run-perf-tests should generate a results page
[WebKit-https.git] / Tools / ChangeLog
1 2012-07-28  Ryosuke Niwa  <rniwa@webkit.org>
2
3         run-perf-tests should generate a results page
4         https://bugs.webkit.org/show_bug.cgi?id=92575
5
6         Reviewed by Eric Seidel.
7
8         Added the ability to generate a results page that summarizes performance test results from
9         multiple runs of run-perf-tests when --output-json-path is specified and --test-results-server
10         is not specified. We cannot generate a results page when --test-results-server is specified
11         because perf-o-matic cannot parse the new JSON format.
12
13         The new JSON format is simply an array of the old JSON output. This JSON is then merged into
14         results-template.html along with jQuery and copied as a HTML file of the same filename as
15         the output JSON file with a .html extension.
16
17         We merge all scripts and the JSON output into the results page as opposed to including them
18         with the src content attribute to make it standalone so that we may post it on Bugzilla or
19         e-mail it to someone else without breaking it.
20
21         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
22         (PerfTestsRunner.run):
23         (PerfTestsRunner._generate_json): Merge "contents" with the existing JSON file when generating
24         a results page, and generate the results page from results-template.html merged with jQuery and
25         the generated JSON output.
26         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
27         (_test_run_with_json_output): Extracted from test_run_with_upload_json to be shared with
28         several test cases.
29         (_test_run_with_json_output.mock_upload_json): Ditto.
30         (test_run_with_json_output): Refactored to use _test_run_with_json_output.
31         (test_run_generates_results_page): Added. Tests the new feature.
32         (test_run_with_json_source): Refactored to use _test_run_with_json_output.
33         (test_run_with_multiple_repositories): Ditto.
34         (test_run_with_upload_json): Ditto.
35
36 2012-07-29  Rik Cabanier  <cabanier@adobe.com>
37
38         Add ENABLE_CSS_COMPOSITING flag
39         https://bugs.webkit.org/show_bug.cgi?id=92553
40
41         Reviewed by Dirk Schulze.
42
43         Adds compiler flag CSS_COMPOSITING to build systems to enable CSS blending and compositing. See spec https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html
44
45         * Scripts/webkitperl/FeatureList.pm:
46
47 2012-07-29  Gustavo Noronha Silva  <gns@gnome.org>
48
49         Reviewed by Martin Robinson.
50
51         Make the jhbuild wrapper scripts become the jhbuild process
52         instead of starting it as a child. This should make it possible to
53         interrupt execution of jhbuild cleanly.
54
55         * gtk/run-with-jhbuild:
56         * jhbuild/jhbuild-wrapper:
57
58 2012-07-29  Mike West  <mkwst@chromium.org>
59
60         Extend `application/x-webkit-test-netscape` plugins to better support multiple frames.
61         https://bugs.webkit.org/show_bug.cgi?id=92478
62
63         Reviewed by Adam Barth.
64
65         DumpRenderTree currently understands
66         `<object src="data:application/x-webkit-test-netscape,alertwhenloaded">`.
67         It would be useful if it understood `logifloaded`, which could give
68         more context regarding test expectations, and can be written in such
69         as way as to support plugins loaded into multiple iframes in a single
70         test.
71
72         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
73         (NPP_New):
74             Adding support for `logifloaded`.
75
76 2012-07-28  Peter Kasting  <pkasting@google.com>
77
78         Fix Chromium/Win compile.
79         https://bugs.webkit.org/show_bug.cgi?id=88787
80
81         Unreviewed, build fix.
82
83         Chromium/Win needs _USE_MATH_DEFINES but doesn't define PLATFORM(WIN).
84         The other files in WebKit that define this macro (both in
85         WebCore/platform/graphics/cg) do it by unconditionally #defining it to 1
86         above the #include of "config.h", so copy that pattern here.
87
88         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
89
90 2012-07-28  Mario Sanchez Prada  <msanchez@igalia.com>
91
92         [WK2][GTK] Implement a new spell checker API for WebKit2GTK+
93         https://bugs.webkit.org/show_bug.cgi?id=90268
94
95         Reviewed by Martin Robinson.
96
97         Ignore WebKitTextChecker.* private files for gtk-doc.
98
99         * gtk/generate-gtkdoc:
100         (get_webkit2_options):
101
102 2012-07-28  Philippe Normand  <pnormand@igalia.com>
103
104         [GTK] Transparent Media controls timeline and panel
105         https://bugs.webkit.org/show_bug.cgi?id=85279
106
107         Reviewed by Martin Robinson.
108
109         * gtk/jhbuild.modules: Provide gnome-themes-standard build
110         support, this is necessary so the media controls panel colors are
111         properly initialized from the GTK+ theme.
112
113 2012-07-27  Kihong Kwon  <kihong.kwon@samsung.com>
114
115         [EFL] Support for HTML media capture
116         https://bugs.webkit.org/show_bug.cgi?id=91842
117
118         Reviewed by Ryosuke Niwa.
119
120         Add HTML media capture feature to the feature list.
121         In addition, enable that on the Efl port.
122
123         * Scripts/webkitperl/FeatureList.pm:
124
125 2012-07-27  Dirk Pranke  <dpranke@chromium.org>
126
127         "webkit-patch rebaseline <test>" fails with exit_code 1
128         https://bugs.webkit.org/show_bug.cgi?id=91560
129
130         Reviewed by Adam Barth.
131
132         webkit-patch rebaseline-json crashes in an svn checkout if it
133         tries to add files and there are no files to add; arguably
134         svn.add() should be robust against this, but rebaseline-json
135         shouldn't be calling it, either. This patch fixes the latter and
136         adds better debugging info to garden-o-matic so we can see what
137         caused the crash.
138
139         * Scripts/webkitpy/tool/commands/rebaseline.py:
140         (AbstractParallelRebaselineCommand._rebaseline):
141         * Scripts/webkitpy/tool/servers/gardeningserver.py:
142         (GardeningHTTPRequestHandler.rebaselineall):
143         (GardeningHTTPRequestHandler.rebaselineall.error_handler):
144         (GardeningHTTPRequestHandler):
145
146 2012-07-27  Brady Eidson  <beidson@apple.com>
147
148         Plugins should not be allowed to override standard properties/attributes in non-standard worlds
149         <rdar://problem/11975252> and https://bugs.webkit.org/show_bug.cgi?id=92519
150
151         Reviewed by Anders Carlsson.
152
153         Add a test plugin which overrides all properties it is asked about:
154         * DumpRenderTree/TestNetscapePlugIn/Tests/PluginScriptableObjectOverridesAllProperties.cpp: Added.
155         (PluginScriptableObjectOverridesAllProperties):
156         (PluginScriptableObjectOverridesAllProperties::PluginScriptableObjectOverridesAllProperties):
157         (PluginObject):
158         (PluginScriptableObjectOverridesAllProperties::PluginObject::PluginObject):
159         (PluginScriptableObjectOverridesAllProperties::PluginObject::~PluginObject):
160         (PluginScriptableObjectOverridesAllProperties::PluginObject::hasProperty):
161         (PluginScriptableObjectOverridesAllProperties::PluginObject::getProperty):
162         (PluginScriptableObjectOverridesAllProperties::NPP_GetValue):
163
164         Expose NPN_MemAlloc to the test plugin:
165         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
166         (PluginTest::NPN_MemAlloc):
167         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
168         (PluginTest):
169
170         * DumpRenderTree/DumpRenderTree.gypi:
171         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
172         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
173         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
174
175 2012-07-27  Rafael Brandao  <rafael.lobo@openbossa.org>
176
177         "webkit-patch upload" should strip colors from patch if necessary
178         https://bugs.webkit.org/show_bug.cgi?id=92306
179
180         Reviewed by Adam Barth.
181
182         * Scripts/webkitpy/common/checkout/scm/git.py: Explicity remove colors from diff.
183
184 2012-07-27  Eric Seidel  <eric@webkit.org>
185
186         clean-pending-commit throws exception when encountering Ossy
187         https://bugs.webkit.org/show_bug.cgi?id=92534
188
189         Reviewed by Adam Barth.
190
191         Mark a couple strings as unicode so that reviewers with unicode names do not cause
192         clean-pending-commit to barf.
193
194         * Scripts/webkitpy/tool/commands/upload.py:
195         (CleanPendingCommit._flags_to_clear_on_patch):
196         (CleanPendingCommit.execute):
197         (AssignToCommitter._assign_bug_to_last_patch_attacher):
198
199 2012-07-27  Dirk Pranke  <dpranke@chromium.org>
200
201         chromium win compile broken after removing webkit.py
202         https://bugs.webkit.org/show_bug.cgi?id=92549
203
204         Unreviewed, build fix.
205
206         It turns out that this file is listed in the chromium downstream
207         'browser_tests.isolate' file, and so deleting it broke gyp.
208         Adding a stub file back in until we can remove the entry from
209         the file.
210
211         * Scripts/webkitpy/layout_tests/port/webkit.py: Added.
212
213 2012-07-27  Dirk Pranke  <dpranke@chromium.org>
214
215         nrwt: remove 'webkit.py' and the 'WebKitPort'
216         https://bugs.webkit.org/show_bug.cgi?id=92450
217
218         Reviewed by Ryosuke Niwa.
219
220         This patch finishes the work of merging WebKitPort into Port.
221         Now Port is way too big :).
222
223         This is all cutting and pasting; no new functionality and
224         no changes in the tests.
225
226         * Scripts/webkitpy/layout_tests/port/apple.py:
227         (ApplePort):
228         (ApplePort.__init__):
229         * Scripts/webkitpy/layout_tests/port/base.py:
230         (Port.skipped_layout_tests):
231         (Port):
232         (Port._port_flag_for_scripts):
233         (Port._arguments_for_configuration):
234         (Port._run_script):
235         (Port._build_driver):
236         (Port._build_driver_flags):
237         (Port._tests_for_other_platforms):
238         (Port._runtime_feature_list):
239         (Port.nm_command):
240         (Port._modules_to_search_for_symbols):
241         (Port._symbols_string):
242         (Port._missing_feature_to_skipped_tests):
243         (Port._missing_symbol_to_skipped_tests):
244         (Port._has_test_in_directories):
245         (Port._skipped_tests_for_unsupported_features):
246         (Port._wk2_port_name):
247         (Port._skipped_file_search_paths):
248         * Scripts/webkitpy/layout_tests/port/chromium.py:
249         (ChromiumPort):
250         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
251         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
252         (ChromiumPortTestCase.test_check_build):
253         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
254         * Scripts/webkitpy/layout_tests/port/efl.py:
255         (EflPort):
256         (EflPort.__init__):
257         * Scripts/webkitpy/layout_tests/port/gtk.py:
258         (GtkPort):
259         (GtkPort.setup_environ_for_server):
260         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
261         (TestWebKitPort):
262         (TestWebKitPort.__init__):
263         (TestWebKitPort.all_test_configurations):
264         (TestWebKitPort._symbols_string):
265         (TestWebKitPort._tests_for_other_platforms):
266         (TestWebKitPort._tests_for_disabled_features):
267         (PortTestCase):
268         (PortTestCase.test_diff_image):
269         (PortTestCase.test_path_to_test_expectations_file):
270         (PortTestCase.test_skipped_directories_for_symbols):
271         (test_skipped_directories_for_features):
272         (test_skipped_directories_for_features_no_matching_tests_in_test_list):
273         (test_skipped_tests_for_unsupported_features_empty_test_list):
274         (test_skipped_layout_tests):
275         (test_skipped_file_search_paths):
276         (test_root_option):
277         (test_test_expectations):
278         (test_build_driver):
279         (_assert_config_file_for_platform):
280         (test_linux_distro_detection):
281         (test_apache_config_file_name_for_platform):
282         (test_path_to_apache_config_file):
283         * Scripts/webkitpy/layout_tests/port/qt.py:
284         (QtPort):
285         (QtPort.__init__):
286         (QtPort.setup_environ_for_server):
287         * Scripts/webkitpy/layout_tests/port/webkit.py: Removed.
288         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Removed.
289         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
290         (get_test_baselines.AllPlatformsPort):
291         (get_test_baselines.AllPlatformsPort.__init__):
292         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
293         (get_test_config.TestMacPort):
294
295 2012-07-27  Christophe Dumez  <christophe.dumez@intel.com>
296
297         [WK2][WTR] LayoutTestController.deliverWebIntent() needs to be implemented
298         https://bugs.webkit.org/show_bug.cgi?id=92228
299
300         Reviewed by Anders Carlsson.
301
302         Implement LayoutTestController.deliverWebIntent() to
303         allow test cases to deliver a Web intent and test this
304         functionality.
305
306         This functionality is needed by:
307         - webintents/web-intents-delivery.html
308
309         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
310         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
311         (WTR::LayoutTestController::deliverWebIntent):
312         (WTR):
313         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
314         (LayoutTestController):
315
316 2012-07-27  Jer Noble  <jer.noble@apple.com>
317
318         Unreviewed build fix.
319
320         Wrap MSVC-specific fixes is a COMPILER() check, not a PLATFORM() check.
321
322         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
323
324 2012-07-27  Xianzhu Wang  <wangxianzhu@chromium.org>
325
326         [Chromium-Android] NRWT better handling of DRT deadlocks and crashes
327         https://bugs.webkit.org/show_bug.cgi?id=92299
328
329         Reviewed by Dirk Pranke.
330
331         1. Changed the deadlock detector thread target from a method of driver to a function to avoid its reference to the
332            current driver (see the bug for the problem of the reference.
333         2. Let the deadlock detector thread exit early when the normal_startup_event is set to avoid it from blocking the main thread when the main thread is exiting.
334         3. Extracted common loop until timeout logic into ChromiumAndroidDriver._loop_with_timeout().
335         4. Use the "for i in range(n)" style suggested by dpranke in https://bugs.webkit.org/show_bug.cgi?id=89124 in several functions.
336
337         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
338         (ChromiumAndroidPort.__init__):
339         (ChromiumAndroidPort._run_adb_command): Reduced the verbose output.
340         (ChromiumAndroidDriver.__init__):
341         (ChromiumAndroidDriver._loop_with_timeout): Extracted common loop until timeout logic here.
342         (ChromiumAndroidDriver._all_pipes_created):
343         (ChromiumAndroidDriver._remove_all_pipes):
344         (ChromiumAndroidDriver._start): Changed the retry loop style.
345         (ChromiumAndroidDriver._start_once): Changed the loop style and code related to deadlock detector.
346         (ChromiumAndroidDriver._start_once.deadlock_detector): Moved the original ChromiumAndroidDriver._deadlock_detector() here.
347         (ChromiumAndroidDriver.stop): Changed the loop style.
348
349 2012-07-27  Dirk Pranke  <dpranke@chromium.org>
350
351         nrwt: move collect_tests(), parse_expectations() into manager
352         https://bugs.webkit.org/show_bug.cgi?id=92423
353
354         Reviewed by Ojan Vafai.
355
356         This is the first in a series of patches refactoring
357         run_webkit_tests.py and manager.py to make them more
358         maintainable; all this patch does is move a couple of functions
359         into manager.run_tests() so manager's public interface is
360         simple.
361
362         * Scripts/webkitpy/layout_tests/controllers/manager.py:
363         (Manager._collect_tests):
364         (Manager._parse_expectations):
365         (Manager._split_into_chunks_if_necessary):
366         (Manager.run):
367         (read_test_files):
368         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
369         (ManagerTest.test_http_locking):
370         (ManagerTest.test_perf_locking):
371         (ManagerTest.integration_test_needs_servers.get_manager_with_tests):
372         (ManagerTest.test_look_for_new_crash_logs.get_manager_with_tests):
373         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
374         (run):
375
376 2012-07-27  Dirk Pranke  <dpranke@chromium.org>
377
378         nrwt: print filtered stderr after a crash correctly
379         https://bugs.webkit.org/show_bug.cgi?id=92428
380
381         Reviewed by Adam Barth.
382
383         Some ports will run the stderr output from DRT/WTR through a
384         filter after a crash in order to print a more useful stack
385         trace; while that gets written to the crash log correctly, we
386         don't log it to the debug output properly. This change fixes
387         that and makes it clearer that we're logging stderr, not the
388         crash log.
389
390         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
391         (SingleTestRunner._handle_error):
392         * Scripts/webkitpy/layout_tests/port/base.py:
393         (Port._get_crash_log):
394         * Scripts/webkitpy/layout_tests/port/chromium.py:
395         (ChromiumPort._get_crash_log):
396         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
397         (ChromiumAndroidPortTest.test_get_crash_log):
398         * Scripts/webkitpy/layout_tests/port/driver.py:
399         (Driver.run_test):
400         * Scripts/webkitpy/layout_tests/port/gtk.py:
401         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
402         * Scripts/webkitpy/layout_tests/port/mac.py:
403         (MacPort._get_crash_log):
404         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
405         (PortTestCase.test_get_crash_log):
406
407 2012-07-27  Dirk Pranke  <dpranke@chromium.org>
408
409         nrwt: move image diffing code to a separate module
410         https://bugs.webkit.org/show_bug.cgi?id=92447
411
412         Reviewed by Ryosuke Niwa.
413
414         This patch moves the code to talk to ImageDiff into its own
415         module, and adds more tests for it. In addition, the patch
416         modifies diff_image() so that we don't automatically stop
417         ImageDiff after a single invocation, and thus subsequent
418         diffs may be slightly faster. (Note that the chromium ports
419         don't use any of this code; that is not changed by this patch).
420
421         The main motivation for this change is to move more "generic"
422         code out of the port/* classes, and in particular to move more
423         code out of webkit.py so that we can eventually eliminate it by
424         merging it into base.py.
425
426         This patch also splits MockServerProcess out from driver_unittest.py
427         so that it can be re-used.
428
429         * Scripts/webkitpy/layout_tests/port/base.py:
430         (Port.__init__):
431         (Port.diff_image):
432         (Port.clean_up_test_run):
433         * Scripts/webkitpy/layout_tests/port/driver.py:
434         (Driver.__init__):
435         (Driver._start):
436         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
437         (DriverTest.test_stop_cleans_up_properly):
438         (DriverTest.test_two_starts_cleans_up_properly):
439         (DriverTest.test_start_actually_starts):
440         * Scripts/webkitpy/layout_tests/port/efl.py:
441         (EflPort.clean_up_test_run):
442         * Scripts/webkitpy/layout_tests/port/gtk.py:
443         (GtkPort.clean_up_test_run):
444         * Scripts/webkitpy/layout_tests/port/image_diff.py: Added.
445         (ImageDiffer):
446         (ImageDiffer.__init__):
447         (ImageDiffer.diff_image):
448         (ImageDiffer._start):
449         (ImageDiffer._read):
450         (ImageDiffer.stop):
451         * Scripts/webkitpy/layout_tests/port/image_diff_unittest.py: Added.
452         (for):
453         (FakePort):
454         (FakePort.__init__):
455         (FakePort._path_to_image_diff):
456         (FakePort.setup_environ_for_server):
457         (TestImageDiffer):
458         (TestImageDiffer.test_diff_image):
459         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
460         (MockDRTPortTest.test_diff_image):
461         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
462         (PortTestCase.test_diff_image__missing_both):
463         (PortTestCase.test_diff_image):
464         (PortTestCase.test_diff_image.make_proc):
465         * Scripts/webkitpy/layout_tests/port/server_process.py:
466         (ServerProcess._start):
467         * Scripts/webkitpy/layout_tests/port/server_process_mock.py: Added.
468         (MockServerProcess):
469         (MockServerProcess.__init__):
470         (MockServerProcess.write):
471         (MockServerProcess.has_crashed):
472         (MockServerProcess.read_stdout_line):
473         (MockServerProcess.read_stdout):
474         (MockServerProcess.pop_all_buffered_stderr):
475         (MockServerProcess.read_either_stdout_or_stderr_line):
476         (MockServerProcess.start):
477         (MockServerProcess.stop):
478         (MockServerProcess.kill):
479         * Scripts/webkitpy/layout_tests/port/webkit.py:
480         (WebKitPort._build_driver_flags):
481         (WebKitPort._symbols_string):
482
483 2012-07-27  Tom Hudson  <hudson@google.com>
484
485         Activate committer bit granted April 6th so I can garden.
486         https://bugs.webkit.org/show_bug.cgi?id=92500
487
488         Reviewed by Jochen Eisinger.
489
490         * Scripts/webkitpy/common/config/committers.py:
491
492 2012-07-27  Jer Noble  <jer.noble@apple.com>
493
494         Support a rational time class for use by media elements.
495         https://bugs.webkit.org/show_bug.cgi?id=88787
496
497         Add unit tests for the WTF::MediaTime class.
498
499         Reviewed by Eric Carlson.
500
501         * TestWebKitAPI/GNUmakefile.am:
502         * TestWebKitAPI/TestWebKitAPI.gypi:
503         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
504         * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Added.
505         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
506         (WTF::operator<<):
507         (TestWebKitAPI):
508         (TestWebKitAPI::TEST):
509
510 2012-07-27  Balazs Kelemen  <kbalazs@webkit.org>
511
512         [NRWT] should have a way to restrict pixel tests for individual directories
513         https://bugs.webkit.org/show_bug.cgi?id=91754
514
515         Unreviewed attempt to fix the chaos I introduced.
516
517         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
518         (WebCore::DumpRenderTree::processLine):
519
520 2012-07-27  YoungTaeck Song  <youngtaeck.song@samsung.com>
521
522         [WK2][EFL] Add an ACCELERATED_COMPOSITING implementation for Efl WebKit2
523         https://bugs.webkit.org/show_bug.cgi?id=91581
524
525         Reviewed by Noam Rosenthal.
526
527         Add a MiniBrowser's option for selecting evas engine.
528
529         * MiniBrowser/efl/main.c:
530         (browserCreate):
531         (main):
532
533 2012-07-27  Sheriff Bot  <webkit.review.bot@gmail.com>
534
535         Unreviewed, rolling out r123869.
536         http://trac.webkit.org/changeset/123869
537         https://bugs.webkit.org/show_bug.cgi?id=92501
538
539         "it did not fix anything but made things even worst"
540         (Requested by kbalazs on #webkit).
541
542         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
543         (WebCore::DumpRenderTree::DumpRenderTree):
544         (WebCore::DumpRenderTree::open):
545         (WebCore::DumpRenderTree::processLine):
546         (WebCore::DumpRenderTree::setDumpPixelsForAllTests):
547         (WebCore::DumpRenderTree::dump):
548         * DumpRenderTree/qt/DumpRenderTreeQt.h:
549         (DumpRenderTree):
550         * DumpRenderTree/qt/main.cpp:
551         (main):
552         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
553         (SingleTestRunner._should_fetch_expected_checksum):
554         (SingleTestRunner._overwrite_baselines):
555         (SingleTestRunner._compare_output):
556         * Scripts/webkitpy/layout_tests/controllers/worker.py:
557         (Worker._update_test_input):
558         * Scripts/webkitpy/layout_tests/port/base.py:
559         (Port.supports_switching_pixel_tests_per_test):
560         (Port):
561         (Port._supports_switching_pixel_tests_per_test):
562         (Port.should_run_as_pixel_test):
563         (Port._should_run_as_pixel_test):
564         * Scripts/webkitpy/layout_tests/port/driver.py:
565         (Driver.cmd_line):
566         (Driver._command_from_driver_input):
567         * Scripts/webkitpy/layout_tests/port/qt.py:
568         (QtPort.check_sys_deps):
569         (QtPort):
570         (QtPort._supports_switching_pixel_tests_per_test):
571         (QtPort._should_run_as_pixel_test):
572         (QtPort._default_pixel_test_directories):
573         * Scripts/webkitpy/layout_tests/port/test.py:
574         (TestPort.supports_switching_pixel_tests_per_test):
575         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
576         (_set_up_derived_options):
577         (parse_args):
578         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
579         (MainTest.test_run_singly_actually_runs_tests):
580         (MainTest.test_pixel_test_directories):
581         * WebKitTestRunner/TestController.cpp:
582         (WTR::TestController::TestController):
583         (WTR::TestController::initialize):
584         (WTR::TestController::runTest):
585         * WebKitTestRunner/TestController.h:
586         (TestController):
587
588 2012-07-27  Balazs Kelemen  <kbalazs@webkit.org>
589
590         [NRWT] should have a way to restrict pixel tests for individual directories
591         https://bugs.webkit.org/show_bug.cgi?id=91754
592
593         Reviewed by Zoltan Herczeg.
594
595         Rollout r123729 because it made Qt debug bots crasy.
596
597         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
598         (WebCore::DumpRenderTree::DumpRenderTree):
599         (WebCore::DumpRenderTree::open):
600         (WebCore::DumpRenderTree::processLine):
601         (WebCore::DumpRenderTree::setDumpPixels):
602         (WebCore::DumpRenderTree::dump):
603         * DumpRenderTree/qt/DumpRenderTreeQt.h:
604         (DumpRenderTree):
605         * DumpRenderTree/qt/main.cpp:
606         (main):
607         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
608         (SingleTestRunner._should_fetch_expected_checksum):
609         (SingleTestRunner._overwrite_baselines):
610         (SingleTestRunner._compare_output):
611         * Scripts/webkitpy/layout_tests/controllers/worker.py:
612         (Worker._update_test_input):
613         * Scripts/webkitpy/layout_tests/port/base.py:
614         (Port.lookup_virtual_test_args):
615         * Scripts/webkitpy/layout_tests/port/driver.py:
616         (Driver.cmd_line):
617         (Driver._command_from_driver_input):
618         * Scripts/webkitpy/layout_tests/port/qt.py:
619         (QtPort.check_sys_deps):
620         * Scripts/webkitpy/layout_tests/port/test.py:
621         (TestPort.virtual_test_suites):
622         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
623         (_set_up_derived_options):
624         (parse_args):
625         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
626         (MainTest.test_run_singly_actually_runs_tests):
627         (MainTest.test_missing_and_unexpected_results):
628         * WebKitTestRunner/TestController.cpp:
629         (WTR::TestController::TestController):
630         (WTR::TestController::initialize):
631         (WTR::TestController::runTest):
632         * WebKitTestRunner/TestController.h:
633         (TestController):
634
635 2012-07-27  Adam Barth  <abarth@webkit.org>
636
637         webkit.review.bot should run clean-review-queue and clean-pending-commit periodically
638         https://bugs.webkit.org/show_bug.cgi?id=92472
639
640         Reviewed by Eric Seidel.
641
642         We need to run these command periodically to keep cruft from
643         accumulating in bugs.webkit.org. Rather than running them manually, we
644         should just have a bot run them. This patch has the style-queue run the
645         commands, which admittedly is a bit odd but it doesn't seem worthwhile
646         to create another bot specifically for this purposes.
647
648         * Scripts/webkitpy/tool/commands/queues.py:
649         (AbstractReviewQueue):
650         (StyleQueue.begin_work_queue):
651         (StyleQueue):
652         (StyleQueue.clean_bugzilla):
653         * Scripts/webkitpy/tool/commands/queues_unittest.py:
654         (StyleQueueTest.test_style_queue_with_style_exception):
655         (test_style_queue_with_watch_list_exception):
656
657 2012-07-27  Dominik Röttsches  <dominik.rottsches@intel.com>
658
659         [Cairo] Add complex font drawing using HarfbuzzNG
660         https://bugs.webkit.org/show_bug.cgi?id=91864
661
662         Reviewed by Simon Hausmann and Martin Robinson.
663
664         Bringing Harfbuzz support to EFL with this patch, so we need HarfBuzz in the pulled in jhbuild dependencies.
665
666         * WebKitTestRunner/CMakeLists.txt: Adding additional header include directories.
667         * efl/jhbuild.modules: Adding source for HarfBuzz release version 0.9.0.
668
669 2012-07-27  KwangYong Choi  <ky0.choi@samsung.com>
670
671         [WK2][EFL][WTR] TestNetscapePlugin is required.
672         https://bugs.webkit.org/show_bug.cgi?id=88756
673
674         Reviewed by Simon Hausmann.
675
676         libTestNetscapePlugin.so should be required for DRT/WTR/EFL.
677
678         * CMakeLists.txt:
679         * DumpRenderTree/TestNetscapePlugin/CMakeList.txt:
680
681 2012-07-27  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
682
683         [EFL] Memory leaks in EFL DRT
684         https://bugs.webkit.org/show_bug.cgi?id=92347
685
686         Reviewed by Simon Hausmann.
687
688         Fix a memory leak in EFL's DRT code by adopting an allocation
689         of JSString created with JSStringCreateWithUTF8CString.
690
691         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
692         (DumpRenderTreeChrome::onWindowObjectCleared):
693
694 2012-07-27  Adam Barth  <abarth@webkit.org>
695
696         Simplify ExpectedFailures
697         https://bugs.webkit.org/show_bug.cgi?id=92216
698
699         Reviewed by Eric Seidel.
700
701         This patch simplifies the ExpectedFailures class we use to remember
702         which tests are currently failing on the bots. When we wrote this code
703         originally, we weren't entirely sure how it would work. Now that we
704         understand it more clearly, we can write the code more clearly.
705
706         * Scripts/webkitpy/tool/bot/expectedfailures.py:
707         (_has_failures):
708         (_is_trustworthy):
709         (ExpectedFailures.__init__):
710         (ExpectedFailures.failures_were_expected):
711         (ExpectedFailures.unexpected_failures_observed):
712         (ExpectedFailures.update):
713         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
714         (ExpectedFailuresTest._assert_can_trust):
715         (ExpectedFailuresTest.test_failures_were_expected):
716         (ExpectedFailuresTest.test_unexpected_failures_observed):
717         (ExpectedFailuresTest.test_unexpected_failures_observed_when_tree_is_hosed):
718         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
719         (PatchAnalysisTask._test):
720         (PatchAnalysisTask._build_and_test_without_patch):
721         (PatchAnalysisTask._test_patch):
722
723 2012-07-27  Csaba Osztrogonác  <ossy@webkit.org>
724
725         [Qt][WK2] REGRESSION(r119127): resetting window.internals settings between tests doesn't work properly
726         https://bugs.webkit.org/show_bug.cgi?id=88064
727
728         Reviewed by Zoltan Herczeg.
729
730         Use resetInternalsObject() instead of injectInternalsObject().
731
732         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
733         (WTR::InjectedBundlePage::resetAfterTest):
734
735 2012-07-26  Ryuan Choi  <ryuan.choi@samsung.com>
736
737         [EFL] Remove forwarding headers from MiniBrowser/Efl.
738         https://bugs.webkit.org/show_bug.cgi?id=91627
739
740         Reviewed by Kentaro Hara.
741
742         * MiniBrowser/efl/CMakeLists.txt: Remove unnecessary forwarding headers.
743
744 2012-07-26  Yoshifumi Inoue  <yosin@chromium.org>
745
746         [Forms] Introduce runtime feature flags for input type datetime, datetimelocal, month, time, week
747         https://bugs.webkit.org/show_bug.cgi?id=92339
748
749         Reviewed by Kent Tamura.
750
751         This patch enables runtime features for input type datetime, datetime-local,
752         month, time and week for Chromium DRT.
753
754         * DumpRenderTree/chromium/TestShell.cpp:
755         (TestShell::TestShell): Call enableInputType{DateTime,DateTimeLocal,Month,Time,Week}.
756
757 2012-07-26  Jeffrey Pfau  <jpfau@apple.com>
758
759         Reloading substitute-data/alternate html string for unreachableURL will add an item to the back-forward-history for each reload
760         https://bugs.webkit.org/show_bug.cgi?id=84041
761
762         Reviewed by Brady Eidson.
763
764         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
765         * TestWebKitAPI/Tests/mac/BackForwardList.mm: Added.
766         (-[BackForwardListTest webView:didFinishLoadForFrame:]):
767         (-[BackForwardListTest webView:didFailProvisionalLoadWithError:forFrame:]):
768         (TestWebKitAPI):
769         (TestWebKitAPI::TEST):
770
771 2012-07-26  Sheriff Bot  <webkit.review.bot@gmail.com>
772
773         Unreviewed, rolling out r123799.
774         http://trac.webkit.org/changeset/123799
775         https://bugs.webkit.org/show_bug.cgi?id=92431
776
777         broke the Apple Mac build (Requested by bweinstein on
778         #webkit).
779
780         * DumpRenderTree/chromium/TestWebPlugin.cpp:
781         * DumpRenderTree/chromium/TestWebPlugin.h:
782         (TestWebPlugin::acceptsInputEvents):
783         (TestWebPlugin::handleInputEvent):
784
785 2012-07-26  Dirk Pranke  <dpranke@chromium.org>
786
787         nrwt: pass --verbose twice on the bots to ensure getting the debug output for now
788         https://bugs.webkit.org/show_bug.cgi?id=92172
789
790         Reviewed by Tony Chang.
791
792         Right now new-run-webkit-tests --verbose prints out too much
793         information (it's like --verbose + debugging). I plan to fix
794         this in bug 88702, and also clean up and simplify all of the
795         --print options, but in preparation for these changes I need to
796         pass --verbose twice to get the same level of output
797         temporarily (for compatibility).
798
799         * Scripts/run-webkit-tests:
800
801 2012-07-26  Sadrul Habib Chowdhury  <sadrul@chromium.org>
802
803         Propagate gesture events to plugins.
804         https://bugs.webkit.org/show_bug.cgi?id=92281
805
806         Reviewed by Adam Barth.
807
808         Update TestWebPlugin to receive events, and output logs for the events.
809
810         * DumpRenderTree/chromium/TestWebPlugin.cpp:
811         (TestWebPlugin::handleInputEvent):
812         * DumpRenderTree/chromium/TestWebPlugin.h:
813         (TestWebPlugin::acceptsInputEvents):
814         (TestWebPlugin):
815
816 2012-07-26  Balazs Kelemen  <kbalazs@webkit.org>
817
818         [nrwt] get rid of --skip-pixel-test-if-no-baseline
819         https://bugs.webkit.org/show_bug.cgi?id=92377
820
821         Reviewed by Adam Barth.
822
823         Remove the option and all code paths that handled it.
824
825         * Scripts/webkitpy/layout_tests/port/base.py:
826         (Port.should_run_as_pixel_test):
827         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
828         (_set_up_derived_options):
829         (parse_args):
830         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
831         (MainTest.test_repeat_each):
832
833 2012-07-26  Olivier Blin  <olivier.blin@softathome.com>
834
835         Add FastMalloc statistics in window.internals
836         https://bugs.webkit.org/show_bug.cgi?id=91274
837
838         Reviewed by Ryosuke Niwa.
839
840         * GNUmakefile.am:
841
842 2012-07-26  Olivier Blin  <olivier.blin@softathome.com>
843
844         Add FastMalloc statistics in window.internals
845         https://bugs.webkit.org/show_bug.cgi?id=91274
846
847         Reviewed by Ryosuke Niwa.
848
849         * GNUmakefile.am:
850
851 2012-07-20  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
852
853         buildbot: Remove the configuration of hfreyther*
854         https://bugs.webkit.org/show_bug.cgi?id=91849
855
856         Reviewed by Adam Roben.
857
858         The machine running these configs was decommissioned and
859         there is no replacement at this point. Remove them from the
860         configuration.
861
862         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove hfreyther* from
863         the config. The Qt Linux SH4 and Qt Linux MIPS schedulers are orphaned, remove
864         them too.
865
866 2012-07-26  Balazs Kelemen  <kbalazs@webkit.org>
867
868         Unreviewed speculative Mac buildfix after r123729 - 2nd attempt.
869
870         * WebKitTestRunner/TestController.cpp:
871         (WTR::TestController::runTest):
872
873 2012-07-26  Balazs Kelemen  <kbalazs@webkit.org>
874
875         Unreviewed speculative buildfix after r123729.
876
877         * WebKitTestRunner/TestController.cpp:
878         (WTR::TestController::runTest): Fix sign errors.
879
880 2012-07-26  Zoltan Nyul  <zoltan.nyul@intel.com>
881
882         [EFL] EFL port should use XDG paths
883         https://bugs.webkit.org/show_bug.cgi?id=91719
884
885         Reviewed by Kenneth Rohde Christiansen.
886
887         The appcache/localstorage/webdatabase path should be set in the
888         ewk_main.cpp instead of the DumpRenderTree, and the XDG_DATA_HOME and
889         XDG_CACHE_HOME should be set to different directory for each processes
890         for the layout-tests.
891
892         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
893         (DumpRenderTreeChrome::initialize):
894         * Scripts/webkitpy/layout_tests/port/efl.py:
895         (EflPort.setup_environ_for_server):
896         * efl/jhbuild.modules:
897
898 2012-07-26  Balazs Kelemen  <kbalazs@webkit.org>
899
900         [NRWT] should have a way to restrict pixel tests for individual directories
901         https://bugs.webkit.org/show_bug.cgi?id=91754
902
903         Reviewed by Dirk Pranke.
904
905         Added --pixel-test-directories option to nrwt. It implies --pixel-tests.
906         If the platform supports this option only tests from these directories will
907         be executed as pixel tests. Furthermore, platforms can have a default set of
908         pixel test directories. To support the feature the test harness have to be
909         able to inform the driver whether to dump pixels for each tests. For this
910         purpose I changed WTR and the Qt DRT to handle a --pixel-test argument from
911         the standard output and made NRWT use this argument with these drivers.
912
913         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
914         (WebCore::DumpRenderTree::DumpRenderTree):
915         (WebCore::DumpRenderTree::open):
916         (WebCore::DumpRenderTree::processLine):
917         (WebCore::DumpRenderTree::setDumpPixelsForAllTests):
918         (WebCore::DumpRenderTree::dump):
919         * DumpRenderTree/qt/DumpRenderTreeQt.h:
920         (DumpRenderTree):
921         * DumpRenderTree/qt/main.cpp:
922         (main):
923         Handle the --pixel-test argument.
924
925         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
926         (SingleTestRunner._should_fetch_expected_checksum):
927         (SingleTestRunner._overwrite_baselines):
928         (SingleTestRunner._compare_output):
929         * Scripts/webkitpy/layout_tests/controllers/worker.py:
930         (Worker._update_test_input):
931         * Scripts/webkitpy/layout_tests/port/base.py:
932         (Port.supports_switching_pixel_tests_per_test): Ports can override this to inform
933         the harness that --pixel-test argument is supported. True for WTR, otherwise calls
934         private version that can be overridden by the actual platform. Only true with WTR
935         and Qt DRT currently. This supposed to exist only temporary until there are ports
936         that doesn't support the feature in their DRT's.
937         (Port):
938         (Port._supports_switching_pixel_tests_per_test):
939         (Port.should_run_as_pixel_test):
940         (Port._should_run_as_pixel_test): Ports can override this to define their
941         default set of pixel tests directories.
942         * Scripts/webkitpy/layout_tests/port/driver.py:
943         (Driver.cmd_line): Don't pass --pixel-tests if the platform supports per test
944         --pixel-test.
945         (Driver._command_from_driver_input): Pass --pixel-test if it is supported and pixel
946         tests are enabled.
947         * Scripts/webkitpy/layout_tests/port/qt.py:
948         (QtPort.check_sys_deps):
949         (QtPort):
950         (QtPort._supports_switching_pixel_tests_per_test):
951         (QtPort._should_run_as_pixel_test):
952         (QtPort._default_pixel_test_directories): Only compositing will be our default pixel
953         test directory for the time being.
954         * Scripts/webkitpy/layout_tests/port/test.py:
955         (TestPort.supports_switching_pixel_tests_per_test):
956         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
957         (_set_up_derived_options):
958         (parse_args):
959         Handle the --pixel-test-directory option. It expect a directory below LayoutTests
960         and can be specified multiple times. Added fixme's that we should improve how we
961         handle these arguments.
962
963         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
964         (MainTest.test_run_singly_actually_runs_tests):
965         (MainTest.test_pixel_test_directories):
966         Added an integration test for the feature.
967
968         * WebKitTestRunner/TestController.cpp:
969         (WTR::TestController::TestController):
970         (WTR::TestController::initialize):
971         (WTR::TestController::runTest):
972         * WebKitTestRunner/TestController.h:
973         (TestController):
974         Handle the --pixel-test argument.
975
976 2012-07-26  Christophe Dumez  <christophe.dumez@intel.com>
977
978         [EFL] Regression(r123604): webintents/web-intents-obj-constructor.html is crashing
979         https://bugs.webkit.org/show_bug.cgi?id=92349
980
981         Reviewed by Kentaro Hara.
982
983         Fix crash occurring after r123604, which replaced strdup()
984         usage with eina_stringshare_add(). Unfortunately, the DRT
985         was not updated accordingly to use eina_stringshare_del()
986         instead of free() on the values returned by Ewk_Intent
987         getters and it was causing
988         webintents/web-intents-obj-constructor.html to crash.
989
990         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
991         (DumpRenderTreeChrome::onFrameIntentNew):
992
993 2012-07-26  Adam Barth  <abarth@webkit.org>
994
995         Unreviewed attempt to fix the chromium-win build.
996
997         * DumpRenderTree/chromium/TestRunner/TestRunner.cpp:
998
999 2012-07-26  Kaustubh Atrawalkar  <kaustubh@motorola.com>
1000
1001         [DRT] LTC:: pageNumberForElementById() could be moved to Internals
1002         https://bugs.webkit.org/show_bug.cgi?id=92091
1003
1004         Reviewed by Adam Barth.
1005
1006         Move the pageNumberForElementById from LayoutTestCotroller to Internals and
1007         remove the old platform specific implementations as it exclusively tests WebCore functionality.
1008
1009         * DumpRenderTree/LayoutTestController.cpp:
1010         (LayoutTestController::staticFunctions):
1011         * DumpRenderTree/LayoutTestController.h:
1012         (LayoutTestController):
1013         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1014         * DumpRenderTree/chromium/LayoutTestController.cpp:
1015         (LayoutTestController::LayoutTestController):
1016         (LayoutTestController::setPrinting):
1017         * DumpRenderTree/chromium/LayoutTestController.h:
1018         (LayoutTestController):
1019         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1020         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1021         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1022         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1023         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1024         (LayoutTestController):
1025         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1026         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1027         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1028         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1029         (WTR):
1030         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1031         (LayoutTestController):
1032
1033 2012-07-25  Adam Barth  <abarth@webkit.org>
1034
1035         TestRunner.a should contain a TestRunner object
1036         https://bugs.webkit.org/show_bug.cgi?id=92313
1037
1038         Reviewed by Kent Tamura.
1039
1040         This patch adds a stub implementation of TestRunner, which is the new
1041         home for our implementation of window.testRunner. A future patch will
1042         migrate functions from LayoutTestController to TestRunner.
1043
1044         * DumpRenderTree/DumpRenderTree.gypi:
1045         * DumpRenderTree/chromium/LayoutTestController.h:
1046         * DumpRenderTree/chromium/TestRunner/TestRunner.cpp: Added.
1047         * DumpRenderTree/chromium/TestRunner/TestRunner.h: Added.
1048
1049 2012-07-25  Wei James  <james.wei@intel.com>
1050
1051         [Chromium] Fix infinite loop issue for chromium android layout test
1052         https://bugs.webkit.org/show_bug.cgi?id=92197
1053
1054         Reviewed by Adam Barth.
1055
1056         The change brought in by r123530 will cause infinite loop when running
1057         Chromium Android Layout Test.
1058         Revert the change for this line only.
1059
1060         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1061         (ChromiumAndroidPort._build_path):
1062
1063 2012-07-25  Adam Barth  <abarth@webkit.org>
1064
1065         Jochen is our a newest reviewer!
1066
1067         * Scripts/webkitpy/common/config/committers.py:
1068
1069 2012-07-25  Jochen Eisinger  <jochen@chromium.org>
1070
1071         [chromium] don't use webkit_support methods directly from test runners but through the test delegate
1072         https://bugs.webkit.org/show_bug.cgi?id=92256
1073
1074         Reviewed by Adam Barth.
1075
1076         This will allow for the content_shell to provide its own implementation
1077         for setting the Gamepad data instead.
1078
1079         * DumpRenderTree/chromium/TestRunner/GamepadController.cpp:
1080         (GamepadController::setDelegate):
1081         (GamepadController::reset):
1082         (GamepadController::connect):
1083         (GamepadController::disconnect):
1084         (GamepadController::setId):
1085         (GamepadController::setButtonCount):
1086         (GamepadController::setButtonData):
1087         (GamepadController::setAxisCount):
1088         (GamepadController::setAxisData):
1089         * DumpRenderTree/chromium/TestRunner/GamepadController.h:
1090         (GamepadController):
1091         * DumpRenderTree/chromium/TestRunner/TestDelegate.h:
1092         (WebKit):
1093         (TestDelegate):
1094         * DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
1095         (TestInterfaces::Internal):
1096         (TestInterfaces::Internal::~Internal):
1097         (TestInterfaces::Internal::setDelegate):
1098         (TestInterfaces::setDelegate):
1099         * DumpRenderTree/chromium/TestRunner/TestInterfaces.h:
1100         (TestInterfaces):
1101         * DumpRenderTree/chromium/TestShell.cpp:
1102         (TestShell::createMainWindow):
1103         (TestShell::~TestShell):
1104         * DumpRenderTree/chromium/WebViewHost.cpp:
1105         (WebViewHost::setGamepadData):
1106         * DumpRenderTree/chromium/WebViewHost.h:
1107         (WebViewHost):
1108
1109 2012-07-25  Christophe Dumez  <christophe.dumez@intel.com>
1110
1111         [WK2][WTR] LayoutTestController.sendWebIntentResponse() needs to be implemented
1112         https://bugs.webkit.org/show_bug.cgi?id=92227
1113
1114         Reviewed by Kenneth Rohde Christiansen.
1115
1116         Implement LayoutTestController.sendWebIntentResponse() so
1117         that a test case can reply to a Web intent request and
1118         test this functionality.
1119
1120         In order to support this functionality, we need to keep
1121         a pointer to the current intent request in
1122         InjectedBundlePage::didReceiveIntentForFrame() so that
1123         we can reuse it later in
1124         LayoutTestController::sendWebIntentResponse().
1125
1126         The following tests need this functionality:
1127         - webintents/web-intents-failure.html
1128         - webintents/web-intents-reply.html
1129
1130         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1131         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1132         (WTR::InjectedBundlePage::didReceiveIntentForFrame):
1133         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1134         (InjectedBundlePage):
1135         (WTR::InjectedBundlePage::currentIntentRequest):
1136         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1137         (WTR::LayoutTestController::sendWebIntentResponse):
1138         (WTR):
1139         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1140         (LayoutTestController):
1141
1142 2012-07-25  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1143
1144         [EFL][WK2][WTR] Alt, Shift and Ctrl keys are not handled by EventSenderProxy.
1145         https://bugs.webkit.org/show_bug.cgi?id=92241
1146
1147         Reviewed by Kenneth Rohde Christiansen.
1148
1149         Alt, Shift and Ctrl keys were not handled by EventSenderProxy.
1150         It caused failure of fast/events/keydown-leftright-keys.html test.
1151
1152         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Added handling of Alt, Shift and Ctrl keys.
1153         (WTR::keyName):
1154
1155 2012-07-25  Christophe Dumez  <christophe.dumez@intel.com>
1156
1157         [EFL][WK2] Fix timeout issues when debugging WebProcess.
1158         https://bugs.webkit.org/show_bug.cgi?id=92245
1159
1160         Reviewed by Dirk Pranke.
1161
1162         Fix timeout issues when debugging the WebProcess
1163         under valgrind or gdb.
1164
1165         * Scripts/webkitpy/layout_tests/port/efl.py:
1166         (EflPort.default_timeout_ms):
1167         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1168         (WTR::TestController::platformInitialize):
1169
1170 2012-07-25  Xianzhu Wang  <wangxianzhu@chromium.org>
1171
1172         [Chromium-Android] NRWT driver should not restart between reftests
1173         https://bugs.webkit.org/show_bug.cgi?id=92267
1174
1175         Reviewed by Dirk Pranke.
1176
1177         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1178         (ChromiumAndroidDriver.start): Resets self._pixel_tests when the pixel_tests parameter changes.
1179
1180 2012-07-25  Tommy Widenflycht  <tommyw@google.com>
1181
1182         MediaStream API: Update MediaStreamTrack to match the specification
1183         https://bugs.webkit.org/show_bug.cgi?id=90180
1184
1185         Reviewed by Adam Barth.
1186
1187         Adding a Mock WebMediaStreamCenter to enable better LayoutTests.
1188
1189         * DumpRenderTree/DumpRenderTree.gypi:
1190         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
1191         (MockWebKitPlatformSupport::createMediaStreamCenter):
1192         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp: Added.
1193         (WebKit):
1194         (WebKit::MockWebMediaStreamCenter::MockWebMediaStreamCenter):
1195         (WebKit::MockWebMediaStreamCenter::queryMediaStreamSources):
1196         (WebKit::MockWebMediaStreamCenter::didEnableMediaStreamTrack):
1197         (WebKit::MockWebMediaStreamCenter::didDisableMediaStreamTrack):
1198         (WebKit::MockWebMediaStreamCenter::didStopLocalMediaStream):
1199         (WebKit::MockWebMediaStreamCenter::didCreateMediaStream):
1200         (WebKit::MockWebMediaStreamCenter::constructSDP):
1201         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp.
1202         (WebKit):
1203         (MockWebMediaStreamCenter):
1204         (WebKit::MockWebMediaStreamCenter::MockWebMediaStreamCenter):
1205
1206 2012-07-25  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1207
1208         [NRWT] Rename baseline_search_path() to default_baseline_search_path()
1209         https://bugs.webkit.org/show_bug.cgi?id=92122
1210
1211         Reviewed by Dirk Pranke.
1212
1213         * Scripts/webkitpy/layout_tests/port/base.py:
1214         (Port.baseline_version_dir):
1215         (Port.baseline_search_path):
1216         (Port):
1217         (Port.default_baseline_search_path):
1218         (Port.expected_baselines):
1219         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1220         (PortTest.test_additional_platform_directory):
1221         * Scripts/webkitpy/layout_tests/port/mac.py:
1222         (MacPort.default_baseline_search_path):
1223         * Scripts/webkitpy/layout_tests/port/qt.py:
1224         (QtPort.default_baseline_search_path):
1225         * Scripts/webkitpy/layout_tests/port/win.py:
1226         (WinPort.default_baseline_search_path):
1227
1228 2012-07-25  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1229
1230         [EFL] Use eina_stringshare_add instead of strdup.
1231         https://bugs.webkit.org/show_bug.cgi?id=92072
1232
1233         Reviewed by Kentaro Hara.
1234
1235         Eina of EFL libraries supports a string functionality that replaces strdup. So, EFL port needs
1236         to replace strdup with eina_stringshare_add function.
1237
1238         DumpRenderTree also needs to be modified according to ewk APIs's parameter change.
1239
1240         * DumpRenderTree/efl/DumpRenderTree.cpp:
1241         (dumpFramesAsText):
1242         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1243         (DumpRenderTreeChrome::onFrameIntentNew):
1244         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1245         (onJavaScriptPrompt):
1246
1247 2012-07-25  Alexander Shalamov  <alexander.shalamov@intel.com>
1248
1249         [WTR][EFL] Wheel events are not emitted
1250         https://bugs.webkit.org/show_bug.cgi?id=92094
1251
1252         Reviewed by Csaba Osztrogonác.
1253
1254         Wheel events are not emitted, therefore, layout tests that use mouseScrollBy method are failing.
1255
1256         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
1257         (WTR::dispatchMouseScrollByEvent):
1258         (WTR::EventSenderProxy::mouseScrollBy):
1259         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1260         (WTR::PlatformWebView::PlatformWebView):
1261         (WTR::PlatformWebView::focus):
1262
1263 2012-07-25  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1264
1265         [EFL][WK2] Add ewk_main.{cpp,h} to EFL WK2
1266         https://bugs.webkit.org/show_bug.cgi?id=92101
1267
1268         Reviewed by Kenneth Rohde Christiansen.
1269
1270         Added a centralized place for general initialization in UI process for EFL WK2.
1271
1272         * MiniBrowser/efl/main.c: Added using of newly added ewk_init() and ewk_shutdown() functions.
1273         (main):
1274         * WebKitTestRunner/efl/main.cpp: Ditto.
1275         (main):
1276
1277 2012-07-24  Benjamin Poulain  <bpoulain@apple.com> && Joseph Pecoraro  <pecoraro@apple.com>
1278
1279         QualifiedName's HashSet should be big enough to hold at least all the static names
1280         https://bugs.webkit.org/show_bug.cgi?id=91891
1281
1282         Reviewed by Darin Adler.
1283
1284         Add a test for WTF::hashTableCapacityForSize.
1285
1286         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1287         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Added.
1288         (InitialCapacityTestHashTraits):
1289         (TestWebKitAPI::testInitialCapacity):
1290         (TestWebKitAPI::generateTestCapacityUpToSize):
1291         (TestWebKitAPI::TEST):
1292
1293 2012-07-24  Adam Barth  <abarth@webkit.org>
1294
1295         The EWS bots get flaky when we hit the failure limit
1296         https://bugs.webkit.org/show_bug.cgi?id=92212
1297
1298         Reviewed by Eric Seidel.
1299
1300         Previously we were missing some failure types, which means we didn't
1301         notice that the bots were hitting the failure limit.
1302
1303         * Scripts/webkitpy/common/net/layouttestresults.py:
1304         (LayoutTestResults.failing_test_results):
1305         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1306         (LayoutTestResultsTest.test_results_from_string):
1307         (LayoutTestResultsTest.test_tests_matching_failure_types):
1308
1309 2012-07-24  Raphael Kubo da Costa  <rakuco@webkit.org>
1310
1311         [EFL] Unreviewed build fix.
1312
1313         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Include unistd.h
1314         for usleep(3).
1315
1316 2012-07-24  Dirk Pranke  <dpranke@chromium.org>
1317
1318         make test-webkitpy at least kinda work in parallel on win32
1319         https://bugs.webkit.org/show_bug.cgi?id=91700
1320
1321         Reviewed by Adam Barth.
1322
1323         This change makes the hoop-jumping we have to do to make running
1324         new-run-webkit-tests in parallel on win32 generic so that we can
1325         re-use it for test-webkitpy as well.
1326
1327         * Scripts/new-run-webkit-tests:
1328         * Scripts/test-webkitpy:
1329         * Scripts/webkitpy/common/multiprocessing_bootstrap.py: Copied from Tools/Scripts/new-run-webkit-tests.
1330         (run):
1331         * Scripts/webkitpy/test/main.py:
1332         (main):
1333         (Tester._log_exception):
1334
1335 2012-07-24  Sheriff Bot  <webkit.review.bot@gmail.com>
1336
1337         Unreviewed, rolling out r123499.
1338         http://trac.webkit.org/changeset/123499
1339         https://bugs.webkit.org/show_bug.cgi?id=92161
1340
1341         Android fails to compile (Requested by zhenyao on #webkit).
1342
1343         * DumpRenderTree/DumpRenderTree.gypi:
1344         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
1345         (MockWebKitPlatformSupport::createMediaStreamCenter):
1346         * DumpRenderTree/chromium/MockWebKitPlatformSupport.h:
1347         (MockWebKitPlatformSupport):
1348         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp: Removed.
1349         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h: Removed.
1350
1351 2012-07-24  Dirk Pranke  <dpranke@chromium.org>
1352
1353         nrwt: never finds binaries in the 'out' dir on chromium win
1354         https://bugs.webkit.org/show_bug.cgi?id=91890
1355
1356         Reviewed by Tony Chang.
1357
1358         Attempt to fix this bug yet again; it turns out that --root and
1359         --build-directory don't have the same meaning (--root should
1360         include the configuration, --build-directory should not).
1361
1362         * Scripts/webkitpy/layout_tests/port/base.py:
1363         (Port._build_path):
1364         * Scripts/webkitpy/layout_tests/port/chromium.py:
1365         (ChromiumPort._static_build_path):
1366         (ChromiumPort.default_results_directory):
1367         (ChromiumPort._build_path):
1368         (ChromiumPort):
1369         (ChromiumPort._build_path_with_configuration):
1370         (ChromiumPort._build_path_with_configuration.does):
1371         (ChromiumPort._path_to_image_diff):
1372         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1373         (ChromiumAndroidPort._build_path):
1374         (ChromiumAndroidPort):
1375         (ChromiumAndroidPort._build_path_with_configuration):
1376         (ChromiumAndroidPort._path_to_driver):
1377         (ChromiumAndroidPort._path_to_forwarder):
1378         (ChromiumAndroidPort._push_executable):
1379         (ChromiumAndroidPort._push_fonts):
1380         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1381         (ChromiumLinuxPort._determine_driver_path_statically):
1382         (ChromiumLinuxPort._modules_to_search_for_symbols):
1383         (ChromiumLinuxPort._path_to_driver):
1384         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1385         (ChromiumLinuxPortTest.test_build_path):
1386         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1387         (ChromiumMacPort._modules_to_search_for_symbols):
1388         (ChromiumMacPort._path_to_driver):
1389         (ChromiumMacPort._path_to_helper):
1390         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1391         (ChromiumMacPortTest.test_build_path):
1392         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1393         (ChromiumWinPort._path_to_driver):
1394         (ChromiumWinPort._path_to_helper):
1395         (ChromiumWinPort._path_to_image_diff):
1396         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1397         (ChromiumWinTest.test_build_path):
1398         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1399         (parse_args):
1400
1401 2012-07-24  Peter Beverloo  <peter@chromium.org>
1402
1403         Android-chromium layout tests failing with GPU related crash
1404         https://bugs.webkit.org/show_bug.cgi?id=92126
1405
1406         Reviewed by Adam Barth.
1407
1408         Remove support for the "--enable-hardware-gpu" flag from run_webkit_tests,
1409         as it's not being used by any port anymore, and neither is being passed
1410         on to the test runner. Instead, append the flag directly to DRT for the
1411         Chromium Android port, which does rely on this functionality.
1412
1413         The ChromiumAndroidUnitTest tests didn't catch this as the property was
1414         set to True, but it's unable to detect whether they'll actually be used.
1415         No occurrances of "--enable-hardware-gpu" exist in either Tools/Scripts/
1416         or Tools/BuildSlaveSupport/, so nothing upstream seems to rely on the flag.
1417
1418         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1419         (ChromiumAndroidPort.__init__):
1420         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1421         (ChromiumAndroidPortTest.test_attributes):
1422         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1423         (parse_args):
1424
1425 2012-07-24  Alexander Shalamov  <alexander.shalamov@intel.com>
1426
1427         [WTR][EFL] Multiple mouse clicks are not emitted in EventSenderProxyEfl
1428         https://bugs.webkit.org/show_bug.cgi?id=92107
1429
1430         Reviewed by Kenneth Rohde Christiansen.
1431
1432         Fixes mouse click events in EventSenderProxyEfl.
1433
1434         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
1435         (WTR::dispatchMouseDownEvent):
1436         (WTR::EventSenderProxy::dispatchEvent):
1437
1438 2012-07-24  Tommy Widenflycht  <tommyw@google.com>
1439
1440         MediaStream API: Update MediaStreamTrack to match the specification
1441         https://bugs.webkit.org/show_bug.cgi?id=90180
1442
1443         Reviewed by Adam Barth.
1444
1445         Adding a Mock WebMediaStreamCenter to enable better LayoutTests.
1446
1447         * DumpRenderTree/DumpRenderTree.gypi:
1448         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
1449         (MockWebKitPlatformSupport::createMediaStreamCenter):
1450         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp: Added.
1451         (WebKit):
1452         (WebKit::MockWebMediaStreamCenter::MockWebMediaStreamCenter):
1453         (WebKit::MockWebMediaStreamCenter::queryMediaStreamSources):
1454         (WebKit::MockWebMediaStreamCenter::didEnableMediaStreamTrack):
1455         (WebKit::MockWebMediaStreamCenter::didDisableMediaStreamTrack):
1456         (WebKit::MockWebMediaStreamCenter::didStopLocalMediaStream):
1457         (WebKit::MockWebMediaStreamCenter::didCreateMediaStream):
1458         (WebKit::MockWebMediaStreamCenter::constructSDP):
1459         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp.
1460         (WebKit):
1461         (MockWebMediaStreamCenter):
1462         (WebKit::MockWebMediaStreamCenter::MockWebMediaStreamCenter):
1463
1464 2012-07-23  Ryosuke Niwa  <rniwa@webkit.org>
1465
1466         Fix regressions in replay performance tests
1467         https://bugs.webkit.org/show_bug.cgi?id=92052
1468
1469         Reviewed by Dirk Pranke.
1470
1471         Fix regression that accumulated over time to make replay tests work again.
1472
1473         * DumpRenderTree/chromium/WebViewHost.cpp:
1474         (WebViewHost::willSendRequest): Use the main document URL in the request since the main frame's
1475         URL hadn't been updated yet When requesting a new URL on the main frame.
1476         * Scripts/webkitpy/performance_tests/perftest.py:
1477         (ReplayServer.wait_until_ready): Waiting for 6 seconds (3 tries) seems enough.
1478         (ReplayPerfTest.prepare): Pass self._archive_path to run_signle as that is the current contract.
1479         (ReplayPerfTest.run_single): Use the archive path to generate -expected.png path.
1480         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1481         (TestReplayPerfTest.test_run_single):
1482         (TestReplayPerfTest.test_prepare):
1483         (TestReplayPerfTest.test_prepare_calls_run_single.run_single):
1484         (TestReplayPerfTest):
1485
1486 2012-07-24  Simon Hausmann  <simon.hausmann@nokia.com>
1487
1488         [Qt] MSVC: unresolved external symbol __DllMainCRTStartup@12
1489         https://bugs.webkit.org/show_bug.cgi?id=91229
1490
1491         Reviewed by Jocelyn Turcotte.
1492
1493         In order to successfully link a DLL on Windows we need to have at least
1494         one object file (or compilation unit). The forward export header files were
1495         supposed to be that, but unfortunately the rule in win32/default_post.prf for
1496         creating the header files had some bugs, among others that it did an exists()
1497         check on the depending static library. At the time qmake is ran those libraries
1498         do not exist yet and therefore the corresponding extra compiler rules were never
1499         created, resulting in empty OBJECTS/SOURCES.
1500
1501         Even without such an exists() check, qmake extra compilers require the files
1502         referred to in the .input variable to exist at qmake time. In this case the input
1503         files were the static libraries, which do not exist yet.
1504
1505         This patch solves this by using a qmake extra target instead of extra
1506         compiler, which does not have this limitation. The target is referenced
1507         through the extension of GENERATED_SOURCES.
1508
1509         The patch also adds a d/_debug suffix for debug builds, do allow for separate
1510         symbol exports if necessary.
1511
1512         * Scripts/generate-win32-export-forwards: Support multiple input files, i.e.
1513         consider the last argument to be the output file and everything else input.
1514         * qmake/mkspecs/features/win32/default_post.prf:
1515
1516 2012-07-24  Balazs Kelemen  <kbalazs@webkit.org>
1517
1518         [Qt] Add quirks for running the web process in a profiler shell, like valgrind
1519         https://bugs.webkit.org/show_bug.cgi?id=87672
1520
1521         Reviewed by Jocelyn Turcotte.
1522
1523         Add --no-timeout-at-all command line switch to not time out no matter how
1524         long the web process does it's job. --no-timeout is not enough for profiling
1525         purposes because it only affects the timeout when we are waiting for the end
1526         of the test. We use another timeout to control how much we wait for the web
1527         process to initialize before and reset after the test and it could also easily
1528         expire when running under valgrind. We should keep the behavior of --no-timeout
1529         to not disable this timout check because --no-timeout is used by performace tests
1530         and those should not wait for the web process to initialize and reset more than
1531         normal tests.
1532
1533         * WebKitTestRunner/TestController.cpp:
1534         (WTR::TestController::TestController):
1535         (WTR::TestController::initialize):
1536         (WTR::TestController::runUntil):
1537         * WebKitTestRunner/TestController.h:
1538
1539 2012-07-24  Peter Beverloo  <peter@chromium.org>
1540
1541         [Chromium] Fix a class/struct mismatch error in TestDelegate.h (showing up on clang)
1542         https://bugs.webkit.org/show_bug.cgi?id=92097
1543
1544         Unreviewed build fix.
1545
1546         WebContextMenuData is declared as a struct in Source/WebKit/chromium/public/WebContextMenuData.h,
1547         but TestDelegate.h forward declares it as a class.
1548
1549         * DumpRenderTree/chromium/TestRunner/TestDelegate.h:
1550         (WebKit):
1551
1552 2012-07-23  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
1553
1554         [Qt] Fix compilation against namespaced Qt
1555
1556         Reviewed by Simon Hausmann.
1557
1558         * QtTestBrowser/launcherwindow.h:
1559         * WebKitTestRunner/PlatformWebView.h:
1560
1561 2012-07-24  Peter Beverloo  <peter@chromium.org>
1562
1563         Update a few Chromium Android contributors in committers.py
1564         https://bugs.webkit.org/show_bug.cgi?id=92090
1565
1566         Reviewed by Kent Tamura.
1567
1568         Add Sami Kyostila, who has been doing significant work on Chromium's
1569         compositor. Add IRC nicknames for John Mellor and Tien-Ren Chen, and
1570         remove John Grabowski who changed projects, and add my webkit.org alias.
1571
1572         * Scripts/webkitpy/common/config/committers.py:
1573
1574 2012-07-24  Pierre Rossi  <pierre.rossi@gmail.com>
1575
1576         [Qt] Enable touch slider when touch events are enabled
1577         https://bugs.webkit.org/show_bug.cgi?id=91013
1578
1579         Reviewed by Kenneth Rohde Christiansen.
1580
1581         TOUCH_SLIDER guards are used in WebCore, so we should really
1582         be setting the corresponding ENABLE define in features.prf.
1583
1584         * qmake/mkspecs/features/features.prf:
1585
1586 2012-07-24  Ryuan Choi  <ryuan.choi@samsung.com>
1587
1588         [EFL] EWebLauncher should not require config.h in the style check
1589         https://bugs.webkit.org/show_bug.cgi?id=92070
1590
1591         Reviewed by Kentaro Hara.
1592
1593         * Scripts/webkitpy/style/checker.py:
1594         Remove the include rules from the style-check for EWebLauncher because
1595         EWebLauncher is simple EFL application.
1596
1597 2012-07-24  Jochen Eisinger  <jochen@chromium.or>
1598
1599         [Chromium] EventSender shouldn't know about TestShell
1600         https://bugs.webkit.org/show_bug.cgi?id=91449
1601
1602         Reviewed by Adam Barth.
1603
1604         Original patch by Adam Barth.
1605
1606         This patch removes the dependency from EventSender to TestShell.  Most
1607         of EventSender works directly with a WebView, but there are a handful
1608         of references to WebViewHost.  We don't want to re-use WebViewHost in
1609         ContentShell because we want to use the multi-process embedding
1610         environment for WebViews.
1611
1612         To avoid the dependency on WebViewHost, this patch introduces
1613         TestDelegate, which is an abstract base class for WebViewHost.  In
1614         ContentShell, we'll need another object to implement these functions.
1615
1616         * DumpRenderTree/chromium/EventSender.cpp:
1617         (EventSender::EventSender):
1618         (EventSender::keyDown):
1619         (makeMenuItemStringsFor):
1620         (EventSender::contextClick):
1621         * DumpRenderTree/chromium/EventSender.h:
1622         (EventSender):
1623         (EventSender::setDelegate):
1624         (EventSender::setWebView):
1625         (EventSender::webview):
1626         * DumpRenderTree/chromium/TestRunner/TestDelegate.h: Added.
1627         (WebKit):
1628         (TestDelegate):
1629         * DumpRenderTree/chromium/TestShell.cpp:
1630         (TestShell::initialize):
1631         (TestShell::createMainWindow):
1632         (TestShell::~TestShell):
1633         * DumpRenderTree/chromium/WebViewHost.cpp:
1634         (WebViewHost::fillSpellingSuggestionList):
1635         * DumpRenderTree/chromium/WebViewHost.h:
1636         (WebViewHost):
1637
1638 2012-07-24  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1639
1640         Make WebIntents and WebIntentsTag a build option for the build-webkit script
1641         https://bugs.webkit.org/show_bug.cgi?id=91841
1642
1643         Reviewed by Philippe Normand.
1644
1645         And it will also be disabled when building with --minimal.
1646
1647         * Scripts/webkitperl/FeatureList.pm:
1648
1649 2012-07-23  Dirk Pranke  <dpranke@chromium.org>
1650
1651         Unreviewed, rolling out r123360.
1652         http://trac.webkit.org/changeset/123360
1653         https://bugs.webkit.org/show_bug.cgi?id=91890
1654
1655         broke the chromium bots
1656
1657         * Scripts/webkitpy/layout_tests/port/chromium.py:
1658         (ChromiumPort._static_build_path):
1659         (ChromiumPort.default_results_directory):
1660         (ChromiumPort._build_path):
1661         (ChromiumPort._path_to_image_diff):
1662         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1663         (ChromiumAndroidPort._build_path):
1664         (ChromiumAndroidPort._path_to_driver):
1665         (ChromiumAndroidPort._path_to_forwarder):
1666         (ChromiumAndroidPort._push_executable):
1667         (ChromiumAndroidPort._push_fonts):
1668         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1669         (ChromiumLinuxPort._determine_driver_path_statically):
1670         (ChromiumLinuxPort._modules_to_search_for_symbols):
1671         (ChromiumLinuxPort._path_to_driver):
1672         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1673         (ChromiumLinuxPortTest.test_build_path):
1674         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1675         (ChromiumMacPort._modules_to_search_for_symbols):
1676         (ChromiumMacPort._path_to_driver):
1677         (ChromiumMacPort._path_to_helper):
1678         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1679         (ChromiumMacPortTest.test_build_path):
1680         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1681         (ChromiumWinPort._path_to_driver):
1682         (ChromiumWinPort._path_to_helper):
1683         (ChromiumWinPort._path_to_image_diff):
1684         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1685         (ChromiumWinTest.test_build_path):
1686
1687 2012-07-23  Adam Barth  <abarth@webkit.org>
1688
1689         [Chromium] TestInterfaces should be responsible for owning and binding AccessibilityController and TextInputController
1690         https://bugs.webkit.org/show_bug.cgi?id=91459
1691
1692         Reviewed by Ryosuke Niwa.
1693
1694         Rather than having TestShell own and bind each of these JavaScript APIs
1695         individually, TestShell should delegate that work to TestInterfaces.
1696         This patch moves AccessibilityController and TextInputController to be
1697         the responsibility of TestInterfaces.
1698
1699         * DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
1700         (TestInterfaces::TestInterfaces):
1701         (TestInterfaces::~TestInterfaces):
1702         (TestInterfaces::setWebView):
1703         (TestInterfaces::bindTo):
1704         (TestInterfaces::resetAll):
1705         * DumpRenderTree/chromium/TestRunner/TestInterfaces.h:
1706         (WebKit):
1707         (TestInterfaces):
1708         (TestInterfaces::accessibilityController):
1709         * DumpRenderTree/chromium/TestShell.cpp:
1710         (TestShell::initialize):
1711         (TestShell::createMainWindow):
1712         (TestShell::~TestShell):
1713         (TestShell::resetTestController):
1714         (TestShell::bindJSObjectsToWindow):
1715         * DumpRenderTree/chromium/TestShell.h:
1716         (TestShell::accessibilityController):
1717         (TestShell):
1718
1719 2012-07-23  Balazs Kelemen  <kbalazs@webkit.org>
1720
1721         nrwt swallows early exceptions
1722         https://bugs.webkit.org/show_bug.cgi?id=91884
1723
1724         Reviewed by Dirk Pranke.
1725
1726         Put everything in a try block so we won't miss any error.
1727
1728         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1729         (run):
1730         (main):
1731
1732 2012-07-23  Christophe Dumez  <christophe.dumez@intel.com>
1733
1734         [WK2] WebKitTestRunner needs to print information about Web intents
1735         https://bugs.webkit.org/show_bug.cgi?id=90873
1736
1737         Reviewed by Anders Carlsson.
1738
1739         Print out information about new intents requests and intent
1740         services registrations in WebKitTestRunner. This is expected
1741         by tests under webintents/*.
1742
1743         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1744         (WTR::InjectedBundlePage::InjectedBundlePage):
1745         (WTR::InjectedBundlePage::didReceiveIntentForFrame):
1746         (WTR):
1747         (WTR::InjectedBundlePage::registerIntentServiceForFrame):
1748         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1749         (InjectedBundlePage):
1750
1751 2012-07-23  Dirk Pranke  <dpranke@chromium.org>
1752
1753         nrwt: never finds binaries in the 'out' dir on chromium win
1754         https://bugs.webkit.org/show_bug.cgi?id=91890
1755
1756         Reviewed by Tony Chang.
1757
1758         We were figuring out which directory look in for binaries by
1759         testing for the base directory (the directory above
1760         Debug/Release). In chromium-win's case, we look in src/build,
1761         which always exists because there are checked-in files in it,
1762         which means we'd always pick that directory over src/out. All of
1763         the other ports' build_path() implementation was including
1764         Debug/Release. If we matched that, we wouldn't have a problem,
1765         so this change fixes that and updates all of the callers of the
1766         chromium ports' implementation to not pass configuration as part
1767         of the path to look up; we still need to pass configuration in
1768         some cases (to test if the build is out of date between debug
1769         and release) so the implementation gets slightly more
1770         complicated.
1771
1772         * Scripts/webkitpy/layout_tests/port/chromium.py:
1773         (ChromiumPort._static_build_path):
1774         (ChromiumPort.default_results_directory):
1775         (ChromiumPort._build_path):
1776         (ChromiumPort._path_to_image_diff):
1777         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1778         (ChromiumAndroidPort._build_path):
1779         (ChromiumAndroidPort._path_to_driver):
1780         (ChromiumAndroidPort._path_to_forwarder):
1781         (ChromiumAndroidPort._push_executable):
1782         (ChromiumAndroidPort._push_fonts):
1783         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1784         (ChromiumLinuxPort._determine_driver_path_statically):
1785         (ChromiumLinuxPort._modules_to_search_for_symbols):
1786         (ChromiumLinuxPort._path_to_driver):
1787         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1788         (ChromiumLinuxPortTest.test_build_path):
1789         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1790         (ChromiumMacPort._modules_to_search_for_symbols):
1791         (ChromiumMacPort._path_to_driver):
1792         (ChromiumMacPort._path_to_helper):
1793         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1794         (ChromiumMacPortTest.test_build_path):
1795         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1796         (ChromiumWinPort._path_to_driver):
1797         (ChromiumWinPort._path_to_helper):
1798         (ChromiumWinPort._path_to_image_diff):
1799         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1800         (ChromiumWinTest.test_build_path):
1801
1802 2012-07-23  Sheriff Bot  <webkit.review.bot@gmail.com>
1803
1804         Unreviewed, rolling out r123339.
1805         http://trac.webkit.org/changeset/123339
1806         https://bugs.webkit.org/show_bug.cgi?id=92006
1807
1808         massive media tests failure (Requested by philn on #webkit).
1809
1810         * Scripts/webkitdirs.pm:
1811         (buildAutotoolsProject):
1812         * gtk/jhbuild.modules:
1813
1814 2012-07-23  Tommy Widenflycht  <tommyw@google.com>
1815
1816         [chromium] MediaStream API: Clean up the MockWebKitPlatformSupport object at shutdown
1817         https://bugs.webkit.org/show_bug.cgi?id=91857
1818
1819         Reviewed by Adam Barth.
1820
1821         Made a few changes so that the destructor could be called at shutdown.
1822
1823         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1824         (WebKitSupportTestEnvironment::WebKitSupportTestEnvironment):
1825         (WebKitSupportTestEnvironment):
1826         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
1827         (MockWebKitPlatformSupport::create):
1828         * DumpRenderTree/chromium/MockWebKitPlatformSupport.h:
1829         (MockWebKitPlatformSupport):
1830         (MockWebKitPlatformSupport::~MockWebKitPlatformSupport):
1831
1832 2012-07-23  Philippe Normand  <pnormand@igalia.com>
1833
1834         [GTK][jhbuild] Switch to GStreamer 0.11 build
1835         https://bugs.webkit.org/show_bug.cgi?id=91727
1836
1837         Reviewed by Gustavo Noronha Silva.
1838
1839         Switch build-webkit --gtk to GStreamer 0.11 support and build the
1840         necessary GStreamer git modules from JHBuild.
1841
1842         * Scripts/webkitdirs.pm:
1843         (buildAutotoolsProject): Build WebKit with GStreamer 0.11 support.
1844         * gtk/jhbuild.modules: GStreamer build support.
1845
1846 2012-07-23  Christophe Dumez  <christophe.dumez@intel.com>
1847
1848         WebKit2 needs layoutTestController.setAlwaysAcceptCookies
1849         https://bugs.webkit.org/show_bug.cgi?id=42778
1850
1851         Reviewed by Kenneth Rohde Christiansen.
1852
1853         Add support for layoutTestController.setAlwaysAcceptCookies()
1854         since it is required by some tests.
1855
1856         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1857         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1858         (WTR::LayoutTestController::setAlwaysAcceptCookies):
1859         (WTR):
1860         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1861         (LayoutTestController):
1862
1863 2012-07-23  Kent Tamura  <tkent@chromium.org>
1864
1865         Rename ENABLE_METER_TAG and ENABLE_PROGRESS_TAG to ENABLE_METER_ELEMENT and ENABLE_PROGRESS_ELEMENT respectively
1866         https://bugs.webkit.org/show_bug.cgi?id=91941
1867
1868         Reviewed by Kentaro Hara.
1869
1870         A flag name for an elmement should be ENABLE_*_ELEMENT.
1871
1872         * Scripts/webkitperl/FeatureList.pm:
1873         * qmake/mkspecs/features/features.pri:
1874
1875 2012-07-22  Kent Tamura  <tkent@chromium.org>
1876
1877         Rename ENABLE_DETAILS to ENABLE_DETAILS_ELEMENT
1878         https://bugs.webkit.org/show_bug.cgi?id=91928
1879
1880         Reviewed by Kentaro Hara.
1881
1882         A flag name for an elmement should be ENABLE_*_ELEMENT.
1883
1884         * Scripts/webkitperl/FeatureList.pm:
1885         * qmake/mkspecs/features/features.pri:
1886
1887 2012-07-20  Kent Tamura  <tkent@chromium.org>
1888
1889         Rename ENABLE_DATALIST to ENABLE_DATALIST_ELEMENT
1890         https://bugs.webkit.org/show_bug.cgi?id=91846
1891
1892         Reviewed by Kentaro Hara.
1893
1894         A flag name for an elmement should be ENABLE_*_ELEMENT.
1895
1896         * Scripts/webkitperl/FeatureList.pm:
1897         * qmake/mkspecs/features/features.pri:
1898
1899 2012-07-20  Xianzhu Wang  <wangxianzhu@chromium.org>
1900
1901         [Chromium-Android] Store test pipes in /data/local/tmp
1902         https://bugs.webkit.org/show_bug.cgi?id=91909
1903
1904         In the previous change (bug 91873, r123258) we placed the pipes in /sdcard/native_tests.
1905         However after tests we found some devices don't allow the app to create pipes there.
1906         So /data/local/tmp is a better place for the pipes.
1907
1908         Reviewed by Adam Barth.
1909
1910         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1911
1912 2012-07-20  Xianzhu Wang  <wangxianzhu@chromium.org>
1913
1914         [Chomium-Android] Place DRT input/output pipes where both app and unrooted shell can read/write
1915         https://bugs.webkit.org/show_bug.cgi?id=91873
1916
1917         Reviewed by Adam Barth.
1918
1919         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1920
1921 2012-07-20  Han Shen  <shenhan@google.com>
1922
1923         [Chromium] Compilation fails under gcc 4.7
1924         https://bugs.webkit.org/show_bug.cgi?id=90227
1925
1926         Reviewed by Tony Chang.
1927
1928         Disable warnings about c++0x compatibility in gcc newer than 4.6.
1929
1930         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1931
1932 2012-07-20  Dirk Pranke  <dpranke@chromium.org>
1933
1934         REGRESSION: run-perf-tests --pause-before-testing is broken
1935         https://bugs.webkit.org/show_bug.cgi?id=91789
1936
1937         Reviewed by Ryosuke Niwa.
1938
1939         Turns out start() wasn't actually starting things :(. Fixed, and
1940         added tests.
1941
1942         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1943         (ChromiumAndroidDriverTest.test_read_prompt):
1944         * Scripts/webkitpy/layout_tests/port/driver.py:
1945         (Driver.__init__):
1946         (Driver._start):
1947         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
1948         (DriverTest.test_read_block):
1949         (DriverTest.test_read_binary_block):
1950         (DriverTest.test_read_base64_block):
1951         (DriverTest.test_stop_cleans_up_properly):
1952         (DriverTest.test_two_starts_cleans_up_properly):
1953         (DriverTest.test_start_actually_starts):
1954         (MockServerProcess.__init__):
1955         (MockServerProcess.start):
1956
1957 2012-07-20  Jochen Eisinger  <jochen@chromium.org>
1958
1959         [chromium] Don't include WebCore headers in TestInterfaces so it's safe to include from outside of WebCore
1960         https://bugs.webkit.org/show_bug.cgi?id=91847
1961
1962         Reviewed by Adam Barth.
1963
1964         This allows for including the TestIntefaces.h from content shell
1965         without introducing a dependency to WebCore/wtf
1966
1967         * DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
1968         (TestInterfaces::Internal):
1969         (TestInterfaces::Internal::Internal):
1970         (TestInterfaces::Internal::~Internal):
1971         (TestInterfaces::Internal::bindTo):
1972         (TestInterfaces::Internal::resetAll):
1973         (TestInterfaces::TestInterfaces):
1974         (TestInterfaces::~TestInterfaces):
1975         (TestInterfaces::bindTo):
1976         (TestInterfaces::resetAll):
1977         * DumpRenderTree/chromium/TestRunner/TestInterfaces.h:
1978         (TestInterfaces):
1979
1980 2012-07-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1981
1982         [Qt] Make WTR use the same color palette as DRT
1983         https://bugs.webkit.org/show_bug.cgi?id=91870
1984
1985         Reviewed by Noam Rosenthal.
1986
1987         Make sure that WebKitTestRunner and DumpRenderTree use the same palette: the
1988         standard from QWindowsStyle.
1989
1990         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1991         (WTR::activateFonts): Moved code to platformInitialize since setting style is not
1992         exactly font related.
1993         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
1994         (WTR::InjectedBundle::platformInitialize): Force the usage of the style's
1995         palette.  Because at this point QApplication was already instantiated, the
1996         default palette was already initialized to be the system one, so we need to
1997         explicitly set the palette to be the standard from style. This is not needed in
1998         DRT because there we set the style before instantiating QApplication.
1999
2000 2012-07-20  Tony Chang  <tony@chromium.org>
2001
2002         Baseline align text in the flakiness dashboard toolbar
2003         https://bugs.webkit.org/show_bug.cgi?id=91784
2004
2005         Reviewed by Ojan Vafai.
2006
2007         Baseline align the flex items.
2008
2009         * TestResultServer/static-dashboards/flakiness_dashboard.css:
2010         (.forms): Add box-align: baseline
2011         (.forms > *): Use block display to force flex items rather than box.
2012         (#tests-form): Add box-align: baseline
2013         (#tests-form > *): Use block display to force flex items rather than box.
2014
2015 2012-07-20  Sheriff Bot  <webkit.review.bot@gmail.com>
2016
2017         Unreviewed, rolling out r123220.
2018         http://trac.webkit.org/changeset/123220
2019         https://bugs.webkit.org/show_bug.cgi?id=91880
2020
2021         broke Debug build (Requested by philn on #webkit).
2022
2023         * Scripts/webkitdirs.pm:
2024         (buildAutotoolsProject):
2025         * gtk/jhbuild.modules:
2026
2027 2012-07-20  Philippe Normand  <pnormand@igalia.com>
2028
2029         [GTK][jhbuild] Switch to GStreamer 0.11 build
2030         https://bugs.webkit.org/show_bug.cgi?id=91727
2031
2032         Reviewed by Gustavo Noronha Silva.
2033
2034         Switch build-webkit --gtk to GStreamer 0.11 support and build the
2035         necessary GStreamer git modules from JHBuild.
2036
2037         * Scripts/webkitdirs.pm:
2038         (buildAutotoolsProject): Build WebKit with GStreamer 0.11 support.
2039         * gtk/jhbuild.modules: GStreamer build support.
2040
2041 2012-07-20  Christophe Dumez  <christophe.dumez@intel.com>
2042
2043         [EFL] Proxy configuration should honor the no_proxy environment variable
2044         https://bugs.webkit.org/show_bug.cgi?id=91747
2045
2046         Reviewed by Kenneth Rohde Christiansen.
2047
2048         Add ProxyResolverSoup to the list of classes that contain GObjects
2049         in style checker script so that it does not complain about naming
2050         convention issues that are mandated by GObject.
2051
2052         * Scripts/webkitpy/style/checker.py:
2053
2054 2012-07-20  Zeno Albisser  <zeno@webkit.org>
2055
2056         [Qt][WK2] Add configure tests for Xrender and GLX.
2057         https://bugs.webkit.org/show_bug.cgi?id=91845
2058
2059         GraphicsSurface on linux requires Xcomposite, Xrender
2060         and GLX. If any of these requirements is not met,
2061         we should disable GraphicsSurface.
2062
2063         Reviewed by Kenneth Rohde Christiansen.
2064
2065         * qmake/config.tests/glx/glx.cpp: Added.
2066         (main):
2067         * qmake/config.tests/glx/glx.pro: Added.
2068         * qmake/config.tests/libXrender/libXrender.cpp: Added.
2069         (main):
2070         * qmake/config.tests/libXrender/libXrender.pro: Added.
2071         * qmake/configure.pri:
2072         * qmake/mkspecs/features/features.prf:
2073
2074 2012-07-20  Kangil Han  <kangil.han@samsung.com>
2075
2076         [EFL][WK2][WTR] Implement EventSenderProxy
2077         https://bugs.webkit.org/show_bug.cgi?id=91731
2078
2079         Reviewed by Kentaro Hara.
2080
2081         This is an initial EFL port implementation of EventSenderProxy.
2082
2083         * WebKitTestRunner/EventSenderProxy.h:
2084         (WTR):
2085         (EventSenderProxy):
2086         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2087         * WebKitTestRunner/PlatformEfl.cmake:
2088         * WebKitTestRunner/TestController.cpp:
2089         (WTR::TestController::TestController):
2090         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2091         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Added.
2092         (WTR):
2093         (WTREvent):
2094         (WTR::WTREvent::WTREvent):
2095         (WTR::KeyEventInfo::KeyEventInfo):
2096         (KeyEventInfo):
2097         (WTR::evasMouseButton):
2098         (WTR::setEvasModifiers):
2099         (WTR::dispatchMouseDownEvent):
2100         (WTR::dispatchMouseUpEvent):
2101         (WTR::dispatchMouseMoveEvent):
2102         (WTR::dispatchMouseScrollByEvent):
2103         (WTR::keyPadName):
2104         (WTR::keyName):
2105         (WTR::EventSenderProxy::EventSenderProxy):
2106         (WTR::EventSenderProxy::updateClickCountForButton):
2107         (WTR::EventSenderProxy::dispatchEvent):
2108         (WTR::EventSenderProxy::replaySavedEvents):
2109         (WTR::EventSenderProxy::sendOrQueueEvent):
2110         (WTR::EventSenderProxy::mouseDown):
2111         (WTR::EventSenderProxy::mouseUp):
2112         (WTR::EventSenderProxy::mouseMoveTo):
2113         (WTR::EventSenderProxy::mouseScrollBy):
2114         (WTR::EventSenderProxy::leapForward):
2115         (WTR::EventSenderProxy::keyDown):
2116         (WTR::EventSenderProxy::addTouchPoint):
2117         (WTR::EventSenderProxy::updateTouchPoint):
2118         (WTR::EventSenderProxy::setTouchModifier):
2119         (WTR::EventSenderProxy::touchStart):
2120         (WTR::EventSenderProxy::touchMove):
2121         (WTR::EventSenderProxy::touchEnd):
2122         (WTR::EventSenderProxy::touchCancel):
2123         (WTR::EventSenderProxy::clearTouchPoints):
2124         (WTR::EventSenderProxy::releaseTouchPoint):
2125         (WTR::EventSenderProxy::cancelTouchPoint):
2126         (WTR::EventSenderProxy::setTouchPointRadius):
2127
2128 2012-07-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2129
2130         Unreviewed, rolling out r123085.
2131         http://trac.webkit.org/changeset/123085
2132         https://bugs.webkit.org/show_bug.cgi?id=91719
2133
2134         r123085 causes crashes on EFL layout test bot.
2135
2136         * WebKitTestRunner/CMakeLists.txt:
2137         * WebKitTestRunner/InjectedBundle/efl/LayoutTestControllerEfl.cpp:
2138         (WTR::LayoutTestController::platformInitialize):
2139
2140 2012-07-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2141
2142         [WTR] Add *explicit* keyword to constructor which has a parameter
2143         https://bugs.webkit.org/show_bug.cgi?id=91745
2144
2145         Reviewed by Adam Barth.
2146
2147         Add *explicit* keyword to contructor which has a parameter in order to avoid implicit type conversion.
2148
2149         * WebKitTestRunner/EventSenderProxy.h:
2150         (EventSenderProxy):
2151         * WebKitTestRunner/TestInvocation.h:
2152         (TestInvocation):
2153
2154 2012-07-19  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2155
2156         [EFL] [WK2] Add methods to get/set a custom text encoding
2157         https://bugs.webkit.org/show_bug.cgi?id=90604
2158
2159         Reviewed by Kenneth Rohde Christiansen.
2160
2161         Added support for setting custom character encoding in MiniBrowser.
2162         Use 'F3' to set the custom character encoding.
2163
2164         * MiniBrowser/efl/main.c:
2165         (on_key_down):
2166
2167 2012-07-19  Dirk Pranke  <dpranke@chromium.org>
2168
2169         webkitpy: executive_unittest still failing when run in parallel
2170         https://bugs.webkit.org/show_bug.cgi?id=91795
2171
2172         Reviewed by Adam Barth.
2173
2174         It turns out that test_kill_process and test_kill_all are both
2175         launching the same process, and so if they're run at the same
2176         time, test_kill_all interferes w/ test_kill_process.
2177
2178         Merging the two tests solves the issue :).
2179
2180         * Scripts/webkitpy/common/system/executive_unittest.py:
2181         (ExecutiveTest.test_kill_process):
2182         (ExecutiveTest._assert_windows_image_name):
2183         (ExecutiveTest):
2184         (ExecutiveTest.test_windows_image_name):
2185
2186 2012-07-19  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2187
2188         [EFL] [WK2] Add a callback to handle delete request in MiniBrowser
2189         https://bugs.webkit.org/show_bug.cgi?id=91483
2190
2191         Reviewed by Dirk Pranke.
2192
2193         Add a callback to handle delete request and quit the main loop when
2194         window is asked to be deleted so that all the resources allocated
2195         for the window will be freed properly.
2196
2197         * MiniBrowser/efl/main.c:
2198         (closeWindow):
2199         (browserCreate):
2200
2201 2012-07-19  No'am Rosenthal  <noam.rosenthal@nokia.com>
2202
2203         [Qt] Enable CSS shaders in Qt (software mode)
2204         https://bugs.webkit.org/show_bug.cgi?id=85140
2205
2206         Reviewed by Simon Hausmann.
2207
2208         Enable CSS_SHADERS when WEBGL and CSS_FILTERS are enabled.
2209
2210         * qmake/mkspecs/features/features.prf:
2211
2212 2012-07-19  No'am Rosenthal  <noam.rosenthal@nokia.com>
2213
2214         [Qt] Enable CSS shaders in Qt (software mode)
2215         https://bugs.webkit.org/show_bug.cgi?id=85140
2216
2217         Reviewed by Simon Hausmann.
2218
2219         Enable CSS_SHADERS when WEBGL and CSS_FILTERS are enabled.
2220
2221         * qmake/mkspecs/features/features.prf:
2222
2223 2012-07-19  Dirk Pranke  <dpranke@chromium.org>
2224
2225         test-webkitpy: fix executive_unittest nits, including a missing 'errno' import
2226         https://bugs.webkit.org/show_bug.cgi?id=91770
2227
2228         Reviewed by Adam Barth.
2229
2230         The missing errno import is causing a flaky failure when run in
2231         parallel on the bots.
2232
2233         * Scripts/webkitpy/common/system/executive_unittest.py:
2234         (ExecutiveTest.assert_interpreter_for_content):
2235
2236 2012-07-19  Oliver Hunt  <oliver@apple.com>
2237
2238         Make style bot handle underscores in names more reasonably
2239         https://bugs.webkit.org/show_bug.cgi?id=91777
2240
2241         Reviewed by Gavin Barraclough.
2242
2243         This patch adds a naming/readability/underscores category for style errors.
2244         That allows us to use underscores in those portions of JSC (and potentially
2245         gtk?) without turning off all naming checks for the effected directories.
2246         We also filter out the DFG_OPERATION warning, and a few other minor changes
2247         to make the style bot less noisy when running over JSC at least.
2248
2249         * Scripts/webkitpy/style/checker.py:
2250         * Scripts/webkitpy/style/checkers/cpp.py:
2251         (check_identifier_name_in_declaration):
2252         (CppChecker):
2253         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2254         (WebKitStyleTest.test_names):
2255
2256 2012-07-19  Dirk Pranke  <dpranke@chromium.org>
2257
2258         config_standalone.py is crashing on apple win's cygwin port
2259         https://bugs.webkit.org/show_bug.cgi?id=91682
2260
2261         Reviewed by Adam Roben.
2262
2263         Work around a weird interaction of ctypes and cygwin that
2264         is causing unit tests to crash for me locally.
2265
2266         * Scripts/webkitpy/common/system/executive.py:
2267         (Executive._win32_check_running_pid):
2268
2269 2012-07-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2270
2271         [GTK] WebKit test runner ignores all system environment variables
2272         https://bugs.webkit.org/show_bug.cgi?id=90284
2273
2274         Reviewed by Dirk Pranke.
2275
2276         Added support in unit test framework to pass a custom environment
2277         variable to the tests by using the --additional-env-var parameter.
2278
2279         * Scripts/webkitpy/layout_tests/port/base.py:
2280         (Port.to.setup_environ_for_server): Adding environment variables
2281         that come through the additional_env_var option.
2282         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2283         (PortTest.test_additional_env_var): Added unit test for the
2284         additional_env_var option
2285         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2286         (parse_args): Added the --additional-env-var parameter.
2287
2288 2012-07-19  Joshua Bell  <jsbell@chromium.org>
2289
2290         Roll out r121610 and r122487 which may have been causing flaky crashes
2291         https://bugs.webkit.org/show_bug.cgi?id=91637
2292
2293         Reviewed by Kentaro Hara.
2294
2295         Flaky crashes started in random tests following r121610. It's not clear
2296         that r121610 is to blame, but we'd like to prove or disprove it.
2297         If this doesn't resolve the crashes, this patch should be rolled out.
2298
2299         * DumpRenderTree/DumpRenderTree.gypi:
2300         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2301         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2302         (PluginTest):
2303         * DumpRenderTree/TestNetscapePlugIn/Tests/LeakWindowScriptableObject.cpp: Removed.
2304
2305 2012-07-19  Pierre Rossi  <pierre.rossi@gmail.com>
2306
2307         [Qt][WK2] Map the elementRect exposed in QML to the view for popup menu
2308         https://bugs.webkit.org/show_bug.cgi?id=91645
2309
2310         Reviewed by Simon Hausmann.
2311
2312         Also improved the logic slightly for edge cases.
2313
2314         * MiniBrowser/qt/qml/ItemSelector.qml:
2315
2316 2012-07-19  Christophe Dumez  <christophe.dumez@intel.com>
2317
2318         [EFL] Bump libsoup dependency to v2.39.4.1 to fix cookie issues
2319         https://bugs.webkit.org/show_bug.cgi?id=91741
2320
2321         Reviewed by Kenneth Rohde Christiansen.
2322
2323         Bump libsoup dependency in jhbuild to v2.39.4.1 to fix issues
2324         with cookies in non-suffixed/private domains [GNOME #679230].
2325
2326         * efl/jhbuild.modules:
2327
2328 2012-07-19  Simon Hausmann  <simon.hausmann@nokia.com>
2329
2330         [Qt] Remove support for Qt versions before 4.8.0
2331         https://bugs.webkit.org/show_bug.cgi?id=91730
2332
2333         Reviewed by Kenneth Rohde Christiansen.
2334
2335         Remove Qt version check #ifdefs for Qt versions before 4.8.0.
2336
2337         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2338         (LayoutTestController::reset):
2339         (LayoutTestController::setAlwaysBlockCookies):
2340         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2341         (LayoutTestController):
2342
2343 2012-07-19  Mario Sanchez Prada  <msanchez@igalia.com>
2344
2345         [GTK] Enable MHTML support by default at build time
2346         https://bugs.webkit.org/show_bug.cgi?id=89987
2347
2348         Reviewed by Carlos Garcia Campos.
2349
2350         Enable MHTML support by default for GTK in build-webkit.
2351
2352         * Scripts/webkitperl/FeatureList.pm:
2353
2354 2012-07-19  Zoltan Nyul  <zoltan.nyul@intel.com>
2355
2356         [EFL][WK2] Using different cache directory for each WTR process
2357         https://bugs.webkit.org/show_bug.cgi?id=91719
2358
2359         Reviewed by Kenneth Rohde Christiansen.
2360
2361         The testrunner script may be running multiple processes in
2362         parallel, and it makes appcache tests fail if they are using the same
2363         directory. I modified the EFL's LayoutTestController to use the
2364         DUMPRENDERTREE_TEMP for application cache directory because it's
2365         different for each process.
2366
2367         * WebKitTestRunner/CMakeLists.txt:
2368         * WebKitTestRunner/InjectedBundle/efl/LayoutTestControllerEfl.cpp:
2369         (WTR::LayoutTestController::platformInitialize):
2370
2371 2012-07-19  Mario Sanchez Prada  <msanchez@igalia.com>
2372
2373         [WK2][GTK] Complete implementation of AccessibilityController in WKTR for GTK
2374         https://bugs.webkit.org/show_bug.cgi?id=89224
2375
2376         Reviewed by Chris Fleizach.
2377
2378         Implement logAccessibilityEvents() and resetToConsistentState(),
2379         so we can ask WKTR from the layout tests for logging all the
2380         accessibility related events into the result.
2381
2382         * WebKitTestRunner/GNUmakefile.am:
2383         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2384         (WTR::AccessibilityController::AccessibilityController):
2385         (WTR):
2386         (WTR::AccessibilityController::logAccessibilityEvents):
2387         (WTR::AccessibilityController::resetToConsistentState):
2388         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2389         (AccessibilityController):
2390         * WebKitTestRunner/InjectedBundle/gtk/AccessibilityControllerGtk.cpp: Added.
2391         (WTR):
2392         (WTR::printAccessibilityEvent):
2393         (WTR::axObjectEventListener):
2394         (WTR::AccessibilityController::logAccessibilityEvents):
2395         (WTR::AccessibilityController::resetToConsistentState):
2396
2397         Ensure we reset the accessibility controller to a consistent
2398         whenever a test has finished running.
2399
2400         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2401         (WTR::InjectedBundle::done):
2402
2403 2012-07-19  Dominik Röttsches  <dominik.rottsches@intel.com>
2404
2405         [EFL][Wk2] Add a bot that runs WTR / WebKit2 tests
2406         https://bugs.webkit.org/show_bug.cgi?id=90788
2407
2408         Reviewed by Kentaro Hara.
2409
2410         Adding EFL 64bit WK2 BuildAndTest bot. At this point, we cannot transfer
2411         the build product from one bot to the other due to link path issues with jhbuild,
2412         so we do a full build and test cycle for WebKit2 on this bot.
2413
2414         * BuildSlaveSupport/build.webkit.org-config/config.json: Adding the new slave.
2415         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Adding a new factory for building and testing WebKit2.
2416         (BuildAndTestWebKit2Factory):
2417
2418 2012-07-18  Mihnea Ovidenie  <mihnea@adobe.com>
2419
2420         Unreviewed. Adding Andrei Bucur, Mihai Balan and Raul Hudea to the contributors list.
2421         They are Adobe contributors working on CSSRegions.
2422
2423         * Scripts/webkitpy/common/config/committers.py:
2424
2425 2012-07-18  Christophe Dumez  <christophe.dumez@intel.com>
2426
2427         [CMake][EFL] Should try to find the same libsoup version pulled by jhbuild
2428         https://bugs.webkit.org/show_bug.cgi?id=91626
2429
2430         Reviewed by Kenneth Rohde Christiansen.
2431
2432         Update jhbuild to pull libsoup 2.39.3 tarball from Gnome FTP instead
2433         of fetching a tag from Gnome GIT. We need to do this to map the version
2434         of libsoup that is required by our CMake config.
2435
2436         * efl/jhbuild.modules:
2437
2438 2012-07-18  MORITA Hajime  <morrita@google.com>
2439
2440         Add window resize benchmark
2441         https://bugs.webkit.org/show_bug.cgi?id=91070
2442
2443         Reviewed by Ryosuke Niwa.
2444
2445         Added some more output filters to take care of html5.html output.
2446
2447         * Scripts/webkitpy/performance_tests/perftest.py:
2448         (PerfTest):
2449
2450 2012-07-18  Dirk Pranke  <dpranke@chromium.org>
2451
2452         nrwt: merge WebKitDriver into Driver
2453         https://bugs.webkit.org/show_bug.cgi?id=91696
2454
2455         Reviewed by Adam Barth.
2456
2457         As part of merging WebKitPort into Port, we also should merge
2458         WebKitDriver into Driver, since all of the non-test Drivers now
2459         inherit from WebKitDriver.
2460
2461         There are no functional changes in this patch, and all the changes should
2462         be covered by the existing tests.
2463
2464         * Scripts/webkitpy/layout_tests/port/base.py:
2465         (Port._driver_class):
2466         * Scripts/webkitpy/layout_tests/port/chromium.py:
2467         (ChromiumPort._check_file_exists):
2468         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2469         (ChromiumAndroidDriver):
2470         (ChromiumAndroidDriver.__init__):
2471         (ChromiumAndroidDriver._drt_cmd_line):
2472         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
2473         (ChromiumAndroidDriverTest.test_read_prompt):
2474         * Scripts/webkitpy/layout_tests/port/driver.py:
2475         (Driver):
2476         (Driver.__init__):
2477         (Driver.__del__):
2478         (Driver.run_test):
2479         (Driver.has_crashed):
2480         (Driver.start):
2481         (Driver._start):
2482         (Driver.stop):
2483         (Driver.cmd_line):
2484         (Driver._check_for_driver_crash):
2485         (Driver._command_from_driver_input):
2486         (Driver._read_first_block):
2487         (Driver._read_optional_image_block):
2488         (Driver._read_header):
2489         (Driver._process_stdout_line):
2490         (Driver._strip_eof):
2491         (Driver._read_block):
2492         (ContentBlock):
2493         (ContentBlock.__init__):
2494         (ContentBlock.decode_content):
2495         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
2496         (DriverTest.make_port):
2497         (DriverTest._assert_wrapper):
2498         (DriverTest.test_read_block):
2499         (DriverTest):
2500         (DriverTest.test_read_binary_block):
2501         (DriverTest.test_read_base64_block):
2502         (DriverTest.test_no_timeout):
2503         (DriverTest.test_check_for_driver_crash):
2504         (DriverTest.test_check_for_driver_crash.FakeServerProcess):
2505         (DriverTest.test_check_for_driver_crash.FakeServerProcess.__init__):
2506         (DriverTest.test_check_for_driver_crash.FakeServerProcess.pid):
2507         (DriverTest.test_check_for_driver_crash.FakeServerProcess.name):
2508         (DriverTest.test_check_for_driver_crash.FakeServerProcess.has_crashed):
2509         (DriverTest.test_check_for_driver_crash.FakeServerProcess.stop):
2510         (DriverTest.test_check_for_driver_crash.assert_crash):
2511         (DriverTest.test_creating_a_port_does_not_write_to_the_filesystem):
2512         (DriverTest.test_stop_cleans_up_properly):
2513         (DriverTest.test_two_starts_cleans_up_properly):
2514         (MockServerProcess):
2515         (MockServerProcess.__init__):
2516         (MockServerProcess.has_crashed):
2517         (MockServerProcess.read_stdout_line):
2518         (MockServerProcess.read_stdout):
2519         (MockServerProcess.read_either_stdout_or_stderr_line):
2520         (MockServerProcess.start):
2521         (MockServerProcess.stop):
2522         (MockServerProcess.kill):
2523         * Scripts/webkitpy/layout_tests/port/gtk.py:
2524         * Scripts/webkitpy/layout_tests/port/webkit.py:
2525         (WebKitPort._read_image_diff):
2526         (WebKitPort.skipped_layout_tests):
2527         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2528         (test_path_to_apache_config_file):
2529         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
2530         (XvfbDriver):
2531         (XvfbDriver.stop):
2532
2533 2012-07-18  Dirk Pranke  <dpranke@chromium.org>
2534
2535         webkitpy.common.system.executive_unittest.ExecutiveTest.test_kill_process is flaky
2536         https://bugs.webkit.org/show_bug.cgi?id=91698
2537
2538         Unreviewed, build fix.
2539
2540         This is a workaround for the test failing (apparently mostly?)
2541         when run in parallel with other tests. The underlying bug still
2542         needs to be diagnosed as we shouldn't be getting ECHILD from
2543         process.wait().
2544
2545         * Scripts/webkitpy/common/system/executive_unittest.py:
2546         (ExecutiveTest.test_kill_process):
2547
2548 2012-07-18  Dirk Pranke  <dpranke@chromium.org>
2549
2550         Disable running python unit tests in parallel on win32 for now.
2551         https://bugs.webkit.org/show_bug.cgi?id=91697
2552
2553         Unreviewed, build fix.
2554
2555         * Scripts/webkitpy/test/main.py:
2556         (Tester._parse_args):
2557
2558 2012-07-18  Dave Tu  <dtu@chromium.org>
2559
2560         [chromium] Add gl_tests to flakiness dashboard.
2561         https://bugs.webkit.org/show_bug.cgi?id=91680
2562
2563         Reviewed by Dirk Pranke.
2564
2565         * TestResultServer/static-dashboards/builders.js:
2566         (loadBuildersList):
2567         * TestResultServer/static-dashboards/dashboard_base.js:
2568         (currentBuilderGroupCategory):
2569
2570 2012-07-18  Dirk Pranke  <dpranke@chromium.org>
2571
2572         fix python unit tests failing under cygwin
2573         https://bugs.webkit.org/show_bug.cgi?id=91678
2574
2575         Reviewed by Adam Barth.
2576
2577         Fix a case where executive.kill_process was failing under cygwin
2578         (apple win port) in an unexpected way.
2579         
2580         * Scripts/webkitpy/common/system/executive.py:
2581         (Executive.kill_process):
2582
2583 2012-07-18  Dirk Pranke  <dpranke@chromium.org>
2584
2585         test-webkitpy: run tests in parallel by default
2586         https://bugs.webkit.org/show_bug.cgi?id=91422
2587
2588         Reviewed by Adam Barth.
2589
2590         We use multiprocessing.cpu_count() for the default number of
2591         jobs to run; memory overhead should be very low, so this should
2592         be fine.
2593
2594         * Scripts/webkitpy/test/main.py:
2595         (Tester._parse_args):
2596
2597 2012-07-18  Ryosuke Niwa  <rniwa@webkit.org>
2598
2599         Add Pravin D to the list of contributors.
2600
2601         * Scripts/webkitpy/common/config/committers.py:
2602
2603 2012-07-18  Balazs Kelemen  <kbalazs@webkit.org>
2604
2605         [Qt] feature detection in orwt/nrwt does not work with force_static_libs_as_shared
2606         https://bugs.webkit.org/show_bug.cgi?id=91514
2607
2608         Reviewed by Dirk Pranke.
2609
2610         Analyzing libQtWebKit.so is not enough in the case of force_static_libs_as_shared.
2611         We need to analyze all the shared library or at least the WebCore one.
2612
2613         * Scripts/webkitdirs.pm:
2614         (builtDylibPathForName):
2615         In orwt it is hard coded to search for symbols in the WebCore library.
2616         While in theory it is possible that symbols for a given feature are not
2617         located in that, it doesn't happen in practice, so returning the path of
2618         the WebCore library for a force_static_libs_as_shared build is enough to
2619         fix the bug and it doesn't require a bigger refactoring. For a default
2620         build we still return the path of the QtWebKit lib.
2621         * Scripts/webkitpy/layout_tests/port/qt.py:
2622         (QtPort._modules_to_search_for_symbols):
2623         Enumerate all dynamic libraries, not just the QtWebKit one.
2624
2625 2012-07-18  Tony Chang  <tony@chromium.org>
2626
2627         [chromium] Unreviewed, more compile fixes on Chromium Win.
2628
2629         * DumpRenderTree/chromium/TestShellWin.cpp:
2630         (TestShell::waitTestFinished):
2631         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
2632
2633 2012-07-18  Christophe Dumez  <christophe.dumez@intel.com>
2634
2635         [EFL] Add central error management to EFL port
2636         https://bugs.webkit.org/show_bug.cgi?id=91598
2637
2638         Reviewed by Kenneth Rohde Christiansen.
2639
2640         Map WebKitNetworkError to NSURLErrorDomain when
2641         printing in DumpRenderTree so that the output
2642         matches the expected one.
2643
2644         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2645         (descriptionSuitableForTestResult):
2646
2647 2012-07-18  Dirk Pranke  <dpranke@chromium.org>
2648
2649         nrwt: start merging port/webkit.py into port/base.py
2650         https://bugs.webkit.org/show_bug.cgi?id=91559
2651
2652         Reviewed by Ojan Vafai.
2653
2654         Since all the non-test port implementations now derive from
2655         WebKitPort, there's no real point in keeping WebKitPort distinct
2656         from Port. This patch starts merging the two by moving nearly
2657         all of the webkit implementations of routines with no default
2658         behavior into base.py. The few that didn't move rely on
2659         additional infrastructure that should be refactored differently
2660         (like the image diffing, which should probably be its own
2661         class) and deserve their own patches.
2662
2663         This patch should just be moving code around, and require no
2664         additional tests; in fact, we can delete the tests that were
2665         asserting virtual methods in the base class.
2666
2667         * Scripts/webkitpy/layout_tests/port/base.py:
2668         (Port.baseline_search_path):
2669         (Port.check_build):
2670         (Port):
2671         (Port._check_driver):
2672         (Port._check_port_build):
2673         (Port.check_image_diff):
2674         (Port.driver_name):
2675         (Port.default_results_directory):
2676         (Port.to.setup_environ_for_server):
2677         (Port._path_to_apache):
2678         (Port._is_redhat_based):
2679         (Port._is_debian_based):
2680         (Port._apache_config_file_name_for_platform):
2681         (Port._path_to_apache_config_file):
2682         (Port._build_path):
2683         (Port._path_to_driver):
2684         (Port._path_to_webcore_library):
2685         (Port._path_to_helper):
2686         (Port._path_to_image_diff):
2687         (Port._path_to_wdiff):
2688         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2689         (PortTest.test_httpd_returns_error_code):
2690         * Scripts/webkitpy/layout_tests/port/webkit.py:
2691         (WebKitPort):
2692         (WebKitPort._build_driver_flags):
2693         (WebKitPort._read_image_diff):
2694         (WebKitPort.skipped_layout_tests):
2695
2696 2012-07-18  Tommy Widenflycht  <tommyw@google.com>
2697
2698         [chromium] MediaStream API: Moving the mock create* WebRTC calls into a shadow Platform class
2699         https://bugs.webkit.org/show_bug.cgi?id=86215
2700
2701         Reviewed by Adam Barth.
2702
2703         Adding a shadow Platform object that is used to override some WebKit::Platform funtions to
2704         instead create mock objects. No actual mock objects created yet.
2705
2706         * DumpRenderTree/DumpRenderTree.gypi:
2707         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2708         (WebKitSupportTestEnvironment::WebKitSupportTestEnvironment):
2709         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp: Copied from Tools/DumpRenderTree/chromium/config.h.
2710         (MockWebKitPlatformSupport::create):
2711         (MockWebKitPlatformSupport::MockWebKitPlatformSupport):
2712         (MockWebKitPlatformSupport::cryptographicallyRandomValues):
2713         (MockWebKitPlatformSupport::createMediaStreamCenter):
2714         * DumpRenderTree/chromium/MockWebKitPlatformSupport.h: Copied from Tools/DumpRenderTree/chromium/config.h.
2715         (MockWebKitPlatformSupport):
2716         * DumpRenderTree/chromium/config.h:
2717
2718 2012-07-18  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2719
2720         [CMake][EFL] Build and run TestWebKitAPI unit tests
2721         https://bugs.webkit.org/show_bug.cgi?id=90671
2722
2723         Reviewed by Daniel Bates.
2724
2725         This patch enables almost for free a significant amount of test for the
2726         WebKit C API, WTF and KURL. It makes easy for CMake based ports to
2727         enable TestWebKitAPI since the missing bits to implement are
2728         relatively simple.
2729
2730         * CMakeLists.txt:
2731         * TestWebKitAPI/CMakeLists.txt: Added.
2732         * TestWebKitAPI/PlatformEfl.cmake: Added.
2733         * TestWebKitAPI/PlatformWebView.h:
2734         * TestWebKitAPI/config.h:
2735         * TestWebKitAPI/efl/InjectedBundleController.cpp: Added.
2736         (TestWebKitAPI):
2737         (TestWebKitAPI::InjectedBundleController::platformInitialize):
2738         * TestWebKitAPI/efl/PlatformUtilities.cpp: Added.
2739         (TestWebKitAPI):
2740         (Util):
2741         (TestWebKitAPI::Util::run):
2742         (TestWebKitAPI::Util::sleep):
2743         (TestWebKitAPI::Util::createURLForResource):
2744         (TestWebKitAPI::Util::createInjectedBundlePath):
2745         (TestWebKitAPI::Util::URLForNonExistentResource):
2746         * TestWebKitAPI/efl/PlatformWebView.cpp: Added.
2747         (TestWebKitAPI):
2748         (TestWebKitAPI::initEcoreEvas):
2749         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2750         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2751         (TestWebKitAPI::PlatformWebView::page):
2752         * TestWebKitAPI/efl/main.cpp: Added.
2753         (checkForUseX11WindowArgument):
2754         (main):
2755
2756 2012-07-18  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2757
2758         [CMake][EFL] Building jsc causes reconfiguration
2759         https://bugs.webkit.org/show_bug.cgi?id=91387
2760
2761         Reviewed by Daniel Bates.
2762
2763         We should remove CMakeCache only when running build-webkit script,
2764         otherwise it will cause a reconfiguration every time someone calls
2765         generateBuildSystemFromCMakeProject(). We were re-building "jsc" and
2766         not running WebKit2 unit tests on the bots because the project was
2767         reconfigured with default values by the scripts that run these tests.
2768
2769         * Scripts/build-webkit:
2770         * Scripts/webkitdirs.pm:
2771         (removeCMakeCache):
2772         (generateBuildSystemFromCMakeProject):
2773
2774 2012-07-18  Seokju Kwon  <seokju.kwon@samsung.com>
2775
2776         [EFL][DRT] Add support for Web Inspector in WebKit-EFL DRT
2777         https://bugs.webkit.org/show_bug.cgi?id=87935
2778
2779         Reviewed by Andreas Kling.
2780
2781         Web Inspector will be shown when path or url contains "inspector/".
2782         Dumprendertree should wait util web inspector resources are loaded totally
2783         and handle the signals for creating or removing a view of web inspector.
2784         ("inspector,view,create" and "inspector,view,close")
2785
2786         * DumpRenderTree/efl/DumpRenderTree.cpp:
2787         (shouldOpenWebInspector):
2788         (createLayoutTestController):
2789         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2790         (DumpRenderTreeChrome::createView):
2791         (DumpRenderTreeChrome::createWebInspectorView):
2792         (DumpRenderTreeChrome::removeWebInspectorView):
2793         (DumpRenderTreeChrome::waitInspectorLoadFinished):
2794         (DumpRenderTreeChrome::onInspectorViewCreate):
2795         (DumpRenderTreeChrome::onInspectorViewClose):
2796         (DumpRenderTreeChrome::onInspectorFrameLoadFinished):
2797         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
2798         (DumpRenderTreeChrome):
2799         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2800         (onConsoleMessage):
2801         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2802         (LayoutTestController::showWebInspector):
2803         (LayoutTestController::closeWebInspector):
2804         (LayoutTestController::evaluateInWebInspector):
2805
2806 2012-07-18  Simon Hausmann  <simon.hausmann@nokia.com>
2807
2808         [ANGLE] On QT, use Bison and Flex during ANGLE build
2809         https://bugs.webkit.org/show_bug.cgi?id=91108
2810
2811         Reviewed by Kenneth Rohde Christiansen.
2812
2813         * qmake/mkspecs/features/default_post.prf: Add support for variable_out to our generators, to allow
2814         generating not only for SOURCES but also ANGLE_SOURCES (in this bug)
2815
2816 2012-07-18  Balazs Kelemen  <kbalazs@webkit.org>
2817
2818         [Qt] plugin tests should not be disabled for WebKit1
2819         https://bugs.webkit.org/show_bug.cgi?id=91604
2820
2821         Reviewed by Simon Hausmann.
2822
2823         Instead of not building TestNetscapePlugIn, we could programatically
2824         disable actually loading it from WTR until https://bugs.webkit.org/show_bug.cgi?id=86620
2825         has been solved, so we can still test plugins on WebKit1.
2826
2827         * Tools.pro:
2828         * WebKitTestRunner/TestController.cpp:
2829         (WTR::TestController::initialize):
2830         * WebKitTestRunner/qt/TestControllerQt.cpp:
2831         (WTR::TestController::initializeTestPluginDirectory):
2832
2833 2012-07-18  Mario Sanchez Prada  <msanchez@igalia.com>
2834
2835         [WK2][GTK] Implement AccessibilityUIElement in WKTR for GTK
2836         https://bugs.webkit.org/show_bug.cgi?id=89223
2837
2838         Reviewed by Chris Fleizach.
2839
2840         Implemented AccessibilityUIElement in WKTR for GTK, based in the
2841         implementation present in DumpRenderTree.
2842
2843         Added new files in gtk/ and updated the cross-platform ones.
2844
2845         * WebKitTestRunner/GNUmakefile.am:
2846         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2847         (WTR):
2848         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2849         (AccessibilityUIElement):
2850         * WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp: Added.
2851         (WTR):
2852         (WTR::attributeSetToString):
2853         (WTR::checkElementState):
2854         (WTR::indexRangeInTable):
2855         (WTR::alterCurrentValue):
2856         (WTR::AccessibilityUIElement::AccessibilityUIElement):
2857         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
2858         (WTR::AccessibilityUIElement::isEqual):
2859         (WTR::AccessibilityUIElement::getChildren):
2860         (WTR::AccessibilityUIElement::getChildrenWithRange):
2861         (WTR::AccessibilityUIElement::childrenCount):
2862         (WTR::AccessibilityUIElement::elementAtPoint):
2863         (WTR::AccessibilityUIElement::indexOfChild):
2864         (WTR::AccessibilityUIElement::childAtIndex):
2865         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
2866         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
2867         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
2868         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
2869         (WTR::AccessibilityUIElement::rowAtIndex):
2870         (WTR::AccessibilityUIElement::selectedChildAtIndex):
2871         (WTR::AccessibilityUIElement::selectedChildrenCount):
2872         (WTR::AccessibilityUIElement::selectedRowAtIndex):
2873         (WTR::AccessibilityUIElement::titleUIElement):
2874         (WTR::AccessibilityUIElement::parentElement):
2875         (WTR::AccessibilityUIElement::disclosedByRow):
2876         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
2877         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
2878         (WTR::AccessibilityUIElement::attributesOfChildren):
2879         (WTR::AccessibilityUIElement::allAttributes):
2880         (WTR::AccessibilityUIElement::stringAttributeValue):
2881         (WTR::AccessibilityUIElement::numberAttributeValue):
2882         (WTR::AccessibilityUIElement::uiElementAttributeValue):
2883         (WTR::AccessibilityUIElement::boolAttributeValue):
2884         (WTR::AccessibilityUIElement::isAttributeSettable):
2885         (WTR::AccessibilityUIElement::isAttributeSupported):
2886         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
2887         (WTR::AccessibilityUIElement::role):
2888         (WTR::AccessibilityUIElement::subrole):
2889         (WTR::AccessibilityUIElement::roleDescription):
2890         (WTR::AccessibilityUIElement::title):
2891         (WTR::AccessibilityUIElement::description):
2892         (WTR::AccessibilityUIElement::orientation):
2893         (WTR::AccessibilityUIElement::stringValue):
2894         (WTR::AccessibilityUIElement::language):
2895         (WTR::AccessibilityUIElement::helpText):
2896         (WTR::AccessibilityUIElement::x):
2897         (WTR::AccessibilityUIElement::y):
2898         (WTR::AccessibilityUIElement::width):
2899         (WTR::AccessibilityUIElement::height):
2900         (WTR::AccessibilityUIElement::clickPointX):
2901         (WTR::AccessibilityUIElement::clickPointY):
2902         (WTR::AccessibilityUIElement::intValue):
2903         (WTR::AccessibilityUIElement::minValue):
2904         (WTR::AccessibilityUIElement::maxValue):
2905         (WTR::AccessibilityUIElement::valueDescription):
2906         (WTR::AccessibilityUIElement::insertionPointLineNumber):
2907         (WTR::AccessibilityUIElement::isActionSupported):
2908         (WTR::AccessibilityUIElement::isEnabled):
2909         (WTR::AccessibilityUIElement::isRequired):
2910         (WTR::AccessibilityUIElement::isFocused):
2911         (WTR::AccessibilityUIElement::isSelected):
2912         (WTR::AccessibilityUIElement::isExpanded):
2913         (WTR::AccessibilityUIElement::isChecked):
2914         (WTR::AccessibilityUIElement::hierarchicalLevel):
2915         (WTR::AccessibilityUIElement::speak):
2916         (WTR::AccessibilityUIElement::ariaIsGrabbed):
2917         (WTR::AccessibilityUIElement::ariaDropEffects):
2918         (WTR::AccessibilityUIElement::lineForIndex):
2919         (WTR::AccessibilityUIElement::rangeForLine):
2920         (WTR::AccessibilityUIElement::rangeForPosition):
2921         (WTR::AccessibilityUIElement::boundsForRange):
2922         (WTR::AccessibilityUIElement::stringForRange):
2923         (WTR::AccessibilityUIElement::attributedStringForRange):
2924         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
2925         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2926         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
2927         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
2928         (WTR::AccessibilityUIElement::attributesOfColumns):
2929         (WTR::AccessibilityUIElement::attributesOfRows):
2930         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
2931         (WTR::AccessibilityUIElement::attributesOfHeader):
2932         (WTR::AccessibilityUIElement::rowCount):
2933         (WTR::AccessibilityUIElement::columnCount):
2934         (WTR::AccessibilityUIElement::indexInTable):
2935         (WTR::AccessibilityUIElement::rowIndexRange):
2936         (WTR::AccessibilityUIElement::columnIndexRange):
2937         (WTR::AccessibilityUIElement::cellForColumnAndRow):
2938         (WTR::AccessibilityUIElement::horizontalScrollbar):
2939         (WTR::AccessibilityUIElement::verticalScrollbar):
2940         (WTR::AccessibilityUIElement::selectedTextRange):
2941         (WTR::AccessibilityUIElement::setSelectedTextRange):
2942         (WTR::AccessibilityUIElement::increment):
2943         (WTR::AccessibilityUIElement::decrement):
2944         (WTR::AccessibilityUIElement::showMenu):
2945         (WTR::AccessibilityUIElement::press):
2946         (WTR::AccessibilityUIElement::setSelectedChild):
2947         (WTR::AccessibilityUIElement::accessibilityValue):
2948         (WTR::AccessibilityUIElement::documentEncoding):
2949         (WTR::AccessibilityUIElement::documentURI):
2950         (WTR::AccessibilityUIElement::url):
2951         (WTR::AccessibilityUIElement::addNotificationListener):
2952         (WTR::AccessibilityUIElement::removeNotificationListener):
2953         (WTR::AccessibilityUIElement::isFocusable):
2954         (WTR::AccessibilityUIElement::isSelectable):
2955         (WTR::AccessibilityUIElement::isMultiSelectable):
2956         (WTR::AccessibilityUIElement::isVisible):
2957         (WTR::AccessibilityUIElement::isOffScreen):
2958         (WTR::AccessibilityUIElement::isCollapsed):
2959         (WTR::AccessibilityUIElement::isIgnored):
2960         (WTR::AccessibilityUIElement::hasPopup):
2961         (WTR::AccessibilityUIElement::takeFocus):
2962         (WTR::AccessibilityUIElement::takeSelection):
2963         (WTR::AccessibilityUIElement::addSelection):
2964         (WTR::AccessibilityUIElement::removeSelection):
2965         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
2966         (WTR::AccessibilityUIElement::textMarkerRangeLength):
2967         (WTR::AccessibilityUIElement::previousTextMarker):
2968         (WTR::AccessibilityUIElement::nextTextMarker):
2969         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
2970         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
2971         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
2972         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
2973         (WTR::AccessibilityUIElement::textMarkerForPoint):
2974         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
2975         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
2976         (WTR::AccessibilityUIElement::indexForTextMarker):
2977         (WTR::AccessibilityUIElement::isTextMarkerValid):
2978         (WTR::AccessibilityUIElement::textMarkerForIndex):
2979
2980         Add documentEncoding and documentURI to AccessibilityUIElement.idl.
2981
2982         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2983
2984 2012-07-18  Alexis Menard  <alexis.menard@openbossa.org>
2985
2986         [EFL] Build fix in WebKitTestRunner.
2987         https://bugs.webkit.org/show_bug.cgi?id=91567
2988
2989         Reviewed by Kentaro Hara.
2990
2991         sleep() is defined in unistd.h, we need to include it.
2992
2993         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2994
2995 2012-07-18  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2996
2997         [NRWT] Unreviewed gardening after r122913
2998         https://bugs.webkit.org/show_bug.cgi?id=91601
2999
3000         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
3001         (TrivialMockPort.process_kill_time):
3002
3003 2012-07-17  Xianzhu Wang  <wangxianzhu@chromium.org>
3004
3005         [Chromium-Android] Run ref tests together to avoid expensive driver restarts
3006         https://bugs.webkit.org/show_bug.cgi?id=91533
3007
3008         Reviewed by Dirk Pranke.
3009
3010         Though DriverProxy maintains two drivers to support pixel tests and non-pixel tests,
3011         chromium-android uses another way because it can't support multiple drivers.
3012         It restarts the driver when pixel-test mode changes (e.g. when running a ref test after
3013         a normal test in --no-pixel-tests mode). However restarting driver is expensive on
3014         Android (several seconds each time). To reduce the cost, a command line option
3015         '--shard-ref-tests' is added to group ref tests in dedicated shards.
3016         The option is by default enabled on Android.
3017
3018         Will remove the option once DRT supports switching pixel test mode during one run.
3019         (https://bugs.webkit.org/show_bug.cgi?id=91538, https://bugs.webkit.org/show_bug.cgi?id=91539)
3020
3021         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3022         (Manager._shard_tests):
3023         (Manager._shard_in_two):
3024         (Manager._shard_by_directory):
3025         (Manager._run_tests):
3026         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3027         (Worker._update_test_input):
3028         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3029         (ChromiumAndroidPort.__init__):
3030         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3031         (parse_args):
3032
3033 2012-07-17  Don Olmstead  <don.olmstead@am.sony.com>
3034
3035         NRWT The time before server_process kills DRT should be variable
3036         https://bugs.webkit.org/show_bug.cgi?id=91542
3037
3038         Reviewed by Dirk Pranke.
3039
3040         Added the ability to configure the amount of time
3041         server_process waits before killing the DRT process
3042         during the call to stop.
3043
3044         * Scripts/webkitpy/layout_tests/port/base.py:
3045         (Port.variable.process_kill_time):
3046         * Scripts/webkitpy/layout_tests/port/server_process.py:
3047         (ServerProcess.stop):
3048
3049 2012-07-17  Alexis Menard  <alexis.menard@openbossa.org>
3050
3051         webkitdirs.pm should fallback to uname -m if arch is not present.
3052         https://bugs.webkit.org/show_bug.cgi?id=91543
3053
3054         Reviewed by Martin Robinson.
3055
3056         It seems that coreutils is moving away from the 'arch' command. Archlinux
3057         for example doesn't ship it anymore (coreutils 8.17). We can then fallback
3058         to 'uname -m' to find out the architecture.
3059
3060         * Scripts/webkitdirs.pm:
3061         (determineArchitecture):
3062
3063 2012-07-17  Dirk Pranke  <dpranke@chromium.org>
3064
3065         nrwt: rename printer.print_update to printer.write_update to match metered_stream
3066         https://bugs.webkit.org/show_bug.cgi?id=91557
3067
3068         Reviewed by Ojan Vafai.
3069
3070         Now that all of the printing logic is in printer.py, I want the
3071         public interface to printer to follow the meteredstream
3072         interface where possible. renaming write_update() gets us close.
3073
3074         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3075         (Manager._run_tests):
3076         (Manager._set_up_run):
3077         (Manager.start_servers_with_lock):
3078         (Manager.stop_servers_with_lock):
3079         (Manager._clobber_old_results):
3080         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3081         (run):
3082         * Scripts/webkitpy/layout_tests/views/printing.py:
3083         (Printer.write_update):
3084         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3085         (Testprinter.test_write_update):
3086
3087 2012-07-17  Tony Chang  <tony@chromium.org>
3088
3089         Fix a bug where optimize-baselines would incorrectly fail to optimize
3090         https://bugs.webkit.org/show_bug.cgi?id=91551
3091
3092         Reviewed by Adam Barth.
3093
3094         In some cases, optimize-baseline would correctly optimize the results, but because
3095         we weren't filtering the virtual ports out of _results_by_port_name, we thought
3096         that we had failed to optimize.
3097
3098         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
3099         (BaselineOptimizer._find_optimal_result_placement): No virtual filtering here.
3100         (BaselineOptimizer._filtered_results_by_port_name): New function that filters out virtual directories.
3101         (BaselineOptimizer.optimize): Filter out virtual ports.
3102         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
3103         (TestBaselineOptimizer._move_baselines): Add a stub so we don't actual move results.
3104         (BaselineOptimizerTest._assertOptimization): Call optimize and verify that the right files were moved.
3105         (BaselineOptimizerTest._assertOptimizationFailed): Add a method for when optimization should fail.
3106         (BaselineOptimizerTest.test_common_directory_includes_root): Update since this test should fail.
3107         (BaselineOptimizerTest.test_virtual_ports_filtered): New test case that demonstrates the bug.
3108
3109 2012-07-17  Xianzhu Wang  <wangxianzhu@chromium.org>
3110
3111         [Chromium] Add --encode-binary command line option for DRT
3112         https://bugs.webkit.org/show_bug.cgi?id=91532
3113
3114         Reviewed by Adam Barth.
3115
3116         When the option presents, DRT will encode binary output data in base64.
3117         ChromiumAndroidPort will pass the option because 'adb shell' doesn't support
3118         binary data output.
3119
3120         This change is a refactoring to replace the original hard-coded code for Android.
3121
3122         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3123         (main):
3124         * DumpRenderTree/chromium/TestEventPrinter.cpp:
3125         (TestEventPrinter::TestEventPrinter):
3126         (TestEventPrinter::handleAudio): New function replacing the original handleAudioHeader
3127         (TestEventPrinter::handleImage):
3128         (TestEventPrinter::handleBinary): Extracted common function for handleAudio and handleImage
3129         * DumpRenderTree/chromium/TestEventPrinter.h:
3130         (TestEventPrinter):
3131         * DumpRenderTree/chromium/TestShell.cpp:
3132         (TestShell::TestShell):
3133         (TestShell::initialize):
3134         (TestShell::dump):
3135         * DumpRenderTree/chromium/TestShell.h:
3136         (TestShell):
3137         (TestShell::setEncodeBinary):
3138         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Add --encode-binary to additional_drt_flags
3139         (ChromiumAndroidPort.__init__):
3140
3141 2012-07-17  Dirk Pranke  <dpranke@chromium.org>
3142
3143         nrwt: move per-test result output into printing.py
3144         https://bugs.webkit.org/show_bug.cgi?id=91465
3145
3146         Reviewed by Ojan Vafai.
3147
3148         This moves the last substantive logging/printing code from the
3149         manager into printing.py. Subsequent patches in this thread can
3150         largely focus on cleaning up printing.py and will leave the rest
3151         of the code alone.
3152
3153         This patch also removes manager.update() and
3154         manager.update_summary(), two routines that were no longer being
3155         used or needed (they have been dead for a long time but I didn't
3156         notice them until now).
3157
3158         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3159         (Manager.results_directory):
3160         (Manager._look_for_new_crash_logs):
3161         (Manager._update_summary_with_result):
3162         * Scripts/webkitpy/layout_tests/views/printing.py:
3163         (Printer.print_finished_test):
3164
3165 2012-07-17  Dirk Pranke  <dpranke@chromium.org>
3166
3167         nrwt: move config-specific logging to printing.py
3168         https://bugs.webkit.org/show_bug.cgi?id=91450
3169
3170         Reviewed by Ojan Vafai.
3171
3172         More refactoring ... this moves the 'config' output to
3173         printing.py.
3174
3175         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3176         (Manager._resize_shards):
3177         (Manager._run_tests):
3178         (Manager._upload_json_files):
3179         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3180         (ManagerTest.get_options):
3181         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3182         (run):
3183         * Scripts/webkitpy/layout_tests/views/printing.py:
3184         (Printer.print_config):
3185         (Printer.print_workers_and_shards):
3186         (Printer._print_config):
3187         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3188         (Testprinter.test_fallback_path_in_config):
3189         (Testprinter.test_print_config):
3190
3191 2012-07-17  Dirk Pranke  <dpranke@chromium.org>
3192
3193         nrwt: clean up logging when we're only running one chunk of the tests
3194         https://bugs.webkit.org/show_bug.cgi?id=91447
3195
3196         Reviewed by Ojan Vafai.
3197
3198         Apparently we were creating a 'tests_run.txt' in the results
3199         directory if we were only running one chunk of the tests; after
3200         3+ years of hacking on this code, that was news to me, so I'm
3201         guessing no one uses this. I'm removing this, and changing the
3202         _print_expected calls to debug messages to simplify the
3203         layering.
3204
3205         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3206         (Manager._split_into_chunks_if_necessary):
3207
3208 2012-07-17  Dirk Pranke  <dpranke@chromium.org>
3209
3210         Fix regression in style checker introduced in r122868.
3211         https://bugs.webkit.org/show_bug.cgi?id=91470
3212
3213         Unreviewed, build fix.
3214
3215         * Scripts/webkitpy/style/checkers/cpp.py:
3216         (_FileState.__init__):
3217
3218 2012-07-17  Dirk Pranke  <dpranke@chromium.org>
3219
3220         nrwt: move the bulk of the "expected" output to printing.py
3221         https://bugs.webkit.org/show_bug.cgi?id=91442
3222
3223         Reviewed by Ojan Vafai.
3224
3225         More printing-related refactoring. This moves all of the code
3226         that prints the results we expect to get, but doesn't move a few
3227         dangling printfs (those'll get hit in a later patch).
3228         
3229         No functional changes; covered by existing tests.
3230
3231         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3232         (Manager._split_into_chunks_if_necessary):
3233         (Manager.prepare_lists_and_print_output):
3234         (Manager.print_config):
3235         * Scripts/webkitpy/layout_tests/views/printing.py:
3236         (Printer.print_expected):
3237         (Printer):
3238         (Printer._print_expected_results_of_type):
3239         (Printer._num_digits):
3240         (Printer._print_expected):
3241         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3242         (Testprinter.test_print_expected):
3243
3244 2012-07-17  Christophe Dumez  <christophe.dumez@intel.com>
3245
3246         [EFL] Replace 0 by NULL in public headers documentation
3247         https://bugs.webkit.org/show_bug.cgi?id=91470
3248
3249         Reviewed by Dirk Pranke.
3250
3251         Fix style checking to properly detect C headers as C
3252         files. Without this change, the style script would
3253         complain if we use NULL (instead of 0 / null) in C
3254         headers.
3255
3256         * Scripts/webkitpy/style/checkers/cpp.py:
3257         (_FileState.__init__):
3258         (_FileState.is_c):
3259         (_FileState.is_c_or_objective_c):
3260
3261 2012-07-17  Xianzhu Wang  <wangxianzhu@chromium.org>
3262
3263         [chromium] remove --test-shell support from DRT
3264         https://bugs.webkit.org/show_bug.cgi?id=86927
3265
3266         Reviewed by Adam Barth.
3267
3268         Now no one use --test-shell. All of us use the standard DRT mode.
3269
3270         * DumpRenderTree/chromium/DumpRenderTree.cpp: Removed support of --test-shell and --pixel-tests=filename options. (--pixel-tests without '=' is kept for DRT mode.)
3271         (runTest):
3272         (main):
3273         * DumpRenderTree/chromium/TestEventPrinter.cpp:
3274         (TestEventPrinter::TestEventPrinter):
3275         (TestEventPrinter::~TestEventPrinter):
3276         (TestEventPrinter::handleTestHeader):
3277         (TestEventPrinter::handleTimedOut):
3278         (TestEventPrinter::handleTextHeader):
3279         (TestEventPrinter::handleTextFooter):
3280         (TestEventPrinter::handleAudioHeader):
3281         (TestEventPrinter::handleAudioFooter):
3282         (TestEventPrinter::handleImage): Removed the unused filename parameter.
3283         (TestEventPrinter::handleTestFooter):
3284         * DumpRenderTree/chromium/TestEventPrinter.h:
3285         (TestEventPrinter): Made it a concrete class because we have only one implementation.
3286         * DumpRenderTree/chromium/TestShell.cpp:
3287         (TestShell::TestShell):
3288         (TestShell::initialize):
3289         (TestShell::dumpImage):
3290         * DumpRenderTree/chromium/TestShell.h:
3291         (TestParams): Removed pixelFileName field.
3292         (TestShell):
3293
3294 2012-07-17  Xianzhu Wang  <wangxianzhu@chromium.org>
3295
3296         remove ChromiumDriver from NRWT
3297         https://bugs.webkit.org/show_bug.cgi?id=88478
3298
3299         Now WebKitDriver has replaced ChromiumDriver since test_shell mode is deperecated.
3300
3301         Reviewed by Dirk Pranke.
3302
3303         * Scripts/webkitpy/layout_tests/port/chromium.py: Removed ChromiumDriver code.
3304         (ChromiumPort._driver_class): Removed. WebKitPort._driver_class() will be used.
3305         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3306
3307 2012-07-17  No'am Rosenthal  <noam.rosenthal@nokia.com>
3308
3309         Unreviewed. Add QtGraphics, TextureMapper and OpenGL to watchlist.
3310
3311         * Scripts/webkitpy/common/config/watchlist:
3312
3313 2012-07-17  Sheriff Bot  <webkit.review.bot@gmail.com>
3314
3315         Unreviewed, rolling out r122828.
3316         http://trac.webkit.org/changeset/122828
3317         https://bugs.webkit.org/show_bug.cgi?id=91516
3318
3319         DumpRenderTree crashes after printing test results. (Requested
3320         by vsevik on #webkit).
3321
3322         * DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
3323         (TestInterfaces::TestInterfaces):
3324         (TestInterfaces::~TestInterfaces):
3325         (TestInterfaces::bindTo):
3326         (TestInterfaces::resetAll):
3327         * DumpRenderTree/chromium/TestRunner/TestInterfaces.h:
3328         (TestInterfaces):
3329         * DumpRenderTree/chromium/TestShell.cpp:
3330         (TestShell::initialize):
3331         (TestShell::createMainWindow):
3332         (TestShell::~TestShell):
3333         (TestShell::resetTestController):
3334         (TestShell::bindJSObjectsToWindow):
3335         * DumpRenderTree/chromium/TestShell.h:
3336         (TestShell::accessibilityController):
3337         (TestShell):
3338
3339 2012-07-17  Gabor Ballabas  <gaborb@inf.u-szeged.hu>
3340
3341         [Qt][V8] Remove the V8 related codepaths and configuration
3342         https://bugs.webkit.org/show_bug.cgi?id=90863
3343
3344         Reviewed by Simon Hausmann.
3345
3346         * Scripts/build-webkit: Remove --v8 option.
3347
3348 2012-07-17  Sheriff Bot  <webkit.review.bot@gmail.com>
3349
3350         Unreviewed, rolling out r122834.
3351         http://trac.webkit.org/changeset/122834
3352         https://bugs.webkit.org/show_bug.cgi?id=91492
3353
3354         it broke the chromium (Requested by kkristof on #webkit).
3355
3356         * Scripts/build-webkit:
3357
3358 2012-07-17  Gabor Ballabas  <gaborb@inf.u-szeged.hu>
3359
3360         [Qt][V8] Remove the V8 related codepaths and configuration
3361         https://bugs.webkit.org/show_bug.cgi?id=90863
3362
3363         Reviewed by Simon Hausmann.
3364
3365         * Scripts/build-webkit: Remove --v8 option.
3366
3367 2012-07-17  Balazs Kelemen  <kbalazs@webkit.org>
3368
3369         [Qt] Add --use-test-fonts option to Minibrowser
3370         https://bugs.webkit.org/show_bug.cgi?id=91402
3371
3372         Reviewed by Tor Arne Vestbø.
3373
3374         Same stuff that already exists for QtTestBrowser.
3375
3376         * MiniBrowser/qt/MiniBrowser.pro:
3377         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3378         (MiniBrowserApplication::handleUserOptions):
3379
3380 2012-07-17  Adam Barth  <abarth@webkit.org>
3381
3382         [Chromium] TestInterfaces should be responsible for owning and binding AccessibilityController and TextInputController
3383         https://bugs.webkit.org/show_bug.cgi?id=91459
3384
3385         Reviewed by Ryosuke Niwa.
3386
3387         Rather than having TestShell own and bind each of these JavaScript APIs
3388         individually, TestShell should delegate that work to TestInterfaces.
3389         This patch moves AccessibilityController and TextInputController to be
3390         the responsibility of TestInterfaces.
3391
3392         * DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
3393         (TestInterfaces::TestInterfaces):
3394         (TestInterfaces::~TestInterfaces):
3395         (TestInterfaces::setWebView):
3396         (TestInterfaces::bindTo):
3397         (TestInterfaces::resetAll):
3398         * DumpRenderTree/chromium/TestRunner/TestInterfaces.h:
3399         (WebKit):
3400         (TestInterfaces):
3401         (TestInterfaces::accessibilityController):
3402         * DumpRenderTree/chromium/TestShell.cpp:
3403         (TestShell::initialize):
3404         (TestShell::createMainWindow):
3405         (TestShell::~TestShell):
3406         (TestShell::resetTestController):
3407         (TestShell::bindJSObjectsToWindow):
3408         * DumpRenderTree/chromium/TestShell.h:
3409         (TestShell::accessibilityController):
3410         (TestShell):
3411
3412 2012-07-17  Adam Barth  <abarth@webkit.org>
3413
3414         [Chromium] Move TextInputController into TestRunner.a
3415         https://bugs.webkit.org/show_bug.cgi?id=91457
3416
3417         Reviewed by Ryosuke Niwa.
3418
3419         This patch is purely moving code. TextInputController is one of the
3420         objects exposed to JavaScript and so should be in the TestRunner
3421         library.
3422
3423         * DumpRenderTree/DumpRenderTree.gypi:
3424         * DumpRenderTree/chromium/TestRunner/TextInputController.cpp: Renamed from Tools/DumpRenderTree/chromium/TextInputController.cpp.
3425         * DumpRenderTree/chromium/TestRunner/TextInputController.h: Renamed from Tools/DumpRenderTree/chromium/TextInputController.h.
3426
3427 2012-07-17  Adam Barth  <abarth@webkit.org>
3428
3429         [Chromium] TextInputController shouldn't know about TestShell
3430         https://bugs.webkit.org/show_bug.cgi?id=91455
3431
3432         Reviewed by Kent Tamura.
3433
3434         This patch uses the same pattern we used for the
3435         AccessibilityController to remove the dependency on TestShell.
3436
3437         * DumpRenderTree/chromium/TestShell.cpp:
3438         (TestShell::initialize):
3439         (TestShell::createMainWindow):
3440         (TestShell::~TestShell):
3441         * DumpRenderTree/chromium/TextInputController.cpp:
3442         (TextInputController::TextInputController):
3443         (TextInputController::insertText):
3444         (TextInputController::doCommand):
3445         (TextInputController::setMarkedText):
3446         (TextInputController::unmarkText):
3447         (TextInputController::hasMarkedText):
3448         (TextInputController::markedRange):
3449         (TextInputController::selectedRange):
3450         (TextInputController::firstRectForCharacterRange):
3451         (TextInputController::validAttributesForMarkedText):
3452         (TextInputController::setComposition):
3453         * DumpRenderTree/chromium/TextInputController.h:
3454         (WebKit):
3455         (TextInputController):
3456         (TextInputController::setWebView):
3457
3458 2012-07-17  David Barr  <davidbarr@chromium.org>
3459
3460         Introduce ENABLE_CSS_IMAGE_ORIENTATION compile flag
3461         https://bugs.webkit.org/show_bug.cgi?id=89055
3462
3463         Reviewed by Kent Tamura.
3464
3465         The css3-images module is at candidate recommendation.
3466         http://www.w3.org/TR/2012/CR-css3-images-20120417/#the-image-orientation
3467
3468         Add a configuration option for CSS image-orientation support, disabling it by default.
3469
3470         * Scripts/webkitperl/FeatureList.pm:
3471         * qmake/mkspecs/features/features.pri:
3472
3473 2012-07-16  Adam Barth  <abarth@webkit.org>
3474
3475         [Chromium] Move Task.(cpp|h) into TestRunner.a
3476         https://bugs.webkit.org/show_bug.cgi?id=91446
3477
3478         Reviewed by Ryosuke Niwa.
3479
3480         Task is a dependency of EventSender, which needs to move into TestRunner.a.
3481
3482         * DumpRenderTree/DumpRenderTree.gypi:
3483         * DumpRenderTree/chromium/TestRunner/Task.cpp: Renamed from Tools/DumpRenderTree/chromium/Task.cpp.
3484         * DumpRenderTree/chromium/TestRunner/Task.h: Renamed from Tools/DumpRenderTree/chromium/Task.h.
3485
3486 2012-07-16  Adam Barth  <abarth@webkit.org>
3487
3488         [Chromium] Move AccessibilityController and AccessibilityUIElement into TestRunner.a
3489         https://bugs.webkit.org/show_bug.cgi?id=91443
3490
3491         Reviewed by Tony Chang.
3492
3493         Purely a file move (and a sorting of #includes).
3494
3495         * DumpRenderTree/DumpRenderTree.gypi:
3496         * DumpRenderTree/chromium/TestRunner/AccessibilityController.cpp: Renamed from Tools/DumpRenderTree/chromium/AccessibilityController.cpp.
3497         * DumpRenderTree/chromium/TestRunner/AccessibilityController.h: Renamed from Tools/DumpRenderTree/chromium/AccessibilityController.h.
3498         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElement.cpp: Renamed from Tools/DumpRenderTree/chromium/AccessibilityUIElement.cpp.
3499         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElement.h: Renamed from Tools/DumpRenderTree/chromium/AccessibilityUIElement.h.
3500
3501 2012-07-16  Adam Barth  <abarth@webkit.org>
3502
3503         [Chromium] AccessibilityController shouldn't know anything about TestShell
3504         https://bugs.webkit.org/show_bug.cgi?id=91441
3505
3506         Reviewed by Tony Chang.
3507
3508         This patch is a precursor to moving AccessibilityController.cpp into TestRunner.a.
3509
3510         * DumpRenderTree/chromium/AccessibilityController.cpp:
3511         (AccessibilityController::AccessibilityController):
3512         (AccessibilityController::getFocusedElement):
3513         (AccessibilityController::getRootElement):
3514         * DumpRenderTree/chromium/AccessibilityController.h:
3515         (WebKit):
3516         (AccessibilityController):
3517         (AccessibilityController::setWebView):
3518         * DumpRenderTree/chromium/TestShell.cpp:
3519         (TestShell::initialize):
3520         (TestShell::createMainWindow):
3521         (TestShell::~TestShell):
3522
3523 2012-07-16  Adam Barth  <abarth@webkit.org>
3524
3525         [Chromium] Introduce TestInterfaces to hold all the JavaScript interfaces needed for LayoutTests
3526         https://bugs.webkit.org/show_bug.cgi?id=91312
3527
3528         Reviewed by Ryosuke Niwa.
3529
3530         Looking forward to moving more objects into TestRunner.a, we're going
3531         to need an object to own all the interfaces and to put them through
3532         their lifecycle.
3533
3534         * DumpRenderTree/DumpRenderTree.gypi:
3535         * DumpRenderTree/chromium/TestShell.cpp:
3536         (TestShell::initialize):
3537         (TestShell::resetTestController):
3538         (TestShell::bindJSObjectsToWindow):
3539         * DumpRenderTree/chromium/TestShell.h:
3540         (TestShell):
3541         * DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp: Added.
3542         * DumpRenderTree/chromium/TestRunner/TestInterfaces.h: Added.
3543
3544 2012-07-16  Ryuan Choi  <ryuan.choi@samsung.com>
3545
3546         [EFL][WK2] Add APIs to support theme.
3547         https://bugs.webkit.org/show_bug.cgi?id=90107
3548
3549         Reviewed by Hajime Morita.
3550
3551         Override default theme path for MiniBrowser and WebKitTestRunner.
3552
3553         * MiniBrowser/efl/CMakeLists.txt:
3554         * MiniBrowser/efl/main.c:
3555         (browserCreate):
3556         * WebKitTestRunner/PlatformEfl.cmake:
3557         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3558         (WTR::PlatformWebView::PlatformWebView):
3559
3560 2012-07-16  Ryuan Choi  <ryuan.choi@samsung.com>
3561
3562         [EFL][DRT] Implement dumpFrameScrollPosition
3563         https://bugs.webkit.org/show_bug.cgi?id=87638
3564
3565         Reviewed by Hajime Morita.
3566
3567         * DumpRenderTree/efl/DumpRenderTree.cpp:
3568         (dumpFrameScrollPosition): Implemented.
3569         (shouldDumpFrameScrollPosition): Fixed wrong condition like other ports.
3570
3571 2012-07-16  Don Olmstead  <don.olmstead@am.sony.com>
3572
3573         NRWRT Should provide a VS project to work on
3574         https://bugs.webkit.org/show_bug.cgi?id=91436
3575
3576         Reviewed by Dirk Pranke.
3577
3578         Adding VS2010 project for modifying webkitpy. Uses pytools
3579         <http://pytools.codeplex.com> which integrates python into 
3580         Visual Studio.
3581
3582         * Scripts/webkitpy/webkitpy.pyproj: Added.
3583         * Scripts/webkitpy/webkitpy.sln: Added.
3584
3585 2012-07-16  Adam Barth  <abarth@webkit.org>
3586
3587         [Chromium] Move GamepadController into TestRunner.a
3588         https://bugs.webkit.org/show_bug.cgi?id=91311
3589
3590         Reviewed by Tony Chang.
3591
3592         GamepadController looks like a simple class to move into TestRunner.a
3593         because it has almost zero dependence on TestShell.
3594
3595         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3596         * DumpRenderTree/DumpRenderTree.gypi:
3597         * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp: Renamed from Tools/DumpRenderTree/chromium/CppBoundClass.cpp.
3598         * DumpRenderTree/chromium/TestRunner/CppBoundClass.h: Renamed from Tools/DumpRenderTree/chromium/CppBoundClass.h.
3599         * DumpRenderTree/chromium/TestRunner/CppVariant.cpp: Renamed from Tools/DumpRenderTree/chromium/CppVariant.cpp.
3600         * DumpRenderTree/chromium/TestRunner/CppVariant.h: Renamed from Tools/DumpRenderTree/chromium/CppVariant.h.
3601             - GamepadController depends on these bindings helpers.
3602         * DumpRenderTree/chromium/TestRunner/GamepadController.cpp: Renamed from Tools/DumpRenderTree/chromium/GamepadController.cpp.
3603         * DumpRenderTree/chromium/TestRunner/GamepadController.h: Renamed from Tools/DumpRenderTree/chromium/GamepadController.h.
3604             - Just moved these files and removed the unused TestShell
3605               references.
3606         * DumpRenderTree/chromium/TestRunner/Stub.cpp: Removed.
3607             - No longer needed.
3608         * DumpRenderTree/chromium/TestShell.cpp:
3609             - Update call to constructor to avoid passing in this.
3610
3611 2012-07-16  Xianzhu Wang  <wangxianzhu@chromium.org>
3612
3613         [Chromium-android] Don't use test_shell mode of DRT
3614         https://bugs.webkit.org/show_bug.cgi?id=88542
3615
3616         Reviewed by Dirk Pranke.
3617
3618         Test shell mode is about to be removed.
3619         Switch to use DRT mode for chromium-android.
3620
3621         Summary of changes:
3622         1. ChromiumAndroidDriver now inherits from WebKitDriver instead of ChromiumDriver (to be deprecated).
3623         2. Conforms to the DRT mode protocol for input/output of DumpRenderTree.
3624         3. Added support for Android 'adb shell' input/output (base64, newline mode, etc.)
3625
3626         * DumpRenderTree/chromium/TestEventPrinter.cpp:
3627         (DRTPrinter::handleImage): Outputs base64 on Android.
3628         * DumpRenderTree/chromium/TestShellAndroid.cpp:
3629         (platformInit): Changed err_file to err_fifo, required by python ServerProcess.
3630         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3631         (ChromiumAndroidPort.__init__):
3632         (ChromiumAndroidPort.create_driver): Override to create driver without DriverProxy to ensure 1 Driver per run.
3633         (ChromiumAndroidDriver):
3634         (ChromiumAndroidDriver.__init__):
3635         (ChromiumAndroidDriver.cmd_line):
3636         (ChromiumAndroidDriver._deadlock_detector):
3637         (ChromiumAndroidDriver._drt_cmd_line):
3638         (ChromiumAndroidDriver.start):
3639         (ChromiumAndroidDriver._start):