58030b2b16ee620db11ad066882c5db34d2fd4b7
[WebKit-https.git] / Tools / ChangeLog
1 2020-03-04  Basuke Suzuki  <basuke.suzuki@sony.com>
2
3         [MSVC] Add .natvis support of WebKit types
4         https://bugs.webkit.org/show_bug.cgi?id=193119
5
6         Reviewed by Don Olmstead.
7
8         To help the WebKit developer while debugging, this file defines how
9         WebKit types are displayed in debugger of Visual Studio.
10         Very limited set of WebKit types, but it changes the world.
11
12         * VisualStudio/WebKit.natvis: Added.
13
14 2020-03-04  Wenson Hsieh  <wenson_hsieh@apple.com>
15
16         Add system trace points around display list replay
17         https://bugs.webkit.org/show_bug.cgi?id=208616
18
19         Reviewed by Simon Fraser.
20
21         Add a new "Display list replay" trace point.
22
23         * Tracing/SystemTracePoints.plist:
24
25 2020-03-04  Alex Christensen  <achristensen@webkit.org>
26
27         Call globalObjectIsAvailableForFrame before evaluating JavaScript in newly created worlds
28         https://bugs.webkit.org/show_bug.cgi?id=208615
29         <rdar://problem/59406743>
30
31         Reviewed by Alex Christensen.
32
33         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
34         * TestWebKitAPI/Tests/WebKitCocoa/ContentWorldPlugIn.mm: Added.
35         (-[ContentWorldPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
36         (-[ContentWorldPlugIn webProcessPlugInBrowserContextController:globalObjectIsAvailableForFrame:inScriptWorld:]):
37         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
38         (TEST):
39         Also make a test written in bug 206310 actually run code.
40
41 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
42
43         [build.webkit.org] Remove leaks queue
44         https://bugs.webkit.org/show_bug.cgi?id=208580
45
46         Reviewed by Jonathan Bedard.
47
48         * BuildSlaveSupport/build.webkit.org-config/config.json:
49         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
50         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
51
52 2020-03-04  Alex Christensen  <achristensen@webkit.org>
53
54         Add SPI to evaluate JavaScript in an iframe
55         https://bugs.webkit.org/show_bug.cgi?id=208605
56
57         Reviewed by Brady Eidson.
58
59         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
60
61 2020-03-03  Jiewen Tan  <jiewen_tan@apple.com>
62
63         [WebAuthn] Implement -[_WKWebAuthenticationPanelDelegate panel:decidePolicyForLocalAuthenticatorWithCompletionHandler:] SPI
64         https://bugs.webkit.org/show_bug.cgi?id=208533
65         <rdar://problem/60010184>
66
67         Reviewed by Alex Christensen.
68
69         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
70         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
71         (-[TestWebAuthenticationPanelDelegate panel:decidePolicyForLocalAuthenticatorWithCompletionHandler:]):
72         (TestWebKitAPI::TEST):
73         (-[TestWebAuthenticationPanelDelegate panel:verifyUserWithAccessControl:completionHandler:]): Deleted.
74         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Removed.
75
76 2020-03-04  Alex Christensen  <achristensen@webkit.org>
77
78         callAsyncJavaScript with an invalid parameter and no completionHandler should not crash
79         https://bugs.webkit.org/show_bug.cgi?id=208593
80
81         Reviewed by Brady Eidson.
82
83         * TestWebKitAPI/Tests/WebKitCocoa/AsyncFunction.mm:
84         (TestWebKitAPI::TEST):
85
86 2020-03-04  Alex Christensen  <achristensen@webkit.org>
87
88         WKWebView's frames accessor should return a traversable type
89         https://bugs.webkit.org/show_bug.cgi?id=208591
90
91         Reviewed by Brady Eidson.
92
93         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
94
95 2020-03-04  Antoine Quint  <graouts@apple.com>
96
97         Add an SPI to allow UserStyleSheet injection to target a specific WKWebView
98         https://bugs.webkit.org/show_bug.cgi?id=208575
99         <rdar://problem/59773690>
100
101         Reviewed by Brady Eidson.
102
103         Add new tests for the new SPI which check:
104         
105         1. that specifying forWKWebView: when initializing a _WKUserStyleSheet will inject the provided CSS source in the
106            specified WKWebView alone,
107         2. that the same test works with two WKWebViews with a shared WKWebKitConfiguration,
108         3. that a WKWebView-specific _WKUserStyleSheet can be removed,
109         4. that a WKWebView-specific _WKUserStyleSheet can be added twice and removed once and be removed as expected,
110         5. and that a WKWebView-specific _WKUserStyleSheet is automatically removed when navigating to a new page,
111         6. and that the same test also works with PSON enabled.
112
113         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
114
115 2020-03-04  Ryan Haddad  <ryanhaddad@apple.com>
116
117         [macOS] test-lldb-webkit failing on debug bots
118         https://bugs.webkit.org/show_bug.cgi?id=208545
119
120         Reviewed by Jonathan Bedard.
121
122         The lldb-webkit-test step must pass in the build configuration as an
123         argument to the test-lldb-webkit script so that it uses the lldbWebKitTester
124         binary that is downloaded with the rest of the build products. Without this
125         argument, the bots expect to find the binary in the 'WebKitBuild/Release' directory
126         regardless of their actual build configuration.
127
128         * BuildSlaveSupport/build.webkit.org-config/steps.py:
129         (RunLLDBWebKitTests): Pass in the build configuration to the test-lldb-webkit script.
130         * Scripts/test-lldb-webkit:
131         (LldbTester.parse_args): Capitalize the constants for Debug / Release since that is what webkitpy expects.
132
133 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
134
135         [ews] Add build step to create local git commit for commit-queue (follow-up fix)
136         https://bugs.webkit.org/show_bug.cgi?id=208539
137
138         Unreviewed follow-up fix.
139
140         * BuildSlaveSupport/ews-build/steps.py:
141
142 2020-03-04  Daniel Bates  <dabates@apple.com>
143
144         Should use -bounds instead of -frame in RequestTextInputContext.mm tests
145         https://bugs.webkit.org/show_bug.cgi?id=208565
146
147         Reviewed by Wenson Hsieh.
148
149         Pass the bounds of the web view to -synchronouslyRequestTextInputContextsInRect: instead
150         of its frame as a means to find all the editable elements in the visible content area
151         of the web view.
152
153         Coincidentally this makes no difference to the test results right now because the web view
154         happens to be located at the origin (0, 0) in the window. However if in the future the
155         web view would be located at some other point then the tests may fail because the rectangle
156         passed to -synchronouslyRequestTextInputContextsInRect: would no longer represent the
157         rectangle for the visible content area.
158
159         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
160         (TEST):
161
162 2020-03-04  Daniel Bates  <dabates@apple.com>
163
164         Organize tests in RequestTextInputContext.mm tests under test name RequestTextInputContext
165         https://bugs.webkit.org/show_bug.cgi?id=208564
166
167         Reviewed by Alex Christensen.
168
169         Group the tests in RequestTextInputContext.mm under the test case name RequestTextInputContext
170         to make it easy to run just these tests.
171
172         Currently, the tests are organized under the test case name WebKit. This means you need to
173         pass run-api-tests the name of each sub-test as there is no easy way to run them all without
174         also running all the TestWebKitAPI.WebKit sub-tests. Instead organize them under RequestTextInputContext
175         so that a person can run just these test using:
176         
177                 run-api-tests --debug TestWebKitAPI.RequestTextInputContext
178
179         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
180         (TEST):
181
182 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
183
184         [ews] Add build step to create local git commit for commit-queue
185         https://bugs.webkit.org/show_bug.cgi?id=208539
186
187         Reviewed by Jonathan Bedard.
188
189         * BuildSlaveSupport/ews-build/steps.py:
190         (CreateLocalGITCommit): Build step to create local git commit.
191         (CreateLocalGITCommit.start):
192         (CreateLocalGITCommit.getResultSummary): Set custom failure message.
193         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests and restructured imports.
194         * BuildSlaveSupport/ews-build/factories.py:
195
196 2020-03-04  Simon Fraser  <simon.fraser@apple.com>
197
198         (r256513) [ Mac ] fast/scrolling/programmatic-scroll-to-zero-zero.html is a flaky failure
199         https://bugs.webkit.org/show_bug.cgi?id=207948
200
201         Reviewed by Zalan Bujtas.
202
203         EventSendingController needs to trigger layout so that the WebHTMLView is not 0x0,
204         so that it receives the wheel events.
205
206         * DumpRenderTree/mac/EventSendingController.mm:
207         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
208         * DumpRenderTree/win/EventSender.cpp:
209         (mouseScrollBy):
210
211 2020-03-04  Andres Gonzalez  <andresg_22@apple.com>
212
213         REGRESSION (r257739): two fast/events/autoscroll test have started to fail
214         https://bugs.webkit.org/show_bug.cgi?id=208520
215         <rdar://problem/60000214>
216
217         Reviewed by Chris Fleizach.
218
219         Calling InjectedBundle::singleton().page()->page() in the constructor
220         of the AccessibilityController is having this side effect on iOS.
221         So #if to MAC where it's actually being used.
222
223         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
224         (WTR::AccessibilityController::AccessibilityController):
225
226 2020-03-03  Alex Christensen  <achristensen@webkit.org>
227
228         Add SPI _WKResourceLoadInfo.loadedFromCache
229         https://bugs.webkit.org/show_bug.cgi?id=208554
230
231         Reviewed by Wenson Hsieh.
232
233         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
234         (TEST):
235
236 2020-03-03  Ryosuke Niwa  <rniwa@webkit.org>
237
238         Batch observations and completions of text manipulations
239         https://bugs.webkit.org/show_bug.cgi?id=208406
240
241         Reviewed by Wenson Hsieh.
242
243         Updated the existing tests to use new APIs, and added new tests for batching finding & replacing
244         multiple paragraphs at once.
245
246         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
247         (-[TextManipulationDelegate _webView:didFindTextManipulationItems:]):
248         (-[TextManipulationDelegate items]):
249         (-[LegacyTextManipulationDelegate init]):
250         (-[LegacyTextManipulationDelegate _webView:didFindTextManipulationItem:]):
251         (TextManipulation.StartTextManipulationSupportsLegacyDelegateCallback): Added.
252         (TextManipulation.LegacyCompleteTextManipulationReplaceSimpleSingleParagraph): Added.
253         (TextManipulation.CompleteTextManipulationReplaceMultipleSimpleParagraphsAtOnce): Added.
254         (TextManipulation.CompleteTextManipulationShouldBatchItemCallback): Added.
255         (TextManipulation.CompleteTextManipulationFailWhenItemIdentifierIsDuplicated): Added.
256         (TextManipulation.CompleteTextManipulationCanHandleSubsetOfItemsToFail): Added.
257
258 2020-03-03  Per Arne Vollan  <pvollan@apple.com>
259
260         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
261         https://bugs.webkit.org/show_bug.cgi?id=208415
262
263         Reviewed by Brent Fulgham.
264
265         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
266         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
267         (TEST):
268
269 2020-03-03  Alex Christensen  <achristensen@webkit.org>
270
271         Add response to _WKResourceLoadDelegate didCompleteWithError callback
272         https://bugs.webkit.org/show_bug.cgi?id=208553
273
274         Reviewed by Simon Fraser.
275
276         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
277         (-[TestResourceLoadDelegate webView:resourceLoad:didCompleteWithError:response:]):
278         (TEST):
279         (-[TestResourceLoadDelegate webView:resourceLoad:didCompleteWithError:]): Deleted.
280
281 2020-03-03  Brady Eidson  <beidson@apple.com>
282
283         API Test [Mojave+ WK2 Debug ] TestWebKitAPI.WKAttachmentTestsMac.InsertDroppedFilePromisesAsAttachments is a flaky crash.
284         https://bugs.webkit.org/show_bug.cgi?id=198795
285
286         Reviewed by Chris Dumez.
287
288         This test appears to no longer be flaky.
289         
290         Let's re-enable it.
291         
292         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
293         (TestWebKitAPI::TEST):
294
295 2020-03-03  Alex Christensen  <achristensen@webkit.org>
296
297         Requests sent to _WKResourceLoadDelegate should include HTTPBody
298         https://bugs.webkit.org/show_bug.cgi?id=208550
299
300         Reviewed by Tim Hatcher.
301
302         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
303         (TEST):
304         * TestWebKitAPI/cocoa/HTTPServer.mm:
305         (TestWebKitAPI::HTTPServer::respondToRequests):
306         HTTPServer now looks for Content-Length in its request.
307         If it finds this header, that means that the HTTP body is going to be received in another read, then the response should be sent after receiving that.
308
309 2020-03-03  Alex Christensen  <achristensen@webkit.org>
310
311         Expose originalURL and originalHTTPMethod on _WKResourceLoadInfo
312         https://bugs.webkit.org/show_bug.cgi?id=208522
313
314         Reviewed by Brian Weinstein.
315
316         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
317         (TEST):
318
319 2020-03-03  Aakash Jain  <aakash_jain@apple.com>
320
321         commit-queue should update working directory and reapply patch just before commiting
322         https://bugs.webkit.org/show_bug.cgi?id=208521
323
324         Reviewed by Jonathan Bedard.
325
326         * BuildSlaveSupport/ews-build/factories.py:
327
328 2020-03-03  Matt Lewis  <jlewis3@apple.com>
329
330         Add Unittest to commits_for_upload() and fix multiple unittests for several test suites.
331         https://bugs.webkit.org/show_bug.cgi?id=208485
332
333         Reviewed by Jonathan Bedard.
334
335         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
336         (StubRepository.__init__): Fixing the constructor to call upon the parent class as we were not doing this before. It also means
337         that we don't have to recreate the variables that are already created.
338         * Scripts/webkitpy/common/checkout/scm/stub_repository_unittest.py: High level changed the imports to better reflect what we are using
339         from each module, rather than making extra imports that we don't need.
340         (StubRepositoryTest.mock_host_for_stub_repository): Since we are calling both an executive and a filesystem mock for most of the
341         tests. it makes more sense to create a mock host with the files needed, than it does to instantiate each of these as separate objects
342         and not part of the host.
343         (StubRepositoryTest.test_in_working_directory): Changed the filesystem call to the host call.
344         (StubRepositoryTest.test_native_revision): Changed the filesystem call to the host call.
345         (StubRepositoryTest.test_native_branch): Changed the filesystem call to the host call.
346         (StubRepositoryTest.test_svn_revision): Changed the filesystem call to the host call.
347         (StubRepositoryTest.test_find_checkout_root): Changed the filesystem call to the host call.
348         (StubRepositoryTest.test_find_checkout_root_failure): Changed the filesystem call to the host call.
349         (StubRepositoryTest.test_find_parent_path_matching_callback_condition_with_file_system): Changed the filesystem call to the host call.
350         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py: 
351         (SummarizedResultsTest.test_svn_revision_exists): Changed the name to original test to better reflect that it was just looking to see
352         if we were geting any value at all
353         (SummarizedResultsTest.test_svn_revision): Added a test to make sure that the revision we are getting is what we expect to get and make
354         sure we aren't gabking the wrong key:value pair
355         * Scripts/webkitpy/port/base_unittest.py: Changed from MockSystemHost to MockHost as we want the extras that
356         come with the MockHosts and MockHost inherits from MockSystemHost.
357         (PortTest.make_port): Changed the port to call MockHost that will creat the required stub_repository files.
358         (test_commits_for_upload): Added amissing test for commits_for_upload as this has been an issue when trying to make changes
359         to the various upload steps.
360
361 2020-03-03  Aakash Jain  <aakash_jain@apple.com>
362
363         [ews] Add build step to find list of modified changelogs
364         https://bugs.webkit.org/show_bug.cgi?id=208514
365
366         Reviewed by Jonathan Bedard.
367
368         * BuildSlaveSupport/ews-build/factories.py:
369         * BuildSlaveSupport/ews-build/steps.py:
370         (FindModifiedChangeLogs): Build step to find modified ChangeLogs.
371         (FindModifiedChangeLogs.start): Initialize log observer.
372         (FindModifiedChangeLogs.getResultSummary): Set custom failure message.
373         (FindModifiedChangeLogs.evaluateCommand):
374         (FindModifiedChangeLogs.is_path_to_changelog): Check if the file is a ChangeLog.
375         (FindModifiedChangeLogs._status_regexp): Regex to match files from git output.
376         (FindModifiedChangeLogs.extract_changelogs): Method to get list of ChangeLogs from git output.
377         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
378
379 2020-03-03  Ryan Haddad  <ryanhaddad@apple.com>
380
381         [iOS EWS] TestWebKitAPI.WKWebsiteDataStore.RemoveAndFetchData is failing
382         https://bugs.webkit.org/show_bug.cgi?id=208451
383
384         Unreviewed test gardening.
385
386         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm: Disable the test for iOS since it is slowing down EWS.
387
388 2020-03-03  Jiten Mehta  <jmehta@apple.com>
389
390         Adopt HTTP Alternative Services Storage
391         https://bugs.webkit.org/show_bug.cgi?id=208387
392
393         Reviewed by Alex Christensen.
394
395         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
396         (checkUntilEntryFound):
397         (TEST):
398
399 2020-03-03  Kate Cheney  <katherine_cheney@apple.com>
400
401         Check for navigation to app-bound domain during script evaluation
402         https://bugs.webkit.org/show_bug.cgi?id=208319
403         <rdar://problem/57569321>
404
405         Reviewed by Brent Fulgham.
406
407         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
408         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm: Added.
409         (-[TestInAppBrowserScriptMessageHandler userContentController:didReceiveScriptMessage:]):
410         (TEST):
411         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-agent-script.html: Added.
412         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-script.html: Added.
413
414 2020-03-03  Commit Queue  <commit-queue@webkit.org>
415
416         Unreviewed, rolling out r257754.
417         https://bugs.webkit.org/show_bug.cgi?id=208513
418
419         Introduced API test failure (Requested by perarne on #webkit).
420
421         Reverted changeset:
422
423         "[Cocoa] Mapping from MIME type to UTI type should be done in
424         the UI process"
425         https://bugs.webkit.org/show_bug.cgi?id=208415
426         https://trac.webkit.org/changeset/257754
427
428 2020-03-03  Diego Pino Garcia  <dpino@igalia.com>
429
430         REGRESSION(r257726): [GTK] LayoutTests crashing after r257726
431         https://bugs.webkit.org/show_bug.cgi?id=208506
432
433         Reviewed by Carlos Garcia Campos.
434
435         * WebKitTestRunner/TestController.cpp:
436         (WTR::TestController::platformAdjustContext): Remove unnecessary code.
437
438 2020-03-02  Ben Nham  <nham@apple.com>
439
440         Add performance probes for HTML parsing
441         https://bugs.webkit.org/show_bug.cgi?id=208271
442
443         Reviewed by Daniel Bates.
444
445         This adds probes that show which lines of HTML are have been parsed.
446
447         * Tracing/SystemTracePoints.plist:
448
449 2020-03-02  Per Arne Vollan  <pvollan@apple.com>
450
451         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
452         https://bugs.webkit.org/show_bug.cgi?id=208415
453
454         Reviewed by Brent Fulgham.
455
456         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
457         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
458         (TEST):
459
460 2020-03-02  Jacob Uphoff  <jacob_uphoff@apple.com>
461
462         Unreviewed, rolling out r257725.
463
464         This commit caused 10 API tests to fail
465
466         Reverted changeset:
467
468         "[Cocoa] Mapping from MIME type to UTI type should be done in
469         the UI process"
470         https://bugs.webkit.org/show_bug.cgi?id=208415
471         https://trac.webkit.org/changeset/257725
472
473 2020-03-02  Saam Barati  <sbarati@apple.com>
474
475         Don't skip tests unnecessarily on arm64
476         https://bugs.webkit.org/show_bug.cgi?id=208470
477         <rdar://problem/59968869>
478
479         Reviewed by Tadeu Zagallo.
480
481         * Scripts/run-jsc-stress-tests:
482
483 2020-03-02  Andres Gonzalez  <andresg_22@apple.com>
484
485         Fix for LayoutTests/accessibility/mac/search-text/search-text.html in IsolatedTree mode.
486         https://bugs.webkit.org/show_bug.cgi?id=208434
487
488         Reviewed by Chris Fleizach.
489
490         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
491         (WTR::AccessibilityController::AccessibilityController): Initializes m_useAXThread.
492         (WTR::AccessibilityController::rootElement): No need to set m_useAXThread here since it is initialize in the constructor.
493         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
494         (WTR::AccessibilityController::accessibleElementById): Same as above.
495
496 2020-03-02  John Wilander  <wilander@apple.com>
497
498         ResourceLoadStatistics: Enable cookie blocking and the Storage Access API in ephemeral sessions
499         https://bugs.webkit.org/show_bug.cgi?id=208399
500         <rdar://problem/24731650>
501
502         Reviewed by Brent Fulgham.
503
504         The majority of the changes in WTR::TestController is (partially) fixing a bug
505         where the TestRunner would statically use the default website datastore instead
506         of the website data store configure for the page. This worked for persistent
507         storage testing but not for ephemeral sessions which is what this patch is all
508         about. The previous TestController::websiteDataStore() is now called
509         TestController::defaultWebsiteDataStore() and the new
510         TestController::websiteDataStore() returns the configured website data store.
511         Most of the use of the default website data store should probably change but
512         that's not really for this patch to deal with. I did however move all of
513         resource load statistics' use to the new TestController::websiteDataStore().
514
515         A new TestRunner function was added: isStatisticsEphemeral()
516         It allows test cases to query the ephemeral status of resource load statistics.
517
518         One problem that is mitigated in this patch but not fully fixed is that for
519         Cocoa platforms, the TestRunner sets up two ephemeral sessions, once in
520         TestController::generatePageConfiguration() via C API 
521         WKPageConfigurationSetWebsiteDataStore(), and then again in 
522         TestControllerCocoa's initializeWebViewConfiguration() via Cocoa API
523         [copiedConfiguration setWebsiteDataStore:ephemeralWebsiteDataStore].
524         I tried removing the latter since one session for all platforms should be
525         Enough but got broken behavior as a result. So now both are still there
526         and both enable resource load statistics.
527
528         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
529         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
530         (WTR::TestRunner::isStatisticsEphemeral):
531         * WebKitTestRunner/InjectedBundle/TestRunner.h:
532         * WebKitTestRunner/TestController.cpp:
533         (WTR::TestController::defaultWebsiteDataStore):
534         (WTR::TestController::websiteDataStore):
535         (WTR::TestController::generatePageConfiguration):
536         (WTR::TestController::resetPreferencesToConsistentValues):
537         (WTR::TestController::resetStateToConsistentValues):
538         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
539         (WTR::TestController::decidePolicyForNavigationAction):
540         (WTR::TestController::platformAdjustContext):
541         (WTR::TestController::clearServiceWorkerRegistrations):
542         (WTR::TestController::clearDOMCache):
543         (WTR::TestController::clearDOMCaches):
544         (WTR::TestController::clearIndexedDatabases):
545         (WTR::TestController::clearLocalStorage):
546         (WTR::TestController::hasDOMCache):
547         (WTR::TestController::domCacheSize):
548         (WTR::TestController::setStatisticsEnabled):
549         (WTR::TestController::isStatisticsEphemeral):
550         (WTR::TestController::setStatisticsDebugMode):
551         (WTR::TestController::setStatisticsPrevalentResourceForDebugMode):
552         (WTR::TestController::setStatisticsLastSeen):
553         (WTR::TestController::setStatisticsMergeStatistic):
554         (WTR::TestController::setStatisticsPrevalentResource):
555         (WTR::TestController::setStatisticsVeryPrevalentResource):
556         (WTR::TestController::dumpResourceLoadStatistics):
557         (WTR::TestController::isStatisticsPrevalentResource):
558         (WTR::TestController::isStatisticsVeryPrevalentResource):
559         (WTR::TestController::isStatisticsRegisteredAsSubresourceUnder):
560         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
561         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
562         (WTR::TestController::setStatisticsHasHadUserInteraction):
563         (WTR::TestController::isStatisticsHasHadUserInteraction):
564         (WTR::TestController::isStatisticsOnlyInDatabaseOnce):
565         (WTR::TestController::setStatisticsGrandfathered):
566         (WTR::TestController::isStatisticsGrandfathered):
567         (WTR::TestController::setUseITPDatabase):
568         (WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin):
569         (WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin):
570         (WTR::TestController::setStatisticsSubresourceUniqueRedirectTo):
571         (WTR::TestController::setStatisticsSubresourceUniqueRedirectFrom):
572         (WTR::TestController::setStatisticsTopFrameUniqueRedirectTo):
573         (WTR::TestController::setStatisticsTopFrameUniqueRedirectFrom):
574         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
575         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
576         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
577         (WTR::TestController::statisticsUpdateCookieBlocking):
578         (WTR::TestController::statisticsSubmitTelemetry):
579         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
580         (WTR::TestController::setStatisticsIsRunningTest):
581         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
582         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
583         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
584         (WTR::TestController::setStatisticsGrandfatheringTime):
585         (WTR::TestController::setStatisticsMaxStatisticsEntries):
586         (WTR::TestController::setStatisticsPruneEntriesDownTo):
587         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
588         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
589         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
590         (WTR::TestController::statisticsDeleteCookiesForHost):
591         (WTR::TestController::isStatisticsHasLocalStorage):
592         (WTR::TestController::setStatisticsCacheMaxAgeCap):
593         (WTR::TestController::hasStatisticsIsolatedSession):
594         (WTR::TestController::setStatisticsShouldDowngradeReferrer):
595         (WTR::TestController::setStatisticsShouldBlockThirdPartyCookies):
596         (WTR::TestController::setStatisticsFirstPartyWebsiteDataRemovalMode):
597         (WTR::TestController::statisticsResetToConsistentState):
598         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
599         * WebKitTestRunner/TestController.h:
600         * WebKitTestRunner/TestInvocation.cpp:
601         (WTR::TestInvocation::invoke):
602         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
603         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
604         (WTR::initializeWebViewConfiguration):
605         (WTR::TestController::platformCreateWebView):
606
607 2020-03-02  Per Arne Vollan  <pvollan@apple.com>
608
609         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
610         https://bugs.webkit.org/show_bug.cgi?id=208415
611
612         Reviewed by Brent Fulgham.
613
614         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
615         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
616         (TEST):
617
618 2020-03-02  Daniel Bates  <dabates@apple.com>
619
620         Page::editableElementsInRect() should find nested editable elements and return found elements in paint order
621         https://bugs.webkit.org/show_bug.cgi?id=208352
622         <rdar://problem/59867815>
623
624         Reviewed by Wenson Hsieh.
625
626         Update test results to reflect the new behavior. To do this I also need to fix up the test code
627         to actually scroll the web content. This also means we now execute the same code on both Mac and
628         iOS to do the scrolling: window.scrollTo(0, 5000). Also fixed up sub-test "Inputs scrolled outside
629         the requested rect; should not be included." to use a 10000px height <div> so that you can scroll
630         to a y position of 5000. Otherwise, it's impossible to do because the page height is < 5000px.
631
632         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
633         (TEST):
634
635 2020-03-02  Jacob Uphoff  <jacob_uphoff@apple.com>
636
637         Unreviewed, rolling out r257687.
638
639         This commit caused debug tests to crash for macOS & iOS
640
641         Reverted changeset:
642
643         "[Cocoa] Mapping from MIME type to UTI type should be done in
644         the UI process"
645         https://bugs.webkit.org/show_bug.cgi?id=208415
646         https://trac.webkit.org/changeset/257687
647
648 2020-03-01  Wenson Hsieh  <wenson_hsieh@apple.com>
649
650         Unreviewed, rolling out r257618.
651
652         This allegedly causes Safari to crash when closing a window
653         (see rdar://problem/59922725).
654
655         Reverted changeset:
656
657         "UIProcess crash after using _prepareForMoveToWindow, then
658         deallocating the WKWebView before moving to the window"
659         https://bugs.webkit.org/show_bug.cgi?id=208365
660         https://trac.webkit.org/changeset/257618
661
662 2020-02-29  Yusuke Suzuki  <ysuzuki@apple.com>
663
664         Remove std::lock_guard
665         https://bugs.webkit.org/show_bug.cgi?id=206451
666
667         Reviewed by Anders Carlsson.
668
669         Add std::lock_guard lint rule to prevent from using it.
670
671         * Scripts/webkitpy/style/checkers/cpp.py:
672         (check_lock_guard):
673         (check_style):
674         (CppChecker):
675         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
676         (WebKitStyleTest.test_lock_guard):
677         * TestWebKitAPI/Tests/WTF/Condition.cpp:
678         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
679         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
680         (assertHasObjects):
681         (assertHasOnlyObjects):
682         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
683         (WTR::AXThread::dispatch):
684         (WTR::AXThread::dispatchFunctionsFromAXThread):
685         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
686         (WTR::AXThread::initializeRunLoop):
687
688 2020-02-29  Per Arne Vollan  <pvollan@apple.com>
689
690         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
691         https://bugs.webkit.org/show_bug.cgi?id=208415
692
693         Reviewed by Brent Fulgham.
694
695         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
696         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
697         (TEST):
698
699 2020-02-28  Fujii Hironori  <Hironori.Fujii@sony.com>
700
701         Unreviewed, rolling out r257565.
702
703         It broke WinCairo MiniBrowser
704
705         Reverted changeset:
706
707         "[CMake] Use WEBKIT_EXECUTABLE in MiniBrowser"
708         https://bugs.webkit.org/show_bug.cgi?id=206894
709         https://trac.webkit.org/changeset/257565
710
711 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
712
713         EWS fails to retry build in case of kill-old-processes exception
714         https://bugs.webkit.org/show_bug.cgi?id=208003
715
716         Reviewed by Jonathan Bedard.
717
718         * BuildSlaveSupport/ews-build/steps.py:
719         (KillOldProcesses.evaluateCommand):
720         (KillOldProcesses.getResultSummary):
721
722 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
723
724         [ews] commit-queue should update the ChangeLog with Reviewer name
725         https://bugs.webkit.org/show_bug.cgi?id=206535
726
727         Reviewed by Jonathan Bedard.
728
729         * BuildSlaveSupport/ews-build/steps.py:
730         (ApplyPatch.start): Update the patch with the patch reviewer name if available.
731
732 2020-02-28  Jonathan Bedard  <jbedard@apple.com>
733
734         run-javascriptcore-tests: Make upload format valid
735         https://bugs.webkit.org/show_bug.cgi?id=208341
736
737         Rubber-stamped by Aakash Jain.
738
739         * Scripts/run-javascriptcore-tests:
740         (uploadResults): Remove. FIXME.
741         * Scripts/webkitdirs.pm:
742         (splitVersionString): Handle case where the subminor version number has a - in it.
743         * Scripts/webkitperl/webkitdirs_unittest/splitVersion.pl: Add unit tests.
744
745 2020-02-28  youenn fablet  <youenn@apple.com>
746
747         [MacOS/iOS] Enable audio/video capture in GPUProcess by default
748         https://bugs.webkit.org/show_bug.cgi?id=208130
749
750         Reviewed by Eric Carlson.
751
752         * WebKitTestRunner/TestOptions.h:
753         Use GPU process to capture by default.
754         We will remove this option once done verifying that every test works smoothly.
755
756 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
757
758         [ews] commit queue should skip building and testing for rollout patches
759         https://bugs.webkit.org/show_bug.cgi?id=208329
760
761         Reviewed by Jonathan Bedard.
762
763         * BuildSlaveSupport/ews-build/steps.py:
764         (BugzillaMixin._is_patch_obsolete): Set rollout property appropriately.
765         (CompileWebKit.doStepIf): Skip tests for rollout patches on commit-queue.
766         (RunWebKit1Tests.doStepIf): Ditto.
767         * BuildSlaveSupport/ews-build/steps_unittest.py:
768         (TestCompileWebKit.test_skip_for_rollout_patches_on_commit_queue): Added unit-test.
769         (TestRunWebKit1Tests.test_skip_for_rollout_patches_on_commit_queue): Ditto.
770
771 2020-02-28  Daniel Bates  <dabates@apple.com>
772
773         Update my watch list preferences and contributor's entry.
774
775         * Scripts/webkitpy/common/config/contributors.json:
776         * Scripts/webkitpy/common/config/watchlist:
777
778 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
779
780         Fix WebCore export macros for declspec
781         https://bugs.webkit.org/show_bug.cgi?id=208363
782
783         Reviewed by Konstantin Tokarev.
784
785         Remove setting of WEBCORE_EXPORT and WEBCORE_TESTSUPPORT_EXPORT from the header
786         files. Removed precompiled headers that were empty.
787
788         * DumpRenderTree/DumpRenderTreePrefix.h:
789         * DumpRenderTree/win/DefaultPolicyDelegate.cpp: Added a missing config.h.
790         * MiniBrowser/win/stdafx.h:
791         * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Removed.
792         * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Removed.
793         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.cpp: Removed.
794         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h: Removed.
795         * WebKitTestRunner/PlatformFTW.cmake:
796         * WebKitTestRunner/PlatformWin.cmake:
797         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
798
799 2020-02-27  Tim Horton  <timothy_horton@apple.com>
800
801         UIProcess crash after using _prepareForMoveToWindow, then deallocating the WKWebView before moving to the window
802         https://bugs.webkit.org/show_bug.cgi?id=208365
803
804         Reviewed by Alex Christensen.
805
806         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
807         (TEST):
808         Add a test! It was a 100% repro crash before this change.
809
810 2020-02-27  Kate Cheney  <katherine_cheney@apple.com>
811
812         TestWebKitAPI and WebKitTestRunner should have bundle identifiers
813         https://bugs.webkit.org/show_bug.cgi?id=208260
814         <rdar://problem/59820107>
815
816         Reviewed by Tim Horton.
817
818         Followed instructions for adding an Info.plist for Single-File Tools
819         found on https://developer.apple.com/library/archive/documentation/Security/Conceptual/CodeSigningGuide/Procedures/Procedures.html
820
821         The default WebsiteDataStore file path will change with this test to
822         reflect the new bundleID so we must change expectations for any api
823         tests which rely on knowing the path.
824
825         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
826         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
827         * TestWebKitAPI/Tests/WebKitCocoa/IDBDeleteRecovery.mm:
828         (TEST):
829         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
830         (TEST):
831         * TestWebKitAPI/Tests/WebKitCocoa/IDBObjectStoreInfoUpgradeToV2.mm:
832         (TEST):
833         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.mm:
834         (TEST):
835         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
836         (TEST):
837         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
838         (TEST):
839         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm:
840         (TEST):
841         (defaultWebsiteCacheDirectory):
842         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageNullEntries.mm:
843         (TEST):
844         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
845         (TEST):
846         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
847         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
848         (TEST):
849         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
850         (TEST):
851         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
852         (runWebsiteDataStoreCustomPaths):
853         (TEST):
854         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
855         (TestWebKitAPI::resetTestState):
856         Now that we set a bundleID, we have to reset the cache model between
857         tests, otherwise it gets stored between tests.
858
859         (TestWebKitAPI::TEST):
860         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
861         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
862
863 2020-02-27  Ryosuke Niwa  <rniwa@webkit.org>
864
865         TextManipulationController should not generate a new item for content in manipulated paragraphs
866         https://bugs.webkit.org/show_bug.cgi?id=208286
867
868         Reviewed by Wenson Hsieh.
869
870         Added a regression test.
871
872         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
873         (TextManipulation.InsertingContentIntoAlreadyManipulatedContentDoesNotCreateTextManipulationItem):
874
875 2020-02-27  Jonathan Bedard  <jbedard@apple.com>
876
877         run-javascriptcore-tests: Make upload format valid
878         https://bugs.webkit.org/show_bug.cgi?id=208341
879
880         Reviewed by Aakash Jain.
881
882         * Scripts/run-javascriptcore-tests:
883         (uploadResults): Print json blob for upload after failure for debugging.
884
885 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
886
887         [CMake] Add WebKit::PAL target
888         https://bugs.webkit.org/show_bug.cgi?id=198493
889
890         Reviewed by Michael Catanzaro.
891
892         Add workaround for Windows where PAL_FRAMEWORK_HEADERS_DIR is not propagating.
893
894         * DumpRenderTree/PlatformWin.cmake:
895
896 2020-02-27  Alex Christensen  <achristensen@webkit.org>
897
898         Add SPI to query WKFrameInfos in a WKWebView
899         https://bugs.webkit.org/show_bug.cgi?id=208212
900
901         Reviewed by Brady Eidson.
902
903         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
904         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp: Removed.
905         * WebKitTestRunner/TestController.cpp:
906         (WTR::TestController::saltForOrigin):
907
908 2020-02-27  Jacob Uphoff  <jacob_uphoff@apple.com>
909
910         Unreviewed, rolling out r257530.
911
912         This commit seems to have broke the build internally for
913         watchOS
914
915         Reverted changeset:
916
917         "Add SPI to query WKFrameInfos in a WKWebView"
918         https://bugs.webkit.org/show_bug.cgi?id=208212
919         https://trac.webkit.org/changeset/257530
920
921 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
922
923         [CMake] Use WEBKIT_EXECUTABLE in MiniBrowser
924         https://bugs.webkit.org/show_bug.cgi?id=206894
925
926         Reviewed by Adrian Perez de Castro.
927
928         Modify CMake ports to use WEBKIT_EXECUTABLE when creating their respective
929         MiniBrowsers.
930
931         * MiniBrowser/gtk/CMakeLists.txt:
932         * MiniBrowser/win/CMakeLists.txt:
933         * MiniBrowser/wpe/CMakeLists.txt:
934
935 2020-02-26  Alex Christensen  <achristensen@webkit.org>
936
937         Remove unused WebsiteDataStore::setSourceApplicationBundleIdentifier
938         https://bugs.webkit.org/show_bug.cgi?id=206456
939
940         Reviewed by Brady Eidson.
941
942         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
943         (TEST):
944
945 2020-02-26  Alex Christensen  <achristensen@webkit.org>
946
947         _WKUserContentWorld should be a wrapper around WKContentWorld
948         https://bugs.webkit.org/show_bug.cgi?id=208274
949
950         Reviewed by Brady Eidson.
951
952         * TestWebKitAPI/Tests/WebKitCocoa/UserContentWorld.mm:
953         (TEST):
954         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
955         (TEST):
956
957 2020-02-26  Ryan Haddad  <ryanhaddad@apple.com>
958
959         Unreviewed, rolling out r257522.
960
961         Caused 16 API test failures on the bots
962
963         Reverted changeset:
964
965         "TestWebKitAPI and WebKitTestRunner should have bundle
966         identifiers"
967         https://bugs.webkit.org/show_bug.cgi?id=208260
968         https://trac.webkit.org/changeset/257522
969
970 2020-02-26  Alex Christensen  <achristensen@webkit.org>
971
972         Add SPI to query WKFrameInfos in a WKWebView
973         https://bugs.webkit.org/show_bug.cgi?id=208212
974
975         Reviewed by Brady Eidson.
976
977         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
978         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp: Removed.
979         * WebKitTestRunner/TestController.cpp:
980         (WTR::TestController::saltForOrigin):
981
982 2020-02-26  Kate Cheney  <katherine_cheney@apple.com>
983
984         TestWebKitAPI and WebKitTestRunner should have bundle identifiers
985         https://bugs.webkit.org/show_bug.cgi?id=208260
986         <rdar://problem/59820107>
987
988         Reviewed by Tim Horton.
989
990         Followed instructions for adding an Info.plist for Single-File Tools
991         found on https://developer.apple.com/library/archive/documentation/Security/Conceptual/CodeSigningGuide/Procedures/Procedures.html
992
993         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
994         * TestWebKitAPI/Info.plist: Added.
995         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
996         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
997         * WebKitTestRunner/Info.plist: Added.
998         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
999
1000 2020-02-26  Kate Cheney  <katherine_cheney@apple.com>
1001
1002         Tests should each use a unique ResourceLoadStatistics file path for its database store
1003         https://bugs.webkit.org/show_bug.cgi?id=208206
1004         <rdar://problem/59690272>
1005
1006         Reviewed by Brady Eidson.
1007
1008         Initialize a default website data store before checking for the ITP
1009         store to ensure the directory exists after the file has been deleted.
1010
1011         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1012         (TEST):
1013
1014 2020-02-26  Christopher Reid  <chris.reid@sony.com>
1015
1016         [Win] Implement NetworkCache::Data by using FileSystem::MappedFileData
1017         https://bugs.webkit.org/show_bug.cgi?id=197684
1018         <rdar://problem/59467397>
1019
1020         Reviewed by Yusuke Suzuki.
1021
1022         Add test for FileSystem::createFile
1023
1024         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
1025
1026 2020-02-26  Aakash Jain  <aakash_jain@apple.com>
1027
1028         [ews] commit-queue should verify patch committer and reviewer
1029         https://bugs.webkit.org/show_bug.cgi?id=206532
1030
1031         Reviewed by Jonathan Bedard.
1032
1033         * BuildSlaveSupport/ews-build/steps.py:
1034         (ValidateCommiterAndReviewer): Build step to validate patch commiter and reviewer.
1035         (ValidateCommiterAndReviewer._addToLog):
1036         (ValidateCommiterAndReviewer.getResultSummary):
1037         (ValidateCommiterAndReviewer.fail_build):
1038         (ValidateCommiterAndReviewer.load_contributors): Load contributors information.
1039         (ValidateCommiterAndReviewer.is_reviewer):
1040         (ValidateCommiterAndReviewer.is_committer):
1041         (ValidateCommiterAndReviewer.full_name_from_email):
1042         (ValidateCommiterAndReviewer.start):
1043
1044 2020-02-26  Daniel Bates  <dabates@apple.com>
1045
1046         [iOS] Send focus update immediately on becoming or resigning first responder
1047         https://bugs.webkit.org/show_bug.cgi?id=208082
1048         <rdar://problem/59688413>
1049
1050         Rubber-stamped by Jer Noble.
1051
1052         Add a test to ensure that selecting a position at a point after the web view
1053         becomes first responder is allowed. Such an operation is only allowed if the
1054         web view is focused.
1055
1056         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
1057         (-[TestWKWebView selectPositionAtPoint:]):
1058         (TEST):
1059         * TestWebKitAPI/ios/UIKitSPI.h: Forward declare SPI.
1060
1061 2020-02-26  Chris Dumez  <cdumez@apple.com>
1062
1063         Unreviewed, disable new DragAndDropTests.DragAndDropOnEmptyView API test on iOS.
1064
1065         The test was added for macOS and times out on iOS.
1066
1067         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
1068         (TEST):
1069
1070 2020-02-26  Youenn Fablet  <youenn@apple.com>
1071
1072         Use WebPageProxy preferences for capture instead of WebProcessPool configuration parameters
1073         https://bugs.webkit.org/show_bug.cgi?id=208238
1074
1075         Reviewed by Eric Carlson.
1076
1077         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1078         (TEST):
1079         Remove use of deleted parameter.
1080
1081 2020-02-25  Devin Rousso  <drousso@apple.com>
1082
1083         Web Inspector: safari app extension isolated worlds and injected files use the extension's identifier instead of its name
1084         https://bugs.webkit.org/show_bug.cgi?id=206911
1085         <rdar://problem/58026635>
1086
1087         Reviewed by Brian Burg.
1088
1089         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1090         (TestWebKitAPI::TEST):
1091         Add test for `WTF::HashSet::reserveInitialCapacity`.
1092
1093         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1094         (TestWebKitAPI::TEST):
1095         Actually check the value of `WTF::HashMap::capacity`.
1096
1097         * TestWebKitAPI/Tests/WebKitCocoa/_WKInspectorDelegate.mm: Added.
1098         (-[InspectorDelegate _webView:didAttachInspector:])
1099         (-[InspectorDelegate _webView:browserDomainEnabledForInspector:])
1100         (-[InspectorDelegate _webView:browserDomainDisabledForInspector:])
1101         (TestWebKitAPI::TEST):
1102         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1103         (-[InspectorDelegate _webView:didAttachInspector:]): Deleted.
1104         (TestWebKitAPI::TEST): Deleted.
1105
1106 2020-02-25  Matt Lewis  <jlewis3@apple.com>
1107
1108         Add checkout_root to stubrepository.py
1109         https://bugs.webkit.org/show_bug.cgi?id=208213
1110
1111         Reviewed by Jonathan Bedard.
1112
1113         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
1114         (StubRepository.__init__):
1115
1116         We are creating our own class variable for checkout_root rather than calling the parent SCM variable
1117         because when initially we left out the parent constructor due to trying to override the fact that we don't actually have a SCM.
1118
1119 2020-02-25  Daniel Bates  <dabates@apple.com>
1120
1121         TestWebKitAPI.PasteMixedContent.CopyAndPasteWithCustomPasteboardDataOnly should wait until copy operation completes
1122         https://bugs.webkit.org/show_bug.cgi?id=208214
1123
1124         Reviewed by Wenson Hsieh.
1125
1126         Wait until the copy operation completes before loading the second web view and testing paste
1127         to ensure that something was actually copied to the clipboard.
1128
1129         * TestWebKitAPI/TestWebKitAPI.xcodeproj/xcshareddata/xcschemes/TestWebKitAPI.xcscheme:
1130         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
1131         (TestWebKitAPI::TEST): Substitute -_synchronouslyExecuteEditCommand for -_executeEditCommand
1132         so that we wait until the command completes.
1133
1134 2020-02-25  Chris Dumez  <cdumez@apple.com>
1135
1136         REGRESSION (r256882): Can't drag an HTML file into a new (empty) Safari tab
1137         https://bugs.webkit.org/show_bug.cgi?id=208199
1138         <rdar://problem/59746887>
1139
1140         Reviewed by Alex Christensen.
1141
1142         Add API test coverage.
1143
1144         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
1145         (TEST):
1146
1147 2020-02-25  Sihui Liu  <sihui_liu@apple.com>
1148
1149         spinRunLoop should take a non-zero integer as parameter
1150         https://bugs.webkit.org/show_bug.cgi?id=208148
1151         <rdar://problem/59766682>
1152
1153         Unreviewed iOS build fix.
1154
1155         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
1156         (TestWebKitAPI::Util::spinRunLoop):
1157
1158 2020-02-25  Sihui Liu  <sihui_liu@apple.com>
1159
1160         spinRunLoop should take a non-zero integer as parameter
1161         https://bugs.webkit.org/show_bug.cgi?id=208148
1162
1163         Reviewed by Darin Adler.
1164
1165         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1166         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1167         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
1168         (TestWebKitAPI::Util::spinRunLoop):
1169
1170 2020-02-24  Yusuke Suzuki  <ysuzuki@apple.com>
1171
1172         [WTF] Add tests for CompactRefPtrTuple
1173         https://bugs.webkit.org/show_bug.cgi?id=208172
1174
1175         Reviewed by Darin Adler.
1176
1177         We copy tests from RefPtr for CompactRefPtrTuple to ensure that it is working correctly.
1178         Many of tests are not necessary since currently CompactRefPtrTuple is non-copyable / non-movable.
1179
1180         * TestWebKitAPI/CMakeLists.txt:
1181         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1182         * TestWebKitAPI/Tests/WTF/CompactRefPtrTuple.cpp: Added.
1183         (TestWebKitAPI::TEST):
1184
1185 2020-02-24  Aakash Jain  <aakash_jain@apple.com>
1186
1187         [ews] commit-queue should check that patch have appropriate review flag
1188         https://bugs.webkit.org/show_bug.cgi?id=208138
1189
1190         Reviewed by Jonathan Bedard.
1191
1192         * BuildSlaveSupport/ews-build/steps.py:
1193         (BugzillaMixin._is_patch_obsolete): Drive-by fix to set build properties for patch author, commiter and reviewer.
1194         (BugzillaMixin._is_patch_cq_plus):
1195         (BugzillaMixin._does_patch_have_acceptable_review_flag): Method to check if patch have r? or r- flag.
1196         (ValidatePatch.start):
1197
1198 2020-02-24  Jiewen Tan  <jiewen_tan@apple.com>
1199
1200         [WebAuthn] Implement SPI for the platform authenticator
1201         https://bugs.webkit.org/show_bug.cgi?id=208087
1202         <rdar://problem/59369305>
1203
1204         Reviewed by Brent Fulgham.
1205
1206         Besides adding API tests, this patch also teaches TestWebKitAPI to use restricted entitlements.
1207
1208         * TestWebKitAPI/Configurations/TestWebKitAPI-macOS.entitlements:
1209         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1210         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1211         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
1212         (-[TestWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:]):
1213         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:completionHandler:]):
1214         (-[TestWebAuthenticationPanelDelegate panel:verifyUserWithAccessControl:completionHandler:]):
1215         (TestWebKitAPI::TEST):
1216         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion.html.
1217         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-duplicate-credential.html: Added.
1218         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-error.html: Added.
1219         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la.html: Added.
1220
1221 2020-02-24  Yusuke Suzuki  <ysuzuki@apple.com>
1222
1223         Unreviewed, updating LLDB test for CompactPointerTuple.
1224         https://bugs.webkit.org/show_bug.cgi?id=207827
1225
1226         * lldb/lldb_webkit.py:
1227         (WTFCompactPointerTupleProvider):
1228         (WTFCompactPointerTupleProvider.update):
1229
1230 2020-02-24  Ellie Epskamp-Hunt  <eepskamphunt@apple.com>
1231
1232         Provide alternate way to name Web Content process
1233         https://bugs.webkit.org/show_bug.cgi?id=205224
1234         rdar://57038084
1235
1236         Reviewed by Alex Christensen.
1237
1238         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1239         * TestWebKitAPI/Tests/WebKitCocoa/DisplayName.mm: Added.
1240         (TestWebKitAPI::TEST):
1241
1242 2020-02-24  Jonathan Bedard  <jbedard@apple.com>
1243
1244         results.webkit.org: Link to result archives
1245         https://bugs.webkit.org/show_bug.cgi?id=207646
1246         <rdar://problem/59395807>
1247
1248         Rubber-stamped by Aakash Jain.
1249
1250         * resultsdbpy/resultsdbpy/view/static/js/archiveRouter.js: Added.
1251         (_ArchiveRouter): Retrieve json from archive-router endpoint.
1252         (_ArchiveRouter.prototype._determineArgumentFromAncestry): Given an argument, default and ancestry values,
1253         return the most specific value.
1254         (_ArchiveRouter.prototype.hasArchive): Check if a suite and mode have an archive link.
1255         (_ArchiveRouter.prototype.pathFor): Construct the path for archive access.
1256         (_ArchiveRouter.prototype.labelFor): Return a label for an archive link.
1257         * resultsdbpy/resultsdbpy/view/static/js/investigate.js:
1258         (parametersForInstance): Extract from lambda function.
1259         (testRunLink): Use parametersForInstance instead of a lambda function.
1260         (archiveLink): Return an archive link for data. 
1261         (contentForData): Add archive link to view.
1262         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
1263         (TimelineFromEndpoint): Accept both suite and test.
1264         (TimelineFromEndpoint.prototype.render.onDotEnterFactory): Add archive link to pop-over.
1265         * resultsdbpy/resultsdbpy/view/templates/search.html: Pass suite and test to TimelineEndpoint.
1266         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Pass suite to TimelineEndpoint.
1267         * resultsdbpy/resultsdbpy/view/view_routes.py:
1268         (ViewRoutes.__init__): Add archive_route dictionary.
1269
1270 2020-02-24  Alex Christensen  <achristensen@webkit.org>
1271
1272         WKWebViewConfiguration._corsDisablingPatterns should also disable CORS for non-DocumentThreadableLoader loading
1273         https://bugs.webkit.org/show_bug.cgi?id=208035
1274         <rdar://problem/58011337>
1275
1276         Reviewed by Tim Hatcher.
1277
1278         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1279
1280 2020-02-22  Darin Adler  <darin@apple.com>
1281
1282         Fix some include mistakes and make some coding style tweaks to WebKit and WebKitTestRunner
1283         https://bugs.webkit.org/show_bug.cgi?id=208099
1284
1285         Reviewed by Antti Koivisto.
1286
1287         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1288         Sorted includes the traditional way. Added an include of AccessibilityCommonMac.h
1289         so we can use the -[NSString createJSStringRef] method.
1290         (-[NSString createJSStringRef]): Deleted. This is a duplicate of the method
1291         defined in AccessibilityCommonMac.mm, and was causing a linker warning.
1292
1293 2020-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1294
1295         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html is failing in iOS 13.4 beta
1296         https://bugs.webkit.org/show_bug.cgi?id=208096
1297         <rdar://problem/59632008>
1298
1299         Reviewed by Alexey Proskuryakov.
1300
1301         In the iOS 13.4 beta, the fix for <rdar://problem/56422337> changed -[UIDatePicker setCalendar:], such that
1302         if the new calendar locale matches that of the current calendar's locale (and several other properties of the
1303         new NSCalendar are also unchanged), then the UIDatePicker's calendar will also avoid changing.
1304
1305         In our layout tests, the mechanism we use to simulate the user changing their preferred calendar is no longer
1306         compatible with the above change since the swizzled NSCalendar instance does not have a locale set, so it will
1307         default to the same locale as the one used in the original NSCalendar. This means the call to -setCalendar: ends
1308         up being a no-op, so the test fails to override the simulated Japanese calendar type with a Gregorian calendar
1309         in the credit card expiry field.
1310
1311         To fix this, additionally specify a calendar locale identifier when generating the mock NSCalendar.
1312
1313         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1314         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1315         (WTR::UIScriptController::setDefaultCalendarType):
1316         * WebKitTestRunner/TestController.h:
1317
1318         Change m_overriddenCalendarIdentifier to m_overriddenCalendarAndLocaleIdentifiers, a pair of calendar
1319         identifier and calendar locale identifier.
1320
1321         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1322         (WTR::swizzledCalendar):
1323         (WTR::TestController::overriddenCalendarIdentifier const):
1324         (WTR::TestController::overriddenCalendarLocaleIdentifier const):
1325
1326         Clean these up by returning the `NSString *` instead of making another `RetainPtr`.
1327
1328         (WTR::TestController::setDefaultCalendarType):
1329
1330         Plumb the new calendar's locale identifier through this method.
1331
1332         (WTR::TestController::cocoaResetStateToConsistentValues):
1333         (WTR::TestController::getOverriddenCalendarIdentifier const): Deleted.
1334         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
1335         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:
1336         (WTR::UIScriptControllerCocoa::setDefaultCalendarType):
1337
1338 2020-02-21  Kate Cheney  <katherine_cheney@apple.com>
1339
1340         App-bound domains should have separate Network Sessions
1341         https://bugs.webkit.org/show_bug.cgi?id=208026
1342         <rdar://problem/59434006>
1343
1344         Reviewed by Brent Fulgham.
1345
1346         This patch is mostly test infrastructure involving 3 functions.
1347         One sets in-app browser privacy as enabled in the network process
1348         manually for the test. One ensures that setting the WebView category
1349         works properly, and the last one checks for an app-bound session for
1350         an app-bound navigation.
1351
1352         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1353         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1354         (WTR::InjectedBundle::didReceiveMessageToPage):
1355         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1356         (WTR::TestRunner::getWebViewCategory):
1357         (WTR::TestRunner::callDidReceiveWebViewCategoryCallback):
1358         (WTR::TestRunner::hasAppBoundSession):
1359         (WTR::TestRunner::setInAppBrowserPrivacyEnabled):
1360         (WTR::TestRunner::callDidSetInAppBrowserPrivacyEnabledCallback):
1361         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1362         * WebKitTestRunner/TestController.cpp:
1363         (WTR::TestController::ensureViewSupportsOptionsForTest):
1364         Clearing the bundleID should happen right before setting a new one, 
1365         otherwise it clears the ID after it is set and returns a null ID.
1366
1367         (WTR::TestController::resetStateToConsistentValues):
1368         (WTR::TestController::getWebViewCategory):
1369         (WTR::InAppBrowserPrivacyCallbackContext::InAppBrowserPrivacyCallbackContext):
1370         (WTR::inAppBrowserPrivacyBooleanResultCallback):
1371         (WTR::inAppBrowserPrivacyVoidResultCallback):
1372         (WTR::TestController::hasAppBoundSession):
1373         (WTR::TestController::setInAppBrowserPrivacyEnabled):
1374         * WebKitTestRunner/TestController.h:
1375         * WebKitTestRunner/TestInvocation.cpp:
1376         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1377         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1378         (WTR::TestInvocation::didSetInAppBrowserPrivacyEnabled):
1379         (WTR::TestInvocation::didReceivePrevalentDomains):
1380         (WTR::TestInvocation::didReceiveWebViewCategory):
1381         * WebKitTestRunner/TestInvocation.h:
1382         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1383         (WTR::TestController::getWebViewCategory):
1384
1385 2020-02-21  Jonathan Bedard  <jbedard@apple.com>
1386
1387         Build DumpRenderTree and WebKitTestRunner for macCatalyst
1388         https://bugs.webkit.org/show_bug.cgi?id=208068
1389         <rdar://problem/59676596>
1390
1391         Reviewed by Tim Horton.
1392
1393         * DumpRenderTree/ios/TextInputControllerIOS.m: Import WebKitLegacy explicitly.
1394         * DumpRenderTree/mac/Configurations/Base.xcconfig: Use cocoatouch instead of SDK.
1395         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Ditto.
1396         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Ditto.
1397         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Ditto.
1398         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Ditto.
1399         * DumpRenderTree/mac/EditingDelegate.mm: Import WebKitLegacy explicitly.
1400         * DumpRenderTree/mac/EventSendingController.h: Ditto.
1401         * DumpRenderTree/mac/ObjCPlugin.m: Ditto.
1402         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Ditto.
1403         * Makefile: Add DumpRenderTree and WebKitTestRunner.
1404         * WebKitTestRunner/Configurations/Base.xcconfig: Use cocoatouch instead of SDK.
1405         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Ditto.
1406         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Ditto.
1407
1408 2020-02-21  Aakash Jain  <aakash_jain@apple.com>
1409
1410         [ews] Add build step to Validate ChangeLog for commit-queue
1411         https://bugs.webkit.org/show_bug.cgi?id=208064
1412
1413         Reviewed by Jonathan Bedard.
1414
1415         * BuildSlaveSupport/ews-build/steps.py:
1416         (ValidateChangeLogAndReviewer): Build step to validate ChangeLog.
1417         (ValidateChangeLogAndReviewer.start):
1418         (ValidateChangeLogAndReviewer.evaluateCommand): If the validation fails, comment on bug and mark patch as cq-.
1419         (SetCommitQueueMinusFlagOnPatch.start): End the build (after marking the patch cq-) if build_finish_summary property is set.
1420
1421 2020-02-21  Aakash Jain  <aakash_jain@apple.com>
1422
1423         [ews] Add build step to set cq- flag on bugzilla patch
1424         https://bugs.webkit.org/show_bug.cgi?id=208021
1425
1426         Reviewed by Jonathan Bedard.
1427
1428         * BuildSlaveSupport/ews-build/steps.py:
1429         (BugzillaMixin.set_cq_minus_flag_on_patch):
1430         (SetCommitQueueMinusFlagOnPatch):
1431         (SetCommitQueueMinusFlagOnPatch.start):
1432         (SetCommitQueueMinusFlagOnPatch.getResultSummary):
1433
1434 2020-02-20  Matt Lewis  <jlewis3@apple.com>
1435
1436         Stub repositories fail to upload some results due to missing head svn revision
1437         https://bugs.webkit.org/show_bug.cgi?id=207684
1438
1439         Reviewed by Jonathan Bedard.
1440
1441         * Scripts/webkitpy/common/host_mock.py: Added in call for creating stub repo checkout information for upload tests.
1442         (MockHost.__init__):
1443         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1444         (summarize_results): Changed call to head_svn_revision to port.commits_for_upload() to bring
1445         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
1446         (SummarizedResultsTest.setUp): Added in new required parameter for testing.
1447         * Scripts/webkitpy/port/base.py:
1448         (Port.commits_for_upload): Removed the forced movement up the systems tree that prevented us 
1449         from using mock SCMs and more
1450         * Scripts/webkitpy/port/test.py: Added function to make the checkout_information.json for upload testing.
1451
1452 2020-02-21  Diego Pino Garcia  <dpino@igalia.com>
1453
1454         [JSCOnly] Add --verbose flag when running JavaScriptCore tests
1455         https://bugs.webkit.org/show_bug.cgi?id=208051
1456
1457         Reviewed by Carlos Alberto Lopez Perez.
1458
1459         Verbose flag prints out each test name executed. Without this flag
1460         stdout prints out one or two periods.
1461
1462         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1463         (RunJavaScriptCoreTests.start):
1464
1465 2020-02-21  Michael Catanzaro  <mcatanzaro@gnome.org>
1466
1467         [WPE][GTK] googleapis.com is a public suffix, defeating isGoogle() check in UserAgentQuirks.cpp
1468         https://bugs.webkit.org/show_bug.cgi?id=207984
1469
1470         Reviewed by Daniel Bates.
1471
1472         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1473         (TestWebKitAPI::TEST):
1474
1475 2020-02-20  Michael Catanzaro  <mcatanzaro@gnome.org>
1476
1477         [GTK] Improve user agent quirk for Google Docs and Google Drive
1478         https://bugs.webkit.org/show_bug.cgi?id=206506
1479
1480         Reviewed by Carlos Garcia Campos.
1481
1482         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1483         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
1484         (TestWebKitAPI::TEST):
1485
1486 2020-02-20  Fujii Hironori  <Hironori.Fujii@sony.com>
1487
1488         check-webkit-style: Check if *_EXPORT and *_EXPORT_PRIVATE macros are used under corresponding directories
1489         https://bugs.webkit.org/show_bug.cgi?id=207380
1490
1491         Reviewed by Jonathan Bedard.
1492
1493         Added a new rule 'build/export_macro'.
1494
1495         Removed a obsolete rule 'readability/webkit_export' which was used
1496         only by Chromium port (r148185).
1497
1498         * Scripts/webkitpy/style/checkers/cpp.py:
1499         (_FunctionState.export_macro):
1500         (check_function_definition):
1501         (_unix_path): Added.
1502         (is_generated_file): Use _unix_path.
1503         (check_has_config_header): Ditto.
1504         (CppChecker):
1505         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1506         (WebKitStyleTest.test_export_macro_check):
1507         (WebKitStyleTest.test_webkit_export_check): Deleted.
1508
1509 2020-02-20  Fujii Hironori  <Hironori.Fujii@sony.com>
1510
1511         [Win][MiniBrowser] Add prettier toolbar button icons
1512         https://bugs.webkit.org/show_bug.cgi?id=207999
1513
1514         Reviewed by Ross Kirsling.
1515
1516         Use a custom toolbar button icons instead of system stock icons.
1517
1518         Fixed a bug toolbar button dropdown arrows always looked being
1519         hovered. TBSTYLE_FLAT should be given.
1520
1521         Removed the window border line of Progress Indicator.
1522
1523         * MiniBrowser/win/MainWindow.cpp:
1524         (MainWindow::createToolbar):
1525         * MiniBrowser/win/MiniBrowserLib.rc:
1526         * MiniBrowser/win/MiniBrowserLibResource.h:
1527         * MiniBrowser/win/toolbar.bmp: Added.
1528
1529 2020-02-20  Aakash Jain  <aakash_jain@apple.com>
1530
1531         Update run-webkit-tests help description for skip-failing-tests
1532         https://bugs.webkit.org/show_bug.cgi?id=208031
1533
1534         Reviewed by Alexey Proskuryakov.
1535
1536         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1537
1538 2020-02-20  Chris Dumez  <cdumez@apple.com>
1539
1540         REGRESSION (r255677): Reloading tab with beforeunload prompt closes tab when asking to stay on page
1541         https://bugs.webkit.org/show_bug.cgi?id=208015
1542         <rdar://problem/59591630>
1543
1544         Reviewed by Geoffrey Garen.
1545
1546         Add API test coverage.
1547
1548         * TestWebKitAPI/Tests/WebKitCocoa/ModalAlerts.mm:
1549         (TEST):
1550
1551 2020-02-20  Tim Horton  <timothy_horton@apple.com>
1552
1553         WKWebView with non-zero origin has the wrong top content inset with NSWindowStyleMaskFullSizeContentView
1554         https://bugs.webkit.org/show_bug.cgi?id=207998
1555         <rdar://problem/40942425>
1556
1557         Reviewed by Sam Weinig.
1558
1559         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1560         * TestWebKitAPI/Tests/WebKitCocoa/TopContentInset.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm.
1561         (-[FullscreenChangeMessageHandler userContentController:didReceiveScriptMessage:]):
1562         (TestWebKitAPI::TEST):
1563         Add some tests for top content insets.
1564
1565 2020-02-20  Jonathan Bedard  <jbedard@apple.com>
1566
1567         results.webkit.org: Correctly report JSC tests for windows (Follow-up fix)
1568         https://bugs.webkit.org/show_bug.cgi?id=207910
1569
1570         Unreviewed infrastructure fix.
1571
1572         * Scripts/run-javascriptcore-tests:
1573         (configurationForUpload): Use the major version instead of the sub-minor version
1574         for version name.
1575
1576 2020-02-20  Don Olmstead  <don.olmstead@sony.com>
1577
1578         [CMake] Add WPE::libwpe target
1579         https://bugs.webkit.org/show_bug.cgi?id=207970
1580
1581         Reviewed by Adrian Perez de Castro.
1582
1583         Use the WPE::libwpe target.
1584
1585         * MiniBrowser/wpe/CMakeLists.txt:
1586         * TestWebKitAPI/PlatformWPE.cmake:
1587         * TestWebKitAPI/glib/PlatformWPE.cmake:
1588         * wpe/backends/CMakeLists.txt:
1589
1590 2020-02-19  Fujii Hironori  <Hironori.Fujii@sony.com>
1591
1592         [Win][MiniBrowser] Add 'Go Home' menu item and toolbar button
1593         https://bugs.webkit.org/show_bug.cgi?id=207749
1594
1595         Reviewed by Ross Kirsling.
1596
1597         Added "Set Default URL to Current URL" menu item like Mac MiniBrowser.
1598
1599         * MiniBrowser/win/MainWindow.cpp:
1600         (MainWindow::createToolbar):
1601         (MainWindow::WndProc):
1602         (MainWindow::setDefaultURLToCurrentURL):
1603         (MainWindow::goHome): Added.
1604         (MainWindow::onURLBarEnter):
1605         * MiniBrowser/win/MainWindow.h:
1606         * MiniBrowser/win/MiniBrowserLib.rc:
1607         * MiniBrowser/win/MiniBrowserLibResource.h:
1608         * MiniBrowser/win/MiniBrowserReplace.h:
1609         * MiniBrowser/win/WinMain.cpp:
1610         (wWinMain):
1611
1612 2020-02-19  Peng Liu  <peng.liu6@apple.com>
1613
1614         Fix check-webkit-style errors related to AVFoundationSPI.h
1615         https://bugs.webkit.org/show_bug.cgi?id=207834
1616
1617         Reviewed by Daniel Bates.
1618
1619         Revert the change in r256770 regarding the headers ordering.
1620         Headers in the same category should be in sorted order (case sensitive, as done by the command-line sort tool or the Xcode sort selection command).
1621
1622         * Scripts/webkitpy/style/checkers/cpp.py:
1623         (check_include_line):
1624
1625 2020-02-19  Jonathan Bedard  <jbedard@apple.com>
1626
1627         results.webkit.org: Correctly report JSC tests for windows
1628         https://bugs.webkit.org/show_bug.cgi?id=207910
1629
1630         Rubber-stamped by Aakash Jain.
1631
1632         * Scripts/run-javascriptcore-tests:
1633         (configurationForUpload): Give Windows a version name.
1634         * Scripts/webkitdirs.pm:
1635         (determineWinVersion): Correctly parse Windows 10 version numbers, conform to
1636         Version dictionary.
1637
1638 2020-02-19  Chris Dumez  <cdumez@apple.com>
1639
1640         Unreviewed, fix assertions in storage access API layout tests after r256882.
1641
1642         Drop dead testRunner code to toggle storage access API feature.
1643
1644         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1645         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1646         (WTR::TestRunner::setStorageAccessAPIEnabled): Deleted.
1647         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1648         * WebKitTestRunner/TestInvocation.cpp:
1649         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1650
1651 2020-02-18  Zan Dobersek  <zdobersek@igalia.com>
1652
1653         [WPE] Support 2D axis, smooth-motion events
1654         https://bugs.webkit.org/show_bug.cgi?id=207881
1655
1656         Reviewed by Carlos Garcia Campos.
1657
1658         * wpe/jhbuild.modules: Bump to a newer libwpe commit.
1659
1660 2020-02-18  Ryan Haddad  <ryanhaddad@apple.com>
1661
1662         Unreviewed, rolling out r256851.
1663
1664         Broke internal bots
1665
1666         Reverted changeset:
1667
1668         "Stub repositories fail to upload some results due to missing
1669         head svn revision"
1670         https://bugs.webkit.org/show_bug.cgi?id=207684
1671         https://trac.webkit.org/changeset/256851
1672
1673 2020-02-18  Fujii Hironori  <Hironori.Fujii@sony.com>
1674
1675         [Win][MiniBrowser] Support back/forward mouse buttons by handing APPCOMMAND_BROWSER_BACKWARD and APPCOMMAND_BROWSER_FORWARD
1676         https://bugs.webkit.org/show_bug.cgi?id=207883
1677
1678         Reviewed by Ross Kirsling.
1679
1680         Unlike other mouse buttons, 4th and 5th mouse buttons are
1681         processed differently. Clicking them dispatches WM_XBUTTONDOWN and
1682         WM_XBUTTONUP events to the window under the mouse cursor.
1683         Unhandled WM_XBUTTONUP events are automatically converted to
1684         WM_APPCOMMAND. And, unhandle WM_APPCOMMAND are propagated to the
1685         parent window.
1686         <https://docs.microsoft.com/en-us/windows/win32/inputdev/wm-appcommand>
1687
1688         Unlike other WM_* commands, WM_APPCOMMAND should return 1 if it is
1689         handled.
1690
1691         * MiniBrowser/win/BrowserWindow.h:
1692         * MiniBrowser/win/MainWindow.cpp:
1693         (MainWindow::WndProc):
1694         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1695         (WebKitBrowserWindow::navigateForwardOrBackward):
1696         * MiniBrowser/win/WebKitBrowserWindow.h:
1697         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
1698         (WebKitLegacyBrowserWindow::navigateForwardOrBackward):
1699         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
1700
1701 2020-02-18  Alex Christensen  <achristensen@webkit.org>
1702
1703         Expand WKRemoteObjectCoder supported POD types to encode NSURLResponse types
1704         https://bugs.webkit.org/show_bug.cgi?id=207912
1705         <rdar://problem/59556922>
1706
1707         Reviewed by Brian Weinstein.
1708
1709         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
1710         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
1711         (TEST):
1712         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
1713         (-[RemoteObjectRegistryPlugIn sendRequest:response:challenge:error:completionHandler:]):
1714
1715 2020-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1716
1717         [macOS] Web process may crash under ServicesOverlayController::buildPotentialHighlightsIfNeeded
1718         https://bugs.webkit.org/show_bug.cgi?id=207899
1719         <rdar://problem/55658207>
1720
1721         Reviewed by Tim Horton and Simon Fraser.
1722
1723         Make it possible to run tests on macOS with services controls enabled, via a new TestOptions flag.
1724
1725         * WebKitTestRunner/TestController.cpp:
1726         (WTR::updateTestOptionsFromTestHeader):
1727         * WebKitTestRunner/TestOptions.h:
1728         (WTR::TestOptions::hasSameInitializationOptions const):
1729         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1730         (WTR::TestController::platformCreateWebView):
1731
1732 2020-02-18  Matt Lewis  <jlewis3@apple.com>
1733
1734         Stub repositories fail to upload some results due to missing head svn revision
1735         https://bugs.webkit.org/show_bug.cgi?id=207684
1736
1737         Reviewed by Jonathan Bedard.
1738
1739         * Scripts/webkitpy/api_tests/run_api_tests.py:
1740         (main): Added initializing the scm to the host object.
1741         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1742         (summarize_results): Changed call to head_svn_revision to port.commits_for_upload() to bring
1743         it in line with modern code.
1744         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1745         (main): Added inializing the scm to the host object.
1746         * Scripts/webkitpy/port/base.py:
1747         (Port.commits_for_upload): Removed the forced movement up the systems tree that prevented us
1748         from using mock SCMs and more
1749         * Scripts/webkitpy/test/main.py:
1750         (main):  Removed the forced movement up the systems tree, initialized the SCM on the host object,
1751         and converted the webkit_root variable to the SCM checkout root.
1752         (Tester._run_tests):
1753
1754 2020-02-18  Per Arne Vollan  <pvollan@apple.com>
1755
1756         Move [UIDevice currentDevice] calls to UI process
1757         https://bugs.webkit.org/show_bug.cgi?id=204320
1758
1759         Reviewed by Darin Adler.
1760
1761         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1762         * TestWebKitAPI/Tests/WebKit/LocalizedDeviceModel.mm: Added.
1763         (TEST):
1764
1765 2020-02-18  Simon Fraser  <simon.fraser@apple.com>
1766
1767         Move from "layer flush" terminology to "rendering update"
1768         https://bugs.webkit.org/show_bug.cgi?id=207870
1769
1770         Reviewed by Tim Horton.
1771
1772         Rename various functions and member variables to move away from the legacy "layer flush"
1773         terminology and instead use "rendering update", matching Page::updateRendering(). The fact
1774         that we have layers is an implementation detail.
1775         
1776         Change LayerFlushThrottlingState to be an OptionSet<>.
1777
1778         * Tracing/SystemTracePoints.plist:
1779
1780 2020-02-17  Zhifei Fang  <zhifei_fang@apple.com>
1781
1782         [Webkit.css] Adding popover style element
1783         This help to prevent us reinventing the wheel ever again
1784         https://bugs.webkit.org/show_bug.cgi?id=207787
1785
1786         Reviewed by Dean Jackson.
1787
1788         * resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml:
1789         * resultsdbpy/resultsdbpy/view/static/library/css/index.html:
1790         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
1791         (.popover):
1792         (.popover>.content):
1793         (.popover.display):
1794         (.popover .arrow):
1795         (.popover .arrow.point-top):
1796         (.popover .arrow.point-bottom):
1797         (.popover .arrow.point-left):
1798         (.popover .arrow.point-right):
1799         (@media (prefers-color-scheme: dark) .popover>.content):
1800         (@media (prefers-color-scheme: dark) .popover.display):
1801         (@media (prefers-color-scheme: dark) .popover .arrow):
1802         (.popover>.content>.section): Deleted.
1803         (.popover:focus>.content, .popover:hover>.content): Deleted.
1804         (.popover.right>.content): Deleted.
1805         (.popover.right :focus>.content, .popover.right:hover>.content): Deleted.
1806         (.popover.left>.content): Deleted.
1807         (.popover.left :focus>.content, .popover.left:hover>.content): Deleted.
1808         (.popover.bottom>.content): Deleted.
1809         (.popover.bottom :focus>.content, .popover.bottom:hover>.content): Deleted.
1810
1811 2020-02-17  Brent Fulgham  <bfulgham@apple.com>
1812
1813         Update WebKit Tools to issue mach extensions as needed
1814         https://bugs.webkit.org/show_bug.cgi?id=207850
1815         <rdar://problem/59521019>
1816
1817         Reviewed by Per Arne Vollan.
1818
1819         Revise the codesign settings for our testing tools to allow the process to vend mach extensions
1820         to its child processes (WebContent, GPU, Network, etc.) as needed.
1821
1822         * MiniBrowser/MiniBrowser.entitlements:
1823         * TestWebKitAPI/Configurations/TestWebKitAPI-macOS.entitlements: Added.
1824         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1825         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1826         * WebKitTestRunner/Configurations/WebKitTestRunner.entitlements:
1827
1828 2020-02-17  Peng Liu  <peng.liu6@apple.com>
1829
1830         Fix check-webkit-style errors related to AVFoundationSPI.h
1831         https://bugs.webkit.org/show_bug.cgi?id=207834
1832
1833         Reviewed by Eric Carlson.
1834
1835         We need to use case-insensitive comparison to check whether the headers are alphabetically sorted in each header section.
1836         Soft-link headers can be included as either "file.h" or <file.h>.
1837
1838         * Scripts/webkitpy/style/checkers/cpp.py:
1839         (_classify_include):
1840         (check_include_line):
1841
1842 2020-02-17  Keith Rollin  <krollin@apple.com>
1843
1844         Unreviewed build fix after r256715.
1845
1846         Fix tvOS and watchOS builds.
1847
1848         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
1849
1850 2020-02-17  Per Arne Vollan  <pvollan@apple.com>
1851
1852         Use CF prefs direct mode in the WebContent process
1853         https://bugs.webkit.org/show_bug.cgi?id=203420
1854
1855         Reviewed by Brent Fulgham.
1856
1857         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1858         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm: Added.
1859         (TEST):
1860
1861 2020-02-17  Aakash Jain  <aakash_jain@apple.com>
1862
1863         EWS should be able to file Bugzilla bugs
1864         https://bugs.webkit.org/show_bug.cgi?id=207845
1865
1866         Reviewed by Alexey Proskuryakov.
1867
1868         * BuildSlaveSupport/ews-build/steps.py:
1869         (BugzillaMixin.create_bug): Method to file bugzilla bug using bugzilla REST API.
1870
1871 2020-02-17  Aakash Jain  <aakash_jain@apple.com>
1872
1873         EWS should be able to comment on Bugzilla
1874         https://bugs.webkit.org/show_bug.cgi?id=201927
1875
1876         Reviewed by Jonathan Bedard.
1877
1878         * BuildSlaveSupport/ews-build/steps.py:
1879         (BugzillaMixin.comment_on_bug): Method to comment on bugzilla bug.
1880         (BugzillaMixin.remove_flags_on_patch): Drive-by fix to correctly identify failure based on status code.
1881         (BugzillaMixin.close_bug): Ditto.
1882         (CommentOnBug): Build step to comment on bugzilla bug.
1883
1884 2020-02-17  Antti Koivisto  <antti@apple.com>
1885
1886         [macOS] Add trace points for layer flush runloop observer
1887         https://bugs.webkit.org/show_bug.cgi?id=207837
1888
1889         Reviewed by Sam Weinig.
1890
1891         * Tracing/SystemTracePoints.plist:
1892
1893 2020-02-17  Don Olmstead  <don.olmstead@sony.com>
1894
1895         [CMake] Use builtin targets
1896         https://bugs.webkit.org/show_bug.cgi?id=205166
1897
1898         Reviewed by Darin Adler.
1899
1900         * TestWebKitAPI/PlatformWin.cmake:
1901
1902 2020-02-17  Aakash Jain  <aakash_jain@apple.com>
1903
1904         [ews] add SetBuildSummary step for Windows EWS
1905         https://bugs.webkit.org/show_bug.cgi?id=207556
1906
1907         Reviewed by Jonathan Bedard.
1908
1909         * BuildSlaveSupport/ews-build/factories.py:
1910         (WindowsFactory.__init__):
1911         (GTKBuildAndTestFactory.__init__):
1912         * BuildSlaveSupport/ews-build/factories_unittest.py:
1913         (TestBuildAndTestsFactory.test_windows_factory): Added unit-test.
1914
1915 2020-02-17  Alberto Garcia  <berto@igalia.com>
1916
1917         [WPE] Change the QML plugin install path
1918         https://bugs.webkit.org/show_bug.cgi?id=207761
1919
1920         Reviewed by Philippe Normand.
1921
1922         * Scripts/run-qt-wpe-minibrowser:
1923         * glib/api_test_runner.py:
1924         (TestRunner._run_test_qt):
1925
1926 2020-02-16  Fujii Hironori  <Hironori.Fujii@sony.com>
1927
1928         Remove remaining WTF_EXPORT and WTF_IMPORT by replacing them with WTF_EXPORT_DECLARATION and WTF_IMPORT_DECLARATION
1929         https://bugs.webkit.org/show_bug.cgi?id=207746
1930
1931         Reviewed by Don Olmstead.
1932
1933         * MiniBrowser/win/stdafx.h:
1934
1935 2020-02-16  Brady Eidson  <beidson@apple.com>
1936
1937         Expose "allowsContentJavaScript" on WKWebpagePreferences
1938         <rdar://problem/51534967> and https://bugs.webkit.org/show_bug.cgi?id=207427
1939
1940         Reviewed by Darin Adler.
1941
1942         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
1943         (TEST):
1944         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1945         (-[WebsitePoliciesNavigationDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
1946         (TEST):
1947         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:preferences:userInfo:decisionHandler:]): Deleted.
1948         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
1949         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1950         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
1951         (-[TestNavigationDelegate waitForDidFinishNavigationWithPreferences:]):
1952         (-[WKWebView _test_waitForDidFinishNavigationWithPreferences:]):
1953         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
1954         * TestWebKitAPI/cocoa/TestWKWebView.h:
1955         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1956         (-[WKWebView synchronouslyLoadHTMLString:preferences:]):
1957
1958 2020-02-14  Yusuke Suzuki  <ysuzuki@apple.com>
1959
1960         NetworkLoadMetrics should be shared by multiple ResourceResponse instances
1961         https://bugs.webkit.org/show_bug.cgi?id=207747
1962
1963         Reviewed by Keith Miller.
1964
1965         * TestWebKitAPI/Tests/WebCore/ParsedContentRange.cpp:
1966         (TestWebKitAPI::TEST):
1967
1968 2020-02-14  Alex Christensen  <achristensen@webkit.org>
1969
1970         Allow UIDNAInfo.errors from uidna_nameToUnicode that would not cause URL parsing failures
1971         https://bugs.webkit.org/show_bug.cgi?id=207360
1972         <rdar://problem/57825317>
1973
1974         Reviewed by Ryosuke Niwa.
1975
1976         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
1977         (TestWebKitAPI::TEST):
1978
1979 2020-02-14  Don Olmstead  <don.olmstead@sony.com>
1980
1981         [CMake] Add Fontconfig::Fontconfig target
1982         https://bugs.webkit.org/show_bug.cgi?id=207730
1983
1984         Reviewed by Adrian Perez de Castro.
1985
1986         Use the Fontconfig::Fontconfig target.
1987
1988         * WebKitTestRunner/PlatformGTK.cmake:
1989
1990 2020-02-13  Kate Cheney  <katherine_cheney@apple.com>
1991
1992          Expose prevalent domains on a per-page basis
1993          https://bugs.webkit.org/show_bug.cgi?id=207523
1994          <rdar://problem/59270758>
1995
1996         Reviewed by Chris Dumez.
1997
1998         Added WebKitTestRunner functions so this functionality can be tested.
1999         clearPrevalentDomains should be called between tests to reset the
2000         state.
2001
2002         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2003         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2004         (WTR::InjectedBundle::didReceiveMessageToPage):
2005         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2006         (WTR::TestRunner::getPrevalentDomains):
2007         (WTR::TestRunner::callDidReceivePrevalentDomainsCallback):
2008         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2009         * WebKitTestRunner/TestController.cpp:
2010         (WTR::TestController::resetStateToConsistentValues):
2011         (WTR::TestController::getPrevalentDomains):
2012         (WTR::TestController::clearPrevalentDomains):
2013         * WebKitTestRunner/TestController.h:
2014         * WebKitTestRunner/TestInvocation.cpp:
2015         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2016         (WTR::TestInvocation::didReceivePrevalentDomains):
2017         * WebKitTestRunner/TestInvocation.h:
2018         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2019         (WTR::TestController::getPrevalentDomains):
2020         (WTR::TestController::clearPrevalentDomains):
2021
2022 2020-02-13  Fujii Hironori  <Hironori.Fujii@sony.com>
2023
2024         [Win][MiniBrowser] Reimplement the toolbar by using toolbar common control
2025         https://bugs.webkit.org/show_bug.cgi?id=207682
2026
2027         Reviewed by Ross Kirsling.
2028
2029         The toolbar placed button common controls as the toolbar buttons.
2030         However, because these buttons are focusable, shortcut keys don't
2031         work after clicking them.
2032
2033         Added Home button, Add to Bookmarks button, dropdown buttons of
2034         back and forward buttons, but they aren't implemented yet. Just
2035         placeholders at the moment.
2036
2037         * MiniBrowser/win/MainWindow.cpp:
2038         (MainWindow::createToolbar): Added.
2039         (MainWindow::resizeToolbar): Added.
2040         (MainWindow::rescaleToolbar): Added.
2041         (MainWindow::init):
2042         (MainWindow::resizeSubViews):
2043         (MainWindow::updateDeviceScaleFactor):
2044         * MiniBrowser/win/MainWindow.h: Added m_toolbarItemsWidth.
2045
2046 2020-02-13  Ryosuke Niwa  <rniwa@webkit.org>
2047
2048         Dark Mode: In Notes, list item becomes invisible in dark mode after outdenting
2049         https://bugs.webkit.org/show_bug.cgi?id=207676
2050
2051         Reviewed by Wenson Hsieh and Timothy Hatcher.
2052
2053         Added regression tests for pasting content with -apple-system-label and outdenting content.
2054
2055         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
2056         (PasteHTML.TransformColorsOfDarkContentButNotSemanticColor):
2057         (PasteHTML.DoesNotTransformColorsOfLightContentDuringOutdent):
2058
2059 2020-02-13  Alex Christensen  <achristensen@webkit.org>
2060
2061         _WKResourceLoadInfo should conform to NSSecureCoding
2062         https://bugs.webkit.org/show_bug.cgi?id=207667
2063
2064         Reviewed by Brady Eidson.
2065
2066         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2067         (TEST):
2068
2069 2020-02-13  Stephan Szabo  <stephan.szabo@sony.com>
2070
2071         [PlayStation] Add Buildbots for Debug/Release builds
2072         https://bugs.webkit.org/show_bug.cgi?id=199454
2073
2074         Reviewed by Aakash Jain.
2075
2076         * BuildSlaveSupport/build.webkit.org-config/config.json:
2077         Add PlayStation slaves, builders
2078         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2079         Use higher timeout for playstation as with win bot
2080         * BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
2081         Set PlayStation category for playstation platform
2082         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2083         Use same path as gtk, wincairo, etc for appendCustomBuildFlags
2084         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2085         Add PlayStation expectations
2086
2087 2020-02-13  Per Arne Vollan  <pvollan@apple.com>
2088
2089         [iOS] Check if PIP is supported in the UI process
2090         https://bugs.webkit.org/show_bug.cgi?id=207406
2091
2092         Reviewed by Brent Fulgham.
2093
2094         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2095         * TestWebKitAPI/Tests/WebKit/PictureInPictureSupport.mm: Added.
2096         (TEST):
2097
2098 2020-02-13  Jonathan Bedard  <jbedard@apple.com>
2099
2100         TestWebKitAPI: Conditionalize fullscreen tests on fullscreen API
2101         https://bugs.webkit.org/show_bug.cgi?id=207397
2102         <rdar://problem/59268128>
2103
2104         Reviewed by Jer Noble.
2105
2106         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
2107         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm:
2108
2109 2020-02-13  Jonathan Bedard  <jbedard@apple.com>
2110
2111         TestWebKitAPI: Re-baseline DocumentEditingContext for Catalyst
2112         https://bugs.webkit.org/show_bug.cgi?id=207696
2113
2114         Reviewed by Tim Horton.
2115
2116         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2117
2118 2020-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2119
2120         [iOS] -updateSelectionWithExtentPoint:completionHandler: should work without requiring floating cursor
2121         https://bugs.webkit.org/show_bug.cgi?id=207680
2122         <rdar://problem/59340940>
2123
2124         Reviewed by Tim Horton.
2125
2126         Add a new API test to verify that calling -updateSelectionWithExtentPoint:completionHandler: with a point behind
2127         the current selection works.
2128
2129         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
2130         (-[TestWKWebView updateSelectionWithExtentPoint:]):
2131         * TestWebKitAPI/ios/UIKitSPI.h:
2132
2133 2020-02-13  Said Abou-Hallawa  <said@apple.com>
2134
2135         Unreviewed, rolling out r255158, 255405 and r255486
2136
2137         Caused test flakiness and PLT regression.
2138
2139         * DumpRenderTree/mac/DumpRenderTree.mm:
2140         (resetWebPreferencesToConsistentValues):
2141         * DumpRenderTree/win/DumpRenderTree.cpp:
2142         (enableExperimentalFeatures):
2143         * WebKitTestRunner/TestController.cpp:
2144         (WTR::TestController::resetPreferencesToConsistentValues):
2145
2146 2020-02-12  Jonathan Bedard  <jbedard@apple.com>
2147
2148         run-javascriptcore-tests: Allow insecure requests on upload
2149         https://bugs.webkit.org/show_bug.cgi?id=207662
2150
2151         Rubber-stamped by Aakash Jain.
2152
2153         * Scripts/run-javascriptcore-tests:
2154         (uploadResults): Allow insecure curl request when posting results.
2155
2156 2020-02-12  Truitt Savell  <tsavell@apple.com>
2157
2158         Unreviewed, rolling out r256463.
2159
2160         Caused major flakiness on Mac wk2
2161
2162         Reverted changeset:
2163
2164         "REGRESSION (r255158): http/tests/frame-throttling/raf-
2165         throttle-in-cross-origin-subframe.html is a flaky failure"
2166         https://bugs.webkit.org/show_bug.cgi?id=206839
2167         https://trac.webkit.org/changeset/256463
2168
2169 2020-02-12  Jonathan Bedard  <jbedard@apple.com>
2170
2171         results.webkit.org: Remove debug JS logging
2172         https://bugs.webkit.org/show_bug.cgi?id=207663
2173
2174         Reviewed by Aakash Jain.
2175
2176         * resultsdbpy/resultsdbpy/view/static/js/investigate.js:
2177         (elapsed):
2178         * resultsdbpy/resultsdbpy/view/static/js/tooltip.js:
2179         (_ToolTip.prototype.toString):
2180         * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js:
2181         (prototype.addWithDelay):
2182         * resultsdbpy/resultsdbpy/view/templates/archive_list.html:
2183
2184 2020-02-12  Simon Fraser  <simon.fraser@apple.com>
2185
2186         Remove CSS_DEVICE_ADAPTATION
2187         https://bugs.webkit.org/show_bug.cgi?id=203479
2188
2189         Reviewed by Tim Horton.
2190         
2191         CSS Working Group resolved to remove @viewport <https://github.com/w3c/csswg-drafts/issues/4766>,
2192         so remove the code.
2193
2194         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2195
2196 2020-02-12  Said Abou-Hallawa  <said@apple.com>
2197
2198         REGRESSION (r255158): http/tests/frame-throttling/raf-throttle-in-cross-origin-subframe.html is a flaky failure
2199         https://bugs.webkit.org/show_bug.cgi?id=206839
2200
2201         Reviewed by Simon Fraser.
2202
2203         Remove the WKPreference key 'RenderingUpdateThrottlingEnabled'.
2204
2205         * DumpRenderTree/mac/DumpRenderTree.mm:
2206         (resetWebPreferencesToConsistentValues):
2207         * DumpRenderTree/win/DumpRenderTree.cpp:
2208         (enableExperimentalFeatures):
2209         * WebKitTestRunner/TestController.cpp:
2210         (WTR::TestController::resetPreferencesToConsistentValues):
2211
2212 2020-02-12  Jonathan Bedard  <jbedard@apple.com>
2213
2214         results.webkit.org: Cache archive content
2215         https://bugs.webkit.org/show_bug.cgi?id=207589
2216
2217         Reviewed by Aakash Jain.
2218
2219         * resultsdbpy/resultsdbpy/flask_support/util.py:
2220         (cache_for): Add decorator function which sets the cache values on the returned response.
2221         * resultsdbpy/resultsdbpy/view/archive_view.py:
2222         (ArchiveView): Cache archive content client-side for 12 hours.
2223         * resultsdbpy/resultsdbpy/view/archive_view_unittest.py:
2224         (ArchiveViewUnittest.test_file): Verify that archived content is cached.
2225
2226 2020-02-12  Youenn Fablet  <youenn@apple.com>
2227
2228         WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
2229         https://bugs.webkit.org/show_bug.cgi?id=207537
2230
2231         Reviewed by Chris Dumez.
2232
2233         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2234
2235 2020-02-11  Rob Buis  <rbuis@igalia.com>
2236
2237         Bug 207424: Crash in WebCore::ParsedContentType::parseContentType when parsing invalid MIME type
2238         <https://webkit.org/b/207424>
2239         <rdar://problem/59250384>
2240
2241         Reviewed by Rob Buis.
2242
2243         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2244         (TestWebKitAPI::TEST): Add more tests.
2245
2246 2020-02-11  Commit Queue  <commit-queue@webkit.org>
2247
2248         Unreviewed, rolling out r256314.
2249         https://bugs.webkit.org/show_bug.cgi?id=207594
2250
2251         It is breaking an API test (Requested by youenn on #webkit).
2252
2253         Reverted changeset:
2254
2255         "WebSWServerConnection::registerServiceWorkerClient is not
2256         sending IPC message to UIProcess when it should"
2257         https://bugs.webkit.org/show_bug.cgi?id=207537
2258         https://trac.webkit.org/changeset/256314
2259
2260 2020-02-11  Jonathan Bedard  <jbedard@apple.com>
2261
2262         results.webkit.org: Configuration documentation should include architecture
2263         https://bugs.webkit.org/show_bug.cgi?id=207584
2264
2265         Reviewed by Aakash Jain.
2266
2267         * resultsdbpy/resultsdbpy/view/templates/documentation.html: Add architecture documentation.
2268
2269 2020-02-11  Youenn Fablet  <youenn@apple.com>
2270
2271         Regression: RTCRtpSender.getCapabilities("video") returns null on iOS 13.4 (17E5223h)
2272         https://bugs.webkit.org/show_bug.cgi?id=207325
2273         <rdar://problem/59224810>
2274
2275         Reviewed by Eric Carlson.
2276
2277         * TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:
2278         (TestWebKitAPI::TEST):
2279         Add a test validating that RTCRtpSender.getCapabilities does not return null.
2280         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2281
2282 2020-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2283
2284         KeyboardInputTests.SupportsImagePaste fails on recent versions of UIKit
2285         https://bugs.webkit.org/show_bug.cgi?id=207557
2286
2287         Reviewed by Jonathan Bedard.
2288
2289         The exception occurs because UIKit attempts to create a QoS interval upon setting the initially selected row in
2290         a UITableView when we focus a date picker. This fails because TestWebKitAPI isn't actually an app, so the call
2291         to `work_interval_create` with `WORK_INTERVAL_TYPE_CA_CLIENT` as the option flag fails. For the time being, work
2292         around this by focusing an empty select element instead (for which we won't attempt to create and select any
2293         table view cells).
2294
2295         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2296
2297 2020-02-11  Alex Christensen  <achristensen@webkit.org>
2298
2299         Add WKHTTPCookieStore._getCookiesForURL SPI
2300         https://bugs.webkit.org/show_bug.cgi?id=207527
2301
2302         Reviewed by Brady Eidson.
2303
2304         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2305         (TEST):
2306
2307 2020-02-11  Youenn Fablet  <youenn@apple.com>
2308
2309         WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
2310         https://bugs.webkit.org/show_bug.cgi?id=207537
2311
2312         Reviewed by Chris Dumez.
2313
2314         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2315
2316 2020-02-11  Lauro Moura  <lmoura@igalia.com>
2317
2318         [WPE][WebDriver] MiniBrowser should react to close session commands
2319         https://bugs.webkit.org/show_bug.cgi?id=207529
2320
2321         Reviewed by Carlos Garcia Campos.
2322
2323         WebDriver delete session command asks to close the WebView associated to the
2324         current automation session. We must react to it to avoid lots of
2325         timeouts and errors.
2326
2327         * MiniBrowser/wpe/main.cpp:
2328         (main): Listen to "close" signal on the main WebView.
2329
2330 2020-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2331
2332         [iOS] Non-internal API test runners frequently crash due to Objective-C exceptions
2333         https://bugs.webkit.org/show_bug.cgi?id=207525
2334         <rdar://problem/59110543>
2335
2336         Reviewed by Tim Horton.
2337
2338         After the fix for <rdar://problem/56301207>, some scroll view content offset changes will attempt to call into
2339         CoreAnalytics API to try and report data about scrolling velocities. In the iOS 13.3 simulator, this involves
2340         creating a dictionary, of which one of the keys is the bundle identifier of the application. The value is
2341         unconditionally inserted into the dictionary. Since TestWebKitAPI does not run in the context of a
2342         UIApplication, the bundle identifier (that is, `NSBundle.mainBundle.bundleIdentifier`) ends up being nil,
2343         causing us to crash upon trying to create the dictionary.
2344
2345         While it would make things easier, we can't just swizzle -bundleIdentifier for the entirely of every test, since
2346         some tests expect the bundle identifier to be nil (or call into system frameworks that expect the bundle
2347         identifier to be nil). These tests fail or time out when -bundleIdentifier is unconditionally swizzled
2348         throughout the test run. To work around this bug for the time being, simply pretend that we have a bundle
2349         identifier when running API tests on iOS, by swizzling `-[NSBundle bundleIdentifier]` to return a string at the
2350         beginning of each API test.
2351
2352         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2353         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2354         (overrideBundleIdentifier):
2355
2356         Move this to the top of the file, so it can be shared.
2357
2358         (+[WKWebView initialize]):
2359
2360         At the start of each test, force UIKit to cache a fake value for `_UIMainBundleIdentifier()` by invoking an
2361         internal class method that calls into the internal helper function, with no other side effects.
2362
2363         * TestWebKitAPI/ios/UIKitSPI.h:
2364
2365 2020-02-10  Jonathan Bedard  <jbedard@apple.com>
2366
2367         TestWebKitAPI: Support ClipboardTests.ReadMultipleItems on Catalyst
2368         https://bugs.webkit.org/show_bug.cgi?id=207501
2369         <rdar://problem/59323414>
2370
2371         Reviewed by Alex Christensen.
2372
2373         * TestWebKitAPI/Tests/WebKitCocoa/ClipboardTests.mm:
2374         (writeMultipleObjectsToPlatformPasteboard): All iOS family ports should have
2375         The same behavior.
2376
2377 2020-02-10  Alan Sien Wei Hshieh  <hshieh@apple.com>
2378
2379         Add a variant of -[WKWebViewPrivate _getContentsAsStringWithCompletionHandler:] that includes contents from subframes
2380         https://bugs.webkit.org/show_bug.cgi?id=207352
2381         <rdar://problem/59115798>
2382
2383         Reviewed by Alex Christensen.
2384
2385         Add a test to exercise the new SPI.
2386
2387         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm: Add a test for getting text from all frames with
2388         a webpage that contains text in subframes.
2389
2390
2391 2020-02-10  Per Arne Vollan  <pvollan@apple.com>
2392
2393         [iOS] Crash when granting access to asset services
2394         https://bugs.webkit.org/show_bug.cgi?id=207520
2395
2396         Reviewed by Brent Fulgham.
2397
2398         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2399         * TestWebKitAPI/Tests/WebKit/GrantAccessToMobileAssets.mm: Added.
2400         (TEST):
2401
2402 2020-02-10  Chris Dumez  <cdumez@apple.com>
2403
2404         [DRT] InternalSettingsGenerated::resetToConsistentState() may override TestOptions
2405         https://bugs.webkit.org/show_bug.cgi?id=207481
2406
2407         Reviewed by Alexey Proskuryakov.
2408
2409         InternalSettingsGenerated::resetToConsistentState() may override TestOptions such as enableBackForwardCache.
2410         This is causing issues such as the back/forward cache sometimes getting enabled on tests where
2411         TestOptions::enableBackForwardCache() is false, because a previous test has enabled the back/forward cache.
2412
2413         * DumpRenderTree/mac/DumpRenderTree.mm:
2414         (resetWebViewToConsistentStateBeforeTesting):
2415         Make sure we reset preferences after we call WebCoreTestSupport::resetInternalsObject(), since
2416         resetInternalsObject() updates settings and TestOptions / DRT preferences should have priority
2417         over internal settings.
2418
2419 2020-02-10  Per Arne Vollan  <pvollan@apple.com>
2420
2421         [watchOS] Notification listener is never unregistered
2422         https://bugs.webkit.org/show_bug.cgi?id=207459
2423
2424         Reviewed by Maciej Stachowiak.
2425
2426         Add a test which tests that posting a backlight level change notification will not cause a crash.
2427
2428         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2429         * TestWebKitAPI/Tests/WebKit/BacklightLevelNotification.mm: Added.
2430         (TEST):
2431
2432 2020-02-10  James Howard  <jameshoward@mac.com>
2433
2434         Standard gamepad mapping for GameControllerGamepads
2435         https://bugs.webkit.org/show_bug.cgi?id=206033
2436
2437         Reviewed by Dean Jackson.
2438
2439         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2440         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2441         (WTR::TestRunner::setMockGamepadDetails):
2442         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2443         * WebKitTestRunner/TestInvocation.cpp:
2444         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2445
2446 2020-02-10  Aakash Jain  <aakash_jain@apple.com>
2447
2448         [ews] Display flaky layout test names in build summary
2449         https://bugs.webkit.org/show_bug.cgi?id=207504
2450
2451         Reviewed by Jonathan Bedard.
2452
2453         * BuildSlaveSupport/ews-build/steps.py:
2454         (ReRunWebKitTests.evaluateCommand): Drive-by fix to correct the pluralization.
2455         (AnalyzeLayoutTestsResults.report_pre_existing_failures): Append the flaky failure information.
2456         (AnalyzeLayoutTestsResults.start):
2457
2458 2020-02-10  Aakash Jain  <aakash_jain@apple.com>
2459
2460         [ews] Use SetBuildSummary instead of buildFinished in Layout tests
2461         https://bugs.webkit.org/show_bug.cgi?id=207492
2462
2463         Reviewed by Jonathan Bedard.
2464
2465         * BuildSlaveSupport/ews-build/steps.py:
2466         (RunWebKitTests.evaluateCommand):
2467         (ReRunWebKitTests.evaluateCommand):
2468         (AnalyzeLayoutTestsResults.report_pre_existing_failures):
2469         * BuildSlaveSupport/ews-build/factories.py:
2470         (TestFactory.__init__):
2471
2472 2020-02-10  Truitt Savell  <tsavell@apple.com>
2473
2474         Unreviewed, rolling out r256091.
2475
2476         Broke internal builds
2477
2478         Reverted changeset:
2479
2480         "Move trivial definitions from FeatureDefines.xcconfig to
2481         PlatformEnableCocoa.h"
2482         https://bugs.webkit.org/show_bug.cgi?id=207155
2483         https://trac.webkit.org/changeset/256091
2484
2485 2020-02-10  Truitt Savell  <tsavell@apple.com>
2486
2487         Unreviewed, rolling out r256103.
2488
2489         This patch is blocking the rollout of r256091
2490
2491         Reverted changeset:
2492
2493         "Move JavaScriptCore related feature defines from
2494         FeatureDefines.xcconfig to PlatformEnableCocoa.h"
2495         https://bugs.webkit.org/show_bug.cgi?id=207436
2496         https://trac.webkit.org/changeset/256103
2497
2498 2020-02-10  Jonathan Bedard  <jbedard@apple.com>
2499
2500         results.webkit.org: Abstract archive storage solutions
2501         https://bugs.webkit.org/show_bug.cgi?id=207277
2502
2503         Rubber-stamped by Aakash Jain.
2504
2505         * resultsdbpy/resultsdbpy/model/archive_context.py:
2506         (ArchiveContext):
2507         (ArchiveContext.ArchiveMetaDataByCommit.unpack):
2508         (ArchiveContext.__init__): Add archiver member.
2509         (ArchiveContext.__enter__): archiver is a context manager.
2510         (ArchiveContext.__exit__): Ditto.
2511         (ArchiveContext.register): The archiver member owns saving an archive.
2512         (ArchiveContext.find_archive): The archiver member owns retrieving an archive.
2513         (ArchiveContext.ArchiveChunks): Move to CassandraArchiver.
2514         * resultsdbpy/resultsdbpy/model/archiver.py: Added.
2515         (Archiver): Base class for all Archiving systems.
2516         (Archiver.archive_digest): Given a file-like archive, calculate it's digest.
2517         (Archiver.archive_size): Given a file-like archive, calculate it's size.
2518         (Archiver.save):
2519         (Archiver.retrieve):
2520         * resultsdbpy/resultsdbpy/model/cassandra_archiver.py: Added.
2521         (CassandraArchiver):
2522         (CassandraArchiver.ArchiveChunks): Moved from ArchiveContext.
2523         (CassandraArchiver.__init__):
2524         (CassandraArchiver.__enter__):
2525         (CassandraArchiver.__exit__):
2526         (CassandraArchiver.save): Split the provided archive into chunks for saving, moved
2527         from ArchiveContext.
2528         (CassandraArchiver.retrieve): Retrieve an archive with the provided hash, moved
2529         from ArchiveContext.
2530
2531 2020-02-09  Lauro Moura  <lmoura@igalia.com>
2532
2533         [GTK][WPE] Expose allowTopNavigationToDataURL
2534         https://bugs.webkit.org/show_bug.cgi?id=207384
2535
2536         Reviewed by Adrian Perez de Castro.
2537
2538         Updates with new "allow-top-navigation-to-data-urls" property.
2539
2540         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2541         (testWebViewAllowModalDialogs): This test requires this property to be
2542         set.
2543         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2544         (testWebKitSettings): Added tests for getter/setter.
2545
2546 2020-02-08  Sam Weinig  <weinig@apple.com>
2547
2548         Move JavaScriptCore related feature defines from FeatureDefines.xcconfig to PlatformEnableCocoa.h
2549         https://bugs.webkit.org/show_bug.cgi?id=207436
2550
2551         Reviewed by Tim Horton.
2552
2553         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2554         Remove ENABLE_FAST_JIT_PERMISSIONS and ENABLE_FTL_JIT.
2555
2556 2020-02-08  Yusuke Suzuki  <ysuzuki@apple.com>
2557
2558         [WTF] Try using 75% load factor for HashTable
2559         https://bugs.webkit.org/show_bug.cgi?id=207183
2560
2561         Reviewed by Mark Lam.
2562
2563         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2564         (TestWebKitAPI::testInitialCapacity):
2565
2566 2020-02-08  Sam Weinig  <weinig@apple.com>
2567
2568         Move trivial definitions from FeatureDefines.xcconfig to PlatformEnableCocoa.h
2569         https://bugs.webkit.org/show_bug.cgi?id=207155
2570
2571         Reviewed by Tim Horton.
2572
2573         Move all trivial definitions (just ENABLE_FOO = ENABLE_FOO; or ENABLE_BAR = ;)
2574         from the FeatureDefines.xcconfigs to PlatformEnableCocoa.h, ensuring each one
2575         also has a default value in PlatformEnable.h
2576
2577         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2578
2579 2020-02-07  Wenson Hsieh  <wenson_hsieh@apple.com>
2580
2581         Several iOS API tests that call -makeKeyWindow assert after r255907
2582         https://bugs.webkit.org/show_bug.cgi?id=207411
2583
2584         Reviewed by Tim Horton.
2585
2586         r255907 asserted in -makeKeyWindow that the shared UIApplication exists. While this was guaranteed for all call
2587         sites of -makeKeyWindow from API tests, -makeKeyWindow may also be invoked from within UIKit code; in this case,
2588         nothing guarantees that the application has been initialized, and we end up hitting this assertion. To fix this,
2589         replace the assertion with logic to bootstrap the shared UIApplication (if it didn't already exist).
2590
2591         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2592         (TestWebKitAPI::TEST):
2593         (TestWebKitAPI::overrideBundleIdentifier): Deleted.
2594         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2595         (overrideBundleIdentifier):
2596         (setOverriddenApplicationKeyWindow):
2597
2598 2020-02-07  Jonathan Bedard  <jbedard@apple.com>
2599
2600         TestWebKitAPI: Disable legacy ActionSheet tests on Catalyst
2601         https://bugs.webkit.org/show_bug.cgi?id=207405
2602
2603         Reviewed by Wenson Hsieh.
2604
2605         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2606
2607 2020-02-07  Alex Christensen  <achristensen@apple.com>
2608
2609         Remember if we used legacy TLS in the back/forward cache like we remember if we have only secure content
2610         https://bugs.webkit.org/show_bug.cgi?id=207409
2611         rdar://problem/59275641
2612
2613         Reviewed by Chris Dumez.
2614
2615         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
2616         (TestWebKitAPI::TEST):
2617
2618 2020-02-07  Ryan Haddad  <ryanhaddad@apple.com>
2619
2620         Unreviewed, rolling out r256051.
2621
2622         Broke internal builds.
2623
2624         Reverted changeset:
2625
2626         "Move trivial definitions from FeatureDefines.xcconfig to
2627         PlatformEnableCocoa.h"
2628         https://bugs.webkit.org/show_bug.cgi?id=207155
2629         https://trac.webkit.org/changeset/256051
2630
2631 2020-02-07  Jonathan Bedard  <jbedard@apple.com>
2632
2633         iPad testers failing to launch processes
2634         https://bugs.webkit.org/show_bug.cgi?id=207401
2635         <rdar://problem/58184777>
2636
2637         Unreviewed infrastructure fix.
2638
2639         This is a speculative fix because I've had problems reproducing this error.
2640         The only time I managed to reproduce the problem was immediately after killing the 
2641         SimulatorTrampoline and CoreSimulator.xpc processes.
2642
2643         * BuildSlaveSupport/kill-old-processes:
2644         (main): Only kill Simulator.app, not all associated simulator processes.
2645
2646 2020-02-07  Jiewen Tan  <jiewen_tan@apple.com>
2647
2648         [WebAuthn] Report CTAP Client Pin Error to clients
2649         https://bugs.webkit.org/show_bug.cgi?id=205837
2650         <rdar://problem/58356872>
2651
2652         Reviewed by Brent Fulgham.
2653
2654         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2655         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
2656         (-[TestWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:]):
2657         (TestWebKitAPI::TEST):
2658         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-pin-auth-blocked-error.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-error.html.
2659         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-pin-invalid-error-retry.html: Added.
2660         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-auth-blocked-error.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-error.html.
2661         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-pin-auth-blocked-error.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-error.html.
2662         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-pin-auth-invalid-error-retry.html: Added.
2663         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-pin-blocked-error.html: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-error.html.
2664         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-pin-invalid-error-retry.html: Added.
2665         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-invalid-error-retry.html: Added.
2666
2667 2020-02-07  Jonathan Bedard  <jbedard@apple.com>
2668
2669         run-safari Doesn't work with the latest Xcode version and iOS
2670         https://bugs.webkit.org/show_bug.cgi?id=207394
2671
2672         Reviewed by Ryosuke Niwa.
2673
2674         * Scripts/webkitdirs.pm:
2675         (iosSimulatorRuntime): Determine the runtime from valid runtimes.
2676         (findOrCreateSimulatorForIOSDevice): iPhone 5 is unsupported, remove code.
2677
2678 2020-02-07  Daniel Bates  <dabates@apple.com>
2679
2680         Legacy WebKit: Have linkedOnOrAfter() respect the NSDefault WebKitLinkedOnOrAfterEverything and opt DumpRenderTree in
2681         https://bugs.webkit.org/show_bug.cgi?id=207366
2682
2683         Reviewed by Brent Fulgham.
2684
2685         Enable default WebKitLinkedOnOrAfterEverything in DumpRenderTree just as we do in WebKitTestRunner.
2686         This lets me put test results for Mac and iOS Legacy WebKit in the same cross-platform directory
2687         as the actual test instead of under a platform-specific directory even when the tests' behavior
2688         depends on the link-time version of WebKit.
2689
2690         Note that testing of pre-linked behavior can still be accomplished by test writers by exposing settings
2691         and toggling them in a test.
2692
2693         * DumpRenderTree/mac/DumpRenderTree.mm:
2694         (setDefaultsToConsistentValuesForTesting):
2695
2696 2020-02-03  Sam Weinig  <weinig@apple.com>
2697
2698         Move trivial definitions from FeatureDefines.xcconfig to PlatformEnableCocoa.h
2699         https://bugs.webkit.org/show_bug.cgi?id=207155
2700
2701         Reviewed by Tim Horton.
2702
2703         Move all trivial definitions (just ENABLE_FOO = ENABLE_FOO; or ENABLE_BAR = ;)
2704         from the FeatureDefines.xcconfigs to PlatformEnableCocoa.h, ensuring each one
2705         also has a default value in PlatformEnable.h
2706
2707         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2708
2709 2020-02-07  Kate Cheney  <katherine_cheney@apple.com>
2710
2711         Update WebView category name to be more accurate
2712         https://bugs.webkit.org/show_bug.cgi?id=207334
2713         <rdar://problem/59224855>
2714
2715         Reviewed by Brent Fulgham.
2716
2717         * TestWebKitAPI/Tests/WebKitCocoa/Configuration.mm:
2718         (TEST):
2719
2720 2020-02-07  Aakash Jain  <aakash_jain@apple.com>
2721
2722         [ews] add commit-queue build step to close the bug
2723         https://bugs.webkit.org/show_bug.cgi?id=207387
2724
2725         Reviewed by Jonathan Bedard.
2726
2727         * BuildSlaveSupport/ews-build/steps.py:
2728         (BugzillaMixin.close_bug): Method to close the bugzilla bug.
2729         (CloseBug): Build step to close bugzilla bug.
2730
2731 2020-02-05  Aakash Jain  <aakash_jain@apple.com>
2732
2733         [ews] add commit-queue build step to clear flags on patch
2734         https://bugs.webkit.org/show_bug.cgi?id=206536
2735
2736         Reviewed by Jonathan Bedard.
2737
2738         * BuildSlaveSupport/ews-build/steps.py:
2739         (BugzillaMixin): Class for common bugzilla related methods.
2740         (BugzillaMixin.get_bugzilla_api_key): Method to read bugzilla api key from file.
2741         (BugzillaMixin.remove_flags_on_patch): Method to remove flags on patch.
2742         (ValidatePatch):
2743         (RemoveFlagsOnPatch): Class to remove flags on patch.
2744         (RemoveFlagsOnPatch.start):
2745         (ValidatePatch._addToLog): Moved.
2746         (ValidatePatch.fetch_data_from_url): Moved.
2747         (ValidatePatch.get_patch_json): Moved.
2748         (ValidatePatch.get_bug_json): Moved.
2749         (ValidatePatch.get_bug_id_from_patch): Moved.
2750         (ValidatePatch._is_patch_obsolete): Moved.
2751         (ValidatePatch._is_patch_review_denied): Moved.
2752         (ValidatePatch._is_patch_cq_plus): Moved.
2753         (ValidatePatch._is_bug_closed): Moved.
2754
2755 2020-02-07  Jonathan Bedard  <jbedard@apple.com>
2756
2757         EWS should run resultsdbpy tests
2758         https://bugs.webkit.org/show_bug.cgi?id=201928
2759
2760         Reviewed by Aakash Jain.
2761
2762         * BuildSlaveSupport/ews-build/factories.py:
2763         (ServicesFactory.__init__): Add RunResultsdbpyTests.
2764         * BuildSlaveSupport/ews-build/factories_unittest.py:
2765         (TestTestsFactory.test_services_factory): Add RunResultsdbpyTests.
2766         * BuildSlaveSupport/ews-build/steps.py:
2767         (CheckPatchRelevance): resultsdbpy changes should trigger service tests.
2768         (RunResultsdbpyTests): Add step which runs resultsdbpy tests.
2769         * BuildSlaveSupport/ews-build/steps_unittest.py:
2770         (TestRunResultsdbpyTests):
2771         (TestRunResultsdbpyTests.setUp):
2772         (TestRunResultsdbpyTests.tearDown):
2773         (TestRunResultsdbpyTests.test_success):
2774         (TestRunResultsdbpyTests.test_failure):
2775
2776 2020-02-07  Jacob Uphoff  <jacob_uphoff@apple.com>
2777
2778         Adding myself to contributors.json
2779         
2780         Unreviewed
2781
2782         * Scripts/webkitpy/common/config/contributors.json:
2783
2784 2020-02-07  Jason Lawrence  <lawrence.j@apple.com>
2785
2786         Adding myself to contributors.json
2787         
2788         Unreviewed
2789
2790         * Scripts/webkitpy/common/config/contributors.json:
2791
2792 2020-02-07  Patrick Griffis  <pgriffis@igalia.com>
2793
2794         [GTK][WPE] Add same-site cookie support
2795         https://bugs.webkit.org/show_bug.cgi?id=204137
2796
2797         Reviewed by Carlos Garcia Campos.
2798
2799         Update libsoup to 2.69.90 in JHBuild.
2800
2801         * gtk/jhbuild.modules:
2802         * wpe/jhbuild.modules:
2803
2804 2020-02-07  Yusuke Suzuki  <ysuzuki@apple.com>
2805
2806         Unreviewed, revert 75% load-factor because of JetStream2/string-unpack-code-SP regression
2807         https://bugs.webkit.org/show_bug.cgi?id=207183
2808
2809         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2810         (TestWebKitAPI::testInitialCapacity):
2811
2812 2020-02-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2813
2814         WebPage::rangeForGranularityAtPoint always returns null in the case of CharacterGranularity
2815         https://bugs.webkit.org/show_bug.cgi?id=207350
2816         <rdar://problem/59239914>
2817
2818         Reviewed by Tim Horton.
2819
2820         Add a test to exercise the corner case in the SPI.
2821
2822         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2823         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm: Added.
2824
2825 2020-02-06  Jiewen Tan  <jiewen_tan@apple.com>
2826
2827         Adopt new SOAuthorizationOption constants
2828         https://bugs.webkit.org/show_bug.cgi?id=207186
2829         <rdar://problem/48909336>
2830
2831         Reviewed by Brent Fulgham.
2832
2833         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
2834         (checkAuthorizationOptions):
2835
2836 2020-02-06  Brady Eidson  <beidson@apple.com>
2837
2838         Cleanup and promote WKContentWorld and its clients in WKWebView.
2839         https://bugs.webkit.org/show_bug.cgi?id=207351
2840
2841         Reviewed by Alex Christensen.
2842
2843         * TestWebKitAPI/Tests/WebKitCocoa/AsyncFunction.mm:
2844         (TestWebKitAPI::TEST):
2845         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
2846         (TEST):
2847         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2848         (-[WKWebView objectByCallingAsyncFunction:withArguments:error:]):
2849
2850 2020-02-06  Fujii Hironori  <Hironori.Fujii@sony.com>
2851
2852         [Win][MiniBrowser] Accelerator keys don't work unless the main window is focused
2853         https://bugs.webkit.org/show_bug.cgi?id=207250
2854
2855         Reviewed by Alex Christensen.
2856
2857         MiniBrowser has shortcut keys, Ctrl-W to close window, Ctrl-R to
2858         reload. However, they don't work unless the main window is
2859         focused.
2860
2861         Ctrl-W should be processed differently. Ctrl-W should be handled
2862         without dispatching to WebKit, others should be handled only when
2863         WebKit didn't consume. So, this change split the accelerator table
2864         into two, one is for Ctrl-W, another is for other shortcut keys.
2865
2866         For Ctrl-W, key events are processed before dispatching to
2867         WebView. It is converted to IDM_CLOSE_WINDOW of WM_COMMAND, and
2868         dispatched to WebView. WebKit2 WebView bubbles up unhandled
2869         WM_COMMAND to the parent window. Then, IDM_CLOSE_WINDOW is handled
2870         in the main window's WndProc. However, it doesn't work for WebKit1
2871         because this change doesn't add the bubbling up code to WebKit1
2872         WebView.
2873
2874         For other shortcut keys, for example Ctrl-R, key events are
2875         dispatched to WebView without accelerator key translations. Then,
2876         WebKitBrowserWindow::didNotHandleKeyEvent is called back if they
2877         aren't consumed. didNotHandleKeyEvent posts the messasge to the
2878         main window. The message loop processed key events dispatched to
2879         the main window with another accelerator table. However, it
2880         doesn't work for WebKit1, because WebKit1 doesn't have a API
2881         equivalent to didNotHandleKeyEvent.
2882
2883         After switching the active window by pressing Alt-Tab and
2884         reactivating the main window, the main window got the focus. This
2885         was the reason shortcut keys worked only after reactivating the
2886         main window. But, this is not the desired behavior after this
2887         change because other shortcut keys don't work if the main window
2888         is focused. So. set the focus to the brower window when
2889         WM_ACTIVATE of the main window.
2890
2891         Shortcut keys Ctrl++ (zoom in) and Ctrl+- (zoom out) were
2892         effective only for keyboard numpad. Add VK_OEM_MINUS and
2893         VK_OEM_PLUS for them.
2894
2895         Add a shortcut key Ctrl-0 to reset page zoom scale to actual.
2896
2897         * MiniBrowser/win/MainWindow.cpp:
2898         (MainWindow::isInstance):
2899         (MainWindow::WndProc):
2900         * MiniBrowser/win/MainWindow.h:
2901         * MiniBrowser/win/MiniBrowserLib.rc: Add a new accelerator table
2902         IDR_ACCELERATORS_PRE for Ctrl-W.
2903         * MiniBrowser/win/MiniBrowserLibResource.h:
2904         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2905         (WebKitBrowserWindow::didNotHandleKeyEvent):
2906         * MiniBrowser/win/WinMain.cpp:
2907         (wWinMain):
2908
2909 2020-02-06  Jonathan Bedard  <jbedard@apple.com>
2910
2911         results.webkitorg: Dead CI links
2912         https://bugs.webkit.org/show_bug.cgi?id=207340
2913
2914         Reviewed by Alexey Proskuryakov.
2915
2916         * resultsdbpy/resultsdbpy/view/static/js/configuration.js:
2917         (Configuration.prototype.toParams): Version name and version number often duplicate the
2918         same information, exception version number is often more specific than is useful.
2919
2920 2020-02-06  Brent Fulgham  <bfulgham@apple.com>
2921
2922         Prevent navigating top level frames to Data URLs
2923         https://bugs.webkit.org/show_bug.cgi?id=206962
2924         <rdar://problem/56770676>
2925
2926         Reviewed by Youenn Fablet.
2927
2928         Revise test running code to allow data URL navigations by default, since they are so frequently
2929         used in testing. However, provide a flag to turn this off in tests so we can confirm proper
2930         function.
2931
2932         * DumpRenderTree/TestOptions.cpp:
2933         (TestOptions::TestOptions):
2934         * DumpRenderTree/TestOptions.h:
2935         * DumpRenderTree/mac/DumpRenderTree.mm:
2936         (setWebPreferencesForTestOptions):
2937         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2938         (DownloadAttributeDoesNotStartDownloads): Revise configuration to allow script navigation of the main frame to a Data URL.
2939         (StartDownloadWithDownloadAttribute): Ditto.
2940         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
2941         (WebViewWillPerformClientRedirect): Ditto.
2942         (WebViewDidCancelClientRedirect): Ditto.
2943         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2944         (NavigateToDataURLThenBack): Ditto.
2945         (ContentExtensionBlocksMainLoadThenReloadWithoutExtensions): Ditto.
2946         * WebKitTestRunner/TestController.cpp:
2947         (WTR::TestController::resetPreferencesToConsistentValues):
2948         (WTR::updateTestOptionsFromTestHeader):
2949         * WebKitTestRunner/TestOptions.h:
2950         (WTR::TestOptions::hasSameInitializationOptions const):
2951         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2952         (WTR::initializeWebViewConfiguration):
2953         (WTR::TestController::platformCreateWebView):
2954
2955 2020-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2956
2957         [iOS] Provide a way to suppress software keyboards on WKWebView's WKContentView
2958         https://bugs.webkit.org/show_bug.cgi?id=207272
2959         <rdar://problem/59190828>
2960
2961         Reviewed by Tim Horton.
2962
2963         Add an API test to verify (through UIKeyboardImpl) that the software keyboard should be suppressed when setting
2964         -_setSuppressSoftwareKeyboard: on the web view. This involves making `-makeKeyWindow` "work" in the API testing
2965         environment on iOS, by swizzling out both `-[NSBundle bundleIdentifier]` and `-[UIApplication keyWindow]`.
2966
2967         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2968         (TestWebKitAPI::overrideBundleIdentifier):
2969         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2970         (setOverriddenApplicationKeyWindow):
2971         (applicationKeyWindowOverride):
2972         (-[TestWKWebViewHostWindow makeKeyWindow]):
2973         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2974         * TestWebKitAPI/ios/UIKitSPI.h:
2975
2976         Also move the `UIResponder (UIKitSPI)` category from the internal section to the SPI section; this is redundant
2977         when using the internal SDK to build, since these methods are already declared in UIResponder_Private.h.
2978
2979 2020-02-05  Don Olmstead  <don.olmstead@sony.com>
2980
2981         [PlayStation] Build a shared JavaScriptCore
2982         https://bugs.webkit.org/show_bug.cgi?id=198446
2983
2984         Reviewed by Fujii Hironori.
2985
2986         Add TARGET_OBJECTS for bmalloc and WTF so TestWTF links.
2987
2988         * TestWebKitAPI/PlatformPlayStation.cmake:
2989
2990 2020-02-05  Stephan Szabo  <stephan.szabo@sony.com>
2991
2992         [WinCairo] Set up fonts for layout tests for test bot image
2993         https://bugs.webkit.org/show_bug.cgi?id=207223
2994
2995         Reviewed by Fujii Hironori.
2996
2997         * WebKitTestRunner/InjectedBundle/win/ActivateFontsWin.cpp:
2998           Implement activateFonts to load fonts for test
2999
3000 2020-02-05  Don Olmstead  <don.olmstead@sony.com>
3001
3002         [PlayStation] Miscellaneous build fixes February 2020 edition
3003         https://bugs.webkit.org/show_bug.cgi?id=207312
3004
3005         Unreviewed build fix.
3006
3007         * TestWebKitAPI/PlatformWebView.h: Remove #elif guard and just use #else
3008
3009 2020-02-05  Yusuke Suzuki  <ysuzuki@apple.com>
3010
3011         [WTF] Try using 75% load factor for HashTable
3012         https://bugs.webkit.org/show_bug.cgi?id=207183
3013
3014         Reviewed by Mark Lam.
3015
3016         Fix load-factor assumption in existing tests.
3017
3018         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3019         (TestWebKitAPI::testInitialCapacity):
3020
3021 2020-02-05  Jonathan Bedard  <jbedard@apple.com>
3022
3023         resulsdbpy: Fix unit tests
3024         https://bugs.webkit.org/show_bug.cgi?id=207304
3025
3026         Reviewed by Aakash Jain.
3027
3028         * resultsdbpy/resultsdbpy/model/configuration_context_unittest.py:
3029         (ConfigurationContextTest.test_partition_by_configuration): Add branch to testing table.
3030         (ConfigurationContextTest.test_partition_by_partial_configuration): Ditto.
3031         * resultsdbpy/resultsdbpy/model/failure_context_unittest.py:
3032         (FailureContextTest.test_failures): Sort test failures by uuid for a predictable order in testing.
3033         (FailureContextTest.test_unexpected_failures): Ditto.
3034         * resultsdbpy/resultsdbpy/model/mock_model_factory.py:
3035         (MockModelFactory.iterate_all_commits): Do not batch requests since this function has no way
3036         of knowing how expensive the callback may be.
3037
3038 2020-02-05  Chris Dumez  <cdumez@apple.com>
3039
3040         Unreviewed, another build fix after r255846
3041
3042         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
3043
3044 2020-02-05  Ryan Haddad  <ryanhaddad@apple.com>
3045
3046         Unreviewed infrastructure fix.
3047
3048         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3049         (WebKitBuildbot): Delete entries for queues that have been removed from buildbot.
3050
3051 2020-02-05  Chris Dumez  <cdumez@apple.com>
3052
3053         Unreviewed build fix after r255846.
3054
3055         * TestWebKitAPI/cocoa/HTTPServer.h:
3056
3057 2020-02-05  Jiewen Tan  <jiewen_tan@apple.com>
3058
3059         Defer ending AppSSO sheets til NSWindowDidDeminiaturize or NSApplicationDidUnhide
3060         https://bugs.webkit.org/show_bug.cgi?id=207173
3061         <rdar://problem/55669065>
3062
3063         Reviewed by Brent Fulgham.
3064
3065         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
3066         (TestWebKitAPI::TEST):
3067         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3068         (-[TestWKWebView _setUpTestWindow:]):
3069         Make the TestWKWebViewHostWindow miniaturizable to enable the test.
3070
3071 2020-02-05  Jonathan Bedard  <jbedard@apple.com>
3072
3073         results.webkit.org: Apply ttl to archive shards
3074         https://bugs.webkit.org/show_bug.cgi?id=207295
3075
3076         Rubber-stamped by Aakash Jain.
3077
3078         * resultsdbpy/resultsdbpy/model/archive_context.py:
3079         (ArchiveContext.ArchiveMetaDataByCommit): Use new table.
3080         (ArchiveContext.ArchiveChunks): Use new table.
3081         (ArchiveContext.register): Add ttl to archive shards.
3082
3083 2020-02-05  Alex Christensen  <achristensen@webkit.org>
3084
3085         Make WKWebView._negotiatedLegacyTLS accurate when loading main resouorce from network or cache
3086         https://bugs.webkit.org/show_bug.cgi?id=207207
3087
3088         Reviewed by Chris Dumez.
3089
3090         HTTPServer now supports HTTPS. Tell your friends!
3091
3092         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
3093         (testCertificate):
3094         (testIdentity):
3095         (credentialWithIdentity):
3096         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
3097         (TestWebKitAPI::webViewWithNavigationDelegate):
3098         (TestWebKitAPI::TEST):
3099         * TestWebKitAPI/cocoa/HTTPServer.h:
3100         * TestWebKitAPI/cocoa/HTTPServer.mm:
3101         (TestWebKitAPI::HTTPServer::HTTPServer):
3102         (TestWebKitAPI::HTTPServer::request const):
3103
3104 2020-02-05  Brady Eidson  <beidson@apple.com>
3105
3106         _WKDownload should expose the originating FrameInfo.
3107         <rdar://problem/58022576> and https://bugs.webkit.org/show_bug.cgi?id=207185
3108
3109         Reviewed by Geoff Garen.
3110
3111         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3112         (-[DownloadTestSchemeDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3113         (-[DownloadSecurityOriginDelegate _downloadDidStart:]):
3114         (loaded):
3115         * TestWebKitAPI/cocoa/HTTPServer.mm:
3116
3117 2020-02-05  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3118
3119         [GTK] Fix dependencies build
3120         https://bugs.webkit.org/show_bug.cgi?id=207273
3121
3122         Reviewed by Carlos Garcia Campos.
3123
3124         * gtk/jhbuild.modules: Bumped wpebackend-fdo version to 1.4.1 and
3125         added mesa as one of its deps. Added the xserver patch as well.
3126         * gtk/patches/xserver-gl-version.patch: Added.
3127
3128 2020-02-05  Chris Dumez  <cdumez@apple.com>
3129
3130         REGRESSION(r255595): page not closed after beforeunload handler returns true
3131         https://bugs.webkit.org/show_bug.cgi?id=207189
3132         <rdar://problem/59149593>
3133
3134         Reviewed by Youenn Fablet.
3135
3136         Add API test coverage for fix landed in r255677.
3137
3138         * TestWebKitAPI/Tests/WebKitCocoa/ModalAlerts.mm:
3139         (-[SlowBeforeUnloadPromptUIDelegate _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3140         (TEST):
3141
3142 2020-02-05  Jonathan Bedard  <jbedard@apple.com>
3143
3144         results.webkit.org should disable auto-capitalize over the search field
3145         https://bugs.webkit.org/show_bug.cgi?id=207240
3146         <rdar://problem/59053042>
3147
3148         Rubber-stamped by Aakash Jain.
3149
3150         * resultsdbpy/resultsdbpy/view/static/js/search.js:
3151
3152 2020-02-01  Darin Adler  <darin@apple.com>
3153
3154         Replace RGBA32 typedef with a class to improve type safety
3155         https://bugs.webkit.org/show_bug.cgi?id=206862
3156
3157         Reviewed by Sam Weinig.
3158
3159         * TestWebKitAPI/Tests/WebKitCocoa/PDFSnapshot.mm:
3160         (TestWebKitAPI::TEST): Use the Color constructor instead of Color::createUnchecked.
3161
3162 2020-02-04  Darin Adler  <darin@apple.com>
3163
3164         Remove NSKeyedArchiverSPI.h now that WebKit only uses API
3165         https://bugs.webkit.org/show_bug.cgi?id=207203
3166
3167         Reviewed by Anders Carlsson.
3168
3169         * TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm: Removed
3170         include of NSKeyedArchiverSPI.h and call methods of NSKeyedArchiver directly.
3171         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm: Ditto.
3172         * TestWebKitAPI/Tests/ios/WKWebViewOpaque.mm: Ditto.
3173         * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm: Ditto.
3174
3175 2020-02-04  Jonathan Bedard  <jbedard@apple.com>
3176
3177         results.webkit.org: Support Internal in run-javascriptcore-tests
3178         https://bugs.webkit.org/show_bug.cgi?id=204095
3179
3180         Rubber-stamped by Aakash Jain.
3181
3182         * Scripts/VCSUtils.pm:
3183         (gitBisectStartBranchForDirectory): Renamed from gitBisectStartBranch.
3184         (gitBranchForDirectory): Compute branch for directory.
3185         (gitBranch): Compute branch for the current git directory.
3186         (commitForDirectory): Add git support.
3187         (gitBisectStartBranch): Renamed to gitBisectStartBranchForDirectory.
3188         * Scripts/run-javascriptcore-tests:
3189         (uploadResults): Check for Internal repository.
3190
3191 2020-02-04  Alex Christensen  <achristensen@webkit.org>
3192
3193         REGRESSION: (r255611) [ Mac ] 3 lldb tests failing related to HashMap
3194         https://bugs.webkit.org/show_bug.cgi?id=207204
3195
3196         Reviewed by Simon Fraser.
3197
3198         Remove support for HashSet and HashMap until we are able to do the equivalent of reinterpret_cast<unsigned*>(pointer)[-1]
3199         in LLDB's python API.
3200
3201         * lldb/lldb_webkit_unittest.py:
3202         (TestSummaryProviders.serial_test_WTFHashMap_tablesize_and_size):
3203         (TestSummaryProviders.serial_test_WTFHashMap_of_vectors_tablesize_and_size):
3204         (TestSummaryProviders.serial_test_WTFHashSet_tablesize_and_size):
3205
3206 2020-02-04  Lauro Moura  <lmoura@igalia.com>
3207
3208         [EWS] Stop GTK/WPE build if jhbuild fails.
3209         https://bugs.webkit.org/show_bug.cgi?id=207220
3210
3211         Reviewed by Adrian Perez de Castro.
3212
3213         * BuildSlaveSupport/ews-build/steps.py:
3214         (InstallGtkDependencies): Halt on failure
3215         (InstallWpeDependencies): Ditto
3216
3217 2020-02-04  Alex Christensen  <achristensen@webkit.org>
3218
3219         Fix Mac CMake build
3220         https://bugs.webkit.org/show_bug.cgi?id=207231
3221
3222         * DumpRenderTree/PlatformMac.cmake:
3223         * MiniBrowser/mac/CMakeLists.txt:
3224         * MiniBrowser/mac/WK2BrowserWindowController.m:
3225         (-[WK2BrowserWindowController awakeFromNib]):
3226         * WebKitTestRunner/PlatformMac.cmake:
3227
3228 2020-02-04  Don Olmstead  <don.olmstead@sony.com>
3229
3230         [PlayStation] Enable TestWebKit
3231         https://bugs.webkit.org/show_bug.cgi?id=207211
3232
3233         Reviewed by Ross Kirsling.
3234
3235         Stub out PlayStation implementation of TestWebKit so it builds.
3236
3237         * TestWebKitAPI/PlatformPlayStation.cmake:
3238         * TestWebKitAPI/PlatformWebView.h: Simplify platform define
3239         * TestWebKitAPI/playstation/PlatformUtilitiesPlayStation.cpp: Added.
3240         (TestWebKitAPI::Util::createInjectedBundlePath):
3241         (TestWebKitAPI::Util::createURLForResource):
3242         (TestWebKitAPI::Util::URLForNonExistentResource):
3243         (TestWebKitAPI::Util::isKeyDown):
3244         * TestWebKitAPI/playstation/PlatformWebViewPlayStation.cpp: Added.
3245         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3246         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
3247         (TestWebKitAPI::PlatformWebView::initialize):
3248         (TestWebKitAPI::PlatformWebView::page const):
3249         (TestWebKitAPI::PlatformWebView::resizeTo):
3250         (TestWebKitAPI::PlatformWebView::focus):
3251         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
3252         (TestWebKitAPI::PlatformWebView::simulateAltKeyPress):
3253         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
3254         (TestWebKitAPI::PlatformWebView::simulateRightClick):
3255
3256 2020-02-04  Jonathan Bedard  <jbedard@apple.com>
3257
3258         results.webkit.org: Support branches in run-javascriptcore-tests
3259         https://bugs.webkit.org/show_bug.cgi?id=204094
3260
3261         Rubber-stamped by Aakash Jain.
3262
3263         * Scripts/run-javascriptcore-tests:
3264         (uploadResults): Use webkitdirs function to generate commit information.
3265         * Scripts/VCSUtils.pm:
3266         (commitForDirectory): Generate commit information for SVN repository, including
3267         branch name.
3268
3269 2020-02-04  Matt Lewis  <jlewis3@apple.com>
3270
3271         Replace bot677 due to hardware failure
3272         https://bugs.webkit.org/show_bug.cgi?id=207224
3273
3274         Reviewed by Aakash Jain.
3275
3276         * BuildSlaveSupport/build.webkit.org-config/config.json:
3277
3278 2020-02-04  Jonathan Bedard  <jbedard@apple.com>
3279
3280         TestWebKitAPI: Handle case where test result does not contain path
3281         https://bugs.webkit.org/show_bug.cgi?id=207216
3282
3283         Reviewed by Tim Horton.
3284
3285         * TestWebKitAPI/TestsController.cpp:
3286         (TestWebKitAPI::Printer::OnTestPartResult): It's possible that the TestPartResult
3287         will not contain a file name. We should handle this case.
3288
3289 2020-02-04  Jonathan Bedard  <jbedard@apple.com>
3290
3291         results.webkit.org: Better order upload callbacks
3292         https://bugs.webkit.org/show_bug.cgi?id=207219
3293
3294         Reviewed by Aakash Jain.
3295
3296         Order upload callbacks more deliberately so that the quickest callbacks
3297         that are least likely to link to information from unfinished callbacks are
3298         executed first.
3299
3300         * resultsdbpy/resultsdbpy/model/model.py:
3301         (Model.__init__): Generate buildbot links first, then generate a failure
3302         list, then generate the collective suite results and finally, individual
3303         test results.
3304
3305 2020-02-04  Aakash Jain  <aakash_jain@apple.com>
3306
3307         [EWS] Do not remove TestWebKitAPI prefix from api test failures
3308         https://bugs.webkit.org/show_bug.cgi?id=207210
3309
3310         Reviewed by Jonathan Bedard.
3311
3312         * BuildSlaveSupport/ews-build/steps.py:
3313         (AnalyzeAPITestsResults.analyzeResults):
3314
3315 2020-02-04  Aakash Jain  <aakash_jain@apple.com>
3316
3317         [EWS] Do not remove webkitpy prefix from test failures
3318         https://bugs.webkit.org/show_bug.cgi?id=207206
3319
3320         Reviewed by Jonathan Bedard.
3321
3322         * BuildSlaveSupport/ews-build/steps.py:
3323         (WebKitPyTest.getResultSummary): Do not remove 'webkitpy' from test name. Also handled the
3324         case when json output doesn't have failures/errors key.
3325         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3326
3327 2020-02-04  Ross Kirsling  <ross.kirsling@sony.com>
3328
3329         [CMake] Add Cairo::Cairo target
3330         https://bugs.webkit.org/show_bug.cgi?id=207159
3331
3332         Reviewed by Konstantin Tokarev.
3333
3334         * DumpRenderTree/PlatformWin.cmake:
3335         * ImageDiff/Cairo.cmake:
3336         * TestWebKitAPI/PlatformWPE.cmake:
3337         * TestWebKitAPI/PlatformWin.cmake:
3338         * TestWebKitAPI/glib/CMakeLists.txt:
3339         * WebKitTestRunner/PlatformGTK.cmake:
3340         * WebKitTestRunner/PlatformWPE.cmake:
3341         * WebKitTestRunner/PlatformWin.cmake:
3342         * wpe/backends/CMakeLists.txt:
3343
3344 2020-02-03  Jiewen Tan  <jiewen_tan@apple.com>
3345
3346         Pass a hint from the extension to decidePolicyForSOAuthorizationLoadWithCurrentPolicy
3347         https://bugs.webkit.org/show_bug.cgi?id=207079
3348         <rdar://problem/48290464>
3349
3350         Reviewed by Brent Fulgham.
3351
3352         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
3353         (-[TestSOAuthorizationDelegate _webView:decidePolicyForSOAuthorizationLoadWithCurrentPolicy:forExtension:completionHandler:]):
3354         (overrideGetAuthorizationHintsWithURL):
3355         (TestWebKitAPI::TEST):
3356
3357 2020-02-03  Jonathan Bedard  <jbedard@apple.com>
3358
3359         results.webkit.org: Support jsc stress tests
3360         https://bugs.webkit.org/show_bug.cgi?id=204096
3361
3362         Rubber-stamped by Aakash Jain.
3363
3364         * Scripts/run-javascriptcore-tests:
3365         (runJSCStressTests): Add pass and failures to reported results.
3366
3367 2020-02-03  Alexey Shvayka  <shvaikalesh@gmail.com>
3368
3369         Make Bugzilla._find_select_element_for_flag more robust
3370         https://bugs.webkit.org/show_bug.cgi?id=207148
3371
3372         Reviewed by Jonathan Bedard.
3373
3374         This patch resolves two FIXMEs:
3375         1. _find_select_element_for_flag() is now used in _fill_attachment_form() method.
3376         2. _find_select_element_for_flag() now does not rely on order of <select> elements.
3377
3378         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3379         (Bugzilla._fill_attachment_form):
3380         (Bugzilla._find_select_element_for_flag):
3381
3382 2020-02-03  Alex Christensen  <achristensen@webkit.org>
3383
3384         Reduce size of HashMap and HashSet
3385         https://bugs.webkit.org/show_bug.cgi?id=207138
3386
3387         Reviewed by Yusuke Suzuki.
3388
3389         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3390         (TestWebKitAPI::TEST):
3391         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3392         (TestWebKitAPI::TEST):
3393
3394 2020-02-03  Alexey Shvayka  <shvaikalesh@gmail.com>
3395
3396         obsolete_attachment should not fail when flags do not exist
3397         https://bugs.webkit.org/show_bug.cgi?id=171121
3398
3399         Reviewed by Jonathan Bedard.
3400
3401         Before this change, an error occured if a contributor without EditBugs privileges tried
3402         to obsolete not their own attachment. With this patch, uploading routine continues with
3403         friendly console warning like we have in reassign_bug() method.
3404
3405         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3406         (Bugzilla):
3407         (Bugzilla.obsolete_attachment):
3408         (Bugzilla.reassign_bug): Use NO_EDIT_BUGS_MESSAGE constant.
3409
3410 2020-02-03  Chris Dumez  <cdumez@apple.com>
3411
3412         Regression(r253224) WKUIDelegate.webViewDidClose may get called twice after calling _tryClose on the WKWebView
3413         https://bugs.webkit.org/show_bug.cgi?id=207121
3414         <rdar://problem/58880177>
3415
3416         Reviewed by Alex Christensen.
3417
3418         Add API test coverage.
3419
3420         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3421         * TestWebKitAPI/Tests/WebKit/beforeunload-slow.html: Added.
3422         * TestWebKitAPI/Tests/WebKitCocoa/ModalAlerts.mm:
3423         (-[SlowBeforeUnloadHandlerUIDelegate _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3424         (-[SlowBeforeUnloadHandlerUIDelegate webViewDidClose:]):
3425         (TEST):
3426
3427 2020-02-03  Lauro Moura  <lmoura@igalia.com>
3428
3429         [WebKitTestRunner] setOpenPanelFiles support in non-local tests
3430         https://bugs.webkit.org/show_bug.cgi?id=206517
3431
3432         Reviewed by Carlos Alberto Lopez Perez.
3433
3434         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3435         (WTR::TestRunner::setOpenPanelFiles): Use file:// if the passed path
3436         starts with a leading slash instead of using the test URL, which could
3437         cause input forms with invalid file data.
3438
3439 2020-02-03  Aakash Jain  <aakash_jain@apple.com>
3440
3441         [ews] Set custom build summary for webkitpy tests
3442         https://bugs.webkit.org/show_bug.cgi?id=207027
3443
3444         Reviewed by Jonathan Bedard.
3445
3446         * BuildSlaveSupport/ews-build/factories.py:
3447         * BuildSlaveSupport/ews-build/steps.py:
3448         (WebKitPyTest.setBuildSummary):
3449         (WebKitPyTest.getResultSummary):
3450         * BuildSlaveSupport/ews-build/factories_unittest.py:
3451
3452 2020-02-03  Jonathan Bedard  <jbedard@apple.com>
3453
3454         run-javascriptcore-tests: Don't split binary results
3455         https://bugs.webkit.org/show_bug.cgi?id=207118
3456
3457         Rubber-stamped by Aakash Jain.
3458
3459         * Scripts/run-javascriptcore-tests:
3460         (runTest): Only report aggregated binary results.
3461
3462 2020-02-03  Chris Dumez  <cdumez@apple.com>
3463
3464         Unreviewed, disable ResponsivenessTimer test in Debug / ASAN
3465
3466         The ResponsivenessTimer is disabled for those configurations as of r255518.
3467
3468         * TestWebKitAPI/Tests/WebKit/ResponsivenessTimerCrash.mm:
3469
3470 2020-02-03  Zan Dobersek  <zdobersek@igalia.com>
3471
3472         Use std::hypot() where possible
3473         https://bugs.webkit.org/show_bug.cgi?id=198483
3474
3475         Reviewed by Carlos Garcia Campos.
3476
3477         Use std::hypot() where possible, allowing for a possibly more precise
3478         calculation of square roots of sums of two or three square values.
3479
3480         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
3481         (-[DragAndDropSimulator initialProgressForMouseDrag]):
3482
3483 2020-02-03  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
3484
3485         [JHBuild] remove libvpx
3486         https://bugs.webkit.org/show_bug.cgi?id=207103
3487
3488         Reviewed by Xabier Rodriguez-Calvar.
3489
3490         libvpx were added in jhbuild in times of OpenWebRTC. Nowadays, LibWebRTC is used and libvpx is
3491         installed through Tools/gtk/install-dependencies, thus it should be removed from jhbuild.modules
3492
3493         * gstreamer/jhbuild.modules: remove libvpx.
3494
3495 2020-02-02  Sam Weinig  <weinig@apple.com>
3496
3497         Update style checker with new locations OS version checks are allowed
3498         https://bugs.webkit.org/show_bug.cgi?id=207106
3499
3500         Reviewed by Alexey Proskuryakov.
3501
3502         * Scripts/webkitpy/style/checkers/cpp.py:
3503         (check_os_version_checks):
3504         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3505         (WebKitStyleTest.test_os_version_checks):
3506         Update path check to allow anything with the pattern "Source/WTF/wtf/Platform[a-zA-Z]+\.h"
3507
3508 2020-02-01  Simon Fraser  <simon.fraser@apple.com>
3509
3510         Closing a MiniBrowser WK2 window does not release the WKWebView
3511         https://bugs.webkit.org/show_bug.cgi?id=203185
3512
3513         Reviewed by Wenson Hsieh.
3514         
3515         Use a weak WKWebView reference in the _textFinder.hideInterfaceCallback() block
3516         to avoid a retain cycle that keeps the window controller and WKWebView alive.
3517
3518         * MiniBrowser/mac/WK2BrowserWindowController.m:
3519         (-[WK2BrowserWindowController awakeFromNib]):
3520
3521 2020-01-31  David Quesada  <david_quesada@apple.com>
3522
3523         REGRESSION(r252185): NetworkSessionCocoa cancels downloads that receive authentication challenges
3524         https://bugs.webkit.org/show_bug.cgi?id=206984
3525         rdar://problem/58999654
3526
3527         Reviewed by Brady Eidson.
3528
3529         Add an API test for a resumed download that receives an authentication challenge. The download
3530         delegate should be asked to handle the challenge, and the download should be able to finish.
3531
3532         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3533         (-[DownloadCancelingDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3534         (-[DownloadCancelingDelegate _download:didReceiveData:]):
3535         (-[DownloadCancelingDelegate _downloadDidCancel:]):
3536         (-[AuthenticationChallengeHandlingDelegate _download:didReceiveAuthenticationChallenge:completionHandler:]):
3537         (-[AuthenticationChallengeHandlingDelegate _downloadDidFinish:]):
3538         (TEST):
3539
3540 2020-01-31  Wenson Hsieh  <wenson_hsieh@apple.com>
3541
3542         Add support for specifying background colors when setting marked text
3543         https://bugs.webkit.org/show_bug.cgi?id=207065
3544         <rdar://problem/57876140>
3545
3546         Reviewed by Tim Horton.
3547
3548         Add support in WebKitTestRunner for specifying a list of highlight ranges when setting marked text. This comes
3549         in the form of an additional argument to TextInputController::setMarkedText, which contains an array of objects,
3550         each describing one range (in the composition) to highlight.
3551
3552         * DumpRenderTree/ios/TextInputControllerIOS.m:
3553         (+[TextInputController isSelectorExcludedFromWebScript:]):
3554         (+[TextInputController webScriptNameForSelector:]):
3555         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:highlights:]):
3556         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]): Deleted.
3557         * DumpRenderTree/mac/TextInputControllerMac.m:
3558         (+[TextInputController isSelectorExcludedFromWebScript:]):
3559         (+[TextInputController webScriptNameForSelector:]):
3560         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:highlights:]):
3561         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]): Deleted.
3562         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
3563         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
3564         (WTR::arrayLength):
3565         (WTR::createCompositionHighlightData):
3566
3567         Add logic to convert a given JSObject containing the composition highlight information into a WKArrayRef, which
3568         is then passed into WebKit via WKBundlePageSetComposition.
3569
3570         (WTR::TextInputController::setMarkedText):
3571         * WebKitTestRunner/InjectedBundle/TextInputController.h:
3572
3573 2020-01-31  Alex Christensen  <achristensen@webkit.org>
3574
3575         Add KVO SPI WKWebView._negotiatedLegacyTLS
3576         https://bugs.webkit.org/show_bug.cgi?id=207067
3577
3578         Reviewed by Andy Estes.
3579
3580         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
3581         (-[TLSObserver observeValueForKeyPath:ofObject:change:context:]):
3582         (-[TLSObserver waitUntilNegotiatedLegacyTLSChanged]):
3583         (TestWebKitAPI::TEST):
3584         * TestWebKitAPI/config.h:
3585
3586 2020-01-31  Aakash Jain  <aakash_jain@apple.com>
3587
3588         [ews] Display flaky test names in build summary when ReRunWebKitTests passes
3589         https://bugs.webkit.org/show_bug.cgi?id=207050
3590
3591         Reviewed by Jonathan Bedard.
3592
3593         * BuildSlaveSupport/ews-build/steps.py:
3594         (ReRunWebKitTests.evaluateCommand):
3595
3596 2020-01-31  David Kilzer  <ddkilzer@apple.com>
3597
3598         REGRESSION: [ iPadOS ] imported/w3c/web-platform-tests/dom/events/Event-dispatch-on-disabled-elements.html always fails
3599         <https://webkit.org/b/206759>
3600         <rdar://problem/58872607>
3601
3602         Reviewed by Brent Fulgham.
3603
3604         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
3605         (WTR::UIScriptControllerIOS::waitForModalTransitionToFinish const):
3606         - Add declaration.
3607         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3608         (WTR::UIScriptControllerIOS::waitForModalTransitionToFinish const):
3609         - Implement by waiting for
3610           -[UIViewController isPerformingModalTransition] to return NO
3611           while spinning the runloop.
3612         (WTR::UIScriptControllerIOS::singleTapAtPointWithModifiers):
3613         - Call waitForModalTransitionToFinish() to fix the test.
3614
3615 2020-01-31  Aakash Jain  <aakash_jain@apple.com>
3616
3617         [ews] add build step to set custom build summary
3618         https://bugs.webkit.org/show_bug.cgi?id=207026
3619
3620         Reviewed by Jonathan Bedard.
3621
3622         * BuildSlaveSupport/ews-build/steps.py:
3623         (SetBuildSummary.doStepIf): Run this step only if build_summary property is set.
3624         (SetBuildSummary.hideStepIf): Hide this step if it is not executed.
3625         (SetBuildSummary.start):
3626
3627 2020-01-31  Jonathan Bedard  <jbedard@apple.com>
3628
3629         results.webkit.org: Handle modified firewall rules
3630         https://bugs.webkit.org/show_bug.cgi?id=207047
3631
3632         Reviewed by Aakash Jain.
3633
3634         * Scripts/webkitpy/results/upload.py:
3635         (Upload.upload_archive): Return true for 403 and 413 errors, but print a message
3636         indicating the upload failed.
3637         * Scripts/webkitpy/results/upload_unittest.py:
3638         (UploadTest.test_archive_upload):
3639
3640 2020-01-30  Jiewen Tan  <jiewen_tan@apple.com>
3641
3642         Unreviewed, another speculative test fix after r255041
3643
3644         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3645         (WTR::TestController::addTestKeyToKeychain):
3646         Adds kSecAttrAccessible: kSecAttrAccessibleAfterFirstUnlock to secItem to bypass
3647         potential error due to screen locks.
3648
3649 2020-01-30  Alex Christensen  <achristensen@webkit.org>
3650
3651         Add WKNavigationDelegate SPI to disable TLS 1.0 and 1.1
3652         https://bugs.webkit.org/show_bug.cgi?id=206979
3653
3654         Reviewed by Brady Eidson.
3655
3656         * MiniBrowser/mac/SettingsController.m:
3657         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
3658         (-[TLSNavigationDelegate waitForDidFinishNavigation]):
3659         (-[TLSNavigationDelegate waitForDidFailProvisionalNavigation]):
3660         (-[TLSNavigationDelegate receivedShouldAllowLegacyTLS]):
3661         (-[TLSNavigationDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
3662         (-[TLSNavigationDelegate webView:didFinishNavigation:]):
3663         (-[TLSNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3664         (-[TLSNavigationDelegate _webView:authenticationChallenge:shouldAllowLegacyTLS:]):
3665         (TestWebKitAPI::TEST):
3666
3667 2020-01-30  Jonathan Bedard  <jbedard@apple.com>
3668
3669         PAL: Remove old iOS version macros
3670         https://bugs.webkit.org/show_bug.cgi?id=206905
3671
3672         Reviewed by Darin Adler.
3673
3674         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm: Remove USE(NSPROGRESS_PUBLISHING_SPI)
3675         with HAVE(NSPROGRESS_PUBLISHING_SPI)
3676
3677 2020-01-30  Jonathan Bedard  <jbedard@apple.com>
3678
3679         TestWebKitAPI: Re-baseline AccessibilityTests for Catalyst
3680         https://bugs.webkit.org/show_bug.cgi?id=206997
3681
3682         Reviewed by Wenson Hsieh.
3683
3684         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
3685         (TestWebKitAPI::TEST):
3686
3687 2020-01-29  Jonathan Bedard  <jbedard@apple.com>
3688
3689         run-safari / run-webkit-tests --ios-simulator not working with XCode 13.3.1 (11C504)
3690         https://bugs.webkit.org/show_bug.cgi?id=206932
3691
3692         Reviewed by Alexey Proskuryakov.
3693
3694         * Scripts/webkitpy/xcode/simulated_device.py:
3695         (SimulatedDeviceManager.get_runtime_for_device_type): Request for a device running
3696         some version will return a runtime of the same major version with a minor version
3697         that is equal to or greater than the specified minor version.
3698         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3699         (test_matching_up_success):
3700         (test_matching_up_failure):
3701
3702 2020-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
3703
3704         [JSC] Give up IC when unknown structure transition happens
3705         https://bugs.webkit.org/show_bug.cgi?id=206846
3706
3707         Reviewed by Mark Lam.
3708
3709         Add `crash!` annotation, which allows us to write a crashing JS test.
3710
3711         * Scripts/run-jsc-stress-tests:
3712         * Scripts/webkitruby/jsc-stress-test-writer-default.rb:
3713         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb:
3714         * Scripts/webkitruby/jsc-stress-test-writer-ruby.rb:
3715
3716 2020-01-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3717
3718         [GTK] Add api-gtk to EWS bubbles.
3719         https://bugs.webkit.org/show_bug.cgi?id=206930
3720
3721         Reviewed by Aakash Jain.
3722
3723         A new queue has been added to the EWS to run GTK API tests in r255238.
3724         The queue is now running fine with no pre-existent failures.
3725         Let's add it to the EWS bubbles.
3726
3727         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3728         (StatusBubble):
3729
3730 2020-01-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3731
3732         [GTK] Fix TestWebKitAPI/TestJSC:/jsc/options API test after r255314
3733         https://bugs.webkit.org/show_bug.cgi?id=206927
3734
3735         Reviewed by Carlos Garcia Campos.
3736
3737         Update the default value tested from 4MB to 5MB.
3738
3739         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3740         (testsJSCOptions):
3741
3742 2020-01-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3743
3744         [GTK] Extra packages needed to successfully run API tests (cups-daemon and fonts-liberation)
3745         https://bugs.webkit.org/show_bug.cgi?id=206925
3746
3747         Reviewed by Carlos Garcia Campos.
3748
3749         Add cups-daemon to the list of packages to be installed, which is necessary to sucessfully
3750         run the printing related GTK API tests. Add also the liberation fonts, which are needed to
3751         run the complex text controller API tests.
3752
3753         * gtk/install-dependencies:
3754         * wpe/install-dependencies: Don't add cups packages, because WPE currently doesn't run print-related API test.
3755
3756 2020-01-28  Tim Horton  <timothy_horton@apple.com>
3757
3758         macCatalyst: Right clicking on a link follows it immediately
3759         https://bugs.webkit.org/show_bug.cgi?id=206919
3760         <rdar://problem/58936679>
3761
3762         Reviewed by Wenson Hsieh.
3763
3764         * TestWebKitAPI/Tests/WebKitCocoa/MacCatalystMouseSupport.mm:
3765         (TEST):
3766         Add a test ensuring that mouseup is still called with the secondary button,
3767         even if the event's buttonmask is 0.
3768
3769 2020-01-28  Jonathan Bedard  <jbedard@apple.com>
3770
3771         TestWebKitAPI: Conditionalize device orientation tests on ENABLE(DEVICE_ORIENTATION)
3772         https://bugs.webkit.org/show_bug.cgi?id=206913
3773         <rdar://problem/58973357>
3774
3775         Reviewed by Chris Dumez.
3776
3777         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
3778
3779 2020-01-28  Tim Horton  <timothy_horton@apple.com>
3780
3781         macCatalyst: Triple clicking to select a sentence results in an empty selection
3782         https://bugs.webkit.org/show_bug.cgi?id=206863
3783         <rdar://problem/58776993>
3784
3785         Reviewed by Wenson Hsieh.
3786
3787         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3788         * TestWebKitAPI/Tests/WebKitCocoa/MacCatalystMouseSupport.mm: Added.
3789         (-[WKTestingEvent locationInView:]):
3790         (-[WKTestingEvent _setButtonMask:]):
3791         (-[WKTestingEvent _buttonMask]):
3792         (-[WKTestingTouch locationInView:]):
3793         (-[WKTestingTouch setTapCount:]):
3794         (-[WKTestingTouch tapCount]):
3795         (mouseGesture):
3796         (TEST):
3797         Add a test ensuring that simply plumbing mouse events to WebCore
3798         does not result in a selection change in macCatalyst (because UIKit
3799         will handle the selection change itself, instead).
3800
3801 2020-01-28  Jonathan Bedard  <jbedard@apple.com>
3802
3803         TestWebKitAPI: Conditionalize QuickLook tests on USE(QUICK_LOOK)
3804         https://bugs.webkit.org/show_bug.cgi?id=206907
3805         <rdar://problem/58969924>
3806
3807         Rubber-stamped by Alexey Proskuryakov.
3808
3809         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm: Conditionalize on USE(QUICK_LOOK).
3810
3811 2020-01-28  Sihui Liu  <sihui_liu@apple.com>
3812
3813         IndexedDB: speed up index records deletion
3814         https://bugs.webkit.org/show_bug.cgi?id=206196
3815
3816         Reviewed by Brady Eidson.
3817
3818         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3819         * TestWebKitAPI/Tests/WebKitCocoa/IDBObjectStoreInfoUpgrade.sqlite3: Added.
3820         * TestWebKitAPI/Tests/WebKitCocoa/IDBObjectStoreInfoUpgradeToV2.html: Added.
3821         * TestWebKitAPI/Tests/WebKitCocoa/IDBObjectStoreInfoUpgradeToV2.mm: Added.
3822         (-[IDBObjectStoreInfoUpgradeToV2MessageHandler userContentController:didReceiveScriptMessage:]):
3823         (TEST):
3824
3825 2020-01-28  James Darpinian  <jdarpinian@chromium.org>
3826
3827         Quote file argument to git check-attr
3828         https://bugs.webkit.org/show_bug.cgi?id=206322
3829
3830         Reviewed by Jonathan Bedard.
3831
3832         * Scripts/prepare-ChangeLog:
3833         (attributeCommand):
3834         * Scripts/webkitperl/prepare-ChangeLog_unittest/filenameWithParentheses.pl: Added.
3835         (writeFileWithContent):
3836
3837 2020-01-28  Brent Fulgham  <bfulgham@apple.com>
3838
3839         Reset the application bundle identifier between test runs
3840         https://bugs.webkit.org/show_bug.cgi?id=206858
3841         <rdar://problem/58844002>
3842
3843         Reviewed by Per Arne Vollan.
3844
3845         Clear the application bundle identifier set during testing when resetting the test system
3846         to a known state in preparation for the next run.
3847
3848         * WebKitTestRunner/TestController.cpp:
3849         (WTR::TestController::resetStateToConsistentValues): Clear any override for the application
3850         bundle identifier before the next test invocation.
3851         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3852         (WTR::TestController::setApplicationBundleIdentifier): Correct an over-release caused by assigning
3853         an autorelease return value to an NSRetainPtr.
3854         (WTR::TestController::clearApplicationBundleIdentifierTestingOverride): Added.
3855
3856 2020-01-28  Aakash Jain  <aakash_jain@apple.com>
3857
3858         EWS django app should send cq+ patches to commit-queue
3859         https://bugs.webkit.org/show_bug.cgi?id=206534
3860
3861         Reviewed by Jonathan Bedard.
3862
3863         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3864         (Buildbot.send_patch_to_buildbot): Added support to send to commit queue.
3865         * BuildSlaveSupport/ews-app/ews/config.py: Added COMMIT_QUEUE_PORT.
3866         * BuildSlaveSupport/ews-app/ews/fetcher.py: Added support for sending patches to commit queue.
3867         * BuildSlaveSupport/ews-app/ews/migrations/0003_patch_sent_to_commit_queue.py: Added.
3868         * BuildSlaveSupport/ews-app/ews/models/patch.py:
3869         (Patch): Added sent_to_commit_queue field in patch table.
3870         (Patch.is_patch_sent_to_commit_queue): Method to check if patch is sent to commit queue.
3871         (Patch.set_sent_to_commit_queue): Set sent_to_commit_queue field.
3872
3873 2020-01-28  Stephan Szabo  <stephan.szabo@sony.com>
3874
3875         Python 3: Update windows scripts and uses of is constant
3876         https://bugs.webkit.org/show_bug.cgi?id=206856
3877
3878         Reviewed by Jonathan Bedard.
3879
3880         * Scripts/download-github-release.py: Update for python 3
3881         * Scripts/webkitpy/common/system/profiler.py: Change is constant usage
3882         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py: Change is constant usage
3883         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: Change is constant usage
3884         * Scripts/webkitpy/port/westondriver.py: Change is constant usage
3885         * Scripts/webkitpy/port/win.py: Update for python 3
3886         * Scripts/webkitpy/port/xvfbdriver.py: Change is constant usage
3887         * Scripts/webkitpy/xcode/device_type.py: Change is constant usage
3888
3889 2020-01-28  Jonathan Bedard  <jbedard@apple.com>
3890
3891         run-webkit-tests: clobber-old-results should remove the entire results folder
3892         https://bugs.webkit.org/show_bug.cgi?id=205875
3893         <rdar://problem/58236117>
3894
3895         Reviewed by Alexey Proskuryakov.
3896
3897         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3898         (Manager.run): Boot http servers after the build check and after clobbering
3899         old results.
3900         (Manager._clobber_old_results): Remove entire results folder.
3901         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3902         (RunTest.test_retrying_and_flaky_tests): clobber-old-results now removes the
3903         entire results directory.
3904
3905 2020-01-28  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3906
3907         [GTK] Add EWS testers to run GTK unit tests.
3908         https://bugs.webkit.org/show_bug.cgi?id=202361
3909
3910         Reviewed by Aakash Jain.
3911
3912         This switches two of the GTK BuildOnly EWS bots to be BuildAndRunAPITests bots.
3913         It doesn't make it a test-only bot because of concerns related with having to
3914         upload and download much data constantly over the network. It reuses the same
3915         logic for running Mac API tests, but simply using a different command at startup.
3916
3917         * BuildSlaveSupport/ews-build/config.json:
3918         * BuildSlaveSupport/ews-build/factories.py:
3919         (GTKBuildFactory):
3920         (GTKBuildAndTestFactory):
3921         (GTKBuildAndTestFactory.__init__):
3922         (GTKAPIBuildAndTestFactory):
3923         * BuildSlaveSupport/ews-build/loadConfig.py:
3924         * BuildSlaveSupport/ews-build/steps.py:
3925         (RunAPITests.start):
3926         (ReRunAPITests.evaluateCommand):
3927         * BuildSlaveSupport/ews-build/steps_unittest.py:
3928
3929 2020-01-28  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3930
3931         WPT test importer only rewrites the first URL on <style> tags.
3932         https://bugs.webkit.org/show_bug.cgi?id=206842
3933
3934         Reviewed by Jonathan Bedard.
3935
3936         There was an issue, when a <style> tag had several URL() paths
3937         to local references, only the first one was converted.
3938         This was caused because the test parser was only seeing the
3939         first one (re.search() only finds the first regex), instead use
3940         re.findall() to find all the ocurrences.
3941         Then in the test converter for relative paths, when there are
3942         several paths to be converted, convert from the last conversion
3943         instead of the original text.
3944
3945         * Scripts/webkitpy/w3c/test_converter.py:
3946         (_W3CTestConverter.convert_reference_relpaths):
3947         * Scripts/webkitpy/w3c/test_converter_unittest.py:
3948         (test_convert_style_multiple_url):
3949         * Scripts/webkitpy/w3c/test_parser.py:
3950         (TestParser.support_files):
3951         * Scripts/webkitpy/w3c/test_parser_unittest.py:
3952
3953 2020-01-28  Antoine Quint  <graouts@apple.com>
3954
3955         [Web Animations] Make Animation.timeline read-write only if a runtime flag is enabled
3956         https://bugs.webkit.org/show_bug.cgi?id=206173
3957         <rdar://problem/58527432>
3958
3959         Reviewed by Dean Jackson.
3960
3961         Manually enable the new WebAnimationsMutableTimelines runtime flag in DumpRenderTree.
3962
3963         * DumpRenderTree/mac/DumpRenderTree.mm:
3964         (enableExperimentalFeatures):
3965         * DumpRenderTree/win/DumpRenderTree.cpp:
3966         (enableExperimentalFeatures):
3967
3968 2020-01-27  Aakash Jain  <aakash_jain@apple.com>
3969
3970         [ews] Add method to fetch cq+ patches from Bugzilla
3971         https://bugs.webkit.org/show_bug.cgi?id=206774
3972
3973         Reviewed by Jonathan Bedard.
3974
3975         * BuildSlaveSupport/ews-app/ews/common/bugzilla.py:
3976         (Bugzilla._get_commit_queue_patches_from_bug): Method to get cq+ patches for a given bug.
3977         (Bugzilla._is_patch_cq_plus): Method to check if patch has cq+ flag set.
3978         (Bugzilla.get_list_of_patches_for_commit_queue): Method to fetch list of cq+ patches from Bugzilla.
3979         (BugzillaBeautifulSoup.fetch_bug_ids_for_commit_queue):
3980
3981 2020-01-27  Noam Rosenthal  <noam@webkit.org>
3982
3983         Unreviewed. Adding myself back as a reviewer.
3984
3985         * Scripts/webkitpy/common/config/contributors.json:
3986
3987 2020-01-27  Keith Rollin  <krollin@apple.com>
3988
3989         Fix internal builds
3990         https://bugs.webkit.org/show_bug.cgi?id=206790
3991         <rdar://problem/58888951>
3992
3993         Reviewed by Maciej Stachowiak.
3994
3995         TestRunner.cpp in DumpRenderTree includes ExecutableAllocator.h. In
3996         some circumstances, this file can include <os/thread_self_restrict.h>,
3997         which in turn includes <machine/cpu_capabilities.h>. This latter file
3998         does not exist at a standard location, and the build fails due to not
3999         being able to find the file. Fix this by adding a path to it to the
4000         build command line.
4001
4002         * DumpRenderTree/mac/Configurations/Base.xcconfig:
4003
4004 2020-01-27  Robin Morisset  <rmorisset@apple.com>
4005
4006         Tools/Scripts/set-webkit-configuration should accept --coverage/--no-coverage
4007         https://bugs.webkit.org/show_bug.cgi?id=206833
4008
4009         Reviewed by Jonathan Bedard.
4010
4011         Just a trivial fix to the arguments validation code of the script.
4012
4013         * Scripts/set-webkit-configuration:
4014
4015 2020-01-27  Said Abou-Hallawa  <sabouhallawa@apple.com>
4016
4017         Throttling requestAnimationFrame should be controlled by RenderingUpdateScheduler
4018         https://bugs.webkit.org/show_bug.cgi?id=204713
4019
4020         Reviewed by Simon Fraser.
4021
4022         RenderingUpdateThrottling is enabled by default. Turn it off for DRT and
4023         WTR. In some cases, the page may not get visually active while it's
4024         waiting for rAF. Throttling tests will have to explicitly turn it on.
4025
4026         * DumpRenderTree/mac/DumpRenderTree.mm:
4027         (resetWebPreferencesToConsistentValues):
4028         * DumpRenderTree/win/DumpRenderTree.cpp:
4029         (resetWebPreferencesToConsistentValues):
4030         * WebKitTestRunner/TestController.cpp:
4031         (WTR::TestController::resetPreferencesToConsistentValues):
4032
4033 2020-01-26  Aakash Jain  <aakash_jain@apple.com>
4034
4035         [ews] Status bubble hover over message in case of success should indicate whether it built the patch or run tests
4036         https://bugs.webkit.org/show_bug.cgi?id=206807
4037
4038         Reviewed by Jonathan Bedard.
4039
4040         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4041
4042 2020-01-27  Kate Cheney  <katherine_cheney@apple.com>
4043
4044         Delete the ITP storage file that is not being used (plist or database file) when switching to a new storage type
4045         https://bugs.webkit.org/show_bug.cgi?id=206601
4046         <rdar://problem/58696521>
4047
4048         Reviewed by Alex Christensen.
4049
4050         This patch caused some API tests to fail which relied on the ITP files
4051         always existing. Now the tests ensure the respective file exists when 
4052         switching between in-memory and database storage before running the tests.
4053
4054         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
4055         (ensureITPFileIsCreated):
4056         (TEST):
4057
4058 2020-01-27  Ryan Haddad  <ryanhaddad@apple.com>
4059
4060         Unreviewed, rolling out r255131.
4061
4062         Caused assertion failures on iOS debug bots.
4063
4064         Reverted changeset:
4065
4066         "Throttling requestAnimationFrame should be controlled by
4067         RenderingUpdateScheduler"
4068         https://bugs.webkit.org/show_bug.cgi?id=204713
4069         https://trac.webkit.org/changeset/255131
4070
4071 2020-01-27  Jonathan Bedard  <jbedard@apple.com>
4072
4073         webkitpy: Replace StringIO.StringIO in statusserver.py
4074         https://bugs.webkit.org/show_bug.cgi?id=206825
4075
4076         Reviewed by Aakash Jain.
4077
4078         * Scripts/webkitpy/common/net/statusserver.py:
4079         (StatusServer._upload_attachment_to_server): The Python 3 compatible StringIO
4080         object cannot be referenced as StringIO.StringIO
4081
4082 2020-01-26  Said Abou-Hallawa  <said@apple.com>
4083
4084         Throttling requestAnimationFrame should be controlled by RenderingUpdateScheduler
4085         https://bugs.webkit.org/show_bug.cgi?id=204713
4086
4087         Reviewed by Simon Fraser.
4088
4089         RenderingUpdateThrottling is enabled by default. Turn it off for DRT and
4090         WTR. In some cases, the page may not get visually active while it's
4091         waiting for rAF. Throttling tests will have to explicitly turn it on.
4092
4093         * DumpRenderTree/mac/DumpRenderTree.mm:
4094         (resetWebPreferencesToConsistentValues):
4095         * DumpRenderTree/win/DumpRenderTree.cpp:
4096         (resetWebPreferencesToConsistentValues):
4097         * WebKitTestRunner/TestController.cpp:
4098         (WTR::TestController::resetPreferencesToConsistentValues):
4099
4100 2020-01-25  Mark Lam  <mark.lam@apple.com>
4101
4102         Add some tests for dynamically allocated StaticStringImpls.
4103         https://bugs.webkit.org/show_bug.cgi?id=206802
4104
4105         Reviewed by Darin Adler.
4106
4107         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
4108         (TestWebKitAPI::doStaticStringImplTests):
4109         (TestWebKitAPI::TEST):
4110
4111 2020-01-25  Aakash Jain  <aakash_jain@apple.com>
4112
4113         webkit-patch upload should not submit automatically to old EWS
4114         https://bugs.webkit.org/show_bug.cgi?id=206801
4115
4116         Reviewed by Alexey Proskuryakov.
4117
4118         * Scripts/webkitpy/tool/commands/upload_unittest.py:
4119         * Scripts/webkitpy/tool/steps/submittoews.py:
4120
4121 2020-01-25  Per Arne Vollan  <pvollan@apple.com>
4122
4123         [Cocoa] Media mime types map should be created in the UI process
4124         https://bugs.webkit.org/show_bug.cgi?id=206478
4125
4126         Reviewed by Darin Adler.
4127
4128         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4129         * TestWebKitAPI/Tests/WebKit/MimeTypes.mm: Added.
4130         (TEST):
4131
4132 2020-01-25  Antti Koivisto  <antti@apple.com>
4133
4134         [LFC][Integration] Re-enable line layout integration
4135         https://bugs.webkit.org/show_bug.cgi?id=206795
4136         <rdar://problem/58853907>
4137
4138         Reviewed by Zalan Bujtas.
4139
4140         * DumpRenderTree/TestOptions.h:
4141
4142 2020-01-25  Youenn Fablet  <youenn@apple.com>
4143
4144         HTMLMediaElement should not remove the media session at DOM suspension time
4145         https://bugs.webkit.org/show_bug.cgi?id=206661
4146         <rdar://problem/58800787>
4147
4148         Reviewed by Eric Carlson.
4149
4150         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
4151         (TestWebKitAPI::TEST):
4152         Suspend/resume Active DOM Objects from time to time as would do scrolling.
4153         This allows pending tasks to be executed asynchronously when not scrolling.
4154
4155 2020-01-23  Matt Lewis  <jlewis3@apple.com>
4156
4157         Remove Apple windows 7 queues.
4158         https://bugs.webkit.org/show_bug.cgi?id=206702
4159
4160         Reviewed by Jonathan Bedard.
4161
4162         * BuildSlaveSupport/build.webkit.org-config/config.json:
4163         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4164         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
4165         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
4166         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
4167         Removed Windows 7 queues from config and from dashboard.
4168
4169 2020-01-24  Per Arne Vollan  <pvollan@apple.com>
4170
4171         Unreviewed, rolling out r255050.
4172
4173         Introduced crashes on bots
4174
4175         Reverted changeset:
4176
4177         "[Cocoa] Media mime types map should be created in the UI
4178         process"
4179         https://bugs.webkit.org/show_bug.cgi?id=206478
4180         https://trac.webkit.org/changeset/255050
4181
4182 2020-01-24  Jonathan Bedard  <jbedard@apple.com>
4183
4184         run-webkit-tests: Handle case where device socket make handle invalid
4185         https://bugs.webkit.org/show_bug.cgi?id=206707
4186
4187         Reviewed by Stephanie Lewis.
4188
4189         * Scripts/webkitpy/port/simulator_process.py:
4190         (SimulatorProcess.NonBlockingFileFromSocket.close): Catch IOError when closing file.
4191
4192 2020-01-24  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4193
4194         [GTK] API test runner fails with error: too many open files.
4195         https://bugs.webkit.org/show_bug.cgi?id=206743
4196
4197         Reviewed by Carlos Garcia Campos.
4198
4199         The API test runner for google tests was leaking file descriptors because
4200         it was not closing the file descriptor of the pseudo-terminal of the child,
4201         which was referred in the parent because of the forkpty() call.
4202         This was causing a small but constant increase of open file descriptors,
4203         until the point it reached the limit of maximum open files (1024 usually)
4204         causing this error.
4205
4206         Fix that by closing the reference to the fd of the child's pseudo-terminal.
4207
4208         * glib/api_test_runner.py:
4209         (TestRunner._run_google_test):
4210
4211 2020-01-24  Zan Dobersek  <zdobersek@igalia.com>
4212
4213         Unreviewed WPE dependency bump.
4214
4215         * wpe/jhbuild.modules: Bump the libwpe checkout commit to include fixes
4216         for configuration errors that can occur with older (but still supported)
4217         CMake versions.
4218
4219 2020-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
4220
4221         Unreviewed GTK gardening. Mark /webkit/WebKitWebPage/get-uri as flaky
4222
4223         * TestWebKitAPI/glib/TestExpectations.json:
4224
4225 2020-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
4226
4227         [iOS] Support setting minimum effective device width during dynamic viewport size updates
4228         https://bugs.webkit.org/show_bug.cgi?id=206709
4229         <rdar://problem/58713872>
4230
4231         Reviewed by Tim Horton.
4232
4233         Adds a new API test that changes both the effective minimum device width and view size during animated resize.
4234
4235         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
4236
4237 2020-01-23  Per Arne Vollan  <pvollan@apple.com>
4238
4239         [Cocoa] Media mime types map should be created in the UI process
4240         https://bugs.webkit.org/show_bug.cgi?id=206478
4241
4242         Reviewed by Darin Adler.
4243
4244         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4245         * TestWebKitAPI/Tests/WebKit/MimeTypes.mm: Added.
4246         (TEST):
4247
4248 2020-01-22  Jiewen Tan  <jiewen_tan@apple.com>
4249
4250         WebKitTestRunner: use ad hoc signing for internal Production builds
4251         https://bugs.webkit.org/show_bug.cgi?id=206607
4252         <rdar://problem/56087327>
4253
4254         Reviewed by Jonathan Bedard.
4255
4256         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
4257
4258 2020-01-23  Tuomas Karkkainen  <tuomas.webkit@apple.com>
4259
4260         Add missing coverage.xcconfig
4261         https://bugs.webkit.org/show_bug.cgi?id=206686
4262
4263         Reviewed by Mark Lam.
4264
4265         * coverage/coverage.xcconfig: Added.
4266
4267 2020-01-23  Per Arne Vollan  <pvollan@apple.com>
4268
4269         [Cocoa] Broker access to the PowerManagement API
4270         https://bugs.webkit.org/show_bug.cgi?id=206373
4271
4272         Reviewed by Darin Adler.
4273
4274         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4275         * TestWebKitAPI/Tests/WebKit/Battery.mm: Added.
4276         (TEST):
4277
4278 2020-01-23  Jonathan Bedard  <jbedard@apple.com>
4279
4280         Fix iOS 13.2 iphoneos build
4281         https://bugs.webkit.org/show_bug.cgi?id=206618
4282
4283         Reviewed by Alexey Proskuryakov.
4284
4285         * Scripts/webkitdirs.pm:
4286         (XcodeOptions): Relax provisioning profile rules on embedded SDKs.
4287
4288 2020-01-23  Takashi Komori  <Takashi.Komori@sony.com>
4289
4290         KeyedDecoderGeneric crashes when it accesses a data with empty string key.
4291         https://bugs.webkit.org/show_bug.cgi?id=206572
4292
4293         Reviewed by Fujii Hironori.
4294
4295         * TestWebKitAPI/Tests/WebCore/KeyedCoding.cpp:
4296         (TestWebKitAPI::TEST):
4297
4298 2020-01-23  Tuomas Karkkainen  <tuomas.webkit@apple.com>
4299
4300         It should be possible to build JavaScriptCore with LLVM Source-based Code Coverage, run the tests and see the coverage data
4301         https://bugs.webkit.org/show_bug.cgi?id=206389
4302
4303         Reviewed by Alexey Proskuryakov.
4304
4305         * Scripts/run-javascriptcore-tests:
4306         * Scripts/set-webkit-configuration:
4307         * Scripts/webkitdirs.pm:
4308         * coverage/coverage.xcconfig: Added.
4309
4310 2020-01-22  Jiewen Tan  <jiewen_tan@apple.com>
4311
4312         Unreviewed, rolling out r254955.
4313
4314         Broke internal builds
4315
4316         Reverted changeset:
4317
4318         "WebKitTestRunner: move code sign configurations from
4319         WebKitTestRunner.xcconfig to DebugRelease.xcconfig"
4320         https://bugs.webkit.org/show_bug.cgi?id=206607
4321         https://trac.webkit.org/changeset/254955
4322
4323 2020-01-22  Jiewen Tan  <jiewen_tan@apple.com>
4324
4325         WebKitTestRunner: move code sign configurations from WebKitTestRunner.xcconfig to DebugRelease.xcconfig
4326         https://bugs.webkit.org/show_bug.cgi?id=206607
4327         <rdar://problem/56087327>
4328
4329         Reviewed by Alexey Proskuryakov.
4330
4331         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
4332
4333 2020-01-22 &nbs