57da8bf8d71f6bd4fb63dda9c55eb64b996dab94
[WebKit-https.git] / Tools / ChangeLog
1 2018-08-21  Alex Christensen  <achristensen@webkit.org>
2
3         Translate WebKit.LimitTitleSize API test into ObjC
4         https://bugs.webkit.org/show_bug.cgi?id=188810
5
6         Reviewed by Andy Estes.
7
8         It uses WKPageLoaderClient.didReceiveTitleForFrame which has been replaced by KVO.
9         I'm translating the test into ObjC rather than introducing a new callback to WKPageNavigationClient.
10
11         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
12         * TestWebKitAPI/Tests/WebKit/LimitTitleSize.cpp: Removed.
13         * TestWebKitAPI/Tests/mac/LimitTitleSize.mm:
14         (TEST):
15         (-[LimitTitleSizeTestObserver observeValueForKeyPath:ofObject:change:context:]):
16         (TestWebKitAPI::TEST): Deleted.
17
18 2018-08-21  Alex Christensen  <achristensen@webkit.org>
19
20         Remove unused shouldKeepCurrentBackForwardListItemInList check
21         https://bugs.webkit.org/show_bug.cgi?id=188805
22
23         Reviewed by Andy Estes.
24
25         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
26         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp: Removed.
27
28 2018-08-21  Alex Christensen  <achristensen@webkit.org>
29
30         Transition more API tests from WKPageLoaderClient to WKPageNavigationClient
31         https://bugs.webkit.org/show_bug.cgi?id=188813
32
33         Reviewed by Andy Estes.
34
35         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
36         (TestWebKitAPI::didLayout):
37         (TestWebKitAPI::setPageLoaderClient):
38         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
39         (TestWebKitAPI::didFinishNavigation):
40         (TestWebKitAPI::didLayout):
41         (TestWebKitAPI::setPageLoaderClient):
42         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
43         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
44         (TestWebKitAPI::didLayout):
45         (TestWebKitAPI::setPageLoaderClient):
46
47 2018-08-21  Wenson Hsieh  <wenson_hsieh@apple.com>
48
49         [Attachment Support] Augment _WKAttachment SPI to handle NSFileWrappers in addition to NSData
50         https://bugs.webkit.org/show_bug.cgi?id=188496
51         <rdar://problem/43216836>
52
53         Reviewed by Tim Horton.
54
55         Adjusts existing attachment API tests. See below for more detail.
56
57         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
58         (-[TestWKWebView synchronouslyInsertAttachmentWithFileWrapper:contentType:]):
59         (-[TestWKWebView synchronouslyInsertAttachmentWithFilename:contentType:data:]):
60         (-[_WKAttachment synchronouslySetData:newContentType:newFilename:error:]):
61         (-[_WKAttachment synchronouslySetFileWrapper:newContentType:error:]):
62
63         Move off of deprecated attachment SPI, and add new helper functions to synchronously insert a new attachment or
64         update an existing attachment with a file wrapper.
65
66         (-[_WKAttachment expectRequestedDataToBe:]):
67         (TestWebKitAPI::TEST):
68
69         Add a new test to verify that file-URL-backed NSFileWrappers can be used to insert and update attachment data.
70         Also augment an existing test to check that an attachment element which has been copied and pasted within the
71         same document has a different _WKAttachment wrapper object than its duplicate, but both _WKAttachments are
72         backed by the same NSFileWrapper that was originally used to insert the attachment.
73
74         Additionally, add another macOS test to verify that dropping promised files in an attachment-element-enabled
75         editable area inserts attachment elements into the document and notifies the UI client with the inserted
76         attachment data.
77
78         (-[_WKAttachment synchronouslyRequestInfo:]): Deleted.
79         (-[_WKAttachment synchronouslyRequestData:]): Deleted.
80         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
81         (-[DragAndDropSimulator _webView:didInsertAttachment:withSource:]):
82
83         Move off of -_webView:didInsertAttachment:.
84
85         (-[DragAndDropSimulator _webView:didInsertAttachment:]): Deleted.
86
87 2018-08-21  David Kilzer  <ddkilzer@apple.com>
88
89         sort-Xcode-project-file: top-level files and folders are sorted unintentionally when `mainGroup` has no name
90         <https://webkit.org/b/188755>
91
92         Reviewed by Andy Estes.
93
94         * Scripts/sort-Xcode-project-file: Fix regular expression to
95         make `mainGroup` name optional.
96
97 2018-08-21  Andy VanWagoner  <andy@vanwagoner.family>
98
99         Unreviewed, add myself to committers list.
100
101         * Scripts/webkitpy/common/config/contributors.json:
102
103 2018-08-21  Antti Koivisto  <antti@apple.com>
104
105         Allow creating WeakPtrs to const objects
106         https://bugs.webkit.org/show_bug.cgi?id=188785
107
108         Reviewed by Geoffrey Garen.
109
110         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
111         (TestWebKitAPI::Base::weakPtrFactory const):
112         (TestWebKitAPI::TEST):
113         (TestWebKitAPI::Base::weakPtrFactory): Deleted.
114
115 2018-08-21  Per Arne Vollan  <pvollan@apple.com>
116
117         [WebGL] Contexts are not updated when display configuration changed.
118         https://bugs.webkit.org/show_bug.cgi?id=188750
119
120         Reviewed by Brent Fulgham.
121
122         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
123         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
124         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
125         * WebKitTestRunner/InjectedBundle/TestRunner.h:
126         * WebKitTestRunner/TestController.cpp:
127         (WTR::TestController::sendDisplayConfigurationChangedMessageForTesting):
128         * WebKitTestRunner/TestController.h:
129         * WebKitTestRunner/TestInvocation.cpp:
130         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
131
132 2018-08-21  John Wilander  <wilander@apple.com>
133
134         Make ResourceLoadObserver::logWebSocketLoading() handle websockets in detached frames
135         https://bugs.webkit.org/show_bug.cgi?id=188757
136         <rdar://problem/38713390>
137
138         Reviewed by Alex Christensen.
139
140         These changes add the new WebKitTestRunner function
141         isStatisticsRegisteredAsSubresourceUnder().
142
143         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
144         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
145         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
146         * WebKitTestRunner/InjectedBundle/TestRunner.h:
147         * WebKitTestRunner/TestController.cpp:
148         (WTR::TestController::isStatisticsRegisteredAsSubresourceUnder):
149         * WebKitTestRunner/TestController.h:
150         * WebKitTestRunner/TestInvocation.cpp:
151         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
152
153 2018-08-21  Alex Christensen  <achristensen@webkit.org>
154
155         Transition more API tests from WKPageLoaderClient to WKPageNavigationClient
156         https://bugs.webkit.org/show_bug.cgi?id=188797
157
158         Reviewed by Tim Horton.
159
160         * TestWebKitAPI/Tests/WebKit/AboutBlankLoad.cpp:
161         (TestWebKitAPI::didFinishNavigation):
162         (TestWebKitAPI::TEST):
163         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
164         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
165         (TestWebKitAPI::didSameDocumentNavigation):
166         (TestWebKitAPI::TEST):
167         (TestWebKitAPI::didSameDocumentNavigationForFrame): Deleted.
168         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
169         (TestWebKitAPI::didFailProvisionalNavigation):
170         (TestWebKitAPI::TEST):
171         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame): Deleted.
172         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
173         (TestWebKitAPI::didStartProvisionalNavigation):
174         (TestWebKitAPI::didCommitNavigation):
175         (TestWebKitAPI::didFinishNavigation):
176         (TestWebKitAPI::TEST):
177         (TestWebKitAPI::didStartProvisionalLoadForFrame): Deleted.
178         (TestWebKitAPI::didCommitLoadForFrame): Deleted.
179         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
180         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
181         (TestWebKitAPI::didStartProvisionalNavigation):
182         (TestWebKitAPI::didCommitNavigation):
183         (TestWebKitAPI::didFinishNavigation):
184         (TestWebKitAPI::TEST):
185         (TestWebKitAPI::didStartProvisionalLoadForFrame): Deleted.
186         (TestWebKitAPI::didCommitLoadForFrame): Deleted.
187         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
188         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
189         (TestWebKitAPI::renderingProgressDidChange):
190         (TestWebKitAPI::TEST):
191         (TestWebKitAPI::didLayout): Deleted.
192         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
193         (TestWebKitAPI::didFinishNavigation):
194         (TestWebKitAPI::renderingProgressDidChange):
195         (TestWebKitAPI::setPageLoaderClient):
196         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
197         (TestWebKitAPI::didLayout): Deleted.
198         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
199         (TestWebKitAPI::State::State):
200         (TestWebKitAPI::didStartProvisionalNavigation):
201         (TestWebKitAPI::didCommitNavigation):
202         (TestWebKitAPI::didFinishNavigation):
203         (TestWebKitAPI::decidePolicyForNavigationAction):
204         (TestWebKitAPI::decidePolicyForResponse):
205         (TestWebKitAPI::TEST):
206         (TestWebKitAPI::didStartProvisionalLoadForFrame): Deleted.
207         (TestWebKitAPI::didCommitLoadForFrame): Deleted.
208         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
209         (TestWebKitAPI::decidePolicyForNewWindowAction): Deleted.
210         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
211         (TestWebKitAPI::didSameDocumentNavigation):
212         (TestWebKitAPI::TEST):
213         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
214         (TestWebKitAPI::didSameDocumentNavigationForFrame): Deleted.
215         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
216         (TestWebKitAPI::TEST):
217         (TestWebKitAPI::didSameDocumentNavigationForFrame): Deleted.
218         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
219         (TestWebKitAPI::didFinishLoad):
220         (TestWebKitAPI::TEST):
221         * TestWebKitAPI/Tests/WebKit/WKBundleFileHandle.cpp:
222         (TestWebKitAPI::didFinishNavigation):
223         (TestWebKitAPI::TEST):
224         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
225         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
226         (TestWebKitAPI::didFinishLoad):
227         (TestWebKitAPI::TEST):
228         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
229         (WebKit2_CommandBackForwardTestWKView::SetUp):
230         (WebKit2_CommandBackForwardTestWKView::didFinishLoadForFrame): Deleted.
231
232 2018-08-20  Alex Christensen  <achristensen@webkit.org>
233
234         Replace WKPageLoaderClient with WKPageNavigationClient in many API tests
235         https://bugs.webkit.org/show_bug.cgi?id=188771
236
237         Reviewed by Tim Horton.
238
239         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
240         (TestWebKitAPI::didFinishNavigation):
241         (TestWebKitAPI::TEST):
242         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
243         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp:
244         (TestWebKitAPI::didFinishNavigation):
245         (TestWebKitAPI::TEST):
246         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
247         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
248         (TestWebKitAPI::didFinishNavigation):
249         (TestWebKitAPI::setPageLoaderClient):
250         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
251         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
252         (TestWebKitAPI::TEST):
253         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
254         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache.cpp:
255         (TestWebKitAPI::didFinishNavigation):
256         (TestWebKitAPI::setPageLoaderClient):
257         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
258         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
259         (TestWebKitAPI::didFinishNavigation):
260         (TestWebKitAPI::setClients):
261         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
262         * TestWebKitAPI/Tests/WebKit/Find.cpp:
263         (TestWebKitAPI::didFinishNavigation):
264         (TestWebKitAPI::TEST):
265         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
266         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
267         (TestWebKitAPI::didFinishNavigation):
268         (TestWebKitAPI::TEST):
269         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
270         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
271         (TestWebKitAPI::didFinishNavigation):
272         (TestWebKitAPI::TEST):
273         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
274         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
275         (TestWebKitAPI::didFinishNavigation):
276         (TestWebKitAPI::TEST):
277         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
278         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
279         (TestWebKitAPI::didFinishNavigation):
280         (TestWebKitAPI::TEST):
281         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
282         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
283         (TestWebKitAPI::didFinishNavigation):
284         (TestWebKitAPI::setPageLoaderClient):
285         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
286         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
287         (TestWebKitAPI::didFinishNavigation):
288         (TestWebKitAPI::TEST):
289         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
290         * TestWebKitAPI/Tests/WebKit/LimitTitleSize.cpp:
291         (TestWebKitAPI::didFinishLoadForFrame):
292         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
293         (TestWebKitAPI::didFinishNavigation):
294         (TestWebKitAPI::loadAlternateHTMLString):
295         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
296         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
297         (TestWebKitAPI::didFinishNavigation):
298         (TestWebKitAPI::TEST):
299         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
300         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
301         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
302         (TestWebKitAPI::didFinishLoad):
303         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
304         (TestWebKitAPI::didFinishNavigation):
305         (TestWebKitAPI::setPageLoaderClient):
306         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
307         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
308         (TestWebKitAPI::didFinishNavigation):
309         (TestWebKitAPI::setPageLoaderClient):
310         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
311         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
312         (TestWebKitAPI::didFinishLoadForFrame):
313         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
314         (TestWebKitAPI::TEST):
315         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
316         (TestWebKitAPI::TEST):
317         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
318         (TestWebKitAPI::didFinishLoad):
319         (TestWebKitAPI::TEST):
320         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
321         (TestWebKitAPI::didFinishNavigation):
322         (TestWebKitAPI::setPageLoaderClient):
323         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
324         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
325         (TestWebKitAPI::didFinishNavigation):
326         (TestWebKitAPI::setPageLoaderClient):
327         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
328         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
329         (TestWebKitAPI::didFinishNavigation):
330         (TestWebKitAPI::TEST):
331         (TestWebKitAPI::didFinishDocumentLoadForFrame): Deleted.
332         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
333         (TestWebKitAPI::didFinishNavigation):
334         (TestWebKitAPI::TEST):
335         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
336         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
337         (TestWebKitAPI::didFailProvisionalNavigation):
338         (TestWebKitAPI::TEST):
339         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame): Deleted.
340         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
341         (TestWebKitAPI::didFinishNavigation):
342         (TestWebKitAPI::TEST):
343         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
344         * TestWebKitAPI/Tests/WebKit/TextFieldDidBeginAndEndEditing.cpp:
345         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::didFinishNavigation):
346         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::setPageLoaderClient):
347         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::didFinishLoadForFrame): Deleted.
348         * TestWebKitAPI/Tests/WebKit/UserMessage.cpp:
349         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::didFinishNavigation):
350         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
351         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::didFinishLoadForFrame): Deleted.
352         * TestWebKitAPI/Tests/WebKit/WKPageConfiguration.cpp:
353         (TestWebKitAPI::didFinishNavigation):
354         (TestWebKitAPI::setPageLoaderClient):
355         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
356         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
357         (TestWebKitAPI::didFinishNavigation):
358         (TestWebKitAPI::setPageLoaderClient):
359         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
360         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
361         (TestWebKitAPI::didFinishNavigation):
362         (TestWebKitAPI::setPageLoaderClient):
363         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
364         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
365         (TestWebKitAPI::didFinishNavigation):
366         (TestWebKitAPI::setUpClients):
367         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
368         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
369         (TestWebKitAPI::didFinishNavigation):
370         (TestWebKitAPI::setPageLoaderClient):
371         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
372         * TestWebKitAPI/Tests/WebKit/WebArchive.cpp:
373         (TestWebKitAPI::didFinishNavigation):
374         (TestWebKitAPI::TEST):
375         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
376         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
377         (TestWebKitAPI::didFinishNavigation):
378         (TestWebKitAPI::TEST):
379         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
380         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
381         (TestWebKitAPI::didFinishNavigation):
382         (TestWebKitAPI::TEST):
383         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
384         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
385         (TestWebKitAPI::didFinishNavigation):
386         (TestWebKitAPI::TEST):
387         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
388         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
389         (TestWebKitAPI::didFinishNavigation):
390         (TestWebKitAPI::TEST):
391         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
392         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
393         (TestWebKitAPI::didFinishNavigation):
394         (TestWebKitAPI::TEST):
395         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
396         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
397         (TestWebKitAPI::didFinishNavigation):
398         (TestWebKitAPI::TEST):
399         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
400         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
401         (didFinishNavigation):
402         (TestWebKitAPI::TEST):
403         (didFinishLoadForFrame): Deleted.
404         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
405         (didFinishNavigation):
406         (TestWebKitAPI::TEST):
407         (didFinishLoadForFrame): Deleted.
408         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
409         (TestWebKitAPI::didFinishNavigation):
410         (TestWebKitAPI::TEST):
411         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
412         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
413         (TestWebKitAPI::didFinishNavigation):
414         (TestWebKitAPI::setPageLoaderClient):
415         (TestWebKitAPI::didFinishLoadForFrame): Deleted.
416
417 2018-08-21  Adrian Perez de Castro  <aperez@igalia.com>
418
419         [WPE] Update to use libwpe-1.0.0 and WPEBackend-fdo-1.0.0
420         https://bugs.webkit.org/show_bug.cgi?id=188782
421
422         Reviewed by Michael Catanzaro.
423
424         Make the build depend on wpe-0.2, and change the Flatpak and JHBuild development
425         environments to use version 1.0.0 of libwpe and WPEBackend-fdo.
426
427         * flatpak/org.webkit.WPE.yaml: Update to use libwpe and WPEBackend-fdo version 1.0.0 from
428         release tarballs, and removed the (now unneeded) Lua and LuaJIT modules.
429         * wpe/jhbuild.modules: Ditto.
430
431 2018-08-21  Michael Catanzaro  <mcatanzaro@igalia.com>
432
433         [Flatpak] Update to GNOME master runtime
434         https://bugs.webkit.org/show_bug.cgi?id=188731
435
436         Reviewed by Philippe Normand.
437
438         The 3.28 runtime is pretty stale at this point. We could wait a couple weeks for the 3.30
439         runtime, but I don't think there's any need to stick with the stable runtime when we have
440         the ability to pin to a particular version of the master runtime. There are also several
441         advantages to switching to the master runtime.
442
443         * flatpak/files/httpd-autogen.sh: Removed.
444         * flatpak/flatpakutils.py:
445         (WebkitFlatpak.clean_args):
446         * flatpak/org.webkit.GTK.yaml:
447         * flatpak/org.webkit.WebKit.yaml:
448         * flatpak/patches/httpd-0001-configure-use-pkg-config-for-PCRE-detection.patch: Removed.
449         * flatpak/patches/libgcrypt-0001-Use-pkg-config-to-detect-gpg-error.patch: Removed.
450
451 2018-08-20  Jonathan Bedard  <jbedard@apple.com>
452
453         WebKitTestRunner: Add watchOS entitlements
454         https://bugs.webkit.org/show_bug.cgi?id=188758
455
456         Reviewed by Tim Horton.
457
458         watchOS needs an additional entitlement to open up a socket for on-device testing.
459
460         * WebKitTestRunner/Configurations/WebKitTestRunnerApp-watchOS.entitlements: Added.
461         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
462         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
463
464 2018-08-20  Thomas Denney  <tdenney@apple.com>
465
466         [WHLSL] Remove generics from the interpreter
467         https://bugs.webkit.org/show_bug.cgi?id=187988
468
469         Reviewed by Myles C. Maxfield.
470
471         This patch completely removes generic and protocol support from WHLSL
472         whilst adding back any features that were originally implemented with
473         generics.
474
475         Many of the changes in this patch just remove occurrences of type
476         arguments and type parameters --- although there are some cases where
477         they have been deliberately left in --- as well as removing tests only
478         relevant to those features. These changes are not listed below.
479
480         * WebGPUShadingLanguageRI/All.js: Add/remove JS dependencies
481         * WebGPUShadingLanguageRI/AutoWrapper.js:
482         (AutoWrapper.prototype.visitConstexprTypeParameter): Deleted.
483         * WebGPUShadingLanguageRI/BuiltinVectorCasts.js: Added. The built-in
484         vectors have many constructors for different scalar and vector types.
485         These were originally implemented with generics.
486         * WebGPUShadingLanguageRI/BuiltinVectorEqualityOperator.js: Adds the
487         equality operator for built-in vectors, again this was removed with
488         generics.
489         * WebGPUShadingLanguageRI/BuiltinVectorGetter.js: Added, as above.
490         Built-in vectors only support the getter and setter, and not the ander.
491         * WebGPUShadingLanguageRI/BuiltinVectorIndexGetter.js: Added.
492         * WebGPUShadingLanguageRI/BuiltinVectorIndexSetter.js: Added.
493         * WebGPUShadingLanguageRI/BuiltinVectorSetter.js: Added.
494         * WebGPUShadingLanguageRI/CallExpression.js: Adds support for
495         instantiating functions which cannot be discovered earlier in
496         preparation because their types are absent (specifically support for the
497         operator &[] for array references and the length operator for array
498         references). Previously support for these was implemented with generics.
499         (CallExpression.resolve):
500         (CallExpression.prototype.resolve):
501         (CallExpression.prototype._resolveByInstantiation):
502         (CallExpression.prototype._resolveToOperatorAnderIndexer):
503         (CallExpression.prototype._resolveToOperatorLength):
504         (CallExpression.prototype.resolveToOverload):
505         (CallExpression.prototype.becomeCast):
506         (CallExpression.prototype.toString):
507         (CallExpression):
508         * WebGPUShadingLanguageRI/CallExpressionTypeArgumentResolver.js: Added.
509         We support syntax like vector<int, 2>(a, b) for constructing vectors;
510         this new preparation step resolves them to specific constructors.
511         * WebGPUShadingLanguageRI/CallFunction.js:
512         * WebGPUShadingLanguageRI/Checker.js:
513         * WebGPUShadingLanguageRI/ConstexprFolder.js:
514         * WebGPUShadingLanguageRI/CreateLiteralType.js:
515         * WebGPUShadingLanguageRI/ExpressionFinder.js:
516         * WebGPUShadingLanguageRI/FlattenProtocolExtends.js: Removed.
517         * WebGPUShadingLanguageRI/FlattenedStructOffsetGatherer.js:
518         * WebGPUShadingLanguageRI/Func.js:
519         * WebGPUShadingLanguageRI/FuncDef.js:
520         * WebGPUShadingLanguageRI/FuncInstantiator.js: Deleted.
521         * WebGPUShadingLanguageRI/InferTypesForCall.js: Removed usage of type arguments.
522         * WebGPUShadingLanguageRI/Inline.js: Remove use of FuncInstantiator.
523         * WebGPUShadingLanguageRI/Inliner.js: Ditto.
524         * WebGPUShadingLanguageRI/Intrinsics.js:
525         * WebGPUShadingLanguageRI/Lexer.js:
526         * WebGPUShadingLanguageRI/LiteralTypeChecker.js:
527         * WebGPUShadingLanguageRI/NameContext.js:
528         (NameContext.prototype.add):
529         (NameContext.prototype.get let):
530         (NameContext.underlyingThings.prototype.else):
531         (NameContext.prototype.resolveFuncOverload):
532         * WebGPUShadingLanguageRI/NameFinder.js:
533         * WebGPUShadingLanguageRI/NameResolver.js:
534         (NameResolver.prototype.visitFunc):
535         (NameResolver.prototype.visitFuncDef):
536         (NameResolver.prototype.visitTypeDef):
537         (NameResolver.prototype.visitStructType):
538         (NameResolver.prototype.visitTypeRef):
539         (NameResolver.prototype.visitCallExpression):
540         (NameResolver.prototype.visitVectorType):
541         (NameResolver):
542         (NameResolver.prototype._visitTypeParametersAndBuildNameContext): Deleted.
543         (NameResolver.prototype.visitProtocolDecl): Deleted.
544         * WebGPUShadingLanguageRI/NativeFunc.js:
545         (NativeFunc):
546         * WebGPUShadingLanguageRI/NativeFuncInstance.js: Deleted.
547         * WebGPUShadingLanguageRI/NativeType.js:
548         (NativeType):
549         (NativeType.prototype.get name):
550         (NativeType.prototype.toString):
551         (NativeType.prototype.get typeParameters): Deleted.
552         (NativeType.prototype.instantiate): Deleted.
553         * WebGPUShadingLanguageRI/Node.js:
554         (Node.prototype.commit):
555         (Node):
556         (Node.prototype.substitute): Deleted.
557         (Node.prototype.substituteToUnification): Deleted.
558         * WebGPUShadingLanguageRI/OperatorAnderIndex.js: Added, previously
559         implemented with generics.
560         * WebGPUShadingLanguageRI/OperatorArrayRefLength.js: Ditto.
561         * WebGPUShadingLanguageRI/OperatorBool.js: Ditto.
562         * WebGPUShadingLanguageRI/Parse.js: Removed everything related to
563         generics and protocols.
564         * WebGPUShadingLanguageRI/Prepare.js: Added new stages.
565         * WebGPUShadingLanguageRI/Program.js:
566         (Program):
567         (Program.prototype.get types):
568         (Program.prototype.add):
569         (Program.prototype.get protocols): Deleted.
570         * WebGPUShadingLanguageRI/ProtocolDecl.js: Removed.
571         * WebGPUShadingLanguageRI/ProtocolRef.js: Removed.
572         * WebGPUShadingLanguageRI/RecursiveTypeChecker.js:
573         * WebGPUShadingLanguageRI/ResolveCallExpressionsWithTypeArguments.js: Added.
574         * WebGPUShadingLanguageRI/ResolveNames.js:
575         * WebGPUShadingLanguageRI/ResolveOverloadImpl.js:
576         * WebGPUShadingLanguageRI/ResolveTypeDefs.js:
577         (resolveTypeDefsInProtocols): Deleted.
578         * WebGPUShadingLanguageRI/Rewriter.js: Changes for new classes.
579         * WebGPUShadingLanguageRI/SPIRV.html:
580         * WebGPUShadingLanguageRI/SPIRVCodegen.js:
581         * WebGPUShadingLanguageRI/StandardLibrary.js: Replace old generic features.
582         * WebGPUShadingLanguageRI/StatementCloner.js: Changes for new classes.
583         (StructLayoutBuilder):
584         * WebGPUShadingLanguageRI/StructType.js:
585         * WebGPUShadingLanguageRI/SwizzleOp.js:
586         (SwizzleOp):
587         (SwizzleOp.prototype.get baseTypeName):
588         (SwizzleOp.prototype.toString):
589         (SwizzleOp.functions.):
590         (SwizzleOp.functions):
591         (SwizzleOp.prototype.instantiateImplementation):
592         (SwizzleOp.allSwizzleOperators.): Deleted.
593         (SwizzleOp.allSwizzleOperators): Deleted.
594         * WebGPUShadingLanguageRI/SynthesizeArrayOperatorLength.js: Added,
595         previously implemented with generics.
596         * WebGPUShadingLanguageRI/SynthesizeCopyConstructorOperator.js: Ditto.
597         * WebGPUShadingLanguageRI/SynthesizeDefaultConstructorOperator.js: Ditto.
598         * WebGPUShadingLanguageRI/SynthesizeEnumFunctions.js: Ditto.
599         * WebGPUShadingLanguageRI/SynthesizeOperatorBool.js: Ditto.
600         * WebGPUShadingLanguageRI/SynthesizeStructAccessors.js:
601         (synthesizeStructAccessors.setupImplementationData):
602         (synthesizeStructAccessors.createFieldType):
603         (synthesizeStructAccessors.createTypeRef):
604         (synthesizeStructAccessors.setupAnder):
605         (synthesizeStructAccessors):
606         (synthesizeStructAccessors.createTypeParameters): Deleted.
607         (synthesizeStructAccessors.): Deleted.
608         * WebGPUShadingLanguageRI/Test.html:
609         * WebGPUShadingLanguageRI/Test.js: Removed redundant tests and added new
610         tests for changed language features.
611         * WebGPUShadingLanguageRI/Type.js:
612         * WebGPUShadingLanguageRI/TypeDef.js:
613         * WebGPUShadingLanguageRI/TypeDefResolver.js:
614         * WebGPUShadingLanguageRI/TypeParameterRewriter.js: Removed.
615         * WebGPUShadingLanguageRI/TypeRef.js:
616         * WebGPUShadingLanguageRI/TypeVariable.js: Removed.
617         * WebGPUShadingLanguageRI/UnificationContext.js:
618         * WebGPUShadingLanguageRI/VectorType.js: Added.
619         * WebGPUShadingLanguageRI/Visitor.js: Changes for new classes.
620         * WebGPUShadingLanguageRI/WSL.md: Removed description of
621         generics/protocols.
622         * WebGPUShadingLanguageRI/WrapChecker.js:
623         (WrapChecker):
624         (WrapChecker.visitConstexprTypeParameter): Deleted.
625         (WrapChecker.prototype.visitFuncParameter): Deleted.
626         (WrapChecker.prototype.visitTypeVariable): Deleted.
627         * WebGPUShadingLanguageRI/index.html:
628
629 2018-08-20  Thomas Denney  <tdenney@apple.com>
630
631         Added Thomas Denney to contributors.json.
632         https://bugs.webkit.org/show_bug.cgi?id=188525
633
634         Reviewed by Myles C. Maxfield.
635
636         * Scripts/webkitpy/common/config/contributors.json:
637
638 2018-08-20  Bernhard M. Wiedemann  <bwiedemann@suse.de>
639
640         [GTK] Sort inspector GResource manifest to ensure reproducible builds
641         https://bugs.webkit.org/show_bug.cgi?id=188738
642
643         Reviewed by Michael Catanzaro.
644
645         * glib/generate-inspector-gresource-manifest.py:
646         (get_filenames): sort list of input files
647
648 2018-08-20  Wenson Hsieh  <wenson_hsieh@apple.com>
649
650         [iOS] Paste is missing from callout bar when pasteboard only contains custom data
651         https://bugs.webkit.org/show_bug.cgi?id=184271
652         <rdar://problem/39256708>
653
654         Reviewed by Andy Estes.
655
656         This API test is failing when run against older macOS builds, where custom pasteboard
657         data is not enabled by default.
658
659         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
660         (TestWebKitAPI::TEST):
661
662 2018-08-20  Claudio Saavedra  <csaavedra@igalia.com>
663
664         Add WPE Debug configuration to the flakiness dashboard
665         https://bugs.webkit.org/show_bug.cgi?id=188743
666
667         Reviewed by Michael Catanzaro.
668
669         * TestResultServer/static-dashboards/builders.jsonp:
670         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
671
672 2018-08-19  Carlos Garcia Campos  <cgarcia@igalia.com>
673
674         [GLIB] Add API to throw exceptions using printf formatted strings
675         https://bugs.webkit.org/show_bug.cgi?id=188698
676
677         Reviewed by Michael Catanzaro.
678
679         Add cases to test the new API.
680
681         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
682         (createFormattedError):
683         (createCustomFormattedError):
684         (testJSCExceptions):
685
686 2018-08-19  Carlos Garcia Campos  <cgarcia@igalia.com>
687
688         [GLIB] Complete the JSCException API
689         https://bugs.webkit.org/show_bug.cgi?id=188695
690
691         Reviewed by Michael Catanzaro.
692
693         Add cases to test the new API.
694
695         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
696         (testJSCCheckSyntax):
697         (createCustomError):
698         (testJSCExceptions):
699
700 2018-08-18  Wenson Hsieh  <wenson_hsieh@apple.com>
701
702         [iOS] Paste is missing from callout bar when pasteboard only contains custom data
703         https://bugs.webkit.org/show_bug.cgi?id=184271
704         <rdar://problem/39256708>
705
706         Reviewed by Ryosuke Niwa.
707
708         Add a new API test to verify that on both iOS and macOS, copied custom pasteboard data can only be pasted in a
709         matching origin. Additionally verify that on iOS, the web view is capable of performing the "paste:" selector.
710
711         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
712         (TestWebKitAPI::TEST):
713         (imagePath): Deleted.
714         (writeTypesAndDataToPasteboard): Deleted.
715         (setUpWebView): Deleted.
716         (markupString): Deleted.
717
718         Make this test file no longer exclusive to macOS.
719
720         * TestWebKitAPI/cocoa/TestWKWebView.h:
721         * TestWebKitAPI/cocoa/TestWKWebView.mm:
722         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]):
723
724         Tweak this helper to also take in a `baseURL`. Defaults to using the TestWebKitAPI bundle resource URL.
725
726         (-[TestWKWebView synchronouslyLoadHTMLString:]):
727
728 2018-08-17  Jonathan Bedard  <jbedard@apple.com>
729
730         Add back --wtf-only to run-api-tests
731         https://bugs.webkit.org/show_bug.cgi?id=187893
732         <rdar://problem/42483983>
733
734         Reviewed by Aakash Jain.
735
736         When doing WTF development, it is not necessary to build or run all of the API
737         tests. Generally, if a user has specified a specific binary (or binaries) that
738         they are interested in testing, it is not necessary to check all API test binaries.
739
740         * Scripts/webkitpy/api_tests/manager.py:
741         (Manager._collect_tests): Only use the binaries matching the program arguments
742         when collecting tests.
743         (Manager._binaries_for_arguments): Generate a list of binaries which match the
744         program arguments.
745         (Manager.run): Pass a list binaries to check.
746         * Scripts/webkitpy/api_tests/run_api_tests.py:
747         (parse_args):
748         * Scripts/webkitpy/port/base.py:
749         (Port.check_api_test_build): If the caller specifies which API test binaries it
750         requires, only check the ones specified.
751         (Port.path_to_api_test_binaries): Allow the caller to only build the WTF API tests.
752         (Port._build_api_tests): Allow the caller to only build the WTF API tests.
753         * Scripts/webkitpy/port/win.py:
754         (WinPort.path_to_api_test_binaries):
755
756 2018-08-17  Jer Noble  <jer.noble@apple.com>
757
758         REGRESSION (234743) Timeouts in TestWebKitAPI.PreferredAudioBufferSize.AudioWithWebAudio and TestWebKitAPI.PreferredAudioBufferSize.WebAudio
759         https://bugs.webkit.org/show_bug.cgi?id=188470
760         <rdar://problem/43144969>
761
762         Reviewed by Alex Christensen.
763
764         On a loaded server, the WebContent process may send the "playing" message before the
765         UIProcess has a chance to register a listener for that message. Restructure the tests
766         so that the listener is registered before the page is loaded.
767
768         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
769         (PreferredAudioBufferSize::runPlayingTestWithPageNamed):
770         (TEST_F):
771
772 2018-08-16  Wenson Hsieh  <wenson_hsieh@apple.com>
773
774         [macOS] [WK2] Add infrastructure to test receiving file promises on drop
775         https://bugs.webkit.org/show_bug.cgi?id=188583
776
777         Reviewed by Andy Estes.
778
779         Enable testing file promise drop handling on the WebKit2 port of macOS by introducing a subclass of
780         NSFilePromiseReceiver and implementing `-enumerateDraggingItemsWithOptions:forView:…` on TestDraggingInfo (the
781         concrete NSDraggingInfo implementation used by DragAndDropSimulator) using the mock file receiver. Also
782         introduces 3 new macOS tests. See below for more details.
783
784         A large portion of this logic is ported over from DumpRenderTree testing infrastructure added in r229297. In a
785         future patch, we should introduce a way to write code common to both API tests, WebKitTestRunner and
786         DumpRenderTree, and make this code shared among all three testing harnesses.
787
788         Tests:  DragAndDropTests.DragImageElementIntoFileUpload
789                 DragAndDropTests.DragPromisedImageFileIntoFileUpload
790                 DragAndDropTests.DragImageFileIntoFileUpload
791
792         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
793         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
794         (TEST):
795
796         Drive-by fix: Replace NSMakePoint with CGPointMake.
797
798         * TestWebKitAPI/Tests/WebKitCocoa/image-and-file-upload.html:
799
800         Add a new test page consisting of an image and a "file upload" area that updates exercises DataTransfer API to
801         load the dropped image.
802
803         * TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm:
804         (waitForConditionWithLogging):
805
806         Add a helper function to wait for a condition to evaluate to true. To make failures more informative,
807         additionally add a mechanism to log a warning message after a given timeout, if the condition has yet to be met.
808
809         (TEST):
810
811         Add new tests to exercise a few cases of file upload in WebKit, including: (1) dragging from an image element,
812         (2) dragging files written to the pasteboard as promises, and (3) files written to the pasteboard as file URLs.
813
814         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
815
816         Surface the new functionality provided by the file promise receiver mock via two new methods on
817         DragAndDropSimulator to (1) write files as file promises to the pasteboard, and (2) write files as file paths
818         directly to the pasteboard.
819
820         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
821         (-[DragAndDropSimulator performDragInWebView:atLocation:withImage:pasteboard:source:]):
822         (-[DragAndDropSimulator externalPromisedFiles]):
823         (getFilePathsAndTypeIdentifiers):
824         (-[DragAndDropSimulator writePromisedFiles:]):
825         (-[DragAndDropSimulator writeFiles:]):
826         * TestWebKitAPI/mac/TestDraggingInfo.h:
827         * TestWebKitAPI/mac/TestDraggingInfo.mm:
828         (-[TestDraggingInfo initWithDragAndDropSimulator:]):
829         (-[TestDraggingInfo filePromiseReceivers]):
830         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
831
832         Implement this by invoking the given block with a TestFilePromiseReceiver. While all other classes are
833         unhandled by this testing code, WebKit only calls into this with [NSFilePromiseReceiver class], this is
834         currently sufficient for testing purposes.
835
836         * TestWebKitAPI/mac/TestFilePromiseReceiver.h: Copied from Tools/TestWebKitAPI/mac/TestDraggingInfo.h.
837         * TestWebKitAPI/mac/TestFilePromiseReceiver.mm: Added.
838         (-[TestFilePromiseReceiver initWithPromisedTypeIdentifiers:dragAndDropSimulator:]):
839         (-[TestFilePromiseReceiver fileTypes]):
840         (-[TestFilePromiseReceiver fileNames]):
841         (-[TestFilePromiseReceiver dealloc]):
842         (-[TestFilePromiseReceiver draggingSource]):
843         (-[TestFilePromiseReceiver setDraggingSource:]):
844         (fileNameWithNumericSuffix):
845         (copyFile):
846
847         Add a helper to copy a file into a destination directory. Used to implement the main functionality of our
848         NSFilePromiseReceiver subclass, which copies the files specified by test code into the directory determined by
849         WebKit.
850
851         (-[TestFilePromiseReceiver receivePromisedFilesAtDestination:options:operationQueue:reader:]):
852
853 2018-08-16  Alex Christensen  <achristensen@webkit.org>
854
855         Add entitlement to MiniBrowser to allow it to communicate with com.apple.Safari.SafeBrowsing.Service
856         https://bugs.webkit.org/show_bug.cgi?id=188677
857
858         Reviewed by Tim Horton.
859
860         * MiniBrowser/MiniBrowser.entitlements:
861         SSBLookupContext lookUpURL:completionHandler: fails to communicate with its service without this entitlement
862         on released operating systems.  See <rdar://problem/42749777>
863
864 2018-08-16  Jer Noble  <jer.noble@apple.com>
865
866         Add option to run-api-tests to force running of DISABLED tests.
867         https://bugs.webkit.org/show_bug.cgi?id=188674
868
869         Reviewed by Joseph Pecoraro.
870
871         * Scripts/webkitpy/api_tests/run_api_tests.py:
872         (parse_args):
873         * Scripts/webkitpy/api_tests/runner.py:
874         (Runner.command_for_port):
875         (_Worker._run_single_test):
876
877 2018-08-16  Aakash Jain  <aakash_jain@apple.com>
878
879         [ews-build] Separate queues for Builders and Testers - macOS High Sierra
880         https://bugs.webkit.org/show_bug.cgi?id=188540
881
882         Reviewed by Lucas Forschler.
883
884         * BuildSlaveSupport/ews-build/config.json: Splitted few macOS queues into builders and testers. 
885
886 2018-08-16  Aakash Jain  <aakash_jain@apple.com>
887
888         [ews-build] Add build steps ArchiveTestResults, UploadTestResults and ExtractTestResults
889         https://bugs.webkit.org/show_bug.cgi?id=188666
890
891         Reviewed by Lucas Forschler.
892
893         * BuildSlaveSupport/ews-build/steps.py:
894         (ArchiveTestResults): Build step to Archive the test results.
895         (UploadTestResults): Build step to upload the archive.
896         (ExtractTestResults): Build step to unzip the archive on server and generate a link.
897         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
898         (ExpectMasterShellCommand): Copied from other similar internal code.
899
900 2018-08-16  Aakash Jain  <aakash_jain@apple.com>
901
902         [ews-build] Separate queues for Builders and Testers - macOS Sierra
903         https://bugs.webkit.org/show_bug.cgi?id=188516
904
905         Reviewed by Lucas Forschler.
906
907         * BuildSlaveSupport/ews-build/config.json: Splitted macOS Sierra Release queues into builders and testers.
908         * BuildSlaveSupport/ews-build/factories.py: Used appropriate base classes for builders and testers.
909
910 2018-08-16  Basuke Suzuki  <Basuke.Suzuki@sony.com>
911
912         [Win][DumpRenderTree] Remove error message for duplicated tests.
913         https://bugs.webkit.org/show_bug.cgi?id=188662
914
915         Reviewed by Per Arne Vollan.
916
917         This was added to track down an issue where the same tests appeared
918         to be run multiple times. This turned out to not be the case.
919         See https://bugs.webkit.org/show_bug.cgi?id=166760 .
920
921         * DumpRenderTree/win/DumpRenderTree.cpp:
922         (runTest):
923
924 2018-08-16  Alex Christensen  <achristensen@webkit.org>
925
926         Re-introduce assertion removed in r234890
927         https://bugs.webkit.org/show_bug.cgi?id=188611
928
929         Reviewed by Geoffrey Garen.
930
931         * TestWebKitAPI/Tests/WTF/Vector.cpp:
932         (TestWebKitAPI::TEST):
933
934 2018-08-16  Jer Noble  <jer.noble@apple.com>
935
936         Add Experimental Feature support for SourceBuffer.changeType()
937         https://bugs.webkit.org/show_bug.cgi?id=188626
938         <rdar://problem/43356021>
939
940         Reviewed by Eric Carlson.
941
942         * DumpRenderTree/mac/DumpRenderTree.mm:
943         (enableExperimentalFeatures):
944         (resetWebPreferencesToConsistentValues):
945         * WebKitTestRunner/TestController.cpp:
946         (WTR::TestController::resetPreferencesToConsistentValues):
947
948 2018-08-16  Aditya Keerthi  <akeerthi@apple.com>
949
950         Support drag-and-drop for input[type=color]
951         https://bugs.webkit.org/show_bug.cgi?id=188464
952
953         Reviewed by Wenson Hsieh.
954
955         Added five cross-platform API tests, to verify that dragging and dropping with
956         color inputs changes the value of the drop target if and only if both inputs are
957         enabled. Also tests that the change and input events are fired when changing the
958         value of a color input through drag and drop. 
959
960         Additionally, added a macOS-specific test to verify that dropping an item with
961         NSColorPboardType changes the value of the color input.
962
963         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
964         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
965         (TestWebKitAPI::TEST):
966         * TestWebKitAPI/Tests/WebKitCocoa/color-drop.html: Added.
967         * TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm:
968         (TestWebKitAPI::TEST):
969
970 2018-08-16  Antti Koivisto  <antti@apple.com>
971
972         Use OptionSet for ActivityState::Flags
973         https://bugs.webkit.org/show_bug.cgi?id=188554
974
975         Reviewed by Brent Fulgham.
976
977         * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
978         (TestWebKitAPI::TEST):
979
980 2018-08-16  Carlos Garcia Campos  <cgarcia@igalia.com>
981
982         [GTK] MiniBrowser: web view doesn't get the focus when new window is created
983         https://bugs.webkit.org/show_bug.cgi?id=188546
984
985         Reviewed by Michael Catanzaro.
986
987         When a new window is created, the first widget of the windo is getting the focus, the toolbar in this case. We
988         always want the WebView to grab the focus. In case of new empty tab, we want to the URL bar to be focused
989         instead. This was causing failures in WebDriver tests that create a popup window with an input element that is
990         filled with send keys command. The input element is marked as focused in the DOM, but the actual focused widget
991         is the toolbar, so key events are sent to the toolbar instead of the web view.
992
993         * MiniBrowser/gtk/BrowserWindow.c:
994         (webViewCreate):
995         (newTabCallback):
996         (openPrivateWindow):
997         (browser_window_get_or_create_web_view_for_automation):
998
999 2018-08-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1000
1001         Unreviewed. Fix WebDriver tests after r234839.
1002
1003         New pytest requires to autoinstall attrs too.
1004
1005         * Scripts/webkitpy/thirdparty/__init__.py:
1006         (AutoinstallImportHook._install_pytest):
1007
1008 2018-08-15  Ansh Shukla  <ansh_shukla@apple.com>
1009
1010         NSURLAuthenticationMethodOAuth challenges are surfaced to clients in -didReceiveAuthenticationChallenge as NSURLAuthenticationMethodDefault
1011         https://bugs.webkit.org/show_bug.cgi?id=186870
1012         <rdar://problem/41314410>
1013
1014         Reviewed by Alex Christensen.
1015
1016         * WebKitTestRunner/TestController.cpp:
1017         (WTR::toString):
1018         (WTR::TestController::canAuthenticateAgainstProtectionSpace): Expose type of authentication challenge so we can test OAuth.
1019         (WTR::TestController::didReceiveAuthenticationChallenge):
1020
1021 2018-08-15  Ben Richards  <benton_richards@apple.com>
1022
1023         We should cache the compiled sandbox profile in a data vault
1024         https://bugs.webkit.org/show_bug.cgi?id=184991
1025
1026         Reviewed by Ryosuke Niwa.
1027
1028         Added trace points for sandbox initialization
1029
1030         * Tracing/SystemTracePoints.plist:
1031
1032 2018-08-15  Ryan Haddad  <ryanhaddad@apple.com>
1033
1034         Unreviewed, rolling out r234870.
1035
1036         The test introduced with this change is a flaky failure.
1037
1038         Reverted changeset:
1039
1040         "NSURLAuthenticationMethodOAuth challenges are surfaced to
1041         clients in -didReceiveAuthenticationChallenge as
1042         NSURLAuthenticationMethodDefault"
1043         https://bugs.webkit.org/show_bug.cgi?id=186870
1044         https://trac.webkit.org/changeset/234870
1045
1046 2018-08-15  Jonathan Bedard  <jbedard@apple.com>
1047
1048         WebKitTestRunner should support watch devices
1049         https://bugs.webkit.org/show_bug.cgi?id=188570
1050
1051         Reviewed by Alex Christensen.
1052
1053         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1054
1055 2018-08-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1056
1057         [Attachment SPI] Remove attachment display mode options
1058         https://bugs.webkit.org/show_bug.cgi?id=188596
1059
1060         Reviewed by Dan Bernstein.
1061
1062         Remove API tests and API test helpers for verifying the behavior of in-place media attachment elements.
1063
1064         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1065         (-[TestWKWebView synchronouslyInsertAttachmentWithFilename:contentType:data:]):
1066         (TestWebKitAPI::TEST):
1067         (testVideoData): Deleted.
1068         (displayOptionsWithMode): Deleted.
1069         (-[TestWKWebView synchronouslyInsertAttachmentWithFilename:contentType:data:options:]): Deleted.
1070
1071 2018-08-14  Devin Rousso  <drousso@apple.com>
1072
1073         Unreviewed, change my emails.
1074
1075         * Scripts/webkitpy/common/config/contributors.json:
1076         * Scripts/webkitpy/common/config/watchlist:
1077
1078 2018-08-14  Saam barati  <sbarati@apple.com>
1079
1080         HashMap<Ref<P>, V> asserts when V is not zero for its empty value
1081         https://bugs.webkit.org/show_bug.cgi?id=188582
1082
1083         Reviewed by Sam Weinig.
1084
1085         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1086         (TestWebKitAPI::TEST):
1087
1088 2018-08-14  Zalan Bujtas  <zalan@apple.com>
1089
1090         [LFC][Floating] Add support for negative clearance.
1091         https://bugs.webkit.org/show_bug.cgi?id=188555
1092
1093         Reviewed by Simon Fraser.
1094
1095         * LayoutReloaded/misc/LFC-passing-tests.txt:
1096
1097 2018-08-14 Sihui Liu <sihui_liu@apple.com>
1098
1099         Crash in WebKit::filterPreloadHSTSEntry via NetworkProcess::getHostNamesWithHSTSCache
1100         https://bugs.webkit.org/show_bug.cgi?id=188576
1101         <rdar://problem/43148977>
1102
1103         Reviewed by Alex Christensen.
1104
1105         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1106         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm: Added.
1107         (TEST):
1108
1109 2018-08-14  Alex Christensen  <achristensen@webkit.org>
1110
1111         isValidCSSSelector is unsafe to be called from a non-main thread
1112         https://bugs.webkit.org/show_bug.cgi?id=188581
1113         <rdar://problem/40517358>
1114
1115         Reviewed by Sam Weinig.
1116
1117         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1118         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
1119         (TestWebKitAPI::checkCompilerError):
1120
1121 2018-08-14  Ansh Shukla  <ansh_shukla@apple.com>
1122
1123         NSURLAuthenticationMethodOAuth challenges are surfaced to clients in -didReceiveAuthenticationChallenge as NSURLAuthenticationMethodDefault
1124         https://bugs.webkit.org/show_bug.cgi?id=186870
1125         <rdar://problem/41314410>
1126
1127         Reviewed by Alex Christensen.
1128
1129         * WebKitTestRunner/TestController.cpp:
1130         (WTR::toString):
1131         (WTR::TestController::canAuthenticateAgainstProtectionSpace): Expose type of authentication challenge so we can test OAuth.
1132         (WTR::TestController::didReceiveAuthenticationChallenge):
1133
1134 2018-08-14  Fujii Hironori  <Hironori.Fujii@sony.com>
1135
1136         [webkitpy][Win] LayoutTests: test names should be Unix style, separated by slash not backslash
1137         https://bugs.webkit.org/show_bug.cgi?id=187973
1138
1139         Reviewed by Alex Christensen.
1140
1141         In LayoutTests, test names have been canonicalized in Unix style
1142         since Bug 63597, for example 'fast/css/001.html'. But Bug 179219,
1143         Bug 179572, Bug 180660, and Bug 181814 have changed to use
1144         os.path.seq instead of slash if Windows Python is used.
1145
1146         Revert parts of those changes. Change relative_test_filename to
1147         return a slash-separated test name as chromium_win.py used to do.
1148
1149         This change fixes all 41 test-webkitpy failures in WinCairo port.
1150
1151         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1152         (TestExpectationParser._parse_line): Do not convert test names with normpath.
1153         * Scripts/webkitpy/port/base.py:
1154         (Port.normalize_test_name): Use TEST_PATH_SEPARATOR instead of os.path.sep.
1155         (Port.relative_test_filename): Replace self.host.filesystem.sep with self.TEST_PATH_SEPARATOR.
1156         (Port.abspath_for_test): Replace self.TEST_PATH_SEPARATOR with self.host.filesystem.sep.
1157         * Scripts/webkitpy/port/driver.py:
1158         (Driver): Use '/' instead of os.sep.
1159         * Scripts/webkitpy/port/win.py:
1160         (WinCairoPort): Do not override TEST_PATH_SEPARATOR.
1161
1162 2018-08-14  Aakash Jain  <aakash_jain@apple.com>
1163
1164         [ews-build] Add build step to run WK1 layout-test
1165         https://bugs.webkit.org/show_bug.cgi?id=188498
1166
1167         Reviewed by Lucas Forschler.
1168
1169         * BuildSlaveSupport/ews-build/steps.py:
1170         (RunWebKit1Tests): Class to run WebKit1Tests.
1171         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1172
1173 2018-08-14  Patrick Griffis  <pgriffis@igalia.com>
1174
1175         [Flatpak] Fix --cmakeargs
1176         https://bugs.webkit.org/show_bug.cgi?id=188567
1177
1178         Reviewed by Michael Catanzaro.
1179
1180         * flatpak/flatpakutils.py:
1181         (WebkitFlatpak.setup_dev_env):
1182
1183 2018-08-14  Darshan Kadu  <dkadu@igalia.com>
1184
1185         Enhancement request: Make export-w3c-test-changes add the PR to "See Also" links
1186         https://bugs.webkit.org/show_bug.cgi?id=186140
1187
1188         Reviewed by Youenn Fablet.
1189
1190         Added an optional parameter see_also to post_comment_to_bug function and used it for adding see_also variable's content in "See Also"
1191         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1192         (Bugzilla.post_comment_to_bug):
1193         Modified mock for see_also parameter
1194         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1195         (MockBugzilla.post_comment_to_bug):
1196         Made following unit tests to have see_also in bug comment
1197         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1198         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
1199         (SheriffTest.test_post_blame_comment_on_bug):
1200         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:
1201         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1202         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1203         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py:
1204         * Scripts/webkitpy/w3c/test_exporter.py:
1205         (WebPlatformTestExporter.make_pull_request):
1206         * Scripts/webkitpy/w3c/test_exporter_unittest.py:
1207         (TestExporterTest.MockBugzilla.post_comment_to_bug):
1208         (TestExporterTest.test_export):
1209
1210 2018-08-14  Aakash Jain  <aakash_jain@apple.com>
1211
1212         [ews-build] Add support for max_builds parameter for workers
1213         https://bugs.webkit.org/show_bug.cgi?id=188531
1214
1215         Reviewed by Lucas Forschler.
1216
1217         * BuildSlaveSupport/ews-build/loadConfig.py:
1218         (loadBuilderConfig): Added support for max_builds.
1219
1220 2018-08-14  Zalan Bujtas  <zalan@apple.com>
1221
1222         [LFC][Floating] Adjust vertical position with non-collapsing previous sibling margin.
1223         https://bugs.webkit.org/show_bug.cgi?id=188543
1224
1225         Reviewed by Antti Koivisto.
1226
1227         * LayoutReloaded/misc/LFC-passing-tests.txt:
1228
1229 2018-08-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1230
1231         Unreviewed. Fix WebDriver tests after r234839.
1232
1233         New pytest requires to autoinstall more_itertools and six too.
1234
1235         * Scripts/webkitpy/thirdparty/__init__.py:
1236         (AutoinstallImportHook._install_pytest):
1237
1238 2018-08-14  Tomas Popela  <tpopela@redhat.com>
1239
1240         [GTK] Minibrowser: Add labels for buttons
1241         https://bugs.webkit.org/show_bug.cgi?id=188549
1242
1243         Reviewed by Carlos Garcia Campos.
1244
1245         So they are accessible easier (i.e. while testing WebKitGTK+ through Minibrowser in Dogtail).
1246
1247         * MiniBrowser/gtk/BrowserWindow.c:
1248         (webViewIsLoadingChanged):
1249         (browserWindowSetupEditorToolbar):
1250         (browser_window_init):
1251
1252 2018-08-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1253
1254         Unreviewed. Fix WebDriver tests after r234839.
1255
1256         New pytest requires to autoinstall atomicwrites too.
1257
1258         * Scripts/webkitpy/thirdparty/__init__.py:
1259         (AutoinstallImportHook._install_pytest):
1260
1261 2018-08-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1262
1263         Unreviewed. Fix WebDriver tests after r234839.
1264
1265         New pytest requires to autoinstall pluggy and funcsigs too.
1266
1267         * Scripts/webkitpy/thirdparty/__init__.py:
1268         (AutoinstallImportHook._install_pytest):
1269
1270 2018-08-13  Carlos Garcia Campos  <cgarcia@igalia.com>
1271
1272         Unreviewed. Update W3C WebDriver imported tests.
1273
1274         Bump pytest version to 3.6.2.
1275
1276         * Scripts/webkitpy/thirdparty/__init__.py:
1277         (AutoinstallImportHook._install_pytest):
1278
1279 2018-08-13  Thomas Denney  <tdenney@apple.com>
1280
1281         Allow the substring 'me' in contributor names and email addresses
1282         https://bugs.webkit.org/show_bug.cgi?id=188538
1283
1284         Reviewed by Tim Horton.
1285
1286         A test didn't permit the string "me" in email addresses or names of contributors.
1287
1288         * Scripts/webkitpy/common/config/committers_unittest.py:
1289         (CommittersTest.test_contributors_by_fuzzy_match):
1290
1291 2018-08-13  Commit Queue  <commit-queue@webkit.org>
1292
1293         Unreviewed, rolling out r234812.
1294         https://bugs.webkit.org/show_bug.cgi?id=188536
1295
1296         broke the build (Requested by ThomasDenney on #webkit).
1297
1298         Reverted changeset:
1299
1300         "Added Thomas Denney to contributors.json."
1301         https://bugs.webkit.org/show_bug.cgi?id=188525
1302         https://trac.webkit.org/changeset/234812
1303
1304 2018-08-13  Sihui Liu  <sihui_liu@apple.com>
1305
1306         Avoid timeout resulted from calling waitUntilDone when test is not running
1307         https://bugs.webkit.org/show_bug.cgi?id=188389
1308
1309         Reviewed by Chris Dumez.
1310
1311         If test is not running, we should not set the waitUntilDone flag, or it may cause subsequent tests timeout.
1312
1313         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1314         (WTR::TestRunner::waitUntilDone):
1315
1316 2018-08-13  Wenson Hsieh  <wenson_hsieh@apple.com>
1317
1318         [WK2] [macOS] Implement a mechanism to test drag and drop
1319         https://bugs.webkit.org/show_bug.cgi?id=181898
1320         <rdar://problem/39181698>
1321
1322         Reviewed by Simon Fraser.
1323
1324         Implements the currently stubbed DragAndDropSimulator on macOS, and introduces a new API test for r227266. See
1325         comments below for more detail.
1326
1327         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1328         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm: Copied from Tools/TestWebKitAPI/mac/DragAndDropSimulatorMac.mm.
1329
1330         Introduce a file for cross-platform drag and drop tests, currently for iOS and macOS. Additionally add a test
1331         for r227266, which was fixed earlier this year but could not be tested due to a lack of testing mechanism on
1332         macOS in WebKit2.
1333
1334         (TEST):
1335         * TestWebKitAPI/Tests/WebKitCocoa/full-page-dropzone.html: Added.
1336
1337         Minor tweaks to this test page to add "dragover" and "drop" event handlers.
1338
1339         * TestWebKitAPI/Tests/WebKitCocoa/image-in-link-and-input.html:
1340         * TestWebKitAPI/Tests/WebKitCocoa/link-in-iframe-and-input.html: Added.
1341
1342         Add a new test page that includes a link embedded within an iframe below a plain text input.
1343
1344         * TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm: Added.
1345         (TEST):
1346         * TestWebKitAPI/Tests/mac/LegacyDragAndDropTests.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm.
1347
1348         Move only existing WebKit2 macOS drag and drop test (DragAndDropPasteboardTests.NumberOfValidItemsForDrop) out
1349         of DragAndDropPasteboardTests.mm and into a new file, DragAndDropTestsMac.mm. Additionally, rename
1350         DragAndDropPasteboardTests to LegacyDragAndDropTests, since it now only contains two legacy WebView tests for
1351         drag and drop.
1352
1353         (+[FrameLoadCompletionListener listenerWithCompletionBlock:]):
1354         (-[FrameLoadCompletionListener initWithCompletionBlock:]):
1355         (-[FrameLoadCompletionListener webView:didFinishLoadForFrame:]):
1356         (-[DragSource draggingSourceOperationMaskForLocal:]):
1357         (-[DragInfo initWithImage:offset:pasteboard:source:destinationWindow:]):
1358         (-[DragInfo lastMousePosition]):
1359         (-[DragInfo setLastMousePosition:]):
1360         (-[DragInfo draggingDestinationWindow]):
1361         (-[DragInfo draggingSourceOperationMask]):
1362         (-[DragInfo draggingLocation]):
1363         (-[DragInfo draggedImageLocation]):
1364         (-[DragInfo draggedImage]):
1365         (-[DragInfo draggingPasteboard]):
1366         (-[DragInfo draggingSource]):
1367         (-[DragInfo draggingSequenceNumber]):
1368         (-[DragInfo slideDraggedImageTo:]):
1369         (-[DragInfo namesOfPromisedFilesDroppedAtDestination:]):
1370         (-[DragInfo draggingFormation]):
1371         (-[DragInfo setDraggingFormation:]):
1372         (-[DragInfo animatesToDestination]):
1373         (-[DragInfo setAnimatesToDestination:]):
1374         (-[DragInfo numberOfValidItemsForDrop]):
1375         (-[DragInfo setNumberOfValidItemsForDrop:]):
1376         (-[DragInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1377         (-[DragInfo springLoadingHighlight]):
1378         (-[DragInfo resetSpringLoading]):
1379         (TestWebKitAPI::getTestImage):
1380         (TestWebKitAPI::webViewAfterPerformingDragOperation):
1381         (TestWebKitAPI::TEST):
1382         * TestWebKitAPI/Tests/mac/full-page-dropzone.html: Removed.
1383         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1384
1385         Flesh out some of the DragAndDropSimulator API for macOS, exposing (among other things) the drag pasteboard,
1386         the current NSDraggingInfo, the initial location of the drag image, and the drag image itself.
1387
1388         * TestWebKitAPI/cocoa/TestWKWebView.h:
1389         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1390         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
1391         (-[TestWKWebView mouseUpAtPoint:]):
1392         (-[TestWKWebView mouseMoveToPoint:withFlags:]):
1393         (-[TestWKWebView sendClicksAtPoint:numberOfClicks:]):
1394         (-[TestWKWebView mouseEnterAtPoint:]):
1395         (-[TestWKWebView mouseExitAtPoint:]):
1396         (-[TestWKWebView mouseDragToPoint:]):
1397         (-[TestWKWebView _mouseEventWithType:atLocation:]):
1398         (-[TestWKWebView _mouseEventWithType:atLocation:flags:timestamp:clickCount:]):
1399
1400         Add TestWKWebView helpers to send MouseMove, MouseEnter and MouseDrag NSEvents to the web view. Additionally,
1401         rename parameter names to these helpers to make it more obvious that these locations are all in NSWindow
1402         coordinates.
1403
1404         (-[TestWKWebView typeCharacter:]):
1405
1406         Drive-by style fix: put this opening brace on the beginning of the next line.
1407
1408         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1409         (-[DragAndDropSimulator initWithWebViewFrame:]):
1410         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1411         (-[DragAndDropSimulator webView]):
1412
1413         Small iOS DragAndDropSimulator adjustments for new DragAndDropSimulator interfaces.
1414
1415         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
1416         (-[DragAndDropTestWKWebView initWithFrame:configuration:simulator:]):
1417
1418         Introduce a WKWebView subclass for testing drag and drop that overrides `-dragImage:at:offset:…`, and instead
1419         allows DragAndDropSimulator to take over the drag.
1420
1421         (-[DragAndDropTestWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
1422
1423         Override this entry point into drag and drop code, and instead call out to the DragAndDropSimulator to
1424         coordinate the drag.
1425
1426         (-[DragAndDropTestWKWebView waitForPendingMouseEvents]):
1427
1428         Helper method to wait for the web process to finish handling all in-flight mouse events.
1429
1430         (defaultExternalDragImage):
1431
1432         Set this image as the default drag image when simulating an incoming drag session from outside of the web view.
1433
1434         (-[DragAndDropSimulator initWithWebViewFrame:]):
1435         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1436         (-[DragAndDropSimulator flipAboutXAxisInHostWindow:]):
1437
1438         Helper method to flip a given point about the X axis of the window.
1439
1440         (-[DragAndDropSimulator locationInViewForCurrentProgress]):
1441
1442         Map a progress value (between 0 and 1) to a drag location.
1443
1444         (-[DragAndDropSimulator initialProgressForMouseDrag]):
1445
1446         Determines the initial progress value when initiation a drag in web content. This is the initial progress
1447         required to ensure that the first mouse drag event exceeds the drag distance hysteresis and causes any drag
1448         (if applicable) to begin.
1449
1450         (-[DragAndDropSimulator runFrom:to:]):
1451         (-[DragAndDropSimulator performDragInWebView:atLocation:withImage:pasteboard:source:]):
1452
1453         Helper to coordinate drag updates in both the cases where we're simulating a drag session entering from outside
1454         of the web view, and in the case where we've initiated a drag from the web view itself.
1455
1456         (-[DragAndDropSimulator webView]):
1457         (-[DragAndDropSimulator setExternalDragPasteboard:]):
1458         (-[DragAndDropSimulator externalDragPasteboard]):
1459
1460         Just like its iOS counterpart (setExternalItemProviders:), setting an external drag pasteboard on macOS puts the
1461         DragAndDropSimulator in a mode that simulates a drag coming in from outside the web view, using the given
1462         pasteboard.
1463
1464         (-[DragAndDropSimulator setExternalDragImage:]):
1465         (-[DragAndDropSimulator externalDragImage]):
1466
1467         May be optionally set when specifying an external drag pasteboard to specify the drag image used. If no external
1468         drag image is specified, falls back to the default image returned by `defaultExternalDragImage()`.
1469
1470         (-[DragAndDropSimulator draggingInfo]):
1471         (-[DragAndDropSimulator willEndDraggingHandler]):
1472         (-[DragAndDropSimulator setWillEndDraggingHandler:]):
1473
1474         Hook to allow tests to run logic right before performing the drop (if the current drag operation is not none) or
1475         ending the drag session without performing a drag operation.
1476
1477         (-[DragAndDropSimulator initWithWebView:]): Deleted.
1478         (-[DragAndDropSimulator dealloc]): Deleted.
1479         (-[DragAndDropSimulator phase]): Deleted.
1480         * TestWebKitAPI/mac/TestDraggingInfo.h: Copied from Tools/TestWebKitAPI/mac/DragAndDropSimulatorMac.mm.
1481         * TestWebKitAPI/mac/TestDraggingInfo.mm: Added.
1482
1483         Mock object conforming to NSDraggingInfo that is passed to WKWebView when invoking -draggingUpdated:,
1484         -draggingEntered: and -draggingExited:.
1485
1486         (-[TestDraggingInfo draggingPasteboard]):
1487         (-[TestDraggingInfo setDraggingPasteboard:]):
1488         (-[TestDraggingInfo draggingSource]):
1489         (-[TestDraggingInfo setDraggingSource:]):
1490         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1491         (-[TestDraggingInfo draggingDestinationWindow]):
1492         (-[TestDraggingInfo draggedImage]):
1493         (-[TestDraggingInfo setDraggedImage:]):
1494         (-[TestDraggingInfo slideDraggedImageTo:]):
1495         (-[TestDraggingInfo namesOfPromisedFilesDroppedAtDestination:]):
1496         (-[TestDraggingInfo resetSpringLoading]):
1497
1498         Empty method stubs, to be implemented in the future as needed.
1499
1500 2018-08-13  Thomas Denney  <tdenney@apple.com>
1501
1502         Added Thomas Denney to contributors.json.
1503         https://bugs.webkit.org/show_bug.cgi?id=188525
1504
1505         Reviewed by Myles C. Maxfield.
1506
1507         * Scripts/webkitpy/common/config/contributors.json:
1508
1509 2018-08-13  Antti Koivisto  <antti@apple.com>
1510
1511         Meaning of OptionSet::contains is unclear when used with OptionSet argument
1512         https://bugs.webkit.org/show_bug.cgi?id=188501
1513
1514         Reviewed by Anders Carlsson.
1515
1516         * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
1517         (TestWebKitAPI::TEST):
1518
1519 2018-08-13  Commit Queue  <commit-queue@webkit.org>
1520
1521         Unreviewed, rolling out r234747.
1522         https://bugs.webkit.org/show_bug.cgi?id=188524
1523
1524         plugin processes crash on launch (Requested by smfr on
1525         #webkit).
1526
1527         Reverted changeset:
1528
1529         "We should cache the compiled sandbox profile in a data vault"
1530         https://bugs.webkit.org/show_bug.cgi?id=184991
1531         https://trac.webkit.org/changeset/234747
1532
1533 2018-08-13  Wenson Hsieh  <wenson_hsieh@apple.com>
1534
1535         [iOS] Dragging a non-editable text selection into a plain text input inserts HTML markup
1536         https://bugs.webkit.org/show_bug.cgi?id=188485
1537         <rdar://problem/43168784>
1538
1539         Reviewed by Tim Horton.
1540
1541         Add a new API test to verify that dropping selected non-editable rich text into a textarea inserts text as
1542         expected, rather than markup.
1543
1544         It's somewhat interesting to note that this particular use case isn't exercised by any existing tests; the
1545         closest test is DragAndDropTests.ContentEditableToTextarea, which drags a rich text selection from a
1546         contenteditable element to a text area. However, due to logic in `DragController::concludeEditDrag` that handles
1547         drag and drop across editable content differently than drag and drop from non-editable to editable content, the
1548         bug that is fixed here doesn't surface in that existing test.
1549
1550         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1551         * TestWebKitAPI/Tests/WebKitCocoa/selected-text-and-textarea.html: Added.
1552         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1553         (TestWebKitAPI::TEST):
1554
1555 2018-08-13  Alex Christensen  <achristensen@webkit.org>
1556
1557         Use a 1-byte enum class for TextDirection
1558         https://bugs.webkit.org/show_bug.cgi?id=188350
1559
1560         Reviewed by Simon Fraser.
1561
1562         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1563         (TestWebKitAPI::TEST_F):
1564         * TestWebKitAPI/Tests/WebCore/StringWithDirection.cpp:
1565         (WebCore::operator<<):
1566         (TestWebKitAPI::TEST):
1567         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
1568         (TEST_F):
1569
1570 2018-08-13  Zalan Bujtas  <zalan@apple.com>
1571
1572         [LFC][Floating] Add basic clearance support
1573         https://bugs.webkit.org/show_bug.cgi?id=188492
1574
1575         Reviewed by Antti Koivisto.
1576
1577         * LayoutReloaded/misc/LFC-passing-tests.txt:
1578
1579 2018-08-12  Zalan Bujtas  <zalan@apple.com>
1580
1581         [LFC] Float prev/next sibling should prevent top/bottom margin collapsing with parent.
1582         https://bugs.webkit.org/show_bug.cgi?id=188487
1583
1584         Reviewed by Antti Koivisto.
1585
1586         * LayoutReloaded/misc/LFC-passing-tests.txt:
1587
1588 2018-08-11  Aakash Jain  <aakash_jain@apple.com>
1589
1590         [ews-build] Separate queues for Builders and Testers - iOS
1591         https://bugs.webkit.org/show_bug.cgi?id=188396
1592
1593         Reviewed by Lucas Forschler.
1594
1595         * BuildSlaveSupport/ews-build/config.json: Splitted iOS queues into builders and testers.
1596         Also added ews121 and ews122 to match with current EWS configuration.
1597         * BuildSlaveSupport/ews-build/factories.py:
1598         (TestsFactory): Base classes for various Test factories.
1599         (TestsFactory.getProduct): Download and extract the archive.
1600
1601 2018-08-10  Daniel Bates  <dabates@apple.com>
1602
1603         webkit-patch setup-git-clone should set Git core editor to commit-log-editor
1604         https://bugs.webkit.org/show_bug.cgi?id=188473
1605
1606         Reviewed by Ryosuke Niwa.
1607
1608         Have "webkit-patch setup-git-clone" set the Git core editor to "perl Tools/Scripts/commit-log-editor --regenerate-log"
1609         so that the Git commit message is generated from the ChangeLog for developers that manually
1610         generate their ChangeLog using prepare-ChangeLog.
1611
1612         * Scripts/webkitpy/tool/commands/setupgitclone.py:
1613         (SetupGitClone.execute):
1614
1615 2018-08-10  Truitt Savell  <tsavell@apple.com>
1616
1617         Unreviewed, rolling out r234749.
1618
1619         Caused all perf tests to fail in Sierra
1620
1621         Reverted changeset:
1622
1623         "[webkitpy][Win] LayoutTests: test names should be Unix style,
1624         separated by slash not backslash"
1625         https://bugs.webkit.org/show_bug.cgi?id=187973
1626         https://trac.webkit.org/changeset/234749
1627
1628 2018-08-10  David Fenton  <david_fenton@apple.com>
1629
1630         Timeouts in TestWebKitAPI.PreferredAudioBufferSize.AudioWithWebAudio and TestWebKitAPI.PreferredAudioBufferSize.WebAudio.
1631         https://bugs.webkit.org/show_bug.cgi?id=188470.
1632
1633         Unreviewed test gardening, disabling the tests.
1634
1635         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
1636         (TEST_F):
1637
1638 2018-08-10  Joseph Pecoraro  <pecoraro@apple.com>
1639
1640         Eliminate remaining instances of "ElCapitan" from LayoutTests / Tools
1641         https://bugs.webkit.org/show_bug.cgi?id=188458
1642
1643         Reviewed by Alex Christensen.
1644
1645         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1646         (TestExpectationParser):
1647         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1648
1649 2018-08-09  Fujii Hironori  <Hironori.Fujii@sony.com>
1650
1651         [webkitpy][Win] LayoutTests: test names should be Unix style, separated by slash not backslash
1652         https://bugs.webkit.org/show_bug.cgi?id=187973
1653
1654         Reviewed by Alex Christensen.
1655
1656         In LayoutTests, test names have been canonicalized in Unix style
1657         since Bug 63597, for example 'fast/css/001.html'. But, Bug 179219,
1658         Bug 179572, Bug 180660 and Bug 181814 have changed to use
1659         os.path.seq instead of slash if Windows Python is used.
1660
1661         Revert parts of those changes. Change relative_test_filename to
1662         return a slash sperated test name as well as chromium_win.py used
1663         to do.
1664
1665         This change fixes all 41 test-webkitpy failures in WinCairo port.
1666
1667         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1668         (TestExpectationParser._parse_line): Do not convert a test name by using normpath.
1669         * Scripts/webkitpy/port/base.py:
1670         (Port.normalize_test_name): Use TEST_PATH_SEPARATOR instead of os.path.sep.
1671         (Port.relative_test_filename): Replace self.host.filesystem.sep with self.TEST_PATH_SEPARATOR.
1672         (Port.abspath_for_test): Split test_name with TEST_PATH_SEPARATOR.
1673         * Scripts/webkitpy/port/driver.py:
1674         (Driver): Use '/' instead of os.sep.
1675         * Scripts/webkitpy/port/win.py:
1676         (WinCairoPort): Do not override TEST_PATH_SEPARATOR.
1677
1678 2018-08-09  Thomas Denney  <tdenney@apple.com>
1679
1680         [WHLSL] Add individual test durations to output
1681         https://bugs.webkit.org/show_bug.cgi?id=188448
1682
1683         Reviewed by Myles C. Maxfield.
1684
1685         * WebGPUShadingLanguageRI/Test.js: Add timing output.
1686
1687 2018-08-09  Ben Richards  <benton_richards@apple.com>
1688
1689         We should cache the compiled sandbox profile in a data vault
1690         https://bugs.webkit.org/show_bug.cgi?id=184991
1691
1692         Reviewed by Ryosuke Niwa.
1693
1694         Added trace points for sandbox initialization
1695
1696         * Tracing/SystemTracePoints.plist:
1697
1698 2018-08-09  Jer Noble  <jer.noble@apple.com>
1699
1700         Video playback is using more power
1701         https://bugs.webkit.org/show_bug.cgi?id=188452
1702         <rdar://problem/42298937>
1703
1704         Reviewed by Eric Carlson.
1705
1706         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
1707         (PreferredAudioBufferSize::createView):
1708         (PreferredAudioBufferSize::preferredAudioBufferSize const):
1709         (TEST_F):
1710
1711 2018-08-09  Alex Christensen  <achristensen@webkit.org>
1712
1713         REGRESSION(234640) Loading stalls in environments without SafariSafeBrowsing framework
1714         https://bugs.webkit.org/show_bug.cgi?id=188453
1715         <rdar://problem/43102553>
1716
1717         Reviewed by Chris Dumez
1718
1719         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1720         (TEST):
1721         (+[NullLookupContext sharedLookupContext]):
1722         (TestWebKitAPI::TEST): Deleted.
1723
1724 2018-08-09  Alex Christensen  <achristensen@webkit.org>
1725
1726         WKURLSchemeHandler crashes when sent errors with sync XHR
1727         https://bugs.webkit.org/show_bug.cgi?id=188358
1728
1729         Reviewed by Chris Dumez.
1730
1731         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1732         (-[SyncErrorScheme webView:startURLSchemeTask:]):
1733         (-[SyncErrorScheme webView:stopURLSchemeTask:]):
1734         (-[SyncErrorScheme webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1735
1736 2018-08-09  Per Arne Vollan  <pvollan@apple.com>
1737
1738         REGRESSION(r234652): fast/scrolling/rtl-scrollbars-animation-property.html is failing
1739         https://bugs.webkit.org/show_bug.cgi?id=188397
1740
1741         Reviewed by Tim Horton.
1742
1743         After r234652, [NSScroller preferredScrollerStyle] is called in the UI process, and we need to set the same
1744         user defaults related to scrollbars in the UI process as we do in the WebProcess.
1745
1746         * WebKitTestRunner/mac/main.mm:
1747         (setDefaultsToConsistentValuesForTesting):
1748
1749 2018-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
1750
1751         [iOS WK2] Rename and refactor DataInteractionTests and DataInteractionSimulator
1752         https://bugs.webkit.org/show_bug.cgi?id=188439
1753
1754         Reviewed by Andy Estes and Megan Gardner.
1755
1756         Refactor DataInteractionSimulator (currently used for drag and drop testing on iOS) so that it exists across
1757         macOS and iOS, and rename it to DragAndDropSimulator. Additionally, rename DataInteractionTests to
1758         DragAndDropTests.
1759
1760         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1761         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1762         (TestWebKitAPI::TEST):
1763         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm: Renamed from Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm.
1764         (testIconImage):
1765         (testZIPArchive):
1766         (-[UIItemProvider registerDataRepresentationForTypeIdentifier:withData:]):
1767         (-[TestWKWebView editorContainsImageElement]):
1768         (-[TestWKWebView editorValue]):
1769         (makeCGRectValue):
1770         (checkCGRectIsEqualToCGRectWithLogging):
1771         (checkSelectionRectsWithLogging):
1772         (checkRichTextTypePrecedesPlainTextType):
1773         (checkFirstTypeIsPresentAndSecondTypeIsMissing):
1774         (checkTypeIdentifierIsRegisteredAtIndex):
1775         (checkEstimatedSize):
1776         (checkSuggestedNameAndEstimatedSize):
1777         (checkStringArraysAreEqual):
1778         (checkDragCaretRectIsContainedInRect):
1779         (checkJSONWithLogging):
1780         (testIconImageData):
1781         (runTestWithTemporaryTextFile):
1782         (runTestWithTemporaryFolder):
1783         (TestWebKitAPI::TEST):
1784         (TestWebKitAPI::setUpTestWebViewForDataTransferItems):
1785         (TestWebKitAPI::testDragAndDropOntoTargetElements):
1786         (TestWebKitAPI::testIconImageData):
1787         * TestWebKitAPI/cocoa/DragAndDropSimulator.h: Renamed from Tools/TestWebKitAPI/ios/DataInteractionSimulator.h.
1788         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm: Renamed from Tools/TestWebKitAPI/ios/DataInteractionSimulator.mm.
1789         (-[WKWebView dropInteractionDelegate]):
1790         (-[WKWebView dragInteractionDelegate]):
1791         (-[WKWebView dropInteraction]):
1792         (-[WKWebView dragInteraction]):
1793         (-[MockDragDropSession initWithItems:location:window:allowMove:]):
1794         (-[MockDragDropSession allowsMoveOperation]):
1795         (-[MockDragDropSession isRestrictedToDraggingApplication]):
1796         (-[MockDragDropSession hasItemsConformingToTypeIdentifiers:]):
1797         (-[MockDragDropSession canLoadObjectsOfClass:]):
1798         (-[MockDragDropSession canLoadObjectsOfClasses:]):
1799         (-[MockDragDropSession items]):
1800         (-[MockDragDropSession setItems:]):
1801         (-[MockDragDropSession addItems:]):
1802         (-[MockDragDropSession locationInView:]):
1803         (-[MockDropSession initWithProviders:location:window:allowMove:]):
1804         (-[MockDropSession isLocal]):
1805         (-[MockDropSession progress]):
1806         (-[MockDropSession setProgressIndicatorStyle:]):
1807         (-[MockDropSession progressIndicatorStyle]):
1808         (-[MockDropSession operationMask]):
1809         (-[MockDropSession localDragSession]):
1810         (-[MockDropSession hasItemsConformingToTypeIdentifier:]):
1811         (-[MockDropSession canCreateItemsOfClass:]):
1812         (-[MockDropSession loadObjectsOfClass:completion:]):
1813         (-[MockDragSession initWithWindow:allowMove:]):
1814         (-[MockDragSession localOperationMask]):
1815         (-[MockDragSession externalOperationMask]):
1816         (-[MockDragSession session]):
1817         (-[MockDragSession localContext]):
1818         (-[MockDragSession setLocalContext:]):
1819         (dragAndDropEventNames):
1820         (-[DragAndDropSimulatorApplication _cancelAllTouches]):
1821         (-[DragAndDropSimulator initWithWebView:]):
1822         (-[DragAndDropSimulator dealloc]):
1823         (-[DragAndDropSimulator _resetSimulatedState]):
1824         (-[DragAndDropSimulator observedEventNames]):
1825         (-[DragAndDropSimulator simulateAllTouchesCanceled:]):
1826         (-[DragAndDropSimulator runFrom:to:]):
1827         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
1828         (-[DragAndDropSimulator finalSelectionRects]):
1829         (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
1830         (-[DragAndDropSimulator _enqueuePendingAdditionalItemRequestLocations]):
1831         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1832         (-[DragAndDropSimulator _advanceProgress]):
1833         (-[DragAndDropSimulator _currentLocation]):
1834         (-[DragAndDropSimulator _scheduleAdvanceProgress]):
1835         (-[DragAndDropSimulator sourceItemProviders]):
1836         (-[DragAndDropSimulator externalItemProviders]):
1837         (-[DragAndDropSimulator setExternalItemProviders:]):
1838         (-[DragAndDropSimulator phase]):
1839         (-[DragAndDropSimulator liftPreviews]):
1840         (-[DragAndDropSimulator lastKnownDragCaretRect]):
1841         (-[DragAndDropSimulator waitForInputSession]):
1842         (-[DragAndDropSimulator insertedAttachments]):
1843         (-[DragAndDropSimulator removedAttachments]):
1844         (-[DragAndDropSimulator endDataTransfer]):
1845         (-[DragAndDropSimulator _webView:dataInteractionOperationWasHandled:forSession:itemProviders:]):
1846         (-[DragAndDropSimulator _webView:willUpdateDataInteractionOperationToOperation:forSession:]):
1847         (-[DragAndDropSimulator _webView:adjustedDataInteractionItemProvidersForItemProvider:representingObjects:additionalData:]):
1848         (-[DragAndDropSimulator _webView:showCustomSheetForElement:]):
1849         (-[DragAndDropSimulator _webView:willPerformDropWithSession:]):
1850         (-[DragAndDropSimulator _webView:didInsertAttachment:]):
1851         (-[DragAndDropSimulator _webView:didRemoveAttachment:]):
1852         (-[DragAndDropSimulator _webView:focusShouldStartInputSession:]):
1853         (-[DragAndDropSimulator _webView:didStartInputSession:]):
1854         * TestWebKitAPI/ios/UIKitSPI.h:
1855         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm: Added.
1856         (-[DragAndDropSimulator initWithWebView:]):
1857         (-[DragAndDropSimulator dealloc]):
1858         (-[DragAndDropSimulator runFrom:to:]):
1859         (-[DragAndDropSimulator insertedAttachments]):
1860         (-[DragAndDropSimulator removedAttachments]):
1861
1862 2018-08-09  Sihui Liu  <sihui_liu@apple.com>
1863
1864         REGRESSION (r232083): WKWebView loses first-party cookies on iOS
1865         https://bugs.webkit.org/show_bug.cgi?id=188443
1866         <rdar://problem/42991584>
1867
1868         Reviewed by Chris Dumez.
1869
1870         Skip WebKit.WKHTTPCookieStoreWithoutProcessPool on iOS.
1871
1872         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1873
1874 2018-08-09  Ross Kirsling  <ross.kirsling@sony.com>
1875
1876         Unreviewed follow-up fix for r234720.
1877
1878         * Scripts/webkitpy/bindings/main.py:
1879         (BindingsTests.close_and_remove):
1880         (BindingsTests.main):
1881         Return to the original approach, since this seems to be the simplest cross-platform solution.
1882
1883 2018-08-09  Ali Juma  <ajuma@chromium.org>
1884
1885         Import WPTs for IntersectionObserver
1886         https://bugs.webkit.org/show_bug.cgi?id=188416
1887
1888         Reviewed by Simon Fraser.
1889
1890         Enable IntersectionObserver in DumpRenderTree. 
1891
1892         * DumpRenderTree/mac/DumpRenderTree.mm:
1893         (enableExperimentalFeatures):
1894         (setWebPreferencesForTestOptions):
1895         * WebKitTestRunner/TestController.cpp:
1896         (WTR::TestController::resetPreferencesToConsistentValues):
1897
1898 2018-08-08  Ross Kirsling  <ross.kirsling@sony.com>
1899
1900         run-bindings-tests is not Win32-compatible
1901         https://bugs.webkit.org/show_bug.cgi?id=188424
1902
1903         Reviewed by Fujii Hironori.
1904
1905         * Scripts/webkitpy/bindings/main.py:
1906         (BindingsTests.main):
1907         Stop leaking file descriptors.
1908         (See https://www.logilab.org/blogentry/17873 for details, though the solution here is even simpler.)
1909
1910 2018-08-08  Alex Christensen  <achristensen@webkit.org>
1911
1912         Fix possible null dereference in WebBackForwardList::restoreFromState
1913         https://bugs.webkit.org/show_bug.cgi?id=188418
1914         <rdar://problem/42531726>
1915
1916         Reviewed by Chris Dumez.
1917
1918         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
1919         (TestWebKitAPI::TEST):
1920
1921 2018-08-08  Ross Kirsling  <ross.kirsling@sony.com>
1922
1923         run-builtins-generator-tests does not correctly handle CRLFs from stderr
1924         https://bugs.webkit.org/show_bug.cgi?id=188392
1925
1926         Reviewed by Fujii Hironori.
1927
1928         Background:
1929         file.write converts LF to os.linesep, so if the input string contains CRLF, we end up writing CRCRLF to the file.
1930
1931         * Scripts/webkitpy/common/system/executive.py:
1932         (Executive.run_command):
1933         Normalize CRLF to LF in decoded stdout/stderr data, so that we don't return consumers a platform-specific string.
1934
1935 2018-08-08  Aditya Keerthi  <akeerthi@apple.com>
1936
1937         Unreviewed, add myself to committers list.
1938
1939         * Scripts/webkitpy/common/config/contributors.json:
1940
1941 2018-08-08  Commit Queue  <commit-queue@webkit.org>
1942
1943         Unreviewed, rolling out r234314, r234320, and r234321.
1944         https://bugs.webkit.org/show_bug.cgi?id=188414
1945
1946         Caused email sign in issue (Requested by ryanhaddad on
1947         #webkit).
1948
1949         Reverted changesets:
1950
1951         "Remove unused WKNavigationDelegatePrivate
1952         decidePolicyForNavigationAction SPI"
1953         https://bugs.webkit.org/show_bug.cgi?id=188077
1954         https://trac.webkit.org/changeset/234314
1955
1956         "Fix API tests after r234314"
1957         https://bugs.webkit.org/show_bug.cgi?id=188077
1958         https://trac.webkit.org/changeset/234320
1959
1960         "Fix API tests after r234314"
1961         https://bugs.webkit.org/show_bug.cgi?id=188077
1962         https://trac.webkit.org/changeset/234321
1963
1964 2018-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1965
1966         [iOS] fast/events/ios/contenteditable-autocapitalize.html is a flaky failure
1967         https://bugs.webkit.org/show_bug.cgi?id=188401
1968         <rdar://problem/32542300>
1969
1970         Reviewed by Ryosuke Niwa.
1971
1972         When run individually, fast/events/ios/contenteditable-autocapitalize.html passes consistently; however, when
1973         run right after another layout test that finishes while the keyboard is shown, this test sometimes fails. This
1974         is because each of the three steps of this test ends when UIScriptController's `didHideKeyboardCallback` is
1975         invoked, and if the keyboard only begins to dismiss after the previous test completes, we have a race. When the
1976         keyboard finishes dismissing after the UI script is evaluated, it will trigger UI script completion early and
1977         skip over one of the steps in the layout test, resulting in a text diff failure.
1978
1979         To fix this, add a mechanism in WebKitTestRunner to wait until the keyboard is dismissed (with a short timeout)
1980         as a part of resetting test controller state, before moving on to the next layout test.
1981
1982         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1983         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1984         (-[TestRunnerWKWebView didStartFormControlInteraction]):
1985         (-[TestRunnerWKWebView didEndFormControlInteraction]):
1986
1987         Use these hooks to keep track of whether the previous test is presenting any form input UI.
1988
1989         (-[TestRunnerWKWebView isInteractingWithFormControl]):
1990         * WebKitTestRunner/ios/TestControllerIOS.mm:
1991         (WTR::handleKeyboardWillHideNotification):
1992         (WTR::handleKeyboardDidHideNotification):
1993         (WTR::TestController::platformInitialize):
1994         (WTR::TestController::platformDestroy):
1995
1996         Register during initialization (and unregister during teardown) for keyboard hiding notifications, to keep track
1997         of when the keyboard dismissal animation ends.
1998
1999         (WTR::TestController::platformResetStateToConsistentValues):
2000
2001         Make a couple of tweaks here: (1) if form input UI is being shown, tell the web view to resign first responder,
2002         which causes the field to lose focus. (2) If necessary, wait for the current keyboard dismissal animation to
2003         finish. This includes any keyboard dismissal animations triggered as a result of step (1).
2004
2005 2018-08-05  Darin Adler  <darin@apple.com>
2006
2007         [Cocoa] More tweaks and refactoring to prepare for ARC
2008         https://bugs.webkit.org/show_bug.cgi?id=188245
2009
2010         Reviewed by Dan Bernstein.
2011
2012         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Use const void* for a
2013         CFTypeRef instead of void*.
2014
2015         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
2016         (createCoreAnimationLayer): Use CFBridgingRetain.
2017
2018         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2019         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker): Use bridging casts.
2020         (AccessibilityUIElement::textMarkerRangeForElement): Ditto.
2021         (AccessibilityUIElement::selectedTextMarkerRange): Ditto.
2022         (AccessibilityUIElement::textMarkerRangeLength): Ditto.
2023         (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute): Ditto.
2024         (AccessibilityUIElement::indexForTextMarker): Ditto.
2025         (AccessibilityUIElement::textMarkerForIndex): Ditto.
2026         (AccessibilityUIElement::isTextMarkerValid): Ditto.
2027         (AccessibilityUIElement::previousTextMarker): Ditto.
2028         (AccessibilityUIElement::nextTextMarker): Ditto.
2029         (AccessibilityUIElement::stringForTextMarkerRange): Ditto.
2030         (createJSStringRef): Ditto.
2031         (AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
2032         (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
2033         (AccessibilityUIElement::textMarkerRangeForMarkers): Ditto.
2034         (AccessibilityUIElement::startTextMarkerForTextMarkerRange): Ditto.
2035         (AccessibilityUIElement::endTextMarkerForTextMarkerRange): Ditto.
2036         (AccessibilityUIElement::endTextMarkerForBounds): Ditto.
2037         (AccessibilityUIElement::startTextMarkerForBounds): Ditto.
2038         (AccessibilityUIElement::textMarkerForPoint): Ditto.
2039         (AccessibilityUIElement::accessibilityElementForTextMarker): Ditto.
2040         (AccessibilityUIElement::startTextMarker): Ditto.
2041         (AccessibilityUIElement::endTextMarker): Ditto.
2042         (AccessibilityUIElement::setSelectedVisibleTextRange): Ditto.
2043         (AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker): Ditto.
2044         (AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker): Ditto.
2045         (AccessibilityUIElement::previousWordStartTextMarkerForTextMarker): Ditto.
2046         (AccessibilityUIElement::nextWordEndTextMarkerForTextMarker): Ditto.
2047         (AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker): Ditto.
2048         (AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker): Ditto.
2049         (AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker): Ditto.
2050         (AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker): Ditto.
2051         (AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker): Ditto.
2052         (AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker): Ditto.
2053
2054         * DumpRenderTree/mac/DumpRenderTree.mm:
2055         (resetWebPreferencesToConsistentValues): Use bridging cast.
2056         (dumpFramesAsText): Ditto.
2057         (dumpBackForwardListForAllWindows): Use a modern for loop instead of
2058         CFArray functions to iterate the array.
2059         (dump): Use bridging cast.
2060         (runTest): Ditto.
2061
2062         * DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
2063         (+[LocalPasteboard alloc]): Use class_createInstance instead of NSAllocateObject.
2064         (toUTI): Return a RetainPtr<CFStringRef>.
2065         (-[LocalPasteboard types]): Use the above and bridging casts.
2066         (-[LocalPasteboard availableTypeFromArray:]): Ditto.
2067         (-[LocalPasteboard setData:forType:]): Ditto.
2068         (-[LocalPasteboard dataForType:]): Ditto.
2069         (-[LocalPasteboard setPropertyList:forType:]): Use NSPropertyListSerialization
2070         instead of CFPropertyList.
2071         (-[LocalPasteboard setString:forType:]): Use NSString method instead of
2072         CFStringCreateExternalRepresentation.
2073
2074         * DumpRenderTree/mac/MockGeolocationProvider.h: Put CFTypeRef in a HashSet
2075         instead of an Objective-C object pointer type.
2076         * DumpRenderTree/mac/MockGeolocationProvider.mm:
2077         (-[MockGeolocationProvider registerWebView:]): Update for above.
2078         (-[MockGeolocationProvider unregisterWebView:]): Ditto.
2079         (-[MockGeolocationProvider timerFired]): Ditto.
2080
2081         * DumpRenderTree/mac/MockWebNotificationProvider.h: Use CFTypeRef in
2082         HashMap and HashSet instead of an Objective-C object pointer type.
2083         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
2084         (-[MockWebNotificationProvider registerWebView:]): Update for above.
2085         (-[MockWebNotificationProvider unregisterWebView:]): Ditto.
2086         (-[MockWebNotificationProvider showNotification:fromWebView:]): Ditto.
2087         (-[MockWebNotificationProvider cancelNotification:]): Ditto.
2088         (-[MockWebNotificationProvider simulateWebNotificationClick:]): Ditto.
2089
2090         * DumpRenderTree/mac/ObjCPlugin.m:
2091         (-[JSObjC retainObject:]): Use CFRetain instead of -[NSObject retain].
2092
2093         * DumpRenderTree/mac/TestRunnerMac.mm:
2094         (TestRunner::addDisallowedURL): Use bridging cast.
2095         (TestRunner::applicationCacheDiskUsageForOrigin): Ditto.
2096         (TestRunner::clearApplicationCacheForOrigin): Ditto.
2097         (originsArrayToJS): Ditto.
2098         (TestRunner::copyDecodedHostName): Ditto.
2099         (TestRunner::copyEncodedHostName): Ditto.
2100         (TestRunner::queueLoad): Ditto.
2101         (TestRunner::setDomainRelaxationForbiddenForURLScheme): Ditto.
2102         (TestRunner::setMockGeolocationPositionUnavailableError): Ditto.
2103         (TestRunner::setUserStyleSheetLocation): Ditto.
2104         (TestRunner::setValueForUser): Ditto.
2105         (TestRunner::overridePreference): Ditto.
2106         (TestRunner::execCommand): Ditto.
2107         (TestRunner::findString): Ditto.
2108         (TestRunner::isCommandEnabled): Ditto.
2109         (TestRunner::addOriginAccessWhitelistEntry): Ditto.
2110         (TestRunner::removeOriginAccessWhitelistEntry): Ditto.
2111         (TestRunner::addUserScript): Ditto.
2112         (TestRunner::addUserStyleSheet): Ditto.
2113         (TestRunner::evaluateInWebInspector): Ditto.
2114         (TestRunner::evaluateScriptInIsolatedWorld): Ditto.
2115         (TestRunner::authenticateSession): Ditto.
2116         (TestRunner::grantWebNotificationPermission): Ditto.
2117         (TestRunner::denyWebNotificationPermission): Ditto.
2118         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
2119         (-[LayoutTestSpellChecker setResultsFromJSObject:inContext:]): Ditto.
2120
2121         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2122         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker): Use bridging cast.
2123         (WTR::AccessibilityUIElement::textMarkerRangeForElement): Ditto.
2124         (WTR::AccessibilityUIElement::previousTextMarker): Ditto.
2125         (WTR::AccessibilityUIElement::nextTextMarker): Ditto.
2126         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers): Ditto.
2127         (WTR::AccessibilityUIElement::selectedTextMarkerRange): Ditto.
2128         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange): Ditto.
2129         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange): Ditto.
2130         (WTR::AccessibilityUIElement::endTextMarkerForBounds): Ditto.
2131         (WTR::AccessibilityUIElement::startTextMarkerForBounds): Ditto.
2132         (WTR::AccessibilityUIElement::textMarkerForPoint): Ditto.
2133         (WTR::AccessibilityUIElement::textMarkerForIndex): Ditto.
2134         (WTR::AccessibilityUIElement::startTextMarker): Ditto.
2135         (WTR::AccessibilityUIElement::endTextMarker): Ditto.
2136         (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker): Ditto.
2137         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker): Ditto.
2138         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker): Ditto.
2139         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker): Ditto.
2140         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker): Ditto.
2141         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker): Ditto.
2142         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker): Ditto.
2143         (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker): Ditto.
2144         (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker): Ditto.
2145         (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker): Ditto.
2146
2147         * WebKitTestRunner/PlatformMac.cmake: Added WebKitTestRunnerWindow.h and .mm files.
2148         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Ditto.
2149
2150         * WebKitTestRunner/mac/EventSenderProxy.mm: Add include of WebKitTestRunnerWindow.h
2151         so we can use the type and know it inherits from NSWindow.
2152
2153         * WebKitTestRunner/mac/PlatformWebViewMac.mm: Add include of WebKitTestRunnerWindow.h
2154         so we can use the type and know it inherits from NSWindow. Moved WebKitTestRunnerWindow
2155         class into a separate file.
2156         (WTR::PlatformWebView::keyWindow): Call +[WebKitTestRunnerWindow _WTR_keyWindow]
2157         instead of have a second copy of the implementation.
2158
2159         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm: Add include of WebKitTestRunnerWindow.h
2160         so we can use the type and know it inherits from NSWindow. Also removed "using namespace".
2161         (+[WebKitTestRunnerEvent mouseLocation]): Updated for above.
2162
2163         * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm:
2164         (+[LocalPasteboard alloc]): Use class_createInstance instead of NSAllocateObject.
2165         (-[LocalPasteboard availableTypeFromArray:]): Use modern for loop.
2166         (-[LocalPasteboard setData:forType:]): Reordered method to be a tiny bit more efficient.
2167         (-[LocalPasteboard setPropertyList:forType:]): Use NSPropertyListSerialization
2168         instead of CFPropertyList.
2169         (-[LocalPasteboard setString:forType:]): Use NSString method instead of
2170         CFStringCreateExternalRepresentation.
2171
2172         * WebKitTestRunner/mac/WebKitTestRunnerWindow.h: Moved declaration of
2173         WebKitTestRunnerWindow here so it can be included by files that need to know
2174         what the type is and that it inherits from NSWindow.
2175
2176         * WebKitTestRunner/mac/WebKitTestRunnerWindow.mm: Added. Moved implementation here.
2177         (+[WebKitTestRunnerWindow _WTR_keyWindow]): Use modern for loop instead of the old,
2178         messier implementation.
2179
2180 2018-08-07  Alex Christensen  <achristensen@webkit.org>
2181
2182         Add a test for using SafeBrowsing
2183         https://bugs.webkit.org/show_bug.cgi?id=188290
2184
2185         Reviewed by Chris Dumez.
2186
2187         Swizzle out SSBLookupContext to write tests for how WebKit responds when it responds in different ways.
2188         We don't do anything with its results in WebKit yet, but when we do I'll add the expected behavior to this test.
2189
2190         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2191         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm: Added.
2192         (-[SafeBrowsingDelegate webView:didFinishNavigation:]):
2193         (TestWebKitAPI::TEST):
2194
2195 2018-08-07  Lucas Forschler  <lforschler@apple.com>
2196
2197         If there's a Radar in the ChangeLog, webkit-patch upload/create-bug should put the radar in the bug and set InRadar
2198         https://bugs.webkit.org/show_bug.cgi?id=188235
2199
2200         Reviewed by Daniel Bates, Kocsen Chung, and Aakash Jain.
2201
2202         * Scripts/webkitpy/common/checkout/changelog.py: 
2203         (ChangeLogEntry): Teach the ChangeLog tools how to parse a radar_id
2204         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Test out the new _parse_radar_id functionality
2205         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2206         (Bugzilla.add_keyword_to_bug): Add logic to add keywords using the changeform
2207         * Scripts/webkitpy/tool/commands/upload.py:
2208         (Upload): Teach the upload step how to add radar information when creating a new bug.
2209         * Scripts/webkitpy/tool/steps/__init__.py:
2210         * Scripts/webkitpy/tool/steps/addradar.py: Added.
2211         (AddRadar):
2212         (AddRadar.run): Contains the logic to add the radar information to bugzilla.
2213         * Scripts/webkitpy/tool/steps/createbug.py:
2214         (CreateBug.run): set a "created_new_bug" state when creating a new bugzilla bug.
2215
2216 2018-08-07  Wenson Hsieh  <wenson_hsieh@apple.com>
2217
2218         Post-review feedback after r234614.
2219         https://bugs.webkit.org/show_bug.cgi?id=188322
2220         <rdar://problem/42455270>
2221
2222         Reviewed by Sam Weinig.
2223
2224         Use std::round instead of roundl — there's no reason to go from double to long double precision when rounding.
2225
2226         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2227         (rounded):
2228
2229 2018-08-07  Don Olmstead  <don.olmstead@sony.com>
2230
2231         [MiniBrowser][Win] Allow selection of recent user agents
2232         https://bugs.webkit.org/show_bug.cgi?id=188371
2233
2234         Reviewed by Fujii Hironori.
2235
2236         Updates the user agent spoofing strings to the latest released
2237         versions and adds Microsoft Edge's user agent.
2238
2239         Moves the menu item selection to the common base class, BrowserWindow
2240         to support user agent spoofing in a WebKitLegacyBrowserWindow and
2241         WebKitBrowserWindow.
2242
2243         * MiniBrowser/win/BrowserWindow.cpp: Added.
2244         (BrowserWindow::setUserAgent):
2245         * MiniBrowser/win/BrowserWindow.h:
2246         * MiniBrowser/win/CMakeLists.txt:
2247         * MiniBrowser/win/MainWindow.cpp:
2248         (MainWindow::toggleMenuItem):
2249         * MiniBrowser/win/MiniBrowserLib.rc:
2250         * MiniBrowser/win/MiniBrowserLibResource.h:
2251         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2252         * MiniBrowser/win/WebKitBrowserWindow.h:
2253         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2254         (WebKitLegacyBrowserWindow::setUserAgent):
2255         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
2256
2257 2018-08-07  Yusuke Suzuki  <utatane.tea@gmail.com>
2258
2259         Unreviewed, add a new address to my configuration
2260
2261         * Scripts/webkitpy/common/config/contributors.json:
2262
2263 2018-08-06  David Quesada  <david_quesada@apple.com>
2264
2265         webkitdirs.pm should default to iPhone SE for 64-bit testing
2266         https://bugs.webkit.org/show_bug.cgi?id=188361
2267
2268         Reviewed by Daniel Bates.
2269
2270         Use iPhone SE as the default iOS Simulator device type. This corresponds to the change to webkitpy in r234467.
2271
2272         * Scripts/webkitdirs.pm:
2273         (findOrCreateSimulatorForIOSDevice):
2274         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2275         (parse_args):
2276             Update the help text for --device-type to reflect the new default device.
2277
2278 2018-08-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2279
2280         [iOS] Caret disappears after resigning and becoming first responder if active focus state is retained
2281         https://bugs.webkit.org/show_bug.cgi?id=188322
2282         <rdar://problem/42455270>
2283
2284         Reviewed by Tim Horton.
2285
2286         Fixes an API test added in r234600, which had incorrect test expectations — namely, the width of the caret rect
2287         was not in content view coordinates, unlike the x, y, and height.
2288
2289         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2290         (rounded):
2291         (-[TestWKWebView waitForCaretViewFrameToBecome:]):
2292         (-[TestWKWebView waitForSelectionViewRectsToBecome:]):
2293         (TestWebKitAPI::TEST):
2294
2295 2018-08-06  Ryan Haddad  <ryanhaddad@apple.com>
2296
2297         Unreviewed, rolling out r234569.
2298
2299         Breaks internal builds.
2300
2301         Reverted changeset:
2302
2303         "We should cache the compiled sandbox profile in a data vault"
2304         https://bugs.webkit.org/show_bug.cgi?id=184991
2305         https://trac.webkit.org/changeset/234569
2306
2307 2018-08-06  Fujii Hironori  <Hironori.Fujii@sony.com>
2308
2309         [Win][DLLLauncher] Remove --highDPI switch
2310         https://bugs.webkit.org/show_bug.cgi?id=188255
2311
2312         Reviewed by Yusuke Suzuki.
2313
2314         Bug 149417 has added `--highDPI` switch to make MiniBrowser DPI
2315         aware. But, Bug 158733 has made MiniBrowser always DPI aware. It
2316         became useless since the change. Remove the switch.
2317
2318         This change fixes the issue all dump render tree tests are failing
2319         in WinCairo port if high DPI display is connected.
2320
2321         * MiniBrowser/win/Common.cpp:
2322         (parseCommandLine): Removed `--highDPI` switch.
2323         * win/DLLLauncher/DLLLauncherMain.cpp:
2324         (wWinMain): Do not call SetProcessDPIAware.
2325         (shouldUseHighDPI): Deleted.
2326
2327 2018-08-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2328
2329         [iOS] Tests that try to interact with the QuickType bar time out on iOS 11+
2330         https://bugs.webkit.org/show_bug.cgi?id=188335
2331         <rdar://problem/32542437> and <rdar://problem/32542433>
2332
2333         Reviewed by Tim Horton.
2334
2335         Remove a UIScriptController helper method that attempted to wait for QuickType buttons to appear, and then send
2336         touch events to the buttons. These were only used for the two tests which this patch refactors. See the
2337         LayoutTests ChangeLog for more detail.
2338
2339         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2340         (WTR::UIScriptController::selectTextCandidateAtIndex): Deleted.
2341         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2342         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2343         (WTR::UIScriptController::selectTextCandidateAtIndex): Deleted.
2344         (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex): Deleted.
2345         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2346         * TestRunnerShared/spi/UIKitTestSPI.h:
2347
2348         Remove an internal class declaration that is now unnecessary.
2349
2350         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2351         (WTR::UIScriptController::selectTextCandidateAtIndex): Deleted.
2352         (WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex): Deleted.
2353
2354 2018-08-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2355
2356         [iOS] Caret disappears after resigning and becoming first responder if active focus state is retained
2357         https://bugs.webkit.org/show_bug.cgi?id=188322
2358         <rdar://problem/42455270>
2359
2360         Reviewed by Tim Horton.
2361
2362         Adds plumbing in UIScriptController to grab the start and end selection handle rects for use in the new layout
2363         test. Also adds new API tests to verify that when a web view resigns first responder, both caret and range
2364         selection views are hidden, and when first responder status is restored, both caret and range selection views
2365         are made visible again.
2366
2367         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2368         (WTR::UIScriptController::selectionStartGrabberViewRect const):
2369         (WTR::UIScriptController::selectionEndGrabberViewRect const):
2370         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2371         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2372         (WTR::UIScriptController::selectionStartGrabberViewRect const):
2373         (WTR::UIScriptController::selectionEndGrabberViewRect const):
2374         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2375         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2376         (-[TestWKWebView waitForCaretViewFrameToBecome:]):
2377         (-[TestWKWebView waitForSelectionViewRectsToBecome:]):
2378         (webViewWithAutofocusedInput):
2379
2380         Pull out some common logic for creating a web view that allows programmatic focus to present the keyboard, and
2381         immediately loading a web page with an autofocusing text field.
2382
2383         (TestWebKitAPI::TEST):
2384         * TestWebKitAPI/cocoa/TestWKWebView.h:
2385         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2386         (-[TestWKWebView caretViewRectInContentCoordinates]):
2387         (-[TestWKWebView selectionViewRectsInContentCoordinates]):
2388         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2389         (WTR::UIScriptController::selectionStartGrabberViewRect const):
2390         (WTR::UIScriptController::selectionEndGrabberViewRect const):
2391
2392 2018-08-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2393
2394         [iOS] Layout tests that send HID events cause WebKitTestRunner to crash on recent SDKs
2395         https://bugs.webkit.org/show_bug.cgi?id=188334
2396         <rdar://problem/40630074>
2397
2398         Reviewed by Tim Horton.
2399
2400         To mark the end of previously dispatched IOHID events, HIDEventGenerator currently sends a vendor-defined event
2401         and stores the completion callback ID for the previously dispatched events as vendor-defined data. When this
2402         vendor-defined marker event is handled by the application, we then read the callback ID back from the event, map
2403         it to a completion block, and invoke the completion block to signal that the previous HID event has been
2404         processed.
2405
2406         This callback ID is an unsigned, so we tell IOKit that we need `sizeof(unsigned)` (4 bytes) to store it. On
2407         shipping software, IOKit clamps this to a minimum of 8 bytes, i.e. `sizeof(CFIndex)`. When we later call
2408         IOHIDEventGetIntegerValue to read the value of our vendor-defined data as a CFIndex, we get our expected
2409         callback ID because the buffer was clamped to 8 bytes.
2410
2411         However, on recent iOS SDKs that contain the fix for <rdar://problem/20082284>, IOKit no longer clamps the size
2412         of the vendor-defined data buffer to 8 bytes. This means that when we try to use IOHIDEventGetIntegerValue to
2413         read our callback ID back, we end up getting a CFIndex where the lower 4 bytes are the callback ID we wrote, and
2414         the upper 4 bytes are garbage. In the case where any of these upper 4 bytes are non-zero, we fail to map the
2415         callback ID to a completion handler, and so we never finish dispatching the HID event, causing an exception to
2416         be thrown.
2417
2418         To fix this, we adjust callback ID to be a CFIndex, which matches IOHIDEventGetIntegerValue's return type.
2419
2420         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2421         (+[HIDEventGenerator nextEventCallbackID]):
2422         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
2423
2424         Also refactor a bit of `-_sendMarkerHIDEventWithCompletionBlock:` by using auto and move semantics.
2425
2426 2018-08-03  Ben Richards  <benton_richards@apple.com>
2427
2428         We should cache the compiled sandbox profile in a data vault
2429         https://bugs.webkit.org/show_bug.cgi?id=184991
2430
2431         Reviewed by Ryosuke Niwa.
2432
2433         Added trace points for sandbox initialization
2434
2435         * Tracing/SystemTracePoints.plist:
2436
2437 2018-08-03  David Fenton  <david_fenton@apple.com>
2438
2439         Unreviewed, rolling out r234517.
2440
2441         Caused API test failures on iOS
2442
2443         Reverted changeset:
2444
2445         "[Cocoa] setCookie API fails to set session cookies for
2446         defaultDataStore if processPool created but not used"
2447         https://bugs.webkit.org/show_bug.cgi?id=188209
2448         https://trac.webkit.org/changeset/234517
2449
2450 2018-08-03  Ben Richards  <benton_richards@apple.com>
2451
2452         Add configuration for automatic process pre-warming
2453         https://bugs.webkit.org/show_bug.cgi?id=187108
2454
2455         Reviewed by Ryosuke Niwa.
2456
2457         Added new test case for setting maximum prewarmed process count and updated test case for process swap on navigation to set the maximum prewarmed process count to be 1 where relevant.
2458
2459         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2460         * TestWebKitAPI/Tests/WebKitCocoa/InitialWarmedProcessUsed.mm:
2461         (TEST):
2462         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2463         * TestWebKitAPI/Tests/WebKitCocoa/SetMaximumPrewarmedProcessCount.mm:
2464         (TEST):
2465
2466 2018-08-03  Aakash Jain  <aakash_jain@apple.com>
2467
2468         [ews-build] Add build step to Check Patch Relevance
2469         https://bugs.webkit.org/show_bug.cgi?id=188295
2470
2471         Reviewed by Lucas Forschler.
2472
2473         * BuildSlaveSupport/ews-build/steps.py:
2474         (CheckPatchRelevance): Added step to check patch relevance.
2475         (CheckPatchRelevance._patch_is_relevant): Checks if the patch is relevant.
2476         (CheckPatchRelevance._get_patch): Retrieves the patch from buildbot.
2477         (CheckPatchRelevance._addToLog): Add the log message.
2478         (CheckPatchRelevance.start):
2479         * BuildSlaveSupport/ews-build/factories.py: Added CheckPatchRelevance step appropriately.
2480
2481 2018-08-03  Jer Noble  <jer.noble@apple.com>
2482
2483         Unreviewed gardening; r234534 changed the policy for what audio session is set when a
2484         media element is paused. Updating the test to reflect the new policy.
2485
2486         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
2487         (TestWebKitAPI::TEST):
2488
2489 2018-08-03  Zalan Bujtas  <zalan@apple.com>
2490
2491         [LFC][Floating] Now that the document renderer belongs to "complicated cases", adjust viewport stretching.
2492         https://bugs.webkit.org/show_bug.cgi?id=188306
2493
2494         Reviewed by Antti Koivisto.
2495
2496         * LayoutReloaded/misc/LFC-passing-tests.txt:
2497
2498 2018-08-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2499
2500         [WPE] Use the new key mapper API from WPEBackend
2501         https://bugs.webkit.org/show_bug.cgi?id=188216
2502
2503         Reviewed by Žan Doberšek.
2504
2505         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2506         (WTR::EventSenderProxy::keyDown): Use wpe_input_xkb_context_get_entries_for_key_code() to get the hardware key
2507         code.
2508         * wpe/backends/WindowViewBackend.cpp:
2509         (WPEToolingBackends::WindowViewBackend::WindowViewBackend):
2510         (WPEToolingBackends::WindowViewBackend::handleKeyEvent):
2511         (WPEToolingBackends::WindowViewBackend::modifiers const):
2512         * wpe/backends/WindowViewBackend.h:
2513
2514 2018-08-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2515
2516         [WPE] Implement MouseEvent.buttons
2517         https://bugs.webkit.org/show_bug.cgi?id=187998
2518
2519         Reviewed by Žan Doberšek.
2520
2521         Pass modifiers to mouse events.
2522
2523         * WebKitTestRunner/EventSenderProxy.h:
2524         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2525         (WTR::senderButtonToWPEButton):
2526         (WTR::modifierForButton):
2527         (WTR::EventSenderProxy::mouseDown):
2528         (WTR::EventSenderProxy::mouseUp):
2529         (WTR::EventSenderProxy::mouseMoveTo):
2530         (WTR::EventSenderProxy::mouseScrollBy):
2531         (WTR::wkEventModifiersToWPE):
2532         (WTR::wpeKeySymForKeyRef):
2533         (WTR::EventSenderProxy::keyDown):
2534         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
2535         * wpe/backends/WindowViewBackend.cpp:
2536         (WPEToolingBackends::WindowViewBackend::handleKeyEvent):
2537         (WPEToolingBackends::WindowViewBackend::modifiers const):
2538         * wpe/backends/WindowViewBackend.h:
2539
2540 2018-08-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2541
2542         [WPE] Use WPE key symbols and new API instead of xkbcommon and the key mapper
2543         https://bugs.webkit.org/show_bug.cgi?id=188093
2544
2545         Reviewed by Žan Doberšek.
2546
2547         * MiniBrowser/wpe/main.cpp: Use WPE key symbols.
2548         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2549         (WTR::wpeKeySymForKeyRef): Use WPE key symbols and wpe_unicode_to_key_code().
2550         (WTR::EventSenderProxy::keyDown): Do not set unicode char to the event since it was removed.
2551         * flatpak/org.webkit.WPE.yaml: Bump WPEBackend and WPEBackend-fdo versions.
2552         * wpe/backends/WindowViewBackend.cpp:
2553         (WPEToolingBackends::WindowViewBackend::handleKeyEvent): Do not set unicode char to the event since it was removed.
2554         * wpe/jhbuild.modules: Bump WPEBackend and WPEBackend-fdo versions.
2555
2556 2018-08-02  Nan Wang  <n_wang@apple.com>
2557
2558         AX: [iOS] add support to return the attributed string under the element
2559         https://bugs.webkit.org/show_bug.cgi?id=188276
2560         <rdar://problem/42872357>
2561
2562         Reviewed by Chris Fleizach.
2563
2564         * DumpRenderTree/AccessibilityUIElement.cpp:
2565         (attributedStringForElementCallback):
2566         (AccessibilityUIElement::getJSClass):
2567         * DumpRenderTree/AccessibilityUIElement.h:
2568         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2569         (AccessibilityUIElement::attributedStringForElement):
2570         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2571         (WTR::AccessibilityUIElement::attributedStringForElement):
2572         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2573         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2574         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2575         (WTR::AccessibilityUIElement::attributedStringForElement):
2576
2577 2018-08-02  Ryan Haddad  <ryanhaddad@apple.com>
2578
2579         Skip API test DataInteractionTests.CustomActionSheetPopover on current SDKs.
2580         https://bugs.webkit.org/show_bug.cgi?id=175204
2581
2582         Unreviewed test gardening.
2583
2584         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2585
2586 2018-08-02  Sihui Liu  <sihui_liu@apple.com>
2587
2588         [Cocoa] setCookie API fails to set session cookies for defaultDataStore if processPool created but not used
2589         https://bugs.webkit.org/show_bug.cgi?id=188209
2590
2591         Reviewed by Geoffrey Garen.
2592
2593         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2594         (TEST):
2595
2596 2018-08-02  Dan Bernstein  <mitz@apple.com>
2597
2598         Fixed WebKit.AttrStyle timing out on build.webkit.org.
2599
2600         * TestWebKitAPI/Tests/WebKitCocoa/AttrStyle.html: Changed from a URL that requires network
2601           access to one that doesn’t.
2602         * TestWebKitAPI/Tests/WebKitCocoa/AttrStyle.mm:
2603         (TEST): Updated expected value.
2604
2605 2018-08-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2606
2607         [iOS] Keyboard becomes unresponsive after pressing delete while pressing down on a character key with accents
2608         https://bugs.webkit.org/show_bug.cgi?id=188251
2609         <rdar://problem/37842108>
2610
2611         Reviewed by Tim Horton.
2612
2613         Adds a new API test to verify that clients (in this case, UIKit) is allowed to invoke
2614         -handleKeyWebEvent:withCompletionHandler: within the completion block of a prior invocation.
2615
2616         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2617         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm: Added.
2618         (TestWebKitAPI::TEST):
2619         * TestWebKitAPI/Tests/ios/TestInputDelegate.h: Added.
2620
2621         Pull some logic used to force an input session to start out from an existing API test file
2622         (WKWebViewAutofillTests) and into a separate helper class that is used by both the existing API tests and the
2623         new keyboard input test.
2624
2625         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2626         (-[AutofillTestView initWithFrame:]):
2627         (TestWebKitAPI::TEST):
2628         (-[TestInputDelegate init]): Deleted.
2629         (-[TestInputDelegate _webView:focusShouldStartInputSession:]): Deleted.
2630         * TestWebKitAPI/ios/UIKitSPI.h:
2631
2632         Add some UIKit SPI utilized by the new API test.
2633
2634 2018-08-01  Dan Bernstein  <mitz@apple.com>
2635
2636         Optionally expose Attr::style to JavaScript
2637         https://bugs.webkit.org/show_bug.cgi?id=188226
2638         <rdar://problem/42818113>
2639
2640         Reviewed by Darin Adler.
2641
2642         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2643         * TestWebKitAPI/Tests/WebKitCocoa/AttrStyle.html: Added.
2644         * TestWebKitAPI/Tests/WebKitCocoa/AttrStyle.mm: Added.
2645         (TEST):
2646
2647 2018-08-02  David Fenton  <david_fenton@apple.com>
2648
2649         Unreviewed, rolling out r234489.
2650
2651         Caused 50+ crashes and 60+ API failures on iOS
2652
2653         Reverted changeset:
2654
2655         "[WTF] Rename String::format to String::deprecatedFormat"
2656         https://bugs.webkit.org/show_bug.cgi?id=188191
2657         https://trac.webkit.org/changeset/234489
2658
2659 2018-08-01  Ross Kirsling  <ross.kirsling@sony.com>
2660
2661         TestWTF.WTF_NeverDestroyed.Construct output differs for MSVC in Debug mode
2662         https://bugs.webkit.org/show_bug.cgi?id=188244
2663
2664         Reviewed by Daniel Bates.
2665
2666         Follow-up to r234179. MSVC chooses not to inline the lambda in Debug mode. 
2667
2668         * TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp:
2669
2670 2018-08-01  Tomas Popela  <tpopela@redhat.com>
2671
2672         [WTF] Rename String::format to String::deprecatedFormat
2673         https://bugs.webkit.org/show_bug.cgi?id=188191
2674
2675         Reviewed by Darin Adler.
2676
2677         It should be replaced with string concatenation.
2678
2679         * DumpRenderTree/win/DumpRenderTree.cpp:
2680         (applicationId):
2681         (main):
2682         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2683         (TestWebKitAPI::Util::createURLForResource):
2684         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2685         (WTR::cacheTestRunnerCallback):
2686         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2687         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
2688         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2689         (WTR::AccessibilityUIElement::attributedStringForRange):
2690         (WTR::AccessibilityUIElement::url):
2691         (WTR::stringAtOffset):
2692         * WebKitTestRunner/TestController.cpp:
2693         (WTR::TestController::didReceiveAuthenticationChallenge):
2694         (WTR::TestController::downloadDidFail):
2695         (WTR::originUserVisibleName):
2696         (WTR::userMediaOriginHash):
2697         (WTR::TestController::didNavigateWithNavigationData):
2698         (WTR::TestController::didPerformClientRedirect):
2699         (WTR::TestController::didPerformServerRedirect):
2700         (WTR::TestController::didUpdateHistoryTitle):
2701
2702 2018-08-01  Nan Wang  <n_wang@apple.com>
2703
2704         AX: AOM: Add ARIA IDL Attribute Reflection
2705         https://bugs.webkit.org/show_bug.cgi?id=184676
2706         <rdar://problem/39476882>
2707
2708         Reviewed by Chris Fleizach.
2709
2710         * DumpRenderTree/mac/DumpRenderTree.mm:
2711         (enableExperimentalFeatures):
2712         * WebKitTestRunner/TestController.cpp:
2713         (WTR::TestController::resetPreferencesToConsistentValues):
2714
2715 2018-08-01  Jonathan Bedard  <jbedard@apple.com>
2716
2717         Use iPhone SE as the default simulated device
2718         https://bugs.webkit.org/show_bug.cgi?id=188227
2719
2720         Reviewed by Aakash Jain.
2721
2722         * Scripts/webkitpy/port/ios_simulator.py:
2723         (IOSSimulatorPort):
2724
2725 2018-08-01  Commit Queue  <commit-queue@webkit.org>
2726
2727         Unreviewed, rolling out r234443 and r234445.
2728         https://bugs.webkit.org/show_bug.cgi?id=188224
2729
2730         Revision caused 3 api failures across all platforms.
2731         (Requested by Truitt on #webkit).
2732
2733         Reverted changesets:
2734
2735         "Add configuration for automatic process pre-warming"
2736         https://bugs.webkit.org/show_bug.cgi?id=187108
2737         https://trac.webkit.org/changeset/234443
2738
2739         "Add configuration for automatic process pre-warming"
2740         https://bugs.webkit.org/show_bug.cgi?id=187108
2741         https://trac.webkit.org/changeset/234445
2742
2743 2018-07-31  Ben Richards  <benton_richards@apple.com>
2744
2745         Add configuration for automatic process pre-warming
2746         https://bugs.webkit.org/show_bug.cgi?id=187108
2747
2748         Reviewed by Ryosuke Niwa.
2749
2750         Added new test case for setting maximum prewarmed process count and updated test case for process swap on navigation to set the maximum prewarmed process count to be 1 where relevant.
2751
2752         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2753         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2754         * TestWebKitAPI/Tests/WebKitCocoa/SetMaximumPrewarmedProcessCount.mm: Added.
2755         (TEST):
2756
2757 2018-07-31  John Wilander  <wilander@apple.com>
2758
2759         Resource Load Statistics: Remove partitioned cookies for reduced complexity, lower memory footprint, and ability to support more platforms
2760         https://bugs.webkit.org/show_bug.cgi?id=188109
2761         <rdar://problem/42664391>
2762
2763         Reviewed by Brent Fulgham, Chris Dumez, and Alex Christensen.
2764
2765         This patch removes cookie partitioning which reduces the model to just
2766         blocked cookies (in third-party contexts) and first-party cookie access.
2767
2768         Several of the changes are renaming to reflect that there are no more
2769         cookie partitions.
2770
2771         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2772            Removed or renamed functions to reflect that there are no more
2773            partitioned cookies.
2774         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2775         (WTR::InjectedBundle::didReceiveMessageToPage):
2776         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2777         (WTR::TestRunner::statisticsUpdateCookieBlocking):
2778         (WTR::TestRunner::statisticsCallDidSetBlockCookiesForHostCallback):
2779         (WTR::TestRunner::setCookieStoragePartitioningEnabled): Deleted.
2780         (WTR::TestRunner::setStatisticsHasHadNonRecentUserInteraction): Deleted.
2781         (WTR::TestRunner::setStatisticsTimeToLiveCookiePartitionFree): Deleted.
2782         (WTR::TestRunner::statisticsUpdateCookiePartitioning): Deleted.
2783         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost): Deleted.
2784         (WTR::TestRunner::statisticsCallDidSetPartitionOrBlockCookiesForHostCallback): Deleted.
2785         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2786         * WebKitTestRunner/TestController.cpp:
2787         (WTR::TestController::statisticsUpdateCookieBlocking):
2788         (WTR::TestController::setStatisticsHasHadNonRecentUserInteraction): Deleted.
2789         (WTR::TestController::setStatisticsTimeToLiveCookiePartitionFree): Deleted.
2790         (WTR::TestController::statisticsUpdateCookiePartitioning): Deleted.
2791         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost): Deleted.
2792         * WebKitTestRunner/TestController.h:
2793         * WebKitTestRunner/TestInvocation.cpp:
2794         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2795         (WTR::TestInvocation::didSetBlockCookiesForHost):
2796         (WTR::TestInvocation::didSetHasHadUserInteraction):
2797         (WTR::TestInvocation::didSetPartitionOrBlockCookiesForHost): Deleted.
2798         (WTR::TestInvocation::didSetHasHadNonRecentUserInteraction): Deleted.
2799         * WebKitTestRunner/TestInvocation.h:
2800         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2801         (WTR::initializeWebViewConfiguration):
2802
2803 2018-07-31  Alex Christensen  <achristensen@webkit.org>
2804
2805         Build fix.  Remove unused variable.
2806
2807         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp:
2808         (TestWebKitAPI::TEST):
2809         transform was never used. It was introduced in r205871
2810         Apparently I'm the first one to build in a certain configuration that found it.
2811
2812 2018-07-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2813
2814         server_process.py should print returncode in debug log if the process crashed
2815         https://bugs.webkit.org/show_bug.cgi?id=188160
2816
2817         Reviewed by Konstantin Tokarev.
2818
2819         * Scripts/webkitpy/port/server_process.py:
2820         (ServerProcess.has_crashed): Put self._proc.returncode into the debug log message.
2821
2822 2018-07-31  Tomas Popela  <tpopela@redhat.com>
2823
2824         [WTF] String::formatWithArguments() is unused
2825         https://bugs.webkit.org/show_bug.cgi?id=187955
2826
2827         Reviewed by Darin Adler.
2828
2829         Remove tests for WTF::String::formatWithArguments() as it's unused and
2830         we are removing it.
2831
2832         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2833
2834 2018-07-30  Aakash Jain  <aakash_jain@apple.com>
2835
2836         [ews-build] Fix typo in builder name for Bindings-tests-EWS.
2837
2838         * BuildSlaveSupport/ews-build/config.json: Changed 'tests' to 'Tests' to make it consistent with
2839         other builders.
2840
2841 2018-07-30 Aakash Jain  <aakash_jain@apple.com>
2842
2843         [ews-build] Add support for API tests in OpenSource EWS
2844         https://bugs.webkit.org/show_bug.cgi?id=188156
2845
2846         Reviewed by Lucas Forschler.
2847
2848         * BuildSlaveSupport/ews-build/config.json:
2849         * BuildSlaveSupport/ews-build/factories.py:
2850         (BuildFactory.__init__): Added triggers parameter.
2851         (BuildFactory): If trigger is defined, create and upload archive and trigger appropriate queues.
2852         (BuildFactory.propertiesToPassToTriggers): Pass all the required properties to triggered queue.
2853         (APITestsFactory): Factory for running API tests.
2854         * BuildSlaveSupport/ews-build/steps.py:
2855         (ConfigureBuild.start): Set the property only if property is defined in config.json. Also set the 
2856         source of the property.
2857
2858 2018-07-30  Aakash Jain  <aakash_jain@apple.com>
2859
2860         [ews-build] loadConfig should ensure that the triggers are valid
2861         https://bugs.webkit.org/show_bug.cgi?id=188134
2862
2863         Reviewed by Lucas Forschler.
2864
2865         * BuildSlaveSupport/ews-build/loadConfig.py:
2866         (checkValidBuilder): Added a check to ensure that the builder doesn't refernce non-existing scheduler.
2867         (checkValidSchedulers): Ensures that the scheduler is not un-used.
2868         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
2869
2870 2018-07-27  Michael Catanzaro  <mcatanzaro@igalia.com>
2871
2872         Unreviewed, fix typo in test expectations and mark another test as timing out
2873
2874         * TestWebKitAPI/glib/TestExpectations.json:
2875
2876 2018-07-27  Michael Catanzaro  <mcatanzaro@igalia.com>
2877
2878         More unreviewed GTK test gardening
2879
2880         * TestWebKitAPI/glib/TestExpectations.json:
2881
2882 2018-07-27  Simon Fraser  <simon.fraser@apple.com>
2883
2884         Be more conservative with compositing layer creation when memory is low
2885         https://bugs.webkit.org/show_bug.cgi?id=187866
2886         rdar://problem/42366345
2887
2888         Reviewed by Zalan Bujtas.
2889         
2890         When process physical footprint is above a fraction of the jetsam limit, be more conservative in making
2891         compositing layers. We avoid compositing for these situations:
2892         1. Layers with 3D transforms which are affine (like translateZ(0)).
2893         2. Layers with will-change
2894         3. Layers for canvases (other than WebGL/WebGPU)
2895         
2896         We reuse some macOS code in MemoryPressureHandler() but choose different thresholds for iOS,
2897         falling into "conservative mode" at 50% of jetsam limit, and "strict mode" at 65%.
2898         Compositing chooses to be more conservative in either "conservative" or "strict" memory modes.
2899         
2900         Plumb through a "compositingPolicyOverride" both so that on-device testing isn't
2901         flakily falling into a different mode, and so that we can impose the conservative
2902         mode for testing.
2903
2904         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2905         (WTR::InjectedBundlePage::prepare):
2906
2907 2018-07-27  Michael Catanzaro  <mcatanzaro@igalia.com>
2908
2909         Unreviewed GTK test gardening
2910
2911         * TestWebKitAPI/glib/TestExpectations.json:
2912
2913 2018-07-27  Alex Christensen  <achristensen@webkit.org>
2914
2915         Fix API tests after r234314
2916         https://bugs.webkit.org/show_bug.cgi?id=188077
2917
2918         Make API tests use new delegate method.
2919
2920         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2921         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2922         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
2923
2924 2018-07-27  Alex Christensen  <achristensen@webkit.org>
2925
2926         Fix API tests after r234314
2927         https://bugs.webkit.org/show_bug.cgi?id=188077
2928
2929         Make API tests use new delegate method.
2930
2931         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2932         (-[ContentBlockingWebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2933         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2934         (-[AsyncAutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2935         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2936         (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2937         (-[ContentBlockingWebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
2938         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
2939         (-[AsyncAutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
2940         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
2941         (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
2942
2943 2018-07-26  Andy VanWagoner  <andy@vanwagoner.family>
2944
2945         [INTL] Remove INTL sub-feature compile flags
2946         https://bugs.webkit.org/show_bug.cgi?id=188081
2947
2948         Reviewed by Michael Catanzaro.
2949
2950         * Scripts/webkitperl/FeatureList.pm:
2951         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2952
2953 2018-07-26  Chris Dumez  <cdumez@apple.com>
2954
2955         Loading a file URL and then issuing a reload right away causes the load to fail due to sandboxing
2956         https://bugs.webkit.org/show_bug.cgi?id=188078
2957         <rdar://problem/42562493>
2958
2959         Reviewed by Geoff Garen.
2960
2961         Add API test coverage. It exercises the right code path but unfortunately is not yet a regression
2962         test because TestWebKitAPI does not appear to be sandboxed (rdar://problem/42638129).
2963
2964         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2965         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileThenReload.mm: Added.
2966         (-[LoadFileThenReloadDelegate webView:didFinishNavigation:]):
2967         (-[LoadFileThenReloadDelegate webView:didFailProvisionalNavigation:withError:]):
2968         (-[LoadFileThenReloadDelegate webView:didFailNavigation:withError:]):
2969         (TEST):
2970
2971 2018-07-26  Aaron Chu  <aaron_chu@apple.com>
2972
2973         Add Aaron Chu as a committer to contributors.json
2974         https://bugs.webkit.org/show_bug.cgi?id=188066
2975
2976         Unreviwed. Added myself as committer.
2977
2978         * Scripts/webkitpy/common/config/contributors.json:
2979
2980 2018-07-26  Aakash Jain  <aakash_jain@apple.com>
2981
2982         [ews-build] Add build step to run API Tests
2983         https://bugs.webkit.org/show_bug.cgi?id=188079
2984
2985         Reviewed by Lucas Forschler.
2986
2987         * BuildSlaveSupport/ews-build/steps.py:
2988         (TestWithFailureCount): Common class for various tests with failure count.
2989         (TestWithFailureCount.start): Configure Buildbot's logobserver.
2990         (TestWithFailureCount.commandComplete): Updates the failure count.
2991         (TestWithFailureCount.evaluateCommand): Set the step status appropriately.
2992         (TestWithFailureCount.getResultSummary): Set the step summary appropriately.
2993         (RunAPITests): Build step to run API tests.
2994         (RunAPITests.countFailures): Count the failures by parsing the output.
2995         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2996
2997 2018-07-26  Ross Kirsling  <ross.kirsling@sony.com>
2998
2999         String(View) should have a splitAllowingEmptyEntries function instead of a flag parameter
3000         https://bugs.webkit.org/show_bug.cgi?id=187963
3001
3002         Reviewed by Alex Christensen.
3003
3004         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3005         Add tests for String::split and String::splitAllowingEmptyEntries.
3006
3007         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3008         * WebKitTestRunner/TestController.cpp:
3009         (WTR::updateTestOptionsFromTestHeader):
3010         Update split/splitAllowingEmptyEntries usage.
3011
3012 2018-07-26  Commit Queue  <commit-queue@webkit.org>
3013
3014         Unreviewed, rolling out r234181 and r234189.
3015         https://bugs.webkit.org/show_bug.cgi?id=188075
3016
3017         These are not needed right now (Requested by thorton on
3018         #webkit).
3019
3020         Reverted changesets:
3021
3022         "Enable Web Content Filtering on watchOS"
3023         https://bugs.webkit.org/show_bug.cgi?id=187979
3024         https://trac.webkit.org/changeset/234181
3025
3026         "HAVE(PARENTAL_CONTROLS) should be true on watchOS"
3027         https://bugs.webkit.org/show_bug.cgi?id=187985
3028         https://trac.webkit.org/changeset/234189
3029
3030 2018-07-04  Darin Adler  <darin@apple.com>
3031
3032         Improve WebGPU implementation, including using Metal Objective-C protocols more simply and correctly
3033         https://bugs.webkit.org/show_bug.cgi?id=187333
3034
3035         Reviewed by Sam Weinig.
3036
3037         * TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm: Updated.
3038         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Updated.
3039         * TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm: Updated.
3040         * TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm: Updated.
3041         * TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm: Updated.
3042
3043 2018-07-25  Aakash Jain  <aakash_jain@apple.com>
3044
3045         [ews-build] Add build steps DownloadBuiltProduct and ExtractBuiltProduct
3046         https://bugs.webkit.org/show_bug.cgi?id=188031
3047
3048         Reviewed by Lucas Forschler.
3049
3050         * BuildSlaveSupport/ews-build/steps.py:
3051         (DownloadBuiltProduct): Added build step DownloadBuiltProduct.
3052         (ExtractBuiltProduct): Added build step ExtractBuiltProduct.
3053         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3054
3055 2018-07-25  Aakash Jain  <aakash_jain@apple.com>
3056
3057         [ews-build] Add build step UploadBuiltProduct
3058         https://bugs.webkit.org/show_bug.cgi?id=188016
3059
3060         Reviewed by Lucas Forschler.
3061
3062         * BuildSlaveSupport/ews-build/steps.py:
3063         (UploadBuiltProduct): Added build step UploadBuiltProduct.
3064         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
3065
3066 2018-07-25  Aakash Jain  <aakash_jain@apple.com>
3067
3068         [ews-build] Add build step ArchiveBuiltProduct
3069         https://bugs.webkit.org/show_bug.cgi?id=188014
3070
3071         Reviewed by Lucas Forschler.
3072
3073         * BuildSlaveSupport/ews-build/steps.py:
3074         (ArchiveBuiltProduct): Added build step ArchiveBuiltProduct.
3075         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3076
3077 2018-07-25  Chris Dumez  <cdumez@apple.com>
3078
3079         navigator.userAgent may return outdated value after webView.customUserAgent is set
3080         https://bugs.webkit.org/show_bug.cgi?id=188009
3081         <rdar://problem/42566456>
3082
3083         Reviewed by Alex Christensen.
3084
3085         Add API test coverage.
3086
3087         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3088         * TestWebKitAPI/Tests/WebKitCocoa/CustomUserAgent.mm: Added.
3089         (TEST):
3090
3091 2018-07-25  Charlie Turner  <cturner@igalia.com>
3092
3093         [Flatpak] Pass more environment variables to sandbox
3094         https://bugs.webkit.org/show_bug.cgi?id=188002
3095
3096         Reviewed by Michael Catanzaro.
3097
3098         * flatpak/flatpakutils.py:
3099         (WebkitFlatpak.run_in_sandbox):
3100
3101 2018-07-25  Zan Dobersek  <zdobersek@igalia.com>
3102
3103         [WPE] Switch ViewBackend to using wpe_view_backend_exportable_fdo_egl APIs
3104         https://bugs.webkit.org/show_bug.cgi?id=187997
3105
3106         Reviewed by Carlos Garcia Campos.
3107
3108         Instead of the raw wpe_view_backend_exportable_fdo API, switch to using
3109         the EGL-oriented API that simply serves EGLImageKHR objects instead of
3110         raw buffer resources. This allows us not to wrangle with creating and
3111         managing lifetime of the same EGLImageKHR by ourselves.
3112
3113         ViewBackend now defines a wpe_view_backend_exportable_fdo_egl_client
3114         struct and uses wpe_view_backend_exportable_fdo_egl_create() to create
3115         the exportable object. This means that for each frame we're served an
3116         EGLImageKHR object that is passed on to the displayBuffer()
3117         implementation.
3118
3119         HeadlessViewBackend now just manages the pending and committed image
3120         objects. Width and height values used during pixel data retrieval are
3121         gathered from the ViewBackend's size that was specified when
3122         constructed.
3123
3124         WindowViewBackend similarly only manages the committed image object,
3125         not having to create an equivalent EGLImageKHR object from the raw
3126         buffer resource anymore.
3127
3128         Unused EGL entrypoints in both HeadlessViewBackend and WindowViewBackend
3129         classes are removed, and destructors for both classes are made virtual.
3130
3131         The WPEBackend-fdo version is bumped in order to have the EGL-specific
3132         export API available.
3133
3134         * flatpak/org.webkit.WPE.yaml:
3135         * wpe/backends/HeadlessViewBackend.cpp:
3136         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend):
3137         (WPEToolingBackends::HeadlessViewBackend::~HeadlessViewBackend):
3138         (WPEToolingBackends::HeadlessViewBackend::createSnapshot):
3139         (WPEToolingBackends::HeadlessViewBackend::performUpdate):
3140         (WPEToolingBackends::HeadlessViewBackend::displayBuffer):
3141         * wpe/backends/HeadlessViewBackend.h:
3142         * wpe/backends/ViewBackend.cpp:
3143         (WPEToolingBackends::ViewBackend::initialize):
3144         * wpe/backends/ViewBackend.h:
3145         * wpe/backends/WindowViewBackend.cpp:
3146         (WPEToolingBackends::WindowViewBackend::WindowViewBackend):
3147         (WPEToolingBackends::WindowViewBackend::~WindowViewBackend):
3148         (WPEToolingBackends::WindowViewBackend::displayBuffer):
3149         * wpe/backends/WindowViewBackend.h:
3150         * wpe/jhbuild.modules:
3151
3152 2018-07-24  Thomas Denney  <tdenney@apple.com>
3153
3154         Remove support for the double type from WHLSL
3155         https://bugs.webkit.org/show_bug.cgi?id=187977
3156
3157         Reviewed by Myles C. Maxfield.
3158
3159         * WebGPUShadingLanguageRI/All.js: Removed DoubleLiteral.js and DoubleLiteralType.js include.
3160         * WebGPUShadingLanguageRI/DoubleLiteral.js: Removed.
3161         * WebGPUShadingLanguageRI/DoubleLiteralType.js: Removed.
3162         * WebGPUShadingLanguageRI/Intrinsics.js: Removed double arithmetic functions.
3163         * WebGPUShadingLanguageRI/Parse.js:
3164         (parseTerm): Removed parsing of double literals.
3165         * WebGPUShadingLanguageRI/SPIRV.html: Removed DoubleLiteral.js and DoubleLiteralType.js include.
3166         * WebGPUShadingLanguageRI/SPIRVCodegen.js: Removed double type logic.
3167         * WebGPUShadingLanguageRI/StandardLibrary.js: Removed double type declarations.
3168         * WebGPUShadingLanguageRI/Test.html: Removed DoubleLiteral.js and DoubleLiteralType.js include.
3169         * WebGPUShadingLanguageRI/Test.js: Removed tests that test doubles or ported them to use floats.
3170         * WebGPUShadingLanguageRI/index.html: Removed DoubleLiteral.js and DoubleLiteralType.js include.
3171
3172 2018-07-24  Tim Horton  <timothy_horton@apple.com>
3173
3174         Enable Web Content Filtering on watchOS
3175         https://bugs.webkit.org/show_bug.cgi?id=187979
3176         <rdar://problem/42559346>
3177
3178         Reviewed by Wenson Hsieh.
3179
3180         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3181
3182 2018-07-24  Daniel Bates  <dabates@apple.com>
3183
3184         Move-constructing NeverDestroyed should move construct underlying object instead of copy constructing it
3185         https://bugs.webkit.org/show_bug.cgi?id=187971
3186
3187         Reviewed by Saam Barati.
3188
3189         Add unit tests to cover move constructing a NeverDestroyed with a non-const and const data type
3190         as well as invoking makeNeverDestroyed() with the result of a function that returns a move-only
3191         data type.
3192
3193         * TestWebKitAPI/CMakeLists.txt:
3194         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3195         * TestWebKitAPI/Tests/WTF/MoveOnlyLifecycleLogger.cpp: Added.
3196         (TestWebKitAPI::MoveOnlyLifecycleLogger::MoveOnlyLifecycleLogger):
3197         (TestWebKitAPI::MoveOnlyLifecycleLogger::~MoveOnlyLifecycleLogger):
3198         (TestWebKitAPI::MoveOnlyLifecycleLogger::operator=):
3199         (TestWebKitAPI::MoveOnlyLifecycleLogger::setName):
3200         (TestWebKitAPI::TEST):
3201         * TestWebKitAPI/Tests/WTF/MoveOnlyLifecycleLogger.h: Added.
3202         * TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp:
3203         (TestWebKitAPI::TEST):
3204
3205 2018-07-24  Thomas Denney  <tdenney@apple.com>
3206         Minor changes to the WHLSL interpreter to support the new compiler
3207         https://bugs.webkit.org/show_bug.cgi?id=187728
3208
3209         Reviewed by Myles C. Maxfield.
3210
3211         This bug contains small changes that are make minor changes to the
3212         behaviour of the existing interpreter (the tests are unaffected and all
3213         still pass).
3214
3215         * WebGPUShadingLanguageRI/EnumType.js:
3216         (EnumType.prototype.get isEnum): Property added to EnumType and Type
3217         * WebGPUShadingLanguageRI/Evaluator.js: Correct typo
3218         * WebGPUShadingLanguageRI/Func.js:
3219         (Func.prototype.get isEntryPoint): Add boolean property
3220         * WebGPUShadingLanguageRI/FuncInstantiator.js:
3221         (FuncInstantiator.prototype.get instances): Public accessor for existing
3222         private field
3223         * WebGPUShadingLanguageRI/FunctionLikeBlock.js: Refactored the class so
3224         that it directly wraps a Func instance (therefore the only interface
3225         change is to the constructor and the addition of the func accessor).
3226         This change allows the de-inlining of functions.
3227         (FunctionLikeBlock):
3228         (FunctionLikeBlock.prototype.get func):
3229         (FunctionLikeBlock.prototype.get returnType):
3230         (FunctionLikeBlock.prototype.get parameters):
3231         (FunctionLikeBlock.prototype.get body):
3232         * WebGPUShadingLanguageRI/Inliner.js: Use the new FunctionLikeBlock
3233         constructor
3234         (Inliner.prototype.visitCallExpression):
3235         (Inliner):
3236         * WebGPUShadingLanguageRI/Intrinsics.js: Migrate the swizzle operators
3237         to native functions (with additional support in StandardLibrary.js).
3238         This reduces first-time compile-time from around 4s to around 0.1s.
3239         (Intrinsics):
3240         * WebGPUShadingLanguageRI/Lexer.js: Ensure that the parsing of multiline
3241         comments completes correctly
3242         (Lexer.prototype.next):
3243         (Lexer):
3244         * WebGPUShadingLanguageRI/MakeArrayRefExpression.js: Addition of type
3245         property, which is based on the type of the lValue and the semantics of
3246         the language (the @ operator yields an array reference with the thread
3247         scope).
3248         (MakeArrayRefExpression):
3249         (MakeArrayRefExpression.prototype.get type):
3250         * WebGPUShadingLanguageRI/NativeFunc.js: Add setter/getter for
3251         implementationData to support swizzle operator change
3252         (NativeFunc.prototype.get implementationData):
3253         (NativeFunc.prototype.set implementationData):
3254         * WebGPUShadingLanguageRI/Rewriter.js: Use new FunctionLikeBlock
3255         constructor
3256         (Rewriter.prototype.visitFunctionLikeBlock):
3257         * WebGPUShadingLanguageRI/StandardLibrary.js:
3258         (_generateSwizzle): Deleted.
3259         * WebGPUShadingLanguageRI/SwizzleOp.js: Introduces a new class for
3260         carrying metadata about swizzle operators so that they are implemented
3261         as native functions rather than generated at compile time.
3262         (SwizzleOp):
3263         (SwizzleOp.prototype.get outSize):
3264         (SwizzleOp.prototype.get components):
3265         (SwizzleOp.prototype.get inSize):
3266         (SwizzleOp.prototype.toString):
3267         (SwizzleOp.allSwizzleOperators.):
3268         (SwizzleOp.allSwizzleOperators):
3269         * WebGPUShadingLanguageRI/StandardLibrary.js: +        (SwizzleOp):
3270         (SwizzleOp.prototype.get outSize):
3271         (SwizzleOp.prototype.get components):
3272         (SwizzleOp.prototype.get inSize):
3273         (SwizzleOp.prototype.toString):
3274         (generateSwizzles):
3275         (_generateSwizzle): Deleted.
3276         * WebGPUShadingLanguageRI/Type.js: Addition of isEnum property, as
3277         above.
3278         (Type.prototype.get isEnum):
3279
3280 2018-07-24  Ryan Haddad  <ryanhaddad@apple.com>
3281
3282         Unreviewed, rolling out r234121.
3283
3284         Caused perf test failures.
3285
3286         Reverted changeset:
3287
3288         "We should cache the compiled sandbox profile in a data vault"
3289         https://bugs.webkit.org/show_bug.cgi?id=184991
3290         https://trac.webkit.org/changeset/234121
3291
3292 2018-07-24  Thibault Saunier  <tsaunier@igalia.com>
3293
3294         [Flatpak] Add openh264 as needed by WebRTC
3295         https://bugs.webkit.org/show_bug.cgi?id=187956
3296
3297         Reviewed by Philippe Normand.
3298
3299         * flatpak/org.webkit.WebKit.yaml:
3300
3301 2018-07-24  Ross Kirsling  <ross.kirsling@sony.com>
3302
3303         WebCore::URL::hostIsIPAddress needs a Windows implementation
3304         https://bugs.webkit.org/show_bug.cgi?id=187859
3305
3306         Reviewed by Fujii Hironori.
3307
3308         * TestWebKitAPI/Tests/WebCore/URL.cpp:
3309         Check for a few other ways an IP address could be invalid.
3310
3311 2018-07-24  Charlie Turner  <cturner@igalia.com>
3312
3313         [Flatpak] Avoid consuming unknown arguments in flatpak wrapper
3314         https://bugs.webkit.org/show_bug.cgi?id=187951
3315
3316         When running run-webkit-tests --wpe --debug, it was observed that
3317         both self.platform != 'wpe' and self.debug != True. This turned
3318         out to be because of the "args" argument consuming the remainder
3319         of future arguments that came after it. Since the first argument
3320         to load_from_args was the test script to run, it would end up
3321         never processing the other arguments supplied to the wrapper
3322         script.
3323
3324         Tested this by rebuilding GTK in debug mode, running the
3325         minibrowser with various extra options, and running some tests
3326         with various extra options.
3327
3328         Reviewed by Michael Catanzaro.
3329
3330         * flatpak/flatpakutils.py:
3331         (WebkitFlatpak.load_from_args):
3332
3333 2018-07-24  Thibault Saunier  <tsaunier@igalia.com>
3334
3335         [Flatpak] Remove now unnecessary 'hacks' for running tests
3336         https://bugs.webkit.org/show_bug.cgi?id=187608
3337
3338         Reviewed by Philippe Normand.
3339
3340         We used to need to not share X11 with the sandbox when running tests
3341         but it is not needed anymore as we do not mount `/tmp` on `/tmp` in the
3342         sandbox (we mount it on `/run/host/tmp` now).
3343
3344         This has the advantage of making running the MiniBrowser to display test
3345         results working again.
3346
3347         * flatpak/flatpakutils.py:
3348         (WebkitFlatpak.clean_args):
3349         (WebkitFlatpak.run_in_sandbox):
3350         (WebkitFlatpak._cleanup_faltpak_args_for_tests_if_needed): Deleted.
3351
3352 2018-07-23  Fujii Hironori  <Hironori.Fujii@sony.com>
3353
3354         webkitpy.port.server_process_unittest.TestServerProcess.test_basic failed on Windows Python
3355         https://bugs.webkit.org/show_bug.cgi?id=187581
3356
3357         Reviewed by Daniel Bates.
3358
3359         There are two failures in this test case:
3360         1. proc.poll() doesn't return 0.
3361         2. stderr is not output.
3362
3363         For failure #1, this is expected. the process should not exit at
3364         the time. proc.poll() should return None because the process is
3365         still alive.
3366
3367         This change added a new test to check proc.poll() becomes 0 after
3368         the process successfully exits.
3369
3370         For failure #2, stderr is not flushed even though stdout is
3371         flushed. This change uses '-u' command switch to force stdin,
3372         stdout and stderr to be totally unbuffered.
3373
3374         * Scripts/webkitpy/port/server_process_unittest.py:
3375         (TestServerProcess.test_basic): Added -u command switch. Do not
3376         flush stdout. Removed the special condition for Windows. Add a new
3377         test to check proc.poll() returns 0.
3378         (TestServerProcess.test_process_crashing): Added -u command
3379         switch. Do not flush stdout.
3380
3381 2018-07-23  Ross Kirsling  <ross.kirsling@sony.com>
3382
3383         WTF::StringView::split should have an allowEmptyEntries flag
3384         https://bugs.webkit.org/show_bug.cgi?id=187864
3385
3386         Reviewed by Konstantin Tokarev.
3387
3388         * TestWebKitAPI/Tests/WTF/StringView.cpp: Add test.
3389
3390 2018-07-23  Ben Richards  <benton_richards@apple.com>
3391
3392         We should cache the compiled sandbox profile in a data vault
3393         https://bugs.webkit.org/show_bug.cgi?id=184991
3394
3395         Reviewed by Ryosuke Niwa.
3396
3397         Added trace points for sandbox initialization
3398
3399         * Tracing/SystemTracePoints.plist:
3400
3401 2018-07-23  Zalan Bujtas  <zalan@apple.com>
3402
3403         DRT relies on [webView display] to call -viewWillDraw on the WebHTMLView
3404         https://bugs.webkit.org/show_bug.cgi?id=187924
3405         <rdar://problem/41745884>
3406
3407         Reviewed by Simon Fraser.
3408
3409         WebKit relies on -viewWillDraw getting called on WebHTMLView, even though that view has not been marked as needing display.
3410
3411         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3412         (createBitmapContextFromWebView):
3413
3414 2018-07-23  Chris Dumez  <cdumez@apple.com>
3415
3416         WebResourceLoadStatisticsStore fails to unregister itself as a MessageReceiver in its destructor
3417         https://bugs.webkit.org/show_bug.cgi?id=187910
3418         <rdar://problem/42356526>
3419
3420         Reviewed by Brent Fulgham.
3421
3422         Add API test coverage.
3423
3424         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3425         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3426         (-[DisableITPDuringNavigationDelegate webView:didCommitNavigation:]):
3427         (-[DisableITPDuringNavigationDelegate webView:didFinishNavigation:]):
3428         (TEST):
3429         * TestWebKitAPI/Tests/WebKitCocoa/notify-resourceLoadObserver.html: Added.
3430
3431 2018-07-23  Daniel Bates  <dabates@apple.com>
3432
3433         test-webkitpy should take configuration command line options
3434         https://bugs.webkit.org/show_bug.cgi?id=187872
3435
3436         Reviewed by David Kilzer.
3437
3438         Add --debug and --release optional command line options and teach the test bots to invoke test-webkitpy
3439         with the appropriate configuration. At the moment these options are only meaningful on Mac since they
3440         effect the configuration lldbWebKitTester is built with and we only build lldbWebKitTester on Mac.
3441
3442         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3443         (RunPythonTests): Pass the configuration to test-webkitpy. On Mac this will effect
3444         how lldbWebKitTester is built. All other ports do not make use of the specified configuration.
3445         * Scripts/webkitpy/test/main.py:
3446         (_build_lldb_webkit_tester): Modified to take the configuration to build lldbWebKitTester. If
3447         the specified configuration is None then we fall back to using the default configuration (as set
3448         by script set-webkit-configuration).
3449         (Tester._parse_args): Add command line options --debug and --release to build lldbWebKitTester
3450         with a Debug configuration and a Release configuration, respectively
3451         (Tester._run_tests): Pass the configuration to build lldbWebKitTester that we parsed from
3452         the command line options. It may be None if neither --debug nor --release were passed.
3453
3454 2018-07-23  Commit Queue  <commit-queue@webkit.org>
3455
3456         Unreviewed, rolling out r233030.
3457         https://bugs.webkit.org/show_bug.cgi?id=187904
3458
3459         Broke tarball builds (Requested by mcatanzaro on #webkit).
3460
3461         Reverted changeset:
3462
3463         "run-gtk-tests (glib/common.py) cannot determine build
3464         directory when webKitBranchBuild=true"
3465         https://bugs.webkit.org/show_bug.cgi?id=185643
3466         https://trac.webkit.org/changeset/233030
3467
3468 2018-07-21  Simon Fraser  <simon.fraser@apple.com>
3469
3470         Fix lldb summarizers for HashMaps and HashSets
3471         https://bugs.webkit.org/show_bug.cgi?id=187883
3472
3473         Reviewed by Dan Bates.
3474         
3475         HashMap and HashSet summarizers were broken in various ways.
3476         
3477         The 'type summary add -x' regexp needs to match at the start and end of the string
3478         to avoid finding types nested inside other templates.
3479         
3480         The HashTable synthetic child code incorrectly used the type of the key, rather than
3481         the value when synthesizing children.
3482         
3483         Add HashMap and HashSet summarizers.
3484
3485         I tried to get synthetic children working directly for HashMap and HashSet, but was unable.
3486
3487         * lldb/lldbWebKitTester/main.cpp:
3488         (testSummaryProviders):
3489         * lldb/lldb_webkit.py:
3490         (__lldb_init_module):
3491         (__lldb_init_module.lldb_webkit):
3492         (WTFHashMap_SummaryProvider):
3493         (WTFHashSet_SummaryProvider):
3494         (WebCoreColorProvider._to_string_extended):
3495         (WebCoreURLProvider.to_string):
3496         (WTFHashMapProvider):
3497         (WTFHashMapProvider.__init__):
3498         (WTFHashMapProvider.tableSize):
3499         (WTFHashMapProvider.keyCount):
3500         (WTFHashSetProvider):
3501         (WTFHashSetProvider.__init__):
3502         (WTFHashSetProvider.tableSize):
3503         (WTFHashSetProvider.keyCount):
3504         (WTFHashTableProvider.tableSize):
3505         (WTFHashTableProvider):
3506         (WTFHashTableProvider.keyCount):
3507         (WTFHashTableProvider.get_child_at_index):
3508         (WTFHashTableProvider.update):
3509         * lldb/lldb_webkit_unittest.py:
3510         (TestSummaryProviders.serial_test_WTFVectorProvider_empty_vector):
3511         (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):
3512         (TestSummaryProviders):
3513         (TestSummaryProviders.serial_test_WTFHashMap_tablesize_and_size):
3514         (TestSummaryProviders.serial_test_WTFHashMap_of_vectors_tablesize_and_size):
3515         (TestSummaryProviders.serial_test_WTFHashSet_tablesize_and_size):
3516
3517 2018-07-21  Simon Fraser  <simon.fraser@apple.com>
3518
3519         Add lldb formatters for WebCore geometry types
3520         https://bugs.webkit.org/show_bug.cgi?id=187884
3521
3522         Reviewed by Daniel Bates.
3523         
3524         Add lldb formatters for IntPoint, IntSize, IntRect, FloatPoint, FloatSize, FloatRect
3525         and LayoutRect.
3526         
3527         Testing is blocked by webkit.org/b/187872.
3528
3529         * lldb/lldbWebKitTester/main.cpp:
3530         (testSummaryProviders):
3531         * lldb/lldb_webkit.py:
3532         (__lldb_init_module.lldb_webkit):
3533         (__lldb_init_module):
3534         (WebCoreLayoutRect_SummaryProvider):
3535         (WebCoreIntSize_SummaryProvider):
3536         (WebCoreIntPoint_SummaryProvider):
3537         (WebCoreFloatSize_SummaryProvider):
3538         (WebCoreFloatPoint_SummaryProvider):
3539         (WebCoreIntRect_SummaryProvider):
3540         (WebCoreFloatRect_SummaryProvider):
3541         (WebCoreLayoutRectProvider):
3542         (WebCoreLayoutRectProvider.__init__):
3543         (WebCoreLayoutRectProvider.get_x):
3544         (WebCoreLayoutRectProvider.get_y):
3545         (WebCoreLayoutRectProvider.get_width):
3546         (WebCoreLayoutRectProvider.get_height):
3547         (WebCoreIntPointProvider):
3548         (WebCoreIntPointProvider.__init__):
3549         (WebCoreIntPointProvider.get_x):
3550         (WebCoreIntPointProvider.get_y):
3551         (WebCoreIntSizeProvider):
3552         (WebCoreIntSizeProvider.__init__):
3553         (WebCoreIntSizeProvider.get_width):
3554         (WebCoreIntSizeProvider.get_height):
3555         (WebCoreIntRectProvider):
3556         (WebCoreIntRectProvider.__init__):
3557         (WebCoreIntRectProvider.get_x):
3558         (WebCoreIntRectProvider.get_y):
3559         (WebCoreIntRectProvider.get_width):
3560         (WebCoreIntRectProvider.get_height):
3561         (WebCoreFloatPointProvider):
3562         (WebCoreFloatPointProvider.__init__):
3563         (WebCoreFloatPointProvider.get_x):
3564         (WebCoreFloatPointProvider.get_y):
3565         (WebCoreFloatSizeProvider):
3566         (WebCoreFloatSizeProvider.__init__):
3567         (WebCoreFloatSizeProvider.get_width):
3568         (WebCoreFloatSizeProvider.get_height):
3569         (WebCoreFloatRectProvider):
3570         (WebCoreFloatRectProvider.__init__):
3571         (WebCoreFloatRectProvider.get_x):
3572         (WebCoreFloatRectProvider.get_y):
3573         (WebCoreFloatRectProvider.get_width):
3574         (WebCoreFloatRectProvider.get_height):
3575
3576 2018-07-20  John Wilander  <wilander@apple.com>
3577
3578         Resource Load Statistics: Enable basic functionality in experimental debug mode
3579         https://bugs.webkit.org/show_bug.cgi?id=187835
3580         <rdar://problem/42408590>
3581
3582         Reviewed by Chris Dumez.
3583
3584         This patch makes the experimental ITP Debug Mode feature work, at least
3585         to a basic level. All of the changes to TestRunner are to support the
3586         layout tests for the functionality.
3587
3588         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3589         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3590         (WTR::InjectedBundle::didReceiveMessageToPage):
3591         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3592         (WTR::TestRunner::setStatisticsDebugMode):
3593         (WTR::TestRunner::statisticsCallDidSetDebugModeCallback):
3594         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
3595         (WTR::TestRunner::statisticsCallDidSetPrevalentResourceForDebugModeCallback):
3596         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3597         * WebKitTestRunner/TestController.cpp:
3598         (WTR::TestController::setStatisticsDebugMode):
3599         (WTR::TestController::setStatisticsPrevalentResourceForDebugMode):
3600         * WebKitTestRunner/TestController.h:
3601         * WebKitTestRunner/TestInvocation.cpp:
3602         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3603         (WTR::TestInvocation::didSetStatisticsDebugMode):
3604         (WTR::TestInvocation::didSetPrevalentResourceForDebugMode):
3605         * WebKitTestRunner/TestInvocation.h:
3606
3607 2018-07-20  Ryosuke Niwa  <rniwa@apple.com>
3608
3609         Picking a color from the color panel for typing attributes needs to inverse transform through color-filter
3610         https://bugs.webkit.org/show_bug.cgi?id=187846
3611
3612         Reviewed by Simon Fraser.
3613
3614         Fixed the bug that testRunner.execCommand was using the second argument as the value.
3615
3616         The second argument, aShowDefaultUI, should always be ignored in testRunner.execCommand,
3617         and the third argument should be used as the value. DumpRenderTree's implementation does this already.
3618
3619         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3620         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3621         (WTR::TestRunner::execCommand):
3622         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3623
3624 2018-07-20  Dean Jackson  <dino@apple.com>
3625
3626         Accidentally checked in the wrong version of these files.
3627
3628         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj:
3629         * lldb/lldbWebKitTester/main.cpp:
3630         (testSummaryProviders):
3631         * lldb/lldb_webkit_unittest.py:
3632         (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):
3633         (TestSummaryProviders.serial_test_WebCoreColorProvider_invalid_color): Deleted.
3634         (TestSummaryProviders.serial_test_WebCoreColorProvider_extended_color): Deleted.
3635         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgb_color): Deleted.
3636         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgba_color): Deleted.
3637         (TestSummaryProviders.serial_test_WebCoreColorProvider_semantic_color): Deleted.
3638
3639 2018-07-20  Dean Jackson  <dino@apple.com>
3640
3641         Provide an lldb type summary for WebCore::Color
3642         https://bugs.webkit.org/show_bug.cgi?id=187776
3643
3644         Reviewed by Dan Bates.
3645
3646         This time without the tests because we don't want to build
3647         all of WebKit just for python tests.
3648
3649         * lldb/lldb_webkit.py: Add a Color summary provider.
3650         (__lldb_init_module):
3651         (WebCoreColor_SummaryProvider):
3652         (WebCoreColorProvider):
3653         (WebCoreColorProvider.__init__):
3654         (WebCoreColorProvider._is_extended):
3655         (WebCoreColorProvider._is_valid):
3656         (WebCoreColorProvider._is_semantic):
3657         (WebCoreColorProvider._to_string_extended):
3658         (WebCoreColorProvider.to_string):
3659
3660 2018-07-20  Brady Eidson  <beidson@apple.com>
3661
3662         Add WKNavigation/WKNavigationAction related SPI.
3663         https://bugs.webkit.org/show_bug.cgi?id=187826
3664
3665         Reviewed by Chris Dumez.
3666
3667         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
3668         (-[NavigationActionHasNavigationDelegate webView:didFinishNavigation:]):
3669         (-[NavigationActionHasNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3670         (TEST):
3671
3672 2018-07-20  Commit Queue  <commit-queue@webkit.org>
3673
3674         Unreviewed, rolling out r233943, r233988, r234004, and
3675         r234012.
3676         https://bugs.webkit.org/show_bug.cgi?id=187856
3677
3678         webkitpy tests are failing to build lldbWebKitTester
3679         (Requested by ryanhaddad on #webkit).
3680
3681         Reverted changesets:
3682
3683         "Provide an lldb type summary for WebCore::Color"
3684         https://bugs.webkit.org/show_bug.cgi?id=187776
3685         https://trac.webkit.org/changeset/233943
3686
3687         "Provide an lldb type summary for WebCore::Color"
3688         https://bugs.webkit.org/show_bug.cgi?id=187776
3689         https://trac.webkit.org/changeset/233988
3690
3691         "Provide an lldb type summary for WebCore::Color"
3692         https://bugs.webkit.org/show_bug.cgi?id=187776
3693         https://trac.webkit.org/changeset/234004
3694
3695         "Provide an lldb type summary for WebCore::Color"
3696         https://bugs.webkit.org/show_bug.cgi?id=187776
3697         https://trac.webkit.org/changeset/234012
3698
3699 2018-07-20  Philippe Normand  <pnormand@igalia.com>
3700
3701         [GTK][WPE] enable-media-capabilities websetting
3702         https://bugs.webkit.org/show_bug.cgi?id=187847
3703
3704         Reviewed by Carlos Garcia Campos.
3705
3706         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3707         (testWebKitSettings): Unit test for the new enable-media-capabilities setting.
3708
3709 2018-07-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3710
3711         [GLIB] jsc_context_evaluate_in_object() should receive an instance when a JSCClass is given
3712         https://bugs.webkit.org/show_bug.cgi?id=187798
3713
3714         Reviewed by Michael Catanzaro.
3715
3716         Update test cases to the new API and use a destroy function and vtable in the test case of calling
3717         jsc_context_evaluate_in_object() with a JSCClass.
3718
3719         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3720         (testJSCEvaluateInObject):
3721
3722 2018-07-19  Ross Kirsling  <ross.kirsling@sony.com>
3723
3724         TestWTF.WTF.StringConcatenate_Unsigned fails for unsigned short on Windows
3725         https://bugs.webkit.org/show_bug.cgi?id=187712
3726
3727         Reviewed by Fujii Hironori.
3728
3729         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
3730         Mark result of unsigned short test case as platform-specific,
3731         since Windows' behavior is actually *less* surprising here.
3732
3733 2018-07-19  Lucas Forschler  <lforschler@apple.com>
3734
3735         Teach the AWS Lambda to use the [minified]-platforms database
3736         https://bugs.webkit.org/show_bug.cgi?id=187817
3737         
3738         Reviewed by David Kilzer.
3739
3740         * WebKitArchiveSupport/lambda/register-archive-in-dynamodb.py:
3741         (lambda_handler): Add support for the platforms.webkit.org database
3742         * WebKitArchiveSupport/lambda/register-minified-s3-archive-in-dynamodb.py:
3743         (lambda_handler): Add support for the minified-platforms.webkit.org database
3744
3745 2018-07-19  Dean Jackson  <dino@apple.com>
3746
3747         Provide an lldb type summary for WebCore::Color
3748         https://bugs.webkit.org/show_bug.cgi?id=187776
3749
3750         Dan Bates helped me with this attempted fix. Fingers crossed!
3751
3752         * Scripts/build-lldbwebkittester:
3753
3754 2018-07-19  Stephan Szabo  <stephan.szabo@sony.com>
3755
3756         [WinCairo] Support DEVELOPER_MODE for allowing inspection of web inspector
3757         https://bugs.webkit.org/show_bug.cgi?id=187786
3758
3759         Reviewed by Fujii Hironori.
3760
3761         * Scripts/webkitdirs.pm:
3762         (generateBuildSystemFromCMakeProject): Turn on DEVELOPER_MODE
3763         for WinCairo builds.
3764
3765 2018-07-19  Dean Jackson  <dino@apple.com>
3766
3767         Provide an lldb type summary for WebCore::Color
3768         https://bugs.webkit.org/show_bug.cgi?id=187776
3769
3770         Another attempted build fix for Debug.
3771
3772         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3773         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj:
3774
3775 2018-07-19  Thomas Denney  <tdenney@apple.com>
3776
3777         [WHLSL] The interpreter doesn't support boolean short-circuiting
3778         https://bugs.webkit.org/show_bug.cgi?id=187779
3779
3780         Reviewed by Alex Christensen.
3781
3782         * WebGPUShadingLanguageRI/Evaluator.js:
3783         (Evaluator.prototype.visitLogicalExpression): RHS is only evaluated when necessary
3784         * WebGPUShadingLanguageRI/Test.js:
3785         (tests.booleanShortcircuiting): Adds 4 tests for the evaluation of logical expresions
3786
3787 2018-07-19  Dean Jackson  <dino@apple.com>
3788
3789         Provide an lldb type summary for WebCore::Color
3790         https://bugs.webkit.org/show_bug.cgi?id=187776
3791
3792         Attempted build fix.
3793
3794         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3795
3796 2018-07-19  Brady Eidson  <beidson@apple.com>
3797
3798         Add an SPI policy action to allow clients to explicitly ask for a new process on a navigation.
3799         https://bugs.webkit.org/show_bug.cgi?id=187789
3800
3801         Reviewed by Andy Estes.
3802
3803         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3804         (-[PSONNavigationDelegate init]):
3805         (-[PSONNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3806
3807 2018-07-19  Thibault Saunier  <tsaunier@igalia.com>
3808
3809         [Flatpak] Let flatpak process handle SIGINT
3810         https://bugs.webkit.org/show_bug.cgi?id=187521
3811
3812         Reviewed by Philippe Normand.
3813
3814         Ensuring that flatpak process ends properly and that the sandbox is teard down.
3815         It also avoids showing usless backtrace to the end user and makes gdb
3816         much more usable.
3817
3818         Also make flatpakutils not verbose by default
3819
3820         * flatpak/flatpakutils.py:
3821         (disable_signals):
3822         (WebkitFlatpak.run_in_sandbox):
3823         (WebkitFlatpak.run_gdb):
3824
3825 2018-07-18  Stephan Szabo  <stephan.szabo@sony.com>
3826
3827         Unreviewed. Fix contributors entry.
3828
3829         * Scripts/webkitpy/common/config/contributors.json:
3830
3831 2018-07-18  Dean Jackson  <dino@apple.com>
3832
3833         Provide an lldb type summary for WebCore::Color
3834         https://bugs.webkit.org/show_bug.cgi?id=187776
3835
3836         Reviewed by Dan Bates.
3837
3838         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj: Link against WebKit
3839             to get to WebCore.
3840         * lldb/lldbWebKitTester/main.cpp:
3841         (testSummaryProviders): Create some Color objects for testing.
3842
3843         * lldb/lldb_webkit.py: Add a Color summary provider.
3844         (__lldb_init_module):
3845         (WebCoreColor_SummaryProvider):
3846         (WebCoreColorProvider):
3847         (WebCoreColorProvider.__init__):
3848         (WebCoreColorProvider._is_extended):
3849         (WebCoreColorProvider._is_valid):
3850         (WebCoreColorProvider._is_semantic):
3851         (WebCoreColorProvider._to_string_extended):
3852         (WebCoreColorProvider.to_string):
3853
3854         * lldb/lldb_webkit_unittest.py: Tests.
3855         (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):
3856         (TestSummaryProviders):
3857         (TestSummaryProviders.serial_test_WebCoreColorProvider_invalid_color):
3858         (TestSummaryProviders.serial_test_WebCoreColorProvider_extended_color):
3859         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgb_color):
3860         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgba_color):
3861
3862 2018-07-18  Truitt Savell  <tsavell@apple.com>
3863
3864         Unreviewed, rolling out r233934.
3865
3866         Revision caused 5 webkitpy failures on Mac and broke webkitpy
3867         testing on iOS simulator
3868
3869         Reverted changeset:
3870
3871         "Provide an lldb type summary for WebCore::Color"
3872         https://bugs.webkit.org/show_bug.cgi?id=187776
3873         https://trac.webkit.org/changeset/233934
3874
3875 2018-07-18  Chris Dumez  <cdumez@apple.com>
3876
3877         REGRESSION (r233897): CrashTracer: com.apple.WebKit.WebContent.Development at com.apple.WebKit: WKBooleanGetValue + 9
3878         https://bugs.webkit.org/show_bug.cgi?id=187784
3879         <rdar://problem/42329230>
3880
3881         Reviewed by Brady Eidson.
3882
3883         When process swapping on navigation, WebPageProxy::reattachToWebProcess() unregisters the page as a MessageReceiver
3884         from the old WebProcessProxy and registers itself as a MessageReceiver for the new WebProcessProxy instead. This
3885         means that after this point, IPC sent by the previous WebProcess to its WebPageProxy will fail.
3886
3887         When we process swap, we also navigate the page in the old WebProcess to about:blank, when the navigation to
3888         about:blank would complete, the WebKitTestRunner's injected bundle would try and send IPC to the WebPageProxy
3889         which would fail and would cause WKBundlePagePostSynchronousMessageForTesting() to return a null result. WKTR
3890         would crash when dereferencing this null result. This patch addresses this by dealing with the potential null
3891         result.
3892
3893         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3894         (WTR::InjectedBundle::shouldProcessWorkQueue const):
3895
3896 2018-07-18  Dean Jackson  <dino@apple.com>
3897
3898         Provide an lldb type summary for WebCore::Color
3899         https://bugs.webkit.org/show_bug.cgi?id=187776
3900
3901         Reviewed by Dan Bates.
3902
3903         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj: Link against WebKit
3904             to get to WebCore.
3905         * lldb/lldbWebKitTester/main.cpp:
3906         (testSummaryProviders): Create some Color objects for testing.
3907
3908         * lldb/lldb_webkit.py: Add a Color summary provider.
3909         (__lldb_init_module):
3910         (WebCoreColor_SummaryProvider):
3911         (WebCoreColorProvider):
3912         (WebCoreColorProvider.__init__):
3913         (WebCoreColorProvider._is_extended):
3914         (WebCoreColorProvider._is_valid):
3915         (WebCoreColorProvider._is_semantic):
3916         (WebCoreColorProvider._to_string_extended):
3917         (WebCoreColorProvider.to_string):
3918
3919         * lldb/lldb_webkit_unittest.py: Tests.
3920         (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):
3921         (TestSummaryProviders):
3922         (TestSummaryProviders.serial_test_WebCoreColorProvider_invalid_color):
3923         (TestSummaryProviders.serial_test_WebCoreColorProvider_extended_color):
3924         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgb_color):
3925         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgba_color):
3926
3927 2018-07-18  Stephan Szabo  <stephan.szabo@sony.com>
3928
3929         Adding myself to contributors.json
3930
3931         Unreviewed contributors.json change.
3932
3933         * Scripts/webkitpy/common/config/contributors.json:
3934
3935 2018-07-18  Jer Noble  <jer.noble@apple.com>
3936
3937         -_beginAnimatedResizeWithUpdates: can leave view in bad state if called during an existing animation
3938         https://bugs.webkit.org/show_bug.cgi?id=187739
3939         <rdar://problem/42304518>
3940
3941         Reviewed by Tim Horton.
3942
3943         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
3944         (TEST):
3945
3946 2018-07-18  Jer Noble  <jer.noble@apple.com>
3947
3948         PiP from Element Fullscreen should match AVKit's behavior
3949         https://bugs.webkit.org/show_bug.cgi?id=187623
3950         <rdar://problem/41212379>
3951
3952         Reviewed by Jon Lee.
3953
3954         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3955         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.html: Added.
3956         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm: Added.
3957         (-[ExitFullscreenOnEnterPiPUIDelegate _webView:hasVideoInPictureInPictureDidChange:]):
3958         (-[ExitFullscreenOnEnterPiPUIDelegate _webViewDidEnterFullscreen:]):
3959         (-[ExitFullscreenOnEnterPiPUIDelegate _webViewDidExitFullscreen:]):
3960         (TestWebKitAPI::TEST):
3961
3962 2018-07-18  Aakash Jain  <aakash_jain@apple.com>
3963
3964         [ews-build] Add build step to run layout-test
3965         https://bugs.webkit.org/show_bug.cgi?id=187674
3966
3967         Reviewed by Lucas Forschler.
3968
3969         * BuildSlaveSupport/ews-build/steps.py:
3970         (RunWebKitTests): Added build step to run layout-tests. This is similar to current EWS.
3971         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3972         * BuildSlaveSupport/ews-build/factories.py: Added build-step to run layout-test in iOSSimulatorFactory.
3973
3974 2018-07-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3975
3976         Add SPI to defer running async script until after document load
3977         https://bugs.webkit.org/show_bug.cgi?id=187748
3978         <rdar://problem/42317378>
3979
3980         Reviewed by Ryosuke Niwa and Tim Horton.
3981
3982         Add an API test to verify that when the deferred async script configuration is set, async scripts will be
3983         executed after the DOMContentLoaded event.
3984
3985         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3986         * TestWebKitAPI/Tests/WebKitCocoa/RunScriptAfterDocumentLoad.mm: Added.
3987         (TEST):
3988
3989 2018-07-18  Charlie Turner  <cturner@igalia.com>
3990
3991         [WPE] Update WPEBackend in flatpak
3992         https://bugs.webkit.org/show_bug.cgi?id=187753
3993
3994         r233763 updated WPEBackend for the jhbuild, but not the flatpak. This
3995         caused WPE_BACKEND_CHECK_VERSION to not be defined, triggering a bug
3996         in the version guard,
3997
3998         #if defined(WPE_BACKEND_CHECK_VERSION) && WPE_BACKEND_CHECK_VERSION(0, 2, 0)
3999
4000         This doesn't work as intended, since the C preprocessor first expands
4001         all macro arguments in the #if expression before evaluating the
4002         expression. When WPE_BACKEND_CHECK_VERSION is not defined, this will
4003         lead to a syntax error and some head scratching.
4004
4005         A future patch should address the buggy macro check, when it is
4006         decided whether the assume the macro is always defined and bump
4007         the API requirements on WPEBackend, or to move the check into two
4008         conditionals to avoid the expansion problem.
4009
4010         Unreviewed build fix.
4011         
4012         * flatpak/org.webkit.WPE.yaml:
4013
4014 2018-07-18  Simon Fraser  <simon.fraser@apple.com>
4015
4016         Fix the parsing of colors in attributed string tests, and make it possible to dump the typing attributes
4017         https://bugs.webkit.org/show_bug.cgi?id=187747
4018
4019         Reviewed by Ryosuke Niwa.
4020         
4021         Add textInputController.attributedStringForTyping(), which returns a one-character
4022         attributed string whose attributes are the typing attributes, making it possible to
4023         test -[WebView typingAttributes].
4024         
4025         Sadly WebCore's convertObjcValueToValue() doesn't know how to convert NSDictionary,
4026         so we can't return -typingAttributes directly.
4027
4028         * DumpRenderTree/mac/TextInputControllerMac.m:
4029         (+[TextInputController isSelectorExcludedFromWebScript:]):
4030         (-[TextInputController attributedStringForTyping]):
4031
4032 2018-07-18  Carlos Garcia Campos  <cgarcia@igalia.com>
4033
4034         [GLIB] Add jsc_context_check_syntax() to GLib API
4035         https://bugs.webkit.org/show_bug.cgi?id=187694
4036
4037         Reviewed by Yusuke Suzuki.
4038
4039         Add a new test case.
4040
4041         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
4042         (testJSCCheckSyntax):
4043         (main):
4044
4045 2018-07-17  Sihui Liu  <sihui_liu@apple.com>
4046
4047         REGRESSION: [macOS Sierra] TestWebKitAPI.WebKit.WebsiteDataStoreCustomPaths is a flaky failure
4048         https://bugs.webkit.org/show_bug.cgi?id=187066
4049         <rdar://problem/41609065>
4050
4051         Reviewed by Chris Dumez.
4052
4053         In r232668 we started to do reload if web process crashes by default. As we killed the web 
4054         process explicitly in this test, if web page got reloaded, messages would be sent again, 
4055         and flag set in message handler could keep the test continue to evaluate the expectation 
4056         without waiting for removeDataOfTypes to finish.
4057
4058         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
4059         (-[WebsiteDataStoreCustomPathsMessageHandler webViewWebContentProcessDidTerminate:]):
4060         (TEST):
4061
4062 2018-07-17  Chris Dumez  <cdumez@apple.com>
4063
4064         Turn on PSON in WebKitTestRunner
4065         https://bugs.webkit.org/show_bug.cgi?id=186542
4066
4067         Reviewed by Brady Eidson.
4068
4069         Turn on PSON by default in WebKitTestRunner.
4070
4071         * WebKitTestRunner/TestOptions.h:
4072
4073 2018-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
4074
4075         Add an SPI hook to allow clients to yield document parsing and script execution
4076         https://bugs.webkit.org/show_bug.cgi?id=187682
4077         <rdar://problem/42207453>
4078
4079         Reviewed by Ryosuke Niwa.
4080
4081         Add a few tests to exercise the new document yield token SPI, verifying that clients can use the SPI to defer
4082         document load, and that doing so doesn't cause deferred `script` to execute in the wrong order (i.e. before
4083         synchronous script, or after "DOMContentLoaded").
4084
4085         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4086         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm: Added.
4087         (-[ParserYieldTokenPlugIn takeDocumentParserTokenAfterCommittingLoad]):
4088         (-[ParserYieldTokenPlugIn releaseDocumentParserToken]):
4089         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
4090         (-[ParserYieldTokenPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
4091         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
4092         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didFinishLoadForFrame:]):
4093
4094         Add an injected bundle object that knows how to take and release multiple document parser yield tokens.
4095
4096         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenTests.h: Added.
4097         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenTests.mm: Added.
4098         (+[ParserYieldTokenTestWebView webView]):
4099         (-[ParserYieldTokenTestWebView bundle]):
4100         (-[ParserYieldTokenTestWebView schemeHandler]):
4101         (-[ParserYieldTokenTestWebView didFinishDocumentLoad]):
4102         (-[ParserYieldTokenTestWebView didFinishLoad]):
4103         (waitForDelay):
4104         (TEST):
4105         * TestWebKitAPI/Tests/WebKitCocoa/TestURLSchemeHandler.h: Added.
4106         * TestWebKitAPI/Tests/WebKitCocoa/TestURLSchemeHandler.mm: Added.
4107         (-[TestURLSchemeHandler webView:startURLSchemeTask:]):
4108         (-[TestURLSchemeHandler webView:stopURLSchemeTask:]):
4109         (-[TestURLSchemeHandler setStartURLSchemeTaskHandler:]):
4110         (-[TestURLSchemeHandler startURLSchemeTaskHandler]):
4111         (-[TestURLSchemeHandler setStopURLSchemeTaskHandler:]):
4112         (-[TestURLSchemeHandler stopURLSchemeTaskHandler]):
4113
4114         Add a new test helper class to handle custom schemes via a block-based API.
4115
4116         * TestWebKitAPI/Tests/WebKitCocoa/text-with-async-script.html: Added.
4117
4118         New test HTML page that contains a deferred script element, a synchronous script element, another deferred
4119         script element, and then some text, images, and links.
4120
4121         * TestWebKitAPI/Tests/WebKitCocoa/text-with-deferred-script.html: Added.
4122
4123 2018-07-17  Truitt Savell  <tsavell@apple.com>
4124
4125         Adding myself to Contributors.json
4126
4127         Unreviewed
4128
4129         * Scripts/webkitpy/common/config/contributors.json:
4130
4131 2018-07-17  Aditya Keerthi  <akeerthi@apple.com>
4132
4133         [macOS] TestWebKitAPI.PictureInPicture.WKUIDelegate is timing out
4134         https://bugs.webkit.org/show_bug.cgi?id=187730
4135
4136         Reviewed by Jer Noble.
4137
4138         This regression was introduced by r233865. PIP can now only be initiated from a
4139         window that is on screen.
4140
4141         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
4142         (TestWebKitAPI::TEST):
4143
4144 2018-07-17  John Wilander  <wilander@apple.com>
4145
4146         Add completion handlers to TestRunner functions setStatisticsLastSeen(), setStatisticsPrevalentResource(), setStatisticsVeryPrevalentResource(), setStatisticsHasHadUserInteraction(), and setStatisticsHasHadNonRecentUserInteraction()
4147         https://bugs.webkit.org/show_bug.cgi?id=187710
4148         <rdar://problem/42252757>
4149
4150         Reviewed by Chris Dumez.
4151
4152         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4153         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4154         (WTR::InjectedBundle::didReceiveMessageToPage):
4155         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4156         (WTR::TestRunner::setStatisticsLastSeen):
4157         (WTR::TestRunner::statisticsCallDidSetLastSeenCallback):
4158         (WTR::TestRunner::setStatisticsPrevalentResource):
4159         (WTR::TestRunner::statisticsCallDidSetPrevalentResourceCallback):
4160         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
4161         (WTR::TestRunner::statisticsCallDidSetVeryPrevalentResourceCallback):
4162         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
4163         (WTR::TestRunner::setStatisticsHasHadNonRecentUserInteraction):
4164         (WTR::TestRunner::statisticsCallDidSetHasHadUserInteractionCallback):
4165         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4166         * WebKitTestRunner/TestController.cpp:
4167         (WTR::TestController::setStatisticsLastSeen):
4168         (WTR::TestController::setStatisticsPrevalentResource):
4169         (WTR::TestController::setStatisticsVeryPrevalentResource):
4170         (WTR::TestController::setStatisticsHasHadUserInteraction):
4171         (WTR::TestController::setStatisticsHasHadNonRecentUserInteraction):
4172         * WebKitTestRunner/TestInvocation.cpp:
4173         (WTR::TestInvocation::didSetLastSeen):
4174         (WTR::TestInvocation::didSetPrevalentResource):
4175         (WTR::TestInvocation::didSetVeryPrevalentResource):
4176         (WTR::TestInvocation::didSetHasHadUserInteraction):
4177         (WTR::TestInvocation::didSetHasHadNonRecentUserInteraction):
4178         * WebKitTestRunner/TestInvocation.h:
4179
4180 2018-07-16  Jeremy Jones  <jeremyj@apple.com>
4181
4182         Fix API Test failures introduced by r233865
4183         https://bugs.webkit.org/show_bug.cgi?id=187720
4184
4185         Unreviewed APITest fix after r233865.
4186
4187         Fullscreen can now only be initiated from a window that is on screen.
4188
4189         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
4190         (TestWebKitAPI::TEST):
4191         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm:
4192         (TestWebKitAPI::TEST):
4193
4194 2018-07-11  Dean Jackson  <dino@apple.com>
4195
4196         Allow removal of white backgrounds
4197         https://bugs.webkit.org/show_bug.cgi?id=187574
4198         <rdar://problem/41146792>
4199
4200         Reviewed by Simon Fraser.
4201
4202         Add a new menu item for punching out white backgrounds in MiniBrowser.
4203         In WebKitTestRunner, expose the new setting and hook that up to
4204         drawing a background in the WebView.
4205
4206         * MiniBrowser/mac/AppDelegate.m:
4207         (defaultConfiguration): Add _punchOutWhiteBackgroundsInDarkMode.
4208
4209         * MiniBrowser/mac/SettingsController.h: Ditto.
4210         * MiniBrowser/mac/SettingsController.m:
4211         (-[SettingsController _populateMenu]):
4212         (-[SettingsController validateMenuItem:]):
4213         (-[SettingsController togglePunchOutWhiteBackgroundsInDarkMode:]):
4214         (-[SettingsController punchOutWhiteBackgroundsInDarkMode]):
4215
4216         * MiniBrowser/mac/WK1BrowserWindowController.m:
4217         (-[WK1BrowserWindowController didChangeSettings]): Set the new preference.
4218
4219         * WebKitTestRunner/PlatformWebView.h: Expose a drawsBackground property.
4220         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Null implementation.
4221         (WTR::PlatformWebView::drawsBackground const):
4222         (WTR::PlatformWebView::setDrawsBackground):
4223         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp: Ditto.
4224         (WTR::PlatformWebView::drawsBackground const):
4225         (WTR::PlatformWebView::setDrawsBackground):
4226      &