[EFL] Add ARM64 build support
[WebKit-https.git] / Tools / ChangeLog
1 2014-03-25  Gabor Rapcsanyi  <rgabor@webkit.org>
2
3         [EFL] Add ARM64 build support
4         https://bugs.webkit.org/show_bug.cgi?id=130506
5
6         Rubber stamped by Gyuyoung Kim.
7
8         * Scripts/webkitdirs.pm:
9         (isARM): Detect aarch64 as ARM.
10
11 2014-03-25  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
12
13         [webkitpy] Improve _parse_bug_description to recognize more descriptions
14         https://bugs.webkit.org/show_bug.cgi?id=130137
15
16         Reviewed by Csaba Osztrogonác.
17
18         * Scripts/webkitpy/common/checkout/changelog.py:
19         (ChangeLogEntry._parse_bug_description):
20         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
21         (test_parse_log_entries_from_changelog):
22         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
23         (CheckoutTest.test_commit_info_for_revision):
24
25 2014-03-24  Andy Estes  <aestes@apple.com>
26
27         Fix the iOS build of TestWebKitAPI.
28
29         * TestWebKitAPI/Configurations/Base.xcconfig:
30         * TestWebKitAPI/PlatformUtilities.h:
31
32 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
33
34         Fix prepare-ChangeLog after r166156.
35         https://bugs.webkit.org/show_bug.cgi?id=130674
36
37         Reviewed by Darin Adler.
38
39         * Scripts/prepare-ChangeLog:
40         (generateFunctionLists):
41         (extractLineRangeBeforeChange):
42
43 2014-03-24  Andy Estes  <aestes@apple.com>
44
45         [iOS] Download support by CFURLDownloadRef under USE(CFNETWORK).
46         https://bugs.webkit.org/show_bug.cgi?id=129322
47
48         Reviewed by Anders Carlsson.
49
50         Add an API test suite for _WKDownload.
51
52         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
53         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: Added.
54         (-[DownloadDelegate initWithSourceURL:]):
55         (-[DownloadDelegate sourceURL]):
56         (-[DownloadDelegate _downloadDidStart:]):
57         (-[DownloadDelegate _download:didReceiveResponse:]):
58         (-[DownloadDelegate _download:didReceiveData:]):
59         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
60         (-[DownloadDelegate _downloadDidFinish:]):
61         (TEST):
62         (runTestWithNavigationDelegate):
63         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
64         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
65
66 2014-03-24  Joseph Pecoraro  <pecoraro@apple.com>
67
68         filter-build-webkit: reduce unfiltered output
69         https://bugs.webkit.org/show_bug.cgi?id=130485
70
71         Reviewed by Brent Fulgham.
72
73         * Scripts/filter-build-webkit:
74         (shouldIgnoreLine):
75
76 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
77
78         prepare-ChangeLog should list functions that have been removed too.
79         https://bugs.webkit.org/show_bug.cgi?id=130508
80
81         Reviewed by Darin Adler.
82
83         The prepare-ChangeLog does not list the deleted functions in the Changelog.
84         We have to read the functions and the line ranges of them from the source
85         before the change, then search for overlaps between them and the changed
86         line ranges from diff.
87
88         * Scripts/prepare-ChangeLog:
89         (originalFile): Get original source command.
90         (generateFunctionLists): Collect deleted functions too.
91         (generateFunctionListsByRanges): Duplicated code is moved to a separate subroutine.
92         (extractLineRangeBeforeChange): Extract line ranges from the original source to get
93         deleted functions ranges too.
94         (extractLineRange): Renamed to extractLineRangeAfterChange.
95
96 2014-03-23  Hyowon Kim  <hw1008.kim@samsung.com>
97
98         Move all EFL typedefs into EflTypedefs.h.
99         https://bugs.webkit.org/show_bug.cgi?id=130511
100
101         Reviewed by Gyuyoung Kim.
102
103         * TestWebKitAPI/PlatformWebView.h: Remove EFL typedefs.
104         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
105         * WebKitTestRunner/PlatformWebView.h: Ditto.
106
107 2014-03-21  Simon Fraser  <simon.fraser@apple.com>
108
109         Don't flush compositing layers within FrameView::willPaintContents()
110         https://bugs.webkit.org/show_bug.cgi?id=130627
111         <rdar://problem/16368869>
112
113         Reviewed by Sam Weinig.
114         
115         Fix DRT to correctly render tests with layers now that FrameView::paintContents
116         does not flush.
117         
118         Move the -[WebView displayIfNeeded] from -[FrameLoadDelegate webView:didFinishLoadForFrame:]
119         into an explicit function called before dumping. 
120         
121         Then explicitly call _flushCompositingChanges to ensure that GraphicsLayer changes
122         are flushed to CA. They will be pushed to the window by snapshotting.
123
124         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
125         Fix weird path to IOKit.framework.
126         * DumpRenderTree/mac/DumpRenderTree.mm:
127         (updateDisplay):
128         (dump):
129         * DumpRenderTree/mac/FrameLoadDelegate.mm:
130         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): Fix parameter name.
131         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Remove display call.
132
133 2014-03-21  David Kilzer  <ddkilzer@apple.com>
134
135         fix-blink-patch: tool to fix up renamed directory paths in Blink
136         <http://webkit.org/b/130609>
137
138         Reviewed by Ryosuke Niwa.
139
140         Usage: cat blink.patch | fix-blink-patch | svn-apply
141
142         * Scripts/fix-blink-patch: Added.
143
144 2014-03-21  Darin Adler  <darin@apple.com>
145
146         Remove use of deprecatedCharacters in WebKit API tests
147         https://bugs.webkit.org/show_bug.cgi?id=130602
148
149         Reviewed by Antti Koivisto.
150
151         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
152         (TestWebKitAPI::expectBuilderContent): Use characters8/16 instead of deprecatedCharacters.
153         (TestWebKitAPI::expectEmpty): Use characters8.
154         (TestWebKitAPI::TEST): Use characters8 instead of deprecatedCharacters in most cases.
155
156         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
157         Removed the test that is entirely about 16-bit conversion since that's basically a test of
158         the deprecatedCharacters function itself, which we are about to delete.
159
160 2014-03-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
161
162         [webkitpy] Fix has_valid_reviewer()
163         https://bugs.webkit.org/show_bug.cgi?id=130589
164
165         Reviewed by Csaba Osztrogonác.
166
167         * Scripts/webkitpy/common/checkout/changelog.py:
168         (ChangeLogEntry.has_valid_reviewer):
169         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
170         (test_has_valid_reviewer):
171         * Scripts/webkitpy/common/config/committers.py:
172         (CommitterList._reviewer_only):
173         (CommitterList.committer_by_name):
174         (CommitterList.reviewer_by_email):
175         (CommitterList):
176         (CommitterList.reviewer_by_name):
177
178 2014-03-21  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
179
180         Add cache support for jhbuild
181         https://bugs.webkit.org/show_bug.cgi?id=130588
182
183         Reviewed by Csaba Osztrogonác.
184
185         * jhbuild/jhbuildrc_common.py:
186         (init): Jhbuild can now save the dependencies locally, if the JHBUILD_MIRROR environment variable is set.
187
188 2014-03-21  Xabier Rodriguez Calvar  <calvaris@igalia.com>
189
190         [CMake] Add support for MAX_CPU_LOAD translated to -l in ninja and make
191         https://bugs.webkit.org/show_bug.cgi?id=130504
192
193         Reviewed by Martin Robinson.
194
195         * Scripts/build-webkit: Add the maxCPULoad() to the makeArgs in
196         CMake if not specified.
197         * Scripts/webkitdirs.pm:
198         (determineMaxCPULoad): Read MAX_CPU_LOAD as maxCPULoad.
199         (maxCPULoad): determineMaxCPULoad and return maxCPULoad.
200
201 2014-03-21  Andreas Kling  <akling@apple.com>
202
203         RetainPtr API test should use CFArray instead of CFString for testing.
204         <rdar://problem/16384899>
205
206         Unreviewed bot fix.
207
208         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
209         (TestWebKitAPI::TEST):
210         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
211         (TestWebKitAPI::TEST):
212
213 2014-03-20  Hyowon Kim  <hw1008.kim@samsung.com>
214
215         Move to using std::unique_ptr for EFL objects.
216         https://bugs.webkit.org/show_bug.cgi?id=129853
217
218         Reviewed by Gyuyoung Kim.
219
220         EflUniquePtr is a template alias of std::unique_ptr
221         with a custom deleter for each Efl Objects, which is motivated by GUniquePtr.
222         This patch replaces uses of OwnPtr and PassOwnPtr for Efl objects with EflUniquePtr.
223
224         * DumpRenderTree/efl/DumpRenderTree.cpp:
225         (main):
226         * ImageDiff/efl/ImageDiff.cpp:
227         (initEfl):
228         (main):
229
230 2014-03-20  Ryuan Choi  <ryuan.choi@samsung.com>
231
232         Unreviewed buildfix after r165983 for non Cocoa platforms
233
234         Renamed WKPreferencesPrivate.h to WKPreferencesRefPrivate.h
235
236         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
237         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
238         * WebKitTestRunner/TestController.cpp:
239
240 2014-03-20  Zan Dobersek  <zdobersek@igalia.com>
241
242         [GTK][CMake] Add support for building with Clang
243         https://bugs.webkit.org/show_bug.cgi?id=130260
244
245         Reviewed by Martin Robinson.
246
247         * TestWebKitAPI/CMakeLists.txt: When building with Clang TestWebKitAPI should be
248         built with GTEST_HAS_TR1_TUPLE defined to 0 to avoid build failures occuring in the
249         included GTest framework headers.
250         * gtk/generate-gtkdoc:
251         (prepare_environment_for_gtkdoc_generation): Don't modify the CFLAGS env anymore
252         in case of using Clang since that is now set by the CMake rule.
253
254 2014-03-19  Simon Fraser  <simon.fraser@apple.com>
255
256         Expose text and page zoom in WK2 SPI, and hook them up in MiniBrowser
257         https://bugs.webkit.org/show_bug.cgi?id=130476
258
259         Reviewed by Anders Carlsson.
260         
261         Hook up page/text zoom in MiniBrowser, make reload work, remove some logging.
262
263         * MiniBrowser/mac/WK1BrowserWindowController.m:
264         (-[WK1BrowserWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
265         Remove log.
266         * MiniBrowser/mac/WK2BrowserWindowController.m:
267         (-[WK2BrowserWindowController awakeFromNib]):
268         (-[WK2BrowserWindowController validateMenuItem:]):
269         (-[WK2BrowserWindowController reload:]):
270         Hook up reload.
271         (-[WK2BrowserWindowController toggleZoomMode:]):
272         (-[WK2BrowserWindowController resetZoom:]):
273         (-[WK2BrowserWindowController canResetZoom]):
274         (-[WK2BrowserWindowController currentZoomFactor]):
275         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
276         (-[WK2BrowserWindowController canZoomIn]):
277         (-[WK2BrowserWindowController canZoomOut]):
278
279 2014-03-19  Alexey Proskuryakov  <ap@apple.com>
280
281         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
282         https://bugs.webkit.org/show_bug.cgi?id=130463
283
284         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Disable the test.
285
286 2014-03-18  Samuel White  <samuel_white@apple.com>
287
288         AX: Not able to use arrow keys to read text with VoiceOver before selection is set someplace (anyplace).
289         https://bugs.webkit.org/show_bug.cgi?id=130250
290
291         Reviewed by Chris Fleizach.
292
293         Added ability to toggle enhanced accessibility on and off to support tests that require it.
294
295         * DumpRenderTree/AccessibilityController.cpp:
296         (enableEnhancedAccessibilityCallback):
297         (getEnhancedAccessibilityEnabledCallback):
298         (AccessibilityController::getJSClass):
299         * DumpRenderTree/AccessibilityController.h:
300         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
301         (AccessibilityController::enableEnhancedAccessibility):
302         (AccessibilityController::enhancedAccessibilityEnabled):
303         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
304         (AccessibilityController::enableEnhancedAccessibility):
305         (AccessibilityController::enhancedAccessibilityEnabled):
306         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
307         (AccessibilityController::enableEnhancedAccessibility):
308         (AccessibilityController::enhancedAccessibilityEnabled):
309         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
310         (AccessibilityController::enableEnhancedAccessibility):
311         (AccessibilityController::enhancedAccessibilityEnabled):
312         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
313         (WTR::AccessibilityController::enableEnhancedAccessibility):
314         (WTR::AccessibilityController::enhancedAccessibilityEnabled):
315         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
316         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
317
318 2014-03-18  Filip Pizlo  <fpizlo@apple.com>
319
320         Unreviewed, add some contributors, and fix Nadav's entry (he's not really a reviewer
321         yet).
322
323         * Scripts/webkitpy/common/config/contributors.json:
324
325 2014-03-18  Joseph Pecoraro  <pecoraro@apple.com>
326
327         Web Inspector: Remove stale ReportMemoryUsagePlugin
328         https://bugs.webkit.org/show_bug.cgi?id=130405
329
330         Reviewed by Andreas Kling.
331
332         This clang plugin looks like it was used for the old Inspector memory
333         instrumentation that was removed. So the tool can be removed.
334
335         * clang/ReportMemoryUsagePlugin/CMakeLists.txt: Removed.
336         * clang/ReportMemoryUsagePlugin/Makefile: Removed.
337         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp: Removed.
338         * clang/ReportMemoryUsagePlugin/tests/Source/WebCore/Test.cpp: Removed.
339
340 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
341
342         webkit-patch land shouldn't add a reviewer for unreviewed build fixes
343         https://bugs.webkit.org/show_bug.cgi?id=130220
344
345         Reviewed by Csaba Osztrogonác.
346
347         * Scripts/webkitpy/common/checkout/changelog.py:
348         (ChangeLog.set_reviewer):
349         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
350         (test_set_reviewer):
351
352 2014-03-17  Filip Pizlo  <fpizlo@apple.com>
353
354         More FTL enabling.
355
356         Rubber stamped by Dan Bernstein.
357
358         * Tools/Scripts/build-webkit:
359
360 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
361
362         Renable pagination mode in WK2 MiniBrowser
363         https://bugs.webkit.org/show_bug.cgi?id=130374
364
365         Reviewed by Anders Carlsson.
366         
367         Put the implementation of togglePaginationMode: back, and correctly
368         enable the menu item.
369
370         * MiniBrowser/mac/WK2BrowserWindowController.m:
371         (-[WK2BrowserWindowController validateMenuItem:]):
372         (-[WK2BrowserWindowController isPaginated]):
373         (-[WK2BrowserWindowController togglePaginationMode:]):
374
375 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
376
377         Add --reset option to Tools/Scripts/set-webkit-configuration script
378         https://bugs.webkit.org/show_bug.cgi?id=130401
379
380         Reviewed by Csaba Osztrogonác.
381
382         * Scripts/set-webkit-configuration:
383
384 2014-03-18  Alberto Garcia  <berto@igalia.com>
385
386         [GTK] [CMake] build-webkit-options.txt is not generated during a fresh build
387         https://bugs.webkit.org/show_bug.cgi?id=130388
388
389         Reviewed by Sergio Villar Senin.
390
391         * Scripts/webkitdirs.pm:
392         (shouldRemoveCMakeCache): make sure that the build directory
393         exists before attempting to create a file in it.
394
395 2014-03-18  Robert Plociennik  <r.plociennik@samsung.com>
396
397         [EFL] fontconfig-2.8.0 is not compliant with C++11 leading to a build break
398         https://bugs.webkit.org/show_bug.cgi?id=130336
399
400         Reviewed by Gyuyoung Kim.
401
402         Compilation with gcc 4.8.x results in 'invalid suffix on literal; C++11
403         requires a space between literal and string macro [-Wliteral-suffix]'
404         warning treated as error.
405
406         This patch applies a solution from r162448 to the EFL port.
407
408         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
409         * efl/jhbuild.modules: Added appropriate patch section.
410
411 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
412
413         webkitpy test rebaseline.
414
415         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
416         (MainTest.test_default_args):
417
418 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
419
420         --profile should imply --test-runner-count=1 in run-perf-tests
421         https://bugs.webkit.org/show_bug.cgi?id=130375
422
423         Reviewed by Benjamin Poulain.
424
425         Use the test runner count of 1 when --profile is specified but not --test-runner-count.
426
427         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
428         (PerfTestsRunner._parse_args): Use -1 as the default value.
429         (PerfTestsRunner._collect_tests): If --test-runner-count is set (i.e. it's a positive value),
430         then use that value. Otherwise, if it's never set and --profile is present, test-runner-count
431         should be 1.
432
433 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
434
435         Address some style nits.
436
437         * MiniBrowser/mac/WK2BrowserWindowController.m:
438
439 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
440
441         Add transparent window support back into MiniBrowser
442         https://bugs.webkit.org/show_bug.cgi?id=130363
443
444         Reviewed by Anders Carlsson.
445         
446         Re-enable transparent window support for WK2.
447
448         * MiniBrowser/mac/WK2BrowserWindowController.m:
449         (-[WK2BrowserWindowController validateMenuItem:]):
450         (-[WK2BrowserWindowController toggleTransparentWindow:]):
451
452 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
453
454         Fix the 32-bit build; make the open panel make a WK1 window.
455
456         * MiniBrowser/mac/AppDelegate.m:
457         (-[BrowserAppDelegate openDocument:]):
458
459 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
460
461         Convert MiniBrowser to use WKWebView API
462         https://bugs.webkit.org/show_bug.cgi?id=130061
463
464         Reviewed by Anders Carlsson.
465         
466         Convert the MiniBrowser WK2 window to use WebKit2 API as much
467         as possible.
468         
469         Some functionality was removed temporarily:
470             - text zoom, page zoom
471             - reload
472             - pagination mode
473             - transparent window
474             - dumping source
475             - window.open support
476             - beforeUnload panel
477             - find in page
478
479         * MiniBrowser/mac/AppDelegate.h:
480         * MiniBrowser/mac/AppDelegate.m:
481         (-[BrowserAppDelegate init]):
482         (-[BrowserAppDelegate newWindow:]):
483         (-[BrowserAppDelegate applicationWillTerminate:]):
484         (-[BrowserAppDelegate openDocument:]):
485         * MiniBrowser/mac/WK2BrowserWindowController.h:
486         * MiniBrowser/mac/WK2BrowserWindowController.m:
487         (-[WK2BrowserWindowController awakeFromNib]):
488         (-[WK2BrowserWindowController dealloc]):
489         (-[WK2BrowserWindowController fetch:]):
490         (-[WK2BrowserWindowController validateMenuItem:]):
491         (-[WK2BrowserWindowController reload:]):
492         (-[WK2BrowserWindowController goBack:]):
493         (-[WK2BrowserWindowController goForward:]):
494         (-[WK2BrowserWindowController toggleZoomMode:]):
495         (-[WK2BrowserWindowController resetZoom:]):
496         (-[WK2BrowserWindowController canResetZoom]):
497         (-[WK2BrowserWindowController dumpSourceToConsole:]):
498         (-[WK2BrowserWindowController togglePaginationMode:]):
499         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
500         (-[WK2BrowserWindowController windowShouldClose:]):
501         (-[WK2BrowserWindowController applicationTerminating]):
502         (-[WK2BrowserWindowController currentZoomFactor]):
503         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
504         (-[WK2BrowserWindowController toggleTransparentWindow:]):
505         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
506         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
507         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
508         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
509         (-[WK2BrowserWindowController find:]):
510         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
511         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
512         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
513         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
514         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
515         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
516         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
517         * WebKitTestRunner/PlatformWebView.h:
518         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
519         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
520
521 2014-03-17  Zan Dobersek  <zdobersek@igalia.com>
522
523         Use RunLoop objects through references instead of pointers
524         https://bugs.webkit.org/show_bug.cgi?id=130313
525
526         Reviewed by Andreas Kling.
527
528         Adjust the code accordingly now that RunLoop::current() and RunLoop::main()
529         return RunLoop reference instead of a pointer.
530
531         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
532         (loadedCallback):
533         (clickedCallback):
534
535 2014-03-17  Tim Horton  <timothy_horton@apple.com>
536
537         sort-export-file --help doesn't work (missing 'use')
538         https://bugs.webkit.org/show_bug.cgi?id=130338
539
540         Reviewed by Anders Carlsson.
541
542         * Scripts/sort-export-file:
543         Add a missing 'use', and fix a typo in an error message.
544
545 2014-03-17  Martin Robinson  <mrobinson@igalia.com>
546
547         [GTK][CMake] Ensure that HAVE_GTK_UNIX_PRINTING is defined when appropriate
548         https://bugs.webkit.org/show_bug.cgi?id=130155
549
550         Reviewed by Philippe Normand.
551
552         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add GTK_UNIX_PRINT flags to the build.
553
554 2014-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
555
556         [GTK] MiniBrowser fails to load injected bundle lib
557         https://bugs.webkit.org/show_bug.cgi?id=130332
558
559         Reviewed by Anders Carlsson.
560
561         This is because WEBKIT_INJECTED_BUNDLE_PATH env var is set too late.
562
563         * MiniBrowser/gtk/main.c:
564         (main): Make sure WEBKIT_INJECTED_BUNDLE_PATH is set before a web
565         process is spawn.
566
567 2014-03-16  Kim Byung Jun  <bj1987.kim@samsung.com>
568
569         [EFL] Enable TOUCH_SLIDER macro
570         https://bugs.webkit.org/show_bug.cgi?id=130185
571
572         Reviewed by Gyuyoung Kim.
573
574         * Scripts/webkitperl/FeatureList.pm:
575
576 2014-03-16  Zan Dobersek  <zdobersek@igalia.com>
577
578         [GTK][CMake] Build with -fno-rtti
579         https://bugs.webkit.org/show_bug.cgi?id=130261
580
581         Reviewed by Martin Robinson.
582
583         * TestWebKitAPI/CMakeLists.txt: Build TestWebKitAPI with GTEST_HAS_RTTI macro
584         defined to 0 to prevent typeid use in included GTest headers.
585
586 2014-03-16  Brian Burg  <bburg@apple.com>
587
588         Web Inspector: vended backend commands file should be generated as part of the build
589         https://bugs.webkit.org/show_bug.cgi?id=130110
590
591         Reviewed by Timothy Hatcher.
592
593         * Scripts/build-webkit: build WebInspectorUI after WebCore but before WebKit.
594
595 2014-03-16  Diego Pino García  <dpino@igalia.com>
596
597         [GTK] Minibrowser: Add shortcuts for reloading page and reloading page ignoring cache
598         https://bugs.webkit.org/show_bug.cgi?id=128999
599
600         Reviewed by Philippe Normand.
601
602         * MiniBrowser/gtk/BrowserWindow.c:
603         (reloadPage):
604         (reloadPageIgnoringCache):
605         (browser_window_init):
606
607 2014-03-15  Martin Robinson  <mrobinson@igalia.com>
608
609         [GTK] Improve ninja detection in webkitdirs.pm
610         https://bugs.webkit.org/show_bug.cgi?id=129902
611
612         Reviewed by Daniel Bates.
613
614         * Scripts/webkitdirs.pm:
615         (canUseNinja): Use which instead of trying to invoke ninja directly. This also allows
616         us to look for ninja-build as well.
617
618 2014-03-14  Maciej Stachowiak  <mjs@apple.com>
619
620         Replace "Apple Computer, Inc." with "Apple Inc." in copyright headers
621         https://bugs.webkit.org/show_bug.cgi?id=130276
622         <rdar://problem/16266927>
623         
624         Reviewed by Simon Fraser.
625
626         * BuildSlaveSupport/build-launcher-app:
627         * BuildSlaveSupport/build-launcher-dmg:
628         * DumpRenderTree/DumpRenderTree.h:
629         * DumpRenderTree/DumpRenderTreePrefix.h:
630         * DumpRenderTree/GCController.cpp:
631         * DumpRenderTree/GCController.h:
632         * DumpRenderTree/JavaScriptThreading.cpp:
633         * DumpRenderTree/JavaScriptThreading.h:
634         * DumpRenderTree/PixelDumpSupport.cpp:
635         * DumpRenderTree/PixelDumpSupport.h:
636         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
637         * DumpRenderTree/TestRunner.cpp:
638         * DumpRenderTree/TestRunner.h:
639         * DumpRenderTree/WorkQueue.cpp:
640         * DumpRenderTree/WorkQueue.h:
641         * DumpRenderTree/WorkQueueItem.h:
642         * DumpRenderTree/atk/AccessibilityCallbacks.h:
643         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
644         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
645         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
646         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
647         * DumpRenderTree/cg/PixelDumpSupportCG.h:
648         * DumpRenderTree/efl/EditingCallbacks.cpp:
649         * DumpRenderTree/efl/EditingCallbacks.h:
650         * DumpRenderTree/efl/EventSender.cpp:
651         * DumpRenderTree/efl/EventSender.h:
652         * DumpRenderTree/efl/GCControllerEfl.cpp:
653         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
654         * DumpRenderTree/efl/TestRunnerEfl.cpp:
655         * DumpRenderTree/gtk/DumpRenderTree.cpp:
656         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
657         * DumpRenderTree/gtk/EditingCallbacks.cpp:
658         * DumpRenderTree/gtk/EditingCallbacks.h:
659         * DumpRenderTree/gtk/EventSender.cpp:
660         * DumpRenderTree/gtk/EventSender.h:
661         * DumpRenderTree/gtk/GCControllerGtk.cpp:
662         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
663         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp:
664         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h:
665         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
666         * DumpRenderTree/gtk/TextInputController.cpp:
667         * DumpRenderTree/gtk/TextInputController.h:
668         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL:
669         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
670         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
671         * DumpRenderTree/mac/AppleScriptController.h:
672         * DumpRenderTree/mac/AppleScriptController.m:
673         * DumpRenderTree/mac/CheckedMalloc.cpp:
674         * DumpRenderTree/mac/CheckedMalloc.h:
675         * DumpRenderTree/mac/DumpRenderTree.mm:
676         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
677         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
678         * DumpRenderTree/mac/DumpRenderTreeMac.h:
679         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
680         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
681         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
682         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
683         * DumpRenderTree/mac/EditingDelegate.h:
684         * DumpRenderTree/mac/EditingDelegate.mm:
685         * DumpRenderTree/mac/EventSendingController.h:
686         * DumpRenderTree/mac/EventSendingController.mm:
687         * DumpRenderTree/mac/FrameLoadDelegate.h:
688         * DumpRenderTree/mac/FrameLoadDelegate.mm:
689         * DumpRenderTree/mac/GCControllerMac.mm:
690         * DumpRenderTree/mac/MockWebNotificationProvider.h:
691         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
692         * DumpRenderTree/mac/NavigationController.h:
693         * DumpRenderTree/mac/NavigationController.m:
694         * DumpRenderTree/mac/ObjCController.h:
695         * DumpRenderTree/mac/ObjCController.m:
696         * DumpRenderTree/mac/ObjCPlugin.h:
697         * DumpRenderTree/mac/ObjCPlugin.m:
698         * DumpRenderTree/mac/ObjCPluginFunction.h:
699         * DumpRenderTree/mac/ObjCPluginFunction.m:
700         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
701         * DumpRenderTree/mac/PolicyDelegate.h:
702         * DumpRenderTree/mac/PolicyDelegate.mm:
703         * DumpRenderTree/mac/ResourceLoadDelegate.h:
704         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
705         * DumpRenderTree/mac/TestRunnerMac.mm:
706         * DumpRenderTree/mac/TextInputController.h:
707         * DumpRenderTree/mac/TextInputController.m:
708         * DumpRenderTree/mac/UIDelegate.h:
709         * DumpRenderTree/mac/UIDelegate.mm:
710         * DumpRenderTree/mac/WorkQueueItemMac.mm:
711         * DumpRenderTree/win/DRTDataObject.cpp:
712         * DumpRenderTree/win/DRTDataObject.h:
713         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
714         * DumpRenderTree/win/DRTDropSource.cpp:
715         * DumpRenderTree/win/DRTDropSource.h:
716         * DumpRenderTree/win/DraggingInfo.h:
717         * DumpRenderTree/win/DumpRenderTree.cpp:
718         * DumpRenderTree/win/DumpRenderTreeWin.h:
719         * DumpRenderTree/win/EditingDelegate.cpp:
720         * DumpRenderTree/win/EditingDelegate.h:
721         * DumpRenderTree/win/EventSender.cpp:
722         * DumpRenderTree/win/EventSender.h:
723         * DumpRenderTree/win/FrameLoadDelegate.cpp:
724         * DumpRenderTree/win/FrameLoadDelegate.h:
725         * DumpRenderTree/win/GCControllerWin.cpp:
726         * DumpRenderTree/win/HistoryDelegate.cpp:
727         * DumpRenderTree/win/HistoryDelegate.h:
728         * DumpRenderTree/win/MD5.cpp:
729         * DumpRenderTree/win/MD5.h:
730         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
731         * DumpRenderTree/win/PolicyDelegate.cpp:
732         * DumpRenderTree/win/PolicyDelegate.h:
733         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
734         * DumpRenderTree/win/ResourceLoadDelegate.h:
735         * DumpRenderTree/win/TestRunnerWin.cpp:
736         * DumpRenderTree/win/TextInputController.cpp:
737         * DumpRenderTree/win/TextInputController.h:
738         * DumpRenderTree/win/TextInputControllerWin.cpp:
739         * DumpRenderTree/win/UIDelegate.cpp:
740         * DumpRenderTree/win/UIDelegate.h:
741         * DumpRenderTree/win/WorkQueueItemWin.cpp:
742         * EWebLauncher/main.c:
743         * GtkLauncher/main.c:
744         * ImageDiff/efl/ImageDiff.cpp:
745         * ImageDiff/gtk/ImageDiff.cpp:
746         * MiniBrowser/gtk/main.c:
747         * Scripts/SpacingHeuristics.pm:
748         * Scripts/VCSUtils.pm:
749         * Scripts/bisect-builds:
750         * Scripts/build-dumprendertree:
751         * Scripts/build-jsc:
752         * Scripts/build-webkit:
753         * Scripts/check-dom-results:
754         * Scripts/check-for-exit-time-destructors:
755         * Scripts/check-for-global-initializers:
756         * Scripts/commit-log-editor:
757         * Scripts/compare-timing-files:
758         * Scripts/debug-minibrowser:
759         * Scripts/debug-safari:
760         * Scripts/do-file-rename:
761         * Scripts/find-extra-includes:
762         * Scripts/generate-coverage-data:
763         * Scripts/make-script-test-wrappers:
764         * Scripts/malloc-tree:
765         * Scripts/old-run-webkit-tests:
766         * Scripts/parse-malloc-history:
767         * Scripts/report-include-statistics:
768         * Scripts/resolve-ChangeLogs:
769         * Scripts/run-bindings-tests:
770         * Scripts/run-iexploder-tests:
771         * Scripts/run-javascriptcore-tests:
772         * Scripts/run-jsc:
773         * Scripts/run-launcher:
774         * Scripts/run-leaks:
775         * Scripts/run-mangleme-tests:
776         * Scripts/run-minibrowser:
777         * Scripts/run-pageloadtest:
778         * Scripts/run-regexp-tests:
779         * Scripts/run-safari:
780         * Scripts/run-sunspider:
781         * Scripts/run-webkit-app:
782         * Scripts/sampstat:
783         * Scripts/set-webkit-configuration:
784         * Scripts/sort-Xcode-project-file:
785         * Scripts/sort-export-file:
786         * Scripts/split-file-by-class:
787         * Scripts/sunspider-compare-results:
788         * Scripts/svn-apply:
789         * Scripts/svn-create-patch:
790         * Scripts/svn-unapply:
791         * Scripts/test-webkit-scripts:
792         * Scripts/update-javascriptcore-test-results:
793         * Scripts/update-webkit:
794         * Scripts/update-webkit-auxiliary-libs:
795         * Scripts/update-webkit-dependency:
796         * Scripts/update-webkit-localizable-strings:
797         * Scripts/update-webkit-support-libs:
798         * Scripts/update-webkit-wincairo-libs:
799         * Scripts/webkit-build-directory:
800         * Scripts/webkitdirs.pm:
801         (installedSafariPath):
802         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
803         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
804         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
805         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
806         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
807         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
808         * Scripts/webkitperl/features.pm:
809         * Scripts/webkitperl/httpd.pm:
810         * Scripts/webkitpy/bindings/main.py:
811         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
812         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
813         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
814         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
815         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
816         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
817         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
818         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
819         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
820         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.h:
821         * WebKitTestRunner/PixelDumpSupport.cpp:
822         * WebKitTestRunner/PixelDumpSupport.h:
823         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
824         * WinLauncher/WinLauncher.cpp:
825         * WinLauncher/WinLauncher.h:
826         * WinLauncher/stdafx.cpp:
827         * WinLauncher/stdafx.h:
828
829 2014-03-14  Filip Pizlo  <fpizlo@apple.com>
830
831         Sometimes we need to be explicit about the SDK when running ranlib on Darwin
832         https://bugs.webkit.org/show_bug.cgi?id=130265
833
834         Reviewed by Michael Saboff.
835
836         * Scripts/build-webkit:
837         * Scripts/copy-webkitlibraries-to-product-directory:
838
839 2014-03-14  Landry Breuil  <landry@openbsd.org>
840
841         Recognize openbsd/netbsd and am64 archs in Tools/Scripts.
842         Also allow to set MAKE in the environment.
843         https://bugs.webkit.org/show_bug.cgi?id=129991
844
845         Reviewed by Andreas Kling.
846
847         * Scripts/webkitdirs.pm:
848         (determineArchitecture):
849         (determineNumberOfCPUs):
850         (isBSD):
851         (buildAutotoolsProject):
852         * Scripts/webkitpy/common/system/platforminfo.py:
853         (PlatformInfo.__init__):
854         (PlatformInfo.is_openbsd):
855         (PlatformInfo):
856         (PlatformInfo.is_netbsd):
857         (PlatformInfo._determine_os_name):
858
859 2014-03-14  Dean Jackson  <dino@apple.com>
860
861         Remove libWebKitSystemInterfaceLion.a
862         https://bugs.webkit.org/show_bug.cgi?id=130254
863
864         Reviewed by Geoffrey Garen and Andreas Kling.
865
866         No need to copy the Lion libraries into the build.
867
868         * Scripts/copy-webkitlibraries-to-product-directory:
869
870 2014-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
871
872         [EFL][MiniBrowser] Revise help messages of command line parameters
873         https://bugs.webkit.org/show_bug.cgi?id=130222
874
875         Reviewed by Csaba Osztrogonác.
876
877         Correct the default value description and make help messages to be consistent.
878
879         * MiniBrowser/efl/main.c:
880
881 2014-03-12  Sergio Villar Senin  <svillar@igalia.com>
882
883         Rename DEFINE_STATIC_LOCAL to DEPRECATED_DEFINE_STATIC_LOCAL
884         https://bugs.webkit.org/show_bug.cgi?id=129612
885
886         Reviewed by Darin Adler.
887
888         For new code use static NeverDestroyed<T> instead.
889
890         * DumpRenderTree/JavaScriptThreading.cpp:
891         (javaScriptThreadsMutex):
892         (javaScriptThreads):
893         * DumpRenderTree/efl/EventSender.cpp:
894         (touchPointList):
895         (delayedEventQueue):
896         * DumpRenderTree/win/FrameLoadDelegate.cpp:
897         (delegatesWithDelayedWork):
898         * Scripts/check-for-exit-time-destructors:
899         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
900         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
901         (testsMap):
902
903 2014-03-13  Sanghyup Lee  <sh53.lee@samsung.com>
904
905         [EFL][WK2] Fix compilation warning in Minibrowser
906         https://bugs.webkit.org/show_bug.cgi?id=130132
907
908         Reviewed by Csaba Osztrogonác.
909
910         Replace mktemp() with mkstemp() to fix compilation warning in MiniBrowser.
911
912         * MiniBrowser/efl/main.c:
913         (on_download_request):
914
915 2014-03-13  Filip Pizlo  <fpizlo@apple.com>
916
917         FTL should support IsBlah
918         https://bugs.webkit.org/show_bug.cgi?id=130202
919
920         Reviewed by Geoffrey Garen.
921         
922         Running existing JSRegress tests with noInline gives us coverage for these
923         changes. Chances are, this will also give coverage for other interesting things
924         as well.
925
926         * Scripts/run-jsc-stress-tests:
927
928 2014-03-12  Brian Burg  <bburg@apple.com>
929
930         Web Inspector: Remove unused callId parameter from evaluateInWebInspector
931         https://bugs.webkit.org/show_bug.cgi?id=129744
932
933         Reviewed by Timothy Hatcher.
934
935         * DumpRenderTree/TestRunner.cpp:
936         (evaluateInWebInspectorCallback):
937         * DumpRenderTree/TestRunner.h:
938         * DumpRenderTree/efl/TestRunnerEfl.cpp:
939         (TestRunner::evaluateInWebInspector):
940         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
941         (TestRunner::evaluateInWebInspector):
942         * DumpRenderTree/mac/TestRunnerMac.mm:
943         (TestRunner::evaluateInWebInspector):
944         * DumpRenderTree/win/TestRunnerWin.cpp:
945         (TestRunner::evaluateInWebInspector):
946         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
947         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
948         (WTR::TestRunner::evaluateInWebInspector):
949         * WebKitTestRunner/InjectedBundle/TestRunner.h:
950
951 2014-03-13  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
952
953         [GTK] build-webkit shouldn't show error message when ninja isn't installed
954         https://bugs.webkit.org/show_bug.cgi?id=130129
955
956         Reviewed by Csaba Osztrogonác.
957
958         * Scripts/webkitdirs.pm:
959         (canUseNinja): Redirecting stderr to /dev/null
960
961 2014-03-13  Andres Gomez  <agomez@igalia.com>
962
963         [GTK] "Tools/jhbuild/jhbuild-wrapper --gtk" build fails even after running Tools/gtk/install-dependencies due to missing proper libxml2 python bindings
964         https://bugs.webkit.org/show_bug.cgi?id=130092
965
966         Reviewed by Csaba Osztrogonác.
967
968         Added "python-dev" as dependency for deb based distros. It is
969         already present for rpm based distros. This dependency will allow
970         libxml2 to generate its python bindings, needed by gtk-doc.
971
972         * gtk/install-dependencies:
973
974 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
975
976         Unreviewed. Fix GTK+ cmake build after r165488.
977
978         * MiniBrowser/gtk/CMakeLists.txt: Add CMAKE_BINARY_DIR to include dirs.
979
980 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
981
982         [GTK][CMAKE] Remove compile warnings about GTK+ deprecated API
983         https://bugs.webkit.org/show_bug.cgi?id=130014
984
985         Reviewed by Martin Robinson.
986
987         Include cmake or autotools config header.
988
989         * MiniBrowser/gtk/BrowserDownloadsBar.c:
990         * MiniBrowser/gtk/BrowserSearchBar.c:
991         * MiniBrowser/gtk/BrowserWindow.c:
992         * MiniBrowser/gtk/main.c:
993
994 2014-03-12  Commit Queue  <commit-queue@webkit.org>
995
996         Unreviewed, rolling out r165471.
997         https://bugs.webkit.org/show_bug.cgi?id=130139
998
999         Didn't really fix the issue and broke another bot (Requested
1000         by mrobinson on #webkit).
1001
1002         Reverted changeset:
1003
1004         "[CMake] Newer versions of CMake cannot find older versions of
1005         Freetype"
1006         https://bugs.webkit.org/show_bug.cgi?id=130107
1007         http://trac.webkit.org/changeset/165471
1008
1009 2014-03-11  Filip Pizlo  <fpizlo@apple.com>
1010
1011         It should be possible to build WebKit with FTL on iOS
1012         https://bugs.webkit.org/show_bug.cgi?id=130116
1013
1014         Reviewed by Dan Bernstein.
1015
1016         * Scripts/build-webkit:
1017         * Scripts/copy-webkitlibraries-to-product-directory:
1018
1019 2014-03-12  Brent Fulgham  <bfulgham@apple.com>
1020
1021         [Win] Remove use of QTSDK
1022         https://bugs.webkit.org/show_bug.cgi?id=130049
1023
1024         Reviewed by Darin Adler.
1025
1026         * DumpRenderTree/win/DumpRenderTree.cpp:
1027         (initialize): Remove QuickTime code.
1028         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't grab logs from
1029         building QTMovieWin.
1030
1031 2014-03-12  Martin Robinson  <mrobinson@igalia.com>
1032
1033         [GTK][CMAKE] Too verbose build output
1034         https://bugs.webkit.org/show_bug.cgi?id=130076
1035
1036         Reviewed by Carlos Garcia Campos.
1037
1038         Instead of building with cmake --build which isn't smart about pretty printing and
1039         colors, we build with a script which calls the proper build command.
1040
1041         * Scripts/webkitdirs.pm:
1042         (buildCMakeGeneratedProject): For GTK+ call the script that we generate during
1043         the CMake configuration pass.
1044
1045 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
1046
1047         [CMake] Newer versions of CMake cannot find older versions of Freetype
1048         https://bugs.webkit.org/show_bug.cgi?id=130107
1049
1050         Reviewed by Gustavo Noronha Silva.
1051
1052         * gtk/jhbuildrc: Work around a bug in newer CMakes by giving the FREETYPE_DIR hint
1053         to CMake during jhbuild initialization.
1054
1055 2014-03-12  Zalan Bujtas  <zalan@apple.com>
1056
1057         Add hiDPI support for compositing content in DumpRenderTree/WebKitTestRunner
1058         https://bugs.webkit.org/show_bug.cgi?id=129961
1059
1060         Reviewed by Simon Fraser.
1061
1062         Now scaled content can go through the window capturing mechanism too for compositing content.
1063         AppleMagnifiedMode is redundant.
1064
1065         * DumpRenderTree/mac/DumpRenderTree.mm:
1066         (setDefaultsToConsistentValuesForTesting):
1067         (runTest):
1068         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1069         (createBitmapContextFromWebView):
1070         * WebKitTestRunner/PlatformWebView.h:
1071         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1072         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1073         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1074         (WTR::PlatformWebView::didInitializeClients):
1075         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1076         (WTR::PlatformWebView::forceWindowFramesChanged):
1077         * WebKitTestRunner/mac/main.mm:
1078         (setDefaultsToConsistentValuesForTesting):
1079
1080 2014-03-12  Anton Obzhirov  <a.obzhirov@samsung.com>
1081
1082         Unreviewed. Add myself as a committer.
1083
1084         * Scripts/webkitpy/common/config/contributors.json:
1085
1086 2014-03-12  Ryuan Choi  <ryuan.choi@samsung.com>
1087
1088         Unreviewed build fix on the EFL port when used lower version of ATK
1089
1090         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1091         (WTR::AccessibilityUIElement::y): Fixed typo.
1092
1093 2014-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
1094
1095         Some images are blank in the rebaseline server UI
1096         https://bugs.webkit.org/show_bug.cgi?id=130104
1097
1098         Reviewed by Tim Horton.
1099
1100         Let the server check for images in the 'retries' directory
1101         if it can't find an image otherwise.
1102
1103         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1104         (RebaselineHTTPRequestHandler.test_result):
1105
1106 2014-03-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1107
1108         [GTK][CMake] --update-gtk has no effect
1109         https://bugs.webkit.org/show_bug.cgi?id=130088
1110
1111         Reviewed by Philippe Normand.
1112
1113         * Scripts/webkitdirs.pm:
1114         (buildCMakeProjectOrExit): call update-webkitgtk-libs if --update-gtk has been passed
1115         as an argument.
1116
1117 2014-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
1118
1119         Add "System Font" to the list of whitelisted DRT fonts
1120         https://bugs.webkit.org/show_bug.cgi?id=130046
1121
1122         Reviewed by Darin Adler.
1123
1124         * DumpRenderTree/mac/DumpRenderTree.mm:
1125         (allowedFontFamilySet):
1126         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
1127
1128 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
1129
1130         [GTK] The jhbuild environment should set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_PATH
1131         https://bugs.webkit.org/show_bug.cgi?id=130064
1132
1133         Reviewed by Philippe Normand.
1134
1135         * efl/jhbuildrc: Remove duplicated code.
1136         * gtk/jhbuildrc: Remove duplicated code.
1137         * jhbuild/jhbuildrc_common.py:
1138         (init): Move duplicated code from jhbuildrc's and extend setting CMake environment variables to
1139         GTK+. We always set the CMAKE_LIBRARY_PATH, which should be harmless for EFL 32-bit systems.
1140         and is apparently necessary for GTK+.
1141
1142 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
1143
1144         check-webkit-style failed to complain about missing braces
1145         https://bugs.webkit.org/show_bug.cgi?id=34189
1146
1147         Reviewed by Ryosuke Niwa.
1148
1149         * Scripts/webkitpy/style/checkers/cpp.py:
1150         (check_braces):
1151         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1152         (WebKitStyleTest.test_braces):
1153
1154 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
1155
1156         Remove Qt cruft from style checker.
1157         https://bugs.webkit.org/show_bug.cgi?id=130085
1158
1159         Reviewed by Csaba Osztrogonác.
1160
1161         There is no 'foreach' keyword in c++. That was a Qt feature
1162         added in: http://trac.webkit.org/changeset/46113
1163         Qt was removed from WebKit, so we should remove the checks
1164         of this keyword from check-webkit-style scripts.
1165
1166         * Scripts/webkitpy/style/checkers/cpp.py:
1167         (check_spacing_for_function_call):
1168         (check_spacing):
1169         (check_braces):
1170         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1171         (CppStyleTest.test_mismatching_spaces_in_parens):
1172         (CppStyleTest.test_spacing_for_fncall):
1173         (WebKitStyleTest.test_braces):
1174
1175 2014-03-11  Martin Hodovan  <mhodovan@inf.u-szeged.hu>
1176
1177         [GTK] update-webkitgtk-libs needs itstool
1178         https://bugs.webkit.org/show_bug.cgi?id=130082
1179
1180         After http://trac.webkit.org/changeset/165110 WebKitGTK+ uses gtk-doc 1.20.
1181         itstool is a dependency of building gtk-doc from version 1.19, so it should
1182         be added to Tools/gtk/install-dependencies script, too.
1183
1184         Reviewed by Philippe Normand.
1185
1186         * gtk/install-dependencies:
1187
1188 2014-03-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1189
1190         webkitbot rollout ChangeLogs should be nicer
1191         https://bugs.webkit.org/show_bug.cgi?id=122654
1192
1193         Reviewed by Csaba Osztrogonác.
1194
1195         Added bug urls and descriptions of rolled out patches to the rollout changelog
1196         if they are present in the original changelog. Additionally removed the list of
1197         changed files and functions.
1198
1199         * Scripts/webkitpy/common/checkout/changelog.py:
1200         (ChangeLog.update_with_unreviewed_message): Cut off the list of modified files.
1201         * Scripts/webkitpy/common/checkout/checkout.py:
1202         (Checkout._changelog_data_for_revision): Store bug description.
1203         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1204         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1205         (CheckoutTest.test_commit_info_for_revision):
1206         * Scripts/webkitpy/common/checkout/commitinfo.py:
1207         (CommitInfo.bug_description): Added.
1208         (CommitInfo.to_json):
1209         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
1210         (CommitInfoTest.test_commit_info_creation):
1211         * Scripts/webkitpy/tool/commands/download.py:
1212         (AbstractRolloutPrepCommand._prepare_state): Store bug ids and descriptions of rolled
1213         out patches for creating rollout changelog.
1214         (CreateRollout._prepare_state): Remove obsolete comments and code, the bug id that
1215         caused the regression is stored in state["bug_blocked"] now.
1216         * Scripts/webkitpy/tool/commands/download_unittest.py:
1217         (test_prepare_rollout):
1218         (test_create_rollout_multiple_revision):
1219         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1220         (PrepareChangeLogForRevert._message_for_revert): Add bug urls and descriptions of
1221         rolled out patches to the changelog.
1222         (PrepareChangeLogForRevert.run):
1223         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
1224         (UpdateChangeLogsForRevertTest):
1225         (test_message_for_revert):
1226         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
1227         (ReopenBugAfterRollout.run):
1228
1229 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
1230
1231         [ATK] Adjust WKTR/DRT to use new API from ATK 2.11.90
1232         https://bugs.webkit.org/show_bug.cgi?id=130021
1233
1234         Reviewed by Mario Sanchez Prada.
1235
1236         Replace deprecated functions to use new API from ATK 2.11.90.
1237
1238         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1239         (AccessibilityUIElement::x):
1240         (AccessibilityUIElement::y):
1241         (AccessibilityUIElement::width):
1242         (AccessibilityUIElement::height):
1243         (AccessibilityUIElement::clickPointX):
1244         (AccessibilityUIElement::clickPointY):
1245         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1246         (WTR::AccessibilityUIElement::x):
1247         (WTR::AccessibilityUIElement::y):
1248         (WTR::AccessibilityUIElement::width):
1249         (WTR::AccessibilityUIElement::height):
1250         (WTR::AccessibilityUIElement::clickPointX):
1251         (WTR::AccessibilityUIElement::clickPointY):
1252
1253 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
1254
1255         [ATK] Expose aria-posinset and aria-setsize through object attributes
1256         https://bugs.webkit.org/show_bug.cgi?id=130011
1257
1258         Reviewed by Chris Fleizach.
1259
1260         Added missing implementation of numberAttributeValue both to WKTR and DRT.
1261
1262         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1263         (AccessibilityUIElement::numberAttributeValue):
1264         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1265         (WTR::AccessibilityUIElement::numberAttributeValue):
1266
1267 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
1268
1269         [Win] Unreviewed build fix.
1270
1271         Some bad Windows code was committed at some point that prevents the Apple Windows port
1272         from finding its runtime dependencies reliably.
1273
1274         * win/DLLLauncher/DLLLauncherMain.cpp:
1275         (appleApplicationSupportDirectory): Restored this function.
1276         (modifyPath): Update to use appleApplicationSupportDirectory function.
1277
1278 2014-03-10  Zoltan Horvath  <zoltan@webkit.org>
1279
1280         Let the user define the full address of the performance-site-server for uploading results
1281         https://bugs.webkit.org/show_bug.cgi?id=129819
1282
1283         Reviewed by Ryosuke Niwa.
1284
1285         Currently perftestsrunner.py assumes that the server uses https protocol all the time, which
1286         can be confusing. It's more straightforward, if you need to define explicitly the server's full
1287         address along with the protocol, when you're using this parameter. I added HTTPS as the default
1288         protocol for now, in order to avoid breaking the perf bots.
1289
1290         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1291         (_upload_json):
1292         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1293         (MainTest.test_upload_json):
1294
1295 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
1296
1297         [Win] Pass environment to Pre-Build, Pre-Link, and Post-Build Stages.
1298         https://bugs.webkit.org/show_bug.cgi?id=130023
1299
1300         Reviewed by Dean Jackson.
1301
1302         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add missing
1303         /SAFESEH flag to DLL launcher process.
1304
1305 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
1306
1307         RunGtkWebKitGObjectDOMBindingsAPIBreakTests should be added to the BuildAndTestFactory not the TestFactory
1308         https://bugs.webkit.org/show_bug.cgi?id=129980
1309
1310         Reviewed by Carlos Garcia Campos.
1311
1312         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add RunGtkWebKitGObjectDOMBindingsAPIBreakTests to the correct factory.
1313
1314 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
1315
1316         [GTK] Remove the WebView source-mode WebKit1 test
1317         https://bugs.webkit.org/show_bug.cgi?id=129976
1318
1319         Reviewed by Carlos Garcia Campos.
1320
1321         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Remove the source-mode test.
1322
1323 2014-03-08  Martin Robinson  <mrobinson@igalia.com>
1324
1325         Unreviewed build fix for GTKbuild after the switch to CMake
1326
1327         * gtk/common.py:
1328         (is_cmake_build): Like r165284, we need to assume CMake by default, since the
1329         test-only bot doesn't have any build files.
1330
1331 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
1332
1333         [GTK] built-product-archive does not handle GTK+ CMake build
1334         https://bugs.webkit.org/show_bug.cgi?id=129941
1335
1336         * BuildSlaveSupport/built-product-archive:
1337         (archiveBuiltProduct): Fix the build by adding support to built-product-archive for
1338         the CMake build.
1339
1340 2014-03-07  Lorenzo Tilve  <ltilve@igalia.com>
1341
1342         [GTK] Include CMake into install-dependencies script
1343         https://bugs.webkit.org/show_bug.cgi?id=129909
1344
1345         Reviewed by Martin Robinson.
1346
1347         As since r165267 buid-webkit uses CMake by default, the dependency
1348         with 'cmake' package should be introduced.
1349
1350         * gtk/install-dependencies: Ditto.
1351
1352 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
1353
1354         REGRESSION(165267): Broke a webkitpy unit tests
1355         https://bugs.webkit.org/show_bug.cgi?id=129904
1356
1357         Reviewed by Jon Honeycutt.
1358
1359         * Scripts/webkitpy/port/gtk.py: Flip the default test to assume CMake by default.
1360         (GtkPort._is_cmake_build):
1361
1362 2014-03-07  Andres Gomez  <agomez@igalia.com>
1363
1364         [GTK] webkit-patch setup-git-clone fails even after running Tools/gtk/install-dependencies
1365         https://bugs.webkit.org/show_bug.cgi?id=129893
1366
1367         Reviewed by Martin Robinson.
1368
1369         Added "git-svn" as dependency for deb based distros and,
1370         additionally, "subversion" for rpm based distros.
1371
1372         * gtk/install-dependencies:
1373
1374 2014-03-07  Roger Fong  <roger_fong@apple.com>
1375
1376         Remove dummy setSystemWebGLLoadPolicy client method.
1377         https://bugs.webkit.org/show_bug.cgi?id=129873.
1378
1379         Reviewed by Dean Jackson.
1380
1381         * WebKitTestRunner/TestController.cpp:
1382         (WTR::TestController::createWebViewWithOptions):
1383
1384 2014-03-07  Mark Hahnenberg  <mhahnenberg@apple.com>
1385
1386         run-jsc-stress-tests doesn't eagerly report test failures when using the shell runner
1387         https://bugs.webkit.org/show_bug.cgi?id=129886
1388
1389         Reviewed by Mark Lam.
1390
1391         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Added a "verbose" mode to the shell runner.
1392         If we're in verbose mode, then we don't redirect any output when running each test. If we're not
1393         in verbose mode then we redirect stdout to /dev/null and allow any stderr output through.
1394         * Scripts/run-jsc-stress-tests: Redirect any sort of error output to stderr so that it will 
1395         make it through when in non-verbose mode.
1396
1397 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
1398
1399         [GTK] buid-webkit should use CMake by default
1400         https://bugs.webkit.org/show_bug.cgi?id=129855
1401
1402         Reviewed by Carlos Garcia Campos.
1403
1404         Make the CMake build the default GTK+ build when using build-webkit. This will
1405         ensure that all bots are using CMake. We do this by swapping --gtk and --gtkcmake,
1406         so that we have --gtk and --gtkautotools.
1407
1408         * Scripts/webkitdirs.pm: Swap --gtkcmake/--gtk for --gtk/--gtkautotools.
1409         * Scripts/webkitpy/port/gtk.py: Ditto.
1410
1411 2014-03-06  Martin Robinson  <mrobinson@igalia.com>
1412
1413         [CMake] [GTK] Build with ninja when it is available
1414         https://bugs.webkit.org/show_bug.cgi?id=129805
1415
1416         Reviewed by Philippe Normand.
1417
1418         * Scripts/webkitdirs.pm:
1419         (canUseNinja): Added this helper which tries to execute Ninja, in an effort to determine
1420         if it's available on the system.
1421         (cmakeGeneratedBuildfile): Return the path to the generated build file. Only Unix support ATM.
1422         (generateBuildSystemFromCMakeProject): For GTK+ compile with Ninja when possible.
1423
1424 2014-03-06  Filip Pizlo  <fpizlo@apple.com>
1425
1426         If the FTL is build-time enabled then it should be run-time enabled.
1427
1428         Rubber stamped by Geoffrey Garen.
1429
1430         * Scripts/run-jsc-stress-tests:
1431
1432 2014-03-06  Mark Hahnenberg  <mhahnenberg@apple.com>
1433
1434         detectFailures in run-jsc-stress-tests can report everything was ok if too many tests fail
1435         https://bugs.webkit.org/show_bug.cgi?id=129837
1436
1437         Reviewed by Michael Saboff.
1438
1439         ls test_fail_* can fail if there are too many files that match. We then swallow that error, which makes everything seem ok.
1440         The fix is to use find instead of ls like we do in shell-runner.sh.
1441
1442         * Scripts/run-jsc-stress-tests:
1443
1444 2014-03-06  Joseph Pecoraro  <pecoraro@apple.com>
1445
1446         filter-build-webkit should not strip .o
1447         https://bugs.webkit.org/show_bug.cgi?id=129614
1448
1449         Reviewed by Dean Jackson.
1450
1451         This makes it much easier to jump from the failing output at
1452         the end back up to the compile errors earlier in the output.
1453
1454         * Scripts/filter-build-webkit:
1455
1456 2014-03-06  Anders Carlsson  <andersca@apple.com>
1457
1458         Build WebKit2 before building WebKit
1459         https://bugs.webkit.org/show_bug.cgi?id=129831
1460         <rdar://problem/15920020>
1461
1462         Reviewed by Dan Bernstein.
1463
1464         * Scripts/build-webkit:
1465         Always build WebKit2 and make sure to build it before WebKit when building on Mac.
1466
1467 2014-03-06  ChangSeok Oh  <changseok.oh@collabora.com>
1468
1469         make-3.82 fails to build on ARM/Linux
1470         https://bugs.webkit.org/show_bug.cgi?id=107926
1471
1472         Reviewed by Martin Robinson.
1473
1474         Some ARM/Linux systems don't support PAGE_SIZE macro so that it causes a build failure.
1475         The related bug reporting is here. https://lists.debian.org/debian-kernel/2014/02/msg00274.html
1476         To avoid this, I propose to use sysconf(_SC_PAGESIZE) instead of PAGE_SIZE
1477         where it is not defined. See more details, http://linux.die.net/man/2/getpagesize
1478
1479         * gtk/patches/make-3.82-arg-list-length.patch:
1480
1481 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1482
1483         [GTK] Close the page when the view is disposed instead of when finalized
1484         https://bugs.webkit.org/show_bug.cgi?id=129783
1485
1486         Reviewed by Sergio Villar Senin.
1487
1488         Add test case but disabled for now because it's affetected by bug #129684.
1489
1490         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
1491         (testProcessPerWebView):
1492
1493 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1494
1495         [GTK] MiniBrowser crashes when opening several urls passed as command line options
1496         https://bugs.webkit.org/show_bug.cgi?id=129738
1497
1498         Reviewed by Sergio Villar Senin.
1499
1500         The problem is that we are calling g_object_unref() for the
1501         WebKitWebSettings everytime we set it to a WebKitWebView, but the
1502         view only increases the reference counter when the settings is not
1503         the same it currently has. We should release our reference once.
1504
1505         * MiniBrowser/gtk/main.c:
1506         (createBrowserWindow):
1507         (main):
1508
1509 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1510
1511         [GTK][CMake] Tarball is created with wrong tarball paths
1512         https://bugs.webkit.org/show_bug.cgi?id=129496
1513
1514         Reviewed by Daniel Bates.
1515
1516         * gtk/make-dist.py:
1517         (Manifest.__init__): I inadvertently inverted the logic of these checks when
1518         landing the original patch with some suggestions from the reviewer. With the
1519         checks corrected, the tarball path is constructed properly.
1520
1521 2014-03-05  Jae Hyun Park  <jaepark@webkit.org>
1522
1523         Unreviewed. Update my email in contributors.json
1524
1525         * Scripts/webkitpy/common/config/contributors.json:
1526
1527 2014-03-05  Dean Jackson  <dino@apple.com>
1528
1529         [WebGL] Use WKSI to see what the system policy for WebGL is
1530         https://bugs.webkit.org/show_bug.cgi?id=129722
1531         <rdar://problem/15790542>
1532
1533         Reviewed by Tim Horton.
1534
1535         Dummy entry for setSystemWebGLLoadPolicy.
1536
1537         * WebKitTestRunner/TestController.cpp:
1538         (WTR::TestController::createWebViewWithOptions):
1539
1540 2014-03-03  Martin Robinson  <mrobinson@igalia.com>
1541
1542         [GTK][CMake] Generate documentation for the DOM bindings
1543         https://bugs.webkit.org/show_bug.cgi?id=126211
1544
1545         Reviewed by Carlos Garcia Campos.
1546
1547         * gtk/GNUmakefile.am: No longer generation sections and SGML files in the makefile.
1548         * gtk/generate-gtkdoc: Call the code from webkitdom.py to generate sections and SGML files.
1549         * gtk/generate-webkitdom-doc-files: Removed.
1550         * gtk/webkitdom.py: Moved WebKit GObject DOM bindings doc generation code here, so
1551         that it can be called by generate-gtkdoc.
1552
1553 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1554
1555         [GTK][CMake] build-webkit should rerun cmake if the Makefile is missing
1556         https://bugs.webkit.org/show_bug.cgi?id=129380
1557
1558         Reviewed by Philippe Normand.
1559
1560         * Scripts/webkitdirs.pm:
1561         (generateBuildSystemFromCMakeProject): Check for the existence of the Makefile before
1562         skipping CMake execution.
1563
1564 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1565
1566         [GTK] The jhbuild environment should have the latest stable release of gtk-doc
1567         https://bugs.webkit.org/show_bug.cgi?id=129651
1568
1569         Reviewed by Philippe Normand.
1570
1571         * gtk/jhbuild.modules: Add gtk-doc to the list of modules.
1572
1573 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1574
1575         [GTK] Give the WebKit GObject DOM bindings API break detection it's own buildbot bubble
1576         https://bugs.webkit.org/show_bug.cgi?id=129637
1577
1578         Reviewed by Carlos Garcia Campos.
1579
1580         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1581         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests): Added this test runner.
1582         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.commandComplete): Run the breakage test command and scan the output.
1583         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.evaluateCommand): Return failure if there is missing API (an API break).
1584         New API typically just requires a rebaseline and isn't necessarily a faiulre.
1585         (TestFactory.__init__): Add the test for GTK+.
1586         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Add a unit test for the new bubble.
1587
1588 2014-03-05  Krzysztof Czech  <k.czech@samsung.com>
1589
1590         [ATK] Expose missing functionalities of AtkTableCell to AT
1591         https://bugs.webkit.org/show_bug.cgi?id=129492
1592
1593         Reviewed by Mario Sanchez Prada.
1594
1595         Reducing some code by using new API of AtkTableCell.
1596
1597         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1598         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1599
1600 2014-03-04  Alex Christensen  <achristensen@webkit.org>
1601
1602         Preparing to run layout tests on Wincairo.
1603         https://bugs.webkit.org/show_bug.cgi?id=129709
1604
1605         Reviewed by Brent Fulgham.
1606
1607         * Scripts/webkitdirs.pm:
1608         (setPathForRunningWebKitApp):
1609         Add GStreamer directory for WinCairo running layout tests.
1610         * win/DLLLauncher/DLLLauncherMain.cpp:
1611         (modifyPath):
1612         Added the WinCairo bin32 or bin64 directory for running WinLauncher.
1613
1614 2014-03-04  Martin Robinson  <mrobinson@igalia.com>
1615
1616         [GTK] Simplify the GObject DOM bindings API break check into one step
1617         https://bugs.webkit.org/show_bug.cgi?id=129571
1618
1619         Reviewed by Carlos Garcia Campos.
1620
1621         * GNUmakefile.am: Add the API break check to 'make check.'
1622         * gtk/check-for-webkitdom-api-breaks: Added. A combination of the two removed scripts.
1623         * gtk/check-gdom-symbols: Removed.
1624         * gtk/webkitdom.py: Added.
1625         (header_name_list_from_gtkdoc_config_file): Gets the names of all headers from the gtkdoc config file.
1626         (get_all_webkitdom_symbol_files): Find the symbol files from the names.
1627
1628 2014-03-03  Simon Fraser  <simon.fraser@apple.com>
1629
1630         Add Jeremy Jones to the contributors list as a contributor.
1631
1632         * Scripts/webkitpy/common/config/contributors.json:
1633
1634 2014-03-03  Adenilson Cavalcanti  <cavalcantii@gmail.com>
1635
1636         Unreviewed. Update contact email.
1637         https://bugs.webkit.org/show_bug.cgi?id=129610
1638
1639         * Scripts/webkitpy/common/config/contributors.json:
1640
1641 2014-03-02  Brian Burg  <bburg@apple.com>
1642
1643         Web Inspector model tests load wrong inspector page under WebKitTestRunner
1644         https://bugs.webkit.org/show_bug.cgi?id=129460
1645
1646         Reviewed by Dan Bernstein.
1647
1648         Don't unconditionally open the inspector before running an inspector test.
1649         Instead, the test should request that the inspector open when it's ready.
1650
1651         This change was lost during a rebase, but is the same change made to
1652         DumpRenderTree.
1653
1654         * WebKitTestRunner/TestInvocation.cpp:
1655         (WTR::TestInvocation::invoke): 
1656
1657 2014-03-02  Darin Adler  <darin@apple.com>
1658
1659         Split TextIteratorBehavior into a separate header
1660         https://bugs.webkit.org/show_bug.cgi?id=129578
1661
1662         Reviewed by Sam Weinig.
1663
1664         * Scripts/sort-export-file: Added special cases to the script so you can just paste link errors
1665         from WebKit in and the script will add them in as unconditional exports. This makes the "add"
1666         task easy, but the remove is still a bit of a pain.
1667
1668 2014-03-02  Darin Adler  <darin@apple.com>
1669
1670         Sort Mac platform export files so they merge better
1671         https://bugs.webkit.org/show_bug.cgi?id=129581
1672
1673         Reviewed by Sam Weinig.
1674
1675         * Scripts/sort-export-file: Added. Quickly whipped together script that sorts
1676         Mac export files in a "canonical" order for this project.
1677
1678 2014-02-28  Zalan Bujtas  <zalan@apple.com>
1679
1680         Add hiDPI support to DumpRenderTree/WebKitTestRunner without the need of reloading the test case.
1681         https://bugs.webkit.org/show_bug.cgi?id=129438
1682
1683         Reviewed by Simon Fraser.
1684
1685         'hidpi-' prefixed test cases now trigger 2x scale factor on the testing
1686         offscreen window. It makes testing subpixel rendering and positioning possible.
1687
1688         Both the offscreen window's and WebKit's scaling are set accordingly.
1689
1690         * DumpRenderTree/mac/DumpRenderTree.mm:
1691         (createWebViewAndOffscreenWindow): cleanup
1692         (destroyWebViewAndOffscreenWindow): cleanup
1693         (dumpRenderTree):
1694         (changeWindowScaleIfNeeded):
1695         (runTest):
1696         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1697         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1698         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): cleanup
1699         * WebKitTestRunner/PlatformWebView.h:
1700         * WebKitTestRunner/TestInvocation.cpp:
1701         (WTR::changeWindowScaleIfNeeded):
1702         (WTR::TestInvocation::invoke):
1703         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1704         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1705         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1706         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1707         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1708         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1709         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1710         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1711
1712 2014-02-28  Anders Carlsson  <andersca@apple.com>
1713
1714         Remove logging.
1715
1716         Reviewed by Dan Bernstein.
1717
1718         * MiniBrowser/mac/WK2BrowserWindowController.m:
1719         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNavigationAction:decisionHandler:]):
1720
1721 2014-02-28  Daniel Bates  <dabates@apple.com>
1722
1723         [iOS] DumpRenderTree Perl Support may build against wrong SDK and toolchain
1724         https://bugs.webkit.org/show_bug.cgi?id=129163
1725
1726         Reviewed by David Kilzer.
1727
1728         Fixes an issue where DumpRenderTree Perl Support may build with the specified
1729         iOS Simulator SDK and toolchain instead of using the OS X SDK and toolchain.
1730         This issue manifests itself in a build failure when building the IPhoneSimulatorNotification
1731         bundle.
1732
1733         Currently we build DumpRenderTree Perl Support with respect to the variable SDKROOT,
1734         which is specified either explicitly when building with MAKE(1) or implicitly by
1735         build-{dumprendertree, webkit}. Instead we should always build Perl Support using
1736         the OS X SDK and toolchain since the built products are only applicable to OS X.
1737
1738         * DumpRenderTree/ios/PerlSupport/Makefile:
1739
1740 2014-02-28  Commit Queue  <commit-queue@webkit.org>
1741
1742         Unreviewed, rolling out r164859.
1743         http://trac.webkit.org/changeset/164859
1744         https://bugs.webkit.org/show_bug.cgi?id=129483
1745
1746         caused WK1 crashes (DumpRenderTree) (Requested by zalan on
1747         #webkit).
1748
1749         * DumpRenderTree/mac/DumpRenderTree.mm:
1750         (createWebViewAndOffscreenWindow):
1751         (dumpRenderTree):
1752         (runTest):
1753         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1754         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1755         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
1756         * WebKitTestRunner/PlatformWebView.h:
1757         * WebKitTestRunner/TestInvocation.cpp:
1758         (WTR::TestInvocation::invoke):
1759         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1760         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1761         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1762         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1763         (-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):
1764
1765 2014-02-28  Zalan Bujtas  <zalan@apple.com>
1766
1767         Add hiDPI support to DumpRenderTree/WebKitTestRunner without the need of reloading the test case.
1768         https://bugs.webkit.org/show_bug.cgi?id=129438
1769
1770         Reviewed by Simon Fraser.
1771
1772         'hidpi-' prefixed test cases now trigger 2x scale factor on the testing
1773         offscreen window. It makes testing subpixel rendering and positioning possible.
1774
1775         Both the offscreen window's and WebKit's scaling are set accordingly.
1776
1777         * DumpRenderTree/mac/DumpRenderTree.mm:
1778         (createWebViewAndOffscreenWindow): unrelated cleanup.
1779         (destroyWebViewAndOffscreenWindow): unrelated cleanup.
1780         (dumpRenderTree):
1781         (changeOffscreenWindowScaleIfNeeded):
1782         (runTest):
1783         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1784         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1785         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): cleanup.
1786         * WebKitTestRunner/PlatformWebView.h:
1787         * WebKitTestRunner/TestInvocation.cpp:
1788         (WTR::changeOffscreenWindowScaleIfNeeded):
1789         (WTR::TestInvocation::invoke):
1790         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1791         (WTR::PlatformWebView::changeOffscreenWindowScaleIfNeeded):
1792
1793 2014-02-27  Brian Burg  <bburg@apple.com>
1794
1795         Web Inspector: model tests should use a special Test.html inspector page
1796         https://bugs.webkit.org/show_bug.cgi?id=129190
1797
1798         Reviewed by Timothy Hatcher.
1799
1800         Remove code that immediately opens the Web Inspector based on the file path of the test.
1801         Instead, the test page should request that the inspector open inside its `test()` method.
1802
1803         This change is necessary because otherwise, the inspector would be opened too early for
1804         InspectorController::isUnderTest to get set in time, so the normal Web Inspector page
1805         will get loaded instead of the minimal test page.
1806
1807         * DumpRenderTree/efl/DumpRenderTree.cpp:
1808         (createTestRunner):
1809         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1810         (runTest):
1811         * DumpRenderTree/mac/DumpRenderTree.mm:
1812         (runTest):
1813         * DumpRenderTree/win/DumpRenderTree.cpp:
1814         (runTest):
1815
1816 2014-02-27  Laszlo Vidacs  <lvidacs.u-szeged@partner.samsung.com>
1817
1818         check-webkit-style indentation false alarm in WebKit/win/WebNodeHighlight.cpp
1819         https://bugs.webkit.org/show_bug.cgi?id=127076
1820
1821         Reviewed by Anders Carlsson.
1822
1823         Avoid match for :: as start of a member initialization list. Modify expression to match
1824         after a colon either non-colon character or end of line.
1825
1826         * Scripts/webkitpy/style/checkers/cpp.py:
1827         (check_member_initialization_list):
1828         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1829         (WebKitStyleTest.test_member_initialization_list):
1830
1831 2014-02-27  Renata Hodovan  <rhodovan.u-szeged@partner.samsung.com>
1832
1833         Unreviewed. Update my email addresses in contributors.json.
1834
1835         * Scripts/webkitpy/common/config/contributors.json:
1836
1837 2014-02-27  Alberto Garcia  <berto@igalia.com>
1838
1839         [gtk-doc] UnicodeEncodeError: 'ascii' codec can't encode character
1840         https://bugs.webkit.org/show_bug.cgi?id=128927
1841
1842         Reviewed by Philippe Normand.
1843
1844         Encode manually the data for sys.{stdout,stderr}.write.
1845
1846         * gtk/gtkdoc.py:
1847         (GTKDoc._run_command):
1848
1849 2014-02-27  Andres Gomez  <agomez@igalia.com>
1850
1851         Unreviewed. Add myself to watchlists
1852
1853         * Scripts/webkitpy/common/config/watchlist: Add myself to
1854         watchlists.
1855
1856 2014-02-27  Andres Gomez  <agomez@igalia.com>
1857
1858         Unreviewed, rolling out r164790.
1859         http://trac.webkit.org/changeset/164790
1860
1861         Revert r164790 because of erroneous commit log
1862
1863         * Scripts/webkitpy/common/config/watchlist:
1864
1865 2014-02-27  Krzysztof Czech  <k.czech@samsung.com>
1866
1867         [ATK] Utilize AtkTableCell to expose directly AccessibilityTableCell to AT
1868         https://bugs.webkit.org/show_bug.cgi?id=129250
1869
1870         Reviewed by Mario Sanchez Prada.
1871
1872         Changing version of ATK to 2.11.90, because it introduces AtkTableCell interface.
1873         Implementing methods so that we could test column/row headers represented as an array of cells.
1874
1875         * DumpRenderTree/AccessibilityUIElement.cpp:
1876         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1877         (AccessibilityUIElement::columnHeaders):
1878         (AccessibilityUIElement::rowHeaders):
1879         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Adding empty stubs, to not break compilation.
1880         (AccessibilityUIElement::columnHeaders):
1881         (AccessibilityUIElement::rowHeaders):
1882         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1883         (WTR::AccessibilityUIElement::rowHeaders):
1884         (WTR::AccessibilityUIElement::columnHeaders):
1885         * efl/jhbuild.modules:
1886         * gtk/jhbuild.modules:
1887
1888 2014-02-27  Andres Gomez  <agomez@igalia.com>
1889
1890         Unreviewed. Add myself to watchlists
1891
1892         * Scripts/webkitpy/common/config/watchlist: Add myself to
1893         watchlists.
1894
1895 2014-02-27  Andres Gomez  <agomez@igalia.com>
1896
1897         Unreviewed. Add myself as a committer.
1898
1899         * Scripts/webkitpy/common/config/contributors.json:
1900
1901 2014-02-27  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1902
1903         Unreviewed. Add Víctor Jáquez and myself to watchlists
1904
1905         * Scripts/webkitpy/common/config/watchlist: Add Víctor Jáquez and
1906         myself to watchlists.
1907
1908 2014-02-26  Julien Brianceau  <jbriance@cisco.com>
1909
1910         Unreviewed. Add myself as a committer.
1911
1912         * Scripts/webkitpy/common/config/contributors.json:
1913
1914 2014-02-26  Laszlo Vidacs  <lvidacs.u-szeged@partner.samsung.com>
1915
1916         Unreviewed. Moved myself to the list of committers.
1917
1918         * Scripts/webkitpy/common/config/contributors.json:
1919
1920 2014-02-24  Martin Robinson  <mrobinson@igalia.com>
1921
1922         [GTK] Reduplicate common.top_level_path in scripts
1923         https://bugs.webkit.org/show_bug.cgi?id=129291
1924
1925         Reviewed by Philippe Normand.
1926
1927         Duplicate common.top_level_path and avoid polluting many scripts with awkward system
1928         path manipulation and weird dependencies on the jhbuild infrastructure.
1929
1930         * Scripts/run-gtk-tests: Use common again.
1931         (TestRunner._setup_testing_environment): Ditto.
1932         * gtk/check-gdom-symbols: Ditto.
1933         * gtk/common.py:
1934         (top_level_path): Re-add top_level_path..
1935         (get_build_path): Use the builtin top_level_path again.
1936         * gtk/find-make-dist-errors: Use common again.
1937         (get_missing_headers): Ditto.
1938         * gtk/generate-inspector-gresource-manifest.py: Ditto.
1939
1940 2014-02-26  Mark Hahnenberg  <mhahnenberg@apple.com>
1941
1942         runscript: line 42: /bin/ls: Argument list too long
1943         https://bugs.webkit.org/show_bug.cgi?id=129376
1944
1945         Reviewed by Michael Saboff.
1946
1947         The "test_script_*" can expand to more things than can be passed as arguments on the command line. 
1948         We should use find instead, which generates the list of files rather than expanding them all on 
1949         the command line and spitting them back out.
1950
1951         * Scripts/jsc-stress-test-helpers/shell-runner.sh: 
1952
1953 2014-02-26  Martin Robinson  <mrobinson@igalia.com>
1954
1955         ENABLE_PROMISES is improperly specified as ENABLE_PROMISE in Features.pm
1956         https://bugs.webkit.org/show_bug.cgi?id=129377
1957
1958         Reviewed by Csaba Osztrogonác.
1959
1960         * Scripts/webkitperl/FeatureList.pm: Properly specify the promises feature as ENABLE_PROMISES.
1961
1962 2014-02-26  Manuel Rego Casasnovas  <rego@igalia.com>
1963
1964         [GTK] Re-enable gtk-doc in EWS
1965         https://bugs.webkit.org/show_bug.cgi?id=128369
1966
1967         Reviewed by Carlos Garcia Campos.
1968
1969         Enable again gtk-doc generation in EWS once bug #128417 has been fixed.
1970
1971         * Scripts/webkitpy/common/config/ports.py:
1972         (GtkPort.build_webkit_command): Add --disable-gtk-doc arg.
1973         (GtkWK2Port.build_webkit_command): Ditto.
1974         * Scripts/webkitpy/common/config/ports_unittest.py:
1975         (DeprecatedPortTest.test_gtk_port): Ditto.
1976         (DeprecatedPortTest.test_gtk_wk2_port): Ditto.
1977
1978 2014-02-26  Martin Robinson  <mrobinson@igalia.com>
1979
1980         [GTK] generate-gtkdoc can fail with WebKit1 or WebKit2 only builds
1981         https://bugs.webkit.org/show_bug.cgi?id=129319
1982
1983         Reviewed by Carlos Garcia Campos.
1984
1985         * gtk/generate-gtkdoc:
1986         (get_generator_for_config): Properly handle the situation where the pkgconfig file is missing.
1987
1988 2014-02-25  Mihai Maerean  <mmaerean@adobe.com>
1989
1990         Unreviewed. Add myself as a committer.
1991
1992         * Scripts/webkitpy/common/config/contributors.json:
1993
1994 2014-02-25  Sergio Villar Senin  <svillar@igalia.com>
1995
1996         [CSS Grid Layout] Add ENABLE flag
1997         https://bugs.webkit.org/show_bug.cgi?id=129153
1998
1999         Reviewed by Simon Fraser.
2000
2001         Added ENABLE_CSS_GRID_LAYOUT feature flag. It's on by default for
2002         all ports for developer builds.
2003
2004         * Scripts/webkitperl/FeatureList.pm:
2005
2006 2014-02-25  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
2007
2008         Added myself as a committer.
2009
2010         Unreviewed.
2011
2012         * Scripts/webkitpy/common/config/contributors.json:
2013
2014 2014-02-25  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
2015
2016         Unreviewed. Moved myself to the list of committers.
2017
2018         * Scripts/webkitpy/common/config/contributors.json:
2019
2020 2014-02-25  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2021
2022         Move myself to the committers list.
2023
2024         Unreviewed.
2025
2026         * Scripts/webkitpy/common/config/contributors.json:
2027
2028 2014-02-25  László Langó  <llango.u-szeged@partner.samsung.com>
2029
2030         Unreviewed. Add myself as a committer.
2031
2032         * Scripts/webkitpy/common/config/contributors.json:
2033
2034 2014-02-25  Commit Queue  <commit-queue@webkit.org>
2035
2036         Unreviewed, rolling out r164639.
2037         http://trac.webkit.org/changeset/164639
2038         https://bugs.webkit.org/show_bug.cgi?id=129302
2039
2040         gtk-doc still have problems in EWS (Requested by rego on
2041         #webkit).
2042
2043         * Scripts/webkitpy/common/config/ports.py:
2044         (GtkPort.build_webkit_command):
2045         (GtkWK2Port.build_webkit_command):
2046         * Scripts/webkitpy/common/config/ports_unittest.py:
2047         (DeprecatedPortTest.test_gtk_port):
2048         (DeprecatedPortTest.test_gtk_wk2_port):
2049
2050 2014-02-25  Manuel Rego Casasnovas  <rego@igalia.com>
2051
2052         [GTK] Re-enable gtk-doc in EWS
2053         https://bugs.webkit.org/show_bug.cgi?id=128369
2054
2055         Reviewed by Carlos Garcia Campos.
2056
2057         Enable again gtk-doc generation in EWS once bug #128417 has been fixed.
2058
2059         * Scripts/webkitpy/common/config/ports.py:
2060         (GtkPort.build_webkit_command): Add --disable-gtk-doc arg.
2061         (GtkWK2Port.build_webkit_command): Ditto.
2062         * Scripts/webkitpy/common/config/ports_unittest.py:
2063         (DeprecatedPortTest.test_gtk_port): Ditto.
2064         (DeprecatedPortTest.test_gtk_wk2_port): Ditto.
2065
2066 2014-02-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2067
2068         [GTK] Mark view source mode methods as deprecated
2069         https://bugs.webkit.org/show_bug.cgi?id=128920
2070
2071         Reviewed by Martin Robinson.
2072
2073         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2074         (beforeAll): Remove view mode test.
2075
2076 2014-02-24  Martin Robinson  <mrobinson@igalia.com>
2077
2078         [GTK] generate-gtkdoc should not generate documentation for source files for unbuilt source files
2079         https://bugs.webkit.org/show_bug.cgi?id=128417
2080
2081         Reviewed by Carlos Garcia Campos.
2082
2083         * gtk/GNUmakefile.am: Make the documentation process depend on the configuration files.
2084         * gtk/generate-gtkdoc: Switch from using hard-coded configurations to reading them from
2085         a makefile. This allows accepting a header list from the build system, which can be used
2086         to dynamically build a list of ignored files. We can ignore any source file that doesn't
2087         have a corresponding header file on the header list. 
2088         * gtk/gtkdoc.py: Now accept a headers parameter, which can be used instead of passing just
2089         source directories to gtkdoc-scan.
2090
2091 2014-02-24  Anders Carlsson  <andersca@apple.com>
2092
2093         Add a DefaultVisitedLinkProvider and route visited link actions through it
2094         https://bugs.webkit.org/show_bug.cgi?id=129285
2095
2096         Reviewed by Dan Bernstein.
2097
2098         * MiniBrowser/mac/AppDelegate.m:
2099         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
2100         Set a shared history so we'll get visited link tracking.
2101
2102         * MiniBrowser/mac/WK1BrowserWindowController.m:
2103         (-[WK1BrowserWindowController awakeFromNib]):
2104         Set a group name.
2105
2106 2014-02-24  Dan Bernstein  <mitz@apple.com>
2107
2108         iOS build fix after r164577.
2109
2110         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2111         (AccessibilityUIElement::selectedChildrenCount):
2112         (AccessibilityUIElement::selectedChildAtIndex):
2113
2114 2014-02-24  David Kilzer  <ddkilzer@apple.com>
2115
2116         [ASan] Remove methods from ignore list that no longer cause crashes
2117         <http://webkit.org/b/129257>
2118
2119         Reviewed by Anders Carlsson.
2120
2121         * asan/webkit-asan-ignore.txt: Remove old methods.
2122
2123 2014-02-24  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2124
2125         Extract common parts from jhbuildrc files.
2126         https://bugs.webkit.org/show_bug.cgi?id=125986
2127
2128         Reviewed by Csaba Osztrogonác.
2129
2130         Co-authored with Peter Szanka <h868064@stud.u-szeged.hu>.
2131
2132         * Scripts/run-gtk-tests:
2133         (TestRunner._setup_testing_environment):
2134         * efl/common.py: Removed.
2135         * efl/jhbuildrc:
2136         * gtk/check-gdom-symbols:
2137         * gtk/common.py:
2138         (binary_build_path):
2139         (get_build_path):
2140         * gtk/find-make-dist-errors:
2141         (get_missing_headers):
2142         * gtk/generate-gtkdoc:
2143         (get_webkit2_options):
2144         (get_webkit1_options.src_path):
2145         (get_webkit1_options):
2146         (get_webkitdom_options.src_path):
2147         (get_webkitdom_options):
2148         * gtk/generate-inspector-gresource-manifest.py:
2149         * gtk/jhbuildrc:
2150         * jhbuild/jhbuildrc_common.py: Added.
2151         (script_path):
2152         (top_level_path):
2153         (init):
2154
2155 2014-02-24  Diego Pino Garcia  <dpino@igalia.com>
2156
2157         Unreviewed. Fix code indentation and spacing.
2158
2159         * Scripts/webkitpy/style/checkers/js.py:
2160         (SingleQuoteChecker.check):
2161
2162 2014-02-24  Krzysztof Czech  <k.czech@samsung.com>
2163
2164         [ATK] Wrong selected element at a given index in a list box.
2165         https://bugs.webkit.org/show_bug.cgi?id=129039
2166
2167         Reviewed by Chris Fleizach.
2168
2169         Added missing implementation and proposed some new function for testing selection
2170         in a list boxes.
2171
2172         * DumpRenderTree/AccessibilityUIElement.cpp:
2173         (setSelectedChildAtIndexCallback):
2174         (removeSelectionAtIndexCallback):
2175         (AccessibilityUIElement::getJSClass):
2176         * DumpRenderTree/AccessibilityUIElement.h:
2177         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2178         (AccessibilityUIElement::selectedChildrenCount):
2179         (AccessibilityUIElement::selectedChildAtIndex):
2180         (AccessibilityUIElement::setSelectedChildAtIndex):
2181         (AccessibilityUIElement::removeSelectionAtIndex):
2182         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2183         (AccessibilityUIElement::selectedChildrenCount):
2184         (AccessibilityUIElement::selectedChildAtIndex):
2185         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2186         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
2187         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
2188         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2189         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2190         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2191         (WTR::AccessibilityUIElement::selectedChildAtIndex):
2192         (WTR::AccessibilityUIElement::selectedChildrenCount):
2193         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
2194         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
2195
2196 2014-02-23  Diego Pino García  <dpino@igalia.com>
2197
2198         [GTK] Fix build after Web Inspector code reorganization (r164543)
2199         https://bugs.webkit.org/show_bug.cgi?id=129231
2200
2201         Reviewed by Dean Jackson.
2202
2203         * gtk/generate-inspector-gresource-manifest.py:
2204         Modify paths to Web Inspector code.
2205
2206 2014-02-23  Martin Robinson  <mrobinson@igalia.com>
2207
2208         [GTK] generate-gtkdoc should use argparse
2209         https://bugs.webkit.org/show_bug.cgi?id=128418
2210
2211         Reviewed by Carlos Garcia Campos.
2212
2213         * gtk/generate-gtkdoc: Get all arguments from argparse, pass then as parameters
2214         to all functions, and guard the main routine with a __name__ == __main__ check.
2215
2216 2014-02-23  Martin Robinson  <mrobinson@igalia.com>
2217
2218         [GTK][CMake] Many plugin tests fail when running WebKit1 layout tests
2219         https://bugs.webkit.org/show_bug.cgi?id=129191
2220
2221         Reviewed by Anders Carlsson.
2222
2223         * DumpRenderTree/PlatformGTK.cmake: Properly specify the library build directory
2224         for the GTK+ DumpRenderTree build. We could manually construct this path, but the
2225         name of the directory is "lib" and not "libs". Instead we should use the CMake
2226         variable specifically assigned to this task.
2227
2228 2014-02-23  David Kilzer  <ddkilzer@apple.com>
2229
2230         [ASan] Add JSC::DFG::prepareOSREntry() to ignore list
2231         <http://webkit.org/b/129209>
2232
2233         Reviewed by Geoffrey Garen.
2234
2235         * asan/webkit-asan-ignore.txt: Add DFG::prepareOSREntry() to the
2236         ignore list to make ASan builds usable again.  Follow-up
2237         investigation is tracked by <rdar://problem/16055903>.
2238
2239 2014-02-20  David Farler  <dfarler@apple.com>
2240
2241         Make old-run-webkit-tests work with iOS Simulator WebKitTestRunner
2242         https://bugs.webkit.org/show_bug.cgi?id=128622
2243
2244         Reviewed by Simon Fraser.
2245
2246         With this change, we now have layout tests running in both DumpRenderTree
2247         and WebKitTestRunner, with WebKit and WebKit2 used respectively in the iOS
2248         simulator.
2249
2250         * Scripts/old-run-webkit-tests:
2251         In general, make any specific reference to DumpRenderTree
2252         able to refer to WebKitTestRunner wherever possible:
2253         - Rename functions to remove DRT-specific naming.
2254         - Name FIFOs after the tool that is being used.
2255         -- Clean up FIFO creation code
2256         Other necessary changes:
2257         - Allow use of an ios-sim-wk2 platform.
2258         - Clean up platform hierarchy creation where the simulator platform behavior differed.
2259         * WebKitTestRunner/TestController.cpp:
2260         Open FIFOs to get dumps out of the simulator as we do in DumpRenderTree.
2261         (WTR::TestController::TestController):
2262         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2263         Copy the injected bundle into the app bundle.
2264
2265 2014-02-21  Joseph Pecoraro  <pecoraro@apple.com>
2266
2267         run-webkit-httpd fails to find httpd configuation file.
2268
2269         Reviewed by Ryosuke Niwa.
2270
2271         * Scripts/webkitperl/httpd.pm:
2272         (getHTTPDConfigPathForTestDirectory):
2273
2274 2014-02-21  Eric Carlson  <eric.carlson@apple.com>
2275
2276         Fix TimeRanges layering violations
2277         https://bugs.webkit.org/show_bug.cgi?id=128717
2278
2279         Reviewed by Jer Noble.
2280
2281         * TestWebKitAPI/Tests/WebCore/TimeRanges.cpp: TimeRanges* -> TimeRanges&.
2282         (TestWebKitAPI::TEST):
2283
2284 2014-02-21  Diego Pino García  <dpino@igalia.com>
2285
2286         Web Inspector: update check-webkit-style to flag single quotes in WebInspectorUI projects
2287         https://bugs.webkit.org/show_bug.cgi?id=128422
2288
2289         Reviewed by Joseph Pecoraro.
2290
2291         * Scripts/webkitpy/style/checkers/js.py:
2292         (JSChecker.__init__):
2293         (JSChecker.check):
2294         (SingleQuoteChecker):
2295         (SingleQuoteChecker.__init__):
2296         (SingleQuoteChecker.check):
2297         * Scripts/webkitpy/style/checkers/js_unittest.py:
2298         (JSTestCase.assertError.error_for_test):
2299         (JSTestCase.assertError):
2300         (JSTestCase.test_no_error):
2301         (JSTestCase.test_error):
2302
2303 == Rolled over to ChangeLog-2014-02-20 ==