REGRESSION (r249923): ASSERTION FAILED: sessionID == WebProcess::singleton().sessionI...
[WebKit-https.git] / Tools / ChangeLog
1 2019-09-17  Chris Dumez  <cdumez@apple.com>
2
3         REGRESSION (r249923): ASSERTION FAILED: sessionID == WebProcess::singleton().sessionID() in WebCore::SWClientConnection *WebKit::WebServiceWorkerProvider::existingServiceWorkerConnectionForSession(PAL::SessionID)
4         https://bugs.webkit.org/show_bug.cgi?id=201859
5         <rdar://problem/55426742>
6
7         Reviewed by Alex Christensen.
8
9         Update API test to use WKWebsiteDataStoreRef C API to do private browsing instead of using
10         the legacy WKPreferencesSetPrivateBrowsingEnabled() C API.
11
12         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
13         (TestWebKitAPI::TEST):
14
15 2019-09-17  Ryan Haddad  <ryanhaddad@apple.com>
16
17         Bring up queues for iOS 13
18         https://bugs.webkit.org/show_bug.cgi?id=201710
19
20         Reviewed by Jonathan Bedard.
21
22         * BuildSlaveSupport/build.webkit.org-config/config.json: Move iOS 12 queues to iOS 13.
23         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Ditto.
24         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
25         (WebKitBuildbot):
26         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
27         (table.queue-grid tr.platform.ios-simulator-12 img.logo): Deleted.
28         (table.queue-grid tr.platform.ios-12 img.logo): Deleted.
29         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit tests.
30         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
31         (_should_file_trigger_build):
32         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
33         (ShouldBuildTest):
34         (ShouldBuildTest.test_should_build):
35         * BuildSlaveSupport/ews-build/config.json: Move iOS 12 queues to iOS 13.
36
37 2019-09-17  Truitt Savell  <tsavell@apple.com>
38
39         Unreviewed, rolling out r249950.
40
41         Broke the iOS build.
42
43         Reverted changeset:
44
45         "Remove the "Show Link Previews" and "Hide Link Previews"
46         action menus in the preview platter"
47         https://bugs.webkit.org/show_bug.cgi?id=201864
48         https://trac.webkit.org/changeset/249950
49
50 2019-09-17  Dean Jackson  <dino@apple.com>
51
52         Remove the "Show Link Previews" and "Hide Link Previews" action menus in the preview platter
53         https://bugs.webkit.org/show_bug.cgi?id=201864
54         <rdar://55190038>
55
56         Reviewed by Simon Fraser.
57
58         Test for the suggested actions.
59
60         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
61         (-[TestContextMenuSuggestedActionsUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
62         (-[TestContextMenuSuggestedActionsUIDelegate webView:contextMenuWillPresentForElement:]):
63         (TEST):
64
65 2019-09-16  Alex Christensen  <achristensen@webkit.org>
66
67         Remove "gopher" from list of special schemes in URLParser
68         https://bugs.webkit.org/show_bug.cgi?id=201852
69
70         Reviewed by Simon Fraser.
71
72         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
73         (TestWebKitAPI::TEST_F):
74         * TestWebKitAPI/Tests/WebCore/URLParserTextEncoding.cpp:
75         (TestWebKitAPI::TEST_F):
76         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
77
78 2019-09-16  Jonathan Bedard  <jbedard@apple.com>
79
80         results.webkit.org: Shard result archives
81         https://bugs.webkit.org/show_bug.cgi?id=201734
82
83         Reviewed by Dewei Zhu.
84
85         Cassandra advertises being able to store up to 2 GB in a single blob-storage row.
86         In practice, this usually doesn't work according to the Cassandra developers,
87         large blobs should be broken up into shards of, at most, 10 MB.
88
89         * resultsdbpy/resultsdbpy/model/archive_context.py:
90         (ArchiveContext):
91         (ArchiveContext.ArchiveMetaDataByCommit): Point to the archive shards by hash.
92         (ArchiveContext.ArchiveMetaDataByCommit.unpack):
93         (ArchiveContext.ArchiveChunks): Store archive shards, indexed by hash.
94         (ArchiveContext.__init__):
95         (ArchiveContext.register): When saving archives, save a reference hash and then
96         shard the actual archive data before saving.
97         (ArchiveContext.find_archive): Search for archive by meta-data, then reconstruct
98         the archive. Raise an exception if we determine that memory usage is a problem.
99         (ArchiveContext.ArchivesByCommit): Deleted.
100         (ArchiveContext.ArchivesByCommit.unpack): Deleted.
101         * resultsdbpy/resultsdbpy/model/archive_context_unittest.py:
102         (ArchiveContextTest.init_database): Allow configuration and archive to be specified.
103         (ArchiveContextTest):
104         (ArchiveContextTest.test_large_archive): Test archive sharding.
105
106 2019-09-16  Jiewen Tan  <jiewen_tan@apple.com>
107
108         [WebAuthn] Support more than two FIDO protocol versions
109         https://bugs.webkit.org/show_bug.cgi?id=198408
110         <rdar://problem/51292176>
111
112         Reviewed by Chris Dumez.
113
114         Adds a new test case that includes a FIDO_2_1_PRE version string.
115
116         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
117         (TestWebKitAPI::TEST):
118         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
119
120 2019-09-16  Jonathan Bedard  <jbedard@apple.com>
121
122         results.webkit.org: Configurations should be branch specific
123         https://bugs.webkit.org/show_bug.cgi?id=201561
124
125         Reviewed by Dewei Zhu.
126
127         Partition configurations by branch in both Redis and Cassandra.
128
129         * resultsdbpy/resultsdbpy/controller/upload_controller.py:
130         (UploadController.suites): Allow the user to specify branches while listing suites.
131         * resultsdbpy/resultsdbpy/model/archive_context.py:
132         (ArchiveContext.register): Register each configuration with a branch.
133         * resultsdbpy/resultsdbpy/model/configuration_context.py:
134         (ConfigurationContext.ByPlatform): Index by branch.
135         (ConfigurationContext.ByPlatformAndVersion): Ditto.
136         (ConfigurationContext.ByArchitecture): Ditto.
137         (ConfigurationContext.ByModel): Ditto.
138         (ConfigurationContext.__init__): Populate Redis cache with branch.
139         (ConfigurationContext._convert_to_redis_key): Accept branch in Redis key.
140         (ConfigurationContext._register_in_redis): Register configuration with branch.
141         (ConfigurationContext.register_configuration): Ditto.
142         (ConfigurationContext.search_for_configuration): Search for configuration with branch.
143         (ConfigurationContext.search_for_recent_configuration): Ditto.
144         (ConfigurationContext.select_from_table_with_configurations): Ditto.
145         * resultsdbpy/resultsdbpy/model/configuration_context_unittest.py:
146         (ConfigurationContextTest.register_configurations): Register with branch.
147         (ConfigurationContextTest.test_repopulate_recent): Construct ConfigurationContext with
148         CommitContext object.
149         * resultsdbpy/resultsdbpy/model/upload_context.py:
150         (UploadContext.SuitesByConfiguration): Index by branch.
151         (UploadContext.upload_test_results): Register each configuration with a branch.
152         (UploadContext.find_suites): Pass branch to search for configurations.
153         * resultsdbpy/resultsdbpy/view/static/js/drawer.js: Check for new configurations when the branch is changed.
154         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Add branch to suites query.
155
156 2019-09-16  David Kilzer  <ddkilzer@apple.com>
157
158         check-webkit-style: Fix warning message for std::make_unique<typename[]>
159         <https://webkit.org/b/201818>
160
161         Reviewed by Darin Adler.
162
163         * Scripts/webkitpy/style/checkers/cpp.py:
164         (check_wtf_make_unique): Emit different error message when using
165         std::make_unique<>() to create an array.  Personalize the error
166         message by including the original type name, which also
167         demonstrates that WTF::makeUniqueArray<>() does not need square
168         brackets for its typename.
169         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
170         (WebKitStyleTest.test_wtf_make_unique): Add test.
171         (WebKitStyleTest.test_wtf_make_unique_array): Ditto.
172
173 2019-09-16  Andres Gonzalez  <andresg_22@apple.com>
174
175         Rename [WebAccessibilityObjectWrapper _accessibilityInsertText] to accessibilityInsertText to match accessibility client.
176         https://bugs.webkit.org/show_bug.cgi?id=201820
177
178         Reviewed by Chris Fleizach.
179
180         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
181         (AccessibilityUIElement::insertText):
182         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
183         (AccessibilityUIElement::insertText):
184         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
185         (WTR::AccessibilityUIElement::insertText):
186         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
187         (WTR::AccessibilityUIElement::insertText):
188
189 2019-09-16  David Kilzer  <ddkilzer@apple.com>
190
191         Fix leaks in DumpRenderTree and WebKitTestRunner
192         <https://webkit.org/b/201814>
193
194         Reviewed by Darin Adler.
195
196         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
197         (createCoreAnimationLayer): Fix signature to return CFTypeRef.
198         Add CF_RETURNS_RETAINED to document behavior.
199         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
200         (createCoreAnimationLayer): Fix signature to return CFTypeRef.
201
202         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
203         (takeWindowSnapshot): Add CF_RETURNS_RETAINED to document
204         behavior.
205         (createBitmapContextFromWebView): Fix leak of CGImageRef when
206         generating a replacement image.
207
208         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Add @dynamic
209         declaration for _stableStateOverride so compiler wouldn't try to
210         create another instance variable for it.
211
212         * WebKitTestRunner/mac/EventSenderProxy.mm:
213         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
214         Release `cgEvent` to fix leak.
215
216 2019-09-16  Andres Gonzalez  <andresg_22@apple.com>
217
218         Expose misspelling ranges for editable content to accessibility clients.
219         https://bugs.webkit.org/show_bug.cgi?id=201752
220         <rdar://problem/49556828>
221
222         Reviewed by Chris Fleizach.
223
224         Test code needed for LayoutTests/accessibility/misspelling-range.html.
225         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
226         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
227         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
228         (WTR::AccessibilityUIElement::misspellingTextMarkerRange):
229         (WTR::AccessibilityUIElement::indexForTextMarker):
230         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
231         (WTR::misspellingSearchParameterizedAttributeForCriteria):
232         (WTR::AccessibilityUIElement::misspellingTextMarkerRange):
233
234 2019-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
235
236         REGRESSION(r249142): [GTK] Epiphany delayed page loads continue indefinitely
237         https://bugs.webkit.org/show_bug.cgi?id=201544
238
239         Reviewed by Michael Catanzaro.
240
241         Add new test cases.
242
243         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
244         (testWebViewActiveURI):
245         (testWebViewIsLoading):
246         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
247         (loadChangedCallback):
248         (LoadTrackingTest::loadAlternateHTML):
249         (LoadTrackingTest::reset):
250         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.h:
251
252 2019-09-15  David Kilzer  <ddkilzer@apple.com>
253
254         block-spammers should obtain credentials the same way as webkit-patch
255         <https://webkit.org/b/201733>
256
257         Reviewed by Lucas Forschler.
258
259         * Scripts/block-spammers: Import Credentials from webkitpy.
260         Remove unused imports.  Enable logging at info level to match
261         webkit-patch.
262         (get_bugzilla_token): Use Credentials module to get
263         bugs.webkit.org credentials.
264         * Scripts/webkitpy/common/net/credentials.py:
265         (Credentials._run_security_tool): Change logging level from
266         error to info since multiple attempts are made at reading the
267         keychain.  Fix typos in comment.
268         (Credentials._credentials_from_security_command): Extract common
269         logic from Credentials._credentials_from_keychain into new
270         method.
271         (Credentials._credentials_from_keychain): Make fallback logic
272         for checking for credentials in the keychain more consistent and
273         easier to read.  Add error logging if no credentials are found.
274
275 2019-09-13  Youenn Fablet  <youenn@apple.com>
276
277         WPT importer should check META global tag in .any.js files to generate the valid .html stub files
278         https://bugs.webkit.org/show_bug.cgi?id=201718
279
280         Reviewed by Chris Dumez.
281
282         Read meta tag information to select the environments where the any.js template tests will be run.
283         Added support to run service worker tests from any.js template tests.
284
285         Covered by unit test.
286         Since we import only a single repository nowadays, use a test config file with just one repository
287         to simplify the new test.
288
289         * Scripts/webkitpy/w3c/test_importer.py:
290         (TestImporter.__init__):
291         (TestImporter.readEnvironmentsForTemplateTest):
292         (TestImporter.write_html_files_for_templated_js_tests):
293         * Scripts/webkitpy/w3c/test_importer_unittest.py:
294         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
295         (TestImporterTest.test_import_dir_with_no_tests):
296         (TestImporterTest.test_import_dir_with_empty_init_py):
297         (TestImporterTest.test_harnesslinks_conversion):
298         (TestImporterTest.test_submodules_generation):
299         (test_checkout_directory):
300         (test_clean_directory_option):
301         (test_git_ignore_generation):
302         (test_initpy_generation):
303         (test_remove_obsolete_content):
304         (test_manual_slow_test):
305         (test_webkit_test_runner_options):
306         (test_webkit_test_runner_import_reftests_with_absolute_paths_download):
307         (test_webkit_test_runner_import_reftests_with_absolute_paths_from_source_dir):
308         (test_template_test):
309
310 2019-09-13  Dean Jackson  <dino@apple.com>
311
312         Provide a prototype for AR QuickLook to trigger processing in the originating page
313         https://bugs.webkit.org/show_bug.cgi?id=201371
314         <rdar://54904781>
315
316         Disable the test for the moment.
317
318         * TestWebKitAPI/Tests/WebKitCocoa/SystemPreview.mm:
319         (TestWebKitAPI::TEST):
320
321 2019-09-11  Dean Jackson  <dino@apple.com>
322
323         Provide a prototype for AR QuickLook to trigger processing in the originating page
324         https://bugs.webkit.org/show_bug.cgi?id=201371
325         <rdar://54904781>
326
327         Reviewed by Simon Fraser.
328
329         * TestWebKitAPI/Tools/TestWebKitAPI/Tests/WebKitCocoa/SystemPreview.mm:
330         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
331         * TestWebKitAPI/Tests/WebKitCocoa/system-preview-trigger.html: Added.
332
333 2019-09-13  Youenn Fablet  <youenn@apple.com>
334
335         Partition processes running service workers by session ID
336         https://bugs.webkit.org/show_bug.cgi?id=201643
337
338         Reviewed by Chris Dumez.
339
340         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
341
342 2019-09-13  Nikolas Zimmermann  <zimmermann@kde.org>
343
344         Re-add myself to the list of committers
345
346         Unreviewed.
347
348         * Scripts/webkitpy/common/config/contributors.json:
349
350 2019-09-13  Alex Christensen  <achristensen@webkit.org>
351
352         [iOS] TestWebKitAPI.WebKit.TLSVersionWebSocket is a flaky failure
353         https://bugs.webkit.org/show_bug.cgi?id=201745
354
355         Reviewed by Chris Dumez.
356
357         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
358         (TestWebKitAPI::TEST):
359         The exact message isn't important.  The fact that the TLS handshake failed is, which is checked by the TCPServer.
360
361 2019-09-13  Patrick Griffis  <pgriffis@igalia.com>
362
363         [JHBuild] Fix building gst-plugins-good against glibc 2.30
364         https://bugs.webkit.org/show_bug.cgi?id=201715
365
366         Reviewed by Xabier Rodriguez-Calvar.
367
368         * gstreamer/patches/gst-plugins-good-glibc-2.30-compat.patch: Added.
369
370 2019-09-12  Chris Dumez  <cdumez@apple.com>
371
372         [WKTR] Drop TestRunner.setPrivateBrowsingEnabled_DEPRECATED()
373         https://bugs.webkit.org/show_bug.cgi?id=201546
374
375         Reviewed by Alex Christensen.
376
377         Drop TestRunner.setPrivateBrowsingEnabled_DEPRECATED() from WebKitTestRunner as it does not do
378         the right thing for WebKit2 and tests have been rewritten to not use it.
379
380         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
381         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
382         (WTR::TestRunner::setPrivateBrowsingEnabled_DEPRECATED): Deleted.
383         * WebKitTestRunner/InjectedBundle/TestRunner.h:
384
385 2019-09-12  Brady Eidson  <beidson@apple.com>
386
387         PDF exporting on iOS should include URL rects.
388         <rdar://problem/54900133> and https://bugs.webkit.org/show_bug.cgi?id=201693
389
390         Reviewed by Tim Horton.
391
392         * TestWebKitAPI/Tests/WebKitCocoa/PDFSnapshot.mm:
393         (TestWebKitAPI::TEST): Enable on iOS.
394
395 2019-09-12  Adrian Perez de Castro  <aperez@igalia.com>
396
397         [GTK][WPE] webkit_settings_set_user_agent() allows content forbidden in HTTP headers
398         https://bugs.webkit.org/show_bug.cgi?id=201077
399
400         Reviewed by Carlos Garcia Campos.
401
402         * TestWebKitAPI/CMakeLists.txt: Add missing HTTPParsers.cpp to be built into TestWebCore.
403         * TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp:
404         (TestWebKitAPI::TEST): Add tests for WebCore::isValidUserAgentHeaderValue().
405
406 2019-09-12  Mark Lam  <mark.lam@apple.com>
407
408         Harden JSC against the abuse of runtime options.
409         https://bugs.webkit.org/show_bug.cgi?id=201597
410         <rdar://problem/55167068>
411
412         Reviewed by Filip Pizlo.
413
414         Linux parts contributed by Carlos Garcia Campos <cgarcia@igalia.com>.
415         Windows parts contributed by Fujii Hironori <Hironori.Fujii@sony.com>.
416
417         Call JSC::Config::configureForTesting() in test harnesses or at the top of tests
418         to disable the hardening on test runs.  Tests rely on setting options to enable
419         test features.
420
421         * DumpRenderTree/mac/DumpRenderTree.mm:
422         (dumpRenderTree):
423         * DumpRenderTree/win/DumpRenderTree.cpp:
424         (initialize):
425         * TestWebKitAPI/PlatformUtilities.cpp:
426         (TestWebKitAPI::Util::createContextWithInjectedBundle):
427         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
428         (main):
429         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm:
430         (TestWebKitAPI::TEST):
431         (TestWebKitAPI::runActiveSessionTest):
432         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
433         (TEST):
434         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
435         (TEST):
436         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm:
437         (TestWebKitAPI::TEST):
438         * TestWebKitAPI/WKWebViewConfigurationExtras.h:
439         * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
440         (+[WKWebViewConfiguration _test_configurationWithTestPlugInClassName:]):
441         (+[WKWebViewConfiguration _test_configurationWithTestPlugInClassName:configureJSCForTesting:]):
442         * WebKitTestRunner/TestController.cpp:
443         (WTR::TestController::generateContextConfiguration const):
444
445 2019-09-12  Keith Rollin  <krollin@apple.com>
446
447         Fix PDFKit references in TestWebKitAPI
448         https://bugs.webkit.org/show_bug.cgi?id=201700
449         <rdar://problem/55279539>
450
451         Reviewed by Youenn Fablet.
452
453         These references fail in watchOS and tvOS, so remove them on those
454         platforms.
455
456         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
457         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
458         * TestWebKitAPI/Tests/WebKitCocoa/PDFSnapshot.mm:
459         * TestWebKitAPI/cocoa/TestPDFDocument.h:
460         * TestWebKitAPI/cocoa/TestPDFDocument.mm:
461         * TestWebKitAPI/config.h:
462
463 2019-09-11  Fujii Hironori  <Hironori.Fujii@sony.com>
464
465         [Win][MiniBrowser] Select all text in the URL bar by clicking it
466         https://bugs.webkit.org/show_bug.cgi?id=201677
467
468         Reviewed by Don Olmstead.
469
470         * MiniBrowser/win/MainWindow.cpp:
471         (EditProc): Post EM_SETSEL in WM_SETFOCUS to select all text.
472
473 2019-09-11  Carlos Garcia Campos  <cgarcia@igalia.com>
474
475         [GTK][WPE] Stop using the session bus in the unit tests
476         https://bugs.webkit.org/show_bug.cgi?id=201636
477
478         Reviewed by Žan Doberšek.
479
480         We are actually using GTestDBus, not the actual session bus of the user session, but it would still be better to
481         use a private p2p DBus connection. This is also the way we encourage apps to implement the communication with
482         the web process extension. This patch removes the WebKitTestBus class and starts a DBus server before every
483         test. The server address is passed to the web extension as initialization parameter to connect directly to
484         it. We keep a global list of connections to the server and a HashMap to get the current active connection for
485         a WebKitWebView.
486
487         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
488         (beforeAll):
489         (afterAll):
490         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
491         (testProcessPerWebView):
492         (beforeAll):
493         (afterAll):
494         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
495         (testWebExtensionGetTitle):
496         (testWebExtensionInputElementIsUserEdited):
497         (testDocumentLoadedSignal):
498         (testWebKitWebViewProcessCrashed):
499         (testWebExtensionIsolatedWorld):
500         (testInstallMissingPluginsPermissionRequest):
501         (testWebExtensionFormControlsAssociated):
502         (FormSubmissionTest::FormSubmissionTest):
503         (beforeAll):
504         (afterAll):
505         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
506         (DelayedSignal::DelayedSignal):
507         (emitPageCreated):
508         (pageCreatedCallback):
509         (webkit_web_extension_initialize_with_user_data):
510         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
511         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
512         (AccessibilityTest::AccessibilityTest):
513         (AccessibilityTest::ensureProxy):
514         (beforeAll):
515         (afterAll):
516         * TestWebKitAPI/glib/CMakeLists.txt:
517         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
518         (dbusConnectionClosed):
519         (dbusServerConnection):
520         (startDBusServer):
521         (stopDBusServer):
522         (main):
523         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
524         (Test::initializeWebExtensions):
525         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp: Removed.
526         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.h: Removed.
527         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
528         (WebViewTest::~WebViewTest):
529         (WebViewTest::extensionProxy):
530         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
531
532 2019-09-10  Dean Jackson  <dino@apple.com>
533
534         setup-git-clone is using http not https
535         https://bugs.webkit.org/show_bug.cgi?id=201658
536
537         Reviewed by Sam Weinig.
538
539         * Scripts/webkitpy/tool/commands/setupgitclone.py:
540         (SetupGitClone.execute):
541
542 2019-09-10  Matt Lewis  <jlewis3@apple.com>
543
544         run-webkit-test: Allow results to be uploaded without scm checkout
545         https://bugs.webkit.org/show_bug.cgi?id=200787
546
547         Reviewed by Jonathan Bedard.
548
549         * Scripts/webkitpy/common/checkout/scm/detection.py:
550         (SCMDetector.detect_scm_system): Added in detection of stub repository.
551         * Scripts/webkitpy/common/checkout/scm/stub_repository.py: Added.
552         (StubRepository):
553         (StubRepository.__init__):
554         (StubRepository._find_parent_path_matching_callback_condition): Checks up the path given to
555         find the directory containing the checkout_information.json of the stub repository.
556         (StubRepository.in_working_directory): Required functions to be implemented.
557         (StubRepository.svn_revision): Required functions to be implemented.
558         (StubRepository.native_revision): Required functions to be implemented.
559         (StubRepository.native_branch): Required functions to be implemented.
560         (StubRepository._decode_json): Decodes checkout_information.json.
561         (StubRepository.find_checkout_root): Required functions to be implemented.
562         * Scripts/webkitpy/common/checkout/scm/stub_repository_unittest.py: Added.
563         (StubRepositoryTest): Unit test for stub_repository SCM.
564         (StubRepositoryTest.mock_host_for_stub_repository):
565         (StubRepositoryTest.test_in_working_directory):
566         (StubRepositoryTest.test_native_revision):
567         (StubRepositoryTest.test_native_branch):
568         (StubRepositoryTest.test_svn_revision):
569         (StubRepositoryTest.test_find_checkout_root):
570         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
571         (JSONResultsGenerator._get_svn_revision): Removed unnecessary scm initialization.
572         * Scripts/webkitpy/port/base.py:
573         (Port.commits_for_upload): Removed unnecessary scm initialization.
574
575 2019-09-10  Brady Eidson  <beidson@apple.com>
576
577         Add SPI to save a PDF from the contents of a WKWebView.
578         <rdar://problem/48955900> and https://bugs.webkit.org/show_bug.cgi?id=195765
579
580         Reviewed by Tim Horton.
581
582         -Add an "Export to PDF..." menu option to MiniBrowser.
583         -Add API tests for the API itself.
584
585         * MiniBrowser/MiniBrowser.entitlements:
586
587         * MiniBrowser/mac/BrowserWindowController.h:
588         * MiniBrowser/mac/BrowserWindowController.m:
589         (-[BrowserWindowController forceRepaint:]):
590         (-[BrowserWindowController saveAsPDF:]):
591
592         * MiniBrowser/mac/MainMenu.xib:
593
594         * MiniBrowser/mac/WK1BrowserWindowController.m:
595         (-[WK1BrowserWindowController validateMenuItem:]):
596         * MiniBrowser/mac/WK2BrowserWindowController.m:
597         (-[WK2BrowserWindowController validateMenuItem:]):
598         (-[WK2BrowserWindowController saveAsPDF:]):
599
600         * TestWebKitAPI/Configurations/Base.xcconfig:
601         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
602         * TestWebKitAPI/Tests/WebKitCocoa/PDFSnapshot.mm: Added.
603         (TestWebKitAPI::TEST):
604         * TestWebKitAPI/cocoa/TestPDFDocument.h: Added.
605         * TestWebKitAPI/cocoa/TestPDFDocument.mm: Added.
606         (TestWebKitAPI::toCGRect):
607         (TestWebKitAPI::toPlatformPoint):
608         (TestWebKitAPI::TestPDFAnnotation::TestPDFAnnotation):
609         (TestWebKitAPI::TestPDFAnnotation::isLink const):
610         (TestWebKitAPI::TestPDFAnnotation::bounds const):
611         (TestWebKitAPI::TestPDFAnnotation::linkURL const):
612         (TestWebKitAPI::TestPDFPage::create):
613         (TestWebKitAPI::TestPDFPage::TestPDFPage):
614         (TestWebKitAPI::TestPDFPage::annotations):
615         (TestWebKitAPI::TestPDFPage::characterCount const):
616         (TestWebKitAPI::TestPDFPage::text const):
617         (TestWebKitAPI::TestPDFPage::rectForCharacterAtIndex const):
618         (TestWebKitAPI::TestPDFPage::characterIndexAtPoint const):
619         (TestWebKitAPI::TestPDFPage::bounds const):
620         (TestWebKitAPI::TestPDFPage::colorAtPoint const):
621         (TestWebKitAPI::TestPDFDocument::createFromData):
622         (TestWebKitAPI::TestPDFDocument::TestPDFDocument):
623         (TestWebKitAPI::TestPDFDocument::pageCount const):
624         (TestWebKitAPI::TestPDFDocument::page):
625
626 2019-09-10  Keith Rollin  <krollin@apple.com>
627
628         Remove SSL-based TLSDeprecation.mm contents
629         https://bugs.webkit.org/show_bug.cgi?id=201657
630         <rdar://problem/55237678>
631
632         Reviewed by Alex Christensen.
633
634         This file does not build on watchOS due to references to SSL
635         facilities. Conditionalize out the contents on HAVE_SSL.
636
637         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
638
639 2019-09-10  Michael Catanzaro  <mcatanzaro@igalia.com>
640
641         Unreviewed, remove myself from watchlists
642
643         * Scripts/webkitpy/common/config/watchlist:
644
645 2019-09-09  Alex Christensen  <achristensen@webkit.org>
646
647         Rebase API test after r249675
648         https://bugs.webkit.org/show_bug.cgi?id=201596
649
650         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
651         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
652         We removed the restriction on WebsitePolicies with non-default persistent sessions.
653         We needed to change the expectations of the test that exercised that code path.
654
655 2019-09-09  Alex Christensen  <achristensen@webkit.org>
656
657         Fix iOS API tests after r249684
658         https://bugs.webkit.org/show_bug.cgi?id=201573
659
660         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
661         (TestWebKitAPI::getWebSocketEventWebKitLegacy):
662         (TestWebKitAPI::TEST):
663         The web thread still exists :(
664         That makes iOS immediate failure results more like WK2, which is fine.
665         The point is that the connection fails somehow and the server sees a TLS failure, which the test verifies.
666
667 2019-09-09  Chris Dumez  <cdumez@apple.com>
668
669         REGRESSION: http/tests/resourceLoadStatistics/do-not-capture-statistics-for-simple-top-navigations.html is frequently timing out on iOS EWS bots
670         https://bugs.webkit.org/show_bug.cgi?id=201550
671
672         Reviewed by Alex Christensen.
673
674         Update testRunner.statisticsNotifyObserver() to return a boolean indicating if it did
675         anything or not.
676
677         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
678         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
679         (WTR::InjectedBundle::statisticsNotifyObserver):
680         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
681         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
682         (WTR::TestRunner::statisticsNotifyObserver):
683         * WebKitTestRunner/InjectedBundle/TestRunner.h:
684
685 2019-09-09  Timothy Hatcher  <timothy@apple.com>
686
687         Tap and hold on Facebook sometimes creates a tall empty selection.
688         https://bugs.webkit.org/show_bug.cgi?id=201618
689         rdar://53630145
690
691         Reviewed by Megan Gardner.
692
693         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
694         * TestWebKitAPI/Tests/ios/SelectionByWord.mm: Added.
695
696 2019-09-09  Aakash Jain  <aakash_jain@apple.com>
697
698         [EWS] Watchlist doesn't work sometimes
699         https://bugs.webkit.org/show_bug.cgi?id=201433
700
701         Reviewed by Michael Catanzaro.
702
703         * Scripts/webkitpy/common/config/watchlist: Updated the email addresses to the one associated with
704         corresponding Bugzilla accounts.
705
706 2019-09-09  Alex Christensen  <achristensen@webkit.org>
707
708         Disable TLS 1.0 and 1.1 in WebSockets
709         https://bugs.webkit.org/show_bug.cgi?id=201573
710
711         Reviewed by Youenn Fablet.
712
713         * TestWebKitAPI/SourcesCocoa.txt:
714         * TestWebKitAPI/TCPServer.cpp:
715         (sk_CRYPTO_BUFFER_num):
716         (sk_CRYPTO_BUFFER_value):
717         (TestWebKitAPI::deleter<CRYPTO_BUFFER>::operator()):
718         (TestWebKitAPI::TCPServer::TCPServer):
719         (TestWebKitAPI::TCPServer::listenForConnections):
720         (TestWebKitAPI::deleter<X509>::operator()): Deleted.
721         (TestWebKitAPI::deleter<uint8_t::operator()): Deleted.
722         * TestWebKitAPI/TCPServer.h:
723         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
724         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm: Added.
725         (-[WebSocketDelegate waitForMessage]):
726         (-[WebSocketDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
727         (TestWebKitAPI::TEST):
728         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
729         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
730         (-[TestNavigationDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
731         (-[TestNavigationDelegate waitForDidFailProvisionalNavigation]):
732
733 2019-09-09  Fujii Hironori  <Hironori.Fujii@sony.com>
734
735         [Win][MiniBrowser] WebKitLegacyBrowserWindow is leaked by circular references
736         https://bugs.webkit.org/show_bug.cgi?id=201600
737
738         Reviewed by Brent Fulgham.
739
740         There were some circular references between
741         WebKitLegacyBrowserWindow and its delegation classes. For
742         example, WebKitLegacyBrowserWindow has a reference of
743         WebDownloadDelegate, and WebDownloadDelegate shares the ref
744         counter with WebKitLegacyBrowserWindow.
745
746         WebNotificationObserver was leaked because it wasn't unregistered
747         from the default notification center by using
748         IWebNotificationCenter::removeObserver.
749
750         If a new legacy window was created by mouse right click a link,
751         WebView was released twice because
752         PrintWebUIDelegate::createWebViewWithRequest didn't AddRef the
753         WebView.
754
755         This change does:
756         1. Make delegation classes have own ref-counter to avoid circular references
757         2. Do removeObserver notification observers
758         3. AddRef WebView in PrintWebUIDelegate::createWebViewWithRequest
759
760         * MiniBrowser/win/AccessibilityDelegate.cpp:
761         (AccessibilityDelegate::AddRef):
762         (AccessibilityDelegate::Release):
763         * MiniBrowser/win/AccessibilityDelegate.h: Added m_refCount.
764         * MiniBrowser/win/MiniBrowserWebHost.cpp:
765         (MiniBrowserWebHost::QueryInterface):
766         (MiniBrowserWebHost::AddRef):
767         (MiniBrowserWebHost::Release):
768         * MiniBrowser/win/MiniBrowserWebHost.h: Added m_refCount.
769         * MiniBrowser/win/PrintWebUIDelegate.cpp:
770         (PrintWebUIDelegate::createWebViewWithRequest): Do AddRef for the returned IWebView.
771         (PrintWebUIDelegate::AddRef):
772         (PrintWebUIDelegate::Release):
773         * MiniBrowser/win/PrintWebUIDelegate.h: Added m_refCount.
774         * MiniBrowser/win/ResourceLoadDelegate.cpp:
775         (ResourceLoadDelegate::AddRef):
776         (ResourceLoadDelegate::Release):
777         * MiniBrowser/win/ResourceLoadDelegate.h: Added m_refCount.
778         * MiniBrowser/win/WebDownloadDelegate.cpp:
779         (WebDownloadDelegate::AddRef):
780         (WebDownloadDelegate::Release):
781         * MiniBrowser/win/WebDownloadDelegate.h: Added m_refCount.
782         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
783         (WebKitLegacyBrowserWindow::~WebKitLegacyBrowserWindow): Do removeObserver notification observers.
784         (WebKitLegacyBrowserWindow::init):
785         (WebKitLegacyBrowserWindow::setUIDelegate):
786         (WebKitLegacyBrowserWindow::setAccessibilityDelegate):
787         (WebKitLegacyBrowserWindow::setResourceLoadDelegate):
788         (WebKitLegacyBrowserWindow::setDownloadDelegate):
789         (WebKitLegacyBrowserWindow::AddRef): Deleted.
790         (WebKitLegacyBrowserWindow::Release): Deleted.
791         (WebKitLegacyBrowserWindow::setFrameLoadDelegate): Deleted.
792         (WebKitLegacyBrowserWindow::setFrameLoadDelegatePrivate): Deleted.
793         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
794
795 2019-09-09  Chris Dumez  <cdumez@apple.com>
796
797         Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in http/tests/adClickAttribution/conversion-disabled-in-ephemeral-session.html
798         https://bugs.webkit.org/show_bug.cgi?id=201596
799
800         Reviewed by Alex Christensen.
801
802         Add new testRunner.setShouldSwapToEphemeralSessionOnNextNavigation() / testRunner.setShouldSwapToDefaultSessionOnNextNavigation()
803         test functions to support dynamic switching between ephemeral and default/persistent session in layout tests. The new methods
804         do the right thing for WebKit2 and truly switch session, unlike setPrivateBrowsingEnabled_DEPRECATED() which was merely making
805         the WebCore::Document think it changed session.
806
807         * DumpRenderTree/TestRunner.cpp:
808         (setShouldSwapToEphemeralSessionOnNextNavigationCallback):
809         (setShouldSwapToDefaultSessionOnNextNavigationCallback):
810         (TestRunner::staticFunctions):
811         (TestRunner::willNavigate):
812         * DumpRenderTree/TestRunner.h:
813         (TestRunner::setShouldSwapToEphemeralSessionOnNextNavigation):
814         (TestRunner::setShouldSwapToDefaultSessionOnNextNavigation):
815         * DumpRenderTree/mac/FrameLoadDelegate.mm:
816         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
817         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
818         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
819         (WTR::TestRunner::setShouldSwapToEphemeralSessionOnNextNavigation):
820         (WTR::TestRunner::setShouldSwapToDefaultSessionOnNextNavigation):
821         * WebKitTestRunner/InjectedBundle/TestRunner.h:
822         * WebKitTestRunner/TestController.cpp:
823         (WTR::TestController::decidePolicyForNavigationAction):
824         * WebKitTestRunner/TestController.h:
825         (WTR::TestController::setShouldSwapToEphemeralSessionOnNextNavigation):
826         (WTR::TestController::setShouldSwapToDefaultSessionOnNextNavigation):
827         * WebKitTestRunner/TestInvocation.cpp:
828         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
829
830 2019-09-09  Aakash Jain  <aakash_jain@apple.com>
831
832         EWS testtube emoji doesn't exist on macOS Mojave
833         https://bugs.webkit.org/show_bug.cgi?id=201532
834
835         Reviewed by Simon Fraser.
836
837         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
838         (StatusBubble): Change the emoji to microscope emoji.
839
840 2019-09-09  Aakash Jain  <aakash_jain@apple.com>
841
842         [EWS] API testers can go in an infinite RETRY loop when there is build failure in trunk
843         https://bugs.webkit.org/show_bug.cgi?id=201607
844
845         Reviewed by Jonathan Bedard.
846
847         * BuildSlaveSupport/ews-build/steps.py:
848         (AnalyzeAPITestsResults.analyzeResults): Do not RETRY when clean_tree_results are missing.
849         (AnalyzeAPITestsResults.analyzeResults.getAPITestFailures): Gracefully handle None result.
850
851 2019-09-07  Keith Miller  <keith_miller@apple.com>
852
853         OSR entry into wasm misses some contexts
854         https://bugs.webkit.org/show_bug.cgi?id=201569
855
856         Reviewed by Yusuke Suzuki.
857
858         Add new test harness mode for tests created from wast files.
859
860         * Scripts/run-jsc-stress-tests:
861
862 2019-09-09  Daniel Bates  <dabates@apple.com>
863
864         Remove all selection view animations before dumping results
865         https://bugs.webkit.org/show_bug.cgi?id=199241
866
867         Reviewed by Wenson Hsieh.
868
869         On iOS the selection UI uses a few animations, including fading in the grabbers. We have many
870         historical tests that were written for Mac and expect Mac's lack of animations that we run on
871         iOS and are flaky. Let's try to remove all selection view animations before dumping results and
872         see if this makes tests on iOS less flaky. A future enhancement to this is to expose a uiController
873         API for a test to remove selection animations at any time during the run.
874
875         * WebKitTestRunner/ios/TestControllerIOS.mm:
876         (WTR::TestController::notifyDone):
877
878 2019-09-09  Jonathan Bedard  <jbedard@apple.com>
879
880         run-webkit-tests: Report results archive to results.webkit.org
881         https://bugs.webkit.org/show_bug.cgi?id=201321
882
883         Reviewed by Aakash Jain.
884
885         * Scripts/webkitpy/layout_tests/controllers/manager.py:
886         (Manager.run): After all tests are finish, upload the results archive for each
887         configuration.
888         * Scripts/webkitpy/results/upload.py:
889         (Upload):
890         (Upload.__init__): Automatically define timestamp.
891         (Upload.upload_archive): Upload an archive associated with the test run.
892         * Scripts/webkitpy/results/upload_unittest.py:
893         (UploadTest.test_buildbot):
894         (UploadTest):
895         (UploadTest.test_archive_upload):
896
897 2019-09-09  Chris Dumez  <cdumez@apple.com>
898
899         Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in http/tests/workers/service/basic-register.html
900         https://bugs.webkit.org/show_bug.cgi?id=201590
901
902         Reviewed by Youenn Fablet.
903
904         Add a new API test to check that if the default session registers a service worker, the
905         hasServiceWorkerRegistration flag is still false in an ephemeral session.
906
907         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
908
909 2019-09-09  Jonathan Bedard  <jbedard@apple.com>
910
911         results.webkit.org: mobile-sidebar-control should override button
912         https://bugs.webkit.org/show_bug.cgi?id=201566
913
914         Rubber-stamped by Aakash Jain.
915
916         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
917         (@media screen and (min-width: 600px)):
918         (.mobile-sidebar-control):
919         (.mobile-sidebar-control.display):
920
921 2019-09-07  Chris Dumez  <cdumez@apple.com>
922
923         Rewrite http/tests/workers/service/serviceworker-private-browsing.https.html as an API test
924         https://bugs.webkit.org/show_bug.cgi?id=201574
925
926         Reviewed by Alex Christensen.
927
928         Rewrite http/tests/workers/service/serviceworker-private-browsing.https.html as an API test so that
929         we truly test private browsing. testRunner.setPrivateBrowsingEnabled_DEPRECATED() is a hack which
930         does not work well for WK2.
931
932         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
933
934 2019-09-07  Chris Dumez  <cdumez@apple.com>
935
936         Rewrite storage/domstorage/localstorage/private-browsing-affects-storage.html as an API test
937         https://bugs.webkit.org/show_bug.cgi?id=201547
938
939         Reviewed by Alex Christensen.
940
941         Rewrite storage/domstorage/localstorage/private-browsing-affects-storage.html as an API test so
942         it can use a true ephemeral session instead of the testRunner.setPrivateBrowsingEnabled_DEPRECATED()
943         hack.
944
945         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
946         (-[LocalStorageNavigationDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
947         (-[LocalStorageNavigationDelegate webView:didFinishNavigation:]):
948         (TEST):
949
950 2019-09-07  Alex Christensen  <achristensen@webkit.org>
951
952         Remove WebsiteDataStore::legacyDefaultDataStoreConfiguration
953         https://bugs.webkit.org/show_bug.cgi?id=200054
954
955         Reviewed by Carlos Garcia Campos.
956
957         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
958         This test relied on the default data store having been instantiated.
959
960 2019-09-07  Alex Christensen  <achristensen@webkit.org>
961
962         Remove calls to WKContextGetWebsiteDataStore missed in r249614
963         https://bugs.webkit.org/show_bug.cgi?id=200050
964
965         * WebKitTestRunner/TestController.cpp:
966         (WTR::TestController::resetPreferencesToConsistentValues):
967         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
968         * WebKitTestRunner/TestInvocation.cpp:
969         (WTR::TestInvocation::invoke):
970
971 2019-09-07  Alex Christensen  <achristensen@webkit.org>
972
973         Remove invalid assertion added in r249614
974         https://bugs.webkit.org/show_bug.cgi?id=200050
975
976         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
977         (WTR::TestController::cocoaResetStateToConsistentValues):
978         Something is instantiating the default data store, which is no problem right now.
979
980 2019-09-07  Ryan Haddad  <ryanhaddad@apple.com>
981
982         Unreviewed, rolling out r249353.
983
984         The test for this change is a flaky failure.
985
986         Reverted changeset:
987
988         "Add support for postMessage buffering between the service
989         worker and window"
990         https://bugs.webkit.org/show_bug.cgi?id=201169
991         https://trac.webkit.org/changeset/249353
992
993 2019-09-07  Alex Christensen  <achristensen@webkit.org>
994
995         Deprecate WKContextGetWebsiteDataStore
996         https://bugs.webkit.org/show_bug.cgi?id=200050
997
998         Reviewed by Geoff Garen.
999
1000         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1001         (WebKitBrowserWindow::updateProxySettings):
1002         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1003         * WebKitTestRunner/TestController.cpp:
1004         (WTR::TestController::generateContextConfiguration const):
1005         (WTR::TestController::websiteDataStore):
1006         (WTR::TestController::generatePageConfiguration):
1007         (WTR::TestController::resetStateToConsistentValues):
1008         (WTR::TestController::platformAdjustContext):
1009         (WTR::TestController::clearServiceWorkerRegistrations):
1010         (WTR::TestController::clearDOMCache):
1011         (WTR::TestController::clearDOMCaches):
1012         (WTR::TestController::ClearIndexedDatabases):
1013         (WTR::TestController::hasDOMCache):
1014         (WTR::TestController::domCacheSize):
1015         (WTR::TestController::setStatisticsDebugMode):
1016         (WTR::TestController::setStatisticsPrevalentResourceForDebugMode):
1017         (WTR::TestController::setStatisticsLastSeen):
1018         (WTR::TestController::setStatisticsPrevalentResource):
1019         (WTR::TestController::setStatisticsVeryPrevalentResource):
1020         (WTR::TestController::dumpResourceLoadStatistics):
1021         (WTR::TestController::isStatisticsPrevalentResource):
1022         (WTR::TestController::isStatisticsVeryPrevalentResource):
1023         (WTR::TestController::isStatisticsRegisteredAsSubresourceUnder):
1024         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
1025         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
1026         (WTR::TestController::setStatisticsHasHadUserInteraction):
1027         (WTR::TestController::isStatisticsHasHadUserInteraction):
1028         (WTR::TestController::setStatisticsGrandfathered):
1029         (WTR::TestController::isStatisticsGrandfathered):
1030         (WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin):
1031         (WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin):
1032         (WTR::TestController::setStatisticsSubresourceUniqueRedirectTo):
1033         (WTR::TestController::setStatisticsSubresourceUniqueRedirectFrom):
1034         (WTR::TestController::setStatisticsTopFrameUniqueRedirectTo):
1035         (WTR::TestController::setStatisticsTopFrameUniqueRedirectFrom):
1036         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1037         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1038         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1039         (WTR::TestController::statisticsUpdateCookieBlocking):
1040         (WTR::TestController::statisticsSubmitTelemetry):
1041         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
1042         (WTR::TestController::setStatisticsIsRunningTest):
1043         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
1044         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
1045         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
1046         (WTR::TestController::setStatisticsGrandfatheringTime):
1047         (WTR::TestController::setStatisticsMaxStatisticsEntries):
1048         (WTR::TestController::setStatisticsPruneEntriesDownTo):
1049         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
1050         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1051         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
1052         (WTR::TestController::statisticsDeleteCookiesForHost):
1053         (WTR::TestController::isStatisticsHasLocalStorage):
1054         (WTR::TestController::setStatisticsCacheMaxAgeCap):
1055         (WTR::TestController::statisticsResetToConsistentState):
1056         (WTR::TestController::setWebAuthenticationMockConfiguration):
1057         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
1058         * WebKitTestRunner/TestController.h:
1059         * WebKitTestRunner/TestInvocation.cpp:
1060         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1061         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1062         (WTR::initializeWebViewConfiguration):
1063
1064 2019-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1065
1066         Incorrect selection rect revealed after pasting images in a contenteditable element
1067         https://bugs.webkit.org/show_bug.cgi?id=201549
1068         <rdar://problem/50956429>
1069
1070         Reviewed by Simon Fraser.
1071
1072         Add an API test to exercise the scenario where we scroll to reveal the selection after pasting an image that was
1073         directly written to the pasteboard.
1074
1075         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
1076
1077 2019-09-06  Matt Lewis  <jlewis3@apple.com>
1078
1079         Unreviewed, rolling out r249582.
1080
1081         This caused results.html fail to be created on internal
1082         testers.
1083
1084         Reverted changeset:
1085
1086         "run-webkit-test: Allow results to be uploaded without scm
1087         checkout"
1088         https://bugs.webkit.org/show_bug.cgi?id=200787
1089         https://trac.webkit.org/changeset/249582
1090
1091 2019-09-06  Aakash Jain  <aakash_jain@apple.com>
1092
1093         [ews-app] Status bubble should only display important messages in pop-over - part 2
1094         https://bugs.webkit.org/show_bug.cgi?id=201557
1095
1096         Reviewed by Jonathan Bedard.
1097
1098         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1099         (StatusBubble): Add few more strings to STEPS_TO_HIDE.
1100
1101 2019-09-06  Alex Christensen  <achristensen@webkit.org>
1102
1103         Deprecate all WKCookieManagerRef functions
1104         https://bugs.webkit.org/show_bug.cgi?id=201473
1105
1106         Reviewed by Chris Dumez.
1107
1108         Adopt replacement C API in WebKitTestRunner.
1109
1110         * TestWebKitAPI/CMakeLists.txt:
1111         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1112         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp: Removed, because the functions it tests were removed.
1113         * WebKitTestRunner/TestController.cpp:
1114         (WTR::TestController::resetPreferencesToConsistentValues):
1115         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1116         * WebKitTestRunner/TestInvocation.cpp:
1117         (WTR::TestInvocation::invoke):
1118         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1119         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1120         (WTR::initializeWebViewConfiguration):
1121
1122 2019-09-06  Tim Horton  <timothy_horton@apple.com>
1123
1124         Marking up a note on iOS results in a PDF with no contents
1125         https://bugs.webkit.org/show_bug.cgi?id=201530
1126         <rdar://problem/53686019>
1127
1128         Reviewed by Andy Estes.
1129
1130         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1131         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm:
1132         Add some tests for WKWebViewPrintFormatter; specifically that it is
1133         possible to _recalcPageCount twice in quick succession, and that
1134         we don't hang if we start painting the printed content immediately
1135         after a Web Content process crash.
1136
1137 2019-09-06  Matt Lewis  <jlewis3@apple.com>
1138
1139         run-webkit-test: Allow results to be uploaded without scm checkout
1140         https://bugs.webkit.org/show_bug.cgi?id=200787
1141
1142         Reviewed by Jonathan Bedard.
1143
1144         * Scripts/webkitpy/common/checkout/scm/detection.py:
1145         (SCMDetector.detect_scm_system): Added in detection of stub repository.
1146         * Scripts/webkitpy/common/checkout/scm/stub_repository.py: Added.
1147         (StubRepository):
1148         (StubRepository.__init__):
1149         (StubRepository._find_parent_path_matching_callback_condition): Checks up the path given to
1150         find the directory containing the checkout_information.json of the stub repository.
1151         (StubRepository.in_working_directory): Required functions to be implemented.
1152         (StubRepository.svn_revision): Required functions to be implemented.
1153         (StubRepository.native_revision): Required functions to be implemented.
1154         (StubRepository.native_branch): Required functions to be implemented.
1155         (StubRepository._decode_json): Decodes checkout_information.json.
1156         (StubRepository.find_checkout_root): Required functions to be implemented.
1157         * Scripts/webkitpy/common/checkout/scm/stub_repository_unittest.py: Added.
1158         (StubRepositoryTest): Unit test for stub_repository SCM.
1159         (StubRepositoryTest.mock_host_for_stub_repository):
1160         (StubRepositoryTest.test_in_working_directory):
1161         (StubRepositoryTest.test_native_revision):
1162         (StubRepositoryTest.test_native_branch):
1163         (StubRepositoryTest.test_svn_revision):
1164         (StubRepositoryTest.test_find_checkout_root):
1165         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1166         (JSONResultsGenerator._get_svn_revision): Removed unnecessary scm initialization.
1167         * Scripts/webkitpy/port/base.py:
1168         (Port.commits_for_upload): Removed unnecessary scm initialization.
1169
1170 2019-09-06  Alex Christensen  <achristensen@webkit.org>
1171
1172         When disabling legacy private browsing for testing, change the SessionID back to what it was, not the defaultSessionID
1173         https://bugs.webkit.org/show_bug.cgi?id=201480
1174
1175         Reviewed by Youenn Fablet.
1176
1177         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1178         (WTR::InjectedBundle::beginTesting):
1179         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1180         (WTR::TestRunner::setPrivateBrowsingEnabled):
1181
1182 2019-09-06  Rob Buis  <rbuis@igalia.com>
1183
1184         Add runtime flag for lazy image loading
1185         https://bugs.webkit.org/show_bug.cgi?id=199794
1186
1187         Reviewed by Frédéric Wang.
1188
1189         Remove parts of r248409 that were meant for WK1 since
1190         lazy image loading is WK2 only.
1191
1192         * DumpRenderTree/TestOptions.cpp:
1193         (TestOptions::TestOptions):
1194         * DumpRenderTree/TestOptions.h:
1195         * DumpRenderTree/mac/DumpRenderTree.mm:
1196         (enableExperimentalFeatures):
1197         (setWebPreferencesForTestOptions):
1198         * DumpRenderTree/win/DumpRenderTree.cpp:
1199         (enableExperimentalFeatures):
1200
1201 2019-09-05  Chris Dumez  <cdumez@apple.com>
1202
1203         Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in imported/w3c/IndexedDB-private-browsing
1204         https://bugs.webkit.org/show_bug.cgi?id=201519
1205
1206         Reviewed by Alex Christensen.
1207
1208         Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in imported/w3c/IndexedDB-private-browsing
1209         as it does not truly enable private browsing for WebKit2. Instead, have WKTR / DRT set the
1210         TestOption::useEphemeralSession flag based on the test folder.
1211
1212         * DumpRenderTree/mac/DumpRenderTree.mm:
1213         (shouldUseEphemeralSession):
1214         (runTest):
1215         * WebKitTestRunner/TestOptions.cpp:
1216         (WTR::shouldUseEphemeralSession):
1217         (WTR::TestOptions::TestOptions):
1218
1219 2019-09-05  Fujii Hironori  <Hironori.Fujii@sony.com>
1220
1221         [Win] Support Per-Monitor (V2) DPI Awareness
1222         https://bugs.webkit.org/show_bug.cgi?id=201450
1223
1224         Reviewed by Don Olmstead.
1225
1226         * MiniBrowser/win/MainWindow.cpp:
1227         (MainWindow::WndProc): Set the window position suggested by WM_DPICHANGED.
1228         * MiniBrowser/win/WinMain.cpp:
1229         (wWinMain): Call SetProcessDpiAwarenessContext by using soft linking.
1230
1231 2019-09-05  Chris Dumez  <cdumez@apple.com>
1232
1233         REGRESSION: http/tests/adClickAttribution/second-attribution-converted-with-higher-priority.html and http/tests/adClickAttribution/second-attribution-converted-with-lower-priority.html are flaky timeouts
1234         https://bugs.webkit.org/show_bug.cgi?id=201440
1235         <rdar://problem/54998427>
1236
1237         Reviewed by Alex Christensen.
1238
1239         Since r249350, it is now possible for a WebContent process to have a suspended WebPage for the current web view.
1240         This was confusing InjectedBundle::page() in WebKitTestRunner which was assuming that the WebPage that was first
1241         created in the WebContent process is the one that is currently running the test and that we want to talk to.
1242         Update InjectedBundle::page() to ignore suspended WebPages in order to address the issue.
1243
1244         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1245         (WTR::InjectedBundle::page const):
1246
1247 2019-09-05  Jonathan Bedard  <jbedard@apple.com>
1248
1249         results.webkit.org: Assign notifyRerender before calling
1250         https://bugs.webkit.org/show_bug.cgi?id=201510
1251
1252         Reviewed by Aakash Jain.
1253
1254         Timelines should define notifyRerender to an empty function,
1255         rename notifiyRerender to notifyRerender.
1256
1257         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
1258         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1259         * resultsdbpy/resultsdbpy/view/templates/search.html:
1260         * resultsdbpy/resultsdbpy/view/templates/suite_results.html:
1261
1262 2019-09-05  Jonathan Bedard  <jbedard@apple.com>
1263
1264         results.webkit.org: Fix prepending search result on empty list 
1265         https://bugs.webkit.org/show_bug.cgi?id=201512
1266
1267         Reviewed by Aakash Jain.
1268
1269         * resultsdbpy/resultsdbpy/view/templates/search.html:
1270
1271 2019-09-05  Jonathan Bedard  <jbedard@apple.com>
1272
1273         results.webkit.org: Retain certain parameters when following menu links
1274         https://bugs.webkit.org/show_bug.cgi?id=201463
1275
1276         Rubber-stamped by Aakash Jain.
1277
1278         * resultsdbpy/resultsdbpy/view/site_menu.py:
1279         (SiteMenu.add_endpoint): Allow added endpoints to define parameters to be retained.
1280         * resultsdbpy/resultsdbpy/view/templates/base.html: When clicking on a site-menu link,
1281         retain the specified parameters
1282         * resultsdbpy/resultsdbpy/view/view_routes.py:
1283         (ViewRoutes.__init__):
1284
1285 2019-09-05  Chris Dumez  <cdumez@apple.com>
1286
1287         [WK2] Add proper layout test support for ephemeral sessions
1288         https://bugs.webkit.org/show_bug.cgi?id=201475
1289
1290         Reviewed by Antti Koivisto.
1291
1292         Add proper layout test support for ephemeral sessions via:
1293         <!-- webkit-test-runner [ useEphemeralSession=true ] -->
1294
1295         This actually creates a new WebView using an ephemeral data store to load the test which
1296         is *true* private browsing.
1297
1298         testRunner.setPrivateBrowsingEnabled() merely overrides the Page's sessionID in the WebContent
1299         process, which is a hack and does not truly enable private browsing because the UIProcess and
1300         the NetworkProcess are not properly updated on WK2. This patch renames testRunner.setPrivateBrowsingEnabled()
1301         to testRunner.setPrivateBrowsingEnabled_DEPRECATED() to discourage its use since I am try to
1302         get rid of it.
1303
1304         Note that WK2 does not support using a WebContent process for different sessions / data stores.
1305         Each WebContent process has a single associated data store and testRunner.setPrivateBrowsingEnabled()
1306         is currently the only exception to that. This leads to additional complexity in our code base (e.g. in ITP),
1307         simply to support testRunner.setPrivateBrowsingEnabled().
1308
1309         * DumpRenderTree/TestOptions.cpp:
1310         (TestOptions::TestOptions):
1311         * DumpRenderTree/TestOptions.h:
1312         * DumpRenderTree/TestRunner.cpp:
1313         (TestRunner::staticFunctions):
1314         * DumpRenderTree/mac/DumpRenderTree.mm:
1315         (setWebPreferencesForTestOptions):
1316         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1317         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1318         (WTR::TestRunner::setPrivateBrowsingEnabled_DEPRECATED):
1319         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1320         * WebKitTestRunner/TestController.cpp:
1321         (WTR::TestController::generatePageConfiguration):
1322         (WTR::updateTestOptionsFromTestHeader):
1323         * WebKitTestRunner/TestOptions.h:
1324         (WTR::TestOptions::hasSameInitializationOptions const):
1325         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1326         (WTR::TestController::platformCreateWebView):
1327
1328 2019-09-05  Ryosuke Niwa  <rniwa@webkit.org>
1329
1330         REGRESSION (iOS 13): Bulleted list copied from Notes to Mail results in Times New Roman
1331         https://bugs.webkit.org/show_bug.cgi?id=201490
1332
1333         Reviewed by Daniel Bates.
1334
1335         Added a test.
1336
1337         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1338         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
1339         * TestWebKitAPI/Tests/WebKitCocoa/cocoa-writer-markup-with-lists.html: Added.
1340
1341 2019-09-05  Ryosuke Niwa  <rniwa@webkit.org>
1342
1343         Remove unused SPI that accesses MemoryCache directly
1344         https://bugs.webkit.org/show_bug.cgi?id=201468
1345
1346         Reviewed by Youenn Fablet.
1347
1348         Removed the API test.
1349
1350         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1351         * TestWebKitAPI/Tests/ios/MemoryCacheAddImageToCacheIOS.mm: Removed.
1352
1353 2019-09-04  Timothy Hatcher  <timothy@apple.com>
1354
1355         Mail appears to be double inverting code copied from Notes, Xcode, or Terminal.
1356         https://bugs.webkit.org/show_bug.cgi?id=201368
1357         rdar://problem/40529867
1358
1359         Reviewed by Ryosuke Niwa.
1360
1361         Added Tests: PasteHTML.TransformColorsOfDarkContent, PasteHTML.DoesNotTransformColorsOfLightContent,
1362             PasteRTFD.TransformColorsOfDarkContent, PasteRTFD.DoesNotTransformColorsOfLightContent
1363
1364         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1365         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
1366         (createWebViewWithCustomPasteboardDataSetting): Added argument to enable color filter.
1367         * TestWebKitAPI/Tests/WebKitCocoa/PasteRTFD.mm:
1368         (createWebViewWithCustomPasteboardDataEnabled): Added argument to enable color filter.
1369         * TestWebKitAPI/Tests/WebKitCocoa/rich-color-filtered.html: Added.
1370         * TestWebKitAPI/cocoa/TestWKWebView.h:
1371         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1372         (-[TestWKWebView forceDarkMode]):
1373
1374 2019-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1375
1376         MobileSafari may crash when invoking the C++ lambda in -[WKContentView _shareForWebView:]
1377         https://bugs.webkit.org/show_bug.cgi?id=201479
1378         <rdar://problem/51511834>
1379
1380         Reviewed by Tim Horton.
1381
1382         Add a test to verify that the UI process doesn't crash when invoking `_share:` while there's no selection.
1383
1384         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1385         * TestWebKitAPI/ios/UIKitSPI.h:
1386
1387 2019-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1388
1389         -[WKContentView selectedText] returns an empty string when selecting more than 200 characters
1390         https://bugs.webkit.org/show_bug.cgi?id=201471
1391         <rdar://problem/55039227>
1392
1393         Reviewed by Tim Horton.
1394
1395         Add an API test to ensure that -selectedText is non-empty in the case where more than 200 characters are
1396         selected.
1397
1398         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1399         (TestWebKitAPI::TEST):
1400         * TestWebKitAPI/ios/UIKitSPI.h:
1401
1402 2019-09-04  Jonathan Bedard  <jbedard@apple.com>
1403
1404         results.webkit.org: Fix mobile vs desktop mode
1405         https://bugs.webkit.org/show_bug.cgi?id=201441
1406
1407         Rubber-stamped by Aakash Jain.
1408
1409         We should unconditionally use desktop mode if the device screen-width
1410         is large enough.
1411
1412         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
1413
1414 2019-09-04  Jonathan Bedard  <jbedard@apple.com>
1415
1416         run-api-tests: Add support for specifying additional environment variables
1417         https://bugs.webkit.org/show_bug.cgi?id=201311
1418         <rdar://problem/54852698>
1419
1420         Reviewed by Daniel Bates.
1421
1422         * Scripts/webkitpy/api_tests/run_api_tests.py:
1423         (parse_args): Add --additional-env-var flag.
1424         * Scripts/webkitpy/port/base.py:
1425         (Port._append_value_colon_separated): Use os.pathsep instead of ':'.
1426         (Port.environment_for_api_tests): Add the values from --additional-env-var to the
1427         environment.
1428
1429 2019-09-04  Aakash Jain  <aakash_jain@apple.com>
1430
1431         EWS bubbles should indicate builder vs tester
1432         https://bugs.webkit.org/show_bug.cgi?id=201253
1433
1434         Reviewed by Jonathan Bedard.
1435
1436         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1437         (StatusBubble._build_bubble): Add icons to the bubbles appropriately.
1438         (StatusBubble._is_tester_queue): Method to determine if the queue is tester queue.
1439         (StatusBubble._is_builder_queue): Method to determine if the queue is builder queue.
1440         (StatusBubble.get):
1441         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1442         (Buildbot.fetch_config): Method to fetch the config from Buildbot server.
1443         (Buildbot.update_icons_for_queues_mapping): Method to update the icons for queues mapping.
1444         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1445         (FetchLoop.run): Update the icons for queues mapping.
1446         * BuildSlaveSupport/ews-build/config.json: Add icon information for the queues.
1447         * BuildSlaveSupport/ews-build/loadConfig.py: Remove 'icon' key from builder before passing it to Buildbot.
1448         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: .
1449         (test_builder_keys): Update unit-test accordingly. Also minor drive-by fix to improve failure string formatting.
1450
1451 2019-09-03  Yusuke Suzuki  <ysuzuki@apple.com>
1452
1453         [bmalloc] IsoTLSLayout and AllIsoHeaps registration is racy with derived class initialization with virtual functions
1454         https://bugs.webkit.org/show_bug.cgi?id=201448
1455
1456         Reviewed by Mark Lam.
1457
1458         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
1459         (TEST):
1460
1461 2019-09-03  Dean Jackson  <dino@apple.com>
1462
1463         Test for ContextMenus with images
1464         https://bugs.webkit.org/show_bug.cgi?id=201437
1465
1466         Reviewed by Wenson Hsieh.
1467
1468         Add a test for ContextMenus that trigger on images, and make
1469         sure that they ask for alternate URLs (added in r249171).
1470
1471         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
1472         (contextMenuWebViewDriver):
1473         (-[TestContextMenuImageUIDelegate _webView:contextMenuConfigurationForElement:completionHandler:]):
1474         (-[TestContextMenuImageUIDelegate _webView:alternateURLFromImage:userInfo:]):
1475         (-[TestContextMenuImageUIDelegate webView:contextMenuWillPresentForElement:]):
1476         (-[TestContextMenuImageUIDelegate webView:contextMenuForElement:willCommitWithAnimator:]):
1477         (-[TestContextMenuImageUIDelegate webView:contextMenuDidEndForElement:]):
1478         (TEST):
1479
1480 2019-09-03  Jonathan Bedard  <jbedard@apple.com>
1481
1482         results.webkit.org: Move legend into sidebar
1483         https://bugs.webkit.org/show_bug.cgi?id=201258
1484
1485         Rubber-stamped by Aakash Jain.
1486
1487         * resultsdbpy/resultsdbpy/view/static/js/timeline.js: 
1488         (Legend): Make the legend vertical instead of horizontal, add ToolTip to dots in the legend.
1489         * resultsdbpy/resultsdbpy/view/static/js/tooltip.css: Add left and right tooltip arrows.
1490         * resultsdbpy/resultsdbpy/view/static/js/tooltip.js:
1491         (isPointInElement): Make bound check include borders.
1492         (_ToolTip.toString): Add left/right cases.
1493         (_ToolTip.prototype.setByElement): Set the tooltip location given an element.
1494         * resultsdbpy/resultsdbpy/view/templates/search.html: Put the legend into the sidebar.
1495         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Ditto.
1496
1497 2019-09-03  Jonathan Bedard  <jbedard@apple.com>
1498
1499         results.webkit.org: Increase default limit for LimitSlider
1500         https://bugs.webkit.org/show_bug.cgi?id=201424
1501
1502         Reviewed by Aakash Jain.
1503
1504         * resultsdbpy/resultsdbpy/view/static/js/drawer.js:
1505         (LimitSlider): Increase the default limit, make limit slider linear instead of logarithmic.
1506
1507 2019-09-03  Antoine Quint  <graouts@apple.com>
1508
1509         [iOS] Treat a two-finger single tap as if the user tapped with the Cmd key pressed
1510         https://bugs.webkit.org/show_bug.cgi?id=201420
1511         <rdar://problem/53207786>
1512
1513         Reviewed by Simon Fraser.
1514
1515         Add a new twoFingerSingleTapAtPoint() method to UIScriptController, which just calls into the existing (but unused)
1516         -[HIDEventGenerator twoFingerTap:completionBlock:].
1517
1518         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1519         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1520         (WTR::UIScriptController::twoFingerSingleTapAtPoint):
1521         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
1522         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1523         (WTR::UIScriptControllerIOS::twoFingerSingleTapAtPoint):
1524
1525 2019-09-03  Zan Dobersek  <zdobersek@igalia.com>
1526
1527         [WPE] MiniBrowser should handle the WebKitWebView::create signal
1528         https://bugs.webkit.org/show_bug.cgi?id=201417
1529
1530         Reviewed by Carlos Garcia Campos.
1531
1532         WPE's MiniBrowser should connect to and handle the
1533         WebKitWebView::create signal, constructing a new bit related
1534         WebKitWebView object upon invocation.
1535
1536         * MiniBrowser/wpe/main.cpp:
1537         (webViewClose):
1538         (createWebView):
1539         (main):
1540
1541 2019-09-03  Zan Dobersek  <zdobersek@igalia.com>
1542
1543         [WPE] Make view backends multi-view-friendly
1544         https://bugs.webkit.org/show_bug.cgi?id=201415
1545
1546         Reviewed by Carlos Garcia Campos.
1547
1548         Have the Wayland EGL connection for WindowViewBackend instances managed
1549         through a per-process singleton, allowing multiple backend objects
1550         use it for different views. HeadlessViewBackend already does this, but
1551         the code there is refurbished into a singleton structure.
1552
1553         The ViewBackend classes are adjusted to work with the backend-specific
1554         EGLDisplay objects (as constructed through the backend-specific EGL
1555         connection approach).
1556
1557         * wpe/backends/HeadlessViewBackend.cpp:
1558         (WPEToolingBackends::HeadlessEGLConnection::singleton):
1559         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend):
1560         (WPEToolingBackends::HeadlessViewBackend::~HeadlessViewBackend):
1561         (WPEToolingBackends::HeadlessViewBackend::createSnapshot):
1562         (WPEToolingBackends::getEGLDisplay): Deleted.
1563         * wpe/backends/ViewBackend.cpp:
1564         (WPEToolingBackends::ViewBackend::initialize):
1565         (WPEToolingBackends::ViewBackend::deinitialize):
1566         (WPEToolingBackends::ViewBackend::~ViewBackend): Deleted.
1567         * wpe/backends/ViewBackend.h:
1568         * wpe/backends/WindowViewBackend.cpp:
1569         (WPEToolingBackends::WaylandEGLConnection::singleton):
1570         (WPEToolingBackends::WindowViewBackend::WindowViewBackend):
1571         (WPEToolingBackends::WindowViewBackend::~WindowViewBackend):
1572         (WPEToolingBackends::WindowViewBackend::displayBuffer):
1573
1574 2019-09-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1575
1576         [WPE][GTK] Deprecate nonfunctional process limit APIs
1577         https://bugs.webkit.org/show_bug.cgi?id=193749
1578
1579         Reviewed by Žan Doberšek.
1580
1581         * MiniBrowser/gtk/main.c:
1582         (main):
1583         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
1584         (beforeAll):
1585         (testWebProcessLimit): Deleted.
1586
1587 2019-09-02  Zan Dobersek  <zdobersek@igalia.com>
1588
1589         [WPE] WindowBackend should do resizing properly
1590         https://bugs.webkit.org/show_bug.cgi?id=201386
1591
1592         Reviewed by Carlos Garcia Campos.
1593
1594         The WindowBackend implementation is resized via the XDG protocol. The
1595         initial size is stored for the object's lifetime and fallen back to when
1596         the XDG protocol reports (0,0) configuration size.
1597
1598         Upon each resize, we have to recreate the texture. We also have to size
1599         the GL viewport accordingly.
1600
1601         * wpe/backends/WindowViewBackend.cpp:
1602         (WPEToolingBackends::WindowViewBackend::WindowViewBackend):
1603         (WPEToolingBackends::WindowViewBackend::createViewTexture):
1604         (WPEToolingBackends::WindowViewBackend::resize):
1605         (WPEToolingBackends::WindowViewBackend::displayBuffer):
1606         * wpe/backends/WindowViewBackend.h:
1607
1608 2019-09-01  Fujii Hironori  <Hironori.Fujii@sony.com>
1609
1610         Unreviewed, rolling out r249366.
1611
1612         WinCairo WebKit2 crashes in some websites and the device scale
1613         factor is not correct in high DPI.
1614
1615         Reverted changeset:
1616
1617         "[WinCairo, FTW] Properly handle device scale factor"
1618         https://bugs.webkit.org/show_bug.cgi?id=201361
1619         https://trac.webkit.org/changeset/249366
1620
1621 2019-09-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1622
1623         Long presses that interrupt accelerated scrolling dispatch clicks on apps linked against iOS 12 or earlier
1624         https://bugs.webkit.org/show_bug.cgi?id=201346
1625         <rdar://problem/54885784>
1626
1627         Reviewed by Dean Jackson.
1628
1629         Add a new test option to allow tests to disable link previews.
1630
1631         * WebKitTestRunner/TestController.cpp:
1632         (WTR::updateTestOptionsFromTestHeader):
1633         * WebKitTestRunner/TestOptions.h:
1634
1635         Drive-by fix: also check enableLazyImageLoading when determining whether two TestOptions are the same.
1636
1637         (WTR::TestOptions::hasSameInitializationOptions const):
1638         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1639         (WTR::TestController::platformCreateWebView):
1640
1641 2019-08-30  Brent Fulgham  <bfulgham@apple.com>
1642
1643         [WinCairo, FTW] Properly handle device scale factor
1644         https://bugs.webkit.org/show_bug.cgi?id=201361
1645
1646         Reviewed by Don Olmstead.
1647
1648         Reset zoom to 1.0; device scale is handled elsewhere.
1649
1650         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1651         (WebKitBrowserWindow::resetZoom):
1652
1653 2019-08-30  Zhifei Fang  <zhifei_fang@apple.com>
1654
1655         [results.webkit.org Timeline] Add notify rerender API for timeline
1656         https://bugs.webkit.org/show_bug.cgi?id=201363
1657
1658         Reviewed by Jonathan Bedard.
1659
1660         * resultsdbpy/resultsdbpy/view/static/js/timeline.js: Export notifyRerender API to timeline class
1661         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1662         (XScrollableCanvasProvider): Add an event stream to receive notification that it will need to render 
1663         (prototype.ExpandableSeriesComponent): Notify the rerender when expanded, because this may change the layout.
1664         (prototype.Timeline.CanvasContainer):
1665
1666 2019-08-30  Aakash Jain  <aakash_jain@apple.com>
1667
1668         [ews-build] 're-run-layout-tests' step on macOS-High-Sierra-Debug-WK1-Tests-EWS runs WK2 tests
1669         https://bugs.webkit.org/show_bug.cgi?id=201350
1670
1671         Reviewed by Jonathan Bedard.
1672
1673         * BuildSlaveSupport/ews-build/steps.py:
1674         (RunWebKit1Tests.start): Set build property to use dump-render-tree.
1675         (RunWebKitTests.start): Use dump-render-tree whenever the corresponding build property is set.
1676
1677 2019-08-30  Jonathan Bedard  <jbedard@apple.com>
1678
1679         results.webkit.org: Add endpoints to upload and download archives
1680         https://bugs.webkit.org/show_bug.cgi?id=201100
1681
1682         Reviewed by Aakash Jain.
1683
1684         Add the endpoint to upload and download a zip archive associated with a test run.
1685
1686         * resultsdbpy/resultsdbpy/controller/api_routes.py:
1687         (APIRoutes.__init__): Add archive endpoint.
1688         * resultsdbpy/resultsdbpy/controller/archive_controller.py: Added.
1689         (ArchiveController):
1690         (ArchiveController.__init__):
1691         (ArchiveController.endpoint):
1692         (ArchiveController.download):
1693         (ArchiveController.upload):
1694         * resultsdbpy/resultsdbpy/controller/archive_controller_unittest.py: Added.
1695         (ArchiveControllerUnittest):
1696         * resultsdbpy/resultsdbpy/model/configuration_context.py:
1697         (ClusteredByConfiguration.register_configuration): Make error message more clear.
1698
1699 2019-08-30  Simon Fraser  <simon.fraser@apple.com>
1700
1701         Add system tracing points for compositing updates, and touch-event dispatching
1702         https://bugs.webkit.org/show_bug.cgi?id=201327
1703
1704         Reviewed by Alex Christensen.
1705
1706         * Tracing/SystemTracePoints.plist:
1707
1708 2019-08-30  Keith Rollin  <krollin@apple.com>
1709
1710         Simplify PLATFORM expression
1711         https://bugs.webkit.org/show_bug.cgi?id=201286
1712         <rdar://problem/54822347>
1713
1714         Reviewed by Alexey Proskuryakov.
1715
1716         The preprocessor expression conditionalizing the inclusion of the body
1717         of ExitFullscreenOnEnterPiP.mm evolved into:
1718
1719             #if PLATFORM(MAC) || (PLATFORM(IOS_FAMILY) && !PLATFORM(IOS_FAMILY_SIMULATOR))
1720
1721         Simplify this to just:
1722
1723             #if !PLATFORM(IOS_FAMILY_SIMULATOR)
1724
1725         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
1726
1727 2019-08-30  Keith Rollin  <krollin@apple.com>
1728
1729         Remove AppKitCompatibilityDeclarations.h
1730         https://bugs.webkit.org/show_bug.cgi?id=201283
1731         <rdar://problem/54822042>
1732
1733         Reviewed by Alexey Proskuryakov.
1734
1735         The two copies of these files -- on in WTF, one in MiniBrowser -- are
1736         empty and can be removed.
1737
1738         * DumpRenderTree/mac/EventSendingController.mm:
1739         * DumpRenderTree/mac/TextInputControllerMac.m:
1740         * MiniBrowser/AppKitCompatibilityDeclarations.h: Removed.
1741         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1742         * MiniBrowser/mac/SettingsController.m:
1743         * MiniBrowser/mac/WK1BrowserWindowController.m:
1744         * MiniBrowser/mac/WK2BrowserWindowController.m:
1745         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuImgWithVideo.mm:
1746         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
1747         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
1748         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
1749         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenLayoutConstraints.mm:
1750         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm:
1751         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
1752         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
1753         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1754         * TestWebKitAPI/Tests/WebKitCocoa/UserInitiatedActionInNavigationAction.mm:
1755         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
1756         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
1757         * TestWebKitAPI/Tests/mac/ContextMenuDefaultItemsHaveTags.mm:
1758         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
1759         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm:
1760         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
1761         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1762         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1763         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1764         * WebKitTestRunner/mac/EventSenderProxy.mm:
1765         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1766         * WebKitTestRunner/mac/TestControllerMac.mm:
1767
1768 2019-08-30  Adrian Perez de Castro  <aperez@igalia.com>
1769
1770         [WPE][GTK] New API to remove a filter from an user content manager given its identifier
1771         https://bugs.webkit.org/show_bug.cgi?id=200479
1772
1773         Reviewed by Carlos Garcia Campos.
1774
1775         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
1776         (testUserContentManagerContentFilter): Test also the new
1777         webkit_user_content_manager_remove_filter_by_id() public API function.
1778
1779 2019-08-30  Philippe Normand  <pnormand@igalia.com>
1780
1781         [WPE][Qt] loadingChanged signal parameter is unusable
1782         https://bugs.webkit.org/show_bug.cgi?id=201301
1783
1784         Reviewed by Carlos Garcia Campos.
1785
1786         * MiniBrowser/wpe/qt/main.qml: Add a basic loadingChange signal handler.
1787         * Scripts/webkitpy/style/checker.py: White-list WPEQtView.h for
1788         readablity/parameter_name code styl checker rule.
1789
1790 2019-08-29  Keith Rollin  <krollin@apple.com>
1791
1792         Update .xcconfig symbols to reflect the current set of past and future product versions.
1793         https://bugs.webkit.org/show_bug.cgi?id=200720
1794         <rdar://problem/54305032>
1795
1796         Reviewed by Alex Christensen.
1797
1798         Remove version symbols related to old OS's we no longer support,
1799         ensure that version symbols are defined for OS's we do support.
1800
1801         * ContentExtensionTester/Configurations/Base.xcconfig:
1802         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
1803         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1804         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1805         * ImageDiff/cg/Configurations/Base.xcconfig:
1806         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
1807         * MiniBrowser/Configurations/Base.xcconfig:
1808         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1809         * TestWebKitAPI/Configurations/Base.xcconfig:
1810         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1811         * WebEditingTester/Configurations/Base.xcconfig:
1812         * WebEditingTester/Configurations/DebugRelease.xcconfig:
1813         * WebKitTestRunner/Configurations/Base.xcconfig:
1814         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1815         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1816         * lldb/lldbWebKitTester/Configurations/DebugRelease.xcconfig:
1817
1818 2019-08-29  Keith Rollin  <krollin@apple.com>
1819
1820         Remove empty FontCache.cpp file in TestWebKitAPI
1821         https://bugs.webkit.org/show_bug.cgi?id=201277
1822         <rdar://problem/54820726>
1823
1824         Reviewed by Alex Christensen.
1825
1826         Bug 200694 emptied out the contents of FontCache.cpp. This patch
1827         removes the file from the project.
1828
1829         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1830         * TestWebKitAPI/Tests/WebCore/FontCache.cpp: Removed.
1831
1832 2019-08-29  Aakash Jain  <aakash_jain@apple.com>
1833
1834         [ews-app] Status bubble should only display important messages in pop-over
1835         https://bugs.webkit.org/show_bug.cgi?id=201308
1836
1837         Reviewed by Jonathan Bedard.
1838
1839         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added various build-steps which are of low interest
1840         to end-users in STEPS_TO_HIDE. If any of these steps fail, it will not be hidden.
1841
1842 2019-08-29  Keith Rollin  <krollin@apple.com>
1843
1844         Remove support for macOS < 10.13 (part 3)
1845         https://bugs.webkit.org/show_bug.cgi?id=201224
1846         <rdar://problem/54795934>
1847
1848         Reviewed by Darin Adler.
1849
1850         Remove symbols in WebKitTargetConditionals.xcconfig related to macOS
1851         10.13, including WK_MACOS_1013 and WK_MACOS_BEFORE_1013, and suffixes
1852         like _MACOS_SINCE_1013.
1853
1854         Also added some macOS target numbers.
1855
1856         * TestWebKitAPI/Configurations/WebKitTargetConditionals.xcconfig:
1857
1858 2019-08-29  Jonathan Bedard  <jbedard@apple.com>
1859
1860         results.webkit.org: Remove border from tooltip
1861         https://bugs.webkit.org/show_bug.cgi?id=201239
1862
1863         Reviewed by Alex Christensen.
1864
1865         * resultsdbpy/resultsdbpy/view/static/css/tooltip.css:
1866         (.tooltip-content): Remove border.
1867
1868 2019-08-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1869
1870         [Win] MiniBrowser crashes in WKURLCopyString if WKPageCopyActiveURL returns null
1871         https://bugs.webkit.org/show_bug.cgi?id=201215
1872
1873         Reviewed by Don Olmstead.
1874
1875         MiniBrowser crashed if it was going to go to a unreachable page
1876         because WKPageCopyActiveURL returned a nullptr.
1877
1878         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1879         (createString): Added null checking of the argument.
1880
1881 2019-08-28  Tim Horton  <timothy_horton@apple.com>
1882
1883         Reloading a web view with a fixed-width viewport and variable content width restores the previous page scale, shouldn't
1884         https://bugs.webkit.org/show_bug.cgi?id=201256
1885         <rdar://problem/54809509>
1886
1887         Reviewed by Simon Fraser.
1888
1889         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1890         * TestWebKitAPI/Tests/WebKit/long-email-viewport.html: Added.
1891         * TestWebKitAPI/Tests/WebKitCocoa/ReloadWithDifferingInitialScale.mm: Added.
1892         (TestWebKitAPI::TEST):
1893         Add a test. I left many comments because I had a great deal of trouble
1894         writing this test and wanted to document my findings.
1895
1896 2019-08-28  Jonathan Bedard  <jbedard@apple.com>
1897
1898         results.webkit.org: Do not display branch selector if only one branches available
1899         https://bugs.webkit.org/show_bug.cgi?id=201244
1900
1901         Rubber-stamped by Aakash Jain.
1902
1903         * resultsdbpy/resultsdbpy/view/static/js/drawer.js: Hide the branch selector's
1904         container if there aren't multiple branches to choose from.
1905
1906 2019-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
1907
1908         WKAttachmentTests.DropFolderAsAttachmentAndMoveByDragging fails in some iOS simulator configurations
1909         https://bugs.webkit.org/show_bug.cgi?id=201241
1910         <rdar://problem/54317588>
1911
1912         Reviewed by Tim Horton.
1913
1914         For reasons that are still unknown, it's possible for iOS 13 simulators to get into a state where the IPC
1915         communication delay between the web and UI processes can become extraordinarily long. Under these circumstances,
1916         the drag and drop harness fails to simulate a drop, since it ends up firing all scheduled calls to
1917         -dropInteraction:sessionDidUpdate: before the first response from the web process arrives in the UI process, so
1918         it believes that the web view has rejected the drop from being handled.
1919
1920         Instead, make the drag and drop simulator robust by ensuring a presentation update between drop session updates,
1921         to make sure that the web process has had time to send a response after each update.
1922
1923         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1924         (-[DragAndDropSimulator _advanceProgress]):
1925
1926 2019-08-28  Megan Gardner  <megan_gardner@apple.com>
1927
1928         Null check webFrame when creating a print preview to prevent a crash.
1929         https://bugs.webkit.org/show_bug.cgi?id=201237
1930         <rdar://problem/51618863>
1931
1932         Reviewed by Tim Horton.
1933
1934         Test to verify that if we don't have the WebPageProxy, we will not crash when making a print preview.
1935
1936         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1937         (TEST):
1938
1939 2019-08-28  Jonathan Bedard  <jbedard@apple.com>
1940
1941         results.webkit.org: Move drawer to the right, open by default
1942         https://bugs.webkit.org/show_bug.cgi?id=200977
1943
1944         Rubber-stamped by Aakash Jain.
1945
1946         The drawer was both unpopular and not discoverable. After feedback from bot watchers,
1947         moving the drawer to the right side of the screen, opening it by default and have it displace
1948         instead of hide the main content.
1949
1950         * resultsdbpy/resultsdbpy/view/commit_view_unittest.py:
1951         (CommitViewUnittest.test_drawer): Support new drawer style.
1952         (CommitViewUnittest.test_range_slider): Ditto.
1953         (CommitViewUnittest.test_one_line_switch): Ditto.
1954         (CommitViewUnittest.test_branch_selection): Ditto.
1955         * resultsdbpy/resultsdbpy/view/static/css/drawer.css: Removed.
1956         * resultsdbpy/resultsdbpy/view/static/js/drawer.js:
1957         (setEnableRecursive): Disable all elements underneath this one 
1958         (Drawer): Make drawer a sidebar.
1959         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
1960         (.header>.title, .topbar>.title): Overflow of titles should be hidden.
1961         (:root): Move boldInverseColor into webkit.css.
1962         (@media (prefers-color-scheme: dark)):
1963         (.sidebar): Sidebars on mobile should behave like drawers.
1964         (.sidebar.hidden): Add concept of hidden sidebar.
1965         (.mobile-sidebar-control): Add a control to collapse sidebar that only exists on mobile.
1966         (.mobile-sidebar-control.display):
1967         (.main.under-topbar-with-actions):
1968         (@media screen and (min-width: 600px) and (orientation: landscape)):
1969         (.sidebar.left.hidden):
1970         (.sidebar.right.hidden):
1971         (.main.right.hidden):
1972         (.main.left.hidden):
1973         (@media screen and (min-width: 768px) and (orientation: landscape)):
1974         (.sidebar.right):
1975         (a.disabled): Add ability to disable a link.
1976         (.desktop-control): Add a control which only exists on desktop.
1977         * resultsdbpy/resultsdbpy/view/templates/base.html: Add hamburger drawer-button for mobile.
1978         * resultsdbpy/resultsdbpy/view/templates/commits.html: Use main since Drawer is now a sidebar.
1979         * resultsdbpy/resultsdbpy/view/templates/documentation.html: Ditto.
1980         * resultsdbpy/resultsdbpy/view/templates/search.html: Ditto.
1981         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Ditto.
1982         * resultsdbpy/resultsdbpy/view/view_routes_unittest.py:
1983         (WebSiteTestCase.toggle_drawer): Support new drawer style.
1984         (WebSiteTestCase.find_input_with_name): Ditto.
1985
1986 2019-08-28  Keith Rollin  <krollin@apple.com>
1987
1988         Remove support for macOS < 10.13 (part 2)
1989         https://bugs.webkit.org/show_bug.cgi?id=201197
1990         <rdar://problem/54759985>
1991
1992         Reviewed by Darin Adler.
1993
1994         Update conditionals that reference WK_MACOS_1013 and suffixes like
1995         _MACOS_SINCE_1013, assuming that we're always building on 10.13 or
1996         later and that these conditionals are always True or False.
1997
1998         See Bug 200694 for earlier changes in this area.
1999
2000         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2001
2002 2019-08-28  Alicia Boya García  <aboya@igalia.com>
2003
2004         [MSE][GStreamer] WebKitMediaSrc rework
2005         https://bugs.webkit.org/show_bug.cgi?id=199719
2006
2007         Reviewed by Xabier Rodriguez-Calvar.
2008
2009         Added WebKitMediaSourceGStreamer.cpp to the GStreamer-style coding
2010         whitelist.
2011
2012         * Scripts/webkitpy/style/checker.py:
2013
2014 2019-08-28  Alexey Proskuryakov  <ap@apple.com>
2015
2016         Updating inactive contributors in contributors.json.
2017
2018         * Scripts/webkitpy/common/config/contributors.json:
2019
2020 2019-08-28  Jonathan Bedard  <jbedard@apple.com>
2021
2022         results.webkit.org: Auto-expand single configurations
2023         https://bugs.webkit.org/show_bug.cgi?id=201218
2024
2025         Rubber-stamped by Aakash Jain.
2026
2027         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
2028         (TimelineFromEndpoint.toString): Automatically expand timeline when only one
2029         configuration has been specified.
2030         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
2031         (prototype.ExpandableSeriesComponent): Add options so that the caller can set whether a timeline
2032         is expanded or collapsed by default.
2033
2034 2019-08-28  Jonathan Bedard  <jbedard@apple.com>
2035
2036         results.webkit.org: Sanitize all commit arguments on upload
2037         https://bugs.webkit.org/show_bug.cgi?id=201189
2038         <rdar://problem/54564837>
2039
2040         Reviewed by Aakash Jain.
2041
2042         * resultsdbpy/resultsdbpy/controller/commit.py:
2043         (Commit.__init__): Only allow commits to be constructed with valid values.
2044         * resultsdbpy/resultsdbpy/controller/commit_controller.py:
2045         (CommitController.register): Strip potential API key.
2046         * resultsdbpy/resultsdbpy/controller/commit_unittest.py:
2047         (CommitUnittest.test_invalid): Test that commits which contain html inside the
2048         repository_id, branch or commit id are rejected.
2049
2050 2019-08-02  Claudio Saavedra  <csaavedra@igalia.com>
2051
2052         [GTK][WPE] Implement HSTS for the soup network backend
2053         https://bugs.webkit.org/show_bug.cgi?id=192074
2054
2055         Reviewed by Carlos Garcia Campos.
2056
2057         libsoup 2.67.1 introduced HSTS support via a SoupSessionFeature.
2058         Add support to the soup network backend by adding the feature to
2059         SoupNetworkSession and handling HSTS protocol upgrades, by
2060         propagating the scheme change further to clients. This patch adds
2061         the HSTS feature unconditionally, but it still possible to add
2062         a boolean property to the web context class if desired.
2063
2064         Additionally, add API to the WebKitWebsiteDataManager to specify
2065         the directory where the HSTS database is saved. If the directory
2066         is not set or if the data manager is ephemeral, use a
2067         non-persistent, memory only HSTS enforcer.
2068
2069         Implement as well the methods needed to clean-up and delete HSTS
2070         policies from the storage and expose the feature in GTK+
2071         MiniBrowser's about:data.
2072
2073         * MiniBrowser/gtk/main.c:
2074         (gotWebsiteDataCallback):
2075         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
2076         (serverCallback):
2077         (testWebsiteDataConfiguration):
2078         (testWebsiteDataEphemeral):
2079         (prepopulateHstsData):
2080         (testWebsiteDataHsts):
2081         (beforeAll):
2082         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2083         (Test::Test):
2084         * gtk/jhbuild.modules: Bump libsoup to 2.67.91 for the new APIs
2085         * wpe/jhbuild.modules: Ditto
2086         * MiniBrowser/gtk/main.c:
2087         (gotWebsiteDataCallback):
2088
2089 2019-08-27  James Darpinian  <jdarpinian@google.com>
2090
2091         Fix applying diffs that only change file mode
2092         https://bugs.webkit.org/show_bug.cgi?id=201191
2093
2094         Reviewed by Daniel Bates.
2095
2096         * Scripts/svn-apply:
2097         (patch): Handle case of file mode change without content change
2098
2099 2019-08-27  Aakash Jain  <aakash_jain@apple.com>
2100
2101         [ews] Status bubble should be red for CANCELLED builds
2102         https://bugs.webkit.org/show_bug.cgi?id=201204
2103
2104         Reviewed by Jonathan Bedard.
2105
2106         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2107         (StatusBubble._build_bubble):
2108
2109 2019-08-27  Zhifei Fang  <zhifei_fang@apple.com>
2110
2111         [results.webkit.org Webkit.css] Center the legend symbols
2112         https://bugs.webkit.org/show_bug.cgi?id=201187
2113
2114         Reviewed by Jonathan Bedard.
2115
2116         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
2117         (.lengend>.item .dot .text): center the dot symbol vertically
2118
2119 2019-08-27  Jonathan Bedard  <jbedard@apple.com>
2120
2121         run-webkit-tests: Use -noBulkSymbolication when calling spindump (Follow-up fix)
2122         https://bugs.webkit.org/show_bug.cgi?id=201000
2123         <rdar://problem/53778938>
2124
2125         Unreviewed follow-up fix.
2126
2127         * Scripts/webkitpy/port/darwin.py:
2128         (DarwinPort.sample_process): Run spindump without -noBulkSymbolication if previous
2129         spindump call failed.
2130         * Scripts/webkitpy/port/darwin_testcase.py:
2131         * Scripts/webkitpy/port/ios_device_unittest.py:
2132
2133 2019-08-27  Aakash Jain  <aakash_jain@apple.com>
2134
2135         [ews-build] Use update-webkit script in Apply-WatchList EWS
2136         https://bugs.webkit.org/show_bug.cgi?id=201179
2137
2138         Reviewed by Jonathan Bedard.
2139
2140         * BuildSlaveSupport/ews-build/factories.py:
2141         (WatchListFactory): Updated to use CheckOutSource step as well.
2142
2143 2019-08-27  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2144
2145         W3C test importer should be able to handle expected references with an absolute path.
2146         https://bugs.webkit.org/show_bug.cgi?id=200717
2147
2148         Reviewed by Youenn Fablet.
2149
2150         This patch implements the logic to resolve test references with absolute paths
2151         when importing w3c tests (like web-platform-tests).
2152         When an absolute path is found for a test reference, the parser now
2153         tries to find the right file by looking for a relative path inside
2154         the root directory of the source test repository.
2155         It works when the tool is run in download-mode as well as when the
2156         tool is run to import the tests from a local directory.
2157
2158         This fixes the import of test references for tests like
2159         web-platform-tests/css/css-images/multiple-position-color-stop-linear-2.html
2160
2161         * Scripts/webkitpy/w3c/test_importer.py:
2162         (TestImporter._source_root_directory_for_path):
2163         (TestImporter.find_importable_tests):
2164         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2165         (TestImporterTest.import_directory):
2166         (test_webkit_test_runner_options):
2167         (test_webkit_test_runner_import_reftests_with_absolute_paths_download):
2168         (test_webkit_test_runner_import_reftests_with_absolute_paths_from_source_dir):
2169         * Scripts/webkitpy/w3c/test_parser.py:
2170         (TestParser.__init__):
2171         (TestParser.analyze_test):
2172
2173 2019-08-26  Wenson Hsieh  <wenson_hsieh@apple.com>
2174
2175         Remove UIHelper.activateElementAtHumanSpeed
2176         https://bugs.webkit.org/show_bug.cgi?id=201147
2177
2178         Reviewed by Tim Horton.
2179
2180         Add plumbing for a new script controller hook to wait for the double tap delay to pass. On non-iOS, this
2181         resolves immediately; on iOS, we inspect the content view for tap gestures that require more than one tap, and
2182         find the value of the maximum double tap delay. We then delay for this amount of time before resolving.
2183
2184         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2185         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2186         (WTR::UIScriptController::doAfterDoubleTapDelay):
2187         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
2188         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2189         (WTR::UIScriptControllerIOS::doAfterDoubleTapDelay):
2190
2191 2019-08-26  Zhifei Fang  <zhifei_fang@apple.com>
2192
2193         [results.webkit.org Timline] Add symbols to the timeline dot
2194         https://bugs.webkit.org/show_bug.cgi?id=201105
2195
2196         Reviewed by Jonathan Bedard.
2197
2198         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
2199         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
2200         (Timeline.CanvasSeriesComponent): Modify the drawDot api to provide user ability to add symbol to the dots, it supports unicode symbol
2201         * resultsdbpy/resultsdbpy/view/templates/base.html: Add the encoding UTF-8 for the page, so that we can add unicode symbol to the dots
2202
2203 2019-08-26  Yusuke Suzuki  <ysuzuki@apple.com>
2204
2205         Unreviewed, remove useMaximalFlushInsertionPhase use
2206         https://bugs.webkit.org/show_bug.cgi?id=201036
2207
2208         * Scripts/run-jsc-stress-tests:
2209
2210 2019-08-26  David Kilzer  <ddkilzer@apple.com>
2211
2212         Don't compute upconverted characters twice in buildQuery() in DataDetection.mm
2213         <https://webkit.org/b/201144>
2214         <rdar://problem/54689399>
2215
2216         Reviewed by Brent Fulgham.
2217
2218         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
2219         DataDetectorsTestIOS.mm to the project.
2220         * TestWebKitAPI/Tests/ios/DataDetectorsTestIOS.mm: Add a new
2221         test for Data Detectors for phone numbers.
2222
2223 2019-08-26  Wenson Hsieh  <wenson_hsieh@apple.com>
2224
2225         REGRESSION (iOS 13): Tests that simulate multiple back-to-back single taps fail or time out
2226         https://bugs.webkit.org/show_bug.cgi?id=201129
2227         <rdar://problem/51857277>
2228
2229         Reviewed by Tim Horton.
2230
2231         The tests in editing/pasteboard/ios were timing out on iOS 13 before this change. This is because they simulate
2232         back-to-back single taps; while this is recognized as two single taps on iOS 12 and prior, only the first single
2233         tap is recognized on iOS 13 (and the second is simply dropped on the floor). This occurs because the synthetic
2234         single tap gesture is reset slightly later on iOS 13 compared to iOS 12, so when the second tap is dispatched,
2235         the gesture recognizer is still in "ended" state after the first tap on iOS 13, which means the gesture isn't
2236         capable of recognizing further touches yet.
2237
2238         In UIKit, a gesture recognizer is only reset once its UIGestureEnvironment's containing dependency subgraph no
2239         longer contains gestures that are active. In iOS 12, the synthetic click gesture is a part of a dependency
2240         subgraph that contains only itself and the normal (blocking) double tap gesture which requires the click to fail
2241         before it can be recognized; immediately after simulating the tap, both these gestures are inactive, which
2242         allows both of them to be reset.
2243
2244         However, in iOS 13, the synthetic click gesture is part of a gesture dependency graph that contains the double
2245         tap for double click gesture, as well as the non-blocking double tap gesture, both of which are still active
2246         immediately after sending the first tap. This change in dependencies is caused by the introduction of
2247         UIUndoGestureInteraction's single and double three-finger tap gestures, which (in -[UIUndoGestureInteraction
2248         gestureRecognizer:shouldBeRequiredToFailByGestureRecognizer:]) explicitly add all other taps as failure
2249         requirements. This effectively links the synthetic single tap gesture to most of the other gestures in
2250         WKContentView's dependency graph by way of these tap gestures for the undo interaction.
2251
2252         All this means that there is now a short (~50 ms) delay after the synthetic single tap gestures is recognized,
2253         before it can be recognized again. To account for this new delay in our test infrastructure, simply wait for
2254         single tap gestures that have ended to reset before attempting to send subsequent single taps. We do this by
2255         introducing WebKit testing SPI to invoke a completion handler after resetting the synthetic click gesture (only
2256         if necessary - i.e., if the gesture is in ended state when we are about to begin simulating the tap). This
2257         allows calls to `UIScriptController::singleTapAtPoint` to be reliably recognized as single taps without
2258         requiring arbitrary 120 ms "human speed" delays.
2259
2260         This fixes a number of flaky or failing layout tests, including the tests in editing/pasteboard/ios.
2261
2262         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2263         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2264         (WTR::UIScriptController::doubleTapAtPoint):
2265
2266         Add a `delay` parameter to `doubleTapAtPoint`. A number of layout tests were actually simulating double click
2267         gestures by simulating two back-to-back single taps; this is done for the purposes of being able to add a "human
2268         speed" delay prior to the second single tap gesture. After the change to wait for the single tap gesture to
2269         reset before attempting to simulate the next tap, this strategy no longer works, since the second gesture is
2270         recognized only as a single tap instead of a double tap.
2271
2272         Instead, we add a delay parameter to `UIScriptController::doubleTapAtPoint`, which the "human speed" double tap
2273         gestures use instead to wait after simulating the first tap.
2274
2275         * WebKitTestRunner/ios/HIDEventGenerator.h:
2276         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2277         (-[HIDEventGenerator _waitFor:]):
2278         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:delay:completionBlock:]):
2279
2280         Plumb the tap gesture delay through to this helper method.
2281
2282         (-[HIDEventGenerator tap:completionBlock:]):
2283         (-[HIDEventGenerator doubleTap:delay:completionBlock:]):
2284         (-[HIDEventGenerator twoFingerTap:completionBlock:]):
2285         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]): Deleted.
2286         (-[HIDEventGenerator doubleTap:completionBlock:]): Deleted.
2287         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
2288         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2289         (WTR::UIScriptControllerIOS::waitForSingleTapToReset const):
2290
2291         Add a new helper to wait for the content view's single tap gesture to reset if needed; call this before
2292         attempting to simulate single taps (either using a stylus, or with a regular touch).
2293
2294         (WTR::UIScriptControllerIOS::singleTapAtPointWithModifiers):
2295         (WTR::UIScriptControllerIOS::doubleTapAtPoint):
2296         (WTR::UIScriptControllerIOS::stylusTapAtPointWithModifiers):
2297
2298 2019-08-26  Jonathan Bedard  <jbedard@apple.com>
2299
2300         results.webkit.org: Allow clicking on the tooltip arrow
2301         https://bugs.webkit.org/show_bug.cgi?id=201103
2302
2303         Rubber-stamped by Aakash Jain.
2304
2305         By design, the arrow sits above the canvas and intercepts mouse events from it.
2306         This will often make an element that has a tooltip unclickable.
2307
2308         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
2309         (xAxisFromScale):
2310         (TimelineFromEndpoint.prototype.render.onDotEnterFactory):
2311         (TimelineFromEndpoint.prototype.render):
2312         * resultsdbpy/resultsdbpy/view/static/js/tooltip.js:
2313         (_ToolTip):
2314         (_ToolTip.prototype.toString): Trigger onClick callback when the arrow is clicked.
2315         (_ToolTip.prototype.set): Set the onClick callback.
2316
2317 2019-08-26  Aakash Jain  <aakash_jain@apple.com>
2318
2319         [EWS] Do not append additional '(failure)' string at the end of custom failure message in EWS Buildbot
2320         https://bugs.webkit.org/show_bug.cgi?id=201140
2321
2322         Reviewed by Jonathan Bedard.
2323
2324         * BuildSlaveSupport/ews-build/steps.py:
2325         (TestWithFailureCount.getResultSummary): Do not append (failure) when in case of custom status.
2326         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
2327
2328 2019-08-26  Jonathan Bedard  <jbedard@apple.com>
2329
2330         run-webkit-tests: Cap the number of automatically booted simulators at 12
2331         https://bugs.webkit.org/show_bug.cgi?id=201139
2332
2333         Reviewed by Aakash Jain.
2334
2335         To make local development with simulators more pleasant, machines should
2336         never automatically boot more than 12 simulators.
2337
2338         * Scripts/webkitpy/xcode/simulated_device.py:
2339         (SimulatedDeviceManager.max_supported_simulators):
2340
2341 2019-08-26  Aakash Jain  <aakash_jain@apple.com>
2342
2343         [ews] Add EWS queue for applying watchlist
2344         https://bugs.webkit.org/show_bug.cgi?id=201072
2345
2346         Reviewed by Jonathan Bedard.
2347
2348         * BuildSlaveSupport/ews-build/steps.py:
2349         (ApplyWatchList): Build step to apply watchlist.
2350         (ApplyWatchList.__init__): Set logEnviron to False.
2351         (ApplyWatchList.getResultSummary): Updated the description in case of failure.
2352         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2353         * BuildSlaveSupport/ews-build/factories.py:
2354         (WatchListFactory): Build factory for WatchList.
2355         * BuildSlaveSupport/ews-build/loadConfig.py:
2356         * BuildSlaveSupport/ews-build/config.json:
2357
2358 2019-08-26  Youenn Fablet  <youenn@apple.com>
2359
2360         Add a WebsiteDataStore delegate to handle AuthenticationChallenge that do not come from pages
2361         https://bugs.webkit.org/show_bug.cgi?id=196870
2362
2363         Reviewed by Alex Christensen.
2364
2365         Implement the new delegate by respecting the value set by testRunner.setAllowsAnySSLCertificate
2366         Accept any server certificate by default.
2367
2368         * WebKitTestRunner/TestController.cpp:
2369         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2370         (WTR::TestController::cocoaResetStateToConsistentValues):
2371         (WTR::TestController::setAllowsAnySSLCertificate):
2372         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.h:
2373         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2374         (-[TestWebsiteDataStoreDelegate didReceiveAuthenticationChallenge:completionHandler:]):
2375         (-[TestWebsiteDataStoreDelegate setAllowAnySSLCertificate:]):
2376
2377 2019-08-23  Aakash Jain  <aakash_jain@apple.com>
2378
2379         Increase log level for watchlist result
2380         https://bugs.webkit.org/show_bug.cgi?id=201081
2381
2382         Reviewed by Jonathan Bedard.
2383
2384         * Scripts/webkitpy/tool/steps/applywatchlist.py: Increased log level.
2385         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py: Updated unit-tests.
2386         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Ditto.
2387
2388 2019-08-23  Chris Dumez  <cdumez@apple.com>
2389
2390         [geolocation] Rename interfaces and remove [NoInterfaceObject]
2391         https://bugs.webkit.org/show_bug.cgi?id=200885
2392
2393         Reviewed by Alex Christensen.
2394
2395         * DumpRenderTree/mac/TestRunnerMac.mm:
2396         (TestRunner::setMockGeolocationPosition):
2397
2398 2019-08-23  Ryan Haddad  <ryanhaddad@apple.com>
2399
2400         Unreviewed, rolling out r249001.
2401
2402         Caused one layout test to fail on all configurations and
2403         another to time out on Catalina / iOS 13.
2404
2405         Reverted changeset:
2406
2407         "Add a WebsiteDataStore delegate to handle
2408         AuthenticationChallenge that do not come from pages"
2409         https://bugs.webkit.org/show_bug.cgi?id=196870
2410         https://trac.webkit.org/changeset/249001
2411
2412 2019-08-23  Jonathan Bedard  <jbedard@apple.com>
2413
2414         results.webkit.org: Escape html in changelog
2415         https://bugs.webkit.org/show_bug.cgi?id=201025
2416         <rdar://problem/54564837>
2417
2418         Reviewed by Darin Adler.
2419
2420         * resultsdbpy/resultsdbpy/view/commit_view.py:
2421         (CommitView.commit): Output a dictionary instead of a JSON encoded string.
2422         * resultsdbpy/resultsdbpy/view/templates/commit.html: Unpack commits dictionary
2423         directly into a JavaScript dictionary.
2424
2425 2019-08-20  Jiewen Tan  <jiewen_tan@apple.com>
2426
2427         [WebAuthn] Support NFC authenticators for iOS
2428         https://bugs.webkit.org/show_bug.cgi?id=188624
2429         <rdar://problem/43354214>
2430
2431         Reviewed by Chris Dumez.
2432
2433         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2434         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
2435         Setup NFC mock testing configuration.
2436
2437 2019-08-23  Aakash Jain  <aakash_jain@apple.com>
2438
2439         [ews] Enable Style queue on new EWS
2440         https://bugs.webkit.org/show_bug.cgi?id=201071
2441
2442         Reviewed by Jonathan Bedard.
2443
2444         * BuildSlaveSupport/ews-build/config.json: Enabled the scheduler for Style queue.
2445         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Enabled style queue bubble on new EWS.
2446         * QueueStatusServer/config/queues.py: Removed style queue from old EWS.
2447         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2448         (BubbleQueueServer): Removed style queue from bot-watcher's dashboard.
2449
2450 2019-08-22  Fujii Hironori  <Hironori.Fujii@sony.com>
2451
2452         [Win][MiniBrowser] URL bar should be updated for in-page navigations
2453         https://bugs.webkit.org/show_bug.cgi?id=201032
2454
2455         Reviewed by Darin Adler.
2456
2457         * MiniBrowser/win/BrowserWindow.h: Added activeURLChanged to BrowserWindowClient interface.
2458         * MiniBrowser/win/MainWindow.cpp:
2459         (MainWindow::init):
2460         (MainWindow::activeURLChanged): Added.
2461         * MiniBrowser/win/MainWindow.h:
2462         * MiniBrowser/win/MiniBrowserWebHost.cpp:
2463         (MiniBrowserWebHost::didCommitLoadForFrame):
2464         (MiniBrowserWebHost::didChangeLocationWithinPageForFrame): Added.
2465         (MiniBrowserWebHost::updateAddressBar): Deleted.
2466         (MiniBrowserWebHost::loadURL): Deleted.
2467         * MiniBrowser/win/MiniBrowserWebHost.h:
2468         (MiniBrowserWebHost::MiniBrowserWebHost):
2469         (MiniBrowserWebHost::didCommitLoadForFrame): Deleted.
2470         (MiniBrowserWebHost::didChangeLocationWithinPageForFrame): Deleted.
2471         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2472         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2473         (WebKitBrowserWindow::create):
2474         (WebKitBrowserWindow::WebKitBrowserWindow):
2475         (WebKitBrowserWindow::didChangeIsLoading): Removed an unused variable.
2476         (WebKitBrowserWindow::didChangeActiveURL): Added.
2477         (WebKitBrowserWindow::createNewPage):
2478         (WebKitBrowserWindow::didCommitNavigation): Deleted.
2479         * MiniBrowser/win/WebKitBrowserWindow.h: Removed m_urlBarWnd.
2480         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2481         (WebKitLegacyBrowserWindow::create):
2482         (WebKitLegacyBrowserWindow::WebKitLegacyBrowserWindow):
2483         (WebKitLegacyBrowserWindow::init):
2484         (WebKitLegacyBrowserWindow::navigateToHistory):
2485         * MiniBrowser/win/WebKitLegacyBrowserWindow.h: Removed m_urlBarWnd.
2486
2487 2019-08-22  Andy Estes  <aestes@apple.com>
2488
2489         [watchOS] Disable Content Filtering in the simulator build
2490         https://bugs.webkit.org/show_bug.cgi?id=201047
2491
2492         Reviewed by Tim Horton.
2493
2494         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2495
2496 2019-08-22  Chris Dumez  <cdumez@apple.com>
2497
2498         Try to recover nicely when getting an unexpected schema in the service workers database
2499         https://bugs.webkit.org/show_bug.cgi?id=201002
2500         <rdar://problem/54574991>
2501
2502         Reviewed by Youenn Fablet.
2503
2504         Add API test coverage.
2505
2506         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2507         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2508
2509 2019-08-22  Keith Rollin  <krollin@apple.com>
2510
2511         Remove support for tvOS < 13.0
2512         https://bugs.webkit.org/show_bug.cgi?id=200963
2513         <rdar://problem/54541355>
2514
2515         Reviewed by Tim Horton.
2516
2517         Update conditionals that reference __TV_OS_VERSION_MIN_REQUIRED and
2518         __TV_OS_VERSION_MAX_ALLOWED, assuming that they both have values >=
2519         130000. This means that expressions like "__TV_OS_VERSION_MIN_REQUIRED
2520         < 130000" are always False and "__TV_OS_VERSION_MIN_REQUIRED >=
2521         130000" are always True.
2522
2523         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
2524         (TestWebKitAPI::TEST):
2525
2526 2019-08-22  Daniel Bates  <dabates@apple.com>
2527
2528         [lldb-webkit] OptionSet summary shows size 0 sometimes for non-empty set
2529         https://bugs.webkit.org/show_bug.cgi?id=200742
2530
2531         Reviewed by Simon Fraser.
2532
2533         The OptionSet synthetic provider must respond to requests for the value of m_storage
2534         (i.e. GetChildMemberWithName('m_storage')) to avoid interfering with the computation
2535         of the type summary.
2536
2537         Synthetic providers substitute alternative debug information (children) for the default
2538         information for a variable. The OptionSet type summary is implemented in terms of the
2539         OptionSet synthetic provider to maximize code reuse. If LLDB instantiates the provider
2540         before invoking the type summary handler then evaluating GetChildMemberWithName() on
2541         the SBValue passed to the type summary handler will access the substitute information
2542         instead of the original debug information. As a result OptionSet's synthetic provider's
2543         get_child_index('m_storage') returns None hence SBValue.GetChildMemberWithName('m_storage')
2544         returned an invalid value; => WTFOptionSetProvider._bitmask() returns 0; => the size
2545         reported in the type summary for the OptionSet is 0. Instead get_child_index('m_storage')
2546         should return a valid value.
2547
2548         * lldb/lldb_webkit.py:
2549         (FlagEnumerationProvider.__init__):
2550         (FlagEnumerationProvider):
2551         (FlagEnumerationProvider._get_child_index): Added. WTFOptionSetProvider will override.
2552         (FlagEnumerationProvider._get_child_at_index): Added. WTFOptionSetProvider will override.
2553         (FlagEnumerationProvider.size): Added.
2554         (FlagEnumerationProvider.get_child_index): Modified to call _get_child_index().
2555         (FlagEnumerationProvider.get_child_at_index): Modified to call _get_child_at_index().
2556         (FlagEnumerationProvider.update): Moved initialization of self._elements to the constructor
2557         and removed self.size. For the latter we can just expose a getter that returns the size of
2558         the list self._elements.
2559         (WTFOptionSetProvider._get_child_index): Added. Return the index for LLDB to query for the
2560         value of m_storage.
2561         (WTFOptionSetProvider):
2562         (WTFOptionSetProvider._get_child_at_index): Added. Return the value for m_storage if it
2563         matches the specified index.
2564         * lldb/lldb_webkit_unittest.py:
2565         (TestSummaryProviders.serial_test_WTFOptionSetProvider_empty): Update expected result now
2566         that we return the value of m_storage as the last synthetic child.
2567
2568 2019-08-22  Jonathan Bedard  <jbedard@apple.com>
2569
2570         results.webkit.org: Remove branch and repository information from commit tooltip
2571         https://bugs.webkit.org/show_bug.cgi?id=201035
2572
2573         Reviewed by Aakash Jain.
2574
2575         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
2576         (xAxisFromScale): Remove branch and repository information from tooltip.
2577
2578 2019-08-22  Jonathan Bedard  <jbedard@apple.com>
2579
2580         run-webkit-tests: Use -noBulkSymbolication when calling spindump
2581         https://bugs.webkit.org/show_bug.cgi?id=201000
2582         <rdar://problem/53778938>
2583
2584         Reviewed by Alexey Proskuryakov.
2585
2586         * Scripts/webkitpy/port/darwin.py:
2587         (DarwinPort.sample_process): Attempt to symbolicate with -noBulkSymbolication first.
2588         * Scripts/webkitpy/port/darwin_testcase.py:
2589         (DarwinTest.test_tailspin):
2590         (DarwinTest.test_get_crash_log): Deleted.
2591         * Scripts/webkitpy/port/ios_device_unittest.py:
2592         (IOSDeviceTest.test_tailspin):
2593
2594 2019-08-22  Zhifei Fang  <zhifei_fang@apple.com>
2595
2596         [results.webkit.org Webkit.css] Change input's disable style
2597         The disable input style will always show the label like it has a value 
2598         https://bugs.webkit.org/show_bug.cgi?id=200998
2599
2600         Reviewed by Jonathan Bedard.
2601
2602         * resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml: Adding a new example for disabled input that already has a value
2603         *resultsdbpy/resultsdbpy/view/static/library/css/generate-webkit-css-docs:
2604         * resultsdbpy/resultsdbpy/view/static/library/css/index.html:
2605         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
2606         (.input>input[type="text"][required][disabled],.input>input[type="number"][required][disabled],):When disabling a text input element even without a value, the style should match the style of a text input element with a value
2607         (.input>input[type="text"][required][disabled]~label, .input>input[type="number"][required][disabled]~label,):
2608         (@media (prefers-color-scheme: dark)):
2609
2610 2019-08-17  Darin Adler  <darin@apple.com>
2611
2612         Use makeString and multi-argument StringBuilder::append instead of less efficient multiple appends
2613         https://bugs.webkit.org/show_bug.cgi?id=200862
2614
2615         Reviewed by Ryosuke Niwa.
2616
2617         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2618         (WTR::TestRunner::statisticsDidRunTelemetryCallback): Use makeString.
2619         * WebKitTestRunner/TestController.cpp:
2620         (WTR::TestController::findAndDumpWebKitProcessIdentifiers): Ditto.
2621         (WTR::TestController::downloadDidReceiveServerRedirectToURL): Ditto.
2622         (WTR::TestController::downloadDidFail): Ditto.
2623
2624 2019-08-22  clopez@igalia.com  <clopez@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
2625
2626         [GTK][WPE] Support for command "--version" on the MiniBrowser (follow-up fix)
2627         https://bugs.webkit.org/show_bug.cgi?id=200978
2628
2629         Unreviewed follow-up fix.
2630
2631         Update the string format specifier for unsigned it.
2632
2633         * MiniBrowser/gtk/main.c:
2634         (main):
2635         * MiniBrowser/wpe/main.cpp:
2636         (main):
2637
2638 2019-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2639
2640         [GTK][WPE] Support for command "--version" on the MiniBrowser
2641         https://bugs.webkit.org/show_bug.cgi?id=200978
2642
2643         Reviewed by Žan Doberšek.
2644
2645         Printing the engine version used from the MiniBrowser is useful.
2646         For example, the test scripts on WPT can use this info to better
2647         tag the generated results.
2648
2649         * MiniBrowser/gtk/main.c: Print the engine version when called with --version or -v.
2650         (main):
2651         * MiniBrowser/wpe/main.cpp: Ditto.
2652         (main):
2653
2654 2019-08-22  Youenn Fablet  <youenn@apple.com>
2655
2656         Add a WebsiteDataStore delegate to handle AuthenticationChallenge that do not come from pages
2657         https://bugs.webkit.org/show_bug.cgi?id=196870
2658
2659         Reviewed by Alex Christensen.
2660
2661         Implement the new delegate by respecting the value set by testRunner.setAllowsAnySSLCertificate
2662         Accept any server certificate by default.
2663
2664         * WebKitTestRunner/TestController.cpp:
2665         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2666         (WTR::TestController::cocoaResetStateToConsistentValues):
2667         (WTR::TestController::setAllowsAnySSLCertificate):
2668         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.h:
2669         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2670         (-[TestWebsiteDataStoreDelegate didReceiveAuthenticationChallenge:completionHandler:]):
2671         (-[TestWebsiteDataStoreDelegate setAllowAnySSLCertificate:]):
2672
2673 2019-08-21  Jonathan Bedard  <jbedard@apple.com>
2674
2675         results.webkit.org: Fix drawer style
2676         https://bugs.webkit.org/show_bug.cgi?id=200988
2677
2678         Rubber-stamped by Aakash Jain.
2679
2680         * resultsdbpy/resultsdbpy/view/static/js/drawer.js:
2681         (Drawer): Nothing in the drawer should be selectable.
2682         (ConfigurationSelectors): Standardize text size, remove underscore from expanders.
2683         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
2684         (.action:hover): Disable underline on 'links' which are actually actions
2685         (.unselectable): Make a div unselectable.
2686         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
2687         (Timeline.ExpandableSeriesWithHeaderExpanderComponent): Remove underscore from expanders.
2688
2689 2019-08-21  Fujii Hironori  <Hironori.Fujii@sony.com>
2690
2691         [Win][MiniBrowser] Add a progress indicator to the main window
2692         https://bugs.webkit.org/show_bug.cgi?id=200970
2693
2694         Reviewed by Alex Christensen.
2695
2696         * MiniBrowser/win/BrowserWindow.h: Added BrowserWindowClient class.
2697         * MiniBrowser/win/MainWindow.cpp:
2698         (MainWindow::init):
2699         (MainWindow::resizeSubViews):
2700         (MainWindow::progressChanged):
2701         (MainWindow::progressFinished):
2702         * MiniBrowser/win/MainWindow.h: Inherited BrowserWindowClient.
2703         Added m_hProgressIndicator.
2704         (MainWindow::hwnd const): Deleted.
2705         (MainWindow::browserWindow const): Deleted.
2706         (): Deleted.
2707         * MiniBrowser/win/MiniBrowserWebHost.cpp:
2708         (MiniBrowserWebHost::onNotify):
2709         * MiniBrowser/win/MiniBrowserWebHost.h:
2710         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2711         (WebKitBrowserWindow::create):
2712         (WebKitBrowserWindow::WebKitBrowserWindow):
2713         (WebKitBrowserWindow::didChangeIsLoading):
2714         (WebKitBrowserWindow::didChangeEstimatedProgress):
2715         (WebKitBrowserWindow::createNewPage):
2716         * MiniBrowser/win/WebKitBrowserWindow.h:
2717         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2718         (WebKitLegacyBrowserWindow::create):
2719         (WebKitLegacyBrowserWindow::WebKitLegacyBrowserWindow):
2720         (WebKitLegacyBrowserWindow::init):
2721         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
2722
2723 2019-08-21  Ryan Haddad  <ryanhaddad@apple.com>
2724
2725         Unreviewed, rolling out r248970.
2726
2727         Caused
2728         lldb_webkit_unittest.TestSummaryProviders.serial_test_WTFOptionSetProvider_empty
2729         to fail.
2730
2731         Reverted changeset:
2732
2733         "[lldb-webkit] OptionSet summary shows size 0 sometimes for
2734         non-empty set"
2735         https://bugs.webkit.org/show_bug.cgi?id=200742
2736         https://trac.webkit.org/changeset/248970
2737
2738 2019-08-21  Jonathan Bedard  <jbedard@apple.com>
2739
2740         results.webkit.org: Add database table to save zip archives to
2741         https://bugs.webkit.org/show_bug.cgi?id=200718
2742
2743         Rubber-stamped by Aakash Jain.
2744
2745         * resultsdbpy/resultsdbpy/model/archive_context.py: Added.
2746         (ArchiveContext):
2747         (ArchiveContext.ArchivesByCommit): Store archives to be retrieved by commit and configuration.
2748         (ArchiveContext.ArchivesByCommit.unpack):
2749         (ArchiveContext.assert_zipfile):
2750         (ArchiveContext.open_zipfile):
2751         (ArchiveContext.__init__):
2752         (ArchiveContext.__enter__):
2753         (ArchiveContext.__exit__):
2754         (ArchiveContext.register): Save the provided archive to Cassandra.
2755         (ArchiveContext.find_archive): Find all archives matching the specified criteria.
2756         (ArchiveContext._files_for_archive):
2757         (ArchiveContext.ls): List all files in the matching archives.
2758         (ArchiveContext.file): Extract a file from the matching archives.
2759         * resultsdbpy/resultsdbpy/model/archive_context_unittest.py: Added.
2760         (ArchiveContextTest):
2761         * resultsdbpy/resultsdbpy/model/mock_model_factory.py:
2762         (MockModelFactory):
2763         (MockModelFactory.process_results):
2764         (MockModelFactory.add_mock_archives):
2765         * resultsdbpy/resultsdbpy/model/model.py:
2766         (Model.__init__): Add an ArchiveContext to the model.
2767
2768 2019-08-21  Aakash Jain  <aakash_jain@apple.com>
2769
2770         [ews-build] view layout test results option should be displayed next to layout-test build step
2771         https://bugs.webkit.org/show_bug.cgi?id=200048
2772
2773         Reviewed by Jonathan Bedard.
2774
2775         * BuildSlaveSupport/ews-build/steps.py:
2776         (ExtractTestResults.getLastBuildStepByName): Method to return the last build-step matching the step name.
2777         (ExtractTestResults.addCustomURLs): Add urls to corresponding layout-test step.
2778
2779 2019-08-21  Aakash Jain  <aakash_jain@apple.com>
2780
2781         [ews] Fix capitalization in Found x new Test failure message
2782         https://bugs.webkit.org/show_bug.cgi?id=201004
2783
2784         Reviewed by Alexey Proskuryakov.
2785
2786         * BuildSlaveSupport/ews-build/steps.py:
2787         (AnalyzeLayoutTestsResults.report_failure):
2788         (AnalyzeAPITestsResults.analyzeResults):
2789         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
2790
2791 2019-08-21  Aakash Jain  <aakash_jain@apple.com>
2792
2793         Assign ews117 to EWS High-Sierra Debug queues
2794         https://bugs.webkit.org/show_bug.cgi?id=200993
2795
2796         Reviewed by Jonathan Bedard.
2797
2798         * BuildSlaveSupport/ews-build/config.json:
2799
2800 2019-08-21  Daniel Bates  <dabates@apple.com>
2801
2802         [lldb-webkit] OptionSet summary shows size 0 sometimes for non-empty set
2803         https://bugs.webkit.org/show_bug.cgi?id=200742
2804
2805         Reviewed by Simon Fraser.
2806
2807         The OptionSet synthetic provider must respond to requests for the value of m_storage
2808         (i.e. GetChildMemberWithName('m_storage')) to avoid interfering with the computation
2809         of the type summary.
2810
2811         Synthetic providers substitute alternative debug information (children) for the default
2812         information for a variable. The OptionSet type summary is implemented in terms of the
2813         OptionSet synthetic provider to maximize code reuse. If LLDB instantiates the provider
2814         before invoking the type summary handler then evaluating GetChildMemberWithName() on
2815         the SBValue passed to the type summary handler will access the substitute information
2816         instead of the original debug information. As a result OptionSet's synthetic provider's
2817         get_child_index('m_storage') returns None hence SBValue.GetChildMemberWithName('m_storage')
2818         returned an invalid value; => WTFOptionSetProvider._bitmask() returns 0; => the size
2819         reported in the type summary for the OptionSet is 0. Instead get_child_index('m_storage')
2820         should return a valid value.
2821
2822         * lldb/lldb_webkit.py:
2823         (FlagEnumerationProvider.__init__):
2824         (FlagEnumerationProvider):
2825         (FlagEnumerationProvider._get_child_index): Added. WTFOptionSetProvider will override.
2826         (FlagEnumerationProvider._get_child_at_index): Added. WTFOptionSetProvider will override.
2827         (FlagEnumerationProvider.size): Added.
2828         (FlagEnumerationProvider.get_child_index): Modified to call _get_child_index().
2829         (FlagEnumerationProvider.get_child_at_index): Modified to call _get_child_at_index().
2830         (FlagEnumerationProvider.update): Moved initialization of self._elements to the constructor
2831         and removed self.size. For the latter we can just expose a getter that returns the size of
2832         the list self._elements.
2833         (WTFOptionSetProvider._get_child_index): Added. Return the index for LLDB to query for the
2834         value of m_storage.
2835         (WTFOptionSetProvider):
2836         (WTFOptionSetProvider._get_child_at_index): Added. Return the value for m_storage if it
2837         matches the specified index.
2838
2839 2019-08-21  Alex Christensen  <achristensen@webkit.org>
2840
2841         Disabling text autosizing should prevent text autosizing
2842         https://bugs.webkit.org/show_bug.cgi?id=200955
2843         <rdar://problem/48095374>
2844
2845         Reviewed by Simon Fraser.
2846
2847         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2848         * TestWebKitAPI/Tests/WebKitCocoa/TextSize.mm: Added.
2849         (TEST):
2850
2851 2019-08-21  Adrian Perez de Castro  <aperez@igalia.com>
2852
2853         [GTK][WPE] Make debug-test-runner work
2854         https://bugs.webkit.org/show_bug.cgi?id=193576
2855
2856         Reviewed by Michael Catanzaro.
2857
2858         * Scripts/webkitdirs.pm:
2859         (wrapperPrefixIfNeeded): Only add the wrapper prefix when not running inside a Flatpak sandbox.
2860         (setupUnixWebKitEnvironment): Added, sets TEST_RUNNER_INJECTED_BUNDLE_FILENAME and
2861         TEST_RUNNER_TEST_PLUGIN_PATH in the environment.
2862         (execUnixAppForDebugging): Added.
2863         (debugWebKitTestRunner): Alternatively, use execUnixAppForDebugging() for the WPE and GTK+ ports.
2864
2865 2019-08-20  Ryosuke Niwa  <rniwa@webkit.org>
2866
2867         Put keygen element behind a runtime flag and disable it by default
2868         https://bugs.webkit.org/show_bug.cgi?id=200850
2869
2870         Reviewed by Antti Koivisto.
2871
2872         Added the support for enableKeygenElement test runner option, which enables keygen element in layout tests.
2873
2874         * DumpRenderTree/TestOptions.cpp:
2875         (TestOptions::TestOptions):
2876         * DumpRenderTree/TestOptions.h:
2877         * DumpRenderTree/mac/DumpRenderTree.mm:
2878         (setWebPreferencesForTestOptions):
2879         * DumpRenderTree/win/DumpRenderTree.cpp:
2880         (setWebPreferencesForTestOptions):
2881         * WebKitTestRunner/TestController.cpp:
2882         (WTR::TestController::resetPreferencesToConsistentValues):
2883         (WTR::updateTestOptionsFromTestHeader):
2884         * WebKitTestRunner/TestOptions.h:
2885         (WTR::TestOptions::hasSameInitializationOptions const):
2886
2887 2019-08-21  Chris Dumez  <cdumez@apple.com>
2888
2889         Add internal setting to disable SecureContext checks
2890         https://bugs.webkit.org/show_bug.cgi?id=200980
2891         <rdar://problem/54438512>
2892
2893         Reviewed by Alex Christensen.
2894
2895         Add API test coverage.
2896
2897         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
2898         (log):
2899         (requestPermission):
2900
2901 2019-08-21  Keith Rollin  <krollin@apple.com>
2902
2903         Remove support for watchOS < 6.0
2904         https://bugs.webkit.org/show_bug.cgi?id=200937
2905         <rdar://problem/54524009>
2906
2907         Reviewed by Darin Adler.
2908
2909         Update conditionals that reference __WATCH_OS_VERSION_MIN_REQUIRED and
2910         __WATCH_OS_VERSION_MAX_ALLOWED, assuming that they both have values >=
2911         60000. This means that expressions like
2912         "__WATCH_OS_VERSION_MIN_REQUIRED < 60000" are always False and
2913         "__WATCH_OS_VERSION_MIN_REQUIRED >= 60000" are always True.
2914
2915         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
2916         (TestWebKitAPI::TEST):
2917
2918 2019-08-20  Zhifei Fang  <zhifei_fang@apple.com>
2919
2920         [results.webkit.org Webkit.css] Add right sidebar
2921         https://bugs.webkit.org/show_bug.cgi?id=200946
2922
2923         Reviewed by Jonathan Bedard.
2924
2925         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
2926         (@media screen and (min-width: 600px) and (orientation: landscape)):
2927         (.main.left):
2928         (@media screen and (min-width: 768px) and (orientation: landscape)):
2929         (.sidebar.right):
2930
2931 2019-08-20  Jonathan Bedard  <jbedard@apple.com>
2932
2933         results.webkit.org: Add ToolTips
2934         https://bugs.webkit.org/show_bug.cgi?id=200801
2935
2936         Rubber-stamped by Aakash Jain.
2937
2938         When dots or scale labels are hovered over, we should display a tool tip with additional information about
2939         The specific element.
2940
2941         * resultsdbpy/resultsdbpy/view/static/css/tooltip.css: Added.
2942         (.tooltip): Add class for ToolTip text box.
2943         (.tooltip-arrow-up): Add class for ToolTip arrow pointing up.
2944         (.tooltip-arrow-down): Add class for ToolTip arrow pointing down.
2945         * resultsdbpy/resultsdbpy/view/static/js/commit.js:
2946         (_CommitBank.prototype.commitsDuringUuid): Return a list of commits which were the trunk of their respective
2947         repositories at a given time.
2948         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
2949         (xAxisFromScale): Add callbacks triggered when the mouse enters or leaves elements in the scale canvas.
2950         (TimelineFromEndpoint.render): Add callbacks triggered when the mouse enters or leaves dot elements.
2951         * resultsdbpy/resultsdbpy/view/static/js/tooltip.js: Added.
2952         (isPointInElement): Given an element and a point, return true if that point is within the bounds of the element.
2953         (_ToolTip):
2954         (_ToolTip.prototype.set): Set the content and location of the ToolTip.
2955         (_ToolTip.prototype.toString): Return the html needed to render the ToolTip.
2956         (_ToolTip.prototype.unset): Clear and hide the ToolTip.
2957         (_ToolTip.prototype.isIn): Check if a given point is contained within the ToolTip.
2958         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
2959         (Timeline.CanvasSeriesComponent): Convert onHover events to onEnter/onLeave events. Add toolTips points to both
2960         dot and scale elements.
2961         * resultsdbpy/resultsdbpy/view/templates/search.html: Add ToolTip.
2962         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Ditto.
2963
2964 2019-08-20  Justin Michaud  <justin_michaud@apple.com>
2965
2966         Fix InBounds speculation of typed array PutByVal and add extra step to integer range optimization to search for equality relationships on the RHS value
2967         https://bugs.webkit.org/show_bug.cgi?id=200782
2968
2969         Reviewed by Saam Barati.
2970
2971         * Scripts/run-jsc-stress-tests:
2972
2973 2019-08-20  Darin Adler  <darin@apple.com>
2974
2975         Variadic StringBuilder::append does not handle upconverting from 8-bit to 16-bit correctly
2976         https://bugs.webkit.org/show_bug.cgi?id=200921
2977
2978         Reviewed by Saam Barati.
2979
2980         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2981         Changed tests to use EXPECT macros instead of ASSERT macros since we don't
2982         need to abort after the first failure. Added three new tests to the VariadicAppend
2983         test to cover various cases of upconverting from 8-bit to 16-bit strings.
2984
2985 2019-08-20  Dean Jackson  <dino@apple.com>
2986
2987         REGRESSION: Open in New Tab is missing from context menu
2988         https://bugs.webkit.org/show_bug.cgi?id=200909
2989         <rdar://problem/54476169>
2990
2991         Reviewed by Simon Fraser.
2992
2993         Add a new test that runs through the legacy context menu
2994         flow, and verifies that it will be called if there aren't
2995         appropriate delegates for the new API.
2996
2997         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
2998         (contextMenuWebViewDriver):
2999         (-[TestContextMenuUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
3000         (TEST):
3001         (-[LegacyPreviewViewController previewActionItems]):
3002         (-[LegacyContextMenuUIDelegate webView:shouldPreviewElement:]):
3003         (-[LegacyContextMenuUIDelegate webView:previewingViewControllerForElement:defaultActions:]):
3004         (-[LegacyContextMenuUIDelegate webView:contextMenuWillPresentForElement:]):
3005         (-[LegacyContextMenuUIDelegate _webView:contextMenuDidEndForElement:]):
3006         * TestWebKitAPI/cocoa/TestContextMenuDriver.h:
3007
3008 2019-08-19  Yusuke Suzuki  <ysuzuki@apple.com>
3009
3010         [JSC] OSR entry to Wasm OMG
3011         https://bugs.webkit.org/show_bug.cgi?id=200362
3012
3013         Reviewed by Michael Saboff.
3014
3015         * Scripts/run-jsc-stress-tests:
3016
3017 2019-08-19  Zhifei Fang  <zhifei_fang@apple.com>
3018
3019         [results.webkit.org Timeline] Disable back gesture
3020         https://bugs.webkit.org/show_bug.cgi?id=200839
3021
3022         Reviewed by Jonathan Bedard.
3023
3024         * resultsdbpy/resultsdbpy/view/static/library/js/Utils.js:
3025         * resultsdbpy/resultsdbpy/view/templates/base.html:
3026
3027 2019-08-19  Jonathan Bedard  <jbedard@apple.com>
3028
3029         results-webkit.org: Add timeout to Redis locks
3030         https://bugs.webkit.org/show_bug.cgi?id=200890
3031
3032         Reviewed by Aakash Jain.
3033
3034         * resultsdbpy/resultsdbpy/model/upload_context.py:
3035         (UploadContext._find_job_with_attempts): Add timeout to Redis lock.
3036
3037 2019-08-19  Sihui Liu  <sihui_liu@apple.com>
3038
3039         Remove IDB-specific quota
3040         https://bugs.webkit.org/show_bug.cgi?id=196545
3041         <rdar://problem/54201783>
3042
3043         Reviewed by Youenn Fablet.
3044
3045         * DumpRenderTree/TestRunner.cpp:
3046         (TestRunner::staticFunctions):
3047         (setIDBPerOriginQuotaCallback): Deleted.
3048         * DumpRenderTree/TestRunner.h:
3049         * DumpRenderTree/mac/DumpRenderTree.mm:
3050         (runTest):
3051         * DumpRenderTree/mac/TestRunnerMac.mm:
3052         (TestRunner::setIDBPerOriginQuota): Deleted.
3053         * DumpRenderTree/win/TestRunnerWin.cpp:
3054         (TestRunner::setIDBPerOriginQuota): Deleted.
3055         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3056         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3057         (WTR::TestRunner::setIDBPerOriginQuota): Deleted.
3058         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3059         * WebKitTestRunner/TestController.cpp:
3060         (WTR::TestController::resetStateToConsistentValues):
3061         (WTR::TestController::setIDBPerOriginQuota): Deleted.
3062         * WebKitTestRunner/TestController.h:
3063         * WebKitTestRunner/TestInvocation.cpp:
3064         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3065
3066 2019-08-19  Yusuke Suzuki  <ysuzuki@apple.com>
3067
3068         [WTF] Style checker should tell errors when it finds std::make_unique
3069         https://bugs.webkit.org/show_bug.cgi?id=200878
3070
3071         Reviewed by Ross Kirsling.
3072
3073         * Scripts/webkitpy/style/checkers/cpp.py:
3074         (check_wtf_make_unique):
3075         (check_style):
3076         (CppChecker):
3077
3078 2019-08-18  Yusuke Suzuki  <ysuzuki@apple.com>
3079
3080         [WTF] Add makeUnique<T>, which ensures T is fast-allocated, makeUnique / makeUniqueWithoutFastMallocCheck part
3081         https://bugs.webkit.org/show_bug.cgi?id=200620
3082
3083         Reviewed by Geoffrey Garen.
3084
3085         * DumpRenderTree/TestRunner.cpp:
3086         (addURLToRedirectCallback):
3087         (setWillSendRequestClearHeaderCallback):
3088         (TestRunner::setAccummulateLogsForChannel):
3089         (TestRunner::runUIScript):
3090         (TestRunner::setOpenPanelFiles):
3091         * DumpRenderTree/mac/DumpRenderTree.mm:
3092         (dumpFramesAsText):
3093         * DumpRenderTree/mac/EventSendingController.mm:
3094         (eventPressedMouseButtonsSwizzlerForViewAndEvent):
3095         * DumpRenderTree/win/DRTDataObject.cpp:
3096         (DRTDataObject::SetData):
3097         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3098         (FrameLoadDelegate::FrameLoadDelegate):
3099         * DumpRenderTree/win/UIDelegate.cpp:
3100         (DRTUndoManager::DRTUndoManager):
3101         (UIDelegate::UIDelegate):
3102         (UIDelegate::resetUndoManager):
3103         * TestWebKitAPI/JavaScriptTest.cpp:
3104         (TestWebKitAPI::runJSTest):
3105         * TestWebKitAPI/PlatformUtilities.cpp:
3106         (TestWebKitAPI::Util::toSTD):
3107         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3108         (TestWebKitAPI::TEST):
3109         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:
3110         (TestWebKitAPI::TEST):
3111         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3112         (TestWebKitAPI::TEST):
3113         (TestWebKitAPI::testMovingUsingEnsure):
3114         (TestWebKitAPI::testMovingUsingAdd):
3115         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3116         (TestWebKitAPI::TEST):
3117         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
3118         (TestWebKitAPI::TEST):
3119         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3120         (TestWebKitAPI::runLockTest):
3121         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3122         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
3123         (TestWebKitAPI::TEST):
3124         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
3125         (TestWebKitAPI::TEST):
3126         * TestWebKitAPI/Tests/WTF/Variant.cpp:
3127         (TestWebKitAPI::TEST):
3128         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3129         (TestWebKitAPI::TEST):
3130         * TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp:
3131         (TestWebKitAPI::CARingBufferTest::SetUp):
3132         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
3133         (TestWebKitAPI::createTestValue):
3134         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3135         (TestWebKitAPI::TEST):
3136         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
3137         (TestWebKitAPI::TEST_F):
3138         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3139         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
3140         (TestWebKitAPI::createNewPage):
3141         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
3142         (TestWebKitAPI::createNewPage):
3143         * TestWebKitAPI/Tests/WebKit/TextFieldDidBeginAndEndEditing.cpp:
3144         * TestWebKitAPI/Tests/WebKit/UserMessage.cpp:
3145         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp):
3146         * TestWebKitAPI/Tests/WebKit/WillLoad.cpp:
3147         (TestWebKitAPI::WebKit2WillLoadTest::SetUp):
3148         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
3149         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
3150         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
3151         (serverCallback):
3152         (testWebViewAuthenticationProxyHTTPS):
3153         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
3154         (WebKitDOMDOMWindowTest::create):
3155         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm:
3156         (TestWebKitAPI::Util::toSTD):
3157         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3158         (applyWorkaroundToAllowWritingAttributedStringsToItemProviders):
3159         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
3160         * TestWebKitAPI/mac/TestFontOptions.mm:
3161         (-[TestFontOptions initWithFontOptions:]):
3162         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3163         (WTR::EventSendingController::callAfterScrollingCompletes):
3164         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3165         (WTR::InjectedBundle::didCreatePage):
3166         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3167         (WTR::TestRunner::setOpenPanelFiles):
3168         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3169         * WebKitTestRunner/StringFunctions.h:
3170         (WTR::toSTD):
3171         (WTR::toWTFString):
3172         * WebKitTestRunner/TestController.cpp:
3173         (WTR::TestController::initialize):
3174         (WTR::TestController::generatePageConfiguration):
3175         (WTR::TestController::resetStateToConsistentValues):
3176         (WTR::createTestURL):
3177         (WTR::TestController::runTest):
3178         (WTR::TestController::platformCreateWebView):
3179         * WebKitTestRunner/TestInvocation.cpp:
3180         (WTR::TestInvocation::runUISideScript):
3181         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3182         (WTR::TestController::platformCreateWebView):
3183         (WTR::TestController::setDefaultCalendarType):
3184         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3185         (WTR::getGDKKeySymForKeyRef):
3186         * WebKitTestRunner/ios/TestControllerIOS.mm:
3187         (WTR::TestController::platformResetStateToConsistentValues):
3188         (WTR::TestController::setKeyboardInputModeIdentifier):
3189         * WebKitTestRunner/mac/EventSenderProxy.mm:
3190         (WTR::EventSenderProxy::mouseDown):
3191         (WTR::EventSenderProxy::mouseUp):
3192         (WTR::EventSenderProxy::mouseMoveTo):
3193         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
3194         (WTR::wpeKeySymForKeyRef):
3195
3196 2019-08-17  Ross Kirsling  <ross.kirsling@sony.com>
3197
3198         [ESNext] Implement optional chaining
3199         https://bugs.webkit.org/show_bug.cgi?id=200199
3200
3201         Reviewed by Yusuke Suzuki.
3202
3203         * Scripts/run-jsc-stress-tests:
3204
3205 2019-08-17  Tim Horton  <timothy_horton@apple.com>
3206
3207         Layout tests that call resizeTo() crash when run on iOS with IOSurface support enabled
3208         https://bugs.webkit.org/show_bug.cgi?id=200866
3209         <rdar://problem/50254021>
3210
3211         Reviewed by Simon Fraser.
3212
3213         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3214         (WTR::PlatformWebView::windowSnapshotImage):
3215         Replace some logging with release assertions that we are snapshotting a reasonable
3216         view and get a reasonable snapshot back. Failing to snapshot is a big deal, and
3217         "silently" failing with just a log that will be ignored is not helpful.
3218
3219 2019-08-17  Yusuke Suzuki  <ysuzuki@apple.com>
3220
3221         [WTF] ThreadGroupRemove test is flaky
3222         https://bugs.webkit.org/show_bug.cgi?id=200763
3223
3224         Reviewed by Mark Lam.
3225
3226         ThreadGroup.ThreadGroupRemove test is flaky since its `threadRunning` modification and check in Thread are racy.
3227         It can lead to infinite wait on waitForCompletion. We should do more idiomatic to avoid race: When notifying condition
3228         variables, we should first take a lock, modify the condition shared and notify the condition change while taking a lock,
3229         and releasing the lock after that.
3230
3231         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
3232         (TestWebKitAPI::TEST):
3233
3234 2019-08-17  Eric Liang  <ericliang@apple.com>
3235
3236         Tested that accessibility WebProcessLoader bundle is loaded for the correct path.
3237         https://bugs.webkit.org/show_bug.cgi?id=200367
3238
3239         Reviewed by Darin Adler.
3240
3241         Added AccessibilityTestPlugin on the web process to report whether a bundle is loaded and its path, so that it can be tested on WKContentView. 
3242
3243         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3244         * TestWebKitAPI/Tests/WebKitCocoa/AccessibilityTestPlugin.mm: Added.
3245         (-[AccessibilityTestPlugin webProcessPlugIn:didCreateBrowserContextController:]):
3246         (-[AccessibilityTestPlugin checkAccessibilityWebProcessLoaderBundleIsLoaded:]):
3247         * TestWebKitAPI/Tests/WebKitCocoa/AccessibilityTestSupportProtocol.h: Added.
3248         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
3249         (TestWebKitAPI::TEST):
3250
3251 2019-08-17  Sam Weinig  <weinig@apple.com>
3252
3253         Rename StringBuilder::flexibleAppend(...) to StringBuilder::append(...)
3254         https://bugs.webkit.org/show_bug.cgi?id=200756
3255
3256         Reviewed by Darin Adler.
3257
3258         Update call sites for rename from StringBuilder::flexibleAppend(...) to 
3259         StringBuilder::append(...).
3260
3261         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
3262         (TestWebKitAPI::TEST):
3263
3264 2019-08-17  Simon Fraser  <simon.fraser@apple.com>
3265
3266         [iOS WK2] Scroll indicators disappear sometimes
3267         https://bugs.webkit.org/show_bug.cgi?id=200791
3268
3269         Reviewed by Tim Horton.
3270
3271         Tests that test that scroll indicators survive subview replacement, and that
3272         a custom view also survives subview replacement.
3273
3274         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3275         * TestWebKitAPI/Tests/ios/OverflowScrollViewTests.mm: Added.
3276         (TestWebKitAPI::TEST):
3277         * TestWebKitAPI/cocoa/TestWKWebView.h:
3278         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3279         (-[TestWKWebView performAfterLoading:]):
3280         (-[UIView wkFirstSubviewWithClass:]):
3281         (-[UIView wkFirstSubviewWithBoundsSize:]):
3282         * TestWebKitAPI/ios/composited.html: Added.
3283         * TestWebKitAPI/ios/overflow-scroll.html: Added.
3284
3285 2019-08-16  John Wilander  <wilander@apple.com>
3286
3287         Add John Wilander as WebKit Reviewer
3288         https://bugs.webkit.org/show_bug.cgi?id=200837
3289
3290         Unreviewed update to contributors.json to change my status to reviewer.
3291         See email on reviewers mailing list for proof of granted privileges.
3292
3293         * Scripts/webkitpy/common/config/contributors.json:
3294
3295 2019-08-16  Timothy Hatcher  <timothy@apple.com>
3296
3297         REGRESSION (r248436): WKWebView doesn’t respect isOpaque setting in NIB.
3298         https://bugs.webkit.org/show_bug.cgi?id=200802
3299         rdar://problem/54357818
3300
3301         Reviewed by Tim Horton.
3302
3303         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added WKWebViewOpaque.mm.
3304         * TestWebKitAPI/Tests/ios/WKWebViewOpaque.mm: Added.
3305         (-[OpaqueTestWKWebView isOpaque]): Added.
3306         (-[NonOpaqueTestWKWebView isOpaque]): Added.
3307         (isOpaque): Added.
3308         (TEST): Added WKWebView.IsOpaqueDefault, WKWebView.SetOpaqueYes, WKWebView.SetOpaqueNo, WKWebView.IsOpaqueYesSubclassOverridden,
3309         WKWebView.IsOpaqueNoSubclassOverridden, WKWebView.IsOpaqueYesDecodedFromArchive, WKWebView.IsOpaqueNoDecodedFromArchive,
3310         WKWebView.IsOpaqueDrawsBackgroundYesConfiguration, WKWebView.IsOpaqueDrawsBackgroundNoConfiguration.
3311
3312 2019-08-16  Aakash Jain  <aakash_jain@apple.com>
3313
3314         [ews] Add build steps for Windows Factory
3315         https://bugs.webkit.org/show_bug.cgi?id=200813
3316
3317         Reviewed by Jonathan Bedard.
3318
3319         * BuildSlaveSupport/ews-build/factories.py:
3320         (WindowsFactory.__init__):
3321
3322 2019-08-16  Aakash Jain  <aakash_jain@apple.com>
3323
3324         [ews] Report machine uptime in PrintConfiguration
3325         https://bugs.webkit.org/show_bug.cgi?id=200812
3326
3327         Reviewed by Jonathan Bedard.
3328
3329         * BuildSlaveSupport/ews-build/steps.py:
3330         (PrintConfiguration): Added uptime command.
3331         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
3332
3333 2019-08-16  Chris Lord  <clord@igalia.com>
3334
3335         Add shared-mime-info to WPE WebKit jhbuild
3336         https://bugs.webkit.org/show_bug.cgi?id=200768
3337
3338         Reviewed by Carlos Alberto Lopez Perez.
3339
3340         * wpe/jhbuild.modules:
3341
3342 2019-08-15  Yusuke Suzuki  <ysuzuki@apple.com>
3343
3344         [WTF] Add makeUnique<T>, which ensures T is fast-allocated, WTF_MAKE_FAST_ALLOCATED annotation part
3345         https://bugs.webkit.org/show_bug.cgi?id=200620
3346
3347         Reviewed by Geoffrey Garen.
3348
3349         * DumpRenderTree/AccessibilityController.h:
3350         * DumpRenderTree/GCController.h:
3351         * DumpRenderTree/win/DRTDataObject.cpp:
3352         * DumpRenderTree/win/DRTDataObject.h:
3353         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
3354         * DumpRenderTree/win/DRTDropSource.h:
3355         * DumpRenderTree/win/DraggingInfo.h:
3356         * DumpRenderTree/win/EditingDelegate.h:
3357         * DumpRenderTree/win/EventSender.cpp:
3358         * DumpRenderTree/win/FrameLoadDelegate.h:
3359         * DumpRenderTree/win/HistoryDelegate.h:
3360         * DumpRenderTree/win/MD5.h:
3361         * DumpRenderTree/win/PolicyDelegate.h:
3362         * DumpRenderTree/win/ResourceLoadDelegate.h:
3363         * DumpRenderTree/win/TextInputController.h:
3364         * DumpRenderTree/win/UIDelegate.cpp:
3365         * DumpRenderTree/win/UIDelegate.h:
3366         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
3367         * TestRunnerShared/cocoa/ClassMethodSwizzler.h:
3368         * TestRunnerShared/cocoa/InstanceMethodSwizzler.h:
3369         * TestWebKitAPI/Counters.h:
3370         * TestWebKitAPI/PlatformWebView.h:
3371         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3372         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3373         (TestWebKitAPI::DerefObserver::ref):
3374         (TestWebKitAPI::DerefObserver::deref):
3375         (TestWebKitAPI::TEST):
3376         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3377         (TestWebKitAPI::DerefObserver::ref):
3378         (TestWebKitAPI::DerefObserver::deref):
3379         (TestWebKitAPI::TEST):
3380         * TestWebKitAPI/Tests/WTF/UniqueRef.cpp:
3381         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3382         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
3383         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
3384         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h:
3385         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h:
3386         * WebKitTestRunner/EventSenderProxy.h:
3387         * WebKitTestRunner/GeolocationProviderMock.h:
3388         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
3389         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3390         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3391         * WebKitTestRunner/PlatformWebView.h:
3392         * WebKitTestRunner/TestInvocation.h:
3393
3394 2019-08-15  Sihui Liu  <sihui_liu@apple.com>
3395
3396         Some improvements on web storage
3397         https://bugs.webkit.org/show_bug.cgi?id=200373
3398
3399         Reviewed by Geoffrey Garen.
3400
3401         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
3402         (TEST): update expectation for behavior change.
3403
3404         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: new SPI to synchronously flush localStorage to 
3405         database file.
3406         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3407         (WTR::TestRunner::syncLocalStorage):
3408         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3409
3410         * WebKitTestRunner/TestController.cpp: clear local storage between test runs to make each test isolated.
3411         (WTR::TestController::resetStateToConsistentValues):
3412         (WTR::StorageVoidCallbackContext::StorageVoidCallbackContext):
3413         (WTR::StorageVoidCallback):
3414         (WTR::TestController::clearIndexedDatabases):
3415         (WTR::TestController::clearLocalStorage):
3416         (WTR::TestController::syncLocalStorage):
3417         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext): Deleted. Replaced
3418         with StorageVoidCallbackContext for general usage.
3419         (WTR::RemoveAllIndexedDatabasesCallback): Deleted. Replaced with StorageVoidCallback.
3420         (WTR::TestController::ClearIndexedDatabases): Deleted. Use lowercase for consistent style.
3421         * WebKitTestRunner/TestController.h:
3422
3423         * WebKitTestRunner/TestInvocation.cpp:
3424         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): add handler for new message 
3425         SyncLocalStorage.
3426
3427 2019-08-15  Jonathan Bedard  <jbedard@apple.com>
3428
3429         results.webkit.org: Add content hook to FlaskRequestsResponse
3430         https://bugs.webkit.org/show_bug.cgi?id=200721
3431
3432         Rubber-stamped by Aakash Jain.
3433
3434         * resultsdbpy/resultsdbpy/flask_support/flask_testcase.py:
3435         (FlaskRequestsResponse):
3436         (FlaskRequestsResponse.content): Return the encoded raw bytes value of the
3437         Response, conforming to request's API.
3438
3439 2019-08-15  Alex Christensen  <achristensen@webkit.org>
3440
3441         WKUIDelegate's webView:contextMenuDidEndForElement: should be called when context menus end
3442         https://bugs.webkit.org/show_bug.cgi?id=200750
3443         <rdar://problem/54232261> and <rdar://problem/52355829>
3444
3445         Reviewed by Tim Horton.
3446
3447         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
3448         (-[TestContextMenuUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
3449         (-[TestContextMenuUIDelegate webView:contextMenuForElement:willCommitWithAnimator:]):
3450         (-[TestContextMenuUIDelegate webView:contextMenuDidEndForElement:]):
3451         (contextMenuWebViewDriver):
3452         (TEST):
3453
3454 2019-08-14  Said Abou-Hallawa  <sabouhallawa@apple.com>
3455
3456         [iOS](REGRESSION: r200487): WebKit.RequestActivatedElementInfoForRotatedImage fails on iOS 13
3457         https://bugs.webkit.org/show_bug.cgi?id=200726
3458
3459         Reviewed by Simon Fraser.
3460
3461         To get the pixels as an array of colors, draw the image into a memory
3462         context. The backing memory buffer can then be accessed to get the image
3463         pixels' colors.
3464
3465         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
3466         (TestWebKitAPI::TEST):
3467
3468 2019-08-14  Ryan Haddad  <ryanhaddad@apple.com>
3469
3470         Unreviewed, rolling out r248526.
3471
3472         Caused two IndexedDB perf tests to fail
3473
3474         Reverted changeset:
3475
3476         "Remove IDB-specific quota"
3477         https://bugs.webkit.org/show_bug.cgi?id=196545
3478         https://trac.webkit.org/changeset/248526
3479
3480 2019-08-14  Keith Rollin  <krollin@apple.com>
3481
3482         Remove support for macOS < 10.13
3483         https://bugs.webkit.org/show_bug.cgi?id=200694
3484         <rdar://problem/54278851>
3485
3486         Reviewed by Youenn Fablet.
3487
3488         Update conditionals that reference __MAC_OS_X_VERSION_MIN_REQUIRED and
3489         __MAC_OS_X_VERSION_MAX_ALLOWED, assuming that they both have values >=
3490         101300. This means that expressions like
3491         "__MAC_OS_X_VERSION_MIN_REQUIRED < 101300" are always False and
3492         "__MAC_OS_X_VERSION_MIN_REQUIRED >= 101300" are always True.
3493
3494         * MiniBrowser/AppKitCompatibilityDeclarations.h:
3495         * MiniBrowser/mac/SettingsController.m:
3496         (-[SettingsController init]):
3497         * TestWebKitAPI/Tests/WebCore/FontCache.cpp:
3498         (TestWebKitAPI::FontCacheTest::SetUp): Deleted.
3499         (TestWebKitAPI::createPlatformFont): Deleted.
3500         (TestWebKitAPI::compareFonts): Deleted.
3501         (TestWebKitAPI::TEST_F): Deleted.
3502         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
3503         (TestWebKitAPI::TEST):
3504         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
3505         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
3506         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3507         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3508         (runWebsiteDataStoreCustomPaths):
3509         * TestWebKitAPI/mac/NSFontPanelTesting.mm:
3510
3511 2019-08-14  Yusuke Suzuki  <ysuzuki@apple.com>
3512
3513         [JSC] Less contended MetaAllocator
3514         https://bugs.webkit.org/show_bug.cgi?id=200278
3515
3516         Reviewed by Mark Lam.
3517
3518         Update the interface.
3519
3520         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3521
3522 2019-08-14  Jonathan Bedard  <jbedard@apple.com>
3523
3524         results.webkit.org: 500 errors on API endpoints don't return JSON
3525         https://bugs.webkit.org/show_bug.cgi?id=200722
3526
3527         Reviewed by Aakash Jain.
3528
3529         * resultsdbpy/resultsdbpy/controller/api_routes.py:
3530         (APIRoutes.response_500): We should return the response, instead of abort.
3531
3532 2019-08-14  Jonathan Bedard  <jbedard@apple.com>
3533
3534         results.webkit.org: Don't save configuration multiple times in upload
3535         https://bugs.webkit.org/show_bug.cgi?id=200719
3536
3537         Reviewed by Aakash Jain.
3538
3539         * resultsdbpy/resultsdbpy/model/upload_context.py:
3540         (UploadContext.upload_test_results): Move registering of the configuration out
3541         of the branch loop.
3542
3543 2019-08-14  Youenn Fablet  <youenn@apple.com>
3544
3545         Reenable Update ContentFiltering.LazilyLoadPlatformFrameworks test for NetworkExtension
3546         https://bugs.webkit.org/show_bug.cgi?id=200706
3547
3548         Reviewed by Alex Christensen.
3549
3550         Libwebrtc is now soft-linked so we can reenable this test.
3551
3552         * TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm:
3553         (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
3554
3555 2019-08-13  Sam Weinig  <weinig@apple.com>
3556
3557         Rename StringBuilder::append(UChar32) to StringBuilder::appendCharacter(UChar32) to avoid accidental change in behavior when replacing append with flexibleAppend
3558         https://bugs.webkit.org/show_bug.cgi?id=200675
3559
3560         Reviewed by Darin Adler.
3561
3562         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
3563         (TestWebKitAPI::TEST):
3564         Update for rename from StringBuilder::append(UChar32) to StringBuilder::appendCharacter(UChar32).
3565
3566 2019-08-13  Zhifei Fang  <zhifei_fang@apple.com>
3567
3568         [results.webkit.org Timeline] Performance improvement - Skip render offscreen canvas
3569         https://bugs.webkit.org/show_bug.cgi?id=200456
3570
3571         Reviewed by Jonathan Bedard.
3572
3573         This patch disable use the new batch draw method to render canvas directly without any caches, this will save a lot of memory, so that we won't go into the "low memory mode".
3574
3575         This patch also change the axis label collision detact box from a rect to polygon, so that we can dectact click more accurate.
3576
3577         * resultsdbpy/resultsdbpy/view/static/library/js/Utils.js:
3578         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
3579         (pointPolygonCollisionDetect): Detact
3580         (pointRightRayLineSegmentCollisionDetect):
3581         (ColorBatchRender):
3582         (ColorBatchRender.prototype.lazyCreateColorSeqs):
3583         (ColorBatchRender.prototype.addSeq):
3584         (ColorBatchRender.prototype.batchRender):
3585         (ColorBatchRender.prototype.clear):
3586         (xScrollStreamRenderFactory):
3587         (Timeline.CanvasSeriesComponent):
3588         (offscreenCachedRenderFactory): Deleted.