5744a4bb1d9174877f4897b296109f849f45c983
[WebKit-https.git] / Tools / ChangeLog
1 2016-09-10  Wenson Hsieh  <wenson_hsieh@apple.com>
2
3         Apple.com keynote does not display media controls
4         https://bugs.webkit.org/show_bug.cgi?id=161833
5         <rdar://problem/28230123>
6
7         Reviewed by Tim Horton.
8
9         New unit test verifying that wide videos (~2 aspect ratio) still get media controls.
10
11         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
12         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
13         (TestWebKitAPI::TEST):
14         * TestWebKitAPI/Tests/WebKit2Cocoa/wide-autoplaying-video-with-audio.html: Added.
15
16 2016-09-09  Tim Horton  <timothy_horton@apple.com>
17
18         WKThumbnailView should expose a mode where it can be reparented without resnapshotting
19         https://bugs.webkit.org/show_bug.cgi?id=161828
20         <rdar://problem/28229756>
21
22         Reviewed by Alex Christensen.
23
24         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
25         * TestWebKitAPI/Tests/WebKit2/WKThumbnailView.mm: Added.
26         (-[SnapshotSizeObserver observeValueForKeyPath:ofObject:change:context:]):
27         (TestWebKitAPI::didFinishLoadForFrame):
28         (TestWebKitAPI::setPageLoaderClient):
29         (TestWebKitAPI::TEST):
30         Add a test ensuring that this behaves correctly.
31
32 2016-09-09  Alex Christensen  <achristensen@webkit.org>
33
34         URLParser: Keep track of cannot-be-a-base-url according to spec
35         https://bugs.webkit.org/show_bug.cgi?id=161830
36
37         Reviewed by Tim Horton.
38
39         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
40         (TestWebKitAPI::TEST_F):
41
42 2016-09-09  Alex Christensen  <achristensen@webkit.org>
43
44         Fix API tests after r205774.
45         https://bugs.webkit.org/show_bug.cgi?id=161820
46
47         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
48         (TestWebKitAPI::TEST_F):
49         I had committed the wrong expected path in one case. The functionality is correct.
50
51 2016-09-09  Michael Saboff  <msaboff@apple.com>
52
53         Unreviewed, rolling r205759 back in with a fix.
54
55         An expectation file, JSTests/ChakraCore/test/Lib/tostring.baseline-jsc,
56         should be named "toString.baseline-jsc".  For systems with case-insensitive
57         filesystems, the wrong name isn't an issue.  That rename is part of this
58         fix.
59
60         * Scripts/run-javascriptcore-tests:
61         (runJSCStressTests):
62
63 2016-09-09  Johan K. Jensen  <johan_jensen@apple.com>
64
65         Unreviewed. Added myself to the list of committers.
66
67         * Scripts/webkitpy/common/config/contributors.json:
68
69 2016-09-09  Alex Christensen  <achristensen@webkit.org>
70
71         URLParser should convert ASCII hosts to lowercase
72         https://bugs.webkit.org/show_bug.cgi?id=161820
73
74         Reviewed by Geoffrey Garen.
75
76         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
77         (TestWebKitAPI::TEST_F):
78
79 2016-09-09  Ryan Haddad  <ryanhaddad@apple.com>
80
81         Unreviewed, rolling out r205759.
82
83         This change broke all JSC tests
84
85         Reverted changeset:
86
87         "Add ChakraCore tests to run-javascriptcore-tests"
88         https://bugs.webkit.org/show_bug.cgi?id=161808
89         http://trac.webkit.org/changeset/205759
90
91 2016-09-09  Ryan Haddad  <ryanhaddad@apple.com>
92
93         Revert r205770 because Ricky is already a committer.
94
95         Unreviewed.
96
97         * Scripts/webkitpy/common/config/contributors.json:
98
99 2016-09-09  Ricky Mondello  <rmondello@apple.com>
100
101         Unreviewed. Added myself to the list of committers.
102
103         * Scripts/webkitpy/common/config/contributors.json:
104
105 2016-09-09  Alex Christensen  <achristensen@webkit.org>
106
107         URLParser: Fix and optimize parsing file URLs ending with a host but no slash
108         https://bugs.webkit.org/show_bug.cgi?id=161815
109
110         Reviewed by Geoffrey Garen.
111
112         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
113         (TestWebKitAPI::TEST_F):
114
115 2016-09-08  Dean Jackson  <dino@apple.com>
116
117         Expose Apple Pencil data to Touch events
118         https://bugs.webkit.org/show_bug.cgi?id=161783
119         <rdar://problem/28218898>
120
121         Reviewed by Beth Dakin.
122
123         The values that IOHID expects are different from their
124         documentation, and from what UITouch interprets. Tweak
125         incoming data so it will produce the output we expect.
126
127         * WebKitTestRunner/ios/HIDEventGenerator.mm:
128         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:]):
129         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:]):
130
131 2016-09-09  JF Bastien  <jfbastien@apple.com>
132
133         Unreviewed. Added myself to the list of committers.
134
135         * Scripts/webkitpy/common/config/contributors.json:
136
137 2016-09-09  Michael Saboff  <msaboff@apple.com>
138
139         Add ChakraCore tests to run-javascriptcore-tests
140         https://bugs.webkit.org/show_bug.cgi?id=161808
141
142         Reviewed by Saam Barati.
143
144         Added ChakraCore tests to the default list of tests to run.
145
146         * Scripts/run-javascriptcore-tests:
147         (runJSCStressTests):
148
149 2016-09-09  Alex Christensen  <achristensen@webkit.org>
150
151         URLParser: Handle \ in path according to spec
152         https://bugs.webkit.org/show_bug.cgi?id=161805
153
154         Reviewed by Andy Estes.
155
156         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
157         (TestWebKitAPI::TEST_F):
158
159 2016-09-09  Alex Christensen  <achristensen@webkit.org>
160
161         URLParser should parse URLs with non-special schemes
162         https://bugs.webkit.org/show_bug.cgi?id=161786
163
164         Reviewed by Andy Estes.
165
166         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
167         (TestWebKitAPI::TEST_F):
168
169 2016-09-08  Yusuke Suzuki  <utatane.tea@gmail.com>
170
171         [WTF] HashTable's rehash is not compatible to Ref<T> and ASan
172         https://bugs.webkit.org/show_bug.cgi?id=161763
173
174         Reviewed by Mark Lam.
175
176         Add tests that inserts many Ref<>s. It incurs HashTable::rehash, and we can ensure
177         that ASan crash does not occur with this patch.
178
179         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
180         (TestWebKitAPI::TEST):
181         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
182         (TestWebKitAPI::TEST):
183
184 2016-09-08  Alex Christensen  <achristensen@webkit.org>
185
186         URLParser: Handle \ in paths of special URLs according to spec
187         https://bugs.webkit.org/show_bug.cgi?id=161781
188
189         Reviewed by Tim Horton.
190
191         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
192         (TestWebKitAPI::TEST_F):
193
194 2016-09-08  Simon Fraser  <simon.fraser@apple.com>
195
196         Update the content-animation.plan file to run css-accelerated-animation.html
197         and pull SVN revision r205680.
198
199         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
200
201 2016-09-08  Simon Fraser  <simon.fraser@apple.com>
202
203         Add a content-animation test with accelerated CSS animations
204         https://bugs.webkit.org/show_bug.cgi?id=161776
205
206         Reviewed by Dean Jackson.
207
208         * Scripts/webkitpy/benchmark_runner/data/patches/ContentAnimation.patch:
209
210 2016-09-08  Alex Christensen  <achristensen@webkit.org>
211
212         URLParser: Parsing empty URLs with a base URL should return the base URL
213         https://bugs.webkit.org/show_bug.cgi?id=161777
214
215         Reviewed by Tim Horton.
216
217         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
218         (TestWebKitAPI::TEST_F):
219
220 2016-09-08  Alex Christensen  <achristensen@webkit.org>
221
222         URLParser failures should preserve the original input string
223         https://bugs.webkit.org/show_bug.cgi?id=161769
224
225         Reviewed by Tim Horton.
226
227         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
228         (TestWebKitAPI::TEST_F):
229         (TestWebKitAPI::shouldFail):
230
231 2016-09-08  Alex Christensen  <achristensen@webkit.org>
232
233         URLParser should parse URLs with a user but no password
234         https://bugs.webkit.org/show_bug.cgi?id=161773
235
236         Reviewed by Brady Eidson.
237
238         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
239         (TestWebKitAPI::TEST_F):
240
241 2016-09-08  Alex Christensen  <achristensen@webkit.org>
242
243         URLParser should parse ports after IPv4 and IPv6 hosts
244         https://bugs.webkit.org/show_bug.cgi?id=161731
245
246         Reviewed by Brady Eidson.
247
248         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
249         (TestWebKitAPI::TEST_F):
250
251 2016-09-08  Alex Christensen  <achristensen@webkit.org>
252
253         URLParser should correctly handle \ in path
254         https://bugs.webkit.org/show_bug.cgi?id=161762
255
256         Reviewed by Brady Eidson.
257
258         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
259         (TestWebKitAPI::TEST_F):
260
261 2016-09-08  Alex Christensen  <achristensen@webkit.org>
262
263         URLParser should handle URLs with empty authority
264         https://bugs.webkit.org/show_bug.cgi?id=161711
265
266         Reviewed by Brady Eidson.
267
268         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
269         (TestWebKitAPI::TEST_F):
270
271 2016-09-08  Alex Christensen  <achristensen@webkit.org>
272
273         Re-land r205580 after r205649 fixed the test failures
274         https://bugs.webkit.org/show_bug.cgi?id=161668
275
276         Re-landing changesets:
277
278         "Punycode encode non-ascii hosts in URLParser"
279         https://bugs.webkit.org/show_bug.cgi?id=161655
280         http://trac.webkit.org/changeset/205521
281
282         "Fix query-only and fragment-only relative URLs when using
283         URLParser"
284         https://bugs.webkit.org/show_bug.cgi?id=161657
285         http://trac.webkit.org/changeset/205526
286
287         "URLParser should parse / as a relative URL"
288         https://bugs.webkit.org/show_bug.cgi?id=161667
289         http://trac.webkit.org/changeset/205532
290
291 2016-09-08  Dean Jackson  <dino@apple.com>
292
293         Expose Apple Pencil input to testing system
294         https://bugs.webkit.org/show_bug.cgi?id=161670
295         <rdar://problem/28183327>
296
297         I fixed the internal builds, now try to fix the public builds.
298
299         * WebKitTestRunner/ios/IOKitSPI.h: Add new enum values.
300
301 2016-09-07  Dean Jackson  <dino@apple.com>
302
303         Expose Apple Pencil input to testing system
304         https://bugs.webkit.org/show_bug.cgi?id=161670
305         <rdar://problem/28183327>
306
307         Attempt to fix iOS 9 builds.
308
309         * WebKitTestRunner/ios/HIDEventGenerator.mm:
310         (-[HIDEventGenerator _createIOHIDEventType:]):
311
312 2016-09-07  Alex Christensen  <achristensen@webkit.org>
313
314         Roll out r205580 and r205582.
315         https://bugs.webkit.org/show_bug.cgi?id=161668
316
317         I need to figure out why this is failing on the bots before landing any more URLParser progress.
318
319 2016-09-07  Alex Christensen  <achristensen@webkit.org>
320
321         Unreviewed, revert r205533.
322         https://bugs.webkit.org/show_bug.cgi?id=161668
323
324         Re-landing changesets:
325
326         "Punycode encode non-ascii hosts in URLParser"
327         https://bugs.webkit.org/show_bug.cgi?id=161655
328         http://trac.webkit.org/changeset/205521
329
330         "Fix query-only and fragment-only relative URLs when using
331         URLParser"
332         https://bugs.webkit.org/show_bug.cgi?id=161657
333         http://trac.webkit.org/changeset/205526
334
335         "URLParser should parse / as a relative URL"
336         https://bugs.webkit.org/show_bug.cgi?id=161667
337         http://trac.webkit.org/changeset/205532
338
339 2016-09-07  Simon Fraser  <simon.fraser@apple.com>
340
341         Enable the <meter> element on iOS
342         https://bugs.webkit.org/show_bug.cgi?id=161714
343         rdar://problem/8978410
344
345         Reviewed by Tim Horton.
346
347         Define ENABLE_METER_ELEMENT unconditionally now.
348
349         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
350
351 2016-09-07  Jonathan Bedard  <jbedard@apple.com>
352
353         Run spindumps on timeout on iOS 9 Simulator Release WK2 (Tests)
354         https://bugs.webkit.org/show_bug.cgi?id=161699
355
356         Reviewed by Alexey Proskuryakov.
357
358         This change does not have testing associated with it because the testing infrastructure does not exists, we cannot currently mock build-bot variables.
359
360         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
361         (RunWebKitTests): Enable sample on timeout for everything.
362         (RunWebKitTests.start): Disable sample on timeout for everything except iOS 9 WK2 release simulators.
363
364 2016-09-06  Dean Jackson  <dino@apple.com>
365
366         Expose Apple Pencil input to testing system
367         https://bugs.webkit.org/show_bug.cgi?id=161670
368         <rdar://problem/28183327>
369
370         Reviewed by Simon Fraser.
371
372         Add API to UIScriptController that allows a test to emulate
373         stylus input, such as from the Apple Pencil.
374
375         The code is only implemented for WebKitTestRunner.
376
377         There are also four new tests that ensure an Apple Pencil
378         operates similarly to a regular touch. The main difference
379         is that you can't have multiple touches when using an Apple Pencil.
380
381         * DumpRenderTree/ios/UIScriptControllerIOS.mm: New methods. Empty implementations.
382         (WTR::UIScriptController::stylusDownAtPoint):
383         (WTR::UIScriptController::stylusMoveToPoint):
384         (WTR::UIScriptController::stylusUpAtPoint):
385         (WTR::UIScriptController::stylusTapAtPoint):
386         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: New methods.
387         * TestRunnerShared/UIScriptContext/UIScriptController.cpp: Empty implementations.
388         (WTR::UIScriptController::stylusDownAtPoint):
389         (WTR::UIScriptController::stylusMoveToPoint):
390         (WTR::UIScriptController::stylusUpAtPoint):
391         (WTR::UIScriptController::stylusTapAtPoint):
392         * TestRunnerShared/UIScriptContext/UIScriptController.h:
393
394         * WebKitTestRunner/ios/HIDEventGenerator.h:
395         * WebKitTestRunner/ios/HIDEventGenerator.mm: New StylusEvent types. Add some properties
396         to SyntheticEventDigitizerInfo.
397         (-[HIDEventGenerator _createIOHIDEventType:]): Add support for StylusEvent types.
398         (-[HIDEventGenerator touchDownAtPoints:touchCount:]): Clear any old stylus info.
399         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:]):
400         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:]):
401         (-[HIDEventGenerator stylusUpAtPoint:]):
402         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
403         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
404         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
405         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
406         * WebKitTestRunner/ios/IOKitSPI.h: Add new include, and new SPI.
407         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Calls into the HIDEventGenerator for the new API.
408         (WTR::UIScriptController::stylusDownAtPoint):
409         (WTR::UIScriptController::stylusMoveToPoint):
410         (WTR::UIScriptController::stylusUpAtPoint):
411         (WTR::UIScriptController::stylusTapAtPoint):
412
413 2016-09-07  Daniel Bates  <dabates@apple.com>
414
415         Update WebKitSystemInterface
416
417         Rubber-stamped by Dean Jackson.
418
419         Copy WebKitSystemInterface for iOS 10 to the built products directory.
420
421         * Scripts/copy-webkitlibraries-to-product-directory:
422
423 2016-09-07  Youenn Fablet  <youenn@apple.com>
424
425         [Streams API] Separate compile flag for ReadableStream and WritableStream
426         https://bugs.webkit.org/show_bug.cgi?id=161044
427
428         Reviewed by Alex Christensen.
429
430         Moving from STREAMS_API to READABLE_STREAM_API and WRITABLE_STREAM_API compilation flags.
431
432         * Scripts/webkitperl/FeatureList.pm:
433         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
434
435 2016-09-07  Carlos Garcia Campos  <cgarcia@igalia.com>
436
437         [GTK] Move some GObject DOM unstable API to stable
438         https://bugs.webkit.org/show_bug.cgi?id=161681
439
440         Reviewed by Žan Doberšek.
441
442         Do not use user message handler unstable API in the tests, since we have stable convenient API for that.
443
444         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
445         (testUserContentManagerScriptMessageFromDOMBindings):
446         (serverCallback): Deleted.
447         (beforeAll): Deleted.
448         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
449         (documentLoadedCallback):
450         (emitURIChanged): Deleted.
451
452 2016-09-07  Youenn Fablet  <youenn@apple.com>
453
454         Using tests-options.json to compute whether tests are slow
455         https://bugs.webkit.org/show_bug.cgi?id=161626
456
457         Reviewed by Darin Adler.
458
459         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: Updated first test to use a MockHost.
460         * Scripts/webkitpy/layout_tests/controllers/manager.py:
461         (Manager.__init__): Loading tests-options.json
462         (Manager._test_is_slow): Computing timeout value based on tests-options.json.
463
464 2016-09-07  Hunseop Jeong  <hs85.jeong@samsung.com>
465
466         [EFL] Need the libosmesa to support the software backend drawing.
467         https://bugs.webkit.org/show_bug.cgi?id=147065
468
469         Reviewed by Gyuyoung Kim.
470
471         Added the libosmesa to support the software backend drawing.
472
473         * efl/install-dependencies:
474
475 2016-09-06  Commit Queue  <commit-queue@webkit.org>
476
477         Unreviewed, rolling out r205521, r205526, and r205532.
478         https://bugs.webkit.org/show_bug.cgi?id=161668
479
480         broke API tests (Requested by alexchristensen on #webkit).
481
482         Reverted changesets:
483
484         "Punycode encode non-ascii hosts in URLParser"
485         https://bugs.webkit.org/show_bug.cgi?id=161655
486         http://trac.webkit.org/changeset/205521
487
488         "Fix query-only and fragment-only relative URLs when using
489         URLParser"
490         https://bugs.webkit.org/show_bug.cgi?id=161657
491         http://trac.webkit.org/changeset/205526
492
493         "URLParser should parse / as a relative URL"
494         https://bugs.webkit.org/show_bug.cgi?id=161667
495         http://trac.webkit.org/changeset/205532
496
497 2016-09-06  Alex Christensen  <achristensen@webkit.org>
498
499         URLParser should parse / as a relative URL
500         https://bugs.webkit.org/show_bug.cgi?id=161667
501
502         Reviewed by Tim Horton.
503
504         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
505         (TestWebKitAPI::TEST_F):
506
507 2016-09-06  Daniel Bates  <dabates@apple.com>
508
509         [iOS] DumpRenderTree and WebKitTestRunner fail to build - "Ad Hoc code signing is not allowed with SDK 'Simulator - iOS 10.0'"
510         https://bugs.webkit.org/show_bug.cgi?id=161661
511
512         Reviewed by Darin Adler.
513
514         Allow ad-hoc code signing when building the dummy DumpRenderTree and WebKitTestRunner
515         command line tools for simulator with the iOS 10 beta SDK.
516
517         * DumpRenderTree/mac/Configurations/Base.xcconfig:
518         * WebKitTestRunner/Configurations/Base.xcconfig:
519
520 2016-09-06  Alex Christensen  <achristensen@webkit.org>
521
522         Fix query-only and fragment-only relative URLs when using URLParser
523         https://bugs.webkit.org/show_bug.cgi?id=161657
524
525         Reviewed by Tim Horton.
526
527         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
528         (TestWebKitAPI::TEST_F):
529
530 2016-09-06  Alex Christensen  <achristensen@webkit.org>
531
532         Punycode encode non-ascii hosts in URLParser
533         https://bugs.webkit.org/show_bug.cgi?id=161655
534
535         Reviewed by Tim Horton.
536
537         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
538         (TestWebKitAPI::wideString):
539         (TestWebKitAPI::TEST_F):
540
541 2016-09-05  Alex Christensen  <achristensen@webkit.org>
542
543         Implement relative file urls and begin implementing character encoding in URLParser
544         https://bugs.webkit.org/show_bug.cgi?id=161618
545
546         Reviewed by Tim Horton.
547
548         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
549         (TestWebKitAPI::TEST_F):
550
551 2016-09-06  Commit Queue  <commit-queue@webkit.org>
552
553         Unreviewed, rolling out r205480.
554         https://bugs.webkit.org/show_bug.cgi?id=161630
555
556         tests-options.json is not known from knockout filesystem
557         (Requested by youenn on #webkit).
558
559         Reverted changeset:
560
561         "Using tests-options.json to compute whether tests are slow"
562         https://bugs.webkit.org/show_bug.cgi?id=161626
563         http://trac.webkit.org/changeset/205480
564
565 2016-09-06  Michael Catanzaro  <mcatanzaro@igalia.com>
566
567         "Redundant argument in sprintf" warning spam from prepare-ChangeLog
568         https://bugs.webkit.org/show_bug.cgi?id=161606
569
570         Reviewed by Darin Adler.
571
572         Avoid extra arguments in call to sprintf, hopefully without introducing new warnings this
573         time.
574
575         * Scripts/prepare-ChangeLog:
576         (statusDescription):
577
578 2016-09-06  Youenn Fablet  <youenn@apple.com>
579
580         Using tests-options.json to compute whether tests are slow
581         https://bugs.webkit.org/show_bug.cgi?id=161626
582
583         Reviewed by Darin Adler.
584
585         * Scripts/webkitpy/layout_tests/controllers/manager.py:
586         (Manager.__init__): Loading tests-options.json
587         (Manager._test_is_slow): Computing timeout value based on tests-options.json.
588
589 2016-09-06  Commit Queue  <commit-queue@webkit.org>
590
591         Unreviewed, rolling out r205461.
592         https://bugs.webkit.org/show_bug.cgi?id=161628
593
594         Introduced "Use of uninitialized value $original in sprintf"
595         warning (Requested by mcatanzaro on #webkit).
596
597         Reverted changeset:
598
599         ""Redundant argument in sprintf" warning spam from prepare-
600         ChangeLog"
601         https://bugs.webkit.org/show_bug.cgi?id=161606
602         http://trac.webkit.org/changeset/205461
603
604 2016-09-06  Youenn Fablet  <youenn@apple.com>
605
606         W3C test importer should be able to identify slow test
607         https://bugs.webkit.org/show_bug.cgi?id=161601
608
609         Reviewed by Darin Adler.
610
611         Test parser is now identifying slow tests based on "meta element name=timeout content=long" elements.
612         Test importer is updating test-options.json file according that information.
613
614         In case of clean import, the test-options.json is cleaned from 'slow' options for all W3C tests.
615
616         * Scripts/webkitpy/w3c/test_importer.py:
617         (TestImporter.__init__):
618         (TestImporter.find_importable_tests):
619         (TestImporter.import_tests):
620         (TestImporter.update_test_options):
621         (TestImporter):
622         (TestImporter.remove_slow_from_w3c_test_options):
623         * Scripts/webkitpy/w3c/test_parser.py:
624         (TestParser.analyze_test):
625         (TestParser.is_slow_test):
626         (TestParser.potential_ref_filename):
627
628 2016-09-06  Per Arne Vollan  <pvollan@apple.com>
629
630         [Win] Crash logs have incorrect symbols.
631         https://bugs.webkit.org/show_bug.cgi?id=161603
632
633         Reviewed by Darin Adler.
634
635         Add build path to _NT_SYMBOL_PATH environment variable.
636
637         * Scripts/webkitpy/port/win.py:
638         (WinPort.setup_crash_log_saving):
639
640 2016-08-31  Filip Pizlo  <fpizlo@apple.com>
641
642         Butterflies should be allocated in Auxiliary MarkedSpace instead of CopiedSpace and we should rewrite as much of the GC as needed to make this not a regression
643         https://bugs.webkit.org/show_bug.cgi?id=160125
644
645         Reviewed by Geoffrey Garen and Keith Miller.
646
647         * DumpRenderTree/TestRunner.cpp:
648         * DumpRenderTree/mac/DumpRenderTree.mm:
649         (DumpRenderTreeMain):
650         * Scripts/run-jsc-stress-tests:
651         * TestWebKitAPI/Tests/WTF/Vector.cpp:
652         (TestWebKitAPI::TEST):
653
654 2016-09-05  Michael Catanzaro  <mcatanzaro@igalia.com>
655
656         "Redundant argument in sprintf" warning spam from prepare-ChangeLog
657         https://bugs.webkit.org/show_bug.cgi?id=161606
658
659         Reviewed by Darin Adler.
660
661         Avoid extra arguments in call to sprintf.
662
663         * Scripts/prepare-ChangeLog:
664         (statusDescription):
665
666 2016-09-05  Michael Catanzaro  <mcatanzaro@igalia.com>
667
668         [GTK] Skip several failing API tests
669
670         Unfortunately we don't have any form of test expectations for API tests, so we'll just skip
671         them after bugs are filed.
672
673         * Scripts/run-gtk-tests:
674         (TestRunner):
675
676 2016-09-05  Youenn Fablet  <youenn@apple.com>
677
678         Fix W3C test importer unit tests after r205447
679         https://bugs.webkit.org/show_bug.cgi?id=161604
680
681         Unreviewed.
682
683         * Scripts/webkitpy/w3c/test_importer.py:
684         (TestImporter.__init__): Skip cleaning test_resource_files files if resource-files.json cannot be read.
685
686 2016-09-05  Philippe Normand  <pnormand@igalia.com>
687
688         WebRTC: Several media stream tests crashing
689         https://bugs.webkit.org/show_bug.cgi?id=161582
690
691         Reviewed by Alejandro G. Castro.
692
693         * gtk/jhbuild.modules: Bump to latest OpenWebRTC master fixing the crash on missing
694         glvideoflip GStreamer element.
695
696 2016-09-05  Youenn Fablet  <youenn@apple.com>
697
698         W3C test importer should generate the list of resource files
699         https://bugs.webkit.org/show_bug.cgi?id=161578
700
701         Reviewed by Ryosuke Niwa.
702
703         Generating LayoutTests/imported/w3c/resources/resource-files.json when importing tests.
704
705         * Scripts/webkitpy/w3c/test_importer.py:
706         (TestImporter.__init__): Reading test resource files configuration file.
707         (TestImporter.find_importable_tests):
708         (TestImporter.import_tests): Update the test resource files based on test parsed files.
709         (TestImporter):
710         (TestImporter._already_identified_as_resource_file): Helper routine to know whether a file is already set as a resource file.
711         (TestImporter._is_in_resources_directory: Helper routine to know whether a file is in a resources directory.
712
713 2016-09-03  Wenson Hsieh  <wenson_hsieh@apple.com>
714
715         Media controls behave strangely when videos mute from within a playing handler
716         https://bugs.webkit.org/show_bug.cgi?id=161559
717         <rdar://problem/28018438>
718
719         Reviewed by Darin Adler.
720
721         Accounts for changes when determining whether or not to show media controls for autoplaying videos that have not
722         begun playing yet. Rather than check for a controlled media element upon page load, we force tests to wait until
723         all autoplaying videos have actually begun playing. This extends to tests that involve interaction, such as
724         clicking or scrolling.
725
726         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
727         (-[VideoControlsManagerTestWebView callJavascriptFunction:]):
728         (-[VideoControlsManagerTestWebView expectControlsManager:afterReceivingMessage:]):
729         (-[VideoControlsManagerTestWebView performAfterReceivingMessage:action:]):
730         (-[VideoControlsManagerTestWebView waitForPageToLoadWithAutoplayingVideos:]):
731         (TestWebKitAPI::TEST):
732         (-[VideoControlsManagerTestWebView loadTestPageNamed:andExpectControlsManager:afterReceivingMessage:]): Deleted.
733         * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html:
734         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html:
735         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-playing-scroll-away.html:
736         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-click-to-pause.html:
737         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-scroll-to-video.html:
738         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-paused-video-hides-controls.html:
739         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-muted-video-hides-controls.html:
740         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-video-keeps-controls.html:
741         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html:
742
743 2016-09-03  Wenson Hsieh  <wenson_hsieh@apple.com>
744
745         Refactor the heuristic for showing media controls to take all media sessions into account
746         https://bugs.webkit.org/show_bug.cgi?id=161503
747         <rdar://problem/28033783>
748
749         Reviewed by Darin Adler.
750
751         Adds new unit tests verifying the behavior of media playback controls when scrolling another video into view.
752         Please see the WebCore ChangeLog for more details about this change. Also refactors existing
753         VideoControlsManager tests by folding duplicated setup and testing logic into helper methods to make the unit
754         tests more readable.
755
756         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
757         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
758         (-[MessageHandler initWithMessage:handler:]):
759         (-[MessageHandler userContentController:didReceiveScriptMessage:]):
760         (-[VideoControlsManagerTestWebView performAfterLoading:]):
761         (-[VideoControlsManagerTestWebView loadTestPageNamed:]):
762         (-[VideoControlsManagerTestWebView loadTestPageNamed:andExpectControlsManager:afterReceivingMessage:]):
763         (-[VideoControlsManagerTestWebView performAfterReceivingMessage:action:]):
764         (-[VideoControlsManagerTestWebView controlledElementID]):
765         (-[VideoControlsManagerTestWebView _handleControlledElementIDResponse:]):
766         (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager):
767         (TestWebKitAPI::TEST):
768         (-[MediaPlaybackMessageHandler initWithWKWebView:finalMessageString:]): Deleted.
769         (-[MediaPlaybackMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
770         (-[OnLoadMessageHandler initWithWKWebView:handler:]): Deleted.
771         (-[OnLoadMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
772         (-[WKWebView performAfterLoading:]): Deleted.
773         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-playing-scroll-away.html: Added.
774         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-click-to-pause.html: Added.
775         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-scroll-to-video.html: Added.
776         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-paused-video-hides-controls.html: Added.
777         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-muted-video-hides-controls.html: Added.
778         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-video-keeps-controls.html: Added.
779
780 2016-09-03  Youenn Fablet  <youenn@apple.com>
781
782         run-webkit-tests should detect w3c test resource files
783         https://bugs.webkit.org/show_bug.cgi?id=161307
784
785         Reviewed by Ryosuke Niwa.
786
787         * Scripts/webkitpy/port/base.py:
788         (Port.__init__): Adding self._w3c_resource_files to store the list of resource files.
789         (Port.potential_test_names_from_expected_file):
790         (Port._real_tests):
791         (Port.is_w3c_resource_file): Computing whether a file is a resource file based on imported/w3c/resources/resource-files.json.
792         (Port._is_test_file): Updated to call Port.is_w3c_resource_file. _is_test_file is no longer static.
793         (Port): Deleted.
794         * Scripts/webkitpy/port/base_unittest.py:
795         (PortTest.test_additional_platform_directory):
796         (PortTest.test_find_no_paths_specified):
797         (PortTest.test_is_test_file): Updated to use non-static version of _is_test_file.
798         (PortTest.test_is_w3c_resource_file): Adding tests.
799
800 2016-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
801
802         Unreviewed. Fix archive-built-product step in GTK+ bots after r205280.
803
804         * BuildSlaveSupport/built-product-archive:
805         (archiveBuiltProduct): Do not copy to the archive the files needed to run GObject DOM bindings API breaks tests
806         that no longer exist.
807
808 2016-09-02  Alex Christensen  <achristensen@webkit.org>
809
810         URLParser should parse file URLs
811         https://bugs.webkit.org/show_bug.cgi?id=161556
812
813         Reviewed by Tim Horton.
814
815         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
816         (TestWebKitAPI::TEST_F):
817         (TestWebKitAPI::checkURLDifferences):
818
819 2016-09-01  Michael Saboff  <msaboff@apple.com>
820
821         Import Chakra tests to JSC
822         https://bugs.webkit.org/show_bug.cgi?id=154697
823
824         Reviewed by Saam Barati.
825
826         Added "runChakra" and "chakraPassFailErrorHandler" to support the running of
827         Chakra tests.
828
829         * Scripts/run-jsc-stress-tests:
830
831 2016-09-02  Jonathan Bedard  <jbedard@apple.com>
832
833         WebKitTestRunner needs layoutTestController.setDashboardCompatibilityMode
834         https://bugs.webkit.org/show_bug.cgi?id=42547
835  
836         Reviewed by Darin Adler.
837
838         Added JavaScript bindings and C++ implementation of setUseDashboardCompatibilityMode for the WebKit2 sTestRunner.
839         Note: this bug mistakenly called this function setDashboardCompatibilityMode, it is actually setUseDashboardCompatibilityMode.
840
841         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Added dashboard compatiblity mode setter.
842         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
843         (WTR::InjectedBundle::beginTesting): Reset dashboard compatibility mode.
844         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
845         (WTR::TestRunner::setJavaScriptCanAccessClipboard): Code style changes.
846         (WTR::TestRunner::setPrivateBrowsingEnabled): Code style changes.
847         (WTR::TestRunner::setUseDashboardCompatibilityMode): Added dashboard compatiblity mode setter.
848         (WTR::TestRunner::setPopupBlockingEnabled): Code style changes.
849         (WTR::TestRunner::setAuthorAndUserStylesEnabled): Code style changes.
850         (WTR::TestRunner::addOriginAccessWhitelistEntry): Code style changes.
851         * WebKitTestRunner/InjectedBundle/TestRunner.h: Added dashboard compatiblity mode setter.
852
853 2016-09-02  Jer Noble  <jer.noble@apple.com>
854
855         Unreviewed build fix: restore storyboard files to Xcode 7-compatability.
856
857         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard:
858         * MobileMiniBrowser/MobileMiniBrowserFramework/Base.lproj/Main.storyboard:
859
860 2016-09-02  Tim Horton  <timothy_horton@apple.com>
861
862         REGRESSION (r205329): Two API tests time out on iOS Simulator
863         https://bugs.webkit.org/show_bug.cgi?id=161542
864
865         Reviewed by Brady Eidson.
866
867         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
868         (createAnimatedResizeWebView):
869         (createFirstVisuallyNonEmptyWatchingNavigationDelegate):
870         (TEST):
871         (animatedResizeWebView): Deleted.
872         The navigation delegate was being stored in a local and went out of scope
873         before the test was over. Keep it around, instead.
874
875 2016-08-31  Jer Noble  <jer.noble@apple.com>
876
877         Refactor MobileMiniBrowser into an application framework to allow external XCTesting
878         https://bugs.webkit.org/show_bug.cgi?id=161462
879
880         Reviewed by Eric Carlson.
881
882         XCTest targets need to be in the same project as the application which they're testing. To facilitate
883         having external projects with XCTest targets, move the application's implementation into a framework
884         that can be included with a bare-bones application shell for testing.
885
886         Simultaneously, add the ability to load files from within the new framework's bundle by using a
887         'bundle:/' URL scheme. Update the tests to use this new bundle URL and remove the dependency on
888         an external server for testing.
889
890         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
891         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard:
892         * MobileMiniBrowser/MobileMiniBrowser/Info.plist:
893         * MobileMiniBrowser/MobileMiniBrowser/main.m:
894         * MobileMiniBrowser/MobileMiniBrowserFramework/AppDelegate.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h.
895         * MobileMiniBrowser/MobileMiniBrowserFramework/AppDelegate.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m.
896         (-[AppDelegate application:didFinishLaunchingWithOptions:]): Manually instantiate the main view
897             controller from the framework's bundle.
898         * MobileMiniBrowser/MobileMiniBrowserFramework/Assets.xcassets/AppIcon.appiconset/Contents.json: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/Assets.xcassets/AppIcon.appiconset/Contents.json.
899         * MobileMiniBrowser/MobileMiniBrowserFramework/Base.lproj/Main.storyboard: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard.
900         * MobileMiniBrowser/MobileMiniBrowserFramework/Info.plist: Added.
901         * MobileMiniBrowser/MobileMiniBrowserFramework/MobileMiniBrowser.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h.
902         * MobileMiniBrowser/MobileMiniBrowserFramework/TabViewController.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/TabViewController.h.
903         * MobileMiniBrowser/MobileMiniBrowserFramework/TabViewController.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/TabViewController.m.
904         * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/WebViewController.h.
905         * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/WebViewController.m.
906         (+[NSURL __bundleURLForFileURL:bundle:]): Add utility method.
907         (+[NSURL __fileURLForBundleURL:bundle:]): Ditto.
908         (-[WebViewController navigateTo:]): Support loading "bundle:/" URLs which are really just "file:" URLs
909             pointing to the framework's resources directory.
910         (-[WebViewController observeValueForKeyPath:ofObject:change:context:]): Ditto.
911         * MobileMiniBrowser/MobileMiniBrowserUITests/MobileMiniBrowserUITests.m:
912         (-[MobileMiniBrowserUITests testBasicVideoPlayback]):
913
914 2016-09-02  Jonathan Bedard  <jbedard@apple.com>
915
916         Fix --no-sample-on-timeout command line argument
917         https://bugs.webkit.org/show_bug.cgi?id=161507
918
919         Reviewed by Alexey Proskuryakov.
920
921         This patch fixes the —no-sample-on-timeout flag and correctly names spindumps as spindump.txt.
922
923         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
924         (parse_args): Fixed —-no-sample-on-timeout.
925         * Scripts/webkitpy/port/apple.py:
926         (ApplePort.sample_process): Use correct file name.
927         (ApplePort.spindump_file_path): Spindump and sample file names are different.
928         * Scripts/webkitpy/port/driver.py:
929         (Driver._check_for_driver_timeout): Check “sample_on_timeout” flag.
930         * Scripts/webkitpy/port/mac_unittest.py:
931         (MacTest.test_spindump): Modified for correct filename.
932
933 2016-09-02  Jonathan Bedard  <jbedard@apple.com>
934
935         Unreviewed: moved myself to the reviewers list.
936
937         * Scripts/webkitpy/common/config/contributors.json:
938
939 2016-09-02  Tomas Popela  <tpopela@redhat.com>
940
941         [GTK] Fix compiler warning in MiniBrowser
942         https://bugs.webkit.org/show_bug.cgi?id=161529
943
944         We were missing a return statement in decidePermissionRequest() and
945         also there was unused variable in browserWindowConstructed().
946
947         Reviewed by Carlos Garcia Campos.
948
949         * MiniBrowser/gtk/BrowserTab.c:
950         (decidePermissionRequest):
951         * MiniBrowser/gtk/BrowserWindow.c:
952         (browserWindowConstructed):
953
954 2016-09-01  Dan Bernstein  <mitz@apple.com>
955
956         Build fix.
957
958         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
959
960 2016-09-01  Tim Horton  <timothy_horton@apple.com>
961
962         Provide a TestWebKitAPI-wide WKNavigationDelegate to simplify tests
963         https://bugs.webkit.org/show_bug.cgi?id=161413
964
965         Reviewed by Simon Fraser.
966
967         Add TestNavigationDelegate, which provides block properties to make
968         writing tests feel a little more natural (the callbacks can be inline),
969         and also add WKWebView _test_waitForDidFinishNavigation, so that many
970         tests don't even need to manually allocate a navigation delegate at all.
971
972         Adopt in some of the simpler tests; there are a few navigation delegates
973         left behind, which we can move to the new model in the future.
974
975         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
976         * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm:
977         (TEST):
978         (-[WKBackForwardListTestNavigationDelegate webView:didFinishNavigation:]): Deleted.
979         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm:
980         (TEST):
981         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]): Deleted.
982         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
983         (animatedResizeWebView):
984         (-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]): Deleted.
985         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
986         (-[AutoLayoutWKWebView initWithFrame:configuration:]):
987         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]):
988         (TEST):
989         (-[AutoLayoutNavigationDelegate webView:didFinishNavigation:]): Deleted.
990         * TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresource.mm:
991         (TEST):
992         (-[CancelFontSubresourceNavigationDelegate webView:didFinishNavigation:]): Deleted.
993         * TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm:
994         (WebKit2_CommandBackForwardTestWKWebView::SetUp):
995         (WebKit2_CommandBackForwardTestWKWebView::loadFiles):
996         (TEST_F):
997         (-[CommandBackForwardNavigationDelegate webView:didFinishNavigation:]): Deleted.
998         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
999         (expectLinkCount):
1000         (TEST):
1001         (-[DataDetectionNavigationDelegate webView:didFinishNavigation:]): Deleted.
1002         * TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm:
1003         (TEST):
1004         (-[FindInPageNavigationDelegate webView:didFinishNavigation:]): Deleted.
1005         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm:
1006         (TEST):
1007         (-[FixedLayoutSizeNavigationDelegate webView:didFinishNavigation:]): Deleted.
1008         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
1009         (TEST):
1010         (-[DatabaseProcessKillNavigationDelegate webView:didFinishNavigation:]): Deleted.
1011         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
1012         (-[IndexedDBNavigationDelegate webView:didFinishNavigation:]): Deleted.
1013         * TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLNotChange.mm:
1014         (TEST):
1015         (-[ProvisionalURLNotChangeController webView:didFinishNavigation:]): Deleted.
1016         (-[ProvisionalURLNotChangeController webView:didFailProvisionalNavigation:withError:]): Deleted.
1017         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1018         (RequiresUserActionForPlaybackTest::createWebView):
1019         (RequiresUserActionForPlaybackTest::testVideoWithAudio):
1020         (RequiresUserActionForPlaybackTest::testVideoWithoutAudio):
1021         (RequiresUserActionForPlaybackTest::testAudioOnly):
1022         (-[RequiresUserActionForPlaybackNavigationDelegate webView:didFinishNavigation:]): Deleted.
1023         * TestWebKitAPI/Tests/WebKit2Cocoa/ShrinkToFit.mm:
1024         (TEST):
1025         (-[ShrinkToFitNavigationDelegate webView:didFinishNavigation:]): Deleted.
1026         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
1027         (TEST):
1028         (webViewForScriptMessageHandlerMultipleHandlerRemovalTest):
1029         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentWorld.mm:
1030         (TEST):
1031         (-[SimpleDelegate webView:didFinishNavigation:]): Deleted.
1032         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm:
1033         (TEST):
1034         (-[WKPDFViewResizeNavigationDelegate webView:didFinishNavigation:]): Deleted.
1035         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
1036         (TEST):
1037         (-[EvaluateJavaScriptNavigationDelegate webView:didFinishNavigation:]): Deleted.
1038         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewTextInput.mm:
1039         (TEST):
1040         (-[DummyNavigationDelegate webView:didFinishNavigation:]): Deleted.
1041         * TestWebKitAPI/cocoa/TestNavigationDelegate.h: Added.
1042         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm: Added.
1043         (-[TestNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1044         (-[TestNavigationDelegate webView:didFinishNavigation:]):
1045         (-[TestNavigationDelegate _webView:renderingProgressDidChange:]):
1046         (-[TestNavigationDelegate waitForDidFinishNavigation]):
1047         (-[WKWebView _test_waitForDidFinishNavigation]):
1048
1049 2016-09-01  Ricky Mondello  <rmondello@apple.com>
1050
1051         YouTube Flash plug-in replacement facility should not insert showinfo=0 into iframe URLs
1052         https://bugs.webkit.org/show_bug.cgi?id=161478
1053         <rdar://problem/28050847>
1054
1055         Reviewed by Eric Carlson.
1056
1057         * TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp:
1058         (TestWebKitAPI::TEST_F): Update expected results.
1059
1060 2016-09-01  Anders Carlsson  <andersca@apple.com>
1061
1062         add BlockPtr::fromCallable
1063         https://bugs.webkit.org/show_bug.cgi?id=161504
1064
1065         Reviewed by Tim Horton.
1066
1067         Add a test.
1068
1069         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1070         * TestWebKitAPI/Tests/WTF/BlockPtr.mm: Added.
1071         (TestWebKitAPI::TEST):
1072
1073 2016-09-01  Alex Christensen  <achristensen@webkit.org>
1074
1075         URLParser should handle . and .. in URL paths
1076         https://bugs.webkit.org/show_bug.cgi?id=161443
1077
1078         Reviewed by Brady Eidson.
1079
1080         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1081         (TestWebKitAPI::eq):
1082         (TestWebKitAPI::TEST_F):
1083
1084 2016-09-01  Commit Queue  <commit-queue@webkit.org>
1085
1086         Unreviewed, rolling out r205295 and r205303.
1087         https://bugs.webkit.org/show_bug.cgi?id=161505
1088
1089         Broke the iOS build (Requested by ryanhaddad on #webkit).
1090
1091         Reverted changesets:
1092
1093         "Refactor MobileMiniBrowser into an application framework to
1094         allow external XCTesting"
1095         https://bugs.webkit.org/show_bug.cgi?id=161462
1096         http://trac.webkit.org/changeset/205295
1097
1098         "Unreviewed build-fix; don't specify an explicit deployment
1099         target."
1100         http://trac.webkit.org/changeset/205303
1101
1102 2016-09-01  Ricky Mondello  <rmondello@apple.com>
1103
1104         YouTube Flash plug-in replacement facility should more gracefully handle malformed queries
1105         https://bugs.webkit.org/show_bug.cgi?id=161476
1106         <rdar://problem/28050847>
1107
1108         Reviewed by Eric Carlson.
1109
1110         * TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp:
1111         (TestWebKitAPI::TEST_F): New tests. The first two and second-to-last test cases cover the "malformed" query
1112             logic. A few other tests are added, too.
1113
1114 2016-09-01  Jer Noble  <jer.noble@apple.com>
1115
1116         Unreviewed build-fix; don't specify an explicit deployment target.
1117
1118         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1119
1120 2016-08-31  Jer Noble  <jer.noble@apple.com>
1121
1122         Refactor MobileMiniBrowser into an application framework to allow external XCTesting
1123         https://bugs.webkit.org/show_bug.cgi?id=161462
1124
1125         Reviewed by Eric Carlson.
1126
1127         XCTest targets need to be in the same project as the application which they're testing. To facilitate
1128         having external projects with XCTest targets, move the application's implementation into a framework
1129         that can be included with a bare-bones application shell for testing.
1130
1131         Simultaneously, add the ability to load files from within the new framework's bundle by using a
1132         'bundle:/' URL scheme. Update the tests to use this new bundle URL and remove the dependency on
1133         an external server for testing.
1134
1135         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1136         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard:
1137         * MobileMiniBrowser/MobileMiniBrowser/Info.plist:
1138         * MobileMiniBrowser/MobileMiniBrowser/main.m:
1139         * MobileMiniBrowser/MobileMiniBrowserFramework/AppDelegate.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h.
1140         * MobileMiniBrowser/MobileMiniBrowserFramework/AppDelegate.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m.
1141         (-[AppDelegate application:didFinishLaunchingWithOptions:]): Manually instantiate the main view
1142             controller from the framework's bundle.
1143         * MobileMiniBrowser/MobileMiniBrowserFramework/Assets.xcassets/AppIcon.appiconset/Contents.json: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/Assets.xcassets/AppIcon.appiconset/Contents.json.
1144         * MobileMiniBrowser/MobileMiniBrowserFramework/Base.lproj/Main.storyboard: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard.
1145         * MobileMiniBrowser/MobileMiniBrowserFramework/Info.plist: Added.
1146         * MobileMiniBrowser/MobileMiniBrowserFramework/MobileMiniBrowser.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h.
1147         * MobileMiniBrowser/MobileMiniBrowserFramework/TabViewController.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/TabViewController.h.
1148         * MobileMiniBrowser/MobileMiniBrowserFramework/TabViewController.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/TabViewController.m.
1149         * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/WebViewController.h.
1150         * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/WebViewController.m.
1151         (+[NSURL __bundleURLForFileURL:bundle:]): Add utility method.
1152         (+[NSURL __fileURLForBundleURL:bundle:]): Ditto.
1153         (-[WebViewController navigateTo:]): Support loading "bundle:/" URLs which are really just "file:" URLs
1154             pointing to the framework's resources directory.
1155         (-[WebViewController observeValueForKeyPath:ofObject:change:context:]): Ditto.
1156         * MobileMiniBrowser/MobileMiniBrowserUITests/MobileMiniBrowserUITests.m:
1157         (-[MobileMiniBrowserUITests testBasicVideoPlayback]):
1158
1159 2016-09-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1160
1161         Unreviewed. Fix webkitpy unit tests after r205280.
1162
1163         * Scripts/webkitpy/style/checker_unittest.py:
1164         (GlobalVariablesTest.test_path_rules_specifier):
1165
1166 2016-08-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1167
1168         [GTK] Move GObject DOM bindings to WebKit2 layer and stop auto generating them
1169         https://bugs.webkit.org/show_bug.cgi?id=161438
1170
1171         Reviewed by Michael Catanzaro.
1172
1173         Remove scripts related to the GObject DOM bindings auto-generation.
1174
1175         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1176         (RunGtkAPITests.getText2):
1177         (TestFactory.__init__):
1178         (RunWebKit1Tests): Deleted.
1179         (RunWebKit1Tests.start): Deleted.
1180         (RunWebKit1LeakTests): Deleted.
1181         (RunWebKit1LeakTests.start): Deleted.
1182         (RunAndUploadPerfTests): Deleted.
1183         (RunAndUploadPerfTests.start): Deleted.
1184         (BuildAndRemoteJSCTestsFactory.__init__): Deleted.
1185         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1186         (BuildStepsTest.test_unnecessary_expected_results):
1187         (RunAndUploadPerfTestsTest): Deleted.
1188         (RunAndUploadPerfTestsTest.assertResults): Deleted.
1189         (RunAndUploadPerfTestsTest.test_success): Deleted.
1190         (RunAndUploadPerfTestsTest.test_tests_failed): Deleted.
1191         (RunAndUploadPerfTestsTest.test_build_bad_build): Deleted.
1192         (RunAndUploadPerfTestsTest.test_build_bad_source_json): Deleted.
1193         (RunAndUploadPerfTestsTest.test_build_bad_marge): Deleted.
1194         (RunAndUploadPerfTestsTest.test_build_bad_failed_uploading): Deleted.
1195         (RunAndUploadPerfTestsTest.test_build_bad_preparation): Deleted.
1196         (RunAndUploadPerfTestsTest.test_buildbot_timeout): Deleted.
1197         (RunBenchmarkTest): Deleted.
1198         (RunBenchmarkTest.assertResults): Deleted.
1199         (RunBenchmarkTest.test_success): Deleted.
1200         * Scripts/run-bindings-tests:
1201         (main):
1202         * Scripts/webkitpy/style/checker.py:
1203         * gtk/check-for-webkitdom-api-breaks: Removed.
1204         * gtk/generate-gtkdoc:
1205         * gtk/webkitdom.py: Removed.
1206
1207 2016-08-31  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1208
1209         [EFL] Small clean up in MiniBrowser
1210         https://bugs.webkit.org/show_bug.cgi?id=161428
1211
1212         Reviewed by Yusuke Suzuki.
1213
1214         This patch resizes MiniBrowser, add *char* constants for scheme,
1215         does line breaking, and remove unnecessary spaces.
1216
1217         * MiniBrowser/efl/main.c:
1218         (on_mouse_wheel):
1219         (history_list_hide):
1220         (script_execute_callback):
1221         (on_key_down):
1222         (on_url_changed):
1223         (on_error):
1224         (on_color_picker_request):
1225         (url_from_user_input):
1226         (url_load_from_user_input):
1227         (on_back_button_clicked):
1228         (on_search_case_option_changed):
1229         (on_search_word_start_option_changed):
1230         (on_list_item_select):
1231         (navigation_button_longpress_process):
1232         (on_navigation_policy_decision):
1233         (window_create):
1234         (parse_cookies_policy):
1235
1236 2016-08-31  Alex Christensen  <achristensen@webkit.org>
1237
1238         Implement IPv6 parsing in URLParser
1239         https://bugs.webkit.org/show_bug.cgi?id=161390
1240
1241         Reviewed by Darin Adler.
1242
1243         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1244         (TestWebKitAPI::TEST_F):
1245         (TestWebKitAPI::checkURLDifferences):
1246
1247 2016-08-31  Brady Eidson  <beidson@apple.com>
1248
1249         WK2 Gamepad provider on iOS.
1250         https://bugs.webkit.org/show_bug.cgi?id=161412
1251
1252         Reviewed by Tim Horton.
1253
1254         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1255
1256 2016-08-30  Ricky Mondello  <rmondello@apple.com>
1257
1258         YouTubePluginReplacementTest's URL transformation logic should have tests
1259         https://bugs.webkit.org/show_bug.cgi?id=161406
1260         <rdar://problem/28050847>
1261
1262         Reviewed by Eric Carlson.
1263
1264         Add some very basic tests. Future patches should expand on these to find and fix bugs.
1265
1266         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add YouTubePluginReplacement.cpp.
1267         * TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp: Added.
1268         (TestWebKitAPI::test): Added.
1269         (TestWebKitAPI::TEST_F): Added.
1270
1271 2016-08-30  Brady Eidson  <beidson@apple.com>
1272
1273         GameController.framework backend for gamepad API.
1274         https://bugs.webkit.org/show_bug.cgi?id=161086
1275
1276         Reviewed by Alex Christensen.
1277
1278         * MiniBrowser/mac/AppDelegate.m:
1279         (-[BrowserAppDelegate awakeFromNib]):
1280
1281         * MiniBrowser/mac/SettingsController.h:
1282         * MiniBrowser/mac/SettingsController.m:
1283         (-[SettingsController _populateMenu]):
1284         (-[SettingsController validateMenuItem:]):
1285         (-[SettingsController usesGameControllerFramework]):
1286         (-[SettingsController toggleUsesGameControllerFramework:]):
1287
1288 2016-08-30  Brent Fulgham  <bfulgham@apple.com>
1289
1290         Use of uninitialised memory in TransformationMatrx::blend4()
1291         https://bugs.webkit.org/show_bug.cgi?id=134621
1292         <rdar://problem/27337539>
1293
1294         Reviewed by Dean Jackson.
1295
1296         Change is based on the Blink change (patch by <alancutter@chromium.org>):
1297         <https://src.chromium.org/viewvc/blink?revision=177453&view=revision>
1298
1299         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1300         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp: Added.
1301         (TestWebKitAPI::TEST):
1302
1303 2016-08-30  Alex Christensen  <achristensen@webkit.org>
1304
1305         URLParser should handle relative URLs that start with //
1306         https://bugs.webkit.org/show_bug.cgi?id=161364
1307
1308         Reviewed by Darin Adler.
1309
1310         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1311         (TestWebKitAPI::checkRelativeURL):
1312         (TestWebKitAPI::TEST_F):
1313
1314 2016-08-29  Aakash Jain  <aakash_jain@apple.com>
1315
1316         EWS patch status page should indicate bot corresponding to each status message
1317         https://bugs.webkit.org/show_bug.cgi?id=161280
1318
1319         Reviewed by Alexey Proskuryakov.
1320
1321         * QueueStatusServer/templates/patch.html: Formatting changes.
1322
1323 2016-08-29  Aakash Jain  <aakash_jain@apple.com>
1324
1325         EWS should indicate which bot processed the patch
1326         https://bugs.webkit.org/show_bug.cgi?id=161222
1327
1328         Reviewed by Alexey Proskuryakov.
1329
1330         * QueueStatusServer/handlers/statusbubble.py:
1331         (StatusBubble._build_bubble): Remove the bot id from bubbles as it is confusing.
1332         bot ids are now displayed in patch status page.
1333
1334 2016-08-29  Alex Christensen  <achristensen@webkit.org>
1335
1336         URLParser should parse about:blank
1337         https://bugs.webkit.org/show_bug.cgi?id=161324
1338
1339         Reviewed by Brady Eidson.
1340
1341         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1342         (TestWebKitAPI::TEST_F):
1343
1344 2016-08-29  JF Bastien  <jfbastien@apple.com>
1345
1346         Bug 161165 - check-webkit-style doesn't understand macros containing `else` or labels
1347         https://bugs.webkit.org/show_bug.cgi?id=161165
1348
1349         Reviewed by Geoffrey Garen.
1350
1351         Fix handling of `else` in a macro. Don't handle labels in a macro:
1352         the checker is already pretty messy in that area and it should be
1353         a rare thing.
1354
1355         * Scripts/webkitpy/style/checkers/cpp.py:
1356         (check_braces):
1357         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1358         (CppStyleTest.test_else_clause_not_on_same_line_as_else):
1359
1360 2016-08-29  Alex Christensen  <achristensen@webkit.org>
1361
1362         API test URLParserTest.ParserFailures failing ASSERT_NOT_REACHED
1363         https://bugs.webkit.org/show_bug.cgi?id=161317
1364
1365         Reviewed by Brady Eidson.
1366
1367         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1368         (TestWebKitAPI::TEST_F):
1369
1370 2016-08-29  Jer Noble  <jer.noble@apple.com>
1371
1372         Unreviewed gardening; only build MiniBrowser against iOS SDK targets.
1373
1374         * Makefile:
1375
1376 2016-08-29  Jonathan Bedard  <jbedard@apple.com>
1377
1378         Sample Process on notifyDone timed out
1379         https://bugs.webkit.org/show_bug.cgi?id=161063
1380
1381         Reviewed by Darin Adler.
1382
1383         * Scripts/webkitpy/port/driver.py:
1384         (Driver._check_for_driver_timeout): 
1385         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Call sample_process during notifyDone timeouts.
1386         (WTR::TestRunner::waitToDumpWatchdogTimerFired):
1387         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm: Log pid and name for testing harness.
1388
1389 2016-08-29  Jonathan Bedard  <jbedard@apple.com>
1390
1391         Check-webkit-style does not work with Objective-C blocks
1392         https://bugs.webkit.org/show_bug.cgi?id=161247
1393
1394         Reviewed by Darin Adler.
1395
1396         * Scripts/webkitpy/style/checkers/cpp.py:
1397         (regex_for_lambda_functions): Changed to regex_for_lambdas_and_blocks.
1398         (regex_for_lambdas_and_blocks): Added check for Objective-C blocks.
1399         (check_spacing_for_function_call): Pass file state for lambda check.
1400         (check_spacing): Pass file state for lambda check.
1401         (check_braces): Pass file state for lambda check.
1402         (check_style): Pass file state for lambda check.
1403         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1404         (CppStyleTest.test_cpp_lambda_functions): Changed from ‘test_lambda_functions’.
1405         (CppStyleTest.test_objective_c_block): Tests Objective-C blocks.
1406         (CppStyleTest.test_lambda_functions): Changed to ‘test_cpp_lambda_functions’.
1407
1408 2016-08-29  Aakash Jain  <aakash_jain@apple.com>
1409
1410         EWS patch status page should indicate bot corresponding to each status message
1411         https://bugs.webkit.org/show_bug.cgi?id=161280
1412
1413         Reviewed by Alexey Proskuryakov.
1414
1415         * QueueStatusServer/templates/patch.html: Added bot_id in the template so that bot id is displayed
1416         for each status message.
1417         * QueueStatusServer/stylesheets/common.css:
1418         (.status-bot): Added corresponding stylesheet class.
1419
1420 2016-08-29  Per Arne Vollan  <pvollan@apple.com>
1421
1422         Attempt to fix Windows build after r205090.
1423
1424         Unreviewed build fix.
1425
1426         * DumpRenderTree/win/DRTDataObject.cpp:
1427         (cfFileNameWFormat):
1428         (cfUrlWFormat):
1429
1430 2016-08-27  Alex Christensen  <achristensen@webkit.org>
1431
1432         URLParser should parse relative URLs
1433         https://bugs.webkit.org/show_bug.cgi?id=161282
1434
1435         Reviewed by Darin Adler.
1436
1437         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1438         (TestWebKitAPI::TEST):
1439         Added some tests for the new operator=.
1440         Test saving iterators, restoring iterators, and even assigning iterators to new CodePoints objects.
1441         Using the same iterator to iterate multiple objects is bad practice, but it's possible and now tested.
1442         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1443         (TestWebKitAPI::checkURL):
1444         (TestWebKitAPI::TEST_F):
1445         (TestWebKitAPI::checkRelativeURL):
1446         (TestWebKitAPI::checkURLDifferences):
1447         (TestWebKitAPI::shouldFail):
1448         Add some relative URL tests.
1449
1450 2016-08-27  Jonathan Bedard  <jbedard@apple.com>
1451
1452         WTR needs an implementation of setAutomaticLinkDetectionEnabled
1453         https://bugs.webkit.org/show_bug.cgi?id=87162
1454
1455         Reviewed by Darin Adler.
1456
1457         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Added setAutomaticLinkDetectionEnabled binding.
1458         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1459         (WTR::InjectedBundle::beginTesting): Set automatic link detection to false by default.
1460         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1461         (WTR::TestRunner::setAutomaticLinkDetectionEnabled): Added setAutomaticLinkDetectionEnabled definition.
1462         * WebKitTestRunner/InjectedBundle/TestRunner.h: Added setAutomaticLinkDetectionEnabled declaration.
1463
1464 2016-08-27  Joseph Pecoraro  <pecoraro@apple.com>
1465
1466         Web Inspector: Make localizedString.js diff and commit friendly (UTF16 -> UTF8)
1467         https://bugs.webkit.org/show_bug.cgi?id=28685
1468         <rdar://problem/16460975>
1469
1470         Reviewed by Darin Adler.
1471
1472         * Scripts/extract-localizable-js-strings:
1473         * Scripts/update-webkit-localizable-strings:
1474         WebInspectorUI localizedStrings.js is now UTF-8. Other clients of
1475         this script still use UTF-16, so keep that the default.
1476
1477 2016-08-27  Alexey Proskuryakov  <ap@apple.com>
1478
1479         REGRESSION (r204052): Popovers on bot watcher's dashboard are broken
1480         https://bugs.webkit.org/show_bug.cgi?id=161254
1481
1482         Reviewed by Darin Adler.
1483
1484         Simplify the CSS. My understanding that the CSS was correct, and the root cause
1485         is tracked in bug 160478.
1486
1487         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
1488
1489 2016-08-27  Simon Fraser  <simon.fraser@apple.com>
1490
1491         Add run-webkit-tests --print-expectations to show expectations for all or a subset of tests
1492         https://bugs.webkit.org/show_bug.cgi?id=161217
1493
1494         Reviewed by Ryosuke Niwa.
1495
1496         "run-webkit-tests --print-expectations" runs the same logic as running the tests, but
1497         dumps out the lists of tests that would be run and skipped, and, for each, the entry
1498         in TestExpectations that determines the expected outcome of the test.
1499
1500         This is an improved version of webkit-patch print-expectations.
1501
1502         See bug for sample output.
1503
1504         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1505         (Manager._print_expectations_for_subset): Print out the list of tests and expected
1506         outcome for some subset of tests.
1507         (Manager.print_expectations): Do the same splitting by device class that running tests
1508         does, and for each subset of tests, call _print_expectations_for_subset.
1509         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1510         (TestExpectationParser.expectation_for_skipped_test): Set the flag
1511         expectation_line.not_applicable_to_current_platform
1512         (TestExpectationLine.__init__): Init not_applicable_to_current_platform to False
1513         (TestExpectationLine.expected_behavior): line.expectation is ['PASS'] by default,
1514         even for skipped tests. This function returns a list relevant for display, taking the skipped
1515         modifier into account.
1516         (TestExpectationLine.create_passing_expectation): expectations is normally a list, not a set.
1517         (TestExpectations.readable_filename_and_line_number): Return something printable for 
1518         lines with and without filenames
1519         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1520         (main): Handle options.print_expectations
1521         (parse_args): Add support for --print-expectations
1522         (_print_expectations):
1523         * Scripts/webkitpy/port/ios.py:
1524         (IOSSimulatorPort.default_child_processes): Make this a debug log.
1525
1526 2016-08-26  Dan Bernstein  <mitz@apple.com>
1527
1528         Keep trying to fix the build after r205057.
1529
1530         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1531
1532 2016-08-26  Dan Bernstein  <mitz@apple.com>
1533
1534         Keep trying to fix the build after r205057.
1535
1536         * MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m: Don’t try to import nonexistent
1537           config.h. This file is only meant to be built with Xcode anyway.
1538         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard: Make this compile
1539           with Xcode 7.3 and deploy to iOS 9.0.
1540         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard: Ditto.
1541         * MobileMiniBrowser/MobileMiniBrowser/TabViewController.m: Don’t try to import config.h.
1542         * MobileMiniBrowser/MobileMiniBrowser/WebViewController.m: Ditto.
1543
1544 2016-08-26  Dan Bernstein  <mitz@apple.com>
1545
1546         Start trying to fix the build after r205057.
1547
1548         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1549
1550 2016-08-26  Alexey Proskuryakov  <ap@apple.com>
1551
1552         Remove Yosemite Leaks from the flakiness dashboard
1553         https://bugs.webkit.org/show_bug.cgi?id=161253
1554
1555         Reviewed by Anders Carlsson.
1556
1557         * TestResultServer/static-dashboards/builders.jsonp:
1558
1559 2016-08-26  Sam Weinig  <sam@webkit.org>
1560
1561         Remove support for ENABLE_LEGACY_WEB_AUDIO
1562         https://bugs.webkit.org/show_bug.cgi?id=161262
1563
1564         Reviewed by Anders Carlsson.
1565
1566         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1567
1568 2016-08-26  Jer Noble  <jer.noble@apple.com>
1569
1570         Add a test harness for running UI tests on the iOS Simulator
1571         https://bugs.webkit.org/show_bug.cgi?id=161265
1572
1573         Reviewed by Simon Fraser.
1574
1575         Add a new iOS Simulator application which uses WKWebView to implement a basic browser, and which
1576         can serve as a test harness for WebKit UI tests.
1577
1578         Also add a basic media playback test which verifies that a <video> element will begin playing in
1579         fullscreen on an iPhone device, but will play inline on an iPad device.
1580
1581         * Makefile: Add MobileMiniBrowser as a Module for iOS builds.
1582         * MobileMiniBrowser/Configurations/Base.xcconfig: Added.
1583         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig: Added.
1584         * MobileMiniBrowser/Configurations/MobileMiniBrowser.xcconfig: Added.
1585         * MobileMiniBrowser/Makefile: Added.
1586         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj: Added.
1587         * MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h: Added.
1588         * MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m: Added.
1589         (-[AppDelegate application:didFinishLaunchingWithOptions:]):
1590         (-[AppDelegate applicationWillResignActive:]):
1591         (-[AppDelegate applicationDidEnterBackground:]):
1592         (-[AppDelegate applicationWillEnterForeground:]):
1593         (-[AppDelegate applicationDidBecomeActive:]):
1594         (-[AppDelegate applicationWillTerminate:]):
1595         * MobileMiniBrowser/MobileMiniBrowser/Assets.xcassets/AppIcon.appiconset/Contents.json: Added.
1596         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard: Added.
1597         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard: Added.
1598         * MobileMiniBrowser/MobileMiniBrowser/Info.plist: Added.
1599         * MobileMiniBrowser/MobileMiniBrowser/TabViewController.h: Added.
1600         * MobileMiniBrowser/MobileMiniBrowser/TabViewController.m: Added.
1601         (-[TabViewController dealloc]):
1602         (-[TabViewController viewDidLoad]):
1603         (-[TabViewController observeValueForKeyPath:ofObject:change:context:]):
1604         (-[TabViewController tableView:cellForRowAtIndexPath:]):
1605         (-[TabViewController tableView:numberOfRowsInSection:]):
1606         (-[TabViewController numberOfSectionsInTableView:]):
1607         (-[TabViewController tableView:canEditRowAtIndexPath:]):
1608         (-[TabViewController tableView:canMoveRowAtIndexPath:]):
1609         (-[TabViewController tableView:commitEditingStyle:forRowAtIndexPath:]):
1610         (-[TabViewController tableView:didSelectRowAtIndexPath:]):
1611         * MobileMiniBrowser/MobileMiniBrowser/WebViewController.h: Added.
1612         * MobileMiniBrowser/MobileMiniBrowser/WebViewController.m: Added.
1613         (-[WebViewController viewDidLoad]):
1614         (-[WebViewController didReceiveMemoryWarning]):
1615         (-[WebViewController reload:]):
1616         (-[WebViewController goBack:]):
1617         (-[WebViewController goForward:]):
1618         (-[WebViewController urlFieldEditingBegan:]):
1619         (-[WebViewController navigateTo:]):
1620         (-[WebViewController showTabs:]):
1621         (-[WebViewController selectWebViewAtIndex:]):
1622         (-[WebViewController removeWebViewAtIndex:]):
1623         (-[WebViewController addWebView]):
1624         (-[WebViewController createWebView]):
1625         (-[WebViewController removeWebView:]):
1626         (-[WebViewController setCurrentWebView:]):
1627         (-[WebViewController webView:didFailNavigation:withError:]):
1628         (-[WebViewController observeValueForKeyPath:ofObject:change:context:]):
1629         * MobileMiniBrowser/MobileMiniBrowser/main.m: Added.
1630         (main):
1631         * MobileMiniBrowser/MobileMiniBrowserUITests/Info.plist: Added.
1632         * MobileMiniBrowser/MobileMiniBrowserUITests/MobileMiniBrowserUITests.m: Added.
1633         (-[MobileMiniBrowserUITests setUp]):
1634         (-[MobileMiniBrowserUITests tearDown]):
1635         (-[MobileMiniBrowserUITests testBasicVideoPlayback]):
1636
1637 2016-08-26  Aakash Jain  <aakash_jain@apple.com>
1638
1639         webkit-queues queue-status page should should list more recent statuses
1640         https://bugs.webkit.org/show_bug.cgi?id=161220
1641
1642         Reviewed by Daniel Bates.
1643
1644         * QueueStatusServer/handlers/queuestatus.py:
1645         (QueueStatus._fetch_statuses): Increase the number of recent statuses from 15 to 50.
1646
1647 2016-08-26  Dan Bernstein  <mitz@apple.com>
1648
1649         [Cocoa] Infinite recursion calling -charValue on a WKNSNumber
1650         https://bugs.webkit.org/show_bug.cgi?id=161258
1651
1652         Reviewed by Anders Carlsson.
1653
1654         * TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm:
1655         (TestWebKitAPI::TEST):
1656
1657 2016-08-26  Csaba Osztrogonác  <ossy@webkit.org>
1658
1659         Fix the ENABLE(WEBASSEMBLY) build on Linux
1660         https://bugs.webkit.org/show_bug.cgi?id=161197
1661
1662         Reviewed by Mark Lam.
1663
1664         * Scripts/build-jsc:
1665
1666 2016-08-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1667
1668         [GTK] run-gtk-tests should use the driver environment for checking the accessibility bus
1669         https://bugs.webkit.org/show_bug.cgi?id=161149
1670
1671         Reviewed by Carlos Garcia Campos.
1672
1673         Add a new function for waiting for the accesibility bus. It sets
1674         the test environment variables before starting the GLib mainloop.
1675         And restores the previous environment after it has finished.
1676         It also adds a timeout (5 seconds) to abort in case it has not
1677         been able to detect the accesibility bus before the timeout expires.
1678
1679         * Scripts/run-gtk-tests:
1680         (TestRunner):
1681         (TestRunner._wait_for_accessibility_bus):
1682         (TestRunner._wait_for_accessibility_bus.timeout_accessibility_bus):
1683         (TestRunner._start_accessibility_daemons):
1684         (TestRunner._get_tests_from_google_test_suite): Run this command also with the driver test environment.
1685
1686 2016-08-26  Per Arne Vollan  <pvollan@apple.com>
1687
1688         [Win] Warning fix.
1689         https://bugs.webkit.org/show_bug.cgi?id=161236
1690
1691         Reviewed by Brent Fulgham.
1692
1693         The & operator in the Test struct has no body.
1694
1695         * TestWebKitAPI/Tests/WTF/Vector.cpp:
1696         (TestWebKitAPI::TEST):
1697
1698 2016-08-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1699
1700         [GTK] run-gtk-tests should use webkitpy.port.gtk and webkitpy.port.xvfbdriver
1701         https://bugs.webkit.org/show_bug.cgi?id=160736
1702
1703         Reviewed by Carlos Garcia Campos.
1704
1705         This plugs run-gtk-tests into the webkitpy testing infrastructure.
1706         As a benefit of this, run-gtk-tests now can be executed over any of
1707         the existing supported gtk test display servers (xvfb, weston-over-xvfb,
1708         or native xorg). A new command line switch --wayland is added for
1709         run-gtk-tests.
1710
1711         * Scripts/run-gtk-tests:
1712         (TestRunner.__init__): Remove the --display command line switch, its not longer useful.
1713         Add a --wayland command line switch.
1714         (TestRunner._start_accessibility_daemons):
1715         (TestRunner):
1716         (TestRunner.__init__):
1717         (TestRunner._run_xvfb): Deleted.
1718         (TestRunner._create_driver):
1719         (TestRunner._setup_testing_environment): Delete the environment variable definitions that
1720         are now done by driver._setup_environ_for_test().
1721         (TestRunner._tear_down_testing_environment):
1722         * Scripts/webkitpy/port/driver.py:
1723         (Driver.__init__): Define self._server_name in the constructor of the base class.
1724         It is used by several functions, so it makes sense to store once the value here.
1725         (Driver._setup_environ_for_test): Factorize setting the environment for a given test.
1726         (Driver._start): Get the environment from self._setup_environ_for_test()
1727         * Scripts/webkitpy/port/driver_unittest.py:
1728         (DriverTest):
1729         (DriverTest.test_setup_environ_for_test): Add unittest for driver._setup_environ_for_test()
1730         * Scripts/webkitpy/port/gtk.py: Move the inspection of the env var USE_NATIVE_XDISPLAY to the constructor.
1731         (GtkPort.__init__):
1732         (GtkPort._driver_class):
1733         * Scripts/webkitpy/port/westondriver.py: Define and use self._setup_environ_for_test()
1734         (WestonDriver._setup_environ_for_test):
1735         (WestonDriver._start):
1736         * Scripts/webkitpy/port/xorgdriver.py: Define and use self._setup_environ_for_test()
1737         (XorgDriver._setup_environ_for_test):
1738         (XorgDriver._start):
1739         * Scripts/webkitpy/port/xvfbdriver.py: Define and use self._setup_environ_for_test()
1740         (XvfbDriver._setup_environ_for_test):
1741         (XvfbDriver._start):
1742
1743 2016-08-26  Csaba Osztrogonác  <ossy@webkit.org>
1744
1745         [EFL][GTK] REGRESSION(204877): Fix the clean build
1746         https://bugs.webkit.org/show_bug.cgi?id=161240
1747
1748         Reviewed by Carlos Garcia Campos.
1749
1750         * WebKitTestRunner/PlatformEfl.cmake:
1751         * WebKitTestRunner/PlatformGTK.cmake:
1752
1753 2016-08-26  Aakash Jain  <aakash_jain@apple.com>
1754
1755         EWS should indicate which bot processed the patch
1756         https://bugs.webkit.org/show_bug.cgi?id=161222
1757
1758         Reviewed by Daniel Bates.
1759
1760         * QueueStatusServer/handlers/statusbubble.py:
1761         (StatusBubble._build_bubble): Display the bot id in status bubble. Also removed "Started processing" message since
1762         after bug fix of 161223, bots send the "Started processing patch" message and it would be displayed in Recent messages.
1763         Also added "Started processing patch" message to progress_statuses.
1764         I might consider displaying bot id in other statuses as well later on.
1765
1766 2016-08-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1767
1768         [EFL] Change homepage url to www.ewebkit.org on MiniBrowser
1769         https://bugs.webkit.org/show_bug.cgi?id=161184
1770
1771         Reviewed by Carlos Garcia Campos.
1772
1773         * MiniBrowser/efl/main.c: Set www.ewebkit.org.
1774
1775 2016-08-25  Aakash Jain  <aakash_jain@apple.com>
1776
1777         ews queues should update status server when they start processing patch
1778         https://bugs.webkit.org/show_bug.cgi?id=161223
1779
1780         Reviewed by Daniel Bates.
1781
1782         * Scripts/webkitpy/tool/commands/queues.py:
1783         (AbstractReviewQueue.process_work_item): Update status server that the bot started processing the patch.
1784         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1785         (EarlyWarningSystemTest._default_expected_logs): Updated the unit test accordingly.
1786         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1787         (StyleQueueTest.test_style_queue_with_style_exception): Same.
1788         (test_style_queue_with_watch_list_exception): Same.
1789         (test_non_valid_patch): Same.
1790
1791 2016-08-25  Alex Christensen  <achristensen@webkit.org>
1792
1793         CMake build fix.
1794
1795         * DumpRenderTree/PlatformMac.cmake:
1796
1797 2016-08-25  Alex Christensen  <achristensen@webkit.org>
1798
1799         Fix URLParserTest with GuardMalloc
1800         https://bugs.webkit.org/show_bug.cgi?id=161214
1801         rdar://problem/28014390
1802
1803         Reviewed by Tim Horton.
1804
1805         The CString returned by String::utf8 was going out of scope before we were doing a string comparison on its data.
1806         This just does the comparison of the CStrings instead to keep them in scope during the comparison.
1807
1808         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1809         (TestWebKitAPI::eq):
1810         (TestWebKitAPI::checkURL):
1811         (TestWebKitAPI::checkURLDifferences):
1812         (TestWebKitAPI::s): Deleted.
1813
1814 2016-08-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1815
1816         Dragging against the end of the inline media scrubber causes the media scrubber to hide
1817         https://bugs.webkit.org/show_bug.cgi?id=161207
1818
1819         Reviewed by Eric Carlson.
1820
1821         Tweaks an existing WebKit API test covering this behavior change. After some discussion, rather than hide media
1822         controls in this case, we should actually continue showing them. This is because seeking due to user gestures
1823         similar to "scrubbing" are indistinguishable from gestures that immediately seek to the end.
1824
1825         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1826         (TestWebKitAPI::TEST):
1827
1828 2016-08-25  Daniel Bates  <dabates@apple.com>
1829
1830         Watch more things.
1831
1832         * Scripts/webkitpy/common/config/watchlist:
1833
1834 2016-08-25  Daniel Bates  <dabates@apple.com>
1835
1836         Fix test failure on GTK Linux bots after <http://trac.webkit.org/changeset/204695>
1837         (https://bugs.webkit.org/show_bug.cgi?id=148437)
1838
1839         Remove use of module File::Slurp as it is not part of the standard Perl 5 distribution
1840         and is not installed on the GTK Linux bots.
1841
1842         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
1843         (writeFileWithContent): Added.
1844
1845 2016-08-25  Per Arne Vollan  <pvollan@apple.com>
1846
1847         [Win] run-api-tests is failing.
1848         https://bugs.webkit.org/show_bug.cgi?id=161140
1849
1850         Reviewed by Brent Fulgham.
1851
1852         Since the move constructor is called 3 more times on Windows, we will have 3 more destructor calls.
1853
1854         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
1855         (TestWebKitAPI::TEST):
1856
1857 2016-08-24  Per Arne Vollan  <pvollan@apple.com>
1858
1859         [Win] run-api-tests is failing.
1860         https://bugs.webkit.org/show_bug.cgi?id=161140
1861
1862         Reviewed by Brent Fulgham.
1863
1864         The number of times the move constructor is called is different on Windows in this test. This seems
1865         to be caused by differences in MSVC's implementation of lambdas or std functions like std::make_tuple.
1866
1867         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
1868         (TestWebKitAPI::TEST):
1869
1870 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
1871
1872         Fix iOS DRT build.
1873
1874         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1875         (WTR::UIScriptController::zoomToScale):
1876
1877 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
1878
1879         [iOS DRT] Hook up uiController.zoomToScale() for DRT
1880         https://bugs.webkit.org/show_bug.cgi?id=161173
1881
1882         Reviewed by Tim Horton.
1883         
1884         Make a UIWebScrollView subclass, DumpRenderTreeWebScrollView, which has an internal delegate to get
1885         UIScrollView delegate callbacks. Store the zoomToScaleCompletionHandler on it.
1886         
1887         UIScriptController::zoomToScale() has to bounce the zoom to the main thread (no poking UIKit from
1888         the WebThread!), but queue up the callback first.
1889
1890         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
1891         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
1892         (-[DumpRenderTreeWebScrollView initWithFrame:]):
1893         (-[DumpRenderTreeWebScrollView dealloc]):
1894         (-[DumpRenderTreeWebScrollView zoomToScale:animated:completionHandler:]):
1895         (-[DumpRenderTreeWebScrollView completedZoomToScale]):
1896         (-[DumpRenderTreeWebScrollViewDelegate initWithScrollView:]):
1897         (-[DumpRenderTreeWebScrollViewDelegate viewForZoomingInScrollView:]): All UIScrollView delegates need to implement this.
1898         (-[DumpRenderTreeWebScrollViewDelegate scrollViewDidEndZooming:withView:atScale:]):
1899         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1900         (WTR::UIScriptController::zoomToScale):
1901         * DumpRenderTree/mac/DumpRenderTree.mm:
1902         (createWebViewAndOffscreenWindow):
1903         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1904         (WTR::UIScriptController::context):
1905
1906 2016-08-24  Ryan Haddad  <ryanhaddad@apple.com>
1907
1908         Attempt to fix Windows build after r204918.
1909
1910         Unreviewed build fix.
1911
1912         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1913         (ResourceLoadDelegate::willSendRequest):
1914
1915 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
1916
1917         [iOS DRT] Get basic viewport tests working in DRT
1918         https://bugs.webkit.org/show_bug.cgi?id=161160
1919
1920         Reviewed by Tim Horton.
1921         
1922         Hook up enough of UIScriptController in iOS DRT to be able to read viewport
1923         scale, and get the contentVisibleRect.
1924         
1925         Requires exposing a bit of UIWebBrowserView SPI from UIKit, which in turn
1926         requires typing the gWebBrowserView as a DumpRenderTreeBrowserView * everywhere.
1927         
1928         One test has different results between DRT and WTR, but DRT behavior seems to differ
1929         from UIWebView here, so just give it a WK1-specific result.
1930
1931         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
1932         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
1933         (-[DumpRenderTreeBrowserView documentVisibleRect]):
1934         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1935         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1936         (WTR::UIScriptController::zoomScale):
1937         (WTR::UIScriptController::minimumZoomScale):
1938         (WTR::UIScriptController::maximumZoomScale):
1939         (WTR::UIScriptController::contentVisibleRect):
1940         * DumpRenderTree/mac/DumpRenderTree.mm:
1941         (createWebViewAndOffscreenWindow):
1942         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1943
1944 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
1945
1946         Minor project rearrangement.
1947
1948         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1949
1950 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
1951
1952         [iOS DRT] Make iOS DRT use the same window size as WebKitTestRunner for flexible viewport tests
1953         https://bugs.webkit.org/show_bug.cgi?id=161124
1954
1955         Reviewed by Daniel Bates.
1956         
1957         Use the main UIScreen's bounds for the size of the window in flexible viewport mode,
1958         and remove the 'phoneBrowserAddressBarOffset' hack, so that it matches WTR.
1959         
1960         Remove some unnecessary zero initializations of static variables.
1961         
1962         Change _setVisibleSize to use the window size, which should not be a behavior change
1963         because this it just used for text autosizing, which is disabled by default,
1964         and only the width is consulted.
1965
1966         * DumpRenderTree/mac/DumpRenderTree.mm:
1967         (adjustWebDocumentForFlexibleViewport):
1968         (adjustWebDocumentForStandardViewport):
1969         (createWebViewAndOffscreenWindow):
1970
1971 2016-08-24  Jonathan Bedard  <jbedard@apple.com>
1972
1973         WebKit2 needs layoutTestController.setDeferMainResourceDataLoad
1974         https://bugs.webkit.org/show_bug.cgi?id=42777
1975
1976         Reviewed by Darin Adler.
1977
1978         The setDeferMainResourceDataLoad method was not correctly tested in DumpRenderTree and would pass even when setDeterMainResourceDataLoad was not called.  Removed function and test.
1979
1980         * DumpRenderTree/TestRunner.cpp:
1981         (setDeferMainResourceDataLoadCallback): Removed setDeferMainResourceDataLoad.
1982         * DumpRenderTree/TestRunner.h:
1983         (TestRunner::deferMainResourceDataLoad): Ditto.
1984         (TestRunner::setDeferMainResourceDataLoad): Ditto.
1985         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Ditto.
1986
1987 2016-08-23  Anders Carlsson  <andersca@apple.com>
1988
1989         Add enum traits and use them in the IPC::Decoder
1990         https://bugs.webkit.org/show_bug.cgi?id=161103
1991
1992         Reviewed by Sam Weinig.
1993
1994         Add API test.
1995
1996         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1997         * TestWebKitAPI/Tests/WTF/EnumTraits.cpp: Added.
1998         (TestWebKitAPI::TEST):
1999
2000 2016-08-24  Filip Pizlo  <fpizlo@apple.com>
2001
2002         Unreviewed, roll out r204901, r204897, r204866, r204856, r204854.
2003
2004         * DumpRenderTree/TestRunner.cpp:
2005         * DumpRenderTree/mac/DumpRenderTree.mm:
2006         (DumpRenderTreeMain):
2007         * Scripts/run-jsc-stress-tests:
2008         * TestWebKitAPI/Tests/WTF/Vector.cpp:
2009         (TestWebKitAPI::TEST):
2010
2011 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
2012
2013         Try to fix Production builds.
2014         
2015         PRODUCTION_FRAMEWORKS_DIR was undefined here.
2016
2017         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2018
2019 2016-08-24  Dan Bernstein  <mitz@apple.com>
2020
2021         Add a convenience function for creating a WKFrameHandleRef from a WKFrameRef without going through WKFrameInfoRef
2022         https://bugs.webkit.org/show_bug.cgi?id=161152
2023
2024         Reviewed by Anders Carlsson.
2025
2026         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2027         * TestWebKitAPI/Tests/WebKit2/FrameHandle.cpp: Added.
2028         (TestWebKitAPI::didFinishLoadForFrame):
2029         (TestWebKitAPI::TEST):
2030
2031 2016-08-24  Nan Wang  <n_wang@apple.com>
2032
2033         AX: Add test for line text marker range on iOS
2034         https://bugs.webkit.org/show_bug.cgi?id=161108
2035         <rdar://problem/27976405>
2036
2037         Reviewed by Chris Fleizach.
2038
2039         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2040         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2041         (AccessibilityUIElement::textMarkerRangeForElement):
2042         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2043         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
2044         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
2045
2046 2016-08-24  Per Arne Vollan  <pvollan@apple.com>
2047
2048         [Win] Warning fixes.
2049         https://bugs.webkit.org/show_bug.cgi?id=161079
2050
2051         Reviewed by Brent Fulgham.
2052
2053         * MiniBrowser/win/WebDownloadDelegate.cpp:
2054         * MiniBrowser/win/WinMain.cpp:
2055         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2056         (TestWebKitAPI::TEST):
2057
2058 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
2059
2060         Fix Windows DRT build.
2061
2062         * DumpRenderTree/win/TestRunnerWin.cpp:
2063         (TestRunner::mainFrameJSContext):
2064
2065 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
2066
2067         Try to fix Windows build.
2068         
2069         Pass Tools/DumpRenderTree/Bindings as the working directory for the generate_bindings.pl
2070         so that perl finds CodeGeneratorDumpRenderTree.pm.
2071
2072         * DumpRenderTree/CMakeLists.txt:
2073
2074 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
2075
2076         Hook up UIScriptController in DumpRenderTree
2077         https://bugs.webkit.org/show_bug.cgi?id=161064
2078
2079         Reviewed by Sam Weinig.
2080
2081         Add a skeleton implementation of UIScriptController to DumpRenderTree, building for both
2082         Mac and iOS. Currently this is sufficient to test doAsyncTask(), enabling two tests
2083         in fast/harness which test this.
2084
2085         Add a DerivedSources target to DumpRenderTree to invoke DerivedSources.make.
2086
2087         Move related code shared between WTR and DRT into Tools/TestRunnerShared, and cleanse it of
2088         WK2-isms. Fix the makefiles to refer to the new location.
2089
2090         Hook up TestRunner::runUIScript() for DumpRenderTree, which requires keeping track of callbacks
2091         by ID and firing them once they are complete.
2092
2093         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm: Added (copied from WTR).
2094         * DumpRenderTree/CMakeLists.txt:
2095         * DumpRenderTree/DerivedSources.make: Copied from Tools/WebKitTestRunner/DerivedSources.make.
2096         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2097         * DumpRenderTree/TestRunner.cpp:
2098         (runUIScriptCallback):
2099         (TestRunner::staticFunctions):
2100         (TestRunner::cacheTestRunnerCallback):
2101         (TestRunner::callTestRunnerCallback):
2102         (TestRunner::clearTestRunnerCallbacks):
2103         (nextUIScriptCallbackID):
2104         (TestRunner::runUIScript):
2105         (TestRunner::callUIScriptCallback):
2106         (TestRunner::uiScriptDidComplete):
2107         (TestRunner::cleanup):
2108         * DumpRenderTree/TestRunner.h:
2109         * DumpRenderTree/ios/UIScriptControllerIOS.mm: Added.
2110         * DumpRenderTree/mac/Configurations/Base.xcconfig: DerivedSources.make needs WEBCORE_PRIVATE_HEADERS_DIR to be defined.
2111         * DumpRenderTree/mac/DumpRenderTree.mm:
2112         (runTest):
2113         * DumpRenderTree/mac/TestRunnerMac.mm:
2114         (TestRunner::mainFrameJSContext):
2115         * DumpRenderTree/mac/UIScriptControllerMac.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h.
2116         (WTR::UIScriptController::doAsyncTask):
2117         * DumpRenderTree/win/DumpRenderTree.cpp:
2118         * TestRunnerShared/Bindings/JSWrappable.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h.
2119         (WTR::JSWrappable::~JSWrappable):
2120         (WTR::JSValueMakeStringOrNull):
2121         * TestRunnerShared/Bindings/JSWrapper.cpp: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp.
2122         (WTR::JSWrapper::wrap):
2123         (WTR::JSWrapper::unwrap):
2124         (WTR::unwrapObject):
2125         (WTR::JSWrapper::initialize):
2126         (WTR::JSWrapper::finalize):
2127         * TestRunnerShared/Bindings/JSWrapper.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h.
2128         (WTR::toJS):
2129         (WTR::setProperty):
2130         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: Renamed from Tools/WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl.
2131         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptContext.cpp.
2132         * TestRunnerShared/UIScriptContext/UIScriptContext.h: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptContext.h.
2133         (WTR::UIScriptContext::currentParentCallbackIsPendingCompletion):
2134         * TestRunnerShared/UIScriptContext/UIScriptController.cpp: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptController.cpp.
2135         * TestRunnerShared/UIScriptContext/UIScriptController.h: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptController.h.
2136         * WebKitTestRunner/CMakeLists.txt:
2137         * WebKitTestRunner/DerivedSources.make:
2138         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
2139         (WTR::JSWrappable::~JSWrappable): Deleted.
2140         (WTR::JSValueMakeStringOrNull): Deleted.
2141         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
2142         (WTR::JSWrapper::wrap): Deleted.
2143         (WTR::JSWrapper::unwrap): Deleted.
2144         (WTR::unwrapObject): Deleted.
2145         (WTR::JSWrapper::initialize): Deleted.
2146         (WTR::JSWrapper::finalize): Deleted.
2147         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h:
2148         (WTR::toJS): Deleted.
2149         (WTR::setProperty): Deleted.
2150         * WebKitTestRunner/TestInvocation.cpp:
2151         (WTR::TestInvocation::runUISideScript):
2152         (WTR::TestInvocation::uiScriptDidComplete):
2153         * WebKitTestRunner/TestInvocation.h:
2154         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp: Moved
2155         * WebKitTestRunner/UIScriptContext/UIScriptContext.h: Moved
2156         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp: Moved
2157         * WebKitTestRunner/UIScriptContext/UIScriptController.h: Moved
2158         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2159         * WebKitTestRunner/config.h:
2160         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2161         (WTR::UIScriptController::contentVisibleRect):
2162
2163 2016-08-23  Saam Barati  <sbarati@apple.com>
2164
2165         JSC should have a "microbenchmarks" directory instead of "regress" directory
2166         https://bugs.webkit.org/show_bug.cgi?id=161096
2167
2168         Rubber stamped by Mark Lam.
2169
2170         This patch moves LayoutTests/js/regress/script-tests to the JSTests/microbenchmarks
2171         directory and removes all the related html and txt files. I did this because
2172         that directory was only there for microbenchmarks, and not for "regression"
2173         tests. I also changed the various scripts to point to it.
2174
2175         * Scripts/run-javascriptcore-tests:
2176         (runJSCStressTests):
2177         * Scripts/run-jsc-benchmarks:
2178
2179 2016-08-23  Alex Christensen  <achristensen@webkit.org>
2180
2181         Fix EFL build.
2182
2183         * TestWebKitAPI/CMakeLists.txt:
2184         Include new directory.
2185
2186 2016-08-22  Filip Pizlo  <fpizlo@apple.com>
2187
2188         Butterflies should be allocated in Auxiliary MarkedSpace instead of CopiedSpace and we should rewrite as much of the GC as needed to make this not a regression
2189         https://bugs.webkit.org/show_bug.cgi?id=160125
2190
2191         Reviewed by Geoffrey Garen.
2192
2193         * DumpRenderTree/TestRunner.cpp: Rewire some #includes.
2194         * Scripts/run-jsc-stress-tests: New test flag!
2195
2196 2016-08-23  Brady Eidson  <beidson@apple.com>
2197
2198         WK2 Gamepad layout test support.
2199         https://bugs.webkit.org/show_bug.cgi?id=134671
2200
2201         Reviewed by Alex Christensen.
2202         
2203         Have the injected bundle expose the MockGamepadProvider to the UI process, which will then 
2204         feed back into the UIGamepadProvider.
2205         
2206         Also, fool NSApplication into treating the most recently created "isKeyWindow" of the test windows
2207         as the actual keyWindow for the test runner, which will allow the view to get gamepad updates.
2208
2209         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2210         
2211         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2212         (WTR::TestRunner::setMockGamepadDetails):
2213         (WTR::TestRunner::setMockGamepadAxisValue):
2214         (WTR::TestRunner::setMockGamepadButtonValue):
2215         
2216         * WebKitTestRunner/PlatformWebView.h:
2217         
2218         * WebKitTestRunner/TestController.cpp:
2219         (WTR::TestController::initialize):
2220         
2221         * WebKitTestRunner/TestInvocation.cpp:
2222         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2223         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Deleted.
2224         
2225         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2226         
2227         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2228         (-[WebKitTestRunnerWindow initWithFrame:]):
2229         (-[WebKitTestRunnerWindow dealloc]):
2230         (WTR::PlatformWebView::keyWindow):
2231         
2232         * WebKitTestRunner/ios/TestControllerIOS.mm:
2233         (WTR::wtr_NSApplication_keyWindow):
2234         (WTR::TestController::platformInitialize):
2235         
2236         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2237         (+[WebKitTestRunnerWindow _WTR_keyWindow]):
2238         (-[WebKitTestRunnerWindow initWithContentRect:styleMask:backing:defer:]):
2239         (-[WebKitTestRunnerWindow dealloc]):
2240         (WTR::PlatformWebView::keyWindow):
2241         
2242         * WebKitTestRunner/mac/TestControllerMac.mm:
2243         (WTR::wtr_NSApplication_keyWindow):
2244         (WTR::TestController::platformInitialize):
2245         * WebKitTestRunner/mac/main.mm:
2246
2247 2016-08-23  Alexey Proskuryakov  <ap@apple.com>
2248
2249         REGRESSION (PHP 5.6): http/tests/misc/bad-charset-alias.html fails
2250         https://bugs.webkit.org/show_bug.cgi?id=161047
2251         rdar://problem/27434307
2252
2253         Reviewed by Lucas Forschler.
2254
2255         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py: Specify a php.ini file.
2256
2257 2016-08-23  Chris Dumez  <cdumez@apple.com>
2258
2259         Unreviewed, rolling out r204243.
2260
2261         Caused some layout test failures
2262
2263         Reverted changeset:
2264
2265         "Write API test to cover crash fix in r204135"
2266         https://bugs.webkit.org/show_bug.cgi?id=160587
2267         http://trac.webkit.org/changeset/204243
2268
2269 2016-08-23  Rawinder Singh  <rawinder.singh-webkit@cisra.canon.com.au>
2270
2271         Order feature option list in FeatureList.pm
2272         https://bugs.webkit.org/show_bug.cgi?id=161074
2273
2274         Reviewed by Michael Catanzaro.
2275
2276         Reorder features in alphabetical order based on command line option. Also, sort variables in alphabetical order.
2277
2278         * Scripts/webkitperl/FeatureList.pm:
2279
2280 2016-08-22  Dewei Zhu  <dewei_zhu@apple.com>
2281
2282         Stop python icon bouncing in the dock while running browser benchmarks.
2283         https://bugs.webkit.org/show_bug.cgi?id=161066
2284
2285         Reviewed by Ryosuke Niwa.
2286
2287         Bouncing python icon may impact browser benchmark results.
2288         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2289         (OSXBrowserDriver.prepare_env):
2290         (OSXBrowserDriver.restore_env):
2291
2292 2016-08-22  Simon Fraser  <simon.fraser@apple.com>
2293
2294         <select> menu on iPad causes shifting of hit-testing areas
2295         https://bugs.webkit.org/show_bug.cgi?id=150079
2296
2297         Reviewed by Tim Horton.
2298
2299         -isAssistingNode (aka the poorly named isEditable) is input into WebPageProxy::computeCustomFixedPositionRect(),
2300         so when it changes we have to update visible rects. We were doing this on focus, but failing
2301         to do it on blur.
2302
2303         Added the ability to test by:
2304         1. Making it possible to initiate an animated scroll in the UI process
2305         2. Adding callbacks for starting and ending interaction with a form control. Sadly
2306         the "ending interaction" for <select> popovers on iPad isn't late enough, since we
2307         have no way currently to know when the dimming view behind the popover animates out,
2308         so for now the test keeps trying to tap a button.
2309
2310         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
2311         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
2312         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
2313         (WTR::UIScriptController::setDidStartFormControlInteractionCallback):
2314         (WTR::UIScriptController::didStartFormControlInteractionCallback):
2315         (WTR::UIScriptController::setDidEndFormControlInteractionCallback):
2316         (WTR::UIScriptController::didEndFormControlInteractionCallback):
2317         (WTR::UIScriptController::scrollToOffset):
2318         (WTR::UIScriptController::platformSetDidStartFormControlInteractionCallback):
2319         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback):
2320         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
2321         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2322         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2323         (-[TestRunnerWKWebView dealloc]):
2324         (-[TestRunnerWKWebView didStartFormControlInteraction]):
2325         (-[TestRunnerWKWebView didEndFormControlInteraction]):
2326         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2327         (WTR::contentOffsetBoundedInValidRange):
2328         (WTR::UIScriptController::scrollToOffset):
2329         (WTR::UIScriptController::platformSetDidStartFormControlInteractionCallback):
2330         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback):
2331
2332 2016-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2333
2334         [EFL][GTK] Script process-linux-coredump is not needed, switch back to use the kernel core dumper instead.
2335         https://bugs.webkit.org/show_bug.cgi?id=160927
2336
2337         Reviewed by Daniel Bates.
2338
2339         * Scripts/process-linux-coredump: Removed.
2340         * Scripts/webkitpy/port/efl.py:
2341         (EflPort._get_crash_log):
2342         * Scripts/webkitpy/port/gtk.py:
2343         (GtkPort._get_crash_log):
2344         * Scripts/webkitpy/port/linux_get_crash_log.py:
2345         (GDBCrashLogGenerator.__init__):
2346         (GDBCrashLogGenerator.generate_crash_log):
2347         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
2348         (GDBCrashLogGeneratorTest.test_generate_crash_log):
2349
2350 2016-08-22  Jonathan Bedard  <jbedard@apple.com>
2351
2352         check-webkit-style does not work with Lambda functions in C++
2353         https://bugs.webkit.org/show_bug.cgi?id=160910
2354
2355         Reviewed by Darin Adler.
2356
2357         This change eliminates false positives on correctly styled lambda functions and includes a few basic checks on capture list.
2358
2359         * Scripts/webkitpy/style/checkers/cpp.py:
2360         (regex_for_lambda_functions): Added function which checks if a string is the start of a lambda function.
2361         (check_for_non_standard_constructs): Added lambda function check.
2362         (check_spacing_for_function_call): Added lambda function check.
2363         (check_braces): Added lambda function check.
2364         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2365         (CppStyleTest.test_lambda_functions): Added test function for lambda function style checks.
2366
2367 2016-08-21  Alex Christensen  <achristensen@webkit.org>
2368
2369         URLParser should parse IPv4 addresses
2370         https://bugs.webkit.org/show_bug.cgi?id=161023
2371
2372         Reviewed by Darin Adler.
2373
2374         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2375         (TestWebKitAPI::TEST_F):
2376         (TestWebKitAPI::checkURLDifferences):
2377         We are already getting differences between the old URL::parse and the new URLParser.
2378         (TestWebKitAPI::shouldFail):
2379
2380 2016-08-21  Daniel Bates  <dabates@apple.com>
2381
2382         prepare-ChangeLog lists unmodified functions as modified and marks functions with few changes as deleted
2383         https://bugs.webkit.org/show_bug.cgi?id=148437
2384
2385         Reviewed by Dan Bernstein.
2386
2387         * Scripts/prepare-ChangeLog:
2388         (diffCommand): When using a Subversion checkout, generate a unified diff without any context lines.
2389         This matches our behavior when using a Git checkout. The function overlap logic in generateFunctionListsByRanges()
2390         assumes that its line ranges were from a unified diff without any context lines.
2391         (extractLineRangeAfterChange): A deleted line should be represented with a ("begin line number", "end line number") = ("new starting line number", "new starting line number").
2392         (extractLineRangeBeforeChange): An added line should be represented with a ("begin line number", "end line number") = ("original starting line number", "original starting line number").
2393         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl: Update expected results
2394         based on changes to extractLineRangeAfterChange() and extractLineRangeBeforeChange().
2395         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl: Added.
2396         (discardOutput): Convenience function invokes the specified function redirecting standard output and standard error
2397         to /dev/null for the duration of the function call.
2398
2399 2016-08-20  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
2400
2401         [EFL] Remove unnecessary a patch to mute ecore warnings
2402         https://bugs.webkit.org/show_bug.cgi?id=160997
2403
2404         Reviewed by Darin Adler.
2405
2406         There is no warning messages during the layout test and perf test
2407         after bumping efl version from 1.17 to 1.18. Remove it.
2408
2409         * efl/patches/ecore_remove_warnings.patch: Removed.
2410
2411 2016-08-20  Simon Fraser  <simon.fraser@apple.com>
2412
2413         REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
2414         https://bugs.webkit.org/show_bug.cgi?id=160985
2415
2416         Re-land r204672, but don't check the result of 'xcrun simctl shutdown', because
2417         device shutdown seems to happen as result of killing Simulator.apps, and we're racing
2418         with that.
2419
2420         * Scripts/webkitpy/layout_tests/views/printing.py:
2421         (Printer.print_config):
2422         * Scripts/webkitpy/port/base.py:
2423         (Port.driver_cmd_line_for_logging):
2424         (Port.driver_cmd_line): Deleted.
2425         * Scripts/webkitpy/port/driver.py:
2426         (IOSSimulatorDriver.cmd_line):
2427         * Scripts/webkitpy/port/ios.py:
2428         (IOSSimulatorPort.__init__):
2429         (IOSSimulatorPort.driver_cmd_line_for_logging):
2430         (IOSSimulatorPort._create_simulators):
2431         (IOSSimulatorPort.setup_test_run):
2432         (IOSSimulatorPort._quit_ios_simulator):
2433         (IOSSimulatorPort.clean_up_test_run):
2434         (IOSSimulatorPort._create_device):
2435         (IOSSimulatorPort):
2436         (IOSSimulatorPort._remove_device):
2437         (IOSSimulatorPort._testing_device):
2438         (IOSSimulatorPort.device_id_for_worker_number):
2439         (IOSSimulatorPort._set_device_class): Deleted.
2440         (IOSSimulatorPort.testing_device): Deleted.
2441         * Scripts/webkitpy/port/port_testcase.py:
2442         (PortTestCase.test_driver_cmd_line):
2443         * Scripts/webkitpy/xcode/simulator.py:
2444         (Device.shutdown):
2445         (Device):
2446         (Device.delete):
2447         (Device.reset):
2448         (Simulator):
2449         (Simulator.create_device):
2450         (Simulator.remove_device):
2451         (Simulator.device_number):
2452         (Simulator.device_state_description):
2453         (Simulator.wait_until_device_is_in_state):
2454
2455 2016-08-19  Ryan Haddad  <ryanhaddad@apple.com>
2456
2457         Unreviewed, rolling out r204659.
2458
2459         This change appears to have caused ios-simulator LayoutTests
2460         to fail when shutting down the simulator
2461
2462         Reverted changeset:
2463
2464         "REGRESSION (r204477): Running LayoutTests on ios-simulator
2465         became ~15 minutes slower"
2466         https://bugs.webkit.org/show_bug.cgi?id=160985
2467         http://trac.webkit.org/changeset/204659
2468
2469 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
2470
2471         Build fix for non-USE_SIM_SERVICE_CONTEXT builds
2472         * LayoutTestRelay/LayoutTestRelay/main.m: (main):
2473
2474 2016-08-18  Simon Fraser  <simon.fraser@apple.com>
2475
2476         REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
2477         https://bugs.webkit.org/show_bug.cgi?id=160985
2478
2479         Reviewed by Alexey Proskuryakov.
2480         
2481         r204477 removed @memoized on a couple of ios.py functions, causing them to instantiate
2482         a Simulator() on every call, which causes 'xcrun simctl list' to run. The functions
2483         must not be @memoized, because their return value depends on the value of simulator_device_type().
2484         
2485         Fix by adding some global state in simulator.py that tracks the created devices 
2486         in a worker number -> Device dictionary. Explicitly create devices in _create_simulators(),
2487         and delete them in clean_up_test_run().
2488         
2489         Also explicitly called 'xcrun simctl shutdown' to shut down devices, since it seems
2490         that killing the Simulator apps isn't enough.
2491         
2492         Simulator tracks the devices in a global dictionary, since state needs to persist
2493         across different instances of IOSSimulatorPort.
2494         
2495         Annoyingly, the "Command line:" dumping tried to access a device before we'd done
2496         any setup. Rather than implicitly creating a device here (which the old code did),
2497         override the more clearly named driver_cmd_line_for_logging() in IOSSimulatorPort
2498         and set flag to say that device_id_for_worker_number() doesn't need to return a real
2499         device id.
2500
2501         * Scripts/webkitpy/layout_tests/views/printing.py:
2502         (print_options):
2503         (Printer.print_config):
2504         * Scripts/webkitpy/port/base.py:
2505         (Port.driver_cmd_line_for_logging):
2506         (Port.driver_cmd_line): Deleted.
2507         * Scripts/webkitpy/port/driver.py:
2508         (IOSSimulatorDriver.cmd_line):
2509         * Scripts/webkitpy/port/ios.py:
2510         (IOSSimulatorPort.__init__):
2511         (IOSSimulatorPort.driver_cmd_line_for_logging):
2512         (IOSSimulatorPort._create_simulators):
2513         (IOSSimulatorPort.setup_test_run):
2514         (IOSSimulatorPort.clean_up_test_run):
2515         (IOSSimulatorPort._create_device):
2516         (IOSSimulatorPort):
2517         (IOSSimulatorPort._remove_device):
2518         (IOSSimulatorPort._testing_device):
2519         (IOSSimulatorPort.device_id_for_worker_number):
2520         (IOSSimulatorPort._set_device_class): Deleted.
2521         (IOSSimulatorPort.testing_device): Deleted.
2522         * Scripts/webkitpy/port/port_testcase.py:
2523         (PortTestCase.test_driver_cmd_line):
2524         * Scripts/webkitpy/xcode/simulator.py:
2525         (Device.shutdown):
2526         (Device.delete):
2527         (Device.reset):
2528         (Simulator.create_device):
2529         (Simulator.remove_device):
2530         (Simulator.device_number):
2531         (Simulator.device_state_description):
2532         (Simulator.wait_until_device_is_in_state):
2533
2534 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
2535
2536         Adopt SimServiceContext in LayoutTestRelay
2537         https://bugs.webkit.org/show_bug.cgi?id=161000
2538         <rdar://problem/25765594>
2539
2540         Reviewed by Daniel Bates.
2541
2542         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
2543         * LayoutTestRelay/LayoutTestRelay/main.m:
2544
2545 2016-08-19  Lucas Forschler  <lforschler@apple.com>
2546
2547         Remove Yosemite Leaks bot after http://trac.webkit.org/projects/webkit/changeset/204629
2548
2549         Reviewed by Kocsen Chung.
2550
2551         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2552         (WebKitBuildbot):
2553
2554 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
2555
2556         Partial revert of r203811 - this key is not needed.
2557
2558         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: (-[LTRelayController installApp]):
2559
2560 2016-08-19  Daniel Bates  <dabates@apple.com>
2561
2562         Another attempt to fix the iOS 9.3 build
2563
2564         Define WK_EMPTY_, WK_NOT_, and WK_NOT_YES.
2565
2566         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2567         * WebKitTestRunner/Configurations/Base.xcconfig:
2568
2569 2016-08-19  Lucas Forschler  <lforschler@apple.com>
2570
2571         Remove Yosemite Leaks bot from config.json
2572         
2573         Reviewed by Alexey Proskuryakov.
2574
2575         * BuildSlaveSupport/build.webkit.org-config/config.json:
2576
2577 2016-08-18  Dan Bernstein  <mitz@apple.com>
2578
2579         [Cocoa] API::Number needs to be wrapped by an NSNumber
2580         https://bugs.webkit.org/show_bug.cgi?id=160977
2581         <rdar://problem/27877735>
2582
2583         Reviewed by Anders Carlsson.
2584
2585         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2586         * TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm: Added.
2587         (TestWebKitAPI::TEST):
2588
2589 2016-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
2590
2591         [Cocoa] Migrate off of deprecated CoreGraphics API CGContextSelectFont() and CGContextShowTextAtPoint()
2592         https://bugs.webkit.org/show_bug.cgi?id=160895
2593
2594         Reviewed by Dean Jackson.
2595
2596         Link to the existing CoreText framework.
2597
2598         * DumpRenderTree/PlatformWin.cmake:
2599         * TestWebKitAPI/PlatformWin.cmake:
2600
2601 2016-08-17  Brent Fulgham  <bfulgham@apple.com>
2602
2603         [Win] Remove old libraries from build inputs
2604         https://bugs.webkit.org/show_bug.cgi?id=160949
2605
2606         Reviewed by Dean Jackson.
2607
2608         Modify the download script to remove the old 'icuuc.lib' and
2609         'icuin.lib' files for Windows builds.
2610
2611         * Scripts/update-webkit-auxiliary-libs:
2612
2613 2016-08-17  Jonathan Bedard  <jbedard@apple.com>
2614
2615         Extra logging for crash reason
2616         https://bugs.webkit.org/show_bug.cgi?id=160943
2617
2618         Reviewed by Alexey Proskuryakov.
2619
2620         A number of tests have been erroneously marked as crashed, this should help diagnose these false crashes.
2621
2622         * Scripts/webkitpy/port/server_process.py:
2623         (ServerProcess.write): Add extra logging to determine why a process has been marked as crashed.
2624         (ServerProcess._wait_for_data_and_update_buffers_using_select): Ditto.
2625         (ServerProcess.has_crashed): Ditto.
2626
2627 2016-08-17  Dan Bernstein  <mitz@apple.com>
2628
2629         [Cocoa] -[NSString isEqualToString:] returns NO for any WKNSString argument
2630         https://bugs.webkit.org/show_bug.cgi?id=160938
2631         <rdar://problem/27876652>
2632
2633         Reviewed by Anders Carlsson.
2634
2635         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2636         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm: Added.
2637         (TestWebKitAPI::TEST):
2638
2639 2016-08-17  Chris Fleizach  <cfleizach@apple.com>
2640
2641         AX: Support abbreviations in iOS
2642         https://bugs.webkit.org/show_bug.cgi?id=160907
2643
2644         Reviewed by Joanmarie Diggs.
2645
2646         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2647         (AccessibilityUIElement::stringAttributeValue):
2648         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2649         (WTR::AccessibilityUIElement::stringAttributeValue):
2650
2651 2016-08-17  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
2652
2653         [EFL] Bump efl version from 1.17 to 1.18
2654         https://bugs.webkit.org/show_bug.cgi?id=160899
2655
2656         Reviewed by Antonio Gomes.
2657
2658         To use efl-1.18, EFL port needs to update install dependencies as well.
2659
2660         * efl/install-dependencies:
2661         * efl/jhbuild.modules:
2662
2663 2016-08-17  Per Arne Vollan  <pvollan@apple.com>
2664
2665         [Win] Add tests for linked fonts.
2666         https://bugs.webkit.org/show_bug.cgi?id=160898
2667
2668         Reviewed by Brent Fulgham.
2669
2670         Add tests for https://trac.webkit.org/changeset/204502.
2671
2672         * TestWebKitAPI/PlatformWin.cmake:
2673         * TestWebKitAPI/Tests/WebCore/win/LinkedFonts.cpp: Added.
2674         (TestWebKitAPI::TEST):
2675
2676 2016-08-16  Daniel Bates  <dabates@apple.com>
2677
2678         prepare-ChangeLog: Extract logic from generateFunctionLists() into a function that takes a delegate object
2679         https://bugs.webkit.org/show_bug.cgi?id=160924
2680
2681         Reviewed by Stephanie Lewis.
2682
2683         Towards adding unit tests for generateFunctionLists() we move its logic into actuallyGenerateFunctionLists()
2684         and have actuallyGenerateFunctionLists() take a delegate object to use to query the file system and SCM.
2685         We modify generateFunctionLists() to call actuallyGenerateFunctionLists(). This will make is possible to
2686         test the generate function list machinery without requiring a SCM checkout by substituting a delegate
2687         object that mocks out the file system and SCM operations.
2688
2689         * Scripts/VCSUtils.pm:
2690         (parseDiffStartLine): Parses an SVN or Git start line and returns the path to the target file.
2691         * Scripts/prepare-ChangeLog:
2692         (generateFunctionLists): Move functionality to actually generate the function lists to actuallyGenerateFunctionLists(),
2693         abstracting the logic to query the file system and SCM into functions on a delegate object that
2694         we pass to it.
2695         (actuallyGenerateFunctionLists): Extracted from generateFunctionLists().
2696         (diffHeaderFormat): Deleted.
2697
2698 2016-08-16  Alex Christensen  <achristensen@webkit.org>
2699
2700         URLParser should parse URLs without credentials
2701         https://bugs.webkit.org/show_bug.cgi?id=160913
2702
2703         Reviewed by Brady Eidson.
2704
2705         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2706         (TestWebKitAPI::s):
2707         (TestWebKitAPI::checkURL):
2708         (TestWebKitAPI::TEST_F):
2709
2710 2016-08-16  Anders Carlsson  <andersca@apple.com>
2711
2712         Add WTF::ScopeExit
2713         https://bugs.webkit.org/show_bug.cgi?id=160908
2714
2715         Reviewed by Geoffrey Garen.
2716
2717         * TestWebKitAPI/CMakeLists.txt:
2718         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2719         * TestWebKitAPI/Tests/WTF/Scope.cpp: Added.
2720         (TestWebKitAPI::TEST):
2721
2722 2016-08-16  Aakash Jain  <aakash_jain@apple.com>
2723
2724         EWS logs file are rotated too quickly
2725         https://bugs.webkit.org/show_bug.cgi?id=160724
2726
2727         Reviewed by Daniel Bates.
2728
2729         Currently we are rotating the log file after 10 iterations of queue. If the queue
2730         doesn't have any pending patches, these iterations result in very small amount of 
2731         logs (1 KB log file). Even if the queue process some patches, logs are few KBs.
2732         This results in a lot of log files in a day. This patch ensures that we rotate the
2733         log file when its file size is greater than or equal to 100 KB.
2734
2735         * EWSTools/start-queue-mac.sh: Added check for file size before rotating log file.
2736
2737 2016-08-16  Daniel Bates  <dabates@apple.com>
2738
2739         WKSI static library should be named by major iOS revision, not individual updates
2740         https://bugs.webkit.org/show_bug.cgi?id=160727
2741         <rdar://problem/22274848>
2742
2743         Reviewed by Alexey Proskuryakov.
2744
2745         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2746         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2747         * Scripts/copy-webkitlibraries-to-product-directory:
2748         * WebKitTestRunner/Configurations/Base.xcconfig:
2749         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2750
2751 2016-08-16  Simon Fraser  <simon.fraser@apple.com>
2752
2753         Make it possible to test iOS select elements, and add iPhone and iPad tests for them
2754         https://bugs.webkit.org/show_bug.cgi?id=160909
2755
2756         Reviewed by Enrica Casucci.
2757         
2758         Add functions to UIScriptController to dismiss the form accessory view for iOS,
2759         and to programmatically pick a row from a <select> picker.
2760
2761         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
2762         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
2763         (WTR::UIScriptController::dismissFormAccessoryView):
2764         (WTR::UIScriptController::selectFormAccessoryPickerRow):
2765         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
2766         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2767         (WTR::UIScriptController::dismissFormAccessoryView):
2768         (WTR::UIScriptController::selectFormAccessoryPickerRow):
2769
2770 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
2771
2772         [iOS] Add iPad viewport and form tests, and revert the iPad-testing part of r202132
2773         https://bugs.webkit.org/show_bug.cgi?id=160878
2774
2775         Reviewed by Tim Horton.
2776         
2777         Remove testing-specific "forceIPadStyleZoomOnInputFocus" behavior added in r202132
2778         now that we have the ability to run tests in the iPad simulator.
2779
2780         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
2781         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
2782         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
2783         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
2784         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
2785         * WebKitTestRunner/ios/TestControllerIOS.mm:
2786         (WTR::TestController::platformResetStateToConsistentValues): Deleted.
2787         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2788         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
2789         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
2790
2791 2016-08-15  Anders Carlsson  <andersca@apple.com>
2792
2793         Add an address-of operator to RetainPtr
2794         https://bugs.webkit.org/show_bug.cgi?id=160879
2795
2796         Reviewed by Tim Horton.
2797
2798         Test HashMap and HashSet with an object whose operator& is deleted.
2799
2800         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2801         Sort the Xcode project.
2802
2803         * TestWebKitAPI/Tests/WTF/DeletedAddressOfOperator.h: Added.
2804         (DeletedAddressOfOperator::DeletedAddressOfOperator):
2805         (DeletedAddressOfOperator::value):
2806         (DeletedAddressOfOperator::operator==):
2807         (WTF::HashTraits<DeletedAddressOfOperator>::constructDeletedValue):
2808         (WTF::HashTraits<DeletedAddressOfOperator>::isDeletedValue):
2809         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::hash):
2810         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::equal):
2811         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2812         (TestWebKitAPI::TEST):
2813         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2814         (TestWebKitAPI::TEST):
2815
2816 2016-08-16  Jonathan Bedard  <jbedard@apple.com>
2817
2818         False crashes in fast/text/emoji-gender-* tests
2819         https://bugs.webkit.org/show_bug.cgi?id=160779
2820
2821         Reviewed by Alexey Proskuryakov.
2822
2823         Fix from <rdar://problem/27786762>, where timed out tests falsely report as crashed.
2824
2825         * Scripts/webkitpy/port/driver.py:
2826         (Driver._check_for_driver_crash_or_unresponsiveness): Change call to ‘write’ to disable crash flag.
2827         * Scripts/webkitpy/port/driver_unittest.py: Added 3 variable to test version of ‘write.’
2828         * Scripts/webkitpy/port/server_process.py:
2829         (ServerProcess.write): Allow caller to disable crash flag on exception.
2830
2831 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
2832
2833         webkitpy error in TestRunResults.merge()
2834         https://bugs.webkit.org/show_bug.cgi?id=160882
2835
2836         Reviewed by Daniel Bates.
2837         
2838         The argument to TestRunResults.merge() can be None if there are no device-specifc
2839         initial results or retry results in Manager.run(), so just return early in that case.
2840
2841         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2842         (TestRunResults.merge):
2843
2844 2016-08-15  Sam Weinig  <sam@webkit.org>
2845
2846         Speed up compile times by not including wtf/Variant.h so much
2847         https://bugs.webkit.org/show_bug.cgi?id=160847
2848
2849         Reviewed by Alex Christensen and Saam Barati.
2850
2851         * TestWebKitAPI/Tests/WTF/Variant.cpp:
2852         (TestWebKitAPI::TEST):
2853         Explicitly use std::experimental::variant.
2854
2855 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
2856
2857         Allow a port to run tests with a custom device setup
2858         https://bugs.webkit.org/show_bug.cgi?id=160833
2859
2860         Reviewed by Daniel Bates.
2861
2862         These changes allow the IOSSimulator port to run tests in iPad mode.
2863
2864         This is made possible by allowing a platform to define CUSTOM_DEVICE_CLASSES,
2865         in this case 'ipad'. When specified, any test in a directory with a suffix that matches
2866         a custom device will be collected into a set, and run in that device's environment after
2867         the other tests have run.
2868
2869         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2870         (Manager._custom_device_for_test): If the test contains a directory matching a
2871         custom device suffix, return that custom device.
2872         (Manager._set_up_run): Push the custom device class, if any, into options so
2873         that the Worker can get to it.
2874         (Manager.run): Go through the list of tests, and break it down into device-generic
2875         tests, and tests for each device class. _run_test_subset is then called for
2876         each collection of tests, and the results merged.
2877         (Manager._run_test_subset): Some lines unwrapped.
2878         (Manager._end_test_run):
2879         (Manager._run_tests):
2880         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2881         (SingleTestRunner.__init__): Unwrapped a line.
2882         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2883         (TestRunResults.merge): Add this function to merge TestRunResults
2884         * Scripts/webkitpy/layout_tests/views/printing.py:
2885         (Printer.print_workers_and_shards): Print the custom device, if any.
2886         * Scripts/webkitpy/port/base.py:
2887         (Port): Base port has empty array of custom devices.
2888         (Port.setup_test_run): Add device_class argument.
2889         * Scripts/webkitpy/port/driver.py:
2890         (DriverInput.__repr__):
2891         (Driver.check_driver.implementation):
2892         * Scripts/webkitpy/port/efl.py:
2893         (EflPort.setup_test_run):
2894         * Scripts/webkitpy/port/gtk.py:
2895         (GtkPort.setup_test_run):
2896         * Scripts/webkitpy/port/ios.py:
2897         (IOSSimulatorPort): Add CUSTOM_DEVICE_CLASSES for ipad.
2898         (IOSSimulatorPort.__init__):
2899         (IOSSimulatorPort.simulator_device_type): Use a device name from the DEVICE_CLASS_MAP
2900         based on the custom device class.
2901         (IOSSimulatorPort._set_device_class):
2902         (IOSSimulatorPort._create_simulators): Factor some code into this function.
2903         (IOSSimulatorPort.setup_test_run):
2904         (IOSSimulatorPort.testing_device):
2905         (IOSSimulatorPort.reset_preferences): This used to create the simulator apps, but that
2906         seemed wrong for this function. That was moved to setup_test_run().
2907         (IOSSimulatorPort.check_sys_deps): This function used to create testing devices,
2908         but this happened too early, before we knew which kind of devices to create. Devices
2909         are now created in setup_test_run().
2910         * Scripts/webkitpy/port/win.py:
2911         (WinPort.setup_test_run):
2912
2913 2016-08-15  Daniel Bates  <dabates@apple.com>
2914
2915         Cannot build WebKit for iOS device using Xcode 7.3/iOS 9.3 public SDK due to missing
2916         private frameworks and libraries
2917         https://bugs.webkit.org/show_bug.cgi?id=155931
2918         <rdar://problem/25807989>
2919
2920         Reviewed by Dan Bernstein.
2921
2922         Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
2923         where X is the major version of the active iOS SDK.
2924
2925         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2926         * WebKitTestRunner/Configurations/Base.xcconfig:
2927
2928 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
2929
2930         Add a setting and preferences to enable visual viewport mode
2931         https://bugs.webkit.org/show_bug.cgi?id=160843
2932
2933         Reviewed by Sam Weinig.
2934         
2935         Pref and a menu item to toggle visualViewportEnabled for WebKits 1 and 2.
2936
2937         * MiniBrowser/mac/SettingsController.h:
2938         * MiniBrowser/mac/SettingsController.m:
2939         (-[SettingsController _populateMenu]):
2940         (-[SettingsController validateMenuItem:]):
2941         (-[SettingsController visualViewportEnabled]):
2942         (-[SettingsController toggleVisualViewportEnabled:]):
2943         * MiniBrowser/mac/WK1BrowserWindowController.m:
2944         (-[WK1BrowserWindowController didChangeSettings]):
2945         * MiniBrowser/mac/WK2BrowserWindowController.m:
2946         (-[WK2BrowserWindowController didChangeSettings]):
2947
2948 2016-08-15  Konstantin Tokarev  <annulen@yandex.ru>
2949
2950         Allow using make-dist with non-GTK ports
2951         https://bugs.webkit.org/show_bug.cgi?id=160842
2952
2953         Reviewed by Michael Catanzaro.
2954
2955         This patch adds support for setting base name of tarball and argument
2956         passed to cmake's -DPORT= via command line arguments.
2957
2958         * gtk/make-dist.py:
2959         (Distcheck.configure):
2960         (Distcheck.check):
2961         (get_tarball_root_and_output_filename_from_arguments):
2962
2963 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2964
2965         [GTK] Install script lacks gstreamer related dependencies
2966         https://bugs.webkit.org/show_bug.cgi?id=160814
2967
2968         Reviewed by Carlos Garcia Campos.
2969
2970         * gtk/install-dependencies: Fedora case had already listed this dependencies,
2971         but both Arch and Debian/Ubuntu were missing them.
2972
2973 2016-08-13  Konstantin Tokarev  <annulen@yandex.ru>
2974
2975         make-dist.py should not allow unknown rules in manifest
2976         https://bugs.webkit.org/show_bug.cgi?id=160841
2977
2978         Reviewed by Carlos Garcia Campos.
2979
2980         * gtk/make-dist.py:
2981         (Manifest.process_line):
2982
2983 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2984
2985         [EFL][GTK] Install script not working on Debian 9 (testing) and Ubuntu 16.10
2986         https://bugs.webkit.org/show_bug.cgi?id=160809
2987
2988         Reviewed by Carlos Garcia Campos.
2989
2990         * efl/install-dependencies: Factorize the previous logic for handling the php5/7
2991         case, and use it also for the new package names of libpng and libgeoclue.
2992         * gtk/install-dependencies: Ditto.
2993
2994 2016-08-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2995
2996         Skip to check directories existence in build-webkit
2997         https://bugs.webkit.org/show_bug.cgi?id=160691
2998
2999         Reviewed by Alex Christensen.
3000
3001         CMake checks if directories are there itself. So CMake ports
3002         don't need to check it in the build-webkit script.
3003
3004         * Scripts/build-webkit:
3005         * Scripts/webkitdirs.pm:
3006         (determineSourceDir):
3007         (isCMakeBuild):
3008
3009 2016-08-12  Alex Christensen  <achristensen@webkit.org>
3010
3011         Make URLParser work with URLs missing URL parts
3012         https://bugs.webkit.org/show_bug.cgi?id=160824
3013
3014         Reviewed by Brady Eidson.
3015
3016         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3017         (TestWebKitAPI::s):
3018         (TestWebKitAPI::checkURL):
3019         (TestWebKitAPI::TEST_F):
3020         (TestWebKitAPI::eq): Deleted.
3021
3022 2016-08-12  John Wilander  <wilander@apple.com>
3023
3024         Add HashCountedSet API tests to TestWTFLibrary target
3025         https://bugs.webkit.org/show_bug.cgi?id=160815
3026
3027         Reviewed by Alex Christensen.
3028
3029         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3030             Added HashCountedSet.cpp and sorted the file reference section
3031             according to UNIX sort.
3032
3033 2016-08-12  Ryosuke Niwa  <rniwa@webkit.org>
3034
3035         run-benchmark should run JetStream 1.1 instead of 1.0.1
3036         https://bugs.webkit.org/show_bug.cgi?id=160816
3037
3038         Reviewed by Filip Pizlo.
3039
3040         Use the latest JetStream 1.1 in run-benchmark.
3041
3042         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
3043         (BenchmarkBuilder.__exit__):
3044         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Updated to apply against 1.1 directory.
3045         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Updated to use r190897, which is the last
3046         change to JetStream directory.
3047
3048 2016-08-12  Alex Christensen  <achristensen@webkit.org>
3049
3050         Initial URLParser implementation
3051         https://bugs.webkit.org/show_bug.cgi?id=160811
3052
3053         Reviewed by Brady Eidson.
3054
3055         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3056         (TestWebKitAPI::eq):
3057         (TestWebKitAPI::checkURL):
3058         (TestWebKitAPI::TEST_F):
3059
3060 2016-08-12  Brady Eidson  <beidson@apple.com>
3061
3062         Fix the 32-bit Mac build after:
3063         Add WK2 ExperimentalFeature support to MiniBrowser
3064         https://bugs.webkit.org/show_bug.cgi?id=160788
3065
3066         Unreviewed.
3067
3068         Sprinkle "#if WK_API_ENABLED"s liberally.
3069         
3070         * MiniBrowser/mac/AppDelegate.m:
3071         (defaultConfiguration):
3072         * MiniBrowser/mac/SettingsController.m:
3073         (-[SettingsController _populateMenu]):
3074         (-[SettingsController validateMenuItem:]):
3075
3076 2016-08-12  Philippe Normand  <pnormand@igalia.com>
3077
3078         [GStreamer][OWR] Video rendering fixes
3079         https://bugs.webkit.org/show_bug.cgi?id=160764
3080
3081         Reviewed by Xabier Rodriguez-Calvar.
3082
3083         * gtk/jhbuild.modules: Bump to current OpenWebRTC master.
3084
3085 2016-08-12  Per Arne Vollan  <pvollan@apple.com>
3086
3087         Add missing return statement in convertFast function added in r204376.
3088
3089         Unreviewed.
3090
3091         * Scripts/webkitpy/common/system/path.py:
3092         (_CygPath.convertFast):
3093
3094 2016-08-11  Brady Eidson  <beidson@apple.com>
3095
3096         Add WK2 ExperimentalFeature support to MiniBrowser.
3097         https://bugs.webkit.org/show_bug.cgi?id=160788
3098
3099         Reviewed by Alex Christensen.
3100
3101         * MiniBrowser/mac/AppDelegate.h:
3102         * MiniBrowser/mac/AppDelegate.m:
3103         (defaultConfiguration):
3104         (defaultPreferences):
3105         
3106         * MiniBrowser/mac/SettingsController.m:
3107         (-[SettingsController _populateMenu]):
3108         (-[SettingsController validateMenuItem:]):
3109         (-[SettingsController toggleExperimentalFeature:]):
3110
3111 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
3112
3113         Keep EWS logs for longer
3114         https://bugs.webkit.org/show_bug.cgi?id=160776
3115
3116         Reviewed by Daniel Bates.
3117
3118         * EWSTools/start-queue-mac.sh: Keep logs for 30 days instead of 14 days.
3119
3120 2016-08-11  Simon Fraser  <simon.fraser@apple.com>
3121
3122         iOS DRT/WTR project cleanup
3123         https://bugs.webkit.org/show_bug.cgi?id=160778
3124
3125         Reviewed by Tim Horton.
3126
3127         Move TARGETED_DEVICE_FAMILY from the project to an xcconfig file.
3128
3129         Remove AppDelegate.* which were unused.
3130
3131         Exclude ios/Launch.storyboard on more platforms.
3132
3133         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3134         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
3135         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
3136         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3137         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Removed.
3138         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Removed.
3139         (-[AppDelegate application:didFinishLaunchingWithOptions:]): Deleted.
3140
3141 2016-08-11  Alex Christensen  <achristensen@webkit.org>
3142
3143         Fix Yosemite bots' cookie accept policies after r204365.
3144         https://bugs.webkit.org/show_bug.cgi?id=160758
3145
3146         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
3147         (TEST):
3148         This makes the test fully clean up after itself.
3149
3150 2016-08-11  Alex Christensen  <achristensen@webkit.org>
3151
3152         Fix Yosemite bots' cookie accept policies after r204365.
3153         https://bugs.webkit.org/show_bug.cgi?id=160758
3154
3155         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
3156         (TEST):
3157         I didn't restore the cookieAcceptPolicy of the sharedHTTPCookieStorage after changing it with this API test.
3158         On Yosemite, this is changing the cookieAcceptPolicy that DumpRenderTree uses.
3159         On more recent Cocoa platforms, it is only changing the cookieAcceptPolicy that TestWebKitAPI uses, which isn't
3160         causing any problems because there are no other API tests that do anything with cookies.
3161         My solution will be to restore the original cookieAcceptPolicy after running this API test to clean up,
3162         but first I am committing this patch setting the cookieAcceptPolicy to NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain
3163         to reset any bots that have run tests since r204365.  I will commit a followup that sets it to originalCookieAcceptPolicy.
3164
3165 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
3166
3167         EWS should check if the patch is still valid before executing every major step
3168         https://bugs.webkit.org/show_bug.cgi?id=160739
3169         rdar://problem/27768813
3170
3171         Reviewed by Alexey Proskuryakov.
3172
3173         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3174         (CommitQueueTask.run): validate method is now executed in base class.
3175         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
3176         (EarlyWarningSystemTask.run): validate method is now executed in base class.
3177         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
3178         (StyleQueueTask.validate): Raise an PatchIsNotValid exception instead of returning False.
3179         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3180         (PatchAnalysisTask._run_command): validate the patch before executing any command. This is to ensure
3181         that we do not waste time on any patch which has become invalid (e.g.: obsolete, r-).
3182         * Scripts/webkitpy/tool/commands/perfalizer.py:
3183         (PerfalizerTask.validate): Added.
3184         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3185         (test_manual_reject_during_processing): Updated test case.
3186
3187 2016-08-11  Alex Christensen  <achristensen@webkit.org>
3188
3189         Add URLParser stub
3190         https://bugs.webkit.org/show_bug.cgi?id=160770
3191
3192         Reviewed by Sam Weinig.
3193
3194         * TestWebKitAPI/PlatformGTK.cmake:
3195         * TestWebKitAPI/PlatformWin.cmake:
3196         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3197         * TestWebKitAPI/Tests/WebCore/URLParser.cpp: Added.
3198         (TestWebKitAPI::TEST_F):
3199
3200 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
3201
3202         [iOS DRT] Allow DRT to be iPad-sized in the iPad simulator
3203         https://bugs.webkit.org/show_bug.cgi?id=160761
3204
3205         Reviewed by Tim Horton.
3206
3207         Give iOS DRT a Launch storyboard.
3208
3209         Have it use a UIViewController so future forms testing works correctly.
3210
3211         Add TARGETED_DEVICE_FAMILY = "1,2" to the build settings for the .app, so that it
3212         can run in iPad mode.
3213
3214         Remove empty InfoPlist.strings files.
3215
3216         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3217         * DumpRenderTree/ios/Info.plist:
3218         * DumpRenderTree/ios/Launch.storyboard: Added.
3219         * DumpRenderTree/mac/DumpRenderTree.mm:
3220         (createWebViewAndOffscreenWindow):
3221         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3222         * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Removed.
3223         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3224         (WTR::PlatformWebView::PlatformWebView): Drive-by leak fix.
3225
3226 2016-08-11  Per Arne Vollan  <pvollan@apple.com>
3227
3228         [Win] Unable to reliably run tests in parallel
3229         https://bugs.webkit.org/show_bug.cgi?id=140914
3230
3231         Reviewed by Brent Fulgham.
3232
3233         The cygpath utility function can fail badly when running with multiple DumpRenderTree
3234         processes. We can use string replacement to convert the Cygwin path to a Windows path
3235         instead.
3236
3237         * Scripts/webkitpy/common/system/path.py:
3238         (cygpathFast):
3239         * Scripts/webkitpy/port/driver.py:
3240         (Driver._command_from_driver_input):
3241
3242 2016-08-10  Alex Christensen  <achristensen@webkit.org>
3243
3244         Fix crash when changing cookie accept policy after r204327
3245         https://bugs.webkit.org/show_bug.cgi?id=160758
3246
3247         Reviewed by Simon Fraser.
3248
3249         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3250         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm: Added.
3251         (-[CookieAcceptPolicyMessageHandler userContentController:didReceiveScriptMessage:]):
3252         (TEST):
3253         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieMessage.html: Added.
3254
3255 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
3256
3257         [iOS WK2] Have WebKitTestRunnerApp.app use a UIViewController, and fix to avoid the status bar
3258         https://bugs.webkit.org/show_bug.cgi?id=160757
3259
3260         Reviewed by Tim Horton.
3261
3262         When programmatically creating the test UIWindow, make a root UIViewController and parent
3263         the WKWebView in its view. This makes the app more like a normal UIKit application.
3264         
3265         Move the WKWebView down 20px to avoid the status bar.
3266         
3267         Give the UIWindow a gray background so it's obvious where the window and view positioned.
3268
3269         Sorted the project file. Removed the link to UIKit which showed red, and wasn't necessary.
3270         
3271         Remove duplicate references to Launch.storyboard.
3272
3273         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3274         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Add license.
3275         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Add license.
3276         (-[AppDelegate applicationWillResignActive:]): Deleted.
3277         (-[AppDelegate applicationDidEnterBackground:]): Deleted.
3278         (-[AppDelegate applicationWillEnterForeground:]): Deleted.
3279         (-[AppDelegate applicationDidBecomeActive:]): Deleted.
3280         (-[AppDelegate applicationWillTerminate:]): Deleted.
3281         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3282         (WTR::viewRectForWindowRect):
3283         (WTR::PlatformWebView::PlatformWebView):
3284         (WTR::PlatformWebView::setWindowFrame):
3285
3286 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
3287
3288         [iOS WK2] Use the simulated device's screen size, rather than a harcoded size
3289         https://bugs.webkit.org/show_bug.cgi?id=160748
3290
3291         Reviewed by Tim Horton.
3292         
3293         Use the main UIScreen's bounds for the window size if we're using a flexible viewport. This
3294         opens the door for tests using other device sizes.
3295
3296         * WebKitTestRunner/ios/TestControllerIOS.mm:
3297         (WTR::TestController::platformConfigureViewForTest):
3298
3299 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
3300
3301         Sort the feature flags in the FEATURE_DEFINES lines
3302         https://bugs.webkit.org/show_bug.cgi?id=160742
3303
3304         Reviewed by Anders Carlsson.
3305         
3306         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3307
3308 2016-08-09  Simon Fraser  <simon.fraser@apple.com>
3309
3310         Logging and other minor improvements to iOS webkitpy
3311         https://bugs.webkit.org/show_bug.cgi?id=160722
3312
3313         Reviewed by Dan Bates.
3314
3315         Fix --debug-rwt-logging to log all the calls to simctl as well as device state information,
3316         to make it easier to debug launching issues.
3317
3318         Have reset_preferences() reset the device, rather than just nuking the data
3319         directory (which broke some versions of the simulator).
3320
3321         Make the Simulator.app launch in the background with open -g.
3322
3323         Wait for the simulator device to be in a known state in some more places.
3324
3325         * Scripts/webkitpy/port/ios.py:
3326         (IOSSimulatorPort.setup_test_run):
3327         (IOSSimulatorPort._quit_ios_simulator):
3328         (IOSSimulatorPort.clean_up_test_run):
3329         (IOSSimulatorPort.setup_environ_for_server):
3330         (IOSSimulatorPort.reset_preferences):
3331         * Scripts/webkitpy/xcode/simulator.py:
3332         (Device.create):
3333         (Device.delete):
3334         (Device):
3335         (Device.reset):
3336         (Simulator.wait_until_device_is_booted):
3337         (Simulator.wait_until_device_is_in_state):
3338         (Simulator):
3339         (Simulator.delete_device):
3340         (Simulator.reset_device):
3341         (Simulator.lookup_or_create_device):
3342
3343 2016-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3344
3345         [GTK][EFL] ALSA_CARD environment variable is not passed for layout tests.
3346         https://bugs.webkit.org/show_bug.cgi?id=160697
3347
3348         Reviewed by Antonio Gomes.
3349
3350         * Scripts/webkitpy/port/base.py:
3351         (Port.to.setup_environ_for_server): Add ALSA_CARD and sort the Linux
3352         list of environment variables to copy.
3353
3354 2016-08-09  George Ruan  <gruan@apple.com>
3355
3356         Implement functionality of media capture on iOS
3357         https://bugs.webkit.org/show_bug.cgi?id=158945
3358         <rdar://problem/26893343>
3359
3360         Reviewed by Tim Horton.
3361
3362         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Enable Media
3363         Capture feature on iOS.
3364
3365 2016-08-09  Saam Barati  <sbarati@apple.com>
3366
3367         Parser<LexerType>::parseFunctionInfo() has the wrong info about captured vars when a function is not cached.
3368         https://bugs.webkit.org/show_bug.cgi?id=160671
3369         <rdar://problem/27756112>
3370
3371         Reviewed by Mark Lam.
3372
3373         * Scripts/run-jsc-stress-tests:
3374
3375 2016-08-09  Alexey Proskuryakov  <ap@apple.com>
3376
3377         Make directory reading code in iOSSimulatorDevices() more strict
3378         https://bugs.webkit.org/show_bug.cgi?id=160702
3379
3380         Reviewed by Tim Horton.
3381
3382         * Scripts/webkitdirs.pm:
3383         (iOSSimulatorDevices):
3384
3385 2016-08-06  Sam Weinig  <sam@webkit.org>
3386
3387         Replace NodeOrString with std::variant<RefPtr<Node>, String>
3388         https://bugs.webkit.org/show_bug.cgi?id=160638
3389
3390         Reviewed by Anders Carlsson.
3391
3392         * TestWebKitAPI/CMakeLists.txt:
3393         * TestWebKitAPI/Tests/WTF/Variant.cpp:
3394         Add additional tests for the initial state of std::variant and using
3395         makeVisitor for visiting.
3396
3397 2016-08-09  Aakash Jain  <aakash_jain@apple.com>
3398
3399         EWS logging should ensure the logging to file is stopped on queue termination
3400         https://bugs.webkit.org/show_bug.cgi?id=160698
3401         rdar://problem/24464570
3402
3403         Reviewed by Daniel Bates.
3404
3405         * Scripts/webkitpy/tool/bot/queueengine.py:
3406         (QueueEngine._stopping): Stop logging to file on queue termination.
3407         (QueueEngine._begin_logging): Configure the Python logger to log to file.
3408         * Scripts/webkitpy/common/system/logutils.py:
3409         (configure_logger_to_log_to_file): Return the handler so as to enable caller to remove it later.
3410         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
3411         (QueueEngineTest._run_engine): Removed extra newline character to improve log readability.
3412         * Scripts/webkitpy/tool/commands/queues.py:
3413         (AbstractQueue._log_directory): Reverting to os.path.join as we don't have host object.
3414         (AbstractQueue.queue_log_path): Same.
3415         (AbstractQueue.begin_work_queue): Removed logging initialization, it is now being done in QueueEngine.
3416         (AbstractQueue.__init__): Removed host parameter, not required anymore, it was required by logging initialization
3417         which moved to QueueEngine now.
3418         (PatchProcessingQueue.__init__): Same.
3419         (CommitQueue.__init__): Same.
3420         (AbstractReviewQueue.__init__): Same.
3421         (StyleQueue.__init__): Same.
3422         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3423         (TestCommitQueue): Removed host parameter.
3424         (TestCommitQueue.__init__): Same.
3425         (AbstractPatchQueueTest.test_next_patch): Same.
3426         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
3427         (test_commit_queue_failure): Same.
3428         (mock_run_webkit_patch):
3429         (MockCommitQueueTask.results_from_patch_test_run): Same.
3430         (test_rollout_lands): Same.
3431         (test_non_valid_patch): Same.
3432         (test_auto_retry): Same.
3433         (test_style_queue_with_watch_list_exception): Same.
3434         (TestQueue.__init__): Deleted.
3435         (TestReviewQueue.__init__): Deleted.
3436         (TestFeederQueue.__init__): Deleted.
3437
3438 2016-08-09  Konstantin Tokarev  <annulen@yandex.ru>
3439
3440         webkit-gtk tarball fails to build due to missing files
3441         https://bugs.webkit.org/show_bug.cgi?id=160684
3442
3443         Reviewed by Alex Christensen.
3444
3445         * gtk/manifest.txt.in: Added back spi directories.
3446
3447 2016-08-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3448
3449         [GTK] Build the jhbuild with -O2 optimization level by default
3450         https://bugs.webkit.org/show_bug.cgi?id=160544
3451
3452         Reviewed by Michael Catanzaro.
3453
3454         * gtk/jhbuildrc: Pass -O2 when building the JHBuild, as also -g1
3455         which don't increases the required disk space significatively and
3456         provides better debug information than no passing it.
3457
3458 2016-08-09  Csaba Osztrogonác  <ossy@webkit.org>
3459
3460         Allow more --cmakeargs option in build-jsc and build-webkit
3461         https://bugs.webkit.org/show_bug.cgi?id=160340
3462
3463         Reviewed by Michael Catanzaro.
3464
3465         * Scripts/build-jsc:
3466         * Scripts/build-webkit:
3467
3468 2016-08-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3469
3470         Do not check if WebKitLibraries folder exists on EFL and GTK
3471         https://bugs.webkit.org/show_bug.cgi?id=160659
3472
3473         Reviewed by Csaba Osztrogonác.
3474
3475         Though WebKitLibraries is only needed by mac and win ports,
3476         EFL and GTK ports have checked whether it exists.
3477
3478         * Scripts/build-webkit:
3479
3480 2016-08-08  Aakash Jain  <aakash_jain@apple.com>
3481
3482         Some EWS console logs doesn't go to log file
3483         https://bugs.webkit.org/show_bug.cgi?id=160585
3484         rdar://problem/24464570
3485
3486         Reviewed by Daniel Bates.
3487
3488         * Scripts/webkitpy/common/system/logutils.py:
3489         (FileSystemHandler._open): Ensure that we open logfile in append mode in order to avoid
3490         any possible overwriting.
3491         * Scripts/webkitpy/common/system/filesystem.py:
3492         (FileSystem.open_text_file_for_writing): Add should_append parameter to append to file.
3493         * Scripts/webkitpy/common/system/filesystem_mock.py:
3494         (MockFileSystem.open_text_file_for_writing): Same.
3495         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3496         (RealFileSystemTest.test_read_and_write_text_file): Removed unused variable 'hex_equivalent'.
3497         (RealFileSystemTest.test_append_to_text_file): Added new unit test for testing append functionality.
3498         * Scripts/webkitpy/tool/commands/queues.py:
3499         (AbstractQueue.begin_work_queue): Configure the logger for overall webkitpy to log to file.
3500         This will ensure that all the sub-modules inside webkitpy will log to file.
3501
3502 2016-08-08  Simon Fraser  <simon.fraser@apple.com>
3503
3504         Have the iOS platform interit from the Apple platform in webkitpy
3505         https://bugs.webkit.org/show_bug.cgi?id=160672
3506
3507         Reviewed by Dan Bates.
3508         
3509         The IOSSimulatorPort used to inherit from Port, rather than ApplePort.
3510         Fix this, and move duplicated code from IOSSimulatorPort and MacPort into
3511         ApplePort.
3512         
3513         Since WinPort also inherits from ApplePort, it needs to stub out some things
3514         that are unavailable on Windows (leaks, sampling).
3515         
3516         Some SnowLeopard-related code and the associated test were removed.
3517
3518         * Scripts/webkitpy/port/apple.py:
3519         (ApplePort.__init__):
3520         (ApplePort):
3521         (ApplePort._make_leak_detector):
3522         (ApplePort.default_timeout_ms):
3523         (ApplePort.supports_per_test_timeout):
3524         (ApplePort.should_retry_crashes):
3525         (ApplePort._generate_all_test_configurations):
3526         (ApplePort.check_for_leaks):
3527         (ApplePort.print_leaks_summary):
3528         (ApplePort._path_to_webcore_library):
3529         (ApplePort.show_results_html_file):
3530         (ApplePort._merge_crash_logs):
3531         (ApplePort._look_for_all_crash_logs_in_log_dir):
3532         (ApplePort._get_crash_log):
3533         (ApplePort.look_for_new_crash_logs):
3534         (ApplePort.sample_process):
3535         (ApplePort.sample_file_path):
3536         (ApplePort.look_for_new_samples):
3537         (ApplePort._path_to_helper):
3538         (ApplePort.determine_full_port_name): Deleted.
3539         * Scripts/webkitpy/port/ios.py:
3540         (IOSSimulatorPort):
3541         (IOSSimulatorPort.__init__):
3542         (IOSSimulatorPort.default_timeout_ms): Deleted.
3543         (IOSSimulatorPort.supports_per_test_timeout): Deleted.
3544         (IOSSimulatorPort.should_retry_crashes): Deleted.
3545         (IOSSimulatorPort.check_for_leaks): Deleted.
3546         (IOSSimulatorPort.print_leaks_summary): Deleted.
3547         (IOSSimulatorPort._path_to_webcore_library): Deleted.
3548         (IOSSimulatorPort.show_results_html_file): Deleted.
3549         (IOSSimulatorPort.sample_file_path): Deleted.
3550         (IOSSimulatorPort._merge_crash_logs): Deleted.
3551         (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Deleted.
3552         (IOSSimulatorPort.look_for_new_crash_logs): Deleted.
3553         (IOSSimulatorPort.look_for_new_samples): Deleted.
3554         (IOSSimulatorPort.sample_process): Deleted.
3555         (IOSSimulatorPort._path_to_helper): Deleted.
3556         (IOSSimulatorPort.make_command): Deleted.
3557         * Scripts/webkitpy/port/mac.py:
3558         (MacPort.__init__):
3559         (MacPort.make_command):
3560         (MacPort._build_java_test_support):
3561         (MacPort): Deleted.
3562         (MacPort.default_timeout_ms): Deleted.
3563         (MacPort.supports_per_test_timeout): Deleted.
3564         (MacPort.should_retry_crashes): Deleted.
3565         (MacPort.default_child_processes): Deleted.
3566         (MacPort.check_for_leaks): Deleted.
3567         (MacPort.print_leaks_summary): Deleted.
3568         (MacPort._path_to_webcore_library): Deleted.
3569         (MacPort.show_results_html_file): Deleted.
3570         (MacPort.sample_file_path): Deleted.
3571         (MacPort._merge_crash_logs): Deleted.
3572         (MacPort._look_for_all_crash_logs_in_log_dir): Deleted.
3573         (MacPort.look_for_new_crash_logs): Deleted.
3574         (MacPort.look_for_new_samples): Deleted.
3575         (MacPort.sample_process): Deleted.
3576         (MacPort._path_to_helper): Deleted.
3577         * Scripts/webkitpy/port/mac_unittest.py:
3578         (MacTest.test_default_child_processes): Deleted.
3579         * Scripts/webkitpy/port/win.py:
3580         (WinPort.look_for_new_samples):
3581         (WinPort):
3582         (WinPort.sample_process):
3583         (WinPort._make_leak_detector):
3584         (WinPort.check_for_leaks):
3585         (WinPort.print_leaks_summary):
3586         (WinPort._path_to_webcore_library):
3587
3588 2016-08-08  Matt Baker  <mattbaker@apple.com>
3589
3590         Unreviewed: moved myself to the reviewers list.
3591
3592         * Scripts/webkitpy/common/config/contributors.json:
3593
3594 2016-08-08  Chris Dumez  <cdumez@apple.com>
3595
3596         Update API tests in mac/SetDocumentURI.mm after r204247
3597         https://bugs.webkit.org/show_bug.cgi?id=160660
3598
3599         Reviewed by Alex Christensen.
3600
3601         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
3602         (TestWebKitAPI::TEST):
3603
3604 2016-08-08  Jonathan Bedard  <jbedard@apple.com>
3605
3606         run-webkit-tests should trigger a spindump when WebContent process is unresponsive
3607         https://bugs.webkit.org/show_bug.cgi?id=159827
3608
3609         Reviewed by Daniel Bates.
3610
3611         This change was spurred by a process hang which occurred between tests and did
3612         not produce a meaningful crashlog.
3613
3614         * Scripts/webkitpy/port/driver.py:
3615         (Driver._check_for_driver_crash_or_unresponsiveness): Notify test controller when finished through stdin.
3616
3617          * Scripts/webkitpy/port/ios.py:
3618         (IOSSimulatorPort):
3619         (IOSSimulatorPort.sample_process): Attempt spindump, but use sample if spindump fails.
3620         * Scripts/webkitpy/port/mac.py:
3621         (MacPort):
3622         (MacPort.sample_process): Attempt spindump, but use sample if spindump fails.
3623
3624         * Scripts/webkitpy/port/mac_unittest.py: Changed expected values to match spindump calls, added specific spindump test.
3625         * Scripts/webkitpy/port/driver_unittest.py: Added dummy write function.
3626
3627         * WebKitTestRunner/TestController.h:
3628         (WTR::TestController::usingServerMode): Added accessor for m_usingServerMode.
3629         * WebKitTestRunner/TestInvocation.cpp:
3630         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Wait for stdin before continuing when in server mode.
3631
3632 2016-08-07  Dan Bernstein  <mitz@apple.com>
3633
3634         [Cocoa] Reply block leaks if the remote object doesn’t call it
3635         https://bugs.webkit.org/show_bug.cgi?id=160642
3636
3637         Reviewed by Sam Weinig.
3638
3639         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Declared a new method.
3640         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
3641         (TEST): Added a test case that checks that the reply block is released even when it’s not
3642           called.
3643         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
3644         (-[RemoteObjectRegistryPlugIn doNotCallCompletionHandler:]): Implement new method by not
3645           calling the completion handler.
3646
3647 2016-08-07  Chris Dumez  <cdumez@apple.com>
3648
3649         Write API test to cover crash fix in r204135
3650         https://bugs.webkit.org/show_bug.cgi?id=160587
3651
3652         Reviewed by Darin Adler.
3653
3654         Add API test to cover crash fix in r204135. This reproduces the crash
3655         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
3656         callback.
3657
3658         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
3659         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
3660         (TEST):
3661
3662 2016-08-06  Chris Dumez  <cdumez@apple.com>
3663
3664         Unreviewed, rolling out r204226.
3665
3666         Broke some API tests
3667
3668         Reverted changeset:
3669
3670         "Write API test to cover crash fix in r204135"
3671         https://bugs.webkit.org/show_bug.cgi?id=160587
3672         http://trac.webkit.org/changeset/204226
3673
3674 2016-08-06  Aakash Jain  <aakash_jain@apple.com>
3675
3676         EWS Style Queue fails to process patches which fails validation
3677         https://bugs.webkit.org/show_bug.cgi?id=160632
3678
3679         Reviewed by Alexey Proskuryakov.
3680
3681         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
3682         (StyleQueueTask.validate): Add more information about validation failure.
3683         (StyleQueueTask.run): Pass the error details in the PatchIsNotValid exception.
3684         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3685         (test_non_valid_patch): Add a unit test to test the above code path.
3686
3687 2016-08-06  Sam Weinig  <sam@webkit.org>
3688
3689         WTF needs a variant implementation
3690         https://bugs.webkit.org/show_bug.cgi?id=160618
3691
3692         Reviewed by Darin Adler.
3693
3694         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3695         * TestWebKitAPI/Tests/WTF/Variant.cpp: Added.
3696         Add tests for the variant implementation.
3697
3698 2016-08-06  Chris Dumez  <cdumez@apple.com>
3699
3700         Write API test to cover crash fix in r204135
3701         https://bugs.webkit.org/show_bug.cgi?id=160587
3702
3703         Reviewed by Darin Adler.
3704
3705         Add API test to cover crash fix in r204135. This reproduces the crash
3706         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
3707         callback.
3708
3709         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
3710         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
3711         (TEST):
3712
3713 2016-08-05  Tim Horton  <timothy_horton@apple.com>
3714
3715         run-api-tests should use a headed simulator
3716         https://bugs.webkit.org/show_bug.cgi?id=160611
3717
3718         Reviewed by Sam Weinig.
3719
3720         CADisplayLink doesn't work in a headless simulator, but is
3721         vital for the proper functioning of WebKit2 painting on iOS.
3722         So, we should not use a headless simulator.
3723
3724         * Scripts/run-api-tests:
3725         Launch a simulator app, don't just boot the simulator.
3726
3727         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
3728         Re-enable a test that works now.
3729
3730 2016-08-05  Dan Bernstein  <mitz@apple.com>
3731
3732         [Cocoa] WKRemoteObjectCoder doesn’t handle NSRange
3733         https://bugs.webkit.org/show_bug.cgi?id=160589
3734
3735         Reviewed by Tim Horton.
3736
3737         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
3738         (remoteObjectInterface): Fixed a mistake in the set of allowed classes in one of the reply
3739           blocks, which wasn’t caught because the test wasn’t run correctly.
3740         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
3741         (TEST): Fixed the -selectionAndClickInformationForClickAtPoint:completionHandler: test, and
3742           added a test that sends over an NSRange.
3743         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
3744         (-[RemoteObjectRegistryPlugIn takeRange:completionHandler:]): Added. Calls the completion
3745           handler with the range‘s location and length.
3746
3747 2016-08-05  Enrica Casucci  <enrica@apple.com>
3748
3749         Fixing tests failing after r204175.
3750
3751         Unreviewed.
3752
3753         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig:
3754
3755 2016-08-05  Enrica Casucci  <enrica@apple.com>
3756
3757         Build fix after 204053.
3758
3759         Unreviewed.
3760
3761         * TestWebKitAPI/Configurations/Base.xcconfig:
3762         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
3763         (-[MockContentFilterEnabler initWithCoder:]):
3764         (-[MockContentFilterEnabler dealloc]):
3765
3766 2016-08-05  Konstantin Tokarev  <annulen@yandex.ru>
3767
3768         Print test name in "Last character read from DRT..." error message.
3769         https://bugs.webkit.org/show_bug.cgi?id=160559
3770
3771         Reviewed by Michael Catanzaro.
3772
3773         * Scripts/webkitpy/port/driver.py:
3774         (Driver.run_test):
3775         (Driver._read_first_block):
3776         (Driver._read_optional_image_block):
3777         (Driver._read_block):
3778         * Scripts/webkitpy/port/driver_unittest.py:
3779         (DriverTest.test_read_block):
3780         (DriverTest.test_read_binary_block):
3781         (DriverTest.test_read_base64_block):
3782
3783 2016-08-05  Commit Queue  <commit-queue@webkit.org>
3784
3785         Unreviewed, rolling out r204123.
3786         https://bugs.webkit.org/show_bug.cgi?id=160597
3787
3788         Caused layout test timeouts on Windows. (Requested by perarne
3789         on #webkit).
3790
3791         Reverted changeset:
3792
3793         "[Win] Unable to reliably run tests in parallel"
3794         https://bugs.webkit.org/show_bug.cgi?id=140914
3795         http://trac.webkit.org/changeset/204123
3796
3797 2016-08-04  Saam Barati  <sbarati@apple.com>
3798
3799         Restore CodeBlock jettison code to jettison when a CodeBlock has been alive for a long time
3800         https://bugs.webkit.org/show_bug.cgi?id=151241
3801
3802         Reviewed by Benjamin Poulain.
3803
3804         * Scripts/run-jsc-stress-tests:
3805
3806 2016-08-04  Dean Johnson  <dean_johnson@apple.com>
3807
3808         UI improvements to Flakiness Dashboard.
3809         https://bugs.webkit.org/show_bug.cgi?id=153295
3810
3811         Reviewed by Alexey Proskuryakov.
3812
3813         * TestResultServer/static-dashboards/flakiness_dashboard.css:
3814         (td.options-container): Center text in most fields.
3815         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3816         (createBugHTML): Text/Grammar updates.
3817         (tableHeaders): Ditto.
3818         (htmlForSingleTestRow): Ditto.
3819         (headerForTestTableHtml): Ditto.
3820         * TestResultServer/static-dashboards/ui.js: Removed the "Group: " and "Test type: " headings.
3821         (ui.html.testTypeSwitcher): Deleted. Removes the "Group:" heading.
3822
3823 2016-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3824
3825         [GTK] install-dependencies script misses libxslt as build-dependency and some python libs for the run-benchmark script
3826         https://bugs.webkit.org/show_bug.cgi?id=160518
3827
3828         Reviewed by Michael Catanzaro.
3829
3830         * Scripts/webkitpy/thirdparty/__init__.py:
3831         (AutoinstallImportHook._install_twisted): Twisted requires zope.interface.
3832         * gtk/install-dependencies:
3833
3834 2016-08-04  Alexey Proskuryakov  <ap@apple.com>
3835
3836         Optimize bot watcher's dashboard a little
3837         https://bugs.webkit.org/show_bug.cgi?id=160515
3838         rdar://problem/26096900
3839
3840         Reviewed by Lucas Forschler.
3841
3842         Made re-sorting after loading an iteration more efficient.
3843
3844         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3845         (BuildbotIteration.prototype._updateWithData):
3846         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3847         (BuildbotQueue.prototype.updateIterationPosition):
3848
3849 2016-08-04  Per Arne Vollan  <pvollan@apple.com>
3850
3851         [Win] Unable to reliably run tests in parallel
3852         https://bugs.webkit.org/show_bug.cgi?id=140914
3853
3854         Reviewed by Brent Fulgham.
3855
3856         The cygpath utility function can fail badly when running with multiple DumpRenderTree
3857         processes. We can use string replacement to convert the Cygwin path to a Windows path
3858         instead.
3859  
3860         * Scripts/webkitpy/common/system/path.py:
3861         (cygpathFast):
3862         * Scripts/webkitpy/port/driver.py:
3863         (Driver._command_from_driver_input):
3864
3865 2016-08-03  Aakash Jain  <aakash_jain@apple.com>
3866
3867         Document instructions for increasing process and file limits
3868         https://bugs.webkit.org/show_bug.cgi?id=160528
3869         rdar://problem/24777576
3870
3871         Reviewed by Alexey Proskuryakov.
3872
3873         * Scripts/webkitpy/port/ios.py:
3874         (IOSSimulatorPort.default_child_processes):
3875
3876 2016-08-03  Anders Carlsson  <andersca@apple.com>
3877
3878         Remove the Objective-C bindings generator
3879         https://bugs.webkit.org/show_bug.cgi?id=160526
3880
3881         Reviewed by Sam Weinig.
3882
3883         * Scripts/run-bindings-tests:
3884         Update test.
3885
3886 2016-08-03  Tim Horton  <timothy_horton@apple.com>
3887
3888         Revise a TestWebKitAPI comment to mention the actual underlying problem
3889
3890         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
3891         Note that this is because of https://bugs.webkit.org/show_bug.cgi?id=160516
3892
3893 2016-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3894
3895         Benchmark test content-animation timeouts always
3896         https://bugs.webkit.org/show_bug.cgi?id=160057
3897
3898         Reviewed by Simon Fraser.
3899
3900         * Scripts/webkitpy/benchmark_runner/data/plans/Skipped: Added.
3901         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
3902         (start):
3903
3904 2016-08-02  Nan Wang  <n_wang@apple.com>
3905
3906         AX: Simulated touch events are not working on iOS
3907         https://bugs.webkit.org/show_bug.cgi?id=160395
3908         <rdar://problem/27633597>
3909
3910         Reviewed by Chris Fleizach.
3911
3912         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3913         (WTR::AccessibilityUIElement::press):
3914         (WTR::AccessibilityUIElement::setSelectedChild):
3915
3916 2016-08-02  Filip Pizlo  <fpizlo@apple.com>
3917
3918         run-javascriptcore-tests should accept multiple --extra-tests
3919         https://bugs.webkit.org/show_bug.cgi?id=160486
3920
3921         Reviewed by Saam Barati.
3922         
3923         We want to be able to pass --extra-tests multiple times, to supply an arbitrary number of extra
3924         test suites. This does it by using GetOpt::Long's array support.
3925
3926         * Scripts/run-javascriptcore-tests:
3927         (runJSCStressTests):
3928
3929 2016-08-02  Enrica Casucci  <enrica@apple.com>
3930
3931         Allow building with content filtering disabled.
3932         https://bugs.webkit.org/show_bug.cgi?id=160454
3933
3934         Reviewed by Simon Fraser.
3935
3936         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3937
3938 2016-08-02  Brady Eidson  <beidson@apple.com>
3939
3940         Removing IndexedDB WebsiteData can fail for some users.
3941         https://bugs.webkit.org/show_bug.cgi?id=160463
3942
3943         Reviewed by Alex Christensen.
3944
3945         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
3946
3947 2016-08-01  Alex Christensen  <achristensen@webkit.org>
3948
3949         _WKDownloadDelegate.didReceiveResponse should be called before decideDestinationWithSuggestedFilename
3950         https://bugs.webkit.org/show_bug.cgi?id=160437
3951         <rdar://problem/27578272>
3952
3953         Reviewed by Brady Eidson.
3954
3955         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3956         (-[DownloadDelegate _download:didReceiveResponse:]):
3957         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
3958         (runTest):
3959         Add a boolean to make sure that didReceiveResponse is called before decideDestinationWithSuggestedFilename.
3960
3961 2016-08-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3962
3963         [Tools] The GDB backtrace report tool don't checks the gdb return code.
3964         https://bugs.webkit.org/show_bug.cgi?id=160414
3965
3966         Reviewed by Michael Catanzaro.
3967
3968         * Scripts/webkitpy/port/linux_get_crash_log.py:
3969         (GDBCrashLogGenerator._wait_for_corefile):
3970
3971 2016-08-01  Youenn Fablet  <youenn@apple.com>
3972
3973         Make wpt server generate its certificates in layout test results folder
3974         https://bugs.webkit.org/show_bug.cgi?id=160422
3975
3976         Reviewed by Chris Dumez.
3977
3978         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3979         (WebPlatformTestServer._copy_webkit_test_files): Setting certificate folder to layout tests results directory.
3980
3981 2016-08-01  Jonathan Bedard  <jbedard@apple.com>
3982
3983         Function Call on NULL Object
3984         https://bugs.webkit.org/show_bug.cgi?id=160325
3985
3986         Reviewed by Darin Adler.
3987
3988         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3989         (WTR::InjectedBundle::didReceiveMessageToPage): Changed removeAllWebNotificationPermissions() call to static function call.
3990         * WebKitTestRunner/InjectedBundle/TestRunner.h: Made all web-notification functions static.
3991
3992 2016-08-01  Keith Miller  <keith_miller@apple.com>
3993
3994         We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory.
3995         https://bugs.webkit.org/show_bug.cgi?id=160372
3996
3997         Rubber stamped by Geoffrey Garen.
3998
3999         This patch moves all the JavaScript tests from Source/JavaScriptCore/tests to
4000         a new top level directory, JSTests. Having the tests in the Source directory
4001         was both confusing an inconvenient for people that just want to checkout the
4002         source code of WebKit. Since there is no other obvious place to put all the
4003         JavaScript tests a new top level directory seemed the most sensible.
4004
4005         * Scripts/import-test262-tests:
4006         * Scripts/run-javascriptcore-tests:
4007         * Scripts/update-javascriptcore-test-res:
4008
4009 2016-07-31  Nan Wang  <n_wang@apple.com>
4010
4011         AX: Add a check for touch event listener on iOS accessibility object
4012         https://bugs.webkit.org/show_bug.cgi?id=160388
4013
4014         Reviewed by Chris Fleizach.
4015
4016         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
4017         (AccessibilityUIElement::boolAttributeValue):
4018         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
4019         (WTR::AccessibilityUIElement::boolAttributeValue):
4020
4021 2016-07-30  Manuel Rego Casasnovas  <rego@igalia.com>
4022
4023         Unreviewed: add myself to the reviewers list.
4024
4025         * Scripts/webkitpy/common/config/contributors.json:
4026
4027 2016-07-29  Alexey Proskuryakov  <ap@apple.com>
4028
4029         Undo r203939, and copy over a rule that clips the logos.
4030
4031         Sierra wasn't the only logo without transparency.
4032
4033         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
4034         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
4035         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
4036
4037 2016-07-29  Alan Sien Wei Hshieh  <hshieh@apple.com>
4038
4039         The Sierra asset at build.webkit.org/dashboard/images/Sierra*.png has a white background
4040         https://bugs.webkit.org/show_bug.cgi?id=160377
4041
4042         Reviewed by Brian Weinstein.
4043
4044         Update assets to remove the white background and use a transparent background instead.
4045
4046         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
4047         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
4048
4049 2016-07-29  David Kilzer  <ddkilzer@apple.com>
4050
4051         Ignore most check-webkit-style checks for ANGLE project
4052         <https://webkit.org/b/160333>
4053
4054         Reviewed by Daniel Bates.
4055
4056         * Scripts/webkitpy/style/checker.py: Ignore all checkers except:
4057         - No tabs.
4058         - No spaces at the end of lines.
4059         - No carriage returns (DOS line endings).
4060
4061 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
4062
4063         Media controls are not displayed for some autoplaying videos at certain browser dimensions
4064         https://bugs.webkit.org/show_bug.cgi?id=160360
4065         <rdar://problem/27179484>
4066
4067         Reviewed by Myles C. Maxfield.
4068
4069         Adds two tests verifying that videos may be considered main content as long as they
4070         are large enough and cover a majority of the mainframe's viewport.
4071
4072         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4073         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
4074         (TestWebKitAPI::TEST):
4075         * TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html: Added.
4076         * TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html: Added.
4077
4078 2016-07-29  Mark Lam  <mark.lam@apple.com>
4079
4080         Gardening: removed unused variable.
4081
4082         Not reviewed.
4083
4084         * TestWebKitAPI/Tests/WTF/StringView.cpp:
4085         (TestWebKitAPI::TEST):
4086
4087 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
4088
4089         Add TestWebKitAPI support for interacting with media controls
4090         https://bugs.webkit.org/show_bug.cgi?id=160342
4091         <rdar://problem/27610246>
4092
4093         Reviewed by Beth Dakin.
4094
4095         Adds support for testing interaction with some media controls, as well as a basic test
4096         verifying that media control teardown after interaction does not result in a crash.
4097
4098         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
4099         (-[WKWebView mouseDownAtPoint:]):
4100         (-[WKWebView performAfterLoading:]):
4101         (TestWebKitAPI::TEST):
4102
4103 2016-07-29  Jonathan Bedard  <jbedard@apple.com>
4104
4105         Crash Log Clobbering on Unbound Crashes
4106         https://bugs.webkit.org/show_bug.cgi?id=160198
4107         <rdar://problem/27472618>
4108
4109         Reviewed by Alexey Proskuryakov.
4110
4111         * Scripts/webkitpy/common/system/crashlogs.py:
4112         (CrashLogs): Fix header order.
4113         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
4114         (TestResultWriter.output_filename): Only remove file extension if it is clearly a file extension.
4115
4116 2016-07-29  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
4117
4118         Update for contributors.json
4119         https://bugs.webkit.org/show_bug.cgi?id=160294
4120
4121         * Scripts/webkitpy/common/config/contributors.json:
4122
4123 2016-07-28  Myles C. Maxfield  <mmaxfield@apple.com>
4124
4125         Remove deprecated SPI for video inline / fullscreen controls
4126         https://bugs.webkit.org/show_bug.cgi?id=160318
4127
4128         Reviewed by Tim Horton.
4129
4130         * DumpRenderTree/mac/DumpRenderTree.mm:
4131         (setDefaultsToConsistentValuesForTesting): Deleted.
4132         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
4133         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
4134         * WebKitTestRunner/TestController.cpp:
4135         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
4136         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4137         (WTR::initializeWebViewConfiguration): Deleted.
4138
4139 2016-07-28  Daniel Bates  <dabates@apple.com>
4140
4141         [iOS] TestWebKitAPI bundle targets are not code signed
4142         https://bugs.webkit.org/show_bug.cgi?id=160328
4143         <rdar://problem/27409246>
4144
4145         Reviewed by Andy Estes.
4146
4147         Workaround <rdar://problem/27459890> by explicitly defining Xcode build settings
4148         CODE_SIGNING_ALLOWED and AD_HOC_CODE_SIGNING_ALLOWED to be YES so as to allow the
4149         the TestWebKitAPI bundle targets to be code signed when building for the iOS simulator.
4150
4151         * TestWebKitAPI/Configurations/Base.xcconfig:
4152
4153 2016-07-28  Tim Horton  <timothy_horton@apple.com>
4154
4155         Disable WebKit2.ResizeWithHiddenContentDoesNotHang for now
4156
4157         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
4158         (animatedResizeWebView):
4159         (TEST):
4160         This test times out only when run in the WebKit Testing simulator environment,
4161         but not in a fresh simulator. Disabling to keep the bots green while under investigation.
4162
4163 2016-07-28  Tim Horton  <timothy_horton@apple.com>
4164
4165         Frequent animation lags when interacting with Safari (sidebar, tab switching, etc.)
4166         https://bugs.webkit.org/show_bug.cgi?id=160289
4167         <rdar://problem/27553464>
4168
4169         Reviewed by Simon Fraser.
4170
4171         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
4172         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4173         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm: Added.
4174         (-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]):
4175         (-[AnimatedResizeWebView _endAnimatedResize]):
4176         (animatedResizeWebView):
4177         (TEST):
4178         * TestWebKitAPI/Tests/WebKit2Cocoa/blinking-div.html: Added.
4179         Add two tests that ensure that hidden-content and animated resizes
4180         don't cause unnecessary synchronous waits. Only the hidden-content
4181         one fails before my patch, but it seemed reasonable to add both anyway.
4182
4183 2016-07-28  David Kilzer  <ddkilzer@apple.com>
4184
4185         webkit-patch upload --suggest-reviewers shouldn't break in the presence of deleted or moved files
4186         <https://webkit.org/b/83342>
4187
4188         Reviewed by Ryosuke Niwa.
4189
4190         * Scripts/webkitpy/common/checkout/scm/git.py:
4191         (Git.revisions_changing_file): Remove code to raise an exception
4192         when the file doesn't exist.  If a file was moved or renamed,
4193         then this caused the script to terminate, which was very
4194         frustrating when you wanted a list of reviewers.
4195         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
4196         (SCMTest._shared_test_revisions_changing_file): Update test
4197         expectation to return an empty list of revisions.
4198         (test_create_patch_is_full_patch): Drive-by fix when running all
4199         webkitpy tests (including scm tests).
4200         * Scripts/webkitpy/common/checkout/scm/svn.py:
4201         (SVN.revisions_changing_file): Catch ScriptError exceptions and
4202         return an empty array of revisions if this occurs.
4203
4204 2016-07-28  Aakash Jain  <aakash_jain@apple.com>
4205
4206         EWS error message "Error: * did not process patch" should include explanation
4207         https://bugs.webkit.org/show_bug.cgi?id=159903
4208         <rdar://problem/27410788>
4209
4210         Reviewed by Alexey Proskuryakov.
4211
4212         * QueueStatusServer/handlers/statusbubble.py:
4213         (StatusBubble._build_bubble): Display more detailed error message on bubbles when patch
4214         is not processed.
4215         * QueueStatusServer/handlers/processingtimesjson.py:
4216         (ProcessingTimesJSON._resultFromFinalStatus): Updated error message to match with rest
4217         of the code.
4218         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
4219         (CommitQueueTask.validate): Add more information about validation failure.
4220         (CommitQueueTask.run): Pass the error details in the PatchIsNotValid exception.
4221         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
4222         (EarlyWarningSystemTask.validate): Add more information about validation failure.
4223         (EarlyWarningSystemTask.run): Pass the error details in the PatchIsNotValid exception.
4224         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
4225         (PatchIsNotValid.__init__): Add the failure_message argument.
4226         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4227         (AbstractEarlyWarningSystem.review_patch): Re-word the error message and include
4228         failure details.
4229         * Scripts/webkitpy/tool/commands/queues.py:
4230         (CommitQueue.process_work_item): Same.
4231         (StyleQueue.review_patch): Same.
4232         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4233         (test_non_valid_patch): Updated test-cases messages to match the above changes.
4234
4235 2016-07-27  Alexey Proskuryakov  <ap@apple.com>
4236
4237         LayoutTestRelay should wait for WebKitTestRunnerApp installation to complete
4238         https://bugs.webkit.org/show_bug.cgi?id=160262
4239
4240         Reviewed by Daniel Bates.
4241
4242         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
4243         (-[LTRelayController installApp]):
4244
4245 2016-07-27  Ryan Haddad  <ryanhaddad@apple.com>
4246
4247         Disable WebCoreNSURLSessionTest API tests on ios-simulator
4248         https://bugs.webkit.org/show_bug.cgi?id=160225
4249
4250         Reviewed by Alexey Proskuryakov.
4251
4252         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
4253
4254 2016-07-27  Miguel Gomez  <magomez@igalia.com>
4255
4256         [GTK] Fix some video/canvas tests that should be passing
4257         https://bugs.webkit.org/show_bug.cgi?id=160023
4258
4259         Reviewed by Carlos Garcia Campos.
4260
4261         Add a platform identifier to the TestRunner's page user agent when the tests are run on the
4262         EFL or GTK platforms.
4263
4264         * WebKitTestRunner/efl/TestControllerEfl.cpp:
4265         (WTR::TestController::platformConfigureViewForTest):
4266         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
4267         (WTR::TestController::platformConfigureViewForTest):
4268
4269 2016-07-27  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4270
4271         [Tools] The built product doesn't contains the dwo files when DEBUG_FISSION is enabled.
4272         https://bugs.webkit.org/show_bug.cgi?id=160247
4273
4274         Reviewed by Michael Catanzaro.
4275
4276         * BuildSlaveSupport/built-product-archive:
4277         (createZip):
4278         (dirContainsdwo):
4279         (archiveBuiltProduct):
4280
4281 2016-07-26  Alex Christensen  <achristensen@webkit.org>
4282
4283         Fix tests after r203743.
4284         https://bugs.webkit.org/show_bug.cgi?id=156947
4285
4286         * WebKitTestRunner/TestController.cpp:
4287         (WTR::TestController::resetStateToConsistentValues):
4288         Reset the new boolean m_rejectsProtectionSpaceAndContinueForAuthenticationChallenges.
4289
4290 2016-07-26  Myles C. Maxfield  <mmaxfield@apple.com>
4291
4292         [iPhone] Playing a video on tudou.com plays only sound, no video
4293         https://bugs.webkit.org/show_bug.cgi?id=160178
4294         <rdar://problem/27535468>
4295
4296         Reviewed by Dan Bernstein.
4297
4298         * DumpRenderTree/mac/DumpRenderTree.mm:
4299         (setDefaultsToConsistentValuesForTesting):
4300         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
4301         (RequiresUserActionForPlaybackTest::SetUp):
4302         * WebKitTestRunner/TestController.cpp:
4303         (WTR::TestController::resetPreferencesToConsistentValues):
4304  &n