run-jsc should pass the option to use dollar vm by default
[WebKit-https.git] / Tools / ChangeLog
1 2018-06-02  Keith Miller  <keith_miller@apple.com>
2
3         run-jsc should pass the option to use dollar vm by default
4         https://bugs.webkit.org/show_bug.cgi?id=186170
5
6         Reviewed by Yusuke Suzuki.
7
8         * Scripts/run-jsc:
9
10 2018-06-02  Commit Queue  <commit-queue@webkit.org>
11
12         Unreviewed, rolling out r232421.
13         https://bugs.webkit.org/show_bug.cgi?id=186240
14
15         Breaks webkitpy tests (Requested by aakashjain on #webkit).
16
17         Reverted changeset:
18
19         "Add some tests for lldb_webkit.py"
20         https://bugs.webkit.org/show_bug.cgi?id=183744
21         https://trac.webkit.org/changeset/232421
22
23 2018-06-01  Daniel Bates  <dabates@apple.com>
24
25         Add some tests for lldb_webkit.py
26         https://bugs.webkit.org/show_bug.cgi?id=183744
27
28         Reviewed by Alexey Proskuryakov.
29
30         Adds some tests to ensure we do not regress LLDB pretty-printing of WTF::StringImpl
31         and WTF::String objects.
32
33         The tests make use of the LLDB Python API (lldb.py) and a simple debug-built test
34         program, lldbWebKitTester, to run. For now, we only support building lldbWebKitTester
35         on Mac.
36
37         * Makefile: Build the simple test tool lldbWebKitTester on Mac.
38         * Scripts/build-lldbwebkittester: Added.
39         (buildProjectOrDie):
40         * Scripts/dump-class-layout: Extract logic to compute the path to the LLDB Python module
41         from here to Scripts/webkitpy/common/system/systemhost.py so that it can used by both
42         this script and lldb/lldb_webkit_unittest.py. Also import the lldb module at the top of
43         the file and take advantage of Python's default error semantics to throw an exception
44         if the import fails instead of handling it ourself. This has the side effect that we
45         now always import the LLDB Python module even if this script is invoked with --help.
46         If this turns out to be a significant annoyance then we can look to dynamically import
47         the module as we did before this change.
48         (webkit_build_dir):
49         (main):
50         (developer_dir): Deleted.
51         (import_lldb): Deleted.
52         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Update FIXME comment to reflect
53         that fact that test-webkitpy does not support class and module fixtures. This is because
54         test-webkitpy currently implements parallelism by breaking down existing test classes
55         into individual test methods itself and having each worker run exactly one test method (via
56         unittest.TestLoader.loadTestsFromName()) at a time. As a result of this reorganization,
57         setUpModule()/setUpClass() are called for each test method as opposed to once per test
58         class/test module.
59         (remove_dir): Ditto.
60         * Scripts/webkitpy/common/system/systemhost.py:
61         (SystemHost):
62         (SystemHost.path_to_lldb_python_directory): Added.
63         * Scripts/webkitpy/test/main.py:
64         (_find_lldb_webkit_tester): Returns whether there exists a Debug or Release-built lldbWebKitTester.
65         (_build_lldb_webkit_tester): Builds lldbWebKitTester. For now, we only support building
66         lldbWebKitTester on Mac.
67         (main): Add Tools/lldb to the test search path if the platform has lldb.py.
68         (Tester.run): Pass a boolean as to whether we will run the lldb_webkit unit tests.
69         (Tester._run_tests): Modified to take a boolean as to whether to run the lldb_webkit unit tests.
70         If we will run these tests then build lldbWebKitTester if it has not already been built as the
71         unit tests depend on this program.
72         * lldb/lldbWebKitTester/Configurations/Base.xcconfig: Added.
73         * lldb/lldbWebKitTester/Configurations/DebugRelease.xcconfig: Added.
74         * lldb/lldbWebKitTester/Configurations/lldbWebKitTester.xcconfig: Added.
75         * lldb/lldbWebKitTester/Makefile: Added.
76         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj: Added.
77         * lldb/lldbWebKitTester/main.cpp: Added.
78         (breakForTestingSummaryProviders):
79         (utf16String):
80         (testSummaryProviders):
81         (main):
82         * lldb/lldb_webkit_unittest.py: Added.
83         (destroy_cached_debug_session):
84         (LLDBDebugSession):
85         (LLDBDebugSession.setup):
86         (LLDBDebugSession.tearDown):
87         (TestSummaryProviders):
88         (TestSummaryProviders.setUpClass):
89         (TestSummaryProviders._sbFrame):
90         (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_null_string):
91         (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_empty_string):
92         (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_8bit_string):
93         (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_16bit_string):
94         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_null_string):
95         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_empty_string):
96         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_8bit_string):
97         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_16bit_string):
98
99 2018-06-01  Frederic Wang  <fwang@igalia.com>
100
101         export-w3c-test-changes cannot apply patches when some w3c-import.log files are changed
102         https://bugs.webkit.org/show_bug.cgi?id=186133
103
104         Reviewed by Youenn Fablet.
105
106         * Scripts/webkitpy/w3c/test_exporter.py: Exclude w3c-import.log from the diff.
107         * Scripts/webkitpy/w3c/test_exporter_unittest.py: Add unit test.
108
109 2018-05-31  Frederic Wang  <fwang@igalia.com>
110
111         export-w3c-test-changes should use the new location & name of the WPT repo
112         https://bugs.webkit.org/show_bug.cgi?id=186135
113
114         Reviewed by Youenn Fablet.
115
116         Web platform tests have been moved to GitHub's web-platform-tests/wpt. This patch updates the
117         corresponding variables to use the new organization and repository name. It also refactors a
118         bit the code to reduce the amount of hardcoded strings.
119
120         * Scripts/webkitpy/w3c/common.py: Use org web-platform-tests, repo name wpt. Also removes the
121         final slash to WPT_GH_URL, so it can be used for repo URL too.
122         * Scripts/webkitpy/w3c/test_exporter.py: Import more symbols and define WPT_PR_URL from
123         WPT_GH_URL.
124         (WebPlatformTestExporter._wpt_fork_branch_github_url): Use WPT_GH_REPO_NAME.
125         (WebPlatformTestExporter._wpt_fork_push_url): Use WPT_GH_REPO_NAME.
126         (WebPlatformTestExporter._git): Use  WPT_GH_URL.
127         (WebPlatformTestExporter._ensure_username_and_token): Use WPT_GH_ORG, WPT_GH_REPO_NAME.
128         (WebPlatformTestExporter.make_pull_request): Use WPT_GH_ORG, WPT_GH_REPO_NAME.
129         (parse_args): Use WPT_GH_REPO_NAME, WPT_GH_URL.
130         * Scripts/webkitpy/w3c/test_exporter_unittest.py:
131         (TestExporterTest.test_export): Update organization and repository names for the remote
132         branch and pull request.
133         (TestExporterTest.test_export_with_specific_branch): Update repository name.
134
135 2018-05-31  Ryan Haddad  <ryanhaddad@apple.com>
136
137         Update expected results for BuildStepsConstructorTest
138         https://bugs.webkit.org/show_bug.cgi?id=186119
139
140         Reviewed by Alex Christensen.
141
142         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Add missing entries for 'WinCairo 64-bit' bots.
143
144 2018-05-31  Sihui Liu  <sihui_liu@apple.com>
145
146         [iOS] TestWebKitAPI.WebKit.WKHTTPCookieStoreWithoutProcessPool fails because cookies use different files with/without processpool
147         https://bugs.webkit.org/show_bug.cgi?id=185831
148         <rdar://problem/40468716>
149
150         Reviewed by David Kilzer.
151
152         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
153         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
154         (TEST):
155
156 2018-05-31  Chris Dumez  <cdumez@apple.com>
157
158         [iOS] API test ScrollViewInsetTests.InnerHeightWithLargeTopContentInset is a flaky failure
159         https://bugs.webkit.org/show_bug.cgi?id=184893
160         <rdar://problem/39747271>
161
162         Reviewed by Wenson Hsieh.
163
164         Update test to wait until the view is the expected height instead of
165         calling waitForNextPresentationUpdate once and expect the view to
166         have the right height. This fixes the flakiness.
167
168         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
169         (TestWebKitAPI::waitUntilInnerHeightIs):
170         (TestWebKitAPI::TEST):
171
172 2018-05-31  Leo Balter  <leonardo.balter@gmail.com>
173
174         test262-runner should run in verbose mode in automation
175         https://bugs.webkit.org/show_bug.cgi?id=186115
176
177         Reviewed by Yusuke Suzuki.
178
179         This patch toggles the verbose mode in the build bot and reports every test file
180         in order to avoid the '1200 seconds without output' issue.
181         * BuildSlaveSupport/build.webkit.org-config/steps.py:
182         (RunTest262Tests):
183         * Scripts/test262/Runner.pm:
184         (processResult):
185
186 2018-05-30  Fujii Hironori  <Hironori.Fujii@sony.com>
187
188         [Win][MiniBrowser] Move MainWindow related code from Common.cpp to MainWindow.cpp
189         https://bugs.webkit.org/show_bug.cgi?id=186079
190
191         Reviewed by Alex Christensen.
192
193         This is a sub task of Bug 184770.
194
195         This change is partial. I'm going to remove global variables
196         gMainWindow and gMiniBrowser and convert more functions to
197         MainWindow's methods in follow-up patches.
198
199         * MiniBrowser/win/CMakeLists.txt: Added Common.cpp
200         * MiniBrowser/win/Common.cpp:
201         (menuItemIsChecked): Moved to MainWindow.cpp.
202         (turnOffOtherUserAgents): Ditto.
203         (EditProc): Ditto.
204         (BackButtonProc): Ditto.
205         (ForwardButtonProc): Ditto.
206         (About): Ditto.
207         (Caches): Ditto.
208         (CustomUserAgent): Ditto.
209         (AuthDialogProc): Ditto.
210         (DisplayAuthDialog): Converted to MainWindow's method.
211         (ToggleMenuItem): Ditto.
212         (loadURL): Ditto.
213         * MiniBrowser/win/Common.h:
214         * MiniBrowser/win/MainWindow.cpp:
215         (MainWindow::init): Call SetFocus at the end of the construction.
216         (MainWindow::WndProc):
217         (menuItemIsChecked): Moved from Common.cpp.
218         (turnOffOtherUserAgents): Ditto.
219         (EditProc): Ditto.
220         (BackButtonProc): Ditto.
221         (ForwardButtonProc): Ditto.
222         (About): Ditto.
223         (Caches): Ditto.
224         (CustomUserAgent): Ditto.
225         (authDialogProc): Ditto.
226         (MainWindow::displayAuthDialog): Converted from a function of Common.cpp.
227         (MainWindow::toggleMenuItem): Ditto.
228         (MainWindow::loadURL): Ditto.
229         * MiniBrowser/win/MainWindow.h: Added method declarations.
230         * MiniBrowser/win/MiniBrowser.h: Added pragma once.
231         * MiniBrowser/win/WinMain.cpp:
232         (wWinMain): Include Common.h instead of Common.cpp.
233
234 2018-05-30  Brady Eidson  <beidson@apple.com>
235
236         REGRESSION (r224684): User-agent seen by page does not change when modified by the develop menu options after reloading.
237         <rdar://problem/34918109> and https://bugs.webkit.org/show_bug.cgi?id=186111
238
239         Reviewed by Andy Estes.
240
241         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
242         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
243         (WTR::TestRunner::setCustomUserAgent):
244         * WebKitTestRunner/InjectedBundle/TestRunner.h:
245         * WebKitTestRunner/TestController.cpp:
246         (WTR::TestController::resetStateToConsistentValues):
247         * WebKitTestRunner/TestInvocation.cpp:
248         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
249
250 2018-05-30  Youenn Fablet  <youenn@apple.com>
251
252         Rename CrossOriginResourcePolicy same to same-origin
253         https://bugs.webkit.org/show_bug.cgi?id=186080
254
255         Reviewed by Chris Dumez.
256
257         * TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp:
258         (TestWebKitAPI::TEST):
259
260 2018-05-30  Ms2ger  <Ms2ger@igalia.com>
261
262         [GTK] Unreviewed test gardening
263         https://bugs.webkit.org/show_bug.cgi?id=186098
264
265         Unreviewed gardening.
266
267         * TestWebKitAPI/glib/TestExpectations.json: update expectations.
268
269 2018-05-29  Youenn Fablet  <youenn@apple.com>
270
271         Add a consistency check between URL and CFURL
272         https://bugs.webkit.org/show_bug.cgi?id=182444
273         <rdar://problem/37164835>
274
275         Reviewed by Geoff Garen.
276
277         DRT code expected a non null URL which is no longer the case now.
278         Updated DRT to remove that assumption.
279
280         * DumpRenderTree/TestRunner.cpp:
281         (TestRunner::redirectionDestinationForURL):
282         * DumpRenderTree/TestRunner.h:
283         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
284         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
285
286 2018-05-29  Brendan McLoughlin  <brendan@bocoup.com>
287
288         Export changes to web-platform-test as part of the webkit-patch upload workflow
289         https://bugs.webkit.org/show_bug.cgi?id=184914
290
291         Reviewed by Youenn Fablet.
292
293         * Scripts/webkitpy/tool/commands/upload.py:
294         (Upload):
295         (CreateBug.execute):
296         (WPTChangeExport):
297         * Scripts/webkitpy/tool/steps/__init__.py:
298         * Scripts/webkitpy/tool/steps/wptchangeexport.py: Added.
299         (WPTChangeExport):
300         (WPTChangeExport.options):
301         (WPTChangeExport.run):
302         * Scripts/webkitpy/w3c/common.py:
303         * Scripts/webkitpy/w3c/test_exporter.py:
304         (WebPlatformTestExporter):
305         (WebPlatformTestExporter.__init__):
306         (WebPlatformTestExporter.username):
307         (WebPlatformTestExporter.token):
308         (WebPlatformTestExporter._github):
309         (WebPlatformTestExporter._wpt_fork_branch_github_url):
310         (WebPlatformTestExporter._wpt_fork_remote):
311         (WebPlatformTestExporter._wpt_fork_push_url):
312         (WebPlatformTestExporter._git):
313         (WebPlatformTestExporter._branch_name):
314         (WebPlatformTestExporter._public_branch_name):
315         (WebPlatformTestExporter._wpt_patch):
316         (WebPlatformTestExporter.has_wpt_changes):
317         (WebPlatformTestExporter._find_filename):
318         (WebPlatformTestExporter._is_ignored_file):
319         (WebPlatformTestExporter._strip_ignored_files_from_diff):
320         (WebPlatformTestExporter.write_git_patch_file):
321         (WebPlatformTestExporter._prompt_for_token):
322         (WebPlatformTestExporter._prompt_for_username):
323         (WebPlatformTestExporter._ensure_username_and_token):
324         (WebPlatformTestExporter._validate_and_save_token):
325         (WebPlatformTestExporter.create_branch_with_patch):
326         (WebPlatformTestExporter.push_to_wpt_fork):
327         (WebPlatformTestExporter.make_pull_request):
328         (WebPlatformTestExporter.delete_local_branch):
329         (WebPlatformTestExporter.create_upload_remote_if_needed):
330         (WebPlatformTestExporter.do_export):
331         (parse_args):
332         (TestExporter): Deleted.
333         (TestExporter.__init__): Deleted.
334         (TestExporter._ensure_wpt_repository): Deleted.
335         (TestExporter._fetch_wpt_repository): Deleted.
336         (TestExporter._ensure_new_branch_name): Deleted.
337         (TestExporter.download_and_commit_patch): Deleted.
338         (TestExporter.clean): Deleted.
339         (TestExporter.create_branch_with_patch): Deleted.
340         (TestExporter.push_to_wpt_fork): Deleted.
341         (TestExporter.make_pull_request): Deleted.
342         (TestExporter.create_wpt_pull_request): Deleted.
343         (TestExporter.delete_local_branch): Deleted.
344         (TestExporter.create_git_patch): Deleted.
345         (TestExporter.create_upload_remote): Deleted.
346         (TestExporter.do_export): Deleted.
347         * Scripts/webkitpy/w3c/test_exporter_unittest.py:
348         (TestExporterTest.MockGit):
349         (TestExporterTest.MockGit.create_patch):
350         (TestExporterTest.test_export):
351         (TestExporterTest.test_export_with_specific_branch):
352         (TestExporterTest):
353         (TestExporterTest.test_export_interactive_mode):
354         (TestExporterTest.test_export_invalid_token):
355         (TestExporterTest.test_export_wrong_token):
356         (TestExporterTest.test_has_wpt_changes):
357         (TestExporterTest.test_has_no_wpt_changes_for_no_diff):
358         (TestExporterTest.test_ignore_changes_to_expected_file):
359
360 2018-05-29  Fujii Hironori  <Hironori.Fujii@sony.com>
361
362         [Win][MiniBrowser] Move WK1 specific code from Common.cpp to MiniBrowser.cpp
363         https://bugs.webkit.org/show_bug.cgi?id=186029
364
365         Reviewed by Alex Christensen.
366
367         This is a sub task of Bug 184770.
368
369         * MiniBrowser/win/Common.cpp:
370         (ToggleMenuItem): Extracted WK1 specific code to MiniBrowser::setPreference.
371         (Caches): Call MiniBrowser::updateStatistics instead of updateStatistics.
372         (AbortProc): Moved to MiniBrowser.cpp.
373         (getPrinterDC): Ditto.
374         (initDocStruct): Ditto.
375         (PrintView): Ditto.
376         (ToggleMenuFlag): Ditto.
377         (setWindowText): Ditto.
378         (updateStatistics): Ditto.
379         * MiniBrowser/win/MainWindow.cpp:
380         (MainWindow::WndProc): Call MiniBrowser::print instead of PrintView.
381         * MiniBrowser/win/MiniBrowser.cpp:
382         (AbortProc): Moved from Common.cpp.
383         (getPrinterDC): Moved from Common.cpp.
384         (initDocStruct): Moved from Common.cpp.
385         (setWindowText): Moved from Common.cpp.
386         (MiniBrowser::print): Renamed from PrintView of Common.cpp.
387         (MiniBrowser::updateStatistics): Renamed from updateStatistics of Common.cpp.
388         (MiniBrowser::setPreference): Extracted from ToggleMenuItem of Common.cpp.
389         * MiniBrowser/win/MiniBrowser.h: Add method declarations.
390         * MiniBrowser/win/MiniBrowserWebHost.cpp: Removed duplicated IWebFramePtr typedef.
391
392 2018-05-29  Saam Barati  <sbarati@apple.com>
393
394         JSC should put bmalloc's scavenger into mini mode
395         https://bugs.webkit.org/show_bug.cgi?id=185988
396
397         Reviewed by Michael Saboff.
398
399         This patch makes it so that we turn off the JIT when running run-testmem
400         that way we make JSC use its mini mode.
401
402         * Scripts/run-testmem:
403
404 2018-05-29  Sihui Liu  <sihui_liu@apple.com>
405
406         Unable to remove IndexedDB Databases with Cocoa API removeDataOfTypes
407         https://bugs.webkit.org/show_bug.cgi?id=185835
408         <rdar://problem/39142257>
409
410         Reviewed by Chris Dumez.
411
412         Add API test coverage.
413
414         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
415         (TEST):
416
417 2018-05-29  Wenson Hsieh  <wenson_hsieh@apple.com>
418
419         [Extra zoom mode] "Significant area painted" rendering progress event is rarely fired
420         https://bugs.webkit.org/show_bug.cgi?id=186042
421         <rdar://problem/40604182>
422
423         Reviewed by Tim Horton.
424
425         Adds a new API test to check that the "significant area painting" rendering milestone is dispatched when a
426         significant portion of the page has been painted before document load is finished.
427
428         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
429         * TestWebKitAPI/Tests/WebKitCocoa/paint-significant-area-milestone.html: Added.
430         * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm: Added.
431         (-[MissingResourceSchemeHandler webView:stopURLSchemeTask:]):
432         (-[MissingResourceSchemeHandler webView:startURLSchemeTask:]):
433         (-[RenderingProgressHandler initWithHandler:]):
434         (-[RenderingProgressHandler _webView:renderingProgressDidChange:]):
435         (TEST):
436
437 2018-05-29  Thibault Saunier  <tsaunier@igalia.com>
438
439         [GStreamer] Update "qtdemux: Clarify field name about stream-encryption-system" patch
440         https://bugs.webkit.org/show_bug.cgi?id=186040
441
442         The patch we merge contained a type and was merged in upstream GStreamer fixing that
443         (s/avalaible/available/).
444
445         Reviewed by Xabier Rodriguez-Calvar.
446
447         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch:
448
449 2018-05-28  Sihui Liu  <sihui_liu@apple.com>
450
451         Add an API test to check process privilege when using Cookie API
452         https://bugs.webkit.org/show_bug.cgi?id=185406
453
454         Reviewed by Geoffrey Garen.
455
456         Add API test coverage.
457
458         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
459         (TEST):
460
461 2018-05-28  Thibault Saunier  <tsaunier@igalia.com>
462
463         [GStreamer] Handle changes in the "drm-preferred-decryption-system-id" NEED_CONTEXT message.
464         https://bugs.webkit.org/show_bug.cgi?id=185948
465
466         Reviewed by Xabier Rodriguez-Calvar.
467
468         When the patch introducing gst_protection_filter_systems_by_available_decryptors was merged, we changed sensibly its behaviour
469         concerning the way empty results is represented (now returning NULL instead of an array of 1(NULL) element) and this change was not
470         properly taken into account in the qtdemux patch that uses it and got upstreamed. Those 3 new patches fixe that and change the
471         NEED_CONTEXT field names to clarify the meaning of "stream-encryption-systems".
472
473         * gstreamer/jhbuild.modules:
474         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Added. Merged upstream as 3e063703b3a51b8aaa7f75f36c4660c583a60e93
475         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Added. Merged upstream as 43a540b1cd9f162d3dae5d50e36703dfaf558a3e
476         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Added.
477
478 2018-05-27  Dan Bernstein  <mitz@apple.com>
479
480         Reverted the changes made for https://webkit.org/b/186016
481
482         They broke the USE(APPLE_INTERNAL_SDK) Sierra build.
483
484 2018-05-27  Dan Bernstein  <mitz@apple.com>
485
486         [Cocoa] Avoid importing directly from subumbrella frameworks
487         https://bugs.webkit.org/show_bug.cgi?id=186016
488
489         Reviewed by Sam Weinig.
490
491         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
492           LaunchServices header.
493         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
494           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
495         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
496           when using SDKs earlier than 10.13.
497         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
498           and OTHER_CPLUSPLUSFLAGS.
499         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm: Import Carbon.h instead of an
500           HIToolbox header.
501         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
502           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
503         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
504           LaunchServices header.
505
506 2018-05-27  Fujii Hironori  <Hironori.Fujii@sony.com>
507
508         [Win][MiniBrowser] Add MainWindow class
509         https://bugs.webkit.org/show_bug.cgi?id=185814
510
511         Reviewed by Per Arne Vollan.
512
513         This is a sub task of Bug 184770. Added a new class MainWindow to
514         represent the main window which will be shared among WK1 and WK2.
515
516         This change is partial so that it's easy to review this patch.
517         I'll move more functions into MainWindow.cpp, and remove more
518         global variables in forthcoming patches.
519
520         * MiniBrowser/win/CMakeLists.txt: Added MainWindow.cpp.
521         * MiniBrowser/win/Common.cpp: Removed MainWindow related global
522         variables hMainWnd, hURLBarWnd, hBackButtonWnd and
523         hForwardButtonWnd. Added a new global variable gMainWindow.
524         (WndProc): Moved to MainWindow.cpp.
525         (resizeSubViews): Ditto.
526         (ToggleMenuFlag): Removed static to be called from MainWindow.cpp.
527         (ToggleMenuItem): Ditto.
528         (CustomUserAgent): Follow the global variables removal.
529         (DisplayAuthDialog): Ditto.
530         (loadURL): Ditto.
531         (WndProc): Renamed to MainWindow::WndProc.
532         * MiniBrowser/win/MainWindow.cpp: Added.
533         (MainWindow::registerClass): Renamed from MyRegisterClass of WinMain.cpp.
534         (MainWindow::init): Extracted MainWindow initialization code from wWinMain.
535         (MainWindow::resizeSubViews): Moved from Common.cpp.
536         (MainWindow::WndProc): Ditto.
537         * MiniBrowser/win/MainWindow.h: Added.
538         (MainWindow::hwnd):
539         (MainWindow::browserWindow):
540         * MiniBrowser/win/MiniBrowser.cpp:
541         (MiniBrowser::init):
542         (MiniBrowser::prepareViews): Extract some code into MiniBrowser::loadDefaultHTML.
543         (MiniBrowser::loadDefaultHTML): Extracted from MiniBrowser::prepareViews.
544         * MiniBrowser/win/MiniBrowser.h:
545         * MiniBrowser/win/WinMain.cpp:
546         (wWinMain): Extracted MainWindow initialization code into MainWindow::init.
547         (MyRegisterClass): Moved to MainWindow.cpp.
548
549 2018-05-27  Fujii Hironori  <Hironori.Fujii@sony.com>
550
551         [Win][MiniBrowser] Remove URL argument of MiniBrowser::init
552         https://bugs.webkit.org/show_bug.cgi?id=185969
553
554         Reviewed by Alex Christensen.
555
556         MiniBrowser::init takes URL argument, but it's used only for
557         loading default HTML if URL is not given.
558
559         - Add a new method MiniBrowser::loadHTMLString
560         - Remove loadHTMLString process from MiniBrowser::prepareViews
561
562         * MiniBrowser/win/MiniBrowser.cpp:
563         (MiniBrowser::init): Removed `requestedURL` argument.
564         (MiniBrowser::prepareViews): Ditto.
565         (MiniBrowser::loadHTMLString): New.
566         (MiniBrowser::loadURL): Return E_INVALIDARG if passedURL is null instead of calling loadHTMLString.
567         * MiniBrowser/win/MiniBrowser.h: Removed URL argument. Added loadHTMLString.
568         * MiniBrowser/win/WinMain.cpp:
569         (wWinMain): Call MiniBrowser::loadHTMLString if URL is not given.
570
571 2018-05-27  David Kilzer  <ddkilzer@apple.com>
572
573         svn-apply fails when a patch has an empty file
574         <https://webkit.org/b/29684>
575
576         Reviewed by Daniel Bates.
577
578         Prior to this change, applying the following patches resulted in:
579         - svn: add empty file     (failure)
580         - svn: delete empty file  (failure)
581         - svn: rename empty file  (failure)
582         - git: add empty file     (false-positive success)
583         - git: delete empty file  (success)
584         - git: rename empty file  (failure)
585
586         * Scripts/VCSUtils.pm:
587         (parseSvnDiffHeader): Handle the case when there is no patch
588         following the header.  If the file exists and is empty, that
589         means it's a deletion.  If the file does not exist, that means
590         it's an addition. Everything else is a fatal error.
591         * Scripts/svn-apply:
592         (patch):
593         - Only apply a patch for deletion if it has one or more text
594           chunks.
595         - Add a case to handle adding an empty file (an addition with no
596           text chunks), and verify the file doesn't exist yet.
597         - Any unhandled patch is a fatal error.
598         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
599         Add tests for adding an empty file and deleting an empty file.
600         * Scripts/webkitperl/VCSUtils_unittest/resources/empty.txt: Add.
601         Used by parseSvnDiffHeader.pl unit test for "add an empty file"
602         test case.
603
604 2018-05-25  Aakash Jain  <aakash_jain@apple.com>
605
606         Display detailed error logs when a script fails in EWS
607         https://bugs.webkit.org/show_bug.cgi?id=175696
608         <rdar://problem/34841885>
609
610         Reviewed by Darin Adler.
611
612         * Scripts/webkitpy/tool/bot/queueengine.py: Set output_limit to 5000 characters instead of default 500 characters.
613         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py: Ditto.
614         * Scripts/webkitpy/tool/commands/download.py: Ditto.
615         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: Ditto.
616         * Scripts/webkitpy/tool/commands/queues.py: Ditto.
617         * Scripts/webkitpy/tool/commands/stepsequence.py: Ditto.
618
619 2018-05-25  Daniel Bates  <dabates@apple.com>
620
621         test-webkitpy messages logged using __main__ logger are not displayed
622         https://bugs.webkit.org/show_bug.cgi?id=185823
623
624         Rubber-stamped by Aakash Jain.
625
626         Configure the logger for __main__ so that messages that are logged before it parses its
627         command line arguments are printed to standard error.
628
629         Currently test-webkitpy creates a named logger (__main__) for its logging. However it does
630         not configure a stream to use for printing until after it parses its command line arguments
631         via webkitpy.test.printer.Printer.configure(). Messages logged until then are never written
632         to the console. We explicitly configure the __main__ logger instead of calling webkitpy.test.printer.Printer.configure()
633         earlier because the latter both configures a stream and filters logged messages based on
634         the specified verbosity. Logged messaged from code in __main__ should not be subject to
635         such filtering. So, we explicitly configure the __main__ logger.
636
637         * Scripts/webkitpy/test/main.py:
638         (main):
639
640 2018-05-25  Saam Barati  <sbarati@apple.com>
641
642         Make JSC have a mini mode that kicks in when the JIT is disabled
643         https://bugs.webkit.org/show_bug.cgi?id=185931
644
645         Reviewed by Mark Lam.
646
647         This renames a variable for clarity.
648
649         * Scripts/run-testmem:
650
651 2018-05-25  Alex Christensen  <achristensen@webkit.org>
652
653         URL::host should return a StringView to reduce allocations
654         https://bugs.webkit.org/show_bug.cgi?id=185986
655
656         Reviewed by Geoff Garen.
657
658         * TestWebKitAPI/Tests/WebCore/URL.cpp:
659         (TestWebKitAPI::TEST_F):
660         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
661         (TestWebKitAPI::eq):
662         * TestWebKitAPI/Tests/mac/SSLKeyGenerator.mm:
663         (TestWebKitAPI::SSLKeyGeneratorTest::TearDown):
664
665 2018-05-25  Ms2ger  <Ms2ger@igalia.com>
666
667         Minor improvements to wpt exporter.
668         https://bugs.webkit.org/show_bug.cgi?id=185978
669
670         Reviewed by Youenn Fablet.
671
672         * Scripts/webkitpy/w3c/test_exporter.py:
673         (TestExporter.push_to_wpt_fork): Update call to create_upload_remote().
674         (TestExporter.make_pull_request): Improve the description of the created PR.
675         (TestExporter.create_upload_remote): Always update the remote to override any obsolete state.
676
677 2018-05-25  Saam Barati  <sbarati@apple.com>
678
679         Have a memory test where we can validate JSCs mini memory mode
680         https://bugs.webkit.org/show_bug.cgi?id=185932
681
682         Reviewed by Mark Lam.
683
684         This patch adds the run-testmem script. This runs the new testmem
685         CLI against the contents in the testmem benchmark. The contents of testmem
686         contain tests from ARES-6, Sunspider, Octane, and JetStream.
687         
688         One iteration of the benchmark comprises of running each testmem test for
689         a certain number of iterations. We collect the peak memory usage, the memory
690         usage after running all the iterations, and the time it takes to run all the
691         iterations. We then run the entire benchmark 3 times over. For each test, we
692         compute the arithmetic mean over each iteration for time, peak memory, and
693         end memory. The benchmark then computes a time score and memory score.
694         
695         peak memory score = geomean({peak memory of each individual test})
696         end memory score = geomean({end memory of each individual test})
697         memory score = geomean({peak memory score, end memory score})
698         time score = geomean({time score of each individual test})
699         
700         We want the memory score to weigh improvements to peak memory usage and
701         memory usage at the end equally.
702         
703         We plan to tune this benchmark in JSC's mini mode by improving the memory
704         score while ensuring the time score is not more than 10-15% regressed.
705
706         * Scripts/run-testmem: Added.
707
708 2018-05-25  Sihui Liu  <sihui_liu@apple.com>
709
710         [WKHTTPCookieStore getAllCookies] returns inconsistent creation time
711         https://bugs.webkit.org/show_bug.cgi?id=185041
712         <rdar://problem/34684214>
713
714         Reviewed by Geoffrey Garen.
715
716         Add API test coverage.
717
718         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
719         (TEST):
720
721 2018-05-24  Chris Dumez  <cdumez@apple.com>
722
723         Reduce copying of FontCascadeDescription objects by moving them around
724         https://bugs.webkit.org/show_bug.cgi?id=185963
725
726         Reviewed by Simon Fraser.
727
728         Reduce copying of FontCascadeDescription objects by moving them around when possible.
729
730         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
731         (TestWebKitAPI::TEST_F):
732
733 2018-05-24  Carlos Garcia Campos  <cgarcia@igalia.com>
734
735         WebDriver: implement maximize, minimize and fullscreen window commands
736         https://bugs.webkit.org/show_bug.cgi?id=180398
737
738         Reviewed by Brian Burg.
739
740         * Scripts/webkitpy/port/xvfbdriver.py:
741         (XvfbDriver._setup_environ_for_test): Set UNDER_XVFB environment variable when running under Xvfb.
742
743 2018-05-24  Xabier Rodriguez Calvar  <calvaris@igalia.com>
744
745         [GStreamer] Save some time disabling some compile options in the dependencies
746         https://bugs.webkit.org/show_bug.cgi?id=185909
747
748         Reviewed by Philippe Normand.
749
750         * gstreamer/jhbuild.modules: Added  --disable-tests to gstreamer
751         and --disable-examples --disable-gtk-doc to gstreamer-vaapi.
752
753 2018-05-23  Roy Reapor  <rreapor@apple.com>
754
755         Use Helvetica on build.webkit.org webpages
756         https://bugs.webkit.org/show_bug.cgi?id=185894
757
758         Reviewed by Aakash Jain.
759
760         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
761         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
762         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html:
763
764 2018-05-23  Aakash Jain  <aakash_jain@apple.com>
765
766         Add Buildbot configuration for Opensource EWS
767         https://bugs.webkit.org/show_bug.cgi?id=185484
768
769         Rubber-stamped by Alexey Proskuryakov.
770
771         * BuildSlaveSupport/ews-build/config.json: Added, config file.
772         * BuildSlaveSupport/ews-build/factories.py: Added, basic template for factories.
773         * BuildSlaveSupport/ews-build/loadConfig.py: Added.
774         (loadBuilderConfig): Loads the configuration.
775         (checkValidWorker): Checks if the worker is valid.
776         (checkValidBuilder): Checks if the builder is valid.
777         (checkWorkersAndBuildersForConsistency): Check if workers and builders are consistent.
778         (checkWorkersAndBuildersForConsistency._find_worker_with_name):
779         (getBlackListedTags): Returns a list of keywords which should not be listed as tags.
780         (getValidTags): Returns a list of valid tags.
781         (getTagsForBuilder): Return a list of tags for given builder.
782         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: unit-tests for loadConfig.py.
783         * BuildSlaveSupport/ews-build/master.cfg: Configuration for buildbot.
784
785 2018-05-23  Michael Catanzaro  <mcatanzaro@igalia.com>
786
787         [GTK] Silence GCC 8 warnings
788         https://bugs.webkit.org/show_bug.cgi?id=185556
789
790         Reviewed by Žan Doberšek.
791
792         GCC is complaining about this strncpy. It's guaranteed to be safe, because the length of
793         source and destination are always identical. But switching to snprintf avoids the warning.
794
795         * DumpRenderTree/TestNetscapePlugIn/Tests/FormValue.cpp:
796         (FormValue::NPP_GetValue):
797
798 2018-05-23  Ryan Haddad  <ryanhaddad@apple.com>
799
800         Unreviewed, rolling out r232112.
801
802         The tests added with this change  are failing on the bots.
803
804         Reverted changeset:
805
806         "test262/Runner.pm: add unit tests"
807         https://bugs.webkit.org/show_bug.cgi?id=185783
808         https://trac.webkit.org/changeset/232112
809
810 2018-05-23  Valerie R Young  <valerie@bocoup.com>
811
812         test262/Runner.pm: add unit tests
813         https://bugs.webkit.org/show_bug.cgi?id=185783
814
815         Reviewed by Aakash Jain.
816
817         Add unit tests to be run by test-webkitperl
818
819         * Scripts/test262/Runner.pm:
820         (main):
821          - If harness files cannot be found in a custom, supplies test262 path,
822            then sure the webkit test262 harness files.
823          - Lazily create the test262-results directory.
824          - If an expectation file is supplied via command line, save to the
825            supplied location instead of the detault webkit location.
826         (compileTest):
827         (processResult):
828         (getHarness):
829         * Scripts/webkitperl/test262_unittest/README: Added.
830         * Scripts/webkitperl/test262_unittest/fixtures/expectations-compare.yaml: Added.
831         * Scripts/webkitperl/test262_unittest/fixtures/expectations.yaml: Added.
832         * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-fail-now-failing-with-new-error.js: Added.
833         * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-fail-now-failing.js: Added.
834         * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-fail-now-passing.js: Added.
835         (f):
836         * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-pass-now-failing.js: Added.
837         * Scripts/webkitperl/test262_unittest/fixtures/test/fail.js: Added.
838         * Scripts/webkitperl/test262_unittest/fixtures/test/pass.js: Added.
839         (f):
840         * Scripts/webkitperl/test262_unittest/test262-runner-tests.pl: Added.
841
842 2018-05-22  Roy Reapor  <rreapor@apple.com>
843
844         Test infrastructure websites should use jQuery and jQuery UI hosted on webkit.org
845         https://bugs.webkit.org/show_bug.cgi?id=185788
846
847         Reviewed by Aakash Jain.
848
849         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
850         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
851         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html:
852         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
853         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html:
854         * TestResultServer/static-dashboards/run-embedded-unittests.html:
855         * TestResultServer/static-dashboards/run-unittests.html:
856
857 2018-05-22  Sihui Liu  <sihui_liu@apple.com>
858
859         [iOS] TestWebKitAPI.WebKit.WKHTTPCookieStoreWithoutProcessPool is crashing with reason: 'Completion handler passed to -[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:] was not called'
860         https://bugs.webkit.org/show_bug.cgi?id=185831
861
862         Reviewed by Chris Dumez.
863
864         Updated the test to prevent crash after assertion fails.
865
866         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
867         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
868
869 2018-05-22  Chris Dumez  <cdumez@apple.com>
870
871         Regression(AsyncPolicyDelegates): Box.app login Window is blank
872         https://bugs.webkit.org/show_bug.cgi?id=185832
873         <rdar://problem/40307871>
874
875         Reviewed by Geoffrey Garen.
876
877         Add API test coverage.
878
879         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
880         * TestWebKitAPI/Tests/WebKit/cocoa/WeakObjCPtr.mm:
881         * TestWebKitAPI/Tests/mac/NoPolicyDelegateResponse.mm: Added.
882         (-[NoPolicyDelegateDecisionDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
883         (-[NoPolicyDelegateDecisionDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
884         (-[NoPolicyDelegateDecisionDelegate webView:didFinishLoadForFrame:]):
885         (TestWebKitAPI::TEST):
886         * TestWebKitAPI/cocoa/TestWKWebView.mm:
887         (-[WKWebView _isBackground]):
888
889 2018-05-22  Sihui Liu  <sihui_liu@apple.com>
890
891         Conversion between SecurityOriginData and DatabaseIdentifier is asymmetric when port is null
892         https://bugs.webkit.org/show_bug.cgi?id=185715
893
894         Reviewed by Geoffrey Garen.
895
896         Add API test coverage.
897
898         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
899         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageDatabaseTracker.mm: Added.
900         (-[LocalStorageUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
901         (TEST):
902
903 2018-05-22  Sihui Liu  <sihui_liu@apple.com>
904
905         Unreviewed, added myself as a WebKit committer.
906
907         * Scripts/webkitpy/common/config/contributors.json:
908
909 2018-05-22  Ryan Haddad  <ryanhaddad@apple.com>
910
911         Unreviewed, rolling out r232052.
912
913         Breaks internal builds.
914
915         Reverted changeset:
916
917         "Use more C++17"
918         https://bugs.webkit.org/show_bug.cgi?id=185176
919         https://trac.webkit.org/changeset/232052
920
921 2018-05-22  Thibault Saunier  <tsaunier@igalia.com>
922
923         [GStreamer] Update to GStreamer 1.14.1 in jhbuild
924         https://bugs.webkit.org/show_bug.cgi?id=185689
925
926         Reviewed by Philippe Normand.
927
928         And update the patches, removing the ones that have been merged upstream.
929
930         * gstreamer/jhbuild.modules:
931         * gstreamer/patches/gst-plugins-good-0001-gstgdkpixbufdec-stop-pretending-to-decode-gifs.patch: Removed.
932         * gstreamer/patches/gst-plugins-good-0001-souphttpsrc-cookie-jar-and-context-query-support.patch: Removed. Not needed anymore and closed as OBSELETE upstream.
933         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gstreamer/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch
934         This patch has now been merged in GStreamer master and will be there in GStreamer 1.16.
935         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Renamed from Tools/gstreamer/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch.
936         This patch has now been merged in GStreamer master and will be there in GStreamer 1.16.
937         * gstreamer/patches/gst-plugins-good-0009-qtdemux-fix-assert-when-moof-contains-one-sample.patch: Removed.
938         * gstreamer/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Removed.
939
940 2018-05-21  Yusuke Suzuki  <utatane.tea@gmail.com>
941
942         Use more C++17
943         https://bugs.webkit.org/show_bug.cgi?id=185176
944
945         Reviewed by JF Bastien.
946
947         * DumpRenderTree/mac/Configurations/Base.xcconfig:
948         * ImageDiff/cg/Configurations/Base.xcconfig:
949         * MiniBrowser/Configurations/Base.xcconfig:
950         * MobileMiniBrowser/Configurations/Base.xcconfig:
951         * TestWebKitAPI/Configurations/Base.xcconfig:
952         * WebKitTestRunner/Configurations/Base.xcconfig:
953
954 2018-05-21  Fujii Hironori  <Hironori.Fujii@sony.com>
955
956         [WinCairo] Enable WebKit build by default
957         https://bugs.webkit.org/show_bug.cgi?id=185141
958
959         Reviewed by Per Arne Vollan.
960
961         TestWTF, TestWebCore and TestWebKitLegacy need a dependency to
962         WebKitForwardingHeaders because config.h includes a header of WK2.
963
964         * TestWebKitAPI/PlatformWin.cmake: Make TestWTFLib, TestWebCoreLib and TestWebKitLegacyLib depend on WebKitForwardingHeaders.
965         * TestWebKitAPI/config.h: Use PLATFORM(WIN_CAIRO) instead of BUILDING_WIN_CAIRO_WEBKIT.
966
967 2018-05-21  Jer Noble  <jer.noble@apple.com>
968
969         Complete fix for enabling modern EME by default
970         https://bugs.webkit.org/show_bug.cgi?id=185770
971         <rdar://problem/40368220>
972
973         Reviewed by Eric Carlson.
974
975         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
976
977 2018-05-18  Christopher Reid  <chris.reid@sony.com>
978
979         Unreviewed, add myself as a WebKit committer.
980
981         * Scripts/webkitpy/common/config/contributors.json:
982
983 2018-05-21  Carlos Garcia Campos  <cgarcia@igalia.com>
984
985         Unreviewed, rolling out r222967.
986
987         It's not ready yet
988
989         Reverted changeset:
990
991         "[GTK][WPE] Add API to configure and enable resource load
992         statistics"
993         https://bugs.webkit.org/show_bug.cgi?id=177943
994         https://trac.webkit.org/changeset/222967
995
996 2018-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
997
998         [GTK] MiniBrowser crashes when loading twice quickly
999         https://bugs.webkit.org/show_bug.cgi?id=185763
1000
1001         Reviewed by Michael Catanzaro.
1002
1003         This is very difficult to reproduce manually, but it happens when running WebDriver tests where loads are very
1004         fast and multiple loads are done quickly. The problem is that we use an idle to reset the progress bar, but we
1005         don't reset it when a new load starts. We always reset the last idle on destroy, but if there's another one
1006         leaked, it will crash when scheduled if the window has already been destroyed.
1007
1008         * MiniBrowser/gtk/BrowserWindow.c:
1009         (webViewLoadProgressChanged): Stop any pending reset task when progress != 1.
1010
1011 2018-05-19  Sihui Liu  <sihui_liu@apple.com>
1012
1013         Flaky API test WebKit.WKHTTPCookieStoreWithoutProcessPool: incorrect order of cookies
1014         https://bugs.webkit.org/show_bug.cgi?id=185624
1015         <rdar://problem/39111626>
1016
1017         Reviewed by Chris Dumez.
1018
1019         Modified expectation to make test more robust as cookies can be returned in different orders.
1020
1021         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1022         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1023         (TEST):
1024
1025 2018-05-18  Commit Queue  <commit-queue@webkit.org>
1026
1027         Unreviewed, rolling out r231982.
1028         https://bugs.webkit.org/show_bug.cgi?id=185793
1029
1030         Caused layout test failures (Requested by realdawei on
1031         #webkit).
1032
1033         Reverted changeset:
1034
1035         "Complete fix for enabling modern EME by default"
1036         https://bugs.webkit.org/show_bug.cgi?id=185770
1037         https://trac.webkit.org/changeset/231982
1038
1039 2018-05-18  Eric Carlson  <eric.carlson@apple.com>
1040
1041         Handle failure to extend sandbox gracefully
1042         https://bugs.webkit.org/show_bug.cgi?id=185779
1043         <rdar://problem/40316349>
1044
1045         Unreviewed, fix test results.
1046
1047         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
1048         (TEST_F):
1049
1050 2018-05-18  Jer Noble  <jer.noble@apple.com>
1051
1052         Complete fix for enabling modern EME by default
1053         https://bugs.webkit.org/show_bug.cgi?id=185770
1054         <rdar://problem/40368220>
1055
1056         Reviewed by Eric Carlson.
1057
1058         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1059
1060 2018-05-18  Eric Carlson  <eric.carlson@apple.com>
1061
1062         Handle failure to extend sandbox gracefully
1063         https://bugs.webkit.org/show_bug.cgi?id=185779
1064         <rdar://problem/40316349>
1065
1066         Reviewed by Brent Fulgham.
1067
1068         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1069         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm: Added.
1070         (-[SimulateFailedSandboxMessageHandler userContentController:didReceiveScriptMessage:]):
1071         (-[SimulateFailedSandboxUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1072         (-[SimulateFailedSandboxUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1073         (MediaCaptureSimulateFailedSandbox::SetUp):
1074         (MediaCaptureSimulateFailedSandbox::loadTestAndWaitForMessage):
1075         (TEST_F):
1076         * TestWebKitAPI/Tests/WebKitCocoa/disableGetUserMedia.html:
1077
1078 2018-05-18  Daniel Bates  <dabates@apple.com>
1079
1080         "debug-safari --ios-simulator" creates lldb target to launch Mac Safari
1081         https://bugs.webkit.org/show_bug.cgi?id=185774
1082
1083         Reviewed by Andy Estes.
1084
1085         For now, the script debug-safari is not supported for WebKit for iOS. To
1086         fix this we differentiate between the Apple Mac port and Apple embedded
1087         ports.
1088
1089         * Scripts/webkitdirs.pm:
1090         (safariPath): Substitute isAppleMacWebKit() for isAppleCocoaWebKit().
1091         (isAppleMacWebKit): Added.
1092         (isAppleCocoaWebKit): Write in terms of isAppleMacWebKit() and isEmbeddedWebKit().
1093         (launcherName): Substitute isAppleMacWebKit() for isAppleCocoaWebKit().
1094         (mobileSafariBundle): Substitute isIOSWebKit() for isAppleCocoaWebKit().
1095         (debugSafari): Substitute isAppleMacWebKit() for isAppleCocoaWebKit().
1096         (runSafari): Ditto.
1097         (runMiniBrowser): Ditto.
1098         (debugMiniBrowser): Ditto.
1099         (runWebKitTestRunner): Ditto.
1100         (debugWebKitTestRunner): Ditto.
1101
1102 2018-05-18  Antoine Quint  <graouts@apple.com>
1103
1104         [Web Animations] Turn Web Animations with CSS integration on for test runners
1105         https://bugs.webkit.org/show_bug.cgi?id=184819
1106         <rdar://problem/39597337>
1107
1108         Unreviewed. Rolling out the patch for this bug, it caused some flaky timeouts for animation suspension tests.
1109
1110         * DumpRenderTree/TestOptions.cpp:
1111         (TestOptions::TestOptions):
1112         * DumpRenderTree/TestOptions.h:
1113         * DumpRenderTree/mac/DumpRenderTree.mm:
1114         (runTest):
1115         (shouldOverrideAndDisableWebAnimationsCSSIntegrationPreference): Deleted.
1116         * WebKitTestRunner/TestController.cpp:
1117         (WTR::TestController::resetPreferencesToConsistentValues):
1118         (WTR::updateTestOptionsFromTestHeader):
1119         * WebKitTestRunner/TestOptions.cpp:
1120         (WTR::TestOptions::TestOptions):
1121         (WTR::isLegacyAnimationEngineTestPath): Deleted.
1122         * WebKitTestRunner/TestOptions.h:
1123
1124 2018-05-18  Fujii Hironori  <Hironori.Fujii@sony.com>
1125
1126         [Win][MiniBrowser] Create MainWindow even in transparent mode
1127         https://bugs.webkit.org/show_bug.cgi?id=185597
1128
1129         Reviewed by Per Arne Vollan.
1130
1131         The current implementations doesn't create the MainWindow in
1132         transparent mode. The screenshot is in Bug 58300.
1133
1134         There were three problems:
1135         - Can't control the WebView. ie. going backward and forward.
1136         - Can't quit the program.
1137         - It makes implementation complicated.
1138
1139         * MiniBrowser/win/Common.cpp (resizeSubViews): Resize sub views
1140         even in the transparent mode.
1141         * MiniBrowser/win/WinMain.cpp:
1142         (wWinMain): Create the main window even in the transparent mode.
1143
1144 2018-05-18  Antoine Quint  <graouts@apple.com>
1145
1146         [Web Animations] Turn Web Animations with CSS integration on for test runners
1147         https://bugs.webkit.org/show_bug.cgi?id=184819
1148         <rdar://problem/39597337>
1149
1150         Reviewed by Jon Lee.
1151
1152         Make the test runners turn both the main Web Animations flag and the Web Animations CSS
1153         integration flag on.
1154
1155         We also remove the ability to toggle the Web Animations CSS integration flag using an HTML
1156         comment directly at the top of the file since test runners now set the flag on by default
1157         and a dedicated directory exists for tests that need to run with this flag off.
1158
1159         * DumpRenderTree/TestOptions.cpp:
1160         (TestOptions::TestOptions):
1161         * DumpRenderTree/TestOptions.h:
1162         * DumpRenderTree/mac/DumpRenderTree.mm:
1163         (shouldOverrideAndDisableWebAnimationsCSSIntegrationPreference):
1164         (runTest):
1165         * WebKitTestRunner/TestController.cpp:
1166         (WTR::TestController::resetPreferencesToConsistentValues):
1167         (WTR::updateTestOptionsFromTestHeader):
1168         * WebKitTestRunner/TestOptions.cpp:
1169         (WTR::isLegacyAnimationEngineTestPath):
1170         (WTR::TestOptions::TestOptions):
1171         * WebKitTestRunner/TestOptions.h:
1172
1173 2018-05-17  Nan Wang  <n_wang@apple.com>
1174
1175         AX: [macOS] Expose the primary screen height through AX API
1176         https://bugs.webkit.org/show_bug.cgi?id=185742
1177
1178         Reviewed by Chris Fleizach.
1179
1180         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1181         (attributesOfElement):
1182         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1183         (WTR::attributesOfElement):
1184
1185 2018-05-17  Commit Queue  <commit-queue@webkit.org>
1186
1187         Unreviewed, rolling out r231912.
1188         https://bugs.webkit.org/show_bug.cgi?id=185750
1189
1190         It is prompting the user when there is no WPT changes
1191         (Requested by bmac on #webkit).
1192
1193         Reverted changeset:
1194
1195         "Export changes to web-platform-test as part of the webkit-
1196         patch upload workflow"
1197         https://bugs.webkit.org/show_bug.cgi?id=184914
1198         https://trac.webkit.org/changeset/231912
1199
1200 2018-05-17  Valerie R Young  <valerie@bocoup.com>
1201
1202         test262/Runner.pm: expand $INC to find webkitdirs.pm
1203         https://bugs.webkit.org/show_bug.cgi?id=185739
1204
1205         Reviewed by Michael Saboff.
1206
1207         * Scripts/test262/Runner.pm:
1208         (getBuildPath):
1209
1210 2018-05-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1211
1212         [WPE] Implement and enable FULLSCREEN_API
1213         https://bugs.webkit.org/show_bug.cgi?id=185676
1214
1215         Reviewed by Žan Doberšek.
1216
1217         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
1218         (testWebViewFullScreen):
1219
1220 2018-05-17  Brendan McLoughlin  <brendan@bocoup.com>
1221
1222         Export changes to web-platform-test as part of the webkit-patch upload workflow
1223         https://bugs.webkit.org/show_bug.cgi?id=184914
1224
1225         Reviewed by Youenn Fablet.
1226
1227         * Scripts/webkitpy/tool/commands/upload.py:
1228         (Upload):
1229         (CreateBug.execute):
1230         (WPTChangeExport):
1231         * Scripts/webkitpy/tool/steps/__init__.py:
1232         * Scripts/webkitpy/tool/steps/wptchangeexport.py: Added.
1233         (WPTChangeExport):
1234         (WPTChangeExport.options):
1235         (WPTChangeExport.run):
1236         * Scripts/webkitpy/w3c/common.py:
1237         * Scripts/webkitpy/w3c/test_exporter.py:
1238         (WebPlatformTestExporter):
1239         (WebPlatformTestExporter.__init__):
1240         (WebPlatformTestExporter.username):
1241         (WebPlatformTestExporter.token):
1242         (WebPlatformTestExporter._github):
1243         (WebPlatformTestExporter._wpt_fork_branch_github_url):
1244         (WebPlatformTestExporter._wpt_fork_remote):
1245         (WebPlatformTestExporter._wpt_fork_push_url):
1246         (WebPlatformTestExporter._git):
1247         (WebPlatformTestExporter._branch_name):
1248         (WebPlatformTestExporter._public_branch_name):
1249         (WebPlatformTestExporter.has_wpt_changes):
1250         (WebPlatformTestExporter._create_patch):
1251         (WebPlatformTestExporter.create_git_patch):
1252         (WebPlatformTestExporter._prompt_for_token):
1253         (WebPlatformTestExporter._prompt_for_username):
1254         (WebPlatformTestExporter._ensure_username_and_token):
1255         (WebPlatformTestExporter._validate_and_save_token):
1256         (WebPlatformTestExporter.push_to_wpt_fork):
1257         (WebPlatformTestExporter.make_pull_request):
1258         (WebPlatformTestExporter.delete_local_branch):
1259         (parse_args):
1260         (TestExporter): Deleted.
1261         (TestExporter.__init__): Deleted.
1262         (TestExporter._ensure_wpt_repository): Deleted.
1263         (TestExporter._fetch_wpt_repository): Deleted.
1264         (TestExporter._ensure_new_branch_name): Deleted.
1265         (TestExporter.download_and_commit_patch): Deleted.
1266         (TestExporter.clean): Deleted.
1267         (TestExporter.create_branch_with_patch): Deleted.
1268         (TestExporter.push_to_wpt_fork): Deleted.
1269         (TestExporter.make_pull_request): Deleted.
1270         (TestExporter.create_wpt_pull_request): Deleted.
1271         (TestExporter.delete_local_branch): Deleted.
1272         (TestExporter.create_git_patch): Deleted.
1273         (TestExporter.create_upload_remote_if_needed): Deleted.
1274         (TestExporter.do_export): Deleted.
1275         * Scripts/webkitpy/w3c/test_exporter_unittest.py:
1276         (TestExporterTest.test_export):
1277         (TestExporterTest.test_export_with_specific_branch):
1278         (TestExporterTest):
1279         (TestExporterTest.test_export_interactive_mode):
1280         (TestExporterTest.test_export_invalid_token):
1281         (TestExporterTest.test_export_wrong_token):
1282
1283 2018-05-17  Valerie R Young  <valerie@bocoup.com>
1284
1285         test262/Runner.pm: look for jsc in path if cannot call webkit-build-directory
1286         https://bugs.webkit.org/show_bug.cgi?id=185650
1287
1288         Reviewed by Michael Saboff.
1289
1290         First, use jsc from CLI arg, then try to use webkit-build-directory,
1291         if that doesn't work, look for jsc in the $PATH
1292
1293         * Scripts/test262/Runner.pm:
1294         (processCLI):
1295         (getBuildPath):
1296         (runTest):
1297
1298 2018-05-16  Leo Balter  <leonardo.balter@gmail.com>
1299
1300         Test262-Runner: Adds a --timeout option
1301         https://bugs.webkit.org/show_bug.cgi?id=185696
1302
1303         Reviewed by Michael Saboff.
1304
1305         The timeout option is used to set a timeout execution in ms for each test run in JSC.
1306         The passed value - if defined - will be used as the value for the JSC --watchdog arg.
1307         * Scripts/test262/Runner.pm:
1308         (processCLI):
1309         (runTest):
1310
1311 2018-05-16  Leo Balter  <leonardo.balter@gmail.com>
1312
1313         Test262-Runner: Set timer for each test run
1314         https://bugs.webkit.org/show_bug.cgi?id=185692
1315
1316         Reviewed by Michael Saboff.
1317
1318         Sets a high resolution timer for each execution call of JSC, reporting
1319         the time in the results report to allow identifying slow tests.
1320         * Scripts/test262/Runner.pm:
1321         (main):
1322         (processFile):
1323         (runTest):
1324         (processResult):
1325
1326 2018-05-16  Andy VanWagoner  <andy@vanwagoner.family>
1327
1328         Add support for Intl NumberFormat formatToParts
1329         https://bugs.webkit.org/show_bug.cgi?id=185375
1330
1331         Reviewed by Yusuke Suzuki.
1332
1333         Add flag for NumberFormat formatToParts.
1334
1335         * Scripts/webkitperl/FeatureList.pm:
1336         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1337
1338 2018-05-14  Yusuke Suzuki  <utatane.tea@gmail.com>
1339
1340         [Win] Use C++17 in MSVC
1341         https://bugs.webkit.org/show_bug.cgi?id=185232
1342
1343         Reviewed by Alex Christensen.
1344
1345         Do not use `using namespace std;`. In C++17, we have std::byte. This "byte"
1346         conflicts with ::byte defined in Windows' header.
1347
1348         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp:
1349         (WindowedPluginTest::WindowedPluginTest):
1350         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1351         (logEventProc):
1352         (stringEvent):
1353         (AccessibilityController::winNotificationReceived):
1354         * DumpRenderTree/win/TextInputController.cpp:
1355         (markedRangeCallback):
1356         (firstRectForCharacterRangeCallback):
1357         (selectedRangeCallback):
1358         * DumpRenderTree/win/TextInputController.h:
1359         * DumpRenderTree/win/TextInputControllerWin.cpp:
1360         (TextInputController::markedRange):
1361         (TextInputController::firstRectForCharacterRange):
1362         (TextInputController::selectedRange):
1363
1364 2018-05-16  Sihui Liu  <sihui_liu@apple.com>
1365
1366         Session cookies aren't reliably set when using default WKWebSiteDataStore
1367         https://bugs.webkit.org/show_bug.cgi?id=185624
1368         <rdar://problem/39111626>
1369
1370         Reviewed by Geoffrey Garen.
1371
1372         Modified and enabled WebKit.WKHTTPCookieStoreWithoutProcessPool.
1373
1374         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1375         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1376         (TEST):
1377
1378 2018-05-16  Valerie R Young  <valerie@bocoup.com>
1379
1380         test262/Runner.pm: save to supplied expectation file if supplied
1381         https://bugs.webkit.org/show_bug.cgi?id=185660
1382
1383         Reviewed by Michael Saboff.
1384
1385         * Scripts/test262/Runner.pm:
1386         (processCLI):
1387         (main):
1388
1389 2018-05-15  Ryan Haddad  <ryanhaddad@apple.com>
1390
1391         Unreviewed, rolling out r231763.
1392
1393         The test added with this change is failing an assertion.
1394
1395         Reverted changeset:
1396
1397         "NSEvent event trackers don't work from WebKitTestRunner"
1398         https://bugs.webkit.org/show_bug.cgi?id=185383
1399         https://trac.webkit.org/changeset/231763
1400
1401 2018-05-15  David Kilzer  <ddkilzer@apple.com>
1402
1403         TestWebKitAPI: Fix warnings found by new clang compiler
1404         <https://webkit.org/b/185631>
1405
1406         Reviewed by Michael Catanzaro.
1407
1408         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
1409         (TestWebKitAPI::TEST):
1410         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
1411         (TestWebKitAPI::TEST):
1412         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
1413         (TestWebKitAPI::TEST):
1414         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
1415         (TestWebKitAPI::TEST):
1416         - Add #pragma statements to ignore the new
1417           -Wself-assign-overloaded warning and to ignore
1418           this as an unknown warning on older clang versions.  We want
1419           to keep these self assigments as this code is designed to test
1420           that use case.
1421
1422         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
1423         (TestWebKitAPI::didFindStringMatches):
1424         - Replace the "rect = rect;" statement that was used to avoid an
1425           unused variable warning with two expectations.
1426
1427         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1428         (-[PinnedStateObserver observeValueForKeyPath:ofObject:change:context:]):
1429         - Switch from -integerValue to -unsignedIntegerValue when
1430           comparing against _WKRectEdgeAll since it's an enum declared
1431           as an NSUInteger.
1432
1433 2018-05-15  Michael Catanzaro  <mcatanzaro@igalia.com>
1434
1435         Unreviewed, rolling out r230749
1436
1437         This did not work as desired.
1438
1439         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1440         (TestWebKitAPI::TEST):
1441
1442 2018-05-15  Antoine Quint  <graouts@apple.com>
1443
1444         [Web Animations] Expose Web Animations CSS integration as an experimental feature
1445         https://bugs.webkit.org/show_bug.cgi?id=185647
1446
1447         Reviewed by Dean Jackson.
1448
1449         Rename the Web Animations CSS integration flag.
1450
1451         * DumpRenderTree/TestOptions.cpp:
1452         (TestOptions::TestOptions):
1453         * DumpRenderTree/TestOptions.h:
1454         * DumpRenderTree/mac/DumpRenderTree.mm:
1455         (setWebPreferencesForTestOptions):
1456         * WebKitTestRunner/TestController.cpp:
1457         (WTR::TestController::resetPreferencesToConsistentValues):
1458         (WTR::updateTestOptionsFromTestHeader):
1459         * WebKitTestRunner/TestOptions.h:
1460         (WTR::TestOptions::hasSameInitializationOptions const):
1461
1462 2018-05-14  Brady Eidson  <beidson@apple.com>
1463
1464         Add an API test to guard against regressions while re-entering setDefersLoading:.
1465         <rdar://problem/37033737> and https://bugs.webkit.org/show_bug.cgi?id=185630
1466
1467         Reviewed by Chris Dumez.
1468
1469         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1470         * TestWebKitAPI/Tests/WebKitCocoa/DoubleDefersLoading.mm: Added.
1471         (-[DoubleDefersNavigationDelegate _webView:navigation:didSameDocumentNavigation:]):
1472         (-[DoubleDefersNavigationDelegate webView:didFinishNavigation:]):
1473         (-[DefersScheme initWithBytes:]):
1474         (-[DefersScheme webView:startURLSchemeTask:]):
1475         (-[DefersScheme webView:stopURLSchemeTask:]):
1476         * TestWebKitAPI/Tests/WebKitCocoa/DoubleDefersLoadingPlugin.mm: Added.
1477         (-[DoubleDefersLoadingPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1478         (-[DoubleDefersLoadingPlugIn webProcessPlugInBrowserContextController:didSameDocumentNavigation:forFrame:]):
1479         (-[DoubleDefersLoadingPlugIn dealloc]):
1480
1481 2018-05-14  Daniel Bates  <dabates@apple.com>
1482
1483         [iOS] Add a test to ensure that setTimeout() does not fire more than expected when using UIWebView
1484         https://bugs.webkit.org/show_bug.cgi?id=185599
1485         <rdar://problem/22493890>
1486
1487         Reviewed by Simon Fraser.
1488
1489         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1490         * TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm: Added.
1491         (-[SetTimeoutFunctionWebViewDelegate webViewDidFinishLoad:]):
1492         (-[SetTimeoutFunctionWebViewDelegate webView:didFailLoadWithError:]):
1493         (-[SetTimeoutFunctionWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
1494         (TestWebKitAPI::TEST):
1495         * TestWebKitAPI/ios/set-timeout-function.html: Added.
1496
1497 2018-05-14  Valerie R Young  <valerie@bocoup.com>
1498
1499         test262/Runner.pm: small bugs in CLI and error codes
1500         https://bugs.webkit.org/show_bug.cgi?id=185629
1501
1502         Reviewed by Michael Saboff.
1503
1504         Fix two commandline args with use '-f', correct
1505         error code of failures.
1506
1507         * Scripts/test262/Runner.pm:
1508         (processCLI):
1509         (main):
1510
1511 2018-05-14  Ryan Haddad  <ryanhaddad@apple.com>
1512
1513         Disable API tests that time out after pointer poisioning was disabled.
1514         https://bugs.webkit.org/show_bug.cgi?id=185586
1515
1516         Unreviewed test gardening.
1517
1518         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
1519         (TestWebKitAPI::TEST):
1520         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
1521         (TestWebKitAPI::TEST):
1522         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
1523         (TestWebKitAPI::TEST):
1524         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
1525         (TestWebKitAPI::TEST):
1526
1527 2018-05-14  Leo Balter  <leonardo.balter@gmail.com>
1528
1529         Test262-Runner: Fix RegExp for capturing tests metadata"
1530         https://bugs.webkit.org/show_bug.cgi?id=185622
1531
1532         Reviewed by Michael Saboff.
1533
1534         This patch fixes the RegExp used to capture each test metadata regarding their EOL characters for
1535         both LF and CRLF forms.
1536
1537         The fix also allows the runner to capture the proper results from two specific files using CR and
1538         CRLF line terminators. They are updated in the expectations file.
1539         * Scripts/test262/Runner.pm:
1540         (parseData):
1541
1542 2018-05-14  Jeremy Jones  <jeremyj@apple.com>
1543
1544         NSEvent event trackers don't work from WebKitTestRunner
1545         https://bugs.webkit.org/show_bug.cgi?id=185383
1546         rdar://problem/40025045
1547
1548         Reviewed by Simon Fraser.
1549
1550         Post simulated wheel events to _sendEventToObservers: so they can be handled by NSEvent observers.
1551         NSEvent swipe tracking is used for webkit swipe navigation.
1552
1553         * WebKitTestRunner/mac/EventSenderProxy.mm:
1554         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
1555
1556 2018-05-11  Leo Balter  <leonardo.balter@gmail.com>
1557
1558         Test262 Runner should search for the Debug JSC by default
1559         https://bugs.webkit.org/show_bug.cgi?id=185562
1560
1561         Reviewed by Michael Saboff.
1562
1563         The Test262 Runner is now searching for the Debug build of JSC by
1564         default, not the Release build.
1565
1566         This fix allows a similar call from the previous runner, making
1567         it compatible with the current build bot configuration parameters.
1568
1569         This patch also adds some minor improvements the verbose mode output.
1570
1571         * Scripts/test262/Runner.pm:
1572         (processCLI):
1573         (main):
1574         (getBuildPath):
1575         (processResult):
1576
1577 2018-05-11  Charles Vazac  <cvazac@gmail.com>
1578
1579         Runtime feature flag for Server-Timing
1580         https://bugs.webkit.org/show_bug.cgi?id=184758
1581
1582         Reviewed by Youenn Fablet.
1583
1584         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: added ENABLE_SERVER_TIMING.
1585         * DumpRenderTree/win/DumpRenderTree.cpp: enable Server Timing
1586
1587 2018-05-11  Fujii Hironori  <Hironori.Fujii@sony.com>
1588
1589         [Win][MiniBrowser] Move WK1 related code into MiniBrowser
1590         https://bugs.webkit.org/show_bug.cgi?id=185418
1591
1592         Reviewed by Alex Christensen.
1593
1594         All WK1 related code should be moved into MiniBrowser for the preparation
1595         of Bug 184770.
1596
1597         This change moves the initilization code of MiniBrowse into MiniBrowser::init().
1598
1599         * MiniBrowser/win/Common.cpp:
1600         (getAppDataFolder): Removed `static` keyword to be called from MiniBrowser.cpp.
1601         (setCacheFolder): This is only for WK1. Moved into MiniBrowser.cpp.
1602         * MiniBrowser/win/Common.h: Added.
1603         * MiniBrowser/win/MiniBrowser.cpp:
1604         (MiniBrowser::init): Moved the initilization code from wWinMain.
1605         (MiniBrowser::setCacheFolder): Moved from Common.cpp and made it a method.
1606         * MiniBrowser/win/MiniBrowser.h:
1607         (MiniBrowser::setCacheFolder): Changed to a private method.
1608         (MiniBrowser::subclassForLayeredWindow): Changed to a private method.
1609         * MiniBrowser/win/WinMain.cpp:
1610         (wWinMain): Moved MiniBrowse initilization code into MiniBrowser.cpp.
1611
1612 2018-05-11  Brady Eidson  <beidson@apple.com>
1613
1614         Make sure history navigations reuse the existing process when necessary.
1615         <rdar://problem/39746516> and https://bugs.webkit.org/show_bug.cgi?id=185532
1616
1617         Reviewed by Ryosuke Niwa.
1618
1619         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1620
1621 2018-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1622
1623         [JSC][GLIB] Add introspectable alternatives to functions using vargars
1624         https://bugs.webkit.org/show_bug.cgi?id=185508
1625
1626         Reviewed by Michael Catanzaro.
1627
1628         Add test cases for the new API.
1629
1630         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1631         (testJSCFunction):
1632         (testJSCObject):
1633
1634 2018-05-10  Leo Balter  <leonardo.balter@gmail.com>
1635
1636         [Build Bot] Restore configuration options to the Test262 Runner
1637
1638         During the switch from the previous Test262 runner to the new one,
1639         a call for an extra configurations options got removed.
1640
1641         This call is important to inform the script to find the debug or
1642         release build of JSC. It's being restored in this patch.
1643
1644         https://bugs.webkit.org/show_bug.cgi?id=185513
1645
1646         Reviewed by Yusuke Suzuki.
1647
1648         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1649         (RunTest262Tests):
1650
1651 2018-05-10  Jonathan Bedard  <jbedard@apple.com>
1652
1653         REGRESSION (r230998): Cannot stream API test output
1654         https://bugs.webkit.org/show_bug.cgi?id=185090
1655
1656         Reviewed by Ryosuke Niwa.
1657
1658         Change run-api-tests so that the stdout and stderr of a test will be printed
1659         before it's result. If -v is passed, the output of single test runs will be
1660         streamed. 
1661
1662         * Scripts/webkitpy/api_tests/run_api_tests.py:
1663         (run): Use print_timestamps flag.
1664         (parse_args): Add timestamps option to print timestamps in the log.
1665         * Scripts/webkitpy/api_tests/runner.py:
1666         (Runner): Add running status.
1667         (Runner.__init__): Add number of workers and a flag to detect if a newline
1668         is needed at the beginning of a log line.
1669         (Runner.run): Turn off most logging coming from server process since it is
1670         not constructive for API tests.
1671         (Runner.handle): Add new log message to stream stdout and stderr instead of
1672         caching values until the test run finished.
1673         (_Worker._run_single_test): Log stdout and stderr in real time.
1674         (_Worker._run_shard_with_binary): Log stderr and stdout buffer before ending
1675         the test.
1676         (_Worker.post): Provide a post with explicitly enumerated argument names.
1677         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
1678         (MeteredStream.__init__): Differentiate verbose logging and logging with timestamps.
1679         (MeteredStream.write): Allow for verbose logging without timestamps.
1680         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
1681         (RegularTest): Add print_timestamps flag.
1682         (RegularTest.setUp):
1683         (RegularTest.test_logging_not_included):
1684         (VerboseTest.test_log_args):
1685         (VerboseWithOutTimestamp):
1686         (VerboseWithOutTimestamp.test_basic): Add test for verbose logging without timestamps.
1687
1688 2018-05-10  Ryosuke Niwa  <rniwa@webkit.org>
1689
1690         build-webkit can erroneously warn about Xcode being too old
1691         https://bugs.webkit.org/show_bug.cgi?id=185533
1692
1693         Reviewed by Dan Bernstein.
1694
1695         Don't assume the version number is always a single digit.
1696
1697         * Scripts/webkitdirs.pm:
1698         (determineXcodeVersion):
1699
1700 2018-05-10  Ross Kirsling  <ross.kirsling@sony.com>
1701
1702         [WinCairo][Buildbot] Test bots need to acquire WinCairoRequirements.
1703         https://bugs.webkit.org/show_bug.cgi?id=185528
1704
1705         Reviewed by Lucas Forschler.
1706
1707         * BuildSlaveSupport/build.webkit.org-config/factories.py:
1708         (TestFactory.__init__):
1709         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1710         (InstallWinCairoDependencies):
1711
1712 2018-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1713
1714         Fix some -Wstring-op-truncation warnings
1715         https://bugs.webkit.org/show_bug.cgi?id=185496
1716
1717         Reviewed by Alex Christensen.
1718
1719         We have an off-by-one in the use of strncpy. The strings would not be null-terminated if
1720         the input was too long. Ensure the buffers are zero-initialized so we don't need to manually
1721         set the last bucket to NUL.
1722
1723         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
1724         (TestWebKitAPI::testAtomicStringNumber):
1725         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1726         (TestWebKitAPI::testStringNumberFixedPrecision):
1727         (TestWebKitAPI::testStringNumberFixedWidth):
1728         (TestWebKitAPI::testStringNumber):
1729
1730 2018-05-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1731
1732         [Win][MiniBrowser] Add a separate WndProc for the layered window
1733         https://bugs.webkit.org/show_bug.cgi?id=185460
1734
1735         Reviewed by Brent Fulgham.
1736
1737         All WK1 related code should be moved into MiniBrowser for the
1738         preparation of Bug 184770.
1739
1740         The layered window was using WndProc of the main window. The
1741         layered window is specific only for WK1. the main window will be
1742         shared among WK1 and WK2.
1743
1744         This change add a new WndProc for the layer window.
1745
1746         * MiniBrowser/win/Common.cpp:
1747         (WndProc): Removed code for the layered windows.
1748         (subclassForLayeredWindow): Moved into MiniBrowser.cpp.
1749         * MiniBrowser/win/MiniBrowser.cpp:
1750         (MiniBrowser::prepareViews): Removed the fourth argument `viewHwnd`.
1751         (viewWndProc): New WndProc for the layered windows.
1752         (MiniBrowser::subclassForLayeredWindow): Moved from Common.cpp.
1753         * MiniBrowser/win/MiniBrowser.h:
1754         (MiniBrowser::hwnd):
1755         * MiniBrowser/win/WinMain.cpp:
1756         (wWinMain): Added m_viewWnd.
1757
1758 2018-05-10  Stephan Szabo  <stephan.szabo@sony.com>
1759
1760         Support --verbose in run-javascriptcore-tests
1761         https://bugs.webkit.org/show_bug.cgi?id=185492
1762
1763         Reviewed by Daniel Bates.
1764
1765         * Scripts/run-javascriptcore-tests:
1766         (runJSCStressTests):
1767
1768 2018-05-10  Valerie R Young  <valerie@bocoup.com>
1769
1770         test262/Runner.pm: --failing-files uses results file not expectations
1771         https://bugs.webkit.org/show_bug.cgi?id=185395
1772
1773         Reviewed by Michael Saboff.
1774
1775         --failing-files arg now uses results file to find failing tests
1776         to rerun. It will look in the test262-results directory from whereever
1777         the script is run, or a results.yaml file can be supplied via command
1778         line argument.
1779         --expectations arg added for suppling expectation file.
1780
1781         * Scripts/test262/Runner.pm:
1782         (processCLI):
1783         (main):
1784         (loadImportFile):
1785         (findAllFailing):
1786
1787 2018-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1788
1789         [GTK] Add support for settings cookies policy and storage type in MiniBrowser
1790         https://bugs.webkit.org/show_bug.cgi?id=185506
1791
1792         Reviewed by Philippe Normand.
1793
1794         Useful for testing and debugging.
1795
1796         * MiniBrowser/gtk/main.c:
1797         (main):
1798
1799 2018-05-09  Chris Dumez  <cdumez@apple.com>
1800
1801         Unreviewed Windows build fix after r231622.
1802
1803         * DumpRenderTree/win/DumpRenderTree.cpp:
1804         (enableExperimentalFeatures):
1805
1806 2018-05-09  Sihui Liu  <sihui_liu@apple.com>
1807
1808         Update WebKit.WebsiteDataStoreCustomPaths after r231536
1809         https://bugs.webkit.org/show_bug.cgi?id=185486
1810         <rdar://problem/37214391>
1811
1812         Reviewed by Chris Dumez.
1813
1814         Update WebKit.WebsiteDataStoreCustomPaths as _syncNetworkProcessCookies is async now.
1815
1816         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1817         (TEST):
1818
1819 2018-05-09  Leo Balter  <leonardo.balter@gmail.com>
1820
1821         Test262-Runner: Improve the verbose output
1822         https://bugs.webkit.org/show_bug.cgi?id=185491
1823
1824         Reviewed by Michael Saboff.
1825
1826         * Scripts/test262/Import.pm:
1827         (transferFiles):
1828         * Scripts/test262/Runner.pm:
1829         (processResult):
1830
1831 2018-05-09  Leo Balter  <leonardo.balter@gmail.com>
1832
1833         Fix Test262 Runner to have DYLD_FRAMEWORK_PATH always set
1834         https://bugs.webkit.org/show_bug.cgi?id=185488
1835
1836         Reviewed by Michael Saboff.
1837
1838         * Scripts/test262/Runner.pm:
1839         (processCLI):
1840         (getBuildPath):
1841         (runTest):
1842
1843 2018-05-09  Richard Houle  <rhoule@apple.com>
1844
1845         [Cocoa] Some fields are not identified as [WKWebProcessPlugInNodeHandle isTextField]
1846         https://bugs.webkit.org/show_bug.cgi?id=185260
1847         <rdar://problem/39290394>
1848
1849         Reviewed by Tim Horton.
1850
1851         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1852         * TestWebKitAPI/Tests/WebKitCocoa/InjectedBundleNodeHandleIsTextField.mm: Added.
1853         (-[InjectedBundleNodeHandleIsTextField isTextFieldForHTMLInputType:document:jsContext:]):
1854         (-[InjectedBundleNodeHandleIsTextField webProcessPlugIn:didCreateBrowserContextController:]):
1855         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1856         (-[InjectedBundleNodeHandleIsTextFieldDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1857
1858 2018-05-09  Thibault Saunier  <tsaunier@igalia.com>
1859
1860         [tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess
1861         https://bugs.webkit.org/show_bug.cgi?id=185481
1862
1863         Reviewed by Philippe Normand.
1864
1865         [tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess
1866
1867         * Scripts/webkitpy/port/gtk.py:
1868         (GtkPort.setup_environ_for_server):
1869
1870 2018-05-09  Leo Balter  <leonardo.balter@gmail.com>
1871
1872         Set build.webkit.org to use the new Test262-runner
1873         https://bugs.webkit.org/show_bug.cgi?id=184933
1874
1875         Reviewed by Aakash Jain.
1876
1877         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1878         (RunTest262Tests):
1879         (RunTest262Tests.countFailures):
1880         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1881
1882 2018-05-09  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
1883
1884         [GTK][JHBuild] LLVM 3.7.0 build is broken with GCC 8.1
1885         https://bugs.webkit.org/show_bug.cgi?id=185461
1886
1887         Reviewed by Michael Catanzaro.
1888
1889         JHBuild now compiles LLVM 6 and Mesa 18.0.3.
1890
1891         * gtk/jhbuild.modules:
1892
1893 2018-05-09  Michael Catanzaro  <mcatanzaro@igalia.com>
1894
1895         Unreviewed. Update OptionsWPE.cmake and NEWS for 2.21.1 release.
1896
1897         * wpe/manifest.txt.in: Distribute the NEWS.
1898
1899 2018-05-09  Michael Catanzaro  <mcatanzaro@igalia.com>
1900
1901         [WPE] Build cleanly with GCC 8 and ICU 60
1902         https://bugs.webkit.org/show_bug.cgi?id=185462
1903
1904         Reviewed by Carlos Alberto Lopez Perez.
1905
1906         * TestWebKitAPI/CMakeLists.txt: Fix weird build failure, we were missing a directory. Not
1907         sure why this was never noticed until now or why the bots are OK.
1908         * gtk/jhbuild.modules: Add upstream patch to avoid warnings inside G_DEFINE_TYPE.
1909         * gtk/patches/glib-cast-function-type.patch: Added.
1910         * wpe/jhbuild.modules: Add upstream patch to avoid warnings inside G_DEFINE_TYPE.
1911         * wpe/patches/glib-cast-function-type.patch: Added.
1912
1913 2018-05-06  Yusuke Suzuki  <utatane.tea@gmail.com>
1914
1915         [JSC][GTK][JSCONLY] Use capstone disassembler
1916         https://bugs.webkit.org/show_bug.cgi?id=185283
1917
1918         Reviewed by Michael Catanzaro.
1919
1920         * gtk/manifest.txt.in:
1921         * wpe/manifest.txt.in:
1922
1923 2018-05-09  Antti Koivisto  <antti@apple.com>
1924
1925         Add OptionSet::operator& and operator bool
1926         https://bugs.webkit.org/show_bug.cgi?id=185306
1927
1928         Reviewed by Anders Carlsson.
1929
1930         * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
1931         (TestWebKitAPI::TEST):
1932
1933 2018-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1934
1935         Consolidate WebContentReaderIOS and WebContentReaderMac into WebContentReaderCocoa
1936         https://bugs.webkit.org/show_bug.cgi?id=185340
1937
1938         Reviewed by Tim Horton.
1939
1940         Adds a new API test to verify that URLs written using -[NSPasteboard writeObjects:] are pasted as anchors with
1941         non-empty text in a contenteditable.
1942
1943         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
1944         (TestWebKitAPI::TEST):
1945
1946 2018-05-08  Valerie R Young  <valerie@bocoup.com>
1947
1948         test262/Runner.pm: create results dir for results of test262 run
1949         https://bugs.webkit.org/show_bug.cgi?id=185392
1950
1951         Reviewed by Michael Saboff.
1952
1953         New directory test262-results created from where ever script is
1954         called.
1955
1956         * Scripts/test262/Runner.pm:
1957         (processCLI):
1958
1959 2018-05-08  Valerie R Young  <valerie@bocoup.com>
1960
1961         test262/Runner.pm: lower number of processes per core
1962         https://bugs.webkit.org/show_bug.cgi?id=185426
1963
1964         Reviewed by Michael Saboff.
1965
1966         * Scripts/test262/Runner.pm:
1967         (getProcesses):
1968
1969 2018-05-08  Leo Balter  <leonardo.balter@gmail.com>
1970
1971         Test262-Runner: Add base Perl UnicodeData
1972         https://bugs.webkit.org/show_bug.cgi?id=185444
1973
1974         Reviewed by Michael Saboff.
1975
1976         * Scripts/test262/local/lib/perl5/unicore/lib/gc_sc/SpacePer.pl: Added.
1977         * Scripts/test262/local/lib/perl5/unicore/lib/gc_sc/Word.pl: Added.
1978
1979 2018-05-08  Daniel Bates  <dabates@apple.com>
1980
1981         Add tests to ensure that the Strong Password appearance is removed on form reset
1982         https://bugs.webkit.org/show_bug.cgi?id=185440
1983
1984         Reviewed by Ryosuke Niwa.
1985
1986         * TestWebKitAPI/Tests/WebKitCocoa/DidResignInputElementStrongPasswordAppearance.mm:
1987         (-[DidResignInputElementStrongPasswordAppearance webProcessPlugIn:didCreateBrowserContextController:]):
1988         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1989         (TEST):
1990
1991 2018-05-08  Daniel Bates  <dabates@apple.com>
1992
1993         Resign Strong Password appearance when text field value changes
1994         https://bugs.webkit.org/show_bug.cgi?id=185433
1995         <rdar://problem/39958508>
1996
1997         Reviewed by Ryosuke Niwa.
1998
1999         Add a unit test to ensure the injected bundle API and WebKit UI delegate SPI is invoked
2000         when the field has the Strong Password button and its value changes.
2001
2002         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2003         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2004         (TEST):
2005
2006 2018-05-06  Filip Pizlo  <fpizlo@apple.com>
2007
2008         InPlaceAbstractState::beginBasicBlock shouldn't have to clear any abstract values
2009         https://bugs.webkit.org/show_bug.cgi?id=185365
2010
2011         Reviewed by Saam Barati.
2012         
2013         Make it possible to measure compile times.
2014         
2015         Rolling back in after fixing cloop builds.
2016
2017         * Scripts/run-jsc-benchmarks:
2018
2019 2018-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2020
2021         [iOS] WKAttachmentTestsIOS.InsertDroppedItemProvidersInOrder fails after r231396
2022         https://bugs.webkit.org/show_bug.cgi?id=185414
2023
2024         Reviewed by Tim Horton.
2025
2026         Adjust a test expectation to check that the resulting DOM contains an attachment element,
2027         anchor element, and another attachment element in that order. This ensures that the test
2028         still passes, even after the anchor element is followed by a line break.
2029
2030         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2031         (TestWebKitAPI::TEST):
2032
2033 2018-05-08  Commit Queue  <commit-queue@webkit.org>
2034
2035         Unreviewed, rolling out r231491.
2036         https://bugs.webkit.org/show_bug.cgi?id=185434
2037
2038         Setting the Created key on a cookie does not work yet, due a
2039         bug in CFNetwork (Requested by ggaren on #webkit).
2040
2041         Reverted changeset:
2042
2043         "[WKHTTPCookieStore getAllCookies] returns inconsistent
2044         creation time"
2045         https://bugs.webkit.org/show_bug.cgi?id=185041
2046         https://trac.webkit.org/changeset/231491
2047
2048 2018-05-08  Valerie R Young  <valerie@bocoup.com>
2049
2050         test262/Runner.pm: move input files to JSTests/test262
2051         https://bugs.webkit.org/show_bug.cgi?id=185389
2052
2053         Reviewed by Michael Saboff.
2054
2055         * Scripts/test262/Runner.pm:
2056         (processCLI):
2057
2058 2018-05-08  Chris Dumez  <cdumez@apple.com>
2059
2060         Unreviewed, simplify Speedometer fixes landed in r231489, r231483 & r231474.
2061
2062         * Scripts/webkitpy/performance_tests/perftest.py:
2063         (PerfTest):
2064
2065 2018-05-08  Ryan Haddad  <ryanhaddad@apple.com>
2066
2067         Unreviewed, rolling out r231468.
2068
2069         Broke the CLoop build
2070
2071         Reverted changeset:
2072
2073         "InPlaceAbstractState::beginBasicBlock shouldn't have to clear
2074         any abstract values"
2075         https://bugs.webkit.org/show_bug.cgi?id=185365
2076         https://trac.webkit.org/changeset/231468
2077
2078 2018-05-08  Sihui Liu  <sihui_liu@apple.com>
2079
2080         [WKHTTPCookieStore getAllCookies] returns inconsistent creation time
2081         https://bugs.webkit.org/show_bug.cgi?id=185041
2082         <rdar://problem/34684214>
2083
2084         Reviewed by Geoffrey Garen.
2085
2086         Add API test Coverage.
2087
2088         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2089         (TEST):
2090
2091 2018-05-08  Chris Dumez  <cdumez@apple.com>
2092
2093         Unreviewed, fix issue with running Speedometer PerfTest after r231450.
2094
2095         * Scripts/webkitpy/performance_tests/perftest.py:
2096         (PerfTest):
2097
2098 2018-05-08  Chris Dumez  <cdumez@apple.com>
2099
2100         Unreviewed, fix issue with running Speedometer PerfTest after r231450.
2101
2102         * Scripts/webkitpy/performance_tests/perftest.py:
2103         (PerfTest):
2104
2105 2018-05-07  Chris Dumez  <cdumez@apple.com>
2106
2107         Unreviewed, fix issue with running Speedometer PerfTest after r231450.
2108
2109         * Scripts/webkitpy/performance_tests/perftest.py:
2110         (PerfTest):
2111
2112 2018-05-06  Filip Pizlo  <fpizlo@apple.com>
2113
2114         InPlaceAbstractState::beginBasicBlock shouldn't have to clear any abstract values
2115         https://bugs.webkit.org/show_bug.cgi?id=185365
2116
2117         Reviewed by Saam Barati.
2118         
2119         Make it possible to measure compile times.
2120
2121         * Scripts/run-jsc-benchmarks:
2122
2123 2018-05-07  Leo Balter  <leonardo.balter@gmail.com>
2124
2125         Test262-Runner: Add base module to the local deps - unicore/Exact.pl
2126         https://bugs.webkit.org/show_bug.cgi?id=185390
2127
2128         Reviewed by Michael Saboff.
2129
2130         * Scripts/test262/local/lib/perl5/unicore/Exact.pl: Added.
2131
2132 2018-05-07  Jonathan Bedard  <jbedard@apple.com>
2133
2134         Check for com.apple.datamigrator before declaring simulators booted
2135         https://bugs.webkit.org/show_bug.cgi?id=185315
2136         <rdar://problem/39986261>
2137
2138         Reviewed by David Kilzer.
2139
2140         * Scripts/webkitdirs.pm:
2141         (waitUntilProcessNotRunning): Wait until a process is not found.
2142         (relaunchIOSSimulator): Wait until com.apple.datamigrator stops running to declare
2143         a simulator booted.
2144         * Scripts/webkitpy/common/system/executive_mock.py:
2145         (MockExecutive2.__init__): Define _running_pids.
2146         * Scripts/webkitpy/xcode/simulated_device.py:
2147         (SimulatedDeviceManager.initialize_devices): Call wait_until_data_migration_is_done before
2148         declaring that devices have been booted, increase the timeout since data migration will frequently
2149         take longer than 60 seconds, especially with multiple simulators booting.
2150         (SimulatedDeviceManager.swap): Ditto.
2151         (SimulatedDeviceManager):
2152         (SimulatedDeviceManager.wait_until_data_migration_is_done): Wait until there are no com.apple.datamigrator
2153         processes running.
2154
2155 2018-05-07  Daniel Bates  <dabates@apple.com>
2156
2157         REGRESSION (r229955): run-webkit-tests runs tests in skipped directories and subdirectories of directory given on command line
2158         https://bugs.webkit.org/show_bug.cgi?id=185054
2159         <rdar://problem/39773209>
2160
2161         Reviewed by Ryosuke Niwa.
2162
2163         Fallback to MacPort.CURRENT_VERSION if we are not using a known named macOS and do not have Apple Additions.
2164
2165         Darwin-based ports have OS version-specific test expectations and are certified to support running tests using
2166         the currently shipping OS by way of a hardcoded class variable CURRENT_VERSION. The run-webkit-tests script
2167         depends on the OS version to find the applicable TestExpectations files to parse to compute the list of skipped
2168         tests for the port.
2169
2170         * Scripts/webkitpy/port/mac.py:
2171         (MacPort.__init__): Fall back to MacPort.CURRENT_VERSION if we are not using a known named macOS and do not
2172         have Apple Additions.
2173         * Scripts/webkitpy/port/mac_unittest.py:
2174         (MacTest.test_factory_with_future_version): Added.
2175         (MacTest.test_factory_with_future_version_and_apple_additions): Renamed from MacTest.test_factory_with_future_version()
2176         and added code to use the mock Apple Additions so that running this code with- and without- the real Apple Additions
2177         produces consistent results now that the Mac port's OS version falls back to MacPort.CURRENT_VERSION when Apple Additions
2178         is absent.
2179
2180 2018-05-07  Brian Burg  <bburg@apple.com>
2181
2182         Web Inspector: opt out of process swap on navigation if a Web Inspector frontend is connected
2183         https://bugs.webkit.org/show_bug.cgi?id=184861
2184         <rdar://problem/39153768>
2185
2186         Reviewed by Timothy Hatcher.
2187
2188         Add a new test that checks whether a new process is used for navigation when
2189         an Inspector is shown. Also check that the behavior reverts to normal after
2190         the Inspector has been closed.
2191
2192         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2193
2194 2018-05-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2195
2196         [iOS] Multiple links in Mail are dropped in a single line, and are difficult to tell apart
2197         https://bugs.webkit.org/show_bug.cgi?id=185289
2198         <rdar://problem/35756912>
2199
2200         Reviewed by Tim Horton and Darin Adler.
2201
2202         Augment and rebaseline some iOS drag-and-drop API tests that handle dropping URLs as a part of multi-item drop
2203         sessions.
2204
2205         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2206         (TestWebKitAPI::TEST):
2207
2208 2018-05-04  Timothy Hatcher  <timothy@apple.com>
2209
2210         Deprecate legacy WebView and friends
2211         https://bugs.webkit.org/show_bug.cgi?id=185279
2212         rdar://problem/33268700
2213
2214         Reviewed by Tim Horton.
2215
2216         * MiniBrowser/Configurations/Base.xcconfig: Added GCC_PREPROCESSOR_DEFINITIONS
2217         to define DISABLE_LEGACY_WEBKIT_DEPRECATIONS.
2218
2219 2018-05-04  Leo Balter  <leonardo.balter@gmail.com>
2220
2221         Test262-Runner: Add base module to the local deps - unicore/PVA.pl
2222         https://bugs.webkit.org/show_bug.cgi?id=185314
2223
2224         Reviewed by Michael Saboff.
2225
2226         * Scripts/test262/local/lib/perl5/unicore/PVA.pl: Added.
2227
2228 2018-05-04  Wenson Hsieh  <whsieh@berkeley.edu>
2229
2230         REGRESSION: [ios-simulator] 3 WKWebViewAutofillTests API test failures seen with 11.3 SDK
2231         https://bugs.webkit.org/show_bug.cgi?id=184196
2232         <rdar://problem/39054481>
2233
2234         Reviewed by Tim Horton.
2235
2236         Removes some unnecessary workarounds to enable running app autofill tests against iOS versions
2237         earlier than 11.3. Also re-enables these tests.
2238
2239         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2240         (TestWebKitAPI::TEST):
2241         (-[UITextAutofillSuggestion initWithUsername:password:]): Deleted.
2242         (+[UITextAutofillSuggestion autofillSuggestionWithUsername:password:]): Deleted.
2243
2244 2018-05-04  Myles C. Maxfield  <mmaxfield@apple.com>
2245
2246         Text shaping in the simple path is flipped in the y direction
2247         https://bugs.webkit.org/show_bug.cgi?id=185062
2248         <rdar://problem/39778678>
2249
2250         Reviewed by Simon Fraser.
2251
2252         Huge thanks to Ulrike Rausch of LiebeFonts for contributing the test fonts!!!
2253
2254         * Scripts/webkitpy/common/config/contributors.json:
2255
2256 2018-05-04  Leo Balter  <leonardo.balter@gmail.com>
2257
2258         Test262-Runner: place the processCLI inside the main call
2259         https://bugs.webkit.org/show_bug.cgi?id=185304
2260
2261         Reviewed by Michael Saboff.
2262
2263         * Scripts/test262/Runner.pm:
2264         (main):
2265
2266 2018-05-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2267
2268         [GTK] Epiphany (GNOME Web) says "Error downloading: Service Unavailable." when trying to download an image from discogs.com
2269         https://bugs.webkit.org/show_bug.cgi?id=174730
2270
2271         Reviewed by Michael Catanzaro.
2272
2273         Update unit tests to check that User-Agent header is included in HTTP download requests.
2274
2275         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
2276         (testDownloadRemoteFile):
2277         (testWebViewDownloadURI):
2278         (testPolicyResponseDownload):
2279         (testPolicyResponseDownloadCancel):
2280         (testDownloadMIMEType):
2281         (testContextMenuDownloadActions):
2282
2283 2018-05-03  Ross Kirsling  <ross.kirsling@sony.com>
2284
2285         [WinCairo] Test archive must use Python zipfile, just like build product.
2286         https://bugs.webkit.org/show_bug.cgi?id=185265
2287
2288         Reviewed by Per Arne Vollan.
2289
2290         * BuildSlaveSupport/test-result-archive:
2291         (archive_test_results):
2292         Copy over Win32-oriented archiving logic from built-product-archive.
2293
2294 2018-05-03  Leo Balter  <leonardo.balter@gmail.com>
2295
2296         cleanup modules usage for the Test262-Runner
2297         https://bugs.webkit.org/show_bug.cgi?id=185263
2298
2299         Reviewed by Michael Saboff.
2300
2301         * Scripts/test262-runner:
2302         * Scripts/test262/Runner.pm:
2303         (processCLI):
2304
2305 2018-05-03  Valerie R Young  <valerie@bocoup.com>
2306
2307         test262/Runner.pm: minor fixes
2308         https://bugs.webkit.org/show_bug.cgi?id=185250
2309
2310         Reviewed by Michael Saboff.
2311
2312         Add comments, change output and fix bug: unintended interpolation
2313         of filename when running jsc.
2314
2315         * Scripts/test262/Runner.pm:
2316         (processCLI):
2317         (main):
2318         (runTest):
2319
2320 2018-05-03  Chris Dumez  <cdumez@apple.com>
2321
2322         Load hangs if the WebProcess fails to launch
2323         https://bugs.webkit.org/show_bug.cgi?id=185225
2324         <rdar://problem/38249058>
2325
2326         Reviewed by Geoff Garen.
2327
2328         Add API test coverage.
2329
2330         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2331         * TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm: Added.
2332         (-[CrashOnStartNavigationDelegate _webView:webContentProcessDidTerminateWithReason:]):
2333         (-[CrashOnStartNavigationDelegate webView:didFinishNavigation:]):
2334         (-[CrashRecoveryScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2335         (TEST):
2336
2337 2018-05-03  Don Olmstead  <don.olmstead@sony.com>
2338
2339         [WinCairo] Add JSC test bots
2340         https://bugs.webkit.org/show_bug.cgi?id=185234
2341
2342         Reviewed by Per Arne Vollan.
2343
2344         * BuildSlaveSupport/build.webkit.org-config/config.json:
2345         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2346         (RunJavaScriptCoreTests.start):
2347
2348 2018-05-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2349
2350         WebKit should send fake macOS user agent to docs.google.com
2351         https://bugs.webkit.org/show_bug.cgi?id=185165
2352
2353         Reviewed by Carlos Garcia Campos.
2354
2355         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2356         (TestWebKitAPI::TEST):
2357
2358 2018-05-03  Valerie R Young  <valerie@bocoup.com>
2359
2360         test262/Runner.pm: performance improvements
2361         https://bugs.webkit.org/show_bug.cgi?id=185202
2362
2363         Reviewed by Michael Saboff.
2364
2365         Batch the tests by the number of processes, and give each process
2366         a file to save results to to avoid threading. Do not parallelize
2367         when running small sets of tests.
2368
2369         * Scripts/test262/Runner.pm:
2370         (processCLI):
2371         (main):
2372         (processFile):
2373         (processResult):
2374
2375 2018-05-03  Ryan Haddad  <ryanhaddad@apple.com>
2376
2377         Unreviewed, rolling out r231253.
2378
2379         The API test added with this change is crashing on the bots.
2380
2381         Reverted changeset:
2382
2383         "Web Inspector: opt out of process swap on navigation if a Web
2384         Inspector frontend is connected"
2385         https://bugs.webkit.org/show_bug.cgi?id=184861
2386         https://trac.webkit.org/changeset/231253
2387
2388 2018-05-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2389
2390         REGRESSION(r222772): [GTK][WPE] WebProcess from WebKitGtk+ 2.19.9x SIGSEVs in WebKit::WebProcess::ensureNetworkProcessConnection() at Source/WebKit/WebProcess/WebProcess.cpp:1127
2391         https://bugs.webkit.org/show_bug.cgi?id=183348
2392
2393         Reviewed by Michael Catanzaro.
2394
2395         Add a test case to reproduce the crash.
2396
2397         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2398         (testWebViewCloseQuickly):
2399         (beforeAll):
2400
2401 2018-05-02  Aditya Keerthi  <akeerthi@apple.com>
2402
2403         Can't copy and paste URLs that have no title into Mail (macOS)
2404         https://bugs.webkit.org/show_bug.cgi?id=185205
2405         <rdar://problem/36352406>
2406
2407         Reviewed by Tim Horton.
2408
2409         Added test to verify behavior when copying and pasting a URL without a title.
2410
2411         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html:
2412         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
2413         (TestWebKitAPI::TEST):
2414
2415 2018-05-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2416
2417         [GTK] Generate a JSC bundle on the 64 and 32 bit release bots and upload it to webkitgtk.org (follow-up fix)
2418         https://bugs.webkit.org/show_bug.cgi?id=184699
2419
2420         Unreviewed follow-up fix after r231230.
2421
2422         * Scripts/generate-jsc-bundle:
2423         (generate_wrapper_script): Quote the arguments passed to jsc.
2424
2425 2018-05-02  Brian Burg  <bburg@apple.com>
2426
2427         Web Inspector: opt out of process swap on navigation if a Web Inspector frontend is connected
2428         https://bugs.webkit.org/show_bug.cgi?id=184861
2429         <rdar://problem/39153768>
2430
2431         Reviewed by Ryosuke Niwa.
2432
2433         Add a new test that checks whether a new process is used for navigation when
2434         an Inspector is shown. Also check that the behavior reverts to normal after
2435         the Inspector has been closed.
2436
2437         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2438
2439 2018-05-02  Valerie R Young  <valerie@bocoup.com>
2440
2441         test262/Runner.pm: save summary to file
2442         https://bugs.webkit.org/show_bug.cgi?id=185200
2443
2444         Reviewed by Michael Saboff.
2445
2446         * Scripts/test262/Runner.pm:
2447         (processCLI):
2448         (main):
2449         (summarizeResults):
2450
2451 2018-05-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2452
2453         [GTK] Generate a JSC bundle on the 64 and 32 bit release bots and upload it to webkitgtk.org
2454         https://bugs.webkit.org/show_bug.cgi?id=184699
2455
2456         Reviewed by Gustavo Noronha Silva.
2457
2458         This adds a new step for the GTK 64-bit release build bot and the
2459         GTK 32-bit release build&test bot.
2460
2461         This step will be run as one of the lasts ones (after the product
2462         is built) and will execute the script generate-jsc-bundle.
2463         This script will take care of creating a JSC bundle and uploading
2464         it to a server defined on a configuration file that has to be
2465         deployed on the bots with the required server data and credentials
2466         for this upload.
2467
2468         In this case, the built products should then be accessible at
2469         <https://webkitgtk.org/jsc-built-products>. But the implementation
2470         is not tied to any specific server. All the details about where
2471         to upload the file is done in configuration file that is kept
2472         private on each bot outside of the WebKit source tree.
2473
2474         The script also supports generating a JSC bundle locally and not
2475         uploading it anywhere. This is the default mode of running.
2476         The remote upload will only be activated if a --remote-config-file
2477         parameter is passed (which is done from the buildbot config)
2478
2479         * BuildSlaveSupport/build.webkit.org-config/config.json:
2480         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2481         (BuildFactory):
2482         (BuildFactory.__init__):
2483         (TestFactory):
2484         (TestFactory.__init__):
2485         (BuildAndGenerateJSCBundleFactory):
2486         (BuildAndNonLayoutTestAndGenerateJSCBundleFactory):
2487         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2488         (GenerateJSCBundle):
2489         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2490         * Scripts/generate-jsc-bundle: Added.
2491         (ldd_get_libs_and_interpreter):
2492         (generate_readme):
2493         (generate_wrapper_script):
2494         (copy_and_remove_rpath):
2495         (createJSCBundle):
2496         (sha256sum):
2497         (uploadJSCBundle):
2498         (main):
2499
2500 2018-05-01  Ryosuke Niwa  <rniwa@webkit.org>
2501
2502         PSON: Make WebKitTestRunner work with process swap on navigation turned on
2503         https://bugs.webkit.org/show_bug.cgi?id=185111
2504
2505         Reviewed by Chris Dumez.
2506
2507         Add the basic support for running layout tests with process-swap-on-navigation turned on.
2508
2509         First, move m_whatToDump, m_dumpPixels, m_waitToDump, and m_dumpFrameLoadCallbacks from WebContent process
2510         to UI process so that calls to waitUntilDone, dumpAsText, etc... persist across process swaps.
2511
2512         In addition, initialize the injected bundle inside a new WebContent process when the first page is created.
2513         This instantiates objects such as TestRunner, GCController, etc... in the new process. The initialization
2514         can't be done in InjectedBundle::beginTesting because some steps in InjectedBundle::initialize require
2515         the current PageGroup and Page objects. We avoid clearing databases and app cache in this case.
2516
2517         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2518         (WTR::InjectedBundle::didCreatePage): Send "Initialization" message to UI process. This message returns
2519         all the dictionary values usually present in "BeginTest" message from UI process as well as "ResumeTesting"
2520         boolean which is set when this process was created as a result of a process swap on navgation. Invoke
2521         beginTesting with BegingTestingMode::Resume when this boolean is set.
2522         (WTR::InjectedBundle::didReceiveMessageToPage):
2523         (WTR::InjectedBundle::beginTesting): Don't clear database, app cache, etc... when initializing an injected
2524         bundle after a process swap on navigation.
2525         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2526         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2527         (WTR::InjectedBundlePage::dump):
2528         (WTR::InjectedBundlePage::frameDidChangeLocation):
2529         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2530         (WTR::TestRunner::TestRunner):
2531         (WTR::TestRunner::shouldDumpPixels const): Added.
2532         (WTR::TestRunner::setDumpPixels): Added.
2533         (WTR::TestRunner::dumpAsText):
2534         (WTR::TestRunner::whatToDump const): Added.
2535         (WTR::TestRunner::setWhatToDump): Added.
2536         (WTR::TestRunner::waitUntilDone):
2537         (WTR::TestRunner::setWaitUntilDone): Added.
2538         (WTR::TestRunner::shouldWaitUntilDone): Added.
2539         (WTR::TestRunner::notifyDone):
2540         (WTR::TestRunner::forceImmediateCompletion):
2541         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks): Added.
2542         (WTR::TestRunner::shouldDumpFrameLoadCallbacks): Added.
2543         (WTR::TestRunner::setAudioResult):
2544         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2545         (WTR::TestRunner::dumpChildFramesAsText):
2546         (WTR::TestRunner::dumpDOMAsWebArchive):
2547         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks): Moved to cpp.
2548         (WTR::TestRunner::whatToDump const): Moved to cpp.
2549         (WTR::TestRunner::shouldDumpMainFrameScrollPosition const):
2550         (WTR::TestRunner::shouldDumpPixels const): Moved to cpp.
2551         (WTR::TestRunner::shouldDumpFrameLoadCallbacks const): Moved to cpp.
2552         (WTR::TestRunner::waitToDump const): Renamed to shouldWaitUntilDone and moved to cpp.
2553         * WebKitTestRunner/TestInvocation.cpp:
2554         (WTR::TestInvocation::TestInvocation): Initialize m_dumpFrameLoadCallbacks here.
2555         (WTR::TestInvocation::shouldLogFrameLoadDelegates const): Deleted.
2556         (WTR::TestInvocation::createTestSettingsDictionary): Extracted from invoke().
2557         (WTR::TestInvocation::invoke): Sets m_startedTesting to true immediately afte sending "BeginTest" message.
2558         m_startedTesting is later used in didReceiveSynchronousMessageFromInjectedBundle to detect whether a given
2559         "Initialization" message is sent from a regular WebContent process (m_startedTesting is false) or the one
2560         started as a result of a process swap on navigation (m_startedTesting is true).
2561         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): Added a bunch of new messgaes to
2562         support initializing the injected bundle in a process swapped after navigation and set/get messages for
2563         the states which must persist across process swaps within a test.
2564         * WebKitTestRunner/TestInvocation.h:
2565         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2566         * Tools/WebKitTestRunner/WhatToDump.h:
2567         (WTR::WhatToDump): Added.
2568
2569 2018-05-01  Leo Balter  <leonardo.balter@gmail.com>
2570
2571         Auto save the results for Test262
2572         https://bugs.webkit.org/show_bug.cgi?id=184926
2573
2574         Reviewed by Michael Saboff.
2575
2576         * Scripts/test262/Runner.pm:
2577         (processCLI):
2578         (main):
2579         (parseError):
2580         (processResult):
2581         (summarizeResults):
2582         * Scripts/test262/config.yaml: Renamed from Tools/Scripts/test262/test262-config.yaml.
2583
2584 2018-05-01  Jonathan Bedard  <jbedard@apple.com>
2585
2586         webkitpy: SIGKILL right after SIGTERM causes orphaned processes with 'xcrun simctl spawn'
2587         https://bugs.webkit.org/show_bug.cgi?id=185164
2588
2589         Reviewed by David Kilzer.
2590
2591         * Scripts/webkitpy/common/system/executive.py:
2592         (Executive.kill_process): First attempt will always send a SIGTERM, all subsequent attempts will
2593         send a SIGKILL. A SIGKILL with not be sent if the process is not running to avoid orphaning childen.
2594
2595 2018-05-01  Chris Dumez  <cdumez@apple.com>
2596
2597         REGRESSION (r230919): API test WebKit.AutoLayoutIntegration is a flaky failure
2598         https://bugs.webkit.org/show_bug.cgi?id=184918
2599         <rdar://problem/39705516>
2600
2601         Reviewed by Wenson Hsieh.
2602
2603         Make sure provisional load has started before calling beginLayoutAtMinimumWidth
2604         on the AutoLayoutWKWebView to restore pre-r230919 behavior. The load now starts
2605         asynchronously because we ask the client if it is OK to do the load and the policy
2606         delegates are asynchronous nowadays.
2607
2608         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
2609         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]):
2610         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
2611         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2612         (-[TestNavigationDelegate webView:didStartProvisionalNavigation:]):
2613         (-[TestNavigationDelegate waitForDidStartProvisionalNavigation]):
2614         (-[WKWebView _test_waitForDidStartProvisionalNavigation]):
2615
2616 2018-05-01  Ross Kirsling  <ross.kirsling@sony.com>
2617
2618         [WinCairo] Align buildbot test stages with AppleWin.
2619         https://bugs.webkit.org/show_bug.cgi?id=185094
2620
2621         Reviewed by Brent Fulgham.
2622
2623         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2624         (TestFactory.__init__):
2625         Do run API tests, don't run dashboard tests.
2626
2627         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2628         (RunUnitTests):
2629         Call run-api-tests with Python, not Perl (bugfix for r230998).
2630
2631         * Scripts/webkitpy/port/win.py:
2632         (WinPort.environment_for_api_tests):
2633         Retrieve necessary Windows environment variables.
2634
2635 2018-05-01  Eric Carlson  <eric.carlson@apple.com>
2636
2637         [MediaStream] remove WK1 support
2638         https://bugs.webkit.org/show_bug.cgi?id=185136
2639
2640         Reviewed by Youenn Fablet.
2641
2642         * DumpRenderTree/mac/UIDelegate.mm:
2643         (-[UIDelegate webView:decidePolicyForUserMediaRequestFromOrigin:listener:]): Deleted.
2644
2645 2018-05-01  Chris Dumez  <cdumez@apple.com>
2646
2647         [WKTR] Move navigation policy for response decision from InjectedBundle to UIProcess
2648         https://bugs.webkit.org/show_bug.cgi?id=185157
2649
2650         Reviewed by Geoffrey Garen.
2651
2652         Move navigation policy for response decision from InjectedBundle to UIProcess. This is a more
2653         common configuration and should therefore be the configuration we test by default.
2654
2655         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2656         (WTR::InjectedBundlePage::decidePolicyForResponse):
2657
2658 2018-05-01  Oleksandr Skachkov  <gskachkov@gmail.com>
2659
2660         WebAssembly: add support for stream APIs - JavaScript API
2661         https://bugs.webkit.org/show_bug.cgi?id=183442
2662
2663         Reviewed by Yusuke Suzuki and JF Bastien.
2664
2665         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2666
2667 2018-04-30  Mark Lam  <mark.lam@apple.com>
2668
2669         Apply PtrTags to the MetaAllocator and friends.
2670         https://bugs.webkit.org/show_bug.cgi?id=185110
2671         <rdar://problem/39533895>
2672
2673         Reviewed by Saam Barati.
2674
2675         Update the test to match MetaAllocator changes in WTF.
2676
2677         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2678         (TestWebKitAPI::TEST_F):
2679         (WTF::tagForPtr):
2680         (WTF::ptrTagName):
2681
2682 2018-04-30  Alex Christensen  <achristensen@webkit.org>
2683
2684         Add WKUIDelegatePrivate equivalent of WKPageContextMenuClient getContextMenuFromProposedMenuAsync
2685         https://bugs.webkit.org/show_bug.cgi?id=180955
2686
2687         Reviewed by Andy Estes.
2688
2689         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuImgWithVideo.mm:
2690         (-[ContextMenuImgWithVideoDelegate _webView:contextMenu:forElement:]):
2691         (-[ContextMenuImgWithVideoDelegate _webView:getContextMenuFromProposedMenu:forElement:userInfo:completionHandler:]):
2692
2693 2018-04-30  JF Bastien  <jfbastien@apple.com>
2694
2695         Use some C++17 features
2696         https://bugs.webkit.org/show_bug.cgi?id=185135
2697
2698         Reviewed by Alex Christensen.
2699
2700         * DumpRenderTree/PlatformMac.cmake:
2701         * gtk/ycm_extra_conf.py:
2702         (FlagsForFile):
2703
2704 2018-04-30  Yusuke Suzuki  <utatane.tea@gmail.com>
2705
2706         Use WordLock instead of std::mutex for Threading
2707         https://bugs.webkit.org/show_bug.cgi?id=185121
2708
2709         Reviewed by Geoffrey Garen.
2710
2711         * TestWebKitAPI/Tests/WTF/Signals.cpp:
2712         (TEST):
2713
2714 2018-04-30  Michael Catanzaro  <mcatanzaro@igalia.com>
2715
2716         [GTK] Webkit should spoof as Safari on a Mac when on Chase.com
2717         https://bugs.webkit.org/show_bug.cgi?id=185103
2718
2719         Reviewed by Carlos Garcia Campos.
2720
2721         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2722         (TestWebKitAPI::TEST):
2723
2724 2018-04-28  Sihui Liu  <sihui_liu@apple.com>
2725
2726         [Cocoa] Set HTTPOnly flag when converting Cookie to NSHTTPCookie
2727         https://bugs.webkit.org/show_bug.cgi?id=185052
2728
2729         Reviewed by Geoffrey Garen.
2730
2731         Modified API test to provide correct test cases for HTTPOnly flag.
2732
2733         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2734         (TEST):
2735
2736 2018-04-28  Rick Waldron  <waldron.rick@gmail.com>
2737
2738         Token misspelled "tocken" in error message string
2739         https://bugs.webkit.org/show_bug.cgi?id=185030
2740
2741         Reviewed by Saam Barati.
2742
2743         * Scripts/test262/test262-expectations.yaml: Fix typo "tocken" => "token"
2744
2745 2018-04-27  Stephan Szabo  <stephan.szabo@sony.com>
2746
2747         [WinCairo] Support --no-copy for jsc tests in wincairo tests, add copying of dlls for copy case
2748         https://bugs.webkit.org/show_bug.cgi?id=185049
2749
2750         Reviewed by Keith Miller.
2751
2752         * Scripts/run-javascriptcore-tests:
2753         (runJSCStressTests):
2754         * Scripts/run-jsc-stress-tests:
2755
2756 2018-04-26  Ryosuke Niwa  <rniwa@webkit.org>
2757
2758         PSON: Triggering a navigation to an invalid URL creates a new WebContent process
2759         https://bugs.webkit.org/show_bug.cgi?id=185066
2760
2761         Reviewed by Youenn Fablet.
2762
2763         Added a new test case (ProcessSwap.NavigateToInvalidURL) for navigating to an invalid URL.
2764         WebKit should not swap WebContent process in this case.
2765
2766         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2767         (-[PSONNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2768         (-[PSONUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2769
2770 2018-04-27  Nan Wang  <n_wang@apple.com>
2771
2772         AX: Accessibility needs to know which part of the content view is visible on iOS
2773         https://bugs.webkit.org/show_bug.cgi?id=185085
2774         <rdar://problem/39801363>
2775
2776         Reviewed by Chris Fleizach.
2777
2778         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2779         (WTR::AccessibilityUIElement::stringAttributeValue):
2780
2781 2018-04-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2782
2783         [Extra zoom mode] Add a mechanism to override default viewport behaviors in extra zoom mode
2784         https://bugs.webkit.org/show_bug.cgi?id=185050
2785         <rdar://problem/39624038>
2786
2787         Reviewed by Tim Horton.
2788
2789         Remove a test that's no longer useful, now that the SPI it was testing is gone. This functionality is now
2790         tested by the layout test added in this patch.
2791
2792         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2793         * TestWebKitAPI/Tests/ios/ViewportSizingTests.mm: Removed.
2794
2795 2018-04-26  Ryan Haddad  <ryanhaddad@apple.com>
2796
2797         REGRESSION (r231039): RunUnitTests step reports disabled tests as failures
2798         https://bugs.webkit.org/show_bug.cgi?id=185061
2799
2800         Reviewed by Aakash Jain.
2801
2802         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2803         (RunUnitTests.countFailures): Return the difference between the total number of tests run and the number that passed.
2804         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Add a test.
2805
2806 2018-04-26  Ross Kirsling  <ross.kirsling@sony.com>
2807
2808         Add release bots for WinCairo.
2809         https://bugs.webkit.org/show_bug.cgi?id=185042
2810
2811         Reviewed by Lucas Forschler.
2812
2813         * BuildSlaveSupport/build.webkit.org-config/config.json:
2814         Add a release build bot and two test bots, replacing the outdated WinCairo release bots.
2815
2816 2018-04-26  Sihui Liu  <sihui_liu@apple.com>
2817
2818         -[WKHTTPCookieStore deleteCookie:completionHandler:] doesn't delete cookies
2819         https://bugs.webkit.org/show_bug.cgi?id=184938
2820         <rdar://problem/34737395>
2821
2822         Reviewed by Geoffrey Garen.
2823
2824         Add API test coverage.
2825
2826         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2827         (TEST):
2828
2829 2018-04-26  Ross Kirsling  <ross.kirsling@sony.com>
2830
2831         WinCairo test bots should run JSC tests with options for Windows command prompt.
2832         https://bugs.webkit.org/show_bug.cgi?id=185019
2833
2834         Reviewed by Per Arne Vollan.
2835
2836         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2837         (RunJavaScriptCoreTests.start):
2838
2839 2018-04-26  Ross Kirsling  <ross.kirsling@sony.com>
2840
2841         WinCairo WKL Debug Test bot is not using DRT.
2842         https://bugs.webkit.org/show_bug.cgi?id=185009
2843
2844         Reviewed by Per Arne Vollan.
2845
2846         * BuildSlaveSupport/build.webkit.org-config/config.json:
2847
2848 2018-04-26  Per Arne Vollan  <pvollan@apple.com>
2849
2850         Disable content filtering in minimal simulator mode
2851         https://bugs.webkit.org/show_bug.cgi?id=185027
2852         <rdar://problem/39736091>
2853
2854         Reviewed by Jer Noble.
2855
2856         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2857
2858 2018-04-26  Brady Eidson  <beidson@apple.com>
2859
2860         Add a setting for keeping around all processes and always reusing them per-origin.
2861         <rdar://problem/39695798> and https://bugs.webkit.org/show_bug.cgi?id=185020
2862
2863         Reviewed by Andy Estes.
2864
2865         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2866
2867 2018-04-26  Andy VanWagoner  <thetalecrafter@gmail.com>
2868
2869         [INTL] Implement Intl.PluralRules
2870         https://bugs.webkit.org/show_bug.cgi?id=184312
2871
2872         Reviewed by JF Bastien.
2873
2874         Added Intl.PluralRules feature flag.
2875
2876         * Scripts/webkitperl/FeatureList.pm:
2877         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2878
2879 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
2880
2881         [WPE] Build and link against latest WPEBackend and WPEBackend-fdo
2882         https://bugs.webkit.org/show_bug.cgi?id=184643
2883
2884         Reviewed by Žan Doberšek.
2885
2886         Add missing INCLUDE_DIRS in many places.
2887
2888         Adapt to single-header WPE includes.
2889
2890         Null-initialize padding to silence -Wmissing-field-initializers. (Yuck.)
2891
2892         * TestWebKitAPI/PlatformWPE.cmake:
2893         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2894         (testWebViewWebBackend):
2895         * TestWebKitAPI/glib/PlatformWPE.cmake:
2896         * WebKitTestRunner/EventSenderProxy.h:
2897         * WebKitTestRunner/PlatformWPE.cmake:
2898         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2899         * wpe/HeadlessViewBackend/CMakeLists.txt:
2900         * wpe/HeadlessViewBackend/HeadlessViewBackend.cpp:
2901         * wpe/HeadlessViewBackend/HeadlessViewBackend.h:
2902         * wpe/jhbuild.modules:
2903
2904 2018-04-25  Jonathan Bedard  <jbedard@apple.com>
2905
2906         REGRESSION (r230998): Bot watcher's dashboard doesn't display number of API test failures
2907         https://bugs.webkit.org/show_bug.cgi?id=184982
2908
2909         Rubber-stamped by Aakash Jain.
2910
2911         Correctly count the number of API test failures.
2912
2913         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2914         (RunUnitTests.countFailures): Count the number of test failures for the new run-api-tests.
2915         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2916         * Scripts/webkitpy/api_tests/manager.py:
2917         (Manager.run): Disabled tests are not run.
2918
2919 2018-04-25  Jiewen Tan  <jiewen_tan@apple.com>
2920
2921         Remove access to keychain from the WebContent process
2922         https://bugs.webkit.org/show_bug.cgi?id=184428
2923         <rdar://problem/13150903>
2924
2925         Reviewed by Brent Fulgham.
2926
2927         This patch does the followings:
2928         1. Added an API test for this patch.
2929         2. Instrument DumpRenderTree and WebKitTestRunner to take advantages of new SPIs.
2930
2931         * DumpRenderTree/mac/UIDelegate.mm:
2932         (-[UIDelegate signedPublicKeyAndChallengeStringForWebView:]):
2933         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2934         * TestWebKitAPI/Tests/mac/SSLKeyGenerator.mm: Added.
2935         (TestWebKitAPI::SSLKeyGeneratorTest::SetUp):
2936         (TestWebKitAPI::SSLKeyGeneratorTest::TearDown):
2937         (TestWebKitAPI::TEST_F):
2938         * WebKitTestRunner/TestController.cpp:
2939         (WTR::copySignedPublicKeyAndChallengeString):
2940         (WTR::TestController::createOtherPage):
2941         (WTR::TestController::createWebViewWithOptions):
2942
2943 2018-04-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2944
2945         [Extra zoom mode] The search field on www.bing.com is missing label text
2946         https://bugs.webkit.org/show_bug.cgi?id=184975
2947         <rdar://problem/39723081>
2948
2949         Reviewed by Tim Horton.
2950
2951         Adds UIScriptController.formInputLabel, which asynchronously requests the input label text for the currently
2952         focused element in extra zoom mode.
2953
2954         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2955         (WTR::UIScriptController::formInputLabel const):
2956         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2957         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2958         (WTR::UIScriptController::formInputLabel const):
2959         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2960         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2961         (WTR::UIScriptController::formInputLabel const):
2962
2963 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
2964
2965         [WPE] Should load injected bundle from builddir in developer builds
2966         https://bugs.webkit.org/show_bug.cgi?id=184983
2967
2968         Reviewed by Carlos Alberto Lopez Perez.
2969
2970         Set WEBKIT_INJECTED_BUNDLE_PATH when running WPE MiniBrowser.
2971
2972         * Scripts/run-minibrowser:
2973
2974 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
2975
2976         [WPE] libgstggtk.so broken in jhbuild environment
2977         https://bugs.webkit.org/show_bug.cgi?id=184984
2978
2979         Reviewed by Carlos Alberto Lopez Perez.
2980
2981         Don't pass --enable-glx=no when building libepoxy, to ensure it's compatible with
2982         gst-plugins-good.
2983
2984         * wpe/jhbuild.modules:
2985
2986 2018-04-25  Ryosuke Niwa  <rniwa@webkit.org>
2987
2988         PSON: Don't create a new process when navigating to a blob URL, data URL, and about:blank
2989         https://bugs.webkit.org/show_bug.cgi?id=184962
2990
2991         Reviewed by Youenn Fablet.
2992
2993         Added four test cases for navigating to a blob URL, data URL, and about:blank with process-swap-on-navigation turned on.
2994
2995         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2996         (ProcessSwap.SameOriginBlobNavigation): Added.
2997         (ProcessSwap.CrossOriginBlobNavigation): Added.
2998         (ProcessSwap.NavigateToAboutBlank): Added.
2999         (ProcessSwap.NavigateToDataURL): Added.
3000
3001 2018-04-25  Michael Catanzaro  <mcatanzaro@igalia.com>
3002
3003         [WPE] Remove deprecated functions and properties from the API
3004         https://bugs.webkit.org/show_bug.cgi?id=179295
3005
3006         Reviewed by Žan Doberšek.
3007
3008         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
3009         (testWebViewAuthenticationStorage): Disable this test for now. It will require some effort
3010         to rewrite LoadTrackingTest to not require the web view at construction time.
3011         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3012         (testWebKitSettings): Don't test private browsing setting, which is gone.
3013         * TestWebKitAPI/glib/CMakeLists.txt: Disable TestCookieManager for now.
3014
3015 2018-04-25  Andy Estes  <aestes@apple.com>
3016
3017         [Mac] Number of drop items is always 0 when performing a DHTML drag
3018         https://bugs.webkit.org/show_bug.cgi?id=184943
3019
3020         Reviewed by Ryosuke Niwa.
3021
3022         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3023         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:
3024         (-[DragInfo numberOfValidItemsForDrop]):
3025         (-[DragInfo setNumberOfValidItemsForDrop:]):
3026         (TestWebKitAPI::TEST):
3027         * TestWebKitAPI/Tests/mac/full-page-dropzone.html: Added.
3028
3029 2018-04-25  Jonathan Bedard  <jbedard@apple.com>
3030
3031         API test harness should be Python
3032         https://bugs.webkit.org/show_bug.cgi?id=181043
3033         <rdar://problem/36164410>
3034
3035         Reviewed by David Kilzer.
3036
3037         Run API tests from a Python script rather than Perl. The Python API tests have
3038         the same structure as the layout tests.
3039
3040         * Scripts/run-api-tests: Changed from Perl to Python.
3041         * Scripts/webkitpy/api_tests: Added.
3042         * Scripts/webkitpy/api_tests/__init__.py: Added.
3043         * Scripts/webkitpy/api_tests/manager.py: Added.
3044         (Manager):
3045         (Manager.__init__):
3046         (Manager._test_list_from_output): Construct a list of tests from the output of
3047         TestWTF and TestWebKitAPI.
3048         (Manager._find_test_subset): Given a list of all possible tests and command line
3049         arguments, return a list of tests which match the provided arguments.
3050         (Manager._collect_tests): Run TestWTF and TestWebKitAPI with --gtest_list_tests
3051         to determine which tests will be run.
3052         (Manager._print_test_result): Formatted print of a test with it's output.
3053         (Manager._print_tests_result_with_status): Print all tests and output for tests
3054         which ran with a specified exit status.
3055         (Manager.run): Collect all tests, run them and then print results from the run.
3056         * Scripts/webkitpy/api_tests/run_api_tests.py: Added.
3057         (main): Parse arguments, construct a port, early exit for illegal ports and
3058         then run tests.
3059         (run): Setup logging and printing before using the Manager to run tests.
3060         (parse_args): Use argparse to define all options used by run-api-tests.
3061         * Scripts/webkitpy/api_tests/runner.py: Added.
3062         (Runner):
3063         (Runner.__init__):
3064         (Runner._shard_tests): Split tests so that each suite runs together.
3065         (Runner.command_for_port): Run a command on the device specified by the given
3066         port object. Once <https://bugs.webkit.org/show_bug.cgi?id=175204> is completed,
3067         this function would be entirely replaced by the server_process factory owned
3068         by the port object.
3069         (Runner.run): Run all shards in the message_pool.
3070         (Runner.handle): Handle reports from child processes.
3071         (Runner.result_map_by_status): Return a mapping of tests to output for tests
3072         which exit with a specific status.
3073         (_Worker):
3074         (_Worker.__init__):
3075         (_Worker._filter_noisy_output): Filter out objc warnings since these polite the log.
3076         (_Worker._run_single_test): Runs a single test in a single child process.
3077         (_Worker._run_shard_with_binary): Attempts to run a group of tests in the same
3078         child process. If this technique fails, the remaining tests are run singly.
3079         (_Worker.handle): Run the specified shard.
3080         * Scripts/webkitpy/port/base.py:
3081         (Port):
3082         (Port.check_api_test_build): Check if TestWTF and TestWebKitAPI are built.
3083         (Port.environment_for_api_tests): Return the environment needed to run
3084         the TestWebKitAPI binary.
3085         (Port. path_to_api_test_binaries): Return a list of the path to all binaries
3086         used when running API tests.
3087         (Port._build_api_tests): Build TestWTF and TestWebKitAPI if required.
3088         * Scripts/webkitpy/port/mac.py:
3089         (MacPort.environment_for_api_tests): Enable GuardMalloc for API tests.
3090         * Scripts/webkitpy/port/server_process.py: 
3091         (ServerProcess.pop_all_buffered_stdout):
3092
3093 2018-04-25  Carlos Garcia Campos  <cgarcia@igalia.com>
3094
3095         Incorrect number of WebDriver test failures shown in the bots
3096         https://bugs.webkit.org/show_bug.cgi?id=184959
3097
3098         Reviewed by Michael Catanzaro.
3099
3100         The regular expression we are using to get the number of failures from the log is matching a particular test
3101         error output. Improve the regular expression to avoid matching other strings in the log. Ensure that only
3102         matches at the beginning of lines and add spaces after Unexpected and before the (<failures>).
3103
3104         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3105         (RunWebDriverTests.commandComplete):
3106
3107 2018-04-25  Carlos Garcia Campos  <cgarcia@igalia.com>
3108
3109         [GTK] Implement MouseEvent.buttons
3110         https://bugs.webkit.org/show_bug.cgi?id=184913
3111
3112         Reviewed by Žan Doberšek.
3113
3114         Include the mouse buttons state in WTR synthesized events.
3115
3116         * WebKitTestRunner/EventSenderProxy.h:
3117         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3118         (WTR::EventSenderProxy::EventSenderProxy):
3119         (WTR::EventSenderProxy::createMouseButtonEvent):
3120         (WTR::EventSenderProxy::mouseDown):
3121         (WTR::EventSenderProxy::mouseUp):
3122         (WTR::EventSenderProxy::mouseMoveTo):
3123
3124 2018-04-24  Pablo Saavedra  <psaavedra@igalia.com>
3125
3126         [GTK][WPE] Fix triggered bot name on the WPE Debug Build bot
3127         https://bugs.webkit.org/show_bug.cgi?id=184954
3128
3129         Reviewed by Michael Catanzaro.
3130
3131         * BuildSlaveSupport/build.webkit.org-config/config.json:
3132
3133 2018-04-24  Saam Barati  <sbarati@apple.com>
3134
3135         Keep around a pre-warmed process when doing process swap on navigation
3136         https://bugs.webkit.org/show_bug.cgi?id=184765
3137         <rdar://problem/39685099>
3138
3139         Reviewed by Ryosuke Niwa and Brady Eidson.
3140
3141         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3142
3143 2018-04-24  Aakash Jain  <aakash_jain@apple.com>
3144
3145         [build.webkit.org] unit-tests fail when passwords.json is missing
3146         https://bugs.webkit.org/show_bug.cgi?id=180390
3147
3148         Reviewed by Carlos Alberto Lopez Perez.
3149
3150         * BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
3151         (loadBuilderConfig): Add support for test_mode. Load mock passwords in test_mode.
3152         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3153         (BuildBotConfigLoader._add_dependant_modules_to_sys_modules): Call _add_webkitpy_to_sys_path as well.
3154         (BuildBotConfigLoader._mock_open): Deleted.
3155         (BuildBotConfigLoader.load_config): Deleted.
3156
3157 2018-04-24  John Wilander  <wilander@apple.com>
3158
3159         From-Origin: Support for 'same' and 'same-site' response header, nested frame origin check
3160         https://bugs.webkit.org/show_bug.cgi?id=184560
3161         <rdar://problem/38901344>
3162
3163         Reviewed by Youenn Fablet and Daniel Bates.
3164
3165         This patch implements significant parts of https://github.com/whatwg/fetch/issues/687.
3166         We consume the From-Origin response header and only load the resource if:
3167         - The header is non-existent, empty, or invalid.
3168         - The header specifies 'same' and the resource's origin matches the originating
3169           document's origin and the origins up the frame tree.
3170         - The header specifies 'same-site' and the resource's eTLD+1 matches the originating
3171           document's eTLD+1 and the eTLD+1 of the documents up the frame tree.
3172
3173         This feature is experimental and off by default.
3174
3175         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3176         * TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp: Added.
3177         (TestWebKitAPI::TEST):
3178             Tests for From-Origin header parsing.
3179
3180 2018-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3181
3182         Unreviewed. Update W3C WebDriver imported tests.
3183
3184         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
3185         (WebDriverW3CExecutor.__init__):
3186
3187 2018-04-24  Zan Dobersek  <zdobersek@igalia.com>
3188
3189         [WPE] Remove libgbm dependency
3190         https://bugs.webkit.org/show_bug.cgi?id=184906
3191
3192         Reviewed by Carlos Garcia Campos.
3193
3194         Stop searching for libgbm, using its compiler flags for the
3195         HeadlessViewBackend compilation and linking against the .so object.
3196         This is not necessary anymore after r230562 switched to a different
3197         backend implementation for testing.
3198
3199         * wpe/HeadlessViewBackend/CMakeLists.txt:
3200         * wpe/install-dependencies:
3201
3202 2018-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3203
3204         [GLIB] Make it possible to use a different timeout for slow test cases in GLib tests
3205         https://bugs.webkit.org/show_bug.cgi?id=184816
3206
3207         Reviewed by Michael Catanzaro.
3208
3209         Pass a function from api test runner to glib test runner to check if a test is slow and use the given slow
3210         timeout.
3211
3212         * TestWebKitAPI/glib/TestExpectations.json:
3213         * glib/api_test_runner.py:
3214         (TestRunner._run_test_glib.is_slow_test):
3215         (TestRunner._run_test_glib):
3216         * glib/glib_test_runner.py:
3217         (GLibTestRunner.__init__):
3218         (GLibTestRunner._stop_timeout):
3219         (GLibTestRunner._subtest_start):
3220         (GLibTestRunner._subtest_end):
3221
3222 2018-04-23  Wenson Hsieh  <wenson_hsieh@apple.com>
3223
3224         [Extra zoom mode] REGRESSION(230860) Unable to change time input values using UI
3225         https://bugs.webkit.org/show_bug.cgi?id=184901
3226         <rdar://problem/39664797>
3227
3228         Reviewed by Tim Horton.
3229
3230         Introduce a new UIScriptController method to set the value of a currently focused input of type time, by
3231         interacting with the UI. See WebKit ChangeLogs for more detail.
3232
3233         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3234         (WTR::UIScriptController::setTimePickerValue):
3235         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3236         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3237         (WTR::UIScriptController::setTimePickerValue):
3238         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3239         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3240         (WTR::UIScriptController::setTimePickerValue):
3241
3242 2018-04-23  Zalan Bujtas  <zalan@apple.com>
3243
3244         [LayoutFormattingContext] Initial commit.
3245         https://bugs.webkit.org/show_bug.cgi?id=184896
3246
3247         Reviewed by Antti Koivisto.
3248
3249         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3250
3251 2018-04-23  Chris Dumez  <cdumez@apple.com>
3252
3253         [WKTR] Move navigation policy decision from the injected bundle to the UIProcess
3254         https://bugs.webkit.org/show_bug.cgi?id=184801
3255
3256         Reviewed by Geoffrey Garen.
3257
3258         Move navigation policy decision from the injected bundle to the UIProcess in WebKitTestRunner.
3259         This is a more common configuration and therefore should be the default testing configuration.
3260
3261         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3262         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
3263         Always respond with 'PassThrough' in the InjectedBundle so the UIProcess
3264         is now asked for the policy decision.
3265
3266 2018-04-23  Pablo Saavedra  <psaavedra@igalia.com>
3267
3268         [GTK][WPE] Add Debug bots (build and tests) for WPE
3269         https://bugs.webkit.org/show_bug.cgi?id=184887
3270
3271         Reviewed by Carlos Alberto Lopez Perez.
3272
3273         Deployed 2 new bots for WPE Debug: wpe-linux-bot-3 and
3274         wpe-linux-bot-4
3275
3276         Both bots have already the credentials ready to authenticated against
3277         build.webkit.org. They provides the bots for the "debug" configuration over
3278         the "WPE" platform and building for the "x86_64" architecture:
3279         WPE Linux 64-bit Debug (Build) and WPE Linux 64-bit Debug (Tests) 
3280
3281         * BuildSlaveSupport/build.webkit.org-config/config.json:
3282         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3283
3284 2018-04-23  Chris Dumez  <cdumez@apple.com>
3285
3286         HTML String load cannot be prevented by responding 'Cancel' asynchronously in decidePolicyForNavigationAction
3287         https://bugs.webkit.org/show_bug.cgi?id=184848
3288         <rdar://problem/39145306>
3289
3290         Reviewed by Brady Eidson.
3291
3292         Add API test coverage.
3293
3294         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
3295         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
3296         (TEST):
3297
3298 2018-04-23  Michael Catanzaro  <mcatanzaro@igalia.com>
3299
3300         [GTK][WPE] TestSSL fails due to additional TLS errors returned
3301         https://bugs.webkit.org/show_bug.cgi?id=184860
3302
3303         Reviewed by Carlos Garcia Campos.
3304
3305         Add script and config file for regenerating the test certificate.
3306         Regenerate it. TestSSL no longer fails on my machine.
3307
3308         I do see a ton of network process crashes and JavaScript errors, none of
3309         which prevent the test from passing, but this commit only claims to fix
3310         the certificate validation portion of the test.
3311
3312         * TestWebKitAPI/Tests/WebKitGLib/resources/generate-test-cert.sh: Added.
3313         * TestWebKitAPI/Tests/WebKitGLib/resources/test-cert.conf: Added.
3314         * TestWebKitAPI/Tests/WebKitGLib/resources/test-cert.pem:
3315
3316 2018-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3317
3318         [GLIB] ERROR: Thread was unable to be detached when running /jsc/vm test in debug
3319         https://bugs.webkit.org/show_bug.cgi?id=184815
3320
3321         Reviewed by Michael Catanzaro.
3322
3323         This is because in the test we are calling both join and detach. We should only call join.
3324
3325         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3326         (testsJSCVirtualMachine):
3327
3328 2018-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3329
3330         [GLIB] Test /jsc/prototypes crashes in debug
3331         https://bugs.webkit.org/show_bug.cgi?id=184814
3332
3333         Reviewed by Michael Catanzaro.
3334
3335         We should also call the constructor/destructor of Bar struct to ensure Foo is constructed.
3336
3337         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3338         (barCreate):
3339         (barFree):
3340
3341 2018-04-20  Michael Catanzaro  <mcatanzaro@igalia.com>
3342
3343         REGRESSION(r228088): [SOUP] Check TLS errors for WebSockets on GTlsConnection::accept-certificate
3344         https://bugs.webkit.org/show_bug.cgi?id=184804
3345
3346         Reviewed by Carlos Garcia Campos.
3347
3348         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
3349         (WebSocketTest::WebSocketTest):
3350         (WebSocketTest::~WebSocketTest):
3351         (WebSocketTest::serverWebSocketCallback):
3352         (WebSocketTest::webSocketTestResultCallback):
3353         (WebSocketTest::connectToServerAndWaitForEvents):
3354         (testWebSocketTLSErrors):
3355         (beforeAll):
3356
3357 2018-04-20  Chris Dumez  <cdumez@apple.com>
3358
3359         Unreviewed, update 2 more API tests after r230876.
3360
3361         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
3362         (TEST):
3363         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
3364         (TestWebKitAPI::TEST):
3365
3366 2018-04-20  Tim Horton  <timothy_horton@apple.com>
3367
3368         Adjust geolocation feature flag
3369         https://bugs.webkit.org/show_bug.cgi?id=184856
3370
3371         Reviewed by Wenson Hsieh.
3372
3373         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3374
3375 2018-04-20  Chris Dumez  <cdumez@apple.com>
3376
3377         REGRESSION (r229828): web view doesn’t update or respond to resizing until client calls policy decision handler
3378         https://bugs.webkit.org/show_bug.cgi?id=184210
3379         <rdar://problem/39072354>
3380
3381         Reviewed by Wenson Hsieh.
3382
3383         * TestWebKitAPI/Tests/WebKit/large-red-square-image.html:
3384         * TestWebKitAPI/Tests/WebKitCocoa/dragstart-change-selection-offscreen.html:
3385         Add viewport meta tags.
3386
3387         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3388         (-[WKWebView _test_waitForDidFinishNavigation]):
3389         Update _test_waitForDidFinishNavigation to wait for the next presentation update
3390         to make iOS API tests happy without having to modify each of them.
3391
3392 2018-04-20  Timothy Hatcher  <timothy@apple.com>
3393
3394         REGRESSION: API test WebKit.BackgroundColorSystemColor is failing
3395
3396         https://bugs.webkit.org/show_bug.cgi?id=184849
3397         rdar://problem/39386405
3398
3399         Reviewed by Brian Burg.
3400
3401         * TestWebKitAPI/Tests/mac/BackgroundColor.mm:
3402         (TestWebKitAPI::TEST): Use CGColorEqualToColor since we might get a different
3403         CGColor pointer from NSColor each time.
3404
3405 2018-04-20  Wenson Hsieh  <wenson_hsieh@apple.com>
3406
3407         [Extra zoom mode] Injected bundle form client should be notified when editing text fields
3408         https://bugs.webkit.org/show_bug.cgi?id=184822
3409         <rdar://problem/38807319>
3410
3411         Reviewed by Tim Horton.
3412
3413         Add WebKitTestRunner support for listening to form editing SPI hooks in the injected bundle. The new layout test
3414         installs callbacks that listen for "begin editing", "end editing", and "text changed" calls to injected bundle
3415         SPI. See other ChangeLogs for more detail.
3416
3417         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3418         (WTR::UIScriptController::enterText):
3419         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3420
3421         Add UIScriptController support for simulating text entry in the currently focused element.
3422
3423         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3424         (WTR::UIScriptController::enterText):
3425         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3426         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3427
3428         Add TestRunner bindings for registering injected bundle form client callbacks.
3429
3430         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3431         (WTR::handleTextDidChangeInTextField):
3432         (WTR::handleTextFieldDidBeginEditing):
3433         (WTR::handleTextFieldDidEndEditing):
3434         (WTR::InjectedBundle::didCreatePage):
3435
3436         Set the injected bundle form editor client.
3437
3438         (WTR::InjectedBundle::setUpInjectedBundleClients):
3439         (WTR::InjectedBundle::textDidChangeInTextField):
3440         (WTR::InjectedBundle::textFieldDidBeginEditing):
3441         (WTR::InjectedBundle::textFieldDidEndEditing):
3442         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3443         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3444         (WTR::TestRunner::installTextDidChangeInTextFieldCallback):
3445         (WTR::TestRunner::textDidChangeInTextFieldCallback):
3446         (WTR::TestRunner::installTextFieldDidBeginEditingCallback):
3447         (WTR::TestRunner::textFieldDidBeginEditingCallback):
3448         (WTR::TestRunner::installTextFieldDidEndEditingCallback):
3449         (WTR::TestRunner::textFieldDidEndEditingCallback):
3450         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3451         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3452         (WTR::UIScriptController::enterText):
3453
3454 2018-04-20  Youenn Fablet  <youenn@apple.com>
3455
3456         WebPage sometimes incorrectly rules out PDF as a mime type that can be showed
3457         https://bugs.webkit.org/show_bug.cgi?id=184369
3458
3459         Reviewed by Chris Dumez.
3460
3461         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
3462         (TEST):
3463
3464 2018-04-20  Daniel Bates  <dabates@apple.com>
3465
3466         Remove Strong Password decoration when text field type changes
3467         https://bugs.webkit.org/show_bug.cgi?id=184795
3468         <rdar://problem/38325108>
3469
3470         Reviewed by Antti Koivisto.
3471
3472         Add a unit test to ensure the injected bundle API and WebKit UI delegate SPI is invoked
3473         when the field has the Strong Password button and its type changes.
3474
3475         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3476         * TestWebKitAPI/Tests/WebKitCocoa/DidResignInputElementStrongPasswordAppearance.mm: Added.
3477         (didResignInputElementStrongPasswordAppearance):
3478         (-[DidResignInputElementStrongPasswordAppearance webProcessPlugIn:didCreateBrowserContextController:]):
3479         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3480         (-[DidResignInputElementStrongPasswordAppearanceDelegate _webView:didResignInputElementStrongPasswordAppearanceWithUserInfo:]):
3481         (-[DidResignInputElementStrongPasswordAppearanceDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3482         (TEST):
3483
3484 2018-04-20  Brady Eidson  <beidson@apple.com>
3485
3486         Add a test to verify load/unload/pageshow/pagehide all work with process swapping.
3487         https://bugs.webkit.org/show_bug.cgi?id=184807
3488
3489         Reviewed by Chris Dumez.
3490
3491         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3492         (-[PSONMessageHandler userContentController:didReceiveScriptMessage:]):
3493
3494 2018-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3495
3496         Unreviewed. Mark TestJSC as slow in debug.
3497
3498         Only /jsc/vm is slow, but GLib API test runner only checks the test binary for GLib tests.
3499
3500         * TestWebKitAPI/glib/TestExpectations.json:
3501
3502 2018-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3503
3504         [GTK] Local cross references are broken in API documentation
3505         https://bugs.webkit.org/show_bug.cgi?id=184771
3506
3507         Reviewed by Michael Catanzaro.
3508
3509         The problem is that gtkdoc-fixxref expects the links to be in the form html/modulename (like the installed
3510         ones), but we generate the documentation as modulename/html. So, links to WebKitDOM or JSC are generated as
3511         ../html/Foo. The rebase command considers html to be the module name in this case, creating broken links in all
3512         the cases.
3513
3514         * gtk/gtkdoc.py:
3515         (GTKDoc._copy_doc_files_to_output_dir): We don't have any html dir in the source tree so, we are not copying
3516         anything here.
3517         (GTKDoc._run_gtkdoc_mkhtml): Create the html dir here using html/modulename instead now.
3518         (GTKDoc._run_gtkdoc_fixxref): Pass the new directory as module dir to gtkdoc-fixxref and fix several links for
3519         which gtkdoc-fixxref always uses absolute paths.
3520         * gtk/manifest.txt.in: Update the documentation html paths and include the JSC GLib API in the tarball too.
3521
3522 2018-04-19  Brady Eidson  <beidson@apple.com>
3523
3524         Make back forward cache work with process swapping.
3525         <rdar://problem/38676604> and https://bugs.webkit.org/show_bug.cgi?id=184793
3526
3527         Reviewed by Chris Dumez.
3528
3529         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3530
3531 2018-04-19  David Kilzer  <ddkilzer@apple.com>
3532
3533         Enable Objective-C weak references
3534         <https://webkit.org/b/184789>
3535         <rdar://problem/39571716>
3536
3537         Reviewed by Dan Bernstein.
3538
3539         * ContentExtensionTester/Configurations/Base.xcconfig:
3540         (CLANG_ENABLE_OBJC_WEAK): Enable.
3541         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3542         (CLANG_ENABLE_OBJC_WEAK): Enable.
3543         * ImageDiff/cg/Configurations/Base.xcconfig:
3544         (CLANG_ENABLE_OBJC_WEAK): Enable.
3545         * MiniBrowser/Configurations/Base.xcconfig:
3546         (CLANG_ENABLE_OBJC_WEAK): Enable.
3547         * TestWebKitAPI/Configurations/Base.xcconfig:
3548         (CLANG_ENABLE_OBJC_WEAK): Enable.
3549         * WebEditingTester/Configurations/Base.xcconfig:
3550         (CLANG_ENABLE_OBJC_ARC): Re-order.
3551         * WebKitLauncher/Configurations/Base.xcconfig: Add newline at
3552         end of file.
3553         (CLANG_ENABLE_OBJC_WEAK): Enable.
3554         * WebKitTestRunner/Configurations/Base.xcconfig:
3555         (CLANG_ENABLE_OBJC_WEAK): Enable.
3556
3557 2018-04-19  Chris Dumez  <cdumez@apple.com>
3558
3559         REGRESSION (r229133): decidePolicyForNavigationAction not called for loading an HTML string
3560         https://bugs.webkit.org/show_bug.cgi?id=184209
3561         <rdar://problem/39145306>
3562
3563         Reviewed by Ryosuke Niwa.
3564
3565         Add API test coverage.
3566
3567         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
3568         (TEST):
3569
3570 2018-04-18  Ross Kirsling  <ross.kirsling@sony.com>
3571
3572         [WinCairo][EWS] Build bot should clean user temp directory each time.
3573         https://bugs.webkit.org/show_bug.cgi?id=184761
3574
3575         Reviewed by Lucas Forschler.
3576
3577         * EWSTools/Start-Queue.ps1:
3578         Clean user's temp directory before each build, so that Windows git doesn't fill it up over time.
3579
3580 2018-04-18  Ross Kirsling  <ross.kirsling@sony.com>
3581
3582         Buildbots using Python zipfile should enable compression
3583         https://bugs.webkit.org/show_bug.cgi?id=184759
3584
3585         Reviewed by Lucas Forschler.
3586
3587         * BuildSlaveSupport/built-product-archive:
3588         (createZipManually):
3589         Default is to archive without compressing, so tell it to compress as well. 
3590
3591 2018-04-18  Nan Wang  <n_wang@apple.com>
3592
3593         AX: [macOS] WebKit hangs when triggering an alert from an AOM increment event
3594         https://bugs.webkit.org/show_bug.cgi?id=184742
3595
3596         Reviewed by Chris Fleizach.
3597
3598         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3599         (AccessibilityUIElement::increment):
3600         (AccessibilityUIElement::decrement):
3601         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3602         (WTR::AccessibilityUIElement::asyncIncrement):
3603         (WTR::AccessibilityUIElement::asyncDecrement):
3604         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3605         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3606         (WTR::AccessibilityUIElement::increment):
3607         (WTR::AccessibilityUIElement::decrement):
3608         (WTR::AccessibilityUIElement::asyncIncrement):
3609         (WTR::AccessibilityUIElement::asyncDecrement):
3610
3611 2018-04-18  Ross Kirsling  <ross.kirsling@sony.com>
3612
3613         Fix archive step for WinCairo build bot.
3614         https://bugs.webkit.org/show_bug.cgi?id=184715
3615
3616         Reviewed by Lucas Forschler.
3617
3618         * BuildSlaveSupport/built-product-archive:
3619         (archiveBuiltProduct):
3620         (extractBuiltProduct):
3621
3622 2018-04-18  Sihui Liu  <sihui_liu@apple.com>
3623
3624         REGRESSION: Using the reload button while offline pushes identical pages onto the back/forward list
3625         https://bugs.webkit.org/show_bug.cgi?id=184570
3626         <rdar://problem/34807323>
3627
3628         Reviewed by Chris Dumez.
3629
3630         Add API test coverage.
3631
3632         * TestWebKitAPI/Tests/WebKitCocoa/LoadAlternateHTMLString.mm:
3633         (TEST):
3634
3635 2018-04-18  Chris Dumez  <cdumez@apple.com>
3636
3637         Add support for converting a local window to a remote window
3638         https://bugs.webkit.org/show_bug.cgi?id=184515
3639         <rdar://problem/39011318>
3640
3641         Reviewed by Ryosuke Niwa.
3642
3643         * MiniBrowser/mac/AppDelegate.m:
3644         (defaultConfiguration):
3645         * MiniBrowser/mac/SettingsController.h:
3646         * MiniBrowser/mac/SettingsController.m: