[MacOS] Filter GVA warning logged to stdout
[WebKit-https.git] / Tools / ChangeLog
1 2019-05-28  Eric Carlson  <eric.carlson@apple.com>
2
3         [MacOS] Filter GVA warning logged to stdout
4         https://bugs.webkit.org/show_bug.cgi?id=198303
5         <rdar://problem/50098041>
6
7         Reviewed by Jer Noble.
8
9         * Scripts/webkitpy/port/mac.py:
10         (MacPort.logging_patterns_to_strip): Filter GVA warnings.
11
12 2019-05-28  Nikita Vasilyev  <nvasilyev@apple.com>
13
14         Web Inspector: Provide UIString descriptions to improve localizations
15         https://bugs.webkit.org/show_bug.cgi?id=195132
16         <rdar://problem/48457817>
17
18         Reviewed by Devin Rousso.
19
20         Allow WI.UIString to take:
21         - WI.UIString(string, key, comment)
22         - WI.UIString(string, comment)
23         - WI.UIString(string)
24
25         * Scripts/extract-localizable-js-strings:
26
27 2019-05-25  Dewei Zhu  <dewei_zhu@apple.com>
28
29         Limit run-benchmark http server to specific interface.
30         https://bugs.webkit.org/show_bug.cgi?id=198247
31
32         Reviewed by Ryosuke Niwa.
33
34         Add '--interface' option to 'twisted_http_server.py'.
35         'SimpleHTTPServerDriver' should specify interface for http server.
36         Update regex that determines http server port from 'lsof' output to support ipv6 address.
37
38         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
39         Added '--interface' argument.
40         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
41         Limited http server to a specific interfce.
42         Added '-P' option to 'lsof' invocation to inhibits the conversion of port numbers to port name so script won't
43         fail if it's listening on a 'well-known' port.
44         Abstracted '_check_http_server_is_running' to allow potential child class to have its own implementation.
45         (SimpleHTTPServerDriver.serve): Updated regex that determines http server port from 'lsof' output to support ipv6 address.
46         (SimpleHTTPServerDriver.kill_server): Added null check for 'self._server_process'.
47
48 2019-05-28  David Xiong  <w_xiong@apple.com>
49
50         webkitpy: Switch run-webkit-tests to tailspin
51         https://bugs.webkit.org/show_bug.cgi?id=198144
52         <rdar://problem/32463212>
53
54         Reviewed by Jonathan Bedard.
55
56         Changes run-webkit-tests to run tailspin on test time out
57         rather than spindump, and edited tests to look for tailspin logs
58         instead.
59
60         * Scripts/webkitpy/port/darwin.py:
61         (DarwinPort.sample_process): Replaced spindump with tailspin (+ symbolication)
62         (DarwinPort):
63         (DarwinPort.tailspin_file_path):
64         (DarwinTest.spindump_file_path): Deleted.
65         * Scripts/webkitpy/port/darwin_testcase.py:
66         (DarwinTest.test_tailspin): Changed spindump test (below) to test for tailspin instead
67         (DarwinTest.test_spindump): Deleted.
68         (DarwinTest.test_spindump.logging_run_command): Deleted.
69         * Scripts/webkitpy/port/ios_device_unittest.py:
70         (IOSDeviceTest.test_tailspin): Changed spindump tests (inc. below) to test for tailspin instead
71         (IOSDeviceTest.test_sample_process.logging_run_command):
72         (IOSDeviceTest.test_sample_process_exception.throwing_run_command):
73         (IOSDeviceTest.test_spindump): Deleted.
74         (IOSDeviceTest.test_spindump.logging_run_command): Deleted.
75
76 2019-05-28  David Xiong  <w_xiong@apple.com>
77
78         webkitpy: Using sudo on iOS device during timeout spindumps 
79         https://bugs.webkit.org/show_bug.cgi?id=198142
80
81         Reviewed by Jonathan Bedard.
82
83         * Scripts/webkitpy/port/darwin.py:
84         (DarwinPort.sample_process): Check target host instead of source host for sudo command.
85
86 2019-05-28  Aakash Jain  <aakash_jain@apple.com>
87
88         [ews-build] Remove unused buildbot tabs
89         https://bugs.webkit.org/show_bug.cgi?id=198108
90
91         Reviewed by Jonathan Bedard.
92
93         * BuildSlaveSupport/ews-build/templates/build.jade: Removed unused 'Changes' and 'Responsible Users' tabs.
94
95 2019-05-27  Carlos Garcia Campos  <cgarcia@igalia.com>
96
97         [GTK] Use WPEBackend-fdo for accelerating compositing in Wayland instead of the nested compositor
98         https://bugs.webkit.org/show_bug.cgi?id=197944
99
100         Reviewed by Michael Catanzaro.
101
102         Add WPEBackend-fdo to jhbuild moduleset.
103
104         * gtk/jhbuild.modules:
105
106 2019-05-27  Wenson Hsieh  <wenson_hsieh@apple.com>
107
108         [iOS] Dropping in an editable element should result in a ranged selection
109         https://bugs.webkit.org/show_bug.cgi?id=198267
110         <rdar://problem/51145977>
111
112         Reviewed by Tim Horton.
113
114         Adjust some existing API tests that currently check for selection rects after a drop. Instead of checking for
115         visible selection rects, simply check for the start caret rect, as determined by WKContentView's
116         -selectionRange.
117
118         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
119         (TestWebKitAPI::TEST):
120         (makeCGRectValue): Deleted.
121         (checkSelectionRectsWithLogging): Deleted.
122         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
123
124         Replace finalSelectionRects with finalSelectionStartRect.
125
126         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
127         (-[DragAndDropSimulator _resetSimulatedState]):
128         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
129         (-[DragAndDropSimulator finalSelectionRects]): Deleted.
130
131 2019-05-27  Oriol Brufau  <obrufau@igalia.com>
132
133         [css-grid] Preserve repeat() notation when serializing declared values
134         https://bugs.webkit.org/show_bug.cgi?id=197840
135
136         Reviewed by Manuel Rego Casasnovas.
137
138         Adapt CSSPropertyParserTest to CSSGridIntegerRepeatValue.
139
140         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
141         (TestWebKitAPI::computeNumberOfTracks):
142
143 2019-05-26  Wenson Hsieh  <wenson_hsieh@apple.com>
144
145         [iOS] Dropped text, attachments, and images should animate into place
146         https://bugs.webkit.org/show_bug.cgi?id=198243
147         <rdar://problem/35205373>
148
149         Reviewed by Tim Horton.
150
151         Adjusts the iOS dragging simulator, and adds a new API test. See below for more detail.
152
153         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
154         (TestWebKitAPI::isCompletelyWhite):
155         (TestWebKitAPI::TEST):
156
157         Add a test that drags and drops an image into a contenteditable element, and then observes the resulting
158         UITargetedDragPreviews upon drop.
159
160         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
161         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
162         (-[DragAndDropSimulator _resetSimulatedState]):
163         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
164         (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
165
166         Teach the iOS version of DragAndDropSimulator to invoke -dropInteraction:concludeDrop: on the drop interaction
167         delegate when the drop finishes. This additionally uses _doAfterReceivingEditDragSnapshotForTesting: to defer
168         the end of the simulated drag and drop until after drag previews have been received during an edit drag.
169
170         (-[DragAndDropSimulator dropPreviews]):
171         (-[DragAndDropSimulator delayedDropPreviews]):
172
173         Have the drag and drop simulator remember which previews were returned by the delegate on drop, as well as which
174         previews were provided asynchronously.
175
176         (-[DragAndDropSimulator _webView:dataInteractionOperationWasHandled:forSession:itemProviders:]):
177         * TestWebKitAPI/ios/UIKitSPI.h:
178
179         Stage the new private drop interacton delegate method.
180
181 2019-05-25  Simon Fraser  <simon.fraser@apple.com>
182
183         MobileMiniBrowser: Add iPad support, and allow insecure loads
184         https://bugs.webkit.org/show_bug.cgi?id=198249
185
186         Reviewed by Tim Horton.
187
188         Add iPad support to MobileMiniBrowser, and allow insecure loads.
189
190         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
191         * MobileMiniBrowser/MobileMiniBrowser/Info.plist:
192
193 2019-05-25  Wenson Hsieh  <wenson_hsieh@apple.com>
194
195         [iOS] Respect -[NSItemProvider preferredPresentationSize] when dropping images
196         https://bugs.webkit.org/show_bug.cgi?id=198242
197
198         Reviewed by Beth Dakin.
199
200         Add a new test that simulates dropping an image with a preferred presentation size into an editable element
201         with attachment elements enabled.
202
203         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
204         (TestWebKitAPI::TEST):
205
206 2019-05-24  Yusuke Suzuki  <ysuzuki@apple.com>
207
208         Make display-profiler-output work with newer HighLine
209         https://bugs.webkit.org/show_bug.cgi?id=198205
210
211         Reviewed by Saam Barati.
212
213         Newer HighLine does not have SystemExtensions. Access @terminal member in default instance of HighLine.
214
215         * Scripts/display-profiler-output:
216
217 2019-05-23  Fujii Hironori  <Hironori.Fujii@sony.com>
218
219         run-webkit-tests: Remove feature detection support
220         https://bugs.webkit.org/show_bug.cgi?id=198105
221
222         Reviewed by Jonathan Bedard.
223
224         Feature detection support was added to DRT for Windows and old
225         run-webkit-tests in Bug 35610. It was added for NRWT in Bug 41842.
226         But, it doesn't work for DRT for Windows because of feature name
227         mismatches. Since USE(ACCELERATED_COMPOSITING) flag has been
228         removed in Bug 127833, it is not needed anymore.
229
230         * DumpRenderTree/win/DumpRenderTree.cpp:
231         (main):
232         * Scripts/webkitpy/port/base.py:
233         (Port._tests_for_other_platforms):
234         (Port._skipped_tests_for_unsupported_features):
235         (Port._runtime_feature_list): Deleted.
236         (Port.nm_command): Deleted.
237         (Port._modules_to_search_for_symbols): Deleted.
238         (Port._symbols_string): Deleted.
239         (Port._missing_feature_to_skipped_tests): Deleted.
240         (Port._has_test_in_directories): Deleted.
241         * Scripts/webkitpy/port/darwin.py:
242         (DarwinPort.make_command):
243         (DarwinPort.nm_command): Deleted.
244         * Scripts/webkitpy/port/ios_simulator.py:
245         (IOSSimulatorPort.reset_preferences):
246         (IOSSimulatorPort.nm_command): Deleted.
247         * Scripts/webkitpy/port/port_testcase.py:
248         (TestWebKitPort.__init__):
249         (TestWebKitPort.all_test_configurations):
250         (PortTestCase.test_path_to_test_expectations_file):
251         (TestWebKitPort._symbols_string): Deleted.
252         (PortTestCase.test_skipped_directories_for_features): Deleted.
253         (PortTestCase.test_skipped_directories_for_features_no_matching_tests_in_test_list): Deleted.
254         (PortTestCase.test_skipped_tests_for_unsupported_features_empty_test_list): Deleted.
255         * Scripts/webkitpy/port/watch_simulator.py:
256         (WatchSimulatorPort.reset_preferences):
257         (WatchSimulatorPort.nm_command): Deleted.
258         * Scripts/webkitpy/port/win.py:
259         (WinPort.show_results_html_file):
260         (WinPort._runtime_feature_list): Deleted.
261         * Scripts/webkitpy/port/win_unittest.py:
262         (WinPortTest.test_operating_system):
263         (WinPortTest.test_runtime_feature_list): Deleted.
264         * WebKitTestRunner/Options.cpp:
265         (WTR::OptionsHandler::OptionsHandler):
266         (WTR::handleOptionPrintSupportedFeatures): Deleted.
267         * WebKitTestRunner/Options.h:
268         * WebKitTestRunner/TestController.cpp:
269         (WTR::TestController::initialize):
270
271 2019-05-23  Commit Queue  <commit-queue@webkit.org>
272
273         Unreviewed, rolling out r245665.
274         https://bugs.webkit.org/show_bug.cgi?id=198203
275
276         Inspector appears blank, again. (Requested by NVI on #webkit).
277
278         Reverted changeset:
279
280         "Web Inspector: Provide UIString descriptions to improve
281         localizations"
282         https://bugs.webkit.org/show_bug.cgi?id=195132
283         https://trac.webkit.org/changeset/245665
284
285 2019-05-23  Stephan Szabo  <stephan.szabo@sony.com>
286
287         [Win][CMake] Pass architecture to cmake via -A for both x64 and Win32
288         https://bugs.webkit.org/show_bug.cgi?id=198098
289
290         Reviewed by Don Olmstead.
291
292         With current CMake and Visual Studio 2019, the default
293         architecture will match the host, so we should make sure
294         to explicitly mention the architecture we want for 32-bit
295         builds as well for cases where we are on x64 and not in an
296         x64_x32 cross-build vcvars environment.
297
298         * Scripts/webkitdirs.pm:
299         (getVisualStudioToolset): Get toolset name for cmake/msbuild
300         (getMSBuildPlatformArgument): Update to use getVisualStudioToolset
301         (getCMakeWindowsToolsetArgument): Get -A argument for cmake
302         based on toolset
303         (generateBuildSystemFromCMakeProject): Remove explicit -A x64
304         in 64-bit mode in favor of new getCMakeWindowsToolsetArgument.
305
306 2019-05-23  Youenn Fablet  <youenn@apple.com>
307
308         Set default WebsiteDataStore storage quota based on StorageQuotaManager
309         https://bugs.webkit.org/show_bug.cgi?id=198133
310         <rdar://problem/51031436>
311
312         Reviewed by Geoffrey Garen.
313
314         * TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm:
315         (doTest):
316
317 2019-05-23  Keith Rollin  <krollin@apple.com>
318
319         generate-xcfilelists should not store temporary build files in /tmp
320         https://bugs.webkit.org/show_bug.cgi?id=198136
321
322         Reviewed by Jonathan Bedard.
323
324         Provide the build infrastructure control of the location of
325         generate-xcfilelists' temporary files by creating them in the build
326         directory when possible.
327
328         * Scripts/webkitpy/generate_xcfilelists_lib/application.py:
329         (get_xcode_project_temp_dir):
330         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
331         (BaseGenerator._generate_derived):
332         (BaseGenerator._generate_unified):
333         (BaseGenerator):
334         (BaseGenerator._get_temp_dir):
335
336 2019-05-23  Philippe Normand  <philn@igalia.com>
337
338         [JHBuild][GStreamer] Enable libsrtp
339         https://bugs.webkit.org/show_bug.cgi?id=198041
340
341         Reviewed by Xabier Rodriguez-Calvar.
342
343         * gstreamer/jhbuild.modules: Enable libsrtp. The system version
344         can't be used from Stretch because it's too old.
345
346 2019-05-22  Ryan Haddad  <ryanhaddad@apple.com>
347
348         Move win-ews queue bubble to Win10 section of dashboard
349         https://bugs.webkit.org/show_bug.cgi?id=198159
350
351         Reviewed by Alexey Proskuryakov.
352
353         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
354         (BubbleQueueServer): Change platform to Windows10 to match the OS version of the bots.
355
356 2019-05-22  Myles C. Maxfield  <mmaxfield@apple.com>
357
358         [Mac] Add API test to make sure the system font is drawn just like in native code
359         https://bugs.webkit.org/show_bug.cgi?id=198010
360
361         Reviewed by Daniel Bates.
362
363         We can compare the width of using font-family:system-ui to a CTLine.
364
365         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
366         * TestWebKitAPI/Tests/WebKitCocoa/TextWidth.html: Added.
367         * TestWebKitAPI/Tests/WebKitCocoa/TextWidth.mm: Added.
368         (TEST):
369
370 2019-05-22  Nikita Vasilyev  <nvasilyev@apple.com>
371
372         Web Inspector: Provide UIString descriptions to improve localizations
373         https://bugs.webkit.org/show_bug.cgi?id=195132
374         <rdar://problem/48457817>
375
376         Reviewed by Devin Rousso.
377
378         Allow WI.UIString to take:
379         - WI.UIString(string, key, comment)
380         - WI.UIString(string, comment)
381         - WI.UIString(string)
382
383         * Scripts/extract-localizable-js-strings:
384
385 2019-05-22  Wenson Hsieh  <wenson_hsieh@apple.com>
386
387         [iOS] The shouldIgnoreMetaViewport test option incorrectly persists across layout tests
388         https://bugs.webkit.org/show_bug.cgi?id=198135
389         <rdar://problem/51001306>
390
391         Reviewed by Alexey Proskuryakov.
392
393         When shouldIgnoreMetaViewport=true is specified on a test, if the following test does not use a flexible
394         viewport, we will continue ignoring the meta viewport, since we'll bail before we attempt to reset
395         WKPreferences' _shouldIgnoreMetaViewport property to NO.
396
397         We fix this by simply allowing shouldIgnoreMetaViewport to take precedence over useFlexibleViewport, such that
398         -[WKPreferences _shouldIgnoreMetaViewport] will always be updated to its intended value between tests.
399
400         * WebKitTestRunner/ios/TestControllerIOS.mm:
401         (WTR::TestController::platformConfigureViewForTest):
402
403 2019-05-22  Sihui Liu  <sihui_liu@apple.com>
404
405         API Test landed in r245540 [Mac WK2] TestWebKitAPI.WKWebView.LocalStorageProcessCrashes is a flaky failure
406         https://bugs.webkit.org/show_bug.cgi?id=198090
407         <rdar://problem/51003644>
408
409         Reviewed by Youenn Fablet.
410
411         WebView was wrongly loaded multiple times.
412
413         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
414         (TEST):
415
416 2019-05-22  Jiewen Tan  <jiewen_tan@apple.com>
417
418         [WebAuthN] Support Attestation Conveyance Preference
419         https://bugs.webkit.org/show_bug.cgi?id=192722
420         <rdar://problem/49939647>
421
422         Reviewed by Brent Fulgham.
423
424         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
425         (TestWebKitAPI::TEST):
426         Updates the test with AttestationConveyancePreference.
427
428 2019-05-22  Zalan Bujtas  <zalan@apple.com>
429
430         [Paste] Add support for preferred presentation size when pasting an image
431         https://bugs.webkit.org/show_bug.cgi?id=198132
432         <rdar://problem/50886917>
433
434         Reviewed by Wenson Hsieh.
435
436         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
437         (TestWebKitAPI::TEST):
438
439 2019-05-22  Keith Rollin  <krollin@apple.com>
440
441         Use a different variable when testing for Xcode context in generate-xcfilelists
442         https://bugs.webkit.org/show_bug.cgi?id=198130
443         <rdar://problem/51032752>
444
445         Reviewed by Jonathan Bedard.
446
447         The generate-xcfilelists script can run stand-alone or in the context
448         of Xcode. There are a couple of places where it helps to know which
449         context is current. To determine the context, genreate-xfilelists
450         checks an environment variable that should be defined only when Xcode
451         is running. The variable chosen was XCODE_INSTALL_PATH. It turns out
452         that this variable is not always defined. Therefore, switch to
453         checking XCODE_PRODUCT_BUILD_VERSION.
454
455         * Scripts/webkitpy/generate_xcfilelists_lib/util.py:
456         (subprocess_run):
457         (is_running_under_xcode):
458
459 2019-05-22  Carlos Garcia Campos  <cgarcia@igalia.com>
460
461         Unreviewed. Fix WPE unit tests after r245565
462
463         Backend creation is failing when the a11y bus is not running because atk produces warning messages. We should
464         not make warnings fatal during backend creation.
465
466         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
467         (testAutomationSessionRequestSession):
468         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
469         (testWebViewGeolocationPermissionRequests):
470         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
471         (Test::createWebViewBackend):
472         (Test::addLogFatalFlag):
473         (Test::removeLogFatalFlag):
474
475 2019-05-21  Aakash Jain  <aakash_jain@apple.com>
476
477         [ews-build] Use custom templates for Buildbot (follow-up fix)
478         https://bugs.webkit.org/show_bug.cgi?id=198076
479
480         Unreviewed minor follow-up fix.
481
482         * BuildSlaveSupport/ews-build/templates/build.jade:
483
484 2019-05-21  Alex Christensen  <achristensen@webkit.org>
485
486         Fix branch build.
487         <rdar://problem/50625279>
488
489         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
490         We need to explicitly include WebKit.h on the branch.
491
492 2019-05-21  Aakash Jain  <aakash_jain@apple.com>
493
494         [ews-build] Use custom templates for Buildbot
495         https://bugs.webkit.org/show_bug.cgi?id=198076
496
497         Rubber-stamped by Jonathan Bedard.
498
499         * BuildSlaveSupport/ews-build/master.cfg:
500         * BuildSlaveSupport/ews-build/templates: Added.
501         * BuildSlaveSupport/ews-build/templates/build.jade: Copied from https://github.com/buildbot/buildbot/blob/v1.7.0/www/base/src/app/builders/builds/build.tpl.jade
502
503 2019-05-21  Chris Dumez  <cdumez@apple.com>
504
505         [PSON] Assertion hit when navigating back after a process swap forced by the client
506         https://bugs.webkit.org/show_bug.cgi?id=198006
507
508         Reviewed by Alex Christensen.
509
510         Add API test coverage.
511
512         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
513
514 2019-05-21  Carlos Garcia Campos  <cgarcia@igalia.com>
515
516         Unreviewed. Fix the build with HAVE(ACCESSIBILITY) disabled
517
518         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
519         (WTR::AccessibilityController::elementAtPoint):
520         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
521         (WTR::AccessibilityController::rootElement):
522         (WTR::AccessibilityController::focusedElement):
523
524 2019-05-21  Carlos Garcia Campos  <cgarcia@igalia.com>
525
526         [WPE] Add initial accessibility support using ATK
527         https://bugs.webkit.org/show_bug.cgi?id=197413
528
529         Reviewed by Michael Catanzaro.
530
531         Add accessibility support in MiniBrowser and backends used by MiniBrowser and tests.
532
533         * MiniBrowser/wpe/CMakeLists.txt:
534         * MiniBrowser/wpe/main.cpp:
535         (main):
536         * TestWebKitAPI/PlatformWPE.cmake:
537         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
538         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
539         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
540         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
541         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
542         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
543         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityControllerWPE.cpp: Removed.
544         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp: Removed.
545         * WebKitTestRunner/PlatformWPE.cmake:
546         * wpe/backends/CMakeLists.txt:
547         * wpe/backends/HeadlessViewBackend.cpp:
548         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend):
549         * wpe/backends/ViewBackend.cpp:
550         (WPEToolingBackends::addKeyEventListener):
551         (WPEToolingBackends::removeKeyEventListener):
552         (WPEToolingBackends::notifyAccessibilityKeyEventListeners):
553         (WPEToolingBackends::ViewBackend::initialize):
554         (WPEToolingBackends::ViewBackend::initializeAccessibility):
555         (WPEToolingBackends::ViewBackend::updateAccessibilityState):
556         (WPEToolingBackends::ViewBackend::setAccessibleChild):
557         (WPEToolingBackends::ViewBackend::addActivityState):
558         (WPEToolingBackends::ViewBackend::removeActivityState):
559         (WPEToolingBackends::ViewBackend::dispatchInputKeyboardEvent):
560         * wpe/backends/ViewBackend.h:
561         * wpe/backends/WebKitAccessibleApplication.cpp: Added.
562         (webkitAccessibleApplicationWindowInterfaceInit):
563         (webkitAccessibleApplicationFinalize):
564         (webkitAccessibleApplicationInitialize):
565         (webkitAccessibleApplicationGetNChildren):
566         (webkitAccessibleApplicationRefChild):
567         (webkitAccessibleApplicationGetName):
568         (webkit_accessible_application_class_init):
569         (webkit_accessible_application_init):
570         (webkitAccessibleApplicationNew):
571         (webkitAccessibleApplicationSetChild):
572         * wpe/backends/WebKitAccessibleApplication.h: Added.
573         * wpe/backends/WindowViewBackend.cpp:
574         (WPEToolingBackends::WindowViewBackend::WindowViewBackend):
575         * wpe/jhbuild.modules:
576
577 2019-05-20  Fujii Hironori  <Hironori.Fujii@sony.com>
578
579         run-webkit-tests not gathering crash logs on Cygwin Python and Windows Python
580         https://bugs.webkit.org/show_bug.cgi?id=179828
581
582         Reviewed by Jonathan Bedard.
583
584         ServerProcess should store its Windows PID for Cygwin before
585         process crashing because the Windows PID is required to get a
586         correct CrashLog.
587
588         CrashLog format has been changed. CrashLogs.GLOBAL_PID_REGEX
589         should accept the new format.
590
591         * Scripts/webkitpy/common/system/crashlogs.py:
592         (CrashLogs.GLOBAL_PID_REGEX): Accept any words between 'Global' and 'PID:'.
593
594         * Scripts/webkitpy/port/driver.py:
595         (Driver.has_crashed):
596         (Driver._check_for_driver_crash_or_unresponsiveness):
597         (Driver._read_block):
598         Store server_process.system_pid() to self._crashed_pid instead of server_process.pid().
599
600         * Scripts/webkitpy/port/server_process.py:
601         (ServerProcess.__init__):
602         (ServerProcess.system_pid): Added.
603         (ServerProcess._find_system_pid): Added.
604         (ServerProcess._start): Set self._system_pid.
605         * Scripts/webkitpy/port/win.py:
606         (WinPort._get_crash_log): Removed broken old code converting Cygwin pid to Windows pid.
607
608 2019-05-20  Aakash Jain  <aakash_jain@apple.com>
609
610         Windows 10 test results missing on flakiness dashboard
611         https://bugs.webkit.org/show_bug.cgi?id=198058
612
613         Rubber-stamped by Alexey Proskuryakov.
614
615         * TestResultServer/static-dashboards/flakiness_dashboard.js:
616
617 2019-05-20  Sihui Liu  <sihui_liu@apple.com>
618
619         Move Web Storage to Network Process
620         https://bugs.webkit.org/show_bug.cgi?id=197636
621  
622         Reviewed by Youenn Fablet.
623  
624         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
625         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageDatabaseTracker.mm: Remove the wait for database file update.
626         (TEST):
627         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm: Add a test for network process crash recovery.
628         (TEST):
629         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm: Fix a typo and add a test case to cover it.
630         * TestWebKitAPI/Tests/WebKitCocoa/local-storage-process-crashes.html: Added.
631
632 2019-05-20  Keith Rollin  <krollin@apple.com>
633
634         generate-xcfilelists is stranding temporary files
635         https://bugs.webkit.org/show_bug.cgi?id=198008
636         <rdar://problem/50893659>
637
638         Reviewed by Jonathan Bedard.
639
640         generate-xcfilelists makes use of temporary files on disk. These files
641         are opened with the OS's "temporary" bit set, causing them to get
642         deleted when closed or the process exists. However, these temporary
643         files actually end up persisting after the script exists. This is
644         because `sed` is used to process the files, and is done so in a way
645         that causes the "temporary" bit to get cleared.
646
647         Address this issue by no longer using `sed` and instead performing the
648         equivalent processing the file content in-memory.
649
650         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
651         (BaseGenerator._generate_derived):
652         (BaseGenerator._generate_unified):
653         (BaseGenerator._replace):
654         (BaseGenerator._unexpand):
655         (BaseGenerator._find_added_lines.get_lines):
656         (BaseGenerator._find_added_lines):
657
658 2019-05-20  Ludovico de Nittis  <ludovico.denittis@collabora.com>
659
660         [WPE][Qt] Use C++17 instead of C++14
661         https://bugs.webkit.org/show_bug.cgi?id=197415
662
663         Reviewed by Philippe Normand.
664
665         There was a regression introduced with the commit https://bugs.webkit.org/show_bug.cgi?id=197131
666         The WPE Qt port was not updated to C++17 and this leaded to a compilation error.
667
668         * TestWebKitAPI/glib/CMakeLists.txt:
669
670 2019-05-20  Ludovico de Nittis  <ludovico.denittis@collabora.com>
671
672         [Flatpak][Qt] Meson: Unknown type feature for gstreamer
673         https://bugs.webkit.org/show_bug.cgi?id=197408
674
675         Reviewed by Philippe Normand.
676
677         This is a regression that has been introduced when
678         GStreamer was updated to version 1.16.0
679         https://bugs.webkit.org/show_bug.cgi?id=197157
680
681         Now GStreamer requires meson >= 0.47.0
682         Updating the Kde runtime to version 5.12 we fulfill
683         this requirement.
684
685         * flatpak/org.webkit.WPEQT.yaml:
686
687 2019-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
688
689         [GLIB] Crash when instantiating a js object registered with jsc_context_register_class on window object cleared
690         https://bugs.webkit.org/show_bug.cgi?id=198037
691
692         Reviewed by Michael Catanzaro.
693
694         Add a test case to check the crash is fixed.
695
696         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
697         (testWebExtensionWindowObjectCleared):
698         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
699         (windowObjectCleared):
700
701 2019-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
702
703         [GLIB] Repeating timer is not stopped when stop is called from the callback
704         https://bugs.webkit.org/show_bug.cgi?id=197986
705
706         Reviewed by Michael Catanzaro.
707
708         Check the timer is no longer active after it has been stopped.
709
710         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
711         (TestWebKitAPI::TEST):
712
713 2019-05-19  Darin Adler  <darin@apple.com>
714
715         Change String::number to use "shortest" instead of "fixed precision 6 digits"
716         https://bugs.webkit.org/show_bug.cgi?id=178319
717
718         Reviewed by Sam Weinig.
719
720         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
721         (TestWebKitAPI::testStringNumberFixedPrecision): Use String::numberToStringFixedPrecision.
722
723         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
724         (attributesOfElement): Use appendFixedPrecisionNumber.
725
726 2019-05-18  Jiewen Tan  <jiewen_tan@apple.com>
727
728         [WebAuthN] Allow authenticators that support both CTAP and U2F to try U2F if CTAP fails in authenticatorGetAssertion
729         https://bugs.webkit.org/show_bug.cgi?id=197974
730         <rdar://problem/50879746>
731
732         Reviewed by Brent Fulgham.
733
734         Add a canDowngrade option for mock hid devices to simulate the situation.
735
736         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
737         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
738
739 2019-05-18  Tadeu Zagallo  <tzagallo@apple.com>
740
741         Add extra information to dumpJITMemory
742         https://bugs.webkit.org/show_bug.cgi?id=197998
743
744         Reviewed by Saam Barati.
745
746         Add description for the new dumpJITMemory trace point code.
747
748         * Tracing/SystemTracePoints.plist:
749
750 2019-05-17  Justin Michaud  <justin_michaud@apple.com>
751
752         [WASM-References] Add support for Anyref in parameters and return types, Ref.null and Ref.is_null for Anyref values.
753         https://bugs.webkit.org/show_bug.cgi?id=197969
754
755         Run wasm tests additionally with wasmBBQUsesAir=0.
756
757         Reviewed by Keith Miller.
758
759         * Scripts/run-jsc-stress-tests:
760
761 2019-05-17  Don Olmstead  <don.olmstead@sony.com>
762
763         [CMake] Use builtin FindICU
764         https://bugs.webkit.org/show_bug.cgi?id=197934
765
766         Reviewed by Michael Catanzaro.
767
768         Remove uses of ICU_INCLUDE_DIRS and ICU_LIBRARIES.
769
770         * TestWebKitAPI/PlatformMac.cmake:
771         * TestWebKitAPI/PlatformPlayStation.cmake:
772         * TestWebKitAPI/PlatformWin.cmake:
773         * WebKitTestRunner/CMakeLists.txt:
774
775 2019-05-17  Alex Christensen  <achristensen@webkit.org>
776
777         Enable legacy EME for iOS WKWebView
778         https://bugs.webkit.org/show_bug.cgi?id=197964
779         <rdar://problem/50625666>
780
781         Reviewed by Wenson Hsieh.
782
783         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
784         (TEST):
785
786 2019-05-17  Aakash Jain  <aakash_jain@apple.com>
787
788         [ews-build] Add clickable url in UI for uploaded S3 archive
789         https://bugs.webkit.org/show_bug.cgi?id=197996
790
791         Reviewed by Jonathan Bedard.
792
793         * BuildSlaveSupport/ews-build/steps.py:
794
795 2019-05-17  Aakash Jain  <aakash_jain@apple.com>
796
797         [ews-app] Status bubble should not turn orange when any build step has warnings
798         https://bugs.webkit.org/show_bug.cgi?id=198000
799
800         Reviewed by Jonathan Bedard.
801
802         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
803         (StatusBubble._does_build_contains_any_failed_step):
804
805 2019-05-17  Alex Christensen  <achristensen@webkit.org>
806
807         Add SPI to set a list of hosts to which to send custom header fields cross-origin
808         https://bugs.webkit.org/show_bug.cgi?id=197397
809
810         Reviewed by Geoff Garen.
811
812         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
813         (TEST):
814         (expectLegacyHeaders):
815         (expectHeaders):
816         (-[CustomHeaderFieldsDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
817         (-[CustomHeaderFieldsDelegate webView:startURLSchemeTask:]):
818         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
819
820 2019-05-17  Keith Rollin  <krollin@apple.com>
821
822         Unreviewed build fix.
823
824         Teach generate-xcfilelists about iphonesimulator.
825
826         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
827         (JavaScriptCoreGenerator):
828         (WebCoreGenerator):
829         (WebKitGenerator):
830
831 2019-05-17  Keith Rollin  <krollin@apple.com>
832
833         Re-enable generate-xcfilelists
834         https://bugs.webkit.org/show_bug.cgi?id=197933
835         <rdar://problem/50831677>
836
837         Reviewed by Jonathan Bedard.
838
839         The following two tasks have been completed, and we can re-enable
840         generate-xcfilelists:
841
842         Bug 197619 <rdar://problem/50507392> Temporarily disable generate-xcfilelists (197619)
843         Bug 197622 <rdar://problem/50508222> Rewrite generate-xcfilelists in Python (197622)
844
845         * DumpRenderTree/Scripts/check-xcfilelists.sh:
846         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
847
848 2019-05-17  Commit Queue  <commit-queue@webkit.org>
849
850         Unreviewed, rolling out r245401.
851         https://bugs.webkit.org/show_bug.cgi?id=197990
852
853         Causing internal build failures (Requested by ShawnRoberts on
854         #webkit).
855
856         Reverted changeset:
857
858         "Add SPI to set a list of hosts to which to send custom header
859         fields cross-origin"
860         https://bugs.webkit.org/show_bug.cgi?id=197397
861         https://trac.webkit.org/changeset/245401
862
863 2019-05-17  Commit Queue  <commit-queue@webkit.org>
864
865         Unreviewed, rolling out r245418.
866         https://bugs.webkit.org/show_bug.cgi?id=197989
867
868         New API test causing crashes on Mojave testers (Requested by
869         ShawnRoberts on #webkit).
870
871         Reverted changeset:
872
873         "Add a unit test for client certificate authentication"
874         https://bugs.webkit.org/show_bug.cgi?id=197800
875         https://trac.webkit.org/changeset/245418
876
877 2019-05-17  Aakash Jain  <aakash_jain@apple.com>
878
879         [ews-build] Add build step to Transfer archive to S3
880         https://bugs.webkit.org/show_bug.cgi?id=197922
881
882         Reviewed by Jonathan Bedard.
883
884         * BuildSlaveSupport/ews-build/steps.py:
885         (TransferToS3):
886         (TransferToS3.finished): Invoke triggers after transfer is successful.
887         (TransferToS3.getResultSummary): Create more readable failure string.
888         (UploadBuiltProduct.finished): Deleted. Moved the trigger invocation after TransferToS3.
889         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
890
891 2019-05-16  Carlos Garcia Campos  <cgarcia@igalia.com>
892
893         [GTK] Need WebKitContextMenuItemType to open emoji picker
894         https://bugs.webkit.org/show_bug.cgi?id=176760
895
896         Reviewed by Michael Catanzaro.
897
898         Update context menu test to check insert emoji action is included in default context menu for editable content.
899
900         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
901
902 2019-05-16  Aakash Jain  <aakash_jain@apple.com>
903
904         [ews-build] Download archives from S3
905         https://bugs.webkit.org/show_bug.cgi?id=197949
906
907         Reviewed by Jonathan Bedard.
908
909         * BuildSlaveSupport/ews-build/steps.py:
910         (DownloadBuiltProduct): Updated to use S3 URL.
911         (DownloadBuiltProduct.getResultSummary): Method to display custom failure string.
912         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
913
914 2019-05-16  David Kilzer  <ddkilzer@apple.com>
915
916         REGRESSION (r15133): Fix leak of JSStringRef in minidom
917         <https://webkit.org/b/197968>
918         <rdar://problem/50872430>
919
920         Reviewed by Joseph Pecoraro.
921
922         * TestWebKitAPI/Tests/WebKitObjC/UserContentTest.mm:
923         (expectScriptValueIsString): Drive-by fix to use adopt() instead
924         of JSRetainPtr<JSStringRef> string(Adopt, JSValueToStringCopy(...)).
925
926 2019-05-16  David Kilzer  <ddkilzer@apple.com>
927
928         REGRESSION (r84160): Leak of OpaqueJSString under WTR::JSTestRunner::pathToLocalResource (32 bytes) in com.apple.WebKit.WebContent running layout tests
929         <https://webkit.org/b/197965>
930
931         Reviewed by Joseph Pecoraro.
932
933         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
934         (WTR::TestRunner::pathToLocalResource): Don't call
935         JSStringRetain() here because the JSRetainPtr<JSStringRef>
936         return type will increment the retain count for us.
937
938 2019-05-16  Alex Christensen  <achristensen@webkit.org>
939
940         Add a unit test for client certificate authentication
941         https://bugs.webkit.org/show_bug.cgi?id=197800
942
943         Reviewed by Youenn Fablet.
944
945         Make better abstractions for reading and writing from/to TCPServer.
946         Add a unit test that causes a client certificate authentication challenge to happen.
947
948         * TestWebKitAPI/TCPServer.cpp:
949         (TestWebKitAPI::TCPServer::TCPServer):
950         (TestWebKitAPI::TCPServer::read):
951         (TestWebKitAPI::TCPServer::write):
952         (TestWebKitAPI::TCPServer::respondWithChallengeThenOK):
953         (TestWebKitAPI::TCPServer::respondWithOK):
954         * TestWebKitAPI/TCPServer.h:
955         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
956         (credentialWithIdentity):
957         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
958         (TEST):
959         (-[ClientCertificateDelegate webView:didFinishNavigation:]):
960         (-[ClientCertificateDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
961         (-[ClientCertificateDelegate challengeCount]):
962         (TestWebKitAPI::TEST):
963         (respondWithChallengeThenOK): Deleted.
964         (credentialWithIdentityAndKeychainPath): Deleted.
965         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
966         (TEST):
967         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
968         (TestWebKitAPI::TEST):
969         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
970         (TEST):
971         (readRequest): Deleted.
972         (writeResponse): Deleted.
973         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
974         (TestWebKitAPI::TEST):
975         (TestWebKitAPI::respondWithChallengeThenOK): Deleted.
976
977 2019-05-16  Alex Christensen  <achristensen@webkit.org>
978
979         Add SPI to set a list of hosts to which to send custom header fields cross-origin
980         https://bugs.webkit.org/show_bug.cgi?id=197397
981
982         Reviewed by Geoff Garen.
983
984         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
985         (TEST):
986         (expectLegacyHeaders):
987         (expectHeaders):
988         (-[CustomHeaderFieldsDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
989         (-[CustomHeaderFieldsDelegate webView:startURLSchemeTask:]):
990         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
991
992 2019-05-15  Aakash Jain  <aakash_jain@apple.com>
993
994         Replace double-quotes with single quotes in steps.py
995         https://bugs.webkit.org/show_bug.cgi?id=197921
996
997         Reviewed by Jonathan Bedard.
998
999         * BuildSlaveSupport/ews-build/steps.py:
1000
1001 2019-05-15  Keith Rollin  <krollin@apple.com>
1002
1003         Rewrite generate-xcfilelists in Python
1004         https://bugs.webkit.org/show_bug.cgi?id=197622
1005         <rdar://problem/50508222>
1006
1007         Reviewed by Jonathan Bedard, Alex Christensen.
1008
1009         For a number of reasons, rewrite generate-xcfilelists in Python:
1010
1011         - The previous bash script was large and unmaintainable.
1012         - We have more internal expertise with Python than with bash.
1013         - The bash script used temporary files in /tmp that got stranded and
1014           were owned by root, making them awkward to clear out.
1015           <rdar://problem/49490262>
1016         - We needed to complete support for engineers that built with Xcode
1017           rather than the command line.
1018         - There are some bugs leading to mildly corrupted .xcfilelist files.
1019           It's not apparent the source of the bugs, but one general reason
1020           might be due to approaches born of using bash. Rewriting in Python
1021           may clear these up.
1022
1023         * Scripts/generate-xcfilelists:
1024         * Scripts/webkitpy/common/attribute_saver.py: Added.
1025         (AttributeSaver):
1026         (AttributeSaver.__init__):
1027         (AttributeSaver.__enter__):
1028         (AttributeSaver.__exit__):
1029         * Scripts/webkitpy/common/attribute_saver_unittest.py: Added.
1030         (AttributeSaverTest):
1031         (AttributeSaverTest.SimpleTestClass):
1032         (AttributeSaverTest.SimpleTestClass.__init__):
1033         (AttributeSaverTest.test_class):
1034         (AttributeSaverTest.test_normal_default):
1035         (AttributeSaverTest.test_normal_value):
1036         (AttributeSaverTest.test_normal_value_on_exception):
1037         (AttributeSaverTest.test_normal_value_on_normal_exit):
1038         (AttributeSaverTest.test_normal_value_with_finally_on_exception):
1039         (AttributeSaverTest.test_normal_value_with_finally_on_normal_exit):
1040         (AttributeSaverTest.test_normal_value_with_else_on_exception):
1041         (AttributeSaverTest.test_normal_value_with_else_on_normal_exit):
1042         * Scripts/webkitpy/generate_xcfilelists_lib/__init__.py: Added.
1043         * Scripts/webkitpy/generate_xcfilelists_lib/application.py: Added.
1044         (Application):
1045         (Application.__init__):
1046         (Application.run):
1047         (Application._initialize):
1048         (Application._initialize.collect_attributes):
1049         (Application._create_parser):
1050         (_validate_args):
1051         (_cmd_generate):
1052         (_cmd_check):
1053         (_cmd_subgenerate):
1054         (_cmd_help):
1055         (_do_generate):
1056         (_do_merge):
1057         (_report_results):
1058         (_report_merge_results):
1059         (_report_remediation_steps):
1060         (_report_remediation_steps.add_to_message):
1061         (_any_have_errors):
1062         (_any_have_actions):
1063         (_log_progress):
1064         (_log_results):
1065         (get_generate_xcfilelists_script_path):
1066         (_get_root_dir):
1067         (get_opensource_dir):
1068         (get_build_scripts_dir):
1069         (get_extract_dependencies_from_makefile_script):
1070         (get_xcode_built_products_dir):
1071         (_getenv):
1072         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py: Added.
1073         (BaseGenerator):
1074         (BaseGenerator.__init__):
1075         (BaseGenerator.__str__):
1076         (BaseGenerator.generate):
1077         (BaseGenerator._sublaunch_under_xcode):
1078         (BaseGenerator.subgenerate):
1079         (BaseGenerator.merge):
1080         (BaseGenerator.pickle_to_file):
1081         (BaseGenerator.has_action):
1082         (BaseGenerator.has_error):
1083         (BaseGenerator.is_valid):
1084         (BaseGenerator.report_error):
1085         (BaseGenerator._generate_derived):
1086         (BaseGenerator._merge_derived):
1087         (BaseGenerator._generate_unified):
1088         (BaseGenerator._merge_unified):
1089         (BaseGenerator._replace):
1090         (BaseGenerator._unexpand):
1091         (BaseGenerator._find_added_lines):
1092         (BaseGenerator._merge_added_lines):
1093         (BaseGenerator._get_file_lines):
1094         (BaseGenerator._getenv):
1095         (BaseGenerator._get_project_file_path):
1096         (BaseGenerator._get_project_dir):
1097         (BaseGenerator._get_project_file_name):
1098         (BaseGenerator._get_project_name):
1099         (BaseGenerator._get_sym_root):
1100         (BaseGenerator._get_obj_root):
1101         (BaseGenerator._get_shared_precomps_dir):
1102         (BaseGenerator._get_build_dirs):
1103         (BaseGenerator._get_build_dirs.define_xcode_build_dirs):
1104         (BaseGenerator._get_build_dirs.define_xcode_build_dirs.read_xcode_user_default):
1105         (BaseGenerator._get_build_dirs.define_command_line_build_dirs):
1106         (BaseGenerator._get_derived_sources_dir):
1107         (BaseGenerator._get_xcfilelist_dir):
1108         (BaseGenerator._get_input_derived_xcfilelist_project_path):
1109         (BaseGenerator._get_output_derived_xcfilelist_project_path):
1110         (BaseGenerator._get_input_unified_xcfilelist_project_path):
1111         (BaseGenerator._get_output_unified_xcfilelist_project_path):
1112         (BaseGenerator._get_generate_derived_sources_script):
1113         (BaseGenerator._get_generate_unified_sources_script):
1114         (JavaScriptCoreGenerator):
1115         (JavaScriptCoreGenerator._get_project_file_path):
1116         (JavaScriptCoreGenerator._get_generate_derived_sources_script):
1117         (JavaScriptCoreGenerator._get_generate_unified_sources_script):
1118         (WebCoreGenerator):
1119         (WebCoreGenerator._get_project_file_path):
1120         (WebCoreGenerator._get_generate_derived_sources_script):
1121         (WebCoreGenerator._get_generate_unified_sources_script):
1122         (WebKitGenerator):
1123         (WebKitGenerator._get_project_file_path):
1124         (WebKitGenerator._get_derived_sources_dir):
1125         (WebKitGenerator._get_generate_derived_sources_script):
1126         (WebKitGenerator._get_generate_unified_sources_script):
1127         (DumpRenderTreeGenerator):
1128         (DumpRenderTreeGenerator._get_project_file_path):
1129         (DumpRenderTreeGenerator._get_generate_derived_sources_script):
1130         (WebKitTestRunnerGenerator):
1131         (WebKitTestRunnerGenerator._get_project_file_path):
1132         (WebKitTestRunnerGenerator._get_generate_derived_sources_script):
1133         * Scripts/webkitpy/generate_xcfilelists_lib/util.py: Added.
1134         (debug_log):
1135         (LogEntryHelper):
1136         (LogEntryHelper.__init__):
1137         (LogEntryHelper.log_entry):
1138         (LogEntryHelper.log_result):
1139         (LogEntryHelper.log_exception):
1140         (LogEntryHelper._print):
1141         (LogEntryExit):
1142         (LogEntryExit._show_debug_logging):
1143         (LogEntryExitClass):
1144         (LogEntryExitClass._show_debug_logging):
1145         (LogEntryExitGlobal):
1146         (LogEntryExitGlobal._show_debug_logging):
1147         (subprocess_run):
1148         (is_running_under_xcode):
1149         (CheckValidItemAction):
1150         (CheckValidItemAction.__init__):
1151         (CheckValidItemAction.__call__):
1152         (CheckValidItemAction.validate_item):
1153         (CheckCommandAction):
1154         (CheckCommandAction.__call__):
1155         (InvalidCommandError):
1156         (InvalidArgumentError):
1157         (InvalidConfigurationError):
1158         (CalledProcessError):
1159         (CalledProcessError.__str__):
1160         * Scripts/webkitpy/xcode/__init__.py:
1161         (xcode_hash_for_path):
1162         (xcode_hash_for_path.convert_to_string):
1163         * Scripts/webkitpy/xcode/sdk.py: Added.
1164         (SDK):
1165         (SDK.__init__):
1166         (SDK.__repr__):
1167         (SDK.as_xcode_specification):
1168         (SDK.get_preferred_sdk_for_platform):
1169         (SDK._parse_sdk):
1170         * Scripts/webkitpy/xcode/sdk_unittest.py: Added.
1171         (SDKTest):
1172
1173 2019-05-15  Aakash Jain  <aakash_jain@apple.com>
1174
1175         [ews-build] Enabling uploading EWS archives to S3
1176         https://bugs.webkit.org/show_bug.cgi?id=197914
1177
1178         Reviewed by Jonathan Bedard.
1179
1180         * BuildSlaveSupport/Shared: Added.
1181         * BuildSlaveSupport/Shared/transfer-archive-to-s3: Moved from Tools/BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3.
1182         (archiveExists): Replace tab with space.
1183         (main): Added main method.
1184         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1185         (TransferToS3): Updated path to the script.
1186         * BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3: Moved to Shared folder.
1187
1188 2019-05-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1189
1190         inputmode="numeric" should show a number pad with digits 0-9, instead of the numeric keyplane
1191         https://bugs.webkit.org/show_bug.cgi?id=197916
1192         <rdar://problem/50815427>
1193
1194         Reviewed by Timothy Hatcher.
1195
1196         Re-enable this previously flaky test, and rebaseline the result to to expect UIKeyboardTypeNumberPad for
1197         inputmode="numeric".
1198
1199         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1200         (TestWebKitAPI::TEST):
1201
1202 2019-05-15  Youenn Fablet  <youenn@apple.com>
1203
1204         Reuse existing WebPageProxy quota handler for NetworkProcessProxy quota requests
1205         https://bugs.webkit.org/show_bug.cgi?id=197463
1206         <rdar://problem/47403621>
1207
1208         Reviewed by Alex Christensen.
1209
1210         * TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm: Added.
1211         (-[QuotaDelegate init]):
1212         (-[QuotaDelegate _webView:decideDatabaseQuotaForSecurityOrigin:currentQuota:currentOriginUsage:currentDatabaseUsage:expectedUsage:decisionHandler:]):
1213         (-[QuotaDelegate quotaDelegateCalled]):
1214         (-[QuotaDelegate grantQuota]):
1215         (-[StorageSchemes webView:startURLSchemeTask:]):
1216         (-[StorageSchemes webView:stopURLSchemeTask:]):
1217         (-[QuotaMessageHandler userContentController:didReceiveScriptMessage:]):
1218         (doTest):
1219
1220 2019-05-15  Youenn Fablet  <youenn@apple.com>
1221
1222         Constant crashes under WebPage::isThrottleable() after r245299
1223         https://bugs.webkit.org/show_bug.cgi?id=197902
1224         <rdar://problem/50793796>
1225
1226         Reviewed by Alex Christensen.
1227
1228         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1229
1230 2019-05-15  Philippe Normand  <pnormand@igalia.com>
1231
1232         [GTK][jhbuild] misc cleanups and bumps
1233         https://bugs.webkit.org/show_bug.cgi?id=197913
1234
1235         Reviewed by Xabier Rodriguez-Calvar.
1236
1237         * gstreamer/jhbuild.modules: Bump to libva 2.4.1 and switch to Meson.
1238         * gtk/jhbuild.modules: Bump to Brotli 1.0.5 and Wayland 1.16.
1239
1240 2019-05-15  Chris Dumez  <cdumez@apple.com>
1241
1242         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
1243         https://bugs.webkit.org/show_bug.cgi?id=195102
1244         <rdar://problem/48456786>
1245
1246         Reviewed by Alex Christensen.
1247
1248         Try to wait longer for the number of processes to reach the expected number
1249         and before failing.
1250
1251         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1252
1253 2019-05-15  Alex Christensen  <achristensen@webkit.org>
1254
1255         Allow NSFileCoordinator to be called from WebContent process
1256         https://bugs.webkit.org/show_bug.cgi?id=197895
1257         <rdar://problem/50107679>
1258
1259         Reviewed by Brent Fulgham.
1260
1261         Add a unit test that verifies calling the block succeeds.
1262
1263         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLsPlugin.mm:
1264         (-[AdditionalReadAccessAllowedURLsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1265
1266 2019-05-14  Andy Estes  <aestes@apple.com>
1267
1268         [Apple Pay] Payment APIs should be completely disabled in web views into which clients have injected user scripts
1269         https://bugs.webkit.org/show_bug.cgi?id=197751
1270         <rdar://problem/50631563>
1271
1272         Reviewed by Alex Christensen.
1273
1274         Added new API tests.
1275
1276         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm:
1277         (-[TestApplePayScriptMessageHandler initWithAPIsAvailableExpectation:canMakePaymentsExpectation:]):
1278         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1279         (TestWebKitAPI::TEST):
1280         (-[TestApplePayScriptMessageHandler initWithExpectation:]): Deleted.
1281         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html:
1282
1283 2019-05-14  Youenn Fablet  <youenn@apple.com>
1284
1285         A service worker process should app nap when all its clients app nap
1286         https://bugs.webkit.org/show_bug.cgi?id=185626
1287         <rdar://problem/46785908>
1288
1289         Reviewed by Alex Christensen.
1290
1291         Allow to enable app nap through test header.
1292
1293         * WebKitTestRunner/TestController.cpp:
1294         (WTR::TestController::resetPreferencesToConsistentValues):
1295         (WTR::updateTestOptionsFromTestHeader):
1296         * WebKitTestRunner/TestOptions.h:
1297         (WTR::TestOptions::hasSameInitializationOptions const):
1298
1299 2019-05-14  Commit Queue  <commit-queue@webkit.org>
1300
1301         Unreviewed, rolling out r245281.
1302         https://bugs.webkit.org/show_bug.cgi?id=197887
1303
1304         Broke API Test TestWebKitAPI.Challenge.ClientCertificate
1305         (Requested by aakashjain on #webkit).
1306
1307         Reverted changeset:
1308
1309         "Add a unit test for client certificate authentication"
1310         https://bugs.webkit.org/show_bug.cgi?id=197800
1311         https://trac.webkit.org/changeset/245281
1312
1313 2019-05-14  Youenn Fablet  <youenn@apple.com>
1314
1315         Add support for webkit-test-runner options to WPT importer
1316         https://bugs.webkit.org/show_bug.cgi?id=197826
1317
1318         Reviewed by Alex Christensen.
1319
1320         In case of overwriting an existing test, check if the existing test
1321         contains a <!-- webkit-test-runner --> comment and insert it back if
1322         needed in the new test.
1323
1324         For exporter, forbid creating a WPT PR if there are changes containing
1325         the webkit-test-runner string.
1326
1327         * Scripts/webkitpy/w3c/test_converter.py:
1328         (convert_for_webkit):
1329         (_W3CTestConverter.__init__):
1330         (_W3CTestConverter.add_webkit_test_runner_options_if_needed):
1331         (_W3CTestConverter.handle_starttag):
1332         (_W3CTestConverter.handle_comment):
1333         (_W3CTestConverter.handle_decl):
1334         (_W3CTestConverter.handle_pi):
1335         * Scripts/webkitpy/w3c/test_exporter.py:
1336         (WebPlatformTestExporter.write_git_patch_file):
1337         (WebPlatformTestExporter.make_pull_request):
1338         * Scripts/webkitpy/w3c/test_importer.py:
1339         (TestImporter.webkit_test_runner_options):
1340         (TestImporter):
1341         (TestImporter.add_webkit_test_runner_options_to_content):
1342         (TestImporter.copy_html_file):
1343         (TestImporter.write_html_template):
1344         (TestImporter.write_html_files_for_templated_js_tests):
1345         (TestImporter.import_tests):
1346         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1347         (test_manual_slow_test):
1348         (test_webkit_test_runner_options):
1349
1350 2019-05-14  Aakash Jain  <aakash_jain@apple.com>
1351
1352         [ews-app] Status bubble should turn orange when any build step fails
1353         https://bugs.webkit.org/show_bug.cgi?id=197812
1354
1355         Reviewed by Jonathan Bedard.
1356
1357         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1358         (StatusBubble._build_bubble): Turn status-bubble orange if there is any failed step in the on-going build.
1359         (StatusBubble._does_build_contains_any_failed_step): Method to check if build contains any failed step.
1360
1361 2019-05-14  Alex Christensen  <achristensen@webkit.org>
1362
1363         Add a unit test for client certificate authentication
1364         https://bugs.webkit.org/show_bug.cgi?id=197800
1365
1366         Reviewed by Youenn Fablet.
1367
1368         Make better abstractions for reading and writing from/to TCPServer.
1369         Add a unit test that causes a client certificate authentication challenge to happen.
1370
1371         * TestWebKitAPI/TCPServer.cpp:
1372         (TestWebKitAPI::TCPServer::TCPServer):
1373         (TestWebKitAPI::TCPServer::read):
1374         (TestWebKitAPI::TCPServer::write):
1375         (TestWebKitAPI::TCPServer::respondWithChallengeThenOK):
1376         (TestWebKitAPI::TCPServer::respondWithOK):
1377         * TestWebKitAPI/TCPServer.h:
1378         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1379         (credentialWithIdentity):
1380         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1381         (TEST):
1382         (-[ClientCertificateDelegate webView:didFinishNavigation:]):
1383         (-[ClientCertificateDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1384         (-[ClientCertificateDelegate challengeCount]):
1385         (TestWebKitAPI::TEST):
1386         (respondWithChallengeThenOK): Deleted.
1387         (credentialWithIdentityAndKeychainPath): Deleted.
1388         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
1389         (TEST):
1390         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
1391         (TestWebKitAPI::TEST):
1392         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1393         (TEST):
1394         (readRequest): Deleted.
1395         (writeResponse): Deleted.
1396         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1397         (TestWebKitAPI::TEST):
1398         (TestWebKitAPI::respondWithChallengeThenOK): Deleted.
1399
1400 2019-05-14  Said Abou-Hallawa  <sabouhallawa@apple.com>
1401
1402         [CG] Adding support for HEIF-sequence ('public.heics') images
1403         https://bugs.webkit.org/show_bug.cgi?id=197384
1404
1405         Reviewed by Simon Fraser.
1406
1407         * DumpRenderTree/TestOptions.cpp:
1408         (TestOptions::TestOptions):
1409         * DumpRenderTree/TestOptions.h:
1410         * DumpRenderTree/mac/DumpRenderTree.mm:
1411         (resetWebViewToConsistentStateBeforeTesting):
1412         Parse the new webkit-test-runner paramter: additionalSupportedImageTypes.
1413         Make DRT call setAdditionalSupportedImageTypesForTesting() before starting
1414         the test.
1415
1416         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1417         (WTR::InjectedBundle::stringForKey):
1418         (WTR::InjectedBundle::beginTesting):
1419         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1420         * WebKitTestRunner/TestController.cpp:
1421         (WTR::TestController::resetStateToConsistentValues):
1422         (WTR::updateTestOptionsFromTestHeader):
1423         * WebKitTestRunner/TestInvocation.cpp:
1424         (WTR::TestInvocation::createTestSettingsDictionary):
1425         * WebKitTestRunner/TestOptions.h:
1426         (WTR::TestOptions::hasSameInitializationOptions const):
1427         Parse the new webkit-test-runner paramter: additionalSupportedImageTypes.
1428         Make WTR call setAdditionalSupportedImageTypesForTesting() before starting
1429         the test.
1430
1431 2019-05-12  Yusuke Suzuki  <ysuzuki@apple.com>
1432
1433         [JSC] Compress Watchpoint size by using enum type and Packed<> data structure
1434         https://bugs.webkit.org/show_bug.cgi?id=197730
1435
1436         Reviewed by Filip Pizlo.
1437
1438         * TestWebKitAPI/CMakeLists.txt:
1439         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1440         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1441         (TestWebKitAPI::TEST):
1442         * TestWebKitAPI/Tests/WTF/Packed.cpp: Added.
1443         (TestWebKitAPI::TEST):
1444
1445 2019-05-10  Chris Dumez  <cdumez@apple.com>
1446
1447         Unreviewed, fix ProcessSwap.OpenerLinkAfterAPIControlledProcessSwappingOfOpener API test
1448
1449         It became flaky after r245198.
1450
1451         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1452
1453 2019-05-10  Youenn Fablet  <youenn@apple.com>
1454
1455         A service worker instance should be terminated when its SWServer is destroyed
1456         https://bugs.webkit.org/show_bug.cgi?id=197801
1457         <rdar://problem/50587270>
1458
1459         Reviewed by Chris Dumez.
1460
1461         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1462
1463 2019-05-10  Chris Dumez  <cdumez@apple.com>
1464
1465         Do not wait until requestPermission() is called to fire deviceorientation events if permission was already granted
1466         https://bugs.webkit.org/show_bug.cgi?id=197750
1467
1468         Reviewed by Geoffrey Garen.
1469
1470         Add API test coverage.
1471
1472         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
1473         (TEST):
1474
1475 2019-05-10  Keith Miller  <keith_miller@apple.com>
1476
1477         Remove legacy test262 import script
1478         https://bugs.webkit.org/show_bug.cgi?id=197788
1479
1480         Reviewed by Yusuke Suzuki.
1481
1482         import-test262-tests doesn't work anymore. We should be using test262-import instead.
1483
1484         * Scripts/import-test262-tests: Removed.
1485
1486 2019-05-10  Charlie Turner  <cturner@igalia.com>
1487
1488         [WPE] Forward libepoxy cflags
1489         https://bugs.webkit.org/show_bug.cgi?id=197784
1490
1491         Reviewed by Žan Doberšek.
1492
1493         Patch by Zan Dobersek.
1494
1495         * wpe/backends/CMakeLists.txt: This is required to keep
1496         -DMESA_EGL_NO_X11_HEADERS in the build, if we don't do this, EGL ends
1497         up trying to include X11 headers even when they're not present in the
1498         environment.
1499
1500 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1501
1502         Fix a bunch of compiler warnings
1503         https://bugs.webkit.org/show_bug.cgi?id=197785
1504
1505         Reviewed by Don Olmstead.
1506
1507         Add preprocessor guards to avoid -Wunused-function warnings.
1508
1509         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
1510         * TestWebKitAPI/Tests/WebCore/IntRect.cpp:
1511         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp:
1512
1513 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1514
1515         [WPE][GTK] Add webkit_frame_get_id() API
1516         https://bugs.webkit.org/show_bug.cgi?id=197270
1517
1518         Reviewed by Carlos Garcia Campos.
1519
1520         This was hard, but I added a test to verify that two different WebKitFrames of the same
1521         WebKitWebPage return two different frame IDs.
1522
1523         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
1524         (WebKitFrameTest::willSubmitFormCallback):
1525         (WebKitFrameTest::testSubframe):
1526         (registerTests):
1527         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
1528         (testWebKitFrameSubframe):
1529         (beforeAll):
1530         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1531         (willSubmitFormCallback):
1532         * TestWebKitAPI/Tests/WebKitGLib/resources/form-in-frame.html: Added.
1533         * TestWebKitAPI/Tests/WebKitGLib/resources/webkitglib-tests.gresource.xml:
1534
1535 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1536
1537         [WPE][GTK] Add WebKitWebPage::did-associate-form-controls-for-frame and deprecate original did-associate-form-controls
1538         https://bugs.webkit.org/show_bug.cgi?id=197271
1539
1540         Reviewed by Youenn Fablet.
1541
1542         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1543         (formControlsAssociatedForFrameCallback):
1544         (pageCreatedCallback):
1545         (formControlsAssociatedCallback): Deleted.
1546
1547 2019-05-10  Adrian Perez de Castro  <aperez@igalia.com>
1548
1549         [Flatpak] Use the safe PyYAML loader if available
1550         https://bugs.webkit.org/show_bug.cgi?id=197771
1551
1552         Reviewed by Philippe Normand.
1553
1554         * flatpak/flatpakutils.py:
1555         (load_manifest): Use yaml.safe_load() if available, with yaml.load()
1556         still used as fallback when the former is not provided by the module.
1557
1558 2019-05-09  Fujii Hironori  <Hironori.Fujii@sony.com>
1559
1560         WinCairo WebKitTestRunner should take platform/wk2/TestExpectations into account
1561         https://bugs.webkit.org/show_bug.cgi?id=197734
1562
1563         Reviewed by Don Olmstead.
1564
1565         * Scripts/webkitpy/port/win.py:
1566         (WinCairoPort._search_paths): Add 'wk2' and
1567         additional_platform_directory to paths as well as other ports do.
1568
1569 2019-05-09  Daniel Bates  <dabates@apple.com>
1570
1571         [iOS] Numpad comma key has incorrect keyIdentifier property
1572         https://bugs.webkit.org/show_bug.cgi?id=197753
1573         <rdar://problem/50636274>
1574
1575         Reviewed by Brent Fulgham.
1576
1577         Recognize "numpadComma" and return the appropriate HID usage code.
1578
1579         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1580         (hidUsageCodeForCharacter):
1581
1582 2019-05-09  Eric Carlson  <eric.carlson@apple.com>
1583
1584         Refine AudioSession route sharing policy
1585         https://bugs.webkit.org/show_bug.cgi?id=197742
1586         <rdar://problem/50590818>
1587
1588         Reviewed by Darin Adler.
1589
1590         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
1591         (TestWebKitAPI::TEST):
1592
1593 2019-05-09  Alex Christensen  <achristensen@webkit.org>
1594
1595         Remove unnecessary test SPI after r244883
1596         https://bugs.webkit.org/show_bug.cgi?id=197575
1597
1598         Reviewed by Tim Horton.
1599
1600         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1601         (TEST):
1602         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1603         (TestWebKitAPI::TEST):
1604
1605 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
1606
1607         [ews-app] Add migrations file to repository
1608         https://bugs.webkit.org/show_bug.cgi?id=197729
1609
1610         Reviewed by Jonathan Bedard.
1611
1612         * BuildSlaveSupport/ews-app/ews/migrations/0001_initial.py: Added. Auto-generated by Django based on models' information.
1613
1614 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
1615
1616         [ews-build] Fix formatting issues and typos
1617         https://bugs.webkit.org/show_bug.cgi?id=197737
1618
1619         Reviewed by Jonathan Bedard.
1620
1621         * BuildSlaveSupport/ews-build/steps.py:
1622         (CompileWebKit.evaluateCommand): Removed extra empty line.
1623         * BuildSlaveSupport/ews-build/steps_unittest.py:
1624         (TestRunWebKitPerlTests): Fixed typo.
1625         * BuildSlaveSupport/ews-app/ews/models/step.py:
1626         (Step.save_step): Changed log level to info so that it is logged in production.
1627
1628 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
1629
1630         [ews-app] Production and Development env should configure DEBUG appropriately
1631         https://bugs.webkit.org/show_bug.cgi?id=197700
1632
1633         Reviewed by Jonathan Bedard.
1634
1635         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1636
1637 2019-05-09  Xan López  <xan@igalia.com>
1638
1639         [CMake] Detect SSE2 at compile time
1640         https://bugs.webkit.org/show_bug.cgi?id=196488
1641
1642         Reviewed by Carlos Garcia Campos.
1643
1644         * Scripts/webkitdirs.pm:
1645         (generateBuildSystemFromCMakeProject): Do not add SSE2 flags here
1646         for x86 builds. This is now handled in WebKitCompilerFlags.cmake.
1647
1648 2019-05-08  Adrian Perez de Castro  <aperez@igalia.com>
1649
1650         [WPE] Update dependencies to use libwpe + WPEBackend-fdo 1.3.0
1651         https://bugs.webkit.org/show_bug.cgi?id=197697
1652
1653         Reviewed by Žan Doberšek.
1654
1655         * flatpak/org.webkit.WPEModules.yaml: Bump version and update checksums.
1656         * wpe/jhbuild.modules: Ditto.
1657
1658 2019-05-08  Don Olmstead  <don.olmstead@sony.com>
1659
1660         Update ANGLE
1661         https://bugs.webkit.org/show_bug.cgi?id=197676
1662
1663         Reviewed by Alex Christensen.
1664
1665         * TestWebKitAPI/PlatformWin.cmake:
1666         Remove unnecessary library linkage.
1667
1668 2019-05-08  Stephan Szabo  <stephan.szabo@sony.com> and Fujii Hironori  <Hironori.Fujii@sony.com>
1669
1670         [Win] build-webkit should be ready for Visual Studio 2019
1671         https://bugs.webkit.org/show_bug.cgi?id=196622
1672
1673         Reviewed by Ross Kirsling.
1674
1675         1. Accommodated to the new msbuild.exe location of VS 2019.
1676         2. Removed the hard coded "Visual Studio 15" generator.
1677
1678         build-webkit is going to choose a Visual Studio generator version
1679         matching with the latest installed VS. If you invoke vcvars.bat
1680         before build-webkit, it chooses the corresponding Visual Studio
1681         generator version by cheking 'VisualStudioVersion' env var which
1682         is set by vcvars.bat.
1683
1684         * Scripts/webkitdirs.pm: Renamed $vcBuildPath to $msBuildPath. Removed $msBuildInstallDir.
1685         (msBuildPath): When looking for MSBuild, look in
1686         "MSBuild\Current\bin" (the new expected location) and fallback
1687         to "MSBuild\15.0\bin" if we can't find an MSBuild.exe in the
1688         first location.
1689         (msBuildInstallDir): Renamed to msBuildPath.
1690         (generateBuildSystemFromCMakeProject): Use -A switch to specify x64.
1691         Add -G "Visual Studio " switch if a env var 'VisualStudioVersion'
1692
1693 2019-05-08  Don Olmstead  <don.olmstead@sony.com>
1694
1695         [PlayStation] Update port options
1696         https://bugs.webkit.org/show_bug.cgi?id=197723
1697
1698         Reviewed by Ross Kirsling.
1699
1700         ICU headers were missing from TestWTF.
1701
1702         * TestWebKitAPI/PlatformPlayStation.cmake:
1703
1704 2019-05-08  Alex Christensen  <achristensen@webkit.org>
1705
1706         Don't crash when DOMNode.addEventListener:listener:useCapture: is called with a nil listener
1707         https://bugs.webkit.org/show_bug.cgi?id=197712
1708         <rdar://problem/50429770>
1709
1710         Reviewed by Tim Horton.
1711
1712         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm:
1713         (TestWebKitAPI::TEST):
1714
1715 2019-05-08  Jonathan Bedard  <jbedard@apple.com>
1716
1717         Change my status to be a WebKit reviewer.
1718
1719         * Scripts/webkitpy/common/config/contributors.json:
1720
1721 2019-05-08  Ryan Haddad  <ryanhaddad@apple.com>
1722
1723         Unreviewed, rolling out r244952.
1724
1725         Caused inspector to appear blank.
1726
1727         Reverted changeset:
1728
1729         "Web Inspector: Provide UIString descriptions to improve
1730         localizations"
1731         https://bugs.webkit.org/show_bug.cgi?id=195132
1732         https://trac.webkit.org/changeset/244952
1733
1734 2019-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1735
1736         TestRunnerWKWebView's menu callbacks should be cleared upon UI script completion
1737         https://bugs.webkit.org/show_bug.cgi?id=197685
1738
1739         Reviewed by Alex Christensen.
1740
1741         Fixes a bug in the test runner wherein didShowMenuCallback and didHideMenuCallback are not reset upon UI script
1742         completion. See LayoutTests/ChangeLog for more details.
1743
1744         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1745         (WTR::UIScriptController::platformClearAllCallbacks):
1746
1747 2019-05-07  Oriol Brufau  <obrufau@igalia.com>
1748
1749         Unreviewed. Add myself as a committer.
1750
1751         * Scripts/webkitpy/common/config/contributors.json:
1752
1753 2019-05-07  Ryan Haddad  <ryanhaddad@apple.com>
1754
1755         Unreviewed, rolling out r245038.
1756
1757         Breaks internal builds.
1758
1759         Reverted changeset:
1760
1761         "Add SPI to set a list of hosts to which to send custom header
1762         fields cross-origin"
1763         https://bugs.webkit.org/show_bug.cgi?id=197397
1764         https://trac.webkit.org/changeset/245038
1765
1766 2019-05-07  Joonghun Park  <pjh0718@gmail.com>
1767
1768         Unreviewed. Add myself as a committer.
1769
1770         * Scripts/webkitpy/common/config/contributors.json:
1771
1772 2019-05-07  Eric Carlson  <eric.carlson@apple.com>
1773
1774         Define media buffering policy
1775         https://bugs.webkit.org/show_bug.cgi?id=196979
1776         <rdar://problem/28383861>
1777
1778         Reviewed by Jer Noble.
1779
1780         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1781         * TestWebKitAPI/Tests/WebKitCocoa/MediaBufferingPolicy.mm: Added.
1782         (waitUntilBufferingPolicyIsEqualTo):
1783         (TEST):
1784
1785 2019-05-07  Alex Christensen  <achristensen@webkit.org>
1786
1787         Add SPI to set a list of hosts to which to send custom header fields cross-origin
1788         https://bugs.webkit.org/show_bug.cgi?id=197397
1789
1790         Reviewed by Geoff Garen.
1791
1792         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1793         (TEST):
1794         (expectLegacyHeaders):
1795         (expectHeaders):
1796         (-[CustomHeaderFieldsDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
1797         (-[CustomHeaderFieldsDelegate webView:startURLSchemeTask:]):
1798         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
1799
1800 2019-05-07  Keith Rollin  <krollin@apple.com>
1801
1802         Add option to build-webkit to control whether or not XCBuild is used
1803         https://bugs.webkit.org/show_bug.cgi?id=197668
1804         <rdar://problem/50549728>
1805
1806         Reviewed by Tim Horton.
1807
1808         Add --[no-]xcbuild to build-webkit to force the use of XCBuild or not.
1809         Also update build-webkit and the makefiles with the foundation for
1810         automatically using XCBuild when the conditions allow it. This latter
1811         facility is currently turned off until Xcode fully supports building
1812         WebKit with XCBuild.
1813
1814         * Scripts/build-webkit:
1815         * Scripts/webkitdirs.pm:
1816         (XcodeOptions):
1817         (canUseXCBuild):
1818
1819 2019-05-07  Andy Estes  <aestes@apple.com>
1820
1821         run-bindings-tests should test global scope constructor generation
1822         https://bugs.webkit.org/show_bug.cgi?id=197669
1823
1824         Reviewed by Alex Christensen.
1825
1826         * Scripts/webkitpy/bindings/main.py:
1827         Updated to specify --testGlobalContextName and --testGlobalScopeConstructorsFile when
1828         invoking preprocess-idls.pl.
1829
1830 2019-05-07  Youenn Fablet  <youenn@apple.com>
1831
1832         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageDefaultDirectories
1833         https://bugs.webkit.org/show_bug.cgi?id=195997
1834         <rdar://problem/50509884>
1835
1836         Reviewed by Chris Dumez.
1837
1838         Spin test until successful.
1839
1840         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1841
1842 2019-05-07  Adrian Perez de Castro  <aperez@igalia.com>
1843
1844         [Flatpak] webkit-build fails due to missing GTK2 in build environment
1845         https://bugs.webkit.org/show_bug.cgi?id=197352
1846
1847         Reviewed by Philippe Normand.
1848
1849         The Flatpak runtimes do not include GTK 2.x anymore, which means that we need
1850         to build it ourselves on top in order to be able to build the GTK 2.x plugin
1851         process.
1852
1853         * flatpak/org.webkit.GTK.yaml: Add gtk2 package.
1854
1855 2019-05-07  Wenson Hsieh  <wenson_hsieh@apple.com>
1856
1857         [macOS] Avoid crashing the UI process when writing empty data to the pasteboard
1858         https://bugs.webkit.org/show_bug.cgi?id=197644
1859         <rdar://problem/50526364>
1860
1861         Reviewed by Tim Horton.
1862
1863         Add a new API test to exercise a possible scenario where we may crash while writing data to the pasteboard.
1864
1865         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
1866         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
1867         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1868         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:pasteboardDataForRange:]):
1869
1870 2019-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1871
1872         [GTK][WPE] MiniBrowser: load about:blank for new web views in automation mode
1873         https://bugs.webkit.org/show_bug.cgi?id=197651
1874
1875         Reviewed by Žan Doberšek.
1876
1877         This is required since the process creation was delayed until something is loaded in the view.
1878
1879         * MiniBrowser/gtk/BrowserWindow.c:
1880         (browser_window_get_or_create_web_view_for_automation):
1881         * MiniBrowser/wpe/main.cpp:
1882         (main):
1883
1884 2019-05-06  Tim Horton  <timothy_horton@apple.com>
1885
1886         _overrideViewportWithArguments does not work when called before loading
1887         https://bugs.webkit.org/show_bug.cgi?id=197638
1888         <rdar://problem/50505111>
1889
1890         Reviewed by Wenson Hsieh.
1891
1892         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
1893         (TEST):
1894
1895 2019-05-04  Per Arne Vollan  <pvollan@apple.com>
1896
1897         -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
1898         https://bugs.webkit.org/show_bug.cgi?id=197510
1899
1900         Reviewed by Alex Christensen.
1901
1902         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1903         (TestWebKitAPI::TEST):
1904
1905 2019-05-06  Keith Rollin  <krollin@apple.com>
1906
1907         Temporarily disable generate-xcfilelists
1908         https://bugs.webkit.org/show_bug.cgi?id=197619
1909         <rdar://problem/50507392>
1910
1911         Reviewed by Alex Christensen.
1912
1913         We need to perform a significant update to the generate-xcfilelist
1914         scripts. This work involves coordinated work with another facility. If
1915         the work does not occur in tandem, the build will be broken. To avoid
1916         this, disable the invoking of the scripts during the transition. The
1917         checking will be restored once the new scripts are in place.
1918
1919         * DumpRenderTree/Scripts/check-xcfilelists.sh:
1920         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
1921
1922 2019-05-04  Alex Christensen  <achristensen@webkit.org>
1923
1924         Revert r244953 and r244954 because they broke internal builds.
1925         https://bugs.webkit.org/show_bug.cgi?id=197534
1926
1927         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
1928         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1929         * DumpRenderTree/mac/DumpRenderTree.mm:
1930         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1931         * DumpRenderTree/mac/TestRunnerMac.mm:
1932         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1933         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
1934         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1935         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1936         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
1937         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
1938         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
1939         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1940         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1941         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1942         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1943         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
1944         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1945         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1946         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1947         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1948         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1949         * TestWebKitAPI/ios/UIKitSPI.h: Added.
1950         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1951         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
1952         * WebKitTestRunner/ios/HIDEventGenerator.h:
1953         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1954         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1955         * WebKitTestRunner/ios/TestControllerIOS.mm:
1956         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1957         * WebKitTestRunner/ios/mainIOS.mm:
1958
1959 2019-05-04  Alex Christensen  <achristensen@webkit.org>
1960
1961         Merge the three UIKitSPI.h files into a single one in PAL
1962         https://bugs.webkit.org/show_bug.cgi?id=197534
1963
1964         Reviewed by Darin Adler.
1965
1966         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
1967         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1968         * DumpRenderTree/mac/DumpRenderTree.mm:
1969         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1970         * DumpRenderTree/mac/TestRunnerMac.mm:
1971         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1972         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
1973         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1974         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1975         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
1976         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
1977         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
1978         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1979         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1980         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1981         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1982         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
1983         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1984         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1985         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1986         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1987         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1988         * TestWebKitAPI/ios/UIKitSPI.h: Removed.
1989         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1990         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
1991         * WebKitTestRunner/ios/HIDEventGenerator.h:
1992         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1993         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1994         * WebKitTestRunner/ios/TestControllerIOS.mm:
1995         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1996         * WebKitTestRunner/ios/mainIOS.mm:
1997
1998 2019-05-04  Nikita Vasilyev  <nvasilyev@apple.com>
1999
2000         Web Inspector: Provide UIString descriptions to improve localizations
2001         https://bugs.webkit.org/show_bug.cgi?id=195132
2002         <rdar://problem/48457817>
2003
2004         Reviewed by Devin Rousso.
2005
2006         Allow WI.UIString to take:
2007         - WI.UIString(string, key, comment)
2008         - WI.UIString(string, comment)
2009         - WI.UIString(string)
2010
2011         * Scripts/extract-localizable-js-strings:
2012
2013 2019-05-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2014
2015         REGRESSION (r244897): Caret may appear wider than normal after zooming to focus an editable element
2016         https://bugs.webkit.org/show_bug.cgi?id=197579
2017
2018         Reviewed by Tim Horton.
2019
2020         Fixes a couple of flaky layout tests (ModifyInputAssistantItemBarButtonGroups and
2021         OverrideInputAssistantItemBarButtonGroups) by programmatically blurring focused elements and waiting for the
2022         input session to change, rather than relying on -resignFirstResponder and -waitForNextPresentationUpdate to
2023         ensure that the the focused element has been blurred.
2024
2025         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2026
2027 2019-05-02  Alexey Proskuryakov  <ap@apple.com>
2028
2029         Add a tool to block spammer accounts
2030         https://bugs.webkit.org/show_bug.cgi?id=197537
2031
2032         Reviewed by Darin Adler.
2033
2034         Usage: block-spammers email1 email2 ...
2035
2036         The tool finds and hides all bugs and comments from this account. Before any work
2037         is done, these bugs and comments are displayed for confirmation.
2038
2039         * Scripts/block-spammers: Added.
2040         (get_bugzilla_token):
2041         (invalidate_bugzilla_token):
2042         (get_user_info):
2043         (get_user_info_self):
2044         (can_use_this_tool):
2045         (disable_user):
2046         (get_bugs_created_by_user):
2047         (get_bugs_commented_on_by_user):
2048         (get_comments):
2049         (hide_bug):
2050         (hide_comments):
2051         (ask_yes_no):
2052         (sanitized_string):
2053         (main):
2054
2055 2019-05-03  Jonathan Bedard  <jbedard@apple.com>
2056
2057         run-apit-tests: Add --iterations and --repeat-each
2058         https://bugs.webkit.org/show_bug.cgi?id=197563
2059
2060         Reviewed by Aakash Jain.
2061
2062         * Scripts/webkitpy/api_tests/manager.py:
2063         (Manager.run): Add --iterations and --repeat-each/
2064         * Scripts/webkitpy/api_tests/run_api_tests.py:
2065         (parse_args): Duplicate the test list based on --iterations and --repeat-each.
2066
2067 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
2068
2069         New EWS: Clicking on white bubble navigates to page with only bubbles
2070         https://bugs.webkit.org/show_bug.cgi?id=197520
2071
2072         Reviewed by Lucas Forschler.
2073
2074         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Disable clicking if bubble doesn't have any url.
2075
2076 2019-05-03  Daniel Bates  <dabates@apple.com>
2077
2078         [lldb-webkit] Support adding pretty-printing for qualified types
2079         https://bugs.webkit.org/show_bug.cgi?id=197518
2080
2081         Reviewed by Darin Adler.
2082
2083         Remove all "::"s from the name of the specified type when computing the name for the Python classes
2084         that will provide summary and synthetic details as LLDB is not happy about registering such classes
2085         when they contain :: in their name.
2086
2087         * lldb/lldb_webkit.py:
2088         (addSummaryAndSyntheticFormattersForRawBitmaskType):
2089
2090 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
2091
2092         New EWS: patches on recently added queues listed as #1 for older bugs
2093         https://bugs.webkit.org/show_bug.cgi?id=197496
2094
2095         Reviewed by Lucas Forschler.
2096
2097         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2098         (StatusBubble._build_bubble):
2099         (StatusBubble._queue_position):
2100
2101 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
2102
2103         webkit-patch --no-review upload does not submit patch to New EWS
2104         https://bugs.webkit.org/show_bug.cgi?id=197519
2105         <rdar://problem/50424887>
2106
2107         Reviewed by Lucas Forschler.
2108
2109         * Scripts/webkitpy/tool/steps/submittoews.py:
2110         (SubmitToEWS.run): Submit to both old and new EWS.
2111         * Scripts/webkitpy/common/config/urls.py: Added url for new EWS server.
2112         * Scripts/webkitpy/common/net/ewsserver.py: Added.
2113         (EWSServer._server_url): Method to return server url.
2114         (EWSServer._post_patch_to_ews): Method to post patch to ews.
2115         (EWSServer.submit_to_ews): Method to submit the patch to ews using NetworkTransaction.
2116         * Scripts/webkitpy/common/net/ewsserver_mock.py: Added Mock EWS Server.
2117         * Scripts/webkitpy/common/net/ewsserver_unittest.py: Added unit-test for EWS Server.
2118         * Scripts/webkitpy/common/net/statusserver_mock.py:
2119         (MockStatusServer.submit_to_ews): Updated the log text.
2120         * Scripts/webkitpy/tool/commands/queues_unittest.py: Updated unit-tests.
2121         * Scripts/webkitpy/tool/commands/upload_unittest.py: Ditto.
2122         * Scripts/webkitpy/tool/main.py:
2123         (WebKitPatch.__init__): Initialize ews_server. 
2124         * Scripts/webkitpy/tool/mocktool.py:
2125         (MockTool.__init__): Ditto.
2126
2127 2019-05-03  Chris Dumez  <cdumez@apple.com>
2128
2129         ASSERTION FAILED: [weakThis->m_view window] == weakThis->m_targetWindowForMovePreparation
2130         https://bugs.webkit.org/show_bug.cgi?id=197574
2131         <rdar://problem/50453181>
2132
2133         Reviewed by Tim Horton.
2134
2135         Add API test coverage.
2136
2137         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
2138         (TEST):
2139
2140 2019-05-03  Yusuke Suzuki  <ysuzuki@apple.com>
2141
2142         [JSC] Generator CodeBlock generation should be idempotent
2143         https://bugs.webkit.org/show_bug.cgi?id=197552
2144
2145         Reviewed by Keith Miller.
2146
2147         * Scripts/run-javascriptcore-tests:
2148         (runJSCStressTests):
2149         * Scripts/run-jsc-stress-tests:
2150
2151 2019-05-03  Commit Queue  <commit-queue@webkit.org>
2152
2153         Unreviewed, rolling out r244881.
2154         https://bugs.webkit.org/show_bug.cgi?id=197559
2155
2156         Breaks compilation of jsconly on linux, breaking compilation
2157         for jsc-i386-ews, jsc-mips-ews and jsc-armv7-ews (Requested by
2158         guijemont on #webkit).
2159
2160         Reverted changeset:
2161
2162         "[CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into
2163         WEBKIT_COPY_FILES"
2164         https://bugs.webkit.org/show_bug.cgi?id=197174
2165         https://trac.webkit.org/changeset/244881
2166
2167 2019-05-03  Zan Dobersek  <zdobersek@igalia.com>
2168
2169         Unreviewed WPE build fix after r244898.
2170
2171         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
2172         (WTR::TestController::abortModal): Add the missing (no-op) definition.
2173
2174 2019-05-02  Alex Christensen  <achristensen@webkit.org>
2175
2176         Mark U+01C0 as a homograph of U+006C
2177         https://bugs.webkit.org/show_bug.cgi?id=197526
2178         <rdar://problem/50301904>
2179
2180         Reviewed by Tim Horton.
2181
2182         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
2183         (TestWebKitAPI::TEST):
2184
2185 2019-05-02  Chris Dumez  <cdumez@apple.com>
2186
2187         Add test coverage for <rdar://problem/49731231>
2188         https://bugs.webkit.org/show_bug.cgi?id=196730
2189         <rdar://problem/49731231>
2190
2191         Reviewed by Ryosuke Niwa.
2192
2193         Add support for testRunner.abortModal() in macOS's WebKitTestRunner in order
2194         to match DumpRenderTree.
2195
2196         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2197         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2198         (WTR::TestRunner::abortModal):
2199         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2200         * WebKitTestRunner/TestController.cpp:
2201         (WTR::TestController::runModal):
2202         * WebKitTestRunner/TestController.h:
2203         * WebKitTestRunner/TestInvocation.cpp:
2204         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2205         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2206         (WTR::TestController::abortModal):
2207         * WebKitTestRunner/ios/TestControllerIOS.mm:
2208         (WTR::TestController::abortModal):
2209         * WebKitTestRunner/mac/TestControllerMac.mm:
2210         (WTR::TestController::abortModal):
2211         * WebKitTestRunner/win/TestControllerWin.cpp:
2212         (WTR::TestController::abortModal):
2213
2214 2019-05-02  Christopher Reid  <chris.reid@sony.com>
2215
2216         [CMake] Add support for LTO builds
2217         https://bugs.webkit.org/show_bug.cgi?id=188986
2218
2219         Reviewed by Don Olmstead.
2220
2221         Add support to configure --lto-mode with cmake builds.
2222
2223         * Scripts/build-webkit:
2224         * Scripts/webkitdirs.pm:
2225         (generateBuildSystemFromCMakeProject):
2226
2227 2019-05-02  John Wilander  <wilander@apple.com>
2228
2229         Make both filterForRegistrableDomains() in WebKit::NetworkProcess use WebCore::RegistrableDomain::uncheckedCreateFromHost()
2230         https://bugs.webkit.org/show_bug.cgi?id=197521
2231         <rdar://problem/49651503>
2232
2233         Reviewed by Brent Fulgham.
2234
2235         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
2236         (TestWebKitAPI::TEST):
2237            Added a test for host strings with leading dots since they are
2238            often used for the domain attribute in cookies.
2239
2240 2019-05-02  Per Arne Vollan  <pvollan@apple.com>
2241
2242         -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
2243         https://bugs.webkit.org/show_bug.cgi?id=197510
2244
2245         Reviewed by Alex Christensen.
2246
2247         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
2248         (TestWebKitAPI::TEST):
2249
2250 2019-05-02  Don Olmstead  <don.olmstead@sony.com>
2251
2252         [CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into WEBKIT_COPY_FILES
2253         https://bugs.webkit.org/show_bug.cgi?id=197174
2254
2255         Reviewed by Alex Christensen.
2256
2257         Make TestJSC dependent on JavaScriptCorePrivateFrameworkHeaders.
2258
2259         * TestWebKitAPI/PlatformGTK.cmake:
2260         * TestWebKitAPI/PlatformWPE.cmake:
2261
2262 2019-05-02  Alex Christensen  <achristensen@webkit.org>
2263
2264         Build fix for internal branch.
2265
2266         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2267         RetainPtr.h was not explicitly included.
2268
2269 2019-05-02  Jonathan Bedard  <jbedard@apple.com>
2270
2271         webkitpy: Ignore errors when shutting down an already shutdown simulator
2272         <https://bugs.webkit.org/show_bug.cgi?id=197514>
2273         <rdar://problem/50390247>
2274
2275         Reviewed by Lucas Forschler.
2276
2277         * Scripts/webkitpy/xcode/simulated_device.py:
2278         (SimulatedDevice._shut_down):
2279
2280 2019-05-02  Frederic Wang  <fwang@igalia.com>
2281
2282         [GTK][WPE] Disable "thin", "thick", "medium" values of mfrac@linethickness at runtime
2283         https://bugs.webkit.org/show_bug.cgi?id=196142
2284
2285         This patch introduces some experimental runtime flag to let users
2286         disable MathML features that are removed from MathML Core [1]. For now,
2287         these features are only disabled on GTK and WPE ports.
2288
2289         [1] https://mathml-refresh.github.io/mathml-core/
2290
2291         Reviewed by Rob Buis.
2292
2293         * DumpRenderTree/TestOptions.cpp:
2294         (TestOptions::TestOptions):
2295         * DumpRenderTree/TestOptions.h:
2296         * DumpRenderTree/mac/DumpRenderTree.mm:
2297         (setWebPreferencesForTestOptions):
2298
2299 2019-05-01  Don Olmstead  <don.olmstead@sony.com>
2300
2301         TestWebKitAPI config.h should be aware of what suite is being built
2302         https://bugs.webkit.org/show_bug.cgi?id=196583
2303
2304         Reviewed by Konstantin Tokarev.
2305
2306         Migrate to WEBKIT_EXECUTABLE to define the Test* executables. As an added
2307         benefit the macro defines BUILDING_* for the executable which allows the includes
2308         of the config.h to be tailored to the test suite being built. Because of that the
2309         dependencies of the Test* executable are specific to the test suite which may
2310         speed up the build.
2311
2312         Some source files were including "PlatformUtilities.h" which includes WebKit headers
2313         when "Utilities.h" is what was needed.
2314
2315         * TestWebKitAPI/CMakeLists.txt:
2316         * TestWebKitAPI/PlatformGTK.cmake:
2317         * TestWebKitAPI/PlatformJSCOnly.cmake:
2318         * TestWebKitAPI/PlatformMac.cmake:
2319         * TestWebKitAPI/PlatformPlayStation.cmake:
2320         * TestWebKitAPI/PlatformUtilities.h:
2321         * TestWebKitAPI/PlatformWPE.cmake:
2322         * TestWebKitAPI/PlatformWin.cmake:
2323         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
2324         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2325         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2326         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm:
2327         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
2328         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
2329         * TestWebKitAPI/config.h:
2330
2331 2019-05-01  Jiewen Tan  <jiewen_tan@apple.com>
2332
2333         Move Document::domainIsRegisterable to SecurityOrigin::isMatchingRegistrableDomainSuffix
2334         https://bugs.webkit.org/show_bug.cgi?id=181950
2335         <rdar://problem/43357371>
2336
2337         Reviewed by Brent Fulgham.
2338
2339         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2340         (TestWebKitAPI::TEST_F):
2341
2342 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
2343
2344         Remove webkitpy and bindings EWS queues from dashboard
2345         https://bugs.webkit.org/show_bug.cgi?id=197475
2346
2347         Reviewed by Alexey Proskuryakov.
2348
2349         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2350
2351 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
2352
2353         Remove webkitpy and bindings test queues from old EWS
2354         https://bugs.webkit.org/show_bug.cgi?id=197468
2355
2356         Reviewed by Alexey Proskuryakov.
2357
2358         * QueueStatusServer/config/queues.py:
2359
2360 2019-04-30  Tim Horton  <timothy_horton@apple.com>
2361
2362         Fix the WebKitTestRunner build
2363         https://bugs.webkit.org/show_bug.cgi?id=197449
2364         <rdar://problem/50334169>
2365
2366         Reviewed by Alexey Proskuryakov.
2367
2368         * WebKitTestRunner/mac/EventSenderProxy.mm:
2369         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
2370         (WTR::EventSenderProxy::mouseForceChanged):
2371         Use some SPI instead of IPI.
2372
2373 2019-04-30  Chris Dumez  <cdumez@apple.com>
2374
2375         Regression(PSON) URL scheme handlers can no longer respond asynchronously
2376         https://bugs.webkit.org/show_bug.cgi?id=197426
2377         <rdar://problem/50256169>
2378
2379         Reviewed by Brady Eidson.
2380
2381         Add API test coverage.
2382
2383         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2384         (-[PSONScheme setShouldRespondAsynchronously:]):
2385         (-[PSONScheme webView:startURLSchemeTask:]):
2386         (-[PSONScheme webView:stopURLSchemeTask:]):
2387
2388 2019-04-30  Chris Dumez  <cdumez@apple.com>
2389
2390         Unreviewed, rolling out r244802.
2391
2392         Caused an API test failure
2393
2394         Reverted changeset:
2395
2396         "Regression(PSON) URL scheme handlers can no longer respond
2397         asynchronously"
2398         https://bugs.webkit.org/show_bug.cgi?id=197426
2399         https://trac.webkit.org/changeset/244802
2400
2401 2019-04-30  Chris Dumez  <cdumez@apple.com>
2402
2403         Regression(PSON) URL scheme handlers can no longer respond asynchronously
2404         https://bugs.webkit.org/show_bug.cgi?id=197426
2405         <rdar://problem/50256169>
2406
2407         Reviewed by Brady Eidson.
2408
2409         Add API test coverage.
2410
2411         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2412         (-[PSONScheme setShouldRespondAsynchronously:]):
2413         (-[PSONScheme webView:startURLSchemeTask:]):
2414         (-[PSONScheme webView:stopURLSchemeTask:]):
2415
2416 2019-04-30  Chris Dumez  <cdumez@apple.com>
2417
2418         Only use a related page's process if that page has not been closed yet
2419         https://bugs.webkit.org/show_bug.cgi?id=197393
2420         <rdar://problem/50302423>
2421
2422         Reviewed by Tim Horton.
2423
2424         Add API test coverage.
2425
2426         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2427
2428 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
2429
2430         [ews-build] Enable Bindings tests queue on new EWS
2431         https://bugs.webkit.org/show_bug.cgi?id=197424
2432
2433         Reviewed by Lucas Forschler.
2434
2435         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2436         (StatusBubble):
2437         * BuildSlaveSupport/ews-build/config.json:
2438
2439 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
2440
2441         [ews-build] Configure ews151 for running various tests
2442         https://bugs.webkit.org/show_bug.cgi?id=197419
2443
2444         Reviewed by Lucas Forschler.
2445
2446         * BuildSlaveSupport/ews-build/config.json:
2447
2448 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
2449
2450         [ews-build] Parse and display bindings test failures
2451         https://bugs.webkit.org/show_bug.cgi?id=197423
2452
2453         Reviewed by Lucas Forschler.
2454
2455         * BuildSlaveSupport/ews-build/steps.py:
2456         (RunBindingsTests.__init__): Set timeout of 5 minutes.
2457         (RunBindingsTests.start): Initialize log_observer for json output.
2458         (RunBindingsTests.getResultSummary): Update step and build summary based on bindings test results.
2459         (RunBindingsTests._addToLog): Method to add message to log.
2460         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
2461
2462 2019-04-30  Pablo Saavedra  <psaavedra@igalia.com>
2463
2464         Unreviewed. Add myself as a committer.
2465
2466         * Scripts/webkitpy/common/config/contributors.json:
2467
2468 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
2469
2470         [ews-build] Enable webkitpy queue on new EWS
2471         https://bugs.webkit.org/show_bug.cgi?id=197396
2472
2473         Reviewed by Lucas Forschler.
2474
2475         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2476         (StatusBubble):
2477         * BuildSlaveSupport/ews-build/config.json:
2478
2479 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
2480
2481         [ews-build] Parse and display webkitpy failures
2482         https://bugs.webkit.org/show_bug.cgi?id=197395
2483
2484         Reviewed by Lucas Forschler.
2485
2486         * BuildSlaveSupport/ews-build/steps.py:
2487         (RunWebKitPyTests.start): Initialize log_observer for json output.
2488         (RunWebKitPyTests.getResultSummary): Update step and build summary based on webkitpy results.
2489         (RunWebKitPyTests._addToLog): Method to add message to log.
2490         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
2491
2492 2019-04-29  Alex Christensen  <achristensen@webkit.org>
2493
2494         <rdar://problem/50299396> Fix internal High Sierra build
2495         https://bugs.webkit.org/show_bug.cgi?id=197388
2496
2497         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2498         * MiniBrowser/Configurations/Base.xcconfig:
2499         * MobileMiniBrowser/Configurations/Base.xcconfig:
2500         * TestWebKitAPI/Configurations/Base.xcconfig:
2501         * WebKitTestRunner/Configurations/Base.xcconfig:
2502
2503 2019-04-29  Youenn Fablet  <youenn@apple.com>
2504
2505         Remove spurious GVA printf logging
2506         https://bugs.webkit.org/show_bug.cgi?id=197368
2507         <rdar://problem/35975256>
2508
2509         Reviewed by Alexey Proskuryakov.
2510
2511         * Scripts/webkitpy/port/mac.py:
2512         (MacPort.logging_patterns_to_strip):
2513
2514 2019-04-29  Youenn Fablet  <youenn@apple.com>
2515
2516         getDisplayMedia should be called on user gesture
2517         https://bugs.webkit.org/show_bug.cgi?id=197356
2518         <rdar://problem/50296074>
2519
2520         Reviewed by Eric Carlson.
2521
2522         Update test configuration to inject internals
2523         so that we can use it to simulate a user click to call getDisplayMedia.
2524
2525         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
2526         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
2527         (TestWebKitAPI::GetDisplayMediaTest::SetUp):
2528
2529 2019-04-26  Stephanie Lewis  <slewis@apple.com>
2530
2531         run-benchmarks should have an intial prep and restore env call for tasks that are too expensive to do for every iteration
2532         https://bugs.webkit.org/show_bug.cgi?id=197339
2533
2534         Reviewed by Dewei Zhu.
2535
2536         Add two new functions prepare_inital_env and restore_env_after_all_testing around the entire
2537         test run for setup steps that are too expensive to do every iteration.
2538
2539         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2540         (BenchmarkRunner._run_benchmark):
2541         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2542         (BrowserDriver):
2543         (BrowserDriver.prepare_initial_env):
2544         (BrowserDriver.restore_env_after_all_testing):
2545         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
2546         (LinuxBrowserDriver.prepare_initial_env):
2547         (LinuxBrowserDriver.restore_env_after_all_testing):
2548         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2549         (OSXBrowserDriver.prepare_initial_env):
2550         (OSXBrowserDriver.restore_env_after_all_testing):
2551
2552 2019-04-28  Andy Estes  <aestes@apple.com>
2553
2554         Fix the watchOS engineering build.
2555
2556         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
2557         (TestWebKitAPI::TEST): AVVideoPerformanceMetrics does not exist on watchOS.
2558
2559 2019-04-27  Chris Dumez  <cdumez@apple.com>
2560
2561         [WKTR] Move test timeout handling to the UIProcess
2562         https://bugs.webkit.org/show_bug.cgi?id=197333
2563
2564         Reviewed by Darin Adler.
2565
2566         Move test timeout handling in WebKitTestRunner to the UIProcess to play nicely with PSON. Previously,
2567         we'd start the timeout timer in the InjectedBundle, which would fail to account of the time spent in
2568         every WebContent process in the case of swapping.
2569
2570         Also, because of process caching, the timeout timer would sometime fire in a cached process and it
2571         would lead to crashes when firing the timer.
2572
2573         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2574         (WTR::InjectedBundle::didReceiveMessageToPage):
2575         (WTR::InjectedBundle::done):
2576         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2577         (WTR::InjectedBundle::shouldDumpPixels const):
2578         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2579         (WTR::TestRunner::TestRunner):
2580         (WTR::TestRunner::waitUntilDone):
2581         (WTR::TestRunner::setWaitUntilDone):
2582         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2583         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2584         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2585         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
2586         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp:
2587         * WebKitTestRunner/TestInvocation.cpp:
2588         (WTR::TestInvocation::TestInvocation):
2589         (WTR::TestInvocation::createTestSettingsDictionary):
2590         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2591         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2592         (WTR::TestInvocation::initializeWaitToDumpWatchdogTimerIfNeeded):
2593         (WTR::TestInvocation::invalidateWaitToDumpWatchdogTimer):
2594         (WTR::TestInvocation::waitToDumpWatchdogTimerFired):
2595         (WTR::TestInvocation::setWaitUntilDone):
2596         (WTR::TestInvocation::done):
2597         * WebKitTestRunner/TestInvocation.h:
2598
2599 2019-04-25  Yusuke Suzuki  <ysuzuki@apple.com>
2600
2601         [JSC] linkPolymorphicCall now does GC
2602         https://bugs.webkit.org/show_bug.cgi?id=197306
2603
2604         Reviewed by Saam Barati.
2605
2606         The test is sensitive to allocations and even adding $vm makes it non-reproducible.
2607         To add this test, we add `runWithoutBaseOption`.
2608
2609         * Scripts/run-jsc-stress-tests:
2610
2611 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
2612
2613         Update inactive reviewers' status to 'contributor'.
2614
2615         Accidentally skipped one at first.
2616
2617         * Scripts/webkitpy/common/config/contributors.json:
2618
2619 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
2620
2621         Update inactive reviewers' status to 'contributor'.
2622
2623         * Scripts/webkitpy/common/config/contributors.json: The change.
2624
2625         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2626         * Scripts/webkitpy/common/checkout/checkout_mock.py:
2627         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2628         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
2629         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2630         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
2631         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2632         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2633         Sadly, regression tests operate on a crazy mix of mock and live data for
2634         contributors.json. It would be a substantial project to mock all code paths,
2635         so changing the tests instead.
2636
2637 2019-04-26  Eric Carlson  <eric.carlson@apple.com>
2638
2639         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
2640         https://bugs.webkit.org/show_bug.cgi?id=197171
2641         <rdar://problem/47454979>
2642
2643         Reviewed by Youenn Fablet.
2644
2645         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2646         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
2647         (TestWebKitAPI::TEST):
2648
2649 2019-04-26  David Kilzer  <ddkilzer@apple.com>
2650
2651         WebKitTestRunner leaks an NSDictionary and multiple JSStringRef objects
2652         <https://webkit.org/b/197314>
2653         <rdar://problem/50245252>
2654
2655         Reviewed by Simon Fraser.
2656
2657         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2658         (WTR::UIScriptController::lastUndoLabel const):
2659         (WTR::UIScriptController::firstRedoLabel const):
2660         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
2661
2662         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2663         (-[HIDEventGenerator sendEventStream:completionBlock:]):
2664         - Call -autorelease to fix leak of NSDictionary.
2665
2666         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2667         (WTR::UIScriptController::accessibilitySpeakSelectionContent const):
2668         (WTR::UIScriptController::selectFormPopoverTitle const):
2669         (WTR::UIScriptController::textContentType const):
2670         (WTR::UIScriptController::formInputLabel const):
2671         (WTR::UIScriptController::scrollingTreeAsText const):
2672         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
2673
2674 2019-04-26  Jonathan Bedard  <jbedard@apple.com>
2675
2676         webkitpy: Running a single test will always use the default device
2677         https://bugs.webkit.org/show_bug.cgi?id=195472
2678         <rdar://problem/48724825>
2679
2680         Reviewed by Lucas Forschler.
2681
2682         It makes more sense to have the Manager class handle the case where a user specifically requests a test which is
2683         skipped on the current configuration. This changes the behavior when running part of a test shard, now tests explicitly
2684         requested will be run regardless of what shard they are in.
2685
2686         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
2687         (LayoutTestFinder.skip_tests): Caller should manage running skipped tests which were explicitly requested.
2688         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2689         (Manager.run): If a test is marked as skipped for the configuration, but was specifically requested, run it anyways
2690         on the default device type.
2691         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2692         (RunTest.test_run_chunk): Explicitly requesting a test will override sharing behavior.
2693         (RunTest.test_run_part): Ditto.
2694
2695 2019-04-26  Alex Christensen  <achristensen@webkit.org>
2696
2697         Add ENABLE(CONTENT_EXTENSIONS) and namespace ContentExtensions to ResourceLoadInfo.h
2698         https://bugs.webkit.org/show_bug.cgi?id=197165
2699
2700         Reviewed by Youenn Fablet.
2701
2702         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2703
2704 2019-04-26  Ryan Haddad  <ryanhaddad@apple.com>
2705
2706         Replace iOS build queue hardware
2707         https://bugs.webkit.org/show_bug.cgi?id=197312
2708
2709         Reviewed by Aakash Jain.
2710
2711         * BuildSlaveSupport/build.webkit.org-config/config.json:
2712         Use newer hardware that supports macOS Mojave.
2713
2714 2019-04-26  Yoshiaki Jitsukawa  <yoshiaki.jitsukawa@sony.com>
2715
2716         check-webkit-style complains the first block in while loop.
2717         https://bugs.webkit.org/show_bug.cgi?id=197307
2718
2719         The style checker shouldn't complain about an open brace on
2720         its own line if the last non-whitespace character on the previous
2721         non-blank line is another open brace, because it's likely to
2722         indicate the begining of a nested code block.
2723
2724         Reviewed by Alex Christensen.
2725
2726         * Scripts/webkitpy/style/checkers/cpp.py:
2727         (check_braces):
2728         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2729         (WebKitStyleTest.test_braces):
2730
2731 2019-04-26  Sihui Liu  <sihui_liu@apple.com>
2732
2733         Stop IDB transactions to release locked database files when network process is ready to suspend
2734         https://bugs.webkit.org/show_bug.cgi?id=196372
2735         <rdar://problem/48930116>
2736
2737         Reviewed by Brady Eidson.
2738
2739         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2740         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.html: Added.
2741         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm: Added.
2742         (-[IndexedDBSuspendImminentlyMessageHandler userContentController:didReceiveScriptMessage:]):
2743         (runTestAndCheckResult):
2744         (keepNetworkProcessActive):
2745         (TEST):
2746
2747 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
2748
2749         REGRESSION (r234330): 3 legacy-animation-engine/compositing tests are flaky failures
2750         https://bugs.webkit.org/show_bug.cgi?id=188357
2751         <rdar://problem/42986633>
2752
2753         Reviewed by Dean Jackson.
2754
2755         DumpRenderTree had no code that set page.setCompositingPolicyOverride() to Normal, so some
2756         tests would fall into low memory mode and have different behavior.
2757         
2758         Fix by moving the code that calls setCompositingPolicyOverride(Normal) from the WK2 layer
2759         to Internals, so it's shared by DRT and WTR.
2760         
2761         We no longer need the WK2 C SPI glue.
2762
2763         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2764         (WTR::InjectedBundlePage::prepare):
2765
2766 2019-04-25  Jonathan Bedard  <jbedard@apple.com>
2767
2768         webkitpy: Including skipped tests in the final count
2769         https://bugs.webkit.org/show_bug.cgi?id=197298
2770         <rdar://problem/49705424>
2771
2772         Reviewed by Lucas Forschler.
2773
2774         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
2775         (BuildBotPrinter.print_run_results): The total number of tests run should exclude delibrately skipped tests.
2776
2777 2019-04-25  Timothy Hatcher  <timothy@apple.com>
2778
2779         Disable date and time inputs on iOSMac.
2780         https://bugs.webkit.org/show_bug.cgi?id=197287
2781         rdar://problem/46794376
2782
2783         Reviewed by Wenson Hsieh.
2784
2785         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2786
2787 2019-04-25  Alex Christensen  <achristensen@webkit.org>
2788
2789         Fix test-webkitpy after r244653
2790         https://bugs.webkit.org/show_bug.cgi?id=197131
2791
2792         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
2793         Also use C++17.
2794
2795 2019-04-25  Per Arne Vollan  <pvollan@apple.com>
2796
2797         -[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:] never returns _WKWebsiteDataTypeCredentials
2798         https://bugs.webkit.org/show_bug.cgi?id=196991
2799         <rdar://problem/45507423>
2800
2801         Reviewed by Alex Christensen.
2802
2803         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
2804         (-[NavigationTestDelegate init]):
2805         (-[NavigationTestDelegate waitForDidFinishNavigation]):
2806         (-[NavigationTestDelegate webView:didFinishNavigation:]):
2807         (-[NavigationTestDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2808         (TestWebKitAPI::TEST):
2809         (TEST): Deleted.
2810
2811 2019-04-25  Alex Christensen  <achristensen@webkit.org>
2812
2813         Revert some code accidentally committed with r244653
2814         https://bugs.webkit.org/show_bug.cgi?id=197131
2815
2816         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
2817         (TestWebKitAPI::TEST):
2818
2819 2019-04-25  Alex Christensen  <achristensen@webkit.org>
2820
2821         Start using C++17
2822         https://bugs.webkit.org/show_bug.cgi?id=197131
2823
2824         Reviewed by Darin Adler.
2825
2826         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2827         * MiniBrowser/Configurations/Base.xcconfig:
2828         * MobileMiniBrowser/Configurations/Base.xcconfig:
2829         * TestWebKitAPI/Configurations/Base.xcconfig:
2830         * WebKitTestRunner/Configurations/Base.xcconfig:
2831
2832 2019-04-25  Commit Queue  <commit-queue@webkit.org>
2833
2834         Unreviewed, rolling out r244627.
2835         https://bugs.webkit.org/show_bug.cgi?id=197282
2836
2837         Causing internal build failures (Requested by ShawnRoberts on
2838         #webkit).
2839
2840         Reverted changeset:
2841
2842         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
2843         https://bugs.webkit.org/show_bug.cgi?id=197171
2844         https://trac.webkit.org/changeset/244627
2845
2846 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2847
2848         [GTK] Hardcoded text color in input fields
2849         https://bugs.webkit.org/show_bug.cgi?id=126907
2850
2851         Reviewed by Michael Catanzaro.
2852
2853         Add dark-mode command line option to MiniBrowser.
2854
2855         * MiniBrowser/gtk/main.c:
2856         (main):
2857
2858 2019-04-24  Zalan Bujtas  <zalan@apple.com>
2859
2860         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
2861         https://bugs.webkit.org/show_bug.cgi?id=196948
2862         <rdar://problem/49927131>
2863
2864         Reviewed by Tim Horton.
2865
2866         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
2867         (TEST):
2868         The expected order of incoming events is
2869         1. didInvalidateIntrinsicContentSize
2870         2. didFirstLayout
2871         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
2872         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
2873         (and remember, all we care about is ordering).
2874
2875 2019-04-24  Eric Carlson  <eric.carlson@apple.com>
2876
2877         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
2878         https://bugs.webkit.org/show_bug.cgi?id=197171
2879         <rdar://problem/47454979>
2880
2881         Reviewed by Youenn Fablet.
2882
2883         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2884         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
2885         (TestWebKitAPI::TEST):
2886
2887 2019-04-24  Brady Eidson  <beidson@apple.com>
2888
2889         XMLHTTPRequest POSTs to a custom WKURLSchemeHandler protocol are missing the HTTP body.
2890         https://bugs.webkit.org/show_bug.cgi?id=191362
2891
2892         Reviewed by Alex Christensen.
2893
2894         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm: Add a test that POSTs all sorts of things
2895           from an XHR to a custom protocol.
2896
2897 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
2898
2899         DumpRenderTree doesn't call Internals::resetToConsistentState() before the first test
2900         https://bugs.webkit.org/show_bug.cgi?id=197273
2901
2902         Reviewed by Dean Jackson.
2903
2904         Reorder code so that we create gTestRunner before calling resetWebViewToConsistentStateBeforeTesting(),
2905         so that WebCoreTestSupport::resetInternalsObject() is always run.
2906
2907         * DumpRenderTree/mac/DumpRenderTree.mm:
2908         (resetWebViewToConsistentStateBeforeTesting):
2909         (runTest):
2910
2911 2019-04-24  John Wilander  <wilander@apple.com>
2912
2913         Age out unconverted Ad Click Attributions after one week.
2914         https://bugs.webkit.org/show_bug.cgi?id=197238
2915         <rdar://problem/50177349>
2916
2917         Reviewed by Chris Dumez.
2918
2919         This patch adds infrastructure to allow tests to expire all unconverted
2920         attributions early.
2921
2922         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2923         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2924         (WTR::TestRunner::markAdClickAttributionsAsExpiredForTesting):
2925         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2926         * WebKitTestRunner/TestController.cpp:
2927         (WTR::TestController::markAdClickAttributionsAsExpiredForTesting):
2928         * WebKitTestRunner/TestController.h:
2929         * WebKitTestRunner/TestInvocation.cpp:
2930         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2931
2932 2019-04-24  Chris Dumez  <cdumez@apple.com>
2933
2934         Fix flaky crashes in a couple of PSON API tests
2935         https://bugs.webkit.org/show_bug.cgi?id=197239
2936
2937         Reviewed by Tim Horton.
2938
2939         Do not adopt the NSURLRequest returned by [NSURLRequest requestWithURL:].
2940
2941         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2942
2943 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
2944
2945         Make it possible to control the renderTreeAsText output by setting options on testRunner
2946         https://bugs.webkit.org/show_bug.cgi?id=197133
2947
2948         Reviewed by Sam Weinig.
2949
2950         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
2951         that make sense in testing (those that don't dump unstable data like addresses), and plumb
2952         these flags through the various framework layers.
2953
2954         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
2955
2956         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
2957         and hand-code DumpRenderTree bindings.
2958
2959         Some cleanup of the TestRunners, using member initializers.
2960
2961         * DumpRenderTree/TestRunner.cpp:
2962         (TestRunner::TestRunner):
2963         (setRenderTreeDumpOptionsCallback):
2964         (TestRunner::staticFunctions):
2965         (TestRunner::setRenderTreeDumpOptions):
2966         * DumpRenderTree/TestRunner.h:
2967         (TestRunner::renderTreeDumpOptions const):
2968         * DumpRenderTree/mac/DumpRenderTree.mm:
2969         (dump):
2970         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2971         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2972         (WTR::InjectedBundlePage::dump):
2973         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2974         (WTR::TestRunner::TestRunner):
2975         (WTR::TestRunner::setRenderTreeDumpOptions):
2976         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2977         (WTR::TestRunner::renderTreeDumpOptions const):
2978
2979 2019-04-24  Alex Christensen  <achristensen@webkit.org>
2980
2981         WKContentRuleLists should have a maximum FileProtection of CompleteUnlessOpen
2982         https://bugs.webkit.org/show_bug.cgi?id=197078
2983         <rdar://problem/49564348>
2984
2985         Reviewed by Geoff Garen.
2986
2987         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2988         (TEST_F):
2989         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]): Deleted.
2990         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]): Deleted.
2991         Unfortunately, setting the NSFileProtectionKey attribute is only supported on iOS devices.
2992
2993 2019-04-24  Alex Christensen  <achristensen@webkit.org>
2994
2995         Add unit test for r239322
2996         https://bugs.webkit.org/show_bug.cgi?id=197236
2997
2998         Reviewed by Chris Dumez.
2999
3000         I initially developed this as a unit test for rdar://problem/48797895 but it seems that isn't quite ready.
3001         May as well add the test infrastructure which was needed before and will be needed in the future.
3002
3003         * TestWebKitAPI/TCPServer.cpp:
3004         (TestWebKitAPI::TCPServer::TCPServer):
3005         * TestWebKitAPI/TCPServer.h:
3006         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3007         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
3008         (TestWebKitAPI::TEST):
3009         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3010         (TestWebKitAPI::downloadAtRate):
3011         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
3012         (TEST):
3013         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm: Added.
3014         (-[ProxyDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3015         (-[ProxyDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
3016         (TestWebKitAPI::TEST):
3017         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
3018         (TEST):
3019
3020 2019-04-24  Chris Dumez  <cdumez@apple.com>
3021
3022         URL set by document.open() is communicated with the WebPageProxy but not the WebFrameProxy
3023         https://bugs.webkit.org/show_bug.cgi?id=197214
3024         <rdar://problem/49237544>
3025
3026         Reviewed by Alex Christensen.
3027
3028         Extend API test coverage.
3029
3030         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
3031         (TEST):
3032
3033 2019-04-24  Philippe Normand  <pnormand@igalia.com>
3034
3035         [Build][GStreamer] Update to 1.16.0
3036         https://bugs.webkit.org/show_bug.cgi?id=197157
3037
3038         Reviewed by Xabier Rodriguez-Calvar.
3039
3040         The upstreamed patches were removed and a new one was added for a
3041         regression detected in the scaletempo GStreamer element. The GNOME
3042         Flatpak was migrated to 3.32 and I switched a few modules to Meson
3043         on the way, as it is the preferred build system now in GStreamer
3044         1.16.
3045
3046         * flatpak/files/httpd-autogen.sh:
3047         * flatpak/flatpakutils.py:
3048         (FlatpakPackage.install):
3049         (WebkitFlatpak.run_in_sandbox):
3050         * flatpak/org.webkit.CommonModules.yaml:
3051         * flatpak/org.webkit.WebKit.yaml:
3052         * gstreamer/jhbuild.modules:
3053         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Removed.
3054         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Removed.
3055         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Removed.
3056         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Removed.
3057         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Removed.
3058         * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch: Removed.
3059         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Removed.
3060         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Removed.
3061         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Removed.
3062         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
3063         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Removed.
3064         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
3065         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Removed.
3066         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Removed.
3067         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Removed.
3068         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Removed.
3069         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Removed.
3070         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Removed.
3071         * gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Removed.
3072         * gstreamer/patches/gst-plugins-good-scaletempo-Advertise-interleaved-layout-in-caps-temp.patch: Added.
3073         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Removed.
3074         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Removed.
3075
3076 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3077
3078         [GTK] MiniBrowser: also set the passed bg-color when receiving arguments
3079         https://bugs.webkit.org/show_bug.cgi?id=197156
3080
3081         Reviewed by Michael Catanzaro.
3082
3083         The background color is only set when MiniBrowser is launched without arguments. This regressed when tabs
3084         support was added.
3085
3086         * MiniBrowser/gtk/BrowserTab.c:
3087         (browser_tab_set_background_color): Set the passed in color as web view background color.
3088         * MiniBrowser/gtk/BrowserTab.h:
3089         * MiniBrowser/gtk/BrowserWindow.c:
3090         (browser_window_init): Initialize backgroundColor.
3091         (browser_window_append_view): Call browser_tab_set_background_color().
3092         (browser_window_set_background_color): Save the passed in color. This function should now be called before tabs
3093         are added.
3094         * MiniBrowser/gtk/main.c:
3095         (main): Call browser_window_set_background_color() before creating the tabs.
3096
3097 2019-04-23  John Wilander  <wilander@apple.com>
3098
3099         Move Ad Click Attribution from internal feature to experimental feature
3100         https://bugs.webkit.org/show_bug.cgi?id=197218
3101         <rdar://problem/47651691>
3102
3103         Reviewed by Brent Fulgham.
3104
3105         * DumpRenderTree/TestOptions.cpp:
3106         (TestOptions::TestOptions):
3107
3108 2019-04-23  Andy Estes  <aestes@apple.com>
3109
3110         [iOS] QuickLook documents loaded from file: URLs should be allowed to perform same-document navigations
3111         https://bugs.webkit.org/show_bug.cgi?id=196749
3112         <rdar://problem/35773454>
3113
3114         Reviewed by Daniel Bates.
3115
3116         Added a new QuickLook API test and added new expectations to existing QuickLook tests.
3117
3118         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
3119         (-[QuickLookDelegate webView:didStartProvisionalNavigation:]):
3120         (-[QuickLookDelegate webView:didFinishNavigation:]):
3121         (-[QuickLookDelegate _webView:didFailNavigation:withError:userInfo:]):
3122         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
3123         (runTest):
3124         (runTestDecideBeforeLoading):
3125         (runTestDecideAfterLoading):
3126         (TEST):
3127
3128 2019-04-23  John Wilander  <wilander@apple.com>
3129
3130         Remove Ad Click Attribution data when removing website data
3131         https://bugs.webkit.org/show_bug.cgi?id=197215
3132         <rdar://problem/47668988>
3133
3134         Reviewed by Chris Dumez.
3135
3136         This patch adds test infrastructure to delete Ad Click Attribution data
3137         through WebsiteDataStore::removeData().
3138
3139         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3140         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3141         (WTR::TestRunner::clearAdClickAttribution):
3142         (WTR::TestRunner::clearAdClickAttributionsThroughWebsiteDataRemoval):
3143         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3144         * WebKitTestRunner/TestController.cpp:
3145         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
3146         * WebKitTestRunner/TestController.h:
3147         * WebKitTestRunner/TestInvocation.cpp:
3148         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3149
3150 2019-04-23  Jonathan Bedard  <jbedard@apple.com>
3151
3152         webkitpy: Kill unresponsive worker processes
3153         https://bugs.webkit.org/show_bug.cgi?id=197205
3154         <rdar://problem/50104388>
3155
3156         Reviewed by Lucas Forschler.
3157
3158         * Scripts/webkitpy/common/message_pool.py:
3159         (_MessagePool.__init__): Add close timeout.
3160         (_MessagePool._close): Send termination before joining workers, kill unresponsive workers.
3161
3162 2019-04-23  Alex Christensen  <achristensen@webkit.org>
3163
3164         Add unit tests for WKWebView.serverTrust
3165         https://bugs.webkit.org/show_bug.cgi?id=197202
3166
3167         Reviewed by Youenn Fablet
3168
3169         * TestWebKitAPI/TCPServer.cpp:
3170         (TestWebKitAPI::deleter<BIO>::operator()):
3171         (TestWebKitAPI::deleter<SSL>::operator()):
3172         (TestWebKitAPI::deleter<X509>::operator()):
3173         (TestWebKitAPI::deleter<SSL_CTX>::operator()):
3174         (TestWebKitAPI::deleter<EVP_PKEY>::operator()):
3175         (TestWebKitAPI::TCPServer::TCPServer):
3176         (TestWebKitAPI::TCPServer::listenForConnections):
3177         * TestWebKitAPI/TCPServer.h:
3178         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3179         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
3180         (TestWebKitAPI::TEST):
3181         (verifyCertificateAndPublicKey):
3182         (-[ServerTrustDelegate webView:didFinishNavigation:]):
3183         (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
3184         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3185         (TestWebKitAPI::downloadAtRate):
3186         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
3187         (TEST):
3188         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
3189         (TEST):
3190
3191 2019-04-23  Commit Queue  <commit-queue@webkit.org>
3192
3193         Unreviewed, rolling out r244556.
3194         https://bugs.webkit.org/show_bug.cgi?id=197212
3195
3196         Causing build failures on multiple builders (Requested by
3197         ShawnRoberts on #webkit).
3198
3199         Reverted changeset:
3200
3201         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
3202         https://bugs.webkit.org/show_bug.cgi?id=197171
3203         https://trac.webkit.org/changeset/244556
3204
3205 2019-04-23  Alex Christensen  <achristensen@webkit.org>
3206
3207         Fix iOS build.
3208         https://bugs.webkit.org/show_bug.cgi?id=195537
3209
3210         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3211         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
3212         AdoptWK constructor is private now.  Use adoptWK instead.
3213
3214 2019-04-23  Andres Gonzalez  <andresg_22@apple.com>
3215
3216         Accessibility text search and selection API enhancements.
3217         https://bugs.webkit.org/show_bug.cgi?id=197095
3218         <rdar://problem/48181791>
3219
3220         Reviewed by Chris Fleizach.
3221
3222         Added new API JS binding code for searchTextWithCriteria to both WTR and DRT.
3223
3224         * DumpRenderTree/AccessibilityTextMarker.h:
3225         * DumpRenderTree/AccessibilityUIElement.cpp:
3226         (searchTextWithCriteriaCallback):
3227         (AccessibilityUIElement::getJSClass):
3228         * DumpRenderTree/AccessibilityUIElement.h:
3229         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3230         (convertVectorToObjectArray):
3231         (convertNSArrayToVector):
3232         (searchTextParameterizedAttributeForCriteria):
3233         (AccessibilityUIElement::getLinkedUIElements):
3234         (AccessibilityUIElement::getDocumentLinks):
3235         (AccessibilityUIElement::getChildren):
3236         (AccessibilityUIElement::getChildrenWithRange):
3237         (AccessibilityUIElement::rowHeaders const):
3238         (AccessibilityUIElement::columnHeaders const):
3239         (AccessibilityUIElement::uiElementArrayAttributeValue const):
3240         (AccessibilityUIElement::searchTextWithCriteria):
3241         (AccessibilityUIElement::attributesOfColumnHeaders):
3242         (AccessibilityUIElement::attributesOfRowHeaders):
3243         (AccessibilityUIElement::attributesOfColumns):
3244         (AccessibilityUIElement::attributesOfRows):
3245         (AccessibilityUIElement::attributesOfVisibleCells):
3246         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3247         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3248         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3249         (WTR::convertVectorToObjectArray):
3250         (WTR::convertNSArrayToVector):
3251         (WTR::searchTextParameterizedAttributeForCriteria):
3252         (WTR::AccessibilityUIElement::getLinkedUIElements):
3253         (WTR::AccessibilityUIElement::getDocumentLinks):
3254         (WTR::AccessibilityUIElement::getUIElementsWithAttribute const):
3255         (WTR::AccessibilityUIElement::getChildren):
3256         (WTR::AccessibilityUIElement::getChildrenWithRange):
3257         (WTR::AccessibilityUIElement::rowHeaders const):
3258         (WTR::AccessibilityUIElement::columnHeaders const):
3259         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
3260         (WTR::AccessibilityUIElement::searchTextWithCriteria):
3261         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
3262         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
3263         (WTR::AccessibilityUIElement::attributesOfColumns):
3264         (WTR::AccessibilityUIElement::attributesOfRows):
3265         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
3266         (WTR::convertElementsToObjectArray): Deleted.
3267
3268 2019-04-23  Guy Lewin  <guy@lewin.co.il>
3269
3270         Multiple File Input Icon Set Regardless of File List
3271         https://bugs.webkit.org/show_bug.cgi?id=195537
3272
3273         Reviewed by Alexey Proskuryakov.
3274
3275         Add setOpenPanelFilesMediaIcon to TestRunner in order to test icon and
3276         display string in iOS file inputs
3277
3278         * DumpRenderTree/TestRunner.cpp:
3279         (SetOpenPanelFilesMediaIconCallback):
3280         (TestRunner::staticFunctions):
3281         (TestRunner::setOpenPanelFilesMediaIcon):
3282         * DumpRenderTree/TestRunner.h:
3283         (TestRunner::openPanelFilesMediaIcon const):
3284         * DumpRenderTree/mac/UIDelegate.mm:
3285         (-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
3286         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3287         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3288         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
3289         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3290         * WebKitTestRunner/TestController.cpp:
3291         (WTR::runOpenPanel):
3292         (WTR::TestController::resetStateToConsistentValues):
3293         * WebKitTestRunner/TestController.h:
3294         (WTR::TestController::openPanelFileURLsMediaIcon const):
3295         (WTR::TestController::setOpenPanelFileURLsMediaIcon):
3296         * WebKitTestRunner/TestInvocation.cpp:
3297         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3298
3299 2019-04-23  Eric Carlson  <eric.carlson@apple.com>
3300
3301         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
3302         https://bugs.webkit.org/show_bug.cgi?id=197171
3303         <rdar://problem/47454979>
3304
3305         Reviewed by Youenn Fablet.
3306
3307         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3308         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
3309         (TestWebKitAPI::TEST):
3310
3311 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
3312
3313         [ews-build] Add unit tests for UnApplyPatchIfRequired
3314         https://bugs.webkit.org/show_bug.cgi?id=197197
3315
3316         Reviewed by Lucas Forschler.
3317
3318         * BuildSlaveSupport/ews-build/steps_unittest.py:
3319         (TestUnApplyPatchIfRequired):
3320         (TestUnApplyPatchIfRequired.test_success):
3321         (TestUnApplyPatchIfRequired.test_failure):
3322         (TestUnApplyPatchIfRequired.test_skip):
3323
3324 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
3325
3326         [ews-build] Add unit tests for CleanWorkingDirectory
3327         https://bugs.webkit.org/show_bug.cgi?id=197195
3328
3329         Reviewed by Lucas Forschler.
3330
3331         * BuildSlaveSupport/ews-build/steps_unittest.py:
3332         (TestCleanWorkingDirectory):
3333         (TestCleanWorkingDirectory.test_success):
3334         (TestCleanWorkingDirectory.test_failure):
3335
3336 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
3337
3338         [ews-build] Use explicit imports instead of wildcard imports
3339         https://bugs.webkit.org/show_bug.cgi?id=197194
3340
3341         Reviewed by Lucas Forschler.
3342
3343         * BuildSlaveSupport/ews-build/factories.py:
3344         * BuildSlaveSupport/ews-build/loadConfig.py:
3345         * BuildSlaveSupport/ews-build/steps_unittest.py:
3346
3347 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
3348
3349         [ews-build] Add unit tests for DownloadBuiltProduct
3350         https://bugs.webkit.org/show_bug.cgi?id=197193
3351
3352         Reviewed by Lucas Forschler.
3353
3354         * BuildSlaveSupport/ews-build/steps_unittest.py:
3355         (TestDownloadBuiltProduct):
3356         (TestDownloadBuiltProduct.setUp):
3357         (TestDownloadBuiltProduct.tearDown):
3358         (TestDownloadBuiltProduct.test_success):
3359         (TestDownloadBuiltProduct.test_failure):
3360
3361 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
3362
3363         [ews-app] Exception while loading status-bubble when no build step has started
3364         https://bugs.webkit.org/show_bug.cgi?id=196676
3365
3366         Reviewed by Lucas Forschler.
3367
3368         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3369         (StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.
3370
3371 2019-04-23  Stephan Szabo  <stephan.szabo@sony.com>
3372
3373         [PlayStation] Support running of JSC tests on remote playstation devices
3374         https://bugs.webkit.org/show_bug.cgi?id=197170
3375
3376         Reviewed by Ross Kirsling.
3377
3378         Script changes
3379
3380         * Scripts/run-javascriptcore-tests:
3381         (runJSCStressTests): Pass arguments for playstation to
3382         run-jsc-stress-tests
3383         * Scripts/run-jsc-stress-tests:
3384         Handle $hostOS=="playstation" for determineArchitecture, turning
3385         off $isFTLPlatform and runProfiler and defaulting test writer.
3386         * Scripts/webkitdirs.pm:
3387         (jscPath): PlayStation WebKit executables have .elf extension
3388         (executableProductDir): PlayStation builds on Windows hosts but
3389         uses bin directory rather than bin64/bin32 for executable output
3390         location.
3391         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb: Added.
3392
3393 2019-04-23  Don Olmstead  <don.olmstead@sony.com>
3394
3395         [CMake][Win] Use target oriented design for WebKit
3396         https://bugs.webkit.org/show_bug.cgi?id=197173
3397
3398         Reviewed by Alex Christensen.
3399
3400         * TestWebKitAPI/PlatformWin.cmake: Add WebKitFrameworkHeaders as a dependency.
3401         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Remove unused header.
3402
3403 2019-04-23  Chris Dumez  <cdumez@apple.com>
3404
3405         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
3406         https://bugs.webkit.org/show_bug.cgi?id=197097
3407         <rdar://problem/50048318>
3408
3409         Reviewed by Alex Christensen.
3410
3411         Add API test coverage.
3412
3413         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3414         (-[PSONScheme webView:startURLSchemeTask:]):
3415
3416 2019-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3417
3418         [ATK] Implement AtkComponentIface scroll_to methods
3419         https://bugs.webkit.org/show_bug.cgi?id=196856
3420
3421         Reviewed by Michael Catanzaro.
3422
3423         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3424         (WTR::AccessibilityUIElement::scrollToMakeVisible): Call atk_component_scroll_to().
3425         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Call atk_component_scroll_to_point().
3426         * gtk/jhbuild.modules: Bump atk, at-spi2-core and at-spi2-atk to their latest stable version.
3427
3428 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
3429
3430         [ews-build] Improve summary for UploadBuiltProduct step
3431         https://bugs.webkit.org/show_bug.cgi?id=197182
3432
3433         Reviewed by Lucas Forschler.
3434
3435         * BuildSlaveSupport/ews-build/steps.py:
3436         (UploadBuiltProduct): Added descriptionDone.
3437         (UploadBuiltProduct.getResultSummary): Overrided getResultSummary.
3438         * BuildSlaveSupport/ews-build/steps_unittest.py:
3439         (TestUploadBuiltProduct.test_success): Updated unit-test.
3440         (TestUploadBuiltProduct.test_failure): Added unit-test for failure case.
3441
3442 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
3443
3444         [ews-build] Trigger queues only after uploading the archive
3445         https://bugs.webkit.org/show_bug.cgi?id=197180
3446
3447         Reviewed by Lucas Forschler.
3448
3449         * BuildSlaveSupport/ews-build/factories.py:
3450         (Factory.__init__):
3451         (BuildFactory.__init__): Remove trigger step from factories.
3452         (BuildFactory.propertiesToPassToTriggers): Deleted.
3453         * BuildSlaveSupport/ews-build/steps.py:
3454         (ConfigureBuild.__init__): Confiure triggers property.
3455         (Trigger): Step to trigger other queues.
3456         (Trigger.propertiesToPassToTriggers): Method to construct properties to pass to triggerred builds.
3457         (UploadBuiltProduct.finished): Trigger builds after upload is successful.
3458
3459 2019-04-22  Alex Christensen  <achristensen@webkit.org>
3460
3461         Deprecate WKContextCreateWithInjectedBundlePath
3462         https://bugs.webkit.org/show_bug.cgi?id=197169
3463
3464         Reviewed by Youenn Fablet.
3465
3466         * TestWebKitAPI/PlatformUtilities.cpp:
3467         (TestWebKitAPI::Util::createContextWithInjectedBundle):
3468         Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.
3469
3470 2019-04-22  Alex Christensen  <achristensen@webkit.org>
3471
3472         REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
3473         https://bugs.webkit.org/show_bug.cgi?id=197093
3474         <rdar://problem/49708268>
3475
3476         Reviewed by Chris Dumez.
3477
3478         Add a test that does two loads.  The first load shouldUseCredentialStorage returns true and we provide a persistent credential.
3479         The second load shouldUseCredentialStorage returns false and we verify that a challenge is received with no suggested credential.
3480         We also need to make the TCPServer able to handle more than one connection because we need these two loads to come from the same protection space,
3481         and our current Cocoa implementation of NetworkSession uses two NSURLSessions that don't share a connection cache, one for loads with credentials
3482         and one for loads without credentials, so there are two TCP connections to the same server in this test.
3483
3484         * TestWebKitAPI/TCPServer.cpp:
3485         (TestWebKitAPI::TCPServer::TCPServer):
3486         (TestWebKitAPI::TCPServer::~TCPServer):
3487         (TestWebKitAPI::TCPServer::socketBindListen):
3488         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests): Deleted.
3489         * TestWebKitAPI/TCPServer.h:
3490         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3491         * TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm: Added.
3492         (-[BasicProposedCredentialPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3493         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
3494         (respondWithChallengeThenOK):
3495         (TestWebKitAPI::TEST):
3496         (-[ProposedCredentialDelegate webView:didFinishNavigation:]):
3497         (-[ProposedCredentialDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
3498         (TEST):
3499
3500 2019-04-22  Chris Dumez  <cdumez@apple.com>
3501
3502         Delayed WebProcessLaunch may break the _relatedWebView SPI
3503         https://bugs.webkit.org/show_bug.cgi?id=197160
3504
3505         Reviewed by Alex Christensen.
3506
3507         Add API test coverage.
3508
3509         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3510
3511 2019-04-22  Dean Johnson  <dean_johnson@apple.com>
3512
3513         Use curl to download packages for webkitpy autoinstaller
3514         https://bugs.webkit.org/show_bug.cgi?id=197164
3515
3516         Reviewed by Darin Adler.
3517
3518         * Scripts/webkitpy/common/system/autoinstall.py:
3519         (AutoInstaller._download): Use curl(1) to download packages necessary for
3520         webkitpy/thirdparty/autoinstalled since Python2's urllib2 module can result in unnecessary
3521         errors which are not present when using curl(1).
3522
3523 2019-04-22  Chris Dumez  <cdumez@apple.com>
3524
3525         Unreviewed, rolling out r244502.
3526
3527         Caused crashes on the bots
3528
3529         Reverted changeset:
3530
3531         "Delayed WebProcessLaunch may break the _relatedWebView SPI"
3532         https://bugs.webkit.org/show_bug.cgi?id=197160
3533         https://trac.webkit.org/changeset/244502
3534
3535 2019-04-22  Ryan Haddad  <ryanhaddad@apple.com>
3536
3537         Unreviewed, rolling out r244437.
3538
3539         Still breaks internal tests.
3540
3541         Reverted changeset:
3542
3543         "InjectedBundle parameters often need initialization function
3544         called before unarchiving"
3545         https://bugs.webkit.org/show_bug.cgi?id=189709
3546         https://trac.webkit.org/changeset/244437
3547
3548 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
3549
3550         [ews-build] Use singular verb in failure description in case of single api test failure
3551         https://bugs.webkit.org/show_bug.cgi?id=197013
3552
3553         Reviewed by Lucas Forschler.
3554
3555         * BuildSlaveSupport/ews-build/steps.py:
3556         (AnalyzeAPITestsResults.analyzeResults):
3557
3558 2019-04-22  Chris Dumez  <cdumez@apple.com>
3559
3560         Delayed WebProcessLaunch may break the _relatedWebView SPI
3561         https://bugs.webkit.org/show_bug.cgi?id=197160
3562
3563         Reviewed by Alex Christensen.
3564
3565         Add API test coverage.
3566
3567         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3568
3569 2019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3570
3571         REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
3572         https://bugs.webkit.org/show_bug.cgi?id=194630
3573
3574         Reviewed by Michael Catanzaro.
3575
3576         Return early from getAttributeSet() is passed in accessible is nullptr.
3577
3578         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3579
3580 2019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
3581
3582         Defer EditorState updates until the next layer tree flush in a few additional circumstances
3583         https://bugs.webkit.org/show_bug.cgi?id=197145
3584         <rdar://problem/50078170>
3585
3586         Reviewed by Darin Adler.
3587
3588         Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
3589         focus, or showing the font manager.
3590
3591         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
3592         (TestWebKitAPI::TEST):
3593         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
3594         (TEST):
3595         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
3596         (TestWebKitAPI::TEST):
3597
3598 2019-04-21  Brian Burg  <bburg@apple.com>
3599
3600         WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
3601         https://bugs.webkit.org/show_bug.cgi?id=197125
3602         <rdar://problem/50061468>
3603
3604         Reviewed by Darin Adler.
3605
3606         Sometimes I want to run wptserve independently of tests. Make it easier to script that
3607         using this class rather than making our own ./wpt serve invocation.
3608
3609         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
3610         (WebDriverW3CWebServer):
3611         (WebDriverW3CWebServer.document_root): Expose this to clients.
3612         (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
3613
3614         (WebDriverW3CWebServer.__enter__):
3615         (WebDriverW3CWebServer.__exit__):
3616         Make it possible to use the web server with a 'with' statement.
3617
3618 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
3619
3620         [CMake][Win] Use target oriented design for WebKitLegacy
3621         https://bugs.webkit.org/show_bug.cgi?id=197112
3622
3623         Reviewed by Konstantin Tokarev.
3624
3625         Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
3626
3627         * DumpRenderTree/CMakeLists.txt:
3628         * DumpRenderTree/PlatformWin.cmake:
3629         * DumpRenderTree/win/EventSender.cpp:
3630
3631 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
3632
3633         Update text for old EWS submit button
3634         https://bugs.webkit.org/show_bug.cgi?id=197140
3635
3636         Reviewed by Alexey Proskuryakov.
3637
3638         * QueueStatusServer/templates/statusbubble.html:
3639
3640 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
3641
3642         [ews-app] New EWS should poll bugzilla more frequently
3643         https://bugs.webkit.org/show_bug.cgi?id=197138
3644
3645         Reviewed by Alexey Proskuryakov.
3646
3647         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3648         (FetchLoop.__init__):
3649
3650 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
3651
3652         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
3653         https://bugs.webkit.org/show_bug.cgi?id=197139
3654
3655         Reviewed by Alexey Proskuryakov.
3656
3657         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3658         * QueueStatusServer/templates/statusbubble.html:
3659
3660 2019-04-20  Chris Dumez  <cdumez@apple.com>
3661
3662         Unreviewed, fix iOS build with recent SDKs.
3663
3664         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3665
3666 2019-04-19  Keith Miller  <keith_miller@apple.com>
3667
3668         Add script to merge run_benchmark jsons
3669         https://bugs.webkit.org/show_bug.cgi?id=197107
3670
3671         Reviewed by Michael Saboff.
3672
3673         The script basically recursively decends through all json objects until it gets
3674         to an array or JSON primitive and concats or takes the first value, respectively.
3675
3676         This patch also adds +x bits to the compare-results script so it
3677         can be run directly from the command line. I had to add a new line so that svn
3678         will accept the change... yay svn!
3679
3680         * Scripts/compare-results:
3681         * Scripts/merge-result-jsons: Added.
3682         (readJSONFile):
3683         (deepAppend):
3684         (mergeJSONs):
3685         (main):
3686