Better fix for Layout Test fast/parser/external-entities-in-xslt.xml is flaky on...
[WebKit-https.git] / Tools / ChangeLog
1 2016-02-02  Dan Bernstein  <mitz@apple.com>
2
3         Better fix for Layout Test fast/parser/external-entities-in-xslt.xml is flaky on El Capitan (but fails most of the time)
4         https://bugs.webkit.org/show_bug.cgi?id=153683
5
6         Reviewed by Darin Adler.
7
8         * Scripts/webkitpy/port/driver.py:
9         (Driver._setup_environ_for_driver): Reverted change from r196013. DUMPRENDERTREE_TEMP is not
10           used by any code in the Web Content process. If that ever changed, we should send it over
11           as a bundle parameter.
12
13         * Scripts/webkitpy/port/ios.py:
14         (IOSSimulatorPort.setup_environ_for_server): Reverted change from r196013.
15
16         * Scripts/webkitpy/port/mac.py:
17         (MacPort.setup_environ_for_server): Ditto.
18
19         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
20         (WTR::InjectedBundle::platformInitialize): Set XML_CATALOG_FILES in the Web Process
21           environment. This is early enough that libxml2 has not been initialized yet.
22
23         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
24         (WTR::InjectedBundle::platformInitialize): Ditto.
25
26 2016-02-02  Dan Bernstein  <mitz@apple.com>
27
28         Layout Test fast/parser/external-entities-in-xslt.xml is flaky on El Capitan (but fails most of the time)
29         https://bugs.webkit.org/show_bug.cgi?id=153683
30
31         Reviewed by Alexey Proskuryakov.
32
33         Ensure that XML_CATALOG_FILES is set in the Web Content service’s environment as well.
34
35         * Scripts/webkitpy/port/driver.py:
36         (Driver._setup_environ_for_driver): Also set __XPC_DUMPRENDERTREE_TEMP.
37         * Scripts/webkitpy/port/ios.py:
38         (IOSSimulatorPort.setup_environ_for_server): Set __XPC_XML_CATALOG_FILES.
39         * Scripts/webkitpy/port/mac.py:
40         (MacPort.setup_environ_for_server): Ditto.
41
42 2016-01-29 Grzegorz Czajkowski  <g.czajkowski@samsung.com>
43
44         [EFL] Virtual Keyboard overlaps MiniBrowser's WebView
45         https://bugs.webkit.org/show_bug.cgi?id=153009
46
47         Reviewed by Gyuyoung Kim.
48
49         On mobile, virtual keyboard represented by ecore_imf module appears on
50         the top of application layer usually covering bottom part of the screen.
51         If the web page contains the editable content on the bottom of the page
52         it will be overlapped by keyboard which prevents user from seeing the
53         typed text.
54
55         Pack MiniBrowser layout into conformant widget to allow EFL to guess
56         the space that will be required by the keyboard, finally resizing it
57         to the desired size. As a result, webview gets resized and scrolled
58         into focused elements which makes the editable elements visible while
59         typing.
60
61         More details about elm_conformant widger can be found at:
62         https://docs.enlightenment.org/elementary/1.15.0/group__Conformant.html
63         https://docs.enlightenment.org/elementary/1.15.0/conformant_example.html
64
65         * MiniBrowser/efl/main.c:
66         (window_create): pack a box into conformant widget.
67
68 2016-02-02  Alejandro G. Castro  <alex@igalia.com>
69
70         [GTK][EFL] Upgrade OpenWebRTC dependency
71         https://bugs.webkit.org/show_bug.cgi?id=153489
72
73         Reviewed by Philippe Normand.
74
75         * Scripts/run-gtk-tests:
76         (TestRunner): Avoid running the mediastream API test.
77         * Scripts/webkitperl/FeatureList.pm: Stop compiling mediastream by
78         default for gtk and efl.
79         * gtk/jhbuild-webrtc.modules: Added modules files with
80         dependencies required to compile and test the mediastream.
81
82 2016-02-01  Jason Marcell  <jmarcell@apple.com>
83
84         Add code to parse the git branches out of the Trac RSS feed
85         https://bugs.webkit.org/show_bug.cgi?id=153624
86
87         Reviewed by Daniel Bates.
88
89         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
90         (Trac.prototype.commitsOnBranch): Update filter to check for Git branches.
91         (Trac.prototype._convertCommitInfoElementToObject): Parse Git branches from the Trac RSS feed. Also changed "branchName" to
92         "branches" and updated the code to work with an array instead of a string.
93         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
94         (MockTrac): Refactored example commits out into a constant, MockTrac.EXAMPLE_TRAC_COMMITS.
95         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-git-trac-rss.xml: Added. Test
96         fixture that contains XML with a Git branch.
97         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit test to test parsing Git
98         branches from Trac RSS feed. Also updated code to work with the new MockTrac.EXAMPLE_TRAC_COMMITS constant.
99
100 2016-02-01  Brady Eidson  <beidson@apple.com>
101
102         Add command line flag to DRT to output the number of tests completed in server mode.
103         https://bugs.webkit.org/show_bug.cgi?id=153750
104
105         Reviewed by Darin Adler.
106
107         * DumpRenderTree/mac/DumpRenderTree.mm:
108         (initializeGlobalsFromCommandLineOptions):
109         (runTestingServerLoop):
110
111 2016-02-01  Jason Marcell  <jmarcell@apple.com>
112
113         Improvements to botwatcher's dashboard unit tests.
114         https://bugs.webkit.org/show_bug.cgi?id=153621
115
116         Reviewed by Darin Adler.
117
118         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
119         (PopoverTracker): Retain a reference to the PopoverTracker so that we can make assertions about it in the unit tests.
120         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
121         (MockTrac): Changing revision 33019 to be on a different branch so that _appendPendingRevisionCount and
122         _popoverLinesForCommitRange have to traverse commits from different branches.
123         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Changing equal to strictEqual
124         in unit test for _appendPendingRevisionCount. Also added assertions for Popover in test for
125         _revisionContentWithPopoverForIteration.
126
127 2016-02-01  Jason Marcell  <jmarcell@apple.com>
128
129         Refactor to add event listeners and start periodic updates for all trac instances.
130         https://bugs.webkit.org/show_bug.cgi?id=153609
131
132         Reviewed by Darin Adler.
133
134         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
135         (BuildbotQueueView): Adding event listeners for all trac instances.
136         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Starting periodic updates
137         for all trac instances.
138
139 2016-01-31  Darin Adler  <darin@apple.com>
140
141         Replace CaseFoldingHash with ASCIICaseInsensitiveHash
142         https://bugs.webkit.org/show_bug.cgi?id=153639
143
144         Reviewed by Filip Pizlo.
145
146         * Scripts/do-webcore-rename: Use script to do this rename.
147
148 2016-01-30  Commit Queue  <commit-queue@webkit.org>
149
150         Unreviewed, rolling out r195911.
151         https://bugs.webkit.org/show_bug.cgi?id=153723
152
153         Caused frequent assertion failures on bots (Requested by ap on
154         #webkit).
155
156         Reverted changeset:
157
158         "Replace CaseFoldingHash with ASCIICaseInsensitiveHash"
159         https://bugs.webkit.org/show_bug.cgi?id=153639
160         http://trac.webkit.org/changeset/195911
161
162 2016-01-30  Darin Adler  <darin@apple.com>
163
164         Replace CaseFoldingHash with ASCIICaseInsensitiveHash
165         https://bugs.webkit.org/show_bug.cgi?id=153639
166
167         Reviewed by Filip Pizlo.
168
169         * Scripts/do-webcore-rename: Use script to do this rename.
170
171 2016-01-30  Ryosuke Niwa  <rniwa@webkit.org>
172
173         TouchList should be retargeted
174         https://bugs.webkit.org/show_bug.cgi?id=149592
175
176         Reviewed by Antti Koivisto.
177
178         Added touchDownAtPoint and liftUpAtPoint to UIScriptController so that we can test touch events with
179         multiple touch targets on iOS. fast/shadow-dom/touch-event-ios.html uses this new testing feature.
180
181         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
182         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
183         (WTR::UIScriptController::touchDownAtPoint): Added.
184         (WTR::UIScriptController::liftUpAtPoint): Added.
185         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
186         * WebKitTestRunner/ios/HIDEventGenerator.h:
187         * WebKitTestRunner/ios/HIDEventGenerator.mm:
188         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]): Added. Sends touch down and waits.
189         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]): Ditto for lift up.
190         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
191         (WTR::UIScriptController::touchDownAtPoint): Added.
192         (WTR::UIScriptController::liftUpAtPoint): Added.
193
194 2016-01-30  Yusuke Suzuki  <utatane.tea@gmail.com>
195
196         Enable SamplingProfiler on POSIX environment
197         https://bugs.webkit.org/show_bug.cgi?id=153584
198
199         Reviewed by Michael Saboff.
200
201         * Scripts/run-jsc-stress-tests:
202
203 2016-01-29  Nikos Andronikos  <nikos.andronikos-webkit@cisra.canon.com.au>
204
205         update-webkit-dependency fails to fetch updates through firewall on Windows
206         https://bugs.webkit.org/show_bug.cgi?id=153619
207
208         Reviewed by Myles C. Maxfield.
209
210         On Windows, when a firewall is present we need to read proxy settings
211         from environment variables.
212
213         This patch relies on the following environment variables being set:
214         HTTP_PROXY
215         HTTPS_PROXY
216
217         * Scripts/update-webkit-dependency:
218
219 2016-01-28  Dan Bernstein  <mitz@apple.com>
220
221         [Cocoa] Use the non-Development variants of XPC services for development
222         https://bugs.webkit.org/show_bug.cgi?id=152545
223
224         Reviewed by Darin Adler.
225
226         * Scripts/webkitdirs.pm:
227         (setUpGuardMallocIfNeeded): Ensure that libgmalloc is loaded into XPC services as well.
228
229         * Scripts/webkitpy/port/driver.py:
230         (Driver._setup_environ_for_driver): Ensure that the DYLD_LIBRARY_PATH and ASAN_OPTIONS are
231           set in the XPC services as well.
232
233         * Scripts/webkitpy/port/ios.py:
234         (IOSSimulatorPort.setup_environ_for_server): Ensure that malloc stack logging for leaks and
235           Guard Malloc are enabled in XPC services as well.
236
237         * Scripts/webkitpy/port/mac.py:
238         (MacPort.setup_environ_for_server): Ditto.
239
240 2016-01-28  Csaba Osztrogonác  <ossy@webkit.org>
241
242         Unreviewed buildfix after r195743.
243
244         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
245         (WTR::AccessibilityUIElement::isPressActionSupported):
246
247 2016-01-12  Jer Noble  <jer.noble@apple.com>
248
249         Custom protocol loading through AVFoundation does not support byte-range requests.
250         https://bugs.webkit.org/show_bug.cgi?id=152919
251         <rdar://problem/23664657>
252
253         Reviewed by Alex Christensen.
254
255         Add tests for new ParsedContntRange class.
256
257         * TestWebKitAPI/PlatformWin.cmake:
258         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
259         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
260         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
261         * TestWebKitAPI/Tests/WebCore/ParsedContentRange.cpp: Added.
262         (TestWebKitAPI::TEST):
263
264 2016-01-28  Konstantin Tokarev  <annulen@yandex.ru>
265
266         Use isAnyWindows() instead of isCygwin() || isWindows() in Perl scripts.
267         https://bugs.webkit.org/show_bug.cgi?id=153594
268
269         Reviewed by Alex Christensen.
270
271         * Scripts/webkitdirs.pm:
272         (determineNumberOfCPUs):
273         (jscPath):
274         (checkFrameworks):
275         (setupCygwinEnv):
276         (wrapperPrefixIfNeeded):
277         (cmakeGeneratedBuildfile):
278         (generateBuildSystemFromCMakeProject):
279         * Scripts/webkitperl/features.pm:
280         (libraryContainsSymbol):
281
282 2016-01-28  Chris Dumez  <cdumez@apple.com>
283
284         Unreviewed, rolling out r195742.
285
286         Broke EWS
287
288         Reverted changeset:
289
290         "[webkitdirs] Clarify logic behind is{PortName} functions."
291         https://bugs.webkit.org/show_bug.cgi?id=153554
292         http://trac.webkit.org/changeset/195742
293
294 2016-01-28  Darin Adler  <darin@apple.com>
295
296         Remove equalIgnoringCase since all callers really wanted equalIgnoringASCIICase
297         https://bugs.webkit.org/show_bug.cgi?id=153411
298
299         Reviewed by Ryosuke Niwa.
300
301         * Scripts/do-webcore-rename: Removed rename of equalIgnoringCase since we
302         have removed the function instead.
303
304         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
305         (TestWebKitAPI::TEST): Updated test since nullptr is now ambiguous since we
306         added overloads for const char*.
307
308         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
309         (WTR::AccessibilityUIElement::isPressActionSupported): Use equalLettersIgnoringASCIICase.
310         (WTR::AccessibilityUIElement::hasPopup): Ditto.
311         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
312         (WTR::testPathFromURL): Ditto.
313
314 2016-01-28  Konstantin Tokarev  <annulen@yandex.ru>
315
316         [webkitdirs] Clarify logic behind is{PortName} functions.
317         https://bugs.webkit.org/show_bug.cgi?id=153554
318
319         Reviewed by Darin Adler.
320
321         * Scripts/webkitdirs.pm:
322         (determinePortName): Added new function which decides which port are
323         we building based on command line switches and platform defaults.
324         (portName): Added getter for determined $portName.
325         (isEfl): Modified to use portName().
326         (isGtk): Ditto.
327         (isWinCairo): Ditto.
328         (isAppleMacWebKit): Ditto.
329         (isAppleWinWebKit): Ditto.
330         (isIOSWebKit): Ditto.
331         (cmakeBasedPortName): Code replaced with portName() call.
332         (determineIsEfl): Deleted.
333         (determineIsGtk): Deleted.
334         (determineIsWinCairo): Deleted.
335
336 2016-01-28  Konstantin Tokarev  <annulen@yandex.ru>
337
338         [webkitdirs] Don't pass cmakeBasedPortName around.
339         https://bugs.webkit.org/show_bug.cgi?id=153589
340
341         Reviewed by Darin Adler.
342
343         It should be local function of webkitdirs.pm instead.
344
345         * Scripts/build-jsc: Don't pass cmakeBasedPortName to
346         buildCMakeProjectOrExit().
347         * Scripts/build-webkit: Don't pass cmakeBasedPortName to
348         buildCMakeProjectOrExit() and generateBuildSystemFromCMakeProject().
349         * Scripts/run-efl-tests: Don't pass cmakeBasedPortName to
350         generateBuildSystemFromCMakeProject().
351         * Scripts/webkitdirs.pm: Don't export cmakeBasedPortName.
352         (generateBuildSystemFromCMakeProject): Removed $port argument as we
353         can get it from cmakeBasedPortName().
354         (buildCMakeProjectOrExit): Ditto.
355
356 2016-01-28  Gwang Yoon Hwang  <yoon@igalia.com>
357
358         [GStreamer] Clean up includes and headers related with GStreamerGL
359         https://bugs.webkit.org/show_bug.cgi?id=153590
360
361         Reviewed by Philippe Normand.
362
363         * Scripts/webkitpy/style/checker.py: Skips
364         include_order check for MediaPlayerPrivateGStreamerBase.cpp
365         Removes VideoSinkGStreamer1.cpp which doesn't exist anymore.
366
367 2016-01-27  Krzysztof Czech  <k.czech@samsung.com>
368
369         [EFL] Remove unused accessibility related code
370         https://bugs.webkit.org/show_bug.cgi?id=153543
371
372         Reviewed by Darin Adler.
373
374         Removed reference to EAIL library.
375         It not going to be support anymore. There have been changes in
376         EFL/Elementary in terms of the accessibility and we should
377         follow those.
378
379         * efl/jhbuild-optional.modules:
380
381 2016-01-27  Daniel Bates  <dabates@apple.com>
382
383         Remove WebKitSystemInterface for iOS SDK < 9
384         https://bugs.webkit.org/show_bug.cgi?id=153570
385
386         Reviewed by Andy Estes.
387
388         * Scripts/copy-webkitlibraries-to-product-directory:
389
390 2016-01-27  Jason Marcell  <jmarcell@apple.com>
391
392         Fix bugs caused by incorrect usage of "branch" vs. "branchName".
393         https://bugs.webkit.org/show_bug.cgi?id=153330
394
395         Reviewed by Daniel Bates.
396
397         In an earlier patch we started using the name "branch" to indicate a branch object, whereas
398         "branchName" implies that the variable or property in question is simply a string. We fixed some
399         inconsistencies regarding this issue in 152982 but further bugs and inconsistencies were recently
400         spotted in BuildbotQueueView.js.
401
402         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
403         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Change branchName to branch in method signature.
404         Changed branchName to branch.name in call to commitsOnBranch.
405         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Change branch.name to branch in call to
406         _popoverLinesForCommitRange.
407         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Changed context.branchName to context.branch.name.
408         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Changed branch.name to branch.
409         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests to verify
410         fix.
411
412 2016-01-27  Ryosuke Niwa  <rniwa@webkit.org>
413
414         Add API to access closed shadowRoot in InjectedBundle
415         https://bugs.webkit.org/show_bug.cgi?id=153533
416
417         Reviewed by Antti Koivisto.
418
419         Added WebKit2 API test for WKBundleScriptWorldMakeAllShadowRootsOpen.
420
421         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
422         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp: Added.
423         (TestWebKitAPI::runJavaScriptAlert):
424         (TestWebKitAPI::TEST):
425         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakrAllShadowRootOpen_Bundle.cpp: Added.
426         (TestWebKitAPI::InjectedBundleMakrAllShadowRootOpenTest::InjectedBundleMakrAllShadowRootOpenTest):
427         (TestWebKitAPI::InjectedBundleMakrAllShadowRootOpenTest::initialize):
428
429 2016-01-27  Jason Marcell  <jmarcell@apple.com>
430
431         Refactor logic for parsing Trac revisions into its own function and add logic for parsing git hashes.
432         https://bugs.webkit.org/show_bug.cgi?id=153332
433
434         Reviewed by Alexey Proskuryakov.
435
436         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
437         (Trac.prototype._xmlTimelineURL): Uses new function.
438         (Trac.prototype._parseRevisionFromURL): Added. Pulled out logic for parsing revisions from a URL. Also added
439         logic for parsing git hashes.
440         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests for
441         Trac._parseRevisionFromURL.
442
443 2016-01-27  Alexey Proskuryakov  <ap@apple.com>
444
445         Remove Mavericks from the flakiness dashboard
446         https://bugs.webkit.org/show_bug.cgi?id=153521
447
448         Reviewed by Dan Bernstein.
449
450         * TestResultServer/static-dashboards/builders.jsonp:
451         * TestResultServer/static-dashboards/flakiness_dashboard.js:
452
453 2016-01-27  Alexey Proskuryakov  <ap@apple.com>
454
455         Remove ENABLE_CURRENTSRC
456         https://bugs.webkit.org/show_bug.cgi?id=153545
457
458         Reviewed by Simon Fraser.
459
460         * Scripts/webkitperl/FeatureList.pm:
461
462 2016-01-26  Jason Marcell  <jmarcell@apple.com>
463
464         Sort incoming commits via date instead of revision number.
465         https://bugs.webkit.org/show_bug.cgi?id=153467
466
467         Reviewed by Alexey Proskuryakov.
468
469         Future Trac instances may use Git or other revision control systems where we cannnot rely on the revision number
470         for sorting revisions. Instead we use the commit date to sort revisions chronologically.
471
472         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
473         (Trac.prototype._loaded): Sort via date instead of revision number.
474         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
475         (MockTrac): Fix up the mock data to look more like real-world data.
476         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-trac-rss.xml: Added.
477         Fake RSS feed that adds three more commits.
478         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit tests to test
479         Trac._loaded().
480
481 2016-01-26  I-Ting Liu  <iting_liu@apple.com>
482
483         Add a test for WebKit::stringMatchesWildcardString.
484         https://bugs.webkit.org/show_bug.cgi?id=153090
485
486         Reviewed by Darin Adler.
487
488         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
489         Add the file to the project.
490
491         * TestWebKitAPI/Tests/WebKit2/mac/StringUtilities.mm: Added.
492         (TestWebKitAPI::TEST):
493         Test that a string matches another string that may contain wildcard characters.
494
495 2016-01-26  Konstantin Tokarev  <annulen@yandex.ru>
496
497         [webkitdirs] Removed check for bison, gperf, and flex.
498         https://bugs.webkit.org/show_bug.cgi?id=153496
499
500         Reviewed by Alex Christensen.
501
502         This prerequisites are checked in WebKitCommon.cmake and don't
503         have to be in $PATH.
504
505         * Scripts/webkitdirs.pm:
506         (checkRequiredSystemConfig):
507
508 2016-01-26  Konstantin Tokarev  <annulen@yandex.ru>
509
510         [webkitdirs] isCMakeBuild should be true by default
511         https://bugs.webkit.org/show_bug.cgi?id=153497
512
513         Reviewed by Michael Catanzaro.
514
515         * Scripts/webkitdirs.pm:
516         (isCMakeBuild):
517
518 2016-01-26  Daniel Bates  <dabates@apple.com>
519
520         Add WebKitSystemInterface for iOS 9.2
521         https://bugs.webkit.org/show_bug.cgi?id=153355
522
523         Rubber-stamped by David Kilzer.
524
525         * Scripts/copy-webkitlibraries-to-product-directory:
526
527 2016-01-26  Daniel Bates  <dabates@apple.com>
528
529         WebKitTestRunner: Credential cache is not cleared between tests
530         https://bugs.webkit.org/show_bug.cgi?id=153407
531         <rdar://problem/24280834>
532
533         Reviewed by Alexey Proskuryakov.
534
535         * WebKitTestRunner/TestController.cpp:
536         (WTR::TestController::resetStateToConsistentValues): Call WKContextClearCachedCredentials()
537         to clear cached credentials.
538
539 2016-01-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
540
541         kill-old-processes: allow to specify on the environment of the bot a list of process that should be killed.
542         https://bugs.webkit.org/show_bug.cgi?id=153483
543
544         Reviewed by Csaba Osztrogonác.
545
546         * BuildSlaveSupport/kill-old-processes:
547         (main): Allow to specify extra tasks to kill via the environment variable WEBKITBOT_TASKSTOKILL
548
549 2016-01-25  Simon Fraser  <simon.fraser@apple.com>
550
551         Give the layout test results file a <title> showing the date and time the tests were run
552         https://bugs.webkit.org/show_bug.cgi?id=153187
553
554         Reviewed by Darin Adler.
555         
556         Include a 'date' property in the JSON with the date and time the tests completed.
557
558         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
559         (summarize_results):
560
561 2016-01-25  Commit Queue  <commit-queue@webkit.org>
562
563         Unreviewed, rolling out r195543.
564         https://bugs.webkit.org/show_bug.cgi?id=153451
565
566         regressed performance of test bots by ~6% (Requested by dydz
567         on #webkit).
568
569         Reverted changeset:
570
571         "WebKitTestRunner: Credential cache is not cleared between
572         tests"
573         https://bugs.webkit.org/show_bug.cgi?id=153407
574         http://trac.webkit.org/changeset/195543
575
576 2016-01-25  Aakash Jain  <aakash_jain@apple.com>
577
578         Failing to upload to flakiness dashboard should not be a hard error
579         https://bugs.webkit.org/show_bug.cgi?id=153444
580         <rdar://problem/22146294>
581
582         Reviewed by Alexey Proskuryakov.
583
584         * Scripts/webkitpy/layout_tests/controllers/manager.py:
585         (Manager._upload_json_files): If JSON file is not generated, do not try to upload it.
586
587 2016-01-25  Daniel Bates  <dabates@apple.com>
588
589         WebKitTestRunner: Credential cache is not cleared between tests
590         https://bugs.webkit.org/show_bug.cgi?id=153407
591         <rdar://problem/24280834>
592
593         Reviewed by Brady Eidson.
594
595         * WebKitTestRunner/TestController.cpp:
596         (WTR::TestController::resetStateToConsistentValues): Reset testing network session
597         to clear cached credentials.
598
599 2016-01-24  Dan Bernstein  <mitz@apple.com>
600
601         Added project.xcworkspace and xcuserdata to this project’s svn:ignore.
602
603         * LayoutTestRelay/LayoutTestRelay.xcodeproj: Added property svn:ignore.
604
605 2016-01-22  Enrica Casucci  <enrica@apple.com>
606
607         Unreviewed build fix after http://trac.webkit.org/changeset/195474.
608
609         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
610         (WTR::TestController::platformCreateWebView):
611
612 2016-01-22  Tim Horton  <timothy_horton@apple.com>
613
614         Add a test for iOS arrow-key repeat
615         https://bugs.webkit.org/show_bug.cgi?id=152857
616         <rdar://problem/24017380>
617
618         Reviewed by Darin Adler.
619
620         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
621         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
622         (WTR::UIScriptController::keyUpUsingHardwareKeyboard):
623         (WTR::UIScriptController::keyDownUsingHardwareKeyboard):
624         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
625         * WebKitTestRunner/ios/HIDEventGenerator.h:
626         * WebKitTestRunner/ios/HIDEventGenerator.mm:
627         (-[HIDEventGenerator keyPress:completionBlock:]):
628         (-[HIDEventGenerator keyDown:completionBlock:]):
629         (-[HIDEventGenerator keyUp:completionBlock:]):
630         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
631         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
632         (WTR::UIScriptController::keyDownUsingHardwareKeyboard):
633         (WTR::UIScriptController::keyUpUsingHardwareKeyboard):
634         Make it possible to independently send keyUp/keyDown, instead of just paired.
635
636 2016-01-22  Tim Horton  <timothy_horton@apple.com>
637
638         Reproducible "Unhanded web process message 'WebUserContentController:AddUserScripts'" and friends
639         https://bugs.webkit.org/show_bug.cgi?id=153193
640         <rdar://problem/24222034>
641
642         Reviewed by Darin Adler.
643
644         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
645         (webViewForScriptMessageHandlerMultipleHandlerRemovalTest):
646         (TEST):
647         Add a test that exhibits the problems we're fixing here.
648         Before, it would both log and assert in debug, and crash in release.
649         Now it runs happily to completion.
650
651 2016-01-22  Enrica Casucci  <enrica@apple.com>
652
653         Add support for testing data detection.
654         https://bugs.webkit.org/show_bug.cgi?id=153360
655
656         Reviewed by Tim Horton.
657
658         Adding a new testing option (useDataDetection) to turn on
659         data detection when running the a test.
660
661         * WebKitTestRunner/TestController.cpp:
662         (WTR::updateTestOptionsFromTestHeader):
663         * WebKitTestRunner/TestOptions.h:
664         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
665         (WTR::TestController::platformCreateWebView):
666
667 2016-01-21  Simon Fraser  <simon.fraser@apple.com>
668
669         Fix the lldb WebCoreLayoutUnitProvider to not dynamically look up the LayoutUnit denominator
670         https://bugs.webkit.org/show_bug.cgi?id=153334
671
672         Reviewed by Zalan Bujtas.
673         
674         Evaluating expressions in the LayoutUnit summary provider seems to cause
675         re-entrancy problems in lldb python bindings, so just hardcode the LayoutUnit
676         denominator to 64.
677
678         * lldb/lldb_webkit.py:
679         (WebCoreLayoutUnitProvider.to_string):
680
681 2016-01-21  Filip Pizlo  <fpizlo@apple.com>
682
683         display-profiler-output should be able to display code blocks sorted by machine counts
684         https://bugs.webkit.org/show_bug.cgi?id=153298
685
686         Reviewed by Oliver Hunt.
687
688         * Scripts/display-profiler-output:
689
690 2016-01-21  Julien Isorce  <j.isorce@samsung.com>
691
692         Ensure to use compatible liborc version with wanted gstreamer version
693         https://bugs.webkit.org/show_bug.cgi?id=153276
694
695         For example gst-plugins-base-1.4.4 fails to build with liborc-0.4.24.
696         The user may have a very recent liborc installed on his system.
697
698         Reviewed by Philippe Normand.
699
700         * efl/jhbuild.modules: add liborc-0.4.17 and make it a gst dependency.
701         * gtk/jhbuild.modules: add liborc-0.4.17 and make it a gst depencendy.
702
703 2016-01-21  Nan Wang  <n_wang@apple.com>
704
705         AX: [IOS] Implement next/previous text marker functions using TextIterator
706         https://bugs.webkit.org/show_bug.cgi?id=153292
707         <rdar://problem/24268243>
708
709         Reviewed by Chris Fleizach.
710
711         Made text marker tests available on iOS.
712
713         * DumpRenderTree/AccessibilityTextMarker.h:
714         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
715         * DumpRenderTree/ios/AccessibilityTextMarkerIOS.mm: Added.
716         (AccessibilityTextMarker::AccessibilityTextMarker):
717         (AccessibilityTextMarker::~AccessibilityTextMarker):
718         (AccessibilityTextMarker::isEqual):
719         (AccessibilityTextMarker::platformTextMarker):
720         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
721         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
722         (AccessibilityTextMarkerRange::isEqual):
723         (AccessibilityTextMarkerRange::platformTextMarkerRange):
724         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
725         (AccessibilityUIElement::pathDescription):
726         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
727         (AccessibilityUIElement::textMarkerRangeForElement):
728         (AccessibilityUIElement::selectedTextMarkerRange):
729         (AccessibilityUIElement::resetSelectedTextMarkerRange):
730         (AccessibilityUIElement::textMarkerRangeLength):
731         (AccessibilityUIElement::textMarkerRangeForMarkers):
732         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
733         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
734         (AccessibilityUIElement::accessibilityElementForTextMarker):
735         (AccessibilityUIElement::endTextMarkerForBounds):
736         (AccessibilityUIElement::startTextMarkerForBounds):
737         (AccessibilityUIElement::textMarkerForPoint):
738         (AccessibilityUIElement::previousTextMarker):
739         (AccessibilityUIElement::nextTextMarker):
740         (AccessibilityUIElement::stringForTextMarkerRange):
741         (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
742         (AccessibilityUIElement::indexForTextMarker):
743         (AccessibilityUIElement::isTextMarkerValid):
744         (AccessibilityUIElement::textMarkerForIndex):
745         (AccessibilityUIElement::startTextMarker):
746         (AccessibilityUIElement::endTextMarker):
747         (AccessibilityUIElement::setSelectedVisibleTextRange):
748         (AccessibilityUIElement::getLinkedUIElements):
749         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
750         (AccessibilityTextMarkerRange::platformTextMarkerRange):
751         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
752         (AccessibilityUIElement::removeSelection):
753         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
754         (AccessibilityUIElement::setSelectedVisibleTextRange):
755         (AccessibilityUIElement::supportedActions):
756         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
757         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
758         (WTR::AccessibilityUIElement::textMarkerRangeLength):
759         (WTR::AccessibilityUIElement::previousTextMarker):
760         (WTR::AccessibilityUIElement::nextTextMarker):
761         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
762         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
763         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
764         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
765         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
766         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
767         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
768
769 2016-01-20  Filip Pizlo  <fpizlo@apple.com>
770
771         Unreviewed, revert accidental unreviewed commit.
772
773         * Scripts/display-profiler-output:
774
775 2016-01-20  Jason Marcell  <jmarcell@apple.com>
776
777         Refactor compareIterations to remove duplicate code.
778         https://bugs.webkit.org/show_bug.cgi?id=152913
779
780         Reviewed by Daniel Bates.
781
782         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
783         (BuildbotQueue.prototype.compareIterations): Refactored to remove duplicate code.
784         (BuildbotQueue.prototype.sortIterations): Add binding to call to compareIterations.
785         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests in order to ensure
786         the same behavior before and after refactor.
787
788 2016-01-20  Dana Burkart  <dburkart@apple.com>
789
790         Botwatcher's dashboard should show an 'X' when the build is broken
791         https://bugs.webkit.org/show_bug.cgi?id=152507
792
793         Reviewed by David Kilzer.
794
795         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
796         (BuildbotStaticAnalyzerQueueView.prototype.appendStaticAnalyzerQueueStatus):
797         (BuildbotStaticAnalyzerQueueView.prototype.update):
798
799 2016-01-19  Jason Marcell  <jmarcell@apple.com>
800
801         Remove assertion from revisionContentForIteration that is causing errors on the dashboard.
802         https://bugs.webkit.org/show_bug.cgi?id=153262
803
804         Reviewed by Alexey Proskuryakov.
805
806         Occasionaly some buildbot iterations will not have their "got_revisions" property populated. In
807         such cases this revisionContentForIteration method does not have any content to return, thus the
808         assertion fails.
809
810         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
811         (BuildbotQueueView.prototype.revisionContentForIteration): Removed assertion that was causing errors.
812
813 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
814
815         [GTK] Runtime critical warnings when loading a URL after a session restore
816         https://bugs.webkit.org/show_bug.cgi?id=153233
817
818         Reviewed by Michael Catanzaro.
819
820         Add new test case.
821
822         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
823         (viewLoadChanged):
824         (testWebKitWebViewNavigationAfterSessionRestore):
825         (beforeAll):
826
827 2016-01-19  Michael Catanzaro  <mcatanzaro@igalia.com>
828
829         [GTK] Remove jhbuild-optional.modules
830         https://bugs.webkit.org/show_bug.cgi?id=152964
831
832         Reviewed by Alex Christensen.
833
834         * gtk/jhbuild-optional.modules: Removed.
835         * gtk/jhbuild.modules:
836
837 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
838
839         [GTK] Add support to load/save session in MiniBrowser
840         https://bugs.webkit.org/show_bug.cgi?id=153201
841
842         Reviewed by Michael Catanzaro.
843
844         It makes it easier to test the new WebView session API.
845
846         * MiniBrowser/gtk/BrowserWindow.c:
847         (browserWindowFinalize): Free the session file path.
848         (browserWindowSaveSession): Save the current WebView session if
849         there's a session file path.
850         (browserWindowDeleteEvent): Call browserWindowSaveSession().
851         (browser_window_load_session): Try to load the session from the
852         given file path, otherwise fall back to homepage and keep the
853         session file to save the session on window close.
854         * MiniBrowser/gtk/BrowserWindow.h:
855         * MiniBrowser/gtk/main.c:
856         (createBrowserWindow): Pass the given session file path when
857         shouldLoadSession is TRUE.
858         (main): Only allow to restore/save session when MiniBrowser is
859         launched without URL arguments.
860
861 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
862
863         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/geolocation-permission-requests after r195075.
864
865         Geolocation is no longer allowed for unique origins after r195075.
866
867         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
868         (testWebViewGeolocationPermissionRequests):
869
870 2016-01-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
871
872         [GTK][EFL] Layout tests abort with PulseAudioSanitizer instance has no attribute '_pa_module_index' when the build is not ready.
873         https://bugs.webkit.org/show_bug.cgi?id=153216
874
875         Reviewed by Michael Catanzaro.
876
877         * Scripts/webkitpy/port/pulseaudio_sanitizer.py:
878         (PulseAudioSanitizer.__init__): initialize _pa_module_index in the constructor.
879
880 2016-01-18  Nan Wang  <n_wang@apple.com>
881
882         AX: [Mac] Implement next/previous text marker functions using TextIterator
883         https://bugs.webkit.org/show_bug.cgi?id=152728
884
885         Reviewed by Chris Fleizach.
886
887         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
888         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
889
890 2016-01-18  Csaba Osztrogonác  <ossy@webkit.org>
891
892         [cmake] Add testair to the build system
893         https://bugs.webkit.org/show_bug.cgi?id=153126
894
895         Reviewed by Michael Catanzaro.
896
897         * Scripts/build-jsc:
898
899 2016-01-16  Myles C. Maxfield  <mmaxfield@apple.com>
900
901         Remove TextRun::allowsRoundingHacks()
902         https://bugs.webkit.org/show_bug.cgi?id=153185
903
904         Reviewed by Simon Fraser.
905
906         * DumpRenderTree/mac/DumpRenderTree.mm:
907         (resetWebViewToConsistentStateBeforeTesting): Deleted.
908
909 2016-01-15  Konstantin Tokarev  <annulen@yandex.ru>
910
911         [webkitdirs] Avoid list form of open because it broke WinCairo
912         https://bugs.webkit.org/show_bug.cgi?id=153106
913
914         Reviewed by Alex Christensen.
915
916         * Scripts/webkitdirs.pm:
917         (determineArchitecture):
918
919 2016-01-15  Simon Fraser  <simon.fraser@apple.com>
920
921         Add kdebug_trace signposts for a few WebCore operations
922         https://bugs.webkit.org/show_bug.cgi?id=153136
923         rdar://problem/24208487
924
925         Reviewed by Sam Weinig.
926         
927         Plist used by kdebug_trace() viewing tools.
928
929         * Tracing/SystemTracePoints.plist: Added.
930
931 2016-01-14  Konstantin Tokarev  <annulen@yandex.ru>
932
933         [webkitdirs] Replaced grep invocation with perl code
934         https://bugs.webkit.org/show_bug.cgi?id=153106
935
936         Reviewed by Alex Christensen.
937
938         * Scripts/webkitdirs.pm:
939         (determineArchitecture):
940
941 2016-01-14  Brian Burg  <bburg@apple.com>
942
943         prepare-changelog does not read paths containing spaces properly
944         https://bugs.webkit.org/show_bug.cgi?id=137982
945
946         Reviewed by Joseph Pecoraro.
947
948         Escape whitespace in filenames before passing the file path to other functions.
949
950         * Scripts/prepare-ChangeLog:
951         (generateFunctionLists): Use the more explicit 3-argument form of 'open'.
952
953 2016-01-14  Jason Marcell  <jmarcell@apple.com>
954
955         Standardize the usage of "branch" vs. "branchName".
956         https://bugs.webkit.org/show_bug.cgi?id=152982
957
958         Reviewed by Daniel Bates.
959
960         In an earlier patch we started using the name "branch" to indicate a branch object, whereas
961         "branchName" implies that the variable or property in question is simply a string.
962
963         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
964         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Change branch to branchName.
965         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Change branch to branch.name.
966         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Change branch to branchName.
967         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
968         (Trac.prototype.commitsOnBranch): Change branch to branchName.
969         (Trac.prototype._convertCommitInfoElementToObject): Ditto.
970         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
971         (MockTrac): Ditto.
972
973 2016-01-14  Jason Marcell  <jmarcell@apple.com>
974
975         Add a unit test to test BuildbotQueueView._appendPendingRevisionCount.
976         https://bugs.webkit.org/show_bug.cgi?id=152910
977
978         Reviewed by Daniel Bates.
979
980         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueue.js: Added.
981         (MockBuildbotQueue): Added. Mock BuildbotQueue object that doesn't need to talk to an actual Buildbot server.
982         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js: Added.
983         (MockBuildbotQueueView): Added. Mock BuildbotQueueView object that returns a pre-specified _latestProductiveIteration without
984         the need to talk to a real Buildbot server.
985         (MockBuildbotQueueView.prototype._latestProductiveIteration): Added. Returns a pre-specified _latestProductiveIteration
986         without the need to talk to a real Buildbot server.
987         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js: Added.
988         (MockTrac): Added. Mock Trac constructor that has pre-populated "recordedCommits" and does not need to talk to a real Trac
989         server.
990         (MockTrac.prototype.get oldestRecordedRevisionNumber): Added. Returns a pre-specified revision.
991         (MockTrac.prototype.get latestRecordedRevisionNumber): Ditto.
992         (MockTrac.prototype.loadMoreHistoricalData): Added. Overrides the real loadMoreHistoricalData so that we don't waste time
993         trying to talk to Trac.
994         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Added. Web page container for
995         QUnit unit tests.
996         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added. QUnit unit tests.
997
998 2016-01-14  Nikos Andronikos  <nikos.andronikos-webkit@cisra.canon.com.au>
999
1000         [CMake][GTK] CMake Error: Could not create named generator Eclipse CDT4 - Ninja
1001         https://bugs.webkit.org/show_bug.cgi?id=132599
1002
1003         Reviewed by Michael Catanzaro.
1004
1005         Check if cmake Ninja generators are installed.
1006
1007         * Scripts/webkitdirs.pm:
1008         (canUseNinjaGenerator):
1009         (canUseEclipseNinjaGenerator):
1010         (generateBuildSystemFromCMakeProject):
1011         (canUseEclipse): Deleted.
1012
1013 2016-01-13  Myles C. Maxfield  <mmaxfield@apple.com>
1014
1015         [Cocoa] Testing with font family name "System Font" is unused
1016         https://bugs.webkit.org/show_bug.cgi?id=153073
1017         <rdar://problem/24091683>
1018
1019         Reviewed by Brent Fulgham.
1020
1021         * DumpRenderTree/mac/DumpRenderTree.mm:
1022         (allowedFontFamilySet): Deleted.
1023         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1024         (WTR::allowedFontFamilySet): Deleted.
1025         * WebKitTestRunner/mac/TestControllerMac.mm:
1026         (WTR::allowedFontFamilySet): Deleted.
1027
1028 2016-01-13  Daniel Bates  <dabates@apple.com>
1029
1030         [XSS Auditor] Add test when XSS payload is in the path portion of the URL
1031         https://bugs.webkit.org/show_bug.cgi?id=152871
1032
1033         Reviewed by Brent Fulgham.
1034
1035         Merged from Blink (patch by Tom Sepez <tsepez@chromium.org>):
1036         <https://src.chromium.org/viewvc/blink?revision=164746&view=revision>
1037
1038         * Scripts/webkitpy/layout_tests/servers/lighttpd.conf:
1039
1040 2016-01-08  Andy Estes  <aestes@apple.com>
1041
1042         [Content Filtering] Lazily load platform frameworks
1043         https://bugs.webkit.org/show_bug.cgi?id=152881
1044         rdar://problem/23270886
1045
1046         Reviewed by Brady Eidson.
1047
1048         Added an API test that verifies that the Parental Controls and Network Extension frameworks are loaded at the
1049         expected times. The test verifies that they are not loaded after creating a WKWebView, loading an HTML string,
1050         loading NSData, loading a file, or loading from a custom protocol. It verifies that Network Extension on Mac/iOS
1051         and Parental Controls on iOS are loaded after an HTTP request. It finally verifies that Parental Controls on Mac
1052         is loaded after an HTTPS request.
1053
1054         To accomplish this, TestProtocol was generalized to allow tests to specify the scheme they wish to use.
1055         Other tests that used TestProtocol were updated to account for this change. TestProtocol was removed from
1056         WebKit2.PreventImageLoadWithAutoResizingTest, which didn't actually need to use it. ContentFiltering tests were
1057         also re-enabled on iOS after mistakenly being disabled by r188892.
1058
1059         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1060         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1061         (TestWebKitAPI::TEST):
1062         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.h: Added.
1063         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.html: Added.
1064         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
1065         (TEST):
1066         (downloadTest):
1067         (-[LazilyLoadPlatformFrameworksController init]):
1068         (-[LazilyLoadPlatformFrameworksController webView]):
1069         (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
1070         (-[LazilyLoadPlatformFrameworksController webView:didFinishNavigation:]):
1071         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
1072         (-[ContentFilteringPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1073         (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]):
1074         (-[ContentFilteringPlugIn checkIfPlatformFrameworksAreLoaded:]):
1075         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1076         (TestWebKitAPI::TEST):
1077         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1078         (TestWebKitAPI::TEST): Deleted.
1079         * TestWebKitAPI/cocoa/TestProtocol.h:
1080         * TestWebKitAPI/cocoa/TestProtocol.mm:
1081         (+[TestProtocol registerWithScheme:]):
1082         (+[TestProtocol unregister]):
1083
1084 2016-01-12  Dewei Zhu  <dewei_zhu@apple.com>
1085
1086         Fix the Sunpider converage in slow device.
1087         https://bugs.webkit.org/show_bug.cgi?id=152938
1088         <rdar://problem/22511411>
1089
1090         Reviewed by Ryosuke Niwa.
1091
1092         Updated the patch for RunBenchmark to resume sunspider coverage by removing unused subresources in sub-tests.
1093
1094         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch:
1095
1096 2016-01-12  Ryosuke Niwa  <rniwa@webkit.org>
1097
1098         Add a build flag for custom element
1099         https://bugs.webkit.org/show_bug.cgi?id=153005
1100
1101         Reviewed by Alex Christensen.
1102
1103         Added --custom-elements option to enable custom elements support.
1104
1105         * Scripts/webkitperl/FeatureList.pm:
1106
1107 2016-01-12  Benjamin Poulain  <bpoulain@apple.com>
1108
1109         [JSC] Add a help message when run-jsc-stress-tests fails
1110         https://bugs.webkit.org/show_bug.cgi?id=153014
1111
1112         Reviewed by Csaba Osztrogonác.
1113
1114         * Scripts/run-jsc-stress-tests:
1115
1116 2016-01-11  Saam barati  <sbarati@apple.com>
1117
1118         run-jsc-stress-tests should try to figure out a JSC path
1119         https://bugs.webkit.org/show_bug.cgi?id=152971
1120
1121         Reviewed by Yusuke Suzuki.
1122
1123         This patch now allows run-jsc-stress-tests to be run
1124         without a "--jsc <jsc-path>" argument. It tries
1125         to take its best guess at a <jsc-path> automagically.
1126         
1127         This makes it much easier to just run run-jsc-stress-tests
1128         with a directory or a yaml file as an argument.
1129         You now just do this:
1130         `run-jsc-stress-tests <path-to-yaml>`
1131         or
1132         `run-jsc-stress-tests <path-to-directory-of-js-files>`
1133         
1134         I wrote this patch because I'd often find myself hacking the 
1135         run-javascriptcore-tests file just to run a particular subset of tests.
1136         Because I always forget the arguments to run-jsc-stress-tests (which means
1137         I always forgot to provide a --jsc argument), I always found it easier to 
1138         just hack on that file instead of calling run-jsc-stress-tests directly.
1139         No longer is this true!
1140
1141         * Scripts/run-jsc-stress-tests:
1142
1143 2016-01-09  Andy Estes  <aestes@apple.com>
1144
1145         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
1146         https://bugs.webkit.org/show_bug.cgi?id=152950
1147         rdar://problem/24066652
1148
1149         Reviewed by Tim Horton.
1150
1151         Added an API test.
1152
1153         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1154         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
1155         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
1156         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
1157         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
1158         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
1159         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
1160         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
1161         (TEST):
1162
1163 2016-01-11  Commit Queue  <commit-queue@webkit.org>
1164
1165         Unreviewed, rolling out r194866.
1166         https://bugs.webkit.org/show_bug.cgi?id=152986
1167
1168         This change broke the mac build (Requested by ryanhaddad on
1169         #webkit).
1170
1171         Reverted changeset:
1172
1173         "[Cocoa] Add SPI to opt out a URL scheme from the memory
1174         cache"
1175         https://bugs.webkit.org/show_bug.cgi?id=152950
1176         http://trac.webkit.org/changeset/194866
1177
1178 2016-01-11  Andy Estes  <aestes@apple.com>
1179
1180         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
1181         https://bugs.webkit.org/show_bug.cgi?id=152950
1182         rdar://problem/24066652
1183
1184         Reviewed by Tim Horton.
1185
1186         Added an API test.
1187
1188         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1189         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
1190         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
1191         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
1192         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
1193         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
1194         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
1195         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
1196         (TEST):
1197
1198 2016-01-11  Konstantin Tokarev  <annulen@yandex.ru>
1199
1200         [webkitdirs] Use CMake to determine architecture on isCMakeBuild()
1201         https://bugs.webkit.org/show_bug.cgi?id=152959
1202
1203         Reviewed by Brent Fulgham.
1204
1205         * Scripts/webkitdirs.pm:
1206         (determineArchitecture):
1207
1208 2016-01-11  Michael Catanzaro  <mcatanzaro@igalia.com>
1209
1210         [GTK] W3C CSS2.1 anonymous table tests are failing
1211         https://bugs.webkit.org/show_bug.cgi?id=152455
1212
1213         Reviewed by Mario Sanchez Prada.
1214
1215         Add shared-mime-info to the jhbuild environment, since it affects the results of layout
1216         tests. Add upstream patches to fix detection of XHTML files.
1217
1218         * gtk/jhbuild.modules:
1219         * gtk/patches/shared-mime-info-xht-glob.patch: Added.
1220         * gtk/patches/shared-mime-info-xhtml-magic.patch: Added.
1221
1222 2016-01-10  Saam barati  <sbarati@apple.com>
1223
1224         Implement a sampling profiler
1225         https://bugs.webkit.org/show_bug.cgi?id=151713
1226
1227         Reviewed by Filip Pizlo.
1228
1229         * Scripts/run-jsc-stress-tests:
1230
1231 2016-01-10  Konstantin Tokarev  <annulen@yandex.ru>
1232
1233         [webkitdirs] Try arch and uname commands on non-windows OS
1234         https://bugs.webkit.org/show_bug.cgi?id=152958
1235
1236         Reviewed by Michael Catanzaro.
1237
1238         Right now, determineArchitecture()  uses `arch` and `uname -m`
1239         commands to determine architecture in case of condition (isGtk() ||
1240         isAppleMacWebKit() || isEfl()) is true. This should be !anyWindows()
1241         instead, because this code is applicable to any non-windows OS WebKit
1242         supports (even Haiku which once was supported is moderately
1243         POSIX-compliant and has uname command).
1244
1245         * Scripts/webkitdirs.pm:
1246         (determineArchitecture):
1247
1248 2016-01-08  Aakash Jain  <aakash_jain@apple.com>
1249
1250         run-webkit-tests mis-counts totals when there are other crashes
1251         https://bugs.webkit.org/show_bug.cgi?id=152894
1252         <rdar://problem/24098697>
1253
1254         Reviewed by Alexey Proskuryakov.
1255
1256         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1257         (TestRunResults.add): Do not update result counters for other crashes.
1258
1259 2016-01-08  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1260
1261         webkit-patch build-and-test should have an option to iterate over new tests
1262         https://bugs.webkit.org/show_bug.cgi?id=143093
1263
1264         Reviewed by Michael Catanzaro.
1265
1266         This patch introduces the --iterate-on-new-tests option to webkit-patch build-and-test.
1267         It allows running run-webkit-tests on modified or new paths in LayoutTests.
1268         Computation of new or modified tests is done by LayoutTestFinder.find_touched_tests
1269         It implements the translation of -expected.* paths to their related tests.
1270         It also implements the removal of skipped tests.
1271
1272         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
1273         (LayoutTestFinder.find_touched_tests):
1274         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py: Added.
1275         (MockPort):
1276         (MockPort.__init__):
1277         (MockPort.tests):
1278         (LayoutTestFinderTests):
1279         (LayoutTestFinderTests.touched_files):
1280         (LayoutTestFinderTests.test_touched_test):
1281         (LayoutTestFinderTests.test_expected_touched_test):
1282         (LayoutTestFinderTests.test_platform_expected_touched_test):
1283         (LayoutTestFinderTests.test_platform_duplicate_touched_test):
1284         (LayoutTestFinderTests.test_touched_but_skipped_test):
1285         * Scripts/webkitpy/port/base.py:
1286         (Port.potential_test_names_from_expected_file):
1287         * Scripts/webkitpy/tool/commands/download_unittest.py:
1288         (DownloadCommandsTest._default_options):
1289         * Scripts/webkitpy/tool/steps/options.py:
1290         (Options):
1291         * Scripts/webkitpy/tool/steps/runtests.py:
1292         (RunTests.options):
1293         (RunTests.run):
1294         (RunTests):
1295         (RunTests._new_or_modified_tests):
1296         (RunTests._run_webkit_tests):
1297         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1298         (RunTestsTest.test_webkit_run_unit_tests):
1299         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1300         (StepsTest._step_options):
1301
1302 2016-01-07  Joseph Pecoraro  <pecoraro@apple.com>
1303
1304         prepare-ChangeLog should include radar number
1305         https://bugs.webkit.org/show_bug.cgi?id=152839
1306         <rdar://problem/24093563>
1307
1308         Reviewed by Daniel Bates.
1309
1310         When running `prepare-ChangeLog -b ###`, check for a bugzilla comment that
1311         starts with a "<rdar://problem/####>" URL. If found, include that radar URL
1312         in the ChangeLog description after the bug URL.
1313
1314         * Scripts/prepare-ChangeLog:
1315         (main): Update signatures.
1316         (fetchBugXMLData): XML Data is now used for multiple reasons. Extract this to just get the data.
1317         (fetchBugDescriptionFromBugXMLData): Search data for <short_desc>.
1318         (fetchRadarURLFromBugXMLData): Search comment text for radar URL.
1319         (generateNewChangeLogs): Include radar URL if we found one.
1320
1321         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl: Added.
1322         Tests for the radar URL extraction.
1323
1324 2016-01-07  Alexey Proskuryakov  <ap@apple.com>
1325
1326         testRunner.runUIScript crashes while running multiple tests in a row that invokes the same UIScript
1327         https://bugs.webkit.org/show_bug.cgi?id=152390
1328         <rdar://problem/23948321>
1329
1330         Reviewed by Simon Fraser.
1331
1332         Fix two use-after-frees.
1333
1334         1. WKPageCallAfterNextPresentationUpdate's callback has a pointer to TestInvocation,
1335         but we may have already progressed to another test by the time the callback fires,
1336         having destroyed the TestInvocation.
1337         2. UIScriptController is a RefCounted object, but it has a raw pointer to
1338         UIScriptContext which has the same lifetime as a TestInvocation.
1339         As a result, completion blocks of UIScriptController actions would use a destroyed
1340         TestInvocation.
1341
1342         * WebKitTestRunner/TestInvocation.cpp:
1343         (WTR::TestInvocation::~TestInvocation):
1344         (WTR::TestInvocation::url):
1345         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1346         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
1347         (WTR::TestInvocation::runUISideScript):
1348         * WebKitTestRunner/TestInvocation.h:
1349         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
1350         (UIScriptContext::UIScriptContext):
1351         (UIScriptContext::~UIScriptContext):
1352         (UIScriptContext::runUIScript):
1353         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
1354         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1355         (WTR::UIScriptController::UIScriptController):
1356         (WTR::UIScriptController::contextDestroyed):
1357         (WTR::UIScriptController::makeWindowObject):
1358         (WTR::UIScriptController::setWillBeginZoomingCallback):
1359         (WTR::UIScriptController::willBeginZoomingCallback):
1360         (WTR::UIScriptController::setDidEndZoomingCallback):
1361         (WTR::UIScriptController::didEndZoomingCallback):
1362         (WTR::UIScriptController::setDidEndScrollingCallback):
1363         (WTR::UIScriptController::didEndScrollingCallback):
1364         (WTR::UIScriptController::setDidShowKeyboardCallback):
1365         (WTR::UIScriptController::didShowKeyboardCallback):
1366         (WTR::UIScriptController::setDidHideKeyboardCallback):
1367         (WTR::UIScriptController::didHideKeyboardCallback):
1368         (WTR::UIScriptController::uiScriptComplete):
1369         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1370         (WTR::UIScriptController::create):
1371         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1372         (WTR::UIScriptController::doAsyncTask):
1373         (WTR::UIScriptController::zoomToScale):
1374         (WTR::UIScriptController::singleTapAtPoint):
1375         (WTR::UIScriptController::doubleTapAtPoint):
1376         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
1377         (WTR::UIScriptController::contentVisibleRect):
1378         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
1379         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
1380         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
1381         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
1382         (WTR::UIScriptController::platformSetDidEndScrollingCallback):
1383         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1384         (WTR::UIScriptController::doAsyncTask):
1385
1386 2016-01-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1387
1388         [buildbot] clean-build script should remove untracked files and revert local changes too
1389         https://bugs.webkit.org/show_bug.cgi?id=142400
1390
1391         Reviewed by Ryosuke Niwa.
1392
1393         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
1394         A helper routine SCM.discard_untracked_files is added for that purpose.
1395
1396         * BuildSlaveSupport/clean-build:
1397         (main): Making call to Scripts/clean-webkit
1398         * Scripts/clean-webkit: Added.
1399         (main): Revert changes and delete untracked files.
1400         * Scripts/webkitpy/common/checkout/scm/scm.py:
1401         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
1402         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1403         (SCMTest._shared_test_discard_untracked_files):
1404         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
1405
1406 2016-01-06  Simon Fraser  <simon.fraser@apple.com>
1407
1408         Add a setting and preferences to enable display-list drawing. Does nothing yet.
1409         https://bugs.webkit.org/show_bug.cgi?id=152807
1410
1411         Reviewed by Zalan Bujtas.
1412         
1413         Add an item to the Settings menu to toggle display-list drawing.
1414
1415         * MiniBrowser/mac/SettingsController.h:
1416         * MiniBrowser/mac/SettingsController.m:
1417         (-[SettingsController _populateMenu]):
1418         (-[SettingsController validateMenuItem:]):
1419         (-[SettingsController toggleDisplayListDrawingEnabled:]):
1420         (-[SettingsController displayListDrawingEnabled]):
1421         * MiniBrowser/mac/WK2BrowserWindowController.m:
1422         (-[WK2BrowserWindowController didChangeSettings]):
1423
1424 2016-01-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1425
1426         Python SCM should be able to retrieve untracked files - Add GIT support
1427         https://bugs.webkit.org/show_bug.cgi?id=143135
1428
1429         Reviewed by Michael Catanzaro.
1430
1431         * Scripts/webkitpy/common/checkout/scm/git.py:
1432         (Git.untracked_files): Adding support for git.
1433         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1434         (GitTest.setUp):
1435         (GitTest.test_untracked_files): Adding test.
1436
1437 2016-01-05  Mark Lam  <mark.lam@apple.com>
1438
1439         Rename badly named JSC_timeout env var to JSCTEST_timeout.
1440         https://bugs.webkit.org/show_bug.cgi?id=152748
1441
1442         Reviewed by Geoffrey Garen.
1443
1444         Now that we validate JSC options, the badly named JSC_timeout env var causes the
1445         bots to have a bad time.
1446
1447         * Scripts/run-javascriptcore-tests:
1448         * Scripts/run-jsc-stress-tests:
1449
1450 2016-01-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1451
1452         [GTK] Allow to save and restore session
1453         https://bugs.webkit.org/show_bug.cgi?id=115600
1454
1455         Reviewed by Michael Catanzaro.
1456
1457         Add test case to check the new session API.
1458
1459         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
1460         (testWebKitWebViewSessionState):
1461         (testWebKitWebViewSessionStateWithFormData):
1462         (beforeAll):
1463
1464 2016-01-04  Csaba Osztrogonác  <ossy@webkit.org>
1465
1466         [EFL] Bump EFL version to 1.16.1
1467         https://bugs.webkit.org/show_bug.cgi?id=152688
1468
1469         Reviewed by Gyuyoung Kim.
1470
1471         * efl/jhbuild.modules:
1472
1473 2016-01-04  Aakash Jain  <aakash_jain@apple.com>
1474
1475         error running layout tests on iOS simulator on latest build
1476         https://bugs.webkit.org/show_bug.cgi?id=152719
1477         <rdar://problem/24009549>
1478
1479         Reviewed by Alexey Proskuryakov.
1480
1481         * Scripts/webkitpy/xcode/simulator.py:
1482         (Simulator.wait_until_device_is_booted): Ensure that simulator device is in booted state
1483           before running simctl spawn command.
1484
1485 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1486
1487         Unreviewed, move Frédéric Wang to committers list
1488
1489         He seems to be on the contributors list by accident. He has been landing his own commits for
1490         about two years now.
1491
1492         * Scripts/webkitpy/common/config/contributors.json:
1493
1494 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1495
1496         Unreviewed, move Sebastian Dröge to committers list harder
1497
1498         He accidentally added himself to the reviewers list because the file is confusing. Then I
1499         accidentially moved him to the contributors list because the file is confusing, even though
1500         I knew the contributors list existed in this file and was attempting to add him to the
1501         committers list. Really move him to the committers list now.
1502
1503         * Scripts/webkitpy/common/config/contributors.json:
1504
1505 2016-01-02  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1506
1507         Python SCM should be able to retrieve untracked files - Add SVN support
1508         https://bugs.webkit.org/show_bug.cgi?id=152546
1509
1510         Reviewed by Michael Catanzaro.
1511
1512         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1513         (test_untracked_files): Activating test for SVN.
1514         * Scripts/webkitpy/common/checkout/scm/svn.py:
1515         (SVN.untracked_files): Implementing untracked files retrieval for SVN.
1516
1517 2015-12-31  Andy Estes  <aestes@apple.com>
1518
1519         Replace WTF::move with WTFMove
1520         https://bugs.webkit.org/show_bug.cgi?id=152601
1521
1522         Reviewed by Brady Eidson.
1523
1524         * DumpRenderTree/TestRunner.h:
1525         (TestRunner::setAllowedHosts):
1526         * DumpRenderTree/win/DRTDataObject.cpp:
1527         (DRTDataObject::SetData):
1528         * TestWebKitAPI/Tests/WTF/Deque.cpp:
1529         (TestWebKitAPI::TEST):
1530         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1531         (TestWebKitAPI::TEST):
1532         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1533         (TestWebKitAPI::TEST):
1534         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
1535         (TestWebKitAPI::TEST):
1536         * TestWebKitAPI/Tests/WTF/Ref.cpp:
1537         (TestWebKitAPI::passWithRef):
1538         (TestWebKitAPI::TEST):
1539         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
1540         (TestWebKitAPI::TEST):
1541         * TestWebKitAPI/Tests/WTF/Vector.cpp:
1542         (TestWebKitAPI::TEST):
1543         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1544         (TestWebKitAPI::TEST):
1545         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
1546         (TestWebKitAPI::TEST):
1547         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
1548         (TestWebKitAPI::createTestValue):
1549         (TestWebKitAPI::TEST):
1550         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1551         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1552         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
1553         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
1554         (TestWebKitAPI::createNFAs):
1555         (TestWebKitAPI::TEST_F):
1556         * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp:
1557         (TestWebKitAPI::combine):
1558         * TestWebKitAPI/Tests/WebCore/DFAHelpers.h:
1559         (TestWebKitAPI::createNFAs):
1560         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm:
1561         (TEST):
1562         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
1563         (WebProcessTest::add):
1564
1565 2016-01-01  Michael Catanzaro  <mcatanzaro@igalia.com>
1566
1567         [SOUP] REGRESSION(r192761): Broke resource URIs for applications that use g_resource_load in a web extension
1568         https://bugs.webkit.org/show_bug.cgi?id=152634
1569
1570         Reviewed by Carlos Garcia Campos.
1571
1572         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1573         (testLoadFromGResource): Added test.
1574         (beforeAll):
1575         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1576         (registerGResource): Added.
1577         (webkit_web_extension_initialize_with_user_data): Load the test gresource.
1578         * TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html: Added.
1579         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Add an HTML file.
1580
1581 2015-12-31  David Kilzer  <ddkilzer@apple.com>
1582
1583         REGRESSION (r194470): Fix warnings uncovered by migrating to WTF_MOVE
1584         <https://bugs.webkit.org/show_bug.cgi?id=152601>
1585
1586         Ignore unknown pragmas on older clangs.  Fixes the following
1587         build failure:
1588
1589             Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp:184:34: error: unknown warning group '-Wself-move', ignored [-Werror,-Wunknown-pragmas]
1590             #pragma clang diagnostic ignored "-Wself-move"
1591                                              ^
1592             1 error generated.
1593
1594         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
1595         (TestWebKitAPI::TEST):
1596         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
1597         (TestWebKitAPI::TEST):
1598
1599 2015-12-31  Andy Estes  <aestes@apple.com>
1600
1601         Update the style checker to advise using WTFMove() instead of WTF::move()
1602         https://bugs.webkit.org/show_bug.cgi?id=152601
1603
1604         Reviewed by Daniel Bates.
1605
1606         * Scripts/webkitpy/style/checkers/cpp.py:
1607         (check_wtf_move):
1608         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1609         (WebKitStyleTest.test_wtf_move):
1610
1611 2015-12-31  Andy Estes  <aestes@apple.com>
1612
1613         Fix warnings uncovered by migrating to WTF_MOVE
1614         https://bugs.webkit.org/show_bug.cgi?id=152601
1615
1616         Reviewed by Daniel Bates.
1617
1618         Ignored -Wself-move warnings in these two API tests. It's useful to test that these classes properly handle
1619         self-move, even if doing so would trigger a warning.
1620
1621         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
1622         (TestWebKitAPI::TEST):
1623         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
1624         (TestWebKitAPI::TEST):
1625
1626 2015-12-31  Martin Robinson  <mrobinson@igalia.com>
1627
1628         [GTK] The install-dependencies script has a syntax error
1629         https://bugs.webkit.org/show_bug.cgi?id=152613
1630
1631         Reviewed by Michael Catanzaro.
1632
1633         * gtk/install-dependencies: Add the missing 'then.'
1634
1635 2015-12-30  Philippe Normand  <pnormand@igalia.com>
1636
1637         [Mac][GTK] Jhbuild support for OSX
1638         https://bugs.webkit.org/show_bug.cgi?id=150799
1639
1640         Reviewed by Michael Catanzaro.
1641
1642         * gtk/install-dependencies: Install dependencies on OSX with Homebrew.
1643         * gtk/jhbuild.modules: Moved platform-specific build settings in condition tags.
1644         * gtk/patches/foxbntconfig-fix-osx-cache.diff: Added.
1645         * gtk/jhbuildrc: GTK+ makeargs clean-up, the 3.0.12 hack is no longer needed.
1646
1647 2015-12-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1648
1649         Unreviewed, move Sebastian Dröge to committers list
1650
1651         He accidentally added himself to the reviewers list because the file is confusing.
1652
1653         * Scripts/webkitpy/common/config/contributors.json:
1654
1655 2015-12-24  Simon Fraser  <simon.fraser@apple.com>
1656
1657         Remove the unused #define _USE_MATH_DEFINES
1658         https://bugs.webkit.org/show_bug.cgi?id=152034
1659
1660         Reviewed by Tim Horton.
1661         
1662         Update this test to use piDouble from MathExtras.h, and
1663         std::numeric_limits<>.
1664
1665         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1666
1667 2015-12-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1668
1669         Python SCM should be able to retrieve untracked files - Generic changes
1670         https://bugs.webkit.org/show_bug.cgi?id=152536
1671
1672         Reviewed by Brent Fulgham.
1673
1674         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
1675         No support is yet added to GIT and SVN specific implementations.
1676
1677         * Scripts/webkitpy/common/checkout/scm/scm.py:
1678         (SCM.untracked_files):
1679         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1680         (SCMTest._shared_test_untracked_files):
1681
1682 2015-12-23  Dewei Zhu  <dewei_zhu@apple.com>
1683
1684         SVN checkout used by RunBenchmark should be non-interactive
1685         https://bugs.webkit.org/show_bug.cgi?id=152542
1686
1687         Reviewed by Ryosuke Niwa.
1688
1689         RunBenchmark should not require user interaction while running.
1690
1691         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
1692         (BenchmarkBuilder._checkout_with_subversion):
1693
1694 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
1695
1696         Web Inspector: add support for running protocol-test.js tests on Windows
1697         https://bugs.webkit.org/show_bug.cgi?id=148037
1698         <rdar://problem/22292237>
1699
1700         Reviewed by Simon Fraser.
1701
1702         * DumpRenderTree/win/TestRunnerWin.cpp:
1703         (TestRunner::inspectorTestStubURL): Provide implementation.
1704
1705 2015-12-23  Eric Carlson  <eric.carlson@apple.com>
1706
1707         [MediaStream] MediaDeviceInfo.label must be empty in some situations
1708         https://bugs.webkit.org/show_bug.cgi?id=152000
1709
1710         Reviewed by Brent Fulgham.
1711
1712         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1713         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1714         (WTR::InjectedBundle::setUserMediaPermission):
1715         (WTR::InjectedBundle::setUserMediaPermissionForOrigin): New.
1716         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1717
1718         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1719         (WTR::TestRunner::setUserMediaPermissionForOrigin): New.
1720         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1721
1722         * WebKitTestRunner/TestController.cpp:
1723         (WTR::TestController::setUserMediaPermissionForOrigin):
1724         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Add NULL check.
1725         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Don't add 
1726           persistent permission for origin, that can be done from script now.
1727         * WebKitTestRunner/TestController.h:
1728
1729         * WebKitTestRunner/TestInvocation.cpp:
1730         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Add support for
1731           SetUserMediaPermissionForOrigin.
1732
1733 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
1734
1735         [Win] Unreviewed build fix: Recognize Windows 10 variants.
1736
1737         * Scripts/webkitpy/common/system/platforminfo.py:
1738         (PlatformInfo._determine_win_version):
1739
1740 2015-12-23  Chris Aljoudi <chris@chrismatic.io> and Alex Christensen <achristensen@webkit.org>
1741
1742         Content blockers should be able to promote http to https
1743         https://bugs.webkit.org/show_bug.cgi?id=148966
1744
1745         Reviewed by Benjamin Poulain.
1746
1747         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1748         (WebCore::ContentExtensions::operator<<):
1749         (TestWebKitAPI::TEST_F):
1750
1751 2015-12-22  Hunseop Jeong  <hs85.jeong@samsung.com>
1752
1753         [EFL] MiniBrowser should be able to choose the offline-web-application-cache option
1754         https://bugs.webkit.org/show_bug.cgi?id=152516
1755
1756         Reviewed by Gyuyoung Kim.
1757
1758         * MiniBrowser/efl/main.c:
1759
1760 2015-12-22  Brent Fulgham  <bfulgham@apple.com>
1761
1762         Unreviewed: Add John Wilander as a contributor.
1763
1764         * Scripts/webkitpy/common/config/contributors.json:
1765
1766 2015-12-22  Chris Fleizach  <cfleizach@apple.com>
1767
1768         [WK2] Looping in testcase: fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
1769         https://bugs.webkit.org/show_bug.cgi?id=152482
1770
1771         Reviewed by Brent Fulgham.
1772
1773         vertical/horizontalScrollbar returns an accessibility element. That element can also be queried
1774         for the same property. On WK2, the element returned will not be valid, but is still present and
1775         that can lead to looping.
1776
1777         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1778         (AccessibilityUIElement::horizontalScrollbar):
1779         (AccessibilityUIElement::verticalScrollbar):
1780         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1781         (WTR::AccessibilityUIElement::horizontalScrollbar):
1782         (WTR::AccessibilityUIElement::verticalScrollbar):
1783
1784 2015-12-22  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1785
1786         Unreviewed.
1787
1788         * Scripts/webkitpy/common/config/contributors.json: Marking myself as reviewer.
1789
1790 2015-12-21  Hunseop Jeong  <hs85.jeong@samsung.com>
1791
1792         [EFL] test_ewk2_context failed after r192808
1793         https://bugs.webkit.org/show_bug.cgi?id=151846
1794
1795         Reviewed by Gyuyoung Kim.
1796
1797         Used the added ewk_context_web_process_count_limit_set api
1798         instead of the deprecated ewk_context_process_model_set.
1799
1800         * MiniBrowser/efl/main.c:
1801         (elm_main):
1802
1803 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
1804
1805         Unreviewed, move myself to reviewer list.
1806
1807         * Scripts/webkitpy/common/config/contributors.json:
1808
1809 2015-12-21  Aakash Jain  <aakash_jain@apple.com>
1810
1811         Unreviewed, add myself to the committers list.
1812
1813         * Scripts/webkitpy/common/config/contributors.json:
1814
1815 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
1816
1817         [GTK] jquery.min.js violates DFSG
1818         https://bugs.webkit.org/show_bug.cgi?id=152428
1819
1820         Reviewed by Joseph Pecoraro.
1821
1822         Stop distributing Source/WebInspectorUI/Tools. It is not needed in tarballs. This brings us
1823         into compliance with DFSG by removing a bundled, minified copy of jQuery from our tarball.
1824
1825         * gtk/manifest.txt.in:
1826
1827 2015-12-19  Dan Bernstein  <mitz@apple.com>
1828
1829         [Mac] WebKit contains dead source code for OS X Mavericks and earlier
1830         https://bugs.webkit.org/show_bug.cgi?id=152462
1831
1832         Reviewed by Alexey Proskuryakov.
1833
1834         - Removed definitions of MACOSX_DEPLOYMENT_TARGET and WEBKIT_SYSTEM_INTERFACE_LIBRARY for
1835           OS X 10.9:
1836
1837         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1838         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1839         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1840         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1841         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1842
1843         - Simplified expressions involving __MAC_OS_X_VERSION_MIN_REQUIRED and removed code that was
1844           never getting compiled:
1845
1846         * DumpRenderTree/mac/TextInputController.m:
1847         * MiniBrowser/mac/BrowserWindowController.m:
1848         * TestWebKitAPI/Tests/mac/AttributedString.mm:
1849         * WebKitTestRunner/mac/EventSenderProxy.mm:
1850
1851 2015-12-18  Michael Catanzaro  <mcatanzaro@igalia.com>
1852
1853         Unreviewed, add WebKitGTK+ Bugzilla email to committers list
1854
1855         This is to make it easy to CC it on Bugzilla.
1856
1857         * Scripts/webkitpy/common/config/contributors.json:
1858
1859 2015-12-18  Aakash Jain  <aakash_jain@apple.com>
1860
1861         Pasteboard get messed up after running kill-old-processes
1862         https://bugs.webkit.org/show_bug.cgi?id=152426
1863
1864         Reviewed by Alexey Proskuryakov.
1865
1866         * BuildSlaveSupport/kill-old-processes:
1867         (main): Do not kill pasteboard anymore.
1868
1869 2015-12-17  Aakash Jain  <aakash_jain@apple.com>
1870
1871         run-webkit-tests shouldn't start multiple iOS simulators while only running one test
1872         https://bugs.webkit.org/show_bug.cgi?id=152157
1873         <rdar://problem/23851817>
1874
1875         Reviewed by Alexey Proskuryakov.
1876
1877         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1878         (LayoutTestRunner.get_worker_count): Calculate required number of workers.
1879         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1880         (Manager._get_test_inputs): Common method to calculate test_inputs.
1881         (Manager._update_worker_count): Calculate and update required number of workers.
1882
1883 2015-12-16  Aakash Jain  <aakash_jain@apple.com>
1884
1885         run-webkit-tests fails to delete Simulator device during cleanup
1886         https://bugs.webkit.org/show_bug.cgi?id=152363
1887
1888         Reviewed by Alexey Proskuryakov.
1889
1890         * Scripts/webkitpy/xcode/simulator.py:
1891         (Simulator.delete_device): Ensure that device is Shutdown before deleting it.
1892
1893 2015-12-16  Tim Horton  <timothy_horton@apple.com>
1894
1895         [mac-wk2] fast/events force click tests crashing
1896         https://bugs.webkit.org/show_bug.cgi?id=152339
1897
1898         Reviewed by Beth Dakin.
1899
1900         * WebKitTestRunner/mac/EventSenderProxy.mm:
1901         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
1902         Set the NSEvent's _type member in addition to overriding -type,
1903         because there are assertions in touch event handling code that depend on it.
1904
1905 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1906
1907         Enforce temporarily bots to sync WebKit and WPT testharness.js
1908         https://bugs.webkit.org/show_bug.cgi?id=152334
1909
1910         Reviewed by Darin Adler.
1911
1912         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1913         (WebPlatformTestServer._copy_webkit_test_files): Temporarily overwrite wpt testharness.js with WebKit testharness.js.
1914
1915 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1916
1917         [Fetch API] Add fetch API compile time flag
1918         https://bugs.webkit.org/show_bug.cgi?id=152254
1919
1920         Reviewed by Darin Adler.
1921
1922         * Scripts/webkitperl/FeatureList.pm:
1923
1924 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1925
1926         Unreviewed.
1927
1928         Added files that have impact in building Streams API to the watchlist.
1929
1930         * Scripts/webkitpy/common/config/watchlist:
1931
1932 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1933
1934         Unreviewed.
1935
1936         Added imported tests to Streams API watchlist.
1937
1938         * Scripts/webkitpy/common/config/watchlist:
1939
1940 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1941
1942         Remove default copy of wpt testharness.js when launching wpt server
1943         https://bugs.webkit.org/show_bug.cgi?id=152298
1944
1945         Reviewed by Darin Adler.
1946
1947         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1948         (WebPlatformTestServer._copy_webkit_test_files): Deleted default copy of WebKit testharness.js to WPT.
1949
1950 2015-12-15  David Kilzer  <ddkilzer@apple.com>
1951
1952         REGRESSION (r192375): DumpRenderTree.app exits immediately with no error
1953         <http://webkit.org/b/152314>
1954
1955         Reviewed by Daniel Bates.
1956
1957         The change to DumpRenderTreeMain.mm in r192375 caused the iOS
1958         code path to exit immediately when calling main().
1959         Unfortunately, DumpRenderTreeMain.mm was used for both
1960         DumpRenderTree command-line binary and DumpRenderTree.app, which
1961         meant that the app would exit immediately with no error code
1962         when run!
1963
1964         The workaround is to introduce a separate source file called
1965         DumpRenderTreeAppMain.mm, similar to what WebKitTestRunner
1966         already does.
1967
1968         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add
1969         DumpRenderTreeAppMain.mm to the project.  Make it the only
1970         compiled source for the DumpRenderTree.app target.
1971         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm: Copied from Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm.
1972         (main): Call DumpRenderTreeMain() on iOS.  Assert on OS X in
1973         case someone tries mistakenly to use the app.
1974         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1975         Link to JavaScriptCore.framework on iOS for the assert.
1976         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1977         Link to JavaScriptCore.framework on OS X for the assert.  Remove
1978         unneeded EXCLUDED_SOURCE_FILE_NAMES setting.
1979         * DumpRenderTree/mac/DumpRenderTreeMain.mm:
1980         (main): Add assert for iOS so that a crash occurs if someone
1981         tries to run the wrong command.
1982
1983 2015-12-14  Tim Horton  <timothy_horton@apple.com>
1984
1985         Frequent crash under -[WKPDFView web_setMinimumSize:]_block_invoke
1986         https://bugs.webkit.org/show_bug.cgi?id=152266
1987         <rdar://problem/22092676>
1988
1989         Reviewed by Simon Fraser.
1990
1991         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1992         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Added.
1993         Add a test that crashed before this change, and doesn't crash after.
1994
1995 2015-12-14  Chris Fleizach  <cfleizach@apple.com>
1996
1997         AX: iOS: Text field variations do not have the correct traits
1998         https://bugs.webkit.org/show_bug.cgi?id=152237
1999
2000         Reviewed by Mario Sanchez Prada.
2001
2002         Add iOS calls for determing if an object is a search field or a text area.
2003
2004         * DumpRenderTree/AccessibilityUIElement.cpp:
2005         (getIsSearchFieldCallback):
2006         (getIsTextAreaCallback):
2007         (stringForSelectionCallback):
2008         (AccessibilityUIElement::getJSClass):
2009         * DumpRenderTree/AccessibilityUIElement.h:
2010         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2011         (AccessibilityUIElement::identifier):
2012         (AccessibilityUIElement::isTextArea):
2013         (AccessibilityUIElement::isSearchField):
2014         (AccessibilityUIElement::traits):
2015         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2016         (WTR::AccessibilityUIElement::scrollPageRight):
2017         (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
2018         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
2019         (WTR::AccessibilityUIElement::isSearchField):
2020         (WTR::AccessibilityUIElement::isTextArea):
2021         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2022         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2023         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2024         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
2025         (WTR::AccessibilityUIElement::isTextArea):
2026         (WTR::AccessibilityUIElement::isSearchField):
2027         (WTR::AccessibilityUIElement::rowCount):
2028
2029 2015-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2030
2031         [GTK] [JHBuild] package libtool-bin is now required on Debian systems.
2032         https://bugs.webkit.org/show_bug.cgi?id=152252
2033
2034         Reviewed by Sergio Villar Senin.
2035
2036         * gtk/install-dependencies: Add libtool-bin to the list of packages required
2037         for building the JHBuild on Debian systems.
2038
2039 2015-12-11  Joseph Pecoraro  <pecoraro@apple.com>
2040
2041         check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
2042         https://bugs.webkit.org/show_bug.cgi?id=152156
2043
2044         Reviewed by Dan Bernstein.
2045
2046         Our frameworks should appropriately prefix all ObjC classes,
2047         not just external symbols.
2048
2049         * Scripts/check-for-inappropriate-objc-class-names:
2050         Remove the -g switch to check all ObjC class names.
2051
2052 2015-12-10  Eric Carlson  <eric.carlson@apple.com>
2053
2054         [MediaStream] Expose media capture devices persistent permissions to WebCore
2055         https://bugs.webkit.org/show_bug.cgi?id=152087
2056
2057         Add support for the new user media permission checker page UI client method.
2058
2059         Reviewed by Chris Dumez.
2060
2061         * WebKitTestRunner/TestController.cpp:
2062         (WTR::decidePolicyForUserMediaPermissionRequest):
2063         (WTR::checkUserMediaPermissionForOrigin):
2064         (WTR::TestController::createOtherPage): Add checkUserMediaPermissionForOrigin.
2065         (WTR::TestController::createWebViewWithOptions): Ditto.
2066         (WTR::TestController::resetStateToConsistentValues): Clear m_userMediaOriginPermissions.
2067         (WTR::originUserVisibleName): New, create a string for the origin.
2068         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Set the WKUserMediaPermissionCheckRef
2069           according to the state of the origin permission map.
2070         (WTR::TestController::handleUserMediaPermissionRequest): Remember both the origin and the
2071           request so we can update the origin permission map in decidePolicyForUserMediaPermissionRequestIfPossible.
2072         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update the
2073           origin permission map.
2074         * WebKitTestRunner/TestController.h:
2075
2076 2015-12-10  Alex Christensen  <achristensen@webkit.org>
2077
2078         REGRESSION (r192796) WKBundlePageResourceLoadClient should be able to setHTTPBody in willSendRequestForFrame
2079         https://bugs.webkit.org/show_bug.cgi?id=152022
2080         rdar://problem/23763584
2081
2082         Reviewed by Darin Adler.
2083
2084         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2085         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2086         (WTR::InjectedBundlePage::willSendRequestForFrame):
2087         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2088         (WTR::TestRunner::setWillSendRequestReturnsNull):
2089         (WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
2090         (WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
2091         (WTR::TestRunner::setWillSendRequestAddsHTTPBody):
2092         (WTR::TestRunner::willSendRequestHTTPBody):
2093         Added setWillSendRequestAddsHTTPBody that uses new SPI for testing.
2094
2095 2015-12-10  Aakash Jain  <aakash_jain@apple.com>
2096
2097         Remove additional simulator checks before running layout-tests
2098         https://bugs.webkit.org/show_bug.cgi?id=152146
2099
2100         Reviewed by Darin Adler.
2101
2102         * Scripts/webkitpy/port/ios.py:
2103         (IOSSimulatorPort.check_sys_deps): Removed additional simulators verifications.
2104         * Scripts/webkitpy/xcode/simulator.py:
2105         (Simulator._boot_and_shutdown_simulator_device): Deleted.
2106         (Simulator.check_simulator_device_and_erase_if_needed): Deleted.
2107
2108 2015-12-09  Aakash Jain  <aakash_jain@apple.com>
2109
2110         Run atleast one simulator even if max process limit is low
2111         https://bugs.webkit.org/show_bug.cgi?id=152081
2112         <rdar://problem/23819694>
2113
2114         Reviewed by Alexey Proskuryakov.
2115
2116 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
2117
2118         [GTK] Crash in WebProcess when loading large content with custom URI schemes
2119         https://bugs.webkit.org/show_bug.cgi?id=144262
2120
2121         Reviewed by Carlos Garcia Campos.
2122
2123         Added new unit test to check the additional scenarios we now
2124         handle for custom URI schemes.
2125
2126         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2127         (generateHTMLContent): New helper function to generate big enough content.
2128         (testWebContextURIScheme): New unit test.
2129
2130 2015-12-09  Ryuan Choi  <ryuan.choi@navercorp.com>
2131
2132         [EFL] Fix unhandled web process message when launching MiniBrowser
2133         https://bugs.webkit.org/show_bug.cgi?id=152048
2134
2135         Reviewed by Gyuyoung Kim.
2136
2137         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
2138         (TestWebKitAPI::TEST):
2139
2140 2015-12-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2141
2142         [GTK] Add API to handle beforeunload events
2143         https://bugs.webkit.org/show_bug.cgi?id=139090
2144
2145         Reviewed by Gustavo Noronha Silva.
2146
2147         * MiniBrowser/gtk/BrowserWindow.c:
2148         (browserWindowConstructed):
2149         (browserWindowDeleteEvent):
2150         (browser_window_class_init):
2151         Handle delete-event to prevent the window from being closed when
2152         the page has beforeunload handlers. Use
2153         webkit_web_view_try_close() when the window is requested to be
2154         closed.
2155         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
2156         (testWebViewJavaScriptDialogs):
2157         Add a test case for the WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM
2158         script dialog type.
2159
2160 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
2161
2162         Refactored initialization code in LoadTrackingTest.
2163
2164         Rubber-stamped by Carlos Garcia Campos.
2165
2166         Small refactoring to make sure that the state of a LoadTrackingTest
2167         gets properly reset before loading new web content.
2168
2169         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
2170         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
2171         (LoadTrackingTest::reset): New, refactored code from *load*() and go*()
2172         functions and reset the remaining local variables.
2173         (LoadTrackingTest::loadURI): Call reset();
2174         (LoadTrackingTest::loadHtml): Ditto.
2175         (LoadTrackingTest::loadPlainText): Ditto.
2176         (LoadTrackingTest::loadBytes): Ditto.
2177         (LoadTrackingTest::loadRequest): Ditto.
2178         (LoadTrackingTest::reload): Ditto.
2179         (LoadTrackingTest::goBack): Ditto.
2180         (LoadTrackingTest::goForward): Ditto.
2181
2182 2015-12-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2183
2184         [EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
2185         https://bugs.webkit.org/show_bug.cgi?id=151942
2186
2187         Reviewed by Darin Adler.
2188
2189         * MiniBrowser/efl/main.c:
2190         (window_create): Enable offline web application cache feature on MiniBrowser.
2191         (elm_main):
2192
2193 2015-12-08  Aakash Jain  <aakash_jain@apple.com>
2194
2195         https://bugs.webkit.org/show_bug.cgi?id=151243
2196         <rdar://problem/22955197>
2197
2198         Reviewed by Alexey Proskuryakov.
2199
2200         * LayoutTestRelay/LayoutTestRelay/main.m:
2201         (getTestingSimDevice): Use separate testing device for each worker.
2202         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2203         (Manager.run): Perform cleanup even if setup fails.
2204         * Scripts/webkitpy/port/ios.py:
2205         (IOSSimulatorPort.default_child_processes): Calculate number of simulators to use.
2206         (IOSSimulatorPort.child_processes): Gets the number of simulators from options variable.
2207         (IOSSimulatorPort.setup_test_run): Handle mulitple simulators.
2208         (IOSSimulatorPort._quit_ios_simulator): Same
2209         (IOSSimulatorPort.clean_up_test_run): Same
2210         (IOSSimulatorPort.check_sys_deps): Same
2211         (IOSSimulatorPort.testing_device): Same
2212         (IOSSimulatorPort.reset_preferences): Same
2213         (IOSSimulatorPort.get_simulator_path): Return simulator path.
2214         (IOSSimulatorPort._createSimulatorApp): Create the copy of simulator app.
2215         * Scripts/webkitpy/xcode/simulator.py:
2216         (Device.delete): Delete the simulator device.
2217         (Simulator.delete_device): Same
2218         (Simulator.wait_until_device_is_booted): Wait for device booting.
2219
2220 2015-12-08  Ryuan Choi  <ryuan.choi@navercorp.com>
2221
2222         [EFL] Add API to provide preferences before creating ewk_view
2223         https://bugs.webkit.org/show_bug.cgi?id=151587
2224
2225         Reviewed by Gyuyoung Kim.
2226
2227         * MiniBrowser/efl/main.c:
2228         (on_key_down):
2229         (quit):
2230         (window_create):
2231         Moved settings related code to configuration() not to update settings
2232         whenever ewk_view is created.
2233         (configuration):
2234         (elm_main):
2235
2236 2015-12-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2237
2238         Unreviewed. Fix GTK+ API tests after r193639.
2239
2240         The new jhbuild version needs some more variables ot be present in
2241         the builtin dict, even if they are set to None.
2242
2243         * jhbuild/jhbuildutils.py:
2244         (enter_jhbuild_environment_if_available):
2245
2246 2015-12-07  Gustavo Noronha Silva  <gns@gnome.org>
2247
2248         [GTK] Notify WebCore when notification is clicked
2249         https://bugs.webkit.org/show_bug.cgi?id=151951
2250
2251         Reviewed by Carlos Garcia Campos.
2252
2253         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2254         (testWebViewNotification): test the new API.
2255
2256 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
2257
2258         'jhbuild build' should fail immediately when building any module fails
2259         https://bugs.webkit.org/show_bug.cgi?id=145697
2260
2261         Reviewed by Carlos Garcia Campos.
2262
2263         * efl/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
2264         * gtk/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
2265         Everything is placed under lib instead of lib64 now.
2266         * jhbuild/jhbuild-wrapper: Update jhbuild to the latest upstream commit, and pass
2267         --exit-on-error when running 'jhbuild build'.
2268         * jhbuild/jhbuildrc_common.py:
2269         (init): Don't override PKG_CONFIG_PATH, CMAKE_PREFIX_PATH, or CMAKE_LIBRARY_PATH. Modern
2270         jhbuild should be able to handle these for us without breaking things....
2271
2272 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2273
2274         Add support to import w3c tests from a repository with a different root that the main repo dir
2275         https://bugs.webkit.org/show_bug.cgi?id=151751
2276
2277         Reviewed by Ryosuke Niwa and Youenn Fablet.
2278
2279         We should be able to import tests from repositories that are not pure test repositories and where tests are kept
2280         in a different directory than the repository root.
2281
2282         This patch introduces a new parameter tests_directory that we will use as root directory to search for
2283         tests. All paths will be flattened when copying tests to have a less complicated directory structure. This
2284         requires having the copy_path lists including tuples of origin and destination directories.
2285
2286         * Scripts/webkitpy/w3c/test_downloader.py:
2287         (TestDownloader._add_test_suite_paths): Adds the paths as a tuple of origin and destination directory.
2288         (TestDownloader.copy_tests): Uses the origin and destination tuple for the paths to copy when copying files.
2289         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2290         (TestImporterTest.test_tests_directory): Test.
2291
2292 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2293
2294         Mock TestRepositories in W3C importer tests
2295         https://bugs.webkit.org/show_bug.cgi?id=151938
2296
2297         Reviewed by Youenn Fablet.
2298
2299         The test importer tests should use a fake repository instead of using the real one. The reason why this happened
2300         is because the test repository method reading the file was using the filesystem directly instead of taking the
2301         host one. This patch changes that.
2302
2303         * Scripts/webkitpy/w3c/test_downloader.py:
2304         (TestDownloader.load_test_repositories): Take a filesystem and use it. If we get no filesystem, we use the
2305         default one.
2306         (TestDownloader.__init__): When loading the repositories, pass the host filesystem.
2307         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2308         (TestImporterTest.test_harnesslinks_conversion):
2309         (TestImporterTest.test_submodules_generation): Use a fake test repository file.
2310
2311 2015-12-07  David Kilzer  <ddkilzer@apple.com>
2312
2313         TestNetscapePlugIn: Address review comment on 193607
2314         <http://webkit.org/b/151881>
2315
2316         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2317         (testSetStatus): Initializing std::unique_ptr<char[]> with
2318         nullptr is redundant.
2319
2320 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2321
2322         [GTK] Add webkit_uri_request_get_http_method
2323         https://bugs.webkit.org/show_bug.cgi?id=151601
2324
2325         Reviewed by Martin Robinson.
2326
2327         Add test case to check HTTP method of WebKitURIRequest.
2328
2329         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
2330         (testURIRequestHTTPMethod):
2331         (serverCallback):
2332         (beforeAll):
2333         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2334         (sendRequestCallback):
2335
2336 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2337
2338         [GTK] Add WebKitWebPage::console-message-sent signal to Web Extensions API
2339         https://bugs.webkit.org/show_bug.cgi?id=79918
2340
2341         Reviewed by Gustavo Noronha Silva.
2342
2343         Add unit tests to check the different console messages.
2344
2345         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2346         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp: Added.
2347         (ConsoleMessageTest::ConsoleMessage::operator==):
2348         (ConsoleMessageTest::consoleMessageReceivedCallback):
2349         (ConsoleMessageTest::ConsoleMessageTest):
2350         (ConsoleMessageTest::~ConsoleMessageTest):
2351         (ConsoleMessageTest::waitUntilConsoleMessageReceived):
2352         (testWebKitConsoleMessageConsoleAPI):
2353         (testWebKitConsoleMessageJavaScriptException):
2354         (testWebKitConsoleMessageNetworkError):
2355         (testWebKitConsoleMessageSecurityError):
2356         (beforeAll):
2357         (afterAll):
2358         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2359         (consoleMessageSentCallback):
2360         (pageCreatedCallback):
2361
2362 2015-12-07  Ryuan Choi  <ryuan.choi@navercorp.com>
2363
2364         [EFL] MiniBrowser doesn't exit when called ewk_view_try_close()
2365         https://bugs.webkit.org/show_bug.cgi?id=151934
2366
2367         Reviewed by Csaba Osztrogonác.
2368
2369         * MiniBrowser/efl/main.c:
2370         (on_window_deletion): Revert the changes of r192767.
2371
2372 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
2373
2374         [GTK] update-webkitgtk-libs cannot build mesa
2375         https://bugs.webkit.org/show_bug.cgi?id=151535
2376
2377         Reviewed by Martin Robinson.
2378
2379         Upgrade to newer mesa in order to build successfully against LLVM 3.7. Add missing
2380         dependency of mesa on LLVM, to ensure LLVM is built first. Build LLVM unconditionally, even
2381         on architectures where FTL is not supported, to ensure mesa is always buildable, since LLVM
2382         does not have a stable API and we cannot expect mesa to be buildable unless we control the
2383         LLVM version. Build mesa with --disable-egl since --enable-egl conflicts with
2384         --enable-xlib-glx. This fixes update-webkitgtk-libs on distros with LLVM 3.7.
2385
2386         * gtk/jhbuild.modules:
2387
2388 2015-12-07  Philippe Normand  <pnormand@igalia.com>
2389
2390         [GTK][Mac] libWebExtensionTest link error
2391         https://bugs.webkit.org/show_bug.cgi?id=150802
2392
2393         Reviewed by Carlos Garcia Campos.
2394
2395         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: add dependencies to the webextension library.
2396
2397 2015-12-06  David Kilzer  <ddkilzer@apple.com>
2398
2399         TestNetscapePlugIn: Fix leaks found by static analyzer
2400         <http://webkit.org/b/151881>
2401
2402         Reviewed by Darin Adler.
2403
2404         Fixes the following leaks found by the static analyzer:
2405             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'path'
2406                     return false;
2407                            ^~~~~
2408             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'target'
2409                     return false;
2410                            ^~~~~
2411             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'url'
2412                     return false;
2413                            ^~~~~
2414
2415         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2416         (toCString): Switch to returning std::unique_ptr<char[]>.  Add
2417         early return if allocation fails.
2418         (testPostURLFile): Switch to using std::unique_ptr<char[]>.
2419         Make sure to call fclose() on filehandle, even for an early
2420         return.
2421         (testSetStatus): Switch to using std::unique_ptr<char[]>.
2422
2423 2015-12-05  David Kilzer  <ddkilzer@apple.com>
2424
2425         prepare-ChangeLog: Fix some warning messages when using svn
2426         <http://webkit.org/b/151914>
2427
2428         Reviewed by Daniel Bates.
2429
2430         * Scripts/prepare-ChangeLog:
2431         (generateFunctionLists): Simplify logic so that we never call
2432         normalizePath() with an undefined value.
2433         (attributeCommand): Quote $subPath for the shell so that we
2434         don't try to run "svn propget" on invalid paths.
2435
2436 2015-12-04  David Kilzer  <ddkilzer@apple.com>
2437
2438         TestNetscapePlugIn: Fix remaining static analyzer warnings
2439         <http://webkit.org/b/151888>
2440
2441         Reviewed by Alexey Proskuryakov.
2442
2443         Fixes the following static analyzer warnings:
2444             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:101:9: warning: Called function pointer is null (null dereference)
2445                     CRASH();
2446                     ^~~~~~~
2447             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:46:5: note: expanded from macro 'CRASH'
2448                 ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ \
2449                 ^~~~~~~~~~~~~~~~
2450             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:375:12: warning: Access to field 'pluginTest' results in a dereference of a null pointer (loaded from variable 'obj')
2451                 return obj->pluginTest->NPP_SetWindow(window);
2452                        ^~~~~~~~~~~~~~~
2453             2 warnings generated.
2454
2455         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2456         (CRASH): Use __builtin_trap() for gcc/clang.
2457         (NPP_SetWindow): Add early return if obj is nullptr.
2458
2459 2015-12-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2460
2461         [GTK] Test /webkit2/WebKitWebResource/get-data is flaky
2462         https://bugs.webkit.org/show_bug.cgi?id=151797
2463
2464         Reviewed by Martin Robinson.
2465
2466         Since we switched to use the network process to run the unit tests
2467         the test /webkit2/WebKitWebResource/get-data sometimes fails and
2468         sometimes passes. We are now also getting the notification for the
2469         css image. Since we wait for 3 resources, sometimes the css image
2470         is loaded before and then checkResourceData is called for it, but
2471         not handled. When the css image is the last one loaded the test
2472         passes. So, we just need to wait for the 4 resources.
2473
2474         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2475         (testWebResourceGetData):
2476
2477 2015-12-03  David Kilzer  <ddkilzer@apple.com>
2478
2479         DumpRenderTree: Use-after-free in createBitmapContext() in PixelDumpSupportMac.mm
2480         <http://webkit.org/b/151845>
2481
2482         Reviewed by Simon Fraser.
2483
2484         Fixes the following static analyzer warning:
2485             DumpRenderTree/mac/PixelDumpSupportMac.mm:67:9: warning: Use of memory after it is freed
2486                     WTFLogAlways("DumpRenderTree: CGBitmapContextCreate(%p, %llu, %llu, 8, %llu, %p, 0x%x) failed\n", buffer, pixelsHigh, pixelsWide, rowBytes, colorSpace.get(), kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host);
2487                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2488
2489         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2490         (createBitmapContext): Free 'buffer' after using it in logging
2491         to fix the use-after-free.  Assign a value of nullptr to buffer
2492         so we don't return with it set to a freed address.
2493
2494 2015-12-03  Jer Noble  <jer.noble@apple.com>
2495
2496         Expose WebCore's InvisibleAutoplayNotPermitted setting to WebKit & WebKit2
2497         https://bugs.webkit.org/show_bug.cgi?id=151830
2498
2499         Reviewed by Anders Carlsson.
2500
2501         Set invisibleAutoplayNotPermitted to NO by default both in WKTR and DRT.
2502
2503         * DumpRenderTree/mac/DumpRenderTree.mm:
2504         (resetWebPreferencesToConsistentValues):
2505         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2506         (WTR::initializeWebViewConfiguration):
2507
2508 2015-12-03  Anders Carlsson  <andersca@apple.com>
2509
2510         Remove Objective-C GC support
2511         https://bugs.webkit.org/show_bug.cgi?id=151819
2512         rdar://problem/23746991
2513
2514         Reviewed by Dan Bernstein.
2515
2516         * asan/asan.xcconfig:
2517
2518 2015-12-02  Yusuke Suzuki  <utatane.tea@gmail.com>
2519
2520         Allow nil for unspecified benchmark pathes
2521         https://bugs.webkit.org/show_bug.cgi?id=151784
2522
2523         Reviewed by Filip Pizlo.
2524
2525         `Pathname.new(nil)` will raise an error.
2526         Only generate Pathname if the benchmark path is specified.
2527
2528         * Scripts/run-jsc-benchmarks:
2529
2530 2015-12-02  Brent Fulgham  <bfulgham@apple.com>
2531
2532         [Win] Run non-http tests without Cygwin
2533         https://bugs.webkit.org/show_bug.cgi?id=151721
2534
2535         Reviewed by Andy Estes.
2536
2537         Support native 32-bit and 64-bit Python (and Perl) builds
2538         for running tests:
2539
2540         1. Use "startswith('win')", rather than "== 'win32'" to support
2541         various Windows build types.
2542         2. Supply full path for some native Windows utilities, since the
2543         path environment does not always have the specified, and they are
2544         guaranteed to exist in those specific locations.
2545         3. Make sure native Windows Python test runs pass proper environment
2546         variables to run programs.
2547         4. Append 'exe' suffix when running Windows executables.
2548         5. Use the _winreg Python module on Windows, since the Cygwin 'regtool'
2549         command doesn't exist.
2550         
2551         * Scripts/update-webkit: Use Perl $^X command to refer to the path of
2552         the current Perl executable, rather than requiring a new path search.
2553         * Scripts/webkitpy/common/find_files_unittest.py:
2554         (TestWinNormalize.test_win): Use startswith('win').
2555         * Scripts/webkitpy/common/prettypatch_unittest.py:
2556         (test_pretty_diff_encodings): Ditto.
2557         * Scripts/webkitpy/common/system/executive.py:
2558         (Executive._should_close_fds): Ditto.
2559         (Executive.shell_command_for_script): Use startswith('win').
2560         (Executive.kill_process): Use full path to killall executable.
2561         (Executive.check_running_pid): Use startswith('win').
2562         (Executive.running_pids): Ditto.
2563         (Executive.kill_all): Ditto. Also use path to 'killall' executable when
2564         running under native Windows Python.
2565         (Executive._child_process_encoding): Use startswith('win').
2566         (Executive._should_encode_child_process_arguments): Ditto.
2567         (Executive.popen): Recognize proper script engine on Windows, since it
2568         does not support the shebang syntax.
2569         (Executive.run_in_parallel): Use startswith('win').
2570         * Scripts/webkitpy/common/system/executive_unittest.py:
2571         (never_ending_command): Ditto.
2572         (ExecutiveTest.test_run_command_with_unicode): Ditto.
2573         (ExecutiveTest.serial_test_kill_process): Ditto.
2574         (ExecutiveTest.serial_test_kill_all): Ditto.
2575         (ExecutiveTest.serial_test_check_running_pid): Ditto.
2576         (ExecutiveTest.serial_test_run_in_parallel): Ditto.
2577         (main): Ditto.
2578         * Scripts/webkitpy/common/system/file_lock.py:
2579         (FileLock._create_lock): Ditto.
2580         (FileLock._remove_lock): Ditto.
2581         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2582         (RealFileSystemTest.test_chdir): Ditto.
2583         (RealFileSystemTest.test_chdir__notexists): Ditto.
2584         (RealFileSystemTest.test_maybe_make_directory__failure): Ditto.
2585         * Scripts/webkitpy/common/system/path_unittest.py:
2586         (AbspathTest.test_abspath_to_uri_win): Ditto.
2587         * Scripts/webkitpy/common/system/platforminfo.py:
2588         (PlatformInfo._determine_os_name): Ditto.
2589         * Scripts/webkitpy/common/system/user.py: Ditto.
2590         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2591         (ManagerTest.integration_test_needs_servers): Ditto.
2592         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2593         (LayoutTestApacheHttpd.__init__): Handle upper and lower-case
2594         driver letters.
2595         (LayoutTestApacheHttpd._get_apache_config_file_path): Ditto.
2596         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
2597         (TestLayoutTestApacheHttpd.test_start_cmd): Ditto.
2598         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2599         (HttpServerBase._check_that_all_ports_are_available): Ditto.
2600         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2601         (TestHttpServer.test_start_cmd): Ditto.
2602         * Scripts/webkitpy/port/base.py:
2603         (Port.to.setup_environ_for_server): Include 'COMSPEC', 'SYSTEMDRIVE',
2604         and 'SYSTEMROOT' in environment passed to test runners.
2605         (Port._apache_config_file_name_for_platform): Use startswith('win').
2606         (Port._build_path): Ditto.
2607         (Port._path_to_driver): Include 'exe' suffix when running under native
2608         Windows.
2609         * Scripts/webkitpy/port/driver.py:
2610         (Driver._setup_environ_for_driver): Explicitly make some environment
2611         variables strings.
2612         * Scripts/webkitpy/port/server_process.py:
2613         (ServerProcess.__init__): Use startswith('win').
2614         * Scripts/webkitpy/port/win.py:
2615         (WinPort): Use the win32 registry utilities on Windows, and appropriate
2616         registry key formats.
2617         (WinPort._ntsd_location): Revise tool search paths for Windows 10.
2618         (WinPort.read_registry_value): Revise to use _winreg library on Windows,
2619         and regtool on Cygwin.
2620         (WinPort.write_registry_value): Ditto.
2621         (WinPort.setup_crash_log_saving): Ditto.
2622         (WinPort.restore_crash_log_saving): Ditto.
2623         (WinPort.prevent_error_dialogs): Ditto.
2624         (WinPort.allow_error_dialogs): Ditto.
2625         (WinPort.find_system_pid): Revise to use Windows management
2626         infrastructure on native Windows, continue using 'ps' on Cygwin.
2627         (WinPort.read_registry_string): Deleted.
2628         (WinPort.write_registry_string): Deleted.
2629         * Scripts/webkitpy/test/main.py:
2630         (main): Use startswith('win').
2631         (Tester._parse_args): Ditto.
2632
2633 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
2634
2635         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
2636         https://bugs.webkit.org/show_bug.cgi?id=150792
2637
2638         Reviewed by Saam Barati.
2639
2640         * Scripts/webkitperl/FeatureList.pm:
2641
2642 2015-12-01  Commit Queue  <commit-queue@webkit.org>
2643
2644         Unreviewed, rolling out r192914.
2645         https://bugs.webkit.org/show_bug.cgi?id=151734
2646
2647         JSC tests for this change are failing on 32 and 64-bit bots
2648         (Requested by ryanhaddad on #webkit).
2649
2650         Reverted changeset:
2651
2652         "[ES6] Implement LLInt/Baseline Support for ES6 Generators and
2653         enable this feature"
2654         https://bugs.webkit.org/show_bug.cgi?id=150792
2655         http://trac.webkit.org/changeset/192914
2656
2657 2015-12-01  David Kilzer  <ddkilzer@apple.com>
2658
2659         EventSenderProxy::swipeGestureWithWheelAndMomentumPhases() leaks an EventSenderSyntheticEvent
2660         <http://webkit.org/b/151726>
2661
2662         Reviewed by Simon Fraser.
2663
2664         * WebKitTestRunner/mac/EventSenderProxy.mm:
2665         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
2666         Deploy RetainPtr<EventSenderSyntheticEvent> to fix leak.
2667
2668 2015-12-01  Myles C. Maxfield  <mmaxfield@apple.com>
2669
2670         Give String and AtomicString an existingHash() function
2671         https://bugs.webkit.org/show_bug.cgi?id=151717
2672
2673         Reviewed by Andreas Kling.
2674
2675         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
2676         (TestWebKitAPI::TEST):
2677         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2678         (TestWebKitAPI::TEST):
2679
2680 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
2681
2682         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
2683         https://bugs.webkit.org/show_bug.cgi?id=150792
2684
2685         Reviewed by Saam Barati.
2686
2687         * Scripts/webkitperl/FeatureList.pm:
2688
2689 2015-12-01  Sam Weinig  <sam@webkit.org>
2690
2691         Need completionHandler-based WebKit C SPI for alert, confirm, and prompt
2692         <rdar://problem/23320863>
2693         https://bugs.webkit.org/show_bug.cgi?id=151708
2694
2695         Reviewed by Anders Carlsson.
2696
2697         * WebKitTestRunner/TestController.cpp:
2698         (WTR::TestController::createOtherPage):
2699         (WTR::TestController::createWebViewWithOptions):
2700         Update for new WKPageUIClient.
2701
2702 2015-12-01  Anders Carlsson  <andersca@apple.com>
2703
2704         Remove WebKit2.framework
2705         https://bugs.webkit.org/show_bug.cgi?id=151715
2706
2707         Reviewed by Dan Bernstein.
2708
2709         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
2710         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
2711         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
2712         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2713         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
2714         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
2715         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
2716
2717 2015-12-01  Joseph Pecoraro  <pecoraro@apple.com>
2718
2719         Unreviewed common typo fix "occurance" => "occurrence".
2720
2721         * Scripts/webkitpy/tool/commands/queries.py:
2722         (FindFlakyTests._print_statistics):
2723
2724 2015-11-30  Alex Christensen  <achristensen@webkit.org>
2725
2726         Make ProcessModel always MultipleSecondaryProcesses
2727         https://bugs.webkit.org/show_bug.cgi?id=151662
2728
2729         Reviewed by Antti Koivisto.
2730
2731         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2732         (TestWebKitAPI::TEST):
2733         * WebKitTestRunner/TestController.cpp:
2734         (WTR::TestController::generatePageConfiguration):
2735
2736 2015-11-30  Alex Christensen  <achristensen@webkit.org>
2737
2738         Make usesNetworkProcess always true
2739         https://bugs.webkit.org/show_bug.cgi?id=151580
2740
2741         Reviewed by Darin Adler.
2742
2743         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2744         (TestWebKitAPI::TEST):
2745         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
2746         (TestWebKitAPI::TEST):
2747         * WebKitTestRunner/TestController.cpp:
2748         (WTR::TestController::generatePageConfiguration):
2749
2750 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2751
2752         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/editable/editable in Debug.
2753
2754         Add a way to skip unit tests only for Debug or Release builds and
2755         skipt the test /webkit2/WebKitWebView/editable/editable only for Debug.
2756
2757         * Scripts/run-gtk-tests:
2758         (SkippedTest):
2759         (SkippedTest.__init__):
2760         (SkippedTest.__str__):
2761         (SkippedTest.skip_entire_suite):
2762         (SkippedTest.skip_for_build_type):
2763         (TestRunner):
2764         (TestRunner.__init__):
2765
2766 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2767
2768         Unreviewed. Fix a crash in GTK+ test /webkit2/WebKitWebView/custom-charset.
2769
2770         It's an assert hit because we are reloading a view loaded with
2771         HTML data which is not supported. Use loadURI instead.
2772
2773         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2774         (testWebViewCustomCharset):
2775
2776 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2777
2778         [GLIB] Remove GMainLoopSource and GThreadSafeMainLoopSource
2779         https://bugs.webkit.org/show_bug.cgi?id=151633
2780
2781         Reviewed by Csaba Osztrogonác.
2782
2783         * TestWebKitAPI/PlatformGTK.cmake:
2784         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Removed.
2785
2786 2015-11-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2787
2788         [GTK] Remove the remaining uses of GMainLoopSource
2789         https://bugs.webkit.org/show_bug.cgi?id=151632
2790
2791         Reviewed by Žan Doberšek.
2792
2793         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2794         (testWebViewSyncRequestOnMaxConns):
2795         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2796         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2797         (WTR::TestRunner::TestRunner):
2798         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2799         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2800         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
2801         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2802         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2803         (WTR::timeoutSource):
2804         (WTR::TestController::notifyDone):
2805         (WTR::TestController::platformRunUntil):
2806
2807 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
2808
2809         [cmake] Add testb3 to the build system
2810         https://bugs.webkit.org/show_bug.cgi?id=151619
2811
2812         Reviewed by Gyuyoung Kim.
2813
2814         * Scripts/build-jsc:
2815
2816 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
2817
2818         [jhbuild] Fix pixman build with clang
2819         https://bugs.webkit.org/show_bug.cgi?id=151441
2820
2821         Reviewed by Carlos Garcia Campos.
2822
2823         * efl/jhbuild.modules:
2824         * gtk/jhbuild.modules:
2825
2826 2015-11-26  David Kilzer  <ddkilzer@apple.com>
2827
2828         Extract prependToEnvironmentVariableList
2829         <http://webkit.org/b/151536>
2830
2831         Reviewed by Daniel Bates.
2832
2833         Tests: webkitdirs_unittest/appendToEnvironmentVariableList.pl
2834                webkitdirs_unittest/prependToEnvironmentVariableList.pl
2835
2836         * Scripts/webkitdirs.pm: Export appendToEnvironmentVariableList
2837         and prependToEnvironmentVariableList.
2838         (appendToEnvironmentVariableList): Simplify variable name.
2839         Switch to use $Config{path_sep}.
2840         (prependToEnvironmentVariableList): Add new method.
2841         (setupMacWebKitEnvironment): Switch to use
2842         prependToEnvironmentVariableList().
2843         (setupIOSWebKitEnvironment): Ditto.
2844
2845         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl: Added.
2846         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl: Added.
2847
2848 2015-11-24  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2849
2850         REGRESSION(r192053): MiniBrowser doesn't exit when clicking on the close-window button
2851         https://bugs.webkit.org/show_bug.cgi?id=151567
2852
2853         Reviewed by Darin Adler.
2854
2855         * MiniBrowser/efl/main.c: Call window_close() instead of ewk_view_try_close().
2856         (on_window_deletion):
2857
2858 2015-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2859
2860         [GTK] Use the network process unconditionally
2861         https://bugs.webkit.org/show_bug.cgi?id=151541
2862
2863         Reviewed by Alex Christensen.
2864
2865         Fix TestInspectorServer test. Do not assume we already have the
2866         title we want when the page has been loaded, since the title is
2867         changed afterwards. So, check if the title has already been set,
2868         and if not wait for it.
2869
2870         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
2871         (openRemoteDebuggingSession):
2872
2873 2015-11-23  Alex Christensen  <achristensen@webkit.org>
2874
2875         Fix crash in ~WebProcessPool when using Geolocation with useNetworkProcess=true
2876         https://bugs.webkit.org/show_bug.cgi?id=151532
2877
2878         Reviewed by Benjamin Poulain.
2879
2880         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2881         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
2882         (TestWebKitAPI::TEST):
2883         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
2884         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker): Deleted.
2885         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker): Deleted.
2886         Properly load about:blank in all WebViews to clean up.  Without this change, we had a 
2887         Geolocation provider stopping after its state tracker was destroyed with its stack frame,
2888         so it was calling a function on a test object that had gone out of scope.
2889         Also, call WKContextSetUsesNetworkProcess(context, true) to show what crash this fixed,
2890         but that will become the default soon and that call will be removed.
2891
2892 2015-11-22  David Kilzer  <ddkilzer@apple.com>
2893
2894         run-webkit-tests: http server for imported W3C tests doesn't work with --layout-tests-directory switch
2895         <http://webkit.org/b/151542>
2896
2897         Reviewed by Daniel Bates.
2898
2899         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2900         (base_url): Use the Port object (already passed in) to give us
2901         the path to the LayoutTests directory, which already checks for a
2902         --layout-tests-directory command-line switch.
2903         (WebPlatformTestServer.__init__): Remove layout_test_results_dir
2904         argument since we can get this from the Port object already
2905         passed in via Port.results_directory().  Also switch to use
2906         Port.layout_tests_dir() to get the LayoutTests directory.
2907
2908         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
2909         (TestWebPlatformTestServer.test_custom_layout_tests_directory):
2910         Add test case for custom LayoutTests directory.
2911         (TestWebPlatformTestServer.test_previously_spawned_instance):
2912         Update Port object to set mock results directory as if it was
2913         set on the command-line.  Remove unneeded argument from
2914         WebPlatformTestServer constructor.
2915         (TestWebPlatformTestServer.test_corrupted_subserver_files): Ditto.
2916
2917         * Scripts/webkitpy/port/base.py:
2918         (Port.to.start_web_platform_test_server): Remove unneeded
2919         argument from WebPlatformTestServer constuctor.
2920
2921 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2922
2923         [GTK] Some unit tests fail when using the network process
2924         https://bugs.webkit.org/show_bug.cgi?id=151490
2925
2926         Reviewed by Martin Robinson.
2927
2928         Run the soup server in a separate thread in TestResources test to
2929         avoid deadlocks.
2930
2931         This fixes /webkit2/WebKitWebView/sync-request-on-max-conns and
2932         /webkit2/WebKitWebResource/get-data when using the network process.
2933
2934         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2935         (beforeAll): Create the WebKitTestServer with ServerRunInThread flag.
2936         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
2937         (WebKitTestServer::WebKitTestServer): When ServerRunInThread is
2938         present, create a WorkQueue to run the server.
2939         (WebKitTestServer::run): Run the server in the work queue if it
2940         has been created.
2941         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h: Convert server
2942         type into server options as flags.
2943
2944 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2945
2946         [GTK] ImageDiff should normalize the diff image
2947         https://bugs.webkit.org/show_bug.cgi?id=151261
2948
2949         Reviewed by Sergio Villar Senin.
2950
2951         * ImageDiff/gtk/ImageDiff.cpp:
2952         (readPixbufFromStdin): Fix memory leak.
2953         (differenceImageFromDifferenceBuffer): Normalize diff buffer.
2954         (calculateDifference): Pass max distance to differenceImageFromDifferenceBuffer.
2955
2956 == Rolled over to ChangeLog-2015-11-21 ==