20% regression on dom_perf/DomDivWalk
[WebKit-https.git] / Tools / ChangeLog
1 2013-01-22  Timothy Loh  <timloh@chromium.com>
2
3         prepare-Changelog should support updating the list of changed files
4         https://bugs.webkit.org/show_bug.cgi?id=74358
5
6         Reviewed by Eric Seidel.
7
8         Needing to re-make ChangeLog entries when the list of files/functions
9         changes is a bit annoying, it'd be nice to have this more automated.
10         This patch makes `webkit-patch update' update the date line and bug
11         description if needed, and if the list of changed files/functions has
12         changed, either updates the list (if there are no annotations), or
13         otherwise appends the new list below.
14
15         * Scripts/webkitpy/tool/steps/preparechangelog.py:
16         (PrepareChangeLog._resolve_existing_entry):
17         (PrepareChangeLog):
18         (PrepareChangeLog._merge_entries):
19         (PrepareChangeLog.run):
20         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
21         (PrepareChangeLogTest.test_resolve_existing_entry):
22         (make_entry):
23         (test_ensure_bug_url):
24
25 2013-01-22  Tim 'mithro' Ansell  <mithro@mithis.com>
26
27         Use Python 2.7 unittest syntax in our unittests
28         https://bugs.webkit.org/show_bug.cgi?id=105607
29
30         Reviewed by Eric Seidel.
31
32         * Scripts/webkitpy/**/*_unittest.py:
33
34 2013-01-22  Tim 'mithro' Ansell  <mithro@mithis.com>
35
36         Convert disable-msg to disable for new pylint.
37         https://bugs.webkit.org/show_bug.cgi?id=107627
38
39         Reviewed by Eric Seidel.
40
41         * Scripts/webkitpy/common/checkout/scm/svn.py:
42         (SVNRepository.has_authorization_for_realm):
43         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
44         (Builder.force_build):
45         * Scripts/webkitpy/common/system/executive_mock.py:
46         (MockExecutive2.run_command):
47         * Scripts/webkitpy/layout_tests/port/base.py:
48         (Port.reference_files):
49         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
50         (ChromiumPortTestCase.test_default_configuration):
51         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
52         (PortTestCase.test_expectations_ordering):
53         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
54         (HttpServerBase._check_that_all_ports_are_available):
55         * Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
56         (AbstractLocalServerCommand.execute):
57         * Scripts/webkitpy/tool/commands/download.py:
58         (AbstractPatchProcessingCommand):
59         * Scripts/webkitpy/tool/commands/rebaseline.py:
60         (AbstractRebaseliningCommand):
61         (AbstractParallelRebaselineCommand):
62         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
63         (_BaseTestCase.setUp):
64         (TestAnalyzeBaselines.setUp):
65
66 2013-01-22  Frank Farzan  <frankf@chromium.org>
67
68         Flakiness dashboard: update builders.jsonp
69         https://bugs.webkit.org/show_bug.cgi?id=107610
70
71         Reviewed by Ojan Vafai.
72
73         * TestResultServer/static-dashboards/builders.jsonp:
74
75 2013-01-22  Frank Farzan  <frankf@chromium.org>
76
77         Add Android instrumentation tests from ChromiumLinux waterfall
78         https://bugs.webkit.org/show_bug.cgi?id=107597
79
80         Reviewed by Ojan Vafai.
81
82         * TestResultServer/static-dashboards/builders.js:
83         (loadBuildersList):
84
85 2013-01-21  Kentaro Hara  <haraken@chromium.org>
86
87         Implement UIEvent constructor
88         https://bugs.webkit.org/show_bug.cgi?id=107430
89
90         Reviewed by Adam Barth.
91
92         Editor's draft: https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm
93
94         UIEvent constructor is implemented under a DOM4_EVENTS_CONSTRUCTOR flag,
95         which is enabled on Safari and Chromium for now.
96
97         * Scripts/webkitperl/FeatureList.pm:
98
99 2013-01-22  Timothy Loh  <timloh@chromium.com>
100
101         Add functions to ChangeLog - parse bug desc/changed functions, delete/prepend entries
102         https://bugs.webkit.org/show_bug.cgi?id=107478
103
104         Reviewed by Eric Seidel.
105
106         On the road to resolving Bug 74358, we need a few more functions in
107         changelog.py.
108         To make things easier to mock, change @staticmethods to @classmethods.
109
110         * Scripts/webkitpy/common/checkout/changelog.py:
111         (ChangeLogEntry):
112         (ChangeLogEntry._parse_reviewer_text):
113         (ChangeLogEntry._split_contributor_names):
114         (ChangeLogEntry._parse_author_name_and_email):
115         (ChangeLogEntry._parse_author_text):
116         (ChangeLogEntry._parse_touched_functions):
117         (ChangeLogEntry._parse_bug_description):
118         (ChangeLogEntry._parse_entry):
119         (ChangeLogEntry.date_line):
120         (ChangeLogEntry.bug_description):
121         (ChangeLogEntry.touched_functions):
122         (ChangeLogEntry.touched_files_text):
123         (ChangeLogEntry.is_touched_files_text_clean):
124         (ChangeLog):
125         (ChangeLog.parse_latest_entry_from_file):
126         (ChangeLog._separate_revision_and_line):
127         (ChangeLog.parse_entries_from_file):
128         (ChangeLog.set_short_description_and_bug_url):
129         (ChangeLog.delete_entries):
130         (ChangeLog.prepend_text):
131         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
132         (test_parse_log_entries_from_changelog):
133         (test_latest_entry_parse):
134         (test_set_short_description_and_bug_url):
135         (test_delete_entries):
136         (test_prepend_text):
137
138 2013-01-22  Lucas Forschler  <lforschler@apple.com>
139
140         Create a MAC EWS startup shell script.
141
142         Reviewed by Ryosuke Niwa.
143
144         * EWSTools/start-queue-mac.sh: Added.
145
146 2013-01-22  Joseph Pecoraro  <pecoraro@apple.com>
147
148         [Mac] Enable Page Visibility (PAGE_VISIBILITY_API)
149         https://bugs.webkit.org/show_bug.cgi?id=107230
150
151         Reviewed by David Kilzer.
152
153         * DumpRenderTree/mac/TestRunnerMac.mm:
154         (TestRunner::resetPageVisibility):
155         Fix a typo in the original implementation. resetPageVisibility should
156         pass initialState YES so an event is not dispatched, which causes
157         issues in multiple tests. This now matches other ports.
158
159 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
160
161         [GTK] Enable CSS Image Orientation feature
162         https://bugs.webkit.org/show_bug.cgi?id=99040
163
164         Reviewed by Martin Robinson.
165
166         Enable the CSS Image Orientation feature in the development
167         builds of the GTK port. The feature is still disabled in the release
168         builds.
169
170         * Scripts/webkitperl/FeatureList.pm:
171
172 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
173
174         [GTK] Enable the <template> element support in development builds
175         https://bugs.webkit.org/show_bug.cgi?id=106575
176
177         Reviewed by Martin Robinson.
178
179         Enable the <template> element support in the development builds of the GTK port.
180
181         * Scripts/webkitperl/FeatureList.pm:
182
183 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
184
185         Prettify the output of the override-feature-defines script
186         https://bugs.webkit.org/show_bug.cgi?id=106542
187
188         Reviewed by Martin Robinson.
189
190         The output now clearly lists the feature defines being overridden
191         along with the default and overriding values for each feature define.
192
193         * gtk/override-feature-defines:
194         (adjust_feature_defines_makefile):
195         (adjust_feature_defines_makefile.override_feature_define):
196
197 2013-01-22  Zan Dobersek  <zdobersek@igalia.com>
198
199         Remove uses of deprecated unittest.TestCase aliases
200         https://bugs.webkit.org/show_bug.cgi?id=102252
201
202         Reviewed by Adam Barth.
203
204         Replace the deprecated assertEquals method of the TestCase interface
205         used in some webkitpy unittests with the assertEqual method.
206
207         * Scripts/webkitpy/common/system/profiler_unittest.py:
208         (ProfilerFactoryTest._assert_default_profiler_name):
209         (ProfilerFactoryTest.test_default_profiler_output):
210         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
211         (GtkPortTest.test_expectations_files):
212         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
213         (TestHttpServer.test_win32_start_and_stop):
214
215 2013-01-22  Jer Noble  <jer.noble@apple.com>
216
217         REGRESSION(r140344): Repeated crashes in WKTR PlatformWebView::viewSupportsOptions().
218         https://bugs.webkit.org/show_bug.cgi?id=107562
219
220         Rubber-stamped by Alexy Proskuryakov.
221
222         The input to WKBooleanGetValue() is not NULL-safe, so NULL check its inputs before calling.
223
224         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
225         (WTR::PlatformWebView::PlatformWebView):
226         (WTR::PlatformWebView::viewSupportsOptions):
227
228 2013-01-22  Alexey Proskuryakov  <ap@apple.com>
229
230         One is not allowed to use commit-queue to make oneself a committer.
231
232         * Scripts/webkitpy/common/config/committers.py: Removing eustas@chromium.org.
233
234 2013-01-22  Eugene Klyuchnikov  <eustas@chromium.org>
235
236         Add myself to commiters.py
237         https://bugs.webkit.org/show_bug.cgi?id=107546
238
239         Reviewed by Kentaro Hara.
240
241         * Scripts/webkitpy/common/config/committers.py:
242
243 2013-01-22  Manuel Rego Casasnovas  <rego@igalia.com>
244
245         [GTK] Implement TestRunner::setTextDirection
246         https://bugs.webkit.org/show_bug.cgi?id=107131
247
248         Reviewed by Philippe Normand.
249
250         * DumpRenderTree/gtk/DumpRenderTree.cpp:
251         (resetDefaultsToConsistentValues): Reset direction to default value.
252         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
253         (TestRunner::setTextDirection): Implement method using
254         gtk_widget_set_direction.
255
256 2013-01-22  Jochen Eisinger  <jochen@chromium.org>
257
258         [chromium] move spell checking mocks to TestRunner library
259         https://bugs.webkit.org/show_bug.cgi?id=107455
260
261         Reviewed by Kent Tamura.
262
263         The content module doesn't provide its own WebSpellCheckClient.
264
265         * DumpRenderTree/DumpRenderTree.gypi:
266         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
267         (WebTestRunner::WebTestDelegate::fillSpellingSuggestionList):
268         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
269         (WebKit):
270         (WebTestRunner):
271         (WebTestProxyBase):
272         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
273         (WebTestRunner):
274         (WebTestRunner::makeMenuItemStringsFor):
275         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Renamed from Tools/DumpRenderTree/chromium/MockGrammarCheck.cpp.
276         (MockGrammarCheck::checkGrammarOfString):
277         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Renamed from Tools/DumpRenderTree/chromium/MockGrammarCheck.h.
278         (WebKit):
279         (MockGrammarCheck):
280         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Renamed from Tools/DumpRenderTree/chromium/MockSpellCheck.cpp.
281         (MockSpellCheck::MockSpellCheck):
282         (MockSpellCheck::~MockSpellCheck):
283         (isNotASCIIAlpha):
284         (MockSpellCheck::spellCheckWord):
285         (MockSpellCheck::fillSuggestionList):
286         (MockSpellCheck::initializeIfNeeded):
287         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Renamed from Tools/DumpRenderTree/chromium/MockSpellCheck.h.
288         (MockSpellCheck):
289         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Added.
290         (WebTestRunner::SpellCheckClient::SpellCheckClient):
291         (WebTestRunner):
292         (WebTestRunner::SpellCheckClient::~SpellCheckClient):
293         (WebTestRunner::SpellCheckClient::setDelegate):
294         (WebTestRunner::SpellCheckClient::spellCheck):
295         (WebTestRunner::SpellCheckClient::checkTextOfParagraph):
296         (WebTestRunner::SpellCheckClient::requestCheckingOfText):
297         (WebTestRunner::SpellCheckClient::finishLastTextCheck):
298         (WebTestRunner::SpellCheckClient::autoCorrectWord):
299         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.
300         (WebTestRunner):
301         (SpellCheckClient):
302         (WebTestRunner::SpellCheckClient::taskList):
303         (WebTestRunner::SpellCheckClient::mockSpellCheck):
304         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
305         (TestDelegate):
306         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
307         (WebTestInterfaces::Internal):
308         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
309         (WebTestRunner::WebTestProxyBase::WebTestProxyBase):
310         (WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
311         (WebTestRunner::WebTestProxyBase::setDelegate):
312         (WebTestRunner::WebTestProxyBase::spellCheckClient):
313         (WebTestRunner):
314         * DumpRenderTree/chromium/WebViewHost.cpp:
315         (WebViewHost::WebViewHost):
316         (WebViewHost::setWebWidget):
317         * DumpRenderTree/chromium/WebViewHost.h:
318         (WebViewHost):
319
320 2013-01-22  Krzysztof Czech  <k.czech@samsung.com>
321
322         [EFL] Adds Accessibility support to wk1
323         https://bugs.webkit.org/show_bug.cgi?id=107440
324
325         Reviewed by Gyuyoung Kim.
326
327         * DumpRenderTree/efl/CMakeLists.txt: Adds ATK headers and libraries.
328
329 2013-01-21  Joseph Pecoraro  <pecoraro@apple.com>
330
331         [Mac] WK1 MiniBrowser should clear delegates before releasing webview
332         https://bugs.webkit.org/show_bug.cgi?id=107506
333
334         Reviewed by Dan Bernstein.
335
336         * MiniBrowser/mac/WK1BrowserWindowController.m:
337         (-[WK1BrowserWindowController dealloc]):
338
339 2013-01-21  Dirk Schulze  <dschulze@adobe.com>
340
341         Add build flag for Canvas's Path object (disabled by default)
342         https://bugs.webkit.org/show_bug.cgi?id=107473
343
344         Reviewed by Dean Jackson.
345
346         Add CANVAS_PATH build flag to build systems.
347
348         * Scripts/webkitperl/FeatureList.pm:
349
350 2013-01-21  Jinwoo Song  <jinwoo7.song@samsung.com>
351
352         [EFL][WK2] Add APIs to set/get view source mode
353         https://bugs.webkit.org/show_bug.cgi?id=106633
354
355         Reviewed by Gyuyoung Kim.
356
357         Added a shotcut 'F8' in Minibrowser to display a source code
358         of the web page in a new window.
359
360        * MiniBrowser/efl/main.c:
361         (on_key_down):
362         (on_window_create):
363         (window_create):
364         (elm_main):
365
366 2013-01-21  Nico Weber  <thakis@chromium.org>
367
368         [chromium] Don't archive generated source files.
369         https://bugs.webkit.org/show_bug.cgi?id=106736
370
371         Reviewed by Eric Seidel.
372
373         They shouldn't be needed to run tests. They don't need a lot of space,
374         but add many lines to the "extracting" stdout. This attempts to reduce
375         that noise a bit.
376
377         * BuildSlaveSupport/built-product-archive:
378         (archiveBuiltProduct):
379
380 2013-01-21  Benjamin Poulain  <benjamin@webkit.org>
381
382         Mac DumpRenderTree's installSignalHandlers() is unreachable code
383         https://bugs.webkit.org/show_bug.cgi?id=107383
384
385         Reviewed by Sam Weinig.
386
387         The CrashHandler of DumpRenderTree were originally used for restoring
388         the color profile of the main display even if DRT crashes.
389
390         That feature was later limited to pixel tests only in r29999.
391
392         In r104351, the DRT was changed to use device color space. Making the crash
393         handlers useless, but they were left in the code since the error reporting
394         code was still reachable.
395
396         Later, r124581 refactored the code and dumpPixelsForCurrentTest
397         is being used before being assigned its value.
398         This did cause any regression because the code had become useless with the previous change.
399
400         * DumpRenderTree/mac/DumpRenderTree.mm:
401         Remove crashHandler() and installSignalHandlers() as they have become useless and
402         have been unreachable code for 6 months.
403         (dumpRenderTree):
404         Remove the code that was unreachable due to dumpPixelsForCurrentTest being always false
405         at those points.
406
407 2013-01-21  Nico Weber  <thakis@chromium.org>
408
409         Make ninja the default build system for build-webkit --chromium on mac
410         https://bugs.webkit.org/show_bug.cgi?id=106737
411
412         Reviewed by Eric Seidel.
413
414         * Scripts/update-webkit-chromium:
415
416 2013-01-21  Christophe Dumez  <christophe.dumez@intel.com>
417
418         Regression(r140262): Causes a lot of flakiness
419         https://bugs.webkit.org/show_bug.cgi?id=107454
420
421         Reviewed by Alexey Proskuryakov.
422
423         r140262 introduced a lot of flakiness due to fixed layout mode
424         not getting disabled on the view after being enabled for
425         specific test cases. This patch makes sure fixed layout mode
426         properly gets reset in WebKitTestRunner to avoid flakiness.
427
428         * WebKitTestRunner/TestInvocation.cpp:
429         (WTR::updateLayoutType):
430
431 2013-01-21  Gustavo Noronha Silva  <gns@gnome.org>
432
433         REGRESSION (r140285): GTK uses WKPageResourceLoadClient which was removed
434         https://bugs.webkit.org/show_bug.cgi?id=107421
435
436         Unreviewed build fix.
437
438         * Scripts/run-gtk-tests:
439         (TestRunner): skip Resource tests.
440
441 2013-01-21  Christophe Dumez  <christophe.dumez@intel.com>
442
443         [EFL][WKTR] platformRunUntil() should keep the main loop running
444         https://bugs.webkit.org/show_bug.cgi?id=107442
445
446         Reviewed by Noam Rosenthal.
447
448         EFL's implementation of platformRunUntil() should keep the main loop
449         running and avoid calling sleep() between calls to
450         ecore_main_loop_iterate(). This call to sleep seems to be a source
451         of deadlocks (see Bug 106884).
452
453         * WebKitTestRunner/efl/TestControllerEfl.cpp:
454         (WTR::TestController::platformRunUntil):
455
456 2013-01-21  Vivek Galatage  <vivek.vg@samsung.com>
457
458         QtTestBrowser should provide way to clear selected elements
459         https://bugs.webkit.org/show_bug.cgi?id=107437
460
461         Reviewed by Simon Hausmann.
462
463         Provide a way to "Clear selection" in the "Develop" menu to clear the previous search highlight.
464         Invoke the clearSelection prior to highlighting new elements.
465
466         * QtTestBrowser/launcherwindow.cpp:
467         (ElementHighlight):
468         (LauncherWindow::createChrome):
469         (LauncherWindow::selectElements):
470         (LauncherWindow::clearSelection):
471         * QtTestBrowser/launcherwindow.h:
472         (LauncherWindow):
473
474 2013-01-21  Jochen Eisinger  <jochen@chromium.org>
475
476         [chromium] move methods interacting with willSendRequest to TestRunner
477         https://bugs.webkit.org/show_bug.cgi?id=107270
478
479         Reviewed by Kent Tamura.
480
481         * DumpRenderTree/chromium/DRTTestRunner.cpp:
482         (DRTTestRunner::DRTTestRunner):
483         (DRTTestRunner::waitForPolicyDelegate):
484         * DumpRenderTree/chromium/DRTTestRunner.h:
485         (DRTTestRunner):
486         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
487         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
488         (WebTestRunner::WebTestRunner::httpHeadersToClear):
489         (WebTestRunner::WebTestRunner::shouldBlockRedirects):
490         (WebTestRunner::WebTestRunner::willSendRequestShouldReturnNull):
491         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
492         (WebTestRunner::TestRunner::TestRunner):
493         (WebTestRunner::TestRunner::reset):
494         (WebTestRunner::TestRunner::httpHeadersToClear):
495         (WebTestRunner):
496         (WebTestRunner::TestRunner::shouldBlockRedirects):
497         (WebTestRunner::TestRunner::willSendRequestShouldReturnNull):
498         (WebTestRunner::TestRunner::setWillSendRequestClearHeader):
499         (WebTestRunner::TestRunner::setWillSendRequestReturnsNullOnRedirect):
500         (WebTestRunner::TestRunner::setWillSendRequestReturnsNull):
501         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
502         (TestRunner):
503         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
504         (WebTestRunner::WebTestProxyBase::willSendRequest):
505         * DumpRenderTree/chromium/WebViewHost.cpp:
506         (WebViewHost::willSendRequest):
507         (WebViewHost::reset):
508         * DumpRenderTree/chromium/WebViewHost.h:
509         (WebViewHost):
510
511 2013-01-21  Zan Dobersek  <zdobersek@igalia.com>
512
513         [GTK] Stop building WebKit2 on GTK EWSs
514         https://bugs.webkit.org/show_bug.cgi?id=107435
515
516         Reviewed by Philippe Normand.
517
518         The WebKit2 build of the GTK is at the moment not efficiently maintainable,
519         so stop building it on GTK EWSs.
520
521         * Scripts/webkitpy/common/config/ports.py:
522         (GtkPort.build_webkit_command):
523         * Scripts/webkitpy/common/config/ports_unittest.py:
524         (DeprecatedPortTest.test_gtk_port):
525
526 2013-01-21  Tommy Widenflycht  <tommyw@google.com>
527
528         MediaStream API: Update the RTCPeerConnection states to match the latest specification
529         https://bugs.webkit.org/show_bug.cgi?id=107120
530
531         Reviewed by Adam Barth.
532
533         Updating mock to use the new states.
534
535         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
536         (RTCPeerConnectionStateTask::RTCPeerConnectionStateTask):
537         (MockWebRTCPeerConnectionHandler::initialize):
538         (MockWebRTCPeerConnectionHandler::updateICE):
539
540 2013-01-20  Tim 'mithro' Ansell  <mithro@mithis.com>
541
542         Extend diff_parser to support the --full-index output.
543         https://bugs.webkit.org/show_bug.cgi?id=107408
544
545         Reviewed by Maciej Stachowiak.
546
547         * Scripts/webkitpy/common/checkout/diff_parser.py:
548         (git_diff_to_svn_diff):
549         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
550         (DiffParserTest):
551         (DiffParserTest.test_git_diff_to_svn_diff):
552         (git_diff_to_svn_diff):
553
554 2013-01-20  Yoshifumi Inoue  <yosin@chromium.org>
555
556         Dragging over an element with scrollbars should scroll the element when dragging near edges
557         https://bugs.webkit.org/show_bug.cgi?id=39725
558
559         Reviewed by Hajime Morita.
560
561         This patch introduces canceling drag-and-drop by escape key for testing
562         behavior after cancellation drag-and-drop.
563
564         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
565         (WebTestRunner):
566         (WebTestRunner::EventSender::doMouseUp):
567         (WebTestRunner::EventSender::finishDragAndDrop):
568         (WebTestRunner::EventSender::keyDown):
569         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
570         (EventSender):
571         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Added VKEY_ESCAPE.
572
573 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
574
575         [chromium] move frame generation related methods to TestRunner
576         https://bugs.webkit.org/show_bug.cgi?id=107268
577
578         Reviewed by Adam Barth.
579
580         * DumpRenderTree/chromium/DRTTestRunner.cpp:
581         (DRTTestRunner::DRTTestRunner):
582         (DRTTestRunner::setWillSendRequestReturnsNull):
583         * DumpRenderTree/chromium/DRTTestRunner.h:
584         (DRTTestRunner):
585         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
586         (WebTestRunner::WebTestDelegate::display):
587         (WebTestRunner::WebTestDelegate::displayInvalidatedRegion):
588         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
589         (WebTestRunner::TestRunner::TestRunner):
590         (WebTestRunner::TestRunner::display):
591         (WebTestRunner):
592         (WebTestRunner::TestRunner::displayInvalidatedRegion):
593         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
594         (TestRunner):
595         * DumpRenderTree/chromium/WebViewHost.cpp:
596         (WebViewHost::display):
597         (WebViewHost::displayInvalidatedRegion):
598         * DumpRenderTree/chromium/WebViewHost.h:
599
600 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
601
602         [chromium] move speech related methods to TestRunner library
603         https://bugs.webkit.org/show_bug.cgi?id=107266
604
605         Reviewed by Adam Barth.
606
607         * DumpRenderTree/chromium/DRTTestRunner.cpp:
608         (DRTTestRunner::DRTTestRunner):
609         (DRTTestRunner::displayInvalidatedRegion):
610         * DumpRenderTree/chromium/DRTTestRunner.h:
611         (DRTTestRunner):
612         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
613         (WebTestDelegate):
614         (WebTestRunner::WebTestDelegate::addMockSpeechInputResult):
615         (WebTestRunner::WebTestDelegate::setMockSpeechInputDumpRect):
616         (WebTestRunner::WebTestDelegate::addMockSpeechRecognitionResult):
617         (WebTestRunner::WebTestDelegate::setMockSpeechRecognitionError):
618         (WebTestRunner::WebTestDelegate::wasMockSpeechRecognitionAborted):
619         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
620         (WebTestRunner::TestRunner::TestRunner):
621         (WebTestRunner):
622         (WebTestRunner::TestRunner::addMockSpeechInputResult):
623         (WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
624         (WebTestRunner::TestRunner::addMockSpeechRecognitionResult):
625         (WebTestRunner::TestRunner::setMockSpeechRecognitionError):
626         (WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
627         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
628         (TestRunner):
629         * DumpRenderTree/chromium/WebViewHost.cpp:
630         (WebViewHost::addMockSpeechInputResult):
631         (WebViewHost::setMockSpeechInputDumpRect):
632         (WebViewHost::addMockSpeechRecognitionResult):
633         (WebViewHost::setMockSpeechRecognitionError):
634         (WebViewHost::wasMockSpeechRecognitionAborted):
635         * DumpRenderTree/chromium/WebViewHost.h:
636
637 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
638
639         [chromium] move notification related methods to TestRunner
640         https://bugs.webkit.org/show_bug.cgi?id=107269
641
642         Reviewed by Adam Barth.
643
644         * DumpRenderTree/chromium/DRTTestRunner.cpp:
645         (DRTTestRunner::DRTTestRunner):
646         * DumpRenderTree/chromium/DRTTestRunner.h:
647         (DRTTestRunner):
648         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
649         (WebTestDelegate):
650         (WebTestRunner::WebTestDelegate::grantWebNotificationPermission):
651         (WebTestRunner::WebTestDelegate::simulateLegacyWebNotificationClick):
652         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
653         (WebTestRunner::TestRunner::TestRunner):
654         (WebTestRunner):
655         (WebTestRunner::TestRunner::grantWebNotificationPermission):
656         (WebTestRunner::TestRunner::simulateLegacyWebNotificationClick):
657         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
658         (TestRunner):
659         * DumpRenderTree/chromium/WebViewHost.cpp:
660         (WebViewHost::grantWebNotificationPermission):
661         (WebViewHost::simulateLegacyWebNotificationClick):
662         * DumpRenderTree/chromium/WebViewHost.h:
663
664 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
665
666         [chromium] move geolocation related methods to TestRunner
667         https://bugs.webkit.org/show_bug.cgi?id=107267
668
669         Reviewed by Adam Barth.
670
671         * DumpRenderTree/chromium/DRTTestRunner.cpp:
672         (DRTTestRunner::DRTTestRunner):
673         * DumpRenderTree/chromium/DRTTestRunner.h:
674         (DRTTestRunner):
675         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
676         (WebTestRunner::WebTestDelegate::numberOfPendingGeolocationPermissionRequests):
677         (WebTestRunner::WebTestDelegate::setGeolocationPermission):
678         (WebTestRunner::WebTestDelegate::setMockGeolocationPosition):
679         (WebTestRunner::WebTestDelegate::setMockGeolocationPositionUnavailableError):
680         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
681         (WebTestRunner::TestRunner::TestRunner):
682         (WebTestRunner::TestRunner::numberOfPendingGeolocationPermissionRequests):
683         (WebTestRunner):
684         (WebTestRunner::TestRunner::setGeolocationPermission):
685         (WebTestRunner::TestRunner::setMockGeolocationPosition):
686         (WebTestRunner::TestRunner::setMockGeolocationPositionUnavailableError):
687         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
688         (TestRunner):
689         * DumpRenderTree/chromium/WebViewHost.cpp:
690         (WebViewHost::numberOfPendingGeolocationPermissionRequests):
691         (WebViewHost::setGeolocationPermission):
692         (WebViewHost::setMockGeolocationPosition):
693         (WebViewHost::setMockGeolocationPositionUnavailableError):
694         * DumpRenderTree/chromium/WebViewHost.h:
695
696 2013-01-19  Zan Dobersek  <zdobersek@igalia.com>
697
698         Unreviewed build fix for Qt WK2 after r140258.
699         Use the size_t type instead of unsigned for the variable
700         which holds the position of the first null character in the
701         console message.
702
703         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
704         (WTR::InjectedBundlePage::willAddMessageToConsole):
705
706 2013-01-19  Sheriff Bot  <webkit.review.bot@gmail.com>
707
708         Unreviewed, rolling out r140260.
709         http://trac.webkit.org/changeset/140260
710         https://bugs.webkit.org/show_bug.cgi?id=107387
711
712         breaks fast/text/hyphens.html, fast/text/hyphenate-* (but
713         nothing else) (Requested by thakis__ on #webkit).
714
715         * Scripts/update-webkit-chromium:
716
717 2013-01-19  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
718
719         Delegated scrolling: Assertion on attempt to show a CSS sticky element
720         https://bugs.webkit.org/show_bug.cgi?id=106890
721
722         Reviewed by Kenneth Rohde Christiansen.
723
724         Enabled fixed layout mode in WTR for 'fast/css/sticky' tests.
725
726         * WebKitTestRunner/TestInvocation.cpp:
727         (WTR::shouldUseFixedLayout):
728         (WTR):
729         (WTR::updateLayoutType):
730
731 2013-01-19  Nico Weber  <thakis@chromium.org>
732
733         Make ninja the default build system for build-webkit --chromium on mac
734         https://bugs.webkit.org/show_bug.cgi?id=106737
735
736         Reviewed by Eric Seidel.
737
738         * Scripts/update-webkit-chromium:
739
740 2013-01-19  Zan Dobersek  <zdobersek@igalia.com>
741
742         [WK2] svg/dom/fuzz-path-parser.html is failing
743         https://bugs.webkit.org/show_bug.cgi?id=107133
744
745         Reviewed by Alexey Proskuryakov.
746
747         Console messages can contain null characters before the end of string.
748         Appending such message to the StringBuilder as a WTFString appends the
749         complete string, including the null character. This later cuts off everything
750         after the null character when the string is being printed out to the test
751         output.
752
753         To avoid this, truncate the string up to the first null character. This
754         preserves the newline character appended immediately after this and
755         stops giving incorrect output.
756
757         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
758         (WTR::InjectedBundlePage::willAddMessageToConsole):
759
760 2013-01-19  Eric Seidel  <eric@webkit.org>
761
762         Update error regexps so that Parser/html-parser-srcdoc.html can "pass"
763         https://bugs.webkit.org/show_bug.cgi?id=107367
764
765         Reviewed by Ryosuke Niwa.
766
767         Using srcdoc instead of document.write changes the error output
768         ever so slightly.  Clearly we were already trying to ignore these
769         messages, just not succeeding.  This change makes this new test "pass" correctly.
770
771         * Scripts/webkitpy/performance_tests/perftest.py:
772         (PerfTest):
773
774 2013-01-18  Dan Winship  <danw@gnome.org>
775
776         REGRESSION (r139071): run-webkit-httpd complains at launch
777         https://bugs.webkit.org/show_bug.cgi?id=107310
778
779         Reviewed by Alexey Proskuryakov.
780
781         * Scripts/webkitperl/httpd.pm:
782         (getApacheVersion): use preferred perl syntax
783
784 2013-01-18  Julie Parent  <jparent@chromium.org>
785
786         Add back 'group' as a default cross dashboard parameter, but with null as its value.
787         https://bugs.webkit.org/show_bug.cgi?id=107336
788
789         We need to have 'group' listed as a parameter, else we never parse it,
790         as we only parse parameters with defaults.
791         
792         Reviewed by Ojan Vafai.
793
794         * TestResultServer/static-dashboards/dashboard_base.js:
795
796 2013-01-18  Emil A Eklund  <eae@chromium.org>
797
798         Update LayoutUnit rounding unit test
799         https://bugs.webkit.org/show_bug.cgi?id=107322
800
801         Reviewed by Levi Weintraub.
802         
803         Update the LayoutUnitRounding test to use fromFloatRound for
804         values that cannot accurately be represented as a LayoutUnit
805         (the default behavior is to floor the value to the nearest
806         LayoutUnit).
807
808         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
809         (TestWebKitAPI::TEST):
810
811 2013-01-18  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
812
813         VCSUtils.pm: Stop calling git repo-config.
814         https://bugs.webkit.org/show_bug.cgi?id=107294
815
816         Reviewed by Dirk Pranke.
817
818         The `repo-config' git command has been deprecated since early
819         2008, and recent versions have started warning it is deprecated.
820
821         Basically revert r27870 and use the `config' command all the time.
822
823         * Scripts/VCSUtils.pm:
824         (gitConfig):
825
826 2013-01-18  Levi Weintraub  <leviw@chromium.org>
827
828         LayoutUnit should round half consistently, not away from zero
829         https://bugs.webkit.org/show_bug.cgi?id=107208
830
831         Reviewed by Eric Seidel.
832
833         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp: Updating to reflect and
834         cover this change in rounding behavior.
835
836 2013-01-18  Tim Horton  <timothy_horton@apple.com>
837
838         [mac] DumpRenderTree/WebKitTestRunner should not participate in Exposé/Mission Control
839         https://bugs.webkit.org/show_bug.cgi?id=107234
840
841         Reviewed by Simon Fraser.
842
843         * DumpRenderTree/mac/DumpRenderTree.mm:
844         (createWebViewAndOffscreenWindow): Disable participation in Exposé via NSWindowCollectionBehaviorStationary.
845         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
846         (WTR::PlatformWebView::PlatformWebView): Ditto.
847
848 2013-01-18  Tim Horton  <timothy_horton@apple.com>
849
850         [mac] DumpRenderTree/WebKitTestRunner should disable NSBeep
851         https://bugs.webkit.org/show_bug.cgi?id=107251
852
853         Reviewed by Simon Fraser.
854
855         Disable NSBeep in DumpRenderTree and WebKitTestRunner using NSSound SPI.
856
857         * DumpRenderTree/mac/DumpRenderTree.mm:
858         (dumpRenderTree):
859         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
860         (WTR::InjectedBundle::platformInitialize):
861
862 2013-01-18  Martin Robinson  <mrobinson@igalia.com>
863
864         [GTK] Enable indexed database for development builds
865         https://bugs.webkit.org/show_bug.cgi?id=107299
866
867         Reviewed by Gustavo Noronha Silva.
868
869         * Scripts/webkitperl/FeatureList.pm: Enable indexed database by default
870         for GTK+ development builds.
871
872 2013-01-18  Dominic Mazzoni  <dmazzoni@google.com>
873
874         AX: Improve table-guessing heuristics
875         https://bugs.webkit.org/show_bug.cgi?id=107042
876
877         Reviewed by Chris Fleizach.
878
879         Implement parentElementCallback on Chromium to make testing easier.
880
881         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
882         (WebTestRunner::AccessibilityUIElement::parentElementCallback):
883
884 2013-01-18  Martin Robinson  <mrobinson@igalia.com>
885
886         [GTK] Add property for IndexedDB database path to WebKitGTK+
887         https://bugs.webkit.org/show_bug.cgi?id=106136
888
889         Reviewed by Gustavo Noronha Silva.
890
891         During testing, set the web database directory to DUMPRENDERTREE_TEMP
892         before falling back to the old default. This is necessary because
893         indexed database tests require that each DRT shard is using a different
894         IDB database location.
895
896         * DumpRenderTree/gtk/DumpRenderTree.cpp:
897         (temporaryDatabaseDirectory): Added this helper for getting the
898         database directory.
899         (setDefaultsToConsistentStateValuesForTesting): Use the new helper.
900
901 2013-01-18  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
902
903         [EFL][WK2] Enable API test InjectedBundleFrameHitTest on EFL
904         https://bugs.webkit.org/show_bug.cgi?id=107264
905
906         Reviewed by Laszlo Gombos.
907
908         Enable API test InjectedBundleFrameHitTest for hit-testing,
909         since it is now passing on both Debug and Release builds.
910
911         * TestWebKitAPI/CMakeLists.txt:
912         * TestWebKitAPI/PlatformEfl.cmake:
913
914 2013-01-18  Manuel Rego Casasnovas  <rego@igalia.com>
915
916         [GTK] Implement TestRunner::addUserScript
917         https://bugs.webkit.org/show_bug.cgi?id=107275
918
919         Reviewed by Philippe Normand.
920
921         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
922         (TestRunner::addUserScript): Implement method using
923         DumpRenderTreeSupportGtk::addUserScript.
924
925 2013-01-18  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
926
927         Unreviewed, add my secondary email address to the list.
928
929         * Scripts/webkitpy/common/config/committers.py:
930
931 2013-01-18  Dan Carney  <dcarney@google.com>
932
933         [chromium] move pointerlock functions to TestRunner library
934         https://bugs.webkit.org/show_bug.cgi?id=107241
935
936         Reviewed by Jochen Eisinger.
937
938         * DumpRenderTree/chromium/DRTTestRunner.cpp:
939         (DRTTestRunner::DRTTestRunner):
940         * DumpRenderTree/chromium/DRTTestRunner.h:
941         (DRTTestRunner):
942         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
943         (WebTestRunner::WebTestDelegate::didAcquirePointerLock):
944         (WebTestRunner::WebTestDelegate::didNotAcquirePointerLock):
945         (WebTestRunner::WebTestDelegate::didLosePointerLock):
946         (WebTestRunner::WebTestDelegate::setPointerLockWillRespondAsynchronously):
947         (WebTestRunner::WebTestDelegate::setPointerLockWillFailSynchronously):
948         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
949         (WebTestRunner::TestRunner::TestRunner):
950         (WebTestRunner):
951         (WebTestRunner::TestRunner::didAcquirePointerLock):
952         (WebTestRunner::TestRunner::didNotAcquirePointerLock):
953         (WebTestRunner::TestRunner::didLosePointerLock):
954         (WebTestRunner::TestRunner::setPointerLockWillRespondAsynchronously):
955         (WebTestRunner::TestRunner::setPointerLockWillFailSynchronously):
956         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
957         (TestRunner):
958         * DumpRenderTree/chromium/WebViewHost.h:
959         (WebViewHost):
960
961 2013-01-14  Dominik Röttsches  <dominik.rottsches@intel.com>
962
963         [EFL] Update freetype in jhbuild to 2.4.11 and activate subpixel layout
964         https://bugs.webkit.org/show_bug.cgi?id=106774
965
966         Reviewed by Martin Robinson.
967
968         In order to fix a long standing linespacing/font ascent & descent issue
969         we found that FreeType commit b0962ac34e660 solves that problem.
970         Let's update FreeType accordingly, but bump it to 2.4.11 due to the
971         maintainer recommending several security updates after that said commit.
972
973         Also, in order to avoid extra rebaselining, let's activate subpixel
974         layout at the same time.
975
976         * efl/jhbuild.modules: New freetype 2.4.11
977
978 2013-01-17  Xiaobo Wang  <xbwang@torchmobile.com.cn>
979
980         [BlackBerry] DRT - Accept http/file URL when running drt-launcher from command line
981         https://bugs.webkit.org/show_bug.cgi?id=107107
982         PR 282192
983
984         Reviewed by Rob Buis.
985
986         The DRT application will convert relative/absolute file path to
987         file://<real-file-path> format, so we only check for http/file prefix.
988
989         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
990         (BlackBerry::WebKit::isFullUrl):
991         (WebKit):
992         (BlackBerry::WebKit::DumpRenderTree::runCurrentTest):
993
994 2013-01-17  Frank Farzan  <frankf@chromium.org>
995
996         Flakiness dashboard: Add ChromiumFYI master
997         https://bugs.webkit.org/show_bug.cgi?id=107180
998
999         Reviewed by Ojan Vafai.
1000
1001         This is needed to enable Chrome Android bots
1002         to upload results for instrumentation tests.
1003
1004         * TestResultServer/generate_builders_json.py:
1005         (main):
1006         * TestResultServer/static-dashboards/builders.jsonp:
1007
1008 2013-01-17  Frank Farzan  <frankf@chromium.org>
1009
1010         Add Chrome on Android instrumentation test types to flakiness dashboard
1011         https://bugs.webkit.org/show_bug.cgi?id=106964
1012
1013         Reviewed by Ojan Vafai.
1014
1015         Specifically, add these test types:
1016         
1017          androidwebview_instrumentation_tests
1018          chromiumtestshell_instrumentation_tests
1019          contentshell_instrumentation_tests
1020         
1021         Also, add ChromiumFYI to the list of masters.
1022
1023         * TestResultServer/static-dashboards/builders.js:
1024         (loadBuildersList):
1025         * TestResultServer/static-dashboards/dashboard_base.js:
1026         (currentBuilderGroupCategory):
1027
1028 2013-01-17  Tim 'mithro' Ansell  <mithro@mithis.com>
1029
1030         Fixing webkitpy's SCM unit tests.
1031         https://bugs.webkit.org/show_bug.cgi?id=106429
1032
1033         Reviewed by Eric Seidel.
1034
1035         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
1036         (SCMDetectorTest.test_detect_scm_system):
1037         * Scripts/webkitpy/common/checkout/scm/git.py:
1038         (Git.in_working_directory):
1039         (Git.read_git_config):
1040         (Git._assert_can_squash):
1041         (Git.remote_branch_ref):
1042         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1043         (GitSVNTest.test_commit_with_message_multiple_local_commits_always_squash):
1044         (GitTestWithMock):
1045         (GitTestWithMock.make_scm):
1046         (GitTestWithMock.test_create_patch):
1047         * Scripts/webkitpy/common/system/outputcapture.py:
1048         (OutputCapture.assert_outputs):
1049         (OutputCaptureTestCaseBase):
1050         * Scripts/webkitpy/test/printer.py:
1051         (Printer.configure):
1052
1053 2013-01-17  Julie Parent  <jparent@chromium.org>
1054
1055         Flakiness dashboard assumes there must be ToT tests
1056         https://bugs.webkit.org/show_bug.cgi?id=107155
1057
1058         Remove group as a default parameter, since we can't actually know
1059         the name of a group initially.  Instead, introduces 
1060         currentBuilderGroupName which returns the current builder group
1061         if it has been explicitly set, or picks the first one available
1062         as a default. Allows us to remove some extra code tracking this
1063         stuff as well.
1064         
1065         Reviewed by Ojan Vafai.
1066
1067         * TestResultServer/static-dashboards/dashboard_base.js:
1068         (parseCrossDashboardParameters):
1069         (currentBuilderGroupName):
1070         (currentBuilderGroup):
1071         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1072         (platformAndBuildType):
1073         * TestResultServer/static-dashboards/loader.js:
1074         (.):
1075
1076 2013-01-16  Ryosuke Niwa  <rniwa@webkit.org>
1077
1078         Remove NodeListsNodeData when it's no longer needed
1079         https://bugs.webkit.org/show_bug.cgi?id=107074
1080
1081         Reviewed by Darin Adler.
1082
1083         Generalize the warning a little so that it's also ignored on PerformanceTests/DOM/TraverseChildNodes.html
1084
1085         * Scripts/webkitpy/performance_tests/perftest.py:
1086         (PerfTest):
1087
1088 2013-01-17  Simon Fraser  <simon.fraser@apple.com>
1089
1090         Ref test images are upside-down in WebKit2
1091         https://bugs.webkit.org/show_bug.cgi?id=105457
1092
1093         Reviewed by Sam "Speedy" Weinig.
1094         
1095         The bitmap context created in TestInvocation::dumpPixelsAndCompareWithExpected()
1096         from the window snapshot contained a flipped copy of the image, causing all ref
1097         and pixel images to be upside-down.
1098
1099         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1100         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1101
1102 2013-01-17  Timothy Loh  <timloh@google.com>
1103
1104         Replaced specifiers variable with is_debug in builders.py
1105         https://bugs.webkit.org/show_bug.cgi?id=107057
1106
1107         Reviewed by Dirk Pranke.
1108
1109         Replaced specifiers variable with is_debug in builders.py to simplify
1110         Bug 106259. The other specifiers are not used elsewhere in the code.
1111         Fixed builder_name_for_port_name to return a debug builder if we don't
1112         have a release builder.
1113
1114         * Scripts/webkitpy/layout_tests/port/builders.py:
1115         (all_port_names):
1116         (builder_name_for_port_name):
1117         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1118         (TestRebaselineExpectations.test_rebaseline_expectations):
1119
1120 2013-01-17  Martin Robinson  <mrobinson@igalia.com>
1121
1122         [GTK] Build with LevelDB when IndexedDB is enabled
1123         https://bugs.webkit.org/show_bug.cgi?id=103220
1124
1125         Reviewed by Gustavo Noronha Silva.
1126
1127         * Scripts/webkitpy/style/checker.py: Do not style check the leveldb source code
1128         as it does not conform to WebKit style.
1129
1130 2013-01-17  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1131
1132         [EFL][WK2] Fix misuse of ASSERT on ecore_evas_init()
1133         https://bugs.webkit.org/show_bug.cgi?id=107119
1134
1135         Reviewed by Laszlo Gombos.
1136
1137         Do not use ASSERT on ecore_evas_init(), since the expression inside
1138         the macro compiles out of release builds.
1139
1140         * TestWebKitAPI/PlatformEfl.cmake: Enable API test UserMessage.
1141         * TestWebKitAPI/efl/PlatformWebView.cpp:
1142         (TestWebKitAPI::initEcoreEvas): Remove ASSERT on ecore_evas_init().
1143
1144 2013-01-17  Eugene Klyuchnikov  <eustas@chromium.org>
1145
1146         Web Inspector: Profiler: split "getProfile" to "getCPUProfile" and "loadHeapSnapshot"
1147         https://bugs.webkit.org/show_bug.cgi?id=104545
1148
1149         Reviewed by Yury Semikhatsky.
1150
1151         Adopt signature changes.
1152
1153         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
1154         (ProfilerAgent.getCPUProfile): Renamed.
1155         (ProfilerAgent.getHeapSnapshot): Added.
1156
1157 2013-01-17  Zan Dobersek  <zdobersek@igalia.com>
1158
1159         [GTK][EFL] NWRT should check that Xvfb is installed
1160         https://bugs.webkit.org/show_bug.cgi?id=71767
1161
1162         Reviewed by Dirk Pranke.
1163
1164         EFL and GTK ports now check that Xvfb is installed before running
1165         layout tests. The command line used to check whether Xvfb is present
1166         is a simple `which Xvfb` that should return 0 as the exit code upon
1167         success.
1168
1169         * Scripts/webkitpy/layout_tests/port/efl.py:
1170         (EflPort.show_results_html_file):
1171         (EflPort):
1172         (EflPort.check_sys_deps):
1173         * Scripts/webkitpy/layout_tests/port/gtk.py:
1174         (GtkPort.check_sys_deps):
1175         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
1176         (XvfbDriver):
1177         (XvfbDriver.check_xvfb):
1178
1179 2013-01-16  Alan Cutter  <alancutter@chromium.org>
1180
1181         sheriffbot can't tell me who "kov" is
1182         https://bugs.webkit.org/show_bug.cgi?id=106184
1183
1184         Reviewed by Eric Seidel.
1185
1186         Added glob style searching to the CommitterList contributors_by_search_string function so exact matches are favoured.
1187
1188         * Scripts/webkitpy/common/config/committers.py:
1189         (Account.matches_glob):
1190         (CommitterList.contributors_by_search_string):
1191         * Scripts/webkitpy/common/config/committers_unittest.py:
1192         (CommittersTest.test_committer_lookup):
1193         * Scripts/webkitpy/tool/bot/irc_command.py:
1194         (Whois):
1195
1196 2013-01-16  David Kilzer  <ddkilzer@apple.com>
1197
1198         Use xcrun to find path to make for Mac port
1199         <http://webkit.org/b/107091>
1200
1201         Reviewed by Dan Bernstein.
1202
1203         * Scripts/webkitpy/layout_tests/port/mac.py:
1204         (MacPort._build_java_test_support): Call self.make_command().
1205         (MacPort.make_command): Add.  Call xcrun_find().
1206         (MacPort.nm_command): Use self.xcrun_find().
1207         (MacPort.xcrun_find): Add.  Extract from nm_command().
1208
1209 2013-01-16  Sam Weinig  <sam@webkit.org>
1210
1211         Make debug-safari --target-web-process work again
1212         https://bugs.webkit.org/show_bug.cgi?id=107088
1213
1214         Reviewed by Anders Carlsson.
1215
1216         * Scripts/webkitdirs.pm:
1217         (execMacWebKitAppForDebugging):
1218         The shim is now called SecItemShim.
1219
1220 2013-01-16  Alan Cutter  <alancutter@chromium.org>
1221
1222         GCE build scripts don't take working directory into account when calling findzone.sh
1223         https://bugs.webkit.org/show_bug.cgi?id=106962
1224
1225         Reviewed by Adam Barth.
1226
1227         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
1228         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
1229         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
1230
1231 2013-01-16  Alan Cutter  <alancutter@chromium.org>
1232
1233         start-queue.sh does not pass remaining parameters correctly
1234         https://bugs.webkit.org/show_bug.cgi?id=107054
1235
1236         Reviewed by Adam Barth.
1237
1238         start-queue.sh now passes all remaining params to the webkit-patch command.
1239         Previously only one additional queue parameter could be sent.
1240
1241         * EWSTools/start-queue.sh:
1242
1243 2013-01-16  Xueqing Huang  <huangxueqing@baidu.com>
1244
1245         check-webkit-style script cannot running in Chinese windows.
1246         https://bugs.webkit.org/show_bug.cgi?id=87548
1247
1248         Reviewed by Darin Adler.
1249
1250         * Scripts/webkitpy/common/system/platforminfo.py:
1251         (PlatformInfo._win_version_tuple_from_cmd):
1252
1253 2013-01-16  Dirk Pranke  <dpranke@chromium.org>
1254
1255         Delete an extraneous print statement.
1256         https://bugs.webkit.org/show_bug.cgi?id=106562
1257
1258         Delete the extraneous print statement introduced in r139841.
1259
1260         * Scripts/webkitpy/layout_tests/views/printing.py:
1261         (Printer.print_found):
1262
1263 2013-01-16  Zan Dobersek  <zdobersek@igalia.com>
1264
1265         Please reinstate --pixel
1266         https://bugs.webkit.org/show_bug.cgi?id=101995
1267
1268         Reviewed by Dirk Pranke.
1269
1270         Add the '--pixel' and '--no-pixel' options for NRWT as aliases for
1271         the '--pixel-tests' (or '-p') and '--no-pixel-tests' options respectively.
1272         Some developers are still used to these options that were available in the ORWT.
1273
1274         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1275         (parse_args):
1276
1277 2013-01-16  Eric Seidel  <eric@webkit.org>
1278
1279         Remove --shark* support from sunspider/run-sunspider now that Shark is dead
1280         https://bugs.webkit.org/show_bug.cgi?id=99512
1281
1282         Reviewed by Darin Adler.
1283
1284         * Scripts/run-sunspider:
1285
1286 2013-01-16  Eric Seidel  <eric@webkit.org>
1287
1288         Remove webkitpy Visual Studio files, as core developers are not interested in maintaining them
1289         https://bugs.webkit.org/show_bug.cgi?id=106036
1290
1291         Reviewed by Darin Adler.
1292
1293         * Scripts/webkitpy/webkitpy.pyproj: Removed.
1294         * Scripts/webkitpy/webkitpy.sln: Removed.
1295
1296 2013-01-16  Chris Hopman  <cjhopman@chromium.org>
1297
1298         [Chromium] Remove hardcoded chromium_*.jar in gyp files
1299         https://bugs.webkit.org/show_bug.cgi?id=104049
1300
1301         Reviewed by Eric Seidel.
1302
1303         Targets with dependencies (direct/indirect) on a java target receive
1304         the chromium_*.jar paths in the variable input_jars_paths. Targets
1305         should use that rather than hardcoding where they think the jar will
1306         be. These can be passed directly to ant as INPUT_JARS_PATHS rather
1307         than as --jars to generate_native_test.py.
1308
1309         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1310         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1311
1312 2013-01-16  Dan Carney  <dcarney@google.com>
1313
1314         [chromium] move setMockDeviceOrientation to TestRunner library
1315         https://bugs.webkit.org/show_bug.cgi?id=106895
1316
1317         Reviewed by Jochen Eisinger.
1318
1319         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1320         (DRTTestRunner::DRTTestRunner):
1321         * DumpRenderTree/chromium/DRTTestRunner.h:
1322         (DRTTestRunner):
1323         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1324         (WebKit):
1325         (WebTestRunner::WebTestDelegate::setDeviceOrientation):
1326         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1327         (WebTestRunner::TestRunner::TestRunner):
1328         (WebTestRunner::TestRunner::setMockDeviceOrientation):
1329         (WebTestRunner):
1330         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1331         (TestRunner):
1332         * DumpRenderTree/chromium/WebViewHost.cpp:
1333         (WebViewHost::setDeviceOrientation):
1334         * DumpRenderTree/chromium/WebViewHost.h:
1335         (WebViewHost):
1336
1337 2013-01-16  Jochen Eisinger  <jochen@chromium.org>
1338
1339         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
1340         https://bugs.webkit.org/show_bug.cgi?id=106904
1341
1342         Reviewed by Adam Barth.
1343
1344         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1345         (DRTTestRunner::DRTTestRunner):
1346         (DRTTestRunner::notifyDone):
1347         (DRTTestRunner::reset):
1348         * DumpRenderTree/chromium/DRTTestRunner.h:
1349         (DRTTestRunner):
1350         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1351         (WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
1352         (WebTestRunner::WebTestDelegate::setFocus):
1353         (WebTestRunner::WebTestDelegate::setAcceptAllCookies):
1354         (WebTestRunner::WebTestDelegate::pathToLocalResource):
1355         (WebTestRunner::WebTestDelegate::setLocale):
1356         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1357         (WebTestRunner::TestRunner::TestRunner):
1358         (WebTestRunner::TestRunner::reset):
1359         (WebTestRunner::TestRunner::setAlwaysAcceptCookies):
1360         (WebTestRunner):
1361         (WebTestRunner::TestRunner::setWindowIsKey):
1362         (WebTestRunner::TestRunner::pathToLocalResource):
1363         (WebTestRunner::TestRunner::setBackingScaleFactor):
1364         (WebTestRunner::TestRunner::setPOSIXLocale):
1365         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1366         (WebTestRunner::TestRunner::taskList):
1367         (TestRunner):
1368         * DumpRenderTree/chromium/WebViewHost.cpp:
1369         (WebViewHost::setDeviceScaleFactor):
1370         (WebViewHost::setFocus):
1371         (WebViewHost::setAcceptAllCookies):
1372         (WebViewHost::pathToLocalResource):
1373         (WebViewHost::setLocale):
1374         * DumpRenderTree/chromium/WebViewHost.h:
1375         (WebViewHost):
1376
1377 2013-01-16  Sergio Villar Senin  <svillar@igalia.com>
1378
1379         [GTK] build-webkit fails if the jhbuild wrapper is not used
1380         https://bugs.webkit.org/show_bug.cgi?id=106769
1381
1382         Reviewed by Martin Robinson.
1383
1384         Return an empty array instead of "" in
1385         jhbuildWrapperPrefixIfNeeded() because otherwise that empty string
1386         will not be recognized as a valid command when the returned array
1387         is directly passed to perl's system() call.
1388
1389         * Scripts/webkitdirs.pm:
1390         (jhbuildWrapperPrefixIfNeeded):
1391
1392 2013-01-16  Jochen Eisinger  <jochen@chromium.org>
1393
1394         [chromium] add title text direction attribute to TestRunner
1395         https://bugs.webkit.org/show_bug.cgi?id=106907
1396
1397         Reviewed by Adam Barth.
1398
1399         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1400         (DRTTestRunner::DRTTestRunner):
1401         (DRTTestRunner::reset):
1402         * DumpRenderTree/chromium/DRTTestRunner.h:
1403         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1404         (WebTestRunner::WebTestRunner::setTitleTextDirection):
1405         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1406         (WebTestRunner::TestRunner::TestRunner):
1407         (WebTestRunner::TestRunner::reset):
1408         (WebTestRunner::TestRunner::setTitleTextDirection):
1409         (WebTestRunner):
1410         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1411         (TestRunner):
1412         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1413         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
1414         * DumpRenderTree/chromium/WebViewHost.cpp:
1415         (WebViewHost::didReceiveTitle):
1416
1417 2013-01-16  Jussi Kukkonen  <jussi.kukkonen@intel.com>
1418
1419         NRWT still confused about test count with --repeat-each and --iterations
1420         https://bugs.webkit.org/show_bug.cgi?id=106562
1421
1422         Reviewed by Dirk Pranke.
1423
1424         Fix the printed unique test count and skipped count. This
1425         seems to have broken in r127688 ("NRWT lies about the number
1426         of tests that it's skipping when used with --repeat-each").
1427
1428         Also add a test for print_found()
1429
1430         * Scripts/webkitpy/layout_tests/views/printing.py:
1431         (Printer.print_found):
1432         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1433         (Testprinter.test_details):
1434         (Testprinter):
1435         (Testprinter.test_found):
1436
1437 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
1438
1439         Unreviewed follow-up to r139769.
1440
1441         Note that omitting the WebKit1 code from the build now
1442         works for GTK as well.
1443
1444         * Scripts/build-webkit:
1445
1446 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
1447
1448         test-webkitpy: truncate output to the terminal width when necessary
1449         https://bugs.webkit.org/show_bug.cgi?id=106973
1450
1451         Reviewed by Ojan Vafai.
1452
1453         this implements the same logic for test-webkitpy that we have
1454         for run-webkit-tests (and ninja).
1455
1456         No tests written as this is exercised by running test-webkitpy itself.
1457
1458         * Scripts/webkitpy/test/printer.py:
1459         (Printer.configure):
1460         (Printer._test_line):
1461
1462 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
1463
1464         remove extraneous output in test-webkitpy
1465         https://bugs.webkit.org/show_bug.cgi?id=106971
1466
1467         Reviewed by Ojan Vafai.
1468
1469         We weren't ignoring or capturing the echoed output from
1470         these two tests, and getting noise in the logs as a result.
1471
1472         * Scripts/webkitpy/common/system/executive_unittest.py:
1473         (ExecutiveTest.test_auto_stringify_args):
1474         (ExecutiveTest.test_popen_args):
1475
1476 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
1477
1478         webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer.test_win32_start_and_stop is flaky
1479         https://bugs.webkit.org/show_bug.cgi?id=106974
1480
1481         Reviewed by Ryosuke Niwa.
1482
1483         I forgot to stub out the call to check to ensure that the ports were
1484         available, so this test could fail if something was listening on 8000 or
1485         8443 on the machine.
1486
1487         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1488         (TestHttpServer.test_win32_start_and_stop):
1489
1490 2013-01-15  Levi Weintraub  <leviw@chromium.org>
1491
1492         Unreviewed, rolling out r139792.
1493         http://trac.webkit.org/changeset/139792
1494         https://bugs.webkit.org/show_bug.cgi?id=106970
1495
1496         Broke the windows build.
1497
1498         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1499         (DRTTestRunner::DRTTestRunner):
1500         (DRTTestRunner::notifyDone):
1501         (DRTTestRunner::reset):
1502         (DRTTestRunner::setAlwaysAcceptCookies):
1503         (DRTTestRunner::setWindowIsKey):
1504         (DRTTestRunner::pathToLocalResource):
1505         (DRTTestRunner::setPOSIXLocale):
1506         (InvokeCallbackTask):
1507         (InvokeCallbackTask::InvokeCallbackTask):
1508         (InvokeCallbackTask::runIfValid):
1509         (DRTTestRunner::setBackingScaleFactor):
1510         * DumpRenderTree/chromium/DRTTestRunner.h:
1511         (DRTTestRunner):
1512         (DRTTestRunner::taskList):
1513         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1514         (WebTestRunner::WebTestDelegate::setDatabaseQuota):
1515         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1516         (WebTestRunner::TestRunner::TestRunner):
1517         (WebTestRunner::TestRunner::reset):
1518         (WebTestRunner::TestRunner::setDatabaseQuota):
1519         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1520         (TestRunner):
1521         * DumpRenderTree/chromium/WebViewHost.cpp:
1522         (WebViewHost::setPendingExtraData):
1523         (WebViewHost::setDeviceScaleFactor):
1524         * DumpRenderTree/chromium/WebViewHost.h:
1525         (WebViewHost):
1526
1527 2013-01-15  Ryosuke Niwa  <rniwa@webkit.org>
1528
1529         Build fix after r139357. The port name of MacWK2EWS should be 'mac-wk2'.
1530
1531         * Scripts/webkitpy/common/config/ports.py:
1532         (MacWK2Port):
1533
1534 2013-01-15  Alan Cutter  <alancutter@chromium.org>
1535
1536         Extend sheriffbot's "help" command to be able to get help on individual commands
1537         https://bugs.webkit.org/show_bug.cgi?id=106629
1538
1539         Reviewed by Eric Seidel.
1540
1541         Added a help command to sheriffbot.
1542         Fixed some style issues and ordered the commands alphabetically.
1543
1544         * Scripts/webkitpy/tool/bot/irc_command.py:
1545         (IRCCommand):
1546         (IRCCommand.execute):
1547         (IRCCommand.usage):
1548         (IRCCommand.help):
1549         (CreateBug):
1550         (CreateBug.execute):
1551         (Help):
1552         (Help.execute):
1553         (Help._post_command_help):
1554         (Hi):
1555         (Hi.execute):
1556         (Restart):
1557         (RollChromiumDEPS):
1558         (RollChromiumDEPS._parse_args):
1559         (RollChromiumDEPS._expand_irc_nickname):
1560         (RollChromiumDEPS.execute):
1561         (Rollout):
1562         (Rollout._extract_revisions):
1563         (Rollout.execute):
1564         (Sheriffs):
1565         (Sheriffs.execute):
1566         (Whois):
1567         (Whois.execute):
1568         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1569         (IRCBotTest.test_help):
1570
1571 2013-01-15  Enrica Casucci  <enrica@apple.com>
1572
1573         Add a new set of WebKit2 APIs for text search and
1574         search results management.
1575         https://bugs.webkit.org/show_bug.cgi?id=106834.
1576         <rdar://problem/12597159>
1577
1578         Added new test for the new WebKit2 API for
1579         text search.
1580         
1581         Reviewed by Simon Fraser.
1582
1583         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1584         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm: Added.
1585
1586 2013-01-15  Levi Weintraub  <leviw@chromium.org>
1587
1588         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
1589         https://bugs.webkit.org/show_bug.cgi?id=106904
1590
1591         Reverting 139794. It broke the build. It appears that a header file,
1592         WebTextDirection.h, was left out.
1593
1594         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1595         (DRTTestRunner::DRTTestRunner):
1596         (DRTTestRunner::reset):
1597         * DumpRenderTree/chromium/DRTTestRunner.h:
1598         (DRTTestRunner::setTitleTextDirection):
1599         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1600         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
1601         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1602         (WebTestRunner::TestRunner::TestRunner):
1603         (WebTestRunner::TestRunner::reset):
1604         (WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
1605         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1606         (TestRunner):
1607         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1608         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
1609         * DumpRenderTree/chromium/WebViewHost.cpp:
1610         (WebViewHost::didReceiveTitle):
1611
1612 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
1613
1614         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
1615         https://bugs.webkit.org/show_bug.cgi?id=106904
1616
1617         Reviewed by Adam Barth.
1618
1619         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1620         (DRTTestRunner::DRTTestRunner):
1621         (DRTTestRunner::notifyDone):
1622         (DRTTestRunner::reset):
1623         * DumpRenderTree/chromium/DRTTestRunner.h:
1624         (DRTTestRunner):
1625         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1626         (WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
1627         (WebTestRunner::WebTestDelegate::setFocus):
1628         (WebTestRunner::WebTestDelegate::setAcceptAllCookies):
1629         (WebTestRunner::WebTestDelegate::pathToLocalResource):
1630         (WebTestRunner::WebTestDelegate::setLocale):
1631         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1632         (WebTestRunner::TestRunner::TestRunner):
1633         (WebTestRunner::TestRunner::reset):
1634         (WebTestRunner::TestRunner::setAlwaysAcceptCookies):
1635         (WebTestRunner):
1636         (WebTestRunner::TestRunner::setWindowIsKey):
1637         (WebTestRunner::TestRunner::pathToLocalResource):
1638         (WebTestRunner::TestRunner::setBackingScaleFactor):
1639         (WebTestRunner::TestRunner::setPOSIXLocale):
1640         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1641         (WebTestRunner::TestRunner::taskList):
1642         (TestRunner):
1643         * DumpRenderTree/chromium/WebViewHost.cpp:
1644         (WebViewHost::setDeviceScaleFactor):
1645         (WebViewHost::setFocus):
1646         (WebViewHost::setAcceptAllCookies):
1647         (WebViewHost::pathToLocalResource):
1648         (WebViewHost::setLocale):
1649         * DumpRenderTree/chromium/WebViewHost.h:
1650         (WebViewHost):
1651
1652 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
1653
1654         Tests with WontFix expectation are (indirectly) skipped
1655         https://bugs.webkit.org/show_bug.cgi?id=105860
1656
1657         Reviewed by Dirk Pranke.
1658
1659         Only skip the WontFix expectation if there are no other layout test
1660         expectations (like Failure, ImageOnlyFailure) listed for the test.
1661         This makes it possible to run an expected failure for which there
1662         is no reason or interest to fix. There are some ports that would like
1663         to exercise this behavior as well as specific test cases that should use
1664         such expectations.
1665
1666         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1667         (TestExpectationParser._tokenize_line): Only add the SKIP modifier for a
1668         WONTFIX test if there are no expectations listed. The warning is adjusted
1669         to reflect the new behavior.
1670         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Add
1671         and adjust test cases for these changes.
1672         (ExpectationSyntaxTests.test_wontfix):
1673         (SemanticTests.test_skip_and_wontfix):
1674
1675 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
1676
1677         [chromium] add title text direction attribute to TestRunner
1678         https://bugs.webkit.org/show_bug.cgi?id=106907
1679
1680         Reviewed by Adam Barth.
1681
1682         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1683         (DRTTestRunner::DRTTestRunner):
1684         (DRTTestRunner::reset):
1685         * DumpRenderTree/chromium/DRTTestRunner.h:
1686         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1687         (WebTestRunner::WebTestRunner::setTitleTextDirection):
1688         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1689         (WebTestRunner::TestRunner::TestRunner):
1690         (WebTestRunner::TestRunner::reset):
1691         (WebTestRunner::TestRunner::setTitleTextDirection):
1692         (WebTestRunner):
1693         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1694         (TestRunner):
1695         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1696         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
1697         * DumpRenderTree/chromium/WebViewHost.cpp:
1698         (WebViewHost::didReceiveTitle):
1699
1700 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
1701
1702         nrwt: change the default # of locked shards on chromium_win to 1
1703         https://bugs.webkit.org/show_bug.cgi?id=106938
1704
1705         Reviewed by Eric Seidel.
1706
1707         It looks like LigHTTPd might be buggy or unstable if we are
1708         running multiple http tests in parallel; see
1709         http://code.google.com/p/chromium/issues/detail?id=169530 for more
1710         context as well. This change will stop running http tests in parallel
1711         and we can see if this fixes things.
1712
1713         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1714         (ChromiumWinPort.default_max_locked_shards):
1715         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1716         (ChromiumWinTest.test_path_to_image_diff):
1717         (ChromiumWinTest):
1718         (ChromiumWinTest.test_default_max_locked_shards):
1719
1720 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
1721
1722         [chromium] move WebDatabase related methods to TestRunner library
1723         https://bugs.webkit.org/show_bug.cgi?id=106905
1724
1725         Reviewed by Adam Barth.
1726
1727         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1728         (DRTTestRunner::DRTTestRunner):
1729         (DRTTestRunner::reset):
1730         * DumpRenderTree/chromium/DRTTestRunner.h:
1731         (DRTTestRunner):
1732         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1733         (WebTestRunner::WebTestDelegate::clearAllDatabases):
1734         (WebTestRunner::WebTestDelegate::setDatabaseQuota):
1735         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1736         (WebTestRunner::TestRunner::TestRunner):
1737         (WebTestRunner::TestRunner::reset):
1738         (WebTestRunner::TestRunner::clearAllDatabases):
1739         (WebTestRunner):
1740         (WebTestRunner::TestRunner::setDatabaseQuota):
1741         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1742         (TestRunner):
1743         * DumpRenderTree/chromium/WebViewHost.cpp:
1744         (WebViewHost::clearAllDatabases):
1745         (WebViewHost::setDatabaseQuota):
1746         * DumpRenderTree/chromium/WebViewHost.h:
1747         (WebViewHost):
1748
1749 2013-01-15  Tim 'mithro' Ansell  <mithro@mithis.com>
1750
1751         Renaming CleanWorkingDirectory step to DiscardLocalChanges to make
1752         functionality match the name.
1753         https://bugs.webkit.org/show_bug.cgi?id=106870
1754
1755         Reviewed by Adam Barth.
1756
1757         * Scripts/webkitpy/tool/commands/download.py:
1758         (Clean):
1759         (Update):
1760         (Build):
1761         (BuildAndTest):
1762         (CheckStyle):
1763         (BuildAttachment):
1764         (BuildAndTestAttachment):
1765         (AbstractPatchApplyingCommand):
1766         (ApplyWatchList):
1767         (AbstractPatchLandingCommand):
1768         (CreateRollout):
1769         * Scripts/webkitpy/tool/steps/__init__.py:
1770         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
1771         (CleanWorkingDirectory.options):
1772         (CleanWorkingDirectory.run):
1773         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
1774         * Scripts/webkitpy/tool/steps/discardlocalchanges.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
1775         * Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py.
1776
1777 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
1778
1779         [Autotools] Add support for WebKit2-only builds
1780         https://bugs.webkit.org/show_bug.cgi?id=106889
1781
1782         Reviewed by Gustavo Noronha Silva.
1783
1784         * GNUmakefile.am: Only build the GtkLauncher and DumpRenderTree if building WebKit1.
1785         * Scripts/build-webkit: Pass along the information on whether to build WebKit1 when
1786         building the GTK port through build-webkit.
1787         * Scripts/webkitdirs.pm:
1788         (buildAutotoolsProject): Add the --disable-webkit1 configuration flag to the build
1789         arguments when not building WebKit1.
1790         (buildGtkProject): Pass along the information on whether to build WebKit1 when building
1791         through the Autotools build system.
1792
1793 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
1794
1795         [GTK] Enable Performance Timeline, Resource Timing, Navigation Timing features
1796         https://bugs.webkit.org/show_bug.cgi?id=106197
1797
1798         Reviewed by Martin Robinson.
1799
1800         * Scripts/webkitperl/FeatureList.pm: Add the configuration options for all three
1801         features. Enable them on GTK, meaning they will be enabled in development builds
1802         (i.e. when building with build-webkit).
1803
1804 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
1805
1806         [GTK] Enable CSS Image Resolution feature
1807         https://bugs.webkit.org/show_bug.cgi?id=99038
1808
1809         Reviewed by Gustavo Noronha Silva.
1810
1811         Enable the CSS Image Resolution feature for the development
1812         builds of the GTK port.
1813
1814         * Scripts/webkitperl/FeatureList.pm:
1815
1816 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
1817
1818         [GTK] Stop passing the unstable features flag to configure script when using build-webkit
1819         https://bugs.webkit.org/show_bug.cgi?id=106579
1820
1821         Reviewed by Gustavo Noronha Silva.
1822
1823         The --enable-unstable-features flag is not required to be passed anymore
1824         to the configure script as it was removed in r138252.
1825
1826         * Scripts/webkitdirs.pm:
1827         (buildAutotoolsProject):
1828
1829 2013-01-15  Tony Chang  <tony@chromium.org>
1830
1831         [chromium] Unreviewed, fix a bug where we don't properly shutdown lighttpd.
1832
1833         * Scripts/webkitpy/layout_tests/servers/http_server.py:
1834         (Lighttpd._check_and_kill): Pass /pid so taskkill.exe doesn't error out on us.
1835         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1836         (TestHttpServer.test_win32_start_and_stop):
1837
1838 2013-01-15  Joshua Bell  <jsbell@chromium.org>
1839
1840         Unreviewed. Adding Michael Pruett as contributor.
1841
1842         * Scripts/webkitpy/common/config/committers.py:
1843
1844 2013-01-15  Victor Carbune  <victor@rosedu.org>
1845
1846         Unreviewed. Update my email addresses.
1847
1848         * Scripts/webkitpy/common/config/committers.py:
1849
1850 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
1851
1852         [GTK] Waiting on the gdb process will lead to deadlock
1853         https://bugs.webkit.org/show_bug.cgi?id=106906
1854
1855         Reviewed by Philippe Normand.
1856
1857         Use communicate() rather than wait() on the Popen object that's running the gdb
1858         command. This avoids the deadlock that occurs on the GTK builders.
1859
1860         * Scripts/webkitpy/layout_tests/port/gtk.py:
1861         (GtkPort._get_gdb_output):
1862
1863 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
1864
1865         [GTK] Limit the number of frames printed out when backtracing with gdb
1866         https://bugs.webkit.org/show_bug.cgi?id=106901
1867
1868         Reviewed by Philippe Normand.
1869
1870         Printing an unlimited number of frames when dumping the gdb backtracing
1871         output can cause timeouts in the builders. This patch limits the number
1872         of frames that are printed out to 1024.
1873
1874         * Scripts/webkitpy/layout_tests/port/gtk.py:
1875         (GtkPort._get_gdb_output):
1876
1877 2013-01-15  Andras Becsi  <andras.becsi@digia.com>
1878
1879         [Qt] Fix ImageDiff's image format conversion
1880         https://bugs.webkit.org/show_bug.cgi?id=106880
1881
1882         Reviewed by Csaba Osztrogonác.
1883
1884         Besides actually doing the conversion this also silences the suspicious warning:
1885         "ignoring return value of function declared with warn_unused_result attribute".
1886
1887         * ImageDiff/qt/ImageDiff.cpp:
1888         (main): QImage::convertToFormat, contrary to the assumed behaviour, returns a
1889         copy of the image in the given format and does not alter the image itself.
1890
1891 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
1892
1893         [chromium] move remaining methods that just set a boolean flag to TestRunner library
1894         https://bugs.webkit.org/show_bug.cgi?id=106823
1895
1896         Reviewed by Darin Fisher.
1897
1898         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1899         (DRTTestRunner::DRTTestRunner):
1900         (DRTTestRunner::reset):
1901         * DumpRenderTree/chromium/DRTTestRunner.h:
1902         (DRTTestRunner):
1903         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1904         (WebTestRunner::WebTestRunner::shouldDumpBackForwardList):
1905         (WebTestRunner::WebTestRunner::deferMainResourceDataLoad):
1906         (WebTestRunner::WebTestRunner::shouldDumpSelectionRect):
1907         (WebTestRunner::WebTestRunner::testRepaint):
1908         (WebTestRunner::WebTestRunner::sweepHorizontally):
1909         (WebTestRunner::WebTestRunner::isPrinting):
1910         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
1911         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1912         (WebTestRunner::TestRunner::TestRunner):
1913         (WebTestRunner::TestRunner::reset):
1914         (WebTestRunner::TestRunner::shouldDumpBackForwardList):
1915         (WebTestRunner):
1916         (WebTestRunner::TestRunner::deferMainResourceDataLoad):
1917         (WebTestRunner::TestRunner::shouldDumpSelectionRect):
1918         (WebTestRunner::TestRunner::testRepaint):
1919         (WebTestRunner::TestRunner::sweepHorizontally):
1920         (WebTestRunner::TestRunner::isPrinting):
1921         (WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
1922         (WebTestRunner::TestRunner::dumpBackForwardList):
1923         (WebTestRunner::TestRunner::setDeferMainResourceDataLoad):
1924         (WebTestRunner::TestRunner::dumpSelectionRect):
1925         (WebTestRunner::TestRunner::repaintSweepHorizontally):
1926         (WebTestRunner::TestRunner::setPrinting):
1927         (WebTestRunner::TestRunner::setShouldStayOnPageAfterHandlingBeforeUnload):
1928         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1929         (TestRunner):
1930
1931 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
1932
1933         nrwt: stub out show_results_html for mock ports
1934         https://bugs.webkit.org/show_bug.cgi?id=106848
1935
1936         Reviewed by Ojan Vafai.
1937
1938         We were accidentally using the underlying ports'
1939         show_results_html_file() implementation, which would, unsurprisingly,
1940         fail in many cases (e.g., running mock-efl on the mac).
1941
1942         No test added since we don't generally add tests for the mock
1943         implementation.
1944
1945         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1946         (MockDRTPort.show_results_html_file):
1947
1948 2013-01-14  Tim 'mithro' Ansell  <mithro@mithis.com>
1949
1950         Changing clean_working_directory/clean_local_commits and related
1951         functions to have consistent naming.
1952
1953         https://bugs.webkit.org/show_bug.cgi?id=104198
1954
1955         Reviewed by Adam Barth.
1956
1957         * Scripts/webkitpy/common/checkout/scm/git.py:
1958         * Scripts/webkitpy/common/checkout/scm/scm.py:
1959         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1960         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1961         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
1962         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
1963
1964 2013-01-14  Alan Cutter  <alancutter@chromium.org>
1965
1966         Fix EWS GCE build scripts to detect which zone is available
1967         https://bugs.webkit.org/show_bug.cgi?id=106524
1968
1969         Reviewed by Adam Barth.
1970
1971         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
1972         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
1973         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
1974         * EWSTools/GoogleComputeEngine/findzone.sh: Added.
1975
1976 2013-01-14  Tim 'mithro' Ansell  <mithro@mithis.com>
1977
1978         Adding an error string to AmbiguousCommitError.
1979         https://bugs.webkit.org/show_bug.cgi?id=106846
1980
1981         Reviewed by Adam Barth.
1982
1983         * Scripts/webkitpy/common/checkout/scm/git.py:
1984         (AmbiguousCommitError.__init__):
1985
1986 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
1987
1988         kill whole lighttpd process tree for chromium win
1989         https://bugs.webkit.org/show_bug.cgi?id=106838
1990
1991         Reviewed by Tony Chang.
1992
1993         Land a speculative fix for lighttpd.exe hanging on some chromium bots;
1994         I think a test is causing a httpd server child process to wedge and
1995         killing the parent httpd server process isn't sufficient to ensure
1996         that the children are also killed.
1997
1998         * Scripts/webkitpy/layout_tests/servers/http_server.py:
1999         (Lighttpd._check_and_kill):
2000         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2001         (TestHttpServer.test_start_cmd):
2002         (TestHttpServer):
2003         (TestHttpServer.test_win32_start_and_stop):
2004         (TestHttpServer.test_win32_start_and_stop.wait_for_action):
2005         (TestHttpServer.test_win32_start_and_stop.mock_returns):
2006         (TestHttpServer.test_win32_start_and_stop.mock_returns.return_value_thunk):
2007
2008 2013-01-14  Nico Weber  <thakis@chromium.org>
2009
2010         [chromium] Enable `update-webkit --chromium --ninja` on windows
2011         https://bugs.webkit.org/show_bug.cgi?id=106836
2012
2013         Reviewed by Eric Seidel.
2014
2015         After running this, build-webkit --chromium will use ninja to build.
2016         Apparently there are some minor issues with that still, so it's
2017         not quite ready for use yet.
2018
2019         * Scripts/webkitdirs.pm:
2020         (determineIsChromiumNinja):
2021         (buildChromium):
2022
2023 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
2024
2025         nrwt: use the same search path for baselines and TestExpectations on apple mac
2026         https://bugs.webkit.org/show_bug.cgi?id=105599
2027
2028         Reviewed by Ryosuke Niwa.
2029
2030         Bug 105583 revealed some confusion due to the fact that the Apple
2031         Mac port used a different list of directories to search for baselines
2032         and TestExpectations files (actually, pretty much every port does).
2033
2034         It seems like a good idea to use the same list for both by default, but
2035         making this happen will affect every port in slightly different ways, so
2036         we'll try this on the Apple Mac port first.
2037
2038         Note that the effective changes for this are that:
2039         1) The apple mac port will look in platform/wk2 for baselines where
2040         it didn't before (it will look after looking in mac-wk2 but before
2041         the non-wk2 dirs)
2042         2) The apple mac-snowleopard port will use the expectations in
2043         mac-lion as well as the expectations in mac-snowleopard, although
2044         I'm not even sure if mac-snowleopard is still supported ...
2045
2046         * Scripts/webkitpy/layout_tests/port/mac.py:
2047         (MacPort.default_baseline_search_path):
2048         (MacPort.expectations_files):
2049         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2050         (test_baseline_search_path):
2051
2052 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
2053
2054         AX: Need to implement ColorWellRole
2055         https://bugs.webkit.org/show_bug.cgi?id=106756
2056
2057         Reviewed by Chris Fleizach.
2058
2059         Returns a string representation of the value of a color
2060         when the role is Color Well, to make it easy to write layout
2061         tests for color controls.
2062
2063         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2064
2065 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
2066
2067         Chromium: Error in AccessibilityUIElement::intValueGetterCallback
2068         https://bugs.webkit.org/show_bug.cgi?id=106682
2069
2070         Reviewed by Chris Fleizach.
2071
2072         Modify Chromium's DRT implementation of intValue to return a
2073         different value depending on the role.
2074
2075         There are actually platform-specific differences in what should
2076         be returned in the "value" of an object, so Chromium normally keeps
2077         these separate (i.e. valueForRange, headingLevel, hierarchicalLevel, etc.)
2078         but this is a fine simplification to make cross-platform tests easier.
2079
2080         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2081         (WebTestRunner::AccessibilityUIElement::intValueGetterCallback):
2082
2083 2013-01-14  Jochen Eisinger  <jochen@chromium.org>
2084
2085         [chromium] move remaining methods to dump WebViewClient callbacks to TestRunner library
2086         https://bugs.webkit.org/show_bug.cgi?id=106785
2087
2088         Reviewed by Adam Barth.
2089
2090         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2091         (DRTTestRunner::DRTTestRunner):
2092         (DRTTestRunner::reset):
2093         * DumpRenderTree/chromium/DRTTestRunner.h:
2094         (DRTTestRunner):
2095         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2096         (WebTestProxyBase):
2097         (WebTestRunner::WebTestProxy::setStatusText):
2098         (WebTestRunner::WebTestProxy::didStopLoading):
2099         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2100         (WebTestRunner::WebTestRunner::shouldDumpStatusCallbacks):
2101         (WebTestRunner::WebTestRunner::shouldDumpProgressFinishedCallback):
2102         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2103         (WebTestRunner::TestRunner::TestRunner):
2104         (WebTestRunner::TestRunner::reset):
2105         (WebTestRunner::TestRunner::shouldDumpStatusCallbacks):
2106         (WebTestRunner):
2107         (WebTestRunner::TestRunner::shouldDumpProgressFinishedCallback):
2108         (WebTestRunner::TestRunner::dumpWindowStatusChanges):
2109         (WebTestRunner::TestRunner::dumpProgressFinishedCallback):
2110         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2111         (TestRunner):
2112         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2113         (WebTestRunner::WebTestProxyBase::setStatusText):
2114         (WebTestRunner):
2115         (WebTestRunner::WebTestProxyBase::didStopLoading):
2116         * DumpRenderTree/chromium/WebViewHost.cpp:
2117         (WebViewHost::didStopLoading):
2118         * DumpRenderTree/chromium/WebViewHost.h:
2119         (WebViewHost):
2120
2121 2013-01-14  Andrey Lushnikov  <lushnikov@chromium.org>
2122
2123         Web Inspector: devtools front-end doesn't have focus in TestShell
2124         https://bugs.webkit.org/show_bug.cgi?id=106778
2125
2126         Reviewed by Pavel Feldman.
2127
2128         Focus devTools window after loadURL method.
2129
2130         * DumpRenderTree/chromium/TestShell.cpp:
2131         (TestShell::runFileTest):
2132
2133 2013-01-14  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2134
2135         [EFL][jhbuild] Build the GStreamer-related dependencies with the "configure" script
2136         https://bugs.webkit.org/show_bug.cgi?id=106573
2137
2138         Reviewed by Philippe Normand.
2139
2140         Similarly to what's been described in bug 106569, we're building
2141         from release tarballs, so there's no reason to regenerate the
2142         autoconf-related stuff with autogen.sh, especially since we might
2143         run into trouble with automake 1.13 and deprecated macros.
2144
2145         * efl/jhbuild.modules:
2146
2147 2013-01-14  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
2148
2149         [Qt] The Qt's configuration isn't honoured regarding the use of the system libpng and libjpeg
2150         https://bugs.webkit.org/show_bug.cgi?id=104909
2151
2152         Reviewed by Simon Hausmann.
2153
2154         To be able to build redistribuable binary packages, Qt's configure switches
2155         -qt-libpng and -qt-libjpeg are used to avoid having the binaries trying to
2156         dynamically link to optional system libraries.
2157         QtWebKit is doing its own configure checks for those libraries, thus adding a
2158         runtime dependency that might not be fulfilled if the packager's machine had
2159         those libraries while the user's machine won't.
2160
2161         Since in most cases where WebKit will want to use those system libraries, Qt will
2162         also be using them, remove these configure tests from WebKit.
2163
2164         * qmake/config.tests/libjpeg/libjpeg.cpp: Removed.
2165         * qmake/config.tests/libjpeg/libjpeg.pro: Removed.
2166         * qmake/config.tests/libpng/libpng.cpp: Removed.
2167         * qmake/config.tests/libpng/libpng.pro: Removed.
2168         * qmake/mkspecs/features/features.prf:
2169
2170 2013-01-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2171
2172         [EFL][jhbuild] Bump the EFL dependencies in jhbuild to 1.7.5.
2173         https://bugs.webkit.org/show_bug.cgi?id=106574
2174
2175         Reviewed by Laszlo Gombos.
2176
2177         Rely on a more recent stable release, which includes support for
2178         Lua 5.2 in Edje and other assorted minor fixes.
2179
2180         While here, also use the "configure" script to build the libraries
2181         instead of relying on autogen.sh, which is not really needed with
2182         a release tarball and may have problems with automake 1.13.
2183
2184         * efl/jhbuild.modules:
2185
2186 2013-01-14  Andrey Lushnikov  <lushnikov@chromium.org>
2187
2188         Web Inspector: fix DRT to deliver simulated events to devtools front-end
2189         https://bugs.webkit.org/show_bug.cgi?id=106650
2190
2191         Reviewed by Pavel Feldman.
2192
2193         Add separated m_devToolsTestInterfaces object to testShell which is
2194         bind to devTools webview.
2195
2196         * DumpRenderTree/chromium/TestShell.cpp:
2197         (TestShell::initialize):
2198         (TestShell::createMainWindow):
2199         (TestShell::~TestShell):
2200         (TestShell::showDevTools):
2201         (TestShell::resetTestController):
2202         (TestShell::bindJSObjectsToWindow):
2203         (TestShell::createNewWindow):
2204         * DumpRenderTree/chromium/TestShell.h:
2205         (TestShell):
2206
2207 2013-01-14  Alan Cutter  <alancutter@chromium.org>
2208
2209         Sheriffbot command aliases need test cases
2210         https://bugs.webkit.org/show_bug.cgi?id=106754
2211
2212         Reviewed by Eric Seidel.
2213
2214         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2215         (SheriffBotTest.test_command_aliases):
2216
2217 2013-01-13  Alan Cutter  <alancutter@chromium.org>
2218
2219         Allow users to misspell the "sheriffs" command in sheriffbot
2220         https://bugs.webkit.org/show_bug.cgi?id=106628
2221
2222         Reviewed by Steve Block.
2223
2224         * Scripts/webkitpy/tool/bot/irc_command.py:
2225
2226 2013-01-13  Alan Cutter  <alancutter@chromium.org>
2227
2228         Make "gardeners" an alias for "sheriffs" in sherrifbot
2229         https://bugs.webkit.org/show_bug.cgi?id=106627
2230
2231         Reviewed by Eric Seidel.
2232
2233         * Scripts/webkitpy/tool/bot/irc_command.py:
2234
2235 2013-01-13  Dirk Pranke  <dpranke@chromium.org>
2236
2237         [chromium] webkitpy-test: executive.py stringify_args error on the release test bot
2238         https://bugs.webkit.org/show_bug.cgi?id=105380
2239
2240         Reviewed by Eric Seidel.
2241
2242         Fix a regression introduced in r137692 where we were double-encoding
2243         the arguments to popen(); this was only an issue on windows, where
2244         we would try to encode something to mbcs, then try to encode it
2245         to unicode as if the input as ascii.
2246
2247         * Scripts/webkitpy/common/system/executive.py:
2248         (Executive.run_command):
2249
2250 2013-01-13  Alan Cutter  <alancutter@chromium.org>
2251
2252         State who told sheriffbot to roll the Chromium deps and to what revision
2253         https://bugs.webkit.org/show_bug.cgi?id=106626
2254
2255         Reviewed by Eric Seidel.
2256
2257         Added optional argument to post-chromium-deps-roll so Sheriffbot can specify ChangeLog message.
2258
2259         * Scripts/webkitpy/tool/bot/irc_command.py:
2260         (RollChromiumDEPS._expand_irc_nickname):
2261         (RollChromiumDEPS.execute):
2262         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2263         (IRCCommandTest.test_roll_chromium_deps):
2264         * Scripts/webkitpy/tool/bot/sheriff.py:
2265         (Sheriff.post_chromium_deps_roll):
2266         * Scripts/webkitpy/tool/commands/roll.py:
2267         (RollChromiumDEPS._prepare_state):
2268         (PostChromiumDEPSRoll):
2269         (PostChromiumDEPSRoll._prepare_state):
2270         * Scripts/webkitpy/tool/commands/roll_unittest.py:
2271         (PostRollCommandsTest.test_prepare_state):
2272         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
2273         (PrepareChangeLogForDEPSRoll.run):
2274
2275 2013-01-13  Alan Cutter  <alancutter@chromium.org>
2276
2277         Add Alan Cutter as contributor
2278         https://bugs.webkit.org/show_bug.cgi?id=106747
2279
2280         Reviewed by Eric Seidel.
2281
2282         * Scripts/webkitpy/common/config/committers.py:
2283
2284 2013-01-13  Jonathan Liu  <net147@gmail.com>
2285
2286         Fix CONFIG missing link_pkgconfig on Windows
2287         https://bugs.webkit.org/show_bug.cgi?id=106647
2288
2289         Some libraries (e.g. libxslt, libxml2 and sqlite3) fail to link
2290         properly on Windows because they are added to PKGCONFIG but
2291         CONFIG does not contain link_pkgconfig.
2292
2293         This is because link_pkgconfig is added in unix/default_pre.prf
2294         which is only used for UNIX platforms. To fix this, move it to
2295         the general default_pre.prf.
2296
2297         Reviewed by Simon Hausmann.
2298
2299         * qmake/mkspecs/features/default_pre.prf:
2300         * qmake/mkspecs/features/unix/default_pre.prf:
2301
2302 2013-01-12  Nico Weber  <thakis@chromium.org>
2303
2304         nrwt/chromium: Don't prefer chromium over webkit build directories
2305         https://bugs.webkit.org/show_bug.cgi?id=105597
2306
2307         Reviewed by Dirk Pranke.
2308
2309         Rely on the new timestamp logic instead. Requested by dpranke in
2310         https://bugs.webkit.org/show_bug.cgi?id=105498
2311
2312         * Scripts/webkitpy/layout_tests/port/chromium.py:
2313         (ChromiumPort._static_build_path):
2314         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2315         (ChromiumLinuxPortTest.test_build_path):
2316         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2317         (ChromiumMacPortTest.test_build_path):
2318         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2319         (ChromiumWinTest.test_build_path):
2320
2321 2013-01-12  Nico Weber  <thakis@chromium.org>
2322
2323         Use ninja by default on Linux for build-webkit --chromium, bot edition
2324         https://bugs.webkit.org/show_bug.cgi?id=104434
2325
2326         Reviewed by Eric Seidel.
2327
2328         r139557 changed update-webkit to pick ninja by default on linux, but
2329         the bots run update-webkit-chromium directly so they didn't see this.
2330         Move the default for ninja into update-webkit-chromium so that it's
2331         picked up by the bots, and let update-webkit forward non-default
2332         options to there.
2333
2334         This way, the default is in one place only and both developers (who
2335         usually use update-webkit which then shells out to
2336         updat-webkit-chromium) and bots (which use update-webkit-chromium
2337         directly) see the same behavior.
2338
2339         * Scripts/update-webkit:
2340         * Scripts/update-webkit-chromium:
2341
2342 2013-01-12  Nico Weber  <thakis@chromium.org>
2343
2344         Make ninja the default build system on Linux for build-webkit --chromium
2345         https://bugs.webkit.org/show_bug.cgi?id=104434
2346
2347         Reviewed by Eric Seidel.
2348
2349         * Scripts/update-webkit:
2350
2351 2013-01-12  Alan Cutter  <alancutter@chromium.org>
2352
2353         Migrate the remaining bots in EC2 to Google Compute Engine
2354         https://bugs.webkit.org/show_bug.cgi?id=106005
2355
2356         Reviewed by Eric Seidel.
2357
2358         Updated bot scripts for launching feeder-queue, style-queue and sheriffbot on GCE.
2359
2360         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh: Copied from Tools/EWSTools/build-repo.sh.
2361         * EWSTools/boot.sh:
2362         * EWSTools/build-repo.sh:
2363         * EWSTools/start-queue.sh:
2364
2365 2013-01-12  Jochen Eisinger  <jochen@chromium.org>
2366
2367         [chromium] move inspector related methods to TestRunner library
2368         https://bugs.webkit.org/show_bug.cgi?id=106654
2369
2370         Reviewed by Adam Barth.
2371
2372         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2373         (DRTTestRunner::DRTTestRunner):
2374         * DumpRenderTree/chromium/DRTTestRunner.h:
2375         (DRTTestRunner):
2376         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2377         (WebTestRunner::WebTestDelegate::showDevTools):
2378         (WebTestRunner::WebTestDelegate::closeDevTools):
2379         (WebTestRunner::WebTestDelegate::evaluateInWebInspector):
2380         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2381         (WebTestRunner::TestRunner::TestRunner):
2382         (WebTestRunner::TestRunner::showWebInspector):
2383         (WebTestRunner):
2384         (WebTestRunner::TestRunner::closeWebInspector):
2385         (WebTestRunner::TestRunner::evaluateInWebInspector):
2386         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2387         (TestRunner):
2388         * DumpRenderTree/chromium/WebViewHost.cpp:
2389         (WebViewHost::showDevTools):
2390         (WebViewHost::closeDevTools):
2391         (WebViewHost::evaluateInWebInspector):
2392         * DumpRenderTree/chromium/WebViewHost.h:
2393         (WebViewHost):
2394
2395 2013-01-11  Julie Parent  <jparent@chromium.org>
2396
2397         Builder should not be a valid parameter for stats dashboard
2398         https://bugs.webkit.org/show_bug.cgi?id=106698
2399
2400         Reviewed by Dirk Pranke.
2401         
2402         Since builder is a dashboard specific parameter, dashboard_base
2403         should not be handling it in handleValidHashParameterWrapper, rather,
2404         each specific dashboard should in its handleValidHashParameter function.
2405     
2406         Note that the FIXME in dashboard_base about this was actually wrong -
2407         we don't want to move it to g_crossDashboardState, because it isn't
2408         actually cross dashboard state.
2409         
2410         In fact, flakiness and treemap have the code in 
2411         handleValidHashParameter, but it is currently dead code because 
2412         dashboard_base gets to it first.
2413         
2414         Added the proper handling to timeline_explorer, since builder is
2415         valid there.
2416
2417         * TestResultServer/static-dashboards/dashboard_base.js:
2418         * TestResultServer/static-dashboards/timeline_explorer.html:
2419
2420 2013-01-11  Ryosuke Niwa  <rniwa@webkit.org>
2421
2422         REGRESSION: buildbot mangles error messages with timestamps run-webkit-tests outputs
2423         https://bugs.webkit.org/show_bug.cgi?id=106688
2424
2425         Reviewed by Eric Seidel.
2426
2427         Update the regular expression used to strip the garbage at the beginning.
2428
2429         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2430         (RunWebKitTests.nrwt_log_message_regexp):
2431
2432 2013-01-11  Pratik Solanki  <psolanki@apple.com>
2433
2434         TestRunner leaks when running tests
2435         https://bugs.webkit.org/show_bug.cgi?id=106683
2436
2437         Reviewed by Simon Fraser.
2438
2439         Remove extra ref() that we missed out on deleting when refactoring window.layoutTestController
2440         to window.testRunner in r124705. This caused the TestRunner object to be leaked when running
2441         tests.
2442
2443         * DumpRenderTree/TestRunner.cpp:
2444         (TestRunner::makeWindowObject):
2445
2446 2013-01-11  Julie Parent  <jparent@chromium.org>
2447
2448         Dashboard Cleanup: Add isLoadingComplete to the loader.Loader object.
2449         https://bugs.webkit.org/show_bug.cgi?id=106247
2450
2451         Old code nulled out the loader instance when it completed loading and
2452         then later used the fact that it was null to determine if it had loaded
2453         or not.  This is not only unintuitive, but it also prevents using the
2454         loader object later on.
2455         
2456         Added new method, used it, added unit test for it.
2457         
2458         Reviewed by Dirk Pranke.
2459
2460         * TestResultServer/static-dashboards/dashboard_base.js:
2461         (resourceLoadingComplete):
2462         (handleLocationChange):
2463         * TestResultServer/static-dashboards/loader.js:
2464         (.):
2465         * TestResultServer/static-dashboards/loader_unittests.js:
2466
2467 2013-01-11  Ryosuke Niwa  <rniwa@webkit.org>
2468
2469         Try CRLF to LF change in r139407 again.
2470
2471         * BuildSlaveSupport/delete-stale-build-files:
2472         (main):
2473         (webkitBuildDirectory):
2474         * BuildSlaveSupport/kill-old-processes:
2475         (main):
2476
2477 2013-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2478
2479         [GTK] Disable the unit tests timeout when running from make check
2480         https://bugs.webkit.org/show_bug.cgi?id=106670
2481
2482         Reviewed by Philippe Normand.
2483
2484         * GNUmakefile.am: Pass --timeout=-1 to run-gtk-test.
2485
2486 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2487
2488         Yet another unreviewed fix after r139431.
2489
2490         * Scripts/run-launcher: Pass the arguments to `jhbuild-wrapper' in
2491         the correct order.
2492
2493 2013-01-11  Dan Carney  <dcarney@google.com>
2494
2495         [chromium] move some whitespace and resize related methods to TestRunner library
2496         https://bugs.webkit.org/show_bug.cgi?id=106655
2497
2498         Reviewed by Jochen Eisinger.
2499
2500         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2501         (DRTTestRunner::DRTTestRunner):
2502         * DumpRenderTree/chromium/DRTTestRunner.h:
2503         (DRTTestRunner):
2504         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2505         (WebKit):
2506         (WebTestRunner::WebTestDelegate::setClientWindowRect):
2507         (WebTestRunner::WebTestDelegate::setSelectTrailingWhitespaceEnabled):
2508         (WebTestRunner::WebTestDelegate::setSmartInsertDeleteEnabled):
2509         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2510         (WebTestRunner::TestRunner::TestRunner):
2511         (WebTestRunner::TestRunner::setSmartInsertDeleteEnabled):
2512         (WebTestRunner):
2513         (WebTestRunner::TestRunner::setSelectTrailingWhitespaceEnabled):
2514         (WebTestRunner::TestRunner::enableAutoResizeMode):
2515         (WebTestRunner::TestRunner::disableAutoResizeMode):
2516         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2517         (TestRunner):
2518         * DumpRenderTree/chromium/WebViewHost.cpp:
2519         (WebViewHost::setClientWindowRect):
2520         * DumpRenderTree/chromium/WebViewHost.h:
2521         (WebViewHost):
2522
2523 2013-01-11  Mario Sanchez Prada  <mario.prada@samsung.com>
2524
2525         Unreviewed. Update my e-mail addresses.
2526
2527         * Scripts/webkitpy/common/config/committers.py:
2528
2529 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2530
2531         Another unreviewed fix after r139431.
2532
2533         In a way, this is also a generic bug fix, since previously isEfl()
2534         would fail when called from run-efl-tests and we thus did not use
2535         jhbuild to run our tests. This now resulted in us calling
2536         "jhbuild-wrapper run" without specifying a platform.
2537
2538         * Scripts/run-efl-tests: Pass "--efl" to ARGV manually for isEfl()
2539         to work.
2540
2541 2013-01-11  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2542
2543         [Qt][WK1] Web Audio support
2544         https://bugs.webkit.org/show_bug.cgi?id=106651
2545
2546         Reviewed by Jocelyn Turcotte.
2547
2548         Implements support for dumping audio data in DumpRenderTree.
2549
2550         Adds WebAudio to toggleable features in QtTestBrowser.
2551
2552         Enables LEGACY_WEB_AUDIO. This feature is required for 2/3 of the web audio regression tests. It is enabled by default
2553         because it has no effect when WEB_AUDIO is not enabled. This combination matches the settings in FeatureList.pm.
2554
2555         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2556         (WebCore::DumpRenderTree::dump):
2557         * DumpRenderTree/qt/TestRunnerQt.cpp:
2558         (TestRunner::reset):
2559         (TestRunner::overridePreference):
2560         (TestRunner::setAudioData):
2561         * DumpRenderTree/qt/TestRunnerQt.h:
2562         (TestRunner::shouldDumpAsAudio):
2563         (TestRunner::audioData):
2564         (TestRunner):
2565         * QtTestBrowser/launcherwindow.cpp:
2566         (LauncherWindow::applyPrefs):
2567         (LauncherWindow::createChrome):
2568         (LauncherWindow::toggleWebAudio):
2569         * QtTestBrowser/launcherwindow.h:
2570         (WindowOptions::WindowOptions):
2571         (WindowOptions):
2572         (LauncherWindow):
2573         * qmake/mkspecs/features/features.prf:
2574         * qmake/mkspecs/features/features.pri:
2575
2576 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2577
2578         Unreviewed jhbuild-related fix after r139431.
2579
2580         * Scripts/webkitpy/layout_tests/port/efl.py:
2581         (EflPort.__init__): Pass a string to set_option_default(), since
2582         shlex.split() will be called on it later.
2583
2584 2013-01-11  Csaba Osztrogonác  <ossy@webkit.org>
2585
2586         Unreviewed typo fixes after r139431.
2587
2588         * Scripts/run-javascriptcore-tests:
2589
2590 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2591
2592         [jhbuild] Remove the "run-with-jhbuild" scripts.
2593         https://bugs.webkit.org/show_bug.cgi?id=106572
2594
2595         Reviewed by Martin Robinson.
2596
2597         Both ports which use jhbuild were mostly duplicating the
2598         `run-with-jhbuild' script in their own directories for no clear reason.
2599
2600         The script itself was just a thin wrapper around the `jhbuild-wrapper',
2601         so just start using that directly and get rid of a useless middle man.
2602
2603         Adjust scripts which called run-with-jhbuild to call jhbuild-wrapper
2604         instead.
2605
2606         * Scripts/run-javascriptcore-tests:
2607         * Scripts/run-launcher:
2608         * Scripts/webkitdirs.pm:
2609         (runAutogenForAutotoolsProjectIfNecessary):
2610         (buildAutotoolsProject):
2611         (jhbuildWrapperPrefixIfNeeded):
2612         (generateBuildSystemFromCMakeProject):
2613         (buildCMakeGeneratedProject):
2614         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
2615         (run):
2616         * Scripts/webkitpy/layout_tests/port/efl.py:
2617         (EflPort.__init__):
2618         (EflPort._image_diff_command):
2619         * efl/run-with-jhbuild: Removed.
2620         * gtk/run-with-jhbuild: Removed.
2621
2622 2013-01-11  Alan Cutter  <alancutter@chromium.org>
2623
2624         Allow arbitrary queue launch parameters in EWSTools/start-queue.sh
2625         https://bugs.webkit.org/show_bug.cgi?id=106636
2626
2627         Reviewed by Adam Barth.
2628
2629         This parameter will allow the bot boot script to use start-queue.sh and provide an IRC password for sheriffbot.
2630
2631         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
2632         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
2633         * EWSTools/screen-config:
2634         * EWSTools/start-queue.sh:
2635
2636 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
2637
2638         kill-old-processes and delete-stale-build-files use CRLF linebreaks
2639         https://bugs.webkit.org/show_bug.cgi?id=106622
2640
2641         Reviewed by Simon Fraser.
2642
2643         Use LF instead of CRLF in kill-old-processes and delete-stale-build-files.
2644         Also escape clang\+\+ correctly in kill-old-processes.
2645
2646         * BuildSlaveSupport/delete-stale-build-files:
2647         * BuildSlaveSupport/kill-old-processes:
2648
2649 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
2650
2651         Build fix after r139357. It was missing a comma.
2652
2653         * QueueStatusServer/model/queues.py:
2654         (Queue):
2655
2656 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
2657
2658         Fixing AuthenticationError when running test-webkitpy as a non-committer.
2659         https://bugs.webkit.org/show_bug.cgi?id=106420
2660
2661         Reviewed by Eric Seidel.
2662
2663         * Scripts/webkitpy/common/checkout/scm/git.py:
2664         (Git.push_local_commits_to_server):
2665         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2666         * Scripts/webkitpy/common/checkout/scm/svn.py:
2667         (SVNRepository):
2668         (SVNRepository.has_authorization_for_realm):
2669
2670 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
2671
2672         [EFL][jhbuild] Use tarballs for gstreamer instead of git
2673         https://bugs.webkit.org/show_bug.cgi?id=106552
2674
2675         Reviewed by Laszlo Gombos.
2676
2677         Use tarballs for gstreamer instead of git in EFL's jhbuild
2678         to work around intermittent network issues on our build
2679         bots. Tarballs are fully cached and require no network
2680         operation if their checksum matches.
2681
2682         * efl/jhbuild.modules:
2683
2684 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
2685
2686         Add Mac WK2 EWS bots
2687         https://bugs.webkit.org/show_bug.cgi?id=106590
2688
2689         Reviewed by Adam Barth.
2690
2691         Added MacWK2EWS, and made myself a watcher for MacEWS and MacWK2EWS.
2692         Also add a deprecated MacWK2Port class.
2693
2694         * QueueStatusServer/model/queues.py:
2695         (Queue):
2696         * Scripts/webkitpy/common/config/ports.py:
2697         (DeprecatedPort.port):
2698         (MacWK2Port):
2699         (MacWK2Port.run_webkit_tests_command):
2700         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2701         (MacEWS):
2702         (MacWK2EWS):
2703         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2704         (_test_ewses):
2705
2706 2013-01-10  Dan Carney  <dcarney@google.com>
2707
2708         [chromium] move webpermissionclient related methods to TestRunner library
2709         https://bugs.webkit.org/show_bug.cgi?id=106548
2710
2711         Reviewed by Jochen Eisinger.
2712
2713         * DumpRenderTree/DumpRenderTree.gypi:
2714         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2715         (DRTTestRunner::DRTTestRunner):
2716         (DRTTestRunner::reset):
2717         * DumpRenderTree/chromium/DRTTestRunner.h:
2718         (DRTTestRunner):
2719         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2720         (WebTestRunner::WebTestDelegate::normalizeLayoutTestURL):
2721         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2722         (WebKit):
2723         (WebTestRunner::WebTestRunner::webPermissions):
2724         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2725         (WebTestRunner::TestRunner::TestRunner):
2726         (WebTestRunner::TestRunner::setDelegate):
2727         (WebTestRunner):
2728         (WebTestRunner::TestRunner::reset):
2729         (WebTestRunner::TestRunner::webPermissions):
2730         (WebTestRunner::TestRunner::dumpPermissionClientCallbacks):
2731         (WebTestRunner::TestRunner::setImagesAllowed):
2732         (WebTestRunner::TestRunner::setScriptsAllowed):
2733         (WebTestRunner::TestRunner::setStorageAllowed):
2734         (WebTestRunner::TestRunner::setPluginsAllowed):
2735         (WebTestRunner::TestRunner::setAllowDisplayOfInsecureContent):
2736         (WebTestRunner::TestRunner::setAllowRunningOfInsecureContent):
2737         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2738         (WebTestRunner):
2739         (TestRunner):
2740         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.cpp.
2741         (WebTestRunner):
2742         (WebTestRunner::WebPermissions::WebPermissions):
2743         (WebTestRunner::WebPermissions::~WebPermissions):
2744         (WebTestRunner::WebPermissions::allowImage):
2745         (WebTestRunner::WebPermissions::allowScriptFromSource):
2746         (WebTestRunner::WebPermissions::allowStorage):
2747         (WebTestRunner::WebPermissions::allowPlugins):
2748         (WebTestRunner::WebPermissions::allowDisplayingInsecureContent):
2749         (WebTestRunner::WebPermissions::allowRunningInsecureContent):
2750         (WebTestRunner::WebPermissions::setImagesAllowed):
2751         (WebTestRunner::WebPermissions::setScriptsAllowed):
2752         (WebTestRunner::WebPermissions::setStorageAllowed):
2753         (WebTestRunner::WebPermissions::setPluginsAllowed):
2754         (WebTestRunner::WebPermissions::setDisplayingInsecureContentAllowed):
2755         (WebTestRunner::WebPermissions::setRunningInsecureContentAllowed):
2756         (WebTestRunner::WebPermissions::setDelegate):
2757         (WebTestRunner::WebPermissions::setDumpCallbacks):
2758         (WebTestRunner::WebPermissions::reset):
2759         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.h.
2760         (WebTestRunner):
2761         (WebPermissions):
2762         * DumpRenderTree/chromium/TestShell.cpp:
2763         (TestShell::initialize):
2764         (TestShell::resetTestController):
2765         (TestShell::createNewWindow):
2766         * DumpRenderTree/chromium/TestShell.h:
2767         (TestShell):
2768         * DumpRenderTree/chromium/WebViewHost.cpp:
2769         (WebViewHost::normalizeLayoutTestURL):
2770         * DumpRenderTree/chromium/WebViewHost.h:
2771         (WebViewHost):
2772
2773 2013-01-10  Alan Cutter  <alancutter@chromium.org>
2774
2775         Split EWS tool cold-boot.sh into modular components
2776         https://bugs.webkit.org/show_bug.cgi?id=106527
2777
2778         Reviewed by Adam Barth.
2779
2780         Split cold-boot.sh script up into build-vm.sh, build-repo.sh and build-boot-cmd.sh.
2781         Updated GCE bot build scripts to match.
2782         Unable to test scripts directly as they depend on being in the repository to work!
2783
2784         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
2785         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
2786         * EWSTools/build-boot-cmd.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-chromium-ews.sh.
2787         * EWSTools/build-repo.sh: Copied from Tools/EWSTools/cold-boot.sh.
2788         * EWSTools/build-vm.sh: Renamed from Tools/EWSTools/cold-boot.sh.
2789
2790 2013-01-10  Julie Parent  <jparent@chromium.org>
2791
2792         Dashboard Cleanup: Do not generate the page if we are about to reload.
2793         https://bugs.webkit.org/show_bug.cgi?id=106584
2794
2795         Reviewed by Dirk Pranke.
2796
2797         Move the logic to determine if we should generate the page into
2798         parseParameters() since that is where we have the knowledge to
2799         determine it, and return that value to handleLocationChange, 
2800         rather than passing the changed parameters back to handleLocationChange
2801         and having it make the decision.
2802         
2803         This is logically equivalent, save one case: when we are about to do
2804         a reload, we know that there is no reason to generate the page.  Old
2805         code was causing an extra page generation in this case.
2806         
2807         * TestResultServer/static-dashboards/dashboard_base.js:
2808         (parseParameters):
2809         (handleLocationChange):
2810
2811 2013-01-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2812
2813         [jhbuild] Use the "configure" script to build glib
2814         https://bugs.webkit.org/show_bug.cgi?id=106569
2815
2816         Reviewed by Martin Robinson.
2817
2818         So far both EFL and GTK have been using autogen.sh to build glib.
2819         While that does work most of the time, it's not really needed since
2820         we are downloading and building stable releases from tarballs.
2821         Additionally, autogen.sh fails to work with automake 1.13 due to the
2822         usage of some macros that have been removed (this has already been
2823         fixed in glib master).
2824
2825         * efl/jhbuild.modules:
2826         * gtk/jhbuild.modules:
2827
2828 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
2829
2830         Changing tests to be consistent and use self.scm rather then recreating the scm object.
2831         (Missed a couple)
2832         https://bugs.webkit.org/show_bug.cgi?id=106536
2833
2834         Reviewed by Eric Seidel.
2835
2836         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2837
2838 2013-01-10  Tony Chang  <tony@chromium.org>
2839
2840         Speed up supplemental dependency computation
2841         https://bugs.webkit.org/show_bug.cgi?id=106503
2842
2843         Reviewed by Adam Barth.
2844
2845         Pass the IDL attributes file for generating the bindings in WebKitTestRunner.
2846
2847         * WebKitTestRunner/CMakeLists.txt:
2848
2849 2013-01-10  Zan Dobersek  <zandobersek@gmail.com>
2850
2851         Remove the ENABLE_ANIMATION_API feature define occurences
2852         https://bugs.webkit.org/show_bug.cgi?id=106544
2853
2854         Reviewed by Simon Fraser.
2855
2856         The Animation API code was removed in r137243. The ENABLE_ANIMATION_API
2857         feature define handling still lingers in various build systems and configurations
2858         but is of no use, so it should be removed.
2859
2860         * Scripts/webkitperl/FeatureList.pm:
2861         * qmake/mkspecs/features/features.pri:
2862
2863 2013-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
2864
2865         [GTK] Add support for loading web process extensions
2866         https://bugs.webkit.org/show_bug.cgi?id=105631
2867
2868         Reviewed by Gustavo Noronha Silva.
2869
2870         * MiniBrowser/gtk/GNUmakefile.am:
2871         * MiniBrowser/gtk/main.c:
2872         (main): Set WEBKIT_INJECTED_BUNDLE env var to use the injected
2873         bundle lib from build dir.
2874         * Scripts/webkitpy/style/checker.py: Add exceptions for GTK+ API
2875         located in WebProcess/InjectedBundle/API/gtk.
2876         * gtk/generate-gtkdoc:
2877         (get_webkit2_options): Scan also files in
2878         WebProcess/InjectedBundle/API/gtk to generate API docs.
2879         (get_webkit2_options.injected_bundle_src_path): Helper function to
2880         build paths in WebProcess/InjectedBundle/API/gtk.
2881
2882 2013-01-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2883
2884         [EFL][WK2] Writing immediately to created windows (open) fails
2885         https://bugs.webkit.org/show_bug.cgi?id=105276
2886
2887         Reviewed by Kenneth Rohde Christiansen.
2888
2889         Do not reset 'about:blank' url for the new pages in mini browser.
2890
2891         * MiniBrowser/efl/main.c:
2892         (window_create):
2893
2894 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
2895
2896         Changing tests to be consistent and use self.scm rather then recreating the scm object.
2897         https://bugs.webkit.org/show_bug.cgi?id=106536
2898
2899         Reviewed by Eric Seidel.
2900
2901         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2902
2903 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
2904
2905         Converting to unittest2 so we can use assertItemsEqual, making tests
2906         not dependent on order of items.
2907         https://bugs.webkit.org/show_bug.cgi?id=106532
2908
2909         Before:
2910         Ran 1733 tests in 38.385s
2911         FAILED (failures=1, errors=22)
2912
2913         After:
2914         Ran 1733 tests in 32.298s
2915         FAILED (failures=0, errors=22)
2916
2917         Reviewed by Eric Seidel.
2918
2919         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2920         * Scripts/webkitpy/thirdparty/__init__.py:
2921         (AutoinstallImportHook._install_unittest2):
2922
2923 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
2924
2925         [EFL] Add gstreamer 1.0.5 to jhbuild
2926         https://bugs.webkit.org/show_bug.cgi?id=106178
2927
2928         Reviewed by Laszlo Gombos.
2929
2930         Add gstreamer 1.0.5 to EFL's jhbuild configuration.
2931
2932         * efl/jhbuild.modules:
2933
2934 2013-01-09  Alan Cutter  <alancutter@chromium.org>
2935
2936         Updated parameters in GCE build scripts so they now work.
2937         https://bugs.webkit.org/show_bug.cgi?id=106523
2938
2939         Reviewed by Adam Barth.
2940
2941         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
2942         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
2943         * EWSTools/cold-boot.sh:
2944
2945 2013-01-09  Mark Pilgrim  <pilgrim@chromium.org>
2946
2947         [Chromium] Remove some stray references to WebKitPlatformSupport.h in DumpRenderTree
2948         https://bugs.webkit.org/show_bug.cgi?id=106520
2949
2950         Reviewed by James Robinson.
2951
2952         Part of a larger refactoring series. See tracking bug 82948.
2953
2954         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2955         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2956
2957 2013-01-09  Julie Parent  <jparent@chromium.org>
2958
2959         Dashboard cleanup: Remove code for currentState and window.location.hash getting out of state
2960         https://bugs.webkit.org/show_bug.cgi?id=106514
2961
2962         This is old code, as these can no longer get out of sync.
2963         permmaLinkURLHash is generated from currentState, which is set only
2964         from the location.  The commment about how these can get out of sync
2965         refers to a function that no longer exists.
2966         
2967         Reviewed by Dirk Pranke.
2968
2969         * TestResultServer/static-dashboards/dashboard_base.js:
2970         (handleLocationChange):
2971
2972 2013-01-09  Julie Parent  <jparent@chromium.org>
2973
2974         Dashboard Cleanup: Reload the page as soon as we know we need to.
2975         https://bugs.webkit.org/show_bug.cgi?id=106515
2976
2977         No need to continue parsing all of the data once we know that
2978         we need to do a reload.
2979         
2980         Reviewed by Dirk Pranke.
2981
2982         * TestResultServer/static-dashboards/dashboard_base.js:
2983         (parseParameters):
2984
2985 2013-01-09  Eric Seidel  <eric@webkit.org>
2986
2987         run-perf-tests --chromium-android --profile should show symbols for the kernel
2988         https://bugs.webkit.org/show_bug.cgi?id=106498
2989
2990         Reviewed by Adam Barth.
2991
2992         Turns out this was easy, once I finally read the output from "perf report".
2993         It appears there may be a bug in "perf record" on android, as it complains
2994         about not being able to read from /proc/kallsyms even when
2995         /proc/sys/kernel/kptr_restrict is 0.  For now I've not bothered
2996         to keep /proc/sys/kernel/kptr_restrict as 0 during the actual record
2997         but rather just flip it to 0 long enough to grab the /proc/kallsyms
2998         and then flip it back to whatever the device had.
2999
3000         /proc/sys/kernel/kptr_restrict controls what /proc/kallsyms returns
3001         on Linux.  /proc/kallsyms contains a mapping of kernel addresses
3002         to symbol names.  Its world-readable, but will return all 0s if you
3003         don't have permission to see the kernel symbols.  kptr_restrict
3004         supports values 0, 1, 2.  Where 0 means "everyone can see the real symbols"
3005         1 is only a specific group, and 2 is "no one, not even root".
3006         By default kptr_restrict is 2 on Android it seems.
3007         More kptr_restrict docs: http://lwn.net/Articles/420403/
3008
3009         I also took this opportunity to clean up how the perf record command
3010         was built for use/display in AndroidPerf.profile_after_exit and
3011         change to always using long-form names for the arguments (to hopefully help readability).
3012
3013         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3014         (AndroidPerf.__init__):
3015         (profile_after_exit):
3016         (ChromiumAndroidDriver.__init__):
3017         (ChromiumAndroidDriver._update_kallsyms_cache):
3018         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3019
3020 2013-01-09  Julie Parent  <jparent@chromium.org>
3021
3022         Dashboard cleanup: remove dead code.
3023         https://bugs.webkit.org/show_bug.cgi?id=106509
3024
3025         Reviewed by Dirk Pranke.
3026
3027         * TestResultServer/static-dashboards/dashboard_base.js:
3028         (parseParameters):
3029
3030 2013-01-09  Joanmarie Diggs  <jdiggs@igalia.com>
3031
3032         [GTK] accessibility/aria-labelledby-overrides-label.html requires a proper baseline
3033         https://bugs.webkit.org/show_bug.cgi?id=105638
3034
3035         Reviewed by Martin Robinson.
3036
3037         The test was failing for two reasons:
3038         - AccessibilityRenderObject::correspondingLabelForControlElement() was
3039           not ignoring the ARIA labelled-by property
3040         - AccessibilityController::accessibleElementById() was not implemented
3041
3042         Because getting an element by ID cannot be done in the UIProcess, the
3043         decision was made to expose the element's ID as an accessible attribute
3044         of the object.
3045
3046         In addition, fixing the bug in AccessibilityRenderObject made it possible
3047         to eliminate the Gtk platform-specific expectations for another test.
3048
3049         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3050         (childElementById): Added. Walks the tree looking for the AtkObject
3051         Attribute which exposes the HTML element's ID.
3052         (AccessibilityController::accessibleElementById): Implemented.
3053         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3054         (AccessibilityUIElement::title): Modified to print out "AXTitle: " even
3055         when there is no title, as is done with the Mac port.
3056         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3057         (WTR):
3058         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
3059         (WTR::childElementById): Added. Walks the tree looking for the AtkObject
3060         Attribute which exposes the HTML element's ID.
3061         (WTR):
3062         (WTR::AccessibilityController::accessibleElementById): Implemented.
3063         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3064         (WTR::AccessibilityUIElement::title): Modified to print out "AXTitle: "
3065         even when there is no title, as is done with the Mac port.
3066
3067 2013-01-09  Gregg Tavares  <gman@google.com>
3068
3069         Add Gregg Tavares as a committer
3070         https://bugs.webkit.org/show_bug.cgi?id=106492
3071
3072         Unreviewed.
3073
3074         * Scripts/webkitpy/common/config/committers.py:
3075
3076 2013-01-09  Roger Fong  <roger_fong@apple.com>
3077
3078         Enable seamless iFrames for Windows DRT.
3079         https://bugs.webkit.org/show_bug.cgi?id=106468.
3080
3081         Rubberstamped by Timothy Horton.
3082
3083         * DumpRenderTree/win/DumpRenderTree.cpp:
3084         (resetDefaultsToConsistentValues):
3085
3086 2013-01-09  Christophe Dumez  <christophe.dumez@intel.com>
3087
3088         [WK2] Implement eventSender.scheduleAsynchronousKeyDown
3089         https://bugs.webkit.org/show_bug.cgi?id=93979
3090
3091         Reviewed by Benjamin Poulain.
3092
3093         Implement eventSender.scheduleAsynchronousKeyDown() in
3094         WebKitTestRunner.
3095
3096         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3097         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3098         (WTR::createKeyDownMessageBody):
3099         (WTR::EventSendingController::keyDown):
3100         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
3101         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3102         (EventSendingController):
3103         * WebKitTestRunner/TestController.cpp:
3104         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
3105         (WTR::TestController::didReceiveMessageFromInjectedBundle):
3106         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3107         * WebKitTestRunner/TestController.h:
3108         (TestController):
3109
3110 2013-01-09  Jochen Eisinger  <jochen@chromium.org>
3111
3112         [chromium] move resource load callback dumping to TestRunner library
3113         https://bugs.webkit.org/show_bug.cgi?id=106449
3114
3115         Reviewed by Adam Barth.
3116
3117         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3118         (DRTTestRunner::DRTTestRunner):
3119         (DRTTestRunner::reset):
3120         * DumpRenderTree/chromium/DRTTestRunner.h:
3121         (DRTTestRunner):
3122         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3123         (WebKit):
3124         (WebTestRunner::WebTestDelegate::makeURLErrorDescription):
3125         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3126         (WebKit):
3127         (WebTestProxyBase):
3128         (WebTestRunner::WebTestProxy::assignIdentifierToRequest):
3129         (WebTestRunner::WebTestProxy::willRequestResource):
3130         (WebTestRunner::WebTestProxy::willSendRequest):
3131         (WebTestRunner::WebTestProxy::didReceiveResponse):
3132         (WebTestRunner::WebTestProxy::didFinishResourceLoad):
3133         (WebTestRunner::WebTestProxy::didFailResourceLoad):
3134         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3135         (WebTestRunner::WebTestRunner::shouldDumpResourceLoadCallbacks):
3136         (WebTestRunner::WebTestRunner::shouldDumpResourceRequestCallbacks):
3137         (WebTestRunner::WebTestRunner::shouldDumpResourceResponseMIMETypes):
3138         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3139         (WebTestRunner::TestRunner::TestRunner):
3140         (WebTestRunner::TestRunner::reset):
3141         (WebTestRunner::TestRunner::shouldDumpResourceLoadCallbacks):
3142         (WebTestRunner::TestRunner::shouldDumpResourceRequestCallbacks):
3143         (WebTestRunner::TestRunner::shouldDumpResourceResponseMIMETypes):
3144         (WebTestRunner):
3145         (WebTestRunner::TestRunner::dumpResourceLoadCallbacks):
3146         (WebTestRunner::TestRunner::dumpResourceRequestCallbacks):
3147         (WebTestRunner::TestRunner::dumpResourceResponseMIMETypes):
3148         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3149         (TestRunner):
3150         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3151         (WebTestRunner::WebTestProxyBase::reset):
3152         (WebTestRunner):
3153         (WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
3154         (WebTestRunner::WebTestProxyBase::willRequestResource):
3155         (WebTestRunner::WebTestProxyBase::willSendRequest):
3156         (WebTestRunner::WebTestProxyBase::didReceiveResponse):
3157         (WebTestRunner::WebTestProxyBase::didFinishResourceLoad):
3158         (WebTestRunner::WebTestProxyBase::didFailResourceLoad):
3159         * DumpRenderTree/chromium/WebViewHost.cpp:
3160         (WebViewHost::willSendRequest):
3161         (WebViewHost::makeURLErrorDescription):
3162         (WebViewHost::reset):
3163         * DumpRenderTree/chromium/WebViewHost.h:
3164         (WebViewHost):
3165
3166 2013-01-09  Dan Carney  <dcarney@google.com>
3167
3168         [chromium] move dumpcreateview methods to testrunner library
3169         https://bugs.webkit.org/show_bug.cgi?id=106434
3170
3171         Reviewed by Adam Barth.
3172
3173         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3174         (DRTTestRunner::DRTTestRunner):
3175         (DRTTestRunner::reset):
3176         * DumpRenderTree/chromium/DRTTestRunner.h:
3177         (DRTTestRunner):
3178         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3179         (WebTestRunner::WebTestRunner::shouldDumpCreateView):
3180         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3181         (WebTestRunner::TestRunner::TestRunner):
3182         (WebTestRunner::TestRunner::reset):
3183         (WebTestRunner::TestRunner::shouldDumpCreateView):
3184         (WebTestRunner):
3185         (WebTestRunner::TestRunner::dumpCreateView):
3186         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3187         (TestRunner):
3188
3189 2013-01-09  Csaba Osztrogonác  <ossy@webkit.org>
3190
3191         webkitpy cleanup: Merge additional_comment_text into comment_text
3192         https://bugs.webkit.org/show_bug.cgi?id=106421
3193
3194         Reviewed by Adam Barth.
3195
3196         * Scripts/webkitpy/common/config/committervalidator.py:
3197         (CommitterValidator.reject_patch_from_commit_queue):
3198         (CommitterValidator.reject_patch_from_review_queue):
3199         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3200         (Bugzilla.set_flag_on_attachment):
3201         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
3202         (MockBugzilla.set_flag_on_attachment):
3203         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3204         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3205         (AbstractEarlyWarningSystem._post_reject_message_on_bug):
3206         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3207
3208 2013-01-09  Mario Sanchez Prada  <mario.prada@samsung.com>
3209
3210         [GTK] Raise version of gdk-pixbuf in jhbuild up to 2.26.5
3211         https://bugs.webkit.org/show_bug.cgi?id=106464
3212
3213         Reviewed by Martin Robinson.
3214
3215         Current version in jhbuild.modules (2.26.0) is giving trouble to
3216         when trying to build WebKitGTK from scratch, due to a segmentation
3217         fault error in gdk-pixbuf-query-loader during the 'make'
3218         phase. Raising the version to 2.26.5 fixes this issue.
3219
3220         * gtk/jhbuild.modules: Version raised, checksums updated.
3221
3222 2013-01-09  János Badics  <jbadics@inf.u-szeged.hu>
3223
3224         [Qt][NRWT] Pass --timeout to DRT/WTR if a test is marked as SLOW.
3225         https://bugs.webkit.org/show_bug.cgi?id=90968.
3226
3227         Reviewed by Csaba Osztrogonác.
3228
3229         Added functionality in DRT and WTR to use any timeout value while running
3230         slow tests (eventually, any test). Now NRWT --time-out-ms determines the
3231         timeout value for the test. Added a flag in NRWT (supports_per_test_timeout)
3232         to indicate whether the current port supports setting timeout value
3233         per test (it's False by default; I enabled it only on Qt).
3234         Also corrected a typo in driver.py
3235
3236         * DumpRenderTree/DumpRenderTree.h:
3237         (TestCommand::TestCommand):
3238         (TestCommand):
3239         * DumpRenderTree/DumpRenderTreeCommon.cpp:
3240         (parseInputLine):
3241         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3242         (WebCore::DumpRenderTree::processLine):
3243         * Scripts/webkitpy/layout_tests/port/base.py:
3244         (Port.supports_per_test_timeout):
3245         * Scripts/webkitpy/layout_tests/port/driver.py:
3246         (Driver.run_test):
3247         (Driver._command_from_driver_input):
3248         * Scripts/webkitpy/layout_tests/port/qt.py:
3249         (QtPort.supports_per_test_timeout):
3250         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3251         (WTR::InjectedBundle::InjectedBundle):
3252         (WTR::InjectedBundle::didReceiveMessage):
3253         (WTR::InjectedBundle::beginTesting):
3254         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3255         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3256         (WTR::TestRunner::setCustomTimeout):
3257         (WTR):
3258         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3259         (TestRunner):
3260         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
3261         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
3262         * WebKitTestRunner/TestController.cpp:
3263         (WTR::TestController::TestController):
3264         (WTR::TestController::getCustomTimeout):
3265         (WTR):
3266         (WTR::TestCommand::TestCommand):
3267         (TestCommand):
3268         (WTR::parseInputLine):
3269         (WTR::TestController::runTest):
3270         (WTR::TestController::runUntil):
3271         * WebKitTestRunner/TestController.h:
3272         (TestController):
3273         * WebKitTestRunner/TestInvocation.cpp:
3274         (WTR::TestInvocation::TestInvocation):
3275         (WTR::TestInvocation::setCustomTimeout):
3276         (WTR):
3277         (WTR::TestInvocation::invoke):
3278         * WebKitTestRunner/TestInvocation.h:
3279         (TestInvocation):
3280
3281 2013-01-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3282
3283         Regression(r138681): Add HAVE(ACCESSIBILITY) guard to atk files
3284         https://bugs.webkit.org/show_bug.cgi?id=106290
3285
3286         Reviewed by Martin Robinson.
3287
3288         Some atk files don't use HAVE(ACCESSIBILITY). It might make build errors when
3289         the macro isn't enabled.
3290
3291         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3292
3293 2013-01-08  Martin Robinson  <mrobinson@igalia.com>
3294
3295         WebKitTestRunner needs support for setHandlesAuthenticationChallenges
3296         https://bugs.webkit.org/show_bug.cgi?id=103653
3297
3298         Reviewed by Anders Carlsson.
3299
3300         Implement setHandlesAuthenticationChallenges in the UIProcess by sending credentials
3301         and the enabled boolean to the UIProcess and then implementing the didReceiveAuthenticationChallengeInFrame
3302         client callback.
3303
3304         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Exposed the new TestRunner
3305         methods to the JavaScript API.
3306         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3307         (WTR::TestRunner::setHandlesAuthenticationChallenges): Added this callback for the JavaScript API.
3308         (WTR::TestRunner::setAuthenticationUsername): Ditto.
3309         (WTR::TestRunner::setAuthenticationPassword): Ditto.
3310         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3311         (TestRunner): Added new declarations for the above.
3312         * WebKitTestRunner/TestController.cpp:
3313         (WTR::TestController::createWebViewWithOptions): Hook up the new didReceiveSynchronousMessageFromInjectedBundle
3314         callback.
3315         (WTR::TestController::resetStateToConsistentValues): Reset the credentials and enabled boolean between tests.
3316         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Handle the callback by using
3317         the authentication information passed from the InjectedBundle.
3318         * WebKitTestRunner/TestController.h:
3319         (WTR::TestController::setHandlesAuthenticationChallenges): Added setter to allow TestInvocation
3320         to communicate with the TestController.
3321         (WTR::TestController::setAuthenticationUsername): Ditto.
3322         (WTR::TestController::setAuthenticationPassword): Ditto.
3323         (TestController):
3324         * WebKitTestRunner/TestInvocation.cpp:
3325         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the messages sending authentication
3326         information from the InjectedBundle.
3327         (WTR::TestInvocation::outputText): Added this method so that the TestController can output
3328         text to the TestInvocation text output.
3329         * WebKitTestRunner/TestInvocation.h:
3330         (TestInvocation): Added declaration for new method.
3331
3332 2013-01-08  Benjamin Poulain  <benjamin@webkit.org>
3333
3334         Add myself as a watcher for Web Geolocation
3335
3336         Unreviewed.
3337
3338         * Scripts/webkitpy/common/config/watchlist:
3339
3340 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
3341
3342         [webkitpy] Call setup_test_run method of the parent Port interface when method is called on subclasses
3343         https://bugs.webkit.org/show_bug.cgi?id=106364
3344
3345         Reviewed by Eric Seidel.
3346
3347         When the setup_test_run method is called on the subclasses of the base Port
3348         interface, the parent method should also be called via super(), despite the
3349         parent method not doing anything at the moment.
3350
3351         The according calls to super() are required in the ChromiumPort, EflPort
3352         and GtkPort implementations.
3353
3354         * Scripts/webkitpy/layout_tests/port/chromium.py:
3355         (ChromiumPort.setup_test_run):
3356         * Scripts/webkitpy/layout_tests/port/efl.py:
3357         (EflPort.setup_test_run):
3358         * Scripts/webkitpy/layout_tests/port/gtk.py:
3359         (GtkPort.setup_test_run):
3360
3361 2013-01-08  Julie Parent  <jparent@chromium.org>
3362
3363         Dashboard cleanup: Remove globals g_buildersThatFailedToLoad and g_staleBuilders
3364         https://bugs.webkit.org/show_bug.cgi?id=106356
3365
3366         g_buildersThatFailedToLoad and g_staleBuilders were globals defined in
3367         dashboard_base, assigned by Loader, and used only by dashboard_base to
3368         create error messages.  Moved the variables to be privates on the Loader
3369         object, moved error message creation to _getLoadingErrorMessages on the
3370         Loader object, and now pass the errors back to dashboard base via the
3371         resourceLoadingComplete callback.
3372         
3373         Also removed the now unused clearError function, it was only being used
3374         by unit tests to clean up global state.
3375         
3376         Reviewed by Dirk Pranke.
3377
3378         * TestResultServer/static-dashboards/dashboard_base.js:
3379         (resourceLoadingComplete):
3380         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3381         * TestResultServer/static-dashboards/loader.js:
3382         (.):
3383         * TestResultServer/static-dashboards/loader_unittests.js:
3384
3385 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
3386
3387         [EFL][GTK] Make the PulseAudioSanitizer an object on the EflPort, GtkPort
3388         https://bugs.webkit.org/show_bug.cgi?id=106354
3389
3390         Reviewed by Eric Seidel.
3391
3392         Put the PulseAudioSanitizer object on the EflPort and GtkPort interfaces
3393         instead of those two inheriting from it. Also add a mock object of the
3394         sanitizer that's used in unit tests.
3395
3396         * Scripts/webkitpy/layout_tests/port/efl.py:
3397         (EflPort):
3398         (EflPort.__init__):
3399         (EflPort.setup_test_run):
3400         (EflPort.clean_up_test_run):
3401         * Scripts/webkitpy/layout_tests/port/efl_unittest.py: Also correct the
3402         importing order.
3403         (EflPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.
3404         * Scripts/webkitpy/layout_tests/port/gtk.py:
3405         (GtkPort):
3406         (GtkPort.__init__):
3407         (GtkPort.setup_test_run):
3408         (GtkPort.clean_up_test_run):
3409         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py: Also correct the
3410         importing order.
3411         (GtkPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.
3412         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer.py:
3413         (PulseAudioSanitizer.unload_pulseaudio_module): Stylize the method as public.
3414         (PulseAudioSanitizer.restore_pulseaudio_module): Ditto.
3415         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer_mock.py: Added.
3416         (PulseAudioSanitizerMock): A simple mock interface for PulseAudioSanitizer.
3417         (PulseAudioSanitizerMock.unload_pulseaudio_module):
3418         (PulseAudioSanitizerMock.restore_pulseaudio_module):
3419
3420 2013-01-08  Jochen Eisinger  <jochen@chromium.org>
3421
3422         [chromium] move dumpFrameLoadCallbacks and friends to the TestRunner library
3423         https://bugs.webkit.org/show_bug.cgi?id=106324
3424
3425         Reviewed by Adam Barth.
3426
3427         Since the frame load callbacks are part of the WebFrameClient, the
3428         WebTestProxy is now intercepting both WebViewClient and WebFrameClient
3429         methods.
3430
3431         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3432         (DRTTestRunner::DRTTestRunner):
3433         (DRTTestRunner::reset):
3434         * DumpRenderTree/chromium/DRTTestRunner.h:
3435         (DRTTestRunner):
3436         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3437         (WebTestInterfaces):
3438         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3439         (WebKit):
3440         (WebTestProxyBase):
3441         (WebTestRunner):
3442         (WebTestRunner::WebTestProxy::WebTestProxy):
3443         (WebTestProxy):
3444         (WebTestRunner::WebTestProxy::didInvalidateRect):
3445         (WebTestRunner::WebTestProxy::didScrollRect):
3446         (WebTestRunner::WebTestProxy::scheduleComposite):
3447         (WebTestRunner::WebTestProxy::scheduleAnimation):
3448         (WebTestRunner::WebTestProxy::setWindowRect):
3449         (WebTestRunner::WebTestProxy::show):
3450         (WebTestRunner::WebTestProxy::didAutoResize):
3451         (WebTestRunner::WebTestProxy::postAccessibilityNotification):
3452         (WebTestRunner::WebTestProxy::startDragging):
3453         (WebTestRunner::WebTestProxy::shouldBeginEditing):
3454         (WebTestRunner::WebTestProxy::shouldEndEditing):
3455         (WebTestRunner::WebTestProxy::shouldInsertNode):
3456         (WebTestRunner::WebTestProxy::shouldInsertText):
3457         (WebTestRunner::WebTestProxy::shouldChangeSelectedRange):
3458         (WebTestRunner::WebTestProxy::shouldDeleteRange):
3459         (WebTestRunner::WebTestProxy::shouldApplyStyle):
3460         (WebTestRunner::WebTestProxy::didBeginEditing):
3461         (WebTestRunner::WebTestProxy::didChangeSelection):
3462         (WebTestRunner::WebTestProxy::didChangeContents):
3463         (WebTestRunner::WebTestProxy::didEndEditing):
3464         (WebTestRunner::WebTestProxy::registerIntentService):
3465         (WebTestRunner::WebTestProxy::dispatchIntent):
3466         (WebTestRunner::WebTestProxy::willPerformClientRedirect):
3467         (WebTestRunner::WebTestProxy::didCancelClientRedirect):
3468         (WebTestRunner::WebTestProxy::didStartProvisionalLoad):
3469         (WebTestRunner::WebTestProxy::didReceiveServerRedirectForProvisionalLoad):
3470         (WebTestRunner::WebTestProxy::didFailProvisionalLoad):
3471         (WebTestRunner::WebTestProxy::didCommitProvisionalLoad):
3472         (WebTestRunner::WebTestProxy::didReceiveTitle):
3473         (WebTestRunner::WebTestProxy::didFinishDocumentLoad):
3474         (WebTestRunner::WebTestProxy::didHandleOnloadEvents):
3475         (WebTestRunner::WebTestProxy::didFailLoad):
3476         (WebTestRunner::WebTestProxy::didFinishLoad):
3477         (WebTestRunner::WebTestProxy::didChangeLocationWithinPage):
3478         (WebTestRunner::WebTestProxy::didDisplayInsecureContent):
3479         (WebTestRunner::WebTestProxy::didRunInsecureContent):
3480         (WebTestRunner::WebTestProxy::didDetectXSS):
3481         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3482         (WebTestRunner::WebTestRunner::setTestIsRunning):
3483         (WebTestRunner::WebTestRunner::shouldDumpFrameLoadCallbacks):
3484         (WebTestRunner::WebTestRunner::setShouldDumpFrameLoadCallbacks):
3485         (WebTestRunner::WebTestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
3486         (WebTestRunner::WebTestRunner::stopProvisionalFrameLoads):
3487         (WebTestRunner::WebTestRunner::shouldDumpTitleChanges):
3488         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3489         (WebTestRunner::TestRunner::TestRunner):
3490         (WebTestRunner::TestRunner::reset):
3491         (WebTestRunner::TestRunner::setTestIsRunning):
3492         (WebTestRunner):
3493         (WebTestRunner::TestRunner::shouldDumpFrameLoadCallbacks):
3494         (WebTestRunner::TestRunner::setShouldDumpFrameLoadCallbacks):
3495         (WebTestRunner::TestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
3496         (WebTestRunner::TestRunner::stopProvisionalFrameLoads):
3497         (WebTestRunner::TestRunner::shouldDumpTitleChanges):
3498         (WebTestRunner::TestRunner::dumpFrameLoadCallbacks):
3499         (WebTestRunner::TestRunner::dumpUserGestureInFrameLoadCallbacks):
3500         (WebTestRunner::TestRunner::setStopProvisionalFrameLoads):
3501         (WebTestRunner::TestRunner::dumpTitleChanges):
3502         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3503         (TestRunner):
3504         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3505         (WebTestInterfaces::Internal):
3506         (WebTestRunner::WebTestInterfaces::Internal::webView):
3507         (WebTestRunner::WebTestInterfaces::Internal::Internal):
3508         (WebTestRunner::WebTestInterfaces::Internal::setWebView):
3509         (WebTestRunner):
3510         (WebTestRunner::WebTestInterfaces::Internal::setTestIsRunning):
3511         (WebTestRunner::WebTestInterfaces::setWebView):
3512         (WebTestRunner::WebTestInterfaces::setTestIsRunning):
3513         (WebTestRunner::WebTestInterfaces::webView):
3514         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3515         (WebTestRunner::WebTestProxyBase::willPerformClientRedirect):
3516         (WebTestRunner):
3517         (WebTestRunner::WebTestProxyBase::didCancelClientRedirect):
3518         (WebTestRunner::WebTestProxyBase::didStartProvisionalLoad):
3519         (WebTestRunner::WebTestProxyBase::didReceiveServerRedirectForProvisionalLoad):
3520         (WebTestRunner::WebTestProxyBase::didFailProvisionalLoad):
3521         (WebTestRunner::WebTestProxyBase::didCommitProvisionalLoad):
3522         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
3523         (WebTestRunner::WebTestProxyBase::didFinishDocumentLoad):
3524         (WebTestRunner::WebTestProxyBase::didHandleOnloadEvents):
3525         (WebTestRunner::WebTestProxyBase::didFailLoad):
3526         (WebTestRunner::WebTestProxyBase::didFinishLoad):
3527         (WebTestRunner::WebTestProxyBase::didChangeLocationWithinPage):
3528         (WebTestRunner::WebTestProxyBase::didDisplayInsecureContent):
3529         (WebTestRunner::WebTestProxyBase::didRunInsecureContent):
3530         (WebTestRunner::WebTestProxyBase::didDetectXSS):
3531         * DumpRenderTree/chromium/TestShell.cpp:
3532         (TestShell::runFileTest):
3533         (TestShell::testFinished):
3534         * DumpRenderTree/chromium/TestShell.h:
3535         (TestShell):
3536         * DumpRenderTree/chromium/WebViewHost.cpp:
3537         (WebViewHost::didStartProvisionalLoad):
3538         (WebViewHost::didReceiveServerRedirectForProvisionalLoad):
3539         (WebViewHost::didFailProvisionalLoad):
3540         (WebViewHost::didCommitProvisionalLoad):
3541         (WebViewHost::didReceiveTitle):
3542         (WebViewHost::didFailLoad):
3543         (WebViewHost::didFinishLoad):
3544         * DumpRenderTree/chromium/WebViewHost.h:
3545         (WebViewHost):
3546
3547 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
3548
3549         [GTK] Lower the default timeout value for WebKitTestRunner
3550         https://bugs.webkit.org/show_bug.cgi?id=106353
3551
3552         Reviewed by Dirk Pranke.
3553
3554         The default timeout value for WebKitTestRunner should be lowered.
3555         The current value (80 seconds) is irrational and just leads to producing
3556         text failures for layout tests that genuinely time out. This just leads
3557         to more deviation from the GTK WK1 port in terms of test expectations.
3558
3559         The value used is the same as when running the DumpRenderTree, that's
3560         6 seconds in release builds and 12 seconds in debug builds.
3561
3562         * Scripts/webkitpy/layout_tests/port/gtk.py:
3563         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3564         (GtkPortTest.test_default_timeout_ms):
3565
3566 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
3567
3568         test-webkitpy shows failure output on my linux box
3569         https://bugs.webkit.org/show_bug.cgi?id=101261
3570
3571         Reviewed by Eric Seidel.
3572
3573         Mock out the PulseAudioSanitizer methods when creating testing instances
3574         of EflPort and GtkPort interfaces in unit tests. This stops throwing up
3575         PulseAudio output when the sanitizer was trying to unload modules which
3576         were already unloaded by another unit test that was being run in parallel.
3577
3578         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
3579         (EflPortTest):
3580         (EflPortTest.make_port):
3581         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3582         (GtkPortTest):
3583         (GtkPortTest.make_port):
3584
3585 2013-01-08  Julie Parent  <jparent@chromium.org>
3586
3587         Dashboard Cleanup: Remove g_hasDoneInitialPageGeneration
3588         https://bugs.webkit.org/show_bug.cgi?id=106254
3589
3590         Remove the global variable g_hasDoneInitialPageGeneration.  It was used
3591         only to figure out if we should call addBuilderLoadErrors during
3592         handleLocationChange, which was called when the loader completed and on
3593         any hash change, but we only ever wanted to call addBuilderLoadErrors
3594         on the initial loader load.  Moved the call of addBuilderLoadErrors to
3595         resourceLoadingComplete rather than handleLocationChange, so now we
3596         only call it when we want to, and the check can go away completely.
3597
3598         Reviewed by Dirk Pranke.
3599
3600         * TestResultServer/static-dashboards/dashboard_base.js:
3601         (addBuilderLoadErrors):
3602         (resourceLoadingComplete):
3603         (handleLocationChange):
3604         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3605
3606 2013-01-08  Dominic Mazzoni  <dmazzoni@google.com>
3607
3608         Add aboxhall@chromium.org to accessibility watchlist.
3609
3610         Unreviewed.
3611
3612         * Scripts/webkitpy/common/config/watchlist:
3613
3614 2013-01-08  Dan Winship  <danw@gnome.org>
3615
3616         Add Apache 2.4 support for Fedora 18
3617         https://bugs.webkit.org/show_bug.cgi?id=104478
3618
3619         Reviewed by Martin Robinson.
3620
3621         Apache 2.4's httpd.conf is slightly incompatible with 2.2's, so we
3622         need a separate config.
3623
3624         * Scripts/webkitpy/layout_tests/port/base.py:
3625         (Port._apache_version):
3626         (Port._apache_config_file_name_for_platform):
3627         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3628         * Scripts/run-webkit-httpd:
3629         * Scripts/webkitperl/httpd.pm:
3630         (getApacheVersion):
3631         (getDefaultConfigForTestDirectory):
3632         (getHTTPDConfigPathForTestDirectory):
3633
3634 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
3635
3636         Make the override-feature-defines script compatible with Python v3
3637         https://bugs.webkit.org/show_bug.cgi?id=105742
3638
3639         Reviewed by Martin Robinson.
3640
3641         Instead of printing output through a statement, use the print function and format
3642         the output using the str.format method. This makes the script runnable with Python v3.
3643
3644         * gtk/override-feature-defines:
3645         (adjust_feature_defines_makefile):
3646
3647 2013-01-08  Heikki Paajanen  <heikki.paajanen@palm.com>
3648
3649         [Qt] Fix libxml2 config test
3650         https://bugs.webkit.org/show_bug.cgi?id=106317
3651
3652         Reviewed by Simon Hausmann.
3653
3654         Don't assume standard include/libxml2, libxml-2.0.pc should know
3655         where it's headers are.
3656
3657         * qmake/config.tests/libxml2/libxml2.cpp: Fix include
3658
3659 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
3660
3661         [GTK] Make Tools/gtk/generate-gtkdoc compatible with Python 3
3662         https://bugs.webkit.org/show_bug.cgi?id=106195