5554156e5ead42e7558321e2dd51d8d21481c83a
[WebKit-https.git] / Tools / ChangeLog
1 2013-08-29  Joseph Pecoraro  <pecoraro@apple.com>
2
3         new-run-webkit-tests does not respect --no-sample-on-timeout switch
4         https://bugs.webkit.org/show_bug.cgi?id=120491
5
6         Reviewed by Darin Adler.
7
8         * Scripts/webkitpy/port/server_process.py:
9         (ServerProcess._handle_timeout):
10
11 2013-08-29  Sam Weinig  <sam@webkit.org>
12
13         Add ENABLE guards for Promises
14         https://bugs.webkit.org/show_bug.cgi?id=120488
15
16         Reviewed by Andreas Kling.
17
18         * Scripts/webkitperl/FeatureList.pm:
19         * qmake/mkspecs/features/features.pri:
20
21 2013-08-29  Andre Moreira Magalhaes   <andre.magalhaes@collabora.co.uk>
22
23         [GTK] Should enable WebGL by default on MiniBrowser
24         https://bugs.webkit.org/show_bug.cgi?id=120420
25
26         Reviewed by Gustavo Noronha Silva.
27
28         Enable WebGL by default on MiniBrowser.
29
30         * MiniBrowser/gtk/main.c:
31         (main):
32
33 2013-08-28  Simon Fraser  <simon.fraser@apple.com>
34
35         Add a Command-R shortcut in MiniBrowser
36         https://bugs.webkit.org/show_bug.cgi?id=120442
37
38         Reviewed by Dean Jackson.
39         
40         Add a "Reload Page" item to the View menu with a Command-R
41         shortcut.
42
43         * MiniBrowser/mac/MainMenu.xib:
44
45 2013-08-29  Alberto Garcia  <berto@igalia.com>
46
47         [GTK] Update apt dependency list
48         https://bugs.webkit.org/show_bug.cgi?id=120399
49
50         Reviewed by Philippe Normand.
51
52         Remove bogus package gail-3.0, add xfonts-utils (needed by
53         xorg-xserver) and switch to the latest versions of libtiff and
54         libjpeg.
55
56         * gtk/install-dependencies:
57
58 2013-08-28  Alexey Proskuryakov  <ap@apple.com>
59
60         [WK2][Mac] WebKitTestRunner doesn't force system appearance
61         https://bugs.webkit.org/show_bug.cgi?id=120437
62
63         Reviewed by Darin Adler.
64
65         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
66         (WTR::InjectedBundle::platformInitialize): Set AppleAquaColorVariant,
67         AppleHighlightColor and AppleOtherHighlightColor to the same values that DRT uses.
68         Fixed formatting.
69
70 2013-08-16  Ryosuke Niwa  <rniwa@webkit.org>
71
72         <https://webkit.org/b/119806> [Mac] Add a way to easily test attributed string generation
73
74         Reviewed by Darin Adler.
75
76         Add textInputController.legacyAttributedString to retrieve the attributed string for copy & paste.
77
78         We can't use textInputController.attributedSubstringFromRange as it uses WebHTMLConverter's static
79         editingAttributedStringFromRange function, which doesn't implement the full converter at the moment.
80
81         Also NSMutableAttributedString.ranges and WebNSRange so that JavaScript can get a list of all
82         ranges in a given attributed string.
83
84         * DumpRenderTree/mac/TextInputController.m:
85         (-[WebNSRange initWithNSRange:]):
86         (-[WebNSRange location]):
87         (-[WebNSRange length]):
88         (+[WebNSRange isSelectorExcludedFromWebScript:]):
89         (+[NSMutableAttributedString isSelectorExcludedFromWebScript:]):
90         (+[NSMutableAttributedString webScriptNameForSelector:]):
91         (-[NSMutableAttributedString ranges]): Added.
92         (+[TextInputController isSelectorExcludedFromWebScript:]):
93         (+[TextInputController webScriptNameForSelector:]):
94         (-[TextInputController legacyAttributedString:]):
95
96 2013-08-28  Denis Nomiyama  <d.nomiyama@samsung.com>
97
98         [GTK] accessibility/menu-list-sends-change-notification.html has incorrect expected results
99         https://bugs.webkit.org/show_bug.cgi?id=120419
100
101         Reviewed by Chris Fleizach.
102
103         Added a notification for AXFocusedUIElementChanged.
104
105         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
106         (axObjectEventListener): Added a notification for AXFocusedUIElementChanged.
107
108 2013-08-28  Roger Fong  <roger_fong@apple.com>
109
110         Decrease number of workers used in NRWT by the Windows port.
111         https://bugs.webkit.org/show_bug.cgi?id=120435.
112
113         Reviewed by Brent Fulgham.
114
115         * Scripts/webkitpy/port/win.py:
116         (WinPort.default_child_processes):
117
118 2013-08-28  Allan Sandfeld Jensen  <allan.jensen@digia.com>
119
120         Http tests fails on Debian with Apache 2.4
121         https://bugs.webkit.org/show_bug.cgi?id=120352
122
123         Unreviewed fix-up.
124
125         Remember to update unit-test expectations and old-run-webkit-tests as well.
126
127         * Scripts/webkitperl/httpd.pm:
128         (getHTTPDConfigPathForTestDirectory):
129         * Scripts/webkitpy/port/port_testcase.py:
130         (test_apache_config_file_name_for_platform):
131
132 2013-08-28  Allan Sandfeld Jensen  <allan.jensen@digia.com>
133
134         Http tests fails on Debian with Apache 2.4
135         https://bugs.webkit.org/show_bug.cgi?id=120352
136
137         Reviewed by Andreas Kling.
138
139         Select httpd.conf file for debian based on version, matching Fedora behavior.
140
141         * Scripts/webkitpy/port/base.py:
142         (Port._apache_config_file_name_for_platform):
143
144 2013-08-28  Commit Queue  <commit-queue@webkit.org>
145
146         Unreviewed, rolling out r154593.
147         http://trac.webkit.org/changeset/154593
148         https://bugs.webkit.org/show_bug.cgi?id=120403
149
150         Caused 50+ flaky tests on WebKit1 bots (Requested by carewolf
151         on #webkit).
152
153         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
154         (WebPage::~WebPage):
155
156 2013-08-28  Allan Sandfeld Jensen  <allan.jensen@digia.com>
157
158         [Qt][Wk2] Many tests are flaky on Qt 5.1
159         https://bugs.webkit.org/show_bug.cgi?id=118232
160
161         Reviewed by Jocelyn Turcotte.
162
163         We need to set renderToOffscreenBuffer since we won't otherwise get
164         the paint calls necessary to synchronize UI- and Web-Process. It was
165         only disabled in Qt 5.0 because it conflicted with setRenderWithoutShowing
166         which is no longer supported or needed.
167
168         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
169         (WTR::WrapperWindow::handleStatusChanged):
170
171 2013-08-27  Alexey Proskuryakov  <ap@apple.com>
172
173         [WK2] Remove USE_WEBPROCESS_EVENT_SIMULATION
174         https://bugs.webkit.org/show_bug.cgi?id=120379
175
176         Reviewed by Darin Adler.
177
178         All major platforms have implemented UI process eventSender support, keeping old
179         web process side code only adds confusion.
180
181         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
182         (WTR::EventSendingController::EventSendingController):
183         (WTR::EventSendingController::mouseDown):
184         (WTR::EventSendingController::mouseUp):
185         (WTR::EventSendingController::mouseMoveTo):
186         (WTR::EventSendingController::leapForward):
187         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
188         * WebKitTestRunner/TestController.cpp:
189         (WTR::TestController::resetStateToConsistentValues):
190         (WTR::TestController::didReceiveMessageFromInjectedBundle):
191         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
192         * WebKitTestRunner/TestController.h:
193
194 2013-08-27  Roger Fong  <roger_fong@apple.com>
195
196         NRWT on AppleWin port should delete semaphore lock files during cleanup tasks.
197         https://bugs.webkit.org/show_bug.cgi?id=120370.
198
199         Reviewed by Brent Fulgham.
200
201         * Scripts/webkitpy/port/win.py:
202         (WinPort.delete_sem_locks):
203         (WinPort.setup_test_run):
204
205 2013-08-27  Denis Nomiyama  <d.nomiyama@samsung.com>
206
207         [GTK] Missing DRT AccessibilityUIElement::addNotificationListener implementation
208         https://bugs.webkit.org/show_bug.cgi?id=119883
209
210         Implemented the notification listener for AccessibilityUIElement. The signal is generated
211         by AXObjectCache::postPlatformNotification() and received by axObjectEventListener().
212         axObjectEventListener will then invoke JSObjectCallAsFunction() with the respective
213         callback function. The global callback function and callbacks for specific elements are
214         stored in a HashMap in AccessibilityCallbacksAtk.cpp.
215
216         Reviewed by Chris Fleizach.
217
218         * DumpRenderTree/AccessibilityUIElement.h: Added a notification handler for GTK+
219         * DumpRenderTree/atk/AccessibilityCallbacks.h: Added addAccessibilityNotificationListener()
220         and removeAccessibilityNotificationListener()
221         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
222         (axObjectEventListener): Call JS callback for global notification or for a specific element
223         (disconnectAccessibilityCallbacks): Only disconnect if logging is off and there is no
224         notification handler
225         (addAccessibilityNotificationHandler): Add notification listener to the list
226         (removeAccessibilityNotificationHandler): Remove notification listener from the list
227         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
228         (AccessibilityController::setLogAccessibilityEvents): Set logging off before disconnecting
229         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.cpp: Added.
230         (AccessibilityNotificationHandler::AccessibilityNotificationHandler): Create handler
231         (AccessibilityNotificationHandler::~AccessibilityNotificationHandler): Destroy handler.
232         Remove handler from the list and disconnect callbacks
233         (AccessibilityNotificationHandler::setNotificationFunctionCallback): Set the notification
234         callback and connect callbacks to signals
235         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.h: Added.
236         (AccessibilityNotificationHandler::setPlatformElement): Set platform element
237         (AccessibilityNotificationHandler::platformElement): Get platform element
238         (AccessibilityNotificationHandler::notificationFunctionCallback): Get notification callback
239         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
240         (AccessibilityUIElement::addNotificationListener): Create notification handler, set the
241         platform element and the notification callback
242         (AccessibilityUIElement::removeNotificationListener):
243         * DumpRenderTree/efl/CMakeLists.txt: Added AccessibilityNotificationHandlerAtk.cpp/h
244         * GNUmakefile.am: Added AccessibilityNotificationHandlerAtk.cpp/h
245
246 2013-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
247
248         Unreviewed. Fix GTK+ build after r154601.
249
250         * TestWebKitAPI/GNUmakefile.am: Remove mac specific file from
251         compilation added by mistake in r154601.
252
253 2013-08-26  Alexey Proskuryakov  <ap@apple.com>
254
255         WebKitTestRunner needs to protect the user's pasteboard contents while running
256         https://bugs.webkit.org/show_bug.cgi?id=81419
257         <rdar://problem/11066794>
258
259         Reviewed by Darin Adler.
260
261         Mostly a copy/paste of DRT code.
262
263         Tested manually by making sure that editing/pasteboard/copy-image-with-alt-text.html
264         doesn't interfere with my clipboard while being run in a loop.
265
266         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
267         * WebKitTestRunner/mac/PoseAsClass.h: Added.
268         * WebKitTestRunner/mac/PoseAsClass.mm: Added.
269         * WebKitTestRunner/mac/TestControllerMac.mm:
270         (WTR::TestController::platformInitialize):
271         (WTR::TestController::platformDestroy):
272         * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.h: Added.
273         * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm: Added.
274
275 2013-08-26  Commit Queue  <commit-queue@webkit.org>
276
277         Unreviewed, rolling out r154640.
278         http://trac.webkit.org/changeset/154640
279         https://bugs.webkit.org/show_bug.cgi?id=120329
280
281         Caused flaky crashes on a lot of editing tests (Requested by
282         rniwa on #webkit).
283
284         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
285         * WebKitTestRunner/mac/PoseAsClass.h: Removed.
286         * WebKitTestRunner/mac/PoseAsClass.mm: Removed.
287         * WebKitTestRunner/mac/TestControllerMac.mm:
288         (WTR::TestController::platformInitialize):
289         (WTR::TestController::platformDestroy):
290         * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.h: Removed.
291         * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm: Removed.
292
293 2013-08-26  Dan Bernstein  <mitz@apple.com>
294
295         Automatic bug reports case pain
296         https://bugs.webkit.org/show_bug.cgi?id=120330
297
298         Reviewed by Anders Carlsson.
299
300         * Scripts/webkitpy/tool/commands/download.py: Made the following changes to the Description
301         of bugs filed by the bot: changed “the sheriff-bot” to “webkitbot”, changed “case pain” to
302         “fail”, and removed “"Only you can prevent forest fires." -- Smokey the Bear”.
303
304 2013-08-23  Andy Estes  <aestes@apple.com>
305
306         Fix issues found by the Clang Static Analyzer
307         https://bugs.webkit.org/show_bug.cgi?id=120230
308
309         Reviewed by Darin Adler.
310
311         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
312         (-[LocalPasteboard initWithName:]): Called [super init] first so that we
313         don't later use ivars from the wrong self.
314         * DumpRenderTree/mac/TestRunnerMac.mm:
315         (-[APITestDelegate initWithCompletionCondition:]): Ditto.
316         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
317         (TestWebKitAPI::TEST): Don't leak WKProcessGroups,
318         WKBrowsingContextGroups, and WKViews.
319
320 2013-08-26  Alexey Proskuryakov  <ap@apple.com>
321
322         WebKitTestRunner needs to protect the user's pasteboard contents while running
323         https://bugs.webkit.org/show_bug.cgi?id=81419
324         <rdar://problem/11066794>
325
326         Reviewed by Darin Adler.
327
328         Mostly a copy/paste of DRT code.
329
330         Tested manually by making sure that editing/pasteboard/copy-image-with-alt-text.html
331         doesn't interfere with my clipboard while being run in a loop.
332
333         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
334         * WebKitTestRunner/mac/PoseAsClass.h: Added.
335         * WebKitTestRunner/mac/PoseAsClass.mm: Added.
336         * WebKitTestRunner/mac/TestControllerMac.mm:
337         (WTR::TestController::platformInitialize):
338         (WTR::TestController::platformDestroy):
339         * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.h: Added.
340         * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm: Added.
341
342 2013-08-26  Zan Dobersek  <zdobersek@igalia.com>
343
344         [GTK] Include most of the WebKit2 unit tests into the build and testing
345         https://bugs.webkit.org/show_bug.cgi?id=120307
346
347         Reviewed by Philippe Normand.
348
349         There are still various unit test source files that are not being included into
350         the build. This patch includes most of these, only leaving out tests that do not
351         compile or test features that are not supported by the GTK port.
352
353         * Scripts/run-gtk-tests: Skip four newly-added tests that are failing or timing out.
354         (TestRunner):
355         * TestWebKitAPI/GNUmakefile.am:
356
357 2013-08-26  Carlos Garcia Campos  <cgarcia@igalia.com>
358
359         [GTK] Allow to run tests without Xvfb in run-gtk-tests
360         https://bugs.webkit.org/show_bug.cgi?id=120298
361
362         Reviewed by Philippe Normand.
363
364         Add --no-xvfb command line option to run tests in the current
365         display.
366
367         * Scripts/run-gtk-tests:
368         (TestRunner._run_xvfb): Return early if option --no-xvfb has been
369         passed.
370         (TestRunner._setup_testing_environment): Use helper function
371         _run_xvfb to start Xvfb if needed.
372         (TestRunner._tear_down_testing_environment): Check Xvfb is
373         actually running before trying to terminate it.
374
375 2013-08-26  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
376
377         Adding Gabor Abraham to contributors.json.
378
379         Reviewed by Csaba Osztrogonác.
380
381         * Scripts/webkitpy/common/config/contributors.json:
382
383 2013-08-26  Carlos Garcia Campos  <cgarcia@igalia.com>
384
385         [GTK] Add support for passing test directories to run-gtk-tests
386         https://bugs.webkit.org/show_bug.cgi?id=120296
387
388         Reviewed by Philippe Normand.
389
390         * Scripts/run-gtk-tests:
391         (TestRunner._get_tests_from_dir): Helper function to return all
392         unit tests found in a given directory.
393         (TestRunner._get_tests): Check the given tests passed in the
394         command line, so that if a directory is found the tests contained
395         in the directory are added to the list of tests to run.
396
397 2013-08-26  Carlos Garcia Campos  <cgarcia@igalia.com>
398
399         [GTK] Improve the stop/reload button implementation in MiniBrowser
400         https://bugs.webkit.org/show_bug.cgi?id=120292
401
402         Reviewed by Philippe Normand.
403
404         - Use an instance member of BrowserWindow for the button widget
405           instead of a global variable.
406         - Use notify::is-loading to monitor the WebView load instead of
407           the estimated-load-progress property.
408         - Use webkit_web_view_is_loading() to check whether the view
409           is loading to change the button icon instead of a string
410           comparison of the gtk stock icon id.
411         - Use the right casts to fix compile warning.
412
413         * MiniBrowser/gtk/BrowserWindow.c:
414         (reloadOrStopCallback):
415         (webViewLoadProgressChanged):
416         (webViewIsLoadingChanged):
417         (browser_window_init):
418         (browserWindowConstructed):
419
420 2013-08-26  Arunprasad Rajkumar  <arurajku@cisco.com>
421
422         [Qt] Remove the fix in QWebPage::javaScriptConsoleMessage introduced by (r61433)
423         https://bugs.webkit.org/show_bug.cgi?id=119791
424
425         Reviewed by Jocelyn Turcotte.
426         
427         Load empty url to send onunload event to currently running page. onunload event is 
428         mandatory for LayoutTests/plugins/open-and-close-window-with-plugin.html and
429         LayoutTests/plugins/geturlnotify-during-document-teardown.html.
430
431         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
432         (WebPage::~WebPage):
433
434 2013-08-26  Carlos Garcia Campos  <cgarcia@igalia.com>
435
436         [GTK] Silence MiniBrowser compile warnings due to recent GTK+ deprecations
437         https://bugs.webkit.org/show_bug.cgi?id=120290
438
439         Reviewed by Philippe Normand.
440
441         * MiniBrowser/gtk/GNUmakefile.am: Add
442         -DGDK_VERSION_MIN_REQUIRED=GDK_VERSION_3_6 compile option.
443
444 2013-08-26  Zan Dobersek  <zdobersek@igalia.com>
445
446         [GTK] Add WillLoad test files to the TestWebKitAPI/TestWebKit2 program
447         https://bugs.webkit.org/show_bug.cgi?id=120288
448
449         Reviewed by Carlos Garcia Campos.
450
451         * TestWebKitAPI/GNUmakefile.am: Add the WillLoad.cpp build target that should be compiled
452         into the TestWebKit2 program. The InjectedBundle counterpart file is added to the build as well.
453         These unit tests are at the moment failing in debug configurations, so it would be nice to
454         have the GTK builds report these failures as well.
455
456 2013-08-25  Ryuan Choi  <ryuan.choi@samsung.com>
457
458         [EFL] EWebLauncher is executed as full screen with device pixel ratio
459         https://bugs.webkit.org/show_bug.cgi?id=120282
460
461         Reviewed by Gyuyoung Kim.
462
463         * EWebLauncher/main.c:
464         Use double instead of float for device_pixel_ratio which is passed to ECORE_GETOPT_VALUE_DOUBLE.
465
466 2013-08-25  Zan Dobersek  <zdobersek@igalia.com>
467
468         [gdb] Remove the pretty printer for KURLGooglePrivate
469         https://bugs.webkit.org/show_bug.cgi?id=120263
470
471         Reviewed by Benjamin Poulain.
472
473         Remove the pretty printer for the WebCore::KURLGooglePrivate structure that
474         was usable inside the gdb debugger. The structure was remove from the codebase
475         along with the GoogleURL backend for KURL.
476
477         * gdb/webkit.py:
478         (JSCJSStringPrinter.to_string):
479         (add_pretty_printers):
480
481 2013-08-24  Filip Pizlo  <fpizlo@apple.com>
482
483         Unreviewed, fix build-webkit --ftl-jit in the case that you have your own llvm directory. We need to
484         prune 'libgtest' and friends from the llvm build, since WebKit builds its own and none of the llvm
485         libraries depend on libgtest anyway.
486
487         * Scripts/copy-webkitlibraries-to-product-directory:
488
489 2013-08-24  Darin Adler  <darin@apple.com>
490
491         RetainPtr lacks move constructor for case when argument is a RetainPtr of a different type
492         https://bugs.webkit.org/show_bug.cgi?id=120255
493
494         Reviewed by Andreas Kling.
495
496         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm: Added four tests covering move assignment and construction.
497
498 2013-08-24  Anders Carlsson  <andersca@apple.com>
499
500         Don't treat NSLocalizedDescriptionKey and NSLocalizedRecoverySuggestionErrorKey as NSLocalized macros
501         https://bugs.webkit.org/show_bug.cgi?id=120249
502
503         Reviewed by Andreas Kling.
504
505         * Scripts/extract-localizable-strings:
506
507 2013-08-24  Carlos Garcia Campos  <cgarcia@igalia.com>
508
509         [GTK] Expose WebKitFrame in WebKit2GTK+ web extensions API
510         https://bugs.webkit.org/show_bug.cgi?id=119743
511
512         Reviewed by Anders Carlsson.
513
514         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
515         (WTR::InjectedBundlePage::InjectedBundlePage): Add
516         willDestroyFrame.
517
518 2013-08-23  Thiago de Barros Lacerda  <thiago.lacerda@openbossa.org>
519
520         Move TestWebKitAPI_LIBRARIES before platform specific cmake include
521         https://bugs.webkit.org/show_bug.cgi?id=120220
522
523         Reviewed by Martin Robinson.
524
525         * TestWebKitAPI/CMakeLists.txt:
526
527 2013-08-22  Filip Pizlo  <fpizlo@apple.com>
528
529         build-jsc --ftl-jit should work
530         https://bugs.webkit.org/show_bug.cgi?id=120194
531
532         Reviewed by Oliver Hunt.
533
534         * Scripts/build-jsc: Need to pass the feature flag to xcodebuild
535
536 2013-08-23  Commit Queue  <commit-queue@webkit.org>
537
538         Unreviewed, rolling out r153534.
539         http://trac.webkit.org/changeset/153534
540         https://bugs.webkit.org/show_bug.cgi?id=120216
541
542         Too many tests failing just WinEWS bots (Requested by rfong on
543         #webkit).
544
545         * Scripts/webkitpy/common/config/ews.json:
546
547 2013-08-23  Alex Christensen  <alex.christensen@flexsim.com>
548
549         Unreviewed.  Added my webkit.org email address.
550
551         * Scripts/webkitpy/common/config/contributors.json:
552
553 2013-08-23  Peter Gal  <galpeter@inf.u-szeged.hu>
554
555         [WTR] Should dump as text when the mimetype is text/plain
556         https://bugs.webkit.org/show_bug.cgi?id=118306
557
558         Reviewed by Christophe Dumez.
559
560         Check for the text/plain mimetype and if true then mark it as
561         text dump.
562
563         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
564         (WTR::InjectedBundlePage::dump):
565
566 2013-08-22  Filip Pizlo  <fpizlo@apple.com>
567
568         Update LLVM binary drops and scripts to the latest version from SVN
569         https://bugs.webkit.org/show_bug.cgi?id=120184
570
571         Reviewed by Mark Hahnenberg.
572
573         * ReducedFTL/build.sh:
574         * Scripts/configure-llvm: Added.
575         * Scripts/copy-webkitlibraries-to-product-directory:
576         * Scripts/export-llvm-build:
577
578 2013-08-22  Andy Estes  <aestes@apple.com>
579
580         <https://webkit.org/b/120180> Fix issues with OTHER_LDFLAGS in various .xcconfig files
581
582         Reviewed by David Kilzer.
583
584         * TestWebKitAPI/Configurations/Base.xcconfig: Removed the definition of
585         OTHER_CPLUSPLUSFLAGS since -ftemplate-depth=256 is already set in
586         DebugRelease.xcconfig and TestWebKitAPI isn't built in Production.
587
588 2013-08-22  Ryosuke Niwa  <rniwa@webkit.org>
589
590         NRWT: Add the ability to upload test results to new test results server
591         https://bugs.webkit.org/show_bug.cgi?id=120146
592
593         Reviewed by Andreas Kling.
594         
595         For the upcoming replacement for webkit-test-results.appspot.com, new-run-webkit-tests needs to use a new JSON format
596         that contains the full summary of the test run including information about passed tests.
597
598         Add this ability to NRWT so that I can start testing this feature. This patch adds the following optoins to NRWT:
599         --build-slave
600         --got-revision
601         --results-server-host
602
603         The last option is somewhat ambigious with --test-results-server but we're intending to deprecate the old server
604         so we should be able to delete --test-results-server in time.
605
606         * Scripts/webkitpy/layout_tests/controllers/manager.py:
607         (Manager.run):
608         (Manager._upload_json_files):
609         (Manager):
610         (Manager.upload_results):
611         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
612         (summarize_results):
613         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
614         (summarized_results):
615         (SummarizedResultsTest.test_summarized_results_wontfix):
616         (SummarizedResultsTest):
617         (SummarizedResultsTest.test_summarized_results_include_passes):
618         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
619         (parse_args):
620
621 2013-08-22  Ryosuke Niwa  <rniwa@webkit.org>
622
623         WKR build fix. Somehow tool.bugs.quips() doesn't work in WKR so work around that.
624
625         * Scripts/webkitpy/tool/bot/irc_command.py:
626         (Hi.execute):
627
628 2013-08-22  Allan Sandfeld Jensen  <allan.jensen@digia.com>
629
630         [Qt] DRT bug revealed/caused by r154300
631         https://bugs.webkit.org/show_bug.cgi?id=120151
632
633         Reviewed by Simon Hausmann.
634
635         Since QtInstance had an implementation of getOwnPropertySlot and not getOwnPropertyDescriptor,
636         the behavior of getOwnPropertyDescriptor changed when it got implemented using getOwnPropertySlot
637         in r154300.
638
639         DRT relied on getOwnPropertyDescriptor returning undefined for JS set properties to distinguish
640         between native Qt methods and JSC bound methods. This patch changes the check to see if the 
641         property is writable since the Qt methods are ReadOnly.
642
643         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
644         (DumpRenderTree::initJSObjects):
645
646 2013-08-21  Joseph Pecoraro  <pecoraro@apple.com>
647
648         <https://webkit.org/b/120134> [Tools] lldb_webkit.py helpers is incorrectly printing 8bit Strings
649
650         Reviewed by Benjamin Poulain.
651
652         WTFString moved the is8bit bit by one in r152201.
653
654         * lldb/lldb_webkit.py:
655         (WTFStringImplProvider.is_8bit):
656
657 2013-08-21  Tim Horton  <timothy_horton@apple.com>
658
659         Revert http://trac.webkit.org/changeset/154022, as it failed to update
660         a variety of scripts that depended on the old format.
661
662         See https://bugs.webkit.org/show_bug.cgi?id=120131 for one such example.
663
664         * Scripts/prepare-ChangeLog:
665         (main):
666         (generateNewChangeLogs):
667
668 2013-08-21  Brent Fulgham  <bfulgham@apple.com>
669
670         [Windows] Unreviewed gardening: WebInspector should always be enabled for WinLauncher.
671
672         * WinLauncher/WinLauncher.cpp:
673         (setToDefaultPreferences): Activate Developer Extras on Release (as well as Debug) builds.
674
675 2013-08-21  Zan Dobersek  <zdobersek@igalia.com>
676
677         <https://webkit.org/b/120116> [GTK] Fix a typo in ActivateFontsGtk.cpp
678
679         Reviewed by Andreas Kling.
680
681         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
682         (WTR::initializeFontConfigSetting): Fix a typo - inititialize -> initialize.
683         (WTR::activateFonts): Ditto.
684
685 2013-08-21  Brian Holt  <brian.holt@samsung.com>
686
687         [GTK] Suppress irrelevant or known leaks for Valgrind
688         https://bugs.webkit.org/show_bug.cgi?id=119448
689
690         Reviewed by Martin Robinson.
691
692         Add a suppressions file to suppress known leaks for Valgrind.
693         Valgrind also takes longer when using suppressions and
694         times out unless the driver timeout is increased.
695
696         * Scripts/valgrind/suppressions.txt: Added.
697         * Scripts/webkitpy/port/gtk.py:
698         (GtkPort.driver_stop_timeout):
699         (GtkPort.setup_environ_for_server):
700
701 2013-08-20  Alex Christensen  <achristensen@apple.com>
702
703         [Windows] Linking fix for Win64.
704
705         Rubberstamped by Brent Fulgham.
706
707         * win/DLLLauncher/DLLLauncherMain.cpp:
708         (wWinMain): Corrected 64-bit linker symbol for dllLauncherEntryPoint.
709
710 2013-08-20  Brent Fulgham  <bfulgham@apple.com>
711
712         <https://webkit.org/b/120090> Report better error messages from WinLauncher/DRT
713
714         Reviewed by Tim Horton.
715
716         * win/DLLLauncher/DLLLauncherMain.cpp:
717         (getLastErrorString): New method to convert GetLastError to text.
718         (wWinMain): Use new error formatter to provide useful diagnostic text to user.
719
720 2013-08-19  Gustavo Noronha Silva  <gns@gnome.org>
721
722         <https://webkit.org/b/120048> [GTK] Add stubs for APIs that went missing in the DOM bindings
723
724         Reviewed by Martin Robinson.
725
726         * Scripts/webkitpy/style/checker.py: add the bindings custom implementation files to be exempt
727         from naming/enum_casing rules, since it needs to provide GObject-style APIs.
728
729 2013-08-20  Anton Obzhirov  <a.obzhirov@samsung.com>
730
731         <https://webkit.org/b/120009> [GTK] Stop button should be added to MiniBrowser
732
733         Reviewed by Martin Robinson.
734
735         Added stop button in MiniBrowser
736
737         * MiniBrowser/gtk/BrowserWindow.c:
738         (reloadOrStopCallback): Callback to handle stop or reload button click.
739         (webViewLoadProgressChanged): Update reload or stop button icon.
740         (browser_window_init): Save button pointer for further icon updates.
741
742 2013-08-20  Simon Pena  <simon.pena@samsung.com>
743
744         <https://webkit.org/b/117584> [GTK][WK1] http/tests/loading/unfinished-load-back-to-cached-page-callbacks.html is failing
745
746         Reviewed by Alexey Proskuryakov.
747
748         Update DumpRenderTree to handle the WEBKIT_LOAD_FAILED status,
749         printing didFailLoadWithError.
750
751         Behave like other ports, and handle WEBKIT_LOAD_FAILED status in
752         DumpRenderTree, printing didFailLoadWithError.
753
754         * DumpRenderTree/gtk/DumpRenderTree.cpp:
755         (webFrameLoadStatusNotified):
756
757 2013-08-19  Ryosuke Niwa  <rniwa@webkit.org>
758
759         <https://webkit.org/b/120049> Delete code for Snow Leopard
760
761         Reviewed by Benjamin Poulain.
762
763         * DumpRenderTree/mac/CheckedMalloc.cpp:
764         (protectionOfRegion):
765         (makeLargeMallocFailSilently):
766         * DumpRenderTree/mac/DumpRenderTree.mm:
767         (resetDefaultsToConsistentValues):
768         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
769         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
770         * DumpRenderTree/mac/FrameLoadDelegate.mm:
771         (testPathFromURL):
772         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
773         * DumpRenderTree/mac/LayoutTestHelper.m:
774         * DumpRenderTree/mac/TestRunnerMac.mm:
775         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
776         (WTR::InjectedBundle::platformInitialize):
777         * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
778         (WTR::testPathFromURL):
779         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
780
781 2013-08-19  Alexey Proskuryakov  <ap@apple.com>
782
783         https://bugs.webkit.org/show_bug.cgi?id=119915
784         REGRESSION(r154144): ASSERTION FAILED: m_history->provisionalItem() == m_requestedHistoryItem.get()
785
786         Reviewed by Darin Adler.
787
788         The issue was that we ended up having no CFNetwork cache in the testing session due
789         to an incorrect cache model. There is a number of things not implemented when it
790         comes to dynamically changing cache model as attempted by WebKitTestRunner, but
791         the easiest way to get this going is to initialize it to correct value upfront.
792
793         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
794
795 2013-08-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
796
797         REGRESSION(r154275): webkitpy tests failing
798         https://bugs.webkit.org/show_bug.cgi?id=120010
799
800         Reviewed by Jocelyn Turcotte.
801
802         Update unit-tests to tests the new search-path structure,
803         but reverting the architecture search path addition.
804
805         * Scripts/webkitpy/port/qt.py:
806         (QtPort):
807         (QtPort.__init__):
808         (QtPort._generate_all_test_configurations):
809         (QtPort.qt_architecture):
810         * Scripts/webkitpy/port/qt_unittest.py:
811         (QtPortTest):
812         (QtPortTest._assert_search_path):
813         (QtPortTest._assert_expectations_files):
814         (QtPortTest._qt_version):
815
816 2013-08-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
817
818         [Qt] Keep the qt-5.0-wk2 search path until the expectation migration is completed
819
820         Unreviewed meta gardening.
821
822         We need to keep using the qt-5.0-wk2 path until it is fully migrated.
823
824         * Scripts/webkitpy/port/qt.py:
825         (QtPort._search_paths):
826
827 2013-08-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
828
829         Restructure Qt test expectations
830
831         Unreviewed meta gardening.
832
833         Removed 5.0 name from WK1 and WK2 results and made it possible to set
834         expectations by both Qt version and mayor architectures.
835
836         * Scripts/webkitpy/port/qt.py:
837         (QtPort._wk2_port_name):
838         (QtPort.__init__):
839         (QtPort.qt_version):
840         (QtPort.architecture):
841         (QtPort._search_paths):
842         (QtPort._port_specific_expectations_files):
843
844 2013-08-16  Brent Fulgham  <bfulgham@apple.com>
845
846         [Windows] DRT is not using the same preferences as the Mac build.
847         https://bugs.webkit.org/show_bug.cgi?id=119822
848
849         Reviewed by Darin Adler.
850
851         * DumpRenderTree/win/DumpRenderTree.cpp:
852         (runTest): Process Windows message queue using CFRunLoop to allow
853         dispatch routines to run properly.
854         (dllLauncherEntryPoint): Wrap CG-specific setup code in a macro
855         to prevent problems on WinCairo port.
856
857 2013-08-16  Brent Fulgham  <bfulgham@apple.com>
858
859         [Windows] URL printing code in DRT doesn't match WTR or Mac DRT
860         https://bugs.webkit.org/show_bug.cgi?id=119583
861
862         Reviewed by Alexey Proskuryakov.
863
864         * DumpRenderTree/win/DumpRenderTree.cpp:
865         (urlSuitableForTestResult): Revise URL output to match Mac DRT by emiting last path
866         component if the URL does not contain the expected base URL.
867
868 2013-08-16  Pratik Solanki  <psolanki@apple.com>
869
870         <https://webkit.org/b/119852> Frame::scriptController() should return a reference
871
872         Reviewed by Andreas Kling.
873
874         m_script is never NULL so we can just return a reference. Also remove some pointless null
875         checks as a result of doing this.
876
877         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
878         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
879
880 2013-08-15  Alexey Proskuryakov  <ap@apple.com>
881
882         [WK2] NetworkProcess should use a temporary storage session for test
883         https://bugs.webkit.org/show_bug.cgi?id=119855
884
885         Reviewed by Darin Adler.
886
887         Use a new API that takes care of both WebProcess and NetworkProcess.
888
889         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
890         (WTR::InjectedBundle::initialize):
891         * WebKitTestRunner/TestController.cpp:
892         (WTR::TestController::initialize):
893
894 2013-08-15  Bem Jones-Bey  <bjonesbe@adobe.com>
895
896         <https://webkit.org/b/119850> Speed up test importing by doing all the regex matching in a single pass
897
898         Reviewed by Dirk Pranke.
899
900         This is a port from Blink of
901         https://src.chromium.org/viewvc/blink?revision=155647&view=revision
902         originally by Dirk Pranke.
903
904         From the original commit:
905
906         This gives something like a 15x speedup over compiling and matching
907         one property at a time and doing multiple passes over the file.
908
909         * Scripts/webkitpy/w3c/test_converter.py:
910         (W3CTestConverter.__init__):
911         (W3CTestConverter.convert_prefixed_properties):
912         (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
913
914 2013-08-15  Dan Bernstein  <mitz@apple.com>
915
916         <https://webkit.org/b/119856> Improve extract-localizable-strings messages
917
918         Reviewed by Darin Adler.
919
920         * Scripts/extract-localizable-strings: When the strings file disagrees with the source code,
921         added a message that points to the source code. Removed some unnecessary repetition of what
922         is already in the file.
923
924 2013-08-15  Andy Estes  <aestes@apple.com>
925
926         <https://webkit.org/b/119853> REGRESSION (r139343): WebKit crashes when canceling a load inside webView:resource:didFinishLoadingFromDataSource:
927
928         Reviewed by Brady Eidson.
929
930         Wrote an API test that verifies -[WebView stopLoading:] can be called
931         inside webView:resource:didFinishLoadingFromDataSource: without crashing.
932
933         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
934         * TestWebKitAPI/Tests/mac/StopLoadingFromDidFinishLoading.mm: Added.
935         (-[StopLoadingFromDidFinishLoadingDelegate webView:resource:didFinishLoadingFromDataSource:]):
936         (TestWebKitAPI::TEST):
937
938 2013-08-15  Alexey Proskuryakov  <ap@apple.com>
939
940         Adding Myles Maxfield to contributors.json.
941
942         Oops, wrong section, fixing.
943
944         * Scripts/webkitpy/common/config/contributors.json:
945
946 2013-08-15  Alexey Proskuryakov  <ap@apple.com>
947
948         Adding Myles Maxfield to contributors.json.
949
950         * Scripts/webkitpy/common/config/contributors.json:
951
952 2013-08-15  Allan Sandfeld Jensen  <allan.jensen@digia.com>
953
954         [Qt] Do not check specifically for version 5.0
955         https://bugs.webkit.org/show_bug.cgi?id=119846
956
957         Reviewed by Jocelyn Turcotte.
958
959         For Qt 5.x we should always use both wk1 and wk2 basepath results.
960
961         * Scripts/webkitpy/port/qt.py:
962         (QtPort._search_paths):
963
964 2013-08-15  Simon Pena  <simon.pena@samsung.com>
965
966         <https://webkit.org/b/119584> [Gtk] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT
967
968         Reviewed by Gustavo Noronha Silva.
969
970         Following a similar approach as in r153977, return a path string
971         that is relative to main frame URL or just file name if the
972         resource is not in the same directory subtree, and replace empty
973         strings with "(null)".
974
975         Update pathFromSoupURI so it behaves more closely to the other
976         ports, and remove the unused code after we no longer print
977         <unknown> in certain cases. Also move
978         soupURIToStringPreservingPassword to DumpRenderTreeGtk so it can
979         be used both in TestRunnerGtk and in DumpRenderTree.
980
981         * DumpRenderTree/gtk/DumpRenderTree.cpp:
982         (soupURIToStringPreservingPassword): Moved from TestRunnerGtk so
983         we can print Soup URIs with the password, since soup_uri_to_string
984         doesn't preserve them.
985         (pathFromSoupURI): Updated following EFL implementation in
986         r153977, and return a WTFString instead of a CString.
987         (convertSoupMessageToURLPath): Return "(null)" instead of empty
988         strings, and handle the new return type of pathFromSoupURI.
989         (convertWebResourceToURLPath): Use a GOwnPtr to hold the Soup URI
990         reference, and handle the new return type of pathFromSoupURI.
991         (descriptionSuitableForTestResult): Remove unused code.
992         (didFinishLoading): Use convertResourceToURLPath.
993         (didFailLoadingWithError): Use convertResourceToURLPath.
994         (authenticationCallback): Display the URL of the authentication
995         challenge.
996         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Declare
997         soupURIToStringPreservingPassword.
998         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove
999         soupURIToStringPreservingPassword.
1000
1001 2013-08-14  Tim Horton  <timothy_horton@apple.com>
1002
1003         Un-inline dataLog dumpers for IntSize and IntPoint
1004         https://bugs.webkit.org/show_bug.cgi?id=119697
1005
1006         Reviewed by Sam Weinig.
1007
1008         * TestWebKitAPI/GNUmakefile.am:
1009
1010 2013-08-14  Ryosuke Niwa  <rniwa@webkit.org>
1011
1012         Flakiness dashboard build fix.
1013
1014         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1015         (processTestRunsForBuilder):
1016
1017 2013-08-14  Martin Robinson  <mrobinson@igalia.com>
1018
1019         [GTK] [CMake] Add support for building TestWebKitAPI
1020         https://bugs.webkit.org/show_bug.cgi?id=116987
1021
1022         Reviewed by Philippe Normand.
1023
1024         * TestWebKitAPI/CMakeLists.txt: Move the library listings to before the inclusion of the
1025         platform-specific file, so that GTK+ can override them.
1026         * TestWebKitAPI/PlatformGTK.cmake: Added.
1027
1028 2013-08-14  Brent Fulgham  <bfulgham@apple.com>
1029
1030         [Windows] Simplify Setting WebKit Debugging Options in WinLauncher
1031         https://bugs.webkit.org/show_bug.cgi?id=119775
1032
1033         This bug updates the WinLauncher program with a few useful menu
1034         options to toggle certain debugging and development features of
1035         WebKit.
1036
1037         Reviewed by Tim Horton.
1038
1039         * WinLauncher/WinLauncher.cpp:
1040         (dllLauncherEntryPoint): Clean up preference objects on exit.
1041         (ToggleMenuItem): New function.
1042         (LaunchInspector): New function.
1043         (WndProc): Add handler for new menu items. Also properly terminate
1044         CFRunLoop operation on program exit.
1045         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add new
1046         menu items.
1047         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Add
1048         resource folder to search path.
1049         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Update
1050         for new menu items.
1051
1052 2013-08-14  Ryosuke Niwa  <rniwa@webkit.org>
1053
1054         Add a hyperlink from build.webkit.org to the flakiness dashboard.
1055
1056         Rubbers-tamped by Simon Fraser.
1057
1058         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1059
1060 2013-08-14  Benjamin Dupont   <bdupont@nds.com>
1061
1062         [Qt] Activate visibility API layout tests
1063         https://bugs.webkit.org/show_bug.cgi?id=119790
1064
1065         Reviewed by Allan Sandfeld Jensen.
1066
1067         * DumpRenderTree/qt/TestRunnerQt.cpp:
1068         (TestRunner::resetPageVisibility):
1069         (TestRunner::setPageVisibility):
1070
1071 2013-08-13  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1072
1073         [GTK] WK does not link properly against libxslt
1074         https://bugs.webkit.org/show_bug.cgi?id=119688
1075
1076         Reviewed by Gustavo Noronha Silva.
1077
1078         * MiniBrowser/gtk/GNUmakefile.am: Added LIBXSLT_LIBS to
1079         MiniBrowser.
1080         * WebKitTestRunner/GNUmakefile.am: Added LIBXSLT_LIBS to WTR.
1081
1082 2013-08-13  Alexey Proskuryakov  <ap@apple.com>
1083
1084         [Mac] fast/dom/attr-style-too-lazy.html is flaky
1085         https://bugs.webkit.org/show_bug.cgi?id=119763
1086
1087         Reviewed by Darin Adler.
1088
1089         * DumpRenderTree/mac/UIDelegate.mm:
1090         (-[UIDelegate webView:setStatusText:]): Don't dump anything when not running
1091         a test, it would just semi-randomly leak to the next one.
1092         (-[UIDelegate webView:didPressMissingPluginButton:]): Added same check here, just
1093         for good measure.
1094
1095 2013-08-13  Tim Horton  <timothy_horton@apple.com>
1096
1097         [mac] Give MiniBrowser a reasonable bundle identifier
1098         https://bugs.webkit.org/show_bug.cgi?id=119773
1099
1100         Rubber-stamped by Simon Fraser.
1101
1102         Give MiniBrowser the bundle identifier org.webkit.MiniBrowser.
1103
1104         * MiniBrowser/mac/Info.plist:
1105         * MiniBrowser/mac/WebBundle/Info.plist:
1106
1107 2013-08-13  Dean Jackson  <dino@apple.com>
1108
1109         <https://webkit.org/b/119766> Make bug url more human friendly in ChangeLog
1110
1111         Reviewed by Mark Rowe.
1112
1113         Have prepare-ChangeLog produce webkit.org/b/id style
1114         URLs rather than exposing the inner workings of our
1115         cgi. I was going to use the term "Future Proofing"
1116         but that seems excessive :)
1117
1118         * Scripts/prepare-ChangeLog:
1119         (main): Generate a more human readable form.
1120         (generateNewChangeLogs): Use it when printing out the ChangeLog entry.
1121
1122 2013-08-13  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1123
1124         [EFL][DRT] Simplify call to reverseFind()
1125         https://bugs.webkit.org/show_bug.cgi?id=119746
1126
1127         Reviewed by Christophe Dumez.
1128
1129         Follow-up to r153977.
1130
1131         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1132         (pathSuitableForTestResult): Instead of defining a static variable
1133         that's only used in a single place, pass '/' to reverseFind() directly.
1134
1135 2013-08-13  Alberto Garcia  <berto@igalia.com>
1136
1137         [GTK] Closing inspector window crashes wk
1138         https://bugs.webkit.org/show_bug.cgi?id=110865
1139
1140         Reviewed by Carlos Garcia Campos.
1141
1142         Disconnect all signal handlers if the inspector window is
1143         destroyed.
1144
1145         * GtkLauncher/LauncherInspectorWindow.c:
1146         (inspectorWindowDestroyed):
1147         (launcherInspectorWindowNew):
1148
1149 2013-08-12  Dan Bernstein  <mitz@apple.com>
1150
1151         extract-localizable-strings output is not suited for parsing by Xcode
1152         https://bugs.webkit.org/show_bug.cgi?id=119728
1153
1154         Reviewed by Darin Adler.
1155
1156         Added spaces where needed after “path:line:” to allow Xcode to recognize the file reference,
1157         removed “ERROR” since messages that refer to a line in a file are shown as error by default,
1158         added “warning: ” in messages that aren’t errors (i.e. don’t prevent the script from exiting
1159         with 0).
1160
1161         * Scripts/extract-localizable-strings:
1162
1163 2013-08-12  Ryuan Choi  <ryuan.choi@samsung.com>
1164
1165         [EFL][WK1] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT
1166         https://bugs.webkit.org/show_bug.cgi?id=119585
1167
1168         Reviewed by Gyuyoung Kim.
1169
1170         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1171         (pathSuitableForTestResult):
1172         Return path string that's relative to main frame URL, or just file name if
1173         the resource is not in the same directory subtree.
1174         Referenced WebKitTestRunner code in r153852.
1175         (descriptionSuitableForTestResult):
1176         (DumpRenderTreeChrome::onFrameRedirectRequested):
1177         (DumpRenderTreeChrome::onNewResourceRequest): Followed changes of r153903.
1178
1179 2013-08-12  Dan Bernstein  <mitz@apple.com>
1180
1181         extract-localizable-strings doesn't know how to verify an existing strings file
1182         https://bugs.webkit.org/show_bug.cgi?id=119704
1183
1184         Reviewed by Darin Adler.
1185
1186         * Scripts/extract-localizable-strings: Added an --exceptions option for specifying the
1187         exceptions file, changing the way “no exceptions file” is expressed from passing “-” as the
1188         exceptions file name to omitting the --exceptions option. Added a --skip option, changing
1189         the way directories to skip are specified from prefixing the directory with a “-” to
1190         specifying it with --skip.
1191         Finally, added a --verify option. When specified, the strings file is not written to, but
1192         instead read in and checked for consistency with the comments, keys and values derived from
1193         the source files and the exceptions file. Missing keys, unused keys, mismatching values and
1194         mismatching comments are reported as errors.
1195         * Scripts/update-webkit-localizable-strings: Updated for the new way of specifying
1196         directories to skip and no exceptions file.
1197
1198 2013-08-12  Alexey Proskuryakov  <ap@apple.com>
1199
1200         http/tests/security/sandboxed-iframe-invalid.html is flaky on Mac
1201         https://bugs.webkit.org/show_bug.cgi?id=85522
1202
1203         Reviewed by Andy Estes.
1204
1205         * DumpRenderTree/mac/UIDelegate.mm:
1206         (-[UIDelegate webView:addMessageToConsole:withSource:]): Don't print console messages
1207         when already done with a test. We already had this check in all UI delegate functions,
1208         except for -webView:addMessageToConsole:withSource: somehow.
1209
1210 2013-08-12  Alexey Proskuryakov  <ap@apple.com>
1211
1212         https://bugs.webkit.org/show_bug.cgi?id=119693
1213         [Mac] security/contentSecurityPolicy/connect-src-websocket-blocked.html is flaky
1214         because of connect-src-websocket-allowed.html
1215
1216         Reviewed by Darin Adler.
1217
1218         Starting a load of about:blank and immediately stopping it cancels outstanding
1219         resource loads, but the page has to transition to committed state to have timers
1220         or WebSockets stopped too.
1221
1222         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Use a synchronous load to
1223         ensure that transition to committed state happens before we start the next test.
1224
1225 2013-08-12  Beth Dakin  <bdakin@apple.com>
1226
1227         The LayoutMilestones didLayout callback should only fire for the main frame
1228         https://bugs.webkit.org/show_bug.cgi?id=119457
1229
1230         Reviewed by Sam Weinig.
1231
1232         Now that the didLayout callback only fires for the main frame, we want to make 
1233         sure it will fire even when all of the content is in a subframe.
1234
1235         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1236         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp: Added.
1237         (TestWebKitAPI::didLayout):
1238         (TestWebKitAPI::TEST):
1239         * TestWebKitAPI/Tests/WebKit2/all-content-in-one-iframe.html: Added.
1240
1241 2013-08-12  Beth Dakin  <bdakin@apple.com>
1242
1243         Remove didNewFirstVisuallyNonEmptyLayout from WebKit2
1244         https://bugs.webkit.org/show_bug.cgi?id=119658
1245
1246         Reviewed by Darin Adler.
1247
1248         * MiniBrowser/mac/WK2BrowserWindowController.m:
1249         (-[WK2BrowserWindowController awakeFromNib]):
1250         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1251         (WTR::InjectedBundlePage::InjectedBundlePage):
1252         * WebKitTestRunner/TestController.cpp:
1253         (WTR::TestController::createWebViewWithOptions):
1254
1255 2013-08-12  Seokju Kwon  <seokju@webkit.org>
1256
1257         Remove glu's libtest rule from checker.py
1258         https://bugs.webkit.org/show_bug.cgi?id=119674
1259
1260         Reviewed by Darin Adler.
1261
1262         * Scripts/webkitpy/style/checker.py: It is no longer used after r148032.
1263
1264 2013-08-11  ChangSeok Oh  <changseok.oh@collabora.com>
1265
1266         Unreviewed. Change my primary mail address.
1267
1268         * Scripts/webkitpy/common/config/contributors.json:
1269
1270 2013-08-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1271
1272         [GTK] Misses mod_ssl and php in the list of packages required for tests for yum
1273         https://bugs.webkit.org/show_bug.cgi?id=115751
1274
1275         Reviewed by Martin Robinson.
1276
1277         * gtk/install-dependencies: add mod_ssl and php to the packages installed for tests
1278         with yum.
1279
1280 2013-08-09  Beth Dakin  <bdakin@apple.com>
1281
1282         AX: Not able to use arrow keys to read text in a WK2 app
1283         https://bugs.webkit.org/show_bug.cgi?id=119605
1284         -and corresponding-
1285         <rdar://problem/14281275>
1286
1287         Reviewed by Darin Adler.
1288
1289         New test verifies that didNotHandleKeyEvent will be called when there is nothing 
1290         to scroll. 
1291         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1292         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp: Added.
1293         (TestWebKitAPI::didFinishLoadForFrame):
1294         (TestWebKitAPI::didNotHandleKeyEventCallback):
1295         (TestWebKitAPI::TEST):
1296
1297 2013-08-09  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1298
1299         Add support for KeyboardEvent.location attribute
1300         https://bugs.webkit.org/show_bug.cgi?id=119326
1301
1302         Reviewed by Benjamin Poulain.
1303
1304         Rename the deprecated 'keyLocation' to 'location' in Mac's DRT code.
1305
1306         * DumpRenderTree/mac/EventSendingController.mm:
1307         (-[EventSendingController keyDown:withModifiers:withLocation:]):
1308         (-[EventSendingController keyDownWrapper:withModifiers:withLocation:]):
1309         (-[EventSendingController scheduleAsynchronousKeyDown:withModifiers:withLocation:]):
1310         (-[EventSendingController handleEvent:]):
1311         (-[EventSendingController fireKeyboardEventsToElement:]):
1312
1313 2013-08-09  Alexey Proskuryakov  <ap@apple.com>
1314
1315         <unknown> is often dumped instead of path in test output
1316         https://bugs.webkit.org/show_bug.cgi?id=119590
1317
1318         Reviewed by Anders Carlsson.
1319
1320         There were two reasons for <unknown>:
1321         1. When delegate logging is enabled via a testRunner call, that obviously happens
1322         after main resource load starts, so we don't record its URL.
1323         2. Authentication delegate logging relied on URL recording, but it's only turned on
1324         when enabling resource loading delegate logging, not auth one.
1325
1326         URL recording was made conditional in <http://trac.webkit.org/r19316>, which was
1327         landed without posted rationale and unreviewed. Just undoing that change now.
1328
1329         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1330         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1331         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1332         (WTR::InjectedBundlePage::didInitiateLoadForResource):
1333
1334 2013-08-08  Alex Christensen  <achristensen@apple.com>
1335
1336         Windows build fixes.
1337
1338         Rubberstamped by Brent Fulgham.
1339
1340         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
1341         Removed /SAFESEH link option which doesn't work with x64.
1342
1343 2013-08-08  Daniel Bates  <dabates@apple.com>
1344
1345         Add iOS support to run-javascriptcore-tests
1346         https://bugs.webkit.org/show_bug.cgi?id=119602
1347
1348         Reviewed by Joseph Pecoraro.
1349
1350         Make run-javascriptcore-tests work for iOS WebKit.
1351
1352         * Scripts/run-javascriptcore-tests:
1353
1354 2013-08-08  Alexey Proskuryakov  <ap@apple.com>
1355
1356         [WK2] loader/go-back-cached-main-resource.html fails
1357         https://bugs.webkit.org/show_bug.cgi?id=116491
1358
1359         Reviewed by Tim Horton.
1360
1361         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1362         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1363         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1364         * DumpRenderTree/win/DumpRenderTree.cpp:
1365         Added FIXMEs about making path printing normalization more compatible.
1366
1367         * DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[NSURL _drt_descriptionSuitableForTestResult]):
1368         Return last path component in cases where we used to return a full path, which is
1369         never desirable. Added a null check to basePath to prevent potentially getting
1370         an Objective C exception.
1371
1372         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1373         (WTR::pathSuitableForTestResult): Changed to use path for main test window, not
1374         for a currently loading one (which is different for tests that use multiple windows).
1375         Changed to return "(null)" for empty URLs to match WK1 output. Changed to return
1376         last path component as last fallback.
1377         (WTR::dumpRequestDescriptionSuitableForTestResult): We no longer need to pass main
1378         frame URL here, and it was potentially a wrong frame.
1379         (WTR::dumpResponseDescriptionSuitableForTestResult): Ditto.
1380         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Ditto.
1381         (WTR::InjectedBundlePage::didInitiateLoadForResource): Ditto.
1382         (WTR::InjectedBundlePage::willSendRequestForFrame): Ditto.
1383         (WTR::InjectedBundlePage::didReceiveResponseForResource): Ditto.
1384
1385 2013-08-08  Alex Christensen  <achristensen@apple.com>
1386
1387         WTR::pathSuitableForTestResult should behave the same as _drt_descriptionSuitableForTestResult so we can unskip tests.
1388         https://bugs.webkit.org/show_bug.cgi?id=116125
1389
1390         Reviewed by Tim Horton. Tweaked and re-landed by Alexey Proskuryakov.
1391
1392         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1393         (WTR::pathSuitableForTestResult):
1394         Changed string operations to match _drt_descriptionSuitableForTestResult.
1395         (WTR::dumpRequestDescriptionSuitableForTestResult):
1396         (WTR::dumpResponseDescriptionSuitableForTestResult):
1397         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
1398         (WTR::InjectedBundlePage::didInitiateLoadForResource):
1399         (WTR::InjectedBundlePage::willSendRequestForFrame):
1400         (WTR::InjectedBundlePage::didReceiveResponseForResource):
1401         Pass the main frame's URL to pathSuitableForTestResult.
1402         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1403         Added WKBundlePageRef to willPerformClientRedirectForFrame.
1404
1405 2013-08-07  Simon Fraser  <simon.fraser@apple.com>
1406
1407         Allow the DumpRenderTree runloop to be idle while waiting for a test to complete
1408         https://bugs.webkit.org/show_bug.cgi?id=119317
1409
1410         Reviewed by Tim Horton.
1411         
1412         The change in r55200 made DumpRenderTree spin a busy-loop while waiting for
1413         the test to complete, which is not power friendly. Although DRT instances
1414         are generally busy anyway, not sitting in a busy loop should free up some CPU
1415         cycles for other instances of DRT.
1416         
1417         Editing tests continue to pass. All Java tests are skipped and were not
1418         tested, but when run fail similarly with and without the patch.
1419
1420         * DumpRenderTree/mac/DumpRenderTree.mm:
1421         (dump):
1422         (runTest):
1423
1424 2013-08-07  Daniel Bates  <dabates@apple.com>
1425
1426         Clean up: Simplifying the printing of the command line arguments passed to jsDriver.pl
1427         <https://bugs.webkit.org/show_bug.cgi?id=119558>
1428
1429         Reviewed by Martin Robinson.
1430
1431         Currently we build the command line to execute jsDriver.pl twice so as to both
1432         print it to standard output and actually execute it. We should only build up
1433         this command line once. Moreover, we should print to standard output the actual
1434         command line that we are going to use including the GTK- and EFL-specific call
1435         to /Tools/jhbuild/jhbuild-wrapper.
1436
1437         * Scripts/run-javascriptcore-tests:
1438
1439 2013-08-07  Mario Sanchez Prada  <mario.prada@samsung.com>
1440
1441         [EFL] REGRESSION after r153432: some accessibility tests crash.
1442         https://bugs.webkit.org/show_bug.cgi?id=119333
1443
1444         Reviewed by Darin Adler.
1445
1446         Use a RefPtr to store a reference to the parent element of
1447         an AccessibilityUIElement instead of the raw pointer, so we
1448         never derefence a function from an invalid pointer.
1449
1450         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1451         (WTR::attributesOfElement): Use a RefPtr instead of a raw pointer.
1452
1453 2013-08-07  Cosmin Truta  <ctruta@blackberry.com>
1454
1455         Unreviewed. Add myself as a committer.
1456
1457         * Scripts/webkitpy/common/config/contributors.json:
1458
1459 2013-08-04  Sam Weinig  <sam@webkit.org>
1460
1461         Remove support for HTML5 MicroData
1462         https://bugs.webkit.org/show_bug.cgi?id=119480
1463
1464         Reviewed by Anders Carlsson.
1465
1466         * Scripts/webkitperl/FeatureList.pm:
1467         * qmake/mkspecs/features/features.pri:
1468
1469 2013-07-23  David Farler  <dfarler@apple.com>
1470
1471         Provide optional OTHER_CFLAGS, OTHER_CPPFLAGS, OTHER_LDFLAGS additions for building with ASAN
1472         https://bugs.webkit.org/show_bug.cgi?id=117762
1473
1474         Reviewed by Mark Rowe.
1475
1476         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1477         Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
1478         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1479         Add ASAN_OTHER_LDFLAGS.
1480         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1481         Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
1482         * Scripts/check-for-weak-vtables-and-externals:
1483         Ignore ___asan externals, these are populated by compiler-rt.
1484         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1485         Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
1486         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1487         Add ASAN_OTHER_LDFLAGS.
1488         * WebKitLauncher/Configurations/Base.xcconfig:
1489         Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
1490         * WebKitLauncher/Configurations/WebKitNightlyEnabler.xcconfig:
1491         Add ASAN_OTHER_LDFLAGS.
1492         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1493         Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
1494         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1495         Add ASAN_OTHER_LDFLAGS.
1496         * asan/asan.xcconfig: Added.
1497         * asan/webkit-asan-ignore.txt: Added.
1498
1499 2013-08-05  Brian Holt  <brian.holt@samsung.com>
1500
1501         [GTK] Implement leak checking with valgrind
1502         https://bugs.webkit.org/show_bug.cgi?id=118785
1503
1504         Reviewed by Dirk Pranke.
1505
1506         Launch the DRT under Valgrind to generate xml files with details
1507         of leaks found.
1508
1509         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1510         (parse_args):
1511         * Scripts/webkitpy/port/gtk.py:
1512         (GtkPort.__init__):
1513         (GtkPort.default_timeout_ms): Allow extra time to run under
1514         Valgrind.
1515         (GtkPort.setup_environ_for_server): Pass Valgrind instructions
1516         using environment variables.
1517
1518 2013-08-02  Mario Sanchez Prada  <mario.prada@samsung.com>
1519
1520         [EFL] REGRESSION after r153432: some accessibility tests crash.
1521         https://bugs.webkit.org/show_bug.cgi?id=119333
1522
1523         Reviewed by Gustavo Noronha Silva.
1524
1525         Add missing null-check to avoid dereferencing a non-existent parent.
1526
1527         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1528         (WTR::attributesOfElement): Ditto.
1529
1530 2013-08-02  Patrick Gansterer  <paroga@webkit.org>
1531
1532         Add --rmdir option to git svn dcommit
1533         https://bugs.webkit.org/show_bug.cgi?id=119398
1534
1535         Reviewed by Ryosuke Niwa.
1536
1537         Add this option tells git-svn to remove empty directories
1538         from the svn tree so they do not leave over there.
1539
1540         * Scripts/webkitpy/common/checkout/scm/git.py:
1541         (Git.push_local_commits_to_server):
1542
1543 2013-08-01  Brent Fulgham  <bfulgham@apple.com>
1544
1545         [Windows] WebKit1 Fullscreen Video Play is Broken
1546         https://bugs.webkit.org/show_bug.cgi?id=119415
1547
1548         Reviewed by Jer Noble.
1549
1550         * WinLauncher/WinLauncher.cpp:
1551         (dllLauncherEntryPoint): Activate full screen mode via
1552         IWebPreferencesInternal interface.
1553
1554 2013-08-01  ChangSeok Oh  <changseok.oh@collabora.com>
1555
1556         Unreviewed. Add an alternative address to show my affiliation in team.html.
1557
1558         * Scripts/webkitpy/common/config/contributors.json:
1559
1560 2013-08-01  Bem Jones-Bey  <bjonesbe@adobe.com>
1561
1562         Duplicate property names can cause test to fail
1563         https://bugs.webkit.org/show_bug.cgi?id=119399
1564
1565         Reviewed by Dirk Pranke.
1566
1567         This problem was noticed when porting the patch for
1568         http://wkb.ug/119357 to Blink: a test would fail because the converted
1569         and test property lists weren't the same length, but they contained
1570         all of the same property names. It looks like this is actually caused
1571         by a bug in converting the HTML, which is being currently rewritten.
1572         In the meantime, as long as this compares the number of unique
1573         properties, it makes the test more robust.
1574
1575         * Scripts/webkitpy/w3c/test_converter_unittest.py:
1576         (verify_prefixed_properties):
1577
1578 2013-08-01  Bem Jones-Bey  <bjonesbe@adobe.com>
1579
1580         Unreviewed. Adding my expertise.
1581
1582         * Scripts/webkitpy/common/config/contributors.json:
1583
1584 2013-08-01  ChangSeok Oh  <changseok.oh@collabora.com>
1585
1586         Unreviewed. Add myself as a committer. Yoo-hoo! \o/
1587
1588         * Scripts/webkitpy/common/config/contributors.json:
1589
1590 2013-08-01  Commit Queue  <commit-queue@webkit.org>
1591
1592         Unreviewed, rolling out r153518.
1593         http://trac.webkit.org/changeset/153518
1594         https://bugs.webkit.org/show_bug.cgi?id=119386
1595
1596         The Jhbuild dep bump of GTK+ is not actually required by
1597         layout testing, is causing pango dep problems (Requested by
1598         zdobersek on #webkit).
1599
1600         * gtk/jhbuild.modules:
1601
1602 2013-08-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1603
1604         Unreviewed. Add myself as a committer.
1605
1606         * Scripts/webkitpy/common/config/contributors.json:
1607
1608 2013-08-01  Jaehun Lim  <ljaehun.lim@samsung.com>
1609
1610         Unreviewed. Add myself as a committer.
1611
1612         * Scripts/webkitpy/common/config/contributors.json:
1613
1614 2013-07-31  Jinwoo Song  <jinwoo7.song@samsung.com>
1615
1616         Unreviewed. Add myself as a committer.
1617
1618         * Scripts/webkitpy/common/config/contributors.json:
1619
1620 2013-08-01  Alberto Garcia  <berto@igalia.com>
1621
1622         Unreviewed. Add myself as a committer.
1623
1624         * Scripts/webkitpy/common/config/contributors.json:
1625
1626 2013-07-31  Seokju Kwon  <seokju@webkit.org>
1627
1628         Unreviewed. Add myself as a committer.
1629
1630         * Scripts/webkitpy/common/config/contributors.json:
1631
1632 2013-07-31  Bem Jones-Bey  <bjonesbe@adobe.com>
1633
1634         W3C test import script prefixes some properties that it shouldn't
1635         https://bugs.webkit.org/show_bug.cgi?id=119357
1636
1637         Reviewed by Dirk Pranke.
1638
1639         Some prefixed properties also have unprefixed implemetations, but when
1640         the implementations aren't identical, they aren't declared in
1641         CSSPropertyNames.in on the same line. This fixes the import script so
1642         that it catches all instances of prefixed properties that have an
1643         unprefixed variant, and does not add the prefix in those cases.
1644
1645         * Scripts/webkitpy/w3c/test_converter.py:
1646         (W3CTestConverter.read_webkit_prefixed_css_property_list): Read all of
1647         the properties on every line and record if they are prefixed or not.
1648         Use this information to only return prefixed properties that do not
1649         have any unprefixed variant. The prefixed property list has also
1650         changed to not include the '-webkit-' prefix, making it much easier to
1651         do the comparison, and removing the need to remove the prefix later.
1652         (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties): This no
1653         longer needs to remove the '-webkit-' prefix, but needs to add it in
1654         the case where a property that needs a prefix is found.
1655         * Scripts/webkitpy/w3c/test_converter_unittest.py:
1656         (W3CTestConverterTest.test_read_prefixed_property_list): Remove assert
1657         for '-webkit-' prefix, as it is no longer included in the properties
1658         in the prefixed property list.
1659
1660 2013-07-31  Bem Jones-Bey  <bjonesbe@adobe.com>
1661
1662         Update location of w3c shapes tests to reflect new import location
1663         https://bugs.webkit.org/show_bug.cgi?id=118156
1664
1665         Reviewed by Dirk Pranke.
1666
1667         Partial imports should not be imported to the same place as the full
1668         import, so this adds an option to allow importing to a different
1669         location than the default. In doing that, I found that imports from
1670         contributor directories didn't seem to be working correctly, so I
1671         updated the import to be smarter about both contributor directories
1672         and the test status directories. It should now be more likely that the
1673         script guesses the root directory properly.
1674
1675         * Scripts/webkitpy/w3c/test_importer.py: Remove comment about the
1676             script not working with the full set of contributors, as that is
1677             no longer true, and I didn't see a good way to keep that behavior.
1678             Also update documentation to properly explain what happens when a
1679             contributor dir is imported.
1680         (main): Attempt to find the proper repo dir by looking at the
1681             directory above the "test status" in the given path, this is still
1682             not exactly right, but is less error prone than just trimming.
1683         (parse_args): Add -d option to set the import directory.
1684         (TestImporter.__init__): Stop appending the subdirs to the
1685             destination_directory because it was making things more complex
1686             and isn't really needed.
1687         (TestImporter.update_test_status): Remove hardcoded strings and use
1688             the TEST_STATUS constants instead.
1689         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1690         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg): Add
1691             support for new option.
1692         (TestImporterTest.test_import_dir_with_no_tests): Ditto.
1693
1694 2013-07-31  Brent Fulgham  <bfulgham@apple.com>
1695
1696         [Windows] Winlauncher shouldn't look for Safari Install Directory
1697         https://bugs.webkit.org/show_bug.cgi?id=119351
1698
1699         Reviewed by Darin Adler.
1700
1701         * win/DLLLauncher/DLLLauncherMain.cpp: Don't check registry for
1702         the Safari install location. Instead, use the proper support
1703         library path for the build architecture.
1704
1705 2013-07-31  Bem Jones-Bey  <bjonesbe@adobe.com>
1706
1707         Update scripts to reference contributors.json instead of committers.py in messaging
1708         https://bugs.webkit.org/show_bug.cgi?id=119342
1709
1710         Reviewed by Ryosuke Niwa.
1711
1712         Change the scripts to point people to contributors.json instead of
1713         committers.py since the latter no longer contains the list of
1714         contributors.
1715
1716         * Scripts/webkitpy/common/config/committervalidator.py:
1717         (CommitterValidator._contributors_json_path):
1718         (CommitterValidator._flag_permission_rejection_message):
1719         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
1720         (CommitterValidatorTest.test_flag_permission_rejection_message):
1721         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1722         (Bugzilla._commit_queue_flag):
1723         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
1724         (WatchListParser._validate):
1725         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
1726         (WatchListParserTest.test_cc_rule_with_invalid_email):
1727         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1728         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1729         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1730         (ValidateReviewer.run):
1731
1732 2013-07-31  Roger Fong  <roger_fong@apple.com>
1733
1734         Unreviewed. Re-enable WinEWS tests following r153527.
1735
1736         * Scripts/webkitpy/common/config/ews.json:
1737
1738 2013-07-31  Bem Jones-Bey  <bjonesbe@adobe.com>
1739
1740         Unreviewed: Adding myself to the committers' list.
1741
1742         * Scripts/webkitpy/common/config/contributors.json:
1743
1744 2013-07-31  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1745
1746         [Qt] Build WebKit with C++11
1747         https://bugs.webkit.org/show_bug.cgi?id=119337
1748
1749         Reviewed by Csaba Osztrogonác.
1750
1751         Enable building with C++11.
1752
1753         * qmake/mkspecs/features/default_pre.prf:
1754         * qmake/mkspecs/features/unix/default_post.prf:
1755         * qmake/mkspecs/features/unix/default_pre.prf:
1756
1757 2013-07-31  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1758
1759         [Qt] ASSERTS trigger in release builds
1760         https://bugs.webkit.org/show_bug.cgi?id=119336
1761
1762         Reviewed by Jocelyn Turcotte.
1763
1764         Ensure the qmake also defaults to release if no configuration is known.
1765
1766         * qmake/mkspecs/features/default_post.prf:
1767
1768 2013-07-31  Zan Dobersek  <zdobersek@igalia.com>
1769
1770         [texmap][GStreamer][GTK] composited video shows tearing
1771         https://bugs.webkit.org/show_bug.cgi?id=118253
1772
1773         Reviewed by Martin Robinson.
1774
1775         * gtk/jhbuild.modules: Bump the Jhbuild versions of the Gdk-Pixbuf and GTK+ packages to 2.27.3 and 3.8.2, respectively.
1776         The first is required by the second, and the GTK+ bump introduces proper display framerate synchronization that removes
1777         screen tearing when enabling accelerated compositing and performing graphically heavy operations like viewing HD videos.
1778
1779 2013-07-30  Ruth Fong  <ruth_fong@apple.com>
1780
1781         Unreviewed: Adding myself to the committers' list.
1782
1783         * Scripts/webkitpy/common/config/contributors.json:
1784
1785 2013-07-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1786
1787         Unreviewed, add my new email to contributors.json.
1788
1789         * Scripts/webkitpy/common/config/contributors.json:
1790
1791 2013-07-30  Krzysztof Czech  <k.czech@samsung.com>
1792
1793         [EFL] REGRESSION after r153439: layout tests do not run.
1794         https://bugs.webkit.org/show_bug.cgi?id=119240
1795
1796         Reviewed by Christophe Dumez.
1797
1798         Changed attribute name from check_xvfb to check_driver.
1799
1800         * Scripts/webkitpy/port/efl.py:
1801         (EflPort.check_sys_deps):
1802
1803 2013-07-29  Commit Queue  <commit-queue@webkit.org>
1804
1805         Unreviewed, rolling out r152860.
1806         http://trac.webkit.org/changeset/152860
1807         https://bugs.webkit.org/show_bug.cgi?id=119227
1808
1809         Disable WinEWS tests until tests stop crashing (Requested by
1810         rfong on #webkit).
1811
1812         * Scripts/webkitpy/common/config/ews.json:
1813
1814 2013-07-29  Zan Dobersek  <zdobersek@igalia.com>
1815
1816         [GTK] Add WestonDriver, use it when appropriate
1817         https://bugs.webkit.org/show_bug.cgi?id=119100
1818
1819         Reviewed by Dirk Pranke.
1820
1821         Introduce the WestonDriver, a Driver-implementing class that sets up an instance of Weston, the Wayland compositor,
1822         and sets up an environment that enables the test runner to run inside it.
1823
1824         The design very much mimics the XvfbDriver class. It is currently used by the GTK port when the WAYLAND_DISPLAY
1825         environment variable is set, that is when NRWT is being run under a Wayland display.
1826
1827         * Scripts/webkitpy/port/base.py:
1828         (Port.to.setup_environ_for_server): Also copy the XDG_RUNTIME_DIR env from the original environment for Linux-using ports.
1829         * Scripts/webkitpy/port/gtk.py:
1830         (GtkPort):
1831         (GtkPort._driver_class): Make the method memoized - the display type is not going to change during the testing, so we
1832         should only check once for the presence of the WAYLAND_DISPLAY env and determine the proper driver class to use based on that.
1833         (GtkPort.check_sys_deps): Call the static check_driver method on the class as returned by the _driver_class method
1834         instead of hard-coding the XvfbDriver class in the check.
1835         * Scripts/webkitpy/port/westondriver.py: Added.
1836         (WestonDriver):
1837         (WestonDriver.check_driver): Similarly to XvfbDriver, this checks for existance of the weston executable.
1838         (WestonDriver.__init__): Again, like in XvfbDriver, we use a small delay between launching the Weston display and launching the driver.
1839         (WestonDriver._start): Sets up the driver-specific temporary directory, launches the Weston display, sets up the environment for the
1840         driver and then launches the driver in said environment, using the driver's Weston display.
1841         (WestonDriver.stop): Cleans up the Weston instance and the temporary directory.
1842         (WestonDriver._ensure_driver_tmpdir_subdirectory): A helper function that creates a subdirectory in the driver's temporary directory
1843         and returns the absolute path to it.
1844         * Scripts/webkitpy/port/xvfbdriver.py:
1845         (XvfbDriver.check_driver): Renamed from check_xvfb.
1846         (XvfbDriver._start): Access the FileSystem object through the Port's Host object, instead of the Port's private member.
1847
1848 2013-07-29  Mario Sanchez Prada  <mario.prada@samsung.com>
1849
1850         [ATK] Implement attributesOfChildren() for AccessibilityUIElement
1851         https://bugs.webkit.org/show_bug.cgi?id=118967
1852
1853         Reviewed by Gustavo Noronha Silva.
1854
1855         Implemented AccessibilityUIElement::attributesOfChildren() both
1856         in DumpRenderTree and the WebKitTestRunner.
1857
1858         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1859         (AccessibilityUIElement::attributesOfChildren): Implemented.
1860
1861         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1862         (WTR::AccessibilityUIElement::attributesOfChildren): Implemented.
1863
1864 2013-07-29  Mario Sanchez Prada  <mario.prada@samsung.com>
1865
1866         [ATK] Implement allAttributes() for AccessibilityUIElement
1867         https://bugs.webkit.org/show_bug.cgi?id=118966
1868
1869         Reviewed by Gustavo Noronha Silva.
1870
1871         Implemented AccessibilityUIElement::allAttributes() both in
1872         DumpRenderTree and the WebKitTestRunner.
1873
1874         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1875         (getAtkAttributeSetAsString): Moved up in the file, and refactored
1876         to use StringBuilder and return a String instead of a gchar*.
1877         (roleToString): Changed not to return the "AXRole: " prefix, so
1878         we can use it as well from attributesOfElement().
1879         (attributesOfElement): New function to dump attributes for an object.
1880         (AccessibilityUIElement::allAttributes): Call attributesOfElement().
1881         (AccessibilityUIElement::role): Updated to prefix "AXRole: ".
1882
1883         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1884         (getAtkAttributeSetAsString): Refactored to use StringBuilder and return
1885         a String instead of a gchar*.
1886
1887         (WTF::roleToString): Changed not to return the "AXRole: " prefix,
1888         so we can use it as well from attributesOfElement().
1889         (WTF::attributesOfElement): New function to dump attributes for an object.
1890         (WTR::AccessibilityUIElement::allAttributes): Call attributesOfElement().
1891         (WTR::AccessibilityUIElement::role): Updated to prefix "AXRole: ".
1892
1893 2013-07-29  Daniel Bates  <dabates@apple.com>
1894
1895         Add support infrastructure for iOS WebKit port
1896         https://bugs.webkit.org/show_bug.cgi?id=119168
1897
1898         Reviewed by Ryosuke Niwa.
1899
1900         Implement support infrastructure towards building iOS WebKit.
1901
1902         * Scripts/webkitdirs.pm:
1903         (xcodeSDKPlatformName): Added.
1904         (determineConfigurationProductDir):
1905         (builtDylibPathForName):
1906         (willUseIOSDeviceSDKWhenBuilding): Added.
1907         (willUseIOSSimulatorSDKWhenBuilding): Added.
1908         (isIOSWebKit): Added.
1909         (copyInspectorFrontendFiles):
1910
1911 2013-07-29  Sergio Correia  <sergio.correia@openbossa.org>
1912
1913         CoordinatedGraphics: Add API to get and set the active state of a WebView
1914         https://bugs.webkit.org/show_bug.cgi?id=119067
1915
1916         Reviewed by Noam Rosenthal.
1917
1918         Added API tests for WKViewIsActive and WKViewSetIsActive.
1919
1920         * TestWebKitAPI/PlatformEfl.cmake:
1921         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp: Added.
1922         (TestWebKitAPI::didFinishLoadForFrame):
1923         (TestWebKitAPI::webProcessCrashed):
1924         (TestWebKitAPI::webProcessRelaunched):
1925         (TestWebKitAPI::TEST):
1926         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp:
1927         Bundle added to allow crashing the WebProcess and testing the active state of a view
1928         under such condition.
1929         (TestWebKitAPI::WKViewIsActiveSetIsActiveTest::WKViewIsActiveSetIsActiveTest):
1930         (TestWebKitAPI::WKViewIsActiveSetIsActiveTest::didReceiveMessage):
1931
1932 2013-07-29  Zan Dobersek  <zdobersek@igalia.com>
1933
1934         [Automake] Remove references to non-existent *_CFLAGS and *_LIBS variables
1935         https://bugs.webkit.org/show_bug.cgi?id=119212
1936
1937         Reviewed by Carlos Garcia Campos.
1938
1939         * GNUmakefile.am: Remove references to GLOBALDEPS_(CFLAGS|LIBS) and CLUTTER_(CFLAGS|LIBS)
1940         variables that are not defined during the configuration process.
1941         * TestWebKitAPI/GNUmakefile.am: Ditto.
1942         * WebKitTestRunner/GNUmakefile.am: Ditto.
1943
1944 2013-07-28  Andy Estes  <aestes@apple.com>
1945
1946         Include <stdio.h> to declare perror()
1947         https://bugs.webkit.org/show_bug.cgi?id=119198
1948
1949         Reviewed by Andreas Kling.
1950
1951         Silences an implicit declaration warning.
1952
1953         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport.c:
1954
1955 2013-07-27  Ryuan Choi  <ryuan.choi@samsung.com>
1956
1957         [EFL] Bump required version of EFL to 1.7
1958         https://bugs.webkit.org/show_bug.cgi?id=119144
1959
1960         Reviewed by Christophe Dumez.
1961
1962         * MiniBrowser/efl/CMakeLists.txt: Bumped EFL to 1.7
1963
1964 2013-07-26  Filip Pizlo  <fpizlo@apple.com>
1965
1966         WKTR should know about the JSC extensions to testRunner
1967         https://bugs.webkit.org/show_bug.cgi?id=119154
1968
1969         Reviewed by Mark Hahnenberg and Geoffrey Garen.
1970         
1971         This makes some fast/js tests pass.
1972
1973         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1974         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1975         (WTR::TestRunner::numberOfDFGCompiles):
1976         (WTR::TestRunner::neverInlineFunction):
1977         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1978
1979 2013-07-25  Mark Rowe  <mrowe@apple.com>
1980
1981         Fix build of DumpRenderTree and WebKitTestRunner when building against an SDK.
1982
1983         * DumpRenderTree/mac/Configurations/Base.xcconfig: Fix framework search path when building against an SDK.
1984         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto. Also fix where our scripts look for WebCore.framework
1985         so they pull the version out of the SDK.
1986
1987 2013-07-25  Anders Carlsson  <andersca@apple.com>
1988
1989         Localizable.strings generated by extract-localizable-strings should be UTF-8
1990         https://bugs.webkit.org/show_bug.cgi?id=119106
1991
1992         Reviewed by Mark Rowe.
1993
1994         Output strings as UTF-8.
1995
1996         * Scripts/extract-localizable-strings:
1997
1998 2013-07-25  Sam Weinig  <sam@webkit.org>
1999
2000         -[WebHTMLView attributedSubstringForProposedRange:actualRange:] does not include strikethrough attribute in the returned attributed string
2001         https://bugs.webkit.org/show_bug.cgi?id=119099
2002         <rdar://problem/13439291>
2003
2004         Reviewed by Enrica Casucci.
2005
2006         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2007         * TestWebKitAPI/Tests/mac/AttributedString.mm:
2008         (TestWebKitAPI::attributedString):
2009         (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
2010         (TestWebKitAPI::AttributedStringTest_CustomFont::url):
2011         (TestWebKitAPI::AttributedStringTest_CustomFont::runTest):
2012         (TestWebKitAPI::TEST_F):
2013         (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
2014         (TestWebKitAPI::AttributedStringTest_Strikethrough::url):
2015         (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest):
2016         * TestWebKitAPI/Tests/mac/attributedStringStrikethrough.html: Added.
2017         Add tests for attributed strings with strikethrough.  Refactor the attributed string tests
2018         to make adding more easier in the future.
2019
2020 2013-07-20  Filip Pizlo  <fpizlo@apple.com>
2021
2022         fourthTier: FTL should be able to generate LLVM IR that uses an intrinsic for OSR exit
2023         https://bugs.webkit.org/show_bug.cgi?id=118948
2024
2025         Reviewed by Sam Weinig.
2026         
2027         - Make ReducedFTL capable of dealing with code that uses the fake OSR exit intrinsic,
2028           by exporting it as a function.
2029         
2030         - Make combineModules.rb idempotent. Sometimes it's convenient to run a file through
2031           it even if you know that you've already done so. See processIRDump.sh.
2032         
2033         - Add a script, processIRDump.sh, that takes the output of --dumpLLVMIR=true and
2034           runs it through ReducedFTL automatically. You typically want to say something like:
2035           
2036           jsc --dumpLLVMIR=true <program(s)> > jsc-output.txt
2037           ./processIRDump.sh --timing < jsc-output.txt
2038
2039         * ReducedFTL/ReducedFTL.c:
2040         (webkit_osr_exit):
2041         * ReducedFTL/combineModules.rb:
2042         * ReducedFTL/processIRDump.sh: Added.
2043
2044 2013-07-20  Filip Pizlo  <fpizlo@apple.com>
2045
2046         fourthTier: We should use the no-asserts build of LLVM if that's what the user configured
2047         https://bugs.webkit.org/show_bug.cgi?id=118947
2048
2049         Reviewed by Dan Bernstein.
2050
2051         * Scripts/copy-webkitlibraries-to-product-directory:
2052
2053 2013-07-16  Filip Pizlo  <fpizlo@apple.com>
2054
2055         fourthTier: We should have a reduced FTL LLVM pipeline tool in the repository
2056         https://bugs.webkit.org/show_bug.cgi?id=118647
2057
2058         Rubber stamped by Geoffrey Garen and Mark Hahnenberg.
2059
2060         Add a tool that takes in an LLVM bitcode file and JITs it in exactly the same
2061         way that the FTL would.
2062         
2063         Also add a tool that combines multiple LLVM modules generated by FTL into a
2064         single module.
2065
2066         * ReducedFTL: Added.
2067         * ReducedFTL/ReducedFTL.c: Added.
2068         (usage):
2069         (currentTime):
2070         (MemorySection):
2071         (mmAllocateCodeSection):
2072         (mmAllocateDataSection):
2073         (mmApplyPermissions):
2074         (mmDestroy):
2075         (symbolLookupCallback):
2076         (main):
2077         * ReducedFTL/build.sh: Added.
2078         * ReducedFTL/combineModules.rb: Added.
2079
2080 2013-06-09  Filip Pizlo  <fpizlo@apple.com>
2081
2082         Unreviewed, fix minor goof in profiling output layout. We weren't accounting
2083         for the "/" that is printed between engine counts.
2084
2085         * Scripts/display-profiler-output:
2086
2087 2013-05-28  Filip Pizlo  <fpizlo@apple.com>
2088
2089         testRunner should have a way of disabling inlining of functions
2090         https://bugs.webkit.org/show_bug.cgi?id=116875
2091
2092         Reviewed by Mark Hahnenberg.
2093
2094         * DumpRenderTree/TestRunner.cpp:
2095         (neverInlineFunction):
2096         (TestRunner::staticFunctions):
2097
2098 2013-05-27  Filip Pizlo  <fpizlo@apple.com>
2099
2100         testRunner should be able to tell you if a function is DFG compiled
2101         https://bugs.webkit.org/show_bug.cgi?id=116847
2102
2103         Reviewed by Mark Hahnenberg.
2104
2105         * DumpRenderTree/TestRunner.cpp:
2106         (numberOfDFGCompiles):
2107         (TestRunner::staticFunctions):
2108
2109 2013-05-21  Filip Pizlo  <fpizlo@apple.com>
2110
2111         fourthTier: display-profiler-output should make it even easier to diff the compilation story between two different runs
2112         https://bugs.webkit.org/show_bug.cgi?id=116556
2113
2114         Reviewed by Oliver Hunt.
2115         
2116         This adds three new capabilities:
2117         
2118         - 'display' now accepts negative compilation indices, and allows specifying
2119           wildcard hashes combined with combination indices. Previously you could say
2120           'display <hash>', 'display <hash>-<index>-<engine>', or 'display *'. The
2121           latter would display every compilation. This improves this so that you can
2122           say 'display *-<index>-<engine>'. It also makes it so that you can give a
2123           negative index, which allows you to say things like 'display blah--1-dfg',
2124           which displays just the last DFG compilation. Also you can say
2125           'display *--1-dfg', which displays the last DFG compilation for each code
2126           block. I realize that this is kind of ugly, but gosh is it practical.
2127         
2128         - You can now say 'sort hash', which will henceforth sort all of the output
2129           by code hash rather than by the time when it was compiled. This means that
2130           if you're doing 'dispay *--1-dfg' and then want to diff the results against
2131           something else, you can ensure that this doesn't get confused just by
2132           changes in compilation order.
2133         
2134         - You can now say 'counts off', which will henceforth disable the display of
2135           execution counts from 'bytecode' and 'display'. This is also useful for
2136           diffs, since if you're trying to figure out why two compilations are
2137           different, they probably have radically different counts. 'counts off' gets
2138           this out of the output so that it doesn't confuse your diff.
2139         
2140         Note that to use this effectively you should also have a script that scrubs
2141         pointers from text so that the diff doesn't get confused by pointers. I'll
2142         post my elimptr script to the bug. Maybe at some point I'll integrate that
2143         into display-profiler-output.
2144         
2145         Put together this is pretty awesome. I was able to do the following:
2146         
2147         (echo "counts off" && echo "sort hash" && echo "d *--1-dfg") | Tools/Scripts/display-profiler-output richards-serial.profile | elimptr > richards-serial.asm
2148         (echo "counts off" && echo "sort hash" && echo "d *--1-dfg") | Tools/Scripts/display-profiler-output richards-concurrent.profile | elimptr > richards-concurrent.asm
2149         diff -u richards-serial.asm richards-concurrent.asm
2150         
2151         And this immediately told me that the reason why richards is slower in the
2152         concurrent compilation case is just that we end up compiling *tons* more
2153         functions, most of which are trivially inlineable. Basically, concurrent
2154         compilation breaks our previous heuristics for delaying compilation of
2155         inlineables just enough that they never trigger compilation. We should fix
2156         that in a separate bug.
2157
2158         * Scripts/display-profiler-output:
2159
2160 2013-04-30  Filip Pizlo  <fpizlo@apple.com>
2161
2162         fourthTier: Use hw.availcpu instead of hw.ncpu, and configure LLVM with --enable-zlib=no
2163
2164         Rubber stamped by Mark Rowe.
2165
2166         * Scripts/copy-webkitlibraries-to-product-directory:
2167
2168 2013-07-16  Oliver Hunt <oliver@apple.com>
2169
2170         Merge dfgFourthTier r148853
2171
2172     2013-04-21  Filip Pizlo  <fpizlo@apple.com>
2173
2174         fourthTier: tandem WebKit and LLVM builds should ./configure LLVM if needed
2175         https://bugs.webkit.org/show_bug.cgi?id=114933
2176
2177         Reviewed by Andy Estes.
2178         
2179         This makes it easy to get set up for tandem LLVM builds.
2180
2181         * Scripts/copy-webkitlibraries-to-product-directory:
2182
2183 2013-07-16  Oliver Hunt <oliver@apple.com>
2184
2185         Merge dfgFourthTier r148850
2186
2187     2013-04-21  Filip Pizlo  <fpizlo@apple.com>
2188
2189         fourthTier: WebKit's build system should relink JavaScriptCore if LLVM's libraries changed but its headers didn't
2190         https://bugs.webkit.org/show_bug.cgi?id=114926
2191
2192         Reviewed by Geoffrey Garen.
2193         
2194         If the LLVM libraries change, then touch a phony header, which will force relink
2195         of JavaScriptCore.
2196
2197         * Scripts/copy-webkitlibraries-to-product-directory:
2198         (unpackIfNecessary):
2199
2200 2013-07-16  Oliver Hunt <oliver@apple.com>
2201
2202         Merge dfgFourthTier r148848
2203
2204     2013-04-21  Filip Pizlo  <fpizlo@apple.com>
2205
2206         fourthTier: developing LLVM in tandem with WebKit should be fun and easy
2207         https://bugs.webkit.org/show_bug.cgi?id=114925
2208
2209         Reviewed by Geoffrey Garen.
2210         
2211         This enables building LLVM along with WebKit, so that build-jsc and build-webkit
2212         will also optionally build LLVM and quickly symlink LLVM's built products into
2213         the right places.
2214         
2215         Most WebKit and JSC hackers will want to rely on the checked-in already-built
2216         versions of LLVM in WebKitLibraries. But developing both systems in tandem is an
2217         increasingly common use-case for me, and it may become a common use case for a
2218         handful of others. Currently, this is really painful: you first have to build
2219         LLVM, then you have to export-llvm-build (which takes a while), and then you
2220         have to make sure that your LLVM_LIBRARY_PACKAGE and LLVM_INCLUDE_PACKAGE
2221         variables are set to point to the thing you exported. The whole process loses
2222         track of dependencies very quickly: making a tiny change in LLVM requires
2223         packaging, and then unpackaging, a large number of potentially large headers and
2224         static libraries. Not only is this slow but it then causes the WebKit build
2225         system to rebuild anything that transitively includes any LLVM header, which is
2226         now quite a few files. While this sort of use pattern is still worthwhile if
2227         you're trying to package a binary drop and test it, it's not great if you're
2228         just trying to do experimental development that involves making small changes
2229         in both trees.
2230         
2231         This change fixes this use case while keeping the old use cases intact. You can
2232         do tandem development using one of two modes:
2233         
2234         Your own LLVM directory: just set LLVM_SOURCE_PATH to the *absolute* path of
2235         the LLVM directory you're using. Once this is done, any invocation of a WebKit
2236         build via build-jsc or build-webkit will also build LLVM, and then quickly
2237         symlink things into place without perturbing dependency tracking.
2238         
2239         Internal LLVM directory: if you check out llvm into a directory called 'llvm'
2240         right off of the WebKit source tree, then the build system will automatically
2241         use this.
2242         
2243         Here's how this takes care of dependencies:
2244         
2245         Headers: the include/llvm and include/llvm-c directories are symlinked into
2246         $productsDir/usr/local/include. And then everything just works.
2247         
2248         Libraries: the build system detects, by reading LLVM's Makefile.config, which
2249         mode LLVM is built in (like Release+Asserts or Debug+Asserts) and symlinks
2250         the .a files into $productsDir/<thingy>. It will ranlib those libraries only
2251         if they have changed, by checking both the modification time and also whether
2252         the last time we had a symlink, that symlink was from the same directory.
2253         This helps if you switch to an *older* LLVM build (using LLVM_SOURCE_PATH)
2254         but that build wasn't yet ranlib'd.
2255         
2256         One problem that this does not yet solve is that xcodebuild will not relink
2257         JavaScriptCore if the only thing that changed was the libraries. I will work
2258         on this problem separately: https://bugs.webkit.org/show_bug.cgi?id=114926.
2259
2260         * Scripts/copy-webkitlibraries-to-product-directory:
2261         (unpackIfNecessary):
2262         (fileContains):
2263         (fileContentsEquals):
2264
2265 2013-04-15  Filip Pizlo  <fpizlo@apple.com>
2266
2267         fourthTier: Update LLVM-related build scripts to copy generated headers as well
2268         https://bugs.webkit.org/show_bug.cgi?id=114551
2269
2270         Reviewed by Oliver Hunt.
2271         
2272         Also added the ability to use something other than bzip2 compression, since although
2273         it is great for checking things into the tree, it increases turn-around times when
2274         experimenting.
2275
2276         * Scripts/copy-webkitlibraries-to-product-directory:
2277         (unpackIfNecessary):
2278         * Scripts/export-llvm-build:
2279
2280 2013-04-03  Filip Pizlo  <fpizlo@apple.com>
2281
2282         fourthTier: Include LLVM headers with surrounding #pragmas instead of using my #define
2283         https://bugs.webkit.org/show_bug.cgi?id=113921
2284
2285         Reviewed by Oliver Hunt.
2286
2287         The LLVM community wants us to continue including all of LLVM's C++ headers. Change
2288         the export script to do this.
2289         
2290         * Scripts/export-llvm-build:
2291
2292 2013-03-29  Filip Pizlo  <fpizlo@apple.com>
2293
2294         fourthTier: Check in a known-good build of LLVM into WebKitLibraries, and have a story for updating it
2295         https://bugs.webkit.org/show_bug.cgi?id=113452
2296
2297         Rubber stamped by Mark Hahnenberg.
2298
2299         * Scripts/copy-webkitlibraries-to-product-directory:
2300         * Scripts/export-llvm-build:
2301
2302 2013-03-29  Filip Pizlo  <fpizlo@apple.com>
2303
2304         fourthTier: FTL JIT should be able run some simple function
2305         https://bugs.webkit.org/show_bug.cgi?id=113481
2306
2307         Reviewed by Geoffrey Garen.
2308         
2309         Give the scripts the ability to find an LLVM build and use it.
2310         
2311         Also added a script, export-llvm-build, that allows you to take your
2312         own build of LLVM and package it for use by WebKit's build system.
2313         
2314         The build system treats a "build" of LLVM as a pair of .tar.bz2's,
2315         one for the library archives and one for the headers. It then unpacks
2316         them into your built products directory in a mannner that is mostly
2317         analogous to how WebKitSystemInterface works.
2318
2319         * Scripts/build-jsc:
2320         * Scripts/copy-webkitlibraries-to-product-directory:
2321         (unpackIfNecessary):
2322         (dittoHeaders):
2323         * Scripts/export-llvm-build: Added.
2324
2325 2013-07-24  Anders Carlsson  <andersca@apple.com>
2326
2327         Crash when calling WKPageGetProcessIdentifier after aborted process launch
2328         https://bugs.webkit.org/show_bug.cgi?id=119069
2329         <rdar://problem/14494064>
2330
2331         Reviewed by Andreas Kling.
2332
2333         Add a test.
2334
2335         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2336         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp: Added.
2337         (TestWebKitAPI::didFinishLoadForFrame):
2338         (TestWebKitAPI::TEST):
2339
2340 2013-07-24  Zan Dobersek  <zdobersek@igalia.com>
2341
2342         Make KURL::hasPath private
2343         https://bugs.webkit.org/show_bug.cgi?id=118279
2344
2345         Reviewed by Darin Adler.
2346
2347         * TestWebKitAPI/Tests/WebCore/KURL.cpp:
2348         (TestWebKitAPI::TEST_F): Remove references to KURL::hasPath the method is now private and thus not accessible for testing.
2349
2350 2013-07-24  Anton Obzhirov  <a.obzhirov@samsung.com>
2351
2352         [GTK] TestInspectorServer unit test is timing out
2353         https://bugs.webkit.org/show_bug.cgi?id=105866
2354
2355         Reviewed by Gustavo Noronha Silva.
2356
2357         * Scripts/run-gtk-tests:
2358         (TestRunner):
2359
2360 2013-07-24  Anton Obzhirov  <a.obzhirov@samsung.com>
2361
2362         [GTK] [WK2] Handle wheel event with delta zero
2363         https://bugs.webkit.org/show_bug.cgi?id=118973
2364
2365         Reviewed by Gustavo Noronha Silva.
2366
2367         Added handling of zero mouse scroll deltas in EventSenderProxy similar
2368         to WK1 and Qt/EFL ports.
2369
2370         fast/events/platform-wheelevent-with-delta-zero-crash.html is no longer
2371         failing on WK2.
2372
2373         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2374         (WTR::EventSenderProxy::mouseScrollBy):
2375
2376 2013-07-23  Andreas Kling  <akling@apple.com>
2377
2378         REGRESSION(r150867): FrameView auto-sizing + delegate denied image load may cause StyleResolver to re-enter itself.
2379         <rdar://problem/14324895>
2380         <http://webkit.org/b/119023>
2381
2382         Reviewed by Simon Fraser.
2383
2384         Add a test for this rather specific problem.
2385
2386         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2387         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm: Added.
2388         (TestWebKitAPI::TEST):
2389         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp: Added.
2390         (TestWebKitAPI::DenyWillSendRequestTest::DenyWillSendRequestTest):
2391         (TestWebKitAPI::DenyWillSendRequestTest::willSendRequestForFrame):
2392         (TestWebKitAPI::DenyWillSendRequestTest::didCreatePage):
2393
2394 2013-07-23  Tim Horton  <timothy_horton@apple.com>
2395
2396         Add a test for plug-in unavailability indicator obscurity detection
2397         https://bugs.webkit.org/show_bug.cgi?id=119007
2398
2399         Reviewed by Anders Carlsson.
2400
2401         Expose the ability to block plug-ins via pluginLoadPolicy to testRunner.
2402
2403         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2404         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2405         (WTR::TestRunner::setBlockAllPlugins):
2406         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2407         * WebKitTestRunner/TestInvocation.cpp:
2408         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2409         Add testRunner.setBlockAllPlugins function (and corresponding message to
2410         forward it through to TestController).
2411
2412         * WebKitTestRunner/TestController.cpp:
2413         Initialize m_shouldBlockAllPlugins to false (and drive-by initialize m_handlesAuthenticationChallenges).
2414
2415         (WTR::TestController::createWebViewWithOptions):
2416         Register our pluginLoadPolicy callback.
2417
2418         (WTR::TestController::resetStateToConsistentValues):
2419         Reset m_shouldBlockAllPlugins to false.
2420
2421         (WTR::TestController::pluginLoadPolicy):
2422         Return the existing plugin load policy, unless setBlockAllPlugins(true)
2423         was called, in which case we reject all plugins with kWKPluginLoadPolicyBlocked.
2424
2425         * WebKitTestRunner/TestController.h:
2426         (WTR::TestController::setBlockAllPlugins):
2427
2428 2013-07-21  Andreas Kling  <akling@apple.com>
2429
2430         KURL creates duplicate strings when completing data: URIs.
2431         <http://webkit.org/b/118952>
2432         <rdar://problem/14504480>
2433
2434         Reviewed by Anders Carlsson.
2435
2436         * TestWebKitAPI/Tests/WebCore/KURL.cpp:
2437         (TestWebKitAPI::TEST_F):
2438
2439 2013-07-19  Chris Fleizach  <cfleizach@apple.com>
2440
2441         AX: VoiceOver not detecting misspelled words don't work in all cases
2442         https://bugs.webkit.org/show_bug.cgi?id=118924
2443
2444         Reviewed by Tim Horton.
2445
2446         Make the misspelled detection dependent on both types of attributes being present.
2447
2448         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2449         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
2450         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2451         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
2452
2453 2013-07-19  Alex Christensen  <achristensen@apple.com>
2454
2455         Improved code coverage generation.
2456         https://bugs.webkit.org/show_bug.cgi?id=118926
2457
2458         Reviewed by Tim Horton.
2459
2460         * Scripts/build-webkit: Removed exception preventing ANGLE code coverage support.
2461         * Scripts/generate-coverage-data: Added --no-build to run-javascriptcore-tests call.
2462         (generateReport): Moved report generation to a subroutine.
2463
2464 2013-07-19  Stephanie Lewis  <slewis@apple.com>
2465
2466         <rdar://problem/14499595> pagination wk2 api test failing on ML (118928)
2467
2468         Unreviewed.
2469
2470         Rebaseline pagination test after http://trac.webkit.org/changeset/152911
2471
2472         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
2473         (TestWebKitAPI::didLayout):
2474
2475 2013-07-19  Daniel Bates  <dabates@apple.com>
2476
2477         Make Perl tools work when using git bisect with Git branch build setup
2478         https://bugs.webkit.org/show_bug.cgi?id=118512
2479
2480         Reviewed by Martin Robinson.
2481
2482         The various Perl tools (run-webkit-app, {debug, run}-safari, et cetera) don't work
2483         during a git bisect session with a Git branch build setup (i.e. git config
2484         core.webKitBranchBuild true). Specifically, the tools cannot find the branch-
2485         specific build of WebKit because they cannot determine the branch Git is on (since
2486         git bisect puts Git into a detached HEAD state). We should teach our tooling to
2487         parse the file .git/BISECT_START (created by git bisect start) for the name of the
2488         branch Git was on when we began a git bisect session. Then the tools can determine
2489         the path to the built WebKit.
2490
2491         * Scripts/VCSUtils.pm:
2492         (gitDirectory): Added.
2493         (gitBisectStartBranch): Added.
2494         (gitBranch): Modified to call gitBisectStartBranch() when we have a detached
2495         HEAD (e.g. running git bisect).
2496         (determineVCSRoot): Modified to call gitDirectory() to determine the path to
2497         the .git directory in the Git checkout.
2498
2499 2013-07-19  Alex Christensen  <achristensen@apple.com>
2500
2501         Added x64 configuration to Visual Studio build.
2502         https://bugs.webkit.org/show_bug.cgi?id=118888
2503
2504         Reviewed by Brent Fulgham.
2505
2506         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2507         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters:
2508         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
2509         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2510         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2511         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2512         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2513         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
2514         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2515         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
2516         * win/record-memory/record-memory.vcxproj:
2517
2518 2013-07-19  Martin Robinson  <mrobinson@igalia.com>
2519
2520         Add a couple people to the MathML watchlist
2521         https://bugs.webkit.org/show_bug.cgi?id=118909
2522
2523         Reviewed by Andreas Kling.
2524
2525         Add a couple people to the MathML watchlist and add Kalyan's other
2526         email address to fix style checker warnings about the watchlist
2527         contents.
2528
2529         * Scripts/webkitpy/common/config/contributors.json: Add Frédéric to the
2530         list of contributors and add Kalyan's second email address.
2531         * Scripts/webkitpy/common/config/watchlist: Add myself and Frédéric to the MathML
2532         watchlist.
2533
2534 2013-07-19  Simon Pena  <simon.pena@samsung.com>
2535
2536         [GTK] Fix regression in DumpRenderTree introduced in r152782 by checking if uri is valid
2537         https://bugs.webkit.org/show_bug.cgi?id=118895
2538
2539         Reviewed by Philippe Normand.
2540
2541         In r152782 an uri is used to create an string representation without checking first if it
2542         is valid. That fails later when the string is used to check for existing redirections. This
2543         patch ensures that the uri is valid before using it.
2544
2545         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2546         (willSendRequestCallback): Ensure an uri is valid before using it.
2547
2548 2013-07-18  Timothy Hatcher  <timothy@apple.com>
2549
2550         Add extract-localizable-js-strings and use it for WebInspectorUI.
2551
2552         https://bugs.webkit.org/show_bug.cgi?id=118851
2553
2554         Reviewed by Joseph Pecoraro.
2555
2556         * Scripts/extract-localizable-js-strings: Added.
2557         * Scripts/extract-localizable-strings: Drive-by-fix: disable deprecated warnings about "goto".
2558         * Scripts/update-webkit-localizable-strings: Use extract-localizable-js-strings for
2559         the WebInspectorUI project.
2560
2561 2013-07-18  Brent Fulgham  <bfulgham@apple.com>
2562
2563         [Windows] Build correction #2 after r152861.
2564
2565         * WinLauncher/WinLauncher.cpp: Declare proper linkage.
2566
2567 2013-07-18  Brent Fulgham  <bfulgham@apple.com>
2568
2569         [Windows] Build correction after r152861.
2570
2571         * WinLauncher/WinLauncher.cpp: Don't reference private header.
2572
2573 2013-07-16  Brent Fulgham  <bfulgham@apple.com>
2574
2575         [Win] Support in-band text tracks.
2576         https://bugs.webkit.org/show_bug.cgi?id=103770
2577
2578         Reviewed by Eric Carlson.
2579
2580         Update WinLauncher to run in a CFRunLoop (rather than a hand-written Windows event loop) so that
2581         libdispatch and CFRunLoop elements are services during the run loop.
2582
2583         * WinLauncher/WinLauncher.cpp:
2584         (dllLauncherEntryPoint): Use CFRunLoopRun (rather than a Windows message loop) if running with
2585         a CoreFoundation (or CFLite) support library.
2586         * WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props: Added.
2587         * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props: Added.
2588         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add references to WinLauncherCF.props
2589         and WinLauncherCFLite.props.
2590
2591 2013-07-18  Roger Fong  <roger_fong@apple.com>
2592
2593         Unreviewed. Test enabling WinEWS tests now that queue is at a good state and NRWT with multiple processes is enabled.
2594
2595         * Scripts/webkitpy/common/config/ews.json:
2596
2597 2013-07-18  Daniel Bates  <dabates@apple.com>
2598
2599         REGRESSION (r132678): Tests that use SSL or port 8080 time out when run using old-run-webkit-tests
2600         https://bugs.webkit.org/show_bug.cgi?id=118854
2601         <rdar://problem/14081339>
2602
2603         Reviewed by David Kilzer.
2604
2605         Following <http://trac.webkit.org/changeset/132678> (https://bugs.webkit.org/show_bug.cgi?id=98602)
2606         Apache no longer listens to ports 8443 (SSL) and 8080. So, tests that use these ports time out when
2607         run using old-run-webkit-tests. We need to update old-run-webkit-tests to explicitly tell Apache to
2608         listen on these ports so that we can run tests that use port 8443 and 8080.
2609
2610         * Scripts/old-run-webkit-tests:
2611         (configureAndOpenHTTPDIfNeeded):
2612
2613 2013-07-17  Tim Horton  <timothy_horton@apple.com>
2614
2615         Update blocked/missing plug-in UI
2616         https://bugs.webkit.org/show_bug.cgi?id=118347
2617         <rdar://problem/14209318>
2618
2619         Reviewed by Sam Weinig.
2620
2621         * MiniBrowser/mac/WK2BrowserWindowController.m:
2622         (-[WK2BrowserWindowController awakeFromNib]):
2623         * WebKitTestRunner/TestController.cpp:
2624         (WTR::TestController::createWebViewWithOptions):
2625         Match new WKPageLoaderClient entry.
2626
2627 2013-07-17  Commit Queue  <commit-queue@webkit.org>
2628
2629         Unreviewed, rolling out r152701, r152703, r152739, r152754,
2630         and r152756.
2631         http://trac.webkit.org/changeset/152701
2632         http://trac.webkit.org/changeset/152703
2633         http://trac.webkit.org/changeset/152739
2634         http://trac.webkit.org/changeset/152754
2635         http://trac.webkit.org/changeset/152756
2636         https://bugs.webkit.org/show_bug.cgi?id=118821
2637
2638         this was a buggy fix and we're going to try something
2639         different (Requested by thorton on #webkit).
2640
2641         * MiniBrowser/mac/WK2BrowserWindowController.m:
2642         (-[WK2BrowserWindowController awakeFromNib]):
2643         * WebKitTestRunner/TestController.cpp:
2644         (WTR::TestController::createWebViewWithOptions):
2645
2646 2013-07-17  Commit Queue  <commit-queue@webkit.org>
2647
2648         Unreviewed, rolling out r151535.
2649         http://trac.webkit.org/changeset/151535
2650         https://bugs.webkit.org/show_bug.cgi?id=118804
2651
2652         Re-disable WinEWS tests (Requested by rfong on #webkit).
2653
2654         * Scripts/webkitpy/common/config/ews.json:
2655
2656 2013-07-17  Simon Pena  <simon.pena@samsung.com>
2657
2658         [GTK] Make DRT obbey testRunner's addURLToRedirect
2659         https://bugs.webkit.org/show_bug.cgi?id=118239
2660
2661         Reviewed by Gustavo Noronha Silva.
2662
2663         Support testRunner's addURLToRedirect in GTK's DRT, so it redirects
2664         to the proper URI when indicated.
2665
2666         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2667         (willSendRequestCallback):
2668
2669 2013-07-17  Gabor Abraham  <abrhm@inf.u-szeged.hu>
2670
2671         Add a new find-resolved-bugs command to webkit-patch.
2672         https://bugs.webkit.org/show_bug.cgi?id=118060
2673
2674         Reviewed by Csaba Osztrogonác.
2675
2676         * Scripts/webkitpy/tool/commands/queries.py:
2677         (PrintBaselines._platform_for_path):
2678         (FindResolvedBugs):
2679         (FindResolvedBugs.execute):
2680
2681 2013-07-16  Balazs Kelemen  <kbalazs@webkit.org>
2682
2683         [CMake] Undefined references should be detected at build time
2684         https://bugs.webkit.org/show_bug.cgi?id=110236
2685
2686         Reviewed by Christophe Dumez.
2687
2688         Add library dependencies that were not defined explicitly before.
2689
2690         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2691         * TestWebKitAPI/CMakeLists.txt:
2692         * WebKitTestRunner/CMakeLists.txt:
2693
2694 2013-07-16  Kwang Yul Seo  <skyul@company100.net>
2695
2696         check-webkit-style: "using namespace foo;" should be flagged as an error only in headers
2697         https://bugs.webkit.org/show_bug.cgi?id=118755
2698
2699         Reviewed by Ryosuke Niwa.
2700
2701         Fix r152719 to check "using namespace foo;" only in headers.
2702
2703         * Scripts/webkitpy/style/checkers/cpp.py:
2704         (check_using_namespace):
2705         (check_style):
2706         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2707         (WebKitStyleTest.test_using_namespace):
2708
2709 2013-07-16  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2710
2711         Get rid of multiple inheritance support from the bindings generators
2712         https://bugs.webkit.org/show_bug.cgi?id=118353
2713
2714         Reviewed by Kentaro Hara.
2715
2716         Update CodeGeneratorTestRunner.pm to use domInterface->parent instead of
2717         deprecated domInterface->parents.
2718
2719         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2720         (_parentInterface):
2721
2722 2013-07-16  Brian Holt  <brian.holt@samsung.com>
2723
2724         check-webkit-style: "using namespace foo;" should be flagged as an error in headers
2725         https://bugs.webkit.org/show_bug.cgi?id=57241
2726
2727         Reviewed by Ryosuke Niwa.
2728
2729         Added check for "using namespace foo" and unit test.
2730
2731         * Scripts/webkitpy/style/checkers/cpp.py:
2732         (check_using_namespace):
2733         (check_style):
2734         (CppChecker):
2735         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2736         (WebKitStyleTest.test_using_namespace):
2737
2738 2013-07-16  Anton Obzhirov  <a.obzhirov@samsung.com>
2739
2740         [GTK] fast/events/platform-wheelevent-with-delta-zero-crash.html is crashing
2741         https://bugs.webkit.org/show_bug.cgi?id=110222
2742
2743         Reviewed by Gustavo Noronha Silva.
2744
2745         Added handling of zero mouse scroll deltas in EventSender.
2746
2747         * DumpRenderTree/gtk/EventSender.cpp:
2748         (mouseScrollByCallback):
2749
2750 2013-07-16  Brian Holt  <brian.holt@samsung.com>
2751
2752         webkitpy: replace urllib with urllib2 for downloading additional modules
2753         https://bugs.webkit.org/show_bug.cgi?id=118671
2754
2755         Reviewed by Ryosuke Niwa.
2756
2757         Urllib2 is available whereever urllib is, but has better proxy support.
2758
2759         * Scripts/webkitpy/common/system/autoinstall.py:
2760         (AutoInstaller._download_to_stream):
2761
2762 2013-07-16  Krzysztof Czech  <k.czech@samsung.com>
2763
2764         [ATK] Adds support for aria-haspopup property.
2765         https://bugs.webkit.org/show_bug.cgi?id=117834
2766
2767         Reviewed by Christophe Dumez.
2768
2769         Adds implementation for testing aria-haspopup property.
2770
2771         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2772         (getAttributeSetValueForId):
2773         (AccessibilityUIElement::stringAttributeValue):
2774         (AccessibilityUIElement::hasPopup):
2775         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2776         (WTR::getAttributeSetValueForId):
2777         (WTR::AccessibilityUIElement::stringAttributeValue):
2778         (WTR::AccessibilityUIElement::hasPopup):
2779
2780 2013-07-16  Michael Brüning  <michael.bruning@digia.com>
2781
2782         [Qt] Replace Nokia references.
2783         https://bugs.webkit.org/show_bug.cgi?id=118728
2784
2785         Reviewed by Simon Hausmann.
2786
2787         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2788         (MiniBrowserApplication::MiniBrowserApplication):
2789         * QtTestBrowser/qttestbrowser.cpp:
2790         (LauncherApplication::LauncherApplication):
2791
2792 2013-07-15  Tim Horton  <timothy_horton@apple.com>
2793
2794         Update blocked/missing plug-in UI
2795         https://bugs.webkit.org/show_bug.cgi?id=118347
2796         <rdar://problem/14209318>
2797
2798         Reviewed by Sam Weinig.
2799
2800         * MiniBrowser/mac/WK2BrowserWindowController.m:
2801         (-[WK2BrowserWindowController awakeFromNib]):
2802         * WebKitTestRunner/TestController.cpp:
2803         (WTR::TestController::createWebViewWithOptions):
2804         Match new WKPageLoaderClient entry.
2805
2806 2013-07-15  Chris Fleizach  <cfleizach@apple.com>
2807
2808         Update James Craig's email address.
2809
2810         * Scripts/webkitpy/common/config/contributors.json:
2811
2812 2013-07-15  Dong-Gwan Kim  <donggwan.kim@samsung.com>
2813
2814         [EFL] Add fallback for TestWebKitAPI if opengl is not available.
2815         https://bugs.webkit.org/show_bug.cgi?id=118583
2816
2817         Reviewed by Christophe Dumez.
2818
2819         There're many fails on efl webkit2 API test if opengl is not available.
2820         So, add fallback to non-opengl evas engine.
2821
2822         * TestWebKitAPI/efl/PlatformWebView.cpp:
2823         (TestWebKitAPI::initEcoreEvas):
2824
2825 2013-07-15  Brian Holt  <brian.holt@samsung.com>
2826
2827         check-webkit-style: Ignore false positive: Instance of 'Popen' has no 'pid' member
2828         https://bugs.webkit.org/show_bug.cgi?id=118592
2829
2830         Reviewed by Martin Robinson.
2831
2832         Added a suppression for pylint false positives and a unit test.
2833
2834         * Scripts/webkitpy/style/checkers/python.py:
2835         (Pylinter):
2836         * Scripts/webkitpy/style/checkers/python_unittest.py:
2837         (PythonCheckerTest.test_check):
2838         (PythonCheckerTest):
2839         (PythonCheckerTest.test_pylint_false_positives):
2840         (PythonCheckerTest.test_pylint_false_positives._mock_handle_style_error):
2841         * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Added.
2842         (test_popen):
2843
2844 2013-07-15  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2845
2846         [GTK] Increase the JHBuild version of GStreamer to 1.0.7
2847         https://bugs.webkit.org/show_bug.cgi?id=115166
2848
2849         Reviewed by Philippe Normand.
2850
2851         * gtk/jhbuild.modules: Bumping GStreamer version up to 1.0.8.
2852
2853 2013-07-12  Kwang Yul Seo  <skyul@company100.net>
2854
2855         Unreviewed. Add an email address and update my domain of experts.
2856
2857         * Scripts/webkitpy/common/config/contributors.json:
2858
2859 2013-07-12  Emanuele Aina  <emanuele.aina@collabora.com>
2860
2861         [jhbuild] Avoid restarting from scratch failed initial checkouts
2862         https://bugs.webkit.org/show_bug.cgi?id=118603
2863
2864         Reviewed by Martin Robinson.
2865
2866         If the initial checkout is interrupted midway (eg. because the internet
2867         connection went down) config files do not get generated and that causes
2868         the next checkout to start from scratch (the missing files cause the
2869         script to delete the build root and the downloaded sources).
2870
2871         By generating the files before invoking jhbuild, subsequent runs are able
2872         to start where the previous run left.
2873
2874         * Scripts/update-webkit-libs-jhbuild:
2875         (saveJhbuildMd5): invoke it before runJhbuild().
2876
2877 2013-07-12  Brent Fulgham  <bfulgham@apple.com>
2878
2879         [Windows] Remove single-worker restriction on tests.
2880
2881         * Scripts/webkitpy/port/win.py: Remove restriction of one worker.
2882
2883 2013-07-12  Commit Queue  <commit-queue@webkit.org>
2884
2885         Unreviewed, rolling out r152599.
2886         http://trac.webkit.org/changeset/152599
2887         https://bugs.webkit.org/show_bug.cgi?id=118612
2888
2889         This patch includes a failing unit test (Requested by
2890         mrobinson on #webkit).
2891
2892         * Scripts/webkitpy/style/checkers/python.py:
2893         (Pylinter):
2894         * Scripts/webkitpy/style/checkers/python_unittest.py:
2895         (PythonCheckerTest.test_check):
2896         * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Removed.
2897
2898 2013-07-12  Emanuele Aina  <emanuele.aina@collabora.com>
2899
2900         [Tools] Ignore missing GNUmakefile when detecting previous arch in build-webkit
2901         https://bugs.webkit.org/show_bug.cgi?id=91223
2902
2903         Reviewed by Martin Robinson.
2904
2905         When run on a clean checkout, `build-webkit` complains that no
2906         GNUmakefile exists when trying to detect the previously configured
2907         architecture, but in this case there's no previous configuration so
2908         the warning is pointless.
2909
2910         * Scripts/webkitdirs.pm:
2911         (determineArchitecture): Redirect grep stderr to /dev/null.
2912
2913 2013-07-12  Brian Holt  <brian.holt@samsung.com>
2914
2915         check-webkit-style: Ignore false positive: Instance of 'Popen' has no 'pid' member
2916         https://bugs.webkit.org/show_bug.cgi?id=118592
2917
2918         Reviewed by Martin Robinson.
2919
2920         Added a suppression for pylint false positives and a unit test.
2921
2922         * Scripts/webkitpy/style/checkers/python.py:
2923         (Pylinter):
2924         * Scripts/webkitpy/style/checkers/python_unittest.py:
2925         (PythonCheckerTest.test_check):
2926         (PythonCheckerTest):
2927         (PythonCheckerTest.test_pylint_false_positives):
2928         (PythonCheckerTest.test_pylint_false_positives._mock_handle_pylint_false_positives):
2929         * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Added.
2930         (test_popen):
2931
2932 2013-07-11  Arnaud Renevier  <a.renevier@samsung.com>
2933
2934         Unreviewed. Add myself as a committer.
2935
2936         * Scripts/webkitpy/common/config/contributors.json:
2937
2938 2013-07-10  Sergio Correia  <sergio.correia@openbossa.org>
2939
2940         Handle "load,provisional,failed" with the on_error callback on EFL MiniBrowser
2941         https://bugs.webkit.org/show_bug.cgi?id=118538
2942
2943         Reviewed by Christophe Dumez.
2944
2945         When attempting some odd url such as ``foo'', MiniBrowser will now show an
2946         error message such as "Cannot resolve hostname (foo)".
2947
2948         Previously, it had the following behavior if MiniBrowser was started with
2949         such urls, e.g ``./MiniBrowser foo'':
2950
2951         - Debug:
2952         It wouldt hit WebKit2/Platform/CoreIPC/unix/ConnectionUnix.cpp(460) and crash.
2953
2954         - Release:
2955         No asserts, naturally, but the view would remain blank, even if we tried to
2956         change to a valid url.
2957
2958         * MiniBrowser/efl/main.c:
2959         (window_create):
2960
2961 2013-07-10  Simon Pena  <simon.pena@samsung.com>
2962
2963         [GTK] WebKitTestRunner tries to remove an already deleted event in EventSenderProxy::replaySavedEvents
2964         https://bugs.webkit.org/show_bug.cgi?id=118509
2965
2966         Reviewed by Martin Robinson.
2967
2968         In EventSenderProxy::replaySavedEvents WebKitTestRunner can crash
2969         when trying to remove an event already removed, if another event is
2970         processed in the middle. By using a Deque's takeFirst, we ensure the
2971         element is removed before we dispatch it.
2972
2973         fast/events/mousedown-inside-dragstart-should-not-cause-crash.html no longer
2974         crashes after this fix is added.
2975
2976         * WebKitTestRunner/EventSenderProxy.h: Use a Deque instead of Vector in GTK
2977         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2978         (WTR::EventSenderProxy::replaySavedEvents): Use takeFirst to retrieve the event
2979         from the queue.
2980
2981 2013-07-09  Ryuan Choi  <ryuan.choi@samsung.com>
2982
2983         [EFL] Add ewk_view_device_pixel_ratio_set
2984         https://bugs.webkit.org/show_bug.cgi?id=118521
2985
2986         Reviewed by Gyuyoung Kim.
2987
2988         * EWebLauncher/main.c: Added new option(-r) to test device pixel ratio.
2989         (windowCreate):
2990         (parseUserArguments):
2991
2992 2013-07-09  Bruno de Oliveira Abinader  <brunoabinader@gmail.com>
2993
2994         Unreviewed change of my email addresses.
2995         https://bugs.webkit.org/show_bug.cgi?id=100122
2996
2997         * Scripts/webkitpy/common/config/contributors.json:
2998
2999 2013-07-09  Anders Carlsson  <andersca@apple.com>
3000
3001         DumpRenderTree should stop sending unsupported URLs to NSWorkspace
3002         https://bugs.webkit.org/show_bug.cgi?id=118514
3003         <rdar://problem/13686836>
3004
3005         Reviewed by Sam Weinig.
3006
3007         Add a new default policy delegate and override decidePolicyForNavigationAction: to not pass unhandled URLs to NSWorkspace.
3008
3009         * DumpRenderTree/DefaultPolicyDelegate.h: Added.
3010         * DumpRenderTree/DefaultPolicyDelegate.m: Added.
3011         (-[DefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
3012         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3013         Add DefaultPolicyDelegate.h and DefaultPolicyDelegate.m.
3014
3015         * DumpRenderTree/mac/DumpRenderTree.mm:
3016         (allocateGlobalControllers):
3017         Allocate a DefaultPolicyDelegate object.
3018
3019         (resetWebViewToConsistentStateBeforeTesting):
3020         Set the policy delegate to the default policy delegate.
3021
3022         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3023         Declare the defaultPolicyDelegate object.
3024
3025         * DumpRenderTree/mac/TestRunnerMac.mm:
3026         (TestRunner::setCustomPolicyDelegate):
3027         Set the policy delegate to the default delegate if setDelegate is false.
3028
3029 2013-07-08  Zan Dobersek  <zdobersek@igalia.com>
3030
3031         KURL unit test fixture class should have a meaningful name
3032         https://bugs.webkit.org/show_bug.cgi?id=118467
3033
3034         Reviewed by Sam Weinig.
3035
3036         * TestWebKitAPI/Tests/WebCore/KURL.cpp:
3037         (TestWebKitAPI::TEST_F): Use 'KURLTest' as the name for the KURL unit test's fixture class
3038         instead of the generic and inappropriate 'WebCore' name.
3039
3040 2013-07-08  Antti Koivisto  <antti@apple.com>
3041
3042         Add Deque::removeLast
3043         https://bugs.webkit.org/show_bug.cgi?id=118466
3044
3045         Reviewed by Andreas Kling.
3046
3047         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3048         * TestWebKitAPI/Tests/WTF/Deque.cpp: Added.
3049         (TestWebKitAPI::TEST):
3050
3051 2013-07-08  Brian Holt  <brian.holt@samsung.com>
3052
3053         [GTK] Leak: GFile* leaking in beginDragWithFilesCallback
3054         https://bugs.webkit.org/show_bug.cgi?id=118412
3055
3056         Reviewed by Martin Robinson.
3057
3058         An adoptRef is required to balance ref and deref calls.
3059
3060         * DumpRenderTree/gtk/EventSender.cpp:
3061         (beginDragWithFilesCallback):
3062
3063 2013-07-06  Sergio Correia  <sergio.correia@openbossa.org>
3064
3065         Update list of EFL WK2 API tests
3066         https://bugs.webkit.org/show_bug.cgi?id=118443
3067
3068         Reviewed by Christophe Dumez.
3069
3070         The following tests were included:
3071
3072         Passing:
3073         - CloseThenTerminate
3074         - DidAssociateFormControls
3075         - PageVisibilityState
3076         - ResponsivenessTimerDoesntFireEarly
3077         - TerminateTwice
3078         - WillLoad
3079
3080         Failing:
3081         - ResizeReversePaginatedWebView
3082         - ScrollPinningBehaviors
3083
3084         This patch also modified ``test_webkit2_api_BINARIES'' list so that it is in
3085         alphabetical order.
3086
3087         * TestWebKitAPI/CMakeLists.txt: Added Bundles for included tests.
3088         * TestWebKitAPI/PlatformEfl.cmake: Added a few tests.
3089
3090 2013-07-05  Tim Horton  <timothy_horton@apple.com>
3091
3092         Fix r152265: FrameView's pagination mode is only one of two, and the logic was totally wrong
3093         https://bugs.webkit.org/show_bug.cgi?id=118439
3094         <rdar://problem/14366120>
3095
3096         Reviewed by Anders Carlsson.
3097
3098         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
3099         (TestWebKitAPI::didLayout):
3100         (TestWebKitAPI::TEST):
3101         - Make use of EXPECT_JS_EQ instead of manually doing JavaScript stuff.
3102         - Assert that we got the right number of pages for sanity.
3103         - Reduce the page gap size so that DrawingAreaImpl doesn't try to allocate
3104             so much memory that SharedMemory asserts and makes the test time out.
3105         - Use didFirstLayoutAfterSuppressedIncrementalRendering instead of Paint
3106             because paint doesn't fire if the window is offscreen.
3107
3108 2013-07-05  Tim Horton  <timothy_horton@apple.com>
3109
3110         [wk2] Add API to lock the scroll position at the top or bottom of the page
3111         https://bugs.webkit.org/show_bug.cgi?id=118429
3112         <rdar://problem/14120323>
3113
3114         Reviewed by Anders Carlsson.
3115
3116         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3117         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp: Added.
3118         (TestWebKitAPI::didFinishDocumentLoadForFrame):
3119         (TestWebKitAPI::TEST):
3120         Add a test that ensures that the three pinning modes (DoNotPin, PinToTop, PinToBottom)
3121         all work correctly in the face of resizing the view and scrolling from JS.
3122
3123 2013-07-05  Michael Pruett  <michael@68k.org>
3124
3125         Unreviewed. Add myself as a committer.
3126
3127         * Scripts/webkitpy/common/config/contributors.json:
3128
3129 2013-07-05  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3130
3131         [GTK] WebKit2 test TestWebKitFaviconDatabase times out with recent glib
3132         https://bugs.webkit.org/show_bug.cgi?id=111434
3133
3134         Reviewed by Carlos Garcia Campos.
3135
3136         * Scripts/run-gtk-tests:
3137         (TestRunner): Unskipped TestWebKitFaviconDatabase tests.
3138
3139 2013-07-04  Viatcheslav Ostapenko  <sl.ostapenko@samsung.com>
3140
3141         [EFL] DumpRenderTree doesn't run if "opengl_x11" engine is not available
3142         https://bugs.webkit.org/show_bug.cgi?id=118370
3143
3144         Reviewed by Christophe Dumez.
3145
3146         Add fallback to software X11 engine if opengl_x11 engine creation fails.
3147
3148         * DumpRenderTree/efl/DumpRenderTree.cpp:
3149         (initEcoreEvas):
3150
3151 2013-07-04  Brian Holt  <brian.holt@samsung.com>
3152
3153         [ATK] Leak: AtkAttributeSet* should be freed
3154         https://bugs.webkit.org/show_bug.cgi?id=118307
3155
3156         Reviewed by Christophe Dumez.
3157
3158         Fixed memory leaks for AtkAttributeSet by calling
3159         atk_attribute_set_free().
3160
3161         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
3162         (AccessibilityController::childElementById):
3163         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3164         (getAtkAttributeSetAsString):
3165         (AccessibilityUIElement::allAttributes):
3166         (AccessibilityUIElement::stringAttributeValue):
3167         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
3168         (WTR::childElementById):
3169         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3170         (WTR::getAtkAttributeSetAsString):
3171         (WTR::AccessibilityUIElement::allAttributes):
3172         (WTR::AccessibilityUIElement::stringAttributeValue):
3173
3174 2013-07-03  David Farler  <dfarler@apple.com>
3175
3176         Add Makefile to WebKitLauncher
3177         https://bugs.webkit.org/show_bug.cgi?id=118365
3178
3179         Reviewed by Mark Rowe.
3180
3181         * WebKitLauncher/Makefile: Added.
3182
3183 2013-07-03  Brian Holt  <brian.holt@samsung.com>
3184
3185         [ATK] Leak: more leaks in AccessibilityUIElement
3186         https://bugs.webkit.org/show_bug.cgi?id=118362
3187
3188         Reviewed by Christophe Dumez.
3189
3190         Free the memory created by g_strdup_printf.
3191
3192         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3193         (AccessibilityUIElement::language):
3194         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3195         (WTR::AccessibilityUIElement::language):
3196
3197 2013-07-03  Jer Noble  <jer.noble@apple.com>
3198
3199         Xcode often gets in a state where the debugger is completely unresponsive
3200         https://bugs.webkit.org/show_bug.cgi?id=118157
3201
3202         The GetPointeeData() operations we use to retrieve strings is extremely expensive.
3203         Rather than pull the character data out of the debugger one byte at a time
3204         through the GetPointeeData() API, retrieve the memory contents of the string through
3205         the ReadMemory() API, and convert the retrieved memory into a python string.
3206
3207         Reviewed by Anders Carlsson.
3208
3209         * lldb/lldb_webkit.py:
3210         (__lldb_init_module.lldb_webkit):
3211         (guess_string_length):
3212         (ustring_to_string):
3213         (lstring_to_string):
3214
3215 2013-07-03  Morten Stenshorne  <mstensho@opera.com>
3216
3217         [GTK] Let F5 refresh the page in MiniBrowser
3218         https://bugs.webkit.org/show_bug.cgi?id=117638
3219
3220         Reviewed by Carlos Garcia Campos.
3221
3222         Also use the correct icon for the refresh button that was already there.
3223
3224         * MiniBrowser/gtk/BrowserWindow.c:
3225         (browser_window_init):
3226
3227 2013-07-02  Kondapally Kalyan  <kalyan.kondapally@intel.com>
3228
3229         Unreviewed. Add my email to a few watchlists.
3230
3231         * Scripts/webkitpy/common/config/watchlist:
3232
3233 2013-07-02  David Farler  <dfarler@apple.com>
3234
3235         Unreviewed. Adding myself to contributors.json.
3236
3237         * Scripts/webkitpy/common/config/contributors.json:
3238
3239 2013-07-02  Brian Holt  <brian.holt@samsung.com>
3240
3241         [ATK] Leak: leaks in AccessibilityUIElement
3242         https://bugs.webkit.org/show_bug.cgi?id=118297
3243
3244         Fixed memory leak.
3245
3246         Reviewed by Christophe Dumez.
3247
3248         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3249         (AccessibilityUIElement::stringValue):
3250
3251 2013-07-02  Byungwoo Lee  <bw80.lee@samsung.com>
3252
3253         Fix WebKitTestRunner crashes.
3254         https://bugs.webkit.org/show_bug.cgi?id=117630
3255
3256         Reviewed by Darin Adler.
3257
3258         Create static function to dump for WebProcess unresponsiveness status,
3259         and use it before calling TestController::runTest().
3260
3261         Accessing TestController::m_currentInvocation before calling
3262         TestController::runTest() can make crash because the invocation
3263         instance will be assigned at the function.
3264
3265         * WebKitTestRunner/TestController.cpp:
3266         (WTR::TestController::run):
3267         * WebKitTestRunner/TestInvocation.cpp:
3268         (WTR::TestInvocation::dumpWebProcessUnresponsiveness):
3269         * WebKitTestRunner/TestInvocation.h:
3270
3271 2013-07-02  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3272
3273         [Qt][WK1] Support WebGL with EGL on Linux
3274         https://bugs.webkit.org/show_bug.cgi?id=118251
3275
3276         Reviewed by Kenneth Rohde Christiansen.
3277
3278         * qmake/mkspecs/features/features.prf:
3279
3280 2013-07-01  Nick Diego Yamane  <nick.yamane@openbossa.org>
3281
3282         [Efl][Gtk] Look at WEBKIT_OUTPUTDIR instead of WEBKITOUTPUTDIR in jhbuildrc
3283         https://bugs.webkit.org/show_bug.cgi?id=118267
3284
3285         Reviewed by Gyuyoung Kim.
3286
3287         After r152226 (from https://bugs.webkit.org/show_bug.cgi?id=117249)
3288         WEBKIT_OUTPUTDIR should be used instead of WEBKITOUPUTDIR. However
3289         Efl's jhbuildrc is still using the WEBKITOUTPUTDIR environment variable.
3290
3291         * efl/jhbuildrc:
3292         * gtk/jhbuildrc:
3293
3294 2013-07-01  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
3295
3296         [GTK] Remove unsupported AC backends
3297         https://bugs.webkit.org/show_bug.cgi?id=117362
3298
3299         Reviewed by Martin Robinson.
3300
3301         * gtk/jhbuild-optional.modules: no longer needs clutter-gtk, clutter
3302         and cogl, so removed.
3303
3304 2013-07-01  Timothy Hatcher  <timothy@apple.com>
3305
3306         Link to WebInspectorUI.framework at build time instead of soft linking.
3307
3308         https://bugs.webkit.org/show_bug.cgi?id=118261
3309
3310         Reviewed by Joseph Pecoraro.
3311
3312         * Scripts/build-webkit: Build WebInspectorUI before WebKit and WebKit2.
3313
3314 2013-07-01  Tim Horton  <timothy_horton@apple.com>
3315
3316         Maximum scroll position can be negative in some cases
3317         https://bugs.webkit.org/show_bug.cgi?id=118175
3318         <rdar://problem/14301217>
3319
3320         Reviewed by Anders Carlsson.
3321
3322         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3323         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp: Added.
3324         (TestWebKitAPI::didRunJavaScript):
3325         (TestWebKitAPI::didLayout):
3326         (TestWebKitAPI::TEST):
3327         * TestWebKitAPI/Tests/WebKit2/lots-of-text-vertical-lr.html: Added.
3328         Add a test that loads a vertical-lr document, paginates it horizontally
3329         from right to left, resizes the view to fit the entire document, and
3330         verifies that the scroll position is negative, as it must be for the
3331         document to be enclosed by the view.
3332
3333 2013-07-01  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3334
3335         [EFL][GTK] Migrate from WEBKITOUTPUTDIR to WEBKIT_OUTPUTDIR
3336         https://bugs.webkit.org/show_bug.cgi?id=117249
3337
3338         Reviewed by Brent Fulgham.
3339
3340         Finish converting all use cases of WEBKITOUTPUTDIR to
3341         WEBKIT_OUTPUTDIR, which seems to be preferred these days.
3342
3343         * DumpRenderTree/efl/FontManagement.cpp:
3344         (getCustomBuildDir):
3345         (getPlatformFontsPath):
3346         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3347         (getOutputDir):
3348         * Scripts/webkitdirs.pm:
3349         (determineBaseProductDir):
3350         (usesPerConfigurationBuildDirectory):
3351         * Scripts/webkitpy/port/base.py:
3352         (Port.to.setup_environ_for_server):
3353         * Scripts/webkitpy/port/driver.py:
3354         (Driver._setup_environ_for_driver):
3355         * Scripts/webkitpy/port/gtk.py:
3356         (GtkPort.setup_environ_for_server):
3357         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3358         (WTR::getOutputDir):
3359         * jhbuild/jhbuildutils.py:
3360         (get_dependencies_path):
3361
3362 2013-07-01  Rafael Brandao  <rafael.lobo@webkit.org>
3363
3364         Unreviewed change of my email address.
3365
3366         * Scripts/webkitpy/common/config/contributors.json:
3367
3368 2013-06-28  Andreas Kling  <akling@apple.com>
3369
3370         Fix Windows builds after deprecatedCharactersWithNullTermination() removal.
3371
3372         * DumpRenderTree/win/DumpRenderTree.cpp:
3373         (addFontFallbackIfPresent):
3374         (removeFontFallbackIfPresent):
3375
3376 2013-06-28  Anders Carlsson  <andersca@apple.com>
3377
3378         Remove String::deprecatedCharactersWithNullTermination() and related code
3379         https://bugs.webkit.org/show_bug.cgi?id=118211
3380
3381         Reviewed by Benjamin Poulain.
3382
3383         Remove all hasTerminatingNullCharacter() checks.
3384
3385         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
3386         (TestWebKitAPI::TEST):
3387         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3388         (TestWebKitAPI::TEST):
3389         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3390         (TestWebKitAPI::TEST):
3391
3392 2013-06-28  Alexey Proskuryakov  <ap@apple.com>
3393
3394         [Mac] Crash when loading is stopped from -didReceiveResponse
3395         https://bugs.webkit.org/show_bug.cgi?id=118209
3396         <rdar://problem/14259249>
3397
3398         Reviewed by Brady Eidson.
3399
3400         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3401         * TestWebKitAPI/Tests/mac/StopLoadingFromDidReceiveResponse.html: Added.
3402         * TestWebKitAPI/Tests/mac/StopLoadingFromDidReceiveResponse.mm: Added.
3403         (-[StopLoadingFromDidReceiveResponse webView:resource:didReceiveResponse:fromDataSource:]):
3404         (TestWebKitAPI::TEST):
3405
3406 2013-06-28  Andy Estes  <aestes@apple.com>
3407
3408         [Mac] Newer versions of clang use a default template instantiation depth that is too small for TestWebKitAPI
3409         https://bugs.webkit.org/show_bug.cgi?id=118208
3410
3411         Reviewed by Mark Rowe.
3412
3413         Newer versions of clang use a default template depth of 128, but this
3414         is too small for Tests/WTF/HashSet.cpp. Use 256 instead, which was the
3415         previous default.
3416
3417         Clang lowered the default to keep recursive template instantiation
3418         from overflowing the stack (see <rdar://problem/13935016>), but
3419         TestWebKitAPI's C++ files don't trigger a stack overflow even with the
3420         higher limit. If for some reason this starts happening then we can
3421         lower the limit back down.
3422
3423         * TestWebKitAPI/Configurations/Base.xcconfig: Build TestWebKitAPI with -ftemplate-depth=256.
3424
3425 2013-06-28  Nick Diego Yamane  <nick.yamane@openbossa.org>
3426
3427         [Tools] Add support for "webKitBranchBuild" git option when calculating jhbuildPath
3428         https://bugs.webkit.org/show_bug.cgi?id=118195
3429
3430         Reviewed by Daniel Bates.
3431
3432         Currently, ports that use jhbuild fail to determine jhbuild directory
3433         when "webKitBranchBuild" git configuration property is enabled. To reproduce
3434         that issue in Efl port, enable that flag in .git/config, switch to a git branch
3435         other than "master" and try to build webkit. The build will fail to
3436         locate dependencies due to lack of pkg-config paths which should be set
3437         by jhbuild.
3438
3439         For more details about "webKitBranchBuild" option, see:
3440         https://trac.webkit.org/wiki/UsingGitWithWebKit
3441
3442         * Scripts/webkitdirs.pm:
3443         (getJhbuildPath):
3444
3445 2013-06-28  Jessie Berlin  <jberlin@apple.com>
3446
3447         WebKitTestRunner should disable automatic quote and dash substitution like DumpRenderTree does
3448         https://bugs.webkit.org/show_bug.cgi?id=118201
3449
3450         Reviewed by Dean Jackson.
3451
3452         * WebKitTestRunner/mac/main.mm:
3453         (main):
3454         Modify NSUserDefaults directly since setAutomaticQuoteSubstitutionEnabled and
3455         setAutomaticDashSubstitutionEnabled are not exposed on WKView.
3456
3457 2013-06-28  David Farler  <dfarler@apple.com>
3458
3459         Upstream WebKit Nightly’s WebKitLauncher
3460         https://bugs.webkit.org/show_bug.cgi?id=117418
3461
3462         Reviewed by Mark Rowe.
3463
3464         Literal patch from Nightly's OpenSource repo.
3465
3466         * WebKitLauncher/Configurations/Base.xcconfig:
3467         * WebKitLauncher/Configurations/WebKitLauncher.xcconfig:
3468         * WebKitLauncher/Info.plist:
3469         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
3470         * WebKitLauncher/WebKitLauncherURLProtocol.m:
3471         (+[WebKitLauncherURLProtocol load]):
3472         (+[WebKitLauncherURLProtocol canInitWithRequest:]):
3473         (-[WebKitLauncherURLProtocol startLoading]):
3474         (-[WebKitLauncherURLProtocol handleWebKitVersionInformation]):
3475         (-[WebKitLauncherURLProtocol resourceNotFound]):
3476         * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
3477         (initializeSparkle):
3478         * WebKitLauncher/main.m:
3479         (determineExecutablePath):
3480         (currentMacOSXVersion):
3481         (main):
3482         * WebKitLauncher/start.html:
3483
3484 2013-06-28  Balazs Kelemen  <b.kelemen@samsung.com>
3485
3486         [EFL] back/forward keyboard shortcuts are non-intuitive
3487         https://bugs.webkit.org/show_bug.cgi?id=118193
3488
3489         Reviewed by Christophe Dumez.
3490
3491         Changed shortcuts for go-back/go-forward to alt+left and alt+right.
3492
3493         * EWebLauncher/main.c:
3494         (on_key_down):
3495         * MiniBrowser/efl/main.c:
3496         (on_key_down):
3497
3498 2013-06-28  Roger Fong  <roger_fong@apple.com>
3499
3500         Enable AVFoundation in Web Prefs for WinLauncher and DumpRenderTree on Windows.
3501         https://bugs.webkit.org/show_bug.cgi?id=118194.
3502
3503         Reviewed by Brent Fulgham.
3504
3505         * DumpRenderTree/win/DumpRenderTree.cpp:
3506         (dllLauncherEntryPoint):
3507         * WinLauncher/WinLauncher.cpp:
3508         (dllLauncherEntryPoint):
3509
3510 2013-06-28  Roger Fong  <roger_fong@apple.com>
3511
3512         Unreviewed build fix for AppleWin port. Fix some file paths.
3513
3514         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
3515         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
3516
3517 2013-06-27  Roger Fong  <roger_fong@apple.com>
3518
3519         Add IAccessibilityDelegate implementation to WinLauncher for testing purposes.
3520         https://bugs.webkit.org/show_bug.cgi?id=118160.
3521
3522         Reviewed by Brent Fulgham.
3523
3524         * WinLauncher/AccessibilityDelegate.cpp: Added.
3525         (AccessibilityDelegate::QueryInterface):
3526         (AccessibilityDelegate::AddRef):
3527         (AccessibilityDelegate::Release):
3528         (AccessibilityDelegate::fireFrameLoadStartedEvents): Just returns S_OK;
3529         (AccessibilityDelegate::fireFrameLoadFinishedEvents): Ditto.
3530         * WinLauncher/AccessibilityDelegate.h: Added.
3531         (AccessibilityDelegate::AccessibilityDelegate):
3532         * WinLauncher/WinLauncher.cpp:
3533         (dllLauncherEntryPoint):
3534         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
3535         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
3536
3537 2013-06-28  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3538
3539         Clean up temporary files created by the bindings test script
3540         https://bugs.webkit.org/show_bug.cgi?id=118189
3541
3542         Reviewed by Kentaro Hara.
3543
3544         Remove temporary files created by preprocess-idls.pl script after
3545         the bindings tests are executed.
3546
3547         Based on Blink 153236 by Kentaro Hara <haraken@chromium.org>.
3548
3549         * Scripts/webkitpy/bindings/main.py:
3550         (BindingsTests.main):
3551
3552 2013-06-26  Dean Jackson  <dino@apple.com>
3553
3554         [Mac] Add Mavericks system font to Test systems
3555         https://bugs.webkit.org/show_bug.cgi?id=118109
3556
3557         Reviewed by Simon Fraser.
3558
3559         OS X Mavericks uses a different font for system controls. Tell DRT and
3560         WKTR about them otherwise they use a fallback font. Unfortunately the
3561         fonts are hidden (not found in the list of available fonts) so I
3562         had to add them manually.
3563
3564         Even though there is only one at the moment, I implemented this
3565         as a set so it will be easier to add new fonts if necessary.
3566
3567         * DumpRenderTree/mac/DumpRenderTree.mm:
3568         (allowedFontFamilySet): Fixed typo.
3569         (systemHiddenFontFamilySet): New method that returns the system control font.
3570         (drt_NSFontManager_availableFonts): Merge the hidden fonts.
3571         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3572         (WTR::allowedFontFamilySet): Fixed typo.
3573         (WTR::systemHiddenFontFamilySet): As above.
3574         (WTR::wtr_NSFontManager_availableFonts):
3575
3576 2013-06-27  Anders Carlsson  <andersca@apple.com>
3577
3578         Get rid of the last uses of deprecatedCharactersWithNullTermination()
3579         https://bugs.webkit.org/show_bug.cgi?id=118159
3580
3581         Reviewed by Andreas Kling.
3582
3583         Replace calls to deprecatedCharactersWithNullTermination() with charactersWithNullTermination().data().
3584
3585         * DumpRenderTree/win/DumpRenderTree.cpp:
3586         (findFontFallback):
3587
3588 2013-06-27  Bem Jones-Bey  <bjonesbe@adobe.com>
3589
3590         Sync up w3c import script with changes in Blink
3591         https://bugs.webkit.org/show_bug.cgi?id=118149
3592
3593         Reviewed by Dirk Pranke.
3594
3595         This is a port of the following blink changes:
3596
3597         https://codereview.chromium.org/15366004
3598         https://chromiumcodereview.appspot.com/15592005
3599         https://codereview.chromium.org/16021006
3600         https://codereview.chromium.org/15590004
3601         https://codereview.chromium.org/15901008
3602         https://codereview.chromium.org/16171009
3603         https://codereview.chromium.org/16465007
3604         https://codereview.chromium.org/15981013
3605
3606         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3607         (setUp):
3608         (test_commit_message_for_this_commit):
3609         * Scripts/webkitpy/port/base.py:
3610         (Port):
3611         * Scripts/webkitpy/port/test.py:
3612         * Scripts/webkitpy/w3c/test_converter.py:
3613         (W3CTestConverter.__init__):
3614         (W3CTestConverter.read_webkit_prefixed_css_property_list):
3615         (W3CTestConverter.convert_for_webkit):
3616         (W3CTestConverter.convert_css):
3617         (W3CTestConverter.convert_html):
3618         (W3CTestConverter.convert_testharness_paths):
3619         (W3CTestConverter.convert_prefixed_properties):
3620         (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
3621         * Scripts/webkitpy/w3c/test_converter_unittest.py:
3622         * Scripts/webkitpy/w3c/test_importer.py:
3623         (main):
3624         (configure_logging):
3625         (configure_logging.LogHandler):
3626         (configure_logging.LogHandler.format):
3627         (parse_args):
3628         (TestImporter.__init__):
3629         (TestImporter.find_importable_tests):
3630         (TestImporter.import_tests):
3631         (TestImporter.setup_destination_directory):
3632         (TestImporter.remove_deleted_files):
3633         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3634         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
3635         (TestImporterTest.test_import_dir_with_no_tests):
3636         (TestImporterTest):
3637         * Scripts/webkitpy/w3c/test_parser.py:
3638         (TestParser.load_file):
3639         (TestParser.analyze_test):
3640         (TestParser.support_files):
3641         * Scripts/webkitpy/w3c/test_parser_unittest.py:
3642
3643 2013-06-27  Csaba Osztrogonác  <ossy@webkit.org>
3644
3645         [webkitpy] AbstractPatchSequencingCommand should have _prepare_state
3646         https://bugs.webkit.org/show_bug.cgi?id=118128
3647
3648         Reviewed by Ryosuke Niwa.
3649
3650         It is a preparation for a new webkit-patch command: run-tests-touched-by-attachment
3651         https://bugs.webkit.org/show_bug.cgi?id=117831
3652
3653         * Scripts/webkitpy/tool/commands/download.py:
3654         (AbstractPatchSequencingCommand):
3655         (AbstractPatchSequencingCommand._prepare_to_process): Call _prepare_state before prepare_steps.
3656         (AbstractPatchSequencingCommand._process_patch): Use the same initial state for each patch.
3657         (AbstractPatchSequencingCommand._prepare_state): Added.
3658
3659 2013-06-27  Brendan Long  <b.long@cablelabs.com>
3660
3661         [Qt] Build overrides -j when given --makeargs="-sj40"
3662         https://bugs.webkit.org/show_bug.cgi?id=116897
3663
3664         Reviewed by Csaba Osztrogonác.
3665
3666         * Scripts/webkitdirs.pm:
3667         (buildQMakeProjects):
3668         Change regex checking for -j* to also check for -*j*
3669
3670 2013-06-27  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3671
3672         Remove [NoInterfaceObject] from WorkerGlobalScope
3673         https://bugs.webkit.org/show_bug.cgi?id=118071
3674
3675         Reviewed by Kentaro Hara.
3676
3677         Update bindings test script to pass 2 additional parameters
3678         now needed by the preprocess-idls.pl script.
3679
3680         * Scripts/webkitpy/bindings/main.py:
3681         (BindingsTests.generate_supplemental_dependency):
3682         (BindingsTests.main):
3683
3684 2013-06-27  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3685
3686         Fixing some compiler warnings
3687         https://bugs.webkit.org/show_bug.cgi?id=117791
3688
3689         Reviewed by Martin Robinson.
3690
3691         * GNUmakefile.am: Silenced format warning.
3692         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
3693         (TestWebKitAPI::DOMWindowExtensionNoCache::globalObjectIsAvailableForFrame):
3694         Solved warning about uninitialized variable.
3695
3696 2013-06-27  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3697
3698         Fix bindings tests after r152080
3699         https://bugs.webkit.org/show_bug.cgi?id=118118
3700
3701         Reviewed by Gyuyoung Kim.
3702
3703         r152080 renamed argument to preprocess-idls.pl from --workerContextConstructorsFile
3704         to --workerGlobalScopeConstructorsFile. This patch updates to bindings test script
3705         accordingly.
3706
3707         * Scripts/webkitpy/bindings/main.py:
3708         (BindingsTests.generate_supplemental_dependency):
3709         (BindingsTests.main):
3710
3711 2013-06-26  Carlos Garcia Campos  <cargarcia@blackberry.com>
3712
3713         [BlackBerry] Handle testRunner.setCustomPolicyDelegate()
3714         https://bugs.webkit.org/show_bug.cgi?id=117982
3715
3716         Reviewed by Rob Buis.
3717
3718         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3719         (BlackBerry::WebKit::DumpRenderTree::DumpRenderTree): Initialize
3720         m_policyDelegateIsPermissive.
3721         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
3722         Reset m_policyDelegateIsPermissive.
3723         (BlackBerry::WebKit::DumpRenderTree::setCustomPolicyDelegate): Set
3724         m_policyDelegateIsPermissive.
3725         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
3726         (BlackBerry::WebKit::DumpRenderTree::policyDelegateEnabled):
3727         Return whether custom policy is enabled.
3728         (BlackBerry::WebKit::DumpRenderTree::policyDelegateIsPermissive):
3729         Return whether custom policy is permissive.
3730
3731 2013-06-26  Anders Carlsson  <andersca@apple.com>
3732
3733         Deprecate StringImpl::charactersWithNullTermination
3734         https://bugs.webkit.org/show_bug.cgi?id=118108
3735
3736         Reviewed by Beth Dakin.
3737
3738         Rename calls to charactersWithNullTermination to deprecatedCharactersWithNullTermination.
3739
3740         * DumpRenderTree/win/DumpRenderTree.cpp:
3741         (findFontFallback):
3742         (addFontFallbackIfPresent):
3743         (removeFontFallbackIfPresent):
3744
3745 2013-06-26  Nico Weber  <thakis@chromium.org>
3746
3747         Remove detect-mismached-virtual-const.
3748         https://bugs.webkit.org/show_bug.cgi?id=117999
3749
3750         Reviewed by Anders Carlsson.
3751
3752         Clang warns on mismatched virtual const, so there's no need for this
3753         script any more.
3754
3755         * Scripts/detect-mismatched-virtual-const: Removed.
3756
3757 2013-06-26  Alex Christensen  <achristensen@apple.com>
3758
3759         Added a code coverage report.
3760         https://bugs.webkit.org/show_bug.cgi?id=117941
3761
3762         Reviewed by Joseph Pecoraro.
3763
3764         * CodeCoverage: Added.
3765         * CodeCoverage/results-template.html: Added.
3766         * Scripts/generate-coverage-data: Generate and open the new report.
3767
3768 2013-06-25  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3769
3770         gdb: Remove the webcore.py pretty printer.
3771         https://bugs.webkit.org/show_bug.cgi?id=117992
3772
3773         Reviewed by Jochen Eisinger.
3774
3775         webcore.py has been only a placeholder for backwards compatibility
3776         for almost 3 years. It should be safe enough to remove it now.
3777
3778         * gdb/webcore.py: Removed.
3779
3780 2013-05-26  Peter Gal  <galpeter@inf.u-szeged.hu>
3781
3782         Creating cURL watchlist and adding myself to it.
3783
3784         Reviewed by Csaba Osztrogonác.
3785
3786         * Scripts/webkitpy/common/config/watchlist:
3787
3788 2013-06-25  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3789
3790         Unreviewed, change my email address for watch list.
3791
3792         * Scripts/webkitpy/common/config/watchlist:
3793
3794 2013-06-25  Byungwoo Lee  <bw80.lee@samsung.com>
3795
3796         [EFL] Add a script to install dependencies.
3797         https://bugs.webkit.org/show_bug.cgi?id=117968
3798
3799         Reviewed by Christophe Dumez.
3800
3801         Add a script which installs basic dependencies for building WebKit EFL.
3802
3803         The dependencies are from the current EFLWebKit wiki page.
3804         After this patch is landed, the wiki page will be updated to use
3805         this script.
3806
3807         * efl/install-dependencies: Added.
3808
3809 2013-06-24  Dean Jackson  <dino@apple.com>
3810
3811         [Mac] Update font used for Chinese in test systems
3812         https://bugs.webkit.org/show_bug.cgi?id=117970
3813
3814         Reviewed by Alexey Proskuryakov.
3815
3816         Add "Songti TC" and "Songti SC" to the list of allowed fonts
3817         in DRT and WKTR.
3818
3819         * DumpRenderTree/mac/DumpRenderTree.mm:
3820         (allowedFontFamilySet):
3821         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3822         (WTR::allowedFontFamilySet):
3823
3824 2013-06-24  Tim Horton  <timothy_horton@apple.com>
3825
3826         Make MiniBrowser paginated mode work with WebKit1
3827         https://bugs.webkit.org/show_bug.cgi?id=117950
3828
3829         Reviewed by Beth Dakin.
3830
3831         * MiniBrowser/mac/WK1BrowserWindowController.m:
3832         (-[WK1BrowserWindowController isPaginated]):
3833         (-[WK1BrowserWindowController togglePaginationMode:]):
3834         Hook up isPaginated and togglePaginationMode just as for WebKit2.
3835
3836 2013-06-24  David Kilzer  <ddkilzer@apple.com>
3837
3838         bisect-builds: improve heuristic for choosing the next build after a broken build
3839         <http://webkit.org/b/117918>
3840
3841         Reviewed by Simon Fraser.
3842
3843         * Scripts/bisect-builds: When a build is broken, use a heuristic
3844         that "bisects" the left side or the right side of the remaining
3845         revisions to pick a revision that's sufficiently different from
3846         the revision of the broken build.  This heuristic assumes there
3847         is a sequential range of broken builds whenever one broken build
3848         is found.
3849
3850 2013-06-24  Chris Rogers  <crogers@google.com>
3851
3852         WaveTable name has changed to PeriodicWave
3853         https://bugs.webkit.org/show_bug.cgi?id=117748
3854
3855         Reviewed by Jer Noble.
3856
3857         * Scripts/do-webcore-rename:
3858
3859 2013-06-22  Santosh Mahto  <santosh.ma@samsung.com>
3860
3861         [EFL] Add support for MHTML save/load feature to MiniBrowser
3862         https://bugs.webkit.org/show_bug.cgi?id=106620
3863
3864         Reviewed by Christophe Dumez.
3865
3866         Enable CTRL + S as save page in mhtml and CTRL + L to load any page
3867         from filesystem.
3868
3869         * MiniBrowser/efl/CMakeLists.txt:
3870         * MiniBrowser/efl/main.c:
3871         (page_contents_callback):
3872         (on_key_down):
3873         (show_file_entry_dialog): generic function to show file enrty
3874         selector dialogue
3875
3876 2013-06-21  Brent Fulgham  <bfulgham@apple.com>
3877
3878         [Windows] Unreviewed crash protection for DRT
3879
3880         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Check for null elements in routines
3881         to avoid crashing during test runs.
3882
3883 2013-06-21  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3884
3885         REGRESSION (r150663): Using webkitAudioContext in Inspector makes it undefined everywhere
3886         https://bugs.webkit.org/show_bug.cgi?id=117825
3887
3888         Reviewed by Kentaro Hara.
3889
3890         DumpRenderTreeSupportEfl::setWebAudioEnabled() now requires an additional view argument.
3891
3892         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3893         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3894         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3895         (TestRunner::overridePreference):
3896
3897 2013-06-21  Krzysztof Czech  <k.czech@samsung.com>
3898
3899         [ATK] Added support for aria-required attribute.
3900         https://bugs.webkit.org/show_bug.cgi?id=117730
3901
3902         Reviewed by Chris Fleizach.
3903
3904         Added support for testing aria-required attribute.
3905
3906         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3907         (AccessibilityUIElement::isRequired):
3908         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3909         (WTR::AccessibilityUIElement::isRequired):
3910
3911 2013-06-20  Ryuan Choi  <ryuan.choi@samsung.com>
3912
3913         [CMAKE][EFL] Enable DOM4 Events Constructor
3914         https://bugs.webkit.org/show_bug.cgi?id=117858
3915
3916         Reviewed by Laszlo Gombos.
3917
3918         * Scripts/webkitperl/FeatureList.pm: Enable the feature for the EFL port.
3919
3920 2013-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3921
3922         [BlackBerry] Handle testRunner.setWillSendRequestReturnsNull() in DRT
3923         https://bugs.webkit.org/show_bug.cgi?id=117827
3924
3925         Reviewed by Rob Buis.
3926
3927         Reset the passed in request if willSendRequestReturnsNull() is
3928         true or willSendRequestReturnsNullOnRedirect() is true and it's a
3929         redirection.
3930
3931         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3932         (BlackBerry::WebKit::DumpRenderTree::willSendRequestForFrame):
3933         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
3934
3935 2013-06-20  Csaba Osztrogonác  <ossy@webkit.org>
3936
3937         Commit queue shouldn't reopen unrelated bugs because of flakiness
3938         https://bugs.webkit.org/show_bug.cgi?id=117503
3939
3940         Reviewed by Ryosuke Niwa.
3941
3942         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3943         (_follow_duplicate_chain):
3944         (_update_bug_for_flaky_test):
3945
3946 2013-06-19  Brent Fulgham  <bfulgham@apple.com>
3947
3948         [Windows] AX: Expand notification support.
3949         https://bugs.webkit.org/show_bug.cgi?id=117761
3950
3951         Reviewed by Anders Carlsson.
3952
3953         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3954         (AccessibilityUIElement::isPressActionSupported): Provide implementation.
3955         (AccessibilityUIElement::press): Provide implementation.
3956
3957 2013-06-19  Benjamin Poulain  <bpoulain@apple.com>
3958
3959         Use the PlatformEvent timestamp when creating a DOM Event
3960         https://bugs.webkit.org/show_bug.cgi?id=117179
3961
3962         Reviewed by Darin Adler.
3963
3964         * WebKitTestRunner/mac/EventSenderProxy.mm:
3965         (WTR::EventSenderProxy::mouseDown):
3966         (WTR::EventSenderProxy::mouseUp):
3967         (WTR::EventSenderProxy::mouseMoveTo):
3968         (WTR::EventSenderProxy::keyDown):
3969
3970 2013-06-18  Alex Christensen  <achristensen@apple.com>
3971
3972         Working on coverage script, added xml to json data extraction script.
3973         https://bugs.webkit.org/show_bug.cgi?id=117648
3974
3975         This is part of a new test code coverage analysis tool.  This compiles WebKit to generate
3976         coverage data, runs the tests, and collects all of the data in json format.
3977
3978         Reviewed by Stephanie Lewis.
3979
3980         * Scripts/generate-coverage-data:
3981         (parseGcovrOutput):
3982         (getFileHitsAndBranches):
3983         (addLineCounts):
3984         (createResultName):
3985         * Scripts/webkitpy/tool/gcovr: Added.
3986
3987 2013-06-18  Ryuan Choi  <ryuan.choi@samsung.com>
3988
3989         Unreviewed build fix after r151699.
3990
3991         * TestWebKitAPI/CMakeLists.txt:
3992         * WebKitTestRunner/CMakeLists.txt:
3993         Added include dir for InjectedBundleHitTestResultMediaType.h and WKBundleHitTestResult.h
3994
3995 2013-06-18  Roger Fong  <roger_fong@apple.com>
3996
3997         Replace tools32 folder with tools and update WebKit Windows solution accordingly.
3998         <rdar://problem/14118143>.
3999
4000         Rubberstamped by Brent Fulgham.
4001
4002         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
4003         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props:
4004         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
4005         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
4006         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props:
4007         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props:
4008         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
4009         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props:
4010         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
4011         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
4012         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
4013         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props:
4014         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props:
4015         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
4016         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props:
4017         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props:
4018         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
4019         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props:
4020         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
4021         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props:
4022         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
4023         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props:
4024         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props:
4025         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
4026         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
4027         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props:
4028         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
4029         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props:
4030         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
4031         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
4032         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
4033         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props:
4034         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
4035         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props:
4036         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props:
4037         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
4038         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props:
4039         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
4040         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
4041         * win/record-memory/record-memory.vcxproj:
4042         * win/record-memory/record-memoryDebug.props:
4043         * win/record-memory/record-memoryDebugWinCairo.props:
4044         * win/record-memory/record-memoryProduction.props:
4045         * win/record-memory/record-memoryRelease.props:
4046         * win/record-memory/record-memoryReleaseWinCairo.props:
4047
4048 2013-06-17  Kangil Han  <kangil.han@samsung.com>
4049
4050         Unreviewed. Add my email to a DOM watchlist.
4051
4052         * Scripts/webkitpy/common/config/watchlist:
4053
4054 2013-06-17  Zan Dobersek  <zdobersek@igalia.com>
4055
4056         Unreviewed GTK gardening.
4057
4058         * Scripts/run-gtk-tests:
4059         (TestRunner): Skip three WebKit2APITests suites that are currently timing out.
4060
4061 2013-06-15  Bruno de Oliveira Abinader  <brunoabinader@gmail.com>
4062
4063         Unreviewed. Reorder my email addresses.
4064         https://bugs.webkit.org/show_bug.cgi?id=100122
4065
4066         * Scripts/webkitpy/common/config/contributors.json:
4067
4068 2013-06-14  Enrica Casucci  <enrica@apple.com>
4069
4070         WKPageFindStringMatches ignores the kWKFindOptionsBackwards option.
4071         https://bugs.webkit.org/show_bug.cgi?id=117647
4072         <rdar://problem/13881024>
4073
4074         Reviewed by Darin Adler.
4075         
4076         The test now uses content with a selection and tests both
4077         forwards and backward find as well as the case of a find
4078         that has no matches after the user selection.
4079
4080         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4081         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
4082         (TestWebKitAPI::didFindStringMatches):
4083         * TestWebKitAPI/Tests/WebKit2/findRanges.html: Added.
4084
4085 2013-06-14  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
4086
4087         Remove myself from Qt build system watchlist
4088
4089         Reviewed by Simon Hausmann.
4090
4091         * Scripts/webkitpy/common/config/watchlist:
4092
4093 2013-06-13  Michael Brüning  <michael.bruning@digia.com>
4094
4095         [Qt][Mac] Disable QTKit video on OS X.
4096         https://bugs.webkit.org/show_bug.cgi?id=117591
4097
4098         Reviewed by Tor Arne Vestbø.
4099
4100         Deployment of Qt binaries to different Mac OS X
4101         platform version makes it impossible to link against
4102         the correct version of the WebKitSystemInterface library,
4103         so we need to disable QTKit for media elements.
4104
4105         * qmake/mkspecs/features/features.prf:
4106
4107 2013-06-13  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
4108
4109         [EFL][WK2] Wrong context menu and popup menu positions when scroll is applied
4110         https://bugs.webkit.org/show_bug.cgi?id=116610
4111
4112         Reviewed by Noam Rosenthal.
4113
4114         Remove unnecessary code adjusting context menu position to webview position.
4115         Now position is calculcated in EwkView.
4116
4117         * MiniBrowser/efl/main.c:
4118         (on_context_menu_show):
4119
4120 2013-06-12  Roger Fong  <roger_fong@apple.com>
4121
4122         Unreviewed. Turn on WinEWS test now that AppleWin port uses new-run-webkit-tests.
4123
4124         * Scripts/webkitpy/common/config/ews.json:
4125
4126 2013-06-12  Eduardo Lima Mitev  <elima@igalia.com>
4127
4128         [atk] Replace deprecated call to atk_document_get_locale() in DumpRenderTree
4129         https://bugs.webkit.org/show_bug.cgi?id=115647
4130
4131         Reviewed by Martin Robinson.
4132
4133         Locale resolution is moved to WebKitAccessibleWrapperAtk using
4134         AtkObject::get_object_locale() API. Now, implementation of
4135         AccessibilityUIElement::language() in both DumpRenderTree and WebKitTestRunner can
4136         be leveraged to get_object_locale() of AtkObject.
4137
4138         Apart from improving encapsulation, this avoids calling deprecated get_document_locale()
4139         method.
4140
4141         No new functionality, no new tests.
4142
4143         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
4144         (AccessibilityUIElement::language): Leverage locale resolution to
4145         AtkObject::get_object_locale().
4146         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4147         (WTR::AccessibilityUIElement::language): Leverage locale resolution to
4148         AtkObject::get_object_locale().
4149
4150 2013-06-12  Hugo Parente Lima  <hugo.lima@openbossa.org>
4151
4152         Remove last bits of GYP from build-webkit and update-webkit scripts
4153         https://bugs.webkit.org/show_bug.cgi?id=117557
4154
4155         Reviewed by Ryosuke Niwa.
4156
4157         * Scripts/build-webkit:
4158         * Scripts/update-webkit:
4159
4160 2013-06-12  Hugo Parente Lima  <hugo.lima@openbossa.org>
4161
4162         Remove forgotten unused Tools/Script/make-gypi script
4163         https://bugs.webkit.org/show_bug.cgi?id=117558
4164
4165         Reviewed by Ryosuke Niwa.
4166
4167         This script isn't used since the GYP removal from WebKit.
4168
4169         * Scripts/make-gypi: Removed.
4170
4171 2013-06-12  Andres Gomez  <agomez@igalia.com>
4172
4173         [GTK] MiniBrowser to automatically download "non-showable" documents when left click in link
4174         https://bugs.webkit.org/show_bug.cgi?id=117533
4175
4176         Reviewed by Carlos Garcia Campos.
4177
4178         MiniBrowser now starts automatically the download of the documents
4179         that cannot be shown just by WebKit itself on link left clicking.
4180
4181         * MiniBrowser/gtk/BrowserWindow.c:
4182         (webViewDecidePolicy): handled the
4183         WEBKIT_POLICY_DECISION_TYPE_RESPONSE decision type too.
4184
4185 2013-06-12  Zan Dobersek  <zdobersek@igalia.com>
4186
4187         [GTK] Remove the WebCoreLayer(Gtk2).a archives before regenerating them
4188         https://bugs.webkit.org/show_bug.cgi?id=116723
4189
4190         Reviewed by Carlos Garcia Campos.
4191
4192         * TestWebKitAPI/GNUmakefile.am: When generating the WebCoreLayer.a archive from all the dependency archives,
4193         remove the current archive (if any). Updating an existent archive in an incremental build is not bulletproof
4194         and can lead to corrupt archives and subsequent build failures. On the other hand, the archive generation is
4195         not expensive and produces a working archive without problems even on incremental builds.
4196
4197 2013-06-11  Santosh Mahto  <santosh.ma@samsung.com>
4198
4199         [EFL] Window resize should close the popupmenu
4200         https://bugs.webkit.org/show_bug.cgi?id=117391
4201
4202         Reviewed by Christophe Dumez.
4203         
4204         Added the code to close the popup when main window is resized.
4205
4206         * MiniBrowser/efl/main.c:
4207         (on_window_resize):
4208
4209 2013-06-11  Alex Christensen  <achristensen@apple.com>
4210
4211         Removed old broken code coverage tool.
4212         https://bugs.webkit.org/show_bug.cgi?id=117520
4213
4214         Reviewed by Sam Weinig.
4215
4216         * CodeCoverage: Removed.
4217         * CodeCoverage/README: Removed.
4218         * CodeCoverage/amber.png: Removed.
4219         * CodeCoverage/cov.py: Removed.
4220         * CodeCoverage/emerald.png: Removed.
4221         * CodeCoverage/gcov.css: Removed.
4222         * CodeCoverage/glass.png: Removed.
4223         * CodeCoverage/regenerate-coverage-display: Removed.
4224         * CodeCoverage/ruby.png: Removed.
4225         * CodeCoverage/run-generate-coverage-data: Removed.
4226         * CodeCoverage/snow.png: Removed.
4227
4228 2013-06-11  Timothy Hatcher  <timothy@apple.com>
4229
4230         Have build-webkit build the WebInspectorUI project.
4231
4232         * Scripts/build-webkit:
4233
4234 2013-06-11  Ryosuke Niwa  <rniwa@webkit.org>
4235
4236         Add an option to run-webkit-tests to skip java dependency check
4237         https://bugs.webkit.org/show_bug.cgi?id=117516
4238
4239         Reviewed by Andreas Kling.
4240
4241         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4242         (parse_args):
4243         * Scripts/webkitpy/port/mac.py:
4244         (MacPort._check_port_build):
4245
4246 2013-06-11  Alex Christensen  <achristensen@apple.com>
4247
4248         https://bugs.webkit.org/show_bug.cgi?id=117514
4249         Removed extra Xcode code coverage flags.
4250
4251         Reviewed by Sam Weinig.
4252
4253         * Scripts/webkitdirs.pm:
4254         (XcodeCoverageSupportOptions):
4255
4256 2013-06-11  Brent Fulgham  <bfulgham@apple.com>
4257
4258         [Windows] Implement 'attributeValue' accessor to support testing
4259         https://bugs.webkit.org/show_bug.cgi?id=117513
4260
4261         Reviewed by Anders Carlsson.
4262
4263         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
4264         (comparableObject): Move earlier in file.
4265         (findAccessibleObjectById): New implemenation.
4266         (AccessibilityController::accessibleElementById): New implementation.
4267
4268 2013-06-11  Csaba Osztrogonác  <ossy@webkit.org>
4269
4270         Make WTR use its own temporary directory for application cache
4271         https://bugs.webkit.org/show_bug.cgi?id=117143
4272
4273         Reviewed by Alexey Proskuryakov.
4274
4275         * WebKitTestRunner/TestController.cpp:
4276         (WTR::TestController::initialize):
4277
4278 2013-06-10  Alexey Proskuryakov  <ap@apple.com>
4279
4280         https://bugs.webkit.org/show_bug.cgi?id=117449
4281         Remove dead code for storing fonts in __DATA section
4282
4283         Reviewed by Dan Bernstein.
4284
4285         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
4286         Don't copy font resources to __DATA, as we don't have any code that reads them
4287         from there (previously removed due to being under "defined(BUILDING_ON_LEOPARD)").
4288
4289         * DumpRenderTree/mac/DumpRenderTree.mm: (activateTestingFonts):
4290         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm: (WTR::activateFonts):
4291         Removed comments suggesting that we want to restore the old solution.
4292
4293 2013-06-10  Bear Travis  <betravis@adobe.com>
4294
4295         [CSS Shapes][CSS Exclusions] Split CSS Exclusions and CSS Shapes code
4296         https://bugs.webkit.org/show_bug.cgi?id=117162
4297
4298         Reviewed by Alexandru Chiculita.
4299
4300         Adding the WebCore/rendering/shapes directory to the include list.
4301
4302         * DumpRenderTree/efl/CMakeLists.txt:
4303
4304 2013-06-09  Brent Fulgham  <bfulgham@apple.com>
4305
4306         [Windows] Unreviewed test correction:  Prevent DumpRenderTree crashes
4307         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
4308         (AccessibilityUIElement::role): Prevent crashes when m_element is null. This
4309         happends in some of the 'accessibility' test cases.
4310
4311 2013-06-08  peavo@outlook.com  <peavo@outlook.com>
4312
4313         [WinCairo] TestWebKitAPI fails to link.
4314         https://bugs.webkit.org/show_bug.cgi?id=117345
4315
4316         Reviewed by Brent Fulgham.
4317
4318         Need to link with WTF.lib.
4319
4320         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Link with WTF.lib.
4321
4322 2013-06-07  Roger Fong  <roger_fong@apple.com>
4323
4324         Get rid of not very helpful test that fails only on some machines because xcrun is not installed.
4325
4326         Rubberstamped by Ryousuke Niwa.
4327
4328         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
4329         (RunTest.test_build_check):
4330
4331 2013-06-07  Hugo Parente Lima  <hugo.lima@openbossa.org>
4332
4333         [Qt] Remove Qt bits from Scripts/webkitperl/FeatureList.pm
4334         https://bugs.webkit.org/show_bug.cgi?id=117315
4335
4336         Reviewed by Benjamin Poulain.
4337
4338         Qt doesn't use the default values specified on FeatureList since r44681,
4339         this patch just remove a bit of noise.
4340
4341         * Scripts/webkitperl/FeatureList.pm:
4342
4343 2013-06-07  Jungsik Tae  <davidtlay88@gmail.com>
4344
4345