Fix the lldb WebCoreLayoutUnitProvider to not dynamically look up the LayoutUnit...
[WebKit-https.git] / Tools / ChangeLog
1 2016-01-21  Simon Fraser  <simon.fraser@apple.com>
2
3         Fix the lldb WebCoreLayoutUnitProvider to not dynamically look up the LayoutUnit denominator
4         https://bugs.webkit.org/show_bug.cgi?id=153334
5
6         Reviewed by Zalan Bujtas.
7         
8         Evaluating expressions in the LayoutUnit summary provider seems to cause
9         re-entrancy problems in lldb python bindings, so just hardcode the LayoutUnit
10         denominator to 64.
11
12         * lldb/lldb_webkit.py:
13         (WebCoreLayoutUnitProvider.to_string):
14
15 2016-01-21  Filip Pizlo  <fpizlo@apple.com>
16
17         display-profiler-output should be able to display code blocks sorted by machine counts
18         https://bugs.webkit.org/show_bug.cgi?id=153298
19
20         Reviewed by Oliver Hunt.
21
22         * Scripts/display-profiler-output:
23
24 2016-01-21  Julien Isorce  <j.isorce@samsung.com>
25
26         Ensure to use compatible liborc version with wanted gstreamer version
27         https://bugs.webkit.org/show_bug.cgi?id=153276
28
29         For example gst-plugins-base-1.4.4 fails to build with liborc-0.4.24.
30         The user may have a very recent liborc installed on his system.
31
32         Reviewed by Philippe Normand.
33
34         * efl/jhbuild.modules: add liborc-0.4.17 and make it a gst dependency.
35         * gtk/jhbuild.modules: add liborc-0.4.17 and make it a gst depencendy.
36
37 2016-01-21  Nan Wang  <n_wang@apple.com>
38
39         AX: [IOS] Implement next/previous text marker functions using TextIterator
40         https://bugs.webkit.org/show_bug.cgi?id=153292
41         <rdar://problem/24268243>
42
43         Reviewed by Chris Fleizach.
44
45         Made text marker tests available on iOS.
46
47         * DumpRenderTree/AccessibilityTextMarker.h:
48         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
49         * DumpRenderTree/ios/AccessibilityTextMarkerIOS.mm: Added.
50         (AccessibilityTextMarker::AccessibilityTextMarker):
51         (AccessibilityTextMarker::~AccessibilityTextMarker):
52         (AccessibilityTextMarker::isEqual):
53         (AccessibilityTextMarker::platformTextMarker):
54         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
55         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
56         (AccessibilityTextMarkerRange::isEqual):
57         (AccessibilityTextMarkerRange::platformTextMarkerRange):
58         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
59         (AccessibilityUIElement::pathDescription):
60         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
61         (AccessibilityUIElement::textMarkerRangeForElement):
62         (AccessibilityUIElement::selectedTextMarkerRange):
63         (AccessibilityUIElement::resetSelectedTextMarkerRange):
64         (AccessibilityUIElement::textMarkerRangeLength):
65         (AccessibilityUIElement::textMarkerRangeForMarkers):
66         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
67         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
68         (AccessibilityUIElement::accessibilityElementForTextMarker):
69         (AccessibilityUIElement::endTextMarkerForBounds):
70         (AccessibilityUIElement::startTextMarkerForBounds):
71         (AccessibilityUIElement::textMarkerForPoint):
72         (AccessibilityUIElement::previousTextMarker):
73         (AccessibilityUIElement::nextTextMarker):
74         (AccessibilityUIElement::stringForTextMarkerRange):
75         (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
76         (AccessibilityUIElement::indexForTextMarker):
77         (AccessibilityUIElement::isTextMarkerValid):
78         (AccessibilityUIElement::textMarkerForIndex):
79         (AccessibilityUIElement::startTextMarker):
80         (AccessibilityUIElement::endTextMarker):
81         (AccessibilityUIElement::setSelectedVisibleTextRange):
82         (AccessibilityUIElement::getLinkedUIElements):
83         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
84         (AccessibilityTextMarkerRange::platformTextMarkerRange):
85         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
86         (AccessibilityUIElement::removeSelection):
87         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
88         (AccessibilityUIElement::setSelectedVisibleTextRange):
89         (AccessibilityUIElement::supportedActions):
90         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
91         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
92         (WTR::AccessibilityUIElement::textMarkerRangeLength):
93         (WTR::AccessibilityUIElement::previousTextMarker):
94         (WTR::AccessibilityUIElement::nextTextMarker):
95         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
96         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
97         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
98         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
99         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
100         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
101         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
102
103 2016-01-20  Filip Pizlo  <fpizlo@apple.com>
104
105         Unreviewed, revert accidental unreviewed commit.
106
107         * Scripts/display-profiler-output:
108
109 2016-01-20  Jason Marcell  <jmarcell@apple.com>
110
111         Refactor compareIterations to remove duplicate code.
112         https://bugs.webkit.org/show_bug.cgi?id=152913
113
114         Reviewed by Daniel Bates.
115
116         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
117         (BuildbotQueue.prototype.compareIterations): Refactored to remove duplicate code.
118         (BuildbotQueue.prototype.sortIterations): Add binding to call to compareIterations.
119         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests in order to ensure
120         the same behavior before and after refactor.
121
122 2016-01-20  Dana Burkart  <dburkart@apple.com>
123
124         Botwatcher's dashboard should show an 'X' when the build is broken
125         https://bugs.webkit.org/show_bug.cgi?id=152507
126
127         Reviewed by David Kilzer.
128
129         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
130         (BuildbotStaticAnalyzerQueueView.prototype.appendStaticAnalyzerQueueStatus):
131         (BuildbotStaticAnalyzerQueueView.prototype.update):
132
133 2016-01-19  Jason Marcell  <jmarcell@apple.com>
134
135         Remove assertion from revisionContentForIteration that is causing errors on the dashboard.
136         https://bugs.webkit.org/show_bug.cgi?id=153262
137
138         Reviewed by Alexey Proskuryakov.
139
140         Occasionaly some buildbot iterations will not have their "got_revisions" property populated. In
141         such cases this revisionContentForIteration method does not have any content to return, thus the
142         assertion fails.
143
144         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
145         (BuildbotQueueView.prototype.revisionContentForIteration): Removed assertion that was causing errors.
146
147 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
148
149         [GTK] Runtime critical warnings when loading a URL after a session restore
150         https://bugs.webkit.org/show_bug.cgi?id=153233
151
152         Reviewed by Michael Catanzaro.
153
154         Add new test case.
155
156         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
157         (viewLoadChanged):
158         (testWebKitWebViewNavigationAfterSessionRestore):
159         (beforeAll):
160
161 2016-01-19  Michael Catanzaro  <mcatanzaro@igalia.com>
162
163         [GTK] Remove jhbuild-optional.modules
164         https://bugs.webkit.org/show_bug.cgi?id=152964
165
166         Reviewed by Alex Christensen.
167
168         * gtk/jhbuild-optional.modules: Removed.
169         * gtk/jhbuild.modules:
170
171 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
172
173         [GTK] Add support to load/save session in MiniBrowser
174         https://bugs.webkit.org/show_bug.cgi?id=153201
175
176         Reviewed by Michael Catanzaro.
177
178         It makes it easier to test the new WebView session API.
179
180         * MiniBrowser/gtk/BrowserWindow.c:
181         (browserWindowFinalize): Free the session file path.
182         (browserWindowSaveSession): Save the current WebView session if
183         there's a session file path.
184         (browserWindowDeleteEvent): Call browserWindowSaveSession().
185         (browser_window_load_session): Try to load the session from the
186         given file path, otherwise fall back to homepage and keep the
187         session file to save the session on window close.
188         * MiniBrowser/gtk/BrowserWindow.h:
189         * MiniBrowser/gtk/main.c:
190         (createBrowserWindow): Pass the given session file path when
191         shouldLoadSession is TRUE.
192         (main): Only allow to restore/save session when MiniBrowser is
193         launched without URL arguments.
194
195 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
196
197         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/geolocation-permission-requests after r195075.
198
199         Geolocation is no longer allowed for unique origins after r195075.
200
201         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
202         (testWebViewGeolocationPermissionRequests):
203
204 2016-01-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
205
206         [GTK][EFL] Layout tests abort with PulseAudioSanitizer instance has no attribute '_pa_module_index' when the build is not ready.
207         https://bugs.webkit.org/show_bug.cgi?id=153216
208
209         Reviewed by Michael Catanzaro.
210
211         * Scripts/webkitpy/port/pulseaudio_sanitizer.py:
212         (PulseAudioSanitizer.__init__): initialize _pa_module_index in the constructor.
213
214 2016-01-18  Nan Wang  <n_wang@apple.com>
215
216         AX: [Mac] Implement next/previous text marker functions using TextIterator
217         https://bugs.webkit.org/show_bug.cgi?id=152728
218
219         Reviewed by Chris Fleizach.
220
221         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
222         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
223
224 2016-01-18  Csaba Osztrogonác  <ossy@webkit.org>
225
226         [cmake] Add testair to the build system
227         https://bugs.webkit.org/show_bug.cgi?id=153126
228
229         Reviewed by Michael Catanzaro.
230
231         * Scripts/build-jsc:
232
233 2016-01-16  Myles C. Maxfield  <mmaxfield@apple.com>
234
235         Remove TextRun::allowsRoundingHacks()
236         https://bugs.webkit.org/show_bug.cgi?id=153185
237
238         Reviewed by Simon Fraser.
239
240         * DumpRenderTree/mac/DumpRenderTree.mm:
241         (resetWebViewToConsistentStateBeforeTesting): Deleted.
242
243 2016-01-15  Konstantin Tokarev  <annulen@yandex.ru>
244
245         [webkitdirs] Avoid list form of open because it broke WinCairo
246         https://bugs.webkit.org/show_bug.cgi?id=153106
247
248         Reviewed by Alex Christensen.
249
250         * Scripts/webkitdirs.pm:
251         (determineArchitecture):
252
253 2016-01-15  Simon Fraser  <simon.fraser@apple.com>
254
255         Add kdebug_trace signposts for a few WebCore operations
256         https://bugs.webkit.org/show_bug.cgi?id=153136
257         rdar://problem/24208487
258
259         Reviewed by Sam Weinig.
260         
261         Plist used by kdebug_trace() viewing tools.
262
263         * Tracing/SystemTracePoints.plist: Added.
264
265 2016-01-14  Konstantin Tokarev  <annulen@yandex.ru>
266
267         [webkitdirs] Replaced grep invocation with perl code
268         https://bugs.webkit.org/show_bug.cgi?id=153106
269
270         Reviewed by Alex Christensen.
271
272         * Scripts/webkitdirs.pm:
273         (determineArchitecture):
274
275 2016-01-14  Brian Burg  <bburg@apple.com>
276
277         prepare-changelog does not read paths containing spaces properly
278         https://bugs.webkit.org/show_bug.cgi?id=137982
279
280         Reviewed by Joseph Pecoraro.
281
282         Escape whitespace in filenames before passing the file path to other functions.
283
284         * Scripts/prepare-ChangeLog:
285         (generateFunctionLists): Use the more explicit 3-argument form of 'open'.
286
287 2016-01-14  Jason Marcell  <jmarcell@apple.com>
288
289         Standardize the usage of "branch" vs. "branchName".
290         https://bugs.webkit.org/show_bug.cgi?id=152982
291
292         Reviewed by Daniel Bates.
293
294         In an earlier patch we started using the name "branch" to indicate a branch object, whereas
295         "branchName" implies that the variable or property in question is simply a string.
296
297         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
298         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Change branch to branchName.
299         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Change branch to branch.name.
300         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Change branch to branchName.
301         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
302         (Trac.prototype.commitsOnBranch): Change branch to branchName.
303         (Trac.prototype._convertCommitInfoElementToObject): Ditto.
304         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
305         (MockTrac): Ditto.
306
307 2016-01-14  Jason Marcell  <jmarcell@apple.com>
308
309         Add a unit test to test BuildbotQueueView._appendPendingRevisionCount.
310         https://bugs.webkit.org/show_bug.cgi?id=152910
311
312         Reviewed by Daniel Bates.
313
314         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueue.js: Added.
315         (MockBuildbotQueue): Added. Mock BuildbotQueue object that doesn't need to talk to an actual Buildbot server.
316         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js: Added.
317         (MockBuildbotQueueView): Added. Mock BuildbotQueueView object that returns a pre-specified _latestProductiveIteration without
318         the need to talk to a real Buildbot server.
319         (MockBuildbotQueueView.prototype._latestProductiveIteration): Added. Returns a pre-specified _latestProductiveIteration
320         without the need to talk to a real Buildbot server.
321         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js: Added.
322         (MockTrac): Added. Mock Trac constructor that has pre-populated "recordedCommits" and does not need to talk to a real Trac
323         server.
324         (MockTrac.prototype.get oldestRecordedRevisionNumber): Added. Returns a pre-specified revision.
325         (MockTrac.prototype.get latestRecordedRevisionNumber): Ditto.
326         (MockTrac.prototype.loadMoreHistoricalData): Added. Overrides the real loadMoreHistoricalData so that we don't waste time
327         trying to talk to Trac.
328         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Added. Web page container for
329         QUnit unit tests.
330         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added. QUnit unit tests.
331
332 2016-01-14  Nikos Andronikos  <nikos.andronikos-webkit@cisra.canon.com.au>
333
334         [CMake][GTK] CMake Error: Could not create named generator Eclipse CDT4 - Ninja
335         https://bugs.webkit.org/show_bug.cgi?id=132599
336
337         Reviewed by Michael Catanzaro.
338
339         Check if cmake Ninja generators are installed.
340
341         * Scripts/webkitdirs.pm:
342         (canUseNinjaGenerator):
343         (canUseEclipseNinjaGenerator):
344         (generateBuildSystemFromCMakeProject):
345         (canUseEclipse): Deleted.
346
347 2016-01-13  Myles C. Maxfield  <mmaxfield@apple.com>
348
349         [Cocoa] Testing with font family name "System Font" is unused
350         https://bugs.webkit.org/show_bug.cgi?id=153073
351         <rdar://problem/24091683>
352
353         Reviewed by Brent Fulgham.
354
355         * DumpRenderTree/mac/DumpRenderTree.mm:
356         (allowedFontFamilySet): Deleted.
357         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
358         (WTR::allowedFontFamilySet): Deleted.
359         * WebKitTestRunner/mac/TestControllerMac.mm:
360         (WTR::allowedFontFamilySet): Deleted.
361
362 2016-01-13  Daniel Bates  <dabates@apple.com>
363
364         [XSS Auditor] Add test when XSS payload is in the path portion of the URL
365         https://bugs.webkit.org/show_bug.cgi?id=152871
366
367         Reviewed by Brent Fulgham.
368
369         Merged from Blink (patch by Tom Sepez <tsepez@chromium.org>):
370         <https://src.chromium.org/viewvc/blink?revision=164746&view=revision>
371
372         * Scripts/webkitpy/layout_tests/servers/lighttpd.conf:
373
374 2016-01-08  Andy Estes  <aestes@apple.com>
375
376         [Content Filtering] Lazily load platform frameworks
377         https://bugs.webkit.org/show_bug.cgi?id=152881
378         rdar://problem/23270886
379
380         Reviewed by Brady Eidson.
381
382         Added an API test that verifies that the Parental Controls and Network Extension frameworks are loaded at the
383         expected times. The test verifies that they are not loaded after creating a WKWebView, loading an HTML string,
384         loading NSData, loading a file, or loading from a custom protocol. It verifies that Network Extension on Mac/iOS
385         and Parental Controls on iOS are loaded after an HTTP request. It finally verifies that Parental Controls on Mac
386         is loaded after an HTTPS request.
387
388         To accomplish this, TestProtocol was generalized to allow tests to specify the scheme they wish to use.
389         Other tests that used TestProtocol were updated to account for this change. TestProtocol was removed from
390         WebKit2.PreventImageLoadWithAutoResizingTest, which didn't actually need to use it. ContentFiltering tests were
391         also re-enabled on iOS after mistakenly being disabled by r188892.
392
393         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
394         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
395         (TestWebKitAPI::TEST):
396         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.h: Added.
397         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.html: Added.
398         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
399         (TEST):
400         (downloadTest):
401         (-[LazilyLoadPlatformFrameworksController init]):
402         (-[LazilyLoadPlatformFrameworksController webView]):
403         (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
404         (-[LazilyLoadPlatformFrameworksController webView:didFinishNavigation:]):
405         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
406         (-[ContentFilteringPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
407         (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]):
408         (-[ContentFilteringPlugIn checkIfPlatformFrameworksAreLoaded:]):
409         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
410         (TestWebKitAPI::TEST):
411         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
412         (TestWebKitAPI::TEST): Deleted.
413         * TestWebKitAPI/cocoa/TestProtocol.h:
414         * TestWebKitAPI/cocoa/TestProtocol.mm:
415         (+[TestProtocol registerWithScheme:]):
416         (+[TestProtocol unregister]):
417
418 2016-01-12  Dewei Zhu  <dewei_zhu@apple.com>
419
420         Fix the Sunpider converage in slow device.
421         https://bugs.webkit.org/show_bug.cgi?id=152938
422         <rdar://problem/22511411>
423
424         Reviewed by Ryosuke Niwa.
425
426         Updated the patch for RunBenchmark to resume sunspider coverage by removing unused subresources in sub-tests.
427
428         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch:
429
430 2016-01-12  Ryosuke Niwa  <rniwa@webkit.org>
431
432         Add a build flag for custom element
433         https://bugs.webkit.org/show_bug.cgi?id=153005
434
435         Reviewed by Alex Christensen.
436
437         Added --custom-elements option to enable custom elements support.
438
439         * Scripts/webkitperl/FeatureList.pm:
440
441 2016-01-12  Benjamin Poulain  <bpoulain@apple.com>
442
443         [JSC] Add a help message when run-jsc-stress-tests fails
444         https://bugs.webkit.org/show_bug.cgi?id=153014
445
446         Reviewed by Csaba Osztrogonác.
447
448         * Scripts/run-jsc-stress-tests:
449
450 2016-01-11  Saam barati  <sbarati@apple.com>
451
452         run-jsc-stress-tests should try to figure out a JSC path
453         https://bugs.webkit.org/show_bug.cgi?id=152971
454
455         Reviewed by Yusuke Suzuki.
456
457         This patch now allows run-jsc-stress-tests to be run
458         without a "--jsc <jsc-path>" argument. It tries
459         to take its best guess at a <jsc-path> automagically.
460         
461         This makes it much easier to just run run-jsc-stress-tests
462         with a directory or a yaml file as an argument.
463         You now just do this:
464         `run-jsc-stress-tests <path-to-yaml>`
465         or
466         `run-jsc-stress-tests <path-to-directory-of-js-files>`
467         
468         I wrote this patch because I'd often find myself hacking the 
469         run-javascriptcore-tests file just to run a particular subset of tests.
470         Because I always forget the arguments to run-jsc-stress-tests (which means
471         I always forgot to provide a --jsc argument), I always found it easier to 
472         just hack on that file instead of calling run-jsc-stress-tests directly.
473         No longer is this true!
474
475         * Scripts/run-jsc-stress-tests:
476
477 2016-01-09  Andy Estes  <aestes@apple.com>
478
479         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
480         https://bugs.webkit.org/show_bug.cgi?id=152950
481         rdar://problem/24066652
482
483         Reviewed by Tim Horton.
484
485         Added an API test.
486
487         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
488         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
489         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
490         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
491         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
492         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
493         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
494         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
495         (TEST):
496
497 2016-01-11  Commit Queue  <commit-queue@webkit.org>
498
499         Unreviewed, rolling out r194866.
500         https://bugs.webkit.org/show_bug.cgi?id=152986
501
502         This change broke the mac build (Requested by ryanhaddad on
503         #webkit).
504
505         Reverted changeset:
506
507         "[Cocoa] Add SPI to opt out a URL scheme from the memory
508         cache"
509         https://bugs.webkit.org/show_bug.cgi?id=152950
510         http://trac.webkit.org/changeset/194866
511
512 2016-01-11  Andy Estes  <aestes@apple.com>
513
514         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
515         https://bugs.webkit.org/show_bug.cgi?id=152950
516         rdar://problem/24066652
517
518         Reviewed by Tim Horton.
519
520         Added an API test.
521
522         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
523         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
524         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
525         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
526         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
527         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
528         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
529         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
530         (TEST):
531
532 2016-01-11  Konstantin Tokarev  <annulen@yandex.ru>
533
534         [webkitdirs] Use CMake to determine architecture on isCMakeBuild()
535         https://bugs.webkit.org/show_bug.cgi?id=152959
536
537         Reviewed by Brent Fulgham.
538
539         * Scripts/webkitdirs.pm:
540         (determineArchitecture):
541
542 2016-01-11  Michael Catanzaro  <mcatanzaro@igalia.com>
543
544         [GTK] W3C CSS2.1 anonymous table tests are failing
545         https://bugs.webkit.org/show_bug.cgi?id=152455
546
547         Reviewed by Mario Sanchez Prada.
548
549         Add shared-mime-info to the jhbuild environment, since it affects the results of layout
550         tests. Add upstream patches to fix detection of XHTML files.
551
552         * gtk/jhbuild.modules:
553         * gtk/patches/shared-mime-info-xht-glob.patch: Added.
554         * gtk/patches/shared-mime-info-xhtml-magic.patch: Added.
555
556 2016-01-10  Saam barati  <sbarati@apple.com>
557
558         Implement a sampling profiler
559         https://bugs.webkit.org/show_bug.cgi?id=151713
560
561         Reviewed by Filip Pizlo.
562
563         * Scripts/run-jsc-stress-tests:
564
565 2016-01-10  Konstantin Tokarev  <annulen@yandex.ru>
566
567         [webkitdirs] Try arch and uname commands on non-windows OS
568         https://bugs.webkit.org/show_bug.cgi?id=152958
569
570         Reviewed by Michael Catanzaro.
571
572         Right now, determineArchitecture()  uses `arch` and `uname -m`
573         commands to determine architecture in case of condition (isGtk() ||
574         isAppleMacWebKit() || isEfl()) is true. This should be !anyWindows()
575         instead, because this code is applicable to any non-windows OS WebKit
576         supports (even Haiku which once was supported is moderately
577         POSIX-compliant and has uname command).
578
579         * Scripts/webkitdirs.pm:
580         (determineArchitecture):
581
582 2016-01-08  Aakash Jain  <aakash_jain@apple.com>
583
584         run-webkit-tests mis-counts totals when there are other crashes
585         https://bugs.webkit.org/show_bug.cgi?id=152894
586         <rdar://problem/24098697>
587
588         Reviewed by Alexey Proskuryakov.
589
590         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
591         (TestRunResults.add): Do not update result counters for other crashes.
592
593 2016-01-08  Youenn Fablet  <youenn.fablet@crf.canon.fr>
594
595         webkit-patch build-and-test should have an option to iterate over new tests
596         https://bugs.webkit.org/show_bug.cgi?id=143093
597
598         Reviewed by Michael Catanzaro.
599
600         This patch introduces the --iterate-on-new-tests option to webkit-patch build-and-test.
601         It allows running run-webkit-tests on modified or new paths in LayoutTests.
602         Computation of new or modified tests is done by LayoutTestFinder.find_touched_tests
603         It implements the translation of -expected.* paths to their related tests.
604         It also implements the removal of skipped tests.
605
606         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
607         (LayoutTestFinder.find_touched_tests):
608         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py: Added.
609         (MockPort):
610         (MockPort.__init__):
611         (MockPort.tests):
612         (LayoutTestFinderTests):
613         (LayoutTestFinderTests.touched_files):
614         (LayoutTestFinderTests.test_touched_test):
615         (LayoutTestFinderTests.test_expected_touched_test):
616         (LayoutTestFinderTests.test_platform_expected_touched_test):
617         (LayoutTestFinderTests.test_platform_duplicate_touched_test):
618         (LayoutTestFinderTests.test_touched_but_skipped_test):
619         * Scripts/webkitpy/port/base.py:
620         (Port.potential_test_names_from_expected_file):
621         * Scripts/webkitpy/tool/commands/download_unittest.py:
622         (DownloadCommandsTest._default_options):
623         * Scripts/webkitpy/tool/steps/options.py:
624         (Options):
625         * Scripts/webkitpy/tool/steps/runtests.py:
626         (RunTests.options):
627         (RunTests.run):
628         (RunTests):
629         (RunTests._new_or_modified_tests):
630         (RunTests._run_webkit_tests):
631         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
632         (RunTestsTest.test_webkit_run_unit_tests):
633         * Scripts/webkitpy/tool/steps/steps_unittest.py:
634         (StepsTest._step_options):
635
636 2016-01-07  Joseph Pecoraro  <pecoraro@apple.com>
637
638         prepare-ChangeLog should include radar number
639         https://bugs.webkit.org/show_bug.cgi?id=152839
640         <rdar://problem/24093563>
641
642         Reviewed by Daniel Bates.
643
644         When running `prepare-ChangeLog -b ###`, check for a bugzilla comment that
645         starts with a "<rdar://problem/####>" URL. If found, include that radar URL
646         in the ChangeLog description after the bug URL.
647
648         * Scripts/prepare-ChangeLog:
649         (main): Update signatures.
650         (fetchBugXMLData): XML Data is now used for multiple reasons. Extract this to just get the data.
651         (fetchBugDescriptionFromBugXMLData): Search data for <short_desc>.
652         (fetchRadarURLFromBugXMLData): Search comment text for radar URL.
653         (generateNewChangeLogs): Include radar URL if we found one.
654
655         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl: Added.
656         Tests for the radar URL extraction.
657
658 2016-01-07  Alexey Proskuryakov  <ap@apple.com>
659
660         testRunner.runUIScript crashes while running multiple tests in a row that invokes the same UIScript
661         https://bugs.webkit.org/show_bug.cgi?id=152390
662         <rdar://problem/23948321>
663
664         Reviewed by Simon Fraser.
665
666         Fix two use-after-frees.
667
668         1. WKPageCallAfterNextPresentationUpdate's callback has a pointer to TestInvocation,
669         but we may have already progressed to another test by the time the callback fires,
670         having destroyed the TestInvocation.
671         2. UIScriptController is a RefCounted object, but it has a raw pointer to
672         UIScriptContext which has the same lifetime as a TestInvocation.
673         As a result, completion blocks of UIScriptController actions would use a destroyed
674         TestInvocation.
675
676         * WebKitTestRunner/TestInvocation.cpp:
677         (WTR::TestInvocation::~TestInvocation):
678         (WTR::TestInvocation::url):
679         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
680         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
681         (WTR::TestInvocation::runUISideScript):
682         * WebKitTestRunner/TestInvocation.h:
683         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
684         (UIScriptContext::UIScriptContext):
685         (UIScriptContext::~UIScriptContext):
686         (UIScriptContext::runUIScript):
687         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
688         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
689         (WTR::UIScriptController::UIScriptController):
690         (WTR::UIScriptController::contextDestroyed):
691         (WTR::UIScriptController::makeWindowObject):
692         (WTR::UIScriptController::setWillBeginZoomingCallback):
693         (WTR::UIScriptController::willBeginZoomingCallback):
694         (WTR::UIScriptController::setDidEndZoomingCallback):
695         (WTR::UIScriptController::didEndZoomingCallback):
696         (WTR::UIScriptController::setDidEndScrollingCallback):
697         (WTR::UIScriptController::didEndScrollingCallback):
698         (WTR::UIScriptController::setDidShowKeyboardCallback):
699         (WTR::UIScriptController::didShowKeyboardCallback):
700         (WTR::UIScriptController::setDidHideKeyboardCallback):
701         (WTR::UIScriptController::didHideKeyboardCallback):
702         (WTR::UIScriptController::uiScriptComplete):
703         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
704         (WTR::UIScriptController::create):
705         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
706         (WTR::UIScriptController::doAsyncTask):
707         (WTR::UIScriptController::zoomToScale):
708         (WTR::UIScriptController::singleTapAtPoint):
709         (WTR::UIScriptController::doubleTapAtPoint):
710         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
711         (WTR::UIScriptController::contentVisibleRect):
712         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
713         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
714         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
715         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
716         (WTR::UIScriptController::platformSetDidEndScrollingCallback):
717         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
718         (WTR::UIScriptController::doAsyncTask):
719
720 2016-01-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
721
722         [buildbot] clean-build script should remove untracked files and revert local changes too
723         https://bugs.webkit.org/show_bug.cgi?id=142400
724
725         Reviewed by Ryosuke Niwa.
726
727         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
728         A helper routine SCM.discard_untracked_files is added for that purpose.
729
730         * BuildSlaveSupport/clean-build:
731         (main): Making call to Scripts/clean-webkit
732         * Scripts/clean-webkit: Added.
733         (main): Revert changes and delete untracked files.
734         * Scripts/webkitpy/common/checkout/scm/scm.py:
735         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
736         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
737         (SCMTest._shared_test_discard_untracked_files):
738         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
739
740 2016-01-06  Simon Fraser  <simon.fraser@apple.com>
741
742         Add a setting and preferences to enable display-list drawing. Does nothing yet.
743         https://bugs.webkit.org/show_bug.cgi?id=152807
744
745         Reviewed by Zalan Bujtas.
746         
747         Add an item to the Settings menu to toggle display-list drawing.
748
749         * MiniBrowser/mac/SettingsController.h:
750         * MiniBrowser/mac/SettingsController.m:
751         (-[SettingsController _populateMenu]):
752         (-[SettingsController validateMenuItem:]):
753         (-[SettingsController toggleDisplayListDrawingEnabled:]):
754         (-[SettingsController displayListDrawingEnabled]):
755         * MiniBrowser/mac/WK2BrowserWindowController.m:
756         (-[WK2BrowserWindowController didChangeSettings]):
757
758 2016-01-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
759
760         Python SCM should be able to retrieve untracked files - Add GIT support
761         https://bugs.webkit.org/show_bug.cgi?id=143135
762
763         Reviewed by Michael Catanzaro.
764
765         * Scripts/webkitpy/common/checkout/scm/git.py:
766         (Git.untracked_files): Adding support for git.
767         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
768         (GitTest.setUp):
769         (GitTest.test_untracked_files): Adding test.
770
771 2016-01-05  Mark Lam  <mark.lam@apple.com>
772
773         Rename badly named JSC_timeout env var to JSCTEST_timeout.
774         https://bugs.webkit.org/show_bug.cgi?id=152748
775
776         Reviewed by Geoffrey Garen.
777
778         Now that we validate JSC options, the badly named JSC_timeout env var causes the
779         bots to have a bad time.
780
781         * Scripts/run-javascriptcore-tests:
782         * Scripts/run-jsc-stress-tests:
783
784 2016-01-04  Carlos Garcia Campos  <cgarcia@igalia.com>
785
786         [GTK] Allow to save and restore session
787         https://bugs.webkit.org/show_bug.cgi?id=115600
788
789         Reviewed by Michael Catanzaro.
790
791         Add test case to check the new session API.
792
793         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
794         (testWebKitWebViewSessionState):
795         (testWebKitWebViewSessionStateWithFormData):
796         (beforeAll):
797
798 2016-01-04  Csaba Osztrogonác  <ossy@webkit.org>
799
800         [EFL] Bump EFL version to 1.16.1
801         https://bugs.webkit.org/show_bug.cgi?id=152688
802
803         Reviewed by Gyuyoung Kim.
804
805         * efl/jhbuild.modules:
806
807 2016-01-04  Aakash Jain  <aakash_jain@apple.com>
808
809         error running layout tests on iOS simulator on latest build
810         https://bugs.webkit.org/show_bug.cgi?id=152719
811         <rdar://problem/24009549>
812
813         Reviewed by Alexey Proskuryakov.
814
815         * Scripts/webkitpy/xcode/simulator.py:
816         (Simulator.wait_until_device_is_booted): Ensure that simulator device is in booted state
817           before running simctl spawn command.
818
819 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
820
821         Unreviewed, move Frédéric Wang to committers list
822
823         He seems to be on the contributors list by accident. He has been landing his own commits for
824         about two years now.
825
826         * Scripts/webkitpy/common/config/contributors.json:
827
828 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
829
830         Unreviewed, move Sebastian Dröge to committers list harder
831
832         He accidentally added himself to the reviewers list because the file is confusing. Then I
833         accidentially moved him to the contributors list because the file is confusing, even though
834         I knew the contributors list existed in this file and was attempting to add him to the
835         committers list. Really move him to the committers list now.
836
837         * Scripts/webkitpy/common/config/contributors.json:
838
839 2016-01-02  Youenn Fablet  <youenn.fablet@crf.canon.fr>
840
841         Python SCM should be able to retrieve untracked files - Add SVN support
842         https://bugs.webkit.org/show_bug.cgi?id=152546
843
844         Reviewed by Michael Catanzaro.
845
846         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
847         (test_untracked_files): Activating test for SVN.
848         * Scripts/webkitpy/common/checkout/scm/svn.py:
849         (SVN.untracked_files): Implementing untracked files retrieval for SVN.
850
851 2015-12-31  Andy Estes  <aestes@apple.com>
852
853         Replace WTF::move with WTFMove
854         https://bugs.webkit.org/show_bug.cgi?id=152601
855
856         Reviewed by Brady Eidson.
857
858         * DumpRenderTree/TestRunner.h:
859         (TestRunner::setAllowedHosts):
860         * DumpRenderTree/win/DRTDataObject.cpp:
861         (DRTDataObject::SetData):
862         * TestWebKitAPI/Tests/WTF/Deque.cpp:
863         (TestWebKitAPI::TEST):
864         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
865         (TestWebKitAPI::TEST):
866         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
867         (TestWebKitAPI::TEST):
868         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
869         (TestWebKitAPI::TEST):
870         * TestWebKitAPI/Tests/WTF/Ref.cpp:
871         (TestWebKitAPI::passWithRef):
872         (TestWebKitAPI::TEST):
873         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
874         (TestWebKitAPI::TEST):
875         * TestWebKitAPI/Tests/WTF/Vector.cpp:
876         (TestWebKitAPI::TEST):
877         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
878         (TestWebKitAPI::TEST):
879         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
880         (TestWebKitAPI::TEST):
881         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
882         (TestWebKitAPI::createTestValue):
883         (TestWebKitAPI::TEST):
884         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
885         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
886         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
887         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
888         (TestWebKitAPI::createNFAs):
889         (TestWebKitAPI::TEST_F):
890         * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp:
891         (TestWebKitAPI::combine):
892         * TestWebKitAPI/Tests/WebCore/DFAHelpers.h:
893         (TestWebKitAPI::createNFAs):
894         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm:
895         (TEST):
896         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
897         (WebProcessTest::add):
898
899 2016-01-01  Michael Catanzaro  <mcatanzaro@igalia.com>
900
901         [SOUP] REGRESSION(r192761): Broke resource URIs for applications that use g_resource_load in a web extension
902         https://bugs.webkit.org/show_bug.cgi?id=152634
903
904         Reviewed by Carlos Garcia Campos.
905
906         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
907         (testLoadFromGResource): Added test.
908         (beforeAll):
909         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
910         (registerGResource): Added.
911         (webkit_web_extension_initialize_with_user_data): Load the test gresource.
912         * TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html: Added.
913         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Add an HTML file.
914
915 2015-12-31  David Kilzer  <ddkilzer@apple.com>
916
917         REGRESSION (r194470): Fix warnings uncovered by migrating to WTF_MOVE
918         <https://bugs.webkit.org/show_bug.cgi?id=152601>
919
920         Ignore unknown pragmas on older clangs.  Fixes the following
921         build failure:
922
923             Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp:184:34: error: unknown warning group '-Wself-move', ignored [-Werror,-Wunknown-pragmas]
924             #pragma clang diagnostic ignored "-Wself-move"
925                                              ^
926             1 error generated.
927
928         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
929         (TestWebKitAPI::TEST):
930         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
931         (TestWebKitAPI::TEST):
932
933 2015-12-31  Andy Estes  <aestes@apple.com>
934
935         Update the style checker to advise using WTFMove() instead of WTF::move()
936         https://bugs.webkit.org/show_bug.cgi?id=152601
937
938         Reviewed by Daniel Bates.
939
940         * Scripts/webkitpy/style/checkers/cpp.py:
941         (check_wtf_move):
942         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
943         (WebKitStyleTest.test_wtf_move):
944
945 2015-12-31  Andy Estes  <aestes@apple.com>
946
947         Fix warnings uncovered by migrating to WTF_MOVE
948         https://bugs.webkit.org/show_bug.cgi?id=152601
949
950         Reviewed by Daniel Bates.
951
952         Ignored -Wself-move warnings in these two API tests. It's useful to test that these classes properly handle
953         self-move, even if doing so would trigger a warning.
954
955         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
956         (TestWebKitAPI::TEST):
957         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
958         (TestWebKitAPI::TEST):
959
960 2015-12-31  Martin Robinson  <mrobinson@igalia.com>
961
962         [GTK] The install-dependencies script has a syntax error
963         https://bugs.webkit.org/show_bug.cgi?id=152613
964
965         Reviewed by Michael Catanzaro.
966
967         * gtk/install-dependencies: Add the missing 'then.'
968
969 2015-12-30  Philippe Normand  <pnormand@igalia.com>
970
971         [Mac][GTK] Jhbuild support for OSX
972         https://bugs.webkit.org/show_bug.cgi?id=150799
973
974         Reviewed by Michael Catanzaro.
975
976         * gtk/install-dependencies: Install dependencies on OSX with Homebrew.
977         * gtk/jhbuild.modules: Moved platform-specific build settings in condition tags.
978         * gtk/patches/foxbntconfig-fix-osx-cache.diff: Added.
979         * gtk/jhbuildrc: GTK+ makeargs clean-up, the 3.0.12 hack is no longer needed.
980
981 2015-12-28  Michael Catanzaro  <mcatanzaro@igalia.com>
982
983         Unreviewed, move Sebastian Dröge to committers list
984
985         He accidentally added himself to the reviewers list because the file is confusing.
986
987         * Scripts/webkitpy/common/config/contributors.json:
988
989 2015-12-24  Simon Fraser  <simon.fraser@apple.com>
990
991         Remove the unused #define _USE_MATH_DEFINES
992         https://bugs.webkit.org/show_bug.cgi?id=152034
993
994         Reviewed by Tim Horton.
995         
996         Update this test to use piDouble from MathExtras.h, and
997         std::numeric_limits<>.
998
999         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1000
1001 2015-12-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1002
1003         Python SCM should be able to retrieve untracked files - Generic changes
1004         https://bugs.webkit.org/show_bug.cgi?id=152536
1005
1006         Reviewed by Brent Fulgham.
1007
1008         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
1009         No support is yet added to GIT and SVN specific implementations.
1010
1011         * Scripts/webkitpy/common/checkout/scm/scm.py:
1012         (SCM.untracked_files):
1013         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1014         (SCMTest._shared_test_untracked_files):
1015
1016 2015-12-23  Dewei Zhu  <dewei_zhu@apple.com>
1017
1018         SVN checkout used by RunBenchmark should be non-interactive
1019         https://bugs.webkit.org/show_bug.cgi?id=152542
1020
1021         Reviewed by Ryosuke Niwa.
1022
1023         RunBenchmark should not require user interaction while running.
1024
1025         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
1026         (BenchmarkBuilder._checkout_with_subversion):
1027
1028 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
1029
1030         Web Inspector: add support for running protocol-test.js tests on Windows
1031         https://bugs.webkit.org/show_bug.cgi?id=148037
1032         <rdar://problem/22292237>
1033
1034         Reviewed by Simon Fraser.
1035
1036         * DumpRenderTree/win/TestRunnerWin.cpp:
1037         (TestRunner::inspectorTestStubURL): Provide implementation.
1038
1039 2015-12-23  Eric Carlson  <eric.carlson@apple.com>
1040
1041         [MediaStream] MediaDeviceInfo.label must be empty in some situations
1042         https://bugs.webkit.org/show_bug.cgi?id=152000
1043
1044         Reviewed by Brent Fulgham.
1045
1046         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1047         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1048         (WTR::InjectedBundle::setUserMediaPermission):
1049         (WTR::InjectedBundle::setUserMediaPermissionForOrigin): New.
1050         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1051
1052         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1053         (WTR::TestRunner::setUserMediaPermissionForOrigin): New.
1054         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1055
1056         * WebKitTestRunner/TestController.cpp:
1057         (WTR::TestController::setUserMediaPermissionForOrigin):
1058         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Add NULL check.
1059         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Don't add 
1060           persistent permission for origin, that can be done from script now.
1061         * WebKitTestRunner/TestController.h:
1062
1063         * WebKitTestRunner/TestInvocation.cpp:
1064         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Add support for
1065           SetUserMediaPermissionForOrigin.
1066
1067 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
1068
1069         [Win] Unreviewed build fix: Recognize Windows 10 variants.
1070
1071         * Scripts/webkitpy/common/system/platforminfo.py:
1072         (PlatformInfo._determine_win_version):
1073
1074 2015-12-23  Chris Aljoudi <chris@chrismatic.io> and Alex Christensen <achristensen@webkit.org>
1075
1076         Content blockers should be able to promote http to https
1077         https://bugs.webkit.org/show_bug.cgi?id=148966
1078
1079         Reviewed by Benjamin Poulain.
1080
1081         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1082         (WebCore::ContentExtensions::operator<<):
1083         (TestWebKitAPI::TEST_F):
1084
1085 2015-12-22  Hunseop Jeong  <hs85.jeong@samsung.com>
1086
1087         [EFL] MiniBrowser should be able to choose the offline-web-application-cache option
1088         https://bugs.webkit.org/show_bug.cgi?id=152516
1089
1090         Reviewed by Gyuyoung Kim.
1091
1092         * MiniBrowser/efl/main.c:
1093
1094 2015-12-22  Brent Fulgham  <bfulgham@apple.com>
1095
1096         Unreviewed: Add John Wilander as a contributor.
1097
1098         * Scripts/webkitpy/common/config/contributors.json:
1099
1100 2015-12-22  Chris Fleizach  <cfleizach@apple.com>
1101
1102         [WK2] Looping in testcase: fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
1103         https://bugs.webkit.org/show_bug.cgi?id=152482
1104
1105         Reviewed by Brent Fulgham.
1106
1107         vertical/horizontalScrollbar returns an accessibility element. That element can also be queried
1108         for the same property. On WK2, the element returned will not be valid, but is still present and
1109         that can lead to looping.
1110
1111         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1112         (AccessibilityUIElement::horizontalScrollbar):
1113         (AccessibilityUIElement::verticalScrollbar):
1114         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1115         (WTR::AccessibilityUIElement::horizontalScrollbar):
1116         (WTR::AccessibilityUIElement::verticalScrollbar):
1117
1118 2015-12-22  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1119
1120         Unreviewed.
1121
1122         * Scripts/webkitpy/common/config/contributors.json: Marking myself as reviewer.
1123
1124 2015-12-21  Hunseop Jeong  <hs85.jeong@samsung.com>
1125
1126         [EFL] test_ewk2_context failed after r192808
1127         https://bugs.webkit.org/show_bug.cgi?id=151846
1128
1129         Reviewed by Gyuyoung Kim.
1130
1131         Used the added ewk_context_web_process_count_limit_set api
1132         instead of the deprecated ewk_context_process_model_set.
1133
1134         * MiniBrowser/efl/main.c:
1135         (elm_main):
1136
1137 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
1138
1139         Unreviewed, move myself to reviewer list.
1140
1141         * Scripts/webkitpy/common/config/contributors.json:
1142
1143 2015-12-21  Aakash Jain  <aakash_jain@apple.com>
1144
1145         Unreviewed, add myself to the committers list.
1146
1147         * Scripts/webkitpy/common/config/contributors.json:
1148
1149 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
1150
1151         [GTK] jquery.min.js violates DFSG
1152         https://bugs.webkit.org/show_bug.cgi?id=152428
1153
1154         Reviewed by Joseph Pecoraro.
1155
1156         Stop distributing Source/WebInspectorUI/Tools. It is not needed in tarballs. This brings us
1157         into compliance with DFSG by removing a bundled, minified copy of jQuery from our tarball.
1158
1159         * gtk/manifest.txt.in:
1160
1161 2015-12-19  Dan Bernstein  <mitz@apple.com>
1162
1163         [Mac] WebKit contains dead source code for OS X Mavericks and earlier
1164         https://bugs.webkit.org/show_bug.cgi?id=152462
1165
1166         Reviewed by Alexey Proskuryakov.
1167
1168         - Removed definitions of MACOSX_DEPLOYMENT_TARGET and WEBKIT_SYSTEM_INTERFACE_LIBRARY for
1169           OS X 10.9:
1170
1171         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1172         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1173         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1174         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1175         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1176
1177         - Simplified expressions involving __MAC_OS_X_VERSION_MIN_REQUIRED and removed code that was
1178           never getting compiled:
1179
1180         * DumpRenderTree/mac/TextInputController.m:
1181         * MiniBrowser/mac/BrowserWindowController.m:
1182         * TestWebKitAPI/Tests/mac/AttributedString.mm:
1183         * WebKitTestRunner/mac/EventSenderProxy.mm:
1184
1185 2015-12-18  Michael Catanzaro  <mcatanzaro@igalia.com>
1186
1187         Unreviewed, add WebKitGTK+ Bugzilla email to committers list
1188
1189         This is to make it easy to CC it on Bugzilla.
1190
1191         * Scripts/webkitpy/common/config/contributors.json:
1192
1193 2015-12-18  Aakash Jain  <aakash_jain@apple.com>
1194
1195         Pasteboard get messed up after running kill-old-processes
1196         https://bugs.webkit.org/show_bug.cgi?id=152426
1197
1198         Reviewed by Alexey Proskuryakov.
1199
1200         * BuildSlaveSupport/kill-old-processes:
1201         (main): Do not kill pasteboard anymore.
1202
1203 2015-12-17  Aakash Jain  <aakash_jain@apple.com>
1204
1205         run-webkit-tests shouldn't start multiple iOS simulators while only running one test
1206         https://bugs.webkit.org/show_bug.cgi?id=152157
1207         <rdar://problem/23851817>
1208
1209         Reviewed by Alexey Proskuryakov.
1210
1211         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1212         (LayoutTestRunner.get_worker_count): Calculate required number of workers.
1213         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1214         (Manager._get_test_inputs): Common method to calculate test_inputs.
1215         (Manager._update_worker_count): Calculate and update required number of workers.
1216
1217 2015-12-16  Aakash Jain  <aakash_jain@apple.com>
1218
1219         run-webkit-tests fails to delete Simulator device during cleanup
1220         https://bugs.webkit.org/show_bug.cgi?id=152363
1221
1222         Reviewed by Alexey Proskuryakov.
1223
1224         * Scripts/webkitpy/xcode/simulator.py:
1225         (Simulator.delete_device): Ensure that device is Shutdown before deleting it.
1226
1227 2015-12-16  Tim Horton  <timothy_horton@apple.com>
1228
1229         [mac-wk2] fast/events force click tests crashing
1230         https://bugs.webkit.org/show_bug.cgi?id=152339
1231
1232         Reviewed by Beth Dakin.
1233
1234         * WebKitTestRunner/mac/EventSenderProxy.mm:
1235         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
1236         Set the NSEvent's _type member in addition to overriding -type,
1237         because there are assertions in touch event handling code that depend on it.
1238
1239 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1240
1241         Enforce temporarily bots to sync WebKit and WPT testharness.js
1242         https://bugs.webkit.org/show_bug.cgi?id=152334
1243
1244         Reviewed by Darin Adler.
1245
1246         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1247         (WebPlatformTestServer._copy_webkit_test_files): Temporarily overwrite wpt testharness.js with WebKit testharness.js.
1248
1249 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1250
1251         [Fetch API] Add fetch API compile time flag
1252         https://bugs.webkit.org/show_bug.cgi?id=152254
1253
1254         Reviewed by Darin Adler.
1255
1256         * Scripts/webkitperl/FeatureList.pm:
1257
1258 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1259
1260         Unreviewed.
1261
1262         Added files that have impact in building Streams API to the watchlist.
1263
1264         * Scripts/webkitpy/common/config/watchlist:
1265
1266 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1267
1268         Unreviewed.
1269
1270         Added imported tests to Streams API watchlist.
1271
1272         * Scripts/webkitpy/common/config/watchlist:
1273
1274 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1275
1276         Remove default copy of wpt testharness.js when launching wpt server
1277         https://bugs.webkit.org/show_bug.cgi?id=152298
1278
1279         Reviewed by Darin Adler.
1280
1281         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1282         (WebPlatformTestServer._copy_webkit_test_files): Deleted default copy of WebKit testharness.js to WPT.
1283
1284 2015-12-15  David Kilzer  <ddkilzer@apple.com>
1285
1286         REGRESSION (r192375): DumpRenderTree.app exits immediately with no error
1287         <http://webkit.org/b/152314>
1288
1289         Reviewed by Daniel Bates.
1290
1291         The change to DumpRenderTreeMain.mm in r192375 caused the iOS
1292         code path to exit immediately when calling main().
1293         Unfortunately, DumpRenderTreeMain.mm was used for both
1294         DumpRenderTree command-line binary and DumpRenderTree.app, which
1295         meant that the app would exit immediately with no error code
1296         when run!
1297
1298         The workaround is to introduce a separate source file called
1299         DumpRenderTreeAppMain.mm, similar to what WebKitTestRunner
1300         already does.
1301
1302         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add
1303         DumpRenderTreeAppMain.mm to the project.  Make it the only
1304         compiled source for the DumpRenderTree.app target.
1305         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm: Copied from Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm.
1306         (main): Call DumpRenderTreeMain() on iOS.  Assert on OS X in
1307         case someone tries mistakenly to use the app.
1308         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1309         Link to JavaScriptCore.framework on iOS for the assert.
1310         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1311         Link to JavaScriptCore.framework on OS X for the assert.  Remove
1312         unneeded EXCLUDED_SOURCE_FILE_NAMES setting.
1313         * DumpRenderTree/mac/DumpRenderTreeMain.mm:
1314         (main): Add assert for iOS so that a crash occurs if someone
1315         tries to run the wrong command.
1316
1317 2015-12-14  Tim Horton  <timothy_horton@apple.com>
1318
1319         Frequent crash under -[WKPDFView web_setMinimumSize:]_block_invoke
1320         https://bugs.webkit.org/show_bug.cgi?id=152266
1321         <rdar://problem/22092676>
1322
1323         Reviewed by Simon Fraser.
1324
1325         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1326         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Added.
1327         Add a test that crashed before this change, and doesn't crash after.
1328
1329 2015-12-14  Chris Fleizach  <cfleizach@apple.com>
1330
1331         AX: iOS: Text field variations do not have the correct traits
1332         https://bugs.webkit.org/show_bug.cgi?id=152237
1333
1334         Reviewed by Mario Sanchez Prada.
1335
1336         Add iOS calls for determing if an object is a search field or a text area.
1337
1338         * DumpRenderTree/AccessibilityUIElement.cpp:
1339         (getIsSearchFieldCallback):
1340         (getIsTextAreaCallback):
1341         (stringForSelectionCallback):
1342         (AccessibilityUIElement::getJSClass):
1343         * DumpRenderTree/AccessibilityUIElement.h:
1344         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1345         (AccessibilityUIElement::identifier):
1346         (AccessibilityUIElement::isTextArea):
1347         (AccessibilityUIElement::isSearchField):
1348         (AccessibilityUIElement::traits):
1349         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1350         (WTR::AccessibilityUIElement::scrollPageRight):
1351         (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
1352         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
1353         (WTR::AccessibilityUIElement::isSearchField):
1354         (WTR::AccessibilityUIElement::isTextArea):
1355         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1356         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1357         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1358         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
1359         (WTR::AccessibilityUIElement::isTextArea):
1360         (WTR::AccessibilityUIElement::isSearchField):
1361         (WTR::AccessibilityUIElement::rowCount):
1362
1363 2015-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1364
1365         [GTK] [JHBuild] package libtool-bin is now required on Debian systems.
1366         https://bugs.webkit.org/show_bug.cgi?id=152252
1367
1368         Reviewed by Sergio Villar Senin.
1369
1370         * gtk/install-dependencies: Add libtool-bin to the list of packages required
1371         for building the JHBuild on Debian systems.
1372
1373 2015-12-11  Joseph Pecoraro  <pecoraro@apple.com>
1374
1375         check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
1376         https://bugs.webkit.org/show_bug.cgi?id=152156
1377
1378         Reviewed by Dan Bernstein.
1379
1380         Our frameworks should appropriately prefix all ObjC classes,
1381         not just external symbols.
1382
1383         * Scripts/check-for-inappropriate-objc-class-names:
1384         Remove the -g switch to check all ObjC class names.
1385
1386 2015-12-10  Eric Carlson  <eric.carlson@apple.com>
1387
1388         [MediaStream] Expose media capture devices persistent permissions to WebCore
1389         https://bugs.webkit.org/show_bug.cgi?id=152087
1390
1391         Add support for the new user media permission checker page UI client method.
1392
1393         Reviewed by Chris Dumez.
1394
1395         * WebKitTestRunner/TestController.cpp:
1396         (WTR::decidePolicyForUserMediaPermissionRequest):
1397         (WTR::checkUserMediaPermissionForOrigin):
1398         (WTR::TestController::createOtherPage): Add checkUserMediaPermissionForOrigin.
1399         (WTR::TestController::createWebViewWithOptions): Ditto.
1400         (WTR::TestController::resetStateToConsistentValues): Clear m_userMediaOriginPermissions.
1401         (WTR::originUserVisibleName): New, create a string for the origin.
1402         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Set the WKUserMediaPermissionCheckRef
1403           according to the state of the origin permission map.
1404         (WTR::TestController::handleUserMediaPermissionRequest): Remember both the origin and the
1405           request so we can update the origin permission map in decidePolicyForUserMediaPermissionRequestIfPossible.
1406         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update the
1407           origin permission map.
1408         * WebKitTestRunner/TestController.h:
1409
1410 2015-12-10  Alex Christensen  <achristensen@webkit.org>
1411
1412         REGRESSION (r192796) WKBundlePageResourceLoadClient should be able to setHTTPBody in willSendRequestForFrame
1413         https://bugs.webkit.org/show_bug.cgi?id=152022
1414         rdar://problem/23763584
1415
1416         Reviewed by Darin Adler.
1417
1418         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1419         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1420         (WTR::InjectedBundlePage::willSendRequestForFrame):
1421         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1422         (WTR::TestRunner::setWillSendRequestReturnsNull):
1423         (WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
1424         (WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
1425         (WTR::TestRunner::setWillSendRequestAddsHTTPBody):
1426         (WTR::TestRunner::willSendRequestHTTPBody):
1427         Added setWillSendRequestAddsHTTPBody that uses new SPI for testing.
1428
1429 2015-12-10  Aakash Jain  <aakash_jain@apple.com>
1430
1431         Remove additional simulator checks before running layout-tests
1432         https://bugs.webkit.org/show_bug.cgi?id=152146
1433
1434         Reviewed by Darin Adler.
1435
1436         * Scripts/webkitpy/port/ios.py:
1437         (IOSSimulatorPort.check_sys_deps): Removed additional simulators verifications.
1438         * Scripts/webkitpy/xcode/simulator.py:
1439         (Simulator._boot_and_shutdown_simulator_device): Deleted.
1440         (Simulator.check_simulator_device_and_erase_if_needed): Deleted.
1441
1442 2015-12-09  Aakash Jain  <aakash_jain@apple.com>
1443
1444         Run atleast one simulator even if max process limit is low
1445         https://bugs.webkit.org/show_bug.cgi?id=152081
1446         <rdar://problem/23819694>
1447
1448         Reviewed by Alexey Proskuryakov.
1449
1450 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
1451
1452         [GTK] Crash in WebProcess when loading large content with custom URI schemes
1453         https://bugs.webkit.org/show_bug.cgi?id=144262
1454
1455         Reviewed by Carlos Garcia Campos.
1456
1457         Added new unit test to check the additional scenarios we now
1458         handle for custom URI schemes.
1459
1460         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1461         (generateHTMLContent): New helper function to generate big enough content.
1462         (testWebContextURIScheme): New unit test.
1463
1464 2015-12-09  Ryuan Choi  <ryuan.choi@navercorp.com>
1465
1466         [EFL] Fix unhandled web process message when launching MiniBrowser
1467         https://bugs.webkit.org/show_bug.cgi?id=152048
1468
1469         Reviewed by Gyuyoung Kim.
1470
1471         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
1472         (TestWebKitAPI::TEST):
1473
1474 2015-12-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1475
1476         [GTK] Add API to handle beforeunload events
1477         https://bugs.webkit.org/show_bug.cgi?id=139090
1478
1479         Reviewed by Gustavo Noronha Silva.
1480
1481         * MiniBrowser/gtk/BrowserWindow.c:
1482         (browserWindowConstructed):
1483         (browserWindowDeleteEvent):
1484         (browser_window_class_init):
1485         Handle delete-event to prevent the window from being closed when
1486         the page has beforeunload handlers. Use
1487         webkit_web_view_try_close() when the window is requested to be
1488         closed.
1489         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1490         (testWebViewJavaScriptDialogs):
1491         Add a test case for the WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM
1492         script dialog type.
1493
1494 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
1495
1496         Refactored initialization code in LoadTrackingTest.
1497
1498         Rubber-stamped by Carlos Garcia Campos.
1499
1500         Small refactoring to make sure that the state of a LoadTrackingTest
1501         gets properly reset before loading new web content.
1502
1503         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
1504         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
1505         (LoadTrackingTest::reset): New, refactored code from *load*() and go*()
1506         functions and reset the remaining local variables.
1507         (LoadTrackingTest::loadURI): Call reset();
1508         (LoadTrackingTest::loadHtml): Ditto.
1509         (LoadTrackingTest::loadPlainText): Ditto.
1510         (LoadTrackingTest::loadBytes): Ditto.
1511         (LoadTrackingTest::loadRequest): Ditto.
1512         (LoadTrackingTest::reload): Ditto.
1513         (LoadTrackingTest::goBack): Ditto.
1514         (LoadTrackingTest::goForward): Ditto.
1515
1516 2015-12-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1517
1518         [EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
1519         https://bugs.webkit.org/show_bug.cgi?id=151942
1520
1521         Reviewed by Darin Adler.
1522
1523         * MiniBrowser/efl/main.c:
1524         (window_create): Enable offline web application cache feature on MiniBrowser.
1525         (elm_main):
1526
1527 2015-12-08  Aakash Jain  <aakash_jain@apple.com>
1528
1529         https://bugs.webkit.org/show_bug.cgi?id=151243
1530         <rdar://problem/22955197>
1531
1532         Reviewed by Alexey Proskuryakov.
1533
1534         * LayoutTestRelay/LayoutTestRelay/main.m:
1535         (getTestingSimDevice): Use separate testing device for each worker.
1536         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1537         (Manager.run): Perform cleanup even if setup fails.
1538         * Scripts/webkitpy/port/ios.py:
1539         (IOSSimulatorPort.default_child_processes): Calculate number of simulators to use.
1540         (IOSSimulatorPort.child_processes): Gets the number of simulators from options variable.
1541         (IOSSimulatorPort.setup_test_run): Handle mulitple simulators.
1542         (IOSSimulatorPort._quit_ios_simulator): Same
1543         (IOSSimulatorPort.clean_up_test_run): Same
1544         (IOSSimulatorPort.check_sys_deps): Same
1545         (IOSSimulatorPort.testing_device): Same
1546         (IOSSimulatorPort.reset_preferences): Same
1547         (IOSSimulatorPort.get_simulator_path): Return simulator path.
1548         (IOSSimulatorPort._createSimulatorApp): Create the copy of simulator app.
1549         * Scripts/webkitpy/xcode/simulator.py:
1550         (Device.delete): Delete the simulator device.
1551         (Simulator.delete_device): Same
1552         (Simulator.wait_until_device_is_booted): Wait for device booting.
1553
1554 2015-12-08  Ryuan Choi  <ryuan.choi@navercorp.com>
1555
1556         [EFL] Add API to provide preferences before creating ewk_view
1557         https://bugs.webkit.org/show_bug.cgi?id=151587
1558
1559         Reviewed by Gyuyoung Kim.
1560
1561         * MiniBrowser/efl/main.c:
1562         (on_key_down):
1563         (quit):
1564         (window_create):
1565         Moved settings related code to configuration() not to update settings
1566         whenever ewk_view is created.
1567         (configuration):
1568         (elm_main):
1569
1570 2015-12-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1571
1572         Unreviewed. Fix GTK+ API tests after r193639.
1573
1574         The new jhbuild version needs some more variables ot be present in
1575         the builtin dict, even if they are set to None.
1576
1577         * jhbuild/jhbuildutils.py:
1578         (enter_jhbuild_environment_if_available):
1579
1580 2015-12-07  Gustavo Noronha Silva  <gns@gnome.org>
1581
1582         [GTK] Notify WebCore when notification is clicked
1583         https://bugs.webkit.org/show_bug.cgi?id=151951
1584
1585         Reviewed by Carlos Garcia Campos.
1586
1587         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1588         (testWebViewNotification): test the new API.
1589
1590 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1591
1592         'jhbuild build' should fail immediately when building any module fails
1593         https://bugs.webkit.org/show_bug.cgi?id=145697
1594
1595         Reviewed by Carlos Garcia Campos.
1596
1597         * efl/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
1598         * gtk/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
1599         Everything is placed under lib instead of lib64 now.
1600         * jhbuild/jhbuild-wrapper: Update jhbuild to the latest upstream commit, and pass
1601         --exit-on-error when running 'jhbuild build'.
1602         * jhbuild/jhbuildrc_common.py:
1603         (init): Don't override PKG_CONFIG_PATH, CMAKE_PREFIX_PATH, or CMAKE_LIBRARY_PATH. Modern
1604         jhbuild should be able to handle these for us without breaking things....
1605
1606 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1607
1608         Add support to import w3c tests from a repository with a different root that the main repo dir
1609         https://bugs.webkit.org/show_bug.cgi?id=151751
1610
1611         Reviewed by Ryosuke Niwa and Youenn Fablet.
1612
1613         We should be able to import tests from repositories that are not pure test repositories and where tests are kept
1614         in a different directory than the repository root.
1615
1616         This patch introduces a new parameter tests_directory that we will use as root directory to search for
1617         tests. All paths will be flattened when copying tests to have a less complicated directory structure. This
1618         requires having the copy_path lists including tuples of origin and destination directories.
1619
1620         * Scripts/webkitpy/w3c/test_downloader.py:
1621         (TestDownloader._add_test_suite_paths): Adds the paths as a tuple of origin and destination directory.
1622         (TestDownloader.copy_tests): Uses the origin and destination tuple for the paths to copy when copying files.
1623         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1624         (TestImporterTest.test_tests_directory): Test.
1625
1626 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1627
1628         Mock TestRepositories in W3C importer tests
1629         https://bugs.webkit.org/show_bug.cgi?id=151938
1630
1631         Reviewed by Youenn Fablet.
1632
1633         The test importer tests should use a fake repository instead of using the real one. The reason why this happened
1634         is because the test repository method reading the file was using the filesystem directly instead of taking the
1635         host one. This patch changes that.
1636
1637         * Scripts/webkitpy/w3c/test_downloader.py:
1638         (TestDownloader.load_test_repositories): Take a filesystem and use it. If we get no filesystem, we use the
1639         default one.
1640         (TestDownloader.__init__): When loading the repositories, pass the host filesystem.
1641         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1642         (TestImporterTest.test_harnesslinks_conversion):
1643         (TestImporterTest.test_submodules_generation): Use a fake test repository file.
1644
1645 2015-12-07  David Kilzer  <ddkilzer@apple.com>
1646
1647         TestNetscapePlugIn: Address review comment on 193607
1648         <http://webkit.org/b/151881>
1649
1650         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1651         (testSetStatus): Initializing std::unique_ptr<char[]> with
1652         nullptr is redundant.
1653
1654 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1655
1656         [GTK] Add webkit_uri_request_get_http_method
1657         https://bugs.webkit.org/show_bug.cgi?id=151601
1658
1659         Reviewed by Martin Robinson.
1660
1661         Add test case to check HTTP method of WebKitURIRequest.
1662
1663         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1664         (testURIRequestHTTPMethod):
1665         (serverCallback):
1666         (beforeAll):
1667         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1668         (sendRequestCallback):
1669
1670 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1671
1672         [GTK] Add WebKitWebPage::console-message-sent signal to Web Extensions API
1673         https://bugs.webkit.org/show_bug.cgi?id=79918
1674
1675         Reviewed by Gustavo Noronha Silva.
1676
1677         Add unit tests to check the different console messages.
1678
1679         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1680         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp: Added.
1681         (ConsoleMessageTest::ConsoleMessage::operator==):
1682         (ConsoleMessageTest::consoleMessageReceivedCallback):
1683         (ConsoleMessageTest::ConsoleMessageTest):
1684         (ConsoleMessageTest::~ConsoleMessageTest):
1685         (ConsoleMessageTest::waitUntilConsoleMessageReceived):
1686         (testWebKitConsoleMessageConsoleAPI):
1687         (testWebKitConsoleMessageJavaScriptException):
1688         (testWebKitConsoleMessageNetworkError):
1689         (testWebKitConsoleMessageSecurityError):
1690         (beforeAll):
1691         (afterAll):
1692         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1693         (consoleMessageSentCallback):
1694         (pageCreatedCallback):
1695
1696 2015-12-07  Ryuan Choi  <ryuan.choi@navercorp.com>
1697
1698         [EFL] MiniBrowser doesn't exit when called ewk_view_try_close()
1699         https://bugs.webkit.org/show_bug.cgi?id=151934
1700
1701         Reviewed by Csaba Osztrogonác.
1702
1703         * MiniBrowser/efl/main.c:
1704         (on_window_deletion): Revert the changes of r192767.
1705
1706 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1707
1708         [GTK] update-webkitgtk-libs cannot build mesa
1709         https://bugs.webkit.org/show_bug.cgi?id=151535
1710
1711         Reviewed by Martin Robinson.
1712
1713         Upgrade to newer mesa in order to build successfully against LLVM 3.7. Add missing
1714         dependency of mesa on LLVM, to ensure LLVM is built first. Build LLVM unconditionally, even
1715         on architectures where FTL is not supported, to ensure mesa is always buildable, since LLVM
1716         does not have a stable API and we cannot expect mesa to be buildable unless we control the
1717         LLVM version. Build mesa with --disable-egl since --enable-egl conflicts with
1718         --enable-xlib-glx. This fixes update-webkitgtk-libs on distros with LLVM 3.7.
1719
1720         * gtk/jhbuild.modules:
1721
1722 2015-12-07  Philippe Normand  <pnormand@igalia.com>
1723
1724         [GTK][Mac] libWebExtensionTest link error
1725         https://bugs.webkit.org/show_bug.cgi?id=150802
1726
1727         Reviewed by Carlos Garcia Campos.
1728
1729         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: add dependencies to the webextension library.
1730
1731 2015-12-06  David Kilzer  <ddkilzer@apple.com>
1732
1733         TestNetscapePlugIn: Fix leaks found by static analyzer
1734         <http://webkit.org/b/151881>
1735
1736         Reviewed by Darin Adler.
1737
1738         Fixes the following leaks found by the static analyzer:
1739             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'path'
1740                     return false;
1741                            ^~~~~
1742             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'target'
1743                     return false;
1744                            ^~~~~
1745             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'url'
1746                     return false;
1747                            ^~~~~
1748
1749         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1750         (toCString): Switch to returning std::unique_ptr<char[]>.  Add
1751         early return if allocation fails.
1752         (testPostURLFile): Switch to using std::unique_ptr<char[]>.
1753         Make sure to call fclose() on filehandle, even for an early
1754         return.
1755         (testSetStatus): Switch to using std::unique_ptr<char[]>.
1756
1757 2015-12-05  David Kilzer  <ddkilzer@apple.com>
1758
1759         prepare-ChangeLog: Fix some warning messages when using svn
1760         <http://webkit.org/b/151914>
1761
1762         Reviewed by Daniel Bates.
1763
1764         * Scripts/prepare-ChangeLog:
1765         (generateFunctionLists): Simplify logic so that we never call
1766         normalizePath() with an undefined value.
1767         (attributeCommand): Quote $subPath for the shell so that we
1768         don't try to run "svn propget" on invalid paths.
1769
1770 2015-12-04  David Kilzer  <ddkilzer@apple.com>
1771
1772         TestNetscapePlugIn: Fix remaining static analyzer warnings
1773         <http://webkit.org/b/151888>
1774
1775         Reviewed by Alexey Proskuryakov.
1776
1777         Fixes the following static analyzer warnings:
1778             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:101:9: warning: Called function pointer is null (null dereference)
1779                     CRASH();
1780                     ^~~~~~~
1781             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:46:5: note: expanded from macro 'CRASH'
1782                 ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ \
1783                 ^~~~~~~~~~~~~~~~
1784             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:375:12: warning: Access to field 'pluginTest' results in a dereference of a null pointer (loaded from variable 'obj')
1785                 return obj->pluginTest->NPP_SetWindow(window);
1786                        ^~~~~~~~~~~~~~~
1787             2 warnings generated.
1788
1789         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1790         (CRASH): Use __builtin_trap() for gcc/clang.
1791         (NPP_SetWindow): Add early return if obj is nullptr.
1792
1793 2015-12-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1794
1795         [GTK] Test /webkit2/WebKitWebResource/get-data is flaky
1796         https://bugs.webkit.org/show_bug.cgi?id=151797
1797
1798         Reviewed by Martin Robinson.
1799
1800         Since we switched to use the network process to run the unit tests
1801         the test /webkit2/WebKitWebResource/get-data sometimes fails and
1802         sometimes passes. We are now also getting the notification for the
1803         css image. Since we wait for 3 resources, sometimes the css image
1804         is loaded before and then checkResourceData is called for it, but
1805         not handled. When the css image is the last one loaded the test
1806         passes. So, we just need to wait for the 4 resources.
1807
1808         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1809         (testWebResourceGetData):
1810
1811 2015-12-03  David Kilzer  <ddkilzer@apple.com>
1812
1813         DumpRenderTree: Use-after-free in createBitmapContext() in PixelDumpSupportMac.mm
1814         <http://webkit.org/b/151845>
1815
1816         Reviewed by Simon Fraser.
1817
1818         Fixes the following static analyzer warning:
1819             DumpRenderTree/mac/PixelDumpSupportMac.mm:67:9: warning: Use of memory after it is freed
1820                     WTFLogAlways("DumpRenderTree: CGBitmapContextCreate(%p, %llu, %llu, 8, %llu, %p, 0x%x) failed\n", buffer, pixelsHigh, pixelsWide, rowBytes, colorSpace.get(), kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host);
1821                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1822
1823         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1824         (createBitmapContext): Free 'buffer' after using it in logging
1825         to fix the use-after-free.  Assign a value of nullptr to buffer
1826         so we don't return with it set to a freed address.
1827
1828 2015-12-03  Jer Noble  <jer.noble@apple.com>
1829
1830         Expose WebCore's InvisibleAutoplayNotPermitted setting to WebKit & WebKit2
1831         https://bugs.webkit.org/show_bug.cgi?id=151830
1832
1833         Reviewed by Anders Carlsson.
1834
1835         Set invisibleAutoplayNotPermitted to NO by default both in WKTR and DRT.
1836
1837         * DumpRenderTree/mac/DumpRenderTree.mm:
1838         (resetWebPreferencesToConsistentValues):
1839         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1840         (WTR::initializeWebViewConfiguration):
1841
1842 2015-12-03  Anders Carlsson  <andersca@apple.com>
1843
1844         Remove Objective-C GC support
1845         https://bugs.webkit.org/show_bug.cgi?id=151819
1846         rdar://problem/23746991
1847
1848         Reviewed by Dan Bernstein.
1849
1850         * asan/asan.xcconfig:
1851
1852 2015-12-02  Yusuke Suzuki  <utatane.tea@gmail.com>
1853
1854         Allow nil for unspecified benchmark pathes
1855         https://bugs.webkit.org/show_bug.cgi?id=151784
1856
1857         Reviewed by Filip Pizlo.
1858
1859         `Pathname.new(nil)` will raise an error.
1860         Only generate Pathname if the benchmark path is specified.
1861
1862         * Scripts/run-jsc-benchmarks:
1863
1864 2015-12-02  Brent Fulgham  <bfulgham@apple.com>
1865
1866         [Win] Run non-http tests without Cygwin
1867         https://bugs.webkit.org/show_bug.cgi?id=151721
1868
1869         Reviewed by Andy Estes.
1870
1871         Support native 32-bit and 64-bit Python (and Perl) builds
1872         for running tests:
1873
1874         1. Use "startswith('win')", rather than "== 'win32'" to support
1875         various Windows build types.
1876         2. Supply full path for some native Windows utilities, since the
1877         path environment does not always have the specified, and they are
1878         guaranteed to exist in those specific locations.
1879         3. Make sure native Windows Python test runs pass proper environment
1880         variables to run programs.
1881         4. Append 'exe' suffix when running Windows executables.
1882         5. Use the _winreg Python module on Windows, since the Cygwin 'regtool'
1883         command doesn't exist.
1884         
1885         * Scripts/update-webkit: Use Perl $^X command to refer to the path of
1886         the current Perl executable, rather than requiring a new path search.
1887         * Scripts/webkitpy/common/find_files_unittest.py:
1888         (TestWinNormalize.test_win): Use startswith('win').
1889         * Scripts/webkitpy/common/prettypatch_unittest.py:
1890         (test_pretty_diff_encodings): Ditto.
1891         * Scripts/webkitpy/common/system/executive.py:
1892         (Executive._should_close_fds): Ditto.
1893         (Executive.shell_command_for_script): Use startswith('win').
1894         (Executive.kill_process): Use full path to killall executable.
1895         (Executive.check_running_pid): Use startswith('win').
1896         (Executive.running_pids): Ditto.
1897         (Executive.kill_all): Ditto. Also use path to 'killall' executable when
1898         running under native Windows Python.
1899         (Executive._child_process_encoding): Use startswith('win').
1900         (Executive._should_encode_child_process_arguments): Ditto.
1901         (Executive.popen): Recognize proper script engine on Windows, since it
1902         does not support the shebang syntax.
1903         (Executive.run_in_parallel): Use startswith('win').
1904         * Scripts/webkitpy/common/system/executive_unittest.py:
1905         (never_ending_command): Ditto.
1906         (ExecutiveTest.test_run_command_with_unicode): Ditto.
1907         (ExecutiveTest.serial_test_kill_process): Ditto.
1908         (ExecutiveTest.serial_test_kill_all): Ditto.
1909         (ExecutiveTest.serial_test_check_running_pid): Ditto.
1910         (ExecutiveTest.serial_test_run_in_parallel): Ditto.
1911         (main): Ditto.
1912         * Scripts/webkitpy/common/system/file_lock.py:
1913         (FileLock._create_lock): Ditto.
1914         (FileLock._remove_lock): Ditto.
1915         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1916         (RealFileSystemTest.test_chdir): Ditto.
1917         (RealFileSystemTest.test_chdir__notexists): Ditto.
1918         (RealFileSystemTest.test_maybe_make_directory__failure): Ditto.
1919         * Scripts/webkitpy/common/system/path_unittest.py:
1920         (AbspathTest.test_abspath_to_uri_win): Ditto.
1921         * Scripts/webkitpy/common/system/platforminfo.py:
1922         (PlatformInfo._determine_os_name): Ditto.
1923         * Scripts/webkitpy/common/system/user.py: Ditto.
1924         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1925         (ManagerTest.integration_test_needs_servers): Ditto.
1926         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1927         (LayoutTestApacheHttpd.__init__): Handle upper and lower-case
1928         driver letters.
1929         (LayoutTestApacheHttpd._get_apache_config_file_path): Ditto.
1930         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
1931         (TestLayoutTestApacheHttpd.test_start_cmd): Ditto.
1932         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1933         (HttpServerBase._check_that_all_ports_are_available): Ditto.
1934         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1935         (TestHttpServer.test_start_cmd): Ditto.
1936         * Scripts/webkitpy/port/base.py:
1937         (Port.to.setup_environ_for_server): Include 'COMSPEC', 'SYSTEMDRIVE',
1938         and 'SYSTEMROOT' in environment passed to test runners.
1939         (Port._apache_config_file_name_for_platform): Use startswith('win').
1940         (Port._build_path): Ditto.
1941         (Port._path_to_driver): Include 'exe' suffix when running under native
1942         Windows.
1943         * Scripts/webkitpy/port/driver.py:
1944         (Driver._setup_environ_for_driver): Explicitly make some environment
1945         variables strings.
1946         * Scripts/webkitpy/port/server_process.py:
1947         (ServerProcess.__init__): Use startswith('win').
1948         * Scripts/webkitpy/port/win.py:
1949         (WinPort): Use the win32 registry utilities on Windows, and appropriate
1950         registry key formats.
1951         (WinPort._ntsd_location): Revise tool search paths for Windows 10.
1952         (WinPort.read_registry_value): Revise to use _winreg library on Windows,
1953         and regtool on Cygwin.
1954         (WinPort.write_registry_value): Ditto.
1955         (WinPort.setup_crash_log_saving): Ditto.
1956         (WinPort.restore_crash_log_saving): Ditto.
1957         (WinPort.prevent_error_dialogs): Ditto.
1958         (WinPort.allow_error_dialogs): Ditto.
1959         (WinPort.find_system_pid): Revise to use Windows management
1960         infrastructure on native Windows, continue using 'ps' on Cygwin.
1961         (WinPort.read_registry_string): Deleted.
1962         (WinPort.write_registry_string): Deleted.
1963         * Scripts/webkitpy/test/main.py:
1964         (main): Use startswith('win').
1965         (Tester._parse_args): Ditto.
1966
1967 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
1968
1969         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
1970         https://bugs.webkit.org/show_bug.cgi?id=150792
1971
1972         Reviewed by Saam Barati.
1973
1974         * Scripts/webkitperl/FeatureList.pm:
1975
1976 2015-12-01  Commit Queue  <commit-queue@webkit.org>
1977
1978         Unreviewed, rolling out r192914.
1979         https://bugs.webkit.org/show_bug.cgi?id=151734
1980
1981         JSC tests for this change are failing on 32 and 64-bit bots
1982         (Requested by ryanhaddad on #webkit).
1983
1984         Reverted changeset:
1985
1986         "[ES6] Implement LLInt/Baseline Support for ES6 Generators and
1987         enable this feature"
1988         https://bugs.webkit.org/show_bug.cgi?id=150792
1989         http://trac.webkit.org/changeset/192914
1990
1991 2015-12-01  David Kilzer  <ddkilzer@apple.com>
1992
1993         EventSenderProxy::swipeGestureWithWheelAndMomentumPhases() leaks an EventSenderSyntheticEvent
1994         <http://webkit.org/b/151726>
1995
1996         Reviewed by Simon Fraser.
1997
1998         * WebKitTestRunner/mac/EventSenderProxy.mm:
1999         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
2000         Deploy RetainPtr<EventSenderSyntheticEvent> to fix leak.
2001
2002 2015-12-01  Myles C. Maxfield  <mmaxfield@apple.com>
2003
2004         Give String and AtomicString an existingHash() function
2005         https://bugs.webkit.org/show_bug.cgi?id=151717
2006
2007         Reviewed by Andreas Kling.
2008
2009         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
2010         (TestWebKitAPI::TEST):
2011         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2012         (TestWebKitAPI::TEST):
2013
2014 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
2015
2016         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
2017         https://bugs.webkit.org/show_bug.cgi?id=150792
2018
2019         Reviewed by Saam Barati.
2020
2021         * Scripts/webkitperl/FeatureList.pm:
2022
2023 2015-12-01  Sam Weinig  <sam@webkit.org>
2024
2025         Need completionHandler-based WebKit C SPI for alert, confirm, and prompt
2026         <rdar://problem/23320863>
2027         https://bugs.webkit.org/show_bug.cgi?id=151708
2028
2029         Reviewed by Anders Carlsson.
2030
2031         * WebKitTestRunner/TestController.cpp:
2032         (WTR::TestController::createOtherPage):
2033         (WTR::TestController::createWebViewWithOptions):
2034         Update for new WKPageUIClient.
2035
2036 2015-12-01  Anders Carlsson  <andersca@apple.com>
2037
2038         Remove WebKit2.framework
2039         https://bugs.webkit.org/show_bug.cgi?id=151715
2040
2041         Reviewed by Dan Bernstein.
2042
2043         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
2044         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
2045         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
2046         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2047         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
2048         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
2049         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
2050
2051 2015-12-01  Joseph Pecoraro  <pecoraro@apple.com>
2052
2053         Unreviewed common typo fix "occurance" => "occurrence".
2054
2055         * Scripts/webkitpy/tool/commands/queries.py:
2056         (FindFlakyTests._print_statistics):
2057
2058 2015-11-30  Alex Christensen  <achristensen@webkit.org>
2059
2060         Make ProcessModel always MultipleSecondaryProcesses
2061         https://bugs.webkit.org/show_bug.cgi?id=151662
2062
2063         Reviewed by Antti Koivisto.
2064
2065         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2066         (TestWebKitAPI::TEST):
2067         * WebKitTestRunner/TestController.cpp:
2068         (WTR::TestController::generatePageConfiguration):
2069
2070 2015-11-30  Alex Christensen  <achristensen@webkit.org>
2071
2072         Make usesNetworkProcess always true
2073         https://bugs.webkit.org/show_bug.cgi?id=151580
2074
2075         Reviewed by Darin Adler.
2076
2077         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2078         (TestWebKitAPI::TEST):
2079         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
2080         (TestWebKitAPI::TEST):
2081         * WebKitTestRunner/TestController.cpp:
2082         (WTR::TestController::generatePageConfiguration):
2083
2084 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2085
2086         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/editable/editable in Debug.
2087
2088         Add a way to skip unit tests only for Debug or Release builds and
2089         skipt the test /webkit2/WebKitWebView/editable/editable only for Debug.
2090
2091         * Scripts/run-gtk-tests:
2092         (SkippedTest):
2093         (SkippedTest.__init__):
2094         (SkippedTest.__str__):
2095         (SkippedTest.skip_entire_suite):
2096         (SkippedTest.skip_for_build_type):
2097         (TestRunner):
2098         (TestRunner.__init__):
2099
2100 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2101
2102         Unreviewed. Fix a crash in GTK+ test /webkit2/WebKitWebView/custom-charset.
2103
2104         It's an assert hit because we are reloading a view loaded with
2105         HTML data which is not supported. Use loadURI instead.
2106
2107         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2108         (testWebViewCustomCharset):
2109
2110 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2111
2112         [GLIB] Remove GMainLoopSource and GThreadSafeMainLoopSource
2113         https://bugs.webkit.org/show_bug.cgi?id=151633
2114
2115         Reviewed by Csaba Osztrogonác.
2116
2117         * TestWebKitAPI/PlatformGTK.cmake:
2118         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Removed.
2119
2120 2015-11-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2121
2122         [GTK] Remove the remaining uses of GMainLoopSource
2123         https://bugs.webkit.org/show_bug.cgi?id=151632
2124
2125         Reviewed by Žan Doberšek.
2126
2127         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2128         (testWebViewSyncRequestOnMaxConns):
2129         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2130         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2131         (WTR::TestRunner::TestRunner):
2132         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2133         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2134         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
2135         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2136         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2137         (WTR::timeoutSource):
2138         (WTR::TestController::notifyDone):
2139         (WTR::TestController::platformRunUntil):
2140
2141 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
2142
2143         [cmake] Add testb3 to the build system
2144         https://bugs.webkit.org/show_bug.cgi?id=151619
2145
2146         Reviewed by Gyuyoung Kim.
2147
2148         * Scripts/build-jsc:
2149
2150 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
2151
2152         [jhbuild] Fix pixman build with clang
2153         https://bugs.webkit.org/show_bug.cgi?id=151441
2154
2155         Reviewed by Carlos Garcia Campos.
2156
2157         * efl/jhbuild.modules:
2158         * gtk/jhbuild.modules:
2159
2160 2015-11-26  David Kilzer  <ddkilzer@apple.com>
2161
2162         Extract prependToEnvironmentVariableList
2163         <http://webkit.org/b/151536>
2164
2165         Reviewed by Daniel Bates.
2166
2167         Tests: webkitdirs_unittest/appendToEnvironmentVariableList.pl
2168                webkitdirs_unittest/prependToEnvironmentVariableList.pl
2169
2170         * Scripts/webkitdirs.pm: Export appendToEnvironmentVariableList
2171         and prependToEnvironmentVariableList.
2172         (appendToEnvironmentVariableList): Simplify variable name.
2173         Switch to use $Config{path_sep}.
2174         (prependToEnvironmentVariableList): Add new method.
2175         (setupMacWebKitEnvironment): Switch to use
2176         prependToEnvironmentVariableList().
2177         (setupIOSWebKitEnvironment): Ditto.
2178
2179         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl: Added.
2180         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl: Added.
2181
2182 2015-11-24  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2183
2184         REGRESSION(r192053): MiniBrowser doesn't exit when clicking on the close-window button
2185         https://bugs.webkit.org/show_bug.cgi?id=151567
2186
2187         Reviewed by Darin Adler.
2188
2189         * MiniBrowser/efl/main.c: Call window_close() instead of ewk_view_try_close().
2190         (on_window_deletion):
2191
2192 2015-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2193
2194         [GTK] Use the network process unconditionally
2195         https://bugs.webkit.org/show_bug.cgi?id=151541
2196
2197         Reviewed by Alex Christensen.
2198
2199         Fix TestInspectorServer test. Do not assume we already have the
2200         title we want when the page has been loaded, since the title is
2201         changed afterwards. So, check if the title has already been set,
2202         and if not wait for it.
2203
2204         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
2205         (openRemoteDebuggingSession):
2206
2207 2015-11-23  Alex Christensen  <achristensen@webkit.org>
2208
2209         Fix crash in ~WebProcessPool when using Geolocation with useNetworkProcess=true
2210         https://bugs.webkit.org/show_bug.cgi?id=151532
2211
2212         Reviewed by Benjamin Poulain.
2213
2214         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2215         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
2216         (TestWebKitAPI::TEST):
2217         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
2218         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker): Deleted.
2219         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker): Deleted.
2220         Properly load about:blank in all WebViews to clean up.  Without this change, we had a 
2221         Geolocation provider stopping after its state tracker was destroyed with its stack frame,
2222         so it was calling a function on a test object that had gone out of scope.
2223         Also, call WKContextSetUsesNetworkProcess(context, true) to show what crash this fixed,
2224         but that will become the default soon and that call will be removed.
2225
2226 2015-11-22  David Kilzer  <ddkilzer@apple.com>
2227
2228         run-webkit-tests: http server for imported W3C tests doesn't work with --layout-tests-directory switch
2229         <http://webkit.org/b/151542>
2230
2231         Reviewed by Daniel Bates.
2232
2233         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2234         (base_url): Use the Port object (already passed in) to give us
2235         the path to the LayoutTests directory, which already checks for a
2236         --layout-tests-directory command-line switch.
2237         (WebPlatformTestServer.__init__): Remove layout_test_results_dir
2238         argument since we can get this from the Port object already
2239         passed in via Port.results_directory().  Also switch to use
2240         Port.layout_tests_dir() to get the LayoutTests directory.
2241
2242         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
2243         (TestWebPlatformTestServer.test_custom_layout_tests_directory):
2244         Add test case for custom LayoutTests directory.
2245         (TestWebPlatformTestServer.test_previously_spawned_instance):
2246         Update Port object to set mock results directory as if it was
2247         set on the command-line.  Remove unneeded argument from
2248         WebPlatformTestServer constructor.
2249         (TestWebPlatformTestServer.test_corrupted_subserver_files): Ditto.
2250
2251         * Scripts/webkitpy/port/base.py:
2252         (Port.to.start_web_platform_test_server): Remove unneeded
2253         argument from WebPlatformTestServer constuctor.
2254
2255 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2256
2257         [GTK] Some unit tests fail when using the network process
2258         https://bugs.webkit.org/show_bug.cgi?id=151490
2259
2260         Reviewed by Martin Robinson.
2261
2262         Run the soup server in a separate thread in TestResources test to
2263         avoid deadlocks.
2264
2265         This fixes /webkit2/WebKitWebView/sync-request-on-max-conns and
2266         /webkit2/WebKitWebResource/get-data when using the network process.
2267
2268         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2269         (beforeAll): Create the WebKitTestServer with ServerRunInThread flag.
2270         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
2271         (WebKitTestServer::WebKitTestServer): When ServerRunInThread is
2272         present, create a WorkQueue to run the server.
2273         (WebKitTestServer::run): Run the server in the work queue if it
2274         has been created.
2275         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h: Convert server
2276         type into server options as flags.
2277
2278 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2279
2280         [GTK] ImageDiff should normalize the diff image
2281         https://bugs.webkit.org/show_bug.cgi?id=151261
2282
2283         Reviewed by Sergio Villar Senin.
2284
2285         * ImageDiff/gtk/ImageDiff.cpp:
2286         (readPixbufFromStdin): Fix memory leak.
2287         (differenceImageFromDifferenceBuffer): Normalize diff buffer.
2288         (calculateDifference): Pass max distance to differenceImageFromDifferenceBuffer.
2289
2290 == Rolled over to ChangeLog-2015-11-21 ==