Tools/ChangeLog

   1 2015-11-04  Alexey Proskuryakov  <ap@apple.com>
   2
   3         iOS test results are not visible on the flakiness dashboard
   4         https://bugs.webkit.org/show_bug.cgi?id=150884
   5
   6         Reviewed by Darin Adler.
   7
   8         Re-generated builders.jsonp using generate_builders_json.py.
   9
  10         I think that this is all that's needed for basic support. There is more work needed
  11         to display test expectations, but that's already mostly broken even for Mac.
  12
  13         * TestResultServer/static-dashboards/builders.jsonp:
  14
  15 2015-11-03  Commit Queue  <commit-queue@webkit.org>
  16
  17         Unreviewed, rolling out r191995.
  18         https://bugs.webkit.org/show_bug.cgi?id=150880
  19
  20         Broke iOS tests (Requested by ap on #webkit).
  21
  22         Reverted changeset:
  23
  24         "run-webkit-test should look in --root directory for
  25         LayoutTestRelay"
  26         https://bugs.webkit.org/show_bug.cgi?id=150859
  27         http://trac.webkit.org/changeset/191995
  28
  29 2015-11-03  Said Abou-Hallawa  <sabouhallawa@apple.com>
  30
  31         Add graphics benchmark to performance bot
  32         https://bugs.webkit.org/show_bug.cgi?id=150450
  33
  34         Reviewed by Chris Dumez.
  35
  36         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Added.
  37         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Added.
  38         Add a patch and a plan to set the defaults of the benchmark, run it,
  39         collect the result and report it to the benchmark runner.
  40
  41 2015-11-03  Jason Marcell  <jmarcell@apple.com>
  42
  43         run-webkit-test should look in --root directory for LayoutTestRelay
  44         https://bugs.webkit.org/show_bug.cgi?id=150859
  45
  46         Reviewed by Daniel Bates.
  47
  48         For iOS run-webkit-tests, use LayoutTestRelay specified by --root; otherwise find
  49         LayoutTestRelay in the Mac build directory when --root is unspecified.
  50
  51         * Scripts/webkitpy/port/ios.py:
  52         (IOSSimulatorPort.relay_path):
  53
  54 2015-11-03  Alexey Proskuryakov  <ap@apple.com>
  55
  56         build.webkit.org/dashboard should use ISO dates in Trac URLs
  57         https://bugs.webkit.org/show_bug.cgi?id=150855
  58
  59         Reviewed by Darin Adler.
  60
  61         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
  62         (Trac.prototype._xmlTimelineURL):
  63
  64 2015-11-03  Said Abou-Hallawa  <sabouhallawa@apple.com>
  65
  66         Unreviewed, add myself to the SVG watchlist.
  67
  68         * Scripts/webkitpy/common/config/watchlist:
  69
  70 2015-11-03  Wenson Hsieh  <wenson_hsieh@apple.com>
  71
  72         Fix touch event sending crash in WebKitTestRunner
  73         https://bugs.webkit.org/show_bug.cgi?id=150848
  74         <rdar://problem/23360841>
  75
  76         Reviewed by Simon Fraser.
  77
  78         Fixes a redundant force event generated by HIDEventGenerator. See the Radar diagnosis for more details.
  79
  80         * WebKitTestRunner/ios/HIDEventGenerator.mm:
  81         (-[HIDEventGenerator _createIOHIDEventType:]): Deleted.
  82
  83 2015-11-03  Brent Fulgham  <bfulgham@apple.com>
  84
  85         [Win] Unreviewed build fix after r191958.
  86
  87         * MiniBrowser/win/MiniBrowser.h: Add missing include.
  88         * MiniBrowser/win/MiniBrowserWebHost.h: Ditto.
  89
  90 2015-11-02  Jiewen Tan  <jiewen_tan@apple.com>
  91
  92         Add Jiewen Tan (jiewen_tan@apple.com) to committer list.
  93
  94         * Scripts/webkitpy/common/config/contributors.json:
  95
  96 2015-11-03  Csaba Osztrogonác  <ossy@webkit.org>
  97
  98         Unreviewed, add unittest after r191827.
  99
 100         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
 101
 102 2015-11-02  Andy Estes  <aestes@apple.com>
 103
 104         [Cocoa] Add tvOS and watchOS to SUPPORTED_PLATFORMS
 105         https://bugs.webkit.org/show_bug.cgi?id=150819
 106
 107         Reviewed by Dan Bernstein.
 108
 109         This tells Xcode to include these platforms in its Devices dropdown, making it possible to build in the IDE.
 110
 111         * DumpRenderTree/mac/Configurations/Base.xcconfig:
 112         * MiniBrowser/Configurations/Base.xcconfig:
 113         * TestWebKitAPI/Configurations/Base.xcconfig:
 114         * WebKitTestRunner/Configurations/Base.xcconfig:
 115
 116 2015-11-02  Anders Carlsson  <andersca@apple.com>
 117
 118         Begin work on supporting reply blocks in _WKRemoteObjectRegistry
 119         https://bugs.webkit.org/show_bug.cgi?id=150739
 120
 121         Reviewed by Tim Horton.
 122
 123         Add a test. We only test the encoding right now.
 124
 125         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
 126         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
 127         (TEST):
 128         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
 129         (-[RemoteObjectRegistryPlugIn sayHello:completionHandler:]):
 130
 131 2015-11-02  Tim Horton  <timothy_horton@apple.com>
 132
 133         Get rid of WKWebView's inner WKView (WKView being inside WKWebView leads to weird API issues)
 134         https://bugs.webkit.org/show_bug.cgi?id=150174
 135
 136         Reviewed by Anders Carlsson.
 137
 138         * WebKitTestRunner/mac/EventSenderProxy.mm:
 139         (WTR::EventSenderProxy::mouseUp):
 140         (WTR::EventSenderProxy::mouseMoveTo):
 141         Revert some parts of r188828 which no longer apply.
 142
 143 2015-10-30  Dana Burkart  <dburkart@apple.com>
 144
 145         svn-apply should handle unified diffs
 146         https://bugs.webkit.org/show_bug.cgi?id=150650
 147
 148         Reviewed by Darin Adler.
 149
 150         * Scripts/VCSUtils.pm:
 151         (parseUnifiedDiffHeader):
 152         This method parses a unified diff header, and returns a information in the
 153         style of parseGitDiffHeader and parseSvnDiffHeader.
 154
 155         (parseDiffHeader):
 156         Teach parseDiffHeader to recognize unified diff headers.
 157
 158         (parseDiff):
 159         Teach parseDiff to recognize unified diffs.
 160
 161         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
 162         * Scripts/webkitperl/VCSUtils_unittest/parseUnifiedDiffHeader.pl: Added.
 163
 164 2015-11-02  Csaba Osztrogonác  <ossy@webkit.org>
 165
 166         Fix the FTL JIT build with system LLVM on Linux
 167         https://bugs.webkit.org/show_bug.cgi?id=150795
 168
 169         Reviewed by Filip Pizlo.
 170
 171         * efl/install-dependencies:
 172         * gtk/install-dependencies:
 173
 174 2015-11-02  Csaba Osztrogonác  <ossy@webkit.org>
 175
 176         [EFL] Bump harfbuzz versions to 0.9.35
 177         https://bugs.webkit.org/show_bug.cgi?id=150448
 178
 179         Reviewed by Gyuyoung Kim.
 180
 181         * efl/jhbuild.modules:
 182
 183 2015-11-02  Csaba Osztrogonác  <ossy@webkit.org>
 184
 185         [EFL] gnutls-3.3.0 jhbuild module build fails on Ubuntu 15.10
 186         https://bugs.webkit.org/show_bug.cgi?id=150622
 187
 188         Reviewed by Gyuyoung Kim.
 189
 190         * efl/install-dependencies:
 191         * efl/jhbuild.modules:
 192
 193 2015-11-02  Csaba Osztrogonác  <ossy@webkit.org>
 194
 195         Fix EFL jhbuild module build on Ubuntu 15.10
 196         https://bugs.webkit.org/show_bug.cgi?id=150621
 197
 198         Reviewed by Gyuyoung Kim.
 199
 200         * efl/jhbuild.modules:
 201         * efl/patches/efl-remove-XPrint.patch: Added.
 202
 203 2015-11-02  Carlos Garcia Campos  <cgarcia@igalia.com>
 204
 205         [GLIB] Remove delete on destroy GMainLoopSources
 206         https://bugs.webkit.org/show_bug.cgi?id=150771
 207
 208         Reviewed by Žan Doberšek.
 209
 210         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp:
 211         (TestWebKitAPI::TEST): Remove DeleteOnDestroy unit tests.
 212         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
 213         (WebViewTest::wait): Use g_timeout_add instead of GMainLoopSource.
 214
 215 2015-11-01  Yusuke Suzuki  <utatane.tea@gmail.com>
 216
 217         [ES6] Support Generator Syntax
 218         https://bugs.webkit.org/show_bug.cgi?id=150769
 219
 220         Reviewed by Geoffrey Garen.
 221
 222         Added ENABLE_ES6_GENERATORS flag.
 223
 224         * Scripts/webkitperl/FeatureList.pm:
 225
 226 2015-11-01  Alexey Proskuryakov  <ap@apple.com>
 227
 228         Sort EWS bots in popovers
 229         https://bugs.webkit.org/show_bug.cgi?id=150782
 230
 231         Reviewed by Darin Adler.
 232
 233         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js:
 234         (BubbleQueueView.prototype._popoverContentForBubbleQueue):
 235
 236 2015-10-31  Filip Pizlo  <fpizlo@apple.com>
 237
 238         B3::reduceStrength's DCE should be more agro and less wrong
 239         https://bugs.webkit.org/show_bug.cgi?id=150748
 240
 241         Reviewed by Geoffrey Garen.
 242
 243         Add an LLVM version of testb3's "testComplex".
 244
 245         * ReducedFTL/ComplexTest.cpp: Added.
 246
 247 2015-11-01  Commit Queue  <commit-queue@webkit.org>
 248
 249         Unreviewed, rolling out r191831.
 250         https://bugs.webkit.org/show_bug.cgi?id=150774
 251
 252         The new test fails (Requested by ap on #webkit).
 253
 254         Reverted changeset:
 255
 256         "Begin work on supporting reply blocks in
 257         _WKRemoteObjectRegistry"
 258         https://bugs.webkit.org/show_bug.cgi?id=150739
 259         http://trac.webkit.org/changeset/191831
 260
 261 2015-10-31  Andreas Kling  <akling@apple.com>
 262
 263         Add a debug overlay with information about web process resource usage.
 264         <https://webkit.org/b/150599>
 265
 266         Reviewed by Darin Adler.
 267
 268         Add a menu item to the MiniBrowser so we can toggle the resource usage overlay on/off.
 269
 270         * MiniBrowser/mac/SettingsController.h:
 271         * MiniBrowser/mac/SettingsController.m:
 272         (-[SettingsController _populateMenu]):
 273         (-[SettingsController validateMenuItem:]):
 274         (-[SettingsController toggleShowResourceUsageOverlay:]):
 275         (-[SettingsController resourceUsageOverlayVisible]):
 276         * MiniBrowser/mac/WK2BrowserWindowController.m:
 277         (-[WK2BrowserWindowController didChangeSettings]):
 278
 279 2015-10-31  Lucas Forschler  <lforschler@apple.com>
 280
 281         Teach the CompileWebKit step to look for additional arguments.
 282
 283         Unreviewed config change.
 284
 285         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 286         (CompileWebKit.start):
 287
 288 2015-10-30  Anders Carlsson  <andersca@apple.com>
 289
 290         Begin work on supporting reply blocks in _WKRemoteObjectRegistry
 291         https://bugs.webkit.org/show_bug.cgi?id=150739
 292
 293         Reviewed by Tim Horton.
 294
 295         Add a test. We only test the encoding right now.
 296
 297         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
 298         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
 299         (TEST):
 300         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
 301         (-[RemoteObjectRegistryPlugIn sayHello:completionHandler:]):
 302
 303 2015-10-30  Lucas Forschler  <lforschler@apple.com>
 304
 305         Add CMAke builder to build.webkit.org
 306         https://bugs.webkit.org/show_bug.cgi?id=150738
 307
 308         Reviewed by Alex Christensen.
 309
 310         * BuildSlaveSupport/build.webkit.org-config/config.json:
 311
 312 2015-10-30  Brent Fulgham  <bfulgham@apple.com>
 313
 314         [Win] build-jsc and run-javascriptcore-tests do not work
 315         https://bugs.webkit.org/show_bug.cgi?id=150700
 316
 317         Reviewed by Mark Lam.
 318
 319         Correct our build system so that it expects Windows to be using CMake,
 320         and to build the correct sub-projects for our JSC helper scripts.
 321
 322         * Scripts/build-jsc: Make sure to build the testapi harness when
 323           building for Windows.
 324         * Scripts/build-webkit:
 325           (1) Use the existing 'cmakeBasedPortName()'
 326           (2) Use File::Spec rather than hard-coding path delimeters.
 327           (3) Refer to Visual Studio 14.0, rather than the unsupported 12.0.
 328         method rather than hard-coding the name based on conditional.
 329         * Scripts/copy-webkitlibraries-to-product-directory: Don't try to grab
 330           LLVM libraries on Apple Windows build.
 331         * Scripts/run-javascriptcore-tests:
 332         (testapiPath): Use File::Spec rather than hard-coding path delimeters.
 333         * Scripts/run-jsc: Ditto.
 334         * Scripts/webkitdirs.pm:
 335         (cmakeBasedPortName): Update to return the right value for the Apple
 336         Windows port and the WinCairo port.
 337         (isCMakeBuild): Expect CMake build for all Windows ports.
 338
 339 2015-10-30  Carlos Garcia Campos  <cgarcia@igalia.com>
 340
 341         [JHBuild] Do not try to update the dependencies if jhbuild configuration hasn't changed
 342         https://bugs.webkit.org/show_bug.cgi?id=150665
 343
 344         Reviewed by Csaba Osztrogonác.
 345
 346         We check it only to wipe the directory or not, but we are still
 347         tryihng to update every module even when the configuration hasn't
 348         changed. This is problematic because it makes the whole build fail
 349         when any repository fails to checkout an already checked out
 350         revision, because the server is down for example. This is even
 351         more problematic for the bots that skip perfectly valid revisions.
 352         It's still possible to force an update passing --force command
 353         line argument.
 354
 355         * Scripts/update-webkit-libs-jhbuild:
 356         (deleteJhbuildMd5): Delete the md5sum files if exist.
 357         (runJhbuild): Return early if the md5sum files haven't
 358         changed. Only write them after a successful build and delete them
 359         if the build fails to ensure we don't skip next run.
 360
 361 2015-10-30  Philippe Normand  <pnormand@igalia.com>
 362
 363         [GTK] Fix MacCLang build errors in Tools
 364         https://bugs.webkit.org/show_bug.cgi?id=150031
 365
 366         Reviewed by Carlos Garcia Campos.
 367
 368         * TestWebKitAPI/PlatformWebView.h: Fix PlatformWindow typedef on OSX flavor of the GTK port.
 369         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp: Include WKView.h for WKViewCreate().
 370         * WebKitTestRunner/PlatformWebView.h: Fix PlatformWindow typedef on OSX flavor of the GTK port.
 371         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Include WKView.h for WKViewCreate().
 372
 373 2015-10-29  Hunseop Jeong  <hs85.jeong@samsung.com>
 374
 375         [EFL] MiniBrowser didn't work after r191749.
 376         https://bugs.webkit.org/show_bug.cgi?id=150706
 377
 378         Reviewed by Alex Christensen.
 379
 380         Renamed jhbuildWrapperPrefixIfNeeded to wrapperPrefixIfNeeded in r191749.
 381
 382         * Scripts/run-minibrowser:
 383
 384 2015-10-29  Commit Queue  <commit-queue@webkit.org>
 385
 386         Unreviewed, rolling out r191766.
 387         https://bugs.webkit.org/show_bug.cgi?id=150707
 388
 389         Problem with Cygwin build (Requested by bfulgham_ on #webkit).
 390
 391         Reverted changeset:
 392
 393         "[Win] build-jsc and run-javascriptcore-tests do not work"
 394         https://bugs.webkit.org/show_bug.cgi?id=150700
 395         http://trac.webkit.org/changeset/191766
 396
 397 2015-10-29  Brent Fulgham  <bfulgham@apple.com>
 398
 399         [Win] build-jsc and run-javascriptcore-tests do not work
 400         https://bugs.webkit.org/show_bug.cgi?id=150700
 401
 402         Reviewed by Mark Lam.
 403
 404         Correct our build system so that it expects Windows to be using CMake,
 405         and to build the correct sub-projects for our JSC helper scripts.
 406
 407         * Scripts/build-jsc: Make sure to build the testapi harness when
 408           building for Windows.
 409         * Scripts/build-webkit:
 410           (1) Use the existing 'cmakeBasedPortName()'
 411           (2) Use File::Spec rather than hard-coding path delimeters.
 412           (3) Refer to Visual Studio 14.0, rather than the unsupported 12.0.
 413         method rather than hard-coding the name based on conditional.
 414         * Scripts/run-javascriptcore-tests:
 415         (testapiPath): Use File::Spec rather than hard-coding path delimeters.
 416         * Scripts/run-jsc: Ditto.
 417         * Scripts/webkitdirs.pm:
 418         (cmakeBasedPortName): Update to return the right value for the Apple
 419         Windows port and the WinCairo port.
 420         (isCMakeBuild): Expect CMake build for all Windows ports.
 421
 422 2015-10-29  Alex Christensen  <achristensen@webkit.org>
 423
 424         Fix build-jsc on Mac after r191749.
 425
 426         * Scripts/build-jsc:
 427         Use isCMakeBuild to determine if we are building with CMake instead of cmakeBasedPortName.
 428
 429 2015-10-29  Alex Christensen  <achristensen@webkit.org>
 430
 431         Fix Mac CMake build
 432         https://bugs.webkit.org/show_bug.cgi?id=150686
 433
 434         Reviewed by Filip Pizlo.
 435
 436         * Scripts/build-webkit:
 437         * Scripts/webkitdirs.pm:
 438         (isCachedArgumentfileOutOfDate):
 439         (wrapperPrefixIfNeeded):
 440         (generateBuildSystemFromCMakeProject):
 441         (buildCMakeGeneratedProject):
 442         (cmakeBasedPortName):
 443         (determineIsCMakeBuild):
 444         (isCMakeBuild):
 445         (promptUser):
 446         (jhbuildWrapperPrefixIfNeeded): Deleted.
 447
 448 2015-10-29  Lucas Forschler  <lforschler@apple.com>
 449
 450         Teach JSC bots to build 32bit instead of x86_64
 451
 452         Reviewed by Mark Lam.
 453
 454         * BuildSlaveSupport/build.webkit.org-config/config.json:
 455
 456 2015-10-29  Per Arne Vollan  <peavo@outlook.com>
 457
 458         [WinCairo] Fall back to AppleWin results in layout tests.
 459         https://bugs.webkit.org/show_bug.cgi?id=150672
 460
 461         Reviewed by Alex Christensen.
 462
 463         * Scripts/webkitpy/port/win.py:
 464         (WinCairoPort):
 465         (WinCairoPort.default_baseline_search_path):
 466
 467 2015-10-28  Keith Rollin  <krollin@apple.com>
 468
 469         Do not sanitize user input for input[type=url]
 470         https://bugs.webkit.org/show_bug.cgi?id=150346
 471         <rdar://problem/23243240>
 472
 473         Reviewed by Brent Fulgham.
 474
 475         The Windows version of DumpRenderTree's eventSender.keyDown handler
 476         simulates user-entry by decomposing the given character into a virtual
 477         key code and a set of modifier keys. The code that determines if the
 478         shift key should be simulated only worked if the character was an
 479         upper case character. Extend this support to also include symbols that
 480         (on the U.S. keyboard) require holding down the shift key.
 481
 482         This change allows fast/forms/input-user-input-sanitization.html
 483         to succeed, which requires us to simulate the entering of '@' and ':'.
 484
 485         * DumpRenderTree/win/EventSender.cpp:
 486         (keyDownCallback):
 487
 488 2015-10-28  Alex Christensen  <achristensen@webkit.org>
 489
 490         Compile and link with CMake on Mac
 491         https://bugs.webkit.org/show_bug.cgi?id=150632
 492
 493         Reviewed by Tim Horton.
 494
 495         * TestWebKitAPI/PlatformMac.cmake:
 496
 497 2015-10-28  Xabier Rodriguez Calvar  <calvaris@igalia.com>
 498
 499         Unreviewed.
 500
 501         * Scripts/webkitpy/common/config/watchlist: Removed dead files from Streams API watchlist.
 502
 503 2015-10-28  Per Arne Vollan  <peavo@outlook.com>
 504
 505         Add WinCairo to list of ports in run-webkit-tests.
 506         https://bugs.webkit.org/show_bug.cgi?id=150625
 507
 508         Reviewed by Brent Fulgham.
 509
 510         * Scripts/webkitpy/common/config/ports.py:
 511         (DeprecatedPort.port):
 512         (WinPort.run_webkit_tests_command):
 513         (WinCairoPort):
 514         (GtkWK2Port):
 515         * Scripts/webkitpy/port/factory.py:
 516         (PortFactory):
 517         * Scripts/webkitpy/port/win.py:
 518         (WinPort.find_system_pid):
 519         (WinCairoPort):
 520
 521 2015-10-27  Alexey Proskuryakov  <ap@apple.com>
 522
 523         WebKitTestRunner leaks in generateWhitelist()
 524         https://bugs.webkit.org/show_bug.cgi?id=150563
 525
 526         Reviewed by Andreas Kling.
 527
 528         * WebKitTestRunner/mac/TestControllerMac.mm:
 529         (WTR::generateWhitelist):
 530
 531 2015-10-27  Anders Carlsson  <andersca@apple.com>
 532
 533         Add an API test for _WKRemoteObjectRegistry
 534         https://bugs.webkit.org/show_bug.cgi?id=150597
 535
 536         Reviewed by Andreas Kling.
 537
 538         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 539         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Added.
 540         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm: Added.
 541         (TEST):
 542         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm: Added.
 543         (-[RemoteObjectRegistryPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
 544         (-[RemoteObjectRegistryPlugIn sayHello:]):
 545
 546 2015-10-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 547
 548         Add myself to the reviewers list
 549         https://bugs.webkit.org/show_bug.cgi?id=150581
 550
 551         Unreviewed.
 552
 553         * Scripts/webkitpy/common/config/contributors.json:
 554
 555 2015-10-26  Ryan Haddad  <ryanhaddad@apple.com>
 556
 557         Adding myself to contributors.json
 558
 559         * Scripts/webkitpy/common/config/contributors.json:
 560
 561 2015-10-26  Tim Horton  <timothy_horton@apple.com>
 562
 563         Don't expose the whitelist/blacklist in _WKUserStyleSheet
 564         https://bugs.webkit.org/show_bug.cgi?id=150566
 565
 566         Reviewed by Anders Carlsson.
 567
 568         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
 569         (TEST):
 570
 571 2015-10-26  Philippe Normand  <pnormand@igalia.com>
 572
 573         Unreviewed, rolling out r191576.
 574
 575         broke
 576
 577         Reverted changeset:
 578
 579         "[GStreamer] Bump internal jhbuild versions to 1.6.0"
 580         https://bugs.webkit.org/show_bug.cgi?id=149594
 581         http://trac.webkit.org/changeset/191576
 582
 583 2015-10-26  ChangSeok Oh  <changseok.oh@collabora.com>
 584
 585         [GStreamer] Bump internal jhbuild versions to 1.6.0
 586         https://bugs.webkit.org/show_bug.cgi?id=149594
 587
 588         Reviewed by Philippe Normand.
 589
 590         Bump up whole gstreamer libraries to 1.6.0. Relevant patches are no more
 591         useful so they are removed accordingly.
 592
 593         * gtk/jhbuild.modules:
 594         * gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Removed.
 595         * gtk/patches/gst-plugins-bad-remove-gnustep-support.patch: Removed.
 596         * gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed.
 597
 598 2015-10-25  Alexey Proskuryakov  <ap@apple.com>
 599
 600         API tests fail on El Capitan after r191543
 601         https://bugs.webkit.org/show_bug.cgi?id=150547
 602
 603         Reviewed by Dan Bernstein.
 604
 605         * Scripts/run-api-tests: (listAllTests): Add appropriate arch arguments in one more place.
 606
 607 2015-10-24  Tim Horton  <timothy_horton@apple.com>
 608
 609         Add a way to add user style sheets to WKUserContentController
 610         https://bugs.webkit.org/show_bug.cgi?id=150531
 611         <rdar://problem/23191691>
 612
 613         Reviewed by Darin Adler.
 614
 615         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
 616         (TEST):
 617
 618 2015-10-24  Tim Horton  <timothy_horton@apple.com>
 619
 620         Expose more information about the exception in WKErrorJavaScriptExceptionOccurred errors
 621         https://bugs.webkit.org/show_bug.cgi?id=150525
 622
 623         Reviewed by Darin Adler.
 624
 625         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
 626         (TEST):
 627         Test the various new keys.
 628
 629 2015-10-24  Frederic Wang  <fred.wang@free.fr>
 630
 631         check-webkit-style complains about missing operator whitespace inside character literal
 632         https://bugs.webkit.org/show_bug.cgi?id=150396
 633
 634         Reviewed by Darin Adler.
 635
 636         * Scripts/webkitpy/style/checkers/cpp.py: Improve matching of C++ character literal.
 637         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
 638         (WebKitStyleTest.test_spacing): Add a test to verify that the spacing for the character literal 'OS/2' is not tested.
 639
 640 2015-10-23  Michael Saboff  <msaboff@apple.com>
 641
 642         REGRESSION (r179357-r179359): WebContent Crash using AOL Mail @ com.apple.JavascriptCore JSC::linkPolymorphicCall(JSC::ExecState*, JSC::CallLinkInfo&, JSC::CallVariant, JSC::RegisterPreservationMode) + 1584
 643         https://bugs.webkit.org/show_bug.cgi?id=150513
 644
 645         Reviewed by Saam Barati.
 646
 647         Added a new test function, failNextNewCodeBlock() to simplify the writing of a regression test.
 648
 649         * DumpRenderTree/TestRunner.cpp:
 650         (simulateWebNotificationClickCallback):
 651         (failNextCodeBlock):
 652         (numberOfDFGCompiles):
 653         (TestRunner::staticFunctions):
 654         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
 655         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
 656         (WTR::TestRunner::setBlockAllPlugins):
 657         (WTR::TestRunner::failNextCodeBlock):
 658         (WTR::TestRunner::numberOfDFGCompiles):
 659         * WebKitTestRunner/InjectedBundle/TestRunner.h:
 660
 661 2015-10-23  Anders Carlsson  <andersca@apple.com>
 662
 663         Simplify the WebKitLegacy menu conversion code
 664         https://bugs.webkit.org/show_bug.cgi?id=150509
 665
 666         Reviewed by Andreas Kling.
 667
 668         Implement the context menu delegate method so we'll test that code path.
 669
 670         * MiniBrowser/mac/WK1BrowserWindowController.m:
 671         (-[WK1BrowserWindowController webView:contextMenuItemsForElement:defaultMenuItems:]):
 672
 673 2015-10-23  Per Arne Vollan  <peavo@outlook.com>
 674
 675         [WinCairo] Improve test results for fast layouttests.
 676         https://bugs.webkit.org/show_bug.cgi?id=150464
 677
 678         Reviewed by Alex Christensen.
 679
 680         Set custom device scale factor to 1.0.
 681
 682         * DumpRenderTree/win/DumpRenderTree.cpp:
 683         (createWebViewAndOffscreenWindow):
 684
 685 2015-10-23  Mark Salisbury  <mark.salisbury@hp.com>
 686
 687         [GTK] update-webkitgtk-libs should use mesa tarball
 688
 689         https://bugs.webkit.org/show_bug.cgi?id=150470
 690
 691         update-webkitgtk-libs downloads all build dependencies; in fixing
 692         bug 148941 mesa was switched from ftp to git access.  Now an http
 693         tarball is available, which is preferred over accessing via git.
 694
 695         Reviewed by Philippe Normand
 696
 697         * gtk/jhbuild.modules:
 698         Mesa access changed to http tarball.
 699
 700 2015-10-22  Sam Weinig  <sam@webkit.org>
 701
 702         Navigations on the same host (but with different schemes and ports) should not trigger universal links
 703         <rdar://problem/22811325>
 704         https://bugs.webkit.org/show_bug.cgi?id=150481
 705
 706         Reviewed by Dan Bernstein.
 707
 708         * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
 709         Update test to test that navigations on the same host but with different schemes does not
 710         trigger universal links, but that changes in the host do.
 711
 712 2015-10-22  Ryosuke Niwa  <rniwa@webkit.org>
 713
 714         REGRESSION (r181972): Scroll position changes to top of youtube page when switching tabs
 715         https://bugs.webkit.org/show_bug.cgi?id=150428
 716
 717         Reviewed by Antti Koivisto.
 718
 719         Added a regression test using WebKit API test.
 720
 721         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 722         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm: Added.
 723         (TestWebKitAPI::didFinishLoadForFrame):
 724         (TestWebKitAPI::TEST):
 725
 726 2015-10-22  Carlos Garcia Campos  <cgarcia@igalia.com>
 727
 728         Unreviewed. Fix GTK+ build after r191423.
 729
 730         Add WebKitDOMHTMLBaseFontElement to the list of deleted classes.
 731
 732         * gtk/webkitdom.py:
 733         (WebKitDOMDocGenerator):
 734
 735 2015-10-22  Aakash Jain  <aakash_jain@apple.com>
 736
 737         [Win][EFL][GTK] webkitpy test failed after r191374.
 738         https://bugs.webkit.org/show_bug.cgi?id=150433
 739
 740         Reviewed by Alexey Proskuryakov.
 741
 742         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
 743         (CrashLogsTest.test_find_all_log_darwin): Check platform before running test.
 744         (CrashLogsTest.test_find_log_darwin): Same.
 745
 746 2015-10-21  Brian Burg  <bburg@apple.com>
 747
 748         Unreviewed, update watchlist for JS builtins.
 749
 750         Add a category for JS builtins code generator, similar to other generators.
 751
 752         Add a nag message to rebaseline builtins generator tests when touching
 753         code generator files in Source/JavaScriptCore/Scripts/builtins/.
 754
 755         * Scripts/webkitpy/common/config/watchlist:
 756
 757 2015-10-21  Brian Burg  <bburg@apple.com>
 758
 759         Restructure generate-js-bindings script to be modular and testable
 760         https://bugs.webkit.org/show_bug.cgi?id=149929
 761
 762         Reviewed by Alex Christensen.
 763
 764         Add a stub shell script and basic webkitpy support for running builtins
 765         generator tests.
 766
 767         * Scripts/run-builtins-generator-tests: Added.
 768         (main):
 769         * Scripts/webkitpy/codegen/__init__.py: Added.
 770         * Scripts/webkitpy/codegen/main.py: Added.
 771
 772             The only interesting difference here from the inspector protocol
 773             generator equivalent is that this implementation decodes the target
 774             framework and output mode (combined or separate) from the test's file name.
 775
 776         (BuiltinsGeneratorTests):
 777         (BuiltinsGeneratorTests.__init__):
 778         (BuiltinsGeneratorTests.generate_from_js_builtins):
 779         (BuiltinsGeneratorTests.write_error_file):
 780         (BuiltinsGeneratorTests.detect_changes):
 781         (BuiltinsGeneratorTests.run_tests):
 782         (BuiltinsGeneratorTests.main):
 783
 784 2015-10-21  Aakash Jain  <aakash_jain@apple.com>
 785
 786         run-webkit-tests does not copy all crash logs for layout test failures on Mac
 787         https://bugs.webkit.org/show_bug.cgi?id=150407
 788         <rdar://problem/22239750>
 789
 790         Reviewed by Alexey Proskuryakov.
 791
 792         * Scripts/webkitpy/port/mac.py:
 793         (MacPort._merge_crash_logs): Merge unique crash logs from two dictionaries.
 794         (MacPort._look_for_all_crash_logs_in_log_dir): Get the crash logs from
 795         the log directory.
 796         (MacPort.look_for_new_crash_logs): Uses above method to get crash logs
 797         from log directory and merge them with the list of already crashed tests.
 798
 799 2015-10-21  Filip Pizlo  <fpizlo@apple.com>
 800
 801         Failures in PutStackSinkingPhase should be less severe
 802         https://bugs.webkit.org/show_bug.cgi?id=150400
 803
 804         Reviewed by Geoffrey Garen.
 805
 806         Add a test mode for no PutStackSinkingPhase.
 807
 808         * Scripts/run-jsc-stress-tests:
 809
 810 2015-10-21  Nan Wang  <n_wang@apple.com>
 811
 812         AX: Expose table size and cell indexes on iOS
 813         https://bugs.webkit.org/show_bug.cgi?id=150366
 814
 815         Reviewed by Chris Fleizach.
 816
 817         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
 818         (AccessibilityUIElement::rowCount):
 819         (AccessibilityUIElement::columnCount):
 820         (AccessibilityUIElement::indexInTable):
 821         (AccessibilityUIElement::numberAttributeValue):
 822         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
 823         (WTR::AccessibilityUIElement::numberAttributeValue):
 824         (WTR::AccessibilityUIElement::rowCount):
 825         (WTR::AccessibilityUIElement::columnCount):
 826         (WTR::AccessibilityUIElement::indexInTable):
 827
 828 2015-10-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 829
 830         W3C test importer should not import reference files as regular tests
 831         https://bugs.webkit.org/show_bug.cgi?id=150331
 832
 833         Reviewed by Darin Adler.
 834
 835         Updated test_parser to return information that a file can be a referencefile or a manual test.
 836         Updated test importer to skip those files.
 837         Updated/Added test parser unit tests accordingly.
 838
 839         Updated test importer to import all not-test files, as they are usually used by tests and lead to test failing or timing out.
 840         Updated test importer to log these 'resource' files that are not in a resources folder, and suggest to import script user
 841         to mark these files as Skip, since they are not direct tests.
 842
 843         * Scripts/webkitpy/w3c/test_importer.py:
 844         (TestImporter.__init__):
 845         (TestImporter.find_importable_tests):
 846         (TestImporter.import_tests):
 847         * Scripts/webkitpy/w3c/test_parser.py:
 848         (TestParser.analyze_test):
 849         * Scripts/webkitpy/w3c/test_parser_unittest.py:
 850         (test_analyze_non_html_file):
 851         (test_reference_test):
 852
 853 2015-10-20  Aakash Jain  <aakash_jain@apple.com>
 854
 855         run-webkit-tests does not copy all crash logs for layout test failures on iOS
 856         https://bugs.webkit.org/show_bug.cgi?id=150056
 857         <rdar://problem/9280656>
 858
 859         Reviewed by Alexey Proskuryakov.
 860
 861         * Scripts/webkitpy/common/system/crashlogs.py:
 862         (CrashLogs.find_all_logs): Generic method to find all crash logs.
 863         (CrashLogs._find_all_logs_darwin): Darwin based method to find all crash logs.
 864         It iterates through log directory and returns all the logs based on timestamp.
 865         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
 866         (CrashLogsTest.create_crash_logs_darwin): Creates sample crash logs and verify them.
 867         (CrashLogsTest.test_find_all_log_darwin): Testcase for above find_all_logs method
 868         (CrashLogsTest.test_find_log_darwin): Restructured to share code with other methods.
 869         * Scripts/webkitpy/layout_tests/controllers/manager.py:
 870         (Manager.run): Modified start_time to start counting before simulator launch
 871         so that we can capture crashes during simualator launch.
 872         (Manager._look_for_new_crash_logs): Browse through list of crashes and append
 873         any test which is not already marked as CRASH to the run_results.
 874         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
 875         (TestExpectationsModel.get_expectations_string): return PASS in case there
 876         are no expectations defined for this test.
 877         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
 878         (summarize_results): Add other_crashes in a separte category in full_results.json.
 879         * Scripts/webkitpy/port/ios.py:
 880         (IOSSimulatorPort._merge_crash_logs): Merge unique crash logs from two dictionaries.
 881         (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Get the crash logs
 882         from the log directory.
 883         (IOSSimulatorPort.look_for_new_crash_logs): Uses above method to get crash
 884         logs from log directory and merge them with the list of already crashed tests.
 885
 886 2015-10-20  Dana Burkart  <dburkart@apple.com>
 887
 888         Fix the build
 889
 890         Unreviewed.
 891
 892         My previous patch was missing a necessary space character.
 893
 894         * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
 895
 896 2015-10-20  Dana Burkart  <dburkart@apple.com>
 897
 898         svn-apply fails to apply binary diffs in some cases
 899         https://bugs.webkit.org/show_bug.cgi?id=64647
 900
 901         Reviewed by Daniel Bates.
 902
 903         * Scripts/VCSUtils.pm:
 904         (decodeGitBinaryPatchDeltaSize): Modified.
 905         We need to handle the case where the binary diff is the last in the patch; so we match on "-- \n" or "\Z".
 906         * Tools/Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl: Added.
 907
 908 2015-10-20  Alexey Proskuryakov  <ap@apple.com>
 909
 910         Mac Debug EWS never finishes when there are failures
 911         https://bugs.webkit.org/show_bug.cgi?id=150334
 912
 913         Reviewed by Daniel Bates.
 914
 915         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
 916         * Scripts/webkitpy/tool/commands/queues.py:
 917
 918 2015-10-20  Philippe Normand  <pnormand@igalia.com>
 919
 920         [GTK] Enable OpenWebRTC test video/audio sources in tests
 921
 922         This is needed because we can't expect the buildbots to have
 923         webcam/mic devices plugged in.
 924
 925         Rubber-stamped by Carlos Garcia Campos.
 926
 927         * Scripts/run-gtk-tests:
 928         (TestRunner._setup_testing_environment):
 929         * Scripts/webkitpy/port/gtk.py:
 930         (GtkPort.setup_environ_for_server):
 931
 932 2015-10-20  Yoav Weiss  <yoav@yoav.ws>
 933
 934         Rename the PICTURE_SIZES flag to CURRENTSRC
 935         https://bugs.webkit.org/show_bug.cgi?id=150275
 936
 937         Reviewed by Dean Jackson.
 938
 939         * Scripts/webkitperl/FeatureList.pm:
 940
 941 2015-10-19  Hunseop Jeong  <hs85.jeong@samsung.com>
 942
 943         Unreviewed, add myself to the committers list.
 944
 945         * Scripts/webkitpy/common/config/contributors.json:
 946
 947 2015-10-19  Alexey Proskuryakov  <ap@apple.com>
 948
 949         Add new EWS queues to bot watcher's dashboard
 950         https://bugs.webkit.org/show_bug.cgi?id=150297
 951
 952         Reviewed by Darin Adler.
 953
 954         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
 955         (BubbleQueueServer):
 956
 957 2015-10-19  ChangSeok Oh  <changseok.oh@collabora.com>
 958
 959         REGRESSION(r190262): User media unit test failures after r190262
 960         https://bugs.webkit.org/show_bug.cgi?id=149580
 961
 962         Reviewed by Carlos Garcia Campos.
 963
 964         The test failures on usermedia-permission-requests and WebKit2.UserMediaBasic have gone.
 965         So we do not need to skip them anymore.
 966
 967         * Scripts/run-gtk-tests:
 968         (TestRunner): Deleted.
 969
 970 2015-10-19  Csaba Osztrogonác  <ossy@webkit.org>
 971
 972         Add historical addresses to contributors.json
 973         https://bugs.webkit.org/show_bug.cgi?id=150227
 974
 975         Reviewed by Darin Adler.
 976
 977         * Scripts/webkitpy/common/config/contributors.json:
 978
 979 2015-10-18  Sungmann Cho  <sungmann.cho@navercorp.com>
 980
 981         [Win] Change the DLL name in MiniBrowserLib.vcxproj to match webkit.org/b/150124.
 982         https://bugs.webkit.org/show_bug.cgi?id=150307
 983
 984         Reviewed by Brent Fulgham.
 985
 986         The DLL build rules have been changed to generate "{Name}Lib.DLL",
 987         but these changes have not yet been applied to the Visual Studio builds.
 988
 989         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj:
 990
 991 2015-10-16  Andreas Kling  <akling@apple.com>
 992
 993         [EFL, AppleWin] WTF.ConcatenateCharacterArrayAndEmptyString API test failed
 994         <https://webkit.org/b/150153>
 995
 996         Unreviewed.
 997
 998         Just use simple arrays of LChar and UChar for this test instead of creating String
 999         objects and then getting the characters8()/characters16() from them, since that
1000         doesn't guarantee null-termination (the bug.)
1001
1002         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
1003         (TestWebKitAPI::TEST):
1004         (TestWebKitAPI::build): Deleted.
1005
1006 2015-10-16  Tim Horton  <timothy_horton@apple.com>
1007
1008         WebKit2.AutoLayoutIntegration API test is failing on some of the bots
1009         https://bugs.webkit.org/show_bug.cgi?id=150255
1010
1011         Reviewed by Simon Fraser.
1012
1013         * Scripts/run-api-tests:
1014         (runTest):
1015         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
1016         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:]):
1017         (-[AutoLayoutWKWebView layoutAtMinimumWidth:andExpectContentSizeChange:]):
1018         (-[AutoLayoutWKWebView load:expectingContentSize:]): Deleted.
1019         (-[AutoLayoutWKWebView expectContentSizeChange:]): Deleted.
1020         Don't set the layout size until after the load finishes and we're waiting
1021         for the reply, so that there is no race between the new size coming in
1022         and us waiting for it.
1023
1024 2015-10-16  Anders Carlsson  <andersca@apple.com>
1025
1026         WebEditingDelegate should be a formal protocol
1027         https://bugs.webkit.org/show_bug.cgi?id=150254
1028         <rdar://problem/23149847>
1029
1030         Reviewed by Dan Bernstein.
1031
1032         * DumpRenderTree/mac/EditingDelegate.h:
1033         Conform to the WebEditingDelegate protocol.
1034
1035 2015-10-16  Tim Horton  <timothy_horton@apple.com>
1036
1037         Hook up autolayout intrinsic sizing for WKWebView
1038         https://bugs.webkit.org/show_bug.cgi?id=150219
1039         <rdar://problem/20016905>
1040
1041         Reviewed by Simon Fraser.
1042
1043         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1044         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm: Added.
1045         (-[AutoLayoutNavigationDelegate webView:didFinishNavigation:]):
1046         (-[AutoLayoutWKWebView load:expectingContentSize:]):
1047         (-[AutoLayoutWKWebView expectContentSizeChange:]):
1048         (-[AutoLayoutWKWebView invalidateIntrinsicContentSize]):
1049         (TEST):
1050         Add a variety of tests, including one which catches the bug that
1051         the WebCore part of this patch fixes.
1052
1053 2015-10-15  Csaba Osztrogonác  <ossy@webkit.org>
1054
1055         Update the help message of --system-malloc
1056         https://bugs.webkit.org/show_bug.cgi?id=150169
1057
1058         Reviewed by Geoffrey Garen.
1059
1060         * Scripts/webkitperl/FeatureList.pm:
1061
1062 2015-10-15  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1063
1064         Update ImportExpectations according currently imported wpt tests
1065         https://bugs.webkit.org/show_bug.cgi?id=150158
1066
1067         Reviewed by Chris Dumez.
1068
1069         * Scripts/webkitpy/w3c/test_downloader.py:
1070         (TestDownloader.copy_tests): ensuring that directories marked as [ Skip ] are not copied.
1071
1072 2015-10-15  Eunmi Lee  <eunmi15.lee@samsung.com>
1073
1074         Unreviewed, Update my email address.
1075
1076         * Scripts/webkitpy/common/config/contributors.json:
1077
1078 2015-10-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1079
1080         [GTK] Test WebKit2.RestoreSessionStateContainingFormData fails
1081         https://bugs.webkit.org/show_bug.cgi?id=84960
1082
1083         Reviewed by Žan Doberšek.
1084
1085         * Scripts/run-gtk-tests:
1086         (TestRunner): Unskip tests using SessionState.
1087         * TestWebKitAPI/PlatformGTK.cmake: Add
1088         WKPageCopySessionStateWithFiltering test.
1089
1090 2015-10-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1091
1092         [GTK] Missing return value on TestWebExtensions.cpp:193
1093         https://bugs.webkit.org/show_bug.cgi?id=149755
1094
1095         Unreviewed. Add missing return value.
1096
1097         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
1098         (permissionRequestCallback):
1099
1100 2015-10-14  Andy Estes  <aestes@apple.com>
1101
1102         [iOS] build-dumprendertree does not build ImageDiff
1103         https://bugs.webkit.org/show_bug.cgi?id=150152
1104
1105         Reviewed by Tim Horton.
1106
1107         run-webkit-tests attempts to build the tools it requires by calling build-dumprendertree and build-webkittestrunner.
1108         On iOS, build-dumprendertree builds the DumpRenderTree.app target, which does not contain the ImageDiff target
1109         as a dependent. If you haven't built ImageDiff by other means (say, because you built the 'All Source' scheme in
1110         WebKit.xcworkspace), tests that rely on image diffing won't work properly.
1111
1112         There's actually no reason to build the DumpRenderTree.app target on iOS; the default aggregate target works
1113         fine on that platform, and results in ImageDiff being built.
1114
1115         * Scripts/build-dumprendertree:
1116
1117 2015-10-14  Brent Fulgham  <bfulgham@apple.com>
1118
1119         [Win] Enforce launcher/library naming scheme
1120         https://bugs.webkit.org/show_bug.cgi?id=150124
1121
1122         Reviewed by Alex Christensen.
1123
1124         * DumpRenderTree/PlatformWin.cmake: Use 'Lib' suffix for DLLs.
1125         * MiniBrowser/win/CMakeLists.txt: Ditto.
1126         * TestWebKitAPI/PlatformWin.cmake: Ditto.
1127         * win/DLLLauncher/DLLLauncherMain.cpp:
1128         (wWinMain): Look for a DLL named {name}Lib.dll, rather than the
1129         original {name}.dll.
1130
1131 2015-10-14  Andreas Kling  <akling@apple.com>
1132
1133         REGRESSION(r190882): Concatenating a character array and an empty string is broken.
1134         <https://webkit.org/b/150135>
1135
1136         Reviewed by Geoffrey Garen.
1137
1138         Add a new WTF API test that covers this issue.
1139
1140         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
1141         (TestWebKitAPI::build):
1142         (TestWebKitAPI::TEST):
1143
1144 2015-10-14  Alex Christensen  <achristensen@webkit.org>
1145
1146         Add SPI for reloading without content blockers
1147         https://bugs.webkit.org/show_bug.cgi?id=150058
1148         rdar://problem/22742222
1149
1150         Reviewed by Sam Weinig.
1151
1152         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1153         (WTR::TestController::cocoaResetStateToConsistentValues):
1154         * WebKitTestRunner/mac/TestControllerMac.mm:
1155         (WTR::TestController::platformConfigureViewForTest):
1156
1157 2015-10-14  Mark Lam  <mark.lam@apple.com>
1158
1159         Rename some JSC option names to be more uniform.
1160         https://bugs.webkit.org/show_bug.cgi?id=150127
1161
1162         Reviewed by Geoffrey Garen.
1163
1164         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
1165         * Scripts/run-jsc-stress-tests:
1166
1167 2015-10-14  Anders Carlsson  <andersca@apple.com>
1168
1169         Change the bundle app cache APIs to take a page
1170         https://bugs.webkit.org/show_bug.cgi?id=150123
1171
1172         Reviewed by Sam Weinig.
1173
1174         Update APIs.
1175
1176         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1177         (WTR::InjectedBundle::beginTesting):
1178         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1179         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
1180         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1181         (WTR::TestRunner::clearAllApplicationCaches):
1182         (WTR::TestRunner::clearApplicationCacheForOrigin):
1183         (WTR::TestRunner::setAppCacheMaximumSize):
1184         (WTR::TestRunner::applicationCacheDiskUsageForOrigin):
1185         (WTR::TestRunner::originsWithApplicationCache):
1186
1187 2015-10-14  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1188
1189         Update web-platform-tests tools to the latest revision
1190         https://bugs.webkit.org/show_bug.cgi?id=149645
1191
1192         Reviewed by Darin Adler.
1193
1194         Disabling git submodules information conversion to json install file for web-platform-tests.
1195         Disabling related python unit tests.
1196         The tools submodules contain submodules and the conversion tool does not support that yet.
1197
1198         Updating wpt launcher script to aling it with web-platform-test main script.
1199
1200         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
1201         (main):
1202         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
1203         (TestWebPlatformTestServer.test_corrupted_subserver_files): Deleted.
1204         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1205         (TestImporterTest.test_submodules_generation):
1206
1207 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
1208
1209         More debug queue build fixing.
1210
1211         Preserve the build style in one more place. Changed mock build_style from "both"
1212         to "release", as we don't support testing both debug and release.
1213
1214         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1215         (MockCommitQueue.archive_last_test_results):
1216         (MockCommitQueue):
1217         (MockCommitQueue.build_style):
1218         (MockCommitQueue.did_pass_testing_ews):
1219         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1220         (PatchAnalysisTask._test):
1221         (PatchAnalysisTask._build_and_test_without_patch):
1222         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1223         (EarlyWarningSystemTest._default_expected_logs):
1224         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1225
1226 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
1227
1228         More debug queue build fixing.
1229
1230         Add build_style argument to derived classes as well.
1231
1232         * Scripts/webkitpy/common/config/ports.py:
1233         (MacPort):
1234         (MacPort.run_webkit_tests_command):
1235         (WinPort.run_bindings_tests_command):
1236         (WinPort):
1237         (WinPort.run_webkit_tests_command):
1238         (GtkWK2Port.build_webkit_command):
1239         (GtkWK2Port):
1240         (GtkWK2Port.run_webkit_tests_command):
1241
1242 2015-10-13  Myles C. Maxfield  <mmaxfield@apple.com>
1243
1244         [iOS] Build fix
1245
1246         Unreviewed.
1247
1248         Mach-O section names are limited to 16 characters.
1249
1250         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1251         * DumpRenderTree/mac/DumpRenderTree.mm:
1252         (activateFontsIOS):
1253
1254 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
1255
1256         Build fix for mac-debug EWS queue.
1257
1258         Unreviewed.
1259
1260         Pass --debug to run-webkit-tests.
1261
1262         While at it, removed unsupported run_webkit_unit_tests_command. All the test steps
1263         will need to be substantially modified to work in EWS, so the dummy implementation
1264         was not helpful.
1265
1266         * Scripts/webkitpy/common/config/ports.py:
1267         (DeprecatedPort.run_javascriptcore_tests_command):
1268         (DeprecatedPort):
1269         (DeprecatedPort.run_webkit_tests_command):
1270         (DeprecatedPort.run_python_unittests_command):
1271         (DeprecatedPort.run_webkit_unit_tests_command): Deleted.
1272         * Scripts/webkitpy/common/config/ports_mock.py:
1273         (MockPort.run_javascriptcore_tests_command):
1274         (MockPort):
1275         (MockPort.run_webkit_tests_command):
1276         (MockPort.run_bindings_tests_command):
1277         (MockPort.run_webkit_unit_tests_command): Deleted.
1278         * Scripts/webkitpy/tool/commands/download_unittest.py:
1279         * Scripts/webkitpy/tool/steps/runtests.py:
1280         (RunTests.run):
1281         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1282         (RunTestsTest.test_webkit_run_unit_tests):
1283         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1284         (StepsTest.test_runtests_args):
1285
1286 2015-10-13  Brent Fulgham  <bfulgham@apple.com>
1287
1288         [Win] Generate Crash Traces
1289         https://bugs.webkit.org/show_bug.cgi?id=150103
1290
1291         Reviewed by Daniel Bates.
1292
1293         We were using an exception filter to try to emit "#CRASHED" to stderr
1294         when a test program crashed. However, the modern Python implementation
1295         seems capable of recognizing crashes on its own. Furthermore, registering
1296         the exception handler was preventing the JIT debugger (NTSD) from
1297         automatically attaching to the crashing program, so we were not getting
1298         crash traces.
1299
1300         * DumpRenderTree/win/DumpRenderTree.cpp:
1301         (main): Don't register an exception filter.
1302         (exceptionFilter): Deleted.
1303         * Scripts/webkitpy/common/system/crashlogs.py:
1304         (CrashLogs): Add another regular expression to handle a second crash trace
1305         syntax I encountered during testing.
1306         (CrashLogs._find_newest_log_win): If the old regular expression doesn't match,
1307         try the new one. The PID found by the new expression is in hexadecimal, so
1308         convert it to an integer before returning it.
1309         * Scripts/webkitpy/port/driver.py:
1310         (Driver._check_for_driver_crash_or_unresponsiveness): Windows was not recognizing
1311         the "#CRASHED" state because it was appending '\r\n', rather than just '\r'. Instead,
1312         check for "#CRASHED" after stripping off the EOL characters.
1313         * Scripts/webkitpy/port/win.py:
1314         (WinPort.setup_crash_log_saving): Put back the '-e %ld' flag in the debugger
1315         invocation. This is apparently used to signal an event when the debugger is finished.
1316
1317 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
1318
1319         Mac Debug and 32-bit queues should be separate
1320         https://bugs.webkit.org/show_bug.cgi?id=150092
1321
1322         Reviewed by Lucas Forschler.
1323
1324         * QueueStatusServer/config/queues.py:
1325         * QueueStatusServer/model/queues.py:
1326         (Queue._capitalize_after_dash):
1327         (Queue._caplitalize_after_dash): Deleted.
1328         * Scripts/webkitpy/common/config/ews.json:
1329
1330 2015-10-13  Sergio Villar Senin  <svillar@igalia.com>
1331
1332         [GTK] Fix build for ENABLE_TOUCH_EVENTS=OFF
1333         https://bugs.webkit.org/show_bug.cgi?id=150085
1334
1335         Reviewed by Carlos Garcia Campos.
1336
1337         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1338
1339 2015-10-13  Sebastian Dröge  <sebastian@centricular.com>
1340
1341         Unreviewed, add myself to the committers list.
1342
1343         * Scripts/webkitpy/common/config/contributors.json:
1344
1345 2015-10-12  Alexey Proskuryakov  <ap@apple.com>
1346
1347         Update bot watcher's dashboard to reflect that EWS is on iOS 9 now
1348         https://bugs.webkit.org/show_bug.cgi?id=149983
1349
1350         Reviewed by Dan Bates.
1351
1352         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1353         (BubbleQueueServer):
1354         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1355
1356 2015-10-12  Alexey Proskuryakov  <ap@apple.com>
1357
1358         Fix webkitpy tests after r190922.
1359
1360         * Scripts/webkitpy/common/config/ews.json:
1361         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1362         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1363
1364 2015-10-12  Alexey Proskuryakov  <ap@apple.com>
1365
1366         Add a Mac debug EWS queue
1367         https://bugs.webkit.org/show_bug.cgi?id=150069
1368
1369         Reviewed by Geoffrey Garen.
1370
1371         * QueueStatusServer/config/queues.py:
1372         * Scripts/webkitpy/common/config/ews.json:
1373         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1374         (AbstractEarlyWarningSystem):
1375         (AbstractEarlyWarningSystem.archive_last_test_results):
1376         (AbstractEarlyWarningSystem.build_style):
1377         (AbstractEarlyWarningSystem.refetch_patch):
1378         (AbstractEarlyWarningSystem.load_ews_classes):
1379
1380 2015-10-12  Mario Sanchez Prada  <mario@endlessm.com>
1381
1382         [GTK] Update jhbuild's version of harfbuzz
1383         https://bugs.webkit.org/show_bug.cgi?id=149749
1384
1385         Reviewed by Martin Robinson.
1386
1387         Update harfbuzz to 0.9.35, following the lead of Debian Stable.
1388
1389         * gtk/jhbuild.modules: Updated details for harfbuzz.
1390
1391 2015-10-12  Mario Sanchez Prada  <mario@endlessm.com>
1392
1393         [GTK] Media tests crashing with gst-plugins-bad 1.4.4 and cpp 5.2
1394         https://bugs.webkit.org/show_bug.cgi?id=150026
1395
1396         Reviewed by Philippe Normand.
1397
1398         Backport upstream patch from gst-plugins-bad so that the right version
1399         of FAAD2 can be found with newer versions of cpp, so that gst-plugins-bad
1400         gets compiled properly, avoiding crashes on runtime while running tests.
1401
1402         * gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Added.
1403         * gtk/jhbuild.modules: Referenced the newly added patch for gst-plugins-bad.
1404
1405 2015-10-11  Myles C. Maxfield  <mmaxfield@apple.com>
1406
1407         Test font-variant-* and font-feature-settings with mocked preinstalled fonts
1408         https://bugs.webkit.org/show_bug.cgi?id=149777
1409
1410         Reviewed by Simon Fraser.
1411
1412         Include FontWithFeatures in DumpRenderTree and WebKitTestRunner. Add it
1413         to the list of tests to preinstall at startup time.
1414
1415         Also, update the generation of the 'name' table in the FontWithFeatures font.
1416
1417         * DumpRenderTree/mac/DumpRenderTree.mm:
1418         (allowedFontFamilySet):
1419         (activateTestingFonts):
1420         (activateFontsIOS):
1421         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
1422         (Generator::generate):
1423         (Generator::appendCFFTable):
1424         (Generator::appendNameSubtable):
1425         (Generator::appendNAMETable):
1426         * FontWithFeatures/FontWithFeatures/main.cpp:
1427         (main):
1428         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1429         (WTR::allowedFontFamilySet):
1430         (WTR::activateFonts):
1431         * WebKitTestRunner/mac/TestControllerMac.mm:
1432         (WTR::allowedFontFamilySet):
1433
1434 2015-10-11  Jinyoung Hur  <hur.ims@navercorp.com>
1435
1436         Unreviewed. Add Jinyoung Hur as a committer.
1437
1438         * Scripts/webkitpy/common/config/contributors.json:
1439
1440 2015-10-10  Dan Bernstein  <mitz@apple.com>
1441
1442         [iOS] Remove unnecessary iOS version checks
1443         https://bugs.webkit.org/show_bug.cgi?id=150002
1444
1445         Reviewed by Alexey Proskuryakov.
1446
1447         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1448         (-[HIDEventGenerator _createIOHIDEventType:]):
1449         (-[HIDEventGenerator _sendHIDEvent:]):
1450         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
1451         * WebKitTestRunner/ios/UIKitSPI.h:
1452
1453 2015-10-09  Myles C. Maxfield  <mmaxfield@apple.com>
1454
1455         Unreviewed, rolling out r190689
1456         https://bugs.webkit.org/show_bug.cgi?id=149992
1457
1458         Fixed in other repository.
1459
1460         Reverted changesets:
1461
1462         "Unreviewed, rolling out r190572, r190593, r190594, and r190639."
1463         https://bugs.webkit.org/show_bug.cgi?id=149897
1464
1465 2015-10-09  Brian Burg  <bburg@apple.com>
1466
1467         Teach webkitperl how to figure out IOS versions from the SDK
1468         https://bugs.webkit.org/show_bug.cgi?id=149963
1469
1470         Reviewed by Daniel Bates.
1471
1472         It should be easier to check the major and minor version of IOS SDKs.
1473
1474         * Scripts/copy-webkitlibraries-to-product-directory: use iosVersion().
1475         * Scripts/webkitdirs.pm:
1476         (splitVersionString): Added.
1477         (determineOSXVersion): Use splitVersionString.
1478         (determineIOSVersion): Added. Look at the SDK version and make a tuple.
1479         (iosVersion): Added.
1480
1481 2015-10-09  Simon Fraser  <simon.fraser@apple.com>
1482
1483         [iOS WK2] Fix some leaks in TestRunnerWKWebView and UIScriptContext
1484         https://bugs.webkit.org/show_bug.cgi?id=149960
1485
1486         Reviewed by Tim Horton.
1487
1488         Use adoptWK(), and null out some members (file is not using ARC).
1489
1490         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
1491         (UIScriptContext::uiScriptComplete):
1492         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1493         (-[TestRunnerWKWebView dealloc]):
1494
1495 2015-10-09  Csaba Osztrogonác  <ossy@webkit.org>
1496
1497         Remove ENABLE_SUID_SANDBOX_LINUX cruft
1498         https://bugs.webkit.org/show_bug.cgi?id=149954
1499
1500         Reviewed by Darin Adler.
1501
1502         * Scripts/webkitperl/FeatureList.pm:
1503
1504 2015-10-09  Daniel Bates  <dabates@apple.com>
1505
1506         Make iOS builders generate debug information in a separate dSYM file
1507         https://bugs.webkit.org/show_bug.cgi?id=149696
1508
1509         Reviewed by Darin Adler.
1510
1511         Similar to the Mac builders, the iOS builders should write debug information
1512         into a separate dSYM file instead of including such information in the binary
1513         itself (default Xcode behavior)
1514
1515         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1516         (CompileWebKit.start):
1517
1518 2015-10-09  Csaba Osztrogonác  <ossy@webkit.org>
1519
1520         Fix webkitpy tests after r190779
1521         https://bugs.webkit.org/show_bug.cgi?id=149949
1522
1523         Reviewed by Ryosuke Niwa.
1524
1525         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
1526         (BenchmarkResults.format):
1527         (BenchmarkResults._format_values):
1528
1529 2015-10-08  Dewei Zhu  <dewei_zhu@apple.com>
1530
1531         Extend run-benchmark script to support human-readable results conversion.
1532         https://bugs.webkit.org/show_bug.cgi?id=149944
1533
1534         Reviewed by Ryosuke Niwa.
1535
1536         Add '--read-results-json' and '--no-adjust-unit' options.
1537         '--read-results-json' option converts result file to human readable format.
1538         '--no-adjust-unit' option skips scientific notation convertion.
1539         '--platform' defaults to 'osx' and '--browser' defaults to 'safari'.
1540
1541         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
1542         (BenchmarkResults.format):
1543         (BenchmarkResults._format_tests):
1544         (BenchmarkResults._format_values):
1545         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1546         (BenchmarkRunner.__init__):
1547         (BenchmarkRunner._run_benchmark):
1548         (BenchmarkRunner._dump):
1549         (BenchmarkRunner.show_results):
1550         (BenchmarkRunner._show_results): Deleted.
1551         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1552         (parse_args):
1553         (start):
1554
1555 2015-10-08  Daniel Bates  <dabates@apple.com>
1556
1557         Add iOS 9 device builder to WebKit Bot Watcher's Dashboard
1558         https://bugs.webkit.org/show_bug.cgi?id=149945
1559
1560         Reviewed by Dan Bernstein.
1561
1562         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9.png: Added.
1563         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9@2x.png: Added.
1564         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1565         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1566         (WebKitBuildbot):
1567         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1568         (table.queue-grid tr.platform.ios-9 img.logo):
1569
1570 2015-10-08  Daniel Bates  <dabates@apple.com>
1571
1572         Teach build-webkit to install LLVM binaries for iOS when building for device with the public iOS SDK
1573         https://bugs.webkit.org/show_bug.cgi?id=149943
1574
1575         Reviewed by Dan Bernstein.
1576
1577         Following the addition of the LLVM binaries for iOS in changeset r190759 (bug #149913) we should
1578         teach build-webkit to install them when building for iOS device using the public iOS SDK.
1579
1580         * Scripts/build-webkit:
1581
1582 2015-10-08  Daniel Bates  <dabates@apple.com>
1583
1584         Add LLVM binaries for iOS 9 device
1585         https://bugs.webkit.org/show_bug.cgi?id=149913
1586
1587         Reviewed by Filip Pizlo.
1588
1589         Implement support for building LLVM for ARM64-based iOS devices.
1590
1591         * Scripts/build-jsc: Enable the FTL when building for Mac or iOS device.
1592         * Scripts/copy-webkitlibraries-to-product-directory: Move logic to clean
1593         an existing build earlier in the file such that remove previously built
1594         libraries before building/copying new ones (if applicable).
1595         (fileContains): Moved function outside of if-block.
1596         (isContentOfFileEqualToString): Renamed; formerly named fileContentsEquals().
1597         (buildLLVM): Added. Extracted machinery to build LLVM into this function and
1598         added logic to build LLVM for ARM64-based iOS devices.
1599         (symlinkLLVMLibrariesIfNeeded): Added. Extracted machinery to symlink the built
1600         LLVM into the WebKitBuild directory.
1601
1602 2015-10-08  Alexey Proskuryakov  <ap@apple.com>
1603
1604         Crash-only queues on bot watcher's dashboard should not have non-crashing tests in popovers
1605         https://bugs.webkit.org/show_bug.cgi?id=149848
1606
1607         Reviewed by Darin Adler.
1608
1609         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1610
1611 2015-10-07  Brent Fulgham  <bfulgham@apple.com>
1612
1613         [Win] Support 64-bit Build and Testing
1614         https://bugs.webkit.org/show_bug.cgi?id=149904
1615
1616         Reviewed by Daniel Bates.
1617
1618         Extend our existing scripts to support 64-bit build and test operations on
1619         Windows.
1620
1621         * Scripts/build-dumprendertree: We don't need to build DRT on its own;
1622         Windows always builds the whole stack.
1623         * Scripts/webkit-build-directory: Add an option to return the location of
1624         the executable files produced by a specific configuration. This change is
1625         actually useful for Gtk and EFL, too.
1626         * Scripts/webkitdirs.pm:
1627         (executableProductDir): Added. This function appends the proper binary
1628         path to the productDir. This is useful for Windows, Gtk, and EFL ports.
1629         (jscProductDir): Use the new 'executableProductDir' method.
1630         (setPathForRunningWebKitApp): Ditto.
1631         (runSafari): Ditto.
1632         (runMiniBrowser): Ditto.
1633         * Scripts/webkitpy/port/factory.py:
1634         (configuration_options): Add a 64-bit option, used on Windows to specify
1635         which binary target should be used for testing.
1636         * Scripts/webkitpy/port/win.py:
1637         (WinPort._port_flag_for_scripts): Added. Supply the 64-bit flag to child
1638         processes when needed.
1639         (WinPort._build_path): Add the correct binary target path to _build_path.
1640         (WinPort._ntsd_location): Check 32-bit paths when running 32-bit tests,
1641         64-bit paths for 64-bit tests.
1642         (WinPort.setup_crash_log_saving): Remove '-e %ld' argument, since the
1643         NTSD debugger does not understand this argument.
1644
1645 2015-10-07  Myles C. Maxfield  <mmaxfield@apple.com>
1646
1647         Test font-variant-* and font-feature-settings with TrueType fonts
1648         https://bugs.webkit.org/show_bug.cgi?id=149776
1649
1650         Reviewed by Simon Fraser.
1651
1652         This test extends our existing FontWithFeatures project to be able to generate a
1653         TrueType font. This font is conceptually similar as the existing OpenType font,
1654         except the feature -> character mapping is different.
1655
1656         The font itself only supports the following characters:
1657         ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
1658         However, the shape of these letters are either an X or a check mark.
1659         The letter "A" always is a check mark.
1660         The letter "B" always is an X.
1661         Each font feature has an letter associated with it. When the font feature is enabled,
1662         that letter is shown as a check mark. For example, when
1663         "kLowerCaseType / kLowerCaseSmallCapsSelector" is enabled, "S" is shown as a check
1664         mark.
1665
1666         Here are the mappings of font features to letters:
1667         kLigaturesType / kCommonLigaturesOnSelector: C
1668         kLigaturesType / kContextualLigaturesOnSelector: D
1669         kLigaturesType / kRareLigaturesOnSelector: G
1670         kLigaturesType / kHistoricalLigaturesOnSelector: I
1671         kContextualAlternatesType / kContextualAlternatesOnSelector: L
1672         kVerticalPositionType / kInferiorsSelector: O
1673         kVerticalPositionType / kSuperiorsSelector: P
1674         kLowerCaseType / kLowerCaseSmallCapsSelector: S
1675         kUpperCaseType / kUpperCaseSmallCapsSelector: V
1676         kLowerCaseType / kLowerCasePetiteCapsSelector: T
1677         kUpperCaseType / kUpperCasePetiteCapsSelector: W
1678         kLetterCaseType / 14: Y
1679         kStyleOptionsType / kTitlingCapsSelector: a
1680         kNumberCaseType / kUpperCaseNumbersSelector: c
1681         kNumberCaseType / kLowerCaseNumbersSelector: d
1682         kNumberSpacingType / kProportionalNumbersSelector: f
1683         kNumberSpacingType / kMonospacedNumbersSelector: g
1684         kFractionsType / kDiagonalFractionsSelector: i
1685         kFractionsType / kVerticalFractionsSelector: j
1686         kVerticalPositionType / kOrdinalsSelector: Q
1687         kTypographicExtrasType / kSlashedZeroOnSelector: k
1688         kLigaturesType / kHistoricalLigaturesOnSelector: K
1689         kCharacterShapeType / kJIS1978CharactersSelector: m
1690         kCharacterShapeType / kJIS1983CharactersSelector: n
1691         kCharacterShapeType / kJIS1990CharactersSelector: o
1692         kCharacterShapeType / kJIS2004CharactersSelector: p
1693         kCharacterShapeType / kSimplifiedCharactersSelector: q
1694         kCharacterShapeType / kTraditionalCharactersSelector: r
1695         kTextSpacingType / kMonospacedTextSelector: t
1696         kTextSpacingType / kProportionalTextSelector: u
1697         kRubyKanaType / kRubyKanaOnSelector: v
1698
1699         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj:
1700         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
1701         (CFFBuilder::moveTo):
1702         (CFFBuilder::lineTo):
1703         (GLYFBuilder::GLYFBuilder):
1704         (GLYFBuilder::takeResult):
1705         (GLYFBuilder::moveTo):
1706         (GLYFBuilder::lineTo):
1707         (GLYFBuilder::closePath):
1708         (GLYFBuilder::writePoint):
1709         (GLYFBuilder::append16):
1710         (generateBoxCharString):
1711         (generateCheckCharString):
1712         (generateXCharString):
1713         (itemForGlyph):
1714         (Generator::generate):
1715         (Generator::insertSelector):
1716         (Generator::insertFeature):
1717         (Generator::generateFeatureDescription):
1718         (Generator::appendCFFTable):
1719         (Generator::appendGLYFTable):
1720         (Generator::appendLOCATable):
1721         (Generator::appendFEATTable):
1722         (Generator::appendMetamorphosisChain):
1723         (Generator::appendMORXTable):
1724         (Generator::appendHEADTable):
1725         (Generator::appendHMTXTable):
1726         (Generator::appendNameSubtable):
1727         (Generator::append2ByteASCIIString):
1728         (Generator::appendNAMETable):
1729         (generateFont):
1730         (CFFBuilder::curveToCubic): Deleted.
1731         (charStringForGlyph): Deleted.
1732         * FontWithFeatures/FontWithFeatures/FontCreator.h:
1733         * FontWithFeatures/FontWithFeatures/main.cpp:
1734         (constructFontWithTrueTypeFeature):
1735         (constructFontWithOpenTypeFeature):
1736         (drawText):
1737         (main):
1738         (drawTextWithFeature): Deleted.
1739
1740 2015-10-07  Commit Queue  <commit-queue@webkit.org>
1741
1742         Unreviewed, rolling out r190572, r190593, r190594, and
1743         r190639.
1744         https://bugs.webkit.org/show_bug.cgi?id=149897
1745
1746         Breaks Mavericks build (Requested by litherum on #webkit).
1747
1748         Reverted changesets:
1749
1750         "Allow WKRetainPtrs to be used as keys in hashing data
1751         structures"
1752         https://bugs.webkit.org/show_bug.cgi?id=149762
1753         http://trac.webkit.org/changeset/190572
1754
1755         "REGRESSION(189668?): http/tests/notifications/events.html
1756         flakily asserts or times out"
1757         https://bugs.webkit.org/show_bug.cgi?id=149218
1758         http://trac.webkit.org/changeset/190593
1759
1760         "Prospective Mavericks build fix."
1761         http://trac.webkit.org/changeset/190594
1762
1763         "Post-review cleanup after r190572."
1764         http://trac.webkit.org/changeset/190639
1765
1766 2015-10-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1767
1768         [GTK] Add autocleanups
1769         https://bugs.webkit.org/show_bug.cgi?id=149588
1770
1771         Reviewed by Darin Adler.
1772
1773         * TestWebKitAPI/Tests/WebKit2Gtk/AutocleanupsTest.cpp: Added.
1774         (AutocleanupsTest::create):
1775         (AutocleanupsTest::testWebProcessAutocleanups):
1776         (registerTests):
1777         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1778         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutocleanups.cpp: Added.
1779         (testUIProcessAutocleanups):
1780         (testWebProcessAutocleanups):
1781         (beforeAll):
1782         (afterAll):
1783
1784 2015-10-06  Brian Burg  <bburg@apple.com>
1785
1786         Unreviewed, try to fix the iOS 8 build after r190368.
1787
1788         On older versions, IOHIDEventCreateForceEvent is not available.
1789
1790         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1791         (-[HIDEventGenerator _createIOHIDEventType:]): Add another guard for force events.
1792
1793 2015-10-06  Keith Miller  <keith_miller@apple.com>
1794
1795         Add gmalloc option to run-javascriptcore-tests.
1796         https://bugs.webkit.org/show_bug.cgi?id=149858
1797
1798         Reviewed by Geoffrey Garen.
1799
1800         run-javascriptcore-tests takes a new option --gmalloc with an optional string argument, the path to the gmalloc dylib.
1801         If no argument is provided then /usr/lib/libgmalloc.dylib is used by default.
1802
1803         * Scripts/run-javascriptcore-tests:
1804
1805 2015-10-06  Myles C. Maxfield  <mmaxfield@apple.com>
1806
1807         Post-review cleanup after r190572.
1808
1809         Unreviewed.
1810
1811         * TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp:
1812
1813 2015-10-06  Brent Fulgham  <bfulgham@apple.com>
1814
1815         [Win] Unreviewed build correction.
1816
1817         * TestWebKitAPI/PlatformWin.cmake: We don't need to link to all of these libraries. Most
1818         are soft-linked at runtime.
1819
1820 2015-10-06  Keith Miller  <keith_miller@apple.com>
1821
1822         Fix run-javascriptcore-tests/run-jsc-stress-tests to work with rootless, add a --quick option and deprecate the Mozilla driver.
1823         https://bugs.webkit.org/show_bug.cgi?id=149815
1824
1825         Reviewed by Filip Pizlo.
1826
1827         Rootless has an issue where it will strip any environment variables that start with DYLD starting a perl/ruby/python script.
1828         Now, run-jsc-stress-tests takes an new argument, --env-vars, that will set the specified environment variables before
1829         running tests. Additionally, I added a quick option that only runs default and the NoCJITValidate versions of each test.
1830         Finally, I removed the calls to the mozilla jsDriver.pl since the run-jsc-stress-tests runner runs the same test suite
1831         so should just use one test runner.
1832
1833         * Scripts/run-javascriptcore-tests:
1834         (runJSCStressTests):
1835         (runMozillaTests): Deleted.
1836         (defaultJsDriverArgsForMozillaTests): Deleted.
1837         * Scripts/run-jsc-stress-tests:
1838
1839 2015-10-06  Mark Salisbury  <mark.salisbury@hp.com>
1840
1841         [GTK] Make update-webkitgtk-libs work behind firewall
1842
1843         update-webkitgtk-libs can work behind a firewall with changes to
1844         a few packages.  Where outbound git and active FTP connections
1845         fail, using http protocol succeeds.  Most packages are
1846         already accessed using http.
1847
1848         https://bugs.webkit.org/show_bug.cgi?id=148941
1849
1850         Reviewed by Martin Robinson.
1851
1852         Tools
1853         * gtk/jhbuild.modules:
1854             Replace git URLs with http.  Remove no longer used ftp repositories.
1855             Update argument for libxml2's autogen.sh script (--without-python
1856             is ignored; --with-python=no is correct).
1857         * jhbuild/jhbuild-wrapper:
1858             Instead of connecting to git://git.gnome.org/jhbuild, connect to
1859             http://git.gnome.org/browse/jhbuild.
1860
1861 2015-10-06  Daniel Bates  <dbates@webkit.org>
1862
1863         Enable XSLT when building WebKit for iOS using the public iOS SDK
1864         https://bugs.webkit.org/show_bug.cgi?id=149827
1865
1866         Reviewed by Alexey Proskuryakov.
1867
1868         Teach script configure-xcode-for-ios-development to copy the OS X XSLT headers to the iPhoneOS
1869         and iPhoneSimulator SDKs so as to support building WebKit for iOS with XSLT. A person must
1870         run this script before building WebKit for iOS or the build will fail because one or more XSLT
1871         headers cannot be found.
1872
1873         * Scripts/configure-xcode-for-ios-development:
1874         (copyMissingXSLTHeadersToSDKIfNeeded): Added.
1875
1876 2015-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
1877
1878         REGRESSION(189668?): http/tests/notifications/events.html flakily asserts or times out
1879         https://bugs.webkit.org/show_bug.cgi?id=149218
1880
1881         Reviewed by Alexey Proskuryakov.
1882
1883         Because of r189668, WebKitTestRunner now tears down and recreates its WKNotificationManagerRef
1884         when the TestOptions change. Previously, WebNotificationProvider only could handle a single
1885         WKNotificationManagerRef. Because the ower of the WKNotificationManagerRef is reference counted,
1886         and AppKit internally retains some objects which end up retaining the WKNotificationManagerRef,
1887         the old WKNotificationManager may not be destroyed before the new one is created. Therefore,
1888         WebNotificationProvider must be updated to appropriately handle multiple
1889         WKNotificationManagerRefs in flight at the same time.
1890
1891         * WebKitTestRunner/WebNotificationProvider.cpp:
1892         (WTR::WebNotificationProvider::~WebNotificationProvider):
1893         (WTR::WebNotificationProvider::showWebNotification):
1894         (WTR::WebNotificationProvider::closeWebNotification):
1895         (WTR::WebNotificationProvider::addNotificationManager):
1896         (WTR::WebNotificationProvider::removeNotificationManager):
1897         (WTR::WebNotificationProvider::simulateWebNotificationClick):
1898         (WTR::WebNotificationProvider::reset):
1899         * WebKitTestRunner/WebNotificationProvider.h:
1900
1901 2015-10-05  Daniel Bates  <dabates@apple.com>
1902
1903         Disable Bitcode when building for iOS device
1904         https://bugs.webkit.org/show_bug.cgi?id=149818
1905
1906         Reviewed by Alexey Proskuryakov.
1907
1908         Xcode 7 generates bitcode for iOS device apps by default. Do not generate bitcode
1909         when building for iOS device.
1910
1911         * Scripts/webkitdirs.pm:
1912         (XcodeOptions):
1913
1914 2015-10-05  Daniel Bates  <dabates@apple.com>
1915
1916         [iOS] Make it possible to build WebKit using iphoneos SDK without a developer certificate installed
1917         https://bugs.webkit.org/show_bug.cgi?id=140828
1918         <rdar://problem/19520599>
1919
1920         Reviewed by Alexey Proskuryakov.
1921
1922         Support building WebKit for iOS device without an iOS Developer certificate installed. Otherwise,
1923         we will pass CODE_SIGN_IDENTITY="iPhone Developer: " to Xcode to find a iOS Developer certificate
1924         to use. To use a specific installed iOS Developer certificate, explicitly pass CODE_SIGN_IDENTITY
1925         to build-webkit.
1926
1927         * Scripts/webkitdirs.pm:
1928         (XcodeOptions): Cleaned up code. When building for iOS device, pass to Xcode CODE_SIGN_IDENTITY="iPhone Developer: "
1929         to code sign using the installed iOS development certificate (if it exists - we assume there is only one such certificate).
1930         Otherwise, pass CODE_SIGN_IDENTITY="" and CODE_SIGNING_REQUIRED=NO to Xcode to disable code signing.
1931         (hasIOSDevelopmentCertificate): Added.
1932
1933 2015-10-05  Daniel Bates  <dabates@apple.com>
1934
1935         DumpRenderTree built with public iOS SDK crashes under -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
1936         https://bugs.webkit.org/show_bug.cgi?id=149766
1937
1938         Reviewed by Alexey Proskuryakov.
1939
1940         Create network storage testing session on iOS.
1941
1942         Currently we do not create a network storage testing session on iOS. A network storage testing session always
1943         has an associated cookie store. When WebKit is built without USE(CFNETWORK), NetworkStorageSession::defaultStorageSession().cookieStorage()
1944         returns nullptr because the caller is expected to interact with NSHTTPCookieStorage instead of querying
1945         NetworkStorageSession for the cookie store. When WebKit is built with USE(CFNETWORK) accessing
1946         NetworkStorageSession::defaultStorageSession().cookieStorage() returns a valid cookie store (creating one if
1947         it does not exist). Instead we should make use of NetworkStorageSession::switchToNewTestingSession() to
1948         create a network storage testing session when building DumpRenderTree for iOS so as to ensure a consistent
1949         testing environment regardless of whether we built with USE(CFNETWORK). This will also make the behavior of
1950         DumpRenderTree on iOS more consistent with the behavior of DumpRenderTree on Mac.
1951
1952         As a side effect of this change DumpRenderTree no longer crashes in -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
1953         when WebKit is built without USE(CFNETWORK) because NetworkStorageSession::defaultStorageSession().cookieStorage()
1954         returns a non-null pointer to a cookie store.
1955
1956         * DumpRenderTree/mac/DumpRenderTree.mm:
1957         (prepareConsistentTestingEnvironment):
1958
1959 2015-10-05  Simon Fraser  <simon.fraser@apple.com>
1960
1961         Fix the iOS 8 build again, where -[UIApplication _enqueueHIDEvent:] is not
1962         available.
1963
1964         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1965         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
1966
1967 2015-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
1968
1969         Allow WKRetainPtrs to be used as keys in hashing data structures
1970         https://bugs.webkit.org/show_bug.cgi?id=149762
1971
1972         Reviewed by Anders Carlsson.
1973
1974         * TestWebKitAPI/PlatformGTK.cmake:
1975         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1976         * TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp: Added.
1977         (TestWebKitAPI::TEST):
1978
1979 2015-10-05  Simon Fraser  <simon.fraser@apple.com>
1980
1981         Fix the iOS 8 build, where -[UIApplication _enqueueHIDEvent:] is not
1982         available, and tidy up the #ifdefs in the UIKitSPI header.
1983
1984         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1985         (-[HIDEventGenerator _sendHIDEvent:]):
1986         * WebKitTestRunner/ios/UIKitSPI.h:
1987
1988 2015-10-04  Zan Dobersek  <zdobersek@igalia.com>
1989
1990         [GTK] Remove duplicate entries in WebKitTestRunner_SOURCES
1991         https://bugs.webkit.org/show_bug.cgi?id=149792
1992
1993         Reviewed by Martin Robinson.
1994
1995         * WebKitTestRunner/PlatformGTK.cmake: Don't list build targets
1996         for WebKitTestRunner multiple times.
1997
1998 2015-10-04  Daniel Bates  <dabates@apple.com>
1999
2000         Fix the Apple Internal iOS build after <http://trac.webkit.org/changeset/190515>
2001         (https://bugs.webkit.org/show_bug.cgi?id=149753)
2002
2003         For now, support calling build-layouttestrelay without --ios-simulator so long
2004         as we are building on a Mac.
2005
2006         * Scripts/build-layouttestrelay:
2007
2008 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
2009
2010         Support Trac 1.0.x XML timeline link format
2011         https://bugs.webkit.org/show_bug.cgi?id=149786
2012
2013         Reviewed by Lucas Forschler.
2014
2015         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2016         (Trac.prototype._convertCommitInfoElementToObject):
2017
2018 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
2019
2020         Fix some errors on bot watcher's dashboard
2021         https://bugs.webkit.org/show_bug.cgi?id=149789
2022
2023         Reviewed by Lucas Forschler.
2024
2025         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2026         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): We may not get to layout
2027         tests step, in which case layoutTestResults.tooManyFailures would raise an exception.
2028
2029 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
2030
2031         Bot watcher's dashboard builders should turn yellow when svn fails
2032         https://bugs.webkit.org/show_bug.cgi?id=149791
2033
2034         Reviewed by Lucas Forschler.
2035
2036         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2037         (BuildbotBuilderQueueView.prototype.appendBuilderQueueStatus):
2038         (BuildbotBuilderQueueView.prototype.update):
2039
2040 2015-10-02  Daniel Bates  <dabates@apple.com>
2041
2042         Add iOS 9 Simulator builders and testers to WebKit Bot Watcher's Dashboard
2043         https://bugs.webkit.org/show_bug.cgi?id=149769
2044
2045         Reviewed by Alexey Proskuryakov.
2046
2047         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator.png: Added.
2048         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator@2x.png: Added.
2049         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2050         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2051         (WebKitBuildbot):
2052         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2053         (table.queue-grid tr.platform.ios-simulator-9 img.logo):
2054
2055 2015-10-02  Ryosuke Niwa  <rniwa@webkit.org>
2056
2057         REGRESSION(r190370): Speedometer spits out an extra console message
2058         https://bugs.webkit.org/show_bug.cgi?id=149720
2059
2060         Unreviewed. Temporarily ignore the console error message.
2061
2062         * Scripts/webkitpy/performance_tests/perftest.py:
2063         (PerfTest._filter_output):
2064
2065 2015-10-02  Brent Fulgham  <bfulgham@apple.com>
2066
2067         Provide "--no-ninja" option to avoid using Ninja
2068         https://bugs.webkit.org/show_bug.cgi?id=149757
2069
2070         Reviewed by Alex Christensen.
2071
2072         Add a new command line argument understood by webkitdirs.pm so
2073         that we can conditionally avoid using Ninja. This is an
2074         'opt-out' argument, so no existing Ninja users should be affected.
2075
2076         * Scripts/webkitdirs.pm:
2077         (canUseNinja): Check for option and block ninja if present.
2078
2079 2015-10-02  Aakash Jain  <aakash_jain@apple.com>
2080
2081         Flakiness dashboard should support OS X El Capitan
2082         https://bugs.webkit.org/show_bug.cgi?id=149648
2083
2084         Reviewed by Alexey Proskuryakov.
2085
2086         * TestResultServer/static-dashboards/flakiness_dashboard.js: Fix the broken dashboard for ElCapitan.
2087
2088 2015-10-02  Daniel Bates  <dabates@apple.com>
2089
2090         Fix run-webkit-tests --ios-simulator after <http://trac.webkit.org/changeset/190515>
2091         (https://bugs.webkit.org/show_bug.cgi?id=149753)
2092
2093         For now, pass --ios-simulator.
2094
2095         * Scripts/webkitpy/port/ios.py:
2096         (IOSSimulatorPort._build_relay):
2097
2098 2015-10-02  Simon Fraser  <simon.fraser@apple.com>
2099
2100         Remove a "nullable" that breaks the iOS 8 build.
2101
2102         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2103         (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]):
2104
2105 2015-10-02  Daniel Bates  <dabates@apple.com>
2106
2107         LayoutTestRelay is not built and archived when building for iOS Simulator
2108         https://bugs.webkit.org/show_bug.cgi?id=149753
2109
2110         Reviewed by Alexey Proskuryakov and Andy Estes.
2111
2112         Towards running layout tests on the iOS Simulator test bots, we need to teach scripts build-webkit
2113         and built-product-archive to build the Mac tool LayoutTestRelay and include this tool in the built
2114         product archive when building for iOS Simulator, respectively.
2115
2116         * BuildSlaveSupport/built-product-archive:
2117         (main): Pass the full platform name (options.platform) to archiveBuiltProduct() so that it can
2118         differentiate between iOS device and iOS Simulator platforms.
2119         (webkitBuildDirectoryForConfigurationAndPlatform): Extracted logic to run the script webkit-build-directory
2120         from determineWebKitBuildDirectories() into this function so that it can be used by both
2121         determineWebKitBuildDirectories() and archiveBuiltProduct().
2122         (determineWebKitBuildDirectories): Moved logic to execute the script webkit-build-directory from here to
2123         webkitBuildDirectoryForConfigurationAndPlatform().
2124         (createZip): Added parameter embedParentDirectoryNameOnDarwin (defaults to False) to specify whether
2125         we should call ditto(1) with --keepParent to embed the parent directory name in the zip archive. This
2126         argument is only applicable when building on Darwin. We only pass embedParentDirectoryNameOnDarwin=True
2127         when making an archive for a Mac or iOS device build. For iOS Simulator builds we archive two directories
2128         and we do not want to keep the parent directory because it is a placeholder directory used as a workaround
2129         for the limitation that ditto(1) can only accept a single directory to archive on its command line.
2130         (archiveBuiltProduct): Modified to take the full platform name as an argument. Added logic for iOS.
2131         For iOS device builds we use the same logic as for a Mac build and archive the configuration-specific
2132         build directory. For iOS Simulator builds we archive the configuration-specific iOS build directory,
2133         LayoutTestRelay and LayoutTestRelay.dSYM (if it exists) from the configuration-specific Mac build.
2134         * Scripts/build-layouttestrelay:
2135             - Remove unnecessary include of Perl module POSIX.
2136             - Only build LayoutTestRelay when building for iOS Simulator (i.e. --ios-simulator is passed).
2137         * Scripts/build-webkit:
2138             - Invoke script build-layouttestrelay when building for iOS Simulator.
2139
2140 2015-10-02  Brent Fulgham  <bfulgham@apple.com>
2141
2142         [Win] Unreviewed test fix.
2143
2144         You cannot run 'run-webkit-tests' from the command line because it does not know
2145         to append the binary subdirectory (bin32/bin64). We don't see this on our builders
2146         because they explicitly set use the 'root' argument to provide the full path to
2147         the test binaries.
2148
2149         * Scripts/webkitpy/port/win.py:
2150         (WinPort._build_path): Added.
2151
2152 2015-10-02  Alex Christensen  <achristensen@webkit.org>
2153
2154         Reloading without content blockers doesn't apply to resource loads after the main frame finishes
2155         https://bugs.webkit.org/show_bug.cgi?id=149430
2156         rdar://problem/22742222
2157
2158         Reviewed by Geoffrey Garen.
2159
2160         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2161         (WTR::TestController::cocoaResetStateToConsistentValues):
2162         * WebKitTestRunner/mac/TestControllerMac.mm:
2163         (WTR::TestController::platformConfigureViewForTest):
2164         Test what happens when you disable content blockers from the SPI.
2165
2166 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
2167
2168         [Win] Unreviewed build fix for run-api-tests
2169
2170         * Scripts/run-api-tests:
2171         (testToolPaths): Windows run needs to specify the binary path.
2172
2173 2015-10-01  Daniel Bates  <dabates@apple.com>
2174
2175         Another attempt to fix the Windows builders after <https://trac.webkit.org/changeset/190387>
2176         (https://bugs.webkit.org/show_bug.cgi?id=149695)
2177
2178         Following r190424 we can now rely on webkit-build-directory to return the path to
2179         the correct configuration-specific build directory on Windows.
2180
2181         * BuildSlaveSupport/built-product-archive:
2182         (archiveBuiltProduct):
2183
2184 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
2185
2186         [Win] Unreviewed build fix.
2187
2188         * Scripts/webkitdirs.pm:
2189         (setupAppleWinEnv): Use 64-bit build tools if available
2190
2191 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
2192
2193         [Win] Fix TestWebKitAPI build under CMake.
2194
2195         Reviewed by Alex Christensen.
2196
2197         * TestWebKitAPI/PlatformWin.cmake: Add missing link command
2198         for Psapi.lib.
2199
2200 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
2201
2202         [Win] Fix behavior of webkit-build-directory script
2203         https://bugs.webkit.org/show_bug.cgi?id=149718
2204
2205         Reviewed by Alex Christensen.
2206
2207         * Scripts/webkitdirs.pm:
2208         (determineConfigurationProductDir): Do not include the binary
2209         sub-directory in the configuration product directory output.
2210         (jscProductDir): Append correct binary path for Windows build.
2211         (setPathForRunningWebKitApp): Include properly binary subdirectories.
2212         (runSafari): Update for revised productDir behavior.
2213         (runMiniBrowser): Ditto.
2214
2215 2015-10-01  Alexey Proskuryakov  <ap@apple.com>
2216
2217         Stop building LayoutTestRelay for now. It's a Mac project, but build-webkit tries to
2218         use iOS SDK, like with all the others.
2219
2220         * Scripts/build-webkit:
2221
2222 2015-10-01  Daniel Bates  <dabates@apple.com>
2223
2224         Attempt to fix the iOS 9 Simulator testers
2225
2226         Add dependency DumpRenderTree.app to target All of project DumpRenderTree so that we
2227         build DumpRenderTree.app, if applicable. Also, teach build-webkit to build project
2228         LayoutTestRelay when building for iOS Simulator.
2229
2230         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2231         * Scripts/build-webkit:
2232
2233 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2234
2235         [GTK] Websites with invalid auth header keep loading forever
2236         https://bugs.webkit.org/show_bug.cgi?id=149710
2237
2238         Reviewed by Martin Robinson.
2239
2240         Add test case to check that we can authenticate sites with an
2241         empty realm.
2242
2243         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
2244         (testWebViewAuthenticationEmptyRealm):
2245         (serverCallback):
2246         (beforeAll):
2247
2248 2015-10-01  Alexey Proskuryakov  <ap@apple.com>
2249
2250         [Mac] Make run-api-tests work with System Integrity Protection
2251         https://bugs.webkit.org/show_bug.cgi?id=149711
2252         rdar://problem/22928202
2253
2254         Reviewed by Dan Bernstein.
2255
2256         * Scripts/run-api-tests:
2257         (runTest):
2258         (archCommandLineArgumentsForRestrictedEnvironmentVariables):
2259
2260 2015-10-01  Daniel Bates  <dabates@apple.com>
2261
2262         Attempt to fix the Windows build after <https://trac.webkit.org/changeset/190387>
2263         (https://bugs.webkit.org/show_bug.cgi?id=149695)
2264
2265         For some reason built-product-archive hardcodes the assumption that we build for 32-bit Windows.
2266         For now, use the path to the top-level WebKit build directory instead of using the configuration-
2267         specific build directory.
2268
2269         * BuildSlaveSupport/built-product-archive:
2270         (archiveBuiltProduct):
2271
2272 2015-10-01  Csaba Osztrogonác  <ossy@webkit.org>
2273
2274         [EFL] Fix the openwebrtc and gst-plugins-openwebrtc build with clang
2275         https://bugs.webkit.org/show_bug.cgi?id=145837
2276
2277         Reviewed by Philippe Normand.
2278
2279         * efl/jhbuild.modules:
2280         * efl/patches/openwebrtc-clang-warning-fix.patch: Added.
2281         * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Added.
2282
2283 2015-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2284
2285         Unreviewed. Fix the iOS build after r190407.
2286
2287         * WebKitTestRunner/ios/IOKitSPI.h:
2288
2289 2015-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2290
2291         Implement keyboard event sending for iOS in WebKitTestRunner
2292         https://bugs.webkit.org/show_bug.cgi?id=149676
2293
2294         Reviewed by Simon Fraser.
2295
2296         Adds support for generating and sending key events in WebKitTestRunner. This is accomplished in a similar
2297         way as touch events, using IOHIDEvent machinery. Also adds callbacks to the UIScriptController JS API that
2298         allows us to run code when the keyboard is shown or hidden.
2299
2300         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Adds the typeCharacter JS interface.
2301         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
2302         (WTR::UIScriptController::setDidShowKeyboardCallback):
2303         (WTR::UIScriptController::didShowKeyboardCallback):
2304         (WTR::UIScriptController::setDidHideKeyboardCallback):
2305         (WTR::UIScriptController::didHideKeyboardCallback):
2306         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
2307         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
2308         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
2309         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
2310         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2311         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2312         (-[TestRunnerWKWebView initWithFrame:configuration:]): Registers the TestRunnerWKWebView to listen to
2313                 the notifications that the keyboard has been raised or lowered.
2314         (-[TestRunnerWKWebView _keyboardDidShow:]):
2315         (-[TestRunnerWKWebView _keyboardDidHide:]):
2316         * WebKitTestRunner/ios/HIDEventGenerator.h:
2317         * WebKitTestRunner/ios/HIDEventGenerator.m:
2318         (-[HIDEventGenerator _sendIOHIDKeyboardEvent:usage:isKeyDown:]): Helper to send a HID keyboard event.
2319         (shouldWrapWithShiftKeyEventForCharacter): Helper used to generate key events.
2320         (hidUsageCodeForCharacter): Ditto.
2321         (-[HIDEventGenerator keyDown:completionBlock:]): Synthesizes and sends HIDKeyboardEvents, triggering
2322                 a keyDown event in WebKit.
2323         * WebKitTestRunner/ios/IOKitSPI.h:
2324         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2325
2326 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2327
2328         Unreviewed, rolling out r190399.
2329
2330         Tests are still failing even after r190362
2331
2332         Reverted changeset:
2333
2334         "Unreviewed. Unskip GTK+ user media unit tests after r190362."
2335         http://trac.webkit.org/changeset/190399
2336
2337 2015-10-01  Csaba Osztrogonác  <ossy@webkit.org>
2338
2339         [jhbuild] switch to new upstream usrsctp library
2340         https://bugs.webkit.org/show_bug.cgi?id=149494
2341
2342         Reviewed by Philippe Normand.
2343
2344         * efl/jhbuild.modules:
2345         * gtk/jhbuild.modules:
2346
2347 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2348
2349         Unreviewed. Unskip GTK+ user media unit tests after r190362.
2350
2351         They should pass now.
2352
2353         * Scripts/run-gtk-tests:
2354         (TestRunner):
2355
2356 2015-09-30  Daniel Bates  <dabates@apple.com>
2357
2358         Another attempt to fix the build after <https://trac.webkit.org/changeset/190387>
2359         (https://bugs.webkit.org/show_bug.cgi?id=149695)
2360
2361         * BuildSlaveSupport/built-product-archive:
2362         (determineWebKitBuildDirectories): Substitute _configurationBuildDirectory for _buildDirectory.
2363         (extractBuiltProduct): Substitute _topLevelBuildDirectory for _buildDirectory.
2364
2365 2015-09-30  Daniel Bates  <dabates@apple.com>
2366
2367         Attempt to fix the build after <https://trac.webkit.org/changeset/190387>
2368         (https://bugs.webkit.org/show_bug.cgi?id=149695)
2369
2370         Actually, we need to pass --configuration to script webkit-build-directory to have
2371         it return the path to the configuration-specific build directory.
2372
2373         * BuildSlaveSupport/built-product-archive:
2374         (determineWebKitBuildDirectories):
2375
2376 2015-09-30  Daniel Bates  <dabates@apple.com>
2377
2378         built-product-archive archives incorrect build directory for iOS port
2379         https://bugs.webkit.org/show_bug.cgi?id=149695
2380
2381         Reviewed by Darin Adler.
2382
2383         Fixes an issue where the script built-product-archive archives a non-existent
2384         build directory for the iOS port. Without loss of generality, the script assumes
2385         the path to the Release configuration build for iOS is in directory WebKitBuild/Release.
2386         But the built products for this configuration are in directory WebKitBuild/Release-iphonesimulator.
2387
2388         Currently the script built-product-archive calls `webkit-build-directory --top-level ...`
2389         to determine the top-level build directory and computes the configuration-specific
2390         build directory to be the concatenation of the the top-level build directory and
2391         the configuration (e.g. Release). This is incorrect. Instead we should call
2392         webkit-build-directory omitting the flag --top-level to compute the path to the
2393         configuration-specific build directory.
2394
2395         * BuildSlaveSupport/built-product-archive: Fix up the style such that we use single quoted literals.
2396         (main): Renamed global variable _buildDirectory to _topLevelBuildDirectory to better describe
2397         its purpose and added global variable _configurationBuildDirectory to store the path
2398         to the configuration-specific build directory. Ensure that we have a non-empty string
2399         for both the top-level and configuration-specific build directories.
2400         (determineWebKitBuildDirectories): Formerly named determineWebKitBuildDirectory.
2401         Compute the configuration-specific build directory and store it in the global variable
2402         _configurationBuildDirectory.
2403         (archiveBuiltProduct): Modified to use _configurationBuildDirectory.
2404         (extractBuiltProduct): Modified to use _configurationBuildDirectory and _topLevelBuildDirectory
2405         as needed.
2406         (determineWebKitBuildDirectory): Deleted.
2407
2408 2015-09-30  Hunseop Jeong  <hs85.jeong@samsung.com>
2409
2410         [EFL] css3/device-adapt/* tests failed after r190335.
2411         https://bugs.webkit.org/show_bug.cgi?id=149655
2412
2413         Reviewed by Simon Fraser.
2414
2415         device-adapt/* tests need the fixedLayout option but useFixedLayout option is
2416         overwritten by updatePlatformSpecificViewOptionsForTest after r190335.
2417
2418         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2419         (WTR::shouldUseFixedLayout):
2420
2421 2015-09-30  Dewei Zhu  <dewei_zhu@apple.com>
2422
2423         Extend JetStream timeout for slow devices.
2424
2425         Reviewed by Chris Dumez.
2426
2427         Extend JetStream timeout to 20 minutes.
2428
2429         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
2430
2431 2015-09-30  Daniel Bates  <dabates@apple.com>
2432
2433         Rename iOS builders/testers to include version
2434         https://bugs.webkit.org/show_bug.cgi?id=149685
2435
2436         Reviewed by Simon Fraser.
2437
2438         Substitute "Apple iOS 9" for "Apple iOS" in the names of iOS builders/testers so as
2439         make it clear to a reader the version of iOS these builders/testers are using.
2440
2441         * BuildSlaveSupport/build.webkit.org-config/config.json:
2442         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2443
2444 2015-09-30  Daniel Bates  <dabates@apple.com>
2445
2446         Add iOS criterion for triggering a build
2447         https://bugs.webkit.org/show_bug.cgi?id=149679
2448
2449         Rubber-stamped by Alexey Proskuryakov.
2450
2451         First pass at defining criterion for triggering an iOS build.
2452
2453         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2454         (_should_file_trigger_build):
2455         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2456         (ShouldBuildTest):
2457         (ShouldBuildTest.test_should_build):
2458
2459 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
2460
2461         [iOS] Allow tests to generate user gestures for UI testing
2462         https://bugs.webkit.org/show_bug.cgi?id=149653
2463
2464         Reviewed by Tim Horton.
2465
2466         Expose functionality in UIScriptController to allow for testing single- and double-tap,
2467         and to listen for completion of scrolling and zooming in the WKWebView.
2468
2469         Tap generation is done using synthetic IOHIDEvents, via a new HIDEventGenerator class
2470         which hides the complexity of creating these events. Event dispatch is asynchronous.
2471         We detect when the last event has been handled by dispatching a vendor-specific event,
2472         which is detected via -_handleHIDEvent: in our UIApplication subclass.
2473
2474         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Link with IOKit.
2475         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Two new properties
2476         for 'will begin zooming' and 'did end zooming' callbacks, and functions to dispatch
2477         single and double taps.
2478         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
2479         (UIScriptContext::registerCallback): Used to store the callbacks for zooming.
2480         Unlike the "task" callbacks, these are persistent, but we store them in the same hash map.
2481         (UIScriptContext::unregisterCallback):
2482         (UIScriptContext::callbackWithID):
2483         (UIScriptContext::fireCallback):
2484         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
2485         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
2486         (WTR::UIScriptController::setWillBeginZoomingCallback): Cross-platform code.
2487         (WTR::UIScriptController::willBeginZoomingCallback): Ditto.
2488         (WTR::UIScriptController::setDidEndZoomingCallback):
2489         (WTR::UIScriptController::didEndZoomingCallback):
2490         (WTR::UIScriptController::singleTapAtPoint): Non-iOS stub.
2491         (WTR::UIScriptController::doubleTapAtPoint): Ditto.
2492         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
2493         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
2494         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
2495         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2496         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Properties for the zooming callbacks.
2497         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2498         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]): Dispatch the zooming callback.
2499         (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]): Ditto.
2500         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]): Ditto.
2501         (-[TestRunnerWKWebView onDidEndZooming:]): Deleted.
2502         * WebKitTestRunner/ios/HIDEventGenerator.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
2503         * WebKitTestRunner/ios/HIDEventGenerator.m: Added.
2504         (simpleDragCurve):
2505         (calculateNextLocation):
2506         (delayBetweenMove):
2507         (+[HIDEventGenerator sharedHIDEventGenerator]):
2508         (+[HIDEventGenerator nextEventCallbackID]):
2509         (-[HIDEventGenerator init]):
2510         (-[HIDEventGenerator _createIOHIDEventType:]):
2511         (-[HIDEventGenerator _sendHIDEvent:]):
2512         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
2513         (-[HIDEventGenerator _updateTouchPoints:count:]):
2514         (-[HIDEventGenerator touchDownAtPoints:touchCount:]):
2515         (-[HIDEventGenerator touchDown:touchCount:]):
2516         (-[HIDEventGenerator touchDown:]):
2517         (-[HIDEventGenerator liftUpAtPoints:touchCount:]):
2518         (-[HIDEventGenerator liftUp:touchCount:]):
2519         (-[HIDEventGenerator liftUp:]):
2520         (-[HIDEventGenerator moveToPoints:touchCount:duration:]):
2521         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
2522         (-[HIDEventGenerator tap:completionBlock:]):
2523         (-[HIDEventGenerator doubleTap:completionBlock:]):
2524         (-[HIDEventGenerator twoFingerTap:completionBlock:]):
2525         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
2526         (-[HIDEventGenerator pinchCloseWithStartPoint:endPoint:duration:completionBlock:]):
2527         (-[HIDEventGenerator pinchOpenWithStartPoint:endPoint:duration:completionBlock:]):
2528         (-[HIDEventGenerator markerEventReceived:]):
2529         * WebKitTestRunner/ios/IOKitSPI.h: Added.
2530         * WebKitTestRunner/ios/UIKitSPI.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
2531         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2532         (WTR::globalToContentCoordinates):
2533         (WTR::UIScriptController::singleTapAtPoint):
2534         (WTR::UIScriptController::doubleTapAtPoint):
2535         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
2536         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
2537         * WebKitTestRunner/ios/mainIOS.mm:
2538         (-[WebKitTestRunnerApp _handleHIDEvent:]):
2539
2540 2015-09-30  Dana Burkart  <dburkart@apple.com>
2541
2542         git-add-reviewer should trim trailing spaces/newlines
2543         https://bugs.webkit.org/show_bug.cgi?id=149513
2544
2545         Reviewed by Darin Adler.
2546
2547         * Scripts/git-add-reviewer:
2548         (nonInteractive):
2549
2550 2015-09-30  Eric Carlson  <eric.carlson@apple.com>
2551
2552         REGRESSION(r190262): User media unit test failures after r190262
2553         https://bugs.webkit.org/show_bug.cgi?id=149580
2554
2555         Reviewed by Darin Adler.
2556
2557         * WebKitTestRunner/TestController.cpp:
2558         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Fix parameter
2559           order to WKUserMediaPermissionRequestAllow.
2560
2561 2015-09-30  Daniel Bates  <dabates@apple.com>
2562
2563         Add iOS builders and testers
2564         https://bugs.webkit.org/show_bug.cgi?id=149549
2565
2566         Reviewed by Alexey Proskuryakov.
2567
2568         Adds definitions for 64-bit iOS Simulator release builders and testers and a iOS device
2569         builder that builds universal release binaries for armv7, armv7s and arm64 architectures.
2570
2571         * BuildSlaveSupport/build.webkit.org-config/config.json: Add definitions for builders and testers.
2572         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Update unit tests.
2573
2574 2015-09-30  Timothy Hatcher  <timothy@apple.com>
2575
2576         Give WebKitLauncher the get-task-allow entitlement to allow it to work on El Capitan
2577         https://bugs.webkit.org/show_bug.cgi?id=149674
2578
2579         Reviewed by Lucas Forschler.
2580
2581         * WebKitLauncher/WebKitLauncher.entitlements: Added.
2582         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2583
2584 2015-09-30  Jason Marcell  <jmarcell@apple.com>
2585
2586         BuildbotQueueView.prototype._appendPendingRevisionCount should skip repositories that don't
2587         have an associated trac instance.
2588         https://bugs.webkit.org/show_bug.cgi?id=149673
2589
2590         Reviewed by Alexey Proskuryakov.
2591
2592         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2593         (BuildbotQueueView.prototype._appendPendingRevisionCount): Skip repositories that don't
2594         have an associated trac instance.
2595
2596 2015-09-30  Daniel Bates  <dabates@apple.com>
2597
2598         Prioritize testing latest build request on iOS test bots
2599         https://bugs.webkit.org/show_bug.cgi?id=149669
2600
2601         Reviewed by Darin Adler.
2602
2603         We should prioritize testing of the latest build request on the iOS test bots
2604         as we do for Mac and Windows test bots.
2605
2606         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2607         (loadBuilderConfig):
2608
2609 2015-09-30  Daniel Bates  <dabates@apple.com>
2610
2611         Add buildbot category for iOS builders and testers
2612         https://bugs.webkit.org/show_bug.cgi?id=149667
2613
2614         Reviewed by Darin Adler.
2615
2616         Group iOS builders and testers under category iOS and add dashboard and console hyperlinks
2617         for iOS to the build.webkit.org home page.
2618
2619         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2620         (loadBuilderConfig):
2621         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2622
2623 2015-09-30  Daniel Bates  <dabates@apple.com>
2624
2625         Actually fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
2626         (https://bugs.webkit.org/show_bug.cgi?id=149539)
2627
2628         I inadvertently didn't remove the ONLY_ACTIVE_ARCH=NO flag when building on a Mac
2629         in <http://trac.webkit.org/changeset/190351>.
2630
2631         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2632         (CompileWebKit.start):
2633
2634 2015-09-30  Daniel Bates  <dabates@apple.com>
2635
2636         Attempt to fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
2637         (https://bugs.webkit.org/show_bug.cgi?id=149539)
2638
2639         {32, 64}-bit Mac builders should not try to build project {Plugin.64, Plugin.32},
2640         respectively; only pass ONLY_ACTIVE_ARCH=NO when building for iOS.
2641
2642         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2643         (CompileWebKit.start):
2644
2645 2015-09-30  Lucas Forschler  <lforschler@apple.com>
2646
2647         bot210 was configured for a queue instead of bot126.
2648
2649         Unreviewed config.json fix.
2650
2651         * BuildSlaveSupport/build.webkit.org-config/config.json:
2652
2653 2015-09-30  Lucas Forschler  <lforschler@apple.com>
2654
2655         Bring El Capitan buildbot infrastructure online.
2656         https://bugs.webkit.org/show_bug.cgi?id=149605
2657
2658         Reviewed by Darin Adler.
2659
2660         * BuildSlaveSupport/build.webkit.org-config/config.json:
2661
2662 2015-09-30  Tomas Popela  <tpopela@redhat.com>
2663
2664         [GTK] Deprecation warnings in DOMNodeTest
2665         https://bugs.webkit.org/show_bug.cgi?id=149663
2666
2667         After the webkit_dom_document_get_elements_by_tag_name deprecation we
2668         need to update the tests to use webkit_dom_document_query_selector_all
2669         to avoid compilation warnings.
2670
2671         Also add a new test for webkit_dom_document_get_elements_by_tag_name_as_html_collection
2672         (the suggested replacement for the deprecated function).
2673
2674         Reviewed by Carlos Garcia Campos.
2675
2676         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
2677         (WebKitDOMNodeTest::testTagNamesNodeList):
2678         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
2679         (registerTests):
2680         (WebKitDOMNodeTest::testTagNames): Deleted.
2681         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
2682         (prepareDOMForTagNamesTests):
2683         (testWebKitDOMNodeTagNamesNodeList):
2684         (testWebKitDOMNodeTagNamesHTMLCollection):
2685         (beforeAll):
2686         (testWebKitDOMNodeTagNames): Deleted.
2687
2688 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
2689
2690         WebKitTestRunner fails to apply "useFlexibleViewport" when it's specified in a file comment
2691         https://bugs.webkit.org/show_bug.cgi?id=149650
2692
2693         Reviewed by Tim Horton.
2694
2695         TestInvocation::invoke() consulted shouldMakeViewportFlexible(), but that only
2696         looks at the file path, and not the custom options that come from file comments.
2697
2698         Fix by computing TestOptions before making the TestInvocation, and setting them
2699         as const TestInvocation data. This meant changing various call sites to take
2700         the std::string pathOrURL, rather than the TestInvocation itself.
2701
2702         Also initialize TestInvocation with a WKURLRef, rather than a std::string.
2703
2704         * WebKitTestRunner/CMakeLists.txt:
2705         * WebKitTestRunner/TestController.cpp:
2706         (WTR::TestController::ensureViewSupportsOptionsForTest):
2707         (WTR::testPath):
2708         (WTR::createTestURL):
2709         (WTR::updateTestOptionsFromTestHeader):
2710         (WTR::TestController::testOptionsForTest):
2711         (WTR::TestController::updateWebViewSizeForTest):
2712         (WTR::TestController::updateWindowScaleForTest):
2713         (WTR::TestController::runTest):
2714         * WebKitTestRunner/TestController.h:
2715         * WebKitTestRunner/TestInvocation.cpp:
2716         (WTR::TestInvocation::TestInvocation):
2717         (WTR::TestInvocation::invoke):
2718         (WTR::createWKURL): Deleted.
2719         (WTR::TestInvocation::shouldMakeViewportFlexible): Deleted.
2720         (WTR::TestInvocation::shouldUseFixedLayout): Deleted.
2721         * WebKitTestRunner/TestInvocation.h:
2722         (WTR::TestInvocation::options):
2723         * WebKitTestRunner/TestOptions.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
2724         (WTR::pathContains):
2725         (WTR::shouldMakeViewportFlexible):
2726         (WTR::shouldUseFixedLayout):
2727         (WTR::isSVGTestPath):
2728         (WTR::isHiDPITestPath):
2729         (WTR::TestOptions::TestOptions):
2730         * WebKitTestRunner/TestOptions.h:
2731         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2732         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2733         (WTR::pathContains):
2734         (WTR::shouldUseFixedLayout):
2735         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2736         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2737         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2738         * WebKitTestRunner/ios/TestControllerIOS.mm:
2739         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2740         * WebKitTestRunner/mac/TestControllerMac.mm:
2741         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2742
2743 2015-09-29  Aakash Jain  <aakash_jain@apple.com>
2744
2745         Flakiness dashboard should support OS X El Capitan
2746         https://bugs.webkit.org/show_bug.cgi?id=149648
2747
2748         Reviewed by Alexey Proskuryakov.
2749
2750         * QueueStatusServer/app.yaml: We do not need to maintain SVN revision here because of
2751         difference between new appscale and old Google App Engine implementation.
2752         * TestResultServer/app.yaml: Same.
2753         * TestResultServer/static-dashboards/builders.jsonp: Added OSX El Capitan support.
2754
2755 2015-09-29  Daniel Bates  <dabates@apple.com>
2756
2757         configure-xcode-for-ios-development does not work with Xcode 7
2758         https://bugs.webkit.org/show_bug.cgi?id=149640
2759
2760         Reviewed by Alexey Proskuryakov.
2761
2762         When Xcode 7 is installed, running configure-xcode-for-ios-development dies with an error
2763         because it cannot find the Xcode specification files for iOS simulator and device. These
2764         files have moved to a new location in Xcode 7 distribution. Moreover we must add the
2765         relevant definitions to the Xcode 7 specification files directly as opposed to creating
2766         new specification files with the added definitions (as we did in older versions of Xcode)
2767         in order for Xcode 7 to honor these definitions.
2768
2769         * Scripts/configure-xcode-for-ios-development: Sorted forward declarations.
2770         (updateXcodeSpecificationFilesForSDKIfNeeded): Added.
2771         (updateXcode7SpecificationFile): Added.
2772         (createLegacyXcodeSpecificationFilesForSDKIfNeeded): Formerly named createXcodeSpecificationFilesForSDKIfNeeded.
2773         (writeXcodeSpecification): Moved congratulations line to caller so as to write out the
2774         appropriate success message.
2775         (mergeXcodeSpecificationWithSpecificationAndId): Formerly named createXcodeSpecificationFromSpecificationAndId.
2776         (createXcodeSpecificationFilesForSDKIfNeeded): Deleted.
2777         (createXcodeSpecificationFromSpecificationAndId): Deleted.
2778
2779 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
2780
2781         [Win] Allow 'prepare-ChangeLog' to be used without Cygwin
2782         https://bugs.webkit.org/show_bug.cgi?id=149639
2783
2784         Reviewed by Alex Christensen.
2785
2786         * Scripts/VCSUtils.pm:
2787         (exitStatus): Use 'isWindows()' method.
2788         (isSVNVersion16OrNewer): 'eval' is not needed here, and just causes
2789         an error. This method could probably just go away.
2790         (normalizePath): Leave Windows (or Unix) paths as platform paths, rather than
2791         always changing to Unix style.
2792         (unixPath): Added. Needed so Windows can always show a Unix path in the
2793         ChangeLog file.
2794         (changeLogName): Work around the fact that 'getpwuid' is not available on
2795         a pure Windows build of Perl.
2796         * Scripts/prepare-ChangeLog:
2797         (generateFunctionLists): Normalize path received from 'svn' in case it's a Unix
2798         path on Windows.
2799         (svnUpdateCommand): Added helper function. Needed because Windows Perl does not
2800         support using arrays for 'open' arguments.
2801         (resolveChangeLogsPath): Ditto.
2802         (resolveConflictedChangeLogs): Use new helper functions.
2803         (generateNewChangeLogs): Force Windows to use Unix paths in ChangeLog output.
2804         (diffCommand): Use double-quotes for paths, since Windows doesn't understand single
2805         quotes. Unix systems are happy either way.
2806         (statusCommand): Ditto.
2807         * Scripts/webkitdirs.pm:
2808         (launcherName): Drive-by fix. WinLauncher was renamed to MiniBrowser some time ago.
2809
2810 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
2811
2812         [Win] Unreviewed 64-bit build fix after switch to CMake.
2813
2814         * Scripts/webkitdirs.pm:
2815         (determineIsWin64FromArchitecture): Added.
2816
2817 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2818
2819         printing does not use minimum page zoom factor
2820         https://bugs.webkit.org/show_bug.cgi?id=108507
2821
2822         Reviewed by Darin Adler.
2823
2824         WebKitTestRunner always takes the snapshots from the UI process
2825         (expect for IOS), so in the case of printing, the layout in the
2826         web view is not the expected one. When printing, we need to take
2827         the snapshot in the web process and ensure it's rendered with a
2828         PrintContext.
2829
2830         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2831         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
2832         kWKSnapshotOptionsPrinting option to
2833         WKBundlePageCreateSnapshotWithOptions() when printing.
2834
2835 2015-09-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2836
2837         [WTR] Pixel tests generate the snapshots twice in Web and UI processes
2838         https://bugs.webkit.org/show_bug.cgi?id=149595
2839
2840         Reviewed by Tim Horton.
2841
2842         All ports except IOS implement
2843         PlatformWebView::windowSnapshotImage() to generate the snapshot
2844         for the pixel tests in the UI process. But we are still generating
2845         a snapshot for pixel tests in the Web process too, that is passed
2846         to the UI process but ignored.
2847         Whether a pixel result is needed or not, is only known by the web
2848         process depending on whether the test called dumpAsText with
2849         dumpPixels == true or not. Since the pixels are now dump in the UI
2850         process, we need to pass that information to the UI process when
2851         the test is done. For that we set a PixelResultIsPending bool
2852         parameter to the Done message, and we only add the PixelResult
2853         when UI process doesn't need to generate the pixels dump.
2854
2855         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2856         (WTR::InjectedBundle::didReceiveMessageToPage): Set
2857         m_pixelResultIsPending to false on reset.
2858         (WTR::InjectedBundle::done): Add PixelResultIsPending parameter to the
2859         Done message, and set the PixelResult if m_pixelResultIsPending is false.
2860         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2861         (WTR::InjectedBundle::setPixelResult): Set m_pixelResultIsPending to false.
2862         (WTR::InjectedBundle::setNeedsPixelResult): Set m_pixelResultIsPending.
2863         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2864         (WTR::InjectedBundlePage::dump): Only create a snapshot for IOS
2865         port.
2866         * WebKitTestRunner/TestInvocation.cpp:
2867         (WTR::TestInvocation::dumpResults): Use either the pixel result
2868         from the web process or generate a pixel result from the web view
2869         if need it.
2870         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2871         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
2872         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
2873         is created by the caller now, but the CG implementation needs to
2874         know if it's a Web or UI process snapshot.
2875         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2876         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
2877         cairo surface for the given image.
2878         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2879         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
2880         CGContext for the given image.
2881
2882 2015-09-28  Dean Johnson  <dean_johnson@apple.com>
2883
2884         Fix JS errors on dashboard metrics page
2885         https://bugs.webkit.org/show_bug.cgi?id=149608
2886
2887         Reviewed by Alexey Proskuryakov.
2888
2889         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Updated to use Settings.
2890         (initPlatformsByFamily):
2891         (updateHiddenPlatforms):
2892         (parsePlatformFamily): Deleted.
2893         (updateToggleButtons): Deleted.
2894         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
2895         (updateHiddenPlatforms): Added to remove errors.
2896         (initPlatformsByFamily): Added to remove errors.
2897         (unhiddenQueues): Updated to use Settings.
2898         (documentReady): Added logic to add toggle buttons to the settings menu.
2899         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
2900         (Settings.prototype.parsePlatformFamily): Moved duplicate logic from Main.js and
2901         MetricsMain.js to Settings.
2902         (Settings.prototype.updateToggleButtons): Moved duplicate logic from Main.js and
2903         MetricsMain.js to Settings.
2904         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
2905         (QueueView.prototype._updateHiddenState): Updated to use Settings.
2906
2907 2015-09-28  Aakash Jain  <aakash_jain@apple.com>
2908
2909         Appscale query fails because of missing index
2910         https://bugs.webkit.org/show_bug.cgi?id=149609
2911
2912         Reviewed by Darin Adler.
2913
2914         * QueueStatusServer/index.yaml: Added the required index.
2915
2916 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
2917
2918         [Win] Fix the 64-bit build after switch to cmake.
2919
2920         Reviewed by Alex Christensen.
2921
2922         * Scripts/webkitdirs.pm:
2923         (generateBuildSystemFromCMakeProject): Use correct arguments for cmake to
2924         run a 64-bit build.
2925
2926 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
2927
2928         [Win] Allow Windows to run test-webkitpy without Cygwin
2929         https://bugs.webkit.org/show_bug.cgi?id=149602
2930
2931         Reviewed by Alex Christensen.
2932
2933         These changes mostly shift from hard-coded paths using UNIX-style
2934         separators to Python's "os.path.join" syntax that uses the correct
2935         path separator for each platform.
2936
2937         * Scripts/webkitpy/common/system/path.py:
2938         (cygpath): Don't pass paths through Cygpath on native Windows.
2939         * Scripts/webkitpy/port/win.py:
2940         (WinPort._path_to_apache): Use os.path.join.
2941         (WinPort._ntsd_location): Support 64-bit environment (ProgramW6432 doesn't exist
2942         in 64-bit environments).
2943         * Scripts/webkitpy/style/checker.py: Use os.path.join.
2944         * Scripts/webkitpy/style/checker_unittest.py:
2945         (GlobalVariablesTest.test_path_rules_specifier.assertNoCheck): Use os.path.join.
2946         (GlobalVariablesTest.test_path_rules_specifier): Ditto.
2947         (GlobalVariablesTest): Ditto.
2948         (GlobalVariablesTest.test_max_reports_per_category): Ditto.
2949         (CheckerDispatcherSkipTest.test_should_skip_with_warning): Ditto.
2950         (CheckerDispatcherDispatchTest.test_js_paths): Ditto.
2951         (CheckerDispatcherDispatchTest.test_json_paths): Ditto.
2952         (CheckerDispatcherDispatchTest.test_python_paths): Ditto.
2953         (CheckerDispatcherDispatchTest.test_text_paths): Ditto.
2954         (CheckerDispatcherDispatchTest.test_xml_paths): Ditto.
2955         (StyleProcessor_CodeCoverageTest._create_carriage_checker_class): Ditto.
2956         (StyleProcessor_CodeCoverageTest): Ditto.
2957         (StyleProcessor_CodeCoverageTest.test_should_process__skip_without_warning): Ditto.
2958         (StyleProcessor_CodeCoverageTest.test_should_process__skip_with_warning): Ditto.
2959         (StyleProcessor_CodeCoverageTest.test_should_process__true_result): Ditto.
2960         * Scripts/webkitpy/w3c/test_parser_unittest.py: Uses os.path.join rather than
2961         manual string concatenation of paths.
2962
2963 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
2964
2965         Add bugzilla addresses of committers to contributors.json
2966         https://bugs.webkit.org/show_bug.cgi?id=149520
2967
2968         Reviewed by Darin Adler.
2969
2970         * Scripts/webkitpy/common/config/contributors.json:
2971
2972 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
2973
2974         validate-committer-lists -b shouldn't need edituser privileges
2975         https://bugs.webkit.org/show_bug.cgi?id=149519
2976
2977         Reviewed by Darin Adler.
2978
2979         * Scripts/validate-committer-lists:
2980         (CommitterListBugzillaChecker._has_invalid_bugzilla_email):
2981         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2982         (BugzillaQueries.is_invalid_bugzilla_email):
2983         (BugzillaQueries): Deleted.
2984         (BugzillaQueries.fetch_logins_matching_substring): Deleted.
2985
2986 2015-09-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2987
2988         Unreviewed. Gardening: skip media stream tests failing after r190262.
2989
2990         * Scripts/run-gtk-tests:
2991         (TestRunner):
2992
2993 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
2994
2995         [Mac] USE_INTERNAL_SDK is used undefined in tools projects
2996         https://bugs.webkit.org/show_bug.cgi?id=149571
2997
2998         Reviewed by Dan Bernstein.
2999
3000         Use the same pattern as in Source directory configurations (so, also get rid of AspenFamily.xcconfig).
3001
3002         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3003         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3004         * LayoutTestRelay/Configurations/Base.xcconfig:
3005         * MiniBrowser/Configurations/Base.xcconfig:
3006         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3007         * TestWebKitAPI/Configurations/Base.xcconfig:
3008         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3009         * WebEditingTester/Configurations/Base.xcconfig:
3010         * WebEditingTester/Configurations/DebugRelease.xcconfig:
3011         * WebKitTestRunner/Configurations/Base.xcconfig:
3012         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3013         * WebKitTestRunner/iOS.xcconfig: Removed.
3014
3015 2015-09-25  Eric Carlson  <eric.carlson@apple.com>
3016
3017         Clean up user media request internal API
3018         https://bugs.webkit.org/show_bug.cgi?id=149527
3019
3020         Reviewed by Tim Horton.
3021
3022         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
3023         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): Update for API changes.
3024
3025         * WebKitTestRunner/TestController.cpp:
3026         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Ditto.
3027
3028 2015-09-25  Simon Fraser  <simon.fraser@apple.com>
3029
3030         [iOS WK2] Add viewport tests and fix runUIScript() timing issues
3031         https://bugs.webkit.org/show_bug.cgi?id=149577
3032
3033         Reviewed by Tim Horton.
3034
3035         When calling testRunner.runUIScript() from a page load event, the script could run
3036         in the UI process before the current remote layer tree transaction had been handled
3037         there. This meant that runUIScript() could query state which was about to change.
3038
3039         Fix by delaying the execution of the UI script until a layer tree transaction has
3040         been handled by the UI process, leveraging the existing DrawingAreaProxy::dispatchAfterEnsuringDrawing().
3041
3042         * WebKitTestRunner/TestInvocation.cpp:
3043         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3044         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
3045         * WebKitTestRunner/TestInvocation.h:
3046
3047 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
3048
3049         [Mac] Media tests start to time out after a few days of bot uptime
3050         https://bugs.webkit.org/show_bug.cgi?id=149468
3051
3052         Reviewed by Darin Adler.
3053
3054         Delete cache directory in addition to the temporary one. Don't delete /private/tmp/MediaCache,
3055         as it's not longer used by tests. Set TMPDIR and DIRHELPER_USER_DIR_SUFFIX to make
3056         all temporary and cache files go to a custom location.
3057
3058         * Scripts/webkitpy/port/base.py:
3059         * Scripts/webkitpy/port/driver.py:
3060         * Scripts/webkitpy/port/mac.py:
3061         * Scripts/webkitpy/port/win.py:
3062         (WinPort._driver_tempdir_for_environment): Deleted unused function.
3063
3064 2015-09-25  Dan Bernstein  <mitz@apple.com>
3065
3066         Removed MiniBrowser.entitlements.
3067
3068         Rubber-stamped by Anders Carlsson.
3069
3070         The entitlements weren’t used anyway.
3071
3072         * MiniBrowser/MiniBrowser.entitlements: Removed.
3073         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3074
3075 2015-09-24  Daniel Bates  <dabates@apple.com>
3076
3077         Add WebKitSystemInterface for iOS 9.0
3078         https://bugs.webkit.org/show_bug.cgi?id=149550
3079
3080         Rubber-stamped by Alexey Proskuryakov.
3081
3082         * Scripts/copy-webkitlibraries-to-product-directory:
3083
3084 2015-09-24  Daniel Bates  <dabates@apple.com>
3085
3086         Support building for arbitrary architectures
3087         https://bugs.webkit.org/show_bug.cgi?id=149539
3088
3089         Reviewed by Alexey Proskuryakov.
3090
3091         Teach buildbot to pass the architectures associated with the builder to build-webkit
3092         when building on OS X and iOS. As a side effect of this change we now support building
3093         universal binaries when multiples architectures are specified.
3094
3095         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3096         (CompileWebKit.start):
3097
3098 2015-09-24  Daniel Bates  <dabates@apple.com>
3099
3100         Fix the build after <http://trac.webkit.org/changeset/190212>
3101         (http://trac.webkit.org/changeset/190212)
3102
3103         I inadvertently did not remove the fullPlatform argument from one of the callers of archiveBuiltProduct().
3104
3105         * BuildSlaveSupport/built-product-archive:
3106         (main):
3107
3108 2015-09-24  Daniel Bates  <dabates@apple.com>
3109
3110         Support running unit tests on iOS Simulator test bot
3111         https://bugs.webkit.org/show_bug.cgi?id=149536
3112
3113         Reviewed by Alexey Proskuryakov.
3114
3115         Implements support for running unit tests on a iOS test bot. At the time of writing,
3116         the script run-api-tests supports running unit tests on Mac, Windows and iOS Simulator.
3117
3118         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3119         (RunUnitTests.start): Append appropriate command line flag when invoking script run-api-tests.
3120         (TestFactory.__init__): Add step RunUnitTests when the test bot is for the iOS Simulator platform.
3121
3122 2015-09-24  Daniel Bates  <dabates@apple.com>
3123
3124         Add support infrastructure for OpenSource iOS builders and testers
3125         https://bugs.webkit.org/show_bug.cgi?id=149534
3126
3127         Reviewed by Darin Adler.
3128
3129         Towards setting up OpenSource iOS build bots, teach buildbot and its support
3130         scripts about iOS.
3131
3132         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3133         (appendCustomBuildFlags): Require the caller to pass parameter fullPlatform and append
3134         --ios-simulator or --device for a builder/tester whose full platform name begins with
3135         "ios-simulator" or "ios", respectively.
3136         (RunJavaScriptCoreTests.start): Pass the full platform name to appendCustomBuildFlags().
3137         * BuildSlaveSupport/built-product-archive:
3138         (main): Pass the full platform name to determineWebKitBuildDirectory().
3139         (determineWebKitBuildDirectory): Call script webkit-build-directory with the appropriate
3140         command line flag when building for iOS.
3141         (archiveBuiltProduct): Use the same logic for iOS as we do for Mac. Also, remove unused
3142         parameter fullPlatform. This parameter was originally added in r125066 to support the
3143         Chromium Android port, which has since been removed from the OpenSource WebKit Project.
3144         (extractBuiltProduct): Use the same logic for iOS as we do for Mac.
3145         * BuildSlaveSupport/clean-build:
3146         (main): Call script webkit-build-directory with the appropriate command line flag when
3147         building for iOS.
3148         * BuildSlaveSupport/delete-stale-build-files:
3149         (main): Use the same logic for iOS as we do for Mac.
3150         (webkitBuildDirectory): Call script webkit-build-directory with the appropriate command line
3151         flag when building for iOS.
3152         * BuildSlaveSupport/test-result-archive:
3153         (archiveTestResults): Use the same logic for iOS as we do for Mac.
3154
3155 2015-09-24  Daniel Bates  <dabates@apple.com>
3156
3157         Remove Chromium-specific changes to script built-product-archive
3158         https://bugs.webkit.org/show_bug.cgi?id=149530
3159
3160         Rubber-stamped by Csaba Osztrogonác.
3161
3162         Reverts changes made in r113074 and r113067 to support Chromium testers. The
3163         Chromium code has long since been removed from the OpenSource WebKit Project.
3164
3165         * BuildSlaveSupport/built-product-archive:
3166         (createZipManually):
3167         (createZip):
3168         (archiveBuiltProduct):
3169
3170 2015-09-24  Dan Bernstein  <mitz@apple.com>
3171
3172         Build fix.
3173
3174         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
3175
3176 2015-09-24  Mark Lam  <mark.lam@apple.com>
3177
3178         Unreviewed. Make Lucas Forschler a WebKit reviewer.
3179
3180         * Scripts/webkitpy/common/config/contributors.json:
3181
3182 2015-09-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3183
3184         Unreviewed. Fix GObject DOM API breaks after r190120.
3185
3186         Bring back code removed in r169931 to handle documentation of
3187         deleted classes.
3188
3189         * gtk/webkitdom.py:
3190         (WebKitDOMDocGenerator):
3191         (WebKitDOMDocGenerator.write_deleted_classes):
3192         (WebKitDOMDocGenerator.generate):
3193         (write_deleted_classes):
3194         (WebKitDOMDocGeneratorSections._deleted_class):
3195         (WebKitDOMDocGeneratorSections._deleted_class.in):
3196         (WebKitDOMDocGeneratorSections.write_deleted_classes):
3197         (WebKitDOMDocGeneratorSections.write_deleted_classes.with):
3198
3199 2015-09-23  Myles C. Maxfield  <mmaxfield@apple.com>
3200
3201         [Cocoa] [Font Features] Implement font-variant-*
3202         https://bugs.webkit.org/show_bug.cgi?id=148413
3203
3204         Reviewed by Darin Adler.
3205
3206         Update test font to use "lnum" feature.
3207
3208         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
3209         (Generator::appendGSUBTable):
3210
3211 2015-09-22  Andy Estes  <aestes@apple.com>
3212
3213         ContentFiltering.AllowDownloadAfterAddData is very flaky
3214         https://bugs.webkit.org/show_bug.cgi?id=148885
3215         <rdar://problem/22729563>
3216
3217         Reviewed by Alexey Proskuryakov.
3218
3219         The AllowDownload* tests were relying on -_downloadDidStart: being called before -webView:didFinishNavigation:,
3220         but there is no guarantee of this. For tests that should allow a download, spin the runloop until
3221         -_downloadDidStart: is called. The test will now timeout on failure, but will no longer produce false failures.
3222
3223         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
3224         (downloadTest):
3225
3226 2015-09-22  Alexey Proskuryakov  <ap@apple.com>
3227
3228         Mavericks: Media tests start to time out after a few days of bot uptime
3229         https://bugs.webkit.org/show_bug.cgi?id=149468
3230
3231         Reviewed by Chris Dumez.
3232
3233         * Scripts/webkitpy/port/base.py:
3234         * Scripts/webkitpy/port/driver.py:
3235         * Scripts/webkitpy/port/mac.py:
3236
3237 2015-09-22  Nan Wang  <n_wang@apple.com>
3238
3239         Unreviewed, add myself to the committers list.
3240
3241         * Scripts/webkitpy/common/config/contributors.json:
3242
3243 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
3244
3245         Remove 'nullable' to fix older iOS builds.
3246
3247         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3248         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
3249
3250 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
3251
3252         [Win] Show tiled drawing debug overlay on Windows
3253         https://bugs.webkit.org/show_bug.cgi?id=149426
3254
3255         Reviewed by Dean Jackson.
3256
3257         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Add new menu option.
3258         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Ditto.
3259         * MiniBrowser/win/Common.cpp:
3260         (::ToggleMenuItem): Recognize new menu item and toggle the 'showTiledScrollingIndicator'
3261         flag if needed.
3262         * MiniBrowser/win/MiniBrowser.h: Update to use new IWebPreferencesPrivate3 class.
3263
3264 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
3265
3266         [Win] Use command-line argument to launch in regular or High DPI mode.
3267         https://bugs.webkit.org/show_bug.cgi?id=149417
3268
3269         Reviewed by Dean Jackson.
3270
3271         * MiniBrowser/win/Common.cpp:
3272         (parseCommandLine): Ignore the '--highDPI' argument. It's used at the
3273         very start of execution, before the MiniBrowser.dll is loaded.
3274         * win/DLLLauncher/DLLLauncherMain.cpp:
3275         (shouldUseHighDPI): Check for '--highDPI', and use this mode if
3276         present. On WinCairo, always use High DPI.
3277
3278 2015-09-21  Ryosuke Niwa  <rniwa@webkit.org>
3279
3280         32-bit Mac build fix attempt after r190065.
3281
3282         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3283
3284 2015-09-21  Alexey Proskuryakov  <ap@apple.com>
3285
3286         [OS X] Update for Xcode 7.0 on Yosemite
3287         https://bugs.webkit.org/show_bug.cgi?id=149389
3288
3289         Reviewed by Dan Bernstein.
3290
3291         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
3292         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
3293         Removed unneeded declarations - conforming to a protocol is sufficient.
3294
3295         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3296         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
3297         Changed the definitions to be compiled whenever the SDK requires it (so we will have
3298         dead code compiled in when building for 10.10 with 10.11 SDK, somewhat unfortunately).
3299
3300 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
3301
3302         Add the ability for tests to run script in the UI process in WebKitTestRunner
3303         https://bugs.webkit.org/show_bug.cgi?id=149356
3304
3305         Reviewed by Tim Horton.
3306
3307         This change adds testRunner.runUIScript(script, callback), which allows a test
3308         to execute script in a JSContext which runs in the UI process. That context
3309         has bindings exposed through the UIScriptController interface; currently one test
3310         function, and some iOS-specific functions are included. UIScriptController can be
3311         async with a callback, and runUIScript() itself is asynchronous. When the UI
3312         script is complete, it calls uiController.uiScriptComplete(result), where 'result'
3313         is a string passed back to the web process, and given to the runUIScript()
3314         callback function.
3315
3316         Thanks to Gyuyoung Kim for help with the Gtk/Efl build.
3317
3318         * WebKitTestRunner/DerivedSources.make: Build UIScriptController.idl.
3319         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Add runUIScript().
3320         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3321         (WTR::InjectedBundle::didReceiveMessageToPage): When the UI-side script is
3322         complete, call back into TestRunner.
3323         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3324         (WTR::nextUIScriptCallbackID):
3325         (WTR::TestRunner::runUIScript): Post a message to the injected bundle to run the UI script.
3326         (WTR::TestRunner::runUIScriptCallback): When the UI script is done, execute its callback function.
3327         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3328         * WebKitTestRunner/PlatformWebView.h:
3329         * WebKitTestRunner/TestController.cpp:
3330         (WTR::updateTestOptionsFromTestHeader):
3331         (WTR::TestController::testOptionsForTest): Support "useFlexibleViewport" as a test argument.
3332         (WTR::shouldUseFixedLayout): Deleted. Moved to a TestInvocation function.
3333         * WebKitTestRunner/TestInvocation.cpp:
3334         (WTR::TestInvocation::shouldUseFixedLayout):
3335         (WTR::TestInvocation::shouldUseThreadedScrolling):
3336         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3337         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3338         (WTR::TestInvocation::runUISideScript): Run the UI-side script!
3339         (WTR::TestInvocation::uiScriptDidComplete): Send a message back to the injected bundle.
3340         * WebKitTestRunner/TestInvocation.h:
3341         * WebKitTestRunner/TestOptions.h:
3342         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3343         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3344         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
3345         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Added.
3346         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
3347         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
3348         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
3349         (-[TestRunnerWKWebView onDidEndZooming:]): Allow a test to hook into the end of zooming.
3350         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3351         (WTR::PlatformWebView::PlatformWebView): Make a TestRunnerWKWebView on iOS.
3352         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Added.
3353         (WTR::UIScriptController::doAsyncTask):
3354         (WTR::UIScriptController::zoomToScale):
3355         (WTR::UIScriptController::zoomScale):
3356         (WTR::UIScriptController::minimumZoomScale):
3357         (WTR::UIScriptController::maximumZoomScale):
3358         (WTR::UIScriptController::contentVisibleRect):
3359         * WebKitTestRunner/mac/EventSenderProxy.mm:
3360         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3361         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Deleted.
3362         * WebKitTestRunner/mac/TestControllerMac.mm:
3363         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
3364         (WTR::shouldUseThreadedScrolling): Deleted. Moved to TestInvocation.
3365         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
3366         * WebKitTestRunner/uiscriptcontext/UIScriptContext.cpp: Added. Owns the JS context in the UI process.
3367         (UIScriptContext::UIScriptContext):
3368         (UIScriptContext::~UIScriptContext):
3369         (UIScriptContext::runUIScript): Entrypoint to running the UI script. If the script didn't do anything
3370         asynchronous, call the callback.
3371         (UIScriptContext::nextTaskCallbackID):
3372         (UIScriptContext::prepareForAsyncTask): Do setup for one async task (i.e. a UIScriptController function
3373         that has a callback). Has to store the callbackID of the script, so code called from the completion
3374         callback knows which UI script invoked it.
3375         (UIScriptContext::asyncTaskComplete): Called when one task is finished.
3376         (UIScriptContext::uiScriptComplete):
3377         (UIScriptContext::objectFromRect): Make a JS object from a rect.
3378         * WebKitTestRunner/uiscriptcontext/UIScriptContext.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
3379         (WTR::UIScriptContext::hasOutstandingAsyncTasks):
3380         * WebKitTestRunner/uiscriptcontext/UIScriptController.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
3381         (WTR::UIScriptController::UIScriptController):
3382         (WTR::UIScriptController::makeWindowObject):
3383         (WTR::UIScriptController::wrapperClass):
3384         (WTR::UIScriptController::doAsyncTask):
3385         (WTR::UIScriptController::zoomToScale):
3386         (WTR::UIScriptController::zoomScale):
3387         (WTR::UIScriptController::minimumZoomScale):
3388         (WTR::UIScriptController::maximumZoomScale):
3389         (WTR::UIScriptController::contentVisibleRect):
3390         (WTR::UIScriptController::uiScriptComplete):
3391         * WebKitTestRunner/uiscriptcontext/UIScriptController.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
3392         (WTR::UIScriptController::create):
3393         * WebKitTestRunner/uiscriptcontext/bindings/UIScriptController.idl: Copied from Tools/WebKitTestRunner/TestOptions.h.
3394
3395 2015-09-21  Tim Horton  <timothy_horton@apple.com>
3396
3397         Turn on threaded scrolling by default in the tests
3398         https://bugs.webkit.org/show_bug.cgi?id=149377
3399
3400         Reviewed by Simon Fraser.
3401
3402         * WebKitTestRunner/mac/TestControllerMac.mm:
3403         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
3404         (WTR::shouldUseThreadedScrolling): Deleted.
3405         Turn on threaded scrolling by default.
3406
3407 2015-09-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3408
3409         [GTK] run-gtk-tests doesn't provide feedback about crashing google tests
3410         https://bugs.webkit.org/show_bug.cgi?id=149252
3411
3412         Reviewed by Darin Adler.
3413
3414         In case of glib tests the test runner notifies about tests
3415         crashing, but for google tests we don't get any feedback, which
3416         means that in case of a test crashing we get a list of **PASS**
3417         messages and at the summary we are notified that the test suite
3418         has failed, but it's impossible to know which test cases have failed.
3419
3420         * Scripts/run-gtk-tests:
3421         (TestRunner._run_google_test): Add a **CRASH** message if test
3422         case crashed.
3423
3424 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
3425
3426         WebKitTestRunner can leak user content script results between tests
3427         https://bugs.webkit.org/show_bug.cgi?id=149391
3428
3429         Reviewed by Sam Weinig.
3430
3431         Move WKBundlePageRemoveAllUserContent call so that it's executed before loading
3432         about:blank, and thus about:blank doesn't have unintended side effects.
3433
3434         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3435         (WTR::InjectedBundle::beginTesting):
3436         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3437         (WTR::InjectedBundlePage::resetAfterTest):
3438
3439 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
3440
3441         [Mac, iOS] AccessibilityController doesn't uninstall global notification handler
3442         https://bugs.webkit.org/show_bug.cgi?id=149384
3443
3444         Reviewed by Chris Fleizach.
3445
3446         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
3447         (AccessibilityController::addNotificationListener): Fixed a leak, and cleaned up the code.
3448         (AccessibilityController::platformResetToConsistentState): Actually remove the handler,
3449         regardless of whether someone else holds a reference (we also call -stopListening in
3450         -dealloc).
3451
3452         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3453         (AccessibilityController::platformResetToConsistentState):
3454         (AccessibilityController::addNotificationListener):
3455         Ditto.
3456
3457 2015-09-20  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3458
3459         Remove XHR_TIMEOUT compilation guard
3460         https://bugs.webkit.org/show_bug.cgi?id=149260
3461
3462         Reviewed by Benjamin Poulain.
3463
3464         * Scripts/webkitperl/FeatureList.pm:
3465
3466 2015-09-19  Dan Bernstein  <mitz@apple.com>
3467
3468         Attempted build fix.
3469
3470         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
3471
3472 2015-09-18  Commit Queue  <commit-queue@webkit.org>
3473
3474         Unreviewed, rolling out r189908.
3475         https://bugs.webkit.org/show_bug.cgi?id=149368
3476
3477         Broke run-webkit-tests --pixel (Requested by ap on #webkit).
3478
3479         Reverted changeset:
3480
3481         "printing does not use minimum page zoom factor"
3482         https://bugs.webkit.org/show_bug.cgi?id=108507
3483         http://trac.webkit.org/changeset/189908
3484
3485 2015-09-18  Andy Estes  <aestes@apple.com>
3486
3487         [iOS] did{Start,Finish}LoadForQuickLookDocumentInMainFrame is never called on WKNavigationDelegate
3488         https://bugs.webkit.org/show_bug.cgi?id=149360
3489
3490         Reviewed by Tim Horton.
3491
3492         Added an API test.
3493
3494         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3495         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Added.
3496         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3497         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3498         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]):
3499         (TEST):
3500         * TestWebKitAPI/ios/pages.pages: Added.
3501
3502 2015-09-18  Nan Wang  <n_wang@apple.com>
3503
3504         AX: Implement ARIA 1.1 @aria-current on iOS
3505         https://bugs.webkit.org/show_bug.cgi?id=149297
3506
3507         Reviewed by Chris Fleizach.
3508
3509         Added support to test aria-current on iOS.
3510
3511         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3512         (AccessibilityUIElement::stringAttributeValue):
3513         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3514         (WTR::AccessibilityUIElement::stringAttributeValue):
3515
3516 2015-09-18  Alexey Proskuryakov  <ap@apple.com>
3517
3518         iOS WebKitTestRunner frequently crashes in WKContextGetIconDatabase
3519         https://bugs.webkit.org/show_bug.cgi?id=149352
3520
3521         Reviewed by Simon Fraser.
3522
3523         * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
3524         m_context can be null. This may indicate a bug in webkitpy too, but
3525         WebKitTestRunner should handle this situation nicely, there is nothing intrinsically
3526         wrong with opening and immediately closing it.
3527
3528 2015-09-18  Daniel Bates  <dabates@apple.com>
3529
3530         isGitSVNDirectory() returns true when Git is not installed
3531         https://bugs.webkit.org/show_bug.cgi?id=149351
3532
3533         Reviewed by Alexey Proskuryakov.
3534
3535         Fixes an issue where VCSUtils::isGitSVNDirectory() returns true for any arbitrary directory if
3536         Git is not installed on the machine.
3537
3538         * Scripts/VCSUtils.pm:
3539         (isGitSVNDirectory): Ensure that `git config --get svn-remote.svn.fetch 2>& 1` exits with
3540         status code 0 (success).
3541
3542 2015-09-18  Alex Christensen  <achristensen@webkit.org>
3543
3544         Prevent build-webkit from building four times on Windows
3545         https://bugs.webkit.org/show_bug.cgi?id=149336
3546
3547         Reviewed by Brent Fulgham.
3548
3549         * Scripts/build-webkit:
3550         Move the Windows code out of the for loop iterating over each subdirectory to be build.
3551         They're built all at once.
3552         * Scripts/webkitdirs.pm:
3553         (buildVisualStudioProject):
3554         (cmakeGeneratedBuildfile):
3555         Don't generate the Visual Studio solution if it already exists.
3556         It will run CMake again if necessary.
3557
3558 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
3559
3560         [iOS WK2] WTR fails to set the key window in the UIKit sense
3561         https://bugs.webkit.org/show_bug.cgi?id=149325
3562
3563         Reviewed by Tim Horton.
3564
3565         -[WebKitTestRunnerWindow isKeyWindow] just returned _platformWebView->windowIsKey().
3566         This causes UIKit to bypass code that actually sets the key window, resulting in
3567         [UIAppliation sharedApplication].keyWindow always being nil.
3568
3569         Fix by PlatformWebView::setWindowIsKey() actually call -makeKeyWindow, and having
3570         -[WebKitTestRunnerWindow isKeyWindow] call super.
3571
3572         * WebKitTestRunner/PlatformWebView.h:
3573         (WTR::PlatformWebView::setWindowIsKey): Deleted.
3574         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3575         (WTR::PlatformWebView::setWindowIsKey):
3576         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3577         (WTR::PlatformWebView::setWindowIsKey):
3578         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3579         (-[WebKitTestRunnerWindow isKeyWindow]):
3580         (WTR::PlatformWebView::PlatformWebView):
3581         (WTR::PlatformWebView::~PlatformWebView):
3582         (WTR::PlatformWebView::setWindowIsKey):
3583         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3584         (WTR::PlatformWebView::setWindowIsKey):
3585
3586 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
3587
3588         [iOS WK2] When loading viewport tests, use the normal web page viewport configuration
3589         https://bugs.webkit.org/show_bug.cgi?id=149321
3590
3591         Reviewed by Tim Horton.
3592
3593         InjectedBundlePage::platformDidStartProvisionalLoadForFrame() unconditionally
3594         enabled the "testing" viewport configuration, which disables page scaling.
3595
3596         If we're running viewport tests, we want the normal web page configuration.
3597         Do that by passing a flag in the dictionary sent to InjectedBundle::beginTesting(),
3598         based on whether the test is in a "viewport" directory.
3599
3600         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3601         (WTR::InjectedBundle::beginTesting):
3602         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
3603         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Deleted.
3604         * WebKitTestRunner/TestInvocation.cpp:
3605         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
3606         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
3607         (WTR::TestInvocation::shouldMakeViewportFlexible):
3608         (WTR::TestInvocation::invoke):
3609         * WebKitTestRunner/TestInvocation.h:
3610         * WebKitTestRunner/ios/TestControllerIOS.mm:
3611         (WTR::TestController::platformConfigureViewForTest):
3612         (WTR::shouldMakeViewportFlexible): Deleted.
3613
3614 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
3615
3616         Give iOS WebKitTestRunner a launch storyboard
3617         https://bugs.webkit.org/show_bug.cgi?id=149314
3618
3619         Reviewed by Dan Bates.
3620
3621         Add a launch storyboard to iOS WebKitTestRunner so that Springboard recognizes
3622         that it's been built for specific device configurations, and puts the window
3623         at the top of the screen. This simplifies coordinate conversions in a future patch.
3624
3625         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3626         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
3627         * WebKitTestRunner/ios/Launch.storyboard: Added.