Tools/ChangeLog

   1 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
   2
   3         More debug queue build fixing.
   4
   5         Add build_style argument to derived classes as well.
   6
   7         * Scripts/webkitpy/common/config/ports.py:
   8         (MacPort):
   9         (MacPort.run_webkit_tests_command):
  10         (WinPort.run_bindings_tests_command):
  11         (WinPort):
  12         (WinPort.run_webkit_tests_command):
  13         (GtkWK2Port.build_webkit_command):
  14         (GtkWK2Port):
  15         (GtkWK2Port.run_webkit_tests_command):
  16
  17 2015-10-13  Myles C. Maxfield  <mmaxfield@apple.com>
  18
  19         [iOS] Build fix
  20
  21         Unreviewed.
  22
  23         Mach-O section names are limited to 16 characters.
  24
  25         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
  26         * DumpRenderTree/mac/DumpRenderTree.mm:
  27         (activateFontsIOS):
  28
  29 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
  30
  31         Build fix for mac-debug EWS queue.
  32
  33         Unreviewed.
  34
  35         Pass --debug to run-webkit-tests.
  36
  37         While at it, removed unsupported run_webkit_unit_tests_command. All the test steps
  38         will need to be substantially modified to work in EWS, so the dummy implementation
  39         was not helpful.
  40
  41         * Scripts/webkitpy/common/config/ports.py:
  42         (DeprecatedPort.run_javascriptcore_tests_command):
  43         (DeprecatedPort):
  44         (DeprecatedPort.run_webkit_tests_command):
  45         (DeprecatedPort.run_python_unittests_command):
  46         (DeprecatedPort.run_webkit_unit_tests_command): Deleted.
  47         * Scripts/webkitpy/common/config/ports_mock.py:
  48         (MockPort.run_javascriptcore_tests_command):
  49         (MockPort):
  50         (MockPort.run_webkit_tests_command):
  51         (MockPort.run_bindings_tests_command):
  52         (MockPort.run_webkit_unit_tests_command): Deleted.
  53         * Scripts/webkitpy/tool/commands/download_unittest.py:
  54         * Scripts/webkitpy/tool/steps/runtests.py:
  55         (RunTests.run):
  56         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
  57         (RunTestsTest.test_webkit_run_unit_tests):
  58         * Scripts/webkitpy/tool/steps/steps_unittest.py:
  59         (StepsTest.test_runtests_args):
  60
  61 2015-10-13  Brent Fulgham  <bfulgham@apple.com>
  62
  63         [Win] Generate Crash Traces
  64         https://bugs.webkit.org/show_bug.cgi?id=150103
  65
  66         Reviewed by Daniel Bates.
  67
  68         We were using an exception filter to try to emit "#CRASHED" to stderr
  69         when a test program crashed. However, the modern Python implementation
  70         seems capable of recognizing crashes on its own. Furthermore, registering
  71         the exception handler was preventing the JIT debugger (NTSD) from
  72         automatically attaching to the crashing program, so we were not getting
  73         crash traces.
  74
  75         * DumpRenderTree/win/DumpRenderTree.cpp:
  76         (main): Don't register an exception filter.
  77         (exceptionFilter): Deleted.
  78         * Scripts/webkitpy/common/system/crashlogs.py:
  79         (CrashLogs): Add another regular expression to handle a second crash trace
  80         syntax I encountered during testing.
  81         (CrashLogs._find_newest_log_win): If the old regular expression doesn't match,
  82         try the new one. The PID found by the new expression is in hexadecimal, so
  83         convert it to an integer before returning it.
  84         * Scripts/webkitpy/port/driver.py:
  85         (Driver._check_for_driver_crash_or_unresponsiveness): Windows was not recognizing
  86         the "#CRASHED" state because it was appending '\r\n', rather than just '\r'. Instead,
  87         check for "#CRASHED" after stripping off the EOL characters.
  88         * Scripts/webkitpy/port/win.py:
  89         (WinPort.setup_crash_log_saving): Put back the '-e %ld' flag in the debugger
  90         invocation. This is apparently used to signal an event when the debugger is finished.
  91
  92 2015-10-13  Alexey Proskuryakov  <ap@apple.com>
  93
  94         Mac Debug and 32-bit queues should be separate
  95         https://bugs.webkit.org/show_bug.cgi?id=150092
  96
  97         Reviewed by Lucas Forschler.
  98
  99         * QueueStatusServer/config/queues.py:
 100         * QueueStatusServer/model/queues.py:
 101         (Queue._capitalize_after_dash):
 102         (Queue._caplitalize_after_dash): Deleted.
 103         * Scripts/webkitpy/common/config/ews.json:
 104
 105 2015-10-13  Sergio Villar Senin  <svillar@igalia.com>
 106
 107         [GTK] Fix build for ENABLE_TOUCH_EVENTS=OFF
 108         https://bugs.webkit.org/show_bug.cgi?id=150085
 109
 110         Reviewed by Carlos Garcia Campos.
 111
 112         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
 113
 114 2015-10-13  Sebastian Dröge  <sebastian@centricular.com>
 115
 116         Unreviewed, add myself to the committers list.
 117
 118         * Scripts/webkitpy/common/config/contributors.json:
 119
 120 2015-10-12  Alexey Proskuryakov  <ap@apple.com>
 121
 122         Update bot watcher's dashboard to reflect that EWS is on iOS 9 now
 123         https://bugs.webkit.org/show_bug.cgi?id=149983
 124
 125         Reviewed by Dan Bates.
 126
 127         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
 128         (BubbleQueueServer):
 129         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
 130
 131 2015-10-12  Alexey Proskuryakov  <ap@apple.com>
 132
 133         Fix webkitpy tests after r190922.
 134
 135         * Scripts/webkitpy/common/config/ews.json:
 136         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
 137         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
 138
 139 2015-10-12  Alexey Proskuryakov  <ap@apple.com>
 140
 141         Add a Mac debug EWS queue
 142         https://bugs.webkit.org/show_bug.cgi?id=150069
 143
 144         Reviewed by Geoffrey Garen.
 145
 146         * QueueStatusServer/config/queues.py:
 147         * Scripts/webkitpy/common/config/ews.json:
 148         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
 149         (AbstractEarlyWarningSystem):
 150         (AbstractEarlyWarningSystem.archive_last_test_results):
 151         (AbstractEarlyWarningSystem.build_style):
 152         (AbstractEarlyWarningSystem.refetch_patch):
 153         (AbstractEarlyWarningSystem.load_ews_classes):
 154
 155 2015-10-12  Mario Sanchez Prada  <mario@endlessm.com>
 156
 157         [GTK] Update jhbuild's version of harfbuzz
 158         https://bugs.webkit.org/show_bug.cgi?id=149749
 159
 160         Reviewed by Martin Robinson.
 161
 162         Update harfbuzz to 0.9.35, following the lead of Debian Stable.
 163
 164         * gtk/jhbuild.modules: Updated details for harfbuzz.
 165
 166 2015-10-12  Mario Sanchez Prada  <mario@endlessm.com>
 167
 168         [GTK] Media tests crashing with gst-plugins-bad 1.4.4 and cpp 5.2
 169         https://bugs.webkit.org/show_bug.cgi?id=150026
 170
 171         Reviewed by Philippe Normand.
 172
 173         Backport upstream patch from gst-plugins-bad so that the right version
 174         of FAAD2 can be found with newer versions of cpp, so that gst-plugins-bad
 175         gets compiled properly, avoiding crashes on runtime while running tests.
 176
 177         * gtk/patches/gst-plugins-bad-fix-faad2-version-check.patch: Added.
 178         * gtk/jhbuild.modules: Referenced the newly added patch for gst-plugins-bad.
 179
 180 2015-10-11  Myles C. Maxfield  <mmaxfield@apple.com>
 181
 182         Test font-variant-* and font-feature-settings with mocked preinstalled fonts
 183         https://bugs.webkit.org/show_bug.cgi?id=149777
 184
 185         Reviewed by Simon Fraser.
 186
 187         Include FontWithFeatures in DumpRenderTree and WebKitTestRunner. Add it
 188         to the list of tests to preinstall at startup time.
 189
 190         Also, update the generation of the 'name' table in the FontWithFeatures font.
 191
 192         * DumpRenderTree/mac/DumpRenderTree.mm:
 193         (allowedFontFamilySet):
 194         (activateTestingFonts):
 195         (activateFontsIOS):
 196         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
 197         (Generator::generate):
 198         (Generator::appendCFFTable):
 199         (Generator::appendNameSubtable):
 200         (Generator::appendNAMETable):
 201         * FontWithFeatures/FontWithFeatures/main.cpp:
 202         (main):
 203         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
 204         (WTR::allowedFontFamilySet):
 205         (WTR::activateFonts):
 206         * WebKitTestRunner/mac/TestControllerMac.mm:
 207         (WTR::allowedFontFamilySet):
 208
 209 2015-10-11  Jinyoung Hur  <hur.ims@navercorp.com>
 210
 211         Unreviewed. Add Jinyoung Hur as a committer.
 212
 213         * Scripts/webkitpy/common/config/contributors.json:
 214
 215 2015-10-10  Dan Bernstein  <mitz@apple.com>
 216
 217         [iOS] Remove unnecessary iOS version checks
 218         https://bugs.webkit.org/show_bug.cgi?id=150002
 219
 220         Reviewed by Alexey Proskuryakov.
 221
 222         * WebKitTestRunner/ios/HIDEventGenerator.mm:
 223         (-[HIDEventGenerator _createIOHIDEventType:]):
 224         (-[HIDEventGenerator _sendHIDEvent:]):
 225         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
 226         * WebKitTestRunner/ios/UIKitSPI.h:
 227
 228 2015-10-09  Myles C. Maxfield  <mmaxfield@apple.com>
 229
 230         Unreviewed, rolling out r190689
 231         https://bugs.webkit.org/show_bug.cgi?id=149992
 232
 233         Fixed in other repository.
 234
 235         Reverted changesets:
 236
 237         "Unreviewed, rolling out r190572, r190593, r190594, and r190639."
 238         https://bugs.webkit.org/show_bug.cgi?id=149897
 239
 240 2015-10-09  Brian Burg  <bburg@apple.com>
 241
 242         Teach webkitperl how to figure out IOS versions from the SDK
 243         https://bugs.webkit.org/show_bug.cgi?id=149963
 244
 245         Reviewed by Daniel Bates.
 246
 247         It should be easier to check the major and minor version of IOS SDKs.
 248
 249         * Scripts/copy-webkitlibraries-to-product-directory: use iosVersion().
 250         * Scripts/webkitdirs.pm:
 251         (splitVersionString): Added.
 252         (determineOSXVersion): Use splitVersionString.
 253         (determineIOSVersion): Added. Look at the SDK version and make a tuple.
 254         (iosVersion): Added.
 255
 256 2015-10-09  Simon Fraser  <simon.fraser@apple.com>
 257
 258         [iOS WK2] Fix some leaks in TestRunnerWKWebView and UIScriptContext
 259         https://bugs.webkit.org/show_bug.cgi?id=149960
 260
 261         Reviewed by Tim Horton.
 262
 263         Use adoptWK(), and null out some members (file is not using ARC).
 264
 265         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
 266         (UIScriptContext::uiScriptComplete):
 267         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
 268         (-[TestRunnerWKWebView dealloc]):
 269
 270 2015-10-09  Csaba Osztrogonác  <ossy@webkit.org>
 271
 272         Remove ENABLE_SUID_SANDBOX_LINUX cruft
 273         https://bugs.webkit.org/show_bug.cgi?id=149954
 274
 275         Reviewed by Darin Adler.
 276
 277         * Scripts/webkitperl/FeatureList.pm:
 278
 279 2015-10-09  Daniel Bates  <dabates@apple.com>
 280
 281         Make iOS builders generate debug information in a separate dSYM file
 282         https://bugs.webkit.org/show_bug.cgi?id=149696
 283
 284         Reviewed by Darin Adler.
 285
 286         Similar to the Mac builders, the iOS builders should write debug information
 287         into a separate dSYM file instead of including such information in the binary
 288         itself (default Xcode behavior)
 289
 290         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 291         (CompileWebKit.start):
 292
 293 2015-10-09  Csaba Osztrogonác  <ossy@webkit.org>
 294
 295         Fix webkitpy tests after r190779
 296         https://bugs.webkit.org/show_bug.cgi?id=149949
 297
 298         Reviewed by Ryosuke Niwa.
 299
 300         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
 301         (BenchmarkResults.format):
 302         (BenchmarkResults._format_values):
 303
 304 2015-10-08  Dewei Zhu  <dewei_zhu@apple.com>
 305
 306         Extend run-benchmark script to support human-readable results conversion.
 307         https://bugs.webkit.org/show_bug.cgi?id=149944
 308
 309         Reviewed by Ryosuke Niwa.
 310
 311         Add '--read-results-json' and '--no-adjust-unit' options.
 312         '--read-results-json' option converts result file to human readable format.
 313         '--no-adjust-unit' option skips scientific notation convertion.
 314         '--platform' defaults to 'osx' and '--browser' defaults to 'safari'.
 315
 316         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
 317         (BenchmarkResults.format):
 318         (BenchmarkResults._format_tests):
 319         (BenchmarkResults._format_values):
 320         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
 321         (BenchmarkRunner.__init__):
 322         (BenchmarkRunner._run_benchmark):
 323         (BenchmarkRunner._dump):
 324         (BenchmarkRunner.show_results):
 325         (BenchmarkRunner._show_results): Deleted.
 326         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
 327         (parse_args):
 328         (start):
 329
 330 2015-10-08  Daniel Bates  <dabates@apple.com>
 331
 332         Add iOS 9 device builder to WebKit Bot Watcher's Dashboard
 333         https://bugs.webkit.org/show_bug.cgi?id=149945
 334
 335         Reviewed by Dan Bernstein.
 336
 337         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9.png: Added.
 338         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9@2x.png: Added.
 339         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
 340         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
 341         (WebKitBuildbot):
 342         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
 343         (table.queue-grid tr.platform.ios-9 img.logo):
 344
 345 2015-10-08  Daniel Bates  <dabates@apple.com>
 346
 347         Teach build-webkit to install LLVM binaries for iOS when building for device with the public iOS SDK
 348         https://bugs.webkit.org/show_bug.cgi?id=149943
 349
 350         Reviewed by Dan Bernstein.
 351
 352         Following the addition of the LLVM binaries for iOS in changeset r190759 (bug #149913) we should
 353         teach build-webkit to install them when building for iOS device using the public iOS SDK.
 354
 355         * Scripts/build-webkit:
 356
 357 2015-10-08  Daniel Bates  <dabates@apple.com>
 358
 359         Add LLVM binaries for iOS 9 device
 360         https://bugs.webkit.org/show_bug.cgi?id=149913
 361
 362         Reviewed by Filip Pizlo.
 363
 364         Implement support for building LLVM for ARM64-based iOS devices.
 365
 366         * Scripts/build-jsc: Enable the FTL when building for Mac or iOS device.
 367         * Scripts/copy-webkitlibraries-to-product-directory: Move logic to clean
 368         an existing build earlier in the file such that remove previously built
 369         libraries before building/copying new ones (if applicable).
 370         (fileContains): Moved function outside of if-block.
 371         (isContentOfFileEqualToString): Renamed; formerly named fileContentsEquals().
 372         (buildLLVM): Added. Extracted machinery to build LLVM into this function and
 373         added logic to build LLVM for ARM64-based iOS devices.
 374         (symlinkLLVMLibrariesIfNeeded): Added. Extracted machinery to symlink the built
 375         LLVM into the WebKitBuild directory.
 376
 377 2015-10-08  Alexey Proskuryakov  <ap@apple.com>
 378
 379         Crash-only queues on bot watcher's dashboard should not have non-crashing tests in popovers
 380         https://bugs.webkit.org/show_bug.cgi?id=149848
 381
 382         Reviewed by Darin Adler.
 383
 384         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
 385
 386 2015-10-07  Brent Fulgham  <bfulgham@apple.com>
 387
 388         [Win] Support 64-bit Build and Testing
 389         https://bugs.webkit.org/show_bug.cgi?id=149904
 390
 391         Reviewed by Daniel Bates.
 392
 393         Extend our existing scripts to support 64-bit build and test operations on
 394         Windows.
 395
 396         * Scripts/build-dumprendertree: We don't need to build DRT on its own;
 397         Windows always builds the whole stack.
 398         * Scripts/webkit-build-directory: Add an option to return the location of
 399         the executable files produced by a specific configuration. This change is
 400         actually useful for Gtk and EFL, too.
 401         * Scripts/webkitdirs.pm:
 402         (executableProductDir): Added. This function appends the proper binary
 403         path to the productDir. This is useful for Windows, Gtk, and EFL ports.
 404         (jscProductDir): Use the new 'executableProductDir' method.
 405         (setPathForRunningWebKitApp): Ditto.
 406         (runSafari): Ditto.
 407         (runMiniBrowser): Ditto.
 408         * Scripts/webkitpy/port/factory.py:
 409         (configuration_options): Add a 64-bit option, used on Windows to specify
 410         which binary target should be used for testing.
 411         * Scripts/webkitpy/port/win.py:
 412         (WinPort._port_flag_for_scripts): Added. Supply the 64-bit flag to child
 413         processes when needed.
 414         (WinPort._build_path): Add the correct binary target path to _build_path.
 415         (WinPort._ntsd_location): Check 32-bit paths when running 32-bit tests,
 416         64-bit paths for 64-bit tests.
 417         (WinPort.setup_crash_log_saving): Remove '-e %ld' argument, since the
 418         NTSD debugger does not understand this argument.
 419
 420 2015-10-07  Myles C. Maxfield  <mmaxfield@apple.com>
 421
 422         Test font-variant-* and font-feature-settings with TrueType fonts
 423         https://bugs.webkit.org/show_bug.cgi?id=149776
 424
 425         Reviewed by Simon Fraser.
 426
 427         This test extends our existing FontWithFeatures project to be able to generate a
 428         TrueType font. This font is conceptually similar as the existing OpenType font,
 429         except the feature -> character mapping is different.
 430
 431         The font itself only supports the following characters:
 432         ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
 433         However, the shape of these letters are either an X or a check mark.
 434         The letter "A" always is a check mark.
 435         The letter "B" always is an X.
 436         Each font feature has an letter associated with it. When the font feature is enabled,
 437         that letter is shown as a check mark. For example, when
 438         "kLowerCaseType / kLowerCaseSmallCapsSelector" is enabled, "S" is shown as a check
 439         mark.
 440
 441         Here are the mappings of font features to letters:
 442         kLigaturesType / kCommonLigaturesOnSelector: C
 443         kLigaturesType / kContextualLigaturesOnSelector: D
 444         kLigaturesType / kRareLigaturesOnSelector: G
 445         kLigaturesType / kHistoricalLigaturesOnSelector: I
 446         kContextualAlternatesType / kContextualAlternatesOnSelector: L
 447         kVerticalPositionType / kInferiorsSelector: O
 448         kVerticalPositionType / kSuperiorsSelector: P
 449         kLowerCaseType / kLowerCaseSmallCapsSelector: S
 450         kUpperCaseType / kUpperCaseSmallCapsSelector: V
 451         kLowerCaseType / kLowerCasePetiteCapsSelector: T
 452         kUpperCaseType / kUpperCasePetiteCapsSelector: W
 453         kLetterCaseType / 14: Y
 454         kStyleOptionsType / kTitlingCapsSelector: a
 455         kNumberCaseType / kUpperCaseNumbersSelector: c
 456         kNumberCaseType / kLowerCaseNumbersSelector: d
 457         kNumberSpacingType / kProportionalNumbersSelector: f
 458         kNumberSpacingType / kMonospacedNumbersSelector: g
 459         kFractionsType / kDiagonalFractionsSelector: i
 460         kFractionsType / kVerticalFractionsSelector: j
 461         kVerticalPositionType / kOrdinalsSelector: Q
 462         kTypographicExtrasType / kSlashedZeroOnSelector: k
 463         kLigaturesType / kHistoricalLigaturesOnSelector: K
 464         kCharacterShapeType / kJIS1978CharactersSelector: m
 465         kCharacterShapeType / kJIS1983CharactersSelector: n
 466         kCharacterShapeType / kJIS1990CharactersSelector: o
 467         kCharacterShapeType / kJIS2004CharactersSelector: p
 468         kCharacterShapeType / kSimplifiedCharactersSelector: q
 469         kCharacterShapeType / kTraditionalCharactersSelector: r
 470         kTextSpacingType / kMonospacedTextSelector: t
 471         kTextSpacingType / kProportionalTextSelector: u
 472         kRubyKanaType / kRubyKanaOnSelector: v
 473
 474         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj:
 475         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
 476         (CFFBuilder::moveTo):
 477         (CFFBuilder::lineTo):
 478         (GLYFBuilder::GLYFBuilder):
 479         (GLYFBuilder::takeResult):
 480         (GLYFBuilder::moveTo):
 481         (GLYFBuilder::lineTo):
 482         (GLYFBuilder::closePath):
 483         (GLYFBuilder::writePoint):
 484         (GLYFBuilder::append16):
 485         (generateBoxCharString):
 486         (generateCheckCharString):
 487         (generateXCharString):
 488         (itemForGlyph):
 489         (Generator::generate):
 490         (Generator::insertSelector):
 491         (Generator::insertFeature):
 492         (Generator::generateFeatureDescription):
 493         (Generator::appendCFFTable):
 494         (Generator::appendGLYFTable):
 495         (Generator::appendLOCATable):
 496         (Generator::appendFEATTable):
 497         (Generator::appendMetamorphosisChain):
 498         (Generator::appendMORXTable):
 499         (Generator::appendHEADTable):
 500         (Generator::appendHMTXTable):
 501         (Generator::appendNameSubtable):
 502         (Generator::append2ByteASCIIString):
 503         (Generator::appendNAMETable):
 504         (generateFont):
 505         (CFFBuilder::curveToCubic): Deleted.
 506         (charStringForGlyph): Deleted.
 507         * FontWithFeatures/FontWithFeatures/FontCreator.h:
 508         * FontWithFeatures/FontWithFeatures/main.cpp:
 509         (constructFontWithTrueTypeFeature):
 510         (constructFontWithOpenTypeFeature):
 511         (drawText):
 512         (main):
 513         (drawTextWithFeature): Deleted.
 514
 515 2015-10-07  Commit Queue  <commit-queue@webkit.org>
 516
 517         Unreviewed, rolling out r190572, r190593, r190594, and
 518         r190639.
 519         https://bugs.webkit.org/show_bug.cgi?id=149897
 520
 521         Breaks Mavericks build (Requested by litherum on #webkit).
 522
 523         Reverted changesets:
 524
 525         "Allow WKRetainPtrs to be used as keys in hashing data
 526         structures"
 527         https://bugs.webkit.org/show_bug.cgi?id=149762
 528         http://trac.webkit.org/changeset/190572
 529
 530         "REGRESSION(189668?): http/tests/notifications/events.html
 531         flakily asserts or times out"
 532         https://bugs.webkit.org/show_bug.cgi?id=149218
 533         http://trac.webkit.org/changeset/190593
 534
 535         "Prospective Mavericks build fix."
 536         http://trac.webkit.org/changeset/190594
 537
 538         "Post-review cleanup after r190572."
 539         http://trac.webkit.org/changeset/190639
 540
 541 2015-10-06  Michael Catanzaro  <mcatanzaro@igalia.com>
 542
 543         [GTK] Add autocleanups
 544         https://bugs.webkit.org/show_bug.cgi?id=149588
 545
 546         Reviewed by Darin Adler.
 547
 548         * TestWebKitAPI/Tests/WebKit2Gtk/AutocleanupsTest.cpp: Added.
 549         (AutocleanupsTest::create):
 550         (AutocleanupsTest::testWebProcessAutocleanups):
 551         (registerTests):
 552         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
 553         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutocleanups.cpp: Added.
 554         (testUIProcessAutocleanups):
 555         (testWebProcessAutocleanups):
 556         (beforeAll):
 557         (afterAll):
 558
 559 2015-10-06  Brian Burg  <bburg@apple.com>
 560
 561         Unreviewed, try to fix the iOS 8 build after r190368.
 562
 563         On older versions, IOHIDEventCreateForceEvent is not available.
 564
 565         * WebKitTestRunner/ios/HIDEventGenerator.mm:
 566         (-[HIDEventGenerator _createIOHIDEventType:]): Add another guard for force events.
 567
 568 2015-10-06  Keith Miller  <keith_miller@apple.com>
 569
 570         Add gmalloc option to run-javascriptcore-tests.
 571         https://bugs.webkit.org/show_bug.cgi?id=149858
 572
 573         Reviewed by Geoffrey Garen.
 574
 575         run-javascriptcore-tests takes a new option --gmalloc with an optional string argument, the path to the gmalloc dylib.
 576         If no argument is provided then /usr/lib/libgmalloc.dylib is used by default.
 577
 578         * Scripts/run-javascriptcore-tests:
 579
 580 2015-10-06  Myles C. Maxfield  <mmaxfield@apple.com>
 581
 582         Post-review cleanup after r190572.
 583
 584         Unreviewed.
 585
 586         * TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp:
 587
 588 2015-10-06  Brent Fulgham  <bfulgham@apple.com>
 589
 590         [Win] Unreviewed build correction.
 591
 592         * TestWebKitAPI/PlatformWin.cmake: We don't need to link to all of these libraries. Most
 593         are soft-linked at runtime.
 594
 595 2015-10-06  Keith Miller  <keith_miller@apple.com>
 596
 597         Fix run-javascriptcore-tests/run-jsc-stress-tests to work with rootless, add a --quick option and deprecate the Mozilla driver.
 598         https://bugs.webkit.org/show_bug.cgi?id=149815
 599
 600         Reviewed by Filip Pizlo.
 601
 602         Rootless has an issue where it will strip any environment variables that start with DYLD starting a perl/ruby/python script.
 603         Now, run-jsc-stress-tests takes an new argument, --env-vars, that will set the specified environment variables before
 604         running tests. Additionally, I added a quick option that only runs default and the NoCJITValidate versions of each test.
 605         Finally, I removed the calls to the mozilla jsDriver.pl since the run-jsc-stress-tests runner runs the same test suite
 606         so should just use one test runner.
 607
 608         * Scripts/run-javascriptcore-tests:
 609         (runJSCStressTests):
 610         (runMozillaTests): Deleted.
 611         (defaultJsDriverArgsForMozillaTests): Deleted.
 612         * Scripts/run-jsc-stress-tests:
 613
 614 2015-10-06  Mark Salisbury  <mark.salisbury@hp.com>
 615
 616         [GTK] Make update-webkitgtk-libs work behind firewall
 617
 618         update-webkitgtk-libs can work behind a firewall with changes to
 619         a few packages.  Where outbound git and active FTP connections
 620         fail, using http protocol succeeds.  Most packages are
 621         already accessed using http.
 622
 623         https://bugs.webkit.org/show_bug.cgi?id=148941
 624
 625         Reviewed by Martin Robinson.
 626
 627         Tools
 628         * gtk/jhbuild.modules:
 629             Replace git URLs with http.  Remove no longer used ftp repositories.
 630             Update argument for libxml2's autogen.sh script (--without-python
 631             is ignored; --with-python=no is correct).
 632         * jhbuild/jhbuild-wrapper:
 633             Instead of connecting to git://git.gnome.org/jhbuild, connect to
 634             http://git.gnome.org/browse/jhbuild.
 635
 636 2015-10-06  Daniel Bates  <dbates@webkit.org>
 637
 638         Enable XSLT when building WebKit for iOS using the public iOS SDK
 639         https://bugs.webkit.org/show_bug.cgi?id=149827
 640
 641         Reviewed by Alexey Proskuryakov.
 642
 643         Teach script configure-xcode-for-ios-development to copy the OS X XSLT headers to the iPhoneOS
 644         and iPhoneSimulator SDKs so as to support building WebKit for iOS with XSLT. A person must
 645         run this script before building WebKit for iOS or the build will fail because one or more XSLT
 646         headers cannot be found.
 647
 648         * Scripts/configure-xcode-for-ios-development:
 649         (copyMissingXSLTHeadersToSDKIfNeeded): Added.
 650
 651 2015-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
 652
 653         REGRESSION(189668?): http/tests/notifications/events.html flakily asserts or times out
 654         https://bugs.webkit.org/show_bug.cgi?id=149218
 655
 656         Reviewed by Alexey Proskuryakov.
 657
 658         Because of r189668, WebKitTestRunner now tears down and recreates its WKNotificationManagerRef
 659         when the TestOptions change. Previously, WebNotificationProvider only could handle a single
 660         WKNotificationManagerRef. Because the ower of the WKNotificationManagerRef is reference counted,
 661         and AppKit internally retains some objects which end up retaining the WKNotificationManagerRef,
 662         the old WKNotificationManager may not be destroyed before the new one is created. Therefore,
 663         WebNotificationProvider must be updated to appropriately handle multiple
 664         WKNotificationManagerRefs in flight at the same time.
 665
 666         * WebKitTestRunner/WebNotificationProvider.cpp:
 667         (WTR::WebNotificationProvider::~WebNotificationProvider):
 668         (WTR::WebNotificationProvider::showWebNotification):
 669         (WTR::WebNotificationProvider::closeWebNotification):
 670         (WTR::WebNotificationProvider::addNotificationManager):
 671         (WTR::WebNotificationProvider::removeNotificationManager):
 672         (WTR::WebNotificationProvider::simulateWebNotificationClick):
 673         (WTR::WebNotificationProvider::reset):
 674         * WebKitTestRunner/WebNotificationProvider.h:
 675
 676 2015-10-05  Daniel Bates  <dabates@apple.com>
 677
 678         Disable Bitcode when building for iOS device
 679         https://bugs.webkit.org/show_bug.cgi?id=149818
 680
 681         Reviewed by Alexey Proskuryakov.
 682
 683         Xcode 7 generates bitcode for iOS device apps by default. Do not generate bitcode
 684         when building for iOS device.
 685
 686         * Scripts/webkitdirs.pm:
 687         (XcodeOptions):
 688
 689 2015-10-05  Daniel Bates  <dabates@apple.com>
 690
 691         [iOS] Make it possible to build WebKit using iphoneos SDK without a developer certificate installed
 692         https://bugs.webkit.org/show_bug.cgi?id=140828
 693         <rdar://problem/19520599>
 694
 695         Reviewed by Alexey Proskuryakov.
 696
 697         Support building WebKit for iOS device without an iOS Developer certificate installed. Otherwise,
 698         we will pass CODE_SIGN_IDENTITY="iPhone Developer: " to Xcode to find a iOS Developer certificate
 699         to use. To use a specific installed iOS Developer certificate, explicitly pass CODE_SIGN_IDENTITY
 700         to build-webkit.
 701
 702         * Scripts/webkitdirs.pm:
 703         (XcodeOptions): Cleaned up code. When building for iOS device, pass to Xcode CODE_SIGN_IDENTITY="iPhone Developer: "
 704         to code sign using the installed iOS development certificate (if it exists - we assume there is only one such certificate).
 705         Otherwise, pass CODE_SIGN_IDENTITY="" and CODE_SIGNING_REQUIRED=NO to Xcode to disable code signing.
 706         (hasIOSDevelopmentCertificate): Added.
 707
 708 2015-10-05  Daniel Bates  <dabates@apple.com>
 709
 710         DumpRenderTree built with public iOS SDK crashes under -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
 711         https://bugs.webkit.org/show_bug.cgi?id=149766
 712
 713         Reviewed by Alexey Proskuryakov.
 714
 715         Create network storage testing session on iOS.
 716
 717         Currently we do not create a network storage testing session on iOS. A network storage testing session always
 718         has an associated cookie store. When WebKit is built without USE(CFNETWORK), NetworkStorageSession::defaultStorageSession().cookieStorage()
 719         returns nullptr because the caller is expected to interact with NSHTTPCookieStorage instead of querying
 720         NetworkStorageSession for the cookie store. When WebKit is built with USE(CFNETWORK) accessing
 721         NetworkStorageSession::defaultStorageSession().cookieStorage() returns a valid cookie store (creating one if
 722         it does not exist). Instead we should make use of NetworkStorageSession::switchToNewTestingSession() to
 723         create a network storage testing session when building DumpRenderTree for iOS so as to ensure a consistent
 724         testing environment regardless of whether we built with USE(CFNETWORK). This will also make the behavior of
 725         DumpRenderTree on iOS more consistent with the behavior of DumpRenderTree on Mac.
 726
 727         As a side effect of this change DumpRenderTree no longer crashes in -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
 728         when WebKit is built without USE(CFNETWORK) because NetworkStorageSession::defaultStorageSession().cookieStorage()
 729         returns a non-null pointer to a cookie store.
 730
 731         * DumpRenderTree/mac/DumpRenderTree.mm:
 732         (prepareConsistentTestingEnvironment):
 733
 734 2015-10-05  Simon Fraser  <simon.fraser@apple.com>
 735
 736         Fix the iOS 8 build again, where -[UIApplication _enqueueHIDEvent:] is not
 737         available.
 738
 739         * WebKitTestRunner/ios/HIDEventGenerator.mm:
 740         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
 741
 742 2015-10-05  Myles C. Maxfield  <mmaxfield@apple.com>
 743
 744         Allow WKRetainPtrs to be used as keys in hashing data structures
 745         https://bugs.webkit.org/show_bug.cgi?id=149762
 746
 747         Reviewed by Anders Carlsson.
 748
 749         * TestWebKitAPI/PlatformGTK.cmake:
 750         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 751         * TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp: Added.
 752         (TestWebKitAPI::TEST):
 753
 754 2015-10-05  Simon Fraser  <simon.fraser@apple.com>
 755
 756         Fix the iOS 8 build, where -[UIApplication _enqueueHIDEvent:] is not
 757         available, and tidy up the #ifdefs in the UIKitSPI header.
 758
 759         * WebKitTestRunner/ios/HIDEventGenerator.mm:
 760         (-[HIDEventGenerator _sendHIDEvent:]):
 761         * WebKitTestRunner/ios/UIKitSPI.h:
 762
 763 2015-10-04  Zan Dobersek  <zdobersek@igalia.com>
 764
 765         [GTK] Remove duplicate entries in WebKitTestRunner_SOURCES
 766         https://bugs.webkit.org/show_bug.cgi?id=149792
 767
 768         Reviewed by Martin Robinson.
 769
 770         * WebKitTestRunner/PlatformGTK.cmake: Don't list build targets
 771         for WebKitTestRunner multiple times.
 772
 773 2015-10-04  Daniel Bates  <dabates@apple.com>
 774
 775         Fix the Apple Internal iOS build after <http://trac.webkit.org/changeset/190515>
 776         (https://bugs.webkit.org/show_bug.cgi?id=149753)
 777
 778         For now, support calling build-layouttestrelay without --ios-simulator so long
 779         as we are building on a Mac.
 780
 781         * Scripts/build-layouttestrelay:
 782
 783 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
 784
 785         Support Trac 1.0.x XML timeline link format
 786         https://bugs.webkit.org/show_bug.cgi?id=149786
 787
 788         Reviewed by Lucas Forschler.
 789
 790         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
 791         (Trac.prototype._convertCommitInfoElementToObject):
 792
 793 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
 794
 795         Fix some errors on bot watcher's dashboard
 796         https://bugs.webkit.org/show_bug.cgi?id=149789
 797
 798         Reviewed by Lucas Forschler.
 799
 800         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
 801         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): We may not get to layout
 802         tests step, in which case layoutTestResults.tooManyFailures would raise an exception.
 803
 804 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
 805
 806         Bot watcher's dashboard builders should turn yellow when svn fails
 807         https://bugs.webkit.org/show_bug.cgi?id=149791
 808
 809         Reviewed by Lucas Forschler.
 810
 811         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
 812         (BuildbotBuilderQueueView.prototype.appendBuilderQueueStatus):
 813         (BuildbotBuilderQueueView.prototype.update):
 814
 815 2015-10-02  Daniel Bates  <dabates@apple.com>
 816
 817         Add iOS 9 Simulator builders and testers to WebKit Bot Watcher's Dashboard
 818         https://bugs.webkit.org/show_bug.cgi?id=149769
 819
 820         Reviewed by Alexey Proskuryakov.
 821
 822         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator.png: Added.
 823         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator@2x.png: Added.
 824         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
 825         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
 826         (WebKitBuildbot):
 827         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
 828         (table.queue-grid tr.platform.ios-simulator-9 img.logo):
 829
 830 2015-10-02  Ryosuke Niwa  <rniwa@webkit.org>
 831
 832         REGRESSION(r190370): Speedometer spits out an extra console message
 833         https://bugs.webkit.org/show_bug.cgi?id=149720
 834
 835         Unreviewed. Temporarily ignore the console error message.
 836
 837         * Scripts/webkitpy/performance_tests/perftest.py:
 838         (PerfTest._filter_output):
 839
 840 2015-10-02  Brent Fulgham  <bfulgham@apple.com>
 841
 842         Provide "--no-ninja" option to avoid using Ninja
 843         https://bugs.webkit.org/show_bug.cgi?id=149757
 844
 845         Reviewed by Alex Christensen.
 846
 847         Add a new command line argument understood by webkitdirs.pm so
 848         that we can conditionally avoid using Ninja. This is an
 849         'opt-out' argument, so no existing Ninja users should be affected.
 850
 851         * Scripts/webkitdirs.pm:
 852         (canUseNinja): Check for option and block ninja if present.
 853
 854 2015-10-02  Aakash Jain  <aakash_jain@apple.com>
 855
 856         Flakiness dashboard should support OS X El Capitan
 857         https://bugs.webkit.org/show_bug.cgi?id=149648
 858
 859         Reviewed by Alexey Proskuryakov.
 860
 861         * TestResultServer/static-dashboards/flakiness_dashboard.js: Fix the broken dashboard for ElCapitan.
 862
 863 2015-10-02  Daniel Bates  <dabates@apple.com>
 864
 865         Fix run-webkit-tests --ios-simulator after <http://trac.webkit.org/changeset/190515>
 866         (https://bugs.webkit.org/show_bug.cgi?id=149753)
 867
 868         For now, pass --ios-simulator.
 869
 870         * Scripts/webkitpy/port/ios.py:
 871         (IOSSimulatorPort._build_relay):
 872
 873 2015-10-02  Simon Fraser  <simon.fraser@apple.com>
 874
 875         Remove a "nullable" that breaks the iOS 8 build.
 876
 877         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
 878         (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]):
 879
 880 2015-10-02  Daniel Bates  <dabates@apple.com>
 881
 882         LayoutTestRelay is not built and archived when building for iOS Simulator
 883         https://bugs.webkit.org/show_bug.cgi?id=149753
 884
 885         Reviewed by Alexey Proskuryakov and Andy Estes.
 886
 887         Towards running layout tests on the iOS Simulator test bots, we need to teach scripts build-webkit
 888         and built-product-archive to build the Mac tool LayoutTestRelay and include this tool in the built
 889         product archive when building for iOS Simulator, respectively.
 890
 891         * BuildSlaveSupport/built-product-archive:
 892         (main): Pass the full platform name (options.platform) to archiveBuiltProduct() so that it can
 893         differentiate between iOS device and iOS Simulator platforms.
 894         (webkitBuildDirectoryForConfigurationAndPlatform): Extracted logic to run the script webkit-build-directory
 895         from determineWebKitBuildDirectories() into this function so that it can be used by both
 896         determineWebKitBuildDirectories() and archiveBuiltProduct().
 897         (determineWebKitBuildDirectories): Moved logic to execute the script webkit-build-directory from here to
 898         webkitBuildDirectoryForConfigurationAndPlatform().
 899         (createZip): Added parameter embedParentDirectoryNameOnDarwin (defaults to False) to specify whether
 900         we should call ditto(1) with --keepParent to embed the parent directory name in the zip archive. This
 901         argument is only applicable when building on Darwin. We only pass embedParentDirectoryNameOnDarwin=True
 902         when making an archive for a Mac or iOS device build. For iOS Simulator builds we archive two directories
 903         and we do not want to keep the parent directory because it is a placeholder directory used as a workaround
 904         for the limitation that ditto(1) can only accept a single directory to archive on its command line.
 905         (archiveBuiltProduct): Modified to take the full platform name as an argument. Added logic for iOS.
 906         For iOS device builds we use the same logic as for a Mac build and archive the configuration-specific
 907         build directory. For iOS Simulator builds we archive the configuration-specific iOS build directory,
 908         LayoutTestRelay and LayoutTestRelay.dSYM (if it exists) from the configuration-specific Mac build.
 909         * Scripts/build-layouttestrelay:
 910             - Remove unnecessary include of Perl module POSIX.
 911             - Only build LayoutTestRelay when building for iOS Simulator (i.e. --ios-simulator is passed).
 912         * Scripts/build-webkit:
 913             - Invoke script build-layouttestrelay when building for iOS Simulator.
 914
 915 2015-10-02  Brent Fulgham  <bfulgham@apple.com>
 916
 917         [Win] Unreviewed test fix.
 918
 919         You cannot run 'run-webkit-tests' from the command line because it does not know
 920         to append the binary subdirectory (bin32/bin64). We don't see this on our builders
 921         because they explicitly set use the 'root' argument to provide the full path to
 922         the test binaries.
 923
 924         * Scripts/webkitpy/port/win.py:
 925         (WinPort._build_path): Added.
 926
 927 2015-10-02  Alex Christensen  <achristensen@webkit.org>
 928
 929         Reloading without content blockers doesn't apply to resource loads after the main frame finishes
 930         https://bugs.webkit.org/show_bug.cgi?id=149430
 931         rdar://problem/22742222
 932
 933         Reviewed by Geoffrey Garen.
 934
 935         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
 936         (WTR::TestController::cocoaResetStateToConsistentValues):
 937         * WebKitTestRunner/mac/TestControllerMac.mm:
 938         (WTR::TestController::platformConfigureViewForTest):
 939         Test what happens when you disable content blockers from the SPI.
 940
 941 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
 942
 943         [Win] Unreviewed build fix for run-api-tests
 944
 945         * Scripts/run-api-tests:
 946         (testToolPaths): Windows run needs to specify the binary path.
 947
 948 2015-10-01  Daniel Bates  <dabates@apple.com>
 949
 950         Another attempt to fix the Windows builders after <https://trac.webkit.org/changeset/190387>
 951         (https://bugs.webkit.org/show_bug.cgi?id=149695)
 952
 953         Following r190424 we can now rely on webkit-build-directory to return the path to
 954         the correct configuration-specific build directory on Windows.
 955
 956         * BuildSlaveSupport/built-product-archive:
 957         (archiveBuiltProduct):
 958
 959 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
 960
 961         [Win] Unreviewed build fix.
 962
 963         * Scripts/webkitdirs.pm:
 964         (setupAppleWinEnv): Use 64-bit build tools if available
 965
 966 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
 967
 968         [Win] Fix TestWebKitAPI build under CMake.
 969
 970         Reviewed by Alex Christensen.
 971
 972         * TestWebKitAPI/PlatformWin.cmake: Add missing link command
 973         for Psapi.lib.
 974
 975 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
 976
 977         [Win] Fix behavior of webkit-build-directory script
 978         https://bugs.webkit.org/show_bug.cgi?id=149718
 979
 980         Reviewed by Alex Christensen.
 981
 982         * Scripts/webkitdirs.pm:
 983         (determineConfigurationProductDir): Do not include the binary
 984         sub-directory in the configuration product directory output.
 985         (jscProductDir): Append correct binary path for Windows build.
 986         (setPathForRunningWebKitApp): Include properly binary subdirectories.
 987         (runSafari): Update for revised productDir behavior.
 988         (runMiniBrowser): Ditto.
 989
 990 2015-10-01  Alexey Proskuryakov  <ap@apple.com>
 991
 992         Stop building LayoutTestRelay for now. It's a Mac project, but build-webkit tries to
 993         use iOS SDK, like with all the others.
 994
 995         * Scripts/build-webkit:
 996
 997 2015-10-01  Daniel Bates  <dabates@apple.com>
 998
 999         Attempt to fix the iOS 9 Simulator testers
1000
1001         Add dependency DumpRenderTree.app to target All of project DumpRenderTree so that we
1002         build DumpRenderTree.app, if applicable. Also, teach build-webkit to build project
1003         LayoutTestRelay when building for iOS Simulator.
1004
1005         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1006         * Scripts/build-webkit:
1007
1008 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1009
1010         [GTK] Websites with invalid auth header keep loading forever
1011         https://bugs.webkit.org/show_bug.cgi?id=149710
1012
1013         Reviewed by Martin Robinson.
1014
1015         Add test case to check that we can authenticate sites with an
1016         empty realm.
1017
1018         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
1019         (testWebViewAuthenticationEmptyRealm):
1020         (serverCallback):
1021         (beforeAll):
1022
1023 2015-10-01  Alexey Proskuryakov  <ap@apple.com>
1024
1025         [Mac] Make run-api-tests work with System Integrity Protection
1026         https://bugs.webkit.org/show_bug.cgi?id=149711
1027         rdar://problem/22928202
1028
1029         Reviewed by Dan Bernstein.
1030
1031         * Scripts/run-api-tests:
1032         (runTest):
1033         (archCommandLineArgumentsForRestrictedEnvironmentVariables):
1034
1035 2015-10-01  Daniel Bates  <dabates@apple.com>
1036
1037         Attempt to fix the Windows build after <https://trac.webkit.org/changeset/190387>
1038         (https://bugs.webkit.org/show_bug.cgi?id=149695)
1039
1040         For some reason built-product-archive hardcodes the assumption that we build for 32-bit Windows.
1041         For now, use the path to the top-level WebKit build directory instead of using the configuration-
1042         specific build directory.
1043
1044         * BuildSlaveSupport/built-product-archive:
1045         (archiveBuiltProduct):
1046
1047 2015-10-01  Csaba Osztrogonác  <ossy@webkit.org>
1048
1049         [EFL] Fix the openwebrtc and gst-plugins-openwebrtc build with clang
1050         https://bugs.webkit.org/show_bug.cgi?id=145837
1051
1052         Reviewed by Philippe Normand.
1053
1054         * efl/jhbuild.modules:
1055         * efl/patches/openwebrtc-clang-warning-fix.patch: Added.
1056         * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Added.
1057
1058 2015-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1059
1060         Unreviewed. Fix the iOS build after r190407.
1061
1062         * WebKitTestRunner/ios/IOKitSPI.h:
1063
1064 2015-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1065
1066         Implement keyboard event sending for iOS in WebKitTestRunner
1067         https://bugs.webkit.org/show_bug.cgi?id=149676
1068
1069         Reviewed by Simon Fraser.
1070
1071         Adds support for generating and sending key events in WebKitTestRunner. This is accomplished in a similar
1072         way as touch events, using IOHIDEvent machinery. Also adds callbacks to the UIScriptController JS API that
1073         allows us to run code when the keyboard is shown or hidden.
1074
1075         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Adds the typeCharacter JS interface.
1076         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1077         (WTR::UIScriptController::setDidShowKeyboardCallback):
1078         (WTR::UIScriptController::didShowKeyboardCallback):
1079         (WTR::UIScriptController::setDidHideKeyboardCallback):
1080         (WTR::UIScriptController::didHideKeyboardCallback):
1081         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
1082         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
1083         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
1084         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1085         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1086         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1087         (-[TestRunnerWKWebView initWithFrame:configuration:]): Registers the TestRunnerWKWebView to listen to
1088                 the notifications that the keyboard has been raised or lowered.
1089         (-[TestRunnerWKWebView _keyboardDidShow:]):
1090         (-[TestRunnerWKWebView _keyboardDidHide:]):
1091         * WebKitTestRunner/ios/HIDEventGenerator.h:
1092         * WebKitTestRunner/ios/HIDEventGenerator.m:
1093         (-[HIDEventGenerator _sendIOHIDKeyboardEvent:usage:isKeyDown:]): Helper to send a HID keyboard event.
1094         (shouldWrapWithShiftKeyEventForCharacter): Helper used to generate key events.
1095         (hidUsageCodeForCharacter): Ditto.
1096         (-[HIDEventGenerator keyDown:completionBlock:]): Synthesizes and sends HIDKeyboardEvents, triggering
1097                 a keyDown event in WebKit.
1098         * WebKitTestRunner/ios/IOKitSPI.h:
1099         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1100
1101 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1102
1103         Unreviewed, rolling out r190399.
1104
1105         Tests are still failing even after r190362
1106
1107         Reverted changeset:
1108
1109         "Unreviewed. Unskip GTK+ user media unit tests after r190362."
1110         http://trac.webkit.org/changeset/190399
1111
1112 2015-10-01  Csaba Osztrogonác  <ossy@webkit.org>
1113
1114         [jhbuild] switch to new upstream usrsctp library
1115         https://bugs.webkit.org/show_bug.cgi?id=149494
1116
1117         Reviewed by Philippe Normand.
1118
1119         * efl/jhbuild.modules:
1120         * gtk/jhbuild.modules:
1121
1122 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1123
1124         Unreviewed. Unskip GTK+ user media unit tests after r190362.
1125
1126         They should pass now.
1127
1128         * Scripts/run-gtk-tests:
1129         (TestRunner):
1130
1131 2015-09-30  Daniel Bates  <dabates@apple.com>
1132
1133         Another attempt to fix the build after <https://trac.webkit.org/changeset/190387>
1134         (https://bugs.webkit.org/show_bug.cgi?id=149695)
1135
1136         * BuildSlaveSupport/built-product-archive:
1137         (determineWebKitBuildDirectories): Substitute _configurationBuildDirectory for _buildDirectory.
1138         (extractBuiltProduct): Substitute _topLevelBuildDirectory for _buildDirectory.
1139
1140 2015-09-30  Daniel Bates  <dabates@apple.com>
1141
1142         Attempt to fix the build after <https://trac.webkit.org/changeset/190387>
1143         (https://bugs.webkit.org/show_bug.cgi?id=149695)
1144
1145         Actually, we need to pass --configuration to script webkit-build-directory to have
1146         it return the path to the configuration-specific build directory.
1147
1148         * BuildSlaveSupport/built-product-archive:
1149         (determineWebKitBuildDirectories):
1150
1151 2015-09-30  Daniel Bates  <dabates@apple.com>
1152
1153         built-product-archive archives incorrect build directory for iOS port
1154         https://bugs.webkit.org/show_bug.cgi?id=149695
1155
1156         Reviewed by Darin Adler.
1157
1158         Fixes an issue where the script built-product-archive archives a non-existent
1159         build directory for the iOS port. Without loss of generality, the script assumes
1160         the path to the Release configuration build for iOS is in directory WebKitBuild/Release.
1161         But the built products for this configuration are in directory WebKitBuild/Release-iphonesimulator.
1162
1163         Currently the script built-product-archive calls `webkit-build-directory --top-level ...`
1164         to determine the top-level build directory and computes the configuration-specific
1165         build directory to be the concatenation of the the top-level build directory and
1166         the configuration (e.g. Release). This is incorrect. Instead we should call
1167         webkit-build-directory omitting the flag --top-level to compute the path to the
1168         configuration-specific build directory.
1169
1170         * BuildSlaveSupport/built-product-archive: Fix up the style such that we use single quoted literals.
1171         (main): Renamed global variable _buildDirectory to _topLevelBuildDirectory to better describe
1172         its purpose and added global variable _configurationBuildDirectory to store the path
1173         to the configuration-specific build directory. Ensure that we have a non-empty string
1174         for both the top-level and configuration-specific build directories.
1175         (determineWebKitBuildDirectories): Formerly named determineWebKitBuildDirectory.
1176         Compute the configuration-specific build directory and store it in the global variable
1177         _configurationBuildDirectory.
1178         (archiveBuiltProduct): Modified to use _configurationBuildDirectory.
1179         (extractBuiltProduct): Modified to use _configurationBuildDirectory and _topLevelBuildDirectory
1180         as needed.
1181         (determineWebKitBuildDirectory): Deleted.
1182
1183 2015-09-30  Hunseop Jeong  <hs85.jeong@samsung.com>
1184
1185         [EFL] css3/device-adapt/* tests failed after r190335.
1186         https://bugs.webkit.org/show_bug.cgi?id=149655
1187
1188         Reviewed by Simon Fraser.
1189
1190         device-adapt/* tests need the fixedLayout option but useFixedLayout option is
1191         overwritten by updatePlatformSpecificViewOptionsForTest after r190335.
1192
1193         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1194         (WTR::shouldUseFixedLayout):
1195
1196 2015-09-30  Dewei Zhu  <dewei_zhu@apple.com>
1197
1198         Extend JetStream timeout for slow devices.
1199
1200         Reviewed by Chris Dumez.
1201
1202         Extend JetStream timeout to 20 minutes.
1203
1204         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
1205
1206 2015-09-30  Daniel Bates  <dabates@apple.com>
1207
1208         Rename iOS builders/testers to include version
1209         https://bugs.webkit.org/show_bug.cgi?id=149685
1210
1211         Reviewed by Simon Fraser.
1212
1213         Substitute "Apple iOS 9" for "Apple iOS" in the names of iOS builders/testers so as
1214         make it clear to a reader the version of iOS these builders/testers are using.
1215
1216         * BuildSlaveSupport/build.webkit.org-config/config.json:
1217         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1218
1219 2015-09-30  Daniel Bates  <dabates@apple.com>
1220
1221         Add iOS criterion for triggering a build
1222         https://bugs.webkit.org/show_bug.cgi?id=149679
1223
1224         Rubber-stamped by Alexey Proskuryakov.
1225
1226         First pass at defining criterion for triggering an iOS build.
1227
1228         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1229         (_should_file_trigger_build):
1230         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1231         (ShouldBuildTest):
1232         (ShouldBuildTest.test_should_build):
1233
1234 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
1235
1236         [iOS] Allow tests to generate user gestures for UI testing
1237         https://bugs.webkit.org/show_bug.cgi?id=149653
1238
1239         Reviewed by Tim Horton.
1240
1241         Expose functionality in UIScriptController to allow for testing single- and double-tap,
1242         and to listen for completion of scrolling and zooming in the WKWebView.
1243
1244         Tap generation is done using synthetic IOHIDEvents, via a new HIDEventGenerator class
1245         which hides the complexity of creating these events. Event dispatch is asynchronous.
1246         We detect when the last event has been handled by dispatching a vendor-specific event,
1247         which is detected via -_handleHIDEvent: in our UIApplication subclass.
1248
1249         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Link with IOKit.
1250         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Two new properties
1251         for 'will begin zooming' and 'did end zooming' callbacks, and functions to dispatch
1252         single and double taps.
1253         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
1254         (UIScriptContext::registerCallback): Used to store the callbacks for zooming.
1255         Unlike the "task" callbacks, these are persistent, but we store them in the same hash map.
1256         (UIScriptContext::unregisterCallback):
1257         (UIScriptContext::callbackWithID):
1258         (UIScriptContext::fireCallback):
1259         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
1260         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1261         (WTR::UIScriptController::setWillBeginZoomingCallback): Cross-platform code.
1262         (WTR::UIScriptController::willBeginZoomingCallback): Ditto.
1263         (WTR::UIScriptController::setDidEndZoomingCallback):
1264         (WTR::UIScriptController::didEndZoomingCallback):
1265         (WTR::UIScriptController::singleTapAtPoint): Non-iOS stub.
1266         (WTR::UIScriptController::doubleTapAtPoint): Ditto.
1267         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
1268         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
1269         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1270         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1271         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Properties for the zooming callbacks.
1272         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1273         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]): Dispatch the zooming callback.
1274         (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]): Ditto.
1275         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]): Ditto.
1276         (-[TestRunnerWKWebView onDidEndZooming:]): Deleted.
1277         * WebKitTestRunner/ios/HIDEventGenerator.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
1278         * WebKitTestRunner/ios/HIDEventGenerator.m: Added.
1279         (simpleDragCurve):
1280         (calculateNextLocation):
1281         (delayBetweenMove):
1282         (+[HIDEventGenerator sharedHIDEventGenerator]):
1283         (+[HIDEventGenerator nextEventCallbackID]):
1284         (-[HIDEventGenerator init]):
1285         (-[HIDEventGenerator _createIOHIDEventType:]):
1286         (-[HIDEventGenerator _sendHIDEvent:]):
1287         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
1288         (-[HIDEventGenerator _updateTouchPoints:count:]):
1289         (-[HIDEventGenerator touchDownAtPoints:touchCount:]):
1290         (-[HIDEventGenerator touchDown:touchCount:]):
1291         (-[HIDEventGenerator touchDown:]):
1292         (-[HIDEventGenerator liftUpAtPoints:touchCount:]):
1293         (-[HIDEventGenerator liftUp:touchCount:]):
1294         (-[HIDEventGenerator liftUp:]):
1295         (-[HIDEventGenerator moveToPoints:touchCount:duration:]):
1296         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
1297         (-[HIDEventGenerator tap:completionBlock:]):
1298         (-[HIDEventGenerator doubleTap:completionBlock:]):
1299         (-[HIDEventGenerator twoFingerTap:completionBlock:]):
1300         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
1301         (-[HIDEventGenerator pinchCloseWithStartPoint:endPoint:duration:completionBlock:]):
1302         (-[HIDEventGenerator pinchOpenWithStartPoint:endPoint:duration:completionBlock:]):
1303         (-[HIDEventGenerator markerEventReceived:]):
1304         * WebKitTestRunner/ios/IOKitSPI.h: Added.
1305         * WebKitTestRunner/ios/UIKitSPI.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
1306         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1307         (WTR::globalToContentCoordinates):
1308         (WTR::UIScriptController::singleTapAtPoint):
1309         (WTR::UIScriptController::doubleTapAtPoint):
1310         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
1311         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
1312         * WebKitTestRunner/ios/mainIOS.mm:
1313         (-[WebKitTestRunnerApp _handleHIDEvent:]):
1314
1315 2015-09-30  Dana Burkart  <dburkart@apple.com>
1316
1317         git-add-reviewer should trim trailing spaces/newlines
1318         https://bugs.webkit.org/show_bug.cgi?id=149513
1319
1320         Reviewed by Darin Adler.
1321
1322         * Scripts/git-add-reviewer:
1323         (nonInteractive):
1324
1325 2015-09-30  Eric Carlson  <eric.carlson@apple.com>
1326
1327         REGRESSION(r190262): User media unit test failures after r190262
1328         https://bugs.webkit.org/show_bug.cgi?id=149580
1329
1330         Reviewed by Darin Adler.
1331
1332         * WebKitTestRunner/TestController.cpp:
1333         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Fix parameter
1334           order to WKUserMediaPermissionRequestAllow.
1335
1336 2015-09-30  Daniel Bates  <dabates@apple.com>
1337
1338         Add iOS builders and testers
1339         https://bugs.webkit.org/show_bug.cgi?id=149549
1340
1341         Reviewed by Alexey Proskuryakov.
1342
1343         Adds definitions for 64-bit iOS Simulator release builders and testers and a iOS device
1344         builder that builds universal release binaries for armv7, armv7s and arm64 architectures.
1345
1346         * BuildSlaveSupport/build.webkit.org-config/config.json: Add definitions for builders and testers.
1347         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Update unit tests.
1348
1349 2015-09-30  Timothy Hatcher  <timothy@apple.com>
1350
1351         Give WebKitLauncher the get-task-allow entitlement to allow it to work on El Capitan
1352         https://bugs.webkit.org/show_bug.cgi?id=149674
1353
1354         Reviewed by Lucas Forschler.
1355
1356         * WebKitLauncher/WebKitLauncher.entitlements: Added.
1357         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1358
1359 2015-09-30  Jason Marcell  <jmarcell@apple.com>
1360
1361         BuildbotQueueView.prototype._appendPendingRevisionCount should skip repositories that don't
1362         have an associated trac instance.
1363         https://bugs.webkit.org/show_bug.cgi?id=149673
1364
1365         Reviewed by Alexey Proskuryakov.
1366
1367         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1368         (BuildbotQueueView.prototype._appendPendingRevisionCount): Skip repositories that don't
1369         have an associated trac instance.
1370
1371 2015-09-30  Daniel Bates  <dabates@apple.com>
1372
1373         Prioritize testing latest build request on iOS test bots
1374         https://bugs.webkit.org/show_bug.cgi?id=149669
1375
1376         Reviewed by Darin Adler.
1377
1378         We should prioritize testing of the latest build request on the iOS test bots
1379         as we do for Mac and Windows test bots.
1380
1381         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1382         (loadBuilderConfig):
1383
1384 2015-09-30  Daniel Bates  <dabates@apple.com>
1385
1386         Add buildbot category for iOS builders and testers
1387         https://bugs.webkit.org/show_bug.cgi?id=149667
1388
1389         Reviewed by Darin Adler.
1390
1391         Group iOS builders and testers under category iOS and add dashboard and console hyperlinks
1392         for iOS to the build.webkit.org home page.
1393
1394         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1395         (loadBuilderConfig):
1396         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1397
1398 2015-09-30  Daniel Bates  <dabates@apple.com>
1399
1400         Actually fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
1401         (https://bugs.webkit.org/show_bug.cgi?id=149539)
1402
1403         I inadvertently didn't remove the ONLY_ACTIVE_ARCH=NO flag when building on a Mac
1404         in <http://trac.webkit.org/changeset/190351>.
1405
1406         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1407         (CompileWebKit.start):
1408
1409 2015-09-30  Daniel Bates  <dabates@apple.com>
1410
1411         Attempt to fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
1412         (https://bugs.webkit.org/show_bug.cgi?id=149539)
1413
1414         {32, 64}-bit Mac builders should not try to build project {Plugin.64, Plugin.32},
1415         respectively; only pass ONLY_ACTIVE_ARCH=NO when building for iOS.
1416
1417         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1418         (CompileWebKit.start):
1419
1420 2015-09-30  Lucas Forschler  <lforschler@apple.com>
1421
1422         bot210 was configured for a queue instead of bot126.
1423
1424         Unreviewed config.json fix.
1425
1426         * BuildSlaveSupport/build.webkit.org-config/config.json:
1427
1428 2015-09-30  Lucas Forschler  <lforschler@apple.com>
1429
1430         Bring El Capitan buildbot infrastructure online.
1431         https://bugs.webkit.org/show_bug.cgi?id=149605
1432
1433         Reviewed by Darin Adler.
1434
1435         * BuildSlaveSupport/build.webkit.org-config/config.json:
1436
1437 2015-09-30  Tomas Popela  <tpopela@redhat.com>
1438
1439         [GTK] Deprecation warnings in DOMNodeTest
1440         https://bugs.webkit.org/show_bug.cgi?id=149663
1441
1442         After the webkit_dom_document_get_elements_by_tag_name deprecation we
1443         need to update the tests to use webkit_dom_document_query_selector_all
1444         to avoid compilation warnings.
1445
1446         Also add a new test for webkit_dom_document_get_elements_by_tag_name_as_html_collection
1447         (the suggested replacement for the deprecated function).
1448
1449         Reviewed by Carlos Garcia Campos.
1450
1451         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
1452         (WebKitDOMNodeTest::testTagNamesNodeList):
1453         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
1454         (registerTests):
1455         (WebKitDOMNodeTest::testTagNames): Deleted.
1456         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
1457         (prepareDOMForTagNamesTests):
1458         (testWebKitDOMNodeTagNamesNodeList):
1459         (testWebKitDOMNodeTagNamesHTMLCollection):
1460         (beforeAll):
1461         (testWebKitDOMNodeTagNames): Deleted.
1462
1463 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
1464
1465         WebKitTestRunner fails to apply "useFlexibleViewport" when it's specified in a file comment
1466         https://bugs.webkit.org/show_bug.cgi?id=149650
1467
1468         Reviewed by Tim Horton.
1469
1470         TestInvocation::invoke() consulted shouldMakeViewportFlexible(), but that only
1471         looks at the file path, and not the custom options that come from file comments.
1472
1473         Fix by computing TestOptions before making the TestInvocation, and setting them
1474         as const TestInvocation data. This meant changing various call sites to take
1475         the std::string pathOrURL, rather than the TestInvocation itself.
1476
1477         Also initialize TestInvocation with a WKURLRef, rather than a std::string.
1478
1479         * WebKitTestRunner/CMakeLists.txt:
1480         * WebKitTestRunner/TestController.cpp:
1481         (WTR::TestController::ensureViewSupportsOptionsForTest):
1482         (WTR::testPath):
1483         (WTR::createTestURL):
1484         (WTR::updateTestOptionsFromTestHeader):
1485         (WTR::TestController::testOptionsForTest):
1486         (WTR::TestController::updateWebViewSizeForTest):
1487         (WTR::TestController::updateWindowScaleForTest):
1488         (WTR::TestController::runTest):
1489         * WebKitTestRunner/TestController.h:
1490         * WebKitTestRunner/TestInvocation.cpp:
1491         (WTR::TestInvocation::TestInvocation):
1492         (WTR::TestInvocation::invoke):
1493         (WTR::createWKURL): Deleted.
1494         (WTR::TestInvocation::shouldMakeViewportFlexible): Deleted.
1495         (WTR::TestInvocation::shouldUseFixedLayout): Deleted.
1496         * WebKitTestRunner/TestInvocation.h:
1497         (WTR::TestInvocation::options):
1498         * WebKitTestRunner/TestOptions.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
1499         (WTR::pathContains):
1500         (WTR::shouldMakeViewportFlexible):
1501         (WTR::shouldUseFixedLayout):
1502         (WTR::isSVGTestPath):
1503         (WTR::isHiDPITestPath):
1504         (WTR::TestOptions::TestOptions):
1505         * WebKitTestRunner/TestOptions.h:
1506         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1507         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1508         (WTR::pathContains):
1509         (WTR::shouldUseFixedLayout):
1510         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1511         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1512         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1513         * WebKitTestRunner/ios/TestControllerIOS.mm:
1514         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1515         * WebKitTestRunner/mac/TestControllerMac.mm:
1516         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1517
1518 2015-09-29  Aakash Jain  <aakash_jain@apple.com>
1519
1520         Flakiness dashboard should support OS X El Capitan
1521         https://bugs.webkit.org/show_bug.cgi?id=149648
1522
1523         Reviewed by Alexey Proskuryakov.
1524
1525         * QueueStatusServer/app.yaml: We do not need to maintain SVN revision here because of
1526         difference between new appscale and old Google App Engine implementation.
1527         * TestResultServer/app.yaml: Same.
1528         * TestResultServer/static-dashboards/builders.jsonp: Added OSX El Capitan support.
1529
1530 2015-09-29  Daniel Bates  <dabates@apple.com>
1531
1532         configure-xcode-for-ios-development does not work with Xcode 7
1533         https://bugs.webkit.org/show_bug.cgi?id=149640
1534
1535         Reviewed by Alexey Proskuryakov.
1536
1537         When Xcode 7 is installed, running configure-xcode-for-ios-development dies with an error
1538         because it cannot find the Xcode specification files for iOS simulator and device. These
1539         files have moved to a new location in Xcode 7 distribution. Moreover we must add the
1540         relevant definitions to the Xcode 7 specification files directly as opposed to creating
1541         new specification files with the added definitions (as we did in older versions of Xcode)
1542         in order for Xcode 7 to honor these definitions.
1543
1544         * Scripts/configure-xcode-for-ios-development: Sorted forward declarations.
1545         (updateXcodeSpecificationFilesForSDKIfNeeded): Added.
1546         (updateXcode7SpecificationFile): Added.
1547         (createLegacyXcodeSpecificationFilesForSDKIfNeeded): Formerly named createXcodeSpecificationFilesForSDKIfNeeded.
1548         (writeXcodeSpecification): Moved congratulations line to caller so as to write out the
1549         appropriate success message.
1550         (mergeXcodeSpecificationWithSpecificationAndId): Formerly named createXcodeSpecificationFromSpecificationAndId.
1551         (createXcodeSpecificationFilesForSDKIfNeeded): Deleted.
1552         (createXcodeSpecificationFromSpecificationAndId): Deleted.
1553
1554 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
1555
1556         [Win] Allow 'prepare-ChangeLog' to be used without Cygwin
1557         https://bugs.webkit.org/show_bug.cgi?id=149639
1558
1559         Reviewed by Alex Christensen.
1560
1561         * Scripts/VCSUtils.pm:
1562         (exitStatus): Use 'isWindows()' method.
1563         (isSVNVersion16OrNewer): 'eval' is not needed here, and just causes
1564         an error. This method could probably just go away.
1565         (normalizePath): Leave Windows (or Unix) paths as platform paths, rather than
1566         always changing to Unix style.
1567         (unixPath): Added. Needed so Windows can always show a Unix path in the
1568         ChangeLog file.
1569         (changeLogName): Work around the fact that 'getpwuid' is not available on
1570         a pure Windows build of Perl.
1571         * Scripts/prepare-ChangeLog:
1572         (generateFunctionLists): Normalize path received from 'svn' in case it's a Unix
1573         path on Windows.
1574         (svnUpdateCommand): Added helper function. Needed because Windows Perl does not
1575         support using arrays for 'open' arguments.
1576         (resolveChangeLogsPath): Ditto.
1577         (resolveConflictedChangeLogs): Use new helper functions.
1578         (generateNewChangeLogs): Force Windows to use Unix paths in ChangeLog output.
1579         (diffCommand): Use double-quotes for paths, since Windows doesn't understand single
1580         quotes. Unix systems are happy either way.
1581         (statusCommand): Ditto.
1582         * Scripts/webkitdirs.pm:
1583         (launcherName): Drive-by fix. WinLauncher was renamed to MiniBrowser some time ago.
1584
1585 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
1586
1587         [Win] Unreviewed 64-bit build fix after switch to CMake.
1588
1589         * Scripts/webkitdirs.pm:
1590         (determineIsWin64FromArchitecture): Added.
1591
1592 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1593
1594         printing does not use minimum page zoom factor
1595         https://bugs.webkit.org/show_bug.cgi?id=108507
1596
1597         Reviewed by Darin Adler.
1598
1599         WebKitTestRunner always takes the snapshots from the UI process
1600         (expect for IOS), so in the case of printing, the layout in the
1601         web view is not the expected one. When printing, we need to take
1602         the snapshot in the web process and ensure it's rendered with a
1603         PrintContext.
1604
1605         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1606         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
1607         kWKSnapshotOptionsPrinting option to
1608         WKBundlePageCreateSnapshotWithOptions() when printing.
1609
1610 2015-09-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1611
1612         [WTR] Pixel tests generate the snapshots twice in Web and UI processes
1613         https://bugs.webkit.org/show_bug.cgi?id=149595
1614
1615         Reviewed by Tim Horton.
1616
1617         All ports except IOS implement
1618         PlatformWebView::windowSnapshotImage() to generate the snapshot
1619         for the pixel tests in the UI process. But we are still generating
1620         a snapshot for pixel tests in the Web process too, that is passed
1621         to the UI process but ignored.
1622         Whether a pixel result is needed or not, is only known by the web
1623         process depending on whether the test called dumpAsText with
1624         dumpPixels == true or not. Since the pixels are now dump in the UI
1625         process, we need to pass that information to the UI process when
1626         the test is done. For that we set a PixelResultIsPending bool
1627         parameter to the Done message, and we only add the PixelResult
1628         when UI process doesn't need to generate the pixels dump.
1629
1630         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1631         (WTR::InjectedBundle::didReceiveMessageToPage): Set
1632         m_pixelResultIsPending to false on reset.
1633         (WTR::InjectedBundle::done): Add PixelResultIsPending parameter to the
1634         Done message, and set the PixelResult if m_pixelResultIsPending is false.
1635         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1636         (WTR::InjectedBundle::setPixelResult): Set m_pixelResultIsPending to false.
1637         (WTR::InjectedBundle::setNeedsPixelResult): Set m_pixelResultIsPending.
1638         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1639         (WTR::InjectedBundlePage::dump): Only create a snapshot for IOS
1640         port.
1641         * WebKitTestRunner/TestInvocation.cpp:
1642         (WTR::TestInvocation::dumpResults): Use either the pixel result
1643         from the web process or generate a pixel result from the web view
1644         if need it.
1645         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1646         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
1647         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
1648         is created by the caller now, but the CG implementation needs to
1649         know if it's a Web or UI process snapshot.
1650         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1651         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
1652         cairo surface for the given image.
1653         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1654         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
1655         CGContext for the given image.
1656
1657 2015-09-28  Dean Johnson  <dean_johnson@apple.com>
1658
1659         Fix JS errors on dashboard metrics page
1660         https://bugs.webkit.org/show_bug.cgi?id=149608
1661
1662         Reviewed by Alexey Proskuryakov.
1663
1664         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Updated to use Settings.
1665         (initPlatformsByFamily):
1666         (updateHiddenPlatforms):
1667         (parsePlatformFamily): Deleted.
1668         (updateToggleButtons): Deleted.
1669         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
1670         (updateHiddenPlatforms): Added to remove errors.
1671         (initPlatformsByFamily): Added to remove errors.
1672         (unhiddenQueues): Updated to use Settings.
1673         (documentReady): Added logic to add toggle buttons to the settings menu.
1674         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
1675         (Settings.prototype.parsePlatformFamily): Moved duplicate logic from Main.js and
1676         MetricsMain.js to Settings.
1677         (Settings.prototype.updateToggleButtons): Moved duplicate logic from Main.js and
1678         MetricsMain.js to Settings.
1679         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
1680         (QueueView.prototype._updateHiddenState): Updated to use Settings.
1681
1682 2015-09-28  Aakash Jain  <aakash_jain@apple.com>
1683
1684         Appscale query fails because of missing index
1685         https://bugs.webkit.org/show_bug.cgi?id=149609
1686
1687         Reviewed by Darin Adler.
1688
1689         * QueueStatusServer/index.yaml: Added the required index.
1690
1691 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
1692
1693         [Win] Fix the 64-bit build after switch to cmake.
1694
1695         Reviewed by Alex Christensen.
1696
1697         * Scripts/webkitdirs.pm:
1698         (generateBuildSystemFromCMakeProject): Use correct arguments for cmake to
1699         run a 64-bit build.
1700
1701 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
1702
1703         [Win] Allow Windows to run test-webkitpy without Cygwin
1704         https://bugs.webkit.org/show_bug.cgi?id=149602
1705
1706         Reviewed by Alex Christensen.
1707
1708         These changes mostly shift from hard-coded paths using UNIX-style
1709         separators to Python's "os.path.join" syntax that uses the correct
1710         path separator for each platform.
1711
1712         * Scripts/webkitpy/common/system/path.py:
1713         (cygpath): Don't pass paths through Cygpath on native Windows.
1714         * Scripts/webkitpy/port/win.py:
1715         (WinPort._path_to_apache): Use os.path.join.
1716         (WinPort._ntsd_location): Support 64-bit environment (ProgramW6432 doesn't exist
1717         in 64-bit environments).
1718         * Scripts/webkitpy/style/checker.py: Use os.path.join.
1719         * Scripts/webkitpy/style/checker_unittest.py:
1720         (GlobalVariablesTest.test_path_rules_specifier.assertNoCheck): Use os.path.join.
1721         (GlobalVariablesTest.test_path_rules_specifier): Ditto.
1722         (GlobalVariablesTest): Ditto.
1723         (GlobalVariablesTest.test_max_reports_per_category): Ditto.
1724         (CheckerDispatcherSkipTest.test_should_skip_with_warning): Ditto.
1725         (CheckerDispatcherDispatchTest.test_js_paths): Ditto.
1726         (CheckerDispatcherDispatchTest.test_json_paths): Ditto.
1727         (CheckerDispatcherDispatchTest.test_python_paths): Ditto.
1728         (CheckerDispatcherDispatchTest.test_text_paths): Ditto.
1729         (CheckerDispatcherDispatchTest.test_xml_paths): Ditto.
1730         (StyleProcessor_CodeCoverageTest._create_carriage_checker_class): Ditto.
1731         (StyleProcessor_CodeCoverageTest): Ditto.
1732         (StyleProcessor_CodeCoverageTest.test_should_process__skip_without_warning): Ditto.
1733         (StyleProcessor_CodeCoverageTest.test_should_process__skip_with_warning): Ditto.
1734         (StyleProcessor_CodeCoverageTest.test_should_process__true_result): Ditto.
1735         * Scripts/webkitpy/w3c/test_parser_unittest.py: Uses os.path.join rather than
1736         manual string concatenation of paths.
1737
1738 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
1739
1740         Add bugzilla addresses of committers to contributors.json
1741         https://bugs.webkit.org/show_bug.cgi?id=149520
1742
1743         Reviewed by Darin Adler.
1744
1745         * Scripts/webkitpy/common/config/contributors.json:
1746
1747 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
1748
1749         validate-committer-lists -b shouldn't need edituser privileges
1750         https://bugs.webkit.org/show_bug.cgi?id=149519
1751
1752         Reviewed by Darin Adler.
1753
1754         * Scripts/validate-committer-lists:
1755         (CommitterListBugzillaChecker._has_invalid_bugzilla_email):
1756         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1757         (BugzillaQueries.is_invalid_bugzilla_email):
1758         (BugzillaQueries): Deleted.
1759         (BugzillaQueries.fetch_logins_matching_substring): Deleted.
1760
1761 2015-09-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1762
1763         Unreviewed. Gardening: skip media stream tests failing after r190262.
1764
1765         * Scripts/run-gtk-tests:
1766         (TestRunner):
1767
1768 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
1769
1770         [Mac] USE_INTERNAL_SDK is used undefined in tools projects
1771         https://bugs.webkit.org/show_bug.cgi?id=149571
1772
1773         Reviewed by Dan Bernstein.
1774
1775         Use the same pattern as in Source directory configurations (so, also get rid of AspenFamily.xcconfig).
1776
1777         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1778         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1779         * LayoutTestRelay/Configurations/Base.xcconfig:
1780         * MiniBrowser/Configurations/Base.xcconfig:
1781         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1782         * TestWebKitAPI/Configurations/Base.xcconfig:
1783         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1784         * WebEditingTester/Configurations/Base.xcconfig:
1785         * WebEditingTester/Configurations/DebugRelease.xcconfig:
1786         * WebKitTestRunner/Configurations/Base.xcconfig:
1787         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1788         * WebKitTestRunner/iOS.xcconfig: Removed.
1789
1790 2015-09-25  Eric Carlson  <eric.carlson@apple.com>
1791
1792         Clean up user media request internal API
1793         https://bugs.webkit.org/show_bug.cgi?id=149527
1794
1795         Reviewed by Tim Horton.
1796
1797         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
1798         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): Update for API changes.
1799
1800         * WebKitTestRunner/TestController.cpp:
1801         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Ditto.
1802
1803 2015-09-25  Simon Fraser  <simon.fraser@apple.com>
1804
1805         [iOS WK2] Add viewport tests and fix runUIScript() timing issues
1806         https://bugs.webkit.org/show_bug.cgi?id=149577
1807
1808         Reviewed by Tim Horton.
1809
1810         When calling testRunner.runUIScript() from a page load event, the script could run
1811         in the UI process before the current remote layer tree transaction had been handled
1812         there. This meant that runUIScript() could query state which was about to change.
1813
1814         Fix by delaying the execution of the UI script until a layer tree transaction has
1815         been handled by the UI process, leveraging the existing DrawingAreaProxy::dispatchAfterEnsuringDrawing().
1816
1817         * WebKitTestRunner/TestInvocation.cpp:
1818         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1819         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
1820         * WebKitTestRunner/TestInvocation.h:
1821
1822 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
1823
1824         [Mac] Media tests start to time out after a few days of bot uptime
1825         https://bugs.webkit.org/show_bug.cgi?id=149468
1826
1827         Reviewed by Darin Adler.
1828
1829         Delete cache directory in addition to the temporary one. Don't delete /private/tmp/MediaCache,
1830         as it's not longer used by tests. Set TMPDIR and DIRHELPER_USER_DIR_SUFFIX to make
1831         all temporary and cache files go to a custom location.
1832
1833         * Scripts/webkitpy/port/base.py:
1834         * Scripts/webkitpy/port/driver.py:
1835         * Scripts/webkitpy/port/mac.py:
1836         * Scripts/webkitpy/port/win.py:
1837         (WinPort._driver_tempdir_for_environment): Deleted unused function.
1838
1839 2015-09-25  Dan Bernstein  <mitz@apple.com>
1840
1841         Removed MiniBrowser.entitlements.
1842
1843         Rubber-stamped by Anders Carlsson.
1844
1845         The entitlements weren’t used anyway.
1846
1847         * MiniBrowser/MiniBrowser.entitlements: Removed.
1848         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1849
1850 2015-09-24  Daniel Bates  <dabates@apple.com>
1851
1852         Add WebKitSystemInterface for iOS 9.0
1853         https://bugs.webkit.org/show_bug.cgi?id=149550
1854
1855         Rubber-stamped by Alexey Proskuryakov.
1856
1857         * Scripts/copy-webkitlibraries-to-product-directory:
1858
1859 2015-09-24  Daniel Bates  <dabates@apple.com>
1860
1861         Support building for arbitrary architectures
1862         https://bugs.webkit.org/show_bug.cgi?id=149539
1863
1864         Reviewed by Alexey Proskuryakov.
1865
1866         Teach buildbot to pass the architectures associated with the builder to build-webkit
1867         when building on OS X and iOS. As a side effect of this change we now support building
1868         universal binaries when multiples architectures are specified.
1869
1870         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1871         (CompileWebKit.start):
1872
1873 2015-09-24  Daniel Bates  <dabates@apple.com>
1874
1875         Fix the build after <http://trac.webkit.org/changeset/190212>
1876         (http://trac.webkit.org/changeset/190212)
1877
1878         I inadvertently did not remove the fullPlatform argument from one of the callers of archiveBuiltProduct().
1879
1880         * BuildSlaveSupport/built-product-archive:
1881         (main):
1882
1883 2015-09-24  Daniel Bates  <dabates@apple.com>
1884
1885         Support running unit tests on iOS Simulator test bot
1886         https://bugs.webkit.org/show_bug.cgi?id=149536
1887
1888         Reviewed by Alexey Proskuryakov.
1889
1890         Implements support for running unit tests on a iOS test bot. At the time of writing,
1891         the script run-api-tests supports running unit tests on Mac, Windows and iOS Simulator.
1892
1893         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1894         (RunUnitTests.start): Append appropriate command line flag when invoking script run-api-tests.
1895         (TestFactory.__init__): Add step RunUnitTests when the test bot is for the iOS Simulator platform.
1896
1897 2015-09-24  Daniel Bates  <dabates@apple.com>
1898
1899         Add support infrastructure for OpenSource iOS builders and testers
1900         https://bugs.webkit.org/show_bug.cgi?id=149534
1901
1902         Reviewed by Darin Adler.
1903
1904         Towards setting up OpenSource iOS build bots, teach buildbot and its support
1905         scripts about iOS.
1906
1907         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1908         (appendCustomBuildFlags): Require the caller to pass parameter fullPlatform and append
1909         --ios-simulator or --device for a builder/tester whose full platform name begins with
1910         "ios-simulator" or "ios", respectively.
1911         (RunJavaScriptCoreTests.start): Pass the full platform name to appendCustomBuildFlags().
1912         * BuildSlaveSupport/built-product-archive:
1913         (main): Pass the full platform name to determineWebKitBuildDirectory().
1914         (determineWebKitBuildDirectory): Call script webkit-build-directory with the appropriate
1915         command line flag when building for iOS.
1916         (archiveBuiltProduct): Use the same logic for iOS as we do for Mac. Also, remove unused
1917         parameter fullPlatform. This parameter was originally added in r125066 to support the
1918         Chromium Android port, which has since been removed from the OpenSource WebKit Project.
1919         (extractBuiltProduct): Use the same logic for iOS as we do for Mac.
1920         * BuildSlaveSupport/clean-build:
1921         (main): Call script webkit-build-directory with the appropriate command line flag when
1922         building for iOS.
1923         * BuildSlaveSupport/delete-stale-build-files:
1924         (main): Use the same logic for iOS as we do for Mac.
1925         (webkitBuildDirectory): Call script webkit-build-directory with the appropriate command line
1926         flag when building for iOS.
1927         * BuildSlaveSupport/test-result-archive:
1928         (archiveTestResults): Use the same logic for iOS as we do for Mac.
1929
1930 2015-09-24  Daniel Bates  <dabates@apple.com>
1931
1932         Remove Chromium-specific changes to script built-product-archive
1933         https://bugs.webkit.org/show_bug.cgi?id=149530
1934
1935         Rubber-stamped by Csaba Osztrogonác.
1936
1937         Reverts changes made in r113074 and r113067 to support Chromium testers. The
1938         Chromium code has long since been removed from the OpenSource WebKit Project.
1939
1940         * BuildSlaveSupport/built-product-archive:
1941         (createZipManually):
1942         (createZip):
1943         (archiveBuiltProduct):
1944
1945 2015-09-24  Dan Bernstein  <mitz@apple.com>
1946
1947         Build fix.
1948
1949         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1950
1951 2015-09-24  Mark Lam  <mark.lam@apple.com>
1952
1953         Unreviewed. Make Lucas Forschler a WebKit reviewer.
1954
1955         * Scripts/webkitpy/common/config/contributors.json:
1956
1957 2015-09-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1958
1959         Unreviewed. Fix GObject DOM API breaks after r190120.
1960
1961         Bring back code removed in r169931 to handle documentation of
1962         deleted classes.
1963
1964         * gtk/webkitdom.py:
1965         (WebKitDOMDocGenerator):
1966         (WebKitDOMDocGenerator.write_deleted_classes):
1967         (WebKitDOMDocGenerator.generate):
1968         (write_deleted_classes):
1969         (WebKitDOMDocGeneratorSections._deleted_class):
1970         (WebKitDOMDocGeneratorSections._deleted_class.in):
1971         (WebKitDOMDocGeneratorSections.write_deleted_classes):
1972         (WebKitDOMDocGeneratorSections.write_deleted_classes.with):
1973
1974 2015-09-23  Myles C. Maxfield  <mmaxfield@apple.com>
1975
1976         [Cocoa] [Font Features] Implement font-variant-*
1977         https://bugs.webkit.org/show_bug.cgi?id=148413
1978
1979         Reviewed by Darin Adler.
1980
1981         Update test font to use "lnum" feature.
1982
1983         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
1984         (Generator::appendGSUBTable):
1985
1986 2015-09-22  Andy Estes  <aestes@apple.com>
1987
1988         ContentFiltering.AllowDownloadAfterAddData is very flaky
1989         https://bugs.webkit.org/show_bug.cgi?id=148885
1990         <rdar://problem/22729563>
1991
1992         Reviewed by Alexey Proskuryakov.
1993
1994         The AllowDownload* tests were relying on -_downloadDidStart: being called before -webView:didFinishNavigation:,
1995         but there is no guarantee of this. For tests that should allow a download, spin the runloop until
1996         -_downloadDidStart: is called. The test will now timeout on failure, but will no longer produce false failures.
1997
1998         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
1999         (downloadTest):
2000
2001 2015-09-22  Alexey Proskuryakov  <ap@apple.com>
2002
2003         Mavericks: Media tests start to time out after a few days of bot uptime
2004         https://bugs.webkit.org/show_bug.cgi?id=149468
2005
2006         Reviewed by Chris Dumez.
2007
2008         * Scripts/webkitpy/port/base.py:
2009         * Scripts/webkitpy/port/driver.py:
2010         * Scripts/webkitpy/port/mac.py:
2011
2012 2015-09-22  Nan Wang  <n_wang@apple.com>
2013
2014         Unreviewed, add myself to the committers list.
2015
2016         * Scripts/webkitpy/common/config/contributors.json:
2017
2018 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
2019
2020         Remove 'nullable' to fix older iOS builds.
2021
2022         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2023         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
2024
2025 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
2026
2027         [Win] Show tiled drawing debug overlay on Windows
2028         https://bugs.webkit.org/show_bug.cgi?id=149426
2029
2030         Reviewed by Dean Jackson.
2031
2032         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Add new menu option.
2033         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Ditto.
2034         * MiniBrowser/win/Common.cpp:
2035         (::ToggleMenuItem): Recognize new menu item and toggle the 'showTiledScrollingIndicator'
2036         flag if needed.
2037         * MiniBrowser/win/MiniBrowser.h: Update to use new IWebPreferencesPrivate3 class.
2038
2039 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
2040
2041         [Win] Use command-line argument to launch in regular or High DPI mode.
2042         https://bugs.webkit.org/show_bug.cgi?id=149417
2043
2044         Reviewed by Dean Jackson.
2045
2046         * MiniBrowser/win/Common.cpp:
2047         (parseCommandLine): Ignore the '--highDPI' argument. It's used at the
2048         very start of execution, before the MiniBrowser.dll is loaded.
2049         * win/DLLLauncher/DLLLauncherMain.cpp:
2050         (shouldUseHighDPI): Check for '--highDPI', and use this mode if
2051         present. On WinCairo, always use High DPI.
2052
2053 2015-09-21  Ryosuke Niwa  <rniwa@webkit.org>
2054
2055         32-bit Mac build fix attempt after r190065.
2056
2057         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2058
2059 2015-09-21  Alexey Proskuryakov  <ap@apple.com>
2060
2061         [OS X] Update for Xcode 7.0 on Yosemite
2062         https://bugs.webkit.org/show_bug.cgi?id=149389
2063
2064         Reviewed by Dan Bernstein.
2065
2066         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
2067         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
2068         Removed unneeded declarations - conforming to a protocol is sufficient.
2069
2070         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2071         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
2072         Changed the definitions to be compiled whenever the SDK requires it (so we will have
2073         dead code compiled in when building for 10.10 with 10.11 SDK, somewhat unfortunately).
2074
2075 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
2076
2077         Add the ability for tests to run script in the UI process in WebKitTestRunner
2078         https://bugs.webkit.org/show_bug.cgi?id=149356
2079
2080         Reviewed by Tim Horton.
2081
2082         This change adds testRunner.runUIScript(script, callback), which allows a test
2083         to execute script in a JSContext which runs in the UI process. That context
2084         has bindings exposed through the UIScriptController interface; currently one test
2085         function, and some iOS-specific functions are included. UIScriptController can be
2086         async with a callback, and runUIScript() itself is asynchronous. When the UI
2087         script is complete, it calls uiController.uiScriptComplete(result), where 'result'
2088         is a string passed back to the web process, and given to the runUIScript()
2089         callback function.
2090
2091         Thanks to Gyuyoung Kim for help with the Gtk/Efl build.
2092
2093         * WebKitTestRunner/DerivedSources.make: Build UIScriptController.idl.
2094         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Add runUIScript().
2095         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2096         (WTR::InjectedBundle::didReceiveMessageToPage): When the UI-side script is
2097         complete, call back into TestRunner.
2098         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2099         (WTR::nextUIScriptCallbackID):
2100         (WTR::TestRunner::runUIScript): Post a message to the injected bundle to run the UI script.
2101         (WTR::TestRunner::runUIScriptCallback): When the UI script is done, execute its callback function.
2102         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2103         * WebKitTestRunner/PlatformWebView.h:
2104         * WebKitTestRunner/TestController.cpp:
2105         (WTR::updateTestOptionsFromTestHeader):
2106         (WTR::TestController::testOptionsForTest): Support "useFlexibleViewport" as a test argument.
2107         (WTR::shouldUseFixedLayout): Deleted. Moved to a TestInvocation function.
2108         * WebKitTestRunner/TestInvocation.cpp:
2109         (WTR::TestInvocation::shouldUseFixedLayout):
2110         (WTR::TestInvocation::shouldUseThreadedScrolling):
2111         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2112         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2113         (WTR::TestInvocation::runUISideScript): Run the UI-side script!
2114         (WTR::TestInvocation::uiScriptDidComplete): Send a message back to the injected bundle.
2115         * WebKitTestRunner/TestInvocation.h:
2116         * WebKitTestRunner/TestOptions.h:
2117         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2118         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2119         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
2120         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Added.
2121         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
2122         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
2123         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
2124         (-[TestRunnerWKWebView onDidEndZooming:]): Allow a test to hook into the end of zooming.
2125         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2126         (WTR::PlatformWebView::PlatformWebView): Make a TestRunnerWKWebView on iOS.
2127         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Added.
2128         (WTR::UIScriptController::doAsyncTask):
2129         (WTR::UIScriptController::zoomToScale):
2130         (WTR::UIScriptController::zoomScale):
2131         (WTR::UIScriptController::minimumZoomScale):
2132         (WTR::UIScriptController::maximumZoomScale):
2133         (WTR::UIScriptController::contentVisibleRect):
2134         * WebKitTestRunner/mac/EventSenderProxy.mm:
2135         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2136         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Deleted.
2137         * WebKitTestRunner/mac/TestControllerMac.mm:
2138         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2139         (WTR::shouldUseThreadedScrolling): Deleted. Moved to TestInvocation.
2140         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
2141         * WebKitTestRunner/uiscriptcontext/UIScriptContext.cpp: Added. Owns the JS context in the UI process.
2142         (UIScriptContext::UIScriptContext):
2143         (UIScriptContext::~UIScriptContext):
2144         (UIScriptContext::runUIScript): Entrypoint to running the UI script. If the script didn't do anything
2145         asynchronous, call the callback.
2146         (UIScriptContext::nextTaskCallbackID):
2147         (UIScriptContext::prepareForAsyncTask): Do setup for one async task (i.e. a UIScriptController function
2148         that has a callback). Has to store the callbackID of the script, so code called from the completion
2149         callback knows which UI script invoked it.
2150         (UIScriptContext::asyncTaskComplete): Called when one task is finished.
2151         (UIScriptContext::uiScriptComplete):
2152         (UIScriptContext::objectFromRect): Make a JS object from a rect.
2153         * WebKitTestRunner/uiscriptcontext/UIScriptContext.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
2154         (WTR::UIScriptContext::hasOutstandingAsyncTasks):
2155         * WebKitTestRunner/uiscriptcontext/UIScriptController.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
2156         (WTR::UIScriptController::UIScriptController):
2157         (WTR::UIScriptController::makeWindowObject):
2158         (WTR::UIScriptController::wrapperClass):
2159         (WTR::UIScriptController::doAsyncTask):
2160         (WTR::UIScriptController::zoomToScale):
2161         (WTR::UIScriptController::zoomScale):
2162         (WTR::UIScriptController::minimumZoomScale):
2163         (WTR::UIScriptController::maximumZoomScale):
2164         (WTR::UIScriptController::contentVisibleRect):
2165         (WTR::UIScriptController::uiScriptComplete):
2166         * WebKitTestRunner/uiscriptcontext/UIScriptController.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
2167         (WTR::UIScriptController::create):
2168         * WebKitTestRunner/uiscriptcontext/bindings/UIScriptController.idl: Copied from Tools/WebKitTestRunner/TestOptions.h.
2169
2170 2015-09-21  Tim Horton  <timothy_horton@apple.com>
2171
2172         Turn on threaded scrolling by default in the tests
2173         https://bugs.webkit.org/show_bug.cgi?id=149377
2174
2175         Reviewed by Simon Fraser.
2176
2177         * WebKitTestRunner/mac/TestControllerMac.mm:
2178         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
2179         (WTR::shouldUseThreadedScrolling): Deleted.
2180         Turn on threaded scrolling by default.
2181
2182 2015-09-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2183
2184         [GTK] run-gtk-tests doesn't provide feedback about crashing google tests
2185         https://bugs.webkit.org/show_bug.cgi?id=149252
2186
2187         Reviewed by Darin Adler.
2188
2189         In case of glib tests the test runner notifies about tests
2190         crashing, but for google tests we don't get any feedback, which
2191         means that in case of a test crashing we get a list of **PASS**
2192         messages and at the summary we are notified that the test suite
2193         has failed, but it's impossible to know which test cases have failed.
2194
2195         * Scripts/run-gtk-tests:
2196         (TestRunner._run_google_test): Add a **CRASH** message if test
2197         case crashed.
2198
2199 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
2200
2201         WebKitTestRunner can leak user content script results between tests
2202         https://bugs.webkit.org/show_bug.cgi?id=149391
2203
2204         Reviewed by Sam Weinig.
2205
2206         Move WKBundlePageRemoveAllUserContent call so that it's executed before loading
2207         about:blank, and thus about:blank doesn't have unintended side effects.
2208
2209         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2210         (WTR::InjectedBundle::beginTesting):
2211         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2212         (WTR::InjectedBundlePage::resetAfterTest):
2213
2214 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
2215
2216         [Mac, iOS] AccessibilityController doesn't uninstall global notification handler
2217         https://bugs.webkit.org/show_bug.cgi?id=149384
2218
2219         Reviewed by Chris Fleizach.
2220
2221         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
2222         (AccessibilityController::addNotificationListener): Fixed a leak, and cleaned up the code.
2223         (AccessibilityController::platformResetToConsistentState): Actually remove the handler,
2224         regardless of whether someone else holds a reference (we also call -stopListening in
2225         -dealloc).
2226
2227         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2228         (AccessibilityController::platformResetToConsistentState):
2229         (AccessibilityController::addNotificationListener):
2230         Ditto.
2231
2232 2015-09-20  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2233
2234         Remove XHR_TIMEOUT compilation guard
2235         https://bugs.webkit.org/show_bug.cgi?id=149260
2236
2237         Reviewed by Benjamin Poulain.
2238
2239         * Scripts/webkitperl/FeatureList.pm:
2240
2241 2015-09-19  Dan Bernstein  <mitz@apple.com>
2242
2243         Attempted build fix.
2244
2245         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
2246
2247 2015-09-18  Commit Queue  <commit-queue@webkit.org>
2248
2249         Unreviewed, rolling out r189908.
2250         https://bugs.webkit.org/show_bug.cgi?id=149368
2251
2252         Broke run-webkit-tests --pixel (Requested by ap on #webkit).
2253
2254         Reverted changeset:
2255
2256         "printing does not use minimum page zoom factor"
2257         https://bugs.webkit.org/show_bug.cgi?id=108507
2258         http://trac.webkit.org/changeset/189908
2259
2260 2015-09-18  Andy Estes  <aestes@apple.com>
2261
2262         [iOS] did{Start,Finish}LoadForQuickLookDocumentInMainFrame is never called on WKNavigationDelegate
2263         https://bugs.webkit.org/show_bug.cgi?id=149360
2264
2265         Reviewed by Tim Horton.
2266
2267         Added an API test.
2268
2269         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2270         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Added.
2271         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2272         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2273         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]):
2274         (TEST):
2275         * TestWebKitAPI/ios/pages.pages: Added.
2276
2277 2015-09-18  Nan Wang  <n_wang@apple.com>
2278
2279         AX: Implement ARIA 1.1 @aria-current on iOS
2280         https://bugs.webkit.org/show_bug.cgi?id=149297
2281
2282         Reviewed by Chris Fleizach.
2283
2284         Added support to test aria-current on iOS.
2285
2286         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2287         (AccessibilityUIElement::stringAttributeValue):
2288         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2289         (WTR::AccessibilityUIElement::stringAttributeValue):
2290
2291 2015-09-18  Alexey Proskuryakov  <ap@apple.com>
2292
2293         iOS WebKitTestRunner frequently crashes in WKContextGetIconDatabase
2294         https://bugs.webkit.org/show_bug.cgi?id=149352
2295
2296         Reviewed by Simon Fraser.
2297
2298         * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
2299         m_context can be null. This may indicate a bug in webkitpy too, but
2300         WebKitTestRunner should handle this situation nicely, there is nothing intrinsically
2301         wrong with opening and immediately closing it.
2302
2303 2015-09-18  Daniel Bates  <dabates@apple.com>
2304
2305         isGitSVNDirectory() returns true when Git is not installed
2306         https://bugs.webkit.org/show_bug.cgi?id=149351
2307
2308         Reviewed by Alexey Proskuryakov.
2309
2310         Fixes an issue where VCSUtils::isGitSVNDirectory() returns true for any arbitrary directory if
2311         Git is not installed on the machine.
2312
2313         * Scripts/VCSUtils.pm:
2314         (isGitSVNDirectory): Ensure that `git config --get svn-remote.svn.fetch 2>& 1` exits with
2315         status code 0 (success).
2316
2317 2015-09-18  Alex Christensen  <achristensen@webkit.org>
2318
2319         Prevent build-webkit from building four times on Windows
2320         https://bugs.webkit.org/show_bug.cgi?id=149336
2321
2322         Reviewed by Brent Fulgham.
2323
2324         * Scripts/build-webkit:
2325         Move the Windows code out of the for loop iterating over each subdirectory to be build.
2326         They're built all at once.
2327         * Scripts/webkitdirs.pm:
2328         (buildVisualStudioProject):
2329         (cmakeGeneratedBuildfile):
2330         Don't generate the Visual Studio solution if it already exists.
2331         It will run CMake again if necessary.
2332
2333 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
2334
2335         [iOS WK2] WTR fails to set the key window in the UIKit sense
2336         https://bugs.webkit.org/show_bug.cgi?id=149325
2337
2338         Reviewed by Tim Horton.
2339
2340         -[WebKitTestRunnerWindow isKeyWindow] just returned _platformWebView->windowIsKey().
2341         This causes UIKit to bypass code that actually sets the key window, resulting in
2342         [UIAppliation sharedApplication].keyWindow always being nil.
2343
2344         Fix by PlatformWebView::setWindowIsKey() actually call -makeKeyWindow, and having
2345         -[WebKitTestRunnerWindow isKeyWindow] call super.
2346
2347         * WebKitTestRunner/PlatformWebView.h:
2348         (WTR::PlatformWebView::setWindowIsKey): Deleted.
2349         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2350         (WTR::PlatformWebView::setWindowIsKey):
2351         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2352         (WTR::PlatformWebView::setWindowIsKey):
2353         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2354         (-[WebKitTestRunnerWindow isKeyWindow]):
2355         (WTR::PlatformWebView::PlatformWebView):
2356         (WTR::PlatformWebView::~PlatformWebView):
2357         (WTR::PlatformWebView::setWindowIsKey):
2358         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2359         (WTR::PlatformWebView::setWindowIsKey):
2360
2361 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
2362
2363         [iOS WK2] When loading viewport tests, use the normal web page viewport configuration
2364         https://bugs.webkit.org/show_bug.cgi?id=149321
2365
2366         Reviewed by Tim Horton.
2367
2368         InjectedBundlePage::platformDidStartProvisionalLoadForFrame() unconditionally
2369         enabled the "testing" viewport configuration, which disables page scaling.
2370
2371         If we're running viewport tests, we want the normal web page configuration.
2372         Do that by passing a flag in the dictionary sent to InjectedBundle::beginTesting(),
2373         based on whether the test is in a "viewport" directory.
2374
2375         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2376         (WTR::InjectedBundle::beginTesting):
2377         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2378         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Deleted.
2379         * WebKitTestRunner/TestInvocation.cpp:
2380         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
2381         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
2382         (WTR::TestInvocation::shouldMakeViewportFlexible):
2383         (WTR::TestInvocation::invoke):
2384         * WebKitTestRunner/TestInvocation.h:
2385         * WebKitTestRunner/ios/TestControllerIOS.mm:
2386         (WTR::TestController::platformConfigureViewForTest):
2387         (WTR::shouldMakeViewportFlexible): Deleted.
2388
2389 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
2390
2391         Give iOS WebKitTestRunner a launch storyboard
2392         https://bugs.webkit.org/show_bug.cgi?id=149314
2393
2394         Reviewed by Dan Bates.
2395
2396         Add a launch storyboard to iOS WebKitTestRunner so that Springboard recognizes
2397         that it's been built for specific device configurations, and puts the window
2398         at the top of the screen. This simplifies coordinate conversions in a future patch.
2399
2400         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2401         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
2402         * WebKitTestRunner/ios/Launch.storyboard: Added.
2403
2404 2015-09-17  Myles C. Maxfield  <mmaxfield@apple.com>
2405
2406         Update licence in r189890
2407         https://bugs.webkit.org/show_bug.cgi?id=149306
2408
2409         Reviewed by Dean Jackson.
2410
2411         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
2412         * FontWithFeatures/FontWithFeatures/FontCreator.h:
2413         * FontWithFeatures/FontWithFeatures/main.cpp:
2414
2415 2015-09-17  Mark Lam  <mark.lam@apple.com>
2416
2417         Add the ability to skip JIT stress tests in run-javascriptcore-tests.
2418         https://bugs.webkit.org/show_bug.cgi?id=149285
2419
2420         Reviewed by Saam Barati.
2421
2422         Just need to add an option to pass --no-jit to run-jsc-stress-test.
2423
2424         * Scripts/run-javascriptcore-tests:
2425         (runJSCStressTests):
2426
2427 2015-09-17  Alex Christensen  <achristensen@webkit.org>
2428
2429         Switch AppleWin build to use CMake
2430         https://bugs.webkit.org/show_bug.cgi?id=149163
2431
2432         Reviewed by Brent Fulgham.
2433
2434         * Scripts/build-webkit:
2435         * Scripts/run-api-tests:
2436         (runTest):
2437         (listAllTests):
2438         (prepareEnvironmentForRunningTestTool):
2439         (testToolPaths):
2440         (testToolPath): Deleted.
2441         Run the API tests as separate executables on Windows.
2442         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
2443         * Scripts/webkitdirs.pm:
2444         (checkRequiredSystemConfig):
2445         (jhbuildWrapperPrefixIfNeeded):
2446         (generateBuildSystemFromCMakeProject):
2447         Fix configuration quirks.
2448
2449 2015-09-17  Dean Johnson  <dean_johnson@apple.com>
2450
2451         Added toggle options for hiding and showing certain platform families on the dashboard.
2452         https://bugs.webkit.org/show_bug.cgi?id=148403
2453
2454         Reviewed by David Kilzer.
2455
2456         This patch removes "hiddenPlatforms" from use in the code and local storage. We also removed
2457         individual hide/show buttons for platforms because we've added toggle options to hide/show entire
2458         families. Examples of these are "mac", "ios", and "linux". "Show All Platforms" was also removed
2459         in lieu of an "all" button in the toggle menu.
2460
2461         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2462         (parsePlatformFamily): Helper function to parse out a platform family.
2463         (initPlatformsByFamily): Initializes platformsByFamily, which organizes platforms on the
2464         page by platformsByFamily[<family>] = <list of platforms belonging to that family>.
2465         (updateToggleButtons): Updates the status of the toggle buttons.
2466         (updateHiddenPlatforms): Changed to work with the new implementation of hiding/showing platforms.
2467         (documentReady): Added creation of toggle buttons.
2468         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
2469         (unhiddenQueues): Updated to search by platform family instead of the individual platform name.
2470         (documentReady): Changed hiddenPlatforms => hiddenPlatformFamilies.
2471         (updateHiddenPlatforms): Deleted. After removing the individual hide button code,
2472         this did the exact same thing as the updateHiddenPlatforms in Scripts/Main.js so it was removed.
2473         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
2474         (QueueView): Updated to use hiddenPlatformFamilies.
2475         (QueueView.prototype._updateHiddenState): Updated to use hiddenPlatformFamilies.
2476         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
2477         (Settings.prototype.toggleHiddenPlatformFamily): Renamed function and some variables.
2478         (Settings.prototype.clearHiddenPlatformFamilies): Now uses hiddenPlatformFamilies for events.
2479         (Settings.prototype.toggleHiddenPlatform): Deleted.
2480         (Settings.prototype.clearHiddenPlatforms): Deleted.
2481         (Settings.prototype.toggleShowPlatformFamily): Deleted.
2482         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2483         (div.cellButton, div.accessibilityButton, div.platformFamilyToggleButton):
2484         (div.cellButton.unhide, div.accessibilityButton.unhide, div.platformFamilyToggleButton.unhide):
2485         (.settings-visible div.settingsWrapper.hide, .settings-visible div.settingsWrapper):
2486         (table.queue-grid tr.headers th):
2487         (div.settingsWrapper.hide):
2488         (div.settingsWrapper):
2489         (div.familyToggleWrapper):
2490         (div.platformFamilyToggleButton):
2491         (div.platformFamilyShowToggleButton:not(:last-child)):
2492         (div.familyShown):
2493         (div.accessibilityButton):
2494         (div.cellButton, div.accessibilityButton): Added platformFamilyToggleButton class.
2495         (div.cellButton.unhide, div.accessibilityButton.unhide): Added platformFamilyToggleButton class.
2496         (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide): Added
2497         platformFamilyToggleButton and settingsWrapper class.
2498         (.accessibilityButton): Deleted.
2499
2500 2015-09-17  Tim Horton  <timothy_horton@apple.com>
2501
2502         Add a test ensuring that scrolling in the middle of a page can't start a swipe gesture
2503         https://bugs.webkit.org/show_bug.cgi?id=148904
2504
2505         Reviewed by Myles Maxfield.
2506
2507         * WebKitTestRunner/TestController.cpp:
2508         (WTR::parseBooleanTestHeaderValue):
2509         (WTR::updateViewOptionsFromTestHeader):
2510         Check for the key "useThreadedScrolling".
2511         Add some code to check for "true" and "false" for boolean options.
2512
2513         (WTR::TestController::viewOptionsForTest):
2514         Apply the test's overrides last, even after the platform's.
2515
2516 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2517
2518         printing does not use minimum page zoom factor
2519         https://bugs.webkit.org/show_bug.cgi?id=108507
2520
2521         Reviewed by Darin Adler.
2522
2523         WebKitTestRunner always takes the snapshots from the UI process
2524         (expect for IOS), so in the case of printing, the layout in the
2525         web view is not the expected one. When printing, we need to take
2526         the snapshot in the web process and ensure it's rendered with a
2527         PrintContext.
2528
2529         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2530         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
2531         kWKSnapshotOptionsPrinting option to
2532         WKBundlePageCreateSnapshotWithOptions() when printing. When not
2533         printing, don't even create the snapshot, since it will be ignored
2534         by the UI process that always creates its own from the WebView (expect for IOS platform)
2535         * WebKitTestRunner/TestInvocation.cpp:
2536         (WTR::TestInvocation::dumpResults): Use always the snapshot image
2537         received from the web process if any when comparing pixel
2538         results. Now we only receive a snapshot from the web process in
2539         case of printing, or when platform is IOS. Otherwhise, generate
2540         the snapshot from the WebView as usual.
2541         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
2542         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
2543         is created by the caller now, but the CG implementation needs to
2544         know if it's a Web or UI process snapshot.
2545         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2546         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
2547         cairo surface for the given image.
2548         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2549         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
2550         CGContext for the given image.
2551
2552 2015-09-16  Myles C. Maxfield  <mmaxfield@apple.com>
2553
2554         Create a font which can be used for testing font features
2555         https://bugs.webkit.org/show_bug.cgi?id=149237
2556
2557         Reviewed by Simon Fraser.
2558
2559         This patch adds a new project in the Tools/ directory which generates a font which can
2560         be used for testing font features. This is a standalone project consisting of two files:
2561         1. A file which actually generates the byte vector representing the font. This file has
2562         a single public function: std::vector<uint8_t> generateFont(). This file is not platform
2563         specific, and only relies on the C++ STL.
2564         2. A file with a main() which calls generateFont() and writes out the font, as well as
2565         uses the font to render some demonstration text into a .png file. This file is platform
2566         specific.
2567
2568         The font itself only supports the following characters:
2569         ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
2570         However, the shape of these letters are either an X or a check mark.
2571
2572         The letter "A" always is a check mark.
2573         The letter "B" always is an X.
2574         Without any font features turned on, the rest of the letters are shown as X.
2575
2576         Each font feature has an letter associated with it. When the font feature is enabled,
2577         that letter is shown as a check mark. For example, when "smcp" is enabled, "J" is shown
2578         as a check mark.
2579
2580         Here are the mappings of font features to letters:
2581         liga: C
2582         clig: D
2583         dlig: E
2584         hlig: F
2585         calt: G
2586         subs: H
2587         sups: I
2588         smcp: J
2589         c2sc: K
2590         pcap: L
2591         c2pc: M
2592         unic: N
2593         titl: O
2594         onum: P
2595         pnum: Q
2596         tnum: R
2597         frac: S
2598         afrc: T
2599         ordn: U
2600         zero: V
2601         hist: W
2602         jp78: X
2603         jp83: Y
2604         jp90: Z
2605         jp04: a
2606         smpl: b
2607         trad: c
2608         fwid: d
2609         pwid: e
2610         ruby: f
2611
2612         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj: Added.
2613         * FontWithFeatures/FontWithFeatures/FontCreator.cpp: Added.
2614         (integralLog2):
2615         (roundDownToPowerOfTwo):
2616         (isFourByteAligned):
2617         (clampTo):
2618         (append32):
2619         (writeCFFEncodedNumber):
2620         (CFFBuilder::CFFBuilder):
2621         (CFFBuilder::takeResult):
2622         (CFFBuilder::moveTo):
2623         (CFFBuilder::lineTo):
2624         (CFFBuilder::curveToCubic):
2625         (CFFBuilder::closePath):
2626         (CFFBuilder::writePoint):
2627         (generateBoxCharString):
2628         (generateCheckCharString):
2629         (generateXCharString):
2630         (charStringForGlyph):
2631         (Generator::generate):
2632         (Generator::Placeholder::Placeholder):
2633         (Generator::Placeholder::populate):
2634         (Generator::Placeholder::~Placeholder):
2635         (Generator::placeholder):
2636         (Generator::append16):
2637         (Generator::append32):
2638         (Generator::append32BitCode):
2639         (Generator::overwrite16):
2640         (Generator::overwrite32):
2641         (Generator::appendCFFTable):
2642         (Generator::appendSubstitutionSubtable):
2643         (Generator::appendScriptSubtable):
2644         (Generator::appendGSUBTable):
2645         (Generator::appendOS2Table):
2646         (Generator::appendFormat12CMAPTable):
2647         (Generator::appendFormat4CMAPTable):
2648         (Generator::appendCMAPTable):
2649         (Generator::appendHEADTable):
2650         (Generator::appendHHEATable):
2651         (Generator::appendHMTXTable):
2652         (Generator::appendMAXPTable):
2653         (Generator::appendNAMETable):
2654         (Generator::appendPOSTTable):
2655         (Generator::calculateChecksum):
2656         (Generator::appendTable):
2657         (generateFont):
2658         * FontWithFeatures/FontWithFeatures/FontCreator.h: Added.
2659         * FontWithFeatures/FontWithFeatures/main.cpp: Added.
2660         (drawTextWithFeature):
2661         (main):
2662
2663 2015-09-16  Commit Queue  <commit-queue@webkit.org>
2664
2665         Unreviewed, rolling out r189875 and r189878.
2666         https://bugs.webkit.org/show_bug.cgi?id=149235
2667
2668         cygwin cmake build not ready yet (Requested by alexchristensen
2669         on #webkit).
2670
2671         Reverted changesets:
2672
2673         "Switch AppleWin build to use CMake"
2674         https://bugs.webkit.org/show_bug.cgi?id=149163
2675         http://trac.webkit.org/changeset/189875
2676
2677         "Cygwin build fix after r189875"
2678         http://trac.webkit.org/changeset/189878
2679
2680 2015-09-16  Alex Christensen  <achristensen@webkit.org>
2681
2682         Cygwin build fix after r189875
2683
2684         * Scripts/build-webkit:
2685         * Scripts/webkitdirs.pm:
2686         (jhbuildWrapperPrefixIfNeeded):
2687         (generateBuildSystemFromCMakeProject):
2688         Make things work with cygwin and cmake.
2689
2690 2015-09-16  Alex Christensen  <achristensen@webkit.org>
2691
2692         Switch AppleWin build to use CMake
2693         https://bugs.webkit.org/show_bug.cgi?id=149163
2694
2695         Reviewed by Brent Fulgham.
2696
2697         * Scripts/build-webkit:
2698         Build with CMake.
2699         * Scripts/run-api-tests:
2700         (runTest):
2701         (listAllTests):
2702         (prepareEnvironmentForRunningTestTool):
2703         (testToolPaths):
2704         (testToolPath): Deleted.
2705         Run the API tests as separate executables on Windows.
2706         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
2707
2708 2015-09-16  Alexey Proskuryakov  <ap@apple.com>
2709
2710         Add newer build.webkit.org pages to robots.txt
2711         https://bugs.webkit.org/show_bug.cgi?id=149219
2712
2713         Reviewed by Darin Adler.
2714
2715         Indexing bot watcher's dashboard can't be good.
2716
2717         * BuildSlaveSupport/build.webkit.org-config/public_html/robots.txt:
2718
2719 2015-09-16  Alex Christensen  <achristensen@webkit.org>
2720
2721         Rollout r189851 and 189853 because they didn’t actually fix the permissions issue
2722
2723         * BuildSlaveSupport/built-product-archive:
2724         (unzipArchive):
2725
2726 2015-09-16  Csaba Osztrogonác  <ossy@webkit.org>
2727
2728         [EFL] Fix the help message of separated web process option of MiniBrowser
2729         https://bugs.webkit.org/show_bug.cgi?id=149212
2730
2731         Reviewed by Gyuyoung Kim.
2732
2733         * MiniBrowser/efl/main.c:
2734
2735 2015-09-16  Alex Christensen  <achristensen@webkit.org>
2736
2737         Fix python syntax after r189851.
2738
2739         * BuildSlaveSupport/built-product-archive:
2740         (unzipArchive):
2741         For loops need a colon.
2742
2743 2015-09-15  Alex Christensen  <achristensen@webkit.org>
2744
2745         Fix Windows test bots after changing to non-cygwin build
2746         https://bugs.webkit.org/show_bug.cgi?id=149196
2747
2748         Reviewed by Daniel Bates.
2749
2750         * BuildSlaveSupport/built-product-archive:
2751         (unzipArchive):
2752         Using different versions of python makes what I think is https://bugs.python.org/issue15795
2753         prevent us from executing files from the archive on the test bots.
2754
2755 2015-09-15  Ryosuke Niwa  <rniwa@webkit.org>
2756
2757         Add ShadowRoot interface and Element.prototype.attachShadow
2758         https://bugs.webkit.org/show_bug.cgi?id=149187
2759
2760         Reviewed by Antti Koivisto.
2761
2762         * Scripts/webkitperl/FeatureList.pm:
2763
2764 2015-09-15  Aakash Jain  <aakash_jain@apple.com>
2765
2766         Appscale queue status json output lacks bots
2767         https://bugs.webkit.org/show_bug.cgi?id=149194
2768         <rdar://problem/22171089>
2769
2770         Reviewed by Alexey Proskuryakov.
2771
2772         * QueueStatusServer/handlers/queuestatusjson.py:
2773         (QueueStatusJSON._bots): Order the results by date so as to get latest events, this was default in AppEngine.
2774         * QueueStatusServer/index.yaml: Index according to appscale requirements.
2775
2776 2015-09-15  Brent Fulgham  <bfulgham@apple.com>
2777
2778         [Win] Provide a means for viewing the layer tree
2779         https://bugs.webkit.org/show_bug.cgi?id=149165
2780
2781         Reviewed by Simon Fraser.
2782
2783         Update MiniBrowser with a new Debug menu option that will
2784         dump the current layer tree to the debug console.
2785
2786         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc:
2787         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h:
2788         * MiniBrowser/win/Common.cpp:
2789         (WndProc): Add handler for 'Print Layer Tree' menu option.
2790         * MiniBrowser/win/MiniBrowser.cpp:
2791         (MiniBrowser::printLayerTree): Added Handler.
2792         * MiniBrowser/win/MiniBrowser.h:
2793
2794 2015-09-14  Myles C. Maxfield  <mmaxfield@apple.com>
2795
2796         WebKitTestRunner declarative language setting is broken for iOS
2797         https://bugs.webkit.org/show_bug.cgi?id=149119
2798
2799         Unreviewed.
2800
2801         In all of the patches on webkit.org/b/189669, my patch to get this working on iOS was
2802         lost in the final version which got committed. This simply implements the existing
2803         OS X behavior on iOS.
2804
2805         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
2806         (WTR::InjectedBundle::platformInitialize):
2807
2808 2015-09-14  Dewei Zhu  <dewei_zhu@apple.com>
2809
2810         Unreviewed, add myself to committers list.
2811
2812         * Scripts/webkitpy/common/config/contributors.json:
2813
2814 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
2815
2816         [Cocoa] Allow testing with the system language
2817         https://bugs.webkit.org/show_bug.cgi?id=148671
2818
2819         Reviewed by Anders Carlsson and Alexey Proskuryakov.
2820
2821         React to tests marked with language=lang1,lang2,etc in their header.
2822         Once this information is parsed, pass it to
2823         WKContextConfigurationSetOverrideLanguages().
2824
2825         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2826         (WTR::InjectedBundle::platformInitialize): Don't clobber the language
2827         list.
2828         * WebKitTestRunner/TestController.cpp:
2829         (WTR::TestController::createWebViewWithOptions): Call
2830         WKContextConfigurationSetOverrideLanguages().
2831         (WTR::updateTestOptionsFromTestHeader): Inspect the language option.
2832         * WebKitTestRunner/TestOptions.h:
2833         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2834         (WTR::PlatformWebView::viewSupportsOptions): Cause a differing language
2835         option to restart the web process.
2836         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2837         (WTR::PlatformWebView::viewSupportsOptions): Ditto.
2838
2839 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
2840
2841         [WKTR] Allow changing the WKContextConfiguration between successive tests
2842         https://bugs.webkit.org/show_bug.cgi?id=148833
2843
2844         Reviewed by Tim Horton.
2845
2846         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
2847         However, there are certain tests which require specifying options in this object. This patch makes
2848         our existing code for recreating the test runner web view also recreate the WKContext.
2849
2850         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
2851         class.
2852
2853         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
2854         * WebKitTestRunner/PlatformWebView.h:
2855         (WTR::PlatformWebView::options):
2856         * WebKitTestRunner/TestController.cpp:
2857         (WTR::TestController::initialize):
2858         (WTR::TestController::generateContextConfiguration):
2859         (WTR::TestController::generatePageConfiguration):
2860         (WTR::TestController::createWebViewWithOptions):
2861         (WTR::TestController::ensureViewSupportsOptionsForTest):
2862         (WTR::updateContextConfigurationOptionsFromTestHeader):
2863         (WTR::TestController::contextConfigurationOptionsForTest):
2864         (WTR::TestController::platformCreateWebView):
2865         (WTR::TestController::platformCreateOtherPage):
2866         (WTR::updateViewOptionsFromTestHeader): Deleted.
2867         (WTR::TestController::viewOptionsForTest): Deleted.
2868         * WebKitTestRunner/TestController.h:
2869         (WTR::TestController::injectedBundlePath):
2870         (WTR::TestController::testPluginDirectory):
2871         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2872         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2873         (WTR::TestController::platformCreateWebView):
2874         (WTR::TestController::platformCreateOtherPage):
2875         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2876         (WTR::PlatformWebView::PlatformWebView):
2877         (WTR::PlatformWebView::viewSupportsOptions):
2878         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2879         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2880         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2881         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2882         (WTR::PlatformWebView::PlatformWebView):
2883         (WTR::PlatformWebView::viewSupportsOptions):
2884         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2885         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2886         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2887         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2888         (WTR::PlatformWebView::PlatformWebView):
2889         (WTR::PlatformWebView::viewSupportsOptions):
2890         * WebKitTestRunner/ios/TestControllerIOS.mm:
2891         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2892         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2893         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2894         (WTR::PlatformWebView::PlatformWebView):
2895         (WTR::PlatformWebView::viewSupportsOptions):
2896         * WebKitTestRunner/mac/TestControllerMac.mm:
2897         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2898         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2899
2900 2015-09-11  Michael Saboff  <msaboff@apple.com>
2901
2902         LayoutTestHelper crashes if a color profile isn't set for a 3rd party monitor
2903         https://bugs.webkit.org/show_bug.cgi?id=149083
2904
2905         Reviewed by Alexey Proskuryakov.
2906
2907         Check to make sure that we have a valid factoryProfile CFDictionaryRef before using it.
2908
2909         * DumpRenderTree/mac/LayoutTestHelper.m:
2910         (colorProfileURLForDisplay):
2911
2912 2015-09-11  Saam barati  <sbarati@apple.com>
2913
2914         There should be a defaultSpotCheck-like mode that doesn't run the MaximalFlushInsertionPhase in run-jsc-stress-tests
2915         https://bugs.webkit.org/show_bug.cgi?id=149058
2916
2917         Reviewed by Geoffrey Garen.
2918
2919         * Scripts/run-jsc-stress-tests:
2920
2921 2015-09-10  Commit Queue  <commit-queue@webkit.org>
2922
2923         Unreviewed, rolling out r189595.
2924         https://bugs.webkit.org/show_bug.cgi?id=149052
2925
2926         The tests still fail (Requested by ap on #webkit).
2927
2928         Reverted changeset:
2929
2930         "Spurious output on Windows tests: AQMEIOManager::FindIOUnit:
2931         error -1"
2932         https://bugs.webkit.org/show_bug.cgi?id=142929
2933         http://trac.webkit.org/changeset/189595
2934
2935 2015-09-10  Alexey Proskuryakov  <ap@apple.com>
2936
2937         Spurious output on Windows tests: AQMEIOManager::FindIOUnit: error -1
2938         https://bugs.webkit.org/show_bug.cgi?id=142929
2939
2940         Reviewed by Brent Fulgham.
2941
2942         Silence the logging. We'll track fixing the root cause in Radar.
2943
2944         * Scripts/webkitpy/port/mac.py:
2945         (MacPort.stderr_patterns_to_strip): Added a FIXME.
2946
2947         * Scripts/webkitpy/port/win.py:
2948         (WinPort.logging_patterns_to_strip): Added.
2949
2950 2015-09-09  Andy Estes  <aestes@apple.com>
2951
2952         [iOS] Teach run-webkit-tests how to parse simulator runtimes when version numbers contain a revision
2953         https://bugs.webkit.org/show_bug.cgi?id=149022
2954
2955         Reviewed by Daniel Bates.
2956
2957         Simulator runtime versions can contain a revision number (e.g. 8.4.1), but the regex for matching runtimes
2958         did not account for this.
2959
2960         * Scripts/webkitpy/xcode/simulator.py:
2961         (Simulator): Optionally matched a revision at the end of a runtime version number.
2962         * Scripts/webkitpy/xcode/simulator_unittest.py: Added a test.
2963
2964 2015-09-09  Andy Estes  <aestes@apple.com>
2965
2966         [iOS] Teach run-webkit-tests how to parse `simctl list` when a tvOS SDK is installed
2967         https://bugs.webkit.org/show_bug.cgi?id=149029
2968         <rdar://problem/22432624>
2969
2970         Reviewed by Daniel Bates.
2971
2972         * Scripts/webkitpy/xcode/simulator.py:
2973         (Simulator): Taught to parse tvOS runtimes.
2974         * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
2975
2976 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
2977
2978         Fix bit rot on bot watcher's dashboard page
2979         https://bugs.webkit.org/show_bug.cgi?id=149012
2980
2981         Reviewed by Tim Horton.
2982
2983         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2984         The code path used by the metrics page was trying to add properties to an undefined.
2985
2986         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2987         Silence an expection that would occur when the step has no logs. This should never
2988         happen, but it did (perhaps buildbot was misconfigured for a while).
2989
2990 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
2991
2992         Update LayoutTestRelay xcconfig file.
2993
2994         Rubber-stamped by Dan Bernstein.
2995
2996         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
2997
2998 2015-09-09  Saam barati  <sbarati@apple.com>
2999
3000         DFG should have a debugging option that runs a phase that flushes all locals
3001         https://bugs.webkit.org/show_bug.cgi?id=148916
3002
3003         Reviewed by Filip Pizlo.
3004
3005         * Scripts/run-jsc-stress-tests:
3006
3007 2015-09-09  Commit Queue  <commit-queue@webkit.org>
3008
3009         Unreviewed, rolling out r189530 and r189534.
3010         https://bugs.webkit.org/show_bug.cgi?id=148996
3011
3012         Caused assertion failures on Yosemite (Requested by litherum
3013         on #webkit).
3014
3015         Reverted changesets:
3016
3017         "[WKTR] Allow changing the WKContextConfiguration between
3018         successive tests"
3019         https://bugs.webkit.org/show_bug.cgi?id=148833
3020         http://trac.webkit.org/changeset/189530
3021
3022         "[Cocoa] Fix the tests after r189530"
3023         http://trac.webkit.org/changeset/189534
3024
3025 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
3026
3027         [Cocoa] Fix the tests after r189530
3028
3029         Unreviewed.
3030
3031         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3032         (WTR::initializeWebViewConfiguration):
3033
3034 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
3035
3036         [WKTR] Allow changing the WKContextConfiguration between successive tests
3037         https://bugs.webkit.org/show_bug.cgi?id=148833
3038
3039         Reviewed by Tim Horton.
3040
3041         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
3042         However, there are certain tests which require specifying options in this object. This patch makes
3043         our existing code for recreating the test runner web view also recreate the WKContext.
3044
3045         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
3046         class.
3047
3048         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
3049         * WebKitTestRunner/PlatformWebView.h:
3050         (WTR::PlatformWebView::options):
3051         * WebKitTestRunner/TestController.cpp:
3052         (WTR::TestController::initialize):
3053         (WTR::TestController::generateContextConfiguration):
3054         (WTR::TestController::generatePageConfiguration):
3055         (WTR::TestController::createWebViewWithOptions):
3056         (WTR::TestController::ensureViewSupportsOptionsForTest):
3057         (WTR::updateContextConfigurationOptionsFromTestHeader):
3058         (WTR::TestController::contextConfigurationOptionsForTest):
3059         (WTR::TestController::platformCreateWebView):
3060         (WTR::TestController::platformCreateOtherPage):
3061         (WTR::updateViewOptionsFromTestHeader): Deleted.
3062         (WTR::TestController::viewOptionsForTest): Deleted.
3063         * WebKitTestRunner/TestController.h:
3064         (WTR::TestController::injectedBundlePath):
3065         (WTR::TestController::testPluginDirectory):
3066         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3067         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3068         (WTR::TestController::platformCreateWebView):
3069         (WTR::TestController::platformCreateOtherPage):
3070         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3071         (WTR::PlatformWebView::PlatformWebView):
3072         (WTR::PlatformWebView::viewSupportsOptions):
3073         * WebKitTestRunner/efl/TestControllerEfl.cpp:
3074         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
3075         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
3076         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3077         (WTR::PlatformWebView::PlatformWebView):
3078         (WTR::PlatformWebView::viewSupportsOptions):
3079         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3080         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
3081         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
3082         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3083         (WTR::PlatformWebView::PlatformWebView):
3084         (WTR::PlatformWebView::viewSupportsOptions):
3085         * WebKitTestRunner/ios/TestControllerIOS.mm:
3086         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
3087         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
3088         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3089         (WTR::PlatformWebView::PlatformWebView):
3090         (WTR::PlatformWebView::viewSupportsOptions):
3091         * WebKitTestRunner/mac/TestControllerMac.mm:
3092         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
3093         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
3094
3095 2015-09-08  Daniel Bates  <dabates@apple.com>
3096
3097         [Mac] Expose Enable/Disable Accelerated Drawing in MiniBrowser
3098         https://bugs.webkit.org/show_bug.cgi?id=148980
3099
3100         Reviewed by Alexey Proskuryakov.
3101
3102         Add setting to enable/disable accelerated drawing so as to support testing
3103         this feature in MiniBrowser on Mac.
3104
3105         * MiniBrowser/mac/SettingsController.h:
3106         * MiniBrowser/mac/SettingsController.m:
3107         (-[SettingsController _populateMenu]): Add menu item.
3108         (-[SettingsController validateMenuItem:]): Update setting when menu item is toggled.
3109         (-[SettingsController toggleAcceleratedDrawingEnabled:]): Added.
3110         (-[SettingsController acceleratedDrawingEnabled]): Added.
3111         * MiniBrowser/mac/WK1BrowserWindowController.m:
3112         (-[WK1BrowserWindowController didChangeSettings]): Apply setting in WebKit1.
3113         * MiniBrowser/mac/WK2BrowserWindowController.m:
3114         (-[WK2BrowserWindowController didChangeSettings]): Apply setting in WebKit2.
3115
3116 2015-09-08  Jason Marcell  <jmarcell@apple.com>
3117
3118         Unreviewed. Added myself as a commiter in contributors.json.
3119
3120         * Scripts/webkitpy/common/config/contributors.json:
3121
3122 2015-09-08  Keith Miller  <keith_miller@apple.com>
3123
3124         Unreviewed, added myself to the list of contributors.
3125
3126         * Scripts/webkitpy/common/config/contributors.json:
3127
3128 2015-09-08  Daniel Bates  <dabates@apple.com>
3129
3130         Dashboard: Remove use of z-index for ring overlay; use DOM ordering
3131         https://bugs.webkit.org/show_bug.cgi?id=148921
3132
3133         Reviewed by Alexey Proskuryakov.
3134
3135         The ring image is positioned above the platform icon in markup and we specify the CSS
3136         property z-index for the ring image so that it is painted on top of the platform icon
3137         instead of below it (by DOM ordering). Instead we can take advantage of the transparency
3138         of the ring image, switch the order of these DOM elements and remove the use of the CSS
3139         property z-index to achieve a similar effect.
3140
3141         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3142         (documentReady): Create the platform icon image element before the ring image such that
3143         the ring image is painted on top of the platform icon.
3144         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3145         (table.queue-grid td.logo img.ring): Removed property z-index.
3146
3147 2015-09-08  Daniel Bates  <dabates@apple.com>
3148
3149         Dashboard: Remove duplicate gear icon data URLs
3150         https://bugs.webkit.org/show_bug.cgi?id=148920
3151
3152         Reviewed by Alexey Proskuryakov.
3153
3154         Currently we duplicate the SVG data URL for the gear icon up to its fill color in the CSS property
3155         background-image associated with each of the three gear icon states: collapsed (.settings), hover
3156         (.settings:hover), and expanded (.settings-visible .settings). Instead we should use the gear icon
3157         as a mask and make use of the CSS background-color to define the fill color for each of these three
3158         states.
3159
3160         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3161         (.settings): Use gear icon as mask and define CSS background-color for collapsed state.
3162         (.settings:hover): Override CSS background-color for hover state.
3163         (.settings-visible .settings): Override CSS background-color for expanded state.
3164
3165 2015-09-07  Andy Estes  <aestes@apple.com>
3166
3167         [Mac] DebugRelease builds should link against libWebKitSystemInterfaceElCapitan.a on 10.11
3168         https://bugs.webkit.org/show_bug.cgi?id=148946
3169         <rdar://problem/22603981>
3170
3171         Reviewed by Dan Bernstein.
3172
3173         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3174         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3175
3176 2015-09-07  Hunseop Jeong  <hs85.jeong@samsung.com>
3177
3178         [EFL] Many of the css3/device-adapt/* tests failed after r188548.
3179         https://bugs.webkit.org/show_bug.cgi?id=148927
3180
3181         Reviewed by Csaba Osztrogonác.
3182
3183         device-adapt/* tests need the fixedLayout option but useFixedLayout option is
3184         overwritten by updatePlatformSpecificViewOptionsForTest after r188548.
3185
3186         * WebKitTestRunner/TestController.cpp:
3187         (WTR::shouldUseFixedLayout): Removed the unnecessary indentations.
3188         * WebKitTestRunner/efl/TestControllerEfl.cpp:
3189         (WTR::shouldUseFixedLayout): Return true if the test is related with 'device-adapt'.
3190
3191 2015-09-07  Andy Estes  <aestes@apple.com>
3192
3193         Fix the Production build after r189455.
3194
3195         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Somehow I added the All target using the
3196         In-App Purchase template instead of the Aggregate template. Whoops.
3197
3198 2015-09-06  Andy Estes  <aestes@apple.com>
3199
3200         WebKit.xcworkspace should be be able to build iOS platforms
3201         https://bugs.webkit.org/show_bug.cgi?id=148881
3202
3203         Reviewed by Daniel Bates.
3204
3205         Since we don't want to create platform-specific schemes, all projects in the workspace's schemes need to build
3206         for all supported platforms.
3207
3208         * MiniBrowser/Configurations/Base.xcconfig: Included iphoneos and iphonesimulator in SUPPORTED_PLATFORMS.
3209         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Excluded all source files on iOS, and linked Cocoa and WebKit on Mac.
3210         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Ditto.
3211         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Stopped linking frameworks in Link Binaries With Libraries.
3212
3213 2015-09-06  Andy Estes  <aestes@apple.com>
3214
3215         WebKitTestRunner should build for iOS using the default target
3216         https://bugs.webkit.org/show_bug.cgi?id=148918
3217
3218         Reviewed by Daniel Bates.
3219
3220         When WebKitTestRunner was ported to iOS, a separate target (WebKitTestRunnerApp) was created for building the
3221         iOS variant. This is annoying because (1) all tools that invoke xcodebuild need to be taught to build this
3222         non-default target, and (2) a single Xcode scheme cannot be used to build both Mac and iOS variants.
3223
3224         This change adds a new default target (All) and makes it work for both Mac and iOS. Files that were built for
3225         both WebKitTestRunner and WebKitTestRunnerApp are now built in a static library target (WebKitTestRunner (Library)),
3226         and both apps now link this library. Files that are specific to Mac or iOS are excluded on the other platform.
3227         WebKitTestRunnerApp.app (which should be renamed to WebKitTestRunner.app) is skipped when installing on Mac, and
3228         WebKitTestRunner is skipped when installing on iOS.
3229
3230         The target dependency graph now looks like this:
3231
3232             All
3233                 WebKitTestRunnerApp
3234                     WebKitTestRunner (Library)
3235                         WebKitTestRunnerInjectedBundle
3236                             Derived Sources
3237                 WebKitTestRunner
3238                     WebKitTestRunner (Library)
3239                         WebKitTestRunnerInjectedBundle
3240                             Derived Sources
3241
3242         * Scripts/build-webkit: Stopped building the WebKitTestRunnerApp target on iOS.
3243         * Scripts/build-webkittestrunner: Ditto.
3244         * WebKitTestRunner/Configurations/Base.xcconfig: Set SUPPORTED_PLATFORMS to macosx, iphoneos, and iphonesimulator.
3245         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Set INSTALL_PATH here since it is the same for all targets.
3246         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Stopped setting INSTALL_PATH.
3247         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Moved frameworks from the build phase to here,
3248         excluded iOS-only files, and skipped installing on iOS.
3249         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Moved frameworks from the build phase to here,
3250         excluded Mac-only files, and skipped installing on Mac.
3251         * WebKitTestRunner/Configurations/WebKitTestRunnerLibrary.xcconfig: Skipped installing always.
3252         * WebKitTestRunner/Makefile: Stopped building the WebKitTestRunnerApp target on iOS.
3253         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added new targets, removed frameworks from
3254         Link Binary With Libraries builds phases, moved common files to the WebKitTestRunner (Library) target, and added
3255         new configuration files.
3256
3257 2015-09-05  Joseph Pecoraro  <pecoraro@apple.com>
3258
3259         Web Inspector: Improve prepare-ChangeLog for multiple cases
3260         https://bugs.webkit.org/show_bug.cgi?id=148875
3261
3262         Reviewed by Timothy Hatcher.
3263
3264         * Scripts/prepare-ChangeLog:
3265         (get_function_line_ranges_for_javascript):
3266         - We were ignoring everything inside of an anonymous function expression,
3267           such as (function(){ ... }), which made InjectedScriptSource produce nothing.
3268           Better handle this by inserting a few tweaks.
3269         - Allow method syntax outside of classes as long as they are at the global level.
3270         - Avoid treating "get" and "set" as getter/setter functions in bad contexts.
3271
3272         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
3273         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
3274         (Foo.prototype.method1):
3275         (Foo.prototype.method2):
3276         (Foo.prototype.method3.innerFunction):
3277         (Foo.prototype.method3):
3278         (insideGlobalAnonymousFunctionExpression):
3279         (foo.insideGlobalFunctionExpression):
3280         (IssueWithMapGetAndSet.prototype.method1.nestedFunctionInsideMethod1):
3281         (IssueWithMapGetAndSet.prototype.method1):
3282         (IssueWithMapGetAndSet.prototype.method2):
3283         (IssueWithMapGetAndSet.prototype.method3):
3284         (IssueWithMapGetAndSet):
3285
3286 2015-09-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3287
3288         [ES6] Enable ES6 Module in JSC shell by default
3289         https://bugs.webkit.org/show_bug.cgi?id=148689
3290
3291         Reviewed by Geoffrey Garen.
3292
3293         * Scripts/run-javascriptcore-tests:
3294         (runJSCStressTests):
3295         * Scripts/run-jsc-stress-tests:
3296
3297 2015-09-04  Basile Clement  <basile_clement@apple.com>
3298
3299         Unreviewed, change my email address.
3300
3301         * Scripts/webkitpy/common/config/contributors.json:
3302
3303 2015-09-04  Beth Dakin  <bdakin@apple.com>
3304
3305         Should have a test to make sure links don't navigate after a cancelled force
3306         click
3307         https://bugs.webkit.org/show_bug.cgi?id=148846
3308
3309         Reviewed by Tim Horton.
3310
3311         New EventSender function for a started then cancelled force click.
3312         * WebKitTestRunner/EventSenderProxy.h:
3313         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3314         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3315         (WTR::EventSendingController::mouseForceClick):
3316         (WTR::EventSendingController::startAndCancelMouseForceClick):
3317         (WTR::EventSendingController::mouseForceDown):
3318         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3319         * WebKitTestRunner/TestController.cpp:
3320         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3321         * WebKitTestRunner/mac/EventSenderProxy.mm:
3322         (WTR::EventSenderProxy::mouseForceClick):
3323         (WTR::EventSenderProxy::startAndCancelMouseForceClick):
3324         (WTR::EventSenderProxy::mouseForceDown):
3325         (WTR::EventSenderProxy::mouseMoveTo):
3326
3327 2015-09-04  Tim Horton  <timothy_horton@apple.com>
3328
3329         Add a test for r179736 (programmatic navigation during swipe causing a crash)
3330         https://bugs.webkit.org/show_bug.cgi?id=148830
3331
3332         Reviewed by Beth Dakin.
3333
3334         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3335         (WTR::InjectedBundle::beginTesting):
3336         Make sure that TestRunner callbacks don't leak between tests!
3337
3338 2015-09-04  Anders Carlsson  <andersca@apple.com>
3339
3340         It should be possible to pass relative HTTP test paths to DumpRenderTree
3341         https://bugs.webkit.org/show_bug.cgi?id=148825
3342         <rdar://problem/22583866>
3343
3344         Reviewed by Tim Horton.
3345
3346         Convert the path to an absolute path if needed.
3347
3348         * DumpRenderTree/mac/DumpRenderTree.mm:
3349         (computeTestURL):
3350
3351 2015-09-04  Jason Marcell  <jmarcell@apple.com>
3352
3353         Fix Swift unit tests for prepare-ChangeLog.
3354         https://bugs.webkit.org/show_bug.cgi?id=148817
3355
3356         Reviewed by Alexey Proskuryakov.
3357
3358         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Fixed
3359         Swift unit tests for prepare-ChangeLog.
3360
3361 2015-09-04  Lucas Forschler  <lforschler@apple.com>
3362
3363         Modifications to the webkit-nightly logic.
3364
3365         * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
3366         (updateAlertPanel):
3367         * WebKitLauncher/main.m:
3368         (displayErrorAndQuit):
3369
3370 2015-09-04  Beth Dakin  <bdakin@apple.com>
3371
3372         Speculative build fix.
3373
3374         * WebKitTestRunner/mac/EventSenderProxy.mm:
3375
3376 2015-09-04  Brian Burg  <bburg@apple.com>
3377
3378         Web Inspector: InspectorController should support multiple frontend channels
3379         https://bugs.webkit.org/show_bug.cgi?id=148538
3380
3381         Reviewed by Joseph Pecoraro.
3382
3383         InspectorClients must explicitly disconnect their frontend channel(s) from the
3384         inspected page's InspectorController.
3385
3386         To make this possible, DumpRenderTree should not destroy non-primary views until
3387         it has tried to close any abandoned Web Inspector instances. Performing teardown
3388         in the reverse order prevents disconnection of the frontend channel because that
3389         prematurely destroys the inspector frontend client.
3390
3391         * DumpRenderTree/mac/DumpRenderTree.mm:
3392         (runTest):
3393         * DumpRenderTree/win/DumpRenderTree.cpp:
3394         (runTest):
3395
3396 2015-09-04  Beth Dakin  <bdakin@apple.com>
3397
3398         Need to be able to test default behaviors on force click
3399         https://bugs.webkit.org/show_bug.cgi?id=148758
3400
3401         Reviewed by Tim Horton.
3402
3403         This patch adds a new eventSender method to do a full, completed force click,
3404         and it re-works all of the existing force methods to dispatch their events in
3405         such a way that they will trigger the NSImmediateAction gesture recognizer.
3406         To do this, first we need to send the events to the app rather than straight
3407         to the view, and also needed to tweak some state and send the events in a
3408         delayed fashion.
3409
3410         New public function mouseForceClick() and private helper functions to make
3411         NSEvents.
3412         * WebKitTestRunner/EventSenderProxy.h:
3413
3414         New public function mouseForceClick().
3415         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3416         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3417         (WTR::EventSendingController::mouseMoveTo):
3418         (WTR::EventSendingController::mouseForceClick):
3419         (WTR::EventSendingController::mouseForceDown):
3420         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3421         * WebKitTestRunner/TestController.cpp:
3422         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3423
3424         initPressureEventAtLocation needs to take a stageTransition and a window.
3425         * WebKitTestRunner/mac/EventSenderProxy.mm:
3426         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
3427         (-[EventSenderSyntheticEvent stageTransition]):
3428         (-[EventSenderSyntheticEvent timestamp]):
3429         (-[EventSenderSyntheticEvent _cgsEventRecord]):
3430         (-[EventSenderSyntheticEvent window]):
3431
3432         In order to enter the gesture recognizer, we need to start with a mouse down
3433         that has a NSEventMaskPressure modifier.
3434         (WTR::EventSenderProxy::sendMouseDownToStartPressureEvents):
3435
3436         This ensures that the events queue properly for the force monitor in AppKit.
3437         (WTR::spinRunLoopForForce):
3438
3439          We need to start the pressure change events with a began.
3440         (WTR::EventSenderProxy::beginPressureEvent):
3441
3442         These functions can be used to create the NSEvent for a pressure change every
3443         time we need one.
3444         (WTR::EventSenderProxy::pressureChangeEvent):
3445
3446         Send the right series of events to emulate a full, completed force click.
3447         (WTR::EventSenderProxy::mouseForceClick):
3448
3449         Use all of the new things for these existing functions.
3450         (WTR::EventSenderProxy::mouseForceDown):
3451         (WTR::EventSenderProxy::mouseForceUp):
3452         (WTR::EventSenderProxy::mouseForceChanged):
3453
3454         Set NSFakeForceTouchDevice to YES.
3455         * WebKitTestRunner/mac/main.mm:
3456         (setDefaultsToConsistentValuesForTesting):
3457
3458 2015-09-04  Jason Marcell  <jmarcell@apple.com>
3459
3460         prepare-ChangeLog needs to know how to parse Swift files.
3461         https://bugs.webkit.org/show_bug.cgi?id=148784
3462         <rdar://problem/22510062>
3463
3464         Reviewed by Darin Adler.
3465
3466         * Scripts/prepare-ChangeLog:
3467         (get_function_line_ranges): Added entry for get_function_line_ranges_for_swift.
3468         (get_function_line_ranges_for_swift): Added function that knows how to parse Swift code.
3469         (parseSwiftFunctionArgs): Added function that knows how to parse Swift function arguments.
3470         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl: Added.
3471         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Ditto.
3472         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests.swift: Ditto.
3473         (freeFunction): Ditto.
3474         (MyClass.function): Ditto.
3475         (MyClass.functionWithArgument(_:)): Ditto.
3476         (MyClass.functionWithMoreArguments(_:arg2:)): Ditto.
3477         (MyClass.functionWithNamedFirstArgument(argument:)): Ditto.
3478         (MyClass.functionWithNamedFirstAndSecondArgument(first:second:)): Ditto.
3479         (MyClass.classFunction): Ditto.
3480         (MyClass.readWriteComputedVariable): Ditto.
3481         (MyClass.readOnlyComputedVariable): Ditto.
3482
3483 2015-09-04  Ryosuke Niwa  <rniwa@webkit.org>
3484
3485         Import css/css-color-3
3486         https://bugs.webkit.org/show_bug.cgi?id=148803
3487
3488         Reviewed by Chris Dumez.
3489
3490         Fixed a bug that the imported reference files used the same extention as tests.
3491         This would result in parsing errors if the tests were XML and references were HTML and vice versa.
3492
3493         * Scripts/webkitpy/w3c/test_importer.py:
3494         (TestImporter.find_importable_tests):
3495
3496 2015-09-03  Commit Queue  <commit-queue@webkit.org>
3497
3498         Unreviewed, rolling out r189338.
3499         https://bugs.webkit.org/show_bug.cgi?id=148785
3500
3501         Caused tons of crashes (Requested by cdumez on #webkit).
3502
3503         Reverted changeset:
3504
3505         "Web Inspector: InspectorController should support multiple
3506         frontend channels"
3507         https://bugs.webkit.org/show_bug.cgi?id=148538
3508         http://trac.webkit.org/changeset/189338
3509
3510 2015-09-03  Brian Burg  <bburg@apple.com>
3511
3512         Web Inspector: InspectorController should support multiple frontend channels
3513         https://bugs.webkit.org/show_bug.cgi?id=148538
3514
3515         Reviewed by Joseph Pecoraro.
3516
3517         InspectorClients must explicitly disconnect their frontend channel(s) from the
3518         inspected page's InspectorController.
3519
3520         To make this possible, DumpRenderTree should not destroy non-primary views until
3521         it has tried to close any abandoned Web Inspector instances. Performing teardown
3522         in the reverse order prevents disconnection of the frontend channel because that
3523         prematurely destroys the inspector frontend client.
3524
3525         * DumpRenderTree/mac/DumpRenderTree.mm:
3526         (runTest):
3527         * DumpRenderTree/win/DumpRenderTree.cpp:
3528         (runTest):
3529
3530 2015-09-03  Timothy Hatcher  <timothy@apple.com>
3531
3532         Update WebKit nightly icon to be more like Safari
3533         https://bugs.webkit.org/show_bug.cgi?id=148768
3534
3535         Reviewed by Joseph Pecoraro.
3536
3537         * WebKitLauncher/webkit.icns:
3538
3539 2015-09-03  Geoffrey Garen  <ggaren@apple.com>
3540
3541         JavaScriptCore should have some ES6 conformance tests
3542         https://bugs.webkit.org/show_bug.cgi?id=148771
3543
3544         Reviewed by Chris Dumez.
3545
3546         * Scripts/run-javascriptcore-tests:
3547         (runJSCStressTests): Added es6 as a test suite.
3548
3549         * Scripts/run-jsc-stress-tests: Added es6 as a test suite.
3550
3551         Some of these tests currently fail, so I also added a way to expect
3552         failure for now. We'll migrate failing tests to expected passes as we
3553         fix them.
3554
3555 2015-09-03  Tim Horton  <timothy_horton@apple.com>
3556
3557         Add a test for swipe-start hysteresis
3558         https://bugs.webkit.org/show_bug.cgi?id=148756
3559
3560         Reviewed by Anders Carlsson.
3561
3562         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3563         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3564         (WTR::cacheTestRunnerCallback):
3565         (WTR::TestRunner::clearTestRunnerCallbacks):
3566         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3567         Make sure that we log if a client tries to install a callback twice
3568         (since we use .add, the second call would not work).
3569
3570         Also, add clearTestRunnerCallbacks so tests can swap out installed
3571         callbacks.
3572
3573 2015-09-03  Anders Carlsson  <andersca@apple.com>
3574
3575         DumpRenderTree should automatically compute HTTP URLs for HTTP tests
3576         https://bugs.webkit.org/show_bug.cgi?id=148746
3577         rdar://problem/22568073
3578
3579         Reviewed by Tim Horton.
3580
3581         * DumpRenderTree/mac/DumpRenderTree.mm:
3582         (computeTestURL):
3583         Compute the test URL from the passed in path or URL. Special-case paths that contain /LayoutTests/http/tests.
3584
3585         (runTest):
3586         Call computeTestURL.
3587
3588         (testPathFromURL):
3589         Get rid of this; computeTestURL does this for us now.
3590
3591         * Scripts/webkitpy/port/driver.py:
3592         (Driver._command_from_driver_input):
3593         Don't convert HTTP test paths to URLS before passing them to DumpRenderTree on Mac. That's handled by DRT itself now.
3594
3595 2015-09-03  Tim Horton  <timothy_horton@apple.com>
3596
3597         Swipe tests fail on Mavericks
3598         https://bugs.webkit.org/show_bug.cgi?id=148752
3599
3600         Reviewed by Beth Dakin.
3601
3602         * WebKitTestRunner/mac/EventSenderProxy.mm:
3603
3604 2015-09-03  Tim Horton  <timothy_horton@apple.com>
3605
3606         Fix the 32-bit build
3607
3608         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3609         (WTR::PlatformWebView::setNavigationGesturesEnabled):
3610
3611 2015-09-03  Tim Horton  <timothy_horton@apple.com>
3612
3613         Remove some logging that wasn't meant to be in the tree
3614
3615         * WebKitTestRunner/mac/EventSenderProxy.mm:
3616         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
3617
3618 2015-09-03  Tim Horton  <timothy_horton@apple.com>
3619
3620         [Mac] Add support for testing swipes
3621         https://bugs.webkit.org/show_bug.cgi?id=148700
3622
3623         Reviewed by Beth Dakin.
3624
3625         * WebKitTestRunner/EventSenderProxy.h:
3626         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3627         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3628         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3629         (WTR::cgEventPhaseFromString):
3630         (WTR::cgEventMomentumPhaseFromString):
3631         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
3632         (WTR::EventSendingController::swipeGestureWithWheelAndMomentumPhases):
3633         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3634         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3635         (WTR::InjectedBundle::didReceiveMessageToPage):
3636         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3637         (WTR::TestRunner::installDidBeginSwipeCallback):
3638         (WTR::TestRunner::installWillEndSwipeCallback):
3639         (WTR::TestRunner::installDidEndSwipeCallback):
3640         (WTR::TestRunner::installDidRemoveSwipeSnapshotCallback):
3641         (WTR::TestRunner::callDidBeginSwipeCallback):
3642         (WTR::TestRunner::callWillEndSwipeCallback):
3643         (WTR::TestRunner::callDidEndSwipeCallback):
3644         (WTR::TestRunner::callDidRemoveSwipeSnapshotCallback):
3645         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3646         * WebKitTestRunner/TestController.cpp:
3647         (WTR::TestController::createOtherPage):
3648         (WTR::TestController::createWebViewWithOptions):
3649         (WTR::TestController::didReceiveMessageFromInjectedBundle):
3650         (WTR::TestController::didBeginNavigationGesture):
3651         (WTR::TestController::willEndNavigationGesture):
3652         (WTR::TestController::didEndNavigationGesture):
3653         (WTR::TestController::didRemoveNavigationGestureSnapshot):
3654         * WebKitTestRunner/TestController.h:
3655         * WebKitTestRunner/TestInvocation.cpp:
3656         (WTR::TestInvocation::didBeginSwipe):
3657         (WTR::TestInvocation::willEndSwipe):
3658         (WTR::TestInvocation::didEndSwipe):
3659         (WTR::TestInvocation::didRemoveSwipeSnapshot):
3660         * WebKitTestRunner/TestInvocation.h:
3661         Add callbacks when navigation gestures didBegin/willEnd/didEnd, and
3662         when the snapshot is removed.
3663
3664         Add swipeGestureWithWheelAndMomentumPhases, just like the equivalent
3665         mouseScrollBy function.
3666
3667         * WebKitTestRunner/mac/EventSenderProxy.mm:
3668         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
3669         (-[EventSenderSyntheticEvent type]):
3670         (-[EventSenderSyntheticEvent subtype]):
3671         (-[EventSenderSyntheticEvent locationInWindow]):
3672         (-[EventSenderSyntheticEvent location]):
3673         (-[EventSenderSyntheticEvent momentumPhase]):
3674         (-[EventSenderSyntheticEvent _isTouchesEnded]):
3675         (-[EventSenderSyntheticEvent _cgsEventRecord]):
3676         Rename EventSenderPressureEvent to EventSenderSyntheticEvent and add some
3677         more adjustable values.
3678
3679         (WTR::EventSenderProxy::mouseForceDown):
3680         (WTR::EventSenderProxy::mouseForceUp):
3681         (WTR::EventSenderProxy::mouseForceChanged):
3682         Adopt EventSenderSyntheticEvent.
3683
3684         (WTR::nsEventPhaseFromCGEventPhase):
3685         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
3686         Make use of EventSenderSyntheticEvent to synthesize swipe gesture events.
3687
3688         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3689         (WTR::PlatformWebView::PlatformWebView):
3690         Enable swipe.
3691
3692 2015-09-03  Myles C. Maxfield  <mmaxfield@apple.com>
3693
3694         [WK2] Allow tagging tests with metadata which needs to be known at web process creation time
3695         https://bugs.webkit.org/show_bug.cgi?id=148723
3696
3697         Reviewed by Anders Carlsson.
3698
3699         * WebKitTestRunner/TestController.cpp:
3700         (WTR::testPath):
3701         (WTR::updateViewOptionsFromTestHeader):
3702         (WTR::TestController::viewOptionsForTest):
3703
3704 2015-09-03  Lucas Forschler  <lforschler@apple.com>
3705
3706         Test commit.
3707
3708 2015-09-02  Tim Horton  <timothy_horton@apple.com>
3709
3710         Add a modern API way to know that the navigation gesture snapshot was removed, for WebKitTestRunner
3711         https://bugs.webkit.org/show_bug.cgi?id=148693
3712
3713         Reviewed by Anders Carlsson.
3714
3715         * WebKitTestRunner/TestController.cpp:
3716         (WTR::TestController::createOtherPage):
3717         (WTR::TestController::createWebViewWithOptions):
3718
3719 2015-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3720
3721         REGRESSION(r188548): Some tests crash after r188548 because injected bundle messages are received after the test finishes
3722         https://bugs.webkit.org/show_bug.cgi?id=148529
3723
3724         Reviewed by Darin Adler.
3725
3726         When there are pending EventSender messages after a test finishes,
3727         they could be processed in the main loop started by the
3728         resetStateToConsistentValues(), but the old EventSender has been
3729         replaced by a new one at that point. The new Eventsender can crash
3730         when processing messages that were sent to the old one. To avoid
3731         this, we return early when receiving an EventSender message and
3732         the TestController state is not RunningTest.
3733
3734         * WebKitTestRunner/TestController.cpp:
3735         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
3736         (WTR::TestController::didReceiveMessageFromInjectedBundle):
3737
3738 2015-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3739
3740         REGRESSION(r188548): TestController state is Resseting while tests are running after r188548
3741         https://bugs.webkit.org/show_bug.cgi?id=148528
3742
3743         Reviewed by Darin Adler.
3744
3745         Before r188548 resetStateToConsistentValues() was called in
3746         TestController::run(), before tests are run, but now it's called
3747         for every test in TestInvocation::invoke(), after m_status has
3748         changed to RunningTest.
3749
3750         * WebKitTestRunner/TestController.cpp:
3751         (WTR::TestController::resetStateToConsistentValues): Use
3752         TemporaryChange to reset m_state ot its previous value after reset
3753         is done.
3754
3755 2015-08-31  Jason Marcell  <jmarcell@apple.com>
3756
3757         Modify prepare-Changelog to be aware of files that are marked as tests as well as files
3758         that are marked as requiring corresponding tests.
3759         https://bugs.webkit.org/show_bug.cgi?id=148498
3760         <rdar://problem/21555314>
3761
3762         Reviewed by Dan Bernstein and David Kilzer.
3763
3764         * Scripts/prepare-ChangeLog: Added "attributeCache" to cache Subversion properties in order to
3765         simulate Git's attribute behevaior.
3766         (main): Added "requiresTests" array to contain files that require tests.
3767         (generateNewChangeLogs): Checks "requiresTests" array to determine whether to inject "tests"
3768         section in ChangeLog.
3769         (attributeCommand): Queries a given file for a given Git attribute value. If using Subversion,
3770         however, we check if the file or any containing folder has the given property set to "1" and
3771         return 1 if so; return 0 otherwise.
3772         (generateFileList): Adds files to "requiresTests" array if Git attribute is set to "1". Also
3773         adds files to "addedRegressionTests" array if "test" attribute is set to "1".
3774
3775 2015-08-26  Andy Estes  <aestes@apple.com>
3776
3777         [Content Filtering] Determine navigation and content policy before continuing to filter a load
3778         https://bugs.webkit.org/show_bug.cgi?id=148506
3779
3780         Reviewed by Brady Eidson.
3781
3782         Added download API tests covering every decision and decision point.
3783         Removed _WKDownload.AsynchronousDownloadPolicy in favor of these new tests.
3784
3785         * TestWebKitAPI/Configurations/Base.xcconfig: Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to the header search path.
3786         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Removed it from here.
3787         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
3788         (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): Called -valueForKeyPath:, which
3789         returns an id, instead of -valueForKey:, which always returns an NSString even if the object is of another type.
3790         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added a class that can send a MockContentFilter
3791         decision and decision point as a bundle parameter.
3792         (+[MockContentFilterEnabler supportsSecureCoding]):
3793         (-[MockContentFilterEnabler copyWithZone:]):
3794         (-[MockContentFilterEnabler initWithCoder:]):
3795         (-[MockContentFilterEnabler initWithDecision:decisionPoint:]):
3796         (-[MockContentFilterEnabler encodeWithCoder:]):
3797         (configurationWithContentFilterSettings): Added a helper function to create a WKWebViewConfiguration with MockConentFilter settings.
3798         (TEST): Renamed ContentFiltering.ServerRedirect to ContentFiltering.URLAfterServerRedirect.
3799         (-[BecomeDownloadDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Decided _WKNavigationResponsePolicyBecomeDownload.
3800         (-[BecomeDownloadDelegate webView:didFailProvisionalNavigation:withError:]): Set isDone to true.
3801         (-[BecomeDownloadDelegate webView:didFinishNavigation:]): Ditto.
3802         (-[ContentFilteringDownloadDelegate _downloadDidStart:]): Set downloadDidStart to true.
3803         (downloadTest): Added a helper function to test downloads with a given decision and decision point.
3804         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added a corresponding bundle class that decodes
3805         the MockContentFilter decision and decision point, and sets these values in the MockContentFilterSettings
3806         singleton. This class is duplicated in the bundle to prevent TestWebKitAPI from having to link to WebCoreTestSupport.
3807         (+[MockContentFilterEnabler supportsSecureCoding]):
3808         (-[MockContentFilterEnabler copyWithZone:]):
3809         (-[MockContentFilterEnabler initWithCoder:]):
3810         (-[MockContentFilterEnabler dealloc]):
3811         (-[MockContentFilterEnabler encodeWithCoder:]):
3812         (-[ContentFilteringPlugIn webProcessPlugIn:initializeWithObject:]): Start observing changes to the MockContentFilterEnabler key path.
3813         (-[ContentFilteringPlugIn dealloc]): Stop observing.
3814         (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]): Store a MockContentFilterEnabler in _contentFilterEnabler.
3815         (+[ServerRedirectPlugIn initialize]): Deleted.
3816         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3817         (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
3818         (-[AsynchronousDownloadDelegate _downloadDidStart:]): Deleted.
3819         (TEST): Deleted.
3820
3821 2015-08-31  Filip Pizlo  <fpizlo@apple.com>
3822
3823         Skip slow lock tests on Windows/debug
3824         https://bugs.webkit.org/show_bug.cgi?id=148643
3825
3826         Reviewed by Alexey Proskuryakov.
3827
3828         The lock tests simulate a critical section by doing some floating point math, and then either
3829         make those critical sections very long or invoke them many times. This appears to be
3830         particularly slow on Windows in debug mode, maybe because Visual Studio's debug build makes
3831         that kind of computation slow.
3832
3833         These tests are almost as useful in release as they are in debug, so it's probably better to
3834         just skip the in debug on platforms where this causes timeouts.
3835
3836         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3837         (TestWebKitAPI::runLockTest):
3838         (TestWebKitAPI::skipSlow):
3839         (TestWebKitAPI::TEST):
3840
3841 2015-08-29  Chris Fleizach  <cfleizach@apple.com>
3842
3843         AX: When navigating the elements of a scrollable element with VoiceOver, the scrollTop() position of the element does not permanently change
3844         https://bugs.webkit.org/show_bug.cgi?id=125720
3845
3846         Reviewed by Daniel Bates.
3847
3848         Add support for scrollToMakeVisibleWithSubFocus and scrollToGlobalPoint.
3849
3850         * DumpRenderTree/AccessibilityUIElement.cpp:
3851         (pressCallback):
3852         (scrollToMakeVisibleWithSubFocusCallback):
3853         (scrollToGlobalPointCallback):
3854         (scrollToMakeVisibleCallback):
3855         (AccessibilityUIElement::getJSClass):
3856         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3857         (AccessibilityUIElement::scrollToMakeVisible):
3858         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3859         (AccessibilityUIElement::scrollToGlobalPoint):
3860         (AccessibilityUIElement::selectedTextRange):
3861         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3862         (AccessibilityUIElement::AccessibilityUIElement):
3863         (AccessibilityUIElement::mathPrescriptsDescription):
3864         (AccessibilityUIElement::scrollToMakeVisible):
3865         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3866         (AccessibilityUIElement::scrollToGlobalPoint):
3867         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3868         (WTR::AccessibilityUIElement::isTextMarkerValid):
3869         (WTR::AccessibilityUIElement::textMarkerForIndex):
3870         (WTR::AccessibilityUIElement::scrollToMakeVisible):
3871         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
3872         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3873         (WTR::AccessibilityUIElement::supportedActions):
3874         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
3875         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
3876         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3877         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3878         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3879         (WTR::AccessibilityUIElement::scrollToMakeVisible):
3880         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
3881         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3882         (WTR::AccessibilityUIElement::selectedTextRange):
3883         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3884         (WTR::AccessibilityUIElement::scrollToMakeVisible):
3885         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
3886         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3887         (WTR::AccessibilityUIElement::selectedTextRange):
3888
3889 2015-08-28  Timothy Horton  <timothy_horton@apple.com>
3890
3891         Add a mysteriously nonproblematic missing comma.
3892
3893         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3894         (TestExpectationParser._collect_matching_tests):
3895         (TestExpectationParser):
3896
3897 2015-08-28  Timothy Horton  <timothy_horton@apple.com>
3898
3899         Remove an old temporary script that has served its purpose
3900
3901         * Scripts/convert-test-expectations: Removed.
3902
3903 2015-08-28  Jer Noble  <jer.noble@apple.com>
3904
3905         [iOS] Add WebKit/WebKit2 settings to control automatic data loading
3906         https://bugs.webkit.org/show_bug.cgi?id=148579
3907
3908         Reviewed by Anders Carlsson.
3909
3910         In DumpRenderTree, set the new mediaDataLoadsAutomatically preference to YES.
3911
3912         In WebKitTestRunner, do the same for the new _mediaDataLoadsAutomatically configuration property,
3913         and also set the existing requiresUserActionForMediaPlayback configuration property to NO.
3914
3915         * DumpRenderTree/mac/DumpRenderTree.mm:
3916         (resetWebPreferencesToConsistentValues):
3917         (resetWebViewToConsistentStateBeforeTesting):
3918         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3919         (WTR::initializeWebViewConfiguration):
3920
3921 2015-08-28  Alexey Proskuryakov  <ap@apple.com>
3922
3923         Fix run-webkit-tests --additional-env-var="DYLD_INSERT_LIBRARIES=..."
3924         https://bugs.webkit.org/show_bug.cgi?id=148592
3925
3926         Reviewed by Tim Horton.
3927
3928         * Scripts/webkitpy/port/base.py:
3929         (Port.to.setup_environ_for_server):
3930         (Port.to):
3931         (Port.to._append_value_colon_separated):
3932         (Port.to.show_results_html_file):
3933         * Scripts/webkitpy/port/ios.py:
3934         (IOSSimulatorPort.setup_environ_for_server):
3935         * Scripts/webkitpy/port/mac.py:
3936         (MacPort.setup_environ_for_server):
3937
3938 2015-08-28  Filip Pizlo  <fpizlo@apple.com>
3939
3940         LICM should be sound even if the CFG has changed
3941         https://bugs.webkit.org/show_bug.cgi?id=148259
3942
3943         Reviewed by Benjamin Poulain.
3944
3945         Add a utility for creating tests that set some uncommon option.
3946
3947         * Scripts/run-jsc-stress-tests:
3948
3949 2015-08-28  Brent Fulgham  <bfulgham@apple.com>
3950
3951         [Win] Unreviewed EWS correction.
3952
3953         * EWSTools/start-queue-win.sh: Update settings to point to VS2015.
3954
3955 2015-08-28  Jer Noble  <jer.noble@apple.com>
3956
3957         [iOS] Make the AllowsInlineMediaPlayback preference work in WebKit / WebKit2.
3958         https://bugs.webkit.org/show_bug.cgi?id=147512
3959
3960         Reviewed by Anders Carlsson.
3961
3962         Set the value of WebKitAllowsInlineMediaPlayback / WKPreferencesSetMediaPlaybackAllowsInline()
3963         to a consistent (true) value.
3964
3965         * DumpRenderTree/mac/DumpRenderTree.mm:
3966         (setDefaultsToConsistentValuesForTesting):
3967         * WebKitTestRunner/TestController.cpp:
3968         (WTR::TestController::resetPreferencesToConsistentValues):
3969
3970 2015-08-28  Tim Horton  <timothy_horton@apple.com>
3971
3972         Add navigation gesture callbacks to WKPageNavigationClient
3973         https://bugs.webkit.org/show_bug.cgi?id=148568
3974         <rdar://problem/22371346>
3975
3976         Reviewed by Anders Carlsson.
3977
3978         * WebKitTestRunner/TestController.cpp:
3979         (WTR::TestController::createOtherPage):
3980         (WTR::TestController::createWebViewWithOptions):
3981         Add some zeroes.
3982
3983 2015-08-28  Alexey Proskuryakov  <ap@apple.com>
3984
3985         [Mac] kill-old-processes should kill more processes
3986         https://bugs.webkit.org/show_bug.cgi?id=148577
3987
3988         Reviewed by Tim Horton.
3989
3990         * BuildSlaveSupport/kill-old-processes:
3991
3992 2015-08-28  Jason Marcell  <jmarcell@apple.com>
3993
3994         The status message for combined builder queues should say "all builds succeeded" if everything
3995         built correctly.
3996         https://bugs.webkit.org/show_bug.cgi?id=148535
3997
3998         Reviewed by David Kilzer and Alexey Proskuryakov.
3999
4000         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
4001         (BuildbotCombinedQueueView.prototype.update): Make status message for combined builder queues
4002         say "all builds succeeded" if everything built correctly.
4003
4004 2015-08-28  Carlos Garcia Campos  <cgarcia@igalia.com>
4005
4006         [GTK] Simplify the internal API to create a WebView
4007         https://bugs.webkit.org/show_bug.cgi?id=148570
4008
4009         Reviewed by Žan Doberšek.
4010
4011         * TestWebKitAPI/PlatformWebView.h: Add initialize method for GTK+ too.
4012         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
4013         (TestWebKitAPI::PlatformWebView::PlatformWebView): Implement all
4014         PlatformWebView constructors that end up calling initialize with a PageConfiguration.
4015         (TestWebKitAPI::PlatformWebView::initialize): Create the WebView
4016         passing the received PageConfiguration.
4017         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
4018         (WTR::PlatformWebView::PlatformWebView): Create the WebView
4019         passing the received PageConfiguration.
4020
4021 2015-08-27  Aakash Jain  <aakash_jain@apple.com>
4022
4023         iOS Simulator API tests fails as Simulator is not running
4024         https://bugs.webkit.org/show_bug.cgi?id=148501
4025         rdar://problem/22447525
4026
4027         Reviewed by Daniel Bates.
4028
4029         This change is a workaround for <rdar://problem/22388812>.
4030
4031          * Scripts/run-api-tests: Launch the iOS Simulator before starting the API Tests
4032          and quit it on program termination when running tests on the iOS port.
4033          * Scripts/webkitdirs.pm: Store string "For WebKit Development" in constant
4034          SIMULATOR_DEVICE_SUFFIX_FOR_WEBKIT_DEVELOPMENT to make it consistently reusable.
4035
4036 2015-08-27  Alex Christensen  <achristensen@webkit.org>
4037
4038         Make DLLLauncherMain executables dependent on dll
4039         https://bugs.webkit.org/show_bug.cgi?id=148548
4040
4041         Reviewed by Brent Fulgham.
4042
4043         * DumpRenderTree/CMakeLists.txt:
4044         * DumpRenderTree/PlatformWin.cmake:
4045         * MiniBrowser/win/CMakeLists.txt:
4046         * TestWebKitAPI/CMakeLists.txt:
4047         * TestWebKitAPI/PlatformWin.cmake:
4048
4049 2015-08-27  Lucas Forschler  <lforschler@apple.com>
4050
4051         Remove Mac slaves 188/189 after being replaced with 400/401.
4052
4053         Unreviewed.
4054
4055         * BuildSlaveSupport/build.webkit.org-config/config.json:
4056
4057 2015-08-27  Lucas Forschler  <lforschler@apple.com>
4058
4059         Add two bots to the Mac Yosemite queue.
4060         This is to eventually replace bots188/189, which will be removed after 400/401 are vetted.
4061
4062         Unreviewed.
4063
4064         * BuildSlaveSupport/build.webkit.org-config/config.json:
4065
4066 2015-08-27  Alex Christensen  <achristensen@webkit.org>
4067
4068         [Win CMake] Fix incremental build after r188673
4069         https://bugs.webkit.org/show_bug.cgi?id=148539
4070
4071         Reviewed by Brent Fulgham.
4072
4073         * TestWebKitAPI/PlatformWin.cmake:
4074         Copy forwarding headers from WebCore before building in case that was not yet done.
4075         It used to be done when running CMake, but now it's a build step.
4076
4077 2015-08-27  Nan Wang  <n_wang@apple.com>
4078
4079         AX: Fix accessibility/select-element-at-index.html test
4080         https://bugs.webkit.org/show_bug.cgi?id=148516
4081
4082         Reviewed by Chris Fleizach.
4083
4084         Implemented setSelectedChildAtIndex and removeSelectionAtIndex for mac.
4085
4086         * DumpRenderTree/AccessibilityUIElement.cpp:
4087         (setSelectedChildCallback):
4088         (setSelectedChildAtIndexCallback):
4089         (removeSelectionAtIndexCallback):
4090         (elementAtPointCallback):
4091         (sentenceAtOffsetCallback):
4092         (stringForSelectionCallback):
4093         (AccessibilityUIElement::getJSClass):
4094         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4095         (AccessibilityUIElement::setSelectedChild):
4096         (AccessibilityUIElement::setSelectedChildAtIndex):
4097         (AccessibilityUIElement::removeSelectionAtIndex):
4098         (AccessibilityUIElement::accessibilityValue):
4099         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
4100         (WTR::AccessibilityUIElement::wordAtOffset):
4101         (WTR::AccessibilityUIElement::lineAtOffset):
4102         (WTR::AccessibilityUIElement::sentenceAtOffset):
4103         (WTR::AccessibilityUIElement::isSelectable):
4104         (WTR::AccessibilityUIElement::isMultiSelectable):
4105         (WTR::AccessibilityUIElement::setSelectedChild):
4106         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
4107         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
4108         (WTR::AccessibilityUIElement::selectedChildrenCount):
4109         (WTR::AccessibilityUIElement::selectedChildAtIndex):
4110         (WTR::AccessibilityUIElement::isExpanded):
4111         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
4112         (WTR::AccessibilityUIElement::setSelectedChild):
4113         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
4114         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
4115         (WTR::AccessibilityUIElement::accessibilityValue):
4116
4117 2015-08-27  Alex Christensen  <achristensen@webkit.org>
4118
4119         Build fix after r188982
4120
4121         * MiniBrowser/win/CMakeLists.txt:
4122         The directory structure changed in the move.
4123
4124 2015-08-27  Michael Catanzaro  <mcatanzaro@igalia.com>
4125
4126         [GTK] Unreviewed, install-dependencies should install geoclue2 on Fedora
4127
4128         geoclue-devel is for obsolete geoclue. Install geoclue2-devel instead.
4129
4130         * gtk/install-dependencies:
4131
4132 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
4133
4134         Unreviewed. Mark WTF_WordLock.ContendedShortSection as slow too.
4135
4136         * Scripts/run-gtk-tests:
4137         (TestRunner):
4138
4139 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
4140
4141         Fix GTK+ WTR crashes in initializeMainRunLoop()
4142
4143         Rubber-stamped by Žan Doberšek.
4144
4145         Initialize threading and main thread before
4146         RunLoop::initializeMainRunLoop(), since the GLib implementation of
4147         the RunLoop uses isMainThread() to decide whether to create a new
4148         GMainContext or use the default one. Also use RunLoop::run() and
4149         ::stop() instead of gtk_main/quit.
4150
4151         * WebKitTestRunner/TestController.cpp:
4152         (WTR::TestController::initialize):
4153         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
4154         (WTR::TestController::notifyDone):
4155         (WTR::TestController::platformRunUntil):
4156
4157 2015-08-27  Filip Pizlo  <fpizlo@apple.com>
4158
4159         Unreviewed, further shorten a test that times out because it's very long
4160         running.
4161
4162         I've locally run these tests on repeat for 24 hours and found no genuine
4163         failures, like deadlocks. So, the timeouts are probably because the test
4164         machine is slow and debug is slow. We should just run this test for fewer
4165         iterations.
4166
4167         * TestWebKitAPI/Tests/WTF/Lock.cpp:
4168         (TestWebKitAPI::TEST):
4169
4170 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
4171
4172         Unreviewed build fix attempt on EFL
4173
4174         * WebKitTestRunner/PlatformEfl.cmake:
4175
4176 2015-08-26  Alex Christensen  <achristensen@webkit.org>
4177
4178         Build fix after r188982
4179
4180         * MiniBrowser/win/CMakeLists.txt:
4181         Find .rc files in correct directory.
4182
4183 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
4184
4185         [EFL] Bump cairo version to 1.14.2
4186         https://bugs.webkit.org/show_bug.cgi?id=148474
4187
4188         Reviewed by Csaba Osztrogonác.
4189
4190         * efl/jhbuild.modules:
4191
4192 2015-08-26  Andy Estes  <aestes@apple.com>
4193
4194         Crash when following a Google search link to Twitter with Limit Adult Content enabled
4195         https://bugs.webkit.org/show_bug.cgi?id=147651
4196
4197         Rubber-stamped by Brady Eidson.
4198
4199         Taught TestRunner how to decide the navigation policy after a delay.
4200
4201         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4202         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4203         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
4204         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4205         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
4206         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4207         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
4208         * WebKitTestRunner/TestController.cpp:
4209         (WTR::TestController::initialize):
4210         (WTR::TestController::resetStateToConsistentValues):
4211         (WTR::TestController::decidePolicyForNavigationAction):
4212         * WebKitTestRunner/TestController.h:
4213         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
4214         * WebKitTestRunner/TestInvocation.cpp:
4215         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
4216
4217 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
4218
4219         [Win] Rename 'WinLauncher' to 'MiniBrowser'
4220         https://bugs.webkit.org/show_bug.cgi?id=148485