Resource Load Statistics: Classify resources as prevalent based on redirects to other...
[WebKit-https.git] / Tools / ChangeLog
1 2018-02-12  John Wilander  <wilander@apple.com>
2
3         Resource Load Statistics: Classify resources as prevalent based on redirects to other prevalent resources
4         https://bugs.webkit.org/show_bug.cgi?id=182664
5         <rdar://problem/37372572>
6
7         Reviewed by Brent Fulgham.
8
9         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
10         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
11         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
12         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
13         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
14         * WebKitTestRunner/InjectedBundle/TestRunner.h:
15         * WebKitTestRunner/TestController.cpp:
16         (WTR::TestController::setStatisticsSubresourceUniqueRedirectFrom):
17         (WTR::TestController::setStatisticsTopFrameUniqueRedirectTo):
18         (WTR::TestController::setStatisticsTopFrameUniqueRedirectFrom):
19         * WebKitTestRunner/TestController.h:
20         * WebKitTestRunner/TestInvocation.cpp:
21         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
22
23 2018-02-12  Ross Kirsling  <ross.kirsling@sony.com>
24
25         download-latest-github-release .py should not use "browser download URL".
26         https://bugs.webkit.org/show_bug.cgi?id=182646
27
28         Reviewed by Per Arne Vollan.
29
30         * Scripts/download-latest-github-release.py:
31         Download request should be a proper GitHub API call and should actually include the token when applicable.
32         (Also clean up usage of args and print while we're in here.)
33
34 2018-02-12  Per Arne Vollan  <pvollan@apple.com>
35
36         EWS should run Windows tests.
37         https://bugs.webkit.org/show_bug.cgi?id=177967
38
39         Reviewed by Lucas Forschler.
40
41         This will help catch regressions at an early stage.
42
43         * Scripts/webkitpy/common/config/ews.json:
44
45 2018-02-08  Ryosuke Niwa  <rniwa@webkit.org>
46
47         REGRESSION (r223440): Copying & pasting a list from Microsoft Word to TinyMCE fails
48         https://bugs.webkit.org/show_bug.cgi?id=182564
49
50         Reviewed by Wenson Hsieh.
51
52         Added tests for pasting HTML with list items generated by Microsoft Word as well as HTML which looks like
53         the one generated by Microsoft Word but missing a proper "html" element at the beginning.
54
55         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
56         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm: Added test cases.
57         * TestWebKitAPI/Tests/WebKitCocoa/PasteWebArchive.mm: Added test cases.
58         (msoListMarkupWithoutProperHTMLElement): Added.
59         * TestWebKitAPI/Tests/WebKitCocoa/mso-list.html: Added.
60
61 2018-02-09  Don Olmstead  <don.olmstead@sony.com>
62
63         [CMake] Make PAL headers copies
64         https://bugs.webkit.org/show_bug.cgi?id=182645
65
66         Reviewed by Alex Christensen.
67
68         * TestWebKitAPI/CMakeLists.txt:
69
70 2018-02-08  Wenson Hsieh  <wenson_hsieh@apple.com>
71
72         Pasting from Excel no longer provides text/html data
73         https://bugs.webkit.org/show_bug.cgi?id=182636
74         <rdar://problem/37087060>
75
76         Reviewed by Ryosuke Niwa.
77
78         Add new API tests to exercise pasting images with various other content types on macOS, and when dropping images
79         and HTML markup on iOS. See the WebCore ChangeLog for more detail.
80
81         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
82         * TestWebKitAPI/Tests/WebKitCocoa/DataTransfer.html: Added.
83
84         Add a new API test harness that dumps various bits of information about a DataTransfer upon paste and drop.
85         While somewhat similar to some existing harnesses, this makes a distinction between the raw HTML data on the
86         pasteboard and the actual result of inserting said HTML into the DOM. This allows us to check that the HTML has
87         been sanitized, while making checks for the actual content of the HTML robust against inline style changes.
88
89         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
90         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm: Added.
91
92         Add a new test suite to exercise pasting mixed content types. In these test cases, the pasteboard contains a
93         file, with some combination of plain text, rich text, and URLs.
94
95         (imagePath):
96         (writeTypesAndDataToPasteboard):
97
98         Add a helper to write a var-arg list of content types and data to the general NSPasteboard.
99
100         (setUpWebView):
101         (markupString):
102         (TestWebKitAPI::TEST):
103         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
104         (TestWebKitAPI::testIconImageData):
105         (TestWebKitAPI::TEST):
106         * TestWebKitAPI/cocoa/TestWKWebView.h:
107
108         Move a private declaration of -[WKWebView paste:] out to TestWKWebView.h, so that it can be shared across
109         multiple tests. Currently, it only resides in PasteImage.mm, but I need it in PasteMixedContent.mm as well.
110
111 2018-02-09  Carlos Garcia Campos  <cgarcia@igalia.com>
112
113         Add a way to check if a host is an IP address
114         https://bugs.webkit.org/show_bug.cgi?id=182427
115
116         Reviewed by Alex Christensen.
117
118         Add unit test for URL::hostIsIPAddress().
119
120         * TestWebKitAPI/Tests/WebCore/URL.cpp:
121         (TestWebKitAPI::TEST_F):
122
123 2018-02-09  Philippe Normand  <pnormand@igalia.com>
124
125         [GStreamer] Layout test fast/replaced/border-radius-clip.html crashes with GStreamer-CRITICAL **: gst_segment_to_stream_time: assertion 'segment->format == format' failed in gst_segment_to_stream_time()
126         https://bugs.webkit.org/show_bug.cgi?id=176802
127
128         Reviewed by Xabier Rodriguez-Calvar.
129
130         * gstreamer/jhbuild.modules:
131         * gstreamer/patches/gst-plugins-good-0001-gstgdkpixbufdec-stop-pretending-to-decode-gifs.patch: Added.
132
133 2018-02-09  Philippe Normand  <pnormand@igalia.com>
134
135         [JHBuild] Update Mesa to version 17
136         https://bugs.webkit.org/show_bug.cgi?id=182599
137
138         Reviewed by Carlos Alberto Lopez Perez.
139
140         * gtk/jhbuild.modules: Update Mesa (and its dependencies, hopefully) to version 17.3.3.
141
142 2018-02-08  Chris Dumez  <cdumez@apple.com>
143
144         There should be a way to disable [OverrideBuiltins] behavior in a given DOMWrapperWorld
145         https://bugs.webkit.org/show_bug.cgi?id=182524
146         <rdar://problem/9057327>
147
148         Reviewed by Ryosuke Niwa.
149
150         Add API test coverage.
151
152         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
153         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp: Added.
154         (TestWebKitAPI::runJavaScriptAlert):
155         (TestWebKitAPI::TEST):
156         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp: Added.
157         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::InjectedBundleDisableOverrideBuiltinsBehaviorTest):
158         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
159         * TestWebKitAPI/Tests/WebKit/override-builtins-test.html: Added.
160
161 2018-02-08  Michael Catanzaro  <mcatanzaro@igalia.com>
162
163         TestController should not exercise cocoa-specific resource load statistics APIs
164         https://bugs.webkit.org/show_bug.cgi?id=182355
165
166         Reviewed by Alex Christensen.
167
168         Remove unnecessary use of platform-specific APIs in the TestController, since there are
169         cross-platform APIs to do the same thing.
170
171         Also, ensure callbacks execute before returning from TestController's functions, since
172         otherwise the tests are guaranteed to be flaky at best, and also since there's nothing to
173         prevent the TestController from being destroyed before the callbacks execute.
174
175         * WebKitTestRunner/TestController.cpp:
176         (WTR::resourceStatisticsVoidResultCallback):
177         (WTR::resourceStatisticsBooleanResultCallback):
178         (WTR::TestController::isStatisticsPrevalentResource):
179         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
180         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
181         (WTR::TestController::isStatisticsHasHadUserInteraction):
182         (WTR::TestController::isStatisticsGrandfathered):
183         (WTR::TestController::statisticsUpdateCookiePartitioning):
184         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
185         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
186         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
187         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
188         (WTR::resourceStatisticsCallback): Deleted.
189         (WTR::TestController::statisticsClearThroughWebsiteDataRemovalCallback): Deleted.
190         * WebKitTestRunner/TestController.h:
191         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
192         (WTR::toNSString): Deleted.
193         (WTR::TestController::setStatisticsLastSeen): Deleted.
194         (WTR::TestController::setStatisticsPrevalentResource): Deleted.
195         (WTR::TestController::isStatisticsPrevalentResource): Deleted.
196         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder): Deleted.
197         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo): Deleted.
198         (WTR::TestController::setStatisticsHasHadUserInteraction): Deleted.
199         (WTR::TestController::setStatisticsHasHadNonRecentUserInteraction): Deleted.
200         (WTR::TestController::isStatisticsHasHadUserInteraction): Deleted.
201         (WTR::TestController::setStatisticsGrandfathered): Deleted.
202         (WTR::TestController::isStatisticsGrandfathered): Deleted.
203         (WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin): Deleted.
204         (WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin): Deleted.
205         (WTR::TestController::setStatisticsSubresourceUniqueRedirectTo): Deleted.
206         (WTR::TestController::setStatisticsTimeToLiveUserInteraction): Deleted.
207         (WTR::TestController::setStatisticsTimeToLiveCookiePartitionFree): Deleted.
208         (WTR::TestController::statisticsProcessStatisticsAndDataRecords): Deleted.
209         (WTR::TestController::statisticsUpdateCookiePartitioning): Deleted.
210         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost): Deleted.
211         (WTR::TestController::statisticsSubmitTelemetry): Deleted.
212         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned): Deleted.
213         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval): Deleted.
214         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured): Deleted.
215         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval): Deleted.
216         (WTR::TestController::setStatisticsGrandfatheringTime): Deleted.
217         (WTR::TestController::setStatisticsMaxStatisticsEntries): Deleted.
218         (WTR::TestController::setStatisticsPruneEntriesDownTo): Deleted.
219         (WTR::TestController::statisticsClearInMemoryAndPersistentStore): Deleted.
220         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours): Deleted.
221         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval): Deleted.
222         (WTR::TestController::statisticsResetToConsistentState): Deleted.
223
224 2018-02-08  Jonathan Bedard  <jbedard@apple.com>
225
226         webkit-patch suggest-reviewers dies with AttributeError: 'NoneType' object has no attribute 'revision'
227         https://bugs.webkit.org/show_bug.cgi?id=182584
228
229         Reviewed by Daniel Bates.
230
231         It is possible that a specific revision has an empty ChangeLog. In this case, Checkout.commit_info_for_revision
232         will return 'None'. Checkout.recent_commit_infos_for_files should never return a set with 'None' in it.
233
234         * Scripts/webkitpy/common/checkout/checkout.py:
235         (Checkout.recent_commit_infos_for_files): Remove any empty commit information from the set.
236         * Scripts/webkitpy/common/checkout/checkout_unittest.py: Add a file which references an empty ChangeLog.
237
238 2018-02-08  Matt Lewis  <jlewis3@apple.com>
239
240         Unreviewed, rolling out r228261.
241
242         This broke an internal build
243
244         Reverted changeset:
245
246         "Add a way to check if a host is an IP address"
247         https://bugs.webkit.org/show_bug.cgi?id=182427
248         https://trac.webkit.org/changeset/228261
249
250 2018-02-08  Commit Queue  <commit-queue@webkit.org>
251
252         Unreviewed, rolling out r228267, r228268, and r228269.
253         https://bugs.webkit.org/show_bug.cgi?id=182601
254
255         jhbuild socks (Requested by philn on #webkit).
256
257         Reverted changesets:
258
259         "[JHBuild] Update Mesa to version 17"
260         https://bugs.webkit.org/show_bug.cgi?id=182599
261         https://trac.webkit.org/changeset/228267
262
263         "Unreviewed, GTK build fix attempt after r228267."
264         https://trac.webkit.org/changeset/228268
265
266         "Unreviewed, final GTK build fix attempt after r228267."
267         https://trac.webkit.org/changeset/228269
268
269 2018-02-08  Philippe Normand  <pnormand@igalia.com>
270
271         Unreviewed, final GTK build fix attempt after r228267.
272
273         * gtk/jhbuild.modules: sha256sum for libdrm was for the tar.gz archive. Oops.
274
275 2018-02-08  Philippe Normand  <pnormand@igalia.com>
276
277         Unreviewed, GTK build fix attempt after r228267.
278
279         * gtk/jhbuild.modules: Update to libdrm version 2.4.89, Mesa 17 requires at least version 2.4.75.
280
281 2018-02-08  Philippe Normand  <pnormand@igalia.com>
282
283         [JHBuild] Update Mesa to version 17
284         https://bugs.webkit.org/show_bug.cgi?id=182599
285
286         Reviewed by Carlos Alberto Lopez Perez.
287
288         * gtk/jhbuild.modules: Update Mesa to version 17.3.3.
289
290 2018-02-05  Carlos Garcia Campos  <cgarcia@igalia.com>
291
292         Add a way to check if a host is an IP address
293         https://bugs.webkit.org/show_bug.cgi?id=182427
294
295         Reviewed by Alex Christensen.
296
297         Add unit test for URL::hostIsIPAddress().
298
299         * TestWebKitAPI/Tests/WebCore/URL.cpp:
300         (TestWebKitAPI::TEST_F):
301
302 2018-02-07  Tim Horton  <timothy_horton@apple.com>
303
304         Evernote device management web view sometimes displays at the wrong scale
305         https://bugs.webkit.org/show_bug.cgi?id=182590
306         <rdar://problem/36633687>
307
308         Reviewed by Simon Fraser.
309
310         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
311         * TestWebKitAPI/Tests/ios/WKScrollViewDelegate.mm: Renamed from Tools/TestWebKitAPI/Tests/ios/WKScrollViewDelegateCrash.mm.
312         (-[TestDelegateForScrollView dealloc]):
313         (TestWebKitAPI::TEST):
314         (-[WKScrollViewDelegateWithViewForZoomingOverridden viewForZoomingInScrollView:]):
315         Add a test that failed before the change that ensures that we don't
316         consult the external delegate for viewForZoomingInScrollView:, and that
317         we succesfully update the scale even if it matches that of the view
318         the external delegate returns for viewForZoomingInScrollView:.
319
320 2018-02-07  Wenson Hsieh  <wenson_hsieh@apple.com>
321
322         REGRESSION(r226396): File paths are inserted when dropping image files
323         https://bugs.webkit.org/show_bug.cgi?id=182557
324         <rdar://problem/37294120>
325
326         Reviewed by Ryosuke Niwa.
327
328         Tweak some image pasting API tests to ensure that file paths are not inserted when pasting images backed by
329         file paths on disk.
330
331         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
332         (TEST):
333
334 2018-02-07  Ms2ger  <Ms2ger@igalia.com>
335
336         [GTK] Enable WebKit.GeolocationTransitionTo{High,Low}Accuracy tests
337         https://bugs.webkit.org/show_bug.cgi?id=125068
338
339         Unreviewed test gardening.
340
341         They do not appear to have failed since we started running them again in r226944.
342
343         * TestWebKitAPI/glib/TestExpectations.json:
344
345 2018-02-07  Ms2ger  <Ms2ger@igalia.com>
346
347         [GTK] Enable WebKit.InjectedBundleFrameHitTest test
348         https://bugs.webkit.org/show_bug.cgi?id=120303
349
350         Unreviewed test gardening.
351
352         It does not appear to have failed since we started running it again in r226944.
353
354         * TestWebKitAPI/glib/TestExpectations.json:
355
356 2018-02-07  Ms2ger  <Ms2ger@igalia.com>
357
358         [GTK] Enable WebKit.ForceRepaint test
359         https://bugs.webkit.org/show_bug.cgi?id=105532
360
361         Unreviewed test gardening.
362
363         It does not appear to have failed since we started running it again in r226944.
364
365         * TestWebKitAPI/glib/TestExpectations.json:
366
367 2018-02-07  Philippe Normand  <pnormand@igalia.com>
368
369         [JHBuild] Add libva in moduleset
370         https://bugs.webkit.org/show_bug.cgi?id=182384
371
372         Reviewed by Xabier Rodriguez-Calvar.
373
374         * gstreamer/jhbuild.modules: Add libva and disable spurious message output.
375         * gtk/install-dependencies: Remove libva from dependencies.
376         * wpe/install-dependencies: Ditto.
377
378 2018-02-07  Ms2ger  <Ms2ger@igalia.com>
379
380         [GTK] Enable WebKit.NewFirstVisuallyNonEmptyLayoutFrames test
381         https://bugs.webkit.org/show_bug.cgi?id=85037
382
383         Unreviewed test gardening.
384
385         It does not appear to have failed since we started running it again in r226944.
386
387         * TestWebKitAPI/glib/TestExpectations.json:
388
389 2018-02-06  Leo Balter  <leonardo.balter@gmail.com>
390
391         Nit fix for ruby script called through Perl
392         https://bugs.webkit.org/show_bug.cgi?id=182552
393
394         Reviewed by Yusuke Suzuki.
395
396         * BuildSlaveSupport/build.webkit.org-config/steps.py:
397         (RunTest262Tests):
398
399 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
400
401         Remove WebCore/ForwardingHeaders directory
402         https://bugs.webkit.org/show_bug.cgi?id=182347
403
404         Reviewed by Keith Miller.
405
406         * WebKitTestRunner/TestController.cpp:
407
408 2018-02-06  Ross Kirsling  <ross.kirsling@sony.com>
409
410         webkit-patch upload should ask for confirmation before creating a new bug
411         https://bugs.webkit.org/show_bug.cgi?id=182551
412
413         Reviewed by Daniel Bates.
414
415         It is quite easy to paste unintended text into the bug number prompt. This creates a junk bug with an uneditable
416         first comment, which could result in embarrassment or potentially even a proprietary information leak.
417
418         * Scripts/webkitpy/tool/commands/upload_unittest.py:
419         (test_prepare):
420         * Scripts/webkitpy/tool/steps/promptforbugortitle.py:
421         (PromptForBugOrTitle):
422         (PromptForBugOrTitle.options):
423         (PromptForBugOrTitle.run):
424
425 2018-02-06  Youenn Fablet  <youenn@apple.com>
426
427         HasServiceWorkerRegistration bit should be sent when creating a new page
428         https://bugs.webkit.org/show_bug.cgi?id=182410
429
430         Reviewed by Chris Dumez.
431
432         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
433
434 2018-02-06  Andres Gomez  <agomez@igalia.com>
435
436         [GTK][WPE] Add dependencies watching lists for WKGTK+ and WPE
437         https://bugs.webkit.org/show_bug.cgi?id=182346
438
439         Reviewed by Michael Catanzaro.
440
441         Loren, Carlos and Andres are interested on the WKGTK+ dependencies
442         watchlist since they are running WKGTK+ EWS.
443
444         Similarly, Adrian and Carlos are running a WPE EWS.
445
446         * Scripts/webkitpy/common/config/watchlist: Added WPEDependencies
447           and WebKitGTKDependencies watchlists with the proper people.
448
449 2018-02-06  Andres Gomez  <agomez@igalia.com>
450
451         Unreviewed, canonicalize contributors.json
452
453         After Thibault's addition, automatic checks complain about
454         contributors.json with:
455
456         "[...] Use "validate-committer-lists --canonicalize" to reformat
457         it. [...]"
458
459         * Scripts/webkitpy/common/config/contributors.json: Canonicalize.
460
461 2018-02-06  Andres Gomez  <agomez@igalia.com>
462
463         Unreviewed, add Lorenzo Tilve to contributors.json
464
465         We need to add Loren to the contributors list in order to CC him
466         in Bugzilla.
467
468         * Scripts/webkitpy/common/config/contributors.json: Added Lorenzo
469           Tilve.
470
471 2018-02-05  Yousuke Kimoto  <yousuke.kimoto@sony.com>
472
473         [WinCairo] Refine WebKitLegacy and WebKit build for wincairo
474         https://bugs.webkit.org/show_bug.cgi?id=182478
475
476         Reviewed by Alex Christensen.
477
478         For TestWebKitAPI, sources related to WebKitLegacy are built
479         at WebKit build. Those files should be reffered for WebKitLegacy build.
480
481         * TestWebKitAPI/PlatformWin.cmake:
482
483 2018-02-05  Daniel Bates  <dabates@apple.com>
484
485         REGRESSION (r217572): run-webkit-tests exits without emitting newline character
486         https://bugs.webkit.org/show_bug.cgi?id=182360
487
488         Rubber-stamped by Aakash Jain.
489
490         Fixes an annoyance where run-webkit-tests always exits without printing a newline character.
491         In the terminal this looks like:
492
493             $ Tools/Scripts/run-webkit-tests
494             Expected to fail, but passed: (7)
495             ...
496             Stopping WebSocket server ...$
497
498         This bug was caused by code added in r217572 to stop all run-webkit-tests started servers (e.g. an HTTP
499         server) from an at-exit handler. When run-webkit-tests runs successfully (i.e. without error or
500         control-C interruption) we would stop all such servers twice: once as part of ending the test
501         run and once from the at-exit handler. The latter never prints a trailing newline character hence
502         the state of the terminal (as depicted above). Instead LayoutTestRunner.stop_servers() should only
503         stop servers that it started in LayoutTestRunner.start_servers().
504
505         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
506         (LayoutTestRunner.__init__):
507         (LayoutTestRunner.start_servers):
508         (LayoutTestRunner.stop_servers):
509         Only start servers that run-webkit-tests has not already started and only stop servers that
510         run-webkit-tests started.
511
512         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
513         (LayoutTestRunnerTests.test_servers_started.is_websocket_server_running):
514         (LayoutTestRunnerTests.test_servers_started):
515         (LayoutTestRunnerTests.test_servers_started.is_websocket_servers_running): Deleted.
516         Update due to rename below.
517
518         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
519         (is_web_socket_server_running): Added.
520         (PyWebSocket.is_running): Deleted.
521
522         * Scripts/webkitpy/port/base.py:
523         (Port.is_http_server_running): Check if we already started the server ourself.
524         (Port.is_websocket_server_running): Formerly named is_websocket_servers_running. Modified
525         to check if we already started the server ourself. Take a similar approach as the other
526         Port.is_*_running methods and only check if an existing WebSocket server is running on the
527         non-secure server port. This is a simple heuristic and should be sufficient in practice.
528         (Port.is_wpt_server_running): Check if we already started the server ourself.
529         (Port.is_websocket_servers_running): Deleted; renamed to is_websocket_server_running().
530
531 2018-02-05  Daniel Bates  <dabates@apple.com>
532
533         prepare-ChangeLog gets confused about Python docstrings that contain the word "class" or "def"
534         https://bugs.webkit.org/show_bug.cgi?id=182405
535
536         Reviewed by David Kilzer.
537
538         String literal statements, including docstrings, do not demarcate a new scope in Python.
539         So, do not treat them like they do when building up the list of modified functions.
540
541         * Scripts/prepare-ChangeLog:
542         (get_function_line_ranges_for_python):
543         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt:
544         The expected ending line number for the last "pass" statement inside the scope of Class5 changed
545         from 97 to 98 because empty lines do not effect scope. This is consistent with the parsing
546         of the second "pass" statement in the scope of class Class5. A "pass" is a null operation that
547         is used as a syntactic placeholder when a statement is required. Ideally we would make
548         the parsing code smarter so as to avoid emitting ranges for "pass" statements that serve
549         not syntactic purpose.
550         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests.py:
551         (Class5):
552         (Class6):
553         (Class6.__init__):
554         (Class7):
555         (Class7.__init__):
556         (Class8):
557         (Class8.__init__):
558         Add some more tests.
559
560 2018-02-05  Matt Lewis  <jlewis3@apple.com>
561
562         Unreviewed, rolling out r228086.
563
564         This introduced a failure with API test
565         URLTest.HostIsIPAddress.
566
567         Reverted changeset:
568
569         "Add a way to check if a host is an IP address"
570         https://bugs.webkit.org/show_bug.cgi?id=182427
571         https://trac.webkit.org/changeset/228086
572
573 2018-02-05  John Wilander  <wilander@apple.com>
574
575         Storage Access API: Add testRunner.getAllStorageAccessEntries() to make testing easier and more explicit
576         https://bugs.webkit.org/show_bug.cgi?id=181601
577         <rdar://problem/36475837>
578
579         Reviewed by Alex Christensen.
580
581         http/tests/storageAccess/request-and-grant-access-then-detach-should-not-have-access.html
582         was found to be flaky. With the testRunner.hasStorageAccessEntry() getter
583         it's possible to check access even if a frame doesn't respond timely to
584         postMessage after detach and attach.
585
586         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
587         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
588         (WTR::InjectedBundle::didReceiveMessageToPage):
589         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
590         (WTR::TestRunner::setStorageAccessAPIEnabled):
591             Just moved for source file grouping.
592         (WTR::TestRunner::getAllStorageAccessEntries):
593         (WTR::TestRunner::callDidReceiveAllStorageAccessEntriesCallback):
594         * WebKitTestRunner/InjectedBundle/TestRunner.h:
595         * WebKitTestRunner/TestController.cpp:
596         (WTR::TestController::getAllStorageAccessEntries):
597             Note that this is just stubbed out, i.e. not implemented.
598         * WebKitTestRunner/TestController.h:
599         * WebKitTestRunner/TestInvocation.cpp:
600         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
601         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
602         * WebKitTestRunner/TestInvocation.h:
603         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
604         (WTR::TestController::getAllStorageAccessEntries):
605             This is the Cocoa-specific version of this test infrastructure.
606
607 2018-02-05  Basuke Suzuki  <Basuke.Suzuki@sony.com>
608
609         [Win] Enable multi CPU building on MSBuild.
610         https://bugs.webkit.org/show_bug.cgi?id=182446
611
612         Compiling itself already uses multi cores, but other stuff is still on single core.
613         This patch enables that by passing an argument to MSBuild.exe.
614
615         Reviewed by Alex Christensen.
616
617         * Scripts/webkitdirs.pm:
618         (determineNumberOfCPUs):
619         (buildVisualStudioProject):
620
621 2018-02-05  Alicia Boya García  <aboya@igalia.com>
622
623         Fix bug in MediaTime comparison for negative values with different scale.
624         https://bugs.webkit.org/show_bug.cgi?id=182433
625
626         Improved test coverage for MediaTime::compare().
627
628         Reviewed by Xabier Rodriguez-Calvar.
629
630         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
631         (TestWebKitAPI::TEST):
632
633 2018-02-05  Carlos Garcia Campos  <cgarcia@igalia.com>
634
635         [SOUP] WebSockets must use system proxy settings
636         https://bugs.webkit.org/show_bug.cgi?id=126384
637
638         Reviewed by Michael Catanzaro.
639
640         Check also WebSockets in /webkit2/WebKitWebContext/proxy.
641
642         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
643         (ProxyTest::webSocketProxyServerCallback):
644         (ProxyTest::ProxyTest):
645         (ProxyTest::webSocketConnected):
646         (ProxyTest::createWebSocketAndWaitUntilConnected):
647         (webSocketServerCallback):
648         (testWebContextProxySettings):
649         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
650         (WebKitTestServer::~WebKitTestServer):
651         (WebKitTestServer::addWebSocketHandler):
652         (WebKitTestServer::removeWebSocketHandler):
653         (WebKitTestServer::getWebSocketURIForPath const):
654         (WebKitTestServer::getURIForPath const):
655         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h:
656         (WebKitTestServer::baseURI const):
657         (WebKitTestServer::baseWebSocketURI const):
658
659 2018-02-05  Carlos Garcia Campos  <cgarcia@igalia.com>
660
661         Add a way to check if a host is an IP address
662         https://bugs.webkit.org/show_bug.cgi?id=182427
663
664         Reviewed by Alex Christensen.
665
666         Add unit test for URL::hostIsIPAddress().
667
668         * TestWebKitAPI/Tests/WebCore/URL.cpp:
669         (TestWebKitAPI::TEST_F):
670
671 2018-02-03  Charlie Turner  <cturner@igalia.com>
672
673         Add libmount to WPE dependencies
674         https://bugs.webkit.org/show_bug.cgi?id=182345
675
676         Reviewed by Michael Catanzaro.
677
678         * wpe/install-dependencies:
679
680 2018-02-02  Youenn Fablet  <youenn@apple.com>
681
682         W3C test exporter should allow exporting newly added files
683         https://bugs.webkit.org/show_bug.cgi?id=182369
684
685         Reviewed by Ryosuke Niwa.
686
687         * Scripts/webkitpy/common/checkout/scm/git.py:
688         (Git.apply_mail_patch):
689
690 2018-02-02  David Quesada  <david_quesada@apple.com>
691
692         WebAppManifest scope should default to the containing directory of start_url if 'scope' is not specified
693         https://bugs.webkit.org/show_bug.cgi?id=182363
694         rdar://problem/37093498
695
696         Reviewed by Ryosuke Niwa.
697
698         Updated ApplicationManifestParserTests to account for the new default scope behavior.
699
700         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
701         (assertManifestHasDefaultValues):
702         (TEST_F):
703
704 2018-02-02  Youenn Fablet  <youenn@apple.com>
705
706         Clearing all service worker registrations should wait for importing service worker registration to finish
707         https://bugs.webkit.org/show_bug.cgi?id=182407
708
709         Reviewed by Chris Dumez.
710
711         Make sure we finish clearing service worker registrations before running tests.
712
713         * WebKitTestRunner/TestController.cpp:
714         (WTR::TestController::resetStateToConsistentValues):
715         (WTR::ClearServiceWorkerRegistrationsCallbackContext::ClearServiceWorkerRegistrationsCallbackContext):
716         (WTR::clearServiceWorkerRegistrationsCallback):
717         (WTR::TestController::clearServiceWorkerRegistrations):
718         * WebKitTestRunner/TestController.h:
719
720 2018-02-02  Youenn Fablet  <youenn@apple.com>
721
722         Configure serviceWorkerRegistrationDirectory on the web site data store and move it to a Caches subfolder as a default
723         https://bugs.webkit.org/show_bug.cgi?id=182403
724
725         Reviewed by Alex Christensen.
726
727         * WebKitTestRunner/TestController.cpp:
728         (WTR::TestController::generateContextConfiguration const):
729         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
730         (WTR::initializeWebViewConfiguration):
731
732 2018-02-02  Carlos Garcia Campos  <cgarcia@igalia.com>
733
734         [GTK] WebDriver: tests step always times out in the bot
735         https://bugs.webkit.org/show_bug.cgi?id=182437
736
737         Reviewed by Carlos Alberto Lopez Perez.
738
739         The process itself is not timing out, but the buildbot step is. This is because we are leaking the Xvfb
740         processes. We should ensure that only one driver is executed and it's stopped before the process finishes.
741
742         * Scripts/run-webdriver-tests: Call teardown() after run().
743         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
744         (WebDriverSeleniumExecutor.__init__): Receive the env directly instead of the display driver.
745         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
746         (WebDriverTestRunner.__init__): Use the driver class directly instead of using the DriverProxy. Get the env from
747         the display driver once and pass it to the test runners.
748         (WebDriverTestRunner.teardown): Stop the display server.
749         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
750         (WebDriverTestRunnerSelenium.__init__): Receive the env directly instead of the display driver.
751         (WebDriverTestRunnerSelenium.collect_tests): Pass the env to the executor.
752         (WebDriverTestRunnerSelenium.run): Ditto.
753         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
754         (WebDriverTestRunnerW3C.__init__): Receive the env directly instead of the display driver.
755         (WebDriverTestRunnerW3C.run): Pass the env to the executor.
756         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
757         (WebDriverW3CExecutor.__init__): Receive the env directly instead of the display driver.
758
759 2018-02-02  Carlos Garcia Campos  <cgarcia@igalia.com>
760
761         Unreviewed, rolling out r227999.
762
763         It didn't fix the problem
764
765         Reverted changeset:
766
767         "Unreviewed. Try to avoid webdriver tests step timing out in
768         the bots."
769         https://trac.webkit.org/changeset/227999
770
771 2018-02-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
772
773         Start timeout for the run-buildbot-test script is too aggressive
774         https://bugs.webkit.org/show_bug.cgi?id=182429
775
776         Reviewed by Carlos Garcia Campos.
777
778         15 seconds is not enough waiting for the update database process
779         to complete on a system backed with rotational HDDs. Raise it to 60.
780
781         * BuildSlaveSupport/build.webkit.org-config/run-buildbot-test.py:
782         (wait_for_master_ready):
783
784 2018-02-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
785
786         re-add ARM JSCOnly bots on buildbot waterfall
787         https://bugs.webkit.org/show_bug.cgi?id=182428
788
789         Reviewed by Csaba Osztrogonác.
790
791         * BuildSlaveSupport/build.webkit.org-config/config.json:
792         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
793
794 2018-02-02  Csaba Osztrogonác  <ossy@webkit.org>
795
796         Remove ARM JSCOnly bots from buildbot waterfall
797         https://bugs.webkit.org/show_bug.cgi?id=182398
798
799         Reviewed by Alexey Proskuryakov.
800
801         * BuildSlaveSupport/build.webkit.org-config/config.json:
802         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
803
804 2018-02-02  Carlos Garcia Campos  <cgarcia@igalia.com>
805
806         Unreviewed. Try to avoid webdriver tests step timing out in the bots.
807
808         This is another speculative workaround. Carlos Lopez suggested to use os._exit() instead of sys.exit() as a
809         workaround for a bug in python2.7 when using multiprocess module.
810
811         * Scripts/run-webdriver-tests:
812
813 2018-02-01  Youenn Fablet  <youenn@apple.com>
814
815         Delay service worker process creation until actually needed by SWServer
816         https://bugs.webkit.org/show_bug.cgi?id=182301
817
818         Reviewed by Chris Dumez.
819
820         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
821         (function):
822
823 2018-02-01  Aakash Jain  <aakash_jain@apple.com>
824
825         Bubbles intermittently disappear from bot watchers dashboard
826         https://bugs.webkit.org/show_bug.cgi?id=182085
827
828         Reviewed by Alexey Proskuryakov.
829
830         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
831         (BuildbotIteration.prototype.failureLogURL): failureLogURL doesn't depend on step in Buildbot 0.9.
832         Return the Build Page URL for Buildbot Buildbot 0.9. Earlier code was also doing the same using a
833         confusing if (!this._firstFailedStep.logs) statement which is always false for Buildbot 0.9.
834
835 2018-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
836
837         [GTK] Problem with Washington Post images
838         https://bugs.webkit.org/show_bug.cgi?id=181421
839
840         Reviewed by Carlos Alberto Lopez Perez.
841
842         Add test case for the new user agent quirk.
843
844         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
845         (TestWebKitAPI::TEST):
846
847 2018-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
848
849         [GTK] MiniBrowser settings are just a list of names
850         https://bugs.webkit.org/show_bug.cgi?id=182005
851
852         Reviewed by Sergio Villar Senin.
853
854         The default size we are using is too small to show the values column, and the window is not resizable because
855         GObjectClass::constructed() is not called in the parent class.
856
857         * MiniBrowser/gtk/BrowserSettingsDialog.c:
858         (browser_settings_dialog_init): Use 600x400 as default size.
859         (browserSettingsDialogConstructed): Chain up to parent constructed.
860
861 2018-01-31  Andres Gomez  <agomez@igalia.com>
862
863         Unreviewed. Remove WebInspectorUI watchlist and remove myself from 2 watchlists more
864
865         * Scripts/webkitpy/common/config/watchlist:
866
867 2018-01-31  Per Arne Vollan  <pvollan@apple.com>
868
869         Layout Test fast/events/beforeunload-dom-manipulation-crash.html is crashing
870         https://bugs.webkit.org/show_bug.cgi?id=181204
871         <rdar://problem/36256274>
872
873         Reviewed by Ryosuke Niwa.
874
875         Implement 'testRunner.forceImmediateCompletion()' for WK1.
876
877         * DumpRenderTree/TestRunner.cpp:
878         (forceImmediateCompletionCallback):
879         (TestRunner::staticFunctions):
880
881 2018-01-31  Alex Christensen  <achristensen@webkit.org>
882
883         Unreviewed, rolling out r227942.
884
885         r227875 should not have been rolled out.
886
887         Reverted changeset:
888
889         "Unreviewed, rolling out r227875."
890         https://bugs.webkit.org/show_bug.cgi?id=182357
891         https://trac.webkit.org/changeset/227942
892
893 2018-01-31  Michael Catanzaro  <mcatanzaro@igalia.com>
894
895         Unreviewed, rolling out r227875.
896         https://bugs.webkit.org/show_bug.cgi?id=182357
897
898         Missing cross-platform TestController implementation
899
900         Reverted changeset:
901
902         "Add callbacks to testRunner.statisticsSetShouldPartitionCookiesForHost() and testRunner.statisticsUpdateCookiePartitioning()"
903         https://bugs.webkit.org/show_bug.cgi?id=181958
904         https://trac.webkit.org/changeset/227875
905
906         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
907         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
908         (WTR::InjectedBundle::didReceiveMessageToPage):
909         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
910         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
911         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
912         (WTR::TestRunner::statisticsCallDidSetPartitionOrBlockCookiesForHostCallback): Deleted.
913         * WebKitTestRunner/InjectedBundle/TestRunner.h:
914         * WebKitTestRunner/TestInvocation.cpp:
915         (WTR::TestInvocation::didSetPartitionOrBlockCookiesForHost): Deleted.
916         * WebKitTestRunner/TestInvocation.h:
917         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
918         (WTR::TestController::statisticsUpdateCookiePartitioning):
919         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
920
921 2018-01-31  Michael Catanzaro  <mcatanzaro@igalia.com>
922
923         REGRESSION(r227223): http/tests/resourceLoadStatistics/clear-in-memory-and-persistent-store-one-hour.html, http/tests/resourceLoadStatistics/grandfathering.html timing out on GTK, WPE
924         https://bugs.webkit.org/show_bug.cgi?id=182222
925
926         Reviewed by Alex Christensen.
927
928         Use the new API to notify when resource load statistics deletion is complete.
929
930         * WebKitTestRunner/TestController.cpp:
931         (WTR::TestController::statisticsClearThroughWebsiteDataRemovalCallback):
932         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
933         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
934
935 2018-01-31  Ryosuke Niwa  <rniwa@webkit.org>
936
937         Add the support for running StyleBench to run-benchmark
938         https://bugs.webkit.org/show_bug.cgi?id=182323
939
940         Reviewed by Antti Koivisto.
941
942         Added the plan file and the patch needed to run StyleBench using run-benchmark as of r227863.
943
944         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/StyleBench.patch: Added.
945         * Scripts/webkitpy/benchmark_runner/data/plans/stylebench.plan: Added.
946
947 2018-01-31  Wenson Hsieh  <wenson_hsieh@apple.com>
948
949         [iOS WK2] API test DataInteractionTests.ExternalSourceDataTransferItemGetFolderAsEntry is failing after an SDK update
950         https://bugs.webkit.org/show_bug.cgi?id=182339
951         <rdar://problem/36041396>
952
953         Reviewed by Andy Estes.
954
955         This API test wasn't meant to be dependent on the size of an image generated using UIImagePNGRepresentation().
956         To make this test robust against changes to image encoding, write the raw data to the test folder instead and
957         check against the length of the data written.
958
959         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
960         (testIconImageData):
961         (runTestWithTemporaryFolder):
962         (TestWebKitAPI::TEST):
963
964 2018-01-31  Dan Bernstein  <mitz@apple.com>
965
966         [macOS] MiniBrowser isn’t app-sandboxed
967         https://bugs.webkit.org/show_bug.cgi?id=182147
968
969         Reviewed by Sam Weinig.
970
971         Enable App Sandbox and add a temporary exception allowing read access to all files.
972
973         * MiniBrowser/Configurations/Base.xcconfig: Enabled ad-hoc code signing.
974         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Specified the entitlements file to use.
975         * MiniBrowser/MiniBrowser.entitlements: Added. Enables App Sandbox with outbound networking
976           and read access from /.
977         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Added reference to new file.
978
979 2018-01-31  Philippe Normand  <pnormand@igalia.com>
980
981         [JHBuild] Add gstreamer-vaapi in moduleset
982         https://bugs.webkit.org/show_bug.cgi?id=182283
983
984         Reviewed by Carlos Alberto Lopez Perez.
985
986         GStreamer-VAAPI is required for hardware-accelerated video
987         playback support on Intel and AMD (using radeosi driver)
988         platforms.
989
990         * gstreamer/jhbuild.modules: Add gstreamer-vaapi.
991         * gtk/install-dependencies: Install libva.
992         * wpe/install-dependencies: Ditto.
993         * Scripts/webkitpy/port/gtk.py:
994         (GtkPort.setup_environ_for_server): Disable va-api support when
995         testing because it's incompatible with Mesa's softGL driver.
996
997 2018-01-31  Charlie Turner  <cturner@igalia.com>
998
999         [WPE] Update jhbuild dependencies
1000         https://bugs.webkit.org/show_bug.cgi?id=182286
1001
1002         This upgrades the following packages,
1003         glib 2.44.1 -> 2.54.3
1004         glib-networking 2.42.0 -> 2.54.1
1005         libsoup 2.48.0 -> 2.60.3
1006
1007         The initial reason for performing these upgrades was that when
1008         visiting https://youtube.com, WPE was getting TLS certificate
1009         errors. After upgrading glib-networking, these were fixed, but the
1010         upgrade introduced dependencies on newer versions of the other
1011         packages upgraded in this commit.
1012
1013         The upgrade to glib caused a linking error in gstreamer, the
1014         following errors were being logged during linking,
1015
1016         //usr/lib/x86_64-linux-gnu/libpangoft2-1.0.so.0: undefined reference to `hb_glib_script_from_script'
1017         //usr/lib/x86_64-linux-gnu/libpangoft2-1.0.so.0: undefined reference to `hb_glib_get_unicode_funcs'
1018         //usr/lib/x86_64-linux-gnu/libpangoft2-1.0.so.0: undefined reference to `hb_glib_script_to_script'
1019
1020         This was fixed by adding the glib package built in the jhbuild to
1021         harfbuzz.
1022
1023         Finally, the upgrade of glib caused the glib-warning-fix.patch to
1024         no longer apply, so this patch was removed.
1025
1026         Reviewed by Michael Catanzaro.
1027
1028         * wpe/jhbuild.modules: Added dependecies.
1029         * wpe/patches/glib-warning-fix.patch: Removed.
1030
1031 2018-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1032
1033         Unreviewed, rolling out r227782.
1034
1035         It didn't fix the problem
1036
1037         Reverted changeset:
1038
1039         "Unreviewed. Try to avoid webdriver tests step timing out in
1040         the bots."
1041         https://trac.webkit.org/changeset/227782
1042
1043 2018-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1044
1045         WebDriver: add domains to server config in w3c tests
1046         https://bugs.webkit.org/show_bug.cgi?id=182294
1047
1048         Reviewed by Carlos Alberto Lopez Perez.
1049
1050         Several cookie tests expect server_config to have a domains key.
1051
1052         Fixes: imported/w3c/webdriver/tests/cookies/add_cookie.py::test_add_domain_cookie
1053                imported/w3c/webdriver/tests/cookies/add_cookie.py::test_add_session_cookie_with_leading_dot_character_in_domain
1054
1055         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
1056         (WebDriverW3CExecutor.__init__):
1057
1058 2018-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1059
1060         Unreviewed. Update W3C WebDriver imported tests.
1061
1062         Show full pytest failure logs.
1063
1064         pytest truncates long lists when printing a failed assertion.
1065         This is not great for debugging and arguably it should be the
1066         default to show the full diff when comparing lists.
1067
1068         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1069         (run):
1070
1071 2018-01-30  John Wilander  <wilander@apple.com>
1072
1073         Add callbacks to testRunner.statisticsSetShouldPartitionCookiesForHost() and testRunner.statisticsUpdateCookiePartitioning()
1074         https://bugs.webkit.org/show_bug.cgi?id=181958
1075         https://bugs.webkit.org/show_bug.cgi?id=182072
1076         <rdar://problem/36801804>
1077         <rdar://problem/36845795>
1078
1079         Reviewed by Brent Fulgham.
1080
1081         Because of the asynchronous nature of XPC and cookies,
1082         we need callbacks in these TestRunner functions so that
1083         the layout tests can wait for state changes to finish
1084         before checking test conditions.
1085
1086         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1087         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1088         (WTR::InjectedBundle::didReceiveMessageToPage):
1089         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1090         (WTR::TestRunner::statisticsUpdateCookiePartitioning):
1091         (WTR::TestRunner::statisticsSetShouldPartitionCookiesForHost):
1092         (WTR::TestRunner::statisticsCallDidSetPartitionOrBlockCookiesForHostCallback):
1093         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1094         * WebKitTestRunner/TestInvocation.cpp:
1095         (WTR::TestInvocation::didSetPartitionOrBlockCookiesForHost):
1096         * WebKitTestRunner/TestInvocation.h:
1097         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1098         (WTR::TestController::statisticsUpdateCookiePartitioning):
1099         (WTR::TestController::statisticsSetShouldPartitionCookiesForHost):
1100
1101 2018-01-30  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1102
1103         [webkitpy] Config file for apache is copied twice.
1104         https://bugs.webkit.org/show_bug.cgi?id=182131
1105
1106         Reviewed by Daniel Bates.
1107
1108         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1109         (LayoutTestApacheHttpd.__init__):
1110         (LayoutTestApacheHttpd._copy_apache_config_file):
1111         (LayoutTestApacheHttpd._get_apache_config_file_path): Deleted.
1112
1113 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
1114
1115         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
1116         https://bugs.webkit.org/show_bug.cgi?id=182312
1117
1118         Reviewed by Michael Catanzaro.
1119
1120         * DumpRenderTree/config.h:
1121         * TestWebKitAPI/config.h:
1122         * WebKitTestRunner/config.h:
1123
1124 2018-01-30  Wenson Hsieh  <wenson_hsieh@apple.com>
1125
1126         [iOS] API test UIPasteboardTests.DataTransferGetDataWhenPastingPlatformRepresentations fails after r223440
1127         https://bugs.webkit.org/show_bug.cgi?id=182307
1128         <rdar://problem/36041485>
1129
1130         Reviewed by Ryosuke Niwa.
1131
1132         Adjusts a failing API test that we forgot to rebaseline after r223440, which ensures that the result of reading
1133         "text/html" from the DataTransfer is sanitized markup. To do this, teach the test harness
1134         (dump-datatransfer-types.html) to ignore inline styles in markup if a flag is set, and then set that flag in
1135         UIPasteboardTests.DataTransferGetDataWhenPastingPlatformRepresentations.
1136
1137         * TestWebKitAPI/Tests/WebKitCocoa/dump-datatransfer-types.html:
1138         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1139         (TestWebKitAPI::TEST):
1140
1141 2018-01-30  Sergio Villar Senin  <svillar@igalia.com>
1142
1143         [WebVR][GTK][WPE] Exclude OpenVR from tarballs
1144         https://bugs.webkit.org/show_bug.cgi?id=182284
1145
1146         Reviewed by Michael Catanzaro.
1147
1148         * gtk/manifest.txt.in: Added ThirdParty/openvr to exclusions.
1149         * wpe/manifest.txt.in: Ditto.
1150
1151 2018-01-30  Yusuke Suzuki  <utatane.tea@gmail.com>
1152
1153         Unreviewed, try to fix JSCOnly build
1154         https://bugs.webkit.org/show_bug.cgi?id=177202
1155
1156         * CMakeLists.txt:
1157
1158 2018-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1159
1160         Unreviewed. Try to avoid webdriver tests step timing out in the bots.
1161
1162         The process itself doesn't seem to be timing out, but the buildbot is always reporting the step as finished
1163         after timeout. I think there's a race condition or something in buildbot, and it keeps watching the json log
1164         file even when it has already been written. This is a speculative workaround, assuming that's the problem, that
1165         creates the json file before running the tests. I'll revert this if it doesn't fix the issue in the end.
1166
1167         * Scripts/run-webdriver-tests:
1168         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
1169         (WebDriverTestRunner.dump_results_to_json_file):
1170
1171 2018-01-30  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1172
1173         [WinCairo] Fix forwarding header conflict of WebKit on WinCairo
1174         https://bugs.webkit.org/show_bug.cgi?id=177202
1175
1176         Reviewed by Alex Christensen.
1177
1178         * CMakeLists.txt:
1179
1180 2018-01-29  Alex Christensen  <achristensen@webkit.org>
1181
1182         Clean up API after bugs 178240 and 176474
1183         https://bugs.webkit.org/show_bug.cgi?id=182259
1184
1185         Reviewed by Dan Bernstein.
1186
1187         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1188         (TEST):
1189         (-[PinnedStateObserver observeValueForKeyPath:ofObject:change:context:]):
1190
1191 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
1192
1193         [WebAuthN] Add a compile-time feature flag
1194         https://bugs.webkit.org/show_bug.cgi?id=182211
1195         <rdar://problem/36936365>
1196
1197         Reviewed by Brent Fulgham.
1198
1199         * Scripts/webkitperl/FeatureList.pm:
1200         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1201
1202 2018-01-29  Brady Eidson  <beidson@apple.com>
1203
1204         Make the API test added in r227737 be Mac-only.
1205
1206         Unreviewed gardening.
1207
1208         * TestWebKitAPI/Tests/WebKitCocoa/MessagePortProviders.mm:
1209
1210 2018-01-29  Matt Lewis  <jlewis3@apple.com>
1211
1212         Unreviewed, rolling out r227731.
1213
1214         This caused and assertion failure in API tests.
1215
1216         Reverted changeset:
1217
1218         "Layout Test fast/events/beforeunload-dom-manipulation-
1219         crash.html is crashing"
1220         https://bugs.webkit.org/show_bug.cgi?id=181204
1221         https://trac.webkit.org/changeset/227731
1222
1223 2018-01-29  Youenn Fablet  <youenn@apple.com>
1224
1225         WPT test exporter should add WebKit export in its PR description
1226         https://bugs.webkit.org/show_bug.cgi?id=182246
1227
1228         Reviewed by Chris Dumez.
1229
1230         Updating PR description body to contain the words 'WebKit export'.
1231         That way, WPT PR bot will mark the PR as reviewed downstream.
1232
1233         * Scripts/webkitpy/w3c/test_exporter.py:
1234         (TestExporter.__init__):
1235         (TestExporter.make_pull_request):
1236         * Scripts/webkitpy/w3c/test_exporter_unittest.py:
1237         (TestExporterTest.test_export):
1238
1239 2018-01-29  Ryosuke Niwa  <rniwa@webkit.org>
1240
1241         Add the support for running Speedometer 2.0 to run-benchmark
1242         https://bugs.webkit.org/show_bug.cgi?id=182231
1243
1244         Reviewed by Antti Koivisto.
1245
1246         Made it possible to run Speedometer 2.0 using run-benchmark. To do this, this patch adds the ability to
1247         aggregate results using the differently aggregated values of subtests. In particular, Speedometer 2.0
1248         requires aggregating the geometric mean out of total time spent in each suite.
1249
1250         Also added --show-iteration-values to show individual measured values in each iteration.
1251
1252         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
1253         (BenchmarkResults.format): Added show_iteration_values as an option.
1254         (BenchmarkResults._format_tests): Ditto.
1255         (BenchmarkResults._format_values): Ditto. Added the code to show the measured values for each iteration
1256         when show_iteration_values is set to True. We don't emit the unit in each value so that the list of values
1257         is easily parsable as a JSON array.
1258         (BenchmarkResults._format_values.format_scaled): Added. A helper function.
1259         (BenchmarkResults._subtest_values_by_config_iteration): Added the support for aggregating values using
1260         the aggregated values of a subtest even when they were computed using a different aggregator if the subtest
1261         had exactly one aggregator.
1262         (BenchmarkResults._lint_results):
1263         (BenchmarkResults._lint_subtest_results): Replaced parent_needing_aggregation, which is set to the parent
1264         test's name only when the parent test had an aggregator, by self-explanatory parent_test and
1265         parent_aggregator_list.
1266         (BenchmarkResults._lint_aggregator_list): Ditto. Added raise an exception when a test has an aggregator but
1267         its subtest doesn't specify the same aggregator or it has more than one aggregators, making it ambiguous.
1268         (BenchmarkResults._lint_configuration):
1269         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py:
1270         (test_format_values_with_no_unit_scaling): Added.
1271         (test_format_values_with_iteration_values): Added.
1272         (test_format_values_with_no_unit_scaling_and_iteration_values): Added.
1273         (test_aggregate_results_from_another_aggregator): Added.
1274         (test_lint_results): Added a test case.
1275         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1276         (BenchmarkRunner.__init__): Added show_iteration_values as an argument.
1277         (BenchmarkRunner._run_benchmark): Ditto.
1278         (BenchmarkRunner.show_results): Ditto.
1279         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer2.patch: Added.
1280         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer2.plan: Added.
1281         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1282         (parse_args): Added --show-iteration-values as a boolean argument.
1283         (run_benchmark_plan): Ditto.
1284         (start): Ditto.
1285         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
1286         (WebServerBenchmarkRunner.__init__): Ditto.
1287
1288 2018-01-29  Brady Eidson  <beidson@apple.com>
1289
1290         Make it possible for apps that use both WK1 and WK2 to use MessagePorts.
1291         https://bugs.webkit.org/show_bug.cgi?id=182229
1292
1293         Reviewed by Chris Dumez.
1294
1295         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1296         * TestWebKitAPI/Tests/WebKitCocoa/MessagePortProviders.mm: Added.
1297
1298 2018-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1299
1300         WebDriver: properly recover w3c tests after a webdriver server crash
1301         https://bugs.webkit.org/show_bug.cgi?id=182242
1302
1303         Reviewed by Carlos Alberto Lopez Perez.
1304
1305         When a test makes the webdriver server crash, all other subsequent tests fail because they still try to send
1306         messages to the server, gettin connection refused errors all the time. Selenium tests handle this correctly by
1307         relaunching the server after every test failure, because other failures, even when not crashing the server,
1308         might leave it in an bad state. WPT runner does the same for test files, it uses a subprocess to run the tests
1309         and when any subtest fails, a new subsprocess is used for the following test file. We could do the same.
1310
1311         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1312         (WebDriverTestRunnerW3C.run): Restart the executor if any subtest failed.
1313         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
1314         (WebDriverW3CExecutor.__init__): Save timeout and expectations and do not import pytest.
1315         (WebDriverW3CExecutor.setup): Create a subprocess to run the tests.
1316         (WebDriverW3CExecutor.teardown): Send a message to the subprocess to terminate.
1317         (WebDriverW3CExecutor._runner): Run the tests using pytest runner.
1318         (WebDriverW3CExecutor.run): Send a message to the subprocess to run the given test and return the results message.
1319
1320 2018-01-29  Per Arne Vollan  <pvollan@apple.com>
1321
1322         Layout Test fast/events/beforeunload-dom-manipulation-crash.html is crashing
1323         https://bugs.webkit.org/show_bug.cgi?id=181204
1324         <rdar://problem/36256274>
1325
1326         Reviewed by Ryosuke Niwa.
1327
1328         Implement 'testRunner.forceImmediateCompletion()' for WK1.
1329
1330         * DumpRenderTree/TestRunner.cpp:
1331         (forceImmediateCompletionCallback):
1332         (TestRunner::staticFunctions):
1333
1334 2018-01-29  Frederic Wang  <fwang@igalia.com>
1335
1336         Unreviewed, add myself to some watch lists.
1337
1338         * Scripts/webkitpy/common/config/watchlist:
1339
1340 2018-01-27  Dan Bernstein  <mitz@apple.com>
1341
1342         HaveInternalSDK includes should be "#include?"
1343         https://bugs.webkit.org/show_bug.cgi?id=179670
1344
1345         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1346
1347 2018-01-26  Chris Dumez  <cdumez@apple.com>
1348
1349         Make sure service worker code does not launch a StorageProcess unnecessarily
1350         https://bugs.webkit.org/show_bug.cgi?id=182192
1351         <rdar://problem/36927427>
1352
1353         Reviewed by Geoffrey Garen.
1354
1355         Add API test coverage.
1356
1357         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1358
1359 2018-01-26  Chris Dumez  <cdumez@apple.com>
1360
1361         Offlined content does not work for apps on home screen
1362         https://bugs.webkit.org/show_bug.cgi?id=182070
1363         <rdar://problem/36843906>
1364
1365         Reviewed by Youenn Fablet.
1366
1367         Add API test coverage to make sure an already registered service worker is able to intercept
1368         the very first load.
1369
1370         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1371         (-[SWMessageHandlerWithExpectedMessage userContentController:didReceiveScriptMessage:]):
1372
1373 2018-01-26  Chris Nardi  <cnardi@chromium.org>
1374
1375         Addressing post-review comments after r226614
1376         https://bugs.webkit.org/show_bug.cgi?id=182151
1377
1378         Reviewed by Myles C. Maxfield.
1379
1380         * TestWebKitAPI/Tests/WTF/TextBreakIterator.cpp:
1381         (TestWebKitAPI::TEST):
1382
1383 2018-01-25  Per Arne Vollan  <pvollan@apple.com>
1384
1385         Unreviewed, rolling out r224920.
1386
1387         Some Win EWS bots are not coming back up after starting reboot.
1388
1389         * EWSTools/start-queue-win.sh:
1390
1391 2018-01-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1392
1393         WebDriver: simplify the tests json report
1394         https://bugs.webkit.org/show_bug.cgi?id=182171
1395
1396         Reviewed by Carlos Alberto Lopez Perez.
1397
1398         We are duplicating the test name in every subtest name. WPT already changed the format to remove the test name
1399         form the subtest name. We should do the same for simplicity and compatibility with WPT.
1400
1401         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
1402         (WebDriverTestRunner.dump_results_to_json_file):
1403
1404 2018-01-25  Alex Christensen  <achristensen@webkit.org>
1405
1406         REGRESSION (r221899): Web Content process hangs when webpage tries to make a new window if the WKWebView doesn’t have a UI delegate
1407         https://bugs.webkit.org/show_bug.cgi?id=182152
1408
1409         Reviewed by Joseph Pecoraro.
1410
1411         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1412         (-[NoUIDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1413         (TEST):
1414
1415 2018-01-25  Youenn Fablet  <youenn@apple.com>
1416
1417         WebPluginInfoProvider should handle null host queries
1418         https://bugs.webkit.org/show_bug.cgi?id=182112
1419
1420         Reviewed by Chris Dumez.
1421
1422         * TestWebKitAPI/Tests/WebKitCocoa/PluginLoadClientPolicies.mm:
1423         (TEST):
1424
1425 2018-01-25  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1426
1427         [webkitpy] Stop modifying path information only when running on Cygwin
1428         https://bugs.webkit.org/show_bug.cgi?id=182136
1429
1430         On LayoutTestApacheHttpd, some path configuration is modified when platform
1431         is Windows. This modification is only required for AppleWin running on Cygwin.
1432         WinCairo uses native Windows environment, so the condition should be changed.
1433
1434         Reviewed by Per Arne Vollan.
1435
1436         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1437         (LayoutTestApacheHttpd.__init__):
1438         (LayoutTestApacheHttpd._get_apache_config_file_path):
1439
1440 2018-01-25  Eric Carlson  <eric.carlson@apple.com>
1441
1442         REGRESSION(r227457): Release assert in updateLayout while destructing a media element
1443         https://bugs.webkit.org/show_bug.cgi?id=182038
1444         <rdar://problem/36812083>
1445
1446         Reviewed by Jer Noble.
1447
1448         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
1449         (TestWebKitAPI::TEST): Show/hide page so controls are always updated.
1450
1451 2018-01-24  Daniel Bates  <dabates@apple.com>
1452
1453         webkit-patch upload emits irrelevant simulator warnings
1454         https://bugs.webkit.org/show_bug.cgi?id=181702
1455         <rdar://problem/36556359>
1456
1457         Reviewed by Aakash Jain.
1458
1459         Remove warning when a person explicitly passes --child-processes with a value greater than
1460         the default number of simulator instances webkitpy would have used had --child-processes
1461         been omitted. Moreover, the placement of the warning logic to support printing such a message
1462         (in the IOSSimulatorPort constructor) caused side effects that may print other warning messages.
1463
1464         By default, webkitpy will parallelize running tests using the maximum number of simulator
1465         instances that can be supported based on available system resources at the time run-webkit-tests
1466         is invoked. It seems reasonable to assume that a person that explicitly overrides this default
1467         by specifying --child-processes knows what they are doing. The effects of picking a large
1468         value be obvious, the system may become sluggish.
1469
1470         As a side benefit of this change we no longer will emit simulator warnings whenever the iOS
1471         simulator port is instantiated by non-layout test related code (e.g. check-webkit-style).
1472
1473         * Scripts/webkitpy/port/ios_simulator.py:
1474         (IOSSimulatorPort.__init__):
1475
1476 2018-01-25  Sergio Villar Senin  <svillar@igalia.com>
1477
1478         [WebVR][GTK][WPE] Remove the WebVR public API added in r227518
1479         https://bugs.webkit.org/show_bug.cgi?id=182102
1480
1481         Reviewed by Carlos Garcia Campos.
1482
1483         * MiniBrowser/gtk/main.c:
1484         (main): Removed the call to set_enable_webvr().
1485
1486 2018-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1487
1488         WebDriver: add support for slow tests
1489         https://bugs.webkit.org/show_bug.cgi?id=182095
1490
1491         Reviewed by Carlos Alberto Lopez Perez.
1492
1493         Add timeout mark to slow tests.
1494
1495         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1496         (TestExpectationsMarker.__init__): Save the timeout.
1497         (TestExpectationsMarker.pytest_collection_modifyitems): If test is slow use timeout * 5.
1498         (run): Pass timeout to TestExpectationsMarker constructor.
1499
1500 2018-01-24  Alex Christensen  <achristensen@webkit.org>
1501
1502         Gracefully recover from NetworkProcess crashes in private browsing
1503         https://bugs.webkit.org/show_bug.cgi?id=182073
1504         <rdar://problem/36572023>
1505
1506         Reviewed by Geoff Garen.
1507
1508         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1509         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcessCrashNonPersistentDataStore.mm: Added.
1510         (-[CrashDelegate webView:didFinishNavigation:]):
1511         (-[CrashDelegate webView:didFailProvisionalNavigation:withError:]):
1512         (-[CrashDelegate webView:didFailNavigation:withError:]):
1513         (TEST):
1514
1515 2018-01-24  Ali Juma  <ajuma@chromium.org>
1516
1517         REGRESSION (r227430): ASSERTION FAILED: !self.zoomToScaleCompletionHandler in TestRunnerWKWebView::zoomToScale
1518         https://bugs.webkit.org/show_bug.cgi?id=182052
1519
1520         Reviewed by Simon Fraser.
1521
1522         Don't set zoomToScaleCompletionHandler in zoomToScale:animated when calling the completion handler
1523         immediately.
1524
1525         Test: fast/visual-viewport/viewport-dimensions.html
1526
1527         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1528         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
1529
1530 2018-01-24  Alex Christensen  <achristensen@webkit.org>
1531
1532         Remove pre-Sierra-OS-specific code in Tools
1533         https://bugs.webkit.org/show_bug.cgi?id=182034
1534
1535         Reviewed by Tim Horton.
1536
1537         * DumpRenderTree/mac/DumpRenderTree.mm:
1538         (setDefaultsToConsistentValuesForTesting):
1539         * MiniBrowser/mac/BrowserWindowController.m:
1540         (-[BrowserWindowController windowDidLoad]):
1541         (-[BrowserWindowController share:]):
1542         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
1543         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:
1544         (-[EventStreamPlayer playbackTimerFired:]):
1545         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1546         * TestWebKitAPI/Tests/WebCore/FontCache.cpp: Removed.
1547         * TestWebKitAPI/Tests/WebKitCocoa/RunOpenPanel.mm:
1548         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1549         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
1550         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1551         (WTR::InjectedBundle::platformInitialize):
1552         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1553         (WTR::initializeWebViewConfiguration):
1554
1555 2018-01-24  Alexey Proskuryakov  <ap@apple.com>
1556
1557         REGRESSION (r226485): Many new wasm leaks detected by the leaks bot
1558         https://bugs.webkit.org/show_bug.cgi?id=181400
1559         <rdar://problem/36358768>
1560
1561         Reviewed by Joseph Pecoraro.
1562
1563         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove incorrect option.
1564
1565         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (_set_up_derived_options):
1566         Always disable poisoning when running with --leaks, as this should work locally,
1567         not just on bots.
1568
1569 2018-01-24  Daniel Bates  <dabates@apple.com>
1570
1571         REGRESSION (r226138): Selecting a line that ends with zero-width joiner (ZWJ) may cause text transformation
1572         https://bugs.webkit.org/show_bug.cgi?id=181993
1573         <rdar://problem/36421080>
1574
1575         Reviewed by David Hyatt.
1576
1577         Remove unit test for overlap strategy FrontmostWithLongestEffectiveRange
1578         as we no longer support this strategy.
1579
1580         * TestWebKitAPI/Tests/WebCore/MarkerSubrange.cpp:
1581
1582 2018-01-24  David Kilzer  <ddkilzer@apple.com>
1583
1584         check-webkit-style reports false-positive whitespace/braces warning about blocks with return types as arguments in Objective-C
1585         <https://webkit.org/b/182015>
1586         <rdar://problem/36449728>
1587
1588         Reviewed by Tim Horton.
1589
1590         * Scripts/webkitpy/style/checkers/cpp.py:
1591         (regex_for_lambdas_and_blocks): Update regex to include
1592         optional return type for block argument in Objective-C.
1593         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1594         (WebKitStyleTest.test_braces): Add test.
1595
1596 2018-01-24  Ms2ger  <Ms2ger@igalia.com>
1597
1598         WPE-focused test gardening.
1599         https://bugs.webkit.org/show_bug.cgi?id=182051
1600
1601         Unreviewed test gardening.
1602
1603         * TestWebKitAPI/glib/TestExpectations.json: TestWebKitFindController failure was fixed in r227418.
1604
1605 2018-01-23  Mark Lam  <mark.lam@apple.com>
1606
1607         Update Poisoned pointers to take a Poison class instead of a uintptr_t&.
1608         https://bugs.webkit.org/show_bug.cgi?id=182017
1609         <rdar://problem/36795513>
1610
1611         Reviewed by Filip Pizlo and JF Bastien.
1612
1613         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
1614         (TestWebKitAPI::TEST):
1615         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
1616         (TestWebKitAPI::TEST):
1617         (TestWebKitAPI::passWithRef):
1618         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
1619         (TestWebKitAPI::TEST):
1620         (TestWebKitAPI::f1):
1621         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
1622         (TestWebKitAPI::TEST):
1623         (TestWebKitAPI::poisonedPtrFoo):
1624         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
1625         (TestWebKitAPI::TEST):
1626         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
1627         (TestWebKitAPI::TEST):
1628
1629 2018-01-18  Sergio Villar Senin  <svillar@igalia.com>
1630
1631         [WebVR] Add OpenVR to the tree and to the build
1632         https://bugs.webkit.org/show_bug.cgi?id=177298
1633
1634         Reviewed by Žan Doberšek.
1635
1636         * Scripts/webkitpy/style/checker.py: Added openvr to the list of third party libraries
1637         with reduced style checks.
1638
1639 2018-01-24  Chris Nardi  <cnardi@chromium.org>
1640
1641         Add Chris Nardi to contributors list
1642         https://bugs.webkit.org/show_bug.cgi?id=182029
1643
1644         Reviewed by Antti Koivisto.
1645
1646         * Scripts/webkitpy/common/config/contributors.json:
1647
1648 2018-01-22  Ryosuke Niwa  <rniwa@webkit.org>
1649
1650         Mac Sierra perf bots have been failing due to CG errors
1651         https://bugs.webkit.org/show_bug.cgi?id=181955
1652
1653         Reviewed by Antti Koivisto.
1654
1655         Ignore the CoreGraphics error messages on macOS Sierra.
1656
1657         Also added tests for ignoring lines in stdout and stderr.
1658
1659         * Scripts/webkitpy/performance_tests/perftest.py:
1660         (PerfTest.run_failed): Refactored for clarity.
1661         (PerfTest):
1662         (PerfTest.filter_ignored_lines): Added.
1663         (PerfTest._lines_to_ignore): Renamed from _lines_to_ignore_in_parser_result since these regular expressions
1664         are now used to ignore lines in other kinds of tests than parser tests.
1665         (PerfTest._errors_to_ignore_in_sierra): Added.
1666         (PerfTest._filter_output): Added the code to ignore errors only on macOS Sierra.
1667         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1668         (test_parse_output_with_ignored_stdout): Added.
1669         (test_parse_output_with_ignored_stderr): Added.
1670         (test_parse_output_with_ignored_stderr.MockPortWithSierraName): Added.
1671
1672 2018-01-23  Eric Carlson  <eric.carlson@apple.com>
1673
1674         Resign NowPlaying status when no media element is eligible
1675         https://bugs.webkit.org/show_bug.cgi?id=181914
1676         <rdar://problem/35294116>
1677
1678         Reviewed by Jer Noble.
1679
1680         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
1681         (-[NowPlayingTestWebView hasActiveNowPlayingSession]):
1682         (TestWebKitAPI::TEST):
1683         * TestWebKitAPI/Tests/WebKitCocoa/large-video-test-now-playing.html:
1684
1685 2018-01-23  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1686
1687         [WinCairo] Use 64-bit toolset
1688         https://bugs.webkit.org/show_bug.cgi?id=181979
1689
1690         Reviewed by Alex Christensen.
1691
1692         Use 64-bit toolset for 64-bit build in order to improve build time. 
1693
1694         * Scripts/webkitdirs.pm:
1695         (generateBuildSystemFromCMakeProject):
1696
1697 2018-01-23  Simon Fraser  <simon.fraser@apple.com>
1698
1699         Element with position:fixed stops scrolling at the bottom of the page, but is painted in the right place on Chacos.com.
1700         https://bugs.webkit.org/show_bug.cgi?id=181741
1701         rdar://problem/36593581
1702
1703         Reviewed by Tim Horton.
1704         
1705         If zoomToScale:animated: is called with the current zoom level, call the callback
1706         rather than doing nothing.
1707
1708         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1709         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
1710
1711 2018-01-23  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1712
1713         Add ignore_errors keyword argument to Executive.run_command() for replacing the common pattern of error_handler usage
1714         https://bugs.webkit.org/show_bug.cgi?id=180820
1715
1716         Reviewed by David Kilzer.
1717
1718         * Scripts/webkitpy/common/checkout/scm/git.py:
1719         (Git.in_working_directory):
1720         (Git.clone):
1721         (Git.read_git_config):
1722         (Git.apply_reverse_diff):
1723         * Scripts/webkitpy/common/checkout/scm/scm.py:
1724         (SCM.run):
1725         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1726         * Scripts/webkitpy/common/checkout/scm/svn.py:
1727         (SVNRepository.has_authorization_for_realm):
1728         * Scripts/webkitpy/common/net/credentials_unittest.py:
1729         * Scripts/webkitpy/common/system/abstractexecutive.py:
1730         (AbstractExecutive.run_command):
1731         * Scripts/webkitpy/common/system/executive.py:
1732         (Executive.kill_process.is):
1733         (Executive.running_pids):
1734         (Executive.kill_all):
1735         (Executive.run_command):
1736         * Scripts/webkitpy/common/system/executive_mock.py:
1737         (MockExecutive.run_command):
1738         (MockExecutive2.run_command):
1739         * Scripts/webkitpy/common/system/executive_unittest.py:
1740         (ExecutiveTest.test_run_command_with_bad_command.run_bad_command):
1741         * Scripts/webkitpy/common/system/platforminfo.py:
1742         (PlatformInfo.xcode_sdk_version):
1743         * Scripts/webkitpy/layout_tests/servers/http_server.py:
1744         (Lighttpd._check_and_kill):
1745         * Scripts/webkitpy/port/base.py:
1746         (Port._symbols_string):
1747         * Scripts/webkitpy/port/gtk.py:
1748         (GtkPort.setup_environ_for_server):
1749         * Scripts/webkitpy/port/win.py:
1750         (WinPort._runtime_feature_list):
1751         (WinPort.read_registry_value):
1752         * Scripts/webkitpy/port/win_unittest.py:
1753         (WinPortTest.test_runtime_feature_list):
1754         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
1755         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py:
1756
1757 2018-01-23  Commit Queue  <commit-queue@webkit.org>
1758
1759         Unreviewed, rolling out r227279 and r227373.
1760         https://bugs.webkit.org/show_bug.cgi?id=181988
1761
1762         The LayoutTest crash fix introduced an API test failure.
1763         (Requested by ryanhaddad on #webkit).
1764
1765         Reverted changesets:
1766
1767         "Resign NowPlaying status when no media element is eligible"
1768         https://bugs.webkit.org/show_bug.cgi?id=181914
1769         https://trac.webkit.org/changeset/227279
1770
1771         "Resign NowPlaying status when no media element is eligible"
1772         https://bugs.webkit.org/show_bug.cgi?id=181914
1773         https://trac.webkit.org/changeset/227373
1774
1775 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1776
1777         Unreviewed. Add test case for slow in test_expectations.py.
1778
1779         I forgot to also check slow tests in test_expectations.py unit tests.
1780
1781         * Scripts/webkitpy/common/test_expectations_unittest.py:
1782         (assert_slow):
1783         (test_build_type):
1784         (test_slow):
1785
1786 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1787
1788         Unreviewed. Mark test WTF_Lock.ManyContendedShortSections as slow.
1789
1790         * TestWebKitAPI/glib/TestExpectations.json:
1791
1792 2018-01-22  Ryosuke Niwa  <rniwa@webkit.org>
1793
1794         Blob conversion and sanitization doesn't work with Microsoft Word for Mac 2011
1795         https://bugs.webkit.org/show_bug.cgi?id=181616
1796         <rdar://problem/36484908>
1797
1798         Reviewed by Wenson Hsieh.
1799
1800         Added tests to make sure we sanitize plain HTML, not just web archives,
1801         when and only when custom pasteboard data is enabled.
1802
1803         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1804         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm: Added.
1805         (writeHTMLToPasteboard): Added.
1806         (createWebViewWithCustomPasteboardDataSetting): Added.
1807
1808 2018-01-22  Alexey Proskuryakov  <ap@apple.com>
1809
1810         REGRESSION (r226485): Many new wasm leaks detected by the leaks bot
1811         https://bugs.webkit.org/show_bug.cgi?id=181400
1812         rdar://problem/36358768
1813
1814         Reviewed by JF Bastien.
1815
1816         * BuildSlaveSupport/build.webkit.org-config/config.json: Disable poisoning on the leaks bot.
1817
1818 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1819
1820         [GTK] Test /webkit/WebKitWebsiteData/resource-load-statistics is failing since r227223
1821         https://bugs.webkit.org/show_bug.cgi?id=181929
1822
1823         Reviewed by Michael Catanzaro.
1824
1825         The test is checking that the resource load stats file is deleted after clearing website data. Since r227223,
1826         the website data completion callback is not called immediately, and a new file is created when the operation
1827         finishes. We need to check that the file was removing after calling clear.
1828
1829         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
1830         (fileChangedCallback):
1831         (testWebsiteDataResourceLoadStatistics):
1832
1833 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1834
1835         Reviewed GTK gardening. Mark /webkit/WebKitWebView/mouse-target as fail too.
1836
1837         * TestWebKitAPI/glib/TestExpectations.json:
1838
1839 2018-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1840
1841         Unreviewed GTK+ gardening. Fix /webkit/WebKitConsoleMessage/network-error.
1842
1843         Partially revert r226782, the fix was wrong for the GLib version we currently use.
1844
1845         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
1846         (testWebKitConsoleMessageNetworkError):
1847
1848 2018-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1849
1850         Unreviewed. Remove unused verbose mode from GLib API tests runner.
1851
1852         * glib/api_test_runner.py:
1853         (add_options):
1854
1855 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1856
1857         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
1858         https://bugs.webkit.org/show_bug.cgi?id=181918
1859
1860         Reviewed by Tim Horton.
1861
1862         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
1863
1864         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1865
1866 2018-01-21  Eric Carlson  <eric.carlson@apple.com>
1867
1868         Resign NowPlaying status when no media element is eligible
1869         https://bugs.webkit.org/show_bug.cgi?id=181914
1870         <rdar://problem/35294116>
1871
1872         Reviewed by Jer Noble.
1873
1874         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
1875         (-[NowPlayingTestWebView hasActiveNowPlayingSession]):
1876         (TestWebKitAPI::TEST):
1877         * TestWebKitAPI/Tests/WebKitCocoa/large-video-test-now-playing.html:
1878
1879 2018-01-21  Aakash Jain  <aakash_jain@apple.com>
1880
1881         Fix broken unit-tests after r227192
1882         https://bugs.webkit.org/show_bug.cgi?id=181909
1883
1884         Reviewed by Carlos Garcia Campos.
1885
1886         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1887
1888 2018-01-20  Chris Dumez  <cdumez@apple.com>
1889
1890         API test URLSchemeHandler.Leaks1 is timing out on iOS simulator debug
1891         https://bugs.webkit.org/show_bug.cgi?id=174984
1892         <rdar://problem/33665676>
1893
1894         Reviewed by Alexey Proskuryakov.
1895
1896         Disable URLSchemeHandler.Leaks1 API test on iOS as it sometimes times out.
1897
1898         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-leaks.mm:
1899         (TEST):
1900
1901 2018-01-20  Brian Burg  <bburg@apple.com>
1902
1903         WebDriver: fix some nits that prevent running W3C tests on Mac
1904         https://bugs.webkit.org/show_bug.cgi?id=181864
1905
1906         Reviewed by Carlos Garcia Campos.
1907
1908         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
1909         (WebDriverW3CWebServer.__init__): _wsout needs to always be defined,
1910         as we assume that the property exists later.
1911
1912         (WebDriverW3CWebServer.stop): If the temporary file doesn't
1913         exist for some reason, the remove call will raise and exception.
1914         Gracefully handle the case where the file isn't created due to
1915         a problem/exception that happened elsewhere.
1916
1917 2018-01-19  Ling Ho  <lingcherd_ho@apple.com>
1918
1919         Move Bingdings EWS and Webkitpy EWS queues to High Sierra on buildbot dashboard.
1920         https://bugs.webkit.org/show_bug.cgi?id=181881
1921
1922         Reviewed by Alexey Proskuryakov.
1923
1924         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1925         (BubbleQueueServer):
1926         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1927         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1928         (table.queue-grid tr.platform.mac-os-x-elcapitan img.logo): Deleted.
1929
1930 2018-01-19  Youenn Fablet  <youenn@apple.com>
1931
1932         Do not go to the storage process when registering a service worker client if there is no service worker registered
1933         https://bugs.webkit.org/show_bug.cgi?id=181740
1934         <rdar://problem/36650400>
1935
1936         Reviewed by Chris Dumez.
1937
1938         Add support for internals inside API tests.
1939
1940         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1941         * TestWebKitAPI/Tests/InjectInternals_Bundle.cpp: Added.
1942         (TestWebKitAPI::InternalsInjectedBundleTest::InternalsInjectedBundleTest):
1943         (TestWebKitAPI::InternalsInjectedBundleTest::initialize):
1944         (TestWebKitAPI::InternalsInjectedBundleTest::didCreatePage):
1945         (TestWebKitAPI::InternalsInjectedBundleTest::didClearWindowForFrame):
1946         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1947         (setConfigurationInjectedBundlePath):
1948         (-[RegularPageMessageHandler userContentController:didReceiveScriptMessage:]):
1949
1950 2018-01-19  John Wilander  <wilander@apple.com>
1951
1952         Resource Load Statistics: Implement callback support for removal of WebsiteDataType::ResourceLoadStatistics
1953         https://bugs.webkit.org/show_bug.cgi?id=181822
1954         https://bugs.webkit.org/show_bug.cgi?id=175263
1955         https://bugs.webkit.org/show_bug.cgi?id=178536
1956         https://bugs.webkit.org/show_bug.cgi?id=181223
1957         https://bugs.webkit.org/show_bug.cgi?id=181482
1958         <rdar://problem/33491222>
1959         <rdar://problem/33805293>
1960         <rdar://problem/36332683>
1961         <rdar://problem/36549026>
1962
1963         Reviewed by Alex Christensen.
1964
1965         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1966         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1967         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
1968         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1969         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1970         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1971         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
1972         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1973
1974 2018-01-19  Jonathan Bedard  <jbedard@apple.com>
1975
1976         run-webkit-tests fails when there is a curly brace in Xcode build output
1977         https://bugs.webkit.org/show_bug.cgi?id=181254
1978         <rdar://problem/36453374>
1979
1980         Reviewed by Daniel Bates.
1981
1982         * Scripts/webkitpy/port/base.py:
1983         (Port._run_script): Encode script output before logging it.
1984
1985 2018-01-19  Chris Dumez  <cdumez@apple.com>
1986
1987         Service worker registrations restored from disk may not be reused when the JS calls register() again
1988         https://bugs.webkit.org/show_bug.cgi?id=181810
1989         <rdar://problem/36591711>
1990
1991         Reviewed by Youenn Fablet.
1992
1993         Add API test coverage.
1994
1995         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1996         (-[SWMessageHandlerForRestoreFromDiskTest initWithExpectedMessage:]):
1997         (-[SWMessageHandlerForRestoreFromDiskTest userContentController:didReceiveScriptMessage:]):
1998
1999 2018-01-19  Ryan Haddad  <ryanhaddad@apple.com>
2000
2001         Remove El Capitan queues from flakiness dashboard
2002         https://bugs.webkit.org/show_bug.cgi?id=181860
2003
2004         Reviewed by Aakash Jain.
2005
2006         * TestResultServer/static-dashboards/builders.jsonp:
2007
2008 2018-01-19  Keith Miller  <keith_miller@apple.com>
2009
2010         HaveInternalSDK includes should be "#include?"
2011         https://bugs.webkit.org/show_bug.cgi?id=179670
2012
2013         Reviewed by Dan Bernstein.
2014
2015         * MiniBrowser/Configurations/Base.xcconfig:
2016         * MobileMiniBrowser/Configurations/Base.xcconfig:
2017         * TestWebKitAPI/Configurations/Base.xcconfig:
2018         * WebKitTestRunner/Configurations/Base.xcconfig:
2019
2020 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2021
2022         WebDriver: driver environment not passed to pytest when running w3c tests
2023         https://bugs.webkit.org/show_bug.cgi?id=181852
2024
2025         Reviewed by Carlos Alberto Lopez Perez.
2026
2027         That's why color codes are not used in the bots log for selenium tests but they appear in w3c tests.
2028
2029         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
2030         (WebDriverW3CExecutor.run):
2031
2032 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2033
2034         [GTK] WebDriver: wayland display no used in wayland bot
2035         https://bugs.webkit.org/show_bug.cgi?id=181851
2036
2037         Reviewed by Carlos Alberto Lopez Perez.
2038
2039         We need to handle the additionalArguments property in the WebDriverTests step.
2040
2041         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2042         (RunWebDriverTests.start):
2043
2044 2018-01-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2045
2046         [GTK] TERM environment variable is not passed to the test driver.
2047         https://bugs.webkit.org/show_bug.cgi?id=181847
2048
2049         Rubber-stamped by by Carlos Garcia Campos.
2050
2051         * Scripts/webkitpy/port/base.py:
2052         (Port.to.setup_environ_for_server):
2053
2054 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2055
2056         WebDriver: run-webdriver-tests is crashing in the bots when creating results json file
2057         https://bugs.webkit.org/show_bug.cgi?id=181844
2058
2059         Reviewed by Carlos Alberto Lopez Perez.
2060
2061         We always try to create the directory where to store the json file, but when the filename is given directly,
2062         like in the bots, the current dir is used.
2063
2064         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
2065         (WebDriverTestRunner.dump_results_to_json_file): Do not try to create the directory if dirname() returns an
2066         empty string.
2067
2068 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2069
2070         [GTK] WebDriver tests are running outside the jhbuild env
2071         https://bugs.webkit.org/show_bug.cgi?id=181842
2072
2073         Reviewed by Žan Doberšek.
2074
2075         We need to enter jhbuild env in run-webdriver-tests.
2076
2077         * Scripts/run-webdriver-tests:
2078
2079 2018-01-18  Carlos Garcia Campos  <cgarcia@igalia.com>
2080
2081         [GTK] Run WebDriver tests in the bots
2082         https://bugs.webkit.org/show_bug.cgi?id=181787
2083
2084         Reviewed by Michael Catanzaro.
2085
2086         Add a step to run WebDriver tests in the GTK test bots. The new step is not GTK specific, but only added to the
2087         factory for the GTK port for now.
2088
2089         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2090         (TestFactory.__init__):
2091         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2092         (RunWebDriverTests):
2093         (RunWebDriverTests.start):
2094         (RunWebDriverTests.commandComplete):
2095         (RunWebDriverTests.evaluateCommand):
2096         (RunWebDriverTests.getText):
2097         (RunWebDriverTests.getText2):
2098
2099 2018-01-18  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2100
2101         [WinCairo] Pass correct url for http test to test driver.
2102         https://bugs.webkit.org/show_bug.cgi?id=181814
2103
2104         Reviewed by Alex Christensen.
2105
2106         * Scripts/webkitpy/port/driver.py:
2107         (Driver):
2108         (Driver.http_test_path_to_uri):
2109         (Driver.is_secure_path):
2110         (Driver.http_base_url):
2111         (Driver.uri_to_test):
2112
2113 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
2114
2115         Unreviewed, update the triggerable name for 'sierra-release-perf-tests'
2116
2117         * BuildSlaveSupport/build.webkit.org-config/config.json:
2118
2119 2018-01-18  Dan Bernstein  <mitz@apple.com>
2120
2121         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
2122         https://bugs.webkit.org/show_bug.cgi?id=181803
2123
2124         Reviewed by Tim Horton.
2125
2126         * DumpRenderTree/mac/Configurations/Base.xcconfig: Updated.
2127         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Ditto.
2128         * ImageDiff/cg/Configurations/Base.xcconfig: Ditto.
2129         * ImageDiff/cg/Configurations/DebugRelease.xcconfig: Ditto.
2130         * MiniBrowser/Configurations/Base.xcconfig: Ditto.
2131         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
2132         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
2133         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
2134         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals
2135           helpers.
2136         * TestWebKitAPI/Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build
2137           settings useful for defining settings that depend on the target macOS version.
2138         * WebKitTestRunner/Configurations/Base.xcconfig: Updated.
2139         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Updated.
2140
2141 2018-01-18  Ling Ho  <lingcherd_ho@apple.com>
2142
2143         Remove Opensource El Capitan queues from buildbot
2144         https://bugs.webkit.org/show_bug.cgi?id=181712
2145
2146         Reviewed by Aakash Jain.
2147
2148         * BuildSlaveSupport/build.webkit.org-config/config.json:
2149         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2150         (WebKitBuildbot):
2151         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2152
2153 2018-01-18  Chris Dumez  <cdumez@apple.com>
2154
2155         Service Workers restored from persistent storage have 'redundant' state
2156         https://bugs.webkit.org/show_bug.cgi?id=181749
2157         <rdar://problem/36556486>
2158
2159         Reviewed by Youenn Fablet.
2160
2161         Add API test coverage.
2162
2163         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2164         (-[SWMessageHandlerForFetchTest userContentController:didReceiveScriptMessage:]):
2165
2166 2018-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
2167
2168         [GTK] AX: Two layout tests crash with error 'g_strstr_len: assertion 'haystack != NULL' failed' in Accessibility::UIElement::url
2169         https://bugs.webkit.org/show_bug.cgi?id=176796
2170
2171         Reviewed by Chris Fleizach.
2172
2173         Add sanity check that we have a URL before calling g_strstr_len().
2174
2175         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2176         (WTR::AccessibilityUIElement::url):
2177
2178 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
2179
2180         Add triggers for Sierra test262 and perf queues
2181         https://bugs.webkit.org/show_bug.cgi?id=181799
2182
2183         Reviewed by Aakash Jain.
2184
2185         * BuildSlaveSupport/build.webkit.org-config/config.json:
2186
2187 2018-01-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2188
2189         [iOS] Specify -[NSURL _title] for the associated URL when copying an image element
2190         https://bugs.webkit.org/show_bug.cgi?id=181783
2191         <rdar://problem/35785445>
2192
2193         Reviewed by Ryosuke Niwa.
2194
2195         Augments an existing API test and adds a new test to make sure that the resulting NSItemProvider's NSURL when
2196         copying an image contains a relevant title.
2197
2198         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2199         (TestWebKitAPI::TEST):
2200         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2201         * TestWebKitAPI/ios/UIKitSPI.h:
2202
2203 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2204
2205         WebDriver: ignore the driver in selenium test names when getting expectations
2206         https://bugs.webkit.org/show_bug.cgi?id=181738
2207
2208         Reviewed by Carlos Alberto Lopez Perez.
2209
2210         In selenium tests, the driver is added as a parameter to every test which results in tests names like
2211         foo[DriverName] or foo[DriverName-param2] in case of tests using more parameters. We don't want to include the
2212         driver name in the test expectations file, so we need to remove it when querying the expectations.
2213
2214         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
2215         (TestExpectationsMarker.__init__): Save the param to ignore.
2216         (TestExpectationsMarker._item_name): Return the name of the test without the para to ignore.
2217         (TestExpectationsMarker.pytest_collection_modifyitems): Use _item_name().
2218         (run): Pass param to ignore to TestExpectationsMarker().
2219         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
2220         (WebDriverSeleniumExecutor.__init__): Save the driver name.
2221         (WebDriverSeleniumExecutor.run): Pass the driver name as param to ignore.
2222
2223 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2224
2225         [GTK][WPE] Show unit tests unexpectedly passing in the bots
2226         https://bugs.webkit.org/show_bug.cgi?id=181726
2227
2228         Reviewed by Michael Catanzaro.
2229
2230         Now that we have the info, let's show it also in the bots.
2231
2232         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2233         (RunGLibAPITests.commandComplete):
2234
2235 2018-01-17  Ling Ho  <lingcherd_ho@apple.com>
2236
2237         Fix broken unittest after r227048
2238         https://bugs.webkit.org/show_bug.cgi?id=181760
2239
2240         Reviewed by Aakash Jain.
2241
2242
2243 2018-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
2244
2245         WEBKIT_FRAMEWORK should not modify file-global include directories
2246         https://bugs.webkit.org/show_bug.cgi?id=181656
2247
2248         Reviewed by Konstantin Tokarev.
2249
2250         * TestWebKitAPI/PlatformWPE.cmake:
2251         * TestWebKitAPI/glib/CMakeLists.txt:
2252
2253 2018-01-17  Alicia Boya García  <aboya@igalia.com>
2254
2255         Unreviewed, mark Alicia as committer in contributors.json
2256
2257         * Scripts/webkitpy/common/config/contributors.json:
2258
2259 2018-01-17  Youenn Fablet  <youenn@apple.com>
2260
2261         Put fetch Request.keepalive behind a runtime flag
2262         https://bugs.webkit.org/show_bug.cgi?id=181592
2263
2264         Reviewed by Chris Dumez.
2265
2266         * DumpRenderTree/mac/DumpRenderTree.mm:
2267         (enableExperimentalFeatures):
2268         * DumpRenderTree/win/DumpRenderTree.cpp:
2269         (enableExperimentalFeatures):
2270         * WebKitTestRunner/TestController.cpp:
2271         (WTR::TestController::resetPreferencesToConsistentValues):
2272
2273 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2274
2275         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
2276         https://bugs.webkit.org/show_bug.cgi?id=181637
2277         <rdar://problem/36508471>
2278
2279         Reviewed by Tim Horton.
2280
2281         Add 2 new API tests to exercise injected bundle SPI for supplying replacement URLs when pasting an image, and an
2282         attributed string containing multiple NSTextAttachments. See WebKit and WebCore ChangeLogs for more detail.
2283
2284         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
2285         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2286         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]):
2287
2288         Implement the new Objective-C bundle SPI to look up the incoming MIME type in the dictionary supplied via the
2289         "MIMETypeToReplacementURLMap" bundle initialization parameter, and return it.
2290
2291         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2292         (webViewForTestingAttachments):
2293         (-[TestWKWebView tagsInBody]):
2294         (-[TestWKWebView expectElementTagsInOrder:]):
2295         (-[TestWKWebView expectElementTag:toComeBefore:]):
2296
2297         Add a test helper to check that the given list of element tags appears in the document body. Also, reimplement
2298         the existing -expectElementTag:toComeBefore: as a special case of -expectElementTagsInOrder:.
2299
2300         (TestWebKitAPI::TEST):
2301         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2302         (WTR::InjectedBundlePage::InjectedBundlePage):
2303
2304 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2305
2306         WebDriver: add support for test expectations
2307         https://bugs.webkit.org/show_bug.cgi?id=180420
2308
2309         Reviewed by Carlos Alberto Lopez Perez.
2310
2311         Add support for parsing test expectations from a JSON file and mark tests on collection accordingly.
2312
2313         * Scripts/run-webdriver-tests: Get the retval from process_results().
2314         * Scripts/webkitpy/thirdparty/__init__.py:
2315         (AutoinstallImportHook._install_pytest): Install also py because pytest needs it.
2316         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
2317         (TestExpectationsMarker): Plugin to mark tests based on given expectations.
2318         (TestExpectationsMarker.__init__): Initialize expectations.
2319         (TestExpectationsMarker.pytest_collection_modifyitems): Mark tests if needed,
2320         (run): Create and use TestExpectationsMarker plugin.
2321         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
2322         (WebDriverSeleniumExecutor.run): Pass expectations to pytest_runner.
2323         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
2324         (WebDriverTestRunner.__init__): Create a TestExpectations and pass it to the runners.
2325         (WebDriverTestRunner.run): Do not count results here.
2326         (WebDriverTestRunner.process_results): Rename print_results() as process_results() since it now returns the
2327         amount of failures. Printing the test summary while processing results will be made optional in a follow up
2328         patch.
2329         (WebDriverTestRunner.process_results.report): Return the amount of failures.
2330         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
2331         (WebDriverTestRunnerSelenium.__init__): Initialize _expectations.
2332         (WebDriverTestRunnerSelenium.collect_tests): Do not include skipped tests.
2333         (WebDriverTestRunnerSelenium.run): Stop returning the tests count.
2334         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
2335         (WebDriverTestRunnerW3C.__init__): Initialize _expectations.
2336         (WebDriverTestRunnerW3C.collect_tests): Do not include skipped tests.
2337         (WebDriverTestRunnerW3C._scan_directory): Ditto.
2338         (WebDriverTestRunnerW3C.run): Stop returning the tests count.
2339         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
2340         (WebDriverW3CExecutor.run): Pass expectations to pytest_runner.
2341
2342 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2343
2344         Unreviewed WPE gardening. Mark some known unit test failures.
2345
2346         * TestWebKitAPI/glib/TestExpectations.json:
2347
2348 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2349
2350         [GTK][WPE] Use the same subtest names in GTK and WPE unit tests
2351         https://bugs.webkit.org/show_bug.cgi?id=181724
2352
2353         Reviewed by Philippe Normand.
2354
2355         We currently use /webkit2/foo/bar for GTK and /wpe/foo/bar for WPE. Many of the tests are common, so there's no
2356         reason to use different names. This way we can refer to the same test names for both and we can share the
2357         expectations in the TestExpectations.json file.
2358
2359         * TestWebKitAPI/glib/TestExpectations.json:
2360         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Use /webkit/foo/bar in GTK and WPE.
2361
2362 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2363
2364         Unreviewed. Increase the slow timeout of GTK and WPE unit tests.
2365
2366         We are using now a lower default timeout, so multiplying by 5 is no longer enough for some of the WTF
2367         tests. Multiply by 10 so that we get the same slow timeout as before, 50.
2368
2369         * glib/api_test_runner.py:
2370         (TestRunner._run_test_glib):
2371         (TestRunner._run_google_test):
2372
2373 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2374
2375         [GTK] Duplicated symbols in libjavascriptcoregtk and libwebkit2gtk can cause crashes in production builds
2376         https://bugs.webkit.org/show_bug.cgi?id=179914
2377
2378         Reviewed by Žan Doberšek.
2379
2380         Add two scripts to be run by dist-check step when releasing. One is to detect symbols duplicated in
2381         libjavascriptcoregtk and libwebkit2gtk that should be included to the version script. The other one is to ensure
2382         all symbols listed in the script are present in the library.
2383
2384         * Scripts/check-for-global-bss-symbols-in-webkigtk-libs: Added.
2385         (bss_symbols):
2386         * Scripts/check-for-invalid-symbols-in-version-script: Added.
2387         (script_symbols):
2388         * Scripts/make-dist:
2389         (Distcheck.build):
2390         (Distcheck):
2391         (Distcheck.check_symbols):
2392         (Distcheck.check):
2393
2394 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2395
2396         [GTK][WPE] Propagate the parameters when restarting glib api tests after a crash
2397         https://bugs.webkit.org/show_bug.cgi?id=181722
2398
2399         Reviewed by Žan Doberšek.
2400
2401         I forgot to pass the parameters to run() when restarting.
2402
2403         * glib/glib_test_runner.py:
2404         (GLibTestRunner.run):
2405
2406 2018-01-16  Fujii Hironori  <Hironori.Fujii@sony.com>
2407
2408         [CMake] Remove WebCoreDerivedSources library target
2409         https://bugs.webkit.org/show_bug.cgi?id=181664
2410
2411         Reviewed by Carlos Garcia Campos.
2412
2413         * TestWebKitAPI/PlatformWPE.cmake: Do not link WebCoreDerivedSources.
2414         * TestWebKitAPI/PlatformWin.cmake: Ditto.
2415
2416 2018-01-16  Ling Ho  <lingcherd_ho@apple.com>
2417
2418         Move Debug Test262, Release Test262 and Performance queues to Sierra
2419         https://bugs.webkit.org/show_bug.cgi?id=181692
2420
2421         Unreviewed
2422
2423 2018-01-16  Zach Li  <zachli@apple.com>
2424
2425         Add pop-up policy support in website policies.
2426         https://bugs.webkit.org/show_bug.cgi?id=181544.
2427         rdar://problem/30521400.
2428
2429         Reviewed by Alex Christensen.
2430
2431         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2432         Added pop-up-check.html.
2433
2434         * TestWebKitAPI/Tests/WebKit/pop-up-check.html: Added.
2435
2436         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2437         (-[PopUpPoliciesDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2438         (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2439         (-[PopUpPoliciesDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2440         (TEST):
2441
2442 2018-01-16  Wenson Hsieh  <wenson_hsieh@apple.com>
2443
2444         [Attachment Support] Provide the `src` of an attachment to the UI delegate when an attachment is inserted
2445         https://bugs.webkit.org/show_bug.cgi?id=181638
2446         <rdar://problem/36508702>
2447
2448         Reviewed by Dan Bernstein.
2449
2450         Tweak an existing API test to check that the `src` of an attachment element inserted via script matches the
2451         `source` provided to the UI delegate via -[WKUIDelegate _webView:didInsertAttachment:withSource:].
2452
2453         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2454         (-[AttachmentUpdateObserver init]):
2455         (-[AttachmentUpdateObserver sourceForIdentifier:]):
2456         (-[AttachmentUpdateObserver _webView:didInsertAttachment:withSource:]):
2457         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::expectSourceForIdentifier):
2458         (TestWebKitAPI::TEST):
2459         (-[AttachmentUpdateObserver _webView:didInsertAttachment:]): Deleted.
2460
2461 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2462
2463         Unreviewed. Fix GTK unit tests execution in the bots after r226967.
2464
2465         I forgot to pass the environment to the GLibTestRunner and Xvfb was not used in the bots.
2466
2467         * glib/api_test_runner.py:
2468         (TestRunner._run_test_glib): Pass env to GLibTestRunner.
2469         * glib/glib_test_runner.py:
2470         (GLibTestRunner.run): Use given env.
2471
2472 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2473
2474         [GTK][WPE] Stop passing --verbose to run-api-tests from the bots
2475         https://bugs.webkit.org/show_bug.cgi?id=181676
2476
2477         Reviewed by Carlos Alberto Lopez Perez.
2478
2479         The option was removed in r226967.
2480
2481         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2482         (RunGtkAPITests):
2483         (RunWPEAPITests):
2484
2485 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2486
2487         Unreviewed. Temporarily bring back --verbose option of api_test_runner.py.
2488
2489         The bots are still passing that option and the step is failing because it was removed in r226967.
2490
2491         * glib/api_test_runner.py:
2492         (add_options):
2493
2494 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2495
2496         [GTK][WPE] Improve the way glib tests are run
2497         https://bugs.webkit.org/show_bug.cgi?id=181674
2498
2499         Reviewed by Žan Doberšek.
2500
2501         Stop using gtester external program and use our own tester from python directly. This way we no longer need to
2502         parse the tests output to get the results which is causing problems in WPE bot. We can now differentiate between
2503         tests failing due to an expected assert in the test and unexpected crashes.
2504         This also fixes a bug in previous code where we failed to properly detect tests timing out, because gtester was
2505         not showing the subtest name in stdout in case of timeouts.
2506         I've lowered the default timeout from 10 to 5, since we are now properly handling the timeout for every test
2507         case. I've also removed the verbose option, since it was only used by gtester and we now always show the result
2508         of every test case.
2509
2510         * glib/api_test_runner.py:
2511         (TestRunner._run_test_glib): Use GLibTestRunner.
2512         (TestRunner._run_google_test): Wrote tests timing out to stdout too.
2513         (add_options):
2514         * glib/glib_test_runner.py: Added.
2515         (TestTimeout):
2516         (Message):
2517         (Message.__init__):
2518         (Message.create):
2519         (Message.create.read_unsigned):
2520         (Message.create.read_double):
2521         (Message.create.read_string):
2522         (GLibTestRunner):
2523         (GLibTestRunner.__init__):
2524         (GLibTestRunner._process_data):
2525         (GLibTestRunner._process_message):
2526         (GLibTestRunner._read_from_pipe):
2527         (GLibTestRunner._read_from_stderr):
2528         (GLibTestRunner._start_timeout):
2529         (GLibTestRunner._start_timeout._alarm_handler):
2530         (GLibTestRunner._stop_timeout):
2531         (GLibTestRunner._subtest_start):
2532         (GLibTestRunner._subtest_message):
2533         (GLibTestRunner._subtest_stderr):
2534         (GLibTestRunner._subtest_end):
2535         (GLibTestRunner.run):
2536
2537 2018-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
2538
2539         Unreviewed, add Thibault to contributors.json
2540
2541         It's a bit weird to add someone here before their first contribution, but this affects
2542         Bugzilla autocomplete, and that is serious business.
2543
2544         * Scripts/webkitpy/common/config/contributors.json:
2545
2546 2018-01-15  JF Bastien  <jfbastien@apple.com>
2547
2548         Remove makePoisonedUnique
2549         https://bugs.webkit.org/show_bug.cgi?id=181630
2550         <rdar://problem/36498623>
2551
2552         Reviewed by Mark Lam.
2553
2554         Update tests.
2555
2556         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
2557         (TestWebKitAPI::TEST):
2558         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
2559         (TestWebKitAPI::TEST):
2560
2561 2018-01-15  Adrian Perez de Castro  <aperez@igalia.com>
2562
2563         [GTK][JHBuild] Tools/gtk/install-dependencies: Package libxfont does not exist anymore in Arch Linux
2564         https://bugs.webkit.org/show_bug.cgi?id=181476
2565
2566         Reviewed by Michael Catanzaro.
2567
2568         Update to xorg-server 1.19.6 which depends on libxfont2, and change
2569         the lists of packages to install libxfont2-devel (or equivalent).
2570
2571         * gtk/install-dependencies:
2572         * gtk/jhbuild.modules:
2573
2574 2018-01-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2575
2576         [GTK][WPE] Add support for unit test expectations
2577         https://bugs.webkit.org/show_bug.cgi?id=181589
2578
2579         Reviewed by Michael Catanzaro.
2580
2581         We currently have a way to skip tests by annotating them in the api test runner script. The main problem of this
2582         approach is that we skip tests when they fail in the bots and we never notice if they stop failing, keeping the
2583         tests skipped forever. This is indeed the case of several WebKit2 C API tests. Annotating skipped tests in the
2584         script itself is not a good idea either.
2585
2586         This patch adds a generic TestExpectations class for simple tests based on tests with subtests, like our unit
2587         tests, but also WebDriver tests. It parses a json file with the tests and subtests expectations and provides
2588         convenient methods to query them.
2589
2590         * Scripts/run-gtk-tests:
2591         (GtkTestRunner): Remove all Skipped and Slow tests marked here.
2592         * Scripts/run-wpe-tests:
2593         (WPETestRunner): Ditto.
2594         * Scripts/webkitpy/common/test_expectations.py: Added.
2595         (TestExpectations):
2596         (TestExpectations.__init__):
2597         (TestExpectations._port_name_for_expected):
2598         (TestExpectations._expected_value):
2599         (TestExpectations.skipped_tests):
2600         (TestExpectations.skipped_subtests):
2601         (TestExpectations._expectation_value):
2602         (TestExpectations.is_slow):
2603         (TestExpectations.get_expectation):
2604         * Scripts/webkitpy/common/test_expectations_unittest.py: Added.
2605         (MockTestExpectations):
2606         (MockTestExpectations.__init__):
2607         (MockTestExpectations.is_skip):
2608         (ExpectationsTest):
2609         (assert_exp):
2610         (assert_not_exp):
2611         (assert_bad_exp):
2612         (assert_skip):
2613         (test_basic):
2614         (test_skip):
2615         (test_flaky):
2616         (test_build_type):
2617         * TestWebKitAPI/glib/TestExpectations.json: Added.
2618         * glib/api_test_runner.py:
2619         (TestRunner): Remove SkippedTest implementation.
2620         (TestRunner.__init__): Create a TestExpectations.
2621         (TestRunner._test_cases_to_skip): Use TestExpectations to check skipped tests.
2622         (TestRunner._should_run_test_program): Ditto.
2623         (TestRunner._run_test_glib): Use TestExpectations to check if test suite is slow.
2624         (TestRunner._run_test_glib.parse_line.set_test_result): Register also tests passing.
2625         (TestRunner._run_google_test): Use TestExpectations to check if test cases is slow and register tests passing.
2626         (TestRunner.run_tests): Check if actual result is the expected one and register also unexpected passes.
2627         (TestRunner.run_tests.report): Helper to write report to stdout.
2628
2629 2018-01-13  Mark Lam  <mark.lam@apple.com>
2630
2631         Replace all use of ConstExprPoisoned with Poisoned.
2632         https://bugs.webkit.org/show_bug.cgi?id=181542
2633         <rdar://problem/36442138>
2634
2635         Reviewed by JF Bastien.
2636
2637         1. Converted tests to using new uintptr_t& poison type.
2638         2. Added tests for Poisoned comparison operators.
2639
2640         * TestWebKitAPI/CMakeLists.txt:
2641         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2642         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp: Removed.
2643         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
2644         (TestWebKitAPI::TEST):
2645         (TestWebKitAPI::initializeTestPoison): Deleted.
2646         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
2647         (TestWebKitAPI::TEST):
2648         (TestWebKitAPI::passWithRef):
2649         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
2650         (TestWebKitAPI::TEST):
2651         (TestWebKitAPI::f1):
2652         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
2653         (TestWebKitAPI::TEST):
2654         (TestWebKitAPI::poisonedPtrFoo):
2655         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
2656         (TestWebKitAPI::TEST):
2657         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
2658         (TestWebKitAPI::TEST):
2659
2660 2018-01-13  David Kilzer  <ddkilzer@apple.com>
2661
2662         check-webkit-style: false positive for [whitespace/braces] with os_log format string
2663         <https://webkit.org/b/181606>
2664
2665         Reviewed by Darin Adler.
2666
2667         * Scripts/webkitpy/style/checkers/cpp.py:
2668         (check_spacing): Modify regular expression to ignore
2669         os_log format strings like '%{public}'.
2670         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2671         (CppStyleTest.test_spacing_before_braces): Add os_log
2672         format string test.
2673
2674 2018-01-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2675
2676         [macOS] API tests ChangeAttachmentDataUpdatesWithInPlaceDisplay and InPlaceVideoAttachmentInsertionWithinList are failing
2677         https://bugs.webkit.org/show_bug.cgi?id=181626
2678
2679         Reviewed by Joseph Pecoraro.
2680
2681         Make the web view for WKAttachmentTests slightly bigger to avoid size clamping behavior introduced in r226915.
2682         Additionally, write a new API test covering the change in r226915.
2683
2684         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2685         (webViewForTestingAttachments):
2686         (TestWebKitAPI::TEST):
2687
2688 2018-01-12  Alex Christensen  <achristensen@webkit.org>
2689
2690         History state should be updated during client redirects with asynchronous policy decisions
2691         https://bugs.webkit.org/show_bug.cgi?id=181358
2692         <rdar://problem/35547689>
2693
2694         Reviewed by Andy Estes.
2695
2696         * TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm:
2697         (-[AsyncPolicyDecisionDelegate webView:didFinishNavigation:]):
2698         (-[AsyncPolicyDecisionDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2699         (TEST):
2700
2701 2018-01-12  Jonathan Bedard  <jbedard@apple.com>
2702
2703         webkitpy: Refactor simulator code (Part 4)
2704         https://bugs.webkit.org/show_bug.cgi?id=180555
2705         <rdar://problem/36131381>
2706
2707         Reviewed by Aakash Jain.
2708
2709         Move new_simulated_device.py to simulated_device.py.
2710
2711         * Scripts/webkitpy/port/ios_simulator.py: Update import statement.
2712         * Scripts/webkitpy/xcode/new_simulated_device.py: Removed.
2713         * Scripts/webkitpy/xcode/new_simulated_device_unittest.py: Removed.
2714         * Scripts/webkitpy/xcode/simulated_device.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device.py.
2715         * Scripts/webkitpy/xcode/simulated_device_unittest.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device_unittest.py.
2716
2717 2018-01-12  Alex Christensen  <achristensen@webkit.org>
2718
2719         REGRESSION (r226818): API test WebKitLegacy.LoadInvalidURLRequest is failing
2720         https://bugs.webkit.org/show_bug.cgi?id=181595
2721
2722         This test was testing behavior of an invalid URL that WebCore parses but NSURL does not.
2723         It was using example.com<> but after r226479 < and > are considered invalid by WebCore.
2724         I change the < and > to $ to make this test pass and continue to test what it used to.
2725
2726         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.html:
2727         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
2728         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2729
2730 2018-01-11  Keith Miller  <keith_miller@apple.com>
2731
2732         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
2733         https://bugs.webkit.org/show_bug.cgi?id=181573
2734
2735         Reviewed by Simon Fraser.
2736
2737         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2738
2739 2018-01-11  Jiewen Tan  <jiewen_tan@apple.com>
2740
2741         [WebAuthN] Import a CBOR coder from Chromium
2742         https://bugs.webkit.org/show_bug.cgi?id=181522
2743         <rdar://problem/36055729>
2744
2745         Reviewed by Brent Fulgham.
2746
2747         This patch also imports all unit tests into our API tests to ensure all
2748         workarounds and modification against the original codebase doesn't change
2749         any original functionalities.
2750
2751         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2752         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp: Added.
2753         (TestWebKitAPI::TEST):
2754         * TestWebKitAPI/Tests/WebCore/CBORValueTest.cpp: Added.
2755         (TestWebKitAPI::TEST):
2756         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp: Added.
2757         (TestWebKitAPI::eq):
2758         Workarounds applied.
2759         (TestWebKitAPI::TEST):
2760
2761 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
2762
2763         webkitpy: Use partially disambiguated type in SimulatedDeviceManager._disambiguate_device_type
2764         https://bugs.webkit.org/show_bug.cgi?id=181538
2765         <rdar://problem/36440580>
2766
2767         Reviewed by Aakash Jain.
2768
2769         When disambiguating a device type, it is possible that the provided device type is sufficiently
2770         ambiguous that the comparisons against complete device types without a disambiguated hardware_family
2771         will result in a failure to disambiguate the type.
2772
2773         * Scripts/webkitpy/xcode/new_simulated_device.py:
2774         (SimulatedDeviceManager._disambiguate_device_type):
2775
2776 2018-01-11  Brent Fulgham  <bfulgham@apple.com>
2777
2778         REGRESSION(r219530): ResourceLoadStatisticsPersistentStorage should be read-only in ephemeral sessions
2779         https://bugs.webkit.org/show_bug.cgi?id=181136
2780         <rdar://problem/36116604>
2781
2782         Reviewed by Chris Dumez.
2783
2784         Add a new API test to confirm that ResourceLoadStatistics can be turned on safely for ephemeral
2785         browsing sessions.
2786
2787         * Scripts/run-gtk-tests:
2788         (GtkTestRunner): Unskip test now that it passes.
2789         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2790         (TEST): Add new WebsiteDataStoreEphemeral test.
2791
2792 2018-01-11  Ryan Haddad  <ryanhaddad@apple.com>
2793
2794         Unreviewed, rolling out r226816.
2795
2796         This change broke LayoutTests on the bots.
2797
2798         Reverted changeset:
2799
2800         "run-webkit-tests fails when there is a curly brace in Xcode
2801         build output"
2802         https://bugs.webkit.org/show_bug.cgi?id=181254
2803         https://trac.webkit.org/changeset/226816
2804
2805 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
2806
2807         webkitpy: Fix flakey webserver tests
2808         https://bugs.webkit.org/show_bug.cgi?id=181555
2809         <rdar://problem/36448273>
2810
2811         Reviewed by Aakash Jain.
2812
2813         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
2814         (LayoutTestRunnerTests.test_servers_started): Add and bind custom checks to
2815         determine if a specific server is running.
2816
2817 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
2818
2819         Commit queue failed to land a bug, 'NoneType' object has no attribute 'strip'
2820         https://bugs.webkit.org/show_bug.cgi?id=181561
2821         <rdar://problem/36452652>
2822
2823         Reviewed by Aakash Jain.
2824
2825         BeautifulSoup.find may return None, this case should be gracefully handled.
2826
2827         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2828         (BugzillaQueries._parse_result_count):
2829         (BugzillaQueries._fetch_bugs_from_advanced_query): Added logging.
2830
2831 2018-01-11  Alexey Proskuryakov  <ap@apple.com>
2832
2833         run-webkit-tests fails when there is a curly brace in Xcode build output
2834         https://bugs.webkit.org/show_bug.cgi?id=181254
2835
2836         Reviewed by Daniel Bates.
2837
2838         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
2839         (MeteredStream.write):
2840
2841 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
2842
2843         webkitpy: Reimplement simulator code (Part 3)
2844         https://bugs.webkit.org/show_bug.cgi?id=180555
2845         <rdar://problem/36131381>
2846
2847         Reviewed by Aakash Jain.
2848
2849         Remove old simulator code.
2850
2851         * Scripts/webkitpy/xcode/__init__.py: Remove import statement.
2852         * Scripts/webkitpy/xcode/simulated_device.py: Removed.
2853         * Scripts/webkitpy/xcode/simulator.py: Removed.
2854         * Scripts/webkitpy/xcode/simulator_unittest.py: Removed.
2855
2856 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2857
2858         [Attachment Support] Support moving attachment elements in editable areas using drag and drop
2859         https://bugs.webkit.org/show_bug.cgi?id=181337
2860         <rdar://problem/36324813>
2861
2862         Reviewed by Tim Horton.
2863
2864         Add 3 new API tests for attachment element dragging.
2865
2866         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2867         (-[TestWKWebView expectElementTag:toComeBefore:]):
2868         (-[NSItemProvider expectType:withData:]):
2869         (TestWebKitAPI::TEST):
2870
2871 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
2872
2873         REGRESSION(r225856): Incorrectly managing 'future' baseline_search_paths. 
2874         https://bugs.webkit.org/show_bug.cgi?id=179621
2875         <rdar://problem/35589585>
2876
2877         Unreviewed infrastructure fix.
2878
2879         * Scripts/webkitpy/port/mac.py:
2880         (MacPort.default_baseline_search_path): Include 'future' in the version_fallback
2881         list if we are the VERSION_MAX, which usually corresponds with future.
2882
2883 2018-01-11  Filip Pizlo  <fpizlo@apple.com>
2884
2885         CodeBlocks should be in IsoSubspaces
2886         https://bugs.webkit.org/show_bug.cgi?id=180884
2887
2888         Reviewed by Saam Barati.
2889         
2890         Remove some less important benchmarks from the default run. Doing run-jsc-benchmarks
2891         shouldn't take a long time due to benchmarks we don't optimize for.
2892         
2893         * Scripts/run-jsc-benchmarks:
2894
2895 2018-01-11  Ms2ger  <Ms2ger@igalia.com>
2896
2897         Test gardening for GTK.
2898         https://bugs.webkit.org/show_bug.cgi?id=181477
2899
2900         Unreviewed test gardening.
2901
2902         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Correct the file name.
2903         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Adjust the expected console message.
2904
2905 2018-01-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2906
2907         Add the new JSCOnly bot to the scheduler.
2908         https://bugs.webkit.org/show_bug.cgi?id=181487
2909
2910         Unreviewed follow-up patch after r226729
2911
2912         On r226729 I missed to add the new JSCOnly bot the default scheduler.
2913         This is needed to make the bot automatically pick each commit for testing.
2914
2915         * BuildSlaveSupport/build.webkit.org-config/config.json:
2916
2917 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2918
2919         [Attachment Support] Support dragging attachment elements out as files on iOS
2920         https://bugs.webkit.org/show_bug.cgi?id=181199
2921         <rdar://problem/36299316>
2922
2923         Reviewed by Tim Horton, Andy Estes and Joseph Pecoraro.
2924
2925         Add support in the drag and drop simulator for testing blob-backed attachment element dragging, and also add new
2926         attachment API tests.
2927
2928         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2929         (-[NSItemProvider expectType:withData:]):
2930         (TestWebKitAPI::TEST):
2931
2932         Add two new WKAttachmentTests to exercise dragging data- and file-backed blobs via attachment elements. These
2933         tests first insert attachments via drop or WKWebView SPI, and then drag these attachments out and use the
2934         -expectType:withData: helper to inspect the item providers created from the drag source.
2935
2936         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2937         (TestWebKitAPI::TEST):
2938         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2939         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2940         (-[MockDragSession localContext]):
2941         (-[MockDragSession setLocalContext:]):
2942         (-[DataInteractionSimulator _resetSimulatedState]):
2943         (-[DataInteractionSimulator simulateAllTouchesCanceled:]):
2944         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
2945         (-[DataInteractionSimulator _advanceProgress]):
2946         (-[DataInteractionSimulator endDataTransfer]):
2947
2948         Make some tweaks to the iOS drag and drop simulator. In particular, this patch (1) adds a new hook to tell
2949         WebKit that data transfers have been completed, (2) fixes incorrect drop proposal handling when returning
2950         UIDropOperationForbidden by replacing _shouldPerformOperation with a UIDropProposal, and (3) teach the
2951         MockDragSession to hold on to a localContext.
2952
2953 2018-01-11  Ali Juma  <ajuma@chromium.org>
2954
2955         Unreviewed. Add Ali Juma as contributor
2956
2957         * Scripts/webkitpy/common/config/contributors.json:
2958
2959 2018-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2960
2961         Unreviewed. Update Selenium WebDriver imported tests.
2962
2963         New version of selenium uses command line options to pass driver and browser binaries to pytest instead of
2964         environment variables.
2965
2966         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
2967         (collect): Reorder the arguments to make pytest happy.
2968         (run): Ditto.
2969         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
2970         (WebDriverSeleniumExecutor.__init__): Add driver binary, browser binary and browser args as arguments.
2971
2972 2018-01-11  Ling Ho  <lingcherd_ho@apple.com>
2973
2974         Move Commit Queue and EWS Queues to Sierra on Bot Watcher's Dasboard
2975         https://bugs.webkit.org/show_bug.cgi?id=181492
2976         <rdar://problem/36359679>
2977
2978         Reviewed by Alexey Proskuryakov. 
2979
2980 2018-01-10  Adrian Perez de Castro  <aperez@igalia.com>
2981
2982         [GTK] Tools/gtk/install-dependencies: Packages geoclue, ruby-highline, xorg-utils do not exist in Arch Linux
2983         https://bugs.webkit.org/show_bug.cgi?id=181475
2984
2985         Reviewed by Michael Catanzaro.
2986
2987         * gtk/install-dependencies: Update package list for Arch Linux, extend
2988         message shown at end of installation with additional tips.
2989
2990 2018-01-10  Wenson Hsieh  <wenson_hsieh@apple.com>
2991
2992         REGRESSION(r222507): Composition highlight doesn't render when using IME
2993         https://bugs.webkit.org/show_bug.cgi?id=181485
2994         <rdar://problem/35896516>
2995
2996         Reviewed by Ryosuke Niwa.
2997
2998         Add a `suppressUnderline` argument to TextInputController.setMarkedText. This suppresses the custom underlines
2999         rendered when testing IME on iOS in WebKit2. In this new test, suppressing underline rendering is needed to
3000         allow rendering composition backgrounds (see InlineTextBox::paint).
3001
3002         * DumpRenderTree/ios/TextInputControllerIOS.m:
3003         (+[TextInputController isSelectorExcludedFromWebScript:]):
3004         (+[TextInputController webScriptNameForSelector:]):
3005         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
3006         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
3007         * DumpRenderTree/mac/TextInputControllerMac.m:
3008         (+[TextInputController isSelectorExcludedFromWebScript:]):
3009         (+[TextInputController webScriptNameForSelector:]):
3010         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
3011         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
3012         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
3013         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
3014         (WTR::TextInputController::setMarkedText):
3015         * WebKitTestRunner/InjectedBundle/TextInputController.h:
3016
3017 2018-01-10  JF Bastien  <jfbastien@apple.com>
3018
3019         Poison small JSObject derivatives which only contain pointers
3020         https://bugs.webkit.org/show_bug.cgi?id=181483
3021         <rdar://problem/36407127>
3022
3023         Reviewed by Mark Lam.
3024
3025         Test the new move-assign and move-copy from unique_ptr, as well as
3026         nullptr_t ctors.
3027
3028         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
3029         (TestWebKitAPI::TEST):
3030         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
3031         (TestWebKitAPI::TEST):
3032         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
3033         (TestWebKitAPI::TEST):
3034
3035 2018-01-10  Chris Dumez  <cdumez@apple.com>
3036
3037         Multiple http/wpt/beacon/contentextensions/ test are flaky.
3038         https://bugs.webkit.org/show_bug.cgi?id=179256
3039         <rdar://problem/35401978>
3040
3041         Reviewed by Alex Christensen.
3042
3043         Update WebKitTestRunner to set a temporary path for content extensions so that its WKTR
3044         instance gets its own folder to avoid conflicts and flakiness.
3045
3046         * WebKitTestRunner/mac/TestControllerMac.mm:
3047         (WTR::TestController::platformConfigureViewForTest):
3048
3049 2018-01-10  Tim Horton  <timothy_horton@apple.com>
3050
3051         REGRESSION (r213590): Swipe from edge to go to previous page is significantly slower than tapping back button on Twitter
3052         https://bugs.webkit.org/show_bug.cgi?id=181269
3053         <rdar://problem/35110344>
3054
3055         Reviewed by Simon Fraser.
3056
3057         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3058         (WTR::UIScriptController::beginBackSwipe):
3059         (WTR::UIScriptController::completeBackSwipe):
3060         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3061         (WTR::UIScriptController::beginBackSwipe):
3062         (WTR::UIScriptController::completeBackSwipe):
3063         (WTR::UIScriptController::overridePreference):
3064         (WTR::UIScriptController::replaceTextAtRange):
3065         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3066         (WTR::PlatformWebView::setNavigationGesturesEnabled):
3067         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3068         (WTR::UIScriptController::beginBackSwipe):
3069         (WTR::UIScriptController::completeBackSwipe):
3070         Implement beginBackSwipe and completeBackSwipe on iOS (they already
3071         exist on Mac) in terms of the new WKWebView testing SPI.
3072
3073 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
3074
3075         REGRESSION (r226715): ignore WARNING output in linter tests
3076         https://bugs.webkit.org/show_bug.cgi?id=181486
3077         <rdar://problem/36408847>
3078
3079         Reviewed by Aakash Jain.
3080
3081         Linter unit tests should not be interested in logs at the the INFO or WARNING levels.
3082
3083         * Scripts/webkitpy/common/system/outputcapture.py:
3084         (OutputCapture.__init__): Pass logging level to be captured.
3085         * Scripts/webkitpy/style/main_unittest.py:
3086         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors): Capture logging at the ERROR level.
3087         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Ditto.
3088         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit): Ditto.
3089         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Ditto.
3090         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Ditto.
3091         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Ditto.
3092         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file): Ditto.
3093         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit): Ditto.
3094
3095 2018-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3096
3097         Add a JSCOnly MIPS buildbot
3098         https://bugs.webkit.org/show_bug.cgi?id=181487
3099
3100         Reviewed by Michael Catanzaro.
3101
3102         Add the new bot configs definitions for the master and update the unit tests.
3103
3104         * BuildSlaveSupport/build.webkit.org-config/config.json:
3105         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3106
3107 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
3108
3109         REGRESSION (r226715): don't re-check number of simulators in child processes
3110         https://bugs.webkit.org/show_bug.cgi?id=181484
3111         <rdar://problem/36407151>
3112
3113         Reviewed by Aakash Jain.
3114
3115         * Scripts/webkitpy/port/ios_simulator.py:
3116         (IOSSimulatorPort.__init__): Skip the number of simulators check if simulators
3117         are already initialized.
3118
3119 2018-01-10  Commit Queue  <commit-queue@webkit.org>
3120
3121         Unreviewed, rolling out r226667 and r226673.
3122         https://bugs.webkit.org/show_bug.cgi?id=181488
3123
3124         This caused a flaky crash. (Requested by mlewis13 on #webkit).
3125
3126         Reverted changesets:
3127
3128         "CodeBlocks should be in IsoSubspaces"
3129         https://bugs.webkit.org/show_bug.cgi?id=180884
3130         https://trac.webkit.org/changeset/226667
3131
3132         "REGRESSION (r226667): CodeBlocks should be in IsoSubspaces"
3133         https://bugs.webkit.org/show_bug.cgi?id=180884
3134         https://trac.webkit.org/changeset/226673
3135
3136 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
3137
3138         Follow-up fix to r226715
3139         https://bugs.webkit.org/show_bug.cgi?id=180555
3140         <rdar://problem/36131381>
3141
3142         Unreviewed infrastructure fix.
3143
3144         * Scripts/webkitpy/xcode/new_simulated_device.py:
3145         (SimulatedDeviceManager._create_or_find_device_for_request): Use _delete instead
3146         of delete.
3147
3148 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
3149
3150         webkitpy: Refactor simulator code (Part 2)
3151         https://bugs.webkit.org/show_bug.cgi?id=180555
3152         <rdar://problem/36131381>
3153
3154         Reviewed by Aakash Jain.
3155
3156         The patch leverages the SimulatedDeviceManager when running layout tests.
3157         This patch is primarily code removal, since much of the IOSSimulatorPort
3158         was dedicated to managing simulators. The removed code is either now owned by the
3159         SimulatedDeviceManager (and committed in Part 1) or supported a technique to
3160         boot multiple simulators which was made obsolete in Xcode 9.
3161
3162         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3163         (Manager._custom_device_for_test.in): Device names now have spaces in them,
3164         strip those spaces.
3165         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3166         (parse_args): Remove '--runtime' flag, this is achieved with the --version flag.
3167         * Scripts/webkitpy/port/ios.py:
3168         (IOSPort.__init__): The _current_device idiom is no longer required since the
3169         SimulatedDeviceManager keeps track of any previously booted devices.
3170         (IOSPort.target_host): Even when only a single device is used, it will be accessed
3171         through the array of managed devices.
3172         (IOSPort.using_multiple_devices): Deleted.
3173         * Scripts/webkitpy/port/ios_device.py:
3174         (IOSDevicePort.using_multiple_devices): Deleted.
3175         * Scripts/webkitpy/port/ios_simulator.py:
3176         (IOSSimulatorPort): Remove constants required to manage simulators, change device
3177         class strings so they can be parsed by the DeviceType class.
3178         (IOSSimulatorPort.__init__): Determine the number of processes to use by checking
3179         the number of simulators currently booted, the number of child processes specified
3180         and the maximum number of simulators supported by this system.
3181         (IOSSimulatorPort._device_for_worker_number_map):Return the array of initialized
3182         devices owned by the SimulatedDeviceManager.
3183         (IOSSimulatorPort.ios_version): Remove support for the --runtime option.
3184         (IOSSimulatorPort.default_child_processes): Use the SimulatedDeviceManager to check
3185         the maximum number of supported simulators on this system.
3186         (IOSSimulatorPort._create_devices): Construct a list of device requests with a
3187         request for each child process and send this list to the SimulatedDeviceManager to
3188         initialize the devices.
3189         (IOSSimulatorPort.clean_up_test_run):
3190         (IOSSimulatorPort.check_sys_deps): Check that there are simulators running the
3191         specified version of iOS.
3192         (IOSSimulatorPort.reset_preferences):
3193         (IOSSimulatorPort.simulator_runtime): Deleted.
3194         (IOSSimulatorPort.simulator_device_type): Deleted.
3195         (IOSSimulatorPort._teardown_managed_simulators): Deleted.
3196         (IOSSimulatorPort.use_multiple_simulator_apps): Deleted.
3197         (IOSSimulatorPort._create_simulators): Deleted.
3198         (IOSSimulatorPort._quit_ios_simulator): Deleted.
3199         (IOSSimulatorPort._using_dedicated_simulators): Deleted.
3200         (IOSSimulatorPort.using_multiple_devices): Deleted.
3201         (IOSSimulatorPort._create_device): Deleted.
3202         (IOSSimulatorPort.get_simulator_path): Deleted.
3203         (IOSSimulatorPort._createSimulatorApps): Deleted.
3204         (IOSSimulatorPort._createSimulatorApp): Deleted.
3205         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3206         (TestRebaseline.test_rebaseline): Filter out commands run when determining the
3207         maximum number of simulators run on this system.
3208         (TestRebaselineExpectations.test_rebaseline_expectations): Ditto.
3209         * Scripts/webkitpy/xcode/new_simulated_device.py:
3210         (SimulatedDeviceManager._does_fulfill_request): Fixed log statement.
3211
3212 2018-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
3213
3214         WebDriver: run-webdriver-tests doesn't handle test names with a '/' correctly
3215         https://bugs.webkit.org/show_bug.cgi?id=181474
3216
3217         Reviewed by Carlos Alberto Lopez Perez.
3218
3219         We use os.path.basename() to get the subtest name. If the test name contains a slash we get part of the subtest
3220         name as the name.
3221
3222         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
3223         (WebDriverTestRunnerW3C._subtest_name): Helper function to get the subtest name.
3224         (WebDriverTestRunnerW3C.run): Use _subtest_name() instead of os.path.basename().
3225
3226 2018-01-09  Andy Estes  <aestes@apple.com>
3227
3228         [Xcode] Use the Apple Internal SDK if available when building ImageDiff
3229         https://bugs.webkit.org/show_bug.cgi?id=181459
3230
3231         Reviewed by Dan Bernstein.
3232
3233         * ImageDiff/cg/Configurations/Base.xcconfig:
3234
3235 2018-01-09  Myles C. Maxfield  <mmaxfield@apple.com>
3236
3237         font-display:fallback can cause a visual flash (which is supposed to be impossible)
3238         https://bugs.webkit.org/show_bug.cgi?id=181374
3239
3240         Reviewed by Simon Fraser.
3241
3242         The test requires Palatino.
3243
3244         * DumpRenderTree/mac/DumpRenderTree.mm:
3245         (allowedFontFamilySet):
3246         * WebKitTestRunner/mac/TestControllerMac.mm:
3247         (WTR::allowedFontFamilySet):
3248
3249 2018-01-09  Saam Barati  <sbarati@apple.com>
3250
3251         Give some slack in display-profiler-outputs computation of the terminal window's number of columns
3252         https://bugs.webkit.org/show_bug.cgi?id=181449
3253
3254         Reviewed by JF Bastien.
3255
3256         This allows me to Cmd+f in my terminal to search for things without
3257         having the results become misaligned.
3258
3259         * Scripts/display-profiler-output:
3260
3261 2018-01-09  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3262
3263         [webkitpy] PlatformInfo should have default argument for casual use
3264         https://bugs.webkit.org/show_bug.cgi?id=180827
3265
3266         Reviewed by David Kilzer.
3267
3268         PlatformInfo should be the only way to check platform specific thing instead
3269         of sys.platform or other various checks. If there is something you want to check,
3270         it should be placed in PlatformInfo.
3271
3272         Currently to instantiate PlatformInfo, it requires arguments, which is usually
3273         sys, platform and Executive(). They are straight forward and should be handled
3274         by default arguments. Then we can instantiate PlatformInfo more casual.
3275
3276         * Scripts/webkitpy/common/system/platforminfo.py:
3277         (PlatformInfo): Use relative module path import
3278         (PlatformInfo.__init__):
3279         (PlatformInfo.executive): Lazy instantiation of Executive()
3280         (PlatformInfo.total_bytes_memory): Accessing via above property
3281         (PlatformInfo.xcode_sdk_version): Ditto
3282         (PlatformInfo.xcode_simctl_list): Ditto
3283         (PlatformInfo.xcode_version): Ditto
3284         (PlatformInfo._win_version_str): Ditto
3285         * Scripts/webkitpy/common/system/systemhost.py:
3286         (SystemHost.__init__):
3287         * Scripts/webkitpy/common/system/user.py:
3288         (User.__init__):
3289
3290 2018-01-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3291
3292         [Win] Remove workaround for Bug 176442 after stopping MSVC 2015 support
3293         https://bugs.webkit.org/show_bug.cgi?id=176443
3294
3295         Reviewed by Darin Adler.
3296
3297         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
3298         (TEST):
3299
3300 2018-01-09  Frederic Wang  <fwang@igalia.com.fr>
3301
3302         check-webkit-style: Verify syntax for WK_API_AVAILABLE
3303         https://bugs.webkit.org/show_bug.cgi?id=181394
3304
3305         Reviewed by Darin Adler.
3306
3307         A common syntax error for WK_API_AVAILABLE is to write ios(WK_MAC_TBA)
3308         as the second parameter instead of ios(WK_IOS_TBA). This generally
3309         builds for iOS on EWS but not when using the public SDK. See r224057,
3310         r223207 and r226211 for example. This patch adds a basic style check
3311         for that macro to prevent this kind of mistake.
3312
3313         * Scripts/webkitpy/style/checkers/cpp.py:
3314         (check_min_versions_of_wk_api_available): New function to verify the parameters of WX_API_AVAILABLE.
3315         (check_style): Run new style check.
3316         (CppChecker): Add build type for the new style check.
3317         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3318         (WebKitStyleTest.test_min_versions_of_wk_api_available): Add tests for the new style check.
3319
3320 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3321
3322         [Attachment Support] Expose HTMLAttachmentElement.uniqueIdentifier to bindings
3323         https://bugs.webkit.org/show_bug.cgi?id=181420
3324         <rdar://problem/36365827>
3325
3326         Reviewed by Alex Christensen.
3327
3328         Adjusts some existing API tests to verify that attachment elements' uniqueIdentifiers match the uniqueIdentifier
3329         of corresponding _WKAttachments.
3330
3331         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3332         (TestWebKitAPI::TEST):
3333
3334 2018-01-08  Alex Christensen  <achristensen@webkit.org>
3335
3336         Add WKNavigationDelegate SPI exposing WebProcess crash reason
3337         https://bugs.webkit.org/show_bug.cgi?id=181410
3338         <rdar://problem/36167199>
3339
3340         Reviewed by Wenson Hsieh.
3341
3342         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
3343         (-[CrashReasonDelegate _webView:webContentProcessDidTerminateWithReason:]):
3344         (TEST):
3345
3346 2018-01-08  Alex Christensen  <achristensen@webkit.org>
3347
3348         Add SPI for WKOpenPanelParameters._acceptedMIMETypes and _acceptedFileExtensions
3349         https://bugs.webkit.org/show_bug.cgi?id=181408
3350         <rdar://problem/35884960>
3351
3352         Reviewed by Tim Horton.
3353
3354         * TestWebKitAPI/Tests/WebKitCocoa/RunOpenPanel.mm:
3355         (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
3356
3357 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3358
3359         [Attachment Support] Expose file name and content type of WKAttachment
3360         https://bugs.webkit.org/show_bug.cgi?id=181390
3361         <rdar://problem/36336837>
3362
3363         Reviewed by Tim Horton.
3364
3365         Adjusts some existing tests in WKAttachmentTests to exercise -requestInfo:.
3366
3367         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3368         (-[_WKAttachment synchronouslyRequestInfo:]):
3369         (-[_WKAttachment synchronouslyRequestData:]):
3370
3371         Reimplement this in terms of -synchronouslyRequestInfo:.
3372
3373         (-[_WKAttachment expectRequestedDataToBe:]):
3374         (TestWebKitAPI::TEST):
3375
3376 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3377
3378         Copying, pasting, and then deleting an attachment element breaks attachment data requests
3379         https://bugs.webkit.org/show_bug.cgi?id=181365
3380         <rdar://problem/36340647>
3381
3382         Reviewed by Tim Horton.
3383
3384         Adds two new attachment API tests to verify that copying and pasting an existing attachment inserts an
3385         attachment element that may be edited independently of the original attachment. See WebCore/ChangeLog for more
3386         detail.
3387
3388         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3389         (TestWebKitAPI::TEST):
3390
3391 2018-01-08  Youenn Fablet  <youenn@apple.com>
3392
3393         navigator.onLine does not work inside service workers
3394         https://bugs.webkit.org/show_bug.cgi?id=181079
3395         <rdar://problem/36178606>
3396
3397         Reviewed by Darin Adler.
3398
3399         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3400         (WTR::InjectedBundle::initialize): Setting service worker creation callback to inject ServiceWorkerInternals object.
3401
3402 2018-01-07  Saam Barati  <sbarati@apple.com>
3403
3404         Add total exits and total compilations sorting mode to the "full" command in display-profiler-output
3405         https://bugs.webkit.org/show_bug.cgi?id=181372
3406
3407         Reviewed by Filip Pizlo.
3408
3409         Adding these sorting modes makes it easier to analyze functions
3410         that recompile a lot and exit a lot.
3411
3412         * Scripts/display-profiler-output:
3413
3414 2018-01-06  Julien Brianceau  <julien.brianceau@gmail.com>
3415
3416         Unreviewed, remove my Cisco email from contributors.json
3417
3418         * Scripts/webkitpy/common/config/contributors.json:
3419
3420 2018-01-05  JF Bastien  <jfbastien@apple.com>
3421
3422         WebAssembly: poison JS object's secrets
3423         https://bugs.webkit.org/show_bug.cgi?id=181339
3424         <rdar://problem/36325001>
3425
3426         Reviewed by Mark Lam.
3427
3428         Update tests for swap(Poisoned<k, T>, T*)
3429
3430         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp:
3431         (TestWebKitAPI::TEST):
3432         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
3433         (TestWebKitAPI::TEST):
3434         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
3435         (TestWebKitAPI::TEST):
3436
3437 2018-01-05  Wenson Hsieh  <wenson_hsieh@apple.com>
3438
3439         REGRESSION(r226396) DataInteractionTests: ContentEditableToContentEditable and ContentEditableToTextarea are failing
3440         https://bugs.webkit.org/show_bug.cgi?id=181359
3441
3442         Reviewed by Tim Horton.
3443
3444         Ensure that these tests still pass using older SDKs.
3445
3446         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3447         (TestWebKitAPI::TEST):
3448
3449 2018-01-05  Alex Christensen  <achristensen@webkit.org>
3450
3451         Rebase API test after r226469
3452         https://bugs.webkit.org/show_bug.cgi?id=181308
3453
3454         * TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm:
3455         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
3456         A URL with < or > in it is now recognized as invalid by WebKit.  This is intentional, and matches our behavior before enabling the new URLParser.
3457
3458 2018-01-05  Alex Christensen  <achristensen@webkit.org>
3459
3460         Restrict navigation-time WKWebsiteDataStore swapping to main frame navigations
3461         https://bugs.webkit.org/show_bug.cgi?id=181217
3462
3463         Reviewed by Tim Horton.
3464
3465         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3466         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
3467         (TEST):
3468
3469 2018-01-05  Alex Christensen  <achristensen@webkit.org>
3470
3471         Add WKBundleFrameCreateFrameHandle
3472         https://bugs.webkit.org/show_bug.cgi?id=181232
3473         <rdar://problem/35926696>
3474
3475         Reviewed by Tim Horton.
3476
3477         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3478         * TestWebKitAPI/Tests/WebKitCocoa/FrameHandleSerialization.mm: Added.
3479         (mouseDidMoveOverElement):
3480         (-[FrameHandleSerialization webProcessPlugIn:didCreateBrowserContextController:]):
3481         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3482         (-[MouseMoveOverElementDelegate _webView:mouseDidMoveOverElement:withFlags:userInfo:]):
3483         (TEST):
3484
3485 2018-01-05  Chris Fleizach  <cfleizach@apple.com>
3486
3487         iOS: Build fix after r226432.
3488         
3489         Unreviewed. Stop duplicating speakAs symbols for iOS.
3490
3491         * DumpRenderTree/AccessibilityUIElement.cpp:
3492         (AccessibilityUIElement::speakAs):
3493
3494 2018-01-05  Javier Fernandez  <jfernandez@igalia.com>
3495
3496         Unreviewed, added myself as WebKit reviewer
3497
3498         * Scripts/webkitpy/common/config/contributors.json:
3499
3500 2018-01-05  Claudio Saavedra  <csaavedra@igalia.com>
3501
3502         WPE: Build fix after r226432.
3503
3504         Unreviewed. Rename ::speak() to ::speakAs().
3505         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
3506         (WTR::AccessibilityUIElement::speakAs):
3507         (WTR::AccessibilityUIElement::speak): Deleted.
3508
3509 2018-01-04  Chris Fleizach  <cfleizach@apple.com>
3510
3511         AX: Implement updated CSS3 Speech for 'speak' and 'speak-as' properties
3512         https://bugs.webkit.org/show_bug.cgi?id=180361
3513
3514         Reviewed by Zalan Bujtas.
3515
3516         * DumpRenderTree/AccessibilityUIElement.cpp:
3517         (speakAsCallback):
3518         (AccessibilityUIElement::speakAs):
3519         (AccessibilityUIElement::getJSClass):
3520         (speakCallback): Deleted.
3521         (AccessibilityUIElement::speak): Deleted.
3522         * DumpRenderTree/AccessibilityUIElement.h:
3523         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3524         (AccessibilityUIElement::speakAs):
3525         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3526         (AccessibilityUIElement::speakAs):
3527         (AccessibilityUIElement::speak): Deleted.
3528         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3529         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3530         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3531         (WTR::AccessibilityUIElement::speakAs):
3532         (WTR::AccessibilityUIElement::speak): Deleted.
3533         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3534         (WTR::AccessibilityUIElement::speakAs):
3535         (WTR::AccessibilityUIElement::speak): Deleted.
3536
3537 2018-01-04  Jonathan Bedard  <jbedard@apple.com>
3538
3539         REGRESSION (r226395): test-webkitperl test expectations incorrect
3540         https://bugs.webkit.org/show_bug.cgi?id=181307
3541         <rdar://problem/36306558>
3542
3543         Rubber-stamped by Aakash Jain.
3544
3545         r226395 added two lines towards the beginning of
3546         Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl, the line
3547         numbers in the test expectations need to update.
3548
3549         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
3550
3551 2018-01-04  Tim Horton  <timothy_horton@apple.com>
3552
3553         WKWebView loses minimum layout size overrides that happen while the process is terminated
3554         https://bugs.webkit.org/show_bug.cgi?id=181306
3555         <rdar://problem/34398288>
3556
3557         Reviewed by Dan Bernstein.
3558
3559         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
3560         (TEST):
3561         Add a test that calling _overrideLayoutParametersWithMinimumLayoutSize
3562         while the process is terminated results in the page getting the correct
3563         minimum layout size.
3564
3565 2018-01-04  Eric Carlson  <eric.carlson@apple.com>
3566
3567         [MediaStream] Add Mock screen capture source
3568         https://bugs.webkit.org/show_bug.cgi?id=181291
3569         <rdar://problem/36298164>
3570
3571         Reviewed by Dean Jackson.
3572
3573         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test.
3574         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
3575         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
3576
3577 2018-01-04  Lucas Forschler  <lforschler@apple.com>
3578
3579         <rdar://problem/36300930> Change proxy server setting on master config to reach s3 servers
3580
3581         Reviewed by Ling Ho.
3582
3583         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3584
3585 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
3586
3587         [Attachment Support] Create attachment elements when dropping files on iOS
3588         https://bugs.webkit.org/show_bug.cgi?id=181192
3589         <rdar://problem/36280945>
3590
3591         Reviewed by Tim Horton.
3592
3593         Adds 3 new API tests to exercise different use cases of dropping content as attachment elements when the runtime
3594         switch is enabled. See below for more details.
3595
3596         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3597         (-[NSItemProvider registerData:type:]):
3598         (platformCopyPNG):
3599         (TestWebKitAPI::TEST):
3600         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3601
3602         Fix some currently failing iOS drag and drop tests. In this case, there's no reason RTFD should appear in the
3603         source item provider when dragging rich text *without* attachments, so this should have been a check for just
3604         kUTTypeRTF instead.
3605
3606         (TestWebKitAPI::TEST):
3607
3608         Tests a few cases of inserting attachment elements via drop:
3609         1.  We should distinguish between drops containing rich/plain text files from just dropping rich/plain text.
3610             Instead of inserting the contents as inline web content, this should generate attachment elements.
3611         2.  Test the fallback mechanism for inserting attachment elements. If the preferred presentation style is not
3612             explicitly set, but there's nothing WebKit would otherwise do with the dropped content, then we should fall
3613             back to inserting the content as an attachment.
3614         3.  Test that if multiple attachments and inline item providers are present, WebKit will respect the order in
3615             which they were inserted by the source (as opposed to, for instance, putting all of the attachments in front
3616             or at the end).
3617
3618         * TestWebKitAPI/cocoa/TestWKWebView.h:
3619         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3620         (-[TestWKWebView objectByEvaluatingJavaScript:]):
3621
3622         Add a helper method to return an object that represents the result of evaluating some given script, and rewrite
3623         -stringByEvaluatingJavaScript to just turn around and call this.
3624
3625         (-[TestWKWebView stringByEvaluatingJavaScript:]):
3626
3627 2018-01-03  Ting-Wei Lan  <lantw44@gmail.com>
3628
3629         Replace hard-coded paths in shebangs with #!/usr/bin/env
3630         https://bugs.webkit.org/show_bug.cgi?id=181040
3631
3632         Reviewed by Alex Christensen.
3633
3634         * BuildSlaveSupport/build-launcher-app:
3635         * BuildSlaveSupport/build-launcher-dmg:
3636         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3637         * BuildSlaveSupport/built-product-archive: