2011-02-03 Martin Robinson <mrobinson@igalia.com>
[WebKit-https.git] / Tools / ChangeLog
1 2011-02-03  Martin Robinson  <mrobinson@igalia.com>
2
3         Reviewed by Eric Seidel.
4
5         [GTK] The GTK+ DRT needs an implementation of the PlainTextController
6         https://bugs.webkit.org/show_bug.cgi?id=53605
7
8         Add an implementation of the PlainTextController for the GTK+ DRT.
9
10         * DumpRenderTree/gtk/DumpRenderTree.cpp:
11         (addControllerToWindow): Added this helper method.
12         (webViewWindowObjectCleared): Use the new helper to add EventSender
13         and the PlainTextController to the window object.
14         * GNUmakefile.am: Added PlainTextController source files.
15         * DumpRenderTree/gtk/PlainTextController.cpp: Added. This will rely
16         on DumpRenderTreeSupportGtk to convert a JSValueRef into a WebKitDOMRange
17         until that functionality exists somewhere in the WebKitGTK+ stack.
18         * DumpRenderTree/gtk/PlainTextController.h: Added.
19
20 2011-04-11  Yael Aharon  <yael.aharon@nokia.com>
21
22         Unreviewed.
23
24         Adding my IRC nick.
25
26         * Scripts/webkitpy/common/config/committers.py:
27
28 2011-04-11  Dirk Pranke  <dpranke@chromium.org>
29
30         Reviewed by Adam Roben.
31
32         new-run-webkit-tests: fix crash when running under windows cmd.exe
33         https://bugs.webkit.org/show_bug.cgi?id=58197
34
35         We would intermittently crash when running NRWT directly under
36         cmd.exe on windows because we were sharing the stdin file
37         descriptor between the python process and the http server.
38         cmd.exe really didn't like that, and there was no reason to
39         share the descriptor, so we now use a PIPE instead.
40
41         * Scripts/webkitpy/layout_tests/port/http_server.py:
42
43 2011-04-11  Dirk Pranke  <dpranke@chromium.org>
44
45         Reviewed by Ojan Vafai.
46
47         new-run-webkit-tests: add unit tests for Port.diff_image()
48         https://bugs.webkit.org/show_bug.cgi?id=58196
49
50         Add the unit tests for the fix in bug 58195.
51
52         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
53         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
54         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
55
56 2011-04-11  Dirk Pranke  <dpranke@chromium.org>
57
58         Reviewed by Tony Chang.
59
60         new-run-webkit-tests: implement support for audio, take two
61         https://bugs.webkit.org/show_bug.cgi?id=58195
62
63         Attempt to re-land the fix for bug 58101 (which was initially
64         landed in r83330, but rolled out). This is the same patch but
65         fixes crashes in Port.diff_image() caused by the change for
66         empty image files being None instead of ''.
67
68         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
69         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
70         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
71         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
72         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
73         * Scripts/webkitpy/layout_tests/port/base.py:
74         * Scripts/webkitpy/layout_tests/port/chromium.py:
75         * Scripts/webkitpy/layout_tests/port/dryrun.py:
76         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
77         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
78         * Scripts/webkitpy/layout_tests/port/test.py:
79         * Scripts/webkitpy/layout_tests/port/webkit.py:
80
81 2011-04-11  Mario Sanchez Prada  <msanchez@igalia.com>
82
83         Reviewed by Xan Lopez.
84
85         [GTK] Implement AccessibilityUIElement::{row|column}IndexRange in DRT
86         https://bugs.webkit.org/show_bug.cgi?id=57854
87
88         Implement missing features in GTK's DRT.
89
90         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
91         (indexRangeInTable): New helper function to get the range string
92         for the current cell inside the parent table, either from the
93         point of view of rows or columns.
94         (AccessibilityUIElement::rowIndexRange): Implemented by relying on
95         the new helper function indexRangeInTable().
96         (AccessibilityUIElement::columnIndexRange): Ditto.
97
98 2011-04-11  Mario Sanchez Prada  <msanchez@igalia.com>
99
100         Reviewed by Chris Fleizach.
101
102         [GTK] Implement AccessibilityUIElement::cellForColumnAndRow in DRT
103         https://bugs.webkit.org/show_bug.cgi?id=57826
104
105         Implement missing feature in GTK's DRT.
106
107         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
108         (AccessibilityUIElement::cellForColumnAndRow): Implemented, by
109         relying on the analogous function from the AtkTable interface.
110
111 2011-04-05  Timothy Hatcher  <timothy@apple.com>
112
113         Fix the extract-localizable-strings script errors that started after
114         WEB_UI_STRING was added to LocalizedStrings.h in WebCore.
115
116         * Scripts/extract-localizable-strings: Skip LocalizedStrings.h.
117
118 2011-04-11  Tony Chang  <tony@chromium.org>
119
120         Reviewed by Eric Seidel.
121
122         fix crc computation on 64 bit machines
123         https://bugs.webkit.org/show_bug.cgi?id=58243
124
125         unsigned long is dependenct on CPU architecture, so use unsigned which is always 32 bits
126
127         * DumpRenderTree/CyclicRedundancyCheck.cpp:
128         (makeCrcTable):
129         (computeCrc):
130         * DumpRenderTree/CyclicRedundancyCheck.h:
131         * DumpRenderTree/PixelDumpSupport.cpp:
132         (appendIntToVector):
133         (convertChecksumToPNGComment):
134
135 2011-04-10  Kimmo Kinnunen  <kimmo.t.kinnunen@nokia.com>
136
137         Reviewed by Eric Seidel.
138
139         Require no undefined symbols during compilation.
140
141         [Qt] [WK2] WebKitTestRunner, QtWebProcess and WTRInjectBundle should fail to compile when there's undefined symbols
142         https://bugs.webkit.org/show_bug.cgi?id=54896
143
144         Add -Wl,--no-undefined to catch missing symbols early.
145
146         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
147         * WebKitTestRunner/qt/WebKitTestRunner.pro:
148
149 2011-04-10  Kevin Ollivier  <kevino@theolliviers.com>
150
151         [wx] Unreviewed build fix. Remove collector dirs from the list of build dirs.
152
153         * wx/build/settings.py:
154
155 2011-04-10  Kevin Ollivier  <kevino@theolliviers.com>
156
157         [wx] Unreviewed build fix. Add Source/JavaScriptCore/heap to the list of directories.
158
159         * wx/build/settings.py:
160
161 2011-04-10  David Levin  <levin@chromium.org>
162
163         Reviewed by Dimitri Glazkov.
164
165         REGRESSION(r83384): Change to chromium.py is resulting in failures of the test framework on linux.
166         https://bugs.webkit.org/show_bug.cgi?id=58201
167
168         * Scripts/webkitpy/layout_tests/port/chromium.py: Commented out the assert for now,
169         and filed bug 58202.
170
171 2011-04-09  David Levin  <levin@chromium.org>
172
173         Unreviewed, rolling out r83394.
174         http://trac.webkit.org/changeset/83394
175         https://bugs.webkit.org/show_bug.cgi?id=53625
176
177         Patch was incorrect as noted in the bug.
178
179         * Scripts/svn-apply:
180
181 2011-04-09  David Levin  <levin@chromium.org>
182
183         Reviewed by Adam Barth.
184
185         svn-apply and/or patch(1) has trouble applying patches that makes changes to files with Windows line endings
186         https://bugs.webkit.org/show_bug.cgi?id=53625
187
188         * Scripts/svn-apply: Ensure that the portions of patches
189         which are for vcproj/vsprops files has DOS line endings.
190
191 2011-04-09  Dirk Pranke  <dpranke@chromium.org>
192
193         Reviewed by Tony Chang.
194
195         It looks like NRWT has not been stopping DRT/TestShell
196         instances properly on windows, probably for a long time.
197         This would go a long way to explaining why we often have
198         processes lying around :)
199
200         https://bugs.webkit.org/show_bug.cgi?id=57807
201
202         * Scripts/webkitpy/layout_tests/port/chromium.py:
203         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
204
205 2011-04-09  Keith Kyzivat  <keith.kyzivat@nokia.com>
206
207         Reviewed by Laszlo Gombos.
208
209         [Qt] Don't link against fontconfig or X11 if embedded
210         https://bugs.webkit.org/show_bug.cgi?id=58104
211
212         * DumpRenderTree/qt/DumpRenderTree.pro: fontconfig !included in embedded
213         * QtTestBrowser/QtTestBrowser.pro: ditto
214         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: ditto
215         * WebKitTestRunner/qt/WebKitTestRunner.pro: ditto
216
217 2011-04-08  Jon Honeycutt  <jhoneycutt@apple.com>
218
219         http/tests/loading/preload-append-scan.php is failing on Windows
220         https://bugs.webkit.org/show_bug.cgi?id=58178
221
222         Reviewed by Brian Weinstein.
223
224         * DumpRenderTree/win/DumpRenderTree.cpp:
225         (lastPathComponent):
226         Use CFURL API to find the last path component, rather than
227         PathFindFileName(), because the latter will include the query string.
228
229 2011-04-08  Jian Li  <jianli@chromium.org>
230
231         Unreviewed, rolling out r83327, r83330 since these patches are very
232         likely to break chromium webkit mac10.6 builders.
233
234         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
235         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
236         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
237         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
238         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
239         * Scripts/webkitpy/layout_tests/port/base.py:
240         * Scripts/webkitpy/layout_tests/port/chromium.py:
241         * Scripts/webkitpy/layout_tests/port/dryrun.py:
242         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
243         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
244         * Scripts/webkitpy/layout_tests/port/test.py:
245         * Scripts/webkitpy/layout_tests/port/webkit.py:
246
247 2011-04-08  Vincent Scheib  <scheib@chromium.org>
248
249         Reviewed by Eric Seidel.
250
251         add chromium-gpu-linux-x86_64 to the recognized list of ports
252         https://bugs.webkit.org/show_bug.cgi?id=58099
253
254         Add chromium-gpu-linux-x86_64 to fix assert.
255
256         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
257
258 2011-04-08  Alpha Lam  <hclam@chromium.org>
259
260         Unreviewed, rolling out r83335.
261         http://trac.webkit.org/changeset/83335
262         https://bugs.webkit.org/show_bug.cgi?id=53556
263
264         GTK and QT bots are broken
265
266         * Scripts/build-webkit:
267
268 2011-04-07  Anna Cavender  <annacc@chromium.org>
269
270         Reviewed by Eric Carlson.
271
272         Setup ENABLE(TRACK) feature define
273         https://bugs.webkit.org/show_bug.cgi?id=53556
274
275         * Scripts/build-webkit:
276
277 2011-04-08  Dirk Pranke  <dpranke@chromium.org>
278
279         Reviewed by Adam Roben.
280
281         new-run-webkit-tests: configure a NRWT test bot for Mac SL
282         https://bugs.webkit.org/show_bug.cgi?id=58114
283
284         This change removes the old new-run-webkit-tests entry and
285         updates it for a new test-only bot.
286
287         * BuildSlaveSupport/build.webkit.org-config/config.json:
288
289 2011-04-08  Dominic Cooney  <dominicc@google.com>
290
291         Reviewed by Adam Roben.
292
293         Make layoutTestController.shadowRoot return null, not undefined,
294         when its argument is invalid.
295         https://bugs.webkit.org/show_bug.cgi?id=58121
296
297         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
298         (LayoutTestController::shadowRoot):
299         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
300         (WTR::LayoutTestController::shadowRoot):
301
302 2011-04-08  Pere Martir  <pere.martir4@gmail.com>
303
304         Reviewed by Adam Roben.
305
306         Locate NSTD.EXE in 64-bit Windows
307         https://bugs.webkit.org/show_bug.cgi?id=57847
308
309         * Scripts/old-run-webkit-tests:
310
311 2011-04-08  Adam Roben  <aroben@apple.com>
312
313         Qt build fix
314
315         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Pull in stdarg.h for va_list.
316
317 2011-04-07  Adam Roben  <aroben@apple.com>
318
319         Test that NPP_SetWindow is passed a null window handle during plugin destruction on non-Mac platforms
320
321         Test for <http://webkit.org/b/47009> WebKit2 needs to call NPP_SetWindow when destroying a
322         plugin
323
324         Reviewed by Anders Carlsson.
325
326         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
327         (pluginLogWithArguments): Moved code to format and log the message here...
328         (pluginLog): ...from here.
329
330         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Added pluginLogWithArguments.
331
332         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
333         (PluginTest::log): Added. Calls through to pluginLogWithArguments.
334
335         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added log.
336
337         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPSetWindowCalledDuringDestruction.cpp: Added.
338         (NPPSetWindowCalledDuringDestruction::setWillBeDestroyed): Records that destruction is about
339         to begin.
340         (NPPSetWindowCalledDuringDestruction::NPPSetWindowCalledDuringDestruction): Simple
341         constructor.
342         (NPPSetWindowCalledDuringDestruction::NPP_GetValue): Creates and returns a ScriptObject that
343         can be used to invoke our setWillBeDestroyed function.
344         (NPPSetWindowCalledDuringDestruction::NPP_SetWindow): Records what has happened (and logs if
345         anything unexpected happens).
346         (NPPSetWindowCalledDuringDestruction::NPP_Destroy): On Mac, logs a failure message if
347         NPP_SetWindow was called during destruction. On other platforms, logs a failure message if
348         NPP_SetWindow was *not* called during destruction.
349         (NPPSetWindowCalledDuringDestruction::ScriptObject::hasMethod): Return true for our only
350         method, setWillBeDestroyed.
351         (NPPSetWindowCalledDuringDestruction::ScriptObject::invoke): Call through to the PluginTest
352         object.
353
354         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
355         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
356         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
357         * GNUmakefile.am:
358         Added new test.
359
360         * Scripts/old-run-webkit-tests: Skip the new test when using out-of-process plugins with
361         WebKit1 on Mac, since it can't work properly due to <http://webkit.org/b/58077>.
362
363 2011-04-08  Mario Sanchez Prada  <msanchez@igalia.com>
364
365         Reviewed by Martin Robinson.
366
367         [GTK] Implement increment() and decrement() functions in DRT's AccessibilityUIElement
368         https://bugs.webkit.org/show_bug.cgi?id=58039
369
370         Implement missing functions in GTK's DRT.
371
372         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
373         (AccessibilityUIElement::increment): Implemented.
374         (AccessibilityUIElement::decrement): Implemented.
375
376 2011-04-08  Dominic Cooney  <dominicc@google.com>
377
378         Reviewed by Kent Tamura.
379
380         Make WK2 layoutTestController.shadowRoot return undefined, not
381         null, when its argument is not an element.
382         https://bugs.webkit.org/show_bug.cgi?id=58121
383
384         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
385         (WTR::LayoutTestController::shadowRoot):
386
387 2011-04-07  Dirk Pranke  <dpranke@chromium.org>
388
389         Reviewed by Mihai Parparita.
390
391         Change reference port for Mac GPU baselines from
392         Leopard to SnowLeopard, XP to Win7, and Linux-x86
393         to Linux x86-64.
394
395         https://bugs.webkit.org/show_bug.cgi?id=58099
396
397         * Scripts/webkitpy/layout_tests/port/chromium.py:
398
399 2011-04-07  Andrew Scherkus  <scherkus@chromium.org>
400
401         Revert ENABLE_TRACK patch due to compile failures.
402
403         * Scripts/build-webkit:
404
405 2011-04-07  Tony Chang  <tony@chromium.org>
406
407         Reviewed by Eric Seidel.
408
409         update DRT to embed checksums in png files
410         https://bugs.webkit.org/show_bug.cgi?id=57871
411
412         We insert the bytes for the comment in printPNG rather than at encode
413         time because each platform does its own PNG encoding (either using CG
414         or cairo).  Putting this in pringPNG avoids having to duplicate this
415         code, although it's not as clean as doing it at encoding time.
416
417         We insert the comment right after the IHDR chunk of the PNG.
418
419         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
420         * DumpRenderTree/CyclicRedundancyCheck.cpp: Added.
421         (makeCrcTable): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js
422         (computeCrc): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js
423         * DumpRenderTree/CyclicRedundancyCheck.h: Added.
424         * DumpRenderTree/PixelDumpSupport.cpp:
425         (dumpWebViewAsPixelsAndCompareWithExpected):
426         (convertChecksumToPNGComment): Generate the bytes to insert.
427         (printPNG): Insert the png comment before the first IDAT section.
428         * DumpRenderTree/PixelDumpSupport.h:
429         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
430         (printPNG):
431         (dumpBitmap):
432         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
433         (printPNG):
434         (dumpBitmap):
435         * DumpRenderTree/win/DumpRenderTree.vcproj:
436         * GNUmakefile.am:
437
438 2011-04-07  Jeff Miller  <jeffm@apple.com>
439
440         Reviewed by Adam Roben.
441
442         Replace WKStringGetCharactersPtr() with WKStringGetCharacters()
443         https://bugs.webkit.org/show_bug.cgi?id=58058
444
445         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
446         (TestWebKitAPI::TEST): Add tests for  WKStringGetLength() and WKStringGetCharactersPtr().
447
448 2011-04-07  Chang Shu  <cshu@webkit.org>
449
450         Reviewed by Darin Adler.
451
452         WebKitTestRunner needs layoutTestController.isPageBoxVisible
453         https://bugs.webkit.org/show_bug.cgi?id=42695
454
455         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
456         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
457         (WTR::LayoutTestController::isPageBoxVisible):
458         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
459
460 2011-04-07  Adam Roben  <aroben@apple.com>
461
462         Build fix
463
464         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added a missing import.
465
466 2011-04-07  Adam Roben  <aroben@apple.com>
467
468         Move ExtractTestResults[AndLeaks]'s summarizing code back from commandComplete() to finished()
469
470         commandComplete() is never called for MasterShellCommands like ExtractTestResults[AndLeaks].
471         (Unfortunately the buildbot documentation does not make this clear.) finished() is the only
472         hook we have, so we have to do our work there. I added a new addCustomURLs method which can
473         be overridden by subclasses to provide extra URLs before we call up to the base class (after
474         which adding more URLs is no longer possible).
475
476         Really hopefully fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks
477         bot results page
478
479         Reviewed by John Sullivan.
480
481         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
482         (ExtractTestResults.addCustomURLs): Moved code to add the "view results" URL here...
483         (ExtractTestResults.finished): ...from here. This replaces commandComplete, since that
484         method is never called for MasterShellCommands.
485         (ExtractTestResultsAndLeaks.addCustomURLs): Replaced commandComplete (which is never called)
486         with this method (which is).
487
488 2011-04-07  Adam Roben  <aroben@apple.com>
489
490         Move ExtractTestResults[AndLeaks]'s summarizing code from finished() to commandComplete()
491
492         This matches how most of our other build steps work, so is good just for improving
493         consistency between build steps. It should also make it possible for
494         ExtractTestResultsAndLeaks to successfully add a URL to Leaks Viewer. (Previously we were
495         trying to do this in finished() after we had called up to the base class, but that was
496         apparently too late to add more URLs.)
497
498         Hopefully fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot
499         results page
500
501         Reviewed by John Sullivan.
502
503         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
504         (ExtractTestResults): Added a descriptionDone property so that we don't have to manually
505         call setText to get the right text to show up for this step. This matches how most of our
506         other build steps work.
507         (ExtractTestResults.commandComplete): Replaced our override of finished with this function.
508         This is how most of our other build steps work.
509         (ExtractTestResultsAndLeaks.commandComplete): Replaced our override of finished with this
510         function, to match the base class.
511
512 2011-04-07  Adam Barth  <abarth@webkit.org>
513
514         Reviewed by Maciej Stachowiak.
515
516         webkit-patch shouldn't state the whole working copy when calling check-webkit-style
517         https://bugs.webkit.org/show_bug.cgi?id=58022
518
519         Previously, we were ignoring the args variable!  This patch fixes the
520         regression introduced in http://trac.webkit.org/changeset/82771.
521
522         * Scripts/webkitpy/tool/commands/download_unittest.py:
523         * Scripts/webkitpy/tool/mocktool.py:
524         * Scripts/webkitpy/tool/steps/checkstyle.py:
525
526 2011-04-07  Maciej Stachowiak  <mjs@apple.com>
527
528         Reviewed by Adam Barth.
529
530         REGRESSION: "webkit-patch land" doesn't work correctly in SVN subdirectories
531         https://bugs.webkit.org/show_bug.cgi?id=58017
532
533         * Scripts/webkitpy/common/checkout/scm.py:
534         * Scripts/webkitpy/common/checkout/scm_unittest.py:
535
536 2011-04-06  Chang Shu  <cshu@webkit.org>
537
538         Reviewed by Darin Adler.
539
540         WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels
541         https://bugs.webkit.org/show_bug.cgi?id=57984
542
543         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
544         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
545         (WTR::LayoutTestController::pageSizeAndMarginsInPixels):
546         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
547
548 2011-04-06  Chris Rogers  <crogers@google.com>
549
550         Reviewed by Tony Chang.
551
552         Add web audio support to DumpRenderTree (mac port)
553         https://bugs.webkit.org/show_bug.cgi?id=57969
554
555         * DumpRenderTree/LayoutTestController.cpp:
556         (LayoutTestController::LayoutTestController):
557         (setEncodedAudioDataCallback):
558         (LayoutTestController::staticFunctions):
559         * DumpRenderTree/LayoutTestController.h:
560         (LayoutTestController::dumpAsAudio):
561         (LayoutTestController::setDumpAsAudio):
562         (LayoutTestController::encodedAudioData):
563         (LayoutTestController::setEncodedAudioData):
564         * DumpRenderTree/mac/DumpRenderTree.mm:
565         (dumpAudio):
566         (dump):
567
568 2011-04-06  Benjamin Poulain  <benjamin.poulain@nokia.com>
569
570         Reviewed by Kenneth Rohde Christiansen.
571
572         [Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
573         https://bugs.webkit.org/show_bug.cgi?id=56086
574
575         Add the missing method.
576
577         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
578         (WebCore::DumpRenderTree::getAllPages): Add a method to return all the pages allocated for the current test.
579         * DumpRenderTree/qt/DumpRenderTreeQt.h:
580         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
581         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
582
583 2011-04-06  Dai Mikurube  <dmikurube@chromium.org>
584
585         Reviewed by David Levin.
586
587         Add QUOTA build flag for unified quota API
588         https://bugs.webkit.org/show_bug.cgi?id=57918
589
590         * Scripts/build-webkit: Added QUOTA build flag
591
592 2011-04-06  Dirk Pranke  <dpranke@chromium.org>
593
594         Reviewed by Tony Chang.
595
596         Adjust the apple webkit port's default timeout to match
597         old-run-webkit-tests at 35 seconds.
598
599         https://bugs.webkit.org/show_bug.cgi?id=37738
600
601         * Scripts/webkitpy/layout_tests/port/mac.py:
602
603 2011-04-06  Scott Cameron  <sccameron@rim.com>
604
605         Reviewed by Eric Seidel.
606
607         Remove global variable $httpdPath and replace with the return value of
608         getHTTPDPath().  Also remove unnecessary calls to getHTTPDPath().
609         https://bugs.webkit.org/show_bug.cgi?id=53499
610
611         * Scripts/run-iexploder-tests:
612         * Scripts/webkitperl/httpd.pm:
613
614 2011-04-06  Kevin Ollivier  <kevino@theolliviers.com>
615
616         Reviewed by Darin Adler.
617
618         Make sure JS_EXPORT_PRIVATE is an empty define when we aren't using the export macros.
619         
620         https://bugs.webkit.org/show_bug.cgi?id=27551
621         
622         * DumpRenderTree/config.h:
623         * WebKitAPITest/config.h:
624         * WebKitTestRunner/config.h:
625
626 2011-04-06  Tony Chang  <tony@chromium.org>
627
628         Reviewed by Darin Adler.
629
630         teach run-webkit-tests to read checksums from png files
631         https://bugs.webkit.org/show_bug.cgi?id=57993
632
633         * Scripts/old-run-webkit-tests: Read the first 2k of a .png if there's
634           no .checksum and look for the checksum in there.
635
636 2011-04-06  David Dorwin  <ddorwin@chromium.org>
637
638         Reviewed by David Levin.
639
640         Enable fullscreen layout tests for Chromium
641         https://bugs.webkit.org/show_bug.cgi?id=55726
642
643         Make DumpRenderTree always run with fullscreen enabled (equivalent of --enable-fullscreen).
644
645         * DumpRenderTree/chromium/WebPreferences.cpp:
646         (WebPreferences::applyTo):
647
648 2011-04-06  Adam Roben  <aroben@apple.com>
649
650         Add a "view leaks" link to builds on SnowLeopard Intel Leaks
651
652         Fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot results page
653
654         Reviewed by David Kilzer.
655
656         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
657         (ExtractTestResults.resultDirectoryURL): Added. Moved code to calculate the URL for the
658         build's results directory here...
659         (ExtractTestResults.finished): ...from here.
660         (ExtractTestResultsAndLeaks): New class that's used by the leaks builder
661         (ExtractTestResultsAndLeaks.finished): Calls up to the base class, but also adds a "view
662         leaks" link to point to Leaks Viewer for this build.
663         (TestFactory): Added ExtractTestResultsClass abstraction. This isn't overridden anywhere,
664         but it seemed good to add for consistency with BuildAndTestFactory.
665         (BuildAndTestFactory): Added ExtractTestResultsClass abstraction.
666         (BuildAndTestLeaksFactory): Use ExtractTestResultsAndLeaks as our ExtractTestResultsClass so
667         that we'll get a "view leaks" link.
668
669 2011-04-06  Zan Dobersek  <zandobersek@gmail.com>
670
671         Reviewed by Eric Seidel.
672
673         [Gtk] plugins/set-status.html fails
674         https://bugs.webkit.org/show_bug.cgi?id=57844
675
676         Allow an empty status text to be dumped.
677
678         * DumpRenderTree/gtk/DumpRenderTree.cpp:
679         (webViewStatusBarTextChanged):
680
681 2011-04-06  Chang Shu  <cshu@webkit.org>
682
683         Reviewed by Darin Adler.
684
685         WebKitTestRunner needs layoutTestController.pageNumberForElementById
686         https://bugs.webkit.org/show_bug.cgi?id=42329
687
688         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
689         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
690         (WTR::LayoutTestController::pageNumberForElementById):
691         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
692
693 2011-04-06  Sergio Villar Senin  <svillar@igalia.com>
694
695         Reviewed by Martin Robinson.
696
697         [GTK] DumpRenderTree: do not try to free NULL SoupURIs
698         https://bugs.webkit.org/show_bug.cgi?id=57932
699
700         Some Layout tests have invalid URIs that do not generate valid
701         SoupURI instances. Do not try to free those NULL SoupURIs.
702
703         * DumpRenderTree/gtk/DumpRenderTree.cpp:
704         (willSendRequestCallback):
705
706 2011-04-06  Csaba Osztrogonác  <ossy@webkit.org>
707
708         Reviewed by Andreas Kling.
709
710         ORWT shouldn't generate diff files for tests without expected files
711         https://bugs.webkit.org/show_bug.cgi?id=57846
712
713         * Scripts/old-run-webkit-tests:
714
715 2011-04-05  Kevin Ollivier  <kevino@theolliviers.com>
716
717         [wx] Mac build fix. Handle cases where 10.4 SDK is not installed, and also add x86_64 arch
718         to deps.
719
720         * wx/install-unix-extras:
721
722 2011-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
723
724         Unreviewed, rolling out r82978, r82999, and r83001.
725         http://trac.webkit.org/changeset/82978
726         http://trac.webkit.org/changeset/82999
727         http://trac.webkit.org/changeset/83001
728         https://bugs.webkit.org/show_bug.cgi?id=57913
729
730         Does not work in Python 2.5 (Requested by abarth on #webkit).
731
732         * Scripts/webkitpy/common/system/executive.py:
733         * Scripts/webkitpy/common/system/executive_unittest.py:
734
735 2011-04-05  Chang Shu  <cshu@webkit.org>
736
737         Reviewed by Darin Adler.
738
739         WebKitTestRunner needs layoutTestController.numberOfPages
740         https://bugs.webkit.org/show_bug.cgi?id=42694
741
742         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
743         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
744         (WTR::LayoutTestController::numberOfPages):
745         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
746
747 2011-04-05  Tony Chang  <tony@chromium.org>
748
749         Reviewed by Mihai Parparita.
750
751         [chromium] stop putting results downloaded from WebKit Linux in chromium-linux-x86_64
752         https://bugs.webkit.org/show_bug.cgi?id=57889
753
754         * Scripts/webkitpy/layout_tests/port/chromium.py:
755         * Scripts/webkitpy/layout_tests/port/test.py:
756         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
757
758 2011-04-05  Adam Barth  <abarth@webkit.org>
759
760         Silly with statement, from the future!
761
762         * Scripts/webkitpy/common/system/executive.py:
763
764 2011-04-05  Adam Barth  <abarth@webkit.org>
765
766         Reviewed by Tony Chang.
767
768         Don't use Exception.message because it's deprecated
769         https://bugs.webkit.org/show_bug.cgi?id=57892
770
771         Suppress the warning for now.  When we move to Python 3, we might need
772         to something more dramatic.
773
774         * Scripts/webkitpy/common/system/executive.py:
775
776 2011-04-05  Mihai Parparita  <mihaip@chromium.org>
777
778         Reviewed by Ojan Vafai.
779
780         Add builders.js to dashboard file list
781         https://bugs.webkit.org/show_bug.cgi?id=57899
782
783         Add file added by http://crrev.com/80538 to dashboard file list.
784
785         * TestResultServer/handlers/dashboardhandler.py:
786
787 2011-04-05  MORITA Hajime  <morrita@google.com>
788
789         Reviewed by Adam Barth.
790
791         webkit-patch should print git's stderr when git svn dcommit fail
792         http://webkit.org/b/57861
793
794         * Scripts/webkitpy/common/checkout/scm.py:
795
796 2011-04-05  Mihai Parparita  <mihaip@chromium.org>
797
798         Reviewed by Tony Chang.
799
800         Add --baseline-search-path to NRWT
801         https://bugs.webkit.org/show_bug.cgi?id=56233
802         
803         Add NRWT option to specify additional directories to look for baselines
804         (will be used by hardware GPU bots which will have local per-bot
805         expectations for some tests)
806
807         * Scripts/webkitpy/common/system/filesystem_mock.py:
808         * Scripts/webkitpy/layout_tests/port/base.py:
809         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
810         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
811
812 2011-04-05  Adam Roben  <aroben@apple.com>
813
814         Strip off /results.html from results URLs before trying to load leaks files from them
815
816         r82734 changed build.webkit.org's "view results" URLs to point straight to the results.html
817         files, rather than pointing to the directory that contains them. This is more convenient for
818         people browsing build.webkit.org, but confused Leaks Viewer.
819
820         Fixes <http://webkit.org/b/57869> REGRESSION (r82734): Links in Leaks Viewer's Recent Builds
821         list don't work
822
823         Reviewed by Joseph Pecoraro.
824
825         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
826         (RecentBuildsLoader.prototype.start): Strip off "/results.html" from the results URL.
827
828 2011-04-05  Carol Szabo  <carol@webkit.org>
829
830         Unreviewed.
831
832         Updated my info in committers.py
833
834         Scripts\webkitpy\common\config\committers.py 
835
836 2011-04-05  Csaba Osztrogonác  <ossy@webkit.org>
837
838         Reviewed by Laszlo Gombos.
839
840         [Qt] Make WebKitLibraries optional for building QtWebKit
841         https://bugs.webkit.org/show_bug.cgi?id=57542
842
843         * Scripts/build-webkit:
844
845 2011-04-05  Chang Shu  <cshu@webkit.org>
846
847         Reviewed by Laszlo Gombos.
848
849         [Qt] MiniBrowser defaultUrl does not work
850         https://bugs.webkit.org/show_bug.cgi?id=57021
851
852         Match the behavior and coding of MiniBrowser to QtTestBrowser.
853         * MiniBrowser/qt/main.cpp:
854         (main):
855
856 2011-04-05  Jade Han  <jade.han@nokia.com>
857
858         Reviewed by Laszlo Gombos.
859
860         [Qt] [Symbian] Disable WebKitTestRunner for Symbian
861         https://bugs.webkit.org/show_bug.cgi?id=54977
862
863         This change is a preparation to enable building webkit2 for Symbian.
864         Bug 57834 is filed to fix and enable WebKitTestRunner for Symbian.
865
866         * Tools.pro:
867
868 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
869
870         Reviewed by Andreas Kling.
871
872         [Qt] Fix timeoutTimer of MiniBrowser's UrlLoader
873         https://bugs.webkit.org/show_bug.cgi?id=57832
874
875         Only QWKPage has loadFinished signal so connect to it instead of BrowserWindow.
876
877         * MiniBrowser/qt/UrlLoader.cpp:
878         (UrlLoader::UrlLoader):
879
880 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
881
882         [Qt] Linux Release minimal build fix after r82919.
883
884         * MiniBrowser/qt/BrowserWindow.cpp:
885         (BrowserWindow::loadURLListFromFile):
886         * QtTestBrowser/launcherwindow.cpp:
887         (LauncherWindow::loadURLListFromFile):
888
889 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
890
891         Reviewed by Andreas Kling.
892
893         [Qt] Make URL loader accessible from testbrowser's menus
894         https://bugs.webkit.org/show_bug.cgi?id=57823
895
896         Add "Load URLs from file" to QtTestBrowser's and to MiniBrowser's menu.
897
898         * MiniBrowser/qt/BrowserWindow.cpp:
899         (BrowserWindow::BrowserWindow):
900         (BrowserWindow::loadURLListFromFile):
901         (BrowserWindow::~BrowserWindow):
902         * MiniBrowser/qt/BrowserWindow.h:
903         * QtTestBrowser/launcherwindow.cpp:
904         (LauncherWindow::LauncherWindow):
905         (LauncherWindow::~LauncherWindow):
906         (LauncherWindow::createChrome):
907         (LauncherWindow::loadURLListFromFile):
908         * QtTestBrowser/launcherwindow.h:
909
910 2011-04-04  Sam Weinig  <sam@webkit.org>
911
912         Reviewed by Brian Weinstein.
913
914         Remove duplicate API from WKContext
915         <rdar://problem/8727879>
916         https://bugs.webkit.org/show_bug.cgi?id=57815
917
918         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
919         * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Removed.
920         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
921         Remove SendingMessagesToTheWebProcessBeforeItIsValid since the API it was testing is now removed.
922
923 2011-04-04  Tony Chang  <tony@chromium.org>
924
925         Reviewed by Ojan Vafai.
926
927         [chromium] don't write .checksum files if a fallback platform has an embedded checksum
928         https://bugs.webkit.org/show_bug.cgi?id=57783
929
930         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
931         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
932
933 2011-04-04  Kevin Ollivier  <kevino@theolliviers.com>
934
935         [wx] Unreviewed build fix, run uninstall when cleaning to remove built files
936         from WebKitBuild.
937
938         * Scripts/webkitdirs.pm:
939
940 2011-04-04  Martin Robinson  <mrobinson@igalia.com>
941
942         Reviewed by Gustavo Noronha Silva.
943
944         [GTK] WebGL support
945         https://bugs.webkit.org/show_bug.cgi?id=31517
946
947         Add support to the DRT for turning on WebGL when a layout tests requests it.
948
949         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
950         (LayoutTestController::overridePreference): Allow turning on WebGL from tests.
951
952 2011-04-04  Chang Shu  <cshu@webkit.org>
953
954         Reviewed by Darin Adler.
955
956         WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
957         https://bugs.webkit.org/show_bug.cgi?id=57572
958
959         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
960         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
961         (WTR::LayoutTestController::setAllowFileAccessFromFileURLs):
962         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
963
964 2011-04-04  Keith Kyzivat  <keith.kyzivat@nokia.com>
965
966         Reviewed by Csaba Osztrogonác.
967
968         [Qt] DumpRenderTree breaks compilation in some uClibc environments
969         https://bugs.webkit.org/show_bug.cgi?id=57602
970
971         * DumpRenderTree/qt/main.cpp:
972         (get_backtrace):
973
974 2011-04-04  Kevin Ollivier  <kevino@theolliviers.com>
975
976         [wx] Unreviewed build fix, add new LayoutTestController method stub to wx.
977
978         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
979         (LayoutTestController::shadowRoot):
980
981 2011-04-04  Pavel Podivilov  <podivilov@chromium.org>
982
983         Unreviewed, fix exception in rebaseline tool.
984
985         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
986
987 2011-04-02  Beth Dakin  <bdakin@apple.com>
988
989         Rubber-stamped by Geoff Garen.
990
991         For Dan!
992         * DumpRenderTree/mac/DumpRenderTree.mm:
993         (resetWebViewToConsistentStateBeforeTesting):
994
995 2011-04-02  Beth Dakin  <bdakin@apple.com>
996
997         Rubber-stamped by Geoff Garen.
998
999         Need to reset the scale, much like zoom.
1000         * DumpRenderTree/mac/DumpRenderTree.mm:
1001         (resetWebViewToConsistentStateBeforeTesting):
1002
1003 2011-04-02  Sam Weinig  <sam@webkit.org>
1004
1005         Reviewed by Beth Dakin.
1006
1007         https://bugs.webkit.org/show_bug.cgi?id=57605
1008         Frame::pageScaleFactor() should not affect getBoundingClientRect() or 
1009         getClientRects()
1010         -and corresponding-
1011         <rdar://problem/9194541>
1012
1013         Add DRT support for the scaleWebView SPI.
1014         * DumpRenderTree/mac/EventSendingController.mm:
1015         (+[EventSendingController isSelectorExcludedFromWebScript:]):
1016         (+[EventSendingController webScriptNameForSelector:]):
1017         (-[EventSendingController scalePageBy:atX:andY:]):
1018         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1019         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1020         (WTR::EventSendingController::scalePageBy):
1021         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1022         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1023         (WTR::InjectedBundlePage::reset):
1024
1025 2011-04-02  Dominic Cooney  <dominicc@google.com>
1026
1027         Reviewed by Martin Robinson.
1028
1029         Add layoutTestController.shadowRoot to GTK DumpRenderTree.
1030         https://bugs.webkit.org/show_bug.cgi?id=57551
1031
1032         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1033         (LayoutTestController::shadowRoot):
1034
1035 2011-04-02  Patrick Gansterer  <paroga@webkit.org>
1036
1037         Reviewed by Eric Seidel.
1038
1039         Remove AbstractStep._run_script and move script names to ports.py
1040         https://bugs.webkit.org/show_bug.cgi?id=57704
1041
1042         Replace deprecated _run_script with _tool.executive.run_and_throw_if_fail.
1043
1044         * Scripts/webkitpy/common/config/ports.py:
1045         * Scripts/webkitpy/tool/commands/download_unittest.py:
1046         * Scripts/webkitpy/tool/commands/roll_unittest.py:
1047         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1048         * Scripts/webkitpy/tool/steps/abstractstep.py:
1049         * Scripts/webkitpy/tool/steps/checkstyle.py:
1050         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1051         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
1052         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1053
1054 2011-04-02  Patrick Gansterer  <paroga@webkit.org>
1055
1056         Reviewed by Eric Seidel.
1057
1058         Emulate shebang on Win32
1059         https://bugs.webkit.org/show_bug.cgi?id=55927
1060
1061         Scripts on Windows work only if they are called with the explicit interpreter.
1062         Read the first line of scripts to detect the correct executable.
1063
1064         * Scripts/webkitpy/common/config/ports.py:
1065         * Scripts/webkitpy/common/system/executive.py: Added interpreter_for_script().
1066         * Scripts/webkitpy/common/system/executive_unittest.py:
1067
1068 2011-04-01  Adam Barth  <abarth@webkit.org>
1069
1070         Reviewed by Eric Seidel.
1071
1072         apos entities shouldn't show up in ChangeLogs when using webkit-patch
1073         https://bugs.webkit.org/show_bug.cgi?id=57692
1074
1075         Previously, we were using BeautifulSoup to process XML from
1076         bugs.webkit.org, but that's incorrect.  We should be using
1077         BeautifulStoneSoup to process the XML.  We were getting the &apos;
1078         entity wrong because &apos; is an XML entity but not an HTML entity.
1079
1080         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1081         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1082
1083 2011-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1084
1085         Unreviewed, rolling out r82721.
1086         http://trac.webkit.org/changeset/82721
1087         https://bugs.webkit.org/show_bug.cgi?id=57687
1088
1089         This patch introduced assertion failures on the GTK+ bots.
1090         (Requested by mrobinson on #webkit).
1091
1092         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1093         (LayoutTestController::shadowRoot):
1094
1095 2011-04-01  Csaba Osztrogonác  <ossy@webkit.org>
1096
1097         Unreviewed buildfix.
1098
1099         [Qt][WK2] Build Webkit2 using "-2" option on Qt
1100         https://bugs.webkit.org/show_bug.cgi?id=55074
1101
1102         * Scripts/build-webkit: Ensure that "-2" isn't passed to qmake.
1103         (The isWK2() function removes it from @ARGV, but not from @options.)
1104
1105 2011-04-01  Keith Kyzivat  <keith.kyzivat@nokia.com>
1106
1107         Reviewed by Csaba Osztrogonác.
1108
1109         [Qt] [WK2] MiniBrowser.qrc not found - regression from rev 82671
1110         https://bugs.webkit.org/show_bug.cgi?id=57666
1111
1112         * MiniBrowser/qt/MiniBrowser.qrc: Renamed from Tools/MiniBrowser/MiniBrowser.qrc.
1113
1114 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
1115
1116         Reviewed by Adam Barth.
1117
1118         new-run-webkit-tests: fix feature detection, skipped platform lists on mac
1119
1120         We apparently never implemented the code to skip tests based on
1121         what was compiled into DRT. Also, change the logic used to skip
1122         platform directories to match what old-run-webkit-tests does: 
1123         skip every test not in a directory in the baseline search path.
1124
1125         https://bugs.webkit.org/show_bug.cgi?id=57662
1126
1127         * Scripts/webkitpy/layout_tests/port/mac.py:
1128         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1129         * Scripts/webkitpy/layout_tests/port/webkit.py:
1130
1131 2011-03-29  Mark Rowe  <mrowe@apple.com>
1132
1133         Reviewed by Jon Honeycutt.
1134
1135         <http://webkit.org/b/56730> new-run-webkit-tests fails on Lion seed
1136
1137         Teach new-run-webkit-tests about the concept of an unreleased version of Mac OS X.
1138
1139         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1140         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1141         * Scripts/webkitpy/layout_tests/port/mac.py:
1142         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1143
1144 2011-04-01  Chang Shu  <cshu@webkit.org>
1145
1146         Reviewed by Csaba Osztrogonác.
1147
1148         [Qt][WK2] Build Webkit2 using "-2" option on Qt
1149         https://bugs.webkit.org/show_bug.cgi?id=55074
1150
1151         * Scripts/build-webkit:
1152
1153 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
1154
1155         Reviewed by Tony Chang.
1156
1157         new-run-webkit-tests: remove spurious port version override in webkit.py
1158         base.py provides a default implementation so this is just
1159         breaking things.
1160
1161         https://bugs.webkit.org/show_bug.cgi?id=57667
1162
1163         * Scripts/webkitpy/layout_tests/port/webkit.py:
1164         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1165
1166 2011-04-01  Csaba Osztrogonác  <ossy@webkit.org>
1167
1168         Reviewed by Adam Roben.
1169
1170         Make view results on waterfall direct link to results.html
1171         https://bugs.webkit.org/show_bug.cgi?id=57671
1172
1173         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add "/results.html" to the URL.
1174         * Scripts/old-run-webkit-tests: Add links to httpd access and error logs.
1175
1176 2011-04-01  Sam Weinig  <sam@webkit.org>
1177
1178         Fix windows build.
1179
1180         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
1181         (TestWebKitAPI::TEST):
1182         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
1183         (TestWebKitAPI::flushMessages):
1184
1185 2011-04-01  Sam Weinig  <sam@webkit.org>
1186
1187         Reviewed by Adam Roben.
1188
1189         Add adoptWK to WKRetainPtr.h
1190         https://bugs.webkit.org/show_bug.cgi?id=57670
1191
1192         * TestWebKitAPI/PlatformUtilities.h:
1193         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
1194         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
1195         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
1196         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
1197         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
1198         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1199         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
1200         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
1201         (TestWebKitAPI::createSessionStateContainingFormData):
1202         * WebKitTestRunner/StringFunctions.h:
1203         Replace custom versions of adoptWK with the API on in WebKit2/WKRetainPtr.h.
1204
1205 2011-04-01  Sam Weinig  <sam@webkit.org>
1206
1207         Reviewed by Adam Roben.
1208
1209         Fix leak noticed by Adam Roben in LayoutTestController::shadowRoot.
1210
1211         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1212         (WTR::LayoutTestController::shadowRoot):
1213         Make judicious use of adoptWK().
1214
1215 2011-04-01  Sam Weinig  <sam@webkit.org>
1216
1217         Reviewed by Timothy Hatcher.
1218
1219         Fix extract-localizable-strings for macro change from UI_STRING -> WEB_UI_STRING.
1220
1221         * Scripts/extract-localizable-strings:
1222
1223 2011-04-01  Anders Carlsson  <andersca@apple.com>
1224
1225         Reviewed by Sam Weinig.
1226
1227         Shockwave plug-in doesn't accept mouse events
1228         https://bugs.webkit.org/show_bug.cgi?id=57653
1229         <rdar://problem/8483273>
1230
1231         Add a plug-in test.
1232
1233         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1234         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1235         (PluginTest::indicateTestFailure):
1236         Move code from NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject here.
1237
1238         (PluginTest::NPN_ConvertPoint):
1239         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1240         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
1241         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
1242         Call indicateTestFailure.
1243
1244         * DumpRenderTree/TestNetscapePlugIn/Tests/mac: Added.
1245         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp: Added.
1246         (ConvertPoint::ConvertPoint):
1247         (ConvertPoint::testConvert):
1248         (ConvertPoint::NPP_New):
1249
1250 2011-04-01  Dominic Cooney  <dominicc@google.com>
1251
1252         Reviewed by Martin Robinson.
1253
1254         Add layoutTestController.shadowRoot to GTK DumpRenderTree.
1255         https://bugs.webkit.org/show_bug.cgi?id=57551
1256
1257         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1258         (LayoutTestController::shadowRoot):
1259
1260 2011-04-01  Sam Weinig  <sam@webkit.org>
1261
1262         Reviewed by Anders Carlsson.
1263
1264         WebKitTestRunner needs layoutTestController.shadowRoot
1265         https://bugs.webkit.org/show_bug.cgi?id=57661
1266
1267         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1268         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1269         (WTR::LayoutTestController::shadowRoot):
1270         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1271         Implement layoutTestController.shadowRoot for WebKit2.
1272
1273 2011-04-01  Chang Shu  <cshu@webkit.org>
1274
1275         Reviewed by Darin Adler.
1276
1277         WebKitTestRunner needs layoutTestController.setDatabaseQuota
1278         https://bugs.webkit.org/show_bug.cgi?id=57568
1279
1280         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1281         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1282         (WTR::LayoutTestController::setDatabaseQuota):
1283         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1284
1285 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
1286
1287         Reviewed by Tony Chang.
1288
1289         This patch completes the cleanup of
1290         rebaseline-chromium-webkit-tests to work with all of the
1291         variants of a platform (we can now rebaseline gpu- and non-gpu
1292         files at the same time).
1293
1294         When the rebaselining is complete, any lines declared as
1295         REBASELINE in the expectations file that matches a test that was
1296         actually rebaselined will be deleted, even if only one of the
1297         variants was actually rebaselined. This may cause odd problems,
1298         but is better than where we're at today.
1299
1300         This change removes the -g flag and deprecates -w. The -g flag is gone
1301         because GPU baselines are handled just like any other variant.
1302         The -w flag is deprecated because this tool now only works
1303         against the canaries, since that's the only place we have a full
1304         set of bots. It will be trivial to change this to
1305         build.webkit.org if we decide that's where we want them to be.
1306
1307         Also, this patch deletes a lot of cruft that is no longer needed
1308         in the test_expectations code and the port-specific code.
1309
1310         https://bugs.webkit.org/show_bug.cgi?id=55191
1311
1312         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1313         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1314         * Scripts/webkitpy/layout_tests/port/base.py:
1315         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1316         * Scripts/webkitpy/layout_tests/port/chromium.py:
1317         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1318         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1319         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1320         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1321         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1322         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1323         * Scripts/webkitpy/layout_tests/port/mac.py:
1324         * Scripts/webkitpy/layout_tests/port/test.py:
1325         * Scripts/webkitpy/layout_tests/port/webkit.py:
1326         * Scripts/webkitpy/layout_tests/port/win.py:
1327         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1328         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1329
1330 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
1331
1332         Reviewed by Adam Barth.
1333
1334         rebaseline-chromium-webkit-tests does not work correctly with
1335         version-specific baselines. This patch updates the tool to use
1336         all of the version-specific bots on the canaries, and will now
1337         attempt to rebaseline all of the versions by default, although
1338         it will not update both GPU and CPU versions.
1339         
1340         Also, it will no longer modify the test_expectations.txt file
1341         *at all*. You will have to manually delete the REBASELINE lines
1342         after running the tool and determining that it did what you
1343         wanted it to do. This should be fixed in a separate bug - see
1344         webkit bug #55191.
1345
1346         https://bugs.webkit.org/show_bug.cgi?id=55608
1347
1348         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1349         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1350         * Scripts/webkitpy/layout_tests/port/chromium.py:
1351         * Scripts/webkitpy/layout_tests/port/test.py:
1352         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1353         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1354
1355 2011-03-31  Tony Chang  <tony@chromium.org>
1356
1357         Reviewed by Ojan Vafai.
1358
1359         [chromium] update the rebaseline tool to know about pngs with checksums
1360         https://bugs.webkit.org/show_bug.cgi?id=57481
1361
1362         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Skip over .checksum files if the checksum is already in the png
1363         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1364
1365 2011-04-01  Adam Roben  <aroben@apple.com>
1366
1367         Retrieve revision numbers from the build's got_revision property in Leaks Viewer
1368
1369         Previously, we were getting the revision of the first revision that triggered a build.
1370         Choosing the last revision would have been more accurate. But got_revision is what is used
1371         everywhere else on build.webkit.org, and should work even when there were no changes that
1372         triggered a build (e.g., if someone clicked the Force Build button).
1373
1374         Fixes <http://webkit.org/b/57630> Leaks viewer gets some revision numbers wrong in the
1375         recent builds list
1376
1377         Reviewed by Anders Carlsson.
1378
1379         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1380         (RecentBuildsLoader.prototype.start): Pull the revision number out of the got_revision
1381         property, rather than out of the first (i.e., earliest) change in the sourceStamp object.
1382
1383         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
1384         (Array.prototype.first): Added this helper function to return the first element in an array
1385         that matches the given predicate, or null if no such element exists.
1386
1387 2011-03-31  Adam Roben  <aroben@apple.com>
1388
1389         Prefer (but don't require) bug URLs to be on their own line when parsing bug numbers from ChangeLogs
1390
1391         Fixes <http://webkit.org/b/57579> webkit-patch is too strict about bug URL formatting
1392
1393         Reviewed by Darin Adler.
1394
1395         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1396         (parse_bug_id_from_changelog): Fall back to parse_bug_id if we weren't able to find a bug
1397         URL on its own line.
1398
1399         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1400         (BugzillaTest.test_parse_bug_id_from_changelog): Updated expected results for test
1401         progression, and added a new test that uses a short bug URL while I was at it.
1402
1403 2011-04-01  Adam Roben  <aroben@apple.com>
1404
1405         Mark .vcproj/.vsprops/.sln files as being Windows-only
1406
1407         Fixes <http://webkit.org/b/57489> Mac builders built 82512, but shouldn't have
1408
1409         Reviewed by Anders Carlsson.
1410
1411         * Scripts/webkitpy/common/config/build.py:
1412         (_should_file_trigger_build): Added patterns to mark .vcproj/.vsprops/.sln files and .vcproj
1413         directories as Windows-only.
1414
1415         * Scripts/webkitpy/common/config/build_unittest.py:
1416         (ShoulBuildTest): Added test cases for the above.
1417
1418 2011-04-01  Keith Kyzivat  <keith.kyzivat@nokia.com>
1419
1420         Reviewed by Laszlo Gombos.
1421
1422         [Qt] Build MiniBrowser for Symbian
1423         https://bugs.webkit.org/show_bug.cgi?id=56319
1424
1425         Have MiniBrowser reference it's own copy of useragentlist.txt instead
1426         of copying QtTestBrowser's.
1427         Remove Tools/MiniBrowser/DerivedSources.pro
1428         This reduces complexity in the Tools scripts due to Symbian limitations.
1429
1430         * DerivedSources.pro:
1431         * MiniBrowser/DerivedSources.pro: Removed.
1432         * MiniBrowser/MiniBrowser.qrc:
1433         * MiniBrowser/qt/MiniBrowser.pro:
1434         * Scripts/webkitdirs.pm:
1435
1436 2011-03-31  Chang Shu  <cshu@webkit.org>
1437
1438         Reviewed by Darin Adler.
1439
1440         WebKitTestRunner needs layoutTestController.clearAllDatabases
1441         https://bugs.webkit.org/show_bug.cgi?id=42540
1442
1443         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1444         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1445         (WTR::InjectedBundle::beginTesting):
1446         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1447         (WTR::LayoutTestController::clearAllDatabases):
1448         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1449
1450 2011-03-31  Chang Shu  <cshu@webkit.org>
1451
1452         Reviewed by Darin Adler.
1453
1454         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
1455         https://bugs.webkit.org/show_bug.cgi?id=42692
1456
1457         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1458
1459 2011-03-31  Darin Adler  <darin@apple.com>
1460
1461         Reviewed by Sam Weinig.
1462
1463         Implement mouseDown, mouseUp, and mouseMoveTo in WebKitTestRunner
1464         https://bugs.webkit.org/show_bug.cgi?id=57573
1465
1466         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1467         Added real definitions for mouseDown, mouseUp, mouseMoveTo and leapForward.
1468         Removed fake definitions of keyDown and contextClick.
1469
1470         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1471         (WTR::operator==): Added. So we can compare two WKPoint structs.
1472         (WTR::parseModifier): Added.
1473         (WTR::parseModifierArray): Added.
1474         (WTR::EventSendingController::EventSendingController): Initialize the
1475         new data members.
1476         (WTR::EventSendingController::mouseDown): Added. Calls
1477         WKBundlePageSimulateMouseDown.
1478         (WTR::EventSendingController::mouseUp): Added. Calls
1479         WKBundlePageSimulateMouseUp.
1480         (WTR::EventSendingController::mouseMoveTo): Added. Calls
1481         WKBundlePageSimulateMouseMotion.
1482         (WTR::EventSendingController::leapForward): Added.
1483         (WTR::EventSendingController::updateClickCount): Added. Used by the
1484         mouseDown/Up functions to create a click count.
1485
1486         * WebKitTestRunner/InjectedBundle/EventSendingController.h: Updated
1487         for the changes above.
1488
1489 2011-03-31  Sergio Villar Senin  <svillar@igalia.com>
1490
1491         Reviewed by Martin Robinson.
1492
1493         [GTK] implement LayoutTestController::setWillSendRequestReturnsNull
1494         https://bugs.webkit.org/show_bug.cgi?id=57362
1495
1496         Do not generate DRT output if willSendRequestReturnsNull is set.
1497
1498         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1499         (willSendRequestCallback):
1500
1501 2011-03-31  Vamshikrishna.Yellenki  <vamshi@motorola.com> and Alejandro G. Castro  <alex@igalia.com>
1502
1503         Reviewed by Martin Robinson.
1504
1505         Implement MiniBrowser for Gtk port.
1506         https://bugs.webkit.org/show_bug.cgi?id=48512
1507
1508         Initial implementation of the Gtk MiniBrowser.
1509
1510         * MiniBrowser/gtk/GNUmakefile.am: Added.
1511         * MiniBrowser/gtk/main.c: Added.
1512         (activateUriEntryCallback):
1513         (destroyCallback):
1514         (goBackCallback):
1515         (goForwardCallback):
1516         (createToolbar):
1517         (createWebView):
1518         (createWindow):
1519         (argumentToURL):
1520         (main):
1521
1522 2011-03-30  Dominic Cooney  <dominicc@google.com>
1523
1524         Reviewed by Dimitri Glazkov.
1525
1526         Adds layoutTestController.shadowRoot accessor to Mac DRT.
1527         https://bugs.webkit.org/show_bug.cgi?id=57415
1528
1529         * DumpRenderTree/LayoutTestController.cpp:
1530         (shadowRootCallback):
1531         (LayoutTestController::staticFunctions):
1532         * DumpRenderTree/LayoutTestController.h:
1533         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1534         (LayoutTestController::shadowRoot):
1535         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1536         (LayoutTestController::shadowRoot):
1537
1538 2011-03-30  Matthew Delaney  <mdelaney@apple.com>
1539
1540         Reviewed by Chris Marrin.
1541
1542         Update fast/canvas tests to avoid dumping the render tree when possible
1543         https://bugs.webkit.org/show_bug.cgi?id=57493
1544
1545         * DumpRenderTree/mac/DumpRenderTree.mm: Make DRT aware of new default values for
1546           accelerated drawing and accelerated drawing for canvas
1547
1548 2011-03-30  Adam Roben  <aroben@apple.com>
1549
1550         Stop ignoring leaks in CGGradientCreateWithColorStops
1551
1552         Fixes <rdar://problem/7888547>.
1553
1554         Rubber-stamped by John Sullivan.
1555
1556         * Scripts/old-run-webkit-tests:
1557         (countAndPrintLeaks): Removed some code to ignore those leaks.
1558
1559 2011-03-30  Timur Iskhodzhanov  <timurrrr@google.com>
1560
1561         Reviewed by Alexey Proskuryakov.
1562
1563         Add some dynamic annotations to JavaScriptCore/wtf
1564         https://bugs.webkit.org/show_bug.cgi?id=53747
1565
1566         By using these annotations we can improve the precision of finding
1567         WebKit errors using dynamic analysis tools like ThreadSanitizer and Valgrind.
1568         These annotations don't affect the compiled binaries unless USE(DYNAMIC_ANNOTATIONS) is "1".
1569
1570         These files don't add new functionality, so don't need extra tests.
1571
1572         * DumpRenderTree/ForwardingHeaders/wtf/DynamicAnnotations.h: Added.
1573
1574 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
1575
1576         Reviewed by Adam Roben.
1577
1578         Share most vsprops between Release and Production builds in releaseproduction.vsprops
1579         https://bugs.webkit.org/show_bug.cgi?id=57508
1580
1581         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
1582         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops:
1583         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops:
1584         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
1585         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops:
1586         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops:
1587         * DumpRenderTree/win/ImageDiffProduction.vsprops:
1588         * DumpRenderTree/win/ImageDiffRelease.vsprops:
1589         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops:
1590         * FindSafari/FindSafariProduction.vsprops:
1591         * FindSafari/FindSafariRelease.vsprops:
1592         * FindSafari/FindSafariReleaseCairoCFLite.vsprops:
1593         * FindSafari/FindSafariReleasePGO.vsprops:
1594         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
1595         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops:
1596         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops:
1597         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops:
1598         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops:
1599         * WebKitAPITest/WebKitAPITestProduction.vsprops:
1600         * WebKitAPITest/WebKitAPITestRelease.vsprops:
1601         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops:
1602         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
1603         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops:
1604         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops:
1605         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
1606         * WebKitTestRunner/win/InjectedBundleRelease.vsprops:
1607         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops:
1608         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
1609         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops:
1610         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops:
1611         * WinLauncher/WinLauncherProduction.vsprops:
1612         * WinLauncher/WinLauncherRelease.vsprops:
1613         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops:
1614         * record-memory-win/record-memory-winProduction.vsprops:
1615         * record-memory-win/record-memory-winRelease.vsprops:
1616         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops:
1617
1618 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
1619
1620         Reviewed by Adam Roben.
1621
1622         Update Windows production build logic for new production configurations
1623         https://bugs.webkit.org/show_bug.cgi?id=57494
1624
1625         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
1626         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
1627         * DumpRenderTree/win/ImageDiffProduction.vsprops:
1628         * FindSafari/FindSafariProduction.vsprops:
1629         * FindSafari/FindSafariReleasePGO.vsprops:
1630         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
1631         * WebKitAPITest/WebKitAPITestProduction.vsprops:
1632         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
1633         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
1634         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
1635         * WinLauncher/WinLauncherProduction.vsprops:
1636         * record-memory-win/record-memory-winProduction.vsprops:
1637
1638 2011-03-30  Robert Hogan  <robert@webkit.org>
1639
1640         Reviewed by Antonio Gomes.
1641
1642         [Qt] Fix LoadHTMLStringItem::invoke() after r75966
1643         Unskip http/tests/navigation/go-back-to-error-page.html
1644
1645         Also add the location of DumpRenderTreeSupportQt.h
1646         to DRT's include paths.
1647
1648         https://bugs.webkit.org/show_bug.cgi?id=52614
1649
1650         * DumpRenderTree/qt/DumpRenderTree.pro:
1651         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1652         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1653         * DumpRenderTree/qt/GCControllerQt.cpp:
1654         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1655         (LayoutTestController::queueLoadHTMLString):
1656         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1657         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
1658         * DumpRenderTree/qt/TextInputControllerQt.cpp:
1659         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
1660         (LoadAlternateHTMLStringItem::invoke):
1661         * DumpRenderTree/qt/WorkQueueItemQt.h:
1662         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
1663         * QtTestBrowser/QtTestBrowser.pro:
1664         * QtTestBrowser/launcherwindow.h:
1665
1666 2011-03-30  Adam Barth  <abarth@webkit.org>
1667
1668         Reviewed by Adam Roben.
1669
1670         SheriffBot rollouts take too long
1671         https://bugs.webkit.org/show_bug.cgi?id=57498
1672
1673         We used to build before landing rollouts via the commit-queue to
1674         prevent further breakage, but now that our individual commit-queue
1675         machines are slower, building takes too long.  I can't remember the
1676         last time a rollout broke compile.  It seems like just landing the
1677         patch is the better trade-off.
1678
1679         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1680         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1681
1682 2011-03-30  Adam Barth  <abarth@webkit.org>
1683
1684         Remove platform/chromium-mac-snowleopard
1685         https://bugs.webkit.org/show_bug.cgi?id=57486
1686
1687         This directory no longer exists, so we can remove it from the fallback
1688         chain.
1689
1690         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1691
1692 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
1693
1694         Reviewed by Adam Roben.
1695
1696         Rename Windows configuration Release_LTCG to Production for clarity
1697         https://bugs.webkit.org/show_bug.cgi?id=57465
1698
1699         * DumpRenderTree/DumpRenderTree.sln:
1700         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1701         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops: Copied from Tools/DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops.
1702         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Removed.
1703         * DumpRenderTree/win/DumpRenderTree.vcproj:
1704         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops: Copied from Tools/DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops.
1705         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Removed.
1706         * DumpRenderTree/win/ImageDiff.vcproj:
1707         * DumpRenderTree/win/ImageDiffProduction.vsprops: Copied from Tools/DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops.
1708         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Removed.
1709         * FindSafari/FindSafari.vcproj:
1710         * FindSafari/FindSafariProduction.vsprops: Copied from Tools/FindSafari/FindSafariReleaseLTCG.vsprops.
1711         * FindSafari/FindSafariReleaseLTCG.vsprops: Removed.
1712         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops: Copied from Tools/MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops.
1713         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Removed.
1714         * MiniBrowser/MiniBrowser.vcproj:
1715         * Scripts/webkitdirs.pm:
1716         * TestWebKitAPI/win/TestWebKitAPI.sln:
1717         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1718         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
1719         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
1720         * WebKitAPITest/WebKitAPITest.vcproj:
1721         * WebKitAPITest/WebKitAPITestProduction.vsprops: Copied from Tools/WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops.
1722         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Removed.
1723         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1724         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops: Copied from Tools/WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops.
1725         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Removed.
1726         * WebKitTestRunner/WebKitTestRunner.sln:
1727         * WebKitTestRunner/win/InjectedBundle.vcproj:
1728         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
1729         * WebKitTestRunner/win/InjectedBundleProduction.vsprops: Copied from Tools/WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops.
1730         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Removed.
1731         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1732         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops: Copied from Tools/WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops.
1733         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Removed.
1734         * WinLauncher/WinLauncher.vcproj:
1735         * WinLauncher/WinLauncherProduction.vsprops: Copied from Tools/WinLauncher/WinLauncherReleaseLTCG.vsprops.
1736         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Removed.
1737         * record-memory-win/record-memory-win.vcproj:
1738         * record-memory-win/record-memory-winProduction.vsprops: Copied from Tools/record-memory-win/record-memory-winReleaseLTCG.vsprops.
1739         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Removed.
1740
1741 2011-03-30  MORITA Hajime  <morrita@google.com>
1742
1743         Reviewed by Dimitri Glazkov.
1744
1745         [Chromium] Expose the shadow DOM to DumpRenderTree JS tests.
1746         https://bugs.webkit.org/show_bug.cgi?id=56573
1747
1748         Added LayoutTestController.shadowRoot() to Chromium DRT.
1749
1750         * DumpRenderTree/chromium/LayoutTestController.cpp:
1751         (LayoutTestController::LayoutTestController):
1752         (LayoutTestController::shadowRoot):
1753         * DumpRenderTree/chromium/LayoutTestController.h:
1754
1755 2011-03-30  Yuta Kitamura  <yutak@chromium.org>
1756
1757         Reviewed by Kent Tamura.
1758
1759         [Chromium] DumpRenderTree: Implement LayoutTestController::setPluginsEnabled
1760         https://bugs.webkit.org/show_bug.cgi?id=57430
1761
1762         * DumpRenderTree/chromium/LayoutTestController.cpp:
1763         (LayoutTestController::LayoutTestController):
1764         (LayoutTestController::setPluginsEnabled):
1765         * DumpRenderTree/chromium/LayoutTestController.h:
1766
1767 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
1768
1769         Reviewed by Adam Barth.
1770
1771         make webkit-patch upload respect -d
1772         https://bugs.webkit.org/show_bug.cgi?id=57425
1773
1774         * Scripts/webkitpy/common/checkout/scm.py:
1775         * Scripts/webkitpy/tool/steps/commit.py:
1776
1777 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
1778
1779         Reviewed by Adam Barth.
1780
1781         Make "webkit-patch --dry-run --verbose land" log the SVN command it's going to use
1782         https://bugs.webkit.org/show_bug.cgi?id=57429
1783
1784         * Scripts/webkitpy/common/checkout/scm.py:
1785
1786 2011-03-29  Sheriff Bot  <webkit.review.bot@gmail.com>
1787
1788         Unreviewed, rolling out r82383.
1789         http://trac.webkit.org/changeset/82383
1790         https://bugs.webkit.org/show_bug.cgi?id=57417
1791
1792         "nrwt isn't shutting down cleanly" (Requested by dpranke on
1793         #webkit).
1794
1795         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1796         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1797         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1798
1799 2011-03-29  Kent Tamura  <tkent@chromium.org>
1800
1801         Reviewed by Dimitri Glazkov.
1802
1803         Make validation message bubble testable
1804         https://bugs.webkit.org/show_bug.cgi?id=57290
1805
1806         * DumpRenderTree/mac/DumpRenderTree.mm:
1807         (createWebViewAndOffscreenWindow): Change a setting so that validation
1808           bubbles isn't hidden automatically.
1809
1810 2011-03-29  Dirk Pranke  <dpranke@chromium.org>
1811
1812         Reviewed by Ojan Vafai.
1813
1814         new-run-webkit-tests: use 'threads' on win instead of 'old-threads'
1815
1816         It's a bit unclear whether multiple threads or multiple
1817         processes will be a better model on windows. This change will
1818         test threads for now while we're still working out the bugs in
1819         multiple-processes.
1820
1821         https://bugs.webkit.org/show_bug.cgi?id=57410
1822
1823         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1824         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1825         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1826
1827 2011-03-29  David Levin  <levin@chromium.org>
1828
1829         Reviewed by Shinichiro Hamaji.
1830
1831         check-webkit-style confused by two ChangeLog entries in a row from same user
1832         https://bugs.webkit.org/show_bug.cgi?id=57250
1833
1834         * Scripts/webkitpy/style/checker.py: Add the line should be checked function to ChangeLogChecker.
1835         * Scripts/webkitpy/style/checker_unittest.py: Fix test due to that new function.
1836         * Scripts/webkitpy/style/checkers/changelog.py: Made this code aware of what lines were being checked.
1837           It basically assumes only one ChangeLog entry is being processed because that is the standard case and
1838           checking more than that would be very messey.
1839         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Add testing to catch the broken case.
1840         * Scripts/webkitpy/style/error_handlers.py: Added should_line_be_checked.
1841
1842 2011-03-29  Kent Tamura  <tkent@chromium.org>
1843
1844         Reviewed by Dimitri Glazkov.
1845
1846         [Mac] Enable interactive-validation tests on Mac DRT
1847         https://bugs.webkit.org/show_bug.cgi?id=57308
1848
1849         * DumpRenderTree/mac/DumpRenderTree.mm:
1850         (createWebViewAndOffscreenWindow): Enable the form interactive validation feature.
1851
1852 2011-03-29  Chang Shu  <cshu@webkit.org>
1853
1854         Reviewed by Kenneth Rohde Christiansen.
1855
1856         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
1857         https://bugs.webkit.org/show_bug.cgi?id=42692
1858
1859         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1860         (WTR::InjectedBundle::beginTesting):
1861         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1862         (WTR::LayoutTestController::setAllowUniversalAccessFromFileURLs):
1863         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1864
1865 2011-03-24  Martin Robinson  <mrobinson@igalia.com>
1866
1867         Reviewed by Xan Lopez.
1868
1869         [GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
1870         https://bugs.webkit.org/show_bug.cgi?id=57067
1871
1872         Eliminate extra spacing between the DRT GtkScrolledWindow and the DRT WebView. This
1873         will allow WebKit1GTK+ and WebKit2GTK+ to share test results. Followup commits will
1874         update DRT and pixel results as hundreds of results will need to be updated.
1875
1876         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1877         (setDefaultsToConsistentStateValuesForTesting): Eliminate spacing on the GtkScrolledWindow
1878         by overriding the theme RC/CSS files.
1879
1880 2011-03-29  Steve Falkenburg  <sfalken@apple.com>
1881
1882         Reviewed by Adam Roben.
1883
1884         Use per-configuration vsprops in tools projects to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
1885         https://bugs.webkit.org/show_bug.cgi?id=57394
1886
1887         Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
1888         InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
1889         the IDE. To avoid this, add a separate vsprops file for each project configuration that
1890         contains the required inherited property sheets.
1891
1892         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1893         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops: Added.
1894         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops: Added.
1895         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops: Added.
1896         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: Added.
1897         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: Added.
1898         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Added.
1899         * DumpRenderTree/win/DumpRenderTree.vcproj:
1900         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops: Added.
1901         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops: Added.
1902         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Added.
1903         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops: Added.
1904         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: Added.
1905         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Added.
1906         * DumpRenderTree/win/ImageDiff.vcproj:
1907         * DumpRenderTree/win/ImageDiffDebug.vsprops: Added.
1908         * DumpRenderTree/win/ImageDiffDebugAll.vsprops: Added.
1909         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Added.
1910         * DumpRenderTree/win/ImageDiffRelease.vsprops: Added.
1911         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Added.
1912         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Added.
1913         * FindSafari/FindSafari.vcproj:
1914         * FindSafari/FindSafariDebug.vsprops: Added.
1915         * FindSafari/FindSafariDebugAll.vsprops: Added.
1916         * FindSafari/FindSafariDebugCairoCFLite.vsprops: Added.
1917         * FindSafari/FindSafariRelease.vsprops: Added.
1918         * FindSafari/FindSafariReleaseCairoCFLite.vsprops: Added.
1919         * FindSafari/FindSafariReleaseLTCG.vsprops: Added.
1920         * FindSafari/FindSafariReleasePGO.vsprops: Added.
1921         * MiniBrowser/Configurations/MiniBrowserDebug.vsprops: Added.
1922         * MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops: Added.
1923         * MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops: Added.
1924         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops: Added.
1925         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops: Added.
1926         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Added.
1927         * MiniBrowser/MiniBrowser.vcproj:
1928         * WebKitAPITest/WebKitAPITest.vcproj:
1929         * WebKitAPITest/WebKitAPITestDebug.vsprops: Added.
1930         * WebKitAPITest/WebKitAPITestDebugAll.vsprops: Added.
1931         * WebKitAPITest/WebKitAPITestDebugCairoCFLite.vsprops: Added.
1932         * WebKitAPITest/WebKitAPITestRelease.vsprops: Added.
1933         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops: Added.
1934         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Added.
1935         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1936         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops: Added.
1937         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops: Added.
1938         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops: Added.
1939         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: Added.
1940         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: Added.
1941         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Added.
1942         * WebKitTestRunner/win/InjectedBundle.vcproj:
1943         * WebKitTestRunner/win/InjectedBundleDebug.vsprops: Added.
1944         * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops: Added.
1945         * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops: Added.
1946         * WebKitTestRunner/win/InjectedBundleRelease.vsprops: Added.
1947         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops: Added.
1948         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Added.
1949         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1950         * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops: Added.
1951         * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops: Added.
1952         * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops: Added.
1953         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops: Added.
1954         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops: Added.
1955         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Added.
1956         * WinLauncher/WinLauncher.vcproj:
1957         * WinLauncher/WinLauncherDebug.vsprops: Added.
1958         * WinLauncher/WinLauncherDebugAll.vsprops: Added.
1959         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops: Added.
1960         * WinLauncher/WinLauncherRelease.vsprops: Added.
1961         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: Added.
1962         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Added.
1963         * record-memory-win/record-memory-win.vcproj:
1964         * record-memory-win/record-memory-winDebug.vsprops: Added.
1965         * record-memory-win/record-memory-winDebugAll.vsprops: Added.
1966         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops: Added.
1967         * record-memory-win/record-memory-winRelease.vsprops: Added.
1968         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: Added.
1969         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Added.
1970
1971 2011-03-29  Adam Barth  <abarth@webkit.org>
1972
1973         Reviewed by Darin Adler.
1974
1975         test_runner2.py can crash due to undefined variable
1976         https://bugs.webkit.org/show_bug.cgi?id=57356
1977
1978         Replace reference to undefined variable with a variable that's actually
1979         defined.  AFAICT, there's no way to test this code.
1980
1981         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
1982
1983 2011-03-29  Tony Chang  <tony@chromium.org>
1984
1985         Reviewed by Eric Seidel.
1986
1987         cleanup rebaseline-chromium-webkit-tests
1988         https://bugs.webkit.org/show_bug.cgi?id=57375
1989
1990         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1991             - Split _extract_and_add_new_baselines into 3 functions
1992             - Reduce the amount of line wrapping (the file already has lines
1993               over 80 col, so may as well try to make the file consistent)
1994             - Remove unnecessary ()s
1995
1996 2011-03-29  Brent Fulgham  <bfulgham@webkit.org>
1997
1998         Reviewed by Adam Roben.
1999
2000         Make WinCairo a core builder.
2001         https://bugs.webkit.org/show_bug.cgi?id=57373
2002
2003         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Add WinCairo.
2004         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Add WinCairo.
2005
2006 2011-03-29  Timothy Hatcher  <timothy@apple.com>
2007
2008         Update update-webkit-localizable-strings to understand that WebKit and
2009         WebKit2 strings go in WebCore.
2010
2011         Also make extract-localizable-strings optionally use an exclude file. No individual
2012         warnings are produced about unlocalized strings when there is no exclude file. This
2013         is needed for WebCore, since there are too many bare strings.
2014
2015         https://webkit.org/b/57354
2016
2017         Reviewed by Sam Weinig.
2018
2019         * Scripts/extract-localizable-strings: Support "-" to mean no exclude file.
2020         * Scripts/update-webkit-localizable-strings: Update paths to scan WebCore and WebKit2.
2021
2022 2011-03-29  Darin Adler  <darin@apple.com>
2023
2024         Reviewed by Adam Roben.
2025
2026         WebKit2 bundle page needs to offer generated file hooks
2027         https://bugs.webkit.org/show_bug.cgi?id=57279
2028
2029         (Land missing part of the original patch after r82289.)
2030
2031         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2032         (WTR::InjectedBundlePage::InjectedBundlePage): Added new callbacks.
2033
2034 2011-03-29  Tony Chang  <tony@chromium.org>
2035
2036         Reviewed by Ojan Vafai.
2037
2038         [chromium] NRWT should be able to read checksums from png comments
2039         https://bugs.webkit.org/show_bug.cgi?id=57280
2040
2041         * Scripts/read-checksum-from-png: Added. Utility script to read the checksum
2042             from a file.
2043         * Scripts/webkitpy/common/system/filesystem.py: Add open_binary_file_for_reading
2044         * Scripts/webkitpy/common/system/filesystem_mock.py:
2045         * Scripts/webkitpy/layout_tests/port/base.py: When loading a checksum,
2046             if the -checksum.txt file doesn't exist, try looking in the png.
2047         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2048         * Scripts/webkitpy/layout_tests/port/test.py:
2049         * Scripts/webkitpy/layout_tests/read_checksum_from_png.py: Added. Scan the first
2050             2k for a png comment with the checksum
2051         * Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py: Added.
2052
2053 2011-03-29  Philippe Normand  <pnormand@igalia.com>
2054
2055         Rubber-stamped by Gustavo Noronha Silva.
2056
2057         [GTK] http/tests/uri/username-with-no-hostname.html fails
2058         https://bugs.webkit.org/show_bug.cgi?id=57325
2059
2060         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2061         (willSendRequestCallback): URI host value check done case-insensitively.
2062
2063 2011-03-29  Philippe Normand  <pnormand@igalia.com>
2064
2065         Reviewed by Martin Robinson.
2066
2067         [GTK] http/tests/uri/username-with-no-hostname.html fails
2068         https://bugs.webkit.org/show_bug.cgi?id=57325
2069
2070         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2071         (willSendRequestCallback): Check URI before submitting the request
2072         to WebCore.
2073
2074 2011-03-29  Noel Gordon  <noel.gordon@gmail.com>
2075
2076         Reviewed by Ojan Vafai.
2077
2078         [chromium] DRT EventSender: remove identity from dragTargetDragEnter() calls
2079         https://bugs.webkit.org/show_bug.cgi?id=57303
2080
2081         * DumpRenderTree/chromium/EventSender.cpp:
2082         (EventSender::doDragDrop):
2083         (EventSender::beginDragWithFiles):
2084
2085 2011-03-29  Zoltan Horvath  <zoltan@webkit.org>
2086
2087         Reviewed by Andreas Kling.
2088
2089         [Qt] Add -print-loaded-urls option to Qt's MiniBrowser and to QtTestBrowser
2090         https://bugs.webkit.org/show_bug.cgi?id=57314
2091
2092         Provide possibility to print loaded urls to the standard output.
2093
2094         * MiniBrowser/qt/BrowserWindow.cpp:
2095         (BrowserWindow::BrowserWindow):
2096         (BrowserWindow::printURL):
2097         * MiniBrowser/qt/BrowserWindow.h:
2098         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2099         (MiniBrowserApplication::handleUserOptions):
2100         * MiniBrowser/qt/MiniBrowserApplication.h:
2101         (WindowOptions::WindowOptions):
2102         * QtTestBrowser/launcherwindow.cpp:
2103         (LauncherWindow::initializeView):
2104         (LauncherWindow::printURL):
2105         (LauncherWindow::cloneWindow):
2106         * QtTestBrowser/launcherwindow.h:
2107         (WindowOptions::WindowOptions):
2108         * QtTestBrowser/main.cpp:
2109         (LauncherApplication::handleUserOptions):
2110
2111 2011-03-29  Gabor Loki  <loki@webkit.org>
2112
2113         Rubber-stamped by Csaba Osztrogonác.
2114
2115         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
2116         https://bugs.webkit.org/show_bug.cgi?id=56918
2117
2118         * Scripts/build-jsc: Remove duplicated --qt options to avoid passing them to qmake.
2119
2120 2011-03-28  Gabor Loki  <loki@webkit.org>
2121
2122         Reviewed by Csaba Osztrogonác.
2123
2124         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
2125         https://bugs.webkit.org/show_bug.cgi?id=56918
2126
2127         * Scripts/build-jsc:
2128         * Scripts/webkitdirs.pm:
2129
2130 2011-03-28  Andrew Foster  <andrewf@chromium.org>
2131
2132         Reviewed by Ojan Vafai.
2133
2134         webkit-patch should be more intelligent about whether a bug applies to a patch
2135         Create a new function, parse_bug_id_from_changelog() which determines
2136         that a bug is related to a patch by parsing the output generated from
2137         prepare-ChangeLog, rather than arbitrarily matching a URL to a bug in
2138         the description of a patch.
2139         https://bugs.webkit.org/show_bug.cgi?id=56989
2140
2141         * Scripts/webkitpy/common/checkout/api.py:
2142         * Scripts/webkitpy/common/checkout/changelog.py:
2143         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
2144         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2145         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2146         * Scripts/webkitpy/style/checkers/changelog.py:
2147         * Scripts/webkitpy/tool/commands/upload.py:
2148
2149 2011-03-28  Maciej Stachowiak  <mjs@apple.com>
2150
2151         Revert accidentally commited change.
2152
2153         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2154         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2155
2156 2011-03-28  Tony Chang  <tony@chromium.org>
2157
2158         Reviewed by Adam Barth.
2159
2160         [chromium] have DRT write the png checksum into a png comment
2161         https://bugs.webkit.org/show_bug.cgi?id=57255
2162
2163         * DumpRenderTree/chromium/TestShell.cpp:
2164         (TestShell::dumpImage):
2165
2166 2011-03-28  Adele Peterson  <adele@apple.com>
2167
2168         Removing Qt stub, since it doesn't use the same header as the others.
2169
2170         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2171
2172 2011-03-28  Adele Peterson  <adele@apple.com>
2173
2174         Added a few more stubs.
2175
2176         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2177         (LayoutTestController::hasGrammarMarker):
2178         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2179         (LayoutTestController::hasGrammarMarker):
2180         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2181         (LayoutTestController::hasGrammarMarker):
2182
2183 2011-03-28  Adele Peterson  <adele@apple.com>
2184
2185         Build fix.
2186
2187         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2188         (LayoutTestController::hasGrammarMarker):
2189
2190 2011-03-28  Adele Peterson  <adele@apple.com>
2191
2192         Reviewed by Eric Seidel.
2193
2194         Testing support for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
2195         https://bugs.webkit.org/show_bug.cgi?id=57173
2196
2197         * DumpRenderTree/LayoutTestController.cpp:
2198         (hasGrammarMarkerCallback): Added.
2199         (LayoutTestController::staticFunctions): Added case for hasGrammarMarker.
2200         * DumpRenderTree/LayoutTestController.h:
2201         * DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): Call setGrammarCheckingEnabled.
2202         * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::hasGrammarMarker): Added. Call new hasGrammarMarker method.
2203
2204 2011-03-28  Csaba Osztrogonác  <ossy@webkit.org>
2205
2206         Reviewed by Benjamin Poulain.
2207
2208         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
2209         https://bugs.webkit.org/show_bug.cgi?id=57087
2210
2211         Trivial typo fix after r82082.
2212
2213         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2214         (WTR::activateFonts):
2215
2216 2011-03-28  Alexis Menard  <alexis.menard@openbossa.org>
2217
2218         Reviewed by Andreas Kling.
2219
2220         Add myself to the committers list.
2221
2222         * Scripts/webkitpy/common/config/committers.py:
2223
2224 2011-03-28  Simon Fraser  <simon.fraser@apple.com>
2225
2226         Reviewed by Sam Weinig.
2227
2228         WebKit2 unfortunately uses code from WebKit, so MiniBrowser needs
2229         to link against WebKit.framework for now.
2230
2231         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2232
2233 2011-03-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
2234
2235         Reviewed by Andreas Kling.
2236
2237         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
2238         https://bugs.webkit.org/show_bug.cgi?id=57087
2239
2240         Disable QT_ASCII_CAST_WARNINGS for applications.
2241
2242         * DumpRenderTree/qt/DumpRenderTree.pro:
2243         * DumpRenderTree/qt/ImageDiff.pro:
2244         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2245         * MiniBrowser/qt/MiniBrowser.pro:
2246         * QtTestBrowser/QtTestBrowser.pro:
2247         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2248
2249 2011-03-28  Andreas Kling  <kling@webkit.org>
2250
2251         Reviewed by Kenneth Rohde Christiansen.
2252
2253         [Qt] QtTestBrowser doesn't reset its window title when opening about:blank
2254         https://bugs.webkit.org/show_bug.cgi?id=57224
2255
2256         * QtTestBrowser/mainwindow.cpp:
2257         (MainWindow::buildUI):
2258         (MainWindow::onTitleChanged):
2259         * QtTestBrowser/mainwindow.h:
2260
2261 2011-03-27  Jer Noble  <jer.noble@apple.com>
2262
2263         Reviewed by Maciej Stachowiak.
2264
2265         Full Screen: disable keyboard access by default
2266         https://bugs.webkit.org/show_bug.cgi?id=56684
2267
2268         Accept the withKeyboard parameter to supportsFullScreenForElement.
2269
2270         * DumpRenderTree/mac/UIDelegate.mm:
2271         (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
2272
2273 2011-03-27  Patrick Gansterer  <paroga@webkit.org>
2274
2275         Reviewed by David Levin.
2276
2277         check-webkit-style should check ChangeLog for a valid bug number
2278         https://bugs.webkit.org/show_bug.cgi?id=57184
2279
2280         * Scripts/webkitpy/style/checker.py:
2281         * Scripts/webkitpy/style/checker_unittest.py:
2282         * Scripts/webkitpy/style/checkers/changelog.py: Added.
2283         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Added.
2284
2285 2011-03-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
2286
2287         Reviewed by Andreas Kling.
2288
2289         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
2290         https://bugs.webkit.org/show_bug.cgi?id=57087
2291
2292         Use explicit conversion for string to avoid depending on the default codec
2293         installed by the user code.
2294
2295         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2296         (WTR::activateFonts):
2297
2298 2011-03-26  Maciej Stachowiak  <mjs@apple.com>
2299
2300         Revert inadvertantly committed changes.
2301
2302         * Scripts/old-run-webkit-tests:
2303         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2304
2305 2011-03-26  Andreas Kling  <kling@webkit.org>
2306
2307         Reviewed by Kenneth Rohde Christiansen.
2308
2309         [Qt] Show page icons (favicons) in QtTestBrowser location bar.
2310         https://bugs.webkit.org/show_bug.cgi?id=57162
2311
2312         * QtTestBrowser/QtTestBrowser.qrc:
2313         * QtTestBrowser/favicon.png: Added.
2314         * QtTestBrowser/locationedit.cpp:
2315         (defaultPageIcon):
2316         (LocationEdit::LocationEdit):
2317         (LocationEdit::setPageIcon):
2318         (LocationEdit::resizeEvent):
2319         (LocationEdit::updateInternalGeometry):
2320         * QtTestBrowser/locationedit.h:
2321         * QtTestBrowser/mainwindow.cpp:
2322         (MainWindow::buildUI):
2323         (MainWindow::onIconChanged):
2324         (MainWindow::onLoadStarted):
2325         * QtTestBrowser/mainwindow.h:
2326
2327 2011-03-23  Martin Robinson  <mrobinson@igalia.com>
2328
2329         Reviewed by Xan Lopez.
2330
2331         [GTK] Force DumpRenderTree to use 96 DPI
2332         https://bugs.webkit.org/show_bug.cgi?id=56866
2333
2334         Make sure that GTK+ is set to use 96 DPI when running tests. This ensures
2335         broader compatibility with WebKit2 and makes setting font sizes more straightforward.
2336
2337         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2338         (initializeGtkFontSettings): Set the screen resolution and GTK+ xft property to 96 DPI.
2339         (resetDefaultsToConsistentValues):Remove the call which repeatedly set the GDK screen resolution.
2340         (setDefaultsToConsistentStateValuesForTesting): Update the font sizes to reflect the new DPI.
2341
2342 2011-03-25  Andy Estes  <aestes@apple.com>
2343
2344         Reviewed by Adele Peterson.
2345
2346         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
2347         https://bugs.webkit.org/show_bug.cgi?id=49016
2348
2349         TestNetscapePlugIn needs to register support for an image MIME type so
2350         we can test that the embed tag prefers plug-ins to render image MIME
2351         types.
2352
2353         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Register image/png.
2354         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2355         (NP_GetMIMEDescription): Ditto.
2356         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Ditto.
2357
2358 2011-03-25  Jessie Berlin  <jberlin@apple.com>
2359
2360         Reviewed by Sam Weinig.
2361
2362         WebKit2: Need to be able to set and get the Cookie Storage Policy.
2363         https://bugs.webkit.org/show_bug.cgi?id=50780
2364
2365         Add a test for getting and setting the HTTP Cookie Accept Policy in WebKit2.
2366
2367         The test is named "CookieManager" so that we can eventually exercise more of the
2368         CookieManager functionality in the test.
2369
2370         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp: Added.
2371         (TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy):
2372         Assert that the policy returned is equal to the policy set in
2373         didGetUserHTTPCookieAcceptPolicy, and then restore the user's policy.
2374         (TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy):
2375         Set the policy to something different than the user's policy and get the policy again.
2376         (TestWebKitAPI::didFinishLoadForFrame):
2377         Get the user's policy so that it can be restored at the end of the test.
2378         (TestWebKitAPI::TEST):
2379         Load about:blank so that the Web Process gets instatiated (needed to get the
2380         CookieManager).
2381
2382         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2383         Add CookieManager.cpp.
2384
2385 2011-03-24  Kevin Ollivier  <kevino@theolliviers.com>
2386
2387         [wx] Fix the build so that gcc-4.1 and up can be used to build on SnowLeopard.
2388
2389         * wx/build/settings.py:
2390
2391 2011-03-24  Ilya Sherman  <isherman@chromium.org>
2392
2393         Reviewed by Adam Roben.
2394
2395         Implement layoutTestController.setAutoFilled in DRT on Windows
2396         https://bugs.webkit.org/show_bug.cgi?id=56828
2397
2398         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2399         (LayoutTestController::setAutofilled): Implemented.
2400
2401 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
2402
2403         Unreviewed build correction.
2404
2405         Correct vsprops file for Debug variant of the CFLite build.
2406         Disable a CFNETWORK-specific test when building for CFLite.
2407
2408         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops:
2409         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2410
2411 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
2412
2413         Reviewed by Adam Barth.
2414
2415         fix regressions introduced in 81908 - there were a couple of
2416         code paths that only fired under python 2.5 that I missed.
2417
2418         Also change a couple of 'python' references to sys.executable
2419         in order to handle runing test-webkitpy with a binary other than
2420         something called 'python'.
2421
2422         https://bugs.webkit.org/show_bug.cgi?id=57063
2423
2424         * Scripts/webkitpy/layout_tests/port/mac.py:
2425         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2426         * Scripts/webkitpy/test/cat.py:
2427         * Scripts/webkitpy/test/echo.py:
2428
2429 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
2430
2431         Unreviewed build correction.
2432
2433         Add a stub implementation of the TestInvocation dumping logic.
2434         Update project files to reflect new file.
2435
2436         * WebKitTestRunner/cairo: Added.
2437         * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added.
2438         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2439         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2440
2441 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
2442
2443         Reviewed by Tony Chang.
2444
2445         new-run-webkit-tests: clean up worker model defaults. This
2446         changes the default behavior to 'threads' instead of
2447         'old-threads', and clarifies that chromium-win-* and
2448         chromium-mac-leopard are exceptions.
2449
2450         https://bugs.webkit.org/show_bug.cgi?id=56971
2451
2452         * Scripts/webkitpy/layout_tests/port/base.py:
2453         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2454         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2455         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2456         * Scripts/webkitpy/layout_tests/port/test.py:
2457         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2458
2459 2011-03-23  Leandro Gracia Gil  <leandrogracia@chromium.org>
2460
2461         Reviewed by Darin Adler.
2462
2463         Media Stream API: fix the order of the options in build-webkit.
2464         https://bugs.webkit.org/show_bug.cgi?id=56949
2465
2466         Fix the order of the options in build-webkit.
2467
2468         * Scripts/build-webkit:
2469
2470 2011-03-23  Adam Klein  <adamk@chromium.org>
2471
2472         Reviewed by Mihai Parparita.
2473
2474         Add an option to new-run-webkit-httpd to allow overriding the location of LayoutTests directory
2475         https://bugs.webkit.org/show_bug.cgi?id=56884
2476
2477         This option will be utilized by Chromium's ui_tests to allow
2478         referencing js-test-resources from a layout test over HTTP.
2479
2480         * Scripts/new-run-webkit-httpd:
2481         Added --layout_tests_dir option.
2482         * Scripts/webkitpy/layout_tests/port/http_server.py:
2483         Plumbed through as layout_tests_dir param.
2484
2485 2011-03-23  Dirk Pranke  <dpranke@chromium.org>
2486
2487         Reviewed by Mihai Parparita.
2488
2489         new-run-webkit-tests: run tests in ascending alphabetical order per
2490         dir. This is a second attempt at the fix; the first attempt, in 
2491         r81597, broke the behavior on the old-inline and old-threads
2492         worker models.
2493
2494         https://bugs.webkit.org/show_bug.cgi?id=56760
2495
2496         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2497         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2498         * Scripts/webkitpy/layout_tests/port/test.py:
2499         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2500
2501 2011-03-23  Mario Sanchez Prada  <msanchez@igalia.com>
2502
2503         Reviewed by Martin Robinson.
2504
2505         [GTK] GTK's DRT to ouput detail's string for the 'property-change' signal
2506         https://bugs.webkit.org/show_bug.cgi?id=56953
2507
2508         Print the string for the detail of 'property-change' signal.
2509
2510         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
2511         (axObjectEventListener): Print the detail string.
2512
2513 2011-03-23  Yury Semikhatsky  <yurys@chromium.org>
2514
2515         Reviewed by Pavel Feldman.
2516
2517         [V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
2518         https://bugs.webkit.org/show_bug.cgi?id=56843
2519
2520         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2521         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2522
2523 2011-03-22  Eric Seidel  <eric@webkit.org>
2524
2525         Reviewed by Adam Barth.
2526
2527         Teach update-webkit about gyp
2528         https://bugs.webkit.org/show_bug.cgi?id=56881
2529
2530         This makes it possible for someone who builds from Xcode
2531         to just run update-webkit --gyp and have the project files
2532         generated after update automatically.
2533
2534         I also added a stand-alone "generate-project-files" script
2535         wrapping Source/gyp/configure.  This makes running gyp simpler
2536         since most people will not have gyp or Source/gyp in their path.
2537
2538         * Scripts/build-webkit:
2539         * Scripts/generate-project-files: Added.
2540         * Scripts/update-webkit:
2541
2542 2011-03-22  Anton D'Auria  <adauria@apple.com>
2543
2544         Reviewed by Alexey Proskuryakov.
2545
2546         Add +[WebApplicationCache getOriginsWithCache]
2547         https://bugs.webkit.org/show_bug.cgi?id=56722
2548
2549         * DumpRenderTree/LayoutTestController.cpp:
2550         (originsWithApplicationCacheCallback):
2551         (LayoutTestController::staticFunctions):
2552         * DumpRenderTree/LayoutTestController.h:
2553         * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
2554         (LayoutTestController::originsWithApplicationCache):
2555         * DumpRenderTree/chromium/LayoutTestController.h:
2556         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
2557         (LayoutTestController::originsWithApplicationCache):
2558         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Pass array of origin's database identifiers.
2559         (originsArrayToJS): Helper function for converting array of WebSecurityOrigins to a JS array of origin identifiers.
2560         (LayoutTestController::originsWithApplicationCache):
2561         (LayoutTestController::originsWithLocalStorage):
2562         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
2563         (LayoutTestController::originsWithApplicationCache):
2564         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2565         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
2566         (LayoutTestController::originsWithApplicationCache):
2567         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Added stub.
2568         (LayoutTestController::originsWithApplicationCache):
2569
2570 2011-03-22  Eric Seidel  <eric@webkit.org>
2571
2572         Reviewed by Adam Barth.
2573
2574         Add support to build-webkit for building with gyp-generated project files
2575         https://bugs.webkit.org/show_bug.cgi?id=56877
2576
2577         build-webkit is a cesspool.  This change just hacks in --gyp support for Mac.
2578         Eventually we'll want to support gyp-generated projects in a more general manner.
2579
2580         * Scripts/build-webkit:
2581
2582 2011-03-22  David Kilzer  <ddkilzer@apple.com>
2583
2584         <http://webkit.org/b/56781> Add --dsym switch to enable dsym generation when building with Xcode
2585
2586         Reviewed by Joseph Pecoraro.
2587
2588         * Scripts/build-webkit: Updated usage statement to include
2589         --dsym.
2590         * Scripts/webkitdirs.pm: Added $generateDsym variable.
2591         (generateDsym): Added. Call determineGenerateDsym() and
2592         return $generateDsym.
2593         (determineGenerateDsym): Added.  Parse @ARGV for --dsym and set
2594         $generateDsym.
2595         (argumentsForXcode): Added.  Returns additional arguments for
2596         xcodebuild based on command-line switches.
2597         (XcodeOptions): Updated to include argumentsForXcode() in the
2598         array returned.
2599
2600 2011-03-22  Adam Roben  <aroben@apple.com>
2601
2602         Make Leopard Debug bots and Windows XP Debug (Tests) core builders
2603
2604         These bots are consistently green again.
2605
2606         Fixes <http://webkit.org/b/56830> Leopard Debug bots and Windows XP Debug (Tests) should be
2607         core builders
2608
2609         Rubber-stamped by Antti Koivisto.
2610
2611         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2612         (BuildBot.__init__): Loosened the regexps for Leopard and Windows.
2613
2614         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2615         (BuildBotTest.test_builder_name_regexps): Updated expectations.
2616
2617 2011-03-21  Sheriff Bot  <webkit.review.bot@gmail.com>
2618
2619         Unreviewed, rolling out r81597.
2620         http://trac.webkit.org/changeset/81597
2621         https://bugs.webkit.org/show_bug.cgi?id=56801
2622
2623         Change results in lots of unexpected flaky on the dashboard.
2624         (Requested by pfeldman on #webkit).
2625
2626         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2627         * Scripts/webkitpy/layout_tests/port/test.py:
2628         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2629
2630 2011-03-21  Sam Weinig  <sam@webkit.org>
2631
2632         Fix failing tests on the WebKit2 bots.
2633
2634         * WebKitTestRunner/TestController.cpp:
2635         (WTR::TestController::resetStateToConsistentValues):
2636
2637 2011-03-21  Daniel Sievers  <sievers@google.com>
2638
2639         Reviewed by Simon Fraser.
2640
2641         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
2642         https://bugs.webkit.org/show_bug.cgi?id=56139
2643
2644         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2645         (main):
2646         * DumpRenderTree/chromium/LayoutTestController.cpp:
2647         (LayoutTestController::LayoutTestController):
2648         (LayoutTestController::layerTreeAsText):
2649         * DumpRenderTree/chromium/LayoutTestController.h:
2650         (LayoutTestController::setShowDebugLayerTree):
2651         * DumpRenderTree/chromium/TestShell.cpp:
2652         (TestShell::runFileTest):
2653         (TestShell::dump):
2654         * DumpRenderTree/chromium/TestShell.h:
2655         (TestParams::TestParams):
2656
2657 2011-03-21  Adam Roben  <aroben@apple.com>
2658
2659         Try again to get buildbot to show run-javascriptcore-tests's actual.html as an HTML file
2660
2661         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
2662         output as plain text
2663
2664         Reviewed by David Kilzer.
2665
2666         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2667         (RunJavaScriptCoreTests): List actual.html as one of our log files so it will get uploaded
2668         to the master.
2669         (RunJavaScriptCoreTests.commandComplete): Reading the actual.html file here won't work,
2670         since we're running on the build master, not the slave. Instead, turn the raw source of
2671         actual.html which the build slave uploaded into an HTML log.
2672
2673 2011-03-21  Dirk Pranke  <dpranke@chromium.org>
2674
2675         Reviewed by Mihai Parparita.
2676
2677         new-run-webkit-tests: run tests in ascending alphabetical order per dir
2678         https://bugs.webkit.org/show_bug.cgi?id=56760
2679
2680         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2681         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2682         * Scripts/webkitpy/layout_tests/port/test.py:
2683
2684 2011-03-21  Leandro Gracia Gil  <leandrogracia@chromium.org>
2685
2686         Reviewed by Steve Block.
2687
2688         Media Stream API patch 0: adding compilation guards.
2689         https://bugs.webkit.org/show_bug.cgi?id=56458
2690
2691         Adding options to enable the media stream API feature in Chromium.
2692
2693         * Scripts/build-webkit:
2694
2695 2011-03-21  Qi Zhang  <qi.2.zhang@nokia.com>
2696
2697         Reviewed by Laszlo Gombos.
2698
2699         [Qt] Add a command line option to capture stdout and stderr for DumpRenderTree
2700         https://bugs.webkit.org/show_bug.cgi?id=56323
2701
2702         Using freopen to redirect STDOUT and STDERR when DumpRenderTree command line provide 
2703         "--stdout" or "--stderr" option.
2704
2705         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2706         (WebCore::DumpRenderTree::~DumpRenderTree):
2707         (WebCore::DumpRenderTree::processArgsLine):
2708         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
2709         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2710         (WebCore::DumpRenderTree::setRedirectOutputFileName):
2711         (WebCore::DumpRenderTree::setRedirectErrorFileName):
2712         * DumpRenderTree/qt/main.cpp:
2713         (isOption):
2714         (takeOptionValue):
2715         (printUsage):
2716         (main):
2717
2718 2011-03-21  Adam Roben  <aroben@apple.com>
2719
2720         Fix exceptions on the buildbot due to my last change
2721
2722         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2723         (RunJavaScriptCoreTests.commandComplete): Catch exceptions due to actual.html not existing.
2724
2725 2011-03-21  Adam Roben  <aroben@apple.com>
2726
2727         Teach buildbot to treat run-javascriptcore-tests's actual.html as an HTML file
2728
2729         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
2730         output as plain text
2731
2732         Reviewed by Darin Adler.
2733
2734         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2735         (RunJavaScriptCoreTests): Removed the logfiles variable, which can only handle plaintext
2736         logs.
2737         (RunJavaScriptCoreTests.commandComplete): Use the addHTMLLog method to upload actual.html to
2738         the build master. This will correctly treat it as HTML.
2739
2740 2011-03-20  Bill Budge  <bbudge@chromium.org>
2741
2742         Reviewed by Adam Barth.
2743
2744         Rename ThreadSafeShared to ThreadSafeRefCounted
2745         https://bugs.webkit.org/show_bug.cgi?id=56714
2746
2747         No new tests. Exposes no new functionality.
2748
2749         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeRefCounted.h: Copied from DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h.
2750         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
2751         * Scripts/do-webcore-rename:
2752
2753 2011-03-19  Anton D'Auria  <adauria@apple.com>
2754
2755         Reviewed by Dan Bernstein.
2756
2757         Add stub to LayoutTestControllerGtk.cpp to fix GTK build
2758         https://bugs.webkit.org/show_bug.cgi?id=56719
2759
2760         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Adding stub.
2761         (LayoutTestController::clearApplicationCacheForOrigin):
2762
2763 2011-03-19  Anton D'Auria  <adauria@apple.com>
2764
2765         Reviewed by Alexey Proskuryakov.
2766
2767         ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
2768         https://bugs.webkit.org/show_bug.cgi?id=56415
2769
2770         * DumpRenderTree/LayoutTestController.cpp:
2771         (clearApplicationCacheForOriginCallback):
2772         (LayoutTestController::staticFunctions):
2773         * DumpRenderTree/LayoutTestController.h:
2774         * DumpRenderTree/chromium/LayoutTestController.cpp: Adding stubs.
2775         (LayoutTestController::LayoutTestController):
2776         (LayoutTestController::clearAllApplicationCaches):
2777         (LayoutTestController::clearApplicationCacheForOrigin): 
2778         * DumpRenderTree/chromium/LayoutTestController.h:
2779         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Adding stub.
2780         (LayoutTestController::clearApplicationCacheForOrigin):
2781         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Adding stub.
2782         (LayoutTestController::clearApplicationCacheForOrigin):
2783         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2784         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Adding stub.
2785         (LayoutTestController::clearApplicationCacheForOrigin):
2786         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Adding stub.
2787         (LayoutTestController::clearApplicationCacheForOrigin):
2788
2789 2011-03-18  Dan Bernstein  <mitz@apple.com>
2790
2791         Revised build fix for r81135.
2792
2793         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
2794         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2795
2796 2011-03-18  Adam Roben  <aroben@apple.com>
2797
2798         Windows build fix
2799
2800         * WebKitTestRunner/config.h: Add a missing #endif.
2801
2802 2011-03-18  Andreas Kling  <kling@webkit.org>
2803
2804         Unbreak Qt build after r81494.
2805
2806         * WebKitTestRunner/qt/TestInvocationQt.cpp:
2807         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2808
2809 2011-03-18  Sam Weinig  <sam@webkit.org>
2810
2811         Fix windows build. This was really Adam Roben's fault. I swear!
2812
2813         * WebKitTestRunner/config.h:
2814
2815 2011-03-18  Sam Weinig  <sam@webkit.org>
2816
2817         Reviewed by Adam Roben.
2818
2819         Pixel tests don't work in WebKitTestRunner on Windows
2820         https://bugs.webkit.org/show_bug.cgi?id=56630
2821
2822         Cross-platformize (Mac and Windows CG) the pixel dumping code in WebKitTestRunner to use WebKit2
2823         built-in snapshotting instead of using the window server on the Mac.
2824
2825         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2826         (WTR::InjectedBundle::InjectedBundle):
2827         (WTR::InjectedBundle::didReceiveMessage):
2828         (WTR::InjectedBundle::beginTesting):
2829         (WTR::InjectedBundle::done):
2830         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2831         (WTR::InjectedBundle::setPixelResult):
2832         (WTR::InjectedBundle::shouldDumpPixels):
2833         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2834         (WTR::InjectedBundlePage::dump):
2835         Take the snapshot in the bundle and send it to the UIProcess for dumping.
2836
2837         * WebKitTestRunner/TestInvocation.cpp:
2838         (WTR::TestInvocation::invoke):
2839         (WTR::TestInvocation::dump):
2840         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2841         * WebKitTestRunner/TestInvocation.h:
2842         * WebKitTestRunner/cg: Added.
2843         * WebKitTestRunner/cg/TestInvocationCG.cpp: Copied from WebKitTestRunner/mac/TestInvocationMac.mm.
2844         (WTR::createCGContextFromImage):
2845         (WTR::computeMD5HashStringForContext):
2846         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2847         * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
2848         Making pixel dumping code shared for CG ports. Also use the WTF/MD5 instead of platform specific code.
2849
2850         * WebKitTestRunner/win/TestInvocationWin.cpp:
2851         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2852         Keep stub for Cairo build.
2853
2854         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Added.
2855         Add CG configuration.
2856
2857         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2858         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2859         Add new files.
2860
2861 2011-03-18  Adam Roben  <aroben@apple.com>
2862
2863         Don't allow Leaks Viewer's vertical scrollbar to cover up long function names
2864
2865         Rubber-stamped by Simon Fraser.
2866
2867         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
2868         (.data-grid .data-container): Use overflow-y:auto instead of the Inspector's default
2869         overflow-y:overlay so that the scrollbar doesn't overlay the content.
2870
2871 2011-03-18  Adam Roben  <aroben@apple.com>
2872
2873         Don't ellipsize long or indented function names in Leaks Viewer
2874
2875         Fixes <http://webkit.org/b/56037> Leaks viewer needs horizontal
2876         scrollbar
2877
2878         Reviewed by Simon Fraser.
2879
2880         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
2881         (.data-grid .data-container):
2882         (.data-grid td > div, .data-grid th > div):
2883         Allow the contents to extend to the right.
2884
2885 2011-03-18  Adam Roben  <aroben@apple.com>
2886
2887         Fix some leaks in DRT seen on the leaks bot
2888
2889         Fixes <http://webkit.org/b/56638> addURLToRedirectCallback and
2890         setWillSendRequestClearHeaderCallback in DRT are leaky
2891
2892         Reviewed by Alexey Proskuryakov.
2893
2894         * DumpRenderTree/ForwardingHeaders/wtf/OwnArrayPtr.h: Added.
2895
2896         * DumpRenderTree/LayoutTestController.cpp:
2897         (addURLToRedirectCallback):
2898         (setWillSendRequestClearHeaderCallback):
2899         Use OwnArrayPtr to cause the strings to be deleted.
2900
2901 2011-03-18  Adam Roben  <aroben@apple.com>
2902
2903         Fix a NSURLCredential leak seen on the leaks bot
2904
2905         Fixes <http://webkit.org/b/56637> -[SynchronousLoader
2906         connection:didReceiveAuthenticationChallenge:] is leaky
2907
2908         Reviewed by John Sullivan.
2909
2910         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2911         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]): Use a RetainPtr to
2912         cause the NSURLCredential to be released.
2913
2914 2011-03-18  John Knottenbelt  <jknotten@chromium.org>
2915
2916         Unreviewed.
2917
2918         Remove unnecessary brackets around my email address.
2919
2920         * Scripts/webkitpy/common/config/committers.py:
2921
2922 2011-03-18  Adam Roben  <aroben@apple.com>
2923         
2924         Remove some files I accidentally added in r81454
2925
2926         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Removed.
2927         * WebKitTestRunner/cg/TestInvocationCG.cpp: Removed.
2928
2929 2011-03-18  Adam Roben  <aroben@apple.com>
2930
2931         Ignore an NSNumberFormatter leak on SnowLeopard
2932
2933         * Scripts/old-run-webkit-tests:
2934         (countAndPrintLeaks): Ignore leaks in -[NSNumberFormatter
2935         getObjectValue:forString:errorDescription:].
2936
2937 2011-03-18  Adam Roben  <aroben@apple.com>
2938
2939         Fix a leak beneath LayoutTestController::authenticateSession seen on the bots
2940
2941         Rubber-stamped by Mark Rowe.
2942
2943         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2944         (LayoutTestController::authenticateSession): Use a RetainPtr to cause the NSURLRequest to be
2945         released.
2946
2947 2011-03-17  Adam Roben  <aroben@apple.com>
2948
2949         Address a review comment I missed in r81445
2950
2951         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
2952         (LeaksParserWorker.prototype._parseLeaks): Anchor the RegExp used to find the number of
2953         leaked bytes to speed up searching on long lines.
2954
2955 2011-03-17  Adam Roben  <aroben@apple.com>
2956
2957         Mark leaky builds orange, even if all regression tests passed
2958
2959         Fixes <http://webkit.org/b/56609> SnowLeopard Intel Leaks bot appears green on
2960         build.webkit.org when all tests pass even though there are still leaks
2961
2962         Reviewed by Dan Bernstein.
2963
2964         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2965         (RunWebKitLeakTests): Set the warnOnWarnings property to True so that the entire build will
2966         be marked orange if this build step generates warnings.
2967
2968 2011-03-17  Adam Roben  <aroben@apple.com>
2969
2970         Allow values in Leaks Viewer to be shown as percentages
2971
2972         Double-clicking on a column will toggle between showing percentages and showing real values.
2973
2974         Fixes <http://webkit.org/b/56628> Would like to view values as percentages of the total
2975         number of leaked bytes in Leaks Viewer
2976
2977         Reviewed by Joe Pecoraro.
2978
2979         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
2980         (LeaksParserWorker.prototype._incorporateLeaks): Calculate the (never-shown) top-level
2981         node's totalTime, which is used in calculating percentages.
2982
2983         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
2984         (monkeyPatchInspectorObjects): Only format values as bytes if we aren't supposed to be
2985         showing them as percentages.
2986
2987 2011-03-17  Adam Roben  <aroben@apple.com>
2988
2989         Show the number of leaked bytes, not just leaked allocations, in Leaks Viewer
2990
2991         The Self and Total columns now report the number of leaked bytes. The new Calls column shows
2992         the number of leaked allocations. And the new Average column shows the average number of
2993         leaked bytes per call.
2994
2995         Fixes <http://webkit.org/b/56344> Leaks Viewer should show how many bytes were leaked, not
2996         just how many allocations
2997
2998         Reviewed by Joe Pecoraro.
2999
3000         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
3001         (LeaksParserWorker.prototype._parseLeaks): Parse the number of leaked bytes from the "Leak:"
3002         line and store it with the leak stack.
3003         (LeaksParserWorker.prototype._createNode): Initialize the averageTime and numberOfCalls
3004         properties.
3005         (LeaksParserWorker.prototype._incorporateLeaks): Updated to get the stack from the .stack
3006         property, and changed to store the number of leaked bytes in .selfTime/.totalTime.
3007         .numberOfCalls now holds the number of leaked allocations.
3008
3009         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
3010         (Preferences): Set samplingCPUProfiler to false so that the Average and Calls columns will
3011         appear.
3012         (monkeyPatchInspectorObjects): Format the values as bytes.
3013
3014 2011-03-17  Adam Roben  <aroben@apple.com>
3015
3016         Make Leaks Viewer able to count leaks in builds that didn't fail any regression tests
3017
3018         Fixes <http://webkit.org/b/56626> Leaks Viewer omits recent builds which didn't fail any
3019         regression tests
3020
3021         Reviewed by James Robinson.
3022
3023         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
3024         (RecentBuildsLoader.prototype.start): Get the number of leaks out of the "text" array, which
3025         is always populated, even when all regression tests pass.
3026
3027 2011-03-10  Hayato Ito  <hayato@chromium.org>
3028
3029         Reviewed by Tony Chang.
3030
3031         Add a check logic for reftests in case that a reftest is marked AS REBASELINE.
3032
3033         https://bugs.webkit.org/show_bug.cgi?id=56076
3034
3035         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3036
3037 2011-03-17  Adam Roben  <aroben@apple.com>
3038
3039         Skip a compositing-sensitive test when accelerated compositing is disabled
3040
3041         Reviewed by Sam Weinig.
3042
3043         * Scripts/old-run-webkit-tests: Skip media/media-document-audio-repaint.html when
3044         accelerated compositing is disabled.
3045
3046 2011-03-17  Adam Roben  <aroben@apple.com>
3047
3048         Start using PlatformSpecificScheduler for the Mac builders
3049
3050         The current set of file/directory patterns should work for Mac builders. We may discover
3051         that there are more files and directories we can exclude from the Mac builds, but they can
3052         be added later.
3053
3054         Fixes <http://webkit.org/b/56593> Mac builders do lots of unnecessary builds
3055
3056         Reviewed by Mark Rowe.
3057
3058         * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the Mac builders into two
3059         PlatformSpecificSchedulers: one for Leopard, and one for SnowLeopard.
3060
3061         * Scripts/webkitpy/common/config/build.py:
3062         (_should_file_trigger_build): Allow "mac-leopard" and "mac-snowleopard" platforms, and
3063         cleaned up patterns a little bit.
3064
3065         * Scripts/webkitpy/common/config/build_unittest.py:
3066         (ShouldBuildTest): Fixed some expected results.
3067         (ShouldBuildTest.test_should_build): Start testing "mac-leopard" and "mac-snowleopard"
3068         platforms.
3069
3070 2011-03-17  Jeff Miller  <jeffm@apple.com>
3071
3072         Use a consistent set of file patterns in the svn:ignore property for all .xcodeproj directories, specifically:
3073         
3074         *.mode*
3075         *.pbxuser
3076         *.perspective*
3077         project.xcworkspace
3078         xcuserdata
3079
3080         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
3081         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
3082         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
3083         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
3084         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
3085
3086 2011-03-17  Adam Roben  <aroben@apple.com>
3087
3088         Make old-run-webkit-tests pick up mac-wk2 results when running in WebKit2 mode on Windows
3089
3090         Fixes <http://webkit.org/b/56563> Running WebKit2 tests on Windows should use results from
3091         mac-wk2
3092
3093         Reviewed by Anders Carlsson.
3094
3095         * Scripts/old-run-webkit-tests:
3096         (expectedDirectoryForTest): Clean up the code to search in extra Mac platform result
3097         directories on Windows. Add mac-wk2 to the set of extra platforms we look in on Windows when
3098         we're running in WebKit2 mode.
3099
3100 2011-03-17  Mikhail Naganov  <mnaganov@chromium.org>
3101
3102         Reviewed by Yury Semikhatsky.
3103
3104         Web Inspector: Clean up Inspector strings.
3105         https://bugs.webkit.org/show_bug.cgi?id=56557
3106
3107         Modify the script to deal correctly with "\xNN" escapes, and to
3108         check strings in Chromium's DevTools.js.
3109
3110         * Scripts/check-inspector-strings:
3111
3112 2011-03-17  Keith Kyzivat  <keith.kyzivat@nokia.com>
3113
3114         Reviewed by Benjamin Poulain.
3115
3116         Update autoinstall to install mechanize 0.2.4
3117         https://bugs.webkit.org/show_bug.cgi?id=56499
3118
3119         Newer versions of mechanize support HTTPS proxies, which is necessary
3120         for people using webkit-patch behind firewalls.
3121
3122         * Scripts/webkitpy/common/system/autoinstall.py:
3123         * Scripts/webkitpy/thirdparty/__init__.py:
3124
3125 2011-03-16  Sam Weinig  <sam@webkit.org>
3126
3127         Reviewed by Adam Roben.
3128
3129         REGRESSION (r81084): media/invalid-media-url-crash.html and editing/execCommand/indent-paragraphs.html failing on WebKit2
3130         https://bugs.webkit.org/show_bug.cgi?id=56541
3131
3132         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3133         (WTR::InjectedBundlePage::willSendRequestForFrame):
3134         Check for an empty host in addition to a null host.  This bug was introduced
3135         when porting off of the KURL code and onto the WKURLRef version.
3136
3137 2011-03-16  Sam Weinig  <sam@webkit.org>
3138
3139         Reviewed by Adam Roben.
3140
3141         Add Lucas Forschler to the list of WebKit committers.
3142
3143         * Scripts/webkitpy/common/config/committers.py:
3144
3145 2011-03-16  Sam Weinig  <sam@webkit.org>
3146
3147         Reviewed upon and dictated through Adam Roben.
3148
3149         Escape crashing function names in results.html. This fixes an issue
3150         when a crash involves a type with templates.
3151
3152         * Scripts/old-run-webkit-tests:
3153
3154 2011-03-16  Daniel Sievers  <sievers@google.com>
3155
3156         Reviewed by James Robinson.
3157
3158         Add setting to always force compositing mode
3159         https://bugs.webkit.org/show_bug.cgi?id=56156
3160
3161         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3162         (main):
3163         * DumpRenderTree/chromium/TestShell.cpp:
3164         (TestShell::TestShell):
3165         (TestShell::resetWebSettings):
3166         * DumpRenderTree/chromium/TestShell.h:
3167         (TestShell::setForceCompositingMode):
3168         * DumpRenderTree/chromium/WebPreferences.cpp:
3169         (WebPreferences::reset):
3170         (WebPreferences::applyTo):
3171         * DumpRenderTree/chromium/WebPreferences.h:
3172
3173 2011-03-15  Hayato Ito  <hayato@chromium.org>
3174
3175         Reviewed by Ojan Vafai.
3176
3177         Ignore files that will be used by reftests in old-run-webkit-tests.
3178
3179         https://bugs.webkit.org/show_bug.cgi?id=55936
3180
3181         * Scripts/old-run-webkit-tests:
3182
3183 2011-03-15  Felipe Oliveira da Silva Netto  <f.dachshund@gmail.com>
3184
3185         Reviewed by Adam Roben.
3186
3187         Function relativeScriptsDir doesn't return the correct relative
3188         Scripts directory.
3189
3190         * Scripts/webkitdirs.pm:
3191         (relativeScriptsDir): Ensure we use the directory that contains
3192         webkitdirs.pm, not the one that contains the original script that
3193         was invoked.
3194
3195 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
3196
3197         [wx] Build fixes for long linker commands on Win and method return error, plus a Mac
3198         fix to link against the Security framework after recent WebKitSystemInterface changes.
3199
3200         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3201         (LayoutTestController::originsWithLocalStorage):
3202         * wx/build/settings.py:
3203         * wx/build/waf_extensions.py:
3204
3205 2011-03-15  Sam Weinig  <sam@webkit.org>
3206
3207         Reviewed by Darin Adler.
3208
3209         Add script to convert a patch to a prettypatch and show in the default browser
3210         https://bugs.webkit.org/show_bug.cgi?id=56416
3211
3212         This can be used either like
3213             $ svn-create-patch | show-pretty-diff
3214         or
3215             $ show-pretty-diff patch.diff
3216
3217         * Scripts/show-pretty-diff: Added.
3218
3219 2011-03-15  Brian Weinstein  <bweinstein@apple.com>
3220
3221         Rubber-stamped by Adam Roben.
3222
3223         Adding myself as a reviewer.
3224
3225         * Scripts/webkitpy/common/config/committers.py:
3226
3227 2011-03-15  Anders Carlsson  <andersca@apple.com>
3228
3229         Try to fix the Windows build.
3230
3231         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
3232         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
3233
3234 2011-03-15  Anders Carlsson  <andersca@apple.com>
3235
3236         Reviewed by Sam Weinig.
3237
3238         Make sure that NP_Shutdown is always the last NPP function called
3239         https://bugs.webkit.org/show_bug.cgi?id=56391
3240
3241         Add a test that times out if an NP_Deallocate object is called after NP_Shutdown.
3242
3243         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3244         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3245         (PluginTest::PluginTest):
3246         (PluginTest::NP_Shutdown):
3247         (PluginTest::registerNPShutdownFunction):
3248         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3249         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp: Added.
3250         (NPDeallocateCalledBeforeNPShutdown::NPDeallocateCalledBeforeNPShutdown):
3251         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
3252         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::hasProperty):
3253         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::getProperty):
3254         (NPDeallocateCalledBeforeNPShutdown::NPP_New):
3255         (NPDeallocateCalledBeforeNPShutdown::NPP_GetValue):
3256         (NPDeallocateCalledBeforeNPShutdown::shutdown):
3257         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3258         (NP_Shutdown):
3259         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3260         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3261         * GNUmakefile.am:
3262
3263 2011-03-15  Ilya Sherman  <isherman@chromium.org>
3264
3265         Reviewed by Tony Chang.
3266
3267         Autofilled form elements are assigned fixed background color but not text color
3268         https://bugs.webkit.org/show_bug.cgi?id=48382
3269
3270         * DumpRenderTree/LayoutTestController.cpp:
3271         (setAutofilledCallback): Added.
3272         (LayoutTestController::staticFunctions):
3273         * DumpRenderTree/LayoutTestController.h:
3274         * DumpRenderTree/chromium/LayoutTestController.cpp:
3275         (LayoutTestController::LayoutTestController):
3276         (LayoutTestController::setAutofilled): Added.
3277         * DumpRenderTree/chromium/LayoutTestController.h:
3278         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3279         (LayoutTestController::setAutofilled): Added.
3280         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3281         (LayoutTestController::setAutofilled): Added.
3282         (LayoutTestController::setValueForUser): Style tweak.
3283         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3284         (LayoutTestController::setAutofilled): Added (stub).
3285         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3286         (LayoutTestController::setAutofilled): Added (stub).
3287
3288 2011-03-15  Dan Bernstein  <mitz@apple.com>
3289
3290         Build fix after r81135.
3291
3292         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
3293
3294 2011-03-15  Dan Bernstein  <mitz@apple.com>
3295
3296         Build fix after r81135.
3297
3298         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
3299         * WebKitTestRunner/mac/TestControllerMac.mm:
3300         * WebKitTestRunner/mac/TestInvocationMac.mm:
3301         * WebKitTestRunner/mac/main.mm:
3302
3303 2011-03-15  Balazs Kelemen  <kbalazs@webkit.org>
3304
3305         Reviewed by Adam Barth.
3306
3307         REGRESSION(80977): breaks Qt ARMv7 Linux Release bot
3308         https://bugs.webkit.org/show_bug.cgi?id=56349
3309
3310         * QtTestBrowser/QtTestBrowser.pro: Link against fontconfig
3311         on platforms where we use it. Copied from DumpRenderTree.pro.
3312
3313 2011-03-15  Dan Bernstein  <mitz@apple.com>
3314
3315         Build fix after r81135.
3316
3317         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
3318         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
3319
3320 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
3321
3322         Reviewed by Darin Adler.
3323
3324         Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
3325         info into the headers rather than in export symbol definition files, but disable it on 
3326         all platforms initially so we can deal with port build issues one port at a time.
3327         
3328         https://bugs.webkit.org/show_bug.cgi?id=27551
3329
3330         * DumpRenderTree/cg/ImageDiffCG.cpp:
3331         * DumpRenderTree/chromium/config.h:
3332         * DumpRenderTree/config.h:
3333         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3334         * TestWebKitAPI/TestWebKitAPIPrefix.h:
3335         * WebKitAPITest/HostWindow.cpp:
3336         * WebKitAPITest/TestsController.cpp:
3337         * WebKitAPITest/config.h: Added.
3338         * WebKitAPITest/main.cpp:
3339         * WebKitAPITest/tests/WebViewDestruction.cpp:
3340         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
3341         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3342         * WebKitTestRunner/InjectedBundle/GCController.cpp:
3343         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3344         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
3345         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3346         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3347         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3348         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
3349         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
3350         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:
3351         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:
3352         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
3353         * WebKitTestRunner/TestController.cpp:
3354         * WebKitTestRunner/TestInvocation.cpp:
3355         * WebKitTestRunner/config.h: Added.
3356         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3357         * WebKitTestRunner/qt/TestControllerQt.cpp:
3358         * WebKitTestRunner/qt/TestInvocationQt.cpp:
3359         * WebKitTestRunner/qt/main.cpp:
3360         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3361         * WebKitTestRunner/win/TestControllerWin.cpp:
3362         * WebKitTestRunner/win/TestInvocationWin.cpp:
3363         * WebKitTestRunner/win/main.cpp:
3364         * wx/build/settings.py:
3365
3366 2011-03-15  Hayato Ito  <hayato@chromium.org>
3367
3368         Reviewed by Shinichiro Hamaji.
3369
3370         [NRWT] Add support for reftests to new-run-webkit-tests.
3371
3372         https://bugs.webkit.org/show_bug.cgi?id=55457
3373
3374         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
3375         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3376         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
3377         * Scripts/webkitpy/layout_tests/port/base.py:
3378         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3379         * Scripts/webkitpy/layout_tests/port/test.py:
3380         * Scripts/webkitpy/layout_tests/port/test_files.py:
3381         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3382
3383 2011-03-15  Alejandro G. Castro  <alex@igalia.com>
3384
3385         Reviewed by Martin Robinson.
3386
3387         [GTK] Fix compilation warning after r80892
3388         https://bugs.webkit.org/show_bug.cgi?id=56302
3389
3390         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3391         (LayoutTestController::originsWithLocalStorage):
3392
3393 2011-03-15  Robert Hogan  <robert@webkit.org>
3394
3395         Reviewed by Adam Barth.
3396
3397         Document the qmakearg argument, and hint how to build webkit2 on Qt
3398         https://bugs.webkit.org/show_bug.cgi?id=56326
3399
3400         * Scripts/build-webkit: add --qmakearg to build-webkit --help
3401
3402 2011-03-15  Adam Roben  <aroben@apple.com>
3403
3404         Make Windows 7 Release (Tests) a core builder
3405
3406         We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
3407         give it a few more days of greenness first.
3408
3409         Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
3410
3411         Reviewed by Sam Weinig.
3412
3413         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3414         (BuildBot): Added a regexp to match Windows 7 Release (Tests).
3415
3416         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3417         (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
3418         Updated the core regexps to match the buildbot module. Updated the expected results to match
3419         the current set of core builders.
3420
3421 2011-03-14  Adam Roben  <aroben@apple.com>
3422
3423         Add forgotten file from r81116
3424
3425         * TestWebKitAPI/Configurations/TestWebKitAPICFNetwork.vsprops: Added.
3426
3427 2011-03-14  Sam Weinig  <sam@webkit.org>
3428
3429         Reviewed by Adam Roben.
3430
3431         about:blank fake responses don't get serialized when sent the UIProcess
3432         <rdar://problem/9108119>
3433         https://bugs.webkit.org/show_bug.cgi?id=56357
3434
3435         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: Added.
3436         (TestWebKitAPI::decidePolicyForResponse):
3437         (TestWebKitAPI::TEST):
3438         Add test that loads of about:blank have a response with a MIMEType of text/html.
3439
3440         * TestWebKitAPI/PlatformUtilities.h:
3441         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3442         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
3443         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3444         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
3445         Add helper to get the MIMEType from a WKURLResponse.
3446
3447         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3448         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3449         Add new files.
3450
3451 2011-03-14  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
3452
3453         Reviewed by Kenneth Rohde Christiansen.
3454
3455         [Qt] Command-line options for QGLWidget and WebGL to QtTestBrowser
3456         https://bugs.webkit.org/show_bug.cgi?id=56006
3457
3458         * QtTestBrowser/launcherwindow.cpp:
3459         (LauncherWindow::initializeView):
3460         * QtTestBrowser/main.cpp:
3461         (LauncherApplication::handleUserOptions):
3462
3463 2011-03-14  James Kozianski  <koz@chromium.org>
3464
3465         Reviewed by Ojan Vafai.
3466
3467         Add method to make BuildBot return test outputs
3468         https://bugs.webkit.org/show_bug.cgi?id=54374
3469
3470         The Builder.latest_cached_build will be used by the new rebaseline
3471         script to determine the build to use baselines from.
3472
3473         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3474         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3475
3476 2011-03-14  Adam Roben  <aroben@apple.com>
3477
3478         Test that WKBundlePageCanHandleRequest returns true for empty document URLs
3479
3480         Reviewed by Sam Weinig.
3481
3482         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp: Added.
3483         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Store the result of the test.
3484         (TestWebKitAPI::setInjectedBundleClient): Hook up our callback.
3485         (TestWebKitAPI::TEST): Register "emptyscheme" as an empty document scheme, load a page to
3486         ensure the web process is initialized, then ask the bundle to run the test and assert that
3487         it succeeded.
3488
3489         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp: Added.
3490         (TestWebKitAPI::CanHandleRequestTest::CanHandleRequestTest): Just call up to the base class.
3491         (TestWebKitAPI::canHandleURL): Helper function to test whether WebKit2 claims to be able to
3492         handle a given URL.
3493         (TestWebKitAPI::runTest): Check that empty document URLs can be handled (and that an unknown
3494         URL type cannot be handled).
3495         (TestWebKitAPI::CanHandleRequestTest::didReceiveMessage): Run the test and return the
3496         result.
3497
3498         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3499         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3500         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
3501         Added new files to the project.
3502
3503 2011-03-14  Sheriff Bot  <webkit.review.bot@gmail.com>
3504
3505         Unreviewed, rolling out r81094.
3506         http://trac.webkit.org/changeset/81094
3507         https://bugs.webkit.org/show_bug.cgi?id=56355
3508
3509         Broke the chromium DRT related build. (Requested by dave_levin
3510         on #webkit).
3511
3512         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3513         (main):
3514         * DumpRenderTree/chromium/LayoutTestController.cpp:
3515         (LayoutTestController::LayoutTestController):
3516         (LayoutTestController::layerTreeAsText):
3517         * DumpRenderTree/chromium/LayoutTestController.h:
3518         * DumpRenderTree/chromium/TestShell.cpp:
3519         (TestShell::runFileTest):
3520         (TestShell::dump):
3521         * DumpRenderTree/chromium/TestShell.h:
3522         (TestParams::TestParams):
3523
3524 2011-03-14  Daniel Sievers  <sievers@google.com>
3525
3526         Reviewed by Simon Fraser.
3527
3528         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
3529         https://bugs.webkit.org/show_bug.cgi?id=56139
3530
3531         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3532         (main):
3533         * DumpRenderTree/chromium/LayoutTestController.cpp:
3534         (LayoutTestController::LayoutTestController):
3535         (LayoutTestController::layerTreeAsText):
3536         * DumpRenderTree/chromium/LayoutTestController.h:
3537         (LayoutTestController::setShowDebugLayerTree):
3538         * DumpRenderTree/chromium/TestShell.cpp:
3539         (TestShell::runFileTest):
3540         (TestShell::dump):
3541         * DumpRenderTree/chromium/TestShell.h:
3542         (TestParams::TestParams):
3543
3544 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
3545
3546         Reviewed by Adam Roben.
3547
3548         [Qt][WK2]Unbreak InjectedBundle on Qt
3549         https://bugs.webkit.org/show_bug.cgi?id=54109
3550
3551         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3552         (WTR::InjectedBundlePage::willSendRequestForFrame): Use new WebKit2
3553         API's instead of KURL to analyze the URL.
3554         * WebKitTestRunner/StringFunctions.h:
3555         (WTR::adoptWK): Moved from InjectedBundlePage.cpp to make it available globally
3556         in the WebKitTestRunner project.
3557         (WTR::toWK): Use adoptWK.
3558         (WTR::operator<<): Added helper for printing a WKURL.
3559         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Do not link
3560         against WebCore.
3561
3562 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
3563
3564         Reviewed by Kenneth Rohde Christiansen.
3565
3566         check-webkit-style falsely should not complain about WebKit2 API headers in the Shared directory
3567         https://bugs.webkit.org/show_bug.cgi?id=56321
3568
3569         * Scripts/webkitpy/style/checker.py: Add the patch "Source/WebKit2/Shared/API/c"
3570         to the list of exceptions for WebKit2 C API headers.
3571
3572 2011-03-14  Adam Roben  <aroben@apple.com>
3573
3574         Show the list of recent leaky builds in reverse chronological order
3575
3576         Previously they were being shown in a deterministic but surprising order based on
3577         lexicographically sorting the build offsets (-1, -10, -2, -3...).
3578
3579         Fixes <http://webkit.org/b/56342> Leaks Viewer shows recent builds in a strange order
3580
3581         Reviewed by Darin Adler.
3582
3583         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
3584         (RecentBuildsLoader.prototype.start): Sort the builds by revision before passing them to our
3585         callback.
3586
3587 2011-03-14  Adam Roben  <aroben@apple.com>
3588
3589         Show a list of up to 10 recent leaky builds when Leaks Viewer loads
3590
3591         Fixes <http://webkit.org/b/56043> Leaks Viewer should present a list of recent builds to
3592         analyze
3593
3594         Reviewed by David Kilzer and Joe Pecoraro.
3595
3596         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
3597         (#url-prompt): Made this a bit taller to make room for the list of builds.
3598
3599         (#recent-builds-loading-indicator):
3600         (#recent-builds-list):
3601         Added styles for the build list and loading indicator.
3602
3603         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
3604         (LeaksViewer.loaded): Pass the URL from the query through decodeURIComponent before loading
3605         it. This will unescape it.
3606         (LeaksViewer.urlPromptButtonClicked): Moved code from here to _urlChosenFromPrompt.
3607         (LeaksViewer._didLoadRecentBuilds): Added. Stores the builds and updates the prompt.
3608         (LeaksViewer._displayURLPrompt): Start loading the recent leaky builds.
3609         (LeaksViewer._updateURLPrompt): Create a list of the recent leaky builds and add them to the
3610         prompt UI.
3611         (LeaksViewer._urlChosenFromPrompt): Added. Code came from urlPromptButtonClicked. This is
3612         now also used when a recent build is clicked.
3613
3614         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js: Added.
3615         (RecentBuildsLoader): Store the callback.
3616         (RecentBuildsLoader.prototype.start): Load the N most recent builds from the specified
3617         builder. Find the revision number, leak count, and results URL for each one. Pass the
3618         resulting info to our callback.
3619
3620         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
3621         (range): Added this helper function to return an array containing the integers [0, n).
3622
3623         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added
3624         RecentBuildsLoader.js and added text to the prompt UI to show the recent builds.
3625
3626 2011-03-14  Mark Rowe  <mrowe@apple.com>
3627
3628         Reviewed by Adam Roben.
3629
3630         Fix two memory leaks within LayoutTestController's storage support.
3631
3632         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3633         (LayoutTestController::originsWithLocalStorage): Don't leak the JSStringRef that is returned
3634         by JSStringCreateWithCFString.
3635         (LayoutTestController::deleteLocalStorageForOrigin): Don't leak the WebSecurityOrigin that we
3636         allocate.
3637
3638 2011-03-14  Mark Rowe  <mrowe@apple.com>
3639
3640         Reviewed by Oliver Hunt.
3641
3642         <http://webkit.org/b/56304> REGRESSION(r80892): 100,000+ leaks seen on the build bot
3643
3644         * DumpRenderTree/LayoutTestController.cpp:
3645         (LayoutTestController::staticFunctions): Remove duplicate entries.
3646
3647 2011-03-14  Alice Liu  <alice.liu@apple.com>
3648
3649         Reviewed by Dan Bernstein.
3650
3651         DumpRenderTree Perl Support fails to build with ARCHS="i386 x86_64"
3652
3653         * DumpRenderTree/mac/PerlSupport/Makefile:
3654         Add whitespace when joining "-arch" with the architectures passed in as arguments.
3655
3656 2011-03-14  Daniel Bates  <dbates@rim.com>
3657
3658         https://bugs.webkit.org/show_bug.cgi?id=55438
3659         Add double quotes around value of -DCMAKE_WINCE_SDK that I inadvertently did not add
3660         when landing changeset 81041 <http://trac.webkit.org/changeset/81041>.
3661
3662         * Scripts/build-webkit:
3663
3664 2011-03-14  Daniel Bates  <dbates@rim.com>
3665
3666         Reviewed by David Kilzer.
3667
3668         Cleanup: Separate port-specific implementation details from webkitdirs::buildCMakeProject()
3669         https://bugs.webkit.org/show_bug.cgi?id=55438
3670
3671         Separate out the EFL- and WinCE-specific logic from the port-independent logic in
3672         webkitdirs::buildCMakeProject(). Also, remove redundant code for generating the
3673         CMake arguments for feature defines.
3674