5470296a61a22a0a8ee358dcee000aa598fc7411
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-16  Zalan Bujtas  <zalan@apple.com>
2
3         [LFC] RenderImage's default intrinsic size is 0.
4         https://bugs.webkit.org/show_bug.cgi?id=194745
5
6         Reviewed by Antti Koivisto.
7
8         * LayoutReloaded/misc/LFC-passing-tests.txt:
9
10 2019-02-16  Zalan Bujtas  <zalan@apple.com>
11
12         [LFC][BFC] Add support for block replaced intrinsic width.
13         https://bugs.webkit.org/show_bug.cgi?id=194705
14
15         Reviewed by Simon Fraser.
16
17         * LayoutReloaded/misc/LFC-passing-tests.txt:
18
19 2019-02-16  Zalan Bujtas  <zalan@apple.com>
20
21         [LFC] Apply min/max width constraints to preferred width computation
22         https://bugs.webkit.org/show_bug.cgi?id=194739
23
24         Reviewed by Simon Fraser.
25
26         * LayoutReloaded/misc/LFC-passing-tests.txt:
27
28 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
29
30         [WTF] Add environment variable helpers
31         https://bugs.webkit.org/show_bug.cgi?id=192405
32
33         Reviewed by Michael Catanzaro.
34
35         * DumpRenderTree/mac/DumpRenderTree.mm:
36         (libraryPathForDumpRenderTree):
37         * DumpRenderTree/win/DumpRenderTree.cpp:
38         (libraryPathForDumpRenderTree):
39         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
40         (setUpIOSLayoutTestCommunication):
41         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
42         (beforeAll):
43         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
44         (main):
45         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
46         (WebKitTestBus::run):
47         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
48         (WTR::getOutputDir):
49         (WTR::initializeFontConfigSetting):
50         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
51         (WTR::InjectedBundle::platformInitialize):
52         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
53         (WTR::topLevelPath):
54         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
55         (WTR::topLevelPath):
56         (WTR::getOutputDir):
57         (WTR::activateFonts):
58         * WebKitTestRunner/TestController.cpp:
59         (WTR::TestController::libraryPathForTesting):
60         (WTR::TestController::generateContextConfiguration const):
61         (WTR::TestController::generatePageConfiguration):
62         (WTR::TestController::decideDestinationWithSuggestedFilename):
63         (WTR::TestController::platformAdjustContext):
64         * WebKitTestRunner/TestController.h:
65         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
66         (WTR::TestController::cocoaPlatformInitialize):
67         (WTR::TestController::platformAdjustContext):
68         * WebKitTestRunner/gtk/main.cpp:
69         (main):
70         * WebKitTestRunner/mac/TestControllerMac.mm:
71         (WTR::TestController::configureContentExtensionForTest):
72         * WebKitTestRunner/wpe/main.cpp:
73         (main):
74         Utilize WTF::Environment where possible.
75
76 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
77
78         [iOS] WKWebView callout bar is missing Change Writing Direction item
79         https://bugs.webkit.org/show_bug.cgi?id=190015
80         <rdar://problem/44810366>
81
82         Reviewed by Tim Horton.
83
84         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
85         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
86
87         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
88         (TestWebKitAPI::TEST):
89
90 2019-02-15  Chris Dumez  <cdumez@apple.com>
91
92         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
93         https://bugs.webkit.org/show_bug.cgi?id=194717
94         <rdar://problem/47884404>
95
96         Reviewed by Brady Eidson.
97
98         Add API test coverage.
99
100         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
101
102 2019-02-15  Youenn Fablet  <youenn@apple.com>
103
104         Make navigator.mediaDevices SecureContext
105         https://bugs.webkit.org/show_bug.cgi?id=194666
106
107         Reviewed by Eric Carlson.
108
109         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
110         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
111         (TEST_F):
112
113 2019-02-15  Brian Burg  <bburg@apple.com>
114
115         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
116         https://bugs.webkit.org/show_bug.cgi?id=194411
117         <rdar://problem/47787614>
118
119         Reviewed by Joseph Pecoraro.
120
121         Remove unnecessary soft linking macro usage.
122
123         * DumpRenderTree/mac/TestRunnerMac.mm:
124         (TestRunner::inspectorTestStubURL):
125         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
126         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
127         (WTR::TestRunner::inspectorTestStubURL):
128
129 2019-02-15  Commit Queue  <commit-queue@webkit.org>
130
131         Unreviewed, rolling out r241559 and r241566.
132         https://bugs.webkit.org/show_bug.cgi?id=194710
133
134         Causes layout test crashes under GuardMalloc (Requested by
135         ryanhaddad on #webkit).
136
137         Reverted changesets:
138
139         "[WTF] Add environment variable helpers"
140         https://bugs.webkit.org/show_bug.cgi?id=192405
141         https://trac.webkit.org/changeset/241559
142
143         "Unreviewed build fix for WinCairo Debug after r241559."
144         https://trac.webkit.org/changeset/241566
145
146 2019-02-15  Zalan Bujtas  <zalan@apple.com>
147
148         [LFC] Out-of-flow box is never a float box
149         https://bugs.webkit.org/show_bug.cgi?id=194704
150
151         Reviewed by Antti Koivisto.
152
153         * LayoutReloaded/misc/LFC-passing-tests.txt:
154
155 2019-02-10  Darin Adler  <darin@apple.com>
156
157         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
158         https://bugs.webkit.org/show_bug.cgi?id=194487
159
160         Reviewed by Daniel Bates.
161
162         * DumpRenderTree/win/DumpRenderTree.cpp:
163         (applicationId): Use makeString instead of String::format.
164         (main): Ditto.
165         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
166         (TestWebKitAPI::Util::createURLForResource): Ditto.
167         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
168         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
169
170         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
171         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
172         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
173         (WTR::createStringWithAttributes): Use appendLiteral.
174         (WTR::AccessibilityUIElement::helpText const): Ditto.
175         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
176         directly instead of using String::format.
177         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
178         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
179
180 2019-02-15  Truitt Savell  <tsavell@apple.com>
181
182         Unreviewed, rolling out r241564.
183
184         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
185
186         Reverted changeset:
187
188         "[Mac] WebInspectorUI.framework does not need to be soft-
189         linked anymore"
190         https://bugs.webkit.org/show_bug.cgi?id=194411
191         https://trac.webkit.org/changeset/241564
192
193 2019-02-15  Saam barati  <sbarati@apple.com>
194
195         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
196         https://bugs.webkit.org/show_bug.cgi?id=194036
197
198         Reviewed by Yusuke Suzuki.
199
200         * Scripts/run-jsc-stress-tests:
201
202 2019-02-14  Tim Horton  <timothy_horton@apple.com>
203
204         Fix the build.
205
206         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
207         (WTR::UIScriptController::drawSquareInEditableImage):
208         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
209         (TestWebKitAPI::drawSquareInEditableImage):
210
211 2019-02-14  Tim Horton  <timothy_horton@apple.com>
212
213         Fix the build.
214
215         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
216         (WTR::UIScriptController::drawSquareInEditableImage):
217         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
218         (TestWebKitAPI::drawSquareInEditableImage):
219
220 2019-02-14  Brian Burg  <bburg@apple.com>
221
222         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
223         https://bugs.webkit.org/show_bug.cgi?id=194411
224         <rdar://problem/47787614>
225
226         Reviewed by Joseph Pecoraro.
227
228         Remove unnecessary soft linking macro usage.
229
230         * DumpRenderTree/mac/TestRunnerMac.mm:
231         (TestRunner::inspectorTestStubURL):
232         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
233         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
234         (WTR::TestRunner::inspectorTestStubURL):
235
236 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
237
238         [ews-app] status bubble should fetch builder name info from BuilderMapping table
239         https://bugs.webkit.org/show_bug.cgi?id=194599
240
241         Reviewed by Lucas Forschler.
242
243         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
244         (StatusBubble._build_bubble):
245
246 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
247
248         [ews-app] Set Foreign Key in Django build model
249         https://bugs.webkit.org/show_bug.cgi?id=194667
250
251         Reviewed by Lucas Forschler.
252
253         * BuildSlaveSupport/ews-app/ews/models/build.py:
254         (Build):
255
256 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
257
258         [WTF] Add environment variable helpers
259         https://bugs.webkit.org/show_bug.cgi?id=192405
260
261         Reviewed by Michael Catanzaro.
262
263         * DumpRenderTree/mac/DumpRenderTree.mm:
264         (libraryPathForDumpRenderTree):
265         * DumpRenderTree/win/DumpRenderTree.cpp:
266         (libraryPathForDumpRenderTree):
267         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
268         (setUpIOSLayoutTestCommunication):
269         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
270         (TestWebKitAPI::strip):
271         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
272         (beforeAll):
273         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
274         (main):
275         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
276         (WebKitTestBus::run):
277         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
278         (WTR::getOutputDir):
279         (WTR::initializeFontConfigSetting):
280         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
281         (WTR::InjectedBundle::platformInitialize):
282         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
283         (WTR::topLevelPath):
284         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
285         (WTR::topLevelPath):
286         (WTR::getOutputDir):
287         (WTR::activateFonts):
288         * WebKitTestRunner/TestController.cpp:
289         (WTR::TestController::libraryPathForTesting):
290         (WTR::TestController::generateContextConfiguration const):
291         (WTR::TestController::generatePageConfiguration):
292         (WTR::TestController::decideDestinationWithSuggestedFilename):
293         (WTR::TestController::platformAdjustContext):
294         * WebKitTestRunner/TestController.h:
295         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
296         (WTR::TestController::cocoaPlatformInitialize):
297         (WTR::TestController::platformAdjustContext):
298         * WebKitTestRunner/gtk/main.cpp:
299         (main):
300         * WebKitTestRunner/mac/TestControllerMac.mm:
301         (WTR::TestController::configureContentExtensionForTest):
302         * WebKitTestRunner/wpe/main.cpp:
303         (main):
304         Utilize WTF::Environment where possible.
305
306 2019-02-14  Chris Dumez  <cdumez@apple.com>
307
308         [PSON] Introduce a WebContent Process cache
309         https://bugs.webkit.org/show_bug.cgi?id=194594
310         <rdar://problem/46793397>
311
312         Reviewed by Geoff Garen.
313
314         Update API tests to turn on the WebContent Process cache.
315
316         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
317
318 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
319
320         Unreviewed, build fix after r241480
321
322         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
323         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
324         (-[DragAndDropSimulator initWithWebView:]):
325
326 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
327
328         AX: ARIA Reflection was disabled in error
329         https://bugs.webkit.org/show_bug.cgi?id=194647
330         <rdar://problem/48068336>
331
332         Reviewed by Ryosuke Niwa.
333
334         Remove test override now that this feature should be enabled by default.
335
336         * WebKitTestRunner/TestController.cpp:
337         (WTR::TestController::resetPreferencesToConsistentValues):
338
339 2019-02-14  Commit Queue  <commit-queue@webkit.org>
340
341         Unreviewed, rolling out r241486.
342         https://bugs.webkit.org/show_bug.cgi?id=194655
343
344         causing API failures in builds (Requested by ShawnRoberts on
345         #webkit).
346
347         Reverted changeset:
348
349         "[Cocoa] Media elements will restart network buffering just
350         before suspending"
351         https://bugs.webkit.org/show_bug.cgi?id=193691
352         https://trac.webkit.org/changeset/241486
353
354 2019-02-14  Zalan Bujtas  <zalan@apple.com>
355
356         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
357         https://bugs.webkit.org/show_bug.cgi?id=194622
358
359         Reviewed by Antti Koivisto.
360
361         * LayoutReloaded/misc/LFC-passing-tests.txt:
362
363 2019-02-14  Zalan Bujtas  <zalan@apple.com>
364
365         [LFC] Shrink-to-fit-width should be constrained by min/max width
366         https://bugs.webkit.org/show_bug.cgi?id=194653
367
368         Reviewed by Antti Koivisto.
369
370         * LayoutReloaded/misc/LFC-passing-tests.txt:
371
372 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
373
374         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
375         https://bugs.webkit.org/show_bug.cgi?id=194641
376
377         Reviewed by Geoffrey Garen.
378
379         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
380         so that the test would fail without this fix.
381
382         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
383         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
384
385 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
386
387         [ews-app] Change log level for a log statement
388
389         Unreviewed minor fix.
390
391         * BuildSlaveSupport/ews-app/ews/models/patch.py:
392         (Patch.save_patch):
393
394 2019-02-13  Jer Noble  <jer.noble@apple.com>
395
396         [Cocoa] Media elements will restart network buffering just before suspending
397         https://bugs.webkit.org/show_bug.cgi?id=193691
398
399         Reviewed by Eric Carlson.
400
401         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
402         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
403         (TEST):
404
405 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
406
407         [ews-app] Fetch builder id to name mapping
408         https://bugs.webkit.org/show_bug.cgi?id=194355
409
410         Reviewed by Lucas Forschler.
411
412         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
413         (Buildbot.get_builder_id_to_name_mapping):
414         (Buildbot._get_display_name_from_builder_name):
415
416 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
417
418         Further restricting webarchive loads
419         https://bugs.webkit.org/show_bug.cgi?id=194567
420         <rdar://problem/47610130>
421
422         Reviewed by Youenn Fablet.
423
424         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
425         navigations on drop.
426
427         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
428         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
429         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
430         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
431         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
432         (TestWebKitAPI::TEST):
433         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
434         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
435         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
436         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
437         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
438         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
439         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
440
441 2019-02-13  John Wilander  <wilander@apple.com>
442
443         Store Ad Click Attribution requests in the network process
444         https://bugs.webkit.org/show_bug.cgi?id=194510
445         <rdar://problem/47650118>
446
447         Reviewed by Alex Christensen and Daniel Bates.
448
449         This patch adds two TestRunner functions:
450         - dumpAdClickAttribution()
451         - clearAdClickAttribution()
452
453         They call into the network process to dump and clear Ad Click
454         Attribution state, respectively.
455
456         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
457         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
458         (WTR::TestRunner::dumpAdClickAttribution):
459         (WTR::TestRunner::clearAdClickAttribution):
460         * WebKitTestRunner/InjectedBundle/TestRunner.h:
461         * WebKitTestRunner/TestController.cpp:
462         (WTR::TestController::resetStateToConsistentValues):
463         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
464         (WTR::adClickAttributionStringResultCallback):
465         (WTR::TestController::dumpAdClickAttribution):
466         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
467         (WTR::adClickAttributionVoidCallback):
468         (WTR::TestController::clearAdClickAttribution):
469         * WebKitTestRunner/TestController.h:
470         * WebKitTestRunner/TestInvocation.cpp:
471         (WTR::TestInvocation::dumpResults):
472         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
473         (WTR::TestInvocation::dumpAdClickAttribution):
474         * WebKitTestRunner/TestInvocation.h:
475
476 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
477
478         [ews-app] Generate status-bubble
479         https://bugs.webkit.org/show_bug.cgi?id=194572
480
481         Reviewed by Lucas Forschler.
482
483         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
484         (StatusBubble._build_bubble):
485         (StatusBubble._should_show_bubble_for):
486         (StatusBubble._build_bubbles_for_patch):
487
488 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
489
490         [ews-app] Add status bubble html template
491         https://bugs.webkit.org/show_bug.cgi?id=194571
492
493         Reviewed by Lucas Forschler.
494
495         * BuildSlaveSupport/ews-app/ews/templates: Added.
496         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
497
498 2019-02-12  Chris Dumez  <cdumez@apple.com>
499
500         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
501         https://bugs.webkit.org/show_bug.cgi?id=194568
502         <rdar://problem/47944490>
503
504         Reviewed by Ryosuke Niwa.
505
506         Add API test coverage.
507
508         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
509         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
510
511 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
512
513         webkitpy: Remove bug_dummy from parsed test expectations
514         https://bugs.webkit.org/show_bug.cgi?id=194562
515         <rdar://problem/47853999>
516
517         Reviewed by Lucas Forschler.
518
519         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
520         (TestExpectationParser):
521         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
522         skipped tests.
523         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
524
525 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
526
527         [ews-app] Add method to fetch patch
528         https://bugs.webkit.org/show_bug.cgi?id=194518
529
530         Reviewed by Lucas Forschler.
531
532         * BuildSlaveSupport/ews-app/ews/models/patch.py:
533         (Patch.get_patch):
534
535 2019-02-12  Zalan Bujtas  <zalan@apple.com>
536
537         [LFC] Expand tests coverage (60 new tests -> 860)
538
539         Unreviewed test gardening (run-singly, --child-processes=1).
540
541         * LayoutReloaded/misc/LFC-passing-tests.txt:
542
543 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
544
545         Allow pages to trigger programmatic paste from script on iOS
546         https://bugs.webkit.org/show_bug.cgi?id=194271
547         <rdar://problem/47808810>
548
549         Reviewed by Tim Horton.
550
551         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
552
553         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
554         (WTR::UIScriptController::platformSetDidShowMenuCallback):
555         (WTR::UIScriptController::platformSetDidHideMenuCallback):
556         (WTR::UIScriptController::rectForMenuAction const):
557
558         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
559         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
560         for when the menu is shown or hidden.
561
562         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
563         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
564         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
565         (WTR::UIScriptController::setDidShowMenuCallback):
566         (WTR::UIScriptController::didShowMenuCallback const):
567         (WTR::UIScriptController::setDidHideMenuCallback):
568         (WTR::UIScriptController::didHideMenuCallback const):
569         (WTR::UIScriptController::platformSetDidShowMenuCallback):
570         (WTR::UIScriptController::platformSetDidHideMenuCallback):
571         (WTR::UIScriptController::rectForMenuAction const):
572         * TestRunnerShared/UIScriptContext/UIScriptController.h:
573         * WebKitTestRunner/TestController.cpp:
574         (WTR::TestController::resetPreferencesToConsistentValues):
575         (WTR::updateTestOptionsFromTestHeader):
576         * WebKitTestRunner/TestOptions.h:
577
578         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
579         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
580
581         (WTR::TestOptions::hasSameInitializationOptions const):
582         * WebKitTestRunner/UIScriptControllerCocoa.mm:
583         (WTR::UIScriptController::calendarType const):
584         (WTR::UIScriptController::platformUndoManager const):
585         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
586         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
587         (-[TestRunnerWKWebView initWithFrame:configuration:]):
588         (-[TestRunnerWKWebView dealloc]):
589         (-[TestRunnerWKWebView _didShowMenu]):
590         (-[TestRunnerWKWebView _didHideMenu]):
591
592         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
593
594         * WebKitTestRunner/ios/TestControllerIOS.mm:
595         (WTR::handleMenuWillHideNotification):
596         (WTR::handleMenuDidHideNotification):
597         (WTR::TestController::platformInitialize):
598         (WTR::TestController::platformDestroy):
599         (WTR::TestController::platformResetStateToConsistentValues):
600
601         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
602         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
603
604         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
605         (WTR::forEachViewInHierarchy):
606         (WTR::findViewInHierarchyOfType):
607
608         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
609         functions that dig through a given view's hierarchy in search of a view of a given class.
610
611         (WTR::UIScriptController::selectionStartGrabberViewRect const):
612         (WTR::UIScriptController::selectionEndGrabberViewRect const):
613         (WTR::UIScriptController::selectionCaretViewRect const):
614         (WTR::UIScriptController::selectionRangeViewRects const):
615         (WTR::UIScriptController::platformSetDidShowMenuCallback):
616         (WTR::UIScriptController::platformSetDidHideMenuCallback):
617
618         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
619
620         (WTR::UIScriptController::rectForMenuAction const):
621
622         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
623         callout bar) whose label matches the given string.
624
625         (WTR::UIScriptController::platformContentView const):
626
627         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
628         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
629         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
630
631         (WTR::UIScriptController::platformUndoManager const): Deleted.
632         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
633         (WTR::UIScriptController::platformContentView const):
634         (WTR::UIScriptController::platformUndoManager const): Deleted.
635
636 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
637
638         webkitpy: No option to only show unexpected failures in results.html for iPad
639         https://bugs.webkit.org/show_bug.cgi?id=194554
640         <rdar://problem/47922442>
641
642         Rubber-stamped by Aakash Jain.
643
644         Just because a TestExpecations file does not exist for a specific platform does not mean that
645         TestExpecations are not being used, given that platforms inherit test expectations.
646
647         * Scripts/webkitpy/port/base.py:
648         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
649         * Scripts/webkitpy/port/base_unittest.py:
650         (PortTest.test_uses_test_expectations_file):
651
652 2019-02-12  Alex Christensen  <achristensen@webkit.org>
653
654         Remove setDefersLoading infrastructure from WebKit2
655         https://bugs.webkit.org/show_bug.cgi?id=194506
656
657         Reviewed by Brady Eidson.
658
659         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
660         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
661         (WTR::TestRunner::setDefersLoading): Deleted.
662         * WebKitTestRunner/InjectedBundle/TestRunner.h:
663
664 2019-02-12  Alex Christensen  <achristensen@webkit.org>
665
666         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
667         https://bugs.webkit.org/show_bug.cgi?id=194522
668         <rdar://problem/47789393>
669
670         Reviewed by Chris Dumez.
671
672         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
673         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
674         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
675         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
676
677 2019-02-12  Andy Estes  <aestes@apple.com>
678
679         [iOSMac] Enable Parental Controls Content Filtering
680         https://bugs.webkit.org/show_bug.cgi?id=194521
681         <rdar://39732376>
682
683         Reviewed by Tim Horton.
684
685         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
686
687 2019-02-12  Zalan Bujtas  <zalan@apple.com>
688
689         [LFC][IFC] Add intrinsic width support for float boxes.
690         https://bugs.webkit.org/show_bug.cgi?id=194528
691
692         Reviewed by Antti Koivisto.
693
694         Expand tests coverage (2 new tests -> 800).
695         (This is the correct test ordering --runs-singly --child-processes=1)
696
697         * LayoutReloaded/misc/LFC-passing-tests.txt:
698
699 2019-02-12  Rob Buis  <rbuis@igalia.com>
700
701         Implement serializing in MIME type parser
702         https://bugs.webkit.org/show_bug.cgi?id=193909
703
704         Reviewed by Darin Adler.
705
706         Add various tests involving upper case, non-ASCII, control/null characters,
707         various HTTP whitespace, single quotes and an unpaired surrogate.
708
709         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
710         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
711         (TestWebKitAPI::serializeIfValid):
712         (TestWebKitAPI::TEST):
713
714 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
715
716         [Cocoa] Ask platform for generic font family mappings
717         https://bugs.webkit.org/show_bug.cgi?id=187723
718         <rdar://problem/41892438>
719
720         Reviewed by Brent Fulgham.
721
722         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
723
724         * DumpRenderTree/mac/DumpRenderTree.mm:
725         (allowedFontFamilySet):
726         * WebKitTestRunner/mac/TestControllerMac.mm:
727         (WTR::allowedFontFamilySet):
728
729 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
730
731         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
732         https://bugs.webkit.org/show_bug.cgi?id=193622
733
734         Reviewed by Michael Catanzaro.
735
736         This adds support for loading content extension rule sets from the JSON files which
737         accompany the corresponding layout test, using the C API. The Cocoa specific parts
738         of WKTR for this could be removed, but that is left for a follow-up patch with
739         cleanups.
740
741         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
742         * WebKitTestRunner/TestController.cpp:
743         (WTR::testPath): Subtract one from the length when constructing the result std::string to
744         avoid having the null-terminator copied into the result.
745         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
746         part of the preparations to run a test.
747         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
748         (WTR::contentExtensionStoreCallback): Added.
749         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
750         used for content extensions test.
751         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
752         extensions and compiling the JSON rule set for tests involving content extensions.
753         (WTR::TestController::resetContentExtensions): Removes the content extension built for
754         testing and disables content extensions.
755         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
756         resetContentExtensions().
757         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
758         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
759         configureContentExtensionForTest(), and userContentController().
760
761 2019-02-11  Daniel Bates  <dabates@apple.com>
762
763         [iOS] Mouse/Touch/Pointer events are missing modifier keys
764         https://bugs.webkit.org/show_bug.cgi?id=191446
765         <rdar://problem/45929460>
766
767         Reviewed by Tim Horton.
768
769         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
770
771         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
772         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
773         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
774         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
775         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
776         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
777         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
778         * TestRunnerShared/UIScriptContext/UIScriptController.h:
779         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
780         (WTR::arrayLength):
781         (WTR::parseModifierArray):
782         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
783         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
784         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
785         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
786
787 2019-02-11  Commit Queue  <commit-queue@webkit.org>
788
789         Unreviewed, rolling out r241272 and r241276.
790         https://bugs.webkit.org/show_bug.cgi?id=194514
791
792         Broke the Apple Internal build and the fix requires human
793         intervention :( (Requested by dydz on #webkit).
794
795         Reverted changesets:
796
797         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
798         https://bugs.webkit.org/show_bug.cgi?id=191446
799         https://trac.webkit.org/changeset/241272
800
801         "Fix internal iOS build after r241272"
802         https://bugs.webkit.org/show_bug.cgi?id=191446
803         https://trac.webkit.org/changeset/241276
804
805 2019-02-11  Truitt Savell  <tsavell@apple.com>
806
807         Unreviewed, rolling out r241269.
808
809         Caused 5 layout tests crashes on Mac WK1
810
811         Reverted changeset:
812
813         "DumpRenderTree should report unknown options"
814         https://bugs.webkit.org/show_bug.cgi?id=191303
815         https://trac.webkit.org/changeset/241269
816
817 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
818
819         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
820         https://bugs.webkit.org/show_bug.cgi?id=194313
821
822         Reviewed by Tim Horton.
823
824         Add a helper to determine whether the web view is presenting modal UI.
825
826         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
827         (WTR::UIScriptController::isPresentingModally const):
828         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
829         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
830         (WTR::UIScriptController::isPresentingModally const):
831         * TestRunnerShared/UIScriptContext/UIScriptController.h:
832         * WebKitTestRunner/UIScriptControllerCocoa.mm:
833         (WTR::UIScriptController::calendarType const): Deleted.
834         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
835         (WTR::UIScriptController::isPresentingModally const):
836         (WTR::UIScriptController::calendarType const):
837         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
838         (WTR::UIScriptController::calendarType const):
839
840 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
841
842         GCHeapInspector: Show the retained sizes in more places
843         https://bugs.webkit.org/show_bug.cgi?id=194464
844
845         Reviewed by Simon Fraser.
846
847         * GCHeapInspector/gc-heap-inspector.html:
848         * GCHeapInspector/script/interface.js:
849         (HeapInspectorUtils.humanReadableSize):
850         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
851         (HeapInspectorUtils.spanForNode.span.span):
852         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
853         (HeapSnapshotInspector.prototype.buildRoots):
854
855 2019-02-11  Daniel Bates  <dabates@apple.com>
856
857         [iOS] Mouse/Touch/Pointer events are missing modifier keys
858         https://bugs.webkit.org/show_bug.cgi?id=191446
859         <rdar://problem/45929460>
860
861         Reviewed by Tim Horton.
862
863         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
864
865         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
866         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
867         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
868         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
869         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
870         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
871         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
872         * TestRunnerShared/UIScriptContext/UIScriptController.h:
873         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
874         (WTR::arrayLength):
875         (WTR::parseModifierArray):
876         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
877         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
878         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
879         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
880
881 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
882
883         DumpRenderTree should report unknown options
884         https://bugs.webkit.org/show_bug.cgi?id=191303
885
886         Reviewed by Frédéric Wang.
887
888         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
889         to report unknown options.
890         Added and assigned test options which are currently used in tests.
891
892         * DumpRenderTree/TestOptions.cpp:
893         (TestOptions::TestOptions):
894
895 2019-02-11  Truitt Savell  <tsavell@apple.com>
896
897         Unreviewed, rolling out r241229.
898
899         Revision broke internal builds for watchOS.
900
901         Reverted changeset:
902
903         "[Cocoa] Ask platform for generic font family mappings"
904         https://bugs.webkit.org/show_bug.cgi?id=187723
905         https://trac.webkit.org/changeset/241229
906
907 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
908
909         [WinCairo][MiniBrowser] Basic authentication always fails.
910         https://bugs.webkit.org/show_bug.cgi?id=194496
911
912         Reviewed by Don Olmstead.
913
914         * MiniBrowser/win/DialogHelper.h:
915         (Dialog::getText):
916
917 2019-02-11  Philippe Normand  <pnormand@igalia.com>
918
919         [GStreamer] GstMappedBuffer testsuite build fails
920         https://bugs.webkit.org/show_bug.cgi?id=194495
921
922         Reviewed by Carlos Garcia Campos.
923
924         Fix the build by explicitely adding the gstreamer1.0-audio include
925         directories to the include path.
926
927         * TestWebKitAPI/PlatformGTK.cmake:
928         * TestWebKitAPI/PlatformWPE.cmake:
929
930 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
931
932         [GTK][WPE] Add enable-javascript-markup setting
933         https://bugs.webkit.org/show_bug.cgi?id=193439
934
935         Reviewed by Michael Catanzaro.
936
937         Add test cases to check the new setting.
938
939         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
940         (testWebKitSettings):
941         (testWebKitSettingsJavaScriptMarkup):
942         (beforeAll):
943
944 2019-02-10  Darin Adler  <darin@apple.com>
945
946         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
947         https://bugs.webkit.org/show_bug.cgi?id=194485
948
949         Reviewed by Daniel Bates.
950
951         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
952
953 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
954
955         Add more tests for clampTo<>()
956         https://bugs.webkit.org/show_bug.cgi?id=194462
957
958         Reviewed by Geoffrey Garen.
959
960         Darin suggested to test the very last floating point number
961         at the boundaries when truncating to integer.
962         I added test for max/min and max-1/min-1.
963
964         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
965         (TestWebKitAPI::TEST):
966
967 2019-02-09  Darin Adler  <darin@apple.com>
968
969         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
970         https://bugs.webkit.org/show_bug.cgi?id=194021
971
972         Reviewed by Geoffrey Garen.
973
974         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
975         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
976         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
977
978 2019-02-09  Zalan Bujtas  <zalan@apple.com>
979
980         [LFC][IFC] Add intrinsic width support for basic inline containers
981         https://bugs.webkit.org/show_bug.cgi?id=194473
982
983         Reviewed by Antti Koivisto.
984
985         Expand tests coverage (11 new tests -> 798)
986
987         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
988
989 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
990
991         Fix MiniBrowser's entitlements
992         https://bugs.webkit.org/show_bug.cgi?id=192431
993
994         Reviewed by Joseph Pecoraro.
995
996         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
997         files, making it impossible to load any extension.
998
999         * MiniBrowser/MiniBrowser.entitlements:
1000
1001 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
1002
1003         [Cocoa] Ask platform for generic font family mappings
1004         https://bugs.webkit.org/show_bug.cgi?id=187723
1005         <rdar://problem/41892438>
1006
1007         Reviewed by Brent Fulgham.
1008
1009         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1010
1011         * DumpRenderTree/mac/DumpRenderTree.mm:
1012         (allowedFontFamilySet):
1013         * WebKitTestRunner/mac/TestControllerMac.mm:
1014         (WTR::allowedFontFamilySet):
1015
1016 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
1017
1018         [GTK] Implement back/forward touchpad gesture
1019         https://bugs.webkit.org/show_bug.cgi?id=193919
1020
1021         Reviewed by Michael Catanzaro.
1022
1023         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1024         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
1025
1026 2019-02-08  Alex Christensen  <achristensen@webkit.org>
1027
1028         Add SPI to use networking daemon instead of XPC service
1029         https://bugs.webkit.org/show_bug.cgi?id=194427
1030
1031         Reviewed by Geoffrey Garen
1032
1033         * MiniBrowser/MiniBrowser.entitlements:
1034
1035 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1036
1037         [ews-build] Ensure that every builder in config.json has short name
1038         https://bugs.webkit.org/show_bug.cgi?id=194461
1039
1040         Reviewed by Lucas Forschler.
1041
1042         * BuildSlaveSupport/ews-build/loadConfig.py:
1043         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
1044
1045 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1046
1047         [ews-build] Add short name to config.json
1048         https://bugs.webkit.org/show_bug.cgi?id=194456
1049
1050         Reviewed by Lucas Forschler.
1051
1052         * BuildSlaveSupport/ews-build/config.json: Added short name.
1053         * BuildSlaveSupport/ews-build/loadConfig.py:
1054         (loadBuilderConfig): Set the short name as the builder description.
1055
1056 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
1057
1058         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
1059         https://bugs.webkit.org/show_bug.cgi?id=194418
1060
1061         Reviewed by Lucas Forschler.
1062
1063         Do not include errors trying when finding crashlogs at the end of
1064         a run-webkit-tests run since we don't process those errors.
1065
1066         * Scripts/webkitpy/port/darwin.py:
1067         (DarwinPort._look_for_all_crash_logs_in_log_dir):
1068         * Scripts/webkitpy/port/ios_device.py:
1069         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
1070         * Scripts/webkitpy/port/watch_device.py:
1071         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
1072
1073 2019-02-08  Beth Dakin  <bdakin@apple.com>
1074
1075         Add afterScreenUpdates to WKSnapshotConfiguration
1076         https://bugs.webkit.org/show_bug.cgi?id=194362
1077         -and corresponding-
1078         <rdar://problem/40655528> Please add an "after screen updates" property to 
1079         WKSnapshotConfiguration (to solve blank snapshots)
1080
1081         Reviewed by Tim Horton.
1082
1083         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
1084         (TEST):
1085
1086 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
1087
1088         clampTo(): do not convert the input to double when dealing with integers
1089         https://bugs.webkit.org/show_bug.cgi?id=194263
1090         <rdar://problem/47692312>
1091
1092         Reviewed by Darin Adler.
1093
1094         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1095         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
1096         (TestWebKitAPI::testClampFloatingPointToInteger):
1097         (TestWebKitAPI::testClampSameSignIntegers):
1098         (TestWebKitAPI::testClampUnsignedToSigned):
1099         (TestWebKitAPI::testClampSignedToUnsigned):
1100
1101 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
1102
1103         webkitpy: Respect --dedicated-simulators flag
1104         https://bugs.webkit.org/show_bug.cgi?id=194416
1105         <rdar://problem/47894722>
1106
1107         Reviewed by Lucas Forschler.
1108
1109         * Scripts/webkitpy/port/device_port.py:
1110         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
1111         available devices can be safely ignored.
1112
1113 2019-02-07  Keith Rollin  <krollin@apple.com>
1114
1115         Remove extra copy of 100x100-red.tga
1116         https://bugs.webkit.org/show_bug.cgi?id=194371
1117         <rdar://problem/47873465>
1118
1119         Reviewed by Said Abou-Hallawa.
1120
1121         In order to help it pass its tests, Bug 194190 added a second copy of
1122         the file 100x100-red.tga. However, it turns out that this additional
1123         file wasn't actually needed, and that that sole previous copy was
1124         sufficient. At the same time, this second copy -- which was copied to
1125         the same location in the build output as the first copy -- now caused
1126         XCBuild to complain because there were two production rules for the
1127         same output file. Address this by removing the newly-added extra copy.
1128
1129         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1130         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
1131
1132 2019-02-07  Alex Christensen  <achristensen@webkit.org>
1133
1134         Deprecate WKBundlePageSetDefersLoading
1135         https://bugs.webkit.org/show_bug.cgi?id=191394
1136
1137         Reviewed by Dean Jackson.
1138
1139         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1140         (WTR::TestRunner::setDefersLoading):
1141
1142 2019-02-07  Zalan Bujtas  <zalan@apple.com>
1143
1144         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
1145         https://bugs.webkit.org/show_bug.cgi?id=194391
1146
1147         Reviewed by Antti Koivisto.
1148
1149         * LayoutReloaded/misc/LFC-passing-tests.txt:
1150
1151 2019-02-06  Keith Rollin  <krollin@apple.com>
1152
1153         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
1154         https://bugs.webkit.org/show_bug.cgi?id=193975
1155         <rdar://problem/47643306>
1156
1157         Reviewed by Tim Horton.
1158
1159         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
1160         the Info.plist file into the bundle. This step is not necessary as the
1161         implicit "bundle up all the build products into a framework" build
1162         phase does this already. Having the Copy Bundle Resources phase do
1163         this causes a conflict under XCBuild, which objects to two build
1164         phases producing the same file (Info.plist). Address this by removing
1165         Info.plist from the Copy Bundle Resources phase.
1166
1167         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1168
1169 2019-02-06  Keith Rollin  <krollin@apple.com>
1170
1171         Really enable the automatic checking and regenerations of .xcfilelists during builds
1172         https://bugs.webkit.org/show_bug.cgi?id=194357
1173         <rdar://problem/47861231>
1174
1175         Reviewed by Chris Dumez.
1176
1177         Bug 194124 was supposed to enable the automatic checking and
1178         regenerating of .xcfilelist files during the build. While related
1179         changes were included in that patch, the change to actually enable the
1180         operation somehow was omitted. This patch actually enables the
1181         operation. The check-xcfilelist.sh scripts now check
1182         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
1183         from the checking.
1184
1185         * DumpRenderTree/Scripts/check-xcfilelists.sh:
1186         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
1187
1188 2019-02-06  David Kilzer  <ddkilzer@apple.com>
1189
1190         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
1191         <https://webkit.org/b/194286>
1192         <rdar://problem/47815558>
1193
1194         Reviewed by Alexey Proskuryakov.
1195
1196         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1197         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
1198         WKRetainPtr<> to avoid leaking the WKDataRef.
1199
1200 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1201
1202         Unreviewed, fix a typo
1203
1204         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1205
1206 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
1207
1208         [GTK][WPE] force libpsl build to use ICU in jhbuild
1209         https://bugs.webkit.org/show_bug.cgi?id=194288
1210
1211         Reviewed by Carlos Garcia Campos.
1212
1213         * gtk/jhbuild.modules:
1214         Require ICU for libpsl build in jhbuild, like done in WPE.
1215
1216 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1217
1218         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
1219         https://bugs.webkit.org/show_bug.cgi?id=194209
1220
1221         Reviewed by Carlos Garcia Campos.
1222
1223         Enhance TestCookieManager to ensure this doesn't happen again.
1224
1225         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1226         (testCookieManagerPersistentStorage):
1227         (beforeAll):
1228
1229 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1230
1231         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
1232         https://bugs.webkit.org/show_bug.cgi?id=194324
1233
1234         Reviewed by Andy Estes.
1235
1236         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
1237         part of the name is already implicit, since this is in testing code in TestOptions.
1238
1239         * WebKitTestRunner/TestController.cpp:
1240         (WTR::TestController::generateContextConfiguration const):
1241         (WTR::updateTestOptionsFromTestHeader):
1242         * WebKitTestRunner/TestOptions.h:
1243         (WTR::TestOptions::hasSameInitializationOptions const):
1244
1245 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1246
1247         [ews-build] Allow * as platform for builders and workers
1248         https://bugs.webkit.org/show_bug.cgi?id=188533
1249
1250         Reviewed by Lucas Forschler.
1251
1252         * BuildSlaveSupport/ews-build/loadConfig.py:
1253         (checkWorkersAndBuildersForConsistency):
1254
1255 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1256
1257         [ews-build] Add few bots to config.json
1258         https://bugs.webkit.org/show_bug.cgi?id=194304
1259
1260         Reviewed by Lucas Forschler.
1261
1262         * BuildSlaveSupport/ews-build/config.json:
1263
1264 2019-02-05  Keith Rollin  <krollin@apple.com>
1265
1266         Enable the automatic checking and regenerations of .xcfilelists during builds
1267         https://bugs.webkit.org/show_bug.cgi?id=194124
1268         <rdar://problem/47721277>
1269
1270         Reviewed by Tim Horton.
1271
1272         Bug 193790 add a facility for checking -- during build time -- that
1273         any needed .xcfilelist files are up-to-date and for updating them if
1274         they are not. This facility was initially opt-in by setting
1275         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
1276         the process seemed robust. Its now time to enable this facility and
1277         make it opt-out. If there is a need to disable this facility, set and
1278         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
1279         running `make` or `build-webkit`, or before running Xcode from the
1280         command line.
1281
1282         Additionally, remove the step that generates a list of source files
1283         going into the UnifiedSources build step. It's only necessarily to
1284         specify Sources.txt and SourcesCocoa.txt as inputs.
1285
1286         * Scripts/generate-xcfilelists:
1287
1288 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1289
1290         [GTK][WPE] force libpsl build to use ICU in jhbuild
1291         https://bugs.webkit.org/show_bug.cgi?id=194288
1292
1293         Reviewed by Philippe Normand.
1294
1295         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
1296         This can cause build failures if libidn is detected but libunistring is not available.
1297
1298         Make sure that ICU is used for runtime and builtin PSL data.
1299
1300         * gtk/jhbuild.modules:
1301         * wpe/jhbuild.modules:
1302
1303 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1304
1305         [ews-app] Modified timestamp should be updated on updating data
1306         https://bugs.webkit.org/show_bug.cgi?id=194295
1307
1308         Reviewed by Lucas Forschler.
1309
1310         * BuildSlaveSupport/ews-app/ews/models/build.py:
1311         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1312         * BuildSlaveSupport/ews-app/ews/models/step.py:
1313
1314 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
1315
1316         Unreviewed, rolling out r240742.
1317
1318         Causes crashes on iOS simulator.
1319
1320         Reverted changeset:
1321
1322         "[iOS] Keyups for non-modifier keys identified as "Dead" when
1323         not focused in a content-editable element"
1324         https://bugs.webkit.org/show_bug.cgi?id=192824
1325         https://trac.webkit.org/changeset/240742
1326
1327 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
1328
1329         run-webkit-tests emits message "...running None" when running tests
1330         https://bugs.webkit.org/show_bug.cgi?id=194133
1331         <rdar://problem/47724738>
1332
1333         Reviewed by Lucas Forschler.
1334
1335         * Scripts/webkitpy/xcode/device_type.py:
1336         (DeviceType.__str__): Use both version mapping tables and use just the variant
1337         name if no version name is available.
1338         * Scripts/webkitpy/xcode/device_type_unittest.py:
1339         (DeviceTypeTest):
1340         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
1341         an associated named.
1342
1343 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1344
1345         [WPE] require python3-setuptools for meson build in jhbuild
1346         https://bugs.webkit.org/show_bug.cgi?id=194287
1347
1348         Reviewed by Philippe Normand.
1349
1350         python3-setuptools is needed to build meson in jhbuild.
1351         It is already required by the GTK port.
1352
1353         * wpe/install-dependencies:
1354
1355 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1356
1357         [ews-app] Add method to save BuilderMapping to database
1358         https://bugs.webkit.org/show_bug.cgi?id=194264
1359
1360         Reviewed by Lucas Forschler.
1361
1362         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1363         (BuilderMapping.__str__):
1364         (BuilderMapping):
1365         (BuilderMapping.save_mapping):
1366         (BuilderMapping.update_mapping):
1367         (BuilderMapping.get_existing_mapping):
1368         (BuilderMapping.is_valid_mapping):
1369
1370 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1371
1372         [ews-app] Add timestamp fields for BuilderMappings
1373         https://bugs.webkit.org/show_bug.cgi?id=194266
1374
1375         Reviewed by Lucas Forschler.
1376
1377         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1378         (BuilderMapping):
1379
1380 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
1381
1382         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
1383         https://bugs.webkit.org/show_bug.cgi?id=174816
1384
1385         Reviewed by Michael Catanzaro.
1386
1387         Add tests for webkit_uri_for_display().
1388
1389         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
1390         (testURIForDisplayUnaffected):
1391         (testURIForDisplayAffected):
1392         (beforeAll):
1393         (afterAll):
1394         * TestWebKitAPI/glib/CMakeLists.txt:
1395
1396 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
1397
1398         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
1399         https://bugs.webkit.org/show_bug.cgi?id=194158
1400         <rdar://problem/47737268>
1401
1402         Rubber-stamped by Aakash Jain.
1403
1404         * Scripts/webkitpy/port/device_port.py:
1405         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
1406
1407 2019-02-04  Said Abou-Hallawa  <said@apple.com>
1408
1409         [CG] Enable setAdditionalSupportedImageTypes for WK1
1410         https://bugs.webkit.org/show_bug.cgi?id=194190
1411
1412         Reviewed by Tim Horton.
1413
1414         Add a test similar to the one under WebKit Cocoa but make it create a
1415         WebView instead of a WKWebView.
1416
1417         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1418         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
1419         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
1420         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
1421         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
1422         (TestWebKitAPI::runTest):
1423         (TestWebKitAPI::TEST):
1424
1425 2019-02-04  Zalan Bujtas  <zalan@apple.com>
1426
1427         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
1428         https://bugs.webkit.org/show_bug.cgi?id=194168
1429
1430         Reviewed by Simon Fraser.
1431
1432         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
1433
1434         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1435         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
1436         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
1437         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
1438         (TEST):
1439         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
1440         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
1441
1442 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
1443
1444         REGRESSION (r237269): webkit-patch what-broke is broken 
1445         https://bugs.webkit.org/show_bug.cgi?id=193025
1446
1447         Reviewed by Aakash Jain.
1448
1449         * Scripts/webkitpy/common/host.py:
1450         (Host.buildbot):
1451         (Host.bugzilla): Renamed to 'buildbot'.
1452
1453 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1454
1455         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
1456         https://bugs.webkit.org/show_bug.cgi?id=194207
1457
1458         Reviewed by Tim Horton.
1459
1460         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
1461         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
1462         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
1463         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
1464         start and delete forwards to remove the original attachment.
1465
1466         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1467         (TestWebKitAPI::TEST):
1468
1469 2019-02-04  Youenn Fablet  <youenn@apple.com>
1470
1471         Capture state should be managed consistently when doing process swapping
1472         https://bugs.webkit.org/show_bug.cgi?id=194122
1473         <rdar://problem/47609293>
1474
1475         Reviewed by Eric Carlson.
1476
1477         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1478         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1479         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1480         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
1481         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1482         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1483         (WTR::TestRunner::isDoingMediaCapture const):
1484         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1485         * WebKitTestRunner/TestController.cpp:
1486         (WTR::TestController::isDoingMediaCapture const):
1487         * WebKitTestRunner/TestController.h:
1488         * WebKitTestRunner/TestInvocation.cpp:
1489         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1490         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1491         (WTR::TestController::isDoingMediaCapture const):
1492
1493 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1494
1495         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
1496         https://bugs.webkit.org/show_bug.cgi?id=194142
1497
1498         Reviewed by Ross Kirsling.
1499
1500         There three 'separator' variables in TestController.cpp. Renamed
1501         it 'pathSeparator', and unified them.
1502
1503         * WebKitTestRunner/TestController.cpp:
1504         (WTR::TestController::generateContextConfiguration const):
1505         (WTR::createTestURL):
1506         (WTR::TestController::platformAdjustContext):
1507
1508 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
1509
1510         Make setNeedsLayout on the root more explicitly about triggering its side-effects
1511         https://bugs.webkit.org/show_bug.cgi?id=194198
1512
1513         Reviewed by Antti Koivisto.
1514
1515         No need to set the banner heights on navigation now, since Page stores them.
1516
1517         * MiniBrowser/mac/WK2BrowserWindowController.m:
1518         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
1519
1520 2019-02-03  John Wilander  <wilander@apple.com>
1521
1522         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
1523         https://bugs.webkit.org/show_bug.cgi?id=194104
1524         <rdar://problem/47649991>
1525
1526         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
1527
1528         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1529         (TestWebKitAPI::TEST):
1530             Changed numeric types from unsigned short to uint32_t.
1531
1532 2019-02-02  David Kilzer  <ddkilzer@apple.com>
1533
1534         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
1535         <https://webkit.org/b/194178>
1536         <rdar://problem/47753473>
1537
1538         Reviewed by Alexey Proskuryakov.
1539
1540         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1541         (WTR::uninstallFakeHelvetica): Pass nullptr into
1542         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
1543
1544 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1545
1546         [LFC] Initialize ICB's style with fixed width/height.
1547         https://bugs.webkit.org/show_bug.cgi?id=194188
1548
1549         Reviewed by Antti Koivisto.
1550
1551         * LayoutReloaded/misc/LFC-passing-tests.txt:
1552
1553 2019-02-02  Zalan Bujtas  <zalan@apple.com>
1554
1555         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
1556         https://bugs.webkit.org/show_bug.cgi?id=194185
1557
1558         Reviewed by Antti Koivisto.
1559
1560         * LayoutReloaded/misc/LFC-passing-tests.txt:
1561
1562 2018-12-16  Darin Adler  <darin@apple.com>
1563
1564         Convert additional String::format clients to alternative approaches
1565         https://bugs.webkit.org/show_bug.cgi?id=192746
1566
1567         Reviewed by Alexey Proskuryakov.
1568
1569         * WebKitTestRunner/TestController.cpp:
1570         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
1571         as an intermediate in code that ultimately constructs a WTF::String.
1572         (WTR::userMediaOriginHash): Use makeString.
1573         (WTR::TestController::didNavigateWithNavigationData): More of the same.
1574         (WTR::TestController::didPerformClientRedirect): Ditto.
1575         (WTR::TestController::didPerformServerRedirect): Ditto.
1576         (WTR::TestController::didUpdateHistoryTitle): Ditto.
1577
1578 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1579
1580         [ews-build] Add unit test to verify builder keys
1581         https://bugs.webkit.org/show_bug.cgi?id=194152
1582
1583         Reviewed by Lucas Forschler.
1584
1585         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1586         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
1587
1588 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1589
1590         [LFC] Expand tests coverage (12 new tests -> 787)
1591
1592         Unreviewed test gardening.
1593
1594         * LayoutReloaded/misc/LFC-passing-tests.txt:
1595
1596 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1597
1598         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
1599         https://bugs.webkit.org/show_bug.cgi?id=194163
1600
1601         Reviewed by Simon Fraser.
1602
1603         775
1604
1605         * LayoutReloaded/misc/LFC-passing-tests.txt:
1606
1607 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1608
1609         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
1610         https://bugs.webkit.org/show_bug.cgi?id=194140
1611         <rdar://problem/47728098>
1612
1613         Reviewed by Tim Horton.
1614
1615         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1616         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1617         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
1618
1619         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
1620         test to induce an IPC deadlock when presenting a modal alert during touch start.
1621
1622         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1623         * WebKitTestRunner/TestController.cpp:
1624         (WTR::runJavaScriptAlert):
1625
1626         Add a client callback function for running JavaScript alerts.
1627
1628         (WTR::TestController::createOtherPage):
1629         (WTR::TestController::generateContextConfiguration const):
1630
1631         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
1632         the fix in this patch.
1633
1634         (WTR::TestController::createWebViewWithOptions):
1635
1636         Plumb TestOptions to generateContextConfiguration.
1637
1638         (WTR::TestController::resetPreferencesToConsistentValues):
1639         (WTR::TestController::resetStateToConsistentValues):
1640         (WTR::updateTestOptionsFromTestHeader):
1641         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
1642         (WTR::TestController::handleJavaScriptAlert):
1643         * WebKitTestRunner/TestController.h:
1644         * WebKitTestRunner/TestInvocation.cpp:
1645         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1646         * WebKitTestRunner/TestOptions.h:
1647         (WTR::TestOptions::hasSameInitializationOptions const):
1648
1649 2019-02-01  Chris Dumez  <cdumez@apple.com>
1650
1651         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
1652         https://bugs.webkit.org/show_bug.cgi?id=193740
1653         <rdar://problem/47527267>
1654
1655         Reviewed by Alex Christensen.
1656
1657         Add API test coverage.
1658
1659         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1660
1661 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
1662
1663         [ews-app] Add display name field to BuilderMapping model
1664         https://bugs.webkit.org/show_bug.cgi?id=194153
1665
1666         Reviewed by Lucas Forschler.
1667
1668         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1669         (BuilderMapping):
1670
1671 2019-02-01  Youenn Fablet  <youenn@apple.com>
1672
1673         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
1674         https://bugs.webkit.org/show_bug.cgi?id=194155
1675
1676         Reviewed by Eric Carlson.
1677
1678         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1679         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
1680         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
1681
1682 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1683
1684         [LFC] Adjust replaced element's intrinsic ratio
1685         https://bugs.webkit.org/show_bug.cgi?id=194154
1686
1687         Reviewed by Antti Koivisto.
1688
1689         761
1690
1691         * LayoutReloaded/misc/LFC-passing-tests.txt:
1692
1693 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1694
1695         [WPE] Show test results in minibrowser
1696         https://bugs.webkit.org/show_bug.cgi?id=194150
1697
1698         Reviewed by Žan Doberšek.
1699
1700         * Scripts/webkitpy/port/wpe.py:
1701         (WPEPort.show_results_html_file):
1702
1703 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1704
1705         [WPE] MiniBrowser: add ky bindings for back/forward navigation
1706         https://bugs.webkit.org/show_bug.cgi?id=194151
1707
1708         Reviewed by Žan Doberšek.
1709
1710         ALT + <- go back
1711         ALT + -> go forward
1712
1713         * MiniBrowser/wpe/main.cpp:
1714         (main):
1715
1716 2019-02-01  Zalan Bujtas  <zalan@apple.com>
1717
1718         [LFC] Set intrinsic size on Layout::Replaced
1719         https://bugs.webkit.org/show_bug.cgi?id=194139
1720
1721         Reviewed by Antti Koivisto.
1722
1723         744
1724
1725         * LayoutReloaded/misc/LFC-passing-tests.txt:
1726
1727 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1728
1729         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
1730         https://bugs.webkit.org/show_bug.cgi?id=194146
1731
1732         Reviewed by Xabier Rodriguez-Calvar.
1733
1734         It allows to open relative paths.
1735
1736         * MiniBrowser/wpe/main.cpp:
1737         (main):
1738
1739 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
1740
1741         Update flakiness dashboard configuration after recent queue changes
1742         https://bugs.webkit.org/show_bug.cgi?id=194127
1743
1744         Rubber-stamped by Aakash Jain.
1745
1746         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
1747
1748         * TestResultServer/static-dashboards/builders.jsonp:
1749
1750 2019-01-31  Youenn Fablet  <youenn@apple.com>
1751
1752         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
1753         https://bugs.webkit.org/show_bug.cgi?id=194106
1754         <rdar://problem/47676333>
1755
1756         Reviewed by Ryosuke Niwa.
1757
1758         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1759         (TestWebKitAPI::didFinishNavigation):
1760         (TestWebKitAPI::TEST):
1761         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
1762
1763 2019-01-31  Chris Dumez  <cdumez@apple.com>
1764
1765         Page zoom level is lost after a process swap or a crash
1766         https://bugs.webkit.org/show_bug.cgi?id=194105
1767         <rdar://problem/47610781>
1768
1769         Reviewed by Alex Christensen.
1770
1771         Add API test coverage.
1772
1773         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1774         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
1775
1776 2019-01-31  Alex Christensen  <achristensen@webkit.org>
1777
1778         Revert r238819 which is unneeded and caused a performance regression.
1779         https://bugs.webkit.org/show_bug.cgi?id=192272
1780         <rdar://problem/46664625>
1781
1782         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
1783         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
1784         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
1785
1786 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
1787
1788         Formalize WebKitAdditions mechanism of LoadOptimizer
1789         https://bugs.webkit.org/show_bug.cgi?id=193886
1790         <rdar://problem/47696809>
1791
1792         Reviewed by Brent Fulgham.
1793
1794         * MiniBrowser/MiniBrowser.entitlements:
1795         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
1796
1797 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1798
1799         [LFC] Margin before/after/start/end initial value is 0 and not auto.
1800         https://bugs.webkit.org/show_bug.cgi?id=194090
1801
1802         Reviewed by Antti Koivisto.
1803
1804         * LayoutReloaded/misc/LFC-passing-tests.txt:
1805
1806 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1807
1808         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
1809         https://bugs.webkit.org/show_bug.cgi?id=194074
1810
1811         Reviewed by Antti Koivisto.
1812
1813         * LayoutReloaded/misc/LFC-passing-tests.txt:
1814
1815 2019-01-31  Zalan Bujtas  <zalan@apple.com>
1816
1817         [LFC][BFC] Add support for block level replaced box.
1818         https://bugs.webkit.org/show_bug.cgi?id=194071
1819
1820         Reviewed by Antti Koivisto.
1821
1822         * LayoutReloaded/misc/LFC-passing-tests.txt:
1823
1824 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1825
1826         Fix WebKitTestRunner's testPath with Windows full paths
1827         https://bugs.webkit.org/show_bug.cgi?id=194012
1828
1829         Reviewed by Alex Christensen.
1830
1831         updateTestOptionsFromTestHeader failed to open test files because
1832         testPath returned wrong file paths. It returned a path "/C:/..."
1833         if a URL "file:///C:/..." was given.
1834
1835         * WebKitTestRunner/TestController.cpp:
1836         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
1837
1838 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1839
1840         [WPE] Bump font related dependencies to match the GTK+ port
1841         https://bugs.webkit.org/show_bug.cgi?id=194017
1842
1843         Reviewed by Žan Doberšek.
1844
1845         * wpe/jhbuild.modules:
1846         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
1847         * wpe/patches/icudata-stdlibs.patch: Added.
1848
1849 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1850
1851         Enable swipe tests on iOS
1852         https://bugs.webkit.org/show_bug.cgi?id=194076
1853
1854         Reviewed by Geoffrey Garen.
1855
1856         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
1857         it causes a debug assertion failure in runUIScript.
1858
1859         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1860         (WTR::UIScriptController::beginBackSwipe):
1861         (WTR::UIScriptController::completeBackSwipe):
1862
1863 2019-01-30  Keith Rollin  <krollin@apple.com>
1864
1865         Use correct printf format specifier
1866         https://bugs.webkit.org/show_bug.cgi?id=194062
1867         <rdar://problem/47686167>
1868
1869         Reviewed by Alexey Proskuryakov.
1870
1871         LayoutTestSpellChecker.mm is trying to format a variable of type
1872         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
1873         actually an unsigned long long. Fix this by formatting with %llu.
1874
1875         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
1876         (-[LayoutTestTextCheckingResult description]):
1877
1878 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
1879
1880         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
1881         https://bugs.webkit.org/show_bug.cgi?id=193979
1882
1883         Reviewed by Wenson Hsieh.
1884
1885         Fix the test for iOS. Make the test work with iOS UA string.
1886
1887         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1888
1889 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
1890
1891         Replace High Sierra LLINT CLoop bot due to hardware failure
1892         https://bugs.webkit.org/show_bug.cgi?id=194066
1893
1894         Reviewed by Aakash Jain.
1895
1896         * BuildSlaveSupport/build.webkit.org-config/config.json:
1897
1898 2019-01-30  Keith Rollin  <krollin@apple.com>
1899
1900         [NSDragItem init] is unavailable
1901         https://bugs.webkit.org/show_bug.cgi?id=194059
1902         <rdar://problem/47685715>
1903
1904         Reviewed by Wenson Hsieh.
1905
1906         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
1907         DumpRenderTree and TestWebKitAPI, which both try to create an
1908         NSDragItem in a manner that invokes this method. Address this by using
1909         -initWithPasteboardWriter instead.
1910
1911         Note that the parameter passed to initWithPasteboardWriter is likely
1912         incorrect. In both cases, the object passed does not conform to
1913         NSPasteboardWriting. However, with this fix, we're no worse off than
1914         before, and can now perform builds with newer compilers and SDKs until
1915         a real fix can be crafted. That work is tracked in
1916         https://bugs.webkit.org/show_bug.cgi?id=194060
1917
1918         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1919         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1920         * TestWebKitAPI/mac/TestDraggingInfo.mm:
1921         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1922
1923 2019-01-30  Daniel Bates  <dabates@apple.com>
1924
1925         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1926         https://bugs.webkit.org/show_bug.cgi?id=192824
1927         <rdar://problem/47100332>
1928
1929         Reviewed by Wenson Hsieh.
1930
1931         Fix a bug where the wrong usage code was used for F13 thru F24.
1932
1933         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1934         (keyCodeForDOMFunctionKey):
1935
1936 2019-01-30  Chris Dumez  <cdumez@apple.com>
1937
1938         Regression(PSON) Load hang can occur on history navigation
1939         https://bugs.webkit.org/show_bug.cgi?id=194030
1940         <rdar://problem/47656939>
1941
1942         Reviewed by Antti Koivisto.
1943
1944         Add API test coverage.
1945
1946         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1947
1948 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1949
1950         [LFC] Expand tests coverage.
1951
1952         Unreviewed test gardening.
1953
1954         * LayoutReloaded/misc/LFC-passing-tests.txt:
1955
1956 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
1957
1958         [Flatpak] Add openjpeg support
1959         https://bugs.webkit.org/show_bug.cgi?id=194019
1960
1961         Reviewed by Michael Catanzaro.
1962
1963         * flatpak/org.webkit.CommonModules.yaml:
1964
1965 2019-01-30  Commit Queue  <commit-queue@webkit.org>
1966
1967         Unreviewed, rolling out r240708.
1968         https://bugs.webkit.org/show_bug.cgi?id=194022
1969
1970         It broke WPE build (Requested by KaL on #webkit).
1971
1972         Reverted changeset:
1973
1974         "[WPE] Bump font related dependencies to match the GTK+ port"
1975         https://bugs.webkit.org/show_bug.cgi?id=194017
1976         https://trac.webkit.org/changeset/240708
1977
1978 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1979
1980         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
1981         https://bugs.webkit.org/show_bug.cgi?id=194001
1982
1983         Reviewed by Antti Koivisto.
1984
1985         * LayoutReloaded/misc/LFC-passing-tests.txt:
1986
1987 2019-01-30  Zalan Bujtas  <zalan@apple.com>
1988
1989         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
1990         https://bugs.webkit.org/show_bug.cgi?id=194020
1991
1992         Reviewed by Antti Koivisto.
1993
1994         * LayoutReloaded/misc/LFC-passing-tests.txt:
1995
1996 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
1997
1998         AX: Support color well on iOS
1999         https://bugs.webkit.org/show_bug.cgi?id=194010
2000
2001         Reviewed by Joanmarie Diggs.
2002
2003         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2004         (WTR::AccessibilityUIElement::stringAttributeValue):
2005
2006 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2007
2008         [WPE] Bump font related dependencies to match the GTK+ port
2009         https://bugs.webkit.org/show_bug.cgi?id=194017
2010
2011         Reviewed by Žan Doberšek.
2012
2013         * wpe/jhbuild.modules:
2014         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2015         * wpe/patches/icudata-stdlibs.patch: Added.
2016
2017 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
2018
2019         [Mac] Update window scale API usage
2020         https://bugs.webkit.org/show_bug.cgi?id=193991
2021         rdar://problem/47614795
2022
2023         Reviewed by Tim Horton.
2024
2025         * DumpRenderTree/mac/DumpRenderTree.mm:
2026         (changeWindowScaleIfNeeded):
2027         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2028         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2029         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2030
2031 2019-01-29  Chris Dumez  <cdumez@apple.com>
2032
2033         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
2034         https://bugs.webkit.org/show_bug.cgi?id=193977
2035         <rdar://problem/47643716>
2036
2037         Reviewed by Geoff Garen.
2038
2039         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
2040         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
2041         to the previous provisional committing *before* we make the last load. 
2042
2043         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2044
2045 2019-01-29  Youenn Fablet  <youenn@apple.com>
2046
2047         Adopt new SPI to evaluate server certificate trust
2048         https://bugs.webkit.org/show_bug.cgi?id=193355
2049
2050         Reviewed by Alex Christensen.
2051
2052         Add infrastructure to handle HTTPS server trust evaluation testing.
2053
2054         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2055         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2056         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
2057         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
2058         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
2059         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2060         * WebKitTestRunner/TestController.cpp:
2061         (WTR::TestController::resetPreferencesToConsistentValues):
2062         (WTR::TestController::didReceiveAuthenticationChallenge):
2063         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2064         * WebKitTestRunner/TestController.h:
2065         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
2066         * WebKitTestRunner/TestInvocation.cpp:
2067         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2068         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2069         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2070
2071 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2072
2073         [ews-build] Add build step to print bot Configuration
2074         https://bugs.webkit.org/show_bug.cgi?id=193887
2075
2076         Reviewed by Lucas Forschler.
2077
2078         * BuildSlaveSupport/ews-build/steps.py:
2079         (PrintConfiguration): Build step to print configuration.
2080         * BuildSlaveSupport/ews-build/factories.py:
2081
2082 2019-01-29  Chris Dumez  <cdumez@apple.com>
2083
2084         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
2085         https://bugs.webkit.org/show_bug.cgi?id=193967
2086         <rdar://problem/47635348>
2087
2088         Reviewed by Alex Christensen.
2089
2090         Add API test coverage.
2091
2092         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2093         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
2094
2095 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2096
2097         [ews-app] Handle incoming results data
2098         https://bugs.webkit.org/show_bug.cgi?id=193973
2099
2100         Reviewed by Lucas Forschler.
2101
2102         * BuildSlaveSupport/ews-app/ews/views/results.py:
2103
2104 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2105
2106         [ews-app] Make the results url generic
2107         https://bugs.webkit.org/show_bug.cgi?id=193928
2108
2109         Reviewed by Lucas Forschler.
2110
2111         * BuildSlaveSupport/ews-app/ews/urls.py:
2112
2113 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2114
2115         [ews-build] Configure buildbot to send events to ews-app
2116         https://bugs.webkit.org/show_bug.cgi?id=193968
2117
2118         Reviewed by Lucas Forschler.
2119
2120         * BuildSlaveSupport/ews-build/events.py: Added.
2121         * BuildSlaveSupport/ews-build/master.cfg:
2122
2123 2019-01-29  Keith Rollin  <krollin@apple.com>
2124
2125         Add .xcfilelists to Run Script build phases
2126         https://bugs.webkit.org/show_bug.cgi?id=193792
2127         <rdar://problem/47201785>
2128
2129         Reviewed by Alex Christensen.
2130
2131         As part of supporting XCBuild, update the necessary Run Script build
2132         phases in their Xcode projects to refer to their associated
2133         .xcfilelist files.
2134
2135         Note that the addition of these files bumps the Xcode project version
2136         number to something that's Xcode 10 compatible. This change means that
2137         older versions of the Xcode IDE can't read these projects. Nor can it
2138         fully load workspaces that refer to these projects (the updated
2139         projects are shown as non-expandable placeholders). `xcodebuild` can
2140         still build these projects; it's just that the IDE can't open them.
2141
2142         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2143         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2144
2145 2019-01-29  John Wilander  <wilander@apple.com>
2146
2147         Add data abstraction and validation for Ad Click Attribution
2148         https://bugs.webkit.org/show_bug.cgi?id=193916
2149         <rdar://problem/47603481>
2150
2151         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
2152
2153         Ad click attribution has two steps. First, the storage of an ad
2154         campaign ID for a click that takes the user to a destination
2155         site. Second, a conversion on the destination site that can be
2156         attributed to the ad click.
2157
2158         This patch adds a class that represents a request for ad click
2159         attribution. Validation makes sure that the bits of entropy
2160         reported through this mechanism is limited.
2161
2162         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2163         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
2164         (TestWebKitAPI::TEST):
2165
2166 2019-01-29  Chris Dumez  <cdumez@apple.com>
2167
2168         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
2169         https://bugs.webkit.org/show_bug.cgi?id=193932
2170         <rdar://problem/47598947>
2171
2172         Reviewed by Brady Eidson.
2173
2174         Add API test coverage.
2175
2176         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2177
2178 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2179
2180         Adding new passing LFC tests.
2181
2182         Unreviewed test gardening.
2183
2184         * LayoutReloaded/misc/LFC-passing-tests.txt:
2185
2186 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2187
2188         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
2189         https://bugs.webkit.org/show_bug.cgi?id=193964
2190
2191         Reviewed by Antti Koivisto.
2192
2193         * LayoutReloaded/misc/LFC-passing-tests.txt:
2194
2195 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2196
2197         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
2198         https://bugs.webkit.org/show_bug.cgi?id=193954
2199
2200         Reviewed by Antti Koivisto.
2201
2202         * LayoutReloaded/misc/LFC-passing-tests.txt:
2203
2204 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2205
2206         WebDriver: add support for running subtests
2207         https://bugs.webkit.org/show_bug.cgi?id=193904
2208
2209         Reviewed by Michael Catanzaro.
2210
2211         pytest already supports it by passing test.py::subtest, so we can do the same.
2212
2213         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
2214         (get_item_name): Made this global.
2215         (CollectRecorder.__init__): Receive the parameter to ignore.
2216         (CollectRecorder.pytest_collectreport): Collect also the subtests.
2217         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
2218         (collect): Add parameter to ignore.
2219         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
2220         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
2221         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
2222         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
2223         (WebDriverTestRunnerSelenium.run): Ditto.
2224         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
2225         (WebDriverTestRunnerW3C.collect_tests): Ditto.
2226         (WebDriverTestRunnerW3C.run): Ditto.
2227
2228 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
2229
2230         User agent string override for navigator.userAgent should be site specific quirks
2231         https://bugs.webkit.org/show_bug.cgi?id=193950
2232
2233         Reviewed by Brent Fulgham.
2234
2235         Updated per the _WKWebsitePolicies rename.
2236
2237         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2238         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2239
2240 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
2241
2242         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
2243         https://bugs.webkit.org/show_bug.cgi?id=193941
2244
2245         Reviewed by Alex Christensen.
2246
2247         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
2248         * TestWebKitAPI/Tests/WTF/Condition.cpp:
2249         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2250         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2251         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2252         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2253         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
2254         * TestWebKitAPI/Tests/WTF/Time.cpp:
2255         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
2256         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
2257         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2258         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2259
2260 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
2261
2262         Unreviewed, reorder my emails to fix autocomplete in bugzilla
2263
2264         * Scripts/webkitpy/common/config/contributors.json:
2265
2266 2019-01-28  Andy Estes  <aestes@apple.com>
2267
2268         [watchOS] Enable Parental Controls content filtering
2269         https://bugs.webkit.org/show_bug.cgi?id=193939
2270         <rdar://problem/46641912>
2271
2272         Reviewed by Ryosuke Niwa.
2273
2274         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2275
2276 2019-01-28  David Kilzer  <ddkilzer@apple.com>
2277
2278         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
2279         <https://webkit.org/b/193884>
2280
2281         Reviewed by Jiewen Tan.
2282
2283         * Scripts/webkitpy/style/checkers/cpp.py:
2284         (check_language): Add LocalAuthentication to
2285         `frameworks_with_soft_links`.
2286
2287 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
2288
2289         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
2290         https://bugs.webkit.org/show_bug.cgi?id=193891
2291
2292         Reviewed by Ross Kirsling.
2293
2294         There were three problems in window sizes of WebView and the host window.
2295         1. The sizes of pixel image output were incorrect.
2296         2. The host window is going to appear after window.resize was invoked.
2297         3. window.resize resized only the host window, not WebView.
2298
2299         This change solves them with a following approach.
2300         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
2301         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
2302            as well as DumpRenderTree in order to match the client area and the window area.
2303         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
2304         d. PlatformWebView::setWindowFrame changes both window sizes.
2305         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
2306
2307         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2308         (WTR::PlatformWebView::PlatformWebView): Create the host window
2309         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
2310         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
2311         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
2312
2313 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2314
2315         [ews-app] Add method to save Step data to database
2316         https://bugs.webkit.org/show_bug.cgi?id=193890
2317
2318         Reviewed by Lucas Forschler.
2319
2320         * BuildSlaveSupport/ews-app/ews/models/step.py:
2321         (Step.save_step): Method to save step data.
2322         (Step.update_step): Method to update step data.
2323         (Step.get_existing_step): Method to fetch existing step from database.
2324         (Step.is_valid_result): Method to validate valid step result.
2325
2326 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2327
2328         [ews-app] Add method to save Build data to database
2329         https://bugs.webkit.org/show_bug.cgi?id=193735
2330
2331         Reviewed by Lucas Forschler.
2332
2333         * BuildSlaveSupport/ews-app/ews/models/build.py:
2334         (Build.save_build): Method to save build information to database.
2335         (Build.get_existing_build): Method to fetch existing build from database.
2336         (Build.is_valid_result): Method to validate build result.
2337         * BuildSlaveSupport/ews-app/ews/common/util.py:
2338         (is_valid_int_id): Method to validate valid id.
2339
2340 2019-01-28  Chris Dumez  <cdumez@apple.com>
2341
2342         Regression(PSON) Crash under WebPageProxy::didStartProgress()
2343         https://bugs.webkit.org/show_bug.cgi?id=193915
2344         <rdar://problem/47560907>
2345
2346         Reviewed by Alex Christensen.
2347
2348         Add API test coverage.
2349
2350         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2351
2352 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2353
2354         [ews-app] Rename id variables
2355         https://bugs.webkit.org/show_bug.cgi?id=193883
2356
2357         Reviewed by Lucas Forschler.
2358
2359         * BuildSlaveSupport/ews-app/ews/models/build.py:
2360         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2361         * BuildSlaveSupport/ews-app/ews/models/step.py:
2362         * BuildSlaveSupport/ews-app/ews/urls.py:
2363         * BuildSlaveSupport/ews-app/ews/views/patch.py:
2364         * BuildSlaveSupport/ews-app/ews/views/results.py:
2365         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2366
2367 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2368
2369         [ews-app] Allow certain fields to be empty
2370         https://bugs.webkit.org/show_bug.cgi?id=193892
2371
2372         Reviewed by Lucas Forschler.
2373
2374         * BuildSlaveSupport/ews-app/ews/models/build.py:
2375         * BuildSlaveSupport/ews-app/ews/models/step.py:
2376
2377 2019-01-28  Rob Buis  <rbuis@igalia.com>
2378
2379         Update MIME type parser
2380         https://bugs.webkit.org/show_bug.cgi?id=180526
2381
2382         Reviewed by Frédéric Wang.
2383
2384         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2385         (TestWebKitAPI::TEST):
2386
2387 2019-01-28  Zalan Bujtas  <zalan@apple.com>
2388
2389         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
2390         https://bugs.webkit.org/show_bug.cgi?id=193896
2391
2392         Reviewed by Antti Koivisto.
2393
2394         * LayoutReloaded/misc/LFC-passing-tests.txt:
2395
2396 2018-12-15  Darin Adler  <darin@apple.com>
2397
2398         Replace many uses of String::format with more type-safe alternatives
2399         https://bugs.webkit.org/show_bug.cgi?id=192742
2400
2401         Reviewed by Mark Lam.
2402
2403         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2404         (WTR::cacheTestRunnerCallback): Use makeString.
2405         * WebKitTestRunner/TestController.cpp:
2406         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
2407         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
2408
2409 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
2410
2411         Use a load optimizer for some sites
2412         https://bugs.webkit.org/show_bug.cgi?id=193881
2413         <rdar://problem/46325455>
2414
2415         Reviewed by Brent Fulgham.
2416
2417         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2418         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
2419
2420 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
2421
2422         AX: Introduce a static accessibility tree
2423         https://bugs.webkit.org/show_bug.cgi?id=193348
2424         <rdar://problem/47203295>
2425
2426         Reviewed by Ryosuke Niwa.
2427
2428         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2429
2430 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2431
2432         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
2433         https://bugs.webkit.org/show_bug.cgi?id=193867
2434
2435         Reviewed by Antti Koivisto.
2436
2437         * LayoutReloaded/misc/LFC-passing-tests.txt:
2438
2439 2019-01-26  Zalan Bujtas  <zalan@apple.com>
2440
2441         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
2442         https://bugs.webkit.org/show_bug.cgi?id=193865
2443
2444         Reviewed by Antti Koivisto.
2445
2446         * LayoutReloaded/misc/LFC-passing-tests.txt:
2447
2448 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2449
2450         Need a mechanism to override navigator.userAgent
2451         https://bugs.webkit.org/show_bug.cgi?id=193762
2452         <rdar://problem/47504939>
2453
2454         Reviewed by Brent Fulgham.
2455
2456         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
2457
2458         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2459         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2460         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
2461
2462 2019-01-25  Dean Jackson  <dino@apple.com>
2463
2464         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
2465         https://bugs.webkit.org/show_bug.cgi?id=193831
2466         <rdar://problem/47399263>
2467
2468         Reviewed by Chris Dumez.
2469
2470         Two new tests that exercise cross-origin and same-origin System
2471         Previews.
2472
2473         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2474
2475 2019-01-25  Keith Rollin  <krollin@apple.com>
2476
2477         Update Xcode projects with "Check .xcfilelists" build phase
2478         https://bugs.webkit.org/show_bug.cgi?id=193790
2479         <rdar://problem/47201374>
2480
2481         Reviewed by Alex Christensen.
2482
2483         Support for XCBuild includes specifying inputs and outputs to various
2484         Run Script build phases. These inputs and outputs are specified as
2485         .xcfilelist files. Once created, these .xcfilelist files need to be
2486         kept up-to-date. In order to check that they are up-to-date or not,
2487         add an Xcode build step that invokes an external script that performs
2488         the checking. If the .xcfilelists are found to be out-of-date, update
2489         them, halt the build, and instruct the developer to restart the build
2490         with up-to-date files.
2491
2492         At this time, the checking and regenerating is performed only if the
2493         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
2494         who want to use this facility can set this variable and test out the
2495         checking/regenerating. Once it seems like there are no egregious
2496         issues that upset a developer's workflow, we'll unconditionally enable
2497         this facility.
2498
2499         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2500         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
2501         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
2502         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2503
2504 2019-01-25  Keith Rollin  <krollin@apple.com>
2505
2506         Update Xcode projects with "Apply Configuration to XCFileLists" build target
2507         https://bugs.webkit.org/show_bug.cgi?id=193781
2508         <rdar://problem/47201153>
2509
2510         Reviewed by Alex Christensen.
2511
2512         Part of generating the .xcfilelists used as part of adopting XCBuild
2513         includes running `make DerivedSources.make` from a standalone script.
2514         It’s important for this invocation to have the same environment as
2515         when the actual build invokes `make DerivedSources.make`. If the
2516         environments are different, then the two invocations will provide
2517         different results. In order to get the same environment in the
2518         standalone script, have the script launch xcodebuild targeting the
2519         "Apply Configuration to XCFileLists" build target, which will then
2520         re-invoke our standalone script. The script is now running again, this
2521         time in an environment with all workspace, project, target, xcconfig
2522         and other environment variables established.
2523
2524         The "Apply Configuration to XCFileLists" build target accomplishes
2525         this task via a small embedded shell script that consists only of:
2526
2527             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
2528
2529         The process that invokes "Apply Configuration to XCFileLists" first
2530         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
2531         evaluated and exports it into the shell environment. When xcodebuild
2532         is invoked, it inherits the value of this variable and can `eval` the
2533         contents of that variable. Our external standalone script can then set
2534         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
2535         of command-line parameters needed to restart itself in the appropriate
2536         state.
2537
2538         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2539         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2540
2541 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2542
2543         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
2544         https://bugs.webkit.org/show_bug.cgi?id=193802
2545         <rdar://problem/46010580>
2546
2547         Reviewed by Andy Estes.
2548
2549         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2550         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
2551         (TEST):
2552
2553 2019-01-25  Daniel Bates  <dabates@apple.com>
2554
2555         [iOS] uiController.keyDown() does not translate Control modified key
2556         https://bugs.webkit.org/show_bug.cgi?id=192898
2557
2558         Reviewed by Wenson Hsieh.
2559
2560         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
2561         key translation, as applicable. Among other cases, key translation occurs when performing
2562         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
2563         also makes the behavior of uiController.keyDown() more closely match the behavior of a
2564         human pressing down and releasing key(s) using a hardware keyboard.
2565
2566         * WebKitTestRunner/ios/HIDEventGenerator.h:
2567         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2568         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
2569
2570         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
2571         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
2572         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2573         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2574         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
2575         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
2576         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
2577         (-[HIDEventGenerator longPress:completionBlock:]):
2578         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
2579         Update code for above renaming.
2580
2581         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
2582         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
2583
2584         (-[HIDEventGenerator keyDown:]): Added.
2585         (-[HIDEventGenerator keyUp:]): Added.
2586         (-[HIDEventGenerator keyPress:completionBlock:]):
2587         (-[HIDEventGenerator eventDispatchThreadEntry:]):
2588         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
2589         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2590         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
2591         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
2592         (WTR::parseModifier): Deleted.
2593
2594 2019-01-25  Keith Rollin  <krollin@apple.com>
2595
2596         Complete the implementation of generate-xcfilelists
2597         https://bugs.webkit.org/show_bug.cgi?id=193782
2598
2599         Reviewed by Alex Christensen.
2600
2601         A preliminary version of generate-xcfilelists was added in r238008.
2602         This patch updates that script in order to:
2603
2604         - Support checking of .xcfilelists
2605         - Perform better execution of `make DerivedSources.make` by
2606           relaunching generate-xcfilelists under xcodebuild
2607         - Support incremental generation and checking of .xcfilelists
2608         - Support supplementary .xcfilelists files from WebKitAdditions
2609         - Support being wrapped by parallel version of generate-xcfilelists in
2610           Internal that adds support for (re)generating WebKit projects in
2611           that repo.
2612         - Support builds that have been performed in WebKitBuild as well as
2613           ~/Library/Developer/code/DerivedData
2614         - Increase robustness and debugging facilities.
2615
2616         * Scripts/generate-xcfilelists:
2617
2618 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2619
2620         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2621         https://bugs.webkit.org/show_bug.cgi?id=193297
2622         <rdar://problem/47158841>
2623
2624         Unreviewed test case fix.
2625
2626         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
2627         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
2628
2629         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2630         (TEST):
2631
2632 2019-01-25  Keith Rollin  <krollin@apple.com>
2633
2634         Update existing .xcfilelists
2635         https://bugs.webkit.org/show_bug.cgi?id=193791
2636         <rdar://problem/47201706>
2637
2638         Reviewed by Alex Christensen.
2639
2640         Many .xcfilelist files were added in r238824 in order to support
2641         XCBuild. Update these with recent changes to the set of build files
2642         and with the current generate-xcfilelist script.
2643
2644         * DumpRenderTree/DerivedSources-input.xcfilelist:
2645         * DumpRenderTree/DerivedSources-output.xcfilelist:
2646         * WebKitTestRunner/DerivedSources-input.xcfilelist:
2647         * WebKitTestRunner/DerivedSources-output.xcfilelist:
2648
2649 2019-01-25  Keith Rollin  <krollin@apple.com>
2650
2651         Fix missing dependencies in extract-dependencies-from-makefile
2652         https://bugs.webkit.org/show_bug.cgi?id=193783
2653         <rdar://problem/47201571>
2654
2655         Reviewed by Alex Christensen.
2656
2657         The extract-dependencies-from-makefile script generates .xcfilelists
2658         for XCBuild by invoking a makefile in --debug mode, parsing the
2659         dependency information in the output, and extracting information
2660         regarding targets and dependents. However, the way `make` emits this
2661         dependency information is not rigorous, and so we need to determine
2662         what lines to look for and parse by trial and error. This approach
2663         didn't coriginally atch all the information we needed to collect, so
2664         update the script to look for the additional lines we now know to look
2665         for.
2666
2667         * Scripts/extract-dependencies-from-makefile:
2668         (Parser):
2669         (Parser.addTarget):
2670         (Parser.addPrereq):
2671         (Parser.doParse):
2672
2673 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
2674
2675         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2676         https://bugs.webkit.org/show_bug.cgi?id=193297
2677         <rdar://problem/47158841>
2678
2679         Reviewed by Alex Christensen.
2680
2681         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
2682             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
2683         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2684         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2685         activating the message used to trigger the callback when it is set.
2686
2687 2019-01-25  Alex Christensen  <achristensen@webkit.org>
2688
2689         WKWebView.goBack should reload if there is a safe browsing warning
2690         https://bugs.webkit.org/show_bug.cgi?id=193805
2691         <rdar://problem/46908216>
2692
2693         Reviewed by Geoff Garen.
2694
2695         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2696         (+[Simple3LookupContext sharedLookupContext]):
2697         (-[Simple3LookupContext lookUpURL:completionHandler:]):
2698         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
2699         (TEST):
2700
2701 2019-01-25  Chris Dumez  <cdumez@apple.com>
2702
2703         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
2704         https://bugs.webkit.org/show_bug.cgi?id=193788
2705         <rdar://problem/47531231>
2706
2707         Reviewed by Alex Christensen.
2708
2709         Add API test coverage.
2710
2711         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2712         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
2713
2714 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
2715
2716         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
2717         https://bugs.webkit.org/show_bug.cgi?id=193771
2718
2719         Unreviewed infrastructure fix.
2720
2721         * Scripts/webkitpy/port/darwin.py:
2722         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
2723
2724 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2725
2726         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
2727
2728 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
2729
2730         Add contributors.json entries for Ling Ho and for a new bot watchers group.
2731
2732         * Scripts/webkitpy/common/config/contributors.json:
2733
2734 2019-01-25  Chris Dumez  <cdumez@apple.com>
2735
2736         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
2737         https://bugs.webkit.org/show_bug.cgi?id=193779
2738         <rdar://problem/46170903>
2739
2740         Reviewed by Antti Koivisto.
2741
2742         Add API test that quickly navigates forward to a previous process without waiting for it to
2743         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
2744         the process' previous page when reconnecting the it for the forward navigation.
2745
2746         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2747
2748 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2749
2750         Need a way for JavaScript (or bundle) code to participate in undo
2751         https://bugs.webkit.org/show_bug.cgi?id=190009
2752         <rdar://problem/44807048>
2753
2754         Reviewed by Ryosuke Niwa.
2755
2756         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
2757         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
2758
2759         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2760         (WTR::UIScriptController::lastUndoLabel const):
2761         (WTR::UIScriptController::firstRedoLabel const):
2762         (WTR::UIScriptController::platformUndoManager const):
2763         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2764         (WTR::UIScriptController::lastUndoLabel const):
2765         (WTR::UIScriptController::firstRedoLabel const):
2766         (WTR::UIScriptController::platformUndoManager const):
2767         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2768         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2769         (WTR::UIScriptController::lastUndoLabel const):
2770         (WTR::UIScriptController::firstRedoLabel const):
2771         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2772         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2773         (WTR::UIScriptController::lastUndoLabel const):
2774         (WTR::UIScriptController::firstRedoLabel const):
2775         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2776         (WTR::UIScriptController::platformUndoManager const):
2777         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2778         (WTR::UIScriptController::platformUndoManager const):
2779
2780 2019-01-25  Zalan Bujtas  <zalan@apple.com>
2781
2782         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
2783         https://bugs.webkit.org/show_bug.cgi?id=193824
2784
2785         Reviewed by Antti Koivisto.
2786
2787         * LayoutReloaded/misc/LFC-passing-tests.txt:
2788
2789 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
2790
2791         Update macOS JSC bot configurations
2792         https://bugs.webkit.org/show_bug.cgi?id=193739
2793
2794         Reviewed by Alexey Proskuryakov.
2795
2796         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
2797         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2798         (BubbleQueueServer): Move JSC EWS to Mojave section.
2799         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2800         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
2801         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
2802
2803 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
2804
2805         [Win][WebKitTestRunner] Implement EventSenderProxy
2806         https://bugs.webkit.org/show_bug.cgi?id=193755
2807
2808         Reviewed by Don Olmstead.
2809
2810         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
2811         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
2812         (WTR::EventSenderProxy::dispatchMessage):
2813         (WTR::EventSenderProxy::EventSenderProxy):
2814         (WTR::EventSenderProxy::mouseDown):
2815         (WTR::EventSenderProxy::mouseUp):
2816         (WTR::EventSenderProxy::mouseMoveTo):
2817         (WTR::EventSenderProxy::mouseScrollBy):
2818         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2819
2820 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2821
2822         Unreviewed fix for API test failure after r240437.
2823
2824         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
2825
2826         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2827
2828 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2829
2830         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
2831         https://bugs.webkit.org/show_bug.cgi?id=193787
2832         <rdar://problem/47497634>
2833
2834         Reviewed by Alexey Proskuryakov.
2835
2836         * Scripts/webkitdirs.pm:
2837         (iosSimulatorApplicationsPath): Pick from available runtime directories.
2838
2839 2019-01-24  Truitt Savell  <tsavell@apple.com>
2840
2841         Unreviewed, rolling out r240446.
2842
2843         Casued 5 API failures
2844
2845         Reverted changeset:
2846
2847         "Activate the WebResourceLoadStatisticsStore in the
2848         NetworkProcess and deactivate it in the UIProcess."
2849         https://bugs.webkit.org/show_bug.cgi?id=193297
2850         https://trac.webkit.org/changeset/240446
2851
2852 2019-01-24  Zalan Bujtas  <zalan@apple.com>
2853
2854         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
2855         https://bugs.webkit.org/show_bug.cgi?id=193741
2856         <rdar://problem/47135030>
2857
2858         Reviewed by Antti Koivisto and Simon Fraser.
2859
2860         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2861         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
2862         (TestWebKitAPI::TEST):
2863
2864 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
2865
2866         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
2867         https://bugs.webkit.org/show_bug.cgi?id=193297
2868         <rdar://problem/47158841>
2869
2870         Reviewed by Alex Christensen.
2871
2872         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2873         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
2874         activating the message used to trigger the callback when it is set.
2875
2876 2019-01-24  John Wilander  <wilander@apple.com>
2877
2878         Add Ad Click Attribution as an internal/experimental feature
2879         https://bugs.webkit.org/show_bug.cgi?id=193685
2880         <rdar://problem/47450399>
2881
2882         Reviewed by Brent Fulgham.
2883
2884         Added test option adClickAttributionEnabled.
2885
2886         * DumpRenderTree/TestOptions.cpp:
2887         (TestOptions::TestOptions):
2888         * DumpRenderTree/TestOptions.h:
2889         * DumpRenderTree/mac/DumpRenderTree.mm:
2890         (setWebPreferencesForTestOptions):
2891
2892 2019-01-24  Antti Koivisto  <antti@apple.com>
2893
2894         [PSON] Flash on back navigation on Mac
2895         https://bugs.webkit.org/show_bug.cgi?id=193716
2896         <rdar://problem/47148458>
2897
2898         Reviewed by Chris Dumez.
2899
2900         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2901
2902         Closing of the previous page is delayed so waiting for didFinishNavigation is
2903         not sufficient to guarantee we have received all the messages. Wait for them.
2904
2905 2019-01-24  Chris Dumez  <cdumez@apple.com>
2906
2907         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
2908         https://bugs.webkit.org/show_bug.cgi?id=193761
2909         <rdar://problem/47456405>
2910
2911         Reviewed by Alex Christensen.
2912
2913         Add API test coverage.
2914
2915         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2916
2917 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
2918
2919         webkitpy: Missing PID in crashlog name should not be fatal
2920         https://bugs.webkit.org/show_bug.cgi?id=193771
2921
2922         If we can't determine the PID of a crashlog, just ignore the crashlog instead
2923         of raising an exception.
2924
2925         Reviewed by Lucas Forschler.
2926
2927         * Scripts/webkitpy/port/darwin.py:
2928         (DarwinPort._merge_crash_logs):
2929
2930 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2931
2932         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
2933         https://bugs.webkit.org/show_bug.cgi?id=193746
2934
2935         Reviewed by Youenn Fablet.
2936
2937         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
2938         so we'd best just not call it.
2939
2940         * Scripts/webkitpy/w3c/test_exporter.py:
2941         (WebPlatformTestExporter.create_branch_with_patch):
2942
2943 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
2944
2945         Move FileSystem to WTF
2946         https://bugs.webkit.org/show_bug.cgi?id=193602
2947
2948         Reviewed by Yusuke Suzuki.
2949
2950         * DumpRenderTree/win/DumpRenderTree.cpp:
2951         * TestWebKitAPI/CMakeLists.txt:
2952         * TestWebKitAPI/PlatformGTK.cmake:
2953         * TestWebKitAPI/PlatformJSCOnly.cmake:
2954         * TestWebKitAPI/PlatformPlayStation.cmake:
2955         * TestWebKitAPI/PlatformWPE.cmake:
2956         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2957         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
2958         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2959         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2960         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
2961         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
2962         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2963         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2964         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
2965         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2966
2967 2019-01-24  Philippe Normand  <pnormand@igalia.com>
2968
2969         [WPE] Remove hard dependency on subprocess32 for the API tests
2970
2971         Rubber-stamped by Carlos Garcia Campos.
2972
2973         * glib/api_test_runner.py:
2974         (TestRunner._run_test_qt): Lazily import subprocess32 and check
2975         its presence only when running WPEQt tests.
2976
2977 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2978
2979         [GLIB] Expose JavaScriptCore options in GLib public API
2980         https://bugs.webkit.org/show_bug.cgi?id=188742
2981
2982         Reviewed by Michael Catanzaro.
2983
2984         Add a test for the new API.
2985
2986         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2987         (testsJSCOptions):
2988         (main):
2989
2990 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2991
2992         [GTK][WPE] Support JPEG 2000 images
2993         https://bugs.webkit.org/show_bug.cgi?id=186272
2994
2995         Reviewed by Žan Doberšek.
2996
2997         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
2998
2999         * gtk/jhbuild.modules:
3000         * wpe/jhbuild.modules:
3001
3002 2019-01-23  David Kilzer  <ddkilzer@apple.com>
3003
3004         check-webkit-style should warn when using soft-linking macros in a header
3005         <https://webkit.org/b/193750>
3006
3007         Reviewed by Darin Adler.
3008
3009         * Scripts/webkitpy/style/checkers/cpp.py:
3010         (check_language): Add softlink/header check by refactoring the
3011         softlink/framework check.
3012         (CppChecker): Enable softlink/header check by default.
3013         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3014         (CppStyleTest.test_softlink_framework): Rename from
3015         CppStyleTest.test_softlink() and change test framework name in
3016         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
3017         files. Set file_name for macros that only appear in headers.
3018         (CppStyleTest.test_softlink_header): Add tests for using
3019         soft-link macros in headers.
3020
3021 2019-01-23  Chris Dumez  <cdumez@apple.com>
3022
3023         Deprecate API to limit the maximum number of WebProcesses
3024         https://bugs.webkit.org/show_bug.cgi?id=193725
3025         <rdar://problem/47464879>
3026
3027         Reviewed by Geoff Garen.
3028
3029         Update existing API tests to stop using deprecated API.
3030
3031         * MiniBrowser/mac/AppDelegate.m:
3032         (defaultConfiguration):
3033         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3034         (TestWebKitAPI::TEST):
3035         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
3036         (TestWebKitAPI::TEST):
3037         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3038         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
3039         (TEST):
3040         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3041         (TEST):
3042
3043 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3044
3045         [ews-app] Rename ews model buildermappings to buildermapping
3046         https://bugs.webkit.org/show_bug.cgi?id=193729
3047
3048         Reviewed by Lucas Forschler.
3049
3050         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
3051         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
3052         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
3053
3054 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3055
3056         [ews-app] Rename ews model steps to step
3057         https://bugs.webkit.org/show_bug.cgi?id=193697
3058
3059         Reviewed by Lucas Forschler.
3060
3061         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
3062         (Step): Renamed Steps to Step.
3063
3064 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
3065
3066         Clean up IndexedDB files between tests
3067         https://bugs.webkit.org/show_bug.cgi?id=192796
3068         <rdar://problem/46824999>
3069
3070         Reviewed by Geoffrey Garen.
3071
3072         * DumpRenderTree/mac/DumpRenderTree.mm:
3073         (runTest):
3074         * WebKitTestRunner/TestController.cpp:
3075         (WTR::TestController::resetStateToConsistentValues):
3076         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
3077         (WTR::RemoveAllIndexedDatabasesCallback):
3078         (WTR::TestController::ClearIndexedDatabases):
3079         * WebKitTestRunner/TestController.h:
3080         * WebKitTestRunner/TestInvocation.cpp:
3081         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3082
3083 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3084
3085         [ews-app] Rename ews model Builds to Build
3086         https://bugs.webkit.org/show_bug.cgi?id=193695
3087
3088         Reviewed by Lucas Forschler.
3089
3090         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
3091         (Build): Renamed Builds to Build.
3092
3093 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3094
3095         webkitpy: Wait longer when launching WebKitTestRunner
3096         https://bugs.webkit.org/show_bug.cgi?id=193734
3097
3098         Reviewed by Aakash Jain.
3099
3100         * Scripts/webkitpy/port/simulator_process.py:
3101         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
3102
3103 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
3104
3105         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
3106         https://bugs.webkit.org/show_bug.cgi?id=193182
3107         <rdar://problem/47452154>
3108
3109         Reviewed by Tim Horton.
3110
3111         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
3112         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
3113         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
3114
3115         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
3116         preventing later tests from recognizing gestures.
3117
3118         * WebKitTestRunner/ios/TestControllerIOS.mm:
3119         (WTR::TestController::platformResetStateToConsistentValues):
3120
3121         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
3122
3123 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3124
3125         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
3126         https://bugs.webkit.org/show_bug.cgi?id=193722
3127         <rdar://problem/47481475>
3128
3129         Reviewed by Lucas Forschler.
3130
3131         iPhone and iPad ports should both use the iOS config.
3132
3133         * Scripts/webkitpy/port/ios_simulator.py:
3134         (IPhoneSimulatorPort.__init__):
3135         (IPadSimulatorPort.__init__):
3136
3137 2019-01-23  Rob Buis  <rbuis@igalia.com>
3138
3139         Update MIME type parser
3140         https://bugs.webkit.org/show_bug.cgi?id=180526
3141
3142         Reviewed by Frédéric Wang.
3143
3144         Add unit tests for both parse modes of ParsedContentType.
3145
3146         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3147         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
3148         (TestWebKitAPI::TEST):
3149
3150 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
3151
3152         [ews-app] fetch loop should not stop on network issues
3153         https://bugs.webkit.org/show_bug.cgi?id=193666
3154
3155         Reviewed by Lucas Forschler.
3156
3157         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3158         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
3159
3160 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3161
3162         [iOS] Multiple WKWebViewAutofillTests are flaky failures
3163         https://bugs.webkit.org/show_bug.cgi?id=189165
3164         <rdar://problem/47433765>
3165
3166         Reviewed by Tim Horton.
3167
3168         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
3169         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
3170         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
3171         process in sufficient to ensure that any previous action that blurred the focused element in the web process
3172         would make its way to the UI process by the time the layer tree commit is finished.
3173
3174         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
3175         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
3176         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
3177         will fail because it asks for -_autofillContext too early.
3178
3179         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
3180         is handled in the UI process.
3181
3182         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3183
3184         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
3185         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
3186         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
3187         input session.
3188
3189         (-[AutofillTestView textInputHasAutofillContext]):
3190
3191         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
3192
3193         * TestWebKitAPI/cocoa/TestWKWebView.h:
3194         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3195         (nextInputSessionChangeCount):
3196
3197         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
3198         This includes changing the focused element from one to another.
3199
3200         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
3201         (-[TestWKWebView didStartFormControlInteraction]):
3202         (-[TestWKWebView didEndFormControlInteraction]):
3203         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
3204
3205         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
3206         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
3207         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
3208         that doesn't require an input session to one that doesn't.
3209
3210 2019-01-22  David Kilzer  <ddkilzer@apple.com>
3211
3212         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
3213         <https://webkit.org/b/193676>
3214
3215         Reviewed by Alexey Proskuryakov.
3216
3217         * Scripts/webkitpy/style/checkers/cpp.py:
3218         (check_member_initialization_list):
3219         - Don't report missing whitespace around colon if the colon at
3220           the start of the line is formatted correctly.
3221         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3222         (WebKitStyleTest.test_member_initialization_list):
3223         - Add a test for a missing permutation of existing tests.
3224         - Add a test this false-positive.
3225         - Add blank lines between subtests to make them easier to read.
3226
3227 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
3228
3229         [build.webkit.org] Unit-test failure after r237113
3230         https://bugs.webkit.org/show_bug.cgi?id=193669
3231
3232         Reviewed by Michael Catanzaro.
3233
3234         * BuildSlaveSupport/build.webkit.org-config/factories.py:
3235         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
3236         multiple or zero flags.
3237
3238 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
3239
3240         Cache bytecode to disk
3241         https://bugs.webkit.org/show_bug.cgi?id=192782
3242         <rdar://problem/46084932>
3243
3244         Reviewed by Keith Miller.
3245
3246         Add test helper to execute bytecode-cache tests: it executes each test
3247         twice, the first with JSC_diskCachePath set to a temporary directory
3248         and second with JSC_forceDiskCache=true (in addition to the cache path)
3249         to guarantee that only the disk cache is being used and no new
3250         UnlinkedCodeBlocks are being created.
3251
3252         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
3253         * Scripts/run-jsc-stress-tests:
3254
3255 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
3256
3257         [css-logical] Implement flow-relative margin, padding and border shorthands
3258         https://bugs.webkit.org/show_bug.cgi?id=188697
3259
3260         Reviewed by Simon Fraser and Antti Koivisto.
3261
3262         * DumpRenderTree/TestOptions.cpp:
3263         (TestOptions::TestOptions):
3264         * DumpRenderTree/TestOptions.h:
3265         * DumpRenderTree/mac/DumpRenderTree.mm:
3266         (setWebPreferencesForTestOptions):
3267         Allow tests to enable the CSSLogicalEnabled flag in WK1.
3268
3269         * Scripts/webkitpy/style/checkers/jsonchecker.py:
3270         (JSONCSSPropertiesChecker.check_codegen_properties):
3271         Allow CSS property definitions to have a 'runtime-flag' parameter which
3272         disables the property when the specified runtime flag is disabled.
3273
3274 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
3275
3276         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
3277         https://bugs.webkit.org/show_bug.cgi?id=193643
3278
3279         Reviewed by Michael Catanzaro.
3280
3281         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
3282         * wpe/jhbuild.modules: Ditto.
3283
3284 2019-01-21  Zalan Bujtas  <zalan@apple.com>
3285
3286         [LFC][Floats] Take float top position into account when computing containing block height.
3287         https://bugs.webkit.org/show_bug.cgi?id=193655
3288
3289         Reviewed by Antti Koivisto.
3290
3291         * LayoutReloaded/misc/LFC-passing-tests.txt:
3292
3293 2019-01-21  David Kilzer  <ddkilzer@apple.com>
3294
3295         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
3296         <https://webkit.org/b/193645>
3297         <rdar://problem/47421574>
3298
3299         Reviewed by Alex Christensen.
3300
3301         - Now checks for local soft-linking of all frameworks that have
3302           their own *SoftLinking.{cpp,h,mm} files.
3303         - Changes softlink/uikit warning to softlink/framework.
3304
3305         * Scripts/webkitpy/style/checkers/cpp.py:
3306         (check_language):
3307         (CppChecker):
3308         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3309         (CppStyleTest):
3310
3311 2019-01-20  Saam Barati  <sbarati@apple.com>
3312
3313         Rollout r240210: It broke tests on iOS
3314         https://bugs.webkit.org/show_bug.cgi?id=193640
3315
3316         Unreviewed.
3317
3318         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
3319         * Scripts/run-jsc-stress-tests:
3320
3321 2019-01-20  chris fleizach  <cfleizach@apple.com>
3322
3323         AX: Support returning relative frames for accessibility
3324         https://bugs.webkit.org/show_bug.cgi?id=193414
3325         <rdar://problem/47268501>
3326
3327         Reviewed by Zalan Bujtas.
3328
3329         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3330         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3331         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3332         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3333         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3334         (WTR::attributesOfElement):
3335         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3336
3337 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
3338
3339         Unreviewed, add my new email address
3340
3341         * Scripts/webkitpy/common/config/contributors.json:
3342
3343 2019-01-19  Zalan Bujtas  <zalan@apple.com>
3344
3345         [LFC][BFC] <body>'s overflow property value is propagated to viewport
3346         https://bugs.webkit.org/show_bug.cgi?id=193617
3347
3348         Reviewed by Antti Koivisto.
3349
3350         * LayoutReloaded/misc/LFC-passing-tests.txt:
3351
3352 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
3353
3354         Unreviewed, rolling out r240209.
3355
3356         Broke GTK/WPE injected bundle
3357
3358         Reverted changeset:
3359
3360         "AX: Support returning relative frames for accessibility"
3361         https://bugs.webkit.org/show_bug.cgi?id=193414
3362         https://trac.webkit.org/changeset/240209
3363
3364 2019-01-12  Dan Bernstein  <mitz@apple.com>
3365
3366         [Cocoa] Avoid importing directly from subumbrella frameworks
3367         https://bugs.webkit.org/show_bug.cgi?id=186016
3368         <rdar://problem/40591038>
3369
3370         Reviewed by Sam Weinig.
3371
3372         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
3373           LaunchServices header.
3374         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3375           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3376         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
3377           when using SDKs earlier than 10.13.
3378         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
3379           and OTHER_CPLUSPLUSFLAGS.
3380         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3381           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3382         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
3383           LaunchServices header.
3384
3385 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
3386
3387         Cache bytecode to disk
3388         https://bugs.webkit.org/show_bug.cgi?id=192782
3389         <rdar://problem/46084932>
3390
3391         Reviewed by Keith Miller.
3392
3393         Add test helper to execute bytecode-cache tests: it executes each test
3394         twice, the first with JSC_diskCachePath set to a temporary directory
3395         and second with JSC_forceDiskCache=true (in addition to the cache path)
3396         to guarantee that only the disk cache is being used and no new
3397         UnlinkedCodeBlocks are being created.
3398
3399         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
3400         * Scripts/run-jsc-stress-tests:
3401
3402 2019-01-20  chris fleizach  <cfleizach@apple.com>
3403
3404         AX: Support returning relative frames for accessibility
3405         https://bugs.webkit.org/show_bug.cgi?id=193414
3406         <rdar://problem/47268501>
3407
3408         Reviewed by Zalan Bujtas.
3409
3410         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3411         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3412         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3413         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3414         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3415         (WTR::attributesOfElement):
3416         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
3417
3418 2019-01-20  Antoine Quint  <graouts@apple.com>
3419
3420         Add a POINTER_EVENTS feature flag
3421         https://bugs.webkit.org/show_bug.cgi?id=193577
3422         <rdar://problem/47408511>
3423
3424         Unreviewed. Also enable Pointer Events for iosmac.
3425
3426         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3427
3428 2019-01-19  Zalan Bujtas  <zalan@apple.com>
3429
3430         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
3431         https://bugs.webkit.org/show_bug.cgi?id=193613
3432
3433         Reviewed by Antti Koivisto.
3434
3435         * LayoutReloaded/misc/LFC-passing-tests.txt:
3436
3437 2019-01-19  Antoine Quint  <graouts@apple.com>
3438
3439         Add a POINTER_EVENTS feature flag
3440         https://bugs.webkit.org/show_bug.cgi?id=193577
3441
3442         Reviewed by Dean Jackson.
3443
3444         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3445
3446 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
3447
3448         Disable the run-jsc-stress-test remote host key check [second round].
3449         https://bugs.webkit.org/show_bug.cgi?id=192988
3450
3451         Reviewed by Dewei Zhu.
3452
3453         * Scripts/run-jsc-stress-tests:
3454
3455 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3456
3457         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
3458         https://bugs.webkit.org/show_bug.cgi?id=193597
3459
3460         Reviewed by Lucas Forschler.
3461
3462         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3463
3464 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3465
3466         [build.webkit.org] api tests failures are incorrectly named as unit test failures
3467         https://bugs.webkit.org/show_bug.cgi?id=193595
3468
3469         Reviewed by Lucas Forschler.
3470
3471         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
3472         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
3473         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
3474
3475 2019-01-18  Chris Dumez  <cdumez@apple.com>
3476
3477         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
3478         https://bugs.webkit.org/show_bug.cgi?id=193588
3479         <rdar://problem/47131566>
3480
3481         Reviewed by Alex Christensen.
3482
3483         Add layout test coverage.
3484
3485         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3486
3487 2019-01-18  Jer Noble  <jer.noble@apple.com>
3488
3489         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3490         https://bugs.webkit.org/show_bug.cgi?id=189553
3491
3492         Reviewed by Tim Horton.
3493
3494         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3495
3496         * ContentExtensionTester/Configurations/Base.xcconfig:
3497         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3498         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3499         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3500         * ImageDiff/cg/Configurations/Base.xcconfig:
3501         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3502         * MiniBrowser/Configurations/Base.xcconfig:
3503         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3504         * MobileMiniBrowser/Configurations/Base.xcconfig:
3505         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3506         * Scripts/webkitpy/style/checker.py:
3507         (_all_categories):
3508         (FileType):
3509         (CheckerDispatcher._file_type):
3510         (CheckerDispatcher._create_checker):
3511         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3512         (SDKVariantChecker):
3513         (SDKVariantChecker.__init__):
3514         (SDKVariantChecker.check):
3515         * TestWebKitAPI/Configurations/Base.xcconfig:
3516         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3517         * WebEditingTester/Configurations/Base.xcconfig:
3518         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3519         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3520         * WebKitTestRunner/Configurations/Base.xcconfig:
3521         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3522         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3523         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3524
3525 2019-01-18  David Kilzer  <ddkilzer@apple.com>
3526
3527         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
3528         <https://webkit.org/b/193568>
3529         <rdar://problem/47381130>
3530
3531         Reviewed by Alex Christensen.
3532
3533         Make sure no one re-introduces UIKit soft-linking by adding a
3534         style rule.
3535
3536         * Scripts/webkitpy/style/checkers/cpp.py:
3537         (check_language): Add softlink/uikit check.
3538         (CppChecker): Enable softlink/uikit check.
3539         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3540         (CppStyleTest): Add test for softlink/uikit.
3541
3542 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
3543
3544         [GTK] install-dependencies tool looks for libunistring-dev for dnf
3545         https://bugs.webkit.org/show_bug.cgi?id=193584
3546
3547         Change "-dev" to "-devel".
3548
3549         Reviewed by Michael Catanzaro.
3550
3551         * gtk/install-dependencies:
3552
3553 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3554
3555         webkitpy: Add iPhone and iPad ports
3556         https://bugs.webkit.org/show_bug.cgi?id=193537
3557         <rdar://problem/47353390>
3558
3559         Reviewed by Lucas Forschler.
3560
3561         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
3562         ports. Note that this separation is optional, the --ios-simulator command remains.
3563
3564         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3565         (RunTest.test_device_type_test_division): Drive-by fix.
3566         (RunTest.test_device_type_specific_listing): Ditto.
3567         (RunTest.test_ipad_test_division):
3568         (RunTest):
3569         (RunTest.test_ipad_listing):
3570         * Scripts/webkitpy/port/factory.py:
3571         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
3572         (PortFactory):
3573         * Scripts/webkitpy/port/ios_simulator.py:
3574         (IPhoneSimulatorPort):
3575         (IPadSimulatorPort):
3576
3577 2019-01-18  Chris Dumez  <cdumez@apple.com>
3578
3579         Regression(PSON) Scroll position is not always restored properly when navigating back
3580         https://bugs.webkit.org/show_bug.cgi?id=193578
3581         <rdar://problem/47386331>
3582
3583         Reviewed by Tim Horton.
3584
3585         Add API test coverage.
3586
3587         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3588
3589 2019-01-18  Youenn Fablet  <youenn@apple.com>
3590
3591         Add a new SPI to request for cache storage quota increase
3592         https://bugs.webkit.org/show_bug.cgi?id=193323
3593
3594         Reviewed by Alex Christensen.
3595
3596         Implement WebsiteDataStore quota delegate to handle quota requests.
3597         By default, do not update quota.
3598         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
3599
3600         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3601         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3602         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
3603         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3604         * WebKitTestRunner/TestController.cpp:
3605         (WTR::TestController::allowCacheStorageQuotaIncrease):
3606         * WebKitTestRunner/TestController.h:
3607         * WebKitTestRunner/TestInvocation.cpp:
3608         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3609         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3610         (-[CacheStorageQuotaManager init]):
3611         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3612         (WTR::initializeWebViewConfiguration):
3613         (WTR::TestController::cocoaResetStateToConsistentValues):
3614         (WTR::TestController::allowCacheStorageQuotaIncrease):
3615
3616 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3617
3618         [ews-build] Pass owner to the triggered builds
3619         https://bugs.webkit.org/show_bug.cgi?id=193574
3620
3621         Reviewed by Lucas Forschler.
3622
3623         * BuildSlaveSupport/ews-build/factories.py:
3624         (BuildFactory.propertiesToPassToTriggers):
3625
3626 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
3627
3628         [ews-app] Send patch author as a build property
3629         https://bugs.webkit.org/show_bug.cgi?id=193560
3630
3631         Reviewed by Lucas Forschler.
3632
3633         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3634         (BugzillaPatchFetcher.fetch):
3635
3636 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3637
3638         webkitpy: Implement device type specific expected results (Follow-up fix)
3639         https://bugs.webkit.org/show_bug.cgi?id=192162
3640         <rdar://problem/46345449>
3641
3642         Unreviewed infrastructure fix.
3643
3644         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3645         (Manager.run): Don't boot a device if no tests are available to run on it.
3646
3647 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3648
3649         webkitpy: Implement device type specific expected results (Follow-up fix)
3650         https://bugs.webkit.org/show_bug.cgi?id=192162
3651         <rdar://problem/46345449>
3652
3653         Unreviewed infrastructure fix.
3654
3655         * Scripts/webkitpy/api_tests/manager.py:
3656         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
3657
3658 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
3659
3660         webkitpy: Implement device type specific expected results (Part 2)
3661         https://bugs.webkit.org/show_bug.cgi?id=192162
3662         <rdar://problem/46345449>
3663
3664         Rubber-stamped by Aakash Jain.
3665
3666         This change uses device_type to select a different set of TestExpectation files based on the type of device running
3667         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
3668         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
3669
3670         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
3671         (LayoutTestFinder.find_tests): Pass device_type through.
3672         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
3673         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
3674         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3675         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
3676         (Manager._collect_tests): Pass device type to test finder.
3677         (Manager._needs_web_platform_test):
3678         (Manager._prepare_lists): Index _expectations by device type.
3679         (Manager._test_input_for_file):
3680         (Manager._test_is_slow): Ditto.
3681         (Manager._test_should_dump_jsconsolelog_in_stderr):
3682         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
3683         (Manager._get_test_inputs):
3684         (Manager._update_worker_count):
3685         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
3686         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
3687         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
3688         the one which runs the test.
3689         (Manager._run_test_subset):
3690         (Manager._run_tests): Index _expectations by current_device_type.
3691         (Manager._print_expectation_line_for_test): Ditto.
3692         (Manager._print_expectations_for_subset): Ditto.
3693         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
3694         Unlike run, this function will behave the same regardless of what devices are available.
3695         (Manager._custom_device_for_test): Deleted.
3696         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3697         (ManagerTest.test_uses_custom_device): Deleted.
3698         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
3699         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3700         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
3701         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
3702         all of the expectations.
3703         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
3704         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
3705         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3706         (TestExpectations.__init__): Allow device_type to be passed through.
3707         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
3708         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
3709         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3710         (summarize_results):
3711         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
3712         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
3713         a test ran with, one must check all expectations to find the first non-skip expectation.
3714         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3715         (RunTest.test_device_type_test_division):
3716         (RunTest):
3717         (RunTest.test_device_type_specific_listing):
3718         * Scripts/webkitpy/port/base.py:
3719         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
3720         (Port.supported_device_types): The result of this function will change based on what devices are available.
3721         * Scripts/webkitpy/port/device_port.py:
3722         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
3723         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
3724         can be used.
3725         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
3726         any, or the DEFAULT_DEVICE_TYPES of the port.
3727         * Scripts/webkitpy/port/ios.py:
3728         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
3729         * Scripts/webkitpy/port/ios_simulator.py:
3730         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
3731         * Scripts/webkitpy/port/watch.py:
3732         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
3733         * Scripts/webkitpy/port/watch_simulator.py:
3734         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
3735         * Scripts/webkitpy/xcode/device_type.py:
3736         (DeviceType):
3737         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
3738
3739 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3740
3741         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
3742         https://bugs.webkit.org/show_bug.cgi?id=193575
3743
3744         Reviewed by Michael Catanzaro.
3745
3746         Allow the script to run without explicit port argument because
3747         it's specific to the WPE port anyway.
3748
3749         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
3750         and simplify the rest of the code accordingly.
3751
3752 2019-01-18  Charlie Turner  <cturner@igalia.com>
3753
3754         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
3755         https://bugs.webkit.org/show_bug.cgi?id=192229
3756
3757         Reviewed by Xabier Rodriguez-Calvar.
3758
3759         * MiniBrowser/wpe/main.cpp:
3760         (main): Enable encrypted-media by default.
3761
3762 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3763
3764         [Flatpak] Missing KeyboardInterrupt exception handler
3765         https://bugs.webkit.org/show_bug.cgi?id=193570
3766
3767         Reviewed by Michael Catanzaro.
3768
3769         * flatpak/flatpakutils.py:
3770         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
3771
3772 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3773
3774         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
3775         https://bugs.webkit.org/show_bug.cgi?id=193564
3776
3777         Reviewed by Antti Koivisto.
3778
3779         * LayoutReloaded/misc/LFC-passing-tests.txt:
3780
3781 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3782
3783         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
3784         https://bugs.webkit.org/show_bug.cgi?id=193562
3785
3786         Reviewed by Antti Koivisto.
3787
3788         * LayoutReloaded/misc/LFC-passing-tests.txt:
3789
3790 2019-01-18  Zalan Bujtas  <zalan@apple.com>
3791
3792         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
3793         https://bugs.webkit.org/show_bug.cgi?id=193555
3794
3795         Reviewed by Antti Koivisto.
3796
3797         * LayoutReloaded/misc/LFC-passing-tests.txt:
3798
3799 2019-01-18  Philippe Normand  <pnormand@igalia.com>
3800
3801         [WPE] Add Qt extension
3802         https://bugs.webkit.org/show_bug.cgi?id=191464
3803
3804         Reviewed by Carlos Garcia Campos.
3805
3806         MiniBrowser and API tests for the WPE Qt API. To run the
3807         MiniBrowser a new script is introduced. Example invocation:
3808
3809         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
3810
3811         Also note-worthy is the introduction of the python2-subprocess32
3812         dependency to run the GLib API tests.
3813
3814         * MiniBrowser/wpe/CMakeLists.txt:
3815         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
3816         * MiniBrowser/wpe/qt/main.cpp: Added.
3817         (main):
3818         * MiniBrowser/wpe/qt/main.qml: Added.
3819         * MiniBrowser/wpe/qt/qml.qrc: Added.
3820         * Scripts/run-gtk-tests:
3821         (GtkTestRunner.is_google_test):
3822         (GtkTestRunner):
3823         (GtkTestRunner.is_qt_test):
3824         * Scripts/run-qt-wpe-minibrowser: Added.
3825         * Scripts/run-wpe-tests:
3826         (WPETestRunner):
3827         (WPETestRunner.is_google_test):
3828         (WPETestRunner.is_qt_test):
3829         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
3830         (TestLoad::main):
3831         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
3832         (TestLoadHtml::main):
3833         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
3834         (TestLoadRequest::main):
3835         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
3836         (TestRunJavaScript::main):
3837         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
3838         (waitForSignal):
3839         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
3840         (LoadSpy::LoadSpy):
3841         (LoadSpy::~LoadSpy):
3842         (LoadSpy::onLoadingChanged):
3843         (LoadStartedCatcher::LoadStartedCatcher):
3844         (LoadStartedCatcher::~LoadStartedCatcher):
3845         (LoadStartedCatcher::onLoadingChanged):
3846         (waitForLoadSucceeded):
3847         (waitForLoadFailed):
3848         * TestWebKitAPI/glib/CMakeLists.txt:
3849         * flatpak/flatpakutils.py:
3850         (WebkitFlatpak.load_from_args):
3851         (WebkitFlatpak.__init__):
3852         (WebkitFlatpak.clean_args):
3853         (WebkitFlatpak.run_in_sandbox):
3854         * flatpak/org.webkit.CommonModules.yaml:
3855         * flatpak/org.webkit.WPE.yaml:
3856         * flatpak/org.webkit.WPEModules.yaml:
3857         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
3858         * flatpak/org.webkit.WebKit.yaml:
3859         * glib/api_test_runner.py:
3860         (TestRunner._run_test_qt):
3861         (TestRunner.is_qt_test):
3862         (TestRunner._run_test):
3863
3864 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3865
3866         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
3867         https://bugs.webkit.org/show_bug.cgi?id=193494
3868         <rdar://problem/46859627>
3869
3870         Reviewed by Simon Fraser and Tim Horton.
3871
3872         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
3873         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
3874
3875         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3876         (WTR::UIScriptController::contentOffsetX const):
3877         (WTR::UIScriptController::contentOffsetY const):
3878         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3879         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3880         (WTR::UIScriptController::contentOffsetX const):
3881         (WTR::UIScriptController::contentOffsetY const):
3882         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3883
3884         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
3885
3886         * WebKitTestRunner/TestController.cpp:
3887         (WTR::updateTestOptionsFromTestHeader):
3888         * WebKitTestRunner/TestOptions.h:
3889         (WTR::TestOptions::hasSameInitializationOptions const):
3890         * WebKitTestRunner/ios/TestControllerIOS.mm:
3891         (WTR::TestController::platformResetStateToConsistentValues):
3892         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3893         (WTR::UIScriptController::contentOffsetX const):
3894         (WTR::UIScriptController::contentOffsetY const):
3895
3896 2019-01-17  Truitt Savell  <tsavell@apple.com>
3897
3898         Unreviewed, rolling out r240124.
3899
3900         This commit broke an internal build.
3901
3902         Reverted changeset:
3903
3904         "SDK_VARIANT build destinations should be separate from non-
3905         SDK_VARIANT builds"
3906         https://bugs.webkit.org/show_bug.cgi?id=189553
3907         https://trac.webkit.org/changeset/240124
3908
3909 2019-01-17  Alex Christensen  <achristensen@webkit.org>
3910
3911         Fix string concatenation API test after r239920
3912         https://bugs.webkit.org/show_bug.cgi?id=193551
3913         <rdar://problem/47359304>
3914
3915         Reviewed by Youenn Fablet.
3916
3917         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
3918         (TestWebKitAPI::TEST):
3919         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
3920         in WebKit's build configuration like it apparently is on Linux.
3921
3922 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3923
3924         [ews-build] validate-patch should handle the case when bug_id is None
3925         https://bugs.webkit.org/show_bug.cgi?id=193547
3926
3927         Reviewed by Lucas Forschler.
3928
3929         * BuildSlaveSupport/ews-build/steps.py:
3930         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
3931         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
3932
3933 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3934
3935         [ews-build] Add patch author information in build
3936         https://bugs.webkit.org/show_bug.cgi?id=193465
3937
3938         Reviewed by Lucas Forschler.
3939
3940         * BuildSlaveSupport/ews-build/steps.py:
3941         (ValidatePatch._is_patch_obsolete):
3942
3943 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
3944
3945         [ews-build] Pass bug_id to the triggered builds
3946         https://bugs.webkit.org/show_bug.cgi?id=193548
3947
3948         Reviewed by Lucas Forschler.
3949
3950         * BuildSlaveSupport/ews-build/factories.py:
3951         (BuildFactory.propertiesToPassToTriggers):
3952
3953 2019-01-17  Jer Noble  <jer.noble@apple.com>
3954
3955         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
3956         https://bugs.webkit.org/show_bug.cgi?id=189553
3957
3958         Reviewed by Tim Horton.
3959
3960         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
3961
3962         * ContentExtensionTester/Configurations/Base.xcconfig:
3963         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
3964         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3965         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
3966         * ImageDiff/cg/Configurations/Base.xcconfig:
3967         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
3968         * MiniBrowser/Configurations/Base.xcconfig:
3969         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3970         * MobileMiniBrowser/Configurations/Base.xcconfig:
3971         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
3972         * Scripts/webkitpy/style/checker.py:
3973         (_all_categories):
3974         (FileType):
3975         (CheckerDispatcher._file_type):
3976         (CheckerDispatcher._create_checker):
3977         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
3978         (SDKVariantChecker):
3979         (SDKVariantChecker.__init__):
3980         (SDKVariantChecker.check):
3981         * TestWebKitAPI/Configurations/Base.xcconfig:
3982         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
3983         * WebEditingTester/Configurations/Base.xcconfig:
3984         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
3985         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
3986         * WebKitTestRunner/Configurations/Base.xcconfig:
3987         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
3988         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
3989         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
3990
3991 2019-01-17  Zalan Bujtas  <zalan@apple.com>
3992
3993         [LFC][BFC] An element with transform is a containing block for positioned descendants.
3994         https://bugs.webkit.org/show_bug.cgi?id=193534
3995
3996         Reviewed by Antti Koivisto.
3997
3998         * LayoutReloaded/misc/LFC-passing-tests.txt:
3999
4000 2019-01-17  Zalan Bujtas  <zalan@apple.com>
4001
4002         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
4003         https://bugs.webkit.org/show_bug.cgi?id=193528
4004
4005         Reviewed by Antti Koivisto.
4006
4007         * LayoutReloaded/misc/LFC-passing-tests.txt:
4008
4009 2019-01-17  Zalan Bujtas  <zalan@apple.com>
4010
4011         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
4012         https://bugs.webkit.org/show_bug.cgi?id=193520
4013
4014         Reviewed by Antti Koivisto.
4015
4016         * LayoutReloaded/misc/LFC-passing-tests.txt:
4017
4018 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
4019
4020         [ews-build] unapply-patch step should not update source
4021         https://bugs.webkit.org/show_bug.cgi?id=193234
4022
4023         Reviewed by Lucas Forschler.
4024
4025         * BuildSlaveSupport/ews-build/steps.py:
4026         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
4027         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
4028
4029 2019-01-16  Youenn Fablet  <youenn@apple.com>
4030
4031         Add a new SPI for controlling getUserMedia
4032         https://bugs.webkit.org/show_bug.cgi?id=192793
4033
4034         Reviewed by Eric Carlson.
4035
4036         * MiniBrowser/mac/WK2BrowserWindowController.m:
4037         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
4038         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
4039         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
4040         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
4041         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
4042         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
4043         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
4044         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
4045         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
4046         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
4047         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
4048         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
4049         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
4050         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
4051
4052 2019-01-16  Zalan Bujtas  <zalan@apple.com>
4053
4054         [LFC][BFC] Inflow non-replaced used width should not be negative.
4055         https://bugs.webkit.org/show_bug.cgi?id=193495
4056
4057         Reviewed by Antti Koivisto.
4058
4059         * LayoutReloaded/misc/LFC-passing-tests.txt:
4060
4061 2019-01-16  Chris Dumez  <cdumez@apple.com>
4062
4063         Regression(PSON) View becomes blank after click a cross-site download link
4064         https://bugs.webkit.org/show_bug.cgi?id=193361
4065         <rdar://problem/47099573>
4066
4067         Reviewed by Geoffrey Garen.
4068
4069         Add API test coverage.
4070
4071         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4072         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
4073
4074 2019-01-16  Zalan Bujtas  <zalan@apple.com>
4075
4076         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
4077         https://bugs.webkit.org/show_bug.cgi?id=193470
4078
4079         Reviewed by Antti Koivisto.
4080
4081         * LayoutReloaded/misc/LFC-passing-tests.txt:
4082
4083 2019-01-16  Zalan Bujtas  <zalan@apple.com>
4084
4085         [LFC] Adjust margin box verification.
4086         https://bugs.webkit.org/show_bug.cgi?id=193482
4087
4088         Reviewed by Antti Koivisto.
4089
4090         * LayoutReloaded/misc/LFC-passing-tests.txt:
4091
4092 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
4093
4094         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
4095         https://bugs.webkit.org/show_bug.cgi?id=193451
4096
4097         Reviewed by Geoffrey Garen.
4098
4099         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
4100         (TEST):
4101         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
4102         (runWebsiteDataStoreCustomPaths):
4103
4104 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
4105
4106         webkitpy: Support boolean simctl isAvailable
4107         https://bugs.webkit.org/show_bug.cgi?id=193472
4108         <rdar://problem/47296150>
4109
4110         Reviewed by Ryosuke Niwa.
4111
4112         * Scripts/webkitpy/xcode/simulated_device.py:
4113         (SimulatedDeviceManager._create_runtimes):
4114         (SimulatedDeviceManager._create_device_with_runtime):
4115
4116 2019-01-15  Chris Dumez  <cdumez@apple.com>
4117
4118         Unreviewed, rolling out r239993, r239995, r239997, and
4119         r239999.
4120
4121         Caused assertions under
4122         ViewGestureController::disconnectFromProcess()
4123
4124         Reverted changesets:
4125
4126         "Regression(PSON) View becomes blank after click a cross-site
4127         download link"
4128         https://bugs.webkit.org/show_bug.cgi?id=193361
4129         https://trac.webkit.org/changeset/239993
4130
4131         "Unreviewed iOS build fix after r239993."
4132         https://trac.webkit.org/changeset/239995
4133
4134         "Fix iOS build after r239993"
4135         https://bugs.webkit.org/show_bug.cgi?id=193361
4136         https://trac.webkit.org/changeset/239997
4137
4138         "Unreviewed, revert part of r239997 as it is not needed to fix
4139         the build."
4140         https://trac.webkit.org/changeset/239999
4141
4142 2019-01-15  Tim Horton  <timothy_horton@apple.com>
4143
4144         Cannot tab out of WKWebView on macOS
4145         https://bugs.webkit.org/show_bug.cgi?id=161448
4146         <rdar://problem/28100085>
4147
4148         Reviewed by Dean Jackson.
4149
4150         Add a test that tabbing into and out of WKWebView works correctly.
4151
4152         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4153         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
4154         (WebKit2_CommandBackForwardTest::SetUp):
4155         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
4156         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
4157         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
4158         (-[FocusableView canBecomeKeyView]):
4159         (TEST):
4160         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
4161         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
4162         (-[OffscreenWindow initWithSize:]):
4163         (-[OffscreenWindow isKeyWindow]):
4164         (-[OffscreenWindow isVisible]):
4165         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
4166         (TestWebKitAPI::PlatformWebView::initialize):
4167         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
4168         (-[ActiveOffscreenWindow isVisible]): Deleted.
4169         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
4170
4171 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
4172
4173         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
4174         https://bugs.webkit.org/show_bug.cgi?id=193459
4175
4176         Reviewed by Mark Lam.
4177
4178         * BuildSlaveSupport/build.webkit.org-config/steps.py:
4179         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
4180
4181 2019-01-15  Chris Dumez  <cdumez@apple.com>
4182
4183         Regression(PSON) View becomes blank after click a cross-site download link
4184         https://bugs.webkit.org/show_bug.cgi?id=193361
4185         <rdar://problem/47099573>
4186
4187         Reviewed by Geoff Garen.
4188
4189         Add API test coverage.
4190
4191         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4192         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
4193
4194 2019-01-15  Zalan Bujtas  <zalan@apple.com>
4195
4196         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
4197         https://bugs.webkit.org/show_bug.cgi?id=193448
4198
4199         Reviewed by Antti Koivisto.
4200
4201         * LayoutReloaded/misc/LFC-passing-tests.txt:
4202
4203 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
4204
4205         webkitpy: Implement device type specific expected results (Part 1)
4206         https://bugs.webkit.org/show_bug.cgi?id=192162
4207
4208         Reviewed by Lucas Forschler.
4209
4210         Device type specific expected results covers two related ideas. The first (covered by this change)
4211         is where to search for -expected.* files. The second is which tests to run based on the
4212         TestExpectations.txt file.
4213
4214         After this change, the baseline search path will be determined by the type of device running a
4215         test. Device type will be passed into any function which picks a file based on the baseline search
4216         path.
4217
4218         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
4219         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
4220         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4221         (Manager.run): Print baseline search path for each round of devices.
4222         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
4223         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
4224         (SingleTestRunner._expected_driver_output): Ditto.
4225         (SingleTestRunner._driver_input): Ditto.
4226         * Scripts/webkitpy/layout_tests/views/printing.py:
4227         (Printer.print_config): Move printing of baseline search path to a separate function.
4228         (Printer.print_baseline_search_path): Moved from Printer.print_config.
4229         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
4230         (Testprinter.test_print_config):
4231         (Testprinter.test_print_baseline_search_path):
4232         * Scripts/webkitpy/port/base.py:
4233         (Port.baseline_search_path): Pass device_type through.
4234         (Port._expected_baselines_for_suffixes): Ditto.
4235         (Port.expected_baselines): Ditto.
4236         (Port.expected_filename): Ditto.
4237         (Port.expected_checksum): Ditto.
4238         (Port.expected_image): Ditto.
4239         (Port.expected_audio): Ditto.
4240         (Port.expected_text): Ditto.
4241         (Port.reference_files): Ditto.
4242         (Port.tests): Ditto.
4243         (Port._expanded_paths): Ditto.
4244         (Port.skipped_layout_tests): Ditto.
4245         (Port.expectations_dict): Ditto.
4246         (Port._port_specific_expectations_files): Ditto.
4247         (Port.expectations_files): Ditto.
4248         (Port.test_search_path): Ditto.
4249         (Port._tests_for_other_platforms): Ditto.
4250         * Scripts/webkitpy/port/base_unittest.py:
4251         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
4252         (PortTest.test_nonexistant_expectations): Ditto.
4253         (test_ref_tests_platform_directory): Ditto.
4254         * Scripts/webkitpy/port/darwin.py:
4255         (DarwinPort._port_specific_expectations_files): Accept device_type.
4256         * Scripts/webkitpy/port/driver.py:
4257         (DriverProxy):
4258         (DriverProxy.host): Expose _target_host for device_type information.
4259         * Scripts/webkitpy/port/gtk.py:
4260         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
4261         * Scripts/webkitpy/port/ios.py:
4262         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
4263         * Scripts/webkitpy/port/mac.py:
4264         (MacPort. default_baseline_search_path): Ditto.
4265         * Scripts/webkitpy/port/port_testcase.py:
4266         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
4267         * Scripts/webkitpy/port/test.py:
4268         * Scripts/webkitpy/port/watch.py:
4269         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
4270         * Scripts/webkitpy/port/win.py:
4271         (WinPort.test_search_path): Accept, but do not use, device_type.
4272         * Scripts/webkitpy/port/wpe.py:
4273         (WPEPort._port_specific_expectations_files): Ditto.
4274         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
4275         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
4276
4277 2019-01-15  Zalan Bujtas  <zalan@apple.com>
4278
4279         [LFC] Use the containing block's padding box to position out-of-flow elements.
4280         https://bugs.webkit.org/show_bug.cgi?id=193431
4281
4282         Reviewed by Antti Koivisto.
4283
4284         * LayoutReloaded/misc/LFC-passing-tests.txt:
4285
4286 2019-01-14  Tim Horton  <timothy_horton@apple.com>
4287
4288         Move a test implementation file that got misplaced in the Xcode project
4289
4290         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4291
4292 2019-01-14  Commit Queue  <commit-queue@webkit.org>
4293
4294         Unreviewed, rolling out r239901, r239909, r239910, r239912,
4295         r239913, and r239914.
4296         https://bugs.webkit.org/show_bug.cgi?id=193407
4297
4298         These revisions caused an internal failure (Requested by
4299         Truitt on #webkit).
4300
4301         Reverted changesets:
4302
4303         "[Cocoa] Avoid importing directly from subumbrella frameworks"
4304         https://bugs.webkit.org/show_bug.cgi?id=186016
4305         https://trac.webkit.org/changeset/239901
4306
4307         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
4308         https://trac.webkit.org/changeset/239909
4309
4310         "Tried to fix the build."
4311         https://trac.webkit.org/changeset/239910
4312
4313         "Fixed iOS builds after r239910."
4314         https://trac.webkit.org/changeset/239912
4315
4316         "More build fixing."
4317         https://trac.webkit.org/changeset/239913
4318
4319         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
4320         https://trac.webkit.org/changeset/239914
4321
4322 2019-01-14  Mark Lam  <mark.lam@apple.com>
4323
4324         Re-enable ability to build --cloop builds.
4325         https://bugs.webkit.org/show_bug.cgi?id=192955
4326         <rdar://problem/46882363>
4327
4328         Reviewed by Saam barati and Keith Miller.
4329
4330         The --cloop build option was being ignored this whole time since r236381.
4331         This patch makes it possible to build CLoop builds again.
4332
4333         * Scripts/build-jsc:
4334         * Scripts/webkitperl/FeatureList.pm:
4335         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4336
4337 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
4338
4339         webkitpy: Expose device_type from host-like objects
4340         https://bugs.webkit.org/show_bug.cgi?id=193406
4341         <rdar://problem/47262305>
4342
4343         Reviewed by Lucas Forschler.
4344
4345         Devices should expose device_type. As a result, all host objects should
4346         provide a device_type property, even if they do not yet define a device_type.
4347
4348         * Scripts/webkitpy/common/system/systemhost.py:
4349         (SystemHost):
4350         (SystemHost.device_type):
4351         * Scripts/webkitpy/common/system/systemhost_mock.py:
4352         (MockSystemHost):
4353         (MockSystemHost.device_type):
4354         * Scripts/webkitpy/port/device.py:
4355         (Device):
4356         (Device.device_type):
4357         * Scripts/webkitpy/xcode/simulated_device.py:
4358         (SimulatedDeviceManager._find_exisiting_device_for_request):