Unreviewed, rolling out r94635.
[WebKit-https.git] / Tools / ChangeLog
1 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
2
3         Unreviewed, rolling out r94635.
4         http://trac.webkit.org/changeset/94635
5         https://bugs.webkit.org/show_bug.cgi?id=67704
6
7         Linux Touch build is failing to compile this change.
8         (Requested by loislo on #webkit).
9
10         * DumpRenderTree/chromium/EventSender.cpp:
11         (EventSender::sendCurrentTouchEvent):
12
13 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
14
15         Unreviewed, rolling out r94655.
16         http://trac.webkit.org/changeset/94655
17         https://bugs.webkit.org/show_bug.cgi?id=67703
18
19         It broke Leopard debug bot (Requested by ossy on #webkit).
20
21         * Scripts/webkitdirs.pm:
22
23 2011-09-07  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
24
25         REGRESSION(r94288) build-webkit doesn't work on Windows
26         https://bugs.webkit.org/show_bug.cgi?id=67646
27
28         Reviewed by Csaba Osztrogonác.
29
30         * Scripts/webkitdirs.pm:
31
32 2011-09-06  Eric Boren  <borenet@gmail.com>
33
34         [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
35         https://bugs.webkit.org/show_bug.cgi?id=66800
36
37         Reviewed by Darin Fisher.
38
39         * DumpRenderTree/chromium/EventSender.cpp:
40         (EventSender::sendCurrentTouchEvent):
41
42 2011-09-06  Adam Barth  <abarth@webkit.org>
43
44         garden-o-matic details view should having working rebaseline and next/previous buttons
45         https://bugs.webkit.org/show_bug.cgi?id=67659
46
47         Reviewed by Dimitri Glazkov.
48
49         This patch wires up basic back/forward buttons that let you traverse
50         through the results we're examining in the details view.  This ended up
51         being more code than I expected, but I wanted to keep all the state
52         information in the DOM itself.
53
54         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
55         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
56         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
57
58 2011-09-01  Dirk Pranke  <dpranke@chromium.org>
59
60         fix MockFileSystem.glob(), refactor filesystem tests
61         https://bugs.webkit.org/show_bug.cgi?id=67462
62
63         Reviewed by Eric Seidel.
64
65         In debugging why my proposed change for MockFileSystem.glob()
66         in bug 66228 didn't work, I stumbled across two real bugs
67         that cancelled each other out for the unit tests. I fixed those
68         (glob shouldn't recurse into subdirs, and we weren't populating
69         self.dirs from self.files properly).
70
71         I have also created a "mixin" class for tests that can be shared
72         between the real filesystem and the mock filesystem - MockFileSystem
73         is being used enough it needs its own tests.
74
75         * Scripts/webkitpy/common/system/filesystem_mock.py:
76         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py: Added.
77         * Scripts/webkitpy/common/system/filesystem_unittest.py:
78
79 2011-09-06  Anders Carlsson  <andersca@apple.com>
80
81         Move NPAPI headers in bridge to plugins
82         https://bugs.webkit.org/show_bug.cgi?id=67661
83
84         Update forwarding headers.
85
86         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
87         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
88
89 2011-09-06  Tony Chang  <tony@chromium.org>
90
91         [chromium] Check in 'build' for compiled binaries first
92         https://bugs.webkit.org/show_bug.cgi?id=67549
93
94         Reviewed by Dirk Pranke.
95
96         I'm working on moving the windows build output to a common location
97         rather than relative to the sln file.  Because of that, we need to
98         check those build locations first for DumpRenderTree.exe.
99
100         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
101
102 2011-09-06  Adam Barth  <abarth@webkit.org>
103
104         Use a hierarchial structure for the garden-o-matic results view
105         https://bugs.webkit.org/show_bug.cgi?id=67620
106
107         Reviewed by Dimitri Glazkov.
108
109         This patch re-organizes the results view to use a hierachial structure
110         for selection.  At the top-level are sections for each test.  Expanding
111         the test section shows a tab selector for builders.
112
113         This structure prepares us for wiring up various actions to this view.
114
115         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
116         (.):
117         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
118         ():
119         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
120         (.):
121         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
122         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
123         (.results-view>.toolbar):
124         (.results-view>.toolbar ul.actions):
125         (.results-view>.toolbar ul.actions li):
126         (.results-grid table):
127         (.results-grid table td, .results-view table th):
128         (.results-grid table th):
129         (.results-grid .text-result):
130         (.results-grid .image-result):
131
132 2011-09-06  Adam Barth  <abarth@webkit.org>
133
134         garden-o-matic's base.probe generates spam in the JavaScript console
135         https://bugs.webkit.org/show_bug.cgi?id=67622
136
137         Reviewed by Dimitri Glazkov.
138
139         Now that we have CORS set up on the buildbot, we can use XMLHttpRequest
140         instead of HTMLScriptElement to test whether results exist.  This
141         reduces the console.log spam and saves bandwidth because we can use a
142         HEAD request instead of a GET request.
143
144         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
145
146 2011-09-05  Adam Barth  <abarth@webkit.org>
147
148         Add a tab to garden-o-matic for viewing expected failures
149         https://bugs.webkit.org/show_bug.cgi?id=67619
150
151         Reviewed by Dimitri Glazkov.
152
153         This patch adds a basic tab to garden-o-matic that shows all the tests
154         failing on the bots, including the expected failures.  This patch
155         mostly involves refactoring existing classes to allow new subclasses.
156
157         This view is useful for when gardeners mark tests as expected to fail
158         and then rebaseline them later.
159
160         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
161         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
162         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
163         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:
164         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
165         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
166         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
167
168 2011-09-05  Adam Barth  <abarth@webkit.org>
169
170         Fix global variable leak in garden-o-matic
171         https://bugs.webkit.org/show_bug.cgi?id=67617
172
173         Reviewed by Dimitri Glazkov.
174
175         Caught by running the unit tests with noglobals turned on.
176
177         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
178
179 2011-09-05  Balazs Kelemen  <kbalazs@webkit.org>
180
181         [Qt][WK2] Add pixel test support
182         https://bugs.webkit.org/show_bug.cgi?id=66283
183
184         Reviewed by Andreas Kling.
185
186         Implemented pixel result generation by reusing the logic
187         that we have in DumpRenderTree.
188         * WebKitTestRunner/qt/TestInvocationQt.cpp:
189         (WTR::dumpImage):
190         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
191
192 2011-09-04  Robin Dunn  <robin@alldunn.com>
193
194         [wx] Enable wxWebKit to run using the wxGC Cairo backend on platforms other than GTK.
195         https://bugs.webkit.org/show_bug.cgi?id=67577
196
197         Reviewed by Kevin Ollivier.
198
199         * waf/build/settings.py:
200
201 2011-09-03  Kevin Ollivier  <kevino@theolliviers.com>
202
203         [wx] Unreviewed build fix. Add wtf/dtoa directory to build.
204
205         * waf/build/settings.py:
206
207 2011-09-03  Dan Bernstein  <mitz@apple.com>
208
209         32-bit build fix.
210
211         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
212         (TestWebKitAPI::Util::toSTD):
213
214 2011-09-03  Dan Bernstein  <mitz@apple.com>
215
216         Move testStringByEvaluatingJavaScriptFromString() from DumpRenderTree to TestWebKitAPI
217         https://bugs.webkit.org/show_bug.cgi?id=67559
218
219         Reviewed by Darin Adler.
220
221         * DumpRenderTree/mac/DumpRenderTree.mm:
222         (dumpRenderTree): Moved testStringByEvaluatingJavaScriptFromString() from here and removed
223         the call to it.
224         * TestWebKitAPI/PlatformUtilities.h: Declared Util::toSTD(NSString *)
225         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringByEvaluatingJavaScriptFromString.mm.
226         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm: Added.
227         (TestWebKitAPI::TEST): Added. Moved testStringByEvaluatingJavaScriptFromString() to here.
228         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
229         (TestWebKitAPI::Util::toSTD): Added.
230
231 2011-09-03  Adam Barth  <abarth@webkit.org>
232
233         garden-o-matic results view should have a better results selector
234         https://bugs.webkit.org/show_bug.cgi?id=67542
235
236         Reviewed by Dimitri Glazkov.
237
238         This patch adds a basic grid-based results selector to the results
239         view.  Currently, this grid just shows how the tests fail on the
240         various bots.  A future patch will let you select which failure to view
241         and to mark the failures for rebaselining.
242
243         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
244         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
245           - Add some more basic functions for manipulating dictionaries.
246         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
247         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
248         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
249
250 2011-09-03  Adam Barth  <abarth@webkit.org>
251
252         garden-o-matic results view should show Actual and Expected results for text failures
253         https://bugs.webkit.org/show_bug.cgi?id=67536
254
255         Reviewed by Eric Seidel.
256
257         In the past, we didn't show actual and expected text results (we just
258         showed the diff) because we didn't have the awesome six-by-two results
259         grid.  Now that we do, we can move show these results.
260
261         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
262         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
263           - Fixed some typos that were preventing these unit tests from running.
264         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
265         (.):
266         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
267           - Report -actual.txt and -expected.txt as possible results URLs.
268
269 2011-09-03  Adam Barth  <abarth@webkit.org>
270
271         garden-o-matic shows "ghost" failures that are already fixed
272         https://bugs.webkit.org/show_bug.cgi?id=67535
273
274         Reviewed by Eric Seidel.
275
276         About 10% of writes fail to stick on test-results.appspot.com.  This
277         patch causes us to fetch the full_results.json blob directly from
278         build.chromium.org rather than relying upon AppEngine.
279
280         Unforuntately, we still need to get historical information from
281         AppEngine.  That will take several patches to fix becuase I need to
282         change the bots to write the full_results.json file to the
283         build-specific directory in addition to the zip file.
284
285         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
286         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
287         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
288
289 2011-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>
290
291         Unreviewed, rolling out r94458.
292         http://trac.webkit.org/changeset/94458
293         https://bugs.webkit.org/show_bug.cgi?id=67558
294
295         Caused appcache test to fail on various bots (Requested by
296         rniwa on #webkit).
297
298         * Scripts/webkitpy/layout_tests/port/webkit.py:
299         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
300
301 2011-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>
302
303         Unreviewed, rolling out r94453.
304         http://trac.webkit.org/changeset/94453
305         https://bugs.webkit.org/show_bug.cgi?id=67557
306
307         Caused appcache test to fail on various bots (Requested by
308         rniwa on #webkit).
309
310         * Scripts/webkitpy/layout_tests/port/webkit.py:
311
312 2011-09-02  Michael Saboff  <msaboff@apple.com>
313
314         Add JSC:RegExp functional tests
315         https://bugs.webkit.org/show_bug.cgi?id=67339
316
317         New perl script to build JavaScriptCore and run the RegExp tests.
318
319         Reviewed by Gavin Barraclough.
320
321         * Scripts/run-regexp-tests: Added.
322
323 2011-09-02  Michael Saboff  <msaboff@apple.com>
324
325         Add JSC:RegExp functional tests
326         https://bugs.webkit.org/show_bug.cgi?id=67339
327
328         New perl script to build JavaScriptCore and run the RegExp tests.
329
330         Reviewed by Gavin Barraclough.
331
332         * Scripts/run-regexp-tests: Added.
333
334 2011-09-02  Eric Seidel  <eric@webkit.org>
335
336         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
337         https://bugs.webkit.org/show_bug.cgi?id=67530
338
339         Unreviewed.  Fixing typo from previous commit.
340
341         Turns out there was *no* unittesting of WebKitDriver.  Added a basic test of _read_block
342         which exercises the code I previously made a typo in.
343
344         * Scripts/webkitpy/layout_tests/port/webkit.py:
345         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
346
347 2011-09-02  Eric Seidel  <eric@webkit.org>
348
349         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
350         https://bugs.webkit.org/show_bug.cgi?id=67530
351
352         Reviewed by Adam Barth.
353
354         No functional change, just reshuffling code.
355
356         * Scripts/webkitpy/layout_tests/port/webkit.py:
357
358 2011-09-02  Darin Adler  <darin@apple.com>
359
360         Added Subversion ignore for .pyc generated files.
361
362         * Scripts/webkitpy/layout_tests/models: Added property svn:ignore.
363         * Scripts/webkitpy/layout_tests/servers: Added property svn:ignore.
364         * Scripts/webkitpy/tool/servers: Added property svn:ignore.
365
366 2011-09-02  Adam Barth  <abarth@webkit.org>
367
368         Enable testing on mac-ews
369         https://bugs.webkit.org/show_bug.cgi?id=67505
370
371         Reviewed by Eric Seidel.
372
373         This patch enables testing on the Mac EWS, which should help
374         contributors not turn the Mac bots red.
375
376         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
377
378 2011-09-01  Beth Dakin  <bdakin@apple.com>
379
380         https://bugs.webkit.org/show_bug.cgi?id=67451
381         Add a test for going back to a cached page after changing the device scale factor
382
383         Reviewed by Adam Roben.
384
385         New test DeviceScaleFactorOnBack.mm inherits from WebKitAgnosticTest.
386         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
387         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm: Added.
388         (TestWebKitAPI::DeviceScaleFactorOnBack::url):
389         (TestWebKitAPI::DeviceScaleFactorOnBack::didLoadURL):
390         (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
391         (TestWebKitAPI::DeviceScaleFactorOnBack::initializeView):
392         (TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
393         (TestWebKitAPI::TEST_F):
394
395         Added new function to WebKitAgnosticTest to goBack. Separated 
396         waitForLoadToFinish() into its own function (instead of being a part of 
397         loadAndWaitUntilFinished()) so that it can be called from goBack as 
398         well. Also added initializeView() so we can set the cache model.
399         * TestWebKitAPI/mac/WebKitAgnosticTest.h:
400         (TestWebKitAPI::WebKitAgnosticTest::initializeView):
401         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
402         (TestWebKitAPI::WebKitAgnosticTest::WebKitAgnosticTest):
403         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
404         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
405         (TestWebKitAPI::WebKitAgnosticTest::loadURL):
406         (TestWebKitAPI::WebKitAgnosticTest::goBack):
407         (TestWebKitAPI::WebKitAgnosticTest::waitForLoadToFinish):
408
409 2011-09-02  Anders Carlsson  <andersca@apple.com>
410
411         Build fix.
412
413         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp:
414         (PrivateBrowsing::ScriptableObject::pluginTest):
415
416 2011-09-02  Anders Carlsson  <andersca@apple.com>
417
418         Move private browsing test to a PluginTest subclass
419         https://bugs.webkit.org/show_bug.cgi?id=67498
420
421         Reviewed by Darin Adler.
422
423         * DumpRenderTree/DumpRenderTree.gypi:
424         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
425         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
426         (pluginGetProperty):
427         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
428         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
429         (PluginTest::NPP_SetValue):
430         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
431         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp: Added.
432         (PrivateBrowsing::PrivateBrowsing):
433         (PrivateBrowsing::privateBrowsingEnabled):
434         (PrivateBrowsing::cachedPrivateBrowsingEnabled):
435         (PrivateBrowsing::ScriptableObject::hasProperty):
436         (PrivateBrowsing::ScriptableObject::getProperty):
437         (PrivateBrowsing::ScriptableObject::pluginTest):
438         (PrivateBrowsing::NPP_New):
439         (PrivateBrowsing::NPP_GetValue):
440         (PrivateBrowsing::NPP_SetValue):
441         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
442         (NPP_New):
443         (NPP_SetValue):
444         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
445         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
446         * GNUmakefile.am:
447
448 2011-09-02  Csaba Osztrogonác  <ossy@webkit.org>
449
450         [Qt] Build dependency problems
451         https://bugs.webkit.org/show_bug.cgi?id=38054
452
453         Trivial fix after r94288.
454
455         Rubber-stamped by Andras Becsi.
456
457         * Scripts/webkitdirs.pm: We should read the whole defaults.txt, not only the first two lines.
458         (buildQMakeProject):
459
460 2011-09-02  Andras Becsi  <andras.becsi@nokia.com>
461
462         Remove my old e-mail address and add my new one.
463
464         Rubber-stamped by Tor Arne Vestbø.
465
466         * Scripts/webkitpy/common/config/committers.py:
467
468 2011-09-02  Philippe Normand  <pnormand@igalia.com>
469
470         [GTK] run-gtk-tests leaves a zombie Xvfb process
471         https://bugs.webkit.org/show_bug.cgi?id=67389
472
473         Reviewed by Martin Robinson.
474
475         * Scripts/run-gtk-tests: Properly close STDIN and STDERR on the
476         child process instead of doing shell redirection.
477
478 2011-09-01  Mark Rowe  <mrowe@apple.com>
479
480         Fix the build by adding some more missing return types.
481
482         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
483         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
484
485 2011-09-01  Eric Seidel  <eric@webkit.org>
486
487         REGRESSION (NRWT): Leaks Viewer can't load leaks from test runs that used NRWT
488         https://bugs.webkit.org/show_bug.cgi?id=66228
489
490         Reviewed by Dirk Pranke.
491
492         ORWT used $(PROCESS)$(NUMBER)-leaks.txt for leaks filenames.
493         The LeaksViewer tool globs for all *-leaks.txt files.
494         This patch makes NRWT output $(PROCESS)-$(PID)-leaks.txt which should match.
495
496         In order to test this I had to fix a limitation in our MockFileSystem.glob
497         method.  However, doing so uncovered a typo and bug in the integration tests.
498         I've disabled the offending integration tests.
499
500         * Scripts/webkitpy/common/system/filesystem_mock.py:
501         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
502         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
503
504 2011-09-01  Dominic Mazzoni  <dmazzoni@google.com>
505
506         Adds a LayoutTestController method to make it possible to test
507         starting speech input via an API call.
508         https://bugs.webkit.org/show_bug.cgi?id=60170
509
510         Reviewed by Dimitri Glazkov.
511
512         * DumpRenderTree/LayoutTestController.h:
513         * DumpRenderTree/chromium/LayoutTestController.cpp:
514         (LayoutTestController::LayoutTestController):
515         (LayoutTestController::startSpeechInput):
516         * DumpRenderTree/chromium/LayoutTestController.h:
517         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
518         (LayoutTestController::startSpeechInput):
519         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
520         (LayoutTestController::startSpeechInput):
521         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
522         (LayoutTestController::startSpeechInput):
523         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
524         (LayoutTestController::startSpeechInput):
525         * DumpRenderTree/qt/LayoutTestControllerQt.h:
526         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
527         (LayoutTestController::startSpeechInput):
528         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
529         (LayoutTestController::startSpeechInput):
530
531 2011-09-01  Tim Horton  <hortont424@gmail.com>
532
533         Fix TestWebKitAPI build on clang-2.0
534
535         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
536
537 2011-09-01  Adam Barth  <abarth@webkit.org>
538
539         Remove unused "extension" parameter from rebaseline gardeningserver handler
540         https://bugs.webkit.org/show_bug.cgi?id=67384
541
542         Reviewed by James Robinson.
543
544         This parameter hasn't done anything in a while.
545
546         * Scripts/webkitpy/tool/commands/rebaseline.py:
547         * Scripts/webkitpy/tool/servers/gardeningserver.py:
548         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
549
550 2011-09-01  Eric Seidel  <eric@webkit.org>
551
552         Unreviewed.
553
554         Fix a typo in unittests.  Unfortunately fixing it
555         caused several assertions.  Just disabling the test
556         instead, since it was providing no value before due to the typo.
557
558         * Scripts/webkitpy/layout_tests/port/test.py:
559
560 2011-09-01  Adam Barth  <abarth@webkit.org>
561
562         Add a "rebaseline" button to the garden-o-matic summary page
563         https://bugs.webkit.org/show_bug.cgi?id=67382
564
565         Reviewed by Dimitri Glazkov.
566
567         As much as we might wish folks to not rebaseline entire test groups at
568         once, the truth is that doing so is a common operation.  Adding a
569         button for this operation is likely to make folks happy.
570
571         This patch also cleans up a bunch of plumbing surrounding failureInfo
572         objects.
573
574         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
575         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
576         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
577         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
578         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
579         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
580         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
581         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
582         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
583         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
584
585 2011-09-01  Adam Barth  <abarth@webkit.org>
586
587         garden-o-matic should let the gardener assign blame for a group of test failures
588         https://bugs.webkit.org/show_bug.cgi?id=67379
589
590         Reviewed by Dimitri Glazkov.
591
592         If a group of test failures has a large revision range, the gardener
593         might wish to blame a specific revision for the failure.  Currently,
594         this only effect of assigning blame in this way is to hide the other
595         suspect commits.
596
597         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
598         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
599         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
600
601 2011-09-01  Adam Barth  <abarth@webkit.org>
602
603         Hide garden-o-matic failure table until hover
604         https://bugs.webkit.org/show_bug.cgi?id=67376
605
606         Reviewed by Dimitri Glazkov.
607
608         This patch removes the failure table for build failures (because it
609         does not make sense) and hides the failure table for test groups until
610         the user hovers over the test failure block, reducing visual noise.
611
612         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
613         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
614         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
615
616 2011-09-01  Adam Barth  <abarth@webkit.org>
617
618         Switch garden-o-matic from commitData.title to commitData.summary
619         https://bugs.webkit.org/show_bug.cgi?id=67375
620
621         Reviewed by Dimitri Glazkov.
622
623         commitData.title is a string provided by Trac, which isn't great in all
624         cases.  commitData.summary is my attempt to find the most important
625         one-line summary of the commit.  This patch switches garden-o-matic
626         over to summary.
627
628         Also, this patch tweaks a bunch of CSS to tighten up the summary page
629         and reduce visual noise.
630
631         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
632         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
633         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
634
635 2011-09-01  Adam Barth  <abarth@webkit.org>
636
637         Group failing tests in garden-o-matic if there are more than three in a folder
638         https://bugs.webkit.org/show_bug.cgi?id=67373
639
640         Reviewed by Dimitri Glazkov.
641
642         Sometimes a failure will cause many tests in a given directory to fail.
643         When that happens, it's better to list the directory as a single item
644         (with a count) rather than spamming all the test names.
645
646         (This patch also updates a bunch of unit test expected results after my last commit.)
647
648         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
649         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
650         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
651         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
652         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
653
654 2011-09-01  Adam Barth  <abarth@webkit.org>
655
656         Lower the visual noise from the failing builders display
657         https://bugs.webkit.org/show_bug.cgi?id=67369
658
659         Reviewed by Dimitri Glazkov.
660
661         This patch ensures that the "Building" row in the failing builders
662         display is always last and dims it by 50% to reduce visual noise.  This
663         lets the gardener focus on the actual failures.
664
665         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
666         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
667         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css: Added.
668
669 2011-09-01  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
670
671         [Qt] Build dependency problems
672         https://bugs.webkit.org/show_bug.cgi?id=38054
673
674         Make clean build after the defines are changed.
675
676         Reviewed by Csaba Osztrogonác.
677
678         * Scripts/webkitdirs.pm:
679         (buildQMakeProject):
680
681 2011-08-31  Adam Barth  <abarth@webkit.org>
682
683         Move DumpRenderTree to WebKitPlatformSupport
684         https://bugs.webkit.org/show_bug.cgi?id=67331
685
686         Reviewed by Darin Fisher.
687
688         This patch update DumpRenderTree to account for the WebKitClient =>
689         WebKitPlatformSupport rename.
690
691         * DumpRenderTree/chromium/NotificationPresenter.cpp:
692         (NotificationPresenter::show):
693         * DumpRenderTree/chromium/Task.cpp:
694         (postTask):
695
696 2011-08-31  Eric Seidel  <eric@webkit.org>
697
698         Add queues.webkit.org/active-bots page to make it easy to see which bots are down
699         https://bugs.webkit.org/show_bug.cgi?id=67314
700
701         Reviewed by Adam Barth.
702
703         Very simple page.  Just lists all the bots, what queue they belong to and what we last heard from them.
704         If we haven't heard from a bot in the last 500 messages (last day or so), then it won't show up here.
705         This makes it very easy for me to see which of my cr-jail bots might be down at any one time.
706
707         I also moved a bunch of code into dashboard.css which belonged there.
708
709         * QueueStatusServer/handlers/activebots.py: Added.
710         * QueueStatusServer/main.py:
711         * QueueStatusServer/stylesheets/dashboard.css:
712         (.queue_bubble):
713         (.queue_name):
714         (.last_heard_from):
715         (.status_text):
716         (.alive):
717         (.behind):
718         (.dead):
719         * QueueStatusServer/templates/activebots.html: Added.
720         * QueueStatusServer/templates/dashboard.html:
721         * QueueStatusServer/templates/recentstatus.html:
722
723 2011-08-31  Oliver Hunt  <oliver@apple.com>
724
725         Move CheckedArithmeticOperations.cpp to the intended location
726
727         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
728         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp: Renamed from Tools/TestWebKitAPI/Tests/CheckedArithmeticOperations.cpp.
729
730 2011-08-31  Elliot Poger  <epoger@google.com>
731
732         add unittest to validate the complete set of Chromium configurations
733         https://bugs.webkit.org/show_bug.cgi?id=67211
734
735         Reviewed by Adam Barth.
736
737         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
738
739 2011-08-31  Nico Weber  <thakis@chromium.org>
740
741         Make ScrollAnimator(Chromium)?Mac check scrollAnimatorEnabled()
742         https://bugs.webkit.org/show_bug.cgi?id=67297
743
744         Reviewed by Tony Chang.
745
746         Explicitly disable smooth scrolling in chromium's DRT.
747
748         * DumpRenderTree/chromium/WebPreferences.cpp:
749         (WebPreferences::applyTo):
750
751 2011-08-31  Oliver Hunt  <oliver@apple.com>
752
753         Add Checked<> tests to windows build
754
755         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
756
757 2011-08-30  Oliver Hunt  <oliver@apple.com>
758
759         Add support for checked arithmetic
760         https://bugs.webkit.org/show_bug.cgi?id=67095
761
762         Reviewed by Sam Weinig.
763
764         Add test cases for Checked<>
765
766         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
767         * TestWebKitAPI/Tests/CheckedArithmeticOperations.cpp: Added.
768
769 2011-08-31  Adam Barth  <abarth@webkit.org>
770
771         Move summary.html to garden-o-matic.html.
772
773         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html.
774         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js.
775         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Removed.
776         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Removed.
777
778 2011-08-31  Noel Gordon  <noel.gordon@gmail.com>
779
780         [chromium] DRT linux should pass nativeKeyCode to plugins
781         https://bugs.webkit.org/show_bug.cgi?id=66679
782
783         Reviewed by Tony Chang.
784
785         * DumpRenderTree/chromium/EventSender.cpp:
786         (EventSender::keyDown):  Call a Chromium Linux GTK helper routine that returns the
787         (simulated) nativeKeyCode for the given input keyboard code.
788
789 2011-08-31  Adam Barth  <abarth@webkit.org>
790
791         Tighen up UI for garden-o-matic tab strip
792         https://bugs.webkit.org/show_bug.cgi?id=67266
793
794         Reviewed by Dimitri Glazkov.
795
796         This patch add CSS to move the tab strip to the edges of the page and
797         to remove some gratuitous border-radius.
798
799         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
800         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
801
802 2011-08-31  Adam Barth  <abarth@webkit.org>
803
804         garden-o-matic results view shouldn't be horrifically ugly
805         https://bugs.webkit.org/show_bug.cgi?id=67264
806
807         Reviewed by Dimitri Glazkov.
808
809         Minor tweak to the results view CSS to make it fit in better with the new tabbed UI.
810
811         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
812         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
813         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
814
815 2011-08-31  Adam Barth  <abarth@webkit.org>
816
817         garden-o-matic needs a tabstrip
818         https://bugs.webkit.org/show_bug.cgi?id=67263
819
820         Reviewed by Dimitri Glazkov.
821
822         This patch adds a basic tabstrip to garden-o-matic.  The results
823         details view now opens in the "Results" tab, and the user can flip back
824         and forth between the Summary and the Results tab quickly.  There's
825         also a stub for a "Commits" tab, which is disabled.
826
827         This patch isn't the most beautiful in the world, but it gets the ball
828         rolling on a multi-modal UI.
829
830         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
831         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
832         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
833         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
834         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
835
836 2011-08-31  Ai Makabi  <makabi@google.com>
837
838         Extract reference links from reftest test file.
839         https://bugs.webkit.org/show_bug.cgi?id=66838
840
841         Reviewed by Shinichiro Hamaji.
842
843         * Scripts/webkitpy/layout_tests/reftests/__init__.py: Added.
844         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link.py: Added.
845         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py: Added.
846
847 2011-08-03  Philippe Normand  <pnormand@igalia.com>
848
849         [webkitpy] missing log import in common/net/resultsjsonparser.py
850         https://bugs.webkit.org/show_bug.cgi?id=65606
851
852         Reviewed by Martin Robinson.
853
854         * Scripts/webkitpy/common/net/resultsjsonparser.py: Import the logging module.
855
856 2011-08-30  Philippe Normand  <pnormand@igalia.com>
857
858         [stylechecker] complains about NULL usage in some gst_structure_ calls
859         https://bugs.webkit.org/show_bug.cgi?id=67194
860
861         Reviewed by Martin Robinson.
862
863         Don't warn about NULL in some gst_structure_ calls. 0 can't be
864         used for these, a proper sentinel is required.
865
866         * Scripts/webkitpy/style/checkers/cpp.py:
867         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
868
869 2011-08-30  Adam Barth  <abarth@webkit.org>
870
871         Remove old-style UI from garden-o-matic
872         https://bugs.webkit.org/show_bug.cgi?id=67257
873
874         Reviewed by Dimitri Glazkov.
875
876         This code is nowhere near as awesome as the new hotness.  Let's remove
877         it so it doesn't weigh us down.
878
879         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Removed.
880         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Removed.
881         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
882         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
883         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js: Removed.
884         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html: Removed.
885
886 2011-08-30  Takashi Toyoshima  <toyoshim@chromium.org>
887
888         [WebSocket] update pywebsocket to 0.6b5.
889         https://bugs.webkit.org/show_bug.cgi?id=66924
890
891         Reviewed by Kent Tamura.
892
893         pywebsocket 0.6b2 supported minimum features of Hybi-08 specification.
894         Now, pywebsocket 0.6b5 supports full features of Hybi-10 specification.
895         0.6b3 or later supports a closing handshake handler and it is useful to
896         verify client's closing handshake implementation.
897         0.6b4 supports AbortedByUserException. It is useful to eliminate
898         unnecessary server warning messages on intended abnormal closures.
899         0.6b5 supports Python 2.5.1 or Mac 10.5.
900
901         * Scripts/webkitpy/thirdparty/__init__.py:
902         Update download URL and directory path.
903
904 2011-08-30  Dan Bernstein  <mitz@apple.com>
905
906         Test for <rdar://problem/9281695> Add text search API for getting the DOM range of a text match
907         https://bugs.webkit.org/show_bug.cgi?id=67230
908
909         Reviewed by Darin Adler.
910
911         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
912         * TestWebKitAPI/Tests/mac/DOMRangeOfString.html: Added.
913         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm: Added.
914         (-[DOMRangeOfStringFrameLoadDelegate webView:didFinishLoadForFrame:]):
915         (TestWebKitAPI::TEST):
916
917 2011-08-30  Aaron Colwell  <acolwell@chromium.org>
918
919         Add MediaSource API to HTMLMediaElement
920         https://bugs.webkit.org/show_bug.cgi?id=64731
921
922         Reviewed by Eric Carlson.
923
924         * Scripts/build-webkit:
925
926 2011-08-30  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
927
928         Emit last progress notification before calling dispatchDidFinishLoad
929         https://bugs.webkit.org/show_bug.cgi?id=28851
930
931         Reviewed by Adam Barth.
932
933         Implement dumpProgressFinishedCallback() in the layoutTestController for Qt,
934         Chromium and GTK ports. The first two were simple changes.
935
936         Some refactoring was needed in GTK port to assure that the dumps are emitted
937         correctly and the processing after the page load finished is in the right place.
938
939         To detect the load finished, we use the callback for the "load-status" notifier
940         signal of the top loading frame. And we use the deprecated "load-finished" signal
941         for dumping (if enabled) the progress finished expected output.
942
943         * DumpRenderTree/LayoutTestController.cpp:
944         (LayoutTestController::LayoutTestController):
945         (dumpProgressFinishedCallbackCallback):
946         (LayoutTestController::staticFunctions):
947         * DumpRenderTree/LayoutTestController.h:
948         (LayoutTestController::dumpProgressFinishedCallback):
949         (LayoutTestController::setDumpProgressFinishedCallback):
950         * DumpRenderTree/chromium/LayoutTestController.cpp:
951         (LayoutTestController::LayoutTestController):
952         (LayoutTestController::dumpProgressFinishedCallback):
953         (LayoutTestController::reset):
954         * DumpRenderTree/chromium/LayoutTestController.h:
955         (LayoutTestController::shouldDumpProgressFinishedCallback):
956         (LayoutTestController::setShouldDumpProgressFinishedCallback):
957         * DumpRenderTree/chromium/WebViewHost.cpp:
958         (WebViewHost::didStopLoading):
959         * DumpRenderTree/gtk/DumpRenderTree.cpp:
960         (webViewLoadFinished):
961         (topLoadingFrameLoadFinished):
962         (webFrameLoadStatusNotified):
963         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
964         (LayoutTestController::reset):
965         (LayoutTestController::dumpProgressFinishedCallback):
966         * DumpRenderTree/qt/LayoutTestControllerQt.h:
967
968 2011-08-30  Filip Pizlo  <fpizlo@apple.com>
969
970         JavaScriptCore does not have a good mechanism for performance
971         regression testing
972         https://bugs.webkit.org/show_bug.cgi?id=67177
973
974         Reviewed by Darin Adler.
975         
976         Added a new script, which allows for testing one, two, or more VMs
977         at once on SunSpider, V8, and Kraken benchmarks.  Benchmark/VM runs
978         are interleaved at random to minimize systematics.  The results
979         that bencher prints includes all possible relevant information about
980         how bencher was invoked.  Bencher can be easily used to measure
981         performance changes down to fractions of a percent.
982         
983         Bencher also includes experimental support for running benchmarks in
984         a DumpRenderTree release build.  This works in SunSpider and V8, but
985         not yet in Kraken.  Running benchmarks in DumpRenderTree more
986         closely mimics the performance when running in browser.
987
988         * Scripts/bencher: Added.
989
990 2011-08-29  Alexey Proskuryakov  <ap@apple.com>
991
992         DumpRenderTree should begin each test with an empty cookie store
993         https://bugs.webkit.org/show_bug.cgi?id=63545
994         <rdar://problem/5666907>
995
996         Reviewed by Darin Adler.
997
998         * DumpRenderTree/mac/DumpRenderTree.mm:
999         (resetDefaultsToConsistentValues):
1000         (setDefaultsToConsistentValuesForTesting):
1001         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1002         (LayoutTestController::setAlwaysAcceptCookies):
1003         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1004         (WTR::InjectedBundle::beginTesting):
1005         Use new SPIs to manipulate sessions.
1006
1007 2011-08-30  Sheriff Bot  <webkit.review.bot@gmail.com>
1008
1009         Unreviewed, rolling out r94055 and r94057.
1010         http://trac.webkit.org/changeset/94055
1011         http://trac.webkit.org/changeset/94057
1012         https://bugs.webkit.org/show_bug.cgi?id=67191
1013
1014         Many failures on Mac 10.5 (Requested by toyoshim on #webkit).
1015
1016         * Scripts/webkitpy/thirdparty/__init__.py:
1017
1018 2011-08-30  Adam Barth  <abarth@webkit.org>
1019
1020         Chromium Android should not be a core builder
1021         https://bugs.webkit.org/show_bug.cgi?id=67184
1022
1023         Reviewed by Ryosuke Niwa.
1024
1025         This bot hasn't been consistently green yet because it has never actually run!
1026
1027         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1028         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1029
1030 2011-08-30  Takashi Toyoshima  <toyoshim@chromium.org>
1031
1032         [WebSocket] update pywebsocket to 0.6b4.
1033         https://bugs.webkit.org/show_bug.cgi?id=66924
1034
1035         Reviewed by Kent Tamura.
1036
1037         pywebsocket 0.6b2 supported minimum features of Hybi-08 specification.
1038         Now, pywebsocket 0.6b4 supports full features of Hybi-10 specification.
1039         0.6b3 or later supports a closing handshake handler and it is useful to
1040         verify client's closing handshake implementation.
1041         0.6b4 supports AbortedByUserException. It is useful to eliminate
1042         unnecessary server warning messages on intended abnormal closures.
1043
1044         * Scripts/webkitpy/thirdparty/__init__.py:
1045         Update download URL and directory path.
1046
1047 2011-08-29  Tom Zakrajsek  <tomz@codeaurora.org>
1048
1049         sheriffbot "usage" help statements are wrong
1050         https://bugs.webkit.org/show_bug.cgi?id=67170
1051
1052         Reviewed by Adam Barth.
1053
1054         * Scripts/webkitpy/tool/bot/irc_command.py:
1055         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1056         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1057
1058 2011-08-29  Adam Barth  <abarth@webkit.org>
1059
1060         Add support for chomium-mac (non-CoreGraphics) baselines
1061         https://bugs.webkit.org/show_bug.cgi?id=67163
1062
1063         Reviewed by Eric Seidel.
1064
1065         This patch teaches the non-CG chromium-mac bots to look at non-CG
1066         baselines.  However, the patch still leaves CG as the default set of
1067         baselines.
1068
1069         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1070         * Scripts/webkitpy/common/config/build.py:
1071         * Scripts/webkitpy/common/config/build_unittest.py:
1072         * Scripts/webkitpy/layout_tests/port/builders.py:
1073         * Scripts/webkitpy/layout_tests/port/chromium.py:
1074         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1075         * Scripts/webkitpy/layout_tests/port/factory.py:
1076         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1077         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1078         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
1079         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1080
1081 2011-08-29  Shawn Singh  <shawnsingh@chromium.org>
1082
1083         Small fix in chromium port of new-run-webkit-tests.
1084         https://bugs.webkit.org/show_bug.cgi?id=67078
1085
1086         Reviewed by Dirk Pranke.
1087
1088         * Scripts/webkitpy/layout_tests/port/chromium.py:
1089
1090 2011-08-29  Sheriff Bot  <webkit.review.bot@gmail.com>
1091
1092         Unreviewed, rolling out r93987, r93992, r93995, r93998, and
1093         r93999.
1094         http://trac.webkit.org/changeset/93987
1095         http://trac.webkit.org/changeset/93992
1096         http://trac.webkit.org/changeset/93995
1097         http://trac.webkit.org/changeset/93998
1098         http://trac.webkit.org/changeset/93999
1099         https://bugs.webkit.org/show_bug.cgi?id=67147
1100
1101         Many failing tests (Requested by ap on #webkit).
1102
1103         * DumpRenderTree/mac/DumpRenderTree.mm:
1104         (setDefaultsToConsistentValuesForTesting):
1105         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1106         (WTR::InjectedBundle::beginTesting):
1107
1108 2011-08-26  Alexey Proskuryakov  <ap@apple.com>
1109
1110         DumpRenderTree should begin each test with an empty cookie store
1111         https://bugs.webkit.org/show_bug.cgi?id=63545
1112         <rdar://problem/5666907>
1113
1114         Reviewed by Darin Adler.
1115
1116         * DumpRenderTree/mac/DumpRenderTree.mm:
1117         (setDefaultsToConsistentValuesForTesting):
1118         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1119         (WTR::InjectedBundle::beginTesting):
1120         Tell WebCore to use a temporary session, starting with a clean cookie store.
1121
1122 2011-08-23  Chris Marrin  <cmarrin@apple.com>
1123
1124         [mac] requestAnimationFrame support for mac port
1125         https://bugs.webkit.org/show_bug.cgi?id=59146
1126
1127         Reviewed by Simon Fraser.
1128
1129         Add support for request-animation-callback flag
1130
1131         * Scripts/build-webkit:
1132
1133 2011-08-27  Peter Beverloo  <peter@chromium.org>
1134
1135         Add a build bot for Chromium with OS(ANDROID)
1136         https://bugs.webkit.org/show_bug.cgi?id=66687
1137
1138         Reviewed by Adam Barth.
1139
1140         * BuildSlaveSupport/build.webkit.org-config/config.json:
1141
1142 2011-08-27  Peter Beverloo  <peter@chromium.org>
1143
1144         Update the master build bot configuration script to properly
1145         deal with the --chromium-android switch.
1146         https://bugs.webkit.org/show_bug.cgi?id=66687
1147
1148         The --chromium-android switch is needed when running
1149         update-webkit-chromium and build-webkit, as it'll tell the
1150         scripts to pull in the right dependencies and cross-compile
1151         WebKit using the Android NDK.
1152
1153         Reviewed by Adam Barth.
1154
1155         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1156
1157 2011-08-27  Peter Beverloo  <peter@chromium.org>
1158
1159         Teach the update and build scripts how to handle dependencies
1160         and cross-compiling rules for the Chromium port on OS(ANDROID).
1161         https://bugs.webkit.org/show_bug.cgi?id=66687
1162
1163         Reviewed by Adam Barth.
1164
1165         * Scripts/build-webkit:
1166         * Scripts/update-webkit:
1167         * Scripts/update-webkit-chromium:
1168         * Scripts/webkitdirs.pm:
1169         (argumentsForConfiguration):
1170         (isChromium):
1171         (isChromiumAndroid):
1172         (determineIsChromiumAndroid):
1173         (buildChromium):
1174
1175 2011-08-26  Adam Barth  <abarth@webkit.org>
1176
1177         garden-o-matic should let me know that I need to run the local server
1178         https://bugs.webkit.org/show_bug.cgi?id=66985
1179
1180         Reviewed by Dimitri Glazkov.
1181
1182         The patch triggers an alert dialog whenever the user tries to use a
1183         feature that requires the local server.
1184
1185         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1186         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
1187         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
1188
1189 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
1190
1191         garden-o-matic summary view should have pretty commit data information.
1192         https://bugs.webkit.org/show_bug.cgi?id=67069
1193
1194         Reviewed by Adam Barth.
1195
1196         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added support for styling commit data.
1197         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Changed tests.
1198         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Defined global anchor color.
1199         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Styled commit data.
1200
1201 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
1202
1203         Tweak the use of Open Sans in garden-o-matic summary view to make it look decent on Windows and Linux.
1204         https://bugs.webkit.org/show_bug.cgi?id=67066
1205
1206         Reviewed by Adam Barth.
1207
1208         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Tweaked.
1209         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
1210
1211 2011-08-26  Raphael Kubo da Costa  <kubo@profusion.mobi>
1212
1213         [DRT] Include cairo.h in PixelDumpSupportCairo.h for EFL too.
1214         https://bugs.webkit.org/show_bug.cgi?id=67041
1215
1216         Reviewed by Martin Robinson.
1217
1218         This is a follow-up to r89053: EFL's PixelDumpSupportEfl.cpp includes
1219         PixelDumpSupportCairo.h, but the latter was #including cairo.h only
1220         when the GTK+ port was being built.
1221
1222         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
1223
1224 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
1225
1226         Clean up and line up layout in garden-o-matic summary view.
1227         https://bugs.webkit.org/show_bug.cgi?id=67057
1228
1229         1) Renamed ui.notifications.TestFailures to ui.notifications.TestsFailing to match BuildersFailing;
1230         2) Rearranged DOM structure a bit to accommodate recent changes;
1231         3) Added minimal CSS to line things up.
1232
1233         Reviewed by Adam Barth.
1234
1235         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Renamed TestFailures to TestsFailing.
1236         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added mocks for BuildersFailing.
1237         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Renamed TestFailures to TestsFailing.
1238         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Updated tests.
1239         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed DOM structure.
1240         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
1241         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Tweaked common appearance.
1242         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added minimal layout/style.
1243         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added Google Web Fonts hook.
1244         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
1245
1246 2011-08-26  Alice Liu  <alice.liu@apple.com>
1247
1248         https://bugs.webkit.org/show_bug.cgi?id=66823
1249         Add the request info to the WebPageProxy::CreateNewPage message
1250
1251         Reviewed by Anders Carlsson.
1252
1253         Update function declarations with additional parameter:
1254         * MiniBrowser/gtk/BrowserWindow.c:
1255         (createNewPage):
1256         * MiniBrowser/mac/BrowserWindowController.m:
1257         (createNewPage):
1258         * MiniBrowser/win/BrowserView.cpp:
1259         (createNewPage):
1260         * WebKitTestRunner/TestController.cpp:
1261         (WTR::TestController::createOtherPage):
1262         * WebKitTestRunner/TestController.h:
1263
1264 2011-08-26  Noel Gordon  <noel.gordon@gmail.com>
1265
1266         Make show-pretty-diff work on linux
1267         https://bugs.webkit.org/show_bug.cgi?id=67017
1268
1269         Reviewed by Adam Barth.
1270
1271         * Scripts/show-pretty-diff:
1272
1273 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
1274
1275         Reorganize garden-o-matic CSS files to match JS-built views.
1276         https://bugs.webkit.org/show_bug.cgi?id=66998
1277
1278         Reviewed by Adam Barth.
1279
1280         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Added.
1281         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added.
1282         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css: Added.
1283         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Removed.
1284         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Changed to use new CSS files.
1285         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
1286
1287 2011-08-25  Adam Barth  <abarth@webkit.org>
1288
1289         garden-o-matic should be able to roll out patches
1290         https://bugs.webkit.org/show_bug.cgi?id=66982
1291
1292         Reviewed by Dimitri Glazkov.
1293
1294         This patch just wires the rollout event through the controller to the
1295         local server, which is already set up to perform rollouts.
1296
1297         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1298         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1299         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1300         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
1301
1302 2011-08-25  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
1303
1304         [Qt] [WK2] Assert in computeViewportAttributes when MiniBrowser started with -touch
1305         https://bugs.webkit.org/show_bug.cgi?id=66951
1306
1307         Reviewed by Andreas Kling.
1308
1309         Function computeViewportAttributes() gets called when height is still 0 because MiniBrowser sets
1310         width and height one by one and setWidth cause geometryChange event in QTouchWebView. 
1311
1312         * MiniBrowser/qt/BrowserView.cpp:
1313         (BrowserView::resizeEvent):
1314
1315 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
1316
1317         garden-o-matic summary view should provide information on builders still in flight.
1318         https://bugs.webkit.org/show_bug.cgi?id=66992
1319
1320         Reviewed by Adam Barth.
1321
1322         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Added grabbing the list of in-flight builders.
1323         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Added buildersInFlightForRevision.
1324         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: Added tests.
1325         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Split off updating builder results to own method.
1326         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added tests.
1327
1328 2011-08-25  Adam Barth  <abarth@webkit.org>
1329
1330         webkit-patch rebaseline-expectations don't work when run outside the root
1331         https://bugs.webkit.org/show_bug.cgi?id=66966
1332
1333         Reviewed by Eric Seidel.
1334
1335         Turns out tool.path() used to be relative, which caused problems when
1336         running webkit-patch outside the root directory.  This patch makes it
1337         absolute.  I checked all callers, and they all appear to want this
1338         behavior.
1339
1340         It was unclear to me how to test this change because we only really
1341         have a testing strategy for webkitpy, not for the main script.
1342
1343         * Scripts/webkit-patch:
1344
1345 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
1346
1347         garden-o-matic summary needs a mock view that could be used for working on styling
1348         https://bugs.webkit.org/show_bug.cgi?id=66971
1349
1350         Reviewed by Adam Barth.
1351
1352         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added.
1353         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added.
1354
1355 2011-08-25  Anders Carlsson  <andersca@apple.com>
1356
1357         Return the correct value for NPNVsupportsCarbonBool
1358         https://bugs.webkit.org/show_bug.cgi?id=66964
1359
1360         Add a test.
1361
1362         Reviewed by Adam Roben.
1363
1364         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1365         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Added.
1366         (SupportsCarbonEventModel::SupportsCarbonEventModel):
1367         (SupportsCarbonEventModel::testConvert):
1368         (SupportsCarbonEventModel::runTest):
1369         (SupportsCarbonEventModel::NPP_New):
1370
1371 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
1372
1373         garden-o-matic summary view should not be broken.
1374
1375         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:
1376         (table.comparison): Added more specificity.
1377
1378 2011-08-25  Adam Barth  <abarth@webkit.org>
1379
1380         This command has been broken for a while.  This patch updates the
1381         callsite to the new API.
1382
1383         * Scripts/webkitpy/tool/commands/rebaseline.py:
1384
1385 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
1386
1387         garden-o-matic needs a way to report where and how tests are failing in the summary view.
1388         https://bugs.webkit.org/show_bug.cgi?id=66955
1389
1390         Introduce FailureGrid, your one-stop failure-indicating destination. 
1391
1392         Reviewed by Adam Barth.
1393
1394         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Added new scripts.
1395         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Added.
1396         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Added.
1397         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Updated to use FailureGrid.
1398         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
1399         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Added new scripts.
1400
1401 2011-08-25  Igor Oliveira  <igor.oliveira@openbossa.org>
1402
1403         Add myself to the committers list
1404         https://bugs.webkit.org/show_bug.cgi?id=66941
1405
1406         Reviewed by Andreas Kling.
1407
1408         * Scripts/webkitpy/common/config/committers.py:
1409
1410 2011-08-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1411
1412         Unreviewed, rolling out r93767.
1413         http://trac.webkit.org/changeset/93767
1414         https://bugs.webkit.org/show_bug.cgi?id=66931
1415
1416         Broke Qt bot. (Requested by yutak on #webkit).
1417
1418         * Scripts/webkitpy/thirdparty/__init__.py:
1419
1420 2011-08-25  Takashi Toyoshima  <toyoshim@chromium.org>
1421
1422         [WebSocket] update pywebsocket to 0.6b3 which supports closing handshake test
1423         https://bugs.webkit.org/show_bug.cgi?id=66924
1424
1425         Reviewed by Kent Tamura.
1426
1427         * Scripts/webkitpy/thirdparty/__init__.py:
1428
1429 2011-08-24  Adam Barth  <abarth@webkit.org>
1430
1431         The user can't close the details view in garden-o-matic
1432         https://bugs.webkit.org/show_bug.cgi?id=66911
1433
1434         Reviewed by Dimitri Glazkov.
1435
1436         In addition to adding a close button, this patch changes the test
1437         selector to use a <select> element and refactors the test selector to
1438         share code with the builder selector.
1439
1440         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1441         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
1442         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
1443         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1444
1445 2011-08-24  James Robinson  <jamesr@chromium.org>
1446
1447         [chromium] Stacktrace not in test output when a test crashes
1448         https://bugs.webkit.org/show_bug.cgi?id=66806
1449
1450         Reviewed by Dirk Pranke.
1451
1452         Appends the .error and .text output when a test crashes since on chromium the .text contains the actual stack
1453         trace.
1454
1455         * Scripts/webkitpy/layout_tests/port/chromium.py:
1456
1457 2011-08-24  Adam Barth  <abarth@webkit.org>
1458
1459         Remove empty directory.
1460
1461         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui: Removed.
1462
1463 2011-08-24  Adam Barth  <abarth@webkit.org>
1464
1465         Finish writing up details-view in garden-o-matic
1466         https://bugs.webkit.org/show_bug.cgi?id=66891
1467
1468         Reviewed by Dimitri Glazkov.
1469
1470         This patch mostly just copies a bunch of CSS from main.css to
1471         summary.css.  Presumably we'll delete main.css soon.
1472
1473         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1474         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
1475         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
1476         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:
1477         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
1478
1479 2011-08-24  James Robinson  <jamesr@chromium.org>
1480
1481         Some compositing LayoutTests flakily crashing on Mac 10.6
1482         https://bugs.webkit.org/show_bug.cgi?id=66740
1483
1484         Reviewed by Adam Barth.
1485
1486         Null-check obj->pluginTest before dereferencing it. This can be null in chromium if the plugin load fails, for
1487         example if the test attempts to load a PDF plugin the load will fail since we don't have such a thing in the
1488         chromium configuration.
1489
1490         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1491         (NPP_Destroy):
1492
1493 2011-08-24  Anton D'Auria  <adauria@apple.com>
1494
1495         No review necessary.
1496
1497         Adding myself to list of committers.
1498
1499         * Scripts/webkitpy/common/config/committers.py:
1500
1501 2011-08-24  Avi Drissman  <avi@google.com>
1502
1503         Crash when restoring NSGraphicsContext when running the Chromium GPU layout tests on Mac
1504         https://bugs.webkit.org/show_bug.cgi?id=66875
1505
1506         Reviewed by James Robinson.
1507
1508         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
1509         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
1510
1511 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
1512
1513         Make notifications appear in time order again.
1514         https://bugs.webkit.org/show_bug.cgi?id=66815
1515
1516         Reviewed by Adam Barth.
1517
1518         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added setting index of the notification.
1519         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated the test.
1520
1521 2011-08-23  James Robinson  <jamesr@chromium.org>
1522
1523         [chromium] Need a way to test lost compositor context recovery
1524         https://bugs.webkit.org/show_bug.cgi?id=66820
1525
1526         Reviewed by Kenneth Russell.
1527
1528         Exposes a LayoutTestController interface in chromium to simulate a
1529         lost compositor context.
1530
1531         * DumpRenderTree/chromium/LayoutTestController.cpp:
1532         (LayoutTestController::LayoutTestController):
1533         (LayoutTestController::loseCompositorContext):
1534         * DumpRenderTree/chromium/LayoutTestController.h:
1535
1536 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
1537
1538         Change garden-o-matic frontend builder array to be a configuration map.
1539         https://bugs.webkit.org/show_bug.cgi?id=66816
1540
1541         Reviewed by Adam Barth.
1542
1543         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js: Made kBuilders a map, with value being a configuration object.
1544         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Adjusted callsites to expect a map.
1545         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Ditto.
1546         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Ditto.
1547         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Ditto.
1548
1549 2011-08-23  Cary Clark  <caryclark@google.com>
1550
1551         Turn WebCanvas into CGContext before drawing scrollbar (DRT using Skia on Mac)
1552         https://bugs.webkit.org/show_bug.cgi?id=66803
1553
1554         This fixes the WebKit Canaries, in particular avoids a crash on tests
1555         like css1/basic/comments.html.
1556
1557         Reviewed by James Robinson.
1558
1559         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
1560         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
1561         The NSGraphicsContext call graphicsContextWithGraphicsPort takes a void*
1562         parameter, so it took a WebCanvas* (mapped to SkCanvas* in Skia-land)
1563         and treated it as if it were a CGContextRef.
1564
1565 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
1566
1567         Fix mergeChangeLogs test on native windows
1568         https://bugs.webkit.org/show_bug.cgi?id=66797
1569
1570         Reviewed by Adam Roben.
1571
1572         Windows has no /tmp/ directory and the "TMPDIR" environment variable isn't set in the default setup.
1573         Add the "TEMP" environment variable as additional source for the temporary directory used in writeTempFile.
1574
1575         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
1576         (writeTempFile):
1577
1578 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
1579
1580         garden-o-matic relative time is wrong and updates too frequently.
1581         https://bugs.webkit.org/show_bug.cgi?id=66802
1582
1583         Reviewed by Adam Barth.
1584
1585         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Changed to account for rounding correctly.
1586         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Updated tests.
1587         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Upped the interval to 1 minute.
1588
1589 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
1590
1591         Add missing quotes around filenames in mergeChangeLogs
1592         https://bugs.webkit.org/show_bug.cgi?id=66794
1593
1594         Reviewed by Adam Roben.
1595
1596         * Scripts/VCSUtils.pm:
1597         (mergeChangeLogs):
1598
1599 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
1600
1601         webkit-perl tests fail on win32 Perl due to lack of list form of pipe open implementation
1602         https://bugs.webkit.org/show_bug.cgi?id=49080
1603
1604         Reviewed by Adam Roben.
1605
1606         Use the string form of pipe open instead (like we do at all other places).
1607
1608         * Scripts/VCSUtils.pm:
1609         (mergeChangeLogs):
1610
1611 2011-08-23  Adam Barth  <abarth@webkit.org>
1612
1613         garden-o-matic summary should be able to examine failures
1614         https://bugs.webkit.org/show_bug.cgi?id=66748
1615
1616         Reviewed by Dimitri Glazkov.
1617
1618         This patch refactors a bunch of code from summary.js to independent
1619         controllers in controllers.js.  This patch also contains the first
1620         iteration of binding the "examine" event to a the behavior showing the
1621         details view for the tests.  There's more work to do here to make this
1622         work properly (and elegantly), but this patch is a start.
1623
1624         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1625         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
1626         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1627         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers/rebaseline.js:
1628         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
1629         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1630         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1631         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
1632         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
1633
1634 2011-08-23  Adam Barth  <abarth@webkit.org>
1635
1636         webkitpy/common/config/build.py shouldn't mention non-existant Android directory
1637         https://bugs.webkit.org/show_bug.cgi?id=66737
1638
1639         Reviewed by Steve Block.
1640
1641         This directory doesn't exist anymore now that the Android port shares
1642         more code with Chromium.
1643
1644         * Scripts/webkitpy/common/config/build.py:
1645
1646 2011-08-22  Eric Seidel  <eric@webkit.org>
1647
1648         Hack start-queue.sh in an attempt to resurrect the cr-jail-1 cr-mac-ews bot.
1649         I won't have ssh access to the bot again for a couple days, so
1650         attempting to fix by changing this script.  If this doesn't
1651         work we'll just live with the it hung for now.
1652
1653         Unreviewed.
1654
1655         * EWSTools/start-queue.sh:
1656
1657 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
1658
1659         webkit-patch rebaseline-expectations command should not rearrange the entire test_expectations.txt file.
1660         https://bugs.webkit.org/show_bug.cgi?id=66727
1661
1662         Reviewed by Adam Barth.
1663
1664         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Made it possible to run TestExpectationSerializer without a TestConfigurationConverter,
1665             in which case the serializer treats all expectations as unparsed.
1666         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added unit tests.
1667
1668 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
1669
1670         Update unit test expectations after r93530.
1671
1672         * Scripts/webkitpy/layout_tests/port/factory_unittest.py: Updated.
1673         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
1674
1675 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
1676
1677         [Chromium] Expand CPU/GPU/Skia/CG into a matrix in graphics_type.
1678         https://bugs.webkit.org/show_bug.cgi?id=66705
1679
1680         Reviewed by Adam Barth.
1681
1682         * Scripts/webkitpy/layout_tests/port/chromium.py: Added plumbing for CG graphics types.
1683         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Adjusted unit test.
1684
1685 2011-08-22  James Robinson  <jamesr@chromium.org>
1686
1687         [chromium] Update builder names for chromium gpu bots due to CG switchover
1688         https://bugs.webkit.org/show_bug.cgi?id=66693
1689
1690         Reviewed by Dirk Pranke.
1691
1692         Update the port and builder names for the chromium mac gpu bots to
1693         account for the CG transition.
1694
1695         * Scripts/webkitpy/layout_tests/port/builders.py:
1696
1697 2011-08-22  Dirk Pranke  <dpranke@chromium.org>
1698
1699         fix the GPU bot names on the layout test dashboard
1700         https://bugs.webkit.org/show_bug.cgi?id=66697
1701
1702         Reviewed by Dimitri Glazkov.
1703
1704         * TestResultServer/static-dashboards/builders.js:
1705
1706 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
1707
1708         garden-o-matic's relative time display should be updated regularly.
1709         https://bugs.webkit.org/show_bug.cgi?id=66682
1710
1711         Reviewed by Adam Barth.
1712
1713         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Moved Time to ui.Time, added code for regular updates.
1714         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed to use ui.Time.
1715         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Added tests.
1716
1717 2011-08-22  Xianzhu Wang  <wangxianzhu@chromium.org>
1718
1719         Pass --makeargs of build-webkit to chromium linux builder
1720         https://bugs.webkit.org/show_bug.cgi?id=66361
1721
1722         Reviewed by Tony Chang.
1723
1724         * Scripts/build-webkit:
1725         * Scripts/webkitdirs.pm:
1726         (buildChromiumMakefile):
1727         (buildChromium):
1728
1729 2011-08-22  Peter Beverloo  <peter@chromium.org>
1730
1731         Add myself to the contributor list.
1732         https://bugs.webkit.org/show_bug.cgi?id=66674
1733
1734         Reviewed by Tony Gentilcore.
1735
1736         * Scripts/webkitpy/common/config/committers.py:
1737
1738 2011-08-22  Balazs Kelemen  <kbalazs@webkit.org>
1739
1740         [Qt] ImageDiff does not consider --tolerance
1741         https://bugs.webkit.org/show_bug.cgi?id=66299
1742
1743         Reviewed by Csaba Osztrogonác.
1744
1745         * DumpRenderTree/qt/ImageDiff.cpp:
1746         (main):
1747
1748 2011-08-22  Csaba Osztrogonác  <ossy@webkit.org>
1749
1750         Update contributor list.
1751
1752         Reviewed by Zoltan Herczeg.
1753
1754         * Scripts/webkitpy/common/config/committers.py:
1755
1756 2011-08-22  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
1757
1758         [ORWT] Fix --reset-results --add-platform-exceptions combo
1759         https://bugs.webkit.org/show_bug.cgi?id=65464
1760
1761         Reviewed by Csaba Osztrogonác.
1762
1763         * Scripts/old-run-webkit-tests:
1764
1765 2011-08-20  Adam Barth  <abarth@webkit.org>
1766
1767         garden-o-matic summary.html should have UI for examining failures
1768         https://bugs.webkit.org/show_bug.cgi?id=66625
1769
1770         Reviewed by Dimitri Glazkov.
1771
1772         This patch introduces the notion of UI actions and converts our
1773         existing manual <button> manipulation with this new abstraction.  The
1774         patch also adds an Examine button to failure notifications.  In a
1775         future patch, I'll add a controller that wires this button up to
1776         something useful.
1777
1778         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1779         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
1780         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js: Added.
1781         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js: Added.
1782         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1783         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1784         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1785         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
1786
1787 2011-08-20  Adam Barth  <abarth@webkit.org>
1788
1789         garden-o-matic summary page should indiciate compile failures
1790         https://bugs.webkit.org/show_bug.cgi?id=66624
1791
1792         Reviewed by Dimitri Glazkov.
1793
1794         This patch creates a notification-based UI for build failures.  The new
1795         UI displays the same information that used to be displayed in the
1796         infobar.  There's lots of room for improvement in surfacing more
1797         information, but this is a start.
1798
1799         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
1800         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1801         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1802
1803 2011-08-19  James Robinson  <jamesr@chromium.org>
1804
1805         [chromium] Default to experimental-fully-parallel mode for chromium gpu port
1806         https://bugs.webkit.org/show_bug.cgi?id=66606
1807
1808         Reviewed by Dirk Pranke.
1809
1810         The chromium GPU configuration does not (currently) contain any tests
1811         incompatible with --experimental-fully-parallel, and this flag is a
1812         significan speedup because of the directory canvas/philip/tests which
1813         contains 802 tests in the same directory. Setting this option by
1814         default on this configuration is a 2x speed in release, 44s to 22s,
1815         and a 3x speedup in debug, 223s to 77s, on linux on a 16 core machine.
1816
1817         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1818         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1819         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1820
1821 2011-08-19  Sheriff Bot  <webkit.review.bot@gmail.com>
1822
1823         Unreviewed, rolling out r93426.
1824         http://trac.webkit.org/changeset/93426
1825         https://bugs.webkit.org/show_bug.cgi?id=66607
1826
1827         Broke the Mac build by not building gtest.framework anymore
1828         (Requested by andersca on #webkit).
1829
1830         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
1831
1832 2011-08-19  James Robinson  <jamesr@chromium.org>
1833
1834         [chromium] Chromium GPU layout tests should use the normal process number selection, not force 1 worker
1835         https://bugs.webkit.org/show_bug.cgi?id=66603
1836
1837         Reviewed by Dirk Pranke.
1838
1839         The various ChromiumGpu ports should use the same child worker
1840         selection logic as other ports so they can run with full
1841         parallelization on multicore systems.
1842
1843         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1844         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1845
1846 2011-08-19  Alok Priyadarshi  <alokp@chromium.org>
1847
1848         [chromium] Remove dependency of WebThemeControlDRTWin on skia::PlatformCanvas
1849         https://bugs.webkit.org/show_bug.cgi?id=66570
1850
1851         Reviewed by Mihai Parparita.
1852
1853         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
1854         (WebThemeControlDRTWin::draw):
1855         (WebThemeControlDRTWin::drawTextField):
1856         (WebThemeControlDRTWin::drawProgressBar):
1857         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
1858
1859 2011-08-18  Dmitry Lomov  <dslomov@google.com>
1860
1861         TestWebKitAPI breaks on Windows due to fast malloc incompatibility.
1862         https://bugs.webkit.org/show_bug.cgi?id=66521
1863
1864         This patch ensures that gtest uses new and delete operators that are defined in JavaScriptCore.
1865
1866         Reviewed by David Levin.
1867
1868         * TestWebKitAPI/Tests/WTF/StringOperators.cpp: Removed redefinition of JS_EXPORTDATA.
1869
1870 2011-08-19  Adam Roben  <aroben@apple.com>
1871
1872         Add project file changes I left out in r93417
1873
1874         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1875
1876 2011-08-19  Adam Roben  <aroben@apple.com>
1877
1878         Add a helper class for swizzling ObjC instance methods to TestWebKitAPI
1879
1880         Fixes <http://webkit.org/b/66565> TestWebKitAPI needs a way to override instance methods of
1881         NSScreen
1882
1883         Reviewed by Anders Carlsson.
1884
1885         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
1886
1887         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Added.
1888         (-[SimpleObject setValue:]): Original implementation.
1889
1890         (TestWebKitAPI::setValue2):
1891         (TestWebKitAPI::setValue3):
1892         Swizzled implementations.
1893
1894         (TestWebKitAPI::TEST): Test that we can swizzle and re-swizzle and un-swizzle an ObjC
1895         instance method.
1896
1897         * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Added.
1898         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Added.
1899         (TestWebKitAPI::InstanceMethodSwizzler::InstanceMethodSwizzler): Swizzle the method.
1900         (TestWebKitAPI::InstanceMethodSwizzler::~InstanceMethodSwizzler): Unswizzle the method.
1901
1902 2011-08-19  Tom Zakrajsek  <tomz@codeaurora.org>
1903
1904         Fix _path_to_apache() error reporting
1905         https://bugs.webkit.org/show_bug.cgi?id=66486
1906
1907         Reviewed by Ryosuke Niwa.
1908
1909         * Scripts/webkitpy/layout_tests/port/webkit.py:
1910
1911 2011-08-19  Adam Roben  <aroben@apple.com>
1912
1913         Windows build fix after r93404
1914
1915         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Added missing #include.
1916
1917 2011-08-19  Tony Gentilcore  <tonyg@chromium.org>
1918
1919         Add leandrogracia to the committers list
1920         https://bugs.webkit.org/show_bug.cgi?id=66552
1921
1922         Also fix line endings in file.
1923
1924         No reviewed required.
1925
1926         * Scripts/webkitpy/common/config/committers.py:
1927
1928 2011-08-19  Amruth Raj  <amruthraj@motorola.com>
1929
1930         Fix compilation issue in WebKitTestRunner
1931         https://bugs.webkit.org/show_bug.cgi?id=66554
1932
1933         Reviewed by Martin Robinson.
1934
1935         * WebKitTestRunner/PixelDumpSupport.cpp:
1936
1937 2011-08-19  Adam Roben  <aroben@apple.com>
1938
1939         Pull some of DynamicDeviceScaleFactor's code up into a shareable base class
1940
1941         This will make it easier to write other WebKit-agnostic tests
1942
1943         Fixes <http://webkit.org/b/66558> Would like to be able to reuse DynamicDeviceScaleFactor's
1944         code in other WebKit-agnostic tests
1945
1946         Reviewed by Anders Carlsson.
1947
1948         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
1949
1950         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Fixed copyright. Moved a bunch of
1951         code to WebKitAgnosticTest.h/mm. Changed to inherit from WebKitAgnosticTest.
1952         (TestWebKitAPI::DynamicDeviceScaleFactor::url): Simple getter.
1953         (TestWebKitAPI::DynamicDeviceScaleFactor::didLoadURL): Calls through to runTest.
1954         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Removed loading code which
1955         WebKitAgnosticTest handles for us.
1956         (TestWebKitAPI::TEST_F): Removed view-creation code which WebKitAgnosticTest handles for us.
1957
1958         * TestWebKitAPI/mac/WebKitAgnosticTest.h: Added. Code came from DynamicDeviceScaleFactor.
1959         (TestWebKitAPI::WebKitAgnosticTest::loadAndWaitUntilDone): Code came from
1960         DynamicDeviceScaleFactor::runTest.
1961
1962         * TestWebKitAPI/mac/WebKitAgnosticTest.mm: Copied from Tools/TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm.
1963         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test): Code came from
1964         DynamicDeviceScaleFactor.WebKit.
1965         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test): Code came from
1966         DynamicDeviceScaleFactor.WebKit2.
1967
1968 2011-08-19  Adam Roben  <aroben@apple.com>
1969
1970         Clean up #includes in TestWebKitAPI
1971
1972         Fixes <http://webkit.org/b/66556> TestWebKitAPI's prefix header isn't very helpful
1973
1974         Reviewed by Anders Carlsson.
1975
1976         * TestWebKitAPI/TestWebKitAPIPrefix.h: Added wtf/Platform.h. Added gtest/gtest.h for C++
1977         files and WebKit/WebKit.h for ObjC files.
1978
1979         * TestWebKitAPI/InjectedBundleController.cpp:
1980         * TestWebKitAPI/JavaScriptTest.h:
1981         * TestWebKitAPI/PlatformUtilities.h:
1982         * TestWebKitAPI/PlatformWebView.h:
1983         * TestWebKitAPI/Test.h:
1984         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
1985         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
1986         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp:
1987         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
1988         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
1989         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
1990         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
1991         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
1992         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
1993         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
1994         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
1995         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
1996         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
1997         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
1998         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
1999         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
2000         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
2001         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
2002         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
2003         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
2004         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2005         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2006         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
2007         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
2008         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
2009         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2010         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2011         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
2012         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
2013         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
2014         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
2015         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
2016         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
2017         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
2018         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
2019         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
2020         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
2021         * TestWebKitAPI/TestsController.cpp:
2022         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2023         Removed now-unnecessary #includes. Moved #includes of Test.h in with the rest of the
2024         #includes since it is no longer a special header.
2025
2026 2011-08-18  Dirk Pranke  <dpranke@chromium.org>
2027
2028         new-run-webkit-tests hung while acquiring http lock on snow leopard bots
2029         https://bugs.webkit.org/show_bug.cgi?id=64886
2030
2031         Temporarily disable the http locking to work around the issue.
2032         I'm not actually sure if this is going to work or improve things
2033         much.
2034
2035         Reviewed by Ryosuke Niwa.
2036
2037         * Scripts/webkitpy/layout_tests/port/mac.py:
2038
2039 2011-08-18  Tony Chang  <tony@chromium.org>
2040
2041         add embedded png checksums to WebKitTestRunner
2042         https://bugs.webkit.org/show_bug.cgi?id=66494
2043
2044         Looks like WebKitTestRunner has never supported embedded checksums.  This copies
2045         some code from DRT and adds it to the WebKitTestRunner.
2046
2047         Reviewed by Darin Adler.
2048
2049         * WebKitTestRunner/CyclicRedundancyCheck.cpp: Copied from Tools/DumpRenderTree
2050         * WebKitTestRunner/CyclicRedundancyCheck.h: Copied from Tools/DumpRenderTree
2051         * WebKitTestRunner/GNUmakefile.am: Add new files
2052         * WebKitTestRunner/PixelDumpSupport.cpp: Copied from Tools/DumpRenderTree
2053         * WebKitTestRunner/PixelDumpSupport.h: Copied from Tools/DumpRenderTree
2054         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Add new files
2055         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2056         (WTR::dumpBitmap): Refactor to use PixelDumpSupport.
2057         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2058         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2059         (WTR::dumpBitmap): Refactor to use PixelDumpSupport.
2060         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2061         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Add new files
2062
2063 2011-08-18  Shawn Singh  <shawnsingh@chromium.org>
2064
2065         https://bugs.webkit.org/show_bug.cgi?id=47240
2066
2067         Fixed a cygwin path problem in the chromium port of diff_image;
2068         Also made the return values of the diff_image function more consistent.
2069
2070         Reviewed by Dirk Pranke.
2071
2072         * Scripts/webkitpy/layout_tests/port/chromium.py:
2073
2074 2011-08-17  Alejandro G. Castro  <alex@igalia.com>
2075
2076         [GTK] Fix compilation problems with deprecations in gtk+
2077         https://bugs.webkit.org/show_bug.cgi?id=66073
2078
2079         Reviewed by Martin Robinson.
2080
2081         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2082         (main): G_CONST_RETURN was deprecated
2083         * GtkLauncher/main.c:
2084         (createWindow): Added gtk_box_new conditional compilation for
2085         gtk+-3.
2086         * MiniBrowser/gtk/BrowserWindow.c:
2087         (browser_window_init): Replaced gtk_vbox_new with gtk_box_new, we
2088         are just supporting gtk+-3 for WebKit2.
2089
2090 2011-08-18  Anders Carlsson  <andersca@apple.com>
2091
2092         Fix libc++ C++0x build
2093         https://bugs.webkit.org/show_bug.cgi?id=66479
2094
2095         Reviewed by Adam Roben.
2096
2097         Add missing includes.
2098
2099         * DumpRenderTree/LayoutTestController.cpp:
2100         * DumpRenderTree/mac/CheckedMalloc.cpp:
2101
2102 2011-08-18  Adam Roben  <aroben@apple.com>
2103
2104         Test that WebKit updates style when a WebView is moved between differently-scaled windows
2105
2106         Test for <http://webkit.org/b/66412> <rdar://problem/9971958> WebKit doesn't react when a
2107         WebView is moved between windows with different backing scale factors
2108
2109         Reviewed by Anders Carlsson.
2110
2111         * TestWebKitAPI/JavaScriptTest.cpp:
2112         (TestWebKitAPI::runJSTest): Moved a little bit of code from here...
2113         (TestWebKitAPI::compareJSResult): ...to here. Also made the error message more similar to
2114         gtest's built-in error messages.
2115
2116         * TestWebKitAPI/JavaScriptTest.h: Added overloads of runJSTest that take a WebView * and
2117         WKView * for convenience on Mac. Added compareJSResult helper function for implementing
2118         those overloads.
2119
2120         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
2121
2122         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Added.
2123         (-[FrameLoadDelegate initWithDidFinishLoadBoolean:]): Simple initializer.
2124         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Record that the load finished.
2125         (TestWebKitAPI::didFinishLoadForFrame): Record that the load finished.
2126         (TestWebKitAPI::setPageLoaderClient): Set up the client.
2127         (TestWebKitAPI::DynamicDeviceScaleFactor::DynamicDeviceScaleFactor): Simple constructor.
2128         (TestWebKitAPI::DynamicDeviceScaleFactor::createWindow): Creates a
2129         SyntheticBackingScaleFactorWindow and returns it.
2130         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Loads devicePixelRatio.html and checks
2131         that WebKit uses the correct scale factor when the WebView is not in a window, is put in a
2132         window, is moved to a differently-scaled window, and is taken out of the window.
2133         (TestWebKitAPI::DynamicDeviceScaleFactor::loadURL): Helper function with overloads for
2134         WebKit1 and WebKit2.
2135         (TestWebKitAPI::TEST_F): Runs the test, with overloads for WebKit1 and WebKit2.
2136
2137         * TestWebKitAPI/Tests/mac/devicePixelRatio.html: Added.
2138
2139         * TestWebKitAPI/mac/JavaScriptTestMac.mm: Added.
2140         (TestWebKitAPI::runJSTest): Fairly simple overloads for WebView * and WKView *.
2141
2142         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.h: Added.
2143         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m: Added.
2144         (-[SyntheticBackingScaleFactorWindow initWithContentRect:styleMask:backing:defer:]): Simple
2145         initializer.
2146         (-[SyntheticBackingScaleFactorWindow setBackingScaleFactor:]): Simple setter.
2147
2148         (-[SyntheticBackingScaleFactorWindow backingScaleFactor]):
2149         (-[SyntheticBackingScaleFactorWindow userSpaceScaleFactor]):
2150         Overrides of NSWindow methods that WebKit uses to determine the device scale factor.
2151
2152 2011-08-18  Dmitry Lomov  <dslomov@google.com>
2153
2154         https://bugs.webkit.org/show_bug.cgi?id=66425
2155         check-webkit-style should detect incorrectly formatted file change descriptions.
2156         Description, if present, should be separated from colon with a space.
2157
2158         Reviewed by David Levin.
2159
2160         * Scripts/webkitpy/style/checkers/changelog.py: Fix.
2161         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Unit tests.
2162
2163 2011-08-18  Adam Barth  <abarth@webkit.org>
2164
2165         webkit-patch pretty-diff should be shown in main help
2166         https://bugs.webkit.org/show_bug.cgi?id=66404
2167
2168         Reviewed by Dimitri Glazkov.
2169
2170         As requested by dglazkov.
2171
2172         * Scripts/webkitpy/tool/commands/prettydiff.py:
2173
2174 2011-08-17  Dmitry Lomov  <dslomov@google.com>
2175
2176         https://bugs.webkit.org/show_bug.cgi?id=66400
2177         Fix TestWebKitAPI build on Mac OS.
2178
2179         Reviewed by David Levin.
2180
2181         * TestWebKitAPI/Configurations/Base.xcconfig: Added ICU headers to the HEADER_SEARCH_PATH.
2182
2183 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
2184
2185         garden-o-matic spring cleaning: move scripts, styles, and images in the respective directories.
2186         https://bugs.webkit.org/show_bug.cgi?id=66427
2187
2188         Reviewed by Adam Barth.
2189
2190         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js: Removed.
2191         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Removed.
2192         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js: Removed.
2193         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Removed.
2194         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js: Removed.
2195         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js: Removed.
2196         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js: Removed.
2197         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js: Removed.
2198         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js: Removed.
2199         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js: Removed.
2200         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js: Removed.
2201         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js: Removed.
2202         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js: Removed.
2203         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js: Removed.
2204         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js: Removed.
2205         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js: Removed.
2206         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js: Removed.
2207         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js: Removed.
2208         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css: Removed.
2209         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js: Removed.
2210         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js: Removed.
2211         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Removed.
2212         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Removed.
2213         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js: Removed.
2214         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Removed.
2215         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js: Removed.
2216         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Removed.
2217         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Removed.
2218         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Removed.
2219         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js: Removed.
2220         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js: Removed.
2221         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Removed.
2222         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js: Removed.
2223         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js: Removed.
2224         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js: Removed.
2225         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers: Removed.
2226         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js: Removed.
2227         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers/rebaseline.js: Removed.
2228         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png: Removed.
2229         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png: Removed.
2230         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2231         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images: Added.
2232         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png.
2233         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png.
2234         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
2235         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css: Removed.
2236         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Removed.
2237         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Removed.
2238         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Removed.
2239         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js: Removed.
2240         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js: Removed.
2241         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html:
2242         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js: Removed.
2243         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js: Removed.
2244         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
2245         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js.
2246         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js.
2247         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js.
2248         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Builder.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js.
2249         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Builder_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js.
2250         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FailingTestsBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js.
2251         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FailingTestsBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js.
2252         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyLayoutTestDetector.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js.
2253         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyLayoutTestDetector_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js.
2254         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyTestBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js.
2255         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyTestBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js.
2256         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestHistoryAnalyzer.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js.
2257         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestResultsLoader.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js.
2258         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NRWTResultsParser.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js.
2259         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js.
2260         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js.
2261         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ORWTResultsParser.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js.
2262         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/PersistentCache.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js.
2263         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/TestRelatedBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js.
2264         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/TestRelatedBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js.
2265         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js.
2266         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js.
2267         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js.
2268         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js.
2269         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBugzilla.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js.
2270         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBuildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js.
2271         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js.
2272         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js.
2273         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/bugzilla_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js.
2274         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js.
2275         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js.
2276         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js.
2277         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js.
2278         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js.
2279         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.
2280         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js.
2281         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js.
2282         ():
2283         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js.
2284         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js.
2285         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js.
2286         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js.
2287         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js.
2288         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js.
2289         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/trac_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js.
2290         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js.
2291         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js.
2292         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js.
2293         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js.
2294         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js.
2295         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/TestFailures.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css.
2296         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/main.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css.
2297         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
2298         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Removed.
2299         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js: Removed.
2300         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js: Removed.
2301         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js: Removed.
2302         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js: Removed.
2303         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html:
2304         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js: Removed.
2305
2306 2011-08-17  Jochen Eisinger  <jochen@chromium.org>
2307
2308         Make SVNTest.test_svn_apply use the same timezone logic as VCSUtils.pm
2309         https://bugs.webkit.org/show_bug.cgi?id=65877
2310
2311         Reviewed by Eric Seidel.
2312
2313         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2314
2315 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
2316
2317         Remove base.keys and replace it with Object.keys.
2318         https://bugs.webkit.org/show_bug.cgi?id=66422
2319
2320         Reviewed by Adam Barth.
2321
2322         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Removed base.keys.
2323         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Removed unit tests for it.
2324         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Replaced with Object.keys
2325
2326 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
2327
2328         garden-o-matic Summary view should have items in descending chronological order.
2329         https://bugs.webkit.org/show_bug.cgi?id=66403
2330
2331         Reviewed by Adam Barth.
2332
2333         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Renamed "push" to "add" for clarity, cleaned up some stuff.
2334         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Rewrote add to insert DOM elements in order.
2335         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added unit tests.
2336
2337 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
2338
2339         Fix a few errors in garden-o-matic frontend unit tests.
2340         https://bugs.webkit.org/show_bug.cgi?id=66421
2341
2342         Reviewed by Adam Barth.
2343
2344         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Changed my excellent test to view time as variable continuum.
2345         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Tweaked the test to accommodate new builder names.
2346         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Hurriedly covered up my prior sins.
2347
2348 2011-08-17  Adam Barth  <abarth@webkit.org>
2349
2350         Update Tools to account for (CG) being added to Chromium builder names
2351         https://bugs.webkit.org/show_bug.cgi?id=66410
2352
2353         Reviewed by Adam Barth.
2354
2355         Some of these names will change back once we turn on Skia bots.
2356
2357         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js:
2358         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
2359         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
2360         * Scripts/webkitpy/layout_tests/port/builders.py:
2361         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2362         * TestResultServer/static-dashboards/builders.js:
2363         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2364
2365 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
2366
2367         Wire up relative time to garden-o-matic summary view.
2368         https://bugs.webkit.org/show_bug.cgi?id=66343
2369
2370         Reviewed by Adam Barth.
2371
2372         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Add time to the commitData object. 
2373         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Adjusted unit tests.
2374         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Wired up relative date.
2375         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated unit tests.
2376         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Adjusted unit tests.
2377
2378 2011-08-17  Adam Roben  <aroben@apple.com>
2379
2380         Make run-api-tests run tests in alphabetical order
2381
2382         Fixes <http://webkit.org/b/66401> run-api-tests runs tests in a semi-random order
2383
2384         Reviewed by David Kilzer.
2385
2386         * Scripts/run-api-tests:
2387         (runAllTests):
2388         (runAllTestsInSuite):
2389         Sort the lists of tests and suites before iterating over them.
2390
2391 2011-08-17  Adam Barth  <abarth@webkit.org>
2392
2393         garden-o-matic should be able to rebaseline expected failures
2394         https://bugs.webkit.org/show_bug.cgi?id=66204
2395
2396         Reviewed by Dimitri Glazkov.
2397
2398         This patch introduces a new view for displaying expect, actual, and
2399         differences between results.  The new view also has a fledgling
2400         controller that handles some basic operations.  The new view is
2401         exercised by rebaseline.html, which lets you rebaselines expected
2402         failures, but the new view is not fully integrated into
2403         garden-o-matic.html
2404
2405         More patches will be required to make this stuff fully working, but
2406         this patch was already somewhat spiraling out of control.  Hopefully
2407         this patch will serve as a good starting point for further development.
2408
2409         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers: Added.
2410         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js: Added.
2411         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers/rebaseline.js: Added.
2412         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2413         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
2414         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2415         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html: Added.
2416         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
2417         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
2418         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
2419         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js:
2420         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js: Added.
2421
2422 2011-08-16  Chang Shu  <cshu@webkit.org>
2423
2424         Support reset in WebCore::Internals
2425         https://bugs.webkit.org/show_bug.cgi?id=66307
2426
2427         Reviewed by Dimitri Glazkov.
2428
2429         Added call to resetInternalsObject in DRT.
2430
2431         * DumpRenderTree/chromium/TestShell.cpp:
2432         (TestShell::resetTestController):
2433         * DumpRenderTree/mac/DumpRenderTree.mm:
2434         (resetWebViewToConsistentStateBeforeTesting):
2435         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2436         (WebCore::WebPage::resetSettings):
2437
2438 2011-08-17  Alexis Menard  <alexis.menard@openbossa.org>
2439
2440         Add a new build slave for the Qt port on Mac OS SnowLeopard.
2441         https://bugs.webkit.org/show_bug.cgi?id=66392
2442
2443         Modify the config file to include the new build slave.
2444
2445         Reviewed by Adam Roben.
2446
2447         * BuildSlaveSupport/build.webkit.org-config/config.json:
2448
2449 2011-08-17  Sam White  <samuel.white@rochester.edu>
2450
2451         AccessibilityObject levels are inconsistent
2452         https://bugs.webkit.org/show_bug.cgi?id=66180
2453         
2454         Added the ability to get numeric attribute values using numberAttributeValue. This
2455         function complements the existing stringAttributeValue and boolAttributeValue functions.
2456         The addition of numberAttributeValue was necessary because the stringAttributeValue
2457         function does a type check and will only return strings. This limitation made it
2458         impossible to get values for attributes that returned an NSNumber.
2459
2460         Reviewed by Chris Fleizach.
2461
2462         * DumpRenderTree/AccessibilityUIElement.cpp:
2463         (numberAttributeValueCallback):
2464         (AccessibilityUIElement::getJSClass):
2465         * DumpRenderTree/AccessibilityUIElement.h:
2466         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2467         (AccessibilityUIElement::numberAttributeValue):
2468         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2469         (AccessibilityUIElement::numberAttributeValue):
2470         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2471         (AccessibilityUIElement::numberAttributeValue):
2472
2473 2011-08-17  Adam Roben  <aroben@apple.com>
2474
2475         Tell Trac logs always to display all specified revisions in a single page
2476
2477         Trac imposes a default limit of 100 revisions per log page. We need to tell it to allow more
2478         revisions than that.
2479
2480         Fixes <http://webkit.org/b/66373> Links to Trac from TestFailures page don't always show all
2481         relevant revisions
2482
2483         Reviewed by Daniel Bates.
2484
2485         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
2486         (trac.logURL): Add a limit parameter to the log URL that allows all revisions to be seen in
2487         a single page.
2488
2489         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
2490         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js:
2491         Updated tests for the above.
2492
2493 2011-08-17  Adam Roben  <aroben@apple.com>
2494
2495         Fix TestFailures's link to file a bug about TestFailures itself
2496
2497         Fixes <http://webkit.org/b/66387> REGRESSION (r92135): TestFailures page's link to file a
2498         bug about itself is broken
2499
2500         Reviewed by Dan Bates.
2501
2502         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
2503         (ViewController.prototype._domForAuxiliaryUIElements): Added a path separator to separate
2504         the host from the path.
2505
2506 2011-08-17  Adam Roben  <aroben@apple.com>
2507
2508         Teach TestFailures to ignore unbelievably short test runs
2509
2510         Fixes <http://webkit.org/b/66385> TestFailures page thinks all tests passed in
2511         http://build.webkit.org/builders/Windows%207%20Release%20(Tests)/builds/14956
2512
2513         Reviewed by Dan Bates.
2514
2515         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
2516         (Builder.prototype.getNumberOfFailingTests): If it looks like all tests passed, but
2517         run-webkit-tests took less than 10 seconds to run, assume that some weird error occurred
2518         that caused it not to run any tests at all (as happened for a while due to
2519         <http://webkit.org/b/64988>). Bumped the cache version to evict old, buggy cached data.
2520
2521         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
2522         Test for the above.
2523
2524         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
2525         (LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy cached data.
2526
2527 2011-08-16  Adam Barth  <abarth@webkit.org>
2528
2529         Add a CG qualifier similar to the GPU qualifier
2530         https://bugs.webkit.org/show_bug.cgi?id=66359
2531
2532         Reviewed by Eric Seidel.
2533
2534         Once we have a Skia configuration on Chromium Mac, we'll use this CG
2535         qualifier to note that expectations apply only to the CG configuration.
2536
2537         * Scripts/webkitpy/layout_tests/port/chromium.py:
2538         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2539
2540 2011-08-16  Eric Seidel  <eric@webkit.org>
2541
2542         REGRESSION(92717): WinPort needs to parse version information from port_name
2543         https://bugs.webkit.org/show_bug.cgi?id=66325
2544
2545         Unreviewed.  Fixing an exception/typo seen on the bots (and testing to make sure it works).
2546
2547         * Scripts/webkitpy/layout_tests/port/mac.py:
2548         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2549
2550 2011-08-16  Adam Barth  <abarth@webkit.org>
2551
2552         Change webkit-patch analyze-baselines to print in a more unix-friendly way
2553         https://bugs.webkit.org/show_bug.cgi?id=66349
2554
2555         Reviewed by James Robinson.
2556
2557         As requested by jamesr.
2558
2559         * Scripts/webkitpy/tool/commands/rebaseline.py:
2560
2561 2011-08-16  Eric Seidel  <eric@webkit.org>
2562
2563         REGRESSION(92717): WinPort needs to parse version information from port_name
2564         https://bugs.webkit.org/show_bug.cgi?id=66325
2565
2566         Reviewed by Adam Barth.
2567
2568         WinPort didn't have any port_name parsing logic.
2569         Seemed it was best to just share the logic from MacPort.
2570         Sharing the logic from MacPort seemed easiest with a shared superclass.
2571         Once I created ApplePort (the superclass) there was a bunch of logic to share.
2572         I found LeakDetector was just in the way when switching back and forth
2573         between win.py and mac.py so I moved it into its own file.
2574
2575         The only logic change here is that WinPort should now be
2576         able to parse port_name values like MacPort (and other ports)
2577         can.  The fact that ports do this in their constructors is
2578         wrong and a source of many bugs.  But at least now WinPort
2579         matches the status-quo.
2580
2581         * Scripts/webkitpy/layout_tests/port/apple.py: Added.
2582         * Scripts/webkitpy/layout_tests/port/leakdetector.py: Added.
2583         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py: Added.
2584         * Scripts/webkitpy/layout_tests/port/mac.py:
2585         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2586         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2587         * Scripts/webkitpy/layout_tests/port/win.py:
2588         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2589
2590 2011-08-16  Adam Barth  <abarth@webkit.org>
2591
2592         Add webkit-patch analyze-baselines, as requested by jamesr.
2593
2594         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
2595         * Scripts/webkitpy/tool/commands/rebaseline.py:
2596
2597 2011-08-16  Adam Barth  <abarth@webkit.org>
2598
2599         Fold bulk-optimize-baselines into optimize-baselines
2600         https://bugs.webkit.org/show_bug.cgi?id=66345
2601
2602         Reviewed by James Robinson.
2603
2604         bulk-optimize-baselines is now a superset of optimize-baselines, so
2605         they can be combined.
2606
2607         * Scripts/webkitpy/tool/commands/rebaseline.py:
2608
2609 2011-08-16  Adam Barth  <abarth@webkit.org>
2610
2611         Move chromium-mac to chromium-cg-mac to prepare for Skia switchover
2612         https://bugs.webkit.org/show_bug.cgi?id=66334
2613
2614         Reviewed by Tony Chang.
2615
2616         This patch moves us closer to switching the Chromium port from
2617         CoreGraphics to Skia.  This patch teaches our tools that the current
2618         Chromium Mac configuration is actually chromium-cg-mac, which makes
2619         room for a future chromium-mac configuration that uses Skia.
2620
2621         Shortly after this patch lands, I'll do a server-side move of the
2622         chromium-mac and chromium-mac-leopard directories to chromium-cg-mac
2623         and chromium-cg-mac-leopard.
2624
2625         * BuildSlaveSupport/build.webkit.org-config/config.json:
2626         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
2627         * Scripts/webkitpy/common/config/build.py:
2628         * Scripts/webkitpy/common/config/build_unittest.py:
2629         * Scripts/webkitpy/layout_tests/port/base.py:
2630         * Scripts/webkitpy/layout_tests/port/builders.py:
2631         * Scripts/webkitpy/layout_tests/port/chromium.py:
2632         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2633         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2634         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2635         * Scripts/webkitpy/layout_tests/port/factory.py:
2636         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2637         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2638         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2639         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2640         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
2641         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2642         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2643
2644 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
2645
2646         garden-o-matic frontend needs a friendly relative time description method.
2647         https://bugs.webkit.org/show_bug.cgi?id=66324
2648
2649         Reviewed by Adam Barth.
2650
2651         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added base.relativizeTime method.
2652         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added unit tests.
2653         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Wired up Time widget to use it.
2654
2655 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
2656
2657         Summary view should not add multiple entries for the same test failure.
2658         https://bugs.webkit.org/show_bug.cgi?id=66318
2659
2660         Reviewed by Adam Barth.
2661
2662         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Added a simplistic updating button.
2663         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added ways to check for
2664             equality of ui.notifications.FailingTest, and whether ui.notifications.TestFailures already contains a given failure analysis.
2665         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added tests.
2666
2667 2011-08-16  Adam Roben  <aroben@apple.com>
2668
2669         Teach TestFailures that tests that have failed or passed many times in a row are not flaky
2670
2671         The basic strategy here is that once a test has failed or passed many times in a row we
2672         never again consider it as a possibly flaky test. It's a simple strategy but seems to result
2673         in many fewer false positives than our current behavior.
2674
2675         Fixes <http://webkit.org/b/66327> TestFailures page considers far too many tests to be
2676         flaky, including tests that failed for a while but then were fixed
2677
2678         Reviewed by Dan Bates.
2679
2680         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:
2681         (FlakyLayoutTestDetector): Initialize new _buildCount property, which is used to track the
2682         number of non-too-many-failure builds we've seen.
2683         (FlakyLayoutTestDetector.prototype.incorporateTestResults): Don't track tests which haven't
2684         failed in the _maximumFailOrPassCount most recent builds. For other not-yet-considered-flaky
2685         tests, keep track of how many times they have passed or failed in a row. If they pass or
2686         fail more than _maximumFailOrPassCount times, consider them to be non-flaky. (Once a test is
2687         considered flaky it doesn't matter how many times it passes or fails.)
2688
2689         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js:
2690         Added tests for the above.
2691
2692 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
2693
2694         garden-o-matic needs a summary view with actions for each problem.
2695         https://bugs.webkit.org/show_bug.cgi?id=66144
2696
2697         Reviewed by Adam Barth.
2698
2699         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Added notifications tests.
2700         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Added.
2701         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added.
2702         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added.
2703         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Added.
2704         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Added.
2705
2706 2011-08-16  Dean Jackson  <dino@apple.com>
2707
2708         Adding Ted "hober" O'Connor as a non-committing contributor.
2709
2710         * Scripts/webkitpy/common/config/committers.py:
2711
2712 2011-08-16  Adam Roben  <aroben@apple.com>
2713
2714         Teach TestFailures how to interpret unfinished test runs
2715
2716         Fixes <http://webkit.org/b/66309> TestFailures thinks all tests passed in
2717         http://build.webkit.org/builders/Lion%20Intel%20Debug%20(Tests)/builds/136
2718
2719         Reviewed by David Kilzer.
2720
2721         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
2722         (Builder.prototype.getNumberOfFailingTests): Look for "isFinished" in the layout-test step
2723         rather than "isStarted" so that we don't count builds for which the test run never finished.
2724         Bumped the cache version to evict old, buggy cached data.
2725
2726         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
2727         Added a test for the above, and made a somewhat synthetic test more realistic by including
2728         more of the actual JSON data from build.webkit.org.
2729
2730         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
2731         (LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy
2732         cached data.
2733
2734 2011-08-16  Adam Roben  <aroben@apple.com>
2735
2736         Make Apple's Windows port fall back to Lion results instead of SnowLeopard
2737
2738         Apple's Windows port now uses Lion-era versions of CoreFoundation, ICU, etc., so in theory
2739         should match Lion's behavior.
2740
2741         Fixes <http://webkit.org/b/66302> Apple's Windows port matches Lion for some test results,
2742         but doesn't use Lion results
2743
2744         Reviewed by David Kilzer.
2745
2746         * Scripts/old-run-webkit-tests:
2747         (expectedDirectoryForTest):
2748         * Scripts/webkitpy/layout_tests/port/win.py:
2749         (WinPort.baseline_search_path):
2750         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2751         (WinPortTest.test_baseline_search_path):
2752         Replaced mac-snowleopard with mac-lion.
2753
2754         * Scripts/webkitpy/common/config/build.py:
2755         (_should_file_trigger_build): Added an entry for the LayoutTests/platform/mac-lion
2756         directory, which all Apple Mac platforms and Apple Win platforms could potentially use
2757         results from. Removed Apple Win from being affected by mac-snowleopard changes, since it
2758         will no longer look there for results.
2759
2760         * Scripts/webkitpy/common/config/build_unittest.py:
2761         (ShouldBuildTest.test_should_build): Tests for the above changes.
2762
2763 2011-08-16  Dean Jackson  <dino@apple.com>
2764
2765         Move me from contributor to reviewer.
2766
2767         * Scripts/webkitpy/common/config/committers.py:
2768
2769 2011-08-15  Dimitri Glazkov  <dglazkov@chromium.org>
2770
2771         garden-o-matic frontend needs model.commitDataForRevisionRange function.
2772         https://bugs.webkit.org/show_bug.cgi?id=66252
2773
2774         Reviewed by Adam Barth.
2775
2776         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Added commitDataForRevisionRange method.
2777         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Added tests.
2778
2779 2011-08-15  Dimitri Glazkov  <dglazkov@chromium.org>
2780
2781         garden-o-matic frontend needs a generic way to track updates.
2782         https://bugs.webkit.org/show_bug.cgi?id=66245
2783
2784         Reviewed by Adam Barth.
2785
2786         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added UpdateTracker.
2787         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added tests.
2788
2789 2011-08-15  Adam Roben  <aroben@apple.com>
2790
2791         Teach TestWebKitAPI/gtest how to print JavaScript failures nicely
2792
2793         Failures now give output of the form: foo should be bar but is baz
2794
2795         Fixes <http://webkit.org/b/66240> It's hard to tell what the actual result of a failed JS
2796         test is in TestWebKitAPI's output
2797
2798         Reviewed by David Levin.
2799
2800         * TestWebKitAPI/JavaScriptTest.cpp:
2801         (TestWebKitAPI::JavaScriptCallbackContext::JavaScriptCallbackContext): Removed now-unused
2802         members.
2803         (TestWebKitAPI::javaScriptCallback): Changed to just store the result string in the context
2804         object, rather than doing any testing of it here.
2805         (TestWebKitAPI::runJSTest): Made this function a gtest predicate-formatter. This allows us
2806         to use a pretty error message when the test fails.
2807
2808         * TestWebKitAPI/JavaScriptTest.h: Changed runJSTest to a predicate-formatter, and added nice
2809         gtest-style macros that wrap it.
2810
2811         * TestWebKitAPI/Test.h: Removed now-unused TEST_ASSERT_RETURN.
2812
2813         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
2814         (TestWebKitAPI::TEST): Changed to use the new macros.
2815
2816         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
2817         (TestWebKitAPI::createSessionStateContainingFormData): Ditto. Note that this function no
2818         longer returns 0 when the JS test fails. That shouldn't have any effect on whether or not
2819         the test passes, though. Returning early seems to have been an unnecessary optimization.
2820
2821         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2822         (TestWebKitAPI::TEST): Changed to use the new macros.
2823
2824 2011-08-15  Eric Seidel  <eric@webkit.org>
2825
2826         Move the Leaks bot back to ORWT until I can fix LeaksViewer regressions filed by Adam Roben in bug 66227 and 66228.
2827
2828         Unreviewed.
2829
2830         * Scripts/run-webkit-tests:
2831         (usingLeaks):
2832         (useNewRunWebKitTests):
2833
2834 2011-08-14  Adam Barth  <abarth@webkit.org>
2835
2836         Switch results detail view over to new-style object-oriented UI widgets
2837         https://bugs.webkit.org/show_bug.cgi?id=66200
2838
2839         Reviewed by Dimitri Glazkov.
2840
2841         This patch replaces my goofy template-based UI for the results
2842         comparison screen with new object-oriented UI widgets.
2843
2844         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2845         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
2846         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2847         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
2848         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
2849         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js: Added.
2850         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
2851
2852 2011-08-13  Dimitri Glazkov  <dglazkov@chromium.org>
2853
2854         garden-o-matic's analyzeUnexpectedFailures needs a completion callback.
2855         https://bugs.webkit.org/show_bug.cgi?id=66166
2856
2857         Also changed base.RequestTracker to:
2858         a) fire callback immediately if requestsInFlight is 0;
2859         b) not barf if callback is not supplied.
2860
2861         Reviewed by Adam Barth.
2862
2863         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Started using completion callback.
2864         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Added completion callback.
2865         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Changed RequestTracker.
2866         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittest.js: Added unit tests.
2867
2868 2011-08-12  Mark Rowe  <mrowe@apple.com>
2869
2870         Be more forward-looking in the choice of compiler.
2871
2872         Rubber-stamped by Jon Honeycutt.
2873
2874         * DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig:
2875         * MiniBrowser/Configurations/CompilerVersion.xcconfig:
2876         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
2877         * WebKitTestRunner/Configurations/CompilerVersion.xcconfig:
2878
2879 2011-08-12  Sadrul Habib Chowdhury  <sadrul@chromium.org>
2880
2881         DRT: Add support for gesture events.
2882         https://bugs.webkit.org/show_bug.cgi?id=66105
2883
2884         Reviewed by Darin Fisher.
2885
2886         * DumpRenderTree/chromium/EventSender.cpp:
2887         (EventSender::EventSender):
2888         (EventSender::gestureScrollBegin):
2889         (EventSender::gestureScrollEnd):
2890         (EventSender::gestureTap):
2891         (EventSender::gestureEvent):
2892         * DumpRenderTree/chromium/EventSender.h:
2893
2894 2011-08-12  Andy Estes  <aestes@apple.com>
2895
2896         allowRoundingHacksCallback uses the wrong argument for 'thisObject'.
2897         https://bugs.webkit.org/show_bug.cgi?id=66158
2898
2899         Reviewed by Dan Bernstein.
2900
2901         * DumpRenderTree/LayoutTestController.cpp:
2902         (allowRoundingHacksCallback): The third argument is the 'this'
2903         JSObjectRef, not the second.
2904
2905 2011-08-12  Andy Estes  <aestes@apple.com>
2906
2907         Cancel in onbeforeunload dialog sometime causes a button to stop working.
2908         https://bugs.webkit.org/show_bug.cgi?id=26211
2909
2910         Reviewed by Alexey Proskuryakov.
2911
2912         Implement a new LayoutTestController method that a test can call to set
2913         the return value of DumpRenderTree's beforeunload UI delegate.
2914
2915         * DumpRenderTree/LayoutTestController.cpp:
2916         (LayoutTestController::LayoutTestController): Initialize
2917         m_shouldStayOnPageAfterHandlingBeforeUnload.
2918         (setShouldStayOnPageAfterHandlingBeforeUnloadCallback): Call
2919         LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload().
2920         (LayoutTestController::staticFunctions): Register
2921         'setShouldStayOnPageAfterHandlingBeforeUnload' as a static function.
2922         * DumpRenderTree/LayoutTestController.h: 
2923         (LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload):
2924         (LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
2925         * DumpRenderTree/chromium/LayoutTestController.cpp:
2926         (LayoutTestController::LayoutTestController): Initialize
2927         m_shouldStayOnPageAfterHandlingBeforeUnload and bind
2928         'setShouldStayOnPageAfterHandlingBeforeUnload' to its c++ setter.
2929         (LayoutTestController::reset): Reset
2930         m_shouldStayOnPageAfterHandlingBeforeUnload to false.
2931         (LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
2932         Set m_shouldStayOnPageAfterHandlingBeforeUnload to the value passed in
2933         from JavaScript.
2934         * DumpRenderTree/chromium/LayoutTestController.h:
2935         (LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload):
2936         * DumpRenderTree/chromium/WebViewHost.cpp:
2937         (WebViewHost::runModalBeforeUnloadDialog): Add the correct logging and
2938         return the inverse of
2939         LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload().
2940         * DumpRenderTree/mac/UIDelegate.mm:
2941         (-[UIDelegate webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:]): Ditto.
2942         * DumpRenderTree/win/UIDelegate.cpp:
2943         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
2944         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2945         Define setShouldStayOnPageAfterHandlingBeforeUnload().
2946         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2947         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue): Post a message
2948         to the Test Controller telling it what value it should return in its
2949         onbeforeunload UI delegate.
2950         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2951         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2952         (WTR::LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
2953         Call InjectedBundle::postNewBeforeUnloadReturnValue().
2954         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2955         * WebKitTestRunner/TestController.cpp:
2956         (WTR::TestController::TestController): Initialize
2957         m_beforeUnloadReturnValue to true.
2958         (WTR::runBeforeUnloadConfirmPanel): Add the correct logging and return
2959         the value of TestController::beforeUnloadReturnValue().
2960         (WTR::TestController::resetStateToConsistentValues): Reset
2961         m_beforeUnloadReturnValue to true.
2962         * WebKitTestRunner/TestController.h:
2963         (WTR::TestController::beforeUnloadReturnValue):
2964         (WTR::TestController::setBeforeUnloadReturnValue):
2965         * WebKitTestRunner/TestInvocation.cpp:
2966         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the
2967         message posted from the injected bundle by retrieving the message body
2968         as a WKBoolean and calling TestController::setBeforeUnloadReturnValue().
2969
2970 2011-08-12  Sam Weinig  <sam@webkit.org>
2971
2972         Move compiler specific macros to their own header
2973         https://bugs.webkit.org/show_bug.cgi?id=66119
2974
2975         Reviewed by Anders Carlsson.
2976
2977         * DumpRenderTree/ForwardingHeaders/wtf/Compiler.h: Added.
2978
2979 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
2980
2981         Add a way to extend DOM objects in garden-o-matic.
2982         https://bugs.webkit.org/show_bug.cgi?id=66096
2983
2984         Reviewed by Adam Barth.
2985
2986         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added base.extends.
2987         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added tests.
2988
2989 2011-08-11  MORITA Hajime  <morrita@google.com>
2990
2991         [Chromium][DRT] editing/spelling/spelling-backspace-between-lines.html fails
2992         https://bugs.webkit.org/show_bug.cgi?id=45438
2993
2994         Reviewed by Kent Tamura.
2995
2996         MockSpellCheck was assuming the input of spellCheckWord() is a word.
2997         But it can be a series of word. This change made spellCheckWord()
2998         understand simple word boundary which appears in tests.
2999         
3000         * DumpRenderTree/chromium/MockSpellCheck.cpp:
3001         (MockSpellCheck::spellCheckWord):
3002
3003 2011-08-11  Mark Rowe  <mrowe@apple.com>
3004
3005         Rework some Makefile logic to remove a double-negative.
3006
3007         Reviewed by Jon Honeycutt.
3008
3009         * DumpRenderTree/mac/PerlSupport/Makefile:
3010
3011 2011-08-11  Anders Carlsson  <andersca@apple.com>
3012
3013         Add a FIXME.
3014
3015         * TestWebKitAPI/TestsController.cpp:
3016         (TestWebKitAPI::TestsController::TestsController):
3017
3018 2011-08-11  Anders Carlsson  <andersca@apple.com>
3019
3020         Initialize threading before running any tests
3021         https://bugs.webkit.org/show_bug.cgi?id=66112
3022
3023         Reviewed by Adam Barth.
3024
3025         * TestWebKitAPI/TestsController.cpp:
3026         (TestWebKitAPI::TestsController::TestsController):
3027
3028 2011-08-11  Adam Barth  <abarth@webkit.org>
3029
3030         Add unexpected-passes.html to TestFailures for marking tests as passing
3031         https://bugs.webkit.org/show_bug.cgi?id=66102
3032
3033         Reviewed by Dimitri Glazkov.
3034
3035         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3036         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
3037             - Move some code into the library so it can be shared.
3038         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
3039         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
3040         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
3041             - Add round-trip unit tests.
3042         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html: Added.
3043         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js: Added.
3044             - I'm not entirely sure this feature should remain a separate HTML
3045               file, but it seemed better than cluttering up the main HTML file
3046               with too much extra stuff.
3047         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3048         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3049             - The gardening server couldn't handle adding PASS expectations.  Now it can.
3050
3051 2011-08-11  Eric Seidel  <eric@webkit.org>
3052
3053         NRWT has wrong fallback order for Mac now that Lion exists
3054         https://bugs.webkit.org/show_bug.cgi?id=66093
3055
3056         Reviewed by Adam Barth.
3057
3058         ORWT used a different system for fallback orders than NRWT did.
3059         I moved win.py to match ORWT fallback orders in bug 64486.
3060         This bug moves mac.py to match ORWT fallback order
3061         and adds 'lion' as a supported OS version.
3062
3063         Because ChromiumMac shares OS version detection code with AppleMac
3064         this also added support for 'lion' to chromium mac.  Hopefully that's a good thing.
3065
3066         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3067         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3068         * Scripts/webkitpy/layout_tests/port/mac.py:
3069         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3070         * Scripts/webkitpy/layout_tests/port/win.py:
3071
3072 2011-08-11  Adam Barth  <abarth@webkit.org>
3073
3074         Update test results now that we use absolute URLs.
3075
3076         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js:
3077
3078 2011-08-11  Adam Barth  <abarth@webkit.org>
3079
3080         garden-o-matic should be able to determine when tests unexpectedly pass
3081         https://bugs.webkit.org/show_bug.cgi?id=66092
3082
3083         Reviewed by Dimitri Glazkov.
3084
3085         This patch just contains the library methods for extracting this
3086         information.  I'll add some UI in a subsequent patch.
3087
3088         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
3089         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
3090
3091 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
3092
3093         New expectation entries should be placed next to existing ones.
3094         https://bugs.webkit.org/show_bug.cgi?id=66066
3095
3096         Reviewed by Adam Barth.
3097
3098         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Added the notion of insertion point,
3099             which is computed as the last found reference to the same test.
3100         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added and adjusted unit tests.
3101
3102 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
3103
3104         Unreviewed, rolling out r92847.
3105         http://trac.webkit.org/changeset/92847
3106         https://bugs.webkit.org/show_bug.cgi?id=65986
3107
3108         Broke check-webkit-style
3109
3110         * Scripts/webkitpy/style/checker.py:
3111         * Scripts/webkitpy/style/checker_unittest.py:
3112
3113 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
3114
3115         Unreviewed, rolling out r92847.
3116         http://trac.webkit.org/changeset/92847
3117         https://bugs.webkit.org/show_bug.cgi?id=65986
3118
3119         Broke check-webkit-style
3120
3121         * Scripts/webkitpy/style/checker.py:
3122         * Scripts/webkitpy/style/checker_unittest.py:
3123
3124 2011-08-11  Pierre Rossi  <pierre.rossi@gmail.com>
3125
3126         [Qt] autotests shouldn't require config.h in the style check
3127         https://bugs.webkit.org/show_bug.cgi?id=65986
3128
3129         Remove the include rules from the style-check for Qt tests.
3130         Since for the most part it's just a matter of using the
3131         API provided by QtWebKit, enforcing the WebCore set of rules
3132         only seems to make sense in the case of MIMESniffing.
3133
3134         Reviewed by Benjamin Poulain.
3135
3136         * Scripts/webkitpy/style/checker.py:
3137         * Scripts/webkitpy/style/checker_unittest.py:
3138
3139 2011-08-11  Zsolt Fehér  <h490267@stud.u-szeged.hu>
3140
3141         [WK2] Implement waitForPolicyDelegate
3142         https://bugs.webkit.org/show_bug.cgi?id=42330
3143
3144         Reviewed by Csaba Osztrogonác.
3145
3146         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3147         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3148         (WTR::navigationTypeToString):
3149         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
3150         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3151         (WTR::LayoutTestController::LayoutTestController):
3152         (WTR::LayoutTestController::setCustomPolicyDelegate):
3153         (WTR::LayoutTestController::waitForPolicyDelegate):
3154         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3155         (WTR::LayoutTestController::isPolicyDelegateEnabled):
3156         (WTR::LayoutTestController::isPolicyDelegatePermissive):
3157
3158 2011-08-11  Adam Barth  <abarth@webkit.org>
3159
3160         rebaseline-expectations should use the release bots, not the debug
3161         bots.  The debug bots don't all run all the tests.  Also, delay
3162         updating test_expectations a long as possible to avoid clearing out
3163         lines that we'll need for other ports.
3164
3165         * Scripts/webkitpy/layout_tests/port/builders.py:
3166         * Scripts/webkitpy/tool/commands/rebaseline.py:
3167         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3168
3169 2011-08-10  Ryosuke Niwa  <rniwa@webkit.org>
3170
3171         r92792 inadvertently removed PlatformSpecificScheduler for all Snow Leopard bots.
3172         Revert it partially so that the remaining Snow Leopard bots can fulfill their duty.
3173
3174         * BuildSlaveSupport/build.webkit.org-config/config.json:
3175
3176 2011-08-10  Eric Seidel  <eric@webkit.org>
3177
3178         new-run-webkit-test's WinPort has no fallback logic
3179         https://bugs.webkit.org/show_bug.cgi?id=64486
3180
3181         Unreviewed.
3182
3183         Turns out that we've long had a subtle bug whereby if you didn't
3184         already have DumpRenderTree built, we might end up running unsupported tests
3185         because the DumpRenderTree --print-supported-features check would silently fail.
3186
3187         When I moved the call from using popen to using Executive.run_command, this silent
3188         failure became noisy.  (Breaking some bots.)
3189
3190         This re-orders our steps so that we always build DRT before collecting expectations,
3191         as well as adds a warning message when DumpRenderTree can't be found.
3192
3193         * Scripts/webkitpy/layout_tests/port/webkit.py:
3194         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3195
3196 2011-08-10  Eric Seidel  <eric@webkit.org>
3197
3198         new-run-webkit-test's WinPort has no fallback logic
3199         https://bugs.webkit.org/show_bug.cgi?id=64486
3200
3201         Unreviewed.  Fix test-webkitpy under Python 2.5.
3202
3203         * Scripts/webkitpy/layout_tests/port/win.py:
3204
3205 2011-08-10  Benjamin Poulain  <benjamin@webkit.org>
3206
3207         [Qt][WK2] MiniBrowser is firing twice the QDesktopWebView::mousePressEvent method
3208         https://bugs.webkit.org/show_bug.cgi?id=65875
3209
3210         Reviewed by Kenneth Rohde Christiansen.
3211
3212         For some reason, QWidget send fake mouse event on some platform, under certains conditions.
3213
3214         This causes mouse events to be sent twice in some cases. We work around the problem
3215         by defining the first touch point to be a primary touch point (case which hit some
3216         weird condition in QWidget, skipping the generation of fake mouse events).
3217
3218         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3219         (MiniBrowserApplication::notify):
3220
3221 2011-08-10  David Hyatt  <hyatt@apple.com>
3222
3223         https://bugs.webkit.org/show_bug.cgi?id=66004
3224
3225         Remove the regions and exclusions bots and also the flags in build-webkit, since I'm just turning
3226         the code on by default.
3227
3228         Reviewed by Adam Roben.
3229
3230         * BuildSlaveSupport/build.webkit.org-config/config.json:
3231         * Scripts/build-webkit:
3232
3233 2011-08-10  Oliver Hunt  <oliver@apple.com>
3234
3235         JSEvaluteScript does not return the correct object when given JSONP data
3236         https://bugs.webkit.org/show_bug.cgi?id=66003
3237
3238         Reviewed by Gavin Barraclough.
3239
3240         Add a test case.
3241
3242         * DumpRenderTree/mac/DumpRenderTree.mm:
3243         (testStringByEvaluatingJavaScriptFromString):
3244
3245 2011-08-10  Eric Seidel  <eric@webkit.org>
3246
3247         WIN: NRWT runs compositing tests on configurations that don't support compositing
3248         https://bugs.webkit.org/show_bug.cgi?id=64472
3249
3250         Reviewed by Adam Barth.
3251
3252         I think the code was just wrong.  It was never splitting the string
3253         into list pieces before.
3254         I've now tested the supported_features code and theoretically it
3255         should now work with Windows DRT.
3256
3257         I also made the list-lookup functions always return lists, to make
3258         it possible to clean up the list-transform code in the future
3259         (I opted not to do that cleanup in this patch, but at least now
3260         both types of feature lookup functions match return types.)
3261
3262         * Scripts/webkitpy/layout_tests/port/webkit.py:
3263         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3264
3265 2011-08-10  Eric Seidel  <eric@webkit.org>
3266
3267         Clean up ChromiumDriver a little
3268         https://bugs.webkit.org/show_bug.cgi?id=65995
3269
3270         Unreviewed.
3271
3272         Fix NRWT for chromium.  Silly python.
3273
3274         * Scripts/webkitpy/layout_tests/port/chromium.py:
3275
3276 2011-08-10  Eric Seidel  <eric@webkit.org>
3277
3278         Clean up ChromiumDriver a little
3279         https://bugs.webkit.org/show_bug.cgi?id=65995
3280
3281         Reviewed by Adam Barth.
3282
3283         - We no longer support threading, so remove threading specific code.
3284         - Add FIXMEs about using ServerProcess instead.
3285         - Condense option-mapping if-cascade into a for loop.
3286         - Unindent long if blocks by using early return.
3287         - Unwrap lines which are needlessly wrapped.
3288
3289         There should be no functional changes here, just code cleanup/dead-code removal.
3290
3291         * Scripts/webkitpy/layout_tests/port/chromium.py:
3292
3293 2011-08-10  Dimitri Glazkov  <dglazkov@chromium.org>
3294
3295         Unmuddle construction options for TestConfiguration.
3296         https://bugs.webkit.org/show_bug.cgi?id=65988
3297
3298         The TestConfiguration instance is now constructed only using actual values.
3299         Port-based construction is split into a "from_port" class method.
3300
3301         Reviewed by Eric Seidel.
3302
3303         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added TestConfiguration.from_port
3304         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Adjusted code to accommodate the change.
3305         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Ditto.
3306         * Scripts/webkitpy/layout_tests/port/base.py: Ditto.
3307         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Ditto.
3308
3309 2011-08-10  Eric Seidel  <eric@webkit.org>
3310
3311         Leaks bot shows python logging prefixes as part of summary display
3312         https://bugs.webkit.org/show_bug.cgi?id=65931
3313
3314         Reviewed by Adam Barth.
3315
3316         The big part of this change is adding a unittesting system for
3317         master.cfg, so mere-mortals can make changes to build.webkit.org
3318         with greatly-reduced risk of breaking the world.
3319
3320         Turns out that in typing up my trival logging fix I made 2 typos,
3321         so hopefully the hour spent getting master.cfg to load was worth it. :)
3322
3323         I also tried to make mastercfg_unittest run as part of test-webkitpy
3324         but right now test-webkitpy requires that unittest files be located in
3325         a module-name-compatible directory.  'build.webkit.org-config' is not
3326         a valid module name.
3327
3328         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3329          - Fixed _parseNewRunWebKitTestsOutput to strip NRWT's python formatter prefix
3330            by using a new _strip_python_logging_prefix function.
3331          - Also fixed this function to file to work with a more modern
3332            simplejson version (which returns unicode objects instead of str objects)
3333            and filed a related bug with buildbot.net due to their handling of unicode builder names.
3334         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Added.
3335          - BuildBotConfigLoader is a huge pile of code just to get master.cfg to load.
3336          - The actual tiny unittest of the new _parseNewRunWebKitTestsOutput logic.
3337         * Scripts/webkitpy/thirdparty/__init__.py:
3338          - Add autoinstallation of buildbot (and jinja2) for use by mastercfg_unittest.py
3339
3340 2011-08-09  Dimitri Glazkov  <dglazkov@chromium.org>
3341
3342         garden-o-matic should extrapolate failures given a set of known results
3343         https://bugs.webkit.org/show_bug.cgi?id=65882
3344
3345         Reviewed by Adam Barth.
3346
3347         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Spuriously covered my old sins.
3348         * Scripts/webkitpy/layout_tests/port/builders.py: Augmented builders dictionary to contain build coverage specifiers,
3349             adjusted all call sites.
3350         * Scripts/webkitpy/tool/servers/gardeningserver.py: Added BuildCoverageExtrapolator, a thing that
3351             makes wider net for specific failures.
3352         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added unit tests.
3353
3354 2011-08-10  Adam Barth  <abarth@webkit.org>
3355
3356         The URL we were computing for retrieving baselines was missing a slash
3357         character because our mocks had an extra slash character.  I've
3358         corrected both the code and the mock.
3359
3360         * Scripts/webkitpy/tool/commands/rebaseline.py:
3361         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3362         * Scripts/webkitpy/tool/mocktool.py:
3363
3364 2011-08-09  Adam Barth  <abarth@webkit.org>
3365
3366         Move the quote mark to the right place.
3367
3368         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
3369
3370 2011-08-09  Adam Barth  <abarth@webkit.org>
3371
3372         garden-o-matic should use huerstics to narrow regression range
3373         https://bugs.webkit.org/show_bug.cgi?id=65948
3374
3375         Reviewed by Dimitri Glazkov.
3376
3377         When analyzing a regression range, if one of the commit messages
3378         mentions the test in question, we now hueristically assume that
3379         revision caused the failure.  (I'm shamelessly stealing this idea from
3380         TestFailures.)
3381
3382         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
3383
3384 2011-07-13  Eric Seidel  <eric@webkit.org>
3385
3386         new-run-webkit-test's WinPort has no fallback logic
3387         https://bugs.webkit.org/show_bug.cgi?id=64486
3388
3389         Reviewed by Adam Roben.
3390
3391         I've tried to write a patch for bug 64439 twice now, and both times
3392         I've ended up re-writing half the port system.  So I'm breaking
3393         things up into smaller pieces, this being the first.
3394
3395         WinPort still does not have any port_name parsing, so when instantiated
3396         with the name "win-xp" (i.e. by the rebaseline server) it will just behave as the 'win' port.
3397         I'll fix this in a second pass when I standardize port_name parsing for all webkit ports.
3398
3399         Otherwise this should "just work" for windows.  I've not been able to test the
3400         version detection on my mac, but the unit tests show the code behaving as designed.
3401
3402         * Scripts/webkitpy/layout_tests/port/win.py:
3403         * Scripts/webkitpy/layout_tests/port/win_unittest.py: Added.
3404
3405 2011-08-09  Adam Barth  <abarth@webkit.org>
3406
3407         Teach build.webkit.org's garden-o-matic how to talk to the local server
3408         https://bugs.webkit.org/show_bug.cgi?id=65940
3409
3410         Reviewed by Dimitri Glazkov.
3411
3412         After this patch, the version of garden-o-matic on build.webkit.org is
3413         fully functional.  It can interact with the local server via CORS.
3414
3415         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
3416         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
3417         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
3418         * Scripts/webkitpy/tool/commands/gardenomatic.py:
3419         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3420
3421 2011-08-09  Adam Barth  <abarth@webkit.org>
3422
3423         Enable CORS for garden-o-matic
3424         https://bugs.webkit.org/show_bug.cgi?id=65936
3425
3426         Reviewed by Dimitri Glazkov.
3427
3428         This patch will allow the hosted instance of garden-o-matic to
3429         communicate with the local server.
3430
3431         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3432         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
3433
3434 2011-08-09  Adam Barth  <abarth@webkit.org>
3435
3436         Upgrade jquery in TestFailures
3437         https://bugs.webkit.org/show_bug.cgi?id=65935
3438
3439         Reviewed by Dimitri Glazkov.
3440
3441         Upgrade to a newer version of jQuery with better support for CORS and CSP.
3442
3443         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3444         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
3445         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
3446
3447 2011-08-09  Sheriff Bot  <webkit.review.bot@gmail.com>
3448
3449         Unreviewed, rolling out r92683.
3450         http://trac.webkit.org/changeset/92683
3451         https://bugs.webkit.org/show_bug.cgi?id=65921
3452
3453          "Breaks Qt --minimal build. Revert pending update of the Qt
3454         minimal configuration" (Requested by simathur on #webkit).
3455
3456         * QtTestBrowser/cookiejar.cpp:
3457         (TestBrowserCookieJar::TestBrowserCookieJar):
3458         * QtTestBrowser/launcherwindow.cpp:
3459         (LauncherWindow::createChrome):
3460         (LauncherWindow::setDiskCache):
3461         * QtTestBrowser/main.cpp:
3462         (LauncherApplication::handleUserOptions):
3463         * QtTestBrowser/webpage.cpp:
3464         (WebPage::openUrlInDefaultBrowser):
3465
3466 2011-08-09  Siddharth Mathur  <siddharth.mathur@nokia.com>
3467
3468         [Qt] Simplify code by removing QT_NO_DESKTOPSERVICES and QT_NO_NETWORKDISKCACHE
3469         https://bugs.webkit.org/show_bug.cgi?id=65880
3470
3471         Reviewed by Andreas Kling.
3472
3473         QDesktopServices and QNetworkDiskCache have been around for a while now. Kill flags which 
3474         check for their feature flags. Assume that any reasonable Qt build provides them. 
3475         * QtTestBrowser/cookiejar.cpp:
3476         (TestBrowserCookieJar::TestBrowserCookieJar):
3477         * QtTestBrowser/launcherwindow.cpp:
3478         (LauncherWindow::createChrome):
3479         (LauncherWindow::setDiskCache):
3480         * QtTestBrowser/main.cpp:
3481         (LauncherApplication::handleUserOptions):
3482         * QtTestBrowser/webpage.cpp:
3483         (WebPage::openUrlInDefaultBrowser):
3484
3485 2011-08-09  Adam Barth  <abarth@webkit.org>
3486
3487         BaselineOptimizer created the wrong baseline for fast/js/regexp-overflow.html
3488         https://bugs.webkit.org/show_bug.cgi?id=65891
3489
3490         Reviewed by Eric Seidel.
3491
3492         The problem was that platform/chromium contained a bogus expectation
3493         file that needed to be removed, but by the time we got around to
3494         removing it, we'd already moved the correct baseline into its place.
3495         After this patch, we copy the gold results into memory before
3496         reshuffling things on disk (and we delete bad things before adding good
3497         things).
3498
3499         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
3500         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
3501
3502 2011-08-08  Adam Barth  <abarth@webkit.org>
3503
3504         Chromium Windows bots can't figure out what SVN revision they're running
3505         https://bugs.webkit.org/show_bug.cgi?id=65893
3506
3507         Reviewed by Eric Seidel.
3508
3509         The comment in _engage_awesome_windows_hacks explains why we're making
3510         this change.  It's ugly and rediculous, but this approach seems better
3511         than using shell=True when calling popen.
3512
3513         * Scripts/webkitpy/common/checkout/scm/svn.py:
3514         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3515
3516 2011-08-08  Adam Barth  <abarth@webkit.org>
3517
3518         Remove deduplicate-tests
3519         https://bugs.webkit.org/show_bug.cgi?id=65886
3520
3521         Reviewed by Tony Chang.
3522
3523         This script is redundant with "webkit-patch bulk-optimize-baselines",
3524         which can find many more duplicates than deduplicate-tests because
3525         bulk-optimize-baselines can move results around whereas
3526         deduplicate-tests can only remove results.
3527
3528         * Scripts/deduplicate-tests: Removed.
3529         * Scripts/webkitpy/to_be_moved/deduplicate_tests.py: Removed.
3530         * Scripts/webkitpy/to_be_moved/deduplicate_tests_unittest.py: Removed.
3531
3532 2011-08-08  Adam Barth  <abarth@webkit.org>
3533
3534         scm.delete should delete empty parent directories as well
3535         https://bugs.webkit.org/show_bug.cgi?id=65878
3536
3537         Reviewed by Eric Seidel.
3538
3539         This behavior makes SVN match GIT (which has no concept of empty
3540         directories).  This bug comes up a lot when optimizing baselines, which
3541         often create empty directories when we're able to optimize everything
3542         out of a given folder.
3543
3544         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3545         * Scripts/webkitpy/common/checkout/scm/svn.py:
3546
3547 2011-08-08  Lucas Forschler  <lforschler@apple.com>
3548
3549         Add triggers for Lion WK2 test bots.
3550
3551         Reviewed by Stephanie Lewis.
3552
3553         * BuildSlaveSupport/build.webkit.org-config/config.json:
3554
3555 2011-08-08  Adam Barth  <abarth@webkit.org>
3556
3557         bulk-optimize-baselines should take directories on the command line
3558         https://bugs.webkit.org/show_bug.cgi?id=65879
3559
3560         Reviewed by Dimitri Glazkov.
3561
3562         Passing lists of tests via stdin is a pain.  It's easier if the command
3563         takes a list of tests on the command line, like run-webkit-tests.
3564
3565         * Scripts/webkitpy/tool/commands/rebaseline.py:
3566
3567 2011-08-08  Adam Barth  <abarth@webkit.org>
3568
3569         Deprecate rebaseline-chromium-webkit-tests
3