Resource Load Statistics: Grandfather domains for existing data records
[WebKit-https.git] / Tools / ChangeLog
1 2017-05-17  John Wilander  <wilander@apple.com>
2
3         Resource Load Statistics: Grandfather domains for existing data records
4         https://bugs.webkit.org/show_bug.cgi?id=172155
5         <rdar://problem/24913532>
6
7         Reviewed by Alex Christensen.
8
9         Adds test infrastructure needed for the added functionality.
10
11         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
12         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
13         (WTR::InjectedBundle::didReceiveMessageToPage):
14         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
15         (WTR::TestRunner::setStatisticsGrandfathered):
16         (WTR::TestRunner::isStatisticsGrandfathered):
17         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
18         (WTR::TestRunner::statisticsDidScanDataRecordsCallback):
19         (WTR::TestRunner::setStatisticsGrandfatheringTime):
20         * WebKitTestRunner/InjectedBundle/TestRunner.h:
21         * WebKitTestRunner/TestController.cpp:
22         (WTR::TestController::setStatisticsGrandfathered):
23         (WTR::TestController::isStatisticsGrandfathered):
24         (WTR::TestController::setStatisticsGrandfatheringTime):
25         * WebKitTestRunner/TestController.h:
26         * WebKitTestRunner/TestInvocation.cpp:
27         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
28
29 2017-05-17  Alex Christensen  <achristensen@webkit.org>
30
31         Fix ios-simulator API test after r216977
32         https://bugs.webkit.org/show_bug.cgi?id=171987
33
34         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
35         (TEST):
36         <rdar://problem/32260156> covers the investigation of this, but fixing it is 
37         not as urgent as having the rest of this working. Notably the ephemeral part of the
38         test works, so something is just wrong with the persistent part.
39
40 2017-05-17  Ryan Haddad  <ryanhaddad@apple.com>
41
42         Unreviewed, rolling out r216955.
43
44         This change caused strange behavior with web-platform-tests
45         locally and on EWS.
46
47         Reverted changeset:
48
49         "webkitpy: Start servers before setting-up for testing"
50         https://bugs.webkit.org/show_bug.cgi?id=172176
51         http://trac.webkit.org/changeset/216955
52
53 2017-05-17  Wenson Hsieh  <wenson_hsieh@apple.com>
54
55         A URL type is vended for a non-URL plain text string when starting data interaction
56         https://bugs.webkit.org/show_bug.cgi?id=172228
57         <rdar://problem/32166729>
58
59         Reviewed by Andy Estes.
60
61         Adds two new data interaction tests, SinglePlainTextWordTypeIdentifiers and SinglePlainTextURLTypeIdentifiers,
62         to verify that a URL UTI is not vended when beginning a data interaction on a single word, but that a URL is
63         still vended when beginning data interaction on something that resembles a link.
64
65         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
66
67 2017-05-17  David Kilzer  <ddkilzer@apple.com>
68
69         BlobDataFileReference::generateReplacementFile() should use mkstemp()
70         <https://webkit.org/b/172192>
71
72         Reviewed by Brent Fulgham.
73
74         * Scripts/webkitpy/style/checkers/cpp.py:
75         (check_language): Add check for mktemp.
76         (CppChecker): Add 'security/temp_file' category.
77         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
78         (CppStyleTest.test_insecure_temp_file): Add test.
79
80 2017-05-17  Devin Rousso  <drousso@apple.com>
81
82         Unreviewed, change my email.
83
84         * Scripts/webkitpy/common/config/contributors.json:
85
86 2017-05-17  Matt Lewis  <jlewis3@apple.com>
87
88         Unreviewed, rolling out r216974.
89
90         Revision caused consistent timeouts on all platforms.
91
92         Reverted changeset:
93
94         "Add a RuntimeEnabledFeature for display: contents, defaulted
95         to false."
96         https://bugs.webkit.org/show_bug.cgi?id=171984
97         http://trac.webkit.org/changeset/216974
98
99 2017-05-17  Alex Christensen  <achristensen@webkit.org>
100
101         Interacting with WKHTTPCookieStores before creating WKWebViews and WKProcessPools should affect cookies used
102         https://bugs.webkit.org/show_bug.cgi?id=171987
103
104         Reviewed by Brady Eidson.
105
106         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
107         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
108         (TEST):
109
110 2017-05-17  Emilio Cobos Álvarez  <ecobos@igalia.com>
111
112         Add a RuntimeEnabledFeature for display: contents, defaulted to false.
113         https://bugs.webkit.org/show_bug.cgi?id=171984
114
115         Reviewed by Antti Koivisto.
116
117         * DumpRenderTree/mac/DumpRenderTree.mm:
118         (enableExperimentalFeatures):
119         * WebKitTestRunner/TestController.cpp:
120         (WTR::TestController::resetPreferencesToConsistentValues):
121
122 2017-05-16  Timothy Horton  <timothy_horton@apple.com>
123
124         Fix the build
125
126         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
127         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
128
129 2017-05-16  Tim Horton  <timothy_horton@apple.com>
130
131         PageVisibilityStateWithWindowChanges tests sometimes time out
132         https://bugs.webkit.org/show_bug.cgi?id=172202
133         <rdar://problem/29653266>
134
135         Reviewed by Dean Jackson.
136
137         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
138         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
139         Make sure the window is miniaturizable, otherwise, in some cases, miniaturize: will not work.
140
141 2017-05-16  Jonathan Bedard  <jbedard@apple.com>
142
143         webkitpy: Start servers before setting-up for testing
144         https://bugs.webkit.org/show_bug.cgi?id=172176
145         <rdar://problem/32225538>
146
147         Reviewed by Alexey Proskuryakov.
148
149         On-device testing requires that servers are started before ports set-up their
150         test environments.
151
152         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
153         (LayoutTestRunner.__init__): Start servers when initializing LayoutTestRunner.
154         (LayoutTestRunner.run_tests): Move the starting of servers to the initializer.
155         * Scripts/webkitpy/layout_tests/controllers/manager.py:
156         (Manager.__init__): Delay construction of the test runner until we can determine
157         if servers need to be started.
158         (Manager.run): Determine if servers need to be started and construct the test runner.
159         (Manager._run_tests): Move the determination of servers to run into Manager.run.
160
161 2017-05-16  Adrian Perez de Castro  <aperez@igalia.com>
162
163         Unreviewed, adding myself to contributors.json
164
165         * Scripts/webkitpy/common/config/contributors.json:
166
167 2017-05-16  Claudio Saavedra  <csaavedra@igalia.com>
168
169         [GTK] Tests that always pass when run alone, but fail in the bots
170         https://bugs.webkit.org/show_bug.cgi?id=168572
171
172         Reviewed by Michael Catanzaro.
173
174         PlatformWebView::viewSupportsOptions() is basically a comparison
175         that checks that the passed options are the ones supported by the
176         web view. There is no reason for them to be implemented for each
177         platform differently. In fact doing so causes issues each time a
178         new option is added, if the corresponding platform implementation
179         is not updated accordingly.
180
181         A consequence of not updating the viewSupportOptions()
182         implementations when new options are added is that tests that need
183         these options might fail if they are executed after a test that
184         didn't need the option, as the webview will be reused even if the
185         option is not supported. This cannot be spotted when running the
186         tests individually. See bug #165133 for other example of the same
187         problem.
188
189         Remove the platform implementations and make the comparison a
190         method of the TestOptions structure, so that the check is in one
191         place. For the time being, only include in the comparison the
192         options that were checked in the mac platform, which seem to be
193         the only ones relevant this far (unless newer ones have also been
194         forgotten).
195
196         * WebKitTestRunner/PlatformWebView.h:
197         (WTR::PlatformWebView::viewSupportsOptions): Use the method
198         defined below.
199         * WebKitTestRunner/TestOptions.h:
200         (WTR::TestOptions::hasSameInitializationOptions): Added.
201         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
202         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
203         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
204         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
205         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
206         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
207         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:
208         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
209
210 2017-05-15  Yusuke Suzuki  <utatane.tea@gmail.com>
211
212         [JSC] Build testapi in non Apple ports
213         https://bugs.webkit.org/show_bug.cgi?id=172103
214
215         Reviewed by Filip Pizlo.
216
217         Now testapi is drived in JSCOnly, GTK and WPE ports too.
218
219         * Scripts/build-jsc:
220         * Scripts/run-javascriptcore-tests:
221
222 2017-05-15  Youenn Fablet  <youenn@apple.com>
223
224         WPT test importer should not account for slow manual tests
225         https://bugs.webkit.org/show_bug.cgi?id=172127
226
227         Reviewed by Ryosuke Niwa.
228
229         Making sure manual tests are not triggering updating tests-options.json file.
230
231         * Scripts/webkitpy/w3c/test_importer.py:
232         (TestImporter.find_importable_tests):
233         (TestImporter._already_identified_as_resource_file):
234         (TestImporter.update_tests_options):
235         * Scripts/webkitpy/w3c/test_importer_unittest.py:
236         (test_manual_slow_test):
237
238 2017-05-15  Jonathan Bedard  <jbedard@apple.com>
239
240         webkitpy: Some versions of simctl do not place parenthesis around runtime identifiers
241         https://bugs.webkit.org/show_bug.cgi?id=172142
242
243         Reviewed by Tim Horton.
244
245         * Scripts/webkitpy/xcode/simulator.py:
246         (Simulator._parse_runtimes): Newer versions of simctl output do not put parenthesis
247         around runtime identifiers.
248         * Scripts/webkitpy/xcode/simulator_unittest.py: Add tests for new simctl output.
249
250 2017-05-15  Ryosuke Niwa  <rniwa@webkit.org>
251
252         Update ARES-6 plan file to use the latest version
253         https://bugs.webkit.org/show_bug.cgi?id=172139
254
255         Reviewed by Keith Miller.
256
257         Include r216538.
258
259         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
260
261 2017-05-15  Jeremy Jones  <jeremyj@apple.com>
262
263         Disable Picture In Picture API tests on unsupported platforms.
264         https://bugs.webkit.org/show_bug.cgi?id=172125
265         rdar://problem/32199477
266
267         Reviewed by Simon Fraser.
268
269         The callbacks and allowing picture-in-picture require new SPI.
270
271         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm:
272
273 2017-05-15  Brady Eidson  <beidson@apple.com>
274
275         [ios-simulator] API test WKWebView.ClearAppCache is failing.
276         https://bugs.webkit.org/show_bug.cgi?id=172120
277
278         Unreviewed test gardening.
279
280         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
281         (TEST): ios-sim needs explicit deleting of the app cache paths that I'd removed in 216805.
282           Restoring that code fixes this.
283
284 2017-05-15  Timothy Horton  <timothy_horton@apple.com>
285
286         Null deref under WebContentReader::readURL when interacting with a file URL
287         https://bugs.webkit.org/show_bug.cgi?id=172045
288         <rdar://problem/25880647>
289
290         Reviewed by Wenson Hsieh.
291
292         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
293         (TestWebKitAPI::TEST):
294         The text of the file URL is pasted because a textual version of it gets
295         onto the pasteboard. However, this test would have crashed before. Also
296         tests that we don't make an <a>.
297
298 2017-05-14  Per Arne Vollan  <pvollan@apple.com>
299
300         [Win] fast/cookies/local-file-can-set-cookies.html is flaky.
301         https://bugs.webkit.org/show_bug.cgi?id=172071
302
303         Reviewed by Alexey Proskuryakov.
304
305         * DumpRenderTree/win/DumpRenderTree.cpp:
306         (resetWebPreferencesToConsistentValues):
307
308 2017-05-14  Chris Dumez  <cdumez@apple.com>
309
310         Drop PassRefPtr class from WTF
311         https://bugs.webkit.org/show_bug.cgi?id=172091
312
313         Reviewed by Alex Christensen.
314
315         Drop API test coverage.
316
317         * TestWebKitAPI/Tests/WTF/Ref.cpp:
318         (TestWebKitAPI::TEST):
319         (TestWebKitAPI::passWithPassRefPtr): Deleted.
320
321 2017-05-13  Eric Carlson  <eric.carlson@apple.com>
322
323         [MediaStream] deviceId constraint doesn't work with getUserMedia
324         https://bugs.webkit.org/show_bug.cgi?id=171877
325         <rdar://problem/31899730>
326
327         Reviewed by Jer Noble.
328
329         The device ID hash salt is now required for getUserMedia to check deviceId constraint, so
330         implement the "checkUserMediaPermission" callback.
331         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
332         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
333         (TestWebKitAPI::checkUserMediaPermissionCallback):
334         (TestWebKitAPI::TEST):
335
336         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm:
337         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
338
339 2017-05-13  Chris Dumez  <cdumez@apple.com>
340
341         Stop using RefPtr::release()
342         https://bugs.webkit.org/show_bug.cgi?id=172074
343
344         Reviewed by Geoffrey Garen.
345
346         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
347         (TestWebKitAPI::TEST):
348
349 2017-05-13  Commit Queue  <commit-queue@webkit.org>
350
351         Unreviewed, rolling out r216808.
352         https://bugs.webkit.org/show_bug.cgi?id=172075
353
354         caused lldb to hang when debugging (Requested by smfr on
355         #webkit).
356
357         Reverted changeset:
358
359         "Use Mach exceptions instead of signals where possible"
360         https://bugs.webkit.org/show_bug.cgi?id=171865
361         http://trac.webkit.org/changeset/216808
362
363 2017-05-12  Alex Christensen  <achristensen@webkit.org>
364
365         Rename WKContentExtension to WKContentRuleList
366         https://bugs.webkit.org/show_bug.cgi?id=172053
367         <rdar://problem/32141005>
368
369         Reviewed by Geoffrey Garen.
370
371         * TestWebKitAPI/Tests/WebKit2Cocoa/WKContentExtensionStore.mm:
372         (WKContentRuleListStoreTest::SetUp):
373         (TEST_F):
374         (-[ContentRuleListDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
375         (WKContentExtensionStoreTest::SetUp): Deleted.
376         (-[ContentExtensionDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Deleted.
377
378 2017-05-12  Keith Miller  <keith_miller@apple.com>
379
380         Use Mach exceptions instead of signals where possible
381         https://bugs.webkit.org/show_bug.cgi?id=171865
382
383         Reviewed by Mark Lam.
384
385         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
386         (runThreadMessageTest):
387         (TEST):
388
389 2017-05-12  Jeremy Jones  <jeremyj@apple.com>
390
391         Add objc version of WK2 UIPageClient setHasVideoInPictureInPicture and rename it to hasVideoInPictureInPictureDidChange.
392         https://bugs.webkit.org/show_bug.cgi?id=172048
393         rdar://problem/32163054
394
395         Reviewed by Simon Fraser.
396
397         Add a WKWebView test for hasVideoInPictureInPictureDidChange UIDelegate callback.
398
399         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.html:
400         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm:
401         (hasVideoInPictureInPictureDidChange):
402         (-[PictureInPictureUIDelegate _webView:hasVideoInPictureInPictureDidChange:]):
403         (-[PictureInPictureUIDelegate userContentController:didReceiveScriptMessage:]):
404         (TestWebKitAPI::TEST):
405
406 2017-05-12  Brady Eidson  <beidson@apple.com>
407
408         REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
409         https://bugs.webkit.org/show_bug.cgi?id=172030
410
411         Unreviewed - Test gardening
412
413         Try to resolve this once and for all by using the WebsiteDataStore API to nuke everything
414         before the test starts.
415
416         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
417         (defaultWebsiteCacheDirectory):
418         (defaultApplicationCacheDirectory):
419         (TEST):
420         (defaultWebsiteDataDirectory): Deleted.
421
422 2017-05-12  David Quesada  <david_quesada@apple.com>
423
424         Add SPI for overriding WKWebView's clipping behavior for _visibleContentRect
425         https://bugs.webkit.org/show_bug.cgi?id=172000
426         rdar://problem/32144756
427
428         Reviewed by Simon Fraser.
429
430         Added API tests to verify that WKWebView provides the expected value for
431         _visibleContentRect in various configurations. (i.e. not inside a scrollview,
432         inside a scrollview but not clipped, clipped by an ancestor scrollview,
433         clipped by the webview's _enclosingViewForExposedRectComputation)
434
435         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
436         * TestWebKitAPI/Tests/WebKit2Cocoa/VisibleContentRect.mm: Added.
437         (-[TestWKWebViewWithEnclosingView _enclosingViewForExposedRectComputation]):
438         (TestWebKitAPI::TEST):
439
440 2017-05-12  Brady Eidson  <beidson@apple.com>
441
442         REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
443         https://bugs.webkit.org/show_bug.cgi?id=172030
444
445         Unreviewed - Test gardening, in effect...
446
447         More exploration as to why this continues to fail on the bots.
448         
449         This change should give us a smoking gun.
450         
451         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
452         (TEST):
453
454 2017-05-12  Hyungwook Lee  <hyungwook.lee@navercorp.com>
455
456         [GTK] Fix compile warnings in PlatformImageCairo.cpp
457         https://bugs.webkit.org/show_bug.cgi?id=171850
458
459         Reviewed by Michael Catanzaro.
460
461         * ImageDiff/cairo/PlatformImageCairo.cpp:
462         (ImageDiff::PlatformImage::createFromStdin):
463         (ImageDiff::PlatformImage::writeAsPNGToStdout):
464
465 2017-05-12  Jeremy Jones  <jeremyj@apple.com>
466
467         Add UIClient callback for when picture-in-picture is activated.
468         https://bugs.webkit.org/show_bug.cgi?id=172023
469
470         Reviewed by Simon Fraser.
471
472         Added a test for WKPageUIClientV10 setHasVideoInPictureInPicture.
473
474         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
475         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.html: Added.
476         * TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm: Added.
477         (onLoadedCompletedCallback):
478         (waitUntilOnLoadIsCompleted):
479         (didFinishLoadForFrame):
480         (setHasVideoInPictureInPicture):
481         (TestWebKitAPI::TEST):
482
483 2017-05-12  Jonathan Bedard  <jbedard@apple.com>
484
485         Unreviewed follow-up to r216776.
486
487         * Scripts/webkitpy/port/base.py:
488         (Port.path_to_crash_logs): Raise not implemented.
489         * Scripts/webkitpy/port/test.py:
490         (TestPort.path_to_crash_logs): Return results directory as the location of crash logs.
491         * Scripts/webkitpy/port/win.py:
492         (WinPort.path_to_crash_logs): Ditto.
493
494 2017-05-12  Alexey Proskuryakov  <ap@apple.com>
495
496         Bot watcher's dashboard shows results links twice sometimes
497         https://bugs.webkit.org/show_bug.cgi?id=172043
498
499         Reviewed by Tim Horton.
500
501         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
502         (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
503
504 2017-05-12  Brady Eidson  <beidson@apple.com>
505
506         REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
507         https://bugs.webkit.org/show_bug.cgi?id=172030
508
509         Unreviewed - Test gardening, in effect...
510
511         This failure is only being seen by the bots.
512         
513         I believe this test is utterly broken in the first place; when it checks the .wal file's
514         size that is not actually an indicator that the records were deleted.
515         
516         But that isn't what's coming up as failure on the bots.
517         
518         This patch is an attempt to:
519         1 - More forcefully clear the Website data directory of leftovers before the test starts.
520         2 - Give an earlier indication of the failure that the bots are seeing, to possibly reveal more.
521
522         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
523         (defaultWebsiteDataDirectory):
524         (defaultApplicationCacheDirectory):
525         (TEST):
526
527 2017-05-12  Jonathan Bedard  <jbedard@apple.com>
528
529         webkitpy: Pass directory with crash logs into CrashLogs
530         https://bugs.webkit.org/show_bug.cgi?id=172033
531         <rdar://problem/32157616>
532
533         Reviewed by Daniel Bates.
534
535         Refactor CrashLogs and the callers of CrashLogs so that the port object owns
536         the location of crash logs.
537
538         * Scripts/webkitpy/common/system/crashlogs.py:
539         (CrashLogs.__init__): Pass mandatory crash_log_directory when constructing.
540         (CrashLogs._find_newest_log_darwin): Use self._crash_log_directory instead of
541         generating one.
542         (CrashLogs._find_newest_log_win): Use self._crash_log_directory instead of
543         self._results_directory.
544         (CrashLogs._find_all_logs_darwin): Use self._crash_log_directory instead of
545         generating one.
546         (CrashLogs._log_directory_darwin): Moved to port.
547         * Scripts/webkitpy/common/system/crashlogs_unittest.py: Update tests since the path
548         to the crash log is no longer owned by CrashLogs.
549         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Use the general
550         directory for uploading crash logs. Note that crash logs are only supported on Mac
551         and Windows.
552         * Scripts/webkitpy/port/apple.py: Remove unneeded CrashLogs import.
553         * Scripts/webkitpy/port/base.py:
554         (Port.path_to_crash_logs): Unless ports declare otherwise, crash logs are assumed
555         to be in the results directory.
556         * Scripts/webkitpy/port/darwin.py:
557         (DarwinPort.path_to_crash_logs): Moved from CrashLogs._log_directory_darwin.
558         (DarwinPort._look_for_all_crash_logs_in_log_dir): Use port specific crash log path.
559         (DarwinPort._get_crash_log): Ditto.
560         * Scripts/webkitpy/port/darwin_testcase.py:
561         (DarwinTest.test_crashlog_path): Test that the Darwin ports are correctly calculating
562         the path to crash logs.
563         * Scripts/webkitpy/port/ios_device.py:
564         (IOSDevicePort.path_to_crash_logs): Currently, crash log retrieval is undefined for iOS.
565         * Scripts/webkitpy/port/ios_device_unittest.py:
566         (IOSDeviceTest.test_crashlog_path): Currently, crash log retrieval is undefined for iOS.
567         * Scripts/webkitpy/port/ios_simulator.py: Remove unneeded CrashLogs import.
568         * Scripts/webkitpy/port/mac.py: Ditto.
569         * Scripts/webkitpy/port/test.py:
570         (TestDriver.run_test): Use port specific crash log path when retrieving crash logs.
571         * Scripts/webkitpy/port/win.py:
572         (WinPort._get_crash_log): Ditto.
573         * Scripts/webkitpy/tool/commands/queries.py:
574         (execute): Construct a port object since this is the object which owns the path to crash logs.
575
576 2017-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
577
578         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/create-navigation-data after r216615.
579
580         In r216615 the custom code for window.open() was removed. The generated code now correctly handles the optional
581         URL parameter using the default value "about:blank" when not provided.
582
583         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
584         (testWebViewCreateNavigationData):
585
586 2017-05-11  Youenn Fablet  <youenn@apple.com>
587
588         Allow WPT server to serve specific WebKit test
589         https://bugs.webkit.org/show_bug.cgi?id=171479
590
591         Reviewed by Ryosuke Niwa.
592
593         Adding a new mount point to WPT server.
594         It points to LayoutTests/http/wpt folder and is triggered on "/WebKit" urls.
595
596         Updating the webkitpy infrastructure to launch WPT server and do test url mapping for LayoutTests/wpt tests.
597
598         * Scripts/webkitpy/layout_tests/controllers/manager.py:
599         (Manager.__init__):
600         (Manager._is_http_test):
601         (Manager._needs_web_platform_test):
602         (Manager._run_tests):
603         (Manager._is_web_platform_test): Deleted.
604         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
605         (build_routes):
606         (main):
607         * Scripts/webkitpy/port/driver.py:
608         (Driver):
609         (Driver.is_webkit_specific_web_platform_test):
610         (Driver.test_to_uri):
611         (Driver._command_from_driver_input):
612
613 2017-05-11  Brady Eidson  <beidson@apple.com>
614
615         [WKWebsiteDataStore removeDataOfTypes:...] doesn't work for IndexedDB if the data store has a custom IDB path.
616         <rdar://problem/30612463> and https://bugs.webkit.org/show_bug.cgi?id=171994
617
618         Reviewed by Andy Estes.
619         Informal review by Maureen Daum.
620
621         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
622         (TEST):
623
624 2017-05-11  Joseph Pecoraro  <pecoraro@apple.com>
625
626         REGRESSION(r216217): lldb_webkit.py no longer prints out a WTFString, StringImpl needs to handle StringImplShape change
627         https://bugs.webkit.org/show_bug.cgi?id=171989
628
629         Reviewed by Brian Burg.
630
631         * lldb/lldb_webkit.py:
632         (WTFStringImplProvider.get_data8):
633         (WTFStringImplProvider.get_data16):
634         m_data8 and m_data16 are now part of the superclass StringImplShape
635         instead of directly in StringImpl. So first get the shape by getting
636         index 0, and the data properties are the same offset within that.
637
638 2017-05-11  Joseph Pecoraro  <pecoraro@apple.com>
639
640         Remove Vibration API
641         https://bugs.webkit.org/show_bug.cgi?id=171766
642
643         Rubber-stamped by Alexey Proskuryakov.
644
645         * Scripts/webkitperl/FeatureList.pm:
646
647 2017-05-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
648
649         Add WPE release bots
650         https://bugs.webkit.org/show_bug.cgi?id=171973
651
652         Reviewed by Žan Doberšek.
653
654         This adds a WPE Release Build bot (64-bit) and a WPE Release Test bot.
655         It also adds a new WPE buildbot category.
656
657         * BuildSlaveSupport/build.webkit.org-config/config.json:
658         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
659         (InstallWpeDependencies):
660         (appendCustomBuildFlags):
661         (Factory.__init__):
662         (loadBuilderConfig):
663         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
664         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
665
666 2017-05-09  Sam Weinig  <sam@webkit.org>
667
668         Remove support for legacy Notifications
669         https://bugs.webkit.org/show_bug.cgi?id=171487
670
671         Reviewed by Jon Lee.
672
673         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
674         (DRTDesktopNotificationPresenter::checkNotificationPermission):
675         * Scripts/webkitperl/FeatureList.pm:
676         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
677         Remove use and definition of ENABLE_LEGACY_NOTIFICATIONS.
678
679 2017-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
680
681         Remove user agent quirk for Slack
682         https://bugs.webkit.org/show_bug.cgi?id=171869
683
684         Reviewed by Carlos Garcia Campos.
685
686         Remove the corresponding test.
687
688         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
689         (TestWebKitAPI::TEST):
690
691 2017-05-10  Commit Queue  <commit-queue@webkit.org>
692
693         Unreviewed, rolling out r216578.
694         https://bugs.webkit.org/show_bug.cgi?id=171920
695
696         Broke the GTK+ build with Wayland enabled (Requested by KaL on
697         #webkit).
698
699         Reverted changeset:
700
701         "[GTK] Bump GTK+ and its dependencies in jhbuild"
702         https://bugs.webkit.org/show_bug.cgi?id=171918
703         http://trac.webkit.org/changeset/216578
704
705 2017-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
706
707         [GTK] Bump GTK+ and its dependencies in jhbuild
708         https://bugs.webkit.org/show_bug.cgi?id=171918
709
710         Reviewed by Carlos Alberto Lopez Perez.
711
712         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
713         (WTR::initializeGtkSettings):
714         * gtk/jhbuild.modules:
715         * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Removed.
716         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch: Removed.
717
718 2017-05-10  Don Olmstead  <don.olmstead@am.sony.com>
719
720         [Win] Set CMake args in build-webkit
721         https://bugs.webkit.org/show_bug.cgi?id=171436
722
723         Reviewed by Per Arne Vollan.
724
725         * Scripts/build-webkit:
726
727 2017-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
728
729         ImageDiff: Add CG implementation for new ImageDiff
730         https://bugs.webkit.org/show_bug.cgi?id=170608
731
732         Reviewed Alex Christensen.
733
734         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
735         * DumpRenderTree/win/ImageDiffCairo.cpp: Removed.
736         * DumpRenderTree/win/ImageDiffWin.cpp: Removed.
737         * ImageDiff/CMakeLists.txt:
738         * ImageDiff/Cairo.cmake:
739         * ImageDiff/ImageDiff.cpp:
740         (main):
741         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
742         * ImageDiff/PlatformImage.cpp:
743         * ImageDiff/PlatformImage.h:
744         * ImageDiff/cairo/PlatformImageCairo.cpp:
745         * ImageDiff/cg/ImageDiff.cpp: Removed.
746         * ImageDiff/cg/PlatformImageCG.cpp: Added.
747         (ImageDiff::PlatformImage::createFromStdin):
748         (ImageDiff::PlatformImage::createFromDiffData):
749         (ImageDiff::PlatformImage::PlatformImage):
750         (ImageDiff::PlatformImage::~PlatformImage):
751         (ImageDiff::PlatformImage::width):
752         (ImageDiff::PlatformImage::height):
753         (ImageDiff::PlatformImage::rowBytes):
754         (ImageDiff::PlatformImage::hasAlpha):
755         (ImageDiff::PlatformImage::pixels):
756         (ImageDiff::PlatformImage::writeAsPNGToStdout):
757
758 2017-05-10  Zan Dobersek  <zdobersek@igalia.com>
759
760         Enable FTL JIT by default on AArch64
761         https://bugs.webkit.org/show_bug.cgi?id=144039
762
763         Reviewed by Yusuke Suzuki.
764
765         * Scripts/build-jsc: Enable the FTL JIT option by default on ARM64.
766         * Scripts/run-jsc-stress-tests: Unmark the ARM64 and Linux combination
767         as an unsupported FTL platform.
768         * Scripts/webkitdirs.pm:
769         (isARM64): Returns 1 if the determined architecture is 'arm64'.
770         * Scripts/webkitperl/FeatureList.pm: Enable FTL_JIT and WEBASSEMBLY on ARM64.
771
772 2017-05-09  Jonathan Bedard  <jbedard@apple.com>
773
774         webkitpy: Remove unneeded crash log retrieval, refactor Darwin crash retrieval
775         https://bugs.webkit.org/show_bug.cgi?id=170857
776         <rdar://problem/31635373>
777
778         Reviewed by Aakash Jain.
779
780         Since LayoutTestRelay has been removed, iOS Simulators and Macs can use the same
781         code to search for crash logs.
782
783         * Scripts/webkitpy/port/darwin.py:
784         (DarwinPort._get_crash_log): Moved from MacPort.
785         * Scripts/webkitpy/port/darwin_testcase.py:
786         (DarwinTest.test_get_crash_log): Moved from MacTest.
787         * Scripts/webkitpy/port/ios_device.py:
788         (IOSDevicePort._get_crash_log): Implement pass-through for iOS device, since iOS
789         devices must search for crash-logs remotely.
790         * Scripts/webkitpy/port/ios_simulator.py:
791         (IOSSimulatorPort._get_crash_log): Deleted.
792         * Scripts/webkitpy/port/ios_simulator_unittest.py:
793         (IOSSimulatorTest.test_get_crash_log): Deleted.
794         * Scripts/webkitpy/port/mac.py:
795         (MacPort._get_crash_log): Moved to DarwinPort
796         * Scripts/webkitpy/port/mac_unittest.py:
797         (MacTest.test_get_crash_log): Moved to DarwinTest.
798
799 2017-05-09  Jonathan Bedard  <jbedard@apple.com>
800
801         build ImageDiff with host SDK from Make
802         https://bugs.webkit.org/show_bug.cgi?id=171835
803
804         Reviewed by Alexey Proskuryakov.
805
806         ImageDiff should be built for the default SDK and default architecture when
807         the SDKROOT is set to either iOS device or iOS simulator. Check the
808         DO_NOT_BUILD_IMAGE_DIFF flag to skip the ImageDiff build.
809
810         * ImageDiff/Makefile: Use Mac SDK when building for iOS Simulator or iOS device.
811         * Makefile: Do not build ImageDiff if the DO_NOT_BUILD_IMAGE_DIFF flag is set.
812
813 2017-05-09  Matt Lewis  <jlewis3@apple.com>
814
815         Unreviewed, adding myself to contributors.json
816
817         * Scripts/webkitpy/common/config/contributors.json:
818
819 2017-05-09  Jonathan Bedard  <jbedard@apple.com>
820
821         REGRESSION: ImageDiff not building with make
822         https://bugs.webkit.org/show_bug.cgi?id=171788
823
824         Reviewed by Alex Christensen.
825
826         * Makefile: Build ImageDiff for all platforms.
827
828 2017-05-09  Fujii Hironori  <Hironori.Fujii@sony.com>
829
830         [Win] ImageDiff isn't built since Bug 168945
831         https://bugs.webkit.org/show_bug.cgi?id=171847
832
833         Reviewed by Alex Christensen.
834
835         * CMakeLists.txt: Add 'ImageDiff' sub-directory to build if WIN32.
836         * ImageDiff/ImageDiff.cpp: Include some header files to fix compilation errors.
837         * ImageDiff/PlatformWin.cmake: Define USE_CAIRO if WinCairo port.
838
839 2017-05-09  Zan Dobersek  <zdobersek@igalia.com>
840
841         Upstream the WPE port
842         https://bugs.webkit.org/show_bug.cgi?id=171110
843
844         Reviewed by Alex Christensen.
845
846         webkit-dev thread:
847         https://lists.webkit.org/pipermail/webkit-dev/2017-April/028923.html
848
849         Add WPE support to various tooling scripts, TestWebKitAPI and WebKitTestRunner.
850         In-file changes removed from this ChangeLog entry for brevity.
851
852         * BuildSlaveSupport/built-product-archive:
853         * BuildSlaveSupport/test-result-archive:
854         * CMakeLists.txt:
855         * ImageDiff/PlatformWPE.cmake: Added.
856         * Scripts/build-dumprendertree:
857         * Scripts/build-webkit:
858         * Scripts/build-webkittestrunner:
859         * Scripts/update-webkit-libs-jhbuild:
860         * Scripts/update-webkitwpe-libs: Added.
861         * Scripts/webkitdirs.pm:
862         * Scripts/webkitperl/FeatureList.pm:
863         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
864         * Scripts/webkitpy/port/factory.py:
865         * Scripts/webkitpy/port/wpe.py: Added.
866         * TestWebKitAPI/PlatformWPE.cmake: Added.
867         * TestWebKitAPI/wpe/InjectedBundleControllerWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
868         * TestWebKitAPI/wpe/PlatformUtilitiesWPE.cpp: Added.
869         * TestWebKitAPI/wpe/main.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
870         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
871         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
872         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
873         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
874         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
875         * WebKitTestRunner/InjectedBundle/TestRunner.h:
876         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityControllerWPE.cpp: Added.
877         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp: Added.
878         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp: Added.
879         * WebKitTestRunner/InjectedBundle/wpe/InjectedBundleWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
880         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
881         * WebKitTestRunner/PlatformWPE.cmake: Added.
882         * WebKitTestRunner/PlatformWebView.h:
883         * WebKitTestRunner/TestController.cpp:
884         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp: Added.
885         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp: Added.
886         * WebKitTestRunner/wpe/HeadlessViewBackend.h: Copied from Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h.
887         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp: Added.
888         * WebKitTestRunner/wpe/TestControllerWPE.cpp: Added.
889         * WebKitTestRunner/wpe/main.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
890         * jhbuild/jhbuild-wrapper:
891         * wpe/generate-inspector-gresource-manifest.py: Added.
892         * wpe/jhbuild.modules: Added.
893         * wpe/jhbuildrc: Added.
894         * wpe/patches/cairo-egl-device-create-for-egl-surface.patch: Added.
895         * wpe/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
896         * wpe/patches/freetype6-2.4.11-truetype-font-height-fix.patch: Added.
897         * wpe/patches/gdate-suppress-string-format-literal-warning.patch: Added.
898         * wpe/patches/glib-warning-fix.patch: Added.
899         * wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Added.
900         * wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Added.
901         * wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
902         * wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.
903         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Added.
904
905 2017-05-08  Jonathan Bedard  <jbedard@apple.com>
906
907         Implement PlatformWebView::windowSnapshotImage and createBitmapContextFromWebView for iOS devices
908         https://bugs.webkit.org/show_bug.cgi?id=169421
909         <rdar://problem/30950171>
910
911         Reviewed by Tim Horton.
912
913         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
914         (createBitmapContextFromWebView): Implement for IOSurface.
915         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
916         (WTR::PlatformWebView::windowSnapshotImage): Use snapshot API for device.
917
918 2017-05-08  Jonathan Bedard  <jbedard@apple.com>
919
920         buildbot: Cleanup simulators after running tests
921         https://bugs.webkit.org/show_bug.cgi?id=171679
922
923         Reviewed by Aakash Jain.
924
925         simctl is partitioned for each user. Since kill-old-processes
926         is run as root, we need to specify the buildbot user when tearing
927         down simulators between steps.
928
929         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
930         (KillOldProcesses): Pass buildbot user to kill-old-processes.
931         * BuildSlaveSupport/kill-old-processes:
932         (main): Specify the user for simctl if one has been provided.
933
934 2017-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
935
936         REGRESSION(r216179): [GTK] Script install-dependencies misses liborc
937         https://bugs.webkit.org/show_bug.cgi?id=171681
938
939         Reviewed by Carlos Garcia Campos.
940
941         * gtk/install-dependencies:
942
943 2017-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
944
945         Unreviewed. Fix GTK+ test /webkit2/WebKitConsoleMessage/network-error after r215556.
946
947         Glib uses now Unicode quotes in error messages.
948
949         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
950         (testWebKitConsoleMessageNetworkError):
951
952 2017-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
953
954         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/javascript-dialogs after r215404.
955
956         Sending down+up keys is no longer enough to simulate a real user interaction after r215404, the key events now
957         should be handled by the web process to be considered a user interaction. So, add an input to the HTML and send
958         characters to the input. Also fix typo in the function name.
959
960         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
961         (testWebViewJavaScriptDialogs):
962
963 2017-05-07  Michael Catanzaro  <mcatanzaro@igalia.com>
964
965         [GTK] Cannot sign in with new Google sign-in page
966         https://bugs.webkit.org/show_bug.cgi?id=171770
967
968         Unreviewed. This just adds a test.
969
970         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
971         (TestWebKitAPI::TEST):
972
973 2017-05-06  Simon Fraser  <simon.fraser@apple.com>
974
975         [iOS WK2] Make rotation tests more reliable
976         https://bugs.webkit.org/show_bug.cgi?id=171778
977
978         Reviewed by Tim Horton.
979
980         Switching between "safari-style" rotation and normal rotation left state on the WKWebView
981         that would cause later viewport-sensitive tests to fail. The WKWebView would be left
982         with override layout parameters, and an override orientation, and these caused viewport
983         size to leak into later tests, and WebCore orientation to not get reset correctly.
984
985         Also, WKWebView was unregistering for UIWindowDidRotateNotification notifications when
986         an override orientation was set, and would never re-register, causing lost orientationchanged
987         events.
988
989         Fix by exposing WKWebView SPI to clear the various bits of overide state. Also don't unregister
990         from the UIWindowDidRotateNotification notification; it's already ignored anyway if it fires.
991
992         Also wait for a visible content rect update after resizing the WKWebVeiw between tests, to make sure
993         the WebProcess is caught up before proceeding with the test.
994
995         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
996         (-[PlatformWebViewController viewWillTransitionToSize:withTransitionCoordinator:]):
997         * WebKitTestRunner/ios/TestControllerIOS.mm:
998         (WTR::TestController::platformResetStateToConsistentValues):
999         (WTR::TestController::platformConfigureViewForTest):
1000
1001 2017-05-06  Csaba Osztrogonác  <ossy@webkit.org>
1002
1003         [Mac][cmake] Buildfix after r216047
1004         https://bugs.webkit.org/show_bug.cgi?id=171769
1005
1006         Unreviewed buildfix.
1007
1008         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1009
1010 2017-05-05  Brady Eidson  <beidson@apple.com>
1011
1012         API test WebKit2.WebsiteDataStoreCustomPaths is failing on ios-simulator.
1013         <rdar://problem/31977294> and https://bugs.webkit.org/show_bug.cgi?id=171513
1014
1015         Reviewed by Andy Estes.
1016
1017         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1018         (TEST):
1019
1020 2017-05-05  Brian Burg  <bburg@apple.com>
1021
1022         [Cocoa] Converting from WebCore::Cookie to NSHTTPCookie always marks cookies as session cookies
1023         https://bugs.webkit.org/show_bug.cgi?id=171748
1024         <rdar://problem/32027327>
1025
1026         Reviewed by Michael Catanzaro.
1027
1028         Remove temporary workaround now that the assertion failure is fixed.
1029
1030         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1031         (TEST):
1032
1033 2017-05-05  Simon Fraser  <simon.fraser@apple.com>
1034
1035         Make it possible to test rotation in iOS WebKitTestRunner
1036         https://bugs.webkit.org/show_bug.cgi?id=171755
1037
1038         Reviewed by Tim Horton.
1039
1040         Add to UIScriptController:
1041             void simulateRotation(DeviceOrientation orientation, object callback);
1042             void simulateRotationLikeSafari(DeviceOrientation orientation, object callback);
1043
1044         The former just does a view resize, as a simple WKWebView app would do. The second does
1045         animation more like MobileSafari, using _begin/_endAnimatedResize. and associated override
1046         layout size and interface orientation. The two behaviors produce different resize and
1047         orientationchange events and sizes, and both need to be tested.
1048
1049         Rotation is initiated by a call on UIDevice, and responded to by the root view controller,
1050         which is now a custom subclass (PlatformWebViewController).
1051
1052         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1053         (WTR::UIScriptController::simulateRotation):
1054         (WTR::UIScriptController::simulateRotationLikeSafari):
1055         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1056         (WTR::UIScriptController::simulateRotation):
1057         (WTR::UIScriptController::simulateRotationLikeSafari):
1058         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1059         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1060         (WTR::toDeviceOrientation):
1061         (WTR::UIScriptController::simulateRotation):
1062         (WTR::UIScriptController::simulateRotationLikeSafari):
1063         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1064         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1065         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1066         (-[TestRunnerWKWebView dealloc]):
1067         (-[TestRunnerWKWebView _didEndRotation]):
1068         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1069         (-[PlatformWebViewController viewWillTransitionToSize:withTransitionCoordinator:]):
1070         (WTR::PlatformWebView::PlatformWebView):
1071         * WebKitTestRunner/ios/TestControllerIOS.mm:
1072         (WTR::TestController::platformResetStateToConsistentValues):
1073         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1074         (WTR::toUIDeviceOrientation):
1075         (WTR::UIScriptController::simulateRotation):
1076         (WTR::UIScriptController::simulateRotationLikeSafari):
1077         (WTR::UIScriptController::platformClearAllCallbacks):
1078         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1079         (WTR::UIScriptController::simulateRotation):
1080         (WTR::UIScriptController::simulateRotationLikeSafari):
1081
1082 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
1083
1084         Use ImageDiff built by host SDK and remove ImageDiff from DumpRenderTree
1085         https://bugs.webkit.org/show_bug.cgi?id=168945
1086         <rdar://problem/30745695>
1087
1088         Reviewed by David Kilzer.
1089
1090         Use ImageDiff built with the host machine's SDK and stop building ImageDiff with the
1091         target SDK. These two changes must happen simultaneously because some archives will
1092         clobber the ImageDiff from the host SDK with the ImageDiff from the target SDK.
1093
1094         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Remove ImageDiff from project.
1095         * DumpRenderTree/PlatformWin.cmake: Remove ImageDiff. Note that the CMakeLists.txt in the
1096         tools directory still includes ImageDiff.
1097         * DumpRenderTree/cg/ImageDiffCG.cpp: Removed.
1098         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Removed.
1099         * Scripts/webkitpy/port/darwin.py: 
1100         (DarwinPort._path_to_image_diff): Return the correct path to ImageDiff when building
1101         locally or when running archives.
1102         * Scripts/webkitpy/port/image_diff.py:
1103         (IOSSimulatorImageDiffer): Deleted.
1104         * Scripts/webkitpy/port/ios_simulator.py:
1105         (IOSSimulatorPort.diff_image): Deleted.
1106
1107 2017-05-05  Brian Burg  <bburg@apple.com>
1108
1109         API test WebKit2.WKHTTPCookieStore fails due to possible issue with handling non-session cookies
1110         https://bugs.webkit.org/show_bug.cgi?id=171748
1111
1112         Unreviewed test gardening.
1113
1114         The assertion failure will be investigated separately in order to avoid rolling out
1115         the fix for "secure" cookies. This assertion fails even without r216258 applied.
1116
1117         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1118         (TEST):
1119
1120 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
1121
1122         Unreviewed, rolling out r216260.
1123
1124         Breaks internal iOS testers
1125
1126         Reverted changeset:
1127
1128         "Use ImageDiff built by host SDK and remove ImageDiff from
1129         DumpRenderTree"
1130         https://bugs.webkit.org/show_bug.cgi?id=168945
1131         http://trac.webkit.org/changeset/216260
1132
1133 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
1134
1135         Use ImageDiff built by host SDK and remove ImageDiff from DumpRenderTree
1136         https://bugs.webkit.org/show_bug.cgi?id=168945
1137         <rdar://problem/30745695>
1138
1139         Reviewed by David Kilzer.
1140
1141         Use ImageDiff built with the host machine's SDK and stop building ImageDiff with the
1142         target SDK. These two changes must happen simultaneously because some archives will
1143         clobber the ImageDiff from the host SDK with the ImageDiff from the target SDK.
1144
1145         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Remove ImageDiff from project.
1146         * DumpRenderTree/PlatformWin.cmake: Remove ImageDiff. Note that the CMakeLists.txt in the
1147         tools directory still includes ImageDiff.
1148         * DumpRenderTree/cg/ImageDiffCG.cpp: Removed.
1149         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Removed.
1150         * Scripts/webkitpy/port/darwin.py: 
1151         (DarwinPort._path_to_image_diff): Return the correct path to ImageDiff when building
1152         locally or when running archives.
1153         * Scripts/webkitpy/port/image_diff.py:
1154         (IOSSimulatorImageDiffer): Deleted.
1155         * Scripts/webkitpy/port/ios_simulator.py:
1156         (IOSSimulatorPort.diff_image): Deleted.
1157
1158 2017-05-05  Brian Burg  <bburg@apple.com>
1159
1160         [Cocoa] Converting from WebCore::Cookie to NSHTTPCookie always marks cookies as secure
1161         https://bugs.webkit.org/show_bug.cgi?id=171700
1162         <rdar://problem/32017975>
1163
1164         Reviewed by Brady Eidson.
1165
1166         Fix a mistake in the test that should have caught this bug.
1167
1168         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1169         (TEST):
1170         The assertions that were meant to check round-tripping were actually checking
1171         the properties of the original cookie objects, not the round-tripped ones.
1172         This test now fails without the bugfix and passes when it is applied.
1173
1174 2017-05-05  Daniel Bates  <dabates@apple.com>
1175
1176         Use EXPECT_EQ() when comparing strings in TestWebKitAPI tests
1177         https://bugs.webkit.org/show_bug.cgi?id=171698
1178
1179         Reviewed by Darin Adler.
1180
1181         We should use EXPECT_EQ() instead of EXPECT_TRUE() to compare WTF::String() objects
1182         so that we get pretty diff output when the actual string differs from the expected
1183         string as opposed to seeing a boolean result. The former makes makes it straightforward
1184         to diagnose a regression without reading the code for the test or instrumenting it to
1185         determine the actual string that was compared.
1186
1187         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1188         (TestWebKitAPI::TEST):
1189         * TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm:
1190         (TestWebKitAPI::TEST_F):
1191         * TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm:
1192         (TestWebKitAPI::TEST_F):
1193
1194 2017-05-05  Chris Dumez  <cdumez@apple.com>
1195
1196         Rename webProcessDidCrashWithReason callback to webProcessDidTerminate and stop calling webProcessDidCrash for client terminations
1197         https://bugs.webkit.org/show_bug.cgi?id=171624
1198
1199         Reviewed by Dan Bernstein.
1200
1201         Extend API test coverage to cover crashes in addition to terminations requested by the client.
1202
1203         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1204         * TestWebKitAPI/Tests/WebKit2/ProcessDidTerminate.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/ProcessDidCrashWithReason.cpp.
1205         (TestWebKitAPI::webProcessWasTerminatedByClient):
1206         (TestWebKitAPI::webProcessCrashed):
1207         (TestWebKitAPI::TEST):
1208
1209 2017-05-04  Mark Lam  <mark.lam@apple.com>
1210
1211         DRT's setAudioResultCallback() and IDBRequest::setResult() need to acquire the JSLock.
1212         https://bugs.webkit.org/show_bug.cgi?id=171716
1213         <rdar://problem/30878027>
1214
1215         Reviewed by Saam Barati.
1216
1217         setAudioResultCallback() needs to acquire the JSLock before calling toJS() (which
1218         does JS conversion and therefore, potentially JS allocations) and accessing
1219         methods of internal JS data structures (which may do JS invocation, etc).
1220
1221         * DumpRenderTree/TestRunner.cpp:
1222         (setAudioResultCallback):
1223
1224 2017-05-05  Jonathan Bedard  <jbedard@apple.com>
1225
1226         buildbot: Cleanup simulators after running tests
1227         https://bugs.webkit.org/show_bug.cgi?id=171679
1228         <rdar://problem/31994361>
1229
1230         Reviewed by Aakash Jain.
1231
1232         We shutdown the simulator process between tests, but in some cases, this is not
1233         sufficient. Explicitly shutdown every booted simulator.
1234
1235         * BuildSlaveSupport/kill-old-processes:
1236         (main): Shutdown all booted simulators.
1237
1238 2017-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1239
1240         [GTK] Assertion failure in Inspector::RemoteInspector::setRemoteInspectorClient when disposing WebKitWebContext
1241         https://bugs.webkit.org/show_bug.cgi?id=171644
1242
1243         Reviewed by Michael Catanzaro.
1244
1245         Check that only one WebKitWebContext can have automation enabled.
1246
1247         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp:
1248         (testAutomationSessionRequestSession):
1249
1250 2017-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1251
1252         [GTK] TestController timeout source callback should return G_SOURCE_REMOVE
1253         https://bugs.webkit.org/show_bug.cgi?id=171724
1254
1255         Reviewed by Michael Catanzaro.
1256
1257         It's currently returning CONTINUE which causes it to be called again even if the run loop has been stopped.
1258
1259         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1260         (WTR::timeoutSource):
1261
1262 2017-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1263
1264         Unreviewed. Fix wrong assert after r215176.
1265
1266         Cairo surface received by computeMD5HashStringForCairoSurface() doesn't need to be ARGB32 since r215176, it
1267         could also be RGB24 when created from a web view snapshot.
1268
1269         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1270         (WTR::computeMD5HashStringForCairoSurface):
1271
1272 2017-05-04  Brian Burg  <bburg@apple.com>
1273
1274         lldb_webkit.py should provide a type summary for WebCore::URL
1275         https://bugs.webkit.org/show_bug.cgi?id=171670
1276
1277         Reviewed by Jer Noble.
1278
1279         Just print out the underlying string using the WTFString provider.
1280
1281         * lldb/lldb_webkit.py:
1282         (__lldb_init_module):
1283         (WebCoreURL_SummaryProvider):
1284         (WebCoreURLProvider):
1285         (WebCoreURLProvider.__init__):
1286         (WebCoreURLProvider.to_string):
1287
1288 2017-05-04  Commit Queue  <commit-queue@webkit.org>
1289
1290         Unreviewed, rolling out r216206.
1291         https://bugs.webkit.org/show_bug.cgi?id=171714
1292
1293         Multiple LayoutTests crashing in Document::page() (Requested
1294         by ap on #webkit).
1295
1296         Reverted changeset:
1297
1298         "Remove support for legacy Notifications"
1299         https://bugs.webkit.org/show_bug.cgi?id=171487
1300         http://trac.webkit.org/changeset/216206
1301
1302 2017-05-04  Mark Lam  <mark.lam@apple.com>
1303
1304         API test WTF.StaticStringImpl crashing in TestWebKitAPI::WTF_StaticStringImpl_Test::TestBody() + 3188
1305         https://bugs.webkit.org/show_bug.cgi?id=171702
1306
1307         Reviewed by Filip Pizlo.
1308
1309         The test was supposed to use the MAKE_STATIC_STRING_IMPL macro.  I had previously
1310         changed it to instantiate an automatic StaticStringImpl (i.e. stack allocated) to
1311         confirm that the test will detect a regression.  Unfortunately, I forgot to
1312         change it back to using MAKE_STATIC_STRING_IMPL before I landed the test.
1313         This patch fixes that.
1314
1315         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1316         (TestWebKitAPI::neverDestroyedString):
1317
1318 2017-05-04  Ryan Haddad  <ryanhaddad@apple.com>
1319
1320         Disable failing API test WebKit2.ResizeWithHiddenContentDoesNotHang.
1321         https://bugs.webkit.org/show_bug.cgi?id=170195
1322
1323         Unreviewed test gardening.
1324
1325         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1326         (TEST):
1327
1328 2017-05-04  Don Olmstead  <don.olmstead@am.sony.com>
1329
1330         [Win] Remove redundant macros that are set in the CMake config
1331         https://bugs.webkit.org/show_bug.cgi?id=171571
1332
1333         Reviewed by Brent Fulgham.
1334
1335         * DumpRenderTree/config.h:
1336         * MiniBrowser/win/stdafx.h:
1337         * TestWebKitAPI/config.h:
1338
1339 2017-05-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
1340
1341         Add testRunner.display() to force displaying the web page for testing
1342         https://bugs.webkit.org/show_bug.cgi?id=171694
1343
1344         Reviewed by Simon Fraser.
1345
1346         Unlike testRunner.displayAndTrackRepaints(), this new function forces 
1347         drawing the web page but without track repaints.
1348
1349         * DumpRenderTree/TestRunner.cpp:
1350         (displayCallback):
1351         (TestRunner::staticFunctions):
1352         * DumpRenderTree/TestRunner.h:
1353         * DumpRenderTree/mac/TestRunnerMac.mm:
1354         (TestRunner::display):
1355         * DumpRenderTree/win/TestRunnerWin.cpp:
1356         (TestRunner::display):
1357         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1358         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1359         (WTR::TestRunner::display):
1360         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1361
1362 2017-05-04  Mark Lam  <mark.lam@apple.com>
1363
1364         NeverDestroyed<String>(ASCIILiteral(...)) is not thread safe.
1365         https://bugs.webkit.org/show_bug.cgi?id=171586
1366         <rdar://problem/31873190>
1367
1368         Reviewed by Yusuke Suzuki.
1369
1370         API test for exercising StaticStringImpl and the MAKE_STATIC_STRING_IMPL macro.
1371
1372         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1373         (TestWebKitAPI::neverDestroyedString):
1374         (TestWebKitAPI::getNeverDestroyedStringAtStackDepth):
1375         (TestWebKitAPI::TEST):
1376
1377 2017-05-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1378
1379         [WK2] Add support for keeping the selection in a focused editable element when dragging begins
1380         https://bugs.webkit.org/show_bug.cgi?id=171585
1381         <rdar://problem/31544320>
1382
1383         Reviewed by Beth Dakin and Zalan Bujtas.
1384
1385         Adds 1 new unit test and tweaks existing tests to check that when first responder status is lost after beginning
1386         a drag while editing, content is still moved (and not copied) when performing data interaction on a different
1387         element. ContentEditableMoveParagraphs checks that content can be shifted within a single element via a move
1388         operation rather than a copy.
1389
1390         See WebCore ChangeLog for more details.
1391
1392         Tests:  DataInteractionSimulator.ContentEditableToContentEditable
1393                 DataInteractionSimulator.ContentEditableToTextarea
1394                 DataInteractionSimulator.ContentEditableMoveParagraphs
1395                 DataInteractionSimulator.TextAreaToInput
1396
1397         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1398         * TestWebKitAPI/Tests/WebKit2Cocoa/two-paragraph-contenteditable.html: Added.
1399         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1400         (TestWebKitAPI::TEST):
1401         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1402         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1403         (-[DataInteractionSimulator initWithWebView:]):
1404         (-[DataInteractionSimulator dealloc]):
1405         (-[DataInteractionSimulator _advanceProgress]):
1406         (-[DataInteractionSimulator waitForInputSession]):
1407         (-[DataInteractionSimulator _webView:focusShouldStartInputSession:]):
1408         (-[DataInteractionSimulator _webView:didStartInputSession:]):
1409
1410 2017-05-04  Said Abou-Hallawa  <sabouhallawa@apple.com>
1411
1412         Rename TestRunner.display() to TestRunner::displayAndTrackRepaints()
1413         https://bugs.webkit.org/show_bug.cgi?id=171641
1414
1415         Reviewed by Simon Fraser.
1416
1417         The plan is to add back the TestRunner.display() which does the display
1418         only without track repaints.
1419
1420         * DumpRenderTree/DumpRenderTree.h:
1421         * DumpRenderTree/TestRunner.cpp:
1422         (displayAndTrackRepaintsCallback):
1423         (TestRunner::staticFunctions):
1424         (displayCallback): Deleted.
1425         (displayInvalidatedRegionCallback): Deleted.
1426         * DumpRenderTree/TestRunner.h:
1427         * DumpRenderTree/mac/DumpRenderTree.mm:
1428         (displayWebView):
1429         (displayAndTrackRepaintsWebView):
1430         * DumpRenderTree/mac/TestRunnerMac.mm:
1431         (TestRunner::displayAndTrackRepaints):
1432         (TestRunner::display): Deleted.
1433         * DumpRenderTree/win/TestRunnerWin.cpp:
1434         (TestRunner::displayAndTrackRepaints):
1435         (TestRunner::display): Deleted.
1436         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1437         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1438         (WTR::TestRunner::displayAndTrackRepaints):
1439         (WTR::TestRunner::display): Deleted.
1440         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1441
1442 2017-05-04  Brady Eidson  <beidson@apple.com>
1443
1444         [ios-simulator] API test WebKit2.WebsiteDataStoreCustomPaths is failing.
1445         https://bugs.webkit.org/show_bug.cgi?id=171513
1446
1447         Unreviewed gardening.
1448
1449         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1450         (TEST): Skip the failing parts of the test on iOS for now.
1451
1452 2017-05-03  Jonathan Bedard  <jbedard@apple.com>
1453
1454         Make ImageDiff stand-alone
1455         https://bugs.webkit.org/show_bug.cgi?id=168939
1456
1457         Reviewed by David Kilzer.
1458
1459         Create ImageDiff without dependencies on bmalloc and WTF so that it exists as a
1460         stand-alone project. Note that this change does not eliminate the ImageDiff inside
1461         the DumpRenderTree project.
1462
1463         * ImageDiff/ImageDiff.xcodeproj: Added.
1464         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj: Added.
1465         * ImageDiff/Makefile: Use ImageDiff project.
1466         * ImageDiff/PlatformMac.cmake: Added.
1467         * ImageDiff/PlatformWin.cmake: Added.
1468         * ImageDiff/cg: Added.
1469         * ImageDiff/cg/Configurations: Added.
1470         * ImageDiff/cg/Configurations/Base.xcconfig: Copied from Tools/DumpRenderTree/mac/Configurations/Base.xcconfig.
1471         * ImageDiff/cg/Configurations/DebugRelease.xcconfig: Copied from Tools/DumpRenderTree/mac/Configurations/DebugRelease.xcconfig.
1472         * ImageDiff/cg/Configurations/ImageDiff.xcconfig: Copied from Tools/DumpRenderTree/mac/Configurations/ImageDiff.xcconfig.
1473         * ImageDiff/cg/ImageDiff.cpp: Copied from Tools/DumpRenderTree/cg/ImageDiffCG.cpp.
1474         (createImageFromStdin): Stop using RetainPtr.
1475         (createDifferenceImage): Ditto.
1476         (main): Ditto.
1477         * Scripts/build-imagediff: Stop building WTF and bmalloc.
1478
1479 2017-05-04  Sam Weinig  <sam@webkit.org>
1480
1481         Remove support for legacy Notifications
1482         https://bugs.webkit.org/show_bug.cgi?id=171487
1483
1484         Reviewed by Jon Lee.
1485
1486         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1487         (DRTDesktopNotificationPresenter::checkNotificationPermission):
1488         * Scripts/webkitperl/FeatureList.pm:
1489         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1490         Remove use and definition of ENABLE_LEGACY_NOTIFICATIONS.
1491
1492 2017-05-04  Andy Estes  <aestes@apple.com>
1493
1494         Give +testwebkitapi_configurationWithTestPlugInClassName: a shorter name
1495         https://bugs.webkit.org/show_bug.cgi?id=171673
1496
1497         Reviewed by Dan Bernstein.
1498
1499         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm:
1500         (TEST):
1501         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
1502         (TEST):
1503         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
1504         (TEST):
1505         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
1506         (TEST):
1507         * TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresource.mm:
1508         (TEST):
1509         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
1510         (configurationWithContentFilterSettings):
1511         (-[LazilyLoadPlatformFrameworksController init]):
1512         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1513         (TEST):
1514         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptions.mm:
1515         (runTestWithWidth):
1516         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentWorld.mm:
1517         (TEST):
1518         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1519         (TestWebKitAPI::TEST):
1520         * TestWebKitAPI/WKWebViewConfigurationExtras.h:
1521         * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
1522         (+[WKWebViewConfiguration _test_configurationWithTestPlugInClassName:]):
1523         (+[WKWebViewConfiguration testwebkitapi_configurationWithTestPlugInClassName:]): Renamed to
1524         +_test_configurationWithTestPlugInClassName:
1525
1526 2017-05-04  Eric Carlson  <eric.carlson@apple.com>
1527
1528         [MediaStream] Allow host application to enable/disable media capture
1529         https://bugs.webkit.org/show_bug.cgi?id=171292
1530         <rdar://problem/31821492>
1531
1532         Reviewed by Jer Noble.
1533
1534         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1535         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm: Added.
1536         (-[UserMediaMessageHandler userContentController:didReceiveScriptMessage:]):
1537         (-[UserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1538         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1539         (MediaCaptureDisabledTest::SetUp):
1540         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
1541         (TEST_F):
1542         * TestWebKitAPI/Tests/WebKit2Cocoa/disableGetUserMedia.html: Added.
1543
1544 2017-05-04  Caio Lima  <ticaiolima@gmail.com>
1545
1546         Unreviewed, Adding self to contributors.json
1547
1548         * Scripts/webkitpy/common/config/contributors.json: Added name.
1549
1550 2017-05-04  Konstantin Tokarev  <annulen@yandex.ru>
1551
1552         Fix compilation with ICU 59.1
1553         https://bugs.webkit.org/show_bug.cgi?id=171612
1554
1555         Reviewed by Mark Lam.
1556
1557         ICU 59.1 has broken source compatibility. Now it defines UChar as
1558         char16_t, which does not allow automatic type conversion from unsigned
1559         short in C++ code.
1560
1561         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
1562         (UIScriptContext::tryToCompleteUIScriptForCurrentParentCallback):
1563
1564 2017-05-04  Andy Estes  <aestes@apple.com>
1565
1566         [Cocoa] Add an optional width parameter to -[WKWebProcessPlugInNodeHandle renderedImageWithOptions:]
1567         https://bugs.webkit.org/show_bug.cgi?id=171646
1568         <rdar://problem/30306321>
1569
1570         Reviewed by Tim Horton.
1571
1572         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptions.mm:
1573         (runTestWithWidth):
1574         (TEST):
1575         (-[RenderedImageWithOptionsObject didRenderImageWithSize:]): Deleted.
1576         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptionsPlugIn.mm:
1577         (-[RenderedImageWithOptionsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1578         (-[RenderedImageWithOptionsPlugIn webProcessPlugInBrowserContextController:didFinishLoadForFrame:]):
1579         (-[RenderedImageWithOptionsPlugIn renderImageWithWidth:completionHandler:]):
1580         * TestWebKitAPI/Tests/WebKit2Cocoa/RenderedImageWithOptionsProtocol.h:
1581
1582 2017-05-04  Adrian Perez de Castro  <aperez@igalia.com>
1583
1584         [GTK] Fontconfig 2.11.2 in JHBuild does not build with glibc 2.25+ or gperf 3.1+
1585         https://bugs.webkit.org/show_bug.cgi?id=171649
1586
1587         Reviewed by Carlos Garcia Campos.
1588
1589         Add two patches picked from the upstream repository to fix building of
1590         the Fontconfig module in JHBuild. Additionally, this needed a patch to
1591         add "autogen.sh" as it is not included in release tarballs. Also:
1592         building the module with srcdir!=builddir prevents "fcobjshash.gperf"
1593         being regenerated (which is needed) so this is disabled for the
1594         Fontconfig module.
1595
1596         * gtk/jhbuild.modules:
1597         * gtk/patches/fontconfig-2.11.1-add-autogen.patch: Added.
1598         * gtk/patches/fontconfig-Avoid-conflicts-with-integer-width-macros-from-TS-18661-1-2014.patch: Added.
1599         * gtk/patches/fontconfig-Fix-the-build-issue-with-gperf-3.1.patch: Added.
1600
1601 2017-05-04  Commit Queue  <commit-queue@webkit.org>
1602
1603         Unreviewed, rolling out r216172.
1604         https://bugs.webkit.org/show_bug.cgi?id=171654
1605
1606         FTBFS for iOS due to missing WebPageProxy::stopMediaCapture()
1607         implementation. (Requested by ddkilzer on #webkit).
1608
1609         Reverted changeset:
1610
1611         "[MediaStream] Allow host application to enable/disable media
1612         capture"
1613         https://bugs.webkit.org/show_bug.cgi?id=171292
1614         http://trac.webkit.org/changeset/216172
1615
1616 2017-05-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1617
1618         [GTK] Bump GStreamer version to 1.10.4 in jhbuild
1619         https://bugs.webkit.org/show_bug.cgi?id=171595
1620
1621         Reviewed by Xabier Rodriguez-Calvar.
1622
1623         * gtk/jhbuild.modules:
1624         * gtk/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Removed.
1625         * gtk/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Removed.
1626         * gtk/patches/gst-plugins-good-0001-rtpbin-pipeline-gets-an-EOS-when-any-rtpsources-byes.patch: Removed.
1627         * gtk/patches/gst-plugins-good-0002-rtpbin-avoid-generating-errors-when-rtcp-messages-ar.patch: Removed.
1628         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
1629         * gtk/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
1630         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
1631
1632 2017-05-03  Saam Barati  <sbarati@apple.com>
1633
1634         How we build polymorphic cases is wrong when making a call from Wasm
1635         https://bugs.webkit.org/show_bug.cgi?id=171527
1636
1637         Reviewed by JF Bastien.
1638
1639         * Scripts/run-jsc-stress-tests:
1640
1641 2017-05-03  Eric Carlson  <eric.carlson@apple.com>
1642
1643         [MediaStream] Allow host application to enable/disable media capture
1644         https://bugs.webkit.org/show_bug.cgi?id=171292
1645         <rdar://problem/31821492>
1646
1647         Reviewed by Jer Noble.
1648
1649         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1650         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm: Added.
1651         (-[UserMediaMessageHandler userContentController:didReceiveScriptMessage:]):
1652         (-[UserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1653         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1654         (MediaCaptureDisabledTest::SetUp):
1655         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
1656         (TEST_F):
1657         * TestWebKitAPI/Tests/WebKit2Cocoa/disableGetUserMedia.html: Added.
1658
1659 2017-05-03  John Wilander  <wilander@apple.com>
1660
1661         Resource Load Statistics: Remove all statistics for modifiedSince website data removals
1662         https://bugs.webkit.org/show_bug.cgi?id=171584
1663         <rdar://problem/24702576>
1664
1665         Reviewed by Brent Fulgham.
1666
1667         New function to call the clear function that takes a modifiedSince parameter.
1668
1669         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1670         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1671         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1672         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1673         * WebKitTestRunner/TestController.cpp:
1674         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1675         * WebKitTestRunner/TestController.h:
1676         * WebKitTestRunner/TestInvocation.cpp:
1677         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1678
1679 2017-05-03  Commit Queue  <commit-queue@webkit.org>
1680
1681         Unreviewed, rolling out r216160 and r216161.
1682         https://bugs.webkit.org/show_bug.cgi?id=171640
1683
1684         These changes broke the iOS build. (Requested by mlewis13 on
1685         #webkit).
1686
1687         Reverted changesets:
1688
1689         "[MediaStream] Allow host application to enable/disable media
1690         capture"
1691         https://bugs.webkit.org/show_bug.cgi?id=171292
1692         http://trac.webkit.org/changeset/216160
1693
1694         "[MediaStream] Allow host application to enable/disable media
1695         capture"
1696         https://bugs.webkit.org/show_bug.cgi?id=171292
1697         http://trac.webkit.org/changeset/216161
1698
1699 2017-05-03  Eric Carlson  <eric.carlson@apple.com>
1700
1701         [MediaStream] Allow host application to enable/disable media capture
1702         https://bugs.webkit.org/show_bug.cgi?id=171292
1703         <rdar://problem/31821492>
1704
1705         Reviewed by Jer Noble.
1706
1707         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1708         * TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm: Added.
1709         (-[UserMediaMessageHandler userContentController:didReceiveScriptMessage:]):
1710         (-[UserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1711         (-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1712         (MediaCaptureDisabledTest::SetUp):
1713         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
1714         (TEST_F):
1715         * TestWebKitAPI/Tests/WebKit2Cocoa/disableGetUserMedia.html: Added.
1716
1717 2017-04-26  Jiewen Tan  <jiewen_tan@apple.com>
1718
1719         [WebCrypto] Add an api test for testing wrapping/unwrapping serialized crypto keys
1720         https://bugs.webkit.org/show_bug.cgi?id=171350
1721         <rdar://problem/28600836>
1722
1723         Patched by Brady Eidson.
1724
1725         Reviewed by Brent Fulgham.
1726
1727         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1728         * TestWebKitAPI/Tests/WebKit2/NavigationClientDefaultCrypto.cpp: Added.
1729         (TestWebKitAPI::runJavaScriptAlert):
1730         (TestWebKitAPI::decidePolicyForNavigationAction):
1731         (TestWebKitAPI::decidePolicyForNavigationResponse):
1732         (TestWebKitAPI::TEST):
1733         * TestWebKitAPI/Tests/WebKit2/navigation-client-default-crypto.html: Added.
1734
1735 2017-05-03  Simon Fraser  <simon.fraser@apple.com>
1736
1737         Have WKWebView call _updateVisibleContentRects for the current transaction if possible, rather than always delaying
1738         https://bugs.webkit.org/show_bug.cgi?id=171619
1739         https://bugs.webkit.org/show_bug.cgi?id=170195
1740
1741         Reviewed by Tim Horton.
1742
1743         Re-enable WebKit2.ResizeWithHiddenContentDoesNotHang.
1744
1745         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1746         (TEST):
1747
1748 2017-05-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1749
1750         YouTube user agent quirk breaks new YouTube
1751         https://bugs.webkit.org/show_bug.cgi?id=171603
1752
1753         Reviewed by Carlos Garcia Campos.
1754
1755         Remove the YouTube quirk test.
1756
1757         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1758         (TestWebKitAPI::TEST):
1759
1760 2017-05-03  Said Abou-Hallawa  <sabouhallawa@apple.com>
1761
1762         Async image decoding should be disabled for snapshots, printing and preview
1763         https://bugs.webkit.org/show_bug.cgi?id=171467
1764
1765         Reviewed by Simon Fraser.
1766
1767         Add a API test for snapshotting with large images. Ensure the images are
1768         drawn correctly which implies they should have been synchronously decoded.
1769
1770         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1771         * TestWebKitAPI/Tests/WebKit2/large-red-square-image.html: Added.
1772         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewSnapshot.mm:
1773         (TEST):
1774
1775 2017-05-03  Chris Dumez  <cdumez@apple.com>
1776
1777         [WK2] Extend processDidCrash delegate to let the client know the reason for the crash
1778         https://bugs.webkit.org/show_bug.cgi?id=171565
1779         <rdar://problem/31204417>
1780
1781         Reviewed by Sam Weinig.
1782
1783         Add API test coverage.
1784
1785         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1786         * TestWebKitAPI/Tests/WebKit2/ProcessDidCrashWithReason.cpp: Added.
1787         (TestWebKitAPI::didFinishNavigation):
1788         (TestWebKitAPI::didCrashWithReason):
1789         (TestWebKitAPI::TEST):
1790
1791 2017-05-02  David Kilzer  <ddkilzer@apple.com>
1792
1793         check-webkit-style should also keep js-test-post[-async].js in sync
1794         <https://webkit.org/b/171568>
1795
1796         Reviewed by Joseph Pecoraro.
1797
1798         * Scripts/webkitpy/style/checker.py:
1799         (_NEVER_SKIPPED_JS_FILES): Add new list that just contains
1800         JavaScript files not to be skipped.
1801         (_NEVER_SKIPPED_FILES): Update to use _NEVER_SKIPPED_JS_FILES.
1802         (CheckerDispatcher._create_checker): Update to use
1803         _NEVER_SKIPPED_JS_FILES.
1804
1805         * Scripts/webkitpy/style/checkers/jstest.py:
1806         (ALL_JS_TEST_FUNCTION_FILES): Rename from ALL_JS_TEST_FILES.
1807         This is the list of files containing functions that need to be
1808         kept in sync.
1809         (KEEP_JS_TEST_FILES_IN_SYNC): Change to list-of-lists format so
1810         we can keep more sets of files in sync between
1811         LayoutTests/resources and LayoutTests/http/tests/resources.
1812         (JSTestChecker.check): Update to use KEEP_JS_TEST_FILES_IN_SYNC
1813         as list of lists.  Update for ALL_JS_TEST_FUNCTION_FILES rename.
1814         (JSTestChecker.check_js_test_files): Add 'file_group' argument
1815         for list of files to check instead of using
1816         KEEP_JS_TEST_FILES_IN_SYNC.
1817         (JSTestChecker.check_js_test_functions): Update for
1818         ALL_JS_TEST_FUNCTION_FILES rename.
1819
1820         * Scripts/webkitpy/style/checkers/jstest_unittest.py:
1821         (JSTestCheckerTestCase):
1822         (JSTestCheckerTestCase.test_map_functions_to_dict):
1823         - Add test case for map_functions_to_dict() in jstest.py.
1824
1825 2017-05-02  Aakash Jain  <aakash_jain@apple.com>
1826
1827         ews should indicate in logs when it fails to fetch the attachment
1828         https://bugs.webkit.org/show_bug.cgi?id=171583
1829
1830         Reviewed by Alexey Proskuryakov.
1831
1832         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1833         (Bugzilla.fetch_attachment): Added log statement.
1834
1835 2017-05-02  David Kilzer  <ddkilzer@apple.com>
1836
1837         Rolling out jstest_unittest.py so it can be reviewed
1838
1839         Follow-up fix for:
1840         check-webkit-style should keep JavaScript test functions in sync
1841         <https://webkit.org/b/171424>
1842
1843         * Scripts/webkitpy/style/checkers/jstest_unittest.py: Remove.
1844
1845 2017-05-02  David Kilzer  <ddkilzer@apple.com>
1846
1847         check-webkit-style should keep JavaScript test functions in sync
1848         <https://webkit.org/b/171424>
1849
1850         Reviewed by Joseph Pecoraro.
1851
1852         Add a new JSTestChecker for check-webkit-style that keeps these
1853         two files in sync:
1854
1855             LayoutTests/http/tests/resources/js-test-pre.js
1856             LayoutTests/resources/js-test-pre.js
1857
1858         And keeps implementations of shouldBe(), shouldNotBe(),
1859         shouldNotThrow(), and shouldThrow() in sync across multiple
1860         files (with the ability to add more functions later):
1861
1862             JSTests/stress/resources/standalone-pre.js
1863             LayoutTests/http/tests/resources/js-test-pre.js
1864             LayoutTests/resources/js-test-pre.js
1865             LayoutTests/resources/js-test.js
1866             LayoutTests/resources/standalone-pre.js
1867
1868         * Scripts/webkitpy/style/checker.py: Remove unused import.  Add
1869         import for JSTestChecker.
1870         (_NEVER_SKIPPED_FILES): Add array of file names that are never
1871         skipped regardless of other rules.
1872         (_all_categories): Add JSTestChecker categories.
1873         (CheckerDispatcher.should_skip_without_warning): Use
1874         _NEVER_SKIPPED_FILES.
1875         (CheckerDispatcher._create_checker): Return JSTestChecker for
1876         the files to check.
1877
1878         * Scripts/webkitpy/style/checkers/jstest.py: Add.
1879         (map_functions_to_dict): Parse JavaScript source by splitting on
1880         /^function\s+/ regex.  This is good enough for the sanity checks
1881         to keep function implementations in sync.
1882         (strip_blank_lines_and_comments): Strips blank lines and lines
1883         with comments from the end of a chunk of text representing a
1884         function.
1885         (JSTestChecker): New checker.
1886         (JSTestChecker.__init__):
1887         (JSTestChecker.check):
1888         (JSTestChecker.check_js_test_files): Keeps whole files in sync.
1889         (JSTestChecker.check_js_test_functions): Keeps individual
1890         functions in sync.
1891
1892         * Scripts/webkitpy/style/checkers/jstest_unittest.py: Add test
1893         case.
1894         (JSTestTestCase):
1895         (JSTestTestCase.test_map_functions_to_dict):
1896
1897 2017-05-02  Joanmarie Diggs  <jdiggs@igalia.com>
1898
1899         AX: Update implementation of aria-orientation
1900         https://bugs.webkit.org/show_bug.cgi?id=171166
1901
1902         Reviewed by Chris Fleizach.
1903
1904         Return "AXUnknownOrientation" when ATK_STATE_VERTICAL and ATK_STATE_HORIZONTAL
1905         are both absent from the state set. Before we were returning an empty string
1906         which was not consistent with what the Mac port does, thus making shared tests
1907         harder.
1908
1909         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1910         (WTR::AccessibilityUIElement::orientation):
1911
1912 2017-05-01  David Kilzer  <ddkilzer@apple.com>
1913
1914         Stop using sprintf() in JavaScriptCore debugger
1915         <https://webkit.org/b/171512>
1916
1917         Reviewed by Keith Miller.
1918
1919         * Scripts/webkitpy/style/checker.py:
1920         (_PATH_RULES_SPECIFIER): Ignore some formatting checkers since
1921         Source/JavaScriptCore/disassembler/udis86/ is generated code.
1922
1923 2017-05-01  Timothy Horton  <timothy_horton@apple.com>
1924
1925         Expose viewport-fit instead of clip-to-safe-area
1926         https://bugs.webkit.org/show_bug.cgi?id=171503
1927         <rdar://problem/31918249>
1928
1929         Reviewed by Simon Fraser.
1930
1931         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1932         (WTR::UIScriptController::setSafeAreaInsets):
1933         (WTR::UIScriptController::setObscuredInsets): Deleted.
1934         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1935         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1936         (WTR::UIScriptController::setSafeAreaInsets):
1937         (WTR::UIScriptController::setObscuredInsets): Deleted.
1938         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1939         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1940         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1941         (-[TestRunnerWKWebView setOverrideSafeAreaInsets:]):
1942         (-[TestRunnerWKWebView _safeAreaInsetsForFrame:inSuperview:]):
1943         * WebKitTestRunner/ios/TestControllerIOS.mm:
1944         (WTR::TestController::platformResetStateToConsistentValues):
1945         * WebKitTestRunner/ios/UIKitSPI.h:
1946         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1947         (WTR::UIScriptController::setSafeAreaInsets):
1948         (WTR::UIScriptController::setObscuredInsets): Deleted.
1949         Expose a safe area inset setter instead of obscured insets.
1950
1951 2017-05-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1952
1953         Unreviewed, fix the build on a new internal SDK
1954
1955         Replace usages of NSItemProviderRepresentationVisibilityAll with
1956         UIItemProviderRepresentationOptionsVisibilityAll.
1957
1958         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1959         (-[UIItemProvider registerDataRepresentationForTypeIdentifier:withData:]):
1960         (TestWebKitAPI::TEST):
1961
1962 2017-05-01  David Kilzer  <ddkilzer@apple.com>
1963
1964         [Cocoa] Replace uses of [get…Class() alloc] in TestWebKitAPI
1965         <https://webkit.org/b/171493>
1966
1967         Reviewed by Dan Bernstein.
1968
1969         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
1970         Remove UIKit soft-link since TestWebKitAPI links to
1971         UIKit.framework.
1972         (TestWebKitAPI::WebKit1_AudioSessionCategoryIOS_Test): Use
1973         UIWindow and UIWebView classes directly.
1974         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1975         Remove UIKit soft-link since TestWebKitAPI links to
1976         UIKit.framework.
1977         (RequiresUserActionForPlaybackTest::createWebView): Use UIWindow
1978         class directly.
1979
1980 2017-05-01  Brady Eidson  <beidson@apple.com>
1981
1982         Update names in WKURLSchemeHandler/WKURLSchemeHandlerTask APIs.
1983         <rdar://problem/31824838> and https://bugs.webkit.org/show_bug.cgi?id=171508
1984
1985         Reviewed by Andy Estes.
1986
1987         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
1988         (-[SchemeHandler webView:startURLSchemeTask:]):
1989         (-[SchemeHandler webView:stopURLSchemeTask:]):
1990         (-[SchemeHandler webView:startTask:]): Deleted.
1991         (-[SchemeHandler webView:stopTask:]): Deleted.
1992
1993 2017-05-01  Jason Marcell  <jmarcell@apple.com>
1994
1995         Add a new function for getting the Git hash for a pure git directory.
1996         https://bugs.webkit.org/show_bug.cgi?id=171450
1997
1998         Reviewed by David Kilzer.
1999
2000         * Scripts/VCSUtils.pm:
2001         (gitHashForDirectory):
2002
2003 2017-05-01  Joanmarie Diggs  <jdiggs@igalia.com>
2004
2005         [ATK] Expose values of aria-rowcount, aria-colcount, aria-rowindex, aria-colindex, aria-rowspan, and aria-colspan as object attributes
2006         https://bugs.webkit.org/show_bug.cgi?id=171496
2007
2008         Reviewed by Chris Fleizach.
2009
2010         Add new attribute names so that the values of the object attributes can be tested.
2011
2012         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2013         (WTR::AccessibilityUIElement::numberAttributeValue):
2014
2015 2017-05-01  Beth Dakin  <bdakin@apple.com>
2016
2017         On-screen panel for candidate bar is in the wrong place when the caret is at the 
2018         start of a paragraph
2019         https://bugs.webkit.org/show_bug.cgi?id=171453
2020         -and corresponding-
2021         rdar://problem/29779764
2022
2023         Reviewed by Tim Horton.
2024
2025         This test hard-codes the y-coordinate for the expected candidateRect. 
2026         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
2027         (TEST):
2028
2029 2017-05-01  David Kilzer  <ddkilzer@apple.com>
2030
2031         check-webkit-style: Enable sprintf(), strcat(), strcpy() and printf() format checks
2032         <https://webkit.org/b/171494>
2033
2034         Reviewed by Brent Fulgham.
2035
2036         * Scripts/webkitpy/style/checkers/cpp.py:
2037         (check_language): Change categories for certain checkers from
2038         'runtime/printf' to 'security/printf' so they are no longer
2039         filtered.
2040         (CppChecker.categories): Add 'security/printf'.
2041         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2042         (CppStyleTest.test_insecure_string_operations): Add new test for
2043         sprintf(), strcat() and strcpy().
2044         (CppStyleTest.test_format_strings): Update test results for new
2045         'security/printf' category use.
2046
2047 2017-05-01  Joanmarie Diggs  <jdiggs@igalia.com>
2048
2049         AX: [GTK] Add support to query for aria-current
2050         https://bugs.webkit.org/show_bug.cgi?id=149016
2051
2052         Reviewed by Chris Fleizach.
2053
2054         Implement support for "AXARIACurrent" string attribute value.
2055
2056         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2057
2058 2017-05-01  David Kilzer  <ddkilzer@apple.com>
2059
2060         REGRESSION (r216000): test-webkitpy fails after adding new soft-linked class checker
2061
2062         Unreviewed.
2063
2064         Follow-up fix for:
2065         [Cocoa] Have check-webkit-style advise against use of [get…Class() alloc]
2066         https://bugs.webkit.org/show_bug.cgi?id=171486
2067
2068         * Scripts/webkitpy/style/checkers/cpp.py:
2069         (check_soft_link_class_alloc): Use (\w+) instead of ([^\s]+) to
2070         match and capture the function name.  The latter also mistakenly
2071         matches C-preprocessor directives.
2072         (CppChecker.categories): Add 'runtime/soft-linked-alloc', which
2073         is a requirement for the CppChecker class.
2074
2075 2017-05-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2076
2077         [GTK] Add automation session API
2078         https://bugs.webkit.org/show_bug.cgi?id=171428
2079
2080         Reviewed by Carlos Alberto Lopez Perez.
2081
2082         Add an automation mode to MiniBrowser using the new API and add a unit test too.
2083
2084         * MiniBrowser/gtk/BrowserWindow.c:
2085         (webViewTitleChanged):
2086         (webViewDecidePolicy):
2087         (newTabCallback):
2088         (openPrivateWindow):
2089         (browserWindowFinalize):
2090         (browser_window_init):
2091         (browser_window_get_or_create_web_view_for_automation):
2092         * MiniBrowser/gtk/BrowserWindow.h:
2093         * MiniBrowser/gtk/main.c:
2094         (createBrowserTab):
2095         (createWebViewForAutomationCallback):
2096         (automationStartedCallback):
2097         (main):
2098         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2099         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp: Added.
2100         (testAutomationSessionRequestSession):
2101         (beforeAll):
2102         (afterAll):
2103
2104 2017-04-30  Dan Bernstein  <mitz@apple.com>
2105
2106         [Cocoa] Have check-webkit-style advise against use of [get…Class() alloc]
2107         https://bugs.webkit.org/show_bug.cgi?id=171486
2108
2109         Reviewed by Sam Weinig.
2110
2111         * Scripts/webkitpy/style/checkers/cpp.py:
2112         (check_soft_link_class_alloc): Added. Looks for [get…Class() alloc] and suggests
2113           alloc…Instance() instead.
2114         (check_style): Invoke new check.
2115
2116 2017-04-30  Brady Eidson  <beidson@apple.com>
2117
2118         More fixing after r215991
2119         https://bugs.webkit.org/show_bug.cgi?id=171483
2120
2121         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2122         (TEST):
2123
2124 2017-04-30  Brady Eidson  <beidson@apple.com>
2125
2126         Updates to _WKWebsiteDataStoreConfiguration cookie storage location SPI.
2127         <rdar://problem/31906397> and https://bugs.webkit.org/show_bug.cgi?id=171483
2128
2129         Reviewed by Geoff Garen (and kind of Andy Estes).
2130
2131         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2132         (TEST):
2133
2134 2017-04-30  Joanmarie Diggs  <jdiggs@igalia.com>
2135
2136         [ATK] Implement support for aria-autocomplete
2137         https://bugs.webkit.org/show_bug.cgi?id=171167
2138
2139         Reviewed by Chris Fleizach.
2140
2141         Add "AXSupportsAutoCompletion" attribute so the presence of
2142         ATK_STATE_SUPPORTS_AUTOCOMPLETION can be tested.
2143
2144         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2145         (WTR::AccessibilityUIElement::boolAttributeValue):
2146
2147 2017-04-30  Joanmarie Diggs  <jdiggs@igalia.com>
2148
2149         [ATK] ARIA treegrid role should be exposed as ATK_ROLE_TREE_TABLE; not ATK_ROLE_TABLE
2150         https://bugs.webkit.org/show_bug.cgi?id=171170
2151
2152         Reviewed by Chris Fleizach.
2153
2154         Add "AXInterfaceTable" attribute to test which elements implement AtkTable.
2155
2156         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2157         (WTR::AccessibilityUIElement::boolAttributeValue):
2158
2159 2017-04-30  Joanmarie Diggs  <jdiggs@igalia.com>
2160
2161         [ATK] Emit object:state-changed:busy event when aria-busy value changes
2162         https://bugs.webkit.org/show_bug.cgi?id=171181
2163
2164         Reviewed by Chris Fleizach.
2165
2166         Add handler for AXElementBusyChanged notifications.
2167
2168         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2169
2170 2017-04-29  Aakash Jain  <aakash_jain@apple.com>
2171
2172         Use PEP8 style guide for raising exceptions in webkitpy.
2173         https://bugs.webkit.org/show_bug.cgi?id=171439
2174
2175         Reviewed by Daniel Bates.
2176
2177         As per https://www.python.org/dev/peps/pep-0008/
2178         "When raising an exception in Python 2, use raise ValueError('message') 
2179         instead of the older form raise ValueError, 'message'"
2180
2181         * Scripts/webkitpy/common/net/irc/ircbot.py: Using new style for raising exceptions.
2182         * Scripts/webkitpy/common/thread/messagepump.py: Same.
2183         * Scripts/webkitpy/tool/bot/queueengine.py: Same.
2184         * Scripts/webkitpy/tool/commands/queues.py: Same.
2185         * Scripts/webkitpy/tool/commands/stepsequence.py: Same.
2186         * Scripts/webkitpy/tool/multicommandtool.py: Same.
2187         * Scripts/webkitpy/tool/steps/abstractstep.py: Same.
2188
2189 2017-04-28  Simon Fraser  <simon.fraser@apple.com>
2190
2191         Add system trace points for Document::updateTouchEventRegions()
2192         https://bugs.webkit.org/show_bug.cgi?id=171470
2193         rdar://problem/31901239
2194
2195         Reviewed by Tim Horton.
2196
2197         Add trace markers for updateTouchEventRegions.
2198
2199         * Tracing/SystemTracePoints.plist:
2200
2201 2017-04-28  Jonathan Bedard  <jbedard@apple.com>
2202
2203         webkitpy: Add apple_additions to webkitpy to insert Internal tools
2204         https://bugs.webkit.org/show_bug.cgi?id=170461
2205         <rdar://problem/31433077>
2206
2207         Reviewed by Daniel Bates.
2208
2209         Allow a package to be pulled in by run-webkit-tests which provides an interface to
2210         run layout tests on an iOS device.  If this package is not available, throw an
2211         exception when attempting to run layout tests on an iOS device.
2212
2213         * Scripts/webkitpy/port/config.py:
2214         (apple_additions): Import apple_additions package.
2215         * Scripts/webkitpy/port/device.py:
2216         (Device.install_dylibs): Pass a directory with all the frameworks and dylibs to be
2217         installed on a device.
2218         (Device.prepare_for_testing): Pass a list of ports to forward from the device to the
2219         host, the bundle id of the app to be used for testing and a path to the layout test
2220         directory to be mounted on the device.
2221         (Device.finished_testing):
2222         * Scripts/webkitpy/port/factory.py:
2223         (platform_options): Add apple_additions platform options if apple_additions exists.
2224         * Scripts/webkitpy/port/ios.py:
2225         (IOSPort.setup_test_run): Install dylibs and frameworks on the device, pass ports
2226         to forward, the bundle ID of the testing app and the layout tests directory to
2227         each device.
2228         * Scripts/webkitpy/port/ios_device.py:
2229         (IOSDevicePort):
2230         (IOSDevicePort.default_child_processes): Query apple_additions for the number of child
2231         processes to be run.
2232         (IOSDevicePort.using_multiple_devices): Always assume multiple devices are used. When
2233         a single device is used, it is still accessed through an array.
2234         (IOSDevicePort._device_for_worker_number_map): Query apple_additions for the device
2235         for worker number map.
2236         (IOSDevicePort._driver_class): Query apple_additions for the test driver.
2237         (IOSDevicePort.determine_full_port_name): Use class variable over hard-coded string.
2238         (IOSDevicePort.check_for_leaks): No implementation for iOSDevicePort.
2239         (IOSDevicePort.look_for_new_crash_logs): Ditto.
2240         (IOSDevicePort.look_for_new_samples): Ditto.
2241         (IOSDevicePort.sample_process): Ditto.
2242         (IOSDevicePort._build_driver_flags): Use class variable over hard-coded string.
2243         (IOSDevicePort._create_devices): Check that devices are available for testing and check
2244         that we have enough devices for each child process.
2245         (IOSDevicePort.clean_up_test_run): Have apple_additions preform any needed clean up.
2246         * Scripts/webkitpy/port/ios_device_unittest.py:
2247         (IOSDeviceTest.test_operating_system):
2248         (IOSDeviceTest.test_spindump): Override method from DarwinTest.
2249         (IOSDeviceTest.test_sample_process): Ditto.
2250         (IOSDeviceTest.test_sample_process_exception): Ditto.
2251
2252 2017-04-28  Wenson Hsieh  <wenson_hsieh@apple.com>
2253
2254         Fix and re-enable data interaction unit tests
2255         https://bugs.webkit.org/show_bug.cgi?id=171446
2256         <rdar://problem/31820646>
2257
2258         Reviewed by Tim Horton.
2259
2260         Enables all DataInteractionTests, and adjusts file upload tests to no longer write to a temporary file before
2261         registering with the UIItemProvider, and instead just register data directly via
2262         -registerDataRepresentationForTypeIdentifier:visibility:loadHandler:.
2263
2264         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2265         (TestWebKitAPI::TEST):
2266         (temporaryURLForDataInteractionFileLoad): Deleted.
2267         (cleanUpDataInteractionTemporaryPath): Deleted.
2268         (-[UIItemProvider registerFileRepresentationForTypeIdentifier:withData:filename:]): Deleted.
2269         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2270         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2271
2272 2017-04-28  Brady Eidson  <beidson@apple.com>
2273
2274         Teach the DatabaseProcess to be fully SessionID aware
2275         https://bugs.webkit.org/show_bug.cgi?id=171451
2276
2277         Reviewed by Geoffrey Garen.
2278
2279         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2280
2281 2017-04-28  Jonathan Bedard  <jbedard@apple.com>
2282
2283         Unreviewed follow-up to r214705.
2284
2285         shut.copytree will fail if given a file as an argument instead of a directory.
2286
2287         * Scripts/webkitpy/common/system/filesystem.py:
2288         (FileSystem.copy_to_base_host): Use copytree when source is a directory and copyfile
2289         when source is a file.
2290         (FileSystem.copy_from_base_host): Ditto.
2291
2292 2017-04-28  Chris Dumez  <cdumez@apple.com>
2293
2294         Update DOMTokenList.replace() to match the latest DOM specification
2295         https://bugs.webkit.org/show_bug.cgi?id=171388
2296
2297         Reviewed by Alex Christensen.
2298
2299         Add API test coverage for new Vector API.
2300
2301         * TestWebKitAPI/Tests/WTF/Vector.cpp:
2302         (TestWebKitAPI::TEST):
2303
2304 2017-04-28  Jonathan Bedard  <jbedard@apple.com>
2305
2306         WebKitTestRunner/DumpRenderTree prevent device from sleeping
2307         https://bugs.webkit.org/show_bug.cgi?id=170731
2308
2309         Reviewed by Alex Christensen.
2310
2311         While running layout tests on a device, the device should not be put asleep.
2312
2313         * DumpRenderTree/mac/DumpRenderTree.mm:
2314         (dumpRenderTree): Disable idle timer.
2315         * WebKitTestRunner/ios/TestControllerIOS.mm:
2316         (WTR::TestController::platformInitialize): Ditto.
2317
2318 2017-04-28  Brady Eidson  <beidson@apple.com>
2319
2320         Start of support for multiple WebsiteDataStore/SessionIDs per process
2321         https://bugs.webkit.org/show_bug.cgi?id=171422
2322
2323         Reviewed by Geoffrey Garen.
2324
2325         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2326         (TEST):
2327
2328 2017-04-28  Youenn Fablet  <youenn@apple.com>
2329
2330         Adding a runtime flag specific to MediaDevices
2331         https://bugs.webkit.org/show_bug.cgi?id=171433
2332
2333         Reviewed by Geoffrey Garen.
2334
2335         Updating WTR and DRT as peer connection and media stream runtime flags are enabled by default.
2336         Setting media devices runtime flag to true for WTR and DRT.
2337
2338         * DumpRenderTree/mac/DumpRenderTree.mm:
2339         (enableExperimentalFeatures):
2340         (resetWebPreferencesToConsistentValues):
2341         * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp:
2342         (TestWebKitAPI::TEST):
2343         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
2344         (TestWebKitAPI::TEST):
2345         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2346         (WTR::InjectedBundle::beginTesting):
2347         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2348         (WTR::TestRunner::setMediaDevicesEnabled):
2349         (WTR::TestRunner::setMediaStreamEnabled): Deleted.
2350         (WTR::TestRunner::setPeerConnectionEnabled): Deleted.
2351         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2352         * WebKitTestRunner/TestController.cpp:
2353         (WTR::TestController::resetPreferencesToConsistentValues):
2354
2355 2017-04-28  Dean Jackson  <dino@apple.com>
2356
2357         [WebGPU] Label MTLCommandQueues with a prefix for internal telemetry
2358         https://bugs.webkit.org/show_bug.cgi?id=171441
2359         <rdar://problem/31826915>
2360
2361         Reviewed by Tim Horton.
2362
2363         Add an API test for GPUCommandQueue, exercising creation
2364         and setting the label.
2365
2366         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2367         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Added.
2368         (TestWebKitAPI::TEST_F):
2369
2370 2017-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
2371
2372         [ATK] aria-modal="true" should be exposed via ATK_STATE_MODAL
2373         https://bugs.webkit.org/show_bug.cgi?id=171188
2374
2375         Reviewed by Chris Fleizach.
2376
2377         Add "AXModal" attribute string so that we can test the state's exposure.
2378
2379         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2380         (WTR::AccessibilityUIElement::boolAttributeValue):
2381
2382 2017-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
2383
2384         [ATK] GridCellRole should implement AtkTableCell (regression?)
2385         https://bugs.webkit.org/show_bug.cgi?id=171179
2386
2387         Reviewed by Chris Fleizach.
2388
2389         Add new "AXInterfaceTableCell" attribute so that we can test whether or
2390         not there is an implementation of AtkTableCell (i.e. without risking false
2391         negatives from bugs in the interface's implementation).
2392
2393         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2394         (WTR::AccessibilityUIElement::boolAttributeValue):
2395
2396 2017-04-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2397
2398         Move UUID from WebCore/platform to WTF
2399         https://bugs.webkit.org/show_bug.cgi?id=171372
2400
2401         Reviewed by Michael Catanzaro.
2402
2403         * WebKitTestRunner/TestController.cpp:
2404
2405 2017-04-27  Alex Christensen  <achristensen@webkit.org>
2406
2407         Add stub SPI for setting cookie storage path on _WKWebsiteDataStoreConfiguration
2408         https://bugs.webkit.org/show_bug.cgi?id=171399
2409
2410         Reviewed by Brady Eidson.
2411
2412         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.html:
2413         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2414         (TEST):
2415
2416 2017-04-27  Ryan Haddad  <ryanhaddad@apple.com>
2417
2418         Disable flaky API test WKWebView.SetOverrideContentSecurityPolicyWithEmptyStringForPageWithCSP.
2419         https://bugs.webkit.org/show_bug.cgi?id=167914
2420
2421         Unreviewed test gardening.
2422
2423         * TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm:
2424         (TEST):
2425
2426 2017-04-26  Saam Barati  <sbarati@apple.com>
2427
2428         Add some more testing modes for Wasm tests now that we have tier up
2429         https://bugs.webkit.org/show_bug.cgi?id=171360
2430
2431         Reviewed by Keith Miller.
2432
2433         Lets enable the FTL on all Wasm tests. Let's also run each
2434         test with and without CJIT.
2435
2436         * Scripts/run-jsc-stress-tests:
2437
2438 2017-04-26  Aakash Jain  <aakash_jain@apple.com>
2439
2440         JSC EWS Patch Relevance skips few JSC scripts
2441         https://bugs.webkit.org/show_bug.cgi?id=171351
2442
2443         Reviewed by Alexey Proskuryakov.
2444
2445         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
2446         (CheckPatchRelevance): Added few jsc related scripts.
2447
2448 2017-04-26  Youenn Fablet  <youenn@apple.com>
2449
2450         Test importer should delete obsolete files based on w3c-import.log
2451         https://bugs.webkit.org/show_bug.cgi?id=171348
2452
2453         Reviewed by Chris Dumez.
2454
2455         * Scripts/webkitpy/w3c/test_importer.py:
2456         (TestImporter.do_import): Removing dangling -expected.txt files in regular import mode.
2457         (TestImporter.remove_deleted_files): Fixing according w3c-import.log current format.
2458         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2459         (test_remove_obsolete_content):
2460
2461 2017-04-26  Jonathan Bedard  <jbedard@apple.com>
2462
2463         REGRESSION (r213926): We're sometimes trying to start WebKitTestRunner without proper DYLD variables
2464         <rdar://problem/31816459>
2465
2466         Unreviewed infrastructure fix.
2467
2468         Some of our iOS Simulator bots are slow and will register crashes due to an incorrect
2469         DYLD_FRAMEWORK_PATH when installing an app.
2470
2471         * Scripts/webkitpy/port/ios.py:
2472         (IOSPort.setup_test_run): Pass DYLD_FRAMEWORK_PATH to app on install.
2473
2474 2017-04-26  Joanmarie Diggs  <jdiggs@igalia.com>
2475
2476         [ATK] Elements with a defined, non-false value for aria-current should expose ATK_STATE_ACTIVE
2477         https://bugs.webkit.org/show_bug.cgi?id=171163
2478
2479         Reviewed by Chris Fleizach.
2480
2481         Add support for state-change notifications for ATK_STATE_ACTIVE.
2482
2483         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2484
2485 2017-04-26  Jonathan Bedard  <jbedard@apple.com>
2486
2487         webkitpy: Teardown iOS Simulators on exit if managed Simulators are still running
2488         https://bugs.webkit.org/show_bug.cgi?id=171293
2489
2490         Reviewed by Aakash Jain.
2491
2492         We should make an effort to teardown simulators which we booted even when an exception is
2493         thrown while booting. Make some IOSSimulatorPort functions into static methods and register
2494         one of these functions to be run at exit to ensure any devices webkitpy is managing gets
2495         torn down.
2496
2497         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2498         (Manager._set_up_run): Rely on exit handlers to teardown, not exceptions.
2499         * Scripts/webkitpy/port/ios_simulator.py:
2500         (IOSSimulatorPort._teardown_managed_simulators): Function run on exit which will kill all
2501         iOS simulators and teardown and managed devices.
2502         (IOSSimulatorPort._create_simulators): Register teardown function.
2503         (IOSSimulatorPort.clean_up_test_run): Move device teardown to _teardown_managed_simulators.
2504         (IOSSimulatorPort._remove_device): Deleted.
2505
2506 2017-04-26  Joanmarie Diggs  <jdiggs@igalia.com>
2507
2508         [ATK] Implement support for new ARIA 1.1 values of aria-haspopup
2509         https://bugs.webkit.org/show_bug.cgi?id=171164
2510
2511         Reviewed by Chris Fleizach.
2512
2513         hasPopup() should return whether or not ATK_STATE_HAS_POPUP is in the
2514         AtkStateSet; not what is found in the AtkObject's attributes.
2515
2516         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2517         (WTR::AccessibilityUIElement::hasPopup):
2518
2519 2017-04-25  Alex Christensen  <achristensen@webkit.org>
2520
2521         Encoded filename should be decoded for WKContentExtension.identifier
2522         https://bugs.webkit.org/show_bug.cgi?id=171316
2523
2524         Reviewed by Andy Estes.
2525
2526         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2527         * TestWebKitAPI/Tests/WebKit2Cocoa/WKContentExtensionStore.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm.
2528         (TEST_F):
2529         * TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm: Removed.
2530
2531 2017-04-25  Alex Christensen  <achristensen@webkit.org>
2532
2533         REGRESSION(206450): WebKit2PlatformMouseEvent m_modifierFlags not set
2534         https://bugs.webkit.org/show_bug.cgi?id=171297
2535         <rdar://problem/31530719>
2536
2537         Reviewed by Geoffrey Garen.
2538
2539         * TestWebKitAPI/PlatformWebView.h:
2540         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2541         * TestWebKitAPI/Tests/WebKit2/EventModifiers.cpp: Added.
2542         (TestWebKitAPI::didFinishLoadForFrame):
2543         (TestWebKitAPI::mouseDidMoveOverElement):
2544         (TestWebKitAPI::setClients):
2545         (TestWebKitAPI::TEST):
2546         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2547         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2548         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
2549
2550 2017-04-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2551
2552         Unreviewed, temporarily disable the data interaction unit tests.
2553
2554         The API around data interaction will change significantly in the near future, and
2555         these tests will begin to fail. These will be reenabled once the bots are on an SDK
2556         that supports the updated data interaction API.
2557
2558         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2559         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2560         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2561
2562 2017-04-25  Brent Fulgham  <bfulgham@apple.com>
2563
2564         Limit allowed size of document.title to avoid locking WebKit clients
2565         https://bugs.webkit.org/show_bug.cgi?id=165113
2566         <rdar://problem/28324389>
2567
2568         Reviewed by Darin Adler.
2569
2570         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2571         * TestWebKitAPI/Tests/WebKit2/LimitTitleSize.cpp: Added.
2572         * TestWebKitAPI/Tests/WebKit2/set-long-title.html: Added.
2573         * TestWebKitAPI/Tests/mac/LimitTitleSize.mm: Added.
2574
2575 2017-04-25  John Wilander  <wilander@apple.com>
2576
2577         Resource Load Statistics: Introduce shorter time-to-live for cookie partition whitelisting
2578         https://bugs.webkit.org/show_bug.cgi?id=171295
2579         <rdar://problem/31823818>
2580
2581         Reviewed by Brent Fulgham.
2582
2583         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2584         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2585         (WTR::TestRunner::setStatisticsTimeToLiveCookiePartitionFree):
2586         (WTR::TestRunner::statisticsFireShouldPartitionCookiesHandler):
2587         (WTR::TestRunner::statisticsFireShouldPartitionCookiesHandlerForOneDomain):
2588         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2589         * WebKitTestRunner/TestController.cpp:
2590         (WTR::TestController::setStatisticsTimeToLiveCookiePartitionFree):
2591         (WTR::TestController::statisticsFireShouldPartitionCookiesHandler):
2592         (WTR::TestController::statisticsFireShouldPartitionCookiesHandlerForOneDomain):
2593         * WebKitTestRunner/TestController.h:
2594         * WebKitTestRunner/TestInvocation.cpp:
2595         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2596
2597 2017-04-25  Tim Horton  <timothy_horton@apple.com>
2598
2599         Try to fix the WKTR build after r215758
2600
2601         * Scripts/build-webkittestrunner:
2602
2603 2017-04-25  Daniel Bates  <dabates@apple.com>
2604
2605         Remove more EFL code
2606         https://bugs.webkit.org/show_bug.cgi?id=171288
2607
2608         Rubber-stamped by Simon Fraser.
2609
2610         The EFL port is no longer in the WebKit OpenSource Project repository. Remove more code
2611         that was part of the EFL port.
2612
2613         * CMakeLists.txt:
2614         * DumpRenderTree/AccessibilityController.h:
2615         * DumpRenderTree/AccessibilityUIElement.cpp:
2616         (AccessibilityUIElement::getJSClass):
2617         * DumpRenderTree/AccessibilityUIElement.h:
2618         * DumpRenderTree/DumpRenderTree.h:
2619         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
2620         * ImageDiff/efl/ImageDiff.cpp: Removed.
2621         * MiniBrowser/efl/CMakeLists.txt: Removed.
2622         * MiniBrowser/efl/main.c: Removed.
2623         * Scripts/build-dumprendertree:
2624         * Scripts/build-jsc:
2625         * Scripts/build-webkit:
2626         * Scripts/build-webkittestrunner:
2627         * Scripts/run-minibrowser:
2628         * Scripts/update-webkit-libs-jhbuild:
2629         * Scripts/update-webkitefl-libs: Removed.
2630         * Scripts/webkitdirs.pm:
2631         (argumentsForConfiguration):
2632         (extractNonMacOSHostConfiguration):
2633         (executableProductDir):
2634         (builtDylibPathForName):
2635         (determinePortName):
2636         (launcherPath):
2637         (launcherName):
2638         (getJhbuildPath):
2639         (wrapperPrefixIfNeeded):
2640         (generateBuildSystemFromCMakeProject):
2641         (buildCMakeProjectOrExit):
2642         (isEfl): Deleted.
2643         * Scripts/webkitperl/FeatureList.pm:
2644         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl:
2645         * Scripts/webkitpy/common/config/ports.py:
2646         (DeprecatedPort.port):
2647         (GtkWK2Port.run_webkit_tests_command):
2648         (EflWK2Port): Deleted.
2649         (EflWK2Port.build_webkit_command): Deleted.
2650         * Scripts/webkitpy/port/builders.py:
2651         * Scripts/webkitpy/port/efl.py: Removed.
2652         * Scripts/webkitpy/port/efl_unittest.py: Removed.
2653         * Scripts/webkitpy/port/factory.py:
2654         (platform_options):
2655         (PortFactory):
2656         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2657         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
2658         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2659         (TestRebaselineTest.test_baseline_directory):
2660         (TestRebaselineExpectations.test_rebaseline_expectations):
2661         * TestWebKitAPI/PlatformEfl.cmake: Removed.
2662         * TestWebKitAPI/PlatformWebView.h:
2663         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2664         (TestWebKitAPI::TEST):
2665         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp: Removed.
2666         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Removed.
2667         * TestWebKitAPI/Tests/WebKit2/efl/WKViewScrollTo.cpp: Removed.
2668         * TestWebKitAPI/Tests/WebKit2/efl/scrollTo.html: Removed.
2669         * TestWebKitAPI/efl/InjectedBundleController.cpp: Removed.
2670         * TestWebKitAPI/efl/PlatformUtilities.cpp: Removed.
2671         * TestWebKitAPI/efl/PlatformWebView.cpp: Removed.
2672         * TestWebKitAPI/efl/main.cpp: Removed.
2673         * WebKitTestRunner/EventSenderProxy.h:
2674         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2675         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2676         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2677         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2678         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2679         (WTR::EventSendingController::contextClick):
2680         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2681         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2682         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
2683         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
2684         * WebKitTestRunner/InjectedBundle/efl/ActivateFontsEfl.cpp: Removed.
2685         * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp: Removed.
2686         * WebKitTestRunner/InjectedBundle/efl/FontManagement.h: Removed.
2687         * WebKitTestRunner/InjectedBundle/efl/InjectedBundleEfl.cpp: Removed.
2688         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp: Removed.
2689         * WebKitTestRunner/PlatformEfl.cmake: Removed.
2690         * WebKitTestRunner/PlatformWebView.h:
2691         * WebKitTestRunner/TestController.cpp:
2692         (WTR::TestController::resetStateToConsistentValues):
2693         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Removed.
2694         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: Removed.
2695         * WebKitTestRunner/efl/TestControllerEfl.cpp: Removed.
2696         * WebKitTestRunner/efl/main.cpp: Removed.
2697         * efl/install-dependencies: Removed.
2698         * efl/jhbuild-optional.modules: Removed.
2699         * efl/jhbuild.modules: Removed.
2700         * efl/jhbuildrc: Removed.
2701         * efl/patches/evas-fix-build-with-giflib5.patch: Removed.
2702         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Removed.
2703         * efl/patches/gst-libav.patch: Removed.
2704         * efl/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed.
2705         * efl/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
2706         * efl/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
2707         * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Removed.
2708         * gtk/manifest.txt.in:
2709
2710 2017-04-25  Daniel Bates  <dabates@apple.com>
2711
2712         [Cocoa][Win] Enable of X-Content-Type-Options: nosniff header
2713         https://bugs.webkit.org/show_bug.cgi?id=136452
2714         <rdar://problem/23412620>
2715
2716         Reviewed by Brent Fulgham.
2717
2718         Enable X-Content-Type-Options: nosniff on Mac, iOS and Windows platforms.
2719
2720         * Scripts/webkitperl/FeatureList.pm: Also do not enable nosniff on EFL
2721         as the EFL port is no longer in the WebKit OpenSource repository.
2722         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2723
2724 2017-04-25  Zan Dobersek  <zdobersek@igalia.com>
2725
2726         Unreviewed follow-up to r215739 and r215740.
2727
2728         * gtk/jhbuild.modules: List the libgcrypt patch that has to be applied.
2729         This (and r215740) was supposed to land in r215739, but I managed to
2730         specify the previous version of the patch.
2731
2732 2017-04-25  Zan Dobersek  <zdobersek@igalia.com>
2733
2734         Unreviewed follow-up to r215739.
2735
2736         * gtk/patches/libgcrypt-use-only-dev-urandom-for-testing.patch: Add the missing
2737         libgcrypt patch that enforces the use of /dev/urandom.
2738
2739 2017-04-25  Zan Dobersek  <zdobersek@igalia.com>
2740
2741         [GTK] Add libgpg-error, libgcrypt libraries to JHBuild
2742         https://bugs.webkit.org/show_bug.cgi?id=171270
2743
2744         Reviewed by Michael Catanzaro.
2745
2746         * gtk/jhbuild.modules: Add the latest stable versions of libgpg-error and libgcrypt
2747         libraries to the webkitgtk-testing-dependencies metamodule. This will help people
2748         that use systems that don't yet provide libgcrypt >= 1.7.0.
2749
2750 2017-04-25  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2751
2752         [GTK] Improve an unit test for the JHBuild wrapper.
2753         https://bugs.webkit.org/show_bug.cgi?id=168036
2754
2755         Unreviewed follow-up patch after r215727
2756
2757         * Scripts/webkitpy/port/base_unittest.py:
2758         (test_jhbuild_wrapper): Improve the unit test by ensuring the directory
2759         wasn't there before calling MockFileSystem.maybe_make_directory(), and
2760         also that it exists after calling it.
2761
2762 2017-04-25  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2763
2764         [GTK] ImageDiff should be run by jhbuild-wrapper in case of using jhbuild
2765         https://bugs.webkit.org/show_bug.cgi?id=168036
2766
2767         Reviewed by Michael Catanzaro.
2768
2769         Call ImageDiff with the JHBuild wrapper if we should use it.
2770         Also add some unit tests for the JHBuild wrapper feature.
2771
2772         * Scripts/webkitpy/port/base.py:
2773         (Port._should_use_jhbuild): Use self._filesystem instead of os.path to allow mock testing.
2774         * Scripts/webkitpy/port/base_unittest.py:
2775         (test_jhbuild_wrapper): Add a test for port._should_use_jhbuild()
2776         * Scripts/webkitpy/port/image_diff.py:
2777         (ImageDiffer._start): The actual fix, use the wrapper if we should.
2778         * Scripts/webkitpy/port/image_diff_unittest.py: Removed. This two tests are now integrated in port_testcase
2779         * Scripts/webkitpy/port/port_testcase.py:
2780         (PortTestCase):
2781         (PortTestCase.test_diff_image): Test the command with wrapper and without it.
2782         (PortTestCase.test_diff_image_passed): Moved from image_diff_unittest.py
2783         (PortTestCase.test_diff_image_failed): Moved from image_diff_unittest.py
2784
2785 2017-04-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2786
2787         Support reading NSURL titles from the pasteboard when performing data interaction
2788         https://bugs.webkit.org/show_bug.cgi?id=171156
2789         <rdar://problem/31356937>
2790
2791         Reviewed by Tim Horton.
2792
2793         Adds a new unit test, DataInteractionTests.ExternalSourceTitledNSURL.
2794
2795         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2796         (TestWebKitAPI::TEST):
2797
2798 2017-04-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2799
2800         Respect fidelity order when reading web content from item providers
2801         https://bugs.webkit.org/show_bug.cgi?id=171155
2802         <rdar://problem/31356937>
2803
2804         Reviewed by Tim Horton.
2805
2806         Adds a new unit test (DataInteractionTests.RespectsExternalSourceFidelityRankings). See WebCore ChangeLog for
2807         more details.
2808
2809         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2810         (TestWebKitAPI::TEST):
2811
2812 2017-04-24  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2813
2814         SyntaxError fix after r215702.
2815         https://bugs.webkit.org/show_bug.cgi?id=168944
2816
2817         Unreviewed "build" fix.
2818
2819         * BuildSlaveSupport/built-product-archive:
2820         (archiveBuiltProduct):
2821
2822 2017-04-24  Jonathan Bedard  <jbedard@apple.com>
2823
2824         Package ImageDiff built with host SDK
2825         https://bugs.webkit.org/show_bug.cgi?id=168944
2826         <rdar://problem/30745642>
2827
2828         Reviewed by David Kilzer.
2829
2830         iOS Simulator and iOS device should archive the ImageDiff built for the host
2831         machine.
2832
2833         * BuildSlaveSupport/built-product-archive:
2834         (determineWebKitBuildDirectories): Add _hostBuildDirectory for iOS.
2835         (archiveBuiltProduct): Archive Mac products for iOS so that ImageDiff is included.
2836
2837 2017-04-24  Keith Miller  <keith_miller@apple.com>
2838
2839         ThreadMessage API tests failing on release bots
2840         https://bugs.webkit.org/show_bug.cgi?id=171246
2841
2842         Reviewed by Saam Barati.
2843
2844         Need to make sure that C++ doesn't optimize away our spin loop.
2845
2846         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
2847         (runThreadMessageTest):
2848         (TEST):
2849
2850 2017-04-24  Alex Christensen  <achristensen@webkit.org>
2851
2852         Reduce copies and allocations in SharedBuffer::append
2853         https://bugs.webkit.org/show_bug.cgi?id=170956
2854
2855         Reviewed by Andreas Kling.
2856
2857         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
2858         (TestWebKitAPI::TEST_F):
2859
2860 2017-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2861
2862         [GTK] Switch to use ENABLE_REMOTE_INSPECTOR instead of ENABLE_INSPECTOR_SERVER for the remote inspector
2863         https://bugs.webkit.org/show_bug.cgi?id=166680
2864
2865         Reviewed by Michael Catanzaro.
2866
2867         Update remote inspector unit tests.
2868
2869         * TestWebKitAPI/Tests/WebKit2Gtk/InspectorTestServer.cpp:
2870         (main):
2871         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
2872         (connectToInspectorServer):
2873         (waitUntilInspectorServerIsReady):
2874         (startTestServer):
2875         (testInspectorServerPageList):
2876         (beforeAll):
2877
2878 2017-04-23  Youenn Fablet  <youenn@apple.com>
2879
2880         Add a tool to update expected.txt files from EWS bot results
2881         https://bugs.webkit.org/show_bug.cgi?id=169538
2882
2883         Reviewed by Ryosuke Niwa.
2884
2885         This script updates expected-txt files from bugzilla posted EWS results.
2886         It uses mac-wk2 as the generic baseline and adds platform-specific results if other ports
2887         have results different from the generic baseline.
2888
2889         * Scripts/update-test-expectations-from-bugzilla: Added.
2890         * Scripts/webkitpy/common/net/bugzilla/test_expectation_updater.py: Added.
2891         * Scripts/webkitpy/common/net/bugzilla/test_expectation_updater_unittest.py: Added.
2892         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: Adding helper routines.
2893
2894 2017-04-22  Youenn Fablet  <youenn@apple.com>
2895
2896         Add an option to import tip-of-tree WPT tests
2897         https://bugs.webkit.org/show_bug.cgi?id=171152
2898
2899         Reviewed by Joseph Pecoraro.
2900
2901         Adding a '-t' option to import tip of tree WPT tests.
2902         Updating importer based on the fact that csswg-test is no longer a thing. 
2903
2904         * Scripts/webkitpy/w3c/test_downloader.py:
2905         (TestDownloader.download_tests):
2906         * Scripts/webkitpy/w3c/test_importer.py:
2907         (configure_logging):
2908         (TestImporter.do_import):
2909         (TestImporter.write_import_log):
2910
2911 2017-04-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2912
2913         File inputs only accept UTI types that can be inserted into contenteditable areas when dropping
2914         https://bugs.webkit.org/show_bug.cgi?id=171177
2915         <rdar://problem/31765379>
2916
2917         Reviewed by Andy Estes.
2918
2919         Tests uploading a JSON file to a file input.
2920
2921         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2922         (TestWebKitAPI::TEST):
2923
2924 2017-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2925
2926         Support writing link titles to the pasteboard when beginning data interaction on a link
2927         https://bugs.webkit.org/show_bug.cgi?id=171154
2928         <rdar://problem/31356937>
2929
2930         Reviewed by Andy Estes.
2931
2932         Augments an existing unit test, DataInteractionTests.LinkToInput, to also check that the fetching the NSURL from
2933         the source UIItemProvider generated by performing data interaction results in an NSURL with the _title attribute
2934         matching the title of the link.
2935
2936         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2937         (TestWebKitAPI::TEST):
2938
2939 2017-04-21  Michael Catanzaro  <mcatanzaro@igalia.com>
2940
2941         Unreviewed, rolling out r215608.
2942
2943         Hundreds of test failures on GTK bot
2944
2945         Reverted changeset:
2946
2947         "Reduce copies and allocations in SharedBuffer::append"
2948         https://bugs.webkit.org/show_bug.cgi?id=170956
2949         http://trac.webkit.org/changeset/215608
2950
2951 2017-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2952
2953         [WK2] Add delegate hooks for overriding unhanded data interaction operations
2954         https://bugs.webkit.org/show_bug.cgi?id=171005
2955         <rdar://problem/31669646>
2956
2957         Reviewed by Tim Horton.
2958
2959         Adds a new API test checking that normal WebKit behavior when vending updated data interaction operations may
2960         be overridden, resulting in a data interaction operation being performed when it otherwise would not have. Also
2961         adjusts for some changes in WebKit2 (See WebKit2 ChangeLog for more details).
2962
2963         New API test:
2964         DataInteractionTests.OverrideDataInteractionOperation
2965
2966         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2967         (-[UIItemProvider registerDataRepresentationForTypeIdentifier:withData:]):
2968         (TestWebKitAPI::TEST):
2969         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2970         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2971         (-[DataInteractionSimulator initWithWebView:]):
2972         (-[DataInteractionSimulator dealloc]):
2973         (-[DataInteractionSimulator _webView:dataInteractionOperationWasHandled:forSession:itemProviders:]):
2974         (-[DataInteractionSimulator _webView:willUpdateDataInteractionOperationToOperation:forSession:]):
2975         (-[DataInteractionSimulator webViewDidPerformDataInteractionControllerOperation:]): Deleted.
2976
2977 2017-04-21  Ryan Haddad  <ryanhaddad@apple.com>
2978
2979         Temporarily disable two flaky API tests.
2980
2981         Unreviewed test gardening.
2982
2983         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
2984         (TEST):
2985         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
2986         (TEST):
2987
2988 2017-04-21  Keith Miller  <keith_miller@apple.com>
2989
2990         Unreviewed, rolling out r215634.
2991
2992         underlying build issues should have been fixed
2993
2994         Reverted changeset:
2995
2996         "Unreviewed, rolling out r215620 and r215623."
2997         https://bugs.webkit.org/show_bug.cgi?id=171139
2998         http://trac.webkit.org/changeset/215634
2999
3000 2017-04-21  Aakash Jain  <aakash_jain@apple.com>
3001
3002         Bubbles on dashboard doesn't turn red for test262 failures
3003         https://bugs.webkit.org/show_bug.cgi?id=171129
3004
3005         Reviewed by Alexey Proskuryakov.
3006
3007         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Added test262-test.
3008
3009 2017-04-21  Commit Queue  <commit-queue@webkit.org>
3010
3011         Unreviewed, rolling out r215620 and r215623.
3012         https://bugs.webkit.org/show_bug.cgi?id=171139
3013
3014         broke arm64 build (Requested by keith_miller on #webkit).
3015
3016         Reverted changesets:
3017
3018         "Add signaling API"
3019         https://bugs.webkit.org/show_bug.cgi?id=170976
3020         http://trac.webkit.org/changeset/215620
3021
3022         "Unreviewed, fix Cloop build."
3023         http://trac.webkit.org/changeset/215623
3024
3025 2017-04-20  Keith Miller  <keith_miller@apple.com>
3026
3027         Add signaling API
3028         https://bugs.webkit.org/show_bug.cgi?id=170976
3029
3030         Reviewed by Filip Pizlo.
3031
3032         Add tests for ThreadMessages.
3033
3034         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3035         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp: Added.
3036         (runThreadMessageTest):
3037         (TEST):
3038
3039 2017-04-20  Conrad Shultz  <conrad_shultz@apple.com>
3040
3041         commit-log-editor should respect the git editor if one is set
3042         https://bugs.webkit.org/show_bug.cgi?id=171085
3043         <rdar://problem/31745506>
3044
3045         Reviewed by Daniel Bates.
3046
3047         * Scripts/commit-log-editor:
3048         If Git is available, consider GIT_LOG_EDITOR and any global Git editor preference when
3049         deciding which editor to present. We examine the global editor preference since that may be
3050         set automatically by installers or third-party tools.
3051
3052 2017-04-21  Alex Christensen  <achristensen@webkit.org>
3053
3054         Reduce copies and allocations in SharedBuffer::append
3055         https://bugs.webkit.org/show_bug.cgi?id=170956
3056
3057         Reviewed by Andreas Kling.
3058
3059         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
3060         (TestWebKitAPI::TEST_F):
3061
3062 2017-04-20  Konstantin Tokarev  <annulen@yandex.ru>
3063
3064         [cmake] Define FORWARDING_HEADERS_DIR in WebKitFS and use it everywhere
3065         https://bugs.webkit.org/show_bug.cgi?id=171071
3066
3067         Reviewed by Michael Catanzaro.
3068
3069         "${DERIVED_SOURCES_DIR}/ForwardingHeaders" path occurs very often in the
3070         build system files. GTK-specifc FORWARDING_HEADERS_DIR variable should
3071         be available for all ports.
3072
3073         * DumpRenderTree/PlatformMac.cmake:
3074         * MiniBrowser/mac/CMakeLists.txt:
3075         * MiniBrowser/win/CMakeLists.txt:
3076         * TestWebKitAPI/PlatformJSCOnly.cmake:
3077         * TestWebKitAPI/PlatformMac.cmake:
3078         * TestWebKitAPI/PlatformWin.cmake:
3079         * WebKitTestRunner/PlatformMac.cmake:
3080
3081 2017-04-20  Joseph Pecoraro  <pecoraro@apple.com>
3082
3083         Test262 bot does not go red with failures
3084         https://bugs.webkit.org/show_bug.cgi?id=171044
3085
3086         Reviewed by Aakash Jain.
3087
3088         The piped output of run-jsc-stress-tests is different from
3089         its non-piped output. Switch to parsing the correct output.
3090
3091         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3092         (RunTest262Tests.countFailures):
3093         Just count the number of lines that start with "FAIL:".
3094
3095         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3096         (RunTest262TestsTest.test_no_regressions_output):
3097         (test_failure_output):
3098         (test_failures_output):
3099         Updated tests with new sample output produced partially from bots and
3100         locally. In cases of failure the return code of run-jsc-stress-tests
3101         is still 0 so update the expected return code in the tests.
3102
3103 2017-04-20  Brady Eidson  <beidson@apple.com>
3104
3105         WebContent process becomes unresponsive after returning nil from async version of -webView:createWebViewWithConfiguration:...
3106         <rdar://problem/31739023> and https://bugs.webkit.org/show_bug.cgi?id=171090
3107
3108         Reviewed by Andy Estes.
3109
3110         * TestWebKitAPI/Tests/WebKit2/open-and-close-window.html:
3111         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
3112         (resetToConsistentState):
3113         (-[OpenAndCloseWindowUIDelegate webViewDidClose:]):
3114         (-[OpenAndCloseWindowUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3115         (TEST):
3116         (-[OpenAndCloseWindowUIDelegateAsync _webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:completionHandler:]):
3117
3118 2017-04-20  Wenson Hsieh  <wenson_hsieh@apple.com>
3119
3120         [ios-simulator] PositionInformationTests API tests are timing out
3121         https://bugs.webkit.org/show_bug.cgi?id=171089
3122
3123         Rubber-stamped by Tim Horton.
3124
3125         Addresses failures observed in the new position information tests added in r215573 by only running them if the
3126         DATA_INTERACTION feature flag is enabled.
3127
3128         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm:
3129
3130 2017-04-20  Brady Eidson  <beidson@apple.com>
3131
3132         Skip WebKit2.OpenAndCloseWindowAsyncCallbackException for now.
3133         https://bugs.webkit.org/show_bug.cgi?id=171083
3134
3135         Unreviewed.
3136
3137         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
3138
3139 2017-04-20  Brady Eidson  <beidson@apple.com>
3140
3141         Add CompletionHandlerCallChecker to SPI added in r215545.
3142         https://bugs.webkit.org/show_bug.cgi?id=171067
3143
3144         Reviewed by Dan Bernstein.
3145
3146         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
3147         (TEST):
3148         (-[OpenAndCloseWindowUIDelegateAsync _webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:completionHandler:]):
3149
3150 2017-04-20  Wenson Hsieh  <wenson_hsieh@apple.com>
3151
3152         [WK2] -[WKContentView doAfterPositionInformationUpdate:atPosition:] should be robust against synchronous reentrancy
3153         https://bugs.webkit.org/show_bug.cgi?id=170922
3154         <rdar://problem/31634990>
3155
3156         Reviewed by Tim Horton.
3157
3158         Adds six new unit tests for retrieving interaction information at a given position in the UI process. See
3159         WebKit2 ChangeLog for more details.
3160
3161         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm:
3162         (-[_WKDraggableElementInfo expectToBeLink:image:atPoint:]):
3163         (TestWebKitAPI::TEST):
3164         (TestWebKitAPI::expectCGPointsToBeEqual): Deleted.
3165
3166 2017-04-20  Xan Lopez  <xlopez@igalia.com>
3167
3168         [GTK][jhbuild] Update glib and glib-networking to the latest stable versions
3169         https://bugs.webkit.org/show_bug.cgi?id=170942
3170
3171         Reviewed by Carlos Garcia Campos.
3172
3173         Update glib and glib-networking to the last stable releases. This
3174         is needed to get working TLS certificate verification at all at
3175         least in Fedora.
3176
3177         * gtk/install-dependencies: add libmount, needed for newer glib.
3178         * gtk/jhbuild.modules: update glib and glib-networking to last
3179         stable releases.
3180
3181 2017-04-20  Joanmarie Diggs  <jdiggs@igalia.com>
3182
3183         [ATK] Implement support for DPub ARIA roles
3184         https://bugs.webkit.org/show_bug.cgi?id=170679
3185
3186         Reviewed by Chris Fleizach.
3187
3188         Add DPub ARIA landmark roles to roleToString().
3189
3190         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3191
3192 2017-04-19  Joseph Pecoraro  <pecoraro@apple.com>
3193
3194         Remove WebKitTestRunner code for enabling features that are already enabled by default
3195         https://bugs.webkit.org/show_bug.cgi?id=171033
3196
3197         Reviewed by Ryosuke Niwa.
3198
3199         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3200         (WTR::InjectedBundle::beginTesting):
3201         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3202         (WTR::TestRunner::setShadowDOMEnabled): Deleted.
3203         (WTR::TestRunner::setCustomElementsEnabled): Deleted.
3204         (WTR::TestRunner::setFetchAPIEnabled): Deleted.
3205         (WTR::TestRunner::setDownloadAttributeEnabled): Deleted.
3206         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3207
3208 2017-04-19  Youenn Fablet  <youenn@apple.com>
3209
3210         [Mac] Allow customizing H264 encoder
3211         https://bugs.webkit.org/show_bug.cgi?id=170829
3212
3213         Reviewed by Alex Christensen.
3214
3215         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3216
3217 2017-04-19  Brady Eidson  <beidson@apple.com>
3218
3219         Add asynchronous equivalent of -[<WKUIDelegate> webView:createWebViewWithConfiguration:...].
3220         <rdar://problem/30699851> and https://bugs.webkit.org/show_bug.cgi?id=171018
3221
3222         Reviewed by Tim Horton.
3223
3224         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
3225         (TEST):
3226         (-[OpenAndCloseWindowUIDelegateAsync webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3227         (-[OpenAndCloseWindowUIDelegateAsync _webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:completionHandler:]):
3228
3229 2017-04-19  Brady Eidson  <beidson@apple.com>
3230
3231         REGRESSION (r213168): An extra Web Content process is spun up on launch and is never closed.
3232         <rdar://problem/30774839> and https://bugs.webkit.org/show_bug.cgi?id=171002
3233
3234         Reviewed by Alex Christensen.
3235
3236         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3237         * TestWebKitAPI/Tests/WebKit2Cocoa/InitialWarmedProcessUsed.mm: Added.
3238
3239 2017-04-19  Brent Fulgham  <bfulgham@apple.com>
3240
3241         [WK2] Run tests with ResourceLoadStatistics enabled
3242         https://bugs.webkit.org/show_bug.cgi?id=170952
3243
3244         Reviewed by Andy Estes.
3245
3246         Excercise the load statistics code during tests.
3247
3248         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3249         (WTR::initializeWebViewConfiguration):
3250
3251 2017-04-19  Bill Ming  <mbbill@gmail.com>
3252
3253         close_fds should be set to False on Windows.
3254         https://bugs.webkit.org/show_bug.cgi?id=170838
3255
3256         Reviewed by Brent Fulgham.
3257
3258         * Scripts/webkitpy/common/system/executive.py:
3259         (Executive._should_close_fds):
3260
3261 2017-04-19  David Kilzer  <ddkilzer@apple.com>
3262
3263         Stop using strcpy() in WebKit::EnvironmentUtilities::stripValuesEndingWithString()
3264         <https://webkit.org/b/170994>
3265         <rdar://problem/29889932>
3266
3267         Reviewed by Brent Fulgham.
3268
3269         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3270         (EnvironmentUtilitiesTest.cpp): Add to TestWebKitAPILibrary
3271         target.
3272         * TestWebKitAPI/Tests/WebKit2/EnvironmentUtilitiesTest.cpp: Add.
3273         (TestWebKitAPI::strip): Helper method to set/get environment
3274         variable for testing.
3275         (TestWebKitAPI::WebKit2_StripValuesEndingWithString_Test): Add
3276         tests.
3277
3278 2017-04-19  JF Bastien  <jfbastien@apple.com>
3279
3280         WebAssembly: add script which can import GCC torture tests
3281         https://bugs.webkit.org/show_bug.cgi?id=170740
3282
3283         Reviewed by Saam Barati.
3284
3285         Add a script which can import the GCC torture tests and create a
3286         yaml file to run them as part of jsc's WebAssembly regression
3287         tests.
3288
3289         This patch doesn't commit the tests themselves because they're
3290         licensed differently.
3291
3292         * Scripts/run-jsc-stress-tests: learn how to run
3293         Emscripten-generated .js+.wasm files, and do a bit of cleanup on
3294         the options because WebAssembly is enabled by default.
3295         * Scripts/update-wasm-gcc-torture.py: Added.
3296         (parse_args):
3297         (update_lkgr):
3298         (untar_torture):
3299         (list_js_files):
3300         (waterfall_known_failures):
3301         (create_yaml):
3302         (main):
3303
3304 2017-04-19  Youenn Fablet  <youenn@apple.com>
3305
3306         Import web-platform-tests/tools
3307         https://bugs.webkit.org/show_bug.cgi?id=170718
3308
3309         Reviewed by Alex Christensen.
3310
3311         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
3312         (main):
3313         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3314         (WebPlatformTestServer.ports_to_forward):
3315         (WebPlatformTestServer._prepare_config):
3316         (WebPlatformTestServer._install_modules): Deleted.
3317         * Scripts/webkitpy/w3c/test_importer.py:
3318         (TestImporter.write_html_files_for_templated_js_tests):
3319
3320 2017-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3321
3322         [WK2] Add infrastructure and unit tests for file uploads using data interaction
3323         https://bugs.webkit.org/show_bug.cgi?id=170903
3324         <rdar://problem/31314689>
3325
3326         Reviewed by Tim Horton.
3327
3328         Adds 5 new unit tests covering different cases of uploading files through data interaction, as well as
3329         infrastructure for simulating UIItemProviders that load file data. Makes a few adjustments to the
3330         DataInteractionSimulator along the way, detailed in the per-method annotations below. See
3331         <https://bugs.webkit.org/show_bug.cgi?id=170880> for more details about the change this patch is testing.
3332
3333         New tests:
3334         DataInteractionTests.ExternalSourceImageToFileInput
3335         DataInteractionTests.ExternalSourceHTMLToUploadArea
3336         DataInteractionTests.ExternalSourceImageAndHTMLToSingleFileInput
3337         DataInteractionTests.ExternalSourceImageAndHTMLToMultipleFileInput
3338         DataInteractionTests.ExternalSourceImageAndHTMLToUploadArea
3339
3340         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3341         (testIconImage):
3342         (temporaryURLForDataInteractionFileLoad):
3343         (cleanUpDataInteractionTemporaryPath):
3344
3345         Creates and tears down temporary file directories for testing data interaction.
3346
3347         (-[UIItemProvider registerFileRepresentationForTypeIdentifier:withData:filename:]):
3348         (TestWebKitAPI::TEST):
3349         * TestWebKitAPI/ios/DataInteractionSimulator.h:
3350         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
3351
3352         Make necessary changes to be able to test what happens when data interaction ends over an element with no
3353         operation. Previously, we would always simulate performing a data interaction operation when ending the
3354         simulation, but this causes us to wait indefinitely for a data operation response to arrive in the UI process.
3355         Instead, we need to note whether or not the content view is allowing data interaction, and only perform an
3356         operation and wait for the -didPerform call if the operation was allowed. Otherwise, we immediately transition
3357         the phase to Cancelled and end the run.
3358
3359         (-[DataInteractionSimulator _resetSimulatedState]):
3360         (-[DataInteractionSimulator runFrom:to:]):
3361         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
3362         (-[DataInteractionSimulator _advanceProgress]):
3363         (-[DataInteractionSimulator externalItemProviders]):
3364         (-[DataInteractionSimulator setExternalItemProviders:]):
3365
3366         Previously, we hard-coded DataInteractionSimulator to only support a single external item provider. In order to
3367         test the scenario where multiple files are being "data interacted" into a file-type input, we generalize this to
3368         take multiple item providers.
3369
3370         (-[DataInteractionSimulator externalItemProvider]): Deleted.
3371         (-[DataInteractionSimulator setExternalItemProvider:]): Deleted.
3372
3373 2017-04-18  John Wilander  <wilander@apple.com>
3374
3375         Make WebCore::topPrivatelyControlledDomain() return "localhost" for localhost
3376         https://bugs.webkit.org/show_bug.cgi?id=170798
3377         <rdar://problem/31595108>
3378
3379         Reviewed by Alex Christensen.
3380
3381         * TestWebKitAPI/Tests/mac/PublicSuffix.mm:
3382         (TestWebKitAPI::TEST_F):
3383             Added two negative test cases for WebCore::isPublicSuffix().
3384             Added test cases with mixed case domains, localhost, and
3385             non-ASCII for WebCore::topPrivatelyControlledDomain().
3386
3387 2017-04-18  Jonathan Bedard  <jbedard@apple.com>
3388
3389         Unreviewed, rolling out r215346 and 215361.
3390
3391         The problem these changes were fixing was addressed in
3392         <https://trac.webkit.org/changeset/215416/webkit>.
3393
3394         Reverted changesets:
3395
3396         "webkitpy: Ignore previously launched pid when system is under
3397         stress"
3398         https://bugs.webkit.org/show_bug.cgi?id=170741
3399         http://trac.webkit.org/changeset/215346
3400         http://trac.webkit.org/changeset/215361
3401
3402 2017-04-17  Alex Christensen  <achristensen@webkit.org>
3403
3404         Allow Variants of RetainPtrs
3405         https://bugs.webkit.org/show_bug.cgi?id=170923
3406
3407         Reviewed by Tim Horton and Sam Weinig.
3408
3409         * TestWebKitAPI/Tests/WTF/Variant.cpp:
3410         (TestWebKitAPI::TEST):
3411         Add tests for RetainPtr and for another class with overloaded operator& to verify such classes can
3412         work in Variants.
3413
3414 2017-04-17  Brady Eidson  <beidson@apple.com>
3415
3416         Make WKHTTPCookieStore public.
3417         <rdar://problem/31024691> and https://bugs.webkit.org/show_bug.cgi?id=170920
3418
3419         Reviewed by Geoffrey Garen.
3420
3421         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3422         (TEST):
3423
3424 2017-04-17  Youenn Fablet  <youenn@apple.com>
3425
3426         Disable outdated WritableStream API
3427         https://bugs.webkit.org/show_bug.cgi?id=170749
3428         <rdar://problem/31446233>
3429
3430         Reviewed by Alex Christensen.
3431
3432         Replacing READABLE_STREAM_API, READABLE_BYTE_STREAM_API and WRITABLE_STREAM_API compilation flag by:
3433         - A STREAMS_API compilation flag.
3434         - A ReadableByteStreamAPI and WritableStreamAPI runtime flags, turned off except for RWT and DRT.
3435
3436         * DumpRenderTree/mac/DumpRenderTree.mm:
3437         (enableExperimentalFeatures):
3438         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3439         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3440         (WTR::InjectedBundle::beginTesting):
3441         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3442         (WTR::TestRunner::setFetchAPIEnabled):
3443         (WTR::TestRunner::setWritableStreamAPIEnabled):
3444         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
3445         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3446
3447 2017-04-17  Tim Horton  <timothy_horton@apple.com>
3448
3449         Provide a viewport parameter to disable clipping to the safe area
3450         https://bugs.webkit.org/show_bug.cgi?id=170766
3451         <rdar://problem/31564634>
3452
3453         Reviewed by Beth Dakin.
3454
3455         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3456         (WTR::UIScriptController::setObscuredInsets):
3457         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3458         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3459         (WTR::UIScriptController::setObscuredInsets):
3460         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3461         * WebKitTestRunner/ios/TestControllerIOS.mm:
3462         (WTR::TestController::platformResetStateToConsistentValues):
3463         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3464         (WTR::UIScriptController::setObscuredInsets):
3465         Add a UIScriptController mechanism to install obscured insets
3466         on the web view.
3467
3468 2017-04-17  Dan Bernstein  <mitz@apple.com>
3469
3470         [Cocoa] Move isNullFunctionPointer down into WTF
3471         https://bugs.webkit.org/show_bug.cgi?id=170892
3472
3473         Reviewed by Sam Weinig.
3474
3475         * TestWebKitAPI/Configurations/TestWTF.xcconfig:
3476         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3477         * TestWebKitAPI/Tests/WTF/darwin/WeakLinking.cpp: Added.
3478         (TestWebKitAPI::TEST):
3479         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-iOS-v2.tbd: Added.
3480         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-iOS.tbd: Added.
3481         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-macOS-v2.tbd: Added.
3482         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-macOS.tbd: Added.
3483
3484 2017-04-17  Jonathan Bedard  <jbedard@apple.com>
3485
3486         webkitpy: Correct poll when killing ServerProcess
3487
3488         Unreviewed infrastructure fix.
3489
3490         * Scripts/webkitpy/port/server_process.py:
3491         (ServerProcess._kill): A polled process equaling 'None' means the process is running.
3492
3493 2017-04-17  Eric Carlson  <eric.carlson@apple.com>
3494
3495         [MediaStream] Enable getUserMedia API test
3496         https://bugs.webkit.org/show_bug.cgi?id=170901
3497         <rdar://problem/31656594>
3498
3499         Reviewed by Youenn Fablet.
3500
3501         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add test.
3502
3503         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
3504         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
3505         (TestWebKitAPI::TEST): Enable capture with mock devices.
3506         * TestWebKitAPI/Tests/WebKit2/getUserMedia.html: Update to mediaDevices.getUserMedia
3507
3508 2017-04-17  Xan Lopez  <xan@igalia.com>
3509
3510         [GTK] Update the Fedora dependencies for WebKitGTK+
3511         https://bugs.webkit.org/show_bug.cgi?id=170590
3512
3513         Reviewed by Carlos Alberto Lopez Perez.
3514
3515         * gtk/install-dependencies: add a bunch of modules necessary to
3516         get a proper set of GStreamer codecs for WebRTC.
3517
3518 2017-04-16  Sam Weinig  <sam@webkit.org>
3519
3520         [WebIDL] Switch IDLAttributes.txt over to a more structured format so that more information can be added for each attribute
3521         https://bugs.webkit.org/show_bug.cgi?id=170843
3522
3523         Reviewed by Chris Dumez.
3524
3525         * DumpRenderTree/DerivedSources.make:
3526         * WebKitTestRunner/DerivedSources.make:
3527         * Scripts/webkitpy/bindings/main.py:
3528         (BindingsTests.generate_from_idl):
3529         Pass IDLAttributes.json, as it is now mandatory to have one.
3530
3531 2017-04-14  Mark Lam  <mark.lam@apple.com>
3532
3533         Update architectures in xcconfig files.
3534         https://bugs.webkit.org/show_bug.cgi?id=170867
3535         <rdar://problem/31628104>
3536
3537         Reviewed by Joseph Pecoraro.
3538
3539         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3540         * MobileMiniBrowser/Configurations/Base.xcconfig:
3541         * TestWebKitAPI/Configurations/Base.xcconfig:
3542         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3543         * WebKitTestRunner/Configurations/Base.xcconfig:
3544
3545 2017-04-14  Brady Eidson  <beidson@apple.com>
3546
3547         Fix basic WKURLSchemeHandler bugs.
3548         <rdar://problem/30647559> and https://bugs.webkit.org/show_bug.cgi?id=170862
3549
3550         Reviewed by Andy Estes.
3551
3552         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3553         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm: Added.
3554         (-[SchemeHandler initWithData:mimeType:]):
3555         (-[SchemeHandler dealloc]):
3556         (-[SchemeHandler webView:startTask:]):
3557         (-[SchemeHandler webView:stopTask:]):
3558         (TEST):
3559
3560 2017-04-14  Bill Ming  <mbbill@gmail.com>
3561
3562         webkit-patch failed to detect git repository
3563         https://bugs.webkit.org/show_bug.cgi?id=170859
3564
3565         Reviewed by Daniel Bates.
3566
3567         Windows cmd does not accept single quoted path. So, using
3568         double quotes here will provide better platform compatibility.
3569
3570         * Scripts/VCSUtils.pm:
3571         (isGitDirectory):
3572         (isGitSVNDirectory):
3573         (svnRevisionForDirectory):
3574         (svnInfoForPath):
3575
3576 2017-04-14  Ryan Haddad  <ryanhaddad@apple.com>
3577
3578         Unreviewed, rolling out r215374.
3579
3580         This change causes LayoutTests to exit early with crashes on
3581         Sierra.
3582
3583         Reverted changeset:
3584
3585         "webkitpy: Ignore previously launched pid when system is under
3586         stress"
3587         https://bugs.webkit.org/show_bug.cgi?id=170741
3588         http://trac.webkit.org/changeset/215374
3589
3590 2017-04-14  Dan Bernstein  <mitz@apple.com>
3591
3592         [ios-simulator] API test WebKit2.AdditionalReadAccessAllowedURLs is failing
3593         https://bugs.webkit.org/show_bug.cgi?id=170856
3594
3595         Disabled the newly-added test in the Simulator, which doesn’t enforce sandboxing.
3596
3597         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm:
3598
3599 2017-04-14  Jonathan Bedard  <jbedard@apple.com>
3600
3601         webkitpy: Ignore previously launched pid when system is under stress
3602         https://bugs.webkit.org/show_bug.cgi?id=170741
3603
3604         Unreviewed infrastructure fix.
3605
3606         Drivers are destroyed between failing layout tests, which is not necessary and
3607         prevents the work-around implemented in https://bugs.webkit.org/show_bug.cgi?id=170741.
3608
3609         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3610         (Worker._kill_driver): Do not destroy drivers when they are stopped.
3611         * Scripts/webkitpy/port/driver.py:
3612         (Driver.stop): Reset driver values set in initializer.
3613
3614 2017-04-14  Andy Estes  <aestes@apple.com>
3615
3616         [ios-simulator] API test WebKit2.WKWebProcessPlugInRangeHandle timing out
3617         https://bugs.webkit.org/show_bug.cgi?id=167594
3618
3619         Re-enabled this API test now that webkit.org/b/161967 is fixed.
3620
3621         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
3622         (TEST):
3623
3624 2017-04-14  Andy Estes  <aestes@apple.com>
3625
3626         [ios-simulator] API test WebKit2.DataDetectionReferenceDate timing out
3627         https://bugs.webkit.org/show_bug.cgi?id=161967
3628
3629         Reviewed by Alexey Proskuryakov.
3630
3631         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
3632         (TEST): Re-enabled WebKit2.DataDetectionReferenceDate.
3633
3634 2017-04-14  Ryan Haddad  <ryanhaddad@apple.com>
3635
3636         Unreviewed, rolling out r215363.
3637
3638         This change causes LayoutTests to exit early with crashes.
3639
3640         Reverted changeset:
3641
3642         "webkitpy: Ignore previously launched pid when system is under
3643         stress"
3644         https://bugs.webkit.org/show_bug.cgi?id=170741
3645         http://trac.webkit.org/changeset/215363
3646
3647 2017-04-14  Jonathan Bedard  <jbedard@apple.com>
3648
3649         webkitpy: Ignore previously launched pid when system is under stress
3650         https://bugs.webkit.org/show_bug.cgi?id=170741
3651
3652         Unreviewed infrastructure fix.
3653
3654         Drivers are destroyed between failing layout tests, which is not necessary and
3655         prevents the work-around implemented in https://bugs.webkit.org/show_bug.cgi?id=170741.