webkitpy: Use partially disambiguated type in SimulatedDeviceManager._disambiguate_de...
[WebKit-https.git] / Tools / ChangeLog
1 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
2
3         webkitpy: Use partially disambiguated type in SimulatedDeviceManager._disambiguate_device_type
4         https://bugs.webkit.org/show_bug.cgi?id=181538
5         <rdar://problem/36440580>
6
7         Reviewed by Aakash Jain.
8
9         When disambiguating a device type, it is possible that the provided device type is sufficiently
10         ambiguous that the comparisons against complete device types without a disambiguated hardware_family
11         will result in a failure to disambiguate the type.
12
13         * Scripts/webkitpy/xcode/new_simulated_device.py:
14         (SimulatedDeviceManager._disambiguate_device_type):
15
16 2018-01-11  Brent Fulgham  <bfulgham@apple.com>
17
18         REGRESSION(r219530): ResourceLoadStatisticsPersistentStorage should be read-only in ephemeral sessions
19         https://bugs.webkit.org/show_bug.cgi?id=181136
20         <rdar://problem/36116604>
21
22         Reviewed by Chris Dumez.
23
24         Add a new API test to confirm that ResourceLoadStatistics can be turned on safely for ephemeral
25         browsing sessions.
26
27         * Scripts/run-gtk-tests:
28         (GtkTestRunner): Unskip test now that it passes.
29         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
30         (TEST): Add new WebsiteDataStoreEphemeral test.
31
32 2018-01-11  Ryan Haddad  <ryanhaddad@apple.com>
33
34         Unreviewed, rolling out r226816.
35
36         This change broke LayoutTests on the bots.
37
38         Reverted changeset:
39
40         "run-webkit-tests fails when there is a curly brace in Xcode
41         build output"
42         https://bugs.webkit.org/show_bug.cgi?id=181254
43         https://trac.webkit.org/changeset/226816
44
45 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
46
47         webkitpy: Fix flakey webserver tests
48         https://bugs.webkit.org/show_bug.cgi?id=181555
49         <rdar://problem/36448273>
50
51         Reviewed by Aakash Jain.
52
53         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
54         (LayoutTestRunnerTests.test_servers_started): Add and bind custom checks to
55         determine if a specific server is running.
56
57 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
58
59         Commit queue failed to land a bug, 'NoneType' object has no attribute 'strip'
60         https://bugs.webkit.org/show_bug.cgi?id=181561
61         <rdar://problem/36452652>
62
63         Reviewed by Aakash Jain.
64
65         BeautifulSoup.find may return None, this case should be gracefully handled.
66
67         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
68         (BugzillaQueries._parse_result_count):
69         (BugzillaQueries._fetch_bugs_from_advanced_query): Added logging.
70
71 2018-01-11  Alexey Proskuryakov  <ap@apple.com>
72
73         run-webkit-tests fails when there is a curly brace in Xcode build output
74         https://bugs.webkit.org/show_bug.cgi?id=181254
75
76         Reviewed by Daniel Bates.
77
78         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
79         (MeteredStream.write):
80
81 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
82
83         webkitpy: Reimplement simulator code (Part 3)
84         https://bugs.webkit.org/show_bug.cgi?id=180555
85         <rdar://problem/36131381>
86
87         Reviewed by Aakash Jain.
88
89         Remove old simulator code.
90
91         * Scripts/webkitpy/xcode/__init__.py: Remove import statement.
92         * Scripts/webkitpy/xcode/simulated_device.py: Removed.
93         * Scripts/webkitpy/xcode/simulator.py: Removed.
94         * Scripts/webkitpy/xcode/simulator_unittest.py: Removed.
95
96 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
97
98         [Attachment Support] Support moving attachment elements in editable areas using drag and drop
99         https://bugs.webkit.org/show_bug.cgi?id=181337
100         <rdar://problem/36324813>
101
102         Reviewed by Tim Horton.
103
104         Add 3 new API tests for attachment element dragging.
105
106         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
107         (-[TestWKWebView expectElementTag:toComeBefore:]):
108         (-[NSItemProvider expectType:withData:]):
109         (TestWebKitAPI::TEST):
110
111 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
112
113         REGRESSION(r225856): Incorrectly managing 'future' baseline_search_paths. 
114         https://bugs.webkit.org/show_bug.cgi?id=179621
115         <rdar://problem/35589585>
116
117         Unreviewed infrastructure fix.
118
119         * Scripts/webkitpy/port/mac.py:
120         (MacPort.default_baseline_search_path): Include 'future' in the version_fallback
121         list if we are the VERSION_MAX, which usually corresponds with future.
122
123 2018-01-11  Filip Pizlo  <fpizlo@apple.com>
124
125         CodeBlocks should be in IsoSubspaces
126         https://bugs.webkit.org/show_bug.cgi?id=180884
127
128         Reviewed by Saam Barati.
129         
130         Remove some less important benchmarks from the default run. Doing run-jsc-benchmarks
131         shouldn't take a long time due to benchmarks we don't optimize for.
132         
133         * Scripts/run-jsc-benchmarks:
134
135 2018-01-11  Ms2ger  <Ms2ger@igalia.com>
136
137         Test gardening for GTK.
138         https://bugs.webkit.org/show_bug.cgi?id=181477
139
140         Unreviewed test gardening.
141
142         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Correct the file name.
143         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Adjust the expected console message.
144
145 2018-01-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
146
147         Add the new JSCOnly bot to the scheduler.
148         https://bugs.webkit.org/show_bug.cgi?id=181487
149
150         Unreviewed follow-up patch after r226729
151
152         On r226729 I missed to add the new JSCOnly bot the default scheduler.
153         This is needed to make the bot automatically pick each commit for testing.
154
155         * BuildSlaveSupport/build.webkit.org-config/config.json:
156
157 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
158
159         [Attachment Support] Support dragging attachment elements out as files on iOS
160         https://bugs.webkit.org/show_bug.cgi?id=181199
161         <rdar://problem/36299316>
162
163         Reviewed by Tim Horton, Andy Estes and Joseph Pecoraro.
164
165         Add support in the drag and drop simulator for testing blob-backed attachment element dragging, and also add new
166         attachment API tests.
167
168         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
169         (-[NSItemProvider expectType:withData:]):
170         (TestWebKitAPI::TEST):
171
172         Add two new WKAttachmentTests to exercise dragging data- and file-backed blobs via attachment elements. These
173         tests first insert attachments via drop or WKWebView SPI, and then drag these attachments out and use the
174         -expectType:withData: helper to inspect the item providers created from the drag source.
175
176         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
177         (TestWebKitAPI::TEST):
178         * TestWebKitAPI/ios/DataInteractionSimulator.h:
179         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
180         (-[MockDragSession localContext]):
181         (-[MockDragSession setLocalContext:]):
182         (-[DataInteractionSimulator _resetSimulatedState]):
183         (-[DataInteractionSimulator simulateAllTouchesCanceled:]):
184         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
185         (-[DataInteractionSimulator _advanceProgress]):
186         (-[DataInteractionSimulator endDataTransfer]):
187
188         Make some tweaks to the iOS drag and drop simulator. In particular, this patch (1) adds a new hook to tell
189         WebKit that data transfers have been completed, (2) fixes incorrect drop proposal handling when returning
190         UIDropOperationForbidden by replacing _shouldPerformOperation with a UIDropProposal, and (3) teach the
191         MockDragSession to hold on to a localContext.
192
193 2018-01-11  Ali Juma  <ajuma@chromium.org>
194
195         Unreviewed. Add Ali Juma as contributor
196
197         * Scripts/webkitpy/common/config/contributors.json:
198
199 2018-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
200
201         Unreviewed. Update Selenium WebDriver imported tests.
202
203         New version of selenium uses command line options to pass driver and browser binaries to pytest instead of
204         environment variables.
205
206         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
207         (collect): Reorder the arguments to make pytest happy.
208         (run): Ditto.
209         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
210         (WebDriverSeleniumExecutor.__init__): Add driver binary, browser binary and browser args as arguments.
211
212 2018-01-11  Ling Ho  <lingcherd_ho@apple.com>
213
214         Move Commit Queue and EWS Queues to Sierra on Bot Watcher's Dasboard
215         https://bugs.webkit.org/show_bug.cgi?id=181492
216         <rdar://problem/36359679>
217
218         Reviewed by Alexey Proskuryakov. 
219
220 2018-01-10  Adrian Perez de Castro  <aperez@igalia.com>
221
222         [GTK] Tools/gtk/install-dependencies: Packages geoclue, ruby-highline, xorg-utils do not exist in Arch Linux
223         https://bugs.webkit.org/show_bug.cgi?id=181475
224
225         Reviewed by Michael Catanzaro.
226
227         * gtk/install-dependencies: Update package list for Arch Linux, extend
228         message shown at end of installation with additional tips.
229
230 2018-01-10  Wenson Hsieh  <wenson_hsieh@apple.com>
231
232         REGRESSION(r222507): Composition highlight doesn't render when using IME
233         https://bugs.webkit.org/show_bug.cgi?id=181485
234         <rdar://problem/35896516>
235
236         Reviewed by Ryosuke Niwa.
237
238         Add a `suppressUnderline` argument to TextInputController.setMarkedText. This suppresses the custom underlines
239         rendered when testing IME on iOS in WebKit2. In this new test, suppressing underline rendering is needed to
240         allow rendering composition backgrounds (see InlineTextBox::paint).
241
242         * DumpRenderTree/ios/TextInputControllerIOS.m:
243         (+[TextInputController isSelectorExcludedFromWebScript:]):
244         (+[TextInputController webScriptNameForSelector:]):
245         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
246         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
247         * DumpRenderTree/mac/TextInputControllerMac.m:
248         (+[TextInputController isSelectorExcludedFromWebScript:]):
249         (+[TextInputController webScriptNameForSelector:]):
250         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
251         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
252         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
253         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
254         (WTR::TextInputController::setMarkedText):
255         * WebKitTestRunner/InjectedBundle/TextInputController.h:
256
257 2018-01-10  JF Bastien  <jfbastien@apple.com>
258
259         Poison small JSObject derivatives which only contain pointers
260         https://bugs.webkit.org/show_bug.cgi?id=181483
261         <rdar://problem/36407127>
262
263         Reviewed by Mark Lam.
264
265         Test the new move-assign and move-copy from unique_ptr, as well as
266         nullptr_t ctors.
267
268         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
269         (TestWebKitAPI::TEST):
270         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
271         (TestWebKitAPI::TEST):
272         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
273         (TestWebKitAPI::TEST):
274
275 2018-01-10  Chris Dumez  <cdumez@apple.com>
276
277         Multiple http/wpt/beacon/contentextensions/ test are flaky.
278         https://bugs.webkit.org/show_bug.cgi?id=179256
279         <rdar://problem/35401978>
280
281         Reviewed by Alex Christensen.
282
283         Update WebKitTestRunner to set a temporary path for content extensions so that its WKTR
284         instance gets its own folder to avoid conflicts and flakiness.
285
286         * WebKitTestRunner/mac/TestControllerMac.mm:
287         (WTR::TestController::platformConfigureViewForTest):
288
289 2018-01-10  Tim Horton  <timothy_horton@apple.com>
290
291         REGRESSION (r213590): Swipe from edge to go to previous page is significantly slower than tapping back button on Twitter
292         https://bugs.webkit.org/show_bug.cgi?id=181269
293         <rdar://problem/35110344>
294
295         Reviewed by Simon Fraser.
296
297         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
298         (WTR::UIScriptController::beginBackSwipe):
299         (WTR::UIScriptController::completeBackSwipe):
300         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
301         (WTR::UIScriptController::beginBackSwipe):
302         (WTR::UIScriptController::completeBackSwipe):
303         (WTR::UIScriptController::overridePreference):
304         (WTR::UIScriptController::replaceTextAtRange):
305         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
306         (WTR::PlatformWebView::setNavigationGesturesEnabled):
307         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
308         (WTR::UIScriptController::beginBackSwipe):
309         (WTR::UIScriptController::completeBackSwipe):
310         Implement beginBackSwipe and completeBackSwipe on iOS (they already
311         exist on Mac) in terms of the new WKWebView testing SPI.
312
313 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
314
315         REGRESSION (r226715): ignore WARNING output in linter tests
316         https://bugs.webkit.org/show_bug.cgi?id=181486
317         <rdar://problem/36408847>
318
319         Reviewed by Aakash Jain.
320
321         Linter unit tests should not be interested in logs at the the INFO or WARNING levels.
322
323         * Scripts/webkitpy/common/system/outputcapture.py:
324         (OutputCapture.__init__): Pass logging level to be captured.
325         * Scripts/webkitpy/style/main_unittest.py:
326         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors): Capture logging at the ERROR level.
327         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Ditto.
328         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit): Ditto.
329         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Ditto.
330         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Ditto.
331         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Ditto.
332         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file): Ditto.
333         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit): Ditto.
334
335 2018-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
336
337         Add a JSCOnly MIPS buildbot
338         https://bugs.webkit.org/show_bug.cgi?id=181487
339
340         Reviewed by Michael Catanzaro.
341
342         Add the new bot configs definitions for the master and update the unit tests.
343
344         * BuildSlaveSupport/build.webkit.org-config/config.json:
345         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
346
347 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
348
349         REGRESSION (r226715): don't re-check number of simulators in child processes
350         https://bugs.webkit.org/show_bug.cgi?id=181484
351         <rdar://problem/36407151>
352
353         Reviewed by Aakash Jain.
354
355         * Scripts/webkitpy/port/ios_simulator.py:
356         (IOSSimulatorPort.__init__): Skip the number of simulators check if simulators
357         are already initialized.
358
359 2018-01-10  Commit Queue  <commit-queue@webkit.org>
360
361         Unreviewed, rolling out r226667 and r226673.
362         https://bugs.webkit.org/show_bug.cgi?id=181488
363
364         This caused a flaky crash. (Requested by mlewis13 on #webkit).
365
366         Reverted changesets:
367
368         "CodeBlocks should be in IsoSubspaces"
369         https://bugs.webkit.org/show_bug.cgi?id=180884
370         https://trac.webkit.org/changeset/226667
371
372         "REGRESSION (r226667): CodeBlocks should be in IsoSubspaces"
373         https://bugs.webkit.org/show_bug.cgi?id=180884
374         https://trac.webkit.org/changeset/226673
375
376 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
377
378         Follow-up fix to r226715
379         https://bugs.webkit.org/show_bug.cgi?id=180555
380         <rdar://problem/36131381>
381
382         Unreviewed infrastructure fix.
383
384         * Scripts/webkitpy/xcode/new_simulated_device.py:
385         (SimulatedDeviceManager._create_or_find_device_for_request): Use _delete instead
386         of delete.
387
388 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
389
390         webkitpy: Refactor simulator code (Part 2)
391         https://bugs.webkit.org/show_bug.cgi?id=180555
392         <rdar://problem/36131381>
393
394         Reviewed by Aakash Jain.
395
396         The patch leverages the SimulatedDeviceManager when running layout tests.
397         This patch is primarily code removal, since much of the IOSSimulatorPort
398         was dedicated to managing simulators. The removed code is either now owned by the
399         SimulatedDeviceManager (and committed in Part 1) or supported a technique to
400         boot multiple simulators which was made obsolete in Xcode 9.
401
402         * Scripts/webkitpy/layout_tests/controllers/manager.py:
403         (Manager._custom_device_for_test.in): Device names now have spaces in them,
404         strip those spaces.
405         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
406         (parse_args): Remove '--runtime' flag, this is achieved with the --version flag.
407         * Scripts/webkitpy/port/ios.py:
408         (IOSPort.__init__): The _current_device idiom is no longer required since the
409         SimulatedDeviceManager keeps track of any previously booted devices.
410         (IOSPort.target_host): Even when only a single device is used, it will be accessed
411         through the array of managed devices.
412         (IOSPort.using_multiple_devices): Deleted.
413         * Scripts/webkitpy/port/ios_device.py:
414         (IOSDevicePort.using_multiple_devices): Deleted.
415         * Scripts/webkitpy/port/ios_simulator.py:
416         (IOSSimulatorPort): Remove constants required to manage simulators, change device
417         class strings so they can be parsed by the DeviceType class.
418         (IOSSimulatorPort.__init__): Determine the number of processes to use by checking
419         the number of simulators currently booted, the number of child processes specified
420         and the maximum number of simulators supported by this system.
421         (IOSSimulatorPort._device_for_worker_number_map):Return the array of initialized
422         devices owned by the SimulatedDeviceManager.
423         (IOSSimulatorPort.ios_version): Remove support for the --runtime option.
424         (IOSSimulatorPort.default_child_processes): Use the SimulatedDeviceManager to check
425         the maximum number of supported simulators on this system.
426         (IOSSimulatorPort._create_devices): Construct a list of device requests with a
427         request for each child process and send this list to the SimulatedDeviceManager to
428         initialize the devices.
429         (IOSSimulatorPort.clean_up_test_run):
430         (IOSSimulatorPort.check_sys_deps): Check that there are simulators running the
431         specified version of iOS.
432         (IOSSimulatorPort.reset_preferences):
433         (IOSSimulatorPort.simulator_runtime): Deleted.
434         (IOSSimulatorPort.simulator_device_type): Deleted.
435         (IOSSimulatorPort._teardown_managed_simulators): Deleted.
436         (IOSSimulatorPort.use_multiple_simulator_apps): Deleted.
437         (IOSSimulatorPort._create_simulators): Deleted.
438         (IOSSimulatorPort._quit_ios_simulator): Deleted.
439         (IOSSimulatorPort._using_dedicated_simulators): Deleted.
440         (IOSSimulatorPort.using_multiple_devices): Deleted.
441         (IOSSimulatorPort._create_device): Deleted.
442         (IOSSimulatorPort.get_simulator_path): Deleted.
443         (IOSSimulatorPort._createSimulatorApps): Deleted.
444         (IOSSimulatorPort._createSimulatorApp): Deleted.
445         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
446         (TestRebaseline.test_rebaseline): Filter out commands run when determining the
447         maximum number of simulators run on this system.
448         (TestRebaselineExpectations.test_rebaseline_expectations): Ditto.
449         * Scripts/webkitpy/xcode/new_simulated_device.py:
450         (SimulatedDeviceManager._does_fulfill_request): Fixed log statement.
451
452 2018-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
453
454         WebDriver: run-webdriver-tests doesn't handle test names with a '/' correctly
455         https://bugs.webkit.org/show_bug.cgi?id=181474
456
457         Reviewed by Carlos Alberto Lopez Perez.
458
459         We use os.path.basename() to get the subtest name. If the test name contains a slash we get part of the subtest
460         name as the name.
461
462         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
463         (WebDriverTestRunnerW3C._subtest_name): Helper function to get the subtest name.
464         (WebDriverTestRunnerW3C.run): Use _subtest_name() instead of os.path.basename().
465
466 2018-01-09  Andy Estes  <aestes@apple.com>
467
468         [Xcode] Use the Apple Internal SDK if available when building ImageDiff
469         https://bugs.webkit.org/show_bug.cgi?id=181459
470
471         Reviewed by Dan Bernstein.
472
473         * ImageDiff/cg/Configurations/Base.xcconfig:
474
475 2018-01-09  Myles C. Maxfield  <mmaxfield@apple.com>
476
477         font-display:fallback can cause a visual flash (which is supposed to be impossible)
478         https://bugs.webkit.org/show_bug.cgi?id=181374
479
480         Reviewed by Simon Fraser.
481
482         The test requires Palatino.
483
484         * DumpRenderTree/mac/DumpRenderTree.mm:
485         (allowedFontFamilySet):
486         * WebKitTestRunner/mac/TestControllerMac.mm:
487         (WTR::allowedFontFamilySet):
488
489 2018-01-09  Saam Barati  <sbarati@apple.com>
490
491         Give some slack in display-profiler-outputs computation of the terminal window's number of columns
492         https://bugs.webkit.org/show_bug.cgi?id=181449
493
494         Reviewed by JF Bastien.
495
496         This allows me to Cmd+f in my terminal to search for things without
497         having the results become misaligned.
498
499         * Scripts/display-profiler-output:
500
501 2018-01-09  Basuke Suzuki  <Basuke.Suzuki@sony.com>
502
503         [webkitpy] PlatformInfo should have default argument for casual use
504         https://bugs.webkit.org/show_bug.cgi?id=180827
505
506         Reviewed by David Kilzer.
507
508         PlatformInfo should be the only way to check platform specific thing instead
509         of sys.platform or other various checks. If there is something you want to check,
510         it should be placed in PlatformInfo.
511
512         Currently to instantiate PlatformInfo, it requires arguments, which is usually
513         sys, platform and Executive(). They are straight forward and should be handled
514         by default arguments. Then we can instantiate PlatformInfo more casual.
515
516         * Scripts/webkitpy/common/system/platforminfo.py:
517         (PlatformInfo): Use relative module path import
518         (PlatformInfo.__init__):
519         (PlatformInfo.executive): Lazy instantiation of Executive()
520         (PlatformInfo.total_bytes_memory): Accessing via above property
521         (PlatformInfo.xcode_sdk_version): Ditto
522         (PlatformInfo.xcode_simctl_list): Ditto
523         (PlatformInfo.xcode_version): Ditto
524         (PlatformInfo._win_version_str): Ditto
525         * Scripts/webkitpy/common/system/systemhost.py:
526         (SystemHost.__init__):
527         * Scripts/webkitpy/common/system/user.py:
528         (User.__init__):
529
530 2018-01-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
531
532         [Win] Remove workaround for Bug 176442 after stopping MSVC 2015 support
533         https://bugs.webkit.org/show_bug.cgi?id=176443
534
535         Reviewed by Darin Adler.
536
537         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
538         (TEST):
539
540 2018-01-09  Frederic Wang  <fwang@igalia.com.fr>
541
542         check-webkit-style: Verify syntax for WK_API_AVAILABLE
543         https://bugs.webkit.org/show_bug.cgi?id=181394
544
545         Reviewed by Darin Adler.
546
547         A common syntax error for WK_API_AVAILABLE is to write ios(WK_MAC_TBA)
548         as the second parameter instead of ios(WK_IOS_TBA). This generally
549         builds for iOS on EWS but not when using the public SDK. See r224057,
550         r223207 and r226211 for example. This patch adds a basic style check
551         for that macro to prevent this kind of mistake.
552
553         * Scripts/webkitpy/style/checkers/cpp.py:
554         (check_min_versions_of_wk_api_available): New function to verify the parameters of WX_API_AVAILABLE.
555         (check_style): Run new style check.
556         (CppChecker): Add build type for the new style check.
557         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
558         (WebKitStyleTest.test_min_versions_of_wk_api_available): Add tests for the new style check.
559
560 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
561
562         [Attachment Support] Expose HTMLAttachmentElement.uniqueIdentifier to bindings
563         https://bugs.webkit.org/show_bug.cgi?id=181420
564         <rdar://problem/36365827>
565
566         Reviewed by Alex Christensen.
567
568         Adjusts some existing API tests to verify that attachment elements' uniqueIdentifiers match the uniqueIdentifier
569         of corresponding _WKAttachments.
570
571         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
572         (TestWebKitAPI::TEST):
573
574 2018-01-08  Alex Christensen  <achristensen@webkit.org>
575
576         Add WKNavigationDelegate SPI exposing WebProcess crash reason
577         https://bugs.webkit.org/show_bug.cgi?id=181410
578         <rdar://problem/36167199>
579
580         Reviewed by Wenson Hsieh.
581
582         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
583         (-[CrashReasonDelegate _webView:webContentProcessDidTerminateWithReason:]):
584         (TEST):
585
586 2018-01-08  Alex Christensen  <achristensen@webkit.org>
587
588         Add SPI for WKOpenPanelParameters._acceptedMIMETypes and _acceptedFileExtensions
589         https://bugs.webkit.org/show_bug.cgi?id=181408
590         <rdar://problem/35884960>
591
592         Reviewed by Tim Horton.
593
594         * TestWebKitAPI/Tests/WebKitCocoa/RunOpenPanel.mm:
595         (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
596
597 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
598
599         [Attachment Support] Expose file name and content type of WKAttachment
600         https://bugs.webkit.org/show_bug.cgi?id=181390
601         <rdar://problem/36336837>
602
603         Reviewed by Tim Horton.
604
605         Adjusts some existing tests in WKAttachmentTests to exercise -requestInfo:.
606
607         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
608         (-[_WKAttachment synchronouslyRequestInfo:]):
609         (-[_WKAttachment synchronouslyRequestData:]):
610
611         Reimplement this in terms of -synchronouslyRequestInfo:.
612
613         (-[_WKAttachment expectRequestedDataToBe:]):
614         (TestWebKitAPI::TEST):
615
616 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
617
618         Copying, pasting, and then deleting an attachment element breaks attachment data requests
619         https://bugs.webkit.org/show_bug.cgi?id=181365
620         <rdar://problem/36340647>
621
622         Reviewed by Tim Horton.
623
624         Adds two new attachment API tests to verify that copying and pasting an existing attachment inserts an
625         attachment element that may be edited independently of the original attachment. See WebCore/ChangeLog for more
626         detail.
627
628         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
629         (TestWebKitAPI::TEST):
630
631 2018-01-08  Youenn Fablet  <youenn@apple.com>
632
633         navigator.onLine does not work inside service workers
634         https://bugs.webkit.org/show_bug.cgi?id=181079
635         <rdar://problem/36178606>
636
637         Reviewed by Darin Adler.
638
639         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
640         (WTR::InjectedBundle::initialize): Setting service worker creation callback to inject ServiceWorkerInternals object.
641
642 2018-01-07  Saam Barati  <sbarati@apple.com>
643
644         Add total exits and total compilations sorting mode to the "full" command in display-profiler-output
645         https://bugs.webkit.org/show_bug.cgi?id=181372
646
647         Reviewed by Filip Pizlo.
648
649         Adding these sorting modes makes it easier to analyze functions
650         that recompile a lot and exit a lot.
651
652         * Scripts/display-profiler-output:
653
654 2018-01-06  Julien Brianceau  <julien.brianceau@gmail.com>
655
656         Unreviewed, remove my Cisco email from contributors.json
657
658         * Scripts/webkitpy/common/config/contributors.json:
659
660 2018-01-05  JF Bastien  <jfbastien@apple.com>
661
662         WebAssembly: poison JS object's secrets
663         https://bugs.webkit.org/show_bug.cgi?id=181339
664         <rdar://problem/36325001>
665
666         Reviewed by Mark Lam.
667
668         Update tests for swap(Poisoned<k, T>, T*)
669
670         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp:
671         (TestWebKitAPI::TEST):
672         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
673         (TestWebKitAPI::TEST):
674         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
675         (TestWebKitAPI::TEST):
676
677 2018-01-05  Wenson Hsieh  <wenson_hsieh@apple.com>
678
679         REGRESSION(r226396) DataInteractionTests: ContentEditableToContentEditable and ContentEditableToTextarea are failing
680         https://bugs.webkit.org/show_bug.cgi?id=181359
681
682         Reviewed by Tim Horton.
683
684         Ensure that these tests still pass using older SDKs.
685
686         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
687         (TestWebKitAPI::TEST):
688
689 2018-01-05  Alex Christensen  <achristensen@webkit.org>
690
691         Rebase API test after r226469
692         https://bugs.webkit.org/show_bug.cgi?id=181308
693
694         * TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm:
695         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
696         A URL with < or > in it is now recognized as invalid by WebKit.  This is intentional, and matches our behavior before enabling the new URLParser.
697
698 2018-01-05  Alex Christensen  <achristensen@webkit.org>
699
700         Restrict navigation-time WKWebsiteDataStore swapping to main frame navigations
701         https://bugs.webkit.org/show_bug.cgi?id=181217
702
703         Reviewed by Tim Horton.
704
705         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
706         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
707         (TEST):
708
709 2018-01-05  Alex Christensen  <achristensen@webkit.org>
710
711         Add WKBundleFrameCreateFrameHandle
712         https://bugs.webkit.org/show_bug.cgi?id=181232
713         <rdar://problem/35926696>
714
715         Reviewed by Tim Horton.
716
717         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
718         * TestWebKitAPI/Tests/WebKitCocoa/FrameHandleSerialization.mm: Added.
719         (mouseDidMoveOverElement):
720         (-[FrameHandleSerialization webProcessPlugIn:didCreateBrowserContextController:]):
721         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
722         (-[MouseMoveOverElementDelegate _webView:mouseDidMoveOverElement:withFlags:userInfo:]):
723         (TEST):
724
725 2018-01-05  Chris Fleizach  <cfleizach@apple.com>
726
727         iOS: Build fix after r226432.
728         
729         Unreviewed. Stop duplicating speakAs symbols for iOS.
730
731         * DumpRenderTree/AccessibilityUIElement.cpp:
732         (AccessibilityUIElement::speakAs):
733
734 2018-01-05  Javier Fernandez  <jfernandez@igalia.com>
735
736         Unreviewed, added myself as WebKit reviewer
737
738         * Scripts/webkitpy/common/config/contributors.json:
739
740 2018-01-05  Claudio Saavedra  <csaavedra@igalia.com>
741
742         WPE: Build fix after r226432.
743
744         Unreviewed. Rename ::speak() to ::speakAs().
745         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
746         (WTR::AccessibilityUIElement::speakAs):
747         (WTR::AccessibilityUIElement::speak): Deleted.
748
749 2018-01-04  Chris Fleizach  <cfleizach@apple.com>
750
751         AX: Implement updated CSS3 Speech for 'speak' and 'speak-as' properties
752         https://bugs.webkit.org/show_bug.cgi?id=180361
753
754         Reviewed by Zalan Bujtas.
755
756         * DumpRenderTree/AccessibilityUIElement.cpp:
757         (speakAsCallback):
758         (AccessibilityUIElement::speakAs):
759         (AccessibilityUIElement::getJSClass):
760         (speakCallback): Deleted.
761         (AccessibilityUIElement::speak): Deleted.
762         * DumpRenderTree/AccessibilityUIElement.h:
763         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
764         (AccessibilityUIElement::speakAs):
765         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
766         (AccessibilityUIElement::speakAs):
767         (AccessibilityUIElement::speak): Deleted.
768         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
769         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
770         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
771         (WTR::AccessibilityUIElement::speakAs):
772         (WTR::AccessibilityUIElement::speak): Deleted.
773         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
774         (WTR::AccessibilityUIElement::speakAs):
775         (WTR::AccessibilityUIElement::speak): Deleted.
776
777 2018-01-04  Jonathan Bedard  <jbedard@apple.com>
778
779         REGRESSION (r226395): test-webkitperl test expectations incorrect
780         https://bugs.webkit.org/show_bug.cgi?id=181307
781         <rdar://problem/36306558>
782
783         Rubber-stamped by Aakash Jain.
784
785         r226395 added two lines towards the beginning of
786         Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl, the line
787         numbers in the test expectations need to update.
788
789         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
790
791 2018-01-04  Tim Horton  <timothy_horton@apple.com>
792
793         WKWebView loses minimum layout size overrides that happen while the process is terminated
794         https://bugs.webkit.org/show_bug.cgi?id=181306
795         <rdar://problem/34398288>
796
797         Reviewed by Dan Bernstein.
798
799         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
800         (TEST):
801         Add a test that calling _overrideLayoutParametersWithMinimumLayoutSize
802         while the process is terminated results in the page getting the correct
803         minimum layout size.
804
805 2018-01-04  Eric Carlson  <eric.carlson@apple.com>
806
807         [MediaStream] Add Mock screen capture source
808         https://bugs.webkit.org/show_bug.cgi?id=181291
809         <rdar://problem/36298164>
810
811         Reviewed by Dean Jackson.
812
813         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test.
814         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
815         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
816
817 2018-01-04  Lucas Forschler  <lforschler@apple.com>
818
819         <rdar://problem/36300930> Change proxy server setting on master config to reach s3 servers
820
821         Reviewed by Ling Ho.
822
823         * BuildSlaveSupport/build.webkit.org-config/steps.py:
824
825 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
826
827         [Attachment Support] Create attachment elements when dropping files on iOS
828         https://bugs.webkit.org/show_bug.cgi?id=181192
829         <rdar://problem/36280945>
830
831         Reviewed by Tim Horton.
832
833         Adds 3 new API tests to exercise different use cases of dropping content as attachment elements when the runtime
834         switch is enabled. See below for more details.
835
836         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
837         (-[NSItemProvider registerData:type:]):
838         (platformCopyPNG):
839         (TestWebKitAPI::TEST):
840         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
841
842         Fix some currently failing iOS drag and drop tests. In this case, there's no reason RTFD should appear in the
843         source item provider when dragging rich text *without* attachments, so this should have been a check for just
844         kUTTypeRTF instead.
845
846         (TestWebKitAPI::TEST):
847
848         Tests a few cases of inserting attachment elements via drop:
849         1.  We should distinguish between drops containing rich/plain text files from just dropping rich/plain text.
850             Instead of inserting the contents as inline web content, this should generate attachment elements.
851         2.  Test the fallback mechanism for inserting attachment elements. If the preferred presentation style is not
852             explicitly set, but there's nothing WebKit would otherwise do with the dropped content, then we should fall
853             back to inserting the content as an attachment.
854         3.  Test that if multiple attachments and inline item providers are present, WebKit will respect the order in
855             which they were inserted by the source (as opposed to, for instance, putting all of the attachments in front
856             or at the end).
857
858         * TestWebKitAPI/cocoa/TestWKWebView.h:
859         * TestWebKitAPI/cocoa/TestWKWebView.mm:
860         (-[TestWKWebView objectByEvaluatingJavaScript:]):
861
862         Add a helper method to return an object that represents the result of evaluating some given script, and rewrite
863         -stringByEvaluatingJavaScript to just turn around and call this.
864
865         (-[TestWKWebView stringByEvaluatingJavaScript:]):
866
867 2018-01-03  Ting-Wei Lan  <lantw44@gmail.com>
868
869         Replace hard-coded paths in shebangs with #!/usr/bin/env
870         https://bugs.webkit.org/show_bug.cgi?id=181040
871
872         Reviewed by Alex Christensen.
873
874         * BuildSlaveSupport/build-launcher-app:
875         * BuildSlaveSupport/build-launcher-dmg:
876         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
877         * BuildSlaveSupport/built-product-archive:
878         * BuildSlaveSupport/clean-build:
879         * BuildSlaveSupport/delete-stale-build-files:
880         * BuildSlaveSupport/download-built-product:
881         * BuildSlaveSupport/gtk/buildbot/log/run:
882         * BuildSlaveSupport/gtk/buildbot/run:
883         * BuildSlaveSupport/gtk/pulseaudio/run:
884         * BuildSlaveSupport/kill-old-processes:
885         * BuildSlaveSupport/test-result-archive:
886         * BuildSlaveSupport/win/kill-old-processes:
887         * Scripts/SpacingHeuristics.pm:
888         * Scripts/add-include:
889         * Scripts/build-api-tests:
890         * Scripts/build-dumprendertree:
891         * Scripts/build-imagediff:
892         * Scripts/build-jsc:
893         * Scripts/build-webkit:
894         * Scripts/build-webkittestrunner:
895         * Scripts/check-Xcode-source-file-types:
896         * Scripts/check-dom-results:
897         * Scripts/check-for-exit-time-destructors:
898         * Scripts/check-for-global-initializers:
899         * Scripts/check-for-inappropriate-objc-class-names:
900         * Scripts/check-for-weak-vtables-and-externals:
901         * Scripts/clean-header-guards:
902         * Scripts/compare-timing-files:
903         * Scripts/configure-xcode-for-ios-development:
904         * Scripts/copy-webkitlibraries-to-product-directory:
905         * Scripts/create-exports:
906         * Scripts/debug-minibrowser:
907         * Scripts/debug-safari:
908         * Scripts/debug-test-runner:
909         * Scripts/do-file-rename:
910         * Scripts/do-webcore-rename:
911         * Scripts/dump-webkit-tests-run:
912         * Scripts/ensure-valid-python:
913         * Scripts/execAppWithEnv:
914         * Scripts/extract-localizable-js-strings:
915         * Scripts/filter-build-webkit:
916         * Scripts/find-extra-includes:
917         * Scripts/fix-blink-patch:
918         * Scripts/generate-coverage-data:
919         * Scripts/git-add-reviewer:
920         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
921         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
922         * Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz:
923         * Scripts/make-new-script-test:
924         * Scripts/make-script-test-wrappers:
925         * Scripts/package-root:
926         * Scripts/parse-malloc-history:
927         * Scripts/report-include-statistics:
928         * Scripts/resolve-ChangeLogs:
929         * Scripts/run-api-tests:
930         * Scripts/run-bindings-tests:
931         * Scripts/run-content-extension-tester:
932         * Scripts/run-iexploder-tests:
933         * Scripts/run-javascriptcore-tests:
934         * Scripts/run-jsc:
935         * Scripts/run-leaks:
936         * Scripts/run-mangleme-tests:
937         * Scripts/run-minibrowser:
938         * Scripts/run-pageloadtest:
939         * Scripts/run-regexp-tests:
940         * Scripts/run-safari:
941         * Scripts/run-sunspider:
942         * Scripts/run-test-runner:
943         * Scripts/run-webkit-app:
944         * Scripts/run-webkit-httpd:
945         * Scripts/run-webkit-websocketserver:
946         * Scripts/set-webkit-configuration:
947         * Scripts/show-pretty-diff:
948         * Scripts/sort-Xcode-project-file:
949         * Scripts/split-file-by-class:
950         * Scripts/sunspider-compare-results:
951         * Scripts/svn-apply:
952         * Scripts/svn-unapply:
953         * Scripts/test-webkit-scripts:
954         * Scripts/test-webkitperl:
955         * Scripts/update-iexploder-cssproperties:
956         * Scripts/update-javascriptcore-test-results:
957         * Scripts/update-webkit:
958         * Scripts/update-webkit-auxiliary-libs:
959         * Scripts/update-webkit-dependency:
960         * Scripts/update-webkit-libs-jhbuild:
961         * Scripts/update-webkit-localizable-strings:
962         * Scripts/update-webkit-support-libs:
963         * Scripts/update-webkitgtk-libs:
964         * Scripts/update-webkitwpe-libs:
965         * Scripts/webkit-build-directory:
966         * Scripts/webkitperl/LoadAsModule.pm:
967         * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
968         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
969         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl:
970         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl:
971         * Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl:
972         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
973         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
974         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
975         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
976         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
977         * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl:
978         * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
979         * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl:
980         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
981         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
982         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
983         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
984         * Scripts/webkitperl/VCSUtils_unittest/parseUnifiedDiffHeader.pl:
985         * Scripts/webkitperl/VCSUtils_unittest/prepareParsedPatch.pl:
986         * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl:
987         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl:
988         * Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl:
989         * Scripts/webkitperl/VCSUtils_unittest/setChangeLogDateAndReviewer.pl:
990         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl:
991         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl:
992         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
993         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl:
994         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl:
995         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
996         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
997         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
998         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
999         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl:
1000         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl:
1001         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl:
1002         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
1003         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
1004         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl:
1005         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl:
1006         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
1007         * ccache/ccache-clang:
1008         * ccache/ccache-clang++:
1009         * ccache/ccache-wrapper:
1010         * gtk/install-dependencies:
1011         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi:
1012         * iExploder/iexploder-1.3.2/htdocs/webserver.rb:
1013         * iExploder/iexploder-1.3.2/tools/lasthit.rb:
1014         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb:
1015         * iExploder/iexploder-1.3.2/tools/showtest.rb:
1016         * iExploder/iexploder-1.7.2/src/browser_harness.rb:
1017         * iExploder/iexploder-1.7.2/src/iexploder.cgi:
1018         * iExploder/iexploder-1.7.2/src/webserver.rb:
1019         * iExploder/iexploder-1.7.2/tools/lasthit.rb:
1020         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb:
1021         * wpe/install-dependencies:
1022
1023 2018-01-03  Simon Fraser  <simon.fraser@apple.com>
1024
1025         filter-build-webkit filters out useful compiler error lines
1026         https://bugs.webkit.org/show_bug.cgi?id=179864
1027
1028         Reviewed by Tim Horton.
1029
1030         Don't filter out lines that contain information about build errors by always showing lines
1031         after a line that contains "note:" or "error:".
1032
1033         * Scripts/filter-build-webkit:
1034         (shouldShowSubsequentLine):
1035         (shouldIgnoreLine):
1036
1037 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1038
1039         REGRESSION(r226366): [GTK] Broke TestBackForwardList and TestWebKitWebView
1040         https://bugs.webkit.org/show_bug.cgi?id=173915
1041
1042         Unreviewed follow-up. Fix /webkit2/WebKitWebView/session-state-with-form-data and
1043         /webkit2/WebKitWebView/submit-form. The form ID may be NULL, but we can't put NULL into a
1044         GVariant unless we use maybe types, and maybe types are incompatible with D-Bus. So use an
1045         empty string in this case.
1046
1047         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1048         (emitFormSubmissionEvent):
1049
1050 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1051
1052         [GTK] Add web process API to detect when form is submitted via JavaScript
1053         https://bugs.webkit.org/show_bug.cgi?id=173915
1054
1055         Reviewed by Carlos Garcia Campos.
1056
1057         Test it.
1058
1059         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1060         (FormSubmissionTest::FormSubmissionTest):
1061         (FormSubmissionTest::~FormSubmissionTest):
1062         (FormSubmissionTest::testFormSubmissionResult):
1063         (FormSubmissionTest::willSendDOMEventCallback):
1064         (FormSubmissionTest::willCompleteCallback):
1065         (FormSubmissionTest::runJavaScriptAndWaitUntilFormSubmitted):
1066         (testWebExtensionFormSubmissionSteps):
1067         (beforeAll):
1068         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1069         (DelayedSignal::DelayedSignal):
1070         (emitFormSubmissionEvent):
1071         (handleFormSubmissionCallback):
1072         (willSubmitFormCallback):
1073         (pageCreatedCallback):
1074
1075 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1076
1077         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/databases
1078         https://bugs.webkit.org/show_bug.cgi?id=181251
1079
1080         * Scripts/run-gtk-tests:
1081         (GtkTestRunner):
1082
1083 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1084
1085         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/ephemeral
1086         https://bugs.webkit.org/show_bug.cgi?id=181136
1087
1088         * Scripts/run-gtk-tests:
1089         (GtkTestRunner):
1090
1091 2018-01-02  Brent Fulgham  <bfulgham@apple.com>
1092
1093         [macOS, iOS] Adopt new secure coding APIs in WebKit
1094         https://bugs.webkit.org/show_bug.cgi?id=181085
1095         <rdar://problem/34837397>
1096
1097         Reviewed by Tim Horton.
1098
1099         Update API tests to use secure coding wherever possible. Currently, NSView/UIView-based classes are not
1100         capable of supporting NSSecureCoding, so pass through the current coding routines.
1101
1102         * TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm: Updated for NSSecureCoding.
1103         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
1104         (encodeAndDecode): Check if class supports the NSSecureCoding protocol and use non-secure coding
1105         routines if necessary.
1106         (TEST): Updated for NSSecureCoding.
1107         * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm:
1108         (TestWebKitAPI::TEST): Updated for NSSecureCoding.
1109
1110 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
1111
1112         Remove std::chrono completely
1113         https://bugs.webkit.org/show_bug.cgi?id=181186
1114
1115         Reviewed by Alex Christensen.
1116
1117         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1118         (WTR::TestController::platformRunUntil):
1119
1120 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1121
1122         REGRESSION(r223253): Broke ResourceLoadStatistics layout tests for non-Cocoa ports
1123         https://bugs.webkit.org/show_bug.cgi?id=181231
1124
1125         Reviewed by Alex Christensen.
1126
1127         Implement TestController APIs needed by ResourceLoadStatistics tests.
1128
1129         * WebKitTestRunner/TestController.cpp:
1130         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
1131         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
1132
1133 2018-01-02  Tim Horton  <timothy_horton@apple.com>
1134
1135         Disable WKAttachmentTests if UIPasteboard.itemProviders is not available
1136         https://bugs.webkit.org/show_bug.cgi?id=181219
1137
1138         Reviewed by Wenson Hsieh.
1139
1140         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1141
1142 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1143
1144         Add a WebAuthentication runtime feature flag
1145         https://bugs.webkit.org/show_bug.cgi?id=181220
1146         <rdar://problem/36055305>
1147
1148         Reviewed by Brent Fulgham.
1149
1150         Renames the CredentialManagement runtime feature flag into WebAuthentication.
1151
1152         * DumpRenderTree/TestOptions.h:
1153         * DumpRenderTree/TestOptions.mm:
1154         (TestOptions::TestOptions):
1155         * DumpRenderTree/mac/DumpRenderTree.mm:
1156         (enableExperimentalFeatures):
1157         (setWebPreferencesForTestOptions):
1158         * WebKitTestRunner/TestController.cpp:
1159         (WTR::TestController::resetPreferencesToConsistentValues):
1160         (WTR::updateTestOptionsFromTestHeader):
1161         * WebKitTestRunner/TestOptions.h:
1162         (WTR::TestOptions::hasSameInitializationOptions const):
1163
1164 2018-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1165
1166         [Attachment Support] Don't Blob-convert images and attachments with https:, http: or data: urls
1167         https://bugs.webkit.org/show_bug.cgi?id=181143
1168         <rdar://problem/36200381>
1169
1170         Reviewed by Tim Horton.
1171
1172         Add a new API test to ensure that a copied image with a data URL does not get pasted as an attachment when
1173         attachment elements are enabled.
1174
1175         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1176         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1177         (TestWebKitAPI::TEST):
1178
1179 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1180
1181         Update Credential Management API for WebAuthentication
1182         https://bugs.webkit.org/show_bug.cgi?id=181082
1183         <rdar://problem/36055239>
1184
1185         Reviewed by Brent Fulgham.
1186
1187         Enable Credential Management API for testing.
1188
1189         * DumpRenderTree/TestOptions.h:
1190         * WebKitTestRunner/TestOptions.h:
1191
1192 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1193
1194         [GTK] Test /webkit2/WebKitWebExtension/form-controls-associated-signal is flaky
1195         https://bugs.webkit.org/show_bug.cgi?id=168194
1196
1197         Reviewed by Carlos Garcia Campos.
1198
1199         Fix an assertion and unskip the test. The order that form controls are associated is not
1200         guaranteed.
1201
1202         * Scripts/run-gtk-tests:
1203         (GtkTestRunner):
1204         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1205         (didAssociateFormControlsCallback):
1206
1207 2018-01-02  Alex Christensen  <achristensen@webkit.org>
1208
1209         Use new WebsiteDataStore passed in through decidePolicyForNavigation SPI
1210         https://bugs.webkit.org/show_bug.cgi?id=180897
1211         <rdar://problem/35535328>
1212
1213         Reviewed by Brent Fulgham.
1214
1215         Test two forms of storage to be sure we are using a different WebsiteDataStore: cookies and sessionStorage.
1216
1217         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1218         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1219         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:startURLSchemeTask:]):
1220         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1221         (websiteDataStoreTestWebView):
1222         (TEST):
1223
1224 == Rolled over to ChangeLog-2018-01-01 ==