Uneviewed, added myself to contributors.json.
[WebKit-https.git] / Tools / ChangeLog
1 2020-03-23  Nikos Mouchtaris  <nmouchtaris@apple.com>
2
3         Uneviewed, added myself to contributors.json.
4
5         * Scripts/webkitpy/common/config/contributors.json:
6
7 2020-03-23  Daniel Bates  <dabates@apple.com>
8
9         Support inserting text or dictation alternative by simulating keyboard input
10         https://bugs.webkit.org/show_bug.cgi?id=209380
11         <rdar://problem/59445102>
12
13         Reviewed by Darin Adler.
14
15         Add tests to ensure that DOM events are dispatched on insertion when shouldSimulateKeyboardInput
16         is enabled.
17
18         I also added a convenience assertion function, EXPECT_NS_EQUAL, that can
19         compare NSObjects so long as they implement -isEqual and -description. I
20         make use of this to compare the actual array of fired DOM events types to
21         an expected array.
22
23         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
24         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
25         (TestWebKitAPI::shouldSimulateKeyboardInputOnTextInsertionOverride):
26         (TestWebKitAPI::TEST):
27         * TestWebKitAPI/cocoa/TestCocoa.h:
28         (TestWebKitAPI::Util::assertNSObjectsAreEqual): Added.
29         (EXPECT_NS_EQUAL): Added.
30         * TestWebKitAPI/ios/insert-text.html: Added.
31
32 2020-03-23  Kate Cheney  <katherine_cheney@apple.com>
33
34         Add checks for app-bound navigations when evaluating user style sheets
35         https://bugs.webkit.org/show_bug.cgi?id=209368
36         <rdar://problem/60204230>
37
38         Reviewed by Brent Fulgham.
39
40         Tested cases based on those in UserContentController.mm.
41
42         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
43         (-[InAppBrowserSchemeHandler webView:startURLSchemeTask:]):
44         (expectScriptEvaluatesToColor):
45         (TEST):
46
47
48 2020-03-23  Alex Christensen  <achristensen@webkit.org>
49
50         Add SPI to move localStorage to a different domain
51         https://bugs.webkit.org/show_bug.cgi?id=209260
52         <rdar://problem/60285683>
53
54         Reviewed by Brady Eidson.
55
56         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
57         (TEST):
58
59 2020-03-23  youenn fablet  <youenn@apple.com>
60
61         Disable TestWebKitAPI.ProcessSwap.GetUserMediaCaptureState if getUserMedia is not supported
62         https://bugs.webkit.org/show_bug.cgi?id=209428
63
64         Reviewed by Jonathan Bedard.
65
66         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
67
68 2020-03-23  Chris Lord  <clord@igalia.com>
69
70         Add missing committer status to Chris Lord in contributors.json
71
72         Unreviewed
73
74         * Scripts/webkitpy/common/config/contributors.json:
75
76 2020-03-23  youenn fablet  <youenn@apple.com>
77
78         StringView::startsWith and String::startsWith do not treat null strings the same
79         https://bugs.webkit.org/show_bug.cgi?id=209273
80
81         Reviewed by Darin Adler.
82
83         * TestWebKitAPI/Tests/WTF/StringView.cpp:
84         (TestWebKitAPI::TEST):
85         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
86         (TestWebKitAPI::TEST):
87
88 2020-03-22  Antoine Quint  <graouts@apple.com>
89
90         DocumentTimeline / CSSTransition objects are leaking on CNN.com
91         https://bugs.webkit.org/show_bug.cgi?id=208069
92         <rdar://problem/59680143>
93
94         Reviewed by Simon Fraser, Geoffrey Garen and Darin Adler.
95
96         Add a test that checks that a ListHashSet containing RefPtr<> types correctly calls the destructor for those items when the assignment operator is used.
97
98         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
99         (TestWebKitAPI::ListHashSetReferencedItem::create):
100         (TestWebKitAPI::ListHashSetReferencedItem::ListHashSetReferencedItem):
101         (TestWebKitAPI::ListHashSetReferencedItem::~ListHashSetReferencedItem):
102         (TestWebKitAPI::FakeElementAnimationRareData::FakeElementAnimationRareData):
103         (TestWebKitAPI::FakeElementAnimationRareData::~FakeElementAnimationRareData):
104         (TestWebKitAPI::FakeElementAnimationRareData::collection):
105         (TestWebKitAPI::FakeElementAnimationRareData::setCollection):
106         (TestWebKitAPI::TEST):
107
108 2020-03-21  Michael Catanzaro  <mcatanzaro@gnome.org>
109
110         [GTK] Use ${PYTHON_EXECUTABLE} to run generate-gtkdoc
111         https://bugs.webkit.org/show_bug.cgi?id=208970
112
113         Reviewed by Konstantin Tokarev.
114
115         We are allowed to use /usr/bin/env in this script because it's not installed (so not
116         packaged). Therefore we can make the shebang compatible with FreeBSD in this particularl
117         case.
118
119         * gtkdoc/generate-gtkdoc:
120
121 2020-03-20  Jonathan Bedard  <jbedard@apple.com>
122
123         run-webkit-tests: Report MacCatalyst as a unique platform
124         https://bugs.webkit.org/show_bug.cgi?id=209361
125
126         Rubber-stamped by Aakash Jain.
127
128         * Scripts/webkitpy/port/mac.py:
129         (MacCatalystPort):
130         (MacCatalystPort.configuration_for_upload): Treat MacCatalyst as a separate platform from Mac.
131
132 2020-03-20  Alex Christensen  <achristensen@webkit.org>
133
134         CORS-disabling SPI introduced in r253978 should make responses non-opaque
135         https://bugs.webkit.org/show_bug.cgi?id=209351
136         <rdar://problem/60024850>
137
138         Reviewed by Chris Dumez.
139
140         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
141
142 2020-03-20  Aakash Jain  <aakash_jain@apple.com>
143
144         commit-queue should skip building and testing if patch already passed tests on mac-wk2 queue
145         https://bugs.webkit.org/show_bug.cgi?id=208938
146
147         Reviewed by Jonathan Bedard.
148
149         * BuildSlaveSupport/ews-build/steps.py:
150         (RunWebKitTests.doStepIf): Skip testing if patch already passed mac-wk2 tests.
151         (CheckPatchStatusOnEWSQueues): Build-step to check patch status on other queues.
152         (CheckPatchStatusOnEWSQueues.get_patch_status):
153         (CheckPatchStatusOnEWSQueues.start):
154         * BuildSlaveSupport/ews-build/steps_unittest.py:
155         (test_skip_for_mac_wk2_passed_patch_on_commit_queue): Added unit-tests.
156         * BuildSlaveSupport/ews-build/factories.py: Added build-step to check the patch status on other queues.
157         * BuildSlaveSupport/ews-build/factories_unittest.py: Updated unit-test.
158         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added the new step status to STEPS_TO_HIDE.
159
160 2020-03-20  Aakash Jain  <aakash_jain@apple.com>
161
162         [ews] Better organize patch status api data
163         https://bugs.webkit.org/show_bug.cgi?id=209342
164
165         Reviewed by Jonathan Bedard.
166
167         * BuildSlaveSupport/ews-app/ews/views/status.py:
168         (Status._build_status):
169         (Status._build_statuses_for_patch): Updated to return dictionary instead of list.
170         (Status.get): Remove safe=false now that we are returning a dictionary.
171
172 2020-03-20  Tim Horton  <timothy_horton@apple.com>
173
174         Upstream a variety of Cocoa-platform HAVE and ENABLE macros
175         https://bugs.webkit.org/show_bug.cgi?id=209307
176
177         Reviewed by Andy Estes.
178
179         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
180
181 2020-03-20  Jacob Uphoff  <jacob_uphoff@apple.com>
182
183         Unreviewed, reverting r258748.
184
185         This commit broke the Catalina build
186
187         Reverted changeset:
188
189         "Upstream a variety of Cocoa-platform HAVE and ENABLE macros"
190         https://bugs.webkit.org/show_bug.cgi?id=209307
191         https://trac.webkit.org/changeset/258748
192
193 2020-03-20  Aakash Jain  <aakash_jain@apple.com>
194
195         [ews] commit-queue should comment on bug if patch fails to apply
196         https://bugs.webkit.org/show_bug.cgi?id=209334
197
198         Reviewed by Jonathan Bedard.
199
200         * BuildSlaveSupport/ews-build/steps.py:
201         (ApplyPatch):
202         (ApplyPatch.evaluateCommand): Overridden to check build status and queue name and comment on bug accordingly.
203         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
204         (TestApplyPatch):
205         (TestApplyPatch.setUp):
206         (TestApplyPatch.setUp.mock_start):
207         (TestApplyPatch.tearDown):
208         (TestApplyPatch.test_success):
209         (TestApplyPatch.test_failure):
210         (TestApplyPatch.test_failure_on_commit_queue):
211
212 2020-03-20  Aakash Jain  <aakash_jain@apple.com>
213
214         [EWS] Limit number of builds to display in status-bubble hover over message in case of lot of retried builds
215         https://bugs.webkit.org/show_bug.cgi?id=209122
216
217         Reviewed by Jonathan Bedard.
218
219         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
220         (StatusBubble._build_bubble):
221
222 2020-03-19  Tim Horton  <timothy_horton@apple.com>
223
224         Upstream a variety of Cocoa-platform HAVE and ENABLE macros
225         https://bugs.webkit.org/show_bug.cgi?id=209307
226
227         Reviewed by Andy Estes.
228
229         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
230
231 2020-03-19  Alex Christensen  <achristensen@webkit.org>
232
233         Remove test failing after r258734
234         https://bugs.webkit.org/show_bug.cgi?id=209303
235
236         We removed the functionality it was testing because it did nothing useful except call the callback.
237         I'm about to remove the only user of WKContextGetStatistics.
238
239         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
240         * TestWebKitAPI/Tests/WebKit/WebCoreStatisticsWithNoWebProcess.cpp: Removed.
241
242 2020-03-19  Aakash Jain  <aakash_jain@apple.com>
243
244         commit-queue status-bubble shows incorrect position in queue
245         https://bugs.webkit.org/show_bug.cgi?id=209313
246
247         Reviewed by Jonathan Bedard.
248
249         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
250         (StatusBubble._queue_position):
251
252 2020-03-19  Takashi Komori  <Takashi.Komori@sony.com>
253
254         [Curl] Add an API returns description of verification errors.
255         https://bugs.webkit.org/show_bug.cgi?id=208913
256
257         Reviewed by Fujii Hironori.
258
259         WKCertificateInfoCopyVerificationErrorDescription returns the description of SSL verification error as human readable string.
260         Browser can display more precise error information with this API.
261
262         API Test: Curl.CertificateAPI
263
264         * MiniBrowser/win/Common.cpp:
265         (askServerTrustEvaluation):
266         * MiniBrowser/win/Common.h:
267         * MiniBrowser/win/WebKitBrowserWindow.cpp:
268         (createPEMString):
269         (WebKitBrowserWindow::canTrustServerCertificate):
270         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp:
271         (TestWebKitAPI::Curl::TEST):
272
273 2020-03-19  Aakash Jain  <aakash_jain@apple.com>
274
275         Update build.webkit.org link for EWS
276         https://bugs.webkit.org/show_bug.cgi?id=209280
277
278         Reviewed by Alexey Proskuryakov.
279
280         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
281
282 2020-03-19  Stephan Szabo  <stephan.szabo@sony.com>
283
284         [WinCairo] extract-built-product fails after r258612
285         https://bugs.webkit.org/show_bug.cgi?id=209285
286
287         extractBuiltProduct also references the old name for the
288         requirements on wincairo.
289
290         Reviewed by Ross Kirsling.
291
292         * BuildSlaveSupport/built-product-archive:
293
294 2020-03-19  Philippe Normand  <pnormand@igalia.com>
295
296         [Flatpak SDK] Release logs not sent to journald when running within the SDK runtime
297         https://bugs.webkit.org/show_bug.cgi?id=209223
298
299         Reviewed by Carlos Alberto Lopez Perez.
300
301         flatpak build doesn't expose a --socket option for white-listing
302         the systemd journal socket. So white-list everything in /run. 🤷
303
304         * flatpak/flatpakutils.py:
305         (WebkitFlatpak.run_in_sandbox):
306
307 2020-03-19  Charlie Turner  <cturner@igalia.com>
308
309         Fix many warnings with Clang 7.0 on GTK x86-64 in Debug.
310         https://bugs.webkit.org/show_bug.cgi?id=209146
311
312         Reviewed by Darin Adler.
313
314         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp:
315         (TestWebKitAPI::TEST):
316         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
317         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
318         (testDownloadMIMEType):
319         (testContextMenuDownloadActions):
320         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
321
322 2020-03-19  Carlos Garcia Campos  <cgarcia@igalia.com>
323
324         [GTK][WPE] REGRESSION(r258626): flatpak is used even when WEBKIT_JHBUILD is set
325         https://bugs.webkit.org/show_bug.cgi?id=209278
326
327         Reviewed by Philippe Normand.
328
329         This happens when using an external jhbuild, because shouldUseFlatpak() assumes that no command prefix always
330         means flatpak.
331
332         * Scripts/webkitdirs.pm:
333         (shouldUseFlatpak): Return early if WEBKIT_JHBUILD is set.
334
335 2020-03-19  Philippe Normand  <pnormand@igalia.com>
336
337         [CMake] cache not cleared when build-webkit options change
338         https://bugs.webkit.org/show_bug.cgi?id=209277
339
340         Reviewed by Adrian Perez de Castro.
341
342         * Scripts/webkitdirs.pm:
343         (shouldRemoveCMakeCache): The expected function signature never
344         included the cache file path. Remove it.
345
346 2020-03-18  Philippe Normand  <pnormand@igalia.com>
347
348         REGRESSION(r258626): webkit-dirs warning
349         https://bugs.webkit.org/show_bug.cgi?id=209221
350
351         Reviewed by Adrian Perez de Castro.
352
353         * Scripts/webkitdirs.pm:
354         (buildCMakeProjectOrExit): Fix Perl Warning. 😎
355
356 2020-03-19  Chris Lord  <clord@igalia.com>
357
358         Add Chris Lord (clord@igalia.com) to the list of contributors
359         https://bugs.webkit.org/show_bug.cgi?id=209274
360
361         Unreviewed
362
363         * Scripts/webkitpy/common/config/contributors.json:
364
365 2020-03-19  Ryan Haddad  <ryanhaddad@apple.com>
366
367         Remove commit queue bubble from bot watchers dashboard
368         https://bugs.webkit.org/show_bug.cgi?id=209271
369
370         Reviewed by Alexey Proskuryakov.
371
372         Remove commit queue bubble from bot watchers dashboard now that it has moved to the new EWS.
373
374         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
375         (BubbleQueueServer): 
376
377 2020-03-18  Simon Fraser  <simon.fraser@apple.com>
378
379         eventSender.monitorWheelEvents() is very fragile
380         https://bugs.webkit.org/show_bug.cgi?id=197819
381         <rdar://problem/51319456>
382
383         Reviewed by Tim Horton.
384
385         Deflake tests using eventSender.monitorWheelEvents() by fixing several causes of flakiness,
386         adding back changes from r257844 that were reverted in r258558.
387         
388         First, have EventSendingController keep track of whether it's seen then "end" event
389         for the scrolling and momentum phases, and pass this down to WheelEventTestMonitor, which
390         now waits until it sees these, which prevents premature triggering which was a common cause of
391         failure before.
392         
393         Second, remove WheelEventTestMonitor's 1/60s timer and instead have WheelEventTestMonitor test
394         for completion in a callout from the end of Page::updateRendering(), which makes it test
395         and fire at a more consistent time.
396         
397         Third, push WheelEventTestMonitor to the ScrollingTree, so that reasons for deferral
398         can be added on the scrolling thread. This fixes an issue where the RunLoop::main().dispatch()
399         used to send the "ScrollingThreadSyncNeeded" reason to the main thread would get delayed,
400         also resulting in a premature trigger.
401
402         * DumpRenderTree/mac/EventSendingController.h:
403         * DumpRenderTree/mac/EventSendingController.mm:
404         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
405         (-[EventSendingController monitorWheelEvents]):
406         (-[EventSendingController callAfterScrollingCompletes:]):
407         * DumpRenderTree/win/EventSender.cpp:
408         (mouseScrollBy):
409         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
410         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
411         (WTR::EventSendingController::monitorWheelEvents):
412         (WTR::EventSendingController::callAfterScrollingCompletes):
413         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
414
415 2020-03-18  John Wilander  <wilander@apple.com>
416
417         WebResourceLoadStatisticsStore::requestStorageAccessUnderOpener() should call its ephemeral counterpart when appropriate
418         https://bugs.webkit.org/show_bug.cgi?id=209245
419         <rdar://problem/60511121>
420
421         Reviewed by Chris Dumez.
422
423         These changes to the TestRunner makes sure that
424         - statisticsClearInMemoryAndPersistentStore()
425         - statisticsClearInMemoryAndPersistentStoreModifiedSinceHours()
426         ... use their own StatisticsDidClearInMemoryAndPersistentStoreCallbackID
427         and adds the infrastructure for that.
428
429         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
430         (WTR::InjectedBundle::didReceiveMessageToPage):
431         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
432         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
433         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
434         (WTR::TestRunner::statisticsCallClearInMemoryAndPersistentStoreCallback):
435         * WebKitTestRunner/InjectedBundle/TestRunner.h:
436         * WebKitTestRunner/TestController.cpp:
437         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
438         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
439         * WebKitTestRunner/TestInvocation.cpp:
440         (WTR::TestInvocation::didClearStatisticsInMemoryAndPersistentStore):
441         * WebKitTestRunner/TestInvocation.h:
442
443 2020-03-18  Wenson Hsieh  <wenson_hsieh@apple.com>
444
445         REGRESSION (r257214): Targeted preview animates to the wrong place when dropping in editable content
446         https://bugs.webkit.org/show_bug.cgi?id=209218
447         <rdar://problem/60560831>
448
449         Reviewed by Tim Horton.
450
451         Augment the drag and drop test harness to verify that for all targeted previews, if they have container views,
452         those views must be parented (i.e. they must be connected to a UIWindow).
453
454         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
455         (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
456         (-[DragAndDropSimulator _expectNoDropPreviewsWithUnparentedContainerViews]):
457         (-[DragAndDropSimulator _invokeDropAnimationCompletionBlocksAndConcludeDrop]):
458
459 2020-03-18  Aakash Jain  <aakash_jain@apple.com>
460
461         [ews] commit-queue should comment on bug in case of test failures
462         https://bugs.webkit.org/show_bug.cgi?id=209226
463
464         Reviewed by Jonathan Bedard.
465
466         * BuildSlaveSupport/ews-build/steps.py:
467         (AnalyzeLayoutTestsResults.report_failure): Comment on bug and set cq- in case of test failure on commit-queue.
468         (BuildLogLineObserver.outLineReceived): Drive-by fix to use single quotes instead of double quotes.
469         (SetBuildSummary): Ditto.
470         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
471
472 2020-03-18  Philippe Normand  <pnormand@igalia.com>
473
474         REGRESSION (r258626): test262 tests failing to run on macOS with error 'Undefined subroutine &Test262::Runner::setConfiguration'
475         https://bugs.webkit.org/show_bug.cgi?id=209238
476
477         Reviewed by Jonathan Bedard.
478
479         * Scripts/test262-runner: Perform the flatpak check on Linux only.
480
481 2020-03-18  Stephan Szabo  <stephan.szabo@sony.com>
482
483         [WinCairo] archive-built-product fails after r258612
484         https://bugs.webkit.org/show_bug.cgi?id=209237
485
486         Reviewed by Alex Christensen.
487
488         * BuildSlaveSupport/built-product-archive:
489         Update name of version file for requirements version
490         file for wincairo.
491
492 2020-03-18  Aakash Jain  <aakash_jain@apple.com>
493
494         commit-queue should allow patches which are reviewed by patch author
495         https://bugs.webkit.org/show_bug.cgi?id=209231
496
497         Reviewed by Jonathan Bedard.
498
499         * BuildSlaveSupport/ews-build/steps.py:
500         (BugzillaMixin._does_patch_have_acceptable_review_flag):
501
502 2020-03-18  Philippe Normand  <pnormand@igalia.com>
503
504         [JHBuild] Flatpak used for run-minibrowser even when forcing jhbuild
505         https://bugs.webkit.org/show_bug.cgi?id=209222
506
507         Reviewed by Carlos Alberto Lopez Perez.
508
509         * Scripts/webkitdirs.pm:
510         (runInFlatpakIfAvailable): If a command wrapper is required it
511         means Flatpak shouldn't be used.
512
513 2020-03-18  Aakash Jain  <aakash_jain@apple.com>
514
515         [ews] commit-queue should comment on bug in case patch fails to build
516         https://bugs.webkit.org/show_bug.cgi?id=209227
517
518         Reviewed by Jonathan Bedard.
519
520         * BuildSlaveSupport/ews-build/steps.py:
521         (AnalyzeCompileWebKitResults.start):
522         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
523
524 2020-03-18  Philippe Normand  <pnormand@igalia.com>
525
526         [GTK][WPE] Migrate to Flatpak-based dev SDK
527         https://bugs.webkit.org/show_bug.cgi?id=205658
528
529         Reviewed by Carlos Alberto Lopez Perez.
530
531         JHBuild will now be used only if the WEBKIT_JHBUILD environment
532         variable is set to 1, which is the case for the time being on the
533         GTK and WPE EWS/build bots.
534
535         By default the build dependencies are now locally installed from a
536         Flatpak repository hosted at https://software.igalia.com. The
537         repository can be regenerated with the scripts from the
538         webkit-flatpak-sdk Github project
539         (https://github.com/Igalia/webkit-flatpak-sdk). This is done
540         transparently with the update-webkit{gtk,wpe}-libs scripts. As
541         there is no need to rebuild the dependencies from scratch, the
542         developer user-experience should now be much more friendly and
543         overall build times reduced.
544
545         As an additional commodity, the new environment supports the
546         GStreamer gst-build-based workflow. Just set the GST_BUILD_PATH
547         environment variable to your gst-build path. This feature was
548         contributed by Thibault Saunier.
549
550         The JHBuild infrastructure will be removed once all the bots have
551         been switched over to Flatpak.
552
553         * BuildSlaveSupport/ews-build/steps.py:
554         (InstallGtkDependencies):
555         (InstallWpeDependencies):
556         (CompileWebKit.start):
557         * BuildSlaveSupport/gtk/buildbot/run:
558         * Scripts/build-webkit:
559         * Scripts/run-bindings-tests:
560         * Scripts/run-builtins-generator-tests:
561         * Scripts/run-gtk-tests:
562         * Scripts/run-javascriptcore-tests:
563         * Scripts/run-minibrowser:
564         * Scripts/run-qt-wpe-minibrowser:
565         * Scripts/run-webdriver-tests:
566         * Scripts/run-wpe-tests:
567         * Scripts/test-webkitperl:
568         * Scripts/test-webkitpy:
569         * Scripts/test262-runner:
570         * Scripts/update-webkit-flatpak: Renamed from Tools/Scripts/update-webkitgtk-flatpak.
571         * Scripts/update-webkitgtk-libs:
572         * Scripts/update-webkitwpe-flatpak: Removed.
573         * Scripts/update-webkitwpe-libs:
574         * Scripts/webkitdirs.pm:
575         (getUserFlatpakPath):
576         (inFlatpakSandbox):
577         (runInFlatpakIfAvailable):
578         (wrapperPrefixIfNeeded):
579         (shouldUseJhbuild):
580         (shouldUseFlatpak):
581         (shouldRemoveCMakeCache):
582         * Scripts/webkitpy/common/system/executive.py:
583         (Executive.kill_all):
584         * Scripts/webkitpy/port/base.py:
585         (Port._path_to_apache):
586         (Port._should_run_as_pixel_test):
587         (Port._in_flatpak_sandbox):
588         * Scripts/webkitpy/port/gtk.py:
589         (GtkPort.setup_environ_for_server):
590         (GtkPort._get_crash_log):
591         * Scripts/webkitpy/port/linux_get_crash_log.py:
592         (GDBCrashLogGenerator):
593         (GDBCrashLogGenerator.__init__):
594         (GDBCrashLogGenerator.generate_crash_log):
595         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
596         (GDBCrashLogGeneratorTest.test_generate_crash_log):
597         * Scripts/webkitpy/port/wpe.py:
598         (WPEPort.setup_environ_for_server):
599         (WPEPort._get_crash_log):
600         * Scripts/webkitpy/port/xvfbdriver.py:
601         (XvfbDriver._setup_environ_for_test):
602         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
603         (WTR::getFontsPath):
604         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
605         (WTR::getFontsPath):
606         * flatpak/files/default.xkm: Removed.
607         * flatpak/files/httpd-autogen.sh: Removed.
608         * flatpak/flatpakutils.py:
609         (check_flatpak):
610         (FlatpakRepos.update):
611         (FlatpakPackage.__repr__):
612         (FlatpakPackage.__str__):
613         (WebkitFlatpak.load_from_args):
614         (WebkitFlatpak.__init__):
615         (WebkitFlatpak.clean_args):
616         (WebkitFlatpak.setup_builddir):
617         (WebkitFlatpak):
618         (WebkitFlatpak.setup_gstbuild):
619         (WebkitFlatpak.run_in_sandbox):
620         (WebkitFlatpak.run):
621         (WebkitFlatpak.has_environment):
622         (WebkitFlatpak.save_config):
623         (WebkitFlatpak.setup_dev_env):
624         (WebkitFlatpak.install_all):
625         (WebkitFlatpak.run_gdb):
626         * flatpak/org.webkit.CommonModules.yaml: Removed.
627         * flatpak/org.webkit.GTK.yaml: Removed.
628         * flatpak/org.webkit.WPE.yaml: Removed.
629         * flatpak/org.webkit.WPEModules.yaml: Removed.
630         * flatpak/org.webkit.WPEQT.yaml: Removed.
631         * flatpak/org.webkit.WebKit.yaml: Removed.
632         * flatpak/patches/httpd-0001-configure-use-pkg-config-for-PCRE-detection.patch: Removed.
633         * flatpak/patches/libgcrypt-0001-Use-pkg-config-to-detect-gpg-error.patch: Removed.
634         * flatpak/patches/xvfb-0001-HACK-Avoid-compiling-a-kbm-file.patch: Removed.
635
636 2020-03-17  Kate Cheney  <katherine_cheney@apple.com>
637
638         Expand In-App-Browser-Privacy testing
639         https://bugs.webkit.org/show_bug.cgi?id=209142
640         <rdar://problem/60496618>
641
642         Reviewed by Darin Adler.
643
644         Expanded test coverage by adding new tests and creating a custom url
645         scheme handler to get around the fact that local file loads are
646         always classified as app-bound.
647
648         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
649         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
650         (-[InAppBrowserSchemeHandler webView:startURLSchemeTask:]):
651         If the path indicates testing user scripts on load, notify the script message
652         handler that the navigation has finished. If the path indicates
653         testing user-agent scripts, set the window.wkUserScriptInjected
654         variable to true. A user agent script will attempt to read this
655         variable and should fail.
656
657         (-[InAppBrowserSchemeHandler webView:stopURLSchemeTask:]):
658         (initializeInAppBrowserPrivacyTestSettings):
659         Basic test setup. Initialize the main run loop and make sure we are
660         starting with a clean state.
661
662         (TEST):
663         Add tests for all protocols checked in shouldBeTreatedAsAppBound,
664         except for blob files which must be generated within the web content.
665
666         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-local-file.html: Added.
667         Basic html document to test local file loads are classified as
668         app-bound.
669
670         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-agent-script.html: Removed.
671         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-script.html: Removed.
672         These files are no longer needed as their content is directly copied
673         into the URL scheme handler.
674
675 2020-03-17  Chris Dumez  <cdumez@apple.com>
676
677         REGRESSION: [ macOS wk1 ] ASSERTION FAILED: _notifications.contains(notificationID) imported/w3c/web-platform-tests/notifications/constructor-basic.html is flaky crashing
678         https://bugs.webkit.org/show_bug.cgi?id=207307
679         <rdar://problem/59206964>
680
681         Reviewed by Alex Christensen.
682
683         When [MockWebNotificationProvider reset] was called at the end of the test, it would remove all
684         notifications from the map but not tell WebCore that the notification were discarded. As a result,
685         WebCore would later tell the MockWebNotificationProvider to cancel the notification but this
686         notification would no longer be in the map, causing us to hit an assertion in debug.
687
688         To address the issue, we now call Notification::finalize() in [MockWebNotificationProvider reset]
689         to let WebCore know the notification was discarded. This is similar to what is already done for
690         WebKit2 in WebNotificationManager::clearNotifications().
691
692         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
693         (-[MockWebNotificationProvider reset]):
694
695 2020-03-17  Don Olmstead  <don.olmstead@sony.com>
696
697         [WinCairo][FTW] Update path to requirements download
698         https://bugs.webkit.org/show_bug.cgi?id=209202
699
700         Reviewed by Ross Kirsling.
701
702         Repository was renamed from WinCairoRequirements to WebKitRequirements in the
703         WebKitForWindows org on GitHub. Additionally the .zip file was renamed to
704         WebKitRequirementsWin64.zip.
705
706         * Scripts/update-webkit-wincairo-libs.py:
707
708 2020-03-17  Aakash Jain  <aakash_jain@apple.com>
709
710         [ews] Resubmit patches to commit-queue which were cq- by commit-queue and later cq+
711         https://bugs.webkit.org/show_bug.cgi?id=208920
712
713         Reviewed by Jonathan Bedard.
714
715         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
716         (Buildbot.update_builder_name_to_id_mapping): Method to generate builder name to id mapping.
717         (Buildbot.fetch_pending_and_inprogress_builds): Method to fetch pendign and in-progress builds from buildbot.
718         (Buildbot.get_patches_in_queue): Method to fetch list of patches which are pending or are in-progress on buildbot.
719         * BuildSlaveSupport/ews-app/ews/common/bugzilla.py:
720         (Bugzilla.get_cq_plus_timestamp): Get UTC timestamp when cq+ flag was set.
721         * BuildSlaveSupport/ews-app/ews/fetcher.py:
722         (FetchLoop.run): Update builder name to id mapping. We just need to update it one-time, since we need the id only
723         for commit-queue which isn't expected to change.
724         (BugzillaPatchFetcher.fetch_commit_queue_patches):
725         (BugzillaPatchFetcher.send_patches_to_buildbot): Allow sending the patch again to commit-queue.
726         (BugzillaPatchFetcher.patches_to_send_to_commit_queue): Find patches which needs to be sent to commit-queue. Filter
727         out patches which are already waiting or in-progress on commit-queue, or whose recent build was completed after
728         setting cq+ flag on bugzilla.
729
730 2020-03-17  Chris Dumez  <cdumez@apple.com>
731
732         [WKTR] testRunner API that takes in a completion handler should use async IPC
733         https://bugs.webkit.org/show_bug.cgi?id=209187
734
735         Reviewed by John Wilander.
736
737         testRunner API that takes in a completion handler should use async IPC. This hangs
738         the WebProcess for no reason and can cause deadlocks if the UIProcess then tries
739         to IPC the WebProcess as a result of this testRunner call.
740
741         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
742         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
743         (WTR::TestRunner::statisticsUpdateCookieBlocking):
744         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
745         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
746         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
747         (WTR::TestRunner::setStatisticsShouldDowngradeReferrer):
748         (WTR::TestRunner::setStatisticsFirstPartyWebsiteDataRemovalMode):
749         (WTR::TestRunner::statisticsResetToConsistentState):
750         (WTR::TestRunner::getAllStorageAccessEntries):
751         (WTR::TestRunner::removeAllSessionCredentials):
752         (WTR::TestRunner::getApplicationManifestThen):
753         * WebKitTestRunner/TestInvocation.cpp:
754         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
755         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
756
757 2020-03-17  Aakash Jain  <aakash_jain@apple.com>
758
759         [ews-app] Timestamp shown in status-bubble hover-over message is in future
760         https://bugs.webkit.org/show_bug.cgi?id=196628
761
762         Reviewed by Jonathan Bedard.
763
764         * BuildSlaveSupport/ews-build/events.py:
765         (JSONProducer.json_serialize_datetime): Keep the timestamp in UTC, instead of converting it to local time zone.
766         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
767         (StatusBubble.get_all_builds_for_queue): Sort the queues based on build number instead of start time, since the 
768         timestamps for new builds might be less than timestamps for old builds which completed immediately prior to this change.
769
770 2020-03-17  Alex Christensen  <achristensen@webkit.org>
771
772         Add WKUIDelegatePrivate SPI _webView:printFrame:completionHandler:
773         https://bugs.webkit.org/show_bug.cgi?id=209192
774         <rdar://problem/51313336>
775
776         Reviewed by Geoff Garen.
777
778         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
779         (-[PrintDelegateWithCompletionHandler _webView:printFrame:completionHandler:]):
780         (-[PrintDelegateWithCompletionHandler waitForPrintFrameCall]):
781         (TEST):
782
783 2020-03-17  Chris Dumez  <cdumez@apple.com>
784
785         Use less sync IPC for ITP testRunner methods
786         https://bugs.webkit.org/show_bug.cgi?id=209184
787
788         Reviewed by Alex Christensen.
789
790         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
791         (WTR::TestRunner::setStatisticsDebugMode):
792         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
793         (WTR::TestRunner::setStatisticsLastSeen):
794         (WTR::TestRunner::setStatisticsMergeStatistic):
795         (WTR::TestRunner::setStatisticsPrevalentResource):
796         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
797         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
798         * WebKitTestRunner/TestInvocation.cpp:
799         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
800         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
801
802 2020-03-17  Chris Dumez  <cdumez@apple.com>
803
804         [WKTR] Crash when trying to open a new window in an ephemeral session test
805         https://bugs.webkit.org/show_bug.cgi?id=209181
806
807         Reviewed by Geoffrey Garen.
808
809         Make sure that the new WKWebView is using the same data store as its related WKWebView.
810
811         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
812         (WTR::TestController::platformCreateOtherPage):
813
814 2020-03-17  Jacob Uphoff  <jacob_uphoff@apple.com>
815
816         Unreviewed, reverting r257844.
817
818         this revision caused a test to start timing out
819
820         Reverted changeset:
821
822         "(r256513) [ Mac ] fast/scrolling/programmatic-scroll-to-zero-
823         zero.html is a flaky failure"
824         https://bugs.webkit.org/show_bug.cgi?id=207948
825         https://trac.webkit.org/changeset/257844
826
827 2020-03-16  Justin Michaud  <justin_michaud@apple.com>
828
829         Add personal email to Tools/Scripts/webkitpy/common/config/contributors.json
830         https://bugs.webkit.org/show_bug.cgi?id=209151
831
832         Reviewed by Yusuke Suzuki.
833
834         * Scripts/webkitpy/common/config/contributors.json:
835
836 2020-03-16  Chris Dumez  <cdumez@apple.com>
837
838         Crash under WebCookieCache::clearForHost()
839         https://bugs.webkit.org/show_bug.cgi?id=209149
840         <rdar://problem/60453086>
841
842         Reviewed by Alex Christensen.
843
844         Add API test coverage.
845
846         * TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm:
847         (TEST):
848
849 2020-03-16  Keith Rollin  <krollin@apple.com>
850
851         Remove support for WebKitSystemInterface
852         https://bugs.webkit.org/show_bug.cgi?id=208894
853         <rdar://problem/60297590>
854
855         Reviewed by Brent Fulgham.
856
857         This project provided support for facilities that are now handled
858         elsewhere and is no longer needed.
859
860         * Scripts/copy-webkitlibraries-to-product-directory:
861
862 2020-03-16  Per Arne Vollan  <pvollan@apple.com>
863
864         [macOS] Accessibility sandbox regressions
865         https://bugs.webkit.org/show_bug.cgi?id=209065
866
867         Reviewed by Brent Fulgham.
868
869         * TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm:
870         (TEST):
871         * TestWebKitAPI/Tests/WebKit/GrantAccessToPreferencesService.mm:
872         (TEST):
873
874 2020-03-16  Ryan Haddad  <ryanhaddad@apple.com>
875
876         Unreviewed infrastructure fix.
877
878         * BuildSlaveSupport/ews-build/config.json: Temporarily remove ews114
879         while the hardware is out for repair.
880
881 2020-03-13  Sergio Villar Senin  <svillar@igalia.com>
882
883         [WebXR] IDLs, stubs and build configuration for WPE
884         https://bugs.webkit.org/show_bug.cgi?id=208702
885
886         Reviewed by Dean Jackson.
887
888         * Scripts/webkitperl/FeatureList.pm: Added WebXR.
889         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Added ENABLE_WEBXR, off by default.
890
891 2020-03-16  Per Arne Vollan  <pvollan@apple.com>
892
893         [Cocoa] Limit set of classes that can be decoded when a preference has changed
894         https://bugs.webkit.org/show_bug.cgi?id=208012
895
896         Reviewed by Brent Fulgham.
897
898         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm:
899         (TEST):
900
901 2020-03-16  youenn fablet  <youenn@apple.com>
902
903         Unique origins should not be Potentially Trustworthy
904         https://bugs.webkit.org/show_bug.cgi?id=209049
905
906         Reviewed by Darin Adler.
907
908         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
909         (TestWebKitAPI::TEST_F):
910
911 2020-03-15  Fujii Hironori  <Hironori.Fujii@sony.com>
912
913         KeyedDecoderGeneric fails to allocate Vector while decoding broken data
914         https://bugs.webkit.org/show_bug.cgi?id=207324
915
916         Reviewed by Darin Adler.
917
918         * TestWebKitAPI/Tests/WebCore/KeyedCoding.cpp:
919         (TestWebKitAPI::generateRandomData): Added.
920         (TestWebKitAPI::KeyedCoding.DecodeRandomData): Added a new test decoding random data.
921
922 2020-03-15  Yusuke Suzuki  <ysuzuki@apple.com>
923
924         Should not use variable-length-array (VLA)
925         https://bugs.webkit.org/show_bug.cgi?id=209043
926
927         Reviewed by Mark Lam.
928
929         * ContentExtensionTester/Configurations/Base.xcconfig:
930         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
931
932 2020-03-13  Alex Christensen  <achristensen@webkit.org>
933
934         WKWebView._negotiatedLegacyTLS should be correct after back/forward navigations
935         https://bugs.webkit.org/show_bug.cgi?id=209011
936         <rdar://problem/59370588>
937
938         Reviewed by Youenn Fablet.
939
940         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
941         (TestWebKitAPI::TEST):
942
943 2020-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
944
945         [watchOS] Don’t display empty text suggestions in Quickboard when editing input fields
946         https://bugs.webkit.org/show_bug.cgi?id=209089
947
948         Reviewed by Tim Horton.
949
950         Add an API test for watchOS. Also rename a few occurrences of "Autofill" to "AutoFill", to reflect the official
951         marketing name for the feature.
952
953         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
954         (runUntilReceivesAutoplayEvent):
955
956         Additionally fix the watchOS engineering build for arm64_32, which was failing due to comparisons between 64-bit
957         and 32-bit integers. This is because this function took a `WKAutoplayEvent` (a 32-bit integer), but compared
958         against the `_WKAutoplayEvent` type (an NSInteger that is 64 bits on this architecture). There didn't seem to
959         be any compelling reason to compare against different types here (especially since we only set
960         `receivedAutoplayEvent` under the Objective-C delegate method that provides a `_WKAutoplayEvent`), so I changed
961         these all to be `_WKAutoplayEvent`.
962
963         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
964         (-[AutoFillTestView _autofillInputView]):
965         (-[AutoFillTestView textInputHasAutoFillContext]):
966         (TestWebKitAPI::TEST):
967         (-[AutofillTestView initWithFrame:]): Deleted.
968         (-[AutofillTestView _autofillInputView]): Deleted.
969         (-[AutofillTestView textInputHasAutofillContext]): Deleted.
970         * TestWebKitAPI/ios/UIKitSPI.h:
971
972 2020-03-13  Chris Dumez  <cdumez@apple.com>
973
974         Unreviewed, reverting r256232.
975
976         Caused ResizeObserver tests to become flaky
977
978         Reverted changeset:
979
980         "[DRT] InternalSettingsGenerated::resetToConsistentState() may
981         override TestOptions"
982         https://bugs.webkit.org/show_bug.cgi?id=207481
983         https://trac.webkit.org/changeset/256232
984
985 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
986
987         [ iOS and Mac wk2 ] http/tests/in-app-browser-privacy/ tests failing
988         https://bugs.webkit.org/show_bug.cgi?id=209016
989         <rdar://problem/60329530> 
990
991         Reviewed by Chris Dumez.
992
993         Re-initialize the app-bound domains when the correct
994         TestOptions parameter is set.
995
996         * WebKitTestRunner/TestController.cpp:
997         (WTR::TestController::createWebViewWithOptions):
998         (WTR::TestController::reinitializeAppBoundDomains):
999         * WebKitTestRunner/TestController.h:
1000
1001 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
1002
1003         Report all third party loads on a per-page basis
1004         https://bugs.webkit.org/show_bug.cgi?id=209032
1005         <rdar://problem/60397323>
1006
1007         Reviewed by Chris Dumez.
1008
1009         Mostly naming updates to reflect the change in use for this SPI call.
1010         It now returns all loaded third party domains, not just prevalent ones.
1011
1012         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1013         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1014         (WTR::InjectedBundle::didReceiveMessageToPage):
1015         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1016         (WTR::TestRunner::getLoadedThirdPartyDomains):
1017         (WTR::TestRunner::callDidReceiveLoadedThirdPartyDomainsCallback):
1018         (WTR::TestRunner::getPrevalentDomains): Deleted.
1019         (WTR::TestRunner::callDidReceivePrevalentDomainsCallback): Deleted.
1020         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1021         * WebKitTestRunner/TestController.cpp:
1022         (WTR::TestController::resetStateToConsistentValues):
1023         (WTR::TestController::getLoadedThirdPartyDomains):
1024         (WTR::TestController::clearLoadedThirdPartyDomains):
1025         (WTR::TestController::getPrevalentDomains): Deleted.
1026         (WTR::TestController::clearPrevalentDomains): Deleted.
1027         * WebKitTestRunner/TestController.h:
1028         * WebKitTestRunner/TestInvocation.cpp:
1029         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1030         (WTR::TestInvocation::didReceiveLoadedThirdPartyDomains):
1031         (WTR::TestInvocation::didReceivePrevalentDomains): Deleted.
1032         * WebKitTestRunner/TestInvocation.h:
1033         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1034         (WTR::TestController::getLoadedThirdPartyDomains):
1035         (WTR::TestController::clearLoadedThirdPartyDomains):
1036         (WTR::TestController::getPrevalentDomains): Deleted.
1037         (WTR::TestController::clearPrevalentDomains): Deleted.
1038
1039 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
1040
1041         [ews] run FindModifiedChangeLogs early in the build
1042         https://bugs.webkit.org/show_bug.cgi?id=209060
1043
1044         Reviewed by Jonathan Bedard.
1045
1046         * BuildSlaveSupport/ews-build/factories.py:
1047         * BuildSlaveSupport/ews-build/factories_unittest.py: Updated unit-test.
1048
1049 2020-03-13  Diego Pino Garcia  <dpino@igalia.com>
1050
1051         [GTK] Add EWS testers to run GTK layout tests
1052         https://bugs.webkit.org/show_bug.cgi?id=207648
1053
1054         Reviewed by Carlos Alberto Lopez Perez and Aakash Jain.
1055
1056         Queue 'GTK-Webkit2-EWS' was renamed to 'GTK-Build-EWS'.
1057         A new queue, named 'GTK-WK2-Tests-EWS', was added for WK2
1058         tests (layout tests).
1059
1060         * BuildSlaveSupport/ews-build/config.json: Added new queue for
1061         WK2 tests.
1062         * BuildSlaveSupport/ews-build/factories.py:
1063         (GTKTestsFactory):
1064         * BuildSlaveSupport/ews-build/factories_unittest.py:
1065         (TestCommitQueueFactory.test_commit_queue_factory):
1066         (TestGTKFactory): Added unit-test.
1067         (TestGTKFactory.test_gtk_factory):
1068         * BuildSlaveSupport/ews-build/loadConfig.py:
1069         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1070         (TagsForBuilderTest.test_getTagsForBuilder):
1071
1072 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
1073
1074         Add API endpoint in EWS django app to provide patch status in json format
1075         https://bugs.webkit.org/show_bug.cgi?id=208940
1076
1077         Reviewed by Jonathan Bedard.
1078
1079         * BuildSlaveSupport/ews-app/ews/urls.py: Added url for new api endpoint.
1080         * BuildSlaveSupport/ews-app/ews/views/status.py: Added.
1081
1082 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
1083
1084         WebKit2UseRemoteLayerTreeDrawingArea should be reset to NO between layout tests
1085         https://bugs.webkit.org/show_bug.cgi?id=209055
1086         <rdar://problem/60272692>
1087
1088         Reviewed by Simon Fraser.
1089
1090         Now that WebKitTestRunner has a bundleID, its' user default values
1091         persist between tests. This patch resets WebKit2UseRemoteLayerTreeDrawingArea
1092         to NO before running tests. It will be set to YES in PlatformWebView
1093         if specified by the test.
1094
1095         * WebKitTestRunner/mac/main.mm:
1096         (setDefaultsToConsistentValuesForTesting):
1097
1098 2020-03-13  Konstantin Tokarev  <annulen@yandex.ru>
1099
1100         [CMake] Eleminate mismatches between Find* module names and variables they set
1101         https://bugs.webkit.org/show_bug.cgi?id=208948
1102
1103         Reviewed by Michael Catanzaro.
1104
1105         * wpe/backends/CMakeLists.txt:
1106
1107 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
1108
1109         [ews-app] reduce logging
1110         https://bugs.webkit.org/show_bug.cgi?id=209062
1111
1112         Reviewed by Jonathan Bedard.
1113
1114         * BuildSlaveSupport/ews-app/ews/common/bugzilla.py:
1115         (BugzillaBeautifulSoup.authenticate):
1116         (BugzillaBeautifulSoup._load_query):
1117
1118 2020-03-13  Ryosuke Niwa  <rniwa@webkit.org>
1119
1120         Crash in TextIterator::node via TextManipulationController::replace
1121         https://bugs.webkit.org/show_bug.cgi?id=209048
1122
1123         Reviewed by Wenson Hsieh.
1124
1125         Added a regression test.
1126
1127         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1128         (TextManipulation.CompleteTextManipulationShouldReplaceContentsAroundParagraphWithJustImage):
1129
1130 2020-03-13  Saam Barati  <sbarati@apple.com>
1131
1132         Pull in JS tests from "Internal" when there are "Internal" tests in an adjacent directory
1133         https://bugs.webkit.org/show_bug.cgi?id=209038
1134
1135         Reviewed by Keith Miller.
1136
1137         This allows us to automatically pull in some tests that are in non open sourced Apple
1138         checkouts.
1139
1140         * Scripts/run-javascriptcore-tests:
1141         (runJSCStressTests):
1142
1143 2020-03-12  Ryosuke Niwa  <rniwa@webkit.org>
1144
1145         Crash in TextManipulationController::replace
1146         https://bugs.webkit.org/show_bug.cgi?id=209021
1147
1148         Reviewed by Wenson Hsieh.
1149
1150         Added a regression test.
1151
1152         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1153         (TextManipulation.CompleteTextManipulationShouldReplaceContentFollowedAfterImageInCSSTable):
1154
1155 2020-03-12  Per Arne Vollan  <pvollan@apple.com>
1156
1157         [macOS] _AXSApplicationAccessibilityEnabled should not be called
1158         https://bugs.webkit.org/show_bug.cgi?id=208953
1159
1160         Reviewed by Brent Fulgham.
1161
1162         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1163
1164 2020-03-12  Kate Cheney  <katherine_cheney@apple.com>
1165
1166         Resource load statistics data summary should return all third party data
1167         https://bugs.webkit.org/show_bug.cgi?id=209000
1168         <rdar://problem/60348306>
1169
1170         Reviewed by John Wilander.
1171
1172         Marked only 2 of 3 domains prevalent in data summary tests to ensure
1173         the call returns all third parties, not just prevalent ones.
1174         Added a more aggressive check for the size of the array at the
1175         beginning of the test to ensure the array is still returning 3 values. 
1176         Also removed the ASSERT statements as they seem to cause timeouts (not
1177         clear crashes) when they are not true, which is hard to debug.
1178         If these values are nil, the test will fail in the EXPECT_WK_STREQ
1179         checks, we don't need ASSERT statements.
1180
1181         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1182         (TEST):
1183
1184 2020-03-12  Jonathan Bedard  <jbedard@apple.com>
1185
1186         resultsdpy: Add script to run local instance
1187         https://bugs.webkit.org/show_bug.cgi?id=208746
1188
1189         Rubber-stamped by Aakash Jain.
1190
1191         * resultsdbpy/resultsdbpy/example: Added.
1192         * resultsdbpy/resultsdbpy/example/__init__.py: Added.
1193         * resultsdbpy/resultsdbpy/example/environment.py: Added.
1194         (Environment): Organize environment variables used by results database.
1195         (ModelFromEnvironment): Construct the database model from the environment.
1196         (main): Create and drop tables, if required.
1197         * resultsdbpy/resultsdbpy/example/main.py: Added.
1198         (health): Web-server health check.
1199         (handle_errors):
1200         (main): Run results database web-server.
1201         * resultsdbpy/resultsdbpy/example/worker.py: Added.
1202         (main): Asynchronously process uploaded results.
1203         * resultsdbpy/resultsdbpy/run: Added.
1204
1205 2020-03-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1206
1207         run-webkit-tests --use-gpu-process should enable GPU Process for canvas
1208         https://bugs.webkit.org/show_bug.cgi?id=209004
1209
1210         Reviewed by Tim Horton.
1211
1212         Add "RenderCanvasInGPUProcessEnabled" to the list of internal features that should be enabled when
1213         `use_gpu_process` is specified.
1214
1215         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1216         (parse_args):
1217
1218 2020-03-12  Matt Lewis  <jlewis3@apple.com>
1219
1220         Make flatpack import for run-webkit-tests only happen on linux systems
1221         https://bugs.webkit.org/show_bug.cgi?id=208954
1222
1223         Reviewed by Philippe Normand.
1224
1225         * Scripts/run-webkit-tests: Added an if statement to find the system platform
1226         to determine if we need the flatpackutils import. 
1227
1228 2020-03-12  Alex Christensen  <achristensen@webkit.org>
1229
1230         WKWebView.hasOnlySecureContent should be correct after back/forward navigations
1231         https://bugs.webkit.org/show_bug.cgi?id=207609
1232
1233         Reviewed by Ryosuke Niwa.
1234
1235         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
1236         (TestWebKitAPI::TEST):
1237
1238 2020-03-12  Daniel Bates  <dabates@apple.com>
1239
1240         FocusController::setFocusedElement() should tell client of refocused element
1241         https://bugs.webkit.org/show_bug.cgi?id=208880
1242
1243         Reviewed by Wenson Hsieh.
1244
1245         Adds a test to ensure that calling -selectPositionAtPoint on an already focused element tries
1246         to start an input session. Currently, it does not even try.
1247
1248         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
1249         (TEST):
1250
1251 2020-03-12  Michael Catanzaro  <mcatanzaro@gnome.org>
1252
1253         [GTK] Use #!/usr/bin/python3 shebang to run generate-gtkdoc
1254         https://bugs.webkit.org/show_bug.cgi?id=208970
1255
1256         Reviewed by Daniel Bates.
1257
1258         Fedora and Ubuntu are both patching generate-gtkdoc to use #!/usr/bin/python3 rather than
1259         #!/usr/bin/env python.
1260
1261         #!/usr/bin/env and /usr/bin/python are both banned in Fedora packages. I guess Ubuntu
1262         probably has similar rules.
1263
1264         Note this is the only script that attempts to use /usr/bin/python in tarball builds.
1265         Everything else that does so is probably only used by webkit-build.
1266
1267         https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_multiple_python_runtimes
1268
1269         * gtkdoc/generate-gtkdoc:
1270
1271 2020-03-11  Jiewen Tan  <jiewen_tan@apple.com>
1272
1273         [WebAuthn] Formalize the Keychain schema
1274         https://bugs.webkit.org/show_bug.cgi?id=183533
1275         <rdar://problem/43347926>
1276
1277         Reviewed by Brent Fulgham.
1278
1279         Modifies the test infra to use Credential ID as the unique identifier for a credential instead of
1280         the original combination of RP ID and user handle.
1281
1282         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1283         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1284         (WTR::TestRunner::cleanUpKeychain):
1285         (WTR::TestRunner::keyExistsInKeychain):
1286         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1287         * WebKitTestRunner/TestController.h:
1288         * WebKitTestRunner/TestInvocation.cpp:
1289         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1290         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1291         (WTR::TestController::cleanUpKeychain):
1292         (WTR::TestController::keyExistsInKeychain):
1293
1294 2020-03-11  Keith Miller  <keith_miller@apple.com>
1295
1296         Test262-runner should always consider crashes as new failures
1297         https://bugs.webkit.org/show_bug.cgi?id=208943
1298
1299         Reviewed by Yusuke Suzuki.
1300
1301         Right now the runner will consider crashes with no output as passes, which is obviously bad.
1302         Since we should never crash on a conformance test we should consider a crash as a new failure
1303         100% of the time.
1304
1305         * Scripts/test262/Runner.pm:
1306         (processFile):
1307         (runTest):
1308         (processResult):
1309
1310 2020-03-11  Chris Dumez  <cdumez@apple.com>
1311
1312         Assertion hit under WebPageProxy::suspendCurrentPageIfPossible() when bypassing certificate warning page
1313         https://bugs.webkit.org/show_bug.cgi?id=208927
1314         <rdar://problem/55448331>
1315
1316         Reviewed by Alex Christensen.
1317
1318         Add API test coverage.
1319
1320         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1321
1322 2020-03-11  Diego Pino Garcia  <dpino@igalia.com>
1323
1324         [GTK] Switch EWS api-gtk bot from buildAndTest to testOnly
1325         https://bugs.webkit.org/show_bug.cgi?id=208860
1326
1327         Reviewed by Carlos Alberto Lopez Perez.
1328
1329         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1330         (StatusBubble): Added 'api-gtk'.
1331         * BuildSlaveSupport/ews-build/config.json:
1332         * BuildSlaveSupport/ews-build/factories.py:
1333         (BuildFactory.__init__): Call InstallGTKDependencies() if platform is
1334         GTK.
1335         (TestFactory.__init__): Call InstallGTKDependencies() if platform is
1336         GTK.
1337         (GTKBuildFactory):
1338         (GTKBuildFactory.__init__): Deleted.
1339         (GTKBuildAndTestFactory): Deleted.
1340         (GTKBuildAndTestFactory.__init__): Deleted.
1341         (GTKAPIBuildAndTestFactory): Deleted.
1342         * BuildSlaveSupport/ews-build/loadConfig.py:
1343
1344 2020-03-11  Aakash Jain  <aakash_jain@apple.com>
1345
1346         [ews] Add unit test to prevent multiple schedulers for a builder.
1347         https://bugs.webkit.org/show_bug.cgi?id=208917
1348
1349         Reviewed by Carlos Alberto Lopez Perez.
1350
1351         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1352         (ConfigDotJSONTest.test_multiple_scheduers_for_builder): Added unit test.
1353         (TagsForBuilderTest): Fixed a typo.
1354
1355 2020-03-11 Philippe Normand  <pnormand@igalia.com>
1356
1357         [GTK] Failing API tests under the Flatpak SDK environment
1358         https://bugs.webkit.org/show_bug.cgi?id=208871
1359
1360         Reviewed by Michael Catanzaro.
1361
1362         The load-failed signal callback should return a boolean result,
1363         otherwise we enter in unknown territory depending on how the
1364         toolchain compiles this, possibly triggering bad behavior (with
1365         GCC 9.2 from the Flatpak SDK) or not caring at all (with current
1366         GCC toolchain on buildbots).
1367
1368         Patch suggested by Michael Catanzaro.
1369
1370         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
1371         (loadFailedCallback):
1372
1373 2020-03-10  Don Olmstead  <don.olmstead@sony.com>
1374
1375         Sync FeatureList.pm with CMake definitions
1376         https://bugs.webkit.org/show_bug.cgi?id=208866
1377
1378         Reviewed by Michael Catanzaro.
1379
1380         * Scripts/webkitperl/FeatureList.pm:
1381
1382 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
1383
1384         [ews] Add unit tests for commit queue factory
1385         https://bugs.webkit.org/show_bug.cgi?id=208862
1386
1387         Reviewed by Jonathan Bedard.
1388
1389         * BuildSlaveSupport/ews-build/factories_unittest.py:
1390         (TestCommitQueueFactory):
1391         (TestCommitQueueFactory.test_commit_queue_factory): Added unit-test for commit-queue factory.
1392
1393 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
1394
1395         [ews-app] Status bubble should only display important messages in pop-over - part 3
1396         https://bugs.webkit.org/show_bug.cgi?id=208865
1397
1398         Reviewed by Jonathan Bedard.
1399
1400         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1401         (StatusBubble): Added more strings to STEPS_TO_HIDE.
1402
1403 2020-03-10  Lauro Moura  <lmoura@igalia.com>
1404
1405         [WPE] MiniBrowser: Close child WebViews when exiting
1406         https://bugs.webkit.org/show_bug.cgi?id=208689
1407
1408         Reviewed by Carlos Garcia Campos.
1409
1410         Store created views so we can release them before exiting.
1411
1412         * MiniBrowser/wpe/main.cpp:
1413         (webViewClose):
1414         (createWebView):
1415         (main):
1416
1417 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
1418
1419         Add ValidateCommiterAndReviewer and ValidateChangeLogAndReviewer build steps in commit-queue
1420         https://bugs.webkit.org/show_bug.cgi?id=208861
1421
1422         Reviewed by Jonathan Bedard.
1423
1424         * BuildSlaveSupport/ews-build/factories.py:
1425         (Factory.__init__): Remove verifycqplus parameter.
1426         (CommitQueueFactory): Inherit from factory.BuildFactory base class instead of custom Factory class.
1427         (CommitQueueFactory.__init__): Add required build steps, especially ValidateCommiterAndReviewer, 
1428         UpdateWorkingDirectory and ValidateChangeLogAndReviewer.
1429
1430 2020-03-10  Philippe Normand  <pnormand@igalia.com>
1431
1432         [GTK] API favicon test flaky timeouts
1433         https://bugs.webkit.org/show_bug.cgi?id=208189
1434
1435         Reviewed by Carlos Garcia Campos.
1436
1437         Sometimes the favicon changes already during the load. Keeping
1438         track of it in the WebView favicon property notification handler
1439         gets us rid of the race.
1440
1441         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
1442         (testFaviconDatabaseGetFavicon):
1443
1444 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
1445
1446         Generate commit-queue status bubble from new EWS
1447         https://bugs.webkit.org/show_bug.cgi?id=208811
1448
1449         Reviewed by Jonathan Bedard.
1450
1451         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1452         (StatusBubble._build_bubbles_for_patch):
1453
1454 2020-03-09  Don Olmstead  <don.olmstead@sony.com>
1455
1456         Remove obsolete feature flags
1457         https://bugs.webkit.org/show_bug.cgi?id=208830
1458
1459         Reviewed by Alex Christensen.
1460
1461         Remove ENABLE_CUSTOM_SCHEME_HANDLER and ENABLE_MAC_VIDEO_TOOLBOX since they
1462         are no longer used.
1463
1464         Also remove ENABLE_POINTER_EVENTS since the FeaturesDefines.xcconfig was not modified
1465         when the compilation flag was removed in r258148.
1466
1467         Remove ENABLE_ACCELERATED_OVERFLOW_SCROLLING, ENABLE_CSS_IMAGE_ORIENTATION,
1468         ENABLE_CUSTOM_SCHEME_HANDLER, and ENABLE_FETCH_API from FeatureList.pm.
1469
1470         * Scripts/webkitperl/FeatureList.pm:
1471         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1472
1473 2020-03-09  Kate Cheney  <katherine_cheney@apple.com>
1474
1475         WebKitTestRunner bundleID should not be cleared before every test
1476         https://bugs.webkit.org/show_bug.cgi?id=208823
1477         <rdar://problem/60204539>
1478
1479         Reviewed by Per Arne Vollan.
1480
1481         This is causing test failures for layout tests which rely on the Info.plist 
1482         bundle identifier (not the one set via the override method).
1483
1484         * WebKitTestRunner/TestController.cpp:
1485         (WTR::TestController::createWebViewWithOptions):
1486         (WTR::TestController::ensureViewSupportsOptionsForTest):
1487         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1488
1489 2020-03-09  Per Arne Vollan  <pvollan@apple.com>
1490
1491         [macOS] Notification observer is not removed
1492         https://bugs.webkit.org/show_bug.cgi?id=208834
1493
1494         Reviewed by Tim Horton.
1495
1496         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1497         * TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm: Added.
1498         (TEST):
1499
1500 2020-03-06  Brian Burg  <bburg@apple.com>
1501
1502         upload.py gets confused by git-svn checkouts, unable to upload test results from my desk build
1503         https://bugs.webkit.org/show_bug.cgi?id=208729
1504         <rdar://problem/60105447>
1505
1506         Reviewed by Jonathan Bedard.
1507
1508         Improve upload.py to look for the svn branch and revision for the 'webkit'
1509         project and prefer those to the git equivalents (eg, prefer trunk/rNNNNN to master/<hash>).
1510
1511         * Scripts/webkitpy/common/checkout/scm/git.py:
1512         (Git):
1513         (Git.git_svn_id_regexp):
1514         (Git._field_from_git_svn_id):
1515         (Git.svn_revision):
1516         (Git.svn_branch):
1517         (Git.svn_url):
1518         (Git.native_branch):
1519         Refactor svn revision, branch, url to use the same regexp and helper code.
1520
1521         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
1522         (StubRepository.svn_branch):
1523         Expose a stub since this is used unconditionally by Port.commits_for_upload.
1524
1525         * Scripts/webkitpy/common/checkout/scm/svn.py:
1526         (SVN.svn_branch):
1527         (SVN.native_revision):
1528         (SVN):
1529         (SVN.native_branch):
1530         Refactor so the actual implementation is contained in svn_revision / svn_branch.
1531         The native_* methods call out to the SVN equivalents since this is an SVN repository.
1532
1533         * Scripts/webkitpy/port/base.py:
1534         (Port.commits_for_upload):
1535         Add special git-svn handling for the WebKit repository so that SVN branch and revision
1536         is preferred over the git equivalents.
1537
1538 2020-03-09  Antoine Quint  <graouts@apple.com>
1539
1540         TestWebKitAPI fails to build on watchOS
1541         https://bugs.webkit.org/show_bug.cgi?id=208820
1542
1543         Reviewed by Tim Horton.
1544
1545         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
1546
1547 2020-03-09  Jonathan Bedard  <jbedard@apple.com>
1548
1549         resultsdbpy: Add tool to manage resultsdbpy container
1550         https://bugs.webkit.org/show_bug.cgi?id=208743
1551
1552         Rubber-stamped by Aakash Jain.
1553
1554         Add tool to start, stop and restart the resultsdbpy Docker container.
1555
1556         * resultsdbpy/resultsdbpy/container: Added.
1557
1558 2020-03-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1559
1560         [GTK][WPE] Surrounding text for input methods should not be limited to the current paragraph
1561         https://bugs.webkit.org/show_bug.cgi?id=208706
1562
1563         Reviewed by Žan Doberšek.
1564
1565         Add test case to check surrounding text in multiline context.
1566
1567         * TestWebKitAPI/Tests/WebKitGLib/TestInputMethodContext.cpp:
1568         (testWebKitInputMethodContextSurrounding):
1569
1570 2020-03-08  Per Arne Vollan  <pvollan@apple.com>
1571
1572         [iOS] Mapping to UTI from tag and tag class should be performed in the UI process
1573         https://bugs.webkit.org/show_bug.cgi?id=208783
1574
1575         Reviewed by Brent Fulgham.
1576
1577         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1578
1579 2020-03-07  Ross Kirsling  <ross.kirsling@sony.com>
1580
1581         Replace the use of term "rollout" to "revert" in various tools
1582         https://bugs.webkit.org/show_bug.cgi?id=208775
1583
1584         Reviewed by Ryosuke Niwa.
1585
1586         See this webkit-dev thread for the originating discussion:
1587         https://lists.webkit.org/pipermail/webkit-dev/2020-March/031132.html
1588
1589         'rollout' is a confusing term to anyone unacquainted with WebKit;
1590         consensus seems to be that 'revert' would be the best replacement (as opposed to 'rollback').
1591
1592         Given the long legacy of this term within WebKit, it's important to deprecate and not remove 'rollout' commands.
1593         As such, this patch aims to make 'revert' the preferred term everywhere without making 'rollout' fail.
1594
1595         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js:
1596         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1597         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1598         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
1599         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/trac_unittests.js:
1600         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1601         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
1602         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
1603         * BuildSlaveSupport/ews-build/steps.py:
1604         * BuildSlaveSupport/ews-build/steps_unittest.py:
1605         * Scripts/webkit-tools-completion.sh:
1606         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1607         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1608         * Scripts/webkitpy/common/checkout/scm/svn.py:
1609         * Scripts/webkitpy/common/net/bugzilla/attachment.py:
1610         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1611         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1612         * Scripts/webkitpy/tool/bot/feeders.py:
1613         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1614         * Scripts/webkitpy/tool/bot/irc_command.py:
1615         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1616         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1617         * Scripts/webkitpy/tool/bot/sheriff.py:
1618         * Scripts/webkitpy/tool/commands/download.py:
1619         * Scripts/webkitpy/tool/commands/download_unittest.py:
1620         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1621         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
1622         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1623         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1624         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1625         * Scripts/webkitpy/tool/steps/__init__.py:
1626         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
1627         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1628         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
1629         * Scripts/webkitpy/tool/steps/reopenbugafterrevert.py: Renamed from Tools/Scripts/webkitpy/tool/steps/reopenbugafterrollout.py.
1630
1631 2020-03-07  David Quesada  <david_quesada@apple.com>
1632
1633         Crash in -[_WKRemoteObjectRegistry _invokeMethod:] block when calling a reply block after the web view has deallocated
1634         https://bugs.webkit.org/show_bug.cgi?id=208781
1635         rdar://problem/60061016
1636
1637         Reviewed by Alex Christensen.
1638
1639         Add a test that recreates the conditions of this crash:
1640         - Send a message from the injected bundle to the UI process that contains a reply block.
1641         - Hold a reference to the reply block.
1642         - Let the web view deallocate.
1643         - Call the block, and expect not to crash.
1644
1645         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
1646         (localObjectInterface):
1647         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
1648         (-[LocalObject doSomethingWithCompletionHandler:]):
1649         (TEST):
1650         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
1651         (-[RemoteObjectRegistryPlugIn callUIProcessMethodWithReplyBlock]):
1652
1653 2020-03-07  Ryosuke Niwa  <rniwa@webkit.org>
1654
1655         TextManipulationController should work with ARIA labels
1656         https://bugs.webkit.org/show_bug.cgi?id=208759
1657
1658         Reviewed by Wenson Hsieh.
1659
1660         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1661         (TextManipulation.StartTextManipulationFindAttributeContent): Added.
1662         (TextManipulation.CompleteTextManipulationShouldPreserveOrderOfBlockImage): Updated
1663         the expected number of tokens for the first item as the very first image is correctly
1664         detected per the code change. 
1665         (TextManipulation.CompleteTextManipulationShouldReplaceAttributeContent): Added.
1666
1667 2020-03-07  Alex Christensen  <achristensen@webkit.org>
1668
1669         Regression r258042: Failing API test TestWebKitAPI.URLSchemeHandler.Frames
1670         https://bugs.webkit.org/show_bug.cgi?id=208767
1671
1672         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1673         The frameID of the main frame before loading is only 0 on Mac right now.
1674         The test is still good because it validates that execution works in the main frame before loading.
1675
1676 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
1677
1678         [ews] commit queue is not skipping layout tests for rollout patches
1679         https://bugs.webkit.org/show_bug.cgi?id=208716
1680
1681         Unreviewed minor fix.
1682
1683         * BuildSlaveSupport/ews-build/steps.py:
1684         (RunWebKitTests.doStepIf):
1685         (RunWebKit1Tests.doStepIf): Moved to base class RunWebKitTests.
1686         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
1687
1688 2020-03-05  Sam Weinig  <weinig@apple.com>
1689
1690         Move JavaScriptCore related feature defines from FeatureDefines.xcconfig to PlatformEnableCocoa.h
1691         https://bugs.webkit.org/show_bug.cgi?id=207436
1692         <rdar://problem/59296762>
1693
1694         Reviewed by Darin Adler.
1695
1696         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1697         Remove JSC related defines.
1698
1699 2020-03-07  Chris Fleizach  <cfleizach@apple.com>
1700
1701         AX: Provide a way to run tests in isolated tree mode
1702         https://bugs.webkit.org/show_bug.cgi?id=208629
1703         <rdar://problem/60075583>
1704
1705         Reviewed by Ryosuke Niwa.
1706
1707         Provide the ability to run tests for accessibility in the isolated tree mode.
1708         This sends a flag over to the injected bundle which calls the right HIServices override so that
1709         the system thinks it is in isolated mode.
1710
1711         * Scripts/compare-webkit-configurations:
1712         (flag_for_comparison):
1713         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1714         (parse_args):
1715         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1716         (parse_args):
1717         * Scripts/webkitpy/port/driver.py:
1718         (Driver.cmd_line):
1719         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1720         (WTR::AccessibilityController::AccessibilityController):
1721         (WTR::AccessibilityController::setAccessibilityIsolatedTreeMode):
1722         (WTR::AccessibilityController::updateIsolatedTreeMode):
1723         (WTR::AccessibilityController::executeOnAXThreadIfPossible):
1724         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
1725         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1726         (WTR::InjectedBundle::didReceiveMessageToPage):
1727         (WTR::InjectedBundle::beginTesting):
1728         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1729         * WebKitTestRunner/Options.cpp:
1730         (WTR::handleOptionAccessibilityIsolatedTreeMode):
1731         (WTR::OptionsHandler::OptionsHandler):
1732         * WebKitTestRunner/Options.h:
1733         * WebKitTestRunner/TestController.cpp:
1734         (WTR::TestController::initialize):
1735         (WTR::TestController::resetPreferencesToConsistentValues):
1736         (WTR::TestController::resetStateToConsistentValues):
1737         * WebKitTestRunner/TestController.h:
1738         (WTR::TestController::accessibilityIsolatedTreeMode const):
1739
1740 2020-03-06  Per Arne Vollan  <pvollan@apple.com>
1741
1742         [Cocoa] Re-enable CFPrefs direct mode
1743         https://bugs.webkit.org/show_bug.cgi?id=208690
1744
1745         Reviewed by Brent Fulgham.
1746
1747         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1748         * TestWebKitAPI/Tests/WebKit/GrantAccessToPreferencesService.mm: Added.
1749         (TEST):
1750         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
1751         (TestWebKitAPI::TEST):
1752
1753 2020-03-06  Kate Cheney  <katherine_cheney@apple.com>
1754
1755         UIProcess needs mechanism to specify AppBound domains
1756         https://bugs.webkit.org/show_bug.cgi?id=208528
1757         <rdar://problem/59980340>
1758
1759         Reviewed by Brent Fulgham.
1760
1761         Added test app-bound domains to the plist and tested that the domains
1762         are properly stored in the website data store after a navigation.
1763
1764         * TestWebKitAPI/Info.plist:
1765         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
1766         (TEST):
1767
1768 2020-03-06  Alex Christensen  <achristensen@webkit.org>
1769
1770         Add SPI to disable cross origin access control checks
1771         https://bugs.webkit.org/show_bug.cgi?id=208748
1772
1773         Reviewed by Tim Hatcher.
1774
1775         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1776         Add a test that verifies this SPI allows Access-Control-Allow-Origin: * with credentials.
1777
1778 2020-03-06  Basuke Suzuki  <basuke.suzuki@sony.com>
1779
1780         [webkitpy] Fix executive on Windows to run wpt server correctly
1781         https://bugs.webkit.org/show_bug.cgi?id=208693
1782
1783         Reviewed by Jonathan Bedard.
1784
1785         Bug fix for Windows environment a) fixing a typo. b) fixing path
1786         c) fix how to kill subprocesses.
1787
1788         * Scripts/webkitpy/common/system/executive.py:
1789         (Executive._windows_kill_command):
1790         (Executive.interrupt):
1791         (Executive.kill_all):
1792         * Scripts/webkitpy/port/base.py:
1793         (Port.web_platform_test_server_doc_root):
1794
1795 2020-03-06  Alex Christensen  <achristensen@webkit.org>
1796
1797         Evaluating JavaScript in main frame before loading should succeed
1798         https://bugs.webkit.org/show_bug.cgi?id=208733
1799
1800         Reviewed by Tim Horton.
1801
1802         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1803
1804 2020-03-06  Ryosuke Niwa  <rniwa@webkit.org>
1805
1806         TextManipulationController should preserve images
1807         https://bugs.webkit.org/show_bug.cgi?id=208692
1808
1809         Reviewed by Wenson Hsieh.
1810
1811         Added tests for preserving images and their ordering.
1812
1813         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1814         (TextManipulation.CompleteTextManipulationShouldPreserveImagesAsExcludedTokens):
1815         (TextManipulation.CompleteTextManipulationShouldPreserveSVGAsExcludedTokens):
1816         (TextManipulation.CompleteTextManipulationShouldPreserveOrderOfBlockImage):
1817
1818 2020-03-06  David Quesada  <david_quesada@apple.com>
1819
1820         Add _WKResourceLoadInfo.resourceType SPI
1821         https://bugs.webkit.org/show_bug.cgi?id=208723
1822
1823         Reviewed by Alex Christensen.
1824
1825         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
1826         (TEST):
1827
1828 2020-03-06  Jonathan Bedard  <jbedard@apple.com>
1829
1830         Stop reporting to webkit-test-results.webkit.org
1831         https://bugs.webkit.org/show_bug.cgi?id=207218
1832
1833         Reviewed by Alexey Proskuryakov.
1834
1835         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1836         (RunWebKitTests):
1837
1838 2020-03-06  Sihui Liu  <sihui_liu@apple.com>
1839
1840         UIProcess crash after using _prepareForMoveToWindow, then deallocating the WKWebView before moving to the window
1841         https://bugs.webkit.org/show_bug.cgi?id=208365
1842         <rdar://problem/59877296>
1843
1844         Reviewed by Geoffrey Garen.
1845
1846         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
1847         (TEST):
1848
1849 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
1850
1851         EWS should be able to fetch patch status for security bugs while processing them
1852         https://bugs.webkit.org/show_bug.cgi?id=206511
1853
1854         Reviewed by Alexey Proskuryakov.
1855
1856         * BuildSlaveSupport/ews-build/steps.py:
1857         (BugzillaMixin.fetch_data_from_url_with_authentication): Method to fetch data from bugzilla using api key.
1858         (BugzillaMixin.get_patch_json): 
1859         (BugzillaMixin.get_bug_json):
1860         (BugzillaMixin._is_bug_closed):
1861         (ApplyPatch.hideStepIf): Use 'sensitive' build property instead of 'validated'.
1862         (TransferToS3.hideStepIf): Ditto.
1863
1864 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
1865
1866         [ews] commit-queue should show the trac url for the commit on the build page
1867         https://bugs.webkit.org/show_bug.cgi?id=208715
1868
1869         Reviewed by Jonathan Bedard.
1870
1871         * BuildSlaveSupport/ews-build/steps.py:
1872         (PushCommitToWebKitRepo.evaluateCommand):
1873
1874 2020-03-06  Alex Christensen  <achristensen@webkit.org>
1875
1876         Fix ResourceLoadDelegate.LoadInfo API test after r257816
1877         https://bugs.webkit.org/show_bug.cgi?id=208550
1878
1879         * TestWebKitAPI/cocoa/HTTPServer.mm:
1880         (TestWebKitAPI::HTTPServer::respondToRequests):
1881         Sometimes we need a separate read to read the HTTP body after a request header, sometimes it comes in the same read.
1882         If it comes in the same read, send the response immediately.  Otherwise read the HTTP body then send the response.
1883
1884 2020-03-06  Lauro Moura <lmoura@igalia.com>
1885
1886         [WPE][WebDriver] MiniBrowser should react to close session commands
1887         https://bugs.webkit.org/show_bug.cgi?id=207529
1888
1889         Reviewed by Carlos Garcia Campos.
1890
1891         Do not call g_object_unref on the first created view if it has already
1892         been disposed in the "close" signal handler.
1893
1894         Based on original patch by Yury Semikhatsky.
1895
1896         * MiniBrowser/wpe/main.cpp:
1897         (main):
1898
1899 2020-03-06  Michael Catanzaro  <mcatanzaro@gnome.org>
1900
1901         [WPE][GTK] Use Firefox user agent quirk more aggressively on Google Docs
1902         https://bugs.webkit.org/show_bug.cgi?id=208647
1903
1904         Reviewed by Carlos Garcia Campos.
1905
1906         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1907         (TestWebKitAPI::TEST):
1908
1909 2020-03-05  Alex Christensen  <achristensen@webkit.org>
1910
1911         Add WKNavigationDelegatePrivate SPI to inform application of subframe navigations
1912         https://bugs.webkit.org/show_bug.cgi?id=208670
1913
1914         Reviewed by Brady Eidson.
1915
1916         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
1917         (-[FrameNavigationDelegate waitForNavigations:]):
1918         (-[FrameNavigationDelegate requests]):
1919         (-[FrameNavigationDelegate frames]):
1920         (-[FrameNavigationDelegate callbacks]):
1921         (-[FrameNavigationDelegate _webView:didStartProvisionalLoadWithRequest:inFrame:]):
1922         (-[FrameNavigationDelegate _webView:didFailProvisionalLoadWithRequest:inFrame:withError:]):
1923         (-[FrameNavigationDelegate _webView:didCommitLoadWithRequest:inFrame:]):
1924         (-[FrameNavigationDelegate _webView:didFailLoadWithRequest:inFrame:withError:]):
1925         (-[FrameNavigationDelegate _webView:didFinishLoadWithRequest:inFrame:]):
1926         (TEST):
1927
1928 2020-03-05  Alex Christensen  <achristensen@webkit.org>
1929
1930         Add WKFrameInfo._parentFrameHandle SPI
1931         https://bugs.webkit.org/show_bug.cgi?id=208674
1932
1933         Reviewed by Brady Eidson.
1934
1935         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1936
1937 2020-03-05  Jiewen Tan  <jiewen_tan@apple.com>
1938
1939         [WebAuthn] Implement SPI -[_WKWebAuthenticationPanelDelegate panel:selectAssertionResponse:source:completionHandler:]
1940         https://bugs.webkit.org/show_bug.cgi?id=208626
1941         <rdar://problem/60074148>
1942
1943         Reviewed by Brent Fulgham.
1944
1945         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1946         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
1947         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:source:completionHandler:]):
1948         (TestWebKitAPI::TEST):
1949         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:completionHandler:]): Deleted.
1950         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-multiple-accounts.html:
1951         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Added.
1952
1953 2020-03-05  Antoine Quint  <graouts@apple.com>
1954
1955         Page-specific UserStyleSheets should wait until the initial empty document has been removed to be injected
1956         https://bugs.webkit.org/show_bug.cgi?id=208644
1957         <rdar://problem/60042429>
1958
1959         Reviewed by Brady Eidson.
1960
1961         Add new tests for -[_WKUserStyleSheet initWithSource:forWKWebView:forMainFrameOnly:userContentWorld:]) that check:
1962         
1963         1. that a _WKUserStyleSheet can be added immediately after a WKWebView's creation and will be injected once the initial
1964            empty document has been removed in favor of the document for the requested URL,
1965         2. that removing a _WKUserStyleSheet immediately after it was added but before the initial empty document was removed
1966            correctly does not injected the style sheet.
1967
1968         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
1969
1970 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
1971
1972         [ews] Add build step to push commit to WebKit repository
1973         https://bugs.webkit.org/show_bug.cgi?id=208589
1974
1975         Reviewed by Jonathan Bedard.
1976
1977         * BuildSlaveSupport/ews-build/steps.py:
1978         (PushCommitToWebKitRepo): Build step to push the local commit to WebKit repository.
1979         (PushCommitToWebKitRepo.start): Initialize log observer.
1980         (PushCommitToWebKitRepo.evaluateCommand): Check command return status and comment on bug accordingly.
1981         (PushCommitToWebKitRepo.comment_text_for_bug): Generate comment text for commenting on bug.
1982         (PushCommitToWebKitRepo.svn_revision_from_commit_text): Extract the svn revision from commit text.
1983         (PushCommitToWebKitRepo.getResultSummary): Set custom failure message.
1984         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1985         * BuildSlaveSupport/ews-build/factories.py:
1986
1987 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
1988
1989         [ews] Add unit tests for ValidateCommiterAndReviewer build step
1990         https://bugs.webkit.org/show_bug.cgi?id=208262
1991
1992         Reviewed by Jonathan Bedard.
1993
1994         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests for ValidateCommiterAndReviewer.
1995
1996 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
1997
1998         commit-queue should run WK2 tests instead of WK1 tests
1999         https://bugs.webkit.org/show_bug.cgi?id=208544
2000
2001         Reviewed by Jonathan Bedard.
2002
2003         * BuildSlaveSupport/ews-build/factories.py:
2004
2005 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
2006
2007         [ews] ValidateCommiterAndReviewer should validate emails in case insensitive manner
2008         https://bugs.webkit.org/show_bug.cgi?id=208645
2009
2010         Reviewed by Alexey Proskuryakov.
2011
2012         * BuildSlaveSupport/ews-build/steps.py:
2013         (ValidateCommiterAndReviewer.load_contributors):
2014         (ValidateCommiterAndReviewer.start):
2015
2016 2020-03-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2017
2018         style-checker: Add UAF to the list of security words to warn about.
2019         https://bugs.webkit.org/show_bug.cgi?id=208643
2020
2021         Reviewed by Jonathan Bedard.
2022
2023         UAF is a common acronym used for use after free.
2024
2025         * Scripts/webkitpy/style/checkers/changelog.py:
2026         (ChangeLogChecker.check_for_unwanted_security_phrases):
2027
2028 2020-03-04  Basuke Suzuki  <basuke.suzuki@sony.com>
2029
2030         [MSVC] Add .natvis support of WebKit types
2031         https://bugs.webkit.org/show_bug.cgi?id=193119
2032
2033         Reviewed by Don Olmstead.
2034
2035         To help the WebKit developer while debugging, this file defines how
2036         WebKit types are displayed in debugger of Visual Studio.
2037         Very limited set of WebKit types, but it changes the world.
2038
2039         * VisualStudio/WebKit.natvis: Added.
2040
2041 2020-03-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2042
2043         Add system trace points around display list replay
2044         https://bugs.webkit.org/show_bug.cgi?id=208616
2045
2046         Reviewed by Simon Fraser.
2047
2048         Add a new "Display list replay" trace point.
2049
2050         * Tracing/SystemTracePoints.plist:
2051
2052 2020-03-04  Alex Christensen  <achristensen@webkit.org>
2053
2054         Call globalObjectIsAvailableForFrame before evaluating JavaScript in newly created worlds
2055         https://bugs.webkit.org/show_bug.cgi?id=208615
2056         <rdar://problem/59406743>
2057
2058         Reviewed by Alex Christensen.
2059
2060         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2061         * TestWebKitAPI/Tests/WebKitCocoa/ContentWorldPlugIn.mm: Added.
2062         (-[ContentWorldPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2063         (-[ContentWorldPlugIn webProcessPlugInBrowserContextController:globalObjectIsAvailableForFrame:inScriptWorld:]):
2064         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
2065         (TEST):
2066         Also make a test written in bug 206310 actually run code.
2067
2068 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
2069
2070         [build.webkit.org] Remove leaks queue
2071         https://bugs.webkit.org/show_bug.cgi?id=208580
2072
2073         Reviewed by Jonathan Bedard.
2074
2075         * BuildSlaveSupport/build.webkit.org-config/config.json:
2076         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2077         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2078
2079 2020-03-04  Alex Christensen  <achristensen@webkit.org>
2080
2081         Add SPI to evaluate JavaScript in an iframe
2082         https://bugs.webkit.org/show_bug.cgi?id=208605
2083
2084         Reviewed by Brady Eidson.
2085
2086         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2087
2088 2020-03-03  Jiewen Tan  <jiewen_tan@apple.com>
2089
2090         [WebAuthn] Implement -[_WKWebAuthenticationPanelDelegate panel:decidePolicyForLocalAuthenticatorWithCompletionHandler:] SPI
2091         https://bugs.webkit.org/show_bug.cgi?id=208533
2092         <rdar://problem/60010184>
2093
2094         Reviewed by Alex Christensen.
2095
2096         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2097         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
2098         (-[TestWebAuthenticationPanelDelegate panel:decidePolicyForLocalAuthenticatorWithCompletionHandler:]):
2099         (TestWebKitAPI::TEST):
2100         (-[TestWebAuthenticationPanelDelegate panel:verifyUserWithAccessControl:completionHandler:]): Deleted.
2101         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Removed.
2102
2103 2020-03-04  Alex Christensen  <achristensen@webkit.org>
2104
2105         callAsyncJavaScript with an invalid parameter and no completionHandler should not crash
2106         https://bugs.webkit.org/show_bug.cgi?id=208593
2107
2108         Reviewed by Brady Eidson.
2109
2110         * TestWebKitAPI/Tests/WebKitCocoa/AsyncFunction.mm:
2111         (TestWebKitAPI::TEST):
2112
2113 2020-03-04  Alex Christensen  <achristensen@webkit.org>
2114
2115         WKWebView's frames accessor should return a traversable type
2116         https://bugs.webkit.org/show_bug.cgi?id=208591
2117
2118         Reviewed by Brady Eidson.
2119
2120         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2121
2122 2020-03-04  Antoine Quint  <graouts@apple.com>
2123
2124         Add an SPI to allow UserStyleSheet injection to target a specific WKWebView
2125         https://bugs.webkit.org/show_bug.cgi?id=208575
2126         <rdar://problem/59773690>
2127
2128         Reviewed by Brady Eidson.
2129
2130         Add new tests for the new SPI which check:
2131         
2132         1. that specifying forWKWebView: when initializing a _WKUserStyleSheet will inject the provided CSS source in the
2133            specified WKWebView alone,
2134         2. that the same test works with two WKWebViews with a shared WKWebKitConfiguration,
2135         3. that a WKWebView-specific _WKUserStyleSheet can be removed,
2136         4. that a WKWebView-specific _WKUserStyleSheet can be added twice and removed once and be removed as expected,
2137         5. and that a WKWebView-specific _WKUserStyleSheet is automatically removed when navigating to a new page,
2138         6. and that the same test also works with PSON enabled.
2139
2140         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
2141
2142 2020-03-04  Ryan Haddad  <ryanhaddad@apple.com>
2143
2144         [macOS] test-lldb-webkit failing on debug bots
2145         https://bugs.webkit.org/show_bug.cgi?id=208545
2146
2147         Reviewed by Jonathan Bedard.
2148
2149         The lldb-webkit-test step must pass in the build configuration as an
2150         argument to the test-lldb-webkit script so that it uses the lldbWebKitTester
2151         binary that is downloaded with the rest of the build products. Without this
2152         argument, the bots expect to find the binary in the 'WebKitBuild/Release' directory
2153         regardless of their actual build configuration.
2154
2155         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2156         (RunLLDBWebKitTests): Pass in the build configuration to the test-lldb-webkit script.
2157         * Scripts/test-lldb-webkit:
2158         (LldbTester.parse_args): Capitalize the constants for Debug / Release since that is what webkitpy expects.
2159
2160 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
2161
2162         [ews] Add build step to create local git commit for commit-queue (follow-up fix)
2163         https://bugs.webkit.org/show_bug.cgi?id=208539
2164
2165         Unreviewed follow-up fix.
2166
2167         * BuildSlaveSupport/ews-build/steps.py:
2168
2169 2020-03-04  Daniel Bates  <dabates@apple.com>
2170
2171         Should use -bounds instead of -frame in RequestTextInputContext.mm tests
2172         https://bugs.webkit.org/show_bug.cgi?id=208565
2173
2174         Reviewed by Wenson Hsieh.
2175
2176         Pass the bounds of the web view to -synchronouslyRequestTextInputContextsInRect: instead
2177         of its frame as a means to find all the editable elements in the visible content area
2178         of the web view.
2179
2180         Coincidentally this makes no difference to the test results right now because the web view
2181         happens to be located at the origin (0, 0) in the window. However if in the future the
2182         web view would be located at some other point then the tests may fail because the rectangle
2183         passed to -synchronouslyRequestTextInputContextsInRect: would no longer represent the
2184         rectangle for the visible content area.
2185
2186         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2187         (TEST):
2188
2189 2020-03-04  Daniel Bates  <dabates@apple.com>
2190
2191         Organize tests in RequestTextInputContext.mm tests under test name RequestTextInputContext
2192         https://bugs.webkit.org/show_bug.cgi?id=208564
2193
2194         Reviewed by Alex Christensen.
2195
2196         Group the tests in RequestTextInputContext.mm under the test case name RequestTextInputContext
2197         to make it easy to run just these tests.
2198
2199         Currently, the tests are organized under the test case name WebKit. This means you need to
2200         pass run-api-tests the name of each sub-test as there is no easy way to run them all without
2201         also running all the TestWebKitAPI.WebKit sub-tests. Instead organize them under RequestTextInputContext
2202         so that a person can run just these test using:
2203         
2204                 run-api-tests --debug TestWebKitAPI.RequestTextInputContext
2205
2206         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2207         (TEST):
2208
2209 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
2210
2211         [ews] Add build step to create local git commit for commit-queue
2212         https://bugs.webkit.org/show_bug.cgi?id=208539
2213
2214         Reviewed by Jonathan Bedard.
2215
2216         * BuildSlaveSupport/ews-build/steps.py:
2217         (CreateLocalGITCommit): Build step to create local git commit.
2218         (CreateLocalGITCommit.start):
2219         (CreateLocalGITCommit.getResultSummary): Set custom failure message.
2220         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests and restructured imports.
2221         * BuildSlaveSupport/ews-build/factories.py:
2222
2223 2020-03-04  Simon Fraser  <simon.fraser@apple.com>
2224
2225         (r256513) [ Mac ] fast/scrolling/programmatic-scroll-to-zero-zero.html is a flaky failure
2226         https://bugs.webkit.org/show_bug.cgi?id=207948
2227
2228         Reviewed by Zalan Bujtas.
2229
2230         EventSendingController needs to trigger layout so that the WebHTMLView is not 0x0,
2231         so that it receives the wheel events.
2232
2233         * DumpRenderTree/mac/EventSendingController.mm:
2234         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
2235         * DumpRenderTree/win/EventSender.cpp:
2236         (mouseScrollBy):
2237
2238 2020-03-04  Andres Gonzalez  <andresg_22@apple.com>
2239
2240         REGRESSION (r257739): two fast/events/autoscroll test have started to fail
2241         https://bugs.webkit.org/show_bug.cgi?id=208520
2242         <rdar://problem/60000214>
2243
2244         Reviewed by Chris Fleizach.
2245
2246         Calling InjectedBundle::singleton().page()->page() in the constructor
2247         of the AccessibilityController is having this side effect on iOS.
2248         So #if to MAC where it's actually being used.
2249
2250         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2251         (WTR::AccessibilityController::AccessibilityController):
2252
2253 2020-03-03  Alex Christensen  <achristensen@webkit.org>
2254
2255         Add SPI _WKResourceLoadInfo.loadedFromCache
2256         https://bugs.webkit.org/show_bug.cgi?id=208554
2257
2258         Reviewed by Wenson Hsieh.
2259
2260         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2261         (TEST):
2262
2263 2020-03-03  Ryosuke Niwa  <rniwa@webkit.org>
2264
2265         Batch observations and completions of text manipulations
2266         https://bugs.webkit.org/show_bug.cgi?id=208406
2267
2268         Reviewed by Wenson Hsieh.
2269
2270         Updated the existing tests to use new APIs, and added new tests for batching finding & replacing
2271         multiple paragraphs at once.
2272
2273         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2274         (-[TextManipulationDelegate _webView:didFindTextManipulationItems:]):
2275         (-[TextManipulationDelegate items]):
2276         (-[LegacyTextManipulationDelegate init]):
2277         (-[LegacyTextManipulationDelegate _webView:didFindTextManipulationItem:]):
2278         (TextManipulation.StartTextManipulationSupportsLegacyDelegateCallback): Added.
2279         (TextManipulation.LegacyCompleteTextManipulationReplaceSimpleSingleParagraph): Added.
2280         (TextManipulation.CompleteTextManipulationReplaceMultipleSimpleParagraphsAtOnce): Added.
2281         (TextManipulation.CompleteTextManipulationShouldBatchItemCallback): Added.
2282         (TextManipulation.CompleteTextManipulationFailWhenItemIdentifierIsDuplicated): Added.
2283         (TextManipulation.CompleteTextManipulationCanHandleSubsetOfItemsToFail): Added.
2284
2285 2020-03-03  Per Arne Vollan  <pvollan@apple.com>
2286
2287         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
2288         https://bugs.webkit.org/show_bug.cgi?id=208415
2289
2290         Reviewed by Brent Fulgham.
2291
2292         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2293         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
2294         (TEST):
2295
2296 2020-03-03  Alex Christensen  <achristensen@webkit.org>
2297
2298         Add response to _WKResourceLoadDelegate didCompleteWithError callback
2299         https://bugs.webkit.org/show_bug.cgi?id=208553
2300
2301         Reviewed by Simon Fraser.
2302
2303         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2304         (-[TestResourceLoadDelegate webView:resourceLoad:didCompleteWithError:response:]):
2305         (TEST):
2306         (-[TestResourceLoadDelegate webView:resourceLoad:didCompleteWithError:]): Deleted.
2307
2308 2020-03-03  Brady Eidson  <beidson@apple.com>
2309
2310         API Test [Mojave+ WK2 Debug ] TestWebKitAPI.WKAttachmentTestsMac.InsertDroppedFilePromisesAsAttachments is a flaky crash.
2311         https://bugs.webkit.org/show_bug.cgi?id=198795
2312
2313         Reviewed by Chris Dumez.
2314
2315         This test appears to no longer be flaky.
2316         
2317         Let's re-enable it.
2318         
2319         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2320         (TestWebKitAPI::TEST):
2321
2322 2020-03-03  Alex Christensen  <achristensen@webkit.org>
2323
2324         Requests sent to _WKResourceLoadDelegate should include HTTPBody
2325         https://bugs.webkit.org/show_bug.cgi?id=208550
2326
2327         Reviewed by Tim Hatcher.
2328
2329         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2330         (TEST):
2331         * TestWebKitAPI/cocoa/HTTPServer.mm:
2332         (TestWebKitAPI::HTTPServer::respondToRequests):
2333         HTTPServer now looks for Content-Length in its request.
2334         If it finds this header, that means that the HTTP body is going to be received in another read, then the response should be sent after receiving that.
2335
2336 2020-03-03  Alex Christensen  <achristensen@webkit.org>
2337
2338         Expose originalURL and originalHTTPMethod on _WKResourceLoadInfo
2339         https://bugs.webkit.org/show_bug.cgi?id=208522
2340
2341         Reviewed by Brian Weinstein.
2342
2343         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2344         (TEST):
2345
2346 2020-03-03  Aakash Jain  <aakash_jain@apple.com>
2347
2348         commit-queue should update working directory and reapply patch just before commiting
2349         https://bugs.webkit.org/show_bug.cgi?id=208521
2350
2351         Reviewed by Jonathan Bedard.
2352
2353         * BuildSlaveSupport/ews-build/factories.py:
2354
2355 2020-03-03  Matt Lewis  <jlewis3@apple.com>
2356
2357         Add Unittest to commits_for_upload() and fix multiple unittests for several test suites.
2358         https://bugs.webkit.org/show_bug.cgi?id=208485
2359
2360         Reviewed by Jonathan Bedard.
2361
2362         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
2363         (StubRepository.__init__): Fixing the constructor to call upon the parent class as we were not doing this before. It also means
2364         that we don't have to recreate the variables that are already created.
2365         * Scripts/webkitpy/common/checkout/scm/stub_repository_unittest.py: High level changed the imports to better reflect what we are using
2366         from each module, rather than making extra imports that we don't need.
2367         (StubRepositoryTest.mock_host_for_stub_repository): Since we are calling both an executive and a filesystem mock for most of the
2368         tests. it makes more sense to create a mock host with the files needed, than it does to instantiate each of these as separate objects
2369         and not part of the host.
2370         (StubRepositoryTest.test_in_working_directory): Changed the filesystem call to the host call.
2371         (StubRepositoryTest.test_native_revision): Changed the filesystem call to the host call.
2372         (StubRepositoryTest.test_native_branch): Changed the filesystem call to the host call.
2373         (StubRepositoryTest.test_svn_revision): Changed the filesystem call to the host call.
2374         (StubRepositoryTest.test_find_checkout_root): Changed the filesystem call to the host call.
2375         (StubRepositoryTest.test_find_checkout_root_failure): Changed the filesystem call to the host call.
2376         (StubRepositoryTest.test_find_parent_path_matching_callback_condition_with_file_system): Changed the filesystem call to the host call.
2377         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py: 
2378         (SummarizedResultsTest.test_svn_revision_exists): Changed the name to original test to better reflect that it was just looking to see
2379         if we were geting any value at all
2380         (SummarizedResultsTest.test_svn_revision): Added a test to make sure that the revision we are getting is what we expect to get and make
2381         sure we aren't gabking the wrong key:value pair
2382         * Scripts/webkitpy/port/base_unittest.py: Changed from MockSystemHost to MockHost as we want the extras that
2383         come with the MockHosts and MockHost inherits from MockSystemHost.
2384         (PortTest.make_port): Changed the port to call MockHost that will creat the required stub_repository files.
2385         (test_commits_for_upload): Added amissing test for commits_for_upload as this has been an issue when trying to make changes
2386         to the various upload steps.
2387
2388 2020-03-03  Aakash Jain  <aakash_jain@apple.com>
2389
2390         [ews] Add build step to find list of modified changelogs
2391         https://bugs.webkit.org/show_bug.cgi?id=208514
2392
2393         Reviewed by Jonathan Bedard.
2394
2395         * BuildSlaveSupport/ews-build/factories.py:
2396         * BuildSlaveSupport/ews-build/steps.py:
2397         (FindModifiedChangeLogs): Build step to find modified ChangeLogs.
2398         (FindModifiedChangeLogs.start): Initialize log observer.
2399         (FindModifiedChangeLogs.getResultSummary): Set custom failure message.
2400         (FindModifiedChangeLogs.evaluateCommand):
2401         (FindModifiedChangeLogs.is_path_to_changelog): Check if the file is a ChangeLog.
2402         (FindModifiedChangeLogs._status_regexp): Regex to match files from git output.
2403         (FindModifiedChangeLogs.extract_changelogs): Method to get list of ChangeLogs from git output.
2404         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2405
2406 2020-03-03  Ryan Haddad  <ryanhaddad@apple.com>
2407
2408         [iOS EWS] TestWebKitAPI.WKWebsiteDataStore.RemoveAndFetchData is failing
2409         https://bugs.webkit.org/show_bug.cgi?id=208451
2410
2411         Unreviewed test gardening.
2412
2413         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm: Disable the test for iOS since it is slowing down EWS.
2414
2415 2020-03-03  Jiten Mehta  <jmehta@apple.com>
2416
2417         Adopt HTTP Alternative Services Storage
2418         https://bugs.webkit.org/show_bug.cgi?id=208387
2419
2420         Reviewed by Alex Christensen.
2421
2422         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2423         (checkUntilEntryFound):
2424         (TEST):
2425
2426 2020-03-03  Kate Cheney  <katherine_cheney@apple.com>
2427
2428         Check for navigation to app-bound domain during script evaluation
2429         https://bugs.webkit.org/show_bug.cgi?id=208319
2430         <rdar://problem/57569321>
2431
2432         Reviewed by Brent Fulgham.
2433
2434         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2435         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm: Added.
2436         (-[TestInAppBrowserScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2437         (TEST):
2438         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-agent-script.html: Added.
2439         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-script.html: Added.
2440
2441 2020-03-03  Commit Queue  <commit-queue@webkit.org>
2442
2443         Unreviewed, rolling out r257754.
2444         https://bugs.webkit.org/show_bug.cgi?id=208513
2445
2446         Introduced API test failure (Requested by perarne on #webkit).
2447
2448         Reverted changeset:
2449
2450         "[Cocoa] Mapping from MIME type to UTI type should be done in
2451         the UI process"
2452         https://bugs.webkit.org/show_bug.cgi?id=208415
2453         https://trac.webkit.org/changeset/257754
2454
2455 2020-03-03  Diego Pino Garcia  <dpino@igalia.com>
2456
2457         REGRESSION(r257726): [GTK] LayoutTests crashing after r257726
2458         https://bugs.webkit.org/show_bug.cgi?id=208506
2459
2460         Reviewed by Carlos Garcia Campos.
2461
2462         * WebKitTestRunner/TestController.cpp:
2463         (WTR::TestController::platformAdjustContext): Remove unnecessary code.
2464
2465 2020-03-02  Ben Nham  <nham@apple.com>
2466
2467         Add performance probes for HTML parsing
2468         https://bugs.webkit.org/show_bug.cgi?id=208271
2469
2470         Reviewed by Daniel Bates.
2471
2472         This adds probes that show which lines of HTML are have been parsed.
2473
2474         * Tracing/SystemTracePoints.plist:
2475
2476 2020-03-02  Per Arne Vollan  <pvollan@apple.com>
2477
2478         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
2479         https://bugs.webkit.org/show_bug.cgi?id=208415
2480
2481         Reviewed by Brent Fulgham.
2482
2483         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2484         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
2485         (TEST):
2486
2487 2020-03-02  Jacob Uphoff  <jacob_uphoff@apple.com>
2488
2489         Unreviewed, rolling out r257725.
2490
2491         This commit caused 10 API tests to fail
2492
2493         Reverted changeset:
2494
2495         "[Cocoa] Mapping from MIME type to UTI type should be done in
2496         the UI process"
2497         https://bugs.webkit.org/show_bug.cgi?id=208415
2498         https://trac.webkit.org/changeset/257725
2499
2500 2020-03-02  Saam Barati  <sbarati@apple.com>
2501
2502         Don't skip tests unnecessarily on arm64
2503         https://bugs.webkit.org/show_bug.cgi?id=208470
2504         <rdar://problem/59968869>
2505
2506         Reviewed by Tadeu Zagallo.
2507
2508         * Scripts/run-jsc-stress-tests:
2509
2510 2020-03-02  Andres Gonzalez  <andresg_22@apple.com>
2511
2512         Fix for LayoutTests/accessibility/mac/search-text/search-text.html in IsolatedTree mode.
2513         https://bugs.webkit.org/show_bug.cgi?id=208434
2514
2515         Reviewed by Chris Fleizach.
2516
2517         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2518         (WTR::AccessibilityController::AccessibilityController): Initializes m_useAXThread.
2519         (WTR::AccessibilityController::rootElement): No need to set m_useAXThread here since it is initialize in the constructor.
2520         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
2521         (WTR::AccessibilityController::accessibleElementById): Same as above.
2522
2523 2020-03-02  John Wilander  <wilander@apple.com>
2524
2525         ResourceLoadStatistics: Enable cookie blocking and the Storage Access API in ephemeral sessions
2526         https://bugs.webkit.org/show_bug.cgi?id=208399
2527         <rdar://problem/24731650>
2528
2529         Reviewed by Brent Fulgham.
2530
2531         The majority of the changes in WTR::TestController is (partially) fixing a bug
2532         where the TestRunner would statically use the default website datastore instead
2533         of the website data store configure for the page. This worked for persistent
2534         storage testing but not for ephemeral sessions which is what this patch is all
2535         about. The previous TestController::websiteDataStore() is now called
2536         TestController::defaultWebsiteDataStore() and the new
2537         TestController::websiteDataStore() returns the configured website data store.
2538         Most of the use of the default website data store should probably change but
2539         that's not really for this patch to deal with. I did however move all of
2540         resource load statistics' use to the new TestController::websiteDataStore().
2541
2542         A new TestRunner function was added: isStatisticsEphemeral()
2543         It allows test cases to query the ephemeral status of resource load statistics.
2544
2545         One problem that is mitigated in this patch but not fully fixed is that for
2546         Cocoa platforms, the TestRunner sets up two ephemeral sessions, once in
2547         TestController::generatePageConfiguration() via C API 
2548         WKPageConfigurationSetWebsiteDataStore(), and then again in 
2549         TestControllerCocoa's initializeWebViewConfiguration() via Cocoa API
2550         [copiedConfiguration setWebsiteDataStore:ephemeralWebsiteDataStore].
2551         I tried removing the latter since one session for all platforms should be
2552         Enough but got broken behavior as a result. So now both are still there
2553         and both enable resource load statistics.
2554
2555         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2556         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2557         (WTR::TestRunner::isStatisticsEphemeral):
2558         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2559         * WebKitTestRunner/TestController.cpp:
2560         (WTR::TestController::defaultWebsiteDataStore):
2561         (WTR::TestController::websiteDataStore):
2562         (WTR::TestController::generatePageConfiguration):
2563         (WTR::TestController::resetPreferencesToConsistentValues):
2564         (WTR::TestController::resetStateToConsistentValues):
2565         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2566         (WTR::TestController::decidePolicyForNavigationAction):
2567         (WTR::TestController::platformAdjustContext):
2568         (WTR::TestController::clearServiceWorkerRegistrations):
2569         (WTR::TestController::clearDOMCache):
2570         (WTR::TestController::clearDOMCaches):
2571         (WTR::TestController::clearIndexedDatabases):
2572         (WTR::TestController::clearLocalStorage):
2573         (WTR::TestController::hasDOMCache):
2574         (WTR::TestController::domCacheSize):
2575         (WTR::TestController::setStatisticsEnabled):
2576         (WTR::TestController::isStatisticsEphemeral):
2577         (WTR::TestController::setStatisticsDebugMode):
2578         (WTR::TestController::setStatisticsPrevalentResourceForDebugMode):
2579         (WTR::TestController::setStatisticsLastSeen):
2580         (WTR::TestController::setStatisticsMergeStatistic):
2581         (WTR::TestController::setStatisticsPrevalentResource):
2582         (WTR::TestController::setStatisticsVeryPrevalentResource):
2583         (WTR::TestController::dumpResourceLoadStatistics):
2584         (WTR::TestController::isStatisticsPrevalentResource):
2585         (WTR::TestController::isStatisticsVeryPrevalentResource):
2586         (WTR::TestController::isStatisticsRegisteredAsSubresourceUnder):
2587         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
2588         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
2589         (WTR::TestController::setStatisticsHasHadUserInteraction):
2590         (WTR::TestController::isStatisticsHasHadUserInteraction):
2591         (WTR::TestController::isStatisticsOnlyInDatabaseOnce):
2592         (WTR::TestController::setStatisticsGrandfathered):
2593         (WTR::TestController::isStatisticsGrandfathered):
2594         (WTR::TestController::setUseITPDatabase):
2595         (WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin):
2596         (WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin):
2597         (WTR::TestController::setStatisticsSubresourceUniqueRedirectTo):
2598         (WTR::TestController::setStatisticsSubresourceUniqueRedirectFrom):
2599         (WTR::TestController::setStatisticsTopFrameUniqueRedirectTo):
2600         (WTR::TestController::setStatisticsTopFrameUniqueRedirectFrom):
2601         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2602         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2603         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2604         (WTR::TestController::statisticsUpdateCookieBlocking):
2605         (WTR::TestController::statisticsSubmitTelemetry):
2606         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
2607         (WTR::TestController::setStatisticsIsRunningTest):
2608         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
2609         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2610         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2611         (WTR::TestController::setStatisticsGrandfatheringTime):
2612         (WTR::TestController::setStatisticsMaxStatisticsEntries):
2613         (WTR::TestController::setStatisticsPruneEntriesDownTo):
2614         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
2615         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
2616         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
2617         (WTR::TestController::statisticsDeleteCookiesForHost):
2618         (WTR::TestController::isStatisticsHasLocalStorage):
2619         (WTR::TestController::setStatisticsCacheMaxAgeCap):
2620         (WTR::TestController::hasStatisticsIsolatedSession):
2621         (WTR::TestController::setStatisticsShouldDowngradeReferrer):
2622         (WTR::TestController::setStatisticsShouldBlockThirdPartyCookies):
2623         (WTR::TestController::setStatisticsFirstPartyWebsiteDataRemovalMode):
2624         (WTR::TestController::statisticsResetToConsistentState):
2625         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
2626         * WebKitTestRunner/TestController.h:
2627         * WebKitTestRunner/TestInvocation.cpp:
2628         (WTR::TestInvocation::invoke):
2629         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2630         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2631         (WTR::initializeWebViewConfiguration):
2632         (WTR::TestController::platformCreateWebView):
2633
2634 2020-03-02  Per Arne Vollan  <pvollan@apple.com>
2635
2636         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
2637         https://bugs.webkit.org/show_bug.cgi?id=208415
2638
2639         Reviewed by Brent Fulgham.
2640
2641         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2642         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
2643         (TEST):
2644
2645 2020-03-02  Daniel Bates  <dabates@apple.com>
2646
2647         Page::editableElementsInRect() should find nested editable elements and return found elements in paint order
2648         https://bugs.webkit.org/show_bug.cgi?id=208352
2649         <rdar://problem/59867815>
2650
2651         Reviewed by Wenson Hsieh.
2652
2653         Update test results to reflect the new behavior. To do this I also need to fix up the test code
2654         to actually scroll the web content. This also means we now execute the same code on both Mac and
2655         iOS to do the scrolling: window.scrollTo(0, 5000). Also fixed up sub-test "Inputs scrolled outside
2656         the requested rect; should not be included." to use a 10000px height <div> so that you can scroll
2657         to a y position of 5000. Otherwise, it's impossible to do because the page height is < 5000px.
2658
2659         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2660         (TEST):
2661
2662 2020-03-02  Jacob Uphoff  <jacob_uphoff@apple.com>
2663
2664         Unreviewed, rolling out r257687.
2665
2666         This commit caused debug tests to crash for macOS & iOS
2667
2668         Reverted changeset:
2669
2670         "[Cocoa] Mapping from MIME type to UTI type should be done in
2671         the UI process"
2672         https://bugs.webkit.org/show_bug.cgi?id=208415
2673         https://trac.webkit.org/changeset/257687
2674
2675 2020-03-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2676
2677         Unreviewed, rolling out r257618.
2678
2679         This allegedly causes Safari to crash when closing a window
2680         (see rdar://problem/59922725).
2681
2682         Reverted changeset:
2683
2684         "UIProcess crash after using _prepareForMoveToWindow, then
2685         deallocating the WKWebView before moving to the window"
2686         https://bugs.webkit.org/show_bug.cgi?id=208365
2687         https://trac.webkit.org/changeset/257618
2688
2689 2020-02-29  Yusuke Suzuki  <ysuzuki@apple.com>
2690
2691         Remove std::lock_guard
2692         https://bugs.webkit.org/show_bug.cgi?id=206451
2693
2694         Reviewed by Anders Carlsson.
2695
2696         Add std::lock_guard lint rule to prevent from using it.
2697
2698         * Scripts/webkitpy/style/checkers/cpp.py:
2699         (check_lock_guard):
2700         (check_style):
2701         (CppChecker):
2702         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2703         (WebKitStyleTest.test_lock_guard):
2704         * TestWebKitAPI/Tests/WTF/Condition.cpp:
2705         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2706         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
2707         (assertHasObjects):
2708         (assertHasOnlyObjects):
2709         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2710         (WTR::AXThread::dispatch):
2711         (WTR::AXThread::dispatchFunctionsFromAXThread):
2712         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
2713         (WTR::AXThread::initializeRunLoop):
2714
2715 2020-02-29  Per Arne Vollan  <pvollan@apple.com>
2716
2717         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
2718         https://bugs.webkit.org/show_bug.cgi?id=208415
2719
2720         Reviewed by Brent Fulgham.
2721
2722         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2723         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
2724         (TEST):
2725
2726 2020-02-28  Fujii Hironori  <Hironori.Fujii@sony.com>
2727
2728         Unreviewed, rolling out r257565.
2729
2730         It broke WinCairo MiniBrowser
2731
2732         Reverted changeset:
2733
2734         "[CMake] Use WEBKIT_EXECUTABLE in MiniBrowser"
2735         https://bugs.webkit.org/show_bug.cgi?id=206894
2736         https://trac.webkit.org/changeset/257565
2737
2738 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
2739
2740         EWS fails to retry build in case of kill-old-processes exception
2741         https://bugs.webkit.org/show_bug.cgi?id=208003
2742
2743         Reviewed by Jonathan Bedard.
2744
2745         * BuildSlaveSupport/ews-build/steps.py:
2746         (KillOldProcesses.evaluateCommand):
2747         (KillOldProcesses.getResultSummary):
2748
2749 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
2750
2751         [ews] commit-queue should update the ChangeLog with Reviewer name
2752         https://bugs.webkit.org/show_bug.cgi?id=206535
2753
2754         Reviewed by Jonathan Bedard.
2755
2756         * BuildSlaveSupport/ews-build/steps.py:
2757         (ApplyPatch.start): Update the patch with the patch reviewer name if available.
2758
2759 2020-02-28  Jonathan Bedard  <jbedard@apple.com>
2760
2761         run-javascriptcore-tests: Make upload format valid
2762         https://bugs.webkit.org/show_bug.cgi?id=208341
2763
2764         Rubber-stamped by Aakash Jain.
2765
2766         * Scripts/run-javascriptcore-tests:
2767         (uploadResults): Remove. FIXME.
2768         * Scripts/webkitdirs.pm:
2769         (splitVersionString): Handle case where the subminor version number has a - in it.
2770         * Scripts/webkitperl/webkitdirs_unittest/splitVersion.pl: Add unit tests.
2771
2772 2020-02-28  youenn fablet  <youenn@apple.com>
2773
2774         [MacOS/iOS] Enable audio/video capture in GPUProcess by default
2775         https://bugs.webkit.org/show_bug.cgi?id=208130
2776
2777         Reviewed by Eric Carlson.
2778
2779         * WebKitTestRunner/TestOptions.h:
2780         Use GPU process to capture by default.
2781         We will remove this option once done verifying that every test works smoothly.
2782
2783 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
2784
2785         [ews] commit queue should skip building and testing for rollout patches
2786         https://bugs.webkit.org/show_bug.cgi?id=208329
2787
2788         Reviewed by Jonathan Bedard.
2789
2790         * BuildSlaveSupport/ews-build/steps.py:
2791         (BugzillaMixin._is_patch_obsolete): Set rollout property appropriately.
2792         (CompileWebKit.doStepIf): Skip tests for rollout patches on commit-queue.
2793         (RunWebKit1Tests.doStepIf): Ditto.
2794         * BuildSlaveSupport/ews-build/steps_unittest.py:
2795         (TestCompileWebKit.test_skip_for_rollout_patches_on_commit_queue): Added unit-test.
2796         (TestRunWebKit1Tests.test_skip_for_rollout_patches_on_commit_queue): Ditto.
2797
2798 2020-02-28  Daniel Bates  <dabates@apple.com>
2799
2800         Update my watch list preferences and contributor's entry.
2801
2802         * Scripts/webkitpy/common/config/contributors.json:
2803         * Scripts/webkitpy/common/config/watchlist:
2804
2805 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
2806
2807         Fix WebCore export macros for declspec
2808         https://bugs.webkit.org/show_bug.cgi?id=208363
2809
2810         Reviewed by Konstantin Tokarev.
2811
2812         Remove setting of WEBCORE_EXPORT and WEBCORE_TESTSUPPORT_EXPORT from the header
2813         files. Removed precompiled headers that were empty.
2814
2815         * DumpRenderTree/DumpRenderTreePrefix.h:
2816         * DumpRenderTree/win/DefaultPolicyDelegate.cpp: Added a missing config.h.
2817         * MiniBrowser/win/stdafx.h:
2818         * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Removed.
2819         * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Removed.
2820         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.cpp: Removed.
2821         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h: Removed.
2822         * WebKitTestRunner/PlatformFTW.cmake:
2823         * WebKitTestRunner/PlatformWin.cmake:
2824         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
2825
2826 2020-02-27  Tim Horton  <timothy_horton@apple.com>
2827
2828         UIProcess crash after using _prepareForMoveToWindow, then deallocating the WKWebView before moving to the window
2829         https://bugs.webkit.org/show_bug.cgi?id=208365
2830
2831         Reviewed by Alex Christensen.
2832
2833         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
2834         (TEST):
2835         Add a test! It was a 100% repro crash before this change.
2836
2837 2020-02-27  Kate Cheney  <katherine_cheney@apple.com>
2838
2839         TestWebKitAPI and WebKitTestRunner should have bundle identifiers
2840         https://bugs.webkit.org/show_bug.cgi?id=208260
2841         <rdar://problem/59820107>
2842
2843         Reviewed by Tim Horton.
2844
2845         Followed instructions for adding an Info.plist for Single-File Tools
2846         found on https://developer.apple.com/library/archive/documentation/Security/Conceptual/CodeSigningGuide/Procedures/Procedures.html
2847
2848         The default WebsiteDataStore file path will change with this test to
2849         reflect the new bundleID so we must change expectations for any api
2850         tests which rely on knowing the path.
2851
2852         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2853         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2854         * TestWebKitAPI/Tests/WebKitCocoa/IDBDeleteRecovery.mm:
2855         (TEST):
2856         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2857         (TEST):
2858         * TestWebKitAPI/Tests/WebKitCocoa/IDBObjectStoreInfoUpgradeToV2.mm:
2859         (TEST):
2860         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.mm:
2861         (TEST):
2862         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2863         (TEST):
2864         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
2865         (TEST):
2866         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm:
2867         (TEST):
2868         (defaultWebsiteCacheDirectory):
2869         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageNullEntries.mm:
2870         (TEST):
2871         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2872         (TEST):
2873         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2874         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2875         (TEST):
2876         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2877         (TEST):
2878         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2879         (runWebsiteDataStoreCustomPaths):
2880         (TEST):
2881         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
2882         (TestWebKitAPI::resetTestState):
2883         Now that we set a bundleID, we have to reset the cache model between
2884         tests, otherwise it gets stored between tests.
2885
2886         (TestWebKitAPI::TEST):
2887         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2888         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2889
2890 2020-02-27  Ryosuke Niwa  <rniwa@webkit.org>
2891
2892         TextManipulationController should not generate a new item for content in manipulated paragraphs
2893         https://bugs.webkit.org/show_bug.cgi?id=208286
2894
2895         Reviewed by Wenson Hsieh.
2896
2897         Added a regression test.
2898
2899         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2900         (TextManipulation.InsertingContentIntoAlreadyManipulatedContentDoesNotCreateTextManipulationItem):
2901
2902 2020-02-27  Jonathan Bedard  <jbedard@apple.com>
2903
2904         run-javascriptcore-tests: Make upload format valid
2905         https://bugs.webkit.org/show_bug.cgi?id=208341
2906
2907         Reviewed by Aakash Jain.
2908
2909         * Scripts/run-javascriptcore-tests:
2910         (uploadResults): Print json blob for upload after failure for debugging.
2911
2912 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
2913
2914         [CMake] Add WebKit::PAL target
2915         https://bugs.webkit.org/show_bug.cgi?id=198493
2916
2917         Reviewed by Michael Catanzaro.
2918
2919         Add workaround for Windows where PAL_FRAMEWORK_HEADERS_DIR is not propagating.
2920
2921         * DumpRenderTree/PlatformWin.cmake:
2922
2923 2020-02-27  Alex Christensen  <achristensen@webkit.org>
2924
2925         Add SPI to query WKFrameInfos in a WKWebView
2926         https://bugs.webkit.org/show_bug.cgi?id=208212
2927
2928         Reviewed by Brady Eidson.
2929
2930         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2931         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp: Removed.
2932         * WebKitTestRunner/TestController.cpp:
2933         (WTR::TestController::saltForOrigin):
2934
2935 2020-02-27  Jacob Uphoff  <jacob_uphoff@apple.com>
2936
2937         Unreviewed, rolling out r257530.
2938
2939         This commit seems to have broke the build internally for
2940         watchOS
2941
2942         Reverted changeset:
2943
2944         "Add SPI to query WKFrameInfos in a WKWebView"
2945         https://bugs.webkit.org/show_bug.cgi?id=208212
2946         https://trac.webkit.org/changeset/257530
2947
2948 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
2949
2950         [CMake] Use WEBKIT_EXECUTABLE in MiniBrowser
2951         https://bugs.webkit.org/show_bug.cgi?id=206894
2952
2953         Reviewed by Adrian Perez de Castro.
2954
2955         Modify CMake ports to use WEBKIT_EXECUTABLE when creating their respective
2956         MiniBrowsers.
2957
2958         * MiniBrowser/gtk/CMakeLists.txt:
2959         * MiniBrowser/win/CMakeLists.txt:
2960         * MiniBrowser/wpe/CMakeLists.txt:
2961
2962 2020-02-26  Alex Christensen  <achristensen@webkit.org>
2963
2964         Remove unused WebsiteDataStore::setSourceApplicationBundleIdentifier
2965         https://bugs.webkit.org/show_bug.cgi?id=206456
2966
2967         Reviewed by Brady Eidson.
2968
2969         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2970         (TEST):
2971
2972 2020-02-26  Alex Christensen  <achristensen@webkit.org>
2973
2974         _WKUserContentWorld should be a wrapper around WKContentWorld
2975         https://bugs.webkit.org/show_bug.cgi?id=208274
2976
2977         Reviewed by Brady Eidson.
2978
2979         * TestWebKitAPI/Tests/WebKitCocoa/UserContentWorld.mm:
2980         (TEST):
2981         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
2982         (TEST):
2983
2984 2020-02-26  Ryan Haddad  <ryanhaddad@apple.com>
2985
2986         Unreviewed, rolling out r257522.
2987
2988         Caused 16 API test failures on the bots
2989
2990         Reverted changeset:
2991
2992         "TestWebKitAPI and WebKitTestRunner should have bundle
2993         identifiers"
2994         https://bugs.webkit.org/show_bug.cgi?id=208260
2995         https://trac.webkit.org/changeset/257522
2996
2997 2020-02-26  Alex Christensen  <achristensen@webkit.org>
2998
2999         Add SPI to query WKFrameInfos in a WKWebView
3000         https://bugs.webkit.org/show_bug.cgi?id=208212
3001
3002         Reviewed by Brady Eidson.
3003
3004         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3005         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp: Removed.
3006         * WebKitTestRunner/TestController.cpp:
3007         (WTR::TestController::saltForOrigin):
3008
3009 2020-02-26  Kate Cheney  <katherine_cheney@apple.com>
3010
3011         TestWebKitAPI and WebKitTestRunner should have bundle identifiers
3012         https://bugs.webkit.org/show_bug.cgi?id=208260
3013         <rdar://problem/59820107>
3014
3015         Reviewed by Tim Horton.
3016
3017         Followed instructions for adding an Info.plist for Single-File Tools
3018         found on https://developer.apple.com/library/archive/documentation/Security/Conceptual/CodeSigningGuide/Procedures/Procedures.html
3019
3020         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3021         * TestWebKitAPI/Info.plist: Added.
3022         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3023         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
3024         * WebKitTestRunner/Info.plist: Added.
3025         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3026
3027 2020-02-26  Kate Cheney  <katherine_cheney@apple.com>
3028
3029         Tests should each use a unique ResourceLoadStatistics file path for its database store
3030         https://bugs.webkit.org/show_bug.cgi?id=208206
3031         <rdar://problem/59690272>
3032
3033         Reviewed by Brady Eidson.
3034
3035         Initialize a default website data store before checking for the ITP
3036         store to ensure the directory exists after the file has been deleted.
3037
3038         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3039         (TEST):
3040
3041 2020-02-26  Christopher Reid  <chris.reid@sony.com>
3042
3043         [Win] Implement NetworkCache::Data by using FileSystem::MappedFileData
3044         https://bugs.webkit.org/show_bug.cgi?id=197684
3045         <rdar://problem/59467397>
3046
3047         Reviewed by Yusuke Suzuki.
3048
3049         Add test for FileSystem::createFile
3050
3051         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
3052
3053 2020-02-26  Aakash Jain  <aakash_jain@apple.com>
3054
3055         [ews] commit-queue should verify patch committer and reviewer
3056         https://bugs.webkit.org/show_bug.cgi?id=206532
3057
3058         Reviewed by Jonathan Bedard.
3059
3060         * BuildSlaveSupport/ews-build/steps.py:
3061         (ValidateCommiterAndReviewer): Build step to validate patch commiter and reviewer.
3062         (ValidateCommiterAndReviewer._addToLog):
3063         (ValidateCommiterAndReviewer.getResultSummary):
3064         (ValidateCommiterAndReviewer.fail_build):
3065         (ValidateCommiterAndReviewer.load_contributors): Load contributors information.
3066         (ValidateCommiterAndReviewer.is_reviewer):
3067         (ValidateCommiterAndReviewer.is_committer):
3068         (ValidateCommiterAndReviewer.full_name_from_email):
3069         (ValidateCommiterAndReviewer.start):
3070
3071 2020-02-26  Daniel Bates  <dabates@apple.com>
3072
3073         [iOS] Send focus update immediately on becoming or resigning first responder
3074         https://bugs.webkit.org/show_bug.cgi?id=208082
3075         <rdar://problem/59688413>
3076
3077         Rubber-stamped by Jer Noble.
3078
3079         Add a test to ensure that selecting a position at a point after the web view
3080         becomes first responder is allowed. Such an operation is only allowed if the
3081         web view is focused.
3082
3083         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
3084         (-[TestWKWebView selectPositionAtPoint:]):
3085         (TEST):
3086         * TestWebKitAPI/ios/UIKitSPI.h: Forward declare SPI.
3087
3088 2020-02-26  Chris Dumez  <cdumez@apple.com>
3089
3090         Unreviewed, disable new DragAndDropTests.DragAndDropOnEmptyView API test on iOS.
3091
3092         The test was added for macOS and times out on iOS.
3093
3094         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
3095         (TEST):
3096
3097 2020-02-26  Youenn Fablet  <youenn@apple.com>
3098
3099         Use WebPageProxy preferences for capture instead of WebProcessPool configuration parameters
3100         https://bugs.webkit.org/show_bug.cgi?id=208238
3101
3102         Reviewed by Eric Carlson.
3103
3104         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3105         (TEST):
3106         Remove use of deleted parameter.
3107
3108 2020-02-25  Devin Rousso  <drousso@apple.com>
3109
3110         Web Inspector: safari app extension isolated worlds and injected files use the extension's identifier instead of its name
3111         https://bugs.webkit.org/show_bug.cgi?id=206911
3112         <rdar://problem/58026635>
3113
3114         Reviewed by Brian Burg.
3115
3116         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3117         (TestWebKitAPI::TEST):
3118         Add test for `WTF::HashSet::reserveInitialCapacity`.
3119
3120         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3121         (TestWebKitAPI::TEST):
3122         Actually check the value of `WTF::HashMap::capacity`.
3123
3124         * TestWebKitAPI/Tests/WebKitCocoa/_WKInspectorDelegate.mm: Added.
3125         (-[InspectorDelegate _webView:didAttachInspector:])
3126         (-[InspectorDelegate _webView:browserDomainEnabledForInspector:])
3127         (-[InspectorDelegate _webView:browserDomainDisabledForInspector:])
3128         (TestWebKitAPI::TEST):
3129         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3130         (-[InspectorDelegate _webView:didAttachInspector:]): Deleted.
3131         (TestWebKitAPI::TEST): Deleted.
3132
3133 2020-02-25  Matt Lewis  <jlewis3@apple.com>
3134
3135         Add checkout_root to stubrepository.py
3136         https://bugs.webkit.org/show_bug.cgi?id=208213
3137
3138         Reviewed by Jonathan Bedard.
3139
3140         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
3141         (StubRepository.__init__):
3142
3143         We are creating our own class variable for checkout_root rather than calling the parent SCM variable
3144         because when initially we left out the parent constructor due to trying to override the fact that we don't actually have a SCM.
3145
3146 2020-02-25  Daniel Bates  <dabates@apple.com>
3147
3148         TestWebKitAPI.PasteMixedContent.CopyAndPasteWithCustomPasteboardDataOnly should wait until copy operation completes
3149         https://bugs.webkit.org/show_bug.cgi?id=208214
3150
3151         Reviewed by Wenson Hsieh.
3152
3153         Wait until the copy operation completes before loading the second web view and testing paste
3154         to ensure that something was actually copied to the clipboard.
3155
3156         * TestWebKitAPI/TestWebKitAPI.xcodeproj/xcshareddata/xcschemes/TestWebKitAPI.xcscheme:
3157         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
3158         (TestWebKitAPI::TEST): Substitute -_synchronouslyExecuteEditCommand for -_executeEditCommand
3159         so that we wait until the command completes.
3160
3161 2020-02-25  Chris Dumez  <cdumez@apple.com>
3162
3163         REGRESSION (r256882): Can't drag an HTML file into a new (empty) Safari tab
3164         https://bugs.webkit.org/show_bug.cgi?id=208199
3165         <rdar://problem/59746887>
3166
3167         Reviewed by Alex Christensen.
3168
3169         Add API test coverage.
3170
3171         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
3172         (TEST):
3173
3174 2020-02-25  Sihui Liu  <sihui_liu@apple.com>
3175
3176         spinRunLoop should take a non-zero integer as parameter
3177         https://bugs.webkit.org/show_bug.cgi?id=208148
3178         <rdar://problem/59766682>
3179
3180         Unreviewed iOS build fix.
3181
3182         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
3183         (TestWebKitAPI::Util::spinRunLoop):
3184
3185 2020-02-25  Sihui Liu  <sihui_liu@apple.com>
3186
3187         spinRunLoop should take a non-zero integer as parameter
3188         https://bugs.webkit.org/show_bug.cgi?id=208148
3189
3190         Reviewed by Darin Adler.
3191
3192         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3193         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3194         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
3195         (TestWebKitAPI::Util::spinRunLoop):
3196
3197 2020-02-24  Yusuke Suzuki  <ysuzuki@apple.com>
3198
3199         [WTF] Add tests for CompactRefPtrTuple
3200         https://bugs.webkit.org/show_bug.cgi?id=208172
3201
3202         Reviewed by Darin Adler.
3203
3204         We copy tests from RefPtr for CompactRefPtrTuple to ensure that it is working correctly.
3205         Many of tests are not necessary since currently CompactRefPtrTuple is non-copyable / non-movable.
3206
3207         * TestWebKitAPI/CMakeLists.txt:
3208         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3209         * TestWebKitAPI/Tests/WTF/CompactRefPtrTuple.cpp: Added.
3210         (TestWebKitAPI::TEST):
3211
3212 2020-02-24  Aakash Jain  <aakash_jain@apple.com>
3213
3214         [ews] commit-queue should check that patch have appropriate review flag
3215         https://bugs.webkit.org/show_bug.cgi?id=208138
3216
3217         Reviewed by Jonathan Bedard.
3218
3219         * BuildSlaveSupport/ews-build/steps.py:
3220         (BugzillaMixin._is_patch_obsolete): Drive-by fix to set build properties for patch author, commiter and reviewer.
3221         (BugzillaMixin._is_patch_cq_plus):
3222         (BugzillaMixin._does_patch_have_acceptable_review_flag): Method to check if patch have r? or r- flag.
3223         (ValidatePatch.start):
3224
3225 2020-02-24  Jiewen Tan  <jiewen_tan@apple.com>
3226
3227         [WebAuthn] Implement SPI for the platform authenticator
3228         https://bugs.webkit.org/show_bug.cgi?id=208087
3229         <rdar://problem/59369305>
3230
3231         Reviewed by Brent Fulgham.
3232
3233         Besides adding API tests, this patch also teaches TestWebKitAPI to use restricted entitlements.
3234
3235         * TestWebKitAPI/Configurations/TestWebKitAPI-macOS.entitlements:
3236         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3237         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3238         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
3239         (-[TestWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:]):
3240         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:completionHandler:]):
3241         (-[TestWebAuthenticationPanelDelegate panel:verifyUserWithAccessControl:completionHandler:]):
3242         (TestWebKitAPI::TEST):
3243         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion.html.
3244         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-duplicate-credential.html: Added.
3245         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-error.html: Added.
3246         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la.html: Added.
3247
3248 2020-02-24  Yusuke Suzuki  <ysuzuki@apple.com>
3249
3250         Unreviewed, updating LLDB test for CompactPointerTuple.
3251         https://bugs.webkit.org/show_bug.cgi?id=207827
3252
3253         * lldb/lldb_webkit.py:
3254         (WTFCompactPointerTupleProvider):
3255         (WTFCompactPointerTupleProvider.update):
3256
3257 2020-02-24  Ellie Epskamp-Hunt  <eepskamphunt@apple.com>
3258
3259         Provide alternate way to name Web Content process
3260         https://bugs.webkit.org/show_bug.cgi?id=205224
3261         rdar://57038084
3262
3263         Reviewed by Alex Christensen.
3264
3265         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3266         * TestWebKitAPI/Tests/WebKitCocoa/DisplayName.mm: Added.
3267         (TestWebKitAPI::TEST):
3268
3269 2020-02-24  Jonathan Bedard  <jbedard@apple.com>
3270
3271         results.webkit.org: Link to result archives
3272         https://bugs.webkit.org/show_bug.cgi?id=207646
3273         <rdar://problem/59395807>
3274
3275         Rubber-stamped by Aakash Jain.
3276
3277         * resultsdbpy/resultsdbpy/view/static/js/archiveRouter.js: Added.
3278         (_ArchiveRouter): Retrieve json from archive-router endpoint.
3279         (_ArchiveRouter.prototype._determineArgumentFromAncestry): Given an argument, default and ancestry values,
3280         return the most specific value.
3281         (_ArchiveRouter.prototype.hasArchive): Check if a suite and mode have an archive link.
3282         (_ArchiveRouter.prototype.pathFor): Construct the path for archive access.
3283         (_ArchiveRouter.prototype.labelFor): Return a label for an archive link.
3284         * resultsdbpy/resultsdbpy/view/static/js/investigate.js:
3285         (parametersForInstance): Extract from lambda function.
3286         (testRunLink): Use parametersForInstance instead of a lambda function.
3287         (archiveLink): Return an archive link for data. 
3288         (contentForData): Add archive link to view.
3289         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
3290         (TimelineFromEndpoint): Accept both suite and test.
3291         (TimelineFromEndpoint.prototype.render.onDotEnterFactory): Add archive link to pop-over.
3292         * resultsdbpy/resultsdbpy/view/templates/search.html: Pass suite and test to TimelineEndpoint.
3293         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Pass suite to TimelineEndpoint.
3294         * resultsdbpy/resultsdbpy/view/view_routes.py:
3295         (ViewRoutes.__init__): Add archive_route dictionary.
3296
3297 2020-02-24  Alex Christensen  <achristensen@webkit.org>
3298
3299         WKWebViewConfiguration._corsDisablingPatterns should also disable CORS for non-DocumentThreadableLoader loading
3300         https://bugs.webkit.org/show_bug.cgi?id=208035
3301         <rdar://problem/58011337>
3302
3303         Reviewed by Tim Hatcher.
3304
3305         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
3306
3307 2020-02-22  Darin Adler  <darin@apple.com>
3308
3309         Fix some include mistakes and make some coding style tweaks to WebKit and WebKitTestRunner
3310         https://bugs.webkit.org/show_bug.cgi?id=208099
3311
3312         Reviewed by Antti Koivisto.
3313
3314         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
3315         Sorted includes the traditional way. Added an include of AccessibilityCommonMac.h
3316         so we can use the -[NSString createJSStringRef] method.
3317         (-[NSString createJSStringRef]): Deleted. This is a duplicate of the method
3318         defined in AccessibilityCommonMac.mm, and was causing a linker warning.
3319
3320 2020-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3321
3322         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html is failing in iOS 13.4 beta
3323         https://bugs.webkit.org/show_bug.cgi?id=208096
3324         <rdar://problem/59632008>
3325
3326         Reviewed by Alexey Proskuryakov.
3327
3328         In the iOS 13.4 beta, the fix for <rdar://problem/56422337> changed -[UIDatePicker setCalendar:], such that
3329         if the new calendar locale matches that of the current calendar's locale (and several other properties of the
3330         new NSCalendar are also unchanged), then the UIDatePicker's calendar will also avoid changing.
3331
3332         In our layout tests, the mechanism we use to simulate the user changing their preferred calendar is no longer
3333         compatible with the above change since the swizzled NSCalendar instance does not have a locale set, so it will
3334         default to the same locale as the one used in the original NSCalendar. This means the call to -setCalendar: ends
3335         up being a no-op, so the test fails to override the simulated Japanese calendar type with a Gregorian calendar
3336         in the credit card expiry field.
3337
3338         To fix this, additionally specify a calendar locale identifier when generating the mock NSCalendar.
3339
3340         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3341         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3342         (WTR::UIScriptController::setDefaultCalendarType):
3343         * WebKitTestRunner/TestController.h:
3344
3345         Change m_overriddenCalendarIdentifier to m_overriddenCalendarAndLocaleIdentifiers, a pair of calendar
3346         identifier and calendar locale identifier.
3347
3348         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3349         (WTR::swizzledCalendar):
3350         (WTR::TestController::overriddenCalendarIdentifier const):
3351         (WTR::TestController::overriddenCalendarLocaleIdentifier const):
3352
3353         Clean these up by returning the `NSString *` instead of making another `RetainPtr`.
3354
3355         (WTR::TestController::setDefaultCalendarType):
3356
3357         Plumb the new calendar's locale identifier through this method.
3358
3359         (WTR::TestController::cocoaResetStateToConsistentValues):
3360         (WTR::TestController::getOverriddenCalendarIdentifier const): Deleted.
3361         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
3362         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:
3363         (WTR::UIScriptControllerCocoa::setDefaultCalendarType):
3364
3365 2020-02-21  Kate Cheney  <katherine_cheney@apple.com>
3366
3367         App-bound domains should have separate Network Sessions
3368         https://bugs.webkit.org/show_bug.cgi?id=208026
3369         <rdar://problem/59434006>
3370
3371         Reviewed by Brent Fulgham.
3372
3373         This patch is mostly test infrastructure involving 3 functions.
3374         One sets in-app browser privacy as enabled in the network process
3375         manually for the test. One ensures that setting the WebView category
3376         works properly, and the last one checks for an app-bound session for
3377         an app-bound navigation.
3378
3379         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3380         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3381         (WTR::InjectedBundle::didReceiveMessageToPage):
3382         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3383         (WTR::TestRunner::getWebViewCategory):
3384         (WTR::TestRunner::callDidReceiveWebViewCategoryCallback):
3385         (WTR::TestRunner::hasAppBoundSession):
3386         (WTR::TestRunner::setInAppBrowserPrivacyEnabled):
3387         (WTR::TestRunner::callDidSetInAppBrowserPrivacyEnabledCallback):
3388         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3389         * WebKitTestRunner/TestController.cpp:
3390         (WTR::TestController::ensureViewSupportsOptionsForTest):
3391         Clearing the bundleID should happen right before setting a new one, 
3392         otherwise it clears the ID after it is set and returns a null ID.
3393
3394         (WTR::TestController::resetStateToConsistentValues):
3395         (WTR::TestController::getWebViewCategory):
3396         (WTR::InAppBrowserPrivacyCallbackContext::InAppBrowserPrivacyCallbackContext):
3397         (WTR::inAppBrowserPrivacyBooleanResultCallback):
3398         (WTR::inAppBrowserPrivacyVoidResultCallback):
3399         (WTR::TestController::hasAppBoundSession):
3400         (WTR::TestController::setInAppBrowserPrivacyEnabled):
3401         * WebKitTestRunner/TestController.h:
3402         * WebKitTestRunner/TestInvocation.cpp:
3403         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3404         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3405         (WTR::TestInvocation::didSetInAppBrowserPrivacyEnabled):
3406         (WTR::TestInvocation::didReceivePrevalentDomains):
3407         (WTR::TestInvocation::didReceiveWebViewCategory):
3408         * WebKitTestRunner/TestInvocation.h:
3409         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3410         (WTR::TestController::getWebViewCategory):
3411
3412 2020-02-21  Jonathan Bedard  <jbedard@apple.com>
3413
3414         Build DumpRenderTree and WebKitTestRunner for macCatalyst
3415         https://bugs.webkit.org/show_bug.cgi?id=208068
3416         <rdar://problem/59676596>
3417
3418         Reviewed by Tim Horton.
3419
3420         * DumpRenderTree/ios/TextInputControllerIOS.m: Import WebKitLegacy explicitly.
3421         * DumpRenderTree/mac/Configurations/Base.xcconfig: Use cocoatouch instead of SDK.
3422         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Ditto.
3423         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Ditto.
3424         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Ditto.
3425         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Ditto.
3426         * DumpRenderTree/mac/EditingDelegate.mm: Import WebKitLegacy explicitly.
3427         * DumpRenderTree/mac/EventSendingController.h: Ditto.
3428         * DumpRenderTree/mac/ObjCPlugin.m: Ditto.
3429         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Ditto.
3430         * Makefile: Add DumpRenderTree and WebKitTestRunner.
3431         * WebKitTestRunner/Configurations/Base.xcconfig: Use cocoatouch instead of SDK.
3432         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Ditto.
3433         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Ditto.
3434
3435 2020-02-21  Aakash Jain  <aakash_jain@apple.com>
3436
3437         [ews] Add build step to Validate ChangeLog for commit-queue
3438         https://bugs.webkit.org/show_bug.cgi?id=208064
3439
3440         Reviewed by Jonathan Bedard.
3441
3442         * BuildSlaveSupport/ews-build/steps.py:
3443         (ValidateChangeLogAndReviewer): Build step to validate ChangeLog.
3444         (ValidateChangeLogAndReviewer.start):
3445         (ValidateChangeLogAndReviewer.evaluateCommand): If the validation fails, comment on bug and mark patch as cq-.
3446         (SetCommitQueueMinusFlagOnPatch.start): End the build (after marking the patch cq-) if build_finish_summary property is set.
3447
3448 2020-02-21  Aakash Jain  <aakash_jain@apple.com>
3449
3450         [ews] Add build step to set cq- flag on bugzilla patch
3451         https://bugs.webkit.org/show_bug.cgi?id=208021
3452
3453         Reviewed by Jonathan Bedard.
3454
3455         * BuildSlaveSupport/ews-build/steps.py:
3456         (BugzillaMixin.set_cq_minus_flag_on_patch):
3457         (SetCommitQueueMinusFlagOnPatch):
3458         (SetCommitQueueMinusFlagOnPatch.start):
3459         (SetCommitQueueMinusFlagOnPatch.getResultSummary):
3460
3461 2020-02-20  Matt Lewis  <jlewis3@apple.com>
3462
3463         Stub repositories fail to upload some results due to missing head svn revision
3464         https://bugs.webkit.org/show_bug.cgi?id=207684
3465
3466         Reviewed by Jonathan Bedard.
3467
3468         * Scripts/webkitpy/common/host_mock.py: Added in call for creating stub repo checkout information for upload tests.
3469         (MockHost.__init__):
3470         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3471         (summarize_results): Changed call to head_svn_revision to port.commits_for_upload() to bring
3472         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
3473         (SummarizedResultsTest.setUp): Added in new required parameter for testing.
3474         * Scripts/webkitpy/port/base.py:
3475         (Port.commits_for_upload): Removed the forced movement up the systems tree that prevented us 
3476         from using mock SCMs and more
3477         * Scripts/webkitpy/port/test.py: Added function to make the checkout_information.json for upload testing.
3478
3479 2020-02-21  Diego Pino Garcia  <dpino@igalia.com>
3480
3481         [JSCOnly] Add --verbose flag when running JavaScriptCore tests
3482         https://bugs.webkit.org/show_bug.cgi?id=208051
3483
3484         Reviewed by Carlos Alberto Lopez Perez.
3485
3486         Verbose flag prints out each test name executed. Without this flag
3487         stdout prints out one or two periods.
3488
3489         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3490         (RunJavaScriptCoreTests.start):
3491
3492 2020-02-21  Michael Catanzaro  <mcatanzaro@gnome.org>
3493
3494         [WPE][GTK] googleapis.com is a public suffix, defeating isGoogle() check in UserAgentQuirks.cpp
3495         https://bugs.webkit.org/show_bug.cgi?id=207984
3496
3497         Reviewed by Daniel Bates.
3498
3499         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3500         (TestWebKitAPI::TEST):
3501
3502 2020-02-20  Michael Catanzaro  <mcatanzaro@gnome.org>
3503
3504         [GTK] Improve user agent quirk for Google Docs and Google Drive
3505         https://bugs.webkit.org/show_bug.cgi?id=206506
3506
3507         Reviewed by Carlos Garcia Campos.
3508
3509         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3510         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
3511         (TestWebKitAPI::TEST):
3512
3513 2020-02-20  Fujii Hironori  <Hironori.Fujii@sony.com>
3514
3515         check-webkit-style: Check if *_EXPORT and *_EXPORT_PRIVATE macros are used under corresponding directories
3516         https://bugs.webkit.org/show_bug.cgi?id=207380
3517
3518         Reviewed by Jonathan Bedard.
3519
3520         Added a new rule 'build/export_macro'.
3521
3522         Removed a obsolete rule 'readability/webkit_export' which was used
3523         only by Chromium port (r148185).
3524
3525         * Scripts/webkitpy/style/checkers/cpp.py:
3526         (_FunctionState.export_macro):
3527         (check_function_definition):
3528         (_unix_path): Added.
3529         (is_generated_file): Use _unix_path.
3530         (check_has_config_header): Ditto.
3531         (CppChecker):
3532         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3533         (WebKitStyleTest.test_export_macro_check):
3534         (WebKitStyleTest.test_webkit_export_check): Deleted.
3535
3536 2020-02-20  Fujii Hironori  <Hironori.Fujii@sony.com>
3537
3538         [Win][MiniBrowser] Add prettier toolbar button icons
3539         https://bugs.webkit.org/show_bug.cgi?id=207999
3540
3541         Reviewed by Ross Kirsling.
3542
3543         Use a custom toolbar button icons instead of system stock icons.
3544
3545         Fixed a bug toolbar button dropdown arrows always looked being
3546         hovered. TBSTYLE_FLAT should be given.
3547
3548         Removed the window border line of Progress Indicator.
3549
3550         * MiniBrowser/win/MainWindow.cpp:
3551         (MainWindow::createToolbar):
3552         * MiniBrowser/win/MiniBrowserLib.rc:
3553         * MiniBrowser/win/MiniBrowserLibResource.h:
3554         * MiniBrowser/win/toolbar.bmp: Added.
3555
3556 2020-02-20  Aakash Jain  <aakash_jain@apple.com>
3557
3558         Update run-webkit-tests help description for skip-failing-tests
3559         https://bugs.webkit.org/show_bug.cgi?id=208031
3560
3561         Reviewed by Alexey Proskuryakov.
3562
3563         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3564
3565 2020-02-20  Chris Dumez  <cdumez@apple.com>
3566
3567         REGRESSION (r255677): Reloading tab with beforeunload prompt closes tab when asking to stay on page
3568         https://bugs.webkit.org/show_bug.cgi?id=208015
3569         <rdar://problem/59591630>
3570
3571         Reviewed by Geoffrey Garen.
3572
3573         Add API test coverage.
3574
3575         * TestWebKitAPI/Tests/WebKitCocoa/ModalAlerts.mm:
3576         (TEST):
3577
3578 2020-02-20  Tim Horton  <timothy_horton@apple.com>
3579
3580         WKWebView with non-zero origin has the wrong top content inset with NSWindowStyleMaskFullSizeContentView
3581         https://bugs.webkit.org/show_bug.cgi?id=207998
3582         <rdar://problem/40942425>
3583
3584         Reviewed by Sam Weinig.
3585
3586         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3587         * TestWebKitAPI/Tests/WebKitCocoa/TopContentInset.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm.
3588         (-[FullscreenChangeMessageHandler userContentController:didReceiveScriptMessage:]):
3589         (TestWebKitAPI::TEST):
3590         Add some tests for top content insets.
3591
3592 2020-02-20  Jonathan Bedard  <jbedard@apple.com>
3593
3594         results.webkit.org: Correctly report JSC tests for windows (Follow-up fix)
3595         https://bugs.webkit.org/show_bug.cgi?id=207910
3596
3597         Unreviewed infrastructure fix.
3598
3599         * Scripts/run-javascriptcore-tests:
3600         (configurationForUpload): Use the major version instead of the sub-minor version
3601         for version name.
3602
3603 2020-02-20  Don Olmstead  <don.olmstead@sony.com>
3604
3605         [CMake] Add WPE::libwpe target
3606         https://bugs.webkit.org/show_bug.cgi?id=207970
3607
3608         Reviewed by Adrian Perez de Castro.
3609
3610         Use the WPE::libwpe target.
3611
3612         * MiniBrowser/wpe/CMakeLists.txt:
3613         * TestWebKitAPI/PlatformWPE.cmake:
3614         * TestWebKitAPI/glib/PlatformWPE.cmake:
3615         * wpe/backends/CMakeLists.txt:
3616
3617 2020-02-19  Fujii Hironori  <Hironori.Fujii@sony.com>
3618
3619         [Win][MiniBrowser] Add 'Go Home' menu item and toolbar button
3620         https://bugs.webkit.org/show_bug.cgi?id=207749
3621
3622         Reviewed by Ross Kirsling.
3623
3624         Added "Set Default URL to Current URL" menu item like Mac MiniBrowser.
3625
3626         * MiniBrowser/win/MainWindow.cpp:
3627         (MainWindow::createToolbar):
3628         (MainWindow::WndProc):
3629         (MainWindow::setDefaultURLToCurrentURL):
3630         (MainWindow::goHome): Added.
3631         (MainWindow::onURLBarEnter):
3632         * MiniBrowser/win/MainWindow.h:
3633         * MiniBrowser/win/MiniBrowserLib.rc:
3634         * MiniBrowser/win/MiniBrowserLibResource.h:
3635         * MiniBrowser/win/MiniBrowserReplace.h:
3636         * MiniBrowser/win/WinMain.cpp:
3637         (wWinMain):
3638
3639 2020-02-19  Peng Liu  <peng.liu6@apple.com>
3640
3641         Fix check-webkit-style errors related to AVFoundationSPI.h
3642         https://bugs.webkit.org/show_bug.cgi?id=207834
3643
3644         Reviewed by Daniel Bates.
3645
3646         Revert the change in r256770 regarding the headers ordering.
3647         Headers in the same category should be in sorted order (case sensitive, as done by the command-line sort to