Revert fix for Bug 75064: TestWebKitAPI: initialize the main thread before running...
[WebKit-https.git] / Tools / ChangeLog
1 2012-01-04  David Kilzer  <ddkilzer@apple.com>
2
3         Revert fix for Bug 75064: TestWebKitAPI: initialize the main thread before running tests
4
5         This reverts commit r103546.
6
7         * TestWebKitAPI/TestsController.cpp:
8         (TestWebKitAPI::TestsController::TestsController):
9
10 2012-01-04  James Robinson  <jamesr@chromium.org>
11
12         [chromium] Move WebMimeRegistry and dependencies to Source/Platform
13         https://bugs.webkit.org/show_bug.cgi?id=74583
14
15         Reviewed by Darin Fisher.
16
17         Teaches the WEBKIT_EXPORT check about the chromium WebKit platform API header location.
18
19         * Scripts/webkitpy/style/checkers/cpp.py:
20         (check_function_definition):
21
22 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
23
24         [Qt] Fix link order of static libraries and unbreak QtWin32
25
26         We were keeping the correct static link order between the intermediate
27         WebKit libraries, but not the internal dependencies for each of those
28         libraries. The load() will in some instances mess with LIBS, so we need
29         to ensure that the dependent libraries are added after the library we
30         are linking against.
31
32         Reviewed by Simon Hausmann.
33
34         * qmake/mkspecs/features/default_post.prf:
35
36 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
37
38         [Qt] Introduce new qmake variable 'WEBKIT' for signaling dependencies
39
40         The custom qmake variable 'WEBKIT' is used for signaling that a
41         target depends in some way on other subproject of the WebKit
42         project. For now this is limited to the set of intermediate
43         libraries: wtf, javascriptcore, webcore, and webkit2.
44
45         This replaces the previous convension of using load(foo) for
46         just include paths, and CONFIG += foo to also link against foo.
47
48         Adding a dependency results in additional include paths being
49         available, and potentially linking to the library. This is
50         decided by the build system based on conditions such as what
51         kind of target is being built and the general build config.
52
53         An advantage to his approach is that it simplifies the individual
54         foo.prf files, for example by allowing us to use INCLUDEPATH +=
55         and LIBS += as normal instead of prepending.
56
57         Reviewed by Simon Hausmann.
58
59         * DumpRenderTree/qt/DumpRenderTree.pro:
60         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
61         * QtTestBrowser/QtTestBrowser.pro:
62         * WebKitTestRunner/InjectedBundle/Target.pri:
63         * WebKitTestRunner/Target.pri:
64         * qmake/README:
65         * qmake/mkspecs/features/default_post.prf:
66         * qmake/mkspecs/features/functions.prf:
67         * qmake/mkspecs/features/javascriptcore.prf:
68         * qmake/mkspecs/features/qtwebkit.prf:
69         * qmake/mkspecs/features/webcore.prf:
70         * qmake/mkspecs/features/webkit2.prf:
71         * qmake/mkspecs/features/wtf.prf:
72
73 2012-01-04  Alexander Færøy  <ahf@0x90.dk>
74
75         [Qt] Add UI for JavaScript Prompt dialog in the Qt MiniBrowser
76         https://bugs.webkit.org/show_bug.cgi?id=75488
77
78         Reviewed by Tor Arne Vestbø.
79
80         * MiniBrowser/qt/MiniBrowser.qrc:
81         * MiniBrowser/qt/qml/BrowserWindow.qml:
82         * MiniBrowser/qt/qml/Dialog.qml:
83         * MiniBrowser/qt/qml/DialogLineInput.qml: Copied from Tools/MiniBrowser/qt/qml/Dialog.qml.
84         * MiniBrowser/qt/qml/PromptDialog.qml: Copied from Tools/MiniBrowser/qt/qml/Dialog.qml.
85
86 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
87
88         [Qt] Use rpath for WTR's InjectedBundle to pick up the right QtWebKit
89
90         It wasn't really a problem at runtime since the right QtWebKit was
91         already loaded as a dependency of the web process, but the ldd output
92         would still be busted.
93
94         Reviewed by Simon Hausmann.
95
96         * WebKitTestRunner/InjectedBundle/Target.pri:
97
98 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
99
100         [Qt] Move use of $$qtLibraryTarget() to a single place
101
102         Reviewed by Kenneth Rohde Christiansen.
103
104         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
105         * WebKitTestRunner/InjectedBundle/Target.pri:
106         * qmake/mkspecs/features/default_post.prf:
107         * qmake/mkspecs/features/webcore.prf:
108
109 2012-01-04  Mary Wu  <mary.wu@torchmobile.com.cn>
110
111         Enable DOWNLOAD_ATTRIBUTE in BlackBerry porting
112         https://bugs.webkit.org/show_bug.cgi?id=75238
113
114         Reviewed by Antonio Gomes.
115
116         Add ENABLE_DOWNLOAD_ATTRIBUTE webkit feature into the build script so that 
117         it could initiate download directly if it has the download attribute in the link 
118         and doesn't need to open new blank page for the target="_blank". Enabling this 
119         feature in the BlackBerry porting also prepares for later blob feature implementation.
120
121         * Scripts/build-webkit: Modified to handle ENABLE_DOWNLOAD_ATTRIBUTE. Make it default on
122         for the BlackBerry porting.
123
124 2012-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
125
126         [GTK] Fix a runtime warning when hovering hyperlink auditing setting in MiniBroweser settings dialog
127         https://bugs.webkit.org/show_bug.cgi?id=75475
128
129         Reviewed by Martin Robinson.
130
131         The problem is that the property blurb contains <a ping> and tree
132         view uses gtk_tooltip_set_markup() internally, so we need to
133         escape the text.
134
135         * MiniBrowser/gtk/BrowserSettingsDialog.c:
136         (browserSettingsDialogConstructed): Escape property blurb before
137         storing it in the GtkTreeModel.
138
139 2012-01-03  Jochen Eisinger  <jochen@chromium.org>
140
141         When showing results.html pass a correct URL to webbrowser.open
142         https://bugs.webkit.org/show_bug.cgi?id=75438
143
144         Reviewed by Adam Barth.
145
146         * Scripts/webkitpy/common/system/filesystem.py:
147         (file_path_as_url):
148         * Scripts/webkitpy/common/system/filesystem_mock.py:
149         (file_path_as_url):
150         * Scripts/webkitpy/common/system/filesystem_unittest.py:
151         (test_file_path_as_url):
152         * Scripts/webkitpy/layout_tests/port/base.py:
153         (show_results_html_file):
154         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
155         (test_show_results_html_file):
156         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
157         (test_results_directory_relative):
158
159 2012-01-03  Ojan Vafai  <ojan@chromium.org>
160
161         shrink the header on the flakiness dashboard
162         https://bugs.webkit.org/show_bug.cgi?id=65153
163
164         Reviewed by Adam Roben.
165
166         Move some of the "show" links to be to the right of the header
167         instead of below the header when they content they're showing
168         is hidden. That way we don't waste vertical space on them.
169
170         No new tests. This code is covered by existing tests.
171
172         * TestResultServer/static-dashboards/flakiness_dashboard.html:
173
174 2012-01-03  Ryosuke Niwa  <rniwa@webkit.org>
175
176         Add a tool to analyze change logs
177         https://bugs.webkit.org/show_bug.cgi?id=72243
178
179         Reviewed by Eric Seidel.
180
181         Add the initial implementation of analyze-changelog command. This version supports parsing multiple changelogs
182         in a single directory and summarizes the result in json files. It also copies summary.html to the output directory
183         for visualizing json files.
184
185         Usage: webkit-patch analyze-changelog [--changelog-count N] <CHANGELOG_DIR> <OUTPUT_DIR>
186         where CHANGELOG_DIR is the directory to look for changelogs, OUTPUT_DIR is the directory into which the tool
187         generates json files, and N is the number of changelogs to parse.
188
189         * Scripts/webkitpy/common/config/contributionareas.py: Added names().
190         * Scripts/webkitpy/common/system/filesystem_mock.py: Added readline and iterator support to ReadableTextFileObject.
191         * Scripts/webkitpy/tool/commands/__init__.py:
192         * Scripts/webkitpy/tool/commands/analyzechangelog.py: Added.
193         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py: Added.
194         * Scripts/webkitpy/tool/commands/data/summary.html: Added.
195         * Scripts/webkitpy/tool/steps/options.py:
196
197 2012-01-03  Ryosuke Niwa  <rniwa@webkit.org>
198
199         Add a tool to analyze change logs
200         https://bugs.webkit.org/show_bug.cgi?id=72243
201
202         Reviewed by Eric Seidel.
203
204         Add the initial implementation of analyze-changelog command. This version supports parsing multiple changelogs
205         in a single directory and summarizes the result in json files. It also copies summary.html to the output directory
206         for visualizing json files.
207
208         Usage: webkit-patch analyze-changelog [--changelog-count N] <CHANGELOG_DIR> <OUTPUT_DIR>
209         where CHANGELOG_DIR is the directory to look for changelogs, OUTPUT_DIR is the directory into which the tool
210         generates json files, and N is the number of changelogs to parse.
211
212         * Scripts/webkitpy/common/config/contributionareas.py: Added names().
213         * Scripts/webkitpy/common/system/filesystem_mock.py: Added readline and iterator support to ReadableTextFileObject.
214         * Scripts/webkitpy/tool/commands/__init__.py:
215         * Scripts/webkitpy/tool/commands/analyzechangelog.py: Added.
216         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py: Added.
217         * Scripts/webkitpy/tool/commands/data/summary.html: Added.
218         * Scripts/webkitpy/tool/steps/options.py:
219
220 2012-01-03  Adam Roben  <aroben@apple.com>
221
222         Make Port subclasses override the operating_system method rather than setting an attribute
223
224         Without this patch, any use of Port.operating_system() within a port's __init__ method would
225         return the default value ("mac"). This was confusing the version-checking logic inside
226         ApplePort.__init__ on Windows.
227
228         Fixes <http://webkit.org/b/75479> <rdar://problem/10637385> REGRESSION (r102161): NRWT
229         crashes on launch on Windows 7 SP1
230
231         Reviewed by Eric Seidel.
232
233         * Scripts/webkitpy/layout_tests/port/apple.py:
234         (ApplePort.__init__): Replaced uses of self._operating_system with self.operating_system().
235
236         * Scripts/webkitpy/layout_tests/port/base.py:
237         (Port.__init__): Removed code that set the self._operating_system attribute. Subclasses
238         should now override the operating_system method instead.
239         (Port.operating_system): Changed to always return "mac". Subclasses should override to
240         return something else.
241
242         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
243         (ChromiumLinuxPort.__init__):
244         (ChromiumLinuxPort.operating_system):
245         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
246         (ChromiumMacPort.__init__):
247         (ChromiumMacPort.operating_system):
248         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
249         (ChromiumWinPort.__init__):
250         (ChromiumWinPort.operating_system):
251         * Scripts/webkitpy/layout_tests/port/mac.py:
252         (MacPort.__init__):
253         (MacPort.operating_system):
254         * Scripts/webkitpy/layout_tests/port/win.py:
255         (WinPort.__init__):
256         (WinPort.operating_system):
257         Changed to override the operating_system method rather than setting the _operating_system
258         attribute, since setting the attribute isn't sufficient for code inside __init__ methods.
259
260         * Scripts/webkitpy/layout_tests/port/qt.py:
261         (QtPort.__init__):
262         (QtPort._path_to_webcore_library):
263         Changed to use self.operating_system() instead of self._operating_system, for consistency
264         with other Port-related code.
265
266         (QtPort.operating_system): Added this override of Port.operating_system that returns the
267         value we determined in our __init__ method.
268
269         * Scripts/webkitpy/layout_tests/port/test.py:
270         (TestPort.operating_system): Added this override of Port.operating_system that returns the
271         value we determined in our __init__ method.
272
273         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
274         (PortTest.test_operating_system):
275         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
276         (ChromiumLinuxPortTest.test_operating_system):
277         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
278         (ChromiumMacPortTest.test_operating_system):
279         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
280         (ChromiumWinPortTest.test_operating_system):
281         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
282         (MacPortTest.test_operating_system):
283         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
284         (QtPortTest.test_operating_system):
285         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
286         (WinPortTest.test_operating_system):
287         Test that all ports return the expected operating system string.
288
289 2012-01-03  Mario Sanchez Prada  <msanchez@igalia.com>
290
291         [GTK] run-gtk-test should ignore files with names without a "test" or "Test" prefix
292         https://bugs.webkit.org/show_bug.cgi?id=75474
293
294         Reviewed by Philippe Normand.
295
296         * Scripts/run-gtk-tests: Ignore files whose name does not start
297         with a "test" (for WK1's API tests) or a "Test" prefix (for WK2).
298
299 2012-01-03  Alexander Færøy  <alexander.faeroy@nokia.com>
300
301         [Qt] Add UI for JavaScript Confirmation dialog in the Qt MiniBrowser
302         https://bugs.webkit.org/show_bug.cgi?id=75472
303
304         Reviewed by Tor Arne Vestbø.
305
306         * MiniBrowser/qt/MiniBrowser.pro:
307         * MiniBrowser/qt/MiniBrowser.qrc:
308         * MiniBrowser/qt/qml/BrowserWindow.qml:
309         * MiniBrowser/qt/qml/ConfirmDialog.qml: Added.
310
311 2012-01-03  Alexander Færøy  <alexander.faeroy@nokia.com>
312
313         [Qt] Add UI for JavaScript Alert dialog in the Qt MiniBrowser
314         https://bugs.webkit.org/show_bug.cgi?id=75471
315
316         Reviewed by Tor Arne Vestbø.
317
318         Add simple UI for JavaScript Alert dialogs. This patch also adds a
319         simple DialogButton QML type and a Dialog QML type which will be
320         reusable for other JavaScript dialogs.
321
322         * MiniBrowser/qt/MiniBrowser.qrc:
323         * MiniBrowser/qt/qml/AlertDialog.qml: Added.
324         * MiniBrowser/qt/qml/BrowserWindow.qml:
325         * MiniBrowser/qt/qml/Dialog.qml: Added.
326         * MiniBrowser/qt/qml/DialogButton.qml: Added.
327
328 2012-01-03  Rafael Brandao  <rafael.lobo@openbossa.org>
329
330         [Qt][WK2] MiniBrowser doesn't show url bar
331         https://bugs.webkit.org/show_bug.cgi?id=75470
332
333         Reviewed by Tor Arne Vestbø.
334
335         * MiniBrowser/qt/qml/BrowserWindow.qml: Remove clipping until it is fixed
336         on QtDeclarative (QTBUG-23422).
337
338 2012-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
339
340         [GTK] Simplify loader client WebKit2 GTK+ API
341         https://bugs.webkit.org/show_bug.cgi?id=74605
342
343         Reviewed by Gustavo Noronha Silva.
344
345         * gtk/generate-gtkdoc: Ignore WebKitWebLoaderClient since it's now
346         private API.
347
348 2012-01-03  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
349
350         [Qt] Clean up detection of fontconfig
351
352         We decide in features.prf whether or not fontconfig is available, and
353         set the HAVE_FONTCONFIG define accordingly. All leaf project files
354         should use this define to decide whether or not to link against
355         fontconfig, not do their own detection.
356
357         We don't need to add link_pkgconfig to CONFIG in each project file,
358         as we selectivly enable that configuration in defaults_post when
359         needed.
360
361         Reviewed by Ossy.
362
363         * DumpRenderTree/qt/DumpRenderTree.pro:
364         * QtTestBrowser/QtTestBrowser.pro:
365         * WebKitTestRunner/InjectedBundle/Target.pri:
366         * qmake/mkspecs/features/unix/default_post.prf:
367         * qmake/mkspecs/features/unix/default_pre.prf:
368
369 2012-01-03  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
370
371         [Qt] Introduce qmake replace function for the active build config
372
373         Reviewed by Ossy.
374
375         * qmake/mkspecs/features/default_post.prf:
376         * qmake/mkspecs/features/functions.prf:
377
378 2012-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
379
380         [GTK] Use gdk_screen_get_monitor_workarea() when available for screenAvailableRect()
381         https://bugs.webkit.org/show_bug.cgi?id=75435
382
383         Reviewed by Martin Robinson.
384
385         * GNUmakefile.am: Make sure DRT links to X11.
386         * WebKitTestRunner/GNUmakefile.am: Make sure WTR links to X11.
387
388 2011-12-04  Philippe Normand  <pnormand@igalia.com>
389
390         [WK2][GTK] WebSettings support in MiniBrowser
391         https://bugs.webkit.org/show_bug.cgi?id=73773
392
393         Reviewed by Martin Robinson.
394
395         Patch heavily inspired from the WebKit GtkLauncher to support
396         command-line WebSettings. Example: --enable-fullscreen=TRUE.
397         The full list of options can be consulted with --help-websettings.
398
399         * MiniBrowser/gtk/main.c:
400         (loadURI):
401         (parseOptionEntryCallback):
402         (isValidParameterType):
403         (getOptionEntriesFromWebKitSettings):
404         (addSettingsGroupToContext):
405         (main):
406
407 2012-01-02  Philippe Normand  <pnormand@igalia.com>
408
409         [GTK] GtkLauncher settings improvements
410         https://bugs.webkit.org/show_bug.cgi?id=75439
411
412         Reviewed by Martin Robinson.
413
414         * GtkLauncher/main.c:
415         (filenameToURL): We can use NULL in C.
416         (isValidParameterType): Utility function to filter GParamTypes
417         that can be edited.
418         (getOptionEntriesFromWebKitWebSettings): Avoid handling
419         construct-only properties and use the isValidParameterType
420         function. Makes the code a bit cleaner.
421
422 2012-01-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
423
424         [EFL] Remove whitespace/declaration style exception
425         https://bugs.webkit.org/show_bug.cgi?id=75424
426
427         Reviewed by David Levin.
428
429         Remove *whitespace/eclaration* style rule. However, EWebLauncher and MiniBrowser are EFL simple
430         application. So, they still need to use EFL coding style.
431
432         * Scripts/webkitpy/style/checker.py:
433
434 2012-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
435
436         [GTK] Add a way to change web view settings in MiniBrowser
437         https://bugs.webkit.org/show_bug.cgi?id=71568
438
439         Reviewed by Philippe Normand.
440
441         Add a preferences button to the toolbar that shows a dialog to
442         change settings of the current web view. It uses a GtkTreeView
443         with a custom cell renderer to support multiple types of values.
444
445         * MiniBrowser/gtk/BrowserCellRendererVariant.c: Added.
446         (browserCellRendererVariantFinalize):
447         (browserCellRendererVariantGetProperty):
448         (browserCellRendererVariantSetModeForValue):
449         (browserCellRendererVariantSetProperty):
450         (browserCellRendererVariantGetRendererForValue):
451         (browserCellRendererVariantCellRendererTextEdited):
452         (browserCellRendererVariantCellRendererSpinEdited):
453         (browserCellRendererVariantCellRendererActivate):
454         (browserCellRendererVariantCellRendererRender):
455         (browserCellRendererVariantCellRendererStartEditing):
456         (browserCellRendererVariantCellRendererGetPreferredWidth):
457         (browserCellRendererVariantCellRendererGetPreferredHeight):
458         (browserCellRendererVariantCellRendererGetPreferredWidthForHeight):
459         (browserCellRendererVariantCellRendererGetPreferredHeightForWidth):
460         (browserCellRendererVariantCellRendererGetAlignedArea):
461         (browser_cell_renderer_variant_init):
462         (browser_cell_renderer_variant_class_init):
463         (browser_cell_renderer_variant_new):
464         * MiniBrowser/gtk/BrowserCellRendererVariant.h: Added.
465         * MiniBrowser/gtk/BrowserSettingsDialog.c: Added.
466         (cellRendererChanged):
467         (browserSettingsDialogSetProperty):
468         (browser_settings_dialog_init):
469         (browserSettingsDialogConstructed):
470         (browser_settings_dialog_class_init):
471         (browser_settings_dialog_new):
472         * MiniBrowser/gtk/BrowserSettingsDialog.h: Added.
473         * MiniBrowser/gtk/BrowserWindow.c:
474         (settingsCallback):
475         (browser_window_init):
476         * MiniBrowser/gtk/GNUmakefile.am:
477         * MiniBrowser/gtk/browser-marshal.list: Added.
478
479 2012-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
480
481         [GTK] Implement create/ready-to-show/close signals in MiniBrowser
482         https://bugs.webkit.org/show_bug.cgi?id=74711
483
484         Reviewed by Philippe Normand.
485
486         * MiniBrowser/gtk/BrowserWindow.c:
487         (webViewClose): Destroy the window.
488         (webViewReadyToShow): Use WindowProperties of the new view to
489         setup and show the window.
490         (webViewCreate): Create a new view and add it to a browser window.
491         (browser_window_init):
492         (browserWindowConstructed): Connect to WebKitWebView::create signal.
493
494 2011-12-31  Dan Bernstein  <mitz@apple.com>
495
496         MiniBrowser sets the WKView’s frame incorrectly
497         https://bugs.webkit.org/show_bug.cgi?id=75393
498
499         Reviewed by Anders Carlsson.
500
501         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed Make Launchable build phase,
502         which is not needed since the binray is linked with the frameworks search path set to the
503         built products directory.
504         * MiniBrowser/mac/BrowserWindowController.m:
505         (-[BrowserWindowController awakeFromNib]): Changed to set the WKView’s frame to its
506         container’s bounds rather than its frame.
507         * MiniBrowser/mac/make-launchable.sh: Removed.
508
509 2011-12-29  Dan Bernstein  <mitz@apple.com>
510
511         debug-safari --no-saved-state fails to start the debugger
512         https://bugs.webkit.org/show_bug.cgi?id=75374
513
514         Reviewed by Sam Weinig.
515
516         * Scripts/webkitdirs.pm:
517         (execMacWebKitAppForDebugging): Pass the --args option to gdb so that it passes arguments to
518         the executable being debugged.
519
520 2011-12-29  Sam Weinig  <sam@webkit.org>
521
522         It should be easier to iterate a Vector backwards
523         https://bugs.webkit.org/show_bug.cgi?id=75359
524
525         Reviewed by Anders Carlsson.
526
527         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
528         * TestWebKitAPI/TestWebKitAPI.gypi:
529         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
530         Add new Vector test.
531
532         * TestWebKitAPI/Tests/Vector.cpp: Added.
533         (TestWebKitAPI::TEST):
534         Test Vector iterators, reverse_iterators and new reversed proxy.
535
536 2011-12-28  Dmitry Lomov  <dslomov@google.com>
537
538         [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
539         https://bugs.webkit.org/show_bug.cgi?id=66509
540         Just renames, merges and removal of dead code. Here are the list of renames:
541           - WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
542           - NewWebCommonWorkerClient renamed to WebCommonWorkerClient
543           - WebWorkerBase merged into WebSharedWorkerImpl
544           - NewWebWorkerBase renamed into WebWorkerBase
545  
546         Reviewed by David Levin.
547
548         * DumpRenderTree/chromium/TestWebWorker.h:
549         (TestWebWorker::createWorker):
550         * DumpRenderTree/chromium/WebViewHost.cpp:
551         (WebViewHost::createWorker):
552         * DumpRenderTree/chromium/WebViewHost.h:
553
554 2011-12-28  Sheriff Bot  <webkit.review.bot@gmail.com>
555
556         Unreviewed, rolling out r103785.
557         http://trac.webkit.org/changeset/103785
558         https://bugs.webkit.org/show_bug.cgi?id=75332
559
560         Broke builders; looks like clobbering didnt help (Requested by
561         dslomov on #webkit).
562
563         * DumpRenderTree/chromium/TestWebWorker.h:
564         (TestWebWorker::createWorker):
565         * DumpRenderTree/chromium/WebViewHost.cpp:
566         (WebViewHost::createWorker):
567         * DumpRenderTree/chromium/WebViewHost.h:
568
569 2011-12-28  Dmitry Lomov  <dslomov@google.com>
570
571
572         [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
573         https://bugs.webkit.org/show_bug.cgi?id=66509
574         Just renames, merges and removal of dead code. Here are the list of renames:
575           - WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
576           - NewWebCommonWorkerClient renamed to WebCommonWorkerClient
577           - WebWorkerBase merged into WebSharedWorkerImpl
578           - NewWebWorkerBase renamed into WebWorkerBase
579  
580         Reviewed by David Levin.
581
582         * DumpRenderTree/chromium/TestWebWorker.h:
583         (TestWebWorker::createWorker):
584         * DumpRenderTree/chromium/WebViewHost.cpp:
585         (WebViewHost::createWorker):
586         * DumpRenderTree/chromium/WebViewHost.h:
587
588 2011-12-28  Sheriff Bot  <webkit.review.bot@gmail.com>
589
590         Unreviewed, rolling out r103620.
591         http://trac.webkit.org/changeset/103620
592         https://bugs.webkit.org/show_bug.cgi?id=75316
593
594         Causes many crashes (Requested by abarth on #webkit).
595
596         * DumpRenderTree/chromium/LayoutTestController.cpp:
597         (LayoutTestController::LayoutTestController):
598         (LayoutTestController::reset):
599         * DumpRenderTree/chromium/LayoutTestController.h:
600         * DumpRenderTree/chromium/WebViewHost.cpp:
601         * DumpRenderTree/chromium/WebViewHost.h:
602
603 2011-12-27  Sheriff Bot  <webkit.review.bot@gmail.com>
604
605         Unreviewed, rolling out r103734.
606         http://trac.webkit.org/changeset/103734
607         https://bugs.webkit.org/show_bug.cgi?id=75278
608
609         Broke cr-mac (Requested by dslomov on #webkit).
610
611         * DumpRenderTree/chromium/TestWebWorker.h:
612         (TestWebWorker::createWorker):
613         * DumpRenderTree/chromium/WebViewHost.cpp:
614         (WebViewHost::createWorker):
615         * DumpRenderTree/chromium/WebViewHost.h:
616
617 2011-12-27  Dmitry Lomov  <dslomov@google.com>
618
619
620         [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
621         https://bugs.webkit.org/show_bug.cgi?id=66509
622         Just renames, merges and removal of dead code. Here are the list of renames:
623           - WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
624           - NewWebCommonWorkerClient renamed to WebCommonWorkerClient
625           - WebWorkerBase merged into WebSharedWorkerImpl
626           - NewWebWorkerBase renamed into WebWorkerBase
627  
628         Reviewed by David Levin.
629
630         * DumpRenderTree/chromium/TestWebWorker.h:
631         (TestWebWorker::createWorker):
632         * DumpRenderTree/chromium/WebViewHost.cpp:
633         (WebViewHost::createWorker):
634         * DumpRenderTree/chromium/WebViewHost.h:
635
636 2011-12-27  Anders Carlsson  <andersca@apple.com>
637
638         Function should handle wrapping/unwrapping RefPtr and PassRefPtr
639         https://bugs.webkit.org/show_bug.cgi?id=75266
640
641         Reviewed by Sam Weinig.
642
643         * TestWebKitAPI/Tests/WTF/Functional.cpp:
644         (TestWebKitAPI::Number::create):
645         (TestWebKitAPI::Number::~Number):
646         (TestWebKitAPI::Number::value):
647         (TestWebKitAPI::Number::Number):
648         (TestWebKitAPI::multiplyNumberByTwo):
649         (TestWebKitAPI::TEST):
650
651 2011-12-24  Kentaro Hara  <haraken@chromium.org>
652
653         Add unittests for the C++ parser of prepare-ChangeLog
654         https://bugs.webkit.org/show_bug.cgi?id=75191
655
656         Reviewed by Ryosuke Niwa.
657
658         cpp_unittests.cpp is the unittests for get_function_line_ranges_for_cpp()
659         of prepare-ChangeLog.
660
661         * Scripts/prepare-ChangeLog:
662         (get_function_line_ranges): Renames get_function_line_ranges_for_c()
663         to get_function_line_ranges_for_cpp().
664         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
665         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt: Added.
666         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added.
667         (func1):
668         (func2):
669         (func3):
670         (func4):
671         (func5):
672         (func6):
673         (func7):
674         (func8):
675         (func9):
676         (func10):
677         (func11):
678         (func12):
679         (func13):
680         (func14):
681         (func15):
682         (funcOverloaded):
683         (Class::func16):
684         (Class1::Class2::func17):
685         (Class2::func18):
686         (Class2::func19):
687         (Class2::func20):
688         (Class2::func21):
689         (Class2::func22):
690         (func23):
691         (func24):
692         (Class2::func25):
693         (Class1::func26):
694         (Class2::func27):
695         (Class3::func28):
696         (Class7::operator+):
697         (Class100::Class100):
698         (Class101::~Class101):
699         (Class102::Class102):
700         (Class103::Class103):
701         (Struct1::func29):
702         (Struct2::func30):
703         (NameSpace1::func30):
704         (NameSpace1::NameSpace2::func31):
705
706 2011-12-24  Kentaro Hara  <haraken@chromium.org>
707
708         Add unittests for the Java parser of prepare-ChangeLog
709         https://bugs.webkit.org/show_bug.cgi?id=75195
710
711         Reviewed by Ryosuke Niwa.
712
713         java_unittests.java is unittest cases for get_function_line_ranges_for_java()
714         of prepare-ChangeLog.
715
716         * Scripts/prepare-ChangeLog:
717         (get_function_line_ranges_for_java): Fixed a parser bug.
718
719             interface I
720             {
721                 void f()
722                 {
723                 }
724             }
725
726         should be recognized as "I.f", and
727
728             class C interface I
729             {
730                 void f()
731                 {
732                 }
733             }
734
735         should be recognized as "C.f".
736         Without this patch, both are recognized as "I.f".
737
738         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
739         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/java_unittests-expected.txt: Added.
740         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/java_unittests.java: Added.
741         (Simple):
742         (Simple.func1):
743         (Simple.func2):
744         (Simple.func3):
745         (Simple.func4):
746         (Simple.func5):
747         (Simple.func6):
748         (Simple.func7):
749         (Simple.func8):
750         (Simple.func9):
751         (Simple.func10):
752         (Simple.funcOverloaded):
753         (Simple.func11):
754         (Simple.func12):
755         (Simple.func13):
756         (Simple.func14):
757         (Simple.func15):
758         (Simple.func16):
759         (Simple.func17):
760         (Simple.func18):
761         (Simple.func19):
762         (Simple.func20):
763         (Simple.func21):
764         (Derived1):
765         (Derived1.Derived1):
766         (Derived1.func22):
767         (Interface1):
768         (Interface2):
769         (Interface2.func23):
770         (Derived2):
771         (Derived2.Derived2):
772         (Derived2.func23):
773
774 2011-12-24  Kentaro Hara  <haraken@chromium.org>
775
776         Add unittests for the Python parser of prepare-ChangeLog
777         https://bugs.webkit.org/show_bug.cgi?id=75197
778
779         Reviewed by Ryosuke Niwa.
780
781         python_unittests.py is the unittest for get_function_line_ranges_for_python()
782         of prepare-ChangeLog. The unittest just contains classes and defs that are not nested.
783         This is because the current python parser is wrong, and it cannot correctly parse nested
784         classes and defs (even one def in a class), nor class inheritance.
785         We will fix it in another patch.
786
787         * Scripts/prepare-ChangeLog:
788         (get_function_line_ranges_for_python): Ignores comment lines that starts from #.
789         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
790         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt: Added.
791         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests.py: Added.
792         (func1):
793         (func2):
794         (func3):
795         (funcInsideComment):
796         (func4):
797         (func5):
798         (func6):
799         (funcOverloaded):
800         (Class1):
801
802 2011-12-24  Dan Bernstein  <mitz@apple.com>
803
804         Set SHARED_PRECOMPS_DIR when Xcode is set to use a custom build product path.
805
806         Reviewed by Anders Carlsson.
807
808         * Scripts/webkitdirs.pm:
809         (determineBaseProductDir):
810
811 2011-12-24  Dan Bernstein  <mitz@apple.com>
812
813         Make build-webkit aware of additional Xcode build location defaults.
814
815         Reviewed by Anders Carlsson.
816
817         * Scripts/webkitdirs.pm:
818         (determineXcodeVersion): Added. This was previously in determineBaseProductDir().
819         (readXcodeUserDefault): Added. Factored out from determineBaseProductDir().
820         (determineBaseProductDir): Changed to check for a custom build location
821         style specified as an absolute location.
822
823 2011-12-24  Ryosuke Niwa  <rniwa@webkit.org>
824
825         Unreviewed, rolling out r103619.
826         http://trac.webkit.org/changeset/103619
827         https://bugs.webkit.org/show_bug.cgi?id=66509
828
829         Broke chromium clang build
830
831         * DumpRenderTree/chromium/TestWebWorker.h:
832         (TestWebWorker::createWorker):
833         * DumpRenderTree/chromium/WebViewHost.cpp:
834         (WebViewHost::createWorker):
835         * DumpRenderTree/chromium/WebViewHost.h:
836
837 2011-12-23  Daniel Bates  <dbates@webkit.org>
838
839         Provide option to disable Mac OS 10.7 application resume when using
840         {debug, run}-{safari, minibrowser, test-runner, test-webkit-api}, and run-webkit-app
841         https://bugs.webkit.org/show_bug.cgi?id=66902
842
843         Reviewed by David Kilzer.
844
845         Add an optional command line argument --no-saved-state to disable
846         application resume (state restoration) for the session on Mac OS 10.7.
847
848         For instance, when debugging an issue in Safari it is useful to be able
849         to temporarily disable application resume. Currently you can disable
850         application resume when launching Safari from within Xcode. We should
851         expose a similar option in our command line tools.
852
853         * Scripts/debug-minibrowser: Call printHelpAndExitForRunAndDebugWebKitAppIfNeeded()
854         to print a help message and exit() if the command line argument --help was given.
855         * Scripts/debug-safari: Ditto.
856         * Scripts/debug-test-runner: Ditto.
857         * Scripts/run-minibrowser: Ditto.
858         * Scripts/run-safari: Ditto.
859         * Scripts/run-test-runner: Ditto.
860         * Scripts/run-test-webkit-api: Ditto.
861         * Scripts/run-webkit-app: Ditto.
862         * Scripts/webkitdirs.pm:
863         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Added.
864         (argumentsForRunAndDebugMacWebKitApp): Added.
865         (runMacWebKitApp): If the --no-saved-state command line argument was given then
866         disable application resume for the session.
867         (execMacWebKitAppForDebugging): Ditto.
868
869 2011-12-23  Dmitry Lomov  <dslomov@google.com>
870
871         [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
872         https://bugs.webkit.org/show_bug.cgi?id=66509
873         Just renames, merges and removal of dead code. Here are the list of renames:
874           - WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
875           - NewWebCommonWorkerClient renamed to WebCommonWorkerClient
876           - WebWorkerBase merged into WebSharedWorkerImpl
877           - NewWebWorkerBase renamed into WebWorkerBase
878  
879         Reviewed by David Levin.
880
881         * DumpRenderTree/chromium/TestWebWorker.h:
882         (TestWebWorker::createWorker):
883         * DumpRenderTree/chromium/WebViewHost.cpp:
884         (WebViewHost::createWorker):
885         * DumpRenderTree/chromium/WebViewHost.h:
886
887 2011-12-23  Kentaro Hara  <haraken@chromium.org>
888
889         Let parser_unittests.pl call different language parsers
890         https://bugs.webkit.org/show_bug.cgi?id=75081
891
892         Reviewed by David Kilzer.
893
894         We introduced parser_unittests.pl in bug 74994 , but it is implemented
895         to always call get_function_line_ranges_for_perl(). In order to enable unittests
896         for other languages, this patch lets parser_unittests.pl call different language
897         parsers depending on the languages.
898
899         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl
900
901         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
902
903 2011-12-22  Adam Roben  <aroben@apple.com>
904
905         Snow Leopard test fix
906
907         * Scripts/webkitpy/test/main.py:
908         (Tester.run_tests): Python 2.6.1 doesn't seem to like specifying testRunner=None to
909         unittest.main, even though that's the default. So now we explicitly specify a
910         TextTestRunner.
911
912 2011-12-22  Chris Fleizach  <cfleizach@apple.com>
913
914         AX: attributed strings do not include AXHeading information when a link is contained within the heading
915         https://bugs.webkit.org/show_bug.cgi?id=75059
916
917         Reviewed by Darin Adler.
918
919         Support the ability to check if an arbitrary attribute is present within an
920         attributed string that can be retrieved through an AccessibilityTextMarkerRange.
921
922         * DumpRenderTree/AccessibilityUIElement.cpp:
923         (attributedStringForTextMarkerRangeContainsAttributeCallback):
924         (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
925         (AccessibilityUIElement::getJSClass):
926         * DumpRenderTree/AccessibilityUIElement.h:
927         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
928         (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
929         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
930         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
931         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
932         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
933         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
934         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
935
936 2011-12-22  David Kilzer  <ddkilzer@apple.com>
937
938         run-api-tests: runAllTests() and runTest() should not use global variables
939
940         Reviewed by Adam Roben.
941
942         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
943
944         * Scripts/run-api-tests:
945         (runTestsBySuite): Rename from runAllTests().  Add arguments for
946         list of tests and $verbose.
947         (runTest): Add $verbose argument.
948
949 2011-12-22  David Kilzer  <ddkilzer@apple.com>
950
951         run-api-tests: inline runAllTestsInSuite() into runAllTests()
952
953         Reviewed by Adam Roben.
954
955         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
956
957         In order to make it easy to run one or more individual suites,
958         or one more individual tests, it's easier to call a single
959         method with different data structures than individual methods.
960
961         * Scripts/run-api-tests:
962         (runAllTests): Inline runAllTestsInSuite().
963
964 2011-12-22  Adam Roben  <aroben@apple.com>
965
966         Add a --xml flag to test-webkitpy
967
968         test-webkitpy --xml will, in addition to providing the standard text output on stdout, write
969         JUnit-style XML files to a test-webkitpy-xml-reports subdirectory in the working directory.
970         This is useful for working with tools that consume JUnit-style XML files.
971
972         Fixes <http://webkit.org/b/75090> Would like a way to generate JUnit-style XML files when
973         running test-webkitpy
974
975         Reviewed by Darin Adler.
976
977         * Scripts/webkitpy/test/main.py:
978         (Tester.run_tests): If the --xml flag is passed, create an XMLTestRunner and pass it to
979         unittest.main(). Otherwise pass no test runner so that unittest will choose its own default.
980
981         * Scripts/webkitpy/thirdparty/__init__.py:
982         (AutoinstallImportHook.find_module):
983         (AutoinstallImportHook._install_xmlrunner):
984         Added code to install unittest-xml-reporting as webkitpy.thirdparty.autoinstalled.xmlrunner.
985         This change is untested because it's basically impossible to get a test to pass when --xml
986         is passed to test-webkitpy (because xmlrunner will already have been imported by the time
987         the test runs).
988
989 2011-12-22  David Kilzer  <ddkilzer@apple.com>
990
991         TestWebKitAPI: initialize the main thread before running tests
992         <http://webkit.org/b/75064>
993
994         Reviewed by Adam Roben.
995
996         * TestWebKitAPI/TestsController.cpp:
997         (TestWebKitAPI::TestsController::TestsController): Call
998         WTF::initializeMainThread() to prevent assertions in Debug
999         builds.
1000
1001 2011-12-22  David Kilzer  <ddkilzer@apple.com>
1002
1003         run-api-tests: dumpAllTests() should not use global variables
1004
1005         Reviewed by Adam Roben.
1006
1007         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
1008
1009         * Scripts/run-api-tests: Renamed $dump to $dumpTests.
1010         (dumpTestsBySuite): Rename from dumpAllTests() and pass in
1011         global data as an argument.  Sort suite names and test names
1012         alphabetically to match output when running tests.
1013
1014 2011-12-22  Leo Yang  <leo.yang@torchmobile.com.cn>
1015
1016         [BlackBerry] Enable blob for the BlackBerry porting
1017         https://bugs.webkit.org/show_bug.cgi?id=75074
1018
1019         Reviewed by George Staikos.
1020
1021         * Scripts/build-webkit:
1022
1023 2011-12-22  Kentaro Hara  <haraken@chromium.org>
1024
1025         Add unittests for the Perl parser of prepare-ChangeLog
1026         https://bugs.webkit.org/show_bug.cgi?id=74994
1027
1028         Reviewed by David Kilzer.
1029
1030         This patch adds unittests for get_function_line_ranges_for_perl() of prepare-ChangeLog.
1031
1032         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl
1033
1034         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl: Added.
1035         Runs unittests specified in @testFiles.
1036         You can reset expected results by specifying a --reset-results option.
1037         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl: Added.
1038         Contains simple methods.
1039         (func1):
1040         (func2):
1041         (func3):
1042         (func4):
1043         (func5):
1044         (func6):
1045         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt: Added.
1046         This test result is generated by the --reset-results option.
1047
1048 2011-12-21  Eric Seidel  <eric@webkit.org>
1049
1050         Add webkit.review.bot@gmail.com and commit-queue@webkit.org as "contributors"
1051         so that they appear in the bugzilla autocomplete CC list.
1052         I also removed the "radar" irc nick (which I believe does not exist)
1053         and removed the uneeded [] around the radar bugzilla email.
1054
1055         Unreviewed.
1056
1057         * Scripts/webkitpy/common/config/committers.py:
1058
1059 2011-12-21  Daniel Bates  <dbates@rim.com>
1060
1061         Teach build-jsc how to build JavaScriptCore for the EFL, BlackBerry, and WinCE ports
1062         https://bugs.webkit.org/show_bug.cgi?id=74985
1063
1064         Reviewed by Eric Seidel.
1065
1066         * Scripts/build-jsc:
1067         * Scripts/webkitdirs.pm:
1068         (cmakeBasedPortName): Added.
1069
1070 2011-12-21  Daniel Bates  <dbates@rim.com>
1071
1072         Extract BlackBerry CMake arguments from build-webkit into separate function
1073         https://bugs.webkit.org/show_bug.cgi?id=74981
1074
1075         Reviewed by Rob Buis.
1076
1077         Towards adding support for using Tools/Scripts/build-jsc for the BlackBerry port, move
1078         the CMake argument logic from Tools/Scripts/build-webkit to function webkitdirs::blackberryCMakeArguments()
1079         and have cmakeBasedPortArguments() call this function for the BlackBerry CMake argument list.
1080         This will allow us to get the BlackBerry CMake arguments in Tools/Scripts/build-jsc so
1081         that we can pass them to the CMake build system when building JavaScriptCore.
1082
1083         * Scripts/build-webkit: Move construction of CMake argument list from here to
1084         webkitdirs::blackberryCMakeArguments(). Also, remove exported function blackberryTargetArchitecture()
1085         since it's only called within webkitdirs.pm now. Formerly we exported this function so that we could
1086         call it from build-webkit.
1087         * Scripts/webkitdirs.pm:
1088         (blackberryCMakeArguments): Added.
1089         (cmakeBasedPortArguments): Modified to call blackberryCMakeArguments() when building the
1090         BlackBerry port.
1091
1092 2011-12-21  Daniel Bates  <dbates@webkit.org>
1093
1094         Extract WinCE CMake arguments from build-webkit into separate function
1095         https://bugs.webkit.org/show_bug.cgi?id=74983
1096
1097         Reviewed by Rob Buis.
1098
1099         Towards adding support for using Tools/Scripts/build-jsc for the WinCE port, extract the
1100         WinCE-specific CMake argument from Tools/Scripts/build-webkit into webkitdirs::cmakeBasedPortArguments().
1101         This will allow us to get the WinCE-specific CMake argument in Tools/Scripts/build-jsc so
1102         that we can pass it to the CMake build system when building JavaScriptCore.
1103
1104         * Scripts/build-webkit:
1105         * Scripts/webkitdirs.pm:
1106         (cmakeBasedPortArguments): Added.
1107
1108 2011-12-21  Kentaro Hara  <haraken@chromium.org>
1109
1110         In prepare-ChangeLog, replace constant global variables with "use constant"
1111         https://bugs.webkit.org/show_bug.cgi?id=74992
1112
1113         Reviewed by Ryosuke Niwa.
1114
1115         This patch replaces the following constant global variables with "use constant"s.
1116             - $changeLogTimeZone
1117             - $SVN
1118             - $GIT
1119             - %supportedTestExtensions
1120
1121         * Scripts/prepare-ChangeLog:
1122         (changeLogNameFromArgs):
1123         (changeLogEmailAddressFromArgs):
1124         (resolveConflictedChangeLogs):
1125         (generateNewChangeLogs):
1126         (diffCommand):
1127         (statusCommand):
1128         (createPatchCommand):
1129         (findOriginalFileFromSvn):
1130         (determinePropertyChanges):
1131         (generateFileList):
1132         (reviewerAndDescriptionForGitCommit):
1133
1134 2011-12-20  Dirk Pranke  <dpranke@chromium.org>
1135
1136         nrwt: rename field references from _fs to _filesystem
1137         https://bugs.webkit.org/show_bug.cgi?id=74898
1138
1139         Reviewed by Adam Barth.
1140
1141         This is a simple cleanup; most of the code uses
1142         self._filesystem, but some used self._fs; this change renames
1143         the latter to the former to be more consistent.
1144
1145         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1146         (Manager.__init__):
1147         (Manager.collect_tests):
1148         (Manager._strip_test_dir_prefix):
1149         (Manager._split_into_chunks_if_necessary):
1150         (Manager.results_directory):
1151         (Manager._clobber_old_results):
1152         (Manager._upload_json_files):
1153         (Manager.print_config):
1154         (Manager._copy_results_html_file):
1155         (Manager._show_results_html_file):
1156         (Manager._log_worker_stack):
1157         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1158         (JSONLayoutResultsGenerator._normalize_results_json):
1159         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1160         (JSONResultsGeneratorBase.__init__):
1161         (JSONResultsGeneratorBase.generate_json_output):
1162         (JSONResultsGeneratorBase.generate_times_ms_file):
1163         (JSONResultsGeneratorBase.upload_json_files):
1164         (JSONResultsGeneratorBase._get_svn_revision):
1165         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1166         (Base.__init__):
1167
1168 2011-12-20  Kentaro Hara  <haraken@chromium.org>
1169
1170         Replace webkitperl/run-leaks_unittest/RunLeaks.pm with webkitperl/LoadAsModule.pm
1171         https://bugs.webkit.org/show_bug.cgi?id=74836
1172
1173         Reviewed by David Kilzer.
1174
1175         webkitperl/run-leaks_unittest/RunLeaks.pm can be used for unit-testing of run-leaks only.
1176         This patch creates more generalized webkitperl/LoadAsModule.pm, which can be also used
1177         for unit-testing of other Perl scripts. We are planning to use it for unit-testing
1178         of prepare-ChangeLog.
1179
1180         Using LoadAsModule.pm, you can load a Perl script as follows.
1181         The first argument is the arbitrary package name you want to use, and the second argument
1182         is the name of the Perl script you want to load.
1183
1184             use LoadAsModule qw(RunLeaks run-leaks);
1185             RunLeaks::someFunctionDefinedInRunLeaks(...);
1186
1187         Tests: Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl
1188                Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl
1189                Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl
1190
1191         * Scripts/webkitperl/LoadAsModule.pm: Added.
1192         * Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Removed.
1193         (import):
1194         (readFile):
1195         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl: Used LoadAsModule instead of RunLeaks.
1196         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
1197         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.
1198
1199 2011-12-20  Balazs Kelemen  <kbalazs@webkit.org>
1200
1201         [Qt] WK2 Debugging quirks need some improvement
1202         https://bugs.webkit.org/show_bug.cgi?id=74859
1203
1204         Reviewed by Simon Hausmann.
1205
1206         Improvements added to make debugging WebKit2 more
1207         confortable and efficient:
1208         1. Unify debugging quirks. From now all of them are controlled
1209         by the QT_WEBKIT2_DEBUG environment variable.
1210         2. Disable crash handlers for WebKitTestRunner if debugging quirks
1211         are used to make it possible to use postmortem debugging via core dumps
1212         which is extremely useful for debugging bugs triggered by layout tests.
1213         3. Disable test timeout for WebKitTestRunner if debugging quirks
1214         are used because that makes debugging impossible.
1215
1216         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
1217         (WTR::InjectedBundle::platformInitialize):
1218         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
1219         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
1220         * WebKitTestRunner/qt/TestControllerQt.cpp:
1221         (WTR::TestController::platformRunUntil):
1222
1223 2011-12-20  Rafael Brandao  <rafael.lobo@openbossa.org>
1224
1225         [Qt][WK2] Implement favicon support
1226         https://bugs.webkit.org/show_bug.cgi?id=71082
1227
1228         Reviewed by Simon Hausmann.
1229
1230         A favorite icon was added on MiniBrowser's url bar as example.
1231         We display a default icon when the page doesn't have an icon ready.
1232
1233         * MiniBrowser/qt/MiniBrowser.qrc:
1234         * MiniBrowser/qt/icons/favicon.png: Added.
1235         * MiniBrowser/qt/qml/BrowserWindow.qml:
1236
1237 2011-12-19  Sam Weinig  <sam@webkit.org>
1238
1239         Add support for scrollLineDown: and scrollLineUp: NSResponder selectors
1240         https://bugs.webkit.org/show_bug.cgi?id=74907
1241
1242         Reviewed by Dan Bernstein.
1243
1244         Add ScrollByLineCommands API test.
1245
1246         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1247         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm: Added.
1248         * TestWebKitAPI/Tests/WebKit2/simple-tall.html: Added.
1249
1250 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
1251
1252         webkitpy: remove port.executive, port.filesystem, port.user properties
1253         https://bugs.webkit.org/show_bug.cgi?id=74896
1254
1255         Reviewed by Eric Seidel.
1256
1257         Following on the refactoring of the port and host objects, this
1258         removes the public executive, filesystem, and user properties
1259         from the Port interface (protected versions of executive and
1260         filesystem still exist). There is still some more clean up to
1261         make the code more consistent and rearrange some other files to
1262         talk to Hosts directly instead of getting them off of the Port
1263         class.
1264
1265         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1266         (Manager.__init__):
1267         (Manager.results_directory):
1268         (Manager._log_worker_stack):
1269         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1270         (ManagerTest.test_fallback_path_in_config):
1271         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1272         (_InlineManager.start_worker):
1273         (_InlineWorkerConnection.__init__):
1274         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1275         (Worker.safe_init):
1276         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
1277         (TestConfiguration.from_port):
1278         * Scripts/webkitpy/layout_tests/port/base.py:
1279         (Port.__init__):
1280         (Port.tests):
1281         (Port.show_results_html_file):
1282         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1283         (PortTest.test_layout_tests_skipping):
1284         (PortTest.test_test_dirs):
1285         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1286         (_set_up_derived_options):
1287         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1288         (PerfTestsRunner.__init__):
1289         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1290         (HtmlGenerator.__init__):
1291         (HtmlGenerator.show_html):
1292         (real_main):
1293         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
1294         (TestHtmlGenerator.make_generator):
1295
1296 2011-12-19  Daniel Bates  <dbates@webkit.org>
1297
1298         Pass command line arguments to GDB when debugging a Mac WebKit application
1299         https://bugs.webkit.org/show_bug.cgi?id=72829
1300
1301         Reviewed by David Kilzer.
1302
1303         Pass through any command line arguments given to debug-{safari, minibrowser}
1304         to GDB so that they may influence the application instance launched by GDB.
1305
1306         * Scripts/webkitdirs.pm:
1307         (execMacWebKitAppForDebugging):
1308
1309 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
1310
1311         webkitpy: remove executive,filesystem,user parameters from Port constructor
1312         https://bugs.webkit.org/show_bug.cgi?id=74878
1313
1314         Reviewed by Eric Seidel.
1315
1316         This change concludes the refactoring that makes Host a required
1317         parameter for Port and ensures that all access to filesystem,
1318         executives, etc. is going through the Host.
1319
1320         * Scripts/webkitpy/layout_tests/port/base.py:
1321         (Port.__init__):
1322
1323 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
1324
1325         webkitpy: finish refactoring port classes to make a host mandatory
1326         https://bugs.webkit.org/show_bug.cgi?id=74566
1327
1328         Reviewed by Eric Seidel.
1329
1330         This change makes all Port objects take a required (System)Host
1331         parameter, and updates the TestPort object to no longer create a
1332         mock filesystem or add files to the existing filesystem by
1333         default.
1334
1335         * Scripts/webkitpy/layout_tests/port/base.py:
1336         (Port.__init__):
1337         * Scripts/webkitpy/layout_tests/port/factory.py:
1338         (PortFactory.__init__):
1339         (PortFactory._get_kwargs):
1340         * Scripts/webkitpy/layout_tests/port/test.py:
1341         (TestInstance.__init__):
1342         (TestPort.__init__):
1343         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1344         (passing_run):
1345         (logging_run):
1346         (get_tests_run):
1347         (MainTest.test_single_file):
1348         (MainTest.test_stderr_is_saved):
1349         (MainTest.test_test_list):
1350         (MainTest.test_test_list_with_prefix):
1351         (MainTest.test_missing_and_unexpected_results):
1352         (MainTest.test_missing_and_unexpected_results_with_custom_exit_code):
1353         (MainTest.test_crash_with_stderr):
1354         (MainTest.test_no_image_failure_with_image_diff):
1355         (MainTest.test_crash_log):
1356         (MainTest.test_web_process_crash_log):
1357         (MainTest.test_exit_after_n_failures_upload):
1358         (MainTest.test_results_directory_absolute):
1359         (MainTest.test_results_directory_relative):
1360         (MainTest.test_retries_directory):
1361         (MainTest.test_tolerance.get_port_for_run):
1362         (MainTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
1363         (EndToEndTest.test_end_to_end):
1364         (EndToEndTest.test_reftest_with_two_notrefs):
1365         (RebaselineTest.test_reset_results):
1366         (RebaselineTest.test_missing_results):
1367         (RebaselineTest.test_new_baseline):
1368         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1369         (Rebaseliner.__init__):
1370         (main):
1371         (real_main):
1372         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
1373         (test_host_port_and_filesystem):
1374         (TestRebaseliner.make_rebaseliner):
1375         (TestRealMain.test_all_platforms):
1376         (TestHtmlGenerator.make_generator):
1377
1378 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
1379
1380         webkitpy: update unit tests in preparation for making host a mandatory parameter to Port objects
1381         https://bugs.webkit.org/show_bug.cgi?id=74562
1382
1383         Reviewed by Eric Seidel.
1384
1385         Apart from a minor change to style/checkers/test_expectations.py
1386         to take a host as a parameter to a TestExpectationsChecker(),
1387         there are only refactoring changes to unit tests here.
1388
1389         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
1390         (TestResultWriterTest.test_reftest_diff_image):
1391         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1392         (JSONGeneratorTest._test_json_generation):
1393         (JSONGeneratorTest.test_test_timings_trie):
1394         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1395         (Base.__init__):
1396         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1397         (PortTest.make_port):
1398         (PortTest.test_layout_tests_skipping):
1399         (PortTest.test_test_dirs):
1400         (PortTest.test_additional_platform_directory):
1401         (PortTest.test_uses_test_expectations_file):
1402         (PortTest.test_find_no_paths_specified):
1403         (PortTest.test_find_one_test):
1404         (PortTest.test_find_glob):
1405         (PortTest.test_find_with_skipped_directories):
1406         (PortTest.test_find_with_skipped_directories_2):
1407         (PortTest.test_parse_reftest_list):
1408         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1409         (DryRunPort.__init__):
1410         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1411         (FactoryTest.setUp):
1412         (FactoryTest.tearDown):
1413         (FactoryTest.assert_port):
1414         (FactoryTest.assert_platform_port):
1415         (FactoryTest.test_unknown_specified):
1416         (FactoryTest.test_unknown_default):
1417         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1418         (GetGoogleChromePortTest._verify_expectations_overrides):
1419         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1420         (MockDRTPortTest.make_port):
1421         (MockDRTTest.assertTest):
1422         (MockDRTTest.test_main):
1423         (MockChromiumDRTTest.test_pixeltest__fails):
1424         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1425         (QtPortTest._assert_search_path):
1426         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1427         (TestWebKitPort.__init__):
1428         (WebKitPortTest.test_skipped_directories_for_symbols):
1429         (test_skipped_directories_for_features):
1430         (test_skipped_layout_tests):
1431         (test_skipped_file_search_paths):
1432         (test_root_option):
1433         (test_test_expectations):
1434         (test_build_driver):
1435         (test_linux_distro_detection):
1436         (test_apache_config_file_name_for_platform):
1437         (test_path_to_apache_config_file):
1438         (WebKitDriverTest.test_read_block):
1439         * Scripts/webkitpy/style/checkers/test_expectations.py:
1440         (TestExpectationsChecker.__init__):
1441         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1442         (TestExpectationsTestCase._expect_port_for_expectations_path):
1443         (TestExpectationsTestCase.assert_lines_lint):
1444         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
1445         (get_test_config.TestMacPort):
1446
1447 2011-12-19  Raphael Kubo da Costa  <kubo@profusion.mobi>
1448
1449         [Efl] Fix path returned by builtDylibPathForName in webkitdirs.pm
1450         https://bugs.webkit.org/show_bug.cgi?id=74854
1451
1452         Reviewed by Csaba Osztrogonác.
1453
1454         Since r101052, libewebkit.so is built in a different location, so we
1455         need to adjust the path returned by builtDylibPathForName.
1456
1457         usesPerConfigurationBuildDirectory also needs to be fixed, as the Efl
1458         port also respects Release/Debug configurations.
1459
1460         These changes should make run-launcher finally work correctly with
1461         webkit-efl.
1462
1463         * Scripts/webkitdirs.pm:
1464         (usesPerConfigurationBuildDirectory):
1465         (builtDylibPathForName):
1466
1467 2011-12-19  Simon Hausmann  <simon.hausmann@nokia.com>
1468
1469         [Qt][WK2] Add support for modal event loop processing for WTR
1470         https://bugs.webkit.org/show_bug.cgi?id=74852
1471
1472         Reviewed by Kenneth Rohde Christiansen.
1473
1474         Rewrote event loop processing: Instead of terminating the event loop
1475         in notifyDone() - something no other platform does - we now respect the
1476         "bool& condition" parameter passed to platformRunUntil. This ensures
1477         proper termination even when the condition is changed from within a
1478         nested event loop, because only when we _exit_ from the nested event
1479         loop we will check the condition and terminate the test properly.
1480
1481         In addition this patch implements TestController::runModal by means of
1482         a nested event loop, which is passed to the platform webview that is
1483         supposed to be modal. It is that view's responsibility to exit the
1484         loop, upon destruction. I believe that's similar to how it works on the Mac,
1485         where it doesn't seem that NSApp's runModalForWindow is terminate via
1486         abort/stopModal but simply because the window is closed.
1487
1488         * WebKitTestRunner/PlatformWebView.h:
1489         (WTR::PlatformWebView::setModalEventLoop):
1490         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1491         (WTR::PlatformWebView::PlatformWebView):
1492         (WTR::PlatformWebView::~PlatformWebView):
1493         * WebKitTestRunner/qt/TestControllerQt.cpp:
1494         (WTR::TestController::notifyDone):
1495         (WTR::TestController::platformRunUntil):
1496         (WTR::TestController::runModal):
1497
1498 2011-12-18  Kentaro Hara  <haraken@chromium.org>
1499
1500         REGRESSION(r103149): prepare-ChangeLog outputs a warning
1501         https://bugs.webkit.org/show_bug.cgi?id=74808
1502
1503         Reviewed by David Kilzer.
1504
1505         Added the prototype declaration of main() to avoid warning messages.
1506         Sorted subroutine declarations in the alphabetical order.
1507
1508         * Scripts/prepare-ChangeLog:
1509
1510 2011-12-17  Adenilson Cavalcanti  <cavalcantii@gmail.com>
1511
1512         [Qt] Fix QtTestBrowser compilation with QtWidgets module
1513         https://bugs.webkit.org/show_bug.cgi?id=74791
1514
1515         Reviewed by Andreas Kling.
1516
1517         * QtTestBrowser/QtTestBrowser.pro:
1518
1519 2011-12-17  Kentaro Hara  <haraken@chromium.org>
1520
1521         Remove top-level code completely from prepare-ChangeLog
1522         https://bugs.webkit.org/show_bug.cgi?id=74698
1523
1524         Reviewed by Darin Adler.
1525
1526         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest manner.
1527         This patch just moves all top-level code into main().
1528
1529         * Scripts/prepare-ChangeLog:
1530         (main):
1531
1532 2011-12-16  Dean Jackson  <dino@apple.com>
1533
1534         Move webkit-bug-importer to Contributor. It won't
1535         autocomplete as an Account.
1536         See https://bugs.webkit.org/show_bug.cgi?id=74739
1537         for some discussion.
1538
1539         Unreviewed.
1540
1541         * Scripts/webkitpy/common/config/committers.py:
1542
1543 2011-12-16  Dean Jackson  <dino@apple.com>
1544
1545         Add webkit-bug-importer@group.apple.com to accounts
1546         so that it autocompletes in bugzilla.
1547
1548         Unreviewed.
1549
1550         * Scripts/webkitpy/common/config/committers.py:
1551
1552 2011-12-16  Philippe Normand  <pnormand@igalia.com>
1553
1554         Unreviewed, skipping 3 failing GTK API tests.
1555
1556         * Scripts/run-gtk-tests:
1557
1558 2011-12-16  Philippe Normand  <pnormand@igalia.com>
1559
1560         Unreviewed, GTK API tests build fix attempt.
1561
1562         * Scripts/run-gtk-tests: Run xvfb on a display not used by NRWT.
1563
1564 2011-12-16  Philippe Normand  <pnormand@igalia.com>
1565
1566         Unreviewed, unskipping GTK testdownload. Should pass on the bot now.
1567
1568         * Scripts/run-gtk-tests:
1569
1570 2011-12-16  Simon Hausmann  <simon.hausmann@nokia.com>
1571
1572         [Qt] Fix the build for newer Qt5
1573         https://bugs.webkit.org/show_bug.cgi?id=74703
1574
1575         Reviewed by Csaba Osztrogonác.
1576
1577         * QtTestBrowser/launcherwindow.h: Add missing forward declaration.
1578         * DumpRenderTree/qt/EventSenderQt.cpp:
1579         (EventSender::sendTouchEvent): Allocate QTouchDevice and use with QTouchEvent constructor.
1580         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Ditto.
1581         (WTR::EventSenderProxy::sendTouchEvent):
1582         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1583         (MiniBrowserApplication::sendTouchEvent): Ditto.
1584         (MiniBrowserApplication::notify): Adapt to changed API for marking primary touch point.
1585
1586 2011-12-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1587
1588         [Qt] Detect and force clean build when feature defines are added
1589
1590         Reviewed by Ossy.
1591
1592         https://bugs.webkit.org/show_bug.cgi?id=74689
1593
1594         * Scripts/webkitdirs.pm:
1595
1596 2011-12-16  Kentaro Hara  <haraken@chromium.org>
1597
1598         [Refactoring] Remove all global variables from prepare-ChangeLog
1599         https://bugs.webkit.org/show_bug.cgi?id=74681
1600
1601         Reviewed by Ryosuke Niwa.
1602
1603         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
1604         manner. This bug is one of the incremental refactorings to remove all top-level
1605         code and global variables from prepare-ChangeLog. In this patch,
1606         we make the following global variables be used only through parameter passing.
1607         This patch removes all global variables from prepare-ChangeLog.
1608             - $mergeBase
1609             - $gitCommit
1610             - $gitIndex
1611
1612         * Scripts/prepare-ChangeLog:
1613         (generateFunctionLists):
1614         (changeLogNameFromArgs):
1615         (changeLogEmailAddressFromArgs):
1616         (generateNewChangeLogs):
1617         (printDiff):
1618         (diffFromToString):
1619         (diffCommand):
1620         (statusCommand):
1621         (createPatchCommand):
1622         (generateFileList):
1623         (isConflictStatus):
1624
1625 2011-12-15  Philippe Normand  <pnormand@igalia.com>
1626
1627         [GTK] Rounding errors on 32-bit machines causes tests to fail
1628         https://bugs.webkit.org/show_bug.cgi?id=72254
1629
1630         Initial patch by vanuan@gmail.com.
1631         Reviewed by Martin Robinson.
1632
1633         * Scripts/webkitdirs.pm:
1634         (runAutogenForAutotoolsProjectIfNecessary): Pass additional
1635         CXXFLAGS to autogen in an attempt to harmonize floating point
1636         values between 32-bit and 64-bit architectures.
1637
1638 2011-12-16  Martin Robinson  <mrobinson@igalia.com>
1639
1640         [GTK] Make distcheck fails during the install
1641         https://bugs.webkit.org/show_bug.cgi?id=74274
1642
1643         No review, since this is a build fix.
1644
1645         * GNUmakefile.am: Remove BUILT_SOURCES from the dependency list for the gtkdoc
1646         step. BUILT_SOURCES includes forwarding header generation for WebKit2, which
1647         always runs. This means that the gtkdoc step was always running when make was
1648         invoked. Generating gtkdoc during 'make install' was triggering a race condition
1649         with the library file. Later we can fix generate-forwarding-headers and unbreak
1650         'make docs,' but this bandaid is sufficient to let us release.
1651
1652 2011-12-15  Eric Seidel  <eric@webkit.org>
1653
1654         NRWT should use free + inactive memory for default_child_processes on OS X (and never return < 1 process)
1655         https://bugs.webkit.org/show_bug.cgi?id=74650
1656
1657         Reviewed by Adam Barth.
1658
1659         * Scripts/webkitpy/common/system/platforminfo.py:
1660         (PlatformInfo._compute_bytes_from_vm_stat_output):
1661         * Scripts/webkitpy/layout_tests/port/base.py:
1662         (Port.default_child_processes):
1663         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1664         (PortTest.test_default_child_processes):
1665
1666 2011-12-15  Filip Pizlo  <fpizlo@apple.com>
1667
1668         bencher script should support remote benchmarking on platforms that don't have ruby
1669         https://bugs.webkit.org/show_bug.cgi?id=74659
1670
1671         Rubber-stamped by Sam Weinig.
1672         
1673         Added the ability to have bencher generate a benchmarking playload that consists of
1674         copies of all of the benchmarks, optionally copies of all of the frameworks and
1675         binaries to run all of the VMs, and a sh script that runs the benchmarks in random
1676         order, which then spits out a raw results file that bencher can parse.
1677         
1678         In normal operating mode, you never see this, as it just generates the payload and
1679         script internally, runs it, parses the results, and spits them out.
1680         
1681         The --remote mode has been changed to use this style, so any remote host that has
1682         sshd, passwordless login support, a ~/.bencher file that points to a "tempPath", and
1683         a sh-compatible shell can be used for remote benchmarking.
1684         
1685         The feature to include VMs in the benchmarking payload is by default only activated
1686         when using --remote, but it can also be activated when doing local benchmarking; the
1687         benefit is that you remove any pathname-related performance pathologies. All VMs
1688         become equal because they are all located in
1689         /path/to/bencher/directory/temp/benchdata/vmN where N is the configuration number
1690         (usually 0 or 1).
1691         
1692         Also fixed bugs in the DumpRenderTree support. It's now possible to run all benchmarks
1693         through DumpRenderTree. This is only a bit slower than running in jsc.
1694
1695         * Scripts/bencher:
1696
1697 2011-12-15  Dirk Pranke  <dpranke@chromium.org>
1698
1699         webkitpy: clean up TestPort to (mostly) not create a new filesystem
1700         https://bugs.webkit.org/show_bug.cgi?id=74556
1701
1702         This change modifies the TestPort to be ready to add tests to an
1703         existing filesystem instead of creating a new filesystem; we
1704         leave unit_test_filesystem() in for now for compatibility.
1705
1706         * Scripts/webkitpy/common/host_mock.py:
1707         (MockHost.__init__):
1708           - call add_unit_tests_to_mock_filesystem by default to make
1709             the MockHost more generally useful for layout_test unit tests.
1710         * Scripts/webkitpy/layout_tests/port/test.py:
1711         (TestInstance.__init__):
1712         (add_unit_tests_to_mock_filesystem):
1713         (add_file):
1714         (unit_test_filesystem):
1715         (TestPort.__init__):
1716         (TestPort._set_default_overriding_none):
1717
1718 2011-12-15  Dirk Pranke  <dpranke@chromium.org>
1719
1720         webkitpy: cleanup prior to systemhostifying the layout_test/port* classes
1721         https://bugs.webkit.org/show_bug.cgi?id=74551
1722
1723         This is some minor cleanup prior to making all of the host/port
1724         changes described in bug 74138.
1725
1726         * Scripts/webkitpy/common/host_mock.py:
1727         (MockHost.__init__):
1728           - make sure the scm object is initialized with the same mock
1729             executive and filesystem objects.
1730
1731         * Scripts/webkitpy/common/system/filesystem_mock.py:
1732         (MockFileSystem.clear_written_files):
1733           - add a routine that will be useful in testing.
1734         (MockFileSystem.maybe_make_directory):
1735         (MockFileSystem.write_binary_file):
1736           - fix bugs to make sure directories are created properly.
1737         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1738         (_Process.run):
1739           - add clarifying comments.
1740         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1741         (MockDRTPort.__init__):
1742         (MockDRT.__init__):
1743           - add clarifying comments.
1744
1745 2011-12-15  Anders Carlsson  <andersca@apple.com>
1746
1747         Regression (r102866): Navigating away from or closing a page with a plugin crashes
1748         https://bugs.webkit.org/show_bug.cgi?id=74655
1749
1750         Reviewed by Sam Weinig.
1751
1752         Add a bunch of tests.
1753
1754         * TestWebKitAPI/Tests/WTF/Functional.cpp:
1755
1756 2011-12-15  Stephanie Lewis  <slewis@apple.com>
1757
1758         https://bugs.webkit.org/show_bug.cgi?id=74469
1759         Escape paths to svn commands so our tools can handle filenames with @ symbols.
1760
1761         Reviewed by Adam Roben.
1762
1763         * Scripts/VCSUtils.pm:
1764         (scmMoveOrRenameFile):
1765         (scmAddExecutableBit):
1766         (scmRemoveExecutableBit):
1767         (determineSVNRoot):
1768         (svnRevisionForDirectory):
1769         (pathRelativeToSVNRepositoryRootForPath):
1770         (svnStatus):
1771         (escapeSubversionPath):
1772         * Scripts/parse-malloc-history:
1773         (main):
1774         * Scripts/prepare-ChangeLog:
1775         (diffCommand):
1776         (statusCommand):
1777         (findOriginalFileFromSvn):
1778         (determinePropertyChanges):
1779         * Scripts/resolve-ChangeLogs:
1780         (conflictFiles):
1781         (resolveConflict):
1782         (showStatus):
1783         * Scripts/svn-apply:
1784         (patch):
1785         (scmCopy):
1786         (scmAdd):
1787         (scmRemove):
1788         * Scripts/svn-create-patch:
1789         (findBaseUrl):
1790         (findMimeType):
1791         (findSourceFileAndRevision):
1792         (generateDiff):
1793         (generateFileList):
1794         (manufacturePatchForAdditionWithHistory):
1795         * Scripts/svn-unapply:
1796         (patch):
1797         (revertDirectories):
1798
1799 2011-12-15  Michael Bruning  <michael.bruning@nokia.com>
1800
1801         [qt][wk2] MiniBrowser: Add pressed state for viewport info button.
1802         https://bugs.webkit.org/show_bug.cgi?id=74617
1803
1804         Reviewed by Kenneth Rohde Christiansen.
1805
1806         * MiniBrowser/qt/qml/BrowserWindow.qml: Added state dependent coloring
1807         for viewport info button, adjusted height and added rounded corners.
1808
1809 2011-12-15  Andy Estes  <aestes@apple.com>
1810
1811         TestFailures: store the name of the buildbot results directory in a property
1812         https://bugs.webkit.org/show_bug.cgi?id=74663
1813
1814         Reviewed by Adam Barth.
1815         
1816         Store the name of the results directory as a property on Buildbot's
1817         prototype. This allows subclasses of Buildbot to customize the results
1818         directory.
1819
1820         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js:
1821         (Buildbot.prototype.resultsDirectoryURL):
1822
1823 2011-12-15  Tony Chang  <tony@chromium.org>
1824
1825         [chromium] pass --delete_unversioned_trees to gclient on the bots
1826         https://bugs.webkit.org/show_bug.cgi?id=74565
1827
1828         Reviewed by Kenneth Russell.
1829
1830         It was temporarily removed in r102891 to keep the bots green.  Now
1831         that the bots have cycled, we can add it back.
1832
1833         * Scripts/update-webkit-chromium:
1834
1835 2011-12-15  Kentaro Hara  <haraken@chromium.org>
1836
1837         [Refactoring] In prepare-ChangeLog, make several global variables be used only through parameter passing
1838         https://bugs.webkit.org/show_bug.cgi?id=74497
1839
1840         Reviewed by Ryosuke Niwa.
1841
1842         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
1843         manner. This bug is one of the incremental refactorings to remove all top-level
1844         code and global variables from prepare-ChangeLog. In this patch,
1845         we make the following global variables be used only through parameter passing.
1846             - $bugDescription
1847             - $bugNumber
1848             - $name
1849             - $emailAddress
1850             - $gitReviewer
1851             - $writeChangeLogs
1852
1853         * Scripts/prepare-ChangeLog:
1854         (fetchBugDescriptionFromURL):
1855         (generateNewChangeLogs):
1856         (reviewerAndDescriptionForGitCommit):
1857
1858 2011-12-15  Raphael Kubo da Costa  <kubo@profusion.mobi>
1859
1860         [EFL] Add a few more web database functions to ewk_settings.
1861         https://bugs.webkit.org/show_bug.cgi?id=72148
1862
1863         Reviewed by Antonio Gomes.
1864
1865         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1866         (LayoutTestController::clearAllDatabases):
1867         (LayoutTestController::setDatabaseQuota):
1868
1869 2011-12-15  Martin Kosiba  <mkosiba@google.com>
1870
1871         Fix find on web pages with -webkit-user-select: none for Chromium
1872         https://bugs.webkit.org/show_bug.cgi?id=72281
1873
1874         Reviewed by Ryosuke Niwa.
1875
1876         Provided a partial findString implementation. This doesn't support
1877         all of the FindOptions since they're not exposed via WebFindOptions.
1878
1879         * DumpRenderTree/chromium/LayoutTestController.cpp:
1880         (LayoutTestController::LayoutTestController):
1881         (LayoutTestController::findString):
1882         * DumpRenderTree/chromium/LayoutTestController.h:
1883
1884 2011-12-15  Kenneth Russell  <kbr@google.com>
1885
1886         [chromium] Add DRT support for WebKitPageCacheSupportsPluginsPreferenceKey
1887         https://bugs.webkit.org/show_bug.cgi?id=74581
1888
1889         Reviewed by Darin Fisher.
1890
1891         * DumpRenderTree/chromium/LayoutTestController.cpp:
1892         (LayoutTestController::overridePreference):
1893         * DumpRenderTree/chromium/WebPreferences.cpp:
1894         (WebPreferences::reset):
1895         (WebPreferences::applyTo):
1896         * DumpRenderTree/chromium/WebPreferences.h:
1897
1898 2011-12-15  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1899
1900         [Qt] Improve the look of the viewport info overlay
1901
1902         Reviewed by Tor Arne Vestbø.
1903
1904         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
1905
1906 2011-12-15  Igor Oliveira  <igor.oliveira@openbossa.org>
1907
1908         [Qt] Support requestAnimationFrame API
1909         https://bugs.webkit.org/show_bug.cgi?id=74528
1910
1911         Add build-option for requestAnimationFrame feature.
1912
1913         Reviewed by Kenneth Rohde Christiansen.
1914
1915         * qmake/mkspecs/features/features.prf:
1916
1917 2011-12-15  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1918
1919         [Qt] Don't add WebCoreSupport and WebKit APIs to include WebCore's include path
1920
1921         Reviewed by Simon Hausmann.
1922
1923         * qmake/mkspecs/features/webcore.prf:
1924
1925 2011-12-15  Michael Brüning  <michael.bruning@nokia.com>
1926
1927         [QT][WK2]Add (experimental) viewport info view to Minibrowser/qt.
1928         https://bugs.webkit.org/show_bug.cgi?id=72893
1929
1930         Reviewed by Kenneth Rohde Christiansen.
1931
1932         This patch extends QQuickWebViewExperimental by a property named
1933         viewportInfo, which contains the viewport scalability and
1934         layout and contents size information. This property is exposed to
1935         QML through the experimental extension for QQuickWebView.
1936
1937         * MiniBrowser/qt/MiniBrowser.pro:
1938         * MiniBrowser/qt/MiniBrowser.qrc:
1939         * MiniBrowser/qt/icons/info.png: Added.
1940         * MiniBrowser/qt/qml/BrowserWindow.qml:
1941         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Added.
1942
1943 2011-12-15  Shinya Kawanaka  <shinyak@google.com>
1944
1945         [chromium] WebViewHost::requestCheckingOfText should return immediately if text is empty.
1946         https://bugs.webkit.org/show_bug.cgi?id=74586
1947
1948         Reviewed by Hajime Morita.
1949
1950         No new tests. Covered by existing tests.
1951
1952         * DumpRenderTree/chromium/WebViewHost.cpp:
1953         (WebViewHost::requestCheckingOfText):
1954           Returns immediately if text is empty.
1955
1956 2011-12-15  Alexander Færøy  <ahf@0x90.dk>
1957
1958         [Qt] QtWebKit fails to build on Mac OS X after r102776
1959         https://bugs.webkit.org/show_bug.cgi?id=74593
1960
1961         Reviewed by Simon Hausmann.
1962
1963         CONFIG =+ link_pkgconfig is needed such that the correct parameters
1964         are passed to the compiler.
1965
1966         * DumpRenderTree/qt/DumpRenderTree.pro:
1967
1968 2011-12-14  Tony Chang  <tony@chromium.org>
1969
1970         [chromium] Remove redundant third_party entries from chromium DEPS
1971         https://bugs.webkit.org/show_bug.cgi?id=74472
1972
1973         Reviewed by Kenneth Russell.
1974
1975         * Scripts/update-webkit-chromium: Temporarily keep unversioned trees.
1976
1977 2011-12-14  Kentaro Hara  <haraken@chromium.org>
1978
1979         [Refactoring] In prepare-ChangeLog, replace $isGit and $isSVN with
1980         VCSUtils::isGit() and VCSUtils::isSVN().
1981         https://bugs.webkit.org/show_bug.cgi?id=74485
1982
1983         Reviewed by David Kilzer.
1984
1985         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
1986         manner. This bug is one of the incremental refactorings to remove all top-level
1987         code and global variables from prepare-ChangeLog. This patch replaces $isGit and $isSVN
1988         with VCSUtils::isGit() and VCSUtils::isSVN(). This patch also removes firstDirectoryOrCwd(),
1989         assuming that no user will mix Git/SVN checkouts and thus we can judge SVN or Git
1990         just by looking at the current working directory.
1991
1992         * Scripts/prepare-ChangeLog: Removed firstDirectoryOrCwd().
1993         (diffFromToString):
1994         (diffCommand):
1995         (statusCommand):
1996         (createPatchCommand):
1997         (diffHeaderFormat):
1998         (generateFileList):
1999         (isAddedStatus):
2000         (isConflictStatus):
2001         (statusDescription):
2002         (extractLineRange):
2003
2004 2011-12-14  Sam Weinig  <weinig@apple.com>
2005
2006         Remove whitespace from InheritedPropertySheets attributes in
2007         vsprops files to appease the Visual Studio project migrator.
2008
2009         Reviewed by Adam Roben.
2010
2011         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops:
2012         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops:
2013         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops:
2014         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
2015         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops:
2016         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops:
2017         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops:
2018         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops:
2019         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops:
2020         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
2021         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops:
2022         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops:
2023         * DumpRenderTree/win/ImageDiffDebug.vsprops:
2024         * DumpRenderTree/win/ImageDiffDebugAll.vsprops:
2025         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops:
2026         * DumpRenderTree/win/ImageDiffProduction.vsprops:
2027         * DumpRenderTree/win/ImageDiffRelease.vsprops:
2028         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops:
2029         * MiniBrowser/Configurations/MiniBrowserDebug.vsprops:
2030         * MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops:
2031         * MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops:
2032         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
2033         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops:
2034         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops:
2035         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops:
2036         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops:
2037         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops:
2038         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops:
2039         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops:
2040         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
2041         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops:
2042         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops:
2043         * WebKitTestRunner/win/InjectedBundleDebug.vsprops:
2044         * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops:
2045         * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops:
2046         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
2047         * WebKitTestRunner/win/InjectedBundleRelease.vsprops:
2048         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops:
2049         * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops:
2050         * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops:
2051         * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops:
2052         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
2053         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops:
2054         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops:
2055         * WinLauncher/WinLauncherDebug.vsprops:
2056         * WinLauncher/WinLauncherDebugAll.vsprops:
2057         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops:
2058         * WinLauncher/WinLauncherProduction.vsprops:
2059         * WinLauncher/WinLauncherRelease.vsprops:
2060         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops:
2061         * record-memory-win/record-memory-winDebug.vsprops:
2062         * record-memory-win/record-memory-winDebugAll.vsprops:
2063         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops:
2064         * record-memory-win/record-memory-winProduction.vsprops:
2065         * record-memory-win/record-memory-winRelease.vsprops:
2066         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops:
2067
2068 2011-12-14  Anders Carlsson  <andersca@apple.com>
2069
2070         Windows build fix.
2071
2072         Move CHECKs out of the destructor.
2073
2074         * TestWebKitAPI/Tests/WTF/Functional.cpp:
2075         (TestWebKitAPI::B::~B):
2076         (TestWebKitAPI::TEST):
2077
2078 2011-12-14  Anders Carlsson  <andersca@apple.com>
2079
2080         binding a member function should ref/deref the object pointer if needed
2081         https://bugs.webkit.org/show_bug.cgi?id=74552
2082
2083         Reviewed by Sam Weinig.
2084
2085         Add new tests.
2086
2087         * TestWebKitAPI/Tests/WTF/Functional.cpp:
2088         (TestWebKitAPI::B::B):
2089         (TestWebKitAPI::B::~B):
2090         (TestWebKitAPI::B::ref):
2091         (TestWebKitAPI::B::deref):
2092         (TestWebKitAPI::B::f):
2093         (TestWebKitAPI::B::g):
2094         (TestWebKitAPI::TEST):
2095
2096 2011-12-14  Hajime Morrita  <morrita@chromium.org>
2097
2098         JS_INLINE and WTF_INLINE should be visible from WebCore
2099         https://bugs.webkit.org/show_bug.cgi?id=73191
2100
2101         Reviewed by Kevin Ollivier.
2102
2103         Removed macro definitions which is now provided by Platform.h
2104
2105         * DumpRenderTree/chromium/config.h:
2106         * DumpRenderTree/config.h:
2107         * DumpRenderTree/ForwardingHeaders/runtime/JSExportMacros.h: Added.
2108         * DumpRenderTree/ForwardingHeaders/wtf/ExportMacros.h: Added.
2109         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Add new ForwardingHeaders.
2110         * TestWebKitAPI/config.h:
2111         * WebKitTestRunner/config.h:
2112
2113 2011-12-14  Kentaro Hara  <haraken@chromium.org>
2114
2115         Unreviewed, rolling out r102761.
2116         http://trac.webkit.org/changeset/102761
2117         https://bugs.webkit.org/show_bug.cgi?id=74485
2118
2119         we came up with a better fix than this (see comments in bug
2120         74485)
2121
2122         * Scripts/prepare-ChangeLog:
2123         (generateFunctionLists):
2124         (printDiff):
2125         (diffCommand):
2126         (statusCommand):
2127         (createPatchCommand):
2128         (generateFileList):
2129         (isAddedStatus):
2130         (isConflictStatus):
2131         (statusDescription):
2132         (extractLineRange):
2133
2134 2011-12-14  Anders Carlsson  <andersca@apple.com>
2135
2136         Work around a bug in the MSVC2005 compiler
2137         https://bugs.webkit.org/show_bug.cgi?id=74550
2138
2139         Reviewed by Sam Weinig.
2140
2141         Re-enable tests.
2142
2143         * TestWebKitAPI/Tests/WTF/Functional.cpp:
2144
2145 2011-12-14  Csaba Osztrogonác  <ossy@webkit.org>
2146
2147         [Qt] Test fonts are not used with Qt5
2148         https://bugs.webkit.org/show_bug.cgi?id=72513
2149
2150         My last unreviewed buildfix for this crazy bug.
2151
2152         * qmake/mkspecs/features/features.prf:
2153
2154 2011-12-14  Anders Carlsson  <andersca@apple.com>
2155
2156         Another attempt at fixing the Windows build.
2157
2158         Disable all the tests until I can figure out what's going on here.
2159
2160         * TestWebKitAPI/Tests/WTF/Functional.cpp:
2161
2162 2011-12-14  Anders Carlsson  <andersca@apple.com>
2163
2164         Fix the Windows build.
2165
2166         Disable some of the tests for now.
2167
2168         * TestWebKitAPI/Tests/WTF/Functional.cpp:
2169
2170 2011-12-14  Anders Carlsson  <andersca@apple.com>
2171
2172         bind should handle member functions
2173         https://bugs.webkit.org/show_bug.cgi?id=74529
2174
2175         Reviewed by Sam Weinig.
2176
2177         Add tests.
2178
2179         * TestWebKitAPI/Tests/WTF/Functional.cpp:
2180         (TestWebKitAPI::A::A):
2181         (TestWebKitAPI::A::f):
2182         (TestWebKitAPI::A::addF):
2183         (TestWebKitAPI::TEST):
2184
2185 2011-12-14  Anders Carlsson  <andersca@apple.com>
2186
2187         Add unary and binary bind overloads
2188         https://bugs.webkit.org/show_bug.cgi?id=74524
2189
2190         Reviewed by Sam Weinig.
2191
2192         Add tests.
2193
2194         * TestWebKitAPI/Tests/WTF/Functional.cpp:
2195         (TestWebKitAPI::TEST):
2196         (TestWebKitAPI::multiplyByTwo):
2197         (TestWebKitAPI::multiplyByOneAndAHalf):
2198         (TestWebKitAPI::multiply):
2199         (TestWebKitAPI::subtract):
2200
2201 2011-12-14  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
2202
2203         [Qt] Test fonts are not used with Qt5
2204         https://bugs.webkit.org/show_bug.cgi?id=72513
2205
2206         MIPS and SH4 buildfix after r102776 and r102795.
2207
2208         Reviewed by Csaba Osztrogonác.
2209
2210         * qmake/mkspecs/features/features.prf:
2211
2212 2011-12-14  Csaba Osztrogonác  <ossy@webkit.org>
2213
2214         [Qt] Unreviewed speculative MIPS and SH4 buildfix after r102776.
2215
2216         * qmake/mkspecs/features/features.prf:
2217
2218 2011-12-14  Andreas Kling  <kling@webkit.org>
2219
2220         Make my e-mail address a little more awesome.
2221
2222         * Scripts/webkitpy/common/config/committers.py:
2223
2224 2011-12-14  Csaba Osztrogonác  <ossy@webkit.org>
2225
2226         [Qt] Rollout r102769, because it broke Qt-4.8 builds.
2227
2228         * qmake/mkspecs/features/webcore.prf:
2229
2230 2011-12-14  Balazs Kelemen  <kbalazs@webkit.org>
2231
2232         [Qt] Test fonts are not used with Qt5
2233         https://bugs.webkit.org/show_bug.cgi?id=72513
2234
2235         Reviewed by Simon Hausmann.
2236
2237         Don't depend on Q_WS_X11 anymore since it's not the Qt5
2238         way to detect the platform. Make the guards depend
2239         on our own configtest for fontconfig. For Qt4 we can still
2240         use the preassumption that we have it on Linux.
2241
2242         * DumpRenderTree/qt/DumpRenderTree.pro:
2243         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2244         (WebCore::DumpRenderTree::open):
2245         (WebCore::DumpRenderTree::initializeFonts):
2246         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2247         * DumpRenderTree/qt/main.cpp:
2248         (main): Additionally remove a nonsense piece of code that was
2249         trying to reset the font settings - which is not necessary -
2250         after we have already returned from main.
2251         * WebKitTestRunner/InjectedBundle/Target.pri:
2252         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2253         (WTR::activateFonts):
2254         * WebKitTestRunner/Target.pri: Remove unnecessary fontconfig linkage
2255         from WTR. It is not needed. We set up the fonts via the injected bundle.
2256         * qmake/config.tests/fontconfig/fontconfig.cpp: Added.
2257         (main):
2258         * qmake/config.tests/fontconfig/fontconfig.pro: Added.
2259         * qmake/mkspecs/features/features.prf:
2260         * qmake/sync.profile:
2261
2262 2011-12-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2263
2264         [Qt] Don't add WebCoreSupport and WebKit APIs to include WebCore's include path
2265
2266         Followup to r102679
2267
2268         https://bugs.webkit.org/show_bug.cgi?id=74413
2269
2270         Reviewed by Simon Hausmann.
2271
2272         * qmake/mkspecs/features/webcore.prf:
2273
2274 2011-12-14  Pierre Rossi  <pierre.rossi@gmail.com>
2275
2276         [Qt] Mobile theme could use a little refresh
2277         https://bugs.webkit.org/show_bug.cgi?id=74293
2278
2279         Have MiniBrowser use the mobile theme when not
2280         passed --desktop.
2281
2282         Reviewed by Kenneth Rohde Christiansen.
2283
2284         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2285         (MiniBrowserApplication::handleUserOptions):
2286
2287 2011-12-14  João Paulo Rechi Vita  <jprvita@openbossa.org>
2288
2289         [Qt] [Gardening] Remove qt-4.7 layout tests dir
2290         https://bugs.webkit.org/show_bug.cgi?id=74426
2291
2292         Building trunk now depends on Qt >= 4.8, so no need to keep this directory
2293         on the tree.
2294
2295         Reviewed by Csaba Osztrogonác.
2296
2297         * Scripts/webkitpy/layout_tests/port/qt.py:
2298         (QtPort.qt_version):
2299         (QtPort.baseline_search_path):
2300         (QtPort._skipped_file_search_paths):
2301         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2302         (QtPortTest._assert_search_path):
2303
2304 2011-12-14  Kentaro Hara  <haraken@chromium.org>
2305
2306         [Refactoring] In prepare-ChangeLog, make $isGit and $isSVN be used only
2307         through parameter passing
2308         https://bugs.webkit.org/show_bug.cgi?id=74485
2309
2310         Reviewed by Ryosuke Niwa.
2311
2312         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
2313         manner. This bug is one of the incremental refactorings to remove all top-level
2314         code and global variables from prepare-ChangeLog. In this patch,
2315         we make the following global variables be used only through parameter passing.
2316             - $isGit
2317             - $isSVN
2318
2319         * Scripts/prepare-ChangeLog:
2320         (generateFunctionLists):
2321         (printDiff):
2322         (diffFromToString):
2323         (diffCommand):
2324         (statusCommand):
2325         (createPatchCommand):
2326         (diffHeaderFormat):
2327         (generateFileList):
2328         (isAddedStatus):
2329         (isConflictStatus):
2330         (statusDescription):
2331         (extractLineRange):
2332
2333 2011-12-14  Alexander Færøy  <alexander.faeroy@nokia.com>
2334
2335         [Qt] DeviceOrientationClientMockQt should be removed in favor of DeviceOrientationClientMock
2336         https://bugs.webkit.org/show_bug.cgi?id=74417
2337
2338         Reviewed by Simon Hausmann.
2339
2340         Based on original patch by Kenneth Christiansen.
2341
2342         Already covered by current tests.
2343
2344         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2345         (WebCore::DumpRenderTree::DumpRenderTree):
2346         (WebCore::DumpRenderTree::~DumpRenderTree):
2347         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2348         (LayoutTestController::setMockDeviceOrientation):
2349
2350 2011-12-03  Philippe Normand  <pnormand@igalia.com>
2351
2352         [GTK] Bad text rendering since r101343
2353         https://bugs.webkit.org/show_bug.cgi?id=73744
2354
2355         Reviewed by Martin Robinson.
2356
2357         Turn cairo hint metrics off for better font metrics reporting in
2358         the tests. This is especially important for SVG.
2359
2360         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2361         (initializeGtkFontSettings):
2362         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2363         (WTR::initializeGtkSettings):
2364
2365 2011-12-13  Kentaro Hara  <haraken@chromium.org>
2366
2367         [Refactoring] Remove several global variables from prepare-ChangeLog
2368         https://bugs.webkit.org/show_bug.cgi?id=74389
2369
2370         Reviewed by David Kilzer.
2371
2372         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
2373         manner. This bug is one of the incremental refactorings to remove all top-level
2374         code and global variables from prepare-ChangeLog. In this patch,
2375         we make the following global variables being used only through parameter passing.
2376             - %paths
2377             - $changedFiles
2378             - $conflictFiles
2379             - $functionLists
2380             - $bugURL
2381
2382         * Scripts/prepare-ChangeLog:
2383         (findChangeLogs):
2384         (generateNewChangeLogs):
2385         (processPaths):
2386         (generateFileList):
2387         (firstDirectoryOrCwd):
2388
2389 2011-12-13  Anders Carlsson  <andersca@apple.com>
2390
2391         Add a very bare-bones implementation of bind and Function to WTF
2392         https://bugs.webkit.org/show_bug.cgi?id=74462
2393
2394         Reviewed by Sam Weinig.
2395
2396         Add basic tests for WTF::Function and WTF::bind.
2397
2398         * TestWebKitAPI/TestWebKitAPI.gypi:
2399         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2400         * TestWebKitAPI/Tests/Functional.cpp: Added.
2401         (TestWebKitAPI::returnFortyTwo):
2402         (TestWebKitAPI::TEST):
2403         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2404
2405 2011-12-13  Robin Dunn  <robin@alldunn.com>
2406
2407         [wx] Add a URL argument to wxWebView constructor.
2408         https://bugs.webkit.org/show_bug.cgi?id=74316
2409         
2410         Reviewed by Kevin Ollivier.
2411
2412         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
2413         (MyApp::OnInit):
2414         * wx/browser/browser.cpp:
2415         (MyApp::OnInit):
2416
2417 2011-12-13  Raphael Kubo da Costa  <kubo@profusion.mobi>
2418
2419         watchlist: Add watchlist for EFL, CMake and libsoup code and put myself on it.
2420         https://bugs.webkit.org/show_bug.cgi?id=74430
2421
2422         Reviewed by David Levin.
2423
2424         * Scripts/webkitpy/common/config/watchlist:
2425
2426 2011-12-13  Peter Beverloo  <peter@chromium.org>
2427
2428         [Chromium] Pull in FreeType and decrease check-out complexity for Android
2429         https://bugs.webkit.org/show_bug.cgi?id=74401
2430
2431         Decrease the check-out complexity by removing the need to first run
2432         "update-webkit-chromium --chromium" prior to running it with
2433         "--chromium-android", which was caused by an unversioned third_party/
2434         directory being created. This moves the Android NDK to Source/WebKit/
2435         chromium/, coming from third_party/ in that directory.
2436
2437         Reviewed by Adam Barth.
2438
2439         * Scripts/update-webkit-chromium:
2440         * Scripts/webkitdirs.pm:
2441         (buildChromiumMakefile):
2442
2443 2011-12-13  Andy Wingo  <wingo@igalia.com> and Martin Robinson <mrobinson@igalia.com>
2444
2445         build-jsc passing incorrect args to buildGtkProject
2446         https://bugs.webkit.org/show_bug.cgi?id=74308
2447
2448         Reviewed by Gustavo Noronha Silva.
2449
2450         * Scripts/build-webkit: Instead of invoking buildGtkProject with
2451         another argument about webkit2, unshift a --disable-webkit2
2452         argument onto the buildArgs.
2453         * Scripts/webkitdirs.pm: Remove $enableWebKit2 arg. Only save autogen.sh
2454         arguments for WebKit to prevent unnecessary reconfiguration when build-webkit
2455         and build-jsc are run one after the other.
2456
2457 2011-12-13  Csaba Osztrogonác  <ossy@webkit.org>
2458
2459         [Qt] REGRESSION(102679): It broke Qt5-WK1 build
2460         https://bugs.webkit.org/show_bug.cgi?id=74413
2461
2462         Unreviewed buildfix.
2463
2464         * qmake/mkspecs/features/webcore.prf: Temporarily revert a part of r102679 until a proper fix.
2465
2466 2011-12-13  Csaba Osztrogonác  <ossy@webkit.org>
2467
2468         [Qt] Unreviewed speculativ debug buildfix after r102679.
2469
2470         * QtTestBrowser/QtTestBrowser.pro:
2471         * QtTestBrowser/main.cpp:
2472
2473 2011-12-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2474
2475         [Qt] Get rid of layering violations in includes
2476
2477         WebKit/qt/API and WebKit/qt/WebCoreSupport should not be included
2478         in the webcore.prf, but rather in each target that specificly needs
2479         headers in these location. We used to include them directly in webcore
2480         since we had layering violations between WebCore and WebKit, but now
2481         that they are gone there's no reason to do that.
2482
2483         Reviewed by Simon Hausmann.
2484
2485         * DumpRenderTree/qt/DumpRenderTree.pro:
2486         * QtTestBrowser/launcherwindow.h:
2487         * WebKitTestRunner/InjectedBundle/Target.pri:
2488         * qmake/mkspecs/features/webcore.prf:
2489         * qmake/mkspecs/features/webkit2.prf:
2490
2491 2011-12-13  János Badics  <dicska@gmail.com>
2492
2493         [NRWT] It crashes intermittently when there are WebProcess crashes
2494         https://bugs.webkit.org/show_bug.cgi?id=73451
2495
2496         Use self.poll() instead of self._proc.poll() because it checks if self._proc is None or not.
2497
2498         Reviewed by Kenneth Rohde Christiansen.
2499
2500         * Scripts/webkitpy/layout_tests/port/server_process.py:
2501         (ServerProcess._check_for_crash):
2502
2503 2011-12-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2504
2505         Unreviewed. Fix GTK+ API docs build.
2506
2507         * gtk/generate-gtkdoc:
2508         (get_webkit2_options): Ignore WebKitUIClient since it's private
2509         API.
2510
2511 2011-12-13  Kenichi Ishibashi  <bashi@chromium.org>
2512
2513         Reviewed, removed one of my email addresses to use the apprpriate one.
2514
2515         * Scripts/webkitpy/common/config/committers.py:
2516
2517 2011-12-12  Ádám Kallai  <Kallai.Adam@stud.u-szeged.hu>
2518
2519         [Qt] Fix skip list search path and expected file search path in ORWT
2520         https://bugs.webkit.org/show_bug.cgi?id=74281
2521
2522         Expected file search path fixed.
2523
2524         Print all used skipped list and expected search path in verbose mode similar to NRWT.
2525
2526         Reviewed by Csaba Osztrogonác.
2527
2528         * Scripts/old-run-webkit-tests:
2529         (buildPlatformResultHierarchy):
2530         (buildPlatformTestHierarchy):
2531         (readSkippedFiles):
2532
2533 2011-12-12  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
2534
2535         [Qt] Missing layoutTestController.dumpWillCacheResponse
2536         https://bugs.webkit.org/show_bug.cgi?id=74287
2537
2538         Reviewed by Csaba Osztrogonác.
2539
2540         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2541         (LayoutTestController::reset):
2542         (LayoutTestController::dumpWillCacheResponse):
2543         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2544
2545 2011-12-12  Martin Robinson  <mrobinson@igalia.com>
2546
2547         [GTK] platform/gtk/fonts/custom-font-missing-glyphs.html fails on 64-bit Debug
2548         https://bugs.webkit.org/show_bug.cgi?id=73771
2549
2550         Reviewed by Gustavo Noronha Silva.
2551
2552         When using a fallback font during testing, always use DejaVu Sans. This prevents
2553         falling back to DejaVu Serif on some systems.
2554
2555         * DumpRenderTree/gtk/fonts/fonts.conf: Fall back to DejaVu Sans.
2556
2557 2011-12-08  Pierre Rossi  <pierre.rossi@gmail.com>
2558
2559         Add myself as a committer
2560
2561         * Scripts/webkitpy/common/config/committers.py:
2562
2563 2011-12-12  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2564
2565         [Qt] [WK2] Support customizing popup menus with QML
2566         https://bugs.webkit.org/show_bug.cgi?id=73560
2567
2568         Reviewed by Tor Arne Vestbø.
2569
2570         Add an Item Selector to our WebView using the experimental API.
2571
2572         * MiniBrowser/qt/MiniBrowser.pro:
2573         * MiniBrowser/qt/MiniBrowser.qrc:
2574         * MiniBrowser/qt/qml/BrowserWindow.qml:
2575         * MiniBrowser/qt/qml/ItemSelector.qml: Added.
2576
2577 2011-12-12  Alexander Færøy  <alexander.faeroy@nokia.com>
2578
2579         [Qt] MiniBrowser should only visualize mock touch points when in non-desktop mode
2580         https://bugs.webkit.org/show_bug.cgi?id=74283
2581
2582         Reviewed by Simon Hausmann.
2583
2584         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2585         (MiniBrowserApplication::sendTouchEvent):
2586
2587 2011-12-12  Kentaro Hara  <haraken@chromium.org>
2588
2589         [Refactoring] In prepare-ChangeLog, move into a method the top-level code
2590         to show ChangeLogs diff and open ChangeLogs in an editor
2591         https://bugs.webkit.org/show_bug.cgi?id=74266
2592
2593         Reviewed by Ryosuke Niwa.
2594
2595         We are planning to write unit-tests for prepare-ChangeLog
2596         in a run-leaks_unittest manner. This patch is one of the incremental
2597         refactorings to remove all top-level code and global variables from
2598         prepare-ChangeLog.
2599
2600         * Scripts/prepare-ChangeLog: Moved the top-level code to show ChangeLogs diff into printDiff().
2601         Moved the top-level code to open ChangeLogs in an editor into openChangeLogs().
2602         Renamed @changed_files to @changedFiles.
2603         Renamed %conflict_files to %conflictFiles.
2604         (generateFunctionLists):
2605         (printDiff):
2606         (openChangeLogs):
2607
2608 2011-12-11  Kentaro Hara  <haraken@chromium.org>
2609
2610         [Refactoring] Move top-level code to resolve conflicted ChangeLogs into a method
2611         https://bugs.webkit.org/show_bug.cgi?id=74257
2612
2613         Reviewed by Ryosuke Niwa.
2614
2615         We are planning to write unit-tests for prepare-ChangeLog
2616         in a run-leaks_unittest/ manner. This patch is one of the incremental
2617         refactorings to remove all top-level code and global variables from
2618         prepare-ChangeLog.
2619
2620         * Scripts/prepare-ChangeLog: Moved top-level code to get the latest ChangeLogs
2621         into getLatestChangeLogs(), and moved top-level code to resolve conflicted ChangeLogs
2622         into resolveConflictedChangeLogs().
2623         (getLatestChangeLogs):
2624         (resolveConflictedChangeLogs):
2625
2626 2011-12-11  Kentaro Hara  <haraken@chromium.org>
2627
2628         [Refactoring] Move top-level code to generate a new ChangeLog into a method
2629         https://bugs.webkit.org/show_bug.cgi?id=74253
2630
2631         Reviewed by David Kilzer.
2632
2633         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing,
2634         which requires to remove top-level code and global variables. This patch is one of
2635         the incremental refactorings for that.
2636
2637         * Scripts/prepare-ChangeLog: Moved top-level code to generate a new ChangeLog into generateNewChangeLogs().
2638         (generateFunctionLists):
2639         (findChangeLogs):
2640         (generateNewChangeLogs):
2641         (generateFileList): Removed an unnecessary variable $didChangeRegressionTests.
2642
2643 2011-12-10  Kentaro Hara  <haraken@chromium.org>
2644
2645         [Refactoring] In prepare-ChangeLog, move top-level code to find ChangeLogs into a method
2646         https://bugs.webkit.org/show_bug.cgi?id=74175
2647
2648         Reviewed by Ryosuke Niwa.
2649
2650         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
2651         This requires to remove top-level code. This patch is one of the incremental refactorings
2652         for that.
2653
2654         * Scripts/prepare-ChangeLog: Moved top-level code to find ChangeLogs into findChangeLogs().
2655         (findChangeLogs):
2656
2657 2011-12-10  Andreas Kling  <kling@webkit.org>
2658
2659         Add my Apple e-mail to committers.py.
2660
2661         * Scripts/webkitpy/common/config/committers.py:
2662
2663 2011-12-09  Dirk Pranke  <dpranke@chromium.org>
2664
2665         chromium win build: revert build_webkit_exes_from_webkit_gyp change
2666         https://bugs.webkit.org/show_bug.cgi?id=74225
2667
2668         This change sets build_webkit_exes_from_webkit_gyp back to 1;
2669         the "All.gyp" solution doesn't work on windows.
2670
2671         * Scripts/webkitdirs.pm:
2672         (buildChromium):
2673
2674 2011-12-09  Hugo Parente Lima  <hugo.lima@openbossa.org>
2675
2676         [Qt] Click's count is limited to three continuous clicks.
2677         https://bugs.webkit.org/show_bug.cgi?id=45666
2678
2679         Reviewed by Kenneth Rohde Christiansen.
2680
2681         Update m_time at every call to leapForward, so double clicks
2682         event are correctly sent by EventSender.
2683
2684         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
2685         (WTR::EventSenderProxy::updateClickCountForButton):
2686         (WTR::EventSenderProxy::leapForward):
2687
2688 2011-12-09  Kentaro Hara  <haraken@chromium.org>
2689
2690         [Refactoring] Reduce top-level code in prepare-ChangeLog
2691         https://bugs.webkit.org/show_bug.cgi?id=74172
2692
2693         Reviewed by Ryosuke Niwa.
2694
2695         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
2696         This requires to remove top-level code. This patch is one of the incremental refactorings
2697         for that.
2698
2699         * Scripts/prepare-ChangeLog: Moved some top-level code into generateFunctionLists().
2700         (generateFunctionLists):
2701
2702 2011-12-09  Sam Weinig  <sam@webkit.org>
2703
2704         Expose a WKConnectionRef which represents the connection to/from the WebProcess/UIProcess
2705         https://bugs.webkit.org/show_bug.cgi?id=74218
2706
2707         Reviewed by Anders Carlsson.
2708
2709         Add a test of the WKConnectionRef API.
2710
2711         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2712         * TestWebKitAPI/Tests/WebKit2/WKConnection.cpp: Added.
2713         (TestWebKitAPI::didCreateConnection):
2714         (TestWebKitAPI::connectionDidReceiveMessage):
2715         (TestWebKitAPI::connectionDidClose):
2716         (TestWebKitAPI::TEST):
2717         * TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp: Added.
2718         (TestWebKitAPI::connectionDidReceiveMessage):
2719         (TestWebKitAPI::WKConnectionTest::WKConnectionTest):
2720         (TestWebKitAPI::WKConnectionTest::initialize):
2721
2722 2011-12-09  David Levin  <levin@chromium.org>
2723
2724         Hash* iterators should allow comparison between const and const versions.
2725         https://bugs.webkit.org/show_bug.cgi?id=73370
2726
2727         Reviewed by Darin Adler.
2728
2729         * TestWebKitAPI/TestWebKitAPI.gypi: Add the new test file to the build.
2730         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
2731         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
2732         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Added.
2733         (TestWebKitAPI::TEST): Add a test for the new functionality.
2734
2735 2011-12-09  Dirk Pranke  <dpranke@chromium.org>
2736
2737         chromium: visual studio projects are busted when build_webkit_exes_from_webkit_gyp==0
2738         https://bugs.webkit.org/show_bug.cgi?id=74212
2739
2740         Reviewed by Tony Chang.
2741
2742         The change introduced in r102201 to split the executables out of
2743         WebKit.gyp apparently doesn't work right on Windows, since
2744         WebKit.gyp and Tools.gyp refer to dependent projects by
2745         different relative paths (it appears gyp doesn't normalize the
2746         paths). This change moves Tools.gyp to be in the same directory
2747         as WebKit.gyp (and All.gyp), which should fix this and
2748         conveniently will also solve the problem of how to add Tools.gyp
2749         to the chromium DEPS file.
2750
2751         * Tools.gyp: Renamed to ../Source/WebKit/chromium/Tools.gyp
2752
2753 2011-12-09  Kentaro Hara  <haraken@chromium.org>
2754
2755         [Refactoring] In prepare-ChangeLog, move top-level code to fetch a bug description from URL into a method
2756         https://bugs.webkit.org/show_bug.cgi?id=74173
2757
2758         Reviewed by Ryosuke Niwa.
2759
2760         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
2761         This requires to remove top-level code. This patch is one of the incremental refactorings
2762         for that.
2763
2764         * Scripts/prepare-ChangeLog: Moved top-level code to fetch a bug description from URL into fetchBugDescriptionFromURL().
2765         (fetchBugDescriptionFromURL):
2766
2767 2011-12-09  Tony Chang  <tony@chromium.org>
2768
2769         Switch the chromium mac bots to using skia test results
2770         https://bugs.webkit.org/show_bug.cgi?id=74201
2771
2772         Reviewed by Ryosuke Niwa.
2773
2774         This is reverting http://trac.webkit.org/changeset/97781 and changing
2775         the name in master.cfg to no longer have cg in the name.
2776
2777         * BuildSlaveSupport/build.webkit.org-config/config.json:
2778         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2779         (appendCustomBuildFlags):
2780         (RunWebKitTests.start):
2781
2782 2011-12-09  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2783
2784         [Qt] Remove a wrongly placed ASSERT.
2785
2786         Reviewed by Tor Arne Vestbø.
2787
2788         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2789         (MiniBrowserApplication::notify):
2790
2791 2011-12-09  Cary Clark  <caryclark@google.com>
2792
2793         layout_test update to accommodate new use_skia=1 default on Chromium-Mac
2794         https://bugs.webkit.org/show_bug.cgi?id=74118
2795
2796         Reviewed by Adam Barth.
2797
2798         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2799         (get):
2800         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2801         (ChromiumMacPort.__init__):
2802         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2803         (ChromiumMacPortTest.test_versions):
2804         (ChromiumMacPortTest.test_graphics_type):
2805
2806 2011-12-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2807
2808         [Qt] Use new qmake option in Qt5 to prevent dependency issues with GNUmake
2809
2810         The GNUmake + gcc_MD_depends options together produce .d files using GCC, but
2811         this failed when moving files in the source tree, as the .d file would contain
2812         stale dependencies on the old source file location. By keeping the object files
2813         (and hence the depdendency files) in a proper tree structure inside the objects
2814         directory we can prevent this failure.
2815
2816         A side benefit is that we can also have objects with the same name inside the
2817         same project.
2818
2819         Reviewed by Simon Hausmann.
2820
2821         * qmake/mkspecs/features/unix/default_pre.prf:
2822
2823 2011-12-09  Csaba Osztrogonác  <ossy@webkit.org>
2824
2825         Unreviewed. Update unit test after r102412.
2826
2827         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2828         (IRCCommandTest.test_whois):
2829
2830 2011-12-09  Kentaro Hara  <haraken@chromium.org>
2831
2832         REGRESSION(r102105): run-bindings-tests should output full diff results
2833         https://bugs.webkit.org/show_bug.cgi?id=74166
2834
2835         Reviewed by Adam Barth.
2836
2837         Since r102105, the output of run-bindings-tests is truncated to 500 characters.
2838         run-bindings-tests should output full diff results.
2839
2840         * Scripts/webkitpy/bindings/main.py: Replaced e.message_with_output() with e.output.
2841         (BindingsTests.generate_from_idl):
2842         (BindingsTests.generate_supplemental_dependency):
2843         (BindingsTests.detect_changes):
2844
2845 2011-12-09  Simon Hausmann  <simon.hausmann@nokia.com>
2846
2847         [Qt] Fix compilation with newly separated Qt 5 QtQuick module
2848         https://bugs.webkit.org/show_bug.cgi?id=73990
2849
2850         Reviewed by Kenneth Rohde Christiansen, tweaked by Csaba Osztrogonác.
2851
2852         Fix QtQuick includes after move from QtDeclarative to QtQuick.
2853
2854         * MiniBrowser/qt/BrowserWindow.h:
2855         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2856
2857 2011-12-08  Adam Klein  <adamk@chromium.org>
2858
2859         [MutationObservers] V8LazyEventHandler breaks microtask delivery semantics
2860         https://bugs.webkit.org/show_bug.cgi?id=73492
2861
2862         Reviewed by Adam Barth.
2863
2864         Add eventSender.scheduleAsynchronousKeyDown, needed to cause a
2865         keypress event without any script on the stack.
2866
2867         * DumpRenderTree/chromium/EventSender.cpp:
2868         (EventSender::EventSender):
2869         (EventSender::keyDown):
2870         (KeyDownTask::KeyDownTask):
2871         (KeyDownTask::runIfValid):
2872         (EventSender::scheduleAsynchronousKeyDown):
2873         * DumpRenderTree/chromium/EventSender.h:
2874
2875 2011-12-08  Hayato Ito  <hayato@chromium.org>
2876
2877         [gdb] Pretty printer for a 8-bit version of WTF::StringImpl and LChar*.
2878         https://bugs.webkit.org/show_bug.cgi?id=73980
2879
2880         Reviewed by Tony Chang.
2881
2882         * gdb/webkit.py:
2883         (guess_string_length):
2884         (ustring_to_string):
2885         (lstring_to_string):
2886         (LCharStringPrinter):
2887         (LCharStringPrinter.to_string):
2888         (WTFStringImplPrinter.get_length):
2889         (WTFStringImplPrinter.to_string):
2890         (WTFStringImplPrinter.is_8bit):
2891         (WTFStringPrinter.stringimpl_ptr):
2892         (WTFStringPrinter.get_length):
2893         (WTFStringPrinter.to_string):
2894         (add_pretty_printers.lookup_function):
2895
2896 2011-12-08  Pierre Rossi  <pierre.rossi@gmail.com>
2897
2898         Drop ENABLE_NO_LISTBOX_RENDERING, and make it a runtime decision.
2899         https://bugs.webkit.org/show_bug.cgi?id=73916
2900
2901         Reviewed by Kent Tamura.
2902
2903         * qmake/mkspecs/features/features.prf:
2904
2905 2011-12-08  Adrienne Walker  <enne@google.com>
2906
2907         Unreviewed contributor additions to committers.py.
2908
2909         * Scripts/webkitpy/common/config/committers.py:
2910
2911 2011-12-08  David Reveman  <reveman@chromium.org>
2912
2913         [Chromium] Add per-tile painting flag to DumpRenderTree and rename AcceleratedDrawing to AcceleratedPainting in chromium specific code.
2914         https://bugs.webkit.org/show_bug.cgi?id=74017
2915
2916         Reviewed by James Robinson.
2917         
2918         Add support for command line flag enable-per-tile-painting in DumpRenderTree.
2919
2920         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2921         (main):
2922         * DumpRenderTree/chromium/TestShell.cpp:
2923         (TestShell::TestShell):
2924         (TestShell::resetWebSettings):
2925         * DumpRenderTree/chromium/TestShell.h:
2926         (TestShell::setAcceleratedPaintingEnabled):
2927         (TestShell::setPerTilePaintingEnabled):
2928         * DumpRenderTree/chromium/WebPreferences.cpp:
2929         (WebPreferences::reset):
2930         (WebPreferences::applyTo):
2931         * DumpRenderTree/chromium/WebPreferences.h:
2932         * Scripts/webkitpy/layout_tests/port/chromium.py:
2933         (ChromiumDriver._wrapper_options):
2934         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2935         (parse_args):
2936
2937 2011-12-08  Dirk Pranke  <dpranke@chromium.org>
2938
2939         create a "SystemHost" object for webkitpy to slim down the Host object
2940         https://bugs.webkit.org/show_bug.cgi?id=72680
2941
2942         Reviewed by Eric Siedel.
2943
2944         This creates a SystemHost object that other objects that should
2945         only have dependencies on functionality in webkitpy.common.system
2946         can use; this will allow them to not require a full Host.
2947
2948         * Scripts/webkitpy/common/host.py:
2949         * Scripts/webkitpy/common/host_mock.py:
2950         * Scripts/webkitpy/common/system/systemhost.py: Added.
2951         * Scripts/webkitpy/common/system/systemhost_mock.py: Added.
2952
2953 2011-12-08  Chris Fleizach  <cfleizach@apple.com>
2954
2955         AX: platform/mac/accessibility/search-with-frames.html crashes
2956         https://bugs.webkit.org/show_bug.cgi?id=74093
2957
2958         Reviewed by Darin Adler.
2959
2960         Take care of the case when an incoming element is null.
2961
2962         * DumpRenderTree/AccessibilityUIElement.cpp:
2963         (uiElementForSearchPredicateCallback):
2964         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2965         (AccessibilityUIElement::uiElementForSearchPredicate):
2966         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2967         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2968
2969 2011-12-08  Alexander Færøy  <ahf@0x90.dk>
2970
2971         [Qt] Visualize mock point ID's in the MiniBrowser
2972         https://bugs.webkit.org/show_bug.cgi?id=74098
2973
2974         Reviewed by Tor Arne Vestbø.
2975
2976         * MiniBrowser/qt/BrowserWindow.cpp:
2977         (BrowserWindow::updateVisualMockTouchPoints):
2978         * MiniBrowser/qt/qml/MockTouchPoint.qml:
2979
2980 2011-12-08  Dominic Mazzoni  <dmazzoni@google.com>
2981
2982         Accessibility: AccessibilityController should support listening to notifications on all elements.
2983         https://bugs.webkit.org/show_bug.cgi?id=72866
2984
2985         Adds addNotificationListener and removeNotificationListener methods
2986         to AccessibilityController, to listen to notifications on any element
2987         rather than a specific element. Mac (DRT and WKTR) and Chromium (DRT)
2988         implementations are all contained in this change.
2989
2990         On Mac, refactors AccessibilityNotificationHandler into its own
2991         source file that can be used by both AccessibilityController and
2992         AccessibilityUIElement. (Both DRT and WKTR.)
2993
2994         Reviewed by Chris Fleizach.
2995
2996         * DumpRenderTree/AccessibilityController.cpp:
2997         (addNotificationListenerCallback):
2998         (removeNotificationListenerCallback):
2999         (AccessibilityController::getJSClass):
3000         * DumpRenderTree/AccessibilityController.h:
3001         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3002         * DumpRenderTree/chromium/AccessibilityController.cpp:
3003         (AccessibilityController::AccessibilityController):
3004         (AccessibilityController::notificationReceived):
3005         (AccessibilityController::addNotificationListenerCallback):
3006         (AccessibilityController::removeNotificationListenerCallback):
3007         * DumpRenderTree/chromium/AccessibilityController.h:
3008         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3009         (AccessibilityController::addNotificationListener):
3010         (AccessibilityController::removeNotificationListener):
3011         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3012         (AccessibilityController::~AccessibilityController):
3013         (AccessibilityController::addNotificationListener):
3014         (AccessibilityController::removeNotificationListener):
3015         * DumpRenderTree/mac/AccessibilityNotificationHandler.h: Added.
3016         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm: Added.
3017         (-[NSString createJSStringRef]):
3018         (-[AccessibilityNotificationHandler init]):
3019         (-[AccessibilityNotificationHandler setPlatformElement:]):
3020         (-[AccessibilityNotificationHandler dealloc]):
3021         (-[AccessibilityNotificationHandler setCallback:]):
3022         (-[AccessibilityNotificationHandler startObserving]):
3023         (-[AccessibilityNotificationHandler _notificationReceived:]):
3024         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3025         (AccessibilityUIElement::addNotificationListener):
3026         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3027         (notificationListenerProc):
3028         (AccessibilityController::addNotificationListener):
3029         (AccessibilityController::removeNotificationListener):
3030         (AccessibilityController::winNotificationReceived):
3031         (AccessibilityController::winAddNotificationListener):
3032         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3033         (AccessibilityUIElement::addNotificationListener):
3034         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3035         (WTR::AccessibilityController::addNotificationListener):
3036         (WTR::AccessibilityController::removeNotificationListener):
3037         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
3038         (WTR::AccessibilityController::logAccessibilityEvents):
3039         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
3040         (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
3041         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
3042         (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
3043         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
3044         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm: Added.
3045         (WTR::AccessibilityController::addNotificationListener):
3046         (WTR::AccessibilityController::removeNotificationListener):
3047         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h: Added.
3048         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm: Added.
3049         (-[NSString createJSStringRef]):
3050         (-[AccessibilityNotificationHandler init]):
3051         (-[AccessibilityNotificationHandler setPlatformElement:]):
3052         (-[AccessibilityNotificationHandler dealloc]):
3053         (-[AccessibilityNotificationHandler setCallback:]):
3054         (-[AccessibilityNotificationHandler startObserving]):
3055         (-[AccessibilityNotificationHandler _notificationReceived:]):
3056         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3057         (WTR::AccessibilityUIElement::AccessibilityUIElement):
3058         (WTR::AccessibilityUIElement::verticalScrollbar):
3059         (WTR::AccessibilityUIElement::addNotificationListener):
3060         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3061
3062 2011-12-08  Csaba Osztrogonác  <ossy@webkit.org>
3063
3064         [Qt][WK2] Unreviewed buildfix after r102352.
3065
3066         * qmake/mkspecs/features/webkit2.prf:
3067
3068 2011-12-08  Adam Roben  <aroben@apple.com>
3069
3070         Make finding crash logs by PID work on Snow Leopard
3071
3072         Crash Reporter on Snow Leopard doesn't set the "app_description" extended attribute that we
3073         were using to check the PID of the crashed process. (Crash Reporter on Lion does.) Now we
3074         read the first line of the crash log and pull the PID out of there.
3075
3076         Fixes <http://webkit.org/b/74094> "webkit-patch crash-log <process> <PID>" doesn't work on
3077         Snow Leopard
3078
3079         Reviewed by Darin Adler.
3080
3081         * Scripts/webkitpy/common/system/crashlogs.py:
3082         (CrashLogs._find_newest_log_darwin): Read the first line of the crash log to get the process
3083         name and PID for the log, rather than checking the Lion-only app_description extended
3084         attribute. We now also reject the log if the process name doesn't match what we expect.
3085
3086         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
3087         (make_mock_crash_report_darwin): Added. Returns a mock crash report given a process name and
3088         PID.
3089         (CrashLogsTest.assertLinesEqual): Added. This is a compatibility shim around
3090         unittest.TestCase.assertMultiLineEqual, which didn't exist before Python 2.7.
3091         (CrashLogsTest.test_find_log_darwin): Made the mock crash reports more believable by using
3092         the new make_mock_crash_report_darwin function. Also added tests for files that can't be
3093         read, files that actually contain a crash log for some other process, and files that are
3094         misformatted.
3095
3096         * Scripts/webkitpy/common/system/filesystem.py: Removed FileSystem.getxattr, which is now
3097         unused.
3098
3099         * Scripts/webkitpy/common/system/filesystem_mock.py:
3100         (MockFileSystem.__init__): Removed xattr support, which is now unused.
3101         (MockFileSystem.open_text_file_for_reading): Changed to actually pass the file's data to
3102         ReadableTextFileObject. This function was completely broken before!
3103         (ReadableBinaryFileObject.__init__): Made the data parameter non-optional to try to prevent
3104         bugs like the above.
3105         (ReadableTextFileObject.__init__): Added. Wraps the data in a StringIO object so we can do
3106         things like readline() and seek().
3107
3108         (ReadableTextFileObject.close):
3109         (ReadableTextFileObject.read):
3110         Added. We override the superclass implementation to account for using a StringIO object.
3111
3112         (ReadableTextFileObject.readline):
3113         (ReadableTextFileObject.seek):
3114         Added. These just call through to StringIO.
3115
3116         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3117         (MainTest.test_crash_log):
3118         (MainTest.test_web_process_crash_log):
3119         Changed to use make_mock_crash_report_darwin.
3120
3121 2011-12-06  Jon Lee  <jonlee@apple.com>
3122
3123         [WK2] Add permissions support (73960)
3124         https://bugs.webkit.org/show_bug.cgi?id=73960
3125         <rdar://problem/10357008>
3126
3127         Reviewed by Darin Adler.
3128
3129         Add null function item to comply with added callback to WKPageUIClient.
3130
3131         * MiniBrowser/mac/BrowserWindowController.m:
3132         (-[BrowserWindowController awakeFromNib]):
3133         * WebKitTestRunner/TestController.cpp:
3134         (WTR::TestController::createOtherPage):
3135         (WTR::TestController::initialize):
3136
3137 2011-12-08  Alexander Færøy  <alexander.faeroy@nokia.com>
3138
3139         [Qt] Visualize mock points in the Qt MiniBrowser
3140         https://bugs.webkit.org/show_bug.cgi?id=74074
3141
3142         Reviewed by Tor Arne Vestbø.
3143
3144         * MiniBrowser/qt/BrowserWindow.cpp:
3145         (BrowserWindow::updateVisualMockTouchPoints):
3146         * MiniBrowser/qt/BrowserWindow.h:
3147         * MiniBrowser/qt/MiniBrowser.qrc:
3148         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3149         (MiniBrowserApplication::notify):
3150         (MiniBrowserApplication::sendTouchEvent):
3151         * MiniBrowser/qt/MiniBrowserApplication.h:
3152         * MiniBrowser/qt/icons/touchpoint.png: Added.
3153         * MiniBrowser/qt/qml/MockTouchPoint.qml: Added.
3154
3155 2011-12-08  Simon Hausmann  <simon.hausmann@nokia.com>
3156
3157         [Qt] WebKitTestRunner crashes with debug builds
3158         https://bugs.webkit.org/show_bug.cgi?id=74090
3159
3160         Reviewed by Tor Arne Vestbø.
3161
3162         * WebKitTestRunner/qt/TestControllerQt.cpp:
3163         (WTR::TestController::platformInitialize): Call QQuickWebView::platformInitialize
3164         to ensure WTF/JSC threading is initialized.
3165
3166 2011-12-08  Dirk Pranke  <dpranke@chromium.org>
3167
3168         fix build-webkit --chromium after breakage in r102201
3169         https://bugs.webkit.org/show_bug.cgi?id=74031
3170
3171         Reviewed by Tony Chang.
3172
3173         * Scripts/webkitdirs.pm:
3174         (buildChromium):
3175
3176 2011-12-08  Kentaro Hara  <haraken@chromium.org>
3177
3178         Unreviewed, rolling out r102280.
3179         http://trac.webkit.org/changeset/102280
3180         https://bugs.webkit.org/show_bug.cgi?id=74031
3181
3182         Chromium/Windows build is broken
3183
3184         * Scripts/webkitdirs.pm:
3185         (buildChromium):
3186
3187 2011-12-08  Nayan Kumar K  <nayankk@motorola.com>
3188
3189         Adding myself to committers list.
3190
3191         Unreviewed.
3192
3193         * Scripts/webkitpy/common/config/committers.py:
3194
3195 2011-12-07  Michael Saboff  <msaboff@apple.com>
3196
3197         StringBuilderTest.Append and StringBuilderTest.ToStringPreserveCapacity are failing.
3198         https://bugs.webkit.org/show_bug.cgi?id=73995
3199
3200         Reenabled failing tests that the code part of the patch fixes.
3201
3202         Reviewed by Geoffrey Garen.
3203
3204         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
3205         (TestWebKitAPI::TEST):
3206
3207 2011-12-07  MORITA Hajime  <morrita@google.com>
3208
3209         [filter-build-webkit] should not emit reset color when --no-color is given
3210         https://bugs.webkit.org/show_bug.cgi?id=73992
3211
3212         Reviewed by Daniel Bates.
3213
3214         Stop printing control sequences when --no-color is given.
3215         After this change, the filter runs nicely even on environments
3216         like Emacs compilation-mode which cannot understand the control sequence.
3217
3218         * Scripts/filter-build-webkit:
3219         (printLine):
3220
3221 2011-12-07  Eric Seidel  <eric@webkit.org>
3222
3223         Use free memory to determine if we have space for DRT instances instead of total memory
3224         https://bugs.webkit.org/show_bug.cgi?id=74021
3225
3226         Reviewed by Adam Barth.
3227
3228         This will hopefully make the Mac buildbots behave better.
3229
3230         I also reduced the expected memory needed per DRT now that
3231         we're properly accounting for the system memory in our calculations.
3232
3233         * Scripts/webkitpy/common/system/platforminfo.py:
3234         (PlatformInfo.total_bytes_memory):
3235         (PlatformInfo._compute_free_bytes_from_vm_stat_output):
3236         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3237         (MockPlatformInfo.total_bytes_memory):
3238         * Scripts/webkitpy/layout_tests/port/base.py:
3239         (Port.default_child_processes):
3240         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3241         (PortTest.test_default_child_processes):
3242
3243 2011-12-07  Dirk Pranke  <dpranke@chromium.org>
3244
3245         fix build-webkit --chromium after breakage in r102201
3246         https://bugs.webkit.org/show_bug.cgi?id=74031
3247
3248         Reviewed by Tony Chang.
3249
3250         r102201 introduced a change to the chromium build that splits
3251         the executables out of WebKit.gyp into other gyp files, and adds
3252         a new "All.gyp" that builds everything. However, I forgot to
3253         update the build script to use All.gyp.
3254
3255         * Scripts/webkitdirs.pm:
3256         (buildChromium):
3257
3258 2011-12-07  Tom Zakrajsek  <tomz@codeaurora.org>
3259
3260         Moved myself to the committers list.
3261
3262         * Scripts/webkitpy/common/config/committers.py:
3263
3264 2011-11-30  Simon Hausmann  <simon.hausmann@nokia.com>
3265
3266         [Qt] Fix debug shlib build with V8.
3267
3268         Reviewed by Tor Arne Vestbø.
3269
3270         * qmake/mkspecs/features/qtwebkit.prf: Don't link jscore with
3271         v8 builds.
3272
3273 2011-11-30  Simon Hausmann  <simon.hausmann@nokia.com>
3274
3275         [Qt] V8 build fixes.
3276
3277         Reviewed by Tor Arne Vestbø.
3278
3279         * qmake/mkspecs/features/javascriptcore.prf: Don't add
3280         Source/Thirdparty to the include search path here.
3281         * qmake/mkspecs/features/webcore.prf: Instead it belongs here, because it's
3282         used when building WebCore as well as using it, because header files like
3283         GraphicsContext3D.h include stuff from ThirdParty.
3284
3285 2011-12-07  Peter Beverloo  <peter@chromium.org>
3286
3287         [Chromium] Fix project file generation for the Android bot after r102201
3288         https://bugs.webkit.org/show_bug.cgi?id=73996
3289
3290         The gyp refactoring in r102201 was didn't explicitly exclude
3291         the Android operating system in Tools/Tools.gyp, which broke
3292         as gcc_version is not defined for that configuration.
3293
3294         Reviewed by Andreas Kling.
3295
3296         * Tools.gyp:
3297
3298 2011-12-07  Vsevolod Vlasov  <vsevik@chromium.org>
3299
3300         Unreviewed. Disabled failing tests on chromium.
3301
3302         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
3303         (TestWebKitAPI::TEST):
3304
3305 2011-12-06  Dirk Pranke  <dpranke@chromium.org>
3306
3307         binaries in webkit.gyp should be split into a new file to break circular dependencies on webkit_support
3308         https://bugs.webkit.org/show_bug.cgi?id=73382
3309
3310         Reviewed by Tony Chang.
3311
3312         XCode (and hence GYP) can't handle circular dependencies between
3313         files (and projects). Accordingly, although the binaries in
3314         WebKit.gyp depend on webkit_support and webkit_support depends
3315         on webkit, we don't mention the latter dependency in the file.
3316         To fix this, this change moves the binaries like DRT into a new
3317         GYP file, and modifies gyp_webkit to build from that file
3318         instead of WebKit.gyp.
3319
3320         * Tools.gyp: Added.
3321
3322 2011-12-06  Adam Roben  <aroben@apple.com>
3323
3324         Add a pid parameter to CrashLogs.find_newest_log
3325
3326         When a PID is passed, only crash logs corresponding to a crashed process with that PID are
3327         considered.
3328
3329         Fixes <http://webkit.org/b/73942> webkitpy provides no way to specify the PID of the crashed
3330         process whose crash log you want to find
3331
3332         Reviewed by Dirk Pranke.
3333
3334         * Scripts/webkitpy/common/system/crashlogs.py:
3335         (CrashLogs.find_newest_log): Added an optional pid parameter.
3336         (CrashLogs._find_newest_log_darwin): Added a pid parameter. When specified, we look at each
3337         candidate log's app_description extended attribute to see if that log corresponds to a
3338         crashed process with the specified PID.
3339
3340         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
3341         (CrashLogsTest.test_find_newest_log_darwin): Added a few more mock crash logs with various
3342         contents and PIDs. Added tests that show that the pid parameter to find_newest_log is
3343         respected. Also fixed an erroneous use of assertTrue instead of assertEqual.
3344
3345         * Scripts/webkitpy/common/system/filesystem.py:
3346         (FileSystem.getxattr): Added. On Darwin, calls through to the xattr module. On other
3347         systems, raises a KeyError, mimicking the behavior on Darwin when the given attribute isn't
3348         present.
3349
3350         * Scripts/webkitpy/common/system/filesystem_mock.py:
3351         (MockFileSystem.__init__): Added an optional xattrs parameter. Documented other parameters.
3352         (MockFileSystem.getxattr): Added. Just pulls the given attribute out of the xattrs
3353         dictionary.
3354
3355         * Scripts/webkitpy/tool/commands/queries.py:
3356         (CrashLog): Added help text. Added an optional PID parameter.
3357         (CrashLog.execute): Pass the PID, if any, through to find_newest_log.
3358
3359 2011-12-06  Adam Roben  <aroben@apple.com>
3360
3361         Wait for Crash Reporter to finish even when it lets the crashed process die quickly
3362
3363         NRWT was only waiting for Crash Reporter in cases where it was keeping the crashed process
3364         alive beyond the normal timeout limit. In cases where the crashed process was able to die
3365         faster, NRWT would assume that Crash Reporter had finished even though it often was still
3366         running, which would lead to an incorrect crash log being picked up.
3367
3368         Part of <http://webkit.org/b/71380> NRWT incorrectly associates crash logs with tests
3369
3370         Reviewed by Dirk Pranke.
3371
3372         * Scripts/webkitpy/layout_tests/port/server_process.py:
3373         (ServerProcess._reset):
3374         (ServerProcess.write):
3375         (ServerProcess._check_for_crash): Changed to use new set_crashed function instead of setting
3376         .crashed directly. Added wait_for_crash_reporter parameter, which we pass along to
3377         set_crashed.
3378
3379         (ServerProcess._handle_timeout): Fixed a logic error that would cause .crashed and
3380         .timed_out both to be set to True in cases where Crash Reporter took a long time to run. Now
3381         we bail out of handling the failure as a timeout if we find out that the process in fact
3382         crashed. We tell _check_for_crash not to wait for Crash Reporter because we've already done
3383         so.
3384         (ServerProcess.set_crashed): Added. When the process crashes, we wait for Crash Reporter to
3385         finish running (unless directed otherwise) so we can be sure the crash log has been saved to
3386         disk.
3387
3388         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
3389         (TrivialMockPort.is_crash_reporter): Added.
3390
3391         * Scripts/webkitpy/layout_tests/port/webkit.py:
3392         (WebKitDriver._check_for_driver_crash): Changed to use set_crashed. (This also fixed a typo
3393         that would have partially broken crash detection on Windows, if NRWT worked on Windows.)
3394
3395 2011-12-06  Adam Barth  <abarth@webkit.org>
3396
3397         NRWT fails on unreleased versions of Mac OS X
3398         https://bugs.webkit.org/show_bug.cgi?id=72748
3399
3400         Reviewed by Dirk Pranke.
3401
3402         Hopefully this patch will make NRWT work on future versions on Mac OS X.
3403         Most of the infrastructure was already in place, but there were some
3404         asserts that failed.  I've tested this patch by haxoring the version
3405         detection logic to simulate an unknown version.  We might need to
3406         iterate based on feedback from folks with a real future version.
3407
3408         * Scripts/webkitpy/layout_tests/port/apple.py:
3409         (ApplePort.__init__):
3410             - mac-future is an allowed port_name that's used internally by
3411               webkitpy to represent future versions of Mac OS X.
3412         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3413         (test_versions):
3414             - Test that we don't throw exceptions when dealing with future
3415               versions of Mac OS X.
3416         * Scripts/webkitpy/layout_tests/port/webkit.py:
3417         (WebKitPort._expectations_from_skipped_files):
3418             - Demote this logging message to "debug".  It's expected that
3419               mac-future doesn't have a Skipped file.
3420         * Scripts/webkitpy/layout_tests/port/mac.py:
3421         (MacPort.__init__):
3422         * Scripts/webkitpy/layout_tests/port/win.py:
3423         (WinPort.__init__):
3424             - Re-order some code in these constructors so that
3425               self._operating_system is available to the ApplePort constructor.
3426
3427 2011-12-06  Tommy Widenflycht  <tommyw@google.com>
3428
3429         Added myself as a committer.
3430
3431         * Scripts/webkitpy/common/config/committers.py:
3432
3433 2011-12-06  Peter Beverloo  <peter@chromium.org>
3434
3435         Added myself as a committer.
3436
3437         * Scripts/webkitpy/common/config/committers.py:
3438
3439 2011-12-06  Kentaro Hara  <haraken@chromium.org>
3440
3441         [Refactoring] In webkitpy/bindings/main.py, replace subprocess.Popen() with Executive
3442         https://bugs.webkit.org/show_bug.cgi?id=73637
3443
3444         Reviewed by Adam Barth.
3445
3446         This patch replaces subprocess.Popen() with Executive, similar to other
3447         Python scripts in webkitpy/. I manually confirmed that run-bindings-tests
3448         works well for cases where no exception is raised, no exception is raised
3449         but diff is found, and ScriptError is raised.
3450
3451         * Scripts/run-bindings-tests:
3452         (main):
3453         * Scripts/webkitpy/bindings/main.py: Replaces subprocess.Popen() with Executive.
3454         (BindingsTests.__init__):
3455         (BindingsTests.generate_from_idl):
3456         (BindingsTests.generate_supplemental_dependency):
3457         (BindingsTests.detect_changes):
3458
3459 2011-12-05  Alexander Færøy  <alexander.faeroy@nokia.com>
3460
3461         [Qt] MiniBrowser should default to touch behavior
3462         https://bugs.webkit.org/show_bug.cgi?id=73863
3463
3464         Reviewed by Chang Shu.
3465
3466         MiniBrowser currently defaults to the traditional desktop behaviour
3467         instead of touch behaviour which is prefered.
3468
3469         * MiniBrowser/qt/BrowserWindow.cpp:
3470         (BrowserWindow::BrowserWindow):
3471         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3472         (printHelp):
3473         (MiniBrowserApplication::handleUserOptions):
3474         * MiniBrowser/qt/MiniBrowserApplication.h:
3475         (WindowOptions::WindowOptions):
3476         (WindowOptions::setUseTraditionalDesktopBehavior):
3477         (WindowOptions::useTraditionalDesktopBehavior):
3478
3479 2011-12-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
3480
3481         webkit.py: Really fix the printing of StringImpl now that 8-bit strings are present.
3482         https://bugs.webkit.org/show_bug.cgi?id=73878
3483
3484         Reviewed by Tony Chang.
3485
3486         r98624 turned StringImpl::m_data into StringImpl::{m_data8,m_data16}.
3487         r98785 made webkit.py always use m_data16, which does not work when
3488         the string is an 8-bit string (such as KURL::string()).
3489
3490         I was not able to directly call StringImpl::is8Bit() in the Python
3491         code, so I just reproduced the implementation there.
3492
3493         * gdb/webkit.py:
3494         (WTFStringPrinter.is_8bit): Reproduced StringImpl::is8Bit().
3495         (WTFStringPrinter.to_string):
3496         (JSCUStringPrinter.is_8bit): Reproduced StringImpl::is8Bit().
3497         (JSCUStringPrinter.to_string):
3498
3499 2011-12-05  Eric Seidel  <eric@webkit.org>
3500
3501         Up the "expected ram for each DRT instance" to 400MB instead of 300MB
3502         in hopes of making the Snow Leopard bot stop timing out.
3503
3504         Unreviewed.
3505
3506         * Scripts/webkitpy/layout_tests/port/base.py:
3507         (Port.default_child_processes):
3508         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3509         (PortTest.test_default_child_processes):
3510
3511 2011-12-05  Eric Seidel  <eric@webkit.org>
3512
3513         NRWT creates too many workers on RAM-limited machines
3514         https://bugs.webkit.org/show_bug.cgi?id=73847
3515
3516         Reviewed by Dirk Pranke.
3517
3518         Make NRWT restrict its number of workers when there isn't enough
3519         RAM to support them.
3520         Also re-enable parallel testing on the Mac bots which were
3521         failing due to not enough ram.
3522
3523         * Scripts/run-webkit-tests:
3524         (platformIsReadyForParallelTesting):
3525         * Scripts/webkitpy/common/host.py:
3526         (Host.__init__):
3527         * Scripts/webkitpy/common/system/executive_mock.py:
3528         (MockExecutive.cpu_count):
3529         * Scripts/webkitpy/common/system/platforminfo.py:
3530         (PlatformInfo.__init__):
3531         (PlatformInfo.display_name):
3532         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3533         (MockPlatformInfo.display_name):
3534         * Scripts/webkitpy/layout_tests/port/base.py:
3535         (Port.default_child_processes):
3536         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3537         (PortTest.test_default_child_processes):
3538         (PortTest.test_pretty_patch_os_error):
3539
3540 2011-12-05  Hugo Parente Lima  <hugo.lima@openbossa.org>
3541
3542         Last mouse event could be lost if a JS call to eventSender.leapForward is made
3543         https://bugs.webkit.org/show_bug.cgi?id=73366
3544
3545         Reviewed by Kenneth Rohde Christiansen.
3546
3547         Empty the entire event queue when requested besides using
3548         sendEvent instead of postEvent to make sure all events were
3549         delivered.
3550
3551         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
3552         (WTR::EventSenderProxy::EventSenderProxy):
3553         (WTR::EventSenderProxy::sendOrQueueEvent):
3554         (WTR::EventSenderProxy::replaySavedEvents):
3555
3556 2011-12-05  Adam Barth  <abarth@webkit.org>
3557
3558         [Chromium] Remove no-longer-used forwarding headers in the WebKit API
3559         https://bugs.webkit.org/show_bug.cgi?id=73845
3560
3561         Reviewed by Darin Fisher.
3562
3563         Update includes to point to the new header locations.
3564
3565         * DumpRenderTree/chromium/AccessibilityController.cpp:
3566         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3567         * DumpRenderTree/chromium/CppBoundClass.cpp:
3568         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
3569         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3570         * DumpRenderTree/chromium/DRTDevToolsClient.h:
3571         * DumpRenderTree/chromium/EventSender.cpp:
3572         * DumpRenderTree/chromium/EventSender.h:
3573         * DumpRenderTree/chromium/GamepadController.h:
3574         * DumpRenderTree/chromium/LayoutTestController.cpp:
3575         * DumpRenderTree/chromium/LayoutTestController.h:
3576         * DumpRenderTree/chromium/MockSpellCheck.cpp:
3577         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3578         * DumpRenderTree/chromium/PlainTextController.cpp:
3579         * DumpRenderTree/chromium/Task.cpp:
3580         * DumpRenderTree/chromium/TestNavigationController.h:
3581         * DumpRenderTree/chromium/TestShell.cpp:
3582         * DumpRenderTree/chromium/TestWebPlugin.cpp:
3583         * DumpRenderTree/chromium/TestWebPlugin.h:
3584         * DumpRenderTree/chromium/TextInputController.cpp:
3585         * DumpRenderTree/chromium/WebPermissions.cpp:
3586         * DumpRenderTree/chromium/WebPreferences.h:
3587         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
3588         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
3589         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
3590         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
3591         * DumpRenderTree/chromium/WebViewHost.cpp:
3592
3593 2011-12-05  Ryosuke Niwa  <rniwa@webkit.org>
3594
3595         Add Aharon Lanin to the contributors list.
3596
3597         * Scripts/webkitpy/common/config/committers.py:
3598
3599 2011-12-05  Jarred Nicholls  <jarred@sencha.com>
3600
3601         Moving myself from contributors to committers.
3602
3603         * Scripts/webkitpy/common/config/committers.py:
3604
3605 2011-12-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
3606
3607         Add myself as a committer.
3608
3609         * Scripts/webkitpy/common/config/committers.py:
3610
3611 2011-12-05  Michael Brüning  <michael.bruning@nokia.com>
3612
3613         [Qt] Rename QQuickWebView::canStop property to just loading 
3614         https://bugs.webkit.org/show_bug.cgi?id=73813
3615
3616         Reviewed by Kenneth Rohde Christiansen.
3617
3618         Replaced references to WebView.canStop with WebView.loading.
3619
3620         * MiniBrowser/qt/qml/BrowserWindow.qml:
3621
3622 2011-12-05  Dirk Pranke  <dpranke@chromium.org>
3623
3624         run-webkit-tests: limit --child-processes properly on apple mac
3625         https://bugs.webkit.org/show_bug.cgi?id=73856
3626
3627         Reviewed by Adam Roben.
3628
3629         Fix typos in r102013 so that we correctly pass --child-processes=1 on
3630         the apple mac bots temporarily.
3631
3632         * Scripts/run-webkit-tests:
3633         (platformIsReadyForParallelTesting):
3634
3635 2011-12-05  Ryosuke Niwa  <rniwa@webkit.org>
3636
3637         Temporarily set --child-process=1 on Mac because 20+ tests are timing out
3638         https://bugs.webkit.org/show_bug.cgi?id=73840
3639
3640         Reviewed by Simon Fraser.
3641
3642         Temporarily go back to single process mode on Mac.
3643
3644         * Scripts/run-webkit-tests:
3645         (platformIsReadyForParallelTesting):
3646
3647 2011-12-05  Adam Roben  <aroben@apple.com>
3648