REGRESSION (r201263): Some tests have become flaky timeouts.
[WebKit-https.git] / Tools / ChangeLog
1 2016-06-04  Alexey Proskuryakov  <ap@apple.com>
2
3         REGRESSION (r201263): Some tests have become flaky timeouts.
4         https://bugs.webkit.org/show_bug.cgi?id=157990
5
6         Reviewed by Darin Adler.
7
8         * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke):
9         It is somewhat legitimate for WebContent to not respond to messages after the test
10         is done; it can be e.g. re-doing a costly repaint. So, we should restart is silently,
11         without making the current test fail.
12
13 2016-06-03  Youenn Fablet  <youenn.fablet@crf.canon.fr>
14
15         [GTK] Update YouCompleteMe script to make all include paths absolute
16         https://bugs.webkit.org/show_bug.cgi?id=158301
17
18         Reviewed by Michael Catanzaro.
19
20         Before this patch, some include paths were not made absolute.
21         This could make YouCompleteMe plugin to fail extracting information or validating cpp files.
22
23         * gtk/ycm_extra_conf.py:
24
25 2016-06-03  Nael Ouedraogo  <nael.ouedraogo@crf.canon.fr>
26
27         Unreviewed: add myself to the committers list.
28
29         * Scripts/webkitpy/common/config/contributors.json:
30
31 2016-06-02  Per Arne Vollan  <pvollan@apple.com>
32
33         [Win] Fetch API tests are failing.
34         https://bugs.webkit.org/show_bug.cgi?id=158296
35
36         Reviewed by Alex Christensen.
37
38         Enable Fetch API when running tests.
39
40         * DumpRenderTree/win/DumpRenderTree.cpp:
41         (resetWebPreferencesToConsistentValues):
42
43 2016-06-02  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
44
45         Really display failing JSC stress tests in buildbot dashboard
46         https://bugs.webkit.org/show_bug.cgi?id=158324
47
48         Reviewed by Alexey Proskuryakov.
49
50         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
51         (BuildbotCombinedQueueView.prototype.update): Correctly check for string membership in array.
52         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
53         (BuildbotIteration.prototype._parseData): Correctly check for string membership in array.
54         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
55         (BuildbotQueueView.prototype._popoverContentForJavaScriptCoreTestRegressions): Correctly check for string
56         membership in array.
57         (BuildbotQueueView.prototype._presentPopoverForJavaScriptCoreTestRegressions): Ensure that the correct URL is
58         generated after the first time.
59         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
60         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Correctly check for string membership in array.
61
62 2016-06-02  Michael Saboff  <msaboff@apple.com>
63
64         [iOS]: Some JSC stress tests fail running out of executable memory when the LLInt is disabled
65         https://bugs.webkit.org/show_bug.cgi?id=158317
66
67         Reviewed by Saam Barati.
68
69         Added defaultNoNoLLIntRun variant to run the default tests with the exception of the no-llint
70         variant.
71
72         * Scripts/run-jsc-stress-tests:
73
74 2016-06-02  Aakash Jain  <aakash_jain@apple.com>
75
76         LayoutTests time out intermittently due to alert about reopening Simulator after it unexpectedly quit
77         https://bugs.webkit.org/show_bug.cgi?id=158305
78
79         Reviewed by Alexey Proskuryakov.
80
81         * Scripts/webkitpy/port/ios.py:
82         (IOSSimulatorPort.clean_up_test_run): Delete simulator's savedState directories during cleanup.
83
84 2016-06-01  Brian Burg  <bburg@apple.com>
85
86         REGRESSION(r191907): Can't enter combining diacritic marks in Web Inspector fields
87         https://bugs.webkit.org/show_bug.cgi?id=158227
88         <rdar://problem/26232464>
89
90         Reviewed by Alexey Proskuryakov.
91
92         Add a regression test that runs on Mac only.
93
94         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
95         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewTextInput.mm: Added.
96         (-[DummyNavigationDelegate webView:didFinishNavigation:]):
97         (TEST):
98         * TestWebKitAPI/Tests/WebKit2Cocoa/editable-body.html: Added.
99
100 2016-06-01  Chris Fleizach  <cfleizach@apple.com>
101
102         AX: iOS: VoiceOver can't access attachments in mail messages
103         https://bugs.webkit.org/show_bug.cgi?id=158198
104
105         Reviewed by Joanmarie Diggs.
106
107         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
108         (AccessibilityUIElement::stringForRange):
109         (AccessibilityUIElement::attributedStringForRange):
110         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
111         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
112         (WTR::AccessibilityUIElement::attributedStringForRange):
113         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
114
115 2016-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
116
117         Unreviewed. Mark GTK+ test /webkit2/WebKitWebInspectorServer/test-open-debugging-session as slow.
118
119         It's timing out in the bots, but it seems to pass when running run-gtk-tests with no timeout. For GLib tests the
120         timeout is applied per tester program not per test case, so we need to mark the whole test
121         WebKit2Gtk/TestInspectorServer as slow.
122
123         * Scripts/run-gtk-tests:
124         (TestRunner):
125         (TestRunner._run_test_glib):
126
127 2016-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
128
129         Unreviewed. Skip media permission request GTK+ unit tests.
130
131         They are timing out in the bots.
132
133         * Scripts/run-gtk-tests:
134         (TestRunner):
135
136 2016-05-31  Jer Noble  <jer.noble@apple.com>
137
138         Yet another unreviewed build fix; move the closing brace of the namespace declaration inside
139         the #if check.
140
141         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
142
143 2016-05-31  Jer Noble  <jer.noble@apple.com>
144
145         Further unreviewed build fix; only run FullscreenTopContentInset test on Mac.
146
147         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
148
149 2016-05-31  Jer Noble  <jer.noble@apple.com>
150
151         Unreviewed build fix; only run FullscreetTopContentInset test on platforms
152         where WK_API_ENABLED is set.
153
154         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
155
156 2016-05-31  Jer Noble  <jer.noble@apple.com>
157
158         REGRESSION (r201405): trailers.apple.com HUD is missing in fullscreen
159         https://bugs.webkit.org/show_bug.cgi?id=158156
160         <rdar://problem/26519589>
161
162         Reviewed by Darin Adler.
163
164         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
165         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.html: Added.
166         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm: Added.
167         (-[FullscreenChangeMessageHandler userContentController:didReceiveScriptMessage:]):
168         (TestWebKitAPI::TEST):
169
170 2016-05-31  Jon Lee  <jonlee@apple.com>
171
172         Unreviewed: add myself to the reviewers list.
173
174         * Scripts/webkitpy/common/config/contributors.json:
175
176 2016-05-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
177
178         [GTK] Provide alternative mirror for the ICU tarball.
179         https://bugs.webkit.org/show_bug.cgi?id=154530
180
181         Unreviewed.
182
183         * gtk/jhbuild.modules: After r201449 the GTK+ ARM buildbot is having
184         a hard time trying to download the ICU tarball from download.icu-project.org
185         (which redirects to sourceforge and gives problems with something related to
186         SSL). Provide this alternative mirror to make things working back.
187
188 2016-05-31  Carlos Garcia Campos  <cgarcia@igalia.com>
189
190         [GTK] Test /webkit2/WebKitWebView/geolocation-permission-requests is failing since r201423
191         https://bugs.webkit.org/show_bug.cgi?id=158200
192
193         Reviewed by Philippe Normand.
194
195         This is because geolocation is no longer allowed for non secure sites, like HTTP. In that case
196         POSITION_UNAVAILABLE is returned without asking the API layer.
197
198         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
199         (testWebViewGeolocationPermissionRequests): Keep the HTTP case to check that it indeed returns
200         POSITION_UNAVAILABLE and use HTTPS URLs to check permission requests are allowed or denied. Also stop using the
201         document title, and use user script messages that are more reliable instead.
202
203 2016-05-28  Aakash Jain  <aakash_jain@apple.com>
204
205         tests fail if display sleeps while run-webkit-tests is running
206         https://bugs.webkit.org/show_bug.cgi?id=153919
207
208         Reviewed by Darin Adler.
209
210         * DumpRenderTree/mac/LayoutTestHelper.m:
211         (addDisplaySleepAssertion): Use PreventUserIdleSystemSleep flag, same as set by caffeinate tool.
212
213 2016-05-27  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
214
215         Display failing JSC stress tests in buildbot dashboard
216         https://bugs.webkit.org/show_bug.cgi?id=156595
217
218         Reviewed by Alexey Proskuryakov.
219
220         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
221         (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration):
222         (Buildbot.prototype.javaScriptCoreTestStdioUrlForIteration):
223         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
224         (BuildbotCombinedQueueView.prototype.update):
225         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
226         (BuildbotIteration):
227         (BuildbotIteration.prototype._parseData):
228         (BuildbotIteration.prototype.loadLayoutTestResults):
229         (BuildbotIteration.prototype.):
230         (BuildbotIteration.prototype.loadJavaScriptCoreTestResults):
231         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
232         (BuildbotQueueView.prototype._createLoadingIndicator):
233         (BuildbotQueueView.prototype.):
234         (BuildbotQueueView.prototype._onPopoverCopy):
235         (BuildbotQueueView.prototype._popoverContentForJavaScriptCoreTestRegressions):
236         (BuildbotQueueView.prototype._presentPopoverForJavaScriptCoreTestRegressions):
237         (BuildbotQueueView.prototype._addIterationHeadingToPopover):
238         (BuildbotQueueView.prototype._testStepFailureDescription):
239         (BuildbotQueueView.prototype._testStepFailureDescriptionWithCount):
240         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
241         (BuildbotTestResults.prototype.addJavaScriptCoreTestFailures):
242         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
243         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus):
244         (BuildbotTesterQueueView.prototype.update):
245         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
246         (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions):
247         (BuildbotTesterQueueView.prototype._testStepFailureDescription): Deleted.
248         (BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount): Deleted.
249         (BuildbotTesterQueueView.prototype.): Deleted.
250         (BuildbotTesterQueueView.prototype.content.oncopy): Deleted.
251         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html:
252         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js.
253         (MockBuildbot):
254         (MockBuildbot.prototype.buildPageURLForIteration):
255         (MockBuildbot.prototype.javaScriptCoreTestFailuresURLForIteration):
256         (MockBuildbot.prototype.javaScriptCoreTestStdioUrlForIteration):
257         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js:
258         (MockBuildbotQueue):
259         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotTestResults.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js.
260         (MockBuildbotTestResults):
261         (MockBuildbotTestResults.prototype.addJavaScriptCoreTestFailures):
262         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/test-jsc-results.json: Added.
263         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
264
265 2016-05-27  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
266
267         Display failing JSC stress tests in buildbot dashboard
268         https://bugs.webkit.org/show_bug.cgi?id=156595
269
270         Reviewed by Alexey Proskuryakov.
271
272         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
273         (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Generate the URL for raw JSON output of
274         JSC tests.
275         (Buildbot.prototype.javaScriptCoreTestStdioURLForIteration): Generate the URL for human-readable stdio output
276         of JSC tests.
277         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
278         (BuildbotCombinedQueueView.prototype.update): Display JSC test results in popover.
279         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
280         (BuildbotIteration): Add javaScriptCoreTestResults variable.
281         (BuildbotIteration.prototype.): Check for javascriptcore tests step.
282         (BuildbotIteration.prototype.loadLayoutTestResults): Add comma at closing brace.
283         (BuildbotIteration.prototype.loadJavaScriptCoreTestResults): Fetch JSON from Buildbot server.
284         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
285         (BuildbotQueueView.prototype._createLoadingIndicator): Reusable function.
286         (BuildbotQueueView.prototype._onPopoverCopy): Reusable copy event handler to allow accurate copying of text
287         from popovers.
288         (BuildbotQueueView.prototype._popoverContentForJavaScriptCoreTestRegressions): Generates the popover bubble's
289         inner HTML from the JSC failure data.
290         (BuildbotQueueView.prototype._presentPopoverForJavaScriptCoreTestRegressions): Generate the popover bubble
291         for JSC results and handle request failures.
292         (BuildbotQueueView.prototype._testStepFailureDescription): Moved from subclass.
293         (BuildbotQueueView.prototype._testStepFailureDescriptionWithCount): Moved from subclass.
294         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
295         (BuildbotTestResults.prototype.addJavaScriptCoreTestFailures): Parse JSON into a list of failing tests.
296         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
297         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Instantiate PopoverTrackers for builds whose 
298         only failures are JSC tests.
299         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions): Use _onPopoverCopy.
300         (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions): Use _createLoadingIndicator.
301         (BuildbotTesterQueueView.prototype._testStepFailureDescription): Deleted. Moved to superclass.
302         (BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount): Deleted. Moved to superclass.
303         (BuildbotTesterQueueView.prototype.content.oncopy): Deleted. Using superclass's reusable function as copy handler instead.
304         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Add new script files.
305         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js: Added.
306         (MockBuildbot): Mocked version of Buildbot, only containing URL methods.
307         (MockBuildbot.prototype.buildPageURLForIteration): Same as real Buildbot.js
308         (MockBuildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Points to local file containing JSON for test.
309         (MockBuildbot.prototype.javaScriptCoreTestStdioURLForIteration): Same as real Buildbot.js
310         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js:
311         (MockBuildbotQueue): Use a MockBuildbot() instead of a string.
312         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotTestResults.js: Added.
313         (MockBuildbotTestResults): Mocked version of BuildbotTestResults.
314         (MockBuildbotTestResults.prototype.addJavaScriptCoreTestFailures): Sets the 'regressions' variable.
315         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/test-jsc-results.json: Added.
316         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js: Add four groups of tests.
317
318 2016-05-27  Chris Dumez  <cdumez@apple.com>
319
320         WorkQueue::dispatch() / RunLoop::dispatch() should not copy captured lambda variables
321         https://bugs.webkit.org/show_bug.cgi?id=158111
322
323         Reviewed by Darin Adler.
324
325         WorkQueue::dispatch() / RunLoop::dispatch() should not copy captured lambda variables.
326         These are often used cross-thread and copying the captured lambda variables can be
327         dangerous (e.g. we do not want to copy a String after calling isolatedCopy() upon
328         capture).
329
330         * WebKitTestRunner/TestController.cpp:
331         (WTR::TestController::decidePolicyForNavigationAction):
332
333 2016-05-27  Brady Eidson  <beidson@apple.com>
334
335         Modern IDB: After closing a Netflix video, trying to watch it again fails.
336         <rdar://problem/25092473> and https://bugs.webkit.org/show_bug.cgi?id=158160
337
338         Reviewed by Alex Christensen.
339
340         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
341         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup-1.html: Added.
342         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup-2.html: Added.
343         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm: Added.
344
345 2016-05-27  Joanmarie Diggs  <jdiggs@igalia.com>
346
347         AX: [ATK] accessibility/gtk/no-notification-for-unrendered-iframe-children.html began failing after r201416
348         https://bugs.webkit.org/show_bug.cgi?id=158152
349
350         Reviewed by Chris Fleizach.
351
352         The failure is actually a bug fix because only one child is being added, but two
353         notifications were being emitted. Now there is only one notification. To verify
354         this was the case, we really should examine the child reportedly being added. That
355         child is the ATK event's any_data, so pass along that child to the listener.
356
357         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
358
359 2016-05-26  Alex Christensen  <achristensen@webkit.org>
360
361         Expose content extension failure error codes in SPI
362         https://bugs.webkit.org/show_bug.cgi?id=158095
363         rdar://problem/26475651
364
365         Reviewed by Anders Carlsson.
366
367         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
368         (checkDomain):
369         (TEST_F):
370         Add tests that use the new enum.
371
372 2016-05-27  Carlos Garcia Campos  <cgarcia@igalia.com>
373
374         New intl-numberformat.js test fails on many Linux platforms
375         https://bugs.webkit.org/show_bug.cgi?id=154530
376
377         Reviewed by Darin Adler.
378
379         The test is actually failing because of a bug in the icu version installed in the bots, using a newer version of
380         icu makes the tests pass and explains why it worked for some people. So, let's add icu 55.1 to the internal
381         jhbuild to ensure JSC tests pass in the bots no matter what the icu version installed is.
382
383         * gtk/jhbuild.modules:
384
385 2016-05-26  Yusuke Suzuki  <utatane.tea@gmail.com>
386
387         [JSC] Allow JSBench to use precise time
388         https://bugs.webkit.org/show_bug.cgi?id=158050
389
390         Reviewed by Geoffrey Garen.
391
392         JSBench use `new Date().getTime()` without options and there is no way to use precise time.
393         This patch modifies the JSBench code to inject the code taking the precise time.
394         `currentTimeInMS` is given by the benchmerk harness and JSBench uses it.
395         run-jsc-benchmark switches this function's implementation between `Date.now()` and
396         testRunner's precise time one.
397
398         While this patch modifies the code of JSBench, the last release of JSBench is Jan 2013 and
399         the contents are not changed for a long time. As described in the original paper[1], the
400         tests can be generated by using JSBench's record & replay system, but in that case, we can
401         adopt this modification by changing the tool side.
402
403         We also add currentTimeInMS implementation in harness.js and u?rem.js directly.
404         u?rem.js implementation is required when it is executed in u?rem.html without harness.
405         And harness.js implementation is required when it is executed in the JSBench's harness.
406         In these implementation, we follow the JetStream's time measuring function: performance.now(),
407         preciseTime(), or Date.now().
408
409         [1]: http://dl.acm.org/citation.cfm?id=2048119
410
411         * Scripts/run-jsc-benchmarks:
412
413 2016-05-26  Brent Fulgham  <bfulgham@apple.com>
414
415         Unreviewed test fix after r201427.
416         https://bugs.webkit.org/show_bug.cgi?id=157423
417         <rdar://problem/23751632>
418
419         A debug assertion was firing during some test runs due to the Geolocation permission
420         being turned off during the test. The timer logic was originally written to assert
421         if the timer fired when permissions were disabled. But this is no longer valid,
422         because we expect the Geolocation system to be active and become deactivated if the
423         browsing context violates one of the security criteria.
424
425         * DumpRenderTree/mac/UIDelegate.mm:
426         (-[UIDelegate timerFired]): Remove invalid assertion.
427
428 2016-05-26  Filip Pizlo  <fpizlo@apple.com>
429
430         ScopedLambda should have a lifetime story that makes sense to the compiler
431         https://bugs.webkit.org/show_bug.cgi?id=158118
432
433         Reviewed by Mark Lam.
434         
435         Added a test case. This test crashes before the fix and now it passes.
436
437         * TestWebKitAPI/CMakeLists.txt:
438         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
439         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp: Added.
440         (TestWebKitAPI::TEST):
441
442 2016-05-26  Myles C. Maxfield  <mmaxfield@apple.com>
443
444         Build fix
445
446         Rubber stamped by Lucas Forschler.
447
448         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
449         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
450
451 2016-05-25  Anders Carlsson  <andersca@apple.com>
452
453         Get rid of WTF/Functional.h
454         https://bugs.webkit.org/show_bug.cgi?id=158081
455
456         Reviewed by Chris Dumez.
457
458         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
459         * TestWebKitAPI/Tests/WTF/Functional.cpp: Removed.
460         (TestWebKitAPI::returnFortyTwo): Deleted.
461         (TestWebKitAPI::TEST): Deleted.
462         (TestWebKitAPI::multiplyByTwo): Deleted.
463         (TestWebKitAPI::multiplyByOneAndAHalf): Deleted.
464         (TestWebKitAPI::multiply): Deleted.
465         (TestWebKitAPI::subtract): Deleted.
466         (TestWebKitAPI::A::A): Deleted.
467         (TestWebKitAPI::A::f): Deleted.
468         (TestWebKitAPI::A::addF): Deleted.
469         (TestWebKitAPI::B::B): Deleted.
470         (TestWebKitAPI::B::~B): Deleted.
471         (TestWebKitAPI::B::ref): Deleted.
472         (TestWebKitAPI::B::deref): Deleted.
473         (TestWebKitAPI::B::f): Deleted.
474         (TestWebKitAPI::B::g): Deleted.
475         (TestWebKitAPI::Number::create): Deleted.
476         (TestWebKitAPI::Number::~Number): Deleted.
477         (TestWebKitAPI::Number::value): Deleted.
478         (TestWebKitAPI::Number::Number): Deleted.
479         (TestWebKitAPI::multiplyNumberByTwo): Deleted.
480
481 2016-05-25  Daniel Bates  <dabates@apple.com> and Brent Fulgham  <bfulgham@apple.com>
482
483         [WebSockets] No infrastructure for testing secure web sockets (wss)
484         https://bugs.webkit.org/show_bug.cgi?id=157884
485         <rdar://problem/26477197>
486
487         Reviewed by Andy Estes.
488
489         Add support to webkitpy to start and stop a secure Web Socket server running on port 9323
490         using the certificate, private-key from file LayoutTests/http/conf/webkit-httpd.pem. Also
491         teaches run-webkit-httpd to start and stop the Web Socket servers.
492
493         Modify DumpRenderTree and WebKitTestRunner to understand a new testRunner method,
494         'setAllowsAnySSLCertificate', which allows us to use the same self-signed test certificate
495         we do for our HTTPS tests.
496         
497         * DumpRenderTree/TestRunner.cpp:
498         (setAllowsAnySSLCertificateCallback):
499         (TestRunner::setAllowsAnySSLCertificate):
500         * DumpRenderTree/TestRunner.h:
501         * DumpRenderTree/mac/DumpRenderTree.mm:
502         (resetWebViewToConsistentStateBeforeTesting): Make sure we turn off the new flag between tests.
503         * Scripts/run-webkit-httpd:
504         (main): Start the websocket server at launch.
505         * Scripts/webkitpy/layout_tests/controllers/manager.py:
506         (Manager.__init__): Remove dead code.
507         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
508         (PyWebSocket.__init__): Cleanup code.
509         (PyWebSocket): Pass '--tls-client-ca' to start command.
510         (PyWebSocket._prepare_config): Cleanups.
511         * Scripts/webkitpy/port/base.py:
512         (Port.to.start_http_server):
513         (Port.to):
514         (Port.to._extract_certificate_from_pem): Added.
515         (Port.to._extract_private_key_from_pem): Added.
516         (Port.to.start_websocket_server): Start secure socket server.
517         (Port.to.stop_websocket_server): Stop secure socket server.
518         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Add new API.
519         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
520         (WTR::InjectedBundle::setAllowsAnySSLCertificate): Added.
521         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
522         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
523         (WTR::TestRunner::setAllowsAnySSLCertificate): Added.
524         * WebKitTestRunner/InjectedBundle/TestRunner.h:
525
526 2016-05-25  Keith Miller  <keith_miller@apple.com>
527
528         run-jsc-benchmarks should use the new JSBench rather than look for it in the config file.
529         https://bugs.webkit.org/show_bug.cgi?id=158077
530
531         Reviewed by Mark Lam.
532
533         Since we didn't have JSBench in the tree before we needed to lookup the path to it from
534         benchmark config file. That's no longer the case so we should just fix it in the script.
535
536         * Scripts/run-jsc-benchmarks:
537
538 2016-05-24  Aakash Jain  <aakash_jain@apple.com>
539
540         Reorganize dashboard code: move code from _timeIntervalString to base class
541         https://bugs.webkit.org/show_bug.cgi?id=158047
542         rdar://problem/26457274
543
544         Reviewed by Alexey Proskuryakov and Dean Johnson.
545
546         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js:
547         (BubbleQueueView.prototype._timeIntervalString): Moved core logic to base class so as to make it re-usable.
548         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
549         (QueueView.prototype._readableTimeString): Same.
550
551 2016-05-24  Yusuke Suzuki  <utatane.tea@gmail.com>
552
553         [JSC][GTK][EFL] Allow run-jsc-benchmark to use WebKitTestRunner in EFL / GTK ports
554         https://bugs.webkit.org/show_bug.cgi?id=158016
555
556         Reviewed by Darin Adler.
557
558         This patch easily allows run-jsc-benchmark to run WebKitTestRunner-based tests in GTK / EFL ports.
559         This change encourages us to run tests with the browser-heap in nix environments.
560         Two things are modified.
561
562         1. Add a fall-back to look up the library path in GTK / EFL / JSCOnly environment.
563
564             In GTK / EFL / JSCOnly ports, the hierarchy of the build directory is slightly different from Apple port.
565             For example, the jsc bin locate at "WebKitBuild/XXX/Release/bin/jsc" and the lib path is "WebKitBuild/XXX/Release/lib"
566             while the one of Apple port is "WebKitBuild/XXX/Release/jsc" and "WebKitBuild/XXX/Release/lib".
567             And based on this library path, we configure the required environment variables to run WebKitTestRunner in GTK / EFL ports.
568
569         2. Add --dependencies option to add dependent library paths.
570
571             While Apple ports does not require any additional dependent library path, GTK and EFL ports require this path,
572             typically WebKitBuild/DependenciesGTK and WebKitBuild/DependenciesEFL respectively. So we need to add such paths to LD_LIBRARY_PATH.
573             Instead of adding platform options like --gtk / --efl, we add --dependencies option to add the additional dependent library paths.
574             The platform options still require the build path to look up the dependent library directory. So we pass it directly through --dependencies.
575             Multiple additional dependent library paths can be added by using --dependencies multiple times.
576
577         By using these change, we can run benchmarks that require WebKitTestRunner in GTK / EFL ports (If you would like to run them in a headless manner, you can use xvbuf.).
578         Example:
579             `Tools/Scripts/run-jsc-benchmarks baseline:WebKitBuild/baseline/Release/bin/WebKitTestRunner patched:WebKitBuild/patched/Release/bin/WebKitTestRunner --dependencies WebKitBuild/DependenciesGTK/Root/lib --js-bench`
580
581         * Scripts/run-jsc-benchmarks:
582
583 2016-05-20  Keith Miller  <keith_miller@apple.com>
584         We should have JSBench in PerformanceTests
585         https://bugs.webkit.org/show_bug.cgi?id=157952
586
587         Rubber-stamped by Saam Barati.
588
589         This changes the runner to use the layout of the newest version of JSBench.
590
591         * Scripts/run-jsc-benchmarks:
592
593 2016-05-24  Chris Dumez  <cdumez@apple.com>
594
595         Use auto for some of our lambda function parameters
596         https://bugs.webkit.org/show_bug.cgi?id=158001
597
598         Reviewed by Darin Adler.
599
600         Use auto for some of our lambda function parameters now that we build with c++14.
601
602         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
603         (WTR::InjectedBundle::willDestroyPage):
604
605 2016-05-23  Brady Eidson  <beidson@apple.com>
606
607         check-webkit-style gets flags std::literals::chrono_literals as bad naming.
608         https://bugs.webkit.org/show_bug.cgi?id=157969
609
610         Reviewed by Alex Christensen.
611
612         * Scripts/webkitpy/style/checkers/cpp.py:
613         (check_identifier_name_in_declaration):
614         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
615         (WebKitStyleTest.test_names):
616
617 2016-05-22  Alexey Proskuryakov  <ap@apple.com>
618
619         RELEASE_ASSERT(TestController::singleton().isCurrentInvocation(testInvocation)) is sometimes hit when running tests
620         https://bugs.webkit.org/show_bug.cgi?id=157977
621         rdar://problem/20874156
622
623         Reviewed by David Kilzer.
624
625         * WebKitTestRunner/TestInvocation.cpp:
626         (WTR::TestInvocation::invoke): Be more certain to launch a new process when there was
627         a timeout detected. If we don't, there is a chance that the process is not quite frozen,
628         and will still send a response that we no longer expect.
629         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Print timeout details to stderr
630         too, as stdout is not available, at least not in the case that I was observing.
631
632 2016-05-22  Brady Eidson  <beidson@apple.com>
633
634         Move to C++14.
635         https://bugs.webkit.org/show_bug.cgi?id=157948
636
637         Reviewed by Michael Catanzaro.
638
639         * DumpRenderTree/mac/Configurations/Base.xcconfig:
640         * MiniBrowser/Configurations/Base.xcconfig:
641         * TestWebKitAPI/Configurations/Base.xcconfig:
642         * WebKitTestRunner/Configurations/Base.xcconfig:
643
644 2016-05-21  Aakash Jain  <aakash_jain@apple.com>
645
646         Simulator launch fails intermittently due to failure in checking simulator boot status
647         https://bugs.webkit.org/show_bug.cgi?id=157965
648         rdar://problem/26402404
649
650         Reviewed by Alexey Proskuryakov.
651
652         * Scripts/webkitpy/xcode/simulator.py:
653         (Simulator.wait_until_device_is_booted): Ignore CalledProcessError exception while checking
654         whether simulator has finished booting.
655
656 2016-05-21  Dan Bernstein  <mitz@apple.com>
657
658         Silence warnings from svn propget when using newer versions of Subversion.
659         https://bugs.webkit.org/show_bug.cgi?id=157879
660
661         Reviewed by Daniel Bates.
662
663         * Scripts/prepare-ChangeLog:
664         (attributeCommand): Redirect svn propget stderr to /dev/null.
665         * Scripts/svn-create-patch:
666         (findMimeType): Ditto.
667
668 2016-05-20  Ryosuke Niwa  <rniwa@webkit.org>
669
670         run-benchmark's results should contain Animometer's debug output
671         https://bugs.webkit.org/show_bug.cgi?id=157941
672
673         Reviewed by Stephanie Lewis.
674
675         Modified the Animometer patch to store debug output and made benchmark_runner extract them together as a single array.
676         The result can be dragged and dropped into Animometer's developer.html page.
677
678         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
679         (BenchmarkRunner._run_one_test): Parse JSON here instead of doing it in multiple call sites.
680         (BenchmarkRunner._run_benchmark): Strip debugOutput from individual test result, and merge them together separately.
681         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch:
682         Modified the patch to store the debug output.
683         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
684         (ServerControl.render_POST): Fixed a bug that POST to /report results in 500 because getvalue is not defined
685         when the request body is larger than a certain size on twisted.
686
687 2016-05-20  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
688
689         Use clearer names for JSON output of javascriptcore test results
690         https://bugs.webkit.org/show_bug.cgi?id=157921
691
692         Reviewed by Alexey Proskuryakov.
693
694         "failures" and "apiTestResult" were somewhat ambiguous names. 
695         
696         * Scripts/run-javascriptcore-tests:
697         (runJSCStressTests): "failures" -> "stressFailures", "apiTestResult" -> "allApiTestsPassed".
698
699 2016-05-20  Chris Dumez  <cdumez@apple.com>
700
701         Unreviewed, fix API test introduced in r201213.
702
703         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
704         (TestWebKitAPI::TEST):
705
706 2016-05-20  Rawinder Singh  <rawinder.singh-webkit@cisra.canon.com.au>
707
708         Implement operator== for WeakPtr
709         https://bugs.webkit.org/show_bug.cgi?id=157883
710
711         Reviewed by Chris Dumez.
712
713         Implement operator== and operator!= for WeakPtr and update code to use the operators.
714
715         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
716         (TestWebKitAPI::TEST):
717
718 2016-05-19  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
719
720         Add JSON results to 32-bit and CLoop JSC tests
721         https://bugs.webkit.org/show_bug.cgi?id=157929
722
723         Reviewed by Alexey Proskuryakov.
724
725         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
726         (RunLLINTCLoopTests): Change command-line parameters to run-javascriptcore-tests in order to get JSON output.
727         (Run32bitJSCTests): Change command-line parameters to run-javascriptcore-tests in order to get JSON output.
728
729 2016-05-19  Csaba Osztrogonác  <ossy@webkit.org>
730
731         Typo fix in import-test262-tests
732         https://bugs.webkit.org/show_bug.cgi?id=157902
733
734         Reviewed by Keith Miller.
735
736         * Scripts/import-test262-tests:
737
738 2016-05-19  Csaba Osztrogonác  <ossy@webkit.org>
739
740         [EFL] Fix the gst-libav build on ARM Thumb2 after r199649
741         https://bugs.webkit.org/show_bug.cgi?id=157893
742
743         Reviewed by Antonio Gomes.
744
745         * efl/patches/gst-libav.patch:
746
747 2016-05-19  Jer Noble  <jer.noble@apple.com>
748
749         REGRESSION(r200951): VideoControlsManager API tests time out
750         https://bugs.webkit.org/show_bug.cgi?id=157896
751         <rdar://problem/26326293>
752
753         Reviewed by Eric Carlson.
754
755         Explicitly disable user gesture requirements for playback.
756
757         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
758         (TestWebKitAPI::TEST):
759
760 2016-05-19  Csaba Osztrogonác  <ossy@webkit.org>
761
762         Slow JSC stress tests times out in 32 bit debug mode
763         https://bugs.webkit.org/show_bug.cgi?id=154964
764
765         Reviewed by Michael Catanzaro.
766
767         * Scripts/run-javascriptcore-tests:
768         (runJSCStressTests): Pass through the --debug option.
769         * Scripts/run-jsc-stress-tests: Increase the timeout for debug builds.
770
771 2016-05-18  Aakash Jain  <aakash_jain@apple.com>
772
773         Remove underline from Status Bubbles on dashboard
774         https://bugs.webkit.org/show_bug.cgi?id=157870
775         rdar://problem/26332321
776
777         Reviewed by Alexey Proskuryakov.
778
779         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: Reverted style 
780         change made in http://trac.webkit.org/r200880
781
782 2016-05-18  Michael Saboff  <msaboff@apple.com>
783
784         r199812 broke test262
785         https://bugs.webkit.org/show_bug.cgi?id=157595
786
787         Reviewed by Filip Pizlo.
788
789         Added a new run type, runOneLargeHeap, for tests that use a large amount of memory.
790         This run type will not run with the --memory-limited option.  Without that option,
791         we'll only the default test variant.
792
793         * Scripts/run-jsc-stress-tests:
794
795 2016-05-18  Simon Fraser  <simon.fraser@apple.com>
796
797         REGRESSION (r200534) Command-+ no longer zooms pages 
798         https://bugs.webkit.org/show_bug.cgi?id=157826
799         rdar://problem/26334636
800
801         Reviewed by Dean Jackson.
802
803         * DumpRenderTree/mac/DumpRenderTree.mm:
804         (resetWebPreferencesToConsistentValues): Remove ENABLE() #ifdefs that do nothing (see http://webkit.org/b/157828).
805
806 2016-05-18  Joanmarie Diggs  <jdiggs@igalia.com>
807
808         [GTK] accessibility/meter-element.html is failing
809         https://bugs.webkit.org/show_bug.cgi?id=115633
810
811         Reviewed by Chris Fleizach.
812
813         Implement AccessibilityUIElement::valueDescription() and add mapping
814         from ATK_ROLE_LEVEL_BAR to AXProgressIndicator.
815
816         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
817         (WTR::AccessibilityUIElement::valueDescription):
818
819 2016-05-18  Brady Eidson  <beidson@apple.com>
820
821         Modern IDB: Make TestRunner.clearAllDatabases also delete IndexedDB databases (once doing so is supported).
822         https://bugs.webkit.org/show_bug.cgi?id=157823
823
824         Reviewed by Alex Christensen.
825
826         * DumpRenderTree/mac/TestRunnerMac.mm:
827         (TestRunner::clearAllDatabases):
828         
829         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
830         (WTR::TestRunner::clearAllDatabases):
831         
832         * WebKitTestRunner/TestInvocation.cpp:
833         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
834
835 2016-05-18  Joanmarie Diggs  <jdiggs@igalia.com>
836
837         AX: [ATK] Use WebCore Accessibility's AccessibilityText for AtkObject name and description
838         https://bugs.webkit.org/show_bug.cgi?id=157822
839
840         Reviewed by Chris Fleizach.
841
842         Fix AccessibilityUIElement::helpText() so that it returns an empty string rather than
843         nullptr upon failure.
844
845         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
846         (WTR::AccessibilityUIElement::helpText):
847
848 2016-05-17  Beth Dakin  <bdakin@apple.com>
849
850         Make handleAcceptedCandidate a public function
851         https://bugs.webkit.org/show_bug.cgi?id=157763
852         -and corresponding-
853         rdar://problem/26206397
854
855         Reviewed by Tim Horton.
856
857         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
858         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocused-text-input.html: Added.
859         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm: Added.
860         (-[DoNotLeakWebView dealloc]):
861         (-[DoNotLeakWebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
862         (-[DoNotLeakFrameLoadDelegate webView:didFinishLoadForFrame:]):
863         (TestWebKitAPI::TEST):
864
865 2016-05-17  Keith Miller  <keith_miller@apple.com>
866
867         Add test262 harness support code
868         https://bugs.webkit.org/show_bug.cgi?id=157797
869
870         Reviewed by Filip Pizlo.
871
872         The import-test262-tests script is used to generate the yaml file used to run test262. It
873         takes a path to the local copy of the Test262 repository as well as an optional path to file
874         containing a list of failures. This script currently just creates the yaml file used to run
875         the script. It does not relocate the test files into our tests directory. In the future I
876         plan to add that feature but it didn't seem essential for the first iteration. Since many
877         test262 tests need to be run in both strict and non-strict mode, import-test262-tests
878         creates two separate runs for those tests. This enables us to distinguish between failures
879         in only one of the two modes.
880
881         This patch also updates the run-jsc-stress-tests Script to run tests from Test262. In order
882         to do so two new run commands were needed runTest262 and prepareTest262Fixture. runTest262
883         takes an actual test file along with the metadata associated with it. prepareTest262Fixture
884         takes a fixture file (used by module tests for importing) and makes sure that file is
885         properly relocated to the test runner directory.
886
887         The proccess I used to import the tests was to first run import-test262-tests to create a
888         yaml for all the tests (import-test262-tests assumes all tests pass if to failures file is
889         passed). Then I ran the generated yaml file with "run-jsc-stress-tests -v -c 1" piping the
890         output to a file and collected all the lines with "FAIL" in it. Finally, I reran
891         import-test262-tests with the new failure file to create the final yaml.
892
893         * Scripts/import-test262-tests: Added.
894         * Scripts/run-jsc-stress-tests:
895
896 2016-05-16  Enrica Casucci  <enrica@apple.com>
897
898         build fix after r200968 and r200969
899
900         Unreviewed.
901
902         * DumpRenderTree/mac/EventSendingController.mm:
903         (-[EventSendingController keyDown:withModifiers:withLocation:]):
904
905 2016-05-16  Jer Noble  <jer.noble@apple.com>
906
907         API test WebKit2.MSEIsPlayingAudio timing out after r200951
908         https://bugs.webkit.org/show_bug.cgi?id=157748
909
910         Reviewed by Eric Carlson.
911
912         The file-with-mse.html testcase only calls play() once it's own XHR loading is complete; the
913         "user gesture" check fails at that point.  Call play() up front; playback will begin as soon
914         as enough data is loaded.
915
916         * TestWebKitAPI/Tests/WebKit2/file-with-mse.html:
917
918 2016-05-16  Enrica Casucci  <enrica@apple.com>
919
920         Remove unused initializer for WebEvent on iOS.
921         https://bugs.webkit.org/show_bug.cgi?id=157689
922
923         Reviewed by Anders Carlsson.
924
925         Adopting different initializer for WebEvent to fix the build.
926
927         * DumpRenderTree/mac/EventSendingController.mm:
928         (-[EventSendingController keyDown:withModifiers:withLocation:]):
929
930 2016-05-16  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
931
932         Add machine-readable results for JSC API tests to the Buildbot json log
933         https://bugs.webkit.org/show_bug.cgi?id=157642
934
935         Reviewed by Geoffrey Garen.
936
937         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
938         (RunJavaScriptCoreTests): Use --no-fail-fast option on run-javascriptcore-tests
939         * Scripts/run-javascriptcore-tests:
940         (runJSCStressTests): Abstracted out writing JSON to file (new function below)
941         (writeJsonDataIfApplicable): Added
942
943 2016-04-06  Jer Noble  <jer.noble@apple.com>
944
945         [WK2] Add API to WKWebViewConfiguration to control autoplay policy.
946         https://bugs.webkit.org/show_bug.cgi?id=156312
947
948         Reviewed by Dan Bernstein.
949
950         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
951         (WTR::initializeWebViewConfiguration):
952         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
953         (TEST_F):
954
955 2016-05-16  Brent Fulgham  <bfulgham@apple.com>
956
957         REGRESSION (r192098): Content missing after copy and paste to Notes App on retina displays
958         https://bugs.webkit.org/show_bug.cgi?id=157630
959         <rdar://problem/25277577>
960
961         Reviewed by Simon Fraser.
962
963         Update test infrastructure to support checking the number of images in the pasteboard.
964
965         * DumpRenderTree/TestRunner.cpp:
966         (imageCountInGeneralPasteboardCallback): Added.
967         (TestRunner::staticFunctions):
968         * DumpRenderTree/TestRunner.h:
969         * DumpRenderTree/mac/TestRunnerMac.mm:
970         (TestRunner::imageCountInGeneralPasteboard): Added.
971         * DumpRenderTree/win/TestRunnerWin.cpp:
972         (TestRunner::imageCountInGeneralPasteboard): Added stub method.
973         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
974         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
975         (WTR::InjectedBundle::imageCountInGeneralPasteboard): Added.
976         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
977         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
978         (WTR::TestRunner::imageCountInGeneralPasteboard): Added.
979         * WebKitTestRunner/InjectedBundle/TestRunner.h:
980         * WebKitTestRunner/TestController.cpp:
981         (WTR::TestController::imageCountInGeneralPasteboard): Added stub implementation.
982         * WebKitTestRunner/TestController.h:
983         * WebKitTestRunner/TestInvocation.cpp:
984         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): Handle copy message.
985         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
986         (WTR::TestController::imageCountInGeneralPasteboard): Added.
987
988 2016-05-13  Dewei Zhu  <dewei_zhu@apple.com>
989
990         Fix JSBench which causes math domain error in run-benchmark script.
991         https://bugs.webkit.org/show_bug.cgi?id=157697
992         <rdar://problem/26279292>
993
994         Reviewed by Ryosuke Niwa.
995
996         Some tests of JSBench give time usage to be 0 ms which will causes error while calculating geometric mean.
997         Also fix a round-off error while calculating stdev.
998
999         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
1000         (BenchmarkResults._format_values):
1001         * Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch:
1002
1003 2016-05-13  Brady Eidson  <beidson@apple.com>
1004
1005         Extend protector naming code style guideline to cover operator= assignment.
1006         https://bugs.webkit.org/show_bug.cgi?id=157693
1007
1008         Reviewed by Darin Adler.
1009
1010         * Scripts/webkitpy/style/checkers/cpp.py:
1011         (check_identifier_name_in_declaration):
1012         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1013         (WebKitStyleTest.test_names):
1014
1015 2016-05-13  Aakash Jain  <aakash_jain@apple.com>
1016
1017         Dashboard code restructuring
1018         https://bugs.webkit.org/show_bug.cgi?id=157680
1019         <rdar://problem/14736888>
1020
1021         Reviewed by Alexey Proskuryakov.
1022
1023         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js:
1024         (BubbleQueueView.prototype.addLinkToRow): Moved to base class.
1025         (BubbleQueueView.prototype.addTextToRow): Moved to base class.
1026         (BubbleQueueView.prototype._addDividerToPopover): Moved to base class.
1027         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1028         (BuildbotBuilderQueueView.prototype.update): Passing additional argument to _appendPendingRevisionCount.
1029         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
1030         (BuildbotCombinedQueueView.prototype.update): Passing additional argument to _appendPendingRevisionCount.
1031         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1032         (BuildbotTesterQueueView.prototype.update): Passing additional argument to _appendPendingRevisionCount.
1033         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1034         (BuildbotQueueView.prototype._appendPendingRevisionCount): Moved to base class and modified to take
1035         additional argument.
1036         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Moved to base class.
1037         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Moved to base class.
1038         (BuildbotQueueView.prototype._addDividerToPopover): Moved to base class.
1039         (BuildbotQueueView.prototype._formatRevisionForDisplay): Moved to base class.
1040         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1041         (documentReady): Display any customView if available.
1042         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
1043         (QueueView.prototype.addLinkToRow): Moved from child class, no changes.
1044         (QueueView.prototype.addTextToRow): Moved from child class, no changes.
1045         (QueueView.prototype._addDividerToPopover): Moved from child class, no changes.
1046         (QueueView.prototype._appendPendingRevisionCount): Moved from child class, made it more generic
1047         by taking latestIterationGetter method as an argument.
1048         (QueueView.prototype._popoverLinesForCommitRange): Moved from child class, no changes.
1049         (QueueView.prototype._presentPopoverForPendingCommits): Moved from child class, no changes.
1050         (QueueView.prototype._formatRevisionForDisplay): Moved from child class, no changes.
1051         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1052         (a:hover:link): Underline only when there is a link.
1053
1054 2016-05-13  Yoav Weiss  <yoav@yoav.ws>
1055
1056         Turn on WEB_TIMING for all ports
1057         https://bugs.webkit.org/show_bug.cgi?id=157673
1058
1059         Reviewed by Alex Christensen.
1060
1061         * Scripts/webkitperl/FeatureList.pm: Make sure that WEB_TIMING is on by default.
1062
1063 2016-05-13  Brady Eidson  <beidson@apple.com>
1064
1065         Protector Ref/RefPtrs should have a specified naming style.
1066         https://bugs.webkit.org/show_bug.cgi?id=157591
1067
1068         Reviewed by Darin Adler.
1069
1070         * Scripts/webkitpy/style/checkers/cpp.py:
1071         (check_identifier_name_in_declaration):
1072         (CppChecker):
1073         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1074         (WebKitStyleTest.test_names):
1075
1076 2016-05-12  Csaba Osztrogonác  <ossy@webkit.org>
1077
1078         Remove ENABLE(ES6_ARROWFUNCTION_SYNTAX) guards
1079         https://bugs.webkit.org/show_bug.cgi?id=157564
1080
1081         Reviewed by Darin Adler.
1082
1083         * Scripts/webkitperl/FeatureList.pm:
1084         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1085
1086 2016-05-11  Joanmarie Diggs  <jdiggs@igalia.com>
1087
1088         [GTK] accessibility/aria-readonly.html is failing
1089         https://bugs.webkit.org/show_bug.cgi?id=98357
1090
1091         Reviewed by Chris Fleizach.
1092
1093         Add checks to isAttributeSettable() for ATK_STATE_READ_ONLY and the 'readonly'
1094         AtkObject attribute along with ATK_STATE_CHECKABLE for toggle-able elements,
1095         ATK_STATE_SELECTABLE for select elements, and ATK_STATE_FOCUSABLE combined
1096         with range verification for inputs which implement AtkValue. The latter two
1097         additions are admittedly a heuristic workaround for platform accessibility
1098         API differences. But they should be sufficient to facilitate cross-platform
1099         testing of isAttributeSettable() for form elements which lack ARIA attributes.
1100
1101         Bump the minimum version of at-spi2-core and at-spi2-atk
1102         to 2.15.4 (earliest version that supports STATE_READ_ONLY).
1103
1104         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1105         (WTR::AccessibilityUIElement::isAttributeSettable):
1106         * gtk/jhbuild.modules:
1107
1108 2016-05-10  Ryan Haddad  <ryanhaddad@apple.com>
1109
1110         Another attempt to fix the build after r200668.
1111
1112         Unreviewed build fix.
1113
1114         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
1115         (TEST):
1116
1117 2016-05-10  Dan Bernstein  <mitz@apple.com>
1118
1119         Tried to fix the Mac build after r200668.
1120
1121         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1122         (WTR::TestController::platformCreateWebView):
1123
1124 2016-05-10  Sam Weinig  <sam@webkit.org>
1125
1126         Tweak underline style for data detected links
1127         https://bugs.webkit.org/show_bug.cgi?id=157546
1128
1129         Reviewed by Tim Horton.
1130
1131         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1132         * TestWebKitAPI/Tests/WebCore/Color.cpp: Added.
1133         (TestWebKitAPI::TEST):
1134         Add tests for the new Color::getHSV() function.
1135
1136 2016-05-10  Filip Pizlo  <fpizlo@apple.com>
1137
1138         Internal JSC profiler should have a timestamped log of events for each code block
1139         https://bugs.webkit.org/show_bug.cgi?id=157538
1140
1141         Reviewed by Benjamin Poulain.
1142
1143         * Scripts/display-profiler-output:
1144
1145 2016-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1146
1147         [Linux] Remove seccomp filters support
1148         https://bugs.webkit.org/show_bug.cgi?id=157380
1149
1150         Reviewed by Darin Adler.
1151
1152         * Scripts/webkitperl/FeatureList.pm:
1153         * TestWebKitAPI/PlatformEfl.cmake:
1154         * TestWebKitAPI/PlatformGTK.cmake:
1155         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Removed.
1156         * efl/jhbuild.modules:
1157         * gtk/jhbuild.modules:
1158
1159 2016-05-09  Simon Fraser  <simon.fraser@apple.com>
1160
1161         [iOS] visibility:hidden -webkit-overflow-scrolling: touch divs can interfere with page scrolling
1162         https://bugs.webkit.org/show_bug.cgi?id=157496
1163         rdar://problem/22963278
1164
1165         Reviewed by Tim Horton.
1166
1167         Enhance UIScriptController to generate a drag, which is useful for scrolling.
1168
1169         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
1170         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1171         (WTR::UIScriptController::dragFromPointToPoint):
1172         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1173         * WebKitTestRunner/ios/HIDEventGenerator.h:
1174         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1175         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
1176         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1177         (WTR::UIScriptController::dragFromPointToPoint):
1178
1179 2016-05-09  Simon Fraser  <simon.fraser@apple.com>
1180
1181         Remove testRunner.setTextAutosizingEnabled and migrate the one test that uses it
1182         https://bugs.webkit.org/show_bug.cgi?id=157480
1183
1184         Reviewed by Zalan Bujtas.
1185
1186         Migrate the one test that used testRunner.setTextAutosizingEnabled() to window.internals.settings.setTextAutosizingEnabled()
1187         and move it next to the other iOS text autosizing tests.
1188         
1189         Remove testRunner.setTextAutosizingEnabled(), which was only implemented in DumpRenderTree.
1190
1191         * DumpRenderTree/TestRunner.cpp:
1192         (setTextAutosizingEnabledCallback): Deleted.
1193         (TestRunner::staticFunctions): Deleted.
1194         * DumpRenderTree/mac/TestRunnerMac.mm:
1195         (TestRunner::setTextAutosizingEnabled): Deleted.
1196
1197 2016-05-07  Darin Adler  <darin@apple.com>
1198
1199         Next step on dictionary bindings, along with other bindings refinements
1200         https://bugs.webkit.org/show_bug.cgi?id=157451
1201
1202         Reviewed by Chris Dumez.
1203
1204         * Scripts/do-webcore-rename: Use this to rename JSDOMBuild.h to JSDOMConvert.h.
1205         Also skip test expectations in a directory that this was modifying unnecessarily.
1206
1207 2016-05-06  Simon Fraser  <simon.fraser@apple.com>
1208
1209         Enable IOS_TEXT_AUTOSIZING on Mac and make it testable
1210         https://bugs.webkit.org/show_bug.cgi?id=157432
1211         rdar://problem/16406720
1212
1213         Reviewed by Dean Jackson.
1214
1215         Enable IOS_TEXT_AUTOSIZING on Mac so it can be tested.
1216
1217         Make the setTextAutosizingEnabled() Setting work, and plumb it through WK1 and WK2
1218         preferences for WTR and DRT. Make textAutosizingWindowSizeOverride() work, for layout tests.
1219         These two settings are shared with TEXT_AUTOSIZING.
1220
1221         Add a TextAutosizing log channel, which is useful for generated -expected.html results.
1222
1223         Move adjustComputedFontSizesOnBlocks() and related code from RenderObject to RenderElement
1224         without changes.
1225
1226         An implication of this set of changes is that the way clients enable text autosizing
1227         has changed. Previously, they set the "MinimumZoomFontSize" preference to 0.
1228         Settings::defaultMinimumZoomFontSize() used to do this in order to enable text autosizing
1229         on iPhone only, not iPad.
1230
1231         Now the preferred technique is to leave minimumZoomFontSize alone, and to use textAutosizingEnabled()
1232         instead. Settings::defaultTextAutosizingEnabled() now does the check for iPhone.
1233
1234         UIWebView calls WebKitGetMinimumZoomFontSize() to setup the default minimum font zoom size,
1235         which will now always return 15, but had no other code that toggled this. So it's safe to just rely
1236         on Settings::defaultTextAutosizingEnabled() doing the right thing for iPhone/iPad.
1237
1238         * DumpRenderTree/mac/DumpRenderTree.mm:
1239         (resetWebPreferencesToConsistentValues):
1240         * DumpRenderTree/mac/TestRunnerMac.mm:
1241         (TestRunner::setTextAutosizingEnabled):
1242         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1243         * WebKitTestRunner/ios/TestControllerIOS.mm:
1244         (WTR::TestController::platformResetPreferencesToConsistentValues):
1245
1246 2016-05-06  Dean Jackson  <dino@apple.com>
1247
1248         Regions, Shapes and Tracks don't need runtime features
1249         https://bugs.webkit.org/show_bug.cgi?id=157426
1250         <rdar://problem/26146262>
1251
1252         Reviewed by Simon Fraser.
1253
1254         The following RuntimeEnabledFeatures can be removed since
1255         we have no need to disable them (they are stable and have
1256         shipped for a while):
1257         - CSS Regions
1258         - CSS Shapes
1259         - Media tracks
1260
1261         * DumpRenderTree/mac/DumpRenderTree.mm:
1262         (resetWebPreferencesToConsistentValues): Deleted.
1263
1264 2016-05-06  Ryan Haddad  <ryanhaddad@apple.com>
1265
1266         Increase delay when launching multiple ios-simulators in parallel
1267         https://bugs.webkit.org/show_bug.cgi?id=157422
1268
1269         Reviewed by Alexey Proskuryakov.
1270
1271         Tests are intermittently failing when launching multiple simulators in parallel due to "You are opening
1272         this application for the first time" confirmation dialogs. Increasing the delay to alleviate this issue.
1273
1274         * Scripts/webkitpy/port/ios.py:
1275         (IOSSimulatorPort.setup_test_run):
1276
1277 2016-05-06  Per Arne Vollan  <peavo@outlook.com>
1278
1279         [Win] Remove WinXP support.
1280         https://bugs.webkit.org/show_bug.cgi?id=157416
1281
1282         Reviewed by Brent Fulgham.
1283
1284         * win/DLLLauncher/DLLLauncherMain.cpp:
1285         (enableTerminationOnHeapCorruption):
1286
1287 2016-05-06  Manuel Rego Casasnovas  <rego@igalia.com>
1288
1289         [css-grid] Unprefix CSS Grid Layout properties
1290         https://bugs.webkit.org/show_bug.cgi?id=157137
1291
1292         Reviewed by Simon Fraser.
1293
1294         Remove "-webkit" prefix from all the grid layout properties,
1295         including the display value.
1296         Update the source code to remove the prefix where it was used too.
1297
1298         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
1299         (TestWebKitAPI::TEST):
1300
1301 2016-05-05  Alexey Proskuryakov  <ap@apple.com>
1302
1303         Partially revert http://trac.webkit.org/r200504
1304         Improve HTTP test names in WebKitTestRunner's crash report information
1305         https://bugs.webkit.org/show_bug.cgi?id=157389
1306
1307         * WebKitTestRunner/cocoa/CrashReporterInfo.mm: Turns out that we can't have URLs
1308         in crash reporter information.
1309
1310 2016-05-05  Alexey Proskuryakov  <ap@apple.com>
1311
1312         Improve HTTP test names in WebKitTestRunner's crash report information
1313         https://bugs.webkit.org/show_bug.cgi?id=157389
1314
1315         Reviewed by Alex Christensen.
1316
1317         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1318         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Added a FIXME.
1319
1320         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
1321         (WTR::testDescription): Don't bail out if the port is neither 8000 nor 8443; we
1322         use other port numbers too. For http tests, return the complete URL string, not
1323         just the path.
1324
1325 2016-05-04  Alex Christensen  <achristensen@webkit.org>
1326
1327         Blocked redirected main resource requests need descriptive errors
1328         https://bugs.webkit.org/show_bug.cgi?id=156828
1329         rdar://problem/25711316
1330
1331         Reviewed by Daniel Bates.
1332
1333         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1334         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
1335         Print out the error type to make sure we have the most descriptive error type.
1336
1337 2016-05-05  Enrique Ocaña González  <eocanha@igalia.com>
1338
1339         [GStreamer] Bump internal jhbuild versions to 1.8.0 and patches to support MSE
1340         https://bugs.webkit.org/show_bug.cgi?id=157341
1341
1342         Reviewed by Xabier Rodriguez-Calvar.
1343
1344         * gtk/jhbuild.modules:
1345         * gtk/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
1346         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.
1347
1348 2016-05-04  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
1349
1350         Add JSC test results in JSON format to a Buildbot log
1351         https://bugs.webkit.org/show_bug.cgi?id=156920
1352
1353         Reviewed by Daniel Bates.
1354
1355         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1356         (RunJavaScriptCoreTests): Move command-line option for output file out
1357         of WithProperties.
1358
1359 2016-05-04  Dean Jackson  <dino@apple.com>
1360
1361         TestRunner should always enable all the experimental features
1362         https://bugs.webkit.org/show_bug.cgi?id=157360
1363         <rdar://problem/26099748>
1364
1365         Reviewed by Anders Carlsson.
1366
1367         Call the new SPI that enables all the experimental features.
1368
1369         * WebKitTestRunner/TestController.cpp:
1370         (WTR::TestController::resetPreferencesToConsistentValues):
1371
1372 2016-05-04  Mark Lam  <mark.lam@apple.com>
1373
1374         ES6 Function.name inferred from property names of literal objects can break some websites.
1375         https://bugs.webkit.org/show_bug.cgi?id=157246
1376
1377         Reviewed by Geoffrey Garen.
1378
1379         * WebKitTestRunner/TestController.cpp:
1380         (WTR::TestController::resetPreferencesToConsistentValues):
1381         (WTR::updateTestOptionsFromTestHeader):
1382         * WebKitTestRunner/TestOptions.h:
1383
1384         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1385         (WTR::PlatformWebView::viewSupportsOptions):
1386         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1387         (WTR::PlatformWebView::viewSupportsOptions):
1388         - Add needsSiteSpecificQuirks to WKTR options that can be set. 
1389
1390 2016-05-04  Joanmarie Diggs  <jdiggs@igalia.com>
1391
1392         AX: ARIA 'region' role is now a landmark; HTML 'section' element should be a landmark only if named
1393         https://bugs.webkit.org/show_bug.cgi?id=157331
1394
1395         Reviewed by Chris Fleizach.
1396
1397         Add AXLandmarkRegion to the landmark strings handled by roleToString
1398         for objects with ATK_ROLE_LANDMARK.
1399
1400         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1401
1402 2016-05-03  Beth Dakin  <bdakin@apple.com>
1403
1404         Add VideoControlsManager tests
1405         https://bugs.webkit.org/show_bug.cgi?id=157332
1406         -and corresponding-
1407         rdar://problem/24358431
1408
1409         Reviewed by Sam Weinig.
1410
1411         This patch adds three VideoControlsManager tests.
1412
1413         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1414         * TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html:
1415         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Added.
1416         (-[DidPlayMessageHandler initWithWKWebView:]):
1417         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]):
1418         (TestWebKitAPI::TEST):
1419         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html: Added.
1420         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.mp4: Added.
1421         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-without-audio.html: Added.
1422
1423 2016-05-03  Joanmarie Diggs  <jdiggs@igalia.com>
1424
1425         [ATK] accessibility/document-attributes.html is failing
1426         https://bugs.webkit.org/show_bug.cgi?id=125348
1427
1428         Reviewed by Chris Fleizach.
1429
1430         The test was failing because the WebArea is now being exposed with the role of
1431         ATK_ROLE_DOCUMENT_WEB; not ATK_ROLE_DOCUMENT_FRAME. Unfortunately, when that
1432         change was made, documentEncoding() and documentURI() were not updated accordingly.
1433
1434         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1435         (WTR::AccessibilityUIElement::documentEncoding):
1436         (WTR::AccessibilityUIElement::documentURI):
1437
1438 2016-05-03  Brent Fulgham  <bfulgham@apple.com>
1439
1440         [Win] Unreviewed build fix.
1441
1442         * EWSTools/start-queue-win.sh: Establish proper VS2015 build
1443         environment at start of queue run.
1444
1445 2016-05-03  Joanmarie Diggs  <jdiggs@igalia.com>
1446
1447         [ATK] accessibility/content-editable-as-textarea.html fails
1448         https://bugs.webkit.org/show_bug.cgi?id=155353
1449
1450         Reviewed by Darin Adler.
1451
1452         The test was timing out because it expected an AXValueChanged notification.
1453         In ATK, AXValueChanged notifications are made for widgets which implement
1454         the AtkValue interface (sliders, progress bars, etc.). We should be listening
1455         for AXTextChanged instead. AtkText's text-insert and text-remove have been
1456         added to the AccessibilityNotificationHandler.
1457
1458         Also, ATK's AccessibilityUIElement support had a number of unimplemented
1459         methods that are being used as part of the previously-failing test. Those
1460         methods are now implemented so that the ATK results are much more similar
1461         to those on the Mac.
1462
1463         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1464         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
1465         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1466         (WTR::AccessibilityUIElement::stringAttributeValue):
1467         (WTR::AccessibilityUIElement::rangeForLine):
1468         (WTR::AccessibilityUIElement::boundsForRange):
1469         (WTR::AccessibilityUIElement::attributedStringForRange):
1470
1471 2016-05-02  Brady Eidson  <beidson@apple.com>
1472
1473         Add the ability to accumulate logs for specific logging channels to help diagnose test timeouts.
1474         https://bugs.webkit.org/show_bug.cgi?id=157274
1475
1476         Reviewed by Alex Christensen.
1477
1478         Add the new accumulate method to DRT's TestRunner, dump the accumulated logs if there's a timeout,
1479         and reset them in between tests:
1480         * DumpRenderTree/TestRunner.cpp:
1481         (accummulateLogsForChannel):
1482         (TestRunner::staticFunctions):
1483         (TestRunner::waitToDumpWatchdogTimerFired):
1484         (TestRunner::setAccummulateLogsForChannel):
1485         * DumpRenderTree/TestRunner.h:
1486         * DumpRenderTree/mac/DumpRenderTree.mm:
1487         (resetWebViewToConsistentStateBeforeTesting):
1488
1489         Also add the new method to WKTR's TestRunner, but just stubbed for now:
1490         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1491         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1492         (WTR::TestRunner::accummulateLogsForChannel):
1493         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1494
1495 2016-05-02  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
1496
1497         Add fail-fast option to run-javascriptcore-tests
1498         https://bugs.webkit.org/show_bug.cgi?id=157270
1499
1500         Reviewed by Geoffrey Garen.
1501
1502         * Scripts/run-javascriptcore-tests: Add fail-fast command line option.
1503         Defaults to yes, which is the current behavior.
1504
1505 2016-05-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1506
1507         [CMake] MiniBrowser fails to build because libsoup link flags are not defined.
1508         https://bugs.webkit.org/show_bug.cgi?id=157268
1509
1510         Reviewed by Michael Catanzaro.
1511
1512         * MiniBrowser/gtk/CMakeLists.txt:
1513
1514 2016-04-30  Darin Adler  <darin@apple.com>
1515
1516         Streamline and remove unused bindings generation code
1517         https://bugs.webkit.org/show_bug.cgi?id=157237
1518
1519         Reviewed by Chris Dumez.
1520
1521         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
1522         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1523         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1524         Replace non-standard "int" with standard "long", which means the same thing.
1525
1526 2016-04-30  Darin Adler  <darin@apple.com>
1527
1528         Next batch of conversions to use C++ enum class instead of strings for enumerations
1529         https://bugs.webkit.org/show_bug.cgi?id=157232
1530
1531         Reviewed by Chris Dumez.
1532
1533         * Scripts/webkitpy/style/checker.py: Skip the bindings script tests when doing style
1534         checking. We don't want to waste time trying to make our generated code match our style.
1535
1536 2016-04-29  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
1537
1538         Add JSC test results in JSON format to a Buildbot log.
1539         https://bugs.webkit.org/show_bug.cgi?id=156920
1540
1541         Reviewed by Daniel Bates.
1542
1543         Generate JSON results for JSC tests and upload them to the master
1544         using Buildbot's logfiles machinery.
1545
1546         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1547         (RunJavaScriptCoreTests): Use --json-output option when invoking the
1548         run-javascriptcore-tests Perl script, and expose this JSON output as a 
1549         Buildbot log.
1550         * Scripts/run-javascriptcore-tests:
1551         (runJSCStressTests): Change key names and remove redundant count key.
1552
1553 2016-04-29  Joanmarie Diggs  <jdiggs@igalia.com>
1554
1555         [ATK] Expose the value of aria-roledescription via an AtkObject attribute
1556         https://bugs.webkit.org/show_bug.cgi?id=146719
1557
1558         Reviewed by Chris Fleizach.
1559
1560         Implement roleDescription() so that the implementation can be tested.
1561
1562         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1563         (WTR::AccessibilityUIElement::roleDescription):
1564
1565 2016-04-27  Alexey Proskuryakov  <ap@apple.com>
1566
1567         Don't throttle GuardMalloc on 8-core Macs
1568         https://bugs.webkit.org/show_bug.cgi?id=157108
1569
1570         Reviewed by Alex Christensen.
1571
1572         This was making them slower unnecessarily.
1573
1574         * Scripts/webkitpy/port/mac.py: (MacPort.default_child_processes):
1575
1576 2016-04-26  Konstantin Tokarev  <annulen@yandex.ru>
1577
1578         Unreviewed: add myself to the committers list.
1579
1580         * Scripts/webkitpy/common/config/contributors.json:
1581
1582 2016-04-26  Ryosuke Niwa  <rniwa@webkit.org>
1583
1584         Fix text in log files autogenerated by import-w3c-tests
1585         https://bugs.webkit.org/show_bug.cgi?id=157021
1586
1587         Unreviewed. Fixing the second typo.
1588
1589         * Scripts/webkitpy/w3c/test_importer.py:
1590         (TestImporter.write_import_log):
1591
1592 2016-04-26  Filip Pizlo  <fpizlo@apple.com>
1593
1594         WebCore on Mac ignores the user's preferred region (country) while getting the language
1595         https://bugs.webkit.org/show_bug.cgi?id=156993
1596
1597         Reviewed by Geoffrey Garen.
1598
1599         Change the test expectations for this test. If the variant is not explicitly specified in
1600         the AppleLanguage, then we use the locale's country code, which this test assumes is US.
1601
1602         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm:
1603         (TestWebKitAPI::languageForSystemLanguage):
1604         (TestWebKitAPI::TEST):
1605
1606 2016-04-25  Ryosuke Niwa  <rniwa@webkit.org>
1607
1608         Remove the build flag for template elements
1609         https://bugs.webkit.org/show_bug.cgi?id=157022
1610
1611         Reviewed by Daniel Bates.
1612
1613         Removed the build option.
1614
1615         * Scripts/webkitperl/FeatureList.pm:
1616
1617 2016-04-25  Ryosuke Niwa  <rniwa@webkit.org>
1618
1619         Fix text in log files autogenerated by import-w3c-tests
1620         https://bugs.webkit.org/show_bug.cgi?id=157021
1621
1622         Reviewed by Chris Dumez.
1623
1624         s/Webkit/WebKit/ and end each sentence with a period.
1625
1626         * Scripts/webkitpy/w3c/test_importer.py:
1627         (TestImporter.write_import_log):
1628
1629 2016-04-25  Myles C. Maxfield  <mmaxfield@apple.com>
1630
1631         [Cocoa] Guarantee FontPlatformData's m_cgFont is never nullptr
1632         https://bugs.webkit.org/show_bug.cgi?id=156929
1633
1634         Reviewed by Darin Adler.
1635
1636         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
1637         (TestWebKitAPI::TEST):
1638
1639 2016-04-25  Caitlin Potter  <caitp@igalia.com>
1640
1641         [Tools] whitelist all-uppercase JSTokenType enum in JavaScriptCore
1642         https://bugs.webkit.org/show_bug.cgi?id=156976
1643
1644         Reviewed by Darin Adler.
1645
1646         Mitigate style-checker spam on bugs which introduce new JavaScript
1647         token types.
1648
1649         * Scripts/webkitpy/style/checkers/cpp.py:
1650         (_EnumState.__init__):
1651         (_EnumState.process_clean_line):
1652         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1653         (NoNonVirtualDestructorsTest.test_enum_casing):
1654
1655 2016-04-25  Simon Fraser  <simon.fraser@apple.com>
1656
1657         Fix issues with content-animation performance tests
1658         https://bugs.webkit.org/show_bug.cgi?id=157001
1659
1660         Reviewed by Sam Weinig.
1661
1662         Add patch content for svg-animation.html, and fix the paths in the patch so
1663         it applies correctly.
1664
1665         Add the patch file to the .plan file.
1666
1667         * Scripts/webkitpy/benchmark_runner/data/patches/ContentAnimation.patch:
1668         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
1669
1670 2016-04-25  Brady Eidson  <beidson@apple.com>
1671
1672         Tweaking IndexedDB watchlist and adding myself to it.
1673
1674         * Scripts/webkitpy/common/config/watchlist:
1675
1676 2016-04-25  Commit Queue  <commit-queue@webkit.org>
1677
1678         Unreviewed, rolling out r199916.
1679         https://bugs.webkit.org/show_bug.cgi?id=156989
1680
1681         Might break buildbot when master is restarted (Requested by
1682         Srinivasan Vijayaraghava, Guest100, on #webkit).
1683
1684         Reverted changeset:
1685
1686         "Add JSC test results in json format to a buildbot log"
1687         https://bugs.webkit.org/show_bug.cgi?id=156920
1688         http://trac.webkit.org/changeset/199916
1689
1690 2016-04-23  Chris Dumez  <cdumez@apple.com>
1691
1692         [WebIDL] Drop [Default] WebKit-IDL extended attribute
1693         https://bugs.webkit.org/show_bug.cgi?id=156955
1694
1695         Reviewed by Darin Adler.
1696
1697         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1698
1699 2016-04-23  Csaba Osztrogonác  <ossy@webkit.org>
1700
1701         Really enable INDEXED_DATABASE on Apple Mac cmake build
1702         https://bugs.webkit.org/show_bug.cgi?id=156902
1703
1704         Reviewed by Michael Catanzaro.
1705
1706         * Scripts/webkitperl/FeatureList.pm:
1707
1708 2016-04-23  Andy Estes  <aestes@apple.com>
1709
1710         check-webkit-style: fix false-positive warnings about @synchronized
1711         https://bugs.webkit.org/show_bug.cgi?id=156957
1712
1713         Reviewed by Dan Bernstein.
1714
1715         * Scripts/webkitpy/style/checkers/cpp.py:
1716         (check_spacing_for_function_call): Ignore @synchronized lines.
1717         (check_braces): Ditto.
1718         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1719         (CppStyleTest.test_brace_at_begin_of_line): Added a test case.
1720
1721 2016-04-22  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
1722
1723         Add JSC test results in json format to a buildbot log
1724         https://bugs.webkit.org/show_bug.cgi?id=156920
1725
1726         Reviewed by Alexey Proskuryakov.
1727
1728         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1729         (RunJavaScriptCoreTests):
1730         Add runtime flag to output json into buildbot
1731         * Scripts/run-javascriptcore-tests:
1732         (runJSCStressTests):
1733         Change key names and remove redundant count key
1734
1735 2016-04-22  Ryan Haddad  <ryanhaddad@apple.com>
1736
1737         Update expected result for WKPreferencesGetOfflineWebApplicationCacheEnabled after r199854
1738
1739         Unreviewed test gardening.
1740
1741         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1742         (TestWebKitAPI::TEST):
1743
1744 2016-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1745
1746         [GTK] Enable the download attribute support
1747         https://bugs.webkit.org/show_bug.cgi?id=99025
1748
1749         Reviewed by Žan Doberšek.
1750
1751         * Scripts/webkitperl/FeatureList.pm:
1752
1753 2016-04-21  Keith Miller  <keith_miller@apple.com>
1754
1755         WebScriptObject description swizzler should work in a multi-threaded world
1756         https://bugs.webkit.org/show_bug.cgi?id=156808
1757
1758         Add a test for our NSObject swizzling TLS implementation. The test runs on
1759         two threads. One in JS and another in Objective-C. We expect the JS thread
1760         to use our NSObject description override and the Objective-C thread to act
1761         as though it was using the original NSObject description method.
1762
1763         Reviewed by Geoffrey Garen.
1764
1765         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1766         * TestWebKitAPI/Tests/mac/WebScriptObjectDescription.html: Added.
1767         * TestWebKitAPI/Tests/mac/WebScriptObjectDescription.mm: Added.
1768         (nsObjectDescriptionTest):
1769         (-[WebScriptDescriptionTest webView:didFinishLoadForFrame:]):
1770         (TestWebKitAPI::TEST):
1771
1772 2016-04-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1773
1774         [GTK] WebKitWebView should claim the contents size as its natural size
1775         https://bugs.webkit.org/show_bug.cgi?id=156835
1776
1777         Reviewed by Žan Doberšek.
1778
1779         Add test case to check the WebKitWebView preferred size.
1780
1781         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1782         (testWebViewPreferredSize):
1783         (beforeAll):
1784
1785 2016-04-20  Simon Fraser  <simon.fraser@apple.com>
1786
1787         Add content animation tests to benchmark_runner, and allow the runner to collect device data as part of the results
1788         https://bugs.webkit.org/show_bug.cgi?id=156827
1789         
1790         Update the .plan file now that the files are present in SVN.
1791
1792         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
1793
1794 2016-04-20  Simon Fraser  <simon.fraser@apple.com>
1795
1796         Add content animation tests to benchmark_runner, and allow the runner to collect device data as part of the results
1797         https://bugs.webkit.org/show_bug.cgi?id=156827
1798         rdar://problem/24358135
1799
1800         Reviewed by Stephanie Lewis.
1801
1802         Enhance benchmark_runner so that a benchmark can load a set of tests sequentially,
1803         and collate results across them. Also add the ability for the browser_driver to supply
1804         additional results, allowing for tests that collect results data in native code, rather
1805         than generating it in the web page.
1806
1807         Add a set of "content animation" tests that use this new functionality, which test
1808         CSS animation and requestAnimationFrame performance.
1809
1810         'plan' files have two new optional keys:
1811             'test_files': a list of files to run as a suite
1812             'options': optional parameters. Currently supports one new option,
1813                 'animation_command', which affects the way that iOS tests are run,
1814                 and is passed to MobileSafari as a parameter on launch.
1815
1816         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1817         (BenchmarkRunner.__init__): If options is not specified in the plan file, set it to an empty dictionary.
1818         (BenchmarkRunner._get_result): Allow the browser_driver to modify the test results.
1819         (BenchmarkRunner):
1820         (BenchmarkRunner._run_one_test): Factored out of _run_benchmark, this contains logic for
1821         running a single test. It starts and stops the http_server_driver.
1822         (BenchmarkRunner._run_benchmark): Run a test in the traditional way if the plan has an 'entry_point'
1823         key, otherwise look for the new 'test_files' and load each in a loop.
1824         (BenchmarkRunner._dump):
1825         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1826         (BrowserDriver.launch_url): Pass options.
1827         (BrowserDriver.add_additional_results): Allow a driver to supply additional results.
1828         (BrowserDriver):
1829         * Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py:
1830         (GTKMiniBrowserDriver.launch_url):
1831         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1832         (OSXBrowserDriver.close_browsers):
1833         (OSXBrowserDriver._terminate_processes): Fix spelling mistake.
1834         (OSXBrowserDriver._terminiate_processes): Deleted.
1835         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1836         (OSXChromeDriver.launch_url):
1837         (OSXChromeCanaryDriver.launch_url):
1838         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1839         (OSXFirefoxDriver.launch_url):
1840         (OSXFirefoxNightlyDriver.launch_url):
1841         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1842         (OSXSafariDriver.launch_url):
1843         * Scripts/webkitpy/benchmark_runner/data/patches/ContentAnimation.patch: Added.
1844         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan: Added.
1845
1846 2016-04-20  Dustin Falgout  <dustin@falgout.us>
1847
1848         [GTK] Expose AllowUniversalAccessFromFileURLs preference now that calling localStorage.getItem() results in SecurityError: DOM Exception 18
1849         https://bugs.webkit.org/show_bug.cgi?id=156651
1850
1851         Reviewed by Michael Catanzaro.
1852
1853         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1854         (testWebKitSettings):
1855
1856 2016-04-20  Brady Eidson  <beidson@apple.com>
1857
1858         Modern IDB (Workers): Enable INDEXED_DATABASE_IN_WORKERS compile time flag, but disabled in RuntimeEnabledFeatures.
1859         https://bugs.webkit.org/show_bug.cgi?id=156782
1860
1861         Reviewed by Alex Christensen.
1862
1863         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1864
1865 2016-04-19  Brent Fulgham  <bfulgham@apple.com>
1866
1867         Unreviewed build fix after r199752.
1868
1869         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1870         (FrameLoadDelegate::didChangeIcons): Remove call to removed function.
1871
1872 2016-04-19  Brent Fulgham  <bfulgham@apple.com>
1873
1874         Remove remaining bits of dynamic <link> rel='icon' loading
1875         https://bugs.webkit.org/show_bug.cgi?id=156727
1876
1877         Reviewed by Darin Adler.
1878
1879         Remove unused test infrastructure. This code never existed in WebKit2
1880         testing since was only used on Windows.
1881
1882         * DumpRenderTree/TestRunner.cpp:
1883         (dumpIconChangesCallback): Deleted.
1884         * DumpRenderTree/TestRunner.h:
1885         (TestRunner::dumpIconChanges): Deleted.
1886         (TestRunner::setDumpIconChanges): Deleted.
1887
1888 2016-04-19  Keith Miller  <keith_miller@apple.com>
1889
1890         ObjcInstance::stringValue should not call NSObject's description method
1891         https://bugs.webkit.org/show_bug.cgi?id=156758
1892
1893         Reviewed by Geoffrey Garen.
1894
1895         Add new methods to ObjCController that expose two Types of WebScriptObjects. The first is
1896         an NSObject and the second is an NSArray of NSObjects. These are used to test that we don't
1897         call the NSObjects description method without first swizzling it.
1898
1899         * DumpRenderTree/mac/ObjCController.m:
1900         (+[ObjCController isSelectorExcludedFromWebScript:]):
1901         (+[ObjCController webScriptNameForSelector:]):
1902         (-[ObjCController testArrayOfObjects]):
1903         (-[ObjCController testObject]):
1904
1905 2016-04-18  Dan Bernstein  <mitz@apple.com>
1906
1907         Fixed building with old Xcode.
1908
1909         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
1910         (TEST):
1911
1912 2016-04-18  Dean Jackson  <dino@apple.com>
1913
1914         New SPI to export a dictionary of runtime features
1915         https://bugs.webkit.org/show_bug.cgi?id=156645
1916         <rdar://problem/23621666>
1917
1918         Reviewed by Darin Adler.
1919
1920         Test the experimental features SPI on WKPreferences.
1921
1922         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
1923
1924 2016-04-18  Yusuke Suzuki  <utatane.tea@gmail.com>
1925
1926         [JSCOnly] Implement RunLoop and remove glib dependency
1927         https://bugs.webkit.org/show_bug.cgi?id=155706
1928
1929         Reviewed by Michael Catanzaro.
1930
1931         Add TestWTF to JSCOnly port to test WorkQueue and RunLoop.
1932         Platform specific ones locate under jsconly directory since
1933         it is not `generic` (Since it includes the GLIB event loop case).
1934
1935         * CMakeLists.txt:
1936         * TestWebKitAPI/PlatformJSCOnly.cmake: Added.
1937         * TestWebKitAPI/PlatformUtilities.h:
1938         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
1939         (TestWebKitAPI::TEST):
1940         * TestWebKitAPI/config.h:
1941         * TestWebKitAPI/jsconly/PlatformUtilitiesJSCOnly.cpp: Renamed from Source/WTF/wtf/none/RunLoopNone.cpp.
1942         (TestWebKitAPI::Util::run):
1943         (TestWebKitAPI::Util::sleep):
1944         * TestWebKitAPI/jsconly/main.cpp: Renamed from Source/WTF/wtf/none/WorkQueueNone.cpp.
1945         (main):
1946
1947 2016-04-18  Jon Lee  <jonlee@apple.com>
1948
1949         Update Animometer plan.
1950         https://bugs.webkit.org/show_bug.cgi?id=156652
1951
1952         Reviewed by Darin Adler.
1953
1954         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r199616.
1955
1956 2016-04-18  Dana Burkart  <dburkart@apple.com>
1957
1958         svn-apply: add option for ignoring changes to ChangeLog files
1959         https://bugs.webkit.org/show_bug.cgi?id=156618
1960
1961         Reviewed by Darin Adler.
1962
1963         This change adds a new option to svn-apply, --skip-changelogs, which short-circuits out of
1964         patch() if the file in question is a ChangeLog.
1965
1966         * Scripts/svn-apply:
1967         (patch):
1968
1969 2016-04-18  Carlos Garcia Campos  <cgarcia@igalia.com>
1970
1971         Pending API Request URL is wrong after reloading
1972         https://bugs.webkit.org/show_bug.cgi?id=139342
1973
1974         Reviewed by Darin Adler.
1975
1976         Update test case to check that the active URL should remain the
1977         same after a reload.
1978
1979         * TestWebKitAPI/Tests/WebKit2/PendingAPIRequestURL.cpp:
1980         (TestWebKitAPI::TEST):
1981
1982 2016-04-18  Carlos Garcia Campos  <cgarcia@igalia.com>
1983
1984         Pending API request URL no set when loading Data, Alternate HTML or plain text
1985         https://bugs.webkit.org/show_bug.cgi?id=136916
1986
1987         Reviewed by Darin Adler.
1988
1989         Add new test to check that active URL is the requested one right
1990         after calling WKPage load methods.
1991
1992         * TestWebKitAPI/PlatformEfl.cmake:
1993         * TestWebKitAPI/PlatformGTK.cmake:
1994         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1995         * TestWebKitAPI/Tests/WebKit2/PendingAPIRequestURL.cpp: Added.
1996         (TestWebKitAPI::TEST):
1997         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1998         (WebViewTest::loadPlainText): Remove FIXME.
1999         (WebViewTest::loadBytes): Ditto.
2000         (WebViewTest::loadAlternateHTML): Ditto.
2001
2002 2016-04-18  Commit Queue  <commit-queue@webkit.org>
2003
2004         Unreviewed, rolling out r199660.
2005         https://bugs.webkit.org/show_bug.cgi?id=156691
2006
2007         It broke the iOS build (Requested by KaL on #webkit).
2008
2009         Reverted changeset:
2010
2011         "Pending API request URL no set when loading Data, Alternate
2012         HTML or plain text"
2013         https://bugs.webkit.org/show_bug.cgi?id=136916
2014         http://trac.webkit.org/changeset/199660
2015
2016 2016-04-18  Carlos Garcia Campos  <cgarcia@igalia.com>
2017
2018         Pending API request URL no set when loading Data, Alternate HTML or plain text
2019         https://bugs.webkit.org/show_bug.cgi?id=136916
2020
2021         Reviewed by Darin Adler.
2022
2023         Add new test to check that active URL is the requested one right
2024         after calling WKPage load methods.
2025
2026         * TestWebKitAPI/PlatformEfl.cmake:
2027         * TestWebKitAPI/PlatformGTK.cmake:
2028         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2029         * TestWebKitAPI/Tests/WebKit2/PendingAPIRequestURL.cpp: Added.
2030         (TestWebKitAPI::TEST):
2031         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2032         (WebViewTest::loadPlainText): Remove FIXME.
2033         (WebViewTest::loadBytes): Ditto.
2034         (WebViewTest::loadAlternateHTML): Ditto.
2035
2036 2016-04-18  Jeremy Huddleston Sequoia  <jeremyhu@apple.com>
2037
2038         Fix incorrect assumption that APPLE implies Mac.
2039         https://bugs.webkit.org/show_bug.cgi?id=156679
2040
2041         Addresses build failure introduced in r198947
2042
2043         Reviewed by Alex Christensen.
2044
2045         * CMakeLists.txt:
2046
2047 2016-04-18  Carlos Garcia Campos  <cgarcia@igalia.com>
2048
2049         [GTK] Test /webkit2/WebKitWebView/mouse-target fails with overlay scrollbars
2050         https://bugs.webkit.org/show_bug.cgi?id=156621
2051
2052         Reviewed by Martin Robinson.
2053
2054         This is a problem of the test itself, we are using an overflow that is not actually scrollable, but that shows
2055         scrollbar troughs when not using overlay scrollbars because it's marked as scrollable. It would be easier to
2056         simply use the main frame scrollbars to test that and it will work no matter of scrollbars are overlay or not.
2057
2058         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
2059         (testWebViewMouseTarget): Remove the div and move the mouse over the main frame scrollbar to test scrolbars hit test.
2060
2061 2016-04-17  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2062
2063         [EFL] Bump gstreamer from 1.4.4 to 1.6.3
2064         https://bugs.webkit.org/show_bug.cgi?id=156655
2065
2066         Reviewed by Antonio Gomes.
2067
2068         To support html5 video feature, we should bump gstreamer version.
2069
2070         * efl/jhbuild.modules:
2071         * efl/patches/gst-libav.patch: Update against newer version.
2072         * efl/patches/gst-plugins-bad-remove-gnustep-support.patch: Removed because this patch was merged.
2073
2074 2016-04-16  Sam Weinig  <sam@webkit.org>
2075
2076         More build fixing.
2077
2078         * MiniBrowser/mac/BrowserWindowController.m:
2079         (-[BrowserWindowController share:]):
2080
2081 2016-04-16  Sam Weinig  <sam@webkit.org>
2082
2083         Another build fix.
2084
2085         * MiniBrowser/mac/BrowserWindowController.m:
2086         (-[BrowserWindowController sharingServicePicker:sharingServicesForItems:proposedSharingServices:]):
2087
2088 2016-04-16  Sam Weinig  <sam@webkit.org>
2089
2090         Fix 32-bit build.
2091
2092         * MiniBrowser/mac/BrowserWindowController.m:
2093         (-[BrowserWindowController share:]):
2094         (-[BrowserWindowController fetch:]):
2095         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
2096
2097 2016-04-15  Sam Weinig  <sam@webkit.org>
2098
2099         Add support for NSSharingService to MiniBrowser, for no great reasons
2100         https://bugs.webkit.org/show_bug.cgi?id=156658
2101
2102         Reviewed by Darin Adler.
2103
2104         * MiniBrowser/mac/BrowserWindow.xib:
2105         * MiniBrowser/mac/BrowserWindowController.h:
2106         Add the share button.
2107
2108         * MiniBrowser/mac/BrowserWindowController.m:
2109         (-[BrowserWindowController windowDidLoad]):
2110         Set the share button to fire it's actions on mouse down, as it is supposed to act like a menu.
2111
2112         (-[BrowserWindowController share:]):
2113         Show the picker when the button is pressed.
2114         (-[BrowserWindowController mainContentView]):
2115         Add a new override to get the main content view of derived classes (either a WKWebView or the WebView).
2116
2117         (-[BrowserWindowController sharingServicePicker:sharingServicesForItems:proposedSharingServices:]):
2118         (-[BrowserWindowController sharingServicePicker:delegateForSharingService:]):
2119         (-[BrowserWindowController sharingServicePicker:didChooseSharingService:]):
2120         (-[BrowserWindowController sharingService:sourceFrameOnScreenForShareItem:]):
2121         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
2122         (-[BrowserWindowController sharingService:sourceWindowForShareItems:sharingContentScope:]):
2123         Add delegate methods.
2124
2125         * MiniBrowser/mac/WK1BrowserWindowController.m:
2126         (-[WK1BrowserWindowController mainContentView]):
2127         * MiniBrowser/mac/WK2BrowserWindowController.m:
2128         (-[WK2BrowserWindowController mainContentView]):
2129         Implement to return the web view.
2130
2131 2016-04-16  Alexey Proskuryakov  <ap@apple.com>
2132
2133         Build fix.
2134
2135         Temporary workaround for rdar://problem/25754945.
2136
2137         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
2138
2139 2016-04-15  Commit Queue  <commit-queue@webkit.org>
2140
2141         Unreviewed, rolling out r199600.
2142         https://bugs.webkit.org/show_bug.cgi?id=156642
2143
2144         It didn't help (Requested by ap_ on #webkit).
2145
2146         Reverted changeset:
2147
2148         "Build fix."
2149         http://trac.webkit.org/changeset/199600
2150
2151 2016-04-15  Alexey Proskuryakov  <ap@apple.com>
2152
2153         Build fix.
2154
2155         * LayoutTestRelay/LayoutTestRelay/main.m: Allow some deprecated methods.
2156
2157 2016-04-14  Alexey Proskuryakov  <ap@apple.com>
2158
2159         Some GuardMalloc bots are not happy when running many parallel processes
2160         https://bugs.webkit.org/show_bug.cgi?id=156614
2161         rdar://problem/24711525
2162
2163         Reviewed by David Kilzer.
2164
2165         * Scripts/webkitpy/port/mac.py: (MacPort.default_child_processes):
2166
2167 2016-04-14  Brent Fulgham  <bfulgham@apple.com>
2168
2169         Make <a download> a runtime enabled option
2170         https://bugs.webkit.org/show_bug.cgi?id=156583
2171         <rdar://problem/25733449>
2172
2173         Reviewed by Alex Christensen.
2174
2175         * DumpRenderTree/mac/DumpRenderTree.mm:
2176         (resetWebPreferencesToConsistentValues):
2177         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2178         (WTR::InjectedBundle::beginTesting):
2179         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2180         (WTR::TestRunner::setDownloadAttributeEnabled):
2181         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2182
2183 2016-04-14  Anders Carlsson  <andersca@apple.com>
2184
2185         Another build fix attempt.
2186
2187         * MiniBrowser/mac/WK2BrowserWindowController.m:
2188
2189 2016-04-14  Anders Carlsson  <andersca@apple.com>
2190
2191         Fix build.
2192
2193         * MiniBrowser/mac/WK2BrowserWindowController.m:
2194         (-[WK2BrowserWindowController webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
2195
2196 2016-04-14  Anders Carlsson  <andersca@apple.com>
2197
2198         [Mac] Add API for open panel handling to WKWebView
2199         https://bugs.webkit.org/show_bug.cgi?id=137759
2200         rdar://problem/23278623
2201
2202         Reviewed by Tim Horton.
2203
2204         Have MiniBrowser implement the new delegate method.
2205
2206         * MiniBrowser/mac/WK2BrowserWindowController.m:
2207         (-[WK2BrowserWindowController webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
2208
2209 2016-04-14  Jiewen Tan  <jiewen_tan@apple.com>
2210
2211         Unreviewed, rolling out r199554.
2212
2213         The change breaks Yosemite Release/Debug build
2214
2215         Reverted changeset:
2216
2217         "[Mac] Add API for open panel handling to WKWebView"
2218         https://bugs.webkit.org/show_bug.cgi?id=137759
2219         http://trac.webkit.org/changeset/199554
2220
2221 2016-04-14  Anders Carlsson  <andersca@apple.com>
2222
2223         [Mac] Add API for open panel handling to WKWebView
2224         https://bugs.webkit.org/show_bug.cgi?id=137759
2225         rdar://problem/23278623
2226
2227         Reviewed by Tim Horton.
2228
2229         Have MiniBrowser implement the new delegate method.
2230
2231         * MiniBrowser/mac/WK2BrowserWindowController.m:
2232         (-[WK2BrowserWindowController webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
2233
2234 2016-04-14  Jon Lee  <jonlee@apple.com>
2235
2236         Update Animometer plan
2237         https://bugs.webkit.org/show_bug.cgi?id=156569
2238
2239         Reviewed by Alex Christensen.
2240
2241         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r199328. Includes update to screen
2242         resolution, starting with complexity of 1, and fixing SVG, multiply, and text tests.
2243
2244 2016-04-13  Alex Christensen  <achristensen@webkit.org>
2245
2246         CMake MiniBrowser should be an app bundle
2247         https://bugs.webkit.org/show_bug.cgi?id=156521
2248
2249         Reviewed by Brent Fulgham.
2250
2251         * MiniBrowser/mac/CMakeLists.txt:
2252         Make an app bundle and compile nibs.
2253         * MiniBrowser/mac/Info.plist:
2254         CMake doesn't know what to do with :rfc1034identifier and there's no reason to keep it.  This is just MiniBrowser.
2255
2256 2016-04-13  Chris Dumez  <cdumez@apple.com>
2257
2258         We should not speculatively revalidate cached redirects
2259         https://bugs.webkit.org/show_bug.cgi?id=156548
2260         <rdar://problem/25583886>
2261
2262         Reviewed by Darin Adler.
2263
2264         Re-enable speculative loading in the context of layout tests. This was
2265         turned off by mistake when speculative loading was turned into a
2266         setting recently.
2267
2268         * WebKitTestRunner/TestController.cpp:
2269         (WTR::TestController::generatePageConfiguration):
2270
2271 2016-04-12  Alexey Proskuryakov  <ap@apple.com>
2272
2273         Python test webkitpy.common.system.executive_unittest.ExecutiveTest.serial_test_kill_process is flaky
2274         https://bugs.webkit.org/show_bug.cgi?id=155367
2275
2276         Reviewed by Darin Adler.
2277
2278         * Scripts/webkitpy/common/system/executive.py: (Executive.kill_process):
2279         Don't flakily consume the return code with waitpid, callers need to do waitpid on
2280         their own. Not sure if this line of code was even intentional.
2281
2282 2016-04-12  Myles C. Maxfield  <mmaxfield@apple.com>
2283
2284         [OS X] Flakey crash after ScrollAnimatorMac destruction
2285         https://bugs.webkit.org/show_bug.cgi?id=156372
2286
2287         Reviewed by Darin Adler.
2288
2289         Implement the new <!-- webkit-test-runner --> flag.
2290
2291         * WebKitTestRunner/TestController.cpp:
2292         (WTR::TestController::createWebViewWithOptions):
2293         (WTR::TestController::ensureViewSupportsOptionsForTest):
2294         (WTR::TestController::resetPreferencesToConsistentValues):
2295         (WTR::TestController::resetStateToConsistentValues):
2296         (WTR::updateTestOptionsFromTestHeader):
2297         * WebKitTestRunner/TestController.h:
2298         * WebKitTestRunner/TestInvocation.cpp:
2299         (WTR::TestInvocation::invoke):
2300         * WebKitTestRunner/TestOptions.h:
2301         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2302         (WKR::PlatformWebView::viewSupportsOptions):
2303
2304 2016-04-12  Tomas Popela  <tpopela@redhat.com>
2305
2306         Modify the CXXFLAGS in webkitdirs.pm just on architectures where the flags are supported
2307         https://bugs.webkit.org/show_bug.cgi?id=156338
2308
2309         Reviewed by Michael Catanzaro.
2310
2311         Add the "-march=pentium4 -msse2 -mfpmath=sse " into the CXXFLAGS just
2312         for the i686 where it is supported and not for other architectures
2313         (such as s390(x) and ppc(64)) where the build will fail with these
2314         CXXFLAGS.
2315
2316         * Scripts/webkitdirs.pm:
2317         (generateBuildSystemFromCMakeProject):
2318
2319 2016-04-11  Alex Christensen  <achristensen@webkit.org>
2320
2321         Build MiniBrowser with CMake on Mac
2322         https://bugs.webkit.org/show_bug.cgi?id=156471
2323
2324         Reviewed by Daniel Bates.
2325
2326         * CMakeLists.txt:
2327         * DumpRenderTree/CMakeLists.txt:
2328         * DumpRenderTree/PlatformWin.cmake:
2329         * MiniBrowser/mac/CMakeLists.txt: Added.
2330
2331 2016-04-11  Ryuan Choi  <ryuan.choi@navercorp.com>
2332
2333         [EFL] Do not pass context to EwkViewCreate
2334         https://bugs.webkit.org/show_bug.cgi?id=156461
2335
2336         Reviewed by Darin Adler.
2337
2338         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
2339         (TestWebKitAPI::TEST): Removed context argument from EwkViewCreate calls.
2340         * TestWebKitAPI/efl/PlatformWebView.cpp:
2341         (TestWebKitAPI::PlatformWebView::PlatformWebView): Ditto.
2342         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2343         (WTR::PlatformWebView::PlatformWebView): Ditto.
2344
2345 2016-04-11  Fujii Hironori  <Hironori.Fujii@jp.sony.com>
2346
2347         [CMake] Make FOLDER property INHERITED
2348         https://bugs.webkit.org/show_bug.cgi?id=156460
2349
2350         Reviewed by Brent Fulgham.
2351
2352         * CMakeLists.txt:
2353         * DumpRenderTree/CMakeLists.txt:
2354         * DumpRenderTree/PlatformWin.cmake:
2355         * ImageDiff/CMakeLists.txt:
2356         * MiniBrowser/efl/CMakeLists.txt:
2357         * MiniBrowser/gtk/CMakeLists.txt:
2358         * MiniBrowser/win/CMakeLists.txt:
2359         Set FOLDER property as a directory property not a target property
2360
2361 2016-04-10  Caitlin Potter  <caitp@igalia.com>
2362
2363         [Tools] correctly check for braces in multiline branches in macro definition
2364         https://bugs.webkit.org/show_bug.cgi?id=156441
2365
2366         Reviewed by Darin Adler.
2367
2368         Prevents emitting whitespace/braces warning for code like the
2369         following:
2370
2371         ```
2372         #define MACRO(x) \
2373             if (x) { \
2374                 doTheThing(); \
2375                 continue; \
2376             }
2377         ```
2378
2379         * Scripts/webkitpy/style/checkers/cpp.py:
2380         (check_braces):
2381         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2382         (WebKitStyleTest.test_line_breaking):
2383
2384 2016-04-08  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2385
2386         Testharness-based tests that time out should be able to produce a detailed output
2387         https://bugs.webkit.org/show_bug.cgi?id=145313
2388
2389         Reviewed by Xabier Rodriguez-Calvar.
2390
2391         Adding timeout readonly accessor to TestRunner for both WK1 and WK2.
2392
2393         * DumpRenderTree/TestRunner.cpp:
2394         (getTimeoutCallback): The js "timeout" property getter.
2395         (TestRunner::staticValues): Adding "timeout" property to DumpRenderTree so that testRunner.timeout called from JS returns the timeout value.
2396         * DumpRenderTree/TestRunner.h:
2397         (TestRunner::timeout): Adding access to DRT m_timeout private value.
2398         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Adding timeout readonly attribute so that testRunner.timeout can be called from JS.
2399         * WebKitTestRunner/InjectedBundle/TestRunner.h: Adding DOM timeout getter to implement timeout IDL definition.
2400         (WTR::TestRunner::timeout):
2401
2402 2016-04-07  Joseph Pecoraro  <pecoraro@apple.com>
2403
2404         stylebot should know about TestWebKitAPI FeatureDefines.xcconfig
2405         https://bugs.webkit.org/show_bug.cgi?id=156387
2406
2407         Rubber-stamped by Dan Bernstein.
2408
2409         * Scripts/webkitpy/style/checkers/featuredefines.py:
2410         (FeatureDefinesChecker.check):
2411
2412 2016-04-07  Joseph Pecoraro  <pecoraro@apple.com>
2413
2414         Remove ENABLE(ENABLE_ES6_CLASS_SYNTAX) guards
2415         https://bugs.webkit.org/show_bug.cgi?id=156384
2416
2417         Reviewed by Ryosuke Niwa.
2418
2419         * Scripts/webkitperl/FeatureList.pm:
2420         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2421
2422 2016-04-06  Dean Jackson  <dino@apple.com>
2423
2424         Watchlist modifications:
2425         - remove roger_fong
2426         - add myself to a few areas
2427         - remove graouts from WebInspectorAPI
2428
2429         * Scripts/webkitpy/common/config/watchlist:
2430
2431 2016-04-07  Simon Fraser  <simon.fraser@apple.com>
2432
2433         Make it possible to test effect of view exposed rect on tiled backing
2434         https://bugs.webkit.org/show_bug.cgi?id=156365
2435
2436         Reviewed by Tim Horton.
2437
2438         Expose testRunner.setViewSize() and internals.setViewExposedRect() to enable
2439         testing of tile coverage when setViewExposedRect() is passed a non-null rectangle.
2440
2441         testRunner.setViewSize() is used instead of using window.resizeTo(), since we
2442         can't easily resize a window to larger than the screen being tested on.
2443
2444         * DumpRenderTree/TestRunner.cpp:
2445         (setViewSizeCallback):
2446         (TestRunner::staticFunctions):
2447         * DumpRenderTree/TestRunner.h:
2448         * DumpRenderTree/mac/TestRunnerMac.mm:
2449         (TestRunner::setViewSize):
2450         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2451         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2452         (WTR::InjectedBundle::postSetViewSize):
2453         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2454         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2455         (WTR::TestRunner::setViewSize):
2456         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2457         * WebKitTestRunner/TestInvocation.cpp:
2458         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2459
2460 2016-04-07  Jason Marcell  <jmarcell@apple.com>
2461
2462         Adding layout tests for the bot watcher's dashboard QUnit tests.
2463         https://bugs.webkit.org/show_bug.cgi?id=155272
2464
2465         Reviewed by Daniel Bates.
2466
2467         Moved supporting resources into a resources folder and updated index.html accordingly
2468         to point to the new locations. Added code to tests.js to dumpAsText when QUnit is done.
2469
2470         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index-expected.txt: Added.
2471         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Updated to point to tests.js and Mock files in resources directory.
2472         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js: Renamed from
2473         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueue.js.
2474         (MockBuildbotQueue):
2475         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueueView.js: Renamed from
2476         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js.
2477         (MockBuildbotQueueView):
2478         (MockBuildbotQueueView.prototype._latestProductiveIteration):
2479         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js: Renamed from
2480         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js.
2481         (MockTrac):
2482         (MockTrac.prototype.get oldestRecordedRevisionNumber):
2483         (MockTrac.prototype.get latestRecordedRevisionNumber):
2484         (MockTrac.prototype.loadMoreHistoricalData):
2485         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/test-fixture-git-trac-rss.xml: Renamed from
2486         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-git-trac-rss.xml.
2487         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/test-fixture-trac-rss.xml: Renamed from
2488         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-trac-rss.xml.
2489         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js: Renamed from
2490         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js.
2491         Updated the unit tests for Trac._loaded() to point to the XML files that are now located in the 'resources' directory.
2492         (QUnit.done): Added. Removes machine-specific output from test results and calls testRunner.notifyDone to let the layout test harness know that all testing is done.
2493         * Scripts/run-dashboard-tests: Added.
2494
2495 2016-04-06  ChangSeok Oh  <changseok@webkit.org>
2496
2497         Unreviewed, Update my primary email address and expertise.
2498
2499         * Scripts/webkitpy/common/config/contributors.json:
2500
2501 2016-04-06  Jon Lee  <jonlee@apple.com>
2502
2503         Update the Animometer patch and plan files
2504         https://bugs.webkit.org/show_bug.cgi?id=156263
2505
2506         Reviewed by Ryosuke Niwa.
2507
2508         Measure the latest set of tests by updating the plan revision to r199134.
2509
2510         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Update to run the master suite only.
2511         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to use the release page instead
2512         of the developer page.
2513
2514 2016-04-06  Saam barati  <sbarati@apple.com>
2515
2516         jsc-layout-tests.yaml/js/script-tests/regress-141098.js failing on Yosemite Debug after r198989
2517         https://bugs.webkit.org/show_bug.cgi?id=156187
2518
2519         Reviewed by Keith Miller.
2520
2521         * Scripts/run-jsc-stress-tests:
2522
2523 2016-04-06  Alex Christensen  <achristensen@webkit.org>
2524
2525         Compile WebKitTestRunner with CMake on Mac
2526         https://bugs.webkit.org/show_bug.cgi?id=156310
2527
2528         Reviewed by Daniel Bates.
2529
2530         * CMakeLists.txt:
2531         * WebKitTestRunner/CMakeLists.txt:
2532         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2533         * WebKitTestRunner/PlatformEfl.cmake:
2534         * WebKitTestRunner/PlatformGTK.cmake:
2535         * WebKitTestRunner/PlatformMac.cmake: Added.
2536
2537 2016-04-05  Simon Fraser  <simon.fraser@apple.com>
2538
2539         Implement operator== and operator!= for Optional<>
2540         https://bugs.webkit.org/show_bug.cgi?id=156266
2541
2542         Reviewed by Anders Carlsson.
2543
2544         * TestWebKitAPI/Tests/WTF/Optional.cpp:
2545         (TestWebKitAPI::TEST):
2546
2547 2016-04-05  Alex Christensen  <achristensen@webkit.org>
2548
2549         Make CMake-generated binaries on Mac able to run
2550         https://bugs.webkit.org/show_bug.cgi?id=156268
2551
2552         Reviewed by Daniel Bates.
2553
2554         * DumpRenderTree/CMakeLists.txt:
2555         * DumpRenderTree/PlatformMac.cmake:
2556         * DumpRenderTree/PlatformWin.cmake:
2557         * TestWebKitAPI/PlatformMac.cmake:
2558
2559 2016-04-05  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2560
2561         [Fetch API] Add a runtime flag to fetch API and related constructs
2562         https://bugs.webkit.org/show_bug.cgi?id=156113
2563  
2564         Reviewed by Alex Christensen.
2565
2566         * DumpRenderTree/TestRunner.h:
2567         * DumpRenderTree/mac/DumpRenderTree.mm:
2568         (resetWebPreferencesToConsistentValues):
2569         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2570         (WTR::InjectedBundle::beginTesting):
2571         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2572         (WTR::TestRunner::setWebGL2Enabled):
2573         (WTR::TestRunner::setFetchAPIEnabled):
2574         (WTR::TestRunner::setAllowUniversalAccessFromFileURLs):
2575         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2576
2577 2016-04-05  Keith Miller  <keith_miller@apple.com>
2578
2579         Make Keith a reviewer!
2580         https://bugs.webkit.org/show_bug.cgi?id=156246
2581
2582         Reviewed by Mark Lam.
2583
2584         * Scripts/webkitpy/common/config/contributors.json:
2585
2586 2016-04-05  Antoine Quint  <graouts@apple.com>
2587
2588         [WebGL2] Allow enabling WebGL2 with a runtime flag
2589         https://bugs.webkit.org/show_bug.cgi?id=156166
2590         <rdar://problem/25526929>
2591
2592         Always enable WebGL2 during testing.
2593
2594         Reviewed by Dean Jackson.
2595
2596         * DumpRenderTree/mac/DumpRenderTree.mm:
2597         (resetWebPreferencesToConsistentValues):
2598         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2599         (WTR::InjectedBundle::beginTesting):
2600         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2601         (WTR::TestRunner::setWebGL2Enabled):
2602         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2603
2604 2016-04-04  Bill Ming  <mbbill@gmail.com>
2605
2606         [win] run-webkit-tests failed to launch DumpRenderTree
2607         https://bugs.webkit.org/show_bug.cgi?id=156150
2608
2609         Reviewed by Alex Christensen.
2610
2611         * Tools/Scripts/webkitpy/port/base.py:
2612
2613 2016-04-04  Bill Ming  <mbbill@gmail.com>
2614
2615         prepare-ChangeLog set endl incorrectly.
2616         https://bugs.webkit.org/show_bug.cgi?id=156151
2617
2618         Reviewed by Alex Christensen.
2619
2620         * Tools/Scripts/prepare-ChangeLog:
2621
2622 2016-04-03  Sam Weinig  <sam@webkit.org>
2623
2624         Add SPI to allow install script message handlers in isolated worlds
2625         https://bugs.webkit.org/show_bug.cgi?id=156153
2626
2627         Reviewed by Anders Carlsson.
2628
2629         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
2630         Add new test, WKUserContentController.ScriptMessageHandlerBasicPostIsolatedWorld
2631
2632 2016-04-04  Jiewen Tan  <jiewen_tan@apple.com>
2633
2634         Build fix for r198956.
2635
2636         Unreviewed.
2637
2638         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm:
2639         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
2640         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
2641         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2642
2643 2016-04-04  Bill Ming  <mbbill@gmail.com>
2644
2645         [win] prepare-ChangeLog should treat windows path differently.
2646         https://bugs.webkit.org/show_bug.cgi?id=156120
2647
2648         Reviewed by Brent Fulgham.
2649
2650         * Scripts/prepare-ChangeLog:
2651
2652 2016-04-04  Alejandro G. Castro  <alex@igalia.com>
2653
2654         REGRESSION(r198492): [GTK] The WEB_RTC flag was not correctly added in some situations
2655         https://bugs.webkit.org/show_bug.cgi?id=156164
2656
2657         Reviewed by Philippe Normand.
2658
2659         Enable the new WEB_RTC option by default for Gtk+.
2660
2661         * Scripts/webkitperl/FeatureList.pm:
2662
2663 2016-04-03  Dan Bernstein  <mitz@apple.com>
2664
2665         Use the correct value for the first nightly build with frameworks built for OS X 10.11.
2666
2667         * Scripts/bisect-builds:
2668         (makeNightlyList):
2669
2670 2016-04-03  Dan Bernstein  <mitz@apple.com>
2671
2672         Made bisect-builds work again.
2673
2674         Rubber-stamped by Sam Weinig.
2675
2676         * Scripts/bisect-builds:
2677         Changed to use HTTPS to access nightly.webkit.org, and added a minimum revision for OS X 10.11.
2678
2679 2016-04-01  Jiewen Tan  <jiewen_tan@apple.com>
2680
2681         Build fix for r198956.
2682
2683         Unreviewed.
2684
2685         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2686         * TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLNotChange.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLChange.mm.
2687         (-[ProvisionalURLNotChangeController webView:didFinishNavigation:]):
2688         (-[ProvisionalURLNotChangeController webView:didFailProvisionalNavigation:withError:]):
2689         (TEST):
2690         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
2691         (-[LoadInvalidSchemeDelegate browsingContextController:didFailProvisionalLoadWithError:]):
2692         (TestWebKitAPI::TEST):
2693
2694 2016-04-01  Jiewen Tan  <jiewen_tan@apple.com>
2695
2696         WebKit should dispatchDidFailProvisionalLoad while loading invalid URLs
2697         https://bugs.webkit.org/show_bug.cgi?id=155995
2698         <rdar://problem/14967004>
2699
2700         Reviewed by Andy Estes.
2701
2702         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2703         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm:
2704         (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didFailProvisionalNavigation:withError:]):
2705         (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didStartProvisionalNavigation:]):
2706         (TEST):
2707         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm: Added.
2708         (literalURL):
2709         (-[LoadInvalidURLNavigationActionDelegate webView:didCommitNavigation:]):
2710         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
2711         (TestWebKitAPI::TEST):
2712         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.html: Added.
2713         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm: Added.
2714         (-[LoadInvalidURLWebFrameLoadDelegate webView:didCommitLoadForFrame:]):
2715         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2716         (TestWebKitAPI::TEST):
2717
2718 2016-04-01  Brent Fulgham  <bfulgham@apple.com>
2719
2720         Confirm <a download> satisfies specification criteria
2721         https://bugs.webkit.org/show_bug.cgi?id=156057
2722
2723         Reviewed by Andy Estes.
2724
2725         Revise WebKitTestRunner:
2726         (1) Provide a download client delegate.
2727         (2) Teach WKTR to wait to finish a test until a download finishes.
2728         (3) Allow WKTR to notify the current TestRunner that it can finish.
2729
2730         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2731         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2732         (WTR::InjectedBundle::didReceiveMessageToPage): Update to recognize a new
2733         message "NotifyDownloadDone".
2734         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2735         (WTR::InjectedBundlePage::decidePolicyForNavigationAction): Handle 'download'
2736         attribute case.
2737         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2738         (WTR::TestRunner::waitUntilDownload): Added.
2739         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2740         (WTR::TestRunner::shouldFinishAfterDownload): Added.
2741         * WebKitTestRunner/TestController.cpp:
2742         (WTR::TestController::createWebViewWithOptions): Set up the download client.
2743         (WTR::TestController::downloadDidStart): Added.
2744         (WTR::TestController::decideDestinationWithSuggestedFilename): Added.
2745         (WTR::TestController::downloadDidFinish): Added.
2746         (WTR::TestController::downloadDidFail): Added.
2747         (WTR::TestController::downloadDidCancel): Added.
2748         * WebKitTestRunner/TestController.h:
2749         * WebKitTestRunner/TestInvocation.cpp:
2750         (WTR::TestInvocation::notifyDownloadDone): Added.
2751         * WebKitTestRunner/TestInvocation.h:
2752
2753 2016-04-01  Alex Christensen  <achristensen@webkit.org>
2754
2755         Compile DumpRenderTree with CMake on Mac
2756         https://bugs.webkit.org/show_bug.cgi?id=156088
2757
2758         Reviewed by Brent Fulgham.
2759
2760         * CMakeLists.txt:
2761         * DumpRenderTree/CMakeLists.txt:
2762         * DumpRenderTree/DefaultPolicyDelegate.m:
2763         (-[DefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2764         * DumpRenderTree/DumpRenderTreeFileDraggingSource.m:
2765         * DumpRenderTree/PlatformMac.cmake: Added.
2766         * DumpRenderTree/PlatformWin.cmake:
2767         * DumpRenderTree/mac/AppleScriptController.m:
2768         (convertAEDescToObject):
2769         * DumpRenderTree/mac/DumpRenderTreeMain.mm:
2770         * DumpRenderTree/mac/LayoutTestHelper.m:
2771
2772 2016-03-31  Bill Ming  <mbbill@gmail.com>
2773
2774         https://bugs.webkit.org/show_bug.cgi?id=156094
2775         [Win] TestWebCore target build sometimes fail.
2776
2777         Reviewed by Alex Christensen.
2778
2779         * Tools/TestWebKitAPI/PlatformWin.cmake:
2780
2781 2016-03-31  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2782
2783         [EFL] Bump EFL version to 1.17.0
2784         https://bugs.webkit.org/show_bug.cgi?id=153008
2785
2786         Reviewed by Michael Catanzaro.
2787
2788         Original author is Csaba Osztrogonác  <ossy@webkit.org>
2789
2790         * efl/jhbuild.modules:
2791
2792 2016-03-31  Daniel Bates  <dabates@apple.com>
2793
2794         run-webkit-tests fails to create user's cache directory when System Integrity Protection is enabled
2795         https://bugs.webkit.org/show_bug.cgi?id=156071
2796         <rdar://problem/25467827>
2797
2798         Reviewed by Brent Fulgham.
2799
2800         Fixes an issue where run-webkit-tests will fail to create the suffixed user's cache directory
2801         on non-Apple Internal machines with System Integrity Protection enabled because the OS only
2802         honors the suffix, specified by the environment variable DIRHELPER_USER_DIR_SUFFIX, in
2803         privileged processes. And python(1) does not have sufficient privileges. As a workaround for
2804         systems that have System Integrity Protection enabled we compute the path to the suffixed
2805         user's cache directory by hand.
2806
2807         Additionally, fix an issue where the user's cache directory created by run-webkit-test was
2808         never deleted on cessation of the test run.
2809
2810         * Scripts/webkitpy/port/driver.py:
2811         (Driver._start): Actually store the path to the user's cache directory in self._driver_user_cache_directory
2812         so that we can delete this directory on cessation of the test run.
2813         * Scripts/webkitpy/port/mac.py:
2814         (MacPort):
2815         (MacPort._path_to_user_cache_directory): Unset the environment variable DIRHELPER_USER_DIR_SUFFIX (if set),
2816         query the OS for the path to the user's cache directory and concatenate this path with the
2817         specified suffix.
2818
2819 2016-03-31  Jiewen Tan  <jiewen_tan@apple.com>
2820
2821         WebKit should set Original URL of a download request correctly
2822         https://bugs.webkit.org/show_bug.cgi?id=155914
2823         <rdar://problem/10473811>
2824
2825         Reviewed by Anders Carlsson.
2826
2827         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2828         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2829         (-[DownloadRequestOriginalURLDelegate initWithExpectOriginalURL:]):
2830         (-[DownloadRequestOriginalURLDelegate _downloadDidStart:]):
2831         (-[DownloadRequestOriginalURLNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2832         (TEST):
2833         * TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestOriginalURL.html: Added.
2834         * TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestOriginalURL2.html: Added.
2835         * TestWebKitAPI/Tests/WebKit2Cocoa/DownloadRequestOriginalURLFrame.html: Added.
2836
2837 2016-03-30  Dewei Zhu  <dewei_zhu@apple.com>
2838
2839         Extend animometer timeout for slow CPUs.
2840         https://bugs.webkit.org/show_bug.cgi?id=156047
2841
2842         Reviewed by Ryosuke Niwa.
2843
2844         Extend animometer timeout to 30 minutes for slow device.
2845
2846         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan:
2847
2848 2016-03-30  Daniel Bates  <dabates@apple.com>
2849
2850         run-webkit-tests must create parent directory of user's cache directory before running tests
2851         https://bugs.webkit.org/show_bug.cgi?id=156009
2852         <rdar://problem/25442682>
2853
2854         Reviewed by Alexey Proskuryakov.
2855
2856         The script run-webkit-tests must create the parent directory of the user's cache directory
2857         before running tests because a WebKit2 child process expects that this directory exists
2858         when it starts.
2859
2860         The script run-webkit-tests influences the path chosen by a WebKit2 child process for the
2861         user's temporary directory and user's cache directory via the environment variable
2862         DIRHELPER_USER_DIR_SUFFIX. For the user's temporary directory, run-webkit-tests creates it
2863         as part of setting up the test environment. But run-webkit-tests does not create the user's
2864         cache directory. Therefore there is race between the time AppKit creates it and when the
2865         launched WebContent and Network processes query for the path to the user's cache directory
2866         such that the OS may return the empty string to the WebContent and Network processes if
2867         queried for this directory before AppKit creates it.
2868
2869         * Scripts/webkitpy/port/base.py:
2870         (Port._path_to_user_cache_directory): Added. Base class implementation that returns the
2871         empty string. We will override this method for the OS X port to return the path to the
2872         user's cache directory with the specified suffix.
2873         (Port.remove_cache_directory): Deleted.
2874         * Scripts/webkitpy/port/driver.py:
2875         (Driver.__init__): Initialize self._driver_user_directory_suffix and self._driver_user_cache_directory
2876         to the suffix to use for the user's temporary and cache directories and the path to the
2877         user's cache directory, respectively.
2878         (Driver._setup_environ_for_driver): Modified to set the environment variable DIRHELPER_USER_DIR_SUFFIX
2879         to self._driver_user_directory_suffix.
2880         (Driver._start): Compute the user directory suffix and the path to the user's cache
2881         directory. Create the user's cache directory (if applicable).
2882         (Driver.stop): Modified to remove directory self._driver_user_cache_directory (if applicable).
2883         * Scripts/webkitpy/port/mac.py:
2884         (MacPort.user_cache_directory): Added. Overrides Port._path_to_user_cache_directory().
2885         (MacPort.remove_cache_directory): Deleted.
2886
2887 2016-03-29  Benjamin Poulain  <bpoulain@apple.com>
2888
2889         [WTF] Removing a smart pointer from HashTable issues two stores to the same location
2890         https://bugs.webkit.org/show_bug.cgi?id=155676
2891
2892         Reviewed by Darin Adler.
2893
2894         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2895         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2896
2897 2016-03-29  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
2898
2899         Add machine-readable results for JSC stress tests
2900         https://bugs.webkit.org/show_bug.cgi?id=155771
2901
2902         Reviewed by Darin Adler and Dean Johnson
2903
2904         Add an option to output JSC stress test results to a user-specified file in JSON format.
2905
2906         * Scripts/run-javascriptcore-tests:
2907         (runJSCStressTests): Add JSON output support
2908         (readAllLines): Remove trailing newline from the end of each item
2909
2910 2016-03-29  Alex Christensen  <achristensen@webkit.org>
2911
2912         Fix Windows build.
2913
2914         * TestWebKitAPI/PlatformWin.cmake:
2915
2916 2016-03-29  Timothy Hatcher  <timothy@apple.com>
2917
2918         Update WebKit nightly to have a red needle to better match Safari
2919
2920         https://bugs.webkit.org/show_bug.cgi?id=155983
2921
2922         Reviewed by Joseph Pecoraro.
2923
2924         * WebKitLauncher/webkit.icns:
2925
2926 2016-03-28  Joanmarie Diggs  <jdiggs@igalia.com>
2927
2928         Adding myself as a reviewer.
2929
2930         Unreviewed.
2931
2932         * Scripts/webkitpy/common/config/contributors.json:
2933
2934 2016-03-25  Dewei Zhu  <dewei_zhu@apple.com>
2935
2936         Dromaeo patch used by run-benchmark should not include an invalid address.
2937         https://bugs.webkit.org/show_bug.cgi?id=155910
2938
2939         Reviewed by Ryosuke Niwa.
2940
2941         Should not use invalid 'http://127.0.0.1/Icons/w3c_home' in the patched version of test.
2942         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch:
2943
2944 2016-03-25  Daniel Bates  <dabates@apple.com>
2945
2946         Add WebKitSystemInterface for iOS 9.3
2947         https://bugs.webkit.org/show_bug.cgi?id=155893
2948
2949         Rubber-stamped by Alexey Proskuryakov.
2950
2951         * Scripts/copy-webkitlibraries-to-product-directory:
2952
2953 2016-03-25  Daniel Bates  <dabates@apple.com>
2954
2955         Use webkitdirs::determineXcodeSDK() instead of webkitdirs::willUseIOSDeviceSDK()
2956         in copy-webkitlibraries-to-product-directory
2957         https://bugs.webkit.org/show_bug.cgi?id=155869
2958
2959         Reviewed by Alexey Proskuryakov.
2960
2961         It is sufficient and more direct to call webkitdirs::determineXcodeSDK() instead of
2962         webkitdirs::willUseIOSDeviceSDK() to process the --sdk/--device/--ios-simulator command
2963         line argument.
2964
2965         * Scripts/copy-webkitlibraries-to-product-directory:
2966
2967 2016-03-25  Konstantin Tokarev  <annulen@yandex.ru>
2968
2969         Turned on ENABLE_REQUEST_ANIMATION_FRAME by default for any port.
2970         https://bugs.webkit.org/show_bug.cgi?id=155882
2971
2972         Reviewed by Michael Catanzaro.
2973
2974         It was already enabled in all trunk ports, and is required for
2975         WebInspectorUI to work.
2976
2977         * Scripts/webkitperl/FeatureList.pm:
2978
2979 2016-03-24  Jeremy Zerfas  <WebKit@JeremyZerfas.com>
2980
2981         Improve update-webkit-dependency script.
2982         https://bugs.webkit.org/show_bug.cgi?id=155576
2983
2984         Reviewed by Brent Fulgham.
2985
2986         * Scripts/update-webkit-dependency:
2987         -Updated script to also use ETags for helping to determine whether dependency is up to date.
2988         -Updated script so it usually won't need to download the entire dependency each time it is
2989          ran.
2990         -Updated script to ensure zip file contains expected directories before trying to install.
2991         -Added some more error checking and improved error messages.
2992         (lastModifiedToUnixTime): Deleted.
2993
2994         * Scripts/update-webkit-wincairo-libs:
2995         -Corrected comment about what script does.
2996
2997 2016-03-24 Bill Ming <mbbill@gmail.com>
2998
2999         Fix webkitpy tests after r198617
3000         https://bugs.webkit.org/show_bug.cgi?id=155827
3001
3002         Reviewed by Alex Christensen.
3003
3004         * Scripts/webkitpy/tool/steps/confirmdiff.py:
3005         (ConfirmDiff._show_pretty_diff):
3006
3007 2016-03-23  Bill Ming  <mbbill@gmail.com>
3008
3009         webkit-patch failed to open pretty diff on Windows
3010         https://bugs.webkit.org/show_bug.cgi?id=155827
3011
3012         Reviewed by Alex Christensen.
3013
3014         * Scripts/webkitpy/tool/steps/confirmdiff.py:
3015         (ConfirmDiff._show_pretty_diff):
3016
3017 2016-03-23  Jer Noble  <jer.noble@apple.com>
3018
3019         [ios-sim] RequiresUserActionForPlaybackTest.DoesNotRequireUserActionForMediaPlayback and RequiresUserActionForVideoButNotAudioPlayback failing
3020         https://bugs.webkit.org/show_bug.cgi?id=155764
3021
3022         Reviewed by Eric Carlson.
3023
3024         Remove the requirement for media elements to have webkit-playsinline attributes on iOS.
3025
3026         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
3027         (RequiresUserActionForPlaybackTest::SetUp):
3028
3029 2016-03-23  Anders Carlsson  <andersca@apple.com>
3030
3031         Crash when using KVO from within -[WebView initWithCoder:]
3032         https://bugs.webkit.org/show_bug.cgi?id=155816
3033         rdar://problem/17073265
3034
3035         Reviewed by Dan Bernstein.
3036
3037         Add test.
3038
3039         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3040         * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm: Added.
3041         (-[EarlyKVOCrashResponder initWithWebView:]):
3042         (-[EarlyKVOCrashResponder initWithCoder:]):
3043         (-[EarlyKVOCrashResponder dealloc]):
3044         (-[EarlyKVOCrashResponder encodeWithCoder:]):
3045         (TestWebKitAPI::TEST):
3046
3047 2016-03-23  Lucas Forschler  <lforschler@apple.com>
3048
3049         Teach kill-old-processes about perl 5.18.
3050         
3051         Reviewed by Alexey Proskuryakov
3052
3053         * BuildSlaveSupport/kill-old-processes:
3054         (main):
3055
3056 2016-03-22  Keith Rollin  <krollin@apple.com>
3057
3058         Unreviewed: add Keith Rollin to the committers list.
3059
3060         * Scripts/webkitpy/common/config/contributors.json:
3061
3062 2016-03-22  Per Arne Vollan  <peavo@outlook.com>
3063
3064         [Win] [64-bit] Remove MSVC 2013 FMA3 Bug Workaround
3065         https://bugs.webkit.org/show_bug.cgi?id=141499
3066
3067         Reviewed by Brent Fulgham.
3068
3069         As we have moved on to VS2015, this workaround is no longer needed.
3070
3071         * DumpRenderTree/cg/ImageDiffCG.cpp:
3072         (main):
3073         * DumpRenderTree/win/DumpRenderTree.cpp:
3074         (main):
3075         * DumpRenderTree/win/ImageDiffCairo.cpp:
3076         (main):
3077         * MiniBrowser/win/Common.cpp:
3078         (DllMain):
3079         * TestWebKitAPI/win/main.cpp:
3080         (main):
3081         * win/DLLLauncher/DLLLauncherMain.cpp:
3082         (wWinMain):
3083
3084 2016-03-22  Yusuke Suzuki  <utatane.tea@gmail.com>
3085
3086         [JSC] ASMBench cannot be run without JSBENCH_PATH
3087         https://bugs.webkit.org/show_bug.cgi?id=155751
3088
3089         Reviewed by Saam Barati.
3090
3091         Check ASMBENCH_PATH instead of JSBENCH_PATH for ASMBench files.
3092
3093         * Scripts/run-jsc-benchmarks:
3094
3095 2016-03-21  Brent Fulgham  <bfulgham@apple.com>
3096
3097         [Win] SharedBuffer::copy() can cause a segmentation fault.
3098         https://bugs.webkit.org/show_bug.cgi?id=155739
3099
3100         Reviewed by Ryosuke Niwa.
3101
3102         * TestWebKitAPI/PlatformWin.cmake: Build and run the
3103         SharedBuffer tests.
3104
3105 2016-03-22  Csaba Osztrogonác  <ossy@webkit.org>
3106
3107         [buildbot] Move ARM Linux bots to JSCOnly port
3108         https://bugs.webkit.org/show_bug.cgi?id=155655
3109
3110         Reviewed by Lucas Forschler.
3111
3112         * BuildSlaveSupport/build.webkit.org-config/config.json:
3113         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3114         (ConfigureBuild.__init__):
3115         (appendCustomBuildFlags):
3116         (CompileJSCOnly):
3117         (Factory.__init__):
3118         (BuildAndRemoteJSCTestsFactory):
3119         (BuildAndRemoteJSCTestsFactory.__init__):
3120         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3121         * BuildSlaveSupport/clean-build:
3122         (main):
3123
3124 2016-03-21  Brent Fulgham  <bfulgham@apple.com>
3125
3126         Improve SharedBuffer testing
3127         https://bugs.webkit.org/show_bug.cgi?id=93078
3128         <rdar://problem/25277829>
3129
3130         Reviewed by Ryosuke Niwa.
3131
3132         Based on a Blink patch by Huang Dongsung <luxtella@company100.net>.
3133         <https://src.chromium.org/viewvc/blink?revision=153850&view=revision,
3134         and a Blink patch by <tyoshino@chromium.org>
3135         <https://src.chromium.org/viewvc/blink?view=rev&revision=151617>
3136
3137         Add three test cases from the Blink project that cover various append,
3138         copy, and createArrayBuffer calls.
3139
3140         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
3141         (TestWebKitAPI::TEST_F):
3142
3143 2016-03-21  Hyungwook Lee  <hyungwook.lee@navercorp.com>
3144
3145         [Win] Connect layoutTestController.findString() to support testing
3146         https://bugs.webkit.org/show_bug.cgi?id=50234
3147
3148         Reviewed by Alex Christensen.
3149
3150         Implement TestRunner::findString().
3151
3152         * DumpRenderTree/win/TestRunnerWin.cpp:
3153         (TestRunner::findString):
3154
3155 2016-03-20  Dan Bernstein  <mitz@apple.com>
3156
3157         [Mac] Determine TARGET_MAC_OS_X_VERSION_MAJOR from MACOSX_DEPLOYMENT_TARGET rather than from MAC_OS_X_VERSION_MAJOR
3158         https://bugs.webkit.org/show_bug.cgi?id=155707
3159         <rdar://problem/24980691>
3160
3161         Reviewed by Darin Adler.
3162
3163         * ContentExtensionTester/Configurations/Base.xcconfig: Set TARGET_MAC_OS_X_VERSION_MAJOR
3164           based on the last component of MACOSX_DEPLOYMENT_TARGET.
3165         * ContentExtensionTester/Configurations/DebugRelease.xcconfig: For engineering builds,
3166           preserve the behavior of TARGET_MAC_OS_X_VERSION_MAJOR being the host’s OS version.
3167
3168         Similarly for these projects:
3169
3170         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3171         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3172         * LayoutTestRelay/Configurations/Base.xcconfig:
3173         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
3174         * MiniBrowser/Configurations/Base.xcconfig:
3175         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3176         * TestWebKitAPI/Configurations/Base.xcconfig:
3177         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3178         * WebEditingTester/Configurations/Base.xcconfig:
3179         * WebEditingTester/Configurations/DebugRelease.xcconfig:
3180         * WebKitTestRunner/Configurations/Base.xcconfig:
3181         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3182
3183 2016-03-20  Dan Bernstein  <mitz@apple.com>
3184
3185         Update build settings
3186
3187         Rubber-stamped by Andy Estes.
3188
3189         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
3190         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3191         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
3192         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3193         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3194         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Synced up to the ones in ../Source.
3195         * WebEditingTester/Configurations/DebugRelease.xcconfig:
3196         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3197         * asan/asan.xcconfig:
3198
3199 2016-03-18  Sam Weinig  <sam@webkit.org>
3200
3201         Add test for HashMap::ensure that shows that moving into the lambda does not incure extra cost
3202         https://bugs.webkit.org/show_bug.cgi?id=155621
3203
3204         Reviewed by Alex Christensen.
3205
3206         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3207         (TestWebKitAPI::ObjectWithRefLogger::ObjectWithRefLogger):
3208         (TestWebKitAPI::testMovingUsingEnsure):
3209         (TestWebKitAPI::testMovingUsingAdd):
3210         Add tests ensuring that objects moved into a map using ensure don't
3211         have extra ref-churn.
3212
3213 2016-03-17  Tim Horton  <timothy_horton@apple.com>
3214
3215         Fix some deprecation warnings in WebEditingTester
3216         https://bugs.webkit.org/show_bug.cgi?id=155601
3217
3218         Reviewed by Simon Fraser.
3219
3220         * WebEditingTester/AppDelegate.m:
3221         (-[WebEditingAppDelegate showOperations:]):
3222         (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
3223
3224 2016-03-17  Tim Horton  <timothy_horton@apple.com>
3225
3226         Find-in-page indicator in Mail viewer is the wrong scale and cut off
3227         https://bugs.webkit.org/show_bug.cgi?id=155605
3228         <rdar://problem/23948165>
3229
3230         Reviewed by Simon Fraser.
3231
3232         * TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm:
3233         (TEST):
3234         Add a test that ensures that the find result image is correctly @2x.
3235         The NSImage size should be in points.
3236
3237 2016-03-16  Commit Queue  <commit-queue@webkit.org>
3238
3239         Unreviewed, rolling out r198187.
3240         https://bugs.webkit.org/show_bug.cgi?id=155564
3241
3242         Potentially break testing on iOS (Requested by Guest23 on
3243         #webkit).
3244
3245         Reverted changeset:
3246
3247         "Add twisted-15.5.0 module to
3248         webkitpy.thirdparty.autoinstalled."
3249         https://bugs.webkit.org/show_bug.cgi?id=154667
3250         http://trac.webkit.org/changeset/198187
3251
3252 2016-03-16  David Kilzer  <ddkilzer@apple.com>
3253
3254         check-webkit-style: should warn about blank lines after #include "config.h" in TestWebKitAPI
3255         <http://webkit.org/b/155445>
3256
3257         Reviewed by Darin Adler.
3258
3259         * Scripts/webkitpy/style/checker.py:
3260         (_PATH_RULES_SPECIFIER): Do not ignore "build/include*" checks
3261         on TestWebKitAPI since this project uses a config.h header as of
3262         r95188.  Also remove references to WebKitAPITest, which ceased
3263         to exist in r95944.
3264
3265         * Scripts/webkitpy/style/checker_unittest.py:
3266         (GlobalVariablesTest.test_path_rules_specifier): Add tests.
3267         Remove reference to WebKitAPITest project.
3268
3269 2016-03-16  Tim Horton  <timothy_horton@apple.com>
3270
3271         [mac] Printing test snapshots are upside-down after r198242
3272         https://bugs.webkit.org/show_bug.cgi?id=155543
3273
3274         Reviewed by Simon Fraser.
3275
3276         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3277         (createPagedBitmapContext):
3278         Flip printing snapshots in DRT so that everything is right-side-up.
3279
3280 2016-03-16  Alexey Proskuryakov  <ap@apple.com>
3281
3282         Update unit test for iOS debug queues.
3283
3284         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3285
3286 2016-03-16  Jiewen Tan  <jiewen_tan@apple.com>
3287
3288         URL Parsing should signal failure for illegal IDN
3289         https://bugs.webkit.org/show_bug.cgi?id=154945
3290         <rdar://problem/8014795>
3291
3292         Reviewed by Brent Fulgham.
3293
3294         * MiniBrowser/mac/WK2BrowserWindowController.m:
3295         (-[WK2BrowserWindowController fetch:]):
3296         * TestWebKitAPI/Tests/Cocoa/URLExtras.mm:
3297         (TestWebKitAPI::TEST):
3298
3299 2016-03-15  Tim Horton  <timothy_horton@apple.com>
3300
3301         [iOS Simulator] Test result snapshots are upside down
3302         https://bugs.webkit.org/show_bug.cgi?id=154761
3303
3304         Reviewed by Simon Fraser.
3305
3306         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3307         (WTR::createCGContextFromImage):
3308         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3309         In r97104, Simon added code to take WindowServer snapshots, which came
3310         in flipped, and added code to flip them back. At this point, WindowServer
3311         snapshots got flipped, and software snapshots did not.
3312
3313         In r140067, Simon noticed that WindowServer ref test images were upside-down
3314         on Mac (not sure why this changed), so turned off the flipping code (but
3315         didn't delete it!). Now, WindowServer snapshots and software snapshots both
3316         are not flipped.
3317
3318         In r190304, Carlos added an enum for the source of the snapshot ("WebView"
3319         for window server snapshots, and "WebContent" for software snapshots),
3320         and - critically - changed the flipping logic to flip software snapshots!
3321
3322         We didn't notice this on Mac because at this point we've made it so that
3323         we *always* have WindowServer snapshots, but on iOS we still don't have
3324         WindowServer snapshots, so now they're flipped.
3325
3326         And that's how we got here.
3327
3328         To restore the behavior from r140067, and correctly unflip snapshots on
3329         iOS, just delete this code.
3330
3331 2016-03-15  Alexey Proskuryakov  <ap@apple.com>
3332
3333         run-api-tests doesn't print test name when the test crashes
3334         https://bugs.webkit.org/show_bug.cgi?id=155476
3335
3336         Reviewed by Daniel Bates.
3337
3338         * Scripts/run-api-tests: Print "UNEXPECTEDLY EXITED" with a test name when output
3339         doesn't contain the test name yet. Changed test name output to always be before raw
3340         stdout for clarity.
3341
3342 2016-03-15  Chris Dumez  <cdumez@apple.com>
3343
3344         Unreviewed, rolling out r198203.
3345
3346         Favorites view is no longer loading on iOS
3347
3348         Reverted changeset:
3349
3350         "URL Parsing should signal failure for illegal IDN"
3351         https://bugs.webkit.org/show_bug.cgi?id=154945
3352         http://trac.webkit.org/changeset/198203
3353
3354 2016-03-15  Jiewen Tan  <jiewen_tan@apple.com>
3355
3356         URL Parsing should signal failure for illegal IDN
3357         https://bugs.webkit.org/show_bug.cgi?id=154945
3358         <rdar://problem/8014795>
3359
3360         Reviewed by Brent Fulgham.
3361
3362         * MiniBrowser/mac/WK2BrowserWindowController.m:
3363         (-[WK2BrowserWindowController fetch:]):
3364         * TestWebKitAPI/Tests/Cocoa/URLExtras.mm:
3365         (TestWebKitAPI::TEST):
3366
3367 2016-03-14  Chris Dumez  <cdumez@apple.com>
3368
3369         Unreviewed, rolling out r197981.
3370
3371         Caused a massive PLT regression on Mac.
3372
3373         Reverted changeset:
3374
3375         "Font antialiasing (smoothing) changes when elements are
3376         rendered into compositing layers"
3377         https://bugs.webkit.org/show_bug.cgi?id=23364
3378         http://trac.webkit.org/changeset/197981
3379
3380 2016-03-14  Dewei Zhu  <dewei_zhu@apple.com>
3381
3382         Add twisted-15.5.0 module to webkitpy.thirdparty.autoinstalled.
3383         https://bugs.webkit.org/show_bug.cgi?id=154667
3384
3385         Reviewed by Ryosuke Niwa and Simon Fraser.
3386
3387         Add twisted-15.5.0 to webkitpy.thirdparty.autoinstalled.
3388         Minor fix for twsited_http_server used by run-benchmark that we should only stop http server while recieving 'GET /shutdown'.
3389
3390         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
3391         (ServerControl.render_POST): Deleted.
3392         * Scripts/webkitpy/thirdparty/__init__.py:
3393         (AutoinstallImportHook.find_module):
3394         (AutoinstallImportHook._install_twisted_15_5_0):
3395         * Scripts/webkitpy/thirdparty/__init___unittest.py:
3396         (ThirdpartyTest.test_imports):
3397
3398 2016-03-14  Mark Lam  <mark.lam@apple.com>
3399
3400         Need to distinguish between Symbol() and Symbol("").
3401         https://bugs.webkit.org/show_bug.cgi?id=155438
3402
3403         Reviewed by Saam Barati.
3404
3405         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3406         (TestWebKitAPI::TEST):
3407         - Test that the a symbol with an empty string is not equivalent to a null symbol. 
3408
3409 2016-03-14  David Kilzer  <ddkilzer@apple.com>
3410
3411         Remove blank lines after #include "config.h"
3412
3413         Follow-up fix from review comments on Bug 155394.
3414
3415         * TestWebKitAPI/PlatformUtilities.cpp:
3416         * TestWebKitAPI/Tests/WTF/RefLogger.cpp:
3417
3418 2016-03-14  Frederic Wang  <fred.wang@free.fr>
3419
3420         Unreviewed: Add my professional email address.
3421
3422         * Scripts/webkitpy/common/config/contributors.json:
3423
3424 2016-03-14  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3425
3426         Web platform test server should not try to launch servers on already bound sockets
3427         https://bugs.webkit.org/show_bug.cgi?id=141157
3428
3429         Reviewed by Darin Adler.
3430
3431         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3432         (wpt_config_json): Load WPT config from LayoutTests/imported/w3c/resources/config.json.
3433         (base_url): Refactored to use wpt_config_json routine.
3434         (WebPlatformTestServer.__init__): Fill port mappings according WPT config.
3435
3436 2016-03-13  Joseph Pecoraro  <pecoraro@apple.com>
3437
3438         Remove ENABLE(ES6_TEMPLATE_LITERAL_SYNTAX) guards
3439         https://bugs.webkit.org/show_bug.cgi?id=155417
3440
3441         Reviewed by Yusuke Suzuki.
3442
3443         * Scripts/webkitperl/FeatureList.pm:
3444         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3445
3446 2016-03-13  Dean Jackson  <dino@apple.com>
3447
3448         DRT should enable WebGL by default on Mac
3449         https://bugs.webkit.org/show_bug.cgi?id=155419
3450         <rdar://problem/25136981>
3451
3452         Reviewed by Sam Weinig.
3453
3454         For some reason, lost in time, WebGL was enabled
3455         by default on trunk, but disabled by default
3456         in DumpRenderTree when using WebKit 1. This
3457         was very annoying, because each test had
3458         an explicit command to enable it.
3459
3460         * DumpRenderTree/mac/DumpRenderTree.mm:
3461         (resetWebPreferencesToConsistentValues): Deleted WebGL line.
3462
3463 2016-03-13  Konstantin Tokarev  <annulen@yandex.ru>
3464
3465         Added new port JSCOnly.
3466         https://bugs.webkit.org/show_bug.cgi?id=154512
3467
3468         Reviewed by Michael Catanzaro.
3469
3470         This port allows to build JavaScriptCore engine with minimal
3471         dependencies.
3472
3473         * Scripts/build-jsc:
3474         * Scripts/webkitdirs.pm:
3475         (argumentsForConfiguration):
3476         (executableProductDir):
3477         (determinePortName):
3478         (isJSCOnly):
3479         (wrapperPrefixIfNeeded):
3480         (generateBuildSystemFromCMakeProject):
3481         (buildCMakeGeneratedProject):
3482
3483 2016-03-13  David Kilzer  <ddkilzer@apple.com>
3484
3485         TestWebKitAPI: fix linker warnings
3486         <http://webkit.org/b/155394>
3487
3488         Reviewed by Darin Adler.
3489
3490         * TestWebKitAPI/CMakeLists.txt:
3491         - Add RefLogger.cpp source file.
3492         - Add other missing cross-platform source files.
3493         - Add FIXMEs about RunLoop.cpp and about missing
3494           platform-specific source files.
3495         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3496         - Add RefLogger.cpp source file.
3497
3498         * TestWebKitAPI/Counters.cpp:
3499         (DeleterCounter<ConstructorDestructorCounter>::deleterCount):
3500         Move specific declaration here to fix linker warning.
3501         * TestWebKitAPI/Counters.h:
3502         (DeleterCounter<T>::deleterCount): Remove declaration of global
3503         template variable.
3504
3505         * TestWebKitAPI/Tests/WTF/RefLogger.cpp: Added.
3506         (TestWebKitAPI::log): Added.  Move inline definition in
3507         RefLogger.h to here to fix linker warning.
3508
3509         * TestWebKitAPI/Tests/WTF/RefLogger.h:
3510         (TestWebKitAPI::log): Replace inline function with declaration.
3511
3512 2016-03-12  David Kilzer  <ddkilzer@apple.com>
3513
3514         REGRESSION (r178615): Fix incorrect case in included header for WeakPtr.cpp
3515
3516         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: Change "test.h" to
3517         "Test.h" to fix incorrect case.  This was discovered when adding
3518         WeakPtr.cpp to CMakeLists.txt for the patch on Bug 155394.
3519
3520 2016-03-12  David Kilzer  <ddkilzer@apple.com>
3521
3522         run-webkit-tests: handle Darwin framework/library environment variables more consistently
3523         <http://webkit.org/b/155392>
3524
3525         Reviewed by Daniel Bates.
3526
3527         These changes will make it possible to pass through environment
3528         variables from the run-webkit-tests command-line.
3529
3530         * Scripts/webkitpy/port/base.py:
3531         (Port.to.setup_environ_for_server): Add DYLD_FRAMEWORK_PATH,
3532         __XPC_DYLD_FRAMEWORK_PATH and __XPC_DYLD_LIBRARY_PATH to the
3533         list of variables to keep from the run-webkit-test environment.
3534
3535         * Scripts/webkitpy/port/driver.py:
3536         (Driver._append_environment_variable_path): Add method to append
3537         a path to an environment variable, or set the path if the
3538         variable doesn't exist.
3539         (Driver._setup_environ_for_driver): Extract build_root_path into
3540         a local variable.  Use Driver._append_environment_variable_path
3541         to extend DYLD_LIBRARY_PATH, __XPC_DYLD_LIBRARY_PATH,
3542         DYLD_FRAMEWORK_PATH and __XPC_DYLD_FRAMEWORK_PATH instead of
3543         overwriting them.
3544
3545         * Scripts/webkitpy/port/driver_unittest.py:
3546         (DriverTest.test__append_environment_variable_path): Add test
3547         method to test Driver._append_environment_variable_path.
3548
3549 2016-03-11  Alexey Proskuryakov  <ap@apple.com>
3550
3551         [ios-sim debug] API test WTF_Lock.ContendedShortSection and WTF_ParkingLot.UnparkOneFifty timing out
3552         https://bugs.webkit.org/show_bug.cgi?id=155276
3553
3554         [ios-sim] API test WTF_Condition.TenProducersTenConsumersOneSlot timing out
3555         https://bugs.webkit.org/show_bug.cgi?id=155345
3556
3557         [iOS Simulator] API test timeout: WTF_ParkingLot.UnparkOneFiftyThenFiftyAll
3558         https://bugs.webkit.org/show_bug.cgi?id=153997
3559         <rdar://problem/23580034>
3560
3561         <rdar://problem/23580018> TestWebKitAPI Timeout: WTF_ParkingLot.UnparkOneFifty
3562
3563         Rubber-stamped by Filip Pizlo.
3564
3565         * Scripts/run-api-tests: These tests are pretty slow. Increase API test timeout.
3566
3567         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp: Start running WTF_ParkingLot.UnparkOneFiftyThenFiftyAll
3568         on iOS again.
3569
3570 2016-03-11  Jer Noble  <jer.noble@apple.com>
3571
3572         [ios-sim debug] API tests RequiresUserActionForPlaybackTest.DoesNotRequireUserActionForMediaPlayback and RequiresUserActionForAudioButNotVideoPlayback asserting
3573         https://bugs.webkit.org/show_bug.cgi?id=155365
3574
3575         Reviewed by Darin Adler.
3576
3577         Allow tests running on iOS simulator to play video inline, avoiding this assert.
3578
3579         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
3580         (RequiresUserActionForPlaybackTest::SetUp):
3581
3582 2016-03-11  Frederic Wang  <fwang@igalia.com>
3583
3584         [jhbuild] Disable LLVM OCaml bindings.
3585         https://bugs.webkit.org/show_bug.cgi?id=153274
3586
3587         Reviewed by Michael Catanzaro.
3588
3589         * gtk/jhbuild.modules: disable all (actually only OCaml) bindings for LLVM.
3590
3591 2016-03-11  Commit Queue  <commit-queue@webkit.org>
3592
3593         Unreviewed, rolling out r197495.
3594         https://bugs.webkit.org/show_bug.cgi?id=155369
3595
3596         LLVM is needed to run update-webkitgtk-libs reliably
3597         (Requested by mcatanzaro on #webkit).
3598
3599         Reverted changeset:
3600
3601         "[jhbuild] Remove LLVM dependency."
3602         https://bugs.webkit.org/show_bug.cgi?id=153274
3603         http://trac.webkit.org/changeset/197495
3604
3605 2016-03-11  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3606
3607         WTF should have a similar function as equalLettersIgnoringASCIICase to match beginning of strings
3608         https://bugs.webkit.org/show_bug.cgi?id=153419
3609
3610         Reviewed by Darin Adler.
3611
3612         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3613         (TestWebKitAPI::TEST): Adding test case for startsWithLettersIgnoringASCIICase.
3614
3615
3616 2016-03-10  Simon Fraser  <simon.fraser@apple.com>
3617
3618         Font antialiasing (smoothing) changes when elements are rendered into compositing layers
3619         https://bugs.webkit.org/show_bug.cgi?id=23364
3620
3621         Reviewed by Tim Horton.
3622
3623         Turn off smoothed layer text because it affects many layout test results.
3624
3625         * DumpRenderTree/mac/DumpRenderTree.mm:
3626         (resetWebViewToConsistentStateBeforeTesting):
3627         * WebKitTestRunner/TestController.cpp:
3628         (WTR::TestController::resetStateToConsistentValues):
3629
3630 2016-03-10  Jer Noble  <jer.noble@apple.com>
3631
3632         Partial roll-out of r197953; test fails because encode/decode support of those properties were never added.
3633
3634         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
3635         (TEST): Deleted.
3636
3637 2016-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
3638
3639         [OS X] Main frame scrollbars should appear on the left on RTL systems
3640         https://bugs.webkit.org/show_bug.cgi?id=155149
3641
3642         Reviewed by Simon Fraser.
3643
3644         Setting the volatile default needs to be done early, so it is
3645         plumbed through the injected bundle's initialization routine.
3646
3647         Control of RTL scrollbars is handled by putting the string
3648         <!-- webkit-test-runner [ rtlScrollbars=true ] -->
3649         on the first line of a test.
3650
3651