52de493920cd81ee3ffdb83912bc103e3da272a9
[WebKit-https.git] / Tools / ChangeLog
1 2011-10-27  Adam Barth  <abarth@webkit.org>
2
3         Dis-integrate run-bindings-tests with webkitpy
4         https://bugs.webkit.org/show_bug.cgi?id=71092
5
6         Reviewed by Ryosuke Niwa.
7
8         These tests aren't really adding any value.
9
10         * Scripts/webkitpy/common/config/ports.py:
11         * Scripts/webkitpy/tool/commands/download_unittest.py:
12         * Scripts/webkitpy/tool/mocktool.py:
13         * Scripts/webkitpy/tool/steps/runtests.py:
14         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
15         * Scripts/webkitpy/tool/steps/steps_unittest.py:
16
17 2011-10-27  Eric Seidel  <eric@webkit.org>
18
19         REGRESSION (r98639): NRWT crashes when parsing leaks output
20         https://bugs.webkit.org/show_bug.cgi?id=71087
21
22         Unreviewed.  Sadly we have no good way to test logging.
23
24         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
25
26 2011-10-27  David Levin  <levin@chromium.org>
27
28         Test expectation errors should include the file name and platform in both the log and exception info.
29         https://bugs.webkit.org/show_bug.cgi?id=71067
30
31         Reviewed by Ojan Vafai.
32
33         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
34         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
35
36 2011-10-27  Eric Seidel  <eric@webkit.org>
37
38         new-run-webkit-tests doesn't understand --qt or --gtk
39         https://bugs.webkit.org/show_bug.cgi?id=63970
40
41         Reviewed by Ojan Vafai.
42
43         Add support for --qt and --gtk to NRWT.
44         I also removed some incorrect comments in the option parsing
45         code (options which we already implement, but said we didn't)
46         as well as moved --platform parsing out of the "results_options"
47         section into the top configuration section.
48
49         Now run-webkit-tests no longer needs NRWT-specific code for passing
50         --platform=qt, etc.
51
52         * Scripts/run-webkit-tests:
53         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
54
55 2011-10-27  Eric Seidel  <eric@webkit.org>
56
57         REGRESSION (NRWT): build.webkit.org doesn't show the total number of leaks found during a test run on the Leaks bot
58         https://bugs.webkit.org/show_bug.cgi?id=66227
59
60         Reviewed by Adam Roben.
61
62         I believe this should fix the bug.
63
64         * Scripts/run-webkit-tests: make NRWT default for --leaks
65         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
66         (LeakDetector._parse_leaks_output): removed the (unneeded) process_pid argument, and made the regexp use named groups (even though we don't ever grab them by name)
67         (LeakDetector.count_total_bytes_and_unique_leaks): renamed from parse_leak_files
68         (LeakDetector.count_total_leaks): new file (the guts of this change) which is used to re-parse the leaks output during the summarize leaks phase.
69         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
70         Changes to reflect the rename of count_total_bytes_and_unique_leaks and a new test for count_total_leaks.
71         * Scripts/webkitpy/layout_tests/port/mac.py:
72         Use count_total_leaks to spit out the total leak count like ORWT did, and remove the FIXME on the subject.
73
74 2011-10-27  Stephen Chenney  <schenney@chromium.org>
75
76         [Chromium] Need setPrinting
77         https://bugs.webkit.org/show_bug.cgi?id=46152
78
79         Reviewed by Hajime Morita.
80
81         * DumpRenderTree/chromium/LayoutTestController.cpp:
82         (LayoutTestController::LayoutTestController): Added logic for handling setPrinting.
83         (LayoutTestController::reset): Clearing flags for setPrinting.
84         (LayoutTestController::setPrinting): Set flags for setPrinting.
85         * DumpRenderTree/chromium/LayoutTestController.h:
86         (LayoutTestController::setIsPrinting): Added the setPrinting methods and flags.
87         (LayoutTestController::isPrinting): Method to return the setPrinting status.
88         * DumpRenderTree/chromium/TestShell.cpp:
89         (dumpFramesAsPrintedText): A method for creating a text dump in printed layout.
90         (TestShell::dump): Modified to dump setPrinting-specific output.
91         * DumpRenderTree/chromium/WebViewHost.cpp:
92         (WebViewHost::paintPagesWithBoundaries): Handling for pixel tests when setPrinting is
93         active.
94         * DumpRenderTree/chromium/WebViewHost.h: Prototype for paintPagesWithBoundaries.
95
96 2011-10-27  Sam Weinig  <sam@webkit.org>
97
98         Add allowsPlugIns property to WKBrowsingContextGroup
99         https://bugs.webkit.org/show_bug.cgi?id=70987
100
101         Reviewed by Anders Carlsson.
102
103         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
104         Add basic test for WKBrowsingContextGroup.allowsPlugIns. 
105
106 2011-10-27  Adam Roben  <aroben@apple.com>
107
108         Test WKBundlePageGetBackingScaleFactor
109
110         Test for <http://webkit.org/b/71025> <rdar://problem/10355037> REGRESSION (r97191): Clients
111         can't reliably determine the scale factor of snapshots returned via
112         WKBundlePageCreateSnapshot* API
113
114         Reviewed by Sam Weinig.
115
116         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
117
118         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm: Added.
119         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Record the passed-back scale factor.
120         (TestWebKitAPI::setInjectedBundleClient): Hook up our didReceiveMessage callback.
121         (TestWebKitAPI::createWindow): Conjure up a window.
122         (TestWebKitAPI::TEST): Ask the injected bundle code to call the new
123         WKBundlePageGetBackingScaleFactor API when the WKView is in windows with various scale
124         factors and when using a custom scale factor, and check that we get those same scale factors
125         back.
126
127         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor_Bundle.mm: Added.
128         (TestWebKitAPI::GetBackingScaleFactorTest::GetBackingScaleFactorTest): Just initialize our
129         members.
130         (TestWebKitAPI::GetBackingScaleFactorTest::didCreatePage): Store the page for later.
131         (TestWebKitAPI::GetBackingScaleFactorTest::didReceiveMessage): Get the backing scale factor
132         from the page using the new API and send it back.
133
134 2011-10-27  Balazs Kelemen  <kbalazs@webkit.org>
135
136         [Qt][WK2] MiniBrowser crashes when started with 0 arguments
137
138         Rubber-stamped by Simon Hausmann.
139
140         * MiniBrowser/qt/MiniBrowserApplication.cpp:
141         (MiniBrowserApplication::handleUserOptions):
142         Fix typo error.
143
144 2011-10-27  Takashi Toyoshima  <toyoshim@chromium.org>
145
146         [WebSocket] update pywebsocket to 0.7.
147         https://bugs.webkit.org/show_bug.cgi?id=70992
148
149         Reviewed by Kent Tamura.
150
151         pywebsocket 0.7 fixed the bug on dual stack support on OS X.
152
153         * Scripts/webkitpy/thirdparty/__init__.py:
154
155 2011-10-27  Elliot Poger  <epoger@google.com>
156
157         make lion observe MAC lines in test_expectations.txt
158         https://bugs.webkit.org/show_bug.cgi?id=70941
159
160         Reviewed by Ojan Vafai.
161
162         * Scripts/webkitpy/layout_tests/port/chromium.py:
163         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
164
165 2011-10-27  John Knottenbelt  <jknotten@chromium.org>
166
167         [Chromium] Allow DRT to be built without notifications enabled.
168         https://bugs.webkit.org/show_bug.cgi?id=70919
169
170         Reviewed by Tony Gentilcore.
171
172         * DumpRenderTree/chromium/LayoutTestController.cpp:
173         (LayoutTestController::grantDesktopNotificationPermission):
174         (LayoutTestController::simulateDesktopNotificationClick):
175         * DumpRenderTree/chromium/NotificationPresenter.cpp:
176         * DumpRenderTree/chromium/TestShell.cpp:
177         (TestShell::TestShell):
178         (TestShell::resetTestController):
179
180 2011-10-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
181
182         [Qt] Improve command line arguments handling for MiniBrowser.
183         https://bugs.webkit.org/show_bug.cgi?id=70616
184
185         Reviewed by Kenneth Rohde Christiansen.
186
187         - Use two dashes for word arguments.
188         - Return with an error when an unsupported argument is given.
189         - Allow the URL to be placed before option arguments.
190
191         * MiniBrowser/qt/MiniBrowserApplication.cpp:
192         (printHelp):
193         (MiniBrowserApplication::handleUserOptions):
194         * MiniBrowser/qt/utils.cpp:
195         (takeOptionFlag):
196         (takeOptionValue):
197         * MiniBrowser/qt/utils.h:
198
199 2011-10-27  Csaba Osztrogonác  <ossy@webkit.org>
200
201         [Qt] NRWT doesn't work on qt-mac platform
202         https://bugs.webkit.org/show_bug.cgi?id=64445
203
204         Reviewed by Adam Barth.
205
206         * Scripts/run-webkit-tests: Switch qt-mac platform to NRWT.
207         (useNewRunWebKitTests):
208         * Scripts/webkitpy/layout_tests/port/qt.py: Fix library path on Mac.
209
210 2011-10-26  Sam Weinig  <sam@webkit.org>
211
212         Add initial setting to WKBrowsingContextGroup
213         https://bugs.webkit.org/show_bug.cgi?id=70942
214
215         Reviewed by Anders Carlsson.
216
217         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
218         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm: Added.
219         Add basic test that setting the javaScriptEnabled setting takes. It is not
220         possible to test its effect quite yet.
221
222 2011-10-26  Alejandro G. Castro  <alex@igalia.com>
223
224         [GTK] [WK2] Add WebKit2 distcheck support
225         https://bugs.webkit.org/show_bug.cgi?id=70933
226
227         Reviewed by Martin Robinson.
228
229         * WebKitTestRunner/GNUmakefile.am: Add missing files to the
230         sources and EXTRA_DIST.
231
232 2011-10-26  Simon Hausmann  <simon.hausmann@nokia.com>
233
234         [Qt][WK2] Fix failing assertion on startup of MiniBrowser -touch.
235
236         Reviewed by Tor Arne Vestbø.
237
238         We're using QScroller since r98460, which requires QWidget/QApplication. So
239         use QApplication and QtWidgets for the time being.
240
241         * MiniBrowser/qt/MiniBrowser.pro:
242         * MiniBrowser/qt/MiniBrowserApplication.cpp:
243         (MiniBrowserApplication::MiniBrowserApplication):
244         (MiniBrowserApplication::notify):
245         * MiniBrowser/qt/MiniBrowserApplication.h:
246
247 2011-10-25  Zeno Albisser  <zeno.albisser@nokia.com>
248
249         [Qt][WK2] Rewrite MiniBrowser in QML
250         https://bugs.webkit.org/show_bug.cgi?id=70315
251
252         Add the first QML based implementation of MiniBrowser.
253
254         Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com>,
255                  Zeno Albisser <zeno.albisser@nokia.com>
256
257         Reviewed by Tor Arne Vestbø.
258
259         * MiniBrowser/qt/BrowserWindow.cpp:
260         (BrowserWindow::BrowserWindow):
261         (BrowserWindow::webView):
262         (BrowserWindow::load):
263         (BrowserWindow::keyPressEvent):
264         (BrowserWindow::~BrowserWindow):
265         * MiniBrowser/qt/BrowserWindow.h:
266         * MiniBrowser/qt/MiniBrowser.pro:
267         * MiniBrowser/qt/MiniBrowser.qrc:
268         * MiniBrowser/qt/MiniBrowserApplication.cpp:
269         (MiniBrowserApplication::MiniBrowserApplication):
270         (MiniBrowserApplication::handleUserOptions):
271         * MiniBrowser/qt/MiniBrowserApplication.h:
272         (WindowOptions::WindowOptions):
273         * MiniBrowser/qt/UrlLoader.cpp:
274         (UrlLoader::UrlLoader):
275         * MiniBrowser/qt/icons/next.png: Added.
276         * MiniBrowser/qt/icons/previous.png: Added.
277         * MiniBrowser/qt/icons/refresh.png: Added.
278         * MiniBrowser/qt/icons/stop.png: Added.
279         * MiniBrowser/qt/main.cpp:
280         (main):
281         * MiniBrowser/qt/qml/BrowserWindow.qml: Added.
282
283 2011-10-26  Zeno Albisser  <zeno.albisser@nokia.com>
284
285         [Qt][WK2] Remove QtWidgets dependency in MiniBrowser
286         https://bugs.webkit.org/show_bug.cgi?id=70529
287
288         Remove obsolete code for a new QML based implementation
289         of MiniBrowser.
290         Change BrowserWindow to derive from QSGView instead of
291         QMainWindow. QSGView is used as a top level window that
292         provides the container for placing QML content.
293         Make MiniBrowserApplication derive from QGuiApplication
294         instead of QApplication.
295
296         Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com>,
297                  Zeno Albisser <zeno.albisser@nokia.com>
298
299         Reviewed by Simon Hausmann.
300
301         * MiniBrowser/qt/BrowserView.cpp: Removed.
302         * MiniBrowser/qt/BrowserView.h: Removed.
303         * MiniBrowser/qt/BrowserWindow.cpp:
304         (BrowserWindow::BrowserWindow):
305         (BrowserWindow::load):
306         (BrowserWindow::screenshot):
307         (BrowserWindow::loadURLListFromFile):
308         (BrowserWindow::updateUserAgentList):
309         (BrowserWindow::~BrowserWindow):
310         * MiniBrowser/qt/BrowserWindow.h:
311         * MiniBrowser/qt/MiniBrowser.pro:
312         * MiniBrowser/qt/MiniBrowserApplication.cpp:
313         (MiniBrowserApplication::MiniBrowserApplication):
314         (MiniBrowserApplication::notify):
315         * MiniBrowser/qt/MiniBrowserApplication.h:
316         * MiniBrowser/qt/UrlLoader.cpp:
317         (UrlLoader::UrlLoader):
318         * MiniBrowser/qt/main.cpp:
319
320 2011-10-25  Zeno Albisser  <zeno.albisser@nokia.com>
321
322         [Qt][WK2] Remove QAction from MiniBrowser
323         https://bugs.webkit.org/show_bug.cgi?id=70525
324
325         In order to rewrite MiniBrowser in QML we need a suitable
326         mechanism for triggering navigation actions.
327         Due to the QtWidgets dependency of QAction the current
328         solution is not suitable anymore. Therefore we introduce
329         invokable methods and export properties in QWebNavigationController.
330
331         Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com>,
332                  Zeno Albisser <zeno.albisser@nokia.com>
333
334         Reviewed by Simon Hausmann.
335
336         * MiniBrowser/qt/BrowserView.cpp:
337         * MiniBrowser/qt/BrowserView.h:
338         * MiniBrowser/qt/BrowserWindow.cpp:
339         (BrowserWindow::BrowserWindow):
340
341 2011-10-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
342
343         [EFL] Unregister viewport,changed signal in EWebLauncher.
344         https://bugs.webkit.org/show_bug.cgi?id=70478
345
346         Reviewed by Eric Seidel.
347
348         'viewport,changed' signal was registered by EWebLauncher in order to test viewport meta tag.
349         However, it sets wrong layout to some web sites which have viewport meta tag. Because, host pc
350         doesn't support proper DPI value though viewport is using DPI value to compute layout values.
351         This signal is for mobile device.
352
353         * EWebLauncher/main.c:
354         (browserCreate):
355
356 2011-10-25  Anders Carlsson  <andersca@apple.com>
357
358         Plug-ins have no way to find out when the device scale factor changes
359         https://bugs.webkit.org/show_bug.cgi?id=67226
360         <rdar://problem/10048276>
361
362         Reviewed by Sam Weinig.
363
364         Keep a cached copy of the contents scale and update it when it changes.
365
366         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ContentsScaleFactor.cpp:
367         (ContentsScaleFactor::ContentsScaleFactor):
368         (ContentsScaleFactor::cachedContentsScaleFactor):
369         (ContentsScaleFactor::ScriptableObject::hasProperty):
370         (ContentsScaleFactor::ScriptableObject::getProperty):
371         (ContentsScaleFactor::NPP_New):
372         (ContentsScaleFactor::NPP_SetValue):
373
374 2011-10-25  Sam Weinig  <sam@webkit.org>
375
376         Add WKBrowsingContextLoadDelegateTest test for a failed load
377         https://bugs.webkit.org/show_bug.cgi?id=70859
378
379         Reviewed by Anders Carlsson.
380
381         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
382         (TEST_F): Add TEST_F(WKBrowsingContextLoadDelegateTest, SimpleLoadFail).
383  
384         (-[SimpleLoadFailDelegate browsingContextControllerDidFailProvisionalLoad:withError:]):
385         Test that we are getting the correct NSError code and domain.
386
387 2011-10-25  Erik Arvidsson  <arv@chromium.org>
388
389         JS Test Harness: Make successfullyParsed optional
390         https://bugs.webkit.org/show_bug.cgi?id=70784
391
392         Reviewed by Ojan Vafai.
393
394         * Scripts/make-new-script-test:
395         (writeTestFile): Update the template for script tests.
396
397 2011-10-25  Anders Carlsson  <andersca@apple.com>
398
399         Plug-ins have to use JavaScript to find out the current device scale factor
400         https://bugs.webkit.org/show_bug.cgi?id=67225
401         <rdar://problem/10048258>
402
403         Reviewed by Darin Adler.
404
405         Add a plug-in test for getting the contents scale factor.
406
407         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
408         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ContentsScaleFactor.cpp: Added.
409         (ContentsScaleFactor::ContentsScaleFactor):
410         (ContentsScaleFactor::contentsScaleFactor):
411         (ContentsScaleFactor::ScriptableObject::hasProperty):
412         (ContentsScaleFactor::ScriptableObject::getProperty):
413         (ContentsScaleFactor::ScriptableObject::pluginTest):
414         (ContentsScaleFactor::NPP_GetValue):
415
416 2011-10-25  Sam Weinig  <sam@webkit.org>
417
418         Flesh out WKBrowsingContextLoadDelegate a bit
419         https://bugs.webkit.org/show_bug.cgi?id=70846
420
421         Reviewed by Anders Carlsson.
422
423         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
424         * TestWebKitAPI/Tests/WebKit2ObjC: Added.
425         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm: Added.
426         (WKBrowsingContextLoadDelegateTest::WKBrowsingContextLoadDelegateTest):
427         (WKBrowsingContextLoadDelegateTest::SetUp):
428         (WKBrowsingContextLoadDelegateTest::TearDown):
429         (-[SimpleLoadDelegate browsingContextControllerDidFinishLoad:]):
430         (TEST_F):
431         Add basic testing for WKBrowsingContextLoadDelegate.
432
433 2011-10-25  Alexey Proskuryakov  <ap@apple.com>
434
435         make-script-test-wrappers should not look outside fast/js
436         https://bugs.webkit.org/show_bug.cgi?id=66357
437
438         Reviewed by Maciej Stachowiak.
439
440         * Scripts/make-script-test-wrappers: Don't look for template files everywhere, only support
441         fast/js.
442
443 2011-10-25  Adam Barth  <abarth@webkit.org>
444
445         Add a --make option to update-webkit to engage the Makefile-based build system
446         https://bugs.webkit.org/show_bug.cgi?id=70847
447
448         Reviewed by Dimitri Glazkov.
449
450         I can never remember what crazy environment variables I'm supposed to
451         set to tell GYP what to do.
452
453         * Scripts/update-webkit:
454
455 2011-10-25  Raphael Kubo da Costa  <kubo@profusion.mobi>
456
457         [EFL] DRT: Force layout when sending events.
458         https://bugs.webkit.org/show_bug.cgi?id=70357
459
460         Reviewed by Antonio Gomes.
461
462         Some tests such as editing/input/page-up-down-scrolls.html rely on the
463         scrollbars being properly set up during the onload events.
464         Document::implicitClose(), however, dispatches the onload events before
465         calling FrameView::layout(), so these tests usually fail.
466
467         We now do the same as the GTK+ and Chromium ports and manually force the
468         layout when dispatching events.
469
470         * DumpRenderTree/efl/EventSender.cpp:
471         (sendMouseEvent):
472         (keyDownCallback):
473
474 2011-10-25  Daniel Bates  <dbates@rim.com>
475
476         build-webkit --clean should only clean build directory for CMake-based ports
477         https://bugs.webkit.org/show_bug.cgi?id=70834
478
479         Reviewed by Antonio Gomes.
480
481         Currently build-webkit --clean both cleans the build directory and builds WebKit for
482         CMake-based ports. Instead, build-webkit --clean should only clean up the build directory
483         as per its description in the usage message of build-webkit.
484
485         * Scripts/webkitdirs.pm:
486         (buildCMakeProjectOrExit):
487
488 2011-10-25  Anna Cavender  <annacc@chromium.org>
489
490         Enable running of track layout tests for Chromium
491         https://bugs.webkit.org/show_bug.cgi?id=70803
492
493         Reviewed by Adam Barth.
494         
495         Make DumpRenderTree/TestShell always run with track enabled
496         (equivalent of --enable-video-track).
497
498         * DumpRenderTree/chromium/TestShell.cpp:
499         (TestShell::TestShell):
500
501 2011-10-25  Vamshikrishna Yellenki  <vamshi@motorola.com>
502
503         [WK2]Main window never gets focus using TAB key in WebKit2 GTK+.
504         https://bugs.webkit.org/show_bug.cgi?id=70603
505
506         Reviewed by Gustavo Noronha Silva.
507
508         * MiniBrowser/gtk/BrowserWindow.c:
509         (focus):
510         (unFocus):
511         (browserWindowUIClientInit):
512
513 2011-10-25  Dan Bernstein  <mitz@apple.com>
514
515         <rdar://problem/10337033> DOMRangeOfString:relativeTo:options has problems with -webkit-user-select: none
516
517         Reviewed by Adam Roben.
518
519         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
520         (TestWebKitAPI::TEST):
521
522 2011-10-25  Eric Seidel  <eric@webkit.org>
523
524         WIN: editing tests fail under NRWT because editing delegate callbacks aren't stripped
525         https://bugs.webkit.org/show_bug.cgi?id=64471
526
527         Reviewed by Adam Roben.
528
529         Speculative fix.
530
531         * Scripts/webkitpy/layout_tests/port/win.py:
532         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
533
534 2011-10-24  Mikhail Naganov  <mnaganov@chromium.org>
535
536         Fix bug summary when rolling Chromium DEPS to LKGR.
537         https://bugs.webkit.org/show_bug.cgi?id=69917
538
539         Reviewed by Adam Barth.
540
541         * Scripts/webkitpy/tool/bot/irc_command.py:
542         * Scripts/webkitpy/tool/bot/sheriff.py:
543         * Scripts/webkitpy/tool/commands/roll.py:
544         * Scripts/webkitpy/tool/commands/roll_unittest.py:
545
546 2011-10-24  Ivan Briano  <ivan@profusion.mobi>
547
548         [EFL] Build fix. Add include path to find npapi.h
549         https://bugs.webkit.org/show_bug.cgi?id=70730
550
551         Unreviewed build fix.
552
553         * DumpRenderTree/efl/CMakeLists.txt: Add include path for npapi.h
554
555 2011-10-24  Eric Seidel  <eric@webkit.org>
556
557         Plugin tests are failing after switching WK2 to NRWT
558         https://bugs.webkit.org/show_bug.cgi?id=70760
559
560         Reviewed by Simon Fraser.
561
562         Perpetuate this horrible hack.
563
564         * Scripts/webkitpy/layout_tests/port/webkit.py:
565
566 2011-10-24  Eric Seidel  <eric@webkit.org>
567
568         NRWT doesn't support ORWT's --root option, but should
569         https://bugs.webkit.org/show_bug.cgi?id=70416
570
571         Reviewed by Dirk Pranke.
572
573         Add support for ORWT's --root option which is used for
574         running tests with a nightly build of WebKit.
575
576         * Scripts/old-run-webkit-tests:
577         * Scripts/webkitpy/layout_tests/port/base.py:
578          - webkit_build_path was never called by any code, removed.
579         * Scripts/webkitpy/layout_tests/port/webkit.py:
580         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
581
582 2011-10-24  David Levin  <levin@chromium.org>
583
584         check-webkit-style complains about WEBKIT_EXPORT in test/WebUnitTests.h
585         https://bugs.webkit.org/show_bug.cgi?id=70747
586
587         Reviewed by Tony Chang.
588
589         * Scripts/webkitpy/style/checkers/cpp.py: Allow WEBKIT_EXPORT in tests dir.
590         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Corresponding test.
591
592 2011-10-24  Balazs Kelemen  <kbalazs@webkit.org>
593
594         [Qt][WK2] Crash when running pixel tests
595         https://bugs.webkit.org/show_bug.cgi?id=70725
596
597         Reviewed by Chang Shu.
598
599         * WebKitTestRunner/qt/TestInvocationQt.cpp:
600         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
601
602 2011-10-24  Carlos Garcia Campos  <cgarcia@igalia.com>
603
604         [GTK] Remove g_thread_init() calls
605         https://bugs.webkit.org/show_bug.cgi?id=70717
606
607         Reviewed by Xan Lopez.
608
609         With newer glib it's not needed anymore and with previous versions
610         it was already called by g_type_init().
611
612         * DumpRenderTree/gtk/DumpRenderTree.cpp:
613         (main):
614         * GtkLauncher/main.c:
615         (main):
616         * MiniBrowser/gtk/main.c:
617         (main):
618
619 2011-10-24  Alejandro G. Castro  <alex@igalia.com>
620
621         [WK2] [GTK] WebKitTestRunner crashes with heap corruption
622         https://bugs.webkit.org/show_bug.cgi?id=69403
623
624         We did not added autotoolsconfig.h to the config.h file and we
625         were adding Platform.h without the config.h in the
626         WebKitTestRunnerPrefix.h. Added the autotoolsconfig.h include in
627         the Prefix file.
628
629         Reviewed by Martin Robinson.
630
631         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
632
633 2011-10-23  Tomasz Morawski  <t.morawski@samsung.com>
634
635         [EFL] Remove unused code from EWebLauncher
636         https://bugs.webkit.org/show_bug.cgi?id=70590
637
638         Reviewed by Andreas Kling.
639
640         Removed unused function on_closeWindow from EWebLauncher
641
642         * EWebLauncher/main.c:
643
644 2011-10-23  Luke Macpherson   <macpherson@chromium.org>
645
646         Add watchlist for WebCore/css and put myself on it.
647         https://bugs.webkit.org/show_bug.cgi?id=70701
648
649         Reviewed by Adam Barth.
650
651         * Scripts/webkitpy/common/config/watchlist:
652         Add watchlist for WebCore/css and put myself on it.
653
654 2011-10-23  Kaustubh Atrawalkar  <kaustubh@motorola.com>
655
656         [GTK] Implement KeyDown function for WebKit2 EventSender.
657         https://bugs.webkit.org/show_bug.cgi?id=69410
658
659         Reviewed by Martin Robinson.
660
661         Implement the KeyDown function on Gtk platform.
662
663         * WebKitTestRunner/GNUmakefile.am:
664         * WebKitTestRunner/TestController.cpp:
665         (WTR::TestController::TestController):
666         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
667         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp: Added.
668         (WTR::EventSenderProxy::EventSenderProxy):
669         (WTR::dispatchEvent):
670         (WTR::getModifiers):
671         (WTR::getGDKKeySymForKeyRef):
672         (WTR::EventSenderProxy::keyDown):
673
674 2011-10-22  Zan Dobersek  <zandobersek@gmail.com>
675
676         [WK2][GTK] run-launcher script fails after testing WK2 tests
677         https://bugs.webkit.org/show_bug.cgi?id=70676
678
679         Reviewed by Andreas Kling.
680
681         Pass the '-2' flag instead of '--webkit-test-runner' when executing
682         run-launcher script after testing with WebKitTestRunner.
683
684         * Scripts/webkitpy/layout_tests/port/gtk.py:
685
686 2011-10-22  Zan Dobersek  <zandobersek@gmail.com>
687
688         [WK2][GTK] Missing env variables cause WKTR to crash
689         https://bugs.webkit.org/show_bug.cgi?id=70674
690
691         Reviewed by Martin Robinson.
692
693         Set two environment variables that the Gtk's port of WebKitTestRunner
694         depends on and crashes if they're not explicitly set by the user.
695         Also modify the setting of the WEBKIT_INSPECTOR_PATH variable so it
696         properly uses the _build_path method.
697
698         * Scripts/webkitpy/layout_tests/port/gtk.py: Set
699         TEST_RUNNER_INJECTED_BUNDLE_FILENAME and TEST_RUNNER_TEST_PLUGIN_PATH
700         environment variables.
701
702 2011-10-21  Filip Pizlo  <fpizlo@apple.com>
703
704         Bencher script doesn't measure GC times accurately
705         https://bugs.webkit.org/show_bug.cgi?id=70588
706
707         Reviewed by Geoff Garen.
708         
709         Added two new options which allow different ways of measuring GC times:
710         
711         --measure-gc, which omits calls to gc() between benchmark invocations.
712         This option takes an optional argument, which is the name of the
713         VM in which to enable this feature. This allows comparing a single VM
714         against itself, with and without GC.
715         
716         --rerun <N>, which causes each sample measurement to include N invocations
717         which do not have gc() calls between them. The default is N = 1, which
718         results in the same behavior as before.
719         
720         You can use either --measure-gc or --rerun <N> for N > 1 (preferably
721         N >= 3) to get more of a contribution from GC to the measured times.
722         --rerun results in tighter confidence intervals than --measure-gc, since
723         it amortizes GC effects in each sample, while with --measure-gc some
724         samples will see GC and some won't leading to a higher standard devation
725         and thus requiring more samples to reduce confidence intervals to
726         managable levels.
727
728         * Scripts/bencher:
729
730 2011-10-21  Sam Weinig  <sam@webkit.org>
731
732         Remove ability to create a WKView without a WKContextRef and WKPageGroupRef
733         https://bugs.webkit.org/show_bug.cgi?id=70653
734
735         Reviewed by Simon Fraser.
736
737         * MiniBrowser/mac/AppDelegate.h:
738         * MiniBrowser/mac/AppDelegate.m:
739         (-[BrowserAppDelegate init]):
740         (-[BrowserAppDelegate newWindow:]):
741         (-[BrowserAppDelegate openPanelDidEnd:returnCode:contextInfo:]):
742         * MiniBrowser/mac/BrowserWindowController.h:
743         * MiniBrowser/mac/BrowserWindowController.m:
744         (-[BrowserWindowController initWithContext:pageGroup:]):
745         (-[BrowserWindowController windowWillClose:]):
746         (createNewPage):
747         (-[BrowserWindowController awakeFromNib]):
748         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
749         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
750         Update testing code to pass a PageGroup as necessary.
751
752 2011-10-21  Leandro Pereira  <leandro@profusion.mobi>
753
754         webkitpy: Teach NRWT about the EFL port
755         https://bugs.webkit.org/show_bug.cgi?id=70637
756
757         Allows using ``efl'' as a platform when executing NRWT.
758
759         Reviewed by Eric Seidel.
760
761         * Scripts/webkitpy/layout_tests/port/efl.py: Added.
762         * Scripts/webkitpy/layout_tests/port/efl_unittest.py: Added.
763         * Scripts/webkitpy/layout_tests/port/factory.py: Adjust factory to make EflPort objects
764         when using PortFactory.get(port_name='efl').
765
766 2011-10-21  Devdatta Deshpande  <pwjd73@motorola.com>
767
768         [Gtk] mousemove event always has metaKey == true
769         https://bugs.webkit.org/show_bug.cgi?id=35299
770
771         Reviewed by Martin Robinson.
772
773         * DumpRenderTree/gtk/EventSender.cpp:
774         (gdkModifierFromJSValue): GDK_META_MASK is used to represent metaKey for platform GTK mouse and
775         keyboard events. So making it in sync with WebCore files.
776         (mouseMoveToCallback): Sending modifier keys state for mouse move event.
777
778 2011-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
779
780         watchlist: Add a new entry for WebKit2 GTK+ public API
781         https://bugs.webkit.org/show_bug.cgi?id=70601
782
783         Reviewed by Philippe Normand.
784
785         Subscribe myself to WebKit2 GTK+ API patches. Also add a message
786         for patches that might include new API that points to the WebKit2
787         GTK+ API guidelines.
788
789         * Scripts/webkitpy/common/config/watchlist:
790
791 2011-10-21  Simon Hausmann  <simon.hausmann@nokia.com>
792
793         Remove QtScript source code from WebKit.
794         https://bugs.webkit.org/show_bug.cgi?id=64088
795
796         Reviewed by Tor Arne Vestbø.
797
798         Removed dead code that isn't developed anymore.
799
800         * Scripts/webkitpy/style/checker_unittest.py:
801
802 2011-10-20  Eric Seidel  <eric@webkit.org>
803
804         Switch webkit2 bot to NRWT
805         https://bugs.webkit.org/show_bug.cgi?id=56729
806
807         Reviewed by Adam Barth.
808
809         Move the WK2 bot to using NRWT instead of ORWT, as announced on webkit-dev:
810         https://lists.webkit.org/pipermail/webkit-dev/2011-October/018337.html
811
812         * Scripts/run-webkit-tests:
813         (runningOnBuildBot):
814         (useNewRunWebKitTests):
815
816 2011-10-20  Eric Seidel  <eric@webkit.org>
817
818         NRWT is asserting on DRT due to lack of newline when processing line from DumpRenderTree
819         https://bugs.webkit.org/show_bug.cgi?id=70585
820
821         Reviewed by Adam Barth.
822
823         This really should be an assert, as this inidicates a programming error in either DRT or NRWT.
824         However since DRT was functioning fine before in Qt, we'll make this an error log for now
825         and once we find the root cause flip this back to an assert.
826
827         * Scripts/webkitpy/layout_tests/port/webkit.py:
828
829 2011-10-20  Yuta Kitamura  <yutak@chromium.org>
830
831         Unreviewed, rolling out r98064.
832         http://trac.webkit.org/changeset/98064
833         https://bugs.webkit.org/show_bug.cgi?id=64788
834
835         Broke Mac bots.
836
837         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
838
839 2011-10-20  Yuta Kitamura  <yutak@chromium.org>
840
841         WebSocket: Connecting to localhost:8880 takes one second on Windows
842         https://bugs.webkit.org/show_bug.cgi?id=64788
843
844         Reviewed by Dirk Pranke.
845
846         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
847         Bind to "localhost" instead of "127.0.0.1" to let pywebsocket listen on both
848         IPv4 and IPv6 addresses. This should prevent the test reserved-opcodes.html
849         from timing out on Windows, because this test tries to open a lot of
850         connections to localhost and each attempt takes one second to fall back from
851         IPv6 to IPv4 on Windows (I have no idea why Windows works like this, though).
852
853 2011-10-20  Ryosuke Niwa  <rniwa@webkit.org>
854
855         nrwt: newly generated results are put in cross-platform directory
856         https://bugs.webkit.org/show_bug.cgi?id=68931
857
858         Reviewed by Dirk Pranke.
859
860         The bug was caused by SingleTestRunner._add_missing_baselines's always calling _save_baseline_data
861         with generate_new_baseline set to False. Fixed the bug by always passing True when .png file is missing
862         (because png images are typically different on each platform), and passing True when .txt file is missing
863         and the actual result's first line matches the regular expression "layer at \(\d+,\d+\) size \d+x\d+".
864
865         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
866         * Scripts/webkitpy/layout_tests/port/test.py:
867         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Changed the expectation
868         and added a test case.
869
870 2011-10-20  Kent Tamura  <tkent@chromium.org>
871
872         Unreviewed. Adding myself to watchlist.
873
874         * Scripts/webkitpy/common/config/watchlist:
875         Add "ChromiumDumpRenderTree" and "Forms" definitions, and cc them to me.
876
877 2011-10-20  Nico Weber  <thakis@chromium.org>
878
879         [chromium/mac] Add support for building with make
880         https://bugs.webkit.org/show_bug.cgi?id=70455
881
882         Reviewed by Adam Barth.
883
884         Depends on http://codereview.chromium.org/8352029/
885         `GYP_GENERATORS=make Tools/Scripts/update-webkit --chromium` will
886         create a toplevel Makefile.chromium.
887
888         If that file exists and is newer than Source/WebKit/chromium/WebKit.xcodeproj,
889         `Tools/Scripts/build-webkit --chromium` will build with make instead of
890         xcodebuild.
891
892         Also let nrwt use a binary from out/ if it exists.
893
894         * Scripts/webkitdirs.pm:
895         (determineBaseProductDir):
896         (isChromiumMacMake):
897         (determineIsChromiumMacMake):
898         (buildChromium):
899
900 2011-10-20  Eric Seidel  <eric@webkit.org>
901
902         Possible REGRESSION(97879): NRWT fails when DumpRenderTree crashes
903         https://bugs.webkit.org/show_bug.cgi?id=70524
904
905         Reviewed by Adam Barth.
906
907         This is a speculative fix, since I do not use a platform
908         which outputs crashlogs over stderr.
909
910         * Scripts/webkitpy/layout_tests/port/server_process.py:
911         * Scripts/webkitpy/layout_tests/port/webkit.py:
912
913 2011-10-20  Eric Seidel  <eric@webkit.org>
914
915         REGRESSION(97879): Pixel tests no longer work with NRWT on Mac
916         https://bugs.webkit.org/show_bug.cgi?id=70492
917
918         Reviewed by Adam Barth.
919
920         The bug turned out to be that I was assuming the block.content
921         would be empty before the binary content following Content-Length
922         was read inside _read_block.  Turns out its not, due to extra newlines
923         and "ExpectedHash" header.
924
925         In the process of trying to figure out what was going wrong I ended up
926         cleaning up our newline usage in DumpRenderTree a little.  Moved
927         two error messages from stdout to stderr, and fixed a little code indent/whitespace.
928
929         I also fixed ServerProcess to use "deadline" everywhere instead of timeout
930         per Adam's request in the original bug.
931
932         * DumpRenderTree/PixelDumpSupport.cpp:
933         (dumpWebViewAsPixelsAndCompareWithExpected):
934         * DumpRenderTree/cg/ImageDiffCG.cpp:
935         (main):
936         * DumpRenderTree/mac/DumpRenderTree.mm:
937         (dump):
938         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
939         (restoreMainDisplayColorProfile):
940         (setupMainDisplayColorProfile):
941         * Scripts/webkitpy/layout_tests/port/server_process.py:
942         * Scripts/webkitpy/layout_tests/port/webkit.py:
943         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
944
945 2011-10-20  Tony Chang  <tony@chromium.org>
946
947         [chromium] Remove <stdint.h> from ImageDiff and use
948         unsigned int instead of uint32_t.
949
950         Unreviewed, fixing the chromium win build.
951
952         * DumpRenderTree/chromium/ImageDiff.cpp:
953         (Image::pixelAt):
954         (Image::setPixelAt):
955         (maxOf3):
956         (getRedComponent):
957         (getGreenComponent):
958         (getBlueComponent):
959         (weightedPercentageDifferent):
960         (createImageDiff):
961
962 2011-10-20  Hao Zheng  <zhenghao@chromium.org>
963
964         [Chromium] Reduce dependencies of ImageDiff to compile it for Android.
965         https://bugs.webkit.org/show_bug.cgi?id=69997
966
967         Reviewed by Tony Chang.
968
969         This change is required to make ImageDiff for Android, and can benefit
970         other platforms, too. On Android, most targets are built as
971         toolsets:target. while ImageDiff needs to be built as toolsets:host.
972         Currently, building the standalone target of ImageDiff depends on about
973         85 other targets (try  make ImageDiff'), which is inefficient. After the
974         change, ImageDiff only depends on webkit_support_gfx, which in turn
975         depends on libpng and zlib.
976
977         * DumpRenderTree/chromium/ImageDiff.cpp:
978         (main):
979
980 2011-10-20  Leandro Pereira  <leandro@profusion.mobi>
981
982         [EFL] Unreviewed DumpRenderTree build fix.
983
984         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
985         (LayoutTestController::addChromeInputField): Add stub.
986         (LayoutTestController::removeChromeInputField): Ditto.
987         (LayoutTestController::focusWebView): Ditto.
988         (LayoutTestController::setBackingScaleFactor): Ditto.
989
990 2011-10-20  Leandro Pereira  <leandro@profusion.mobi>
991
992         [EFL] Plug ImageDiff/DumpRenderTree on CMake build system
993         https://bugs.webkit.org/show_bug.cgi?id=70142
994
995         Reviewed by Gustavo Noronha Silva.
996
997         * CMakeListsEfl.txt: Include DRT CMakeLists.
998         * DumpRenderTree/efl/CMakeLists.txt: Added.
999
1000 2011-10-20  Philippe Normand  <pnormand@igalia.com>
1001
1002         [style] Allow usage of NULL in gst_*
1003         https://bugs.webkit.org/show_bug.cgi?id=70498
1004
1005         Reviewed by David Levin.
1006
1007         * Scripts/webkitpy/style/checkers/cpp.py: Simplified the detection
1008         of gst_ calls. Now just ignore NULL in all of them.
1009         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Test for above change.
1010
1011 2011-10-20  Leandro Pereira  <leandro@profusion.mobi>
1012
1013         [EFL] Unreviewed. Build fix after r97043.
1014
1015         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1016         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Use ewk_view_scale_set() instead of ewk_view_page_scale().
1017         * DumpRenderTree/efl/EventSender.cpp:
1018         (scalePageByCallback): Ditto.
1019
1020 2011-10-20  Philippe Normand  <pnormand@igalia.com>
1021
1022         Unreviewed. Adding myself to watchlists.
1023         * Scripts/webkitpy/common/config/watchlist:
1024
1025 2011-10-19  Eric Seidel  <eric@webkit.org>
1026
1027         Reviewed by Adam Barth.
1028
1029         Teach new-run-webkit-tests about #CRASHED and #CRASHED - WebProcess
1030         https://bugs.webkit.org/show_bug.cgi?id=63683
1031
1032         * Scripts/webkitpy/common/net/layouttestresults.py:
1033         * Scripts/webkitpy/common/net/resultsjsonparser.py:
1034         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
1035         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
1036         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1037         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
1038         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1039         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
1040         * Scripts/webkitpy/layout_tests/port/base.py:
1041         * Scripts/webkitpy/layout_tests/port/server_process.py:
1042         * Scripts/webkitpy/layout_tests/port/webkit.py:
1043         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1044
1045 2011-10-19  Jochen Eisinger  <jochen@chromium.org>
1046
1047         Chromium doesn't support git branch builds, so don't add the branch to the product dir
1048         https://bugs.webkit.org/show_bug.cgi?id=70449
1049
1050         Reviewed by Eric Seidel.
1051
1052         * Scripts/webkitdirs.pm:
1053         (determineBaseProductDir):
1054
1055 2011-10-19  Ojan Vafai  <ojan@chromium.org>
1056
1057         Unreviewed. Adding myself to watchlists.
1058         * Scripts/webkitpy/common/config/watchlist:
1059
1060 2011-10-19  Tom Zakrajsek  <tomz@codeaurora.org>
1061
1062         Add a suggest-nominations command to webkit-patch for computing potential committer/reviewer nominations
1063         https://bugs.webkit.org/show_bug.cgi?id=62166
1064
1065         Reviewed by Eric Seidel.
1066
1067         Included options to control committer/reviewer patch count requirements,
1068         an age-limit on patches, and verbose output for more in-depth analysis.
1069
1070         * Scripts/webkitpy/common/checkout/changelog.py:
1071         * Scripts/webkitpy/tool/commands/__init__.py:
1072         * Scripts/webkitpy/tool/commands/suggestnominations.py: Added.
1073         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py: Added.
1074
1075 2011-10-19  Eric Seidel  <eric@webkit.org>
1076
1077         new-run-webkit-tests -2 was crashing due to both "java" and "java/" being listed in Skipped files.
1078         Make NRWT normalize directory names in Skipped files during parsing.
1079
1080         Unreviewed.  Very simple (tested) change.
1081
1082         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1083         * Scripts/webkitpy/layout_tests/port/webkit.py:
1084
1085 2011-10-19  David Levin  <levin@chromium.org>
1086
1087         watchlist: Should be more robust to bad regex.
1088         https://bugs.webkit.org/show_bug.cgi?id=69486
1089
1090         Reviewed by Adam Barth.
1091
1092         * Scripts/webkitpy/common/config/watchlist: Change the instructions due to
1093           watchlist being checked by check-webkit-style (bug 69487) and remove the .* from file
1094           patterns since they are no longer anchored on the right hand side.
1095         * Scripts/webkitpy/common/watchlist/amountchangedpattern.py: Change *pattern to take a compiled regex directly.
1096         * Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py: Ditto.
1097         * Scripts/webkitpy/common/watchlist/changedlinepattern.py: Ditto.
1098         * Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py: Ditto.
1099         * Scripts/webkitpy/common/watchlist/filenamepattern.py: Ditto.
1100         * Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py: Ditto and change a test now that
1101         filenames are no longer anchored on the right hand side.
1102         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Catch regex errors and log them as errors.
1103         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Add some tests to verify that bad regexes
1104         don't kill everything.
1105
1106 2011-10-19  David Levin  <levin@chromium.org>
1107
1108         watchlist: Add a stylecheck to do validity checks for the watchlist config.
1109         https://bugs.webkit.org/show_bug.cgi?id=69487
1110
1111         Reviewed by Adam Barth.
1112
1113         * Scripts/webkitpy/style/checker.py: Add the watchlist file type.
1114         * Scripts/webkitpy/style/checkers/watchlist.py: Added.
1115         * Scripts/webkitpy/style/checkers/watchlist_unittest.py: Added.
1116
1117 2011-10-19  Eric Seidel  <eric@webkit.org>
1118
1119         NRWT ServerProcess can't read lines from stderr and stdio separately
1120         https://bugs.webkit.org/show_bug.cgi?id=70435
1121
1122         Reviewed by Adam Barth.
1123
1124         This is the underlying bug behind our lack of WK2 support, and timeout detection on Windows.
1125         DRT expects RWT to read one line at a time from stderr and stdout independently.
1126         This allows DRT to communicate errors over stderr and have them responded to immediately
1127         regardless of what state the stdio stream may be in.  Previously NRWT's ServerProcess
1128         class only exposed a read_line function which would read a line from stdout
1129         and batch all output from stderr into an error buffer.  Callers would only be able
1130         to respond to commands over stderr if they happened to correspond with a stdout line boundary.
1131
1132         * Scripts/webkitpy/layout_tests/port/server_process.py:
1133         * Scripts/webkitpy/layout_tests/port/webkit.py:
1134
1135 2011-10-19  Chang Shu  <cshu@webkit.org>
1136
1137         [Qt] Support WK1-only Skipped list
1138         https://bugs.webkit.org/show_bug.cgi?id=70254
1139
1140         Reviewed by Csaba Osztrogonác.
1141
1142         Added a new search path qt-wk1 for skipping WK1-only tests.
1143
1144         * Scripts/webkitpy/layout_tests/port/qt.py: NRWT
1145         * Scripts/old-run-webkit-tests: ORWT
1146
1147 2011-10-19  Gabor Rapcsanyi  <rgabor@webkit.org>
1148
1149         [GTK] Enable to use built-product-archive on GTK platform
1150         https://bugs.webkit.org/show_bug.cgi?id=70319
1151
1152         Reviewed by Csaba Osztrogonác.
1153
1154         * BuildSlaveSupport/built-product-archive:
1155
1156 2011-10-18  David Levin  <levin@chromium.org>
1157
1158         watchlist: Should try to run if it can and not throw on mistakes.
1159         https://bugs.webkit.org/show_bug.cgi?id=70358
1160
1161         Reviewed by Adam Barth.
1162
1163         * Scripts/webkitpy/common/system/outputcapture.py: Add the ability to capture log output.
1164         * Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Adapt to the logging of errors.
1165         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Change to log problems and fix problems when found.
1166         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Adapt to the logging of errors.
1167         * Scripts/webkitpy/common/watchlist/watchlistrule.py: Expose a way to remove instructions.
1168         * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py: Test the new function.
1169
1170 2011-10-18  Sam Weinig  <sam@webkit.org>
1171
1172         Move uses of C-SPI out of WKView.h and into WKViewPrivate.h
1173         https://bugs.webkit.org/show_bug.cgi?id=70387
1174
1175         Reviewed by Dan Bernstein.
1176
1177         * MiniBrowser/mac/BrowserWindowController.m:
1178         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
1179         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
1180         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1181         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
1182         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1183         Update to include WKViewPrivate.h where necessary.
1184
1185 2011-10-18  Joseph Pecoraro  <joepeck@webkit.org>
1186
1187         Web Inspector: Some localizedStrings.js Updates
1188         https://bugs.webkit.org/show_bug.cgi?id=70365
1189
1190         Reviewed by Darin Adler.
1191
1192         * Scripts/check-inspector-strings:
1193         Updated to the new webkitpy way to determine checkout root.
1194
1195         * Scripts/webkitdirs.pm:
1196         (copyInspectorFrontendFiles):
1197         Made it so build-webkit --inspector-frontend copies over
1198         the localizedStrings.js file as well as the frontend files.
1199
1200 2011-10-18  Raphael Kubo da Costa  <kubo@profusion.mobi>
1201
1202         [EFL] DRT: Clear list of visited pages before each test.
1203         https://bugs.webkit.org/show_bug.cgi?id=70355
1204
1205         Reviewed by Antonio Gomes.
1206
1207         r97596 uncovered a bug in the implementation: the list of visited
1208         links was not cleared between tests, which caused tests such as
1209         fast/repaint/outline-repaint-glitch.html to be flaky (the link color
1210         changed depending on whether fast/repaint/border-repaint-glitch.html
1211         was visited before or not).
1212
1213         Call ewk_history_clear to make sure the visited links list does not
1214         persist between tests.
1215
1216         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1217         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1218
1219 2011-10-18  Dimitri Glazkov  <dglazkov@chromium.org>
1220
1221         Split TestExpectationsEditor into its own file.
1222         https://bugs.webkit.org/show_bug.cgi?id=70348
1223
1224         Reviewed by Adam Barth.
1225
1226         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py: Copied from Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py.
1227         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py.
1228         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Adjusted for change.
1229         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Ditto.
1230         * Scripts/webkitpy/tool/servers/gardeningserver.py: Ditto.
1231
1232 2011-10-18  Ryosuke Niwa  <rniwa@webkit.org>
1233
1234         [Chromium] buildbot runs nrwt with --chromium instead of --chromium-cg-mac
1235         https://bugs.webkit.org/show_bug.cgi?id=70313
1236
1237         Reviewed by Adam Barth.
1238
1239         Fixed the bug by passing --platform --chromium-cg-mac in RunWebKitTests. We can't always add
1240         this parameter because build-webkit and other scripts don't accept it.
1241
1242         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1243
1244 2011-10-18  Adam Barth  <abarth@webkit.org>
1245
1246         Subscribe myself to WebIDL changes
1247         https://bugs.webkit.org/show_bug.cgi?id=70341
1248
1249         Reviewed by David Levin.
1250
1251         I've also added some documentation and refactored my previous
1252         subscriptions to make it eaiser for others to subscribe as well.
1253
1254         * Scripts/webkitpy/common/config/watchlist:
1255
1256 2011-10-18  Dimitri Glazkov  <dglazkov@chromium.org>
1257
1258         Add myself to the newfangled watchlist plumbing.
1259         https://bugs.webkit.org/show_bug.cgi?id=70338
1260
1261         Reviewed by David Levin.
1262
1263         * Scripts/webkitpy/common/config/watchlist: Added sheepishly.
1264
1265 2011-10-18  Dimitri Glazkov  <dglazkov@chromium.org>
1266
1267         Fix a unit test in TestFailures.
1268         https://bugs.webkit.org/show_bug.cgi?id=70337
1269
1270         Reviewed by Adam Barth.
1271
1272         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm_unittests.js: Turns out,
1273             the value of a method property should always be lowercase.
1274
1275 2011-10-18  Adam Barth  <abarth@webkit.org>
1276
1277         Always enable ENABLE(XPATH)
1278         https://bugs.webkit.org/show_bug.cgi?id=70217
1279
1280         Reviewed by Eric Seidel.
1281
1282         * Scripts/build-webkit:
1283
1284 2011-10-18  Dimitri Glazkov  <dglazkov@chromium.org>
1285
1286         garden-o-matic should not report flaking in expected failures as failures.
1287         https://bugs.webkit.org/show_bug.cgi?id=70279
1288
1289         Reviewed by Adam Barth.
1290
1291         On the bots, flakes that are already expected to fail aren't reported as failures (they keep the bot green).
1292         For example, if TEXT failure is expected, a TEXT TIMEOUT result will not cause the redness. We should do the
1293         same for garden-o-matic.
1294
1295         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: Spuriously changed to use Array iterators rather than jQuery APIs,
1296             rewrote the logic for determining expected or unexpected failures as a central analysis tool.
1297         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js: Added unit tests.
1298
1299 2011-10-18  Zan Dobersek  <zandobersek@gmail.com>
1300
1301         [Gtk] Support for client-based geolocation
1302         https://bugs.webkit.org/show_bug.cgi?id=64970
1303
1304         Reviewed by Martin Robinson.
1305
1306         Add support for testing client-based geolocation tests in DumpRenderTree.
1307
1308         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1309         (resetDefaultsToConsistentValues): Reset GeolocationClientMock.
1310         (createWebView): Create web view after declaring DumpRenderTree mode.
1311         That way a mock client for geolocation is used instead of a GeoClue
1312         client if a web view is created when testing.
1313         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Implement functions for
1314         geolocation layout tests.
1315         (LayoutTestController::setMockGeolocationPosition):
1316         (LayoutTestController::setMockGeolocationError):
1317         (LayoutTestController::setGeolocationPermission):
1318         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1319         * Scripts/build-webkit: Note that the Gtk port is using client-based
1320         geolocation, even though changing this flag has no effect on compilation.
1321
1322 2011-10-07  Andrey Kosyakov  <caseq@chromium.org>
1323
1324         [Chromium] suppress console output from DevTools window
1325         https://bugs.webkit.org/show_bug.cgi?id=69632
1326
1327         Reviewed by Pavel Feldman.
1328
1329         * DumpRenderTree/chromium/TestShell.cpp:
1330         (TestShell::showDevTools):
1331         * DumpRenderTree/chromium/WebViewHost.cpp:
1332         (WebViewHost::didAddMessageToConsole):
1333         (WebViewHost::reset):
1334         (WebViewHost::setLogConsoleOutput):
1335         * DumpRenderTree/chromium/WebViewHost.h:
1336
1337 2011-10-18  Sheriff Bot  <webkit.review.bot@gmail.com>
1338
1339         Unreviewed, rolling out r97735.
1340         http://trac.webkit.org/changeset/97735
1341         https://bugs.webkit.org/show_bug.cgi?id=70317
1342
1343         some people apparently use build-jsc with the qt port without
1344         building webkit first (Requested by torarne on #webkit).
1345
1346         * Scripts/build-webkit:
1347         * Scripts/webkitdirs.pm:
1348         (buildQMakeProject):
1349         (buildQMakeQtProject):
1350
1351 2011-10-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1352
1353         [Qt] Remove dead code in build-webkit
1354
1355         build-webkit will iterate over a list of subdirectories to build,
1356         but this feature is only used by the Apple ports. For QtWebKit we
1357         always pass an empty directory to buildQMakeProject, which makes
1358         the logic for dealing with sub-projects in buildQMakeProject just
1359         added noise.
1360
1361         If we do want this feature at some point, we should redo it in
1362         the context of the upcoming build system changes for Qt.
1363
1364         Reviewed by Simon Hausmann.
1365
1366         * Scripts/build-webkit:
1367         * Scripts/webkitdirs.pm:
1368         (buildQt):
1369
1370 2011-10-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1371
1372         Remove traces of Symbian support from the build scripts
1373
1374         Reviewed by Simon Hausmann.
1375
1376         * Scripts/build-webkit:
1377         * Scripts/webkitdirs.pm:
1378         (determineBaseProductDir):
1379         (argumentsForConfiguration):
1380         (usesPerConfigurationBuildDirectory):
1381         (buildQMakeProject):
1382
1383 2011-10-18  Ryosuke Niwa  <rniwa@webkit.org>
1384
1385         Build fix after r97672.
1386
1387         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1388
1389 2011-10-17  Kent Tamura  <tkent@chromium.org>
1390
1391         A follow-up of r97716.
1392         https://bugs.webkit.org/show_bug.cgi?id=68803
1393
1394         * DumpRenderTree/chromium/LayoutTestController.cpp:
1395         (LayoutTestController::reset): Initialize m_dumpCreateView.
1396
1397 2011-10-17  Jochen Eisinger  <jochen@chromium.org>
1398
1399         [chromium] add LayoutTestController.dumpCreateView() to monitor calls to WebViewClient::createView
1400         https://bugs.webkit.org/show_bug.cgi?id=68803
1401
1402         Reviewed by Nate Chapin.
1403
1404         * DumpRenderTree/chromium/LayoutTestController.cpp:
1405         (LayoutTestController::LayoutTestController):
1406         (LayoutTestController::dumpCreateView):
1407         * DumpRenderTree/chromium/LayoutTestController.h:
1408         (LayoutTestController::shouldDumpCreateView):
1409         * DumpRenderTree/chromium/WebViewHost.cpp:
1410         (WebViewHost::createView):
1411
1412 2011-10-17  Nate Chapin  <japhet@chromium.org>
1413
1414         Add myself to watchlists, and add a watch
1415         for Source/WebCore/loader/.
1416         https://bugs.webkit.org/show_bug.cgi?id=70263
1417
1418         Reviewed by David Levin.
1419
1420         * Scripts/webkitpy/common/config/watchlist:
1421
1422 2011-10-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
1423
1424         [EFL] DRT: Make non-recognized keys work in events as well.
1425         https://bugs.webkit.org/show_bug.cgi?id=69860
1426
1427         Reviewed by Antonio Gomes.
1428
1429         fast/forms/select-type-ahead-non-latin.html is the canonical case we fix
1430         here: it has a select box with a few non-latin options, and one of them
1431         is selected via the keyboard.
1432
1433         In this specific case, we need to make EventHandler::keyEvent send a
1434         keyPressEvent to SelectElement, so that
1435         SelectElement::defaultEventHandler calls typeAheadFind(). This happens
1436         only when PlatformKeyEvent::text() is not empty, which was not the case
1437         so far.
1438
1439         * DumpRenderTree/efl/EventSender.cpp:
1440         (keyDownCallback):
1441
1442 2011-10-17  Alok Priyadarshi  <alokp@chromium.org>
1443
1444         Add layout tests for WebPlugin compositor path
1445         https://bugs.webkit.org/show_bug.cgi?id=69027
1446
1447         Reviewed by James Robinson.
1448
1449         * DumpRenderTree/DumpRenderTree.gypi:
1450         * DumpRenderTree/chromium/TestWebPlugin.cpp: Added.
1451         (premultiplyAlpha):
1452         (TestWebPlugin::TestWebPlugin):
1453         (TestWebPlugin::~TestWebPlugin):
1454         (TestWebPlugin::mimeType):
1455         (TestWebPlugin::initialize):
1456         (TestWebPlugin::destroy):
1457         (TestWebPlugin::updateGeometry):
1458         (TestWebPlugin::parsePrimitive):
1459         (TestWebPlugin::parseColor):
1460         (TestWebPlugin::parseOpacity):
1461         (TestWebPlugin::initScene):
1462         (TestWebPlugin::drawScene):
1463         (TestWebPlugin::destroyScene):
1464         (TestWebPlugin::initProgram):
1465         (TestWebPlugin::initPrimitive):
1466         (TestWebPlugin::drawPrimitive):
1467         (TestWebPlugin::loadShader):
1468         (TestWebPlugin::loadProgram):
1469         * DumpRenderTree/chromium/TestWebPlugin.h: Added.
1470         (TestWebPlugin::scriptableObject):
1471         (TestWebPlugin::paint):
1472         (TestWebPlugin::updateFocus):
1473         (TestWebPlugin::updateVisibility):
1474         (TestWebPlugin::acceptsInputEvents):
1475         (TestWebPlugin::handleInputEvent):
1476         (TestWebPlugin::didReceiveResponse):
1477         (TestWebPlugin::didReceiveData):
1478         (TestWebPlugin::didFinishLoading):
1479         (TestWebPlugin::didFailLoading):
1480         (TestWebPlugin::didFinishLoadingFrameRequest):
1481         (TestWebPlugin::didFailLoadingFrameRequest):
1482         (TestWebPlugin::Scene::Scene):
1483         * DumpRenderTree/chromium/WebViewHost.cpp:
1484         (WebViewHost::createPlugin):
1485
1486 2011-10-17  Ryosuke Niwa  <rniwa@webkit.org>
1487
1488         [nrwt] Add new category for MISSING
1489         https://bugs.webkit.org/show_bug.cgi?id=69990
1490
1491         Reviewed by Dirk Pranke.
1492
1493         Treat missing results as a new category in summerize_results.
1494
1495         Because Chromium port wants to turn bots red when there are tests with missing results,
1496         extracted the logic to compute the exit code as exit_code_from_summarized_results in
1497         base and chromium ports.
1498
1499         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1500         * Scripts/webkitpy/layout_tests/port/base.py:
1501         * Scripts/webkitpy/layout_tests/port/chromium.py:
1502         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1503
1504 2011-10-17  Dimitri Glazkov  <dglazkov@chromium.org>
1505
1506         garden-o-matic operations fail because of CSP.
1507         https://bugs.webkit.org/show_bug.cgi?id=70249
1508
1509         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Added gardening server to the policy.
1510
1511 2011-10-17  Ada Chan  <adachan@apple.com>
1512
1513         Add a test to call WKPageLoadAlternateHTMLString() with a non-directory URL.
1514         https://bugs.webkit.org/show_bug.cgi?id=70168
1515
1516         Reviewed by Alexey Proskuryakov.
1517
1518         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp: Added.
1519         (TestWebKitAPI::didFinishLoadForFrame):
1520         (TestWebKitAPI::TEST): Call WKPageLoadAlternateHTMLString() with a file URL and make sure it finishes loading.
1521
1522         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1523         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1524         Add the new file.
1525
1526 2011-10-17  Darin Adler  <darin@apple.com>
1527
1528         Add some more *.pyc ignores in directories with Python scripts.
1529
1530         * QueueStatusServer: Added property svn:ignore.
1531         * Scripts/webkitpy/common/watchlist: Added property svn:ignore.
1532         * Scripts/webkitpy/layout_tests/controllers: Added property svn:ignore.
1533         * Scripts/webkitpy/layout_tests/views: Added property svn:ignore.
1534
1535 2011-10-17  Alexis Menard  <alexis.menard@openbossa.org>
1536
1537         [Qt][WK2][meta] Fix failing API tests
1538         https://bugs.webkit.org/show_bug.cgi?id=70236
1539
1540         Reviewed by Csaba Osztrogonác.
1541
1542         In order to run WebKit2 API tests we need the WebProcess to be in
1543         the path so let's add the bin directory when running the API tests of Qt.
1544
1545         * Scripts/run-qtwebkit-tests:
1546
1547 2011-10-17  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1548
1549         [Qt][WK2] Build dependency problems
1550         https://bugs.webkit.org/show_bug.cgi?id=68456
1551
1552         Reviewed by Csaba Osztrogonác.
1553
1554         * Scripts/webkitdirs.pm:
1555         (buildQMakeProject):
1556
1557 2011-10-17  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
1558
1559         [build] Introduce Qt/SH4 buildbot
1560         https://bugs.webkit.org/show_bug.cgi?id=70227
1561
1562         Reviewed by Adam Roben.
1563
1564         Add buildslave for Linux/Qt/SH4.
1565
1566         * BuildSlaveSupport/build.webkit.org-config/config.json:
1567
1568 2011-10-16  Adam Barth  <abarth@webkit.org>
1569
1570         Always enable ENABLE(DOM_STORAGE)
1571         https://bugs.webkit.org/show_bug.cgi?id=70189
1572
1573         Reviewed by Eric Seidel.
1574
1575         * Scripts/build-webkit:
1576         * waf/build/settings.py:
1577
1578 2011-10-15  Adam Barth  <abarth@webkit.org>
1579
1580         Rename ENABLE(TILED_BACKING_STORE) to USE(TILED_BACKING_STORE)
1581         https://bugs.webkit.org/show_bug.cgi?id=70194
1582
1583         Reviewed by Daniel Bates.
1584
1585         * Scripts/build-webkit:
1586
1587 2011-10-15  Ojan Vafai  <ojan@chromium.org>
1588
1589         run-webkit-tests should accept --child-processes
1590         https://bugs.webkit.org/show_bug.cgi?id=69713
1591
1592         Reviewed by Adam Barth.
1593
1594         Only set --child-processes=1 if --child-processes it not
1595         passed on the commandline.
1596
1597         * Scripts/run-webkit-tests:
1598
1599 2011-10-15  Daniel Bates  <dbates@webkit.org>
1600
1601         Extract common gdb code into its own function; Remove script gdb-safari
1602         https://bugs.webkit.org/show_bug.cgi?id=68499
1603
1604         Reviewed by David Kilzer.
1605
1606         Almost identical code is used in webkitdirs::{debugMiniBrowser, debugWebKitTestRunner,
1607         runSafari}() and in the script gdb-safari to launch gdb to debug an application.
1608         We should extract the common parts into a function that can be shared by all callers
1609         so as to remove duplicate code.
1610
1611         As a side effect of removing duplicate code we can remove the script gdb-safari since
1612         its code has been incorporated into webkitdirs::debugSafari() which is called by the
1613         script debug-safari.
1614
1615         * Scripts/debug-safari: Modified to call webkitdirs::debugSafari().
1616         * Scripts/gdb-safari: Removed.
1617         * Scripts/webkitdirs.pm:
1618         (execMacWebKitAppForDebugging): Added; Extracted common debugging code from
1619         debugMiniBrowser(), debugWebKitTestRunner(), runSafari() and
1620         script gdb-safari to here.
1621         (debugSafari): Added.
1622         (runSafari): Extracted debugging code to debugSafari() and debugMacWebKitApp();
1623         Also, return the exit status of WebKit launcher (WebKit.exe) on Windows. Currently,
1624         runSafari() always returns 1 on Windows and the script run-safari exits using this
1625         value as its exit status. Hence, the script run-safari always exits with a nonzero
1626         exit status (i.e. abnormal termination) on Windows. Instead, we should return the
1627         exit status of the WebKit launcher application.
1628         (debugMiniBrowser): Modified to call debugMacWebKitApp().
1629         (debugWebKitTestRunner): Ditto.
1630
1631 2011-10-15  Robert Hogan  <robert@webkit.org>
1632
1633         [webkit-patch] Put Source/Tools changes at the top of patches, LayoutTests at the bottom
1634         https://bugs.webkit.org/show_bug.cgi?id=70056
1635
1636         Reviewed by Adam Barth.
1637
1638         The preferred file-order for patches is LayoutTests at the end and
1639         ChangeLogs before everything else in a subdirectory. Specify this in a git 'orderfile' and use 
1640         it when creating patches for review and landing.
1641
1642         * Scripts/webkitpy/common/checkout/scm/git.py:
1643         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1644         * Scripts/webkitpy/common/config/orderfile: Added.
1645
1646 2011-10-15  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1647
1648         [Qt] [Symbian] Remove support for the Symbian platform for the QtWebKit port
1649         https://bugs.webkit.org/show_bug.cgi?id=69920
1650
1651         Reviewed by Kenneth Rohde Christiansen.
1652
1653         * DumpRenderTree/qt/DumpRenderTree.pro:
1654         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1655         (WebCore::DumpRenderTree::open):
1656         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1657         * QtTestBrowser/QtTestBrowser.pro:
1658         * QtTestBrowser/launcherwindow.cpp:
1659         (LauncherWindow::screenshot):
1660         (LauncherWindow::showFPS):
1661         (LauncherWindow::updateFPS):
1662         * QtTestBrowser/launcherwindow.h:
1663         (WindowOptions::WindowOptions):
1664         * QtTestBrowser/mainwindow.cpp:
1665         (MainWindow::buildUI):
1666         * Scripts/webkitpy/style/checker.py: Remove rules for the
1667         WebKit/qt/symbian/platformplugin directory.
1668         * Scripts/webkitpy/style/checker_unittest.py:
1669         * Tools.pro:
1670         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1671         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
1672         (WTR::LayoutTestController::platformInitialize):
1673         * WebKitTestRunner/qt/TestControllerQt.cpp:
1674         (WTR::isExistingLibrary):
1675         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1676
1677 2011-10-15  Adam Barth  <abarth@webkit.org>
1678
1679         Fix typo in webkitpy help
1680         https://bugs.webkit.org/show_bug.cgi?id=70169
1681
1682         Reviewed by Eric Seidel.
1683
1684         * Scripts/webkitpy/tool/commands/upload.py:
1685
1686 2011-10-15  Tony Chang  <tony@chromium.org>
1687
1688         fix another typo in treemap.html
1689         https://bugs.webkit.org/show_bug.cgi?id=70149
1690
1691         Reviewed by Ojan Vafai.
1692
1693         Fixes a bug where #treemapfocus=LayoutTests%2Fhttp didn't focus the http tests.
1694
1695         * TestResultServer/static-dashboards/treemap.html:
1696
1697 2011-10-14  Adam Barth  <abarth@webkit.org>
1698
1699         Hide status bubbles from queues which are very far behind
1700         https://bugs.webkit.org/show_bug.cgi?id=70133
1701
1702         Reviewed by Eric Seidel.
1703
1704         The mac-ews is so far behind that we shouldn't show its status bubble.
1705         The status bubble just makes contributors sad.
1706
1707         * QueueStatusServer/handlers/statusbubble.py:
1708
1709 2011-10-14  Dimitri Glazkov  <dglazkov@chromium.org>
1710
1711         Write unit test to ensure style-checker-filter option is passed properly in webkit-patch
1712         https://bugs.webkit.org/show_bug.cgi?id=70143
1713
1714         Reviewed by Adam Barth.
1715
1716         * Scripts/webkitpy/tool/commands/download_unittest.py: Added a test for land-cowboy. Not so cowboy after all.
1717         * Scripts/webkitpy/tool/steps/checkstyle.py: Fixed a bug, discovered by the newly added test.
1718
1719 2011-10-14  David Levin  <levin@chromium.org>
1720
1721         watchlist: Add a validation check for the email names in the list.
1722         https://bugs.webkit.org/show_bug.cgi?id=70154
1723
1724         Reviewed by Adam Barth.
1725
1726         If an email is listed which doesn't have a bugzilla log in, then any emails
1727         added to the bug along with that email will fail to happen, so try to prevent this
1728         from happening by validating that emails added to the watchlist are known to be
1729         contributors.
1730
1731         * Scripts/webkitpy/common/config/committers.py: Add my other email aliases for bugzilla.
1732         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Add the check.
1733         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: A unit test for the check.
1734
1735 2011-10-14  David Levin  <levin@chromium.org>
1736
1737         watchlist: If the style check fails, then the watchlist will not be run.
1738         https://bugs.webkit.org/show_bug.cgi?id=69484
1739
1740         Reviewed by Adam Barth.
1741
1742         * Scripts/webkitpy/tool/commands/queues.py: Run the watch list even
1743         if the style part fails and don't allow watch list failures turn the
1744         bot run red.
1745         * Scripts/webkitpy/tool/commands/queues_unittest.py: Appropriate unit tests.
1746         * Scripts/webkitpy/tool/mocktool.py: Add support to make an executive command throw.
1747
1748 2011-10-14  Dimitri Glazkov  <dglazkov@chromium.org>
1749
1750         Plumb style-checker filter up to command options and make land-cowboy use it.
1751         https://bugs.webkit.org/show_bug.cgi?id=70119
1752
1753         Reviewed by Adam Barth.
1754
1755         * Scripts/webkitpy/style/checker.py: Added ChangeLogChecker categories to the big list.
1756         * Scripts/webkitpy/style/checkers/changelog.py: Declared categories, used in ChangeLogChecker.
1757         * Scripts/webkitpy/tool/commands/download.py: Made LandCowboy use filter.
1758         * Scripts/webkitpy/tool/commands/download_unittest.py: Tweaked the test.
1759         * Scripts/webkitpy/tool/commands/upload_unittest.py: Ditto.
1760         * Scripts/webkitpy/tool/steps/checkstyle.py: Made check_style_filter work.
1761         * Scripts/webkitpy/tool/steps/options.py: Added new option, check-style-filter.
1762
1763 2011-10-14  Sam Weinig  <sam@webkit.org>
1764
1765         Remove the Leopard slaves.
1766
1767         Reviewed by Adam Roben.
1768
1769         * BuildSlaveSupport/build.webkit.org-config/config.json:
1770
1771 2011-10-14  Peter Beverloo  <peter@chromium.org>
1772
1773         [Chromium] Inherit settings from Chromium's envsetup.sh, address a NDK todo
1774         https://bugs.webkit.org/show_bug.cgi?id=70028
1775
1776         Reviewed by Adam Barth.
1777
1778         * Scripts/update-webkit-chromium:
1779         * Scripts/webkitdirs.pm:
1780         (buildChromiumMakefile):
1781         (buildChromium):
1782
1783 2011-10-14  Leandro Pereira  <leandro@profusion.mobi>
1784
1785         Unreviewed; add missing #includes.
1786
1787         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1788         * DumpRenderTree/efl/EventSender.cpp:
1789
1790 2011-10-14  Raphael Kubo da Costa  <kubo@profusion.mobi>
1791
1792         [EFL] Correctly get the absolute URL in LayoutTestController::queueLoad()
1793         https://bugs.webkit.org/show_bug.cgi?id=69770
1794
1795         Reviewed by Antonio Gomes.
1796
1797         We were just appending the given URL to the absolute URI of the main
1798         frame, which resulted in "file:///foo/bar/baz.htmltheother/url.html"
1799         instead of "file:///foo/bar/theother/url.html".
1800
1801         This should make fast/dom/navigation-type-navigate.html behave
1802         better (it still fails, but later).
1803
1804         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1805         (LayoutTestController::queueLoad):
1806
1807 2011-10-13  Arko Saha  <arko@motorola.com>
1808
1809         Microdata: Basic implementation of document.getItems() method.
1810         https://bugs.webkit.org/show_bug.cgi?id=68610
1811
1812         Reviewed by Ryosuke Niwa.
1813
1814         Added ENABLE(MICRODATA) feature flag. Implement document.getItems() DOM API.
1815         Spec : http://www.whatwg.org/specs/web-apps/current-work/complete/microdata.html
1816
1817         * Scripts/build-webkit:
1818
1819 2011-10-14  Csaba Osztrogonác  <ossy@webkit.org>
1820
1821         new-run-webkit-tests does not support qt-4.8 results
1822         https://bugs.webkit.org/show_bug.cgi?id=64071
1823
1824         Roll-back second part of r97252. :)
1825
1826         * Scripts/webkitpy/layout_tests/port/qt.py:
1827
1828 2011-10-14  Raphael Kubo da Costa  <kubo@profusion.mobi>
1829
1830         [EFL] DRT: Do not use OwnFastMallocPtr to manage char*'s.
1831         https://bugs.webkit.org/show_bug.cgi?id=70106
1832
1833         Reviewed by Antonio Gomes.
1834
1835         OwnFastMallocPtr was being used as a smart pointer that automatically called
1836         free() on the strings returned by the EFL or by ewk.
1837
1838         However, when WTF is built in release mode, it uses its own memory management
1839         code instead of using the system malloc(), free() and friends. This means bad
1840         things will happen when one uses WTF's free() on memory allocated with system
1841         malloc() by the EFL or ewk.
1842
1843         The easiest way to solve this is to call free() ourselves.
1844
1845         * DumpRenderTree/efl/DumpRenderTree.cpp:
1846         (dumpFramesAsText):
1847         (getFinalTestURL):
1848
1849 2011-10-14  Raphael Kubo da Costa  <kubo@profusion.mobi>
1850
1851         [EFL] Add DumpRenderTreeSupportEfl
1852         https://bugs.webkit.org/show_bug.cgi?id=68458
1853
1854         Reviewed by Kenneth Rohde Christiansen.
1855
1856         Make the calls in DumpRenderTree use DumpRenderTreeSupportEfl.
1857
1858         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1859         (DumpRenderTreeChrome::initialize): Turn on mock scrollbars.
1860         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1861         (DumpRenderTreeChrome::onWindowObjectCleared):
1862         (DumpRenderTreeChrome::onDocumentLoadFinished):
1863         * DumpRenderTree/efl/GCControllerEfl.cpp:
1864         (GCController::collect):
1865         (GCController::collectOnAlternateThread):
1866         (GCController::getJSObjectCount):
1867         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1868         (LayoutTestController::counterValueForElementById):
1869         (LayoutTestController::pageNumberForElementById):
1870         (LayoutTestController::numberOfPages):
1871         (LayoutTestController::workerThreadCount):
1872         (LayoutTestController::findString):
1873         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
1874         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
1875         (LayoutTestController::sampleSVGAnimationForElementAtTime):
1876         (LayoutTestController::numberOfActiveAnimations):
1877         (LayoutTestController::suspendAnimations):
1878         (LayoutTestController::resumeAnimations):
1879         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
1880         (createBitmapContextFromWebView):
1881
1882 2011-10-14  Csaba Osztrogonác  <ossy@webkit.org>
1883
1884         [Qt] Enable NRWT for Qt 4.8 version too, because it is supported after r97461.
1885
1886         Unreviewed.
1887
1888         * Scripts/run-webkit-tests:
1889         (useNewRunWebKitTests):
1890
1891 2011-10-14  Csaba Osztrogonác  <ossy@webkit.org>
1892
1893         new-run-webkit-tests does not support qt-4.8 results
1894         https://bugs.webkit.org/show_bug.cgi?id=64071
1895
1896         Roll-back r97252 with unit test fix.
1897
1898         Reviewed by Csaba Osztrogonác.
1899
1900         * Scripts/webkitpy/layout_tests/port/qt.py:
1901         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1902
1903 2011-10-13  Ojan Vafai  <ojan@chromium.org>
1904
1905         Make filter-build-webkit exit 1 if the build fails.
1906         https://bugs.webkit.org/show_bug.cgi?id=70080
1907
1908         Reviewed by Eric Seidel.
1909
1910         This only works if you redirect stderr to stdout, but it at least makes it possible.
1911         This is useful if you want to run a followup command (e.g. run-webkit-tests) but
1912         only if the build succeeds.
1913
1914         * Scripts/filter-build-webkit:
1915
1916 2011-10-13  Dimitri Glazkov  <dglazkov@chromium.org>
1917
1918         land-cowboy should at least check style.
1919         https://bugs.webkit.org/show_bug.cgi?id=70073
1920
1921         Reviewed by Adam Barth.
1922
1923         * Scripts/webkitpy/tool/commands/download.py: Added CheckStyle step to LandCowboy command.
1924
1925 2011-10-13  Tony Chang  <tony@chromium.org>
1926
1927         fix regex in layout test times dashboard
1928         https://bugs.webkit.org/show_bug.cgi?id=70059
1929
1930         This fixes the treemapfocus query param.
1931
1932         Reviewed by Ojan Vafai.
1933
1934         * TestResultServer/static-dashboards/treemap.html:
1935
1936 2011-10-13  Beth Dakin  <bdakin@apple.com>
1937
1938         https://bugs.webkit.org/show_bug.cgi?id=70050
1939         DRT and WRT should have HiDPI testing capabilities
1940
1941         Reviewed by Darin Adler.
1942
1943         New layoutTestController function setBackingScaleFactor takes a double for a scale 
1944         factor and a callback function to call once the backing scale factor has 
1945         successfully been set for the view.
1946         * DumpRenderTree/LayoutTestController.cpp:
1947         (setBackingScaleFactorCallback):
1948         (LayoutTestController::staticFunctions):
1949
1950         On Mac, setBackingScaleFactor calls WebView _setCustomBackingScaleFactor. Other 
1951         platforms do nothing.
1952         * DumpRenderTree/LayoutTestController.h:
1953         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1954         (LayoutTestController::setBackingScaleFactor):
1955         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1956         (LayoutTestController::setBackingScaleFactor):
1957         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1958         (LayoutTestController::setBackingScaleFactor):
1959
1960         Reset the backing scale factor by calling _setCutsomBackingScaleFactor with a 
1961         value of 0, which resets to the system default.
1962         * DumpRenderTree/mac/DumpRenderTree.mm:
1963         (resetWebViewToConsistentStateBeforeTesting):
1964
1965         When generating the pixel dump, create a Bitmap of the appropriate size based on 
1966         the backing scale factor. If it is a HiDPI view, paint into the context using 
1967         displayRectIgnoringOpacity.
1968         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1969         (createBitmapContextFromWebView):
1970
1971         And now the same stuff for WK2. Again, new layoutTestController function 
1972         setBackingScaleFactor takes a double for a scale factor and a callback function. 
1973         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1974         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1975         (WTR::LayoutTestController::setBackingScaleFactor):
1976         (WTR::LayoutTestController::callSetBackingScaleFactorCallback):
1977         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1978
1979         The InjectedBundle sends a message to the UI process to set the backing scale 
1980         factor. It also processes a message the UI process will send back once it 
1981         completes this task, and at that time, the InjectedBundle calls the callback.
1982         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1983         (WTR::InjectedBundle::didReceiveMessage):
1984         (WTR::InjectedBundle::postSetBackingScaleFactor):
1985         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1986
1987         Again, reset the backing scale factor by calling WKPageSetCustomBackingScaleFactor 
1988         with a value of 0, which resets to the system default.
1989         * WebKitTestRunner/TestController.cpp:
1990         (WTR::TestController::resetStateToConsistentValues):
1991
1992         Upon receiving the SetBackingScaleFactor message, call 
1993         WKPageSetCustomBackingScaleFactor to the given scale factor, and post a message 
1994         back to InjectedBundle to say it has been done.
1995         * WebKitTestRunner/TestInvocation.cpp:
1996         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1997         
1998         Don't use window snapshotting for the HiDPI tests. We don't have a way to fake a 
1999         window's scale factor so we have to avoid that.
2000         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2001         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2002
2003 2011-10-13  John Knottenbelt  <jknotten@chromium.org>
2004
2005         [Chromium] Allow building without speech input enabled.
2006         https://bugs.webkit.org/show_bug.cgi?id=69867
2007
2008         Reviewed by Darin Fisher.
2009
2010         * DumpRenderTree/chromium/LayoutTestController.cpp:
2011         (LayoutTestController::addMockSpeechInputResult):
2012
2013 2011-10-13  Kent Tamura  <tkent@chromium.org>
2014
2015         [Chromium] A DRT fix for r97348.
2016
2017         * DumpRenderTree/chromium/LayoutTestController.cpp:
2018         (LayoutTestController::overridePreference):
2019         Ignore overridePreference() for "WebKitWebAudioEnabled", and don't
2020         print an error message.
2021
2022 2011-10-12  Lucas Forschler  <lforschler@apple.com>
2023
2024         Update kill-old-processes logic.
2025         https://bugs.webkit.org/show_bug.cgi?id=63651
2026
2027         Reviewed by Ryosuke Niwa.
2028
2029         Remove unused mac platform specific folder.
2030         Update master.config to use new kill-old-processes.
2031
2032         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2033         * BuildSlaveSupport/kill-old-processes:
2034         * BuildSlaveSupport/mac: Removed.
2035
2036 2011-10-12  Ryosuke Niwa  <rniwa@webkit.org>
2037
2038         [NRWT] New tests without expected files are reported as flakey tests
2039         https://bugs.webkit.org/show_bug.cgi?id=67268
2040
2041         Reviewed by Dirk Pranke.
2042
2043         The bug was caused by summarize_results's regarding all tests that have an entry in result_summary
2044         and no entry in retry_summary as flaky. Since we don't retry missing tests, there will be no entries
2045         for missing results in retry_summary.
2046
2047         Fixed the bug by treating missing results separately.
2048
2049         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2050         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2051
2052 2011-10-12  Adam Barth  <abarth@webkit.org>
2053
2054         Remove ENABLE(XHTMLMP) and associated code
2055         https://bugs.webkit.org/show_bug.cgi?id=69729
2056
2057         Reviewed by David Levin.
2058
2059         * Scripts/build-webkit:
2060         * Scripts/old-run-webkit-tests:
2061         * Scripts/webkitperl/features.pm:
2062         * Scripts/webkitpy/layout_tests/port/webkit.py:
2063         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2064
2065 2011-10-12  Ryosuke Niwa  <rniwa@webkit.org>
2066
2067         Kill old run-webkit-tests processes in kill-process on Mac
2068         https://bugs.webkit.org/show_bug.cgi?id=69976
2069
2070         Reviewed by Dirk Pranke.
2071
2072         Add a system call to remove all python processes running run-webkit-tests.
2073
2074         * BuildSlaveSupport/kill-old-processes:
2075         * BuildSlaveSupport/mac: Removed.
2076
2077 2011-10-12  Simon Fraser  <simon.fraser@apple.com>
2078
2079         Many WK2 snapshots are blank
2080         https://bugs.webkit.org/show_bug.cgi?id=69953
2081
2082         Reviewed by Beth Dakin.
2083         
2084         Two fixes:
2085         1. negating a size_t in CGContextTranslateCTM() fails, because
2086         size_t is unsigned. Fix by casing to CGFloat before negation.
2087         
2088         2. Turn on window autodisplay, so that compositing tests snapshot correctly.
2089         Autodisplay is necessary to kick off Core Animation rendering.
2090
2091         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2092         (WTR::createCGContextFromImage):
2093         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2094         (WTR::PlatformWebView::PlatformWebView):
2095
2096 2011-10-12  Adam Barth  <abarth@webkit.org>
2097
2098         commit-queue doesn't have a friendly error message when the reviewer line is messed up
2099         https://bugs.webkit.org/show_bug.cgi?id=69979
2100
2101         Reviewed by Eric Seidel.
2102
2103         Rather than combining the ChangeLog validation with a more complicated
2104         command, this patch has the commit-queue run it as a separate command,
2105         which will give us more control over the error message.
2106
2107         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2108         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2109         * Scripts/webkitpy/tool/commands/download.py:
2110         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2111         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
2112         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2113
2114 2011-10-12  Eric Seidel  <eric@webkit.org>
2115
2116         Layout tests asserting in LayoutTestController::pathToLocalResource()
2117         https://bugs.webkit.org/show_bug.cgi?id=69898
2118
2119         Reviewed by Simon Fraser.
2120
2121         old-run-webkit-tests just didn't know to set LOCAL_RESOURCE_ROOT, oops.
2122
2123         * Scripts/old-run-webkit-tests:
2124         (openDumpTool):
2125
2126 2011-10-12  Adam Barth  <abarth@webkit.org>
2127
2128         The commit-queue doesn't tell me which tests my patch broke
2129         https://bugs.webkit.org/show_bug.cgi?id=69975
2130
2131         Reviewed by Eric Seidel.
2132
2133         We now print the list of newly failing tests, like we do for the EWS.
2134
2135         * Scripts/webkitpy/tool/commands/queues.py:
2136         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2137
2138 2011-10-10  Alice Boxhall  <aboxhall@chromium.org>
2139
2140         Added myself as a committer.
2141
2142         * Scripts/webkitpy/common/config/committers.py:
2143
2144 2011-10-12  Adam Barth  <abarth@webkit.org>
2145
2146         _run_tests is a confusing variable name in webkitpy
2147         https://bugs.webkit.org/show_bug.cgi?id=69971
2148
2149         Reviewed by Eric Seidel.
2150
2151         Eric and I thought this was a function.
2152
2153         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
2154
2155 2011-10-12  Tony Chang  <tony@chromium.org>
2156
2157         Fix test-webkitpy after r97307 and r97293.
2158
2159         * Scripts/webkitpy/layout_tests/port/chromium.py: options.time_out_ms
2160           is None during tests so add back the check.
2161         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: The
2162           output directory is now build/Debug.
2163
2164 2011-10-12  Tony Chang  <tony@chromium.org>
2165
2166         [chromium] remove old build dirs on chromium-win
2167         https://bugs.webkit.org/show_bug.cgi?id=69961
2168
2169         Reviewed by Adam Barth.
2170
2171         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Output is now
2172           always in build and never in chrome or webkit.
2173
2174 2011-10-12  Dimitri Glazkov  <dglazkov@chromium.org>
2175
2176         garden-o-matic's "Expect Failure" button does not work correctly, so we should remove it until the plumbing is fixed to avoid landmines.
2177         https://bugs.webkit.org/show_bug.cgi?id=69954
2178
2179         Also renamed the action and associated event name to address an FIXME.
2180
2181         Reviewed by Adam Barth.
2182
2183         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Renamed event name.
2184         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js: Renamed the action.
2185         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Removed action temporarily.
2186
2187 2011-10-12  Tony Chang  <tony@chromium.org>
2188
2189         stop spamming 'stopping test driver timed out, killing it' when running rwt
2190         https://bugs.webkit.org/show_bug.cgi?id=69938
2191
2192         Reviewed by Adam Barth.
2193
2194         In http://trac.webkit.org/changeset/95875 , we made the timeout for
2195         stopping the driver based on time_out_ms, but we based it on the wrong
2196         default times.
2197
2198         * Scripts/webkitpy/layout_tests/port/chromium.py:
2199
2200 2011-10-12  Simon Fraser  <simon.fraser@apple.com>
2201
2202         3D transforms are flattened in WebKit2 snapshots
2203         https://bugs.webkit.org/show_bug.cgi?id=68276
2204
2205         Reviewed by Adam Roben.
2206         
2207         Fix WKImage leak noticed by Adam.
2208
2209         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2210         (WTR::PlatformWebView::windowSnapshotImage):
2211
2212 2011-10-12  Dimitri Glazkov  <dglazkov@chromium.org>
2213
2214         garden-o-matic should color-code test failure types.
2215         https://bugs.webkit.org/show_bug.cgi?id=69945
2216
2217         Reviewed by Adam Barth.
2218
2219         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Added an extra span for styling.
2220         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Updated tests.
2221         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Ditto.
2222         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added color-coding.
2223
2224 2011-10-12  Adam Barth  <abarth@webkit.org>
2225
2226         webkitpy tests are failing on Mac bots
2227         https://bugs.webkit.org/show_bug.cgi?id=69929
2228
2229         Reviewed by Simon Fraser.
2230
2231         Admit that Lion exists.
2232
2233         * Scripts/webkitpy/layout_tests/port/chromium.py:
2234         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2235
2236 2011-10-12  Simon Fraser  <simon.fraser@apple.com>
2237
2238         Improve output of run-api-tests to make time-outs more obvious
2239         https://bugs.webkit.org/show_bug.cgi?id=69788
2240
2241         Reviewed by Adam Roben.
2242         
2243         List the tests that failed and timed out at the bottom of the output,
2244         if run with --verbose.
2245
2246         * Scripts/run-api-tests:
2247         (runAllTests):
2248         (runTest):
2249
2250 2011-10-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2251
2252         Unreviewed, rolling out r97252.
2253         http://trac.webkit.org/changeset/97252
2254         https://bugs.webkit.org/show_bug.cgi?id=69944
2255
2256         Broke test-webkpy (Requested by abarth on #webkit).
2257
2258         * Scripts/webkitpy/layout_tests/port/qt.py:
2259         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2260
2261 2011-10-12  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2262
2263         new-run-webkit-tests does not support qt-4.8 results
2264         https://bugs.webkit.org/show_bug.cgi?id=64071
2265
2266         Reviewed by Csaba Osztrogonác.
2267
2268         * Scripts/webkitpy/layout_tests/port/qt.py:
2269         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2270
2271 2011-10-10  Martin Robinson  <mrobinson@igalia.com>
2272
2273         [GTK] [WebKit2] Make adding another unit test easier
2274         https://bugs.webkit.org/show_bug.cgi?id=69409
2275
2276         Reviewed by Gustavo Noronha Silva.
2277
2278         * Scripts/run-gtk-tests: Update run-gtk-tests to be able to execute
2279         new WebKit2 tests.
2280
2281 2011-10-11  Takashi Toyoshima  <toyoshim@chromium.org>
2282
2283         [WebSocket] update pywebsocket to 0.6b6.
2284         https://bugs.webkit.org/show_bug.cgi?id=69824
2285
2286         Reviewed by Kent Tamura.
2287
2288         WebKit supports WebSocket with version 8 based protocol for now.
2289         We should update its protocol to version 13 based one like hybi-17.
2290         pywebsocket 0.6b6 supports both of version 8 and 13.
2291
2292         * Scripts/webkitpy/thirdparty/__init__.py:
2293
2294 2011-10-11  Simon Fraser  <simon.fraser@apple.com>
2295
2296         WebKitTestRunner needs to link with WebKit for NSURL category methods
2297         https://bugs.webkit.org/show_bug.cgi?id=69892
2298
2299         Reviewed by Sam Weinig.
2300         
2301         WebDragClient::declareAndWriteDragImage() was throwing an Obj-C exception on 10.6 because
2302         the +_web_originalDataAsString selector on NSURL was not recognized. Link with
2303         WebKit.framework to fix this.
2304
2305         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2306
2307 2011-10-11  Adam Barth  <abarth@webkit.org>
2308
2309         sheriffbot takes too long to acknowledge rollout commands
2310         https://bugs.webkit.org/show_bug.cgi?id=69871
2311
2312         Reviewed by Eric Seidel.
2313
2314         We used to update the working copy before acknowledging the command
2315         because we wanted to ping all the relevant IRC nicks.  That's caused a
2316         bunch of frustration because folks don't know whether the bot has heard
2317         their commands.
2318
2319         This patch makes the bot reply immediately before updating the working
2320         copy.  All the relevenat folks are still pinged when the bot finishes
2321         preparing the rollout.
2322
2323         * Scripts/webkitpy/tool/bot/irc_command.py:
2324         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2325
2326 2011-10-11  Adam Barth  <abarth@webkit.org>
2327
2328         test-webkitpy fails on Lion
2329         https://bugs.webkit.org/show_bug.cgi?id=69873
2330
2331         Reviewed by Eric Seidel.
2332
2333         This patch fixes one of the two failures.  I'll need to track down the
2334         other failure another time.
2335
2336         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2337
2338 2011-10-11  Adam Barth  <abarth@webkit.org>
2339
2340         garden-o-matic should warn me when run-webkit-tests errors out (e.g., due to python screw-ups)
2341         https://bugs.webkit.org/show_bug.cgi?id=65230
2342
2343         Reviewed by Dimitri Glazkov.
2344
2345         This patch causes us to treat crashed or hung run-webkit-tests runs
2346         similarly to how we treat compile failures.  In some sense, they're
2347         similar because they prevent us from getting test coverage.
2348
2349         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
2350         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
2351
2352 2011-10-11  Adam Barth  <abarth@webkit.org>
2353
2354         Failing builder display in garden-o-matic should have the same visual style as the failure grid
2355         https://bugs.webkit.org/show_bug.cgi?id=69876
2356
2357         Reviewed by Dimitri Glazkov.
2358
2359         This patch generalizes the view we use for failing builders in the
2360         FailureGrid so that we can use it for the list of builders that aren't
2361         compiling.
2362
2363         One downside of this patch is that it makes it harder to tell when
2364         debug builders are failing (as opposed to release builders) because
2365         that information isn't presented in this view.  A future patch will
2366         improve this aspect.
2367
2368         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2369         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
2370         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2371         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2372         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
2373         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
2374
2375 2011-10-11  Filip Pizlo  <fpizlo@apple.com>
2376
2377         Some API tests are timing out in Release
2378         https://bugs.webkit.org/show_bug.cgi?id=69787
2379
2380         Reviewed by Mark Rowe.
2381         
2382         NDEBUG must be set in release builds. Otherwise the world breaks. Also added some
2383         magic to ensure that GTest builds in release mode in clang with NDEBUG set.
2384
2385         * TestWebKitAPI/Configurations/Base.xcconfig:
2386         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2387         * TestWebKitAPI/config.h:
2388
2389 2011-10-11  Adam Barth  <abarth@webkit.org>
2390
2391         garden-o-matic links to flakiness dashboard should open in a new tab
2392         https://bugs.webkit.org/show_bug.cgi?id=69864
2393
2394         Reviewed by Dimitri Glazkov.
2395
2396         This bug was obvious in the first five minutes of using this new
2397         feature.  :)
2398
2399         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2400         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2401
2402 2011-10-11  Adam Barth  <abarth@webkit.org>
2403
2404         Tweak the Content-Security-Policy for garden-o-matic.  It turns out
2405         that * doesn't really mean "all".  I've emailed the W3C working group
2406         about changing the spec.
2407
2408         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2409
2410 2011-10-11  Adam Barth  <abarth@webkit.org>
2411
2412         garden-o-matic should link to the flakiness dashboard
2413         https://bugs.webkit.org/show_bug.cgi?id=69862
2414
2415         Reviewed by Dimitri Glazkov.
2416
2417         The flakiness dashboard has lots of great information about the failure
2418         history of each test.  This patch adds a link from garden-o-matic to
2419         the flakiness dashboard so the gardener can look at this information.
2420
2421         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2422         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2423         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2424
2425 2011-10-11  David Levin  <levin@chromium.org>
2426
2427         watchlist: assertRaisesRegexp implementation should be compatible with python 2.7.
2428         https://bugs.webkit.org/show_bug.cgi?id=69789
2429
2430         Reviewed by Eric Seidel.
2431
2432         Made the signature of _assertRaisesRegexp match that of Python 2.7.
2433
2434         * Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Adjusted to be compatible with Python 2.7.
2435         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Ditto.
2436         * Scripts/webkitpy/common/webkitunittest.py: Ditto.
2437         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Ditto.
2438
2439 2011-10-11  Raphael Kubo da Costa  <kubo@profusion.mobi>
2440
2441         [EFL] DRT: Do not abort() when an unknown key is pressed.
2442         https://bugs.webkit.org/show_bug.cgi?id=69856
2443
2444         Reviewed by Antonio Gomes.
2445
2446         A lot of tests crash due to the previous behaviour. Just using the
2447         received name of the pressed key works most of the time, and when it
2448         does not the failing tests should tell us.
2449
2450         * DumpRenderTree/efl/EventSender.cpp:
2451         (keyPadNameFromJSValue):
2452         (keyNameFromJSValue):
2453         (keyDownCallback):
2454
2455 2011-10-11  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2456
2457         [Qt] [WK2] NRWT failed to launch MiniBrowser after test run
2458         https://bugs.webkit.org/show_bug.cgi?id=68016
2459
2460         Reviewed by Chang Shu.
2461
2462         * Scripts/webkitpy/layout_tests/port/qt.py:
2463
2464 2011-10-11  Raphael Kubo da Costa  <kubo@profusion.mobi>
2465
2466         [EFL] DRT: Return the right window count in LayoutTestController.
2467         https://bugs.webkit.org/show_bug.cgi?id=69764
2468
2469         Reviewed by Antonio Gomes.
2470
2471         Follow-up to r96943: now that we have DumpRenderTreeChrome and
2472         DumpRenderTreeView in the tree, we can correctly count the number of
2473         open windows in DRT.
2474
2475         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2476         (LayoutTestController::windowCount):
2477
2478 2011-10-11  Jer Noble  <jer.noble@apple.com>
2479
2480         REGRESSION (r96770-r96777): fast/dom/Window/window-properties.html, fast/dom/prototype-inheritance-2.html, fast/js/global-constructors.html failing on SnowLeopard Intel Release (Tests)
2481         https://bugs.webkit.org/show_bug.cgi?id=69800
2482
2483         Reviewed by Csaba Osztrogonác.
2484
2485         Enable WEB_AUDIO at runtime.
2486
2487         * DumpRenderTree/mac/DumpRenderTree.mm:
2488         (resetDefaultsToConsistentValues):
2489
2490 2011-10-11  Raphael Kubo da Costa  <kubo@profusion.mobi>
2491
2492         [EFL] DRT: Make sure IconDatabase is closed before trying to open it again.
2493         https://bugs.webkit.org/show_bug.cgi?id=69769
2494
2495         Reviewed by Antonio Gomes.
2496
2497         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2498         (LayoutTestController::setIconDatabaseEnabled):
2499
2500 2011-10-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2501
2502         [Qt] Remove all references to QTDIR_build and standalone_package
2503
2504         Qt is now modularized, which means we no longer import WebKit into
2505         the Qt source tree. Instead we use git submodules, and building
2506         QtWebKit as "part of Qt" is really building QtWebKit as from trunk.
2507
2508         To decrease the number of buildsystem configurations we also remove
2509         the standalone_package code-path used when we were providing tarballs
2510         with the derived sources pre-generated.
2511
2512         Reviewed by Simon Hausmann.
2513
2514         * MiniBrowser/qt/MiniBrowser.pro:
2515         * QtTestBrowser/QtTestBrowser.pro:
2516         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2517
2518 2011-10-11  Dominic Mazzoni  <dmazzoni@google.com>
2519
2520         Update Chromium accessibility support in DRT.
2521         https://bugs.webkit.org/show_bug.cgi?id=69676
2522
2523         Reviewed by Chris Fleizach.
2524
2525         Adds several missing properties and methods to enable more
2526         tests to pass, and in particular adds support for notification
2527         callbacks.
2528
2529         * DumpRenderTree/chromium/AccessibilityController.cpp:
2530         (AccessibilityController::AccessibilityController):
2531         (AccessibilityController::reset):
2532         (AccessibilityController::getFocusedElement):
2533         (AccessibilityController::shouldLogAccessibilityEvents):
2534         (AccessibilityController::notificationReceived):
2535         (AccessibilityController::logAccessibilityEventsCallback):
2536         * DumpRenderTree/chromium/AccessibilityController.h:
2537         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2538         (getHelpText):
2539         (getStringValue):
2540         (getOrientation):
2541         (AccessibilityUIElement::AccessibilityUIElement):
2542         (AccessibilityUIElement::getChildAtIndex):
2543         (AccessibilityUIElement::isEqual):
2544         (AccessibilityUIElement::notificationReceived):
2545         (AccessibilityUIElement::roleGetterCallback):
2546         (AccessibilityUIElement::titleGetterCallback):
2547         (AccessibilityUIElement::descriptionGetterCallback):
2548         (AccessibilityUIElement::helpTextGetterCallback):
2549         (AccessibilityUIElement::stringValueGetterCallback):
2550         (AccessibilityUIElement::xGetterCallback):
2551         (AccessibilityUIElement::yGetterCallback):
2552         (AccessibilityUIElement::widthGetterCallback):
2553         (AccessibilityUIElement::heightGetterCallback):
2554         (AccessibilityUIElement::intValueGetterCallback):
2555         (AccessibilityUIElement::minValueGetterCallback):
2556         (AccessibilityUIElement::maxValueGetterCallback):
2557         (AccessibilityUIElement::childrenCountGetterCallback):
2558         (AccessibilityUIElement::insertionPointLineNumberGetterCallback):
2559         (AccessibilityUIElement::selectedTextRangeGetterCallback):
2560         (AccessibilityUIElement::isEnabledGetterCallback):
2561         (AccessibilityUIElement::isRequiredGetterCallback):
2562         (AccessibilityUIElement::isFocusedGetterCallback):
2563         (AccessibilityUIElement::isFocusableGetterCallback):
2564         (AccessibilityUIElement::isSelectedGetterCallback):
2565         (AccessibilityUIElement::isSelectableGetterCallback):
2566         (AccessibilityUIElement::isMultiSelectableGetterCallback):
2567         (AccessibilityUIElement::isExpandedGetterCallback):
2568         (AccessibilityUIElement::isCheckedGetterCallback):
2569         (AccessibilityUIElement::isVisibleGetterCallback):
2570         (AccessibilityUIElement::isOffScreenGetterCallback):
2571         (AccessibilityUIElement::isCollapsedGetterCallback):
2572         (AccessibilityUIElement::hasPopupGetterCallback):
2573         (AccessibilityUIElement::isValidGetterCallback):
2574         (AccessibilityUIElement::orientationGetterCallback):
2575         (AccessibilityUIElement::showMenuCallback):
2576         (AccessibilityUIElement::pressCallback):
2577         (AccessibilityUIElement::isEqualCallback):
2578         (AccessibilityUIElement::addNotificationListenerCallback):
2579         (AccessibilityUIElement::removeNotificationListenerCallback):
2580         (AccessibilityUIElement::takeFocusCallback):
2581         (AccessibilityUIElement::fallbackCallback):
2582         (RootAccessibilityUIElement::getChildAtIndex):
2583         (AccessibilityUIElementList::getOrCreate):
2584         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2585         * DumpRenderTree/chromium/CppVariant.cpp:
2586         (CppVariant::invokeDefault):
2587         * DumpRenderTree/chromium/CppVariant.h:
2588         * DumpRenderTree/chromium/LayoutTestController.cpp:
2589         (LayoutTestController::LayoutTestController):
2590         (LayoutTestController::reset):
2591         * DumpRenderTree/chromium/LayoutTestController.h:
2592         * DumpRenderTree/chromium/WebViewHost.cpp:
2593         (WebViewHost::postAccessibilityNotification):
2594
2595 2011-10-10  Adam Klein  <adamk@chromium.org>
2596
2597         Support Distributed-CompileC as an action name in filter-build-webkit
2598         https://bugs.webkit.org/show_bug.cgi?id=69783
2599
2600         Reviewed by Ojan Vafai.
2601
2602         * Scripts/filter-build-webkit:
2603
2604 2011-10-10  Simon Fraser  <simon.fraser@apple.com>
2605
2606         3D transforms are flattened in WebKit2 snapshots
2607         https://bugs.webkit.org/show_bug.cgi?id=68276
2608
2609         Reviewed by Anders Carlsson.
2610         
2611         Use a snapshot of the window, rather than an image from the web process
2612         for pixel testing in WebKitTestRunner. This correctly captures compositing
2613         layers, so works for 3D transform tests.
2614
2615         * WebKitTestRunner/PlatformWebView.h: Add a windowSnapshotImage() method.
2616         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2617         (WTR::createCGContextFromImage): Add a param to optionally flip the image when drawing.
2618         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Call windowSnapshotImage(), and if it returns an image,
2619         use that instead of the image we get from the web process.
2620         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2621         (WTR::PlatformWebView::windowSnapshotImage): Stub out the new method.
2622         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2623         (WTR::PlatformWebView::windowSnapshotImage): Ditto.
2624         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2625         (WTR::PlatformWebView::windowSnapshotImage): Ditto.
2626         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2627         (WTR::PlatformWebView::windowSnapshotImage): Ditto.
2628
2629 2011-10-10  David Levin  <levin@chromium.org>
2630
2631         Quick fix for watchlist unit test failures when using Python 2.7+
2632         Reviewed by Adam Barth.
2633
2634         Filed bug https://bugs.webkit.org/show_bug.cgi?id=69789 about a
2635         better fix.
2636
2637         * Scripts/webkitpy/common/webkitunittest.py: Always use our
2638         version of assertRaisesRegexp.
2639
2640 2011-10-10  Sheriff Bot  <webkit.review.bot@gmail.com>
2641
2642         Unreviewed, rolling out r97082.
2643         http://trac.webkit.org/changeset/97082
2644         https://bugs.webkit.org/show_bug.cgi?id=69784
2645
2646         broke Windows build (Requested by smfr on #webkit).
2647
2648         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2649         * WebKitTestRunner/cg/TestInvocationCG.cpp: Renamed from Tools/WebKitTestRunner/cg/TestInvocationCG.mm.
2650         (WTR::createCGContextFromImage):
2651         (WTR::computeMD5HashStringForContext):
2652         (WTR::dumpBitmap):
2653         (WTR::paintRepaintRectOverlay):
2654         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2655         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2656         (WTR::PlatformWebView::PlatformWebView):
2657
2658 2011-10-10  Simon Fraser  <simon.fraser@apple.com>
2659
2660         3D transforms are flattened in WebKit2 snapshots
2661         https://bugs.webkit.org/show_bug.cgi?id=68276
2662
2663         Reviewed by Anders Carlsson.
2664         
2665         The WKImage passed from the WebProcess when pixel dumping is created by painting compositing layers
2666         flattened, which flattens 3D transforms. Instead, use CGWindowListCreateImage() to get a snapshot of
2667         the window when doing pixel tests.
2668         
2669         Also allow the window to auto-display, so that Core Animation layers are rendered, and animate.
2670
2671         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: TestInvocationCG became a .mm file
2672         * WebKitTestRunner/cg/TestInvocationCG.mm: Renamed from Tools/WebKitTestRunner/cg/TestInvocationCG.cpp.
2673         (WTR::createBitmapCGContext): Utility function to create a bitmap context.
2674         (WTR::computeMD5HashStringForContext):
2675         (WTR::dumpBitmap):
2676         (WTR::paintRepaintRectOverlay):
2677         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Use CGWindowListCreateImage() to
2678         grap a snapshot of the window, rather than relying on the WKImage which was passed from the web process.
2679         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2680         (WTR::PlatformWebView::PlatformWebView): Remove the line that turned off autoDisplay for the NSWindow.
2681         We need the window to autodisplay for Core Animation to render layers and start animations.
2682
2683 2011-10-10  Simon Fraser  <simon.fraser@apple.com>
2684
2685         WebKitTestRunner needs layoutTestController.setWindowIsKey
2686         https://bugs.webkit.org/show_bug.cgi?id=42688
2687
2688         Reviewed by Anders Carlsson.
2689
2690         Implement layoutTestController.setWindowIsKey() in WebKitTestRunner.
2691         This sets a flag that the platform layer uses to indicate that
2692         the window is the key window, which fixes focus ring drawing
2693         in pixel results.
2694         
2695         Also focus the web view when we get a 'didCommitLoad' for the main
2696         frame, as DumpRenderTree does.
2697
2698         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2699         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2700         (WTR::InjectedBundle::postSetWindowIsKey):
2701         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2702         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2703         (WTR::cacheLayoutTestControllerCallback): Replace some magic numbers with an enum.
2704         (WTR::LayoutTestController::addChromeInputField):
2705         (WTR::LayoutTestController::removeChromeInputField):
2706         (WTR::LayoutTestController::focusWebView):
2707         (WTR::LayoutTestController::setWindowIsKey):
2708         (WTR::LayoutTestController::callAddChromeInputFieldCallback):
2709         (WTR::LayoutTestController::callRemoveChromeInputFieldCallback):
2710         (WTR::LayoutTestController::callFocusWebViewCallback):
2711         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2712         * WebKitTestRunner/PlatformWebView.h: Add an NSWindow subclass
2713         so that we can override -isKeyWindow. Use a boolean member variable
2714         to track window key status.
2715         (WTR::PlatformWebView::setWindowIsKey):
2716         (WTR::PlatformWebView::windowIsKey):
2717         * WebKitTestRunner/TestController.cpp:
2718         (WTR::TestController::runModal): Change the window key status when showing a modal alert, as DRT does.
2719         (WTR::closeOtherPage): Use the same cast as other functions.
2720         (WTR::focus): Implement to call setWindowIsKey(true)
2721         (WTR::unfocus): Implement to call setWindowIsKey(false)
2722         (WTR::TestController::createOtherPage): Add page callbacks for focus and unfocus.
2723         (WTR::TestController::initialize):
2724         (WTR::TestController::didCommitLoadForFrame): Hook up callback to focus the web view, as DRT does.
2725         * WebKitTestRunner/TestController.h:
2726         * WebKitTestRunner/TestInvocation.cpp:
2727         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2728         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2729         (WTR::PlatformWebView::PlatformWebView):
2730         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2731         (-[WebKitTestRunnerWindow isKeyWindow]):
2732         (WTR::PlatformWebView::PlatformWebView): Make a WebKitTestRunnerWindow.
2733         (WTR::PlatformWebView::~PlatformWebView): Clean up the back pointer on the NSWindow subclass, in case it outlives us.
2734         (WTR::PlatformWebView::focus): Set the view as the first responder, and the window as the key window, as DRT does.
2735         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2736         (WTR::PlatformWebView::PlatformWebView):
2737         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2738         (WTR::PlatformWebView::PlatformWebView):
2739
2740 2011-10-10  Raphael Kubo da Costa  <kubo@profusion.mobi>
2741
2742         check-webkit-style: Add readability exception for Ewk_* data types.
2743         https://bugs.webkit.org/show_bug.cgi?id=69763
2744
2745         Reviewed by David Levin.
2746
2747         Many EFL-related files (such as EditorClientEfl.h or
2748         DumpRenderTreeSupportEfl.h) need to have declarations such as "typedef
2749         struct _Ewk_Foo Ewk_Foo", which currently produce false positives in
2750         check-webkit-style.
2751
2752         Add an exception for them, just like there are exceptions for
2753         Evas_*, Ecore_* and others.
2754
2755         * Scripts/webkitpy/style/checkers/cpp.py:
2756         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2757
2758 2011-10-10  Dominic Mazzoni  <dmazzoni@google.com>
2759
2760         [Chromium] Get rid of WebAccessibilityCache.
2761         https://bugs.webkit.org/show_bug.cgi?id=68224
2762
2763         Reviewed by Dimitri Glazkov.
2764
2765         * DumpRenderTree/chromium/AccessibilityController.cpp:
2766         (AccessibilityController::bindToJavascript):
2767
2768 2011-10-09  Adam Barth  <abarth@webkit.org>
2769
2770         Remove "near miss" XSS vulnerabilities in garden-o-matic
2771         https://bugs.webkit.org/show_bug.cgi?id=69708
2772
2773         Reviewed by David Levin.
2774
2775         Collin Jackson did a security audit of garden-o-matic.  He hasn't found
2776         any actual vulnerabilities yet, but he did identify a couple "near
2777         misses" where a slight change in garden-o-matic could lead to a
2778         vulnerability.  This patch removes those potential issues.
2779
2780         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js:
2781         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2782
2783 2011-10-07  Adam Barth  <abarth@webkit.org>
2784
2785         Add a Content-Security-Policy to garden-o-matic
2786         https://bugs.webkit.org/show_bug.cgi?id=69668
2787
2788         Reviewed by David Levin.
2789
2790         This will help mitigate cross-site script and will also help us dogfood CSP.
2791
2792         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2793
2794 2011-10-07  Raphael Kubo da Costa  <kubo@profusion.mobi>
2795
2796         [EFL] DRT: Add DumpRenderTreeChrome.{cpp,h}
2797         https://bugs.webkit.org/show_bug.cgi?id=66380
2798
2799         Reviewed by Antonio Gomes.
2800
2801         This encapsulates EWebKit into an object that manages multiple windows
2802         and provides a cleaner interface to EFL's DumpRenderTree.
2803
2804         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Added.
2805         (DumpRenderTreeChrome::create):
2806         (DumpRenderTreeChrome::DumpRenderTreeChrome):
2807         (DumpRenderTreeChrome::~DumpRenderTreeChrome):
2808         (DumpRenderTreeChrome::createNewWindow):
2809         (DumpRenderTreeChrome::createView):
2810         (DumpRenderTreeChrome::removeWindow):
2811         (DumpRenderTreeChrome::initialize):
2812         (DumpRenderTreeChrome::extraViews):
2813         (DumpRenderTreeChrome::mainFrame):
2814         (DumpRenderTreeChrome::mainView):
2815         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2816         (DumpRenderTreeChrome::onWindowObjectCleared):
2817         (DumpRenderTreeChrome::onLoadStarted):
2818         (DumpRenderTreeChrome::processWork):
2819         (DumpRenderTreeChrome::onLoadFinished):
2820         (DumpRenderTreeChrome::onStatusbarTextSet):
2821         (DumpRenderTreeChrome::onTitleChanged):
2822         (DumpRenderTreeChrome::onDocumentLoadFinished):
2823         * DumpRenderTree/efl/DumpRenderTreeChrome.h: Added.
2824         * DumpRenderTree/efl/EventSender.cpp:
2825         (sendClick): Use browser->mainFrame() instead of mainFrame.
2826         (mouseDownCallback): Ditto.
2827         (mouseUpCallback): Ditto.
2828         (mouseMoveToCallback): Ditto.
2829         (mouseScrollByCallback): Ditto.
2830         (keyDownCallback): Ditto.
2831         (scalePageByCallback): Ditto.
2832         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2833         (LayoutTestController::counterValueForElementById): Use
2834         browser->mainFrame() instead of mainFrame.
2835         (LayoutTestController::pageNumberForElementById): Ditto.
2836         (LayoutTestController::numberOfPages): Ditto.
2837         (LayoutTestController::pauseAnimationAtTimeOnElementWithId): Ditto.
2838         (LayoutTestController::pauseTransitionAtTimeOnElementWithId): Ditto.
2839         (LayoutTestController::sampleSVGAnimationForElementAtTime): Ditto.
2840         (LayoutTestController::numberOfActiveAnimations): Ditto.
2841         (LayoutTestController::suspendAnimations): Ditto.
2842         (LayoutTestController::resumeAnimations): Ditto.
2843         (LayoutTestController::setWebViewEditable): Ditto.
2844         (LayoutTestController::webHistoryItemCount): Use browser->mainView()
2845         instead of browser.
2846         (LayoutTestController::queueLoad): Ditto.
2847         (LayoutTestController::setAcceptsEditing): Ditto.
2848         (LayoutTestController::setUserStyleSheetEnabled): Ditto.
2849         (LayoutTestController::setPrivateBrowsingEnabled): Ditto.
2850         (LayoutTestController::setFrameFlatteningEnabled): Ditto.
2851         (LayoutTestController::setSpatialNavigationEnabled): Ditto.
2852         (LayoutTestController::setPluginsEnabled): Ditto.
2853         (LayoutTestController::findString): Ditto.
2854         (LayoutTestController::setDeveloperExtrasEnabled): Ditto.
2855         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
2856         (createBitmapContextFromWebView): Use browser->mainFrame() instead of
2857         mainFrame.
2858         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
2859         (LoadItem::invoke): Ditto.
2860         (LoadHTMLStringItem::invoke): Ditto.
2861         (ScriptItem::invoke): Ditto.
2862         (ReloadItem::invoke): Use browser->mainView() instead of browser.
2863
2864 2011-10-07  Simon Hausmann  <simon.hausmann@nokia.com>
2865
2866         [Qt][WK2] Touch mocking is broken with Qt 5 post refactor merge
2867         https://bugs.webkit.org/show_bug.cgi?id=69617
2868
2869         Reviewed by Andreas Kling.
2870
2871         Injecting fake touch events using qt_translateRawTouchEvent does not work anymore, as it sends
2872         the touch events to widgets only. The QML view however is a QWindow. Therefore the fake touch
2873         events have to be dispatched through QWindowSystemInterface::handleTouchEvent. As a result the
2874         events appear to be spontaenous, which required adjusting the are-we-on-a-real-touch-device
2875         logic.
2876
2877         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2878         (MiniBrowserApplication::MiniBrowserApplication):
2879         (MiniBrowserApplication::notify):
2880         * MiniBrowser/qt/MiniBrowserApplication.h:
2881
2882 2011-10-06  Adam Barth  <abarth@webkit.org>
2883
2884         Port PixelZoomer to work in garden-o-matic
2885         https://bugs.webkit.org/show_bug.cgi?id=69577
2886
2887         Reviewed by David Levin.
2888
2889         This implementation of PixelZoomer is basically a fork of the
2890         implementation used by results.html.  These two apps have different
2891         requirements on where this code lives.  results.html wants to be
2892         self-contained whereas garden-o-matic wants to live in the public_html
2893         folder of the buildbot.  We could do something fancy here to share the
2894         code, but that's not likely to be of much benefit.
2895
2896         I had to change a few things about pixelzoomer to accounter for the
2897         differences in DOM between results.html and garden-o-matic, but
2898         surprisingly little.  I also moved all the code into an anonymous
2899         function, which is the style we're suing for module separation in
2900         garden-o-matic.  Finally, some jQuery-ims snuck in because I didn't
2901         want to drag along too many extra functions from results.html.
2902
2903         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2904         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
2905         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js: Added.
2906         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2907         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/pixelzoomer.css: Added.
2908         (.pixel-zoom-container):
2909         (.pixel-zoom-container > *):
2910         (.pixel-zoom-container .scaled-image-container):
2911         (.scaled-image-container > img):
2912
2913 2011-10-06  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2914
2915         [EFL] Change data type of parameter in ewk_view_viewport_attributes_get().
2916         https://bugs.webkit.org/show_bug.cgi?id=69505
2917
2918         Reviewed by Andreas Kling.
2919
2920         * EWebLauncher/main.c: Use *int* variables for width and height of viewport meta tag.
2921         (on_viewport_changed):
2922
2923 2011-10-06  Brent Fulgham  <bfulgham@webkit.org>
2924
2925         [WinCairo] Unreviewed test correction.
2926
2927         * Scripts/webkitdirs.pm:
2928         (argumentsForConfiguration): Add 'wincairo' option to the set of
2929         configuration flags used by run-javascript-core tests, so that it
2930         does not attempt to run Apple's release version.
2931
2932 2011-10-06  Brent Fulgham  <bfulgham@webkit.org>
2933
2934         [WinCairo] Unreviewed test correction.
2935
2936         * BuildSlaveSupport/test-result-archive: Add 'wincairo' to the set
2937          of known build slave types so that test-result-archive won't fail
2938          when running tests.
2939
2940 2011-10-06  Martin Robinson  <mrobinson@igalia.com>
2941
2942         The GTK+ WebKit2 headers produce a lot of style warnings
2943         https://bugs.webkit.org/show_bug.cgi?id=69481
2944
2945         Reviewed by David Levin.
2946
2947         Prevent emitting so many style warnings for GTK+ API. We skip header
2948         files in the WebKit2 GTK+ API directory and also avoid warnings about
2949         identifier names that begin with "webkit_" in files that contain the
2950         string "gtk".
2951
2952         * Scripts/webkitpy/style/checker.py: Do not check header files in
2953         Source/WebKit2/UIProcess/API/gtk that do not end in Private.h. This required
2954         adding the ability to specify a regular expression in the skip list. Remove
2955         a few files from the skipped list that no longer exist.
2956         * Scripts/webkitpy/style/checker_unittest.py: Added a test for this behavior.
2957         * Scripts/webkitpy/style/checkers/cpp.py: If a path contains "gtk" don't warn
2958         about identifiers that begin with "webkit_".
2959         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added a test for this behavior.
2960
2961 2011-10-06  Brent Fulgham  <bfulgham@webkit.org>
2962
2963         [WinCairo] Correct config.json for WinCairo Test builds.
2964         https://bugs.webkit.org/show_bug.cgi?id=69272
2965
2966         Reviewed by Ryosuke Niwa.
2967
2968         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove
2969          old 'WinCairo Debug (Build)' label and replace with correct
2970          'WinCairo Release' label.
2971
2972 2011-10-06  David Levin  <levin@chromium.org>
2973
2974         Add a style checker watchlist definition and add myself to it.
2975         https://bugs.webkit.org/show_bug.cgi?id=69564
2976
2977         Reviewed by Daniel Bates.
2978
2979         * Scripts/webkitpy/common/config/watchlist:
2980
2981 2011-10-06  Raphael Kubo da Costa  <kubo@profusion.mobi>
2982
2983         [EFL] DRT: Create icon database path in LayoutTestController::setIconDatabaseEnabled.
2984         https://bugs.webkit.org/show_bug.cgi?id=69450
2985
2986         Reviewed by Ryosuke Niwa.
2987
2988         This should avoid stderr messages when running
2989         webarchive/test-link-rel-icon.html.
2990
2991         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2992         (LayoutTestController::setIconDatabaseEnabled):
2993
2994 2011-10-06  Alejandro G. Castro  <alex@igalia.com>
2995
2996         [WK2] [GTK] Add Skipped file for Webkit2 test runner
2997         https://bugs.webkit.org/show_bug.cgi?id=69517
2998
2999         Use the shared WK2 skipped file also in GTK port.
3000
3001         Reviewed by Martin Robinson.
3002
3003         * Scripts/old-run-webkit-tests:
3004         (readSkippedFiles):
3005
3006 2011-10-06  Elliot Poger  <epoger@google.com>
3007
3008         allow new-run-webkit-tests to run on Lion
3009         https://bugs.webkit.org/show_bug.cgi?id=69429
3010
3011         Add fallback lists for chromium-mac-lion, and add chromium-mac-snowleopard
3012         directory to fallback lists (even though that directory doesn't exist yet)
3013
3014         Reviewed by Adam Barth.
3015
3016         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3017         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3018
3019 2011-10-03  Hans Wennborg  <hans@chromium.org>
3020
3021         IndexedDB: Remove SQLite-LevelDB migration code
3022         https://bugs.webkit.org/show_bug.cgi?id=69264
3023
3024         Reviewed by Tony Chang.
3025
3026         Remove setOverrideIndexedDBBackingStore. It was used in the layout
3027         test for migration.
3028
3029         * DumpRenderTree/chromium/LayoutTestController.cpp:
3030         (LayoutTestController::LayoutTestController):
3031         * DumpRenderTree/chromium/LayoutTestController.h:
3032
3033 2011-10-05  James Robinson  <jamesr@chromium.org>
3034
3035         [chromium] Add a command line option to DumpRenderTree and run_webkit_tests.py to enable threaded compositing mode
3036         https://bugs.webkit.org/show_bug.cgi?id=69498
3037
3038         Reviewed by Adam Barth.
3039
3040         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3041         (main):
3042         * DumpRenderTree/chromium/TestShell.cpp:
3043         (TestShell::TestShell):
3044         (TestShell::resetWebSettings):
3045         * DumpRenderTree/chromium/TestShell.h:
3046         (TestShell::setThreadedCompositingEnabled):
3047         * DumpRenderTree/chromium/WebPreferences.cpp:
3048         (WebPreferences::reset):
3049         (WebPreferences::applyTo):
3050         * DumpRenderTree/chromium/WebPreferences.h:
3051         * Scripts/webkitpy/layout_tests/port/chromium.py:
3052         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3053
3054 2011-10-05  Erik Arvidsson  <arv@chromium.org>
3055
3056         [QT] Fix DRT after r96779
3057
3058         unreviewed.
3059
3060         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3061         (WebCore::dumpHistoryItem):
3062
3063 2011-10-05  Erik Arvidsson  <arv@chromium.org>
3064
3065         window.location.href and others needlessly decodes URI-encoded characters
3066         https://bugs.webkit.org/show_bug.cgi?id=30225
3067
3068         Reviewed by Darin Adler.
3069
3070         * DumpRenderTree/chromium/TestShell.cpp:
3071         (normalizeLayoutTestURLInternal): Remove extra encode.
3072
3073 2011-10-05  Darin Adler  <darin@apple.com>
3074
3075         Fix build.
3076
3077         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
3078         (TestWebKitAPI::TEST): Remove underscore prefix from call to
3079         WKContextRegisterURLSchemeAsEmptyDocument.
3080
3081 2011-10-05  Brent Fulgham  <bfulgham@webkit.org>
3082
3083         [WinCairo] Switch to building Release target, and activate tests.
3084         https://bugs.webkit.org/show_bug.cgi?id=69272
3085
3086         Reviewed by Adam Barth.
3087
3088         * BuildSlaveSupport/build.webkit.org-config/config.json:
3089         Change from debug to release target. Switch from "Build" to
3090         "BuildAndTest"
3091
3092 2011-10-05  Simon Fraser  <simon.fraser@apple.com>
3093
3094         In WebKitTestRunner, text has font smoothing in pixel snapshots
3095         https://bugs.webkit.org/show_bug.cgi?id=69396
3096
3097         Reviewed by Darin Adler.
3098         
3099         Call the new WKContext method that disables font smoothing in
3100         WebKitTestRunner, so that pixel snapshots don't have font smoothing
3101         enabled. Remove leading underscore from a WKContext function call.
3102
3103         * WebKitTestRunner/TestController.cpp:
3104         (WTR::TestController::resetStateToConsistentValues):
3105
3106 2011-10-05  David Levin  <levin@chromium.org>
3107
3108         Improve the watchlist for threading entries.
3109         https://bugs.webkit.org/show_bug.cgi?id=69463
3110
3111         Reviewed by Adam Barth.
3112
3113         * Scripts/webkitpy/common/config/watchlist:
3114
3115 2011-10-05  Adam Roben  <aroben@apple.com>
3116
3117         Add tests for using RetainPtrs inside HashMap and HashSet
3118
3119         Fixes <http://webkit.org/b/69414> <rdar://problem/10236833> Using RetainPtr as the key type
3120         in HashMap/HashSet fails to compile
3121
3122         Reviewed by John Sullivan.
3123
3124         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp: Added.
3125         (TestWebKitAPI::TEST): Show that RetainPtr can be used inside HashSet and as both the key
3126         and value type of HashMap.
3127
3128         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3129         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3130         Added new file.
3131
3132 2011-10-05  Adam Barth  <abarth@webkit.org>
3133
3134         Mark as Expected in garden-o-matic is confusing
3135         https://bugs.webkit.org/show_bug.cgi?id=69452
3136
3137         Reviewed by David Levin.
3138
3139         krit didn't understand the difference between this button and the
3140         Rebaseline button because both of them seem to indicate that the new
3141         behavior is expected.  This patch renames "Mark as Expected" to "Expect
3142         Failure" to make it clear that we're just expecting the test to fail
3143         rather than accepting the new results as passing.  We might need to
3144         iterate on these names a bit more if folks continue to find them
3145         confusing.
3146
3147         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
3148
3149 2011-10-05  Adam Barth  <abarth@webkit.org>
3150
3151         Add watchlist entries for abarth
3152         https://bugs.webkit.org/show_bug.cgi?id=69461
3153
3154         Reviewed by David Levin.
3155
3156         I might have gone a bit overboard.  We'll see if this is too much spam
3157         for me.
3158
3159         * Scripts/webkitpy/common/config/watchlist:
3160
3161 2011-10-05  Brent Fulgham  <bfulgham@webkit.org>
3162
3163         [WinCairo] Teach old-run-webkit-tests about wincairo.
3164         https://bugs.webkit.org/show_bug.cgi?id=69280
3165
3166         Reviewed by Adam Roben.
3167
3168         * Scripts/old-run-webkit-tests: Handle wincairo case.
3169         (buildPlatformResultHierarchy):
3170         (readSkippedFiles): Ditto
3171         * Scripts/webkitdirs.pm: Deal with wincairo build case.
3172         (determineConfiguration):
3173
3174 2011-10-05  Chang Shu  <cshu@webkit.org>
3175
3176         [WK2] Support setMarkedText/hasMarkedText/unmarkText/insertText for WTR TextInputController
3177         https://bugs.webkit.org/show_bug.cgi?id=68924
3178
3179         Added TextInputController files and JS interfaces for the above functions.
3180
3181         Reviewed by Darin Adler.
3182
3183         * WebKitTestRunner/DerivedSources.make:
3184         * WebKitTestRunner/DerivedSources.pro:
3185         * WebKitTestRunner/GNUmakefile.am:
3186         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl: Added.
3187         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3188         (WTR::InjectedBundle::beginTesting):
3189         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3190         (WTR::InjectedBundle::textInputController):
3191         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3192         (WTR::InjectedBundlePage::didClearWindowForFrame):
3193         * WebKitTestRunner/InjectedBundle/TextInputController.cpp: Added.
3194         (WTR::TextInputController::create):
3195         (WTR::TextInputController::TextInputController):
3196         (WTR::TextInputController::~TextInputController):
3197         (WTR::TextInputController::wrapperClass):
3198         (WTR::TextInputController::makeWindowObject):
3199         (WTR::TextInputController::setMarkedText):
3200         (WTR::TextInputController::hasMarkedText):
3201         (WTR::TextInputController::unmarkText):
3202         (WTR::TextInputController::insertText):
3203         * WebKitTestRunner/InjectedBundle/TextInputController.h: Added.
3204         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3205         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3206         * WebKitTestRunner/win/InjectedBundle.vcproj:
3207
3208 2011-10-04  Oliver Hunt  <oliver@apple.com>
3209
3210         Add rudimentary filtering to write barriers
3211         https://bugs.webkit.org/show_bug.cgi?id=69392
3212
3213         Reviewed by Filip Pizlo.
3214
3215         When we're recording gc phase times Heap.o picks up
3216         some exit time destructors, so we'll just ignore Heap.o
3217         in this check.
3218
3219         * Scripts/check-for-exit-time-destructors:
3220
3221 2011-10-05  Chang Shu  <cshu@webkit.org>
3222
3223         [WK2] WebKitTestRunner needs LayoutTestController.dumpConfigurationForViewport
3224         https://bugs.webkit.org/show_bug.cgi?id=69365
3225
3226         Reviewed by Darin Adler.
3227
3228         Added js API in WTR LayoutTestController.
3229
3230         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3231         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3232         (WTR::LayoutTestController::dumpConfigurationForViewport):
3233         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3234
3235 2011-10-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
3236
3237         [EFL] ImageDiff: Do not clear the image before it is processed and compared
3238         https://bugs.webkit.org/show_bug.cgi?id=69378
3239
3240         Reviewed by Antonio Gomes.
3241
3242         Commit 61836 to Evas added a few cleanup calls to some
3243         evas_object_image functions which effectively made ImageDiff consider
3244         all images to be equal.
3245
3246         It turns out that now evas_object_image_colorspace_set clears any
3247         data set, so the call to evas_object_image_data_set was not having any
3248         effect.
3249
3250         * DumpRenderTree/efl/ImageDiff.cpp:
3251         (readImageFromStdin): Call evas_object_image_data_set after
3252         evas_object_image_colorspace_set.
3253
3254 2011-10-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
3255
3256         [EFL] Fix Evas_Object_Image reference counts and file descriptor leakage in ImageDiff.
3257         https://bugs.webkit.org/show_bug.cgi?id=68449
3258
3259         Reviewed by Antonio Gomes.
3260
3261         evas_render() must be called to close up temporary files and unmap unused
3262         resources. evas_object_image_data_set() must be called after an
3263         evas_object_image_data_get() to balance an internal reference count.
3264
3265         * DumpRenderTree/efl/ImageDiff.cpp:
3266         (differenceImageFromDifferenceBuffer):
3267         (calculateDifference):
3268         (printImage):
3269         (printImageDifferences):
3270
3271 2011-10-05  Balazs Kelemen  <kbalazs@webkit.org>
3272
3273         [Qt][WK2] Unreviewed build fix.
3274
3275         Don't use WebCore directly in WTR.
3276
3277         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3278         (WTR::PlatformWebView::addChromeInputField):
3279         (WTR::PlatformWebView::removeChromeInputField):
3280         (WTR::PlatformWebView::makeWebViewFirstResponder):
3281
3282 2011-10-05  David Levin  <levin@chromium.org>
3283
3284         watchlist: Add more rules for chromium public api and sort the file.
3285         https://bugs.webkit.org/show_bug.cgi?id=69323
3286
3287         Reviewed by Adam Barth.
3288
3289         * Scripts/webkitpy/common/config/watchlist:
3290
3291 2011-10-05  David Levin  <levin@chromium.org>
3292
3293         watchlist: Don't add the same message to a bug more than once.
3294         https://bugs.webkit.org/show_bug.cgi?id=69303
3295
3296         Reviewed by Adam Barth.
3297
3298         * Scripts/webkitpy/common/net/bugzilla/bug.py: Added a way to determine
3299         if a message is in the comments already.
3300         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py: A test for the above.
3301         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:
3302         Pick a bug supplied by the mock. Change the test due to different output
3303         from the mock watch list tool.
3304         * Scripts/webkitpy/tool/mocktool.py: Change the mock watch list to return
3305         another email so it will be filtered out, fix bugs to have the cc and comment fields,
3306         and fix fetch_bug to handle bug_id's which are text (because that took me way too long
3307         to debug).
3308         * Scripts/webkitpy/tool/steps/applywatchlist.py: Change to filter out comments
3309         and/or cc's that are already in the bug.
3310         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py: Pick a bug supplied by the mock,
3311         and remove a comment that is filtered out.
3312
3313 2011-10-05  Balazs Kelemen  <kbalazs@webkit.org>
3314
3315         [Qt][WK2] Unreviewed build fix after r96643.
3316
3317         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3318         (WTR::PlatformWebView::addChromeInputField):
3319         (WTR::PlatformWebView::removeChromeInputField):
3320         (WTR::PlatformWebView::makeWebViewFirstResponder):
3321
3322 2011-10-04  Kent Tamura  <tkent@chromium.org>
3323
3324         Introduce feature flags for incomplete input types
3325         https://bugs.webkit.org/show_bug.cgi?id=68971
3326
3327         Reviewed by Hajime Morita.
3328
3329         * Scripts/build-webkit:
3330         Add --input-type-{date,datetime,datetimelocal,month,time,week} flags.
3331         They are disabled by default.
3332
3333 2011-10-04  Adam Barth  <abarth@webkit.org>
3334
3335         garden-o-matic doesn't launch it's UI on Lion
3336         https://bugs.webkit.org/show_bug.cgi?id=69349
3337
3338         Reviewed by Darin Adler.
3339
3340         It turns out that Lion is a bit more picky about file URLs.  This patch
3341         switches us from using a path to using an actual file URL, silencing
3342         the warning and making the tool actually launch on Lion.
3343
3344         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3345
3346 2011-10-04  Daniel Bates  <dbates@rim.com>
3347
3348         Fix Perl undefined variable warning when using run-safari after
3349         <http://trac.webkit.org/changeset/96448> (https://bugs.webkit.org/show_bug.cgi?id=68662)
3350
3351         Rubber-stamped by Alexey Proskuryakov.
3352
3353         * Scripts/webkitdirs.pm:
3354         (runMacWebKitApp): Check that the optional function argument $useOpenCommand
3355         is defined before using it in a comparison operation.
3356
3357 2011-10-04  Scott Graham  <scottmg@chromium.org>
3358
3359         Add GAMEPAD feature flag
3360         https://bugs.webkit.org/show_bug.cgi?id=66859
3361
3362         Reviewed by Darin Fisher.
3363
3364         * Scripts/build-webkit:
3365
3366 2011-10-04  Jon Lee  <jonlee@apple.com>
3367
3368         REGRESSION (WK2): (Shift-)option-tabbing skips over elements when transitioning from chrome to webview
3369         https://bugs.webkit.org/show_bug.cgi?id=68412
3370         <rdar://problem/9988252>
3371
3372         Reviewed by Darin Adler.
3373
3374         In order to create a test for the bug, I had to update DRT and WKTR to create some
3375         widget that allows first responder status to move away from the main web view.
3376
3377         Three methods were added to layoutTestController: addChromeInputField,
3378         removeChromeInputField, and focusWebView. addChromeInputField adds a text field
3379         that is a sibling to the web view, and sets up the key event loop between the two.
3380         removeChromeInputField removes that field. focusWebView moves first responder
3381         status to the web view.
3382
3383         The test makes the call via layoutTestController and passes a callback that it
3384         assumes will be executed once the task is completed. In DRT the callback is called
3385         synchronously. In WKTR this is handled with message passing between the two
3386         processes.
3387
3388         * DumpRenderTree/LayoutTestController.cpp:
3389         (addChromeInputFieldCallback):
3390         (removeChromeInputFieldCallback):
3391         (focusWebViewCallback):
3392         (LayoutTestController::staticFunctions):
3393         * DumpRenderTree/LayoutTestController.h:
3394         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3395         (LayoutTestController::addChromeInputField):
3396         (LayoutTestController::removeChromeInputField):
3397         (LayoutTestController::focusWebView):
3398         * DumpRenderTree/mac/DumpRenderTree.mm:
3399         (resetWebViewToConsistentStateBeforeTesting): When resetting for the next test,
3400         make sure to remove the chrome input field.
3401         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3402         (LayoutTestController::addChromeInputField):
3403         (LayoutTestController::removeChromeInputField):
3404         (LayoutTestController::focusWebView):
3405         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3406         (LayoutTestController::addChromeInputField):
3407         (LayoutTestController::removeChromeInputField):
3408         (LayoutTestController::focusWebView):
3409         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3410         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3411         (WTR::InjectedBundle::didReceiveMessage):
3412         (WTR::InjectedBundle::postAddChromeInputField):
3413         (WTR::InjectedBundle::postRemoveChromeInputField):
3414         (WTR::InjectedBundle::postFocusWebView):
3415         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3416         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3417         (WTR::callbackMap): Create a hash map that keeps track of the callbacks provided
3418         through JS.
3419         (WTR::cacheLayoutTestControllerCallback):
3420         (WTR::callLayoutTestControllerCallback):
3421         (WTR::LayoutTestController::addChromeInputField):
3422         (WTR::LayoutTestController::removeChromeInputField):
3423         (WTR::LayoutTestController::focusWebView):
3424         (WTR::LayoutTestController::callAddChromeInputFieldCallback):
3425         (WTR::LayoutTestController::callRemoveChromeInputFieldCallback):
3426         (WTR::LayoutTestController::callFocusWebViewCallback):
3427         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3428         * WebKitTestRunner/PlatformWebView.h:
3429         * WebKitTestRunner/TestController.cpp:
3430         (WTR::TestController::resetStateToConsistentValues):
3431         * WebKitTestRunner/TestInvocation.cpp:
3432         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3433         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3434         (WTR::PlatformWebView::addChromeInputField):
3435         (WTR::PlatformWebView::removeChromeInputField):
3436         (WTR::PlatformWebView::makeWebViewFirstResponder):
3437         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3438         (WTR::PlatformWebView::addChromeInputField):
3439         (WTR::PlatformWebView::removeChromeInputField):
3440         (WTR::PlatformWebView::makeWebViewFirstResponder):
3441         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3442         (WTR::PlatformWebView::addChromeInputField):
3443         (WTR::PlatformWebView::removeChromeInputField):
3444         (WTR::PlatformWebView::makeWebViewFirstResponder):
3445
3446         * DumpRenderTree/mac/LayoutTestControllerMac.mm: These functions have nothing to do
3447         with the patch-- just cleaning up style.
3448         (LayoutTestController::addDisallowedURL):
3449         (originsArrayToJS):
3450         (LayoutTestController::queueLoad):
3451         (LayoutTestController::setMockDeviceOrientation):
3452         (LayoutTestController::setIconDatabaseEnabled):
3453         (LayoutTestController::setEditingBehavior):
3454
3455 2011-10-04  Simon Fraser  <simon.fraser@apple.com>
3456
3457         Move font-fixup code in WebKitTestRunner to a better place
3458         https://bugs.webkit.org/show_bug.cgi?id=69356
3459
3460         Reviewed by Sam Weinig.
3461         
3462         Move code that swizzles NSFontManager methods to ActivateFonts.mm, which
3463         already contains font-related code.
3464
3465         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3466         (WTR::InjectedBundle::initialize):
3467         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3468         (WTR::allowedFontFamilySet):
3469         (WTR::drt_NSFontManager_availableFontFamilies):
3470         (WTR::drt_NSFontManager_availableFonts):
3471         (WTR::swizzleNSFontManagerMethods):
3472         (WTR::activateFonts):
3473         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3474         (WTR::InjectedBundle::platformInitialize):
3475
3476 2011-10-04  Raphael Kubo da Costa  <kubo@profusion.mobi>
3477
3478         [EFL] DRT: Add DumpRenderTree.cpp
3479         https://bugs.webkit.org/show_bug.cgi?id=62034
3480
3481         Reviewed by Antonio Gomes.
3482
3483         This is the main implementation file for EFL's DumpRenderTree.
3484
3485         * DumpRenderTree/efl/DumpRenderTree.cpp: Added.
3486         (dumpFramesAsText):
3487         (dumpFrameScrollPosition):
3488         (shouldLogFrameLoadDelegates):
3489         (shouldDumpAsText):
3490         (sendPixelResultsEOF):
3491         (invalidateAnyPreviousWaitToDumpWatchdog):
3492         (onEcoreEvasResize):
3493         (onCloseWindow):
3494         (useLongRunningServerMode):
3495         (parseCommandLineOptions):
3496         (getFinalTestURL):
3497         (getExpectedPixelHash):
3498         (createLayoutTestController):
3499         (runTest):
3500         (runTestingServerLoop):
3501         (adjustOutputTypeByMimeType):
3502         (dumpFrameContentsAsText):
3503         (shouldDumpFrameScrollPosition):
3504         (shouldDumpPixelsAndCompareWithExpected):
3505         (shouldDumpBackForwardList):
3506         (initEfl):
3507         (shutdownEfl):
3508         (displayWebView):
3509         (dump):
3510         (initEcoreEvas):
3511         (main):
3512
3513 2011-10-03  Adam Barth  <abarth@webkit.org>
3514
3515         garden-o-matic should remove builders from the failure grid once they start to pass
3516         https://bugs.webkit.org/show_bug.cgi?id=69309
3517
3518         Unreviewed.  dglazkov is on vacation.  I need to interest someone else
3519         in reviewing these patches.
3520
3521         This patch follows the update/purge model from UpdateTracker.  This
3522         patch is less awesome than it could be because it causes the UI to
3523         flash slightly.  In a future patch, we'll want to use these
3524         update/purge notifications to update the UI without flashing.  However,
3525         that's not such a big deal because this UI is hidden in the default
3526         view.
3527
3528         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3529         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
3530         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
3531         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3532
3533 2011-10-03  David Levin  <levin@chromium.org>
3534
3535         webkitpy: Expose cc_emails and comments from bug.py
3536         https://bugs.webkit.org/show_bug.cgi?id=69308
3537
3538         Reviewed by Adam Barth.
3539
3540         * Scripts/webkitpy/common/net/bugzilla/bug.py: Expose cc_emails and comments .
3541         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: Add parsing support for comments.
3542         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: Fix the unit test due
3543         to comments being exposed.
3544
3545 2011-10-03  James Robinson  <jamesr@chromium.org>
3546
3547         Add myself to the watchlist for platform/graphics/chromium
3548         https://bugs.webkit.org/show_bug.cgi?id=69297
3549
3550         Reviewed by David Levin.
3551
3552         * Scripts/webkitpy/common/config/watchlist:
3553
3554 2011-10-03  Anders Carlsson  <andersca@apple.com>
3555
3556         Remove custom scrollbar painting hooks
3557         https://bugs.webkit.org/show_bug.cgi?id=69163
3558
3559         Reviewed by Alexey Proskuryakov.
3560
3561         * DumpRenderTree/chromium/WebPreferences.cpp:
3562         (WebPreferences::applyTo):
3563         No need to enable custom scrollbar painting.
3564
3565 2011-10-03  David Levin  <levin@chromium.org>
3566
3567         watchlist: Make watchlist run on a bot.
3568         https://bugs.webkit.org/show_bug.cgi?id=68974
3569
3570         Reviewed by Adam Barth.
3571
3572         * Scripts/webkitpy/tool/commands/queues.py: Add the watchlist to the style bot.
3573         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3574         Change to log what is run so that we can see the style command
3575         and the watchlist command being run.
3576
3577 2011-10-03  David Levin  <levin@chromium.org>
3578
3579         watchlist: Allow specified a bug to attach the watchlist info to.
3580         https://bugs.webkit.org/show_bug.cgi?id=69288
3581
3582         Reviewed by Eric Seidel.
3583
3584         * Scripts/webkitpy/tool/commands/applywatchlistlocal.py: Add support for bugid.
3585         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:
3586         Add tests and fix an existing test because the unit tests do not go through the
3587         normal command line processing (so the -g argument remained when we determined bug ids).
3588         * Scripts/webkitpy/tool/commands/commandtest.py: Change the derivation to
3589         get the assert raises regex method.
3590         * Scripts/webkitpy/tool/commands/download.py: Fix the command help to be more unixy.
3591
3592 2011-10-03  Leandro Pereira  <leandro@profusion.mobi>
3593
3594         [EFL] DRT: Add JSStringUtils.{cpp,h}
3595         https://bugs.webkit.org/show_bug.cgi?id=66397
3596
3597         Reviewed by Ryosuke Niwa.
3598         
3599         Adds helper functions to compare the equality of C-style strings and
3600         JSStringRef objects.
3601
3602         * DumpRenderTree/efl/JSStringUtils.cpp: Added.
3603         (equals):
3604         * DumpRenderTree/efl/JSStringUtils.h: Added.
3605
3606 2011-10-03  Adam Barth  <abarth@webkit.org>
3607
3608         garden-o-matic should work in Safari 5.1
3609         https://bugs.webkit.org/show_bug.cgi?id=69290
3610
3611         Reviewed by Sam Weinig.
3612
3613         My old implementation of bind was too clever by half.  This one seems
3614         to work better, at least according to this test.
3615
3616         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3617         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
3618
3619 2011-09-29  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
3620
3621         Unreviewed: change my e-mail in commiters.py
3622
3623         (I'm leaving the company and my @openbossa.org will be no more)
3624
3625         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
3626
3627 2011-10-01  Brent Fulgham  <bfulgham@webkit.org>
3628
3629         Correct post-build step for WinCairo test runs.
3630         https://bugs.webkit.org/show_bug.cgi?id=69191 
3631
3632         Reviewed by Brian Weinstein.
3633
3634         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Add additional
3635         shell case to handle the CFLite build.
3636
3637 2011-10-01  Filip Pizlo  <fpizlo@apple.com>
3638
3639         Added myself to reviewers, because I'm now a reviewer.
3640
3641         * Scripts/webkitpy/common/config/committers.py:
3642
3643 2011-10-01  Filip Pizlo  <fpizlo@apple.com>
3644
3645         Bencher script makes it difficult to do automated performance testing
3646         https://bugs.webkit.org/show_bug.cgi?id=69207
3647
3648         Reviewed by Sam Weinig.
3649         
3650         This adds two new features:
3651         
3652         The ability to disable automatic VM detection, which is flaky if any
3653         profiling features are enabled in jsc.
3654         
3655         The ability to compute, and report, a scaled result for all benchmark
3656         suites. It is the geometric mean of three numbers: SunSpider's
3657         arithmetic mean, V8's geometric mean, and Kraken's arithmetic mean.
3658         It is also possible to turn off all other output from bencher and just
3659         get this number with the --brief option.
3660
3661         * Scripts/bencher:
3662
3663 2011-10-01  Sam Weinig  <sam@webkit.org>
3664
3665         WTR is not successfully changing the NSUserDefaults
3666         https://bugs.webkit.org/show_bug.cgi?id=69204
3667
3668         Reviewed by Dan Bernstein.
3669
3670         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3671         (WTR::InjectedBundle::platformInitialize):
3672         Use -setVolatileDomain:forName:NSArgumentDomain instead of registerDefaults to
3673         get our overrides picked up.
3674
3675 2011-09-30  Daniel Bates  <dbates@rim.com>
3676
3677         Cleanup: Extract code to launch a Mac WebKit application into a common function
3678         https://bugs.webkit.org/show_bug.cgi?id=68662
3679
3680         Reviewed by Adam Roben.
3681
3682         Extracts common code to launch a WebKit application on Mac OS X into a function
3683         so that we can remove duplicate code.
3684
3685         * Scripts/run-webkit-app: Modified to use webkitdirs::runMacWebKitApp().
3686         * Scripts/webkitdirs.pm: Sorted @EXPORT list and added constant USE_OPEN_COMMAND.
3687         (runMacWebKitApp): Added.
3688         (runSafari): Modified to use webkitdirs::runMacWebKitApp().
3689         (runMiniBrowser): Ditto.
3690         (runWebKitTestRunner): Ditto.
3691         (runTestWebKitAPI): Ditto.
3692
3693 2011-09-29  David Levin  <levin@chromium.org>
3694
3695         watchlist: Add webkit-patch command to run watchlist.
3696         https://bugs.webkit.org/show_bug.cgi?id=68973
3697
3698         Reviewed by Eric Seidel.
3699
3700         * Scripts/webkitpy/common/host.py: Exposed the watch_list.
3701         * Scripts/webkitpy/common/watchlist/watchlist.py: Changed to return
3702         the cc and messages as sorted lists. To allow for deterministic ordering.
3703         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Ditto.
3704         * Scripts/webkitpy/tool/commands/__init__.py: Add ApplyWatchListLocal so
3705         that it will be exposed as a command by webkit-patch.
3706         * Scripts/webkitpy/tool/commands/applywatchlistlocal.py: Added.
3707         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Added.
3708         * Scripts/webkitpy/tool/commands/download.py: Added ApplyWatchList which mimics CheckStyle.
3709         * Scripts/webkitpy/tool/commands/download_unittest.py: Added an appropriate test.
3710         * Scripts/webkitpy/tool/mocktool.py: Mock out the watch list.
3711         * Scripts/webkitpy/tool/steps/__init__.py: Added ApplyWatchList.
3712         * Scripts/webkitpy/tool/steps/applywatchlist.py: Added.
3713         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py: Added.
3714
3715 2011-09-30  David Levin  <levin@chromium.org>
3716
3717         watchlist: Add a way to detect a net increase or decrease of a pattern (in a file).
3718         https://bugs.webkit.org/show_bug.cgi?id=69031
3719
3720         Reviewed by Adam Barth.
3721
3722         * Scripts/webkitpy/common/config/watchlist: Added usage of the new pattern,
3723         a comment to explain something important about the email addresses, and
3724         a comment to let emacs know to treat the file as a python file.
3725         * Scripts/webkitpy/common/watchlist/amountchangedpattern.py: Added.
3726         Detects increases or decreases in a pattern.
3727         * Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py: Added.
3728         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
3729         Added unit tests for watchlist which has "more" or "less".
3730         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
3731         Added support for "more" or "less".
3732
3733 2011-09-30  Sam Weinig  <sam@webkit.org>
3734
3735         Add support for eventSender.mouseScrollBy in WTR
3736         https://bugs.webkit.org/show_bug.cgi?id=69189
3737
3738         Add implementation of eventSender.mouseScrollBy for the mac.
3739
3740         Reviewed by Simon Fraser.
3741
3742         * WebKitTestRunner/EventSenderProxy.h:
3743         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3744         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3745         (WTR::EventSendingController::keyDown):
3746         (WTR::EventSendingController::mouseScrollBy):
3747         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3748         * WebKitTestRunner/TestController.cpp:
3749         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3750         * WebKitTestRunner/mac/EventSenderProxy.mm:
3751         (WTR::EventSenderProxy::mouseScrollBy):
3752
3753 2011-09-30  Simon Fraser  <simon.fraser@apple.com>
3754
3755         fast/forms/text-control-intrinsic-widths.html fails on Mac if Word/Office fonts are installed
3756         https://bugs.webkit.org/show_bug.cgi?id=35273
3757
3758         Reviewed by Dan Bernstein.
3759         
3760         There are two types of font issue that can cause layout test failure.
3761         First, the user may have non-standard fonts installed that affect the layout
3762         of some tests. For example, some tests use the MS Gothic font if installed.
3763         
3764         Secondly, the user may have duplicate fonts installed in ~/Library/Fonts,
3765         which override the system fonts (e.g. a copy of Arial from MS Office). For
3766         some tests, this can affect font metrics or fallback behavior.
3767         
3768         This change addresses the first problem only. It limits the set of fonts
3769         available through NSFontManager, by swizzling some methods to return
3770         a list of fonts or font families which only include fonts from a hardcoded
3771         whitelist.
3772         
3773         * DumpRenderTree/mac/DumpRenderTree.mm:
3774         (allowedFontFamilySet):
3775         (drt_NSFontManager_availableFontFamilies):
3776         (drt_NSFontManager_availableFonts):
3777         (swizzleNSFontManagerMethods):
3778         (activateTestingFonts):
3779         (adjustFonts):
3780         (createWebViewAndOffscreenWindow):
3781         (prepareConsistentTestingEnvironment):
3782         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3783         (WTR::allowedFontFamilySet):
3784         (WTR::drt_NSFontManager_availableFontFamilies):
3785         (WTR::drt_NSFontManager_availableFonts):
3786         (WTR::swizzleNSFontManagerMethods):
3787         (WTR::InjectedBundle::platformInitialize):
3788
3789 2011-09-30  David Levin  <levin@chromium.org>
3790
3791         Need to skip webkitpy.common.checkout.baselineoptimizer_unittest.BaselineOptimizerTest on Windows..
3792         https://bugs.webkit.org/show_bug.cgi?id=69039
3793
3794         Reviewed by Adam Barth.
3795
3796         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
3797         Actually skip only one specific test that is failing on Windows.
3798
3799 2011-09-30  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3800
3801         [Qt] Prevent qDebug() output from DRT and WTR unless --verbose
3802
3803         For DRT we didn't install the message handler early enough to
3804         catch output while constructing the QApplication. For WTR we
3805         didn't even install a message handler.
3806
3807         Since the UI process will forward any output from the web process
3808         we set an environment variable QT_WEBKIT_SUPPRESS_WEB_PROCESS_OUTPUT
3809         in WTR before the web process is started. This is picked up by the
3810         web process which installs its own message handler.
3811
3812         The environment variable can be overriden on the command line if you
3813         want to see output from the web process, or you can pass --verbose to
3814         WTR to see output from both processes.
3815
3816         https://bugs.webkit.org/show_bug.cgi?id=69132
3817
3818         Reviewed by Andreas Kling.
3819
3820         * DumpRenderTree/qt/main.cpp:
3821         * WebKitTestRunner/qt/main.cpp:
3822
3823 2011-09-30  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3824
3825         [Qt] Make sure WTR sizes the window and item correctly
3826
3827         Revision 96345 changed the logic for how the view and
3828         window was created, but missed a vital part, setting
3829         the size.
3830
3831         We now use a QSGView for the window, that has a simple
3832         item as its root object that is always resized to fit
3833         within the window. The webview is then parented to the
3834         root object and set to anchors.fill: parent. That way
3835         any window geometry changes will propagate to the web
3836         view.
3837
3838         https://bugs.webkit.org/show_bug.cgi?id=69134
3839
3840         Reviewed by Andreas Kling.
3841
3842         * WebKitTestRunner/PlatformWebView.h:
3843         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3844
3845 2011-09-30  Raphael Kubo da Costa  <kubo@profusion.mobi>
3846
3847         [EFL] Only save the current viewport in PixelDumpSupportEfl.
3848         https://bugs.webkit.org/show_bug.cgi?id=68450
3849
3850         Reviewed by Antonio Gomes.
3851
3852         The previous implementation saved the whole page contents in the final
3853         PNG, however the baselines and expectations in the tree only want the
3854         current viewport (with a scrollbar, if needed), so we now only save the
3855         currently visible contents.
3856
3857         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
3858         (createBitmapContextFromWebView): Use
3859         ewk_frame_visible_content_geometry_get instead of
3860         ewk_frame_contents_size_get.
3861
3862 2011-09-30  Raphael Kubo da Costa  <kubo@profusion.mobi>
3863
3864         [EFL] Support and keep track of extra windows (views).
3865         https://bugs.webkit.org/show_bug.cgi?id=68454
3866
3867         Reviewed by Antonio Gomes.
3868
3869         So far, window.open and related JavaScript code would not work, as
3870         DRTView did not implementation
3871         Ewk_View_Smart_Class::window_{open,close}. The default implementation
3872         in ewk just returns the current window/view, which broke any
3873         layouttest which relied on window.open.
3874
3875         We now properly create and remove these new views. Unfortunately, the
3876         current way ewk works (and due to the fact that we cannot pass class
3877         methods as function pointers to the EFL functions), DRTView needs to
3878         know that DRTChrome exists and call `browser' directly in some points.
3879
3880         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
3881         (onWindowCreate):
3882         (onWindowCloseDelayed):
3883         (onWindowClose):
3884         (drtViewTiledAdd):
3885
3886 2011-09-30  Qi Zhang  <qi.2.zhang@nokia.com>
3887
3888         WebKitTestRunner needs layoutTestController.setAppCacheMaximumSize
3889         https://bugs.webkit.org/show_bug.cgi?id=42698
3890
3891         Reviewed by Andreas Kling.
3892
3893         Implemented layoutTestController.setAppCacheMaximumSize and layoutTestController.clearApplicationCache,
3894         and call clearApplicationCache when layoutTest start up.
3895
3896         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3897         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3898         (WTR::InjectedBundle::beginTesting):
3899         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3900         (WTR::LayoutTestController::clearAllApplicationCaches):
3901         (WTR::LayoutTestController::setAppCacheMaximumSize):
3902         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3903
3904 2011-09-30  Zeno Albisser  <zeno.albisser@nokia.com>
3905
3906         [Qt][WK2] Change WebKitTestRunner to use QMouseEvents instead of QGraphicsSceneMouseEvents
3907         https://bugs.webkit.org/show_bug.cgi?id=69145
3908
3909         This is a follow up to https://bugs.webkit.org/show_bug.cgi?id=69105
3910         Due to refactorings in Qt5, QMouseEvent now supports floating point coordinates
3911         and is perfectly suitable for SceneGraph as well. GraphicsScene events
3912         will not be available in QtGui anymore in future. Therefore we also have to change
3913         QtWebKit to use QMouseEvents instead of QGraphicsSceneMouseEvents.
3914
3915         Reviewed by Chang Shu.
3916
3917         * WebKitTestRunner/EventSenderProxy.h:
3918         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
3919         (WTR::EventSenderProxy::createMouseEvent):
3920         (WTR::EventSenderProxy::mouseDown):
3921         (WTR::EventSenderProxy::mouseUp):
3922         (WTR::EventSenderProxy::mouseMoveTo):
3923
3924 2011-09-30  James Robinson  <jamesr@chromium.org>
3925
3926         [chromium] Add WebKit API for sending input events to the compositor thread
3927         https://bugs.webkit.org/show_bug.cgi?id=69117
3928
3929         Reviewed by Darin Fisher.
3930
3931         Adds support for creating and setting a compositor thread in DRT.
3932
3933         * DumpRenderTree/chromium/WebViewHost.cpp:
3934         (WebViewHost::WebViewHost):
3935         * DumpRenderTree/chromium/WebViewHost.h:
3936
3937 2011-09-29  David Levin  <levin@chromium.org>
3938
3939         watchlist: Add cross-checks for WatchList once it is filled.
3940         https://bugs.webkit.org/show_bug.cgi?id=68975
3941
3942         Reviewed by Eric Seidel.
3943
3944         * Scripts/webkitpy/common/watchlist/watchlist.py: Made the data members public
3945         instead of having trivial getter and setters.
3946         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Fix the unit tests to
3947         pass the validation checks.
3948         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Add validation checks
3949         and fix a few style nits.
3950         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Add tests for the
3951         validation checks.
3952         * Scripts/webkitpy/common/watchlist/watchlistrule.py: Make definitions_to_match public.
3953
3954 2011-09-29  Xianzhu Wang  <wangxianzhu@chromium.org>
3955
3956         run-api-tests fails on chromium-win bot
3957         https://bugs.webkit.org/show_bug.cgi?id=69121
3958
3959         On Windows running a perl script needs the interpreter.
3960
3961         Reviewed by Adam Barth.
3962
3963         * Scripts/run-api-tests:
3964         (buildTestTool):
3965
3966 2011-09-29  Adam Barth  <abarth@webkit.org>
3967
3968         Attempt to make this tool work on Windows.
3969
3970         * Scripts/run-api-tests:
3971         (buildTestTool):
3972
3973 2011-09-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3974
3975         [Qt] Try to fix the minial build
3976
3977         * QtTestBrowser/launcherwindow.cpp:
3978         * QtTestBrowser/webpage.cpp:
3979
3980 2011-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3981
3982         [Qt] Fix build against Qt5 after refactor of widgets out of QtGUi
3983
3984         QWidget and friends now live in the QtWidgets library. We update
3985         includes in implementation files and private headers to us the
3986         non-module-prefixed path, and leave the lookup for the include
3987         path. For public headers we have to ifdef the includes as the
3988         user might now have the modules we need in his QT config.
3989
3990         Finally, QSGCanvas is no longer a QWidget but a QWindow, so we
3991         have to update our code and use windowHandle() for setting the
3992         parent relationships.
3993
3994         https://bugs.webkit.org/show_bug.cgi?id=68687
3995
3996         Reviewed by Andreas Kling.
3997
3998         * DumpRenderTree/qt/DumpRenderTree.pro:
3999         * DumpRenderTree/qt/ImageDiff.pro:
4000         * MiniBrowser/qt/BrowserView.cpp:
4001         * MiniBrowser/qt/BrowserView.h:
4002         * MiniBrowser/qt/BrowserWindow.cpp:
4003         * MiniBrowser/qt/BrowserWindow.h:
4004         * MiniBrowser/qt/MiniBrowser.pro:
4005         * MiniBrowser/qt/MiniBrowserApplication.h:
4006         * MiniBrowser/qt/main.cpp:
4007         * QtTestBrowser/QtTestBrowser.pro:
4008         * QtTestBrowser/launcherwindow.cpp:
4009         * QtTestBrowser/launcherwindow.h:
4010         * QtTestBrowser/locationedit.h:
4011         * QtTestBrowser/main.cpp:
4012         * QtTestBrowser/mainwindow.cpp:
4013         * QtTestBrowser/mainwindow.h:
4014         * QtTestBrowser/webinspector.h:
4015         * QtTestBrowser/webpage.cpp:
4016         * QtTestBrowser/webview.cpp:
4017         * WebKitTestRunner/PlatformWebView.h:
4018         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
4019
4020 2011-09-29  Ravi Phaneendra Kasibhatla  <ravi.kasibhatla@motorola.com>
4021
4022         Initial implementation of WebInspector for WebKit2 GTK port.
4023         https://bugs.webkit.org/show_bug.cgi?id=68235
4024
4025         Reviewed by Martin Robinson.
4026
4027         * MiniBrowser/gtk/BrowserWindow.c:
4028         (browserWindowConstructed): Set the developer extra flags to true to enable inspect element.
4029
4030 2011-09-29  Adam Barth  <abarth@webkit.org>
4031
4032         Unbreak the "update expectatations" button by using the existing
4033         machinery to create the failureInfo objects.
4034
4035         Unbreak the "close" button on the progress dialog by using |this|
4036         instead of the old name of the object.
4037
4038         Teach the controllers unit test not to talk to the actual network.
4039
4040         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
4041         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers_unittests.js:
4042         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
4043
4044 2011-09-29  Hans Wennborg  <hans@chromium.org>
4045
4046         IndexedDB: Use LevelDB also for in-memory databases
4047         https://bugs.webkit.org/show_bug.cgi?id=68903
4048
4049         Reviewed by Steve Block.
4050
4051         Remove the temporary dir that was necessary before LevelDB supported
4052         in-memory databases.
4053
4054         * DumpRenderTree/chromium/TestShell.cpp:
4055         (TestShell::TestShell):
4056         * DumpRenderTree/chromium/TestShell.h:
4057
4058 2011-09-28  Xianzhu Wang  <wangxianzhu@chromium.org>
4059
4060         Run TestWebKitAPI on Chromium buildbots
4061         https://bugs.webkit.org/show_bug.cgi?id=68678
4062
4063         Reviewed by Tony Chang.
4064
4065         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4066
4067 2011-09-28  Dimitri Glazkov  <dglazkov@chromium.org>
4068
4069         garden-o-matic results should anticipate 0 unexpected failures.
4070         https://bugs.webkit.org/show_bug.cgi?id=69036
4071
4072         Also fixes controllers: UnexpectedFailures test.
4073
4074         Reviewed by Adam Barth.
4075
4076         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Tweaked.
4077
4078 2011-09-28  Dirk Pranke  <dpranke@chromium.org>
4079
4080         Modify new-run-webkit-tests to return the percentage difference in image diffs where possible.
4081
4082         https://bugs.webkit.org/show_bug.cgi?id=67253
4083
4084         Reviewed by Eric Seidel.
4085
4086         Nearly all of the work in this was done by Simon Fraser; I'm
4087         just repackaging it and cleaning it up a bit. This change
4088         modifies port.diff_image() to return a tuple of (pass/fail,
4089         %age), adds the value to the FailureImageHashMismatch, and
4090         writes the value into the full_results.json files to be
4091         displayed in the results page.
4092
4093         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4094         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
4095         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
4096         * Scripts/webkitpy/layout_tests/models/test_failures.py:
4097         * Scripts/webkitpy/layout_tests/port/base.py:
4098         * Scripts/webkitpy/layout_tests/port/chromium.py:
4099         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
4100         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
4101         * Scripts/webkitpy/layout_tests/port/test.py:
4102         * Scripts/webkitpy/layout_tests/port/webkit.py:
4103         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
4104
4105 2011-09-25  Kentaro Hara  <haraken@chromium.org>
4106
4107         Unreviewed. Adding myself to committers.py.
4108
4109         * Scripts/webkitpy/common/config/committers.py:
4110
4111 2011-09-28  Adam Barth  <abarth@webkit.org>
4112
4113         garden-o-matic shouldn't depend on test-results.appspot.com
4114         https://bugs.webkit.org/show_bug.cgi?id=69019
4115
4116         Reviewed by Dimitri Glazkov.
4117
4118         This patch moves garden-o-matic from getting full_results.json from
4119         test-results.appspot.com to getting that information directly from the
4120         buildbot.  This patch improve the load time and accuracy of
4121         garden-o-matic because test-results.appspot.com is slow and is dropping
4122         a significant number of writes (see
4123         https://bugs.webkit.org/show_bug.cgi?id=68748).
4124
4125         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
4126         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
4127         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
4128
4129 2011-09-28  David Levin  <levin@chromium.org>
4130
4131         watchlist: Add a way to load the watchlist from config.
4132         https://bugs.webkit.org/show_bug.cgi?id=68991
4133
4134         Reviewed by Eric Seidel.
4135
4136         * Scripts/webkitpy/common/config/watchlist: Added.
4137         * Scripts/webkitpy/common/watchlist/watchlistloader.py: Added.
4138         Support for loading the watch list.
4139         * Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Added.
4140         Tests for the loading.
4141         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
4142         Adjusted to use the common base class.
4143         * Scripts/webkitpy/common/webkitunittest.py: Added.
4144         Made a common base class for functionality used in more than one.
4145
4146 2011-09-28  David Levin  <levin@chromium.org>
4147
4148         Attempt fix for Leopard python unit test run.
4149
4150         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
4151
4152 2011-09-27  Dimitri Glazkov  <dglazkov@chromium.org>
4153
4154         REGRESSION(r95573): Crash when loading SVG documents in a flattened frame or any SVG document in Chromium/Mac.
4155         https://bugs.webkit.org/show_bug.cgi?id=68938
4156
4157         Made Chromium/Mac DRT better match how Chromium/Mac queries WebKit.
4158
4159         Reviewed by David Hyatt.
4160
4161         * DumpRenderTree/chromium/WebViewHost.cpp:
4162         (WebViewHost::didUpdateLayout): Added width/height queries.
4163         * DumpRenderTree/chromium/WebViewHost.h: Updated defs.
4164
4165 2011-09-28  Mihai Parparita  <mihaip@chromium.org>
4166
4167         Get rebaseline server running again
4168         https://bugs.webkit.org/show_bug.cgi?id=69020
4169
4170         Reviewed by Adam Barth.
4171
4172         Make rebaseline server run again after r90337 (missing format_date_time
4173         import, results_json wasn't outputting anything).
4174
4175         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
4176         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
4177
4178 2011-09-28  David Grogan  <dgrogan@chromium.org>
4179
4180         Move dgrogan from contributor to committer
4181         https://bugs.webkit.org/show_bug.cgi?id=69021
4182
4183         * Scripts/webkitpy/common/config/committers.py:
4184
4185 2011-09-28  Mihai Parparita  <mihaip@chromium.org>
4186
4187         Add Mac Skia GPU bots to builders.py
4188         https://bugs.webkit.org/show_bug.cgi?id=69016
4189
4190         Reviewed by Eric Seidel.
4191
4192         This allows wwebkit-patch rebaseline-expectations to work with Mac Skia
4193         GPU tests.
4194
4195         * Scripts/webkitpy/layout_tests/port/builders.py:
4196         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
4197
4198 2011-09-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
4199
4200         Second try at fixing the GTK+ build.
4201
4202         * GNUmakefile.am:
4203
4204 2011-09-28  Xianzhu Wang  <wangxianzhu@chromium.org>
4205
4206         Let TestWebKitAPI and webkit_unit_tests work for chromium-win
4207         https://bugs.webkit.org/show_bug.cgi?id=68680
4208
4209         Reviewed by Tony Chang.
4210
4211         * Scripts/run-chromium-webkit-unit-tests:
4212         * Scripts/webkitdirs.pm:
4213         (determineBaseProductDir):
4214
4215 2011-09-28  Kaustubh Atrawalkar  <kaustubh@motorola.com>
4216
4217         [Gtk] Implement textInputController.doCommand
4218         https://bugs.webkit.org/show_bug.cgi?id=66496
4219
4220         Reviewed by Martin Robinson.
4221
4222         * DumpRenderTree/gtk/TextInputController.cpp:
4223         (doCommandCallback): Callback function for textInputController.doCommand
4224
4225 2011-09-28  David Levin  <levin@chromium.org>
4226
4227         watchlist: Suggest corrections for typos and improve error message consistency.
4228         https://bugs.webkit.org/show_bug.cgi?id=68976
4229
4230         Reviewed by Adam Barth.
4231
4232         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Add suggestions
4233         for typos and improve consistency of the error messages.
4234         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Add tests
4235         and improve the regex that were already present.
4236
4237 2011-09-28  David Levin  <levin@chromium.org>
4238
4239         watchlist: Add support for matching added or deleted lines.
4240         https://bugs.webkit.org/show_bug.cgi?id=68972
4241
4242         Reviewed by Adam Barth.
4243
4244         * Scripts/webkitpy/common/watchlist/changedlinepattern.py: Added.
4245         * Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py: Added.
4246         * Scripts/webkitpy/common/watchlist/watchlist.py: Comment fix up and fix input
4247         to the pattern match to only have the diff lines instead of the DiffFile.
4248         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
4249         Add tests for the new patterns and combinations of the patterns.
4250         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
4251         Sort imports. Add changeline support.
4252
4253 2011-09-28  Carlos Garcia Campos  <cgarcia@igalia.com>
4254
4255         [GTK] Add WebKitError to GTK+ WebKit2 API
4256         https://bugs.webkit.org/show_bug.cgi?id=68508
4257
4258         Reviewed by Martin Robinson.
4259
4260         * GNUmakefile.am: Add path to webkitgtk derived sources to the
4261         include path.
4262
4263 2011-09-28  Philippe Normand  <pnormand@igalia.com>
4264
4265         [GTK] missing WebKit2 support in run-gtk-tests
4266         https://bugs.webkit.org/show_bug.cgi?id=68992
4267
4268         Rubber-stamped by Andreas Kling.
4269
4270         * Scripts/run-gtk-tests: Get the WebKit2 tests to run from the
4271         webkit2 directory.
4272
4273 2011-09-27  Philippe Normand  <pnormand@igalia.com>
4274
4275         [GTK] build-webkit --no-webkit2 still builds WebKit2
4276         https://bugs.webkit.org/show_bug.cgi?id=68892
4277
4278         Reviewed by Martin Robinson.
4279
4280         Take the --no-webkit2 option in account when building WebKitGTK+.
4281
4282         * Scripts/build-webkit:
4283         * Scripts/webkitdirs.pm:
4284         (buildAutotoolsProject):
4285         (buildGtkProject):
4286
4287 2011-09-28  Ryosuke Niwa  <rniwa@webkit.org>
4288
4289         Make Chromium Win Release (Tests) a core builder
4290         https://bugs.webkit.org/show_bug.cgi?id=68906
4291
4292         Reviewed by Adam Barth.
4293
4294         Add Chromium Win Release (Tests) to the list of core builders.
4295
4296         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
4297         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
4298
4299 2011-09-27  Adam Barth  <abarth@webkit.org>
4300
4301         garden-o-matic should load faster and inform the user what is happening
4302         https://bugs.webkit.org/show_bug.cgi?id=68954
4303
4304         Reviewed by Dimitri Glazkov.
4305
4306         This test disables the expected failures tab.  The web inspector showed
4307         that loading the data for this tab was slowing down the loading time
4308         for the whole app.  We need to find a way to load that data lazily.
4309
4310         This patch also improves the update message to better describe the
4311         progress the app is making analyzing data from the buildbot.
4312
4313         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
4314         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
4315         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
4316
4317 2011-09-27  Adam Barth  <abarth@webkit.org>
4318
4319         garden-o-matic should show the first result when examining results
4320         http