52a2406317b00928972d8e96f6623113bc1f65db
[WebKit-https.git] / Tools / ChangeLog
1 2012-07-29  Rik Cabanier  <cabanier@adobe.com>
2
3         Add ENABLE_CSS_COMPOSITING flag
4         https://bugs.webkit.org/show_bug.cgi?id=92553
5
6         Reviewed by Dirk Schulze.
7
8         Adds compiler flag CSS_COMPOSITING to build systems to enable CSS blending and compositing. See spec https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html
9
10         * Scripts/webkitperl/FeatureList.pm:
11
12 2012-07-29  Gustavo Noronha Silva  <gns@gnome.org>
13
14         Reviewed by Martin Robinson.
15
16         Make the jhbuild wrapper scripts become the jhbuild process
17         instead of starting it as a child. This should make it possible to
18         interrupt execution of jhbuild cleanly.
19
20         * gtk/run-with-jhbuild:
21         * jhbuild/jhbuild-wrapper:
22
23 2012-07-29  Mike West  <mkwst@chromium.org>
24
25         Extend `application/x-webkit-test-netscape` plugins to better support multiple frames.
26         https://bugs.webkit.org/show_bug.cgi?id=92478
27
28         Reviewed by Adam Barth.
29
30         DumpRenderTree currently understands
31         `<object src="data:application/x-webkit-test-netscape,alertwhenloaded">`.
32         It would be useful if it understood `logifloaded`, which could give
33         more context regarding test expectations, and can be written in such
34         as way as to support plugins loaded into multiple iframes in a single
35         test.
36
37         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
38         (NPP_New):
39             Adding support for `logifloaded`.
40
41 2012-07-28  Peter Kasting  <pkasting@google.com>
42
43         Fix Chromium/Win compile.
44         https://bugs.webkit.org/show_bug.cgi?id=88787
45
46         Unreviewed, build fix.
47
48         Chromium/Win needs _USE_MATH_DEFINES but doesn't define PLATFORM(WIN).
49         The other files in WebKit that define this macro (both in
50         WebCore/platform/graphics/cg) do it by unconditionally #defining it to 1
51         above the #include of "config.h", so copy that pattern here.
52
53         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
54
55 2012-07-28  Mario Sanchez Prada  <msanchez@igalia.com>
56
57         [WK2][GTK] Implement a new spell checker API for WebKit2GTK+
58         https://bugs.webkit.org/show_bug.cgi?id=90268
59
60         Reviewed by Martin Robinson.
61
62         Ignore WebKitTextChecker.* private files for gtk-doc.
63
64         * gtk/generate-gtkdoc:
65         (get_webkit2_options):
66
67 2012-07-28  Philippe Normand  <pnormand@igalia.com>
68
69         [GTK] Transparent Media controls timeline and panel
70         https://bugs.webkit.org/show_bug.cgi?id=85279
71
72         Reviewed by Martin Robinson.
73
74         * gtk/jhbuild.modules: Provide gnome-themes-standard build
75         support, this is necessary so the media controls panel colors are
76         properly initialized from the GTK+ theme.
77
78 2012-07-27  Kihong Kwon  <kihong.kwon@samsung.com>
79
80         [EFL] Support for HTML media capture
81         https://bugs.webkit.org/show_bug.cgi?id=91842
82
83         Reviewed by Ryosuke Niwa.
84
85         Add HTML media capture feature to the feature list.
86         In addition, enable that on the Efl port.
87
88         * Scripts/webkitperl/FeatureList.pm:
89
90 2012-07-27  Dirk Pranke  <dpranke@chromium.org>
91
92         "webkit-patch rebaseline <test>" fails with exit_code 1
93         https://bugs.webkit.org/show_bug.cgi?id=91560
94
95         Reviewed by Adam Barth.
96
97         webkit-patch rebaseline-json crashes in an svn checkout if it
98         tries to add files and there are no files to add; arguably
99         svn.add() should be robust against this, but rebaseline-json
100         shouldn't be calling it, either. This patch fixes the latter and
101         adds better debugging info to garden-o-matic so we can see what
102         caused the crash.
103
104         * Scripts/webkitpy/tool/commands/rebaseline.py:
105         (AbstractParallelRebaselineCommand._rebaseline):
106         * Scripts/webkitpy/tool/servers/gardeningserver.py:
107         (GardeningHTTPRequestHandler.rebaselineall):
108         (GardeningHTTPRequestHandler.rebaselineall.error_handler):
109         (GardeningHTTPRequestHandler):
110
111 2012-07-27  Brady Eidson  <beidson@apple.com>
112
113         Plugins should not be allowed to override standard properties/attributes in non-standard worlds
114         <rdar://problem/11975252> and https://bugs.webkit.org/show_bug.cgi?id=92519
115
116         Reviewed by Anders Carlsson.
117
118         Add a test plugin which overrides all properties it is asked about:
119         * DumpRenderTree/TestNetscapePlugIn/Tests/PluginScriptableObjectOverridesAllProperties.cpp: Added.
120         (PluginScriptableObjectOverridesAllProperties):
121         (PluginScriptableObjectOverridesAllProperties::PluginScriptableObjectOverridesAllProperties):
122         (PluginObject):
123         (PluginScriptableObjectOverridesAllProperties::PluginObject::PluginObject):
124         (PluginScriptableObjectOverridesAllProperties::PluginObject::~PluginObject):
125         (PluginScriptableObjectOverridesAllProperties::PluginObject::hasProperty):
126         (PluginScriptableObjectOverridesAllProperties::PluginObject::getProperty):
127         (PluginScriptableObjectOverridesAllProperties::NPP_GetValue):
128
129         Expose NPN_MemAlloc to the test plugin:
130         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
131         (PluginTest::NPN_MemAlloc):
132         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
133         (PluginTest):
134
135         * DumpRenderTree/DumpRenderTree.gypi:
136         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
137         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
138         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
139
140 2012-07-27  Rafael Brandao  <rafael.lobo@openbossa.org>
141
142         "webkit-patch upload" should strip colors from patch if necessary
143         https://bugs.webkit.org/show_bug.cgi?id=92306
144
145         Reviewed by Adam Barth.
146
147         * Scripts/webkitpy/common/checkout/scm/git.py: Explicity remove colors from diff.
148
149 2012-07-27  Eric Seidel  <eric@webkit.org>
150
151         clean-pending-commit throws exception when encountering Ossy
152         https://bugs.webkit.org/show_bug.cgi?id=92534
153
154         Reviewed by Adam Barth.
155
156         Mark a couple strings as unicode so that reviewers with unicode names do not cause
157         clean-pending-commit to barf.
158
159         * Scripts/webkitpy/tool/commands/upload.py:
160         (CleanPendingCommit._flags_to_clear_on_patch):
161         (CleanPendingCommit.execute):
162         (AssignToCommitter._assign_bug_to_last_patch_attacher):
163
164 2012-07-27  Dirk Pranke  <dpranke@chromium.org>
165
166         chromium win compile broken after removing webkit.py
167         https://bugs.webkit.org/show_bug.cgi?id=92549
168
169         Unreviewed, build fix.
170
171         It turns out that this file is listed in the chromium downstream
172         'browser_tests.isolate' file, and so deleting it broke gyp.
173         Adding a stub file back in until we can remove the entry from
174         the file.
175
176         * Scripts/webkitpy/layout_tests/port/webkit.py: Added.
177
178 2012-07-27  Dirk Pranke  <dpranke@chromium.org>
179
180         nrwt: remove 'webkit.py' and the 'WebKitPort'
181         https://bugs.webkit.org/show_bug.cgi?id=92450
182
183         Reviewed by Ryosuke Niwa.
184
185         This patch finishes the work of merging WebKitPort into Port.
186         Now Port is way too big :).
187
188         This is all cutting and pasting; no new functionality and
189         no changes in the tests.
190
191         * Scripts/webkitpy/layout_tests/port/apple.py:
192         (ApplePort):
193         (ApplePort.__init__):
194         * Scripts/webkitpy/layout_tests/port/base.py:
195         (Port.skipped_layout_tests):
196         (Port):
197         (Port._port_flag_for_scripts):
198         (Port._arguments_for_configuration):
199         (Port._run_script):
200         (Port._build_driver):
201         (Port._build_driver_flags):
202         (Port._tests_for_other_platforms):
203         (Port._runtime_feature_list):
204         (Port.nm_command):
205         (Port._modules_to_search_for_symbols):
206         (Port._symbols_string):
207         (Port._missing_feature_to_skipped_tests):
208         (Port._missing_symbol_to_skipped_tests):
209         (Port._has_test_in_directories):
210         (Port._skipped_tests_for_unsupported_features):
211         (Port._wk2_port_name):
212         (Port._skipped_file_search_paths):
213         * Scripts/webkitpy/layout_tests/port/chromium.py:
214         (ChromiumPort):
215         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
216         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
217         (ChromiumPortTestCase.test_check_build):
218         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
219         * Scripts/webkitpy/layout_tests/port/efl.py:
220         (EflPort):
221         (EflPort.__init__):
222         * Scripts/webkitpy/layout_tests/port/gtk.py:
223         (GtkPort):
224         (GtkPort.setup_environ_for_server):
225         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
226         (TestWebKitPort):
227         (TestWebKitPort.__init__):
228         (TestWebKitPort.all_test_configurations):
229         (TestWebKitPort._symbols_string):
230         (TestWebKitPort._tests_for_other_platforms):
231         (TestWebKitPort._tests_for_disabled_features):
232         (PortTestCase):
233         (PortTestCase.test_diff_image):
234         (PortTestCase.test_path_to_test_expectations_file):
235         (PortTestCase.test_skipped_directories_for_symbols):
236         (test_skipped_directories_for_features):
237         (test_skipped_directories_for_features_no_matching_tests_in_test_list):
238         (test_skipped_tests_for_unsupported_features_empty_test_list):
239         (test_skipped_layout_tests):
240         (test_skipped_file_search_paths):
241         (test_root_option):
242         (test_test_expectations):
243         (test_build_driver):
244         (_assert_config_file_for_platform):
245         (test_linux_distro_detection):
246         (test_apache_config_file_name_for_platform):
247         (test_path_to_apache_config_file):
248         * Scripts/webkitpy/layout_tests/port/qt.py:
249         (QtPort):
250         (QtPort.__init__):
251         (QtPort.setup_environ_for_server):
252         * Scripts/webkitpy/layout_tests/port/webkit.py: Removed.
253         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Removed.
254         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
255         (get_test_baselines.AllPlatformsPort):
256         (get_test_baselines.AllPlatformsPort.__init__):
257         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
258         (get_test_config.TestMacPort):
259
260 2012-07-27  Christophe Dumez  <christophe.dumez@intel.com>
261
262         [WK2][WTR] LayoutTestController.deliverWebIntent() needs to be implemented
263         https://bugs.webkit.org/show_bug.cgi?id=92228
264
265         Reviewed by Anders Carlsson.
266
267         Implement LayoutTestController.deliverWebIntent() to
268         allow test cases to deliver a Web intent and test this
269         functionality.
270
271         This functionality is needed by:
272         - webintents/web-intents-delivery.html
273
274         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
275         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
276         (WTR::LayoutTestController::deliverWebIntent):
277         (WTR):
278         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
279         (LayoutTestController):
280
281 2012-07-27  Jer Noble  <jer.noble@apple.com>
282
283         Unreviewed build fix.
284
285         Wrap MSVC-specific fixes is a COMPILER() check, not a PLATFORM() check.
286
287         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
288
289 2012-07-27  Xianzhu Wang  <wangxianzhu@chromium.org>
290
291         [Chromium-Android] NRWT better handling of DRT deadlocks and crashes
292         https://bugs.webkit.org/show_bug.cgi?id=92299
293
294         Reviewed by Dirk Pranke.
295
296         1. Changed the deadlock detector thread target from a method of driver to a function to avoid its reference to the
297            current driver (see the bug for the problem of the reference.
298         2. Let the deadlock detector thread exit early when the normal_startup_event is set to avoid it from blocking the main thread when the main thread is exiting.
299         3. Extracted common loop until timeout logic into ChromiumAndroidDriver._loop_with_timeout().
300         4. Use the "for i in range(n)" style suggested by dpranke in https://bugs.webkit.org/show_bug.cgi?id=89124 in several functions.
301
302         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
303         (ChromiumAndroidPort.__init__):
304         (ChromiumAndroidPort._run_adb_command): Reduced the verbose output.
305         (ChromiumAndroidDriver.__init__):
306         (ChromiumAndroidDriver._loop_with_timeout): Extracted common loop until timeout logic here.
307         (ChromiumAndroidDriver._all_pipes_created):
308         (ChromiumAndroidDriver._remove_all_pipes):
309         (ChromiumAndroidDriver._start): Changed the retry loop style.
310         (ChromiumAndroidDriver._start_once): Changed the loop style and code related to deadlock detector.
311         (ChromiumAndroidDriver._start_once.deadlock_detector): Moved the original ChromiumAndroidDriver._deadlock_detector() here.
312         (ChromiumAndroidDriver.stop): Changed the loop style.
313
314 2012-07-27  Dirk Pranke  <dpranke@chromium.org>
315
316         nrwt: move collect_tests(), parse_expectations() into manager
317         https://bugs.webkit.org/show_bug.cgi?id=92423
318
319         Reviewed by Ojan Vafai.
320
321         This is the first in a series of patches refactoring
322         run_webkit_tests.py and manager.py to make them more
323         maintainable; all this patch does is move a couple of functions
324         into manager.run_tests() so manager's public interface is
325         simple.
326
327         * Scripts/webkitpy/layout_tests/controllers/manager.py:
328         (Manager._collect_tests):
329         (Manager._parse_expectations):
330         (Manager._split_into_chunks_if_necessary):
331         (Manager.run):
332         (read_test_files):
333         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
334         (ManagerTest.test_http_locking):
335         (ManagerTest.test_perf_locking):
336         (ManagerTest.integration_test_needs_servers.get_manager_with_tests):
337         (ManagerTest.test_look_for_new_crash_logs.get_manager_with_tests):
338         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
339         (run):
340
341 2012-07-27  Dirk Pranke  <dpranke@chromium.org>
342
343         nrwt: print filtered stderr after a crash correctly
344         https://bugs.webkit.org/show_bug.cgi?id=92428
345
346         Reviewed by Adam Barth.
347
348         Some ports will run the stderr output from DRT/WTR through a
349         filter after a crash in order to print a more useful stack
350         trace; while that gets written to the crash log correctly, we
351         don't log it to the debug output properly. This change fixes
352         that and makes it clearer that we're logging stderr, not the
353         crash log.
354
355         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
356         (SingleTestRunner._handle_error):
357         * Scripts/webkitpy/layout_tests/port/base.py:
358         (Port._get_crash_log):
359         * Scripts/webkitpy/layout_tests/port/chromium.py:
360         (ChromiumPort._get_crash_log):
361         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
362         (ChromiumAndroidPortTest.test_get_crash_log):
363         * Scripts/webkitpy/layout_tests/port/driver.py:
364         (Driver.run_test):
365         * Scripts/webkitpy/layout_tests/port/gtk.py:
366         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
367         * Scripts/webkitpy/layout_tests/port/mac.py:
368         (MacPort._get_crash_log):
369         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
370         (PortTestCase.test_get_crash_log):
371
372 2012-07-27  Dirk Pranke  <dpranke@chromium.org>
373
374         nrwt: move image diffing code to a separate module
375         https://bugs.webkit.org/show_bug.cgi?id=92447
376
377         Reviewed by Ryosuke Niwa.
378
379         This patch moves the code to talk to ImageDiff into its own
380         module, and adds more tests for it. In addition, the patch
381         modifies diff_image() so that we don't automatically stop
382         ImageDiff after a single invocation, and thus subsequent
383         diffs may be slightly faster. (Note that the chromium ports
384         don't use any of this code; that is not changed by this patch).
385
386         The main motivation for this change is to move more "generic"
387         code out of the port/* classes, and in particular to move more
388         code out of webkit.py so that we can eventually eliminate it by
389         merging it into base.py.
390
391         This patch also splits MockServerProcess out from driver_unittest.py
392         so that it can be re-used.
393
394         * Scripts/webkitpy/layout_tests/port/base.py:
395         (Port.__init__):
396         (Port.diff_image):
397         (Port.clean_up_test_run):
398         * Scripts/webkitpy/layout_tests/port/driver.py:
399         (Driver.__init__):
400         (Driver._start):
401         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
402         (DriverTest.test_stop_cleans_up_properly):
403         (DriverTest.test_two_starts_cleans_up_properly):
404         (DriverTest.test_start_actually_starts):
405         * Scripts/webkitpy/layout_tests/port/efl.py:
406         (EflPort.clean_up_test_run):
407         * Scripts/webkitpy/layout_tests/port/gtk.py:
408         (GtkPort.clean_up_test_run):
409         * Scripts/webkitpy/layout_tests/port/image_diff.py: Added.
410         (ImageDiffer):
411         (ImageDiffer.__init__):
412         (ImageDiffer.diff_image):
413         (ImageDiffer._start):
414         (ImageDiffer._read):
415         (ImageDiffer.stop):
416         * Scripts/webkitpy/layout_tests/port/image_diff_unittest.py: Added.
417         (for):
418         (FakePort):
419         (FakePort.__init__):
420         (FakePort._path_to_image_diff):
421         (FakePort.setup_environ_for_server):
422         (TestImageDiffer):
423         (TestImageDiffer.test_diff_image):
424         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
425         (MockDRTPortTest.test_diff_image):
426         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
427         (PortTestCase.test_diff_image__missing_both):
428         (PortTestCase.test_diff_image):
429         (PortTestCase.test_diff_image.make_proc):
430         * Scripts/webkitpy/layout_tests/port/server_process.py:
431         (ServerProcess._start):
432         * Scripts/webkitpy/layout_tests/port/server_process_mock.py: Added.
433         (MockServerProcess):
434         (MockServerProcess.__init__):
435         (MockServerProcess.write):
436         (MockServerProcess.has_crashed):
437         (MockServerProcess.read_stdout_line):
438         (MockServerProcess.read_stdout):
439         (MockServerProcess.pop_all_buffered_stderr):
440         (MockServerProcess.read_either_stdout_or_stderr_line):
441         (MockServerProcess.start):
442         (MockServerProcess.stop):
443         (MockServerProcess.kill):
444         * Scripts/webkitpy/layout_tests/port/webkit.py:
445         (WebKitPort._build_driver_flags):
446         (WebKitPort._symbols_string):
447
448 2012-07-27  Tom Hudson  <hudson@google.com>
449
450         Activate committer bit granted April 6th so I can garden.
451         https://bugs.webkit.org/show_bug.cgi?id=92500
452
453         Reviewed by Jochen Eisinger.
454
455         * Scripts/webkitpy/common/config/committers.py:
456
457 2012-07-27  Jer Noble  <jer.noble@apple.com>
458
459         Support a rational time class for use by media elements.
460         https://bugs.webkit.org/show_bug.cgi?id=88787
461
462         Add unit tests for the WTF::MediaTime class.
463
464         Reviewed by Eric Carlson.
465
466         * TestWebKitAPI/GNUmakefile.am:
467         * TestWebKitAPI/TestWebKitAPI.gypi:
468         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
469         * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Added.
470         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
471         (WTF::operator<<):
472         (TestWebKitAPI):
473         (TestWebKitAPI::TEST):
474
475 2012-07-27  Balazs Kelemen  <kbalazs@webkit.org>
476
477         [NRWT] should have a way to restrict pixel tests for individual directories
478         https://bugs.webkit.org/show_bug.cgi?id=91754
479
480         Unreviewed attempt to fix the chaos I introduced.
481
482         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
483         (WebCore::DumpRenderTree::processLine):
484
485 2012-07-27  YoungTaeck Song  <youngtaeck.song@samsung.com>
486
487         [WK2][EFL] Add an ACCELERATED_COMPOSITING implementation for Efl WebKit2
488         https://bugs.webkit.org/show_bug.cgi?id=91581
489
490         Reviewed by Noam Rosenthal.
491
492         Add a MiniBrowser's option for selecting evas engine.
493
494         * MiniBrowser/efl/main.c:
495         (browserCreate):
496         (main):
497
498 2012-07-27  Sheriff Bot  <webkit.review.bot@gmail.com>
499
500         Unreviewed, rolling out r123869.
501         http://trac.webkit.org/changeset/123869
502         https://bugs.webkit.org/show_bug.cgi?id=92501
503
504         "it did not fix anything but made things even worst"
505         (Requested by kbalazs on #webkit).
506
507         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
508         (WebCore::DumpRenderTree::DumpRenderTree):
509         (WebCore::DumpRenderTree::open):
510         (WebCore::DumpRenderTree::processLine):
511         (WebCore::DumpRenderTree::setDumpPixelsForAllTests):
512         (WebCore::DumpRenderTree::dump):
513         * DumpRenderTree/qt/DumpRenderTreeQt.h:
514         (DumpRenderTree):
515         * DumpRenderTree/qt/main.cpp:
516         (main):
517         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
518         (SingleTestRunner._should_fetch_expected_checksum):
519         (SingleTestRunner._overwrite_baselines):
520         (SingleTestRunner._compare_output):
521         * Scripts/webkitpy/layout_tests/controllers/worker.py:
522         (Worker._update_test_input):
523         * Scripts/webkitpy/layout_tests/port/base.py:
524         (Port.supports_switching_pixel_tests_per_test):
525         (Port):
526         (Port._supports_switching_pixel_tests_per_test):
527         (Port.should_run_as_pixel_test):
528         (Port._should_run_as_pixel_test):
529         * Scripts/webkitpy/layout_tests/port/driver.py:
530         (Driver.cmd_line):
531         (Driver._command_from_driver_input):
532         * Scripts/webkitpy/layout_tests/port/qt.py:
533         (QtPort.check_sys_deps):
534         (QtPort):
535         (QtPort._supports_switching_pixel_tests_per_test):
536         (QtPort._should_run_as_pixel_test):
537         (QtPort._default_pixel_test_directories):
538         * Scripts/webkitpy/layout_tests/port/test.py:
539         (TestPort.supports_switching_pixel_tests_per_test):
540         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
541         (_set_up_derived_options):
542         (parse_args):
543         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
544         (MainTest.test_run_singly_actually_runs_tests):
545         (MainTest.test_pixel_test_directories):
546         * WebKitTestRunner/TestController.cpp:
547         (WTR::TestController::TestController):
548         (WTR::TestController::initialize):
549         (WTR::TestController::runTest):
550         * WebKitTestRunner/TestController.h:
551         (TestController):
552
553 2012-07-27  Balazs Kelemen  <kbalazs@webkit.org>
554
555         [NRWT] should have a way to restrict pixel tests for individual directories
556         https://bugs.webkit.org/show_bug.cgi?id=91754
557
558         Reviewed by Zoltan Herczeg.
559
560         Rollout r123729 because it made Qt debug bots crasy.
561
562         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
563         (WebCore::DumpRenderTree::DumpRenderTree):
564         (WebCore::DumpRenderTree::open):
565         (WebCore::DumpRenderTree::processLine):
566         (WebCore::DumpRenderTree::setDumpPixels):
567         (WebCore::DumpRenderTree::dump):
568         * DumpRenderTree/qt/DumpRenderTreeQt.h:
569         (DumpRenderTree):
570         * DumpRenderTree/qt/main.cpp:
571         (main):
572         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
573         (SingleTestRunner._should_fetch_expected_checksum):
574         (SingleTestRunner._overwrite_baselines):
575         (SingleTestRunner._compare_output):
576         * Scripts/webkitpy/layout_tests/controllers/worker.py:
577         (Worker._update_test_input):
578         * Scripts/webkitpy/layout_tests/port/base.py:
579         (Port.lookup_virtual_test_args):
580         * Scripts/webkitpy/layout_tests/port/driver.py:
581         (Driver.cmd_line):
582         (Driver._command_from_driver_input):
583         * Scripts/webkitpy/layout_tests/port/qt.py:
584         (QtPort.check_sys_deps):
585         * Scripts/webkitpy/layout_tests/port/test.py:
586         (TestPort.virtual_test_suites):
587         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
588         (_set_up_derived_options):
589         (parse_args):
590         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
591         (MainTest.test_run_singly_actually_runs_tests):
592         (MainTest.test_missing_and_unexpected_results):
593         * WebKitTestRunner/TestController.cpp:
594         (WTR::TestController::TestController):
595         (WTR::TestController::initialize):
596         (WTR::TestController::runTest):
597         * WebKitTestRunner/TestController.h:
598         (TestController):
599
600 2012-07-27  Adam Barth  <abarth@webkit.org>
601
602         webkit.review.bot should run clean-review-queue and clean-pending-commit periodically
603         https://bugs.webkit.org/show_bug.cgi?id=92472
604
605         Reviewed by Eric Seidel.
606
607         We need to run these command periodically to keep cruft from
608         accumulating in bugs.webkit.org. Rather than running them manually, we
609         should just have a bot run them. This patch has the style-queue run the
610         commands, which admittedly is a bit odd but it doesn't seem worthwhile
611         to create another bot specifically for this purposes.
612
613         * Scripts/webkitpy/tool/commands/queues.py:
614         (AbstractReviewQueue):
615         (StyleQueue.begin_work_queue):
616         (StyleQueue):
617         (StyleQueue.clean_bugzilla):
618         * Scripts/webkitpy/tool/commands/queues_unittest.py:
619         (StyleQueueTest.test_style_queue_with_style_exception):
620         (test_style_queue_with_watch_list_exception):
621
622 2012-07-27  Dominik Röttsches  <dominik.rottsches@intel.com>
623
624         [Cairo] Add complex font drawing using HarfbuzzNG
625         https://bugs.webkit.org/show_bug.cgi?id=91864
626
627         Reviewed by Simon Hausmann and Martin Robinson.
628
629         Bringing Harfbuzz support to EFL with this patch, so we need HarfBuzz in the pulled in jhbuild dependencies.
630
631         * WebKitTestRunner/CMakeLists.txt: Adding additional header include directories.
632         * efl/jhbuild.modules: Adding source for HarfBuzz release version 0.9.0.
633
634 2012-07-27  KwangYong Choi  <ky0.choi@samsung.com>
635
636         [WK2][EFL][WTR] TestNetscapePlugin is required.
637         https://bugs.webkit.org/show_bug.cgi?id=88756
638
639         Reviewed by Simon Hausmann.
640
641         libTestNetscapePlugin.so should be required for DRT/WTR/EFL.
642
643         * CMakeLists.txt:
644         * DumpRenderTree/TestNetscapePlugin/CMakeList.txt:
645
646 2012-07-27  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
647
648         [EFL] Memory leaks in EFL DRT
649         https://bugs.webkit.org/show_bug.cgi?id=92347
650
651         Reviewed by Simon Hausmann.
652
653         Fix a memory leak in EFL's DRT code by adopting an allocation
654         of JSString created with JSStringCreateWithUTF8CString.
655
656         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
657         (DumpRenderTreeChrome::onWindowObjectCleared):
658
659 2012-07-27  Adam Barth  <abarth@webkit.org>
660
661         Simplify ExpectedFailures
662         https://bugs.webkit.org/show_bug.cgi?id=92216
663
664         Reviewed by Eric Seidel.
665
666         This patch simplifies the ExpectedFailures class we use to remember
667         which tests are currently failing on the bots. When we wrote this code
668         originally, we weren't entirely sure how it would work. Now that we
669         understand it more clearly, we can write the code more clearly.
670
671         * Scripts/webkitpy/tool/bot/expectedfailures.py:
672         (_has_failures):
673         (_is_trustworthy):
674         (ExpectedFailures.__init__):
675         (ExpectedFailures.failures_were_expected):
676         (ExpectedFailures.unexpected_failures_observed):
677         (ExpectedFailures.update):
678         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
679         (ExpectedFailuresTest._assert_can_trust):
680         (ExpectedFailuresTest.test_failures_were_expected):
681         (ExpectedFailuresTest.test_unexpected_failures_observed):
682         (ExpectedFailuresTest.test_unexpected_failures_observed_when_tree_is_hosed):
683         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
684         (PatchAnalysisTask._test):
685         (PatchAnalysisTask._build_and_test_without_patch):
686         (PatchAnalysisTask._test_patch):
687
688 2012-07-27  Csaba Osztrogonác  <ossy@webkit.org>
689
690         [Qt][WK2] REGRESSION(r119127): resetting window.internals settings between tests doesn't work properly
691         https://bugs.webkit.org/show_bug.cgi?id=88064
692
693         Reviewed by Zoltan Herczeg.
694
695         Use resetInternalsObject() instead of injectInternalsObject().
696
697         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
698         (WTR::InjectedBundlePage::resetAfterTest):
699
700 2012-07-26  Ryuan Choi  <ryuan.choi@samsung.com>
701
702         [EFL] Remove forwarding headers from MiniBrowser/Efl.
703         https://bugs.webkit.org/show_bug.cgi?id=91627
704
705         Reviewed by Kentaro Hara.
706
707         * MiniBrowser/efl/CMakeLists.txt: Remove unnecessary forwarding headers.
708
709 2012-07-26  Yoshifumi Inoue  <yosin@chromium.org>
710
711         [Forms] Introduce runtime feature flags for input type datetime, datetimelocal, month, time, week
712         https://bugs.webkit.org/show_bug.cgi?id=92339
713
714         Reviewed by Kent Tamura.
715
716         This patch enables runtime features for input type datetime, datetime-local,
717         month, time and week for Chromium DRT.
718
719         * DumpRenderTree/chromium/TestShell.cpp:
720         (TestShell::TestShell): Call enableInputType{DateTime,DateTimeLocal,Month,Time,Week}.
721
722 2012-07-26  Jeffrey Pfau  <jpfau@apple.com>
723
724         Reloading substitute-data/alternate html string for unreachableURL will add an item to the back-forward-history for each reload
725         https://bugs.webkit.org/show_bug.cgi?id=84041
726
727         Reviewed by Brady Eidson.
728
729         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
730         * TestWebKitAPI/Tests/mac/BackForwardList.mm: Added.
731         (-[BackForwardListTest webView:didFinishLoadForFrame:]):
732         (-[BackForwardListTest webView:didFailProvisionalLoadWithError:forFrame:]):
733         (TestWebKitAPI):
734         (TestWebKitAPI::TEST):
735
736 2012-07-26  Sheriff Bot  <webkit.review.bot@gmail.com>
737
738         Unreviewed, rolling out r123799.
739         http://trac.webkit.org/changeset/123799
740         https://bugs.webkit.org/show_bug.cgi?id=92431
741
742         broke the Apple Mac build (Requested by bweinstein on
743         #webkit).
744
745         * DumpRenderTree/chromium/TestWebPlugin.cpp:
746         * DumpRenderTree/chromium/TestWebPlugin.h:
747         (TestWebPlugin::acceptsInputEvents):
748         (TestWebPlugin::handleInputEvent):
749
750 2012-07-26  Dirk Pranke  <dpranke@chromium.org>
751
752         nrwt: pass --verbose twice on the bots to ensure getting the debug output for now
753         https://bugs.webkit.org/show_bug.cgi?id=92172
754
755         Reviewed by Tony Chang.
756
757         Right now new-run-webkit-tests --verbose prints out too much
758         information (it's like --verbose + debugging). I plan to fix
759         this in bug 88702, and also clean up and simplify all of the
760         --print options, but in preparation for these changes I need to
761         pass --verbose twice to get the same level of output
762         temporarily (for compatibility).
763
764         * Scripts/run-webkit-tests:
765
766 2012-07-26  Sadrul Habib Chowdhury  <sadrul@chromium.org>
767
768         Propagate gesture events to plugins.
769         https://bugs.webkit.org/show_bug.cgi?id=92281
770
771         Reviewed by Adam Barth.
772
773         Update TestWebPlugin to receive events, and output logs for the events.
774
775         * DumpRenderTree/chromium/TestWebPlugin.cpp:
776         (TestWebPlugin::handleInputEvent):
777         * DumpRenderTree/chromium/TestWebPlugin.h:
778         (TestWebPlugin::acceptsInputEvents):
779         (TestWebPlugin):
780
781 2012-07-26  Balazs Kelemen  <kbalazs@webkit.org>
782
783         [nrwt] get rid of --skip-pixel-test-if-no-baseline
784         https://bugs.webkit.org/show_bug.cgi?id=92377
785
786         Reviewed by Adam Barth.
787
788         Remove the option and all code paths that handled it.
789
790         * Scripts/webkitpy/layout_tests/port/base.py:
791         (Port.should_run_as_pixel_test):
792         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
793         (_set_up_derived_options):
794         (parse_args):
795         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
796         (MainTest.test_repeat_each):
797
798 2012-07-26  Olivier Blin  <olivier.blin@softathome.com>
799
800         Add FastMalloc statistics in window.internals
801         https://bugs.webkit.org/show_bug.cgi?id=91274
802
803         Reviewed by Ryosuke Niwa.
804
805         * GNUmakefile.am:
806
807 2012-07-26  Olivier Blin  <olivier.blin@softathome.com>
808
809         Add FastMalloc statistics in window.internals
810         https://bugs.webkit.org/show_bug.cgi?id=91274
811
812         Reviewed by Ryosuke Niwa.
813
814         * GNUmakefile.am:
815
816 2012-07-20  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
817
818         buildbot: Remove the configuration of hfreyther*
819         https://bugs.webkit.org/show_bug.cgi?id=91849
820
821         Reviewed by Adam Roben.
822
823         The machine running these configs was decommissioned and
824         there is no replacement at this point. Remove them from the
825         configuration.
826
827         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove hfreyther* from
828         the config. The Qt Linux SH4 and Qt Linux MIPS schedulers are orphaned, remove
829         them too.
830
831 2012-07-26  Balazs Kelemen  <kbalazs@webkit.org>
832
833         Unreviewed speculative Mac buildfix after r123729 - 2nd attempt.
834
835         * WebKitTestRunner/TestController.cpp:
836         (WTR::TestController::runTest):
837
838 2012-07-26  Balazs Kelemen  <kbalazs@webkit.org>
839
840         Unreviewed speculative buildfix after r123729.
841
842         * WebKitTestRunner/TestController.cpp:
843         (WTR::TestController::runTest): Fix sign errors.
844
845 2012-07-26  Zoltan Nyul  <zoltan.nyul@intel.com>
846
847         [EFL] EFL port should use XDG paths
848         https://bugs.webkit.org/show_bug.cgi?id=91719
849
850         Reviewed by Kenneth Rohde Christiansen.
851
852         The appcache/localstorage/webdatabase path should be set in the
853         ewk_main.cpp instead of the DumpRenderTree, and the XDG_DATA_HOME and
854         XDG_CACHE_HOME should be set to different directory for each processes
855         for the layout-tests.
856
857         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
858         (DumpRenderTreeChrome::initialize):
859         * Scripts/webkitpy/layout_tests/port/efl.py:
860         (EflPort.setup_environ_for_server):
861         * efl/jhbuild.modules:
862
863 2012-07-26  Balazs Kelemen  <kbalazs@webkit.org>
864
865         [NRWT] should have a way to restrict pixel tests for individual directories
866         https://bugs.webkit.org/show_bug.cgi?id=91754
867
868         Reviewed by Dirk Pranke.
869
870         Added --pixel-test-directories option to nrwt. It implies --pixel-tests.
871         If the platform supports this option only tests from these directories will
872         be executed as pixel tests. Furthermore, platforms can have a default set of
873         pixel test directories. To support the feature the test harness have to be
874         able to inform the driver whether to dump pixels for each tests. For this
875         purpose I changed WTR and the Qt DRT to handle a --pixel-test argument from
876         the standard output and made NRWT use this argument with these drivers.
877
878         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
879         (WebCore::DumpRenderTree::DumpRenderTree):
880         (WebCore::DumpRenderTree::open):
881         (WebCore::DumpRenderTree::processLine):
882         (WebCore::DumpRenderTree::setDumpPixelsForAllTests):
883         (WebCore::DumpRenderTree::dump):
884         * DumpRenderTree/qt/DumpRenderTreeQt.h:
885         (DumpRenderTree):
886         * DumpRenderTree/qt/main.cpp:
887         (main):
888         Handle the --pixel-test argument.
889
890         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
891         (SingleTestRunner._should_fetch_expected_checksum):
892         (SingleTestRunner._overwrite_baselines):
893         (SingleTestRunner._compare_output):
894         * Scripts/webkitpy/layout_tests/controllers/worker.py:
895         (Worker._update_test_input):
896         * Scripts/webkitpy/layout_tests/port/base.py:
897         (Port.supports_switching_pixel_tests_per_test): Ports can override this to inform
898         the harness that --pixel-test argument is supported. True for WTR, otherwise calls
899         private version that can be overridden by the actual platform. Only true with WTR
900         and Qt DRT currently. This supposed to exist only temporary until there are ports
901         that doesn't support the feature in their DRT's.
902         (Port):
903         (Port._supports_switching_pixel_tests_per_test):
904         (Port.should_run_as_pixel_test):
905         (Port._should_run_as_pixel_test): Ports can override this to define their
906         default set of pixel tests directories.
907         * Scripts/webkitpy/layout_tests/port/driver.py:
908         (Driver.cmd_line): Don't pass --pixel-tests if the platform supports per test
909         --pixel-test.
910         (Driver._command_from_driver_input): Pass --pixel-test if it is supported and pixel
911         tests are enabled.
912         * Scripts/webkitpy/layout_tests/port/qt.py:
913         (QtPort.check_sys_deps):
914         (QtPort):
915         (QtPort._supports_switching_pixel_tests_per_test):
916         (QtPort._should_run_as_pixel_test):
917         (QtPort._default_pixel_test_directories): Only compositing will be our default pixel
918         test directory for the time being.
919         * Scripts/webkitpy/layout_tests/port/test.py:
920         (TestPort.supports_switching_pixel_tests_per_test):
921         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
922         (_set_up_derived_options):
923         (parse_args):
924         Handle the --pixel-test-directory option. It expect a directory below LayoutTests
925         and can be specified multiple times. Added fixme's that we should improve how we
926         handle these arguments.
927
928         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
929         (MainTest.test_run_singly_actually_runs_tests):
930         (MainTest.test_pixel_test_directories):
931         Added an integration test for the feature.
932
933         * WebKitTestRunner/TestController.cpp:
934         (WTR::TestController::TestController):
935         (WTR::TestController::initialize):
936         (WTR::TestController::runTest):
937         * WebKitTestRunner/TestController.h:
938         (TestController):
939         Handle the --pixel-test argument.
940
941 2012-07-26  Christophe Dumez  <christophe.dumez@intel.com>
942
943         [EFL] Regression(r123604): webintents/web-intents-obj-constructor.html is crashing
944         https://bugs.webkit.org/show_bug.cgi?id=92349
945
946         Reviewed by Kentaro Hara.
947
948         Fix crash occurring after r123604, which replaced strdup()
949         usage with eina_stringshare_add(). Unfortunately, the DRT
950         was not updated accordingly to use eina_stringshare_del()
951         instead of free() on the values returned by Ewk_Intent
952         getters and it was causing
953         webintents/web-intents-obj-constructor.html to crash.
954
955         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
956         (DumpRenderTreeChrome::onFrameIntentNew):
957
958 2012-07-26  Adam Barth  <abarth@webkit.org>
959
960         Unreviewed attempt to fix the chromium-win build.
961
962         * DumpRenderTree/chromium/TestRunner/TestRunner.cpp:
963
964 2012-07-26  Kaustubh Atrawalkar  <kaustubh@motorola.com>
965
966         [DRT] LTC:: pageNumberForElementById() could be moved to Internals
967         https://bugs.webkit.org/show_bug.cgi?id=92091
968
969         Reviewed by Adam Barth.
970
971         Move the pageNumberForElementById from LayoutTestCotroller to Internals and
972         remove the old platform specific implementations as it exclusively tests WebCore functionality.
973
974         * DumpRenderTree/LayoutTestController.cpp:
975         (LayoutTestController::staticFunctions):
976         * DumpRenderTree/LayoutTestController.h:
977         (LayoutTestController):
978         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
979         * DumpRenderTree/chromium/LayoutTestController.cpp:
980         (LayoutTestController::LayoutTestController):
981         (LayoutTestController::setPrinting):
982         * DumpRenderTree/chromium/LayoutTestController.h:
983         (LayoutTestController):
984         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
985         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
986         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
987         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
988         * DumpRenderTree/qt/LayoutTestControllerQt.h:
989         (LayoutTestController):
990         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
991         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
992         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
993         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
994         (WTR):
995         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
996         (LayoutTestController):
997
998 2012-07-25  Adam Barth  <abarth@webkit.org>
999
1000         TestRunner.a should contain a TestRunner object
1001         https://bugs.webkit.org/show_bug.cgi?id=92313
1002
1003         Reviewed by Kent Tamura.
1004
1005         This patch adds a stub implementation of TestRunner, which is the new
1006         home for our implementation of window.testRunner. A future patch will
1007         migrate functions from LayoutTestController to TestRunner.
1008
1009         * DumpRenderTree/DumpRenderTree.gypi:
1010         * DumpRenderTree/chromium/LayoutTestController.h:
1011         * DumpRenderTree/chromium/TestRunner/TestRunner.cpp: Added.
1012         * DumpRenderTree/chromium/TestRunner/TestRunner.h: Added.
1013
1014 2012-07-25  Wei James  <james.wei@intel.com>
1015
1016         [Chromium] Fix infinite loop issue for chromium android layout test
1017         https://bugs.webkit.org/show_bug.cgi?id=92197
1018
1019         Reviewed by Adam Barth.
1020
1021         The change brought in by r123530 will cause infinite loop when running
1022         Chromium Android Layout Test.
1023         Revert the change for this line only.
1024
1025         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1026         (ChromiumAndroidPort._build_path):
1027
1028 2012-07-25  Adam Barth  <abarth@webkit.org>
1029
1030         Jochen is our a newest reviewer!
1031
1032         * Scripts/webkitpy/common/config/committers.py:
1033
1034 2012-07-25  Jochen Eisinger  <jochen@chromium.org>
1035
1036         [chromium] don't use webkit_support methods directly from test runners but through the test delegate
1037         https://bugs.webkit.org/show_bug.cgi?id=92256
1038
1039         Reviewed by Adam Barth.
1040
1041         This will allow for the content_shell to provide its own implementation
1042         for setting the Gamepad data instead.
1043
1044         * DumpRenderTree/chromium/TestRunner/GamepadController.cpp:
1045         (GamepadController::setDelegate):
1046         (GamepadController::reset):
1047         (GamepadController::connect):
1048         (GamepadController::disconnect):
1049         (GamepadController::setId):
1050         (GamepadController::setButtonCount):
1051         (GamepadController::setButtonData):
1052         (GamepadController::setAxisCount):
1053         (GamepadController::setAxisData):
1054         * DumpRenderTree/chromium/TestRunner/GamepadController.h:
1055         (GamepadController):
1056         * DumpRenderTree/chromium/TestRunner/TestDelegate.h:
1057         (WebKit):
1058         (TestDelegate):
1059         * DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
1060         (TestInterfaces::Internal):
1061         (TestInterfaces::Internal::~Internal):
1062         (TestInterfaces::Internal::setDelegate):
1063         (TestInterfaces::setDelegate):
1064         * DumpRenderTree/chromium/TestRunner/TestInterfaces.h:
1065         (TestInterfaces):
1066         * DumpRenderTree/chromium/TestShell.cpp:
1067         (TestShell::createMainWindow):
1068         (TestShell::~TestShell):
1069         * DumpRenderTree/chromium/WebViewHost.cpp:
1070         (WebViewHost::setGamepadData):
1071         * DumpRenderTree/chromium/WebViewHost.h:
1072         (WebViewHost):
1073
1074 2012-07-25  Christophe Dumez  <christophe.dumez@intel.com>
1075
1076         [WK2][WTR] LayoutTestController.sendWebIntentResponse() needs to be implemented
1077         https://bugs.webkit.org/show_bug.cgi?id=92227
1078
1079         Reviewed by Kenneth Rohde Christiansen.
1080
1081         Implement LayoutTestController.sendWebIntentResponse() so
1082         that a test case can reply to a Web intent request and
1083         test this functionality.
1084
1085         In order to support this functionality, we need to keep
1086         a pointer to the current intent request in
1087         InjectedBundlePage::didReceiveIntentForFrame() so that
1088         we can reuse it later in
1089         LayoutTestController::sendWebIntentResponse().
1090
1091         The following tests need this functionality:
1092         - webintents/web-intents-failure.html
1093         - webintents/web-intents-reply.html
1094
1095         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1096         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1097         (WTR::InjectedBundlePage::didReceiveIntentForFrame):
1098         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1099         (InjectedBundlePage):
1100         (WTR::InjectedBundlePage::currentIntentRequest):
1101         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1102         (WTR::LayoutTestController::sendWebIntentResponse):
1103         (WTR):
1104         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1105         (LayoutTestController):
1106
1107 2012-07-25  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1108
1109         [EFL][WK2][WTR] Alt, Shift and Ctrl keys are not handled by EventSenderProxy.
1110         https://bugs.webkit.org/show_bug.cgi?id=92241
1111
1112         Reviewed by Kenneth Rohde Christiansen.
1113
1114         Alt, Shift and Ctrl keys were not handled by EventSenderProxy.
1115         It caused failure of fast/events/keydown-leftright-keys.html test.
1116
1117         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Added handling of Alt, Shift and Ctrl keys.
1118         (WTR::keyName):
1119
1120 2012-07-25  Christophe Dumez  <christophe.dumez@intel.com>
1121
1122         [EFL][WK2] Fix timeout issues when debugging WebProcess.
1123         https://bugs.webkit.org/show_bug.cgi?id=92245
1124
1125         Reviewed by Dirk Pranke.
1126
1127         Fix timeout issues when debugging the WebProcess
1128         under valgrind or gdb.
1129
1130         * Scripts/webkitpy/layout_tests/port/efl.py:
1131         (EflPort.default_timeout_ms):
1132         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1133         (WTR::TestController::platformInitialize):
1134
1135 2012-07-25  Xianzhu Wang  <wangxianzhu@chromium.org>
1136
1137         [Chromium-Android] NRWT driver should not restart between reftests
1138         https://bugs.webkit.org/show_bug.cgi?id=92267
1139
1140         Reviewed by Dirk Pranke.
1141
1142         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1143         (ChromiumAndroidDriver.start): Resets self._pixel_tests when the pixel_tests parameter changes.
1144
1145 2012-07-25  Tommy Widenflycht  <tommyw@google.com>
1146
1147         MediaStream API: Update MediaStreamTrack to match the specification
1148         https://bugs.webkit.org/show_bug.cgi?id=90180
1149
1150         Reviewed by Adam Barth.
1151
1152         Adding a Mock WebMediaStreamCenter to enable better LayoutTests.
1153
1154         * DumpRenderTree/DumpRenderTree.gypi:
1155         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
1156         (MockWebKitPlatformSupport::createMediaStreamCenter):
1157         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp: Added.
1158         (WebKit):
1159         (WebKit::MockWebMediaStreamCenter::MockWebMediaStreamCenter):
1160         (WebKit::MockWebMediaStreamCenter::queryMediaStreamSources):
1161         (WebKit::MockWebMediaStreamCenter::didEnableMediaStreamTrack):
1162         (WebKit::MockWebMediaStreamCenter::didDisableMediaStreamTrack):
1163         (WebKit::MockWebMediaStreamCenter::didStopLocalMediaStream):
1164         (WebKit::MockWebMediaStreamCenter::didCreateMediaStream):
1165         (WebKit::MockWebMediaStreamCenter::constructSDP):
1166         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp.
1167         (WebKit):
1168         (MockWebMediaStreamCenter):
1169         (WebKit::MockWebMediaStreamCenter::MockWebMediaStreamCenter):
1170
1171 2012-07-25  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1172
1173         [NRWT] Rename baseline_search_path() to default_baseline_search_path()
1174         https://bugs.webkit.org/show_bug.cgi?id=92122
1175
1176         Reviewed by Dirk Pranke.
1177
1178         * Scripts/webkitpy/layout_tests/port/base.py:
1179         (Port.baseline_version_dir):
1180         (Port.baseline_search_path):
1181         (Port):
1182         (Port.default_baseline_search_path):
1183         (Port.expected_baselines):
1184         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1185         (PortTest.test_additional_platform_directory):
1186         * Scripts/webkitpy/layout_tests/port/mac.py:
1187         (MacPort.default_baseline_search_path):
1188         * Scripts/webkitpy/layout_tests/port/qt.py:
1189         (QtPort.default_baseline_search_path):
1190         * Scripts/webkitpy/layout_tests/port/win.py:
1191         (WinPort.default_baseline_search_path):
1192
1193 2012-07-25  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1194
1195         [EFL] Use eina_stringshare_add instead of strdup.
1196         https://bugs.webkit.org/show_bug.cgi?id=92072
1197
1198         Reviewed by Kentaro Hara.
1199
1200         Eina of EFL libraries supports a string functionality that replaces strdup. So, EFL port needs
1201         to replace strdup with eina_stringshare_add function.
1202
1203         DumpRenderTree also needs to be modified according to ewk APIs's parameter change.
1204
1205         * DumpRenderTree/efl/DumpRenderTree.cpp:
1206         (dumpFramesAsText):
1207         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1208         (DumpRenderTreeChrome::onFrameIntentNew):
1209         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1210         (onJavaScriptPrompt):
1211
1212 2012-07-25  Alexander Shalamov  <alexander.shalamov@intel.com>
1213
1214         [WTR][EFL] Wheel events are not emitted
1215         https://bugs.webkit.org/show_bug.cgi?id=92094
1216
1217         Reviewed by Csaba Osztrogonác.
1218
1219         Wheel events are not emitted, therefore, layout tests that use mouseScrollBy method are failing.
1220
1221         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
1222         (WTR::dispatchMouseScrollByEvent):
1223         (WTR::EventSenderProxy::mouseScrollBy):
1224         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1225         (WTR::PlatformWebView::PlatformWebView):
1226         (WTR::PlatformWebView::focus):
1227
1228 2012-07-25  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1229
1230         [EFL][WK2] Add ewk_main.{cpp,h} to EFL WK2
1231         https://bugs.webkit.org/show_bug.cgi?id=92101
1232
1233         Reviewed by Kenneth Rohde Christiansen.
1234
1235         Added a centralized place for general initialization in UI process for EFL WK2.
1236
1237         * MiniBrowser/efl/main.c: Added using of newly added ewk_init() and ewk_shutdown() functions.
1238         (main):
1239         * WebKitTestRunner/efl/main.cpp: Ditto.
1240         (main):
1241
1242 2012-07-24  Benjamin Poulain  <bpoulain@apple.com> && Joseph Pecoraro  <pecoraro@apple.com>
1243
1244         QualifiedName's HashSet should be big enough to hold at least all the static names
1245         https://bugs.webkit.org/show_bug.cgi?id=91891
1246
1247         Reviewed by Darin Adler.
1248
1249         Add a test for WTF::hashTableCapacityForSize.
1250
1251         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1252         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Added.
1253         (InitialCapacityTestHashTraits):
1254         (TestWebKitAPI::testInitialCapacity):
1255         (TestWebKitAPI::generateTestCapacityUpToSize):
1256         (TestWebKitAPI::TEST):
1257
1258 2012-07-24  Adam Barth  <abarth@webkit.org>
1259
1260         The EWS bots get flaky when we hit the failure limit
1261         https://bugs.webkit.org/show_bug.cgi?id=92212
1262
1263         Reviewed by Eric Seidel.
1264
1265         Previously we were missing some failure types, which means we didn't
1266         notice that the bots were hitting the failure limit.
1267
1268         * Scripts/webkitpy/common/net/layouttestresults.py:
1269         (LayoutTestResults.failing_test_results):
1270         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1271         (LayoutTestResultsTest.test_results_from_string):
1272         (LayoutTestResultsTest.test_tests_matching_failure_types):
1273
1274 2012-07-24  Raphael Kubo da Costa  <rakuco@webkit.org>
1275
1276         [EFL] Unreviewed build fix.
1277
1278         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Include unistd.h
1279         for usleep(3).
1280
1281 2012-07-24  Dirk Pranke  <dpranke@chromium.org>
1282
1283         make test-webkitpy at least kinda work in parallel on win32
1284         https://bugs.webkit.org/show_bug.cgi?id=91700
1285
1286         Reviewed by Adam Barth.
1287
1288         This change makes the hoop-jumping we have to do to make running
1289         new-run-webkit-tests in parallel on win32 generic so that we can
1290         re-use it for test-webkitpy as well.
1291
1292         * Scripts/new-run-webkit-tests:
1293         * Scripts/test-webkitpy:
1294         * Scripts/webkitpy/common/multiprocessing_bootstrap.py: Copied from Tools/Scripts/new-run-webkit-tests.
1295         (run):
1296         * Scripts/webkitpy/test/main.py:
1297         (main):
1298         (Tester._log_exception):
1299
1300 2012-07-24  Sheriff Bot  <webkit.review.bot@gmail.com>
1301
1302         Unreviewed, rolling out r123499.
1303         http://trac.webkit.org/changeset/123499
1304         https://bugs.webkit.org/show_bug.cgi?id=92161
1305
1306         Android fails to compile (Requested by zhenyao on #webkit).
1307
1308         * DumpRenderTree/DumpRenderTree.gypi:
1309         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
1310         (MockWebKitPlatformSupport::createMediaStreamCenter):
1311         * DumpRenderTree/chromium/MockWebKitPlatformSupport.h:
1312         (MockWebKitPlatformSupport):
1313         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp: Removed.
1314         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h: Removed.
1315
1316 2012-07-24  Dirk Pranke  <dpranke@chromium.org>
1317
1318         nrwt: never finds binaries in the 'out' dir on chromium win
1319         https://bugs.webkit.org/show_bug.cgi?id=91890
1320
1321         Reviewed by Tony Chang.
1322
1323         Attempt to fix this bug yet again; it turns out that --root and
1324         --build-directory don't have the same meaning (--root should
1325         include the configuration, --build-directory should not).
1326
1327         * Scripts/webkitpy/layout_tests/port/base.py:
1328         (Port._build_path):
1329         * Scripts/webkitpy/layout_tests/port/chromium.py:
1330         (ChromiumPort._static_build_path):
1331         (ChromiumPort.default_results_directory):
1332         (ChromiumPort._build_path):
1333         (ChromiumPort):
1334         (ChromiumPort._build_path_with_configuration):
1335         (ChromiumPort._build_path_with_configuration.does):
1336         (ChromiumPort._path_to_image_diff):
1337         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1338         (ChromiumAndroidPort._build_path):
1339         (ChromiumAndroidPort):
1340         (ChromiumAndroidPort._build_path_with_configuration):
1341         (ChromiumAndroidPort._path_to_driver):
1342         (ChromiumAndroidPort._path_to_forwarder):
1343         (ChromiumAndroidPort._push_executable):
1344         (ChromiumAndroidPort._push_fonts):
1345         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1346         (ChromiumLinuxPort._determine_driver_path_statically):
1347         (ChromiumLinuxPort._modules_to_search_for_symbols):
1348         (ChromiumLinuxPort._path_to_driver):
1349         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1350         (ChromiumLinuxPortTest.test_build_path):
1351         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1352         (ChromiumMacPort._modules_to_search_for_symbols):
1353         (ChromiumMacPort._path_to_driver):
1354         (ChromiumMacPort._path_to_helper):
1355         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1356         (ChromiumMacPortTest.test_build_path):
1357         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1358         (ChromiumWinPort._path_to_driver):
1359         (ChromiumWinPort._path_to_helper):
1360         (ChromiumWinPort._path_to_image_diff):
1361         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1362         (ChromiumWinTest.test_build_path):
1363         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1364         (parse_args):
1365
1366 2012-07-24  Peter Beverloo  <peter@chromium.org>
1367
1368         Android-chromium layout tests failing with GPU related crash
1369         https://bugs.webkit.org/show_bug.cgi?id=92126
1370
1371         Reviewed by Adam Barth.
1372
1373         Remove support for the "--enable-hardware-gpu" flag from run_webkit_tests,
1374         as it's not being used by any port anymore, and neither is being passed
1375         on to the test runner. Instead, append the flag directly to DRT for the
1376         Chromium Android port, which does rely on this functionality.
1377
1378         The ChromiumAndroidUnitTest tests didn't catch this as the property was
1379         set to True, but it's unable to detect whether they'll actually be used.
1380         No occurrances of "--enable-hardware-gpu" exist in either Tools/Scripts/
1381         or Tools/BuildSlaveSupport/, so nothing upstream seems to rely on the flag.
1382
1383         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1384         (ChromiumAndroidPort.__init__):
1385         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1386         (ChromiumAndroidPortTest.test_attributes):
1387         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1388         (parse_args):
1389
1390 2012-07-24  Alexander Shalamov  <alexander.shalamov@intel.com>
1391
1392         [WTR][EFL] Multiple mouse clicks are not emitted in EventSenderProxyEfl
1393         https://bugs.webkit.org/show_bug.cgi?id=92107
1394
1395         Reviewed by Kenneth Rohde Christiansen.
1396
1397         Fixes mouse click events in EventSenderProxyEfl.
1398
1399         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
1400         (WTR::dispatchMouseDownEvent):
1401         (WTR::EventSenderProxy::dispatchEvent):
1402
1403 2012-07-24  Tommy Widenflycht  <tommyw@google.com>
1404
1405         MediaStream API: Update MediaStreamTrack to match the specification
1406         https://bugs.webkit.org/show_bug.cgi?id=90180
1407
1408         Reviewed by Adam Barth.
1409
1410         Adding a Mock WebMediaStreamCenter to enable better LayoutTests.
1411
1412         * DumpRenderTree/DumpRenderTree.gypi:
1413         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
1414         (MockWebKitPlatformSupport::createMediaStreamCenter):
1415         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp: Added.
1416         (WebKit):
1417         (WebKit::MockWebMediaStreamCenter::MockWebMediaStreamCenter):
1418         (WebKit::MockWebMediaStreamCenter::queryMediaStreamSources):
1419         (WebKit::MockWebMediaStreamCenter::didEnableMediaStreamTrack):
1420         (WebKit::MockWebMediaStreamCenter::didDisableMediaStreamTrack):
1421         (WebKit::MockWebMediaStreamCenter::didStopLocalMediaStream):
1422         (WebKit::MockWebMediaStreamCenter::didCreateMediaStream):
1423         (WebKit::MockWebMediaStreamCenter::constructSDP):
1424         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp.
1425         (WebKit):
1426         (MockWebMediaStreamCenter):
1427         (WebKit::MockWebMediaStreamCenter::MockWebMediaStreamCenter):
1428
1429 2012-07-23  Ryosuke Niwa  <rniwa@webkit.org>
1430
1431         Fix regressions in replay performance tests
1432         https://bugs.webkit.org/show_bug.cgi?id=92052
1433
1434         Reviewed by Dirk Pranke.
1435
1436         Fix regression that accumulated over time to make replay tests work again.
1437
1438         * DumpRenderTree/chromium/WebViewHost.cpp:
1439         (WebViewHost::willSendRequest): Use the main document URL in the request since the main frame's
1440         URL hadn't been updated yet When requesting a new URL on the main frame.
1441         * Scripts/webkitpy/performance_tests/perftest.py:
1442         (ReplayServer.wait_until_ready): Waiting for 6 seconds (3 tries) seems enough.
1443         (ReplayPerfTest.prepare): Pass self._archive_path to run_signle as that is the current contract.
1444         (ReplayPerfTest.run_single): Use the archive path to generate -expected.png path.
1445         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1446         (TestReplayPerfTest.test_run_single):
1447         (TestReplayPerfTest.test_prepare):
1448         (TestReplayPerfTest.test_prepare_calls_run_single.run_single):
1449         (TestReplayPerfTest):
1450
1451 2012-07-24  Simon Hausmann  <simon.hausmann@nokia.com>
1452
1453         [Qt] MSVC: unresolved external symbol __DllMainCRTStartup@12
1454         https://bugs.webkit.org/show_bug.cgi?id=91229
1455
1456         Reviewed by Jocelyn Turcotte.
1457
1458         In order to successfully link a DLL on Windows we need to have at least
1459         one object file (or compilation unit). The forward export header files were
1460         supposed to be that, but unfortunately the rule in win32/default_post.prf for
1461         creating the header files had some bugs, among others that it did an exists()
1462         check on the depending static library. At the time qmake is ran those libraries
1463         do not exist yet and therefore the corresponding extra compiler rules were never
1464         created, resulting in empty OBJECTS/SOURCES.
1465
1466         Even without such an exists() check, qmake extra compilers require the files
1467         referred to in the .input variable to exist at qmake time. In this case the input
1468         files were the static libraries, which do not exist yet.
1469
1470         This patch solves this by using a qmake extra target instead of extra
1471         compiler, which does not have this limitation. The target is referenced
1472         through the extension of GENERATED_SOURCES.
1473
1474         The patch also adds a d/_debug suffix for debug builds, do allow for separate
1475         symbol exports if necessary.
1476
1477         * Scripts/generate-win32-export-forwards: Support multiple input files, i.e.
1478         consider the last argument to be the output file and everything else input.
1479         * qmake/mkspecs/features/win32/default_post.prf:
1480
1481 2012-07-24  Balazs Kelemen  <kbalazs@webkit.org>
1482
1483         [Qt] Add quirks for running the web process in a profiler shell, like valgrind
1484         https://bugs.webkit.org/show_bug.cgi?id=87672
1485
1486         Reviewed by Jocelyn Turcotte.
1487
1488         Add --no-timeout-at-all command line switch to not time out no matter how
1489         long the web process does it's job. --no-timeout is not enough for profiling
1490         purposes because it only affects the timeout when we are waiting for the end
1491         of the test. We use another timeout to control how much we wait for the web
1492         process to initialize before and reset after the test and it could also easily
1493         expire when running under valgrind. We should keep the behavior of --no-timeout
1494         to not disable this timout check because --no-timeout is used by performace tests
1495         and those should not wait for the web process to initialize and reset more than
1496         normal tests.
1497
1498         * WebKitTestRunner/TestController.cpp:
1499         (WTR::TestController::TestController):
1500         (WTR::TestController::initialize):
1501         (WTR::TestController::runUntil):
1502         * WebKitTestRunner/TestController.h:
1503
1504 2012-07-24  Peter Beverloo  <peter@chromium.org>
1505
1506         [Chromium] Fix a class/struct mismatch error in TestDelegate.h (showing up on clang)
1507         https://bugs.webkit.org/show_bug.cgi?id=92097
1508
1509         Unreviewed build fix.
1510
1511         WebContextMenuData is declared as a struct in Source/WebKit/chromium/public/WebContextMenuData.h,
1512         but TestDelegate.h forward declares it as a class.
1513
1514         * DumpRenderTree/chromium/TestRunner/TestDelegate.h:
1515         (WebKit):
1516
1517 2012-07-23  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
1518
1519         [Qt] Fix compilation against namespaced Qt
1520
1521         Reviewed by Simon Hausmann.
1522
1523         * QtTestBrowser/launcherwindow.h:
1524         * WebKitTestRunner/PlatformWebView.h:
1525
1526 2012-07-24  Peter Beverloo  <peter@chromium.org>
1527
1528         Update a few Chromium Android contributors in committers.py
1529         https://bugs.webkit.org/show_bug.cgi?id=92090
1530
1531         Reviewed by Kent Tamura.
1532
1533         Add Sami Kyostila, who has been doing significant work on Chromium's
1534         compositor. Add IRC nicknames for John Mellor and Tien-Ren Chen, and
1535         remove John Grabowski who changed projects, and add my webkit.org alias.
1536
1537         * Scripts/webkitpy/common/config/committers.py:
1538
1539 2012-07-24  Pierre Rossi  <pierre.rossi@gmail.com>
1540
1541         [Qt] Enable touch slider when touch events are enabled
1542         https://bugs.webkit.org/show_bug.cgi?id=91013
1543
1544         Reviewed by Kenneth Rohde Christiansen.
1545
1546         TOUCH_SLIDER guards are used in WebCore, so we should really
1547         be setting the corresponding ENABLE define in features.prf.
1548
1549         * qmake/mkspecs/features/features.prf:
1550
1551 2012-07-24  Ryuan Choi  <ryuan.choi@samsung.com>
1552
1553         [EFL] EWebLauncher should not require config.h in the style check
1554         https://bugs.webkit.org/show_bug.cgi?id=92070
1555
1556         Reviewed by Kentaro Hara.
1557
1558         * Scripts/webkitpy/style/checker.py:
1559         Remove the include rules from the style-check for EWebLauncher because
1560         EWebLauncher is simple EFL application.
1561
1562 2012-07-24  Jochen Eisinger  <jochen@chromium.or>
1563
1564         [Chromium] EventSender shouldn't know about TestShell
1565         https://bugs.webkit.org/show_bug.cgi?id=91449
1566
1567         Reviewed by Adam Barth.
1568
1569         Original patch by Adam Barth.
1570
1571         This patch removes the dependency from EventSender to TestShell.  Most
1572         of EventSender works directly with a WebView, but there are a handful
1573         of references to WebViewHost.  We don't want to re-use WebViewHost in
1574         ContentShell because we want to use the multi-process embedding
1575         environment for WebViews.
1576
1577         To avoid the dependency on WebViewHost, this patch introduces
1578         TestDelegate, which is an abstract base class for WebViewHost.  In
1579         ContentShell, we'll need another object to implement these functions.
1580
1581         * DumpRenderTree/chromium/EventSender.cpp:
1582         (EventSender::EventSender):
1583         (EventSender::keyDown):
1584         (makeMenuItemStringsFor):
1585         (EventSender::contextClick):
1586         * DumpRenderTree/chromium/EventSender.h:
1587         (EventSender):
1588         (EventSender::setDelegate):
1589         (EventSender::setWebView):
1590         (EventSender::webview):
1591         * DumpRenderTree/chromium/TestRunner/TestDelegate.h: Added.
1592         (WebKit):
1593         (TestDelegate):
1594         * DumpRenderTree/chromium/TestShell.cpp:
1595         (TestShell::initialize):
1596         (TestShell::createMainWindow):
1597         (TestShell::~TestShell):
1598         * DumpRenderTree/chromium/WebViewHost.cpp:
1599         (WebViewHost::fillSpellingSuggestionList):
1600         * DumpRenderTree/chromium/WebViewHost.h:
1601         (WebViewHost):
1602
1603 2012-07-24  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1604
1605         Make WebIntents and WebIntentsTag a build option for the build-webkit script
1606         https://bugs.webkit.org/show_bug.cgi?id=91841
1607
1608         Reviewed by Philippe Normand.
1609
1610         And it will also be disabled when building with --minimal.
1611
1612         * Scripts/webkitperl/FeatureList.pm:
1613
1614 2012-07-23  Dirk Pranke  <dpranke@chromium.org>
1615
1616         Unreviewed, rolling out r123360.
1617         http://trac.webkit.org/changeset/123360
1618         https://bugs.webkit.org/show_bug.cgi?id=91890
1619
1620         broke the chromium bots
1621
1622         * Scripts/webkitpy/layout_tests/port/chromium.py:
1623         (ChromiumPort._static_build_path):
1624         (ChromiumPort.default_results_directory):
1625         (ChromiumPort._build_path):
1626         (ChromiumPort._path_to_image_diff):
1627         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1628         (ChromiumAndroidPort._build_path):
1629         (ChromiumAndroidPort._path_to_driver):
1630         (ChromiumAndroidPort._path_to_forwarder):
1631         (ChromiumAndroidPort._push_executable):
1632         (ChromiumAndroidPort._push_fonts):
1633         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1634         (ChromiumLinuxPort._determine_driver_path_statically):
1635         (ChromiumLinuxPort._modules_to_search_for_symbols):
1636         (ChromiumLinuxPort._path_to_driver):
1637         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1638         (ChromiumLinuxPortTest.test_build_path):
1639         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1640         (ChromiumMacPort._modules_to_search_for_symbols):
1641         (ChromiumMacPort._path_to_driver):
1642         (ChromiumMacPort._path_to_helper):
1643         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1644         (ChromiumMacPortTest.test_build_path):
1645         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1646         (ChromiumWinPort._path_to_driver):
1647         (ChromiumWinPort._path_to_helper):
1648         (ChromiumWinPort._path_to_image_diff):
1649         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1650         (ChromiumWinTest.test_build_path):
1651
1652 2012-07-23  Adam Barth  <abarth@webkit.org>
1653
1654         [Chromium] TestInterfaces should be responsible for owning and binding AccessibilityController and TextInputController
1655         https://bugs.webkit.org/show_bug.cgi?id=91459
1656
1657         Reviewed by Ryosuke Niwa.
1658
1659         Rather than having TestShell own and bind each of these JavaScript APIs
1660         individually, TestShell should delegate that work to TestInterfaces.
1661         This patch moves AccessibilityController and TextInputController to be
1662         the responsibility of TestInterfaces.
1663
1664         * DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
1665         (TestInterfaces::TestInterfaces):
1666         (TestInterfaces::~TestInterfaces):
1667         (TestInterfaces::setWebView):
1668         (TestInterfaces::bindTo):
1669         (TestInterfaces::resetAll):
1670         * DumpRenderTree/chromium/TestRunner/TestInterfaces.h:
1671         (WebKit):
1672         (TestInterfaces):
1673         (TestInterfaces::accessibilityController):
1674         * DumpRenderTree/chromium/TestShell.cpp:
1675         (TestShell::initialize):
1676         (TestShell::createMainWindow):
1677         (TestShell::~TestShell):
1678         (TestShell::resetTestController):
1679         (TestShell::bindJSObjectsToWindow):
1680         * DumpRenderTree/chromium/TestShell.h:
1681         (TestShell::accessibilityController):
1682         (TestShell):
1683
1684 2012-07-23  Balazs Kelemen  <kbalazs@webkit.org>
1685
1686         nrwt swallows early exceptions
1687         https://bugs.webkit.org/show_bug.cgi?id=91884
1688
1689         Reviewed by Dirk Pranke.
1690
1691         Put everything in a try block so we won't miss any error.
1692
1693         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1694         (run):
1695         (main):
1696
1697 2012-07-23  Christophe Dumez  <christophe.dumez@intel.com>
1698
1699         [WK2] WebKitTestRunner needs to print information about Web intents
1700         https://bugs.webkit.org/show_bug.cgi?id=90873
1701
1702         Reviewed by Anders Carlsson.
1703
1704         Print out information about new intents requests and intent
1705         services registrations in WebKitTestRunner. This is expected
1706         by tests under webintents/*.
1707
1708         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1709         (WTR::InjectedBundlePage::InjectedBundlePage):
1710         (WTR::InjectedBundlePage::didReceiveIntentForFrame):
1711         (WTR):
1712         (WTR::InjectedBundlePage::registerIntentServiceForFrame):
1713         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1714         (InjectedBundlePage):
1715
1716 2012-07-23  Dirk Pranke  <dpranke@chromium.org>
1717
1718         nrwt: never finds binaries in the 'out' dir on chromium win
1719         https://bugs.webkit.org/show_bug.cgi?id=91890
1720
1721         Reviewed by Tony Chang.
1722
1723         We were figuring out which directory look in for binaries by
1724         testing for the base directory (the directory above
1725         Debug/Release). In chromium-win's case, we look in src/build,
1726         which always exists because there are checked-in files in it,
1727         which means we'd always pick that directory over src/out. All of
1728         the other ports' build_path() implementation was including
1729         Debug/Release. If we matched that, we wouldn't have a problem,
1730         so this change fixes that and updates all of the callers of the
1731         chromium ports' implementation to not pass configuration as part
1732         of the path to look up; we still need to pass configuration in
1733         some cases (to test if the build is out of date between debug
1734         and release) so the implementation gets slightly more
1735         complicated.
1736
1737         * Scripts/webkitpy/layout_tests/port/chromium.py:
1738         (ChromiumPort._static_build_path):
1739         (ChromiumPort.default_results_directory):
1740         (ChromiumPort._build_path):
1741         (ChromiumPort._path_to_image_diff):
1742         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1743         (ChromiumAndroidPort._build_path):
1744         (ChromiumAndroidPort._path_to_driver):
1745         (ChromiumAndroidPort._path_to_forwarder):
1746         (ChromiumAndroidPort._push_executable):
1747         (ChromiumAndroidPort._push_fonts):
1748         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1749         (ChromiumLinuxPort._determine_driver_path_statically):
1750         (ChromiumLinuxPort._modules_to_search_for_symbols):
1751         (ChromiumLinuxPort._path_to_driver):
1752         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1753         (ChromiumLinuxPortTest.test_build_path):
1754         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1755         (ChromiumMacPort._modules_to_search_for_symbols):
1756         (ChromiumMacPort._path_to_driver):
1757         (ChromiumMacPort._path_to_helper):
1758         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1759         (ChromiumMacPortTest.test_build_path):
1760         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1761         (ChromiumWinPort._path_to_driver):
1762         (ChromiumWinPort._path_to_helper):
1763         (ChromiumWinPort._path_to_image_diff):
1764         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1765         (ChromiumWinTest.test_build_path):
1766
1767 2012-07-23  Sheriff Bot  <webkit.review.bot@gmail.com>
1768
1769         Unreviewed, rolling out r123339.
1770         http://trac.webkit.org/changeset/123339
1771         https://bugs.webkit.org/show_bug.cgi?id=92006
1772
1773         massive media tests failure (Requested by philn on #webkit).
1774
1775         * Scripts/webkitdirs.pm:
1776         (buildAutotoolsProject):
1777         * gtk/jhbuild.modules:
1778
1779 2012-07-23  Tommy Widenflycht  <tommyw@google.com>
1780
1781         [chromium] MediaStream API: Clean up the MockWebKitPlatformSupport object at shutdown
1782         https://bugs.webkit.org/show_bug.cgi?id=91857
1783
1784         Reviewed by Adam Barth.
1785
1786         Made a few changes so that the destructor could be called at shutdown.
1787
1788         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1789         (WebKitSupportTestEnvironment::WebKitSupportTestEnvironment):
1790         (WebKitSupportTestEnvironment):
1791         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
1792         (MockWebKitPlatformSupport::create):
1793         * DumpRenderTree/chromium/MockWebKitPlatformSupport.h:
1794         (MockWebKitPlatformSupport):
1795         (MockWebKitPlatformSupport::~MockWebKitPlatformSupport):
1796
1797 2012-07-23  Philippe Normand  <pnormand@igalia.com>
1798
1799         [GTK][jhbuild] Switch to GStreamer 0.11 build
1800         https://bugs.webkit.org/show_bug.cgi?id=91727
1801
1802         Reviewed by Gustavo Noronha Silva.
1803
1804         Switch build-webkit --gtk to GStreamer 0.11 support and build the
1805         necessary GStreamer git modules from JHBuild.
1806
1807         * Scripts/webkitdirs.pm:
1808         (buildAutotoolsProject): Build WebKit with GStreamer 0.11 support.
1809         * gtk/jhbuild.modules: GStreamer build support.
1810
1811 2012-07-23  Christophe Dumez  <christophe.dumez@intel.com>
1812
1813         WebKit2 needs layoutTestController.setAlwaysAcceptCookies
1814         https://bugs.webkit.org/show_bug.cgi?id=42778
1815
1816         Reviewed by Kenneth Rohde Christiansen.
1817
1818         Add support for layoutTestController.setAlwaysAcceptCookies()
1819         since it is required by some tests.
1820
1821         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1822         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1823         (WTR::LayoutTestController::setAlwaysAcceptCookies):
1824         (WTR):
1825         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1826         (LayoutTestController):
1827
1828 2012-07-23  Kent Tamura  <tkent@chromium.org>
1829
1830         Rename ENABLE_METER_TAG and ENABLE_PROGRESS_TAG to ENABLE_METER_ELEMENT and ENABLE_PROGRESS_ELEMENT respectively
1831         https://bugs.webkit.org/show_bug.cgi?id=91941
1832
1833         Reviewed by Kentaro Hara.
1834
1835         A flag name for an elmement should be ENABLE_*_ELEMENT.
1836
1837         * Scripts/webkitperl/FeatureList.pm:
1838         * qmake/mkspecs/features/features.pri:
1839
1840 2012-07-22  Kent Tamura  <tkent@chromium.org>
1841
1842         Rename ENABLE_DETAILS to ENABLE_DETAILS_ELEMENT
1843         https://bugs.webkit.org/show_bug.cgi?id=91928
1844
1845         Reviewed by Kentaro Hara.
1846
1847         A flag name for an elmement should be ENABLE_*_ELEMENT.
1848
1849         * Scripts/webkitperl/FeatureList.pm:
1850         * qmake/mkspecs/features/features.pri:
1851
1852 2012-07-20  Kent Tamura  <tkent@chromium.org>
1853
1854         Rename ENABLE_DATALIST to ENABLE_DATALIST_ELEMENT
1855         https://bugs.webkit.org/show_bug.cgi?id=91846
1856
1857         Reviewed by Kentaro Hara.
1858
1859         A flag name for an elmement should be ENABLE_*_ELEMENT.
1860
1861         * Scripts/webkitperl/FeatureList.pm:
1862         * qmake/mkspecs/features/features.pri:
1863
1864 2012-07-20  Xianzhu Wang  <wangxianzhu@chromium.org>
1865
1866         [Chromium-Android] Store test pipes in /data/local/tmp
1867         https://bugs.webkit.org/show_bug.cgi?id=91909
1868
1869         In the previous change (bug 91873, r123258) we placed the pipes in /sdcard/native_tests.
1870         However after tests we found some devices don't allow the app to create pipes there.
1871         So /data/local/tmp is a better place for the pipes.
1872
1873         Reviewed by Adam Barth.
1874
1875         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1876
1877 2012-07-20  Xianzhu Wang  <wangxianzhu@chromium.org>
1878
1879         [Chomium-Android] Place DRT input/output pipes where both app and unrooted shell can read/write
1880         https://bugs.webkit.org/show_bug.cgi?id=91873
1881
1882         Reviewed by Adam Barth.
1883
1884         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1885
1886 2012-07-20  Han Shen  <shenhan@google.com>
1887
1888         [Chromium] Compilation fails under gcc 4.7
1889         https://bugs.webkit.org/show_bug.cgi?id=90227
1890
1891         Reviewed by Tony Chang.
1892
1893         Disable warnings about c++0x compatibility in gcc newer than 4.6.
1894
1895         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1896
1897 2012-07-20  Dirk Pranke  <dpranke@chromium.org>
1898
1899         REGRESSION: run-perf-tests --pause-before-testing is broken
1900         https://bugs.webkit.org/show_bug.cgi?id=91789
1901
1902         Reviewed by Ryosuke Niwa.
1903
1904         Turns out start() wasn't actually starting things :(. Fixed, and
1905         added tests.
1906
1907         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1908         (ChromiumAndroidDriverTest.test_read_prompt):
1909         * Scripts/webkitpy/layout_tests/port/driver.py:
1910         (Driver.__init__):
1911         (Driver._start):
1912         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
1913         (DriverTest.test_read_block):
1914         (DriverTest.test_read_binary_block):
1915         (DriverTest.test_read_base64_block):
1916         (DriverTest.test_stop_cleans_up_properly):
1917         (DriverTest.test_two_starts_cleans_up_properly):
1918         (DriverTest.test_start_actually_starts):
1919         (MockServerProcess.__init__):
1920         (MockServerProcess.start):
1921
1922 2012-07-20  Jochen Eisinger  <jochen@chromium.org>
1923
1924         [chromium] Don't include WebCore headers in TestInterfaces so it's safe to include from outside of WebCore
1925         https://bugs.webkit.org/show_bug.cgi?id=91847
1926
1927         Reviewed by Adam Barth.
1928
1929         This allows for including the TestIntefaces.h from content shell
1930         without introducing a dependency to WebCore/wtf
1931
1932         * DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
1933         (TestInterfaces::Internal):
1934         (TestInterfaces::Internal::Internal):
1935         (TestInterfaces::Internal::~Internal):
1936         (TestInterfaces::Internal::bindTo):
1937         (TestInterfaces::Internal::resetAll):
1938         (TestInterfaces::TestInterfaces):
1939         (TestInterfaces::~TestInterfaces):
1940         (TestInterfaces::bindTo):
1941         (TestInterfaces::resetAll):
1942         * DumpRenderTree/chromium/TestRunner/TestInterfaces.h:
1943         (TestInterfaces):
1944
1945 2012-07-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1946
1947         [Qt] Make WTR use the same color palette as DRT
1948         https://bugs.webkit.org/show_bug.cgi?id=91870
1949
1950         Reviewed by Noam Rosenthal.
1951
1952         Make sure that WebKitTestRunner and DumpRenderTree use the same palette: the
1953         standard from QWindowsStyle.
1954
1955         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1956         (WTR::activateFonts): Moved code to platformInitialize since setting style is not
1957         exactly font related.
1958         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
1959         (WTR::InjectedBundle::platformInitialize): Force the usage of the style's
1960         palette.  Because at this point QApplication was already instantiated, the
1961         default palette was already initialized to be the system one, so we need to
1962         explicitly set the palette to be the standard from style. This is not needed in
1963         DRT because there we set the style before instantiating QApplication.
1964
1965 2012-07-20  Tony Chang  <tony@chromium.org>
1966
1967         Baseline align text in the flakiness dashboard toolbar
1968         https://bugs.webkit.org/show_bug.cgi?id=91784
1969
1970         Reviewed by Ojan Vafai.
1971
1972         Baseline align the flex items.
1973
1974         * TestResultServer/static-dashboards/flakiness_dashboard.css:
1975         (.forms): Add box-align: baseline
1976         (.forms > *): Use block display to force flex items rather than box.
1977         (#tests-form): Add box-align: baseline
1978         (#tests-form > *): Use block display to force flex items rather than box.
1979
1980 2012-07-20  Sheriff Bot  <webkit.review.bot@gmail.com>
1981
1982         Unreviewed, rolling out r123220.
1983         http://trac.webkit.org/changeset/123220
1984         https://bugs.webkit.org/show_bug.cgi?id=91880
1985
1986         broke Debug build (Requested by philn on #webkit).
1987
1988         * Scripts/webkitdirs.pm:
1989         (buildAutotoolsProject):
1990         * gtk/jhbuild.modules:
1991
1992 2012-07-20  Philippe Normand  <pnormand@igalia.com>
1993
1994         [GTK][jhbuild] Switch to GStreamer 0.11 build
1995         https://bugs.webkit.org/show_bug.cgi?id=91727
1996
1997         Reviewed by Gustavo Noronha Silva.
1998
1999         Switch build-webkit --gtk to GStreamer 0.11 support and build the
2000         necessary GStreamer git modules from JHBuild.
2001
2002         * Scripts/webkitdirs.pm:
2003         (buildAutotoolsProject): Build WebKit with GStreamer 0.11 support.
2004         * gtk/jhbuild.modules: GStreamer build support.
2005
2006 2012-07-20  Christophe Dumez  <christophe.dumez@intel.com>
2007
2008         [EFL] Proxy configuration should honor the no_proxy environment variable
2009         https://bugs.webkit.org/show_bug.cgi?id=91747
2010
2011         Reviewed by Kenneth Rohde Christiansen.
2012
2013         Add ProxyResolverSoup to the list of classes that contain GObjects
2014         in style checker script so that it does not complain about naming
2015         convention issues that are mandated by GObject.
2016
2017         * Scripts/webkitpy/style/checker.py:
2018
2019 2012-07-20  Zeno Albisser  <zeno@webkit.org>
2020
2021         [Qt][WK2] Add configure tests for Xrender and GLX.
2022         https://bugs.webkit.org/show_bug.cgi?id=91845
2023
2024         GraphicsSurface on linux requires Xcomposite, Xrender
2025         and GLX. If any of these requirements is not met,
2026         we should disable GraphicsSurface.
2027
2028         Reviewed by Kenneth Rohde Christiansen.
2029
2030         * qmake/config.tests/glx/glx.cpp: Added.
2031         (main):
2032         * qmake/config.tests/glx/glx.pro: Added.
2033         * qmake/config.tests/libXrender/libXrender.cpp: Added.
2034         (main):
2035         * qmake/config.tests/libXrender/libXrender.pro: Added.
2036         * qmake/configure.pri:
2037         * qmake/mkspecs/features/features.prf:
2038
2039 2012-07-20  Kangil Han  <kangil.han@samsung.com>
2040
2041         [EFL][WK2][WTR] Implement EventSenderProxy
2042         https://bugs.webkit.org/show_bug.cgi?id=91731
2043
2044         Reviewed by Kentaro Hara.
2045
2046         This is an initial EFL port implementation of EventSenderProxy.
2047
2048         * WebKitTestRunner/EventSenderProxy.h:
2049         (WTR):
2050         (EventSenderProxy):
2051         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2052         * WebKitTestRunner/PlatformEfl.cmake:
2053         * WebKitTestRunner/TestController.cpp:
2054         (WTR::TestController::TestController):
2055         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2056         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Added.
2057         (WTR):
2058         (WTREvent):
2059         (WTR::WTREvent::WTREvent):
2060         (WTR::KeyEventInfo::KeyEventInfo):
2061         (KeyEventInfo):
2062         (WTR::evasMouseButton):
2063         (WTR::setEvasModifiers):
2064         (WTR::dispatchMouseDownEvent):
2065         (WTR::dispatchMouseUpEvent):
2066         (WTR::dispatchMouseMoveEvent):
2067         (WTR::dispatchMouseScrollByEvent):
2068         (WTR::keyPadName):
2069         (WTR::keyName):
2070         (WTR::EventSenderProxy::EventSenderProxy):
2071         (WTR::EventSenderProxy::updateClickCountForButton):
2072         (WTR::EventSenderProxy::dispatchEvent):
2073         (WTR::EventSenderProxy::replaySavedEvents):
2074         (WTR::EventSenderProxy::sendOrQueueEvent):
2075         (WTR::EventSenderProxy::mouseDown):
2076         (WTR::EventSenderProxy::mouseUp):
2077         (WTR::EventSenderProxy::mouseMoveTo):
2078         (WTR::EventSenderProxy::mouseScrollBy):
2079         (WTR::EventSenderProxy::leapForward):
2080         (WTR::EventSenderProxy::keyDown):
2081         (WTR::EventSenderProxy::addTouchPoint):
2082         (WTR::EventSenderProxy::updateTouchPoint):
2083         (WTR::EventSenderProxy::setTouchModifier):
2084         (WTR::EventSenderProxy::touchStart):
2085         (WTR::EventSenderProxy::touchMove):
2086         (WTR::EventSenderProxy::touchEnd):
2087         (WTR::EventSenderProxy::touchCancel):
2088         (WTR::EventSenderProxy::clearTouchPoints):
2089         (WTR::EventSenderProxy::releaseTouchPoint):
2090         (WTR::EventSenderProxy::cancelTouchPoint):
2091         (WTR::EventSenderProxy::setTouchPointRadius):
2092
2093 2012-07-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2094
2095         Unreviewed, rolling out r123085.
2096         http://trac.webkit.org/changeset/123085
2097         https://bugs.webkit.org/show_bug.cgi?id=91719
2098
2099         r123085 causes crashes on EFL layout test bot.
2100
2101         * WebKitTestRunner/CMakeLists.txt:
2102         * WebKitTestRunner/InjectedBundle/efl/LayoutTestControllerEfl.cpp:
2103         (WTR::LayoutTestController::platformInitialize):
2104
2105 2012-07-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2106
2107         [WTR] Add *explicit* keyword to constructor which has a parameter
2108         https://bugs.webkit.org/show_bug.cgi?id=91745
2109
2110         Reviewed by Adam Barth.
2111
2112         Add *explicit* keyword to contructor which has a parameter in order to avoid implicit type conversion.
2113
2114         * WebKitTestRunner/EventSenderProxy.h:
2115         (EventSenderProxy):
2116         * WebKitTestRunner/TestInvocation.h:
2117         (TestInvocation):
2118
2119 2012-07-19  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2120
2121         [EFL] [WK2] Add methods to get/set a custom text encoding
2122         https://bugs.webkit.org/show_bug.cgi?id=90604
2123
2124         Reviewed by Kenneth Rohde Christiansen.
2125
2126         Added support for setting custom character encoding in MiniBrowser.
2127         Use 'F3' to set the custom character encoding.
2128
2129         * MiniBrowser/efl/main.c:
2130         (on_key_down):
2131
2132 2012-07-19  Dirk Pranke  <dpranke@chromium.org>
2133
2134         webkitpy: executive_unittest still failing when run in parallel
2135         https://bugs.webkit.org/show_bug.cgi?id=91795
2136
2137         Reviewed by Adam Barth.
2138
2139         It turns out that test_kill_process and test_kill_all are both
2140         launching the same process, and so if they're run at the same
2141         time, test_kill_all interferes w/ test_kill_process.
2142
2143         Merging the two tests solves the issue :).
2144
2145         * Scripts/webkitpy/common/system/executive_unittest.py:
2146         (ExecutiveTest.test_kill_process):
2147         (ExecutiveTest._assert_windows_image_name):
2148         (ExecutiveTest):
2149         (ExecutiveTest.test_windows_image_name):
2150
2151 2012-07-19  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2152
2153         [EFL] [WK2] Add a callback to handle delete request in MiniBrowser
2154         https://bugs.webkit.org/show_bug.cgi?id=91483
2155
2156         Reviewed by Dirk Pranke.
2157
2158         Add a callback to handle delete request and quit the main loop when
2159         window is asked to be deleted so that all the resources allocated
2160         for the window will be freed properly.
2161
2162         * MiniBrowser/efl/main.c:
2163         (closeWindow):
2164         (browserCreate):
2165
2166 2012-07-19  No'am Rosenthal  <noam.rosenthal@nokia.com>
2167
2168         [Qt] Enable CSS shaders in Qt (software mode)
2169         https://bugs.webkit.org/show_bug.cgi?id=85140
2170
2171         Reviewed by Simon Hausmann.
2172
2173         Enable CSS_SHADERS when WEBGL and CSS_FILTERS are enabled.
2174
2175         * qmake/mkspecs/features/features.prf:
2176
2177 2012-07-19  No'am Rosenthal  <noam.rosenthal@nokia.com>
2178
2179         [Qt] Enable CSS shaders in Qt (software mode)
2180         https://bugs.webkit.org/show_bug.cgi?id=85140
2181
2182         Reviewed by Simon Hausmann.
2183
2184         Enable CSS_SHADERS when WEBGL and CSS_FILTERS are enabled.
2185
2186         * qmake/mkspecs/features/features.prf:
2187
2188 2012-07-19  Dirk Pranke  <dpranke@chromium.org>
2189
2190         test-webkitpy: fix executive_unittest nits, including a missing 'errno' import
2191         https://bugs.webkit.org/show_bug.cgi?id=91770
2192
2193         Reviewed by Adam Barth.
2194
2195         The missing errno import is causing a flaky failure when run in
2196         parallel on the bots.
2197
2198         * Scripts/webkitpy/common/system/executive_unittest.py:
2199         (ExecutiveTest.assert_interpreter_for_content):
2200
2201 2012-07-19  Oliver Hunt  <oliver@apple.com>
2202
2203         Make style bot handle underscores in names more reasonably
2204         https://bugs.webkit.org/show_bug.cgi?id=91777
2205
2206         Reviewed by Gavin Barraclough.
2207
2208         This patch adds a naming/readability/underscores category for style errors.
2209         That allows us to use underscores in those portions of JSC (and potentially
2210         gtk?) without turning off all naming checks for the effected directories.
2211         We also filter out the DFG_OPERATION warning, and a few other minor changes
2212         to make the style bot less noisy when running over JSC at least.
2213
2214         * Scripts/webkitpy/style/checker.py:
2215         * Scripts/webkitpy/style/checkers/cpp.py:
2216         (check_identifier_name_in_declaration):
2217         (CppChecker):
2218         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2219         (WebKitStyleTest.test_names):
2220
2221 2012-07-19  Dirk Pranke  <dpranke@chromium.org>
2222
2223         config_standalone.py is crashing on apple win's cygwin port
2224         https://bugs.webkit.org/show_bug.cgi?id=91682
2225
2226         Reviewed by Adam Roben.
2227
2228         Work around a weird interaction of ctypes and cygwin that
2229         is causing unit tests to crash for me locally.
2230
2231         * Scripts/webkitpy/common/system/executive.py:
2232         (Executive._win32_check_running_pid):
2233
2234 2012-07-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2235
2236         [GTK] WebKit test runner ignores all system environment variables
2237         https://bugs.webkit.org/show_bug.cgi?id=90284
2238
2239         Reviewed by Dirk Pranke.
2240
2241         Added support in unit test framework to pass a custom environment
2242         variable to the tests by using the --additional-env-var parameter.
2243
2244         * Scripts/webkitpy/layout_tests/port/base.py:
2245         (Port.to.setup_environ_for_server): Adding environment variables
2246         that come through the additional_env_var option.
2247         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2248         (PortTest.test_additional_env_var): Added unit test for the
2249         additional_env_var option
2250         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2251         (parse_args): Added the --additional-env-var parameter.
2252
2253 2012-07-19  Joshua Bell  <jsbell@chromium.org>
2254
2255         Roll out r121610 and r122487 which may have been causing flaky crashes
2256         https://bugs.webkit.org/show_bug.cgi?id=91637
2257
2258         Reviewed by Kentaro Hara.
2259
2260         Flaky crashes started in random tests following r121610. It's not clear
2261         that r121610 is to blame, but we'd like to prove or disprove it.
2262         If this doesn't resolve the crashes, this patch should be rolled out.
2263
2264         * DumpRenderTree/DumpRenderTree.gypi:
2265         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2266         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2267         (PluginTest):
2268         * DumpRenderTree/TestNetscapePlugIn/Tests/LeakWindowScriptableObject.cpp: Removed.
2269
2270 2012-07-19  Pierre Rossi  <pierre.rossi@gmail.com>
2271
2272         [Qt][WK2] Map the elementRect exposed in QML to the view for popup menu
2273         https://bugs.webkit.org/show_bug.cgi?id=91645
2274
2275         Reviewed by Simon Hausmann.
2276
2277         Also improved the logic slightly for edge cases.
2278
2279         * MiniBrowser/qt/qml/ItemSelector.qml:
2280
2281 2012-07-19  Christophe Dumez  <christophe.dumez@intel.com>
2282
2283         [EFL] Bump libsoup dependency to v2.39.4.1 to fix cookie issues
2284         https://bugs.webkit.org/show_bug.cgi?id=91741
2285
2286         Reviewed by Kenneth Rohde Christiansen.
2287
2288         Bump libsoup dependency in jhbuild to v2.39.4.1 to fix issues
2289         with cookies in non-suffixed/private domains [GNOME #679230].
2290
2291         * efl/jhbuild.modules:
2292
2293 2012-07-19  Simon Hausmann  <simon.hausmann@nokia.com>
2294
2295         [Qt] Remove support for Qt versions before 4.8.0
2296         https://bugs.webkit.org/show_bug.cgi?id=91730
2297
2298         Reviewed by Kenneth Rohde Christiansen.
2299
2300         Remove Qt version check #ifdefs for Qt versions before 4.8.0.
2301
2302         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2303         (LayoutTestController::reset):
2304         (LayoutTestController::setAlwaysBlockCookies):
2305         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2306         (LayoutTestController):
2307
2308 2012-07-19  Mario Sanchez Prada  <msanchez@igalia.com>
2309
2310         [GTK] Enable MHTML support by default at build time
2311         https://bugs.webkit.org/show_bug.cgi?id=89987
2312
2313         Reviewed by Carlos Garcia Campos.
2314
2315         Enable MHTML support by default for GTK in build-webkit.
2316
2317         * Scripts/webkitperl/FeatureList.pm:
2318
2319 2012-07-19  Zoltan Nyul  <zoltan.nyul@intel.com>
2320
2321         [EFL][WK2] Using different cache directory for each WTR process
2322         https://bugs.webkit.org/show_bug.cgi?id=91719
2323
2324         Reviewed by Kenneth Rohde Christiansen.
2325
2326         The testrunner script may be running multiple processes in
2327         parallel, and it makes appcache tests fail if they are using the same
2328         directory. I modified the EFL's LayoutTestController to use the
2329         DUMPRENDERTREE_TEMP for application cache directory because it's
2330         different for each process.
2331
2332         * WebKitTestRunner/CMakeLists.txt:
2333         * WebKitTestRunner/InjectedBundle/efl/LayoutTestControllerEfl.cpp:
2334         (WTR::LayoutTestController::platformInitialize):
2335
2336 2012-07-19  Mario Sanchez Prada  <msanchez@igalia.com>
2337
2338         [WK2][GTK] Complete implementation of AccessibilityController in WKTR for GTK
2339         https://bugs.webkit.org/show_bug.cgi?id=89224
2340
2341         Reviewed by Chris Fleizach.
2342
2343         Implement logAccessibilityEvents() and resetToConsistentState(),
2344         so we can ask WKTR from the layout tests for logging all the
2345         accessibility related events into the result.
2346
2347         * WebKitTestRunner/GNUmakefile.am:
2348         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2349         (WTR::AccessibilityController::AccessibilityController):
2350         (WTR):
2351         (WTR::AccessibilityController::logAccessibilityEvents):
2352         (WTR::AccessibilityController::resetToConsistentState):
2353         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2354         (AccessibilityController):
2355         * WebKitTestRunner/InjectedBundle/gtk/AccessibilityControllerGtk.cpp: Added.
2356         (WTR):
2357         (WTR::printAccessibilityEvent):
2358         (WTR::axObjectEventListener):
2359         (WTR::AccessibilityController::logAccessibilityEvents):
2360         (WTR::AccessibilityController::resetToConsistentState):
2361
2362         Ensure we reset the accessibility controller to a consistent
2363         whenever a test has finished running.
2364
2365         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2366         (WTR::InjectedBundle::done):
2367
2368 2012-07-19  Dominik Röttsches  <dominik.rottsches@intel.com>
2369
2370         [EFL][Wk2] Add a bot that runs WTR / WebKit2 tests
2371         https://bugs.webkit.org/show_bug.cgi?id=90788
2372
2373         Reviewed by Kentaro Hara.
2374
2375         Adding EFL 64bit WK2 BuildAndTest bot. At this point, we cannot transfer
2376         the build product from one bot to the other due to link path issues with jhbuild,
2377         so we do a full build and test cycle for WebKit2 on this bot.
2378
2379         * BuildSlaveSupport/build.webkit.org-config/config.json: Adding the new slave.
2380         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Adding a new factory for building and testing WebKit2.
2381         (BuildAndTestWebKit2Factory):
2382
2383 2012-07-18  Mihnea Ovidenie  <mihnea@adobe.com>
2384
2385         Unreviewed. Adding Andrei Bucur, Mihai Balan and Raul Hudea to the contributors list.
2386         They are Adobe contributors working on CSSRegions.
2387
2388         * Scripts/webkitpy/common/config/committers.py:
2389
2390 2012-07-18  Christophe Dumez  <christophe.dumez@intel.com>
2391
2392         [CMake][EFL] Should try to find the same libsoup version pulled by jhbuild
2393         https://bugs.webkit.org/show_bug.cgi?id=91626
2394
2395         Reviewed by Kenneth Rohde Christiansen.
2396
2397         Update jhbuild to pull libsoup 2.39.3 tarball from Gnome FTP instead
2398         of fetching a tag from Gnome GIT. We need to do this to map the version
2399         of libsoup that is required by our CMake config.
2400
2401         * efl/jhbuild.modules:
2402
2403 2012-07-18  MORITA Hajime  <morrita@google.com>
2404
2405         Add window resize benchmark
2406         https://bugs.webkit.org/show_bug.cgi?id=91070
2407
2408         Reviewed by Ryosuke Niwa.
2409
2410         Added some more output filters to take care of html5.html output.
2411
2412         * Scripts/webkitpy/performance_tests/perftest.py:
2413         (PerfTest):
2414
2415 2012-07-18  Dirk Pranke  <dpranke@chromium.org>
2416
2417         nrwt: merge WebKitDriver into Driver
2418         https://bugs.webkit.org/show_bug.cgi?id=91696
2419
2420         Reviewed by Adam Barth.
2421
2422         As part of merging WebKitPort into Port, we also should merge
2423         WebKitDriver into Driver, since all of the non-test Drivers now
2424         inherit from WebKitDriver.
2425
2426         There are no functional changes in this patch, and all the changes should
2427         be covered by the existing tests.
2428
2429         * Scripts/webkitpy/layout_tests/port/base.py:
2430         (Port._driver_class):
2431         * Scripts/webkitpy/layout_tests/port/chromium.py:
2432         (ChromiumPort._check_file_exists):
2433         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2434         (ChromiumAndroidDriver):
2435         (ChromiumAndroidDriver.__init__):
2436         (ChromiumAndroidDriver._drt_cmd_line):
2437         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
2438         (ChromiumAndroidDriverTest.test_read_prompt):
2439         * Scripts/webkitpy/layout_tests/port/driver.py:
2440         (Driver):
2441         (Driver.__init__):
2442         (Driver.__del__):
2443         (Driver.run_test):
2444         (Driver.has_crashed):
2445         (Driver.start):
2446         (Driver._start):
2447         (Driver.stop):
2448         (Driver.cmd_line):
2449         (Driver._check_for_driver_crash):
2450         (Driver._command_from_driver_input):
2451         (Driver._read_first_block):
2452         (Driver._read_optional_image_block):
2453         (Driver._read_header):
2454         (Driver._process_stdout_line):
2455         (Driver._strip_eof):
2456         (Driver._read_block):
2457         (ContentBlock):
2458         (ContentBlock.__init__):
2459         (ContentBlock.decode_content):
2460         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
2461         (DriverTest.make_port):
2462         (DriverTest._assert_wrapper):
2463         (DriverTest.test_read_block):
2464         (DriverTest):
2465         (DriverTest.test_read_binary_block):
2466         (DriverTest.test_read_base64_block):
2467         (DriverTest.test_no_timeout):
2468         (DriverTest.test_check_for_driver_crash):
2469         (DriverTest.test_check_for_driver_crash.FakeServerProcess):
2470         (DriverTest.test_check_for_driver_crash.FakeServerProcess.__init__):
2471         (DriverTest.test_check_for_driver_crash.FakeServerProcess.pid):
2472         (DriverTest.test_check_for_driver_crash.FakeServerProcess.name):
2473         (DriverTest.test_check_for_driver_crash.FakeServerProcess.has_crashed):
2474         (DriverTest.test_check_for_driver_crash.FakeServerProcess.stop):
2475         (DriverTest.test_check_for_driver_crash.assert_crash):
2476         (DriverTest.test_creating_a_port_does_not_write_to_the_filesystem):
2477         (DriverTest.test_stop_cleans_up_properly):
2478         (DriverTest.test_two_starts_cleans_up_properly):
2479         (MockServerProcess):
2480         (MockServerProcess.__init__):
2481         (MockServerProcess.has_crashed):
2482         (MockServerProcess.read_stdout_line):
2483         (MockServerProcess.read_stdout):
2484         (MockServerProcess.read_either_stdout_or_stderr_line):
2485         (MockServerProcess.start):
2486         (MockServerProcess.stop):
2487         (MockServerProcess.kill):
2488         * Scripts/webkitpy/layout_tests/port/gtk.py:
2489         * Scripts/webkitpy/layout_tests/port/webkit.py:
2490         (WebKitPort._read_image_diff):
2491         (WebKitPort.skipped_layout_tests):
2492         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2493         (test_path_to_apache_config_file):
2494         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
2495         (XvfbDriver):
2496         (XvfbDriver.stop):
2497
2498 2012-07-18  Dirk Pranke  <dpranke@chromium.org>
2499
2500         webkitpy.common.system.executive_unittest.ExecutiveTest.test_kill_process is flaky
2501         https://bugs.webkit.org/show_bug.cgi?id=91698
2502
2503         Unreviewed, build fix.
2504
2505         This is a workaround for the test failing (apparently mostly?)
2506         when run in parallel with other tests. The underlying bug still
2507         needs to be diagnosed as we shouldn't be getting ECHILD from
2508         process.wait().
2509
2510         * Scripts/webkitpy/common/system/executive_unittest.py:
2511         (ExecutiveTest.test_kill_process):
2512
2513 2012-07-18  Dirk Pranke  <dpranke@chromium.org>
2514
2515         Disable running python unit tests in parallel on win32 for now.
2516         https://bugs.webkit.org/show_bug.cgi?id=91697
2517
2518         Unreviewed, build fix.
2519
2520         * Scripts/webkitpy/test/main.py:
2521         (Tester._parse_args):
2522
2523 2012-07-18  Dave Tu  <dtu@chromium.org>
2524
2525         [chromium] Add gl_tests to flakiness dashboard.
2526         https://bugs.webkit.org/show_bug.cgi?id=91680
2527
2528         Reviewed by Dirk Pranke.
2529
2530         * TestResultServer/static-dashboards/builders.js:
2531         (loadBuildersList):
2532         * TestResultServer/static-dashboards/dashboard_base.js:
2533         (currentBuilderGroupCategory):
2534
2535 2012-07-18  Dirk Pranke  <dpranke@chromium.org>
2536
2537         fix python unit tests failing under cygwin
2538         https://bugs.webkit.org/show_bug.cgi?id=91678
2539
2540         Reviewed by Adam Barth.
2541
2542         Fix a case where executive.kill_process was failing under cygwin
2543         (apple win port) in an unexpected way.
2544         
2545         * Scripts/webkitpy/common/system/executive.py:
2546         (Executive.kill_process):
2547
2548 2012-07-18  Dirk Pranke  <dpranke@chromium.org>
2549
2550         test-webkitpy: run tests in parallel by default
2551         https://bugs.webkit.org/show_bug.cgi?id=91422
2552
2553         Reviewed by Adam Barth.
2554
2555         We use multiprocessing.cpu_count() for the default number of
2556         jobs to run; memory overhead should be very low, so this should
2557         be fine.
2558
2559         * Scripts/webkitpy/test/main.py:
2560         (Tester._parse_args):
2561
2562 2012-07-18  Ryosuke Niwa  <rniwa@webkit.org>
2563
2564         Add Pravin D to the list of contributors.
2565
2566         * Scripts/webkitpy/common/config/committers.py:
2567
2568 2012-07-18  Balazs Kelemen  <kbalazs@webkit.org>
2569
2570         [Qt] feature detection in orwt/nrwt does not work with force_static_libs_as_shared
2571         https://bugs.webkit.org/show_bug.cgi?id=91514
2572
2573         Reviewed by Dirk Pranke.
2574
2575         Analyzing libQtWebKit.so is not enough in the case of force_static_libs_as_shared.
2576         We need to analyze all the shared library or at least the WebCore one.
2577
2578         * Scripts/webkitdirs.pm:
2579         (builtDylibPathForName):
2580         In orwt it is hard coded to search for symbols in the WebCore library.
2581         While in theory it is possible that symbols for a given feature are not
2582         located in that, it doesn't happen in practice, so returning the path of
2583         the WebCore library for a force_static_libs_as_shared build is enough to
2584         fix the bug and it doesn't require a bigger refactoring. For a default
2585         build we still return the path of the QtWebKit lib.
2586         * Scripts/webkitpy/layout_tests/port/qt.py:
2587         (QtPort._modules_to_search_for_symbols):
2588         Enumerate all dynamic libraries, not just the QtWebKit one.
2589
2590 2012-07-18  Tony Chang  <tony@chromium.org>
2591
2592         [chromium] Unreviewed, more compile fixes on Chromium Win.
2593
2594         * DumpRenderTree/chromium/TestShellWin.cpp:
2595         (TestShell::waitTestFinished):
2596         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
2597
2598 2012-07-18  Christophe Dumez  <christophe.dumez@intel.com>
2599
2600         [EFL] Add central error management to EFL port
2601         https://bugs.webkit.org/show_bug.cgi?id=91598
2602
2603         Reviewed by Kenneth Rohde Christiansen.
2604
2605         Map WebKitNetworkError to NSURLErrorDomain when
2606         printing in DumpRenderTree so that the output
2607         matches the expected one.
2608
2609         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2610         (descriptionSuitableForTestResult):
2611
2612 2012-07-18  Dirk Pranke  <dpranke@chromium.org>
2613
2614         nrwt: start merging port/webkit.py into port/base.py
2615         https://bugs.webkit.org/show_bug.cgi?id=91559
2616
2617         Reviewed by Ojan Vafai.
2618
2619         Since all the non-test port implementations now derive from
2620         WebKitPort, there's no real point in keeping WebKitPort distinct
2621         from Port. This patch starts merging the two by moving nearly
2622         all of the webkit implementations of routines with no default
2623         behavior into base.py. The few that didn't move rely on
2624         additional infrastructure that should be refactored differently
2625         (like the image diffing, which should probably be its own
2626         class) and deserve their own patches.
2627
2628         This patch should just be moving code around, and require no
2629         additional tests; in fact, we can delete the tests that were
2630         asserting virtual methods in the base class.
2631
2632         * Scripts/webkitpy/layout_tests/port/base.py:
2633         (Port.baseline_search_path):
2634         (Port.check_build):
2635         (Port):
2636         (Port._check_driver):
2637         (Port._check_port_build):
2638         (Port.check_image_diff):
2639         (Port.driver_name):
2640         (Port.default_results_directory):
2641         (Port.to.setup_environ_for_server):
2642         (Port._path_to_apache):
2643         (Port._is_redhat_based):
2644         (Port._is_debian_based):
2645         (Port._apache_config_file_name_for_platform):
2646         (Port._path_to_apache_config_file):
2647         (Port._build_path):
2648         (Port._path_to_driver):
2649         (Port._path_to_webcore_library):
2650         (Port._path_to_helper):
2651         (Port._path_to_image_diff):
2652         (Port._path_to_wdiff):
2653         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2654         (PortTest.test_httpd_returns_error_code):
2655         * Scripts/webkitpy/layout_tests/port/webkit.py:
2656         (WebKitPort):
2657         (WebKitPort._build_driver_flags):
2658         (WebKitPort._read_image_diff):
2659         (WebKitPort.skipped_layout_tests):
2660
2661 2012-07-18  Tommy Widenflycht  <tommyw@google.com>
2662
2663         [chromium] MediaStream API: Moving the mock create* WebRTC calls into a shadow Platform class
2664         https://bugs.webkit.org/show_bug.cgi?id=86215
2665
2666         Reviewed by Adam Barth.
2667
2668         Adding a shadow Platform object that is used to override some WebKit::Platform funtions to
2669         instead create mock objects. No actual mock objects created yet.
2670
2671         * DumpRenderTree/DumpRenderTree.gypi:
2672         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2673         (WebKitSupportTestEnvironment::WebKitSupportTestEnvironment):
2674         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp: Copied from Tools/DumpRenderTree/chromium/config.h.
2675         (MockWebKitPlatformSupport::create):
2676         (MockWebKitPlatformSupport::MockWebKitPlatformSupport):
2677         (MockWebKitPlatformSupport::cryptographicallyRandomValues):
2678         (MockWebKitPlatformSupport::createMediaStreamCenter):
2679         * DumpRenderTree/chromium/MockWebKitPlatformSupport.h: Copied from Tools/DumpRenderTree/chromium/config.h.
2680         (MockWebKitPlatformSupport):
2681         * DumpRenderTree/chromium/config.h:
2682
2683 2012-07-18  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2684
2685         [CMake][EFL] Build and run TestWebKitAPI unit tests
2686         https://bugs.webkit.org/show_bug.cgi?id=90671
2687
2688         Reviewed by Daniel Bates.
2689
2690         This patch enables almost for free a significant amount of test for the
2691         WebKit C API, WTF and KURL. It makes easy for CMake based ports to
2692         enable TestWebKitAPI since the missing bits to implement are
2693         relatively simple.
2694
2695         * CMakeLists.txt:
2696         * TestWebKitAPI/CMakeLists.txt: Added.
2697         * TestWebKitAPI/PlatformEfl.cmake: Added.
2698         * TestWebKitAPI/PlatformWebView.h:
2699         * TestWebKitAPI/config.h:
2700         * TestWebKitAPI/efl/InjectedBundleController.cpp: Added.
2701         (TestWebKitAPI):
2702         (TestWebKitAPI::InjectedBundleController::platformInitialize):
2703         * TestWebKitAPI/efl/PlatformUtilities.cpp: Added.
2704         (TestWebKitAPI):
2705         (Util):
2706         (TestWebKitAPI::Util::run):
2707         (TestWebKitAPI::Util::sleep):
2708         (TestWebKitAPI::Util::createURLForResource):
2709         (TestWebKitAPI::Util::createInjectedBundlePath):
2710         (TestWebKitAPI::Util::URLForNonExistentResource):
2711         * TestWebKitAPI/efl/PlatformWebView.cpp: Added.
2712         (TestWebKitAPI):
2713         (TestWebKitAPI::initEcoreEvas):
2714         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2715         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2716         (TestWebKitAPI::PlatformWebView::page):
2717         * TestWebKitAPI/efl/main.cpp: Added.
2718         (checkForUseX11WindowArgument):
2719         (main):
2720
2721 2012-07-18  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2722
2723         [CMake][EFL] Building jsc causes reconfiguration
2724         https://bugs.webkit.org/show_bug.cgi?id=91387
2725
2726         Reviewed by Daniel Bates.
2727
2728         We should remove CMakeCache only when running build-webkit script,
2729         otherwise it will cause a reconfiguration every time someone calls
2730         generateBuildSystemFromCMakeProject(). We were re-building "jsc" and
2731         not running WebKit2 unit tests on the bots because the project was
2732         reconfigured with default values by the scripts that run these tests.
2733
2734         * Scripts/build-webkit:
2735         * Scripts/webkitdirs.pm:
2736         (removeCMakeCache):
2737         (generateBuildSystemFromCMakeProject):
2738
2739 2012-07-18  Seokju Kwon  <seokju.kwon@samsung.com>
2740
2741         [EFL][DRT] Add support for Web Inspector in WebKit-EFL DRT
2742         https://bugs.webkit.org/show_bug.cgi?id=87935
2743
2744         Reviewed by Andreas Kling.
2745
2746         Web Inspector will be shown when path or url contains "inspector/".
2747         Dumprendertree should wait util web inspector resources are loaded totally
2748         and handle the signals for creating or removing a view of web inspector.
2749         ("inspector,view,create" and "inspector,view,close")
2750
2751         * DumpRenderTree/efl/DumpRenderTree.cpp:
2752         (shouldOpenWebInspector):
2753         (createLayoutTestController):
2754         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2755         (DumpRenderTreeChrome::createView):
2756         (DumpRenderTreeChrome::createWebInspectorView):
2757         (DumpRenderTreeChrome::removeWebInspectorView):
2758         (DumpRenderTreeChrome::waitInspectorLoadFinished):
2759         (DumpRenderTreeChrome::onInspectorViewCreate):
2760         (DumpRenderTreeChrome::onInspectorViewClose):
2761         (DumpRenderTreeChrome::onInspectorFrameLoadFinished):
2762         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
2763         (DumpRenderTreeChrome):
2764         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2765         (onConsoleMessage):
2766         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2767         (LayoutTestController::showWebInspector):
2768         (LayoutTestController::closeWebInspector):
2769         (LayoutTestController::evaluateInWebInspector):
2770
2771 2012-07-18  Simon Hausmann  <simon.hausmann@nokia.com>
2772
2773         [ANGLE] On QT, use Bison and Flex during ANGLE build
2774         https://bugs.webkit.org/show_bug.cgi?id=91108
2775
2776         Reviewed by Kenneth Rohde Christiansen.
2777
2778         * qmake/mkspecs/features/default_post.prf: Add support for variable_out to our generators, to allow
2779         generating not only for SOURCES but also ANGLE_SOURCES (in this bug)
2780
2781 2012-07-18  Balazs Kelemen  <kbalazs@webkit.org>
2782
2783         [Qt] plugin tests should not be disabled for WebKit1
2784         https://bugs.webkit.org/show_bug.cgi?id=91604
2785
2786         Reviewed by Simon Hausmann.
2787
2788         Instead of not building TestNetscapePlugIn, we could programatically
2789         disable actually loading it from WTR until https://bugs.webkit.org/show_bug.cgi?id=86620
2790         has been solved, so we can still test plugins on WebKit1.
2791
2792         * Tools.pro:
2793         * WebKitTestRunner/TestController.cpp:
2794         (WTR::TestController::initialize):
2795         * WebKitTestRunner/qt/TestControllerQt.cpp:
2796         (WTR::TestController::initializeTestPluginDirectory):
2797
2798 2012-07-18  Mario Sanchez Prada  <msanchez@igalia.com>
2799
2800         [WK2][GTK] Implement AccessibilityUIElement in WKTR for GTK
2801         https://bugs.webkit.org/show_bug.cgi?id=89223
2802
2803         Reviewed by Chris Fleizach.
2804
2805         Implemented AccessibilityUIElement in WKTR for GTK, based in the
2806         implementation present in DumpRenderTree.
2807
2808         Added new files in gtk/ and updated the cross-platform ones.
2809
2810         * WebKitTestRunner/GNUmakefile.am:
2811         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2812         (WTR):
2813         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2814         (AccessibilityUIElement):
2815         * WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp: Added.
2816         (WTR):
2817         (WTR::attributeSetToString):
2818         (WTR::checkElementState):
2819         (WTR::indexRangeInTable):
2820         (WTR::alterCurrentValue):
2821         (WTR::AccessibilityUIElement::AccessibilityUIElement):
2822         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
2823         (WTR::AccessibilityUIElement::isEqual):
2824         (WTR::AccessibilityUIElement::getChildren):
2825         (WTR::AccessibilityUIElement::getChildrenWithRange):
2826         (WTR::AccessibilityUIElement::childrenCount):
2827         (WTR::AccessibilityUIElement::elementAtPoint):
2828         (WTR::AccessibilityUIElement::indexOfChild):
2829         (WTR::AccessibilityUIElement::childAtIndex):
2830         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
2831         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
2832         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
2833         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
2834         (WTR::AccessibilityUIElement::rowAtIndex):
2835         (WTR::AccessibilityUIElement::selectedChildAtIndex):
2836         (WTR::AccessibilityUIElement::selectedChildrenCount):
2837         (WTR::AccessibilityUIElement::selectedRowAtIndex):
2838         (WTR::AccessibilityUIElement::titleUIElement):
2839         (WTR::AccessibilityUIElement::parentElement):
2840         (WTR::AccessibilityUIElement::disclosedByRow):
2841         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
2842         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
2843         (WTR::AccessibilityUIElement::attributesOfChildren):
2844         (WTR::AccessibilityUIElement::allAttributes):
2845         (WTR::AccessibilityUIElement::stringAttributeValue):
2846         (WTR::AccessibilityUIElement::numberAttributeValue):
2847         (WTR::AccessibilityUIElement::uiElementAttributeValue):
2848         (WTR::AccessibilityUIElement::boolAttributeValue):
2849         (WTR::AccessibilityUIElement::isAttributeSettable):
2850         (WTR::AccessibilityUIElement::isAttributeSupported):
2851         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
2852         (WTR::AccessibilityUIElement::role):
2853         (WTR::AccessibilityUIElement::subrole):
2854         (WTR::AccessibilityUIElement::roleDescription):
2855         (WTR::AccessibilityUIElement::title):
2856         (WTR::AccessibilityUIElement::description):
2857         (WTR::AccessibilityUIElement::orientation):
2858         (WTR::AccessibilityUIElement::stringValue):
2859         (WTR::AccessibilityUIElement::language):
2860         (WTR::AccessibilityUIElement::helpText):
2861         (WTR::AccessibilityUIElement::x):
2862         (WTR::AccessibilityUIElement::y):
2863         (WTR::AccessibilityUIElement::width):
2864         (WTR::AccessibilityUIElement::height):
2865         (WTR::AccessibilityUIElement::clickPointX):
2866         (WTR::AccessibilityUIElement::clickPointY):
2867         (WTR::AccessibilityUIElement::intValue):
2868         (WTR::AccessibilityUIElement::minValue):
2869         (WTR::AccessibilityUIElement::maxValue):
2870         (WTR::AccessibilityUIElement::valueDescription):
2871         (WTR::AccessibilityUIElement::insertionPointLineNumber):
2872         (WTR::AccessibilityUIElement::isActionSupported):
2873         (WTR::AccessibilityUIElement::isEnabled):
2874         (WTR::AccessibilityUIElement::isRequired):
2875         (WTR::AccessibilityUIElement::isFocused):
2876         (WTR::AccessibilityUIElement::isSelected):
2877         (WTR::AccessibilityUIElement::isExpanded):
2878         (WTR::AccessibilityUIElement::isChecked):
2879         (WTR::AccessibilityUIElement::hierarchicalLevel):
2880         (WTR::AccessibilityUIElement::speak):
2881         (WTR::AccessibilityUIElement::ariaIsGrabbed):
2882         (WTR::AccessibilityUIElement::ariaDropEffects):
2883         (WTR::AccessibilityUIElement::lineForIndex):
2884         (WTR::AccessibilityUIElement::rangeForLine):
2885         (WTR::AccessibilityUIElement::rangeForPosition):
2886         (WTR::AccessibilityUIElement::boundsForRange):
2887         (WTR::AccessibilityUIElement::stringForRange):
2888         (WTR::AccessibilityUIElement::attributedStringForRange):
2889         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
2890         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2891         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
2892         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
2893         (WTR::AccessibilityUIElement::attributesOfColumns):
2894         (WTR::AccessibilityUIElement::attributesOfRows):
2895         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
2896         (WTR::AccessibilityUIElement::attributesOfHeader):
2897         (WTR::AccessibilityUIElement::rowCount):
2898         (WTR::AccessibilityUIElement::columnCount):
2899         (WTR::AccessibilityUIElement::indexInTable):
2900         (WTR::AccessibilityUIElement::rowIndexRange):
2901         (WTR::AccessibilityUIElement::columnIndexRange):
2902         (WTR::AccessibilityUIElement::cellForColumnAndRow):
2903         (WTR::AccessibilityUIElement::horizontalScrollbar):
2904         (WTR::AccessibilityUIElement::verticalScrollbar):
2905         (WTR::AccessibilityUIElement::selectedTextRange):
2906         (WTR::AccessibilityUIElement::setSelectedTextRange):
2907         (WTR::AccessibilityUIElement::increment):
2908         (WTR::AccessibilityUIElement::decrement):
2909         (WTR::AccessibilityUIElement::showMenu):
2910         (WTR::AccessibilityUIElement::press):
2911         (WTR::AccessibilityUIElement::setSelectedChild):
2912         (WTR::AccessibilityUIElement::accessibilityValue):
2913         (WTR::AccessibilityUIElement::documentEncoding):
2914         (WTR::AccessibilityUIElement::documentURI):
2915         (WTR::AccessibilityUIElement::url):
2916         (WTR::AccessibilityUIElement::addNotificationListener):
2917         (WTR::AccessibilityUIElement::removeNotificationListener):
2918         (WTR::AccessibilityUIElement::isFocusable):
2919         (WTR::AccessibilityUIElement::isSelectable):
2920         (WTR::AccessibilityUIElement::isMultiSelectable):
2921         (WTR::AccessibilityUIElement::isVisible):
2922         (WTR::AccessibilityUIElement::isOffScreen):
2923         (WTR::AccessibilityUIElement::isCollapsed):
2924         (WTR::AccessibilityUIElement::isIgnored):
2925         (WTR::AccessibilityUIElement::hasPopup):
2926         (WTR::AccessibilityUIElement::takeFocus):
2927         (WTR::AccessibilityUIElement::takeSelection):
2928         (WTR::AccessibilityUIElement::addSelection):
2929         (WTR::AccessibilityUIElement::removeSelection):
2930         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
2931         (WTR::AccessibilityUIElement::textMarkerRangeLength):
2932         (WTR::AccessibilityUIElement::previousTextMarker):
2933         (WTR::AccessibilityUIElement::nextTextMarker):
2934         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
2935         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
2936         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
2937         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
2938         (WTR::AccessibilityUIElement::textMarkerForPoint):
2939         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
2940         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
2941         (WTR::AccessibilityUIElement::indexForTextMarker):
2942         (WTR::AccessibilityUIElement::isTextMarkerValid):
2943         (WTR::AccessibilityUIElement::textMarkerForIndex):
2944
2945         Add documentEncoding and documentURI to AccessibilityUIElement.idl.
2946
2947         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2948
2949 2012-07-18  Alexis Menard  <alexis.menard@openbossa.org>
2950
2951         [EFL] Build fix in WebKitTestRunner.
2952         https://bugs.webkit.org/show_bug.cgi?id=91567
2953
2954         Reviewed by Kentaro Hara.
2955
2956         sleep() is defined in unistd.h, we need to include it.
2957
2958         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2959
2960 2012-07-18  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2961
2962         [NRWT] Unreviewed gardening after r122913
2963         https://bugs.webkit.org/show_bug.cgi?id=91601
2964
2965         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
2966         (TrivialMockPort.process_kill_time):
2967
2968 2012-07-17  Xianzhu Wang  <wangxianzhu@chromium.org>
2969
2970         [Chromium-Android] Run ref tests together to avoid expensive driver restarts
2971         https://bugs.webkit.org/show_bug.cgi?id=91533
2972
2973         Reviewed by Dirk Pranke.
2974
2975         Though DriverProxy maintains two drivers to support pixel tests and non-pixel tests,
2976         chromium-android uses another way because it can't support multiple drivers.
2977         It restarts the driver when pixel-test mode changes (e.g. when running a ref test after
2978         a normal test in --no-pixel-tests mode). However restarting driver is expensive on
2979         Android (several seconds each time). To reduce the cost, a command line option
2980         '--shard-ref-tests' is added to group ref tests in dedicated shards.
2981         The option is by default enabled on Android.
2982
2983         Will remove the option once DRT supports switching pixel test mode during one run.
2984         (https://bugs.webkit.org/show_bug.cgi?id=91538, https://bugs.webkit.org/show_bug.cgi?id=91539)
2985
2986         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2987         (Manager._shard_tests):
2988         (Manager._shard_in_two):
2989         (Manager._shard_by_directory):
2990         (Manager._run_tests):
2991         * Scripts/webkitpy/layout_tests/controllers/worker.py:
2992         (Worker._update_test_input):
2993         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2994         (ChromiumAndroidPort.__init__):
2995         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2996         (parse_args):
2997
2998 2012-07-17  Don Olmstead  <don.olmstead@am.sony.com>
2999
3000         NRWT The time before server_process kills DRT should be variable
3001         https://bugs.webkit.org/show_bug.cgi?id=91542
3002
3003         Reviewed by Dirk Pranke.
3004
3005         Added the ability to configure the amount of time
3006         server_process waits before killing the DRT process
3007         during the call to stop.
3008
3009         * Scripts/webkitpy/layout_tests/port/base.py:
3010         (Port.variable.process_kill_time):
3011         * Scripts/webkitpy/layout_tests/port/server_process.py:
3012         (ServerProcess.stop):
3013
3014 2012-07-17  Alexis Menard  <alexis.menard@openbossa.org>
3015
3016         webkitdirs.pm should fallback to uname -m if arch is not present.
3017         https://bugs.webkit.org/show_bug.cgi?id=91543
3018
3019         Reviewed by Martin Robinson.
3020
3021         It seems that coreutils is moving away from the 'arch' command. Archlinux
3022         for example doesn't ship it anymore (coreutils 8.17). We can then fallback
3023         to 'uname -m' to find out the architecture.
3024
3025         * Scripts/webkitdirs.pm:
3026         (determineArchitecture):
3027
3028 2012-07-17  Dirk Pranke  <dpranke@chromium.org>
3029
3030         nrwt: rename printer.print_update to printer.write_update to match metered_stream
3031         https://bugs.webkit.org/show_bug.cgi?id=91557
3032
3033         Reviewed by Ojan Vafai.
3034
3035         Now that all of the printing logic is in printer.py, I want the
3036         public interface to printer to follow the meteredstream
3037         interface where possible. renaming write_update() gets us close.
3038
3039         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3040         (Manager._run_tests):
3041         (Manager._set_up_run):
3042         (Manager.start_servers_with_lock):
3043         (Manager.stop_servers_with_lock):
3044         (Manager._clobber_old_results):
3045         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3046         (run):
3047         * Scripts/webkitpy/layout_tests/views/printing.py:
3048         (Printer.write_update):
3049         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3050         (Testprinter.test_write_update):
3051
3052 2012-07-17  Tony Chang  <tony@chromium.org>
3053
3054         Fix a bug where optimize-baselines would incorrectly fail to optimize
3055         https://bugs.webkit.org/show_bug.cgi?id=91551
3056
3057         Reviewed by Adam Barth.
3058
3059         In some cases, optimize-baseline would correctly optimize the results, but because
3060         we weren't filtering the virtual ports out of _results_by_port_name, we thought
3061         that we had failed to optimize.
3062
3063         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
3064         (BaselineOptimizer._find_optimal_result_placement): No virtual filtering here.
3065         (BaselineOptimizer._filtered_results_by_port_name): New function that filters out virtual directories.
3066         (BaselineOptimizer.optimize): Filter out virtual ports.
3067         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
3068         (TestBaselineOptimizer._move_baselines): Add a stub so we don't actual move results.
3069         (BaselineOptimizerTest._assertOptimization): Call optimize and verify that the right files were moved.
3070         (BaselineOptimizerTest._assertOptimizationFailed): Add a method for when optimization should fail.
3071         (BaselineOptimizerTest.test_common_directory_includes_root): Update since this test should fail.
3072         (BaselineOptimizerTest.test_virtual_ports_filtered): New test case that demonstrates the bug.
3073
3074 2012-07-17  Xianzhu Wang  <wangxianzhu@chromium.org>
3075
3076         [Chromium] Add --encode-binary command line option for DRT
3077         https://bugs.webkit.org/show_bug.cgi?id=91532
3078
3079         Reviewed by Adam Barth.
3080
3081         When the option presents, DRT will encode binary output data in base64.
3082         ChromiumAndroidPort will pass the option because 'adb shell' doesn't support
3083         binary data output.
3084
3085         This change is a refactoring to replace the original hard-coded code for Android.
3086
3087         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3088         (main):
3089         * DumpRenderTree/chromium/TestEventPrinter.cpp:
3090         (TestEventPrinter::TestEventPrinter):
3091         (TestEventPrinter::handleAudio): New function replacing the original handleAudioHeader
3092         (TestEventPrinter::handleImage):
3093         (TestEventPrinter::handleBinary): Extracted common function for handleAudio and handleImage
3094         * DumpRenderTree/chromium/TestEventPrinter.h:
3095         (TestEventPrinter):
3096         * DumpRenderTree/chromium/TestShell.cpp:
3097         (TestShell::TestShell):
3098         (TestShell::initialize):
3099         (TestShell::dump):
3100         * DumpRenderTree/chromium/TestShell.h:
3101         (TestShell):
3102         (TestShell::setEncodeBinary):
3103         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Add --encode-binary to additional_drt_flags
3104         (ChromiumAndroidPort.__init__):
3105
3106 2012-07-17  Dirk Pranke  <dpranke@chromium.org>
3107
3108         nrwt: move per-test result output into printing.py
3109         https://bugs.webkit.org/show_bug.cgi?id=91465
3110
3111         Reviewed by Ojan Vafai.
3112
3113         This moves the last substantive logging/printing code from the
3114         manager into printing.py. Subsequent patches in this thread can
3115         largely focus on cleaning up printing.py and will leave the rest
3116         of the code alone.
3117
3118         This patch also removes manager.update() and
3119         manager.update_summary(), two routines that were no longer being
3120         used or needed (they have been dead for a long time but I didn't
3121         notice them until now).
3122
3123         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3124         (Manager.results_directory):
3125         (Manager._look_for_new_crash_logs):
3126         (Manager._update_summary_with_result):
3127         * Scripts/webkitpy/layout_tests/views/printing.py:
3128         (Printer.print_finished_test):
3129
3130 2012-07-17  Dirk Pranke  <dpranke@chromium.org>
3131
3132         nrwt: move config-specific logging to printing.py
3133         https://bugs.webkit.org/show_bug.cgi?id=91450
3134
3135         Reviewed by Ojan Vafai.
3136
3137         More refactoring ... this moves the 'config' output to
3138         printing.py.
3139
3140         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3141         (Manager._resize_shards):
3142         (Manager._run_tests):
3143         (Manager._upload_json_files):
3144         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3145         (ManagerTest.get_options):
3146         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3147         (run):
3148         * Scripts/webkitpy/layout_tests/views/printing.py:
3149         (Printer.print_config):
3150         (Printer.print_workers_and_shards):
3151         (Printer._print_config):
3152         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3153         (Testprinter.test_fallback_path_in_config):
3154         (Testprinter.test_print_config):
3155
3156 2012-07-17  Dirk Pranke  <dpranke@chromium.org>
3157
3158         nrwt: clean up logging when we're only running one chunk of the tests
3159         https://bugs.webkit.org/show_bug.cgi?id=91447
3160
3161         Reviewed by Ojan Vafai.
3162
3163         Apparently we were creating a 'tests_run.txt' in the results
3164         directory if we were only running one chunk of the tests; after
3165         3+ years of hacking on this code, that was news to me, so I'm
3166         guessing no one uses this. I'm removing this, and changing the
3167         _print_expected calls to debug messages to simplify the
3168         layering.
3169
3170         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3171         (Manager._split_into_chunks_if_necessary):
3172
3173 2012-07-17  Dirk Pranke  <dpranke@chromium.org>
3174
3175         Fix regression in style checker introduced in r122868.
3176         https://bugs.webkit.org/show_bug.cgi?id=91470
3177
3178         Unreviewed, build fix.
3179
3180         * Scripts/webkitpy/style/checkers/cpp.py:
3181         (_FileState.__init__):
3182
3183 2012-07-17  Dirk Pranke  <dpranke@chromium.org>
3184
3185         nrwt: move the bulk of the "expected" output to printing.py
3186         https://bugs.webkit.org/show_bug.cgi?id=91442
3187
3188         Reviewed by Ojan Vafai.
3189
3190         More printing-related refactoring. This moves all of the code
3191         that prints the results we expect to get, but doesn't move a few
3192         dangling printfs (those'll get hit in a later patch).
3193         
3194         No functional changes; covered by existing tests.
3195
3196         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3197         (Manager._split_into_chunks_if_necessary):
3198         (Manager.prepare_lists_and_print_output):
3199         (Manager.print_config):
3200         * Scripts/webkitpy/layout_tests/views/printing.py:
3201         (Printer.print_expected):
3202         (Printer):
3203         (Printer._print_expected_results_of_type):
3204         (Printer._num_digits):
3205         (Printer._print_expected):
3206         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3207         (Testprinter.test_print_expected):
3208
3209 2012-07-17  Christophe Dumez  <christophe.dumez@intel.com>
3210
3211         [EFL] Replace 0 by NULL in public headers documentation
3212         https://bugs.webkit.org/show_bug.cgi?id=91470
3213
3214         Reviewed by Dirk Pranke.
3215
3216         Fix style checking to properly detect C headers as C
3217         files. Without this change, the style script would
3218         complain if we use NULL (instead of 0 / null) in C
3219         headers.
3220
3221         * Scripts/webkitpy/style/checkers/cpp.py:
3222         (_FileState.__init__):
3223         (_FileState.is_c):
3224         (_FileState.is_c_or_objective_c):
3225
3226 2012-07-17  Xianzhu Wang  <wangxianzhu@chromium.org>
3227
3228         [chromium] remove --test-shell support from DRT
3229         https://bugs.webkit.org/show_bug.cgi?id=86927
3230
3231         Reviewed by Adam Barth.
3232
3233         Now no one use --test-shell. All of us use the standard DRT mode.
3234
3235         * DumpRenderTree/chromium/DumpRenderTree.cpp: Removed support of --test-shell and --pixel-tests=filename options. (--pixel-tests without '=' is kept for DRT mode.)
3236         (runTest):
3237         (main):
3238         * DumpRenderTree/chromium/TestEventPrinter.cpp:
3239         (TestEventPrinter::TestEventPrinter):
3240         (TestEventPrinter::~TestEventPrinter):
3241         (TestEventPrinter::handleTestHeader):
3242         (TestEventPrinter::handleTimedOut):
3243         (TestEventPrinter::handleTextHeader):
3244         (TestEventPrinter::handleTextFooter):
3245         (TestEventPrinter::handleAudioHeader):
3246         (TestEventPrinter::handleAudioFooter):
3247         (TestEventPrinter::handleImage): Removed the unused filename parameter.
3248         (TestEventPrinter::handleTestFooter):
3249         * DumpRenderTree/chromium/TestEventPrinter.h:
3250         (TestEventPrinter): Made it a concrete class because we have only one implementation.
3251         * DumpRenderTree/chromium/TestShell.cpp:
3252         (TestShell::TestShell):
3253         (TestShell::initialize):
3254         (TestShell::dumpImage):
3255         * DumpRenderTree/chromium/TestShell.h:
3256         (TestParams): Removed pixelFileName field.
3257         (TestShell):
3258
3259 2012-07-17  Xianzhu Wang  <wangxianzhu@chromium.org>
3260
3261         remove ChromiumDriver from NRWT
3262         https://bugs.webkit.org/show_bug.cgi?id=88478
3263
3264         Now WebKitDriver has replaced ChromiumDriver since test_shell mode is deperecated.
3265
3266         Reviewed by Dirk Pranke.
3267
3268         * Scripts/webkitpy/layout_tests/port/chromium.py: Removed ChromiumDriver code.
3269         (ChromiumPort._driver_class): Removed. WebKitPort._driver_class() will be used.
3270         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3271
3272 2012-07-17  No'am Rosenthal  <noam.rosenthal@nokia.com>
3273
3274         Unreviewed. Add QtGraphics, TextureMapper and OpenGL to watchlist.
3275
3276         * Scripts/webkitpy/common/config/watchlist:
3277
3278 2012-07-17  Sheriff Bot  <webkit.review.bot@gmail.com>
3279
3280         Unreviewed, rolling out r122828.
3281         http://trac.webkit.org/changeset/122828
3282         https://bugs.webkit.org/show_bug.cgi?id=91516
3283
3284         DumpRenderTree crashes after printing test results. (Requested
3285         by vsevik on #webkit).
3286
3287         * DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
3288         (TestInterfaces::TestInterfaces):
3289         (TestInterfaces::~TestInterfaces):
3290         (TestInterfaces::bindTo):
3291         (TestInterfaces::resetAll):
3292         * DumpRenderTree/chromium/TestRunner/TestInterfaces.h:
3293         (TestInterfaces):
3294         * DumpRenderTree/chromium/TestShell.cpp:
3295         (TestShell::initialize):
3296         (TestShell::createMainWindow):
3297         (TestShell::~TestShell):
3298         (TestShell::resetTestController):
3299         (TestShell::bindJSObjectsToWindow):
3300         * DumpRenderTree/chromium/TestShell.h:
3301         (TestShell::accessibilityController):
3302         (TestShell):
3303
3304 2012-07-17  Gabor Ballabas  <gaborb@inf.u-szeged.hu>
3305
3306         [Qt][V8] Remove the V8 related codepaths and configuration
3307         https://bugs.webkit.org/show_bug.cgi?id=90863
3308
3309         Reviewed by Simon Hausmann.
3310
3311         * Scripts/build-webkit: Remove --v8 option.
3312
3313 2012-07-17  Sheriff Bot  <webkit.review.bot@gmail.com>
3314
3315         Unreviewed, rolling out r122834.
3316         http://trac.webkit.org/changeset/122834
3317         https://bugs.webkit.org/show_bug.cgi?id=91492
3318
3319         it broke the chromium (Requested by kkristof on #webkit).
3320
3321         * Scripts/build-webkit:
3322
3323 2012-07-17  Gabor Ballabas  <gaborb@inf.u-szeged.hu>
3324
3325         [Qt][V8] Remove the V8 related codepaths and configuration
3326         https://bugs.webkit.org/show_bug.cgi?id=90863
3327
3328         Reviewed by Simon Hausmann.
3329
3330         * Scripts/build-webkit: Remove --v8 option.
3331
3332 2012-07-17  Balazs Kelemen  <kbalazs@webkit.org>
3333
3334         [Qt] Add --use-test-fonts option to Minibrowser
3335         https://bugs.webkit.org/show_bug.cgi?id=91402
3336
3337         Reviewed by Tor Arne Vestbø.
3338
3339         Same stuff that already exists for QtTestBrowser.
3340
3341         * MiniBrowser/qt/MiniBrowser.pro:
3342         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3343         (MiniBrowserApplication::handleUserOptions):
3344
3345 2012-07-17  Adam Barth  <abarth@webkit.org>
3346
3347         [Chromium] TestInterfaces should be responsible for owning and binding AccessibilityController and TextInputController
3348         https://bugs.webkit.org/show_bug.cgi?id=91459
3349
3350         Reviewed by Ryosuke Niwa.
3351
3352         Rather than having TestShell own and bind each of these JavaScript APIs
3353         individually, TestShell should delegate that work to TestInterfaces.
3354         This patch moves AccessibilityController and TextInputController to be
3355         the responsibility of TestInterfaces.
3356
3357         * DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
3358         (TestInterfaces::TestInterfaces):
3359         (TestInterfaces::~TestInterfaces):
3360         (TestInterfaces::setWebView):
3361         (TestInterfaces::bindTo):
3362         (TestInterfaces::resetAll):
3363         * DumpRenderTree/chromium/TestRunner/TestInterfaces.h:
3364         (WebKit):
3365         (TestInterfaces):
3366         (TestInterfaces::accessibilityController):
3367         * DumpRenderTree/chromium/TestShell.cpp:
3368         (TestShell::initialize):
3369         (TestShell::createMainWindow):
3370         (TestShell::~TestShell):
3371         (TestShell::resetTestController):
3372         (TestShell::bindJSObjectsToWindow):
3373         * DumpRenderTree/chromium/TestShell.h:
3374         (TestShell::accessibilityController):
3375         (TestShell):
3376
3377 2012-07-17  Adam Barth  <abarth@webkit.org>
3378
3379         [Chromium] Move TextInputController into TestRunner.a
3380         https://bugs.webkit.org/show_bug.cgi?id=91457
3381
3382         Reviewed by Ryosuke Niwa.
3383
3384         This patch is purely moving code. TextInputController is one of the
3385         objects exposed to JavaScript and so should be in the TestRunner
3386         library.
3387
3388         * DumpRenderTree/DumpRenderTree.gypi:
3389         * DumpRenderTree/chromium/TestRunner/TextInputController.cpp: Renamed from Tools/DumpRenderTree/chromium/TextInputController.cpp.
3390         * DumpRenderTree/chromium/TestRunner/TextInputController.h: Renamed from Tools/DumpRenderTree/chromium/TextInputController.h.
3391
3392 2012-07-17  Adam Barth  <abarth@webkit.org>
3393
3394         [Chromium] TextInputController shouldn't know about TestShell
3395         https://bugs.webkit.org/show_bug.cgi?id=91455
3396
3397         Reviewed by Kent Tamura.
3398
3399         This patch uses the same pattern we used for the
3400         AccessibilityController to remove the dependency on TestShell.
3401
3402         * DumpRenderTree/chromium/TestShell.cpp:
3403         (TestShell::initialize):
3404         (TestShell::createMainWindow):
3405         (TestShell::~TestShell):
3406         * DumpRenderTree/chromium/TextInputController.cpp:
3407         (TextInputController::TextInputController):
3408         (TextInputController::insertText):
3409         (TextInputController::doCommand):
3410         (TextInputController::setMarkedText):
3411         (TextInputController::unmarkText):
3412         (TextInputController::hasMarkedText):
3413         (TextInputController::markedRange):
3414         (TextInputController::selectedRange):
3415         (TextInputController::firstRectForCharacterRange):
3416         (TextInputController::validAttributesForMarkedText):
3417         (TextInputController::setComposition):
3418         * DumpRenderTree/chromium/TextInputController.h:
3419         (WebKit):
3420         (TextInputController):
3421         (TextInputController::setWebView):
3422
3423 2012-07-17  David Barr  <davidbarr@chromium.org>
3424
3425         Introduce ENABLE_CSS_IMAGE_ORIENTATION compile flag
3426         https://bugs.webkit.org/show_bug.cgi?id=89055
3427
3428         Reviewed by Kent Tamura.
3429
3430         The css3-images module is at candidate recommendation.
3431         http://www.w3.org/TR/2012/CR-css3-images-20120417/#the-image-orientation
3432
3433         Add a configuration option for CSS image-orientation support, disabling it by default.
3434
3435         * Scripts/webkitperl/FeatureList.pm:
3436         * qmake/mkspecs/features/features.pri:
3437
3438 2012-07-16  Adam Barth  <abarth@webkit.org>
3439
3440         [Chromium] Move Task.(cpp|h) into TestRunner.a
3441         https://bugs.webkit.org/show_bug.cgi?id=91446
3442
3443         Reviewed by Ryosuke Niwa.
3444
3445         Task is a dependency of EventSender, which needs to move into TestRunner.a.
3446
3447         * DumpRenderTree/DumpRenderTree.gypi:
3448         * DumpRenderTree/chromium/TestRunner/Task.cpp: Renamed from Tools/DumpRenderTree/chromium/Task.cpp.
3449         * DumpRenderTree/chromium/TestRunner/Task.h: Renamed from Tools/DumpRenderTree/chromium/Task.h.
3450
3451 2012-07-16  Adam Barth  <abarth@webkit.org>
3452
3453         [Chromium] Move AccessibilityController and AccessibilityUIElement into TestRunner.a
3454         https://bugs.webkit.org/show_bug.cgi?id=91443
3455
3456         Reviewed by Tony Chang.
3457
3458         Purely a file move (and a sorting of #includes).
3459
3460         * DumpRenderTree/DumpRenderTree.gypi:
3461         * DumpRenderTree/chromium/TestRunner/AccessibilityController.cpp: Renamed from Tools/DumpRenderTree/chromium/AccessibilityController.cpp.
3462         * DumpRenderTree/chromium/TestRunner/AccessibilityController.h: Renamed from Tools/DumpRenderTree/chromium/AccessibilityController.h.
3463         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElement.cpp: Renamed from Tools/DumpRenderTree/chromium/AccessibilityUIElement.cpp.
3464         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElement.h: Renamed from Tools/DumpRenderTree/chromium/AccessibilityUIElement.h.
3465
3466 2012-07-16  Adam Barth  <abarth@webkit.org>
3467
3468         [Chromium] AccessibilityController shouldn't know anything about TestShell
3469         https://bugs.webkit.org/show_bug.cgi?id=91441
3470
3471         Reviewed by Tony Chang.
3472
3473         This patch is a precursor to moving AccessibilityController.cpp into TestRunner.a.
3474
3475         * DumpRenderTree/chromium/AccessibilityController.cpp:
3476         (AccessibilityController::AccessibilityController):
3477         (AccessibilityController::getFocusedElement):
3478         (AccessibilityController::getRootElement):
3479         * DumpRenderTree/chromium/AccessibilityController.h:
3480         (WebKit):
3481         (AccessibilityController):
3482         (AccessibilityController::setWebView):
3483         * DumpRenderTree/chromium/TestShell.cpp:
3484         (TestShell::initialize):
3485         (TestShell::createMainWindow):
3486         (TestShell::~TestShell):
3487
3488 2012-07-16  Adam Barth  <abarth@webkit.org>
3489
3490         [Chromium] Introduce TestInterfaces to hold all the JavaScript interfaces needed for LayoutTests
3491         https://bugs.webkit.org/show_bug.cgi?id=91312
3492
3493         Reviewed by Ryosuke Niwa.
3494
3495         Looking forward to moving more objects into TestRunner.a, we're going
3496         to need an object to own all the interfaces and to put them through
3497         their lifecycle.
3498
3499         * DumpRenderTree/DumpRenderTree.gypi:
3500         * DumpRenderTree/chromium/TestShell.cpp:
3501         (TestShell::initialize):
3502         (TestShell::resetTestController):
3503         (TestShell::bindJSObjectsToWindow):
3504         * DumpRenderTree/chromium/TestShell.h:
3505         (TestShell):
3506         * DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp: Added.
3507         * DumpRenderTree/chromium/TestRunner/TestInterfaces.h: Added.
3508
3509 2012-07-16  Ryuan Choi  <ryuan.choi@samsung.com>
3510
3511         [EFL][WK2] Add APIs to support theme.
3512         https://bugs.webkit.org/show_bug.cgi?id=90107
3513
3514         Reviewed by Hajime Morita.
3515
3516         Override default theme path for MiniBrowser and WebKitTestRunner.
3517
3518         * MiniBrowser/efl/CMakeLists.txt:
3519         * MiniBrowser/efl/main.c:
3520         (browserCreate):
3521         * WebKitTestRunner/PlatformEfl.cmake:
3522         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3523         (WTR::PlatformWebView::PlatformWebView):
3524
3525 2012-07-16  Ryuan Choi  <ryuan.choi@samsung.com>
3526
3527         [EFL][DRT] Implement dumpFrameScrollPosition
3528         https://bugs.webkit.org/show_bug.cgi?id=87638
3529
3530         Reviewed by Hajime Morita.
3531
3532         * DumpRenderTree/efl/DumpRenderTree.cpp:
3533         (dumpFrameScrollPosition): Implemented.
3534         (shouldDumpFrameScrollPosition): Fixed wrong condition like other ports.
3535
3536 2012-07-16  Don Olmstead  <don.olmstead@am.sony.com>
3537
3538         NRWRT Should provide a VS project to work on
3539         https://bugs.webkit.org/show_bug.cgi?id=91436
3540
3541         Reviewed by Dirk Pranke.
3542
3543         Adding VS2010 project for modifying webkitpy. Uses pytools
3544         <http://pytools.codeplex.com> which integrates python into 
3545         Visual Studio.
3546
3547         * Scripts/webkitpy/webkitpy.pyproj: Added.
3548         * Scripts/webkitpy/webkitpy.sln: Added.
3549
3550 2012-07-16  Adam Barth  <abarth@webkit.org>
3551
3552         [Chromium] Move GamepadController into TestRunner.a
3553         https://bugs.webkit.org/show_bug.cgi?id=91311
3554
3555         Reviewed by Tony Chang.
3556
3557         GamepadController looks like a simple class to move into TestRunner.a
3558         because it has almost zero dependence on TestShell.
3559
3560         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3561         * DumpRenderTree/DumpRenderTree.gypi:
3562         * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp: Renamed from Tools/DumpRenderTree/chromium/CppBoundClass.cpp.
3563         * DumpRenderTree/chromium/TestRunner/CppBoundClass.h: Renamed from Tools/DumpRenderTree/chromium/CppBoundClass.h.
3564         * DumpRenderTree/chromium/TestRunner/CppVariant.cpp: Renamed from Tools/DumpRenderTree/chromium/CppVariant.cpp.
3565         * DumpRenderTree/chromium/TestRunner/CppVariant.h: Renamed from Tools/DumpRenderTree/chromium/CppVariant.h.
3566             - GamepadController depends on these bindings helpers.
3567         * DumpRenderTree/chromium/TestRunner/GamepadController.cpp: Renamed from Tools/DumpRenderTree/chromium/GamepadController.cpp.
3568         * DumpRenderTree/chromium/TestRunner/GamepadController.h: Renamed from Tools/DumpRenderTree/chromium/GamepadController.h.
3569             - Just moved these files and removed the unused TestShell
3570               references.
3571         * DumpRenderTree/chromium/TestRunner/Stub.cpp: Removed.
3572             - No longer needed.
3573         * DumpRenderTree/chromium/TestShell.cpp:
3574             - Update call to constructor to avoid passing in this.
3575
3576 2012-07-16  Xianzhu Wang  <wangxianzhu@chromium.org>
3577
3578         [Chromium-android] Don't use test_shell mode of DRT
3579         https://bugs.webkit.org/show_bug.cgi?id=88542
3580
3581         Reviewed by Dirk Pranke.
3582
3583         Test shell mode is about to be removed.
3584         Switch to use DRT mode for chromium-android.
3585
3586         Summary of changes:
3587         1. ChromiumAndroidDriver now inherits from WebKitDriver instead of ChromiumDriver (to be deprecated).
3588         2. Conforms to the DRT mode protocol for input/output of DumpRenderTree.
3589         3. Added support for Android 'adb shell' input/output (base64, newline mode, etc.)
3590
3591         * DumpRenderTree/chromium/TestEventPrinter.cpp:
3592         (DRTPrinter::handleImage): Outputs base64 on Android.
3593         * DumpRenderTree/chromium/TestShellAndroid.cpp:
3594         (platformInit): Changed err_file to err_fifo, required by python ServerProcess.
3595         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3596         (ChromiumAndroidPort.__init__):
3597         (ChromiumAndroidPort.create_driver): Override to create driver without DriverProxy to ensure 1 Driver per run.
3598         (ChromiumAndroidDriver):
3599         (ChromiumAndroidDriver.__init__):
3600         (ChromiumAndroidDriver.cmd_line):
3601         (ChromiumAndroidDriver._deadlock_detector):
3602         (ChromiumAndroidDriver._drt_cmd_line):
3603         (ChromiumAndroidDriver.start):
3604         (ChromiumAndroidDriver._start):
3605         (ChromiumAndroidDriver._start_once):
3606         (ChromiumAndroidDriver.run_test):
3607         (ChromiumAndroidDriver.stop):
3608         (ChromiumAndroidDriver._command_from_driver_input):
3609         (ChromiumAndroidDriver._read_prompt):
3610         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3611         (ChromiumAndroidPortTest.test_driver_cmd_line):
3612         (ChromiumAndroidDriverTest.test_cmd_line):
3613         (ChromiumAndroidDriverTest):
3614         (ChromiumAndroidDriverTest.test_drt_cmd_line):
3615         (ChromiumAndroidDriverTest.test_read_prompt):
3616         (ChromiumAndroidDriverTest.test_command_from_driver_input):
3617         (ChromiumAndroidDriverTest.test_write_command_and_read_line):
3618         * Scripts/webkitpy/layout_tests/port/server_process.py:
3619         (ServerProcess.__init__): Added universal_newlines to handle Android 'adb shell' line ends.
3620         (ServerProcess._start):
3621         (ServerProcess._wait_for_data_and_update_buffers_using_select): Handles unexpected EOF which indicates crash on Android.
3622         (ServerProcess.stop): Added kill_directly parameter to kill the process without waiting it (which always timeouts for Android).
3623         (ServerProcess.replace_outputs): Added to combine different input/output pipes into one ServerProcess.
3624         * Scripts/webkitpy/layout_tests/port/webkit.py:
3625         (WebKitDriver._command_from_driver_input):
3626         (WebKitDriver.run_test): Changed timeout origin so that slow start() on Android won't cause timeout of layout test case.
3627         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3628         (MockServerProcess.read_stdout):
3629         (MockServerProcess.start):
3630         (MockServerProcess):
3631         (MockServerProcess.stop):
3632         (MockServerProcess.kill):
3633         (WebKitDriverTest.test_read_block):
3634         (WebKitDriverTest.test_read_binary_block):
3635         (WebKitDriverTest.test_read_base64_block):
3636
3637 2012-07-16  Dirk Pranke  <dpranke@chromium.org>
3638
3639         nrwt: move a bunch of printing code from manager.py to printing.py
3640         https://bugs.webkit.org/show_bug.cgi?id=91439
3641
3642         Reviewed by Ojan Vafai.
3643
3644         All of the logic that handles what gets logged should eventually
3645         live in printing.py; this patch moves a large chunk of code that
3646         prints all of the stuff after the run completes.
3647
3648         There are no functional changes, this is just moving code
3649         around. Covered by existing tests (updated as necessary).
3650
3651         This code is all pretty messy and most of it should be deleted
3652         (or extracted after the fact from results.json), but I'm saving
3653         that for further patches. My goal is just to manager.py to a
3654         more manageable state.
3655
3656         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3657         (Manager.prepare_lists_and_print_output):
3658         (Manager.run):
3659         (Manager._mark_interrupted_tests_as_skipped):
3660         (Manager._update_summary_with_result):
3661         (Manager._num_digits):
3662         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3663         (ManagerTest.test_interrupt_if_at_failure_limits):
3664         (ResultSummaryTest.summarized_results):
3665         * Scripts/webkitpy/layout_tests/models/result_summary.py:
3666         (ResultSummary.__init__):
3667         (ResultSummary.add):
3668         Here we had to add a list of the slow tests to the result
3669         summary so that we didn't need to call back into the manager and
3670         the test expectations object to figure out if a test is SLOW.
3671         * Scripts/webkitpy/layout_tests/views/printing.py:
3672         (Printer.print_results):
3673         (Printer):
3674         (Printer._print_timing_statistics):
3675         (Printer._print_aggregate_test_statistics):
3676         (Printer._print_individual_test_times):
3677         (Printer._print_test_list_timing):
3678         (Printer._print_directory_timings):
3679         (Printer._print_statistics_for_test_timings):
3680         (Printer._print_result_summary):
3681         (Printer._print_result_summary_entry):
3682         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3683         (Testprinter.test_print_unexpected_results.get_unexpected_results):
3684         (Testprinter):
3685
3686 2012-07-16  Adam Barth  <abarth@webkit.org>
3687
3688         [Chromium] Create a stub TestRunner.a target
3689         https://bugs.webkit.org/show_bug.cgi?id=91309
3690
3691         Reviewed by Ryosuke Niwa.
3692
3693         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3694         * DumpRenderTree/DumpRenderTree.gypi:
3695         * DumpRenderTree/chromium/TestRunner/Stub.cpp: Added.
3696
3697 2012-07-16  Dirk Pranke  <dpranke@chromium.org>
3698
3699         test-webkitpy: clean up logging to make it ninja-esque
3700         https://bugs.webkit.org/show_bug.cgi?id=91297
3701
3702         Reviewed by Adam Barth.
3703
3704         This patch changes the output of test-webkitpy to be closer to
3705         what ninja produces. Namely:
3706
3707         If you are running with stderr writing to a tty (and not -v), we
3708         will no longer print '...' as tests complete. Instead, we use a
3709         metered stream and print entries of the form:
3710            '[X/Y] test_name passed/failed/erred'
3711         where X is the current test # and Y is the total number of tests.
3712
3713         If you are running with stderr piped to a file or other non-tty
3714         object (or with -v), you get the same output, one per line for
3715         every test.
3716
3717         In addition, if tests fail or err out, you get the stack trace
3718         immediately; you don't have to wait until the end of the run.
3719
3720         Lastly, this change cleans up the unit tests for test-webkitpy
3721         itself to not confuse the logger and to work cleanly w/ multiple
3722         processes. It looks like between this and all the clean up in
3723         MessagePool that happened as it landed, we can now run
3724         multiprocessing tests in parallel.
3725
3726         * Scripts/webkitpy/test/finder.py:
3727         (Finder._default_names):
3728         * Scripts/webkitpy/test/finder_unittest.py:
3729         (FinderTest.setUp):
3730         (FinderTest.tearDown):
3731         * Scripts/webkitpy/test/printer.py:
3732         (Printer.__init__):
3733         (Printer.configure):
3734         (Printer.print_started_test):
3735         (Printer.print_finished_test):
3736         (Printer._test_line):
3737         (Printer.print_result):
3738         * Scripts/webkitpy/test/runner.py:
3739         (Runner.run):
3740         * Scripts/webkitpy/test/runner_unittest.py:
3741         (RunnerTest.setUp):
3742         (RunnerTest):
3743         (RunnerTest.tearDown):
3744         (RunnerTest.assert_run):
3745         (RunnerTest.test_regular):
3746         (RunnerTest.test_verbose):
3747         (RunnerTest.test_timing):
3748
3749 2012-07-16  Dirk Pranke  <dpranke@chromium.org>
3750
3751         test-webkitpy: handle failures properly when running in parallel
3752         https://bugs.webkit.org/show_bug.cgi?id=91416
3753
3754         Reviewed by Adam Barth.
3755
3756         It turns out that unittest.TestResults contain a handle to the
3757         test method itself, which isn't picklable; it's sufficient to just
3758         store the test name instead of the actual method. By doing so
3759         we can move the test_name() method from the printer to the
3760         runner where it belongs (so the printer is less dependent on the
3761         unittest framework's data structures).
3762
3763         This change should really have a test but I don't know how to
3764         write one that properly captures the behavior and won't cause
3765         test-webkitpy itself to fail. I've verified the fix by hand, at
3766         least, in the meantime.
3767
3768         * Scripts/webkitpy/test/printer.py:
3769         (Printer.__init__):
3770         (Printer.print_result):
3771         * Scripts/webkitpy/test/runner.py:
3772         (_test_name):
3773         (Runner.all_test_names):
3774         (_Worker.handle):
3775
3776 2012-07-16  Dirk Pranke  <dpranke@chromium.org>
3777
3778         test-webkitpy: handle failures properly when running in parallel
3779         https://bugs.webkit.org/show_bug.cgi?id=91416
3780
3781         Reviewed by Tony Chang.
3782
3783         It turns out that unittest.TestResults contain a handle to the
3784         test method itself, which isn't picklable; it's sufficient to just
3785         store the test name instead of the actual method. By doing so
3786         we can move the test_name() method from the printer to the
3787         runner where it belongs (so the printer is less dependent on the
3788         unittest framework's data structures).
3789
3790         This change should really have a test but I don't know how to
3791         write one that properly captures the behavior and won't cause
3792         test-webkitpy itself to fail. I've verified the fix by hand, at
3793         least, in the meantime.
3794
3795         * Scripts/webkitpy/test/printer.py:
3796         (Printer.__init__):
3797         (Printer.print_result):
3798         * Scripts/webkitpy/test/runner.py:
3799         (_test_name):
3800         (Runner.all_test_names):
3801         (_Worker.handle):
3802
3803 2012-07-16  Dirk Pranke  <dpranke@chromium.org>
3804
3805         test-webkitpy: run tests in parallel
3806         https://bugs.webkit.org/show_bug.cgi?id=91294
3807
3808         Reviewed by Ojan Vafai.
3809
3810         This change adds support for running tests in parallel. This is
3811         not yet on by default, since the logging isn't very pretty w/
3812         parallel tests.
3813
3814         Also, there are some (multiprocessing-related) tests that can't be
3815         run in parallel and so we skip them in that situation; I need to
3816         come up with a mechanism for dealing with this, since you
3817         apparently can't use multiprocessing as both a parent and a
3818         child process.
3819
3820         * Scripts/webkitpy/test/finder.py:
3821         (Finder.find_names):
3822         (Finder._default_names):
3823         * Scripts/webkitpy/test/main.py:
3824         (Tester._parse_args):
3825         (Tester.run):
3826         * Scripts/webkitpy/test/main_unittest.py:
3827         (TesterTest.test_no_tests_found):
3828         * Scripts/webkitpy/test/runner.py:
3829         (Runner.run):
3830         * Scripts/webkitpy/test/runner_unittest.py:
3831         (RunnerTest.test_regular):
3832         (RunnerTest.test_verbose):
3833         (RunnerTest.test_timing):
3834
3835 2012-07-16  Dirk Pranke  <dpranke@chromium.org>
3836
3837         test-webkitpy: use message pools
3838         https://bugs.webkit.org/show_bug.cgi?id=91292
3839
3840         Reviewed by Ojan Vafai.
3841
3842         Restructure the test-running code to be message-driven and
3843         use a MessagePool; note that this does not yet actually run the
3844         tests in parallel.
3845
3846         Also clean up the unit tests so that the fake loader is passed
3847         to the _Worker properly, and reduce a lot of the cut&pasted code
3848         in the tests.
3849
3850         No functional changes; covered by existing tests.
3851
3852         * Scripts/webkitpy/test/printer.py:
3853         (Printer.print_started_test):
3854         (Printer.print_finished_test):
3855         * Scripts/webkitpy/test/runner.py:
3856         (Runner.__init__):
3857         (Runner.run):
3858         (Runner.handle):
3859         (_Worker):
3860         (_Worker.__init__):
3861         (_Worker.handle):
3862         * Scripts/webkitpy/test/runner_unittest.py:
3863         (RunnerTest.assert_run):
3864         (RunnerTest.test_regular):
3865         (RunnerTest.test_verbose):
3866         (RunnerTest.test_timing):
3867
3868 2012-07-16  Simon Hausmann  <simon.hausmann@nokia.com>
3869
3870         [Qt] Fix Qt5 module dependencies
3871         https://bugs.webkit.org/show_bug.cgi?id=91388
3872
3873         Reviewed by Laszlo Gombos.
3874
3875         Removed ancient qtscript and qtxmlpatterns module dependencies.
3876
3877         * qmake/qt_webkit.pri:
3878
3879 2012-07-16  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3880
3881         run-webkit-test returns 254 at exit even when it succeeds
3882         https://bugs.webkit.org/show_bug.cgi?id=91370
3883
3884         Reviewed by Simon Hausmann.
3885
3886         sys.exit() is implemented by raising SystemExit which inherits from
3887         BaseException. Since we are catching BaseException, run_webkit_tests.py
3888         was always returning an error code.
3889
3890         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3891
3892 2012-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
3893
3894         Unreviewed. Fix make distcheck.
3895
3896         * GNUmakefile.am: Add missing file to compilation.
3897
3898 2012-07-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3899
3900         Unreviewed. Add EFLWebKit2PublicAPI, EFLWebKit2PlatformSpecific to watch list.
3901
3902         * Scripts/webkitpy/common/config/watchlist:
3903
3904 2012-07-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3905
3906         Unreviewed. Add gyuyoung.kim@samsung.com to watch list.
3907
3908         * Scripts/webkitpy/common/config/watchlist:
3909
3910 2012-07-15  Joseph Pecoraro  <pecoraro@apple.com>
3911
3912         Windowless WebView not firing JavaScript load event if there is a media element
3913         https://bugs.webkit.org/show_bug.cgi?id=91331
3914
3915         Reviewed by Eric Carlson.
3916
3917         Test a windowless WebView loading a page with a media element. The load
3918         event should happen on the next spin of the run loop, but we spin check
3919         the page, with a timeout of 250ms.
3920
3921         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3922         * TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.html: Added.
3923         * TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.mm: Added.
3924         (-[WindowlessWebViewWithMediaFrameLoadDelegate webView:didFinishLoadForFrame:]):
3925         (TestWebKitAPI::spinLoop): Spin check with timeout. Runs a block each spin to early bail.
3926         (TestWebKitAPI::TEST):
3927
3928 2012-07-14  Benjamin Poulain  <bpoulain@apple.com>
3929
3930         [Mac] Do not try to update the cache model for every WebPreferences change
3931         https://bugs.webkit.org/show_bug.cgi?id=91302
3932
3933         Reviewed by Joseph Pecoraro.
3934
3935         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3936         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: Added.
3937         (TestWebKitAPI):
3938         (TestWebKitAPI::TEST):
3939
3940 2012-07-14  Sheriff Bot  <webkit.review.bot@gmail.com>
3941
3942         Unreviewed, rolling out r122665.
3943         http://trac.webkit.org/changeset/122665
3944         https://bugs.webkit.org/show_bug.cgi?id=91321
3945
3946         Broke Mac builds (Requested by rniwa on #webkit).
3947
3948         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3949         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: Removed.
3950
3951 2012-07-13  Benjamin Poulain  <bpoulain@apple.com>
3952
3953         [Mac] Do not try to update the cache model for every WebPreferences change
3954         https://bugs.webkit.org/show_bug.cgi?id=91302
3955
3956         Reviewed by Joseph Pecoraro.
3957
3958         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3959         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: Added.
3960         (TestWebKitAPI):
3961         (TestWebKitAPI::TEST):
3962
3963 2012-07-13  Dirk Pranke  <dpranke@chromium.org>
3964
3965         run-webkit-test outputs the wrong number of tests executed when some are skipped.
3966         https://bugs.webkit.org/show_bug.cgi?id=89894
3967
3968         Reviewed by Ojan Vafai.
3969
3970         Fix the logging of the actual number of tests run so that tests
3971         that are skipped aren't included.
3972
3973         Also revamp the 'expected' output so we distinguish the number
3974         of tests found from the number of tests run (to account for
3975         --repeat-each and --iterations).
3976
3977         Covered by existing tests.
3978
3979         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3980         (Manager.prepare_lists_and_print_output):
3981         (Manager._log_num_workers):
3982         (Manager.run):
3983         (Manager._print_result_summary):
3984         * Scripts/webkitpy/layout_tests/models/result_summary.py:
3985         (ResultSummary.__init__):
3986         (ResultSummary.add):
3987         * Scripts/webkitpy/layout_tests/views/printing.py:
3988         (Printer.print_one_line_summary):
3989         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3990         (Testprinter.test_print_one_line_summary):
3991
3992 2012-07-13  Dirk Pranke  <dpranke@chromium.org>
3993
3994         nrwt: actually print the exception name and message for otherwise unhandled exceptions
3995         https://bugs.webkit.org/show_bug.cgi?id=91305
3996
3997         Reviewed by Adam Barth.
3998
3999         Two more places where I was printing the stack trace but not the
4000         exception itself :(. These two spots can't easily be
4001         unit-tested, but I tested them by hand.
4002
4003         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4004         (run):
4005         (main):
4006
4007 2012-07-13  Josh Hawn  <jhawn@apple.com>
4008
4009         Fix for WebContext::getWebCoreStatistics() causes crash if no m_process
4010         https://bugs.webkit.org/show_bug.cgi?id=91116
4011
4012         Reviewed by Simon Fraser.
4013
4014         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4015             Added new test file.
4016         * TestWebKitAPI/Tests/WebKit2/WebCoreStatisticsWithNoWebProcess.cpp: Added.
4017         (TestWebKitAPI::wkContextGetStatisticsCallback):
4018             Tests that callback function receives an error.
4019         (TestWebKitAPI::TEST):
4020             Creates a dummy web context object (no web process).
4021             Calls WKContextGetStatistics with the web context and test callback.
4022             The test callback should get an expected error.
4023
4024 2012-07-13  Dirk Pranke  <dpranke@chromium.org>
4025
4026         test-webkitpy: move printing-related code out of the runner
4027         https://bugs.webkit.org/show_bug.cgi?id=91289
4028
4029         Reviewed by Ryosuke Niwa.
4030
4031         More refactoring ... this moves all printing-related stuff out
4032         of runner.py and into printer.py.
4033
4034         No functional changes; covered by existing tests.
4035
4036         * Scripts/webkitpy/test/main.py:
4037         (Tester._run_tests):
4038         * Scripts/webkitpy/test/printer.py:
4039         (Printer.__init__):
4040         (Printer):
4041         (Printer.test_name):
4042         (Printer.print_started_test):
4043         (Printer.print_finished_test):
4044         (Printer.print_result):
4045         * Scripts/webkitpy/test/runner.py:
4046         (Runner.__init__):
4047         (Runner.all_test_names):
4048         (Runner.run):
4049         * Scripts/webkitpy/test/runner_unittest.py:
4050         (RunnerTest.test_regular):
4051         (RunnerTest.test_verbose):
4052         (RunnerTest.test_timing):
4053
4054 2012-07-13  Dirk Pranke  <dpranke@chromium.org>
4055
4056         webkitpy: split printing/logging code for test-webkitpy out into a new class
4057         https://bugs.webkit.org/show_bug.cgi?id=91282
4058
4059         Reviewed by Ojan Vafai.
4060
4061         This patch is the first step at splitting all of the
4062         printing/logging code out separately from the actual
4063         test-running code.
4064
4065         This is just moving stuff around; no new functionality and no
4066         new tests needed.
4067
4068         * Scripts/webkitpy/test/finder_unittest.py:
4069         (FinderTest.setUp):
4070         * Scripts/webkitpy/test/main.py:
4071         (Tester.__init__):
4072         (Tester._parse_args):
4073         (Tester.run):
4074         (Tester._run_tests):
4075         (Tester._log_exception):
4076         * Scripts/webkitpy/test/main_unittest.py:
4077         (TesterTest.test_no_tests_found):
4078         * Scripts/webkitpy/test/printer.py: Added.
4079         (Printer):
4080         (Printer.__init__):
4081         (Printer.configure):
4082         (Printer.configure.filter):
4083         (_CaptureAndPassThroughStream):
4084         (_CaptureAndPassThroughStream.__init__):
4085         (_CaptureAndPassThroughStream.write):
4086         (_CaptureAndPassThroughStream._message_is_from_pdb):
4087         (_CaptureAndPassThroughStream.flush):
4088         (_CaptureAndPassThroughStream.getvalue):
4089
4090 2012-07-13  James Simonsen  <simonjam@chromium.org>
4091
4092         [Navigation Timing] Imported W3C tests contain duplicates and are DOS formatted
4093         https://bugs.webkit.org/show_bug.cgi?id=91184
4094
4095         Reviewed by Adam Barth.
4096
4097         The upstream 'html5' tests are just duplicates of the 'html' tests.
4098
4099         * Scripts/import-w3c-performance-wg-tests:
4100
4101 2012-07-13  Dirk Pranke  <dpranke@chromium.org>
4102
4103         webkitpy: hide yield_to_caller from callers in MessagePool :)
4104         https://bugs.webkit.org/show_bug.cgi?id=91269
4105
4106         Reviewed by Adam Barth.
4107
4108         yield_to_caller() was an optimization/hack to allow us to run
4109         both manager and worker in a single process/loop without
4110         starving the manager while the worker is running tests. The
4111         worker was required to call yield_to_caller() periodically. It
4112         turns out that I can get equivalent responsiveness by yielding
4113         inside the MessagePool every time the worker posts a message, and this
4114         allows me to no longer need the worker to call the routine. Thus
4115         I rename yield_to_caller() to _yield_to_manager() to be a little
4116         clearer about its purpose.
4117
4118         Tested by existing tests.
4119
4120         * Scripts/webkitpy/common/message_pool.py:
4121         (_Worker.run):
4122         (_Worker.post):
4123         (_Worker._yield_to_manager):
4124         * Scripts/webkitpy/layout_tests/controllers/worker.py:
4125         (Worker.handle):
4126
4127 2012-07-13  Adam Barth  <abarth@webkit.org>
4128
4129         EWSTools should be able to build a commit-queue instance from scratch
4130         https://bugs.webkit.org/show_bug.cgi?id=91264
4131
4132         Reviewed by Eric Seidel.
4133
4134         I've been using this script to build commit-queue instances on Google
4135         Compute Engine and it seems to work.
4136
4137         * EWSTools/GoogleComputeEngine/build-commit-queue.sh: Added.
4138
4139 2012-07-13  Dirk Pranke  <dpranke@chromium.org>
4140
4141         webkitpy: make worker.start() and worker.stop() optional in the messagepool
4142         https://bugs.webkit.org/show_bug.cgi?id=91170
4143
4144         Reviewed by Ojan Vafai.
4145
4146         test-webkitpy will use messagepool workers that don't actually
4147         have any per-worker state, so they don't need start() and stop()
4148         methods. Now we will only call the methods if they exist; this
4149         means that workers only need to expose a handle() method.
4150
4151         * Scripts/webkitpy/common/message_pool.py:
4152         (_Worker.terminate):
4153         (_Worker.run):
4154
4155 2012-07-13  Dirk Pranke  <dpranke@chromium.org>
4156
4157         NRWT doesn't print exceptions
4158         https://bugs.webkit.org/show_bug.cgi?id=91129
4159
4160         Reviewed by Ojan Vafai.
4161
4162         Although we printed exceptions in most cases, if an unexpected
4163         exception (like a runtime error) was raised when creating a
4164         port, we wouldn't. This patch fixes that, and also cleans up
4165         how we were logging exceptions from the workers to be less
4166         verbose.
4167
4168         Because of the corner cases where these errors are occurring,
4169         it's difficult to write automated unit tests for them. I've
4170         tested it quite a bit by hand, though.
4171
4172         * Scripts/webkitpy/common/message_pool.py:
4173         (_MessagePool._close):
4174         (_MessagePool._handle_worker_exception):
4175         (_Worker.run):
4176         (_Worker._raise):
4177         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4178         (Manager._run_tests):
4179         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4180         (main):
4181
4182 2012-07-13  Wei James  <james.wei@intel.com>
4183
4184         enable TestWebKitAPI/webkit_unit_tests apk on x86 android platform by adding abi support
4185         https://bugs.webkit.org/show_bug.cgi?id=91194
4186
4187         Reviewed by Adam Barth.
4188
4189         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
4190
4191 2012-07-13  Simon Pena  <spena@igalia.com>
4192
4193         [GTK] Gardening: update API tests skipped list
4194         https://bugs.webkit.org/show_bug.cgi?id=91224
4195
4196         Unreviewed gardening.
4197
4198         Skip "next" and "previous" tests of FindController until bug #91083
4199         is fixed.
4200
4201         * gtk/run-api-tests:
4202         (TestRunner):
4203
4204 2012-07-13  Zeno Albisser  <zeno@webkit.org>
4205
4206         [Qt][WK2] Implement GraphicsSurface for Linux/GLX.
4207         https://bugs.webkit.org/show_bug.cgi?id=90881
4208
4209         Enable GraphicsSurface for Linux based platforms
4210         whenever the Xcomposite extension is available.
4211
4212         Reviewed by Noam Rosenthal.
4213
4214         * qmake/config.tests/libXcomposite/libXcomposite.cpp: Added.
4215         (main):
4216         * qmake/config.tests/libXcomposite/libXcomposite.pro: Added.
4217           Add a configure test to detect Xcomposite extension and
4218           activate GraphicsSurface on linux in case the extension is available.
4219         * qmake/configure.pri:
4220         * qmake/mkspecs/features/features.prf:
4221
4222 2012-07-13  David Grogan  <dgrogan@chromium.org>
4223
4224         nrwt: don't choke when printing invalid utf-8 to stderr
4225         https://bugs.webkit.org/show_bug.cgi?id=91181
4226
4227         Reviewed by Dirk Pranke.
4228
4229         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
4230         (TestResultWriter.write_stderr):
4231
4232 2012-07-13  Dirk Pranke  <dpranke@chromium.org>
4233
4234         test-webkitpy: more class renaming cleanup
4235         https://bugs.webkit.org/show_bug.cgi?id=91182
4236
4237         Reviewed by Adam Barth.
4238
4239         More removing of the unnecessary "Test" prefix.
4240
4241         * Scripts/webkitpy/test/finder.py:
4242         (_DirectoryTree):
4243         (Finder.add_tree):
4244         * Scripts/webkitpy/test/main.py:
4245         (Tester._run_tests):
4246         * Scripts/webkitpy/test/runner.py:
4247         (Runner):
4248         * Scripts/webkitpy/test/runner_unittest.py:
4249         (RunnerTest.test_regular):
4250         (RunnerTest.test_verbose):
4251         (RunnerTest.test_timing):
4252
4253 2012-07-12  Christophe Dumez  <christophe.dumez@intel.com>
4254
4255         [WK2][EFL] Facilitate debugging of the Web Process
4256         https://bugs.webkit.org/show_bug.cgi?id=90768
4257
4258         Reviewed by Kenneth Rohde Christiansen.
4259
4260         Add a new --webprocess-cmd-prefix argument to
4261         run-webkit-tests script for EFL port. If provided,
4262         the prefix will be prepended to the command used
4263         to spawn the Web process. This can be used for
4264         debugging purposes with prefixes such as:
4265         "xterm -title renderer -e gdb --args".
4266
4267         * Scripts/webkitpy/layout_tests/port/efl.py:
4268         (EflPort.__init__):
4269         (EflPort.setup_environ_for_server):
4270         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4271         (parse_args):
4272         * WebKitTestRunner/efl/TestControllerEfl.cpp:
4273         (WTR::TestController::platformRunUntil): Implement support for
4274         m_noTimeout timeout value.
4275
4276 2012-07-12  Adam Barth  <abarth@webkit.org>
4277
4278         Fix crash in the commit-queue.  We need to initialize self.port during __init__.
4279
4280         * Scripts/webkitpy/tool/commands/queues.py:
4281         (CommitQueue.__init__):
4282         (CommitQueue.begin_work_queue):
4283
4284 2012-07-12  Dirk Pranke  <dpranke@chromium.org>
4285
4286         test-webkitpy: rename test_finder to finder
4287         https://bugs.webkit.org/show_bug.cgi?id=91175
4288
4289         Reviewed by Adam Barth.
4290
4291         Rename test_finder -> finder, TestFinder -> Finder to remove
4292         some of the stutter in the names.
4293
4294         * Scripts/webkitpy/test/finder.py: Renamed from Tools/Scripts/webkitpy/test/test_finder.py.
4295         * Scripts/webkitpy/test/finder_unittest.py: Renamed from Tools/Scripts/webkitpy/test/test_finder_unittest.py.
4296         * Scripts/webkitpy/test/main.py:
4297         (Tester.__init__):
4298
4299 2012-07-12  Adam Barth  <abarth@webkit.org>
4300
4301         CommitQueue is confused about what port it is using
4302         https://bugs.webkit.org/show_bug.cgi?id=91040
4303
4304         Reviewed by Dirk Pranke.
4305
4306         On EC2, we explicitly pass --port to the commit-queue, but that
4307         requires editing the start-queue.sh script locally on each bot. In
4308         moving to Google Compute Engine, we're try to avoid any local edits to
4309         the EWSTools.