52726ccd402c6c8228eb4236781dc7c3678239e8
[WebKit-https.git] / Tools / ChangeLog
1 2012-03-22  Philippe Normand  <pnormand@igalia.com>
2
3         Unreviewed, test-webkitpy fix after r111661.
4
5         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
6         (MainTest.test_crash_log):
7         (MainTest.test_web_process_crash_log):
8
9 2012-03-22  Philippe Normand  <pnormand@igalia.com>
10
11         Unreviewed, test-webkitpy fix after r111642.
12
13         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
14         (ChromiumDriverTest.setUp):
15         (ChromiumDriverTest.test_two_drivers):
16
17 2012-03-22  Csaba Osztrogonác  <ossy@webkit.org>
18
19         webkitpy: clean up actually getting crash logs from DRT/WTR crashes
20         https://bugs.webkit.org/show_bug.cgi?id=81603
21
22         Unreviewed rolling out r111609 and part of r111615,
23         because it broke NRWT on Qt-WK2 platform.
24
25         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
26         (SingleTestRunner._handle_error):
27         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
28         (write_test_result):
29         (TestResultWriter.write_crash_report):
30         * Scripts/webkitpy/layout_tests/port/base.py:
31         (Port.is_crash_reporter):
32         (Port._driver_class):
33         * Scripts/webkitpy/layout_tests/port/chromium.py:
34         (ChromiumDriver.run_test):
35         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
36         (ChromiumDriverTest.test_crashed_process_name):
37         * Scripts/webkitpy/layout_tests/port/driver.py:
38         (DriverOutput.__init__):
39         * Scripts/webkitpy/layout_tests/port/mac.py:
40         (MacPort):
41         (MacPort.is_crash_reporter):
42         (MacPort.release_http_lock):
43         * Scripts/webkitpy/layout_tests/port/test.py:
44         (TestDriver.run_test):
45         * Scripts/webkitpy/layout_tests/port/webkit.py:
46         (WebKitDriver.__init__):
47         (WebKitDriver._start):
48         (WebKitDriver.has_crashed):
49         (WebKitDriver._check_for_driver_crash):
50         (WebKitDriver.run_test):
51
52 2012-03-22  Csaba Osztrogonác  <ossy@webkit.org>
53
54         [Qt] Add full platforms to Qt buildslaves
55         https://bugs.webkit.org/show_bug.cgi?id=81877
56
57         Reviewed by Ryosuke Niwa.
58
59         * BuildSlaveSupport/build.webkit.org-config/config.json:
60
61 2012-03-21  Johnny Ding  <jnd@chromium.org>
62
63         Customize layout test timeout value for different ports.
64         https://bugs.webkit.org/show_bug.cgi?id=79859
65
66         Reviewed by Ojan Vafai.
67
68         * Scripts/webkitpy/layout_tests/controllers/manager.py:
69         (Manager):
70         * Scripts/webkitpy/layout_tests/port/base.py:
71         (Port.default_test_timeout_ms):
72         * Scripts/webkitpy/layout_tests/port/chromium.py:
73         (ChromiumDriver.stop):
74         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
75         (ChromiumAndroidPort.default_test_timeout_ms):
76         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
77         (_set_up_derived_options):
78
79 2012-03-21  Mark Rowe  <mrowe@apple.com>
80
81         Fix the build.
82
83         Ensure that our test tools don't try and use RTTI unnecessarily.
84
85         * DumpRenderTree/mac/Configurations/Base.xcconfig:
86         * TestWebKitAPI/Configurations/Base.xcconfig:
87         * WebKitTestRunner/Configurations/Base.xcconfig:
88
89 2012-03-21  Adam Barth  <abarth@webkit.org>
90
91         WebKit should have some scripts to smooth interactions with GitHub
92         https://bugs.webkit.org/show_bug.cgi?id=81842
93
94         Reviewed by Eric Seidel.
95
96         These scripts support the workflow in
97         https://trac.webkit.org/wiki/UsingGitHub by automating the
98         configuration and syncing operations needed for a GitHub fork of WebKit
99         to track the main WebKit repository.
100
101         * Scripts/configure-github-as-upstream: Added.
102         * Scripts/sync-master-with-upstream: Added.
103
104 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
105
106         WTR - log the pid of a crashing WebProcess
107         https://bugs.webkit.org/show_bug.cgi?id=81575
108
109         Reviewed by Alexey Proskuryakov.
110
111         This allows run-webkit-tests to find the right crash log for a
112         given crashed WebProcess in WebKit2.
113
114         * WebKitTestRunner/TestController.cpp:
115         (WTR::exceededDatabaseQuota):
116         (WTR::TestController::createOtherPage):
117         (WTR::TestController::initialize):
118         (WTR::TestController::resetStateToConsistentValues):
119         (WTR::TestController::runTest):
120         (WTR::TestController::processDidCrash):
121
122 2012-03-21  Enrica Casucci  <enrica@apple.com>
123
124         WebKitURLWithTitles pasteboard format should support URLs containing Emoji characters.
125         https://bugs.webkit.org/show_bug.cgi?id=81835
126         <rdar://problem/11082749>
127
128         Reviewed by Brady Eidson.
129
130         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html:
131         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
132         (TestWebKitAPI::contextMenuCopyLink):
133
134 2012-03-21  Alexandru Chiculita  <achicu@adobe.com>
135
136         [CSS Shaders] Make CSS Shaders compile on Chromium
137         https://bugs.webkit.org/show_bug.cgi?id=81435
138
139         Reviewed by Stephen White.
140         
141         I've added WebKitCSSCustomFilterEnabled support for the layoutTestController.overridePreference function.
142
143         * DumpRenderTree/chromium/LayoutTestController.cpp:
144         (LayoutTestController::overridePreference):
145         * DumpRenderTree/chromium/WebPreferences.cpp:
146         (WebPreferences::reset):
147         (WebPreferences::applyTo):
148         * DumpRenderTree/chromium/WebPreferences.h:
149         (WebPreferences):
150
151 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
152
153         fix regression on gtk port introduced by r111609
154         https://bugs.webkit.org/show_bug.cgi?id=81839
155
156         Reviewed by Philippe Normand.
157
158         r111609 should've initialized a couple of missing fields in
159         WebKitDriver, and also should've checked for method overrides
160         in the other ports :(.
161
162         * Scripts/webkitpy/layout_tests/port/gtk.py:
163         (GtkDriver._start):
164         * Scripts/webkitpy/layout_tests/port/webkit.py:
165         (WebKitDriver.__init__):
166         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
167         (MainTest.test_crash_log):
168         (MainTest.test_web_process_crash_log):
169
170 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
171
172         webkitpy: clean up actually getting crash logs from DRT/WTR crashes
173         https://bugs.webkit.org/show_bug.cgi?id=81603
174
175         Reviewed by Adam Barth.
176
177         Add a new _get_crash_log() overridable method on the Port
178         object to customize how we fetch crash logs per port.
179         Mac will now slow-spin with a timeout waiting for the crash log, rather
180         than waiting for the ReportCrash process to exit (it appears
181         that the mac will manage multiple crashes with a single
182         ReportCrash process, the process waits around longer than
183         necessary, presumably to avoid thrashing if processes are
184         repeatedly crashing).
185
186         Also, add the DriverOutput should contain the crash log and other info,
187         which is created in a port-specific manner but can then be
188         treated generically. Previously single_test_runner would get
189         told that something crashed and attempt to do something to get
190         the crash log, but it didn't have the information it needed to
191         od the right thing; better to make the driver hand back the
192         right info.
193
194         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
195         (SingleTestRunner._handle_error):
196         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
197         (write_test_result):
198         (TestResultWriter.write_crash_log):
199         * Scripts/webkitpy/layout_tests/port/base.py:
200         (Port.diff_text):
201         (Port._get_crash_log):
202         * Scripts/webkitpy/layout_tests/port/chromium.py:
203         (ChromiumDriver.run_test):
204         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
205         (ChromiumDriverTest.test_crash_log):
206         * Scripts/webkitpy/layout_tests/port/driver.py:
207         (DriverOutput.__init__):
208         * Scripts/webkitpy/layout_tests/port/mac.py:
209         (MacPort.is_lion):
210         (MacPort._get_crash_log):
211         * Scripts/webkitpy/layout_tests/port/test.py:
212         (TestDriver.run_test):
213         * Scripts/webkitpy/layout_tests/port/webkit.py:
214         (WebKitDriver.__init__):
215         (WebKitDriver._start):
216         (WebKitDriver.has_crashed):
217         (WebKitDriver._check_for_driver_crash):
218         (WebKitDriver.run_test):
219
220 2012-03-21  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
221
222         [EFL] Use jhbuild downloaded fonts instead of hardcoded system font paths
223         https://bugs.webkit.org/show_bug.cgi?id=81507
224
225         Now that we're only loading from one directory, no need to
226         iterate over a list of directories anymore.
227
228         Reviewed by Martin Robinson.
229
230         * DumpRenderTree/efl/CMakeLists.txt:
231         * DumpRenderTree/efl/FontManagement.cpp:
232         (addFontDirectory):
233         (addFontsToEnvironment):
234
235 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
236
237         webkitpy: get ServerProcess out of the reportcrash business
238         https://bugs.webkit.org/show_bug.cgi?id=81600
239
240         Unreviewed, build fix.
241
242         Re-land r111307 and r111293 with another fix for a crash in NRWT;
243         we need to check if the driver has crashed before attempting to
244         read from it.
245
246
247         * Scripts/webkitpy/layout_tests/port/server_process.py:
248         (ServerProcess._reset):
249         (ServerProcess._handle_possible_interrupt):
250         (ServerProcess.write):
251         (ServerProcess.read_stdout):
252         (ServerProcess.has_crashed):
253         (ServerProcess._read):
254         (ServerProcess.stop):
255         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
256         (TrivialMockPort.check_for_leaks):
257         (TestServerProcess.test_broken_pipe):
258         * Scripts/webkitpy/layout_tests/port/webkit.py:
259         (WebKitPort._read_image_diff):
260         (WebKitDriver.has_crashed):
261         (WebKitDriver._check_for_driver_crash):
262         (WebKitDriver.run_test):
263         (WebKitDriver._read_block):
264         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
265         (MockServerProcess.__init__):
266         (MockServerProcess):
267         (MockServerProcess.has_crashed):
268
269 2012-03-21  Zeno Albisser  <zeno@webkit.org>
270
271         [Qt][Mac] ranlib segfaults when creating symbol tables for libWebCore.a.
272         https://bugs.webkit.org/show_bug.cgi?id=81750
273
274         Building WebCore on mac currently creates an archive that is bigger than
275         4GB. But ranlib fails to create a symbol table for such a big archive,
276         even on 64bit machines.
277         Therefore we start using SVGAllInOne.cpp when building debug
278         on mac. This reduces the size of the archive by about 300MB.
279
280         Reviewed by Tor Arne Vestbø.
281
282         * qmake/mkspecs/features/mac/default_pre.prf:
283
284 2012-03-21  Szilard Ledan  <szledan@inf.u-szeged.hu>
285
286         Updated the address list of committers.py.
287
288         Reviewed by Csaba Osztrogonác.
289
290         * Scripts/webkitpy/common/config/committers.py:
291
292 2012-03-21  W. James MacLean  <wjmaclean@chromium.org>
293
294         Updating my nick in committers file.
295
296         Unreviewed.
297
298         * Scripts/webkitpy/common/config/committers.py:
299
300 2012-03-21  Peter Beverloo  <peter@chromium.org>
301
302         [Chromium] Remove Android build-fix when the proper fix rolled into WebKit
303         https://bugs.webkit.org/show_bug.cgi?id=80861
304
305         Reviewed by Tony Chang.
306
307         Remove most Android-specific logic from webkitdirs.pm in favor of
308         handling this during project generation time.
309
310         * Scripts/webkitdirs.pm:
311         (buildChromiumMakefile):
312
313 2012-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
314
315         [GTK] Allow running javascript from location bar in MiniBrowser
316         https://bugs.webkit.org/show_bug.cgi?id=81331
317
318         Reviewed by Martin Robinson.
319
320         * MiniBrowser/gtk/BrowserWindow.c:
321         (activateUriEntryCallback): Use browser_window_load_uri().
322         (browser_window_load_uri): Check whether uri starts with
323         javascript: and run the given script, or just call
324         webkit_web_view_load_uri() to load the given uri.
325         * MiniBrowser/gtk/BrowserWindow.h:
326         * MiniBrowser/gtk/main.c:
327         (createBrowserWindow): Use browser_window_load_uri().
328
329 2012-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
330
331         [GTK] Add webkit_web_view_run_javascript() to WebKit2 GTK+
332         https://bugs.webkit.org/show_bug.cgi?id=75543
333
334         Reviewed by Martin Robinson.
335
336         * MiniBrowser/gtk/GNUmakefile.am: Add javascriptcore_cppflags to
337         MiniBrowser CPP flags.
338
339 2012-03-20  Eric Seidel  <eric@webkit.org>
340
341         Move wtf/Platform.h from JavaScriptCore to Source/WTF/wtf
342         https://bugs.webkit.org/show_bug.cgi?id=80911
343
344         Reviewed by Adam Barth.
345
346         Update include paths for Source/WTF.
347
348         * DumpRenderTree/efl/CMakeLists.txt:
349         * DumpRenderTree/qt/DumpRenderTree.pro:
350         * QtTestBrowser/QtTestBrowser.pro:
351         * Scripts/build-webkit: Build Source/WTF on AppleWin as well.
352
353 2012-03-20  Adam Barth  <abarth@webkit.org>
354
355         svn-apply should move inflight patches from WebCore/webaudio to WebCore/Modules/webaudio
356         https://bugs.webkit.org/show_bug.cgi?id=81567
357
358         Reviewed by Eric Seidel.
359
360         This temporary measure should help us avoid disrupting the folks
361         working on WebAudio when we move the webaudio directory to Modules.
362
363         * Scripts/VCSUtils.pm:
364         (adjustPathForRecentRenamings):
365         (parseGitDiffHeader):
366         (parseSvnDiffHeader):
367
368 2012-03-20  Dirk Pranke  <dpranke@chromium.org>
369
370         Unreviewed, rolling out r111453.
371         http://trac.webkit.org/changeset/111453
372         https://bugs.webkit.org/show_bug.cgi?id=81600
373
374         still broken
375
376         * Scripts/webkitpy/layout_tests/port/server_process.py:
377         (ServerProcess._reset):
378         (ServerProcess.handle_interrupt):
379         (ServerProcess.write):
380         (ServerProcess._check_for_crash):
381         (ServerProcess._handle_timeout):
382         (ServerProcess._check_for_abort):
383         (ServerProcess._read):
384         (ServerProcess.stop):
385         (ServerProcess):
386         (ServerProcess.set_crashed):
387         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
388         (TrivialMockPort.is_crash_reporter):
389         (TestServerProcess.test_broken_pipe):
390         * Scripts/webkitpy/layout_tests/port/webkit.py:
391         (WebKitPort._read_image_diff):
392         (WebKitDriver.has_crashed):
393         (WebKitDriver._check_for_driver_crash):
394         (WebKitDriver):
395         (WebKitDriver._detected_crash):
396         (WebKitDriver._subprocess_crashed):
397         (WebKitDriver._crashed_process_name):
398         (WebKitDriver.run_test):
399         (WebKitDriver._read_block):
400         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
401         (MockServerProcess.__init__):
402
403 2012-03-20  Dirk Pranke  <dpranke@chromium.org>
404
405         webkitpy: get ServerProcess out of the reportcrash business
406         https://bugs.webkit.org/show_bug.cgi?id=81600
407
408         Unreviewed, build fix.
409
410         Re-land r111307 and r111293 with fix for crash in NRWT; I
411         was failing to set the crashing process name.
412
413         * Scripts/webkitpy/layout_tests/port/server_process.py:
414         (ServerProcess._reset):
415         (ServerProcess._handle_possible_interrupt):
416         (ServerProcess.write):
417         (ServerProcess.read_stdout):
418         (ServerProcess.has_crashed):
419         (ServerProcess._read):
420         (ServerProcess.stop):
421         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
422         (TrivialMockPort.check_for_leaks):
423         (TestServerProcess.test_broken_pipe):
424         * Scripts/webkitpy/layout_tests/port/webkit.py:
425         (WebKitPort._read_image_diff):
426         (WebKitDriver.has_crashed):
427         (WebKitDriver._check_for_driver_crash):
428         (WebKitDriver.run_test):
429         (WebKitDriver._read_block):
430         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
431         (MockServerProcess.__init__):
432         (MockServerProcess):
433         (MockServerProcess.has_crashed):
434
435 2012-03-20  Tim Horton  <timothy_horton@apple.com>
436
437         [mac] Restore color space switching code to run-webkit-tests
438         https://bugs.webkit.org/show_bug.cgi?id=80571
439         <rdar://problem/11008529>
440
441         Reviewed by Simon Fraser.
442
443         http://trac.webkit.org/changeset/111429 broke tools build on Snow Leopard.
444         
445         Use the old CM* API on Snow Leopard, since CGDisplayCreateUUIDFromDisplayID
446         didn't exist until Lion.
447
448         * DumpRenderTree/mac/LayoutTestHelper.m:
449         (installLayoutTestColorProfile):
450         (restoreUserColorProfile):
451
452 2012-03-20  Adele Peterson  <adele@apple.com>
453
454         Update the last test to use EXPECT_WK_STREQ.
455
456         Reviewed by Dan Bernstein.
457
458         * TestWebKitAPI/Tests/mac/AttributedString.mm: (TestWebKitAPI::TEST):
459
460 2012-03-20  Adele Peterson  <adele@apple.com>
461
462         "Attempt to insert nil value " exception when calling attributed string APIs on content with a custom font
463         https://bugs.webkit.org/show_bug.cgi?id=81630
464         <rdar://problem/10650660>
465
466         Reviewed by Alexey Proskuryakov.
467
468         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
469         * TestWebKitAPI/Tests/mac/Ahem.ttf: Added.
470         * TestWebKitAPI/Tests/mac/AttributedString.mm: Added.
471         (-[AttributedStringTest webView:didFinishLoadForFrame:]):
472         (TestWebKitAPI):
473         (TestWebKitAPI::didFinishLoadForFrame):
474         (TestWebKitAPI::TEST):
475         * TestWebKitAPI/Tests/mac/attributedStringCustomFont.html: Added.
476
477 2012-03-20  Eric Seidel  <eric@webkit.org>
478
479         Add link on queues.webkit.org to kov's fancy queue-depth graph
480         https://bugs.webkit.org/show_bug.cgi?id=81690
481
482         Reviewed by Adam Barth.
483
484         * QueueStatusServer/templates/recentstatus.html:
485
486 2012-03-20  Tim Horton  <timothy_horton@apple.com>
487
488         [mac] Restore color space switching code to run-webkit-tests
489         https://bugs.webkit.org/show_bug.cgi?id=80571
490         <rdar://problem/11008529>
491
492         Reviewed by Simon Fraser.
493
494         Make use of the layout test helper hooks to restore the Mac system-wide
495         color profile switching code. This makes WkTR and DRT results match, and
496         causes the main display's color profile to not affect results on Lion.
497
498         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
499         * DumpRenderTree/mac/LayoutTestHelper.m: Added.
500         (installLayoutTestColorProfile):
501         (restoreUserColorProfile):
502         (simpleSignalHandler):
503         (main):
504         * Scripts/webkitpy/layout_tests/port/mac.py:
505         (MacPort.release_http_lock):
506         (MacPort):
507         (MacPort._path_to_helper):
508         (MacPort.start_helper):
509         (MacPort.stop_helper):
510         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
511         (WTR::PlatformWebView::PlatformWebView):
512         (WTR::PlatformWebView::windowSnapshotImage):
513
514 2012-02-24  Darin Fisher  <darin@chromium.org>
515
516         Add more Chromium WebKit API reviewers
517         https://bugs.webkit.org/show_bug.cgi?id=81576
518
519         Reviewed by Adam Barth and David Levin.
520
521         Simplify watchlist to lump all WebKit API into one.
522
523         * Scripts/webkitpy/common/config/watchlist:
524
525 2012-03-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
526
527         Convert hasSpellingMarker to use Internals interface.
528         https://bugs.webkit.org/show_bug.cgi?id=81300
529
530         Reviewed by Ryosuke Niwa.
531
532         Remove hasSpellingMarker functions, because it is able to work in the
533         cross-port way through the Internals interface.
534
535         * DumpRenderTree/LayoutTestController.cpp:
536         (LayoutTestController::staticFunctions):
537         * DumpRenderTree/LayoutTestController.h:
538         (LayoutTestController):
539         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
540         * DumpRenderTree/chromium/LayoutTestController.cpp:
541         (LayoutTestController::LayoutTestController):
542         * DumpRenderTree/chromium/LayoutTestController.h:
543         (LayoutTestController):
544         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
545         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
546         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
547         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
548         * DumpRenderTree/qt/LayoutTestControllerQt.h:
549         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
550         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
551
552 2012-03-20  Csaba Osztrogonác  <ossy@webkit.org>
553
554         Add new Qt-WK2 performance tester bot to build.webkit.org
555         https://bugs.webkit.org/show_bug.cgi?id=80842
556
557         Reviewed by Ryosuke Niwa.
558
559         * BuildSlaveSupport/build.webkit.org-config/config.json:
560         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
561         (RunAndUploadPerfTestsWebKit2):
562         (RunAndUploadPerfTestsWebKit2.start):
563         (BuildAndPerfTestWebKit2Factory):
564         (BuildAndPerfTestWebKit2Factory.__init__):
565         (DownloadAndPerfTestWebKit2Factory):
566         (DownloadAndPerfTestWebKit2Factory.__init__):
567
568 2012-03-20  Peter Beverloo  <peter@chromium.org>
569
570         [Chromium] Update to Android NDK r7b
571         https://bugs.webkit.org/show_bug.cgi?id=81005
572
573         Reviewed by Adam Barth.
574
575         Update to version r7b of the Android NDK, release notes of which are
576         available on the following page:
577         http://developer.android.com/sdk/ndk/index.html
578
579         * Scripts/update-webkit-chromium:
580
581 2012-03-20  Csaba Osztrogonác  <ossy@webkit.org>
582
583         x86 GCC bug triggers a compilation error in generated copy constructor of CollapsedBorderValue
584         https://bugs.webkit.org/show_bug.cgi?id=81502
585
586         Unreviewed.
587
588         * qmake/mkspecs/features/unix/default_post.prf: Reenable Werror after r111171.
589
590 2012-03-19  Jessie Berlin  <jberlin@apple.com>
591
592         Unreviewed; roll out http://trac.webkit.org/changeset/111307 and http://trac.webkit.org/changeset/111293
593         because they broke running the layout tests on mac.
594
595         * Scripts/webkitpy/layout_tests/port/webkit.py:
596         (WebKitDriver._check_for_driver_crash):
597
598 2012-03-16  Martin Robinson  <mrobinson@igalia.com>
599
600         [GTK] Allow running run-gtk-tests during 'make distcheck'
601         https://bugs.webkit.org/show_bug.cgi?id=81415
602
603         Reviewed by Philippe Normand.
604
605         Modify the build and run-gtk-tests so that it can run during 'make distcheck'
606
607         * GNUmakefile.am: Distribute run-gtk-tests during 'make dist' and make it the
608         main command run during 'make check.'
609         * Scripts/run-gtk-tests: Refactored run-gtk-tests so that jhbuild is no longer
610         a requirement to run it. If jhbuild isn't around it will simply not start the
611         SPI daemons and skip the WebKit2 accessibility test. Remove test runs from the
612         main loop and simply use the main loop in a synchronous method to start SPI
613         daemons. Did a bunch of general cleanup around these tasks.
614
615 2012-03-19  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
616
617         jhbuild: Use the multiprocessing module to get the number of CPUs.
618         https://bugs.webkit.org/show_bug.cgi?id=81585
619
620         Reviewed by Martin Robinson.
621
622         Now that support for Python 2.5 has been dropped, we can safely
623         use multiprocessing.cpu_count() to obtain the current number of
624         CPUs in the system instead of running a webkitperl script for
625         that.
626
627         * efl/common.py:
628         (top_level_path):
629         * efl/jhbuildrc:
630         * gtk/common.py:
631         (build_path):
632         * gtk/jhbuildrc:
633
634 2012-03-19  Ojan Vafai  <ojan@chromium.org>
635
636         We should only add a live event listener once, not once per TestSelector.
637         Adding one per TestSelector would cause accordion('option', 'active') to
638         incorrectly be "false" if you examine multiple sets of tests.
639
640         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
641
642 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
643
644         Fix typo introduced in r111293.
645
646         Unreviewed, build fix.
647
648         * Scripts/webkitpy/layout_tests/port/webkit.py:
649         (WebKitDriver._check_for_driver_crash):
650
651 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
652
653         webkitpy: get ServerProcess out of the reportcrash business
654         https://bugs.webkit.org/show_bug.cgi?id=81600
655
656         Reviewed by Adam Barth.
657
658         ServerProcess was half-aware that ReportCrash might run
659         sometimes, and that the process ServerProcess was talking to
660         might have its own crashing subprocesses; neither of these
661         things really worked right and it made the logic convoluted, so
662         this change makes handling crashes completely separate from the
663         server_process code, so that it can focus on just I/O to the
664         subprocess.
665
666         There should be no functional changes resulting from this patch.
667
668         * Scripts/webkitpy/layout_tests/port/server_process.py:
669         (ServerProcess._reset):
670         (ServerProcess._handle_possible_interrupt):
671         (ServerProcess.write):
672         (ServerProcess.read_stdout):
673         (ServerProcess.has_crashed):
674         (ServerProcess._read):
675         (ServerProcess.stop):
676         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
677         (TrivialMockPort.check_for_leaks):
678         (TestServerProcess.test_broken_pipe):
679         * Scripts/webkitpy/layout_tests/port/webkit.py:
680         (WebKitPort._read_image_diff):
681         (WebKitDriver.has_crashed):
682         (WebKitDriver._check_for_driver_crash):
683         (WebKitDriver.run_test):
684         (WebKitDriver._read_block):
685         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
686         (MockServerProcess.__init__):
687         (MockServerProcess):
688         (MockServerProcess.has_crashed):
689
690 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
691
692         webkitpy: crashlog parsing is broken
693         https://bugs.webkit.org/show_bug.cgi?id=81586
694
695         Reviewed by Adam Barth.
696
697         Seeking on a file opened through codecs() appears to not work
698         correctly (at least on SL).
699         
700         The code was more complicated than it needed to be, so I have
701         revamped it to just read a full crashlog at once and then look
702         for matches. 
703         
704         I have also added the ability to optionally propagate
705         errors back (which can be helpful to debug races when ReportCrash is
706         still running and you need to see that you couldn't open some
707         files, rather than just ignoring them).
708
709         * Scripts/webkitpy/common/system/crashlogs.py:
710         (CrashLogs.find_newest_log):
711         (CrashLogs._find_newest_log_darwin):
712         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
713         (CrashLogsTest.test_find_log_darwin):
714
715 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
716
717         webkitpy: clean up some port._filesystem references to not reference private members
718         https://bugs.webkit.org/show_bug.cgi?id=81595
719
720         Reviewed by Eric Seidel.
721
722         There should be no functional changes in this patch, just some
723         refactoring. Also, fixes a minor nit in write_image_diff_files(()
724
725         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
726         (SingleTestRunner.__init__):
727         (SingleTestRunner._run_compare_test):
728         (SingleTestRunner._run_rebaseline):
729         (SingleTestRunner._save_baseline_data):
730         (SingleTestRunner._handle_error):
731         (SingleTestRunner._run_reftest):
732         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
733         (write_test_result):
734         (TestResultWriter.__init__):
735         (TestResultWriter._make_output_directory):
736         (TestResultWriter.output_filename):
737         (TestResultWriter._output_testname):
738         (TestResultWriter.write_output_files):
739         (TestResultWriter.write_stderr):
740         (TestResultWriter.write_crash_report):
741         (TestResultWriter.create_text_diff_and_write_result):
742         (TestResultWriter.write_image_diff_files):
743         (copy_file):
744         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
745         (TestResultWriterTest.test_reftest_diff_image):
746
747 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
748
749         webkitpy: fix nit - incorrect reference to DRT in test_expectations.py
750         https://bugs.webkit.org/show_bug.cgi?id=81598
751
752         Reviewed by Eric Seidel.
753
754         "DumpRenderTree" shouldn't be hard-coded here, since some other
755         process may actually be crashing (WebKitTestRunner, WebProcess, etc.)
756         
757         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
758         (TestExpectations):
759
760 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
761
762         webkitpy: allow instance data in TestFailure objects
763         https://bugs.webkit.org/show_bug.cgi?id=81580
764
765         Reviewed by Tony Chang.
766
767         Current TestFailures are basically enums, but it would be nice,
768         especially for crashes, if they contained the name and pid of
769         the process that crashed.
770
771         * Scripts/webkitpy/layout_tests/models/test_failures.py:
772         (TestFailure.message):
773         (FailureTimeout.message):
774         (FailureCrash):
775         (FailureCrash.__init__):
776         (FailureCrash.message):
777         (FailureMissingResult.message):
778         (FailureTextMismatch.message):
779         (FailureMissingImageHash.message):
780         (FailureMissingImage.message):
781         (FailureImageHashMismatch.message):
782         (FailureImageHashIncorrect.message):
783         (FailureReftestMismatch.message):
784         (FailureReftestMismatchDidNotOccur.message):
785         (FailureReftestNoImagesGenerated.message):
786         (FailureMissingAudio.message):
787         (FailureAudioMismatch.message):
788         * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
789         (TestFailuresTest.test_equals):
790         (TestFailuresTest):
791         (TestFailuresTest.test_crashes):
792
793 2012-03-19  Brady Eidson  <beidson@apple.com>
794
795         <rdar://problem/10917120> and https://bugs.webkit.org/show_bug.cgi?id=81066
796         Crash in 3rd party WebKit apps under XHR/Cache code
797
798         Reviewed by Antti Koivisto.
799
800         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
801         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.html: Added.
802         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm: Added.
803         (-[MemoryCachePruneTestResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
804         (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
805         (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
806         (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
807         (TestWebKitAPI):
808         (TestWebKitAPI::TEST):
809
810 2012-03-19  Brady Eidson  <beidson@apple.com>
811
812         <rdar://problem/10848575> and https://bugs.webkit.org/show_bug.cgi?id=81516
813         REGRESSION (r107435) URLs copied from WebKit apps aren't in the right pasteboard format
814
815         Reviewed by Enrica Casucci.
816
817         Bring up a context menu on a link, copy the link, then verify the pasteboard contents
818         are in the correct format.
819
820         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
821         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html: Added.
822         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm: Added.
823         (-[ContextMenuCanCopyURLDelegate webView:didFinishLoadForFrame:]):
824         (TestWebKitAPI::contextMenuCopyLink):
825         (TestWebKitAPI::TEST):
826
827 2012-03-19  Ojan Vafai  <ojan@chromium.org>
828
829         Make the selected item in the accordion a link to the flakiness dashboard
830         https://bugs.webkit.org/show_bug.cgi?id=81571
831
832         Reviewed by Dimitri Glazkov.
833
834         Also, make it so that you can select the text of the link, instead of the current behavior
835         of acting as if you had clicked on the accordion header.
836
837         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
838         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
839
840 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
841
842         NRWT runs some tests that are skipped with -i command line option
843         https://bugs.webkit.org/show_bug.cgi?id=81535
844
845         Reviewed by Ojan Vafai.
846
847         This change modifies the interaction of Skipped files and
848         test_expectations files so that entries in Skipped files (and
849         the -i command line) override *everything* in the expectations
850         file.
851
852         Specifically, a directory in a Skipped file will cause all of
853         the tests in the dir to be skipped even if individual tests in
854         the dir are listed in the test_expectations.txt.
855
856         Skipped files also override anything in an overrides files.
857
858         This seems to make more intuitive sense, since if you list
859         something in the Skips file (and even more specify it on the
860         command line) you probably want it to be universally applied.
861
862         Theoretically we could add more precedence levels and have full
863         paths in an expectations file override dirs in a Skipped file
864         (but not the command line), but I don't know yet that that level
865         of complexity is justified.
866         
867         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
868         (TestExpectations.__init__):
869         (TestExpectations._add_skipped_tests):
870         (TestExpectations._add_test):
871         (TestExpectations._add_expectations):
872         (TestExpectations._add_expectation_line):
873         (TestExpectations._already_seen_better_match):
874         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
875         (test_more_specific_override_resets_skip):
876         (SkippedTests):
877         (SkippedTests.get_exp):
878         (SkippedTests.assert_exp):
879         (SkippedTests.test_skipped_tests_work):
880         (SkippedTests.test_duplicate_skipped_test_fails_lint):
881         (SkippedTests.test_skipped_file_overrides_expectations):
882         (SkippedTests.test_skipped_dir_overrides_expectations):
883         (SkippedTests.test_skipped_file_overrides_overrides):
884         (SkippedTests.test_skipped_dir_overrides_overrides):
885
886 2012-03-19  Eric Seidel  <eric@webkit.org>
887
888         Fix WTF header include discipline in Chromium WebKit
889         https://bugs.webkit.org/show_bug.cgi?id=81281
890
891         Reviewed by James Robinson.
892
893         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
894         * Scripts/update-webkit-chromium: Made it possible to run this from a directory other than the root.
895
896 2012-03-19  Andy Chen  <andchen@rim.com>
897
898         [BlackBerry] Add new layout test for text match marker
899         https://bugs.webkit.org/show_bug.cgi?id=81531
900
901         Make the LayoutTestControllerBlackBerry::findString to test the
902         BlackBerry port implementation.
903
904         Reviewed by Rob Buis.
905
906         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
907         (LayoutTestController::findString):
908
909 2012-03-19  Ojan Vafai  <ojan@chromium.org>
910
911         Don't show WONTFIX tests in garden-o-matic
912         https://bugs.webkit.org/show_bug.cgi?id=81554
913
914         Reviewed by Dimitri Glazkov.
915
916         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
917         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
918
919 2012-03-19  Chris Fleizach  <cfleizach@apple.com>
920
921         platform/mac/accessibility/selected-rows-table.html failing on Lion Intel Debug WebKit2 testers
922         https://bugs.webkit.org/show_bug.cgi?id=81530
923
924         Reviewed by Jessie Berlin.
925
926         Add rowAtIndex to WebKitTestRunner.
927
928         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
929         (WTR::AccessibilityUIElement::rowAtIndex):
930         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
931         (AccessibilityUIElement):
932         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
933         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
934         (WTR):
935         (WTR::AccessibilityUIElement::rowAtIndex):
936
937 2012-03-19  Ojan Vafai  <ojan@chromium.org>
938
939         Change garden-o-matic All Failures tab to Expected Failures
940         https://bugs.webkit.org/show_bug.cgi?id=81540
941
942         Reviewed by Dimitri Glazkov.
943
944         Also, fix some broken unittests that had just gotten stale.
945
946         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
947         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers/rebaseline.js:
948         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
949         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
950         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
951         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
952         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
953         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
954         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
955         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
956
957 2012-03-19  Hao Zheng  <zhenghao@chromium.org>
958
959         [chromium] DRT crashes at shutdown.
960         https://bugs.webkit.org/show_bug.cgi?id=81504
961
962         Reviewed by James Robinson.
963
964         WebCompositor must be destroyed after WebView is properly destroyed,
965         or some compositor objects like CCLayerTreeHost may not be destroyed.
966         However, it is really hard to make the destruction order correct
967         explicitly in ~TestShell. So move it out to DumpRenderTree.
968
969         * DumpRenderTree/chromium/DumpRenderTree.cpp:
970         (main):
971         * DumpRenderTree/chromium/TestShell.cpp:
972         (TestShell::~TestShell):
973
974 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
975
976         add dpranke to webkitpy watchlist
977         https://bugs.webkit.org/show_bug.cgi?id=81433
978
979         Reviewed by Benjamin Poulain.
980
981         * Scripts/webkitpy/common/config/watchlist:
982
983 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
984
985         test-webkitpy is failing on SL/Python 2.6.1
986         https://bugs.webkit.org/show_bug.cgi?id=81533
987
988         Reviewed by Ojan Vafai.
989
990         It appears that itertools.combinations() is buggy in 2.6.1; this
991         backports the implementation from 2.7.
992
993         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
994         (TestConfigurationConverter.collapse_macros):
995         (TestConfigurationConverter):
996         (TestConfigurationConverter.combinations):
997
998 2012-03-19  David Michael Barr  <davidbarr@google.com>
999
1000         Optimize the cleanup sequence in the start-queue.sh script
1001         https://github.com/abarth/webkit/pull/1
1002
1003         Reviewed by Adam Barth.
1004
1005         Updating the working copy is an expensive operation
1006         for a repository the size of WebKit.
1007         Attempt to reset only to the target revision.
1008
1009         * EWSTools/start-queue.sh:
1010
1011 2012-03-19  Raphael Kubo da Costa  <kubo@profusion.mobi>
1012
1013         Adjust architecture type of the EFL build bot.
1014         https://bugs.webkit.org/show_bug.cgi?id=81452
1015
1016         Reviewed by Tony Chang.
1017
1018         * BuildSlaveSupport/build.webkit.org-config/config.json: The
1019         buildslave is a 64-bit machine, therefore describe it as being
1020         x86_64, not i386.
1021
1022 2012-03-19  Alexander Færøy  <alexander.faeroy@nokia.com>
1023
1024         [Qt] printLoadedUrls prints "Object" instead of the actual URL.
1025         https://bugs.webkit.org/show_bug.cgi?id=81514
1026
1027         Reviewed by Simon Hausmann.
1028
1029         * MiniBrowser/qt/qml/BrowserWindow.qml:
1030
1031 2012-03-19  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
1032
1033         [EFL] jhbuild: Set CMAKE_PREFIX_PATH in jhbuildrc.
1034         https://bugs.webkit.org/show_bug.cgi?id=81491
1035
1036         Reviewed by Philippe Normand.
1037
1038         For the find_path(), find_library() etc CMake calls to find the
1039         dependencies built with jhbuild, CMAKE_PREFIX_PATH must be properly
1040         set, otherwise CMake cannot know the dependencies exist and will only
1041         look in the standard directories.
1042
1043         * efl/jhbuildrc: Set the CMAKE_PREFIX_PATH environment variable with
1044         the jhbuild Root directory.
1045
1046 2012-03-19  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
1047
1048         [EFL] Add XDG env vars to jhbuildrc
1049         https://bugs.webkit.org/show_bug.cgi?id=81510
1050
1051         Needed to ensure correct glib behaviour in jhbuild environment.
1052
1053         Reviewed by Philippe Normand.
1054
1055         * efl/jhbuildrc:
1056
1057 2012-03-19  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
1058
1059         Select best target for tap gesture.
1060         https://bugs.webkit.org/show_bug.cgi?id=78801
1061
1062         Reviewed by Kenneth Rohde Christiansen.
1063
1064         Add TOUCH_ADJUSTMENT to enabled features.
1065
1066         * qmake/mkspecs/features/features.prf:
1067
1068 2012-03-19  Robert Kroeger  <rjkroege@chromium.org>
1069
1070         [chromium] synthesize wheel events for fling on main thread
1071         https://bugs.webkit.org/show_bug.cgi?id=81458
1072
1073         Added the ability to dispatch GestureFlingStart and GestureFlingCancel from EventSender.
1074
1075         Reviewed by James Robinson.
1076
1077         * DumpRenderTree/chromium/EventSender.cpp:
1078         (EventSender::EventSender):
1079         (EventSender::gestureFlingCancel):
1080         (EventSender::gestureFlingStart):
1081         * DumpRenderTree/chromium/EventSender.h:
1082         (EventSender):
1083
1084 2012-03-19  Alexander Færøy  <alexander.faeroy@nokia.com>
1085
1086         [Qt] Add command line option to set the user agent in the MiniBrowser
1087         https://bugs.webkit.org/show_bug.cgi?id=81508
1088
1089         Reviewed by Simon Hausmann.
1090
1091         * MiniBrowser/qt/BrowserWindow.cpp:
1092         (BrowserWindow::BrowserWindow):
1093         (BrowserWindow::webViewExperimental):
1094         * MiniBrowser/qt/BrowserWindow.h:
1095         (BrowserWindow):
1096         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1097         (printHelp):
1098         (MiniBrowserApplication::handleUserOptions):
1099         * MiniBrowser/qt/MiniBrowserApplication.h:
1100         (WindowOptions::WindowOptions):
1101         (WindowOptions::setUserAgent):
1102         (WindowOptions::userAgent):
1103         (WindowOptions):
1104
1105 2012-03-19  Alexander Færøy  <alexander.faeroy@nokia.com>
1106
1107         [Qt] Remove dead user agent code from the MiniBrowser.
1108
1109         Reviewed by Simon Hausmann.
1110
1111         * MiniBrowser/qt/BrowserWindow.cpp:
1112         * MiniBrowser/qt/BrowserWindow.h:
1113         (BrowserWindow):
1114         * MiniBrowser/qt/MiniBrowser.qrc:
1115         * MiniBrowser/qt/useragentlist.txt: Removed.
1116
1117 2012-03-19  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
1118
1119         jhbuild: Call jhbuild's autogen.sh via bash.
1120         https://bugs.webkit.org/show_bug.cgi?id=81485
1121
1122         Reviewed by Philippe Normand.
1123
1124         jhbuild's autogen.sh uses "/bin/bash" in the shebang line, however
1125         this is usually true only on Linux systems, and even then bash for
1126         some reason might not be available in that location. It is safer to
1127         call bash directly and pass autogen.sh to it instead.
1128
1129         * jhbuild/jhbuild-wrapper:
1130         (install_jhbuild):
1131
1132 2012-03-19  Philippe Normand  <pnormand@igalia.com>
1133
1134         [GTK] Prefix run-launcher with run-with-jhbuild
1135         https://bugs.webkit.org/show_bug.cgi?id=81503
1136
1137         Reviewed by Hajime Morita.
1138
1139         * Scripts/run-launcher:
1140
1141 2012-03-19  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
1142
1143         [EFL] Prefix run-launcher with run-with-jhbuild
1144         https://bugs.webkit.org/show_bug.cgi?id=80026
1145
1146         Reviewed by Hajime Morita.
1147
1148         * Scripts/run-launcher:
1149
1150 2012-03-18  Csaba Osztrogonác  <ossy@webkit.org>
1151
1152         [Qt] Unreviewed. Disable -Werror on x86 until proper fix.
1153         https://bugs.webkit.org/show_bug.cgi?id=81498
1154
1155         * qmake/mkspecs/features/unix/default_post.prf:
1156
1157 2012-03-17  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
1158
1159         Unreviewed; switch to using my FreeBSD.org email address, the
1160         other one is going to disappear soon.
1161
1162         * Scripts/webkitpy/common/config/committers.py:
1163         * Scripts/webkitpy/common/config/watchlist:
1164
1165 2012-03-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
1166
1167         Unreviewed; fix webkitpy unit test failures after r111116.
1168
1169         It turns out that cmd_line in the patch in bug 80025 had the right
1170         signature when it was submitted, but r109242 added a few more
1171         required parameters, and since the method (and EflDriver) did not
1172         exist at the time we ended up committing a broken method.
1173
1174         * Scripts/webkitpy/layout_tests/port/efl.py:
1175         (EflDriver.cmd_line): Add the `pixel_tests' and `per_test_args'
1176         arguments.
1177
1178 2012-03-17  Charles Wei  <charles.wei@torchmobile.com.cn>
1179
1180         [BlackBerry] Enable Web Timing for performance profiling and improvement.
1181         https://bugs.webkit.org/show_bug.cgi?id=81085
1182
1183         Reviewed by Rob Buis.
1184
1185         * Scripts/build-webkit:
1186
1187 2012-03-17  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
1188
1189         Add a dependencies installation step for EFL to buildbot master.cfg
1190         https://bugs.webkit.org/show_bug.cgi?id=81337
1191
1192         Reviewed by Gustavo Noronha Silva.
1193
1194         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1195         (InstallEflDependencies):
1196         (Factory.__init__):
1197
1198 2012-03-17  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
1199
1200         [EFL] Prefixing run-webkit-tests with run-with-jhbuild
1201         https://bugs.webkit.org/show_bug.cgi?id=80025
1202
1203         Reviewed by Gustavo Noronha Silva.
1204
1205         * Scripts/webkitpy/layout_tests/port/efl.py:
1206         (EflDriver):
1207         (EflDriver.cmd_line):
1208         (EflPort._driver_class):
1209
1210 2012-03-17  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
1211
1212         [EFL] Add and use run-with-jhbuild and update-webkitefl-libs scripts for EFL
1213         https://bugs.webkit.org/show_bug.cgi?id=79904
1214
1215         build-webkit --efl will use jhbuild for fetching and building dependencies.
1216
1217         Reviewed by Gustavo Noronha Silva.
1218
1219         * Scripts/update-webkitefl-libs: Added.
1220         * Scripts/webkitdirs.pm:
1221         (jhbuildWrapperPrefixIfNeeded):
1222         (generateBuildSystemFromCMakeProject):
1223         (buildCMakeGeneratedProject):
1224         * efl/common.py: Added.
1225         (script_path):
1226         (top_level_path):
1227         (number_of_cpus):
1228         * efl/jhbuild.modules: Added.
1229         * efl/jhbuildrc: Added.
1230         * efl/run-with-jhbuild: Added.
1231
1232 2012-03-16  Stephanie Lewis  <slewis@apple.com>
1233
1234         https://bugs.webkit.org/show_bug.cgi?id=81065
1235         <rdar://problem/10944309> CrashTracer: [USER] 111 crashes in WebProcess at WebKitTestRunnerInjectedBundle: WTR::InjectedBundle::done + 142
1236         Fix crash preventing WebKitTestRunner from working in Release.  
1237         WebKitTestRunner used ostringstream to collect output from the test.  ostringstream is incompatible with our
1238         FastMalloc overrides.  When copying strings out ostringstream a new string is allocated with FastMalloc because
1239         the allocation is inlined.  When that string is freed is uses the system malloc because that call is not inlined.
1240
1241         I removed ostringstream in favor of StringBuilder.  
1242
1243         Properly set NDEBUG on Release builds so we don't crash when when we free the strings StringBuilder created.
1244
1245         Reviewed by Geoff Garen.
1246
1247         Add DEBUG_DEFINES to set NDEBUG on release builds.
1248         * WebKitTestRunner/Configurations/Base.xcconfig:
1249         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1250
1251         Remove ostringstream member in favor of StringBuilder.
1252         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1253         (WTR::InjectedBundle::initialize):
1254         (WTR::InjectedBundle::beginTesting):
1255         (WTR::InjectedBundle::done):
1256         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1257         (WTF):
1258         (WTR::InjectedBundle::stringBuilder):
1259         (InjectedBundle):
1260
1261         Append output to StringBuilder.
1262         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1263         (WTR::hasPrefix):
1264         (WTR::dumpPath):
1265         (WTR::rangeToStr):
1266         (WTR::styleDecToStr):
1267         (WTR::frameToStr):
1268         (WTR::dumpFrameScrollPosition):
1269         (WTR::dumpFrameText):
1270         (WTR::dumpDescendantFramesText):
1271         (WTR::InjectedBundlePage::dump):
1272         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
1273         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
1274         (WTR::InjectedBundlePage::willSendRequestForFrame):
1275         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1276         (WTR::lastFileURLPathComponent):
1277         (WTR::InjectedBundlePage::willAddMessageToConsole):
1278         (WTR::InjectedBundlePage::willSetStatusbarText):
1279         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
1280         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
1281         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
1282         (WTR::InjectedBundlePage::shouldBeginEditing):
1283         (WTR::InjectedBundlePage::shouldEndEditing):
1284         (WTR::InjectedBundlePage::shouldInsertNode):
1285         (WTR::InjectedBundlePage::shouldInsertText):
1286         (WTR::InjectedBundlePage::shouldDeleteRange):
1287         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
1288         (WTR::InjectedBundlePage::shouldApplyStyle):
1289         (WTR::InjectedBundlePage::didBeginEditing):
1290         (WTR::InjectedBundlePage::didEndEditing):
1291         (WTR::InjectedBundlePage::didChange):
1292         (WTR::InjectedBundlePage::didChangeSelection):
1293         (WTR::InjectedBundlePage::supportsFullScreen):
1294         (WTR::InjectedBundlePage::enterFullScreenForElement):
1295         (WTR::InjectedBundlePage::exitFullScreenForElement):
1296         (WTR::InjectedBundlePage::beganEnterFullScreen):
1297         (WTR::InjectedBundlePage::beganExitFullScreen):
1298         (WTR::dumpBackForwardListItem):
1299         (WTR::InjectedBundlePage::dumpBackForwardList):
1300         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1301         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired):
1302         (WTR::LayoutTestController::dumpConfigurationForViewport):
1303         
1304         Convert between WTF::String and WKStringRef.
1305         * WebKitTestRunner/StringFunctions.h:
1306         (WTR::toWTFString):
1307         (WTR):
1308         * WebKitTestRunner/TestInvocation.cpp:
1309         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1310
1311 2012-03-16  Eric Seidel  <eric@webkit.org>
1312
1313         Add a land-from-url command
1314         https://bugs.webkit.org/show_bug.cgi?id=81411
1315
1316         Reviewed by Adam Barth.
1317
1318         Very basic so far.  The goal is to make it landing smarter
1319         so that users don't have to bother to parse out the ids out of the urls.
1320
1321         * Scripts/webkitpy/common/config/urls.py:
1322         (parse_bug_id):
1323         (parse_attachment_id):
1324         * Scripts/webkitpy/common/config/urls_unittest.py:
1325         (URLsTest.test_parse_bug_id):
1326         (URLsTest):
1327         (URLsTest.test_parse_attachment_id):
1328         * Scripts/webkitpy/tool/commands/download.py:
1329         (ProcessURLsMixin):
1330         (ProcessURLsMixin._fetch_list_of_patches_to_process):
1331         (LandFromURL):
1332         * Scripts/webkitpy/tool/commands/download_unittest.py:
1333         (test_land_from_bug):
1334         (test_land_from_url):
1335
1336 2012-03-16  Dave Tharp  <dtharp@codeaurora.org>
1337
1338         build-webkit launcher instructions use wrong relative path for Qt
1339         https://bugs.webkit.org/show_bug.cgi?id=81357
1340
1341         Reviewed by Eric Seidel.
1342
1343         Ensure we are at the proper directory before generating run-launcher
1344         instructions.
1345
1346         * Scripts/build-webkit:
1347
1348 2012-03-16  Brady Eidson  <beidson@apple.com>
1349
1350         <rdar://problem/11027997> and https://bugs.webkit.org/show_bug.cgi?id=81412
1351         REGRESSION (r107435) Copy a link and paste to Mail: Nothing is pasted
1352
1353         Reviewed by Geoff Garen.
1354
1355         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1356         * TestWebKitAPI/Tests/mac/WebViewCanPasteURL.mm: Added.
1357
1358 2012-03-16  Ojan Vafai  <ojan@chromium.org>
1359
1360         Mark wontfix tests in full_results.json so we can ignore them in garden-o-matic
1361         https://bugs.webkit.org/show_bug.cgi?id=81407
1362
1363         Reviewed by Adam Barth.
1364
1365         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1366         (summarize_results):
1367         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1368         (ResultSummaryTest.summarized_results):
1369         (ResultSummaryTest.test_no_svn_revision):
1370         (ResultSummaryTest.test_svn_revision):
1371         (ResultSummaryTest):
1372         (ResultSummaryTest.test_summarized_results_wontfix):
1373
1374 2012-03-16  Ojan Vafai  <ojan@chromium.org>
1375
1376         Have webkit-patch rebaseline-test update test_expectations.txt
1377         https://bugs.webkit.org/show_bug.cgi?id=81054
1378
1379         Recommit http://trac.webkit.org/changeset/110783 now that
1380         http://trac.webkit.org/changeset/111034 has landed.
1381
1382         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1383         (TestExpectations.remove_configuration_from_test):
1384         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1385         (RemoveConfigurationsTest):
1386         (RemoveConfigurationsTest.test_remove):
1387         (test_remove_line):
1388         * Scripts/webkitpy/tool/commands/rebaseline.py:
1389         (RebaselineTest._update_expectations_file):
1390         (RebaselineTest._rebaseline_test_and_update_expectations):
1391         (RebaselineTest):
1392         (RebaselineTest.execute):
1393         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1394         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
1395         (test_rebaseline_updates_expectations_file):
1396
1397 2012-03-15  Ojan Vafai  <ojan@chromium.org>
1398
1399         Specifier collapsing when writing test expectations lines gets a number of cases wrong
1400         https://bugs.webkit.org/show_bug.cgi?id=81309
1401
1402         Reviewed by Dimitri Glazkov.
1403
1404         I've run this over all the lines in the current Chromium test_expectations.txt file,
1405         so I'm relatively confident we now cover all the cases.
1406
1407         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
1408         (TestConfigurationConverter.__init__):
1409         (TestConfigurationConverter.collapse_macros):
1410         (TestConfigurationConverter.collapse_macros.collapse_individual_specifier_set):
1411         (TestConfigurationConverter):
1412         (TestConfigurationConverter.intersect_combination):
1413         (TestConfigurationConverter.symmetric_difference):
1414         (TestConfigurationConverter.to_specifiers_list):
1415         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
1416         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
1417         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
1418         (make_mock_all_test_configurations_set):
1419         (TestConfigurationConverterTest.test_symmetric_difference):
1420         (TestConfigurationConverterTest.test_to_config_set):
1421         (TestConfigurationConverterTest.test_macro_expansion):
1422         (TestConfigurationConverterTest.test_to_specifier_lists):
1423         (TestConfigurationConverterTest.test_converter_macro_collapsing):
1424         * Scripts/webkitpy/layout_tests/port/chromium.py:
1425         (ChromiumPort):
1426         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1427         (ChromiumAndroidPort.__init__):
1428         The android port uses "arm" as it's architecture, which is technically correct,
1429         but considerably complicates making collapsing work. We probably should kill
1430         the concept of architecture entirely. The benefits are not worth the code
1431         complexity.
1432
1433         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1434         (ChromiumPortTest.test_all_test_configurations):
1435         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1436         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
1437         (test_rebaseline_updates_expectations_file):
1438
1439 2012-03-16  Dinu Jacob  <dinu.jacob@nokia.com>
1440
1441         [Qt][Wk2] Assertion Failure and crash on file upload
1442         https://bugs.webkit.org/show_bug.cgi?id=80854
1443
1444         Reviewed by Simon Hausmann.
1445
1446         Added filePicker to WebView using experimental API.
1447
1448         * MiniBrowser/qt/MiniBrowser.qrc:
1449         * MiniBrowser/qt/icons/folder.png: Added.
1450         * MiniBrowser/qt/icons/titlebar.png: Added.
1451         * MiniBrowser/qt/icons/up.png: Added.
1452         * MiniBrowser/qt/qml/BrowserWindow.qml:
1453         * MiniBrowser/qt/qml/FilePicker.qml: Added.
1454
1455 2012-03-16  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1456
1457         Updating email for committer.py script.
1458
1459         * Scripts/webkitpy/common/config/committers.py:
1460
1461 2012-03-16  Robert Kroeger  <rjkroege@chromium.org>
1462
1463         [chromium] DRT: Add support for sending gesture scrolls without a begin
1464         https://bugs.webkit.org/show_bug.cgi?id=81292
1465
1466         Reviewed by Kent Tamura.
1467
1468         * DumpRenderTree/chromium/EventSender.cpp:
1469         (EventSender::EventSender):
1470         (EventSender::gestureScrollFirstPoint):
1471         * DumpRenderTree/chromium/EventSender.h:
1472         (EventSender):
1473
1474 2012-03-02  Carlos Garcia Campos  <cgarcia@igalia.com> and Sergio Villar Senin  <svillar@igalia.com>
1475
1476         [GTK] WebKitIconDatabase doesn't keep icons cached
1477         https://bugs.webkit.org/show_bug.cgi?id=56200
1478
1479         Reviewed by Martin Robinson.
1480
1481         Add support for favicons in GtkLauncher.
1482
1483         * GtkLauncher/main.c:
1484         (activateUriEntryCb):
1485         (iconLoadedCb):
1486         (createBrowser):
1487
1488 2012-03-16  Adam Barth  <abarth@webkit.org>
1489
1490         Remove sheriff-bot's last-green-revision command
1491         https://bugs.webkit.org/show_bug.cgi?id=81314
1492
1493         Reviewed by Eric Seidel.
1494
1495         This command is a cruel joke.  WebKit doesn't really ever have a
1496         last-green-revision.
1497
1498         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1499         (BuildBot._find_green_revision):
1500         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
1501         (MockBuildBot.builder_statuses):
1502         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1503         (test_find_green_revision):
1504         * Scripts/webkitpy/tool/bot/irc_command.py:
1505         (IRCCommand.execute):
1506         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1507         (SheriffIRCBotTest.test_help):
1508         * Scripts/webkitpy/tool/commands/queries.py:
1509         (PatchesToReview.execute):
1510
1511 2012-03-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1512
1513         [Qt] Make gccdepends test aware of broken icecream deps generation
1514
1515         Icecream seems to build the files without passing -o to gcc with
1516         the original destination path, which means the target name in the
1517         dependency file is wrong.
1518
1519         Also, echo something to the final file instead of just touching it,
1520         so it's not deleted on every build.
1521
1522         Reviewed by Simon Hausmann.
1523
1524         * qmake/config.tests/gccdepends/gccdepends.pro:
1525
1526 2012-03-16  Kihong Kwon  <kihong.kwon@samsung.com>
1527
1528         Support for Battery Status API
1529         https://bugs.webkit.org/show_bug.cgi?id=62698
1530
1531         Add include directory and file.
1532         http://www.w3.org/TR/battery-status/
1533
1534         Reviewed by Adam Barth.
1535
1536         * Scripts/build-webkit:
1537
1538 2012-03-16  Kishore Bolisetty  <kbolisetty@innominds.com>
1539
1540         check-webkit-style fails on LayoutTests/platform/efl/test_expectations.txt
1541         https://bugs.webkit.org/show_bug.cgi?id=81007
1542
1543         Reviewed by Adam Barth.
1544
1545         A dedidcated build slave is available for efl on build.webkit.org. 
1546         This change add's an entry for the elf port in list of available port builders.
1547         This is required because test_expectations.py when triggered, looks for a valid port object for the specified port. 
1548
1549         * Scripts/webkitpy/layout_tests/port/builders.py:
1550
1551 2012-03-16  Adam Barth  <abarth@webkit.org>
1552
1553         [webkitpy] StatusServer.next_work_item has an incorrectly named local variable
1554         https://bugs.webkit.org/show_bug.cgi?id=81302
1555
1556         Reviewed by Eric Seidel.
1557
1558         This is a trivial patch, but the variable name turned up in a grep of
1559         webkitpy and looks like copy pasta.
1560
1561         * Scripts/webkitpy/common/net/statusserver.py:
1562         (StatusServer.next_work_item):
1563
1564 2012-03-16  Andrew Lo  <anlo@rim.com>
1565
1566         [BlackBerry] Enable PAGE_VISIBILITY_API
1567         https://bugs.webkit.org/show_bug.cgi?id=81257
1568
1569         Enable Page Visibility API for BlackBerry.
1570
1571         Reviewed by Rob Buis.
1572
1573         * Scripts/build-webkit:
1574
1575 2012-03-16  Zan Dobersek  <zandobersek@gmail.com>
1576
1577         [Gtk] Add computedStyleIncludingVisitedInfo to DumpRenderTreeSupport
1578         https://bugs.webkit.org/show_bug.cgi?id=81232
1579
1580         Reviewed by Philippe Normand.
1581
1582         Use the newly-added helper method in DumpRenderTreeSupportGtk.
1583
1584         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1585         (LayoutTestController::computedStyleIncludingVisitedInfo):
1586
1587 2012-03-15  Eric Seidel  <eric@webkit.org>
1588
1589         Move parse_bug_id into config/urls in preparation for re-use elsewhere.
1590         https://bugs.webkit.org/show_bug.cgi?id=81313
1591
1592         Reviewed by Adam Barth.
1593
1594         * Scripts/webkitpy/common/checkout/changelog.py:
1595         (parse_bug_id_from_changelog):
1596         * Scripts/webkitpy/common/config/urls.py:
1597         (parse_bug_id):
1598         * Scripts/webkitpy/common/config/urls_unittest.py: Copied from Tools/Scripts/webkitpy/common/config/urls.py.
1599         (URLsTest):
1600         (URLsTest.test_parse_bug_id):
1601         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1602         (test_parse_bug_id):
1603         * Scripts/webkitpy/tool/bot/irc_command.py:
1604         (_post_error_and_check_for_bug_url):
1605         * Scripts/webkitpy/tool/bot/sheriff.py:
1606         (Sheriff.post_rollout_patch):
1607         (Sheriff.post_chromium_deps_roll):
1608
1609 2012-03-15  Adam Barth  <abarth@webkit.org>
1610
1611         The commit-queue should fast-track patches that have already passed the testing EWS bots
1612         https://bugs.webkit.org/show_bug.cgi?id=81305
1613
1614         Reviewed by Eric Seidel.
1615
1616         If a patch has already passed the testing EWS bots (currently only the
1617         chromium-ews bot), we should be able to land the patch without running
1618         the tests again.  This patch is somewhat risky in that the tests might
1619         have been broken between when the EWS bots ran and when the
1620         commit-queue is processing the patch.  If that turns out to be a
1621         problem in practice, we'll tighten up this fast-track in some way,
1622         likely by making sure that the pass status is recent.
1623
1624         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1625         (CommitQueueTaskDelegate.did_pass_testing_ews):
1626         (CommitQueueTask._did_pass_tests_recently):
1627         (CommitQueueTask.run):
1628         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1629         (MockCommitQueue.did_pass_testing_ews):
1630         (test_fast_success_case):
1631         * Scripts/webkitpy/tool/commands/queues.py:
1632         (CommitQueue.did_pass_testing_ews):
1633         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1634         (test_did_pass_testing_ews):
1635
1636 2012-03-15  Kentaro Hara  <haraken@chromium.org>
1637
1638         [PerformanceTests] run-perf-tests should output correct units
1639         https://bugs.webkit.org/show_bug.cgi?id=78303
1640
1641         Reviewed by Ryosuke Niwa.
1642
1643         Previously run-perf-tests just supported "ms" for units.
1644         Consequently, Dromaeo perf tests had been reporting runs/s as "ms".
1645         This patch fixes run-perf-tests so that they can support custom units.
1646         The default unit is "ms".
1647
1648         The test result looks like this:
1649
1650         $ ./Tools/Scripts/run-perf-tests Dromaeo/dom-attr.html
1651         RESULT Dromaeo: dom-attr= 6465.9525483 runs/s
1652         median= 0.0 runs/s, stdev= 24.2983433436 runs/s, min= 6435.87649402 runs/s, max= 6515.63693392 runs/s
1653
1654         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1655         (PerfTestsRunner._process_parser_test_result):
1656
1657 2012-03-15  Brent Fulgham  <bfulgham@webkit.org>
1658
1659         [WinCairo] Unreviewed build change after wtf path changes.
1660
1661         * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Updated include
1662         directories to look at the private header directory to find 'wtf'.
1663
1664 2012-03-15  Kent Tamura  <tkent@chromium.org>
1665
1666         REGRESSION(r110595): webkit-patch suggest-reviewers doesn't work
1667         https://bugs.webkit.org/show_bug.cgi?id=81293
1668
1669         Reviewed by Adam Barth.
1670
1671         r110595 introduced new format of the author field of ChangeLog entry:
1672         "Adam Barth  <abarth@webkit.org> && Benjamin Poulain  <bpoulain@apple.com>"
1673         Updte chanelog.py to support it.
1674
1675         * Scripts/webkitpy/common/checkout/changelog.py:
1676         (ChangeLogEntry._split_contributor_names):
1677         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1678         (test_parse_authors):
1679
1680 2012-03-15  Lynn Neir  <lynn.neir@skype.net>
1681
1682         Implement LayoutTestController::setValueForUser on Windows https://bugs.webkit.org/show_bug.cgi?id=55834
1683
1684         Implemented setValueForUser in both DumpRenderTree and WebKitTestRunner.
1685
1686         Reviewed by Jessie Berlin.
1687
1688         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1689         (LayoutTestController::setValueForUser):
1690         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1691         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1692         (WTR::LayoutTestController::setValueForUser):
1693         (WTR):
1694         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1695         (LayoutTestController):
1696
1697 2012-03-15  Adam Barth  <abarth@webkit.org>
1698
1699         Update the start-queue.sh script to match what we're using on the bots
1700         https://bugs.webkit.org/show_bug.cgi?id=81277
1701
1702         Reviewed by Eric Seidel.
1703
1704         Over time we've added more magic git commands to clean up the local repo after
1705         it has been borked in various ways. The idea behind this sequence is to clear
1706         out any changes in the working copy and then to rebuild the master branch from
1707         origin/master.
1708
1709         This patch also removes the watchdog timer that we've stopped using on the
1710         bots.
1711
1712         This patch was reviewed on <https://github.com/eseidel/webkit/pull/1>.
1713         Note: Eric and I are experimenting with GitHub to see if it might be
1714         useful for WebKit.  If you have thoughts on this topic, please feel
1715         free to grab Eric or me on #webkit to chat.  I assume that he and I are
1716         the only ones who care about this file so using this alternative
1717         process for this patch shouldn't cause any trouble.
1718
1719         * EWSTools/start-queue.sh:
1720
1721 2012-03-15  Adam Barth  <abarth@webkit.org>
1722
1723         The commit-queue can hang when the test_expectations.txt style check fails during commit
1724         https://bugs.webkit.org/show_bug.cgi?id=81251
1725
1726         Reviewed by Eric Seidel.
1727
1728         We forgot to check the --non-interactive flag, so we end up prompting
1729         the "user" who doesn't exist on the bot.  We might consider teaching
1730         the User class about non-interactive if we have this sort of bug again.
1731
1732         * Scripts/webkitpy/tool/steps/commit.py:
1733         (Commit.options):
1734         (Commit._check_test_expectations):
1735         (Commit.run):
1736         * Scripts/webkitpy/tool/steps/commit_unittest.py:
1737         (CommitTest.test_check_test_expectations):
1738
1739 2012-03-15  Jessie Berlin  <jberlin@apple.com>
1740
1741         fast/dom/Window/window-properties.html and fast/dom/prototype-inheritance-2.html failing on
1742         Mac WK2 because WebAudio is not enabled
1743         https://bugs.webkit.org/show_bug.cgi?id=81259
1744
1745         Reviewed by Dan Bernstein.
1746
1747         Enable WebAudio so that it appears in the window object in the tests.
1748         The webaudio tests are all still skipped in the Mac Skipped list.
1749
1750         * WebKitTestRunner/TestController.cpp:
1751         (WTR::TestController::resetStateToConsistentValues):
1752
1753 2012-03-15  David Levin  <levin@chromium.org>
1754
1755         Various autoresize fixes.
1756         https://bugs.webkit.org/show_bug.cgi?id=81199
1757
1758         Reviewed by Darin Fisher.
1759
1760         * DumpRenderTree/chromium/LayoutTestController.cpp:
1761         (LayoutTestController::reset): Stop using the deprecated api that was removed.
1762
1763 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1764
1765         [GTK] Actually use --release and --debug command line options in run-gtk-test
1766         https://bugs.webkit.org/show_bug.cgi?id=81234
1767
1768         Reviewed by Philippe Normand.
1769
1770         Actually handle --release and --debug command line options to
1771         create the build directory, falling back to current hack to detect
1772         whether it's a Release or Debug build when both options are missed.
1773
1774         * Scripts/run-gtk-tests:
1775         (TestRunner.__init__): Receive options too.
1776         (TestRunner._get_top_level_directory): Helper function to get the
1777         top level directory.
1778         (TestRunner._get_build_directory): Helper function to get the
1779         build directory depending on --release/--debug command line
1780         options or gessing it if both options are missing.
1781         (TestRunner._ensure_accessibility_daemon_is_running): Use
1782         self-options now.
1783         (TestRunner.run): Ditto.
1784         (TestRunner.run.run_tests): Pass options to the constructor
1785         instead of run().
1786
1787 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1788
1789         [GTK] Run unit tests with --verbose in the bots
1790         https://bugs.webkit.org/show_bug.cgi?id=81230
1791
1792         Reviewed by Martin Robinson.
1793
1794         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1795         (RunGtkAPITests): Add --verbose to run-gtk-test command.
1796
1797 2012-03-15  Kevin Ollivier  <kevino@theolliviers.com>
1798
1799         Move wx port to using export macros
1800         https://bugs.webkit.org/show_bug.cgi?id=77279
1801
1802         Reviewed by Hajime Morita.
1803
1804         * waf/build/settings.py:
1805         (common_configure):
1806
1807 2012-03-15  Philippe Normand  <pnormand@igalia.com>
1808
1809         Unreviewed, GTK build fix attempt after r110845.
1810
1811         * Scripts/run-gtk-tests: Added --release and --debug options.
1812
1813 2012-03-15  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
1814
1815         Parametrize run-with-jhbuild and update-webkitgtk-libs with platform --gtk/--efl
1816         https://bugs.webkit.org/show_bug.cgi?id=79673
1817
1818         Preparatory work for bringing jhbuild enabled build to EFL port.
1819
1820         Reviewed by Philippe Normand.
1821
1822         * Scripts/update-webkit-libs-jhbuild: Copied from Tools/Scripts/update-webkitgtk-libs.
1823         * Scripts/update-webkitgtk-libs:
1824         * gtk/run-with-jhbuild:
1825         * jhbuild/jhbuild-wrapper: Copied from Tools/gtk/run-with-jhbuild.
1826         (top_level_path):
1827         (jhbuild_installed):
1828         (jhbuild_cloned):
1829         (jhbuild_at_expected_revision):
1830         (update_jhbuild):
1831         (clone_jhbuild):
1832         (install_jhbuild):
1833         (update_webkit_libs_jhbuild):
1834         (determine_platform):
1835         (ensure_jhbuild):
1836
1837 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1838
1839         [GTK] Add command line options to run-gtk-tests script
1840         https://bugs.webkit.org/show_bug.cgi?id=81218
1841
1842         Reviewed by Philippe Normand.
1843
1844         Following command line options have been added:
1845
1846         -v, --verbose: to run gtester with --verbose. That would be used
1847         by the bots to make it easier to know which test case it failing.
1848
1849         --display: to use a different display for Xvfb
1850
1851         It's also possible to pass one or more tests as arguments.
1852
1853         * Scripts/run-gtk-tests:
1854         (TestRunner.__init__): Receive command line arguments.
1855         (TestRunner._get_tests): Get all the tests or the ones passed by
1856         command line arguments.
1857         (TestRunner._ensure_accessibility_daemon_is_running): Use display
1858         command line argument.
1859         (TestRunner.run): Pas command line options.
1860         (TestRunner.run.run_tests): Pass command line arguments.
1861
1862 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1863
1864         [GTK] WebKit2APITests/TestPrinting timeout in the bots
1865         https://bugs.webkit.org/show_bug.cgi?id=81211
1866
1867         Reviewed by Philippe Normand.
1868
1869         Add gtk+ patch to fix timeout in the bots. A similar patch has
1870         already landed in updatream gtk+, see
1871         http://git.gnome.org/browse/gtk+/commit/?id=5ebfad5d091f4c9d9c6e60364fad4c60842f027f
1872
1873         * gtk/jhbuild.modules:
1874         * gtk/patches/gtk+-3.0.12-gtkprinter.patch: Added.
1875
1876 2012-03-14  Gustavo Noronha Silva  <gns@gnome.org>
1877
1878         sheriffbot should also be addressable with a comma in addition to colon
1879         https://bugs.webkit.org/show_bug.cgi?id=81101
1880
1881         Reviewed by Adam Barth.
1882
1883         * Scripts/webkitpy/common/net/irc/ircbot.py:
1884         (IRCBot.on_pubmsg):
1885
1886 2012-03-15  Alexander Færøy  <alexander.faeroy@nokia.com>
1887
1888         [Qt] MiniBrowser scroll indicators should not scroll out of view
1889         https://bugs.webkit.org/show_bug.cgi?id=81131
1890
1891         Reviewed by Kenneth Rohde Christiansen.
1892
1893         * MiniBrowser/qt/qml/ScrollIndicator.qml:
1894
1895 2012-03-14  Chris Fleizach  <cfleizach@apple.com>
1896
1897         AX: ARIA tables need to support selected rows attribute/select rows changed notification
1898         https://bugs.webkit.org/show_bug.cgi?id=79821
1899
1900         Reviewed by Beth Dakin.
1901
1902         * DumpRenderTree/AccessibilityUIElement.cpp:
1903         (rowAtIndexCallback):
1904         (AccessibilityUIElement::getJSClass):
1905         * DumpRenderTree/AccessibilityUIElement.h:
1906         (AccessibilityUIElement):
1907         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1908         (AccessibilityUIElement::rowAtIndex):
1909         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1910         (AccessibilityUIElement::rowAtIndex):
1911         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1912         (AccessibilityUIElement::rowAtIndex):
1913         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1914         (AccessibilityUIElement::rowAtIndex):
1915
1916 2012-03-14  Tim Horton  <timothy_horton@apple.com>
1917
1918         NRWT should respect --additional-platform-directory's Skipped list
1919         https://bugs.webkit.org/show_bug.cgi?id=81172
1920
1921         Reviewed by Timothy Hatcher.
1922
1923         Respect the Skipped file inside all paths included via the --additional-platform-directory option. Test results
1924         from said path are already used, but the Skipped file is ignored.
1925
1926         * Scripts/webkitpy/layout_tests/port/webkit.py:
1927         (WebKitPort._skipped_file_search_paths):
1928         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1929         (test_skipped_file_search_paths):
1930
1931 2012-03-14  Ojan Vafai  <ojan@chromium.org>
1932
1933         Unreviewed, rolling out r110783.
1934         http://trac.webkit.org/changeset/110783
1935         https://bugs.webkit.org/show_bug.cgi?id=81054
1936
1937         Caused existing test expectation lines to expand to one for
1938         each test configuration.
1939
1940         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1941         (TestExpectations.has_warnings):
1942         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1943         (test_macro_overrides):
1944         * Scripts/webkitpy/tool/commands/rebaseline.py:
1945         (RebaselineTest._save_baseline):
1946         (RebaselineTest._rebaseline_test):
1947         (RebaselineTest.execute):
1948         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1949         (TestRebaseline.test_tests_to_update):
1950
1951 2012-03-13  Jon Lee  <jonlee@apple.com>
1952
1953         Separate NOTIFICATIONS and LEGACY_NOTIFICATIONS
1954         https://bugs.webkit.org/show_bug.cgi?id=80922
1955         <rdar://problem/11035082>
1956
1957         Reviewed by Jian Li.
1958
1959         You can include either NOTIFICATIONS or LEGACY_NOTIFICATIONS and have a complete API.
1960         LEGACY_NOTIFICATIONS should cover all of the previous functionality, and NOTIFICATIONS will cover the
1961         new API. Therefore, APIs that are common between the two will have:
1962         #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
1963
1964         This patch initially sets both to be exactly the same. As other bugs with patches begin to migrate to
1965         the new API, the defines will begin to split. This allows ports to decide which set of APIs to include.
1966
1967         Update everything to be #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
1968         * DumpRenderTree/chromium/LayoutTestController.cpp:
1969         (LayoutTestController::grantDesktopNotificationPermission):
1970         (LayoutTestController::simulateDesktopNotificationClick):
1971         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1972         * DumpRenderTree/chromium/TestShell.cpp:
1973         (TestShell::TestShell):
1974         (TestShell::resetTestController):
1975         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1976         (DRTDesktopNotificationPresenter::checkNotificationPermission):
1977
1978 2012-03-13  Ojan Vafai  <ojan@chromium.org>
1979
1980         Have webkit-patch rebaseline-test update test_expectations.txt
1981         https://bugs.webkit.org/show_bug.cgi?id=81054
1982
1983         Reviewed by Dirk Pranke.
1984
1985         This will allow us to use the All Failures tab in garden-o-matic
1986         to rebaseline tests without making test_expectations.txt stale.
1987
1988         It's conservative and only removes lines if the test is
1989         not flaky and fails in a way the rebaseline would fix (e.g.
1990         CRASH/TIMEOUT will not be touched).
1991
1992         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1993         (TestExpectations.remove_configuration_from_test):
1994         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1995         (RemoveConfigurationsTest):
1996         (RemoveConfigurationsTest.test_remove):
1997         (test_remove_line):
1998         * Scripts/webkitpy/tool/commands/rebaseline.py:
1999         (RebaselineTest._is_supported_port):
2000         (RebaselineTest):
2001         (RebaselineTest._update_expectations_file):
2002         (RebaselineTest._rebaseline_test_and_update_expectations):
2003         (RebaselineTest.execute):
2004         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2005         (TestRebaseline.test_rebaseline_updates_expectations_file):
2006
2007 2012-03-14  Jessie Berlin  <jberlin@apple.com>
2008
2009         Crash in WKTR under addChromeInputField due to using 0 as a key in a HashMap
2010         https://bugs.webkit.org/show_bug.cgi?id=81167
2011
2012         Reviewed by Sam Weinig.
2013
2014         Do not use 0 as a key in a HashMap.
2015
2016         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2017         cacheLayoutTestControllerCallback uses the enum as keys for the callback map.
2018
2019 2012-03-14  Ojan Vafai  <ojan@chromium.org>
2020
2021         Add the chromium lion bot to garden-o-matic and remove
2022         the platform_move_to in builders.py since the Chromium Lion
2023         port is now a normal port.
2024
2025         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2026         * Scripts/webkitpy/layout_tests/port/builders.py:
2027
2028 2012-03-14  Dirk Pranke  <dpranke@chromium.org>
2029
2030         Fix regression/crash introduced in r110724 - bad type passed from skipped_tests() by default.
2031
2032         Unreviewed, build fix.
2033
2034         * Scripts/webkitpy/layout_tests/port/base.py:
2035         (Port.skipped_tests):
2036
2037 2012-03-14  Dirk Pranke  <dpranke@chromium.org>
2038
2039         Please add a way to manually skip some tests in NRWT
2040         https://bugs.webkit.org/show_bug.cgi?id=81019
2041
2042         Reviewed by Ojan Vafai.
2043
2044         This patch implements the -i / --ignore-tests flag from ORWT
2045         and refactors the test_expectations.py code slightly to handle
2046         it.
2047
2048         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2049         (Manager.parse_expectations):
2050         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2051         (TestExpectations.__init__):
2052         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2053         (test_add_skipped_tests):
2054         (test_add_skipped_tests_duplicate):
2055         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2056         (parse_args):
2057         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2058         (MainTest.test_ignore_tests):
2059         (MainTest.test_ignore_tests.assert_ignored):
2060
2061 2012-03-14  Dirk Pranke  <dpranke@chromium.org>
2062
2063         nrwt: run with no args on lion, is putting baselines in platform/mac-lion, not platform/mac
2064         https://bugs.webkit.org/show_bug.cgi?id=81028
2065
2066         Reviewed by Ojan Vafai.
2067
2068         The mac port had incorrect lookups for 'mac-lion' and
2069         'mac-future' in some places. This patch fixes that and adds a
2070         bunch of tests.
2071
2072         * Scripts/webkitpy/layout_tests/port/mac.py:
2073         (MacPort.baseline_path):
2074         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2075         (MacTest.assert_skipped_file_search_paths):
2076         (MacTest.test_skipped_file_search_paths):
2077         (_assert_search_path):
2078         (test_baseline_search_path):
2079         * Scripts/webkitpy/layout_tests/port/webkit.py:
2080         (WebKitPort._skipped_file_search_paths):
2081
2082 2012-03-13  Jer Noble  <jer.noble@apple.com>
2083
2084         Lion Intel Debug WebKit2 Tests crashing under [WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]
2085         https://bugs.webkit.org/show_bug.cgi?id=81056
2086
2087         Reviewed by Jessie Berlin.
2088
2089         Intercept beganEnterFullScreen and beganExitFullScreen and turn them into no-ops (plus logging).
2090
2091         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2092         (WTR::InjectedBundlePage::InjectedBundlePage):
2093         (WTR::InjectedBundlePage::beganEnterFullScreen):
2094         (WTR::InjectedBundlePage::beganExitFullScreen):
2095
2096 2012-03-14  Alexander Færøy  <alexander.faeroy@nokia.com>
2097
2098         The width and height of the scroll indicators in the MiniBrowser does
2099         not consider the offset margins.
2100         https://bugs.webkit.org/show_bug.cgi?id=81112
2101
2102         Reviewed by Kenneth Rohde Christiansen.
2103
2104         This patch fixes the issue by withdrawing two times the anchor
2105         margins.
2106
2107         * MiniBrowser/qt/qml/ScrollIndicator.qml:
2108
2109 2012-03-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2110
2111         [EFL] Implement LayoutTestController::clearBackForwardList
2112         https://bugs.webkit.org/show_bug.cgi?id=80142
2113
2114         Adding missing implementation clearBackForwardList to EFL's
2115         LayoutTestController. This implementation allows us to unskip 
2116         tests connected with history.
2117
2118         Reviewed by Antonio Gomes.
2119
2120         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2121         (LayoutTestController::clearBackForwardList): Implemented.
2122
2123 2012-03-13  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2124
2125         [EFL][DRT] Expose window.internals object
2126         https://bugs.webkit.org/show_bug.cgi?id=79900
2127
2128         Exposes window.internals for EFL's DRT. Makes possible to
2129         remove some tests from the skip list.
2130
2131         Reviewed by Antonio Gomes.
2132
2133         * DumpRenderTree/efl/CMakeLists.txt:
2134         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2135         (DumpRenderTreeChrome::onWindowObjectCleared):
2136
2137 2012-03-13  Adam Barth  <abarth@webkit.org> && Benjamin Poulain  <bpoulain@apple.com>
2138
2139         Always enable ENABLE(CLIENT_BASED_GEOLOCATION)
2140         https://bugs.webkit.org/show_bug.cgi?id=78853
2141
2142         Reviewed by Adam Barth.
2143
2144         * Scripts/build-webkit:
2145         * qmake/mkspecs/features/features.prf:
2146
2147 2012-03-12  Antonio Gomes  <agomes@rim.com>
2148
2149         Convert nodesFromRect tests to use Internals interface
2150         https://bugs.webkit.org/show_bug.cgi?id=80886
2151
2152         Reviewed by Ryosuke Niwa.
2153
2154         This clean up allows to remove port specific bits of each
2155         DRT implementation that supports testing Document::nodesFromRect,
2156         in favor of making use of the 'Internals' interface to test it.
2157
2158         This makes its code conveniently more expansible and cleaner.
2159
2160         Also removed stubs from Win and EFL DRTs.
2161
2162         * DumpRenderTree/LayoutTestController.cpp:
2163         (LayoutTestController::staticFunctions):
2164         * DumpRenderTree/LayoutTestController.h:
2165         (LayoutTestController):
2166         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2167         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2168         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2169         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2170         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2171         (LayoutTestController):
2172         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2173
2174 2012-03-13  Ojan Vafai  <ojan@chromium.org>
2175
2176         Rebaselining for a new port doesn't work right with multiple fallback ports
2177         https://bugs.webkit.org/show_bug.cgi?id=80932
2178
2179         Reviewed by Adam Barth.
2180
2181         Since chromium-leopard also falls back to mac-leopard, we need to
2182         copy the existing result for both chromium-leopard and chromium-snowleopard
2183         before doing lion rebaselines.
2184
2185         * Scripts/webkitpy/layout_tests/port/builders.py:
2186         (fallback_port_names_for_new_port):
2187         * Scripts/webkitpy/tool/commands/rebaseline.py:
2188         (RebaselineTest):
2189         (RebaselineTest._copy_existing_baseline):
2190         (RebaselineTest._rebaseline_test):
2191         (RebaselineTest.execute):
2192         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2193         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2194         (GardeningHTTPRequestHandler.rebaseline):
2195         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2196         (GardeningServerTest.test_rebaseline_new_port):
2197
2198 2012-03-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2199
2200         [Qt] Tweak minibrowser UI
2201
2202         Add some margins to the scroll indicators, and set a dark background
2203         color so you see the page dimensions.
2204
2205         Reviewed by Antonio Gomes.
2206
2207         * MiniBrowser/qt/qml/BrowserWindow.qml:
2208         * MiniBrowser/qt/qml/ScrollIndicator.qml:
2209
2210 2012-03-13  ChangSeok Oh  <shivamidow@gmail.com>
2211
2212         [EFL] [DRT] Implement scheduleAsynchronousKeyDown.
2213         https://bugs.webkit.org/show_bug.cgi?id=79601
2214
2215         Reviewed by Gustavo Noronha Silva.
2216
2217         Extracted shareable code from keyDownCallback and then added createKeyEventInfo.
2218         createKeyEventInfo creates a new structure KeyEventInfo that has keyName and modifiers
2219         and is taken over to sendKeyDown.
2220         Added sendKeyDown and sendAsynchronousKeyDown to evaluate keyDown event directly
2221         and asynchronously. Eventually, sendAsynchronousKeyDown calls sendKeyDown.
2222
2223         * DumpRenderTree/efl/EventSender.cpp:
2224         (KeyEventInfo::KeyEventInfo):
2225         (KeyEventInfo):
2226         (createKeyEventInfo):
2227         (sendKeyDown):
2228         (keyDownCallback):
2229         (sendAsynchronousKeyDown):
2230         (scheduleAsynchronousKeyDownCallback):
2231
2232 2012-03-12  Ojan Vafai  <ojan@chromium.org>
2233
2234         webkit-patch optimize-baselines sometimes creates a mac-future result
2235         https://bugs.webkit.org/show_bug.cgi?id=80717
2236
2237         Reviewed by Adam Barth.
2238
2239         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
2240         (_baseline_search_hypergraph):
2241         (BaselineOptimizer._find_optimal_result_placement):
2242         (BaselineOptimizer._filter_virtual_ports):
2243         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
2244         (BaselineOptimizerTest.test_no_add_mac_future):
2245
2246 2012-03-12  Jessie Berlin  <jberlin@apple.com>
2247
2248         More Windows build fixing.
2249
2250         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2251
2252 2012-03-12  Jessie Berlin  <jberlin@apple.com>
2253
2254         More Windows build fixing.
2255
2256         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2257         * DumpRenderTree/win/EditingDelegate.cpp:
2258         * DumpRenderTree/win/EventSender.cpp:
2259         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2260         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2261         * DumpRenderTree/win/UIDelegate.cpp:
2262
2263 2012-03-12  Dirk Pranke  <dpranke@chromium.org>
2264
2265         remove the 'gpu' group from the flakiness dashboard
2266         https://bugs.webkit.org/show_bug.cgi?id=80353
2267
2268         Reviewed by Adam Barth.
2269
2270         Since those bots are obsolete, we don't need this any more.
2271
2272         * TestResultServer/static-dashboards/builders.js:
2273         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2274         (testPlatformAndBuildType):
2275         (testHtmlForTestTypeSwitcherGroup):
2276
2277 2012-03-12  Dirk Pranke  <dpranke@chromium.org>
2278
2279         remove graphics_type from webkitpy.layout_tests.models.test_configuration
2280         https://bugs.webkit.org/show_bug.cgi?id=80643
2281
2282         Reviewed by Ojan Vafai.
2283
2284         Now that the chromium-gpu ports are gone, there's no need for
2285         the graphics_type CPU/GPU distinction. Most of this change is
2286         just updating tests accordingly.
2287
2288         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
2289         (TestExpectationEditorTests):
2290         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
2291         (TestConfiguration.__init__):
2292         (TestConfiguration.category_order):
2293         (TestConfiguration.__str__):
2294         (TestConfiguration.__repr__):
2295         (TestConfiguration.__hash__):
2296         (TestConfigurationConverter.to_specifiers_list):
2297         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
2298         (make_mock_all_test_configurations_set):
2299         (TestConfigurationTest.test_items):
2300         (TestConfigurationTest.test_keys):
2301         (TestConfigurationTest.test_str):
2302         (TestConfigurationTest.test_repr):
2303         (TestConfigurationTest.test_hash):
2304         (TestConfigurationTest.test_hash.query_unknown_key):
2305         (TestConfigurationTest.test_eq):
2306         (TestConfigurationTest.test_values):
2307         (SpecifierSorterTest.test_specifier_priority):
2308         (SpecifierSorterTest.test_sort_specifiers):
2309         (TestConfigurationConverterTest.test_to_config_set):
2310         (TestConfigurationConverterTest.test_macro_expansion):
2311         (TestConfigurationConverterTest.test_to_specifier_lists):
2312         (TestConfigurationConverterTest.test_converter_macro_collapsing):
2313         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2314         (test_error_on_different_build_type):
2315         (TestExpectationSerializerTests.test_parsed_to_string):
2316         (TestExpectationSerializerTests.test_reconstitute_only_these):
2317         * Scripts/webkitpy/layout_tests/port/apple.py:
2318         (ApplePort._generate_all_test_configurations):
2319         * Scripts/webkitpy/layout_tests/port/base.py:
2320         (Port.__init__):
2321         (Port.name):
2322         (Port.version):
2323         (Port.test_configuration):
2324         * Scripts/webkitpy/layout_tests/port/builders.py:
2325         * Scripts/webkitpy/layout_tests/port/chromium.py:
2326         (ChromiumPort):
2327         (ChromiumPort._generate_all_test_configurations):
2328         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2329         (ChromiumLinuxPort.__init__):
2330         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2331         (ChromiumLinuxPortTest.test_check_illegal_port_names):
2332         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2333         (ChromiumMacPortTest.test_baseline_path):
2334         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2335         (ChromiumPortTest.test_all_test_configurations):
2336         * Scripts/webkitpy/layout_tests/port/efl.py:
2337         (EflPort._generate_all_test_configurations):
2338         * Scripts/webkitpy/layout_tests/port/gtk.py:
2339         (GtkPort._generate_all_test_configurations):
2340         * Scripts/webkitpy/layout_tests/port/qt.py:
2341         (QtPort._generate_all_test_configurations):
2342         * Scripts/webkitpy/layout_tests/port/test.py:
2343         (TestPort.all_test_configurations):
2344         (TestPort._all_build_types):
2345         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2346         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2347         (BuildCoverageExtrapolatorTest.test_extrapolate):
2348         (GardeningExpectationsUpdaterTest.test_unknown_failure_type):
2349         (GardeningExpectationsUpdaterTest.test_add_new_expectation):
2350         (GardeningExpectationsUpdaterTest.test_replace_old_expectation):
2351         (GardeningExpectationsUpdaterTest.test_pass_expectation):
2352         (GardeningExpectationsUpdaterTest.test_supplement_old_expectation):
2353         (GardeningExpectationsUpdaterTest.test_spurious_updates):
2354
2355 2012-03-12  Dirk Pranke  <dpranke@chromium.org>
2356
2357         _runtime_feature_list isn't supported on Apple Mac DRT
2358         https://bugs.webkit.org/show_bug.cgi?id=80906
2359
2360         Reviewed by Eric Seidel.
2361
2362         It looks like this feature is actually only supported on the Win
2363         DRT port, so this patch reworks the code to make that clearer
2364         and reduce unnecessary overrides.
2365
2366         * Scripts/webkitpy/layout_tests/port/efl.py:
2367         (EflPort._path_to_webcore_library):
2368         * Scripts/webkitpy/layout_tests/port/gtk.py:
2369         (GtkPort._path_to_webcore_library):
2370         * Scripts/webkitpy/layout_tests/port/qt.py:
2371         (QtPort._skipped_file_search_paths):
2372         * Scripts/webkitpy/layout_tests/port/webkit.py:
2373         (WebKitPort._runtime_feature_list):
2374         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2375         (TestWebKitPort.__init__):
2376         (TestWebKitPort.all_test_configurations):
2377         (test_skipped_directories_for_features):
2378         * Scripts/webkitpy/layout_tests/port/win.py:
2379         (WinPort):
2380         (WinPort._runtime_feature_list):
2381         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2382         (WinPortTest.test_operating_system):
2383         (WinPortTest):
2384         (WinPortTest.test_runtime_feature_list):
2385
2386 2012-03-12  Peter Beverloo  <peter@chromium.org>
2387
2388         [Chromium] Temporary build-fix for the Android bot
2389         https://bugs.webkit.org/show_bug.cgi?id=80862
2390
2391         Reviewed by Adam Barth.
2392
2393         Manually set the environmental variables required to compile source
2394         files through the Android NDK instead of relying on the envsetup.sh
2395         script. A proper fix will be landed to Chromium ASAP, and following
2396         a Chromium roll into WebKit this code will be removed.
2397
2398         * Scripts/webkitdirs.pm:
2399         (buildChromiumMakefile):
2400
2401 2012-03-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2402
2403         [Qt] Use right construct to detect config_test_gccdepends
2404
2405         Reviewed by Andreas Kling.
2406
2407         * qmake/mkspecs/features/default_pre.prf:
2408
2409 2012-03-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2410
2411         [Qt] Expose location of WebKit's bin and imports dir through module file
2412
2413         Reviewed by Andreas Kling.
2414
2415         * qmake/qt_webkit.pri:
2416
2417 2012-03-12  Andras Becsi  <andras.becsi@nokia.com>
2418
2419         [Qt][WK2] Add support for rudimentary scroll indicators in MiniBrowser
2420         https://bugs.webkit.org/show_bug.cgi?id=80832
2421
2422         Reviewed by Tor Arne Vestbø.
2423
2424         Add a basic scroll indicator component to MiniBrowser so that it
2425         behaves similar to the ScrollDecorator QML component.
2426
2427         * MiniBrowser/qt/MiniBrowser.qrc:
2428         * MiniBrowser/qt/qml/BrowserWindow.qml:
2429         * MiniBrowser/qt/qml/ScrollIndicator.qml: Added.
2430
2431 2012-03-12  C Anthony Risinger  <anthony@xtfx.me>
2432
2433         [GTK] r110296 included an extra $ in @$(AM_V_GEN)
2434         https://bugs.webkit.org/show_bug.cgi?id=80809
2435
2436         Reviewed by Philippe Normand.
2437
2438         * GNUmakefile.am: Add `$` to @(AM_V_GEN), else /bin/sh syntax error
2439
2440 2012-03-12  Ming Xie  <mxie@rim.com>
2441
2442         [BlackBerry] build-webkit doesn't recognize "--cmakearg" for the BlackBerry port
2443         https://bugs.webkit.org/show_bug.cgi?id=80812
2444
2445         Reviewed by Rob Buis.
2446
2447         * Scripts/build-webkit: Add $cmakeArgs to buildCMakeProjectOrExit()
2448         * Scripts/webkitdirs.pm:
2449         (blackberryCMakeArguments): Remove "PUBLIC_BUILD=0" define
2450
2451
2452 2012-03-12  Simon Hausmann  <simon.hausmann@nokia.com>
2453
2454         [Qt] Fix build with newer Qt 5.
2455
2456         Reviewed by Tor Arne Vestbø.
2457
2458         Newer Qt 5 renames QDeclarativeFoo to QQmlFoo and provides backwards compatible
2459         renames, which however do trigger a #warning. Until we _require_ a newer Qt 5
2460         we should disable -Werror.
2461
2462         Also load(moc) for the availability of QMAKE_MOC in various derived sources. The
2463         implicit load was removed recently.
2464
2465         * qmake/mkspecs/features/default_pre.prf:
2466         * qmake/mkspecs/features/unix/default_post.prf:
2467
2468 2012-03-11  Maciej Stachowiak  <mjs@apple.com>
2469
2470         Add --instruments option to sunspider to profile with Instruments
2471         https://bugs.webkit.org/show_bug.cgi?id=80783
2472
2473         Reviewed by Filip Pizlo.
2474
2475         * Scripts/run-sunspider:
2476
2477 2012-03-11  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
2478
2479         [Qt] [WK2] Support threaded renderer in WK2
2480         https://bugs.webkit.org/show_bug.cgi?id=76661
2481
2482         Remove disabling of threaded rendering.
2483
2484         Reviewed by Noam Rosenthal.
2485
2486         * MiniBrowser/qt/main.cpp:
2487         (main):
2488
2489 2012-03-09  Zan Dobersek  <zandobersek@gmail.com>
2490
2491         [WK2] run-perf-tests should be able to run with WTR
2492         https://bugs.webkit.org/show_bug.cgi?id=80042
2493
2494         Reviewed by Martin Robinson.
2495
2496         Add an option to PerfTestRunner to use WebKitTestRunner instead of
2497         DumpRenderTree and add the '--no-timeout' flag to WebKitTestRunner
2498         to avoid timing out when running performance tests.
2499
2500         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2501         (PerfTestsRunner._parse_args):
2502         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2503         (WTR::InjectedBundle::InjectedBundle): Initialize m_useWaitToDumpWatchdogTimer
2504         to true.
2505         (WTR::InjectedBundle::didReceiveMessage): Unpack the 'BeginTest' message
2506         as a dictionary containing DumpPixels and UseWaitToDumpWatchdogTimer keys.
2507         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2508         (WTR::InjectedBundle::useWaitToDumpWatchdogTimer): Make m_useWaitToDumpWatchdogTimer
2509         publicly accessible.
2510         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2511         (WTR::LayoutTestController::waitUntilDone): Only initialize the watchdog if it
2512         is required.
2513         * WebKitTestRunner/TestController.cpp:
2514         (WTR::TestController::TestController): Initialize m_useWaitToDumpWatchdogTimer
2515         to true.
2516         (WTR::TestController::initialize): Set m_useWaitToDumpWatchdogTimer to false
2517         if '--no-timeout' option is present.
2518         (WTR::TestController::runUntil): Translate TimeoutDuration to a proper timeout
2519         value, or -1.0 if timeout should not occur.
2520         * WebKitTestRunner/TestController.h:
2521         (WTR::TestController::useWaitToDumpWatchdogTimer): Make m_useWaitToDumpWatchdogTimer
2522         publicly accessible.
2523         * WebKitTestRunner/TestInvocation.cpp:
2524         (WTR::TestInvocation::invoke): Pack the 'BeginTest' message as a dictionary,
2525         containing DumpPixels and UseWaitToDumpWatchdogTimer keys and corresponding values.
2526         Waiting for final message should not time out if not necessary.
2527         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2528         (WTR::TestController::platformRunUntil): Only set up a timeout if necessary.
2529         * WebKitTestRunner/qt/TestControllerQt.cpp:
2530         (WTR::TestController::platformRunUntil): Ditto.
2531         * WebKitTestRunner/mac/TestControllerMac.mm:
2532         (WTR::TestController::platformRunUntil): Add a FIXME, indicating functionality
2533         is missing.
2534         * WebKitTestRunner/win/TestControllerWin.cpp:
2535         (WTR::TestController::platformRunUntil): Ditto.
2536
2537 2012-03-09  Jon Lee  <jonlee@apple.com>
2538
2539         Rename NotificationPresenter to NotificationClient
2540         https://bugs.webkit.org/show_bug.cgi?id=80488
2541         <rdar://problem/10965558>
2542
2543         Reviewed by Kentaro Hara.
2544
2545         Refactor to use renamed WebCore::NotificationClient.
2546         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2547         (DRTDesktopNotificationPresenter::checkNotificationPermission):
2548
2549 2012-03-07  James Robinson  <jamesr@chromium.org>
2550
2551         [chromium] Deprecate renderDirectlyToWebView parameter of WebViewClient::createGraphicsContext3D()
2552         https://bugs.webkit.org/show_bug.cgi?id=80523
2553
2554         Reviewed by Darin Fisher.
2555
2556         * DumpRenderTree/chromium/WebViewHost.cpp:
2557         (WebViewHost::createGraphicsContext3D):
2558         * DumpRenderTree/chromium/WebViewHost.h:
2559         (WebViewHost):
2560
2561 2012-03-09  Eric Seidel  <eric@webkit.org>
2562
2563         build-webkit should build Source/WTF on Mac
2564         https://bugs.webkit.org/show_bug.cgi?id=80728
2565
2566         Reviewed by Adam Barth.
2567
2568         We'll add other ports to this list in future commits.
2569
2570         * Scripts/build-webkit:
2571
2572 2012-03-09  Jon Lee  <jonlee@apple.com>
2573
2574         Add support for ENABLE(LEGACY_NOTIFICATIONS)
2575         https://bugs.webkit.org/show_bug.cgi?id=80497
2576
2577         Reviewed by Adam Barth.
2578
2579         Prep for b80472: Update API for Web Notifications
2580         * Scripts/build-webkit:
2581         * qmake/mkspecs/features/features.prf:
2582
2583 2012-03-09  Ashod Nakashian  <ashodnakashian@yahoo.com>
2584
2585         Bash scripts should support LF endings only
2586         https://bugs.webkit.org/show_bug.cgi?id=79509
2587
2588         Reviewed by David Kilzer.
2589
2590         * EWSTools/boot.sh: Added properties svn:executable and svn:eol-style.
2591         * EWSTools/start-queue.sh: Added property svn:eol-style.
2592         * Scripts/webkit-tools-completion.sh: Added properties svn:executable and svn:eol-style.
2593         * WebKitTestRunner/win/build-generated-files.sh: Added properties svn:executable and svn:eol-style.
2594         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added property svn:eol-style.
2595         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added property svn:eol-style.
2596
2597 2012-03-09  Ionut Biru  <ibiru@archlinux.org>
2598
2599         [BUILD] use detected python to run generate-gtkdoc
2600         https://bugs.webkit.org/show_bug.cgi?id=80695
2601
2602         Reviewed by Gustavo Noronha Silva.
2603
2604         * GNUmakefile.am: Use $(PYTHON) instead of plain `python`
2605
2606 2012-03-09  Nat Duca  <nduca@chromium.org>
2607
2608         Make check-webkit-style complain about "no new tests" lines in changelogs
2609         https://bugs.webkit.org/show_bug.cgi?id=80582
2610
2611         Reviewed by David Levin.
2612
2613         * Scripts/webkitpy/style/checkers/changelog.py:
2614         (ChangeLogChecker.check_entry):
2615         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
2616         (ChangeLogCheckerTest.test_no_new_tests):
2617
2618 2012-03-09  Sheriff Bot  <webkit.review.bot@gmail.com>
2619
2620         Unreviewed, rolling out r110250.
2621         http://trac.webkit.org/changeset/110250
2622         https://bugs.webkit.org/show_bug.cgi?id=80682
2623
2624         It made NRWT ignore test_expectations.txt on Qt-WK2 and ignore
2625         qt-linux at all. (Requested by Ossy on #webkit).
2626
2627         * Scripts/old-run-webkit-tests:
2628         * Scripts/webkitpy/layout_tests/port/qt.py:
2629         (QtPort):
2630         (QtPort.determine_full_port_name):
2631         (QtPort.baseline_search_path):
2632         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2633         (QtPortTest):
2634         (QtPortTest._assert_search_path):
2635         (QtPortTest.test_baseline_search_path):
2636
2637 2012-03-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2638
2639         [Qt] Use Qt's module system for install rules and depending on QtWebKit
2640
2641         Instead of rolling our own install rules we now use the same approach as
2642         every other Qt module, by loading qt_module.prf and qt_module_config.prf.
2643
2644         This ensures that we follow the same semantics as the rest of Qt on
2645         what sort of config options are enabled by default (create_cmake eg.).
2646         It also allows us to use QT += webkit instead of the workaround we had
2647         with CONFIG += qtwebkit.
2648
2649         We do however force Qt to always treat our build as a non-developer build,
2650         so the libraries will end up in the WebKit lib directory instead of the
2651         qtbase directory (as with a normal developer-build). This allows us to
2652         keep the webkit-build self-contained. If Qt is a developer build we still
2653         copy the module file manually to Qt, so that you don't have to install
2654         WebKit to make it available.
2655
2656         For non-developer builds of Qt, it is still possible to use the built
2657         WebKit libraries without having to install them, by having the variable
2658         QMAKE_EXTRA_MODULE_FORWARDS set in the project's .qmake.cache file,
2659         pointing to $WEBKITOUTUTDIR/$CONFIGURATION/modules.
2660
2661         https://bugs.webkit.org/show_bug.cgi?id=80590
2662
2663         Reviewed by Simon Hausmann.
2664
2665         * DumpRenderTree/qt/DumpRenderTree.pro:
2666         * MiniBrowser/qt/BrowserWindow.cpp:
2667         * MiniBrowser/qt/MiniBrowser.pro:
2668         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2669         * MiniBrowser/qt/UrlLoader.cpp:
2670         * QtTestBrowser/QtTestBrowser.pro:
2671         * Tools.pro:
2672         * WebKitTestRunner/InjectedBundle/Target.pri:
2673         * WebKitTestRunner/Target.pri:
2674         * qmake/mkspecs/features/default_post.prf:
2675         * qmake/mkspecs/features/default_pre.prf:
2676         * qmake/mkspecs/features/functions.prf:
2677         * qmake/mkspecs/features/qtwebkit-private.prf: Removed.
2678         * qmake/mkspecs/features/qtwebkit.prf:
2679         * qmake/mkspecs/features/rpath.prf:
2680         * qmake/mkspecs/modules/qt_webkit.pri: Removed.
2681         * qmake/qt_webkit.pri: Added.
2682
2683 2012-03-08  Igor Oliveira  <igor.o@sisa.samsung.com>
2684
2685         Unreviewed. Update my email.
2686
2687         * Scripts/webkitpy/common/config/committers.py:
2688
2689 2012-03-08  Xianzhu Wang  <wangxianzhu@chromium.org>
2690
2691         Recent changes to chromium.py etc. broke chromium_android.py
2692         https://bugs.webkit.org/show_bug.cgi?id=80623
2693
2694         Reviewed by Dirk Pranke.
2695
2696         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2697         (ChromiumAndroidDriver.__init__):
2698         (ChromiumAndroidDriver._start):
2699
2700 2012-03-08  Xianzhu Wang  <wangxianzhu@chromium.org>
2701
2702         [Chromium] Exception running reftest with --no-pixel-tests
2703         https://bugs.webkit.org/show_bug.cgi?id=80642
2704
2705         Reviewed by Dirk Pranke.
2706
2707         * Scripts/webkitpy/layout_tests/port/chromium.py:
2708         (ChromiumDriver.__init__):
2709         (ChromiumDriver._wrapper_options):
2710
2711 2012-03-08  Rafael Brandao  <rafael.lobo@openbossa.org>
2712
2713         [NRWT] Fix --platform=qt-5.0 --new-baseline combo
2714         https://bugs.webkit.org/show_bug.cgi?id=72489
2715
2716         Reviewed by Dirk Pranke.
2717
2718         NRWT: The default platform name for Qt combined with --webkit-test-runner is now
2719         "qt-5.0-wk2" instead of "qt-linux" and that name is now prefered for tests.
2720         --platform will override the platform name and then we'll use it.
2721
2722         ORWT: We check for qt version and use platform name "qt-4.8" if the version is lower
2723         than 5.0.0, and then we choose between "qt-5.0-wk1" and "qt-5.0-wk2". --platform will
2724         override it in the end.
2725
2726         * Scripts/old-run-webkit-tests:
2727         * Scripts/webkitpy/layout_tests/port/qt.py:
2728         (QtPort):
2729         (QtPort.determine_full_port_name):
2730         (QtPort.baseline_search_path):
2731         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2732         (QtPortTest):
2733         (QtPortTest._assert_search_path):
2734         (QtPortTest.test_baseline_search_path):
2735
2736 2012-03-08  Beth Dakin  <bdakin@apple.com>
2737
2738         https://bugs.webkit.org/show_bug.cgi?id=80463
2739         RenderImage is using the wrong origin when calling addRelevantRepaintedObject
2740         -and corresponding-
2741         <rdar://problem/10970221>
2742
2743         Reviewed by Dan Bernstein.
2744
2745         New test!
2746         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2747         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp: Added.
2748         (TestWebKitAPI):
2749         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
2750         (TestWebKitAPI::setPageLoaderClient):
2751         (TestWebKitAPI::TEST):
2752         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp: Added.
2753         (TestWebKitAPI):
2754         (NewFirstVisuallyNonEmptyLayoutForImagesTest):
2755         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutForImagesTest::NewFirstVisuallyNonEmptyLayoutForImagesTest):
2756         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutForImagesTest::didCreatePage):
2757         * TestWebKitAPI/Tests/WebKit2/lots-of-images.html: Added.
2758
2759 2012-03-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2760
2761         [Qt] Prospective Windows build fix
2762
2763         Don't assume that windows-builds will always run inside a cmd.exe shell.
2764
2765         * qmake/mkspecs/features/default_pre.prf:
2766
2767 2012-03-08  Dan Bernstein  <mitz@apple.com>
2768
2769         <rdar://problem/10981173> Dashboard regions should not be in device space
2770
2771         Reviewed by John Sullivan.
2772
2773         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2774         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm: Added.
2775         (-[DeviceScaleFactorInDashboardRegionsUIDelegate webView:dashboardRegionsChanged:]):
2776         (TestWebKitAPI):
2777         (TestWebKitAPI::TEST):
2778
2779 2012-03-08  Dirk Pranke  <dpranke@chromium.org>
2780
2781         webkit-patch works oddly on local Git branches
2782         https://bugs.webkit.org/show_bug.cgi?id=76958
2783
2784         Reviewed by Ojan Vafai.
2785
2786         This change makes the '-g' flag to webkit-patch behave a
2787         little more consistently with git. The 'HEAD..' syntax
2788         is changed to 'HEAD....' (four dots), so as to not
2789         collide with the underlying git syntax. We also generalize
2790         the syntax to support any refname, so 'foo....' means
2791         diff against foo and include working copy changes.
2792
2793         This change also adds the 'UPSTREAM' shortcut to identify
2794         whatever the current upstream/tracking branch is; this is
2795         useful if you have multiple local branches stacked up.
2796
2797         * Scripts/webkitpy/common/checkout/scm/git.py:
2798         (Git._branch_from_ref):
2799         (Git):
2800         (Git._current_branch):
2801         (Git._upstream_branch):
2802         (Git.merge_base):
2803         (Git._commit_on_branch):
2804         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2805         (GitSVNTest._second_local_commit):
2806         (GitSVNTest._two_local_commits):
2807         (GitSVNTest.test_commit_with_message_git_commit_range):
2808         (GitSVNTest.test_upstream_branch):
2809         (GitSVNTest.test_create_patch_working_copy_only):
2810         (GitSVNTest.test_changed_files_local_plus_working_copy):
2811         (GitSVNTest.test_changed_files_working_copy_only):
2812         (GitSVNTest.test_changed_files_upstream):
2813         * Scripts/webkitpy/tool/steps/options.py:
2814         (Options):
2815
2816 2012-03-08  John Sullivan  <sullivan@apple.com>
2817
2818         Made extract-localizable-strings ignore NSLocalizedFileSizeDescription
2819
2820         Reviewed by Eric Carlson.
2821
2822         * Scripts/extract-localizable-strings:
2823         Added NSLocalizedFileSizeDescription to allowed list of tokens that start
2824         with NSLocalized. Also improved an error message to include the troublesome token.
2825
2826 2012-03-08  Sheriff Bot  <webkit.review.bot@gmail.com>
2827
2828         Unreviewed, rolling out r110115.
2829         http://trac.webkit.org/changeset/110115
2830         https://bugs.webkit.org/show_bug.cgi?id=80581
2831
2832         broke test-webkitpy (Requested by philn-tp on #webkit).
2833
2834         * Scripts/old-run-webkit-tests:
2835         * Scripts/webkitpy/layout_tests/port/qt.py:
2836         (QtPort):
2837         (QtPort.determine_full_port_name):
2838         (QtPort.baseline_search_path):
2839
2840 2012-03-08  Kentaro Hara  <haraken@chromium.org>
2841
2842         Unreviewed. Added myself to watchlist.
2843
2844         * Scripts/webkitpy/common/config/watchlist:
2845
2846 2012-03-07  Jessie Berlin  <jberlin@apple.com>
2847
2848         Clean Windows build fails after r110033
2849         https://bugs.webkit.org/show_bug.cgi?id=80553
2850
2851         Rubber-stamped by Jon Honeycutt and Eric Seidel.
2852
2853         Add the new JavaScriptCore include directory to some more vsprops files.
2854
2855         * DumpRenderTree/win/ImageDiffCommon.vsprops:
2856         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2857         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
2858
2859 2012-03-07  Rafael Brandao  <rafael.lobo@openbossa.org>
2860
2861         [NRWT] Fix --platform=qt-5.0 --new-baseline combo
2862         https://bugs.webkit.org/show_bug.cgi?id=72489
2863
2864         Reviewed by Dirk Pranke.
2865
2866         NRWT: The default platform name for Qt combined with --webkit-test-runner is now
2867         "qt-5.0-wk2" instead of "qt-linux" and that name is now prefered for tests.
2868         --platform will override the platform name and then we'll use it.
2869
2870         ORWT: We check for qt version and use platform name "qt-4.8" if the version is lower
2871         than 5.0.0, and then we choose between "qt-5.0-wk1" and "qt-5.0-wk2". --platform will
2872         override it in the end.
2873
2874         * Scripts/old-run-webkit-tests:
2875         * Scripts/webkitpy/layout_tests/port/qt.py:
2876         (QtPort):
2877         (QtPort.determine_full_port_name):
2878         (QtPort.baseline_search_path):
2879
2880 2012-03-07  Hugo Parente Lima  <hugo.lima@openbossa.org>
2881
2882         [Qt][WK2] MiniBrowser on desktop does not react to click events
2883         https://bugs.webkit.org/show_bug.cgi?id=80314
2884
2885         Reviewed by Kenneth Rohde Christiansen.
2886
2887         Do not enable touch mocking on desktop mode.
2888
2889         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2890         (MiniBrowserApplication::handleUserOptions):
2891
2892 2012-03-07  Ojan Vafai  <ojan@chromium.org>
2893
2894         Automatically move to the next test after rebaseline in the results view
2895         https://bugs.webkit.org/show_bug.cgi?id=80527
2896
2897         Reviewed by Dimitri Glazkov.
2898
2899         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2900         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2901
2902 2012-03-07  Ojan Vafai  <ojan@chromium.org>
2903
2904         garden-o-matic rebaseline is broken for ports that don't have a fallback port
2905         https://bugs.webkit.org/show_bug.cgi?id=80526
2906
2907         Reviewed by Adam Barth.
2908
2909         Passing "None" as the fallback port throws an error in "webkit-patch rebaseline-test"
2910         since there is no "None" port.
2911
2912         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2913         (GardeningHTTPRequestHandler.rebaseline):
2914         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2915         (GardeningServerTest.test_rebaseline):
2916
2917 2012-03-07  James Robinson  <jamesr@chromium.org>
2918
2919         [chromium] Remove the TestWebPlugin's use of implicit FBO for offscreen contexts
2920         https://bugs.webkit.org/show_bug.cgi?id=80521
2921
2922         Reviewed by Kenneth Russell.
2923
2924         Switches TestWebPlugin from using a context created by WebViewClient::createGraphicsContext3D(..., false) over
2925         to an explicitly offscreen context with explicitly managed texture / FBO, so we can deprecate the
2926         renderDirectlyToHostWindow flag from WebViewClient::createGraphicsContext3D.
2927
2928         Covered by platform/chromium/compositing/plugins/*
2929
2930         * DumpRenderTree/chromium/TestWebPlugin.cpp:
2931         (TestWebPlugin::TestWebPlugin):
2932         (TestWebPlugin::initialize):
2933         (TestWebPlugin::updateGeometry):
2934         (TestWebPlugin::initScene):
2935         (TestWebPlugin::destroyScene):
2936         * DumpRenderTree/chromium/TestWebPlugin.h:
2937         (TestWebPlugin):
2938         * DumpRenderTree/chromium/WebViewHost.cpp:
2939         (WebViewHost::createPlugin):
2940
2941 2012-03-07  Philippe Normand  <pnormand@igalia.com>
2942
2943         [GTK] remove webkitpy dependency in run-gtk-tests
2944         https://bugs.webkit.org/show_bug.cgi?id=80500
2945
2946         Reviewed by Martin Robinson.
2947
2948         Replace Executive calls with bare subprocess calls.
2949
2950         * Scripts/run-gtk-tests:
2951         (TestRunner):
2952         (TestRunner._lookup_atspi2_binary):
2953         (TestRunner.run):
2954         (TestRunner.run.run_for_real):
2955
2956 2012-03-07  Philippe Normand  <pnormand@igalia.com>
2957
2958         Unreviewed, GTK build fix after r110059.
2959
2960         * Scripts/run-gtk-tests:
2961         (TestRunner._check_if_tests_have_timed_out):
2962         (TestRunner.run.run_tests):
2963         (TestRunner):
2964
2965 2012-03-07  Philippe Normand  <pnormand@igalia.com>
2966
2967         [GTK] race condition in run-gtk-tests
2968         https://bugs.webkit.org/show_bug.cgi?id=80495
2969
2970         Reviewed by Martin Robinson.
2971
2972         Refactored the script to wait the a11y dbus service becomes
2973         available before starting the tests.
2974
2975         * Scripts/run-gtk-tests:
2976         (TestRunner._lookup_atspi2_binary):
2977         (TestRunner):
2978         (TestRunner._wait_dbus_service_and_run):
2979         (TestRunner._wait_dbus_service_and_run.on_name_appeared):
2980         (TestRunner._wait_dbus_service_and_run.on_name_vanished):
2981         (TestRunner.run):
2982         (TestRunner.run.bailout):
2983         (TestRunner.run.run_for_real):
2984
2985 2012-03-07  Dinu Jacob  <dinu.jacob@nokia.com>
2986
2987         [Qt] REGRESSION(r109575) Broke tap-to-zoom gesture
2988         https://bugs.webkit.org/show_bug.cgi?id=80425
2989
2990         Reviewed by Simon Hausmann.
2991
2992         Set startScreenPos in mock touch point
2993
2994         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2995         (MiniBrowserApplication::notify):
2996         * MiniBrowser/qt/MiniBrowserApplication.h:
2997         (MiniBrowserApplication):
2998
2999 2012-03-07  Simon Hausmann  <simon.hausmann@nokia.com>
3000
3001         [Qt] Windows build fix.
3002
3003         Reviewed by Tor Arne Vestbø.
3004
3005         Pass the -j parameter only to "make", not "nmake".
3006
3007         * Scripts/webkitdirs.pm:
3008         (buildQMakeProjects):
3009
3010 2012-03-07  Simon Hausmann  <simon.hausmann@nokia.com>
3011
3012         [Qt] Fix compilation without QtQuick1
3013         https://bugs.webkit.org/show_bug.cgi?id=80503
3014
3015         Reviewed by Tor Arne Vestbø.
3016
3017         Introduce HAVE_QQUICK1 as feature and added haveQtModule
3018         as convenience function.
3019
3020         * qmake/mkspecs/features/features.prf:
3021         * qmake/mkspecs/features/functions.prf:
3022
3023 2012-03-07  Zoltan Horvath  <zoltan@webkit.org>
3024
3025         [Qt] Add qmake config tests for JPEG and PNG library
3026         https://bugs.webkit.org/show_bug.cgi?id=80398
3027
3028         Add JPEG and PNG library tests to config.tests and
3029         add error() abort to WebCore.pri if tests don't work.
3030
3031         Reviewed by Tor Arne Vestbø.
3032
3033         * qmake/config.tests/libjpeg/libjpeg.cpp: Added.
3034         (main):
3035         * qmake/config.tests/libjpeg/libjpeg.pro: Added.
3036         * qmake/config.tests/libpng/libpng.cpp: Added.
3037         (main):
3038         * qmake/config.tests/libpng/libpng.pro: Added.
3039         * qmake/sync.profile:
3040
3041 2012-03-07  Byungwoo Lee  <bw80.lee@samsung.com>
3042
3043         [EFL] Build warning: Fix warn_unused_result warnings.
3044         https://bugs.webkit.org/show_bug.cgi?id=79194
3045
3046         Reviewed by Filip Pizlo.
3047
3048         Fixed build warning which is getting generated when not using return
3049         value of a fuction, especially declared with warn_unused_result
3050         attribute.
3051
3052         * DumpRenderTree/efl/ImageDiff.cpp:
3053         (printImage):
3054
3055 2012-03-07  Kangil Han  <kangil.han@samsung.com>
3056
3057         [DRT] Remove PlainTextController implementations.
3058         https://bugs.webkit.org/show_bug.cgi?id=79959
3059
3060         Reviewed by Hajime Morita.
3061
3062         PlainTextController usages in existing tests have been
3063         replaced by internals API by bug 78570.
3064         So this patch will remove PlainTextController implementations
3065         to avoid further usage in new tests.
3066
3067         * DumpRenderTree/DumpRenderTree.gypi:
3068         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3069         * DumpRenderTree/chromium/PlainTextController.cpp: Removed.
3070         * DumpRenderTree/chromium/PlainTextController.h: Removed.
3071         * DumpRenderTree/chromium/TestShell.cpp:
3072         (TestShell::TestShell):
3073         (TestShell::bindJSObjectsToWindow):
3074         * DumpRenderTree/chromium/TestShell.h:
3075         (TestShell):
3076         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3077         (webViewWindowObjectCleared):
3078         * DumpRenderTree/gtk/PlainTextController.cpp: Removed.
3079         * DumpRenderTree/gtk/PlainTextController.h: Removed.
3080         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3081         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
3082         * DumpRenderTree/mac/PlainTextController.h: Removed.
3083         * DumpRenderTree/mac/PlainTextController.mm: Removed.
3084         * DumpRenderTree/qt/DumpRenderTree.pro:
3085         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3086         (WebCore::DumpRenderTree::DumpRenderTree):
3087         (WebCore::DumpRenderTree::initJSObjects):
3088         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3089         (DumpRenderTree):
3090         * DumpRenderTree/qt/PlainTextControllerQt.cpp: Removed.
3091         * DumpRenderTree/qt/PlainTextControllerQt.h: Removed.
3092         * GNUmakefile.am:
3093
3094 2012-03-06  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
3095
3096         [EFL][DRT] Implements LayoutTestController's setPopupBlockingEnabled.
3097         https://bugs.webkit.org/show_bug.cgi?id=80137
3098
3099         Reviewed by Eric Seidel.
3100
3101         Adds implementation LayoutTestController's setPopupBlockingEnabled.
3102         To pass popup-blocking-click-in-iframe.html EventSender should not
3103         repeat click events in idler's function. EventSender allows to
3104         asynchronously send click event through ecore_idler_add.
3105         This event will be called repeatedly as long as it return true.
3106         Click event should be called only once by returning ECORE_CALLBACK_CANCEL.
3107
3108         * DumpRenderTree/efl/EventSender.cpp:
3109         (sendMouseEvent): Changed return value from bool to void because it always returns true.
3110         (sendClick): Idler is deleted by returning ECORE_CALLBACK_CANCEL.
3111         (mouseDownCallback): Remove unnecessary checking of return value.
3112         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3113         (LayoutTestController::setPopupBlockingEnabled):
3114
3115 2012-03-06  Dirk Pranke  <dpranke@chromium.org>
3116
3117         rebaseline_chromium_webkit_tests is obsolete and should be removed
3118         https://bugs.webkit.org/show_bug.cgi?id=80347
3119
3120         Reviewed by Tony Chang.
3121
3122         * Scripts/rebaseline-chromium-webkit-tests: Removed.
3123         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py: Removed.
3124         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py: Removed.
3125
3126 2012-03-06  Dirk Pranke  <dpranke@chromium.org>
3127
3128         test_start_cmd (webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer) is broken
3129         https://bugs.webkit.org/show_bug.cgi?id=80468
3130
3131         Unreviewed, build fix.
3132
3133         Fixing a bug revealed by r80443 when we fixed filesystem.copyfile().
3134
3135         * Scripts/webkitpy/layout_tests/servers/http_server.py:
3136         (Lighttpd._prepare_config):
3137
3138 2012-03-06  Dirk Pranke  <dpranke@chromium.org>
3139
3140         remove chromium_gpu ports
3141         https://bugs.webkit.org/show_bug.cgi?id=80345
3142
3143         Reviewed by Ojan Vafai.
3144
3145         This change leaves in the 'graphics_type' distinction in the
3146         test_expectations; removing that will require more updates and a
3147         pass over test_expectations.txt, so I'm separating that out.
3148
3149         * Scripts/webkitpy/layout_tests/port/builders.py:
3150         * Scripts/webkitpy/layout_tests/port/chromium.py:
3151         (ChromiumPort):
3152         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: Removed.
3153         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py: Removed.
3154         * Scripts/webkitpy/layout_tests/port/factory.py:
3155         (PortFactory):
3156         (PortFactory.get):
3157         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3158         (FactoryTest.test_qt):
3159         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3160         (TestRebaseline.test_rebaseline_expectations):
3161
3162 2012-03-06  Raphael Kubo da Costa  <kubo@profusion.mobi>
3163
3164         undefined reference to JSC::IdentifierTable::~IdentifierTable() on EFL port
3165         https://bugs.webkit.org/show_bug.cgi?id=80282
3166
3167         Reviewed by Antonio Gomes.
3168
3169         Remove transitive library dependencies; they are especially
3170         dangerous when one ends up linking against WTF, JSC and then WTF
3171         again, since some symbols will not be defined.
3172
3173         Passing --no-copy-dt-needed-entries and --as-needed to the linker
3174         (which some recent Linux distros do by default) makes the issue
3175         even more evident.
3176
3177         * DumpRenderTree/efl/CMakeLists.txt: Do not link directly to WTF,
3178         as the other libraries have the needed symbols. Explicitly link
3179         against fontconfig.
3180
3181 2012-03-06  Dean Jackson  <dino@apple.com>
3182
3183         filter-build-webkit needs more filters
3184         https://bugs.webkit.org/show_bug.cgi?id=80440
3185
3186         Reviewed by Joseph Pecoraro.
3187
3188         Added as many missing filters as I could find for Apple
3189         builds. Plus a few minor style updates.
3190
3191         * Scripts/filter-build-webkit:
3192         (printLine):
3193
3194 2012-03-06  Ojan Vafai  <ojan@chromium.org>
3195
3196         Copying old baselines throws an error if the new directory doesn't exist
3197         https://bugs.webkit.org/show_bug.cgi?id=80443
3198
3199         Reviewed by Adam Barth.
3200
3201         Existing tests cover the new code with the fix to filesystem_mock.
3202
3203         * Scripts/webkitpy/common/system/filesystem_mock.py:
3204         (MockFileSystem.copyfile):
3205         Fix the mock to better match python's copyfile semantics.
3206
3207         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3208         (Rebaseliner._create_html_baseline_files):
3209         * Scripts/webkitpy/tool/commands/rebaseline.py:
3210         (RebaselineTest._copy_existing_baseline):
3211
3212 2012-03-05  Ojan Vafai  <ojan@chromium.org>
3213
3214         Add a mechanism to rebaseline new ports
3215         https://bugs.webkit.org/show_bug.cgi?id=80355
3216
3217         Reviewed by Adam Barth.
3218
3219         For a test that's only failing on a new port, we want
3220         to first copy the existing result into the location for the
3221         port it's replacing in order to not break that port.
3222
3223         For example, bringing up the chromium-lion port, if we just
3224         stick the results in the chromium-mac directory, the snow leopard
3225         will start failing. Instead, we first copy the existing result
3226         to the chromium-mac-snowleopard directory.
3227
3228         * Scripts/webkitpy/layout_tests/port/builders.py:
3229         (builder_path_for_port_name):
3230         (fallback_port_name_for_new_port):
3231         * Scripts/webkitpy/tool/commands/rebaseline.py:
3232         (RebaselineTest):
3233         (RebaselineTest._copy_existing_baseline):
3234         (RebaselineTest._rebaseline_test):
3235         (RebaselineTest.execute):
3236         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3237         (TestRebaseline.test_rebaseline_test):
3238         (TestRebaseline):
3239         (TestRebaseline.test_rebaseline_and_copy_test):
3240         (test_rebaseline_and_copy_test_no_existing_result):
3241         (test_rebaseline_and_copy_test_with_lion_result):
3242         (test_rebaseline_and_copy_no_overwrite_test):
3243         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3244         (GardeningHTTPRequestHandler.rebaseline):
3245         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3246         (GardeningServerTest.test_rebaseline):
3247         (GardeningServerTest):
3248         (GardeningServerTest.test_rebaseline_new_port):
3249
3250 2012-03-06  Beth Dakin  <bdakin@apple.com>
3251
3252         https://bugs.webkit.org/show_bug.cgi?id=80351
3253         InlineTextBox is using the wrong origin when calling 
3254         addRelevantRepaintedObject
3255         -and corresponding-
3256         <rdar://problem/10970221>
3257
3258         Reviewed by Sam Weinig.
3259
3260         This test has actually been broken since revision 109273. This change makes 
3261         the test pass again, and it makes it specifically exercise the fix for this 
3262         bug.
3263         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3264         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
3265         (TestWebKitAPI::TEST):
3266
3267         Adjust comments in the other tests to reflect the API changes from 109273.
3268         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
3269         (TestWebKitAPI::TEST):
3270         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
3271         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::didCreatePage):
3272         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
3273         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::didCreatePage):
3274         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
3275         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::didCreatePage):
3276         * TestWebKitAPI/Tests/WebKit2/lots-of-text.html: Added.
3277
3278 2012-03-06  Hans Wennborg  <hans@chromium.org>
3279
3280         Speech JavaScript API: add SpeechRecognitionError
3281         https://bugs.webkit.org/show_bug.cgi?id=80410
3282
3283         Chromium: enable the runtime flag for scripted speech so we can run
3284         the layout tests for it.
3285
3286         Reviewed by Adam Barth.
3287
3288         * DumpRenderTree/chromium/TestShell.cpp:
3289         (TestShell::TestShell):
3290
3291 2012-03-06  Sami Kyostila  <skyostil@chromium.org>
3292
3293         Enable universal newlines in chromium android layout test runner
3294         https://bugs.webkit.org/show_bug.cgi?id=80418
3295
3296         Reviewed by Adam Barth.
3297
3298         The Chromium Android layout test runner uses the 'adb' program to
3299         communicate with the Android device. Adb uses CRLF ('\r\n') to delimit
3300         output lines from the test runner, while the test expectation files are
3301         written with LF ('\n') delimiters. This causes the results to have
3302         spurious whitespace differences, making them more difficult to
3303         interpret.
3304
3305         The fix is to enable universal newlines for the DumpRenderTree pipe,
3306         causing the output to only contain LF newlines like on other platforms.
3307
3308         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3309         (ChromiumAndroidDriver._start):
3310
3311 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3312
3313         [Qt] Revert r109900, it was completly busted
3314
3315         HAVE_FOO does _not_ have a WTF_ prefix, go figure.
3316
3317         We still leave in the HAVE(FOO) in QtInitializeTestFonts.cpp, instead
3318         of manual define checks.
3319
3320         Reviewed by Ossy.
3321
3322         * DumpRenderTree/qt/DumpRenderTree.pro:
3323         * QtTestBrowser/QtTestBrowser.pro:
3324         * WebKitTestRunner/InjectedBundle/Target.pri:
3325         * qmake/mkspecs/features/features.prf:
3326
3327 2012-03-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3328
3329         [Qt] Use config test to determine if the compiler supports -MD
3330
3331         We used to assume that unix systems building against Qt5 would have
3332         a compiler that supported -MD. Although this was usually the case,
3333         we failed to take into account broken tools for distributed builds
3334         (e.g. teambuilder or icecream) which would end up producing .d files
3335         in the root of the build dir instead of along-side the object file.
3336
3337         Now that we use a config-test to determine the support, we'll capture
3338         those cases, unless distributed builds are enabled after the initial
3339         build-webkit run.
3340
3341         Reviewed by Csaba Osztrogonác.
3342
3343         * Tools.pro:
3344         * qmake/config.tests/gccdepends/empty.cpp: Added.
3345         * qmake/config.tests/gccdepends/gccdepends.pro: Added.
3346         * qmake/mkspecs/features/default_pre.prf:
3347         * qmake/mkspecs/features/features.prf:
3348         * qmake/mkspecs/features/unix/default_pre.prf:
3349         * qmake/sync.profile:
3350
3351 2012-03-06  Csaba Osztrogonác  <ossy@webkit.org>
3352
3353         REGRESSION(r109294): It broke the unittest of master.cfg
3354         https://bugs.webkit.org/show_bug.cgi?id=80253
3355
3356         Reviewed by Tor Arne Vestbø.
3357
3358         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Use json instead of simplejson.
3359         (BuildBotConfigLoader._create_mock_passwords_dict):
3360         (BuildBotConfigLoader._mock_open):
3361         (BuildBotConfigLoader._add_dependant_modules_to_sys_modules):
3362         (BuildBotConfigLoader.load_config):
3363
3364 2012-03-06  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3365
3366         Qt API test buildstep throws exception after buildmaster update
3367         https://bugs.webkit.org/show_bug.cgi?id=80249
3368
3369         This patch based on Peter Gal's work.
3370
3371         Reviewed by Csaba Osztrogonác.
3372
3373         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3374         (RunQtAPITests):
3375         (BuildAndTestFactory.__init__): Enable API tests on the Qt platform again.
3376
3377 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3378
3379         [Qt] Use correct define names for HAVE(FOO) style optional dependencies
3380
3381         Reviewed by Simon Hausmann.
3382         Reviewed by Ossy.
3383
3384         * DumpRenderTree/qt/DumpRenderTree.pro:
3385         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
3386         (WebKit::initializeTestFonts):
3387         * QtTestBrowser/QtTestBrowser.pro:
3388         * WebKitTestRunner/InjectedBundle/Target.pri:
3389         * qmake/mkspecs/features/features.prf:
3390
3391 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3392
3393         [Qt] Don't add recursive qmake_all target if there are no subdirs to recurse
3394
3395         Reviewed by Ossy.
3396
3397         * qmake/mkspecs/features/default_post.prf:
3398
3399 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3400
3401         [Qt] Make sure clean builds are followed by make qmake && make if needed
3402
3403         On non-GNUmake systems we have to run make qmake so that the generated
3404         sources are generated before we run qmake on the target pro files. This
3405         is achieved by using the 'incremental' target.
3406
3407         Reviewed by Ossy.
3408
3409         * Scripts/webkitdirs.pm:
3410         (buildQMakeProjects):
3411
3412 2012-03-06  Filip Pizlo  <fpizlo@apple.com>
3413
3414         DumpRenderTree should support preciseTime()
3415         https://bugs.webkit.org/show_bug.cgi?id=80397
3416
3417         Reviewed by Gavin Barraclough.
3418
3419         * DumpRenderTree/LayoutTestController.cpp:
3420         (preciseTimeCallback):
3421         (LayoutTestController::staticFunctions):
3422
3423 2012-03-06  Sheriff Bot  <webkit.review.bot@gmail.com>
3424
3425         Unreviewed, rolling out r109887.
3426         http://trac.webkit.org/changeset/109887
3427         https://bugs.webkit.org/show_bug.cgi?id=80402
3428
3429         It broke the build (Requested by Ossy on #webkit).
3430
3431         * DumpRenderTree/qt/DumpRenderTree.pro:
3432         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
3433         (WebKit::initializeTestFonts):
3434         * QtTestBrowser/QtTestBrowser.pro:
3435         * WebKitTestRunner/InjectedBundle/Target.pri:
3436         * qmake/mkspecs/features/features.prf:
3437
3438 2012-03-06  Sheriff Bot  <webkit.review.bot@gmail.com>
3439
3440         Unreviewed, rolling out r109837.
3441         http://trac.webkit.org/changeset/109837
3442         https://bugs.webkit.org/show_bug.cgi?id=80399
3443
3444         breaks Mac Productions builds, too late to try and fix it
3445         tonight (Requested by eseidel on #webkit).
3446
3447         * Scripts/build-webkit:
3448
3449 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3450
3451         [Qt] Use correct define names for HAVE(FOO) style optional dependencies
3452
3453         Reviewed by Simon Hausmann.
3454
3455         * DumpRenderTree/qt/DumpRenderTree.pro:
3456         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
3457         (WebKit::initializeTestFonts):
3458         * QtTestBrowser/QtTestBrowser.pro:
3459         * WebKitTestRunner/InjectedBundle/Target.pri:
3460         * qmake/mkspecs/features/features.prf:
3461
3462 2012-03-06  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3463
3464         [Qt] Create EWS to build WebKit2
3465         https://bugs.webkit.org/show_bug.cgi?id=80277
3466
3467         Reviewed by Csaba Osztrogonác.
3468
3469         * QueueStatusServer/model/queues.py:
3470         (Queue):
3471         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3472         (QtWK2EWS):
3473         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3474         (EarlyWarningSytemTest.test_builder_ewses):
3475
3476 2012-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
3477
3478         Unreviewed, rolling out r109733.
3479         http://trac.webkit.org/changeset/109733
3480         https://bugs.webkit.org/show_bug.cgi?id=80378
3481
3482         It broke Qt5 build system (Requested by Ossy on #webkit).
3483
3484         * Tools.pro:
3485         * qmake/config.tests/gccdepends/empty.cpp: Removed.
3486         * qmake/config.tests/gccdepends/gccdepends.pro: Removed.
3487         * qmake/mkspecs/features/default_pre.prf:
3488         * qmake/mkspecs/features/features.prf:
3489         * qmake/mkspecs/features/unix/default_pre.prf:
3490         * qmake/sync.profile:
3491
3492 2012-03-05  Eric Seidel  <eric@webkit.org>
3493
3494         Update JavaScriptCore files to use fully-qualified WTF include path
3495         https://bugs.webkit.org/show_bug.cgi?id=79960
3496
3497         Reviewed by Adam Barth.
3498
3499         Build WTF/WTF.xcodeproj by default on Mac.
3500
3501         * Scripts/build-webkit:
3502
3503 2012-03-05  Dirk Pranke  <dpranke@chromium.org>
3504
3505         There should be a way to disable optimizer in webkit-patch rebaseline-expectations
3506         https://bugs.webkit.org/show_bug.cgi?id=69590
3507
3508         Reviewed by Ryosuke Niwa.
3509
3510         Adds a --no-optimize flag to webkit-patch rebaseline-expectations
3511         to skip the 'optimize-expectations' step.
3512
3513         * Scripts/webkitpy/tool/commands/rebaseline.py:
3514         (RebaselineExpectations.__init__):
3515         (RebaselineExpectations.execute):
3516         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3517
3518 2012-03-05  Kent Tamura  <tkent@chromium.org>
3519
3520         [Chromium] Add new popup type: PagePopup
3521         https://bugs.webkit.org/show_bug.cgi?id=80106
3522
3523         Reviewed by Darin Fisher.
3524
3525         * DumpRenderTree/chromium/WebViewHost.cpp:
3526         (WebViewHost::createPopupMenu):
3527
3528 2012-03-05  Jessie Berlin  <jberlin@apple.com>
3529
3530         Add myself as a reviewer.
3531
3532         * Scripts/webkitpy/common/config/committers.py:
3533         Also, add my IRC nick so it is easier to find and yell at me.
3534
3535 2012-03-05  Robert Kroeger  <rjkroege@chromium.org>
3536
3537         Correctly compute the positions of GestureScroll* events on
3538         Chromium.
3539         https://bugs.webkit.org/show_bug.cgi?id=80075
3540
3541         Reviewed by Adam Barth.
3542
3543         * DumpRenderTree/chromium/EventSender.cpp:
3544         (EventSender::reset):
3545         (EventSender::gestureEvent):
3546         * DumpRenderTree/chromium/EventSender.h:
3547         (EventSender):
3548
3549 2012-03-05  Dirk Pranke  <dpranke@chromium.org>
3550
3551         flakiness dashboard doesn't display baselines for virtual tests correctly
3552         https://bugs.webkit.org/show_bug.cgi?id=80341
3553
3554         Reviewed by Ojan Vafai.
3555
3556         If the test is part of a virtual test suite, we need to look for
3557         baselines in the underlying fallback path for the actual test
3558         being run, as well as baselines for the virtual version.
3559
3560         This patch adds code to handle both branches and also pulls the
3561         mapping of the test suites up into a constant.
3562
3563         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3564         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3565         (testLookupVirtualTestSuite):
3566         (testBaseTest):
3567
3568 2012-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
3569
3570         Unreviewed, rolling out r109760.
3571         http://trac.webkit.org/changeset/109760
3572         https://bugs.webkit.org/show_bug.cgi?id=80320
3573
3574         Caused many GTK+ tests to crash (Requested by mrobinson on
3575         #webkit).
3576
3577         * gtk/jhbuild.modules:
3578
3579 2012-03-05  Charlie Reis  <creis@chromium.org>
3580
3581         [chromium] Pass WebNavigationPolicy to WebViewClient::createView
3582         https://bugs.webkit.org/show_bug.cgi?id=80057
3583
3584         Reviewed by Darin Fisher.
3585
3586         * DumpRenderTree/chromium/WebViewHost.cpp:
3587         (WebViewHost::createView):
3588         * DumpRenderTree/chromium/WebViewHost.h:
3589         (WebViewHost):
3590
3591 2012-03-05  Martin Robinson  <mrobinson@igalia.com>
3592
3593         [soup] Crash while loading http://www.jusco.cn
3594         https://bugs.webkit.org/show_bug.cgi?id=68238
3595
3596         Reviewed by Philippe Normand.
3597
3598         * gtk/jhbuild.modules: Bumped the libsoup and glib dependencies
3599         in the jhbuild file.
3600
3601 2012-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
3602
3603         Unreviewed, rolling out r109748.
3604         http://trac.webkit.org/changeset/109748
3605         https://bugs.webkit.org/show_bug.cgi?id=80296
3606
3607         Made some tests crash, will fix and recommit (Requested by
3608         noamr on #webkit).
3609
3610         * MiniBrowser/qt/main.cpp:
3611         (main):
3612
3613 2012-03-05  Zan Dobersek  <zandobersek@gmail.com>
3614
3615         [GTK] plugins/netscape-plugin-page-cache-works.html fails
3616         https://bugs.webkit.org/show_bug.cgi?id=74409
3617
3618         Reviewed by Martin Robinson.
3619
3620         Add support for overriding the page-cache-for-plugins preference
3621         through DumpRenderTreeSupport.
3622
3623         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3624         (booleanFromValue): A helper function to convert a string to boolean.
3625         (LayoutTestController::overridePreference):
3626
3627 2012-03-05  Rob Buis  <rbuis@rim.com>
3628
3629         [BlackBerry] Update Tools/DumpRenderTree
3630         https://bugs.webkit.org/show_bug.cgi?id=80287
3631
3632         Reviewed by Antonio Gomes.
3633
3634         Update so we are sure we can build our implementation of DRT.
3635
3636         * DumpRenderTree/DumpRenderTree.h: include DumpRenderTreeBlackBerry.h.
3637         * DumpRenderTree/PixelDumpSupport.cpp: include PixelDumpSupportBlackBerry.h.
3638         * DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp:
3639         (AccessibilityController::addNotificationListener): add missing hook.
3640         (AccessibilityController::removeNotificationListener): add missing hook.
3641         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
3642         (AccessibilityUIElement::isSelectedOptionActive): add missing hook.
3643         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
3644         (LayoutTestController::setMockSpeechInputDumpRect): add missing hook.
3645         (LayoutTestController::simulateDesktopNotificationClick): add missing hook.
3646
3647 2012-03-05  No'am Rosenthal  <noam.rosenthal@nokia.com>
3648
3649         [Qt] [WK2] Support threaded renderer in WK2
3650         https://bugs.webkit.org/show_bug.cgi?id=76661
3651
3652         Remove the QML_NO_THREADED_RENDERER environment variable from MiniBrowser.
3653
3654         Reviewed by Kenneth Rohde Christiansen.
3655
3656         * MiniBrowser/qt/main.cpp:
3657         (main):
3658
3659 2012-03-05  Alexander Færøy  <alexander.faeroy@nokia.com>
3660
3661         Unreviewed. Add myself to committer list.
3662
3663         * Scripts/webkitpy/common/config/committers.py:
3664
3665 2012-03-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3666
3667         [Qt] Use config test to determine if the compiler supports -MD
3668
3669         We used to assume that unix systems building against Qt5 would have
3670         a compiler that supported -MD. Although this was usually the case,
3671         we failed to take into account broken tools for distributed builds
3672         (e.g. teambuilder or icecream) which would end up producing .d files
3673         in the root of the build dir instead of along-side the object file.
3674
3675         Now that we use a config-test to determine the support, we'll capture
3676         those cases, unless distributed builds are enabled after the initial
3677         build-webkit run.
3678
3679         Reviewed by Csaba Osztrogonác.
3680
3681         * Tools.pro:
3682         * qmake/config.tests/gccdepends/empty.cpp: Added.
3683         * qmake/config.tests/gccdepends/gccdepends.pro: Added.
3684         * qmake/mkspecs/features/default_pre.prf:
3685         * qmake/mkspecs/features/features.prf:
3686         * qmake/mkspecs/features/unix/default_pre.prf:
3687         * qmake/sync.profile:
3688
3689 2012-03-05  Csaba Osztrogonác  <ossy@webkit.org>
3690
3691         Qt API test buildstep throws exception after buildmaster update
3692         https://bugs.webkit.org/show_bug.cgi?id=80249
3693
3694         Reviewed by Zoltan Herczeg.
3695
3696         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Disable API tests on the Qt bot temporarily.
3697         (BuildAndTestFactory.__init__):
3698
3699 2012-03-04  Martin Robinson  <mrobinson@igalia.com>
3700
3701         [GTK] Unit tests are noisy when run under jhbuild
3702         https://bugs.webkit.org/show_bug.cgi?id=80241
3703
3704         Reviewed by Philippe Normand.
3705
3706         Force the 'memory' backend in GSettings so that each unit
3707         test doesn't produce a warning when it's forced to fall back
3708         to the 'memory' backend.
3709
3710         * Scripts/run-gtk-tests:
3711         (TestRunner.run): Force the 'memory' backend.
3712
3713 2012-03-04  Martin Robinson  <mrobinson@igalia.com>
3714
3715         [GTK] "Console: undefined @0: ReferenceError: Can't find variable: WebInspector" during testwebinspector
3716         https://bugs.webkit.org/show_bug.cgi?id=80235
3717
3718         Reviewed by Philippe Normand.
3719
3720         * Scripts/run-gtk-tests:
3721         (TestRunner.run): Use the WEBKIT_INSPECTOR_PATH environment variable so that
3722         inspector resources path determination is shared by all tests.
3723
3724 2012-03-04  Martin Robinson  <mrobinson@igalia.com>
3725
3726         [GTK] REGRESSION: r108278 broke some tests that expect focus
3727         https://bugs.webkit.org/show_bug.cgi?id=79084
3728
3729         Reviewed by Philippe Normand.
3730
3731         Grab focus when dumping test results and also when sending
3732         events. During the course of testing, the WebView may lose
3733         focus and this seems to snap it back when tests demand it.
3734
3735         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3736         (dump): Grab focus.
3737         * DumpRenderTree/gtk/EventSender.cpp:
3738         (dispatchEvent): Ditto.
3739
3740 2012-03-04  Charles Wei  <charles.wei@torchmobile.com.cn>
3741
3742         Unreviewed, Add myself to committer list.
3743         https://bugs.webkit.org/show_bug.cgi?id=80232
3744
3745         * Scripts/webkitpy/common/config/committers.py:
3746
3747 2012-03-04  Anders Carlsson  <andersca@apple.com>
3748
3749         Newer versions of clang fail to compile WebKit.
3750
3751         Fix build.
3752
3753         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3754         (descriptionOfValue):
3755         (AccessibilityUIElement::rowIndexRange):
3756         (AccessibilityUIElement::columnIndexRange):
3757         (AccessibilityUIElement::selectedTextRange):
3758         * DumpRenderTree/mac/EditingDelegate.mm:
3759         (-[DOMRange dump]):
3760         * DumpRenderTree/mac/PolicyDelegate.mm:
3761         (-[PolicyDelegate webView:unableToImplementPolicyWithError:frame:]):
3762         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3763         (-[NSError _drt_descriptionSuitableForTestResult]):
3764         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3765         (WTR::descriptionOfValue):
3766         (WTR::AccessibilityUIElement::rowIndexRange):
3767         (WTR::AccessibilityUIElement::columnIndexRange):
3768         (WTR::AccessibilityUIElement::selectedTextRange):
3769
3770 2012-03-03  Simon Hausmann  <simon.hausmann@nokia.com>
3771
3772         [Qt] Fix static_libs_as_shared build
3773         https://bugs.webkit.org/show_bug.cgi?id=80214
3774
3775         Reviewed by Tor Arne Vestbø.
3776
3777         * WebKitTestRunner/qt/main.cpp:
3778         (main): Set the correct environment variable for choosing the theme in the
3779         web process.
3780
3781 2012-03-03  Hans Wennborg  <hans@chromium.org>
3782
3783         Implement Speech JavaScript API
3784         https://bugs.webkit.org/show_bug.cgi?id=80019
3785
3786         Reviewed by Adam Barth.
3787
3788         Add ENABLE_SCRIPTED_SPEECH.
3789
3790         * Scripts/build-webkit:
3791         * qmake/mkspecs/features/features.prf:
3792
3793 2012-03-02  Alexey Proskuryakov  <ap@apple.com>
3794
3795         Fix commit queue, remove duplicate entry.
3796
3797         * Scripts/webkitpy/common/config/committers.py:
3798
3799 2012-03-02  Stephen Chenney  <schenney@chromium.org>
3800
3801         Unreviewed, add myself as a committer
3802
3803         * Scripts/webkitpy/common/config/committers.py:
3804
3805 2012-03-02  Ojan Vafai  <ojan@chromium.org>
3806
3807         Add the Chromium Lion canary bot to the flakiness dashboard.
3808         * TestResultServer/static-dashboards/builders.js:
3809
3810 2012-03-02  Dirk Pranke  <dpranke@chromium.org>
3811
3812         links for virtual tests are broken in the flakiness dashboard
3813         https://bugs.webkit.org/show_bug.cgi?id=80180
3814
3815         Reviewed by Ojan Vafai.
3816
3817         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3818         (linkHTMLToOpenWindow):
3819         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3820         (testLinkHTMLToOpenWindow): added.
3821
3822 2012-03-02  Philippe Normand  <pnormand@igalia.com>
3823
3824         [GTK] security/block-test.html baselines differ from mac
3825         https://bugs.webkit.org/show_bug.cgi?id=78343
3826
3827         Reviewed by Martin Robinson.
3828
3829         Improved the FrameLoader error heuristics to match mac behavior a
3830         bit more.
3831
3832         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3833         (pathFromSoupURI): Handle ftp urls the same as http urls.
3834         (descriptionSuitableForTestResult): Map WebKitPolicyError to WebKitErrorDomain.
3835
3836 2012-03-02  Andras Becsi  <andras.becsi@nokia.com>
3837
3838         [Qt][WK2] Fix typo in patch committed in r109575
3839
3840         Unreviewed typo fix.
3841
3842         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3843         (MiniBrowserApplication::notify): Cache the position
3844         in floating point coordinates.
3845
3846 2012-03-02  Andras Becsi  <andras.becsi@nokia.com>
3847
3848         [Qt][WK2] Infinite loop on history navigation, when panning
3849         https://bugs.webkit.org/show_bug.cgi?id=79119
3850
3851         Reviewed by Simon Hausmann.
3852
3853         Make the touch mocking more robust by creating touch events
3854         directly and sending them synchronously to the browser window.
3855         If the sent touch event was not accepted we propagate the
3856         original mouse event to its target.
3857         This way we make sure we only send either a touch or a mouse
3858         event and do not end up in an infinite loop between our mocking
3859         code and the Qt5 automatic mouse event synthesizing.
3860
3861         * MiniBrowser/qt/BrowserWindow.cpp:
3862         (BrowserWindow::updateVisualMockTouchPoints):
3863         * MiniBrowser/qt/BrowserWindow.h:
3864         (BrowserWindow):
3865         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3866         (touchRectForPosition):
3867         (MiniBrowserApplication::notify):
3868         (MiniBrowserApplication::sendTouchEvent):
3869         * MiniBrowser/qt/MiniBrowserApplication.h:
3870         (MiniBrowserApplication):
3871
3872 2012-03-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3873
3874         [Qt] Use 'all' as default target when debug_and_release is in effect
3875
3876         When debug_and_release is enabled, in combination with build_all,
3877         qmake will generate an aggregate makefile that calls make on both
3878         the debug and the release makefiles, but with the 'all' target.
3879
3880         In this case we can't use 'first' as the default target, as the
3881         extra targets would then not be run, so we append extra targets
3882         to 'all' instead.
3883
3884         Reviewed by Simon Hausmann.
3885
3886         * qmake/mkspecs/features/default_post.prf:
3887
3888 2012-03-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3889
3890         [Qt] Make sure activeBuildConfig() returns the right config
3891
3892         Using isActiveConfig fails, as that only checks if the given
3893         argument is in CONFIG, not the order.
3894
3895         Reviewed by Simon Hausmann.
3896
3897         * qmake/mkspecs/features/functions.prf:
3898
3899 2012-03-02  Simon Hausmann  <simon.hausmann@nokia.com>
3900
3901         [Qt] Fix tests run with WTR not using QStyle theme
3902         https://bugs.webkit.org/show_bug.cgi?id=80147
3903
3904         Reviewed by Csaba Osztrogonác.
3905
3906         * WebKitTestRunner/qt/main.cpp:
3907         (main): Set environment variable for web process to use QStyle theme.
3908
3909 2012-03-02  Philippe Normand  <pnormand@igalia.com>
3910
3911         Unreviewed, remove debug print call.
3912
3913         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3914         (descriptionSuitableForTestResult):
3915
3916 2012-03-02  Robert Kroeger  <rjkroege@chromium.org>
3917
3918         Updated EventSender to send complete gesture events.
3919         https://bugs.webkit.org/show_bug.cgi?id=80075
3920
3921         Reviewed by Adam Barth.
3922
3923         * DumpRenderTree/chromium/EventSender.cpp:
3924         (EventSender::gestureEvent): set additional parameters in sent events.
3925
3926 2012-03-01  Kalev Lember  <kalevlember@gmail.com>
3927
3928         WebKitTestRunner: Explicitly include unistd.h for gcc 4.7
3929         https://bugs.webkit.org/show_bug.cgi?id=80033
3930
3931         Reviewed by Gustavo Noronha Silva.
3932
3933         GCC 4.7 no longer includes unistd.h from most of the standard C++
3934         header files, so we need to explicitly include it for getcwd().
3935
3936         * WebKitTestRunner/TestInvocation.cpp: Make sure unistd.h gets included
3937         not only on Mac, but on all Unix platforms.
3938
3939 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
3940
3941         Actually look at the args in driver_input :(.
3942
3943         Unreviewed, build fix.
3944
3945         * Scripts/webkitpy/layout_tests/port/chromium.py:
3946         (ChromiumDriver.run_test):
3947
3948 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
3949
3950         Fix typo in flag used to run gpu virtual suites.
3951
3952         Unreviewed, build fix.
3953
3954         * Scripts/webkitpy/layout_tests/port/chromium.py:
3955         (ChromiumPort.virtual_test_suites):
3956
3957 2012-03-01  Adam Barth  <abarth@webkit.org>
3958
3959         Unreviewed, rolling out r109317.
3960         http://trac.webkit.org/changeset/109317
3961
3962         Let's try watchlists again now that we're using a pure git
3963         working copy
3964
3965         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
3966         (StyleQueueTask.run):
3967         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3968
3969 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
3970
3971         webkitpy: test_run_test_pause_before_testing is failing after r109482
3972         https://bugs.webkit.org/show_bug.cgi?id=80084
3973
3974         Unreviewed, build fix.
3975
3976         Fixes the test string compare to ignore the time spent running
3977         the tests.
3978
3979         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3980         (test_run_test_pause_before_testing):
3981
3982 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
3983
3984         nrwt: virtual tests aren't being run
3985         https://bugs.webkit.org/show_bug.cgi?id=80083
3986
3987         Reviewed by Eric Seidel.
3988
3989         If we tried to run all of the tests by default (and
3990         didn't specify any paths), the virtual tests weren't
3991         picked up.
3992
3993         * Scripts/webkitpy/layout_tests/port/base.py:
3994         (Port._virtual_tests):
3995         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3996         (PortTest.test_tests):
3997         * Scripts/webkitpy/layout_tests/port/test.py:
3998         (TestPort.virtual_test_suites):
3999
4000 2012-03-01  Ryosuke Niwa  <rniwa@webkit.org>
4001
4002         run-perf-tests should report the test runtime
4003         https://bugs.webkit.org/show_bug.cgi?id=80078
4004
4005         Reviewed by Hajime Morita.
4006
4007         Record and output the aggreated test run time.
4008
4009         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4010         (PerfTestsRunner._run_single_test):
4011
4012 2012-03-01  Michael Nordman  <michaeln@google.com>
4013
4014         [chromium] Use webkit_support to create session storage namespaces in DRT.
4015         https://bugs.webkit.org/show_bug.cgi?id=79933
4016
4017         Reviewed by Tony Chang.
4018
4019         * DumpRenderTree/chromium/WebViewHost.cpp:
4020         (WebViewHost::createSessionStorageNamespace):
4021
4022 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
4023
4024         nrwt: test_isfile, test_isdir, and test_exists don't work for virtual tests
4025         https://bugs.webkit.org/show_bug.cgi?id=80048
4026
4027         Reviewed by Adam Barth.
4028
4029         * Scripts/webkitpy/layout_tests/port/base.py:
4030         (Port.test_isfile):
4031         (Port.test_isdir):
4032         (Port):
4033         (Port.test_exists):
4034         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
4035         (PortTest.test_test_exists):
4036         (PortTest):
4037         (PortTest.test_test_isfile):
4038         (PortTest.test_test_isdir):
4039         * Scripts/webkitpy/layout_tests/port/test.py:
4040         (TestPort.virtual_test_suites):
4041         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
4042         (MainTest.test_virtual):
4043
4044 2012-03-01  Kalev Lember  <kalevlember@gmail.com>
4045
4046         [GTK] Avoid building any parts of WebKitTestRunner when WK2 is disabled
4047         https://bugs.webkit.org/show_bug.cgi?id=80031
4048
4049         Reviewed by Gustavo Noronha Silva.
4050
4051         Only build the libTestRunnerInjectedBundle.la convenience library when
4052         ENABLE_WEBKIT2 is defined.
4053
4054         * WebKitTestRunner/GNUmakefile.am:
4055
4056 2012-03-01  Philippe Normand  <pnormand@igalia.com>
4057
4058         Unreviewed, second attempt to fix GTK NRWT after r109242.
4059
4060         * Scripts/webkitpy/layout_tests/port/gtk.py:
4061         (GtkDriver._start):
4062
4063 2012-03-01  Philippe Normand  <pnormand@igalia.com>
4064
4065         Unreviewed, GTK NRWT build fix attempt after r109242.
4066
4067         * Scripts/webkitpy/layout_tests/port/gtk.py:
4068         (GtkDriver._start):
4069
4070 2012-03-01  Kentaro Hara  <haraken@chromium.org>
4071
4072         REGRESSION(r109036): run-bindings-tests fails because resolve-supplemental.pl was renamed
4073         https://bugs.webkit.org/show_bug.cgi?id=80008
4074
4075         Reviewed by Adam Barth.
4076
4077         In r109036, I forgot to rename "resolve-supplemental.pl" in run-bindings-tests
4078         to "preprocess-idls.pl". This patch renames it.
4079
4080         Test: Confirm that run-bindings-tests runs.
4081
4082         * Scripts/webkitpy/bindings/main.py:
4083         (BindingsTests.generate_supplemental_dependency):
4084
4085 2012-02-29  Simon Hausmann  <simon.hausmann@nokia.com>
4086
4087         [Qt][WK2] QQuickWebView::event should lookup faster which events QQuickWebPage can handle
4088         https://bugs.webkit.org/show_bug.cgi?id=78047
4089
4090         Reviewed by Kenneth Rohde Christiansen.
4091
4092         Send events for the webview through the QQuickCanvas instead of directly to the item. Direct
4093         sending to the item requires the QObject::event re-implementation to dispatch to the correct
4094         event handling function. However QQuickItem::event doesn't do that. Instead QQuickCanvas calls
4095         the event handlers directly, and with the removal of our own dispatching we need to go through
4096         that code path.
4097
4098         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
4099         (WTR::PlatformWebView::sendEvent):
4100         (WTR::PlatformWebView::postEvent):
4101
4102 2012-02-29  Adam Barth  <abarth@webkit.org>
4103
4104         Disable watchlist.  It's been spamming CCs.
4105
4106         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
4107         (StyleQueueTask.run):
4108         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4109
4110 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
4111
4112         need to clone the gpu baselines and expectations into the new "virtual" dir
4113         https://bugs.webkit.org/show_bug.cgi?id=79956
4114
4115         Reviewed by Adam Barth.
4116
4117         * Scripts/webkitpy/layout_tests/port/chromium.py:
4118         (ChromiumPort.virtual_test_suites):
4119
4120 2012-02-29  Mark Rowe  <mrowe@apple.com>
4121
4122         Switch to using json rather than simplejson now that the master is using Python 2.7.
4123
4124         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4125         (loadBuilderConfig):
4126
4127 2012-02-29  David Levin  <levin@chromium.org>
4128
4129         [chromium] Add the ability to turn off autoresize.
4130         https://bugs.webkit.org/show_bug.cgi?id=77452
4131
4132         Reviewed by Darin Fisher.
4133
4134         * DumpRenderTree/chromium/LayoutTestController.cpp:
4135         (LayoutTestController::LayoutTestController): Expose a way to turn off auto-resize.
4136         (LayoutTestController::enableAutoResizeMode): Ditto and adjust to new WebKit api.
4137         (LayoutTestController::disableAutoResizeMode):  Ditto.
4138         * DumpRenderTree/chromium/LayoutTestController.h: Ditto.
4139
4140 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
4141
4142         nrwt: make --print trace work with virtual tests
4143         https://bugs.webkit.org/show_bug.cgi?id=79952
4144
4145         Reviewed by Adam Barth.
4146
4147         * Scripts/webkitpy/layout_tests/views/printing.py:
4148         (Printer._print_test_trace):
4149         (Printer._print_baseline):
4150
4151 2012-02-28  Brian Weinstein  <bweinstein@apple.com>
4152
4153         WebKit2: didNewFirstVisuallyNonEmptyLayout should be sent to injected bundle
4154         https://bugs.webkit.org/show_bug.cgi?id=79849
4155
4156         Reviewed by Beth Dakin.
4157
4158         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4159         (WTR::InjectedBundlePage::InjectedBundlePage): Add an entry to the struct.
4160
4161 2012-02-29  Lucas Forschler  <lforschler@apple.com>
4162
4163         Removed unused Apple buildslaves from the master configuration
4164         https://bugs.webkit.org/show_bug.cgi?id=79925
4165
4166         Reviewed by Stephanie Lewis.
4167
4168         * BuildSlaveSupport/build.webkit.org-config/config.json:
4169
4170 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
4171
4172         nrwt: implement simple 'virtual test suite' support
4173         https://bugs.webkit.org/show_bug.cgi?id=79737
4174
4175         Reviewed by Adam Barth.
4176
4177         Add very basic support for 'virtual test suites' to NRWT:
4178         a virtual suite is a directory that may contain new baselines,
4179         contains a pointer to a "base" directory of tests, and an
4180         optional list of command line arguments to pass to DRT;
4181         it gives us a way to run all of the tests in a given directory
4182         multiple times with multiple (potentially differing) sets of
4183         results and baselines.
4184
4185         This patch implements the support needed for this feature, and
4186         some basic tests, but no actual port will use the feature yet.
4187
4188         This is probably the simplest implementation possible - the
4189         list of virtual suites will be hard-coded into the port's
4190         implementation. One can imagine a more data-driven approach
4191         where the suite instructions are stored in a manifest file
4192         either in LayoutTests (all suites in one file), or per-port,
4193         or per-directory. If this feature ends up being useful we
4194         should probably add something like that so people don't have
4195         to hunt around in the code to add suites.
4196
4197         * Scripts/webkitpy/layout_tests/port/base.py:
4198         (Port.__init__):
4199         (Port.expected_filename):
4200         (Port.tests):
4201         (Port):
4202         (Port._real_tests):
4203         (Port._driver_class):
4204         (Port.virtual_test_suites):
4205         (Port.virtual_suite):
4206         (Port.virtual_suite.VirtualTestSuite):
4207         (Port.virtual_suite.VirtualTestSuite.__init__):
4208         (Port.virtual_suite.VirtualTestSuite.__repr__):
4209         (Port.populated_virtual_test_suites):
4210         (Port._virtual_tests):
4211         (Port.lookup_virtual_test_base):
4212         (Port.lookup_virtual_test_args):
4213         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
4214         (PortTest.test_find_with_skipped_directories):
4215         * Scripts/webkitpy/layout_tests/port/driver.py:
4216         (DriverInput.__init__):
4217         (DriverProxy.run_test):
4218         * Scripts/webkitpy/layout_tests/port/test.py:
4219         (TestPort.virtual_test_suites):
4220         (TestDriver.run_test):
4221         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
4222         (MainTest.test_all):
4223         (MainTest.test_virtual):
4224
4225 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
4226
4227         nrwt: support more than two drivers in DriverProxy
4228         https://bugs.webkit.org/show_bug.cgi?id=79736
4229
4230         Reviewed by Adam Barth.
4231
4232         Now that we can support per-test command lines for
4233         Drivers, modify DriverProxy to keep a map of running
4234         drivers for each needed command-line; this will allow
4235         us to transparently maintain a pool of appropriately
4236         configured DRTs without having to constantly start and stop
4237         them.
4238
4239         Note that this potentially raises a garbage collection
4240         problem - the number of running DRTs will grow with the
4241         number of different sets of command line args. For now
4242         this is no worse than the current code - if you're running
4243         with pixel tests, you will only need one DRT per worker,
4244         and if you aren't, you'll need two (one for text-only tests,
4245         and one for reftests).
4246
4247         An alternative would be to only ever have one running driver,
4248         and restart the driver as the command line changes, but this
4249         might (?) slow down execution in the text-only case - we
4250         should benchmark this because it would be simpler and possibly
4251         allow us to eliminate DriverProxy altogether.
4252
4253         * Scripts/webkitpy/layout_tests/port/driver.py:
4254         (DriverProxy.__init__):
4255         (DriverProxy):
4256         (DriverProxy._make_driver):
4257         (DriverProxy.run_test):
4258         (DriverProxy.has_crashed):
4259         (DriverProxy.stop):
4260         (DriverProxy.cmd_line):
4261         (DriverProxy._cmd_line_as_key):
4262
4263 2012-02-29  Adrienne Walker  <enne@google.com>
4264
4265         Unreviewed, add myself as a reviewer
4266
4267         * Scripts/webkitpy/common/config/committers.py:
4268
4269 2012-02-29  Greg Billock  <gbillock@google.com>
4270
4271         Add more tests for web intents
4272         https://bugs.webkit.org/show_bug.cgi?id=79527
4273
4274         Reviewed by Adam Barth.
4275
4276         * DumpRenderTree/chromium/LayoutTestController.cpp:
4277         (LayoutTestController::LayoutTestController):
4278         (LayoutTestController::sendWebIntentResponse):
4279         * DumpRenderTree/chromium/LayoutTestController.h:
4280         (LayoutTestController):
4281         * DumpRenderTree/chromium/WebViewHost.h:
4282         (WebViewHost):
4283         (WebViewHost::currentIntentRequest):
4284
4285 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
4286
4287         nrwt: port/Driver needs to support per-test command line args
4288         https://bugs.webkit.org/show_bug.cgi?id=79733
4289
4290         Reviewed by Adam Barth.
4291
4292         As part of removing the 'gpu' configurations and adding support
4293         for 'virtual test suites', the Driver classes need to support
4294         per-test command lines (since different tests will need to be
4295         run with different command line options).
4296
4297         The per-test args are not yet used, so this change should have
4298         no visible effects and need no additional testing.
4299
4300         * Scripts/webkitpy/layout_tests/port/base.py:
4301         (Port.driver_cmd_line):
4302         * Scripts/webkitpy/layout_tests/port/chromium.py:
4303         (ChromiumDriver.cmd_line):
4304         (ChromiumDriver._start):
4305         (ChromiumDriver.start):
4306         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
4307         (ChromiumDriverTest.test_two_drivers.MockDriver.cmd_line):
4308         (ChromiumDriverTest):
4309         (ChromiumDriverTest.test_two_drivers):
4310         * Scripts/webkitpy/layout_tests/port/driver.py:
4311         (Driver.cmd_line):
4312         (DriverProxy.__init__):
4313         (DriverProxy.start):
4314         (DriverProxy.cmd_line):
4315         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
4316         (DriverTest.test_virtual_driver_methods):
4317         * Scripts/webkitpy/layout_tests/port/gtk.py:
4318         (GtkDriver.cmd_line):
4319         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
4320         * Scripts/webkitpy/layout_tests/port/test.py:
4321         (TestPort._path_to_driver):
4322         (TestDriver.cmd_line):
4323         (TestDriver.start):
4324         * Scripts/webkitpy/layout_tests/port/webkit.py:
4325         (WebKitDriver.cmd_line):
4326         (WebKitDriver._start):
4327         (WebKitDriver.run_test):
4328         (WebKitDriver.start):
4329         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
4330         (WebKitDriverTest.test_no_timeout):
4331         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4332         (PerfTestsRunner._run_tests_set):
4333         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
4334         (test_run_test_pause_before_testing):
4335
4336 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
4337
4338         perftestsrunner can call printer.write() after printer.cleanup()
4339         https://bugs.webkit.org/show_bug.cgi?id=79872
4340
4341         Reviewed by Ryosuke Niwa.
4342
4343         This patch fixes a unittest that was incorrectly calling
4344         PerfTestsRunner.run() twice (which led to a weird state in the
4345         printer object).
4346
4347         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
4348         (MainTest.test_run_with_upload_json):
4349
4350 2012-02-29  Balazs Kelemen  <kbalazs@webkit.org>
4351
4352         [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
4353         https://bugs.webkit.org/show_bug.cgi?id=76546
4354
4355         Reviewed by Simon Hausmann.
4356
4357         Revert the workaround introduced in r107868 and reintroduce
4358         the qml binding so we can test the code path that we are more
4359         interested in. The reason that it did not work before is that
4360         we don't have an active platform window which we now workaround
4361         by propagating the resize through QWindowSystemInterface.
4362
4363         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
4364         (WTR::WrapperWindow::handleStatusChanged):
4365         (WTR::PlatformWebView::resizeTo):
4366
4367 2012-02-29  Gabor Rapcsanyi  <rgabor@webkit.org>
4368
4369         [GTK] Small fix for cross compilation to not generate gtkdoc.
4370
4371         Rubber-stamped by Csaba Osztrogonác.
4372
4373         * Scripts/webkitdirs.pm:
4374         (isCrossCompilation):
4375
4376 2012-02-28  Lucas Forschler  <lforschler@apple.com>
4377
4378         Fix a typo in config.json
4379         linx -> linux
4380         
4381         * BuildSlaveSupport/build.webkit.org-config/config.json:
4382