52411bfaf694c8ef2e03785d1f462ae2a0114949
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-04  Chris Dumez  <cdumez@apple.com>
2
3         Unreviewed, roll out r243858 which made tests time out.
4
5         Disable new API tests on Windows instead.
6
7         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
8         (TestWebKitAPI::TEST):
9
10 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
11
12         [ATK] Cleanup WebPageAccessibilityObjectAtk
13         https://bugs.webkit.org/show_bug.cgi?id=196537
14
15         Reviewed by Michael Catanzaro.
16
17         Also consider files under atk directories as exceptions for GObject conventions.
18
19         * Scripts/webkitpy/style/checkers/cpp.py:
20         (check_identifier_name_in_declaration):
21
22 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
23
24         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
25         https://bugs.webkit.org/show_bug.cgi?id=196588
26         <rdar://problem/49365787>
27
28         Unreviewed build fix for Windows port.
29
30         error C3861: 'kill': identifier not found
31
32         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
33         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
34
35 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
36
37         [ews-build] Cancel build and similar operations should have authentication
38         https://bugs.webkit.org/show_bug.cgi?id=196520
39
40         Reviewed by Dewei Zhu.
41
42         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
43         environment variables.
44
45 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
46
47         [ews-build] Do not trigger queues which are not in production yet
48         https://bugs.webkit.org/show_bug.cgi?id=196581
49
50         Reviewed by Dewei Zhu.
51
52         * BuildSlaveSupport/ews-build/config.json:
53
54 2019-04-03  Chris Dumez  <cdumez@apple.com>
55
56         Unreviewed, fix typo in the name of API test added in r243848.
57
58         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
59         (TestWebKitAPI::TEST):
60
61 2019-04-03  Chris Dumez  <cdumez@apple.com>
62
63         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
64         https://bugs.webkit.org/show_bug.cgi?id=196588
65         <rdar://problem/49365787>
66
67         Reviewed by Ryosuke Niwa.
68
69         Add API test coverage.
70
71         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
72         (TestWebKitAPI::nullJavaScriptCallback):
73         (TestWebKitAPI::didCrashCheckFrames):
74         (TestWebKitAPI::TEST):
75
76 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
77
78         run-webkit-tests: Upload test results (new results database)
79         https://bugs.webkit.org/show_bug.cgi?id=196577
80         <rdar://problem/34841155>
81
82         Reviewed by Lucas Forschler.
83
84         * Scripts/webkitpy/layout_tests/controllers/manager.py:
85         (Manager.run): Upload results after each device shard, since the configuration will be
86         different for each device.
87         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
88         uploaded to a results database.
89         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
90         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
91
92 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
93
94         -apple-trailing-word is needed for browser detection
95         https://bugs.webkit.org/show_bug.cgi?id=196575
96
97         Unreviewed.
98
99         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
100
101 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
102
103         [CMake][WTF] Mirror XCode header directories
104         https://bugs.webkit.org/show_bug.cgi?id=191662
105
106         Reviewed by Konstantin Tokarev.
107
108         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
109         builds.
110
111         * CMakeLists.txt:
112         * DumpRenderTree/CMakeLists.txt:
113         * DumpRenderTree/PlatformWin.cmake:
114         * MiniBrowser/win/CMakeLists.txt:
115         * TestWebKitAPI/CMakeLists.txt:
116         * TestWebKitAPI/PlatformWin.cmake:
117         * WebKitTestRunner/PlatformGTK.cmake:
118         * WebKitTestRunner/PlatformWin.cmake:
119
120 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
121
122         [ews-app] Status bubble should not display certain infrastructure status messages
123         https://bugs.webkit.org/show_bug.cgi?id=196550
124
125         Reviewed by Lucas Forschler.
126
127         Do not display the steps which are un-needed for end-user. This information is still avaiable
128         if the user click on the bubble and look at the Buildbot build.
129         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
130         (StatusBubble._steps_messages):
131         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
132
133 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
134
135         [ews-build] Use https for sending data to ews-app
136         https://bugs.webkit.org/show_bug.cgi?id=196492
137
138         Reviewed by Lucas Forschler.
139
140         * BuildSlaveSupport/ews-build/events.py:
141
142 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
143
144         Remove support for -apple-trailing-word
145         https://bugs.webkit.org/show_bug.cgi?id=196525
146
147         Reviewed by Zalan Bujtas.
148
149         This CSS property is nonstandard and not used.
150
151         * Scripts/webkitperl/FeatureList.pm:
152         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
153
154 2019-04-03  Youenn Fablet  <youenn@apple.com>
155
156         Add a test for DOMCache on multiple browsing in case of private browsing
157         https://bugs.webkit.org/show_bug.cgi?id=196524
158
159         Reviewed by Alex Christensen.
160
161         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
162         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
163
164 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
165
166         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
167         https://bugs.webkit.org/show_bug.cgi?id=196540
168
169         Reviewed by Aakash Jain.
170
171         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
172
173 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
174
175         Add plumbing for a compatibility mode preference in WebKit
176         https://bugs.webkit.org/show_bug.cgi?id=196005
177
178         Reviewed by Tim Horton.
179
180         Add new API tests.
181
182         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
183         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
184
185 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
186
187         [WPE][GTK] Update libsrtp dependency package for Debian
188         https://bugs.webkit.org/show_bug.cgi?id=196528
189
190         Reviewed by Frédéric Wang.
191
192         * gtk/install-dependencies:
193         * wpe/install-dependencies:
194
195 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
196
197         [WK2] Add support for Window's beforeprint / afterprint events
198         https://bugs.webkit.org/show_bug.cgi?id=196478
199         <rdar://problem/49535124>
200
201         Unreviewed build fix for MSVC.
202
203         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
204
205         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
206
207         * WebKitTestRunner/TestController.cpp:
208         (WTR::printFrame): Use int and float literals.
209
210 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
211
212         [ews-build] Reassign bots to queues
213
214         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
215
216 2019-04-02  Chris Dumez  <cdumez@apple.com>
217
218         [WK2] Add support for Window's beforeprint / afterprint events
219         https://bugs.webkit.org/show_bug.cgi?id=196478
220
221         Reviewed by Alex Christensen.
222
223         Add minimal implementation for printFrame in WebKitTestRunner.
224
225         * WebKitTestRunner/TestController.cpp:
226         (WTR::printFrame):
227         (WTR::TestController::createOtherPage):
228         (WTR::TestController::createWebViewWithOptions):
229
230 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
231
232         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
233         https://bugs.webkit.org/show_bug.cgi?id=196491
234
235         Reviewed by Lucas Forschler.
236
237         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
238
239 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
240
241         [ews-build] Configure buildbot try credentials in environment variables
242         https://bugs.webkit.org/show_bug.cgi?id=196501
243
244         Reviewed by Lucas Forschler.
245
246         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
247         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
248         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
249
250 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
251
252         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
253         https://bugs.webkit.org/show_bug.cgi?id=196496
254         <rdar://problem/49521634>
255
256         Reviewed by Chris Dumez.
257
258         Add new API tests (see WebKit ChangeLog for more detail).
259
260         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
261         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
262         (TEST):
263
264 2019-04-02  David Kilzer  <ddkilzer@apple.com>
265
266         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
267         <https://webkit.org/b/196499>
268
269         Reviewed by Alexey Proskuryakov.
270
271         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
272         ENABLE_ADDRESS_SANITIZER.
273
274 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
275
276         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
277         https://bugs.webkit.org/show_bug.cgi?id=182757
278
279         Reviewed by Don Olmstead.
280
281         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
282         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
283
284 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
285
286         run-api-tests: Upload test results
287         https://bugs.webkit.org/show_bug.cgi?id=196323
288         <rdar://problem/49356714>
289
290         Reviewed by Lucas Forschler.
291
292         * Scripts/webkitpy/api_tests/manager.py:
293         (Manager):
294         (Manager.run): Upload results to a results database.
295         * Scripts/webkitpy/api_tests/run_api_tests.py:
296         (parse_args): Add upload arguments.
297         * Scripts/webkitpy/port/base.py:
298         (Port):
299         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
300         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
301         with commits from any other associated repositories.
302         * Scripts/webkitpy/port/device.py:
303         (Device):
304         (Device.build_version): Access build_versoin of underlying platform device.
305         * Scripts/webkitpy/port/ios_simulator_unittest.py:
306         (IOSSimulatorTest):
307         (IOSSimulatorTest.test_configuration_for_upload):
308         * Scripts/webkitpy/port/device_port.py:
309         (DevicePort):
310         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
311         the same as the machine uploading results.
312         * Scripts/webkitpy/port/mac.py:
313         (MacPort):
314         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
315         * Scripts/webkitpy/port/mac_unittest.py:
316         (MacTest):
317         (MacTest.test_configuration_for_upload):
318         * Scripts/webkitpy/xcode/simulated_device.py:
319         (SimulatedDeviceManager._create_device_with_runtime):
320         (SimulatedDevice.__init__): Create simulated device with a build_version.
321         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
322         (test_existing_simulator):
323
324 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
325
326         Remove extra newline characters (Follow-up fix to r243707)
327
328         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
329
330 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
331
332         [ews-app] Use API_KEY to accept results data
333         https://bugs.webkit.org/show_bug.cgi?id=196461
334
335         Reviewed by Dewei Zhu.
336
337         * BuildSlaveSupport/ews-app/ews/views/results.py:
338         (Results.post): Validate EWS_API_KEY before accepting any data.
339         * BuildSlaveSupport/ews-build/events.py:
340         (Events.sendData): Send EWS_API_KEY if available along with event data.
341
342 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
343
344         Unable to copy and paste a PDF from Notes into Mail compose body
345         https://bugs.webkit.org/show_bug.cgi?id=196442
346         <rdar://problem/48573098>
347
348         Reviewed by Tim Horton.
349
350         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
351         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
352         to be specified on the item providers.
353
354         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
355         (TestWebKitAPI::mapItemForTesting):
356         (TestWebKitAPI::contactItemForTesting):
357
358 2019-04-01  Tim Horton  <timothy_horton@apple.com>
359
360         Make UIWKDocumentContext rects per-character instead of per-word
361         https://bugs.webkit.org/show_bug.cgi?id=196459
362
363         Reviewed by Wenson Hsieh.
364
365         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
366         (TEST):
367         Adjust test results due to switching to per-character rects.
368
369 2019-04-01  Chris Dumez  <cdumez@apple.com>
370
371         UIProcess crash when a prewarmed process is terminated
372         https://bugs.webkit.org/show_bug.cgi?id=196451
373         <rdar://problem/49245471>
374
375         Reviewed by Geoffrey Garen.
376
377         Add API test coverage.
378
379         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
380         (TEST):
381
382 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
383
384         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
385         https://bugs.webkit.org/show_bug.cgi?id=196449
386
387         Reviewed by Lucas Forschler.
388
389         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
390         (StatusBubble.get_os_details): Method to get OS and Xcode details.
391         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
392         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
393
394 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
395
396         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
397         https://bugs.webkit.org/show_bug.cgi?id=196444
398
399         Reviewed by Lucas Forschler.
400
401         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
402
403 2019-04-01  Alex Christensen  <achristensen@webkit.org>
404
405         Add SPI to canonicalize NSURLs with WTF::URL
406         https://bugs.webkit.org/show_bug.cgi?id=196415
407         <rdar://problem/44980271>
408
409         Reviewed by Darin Adler.
410
411         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
412         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
413         (TestWebKitAPI::TEST):
414
415 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
416
417         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
418         https://bugs.webkit.org/show_bug.cgi?id=196441
419
420         Reviewed by Carlos Garcia Campos.
421
422         Don't cache the wpe_view_backend object that might not exist yet at the
423         time of EventSenderProxy constructor invocation, but instead retrieve
424         that object whenever it's required for event dispatching. This should
425         avoid crashes in this constructor now that it's invoked before any
426         PlatformWindow has been set up (as changed in r243496).
427
428         * WebKitTestRunner/EventSenderProxy.h:
429         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
430         (WTR::viewBackend):
431         (WTR::EventSenderProxy::EventSenderProxy):
432         (WTR::EventSenderProxy::mouseDown):
433         (WTR::EventSenderProxy::mouseUp):
434         (WTR::EventSenderProxy::mouseMoveTo):
435         (WTR::EventSenderProxy::mouseScrollBy):
436         (WTR::EventSenderProxy::keyDown):
437         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
438
439 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
440
441         [Win][WebKit] MiniBrowser should support high DPI display
442         https://bugs.webkit.org/show_bug.cgi?id=196391
443
444         Reviewed by Alex Christensen.
445
446         * MiniBrowser/win/WebKitBrowserWindow.cpp:
447         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
448         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
449         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
450
451 2019-03-31  Sam Weinig  <weinig@apple.com>
452
453         Remove more i386 specific configurations
454         https://bugs.webkit.org/show_bug.cgi?id=196430
455
456         Reviewed by Alexey Proskuryakov.
457
458         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
459         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
460
461 2019-03-31  Andy Estes  <aestes@apple.com>
462
463         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
464         https://bugs.webkit.org/show_bug.cgi?id=196433
465         <rdar://problem/49293305>
466
467         Reviewed by Tim Horton.
468
469         Enhanced API test coverage to include all navigation response policy decisions in both
470         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
471
472         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
473         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
474         (TestWebKitAPI::TEST):
475         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
476         (readFile):
477         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
478         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
479         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
480         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
481         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
482         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
483         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
484         (-[QuickLookDelegate _downloadDidStart:]):
485         (-[QuickLookDelegate _download:didReceiveResponse:]):
486         (-[QuickLookDelegate _download:didReceiveData:]):
487         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
488         (-[QuickLookDelegate _downloadDidFinish:]):
489         (-[QuickLookDelegate _download:didFailWithError:]):
490         (-[QuickLookDelegate _downloadDidCancel:]):
491         (-[QuickLookDelegate verifyDownload]):
492         (runTest):
493         (runTestDecideBeforeLoading):
494         (runTestDecideAfterLoading):
495         (TEST):
496         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
497         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
498         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
499         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
500         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
501         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
502         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
503         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
504         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
505         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
506         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
507         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
508         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
509         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
510
511 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
512
513         [CMake] add testdfg as target with build-jsc
514         https://bugs.webkit.org/show_bug.cgi?id=196393
515
516         Reviewed by Saam Barati.
517
518         Added testdfg as one of the targets to build when
519         using CMake.
520
521         * Scripts/build-jsc:
522
523 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
524
525         Delete WebMetal implementation in favor of WebGPU
526         https://bugs.webkit.org/show_bug.cgi?id=195418
527
528         Reviewed by Dean Jackson.
529
530         * DumpRenderTree/mac/DumpRenderTree.mm:
531         (enableExperimentalFeatures):
532         (resetWebPreferencesToConsistentValues):
533         * Scripts/webkitperl/FeatureList.pm:
534         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
535         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
536         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
537         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
538         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
539         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
540         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
541         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
542         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
543         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
544         (WTR::InjectedBundle::beginTesting):
545         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
546         (WTR::TestRunner::setWebMetalEnabled): Deleted.
547         * WebKitTestRunner/InjectedBundle/TestRunner.h:
548
549 2019-03-29  Chris Dumez  <cdumez@apple.com>
550
551         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
552         https://bugs.webkit.org/show_bug.cgi?id=196405
553         <rdar://problem/49428130>
554
555         Reviewed by Wenson Hsieh.
556
557         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
558         the popover presentation methods to be no-ops. Use this in the new test added in
559         r243523 so that we do not swizzle those methods for all tests. This is needed because
560         those WatchOS tests rely on the popover getting presented and interactive.
561
562         * WebKitTestRunner/TestController.cpp:
563         (WTR::updateTestOptionsFromTestHeader):
564         * WebKitTestRunner/TestController.h:
565         * WebKitTestRunner/TestOptions.h:
566         (WTR::TestOptions::hasSameInitializationOptions const):
567         * WebKitTestRunner/ios/TestControllerIOS.mm:
568         (WTR::TestController::platformInitialize):
569         (WTR::TestController::platformResetStateToConsistentValues):
570
571 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
572
573         [Curl] Add Server Trust Evaluation Support.
574         https://bugs.webkit.org/show_bug.cgi?id=191646
575
576         Reviewed by Fujii Hironori.
577
578         Implemented MiniBrowser UI for asking if user trusts the server.
579
580         * MiniBrowser/win/Common.cpp:
581         (askServerTrustEvaluation):
582         (replaceString):
583         * MiniBrowser/win/Common.h:
584         * MiniBrowser/win/MiniBrowserLib.rc:
585         * MiniBrowser/win/MiniBrowserLibResource.h:
586         * MiniBrowser/win/WebKitBrowserWindow.cpp:
587         (createPEMString):
588         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
589         (WebKitBrowserWindow::canTrustServerCertificate):
590         * MiniBrowser/win/WebKitBrowserWindow.h:
591
592 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
593
594         Implement ResizeObserver.
595         https://bugs.webkit.org/show_bug.cgi?id=157743
596
597         Reviewed by Simon Fraser.
598
599         Support resizeObserverEnabled webPreferences.
600
601         * DumpRenderTree/TestOptions.cpp:
602         (TestOptions::TestOptions):
603         * DumpRenderTree/TestOptions.h:
604         * DumpRenderTree/mac/DumpRenderTree.mm:
605         (setWebPreferencesForTestOptions):
606         * DumpRenderTree/win/DumpRenderTree.cpp:
607         (enableExperimentalFeatures):
608         * Scripts/webkitperl/FeatureList.pm:
609         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
610
611 2019-03-28  John Wilander  <wilander@apple.com>
612
613         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
614         https://bugs.webkit.org/show_bug.cgi?id=196281
615         <rdar://problem/48938748>
616
617         Reviewed by Alex Christensen.
618
619         This patch adds the function isStatisticsHasLocalStorage() to the
620         TestRunner. With it, the page can query the WebsiteDataStore in the
621         UI process to make sure that it sees LocalStorage.
622
623         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
624         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
625         (WTR::TestRunner::isStatisticsHasLocalStorage):
626         * WebKitTestRunner/InjectedBundle/TestRunner.h:
627         * WebKitTestRunner/TestController.cpp:
628         (WTR::TestController::isStatisticsHasLocalStorage):
629         * WebKitTestRunner/TestController.h:
630         * WebKitTestRunner/TestInvocation.cpp:
631         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
632
633 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
634
635         API::Data::createWithoutCopying should do a null check before calling CFRelease
636         https://bugs.webkit.org/show_bug.cgi?id=196276
637         <rdar://problem/48059859>
638
639         Reviewed by Alex Christensen.
640
641         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
642
643         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
644         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
645         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
646         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
647         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
648         (TestWebKitAPI::TEST):
649
650 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
651
652         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
653         https://bugs.webkit.org/show_bug.cgi?id=186276
654
655         Reviewed by Carlos Garcia Campos.
656
657         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
658         (webViewLoadChanged):
659         (testWebResourceGetDataError):
660         (testWebResourceGetDataEmpty):
661         (beforeAll):
662         (webViewloadChanged): Deleted.
663
664 2019-03-27  Andy Estes  <aestes@apple.com>
665
666         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
667         https://bugs.webkit.org/show_bug.cgi?id=196317
668
669         Reviewed by Dan Bernstein.
670
671         package-root copies built products into a staging directory using ditto(1), which does not
672         follow symbolic links as it traverses a directory. Now that the files in
673         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
674         itself, these become broken links when ditto'd into the staging directory.
675
676         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
677
678         * Scripts/package-root:
679
680 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
681
682         [ews-app] Update display text of Submit for ews analysis
683         https://bugs.webkit.org/show_bug.cgi?id=196309
684
685         Reviewed by Dewei Zhu.
686
687         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
688
689 2019-03-27  David Kilzer  <ddkilzer@apple.com>
690
691         run-webkit-tests should check for leaks in WebKit processes
692         <https://webkit.org/b/193772>
693         <rdar://problem/46526680>
694
695         Reviewed by Ryosuke Niwa.
696
697         This works by doing the following:
698         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
699           The list of child processes are returned one per line:
700           process.name: pid
701         - Run the "#LIST CHILD PROCESSES" command just before the
702           "#CHECK FOR WORLD LEAKS" command, and store the list of child
703           processes on the ServerProcess object.
704         - When the `--leaks` switch is handled, run check_for_leaks() on
705           each child process after the main test harness.
706
707         * DumpRenderTree/mac/DumpRenderTree.mm:
708         (handleControlCommand):
709         - Use strncmp() instead of strcmp().
710         - Add support for handling "#LIST CHILD PROCESSES" command.
711
712         * Scripts/webkitpy/port/base.py:
713         (Port.check_for_leaks):
714         * Scripts/webkitpy/port/darwin.py:
715         (DarwinPort.check_for_leaks):
716         - Rename redundant 'process_pid' argument to 'process_id'.
717
718         * Scripts/webkitpy/port/driver.py:
719         (Driver.do_post_tests_work):
720         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
721           longer the only command this sends to WebKitTestRunner.
722         - If the `--leaks` switch is present, send the
723           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
724           result using Port.set_webkit_processes().
725         (Driver._parse_child_processes_output):
726         - Add helper method to parse list of child process names and
727           process IDs returned from WebKitTestRunner.
728
729         * Scripts/webkitpy/port/ios_device.py:
730         (IOSDevicePort.check_for_leaks):
731         - Rename redundant 'process_pid' argument to 'process_id'.
732
733         * Scripts/webkitpy/port/leakdetector.py:
734         (LeakDetector._parse_leaks_output):
735         - Return early if there is no leaks_output.
736         (LeakDetector.check_for_leaks):
737         - Rename redundant 'process_pid' argument to 'process_id'.
738
739         * Scripts/webkitpy/port/server_process.py:
740         (ServerProcess.__init__):
741         (ServerProcess.child_processes):
742         (ServerProcess.set_child_processes):
743         - Add instance variable to Port to store list of child process
744           names and process IDs returned from WebKitTestRunner.
745         (ServerProcess._start):
746         - Clear self._child_processes.
747         (ServerProcess.stop):
748         - If self._child_processes is set, call
749           self._port.check_for_leaks() for each child process.
750
751         * Scripts/webkitpy/port/server_process_unittest.py:
752         (TrivialMockPort.check_for_leaks):
753         - Rename redundant 'process_pid' argument to 'process_id'.
754
755         * Scripts/webkitpy/port/simulator_process.py:
756         (SimulatorProcess.stop):
757         - If self._child_processes is set, call
758           self._port.check_for_leaks() for each child process.
759
760         * Scripts/webkitpy/port/watch_device.py:
761         (WatchDevicePort.check_for_leaks):
762         - Rename redundant 'process_pid' argument to 'process_id'.
763
764         * WebKitTestRunner/TestController.cpp:
765         (WTR::TestController::dumpResponse):
766         - Extract method from findAndDumpWorldLeaks() so that it may be
767           reused by findAndDumpWebKitProcessIdentifiers().
768         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
769         - Add method to output process name and process ID of both the
770           WebContent and Networking processes.
771         (WTR::TestController::findAndDumpWorldLeaks):
772         - Fix missing newline in output when there were no abandoned
773           documents.
774         - Call dumpResponse() for extracted code.
775         (WTR::TestController::handleControlCommand):
776         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
777         - Use strncmp() instead of strcmp().
778         - Call findAndDumpWebKitProcessIdentifiers() when
779           "#LIST CHILD PROCESSES" command is sent.
780         * WebKitTestRunner/TestController.h:
781         (WTR::TestController::dumpResponse):
782         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
783         - Declare methods.
784
785 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
786
787         Unreviewed. Add GLib API test cases after r243434.
788
789         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
790         (testWebViewActiveURI):
791         (serverCallback):
792         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
793         (sendRequestCallback):
794
795 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
796
797         Geolocation request not complete when watch request was started in a different web process
798         https://bugs.webkit.org/show_bug.cgi?id=195996
799
800         Reviewed by Alex Christensen.
801
802         Add a test case.
803
804         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
805         (TestWebKitAPI::runJavaScriptAlert):
806         (TestWebKitAPI::TEST):
807
808 2019-03-26  Keith Rollin  <krollin@apple.com>
809
810         Update the way generate-xcfilelists returns strings from functions
811         https://bugs.webkit.org/show_bug.cgi?id=195975
812         <rdar://problem/49040807>
813
814         Reviewed by Dean Jackson.
815
816         There are places where generate-xcfilelists executes assignments with
817         statements like:
818
819             FOO=$(some_function)
820
821         where "some_function" return a string by echoing it. E.g.
822
823             some_function()
824             {
825                 echo "Hello, World"
826             }
827
828         This is a common idiom, but it has a problem if "some_function" needs
829         to call "exit" in an attempt to halt the entire script right then and
830         there. Since "some_function" is called inside of $(), it's being
831         executed in a sub-shell. Calling exit in that sub-shell simply exits
832         that shell; it doesn't not exit the outer shell in which the main part
833         of the script is still running. As such, the main script keeps
834         executing when the intent was for the script to halt.
835
836         The solution to this is to use a different idiom for returning
837         strings. The one we now is to pass in the name of the variable to
838         receive the string result:
839
840             some_function()
841             {
842                 variable_name=$1
843                 eval $variable_name ="Hello, World"
844             }
845
846         The call site now looks like
847
848             some_function FOO
849
850         Because there's no invocation of a sub-shell, some_function can now
851         call "exit" if it wants to, and the entire script will exit at that
852         point.
853
854         * Scripts/generate-xcfilelists:
855
856 2019-03-26  Chris Dumez  <cdumez@apple.com>
857
858         Add basic layout test coverage for File Picker on iOS
859         https://bugs.webkit.org/show_bug.cgi?id=196265
860
861         Reviewed by Wenson Hsieh.
862
863         Add layout test infrastructure to test the file picker on iOS.
864
865         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
866         (WTR::UIScriptController::dismissFilePicker):
867         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
868         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
869         (WTR::UIScriptController::dismissFilePicker):
870         * TestRunnerShared/UIScriptContext/UIScriptController.h:
871         * WebKitTestRunner/TestController.cpp:
872         (WTR::TestController::createWebViewWithOptions):
873         (WTR::updateTestOptionsFromTestHeader):
874         * WebKitTestRunner/TestOptions.h:
875         (WTR::TestOptions::hasSameInitializationOptions const):
876         * WebKitTestRunner/ios/TestControllerIOS.mm:
877         (overridePresentViewController):
878         (WTR::TestController::platformInitialize):
879         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
880         (WTR::UIScriptController::dismissFilePicker):
881
882 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
883
884         Implement async paste method on UIWKInteractionViewProtocol
885         https://bugs.webkit.org/show_bug.cgi?id=196267
886         <rdar://problem/49236346>
887
888         Reviewed by Tim Horton.
889
890         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
891         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
892         are now a part of all iOS 12 internal SDKs.
893
894         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
895
896         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
897         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
898
899         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
900         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
901         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
902         * TestWebKitAPI/ios/UIKitSPI.h:
903
904 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
905
906         [ews-build] Use PostgreSQL for ews.webkit.org database
907         https://bugs.webkit.org/show_bug.cgi?id=196270
908
909         Reviewed by Lucas Forschler.
910
911         * BuildSlaveSupport/ews-app/ews-app/settings.py:
912
913 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
914
915         [ews] Reset simctl states on reboot
916         https://bugs.webkit.org/show_bug.cgi?id=196260
917
918         Rubber-stamped by Aakash Jain.
919
920         * EWSTools/start-queue-mac.sh:
921
922 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
923
924         [ews-build] Use PostgreSQL for ews-build database
925         https://bugs.webkit.org/show_bug.cgi?id=196229
926
927         Reviewed by Lucas Forschler.
928
929         * BuildSlaveSupport/ews-build/master.cfg:
930
931 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
932
933         [ews-build] Get master_hostname dynamically in master.cfg
934         https://bugs.webkit.org/show_bug.cgi?id=196255
935
936         Reviewed by Lucas Forschler.
937
938         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
939         send events data in test mode.
940
941 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
942
943         [ews-app] Set db_constraint to False for Foreign Keys
944         https://bugs.webkit.org/show_bug.cgi?id=196252
945
946         Reviewed by Lucas Forschler.
947
948         * BuildSlaveSupport/ews-app/ews/models/build.py:
949         * BuildSlaveSupport/ews-app/ews/models/step.py:
950
951 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
952
953         [ews-build] is_test_mode_enabled should default to True
954         https://bugs.webkit.org/show_bug.cgi?id=196248
955
956         Reviewed by Lucas Forschler.
957
958         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
959
960 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
961
962         [ews-app] Add webkitperl to ENABLED_QUEUES
963         https://bugs.webkit.org/show_bug.cgi?id=196253
964
965         Reviewed by Lucas Forschler.
966
967         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
968
969 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
970
971         Address NSWindow sometimes using WebKitTestRunnerEvent too early
972         https://bugs.webkit.org/show_bug.cgi?id=196211
973         rdar://problem/49110552
974
975         Reviewed by Tim Horton.
976
977         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
978         Make sure that EventSenderProxy always exists when running tests. We used to create
979         it when resetting before the first test, which is a bit too late.
980
981         * WebKitTestRunner/TestController.h:
982         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
983         (WTR::TestController::platformCreateWebView):
984         (WTR::TestController::platformCreateOtherPage):
985         (WTR::TestController::finishCreatingPlatformWebView):
986         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
987         (WTR::PlatformWebView::PlatformWebView):
988         Moved some code that made NSWindow use NSEvent during web view creation. We may
989         need to move more if some other case us found, but this is enough for now.
990
991 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
992
993         Unreviewed. Fix typo in GLib geolocation API after r243285.
994
995         gelocation -> geolocation.
996
997         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
998         (testGeolocationManagerWatchPosition):
999
1000 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1001
1002         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1003         https://bugs.webkit.org/show_bug.cgi?id=196213
1004
1005         Reviewed by Geoff Garen.
1006
1007         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1008         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1009         (credentialWithIdentityAndKeychainPath):
1010         (-[ChallengeDelegate webView:didFinishNavigation:]):
1011         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1012         (TestWebKitAPI::TEST):
1013
1014 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1015
1016         Expected shouldn't assume its contained types are copyable
1017         https://bugs.webkit.org/show_bug.cgi?id=195986
1018
1019         Reviewed by JF Bastien.
1020
1021         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1022         (TestWebKitAPI::NonCopyable::operator== const):
1023         (TestWebKitAPI::NonCopyable::operator!= const):
1024         (TestWebKitAPI::TEST):
1025
1026 2019-03-25  Tim Horton  <timothy_horton@apple.com>
1027
1028         Remove some now-unnecessary dynamic class lookup
1029         https://bugs.webkit.org/show_bug.cgi?id=196237
1030
1031         Reviewed by Simon Fraser.
1032
1033         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1034         (makeRequest):
1035         (TEST):
1036
1037 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
1038
1039         Unreviewed, rolling out r243450.
1040
1041         AppleWin and WinCairo port builds get broken.
1042
1043         Reverted changeset:
1044
1045         "Add test for fix of #196095"
1046         https://bugs.webkit.org/show_bug.cgi?id=196097
1047         https://trac.webkit.org/changeset/243450
1048
1049 2019-03-25  Commit Queue  <commit-queue@webkit.org>
1050
1051         Unreviewed, rolling out r243465.
1052         https://bugs.webkit.org/show_bug.cgi?id=196226
1053
1054         the test doesn't build (Requested by thorton on #webkit).
1055
1056         Reverted changeset:
1057
1058         "Do not terminate the NetworkProcess if a third party
1059         application sends a NSCredential with a SecIdentityRef"
1060         https://bugs.webkit.org/show_bug.cgi?id=196213
1061         https://trac.webkit.org/changeset/243465
1062
1063 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1064
1065         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1066         https://bugs.webkit.org/show_bug.cgi?id=196213
1067
1068         Reviewed by Geoff Garen.
1069
1070         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1071         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1072         (credentialWithIdentityAndKeychainPath):
1073         (-[ChallengeDelegate webView:didFinishNavigation:]):
1074         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1075         (TestWebKitAPI::TEST):
1076
1077 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1078
1079         [ews-build] Gracefully handle missing patch_id in events
1080         https://bugs.webkit.org/show_bug.cgi?id=196216
1081
1082         Reviewed by Lucas Forschler.
1083
1084         * BuildSlaveSupport/ews-build/events.py:
1085
1086 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1087
1088         [ews-build] use lz4 compression for improving buildbot performance
1089         https://bugs.webkit.org/show_bug.cgi?id=196155
1090
1091         Reviewed by Lucas Forschler.
1092
1093         * BuildSlaveSupport/ews-build/master.cfg:
1094
1095 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1096
1097         Pull some API testing helper methods out of TestWKWebView
1098         https://bugs.webkit.org/show_bug.cgi?id=196212
1099
1100         Reviewed by Tim Horton.
1101
1102         Refactor some more API testing utility methods, so that they can be used in
1103         tests that do not use TestWKWebView.
1104
1105         * TestWebKitAPI/cocoa/TestWKWebView.h:
1106         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1107         (-[WKWebView loadTestPageNamed:]):
1108         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1109         (-[WKWebView synchronouslyLoadHTMLString:]):
1110         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1111         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1112         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1113         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1114         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1115
1116 2019-03-25  Jer Noble  <jer.noble@apple.com>
1117
1118         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1119         https://bugs.webkit.org/show_bug.cgi?id=196097
1120
1121         Reviewed by Eric Carlson.
1122
1123         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1124
1125         * DumpRenderTree/mac/DumpRenderTree.mm:
1126         (resetWebPreferencesToConsistentValues):
1127         * WebKitTestRunner/TestController.cpp:
1128         (WTR::TestController::resetPreferencesToConsistentValues):
1129
1130 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1131
1132         Pull IPadUserInterfaceSwizzler out into a separate header file
1133         https://bugs.webkit.org/show_bug.cgi?id=196193
1134
1135         Reviewed by Anders Carlsson.
1136
1137         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1138         be used in other API tests.
1139
1140         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1141         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1142         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1143         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1144         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1145         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1146         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1147
1148 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1149
1150         Remove NavigatorContentUtils in WebCore/Modules
1151         https://bugs.webkit.org/show_bug.cgi?id=196070
1152
1153         Reviewed by Alex Christensen.
1154
1155         NavigatorContentUtils was to support the custom scheme spec [1].
1156         However, in WebKit side, no port has supported the feature in
1157         WebKit layer after EFL port was removed. So there has been the
1158         only IDL implementation of the NavigatorContentUtils in WebCore.
1159         So we don't need to keep the implementation in WebCore anymore.
1160
1161         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1162
1163         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1164
1165 2019-03-24  Andy Estes  <aestes@apple.com>
1166
1167         [watchOS] Remove unused Proximity Networking code
1168         https://bugs.webkit.org/show_bug.cgi?id=196188
1169
1170         Reviewed by Tim Horton.
1171
1172         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1173         (TEST):
1174
1175 2019-03-23  Keith Miller  <keith_miller@apple.com>
1176
1177         Refactor clz/ctz and fix getLSBSet.
1178         https://bugs.webkit.org/show_bug.cgi?id=196162
1179
1180         Reviewed by Saam Barati.
1181
1182         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1183
1184         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1185         (TestWebKitAPI::TEST):
1186
1187 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1188
1189         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1190         https://bugs.webkit.org/show_bug.cgi?id=196143
1191
1192         Reviewed by Michael Catanzaro.
1193
1194         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1195         directories.
1196
1197         * Scripts/webkitpy/style/checkers/cpp.py:
1198         (check_identifier_name_in_declaration):
1199         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1200         (WebKitStyleTest.test_names):
1201
1202 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1203
1204         [Flatpak] Manifest expanding fails for qt WPE extension
1205         https://bugs.webkit.org/show_bug.cgi?id=196148
1206
1207         Reviewed by Alex Christensen.
1208
1209         * flatpak/flatpakutils.py:
1210         (expand_submodules_recurse): The last recurse manifest expand
1211         iteration might lead to a single module so take it into account
1212         and don't try to recurse further.
1213
1214 2019-03-22  Chris Dumez  <cdumez@apple.com>
1215
1216         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1217         https://bugs.webkit.org/show_bug.cgi?id=195348
1218         <rdar://problem/48622090>
1219
1220         Reviewed by Alex Christensen.
1221
1222         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1223         to NO when test.options().shouldIgnoreMetaViewport is false.
1224
1225         * WebKitTestRunner/ios/TestControllerIOS.mm:
1226         (WTR::TestController::platformConfigureViewForTest):
1227
1228 2019-03-22  Chris Dumez  <cdumez@apple.com>
1229
1230         Prewarmed processes should be usable with any website data store
1231         https://bugs.webkit.org/show_bug.cgi?id=196104
1232
1233         Reviewed by Alex Christensen.
1234
1235         Add API test coverage.
1236
1237         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1238         (runInitialWarmedProcessUsedTest):
1239         (TEST):
1240
1241 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1242
1243         Back out local changes to Alex's Subversion working directory
1244
1245         They were accidentally committed.
1246
1247         * Scripts/webkitpy/common/system/abstractexecutive.py:
1248         (AbstractExecutive.wait_newest):
1249         * Scripts/webkitpy/common/system/executive.py:
1250         (Executive.running_pids):
1251         * Scripts/webkitpy/common/system/executive_mock.py:
1252         (MockExecutive.running_pids):
1253         * Scripts/webkitpy/common/system/executive_unittest.py:
1254         (ExecutiveTest.serial_test_running_pids):
1255         * Scripts/webkitpy/port/darwin.py:
1256         (DarwinPort.check_for_leaks):
1257         * Scripts/webkitpy/port/leakdetector.py:
1258         (LeakDetector.check_for_leaks):
1259         - This was the hack attached to Bug 193772.
1260
1261         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1262         (+[WebKitTestRunnerEvent mouseLocation]):
1263         - This works around a crash on an internal build.
1264
1265 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1266
1267         Fix the build after r243354
1268         https://bugs.webkit.org/show_bug.cgi?id=196138
1269         <rdar://problem/49145951>
1270
1271         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1272         (TEST):
1273         * TestWebKitAPI/ios/UIKitSPI.h:
1274
1275 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1276
1277         Adopt UIWKDocumentContext
1278         https://bugs.webkit.org/show_bug.cgi?id=196040
1279         <rdar://problem/48642440>
1280
1281         Reviewed by Ryosuke Niwa.
1282
1283         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1284         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1285         (makeRequest):
1286         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1287         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1288         (applyStyle):
1289         (TEST):
1290         Add tests for UIWKDocumentContext.
1291
1292         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1293         (TEST):
1294         (recursiveFindWKContentView): Deleted.
1295         * TestWebKitAPI/cocoa/TestWKWebView.h:
1296         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1297         (recursiveFindWKContentView):
1298         (-[TestWKWebView wkContentView]):
1299         * TestWebKitAPI/ios/UIKitSPI.h:
1300         Share the WKContentView finding code between tests.
1301
1302 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1303
1304         [iOS WK2] Turn on async overflow scrolling by default
1305         https://bugs.webkit.org/show_bug.cgi?id=196011
1306         rdar://problem/48453859
1307
1308         Reviewed by Antti Koivisto.
1309         
1310         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1311         since so many basic layout tests have different results when compositing is triggered for
1312         overflow.
1313         
1314         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1315
1316         * WebKitTestRunner/TestController.cpp:
1317         (WTR::TestController::resetPreferencesToConsistentValues):
1318
1319 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1320
1321         [ews-build] Retry API test in case of failures
1322         https://bugs.webkit.org/show_bug.cgi?id=196004
1323
1324         Reviewed by Lucas Forschler.
1325
1326         * BuildSlaveSupport/ews-build/steps.py:
1327         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1328         (CompileWebKitToT.doStepIf): Ditto.
1329         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1330         (ReRunAPITests): Re-run API tests.
1331         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1332         (RunAPITestsWithoutPatch): Run API tests without patch.
1333         (RunAPITestsWithoutPatch.doStepIf):
1334         (RunAPITestsWithoutPatch.hideStepIf):
1335         (RunAPITestsWithoutPatch.evaluateCommand):
1336         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1337         (AnalyzeAPITestsResults.start):
1338         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1339         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1340         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1341         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1342
1343 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1344
1345         [ews-build] Update queues configurations
1346         https://bugs.webkit.org/show_bug.cgi?id=196074
1347
1348         Reviewed by Dewei Zhu.
1349
1350         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1351         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1352
1353 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1354
1355         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1356         https://bugs.webkit.org/show_bug.cgi?id=195680
1357         <rdar://problem/48903534>
1358
1359         Unreviewed infrastructure fix.
1360
1361         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1362         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1363
1364 2019-03-21  Andy Estes  <aestes@apple.com>
1365
1366         [iOS] Apple Pay should be available in documents with no user agent scripts
1367         https://bugs.webkit.org/show_bug.cgi?id=196061
1368         <rdar://problem/48649391>
1369
1370         Reviewed by Brady Eidson.
1371
1372         Added API tests and related infrastructure.
1373
1374         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1375         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1376         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1377         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1378         (TestWebKitAPI::TEST):
1379         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1380         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1381         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1382         * TestWebKitAPI/cocoa/TestProtocol.mm:
1383         (-[TestProtocol startLoading]):
1384         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1385         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1386         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1387         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1388
1389 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1390
1391         REGRESSSION (r243297): webkitpy tests broken
1392         https://bugs.webkit.org/show_bug.cgi?id=196108
1393
1394         Reviewed by Aakash Jain.
1395
1396         r243297 updated contributors.json, which broke a few unit tests.
1397
1398         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1399         (IRCCommandTest.test_whois):
1400         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1401
1402 2019-03-21  Chris Dumez  <cdumez@apple.com>
1403
1404         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1405         https://bugs.webkit.org/show_bug.cgi?id=196041
1406         <rdar://problem/49083230>
1407
1408         Reviewed by Alex Christensen.
1409
1410         Add API test coverage.
1411
1412         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1413         (TEST):
1414
1415 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1416
1417         Add SPI to inform applications of WKContentRuleList actions
1418         https://bugs.webkit.org/show_bug.cgi?id=195965
1419         <rdar://problem/42664365>
1420
1421         Reviewed by Geoff Garen.
1422
1423         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1424         (TestWebKitAPI::allActionsForResourceLoad):
1425         (TestWebKitAPI::testRequest):
1426         (TestWebKitAPI::TEST_F):
1427         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1428         (Notification::description):
1429         (Notification::operator== const):
1430         (toVector):
1431         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1432         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1433         (makeContentRuleList):
1434         (TEST):
1435         (makeWarnContentRuleList): Deleted.
1436
1437 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1438
1439         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1440         https://bugs.webkit.org/show_bug.cgi?id=196088
1441
1442         Reviewed by Brian Burg.
1443
1444         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1445         Support checks when only one platform is specified. Also deprecate macosx() and
1446         force the use of macos() instead.
1447
1448         * Scripts/webkitpy/style/checkers/cpp.py:
1449         (check_min_versions_of_wk_api_available):
1450         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1451         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1452
1453 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1454
1455         Update status inactive committers' status to 'contributor'.
1456
1457         * Scripts/webkitpy/common/config/contributors.json:
1458
1459 2019-03-21  Xan Lopez  <xan@igalia.com>
1460
1461         [JSC][x86] Drop support for x87 floating point
1462         https://bugs.webkit.org/show_bug.cgi?id=194853
1463
1464         Reviewed by Don Olmstead.
1465
1466         Force SSE2 on x86/32bit builds.
1467
1468         * Scripts/webkitdirs.pm:
1469         (generateBuildSystemFromCMakeProject):
1470
1471 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1472
1473         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1474         https://bugs.webkit.org/show_bug.cgi?id=196073
1475
1476         Reviewed by Michael Catanzaro.
1477
1478         Add test cases to check functions and constructors with no arguments but receiving user data.
1479
1480         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1481         (checkUserData):
1482         (testJSCFunction):
1483         (fooCreateWithUserData):
1484         (testJSCClass):
1485
1486 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1487
1488         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1489
1490         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1491
1492         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1493
1494 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1495
1496         [GTK][WPE] Add API to provide geolocation information
1497         https://bugs.webkit.org/show_bug.cgi?id=195940
1498
1499         Reviewed by Michael Catanzaro.
1500
1501         Add a new test to check the new API.
1502
1503         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1504         (testGeolocationManagerCurrentPosition):
1505         (testGeolocationManagerWatchPosition):
1506         (beforeAll):
1507         (afterAll):
1508         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1509         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1510         (beforeAll): Ditto.
1511         * TestWebKitAPI/glib/CMakeLists.txt:
1512
1513 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1514
1515         [GLib] Returning G_TYPE_OBJECT from a method does not work
1516         https://bugs.webkit.org/show_bug.cgi?id=195574
1517
1518         Reviewed by Michael Catanzaro.
1519
1520         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1521
1522         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1523         (getGFile):
1524         (getParent):
1525         (createGString):
1526         (getGString):
1527         (getGStringCopyWillRaise):
1528         (getGStringCopy):
1529         (getGStringStr):
1530         (getGStringLen):
1531         (freeGString):
1532         (testJSCClass):
1533
1534 2019-03-20  Saam Barati  <sbarati@apple.com>
1535
1536         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1537         https://bugs.webkit.org/show_bug.cgi?id=195721
1538
1539         Reviewed by Filip Pizlo.
1540
1541         * Scripts/run-javascriptcore-tests:
1542
1543 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1544
1545         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1546         https://bugs.webkit.org/show_bug.cgi?id=196049
1547
1548         Reviewed by Tim Horton.
1549
1550         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1551         overflow scrolling in general, so rename it.
1552
1553         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1554
1555 2019-03-20  Daniel Bates  <dabates@apple.com>
1556
1557         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1558         https://bugs.webkit.org/show_bug.cgi?id=196031
1559         <rdar://problem/49078172>
1560
1561         Reviewed by Tim Horton.
1562
1563         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1564         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1565         same code path used when the Done button is pressed to dismiss the <select> picker.
1566
1567         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1568         (TestWebKitAPI::TEST):
1569
1570 2019-03-20  Chris Dumez  <cdumez@apple.com>
1571
1572         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1573         https://bugs.webkit.org/show_bug.cgi?id=196029
1574         <rdar://problem/48954651>
1575
1576         Reviewed by Tim Horton.
1577
1578         Add API test coverage.
1579
1580         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1581
1582 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1583
1584         [ews-build] Improve failure summary string for ApplyPatch step
1585         https://bugs.webkit.org/show_bug.cgi?id=195995
1586
1587         Reviewed by Alexey Proskuryakov.
1588
1589         * BuildSlaveSupport/ews-build/steps.py:
1590         (ApplyPatch.getResultSummary): Override getResultSummary.
1591
1592 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
1593
1594         AX: Implement support for new meter ARIA role
1595         https://bugs.webkit.org/show_bug.cgi?id=195966
1596
1597         Reviewed by Chris Fleizach.
1598
1599         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
1600         to AXLevelIndicator.
1601
1602         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1603
1604 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
1605
1606         [WebAuthN] Implement FIDO AppID extension
1607         https://bugs.webkit.org/show_bug.cgi?id=143491
1608         <rdar://problem/48298273>
1609
1610         Reviewed by Brent Fulgham.
1611
1612         Add a test that covers the new flag of convertToU2fSignCommand.
1613
1614         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
1615         (TestWebKitAPI::TEST):
1616         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1617         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
1618         (TestWebKitAPI::TEST):
1619
1620 2019-03-19  Keith Rollin  <krollin@apple.com>
1621
1622         Add support for more platforms to generate-xcfilelists
1623         https://bugs.webkit.org/show_bug.cgi?id=195977
1624
1625         Reviewed by Alexey Proskuryakov.
1626
1627         generate-xcfilelists incorrectly complains when involved with building
1628         WebKit for iphonesimulator:
1629
1630             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
1631             …
1632             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
1633
1634         Address this by teaching generate-xcfilelists about more platforms.
1635
1636         * Scripts/generate-xcfilelists:
1637
1638 2019-03-19  John Wilander  <wilander@apple.com>
1639
1640         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
1641         https://bugs.webkit.org/show_bug.cgi?id=195923
1642         <rdar://problem/49001272>
1643
1644         Reviewed by Alex Christensen.
1645
1646         This patch does the following to the TestRunner:
1647         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
1648         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
1649         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
1650
1651         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1652         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1653         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1654         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1655         * WebKitTestRunner/TestController.cpp:
1656         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1657         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1658         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1659         * WebKitTestRunner/TestController.h:
1660         * WebKitTestRunner/TestInvocation.cpp:
1661         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1662
1663 2019-03-19  Christopher Reid  <chris.reid@sony.com>
1664
1665         [CMake] Support more clang and gcc sanitizers
1666         https://bugs.webkit.org/show_bug.cgi?id=195956
1667
1668         Reviewed by Michael Catanzaro.
1669
1670         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
1671
1672 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1673
1674         [ews-build] Improve summary for PrintConfiguration step
1675         https://bugs.webkit.org/show_bug.cgi?id=195945
1676
1677         Reviewed by Lucas Forschler.
1678
1679         * BuildSlaveSupport/ews-build/steps.py:
1680         (PrintConfiguration.getResultSummary): Override getResultSummary.
1681
1682 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1683
1684         [ews-build] Improve summary for CheckOutSource step
1685         https://bugs.webkit.org/show_bug.cgi?id=195963
1686
1687         Reviewed by Lucas Forschler.
1688
1689         * BuildSlaveSupport/ews-build/steps.py:
1690         (CheckOutSource.getResultSummary):
1691
1692 2019-03-19  Daniel Bates  <dabates@apple.com>
1693
1694         [iOS] Focus not preserved when switching between tabs
1695         https://bugs.webkit.org/show_bug.cgi?id=195820
1696         <rdar://problem/43614450>
1697
1698         Reviewed by Brent Fulgham.
1699
1700         Add tests to ensure that we restore focus when resigning and becoming first responder.
1701
1702         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1703         (TestWebKitAPI::TEST):
1704
1705 2019-03-19  Alex Christensen  <achristensen@webkit.org>
1706
1707         Make WTFLogChannelState and WTFLogLevel enum classes
1708         https://bugs.webkit.org/show_bug.cgi?id=195904
1709
1710         Reviewed by Eric Carlson.
1711
1712         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1713         (TestWebKitAPI::TEST_F):
1714
1715 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1716
1717         [GStreamer][EME] Backported mssdemux protection data crash fix
1718         https://bugs.webkit.org/show_bug.cgi?id=195918
1719
1720         Reviewed by Philippe Normand.
1721
1722         * gstreamer/jhbuild.modules:
1723         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
1724
1725 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1726
1727         Unreviewed, rolling out r243132.
1728
1729         Broke GTK build
1730
1731         Reverted changeset:
1732
1733         "Make WTFLogChannelState and WTFLogLevel enum classes"
1734         https://bugs.webkit.org/show_bug.cgi?id=195904
1735         https://trac.webkit.org/changeset/243132
1736
1737 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
1738
1739         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
1740
1741         * Scripts/webkitdirs.pm:
1742         (builtDylibPathForName): Adjust the shared library name that's changed
1743         with the API version bump in r243073.
1744
1745 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1746
1747         Make WTFLogChannelState and WTFLogLevel enum classes
1748         https://bugs.webkit.org/show_bug.cgi?id=195904
1749
1750         Reviewed by Eric Carlson.
1751
1752         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1753         (TestWebKitAPI::TEST_F):
1754
1755 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1756
1757         Disable flaky test added in r2431100
1758         https://webkit.org/b/195785
1759
1760         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1761         (TestWebKitAPI::TEST):
1762         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
1763
1764 2019-03-18  Timothy Hatcher  <timothy@apple.com>
1765
1766         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
1767         https://bugs.webkit.org/show_bug.cgi?id=195916
1768
1769         Reviewed by Tim Horton.
1770
1771         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1772         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
1773
1774 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
1775
1776         Add a secondary e-mail address for Fujii Hironori to make tools happier.
1777
1778         * Scripts/webkitpy/common/config/contributors.json:
1779
1780 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1781
1782         Implement DownloadMonitor to prevent long-running slow downloads from background apps
1783         https://bugs.webkit.org/show_bug.cgi?id=195785
1784
1785         Reviewed by Geoffrey Garen.
1786
1787         * TestWebKitAPI/TCPServer.cpp: Added.
1788         (TestWebKitAPI::TCPServer::TCPServer):
1789         (TestWebKitAPI::TCPServer::~TCPServer):
1790         (TestWebKitAPI::TCPServer::socketBindListen):
1791         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
1792         * TestWebKitAPI/TCPServer.h: Added.
1793         (TestWebKitAPI::TCPServer::port const):
1794         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1795         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1796         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
1797         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
1798         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1799         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
1800         (TestWebKitAPI::respondSlowly):
1801         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
1802         (TestWebKitAPI::downloadAtRate):
1803         (TestWebKitAPI::TEST):
1804
1805 2019-03-18  Saam Barati  <sbarati@apple.com>
1806
1807         Add a plan file for JetStream 2
1808         https://bugs.webkit.org/show_bug.cgi?id=190734
1809
1810         Reviewed by Mark Lam.
1811
1812         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
1813
1814 2019-03-18  Chris Dumez  <cdumez@apple.com>
1815
1816         Delay WebProcess launch until a load is triggered in a Web view
1817         https://bugs.webkit.org/show_bug.cgi?id=195758
1818         <rdar://problem/48126013>
1819
1820         Reviewed by Geoff Garen.
1821
1822         Add API test coverage. Also update some existing API tests to not expect
1823         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
1824
1825         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
1826         (TestWebKitAPI::TEST):
1827         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
1828         (TestWebKitAPI::TEST):
1829         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1830         (TEST):
1831         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1832         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1833         (TEST):
1834         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1835         (TEST):
1836         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
1837
1838 2019-03-18  Xan Lopez  <xan@igalia.com>
1839
1840         [CMake] Prevent potential warning when determining $architecture
1841         https://bugs.webkit.org/show_bug.cgi?id=195891
1842
1843         Reviewed by Michael Catanzaro.
1844
1845         It's possible for generateBuildSystemForCMakeProject to be called
1846         before determineArchitecture() is ever called. This will make the
1847         first eq check with $architecture to be bogus (and print a
1848         warning). Change that to an eq check with architecture(), which
1849         implicitly calls determineArchitecture() if needed, and change all
1850         the other similar cases in the method in the same way to prevent
1851         future bugs like this one.
1852
1853         * Scripts/webkitdirs.pm:
1854         (generateBuildSystemFromCMakeProject):
1855
1856 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1857
1858         [WPE] Tarballs generated with “make dist” cannot build documentation
1859         https://bugs.webkit.org/show_bug.cgi?id=195885
1860
1861         Reviewed by Carlos Garcia Campos.
1862
1863         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
1864
1865 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1866
1867         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
1868         https://bugs.webkit.org/show_bug.cgi?id=195883
1869
1870         Reviewed by Carlos Garcia Campos.
1871
1872         * gtkdoc/gtkdoc.py:
1873         (GTKDoc._run_command): When commands fail to run, include the full command line for
1874         the program invocation and the output it has generated on the standard error stream.
1875
1876 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1877
1878         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
1879         https://bugs.webkit.org/show_bug.cgi?id=195786
1880
1881         Reviewed by Philippe Normand.
1882
1883         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
1884         * wpe/jhbuild.modules: Ditto.
1885
1886 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
1887
1888         [ews-build] Don't run clean builds on EWS builders
1889         https://bugs.webkit.org/show_bug.cgi?id=195851
1890
1891         Reviewed by Geoffrey Garen.
1892
1893         * BuildSlaveSupport/ews-build/factories.py:
1894
1895 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
1896
1897         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
1898         https://bugs.webkit.org/show_bug.cgi?id=195849
1899
1900         Reviewed by Chris Dumez.
1901
1902         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
1903
1904         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1905         (runWebsiteDataStoreCustomPaths):
1906
1907 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
1908
1909         webkitpy: Upload test results
1910         https://bugs.webkit.org/show_bug.cgi?id=195755
1911         <rdar://problem/48896182>
1912
1913         Reviewed by Aakash Jain.
1914
1915         Establish a new format for uploading results that is not tied to layout tests, apply
1916         that format to webkitpy tests.
1917
1918         * Scripts/webkitpy/common/checkout/scm/git.py:
1919         (Git.native_branch): Return what branch the current checkout is on.
1920         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1921         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1922         * Scripts/webkitpy/common/checkout/scm/svn.py:
1923         (SVN.native_branch): Ditto.
1924         * Scripts/webkitpy/common/system/platforminfo.py:
1925         (PlatformInfo.build_version): Return a build version for Mac.
1926         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1927         (MockPlatformInfo.__init__):
1928         (MockPlatformInfo.build_version):
1929         * Scripts/webkitpy/results: Added.
1930         * Scripts/webkitpy/results/__init__.py: Added.
1931         * Scripts/webkitpy/results/options.py: Added.
1932         (upload_options): OptParse list for upload options.
1933         * Scripts/webkitpy/results/upload.py: Added.
1934         (Upload): Class which enforces the upload format expected by the results server.
1935         (Upload.Expectations):
1936         (Upload.create_configuration):
1937         (Upload.create_commit):
1938         (Upload.create_details):
1939         (Upload.create_run_stats):
1940         (Upload.create_test_result):
1941         (Upload.__init__):
1942         (Upload.Encoder): Encode Upload object as json.
1943         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
1944         * Scripts/webkitpy/results/upload_unittest.py: Added.
1945         * Scripts/webkitpy/test/main.py:
1946         (Tester._parse_args): Add upload arguments.
1947         (Tester._run_tests): Allow results to be uploaded.
1948         * Scripts/webkitpy/test/runner.py:
1949         (Runner.__init__): Record which tests were run, rather than just counting them.
1950         (Runner.handle):
1951         * Scripts/webkitpy/test/runner_unittest.py:
1952         (RunnerTest.test_run):
1953         * Scripts/webkitpy/thirdparty/__init__.py:
1954         (AutoinstallImportHook.find_module): Add requests auto-install.
1955         (AutoinstallImportHook._install_requests):
1956         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1957         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
1958
1959 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1960
1961         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
1962         https://bugs.webkit.org/show_bug.cgi?id=195810
1963
1964         Reviewed by Tim Horton.
1965
1966         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
1967         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
1968         ending certain layout tests.
1969
1970         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1971         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1972         (-[TestRunnerWKWebView dealloc]):
1973         (-[TestRunnerWKWebView resetInteractionCallbacks]):
1974
1975         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
1976         helper method when destroying the web view, and when resetting state between tests.
1977
1978         * WebKitTestRunner/ios/TestControllerIOS.mm:
1979         (WTR::TestController::platformResetStateToConsistentValues):
1980
1981         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
1982
1983 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
1984
1985         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
1986         https://bugs.webkit.org/show_bug.cgi?id=190350
1987         <rdar://problem/45089503>
1988
1989         Reviewed by Geoffrey Garen.
1990
1991         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1992         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
1993         (TEST):
1994         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
1995         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
1996         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
1997         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
1998         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
1999         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
2000         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
2001         (runTest):
2002         (createDirectories):
2003         (TEST):
2004         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2005         (TEST):
2006         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2007         (TEST):
2008
2009 2019-03-15  Timothy Hatcher  <timothy@apple.com>
2010
2011         Add support to WebPage for getting the contents as an attributed string.
2012         https://bugs.webkit.org/show_bug.cgi?id=195636
2013         rdar://problem/45055697
2014
2015         Reviewed by Tim Horton.
2016
2017         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2018         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
2019
2020 2019-03-15  Chris Dumez  <cdumez@apple.com>
2021
2022         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2023         https://bugs.webkit.org/show_bug.cgi?id=195747
2024
2025         Reviewed by Geoff Garen.
2026
2027         Add API test coverage.
2028
2029         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2030
2031 2019-03-15  Shawn Roberts  <sroberts@apple.com>
2032
2033         Unreviewed, rolling out r242952.
2034
2035         Causing API failures on iOS Simulator
2036
2037         Reverted changeset:
2038
2039         "[PSON] Make sure the WebProcessCache is leverage when
2040         relaunching a process after termination"
2041         https://bugs.webkit.org/show_bug.cgi?id=195747
2042         https://trac.webkit.org/changeset/242952
2043
2044 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
2045
2046         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
2047         https://bugs.webkit.org/show_bug.cgi?id=195740
2048
2049         Reviewed by Ross Kirsling.
2050
2051         window.open doesn't work for WebKitBrowserWindow because it is not
2052         implemented yet.
2053
2054         1. Implemented createNewPage callback of WKPageUIClient.
2055         2. Changed MainWindow to take a BrowserWindow factory function
2056           instead of BrowserWindowType to be flexible to create
2057           BrowserWindow with extra settings.
2058         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2059           because it is not relevant with MainWindow anymore.
2060
2061         * MiniBrowser/win/Common.cpp:
2062         (parseCommandLine):
2063         * MiniBrowser/win/Common.h:
2064         (CommandLineOptions::CommandLineOptions):
2065         * MiniBrowser/win/MainWindow.cpp:
2066         (MainWindow::MainWindow):
2067         (MainWindow::create):
2068         (MainWindow::init):
2069         (MainWindow::WndProc):
2070         * MiniBrowser/win/MainWindow.h:
2071         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2072         (PrintWebUIDelegate::createWebViewWithRequest):
2073         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2074         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2075         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2076         (WebKitBrowserWindow::updateProxySettings):
2077         (WebKitBrowserWindow::createNewPage):
2078         * MiniBrowser/win/WebKitBrowserWindow.h:
2079         * MiniBrowser/win/WinMain.cpp:
2080         (wWinMain):
2081
2082 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2083
2084         Make it possible to test scrolling tree layer manipulation more easily
2085         https://bugs.webkit.org/show_bug.cgi?id=195780
2086
2087         Reviewed by Tim Horton.
2088         
2089         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2090         cuts off communication of scrolling tree scrolls back to the web process
2091         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2092         allows tests to trigger scrolls which run the scrolling tree layer positioning
2093         logic, but never get another commit from the web process that might mask
2094         scrolling tree bugs.
2095         
2096         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2097         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2098         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2099
2100         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2101         (WTR::UIScriptController::scrollUpdatesDisabled const):
2102         (WTR::UIScriptController::setScrollUpdatesDisabled):
2103         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2104         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2105         (WTR::UIScriptController::scrollUpdatesDisabled const):
2106         (WTR::UIScriptController::setScrollUpdatesDisabled):
2107         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2108         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2109         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2110         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2111         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2112         * WebKitTestRunner/ios/TestControllerIOS.mm:
2113         (WTR::TestController::platformResetStateToConsistentValues):
2114         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2115         (WTR::UIScriptController::scrollUpdatesDisabled const):
2116         (WTR::UIScriptController::setScrollUpdatesDisabled):
2117
2118 2019-03-14  Youenn Fablet  <youenn@apple.com>
2119
2120         Move IDB storage in private browsing mode to NetworkProcess
2121         https://bugs.webkit.org/show_bug.cgi?id=195602
2122
2123         Reviewed by Brady Eidson.
2124
2125         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2126         (TEST):
2127
2128 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2129
2130         [ews-build] Make descriptionDone messages more readable
2131         https://bugs.webkit.org/show_bug.cgi?id=195760
2132
2133         Reviewed by Lucas Forschler.
2134
2135         * BuildSlaveSupport/ews-build/steps.py:
2136         * BuildSlaveSupport/ews-build/steps_unittest.py:
2137
2138 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2139
2140         [ews-build] Generate status-bubble hover-over messages
2141         https://bugs.webkit.org/show_bug.cgi?id=195680
2142
2143         Reviewed by Lucas Forschler.
2144
2145         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2146         (StatusBubble):
2147         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2148         on hover-over.
2149         (StatusBubble._iso_time):
2150         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2151         hover-over message.
2152         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2153
2154 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2155
2156         [ews-app] Gracefully handle the case when state_string is None
2157         https://bugs.webkit.org/show_bug.cgi?id=195753
2158
2159         Reviewed by Lucas Forschler.
2160
2161         * BuildSlaveSupport/ews-app/ews/models/build.py:
2162         * BuildSlaveSupport/ews-app/ews/models/step.py:
2163
2164 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2165
2166         [ews-app] Status bubble display pending for currently running build step
2167         https://bugs.webkit.org/show_bug.cgi?id=195744
2168
2169         Reviewed by Lucas Forschler.
2170
2171         * BuildSlaveSupport/ews-build/events.py:
2172         (Events.stepStarted): If state_string is pending, replace it with step name.
2173
2174 2019-03-14  Chris Dumez  <cdumez@apple.com>
2175
2176         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2177         https://bugs.webkit.org/show_bug.cgi?id=195750
2178
2179         Reviewed by Geoffrey Garen.
2180
2181         Add API test coverage.
2182
2183         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2184         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2185         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2186         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2187
2188 2019-03-14  Chris Dumez  <cdumez@apple.com>
2189
2190         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2191         https://bugs.webkit.org/show_bug.cgi?id=195747
2192
2193         Reviewed by Geoff Garen.
2194
2195         Add API test coverage.
2196
2197         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2198
2199 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2200
2201         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2202         https://bugs.webkit.org/show_bug.cgi?id=195725
2203         <rdar://problem/48545062>
2204
2205         Reviewed by Tim Horton.
2206
2207         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2208         handler is nil.
2209
2210         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2211         (TestWebKitAPI::TEST):
2212
2213 2019-03-13  Sam Weinig  <sam@webkit.org>
2214
2215         Add utility function to allow easy reverse range-based iteration of a container
2216         https://bugs.webkit.org/show_bug.cgi?id=195542
2217
2218         Reviewed by Antti Koivisto.
2219
2220         * TestWebKitAPI/CMakeLists.txt:
2221         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2222         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2223         (TestWebKitAPI::TEST):
2224         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2225
2226 2019-03-13  Chris Dumez  <cdumez@apple.com>
2227
2228         Use a ServiceWorker process per registrable domain
2229         https://bugs.webkit.org/show_bug.cgi?id=195649
2230
2231         Reviewed by Youenn Fablet.
2232
2233         Update API test coverage.
2234
2235         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2236
2237 2019-03-13  Chris Dumez  <cdumez@apple.com>
2238
2239         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2240         https://bugs.webkit.org/show_bug.cgi?id=195684
2241         <rdar://problem/48294714>
2242
2243         Reviewed by Antti Koivisto.
2244
2245         Add API test coverage.
2246
2247         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2248
2249 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2250
2251         [ews-app] Remove unused patch view
2252         https://bugs.webkit.org/show_bug.cgi?id=195669
2253
2254         Reviewed by Lucas Forschler.
2255
2256         * BuildSlaveSupport/ews-app/ews/urls.py:
2257         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2258
2259 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2260
2261         [ews-app] Use Buildbot result code variables
2262         https://bugs.webkit.org/show_bug.cgi?id=195668
2263
2264         Reviewed by Alexey Proskuryakov.
2265
2266         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2267         (Buildbot): Added Buildbot result code variables.
2268         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2269         (StatusBubble._build_bubble): Used Buildbot result code variables.
2270
2271 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2272
2273         [Flatpak] Expand submodule recursively
2274         https://bugs.webkit.org/show_bug.cgi?id=195672
2275
2276         Building WPE with flatpak was impossible without that as it was raising an exception.
2277         Also update wpebackend-fdo to match what is built in jhbuild
2278
2279         Reviewed by Philippe Normand.
2280
2281         * flatpak/flatpakutils.py:
2282         (expand_submodules_recurse):
2283         (expand_manifest):
2284         * flatpak/org.webkit.WPEModules.yaml:
2285
2286 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2287
2288         [ews-app] status bubble should be hidden for certain builds
2289         https://bugs.webkit.org/show_bug.cgi?id=194597
2290
2291         Reviewed by Dewei Zhu.
2292
2293         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2294         (StatusBubble._build_bubble):
2295         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2296         because the patch didn't have relevant changes.
2297         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2298         in production yet.
2299
2300 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2301
2302         [Win] Fix a slew of simple clang-cl warnings.
2303         https://bugs.webkit.org/show_bug.cgi?id=195652
2304
2305         Reviewed by Don Olmstead.
2306
2307         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2308         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2309
2310 2019-03-12  Justin Fan  <justin_fan@apple.com>
2311
2312         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2313         https://bugs.webkit.org/show_bug.cgi?id=195518
2314         <rdar://problem/46322356>
2315
2316         Reviewed by Myles C. Maxfield.
2317
2318         * DumpRenderTree/DerivedSources-input.xcfilelist:
2319         * DumpRenderTree/DerivedSources-output.xcfilelist:
2320
2321 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2322
2323         Unreviewed, rolling out r242825.
2324         https://bugs.webkit.org/show_bug.cgi?id=195648
2325
2326         "Broke webkitpy tests with my change to
2327         lldb_dump_class_layout.py" (Requested by rmorisset on
2328         #webkit).
2329
2330         Reverted changeset:
2331
2332         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2333         classes with suspicious padding"
2334         https://bugs.webkit.org/show_bug.cgi?id=195573
2335         https://trac.webkit.org/changeset/242825
2336
2337 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2338
2339         [ews-build] Show status bubbles while the patch is waiting in queue
2340         https://bugs.webkit.org/show_bug.cgi?id=195618
2341
2342         Reviewed by Lucas Forschler.
2343
2344         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2345         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2346         enabled in initial deployment.
2347         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2348         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2349         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2350         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2351         (StatusBubble._build_bubbles_for_patch):
2352
2353 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2354
2355         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2356         https://bugs.webkit.org/show_bug.cgi?id=195573
2357
2358         Reviewed by Simon Fraser.
2359
2360         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2361
2362         * Scripts/dump-class-layout:
2363         (main):
2364         * lldb/lldb_dump_class_layout.py:
2365         (ClassLayout.__init__):
2366         (ClassLayout._compute_padding_recursive):
2367         (LLDBDebuggerInstance.dump_layout_for_classname):
2368         (LLDBDebuggerInstance):
2369         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2370         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2371
2372 2019-03-12  Chris Dumez  <cdumez@apple.com>
2373
2374         Device Orientation access permission should be denied unless explicitly granted by the client
2375         https://bugs.webkit.org/show_bug.cgi?id=195625
2376
2377         Reviewed by Youenn Fablet.
2378
2379         add API test coverage.
2380
2381         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2382         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2383         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2384         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2385         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2386         (runDeviceOrientationTest):
2387         (TEST):
2388         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2389         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2390
2391 2019-03-12  Jer Noble  <jer.noble@apple.com>
2392
2393         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2394         https://bugs.webkit.org/show_bug.cgi?id=195137
2395         <rdar://problem/48810307>
2396
2397         Reviewed by Eric Carlson.
2398
2399         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2400         (TestWebKitAPI::TEST):
2401
2402 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2403
2404         [ews-build] Change urls from uat to production
2405         https://bugs.webkit.org/show_bug.cgi?id=195566
2406
2407         Reviewed by Lucas Forschler.
2408
2409         * BuildSlaveSupport/ews-app/ews/config.py:
2410         * BuildSlaveSupport/ews-build/events.py:
2411         * BuildSlaveSupport/ews-build/steps.py:
2412
2413 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2414
2415         [ews-build] change max_builds for local-worker to 1
2416         https://bugs.webkit.org/show_bug.cgi?id=195568
2417
2418         Reviewed by Lucas Forschler.
2419
2420         * BuildSlaveSupport/ews-build/loadConfig.py:
2421
2422 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2423
2424         Fix the build
2425
2426         * TestRunnerShared/spi/PencilKitTestSPI.h:
2427         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2428
2429 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2430
2431         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2432         https://bugs.webkit.org/show_bug.cgi?id=194131
2433
2434         Reviewed by Michael Catanzaro.
2435
2436         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2437         (uriChanged):
2438         (testUnfinishedSubresourceLoad):
2439         (serverCallback):
2440         (beforeAll):
2441
2442 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2443
2444         WTF::Expected should use std::addressof instead of operator&
2445         https://bugs.webkit.org/show_bug.cgi?id=195604
2446
2447         Reviewed by Myles Maxfield.
2448
2449         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2450         (TestWebKitAPI::Unique::Unique):
2451         (TestWebKitAPI::Unique::operator&):
2452         (TestWebKitAPI::TEST):
2453
2454 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2455
2456         Add Optional to Forward.h.
2457         https://bugs.webkit.org/show_bug.cgi?id=195586
2458
2459         Reviewed by Darin Adler.
2460
2461         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2462         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2463         Remove unnecessary includes from headers.
2464
2465 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2466
2467         Add testing API to hit-test and scroll overflow scrollers
2468         https://bugs.webkit.org/show_bug.cgi?id=195278
2469
2470         Reviewed by Antti Koivisto.
2471         
2472         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2473         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2474         
2475         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2476
2477         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2478         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2479         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2480         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2481         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2482         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2483         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2484         (WTR::enclosingScrollViewIncludingSelf):
2485         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2486
2487 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2488
2489         API test WebKit.RequestTextInputContext fails on iOS
2490         https://bugs.webkit.org/show_bug.cgi?id=195585
2491
2492         Reviewed by Wenson Hsieh and Simon Fraser.
2493
2494         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2495         (applyStyle):
2496         (TEST):
2497         Add a viewport, so that the coordinates match up on iOS.
2498         Scroll by moving the UIScrollView's contentOffset.
2499
2500 2019-03-11  Chris Dumez  <cdumez@apple.com>
2501
2502         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2503         https://bugs.webkit.org/show_bug.cgi?id=195506
2504         <rdar://problem/48733477>
2505
2506         Reviewed by Alex Christensen.
2507
2508         Add API test coverage.
2509
2510         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2511
2512 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2513
2514         Adding myself to contributors.json
2515
2516         Unreviewed, addming myself to contributors.json .
2517
2518         * Scripts/webkitpy/common/config/contributors.json:
2519
2520 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2521
2522         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2523         https://bugs.webkit.org/show_bug.cgi?id=195511
2524         <rdar://problem/44873269>
2525
2526         Reviewed by Darin Adler.
2527
2528         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2529         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2530         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2531         (TEST_F):
2532
2533 2019-03-11  Chris Dumez  <cdumez@apple.com>
2534
2535         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2536         https://bugs.webkit.org/show_bug.cgi?id=195561
2537
2538         Reviewed by Youenn Fablet.
2539
2540         Make sure the JS in the test requests for permission to receive device orientation events.
2541
2542         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2543
2544 2019-03-11  Youenn Fablet  <youenn@apple.com>
2545
2546         Allow storage quota increase by default in WTR
2547         https://bugs.webkit.org/show_bug.cgi?id=195541
2548
2549         Reviewed by Geoffrey Garen.
2550
2551         Allow storage quota increase by default in WTR.
2552         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2553         Use this for tests that explicitly need cache increase.
2554
2555         Instead of increasing quota by 2, make sure the next request is
2556         granted by adding all given parameters.
2557
2558         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2559         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2560         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2561         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2562         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2563         * WebKitTestRunner/TestController.cpp:
2564         (WTR::TestController::setAllowStorageQuotaIncrease):
2565         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2566         * WebKitTestRunner/TestController.h:
2567         * WebKitTestRunner/TestInvocation.cpp:
2568         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2569         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2570         (WTR::TestController::cocoaResetStateToConsistentValues):
2571         (WTR::TestController::setAllowStorageQuotaIncrease):
2572         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2573         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2574         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2575
2576 2019-03-11  Xan Lopez  <xan@igalia.com>
2577
2578         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2579         https://bugs.webkit.org/show_bug.cgi?id=194147
2580
2581         Reviewed by Michael Saboff.
2582
2583         To make --32-bit work correctly on Linux/64bit we need to:
2584
2585         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
2586         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
2587         unfortunately CMake only allows us to do this during
2588         crosscompilation, which is overkill here.
2589         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
2590         pkg-config detection module uses the x86 .pc files instead of the
2591         x86_64 ones.
2592         - Set the -m32 flags for the compiler.
2593
2594         * Scripts/webkitdirs.pm:
2595         (generateBuildSystemFromCMakeProject):
2596
2597 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
2598
2599         Add MotionMark-1.1 plan file for run-benchmark script.
2600         https://bugs.webkit.org/show_bug.cgi?id=195481
2601
2602         Rubber-stamped by Darin Adler.
2603
2604         Run-benchmark script should support MontionMark-1.1.
2605
2606         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
2607
2608 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2609
2610         [ews-app] Add support for submit-to-ews url
2611         https://bugs.webkit.org/show_bug.cgi?id=195477
2612
2613         Reviewed by Lucas Forschler.
2614
2615         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2616         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2617         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
2618         * BuildSlaveSupport/ews-app/ews/urls.py:
2619         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
2620
2621 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
2622
2623         Unreviewed, rolling out r242688, r242643, r242624.
2624
2625         Caused multiple layout test failures and crashes on iOS and macOS.
2626
2627         Reverted changeset:
2628
2629         "requestAnimationFrame should execute before the next frame"
2630         https://bugs.webkit.org/show_bug.cgi?id=177484
2631         https://trac.webkit.org/changeset/242624/webkit
2632
2633         * Tracing/SystemTracePoints.plist:
2634
2635 2019-03-11  John Wilander  <wilander@apple.com>
2636
2637         Resource Load Statistics: Make it possible exclude localhost from classification
2638         https://bugs.webkit.org/show_bug.cgi?id=195474
2639         <rdar://problem/47520577>
2640
2641         Reviewed by Brent Fulgham.
2642
2643         This patch allows for localhost to be excluded from classification and
2644         treatment as a prevalent resource.
2645
2646         The WebKit Tools change adds a new function called
2647         testRunner.setStatisticsIsRunningTest() which can be used to control this
2648         behavior.
2649
2650         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2651         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2652         (WTR::TestRunner::setStatisticsIsRunningTest):
2653         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2654         * WebKitTestRunner/TestController.cpp:
2655         (WTR::TestController::setStatisticsIsRunningTest):
2656         * WebKitTestRunner/TestController.h:
2657         * WebKitTestRunner/TestInvocation.cpp:
2658         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2659
2660 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2661
2662         [ews-build] Disable waterfall and console view for ews-build.webkit.org
2663         https://bugs.webkit.org/show_bug.cgi?id=195560
2664
2665         Reviewed by Lucas Forschler.
2666
2667         * BuildSlaveSupport/ews-build/master.cfg:
2668
2669 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2670
2671         Unreviewed, rolling out r242698.
2672
2673         API test crashes on bots.
2674
2675         Reverted changeset:
2676
2677         "Add a WKContentRuleList variant that uses copied memory
2678         instead of mmap'd shared memory for class A containerized
2679         apps"
2680         https://bugs.webkit.org/show_bug.cgi?id=195511
2681         https://trac.webkit.org/changeset/242698
2682
2683 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2684
2685         [WPE] Enable web process sandbox
2686         https://bugs.webkit.org/show_bug.cgi?id=195169
2687
2688         Reviewed by Daniel Bates.
2689
2690         * wpe/install-dependencies:
2691         * wpe/jhbuild.modules:
2692
2693 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2694
2695         [ews-app] Use port 17000 for worker communication
2696         https://bugs.webkit.org/show_bug.cgi?id=195558
2697
2698         Reviewed by Lucas Forschler.
2699
2700         * BuildSlaveSupport/ews-build/master.cfg:
2701
2702 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2703
2704         [ews-build] unit-tests fail when passwords.json is missing
2705         https://bugs.webkit.org/show_bug.cgi?id=195557
2706
2707         Reviewed by Lucas Forschler.
2708
2709         * BuildSlaveSupport/ews-build/loadConfig.py:
2710         (loadBuilderConfig):
2711         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2712         (ConfigDotJSONTest.test_configuration):
2713         * BuildSlaveSupport/ews-build/master.cfg:
2714
2715 2019-03-11  Truitt Savell  <tsavell@apple.com>
2716
2717         Unreviewed, rolling out r242702.
2718
2719         Broke High Sierra builders.
2720
2721         Reverted changeset:
2722
2723         "Add utility function to allow easy reverse range-based
2724         iteration of a container"
2725         https://bugs.webkit.org/show_bug.cgi?id=195542
2726         https://trac.webkit.org/changeset/242702
2727
2728 2019-03-11  Sam Weinig  <sam@webkit.org>
2729
2730         Add utility function to allow easy reverse range-based iteration of a container
2731         https://bugs.webkit.org/show_bug.cgi?id=195542
2732
2733         Reviewed by Antti Koivisto.
2734
2735         * TestWebKitAPI/CMakeLists.txt:
2736         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2737         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2738         (TestWebKitAPI::TEST):
2739         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2740
2741 2019-03-10  Alex Christensen  <achristensen@webkit.org>
2742
2743         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2744         https://bugs.webkit.org/show_bug.cgi?id=195511
2745         <rdar://problem/44873269>
2746
2747         Reviewed by Darin Adler.
2748
2749         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2750         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2751         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2752         (TEST_F):
2753
2754 2019-03-10  Tim Horton  <timothy_horton@apple.com>
2755
2756         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
2757         https://bugs.webkit.org/show_bug.cgi?id=195499
2758
2759         Reviewed by Darin Adler.
2760
2761         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2762         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
2763         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
2764         (-[WKWebView synchronouslyFocusTextInputContext:]):
2765         (applyStyle):
2766         (applyIframe):
2767         (TEST):
2768         Add some tests for this SPI.
2769
2770 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
2771
2772         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
2773         https://bugs.webkit.org/show_bug.cgi?id=181151
2774
2775         Reviewed by Don Olmstead.
2776
2777         * TestWebKitAPI/CMakeLists.txt:
2778         * TestWebKitAPI/PlatformWin.cmake:
2779         Enable TestWTF RunLoop tests in all platforms.
2780
2781         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
2782         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
2783         (TestWebKitAPI::DerivedOneShotTimer::fired):
2784         (TestWebKitAPI::TEST):
2785         Only a few platforms support nested RunLoop.
2786
2787         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
2788         (TestWebKitAPI::DerivedRepeatingTimer::fired):
2789
2790 2019-03-10  David Quesada  <david_quesada@apple.com>
2791
2792         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
2793         https://bugs.webkit.org/show_bug.cgi?id=152480
2794
2795         Reviewed by Chris Dumez.
2796
2797         Add a unit test based on Daniel Bates's test case that starts a download, ensures
2798         there are no additional references to the process pool besides the one held by
2799         the download, waits for the download to finish (in the sense that the
2800         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
2801         measure, also check that the process pool has been deallocated at the end of the
2802         test. The test wouldn't be meaningful if the process pool were still alive.
2803
2804         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2805         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
2806         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
2807             The download will be canceled because the delegate does not implement the
2808             method to decide the download's destination, so this is where we know the
2809             DownloadProxyMap is done with the DownloadProxy.
2810         (TEST):
2811
2812 2019-03-08  Chris Dumez  <cdumez@apple.com>
2813
2814         Add support for Device Orientation / Motion permission API
2815         https://bugs.webkit.org/show_bug.cgi?id=195329
2816         <rdar://problem/47645367>
2817
2818         Reviewed by Geoffrey Garen.
2819
2820         Add test infrastructure to help test the Device Orientation / Motion permission API.
2821
2822         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2823         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2824         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
2825         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2826         * WebKitTestRunner/TestController.cpp:
2827         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
2828         (WTR::TestController::createWebViewWithOptions):
2829         (WTR::TestController::resetStateToConsistentValues):
2830         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
2831         * WebKitTestRunner/TestController.h:
2832         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
2833         * WebKitTestRunner/TestInvocation.cpp:
2834         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2835
2836 2019-03-08  Saam barati  <sbarati@apple.com>
2837
2838         Add a compare-results script to compare benchmark results
2839         https://bugs.webkit.org/show_bug.cgi?id=195486
2840         <rdar://problem/48723397>
2841
2842         Reviewed by Geoffrey Garen.
2843
2844         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
2845         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
2846         to extend it to learn about our other benchmarks.
2847
2848         * Scripts/compare-results: Added.
2849         (readJSONFile):
2850         (detectJetStream2):
2851         (JetStream2Results):
2852         (detectSpeedometer2):
2853         (Speedometer2Results):
2854         (detectPLT5):
2855         (PLT5Results):
2856         (detectBenchmark):
2857         (biggerIsBetter):
2858         (ttest):
2859         (getOptions):
2860         (main):
2861
2862 2019-03-08  Stephanie Lewis  <slewis@apple.com>
2863
2864         Ensure old tab state is cleared between iterations of run-benchmark
2865         https://bugs.webkit.org/show_bug.cgi?id=195393
2866         <rdar://problem/46885583>
2867
2868         Reviewed by Dewei Zhu.
2869
2870         a) ensure the default to restore state is not set
2871         b) terminate Safari correctly
2872         c) Set the system default to ignore Persistent State in Safari
2873
2874         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2875         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
2876         (OSXBrowserDriver.prepare_env): 
2877         (OSXBrowserDriver.restore_env):
2878         (OSXBrowserDriver.close_browsers):
2879         (OSXBrowserDriver._terminate_processes):
2880         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
2881         (OSXChromeDriver):
2882         (OSXChromeCanaryDriver):
2883         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
2884         (OSXFirefoxDriver):
2885         (OSXFirefoxNightlyDriver):
2886         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
2887         (OSXSafariDriver):
2888         (OSXSafariDriver.prepare_env):
2889
2890 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
2891
2892         [GTK] Several InputMethodFilter tests are failing
2893         https://bugs.webkit.org/show_bug.cgi?id=195408
2894
2895         Reviewed by Carlos Garcia Campos.
2896
2897         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
2898         Regressed in r241751.
2899         Hexadecimal values of keycodes are expressed now in upper letters.
2900         Composited characters should be cast to UTF8 strings.
2901
2902         (TestWebKitAPI::TEST):
2903
2904 2019-03-07  Tomas Popela  <tpopela@redhat.com>
2905
2906         [GTK] Make Tools/gtkdoc python3 compatible
2907         https://bugs.webkit.org/show_bug.cgi?id=195359
2908
2909         Reviewed by Carlos Garcia Campos.
2910
2911         * gtkdoc/generate-gtkdoc:
2912         ConfigParser was reworked in Python 3.2 so we have adapt the code to
2913         work with Python 2 and 3.
2914         (get_gtkdoc_module_paths):
2915         The iteritems() was removed in Python 3, so let's use items() that's
2916         available in Python 2 and 3.
2917         (get_generator_for_config):
2918         * gtkdoc/gtkdoc.py:
2919         (GTKDoc._run_command):
2920         The sys.stdout.write() is expecting str in Python 3 and not bytes
2921         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
2922         for passing the bytes there.
2923
2924 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
2925
2926         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2927         https://bugs.webkit.org/show_bug.cgi?id=195346
2928         <rdar://problem/48667048>
2929
2930         Unreviewed build fix for clang-cl.
2931
2932         * DumpRenderTree/win/DumpRenderTree.cpp:
2933         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
2934
2935 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
2936
2937         requestAnimationFrame should execute before the next frame
2938         https://bugs.webkit.org/show_bug.cgi?id=177484
2939
2940         Reviewed by Simon Fraser.
2941
2942         Add trace points for the page RenderingUpdate.
2943
2944         * Tracing/SystemTracePoints.plist:
2945
2946 2019-03-07  Zalan Bujtas  <zalan@apple.com>
2947
2948         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
2949         https://bugs.webkit.org/show_bug.cgi?id=195353
2950         <rdar://problem/48626394>
2951
2952         Reviewed by Simon Fraser.
2953
2954         * WebKitTestRunner/ios/TestControllerIOS.mm:
2955         (WTR::TestController::platformResetPreferencesToConsistentValues):
2956
2957 2019-03-07  John Wilander  <wilander@apple.com>
2958
2959         Resource Load Statistics: Make it possible to purge only script-accessible cookies
2960         https://bugs.webkit.org/show_bug.cgi?id=195383
2961         <rdar://problem/48570136>
2962
2963         Reviewed by Brent Fulgham.
2964
2965         This patch adds test infrastructure to purge only script-accessible cookies,
2966         including a new testRunner function called statisticsDeleteCookiesForHost().git a
2967
2968         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2969         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2970         (WTR::TestRunner::statisticsDeleteCookiesForHost):
2971         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2972         * WebKitTestRunner/TestController.cpp:
2973         (WTR::TestController::statisticsDeleteCookiesForHost):
2974         * WebKitTestRunner/TestController.h:
2975         * WebKitTestRunner/TestInvocation.cpp:
2976         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2977
2978 2019-03-07  Commit Queue  <commit-queue@webkit.org>
2979
2980         Unreviewed, rolling out r242354.
2981         https://bugs.webkit.org/show_bug.cgi?id=195402
2982
2983         breaks layout tests in all configurations (Requested by
2984         zdobersek on #webkit).
2985
2986         Reverted changeset:
2987
2988         "[WPE] Enable web process sandbox"
2989         https://bugs.webkit.org/show_bug.cgi?id=195169
2990         https://trac.webkit.org/changeset/242354
2991
2992 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
2993
2994         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2995         https://bugs.webkit.org/show_bug.cgi?id=195346
2996
2997         Reviewed by Fujii Hironori.
2998
2999         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
3000         (TestWebKitAPI::TEST):
3001         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
3002
3003         * DumpRenderTree/win/DumpRenderTree.cpp:
3004         (findFontFallback):
3005         (addFontFallbackIfPresent):
3006         (removeFontFallbackIfPresent):
3007         (main):
3008         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3009         (TestWebKitAPI::Util::moduleDirectory):
3010         (TestWebKitAPI::Util::createInjectedBundlePath):
3011         Use wchar helpers as needed.
3012
3013 2019-03-06  Rob Buis  <rbuis@igalia.com>
3014
3015         Consider supporting the `referrerpolicy` attribute.
3016         https://bugs.webkit.org/show_bug.cgi?id=179053
3017
3018         Reviewed by Darin Adler.
3019
3020         Add a runtime flag for referrerpolicy attribute.
3021
3022         * DumpRenderTree/mac/DumpRenderTree.mm:
3023         (enableExperimentalFeatures):
3024
3025 2019-03-05  Daniel Bates  <dabates@apple.com>
3026
3027         Update expected API test result following r242379
3028         (https://bugs.webkit.org/show_bug.cgi?id=195125)
3029
3030         Update expected x-coordinate of selection rect now that the left padding of
3031         a textarea is sized in ems (so dependent on the font size) just like the left
3032         padding of a text field.
3033
3034         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3035         (TestWebKitAPI::TEST):
3036
3037 2019-03-05  David Quesada  <david_quesada@apple.com>
3038
3039         [WK2] It should be possible to follow links with 'download' attributes
3040         https://bugs.webkit.org/show_bug.cgi?id=195145
3041         rdar://problem/48462642
3042
3043         Reviewed by Alex Christensen.
3044
3045         Add a unit test to verify that activating links with 'download' attributes now
3046         navigates to the linked resource, rather than starts downloading it. Add another
3047         to verify that it is still possible to explicitly download the link via the
3048         'Download' navigation action policy.
3049
3050         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3051         (-[DownloadAttributeTestDelegate init]):
3052         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3053         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3054         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3055         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3056         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3057         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3058         (TEST):
3059         * WebKitTestRunner/TestController.cpp:
3060         (WTR::TestController::decidePolicyForNavigationAction):
3061         * WebKitTestRunner/TestController.h:
3062
3063 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3064
3065         [Curl] Implement Cookie Accept Policy.
3066         https://bugs.webkit.org/show_bug.cgi?id=191645
3067
3068         Reviewed by Fujii Hironori.
3069
3070         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3071         (TestWebKitAPI::Curl::TEST_F):
3072
3073 2019-03-05  Youenn Fablet  <youenn@apple.com>
3074
3075         Rename requestCacheStorageSpace to requestStorageSpace
3076         https://bugs.webkit.org/show_bug.cgi?id=195282
3077
3078         Reviewed by Chris Dumez.
3079
3080         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3081         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3082         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3083
3084 2019-03-05  Brady Eidson  <beidson@apple.com>
3085
3086         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3087         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3088
3089         Reviewed by Tim Horton.
3090
3091         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3092         different directory into that same WKWebView should work.
3093
3094         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3095         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3096
3097 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3098
3099         Add WeakHashSet
3100         https://bugs.webkit.org/show_bug.cgi?id=195152
3101
3102         Reviewed by Antti Koivisto.
3103
3104         Added tests for WeakHashSet.
3105
3106         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3107         (TestWebKitAPI::Base::Base): Moved.
3108         (TestWebKitAPI::Derived::foo): Moved.
3109         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3110         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3111         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3112         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3113
3114 2019-03-04  Chris Dumez  <cdumez@apple.com>
3115
3116         Do not share WebProcesses between private and regular sessions
3117         https://bugs.webkit.org/show_bug.cgi?id=195189
3118         <rdar://problem/48421064>
3119
3120         Reviewed by Alex Christensen.
3121
3122         Add API test coverage.
3123
3124         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3125         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3126
3127 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3128
3129         [WPE] Enable web process sandbox
3130         https://bugs.webkit.org/show_bug.cgi?id=195169
3131
3132         Reviewed by Daniel Bates.
3133
3134         * wpe/install-dependencies:
3135         * wpe/jhbuild.modules:
3136
3137 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3138
3139         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3140         https://bugs.webkit.org/show_bug.cgi?id=195206
3141
3142         Reviewed by Žan Doberšek.
3143
3144         Add a new test case.
3145
3146         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3147         (testJSCClass):
3148
3149 2019-03-04  Charlie Turner  <cturner@igalia.com>
3150
3151         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3152         https://bugs.webkit.org/show_bug.cgi?id=194898
3153
3154         Reviewed by Žan Doberšek.
3155
3156         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3157         a GCC extension that permits arithmetic on void* pointer. Inline
3158         the macro until this issue is fixed upstream.
3159
3160 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3161
3162         Rid the world of WK_API_ENABLED
3163         https://bugs.webkit.org/show_bug.cgi?id=195263
3164
3165         Reviewed by Dan Bernstein.
3166
3167         List of changed files elided because it's useless.
3168
3169 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3170
3171         Unreviewed follow-up to r242292.
3172
3173         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3174
3175         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3176         (TestWebKitAPI::testStrip): Renamed from strip.
3177         (TestWebKitAPI::TEST):
3178
3179 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3180
3181         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3182
3183         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3184         and bug #194272 for details.
3185
3186         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3187
3188 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3189
3190         Remove some more unused 32-bit code
3191         https://bugs.webkit.org/show_bug.cgi?id=195255
3192
3193         Reviewed by Darin Adler.
3194
3195         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3196         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3197         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3198         (NPP_New):
3199         (NPP_HandleEvent):
3200         (handleEventCarbon): Deleted.
3201
3202 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3203
3204         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3205
3206         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3207         (TestWebKitAPI::TEST):
3208
3209 2019-03-01  Darin Adler  <darin@apple.com>
3210
3211         Finish removing String::format
3212         https://bugs.webkit.org/show_bug.cgi?id=194893
3213
3214         Reviewed by Daniel Bates.
3215 '
3216         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3217
3218 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3219
3220         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3221         https://bugs.webkit.org/show_bug.cgi?id=195229
3222         <rdar://problem/48520362>
3223
3224         Reviewed by Chris Dumez.
3225
3226         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3227         (TEST):
3228
3229 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3230
3231         Add a system trace scope for event region building
3232         https://bugs.webkit.org/show_bug.cgi?id=195226
3233
3234         Reviewed by Jon Lee.
3235
3236         This trace scope measures the time spend converting element rects into Region objects,
3237         which can be large on some pages.
3238
3239         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3240
3241         * Tracing/SystemTracePoints.plist:
3242
3243 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3244
3245         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3246         https://bugs.webkit.org/show_bug.cgi?id=194612
3247
3248         Reviewed by Alex Christensen.
3249
3250         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3251         Just test the new string-processing function and don't touch the actual environment.
3252         (Test cases are all as before, but based on operator== instead of strcmp.)
3253
3254 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3255
3256         [ews-app] Update primary keys for handling multiple Buildbot instances
3257         https://bugs.webkit.org/show_bug.cgi?id=195120
3258
3259         Reviewed by Stephanie Lewis.
3260
3261         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3262         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3263         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3264
3265         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3266         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3267         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3268         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3269         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3270         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3271
3272 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3273
3274         [WinCairo] Enable service worker
3275         https://bugs.webkit.org/show_bug.cgi?id=188318
3276
3277         Reviewed by Youenn Fablet.
3278
3279         * DumpRenderTree/DumpRenderTreePrefix.h:
3280         * TestWebKitAPI/PlatformWin.cmake:
3281         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3282         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3283         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3284
3285 2019-03-01  Justin Fan  <justin_fan@apple.com>
3286
3287         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3288         https://bugs.webkit.org/show_bug.cgi?id=195191
3289
3290         Rubber-stamped by Dean Jackson.
3291
3292         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3293
3294         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3295
3296 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3297
3298         Unreviewed, fix lldb webkitpy tests
3299         https://bugs.webkit.org/show_bug.cgi?id=194375
3300
3301         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3302
3303         * lldb/lldb_webkit.py:
3304         (WTFStringImplProvider.is_8bit):
3305
3306 2019-02-28  David Quesada  <david_quesada@apple.com>
3307
3308         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3309         https://bugs.webkit.org/show_bug.cgi?id=195121
3310         rdar://problem/48450302
3311
3312         Reviewed by Alex Christensen.
3313
3314         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3315         configurations where the 'download' attribute is absent, blank, or populated
3316         with a filename, and where the anchor element is same-origin or cross-origin
3317         (meaning the 'download' attribute shouldn't be honored).
3318
3319         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3320         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3321         (-[NavigationActionTestDelegate init]):
3322         (-[NavigationActionTestDelegate navigationAction]):
3323         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3324         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3325         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3326         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3327         (TEST):
3328
3329 2019-02-28  Antoine Quint  <graouts@apple.com>
3330
3331         Enable the Pointer Events runtime flag by default
3332         https://bugs.webkit.org/show_bug.cgi?id=195156
3333
3334         Reviewed by Dean Jackson.
3335
3336         * DumpRenderTree/mac/DumpRenderTree.mm:
3337         (enableExperimentalFeatures):
3338
3339 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3340
3341         Several PasteImage API tests are flaky
3342         https://bugs.webkit.org/show_bug.cgi?id=195160
3343
3344         Reviewed by Tim Horton.
3345
3346         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3347         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3348         listening for a "load" event after image load is already complete.
3349
3350         To address this, make these tests first register a "load" event handler, then run script to insert an image
3351         element into the document, and finally wait until the load event is observed before checking image size.
3352
3353         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3354
3355 2019-02-28  Chris Dumez  <cdumez@apple.com>
3356
3357         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3358         https://bugs.webkit.org/show_bug.cgi?id=195107
3359
3360         Reviewed by Alex Christensen.
3361
3362         Give some time for the zoom level to get restored.
3363
3364         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3365
3366 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3367
3368         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3369         https://bugs.webkit.org/show_bug.cgi?id=194958
3370
3371         Reviewed by Geoffrey Garen.
3372
3373         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3374         (TEST):
3375
3376 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3377
3378         [ews-app] Update method to save build to handle builder_display_name
3379         https://bugs.webkit.org/show_bug.cgi?id=195047
3380
3381         Reviewed by Dewei Zhu.
3382
3383         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3384         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3385
3386 2019-02-28  Justin Fan  <justin_fan@apple.com>
3387
3388         [Web GPU] Enable Web GPU only on 64-bit
3389         https://bugs.webkit.org/show_bug.cgi?id=195139
3390
3391         Because Metal is only supported on 64 bit apps.
3392
3393         Unreviewed build fix.
3394
3395         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3396
3397 2019-02-27  Youenn Fablet  <youenn@apple.com>
3398
3399         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3400         https://bugs.webkit.org/show_bug.cgi?id=194959
3401
3402         Reviewed by Chris Dumez.
3403
3404         Spin loop until getting the condition to remove flakiness.
3405
3406         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3407
3408 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3409
3410         [ews-build] Buildbot should include builder_display_name in the build events
3411         https://bugs.webkit.org/show_bug.cgi?id=195045
3412
3413         Reviewed by Dewei Zhu.
3414
3415         * BuildSlaveSupport/ews-build/events.py:
3416         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3417         buildername to builder_name to be consistent in naming style.
3418         (Events.buildFinished): Ditto.
3419
3420 2019-02-27  Chris Dumez  <cdumez@apple.com>
3421
3422         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3423         https://bugs.webkit.org/show_bug.cgi?id=194480
3424
3425         Reviewed by Brady Eidson.
3426
3427         Update existing API test to make it more likely to reproduce the issue.
3428
3429         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3430
3431 2019-02-27  Brady Eidson  <beidson@apple.com>
3432
3433         Universal links from Google search results pages don't open the app.
3434         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3435
3436         Reviewed by Geoffrey Garen.
3437
3438         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3439         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3440         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3441         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3442
3443 2019-02-27  Chris Dumez  <cdumez@apple.com>
3444
3445         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3446         https://bugs.webkit.org/show_bug.cgi?id=195102
3447
3448         Reviewed by Geoffrey Garen.
3449
3450         If the number of processes is not yet what we expect, wait a bit and check again to give
3451         processes some time to exit.
3452
3453         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3454
3455 2019-02-27  Chris Dumez  <cdumez@apple.com>
3456
3457         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3458         https://bugs.webkit.org/show_bug.cgi?id=194545
3459
3460         Reviewed by Brady Eidson.
3461
3462         Make sure the test navigates forward and then back only once. Previously, navigating
3463         back would trigger a navigation again in a timer.
3464
3465         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3466
3467 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3468
3469         High Sierra Debug JSC test queue should use faster hardware
3470         https://bugs.webkit.org/show_bug.cgi?id=194603
3471
3472         Rubber-stamped by Alexey Proskuryakov.
3473
3474         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3475
3476         * BuildSlaveSupport/build.webkit.org-config/config.json:
3477         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3478         (BubbleQueueServer):
3479         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3480         (WebKitBuildbot):
3481         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3482         * QueueStatusServer/config/queues.py:
3483         * Scripts/webkitpy/common/config/ews.json:
3484         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3485         (test_ews_name):
3486
3487 2019-02-27  John Wilander  <wilander@apple.com>
3488
3489         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3490         https://bugs.webkit.org/show_bug.cgi?id=195071
3491         <rdar://problem/48417690>
3492
3493         Reviewed by Alex Christensen and Brent Fulgham.
3494
3495         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3496         (TestWebKitAPI::createURL):
3497             Convenience function.
3498         (TestWebKitAPI::TEST):
3499             WebCore::AdClickAttribution now takes a URL when creating Source and
3500             Destination.
3501         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3502         (TestWebKitAPI::TEST):
3503             WebCore::AdClickAttribution now takes a URL when creating Source and
3504             Destination.
3505
3506 2019-02-27  Antoine Quint  <graouts@apple.com>
3507
3508         Support Pointer Events on macOS
3509         https://bugs.webkit.org/show_bug.cgi?id=195008
3510         <rdar://problem/47454419>
3511
3512         Reviewed by Dean Jackson.
3513
3514         * DumpRenderTree/mac/DumpRenderTree.mm:
3515         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3516         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3517
3518 2019-02-26  Mark Lam  <mark.lam@apple.com>
3519
3520         Remove remaining poisoning code.
3521         https://bugs.webkit.org/show_bug.cgi?id=194138
3522
3523         Reviewed by Saam Barati.
3524
3525         * TestWebKitAPI/CMakeLists.txt:
3526         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3527         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3528         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3529         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3530         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3531         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3532         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3533
3534 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3535
3536         Move ephemeral local storage from WebProcess to UIProcess
3537         https://bugs.webkit.org/show_bug.cgi?id=195074
3538         <rdar://problem/47937975>
3539
3540         Reviewed by Geoff Garen.
3541
3542         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3543
3544 2019-02-20  Jer Noble  <jer.noble@apple.com>
3545
3546         [Cocoa] Media elements will restart network buffering just before suspending
3547         https://bugs.webkit.org/show_bug.cgi?id=193691
3548
3549         Reviewed by Eric Carlson.
3550
3551         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3552         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3553         (TEST):
3554
3555 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
3556
3557         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
3558         https://bugs.webkit.org/show_bug.cgi?id=191652
3559
3560         Reviewed by Alex Christensen.
3561
3562         Fix WinCairo MiniBrowser behavior of authentication dialog.
3563
3564         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3565         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3566
3567 2019-02-26  Youenn Fablet  <youenn@apple.com>
3568
3569         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
3570         https://bugs.webkit.org/show_bug.cgi?id=195028
3571         <rdar://problem/48243733>
3572
3573         Reviewed by Eric Carlson.
3574
3575         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3576
3577 2019-02-26  Philippe Normand  <pnormand@igalia.com>
3578
3579         [WPE] Add API for webview background color configuration
3580         https://bugs.webkit.org/show_bug.cgi?id=192305
3581
3582         Reviewed by Michael Catanzaro.
3583
3584         * MiniBrowser/wpe/main.cpp:
3585         (main): Add a new option to configure the webview background
3586         color. Example: --bg-color=transparent.
3587         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3588         (testWebViewBackgroundColor): Enable background color API tests for WPE.
3589         (beforeAll): Ditto.
3590
3591 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
3592
3593         scalableNativeWebpageParameters() is not preserved on new page navigation.
3594         https://bugs.webkit.org/show_bug.cgi?id=194892
3595         <rdar://problem/47538280>
3596
3597         Reviewed by Wenson Hsieh.
3598         
3599         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
3600
3601         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3602         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3603         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3604         (WTR::UIScriptController::allowsViewportShrinkToFit):
3605         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3606         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3607         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3608         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3609         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3610         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3611
3612 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3613
3614         [ews-app] Add model for handling multiple Buildbot instances
3615         https://bugs.webkit.org/show_bug.cgi?id=194863
3616
3617         Reviewed by Stephanie Lewis.
3618
3619         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
3620
3621 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3622
3623         [ews-app] Remove BuilderMapping table
3624         https://bugs.webkit.org/show_bug.cgi?id=194961
3625
3626         Reviewed by Stephanie Lewis.
3627
3628         Store builder name directly in build table, instead of having a separate
3629         table for it.
3630
3631         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
3632         * BuildSlaveSupport/ews-app/ews/models/build.py:
3633         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
3634         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3635
3636 2019-02-25  John Wilander  <wilander@apple.com>
3637
3638         Introduce and adopt new class RegistrableDomain for eTLD+1
3639         https://bugs.webkit.org/show_bug.cgi?id=194791
3640         <rdar://problem/48179240>
3641
3642         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
3643
3644         This patch adds an API test and replaces two instances of
3645         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
3646
3647         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3648         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3649         (TestWebKitAPI::TEST):
3650             Changed two strings to make sure the registrable domains are still considered
3651             invalid and pass the test.
3652         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
3653         (TestWebKitAPI::TEST):
3654         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3655         (WTR::InjectedBundle::didReceiveMessageToPage):
3656
3657 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
3658
3659         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
3660         https://bugs.webkit.org/show_bug.cgi?id=195001
3661
3662         Reviewed by Carlos Garcia Campos.
3663
3664         API version 1.0 always includes the functionality previously guarded with
3665         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
3666         unconditionally.
3667
3668         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3669         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
3670         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
3671         (WebViewTest::showInWindow): Ditto.
3672         (WebViewTest::hideView): Ditto.
3673         * wpe/backends/HeadlessViewBackend.cpp:
3674         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
3675         * wpe/backends/ViewBackend.cpp:
3676         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
3677         * wpe/backends/WindowViewBackend.cpp:
3678         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
3679         WPE_BACKEND_CHECK_VERSION().
3680         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
3681
3682 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
3683
3684         [Flatpak] Add support for flatpak > 1.1.2
3685         https://bugs.webkit.org/show_bug.cgi?id=194088
3686
3687         Flatpak 1.2 is now out so we need to support that
3688         version now.
3689
3690         Reviewed by Michael Catanzaro.
3691
3692         * flatpak/flatpakutils.py:
3693         (check_flatpak):
3694         (FlatpakPackages.__init__):
3695         (FlatpakPackages.__detect_packages):
3696         (FlatpakPackages.__detect_packages.in):
3697         (FlatpakRepos.update):
3698
3699 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
3700
3701         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
3702         https://bugs.webkit.org/show_bug.cgi?id=194998
3703
3704         Reviewed by Carlos Garcia Campos.
3705
3706         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
3707         to a Git checkout and using the latest commit containing various fixes
3708         and improvements.
3709
3710 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3711
3712         [WPE][GTK] Remove user agent quirk for washingtonpost.com
3713         https://bugs.webkit.org/show_bug.cgi?id=194981
3714
3715         Reviewed by Žan Doberšek.
3716
3717         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3718         (TestWebKitAPI::TEST):
3719
3720 2019-02-23  Keith Miller  <keith_miller@apple.com>
3721
3722         Add new mac target numbers
3723         https://bugs.webkit.org/show_bug.cgi?id=194955
3724
3725         Reviewed by Tim Horton.
3726
3727         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3728         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3729         * MiniBrowser/Configurations/Base.xcconfig:
3730         * TestWebKitAPI/Configurations/Base.xcconfig:
3731         * WebKitTestRunner/Configurations/Base.xcconfig:
3732
3733 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
3734
3735         [WinCairo] Enable wk1/wk2 suffix for platform search path.
3736         https://bugs.webkit.org/show_bug.cgi?id=194846
3737
3738         Reviewed by Don Olmstead.
3739
3740         Added _search_paths() and _port_specific_expectations_files() for
3741         WinCairoPort.
3742
3743         * Scripts/webkitpy/port/win.py:
3744         (WinCairoPort.default_baseline_search_path):
3745         (WinCairoPort):
3746         (WinCairoPort._port_specific_expectations_files):
3747         (WinCairoPort._search_paths):
3748
3749 2019-02-22  Tim Horton  <timothy_horton@apple.com>
3750
3751         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
3752         https://bugs.webkit.org/show_bug.cgi?id=194963
3753
3754         Reviewed by Dean Jackson.
3755
3756         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3757         Do a `contains` check instead of `equals`, because in debug builds we
3758         put the GraphicsLayer pointer in a prefix.
3759
3760 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3761
3762         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
3763         https://bugs.webkit.org/show_bug.cgi?id=194873
3764         <rdar://problem/46701974>
3765
3766         Reviewed by Tim Horton.
3767
3768         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
3769
3770         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3771         (WTR::UIScriptController::menuRect const):
3772         (WTR::UIScriptController::isShowingMenu const):
3773         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3774         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3775         (WTR::UIScriptController::menuRect const):
3776
3777         Add a function to query the bounds of the callout menu in content coordinates.
3778
3779         (WTR::UIScriptController::isShowingMenu const):
3780
3781         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
3782
3783         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3784         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3785         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3786         (WTR::UIScriptController::rectForMenuAction const):
3787         (WTR::UIScriptController::menuRect const):
3788         (WTR::UIScriptController::isShowingMenu const):
3789         (WTR::findViewInHierarchyOfType): Deleted.
3790
3791 2019-02-22  Chris Dumez  <cdumez@apple.com>
3792
3793         Regression(PSON) Unable to preview password-protected documents on iCloud.com
3794         https://bugs.webkit.org/show_bug.cgi?id=194954
3795         <rdar://problem/48127957>
3796
3797         Reviewed by Alex Christensen.
3798
3799         Add API test coverage.
3800
3801         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3802         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
3803         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3804         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3805
3806 2019-02-22  Chris Dumez  <cdumez@apple.com>
3807
3808         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
3809         https://bugs.webkit.org/show_bug.cgi?id=194924
3810         <rdar://problem/48216125>
3811
3812         Reviewed by Geoffrey Garen.
3813
3814         Add API test coverage.
3815
3816         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3817
3818 2019-02-22  Chris Dumez  <cdumez@apple.com>
3819
3820         Unreviewed, disable API test added in r241928 on iOS.
3821
3822         The cache is not enabled on devices with less than 3GB of RAM.
3823
3824         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3825
3826 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
3827
3828         Hardcode Visual Viewports on everywhere except iOS WK1
3829         https://bugs.webkit.org/show_bug.cgi?id=194928
3830
3831         Reviewed by Zalan Bujtas.
3832
3833         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
3834         change the default value of the Setting to 'true', and hardcode WebView on iOS to
3835         set it to false. The setting has shipped for several years and there's no need to turn
3836         it off now.
3837
3838         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
3839         Visual Viewports are not enabled.
3840         
3841         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
3842         that only runs in WK2
3843
3844         * MiniBrowser/mac/SettingsController.h:
3845         * MiniBrowser/mac/SettingsController.m:
3846         (-[SettingsController init]):
3847         (-[SettingsController _populateMenu]):
3848         (-[SettingsController validateMenuItem:]):
3849         (-[SettingsController visualViewportEnabled]): Deleted.
3850         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
3851         * MiniBrowser/mac/WK1BrowserWindowController.m:
3852         (-[WK1BrowserWindowController didChangeSettings]):
3853         * MiniBrowser/mac/WK2BrowserWindowController.m:
3854         (-[WK2BrowserWindowController didChangeSettings]):
3855
3856 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
3857
3858         Discard cached processes when clearing website data store
3859         https://bugs.webkit.org/show_bug.cgi?id=194894
3860
3861         Reviewed by Chris Dumez.
3862
3863         Added a test case.
3864
3865         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3866         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
3867
3868 2019-02-21  Alex Christensen  <achristensen@webkit.org>
3869
3870         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
3871         https://bugs.webkit.org/show_bug.cgi?id=194914
3872         <rdar://problem/47586889>
3873
3874         Reviewed by Geoffrey Garen.
3875
3876         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3877         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
3878         (TEST):
3879         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
3880
3881 2019-02-21  David Kilzer  <ddkilzer@apple.com>
3882
3883         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
3884         <https://webkit.org/b/194761>
3885
3886         Reviewed by Myles Maxfield.
3887
3888         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3889         (WTR::activateSystemCoreWebFonts): Log `error` to console if
3890         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
3891         to use ARC-compliant cast.
3892         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
3893         ARC-compliant cast.
3894         (WTR::installFakeHelvetica): Log `error` to console if
3895         CTFontManagerRegisterFontsForURL() fails, but only on supported
3896         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
3897         Call CFRelease() on `error` to fix the leak.  Update to use
3898         ARC-compliant cast.
3899         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
3900         cast.
3901
3902 2019-02-21  Chris Dumez  <cdumez@apple.com>
3903
3904         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
3905         https://bugs.webkit.org/show_bug.cgi?id=194481
3906
3907         Reviewed by Alex Christensen.
3908
3909         Give the processes a chance to shutdown and wait until we reached the expected number
3910         of processes.
3911
3912         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3913
3914 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3915
3916         Fix the macOS build
3917
3918         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3919
3920 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3921
3922         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3923
3924         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3925         I am a backwards.
3926
3927 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3928
3929         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
3930
3931         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3932         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
3933         We could force on UI-side compositing, but I feel like the test might be more
3934         valuable exercising the normal path on each platform (though the original
3935         bug was also UI-side specific). Though we can't validate that the overlay
3936         layer was installed successfully, there are layout tests that do that.
3937
3938 2019-02-21  Tim Horton  <timothy_horton@apple.com>
3939
3940         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
3941         https://bugs.webkit.org/show_bug.cgi?id=194845
3942         <rdar://problem/47944579>
3943
3944         Reviewed by Antti Koivisto.
3945
3946         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3947         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3948
3949 2019-02-21  Zalan Bujtas  <zalan@apple.com>
3950
3951         [LFC][Floats] Add support for placing formatting roots in-between floats.
3952         https://bugs.webkit.org/show_bug.cgi?id=194902
3953
3954         Reviewed by Antti Koivisto.
3955
3956         * LayoutReloaded/misc/LFC-passing-tests.txt:
3957
3958 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
3959
3960         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
3961         https://bugs.webkit.org/show_bug.cgi?id=194901
3962
3963         Unreviewed build fix.
3964
3965         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
3966         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
3967         WPEBackend-fdo-0.1 as library name.
3968
3969 2019-02-21  Rob Buis  <rbuis@igalia.com>
3970
3971         Update MIME type parser
3972         https://bugs.webkit.org/show_bug.cgi?id=180526
3973
3974         Reviewed by Darin Adler.
3975
3976         Add tests involving leading and trailing whitespace, non-token
3977         characters and quoted strings.
3978
3979         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3980         (TestWebKitAPI::TEST):
3981
3982 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
3983
3984         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
3985         https://bugs.webkit.org/show_bug.cgi?id=194884
3986
3987         Reviewed by Michael Catanzaro.
3988
3989         * PlatformWin.cmake:
3990
3991 2019-02-20  Chris Dumez  <cdumez@apple.com>
3992
3993         Add API test for <rdar://problem/47471222>
3994         https://bugs.webkit.org/show_bug.cgi?id=194847
3995
3996         Reviewed by Alex Christensen.
3997
3998         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3999
4000 2019-02-20  Chris Dumez  <cdumez@apple.com>
4001
4002         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
4003         https://bugs.webkit.org/show_bug.cgi?id=194872
4004         <rdar://problem/47924500>
4005
4006         Reviewed by Alex Christensen.
4007
4008         Add API test coverage.
4009
4010         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4011
4012 2019-02-20  Jer Noble  <jer.noble@apple.com>
4013
4014         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
4015         https://bugs.webkit.org/show_bug.cgi?id=191332
4016
4017         Reviewed by Dean Jackson.
4018
4019         * Scripts/git-is-in-range: Added.
4020
4021 2019-02-20  Andy Estes  <aestes@apple.com>
4022
4023         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
4024         https://bugs.webkit.org/show_bug.cgi?id=194869
4025
4026         Rubber-stamped by Jer Noble.
4027
4028         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4029         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
4030         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
4031         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
4032         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4033         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4034
4035 2019-02-20  Chris Dumez  <cdumez@apple.com>
4036
4037         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
4038         https://bugs.webkit.org/show_bug.cgi?id=194857
4039         <rdar://problem/47759323>
4040
4041         Reviewed by Alex Christensen.
4042
4043         Add API test coverage.
4044
4045         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4046
4047 2019-02-20  Chris Dumez  <cdumez@apple.com>
4048
4049         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
4050         https://bugs.webkit.org/show_bug.cgi?id=194829
4051         <rdar://problem/47889906>
4052
4053         Reviewed by Alexey Proskuryakov.
4054
4055         Every time the TestOptions were changing we were creating both a new Web view and
4056         a new WKContext, which would start a new Network process. In most cases, we only
4057         need to contruct a new Web view and we do can keep reusing the same WKContext.
4058         This patch implements this optimization and thus avoids spinning a lot of new
4059         Network processes while running the layout tests.
4060
4061         * WebKitTestRunner/TestController.cpp:
4062         (WTR::TestController::generateContextConfiguration const):
4063         (WTR::TestController::generatePageConfiguration):
4064         (WTR::TestController::createWebViewWithOptions):
4065         (WTR::TestController::resetPreferencesToConsistentValues):
4066         (WTR::updateTestOptionsFromTestHeader):
4067         * WebKitTestRunner/TestController.h:
4068         * WebKitTestRunner/TestOptions.h:
4069         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
4070         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
4071         (WTR::TestOptions::hasSameInitializationOptions const):
4072         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
4073         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4074         (WTR::TestController::platformAddTestOptions const):
4075
4076 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
4077
4078         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
4079         https://bugs.webkit.org/show_bug.cgi?id=167941
4080
4081         Reviewed by Carlos Garcia Campos.
4082
4083         * MiniBrowser/gtk/main.c:
4084         (filterSavedCallback): Added.
4085         (main): Support loading a JSON rule set file for content filtering.
4086         * MiniBrowser/wpe/main.cpp:
4087         (filterSavedCallback): Added.
4088         (main): Support loading a JSON rule set file for content filtering.
4089         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
4090         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
4091         (WTF::derefGPtr): Ditto.
4092         (testEmptyStore):
4093         (testSaveInvalidFilter):
4094         (testSaveLoadFilter):
4095         (testSavedFilterIdentifierMatch):
4096         (testRemoveFilter):
4097         (testSaveMultipleFilters):
4098         (testSaveFilterFromFile):
4099         (testFilterPersistence):
4100         (beforeAll):
4101         (afterAll):
4102         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
4103         (removeOldInjectedContentAndResetLists): Also reset content filters.
4104         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
4105         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
4106         the element affected by the style sheet.
4107         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
4108         and returns it to be used by tests.
4109         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
4110         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
4111         (serverCallback): Add support for serving a CSS style sheet for testing.
4112         (beforeAll): Add call to testUserContentManagerContentFilter().
4113         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
4114
4115 2019-02-19  Keith Rollin  <krollin@apple.com>
4116
4117         Add timing information to build output
4118         https://bugs.webkit.org/show_bug.cgi?id=194839
4119         <rdar://problem/48219609>
4120
4121         Reviewed by Alexey Proskuryakov.
4122
4123         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
4124         emit each project's build time to its output. E.g.,
4125
4126             ** BUILD SUCCEEDED ** [0.132 sec]
4127
4128         * Scripts/webkitdirs.pm:
4129         (XcodeOptions):
4130
4131 2019-02-19  Truitt Savell  <tsavell@apple.com>
4132
4133         Unreviewed, rolling out r241784.
4134
4135         Broke all OpenSource builds.
4136
4137         Reverted changeset:
4138
4139         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
4140         instances view"
4141         https://bugs.webkit.org/show_bug.cgi?id=172848
4142         https://trac.webkit.org/changeset/241784
4143
4144 2019-02-19  Zalan Bujtas  <zalan@apple.com>
4145
4146         [LFC][Floats] Remove redundant intersecting logic
4147         https://bugs.webkit.org/show_bug.cgi?id=194804
4148
4149         Reviewed by Antti Koivisto.
4150
4151         * LayoutReloaded/misc/LFC-passing-tests.txt:
4152
4153 2019-02-19  Dean Jackson  <dino@apple.com>
4154
4155         Clean-up output from generate-xcfilelists so it can be filtered
4156         https://bugs.webkit.org/show_bug.cgi?id=194795
4157
4158         Reviewed by Joseph Pecoraro (and Keith Rollin).
4159
4160         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
4161         make a slight tweak to filter-build-webkit so such lines are marked
4162         as plain.
4163
4164         * Scripts/filter-build-webkit:
4165         * Scripts/generate-xcfilelists:
4166
4167 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
4168
4169         pytest is not correctly auto-installed
4170         https://bugs.webkit.org/show_bug.cgi?id=194707
4171
4172         Reviewed by Carlos Garcia Campos.
4173
4174         * Scripts/webkitpy/thirdparty/__init__.py:
4175         (AutoinstallImportHook._install_pytest):
4176
4177 2019-02-18  Chris Dumez  <cdumez@apple.com>
4178
4179         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
4180         https://bugs.webkit.org/show_bug.cgi?id=194797
4181         <rdar://problem/48055151>
4182
4183         Reviewed by Geoffrey Garen.
4184
4185         Add API test coverage.
4186
4187         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4188
4189 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
4190
4191         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
4192         https://bugs.webkit.org/show_bug.cgi?id=194670
4193         <rdar://problem/39066529>
4194
4195         Reviewed by Tim Horton.
4196
4197         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
4198         pasted in an editable area as attachment elements.
4199
4200         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
4201         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
4202         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
4203         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4204         (TestWebKitAPI::TEST):
4205         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4206         (WTR::InjectedBundlePage::InjectedBundlePage):
4207
4208 2019-02-18  Alex Christensen  <achristensen@webkit.org>
4209
4210         Fix API test after r241728
4211        ​https://bugs.webkit.org/show_bug.cgi?id=194723
4212
4213         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4214         (TEST):
4215         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
4216
4217 2019-02-18  Daniel Bates  <dabates@apple.com>
4218
4219         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
4220         https://bugs.webkit.org/show_bug.cgi?id=192824
4221         <rdar://problem/47100332>
4222
4223         Reviewed by Wenson Hsieh.
4224
4225         Fix a bug where the wrong usage code was used for F13 thru F24.
4226
4227         * WebKitTestRunner/ios/HIDEventGenerator.mm:
4228         (keyCodeForDOMFunctionKey):
4229
4230 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
4231
4232         Bytecode cache should a have a boot-specific validation
4233         https://bugs.webkit.org/show_bug.cgi?id=194769
4234         <rdar://problem/48149509>
4235
4236         Reviewed by Keith Miller.
4237
4238         Add test for WTF::bootSessionUUIDString()
4239
4240         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4241         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
4242         (TEST):
4243
4244 2019-02-18  Alex Christensen  <achristensen@webkit.org>
4245
4246         Disable safe browsing in WKWebView and remove its WKPreferences API
4247         https://bugs.webkit.org/show_bug.cgi?id=194723
4248         <rdar://problem/48122993>
4249
4250         Reviewed by Geoffrey Garen.
4251
4252         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4253         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4254         (TEST):
4255         (safeBrowsingView):
4256         Make tests use SPI instead of API.
4257
4258 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
4259
4260         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
4261         https://bugs.webkit.org/show_bug.cgi?id=194586
4262
4263         Reviewed by Ross Kirsling.
4264
4265         * DumpRenderTree/win/DumpRenderTree.cpp:
4266         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
4267         * Scripts/webkitpy/port/driver.py:
4268         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
4269
4270 2019-02-17  David Kilzer  <ddkilzer@apple.com>
4271
4272         Unreviewed, rolling out r241620.
4273
4274         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
4275         (Requested by ddkilzer on #webkit.)
4276
4277         Reverted changeset:
4278
4279         "[WTF] Add environment variable helpers"
4280         https://bugs.webkit.org/show_bug.cgi?id=192405
4281         https://trac.webkit.org/changeset/241620
4282
4283 2019-02-16  Zalan Bujtas  <zalan@apple.com>
4284
4285         [LFC] RenderImage's default intrinsic size is 0.
4286         https://bugs.webkit.org/show_bug.cgi?id=194745
4287
4288         Reviewed by Antti Koivisto.
4289
4290         * LayoutReloaded/misc/LFC-passing-tests.txt:
4291
4292 2019-02-16  Zalan Bujtas  <zalan@apple.com>
4293
4294         [LFC][BFC] Add support for block replaced intrinsic width.
4295         https://bugs.webkit.org/show_bug.cgi?id=194705
4296
4297         Reviewed by Simon Fraser.
4298
4299         * LayoutReloaded/misc/LFC-passing-tests.txt:
4300
4301 2019-02-16  Zalan Bujtas  <zalan@apple.com>
4302
4303         [LFC] Apply min/max width constraints to preferred width computation
4304         https://bugs.webkit.org/show_bug.cgi?id=194739
4305
4306         Reviewed by Simon Fraser.
4307
4308         * LayoutReloaded/misc/LFC-passing-tests.txt:
4309
4310 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
4311
4312         [WTF] Add environment variable helpers
4313         https://bugs.webkit.org/show_bug.cgi?id=192405
4314
4315         Reviewed by Michael Catanzaro.
4316
4317         * DumpRenderTree/mac/DumpRenderTree.mm:
4318         (libraryPathForDumpRenderTree):
4319         * DumpRenderTree/win/DumpRenderTree.cpp:
4320         (libraryPathForDumpRenderTree):
4321         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
4322         (setUpIOSLayoutTestCommunication):
4323         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
4324         (beforeAll):
4325         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
4326         (main):
4327         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
4328         (WebKitTestBus::run):
4329         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
4330         (WTR::getOutputDir):
4331         (WTR::initializeFontConfigSetting):
4332         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
4333         (WTR::InjectedBundle::platformInitialize):
4334         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
4335         (WTR::topLevelPath):
4336         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
4337         (WTR::topLevelPath):
4338         (WTR::getOutputDir):
4339         (WTR::activateFonts):
4340         * WebKitTestRunner/TestController.cpp:
4341         (WTR::TestController::libraryPathForTesting):
4342         (WTR::TestController::generateContextConfiguration const):
4343         (WTR::TestController::generatePageConfiguration):
4344         (WTR::TestController::decideDestinationWithSuggestedFilename):
4345         (WTR::TestController::platformAdjustContext):
4346         * WebKitTestRunner/TestController.h:
4347         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4348         (WTR::TestController::cocoaPlatformInitialize):
4349         (WTR::TestController::platformAdjustContext):
4350         * WebKitTestRunner/gtk/main.cpp:
4351         (main):
4352         * WebKitTestRunner/mac/TestControllerMac.mm:
4353         (WTR::TestController::configureContentExtensionForTest):
4354         * WebKitTestRunner/wpe/main.cpp:
4355         (main):
4356         Utilize WTF::Environment where possible.
4357
4358 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
4359
4360         [iOS] WKWebView callout bar is missing Change Writing Direction item
4361         https://bugs.webkit.org/show_bug.cgi?id=190015
4362         <rdar://problem/44810366>
4363
4364         Reviewed by Tim Horton.
4365
4366         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
4367         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
4368
4369         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
4370         (TestWebKitAPI::TEST):
4371
4372 2019-02-15  Chris Dumez  <cdumez@apple.com>
4373
4374         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
4375         https://bugs.webkit.org/show_bug.cgi?id=194717
4376         <rdar://problem/47884404>
4377
4378         Reviewed by Brady Eidson.
4379
4380         Add API test coverage.
4381
4382         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4383
4384 2019-02-15  Youenn Fablet  <youenn@apple.com>
4385
4386     &