Unreviewed, rolling out r243465.
[WebKit-https.git] / Tools / ChangeLog
1 2019-03-25  Commit Queue  <commit-queue@webkit.org>
2
3         Unreviewed, rolling out r243465.
4         https://bugs.webkit.org/show_bug.cgi?id=196226
5
6         the test doesn't build (Requested by thorton on #webkit).
7
8         Reverted changeset:
9
10         "Do not terminate the NetworkProcess if a third party
11         application sends a NSCredential with a SecIdentityRef"
12         https://bugs.webkit.org/show_bug.cgi?id=196213
13         https://trac.webkit.org/changeset/243465
14
15 2019-03-25  Alex Christensen  <achristensen@webkit.org>
16
17         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
18         https://bugs.webkit.org/show_bug.cgi?id=196213
19
20         Reviewed by Geoff Garen.
21
22         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
23         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
24         (credentialWithIdentityAndKeychainPath):
25         (-[ChallengeDelegate webView:didFinishNavigation:]):
26         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
27         (TestWebKitAPI::TEST):
28
29 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
30
31         [ews-build] Gracefully handle missing patch_id in events
32         https://bugs.webkit.org/show_bug.cgi?id=196216
33
34         Reviewed by Lucas Forschler.
35
36         * BuildSlaveSupport/ews-build/events.py:
37
38 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
39
40         [ews-build] use lz4 compression for improving buildbot performance
41         https://bugs.webkit.org/show_bug.cgi?id=196155
42
43         Reviewed by Lucas Forschler.
44
45         * BuildSlaveSupport/ews-build/master.cfg:
46
47 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
48
49         Pull some API testing helper methods out of TestWKWebView
50         https://bugs.webkit.org/show_bug.cgi?id=196212
51
52         Reviewed by Tim Horton.
53
54         Refactor some more API testing utility methods, so that they can be used in
55         tests that do not use TestWKWebView.
56
57         * TestWebKitAPI/cocoa/TestWKWebView.h:
58         * TestWebKitAPI/cocoa/TestWKWebView.mm:
59         (-[WKWebView loadTestPageNamed:]):
60         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
61         (-[WKWebView synchronouslyLoadHTMLString:]):
62         (-[WKWebView synchronouslyLoadTestPageNamed:]):
63         (-[TestWKWebView loadTestPageNamed:]): Deleted.
64         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
65         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
66         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
67
68 2019-03-25  Jer Noble  <jer.noble@apple.com>
69
70         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
71         https://bugs.webkit.org/show_bug.cgi?id=196097
72
73         Reviewed by Eric Carlson.
74
75         Drive-by bug fix: allow tests to play audio without a user gesture by default.
76
77         * DumpRenderTree/mac/DumpRenderTree.mm:
78         (resetWebPreferencesToConsistentValues):
79         * WebKitTestRunner/TestController.cpp:
80         (WTR::TestController::resetPreferencesToConsistentValues):
81
82 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
83
84         Pull IPadUserInterfaceSwizzler out into a separate header file
85         https://bugs.webkit.org/show_bug.cgi?id=196193
86
87         Reviewed by Anders Carlsson.
88
89         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
90         be used in other API tests.
91
92         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
93         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
94         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
95         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
96         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
97         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
98         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
99
100 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
101
102         Remove NavigatorContentUtils in WebCore/Modules
103         https://bugs.webkit.org/show_bug.cgi?id=196070
104
105         Reviewed by Alex Christensen.
106
107         NavigatorContentUtils was to support the custom scheme spec [1].
108         However, in WebKit side, no port has supported the feature in
109         WebKit layer after EFL port was removed. So there has been the
110         only IDL implementation of the NavigatorContentUtils in WebCore.
111         So we don't need to keep the implementation in WebCore anymore.
112
113         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
114
115         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
116
117 2019-03-24  Andy Estes  <aestes@apple.com>
118
119         [watchOS] Remove unused Proximity Networking code
120         https://bugs.webkit.org/show_bug.cgi?id=196188
121
122         Reviewed by Tim Horton.
123
124         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
125         (TEST):
126
127 2019-03-23  Keith Miller  <keith_miller@apple.com>
128
129         Refactor clz/ctz and fix getLSBSet.
130         https://bugs.webkit.org/show_bug.cgi?id=196162
131
132         Reviewed by Saam Barati.
133
134         Add tests for clz, ctz, getLSBSet, and getMSBSet.
135
136         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
137         (TestWebKitAPI::TEST):
138
139 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
140
141         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
142         https://bugs.webkit.org/show_bug.cgi?id=196143
143
144         Reviewed by Michael Catanzaro.
145
146         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
147         directories.
148
149         * Scripts/webkitpy/style/checkers/cpp.py:
150         (check_identifier_name_in_declaration):
151         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
152         (WebKitStyleTest.test_names):
153
154 2019-03-22  Philippe Normand  <pnormand@igalia.com>
155
156         [Flatpak] Manifest expanding fails for qt WPE extension
157         https://bugs.webkit.org/show_bug.cgi?id=196148
158
159         Reviewed by Alex Christensen.
160
161         * flatpak/flatpakutils.py:
162         (expand_submodules_recurse): The last recurse manifest expand
163         iteration might lead to a single module so take it into account
164         and don't try to recurse further.
165
166 2019-03-22  Chris Dumez  <cdumez@apple.com>
167
168         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
169         https://bugs.webkit.org/show_bug.cgi?id=195348
170         <rdar://problem/48622090>
171
172         Reviewed by Alex Christensen.
173
174         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
175         to NO when test.options().shouldIgnoreMetaViewport is false.
176
177         * WebKitTestRunner/ios/TestControllerIOS.mm:
178         (WTR::TestController::platformConfigureViewForTest):
179
180 2019-03-22  Chris Dumez  <cdumez@apple.com>
181
182         Prewarmed processes should be usable with any website data store
183         https://bugs.webkit.org/show_bug.cgi?id=196104
184
185         Reviewed by Alex Christensen.
186
187         Add API test coverage.
188
189         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
190         (runInitialWarmedProcessUsedTest):
191         (TEST):
192
193 2019-03-22  David Kilzer  <ddkilzer@apple.com>
194
195         Back out local changes to Alex's Subversion working directory
196
197         They were accidentally committed.
198
199         * Scripts/webkitpy/common/system/abstractexecutive.py:
200         (AbstractExecutive.wait_newest):
201         * Scripts/webkitpy/common/system/executive.py:
202         (Executive.running_pids):
203         * Scripts/webkitpy/common/system/executive_mock.py:
204         (MockExecutive.running_pids):
205         * Scripts/webkitpy/common/system/executive_unittest.py:
206         (ExecutiveTest.serial_test_running_pids):
207         * Scripts/webkitpy/port/darwin.py:
208         (DarwinPort.check_for_leaks):
209         * Scripts/webkitpy/port/leakdetector.py:
210         (LeakDetector.check_for_leaks):
211         - This was the hack attached to Bug 193772.
212
213         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
214         (+[WebKitTestRunnerEvent mouseLocation]):
215         - This works around a crash on an internal build.
216
217 2019-03-22  Tim Horton  <timothy_horton@apple.com>
218
219         Fix the build after r243354
220         https://bugs.webkit.org/show_bug.cgi?id=196138
221         <rdar://problem/49145951>
222
223         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
224         (TEST):
225         * TestWebKitAPI/ios/UIKitSPI.h:
226
227 2019-03-21  Tim Horton  <timothy_horton@apple.com>
228
229         Adopt UIWKDocumentContext
230         https://bugs.webkit.org/show_bug.cgi?id=196040
231         <rdar://problem/48642440>
232
233         Reviewed by Ryosuke Niwa.
234
235         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
236         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
237         (makeRequest):
238         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
239         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
240         (applyStyle):
241         (TEST):
242         Add tests for UIWKDocumentContext.
243
244         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
245         (TEST):
246         (recursiveFindWKContentView): Deleted.
247         * TestWebKitAPI/cocoa/TestWKWebView.h:
248         * TestWebKitAPI/cocoa/TestWKWebView.mm:
249         (recursiveFindWKContentView):
250         (-[TestWKWebView wkContentView]):
251         * TestWebKitAPI/ios/UIKitSPI.h:
252         Share the WKContentView finding code between tests.
253
254 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
255
256         [iOS WK2] Turn on async overflow scrolling by default
257         https://bugs.webkit.org/show_bug.cgi?id=196011
258         rdar://problem/48453859
259
260         Reviewed by Antti Koivisto.
261         
262         Explicitly turn off the async overflow scrolling internal feature for tests by default,
263         since so many basic layout tests have different results when compositing is triggered for
264         overflow.
265         
266         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
267
268         * WebKitTestRunner/TestController.cpp:
269         (WTR::TestController::resetPreferencesToConsistentValues):
270
271 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
272
273         [ews-build] Retry API test in case of failures
274         https://bugs.webkit.org/show_bug.cgi?id=196004
275
276         Reviewed by Lucas Forschler.
277
278         * BuildSlaveSupport/ews-build/steps.py:
279         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
280         (CompileWebKitToT.doStepIf): Ditto.
281         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
282         (ReRunAPITests): Re-run API tests.
283         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
284         (RunAPITestsWithoutPatch): Run API tests without patch.
285         (RunAPITestsWithoutPatch.doStepIf):
286         (RunAPITestsWithoutPatch.hideStepIf):
287         (RunAPITestsWithoutPatch.evaluateCommand):
288         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
289         (AnalyzeAPITestsResults.start):
290         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
291         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
292         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
293         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
294
295 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
296
297         [ews-build] Update queues configurations
298         https://bugs.webkit.org/show_bug.cgi?id=196074
299
300         Reviewed by Dewei Zhu.
301
302         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
303         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
304
305 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
306
307         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
308         https://bugs.webkit.org/show_bug.cgi?id=195680
309         <rdar://problem/48903534>
310
311         Unreviewed infrastructure fix.
312
313         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
314         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
315
316 2019-03-21  Andy Estes  <aestes@apple.com>
317
318         [iOS] Apple Pay should be available in documents with no user agent scripts
319         https://bugs.webkit.org/show_bug.cgi?id=196061
320         <rdar://problem/48649391>
321
322         Reviewed by Brady Eidson.
323
324         Added API tests and related infrastructure.
325
326         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
327         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
328         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
329         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
330         (TestWebKitAPI::TEST):
331         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
332         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
333         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
334         * TestWebKitAPI/cocoa/TestProtocol.mm:
335         (-[TestProtocol startLoading]):
336         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
337         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
338         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
339         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
340
341 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
342
343         REGRESSSION (r243297): webkitpy tests broken
344         https://bugs.webkit.org/show_bug.cgi?id=196108
345
346         Reviewed by Aakash Jain.
347
348         r243297 updated contributors.json, which broke a few unit tests.
349
350         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
351         (IRCCommandTest.test_whois):
352         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
353
354 2019-03-21  Chris Dumez  <cdumez@apple.com>
355
356         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
357         https://bugs.webkit.org/show_bug.cgi?id=196041
358         <rdar://problem/49083230>
359
360         Reviewed by Alex Christensen.
361
362         Add API test coverage.
363
364         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
365         (TEST):
366
367 2019-03-21  Alex Christensen  <achristensen@webkit.org>
368
369         Add SPI to inform applications of WKContentRuleList actions
370         https://bugs.webkit.org/show_bug.cgi?id=195965
371         <rdar://problem/42664365>
372
373         Reviewed by Geoff Garen.
374
375         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
376         (TestWebKitAPI::allActionsForResourceLoad):
377         (TestWebKitAPI::testRequest):
378         (TestWebKitAPI::TEST_F):
379         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
380         (Notification::description):
381         (Notification::operator== const):
382         (toVector):
383         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
384         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
385         (makeContentRuleList):
386         (TEST):
387         (makeWarnContentRuleList): Deleted.
388
389 2019-03-21  Timothy Hatcher  <timothy@apple.com>
390
391         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
392         https://bugs.webkit.org/show_bug.cgi?id=196088
393
394         Reviewed by Brian Burg.
395
396         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
397         Support checks when only one platform is specified. Also deprecate macosx() and
398         force the use of macos() instead.
399
400         * Scripts/webkitpy/style/checkers/cpp.py:
401         (check_min_versions_of_wk_api_available):
402         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
403         (WebKitStyleTest.test_min_versions_of_wk_api_available):
404
405 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
406
407         Update status inactive committers' status to 'contributor'.
408
409         * Scripts/webkitpy/common/config/contributors.json:
410
411 2019-03-21  Xan Lopez  <xan@igalia.com>
412
413         [JSC][x86] Drop support for x87 floating point
414         https://bugs.webkit.org/show_bug.cgi?id=194853
415
416         Reviewed by Don Olmstead.
417
418         Force SSE2 on x86/32bit builds.
419
420         * Scripts/webkitdirs.pm:
421         (generateBuildSystemFromCMakeProject):
422
423 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
424
425         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
426         https://bugs.webkit.org/show_bug.cgi?id=196073
427
428         Reviewed by Michael Catanzaro.
429
430         Add test cases to check functions and constructors with no arguments but receiving user data.
431
432         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
433         (checkUserData):
434         (testJSCFunction):
435         (fooCreateWithUserData):
436         (testJSCClass):
437
438 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
439
440         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
441
442         Add g_assert_cmpfloat_with_epsilon macro if not defined.
443
444         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
445
446 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
447
448         [GTK][WPE] Add API to provide geolocation information
449         https://bugs.webkit.org/show_bug.cgi?id=195940
450
451         Reviewed by Michael Catanzaro.
452
453         Add a new test to check the new API.
454
455         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
456         (testGeolocationManagerCurrentPosition):
457         (testGeolocationManagerWatchPosition):
458         (beforeAll):
459         (afterAll):
460         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
461         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
462         (beforeAll): Ditto.
463         * TestWebKitAPI/glib/CMakeLists.txt:
464
465 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
466
467         [GLib] Returning G_TYPE_OBJECT from a method does not work
468         https://bugs.webkit.org/show_bug.cgi?id=195574
469
470         Reviewed by Michael Catanzaro.
471
472         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
473
474         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
475         (getGFile):
476         (getParent):
477         (createGString):
478         (getGString):
479         (getGStringCopyWillRaise):
480         (getGStringCopy):
481         (getGStringStr):
482         (getGStringLen):
483         (freeGString):
484         (testJSCClass):
485
486 2019-03-20  Saam Barati  <sbarati@apple.com>
487
488         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
489         https://bugs.webkit.org/show_bug.cgi?id=195721
490
491         Reviewed by Filip Pizlo.
492
493         * Scripts/run-javascriptcore-tests:
494
495 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
496
497         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
498         https://bugs.webkit.org/show_bug.cgi?id=196049
499
500         Reviewed by Tim Horton.
501
502         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
503         overflow scrolling in general, so rename it.
504
505         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
506
507 2019-03-20  Daniel Bates  <dabates@apple.com>
508
509         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
510         https://bugs.webkit.org/show_bug.cgi?id=196031
511         <rdar://problem/49078172>
512
513         Reviewed by Tim Horton.
514
515         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
516         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
517         same code path used when the Done button is pressed to dismiss the <select> picker.
518
519         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
520         (TestWebKitAPI::TEST):
521
522 2019-03-20  Chris Dumez  <cdumez@apple.com>
523
524         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
525         https://bugs.webkit.org/show_bug.cgi?id=196029
526         <rdar://problem/48954651>
527
528         Reviewed by Tim Horton.
529
530         Add API test coverage.
531
532         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
533
534 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
535
536         [ews-build] Improve failure summary string for ApplyPatch step
537         https://bugs.webkit.org/show_bug.cgi?id=195995
538
539         Reviewed by Alexey Proskuryakov.
540
541         * BuildSlaveSupport/ews-build/steps.py:
542         (ApplyPatch.getResultSummary): Override getResultSummary.
543
544 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
545
546         AX: Implement support for new meter ARIA role
547         https://bugs.webkit.org/show_bug.cgi?id=195966
548
549         Reviewed by Chris Fleizach.
550
551         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
552         to AXLevelIndicator.
553
554         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
555
556 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
557
558         [WebAuthN] Implement FIDO AppID extension
559         https://bugs.webkit.org/show_bug.cgi?id=143491
560         <rdar://problem/48298273>
561
562         Reviewed by Brent Fulgham.
563
564         Add a test that covers the new flag of convertToU2fSignCommand.
565
566         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
567         (TestWebKitAPI::TEST):
568         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
569         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
570         (TestWebKitAPI::TEST):
571
572 2019-03-19  Keith Rollin  <krollin@apple.com>
573
574         Add support for more platforms to generate-xcfilelists
575         https://bugs.webkit.org/show_bug.cgi?id=195977
576
577         Reviewed by Alexey Proskuryakov.
578
579         generate-xcfilelists incorrectly complains when involved with building
580         WebKit for iphonesimulator:
581
582             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
583             …
584             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
585
586         Address this by teaching generate-xcfilelists about more platforms.
587
588         * Scripts/generate-xcfilelists:
589
590 2019-03-19  John Wilander  <wilander@apple.com>
591
592         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
593         https://bugs.webkit.org/show_bug.cgi?id=195923
594         <rdar://problem/49001272>
595
596         Reviewed by Alex Christensen.
597
598         This patch does the following to the TestRunner:
599         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
600         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
601         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
602
603         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
604         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
605         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
606         * WebKitTestRunner/InjectedBundle/TestRunner.h:
607         * WebKitTestRunner/TestController.cpp:
608         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
609         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
610         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
611         * WebKitTestRunner/TestController.h:
612         * WebKitTestRunner/TestInvocation.cpp:
613         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
614
615 2019-03-19  Christopher Reid  <chris.reid@sony.com>
616
617         [CMake] Support more clang and gcc sanitizers
618         https://bugs.webkit.org/show_bug.cgi?id=195956
619
620         Reviewed by Michael Catanzaro.
621
622         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
623
624 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
625
626         [ews-build] Improve summary for PrintConfiguration step
627         https://bugs.webkit.org/show_bug.cgi?id=195945
628
629         Reviewed by Lucas Forschler.
630
631         * BuildSlaveSupport/ews-build/steps.py:
632         (PrintConfiguration.getResultSummary): Override getResultSummary.
633
634 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
635
636         [ews-build] Improve summary for CheckOutSource step
637         https://bugs.webkit.org/show_bug.cgi?id=195963
638
639         Reviewed by Lucas Forschler.
640
641         * BuildSlaveSupport/ews-build/steps.py:
642         (CheckOutSource.getResultSummary):
643
644 2019-03-19  Daniel Bates  <dabates@apple.com>
645
646         [iOS] Focus not preserved when switching between tabs
647         https://bugs.webkit.org/show_bug.cgi?id=195820
648         <rdar://problem/43614450>
649
650         Reviewed by Brent Fulgham.
651
652         Add tests to ensure that we restore focus when resigning and becoming first responder.
653
654         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
655         (TestWebKitAPI::TEST):
656
657 2019-03-19  Alex Christensen  <achristensen@webkit.org>
658
659         Make WTFLogChannelState and WTFLogLevel enum classes
660         https://bugs.webkit.org/show_bug.cgi?id=195904
661
662         Reviewed by Eric Carlson.
663
664         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
665         (TestWebKitAPI::TEST_F):
666
667 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
668
669         [GStreamer][EME] Backported mssdemux protection data crash fix
670         https://bugs.webkit.org/show_bug.cgi?id=195918
671
672         Reviewed by Philippe Normand.
673
674         * gstreamer/jhbuild.modules:
675         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
676
677 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
678
679         Unreviewed, rolling out r243132.
680
681         Broke GTK build
682
683         Reverted changeset:
684
685         "Make WTFLogChannelState and WTFLogLevel enum classes"
686         https://bugs.webkit.org/show_bug.cgi?id=195904
687         https://trac.webkit.org/changeset/243132
688
689 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
690
691         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
692
693         * Scripts/webkitdirs.pm:
694         (builtDylibPathForName): Adjust the shared library name that's changed
695         with the API version bump in r243073.
696
697 2019-03-18  Alex Christensen  <achristensen@webkit.org>
698
699         Make WTFLogChannelState and WTFLogLevel enum classes
700         https://bugs.webkit.org/show_bug.cgi?id=195904
701
702         Reviewed by Eric Carlson.
703
704         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
705         (TestWebKitAPI::TEST_F):
706
707 2019-03-18  Alex Christensen  <achristensen@webkit.org>
708
709         Disable flaky test added in r2431100
710         https://webkit.org/b/195785
711
712         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
713         (TestWebKitAPI::TEST):
714         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
715
716 2019-03-18  Timothy Hatcher  <timothy@apple.com>
717
718         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
719         https://bugs.webkit.org/show_bug.cgi?id=195916
720
721         Reviewed by Tim Horton.
722
723         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
724         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
725
726 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
727
728         Add a secondary e-mail address for Fujii Hironori to make tools happier.
729
730         * Scripts/webkitpy/common/config/contributors.json:
731
732 2019-03-18  Alex Christensen  <achristensen@webkit.org>
733
734         Implement DownloadMonitor to prevent long-running slow downloads from background apps
735         https://bugs.webkit.org/show_bug.cgi?id=195785
736
737         Reviewed by Geoffrey Garen.
738
739         * TestWebKitAPI/TCPServer.cpp: Added.
740         (TestWebKitAPI::TCPServer::TCPServer):
741         (TestWebKitAPI::TCPServer::~TCPServer):
742         (TestWebKitAPI::TCPServer::socketBindListen):
743         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
744         * TestWebKitAPI/TCPServer.h: Added.
745         (TestWebKitAPI::TCPServer::port const):
746         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
747         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
748         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
749         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
750         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
751         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
752         (TestWebKitAPI::respondSlowly):
753         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
754         (TestWebKitAPI::downloadAtRate):
755         (TestWebKitAPI::TEST):
756
757 2019-03-18  Saam Barati  <sbarati@apple.com>
758
759         Add a plan file for JetStream 2
760         https://bugs.webkit.org/show_bug.cgi?id=190734
761
762         Reviewed by Mark Lam.
763
764         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
765
766 2019-03-18  Chris Dumez  <cdumez@apple.com>
767
768         Delay WebProcess launch until a load is triggered in a Web view
769         https://bugs.webkit.org/show_bug.cgi?id=195758
770         <rdar://problem/48126013>
771
772         Reviewed by Geoff Garen.
773
774         Add API test coverage. Also update some existing API tests to not expect
775         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
776
777         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
778         (TestWebKitAPI::TEST):
779         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
780         (TestWebKitAPI::TEST):
781         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
782         (TEST):
783         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
784         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
785         (TEST):
786         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
787         (TEST):
788         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
789
790 2019-03-18  Xan Lopez  <xan@igalia.com>
791
792         [CMake] Prevent potential warning when determining $architecture
793         https://bugs.webkit.org/show_bug.cgi?id=195891
794
795         Reviewed by Michael Catanzaro.
796
797         It's possible for generateBuildSystemForCMakeProject to be called
798         before determineArchitecture() is ever called. This will make the
799         first eq check with $architecture to be bogus (and print a
800         warning). Change that to an eq check with architecture(), which
801         implicitly calls determineArchitecture() if needed, and change all
802         the other similar cases in the method in the same way to prevent
803         future bugs like this one.
804
805         * Scripts/webkitdirs.pm:
806         (generateBuildSystemFromCMakeProject):
807
808 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
809
810         [WPE] Tarballs generated with “make dist” cannot build documentation
811         https://bugs.webkit.org/show_bug.cgi?id=195885
812
813         Reviewed by Carlos Garcia Campos.
814
815         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
816
817 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
818
819         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
820         https://bugs.webkit.org/show_bug.cgi?id=195883
821
822         Reviewed by Carlos Garcia Campos.
823
824         * gtkdoc/gtkdoc.py:
825         (GTKDoc._run_command): When commands fail to run, include the full command line for
826         the program invocation and the output it has generated on the standard error stream.
827
828 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
829
830         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
831         https://bugs.webkit.org/show_bug.cgi?id=195786
832
833         Reviewed by Philippe Normand.
834
835         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
836         * wpe/jhbuild.modules: Ditto.
837
838 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
839
840         [ews-build] Don't run clean builds on EWS builders
841         https://bugs.webkit.org/show_bug.cgi?id=195851
842
843         Reviewed by Geoffrey Garen.
844
845         * BuildSlaveSupport/ews-build/factories.py:
846
847 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
848
849         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
850         https://bugs.webkit.org/show_bug.cgi?id=195849
851
852         Reviewed by Chris Dumez.
853
854         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
855
856         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
857         (runWebsiteDataStoreCustomPaths):
858
859 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
860
861         webkitpy: Upload test results
862         https://bugs.webkit.org/show_bug.cgi?id=195755
863         <rdar://problem/48896182>
864
865         Reviewed by Aakash Jain.
866
867         Establish a new format for uploading results that is not tied to layout tests, apply
868         that format to webkitpy tests.
869
870         * Scripts/webkitpy/common/checkout/scm/git.py:
871         (Git.native_branch): Return what branch the current checkout is on.
872         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
873         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
874         * Scripts/webkitpy/common/checkout/scm/svn.py:
875         (SVN.native_branch): Ditto.
876         * Scripts/webkitpy/common/system/platforminfo.py:
877         (PlatformInfo.build_version): Return a build version for Mac.
878         * Scripts/webkitpy/common/system/platforminfo_mock.py:
879         (MockPlatformInfo.__init__):
880         (MockPlatformInfo.build_version):
881         * Scripts/webkitpy/results: Added.
882         * Scripts/webkitpy/results/__init__.py: Added.
883         * Scripts/webkitpy/results/options.py: Added.
884         (upload_options): OptParse list for upload options.
885         * Scripts/webkitpy/results/upload.py: Added.
886         (Upload): Class which enforces the upload format expected by the results server.
887         (Upload.Expectations):
888         (Upload.create_configuration):
889         (Upload.create_commit):
890         (Upload.create_details):
891         (Upload.create_run_stats):
892         (Upload.create_test_result):
893         (Upload.__init__):
894         (Upload.Encoder): Encode Upload object as json.
895         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
896         * Scripts/webkitpy/results/upload_unittest.py: Added.
897         * Scripts/webkitpy/test/main.py:
898         (Tester._parse_args): Add upload arguments.
899         (Tester._run_tests): Allow results to be uploaded.
900         * Scripts/webkitpy/test/runner.py:
901         (Runner.__init__): Record which tests were run, rather than just counting them.
902         (Runner.handle):
903         * Scripts/webkitpy/test/runner_unittest.py:
904         (RunnerTest.test_run):
905         * Scripts/webkitpy/thirdparty/__init__.py:
906         (AutoinstallImportHook.find_module): Add requests auto-install.
907         (AutoinstallImportHook._install_requests):
908         * Scripts/webkitpy/tool/commands/queues_unittest.py:
909         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
910
911 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
912
913         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
914         https://bugs.webkit.org/show_bug.cgi?id=195810
915
916         Reviewed by Tim Horton.
917
918         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
919         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
920         ending certain layout tests.
921
922         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
923         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
924         (-[TestRunnerWKWebView dealloc]):
925         (-[TestRunnerWKWebView resetInteractionCallbacks]):
926
927         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
928         helper method when destroying the web view, and when resetting state between tests.
929
930         * WebKitTestRunner/ios/TestControllerIOS.mm:
931         (WTR::TestController::platformResetStateToConsistentValues):
932
933         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
934
935 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
936
937         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
938         https://bugs.webkit.org/show_bug.cgi?id=190350
939         <rdar://problem/45089503>
940
941         Reviewed by Geoffrey Garen.
942
943         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
944         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
945         (TEST):
946         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
947         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
948         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
949         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
950         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
951         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
952         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
953         (runTest):
954         (createDirectories):
955         (TEST):
956         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
957         (TEST):
958         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
959         (TEST):
960
961 2019-03-15  Timothy Hatcher  <timothy@apple.com>
962
963         Add support to WebPage for getting the contents as an attributed string.
964         https://bugs.webkit.org/show_bug.cgi?id=195636
965         rdar://problem/45055697
966
967         Reviewed by Tim Horton.
968
969         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
970         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
971
972 2019-03-15  Chris Dumez  <cdumez@apple.com>
973
974         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
975         https://bugs.webkit.org/show_bug.cgi?id=195747
976
977         Reviewed by Geoff Garen.
978
979         Add API test coverage.
980
981         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
982
983 2019-03-15  Shawn Roberts  <sroberts@apple.com>
984
985         Unreviewed, rolling out r242952.
986
987         Causing API failures on iOS Simulator
988
989         Reverted changeset:
990
991         "[PSON] Make sure the WebProcessCache is leverage when
992         relaunching a process after termination"
993         https://bugs.webkit.org/show_bug.cgi?id=195747
994         https://trac.webkit.org/changeset/242952
995
996 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
997
998         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
999         https://bugs.webkit.org/show_bug.cgi?id=195740
1000
1001         Reviewed by Ross Kirsling.
1002
1003         window.open doesn't work for WebKitBrowserWindow because it is not
1004         implemented yet.
1005
1006         1. Implemented createNewPage callback of WKPageUIClient.
1007         2. Changed MainWindow to take a BrowserWindow factory function
1008           instead of BrowserWindowType to be flexible to create
1009           BrowserWindow with extra settings.
1010         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
1011           because it is not relevant with MainWindow anymore.
1012
1013         * MiniBrowser/win/Common.cpp:
1014         (parseCommandLine):
1015         * MiniBrowser/win/Common.h:
1016         (CommandLineOptions::CommandLineOptions):
1017         * MiniBrowser/win/MainWindow.cpp:
1018         (MainWindow::MainWindow):
1019         (MainWindow::create):
1020         (MainWindow::init):
1021         (MainWindow::WndProc):
1022         * MiniBrowser/win/MainWindow.h:
1023         * MiniBrowser/win/PrintWebUIDelegate.cpp:
1024         (PrintWebUIDelegate::createWebViewWithRequest):
1025         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1026         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
1027         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
1028         (WebKitBrowserWindow::updateProxySettings):
1029         (WebKitBrowserWindow::createNewPage):
1030         * MiniBrowser/win/WebKitBrowserWindow.h:
1031         * MiniBrowser/win/WinMain.cpp:
1032         (wWinMain):
1033
1034 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
1035
1036         Make it possible to test scrolling tree layer manipulation more easily
1037         https://bugs.webkit.org/show_bug.cgi?id=195780
1038
1039         Reviewed by Tim Horton.
1040         
1041         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
1042         cuts off communication of scrolling tree scrolls back to the web process
1043         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
1044         allows tests to trigger scrolls which run the scrolling tree layer positioning
1045         logic, but never get another commit from the web process that might mask
1046         scrolling tree bugs.
1047         
1048         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
1049         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
1050         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
1051
1052         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1053         (WTR::UIScriptController::scrollUpdatesDisabled const):
1054         (WTR::UIScriptController::setScrollUpdatesDisabled):
1055         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1056         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1057         (WTR::UIScriptController::scrollUpdatesDisabled const):
1058         (WTR::UIScriptController::setScrollUpdatesDisabled):
1059         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1060         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1061         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1062         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
1063         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
1064         * WebKitTestRunner/ios/TestControllerIOS.mm:
1065         (WTR::TestController::platformResetStateToConsistentValues):
1066         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1067         (WTR::UIScriptController::scrollUpdatesDisabled const):
1068         (WTR::UIScriptController::setScrollUpdatesDisabled):
1069
1070 2019-03-14  Youenn Fablet  <youenn@apple.com>
1071
1072         Move IDB storage in private browsing mode to NetworkProcess
1073         https://bugs.webkit.org/show_bug.cgi?id=195602
1074
1075         Reviewed by Brady Eidson.
1076
1077         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
1078         (TEST):
1079
1080 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1081
1082         [ews-build] Make descriptionDone messages more readable
1083         https://bugs.webkit.org/show_bug.cgi?id=195760
1084
1085         Reviewed by Lucas Forschler.
1086
1087         * BuildSlaveSupport/ews-build/steps.py:
1088         * BuildSlaveSupport/ews-build/steps_unittest.py:
1089
1090 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1091
1092         [ews-build] Generate status-bubble hover-over messages
1093         https://bugs.webkit.org/show_bug.cgi?id=195680
1094
1095         Reviewed by Lucas Forschler.
1096
1097         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1098         (StatusBubble):
1099         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
1100         on hover-over.
1101         (StatusBubble._iso_time):
1102         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
1103         hover-over message.
1104         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
1105
1106 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1107
1108         [ews-app] Gracefully handle the case when state_string is None
1109         https://bugs.webkit.org/show_bug.cgi?id=195753
1110
1111         Reviewed by Lucas Forschler.
1112
1113         * BuildSlaveSupport/ews-app/ews/models/build.py:
1114         * BuildSlaveSupport/ews-app/ews/models/step.py:
1115
1116 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
1117
1118         [ews-app] Status bubble display pending for currently running build step
1119         https://bugs.webkit.org/show_bug.cgi?id=195744
1120
1121         Reviewed by Lucas Forschler.
1122
1123         * BuildSlaveSupport/ews-build/events.py:
1124         (Events.stepStarted): If state_string is pending, replace it with step name.
1125
1126 2019-03-14  Chris Dumez  <cdumez@apple.com>
1127
1128         Add WebsitePolicy for the client to specify the device orientation & motion access policy
1129         https://bugs.webkit.org/show_bug.cgi?id=195750
1130
1131         Reviewed by Geoffrey Garen.
1132
1133         Add API test coverage.
1134
1135         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1136         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
1137         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1138         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1139
1140 2019-03-14  Chris Dumez  <cdumez@apple.com>
1141
1142         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
1143         https://bugs.webkit.org/show_bug.cgi?id=195747
1144
1145         Reviewed by Geoff Garen.
1146
1147         Add API test coverage.
1148
1149         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1150
1151 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
1152
1153         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
1154         https://bugs.webkit.org/show_bug.cgi?id=195725
1155         <rdar://problem/48545062>
1156
1157         Reviewed by Tim Horton.
1158
1159         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
1160         handler is nil.
1161
1162         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1163         (TestWebKitAPI::TEST):
1164
1165 2019-03-13  Sam Weinig  <sam@webkit.org>
1166
1167         Add utility function to allow easy reverse range-based iteration of a container
1168         https://bugs.webkit.org/show_bug.cgi?id=195542
1169
1170         Reviewed by Antti Koivisto.
1171
1172         * TestWebKitAPI/CMakeLists.txt:
1173         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1174         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
1175         (TestWebKitAPI::TEST):
1176         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
1177
1178 2019-03-13  Chris Dumez  <cdumez@apple.com>
1179
1180         Use a ServiceWorker process per registrable domain
1181         https://bugs.webkit.org/show_bug.cgi?id=195649
1182
1183         Reviewed by Youenn Fablet.
1184
1185         Update API test coverage.
1186
1187         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1188
1189 2019-03-13  Chris Dumez  <cdumez@apple.com>
1190
1191         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
1192         https://bugs.webkit.org/show_bug.cgi?id=195684
1193         <rdar://problem/48294714>
1194
1195         Reviewed by Antti Koivisto.
1196
1197         Add API test coverage.
1198
1199         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1200
1201 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
1202
1203         [ews-app] Remove unused patch view
1204         https://bugs.webkit.org/show_bug.cgi?id=195669
1205
1206         Reviewed by Lucas Forschler.
1207
1208         * BuildSlaveSupport/ews-app/ews/urls.py:
1209         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
1210
1211 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
1212
1213         [ews-app] Use Buildbot result code variables
1214         https://bugs.webkit.org/show_bug.cgi?id=195668
1215
1216         Reviewed by Alexey Proskuryakov.
1217
1218         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1219         (Buildbot): Added Buildbot result code variables.
1220         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1221         (StatusBubble._build_bubble): Used Buildbot result code variables.
1222
1223 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
1224
1225         [Flatpak] Expand submodule recursively
1226         https://bugs.webkit.org/show_bug.cgi?id=195672
1227
1228         Building WPE with flatpak was impossible without that as it was raising an exception.
1229         Also update wpebackend-fdo to match what is built in jhbuild
1230
1231         Reviewed by Philippe Normand.
1232
1233         * flatpak/flatpakutils.py:
1234         (expand_submodules_recurse):
1235         (expand_manifest):
1236         * flatpak/org.webkit.WPEModules.yaml:
1237
1238 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
1239
1240         [ews-app] status bubble should be hidden for certain builds
1241         https://bugs.webkit.org/show_bug.cgi?id=194597
1242
1243         Reviewed by Dewei Zhu.
1244
1245         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1246         (StatusBubble._build_bubble):
1247         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
1248         because the patch didn't have relevant changes.
1249         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
1250         in production yet.
1251
1252 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
1253
1254         [Win] Fix a slew of simple clang-cl warnings.
1255         https://bugs.webkit.org/show_bug.cgi?id=195652
1256
1257         Reviewed by Don Olmstead.
1258
1259         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1260         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
1261
1262 2019-03-12  Justin Fan  <justin_fan@apple.com>
1263
1264         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
1265         https://bugs.webkit.org/show_bug.cgi?id=195518
1266         <rdar://problem/46322356>
1267
1268         Reviewed by Myles C. Maxfield.
1269
1270         * DumpRenderTree/DerivedSources-input.xcfilelist:
1271         * DumpRenderTree/DerivedSources-output.xcfilelist:
1272
1273 2019-03-12  Commit Queue  <commit-queue@webkit.org>
1274
1275         Unreviewed, rolling out r242825.
1276         https://bugs.webkit.org/show_bug.cgi?id=195648
1277
1278         "Broke webkitpy tests with my change to
1279         lldb_dump_class_layout.py" (Requested by rmorisset on
1280         #webkit).
1281
1282         Reverted changeset:
1283
1284         "Alter Tools/Scripts/dump-class-layout to be able to dump all
1285         classes with suspicious padding"
1286         https://bugs.webkit.org/show_bug.cgi?id=195573
1287         https://trac.webkit.org/changeset/242825
1288
1289 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
1290
1291         [ews-build] Show status bubbles while the patch is waiting in queue
1292         https://bugs.webkit.org/show_bug.cgi?id=195618
1293
1294         Reviewed by Lucas Forschler.
1295
1296         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1297         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
1298         enabled in initial deployment.
1299         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
1300         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
1301         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
1302         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
1303         (StatusBubble._build_bubbles_for_patch):
1304
1305 2019-03-12  Robin Morisset  <rmorisset@apple.com>
1306
1307         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
1308         https://bugs.webkit.org/show_bug.cgi?id=195573
1309
1310         Reviewed by Simon Fraser.
1311
1312         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
1313
1314         * Scripts/dump-class-layout:
1315         (main):
1316         * lldb/lldb_dump_class_layout.py:
1317         (ClassLayout.__init__):
1318         (ClassLayout._compute_padding_recursive):
1319         (LLDBDebuggerInstance.dump_layout_for_classname):
1320         (LLDBDebuggerInstance):
1321         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
1322         (LLDBDebuggerInstance.layout_for_classname): Deleted.
1323
1324 2019-03-12  Chris Dumez  <cdumez@apple.com>
1325
1326         Device Orientation access permission should be denied unless explicitly granted by the client
1327         https://bugs.webkit.org/show_bug.cgi?id=195625
1328
1329         Reviewed by Youenn Fablet.
1330
1331         add API test coverage.
1332
1333         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1334         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
1335         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
1336         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
1337         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1338         (runDeviceOrientationTest):
1339         (TEST):
1340         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1341         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1342
1343 2019-03-12  Jer Noble  <jer.noble@apple.com>
1344
1345         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
1346         https://bugs.webkit.org/show_bug.cgi?id=195137
1347         <rdar://problem/48810307>
1348
1349         Reviewed by Eric Carlson.
1350
1351         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
1352         (TestWebKitAPI::TEST):
1353
1354 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
1355
1356         [ews-build] Change urls from uat to production
1357         https://bugs.webkit.org/show_bug.cgi?id=195566
1358
1359         Reviewed by Lucas Forschler.
1360
1361         * BuildSlaveSupport/ews-app/ews/config.py:
1362         * BuildSlaveSupport/ews-build/events.py:
1363         * BuildSlaveSupport/ews-build/steps.py:
1364
1365 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
1366
1367         [ews-build] change max_builds for local-worker to 1
1368         https://bugs.webkit.org/show_bug.cgi?id=195568
1369
1370         Reviewed by Lucas Forschler.
1371
1372         * BuildSlaveSupport/ews-build/loadConfig.py:
1373
1374 2019-03-12  Tim Horton  <timothy_horton@apple.com>
1375
1376         Fix the build
1377
1378         * TestRunnerShared/spi/PencilKitTestSPI.h:
1379         * TestWebKitAPI/ios/PencilKitTestSPI.h:
1380
1381 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
1382
1383         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
1384         https://bugs.webkit.org/show_bug.cgi?id=194131
1385
1386         Reviewed by Michael Catanzaro.
1387
1388         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1389         (uriChanged):
1390         (testUnfinishedSubresourceLoad):
1391         (serverCallback):
1392         (beforeAll):
1393
1394 2019-03-11  Alex Christensen  <achristensen@webkit.org>
1395
1396         WTF::Expected should use std::addressof instead of operator&
1397         https://bugs.webkit.org/show_bug.cgi?id=195604
1398
1399         Reviewed by Myles Maxfield.
1400
1401         * TestWebKitAPI/Tests/WTF/Expected.cpp:
1402         (TestWebKitAPI::Unique::Unique):
1403         (TestWebKitAPI::Unique::operator&):
1404         (TestWebKitAPI::TEST):
1405
1406 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
1407
1408         Add Optional to Forward.h.
1409         https://bugs.webkit.org/show_bug.cgi?id=195586
1410
1411         Reviewed by Darin Adler.
1412
1413         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
1414         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
1415         Remove unnecessary includes from headers.
1416
1417 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
1418
1419         Add testing API to hit-test and scroll overflow scrollers
1420         https://bugs.webkit.org/show_bug.cgi?id=195278
1421
1422         Reviewed by Antti Koivisto.
1423         
1424         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
1425         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
1426         
1427         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
1428
1429         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1430         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
1431         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1432         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1433         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
1434         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1435         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1436         (WTR::enclosingScrollViewIncludingSelf):
1437         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
1438
1439 2019-03-11  Tim Horton  <timothy_horton@apple.com>
1440
1441         API test WebKit.RequestTextInputContext fails on iOS
1442         https://bugs.webkit.org/show_bug.cgi?id=195585
1443
1444         Reviewed by Wenson Hsieh and Simon Fraser.
1445
1446         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
1447         (applyStyle):
1448         (TEST):
1449         Add a viewport, so that the coordinates match up on iOS.
1450         Scroll by moving the UIScrollView's contentOffset.
1451
1452 2019-03-11  Chris Dumez  <cdumez@apple.com>
1453
1454         Assert in WebPageProxy::suspendCurrentPageIfPossible()
1455         https://bugs.webkit.org/show_bug.cgi?id=195506
1456         <rdar://problem/48733477>
1457
1458         Reviewed by Alex Christensen.
1459
1460         Add API test coverage.
1461
1462         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1463
1464 2019-03-11  Shawn Roberts  <sroberts@apple.com>
1465
1466         Adding myself to contributors.json
1467
1468         Unreviewed, addming myself to contributors.json .
1469
1470         * Scripts/webkitpy/common/config/contributors.json:
1471
1472 2019-03-11  Alex Christensen  <achristensen@webkit.org>
1473
1474         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
1475         https://bugs.webkit.org/show_bug.cgi?id=195511
1476         <rdar://problem/44873269>
1477
1478         Reviewed by Darin Adler.
1479
1480         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
1481         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
1482         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
1483         (TEST_F):
1484
1485 2019-03-11  Chris Dumez  <cdumez@apple.com>
1486
1487         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
1488         https://bugs.webkit.org/show_bug.cgi?id=195561
1489
1490         Reviewed by Youenn Fablet.
1491
1492         Make sure the JS in the test requests for permission to receive device orientation events.
1493
1494         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1495
1496 2019-03-11  Youenn Fablet  <youenn@apple.com>
1497
1498         Allow storage quota increase by default in WTR
1499         https://bugs.webkit.org/show_bug.cgi?id=195541
1500
1501         Reviewed by Geoffrey Garen.
1502
1503         Allow storage quota increase by default in WTR.
1504         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
1505         Use this for tests that explicitly need cache increase.
1506
1507         Instead of increasing quota by 2, make sure the next request is
1508         granted by adding all given parameters.
1509
1510         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1511         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1512         (WTR::TestRunner::setAllowStorageQuotaIncrease):
1513         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
1514         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1515         * WebKitTestRunner/TestController.cpp:
1516         (WTR::TestController::setAllowStorageQuotaIncrease):
1517         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
1518         * WebKitTestRunner/TestController.h:
1519         * WebKitTestRunner/TestInvocation.cpp:
1520         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1521         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1522         (WTR::TestController::cocoaResetStateToConsistentValues):
1523         (WTR::TestController::setAllowStorageQuotaIncrease):
1524         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
1525         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
1526         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
1527
1528 2019-03-11  Xan Lopez  <xan@igalia.com>
1529
1530         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
1531         https://bugs.webkit.org/show_bug.cgi?id=194147
1532
1533         Reviewed by Michael Saboff.
1534
1535         To make --32-bit work correctly on Linux/64bit we need to:
1536
1537         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
1538         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
1539         unfortunately CMake only allows us to do this during
1540         crosscompilation, which is overkill here.
1541         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
1542         pkg-config detection module uses the x86 .pc files instead of the
1543         x86_64 ones.
1544         - Set the -m32 flags for the compiler.
1545
1546         * Scripts/webkitdirs.pm:
1547         (generateBuildSystemFromCMakeProject):
1548
1549 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
1550
1551         Add MotionMark-1.1 plan file for run-benchmark script.
1552         https://bugs.webkit.org/show_bug.cgi?id=195481
1553
1554         Rubber-stamped by Darin Adler.
1555
1556         Run-benchmark script should support MontionMark-1.1.
1557
1558         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
1559
1560 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
1561
1562         [ews-app] Add support for submit-to-ews url
1563         https://bugs.webkit.org/show_bug.cgi?id=195477
1564
1565         Reviewed by Lucas Forschler.
1566
1567         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1568         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1569         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
1570         * BuildSlaveSupport/ews-app/ews/urls.py:
1571         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
1572
1573 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
1574
1575         Unreviewed, rolling out r242688, r242643, r242624.
1576
1577         Caused multiple layout test failures and crashes on iOS and macOS.
1578
1579         Reverted changeset:
1580
1581         "requestAnimationFrame should execute before the next frame"
1582         https://bugs.webkit.org/show_bug.cgi?id=177484
1583         https://trac.webkit.org/changeset/242624/webkit
1584
1585         * Tracing/SystemTracePoints.plist:
1586
1587 2019-03-11  John Wilander  <wilander@apple.com>
1588
1589         Resource Load Statistics: Make it possible exclude localhost from classification
1590         https://bugs.webkit.org/show_bug.cgi?id=195474
1591         <rdar://problem/47520577>
1592
1593         Reviewed by Brent Fulgham.
1594
1595         This patch allows for localhost to be excluded from classification and
1596         treatment as a prevalent resource.
1597
1598         The WebKit Tools change adds a new function called
1599         testRunner.setStatisticsIsRunningTest() which can be used to control this
1600         behavior.
1601
1602         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1603         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1604         (WTR::TestRunner::setStatisticsIsRunningTest):
1605         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1606         * WebKitTestRunner/TestController.cpp:
1607         (WTR::TestController::setStatisticsIsRunningTest):
1608         * WebKitTestRunner/TestController.h:
1609         * WebKitTestRunner/TestInvocation.cpp:
1610         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1611
1612 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
1613
1614         [ews-build] Disable waterfall and console view for ews-build.webkit.org
1615         https://bugs.webkit.org/show_bug.cgi?id=195560
1616
1617         Reviewed by Lucas Forschler.
1618
1619         * BuildSlaveSupport/ews-build/master.cfg:
1620
1621 2019-03-11  Alex Christensen  <achristensen@webkit.org>
1622
1623         Unreviewed, rolling out r242698.
1624
1625         API test crashes on bots.
1626
1627         Reverted changeset:
1628
1629         "Add a WKContentRuleList variant that uses copied memory
1630         instead of mmap'd shared memory for class A containerized
1631         apps"
1632         https://bugs.webkit.org/show_bug.cgi?id=195511
1633         https://trac.webkit.org/changeset/242698
1634
1635 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
1636
1637         [WPE] Enable web process sandbox
1638         https://bugs.webkit.org/show_bug.cgi?id=195169
1639
1640         Reviewed by Daniel Bates.
1641
1642         * wpe/install-dependencies:
1643         * wpe/jhbuild.modules:
1644
1645 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
1646
1647         [ews-app] Use port 17000 for worker communication
1648         https://bugs.webkit.org/show_bug.cgi?id=195558
1649
1650         Reviewed by Lucas Forschler.
1651
1652         * BuildSlaveSupport/ews-build/master.cfg:
1653
1654 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
1655
1656         [ews-build] unit-tests fail when passwords.json is missing
1657         https://bugs.webkit.org/show_bug.cgi?id=195557
1658
1659         Reviewed by Lucas Forschler.
1660
1661         * BuildSlaveSupport/ews-build/loadConfig.py:
1662         (loadBuilderConfig):
1663         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1664         (ConfigDotJSONTest.test_configuration):
1665         * BuildSlaveSupport/ews-build/master.cfg:
1666
1667 2019-03-11  Truitt Savell  <tsavell@apple.com>
1668
1669         Unreviewed, rolling out r242702.
1670
1671         Broke High Sierra builders.
1672
1673         Reverted changeset:
1674
1675         "Add utility function to allow easy reverse range-based
1676         iteration of a container"
1677         https://bugs.webkit.org/show_bug.cgi?id=195542
1678         https://trac.webkit.org/changeset/242702
1679
1680 2019-03-11  Sam Weinig  <sam@webkit.org>
1681
1682         Add utility function to allow easy reverse range-based iteration of a container
1683         https://bugs.webkit.org/show_bug.cgi?id=195542
1684
1685         Reviewed by Antti Koivisto.
1686
1687         * TestWebKitAPI/CMakeLists.txt:
1688         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1689         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
1690         (TestWebKitAPI::TEST):
1691         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
1692
1693 2019-03-10  Alex Christensen  <achristensen@webkit.org>
1694
1695         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
1696         https://bugs.webkit.org/show_bug.cgi?id=195511
1697         <rdar://problem/44873269>
1698
1699         Reviewed by Darin Adler.
1700
1701         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
1702         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
1703         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
1704         (TEST_F):
1705
1706 2019-03-10  Tim Horton  <timothy_horton@apple.com>
1707
1708         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
1709         https://bugs.webkit.org/show_bug.cgi?id=195499
1710
1711         Reviewed by Darin Adler.
1712
1713         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1714         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
1715         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
1716         (-[WKWebView synchronouslyFocusTextInputContext:]):
1717         (applyStyle):
1718         (applyIframe):
1719         (TEST):
1720         Add some tests for this SPI.
1721
1722 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
1723
1724         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
1725         https://bugs.webkit.org/show_bug.cgi?id=181151
1726
1727         Reviewed by Don Olmstead.
1728
1729         * TestWebKitAPI/CMakeLists.txt:
1730         * TestWebKitAPI/PlatformWin.cmake:
1731         Enable TestWTF RunLoop tests in all platforms.
1732
1733         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
1734         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
1735         (TestWebKitAPI::DerivedOneShotTimer::fired):
1736         (TestWebKitAPI::TEST):
1737         Only a few platforms support nested RunLoop.
1738
1739         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
1740         (TestWebKitAPI::DerivedRepeatingTimer::fired):
1741
1742 2019-03-10  David Quesada  <david_quesada@apple.com>
1743
1744         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
1745         https://bugs.webkit.org/show_bug.cgi?id=152480
1746
1747         Reviewed by Chris Dumez.
1748
1749         Add a unit test based on Daniel Bates's test case that starts a download, ensures
1750         there are no additional references to the process pool besides the one held by
1751         the download, waits for the download to finish (in the sense that the
1752         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
1753         measure, also check that the process pool has been deallocated at the end of the
1754         test. The test wouldn't be meaningful if the process pool were still alive.
1755
1756         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1757         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
1758         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
1759             The download will be canceled because the delegate does not implement the
1760             method to decide the download's destination, so this is where we know the
1761             DownloadProxyMap is done with the DownloadProxy.
1762         (TEST):
1763
1764 2019-03-08  Chris Dumez  <cdumez@apple.com>
1765
1766         Add support for Device Orientation / Motion permission API
1767         https://bugs.webkit.org/show_bug.cgi?id=195329
1768         <rdar://problem/47645367>
1769
1770         Reviewed by Geoffrey Garen.
1771
1772         Add test infrastructure to help test the Device Orientation / Motion permission API.
1773
1774         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1775         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1776         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
1777         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1778         * WebKitTestRunner/TestController.cpp:
1779         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
1780         (WTR::TestController::createWebViewWithOptions):
1781         (WTR::TestController::resetStateToConsistentValues):
1782         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
1783         * WebKitTestRunner/TestController.h:
1784         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
1785         * WebKitTestRunner/TestInvocation.cpp:
1786         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1787
1788 2019-03-08  Saam barati  <sbarati@apple.com>
1789
1790         Add a compare-results script to compare benchmark results
1791         https://bugs.webkit.org/show_bug.cgi?id=195486
1792         <rdar://problem/48723397>
1793
1794         Reviewed by Geoffrey Garen.
1795
1796         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
1797         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
1798         to extend it to learn about our other benchmarks.
1799
1800         * Scripts/compare-results: Added.
1801         (readJSONFile):
1802         (detectJetStream2):
1803         (JetStream2Results):
1804         (detectSpeedometer2):
1805         (Speedometer2Results):
1806         (detectPLT5):
1807         (PLT5Results):
1808         (detectBenchmark):
1809         (biggerIsBetter):
1810         (ttest):
1811         (getOptions):
1812         (main):
1813
1814 2019-03-08  Stephanie Lewis  <slewis@apple.com>
1815
1816         Ensure old tab state is cleared between iterations of run-benchmark
1817         https://bugs.webkit.org/show_bug.cgi?id=195393
1818         <rdar://problem/46885583>
1819
1820         Reviewed by Dewei Zhu.
1821
1822         a) ensure the default to restore state is not set
1823         b) terminate Safari correctly
1824         c) Set the system default to ignore Persistent State in Safari
1825
1826         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1827         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
1828         (OSXBrowserDriver.prepare_env): 
1829         (OSXBrowserDriver.restore_env):
1830         (OSXBrowserDriver.close_browsers):
1831         (OSXBrowserDriver._terminate_processes):
1832         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
1833         (OSXChromeDriver):
1834         (OSXChromeCanaryDriver):
1835         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
1836         (OSXFirefoxDriver):
1837         (OSXFirefoxNightlyDriver):
1838         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
1839         (OSXSafariDriver):
1840         (OSXSafariDriver.prepare_env):
1841
1842 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
1843
1844         [GTK] Several InputMethodFilter tests are failing
1845         https://bugs.webkit.org/show_bug.cgi?id=195408
1846
1847         Reviewed by Carlos Garcia Campos.
1848
1849         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
1850         Regressed in r241751.
1851         Hexadecimal values of keycodes are expressed now in upper letters.
1852         Composited characters should be cast to UTF8 strings.
1853
1854         (TestWebKitAPI::TEST):
1855
1856 2019-03-07  Tomas Popela  <tpopela@redhat.com>
1857
1858         [GTK] Make Tools/gtkdoc python3 compatible
1859         https://bugs.webkit.org/show_bug.cgi?id=195359
1860
1861         Reviewed by Carlos Garcia Campos.
1862
1863         * gtkdoc/generate-gtkdoc:
1864         ConfigParser was reworked in Python 3.2 so we have adapt the code to
1865         work with Python 2 and 3.
1866         (get_gtkdoc_module_paths):
1867         The iteritems() was removed in Python 3, so let's use items() that's
1868         available in Python 2 and 3.
1869         (get_generator_for_config):
1870         * gtkdoc/gtkdoc.py:
1871         (GTKDoc._run_command):
1872         The sys.stdout.write() is expecting str in Python 3 and not bytes
1873         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
1874         for passing the bytes there.
1875
1876 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
1877
1878         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
1879         https://bugs.webkit.org/show_bug.cgi?id=195346
1880         <rdar://problem/48667048>
1881
1882         Unreviewed build fix for clang-cl.
1883
1884         * DumpRenderTree/win/DumpRenderTree.cpp:
1885         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
1886
1887 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
1888
1889         requestAnimationFrame should execute before the next frame
1890         https://bugs.webkit.org/show_bug.cgi?id=177484
1891
1892         Reviewed by Simon Fraser.
1893
1894         Add trace points for the page RenderingUpdate.
1895
1896         * Tracing/SystemTracePoints.plist:
1897
1898 2019-03-07  Zalan Bujtas  <zalan@apple.com>
1899
1900         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
1901         https://bugs.webkit.org/show_bug.cgi?id=195353
1902         <rdar://problem/48626394>
1903
1904         Reviewed by Simon Fraser.
1905
1906         * WebKitTestRunner/ios/TestControllerIOS.mm:
1907         (WTR::TestController::platformResetPreferencesToConsistentValues):
1908
1909 2019-03-07  John Wilander  <wilander@apple.com>
1910
1911         Resource Load Statistics: Make it possible to purge only script-accessible cookies
1912         https://bugs.webkit.org/show_bug.cgi?id=195383
1913         <rdar://problem/48570136>
1914
1915         Reviewed by Brent Fulgham.
1916
1917         This patch adds test infrastructure to purge only script-accessible cookies,
1918         including a new testRunner function called statisticsDeleteCookiesForHost().git a
1919
1920         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1921         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1922         (WTR::TestRunner::statisticsDeleteCookiesForHost):
1923         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1924         * WebKitTestRunner/TestController.cpp:
1925         (WTR::TestController::statisticsDeleteCookiesForHost):
1926         * WebKitTestRunner/TestController.h:
1927         * WebKitTestRunner/TestInvocation.cpp:
1928         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1929
1930 2019-03-07  Commit Queue  <commit-queue@webkit.org>
1931
1932         Unreviewed, rolling out r242354.
1933         https://bugs.webkit.org/show_bug.cgi?id=195402
1934
1935         breaks layout tests in all configurations (Requested by
1936         zdobersek on #webkit).
1937
1938         Reverted changeset:
1939
1940         "[WPE] Enable web process sandbox"
1941         https://bugs.webkit.org/show_bug.cgi?id=195169
1942         https://trac.webkit.org/changeset/242354
1943
1944 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
1945
1946         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
1947         https://bugs.webkit.org/show_bug.cgi?id=195346
1948
1949         Reviewed by Fujii Hironori.
1950
1951         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
1952         (TestWebKitAPI::TEST):
1953         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
1954
1955         * DumpRenderTree/win/DumpRenderTree.cpp:
1956         (findFontFallback):
1957         (addFontFallbackIfPresent):
1958         (removeFontFallbackIfPresent):
1959         (main):
1960         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1961         (TestWebKitAPI::Util::moduleDirectory):
1962         (TestWebKitAPI::Util::createInjectedBundlePath):
1963         Use wchar helpers as needed.
1964
1965 2019-03-06  Rob Buis  <rbuis@igalia.com>
1966
1967         Consider supporting the `referrerpolicy` attribute.
1968         https://bugs.webkit.org/show_bug.cgi?id=179053
1969
1970         Reviewed by Darin Adler.
1971
1972         Add a runtime flag for referrerpolicy attribute.
1973
1974         * DumpRenderTree/mac/DumpRenderTree.mm:
1975         (enableExperimentalFeatures):
1976
1977 2019-03-05  Daniel Bates  <dabates@apple.com>
1978
1979         Update expected API test result following r242379
1980         (https://bugs.webkit.org/show_bug.cgi?id=195125)
1981
1982         Update expected x-coordinate of selection rect now that the left padding of
1983         a textarea is sized in ems (so dependent on the font size) just like the left
1984         padding of a text field.
1985
1986         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1987         (TestWebKitAPI::TEST):
1988
1989 2019-03-05  David Quesada  <david_quesada@apple.com>
1990
1991         [WK2] It should be possible to follow links with 'download' attributes
1992         https://bugs.webkit.org/show_bug.cgi?id=195145
1993         rdar://problem/48462642
1994
1995         Reviewed by Alex Christensen.
1996
1997         Add a unit test to verify that activating links with 'download' attributes now
1998         navigates to the linked resource, rather than starts downloading it. Add another
1999         to verify that it is still possible to explicitly download the link via the
2000         'Download' navigation action policy.
2001
2002         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2003         (-[DownloadAttributeTestDelegate init]):
2004         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
2005         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
2006         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
2007         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
2008         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2009         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
2010         (TEST):
2011         * WebKitTestRunner/TestController.cpp:
2012         (WTR::TestController::decidePolicyForNavigationAction):
2013         * WebKitTestRunner/TestController.h:
2014
2015 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
2016
2017         [Curl] Implement Cookie Accept Policy.
2018         https://bugs.webkit.org/show_bug.cgi?id=191645
2019
2020         Reviewed by Fujii Hironori.
2021
2022         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2023         (TestWebKitAPI::Curl::TEST_F):
2024
2025 2019-03-05  Youenn Fablet  <youenn@apple.com>
2026
2027         Rename requestCacheStorageSpace to requestStorageSpace
2028         https://bugs.webkit.org/show_bug.cgi?id=195282
2029
2030         Reviewed by Chris Dumez.
2031
2032         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2033         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2034         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
2035
2036 2019-03-05  Brady Eidson  <beidson@apple.com>
2037
2038         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
2039         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
2040
2041         Reviewed by Tim Horton.
2042
2043         Loading a file: URL into a WKWebView and then loading another file: url from a completely
2044         different directory into that same WKWebView should work.
2045
2046         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2047         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
2048
2049 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
2050
2051         Add WeakHashSet
2052         https://bugs.webkit.org/show_bug.cgi?id=195152
2053
2054         Reviewed by Antti Koivisto.
2055
2056         Added tests for WeakHashSet.
2057
2058         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2059         (TestWebKitAPI::Base::Base): Moved.
2060         (TestWebKitAPI::Derived::foo): Moved.
2061         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
2062         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
2063         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
2064         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
2065
2066 2019-03-04  Chris Dumez  <cdumez@apple.com>
2067
2068         Do not share WebProcesses between private and regular sessions
2069         https://bugs.webkit.org/show_bug.cgi?id=195189
2070         <rdar://problem/48421064>
2071
2072         Reviewed by Alex Christensen.
2073
2074         Add API test coverage.
2075
2076         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2077         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2078
2079 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
2080
2081         [WPE] Enable web process sandbox
2082         https://bugs.webkit.org/show_bug.cgi?id=195169
2083
2084         Reviewed by Daniel Bates.
2085
2086         * wpe/install-dependencies:
2087         * wpe/jhbuild.modules:
2088
2089 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2090
2091         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
2092         https://bugs.webkit.org/show_bug.cgi?id=195206
2093
2094         Reviewed by Žan Doberšek.
2095
2096         Add a new test case.
2097
2098         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2099         (testJSCClass):
2100
2101 2019-03-04  Charlie Turner  <cturner@igalia.com>
2102
2103         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
2104         https://bugs.webkit.org/show_bug.cgi?id=194898
2105
2106         Reviewed by Žan Doberšek.
2107
2108         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
2109         a GCC extension that permits arithmetic on void* pointer. Inline
2110         the macro until this issue is fixed upstream.
2111
2112 2019-03-03  Tim Horton  <timothy_horton@apple.com>
2113
2114         Rid the world of WK_API_ENABLED
2115         https://bugs.webkit.org/show_bug.cgi?id=195263
2116
2117         Reviewed by Dan Bernstein.
2118
2119         List of changed files elided because it's useless.
2120
2121 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
2122
2123         Unreviewed follow-up to r242292.
2124
2125         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
2126
2127         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2128         (TestWebKitAPI::testStrip): Renamed from strip.
2129         (TestWebKitAPI::TEST):
2130
2131 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2132
2133         Unreviewed, remove accidentally-committed URLHelpers.cpp test
2134
2135         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
2136         and bug #194272 for details.
2137
2138         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
2139
2140 2019-03-03  Tim Horton  <timothy_horton@apple.com>
2141
2142         Remove some more unused 32-bit code
2143         https://bugs.webkit.org/show_bug.cgi?id=195255
2144
2145         Reviewed by Darin Adler.
2146
2147         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2148         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
2149         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2150         (NPP_New):
2151         (NPP_HandleEvent):
2152         (handleEventCarbon): Deleted.
2153
2154 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
2155
2156         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
2157
2158         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2159         (TestWebKitAPI::TEST):
2160
2161 2019-03-01  Darin Adler  <darin@apple.com>
2162
2163         Finish removing String::format
2164         https://bugs.webkit.org/show_bug.cgi?id=194893
2165
2166         Reviewed by Daniel Bates.
2167 '
2168         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
2169
2170 2019-03-01  Alex Christensen  <achristensen@webkit.org>
2171
2172         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
2173         https://bugs.webkit.org/show_bug.cgi?id=195229
2174         <rdar://problem/48520362>
2175
2176         Reviewed by Chris Dumez.
2177
2178         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2179         (TEST):
2180
2181 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
2182
2183         Add a system trace scope for event region building
2184         https://bugs.webkit.org/show_bug.cgi?id=195226
2185
2186         Reviewed by Jon Lee.
2187
2188         This trace scope measures the time spend converting element rects into Region objects,
2189         which can be large on some pages.
2190
2191         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
2192
2193         * Tracing/SystemTracePoints.plist:
2194
2195 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
2196
2197         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
2198         https://bugs.webkit.org/show_bug.cgi?id=194612
2199
2200         Reviewed by Alex Christensen.
2201
2202         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2203         Just test the new string-processing function and don't touch the actual environment.
2204         (Test cases are all as before, but based on operator== instead of strcmp.)
2205
2206 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
2207
2208         [ews-app] Update primary keys for handling multiple Buildbot instances
2209         https://bugs.webkit.org/show_bug.cgi?id=195120
2210
2211         Reviewed by Stephanie Lewis.
2212
2213         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
2214         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
2215         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
2216
2217         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
2218         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
2219         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
2220         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
2221         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
2222         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
2223
2224 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
2225
2226         [WinCairo] Enable service worker
2227         https://bugs.webkit.org/show_bug.cgi?id=188318
2228
2229         Reviewed by Youenn Fablet.
2230
2231         * DumpRenderTree/DumpRenderTreePrefix.h:
2232         * TestWebKitAPI/PlatformWin.cmake:
2233         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
2234         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
2235         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
2236
2237 2019-03-01  Justin Fan  <justin_fan@apple.com>
2238
2239         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
2240         https://bugs.webkit.org/show_bug.cgi?id=195191
2241
2242         Rubber-stamped by Dean Jackson.
2243
2244         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
2245
2246         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2247
2248 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
2249
2250         Unreviewed, fix lldb webkitpy tests
2251         https://bugs.webkit.org/show_bug.cgi?id=194375
2252
2253         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
2254
2255         * lldb/lldb_webkit.py:
2256         (WTFStringImplProvider.is_8bit):
2257
2258 2019-02-28  David Quesada  <david_quesada@apple.com>
2259
2260         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
2261         https://bugs.webkit.org/show_bug.cgi?id=195121
2262         rdar://problem/48450302
2263
2264         Reviewed by Alex Christensen.
2265
2266         Add API tests for -WKNavigationAction._shouldPerformDownload in various
2267         configurations where the 'download' attribute is absent, blank, or populated
2268         with a filename, and where the anchor element is same-origin or cross-origin
2269         (meaning the 'download' attribute shouldn't be honored).
2270
2271         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2272         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
2273         (-[NavigationActionTestDelegate init]):
2274         (-[NavigationActionTestDelegate navigationAction]):
2275         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
2276         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
2277         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2278         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
2279         (TEST):
2280
2281 2019-02-28  Antoine Quint  <graouts@apple.com>
2282
2283         Enable the Pointer Events runtime flag by default
2284         https://bugs.webkit.org/show_bug.cgi?id=195156
2285
2286         Reviewed by Dean Jackson.
2287
2288         * DumpRenderTree/mac/DumpRenderTree.mm:
2289         (enableExperimentalFeatures):
2290
2291 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
2292
2293         Several PasteImage API tests are flaky
2294         https://bugs.webkit.org/show_bug.cgi?id=195160
2295
2296         Reviewed by Tim Horton.
2297
2298         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
2299         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
2300         listening for a "load" event after image load is already complete.
2301
2302         To address this, make these tests first register a "load" event handler, then run script to insert an image
2303         element into the document, and finally wait until the load event is observed before checking image size.
2304
2305         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
2306
2307 2019-02-28  Chris Dumez  <cdumez@apple.com>
2308
2309         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
2310         https://bugs.webkit.org/show_bug.cgi?id=195107
2311
2312         Reviewed by Alex Christensen.
2313
2314         Give some time for the zoom level to get restored.
2315
2316         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2317
2318 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
2319
2320         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
2321         https://bugs.webkit.org/show_bug.cgi?id=194958
2322
2323         Reviewed by Geoffrey Garen.
2324
2325         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
2326         (TEST):
2327
2328 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
2329
2330         [ews-app] Update method to save build to handle builder_display_name
2331         https://bugs.webkit.org/show_bug.cgi?id=195047
2332
2333         Reviewed by Dewei Zhu.
2334
2335         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
2336         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
2337
2338 2019-02-28  Justin Fan  <justin_fan@apple.com>
2339
2340         [Web GPU] Enable Web GPU only on 64-bit
2341         https://bugs.webkit.org/show_bug.cgi?id=195139
2342
2343         Because Metal is only supported on 64 bit apps.
2344
2345         Unreviewed build fix.
2346
2347         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2348
2349 2019-02-27  Youenn Fablet  <youenn@apple.com>
2350
2351         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
2352         https://bugs.webkit.org/show_bug.cgi?id=194959
2353
2354         Reviewed by Chris Dumez.
2355
2356         Spin loop until getting the condition to remove flakiness.
2357
2358         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2359
2360 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
2361
2362         [ews-build] Buildbot should include builder_display_name in the build events
2363         https://bugs.webkit.org/show_bug.cgi?id=195045
2364
2365         Reviewed by Dewei Zhu.
2366
2367         * BuildSlaveSupport/ews-build/events.py:
2368         (Events.buildStarted): Included builder_display_name in event data. Also renamed
2369         buildername to builder_name to be consistent in naming style.
2370         (Events.buildFinished): Ditto.
2371
2372 2019-02-27  Chris Dumez  <cdumez@apple.com>
2373
2374         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
2375         https://bugs.webkit.org/show_bug.cgi?id=194480
2376
2377         Reviewed by Brady Eidson.
2378
2379         Update existing API test to make it more likely to reproduce the issue.
2380
2381         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2382
2383 2019-02-27  Brady Eidson  <beidson@apple.com>
2384
2385         Universal links from Google search results pages don't open the app.
2386         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
2387
2388         Reviewed by Geoffrey Garen.
2389
2390         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
2391         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
2392         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2393         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2394
2395 2019-02-27  Chris Dumez  <cdumez@apple.com>
2396
2397         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
2398         https://bugs.webkit.org/show_bug.cgi?id=195102
2399
2400         Reviewed by Geoffrey Garen.
2401
2402         If the number of processes is not yet what we expect, wait a bit and check again to give
2403         processes some time to exit.
2404
2405         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2406
2407 2019-02-27  Chris Dumez  <cdumez@apple.com>
2408
2409         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
2410         https://bugs.webkit.org/show_bug.cgi?id=194545
2411
2412         Reviewed by Brady Eidson.
2413
2414         Make sure the test navigates forward and then back only once. Previously, navigating
2415         back would trigger a navigation again in a timer.
2416
2417         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2418
2419 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
2420
2421         High Sierra Debug JSC test queue should use faster hardware
2422         https://bugs.webkit.org/show_bug.cgi?id=194603
2423
2424         Rubber-stamped by Alexey Proskuryakov.
2425
2426         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
2427
2428         * BuildSlaveSupport/build.webkit.org-config/config.json:
2429         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2430         (BubbleQueueServer):
2431         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2432         (WebKitBuildbot):
2433         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2434         * QueueStatusServer/config/queues.py:
2435         * Scripts/webkitpy/common/config/ews.json:
2436         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2437         (test_ews_name):
2438
2439 2019-02-27  John Wilander  <wilander@apple.com>
2440
2441         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
2442         https://bugs.webkit.org/show_bug.cgi?id=195071
2443         <rdar://problem/48417690>
2444
2445         Reviewed by Alex Christensen and Brent Fulgham.
2446
2447         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2448         (TestWebKitAPI::createURL):
2449             Convenience function.
2450         (TestWebKitAPI::TEST):
2451             WebCore::AdClickAttribution now takes a URL when creating Source and
2452             Destination.
2453         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
2454         (TestWebKitAPI::TEST):
2455             WebCore::AdClickAttribution now takes a URL when creating Source and
2456             Destination.
2457
2458 2019-02-27  Antoine Quint  <graouts@apple.com>
2459
2460         Support Pointer Events on macOS
2461         https://bugs.webkit.org/show_bug.cgi?id=195008
2462         <rdar://problem/47454419>
2463
2464         Reviewed by Dean Jackson.
2465
2466         * DumpRenderTree/mac/DumpRenderTree.mm:
2467         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
2468         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2469
2470 2019-02-26  Mark Lam  <mark.lam@apple.com>
2471
2472         Remove remaining poisoning code.
2473         https://bugs.webkit.org/show_bug.cgi?id=194138
2474
2475         Reviewed by Saam Barati.
2476
2477         * TestWebKitAPI/CMakeLists.txt:
2478         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2479         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
2480         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
2481         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
2482         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
2483         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
2484         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
2485
2486 2019-02-26  Alex Christensen  <achristensen@webkit.org>
2487
2488         Move ephemeral local storage from WebProcess to UIProcess
2489         https://bugs.webkit.org/show_bug.cgi?id=195074
2490         <rdar://problem/47937975>
2491
2492         Reviewed by Geoff Garen.
2493
2494         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2495
2496 2019-02-20  Jer Noble  <jer.noble@apple.com>
2497
2498         [Cocoa] Media elements will restart network buffering just before suspending
2499         https://bugs.webkit.org/show_bug.cgi?id=193691
2500
2501         Reviewed by Eric Carlson.
2502
2503         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2504         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
2505         (TEST):
2506
2507 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
2508
2509         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
2510         https://bugs.webkit.org/show_bug.cgi?id=191652
2511
2512         Reviewed by Alex Christensen.
2513
2514         Fix WinCairo MiniBrowser behavior of authentication dialog.
2515
2516         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2517         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
2518
2519 2019-02-26  Youenn Fablet  <youenn@apple.com>
2520
2521         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
2522         https://bugs.webkit.org/show_bug.cgi?id=195028
2523         <rdar://problem/48243733>
2524
2525         Reviewed by Eric Carlson.
2526
2527         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2528
2529 2019-02-26  Philippe Normand  <pnormand@igalia.com>
2530
2531         [WPE] Add API for webview background color configuration
2532         https://bugs.webkit.org/show_bug.cgi?id=192305
2533
2534         Reviewed by Michael Catanzaro.
2535
2536         * MiniBrowser/wpe/main.cpp:
2537         (main): Add a new option to configure the webview background
2538         color. Example: --bg-color=transparent.
2539         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2540         (testWebViewBackgroundColor): Enable background color API tests for WPE.
2541         (beforeAll): Ditto.
2542
2543 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
2544
2545         scalableNativeWebpageParameters() is not preserved on new page navigation.
2546         https://bugs.webkit.org/show_bug.cgi?id=194892
2547         <rdar://problem/47538280>
2548
2549         Reviewed by Wenson Hsieh.
2550         
2551         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
2552
2553         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2554         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
2555         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2556         (WTR::UIScriptController::allowsViewportShrinkToFit):
2557         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2558         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2559         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
2560         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2561         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2562         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
2563
2564 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
2565
2566         [ews-app] Add model for handling multiple Buildbot instances
2567         https://bugs.webkit.org/show_bug.cgi?id=194863
2568
2569         Reviewed by Stephanie Lewis.
2570
2571         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
2572
2573 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
2574
2575         [ews-app] Remove BuilderMapping table
2576         https://bugs.webkit.org/show_bug.cgi?id=194961
2577
2578         Reviewed by Stephanie Lewis.
2579
2580         Store builder name directly in build table, instead of having a separate
2581         table for it.
2582
2583         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
2584         * BuildSlaveSupport/ews-app/ews/models/build.py:
2585         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
2586         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2587
2588 2019-02-25  John Wilander  <wilander@apple.com>
2589
2590         Introduce and adopt new class RegistrableDomain for eTLD+1
2591         https://bugs.webkit.org/show_bug.cgi?id=194791
2592         <rdar://problem/48179240>
2593
2594         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
2595
2596         This patch adds an API test and replaces two instances of
2597         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
2598
2599         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2600         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2601         (TestWebKitAPI::TEST):
2602             Changed two strings to make sure the registrable domains are still considered
2603             invalid and pass the test.
2604         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
2605         (TestWebKitAPI::TEST):
2606         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2607         (WTR::InjectedBundle::didReceiveMessageToPage):
2608
2609 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
2610
2611         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
2612         https://bugs.webkit.org/show_bug.cgi?id=195001
2613
2614         Reviewed by Carlos Garcia Campos.
2615
2616         API version 1.0 always includes the functionality previously guarded with
2617         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
2618         unconditionally.
2619
2620         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2621         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
2622         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
2623         (WebViewTest::showInWindow): Ditto.
2624         (WebViewTest::hideView): Ditto.
2625         * wpe/backends/HeadlessViewBackend.cpp:
2626         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
2627         * wpe/backends/ViewBackend.cpp:
2628         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
2629         * wpe/backends/WindowViewBackend.cpp:
2630         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
2631         WPE_BACKEND_CHECK_VERSION().
2632         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
2633
2634 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
2635
2636         [Flatpak] Add support for flatpak > 1.1.2
2637         https://bugs.webkit.org/show_bug.cgi?id=194088
2638
2639         Flatpak 1.2 is now out so we need to support that
2640         version now.
2641
2642         Reviewed by Michael Catanzaro.
2643
2644         * flatpak/flatpakutils.py:
2645         (check_flatpak):
2646         (FlatpakPackages.__init__):
2647         (FlatpakPackages.__detect_packages):
2648         (FlatpakPackages.__detect_packages.in):
2649         (FlatpakRepos.update):
2650
2651 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
2652
2653         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
2654         https://bugs.webkit.org/show_bug.cgi?id=194998
2655
2656         Reviewed by Carlos Garcia Campos.
2657
2658         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
2659         to a Git checkout and using the latest commit containing various fixes
2660         and improvements.
2661
2662 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2663
2664         [WPE][GTK] Remove user agent quirk for washingtonpost.com
2665         https://bugs.webkit.org/show_bug.cgi?id=194981
2666
2667         Reviewed by Žan Doberšek.
2668
2669         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2670         (TestWebKitAPI::TEST):
2671
2672 2019-02-23  Keith Miller  <keith_miller@apple.com>
2673
2674         Add new mac target numbers
2675         https://bugs.webkit.org/show_bug.cgi?id=194955
2676
2677         Reviewed by Tim Horton.
2678
2679         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2680         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2681         * MiniBrowser/Configurations/Base.xcconfig:
2682         * TestWebKitAPI/Configurations/Base.xcconfig:
2683         * WebKitTestRunner/Configurations/Base.xcconfig:
2684
2685 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
2686
2687         [WinCairo] Enable wk1/wk2 suffix for platform search path.
2688         https://bugs.webkit.org/show_bug.cgi?id=194846
2689
2690         Reviewed by Don Olmstead.
2691
2692         Added _search_paths() and _port_specific_expectations_files() for
2693         WinCairoPort.
2694
2695         * Scripts/webkitpy/port/win.py:
2696         (WinCairoPort.default_baseline_search_path):
2697         (WinCairoPort):
2698         (WinCairoPort._port_specific_expectations_files):
2699         (WinCairoPort._search_paths):
2700
2701 2019-02-22  Tim Horton  <timothy_horton@apple.com>
2702
2703         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
2704         https://bugs.webkit.org/show_bug.cgi?id=194963
2705
2706         Reviewed by Dean Jackson.
2707
2708         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2709         Do a `contains` check instead of `equals`, because in debug builds we
2710         put the GraphicsLayer pointer in a prefix.
2711
2712 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2713
2714         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
2715         https://bugs.webkit.org/show_bug.cgi?id=194873
2716         <rdar://problem/46701974>
2717
2718         Reviewed by Tim Horton.
2719
2720         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
2721
2722         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2723         (WTR::UIScriptController::menuRect const):
2724         (WTR::UIScriptController::isShowingMenu const):
2725         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2726         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2727         (WTR::UIScriptController::menuRect const):
2728
2729         Add a function to query the bounds of the callout menu in content coordinates.
2730
2731         (WTR::UIScriptController::isShowingMenu const):
2732
2733         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
2734
2735         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2736         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2737         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2738         (WTR::UIScriptController::rectForMenuAction const):
2739         (WTR::UIScriptController::menuRect const):
2740         (WTR::UIScriptController::isShowingMenu const):
2741         (WTR::findViewInHierarchyOfType): Deleted.
2742
2743 2019-02-22  Chris Dumez  <cdumez@apple.com>
2744
2745         Regression(PSON) Unable to preview password-protected documents on iCloud.com
2746         https://bugs.webkit.org/show_bug.cgi?id=194954
2747         <rdar://problem/48127957>
2748
2749         Reviewed by Alex Christensen.
2750
2751         Add API test coverage.
2752
2753         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2754         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
2755         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2756         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2757
2758 2019-02-22  Chris Dumez  <cdumez@apple.com>
2759
2760         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
2761         https://bugs.webkit.org/show_bug.cgi?id=194924
2762         <rdar://problem/48216125>
2763
2764         Reviewed by Geoffrey Garen.
2765
2766         Add API test coverage.
2767
2768         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2769
2770 2019-02-22  Chris Dumez  <cdumez@apple.com>
2771
2772         Unreviewed, disable API test added in r241928 on iOS.
2773
2774         The cache is not enabled on devices with less than 3GB of RAM.
2775
2776         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2777
2778 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
2779
2780         Hardcode Visual Viewports on everywhere except iOS WK1
2781         https://bugs.webkit.org/show_bug.cgi?id=194928
2782
2783         Reviewed by Zalan Bujtas.
2784
2785         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
2786         change the default value of the Setting to 'true', and hardcode WebView on iOS to
2787         set it to false. The setting has shipped for several years and there's no need to turn
2788         it off now.
2789
2790         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
2791         Visual Viewports are not enabled.
2792         
2793         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
2794         that only runs in WK2
2795
2796         * MiniBrowser/mac/SettingsController.h:
2797         * MiniBrowser/mac/SettingsController.m:
2798         (-[SettingsController init]):
2799         (-[SettingsController _populateMenu]):
2800         (-[SettingsController validateMenuItem:]):
2801         (-[SettingsController visualViewportEnabled]): Deleted.
2802         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
2803         * MiniBrowser/mac/WK1BrowserWindowController.m:
2804         (-[WK1BrowserWindowController didChangeSettings]):
2805         * MiniBrowser/mac/WK2BrowserWindowController.m:
2806         (-[WK2BrowserWindowController didChangeSettings]):
2807
2808 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
2809
2810         Discard cached processes when clearing website data store
2811         https://bugs.webkit.org/show_bug.cgi?id=194894
2812
2813         Reviewed by Chris Dumez.
2814
2815         Added a test case.
2816
2817         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2818         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
2819
2820 2019-02-21  Alex Christensen  <achristensen@webkit.org>
2821
2822         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
2823         https://bugs.webkit.org/show_bug.cgi?id=194914
2824         <rdar://problem/47586889>
2825
2826         Reviewed by Geoffrey Garen.
2827
2828         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2829         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
2830         (TEST):
2831         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
2832
2833 2019-02-21  David Kilzer  <ddkilzer@apple.com>
2834
2835         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
2836         <https://webkit.org/b/194761>
2837
2838         Reviewed by Myles Maxfield.
2839
2840         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2841         (WTR::activateSystemCoreWebFonts): Log `error` to console if
2842         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
2843         to use ARC-compliant cast.
2844         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
2845         ARC-compliant cast.
2846         (WTR::installFakeHelvetica): Log `error` to console if
2847         CTFontManagerRegisterFontsForURL() fails, but only on supported
2848         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
2849         Call CFRelease() on `error` to fix the leak.  Update to use
2850         ARC-compliant cast.
2851         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
2852         cast.
2853
2854 2019-02-21  Chris Dumez  <cdumez@apple.com>
2855
2856         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
2857         https://bugs.webkit.org/show_bug.cgi?id=194481
2858
2859         Reviewed by Alex Christensen.
2860
2861         Give the processes a chance to shutdown and wait until we reached the expected number
2862         of processes.
2863
2864         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2865
2866 2019-02-21  Tim Horton  <timothy_horton@apple.com>
2867
2868         Fix the macOS build
2869
2870         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2871
2872 2019-02-21  Tim Horton  <timothy_horton@apple.com>
2873
2874         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
2875
2876         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2877         I am a backwards.
2878
2879 2019-02-21  Tim Horton  <timothy_horton@apple.com>
2880
2881         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
2882
2883         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2884         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
2885         We could force on UI-side compositing, but I feel like the test might be more
2886         valuable exercising the normal path on each platform (though the original
2887         bug was also UI-side specific). Though we can't validate that the overlay
2888         layer was installed successfully, there are layout tests that do that.
2889
2890 2019-02-21  Tim Horton  <timothy_horton@apple.com>
2891
2892         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
2893         https://bugs.webkit.org/show_bug.cgi?id=194845
2894         <rdar://problem/47944579>
2895
2896         Reviewed by Antti Koivisto.
2897
2898         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2899         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2900
2901 2019-02-21  Zalan Bujtas  <zalan@apple.com>
2902
2903         [LFC][Floats] Add support for placing formatting roots in-between floats.
2904         https://bugs.webkit.org/show_bug.cgi?id=194902
2905
2906         Reviewed by Antti Koivisto.
2907
2908         * LayoutReloaded/misc/LFC-passing-tests.txt:
2909
2910 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
2911
2912         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
2913         https://bugs.webkit.org/show_bug.cgi?id=194901
2914
2915         Unreviewed build fix.
2916
2917         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
2918         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
2919         WPEBackend-fdo-0.1 as library name.
2920
2921 2019-02-21  Rob Buis  <rbuis@igalia.com>
2922
2923         Update MIME type parser
2924         https://bugs.webkit.org/show_bug.cgi?id=180526
2925
2926         Reviewed by Darin Adler.
2927
2928         Add tests involving leading and trailing whitespace, non-token
2929         characters and quoted strings.
2930
2931         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2932         (TestWebKitAPI::TEST):
2933
2934 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
2935
2936         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
2937         https://bugs.webkit.org/show_bug.cgi?id=194884
2938
2939         Reviewed by Michael Catanzaro.
2940
2941         * PlatformWin.cmake:
2942
2943 2019-02-20  Chris Dumez  <cdumez@apple.com>
2944
2945         Add API test for <rdar://problem/47471222>
2946         https://bugs.webkit.org/show_bug.cgi?id=194847
2947
2948         Reviewed by Alex Christensen.
2949
2950         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2951
2952 2019-02-20  Chris Dumez  <cdumez@apple.com>
2953
2954         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
2955         https://bugs.webkit.org/show_bug.cgi?id=194872
2956         <rdar://problem/47924500>
2957
2958         Reviewed by Alex Christensen.
2959
2960         Add API test coverage.
2961
2962         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2963
2964 2019-02-20  Jer Noble  <jer.noble@apple.com>
2965
2966         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
2967         https://bugs.webkit.org/show_bug.cgi?id=191332
2968
2969         Reviewed by Dean Jackson.
2970
2971         * Scripts/git-is-in-range: Added.
2972
2973 2019-02-20  Andy Estes  <aestes@apple.com>
2974
2975         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
2976         https://bugs.webkit.org/show_bug.cgi?id=194869
2977
2978         Rubber-stamped by Jer Noble.
2979
2980         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2981         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
2982         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2983         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
2984         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2985         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2986
2987 2019-02-20  Chris Dumez  <cdumez@apple.com>
2988
2989         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
2990         https://bugs.webkit.org/show_bug.cgi?id=194857
2991         <rdar://problem/47759323>
2992
2993         Reviewed by Alex Christensen.
2994
2995         Add API test coverage.
2996
2997         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2998
2999 2019-02-20  Chris Dumez  <cdumez@apple.com>
3000
3001         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
3002         https://bugs.webkit.org/show_bug.cgi?id=194829
3003         <rdar://problem/47889906>
3004
3005         Reviewed by Alexey Proskuryakov.
3006
3007         Every time the TestOptions were changing we were creating both a new Web view and
3008         a new WKContext, which would start a new Network process. In most cases, we only
3009         need to contruct a new Web view and we do can keep reusing the same WKContext.
3010         This patch implements this optimization and thus avoids spinning a lot of new
3011         Network processes while running the layout tests.
3012
3013         * WebKitTestRunner/TestController.cpp:
3014         (WTR::TestController::generateContextConfiguration const):
3015         (WTR::TestController::generatePageConfiguration):
3016         (WTR::TestController::createWebViewWithOptions):
3017         (WTR::TestController::resetPreferencesToConsistentValues):
3018         (WTR::updateTestOptionsFromTestHeader):
3019         * WebKitTestRunner/TestController.h:
3020         * WebKitTestRunner/TestOptions.h:
3021         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
3022         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
3023         (WTR::TestOptions::hasSameInitializationOptions const):
3024         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
3025         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3026         (WTR::TestController::platformAddTestOptions const):
3027
3028 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
3029
3030         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
3031         https://bugs.webkit.org/show_bug.cgi?id=167941
3032
3033         Reviewed by Carlos Garcia Campos.
3034
3035         * MiniBrowser/gtk/main.c:
3036         (filterSavedCallback): Added.
3037         (main): Support loading a JSON rule set file for content filtering.
3038         * MiniBrowser/wpe/main.cpp:
3039         (filterSavedCallback): Added.
3040         (main): Support loading a JSON rule set file for content filtering.
3041         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
3042         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
3043         (WTF::derefGPtr): Ditto.
3044         (testEmptyStore):
3045         (testSaveInvalidFilter):
3046         (testSaveLoadFilter):
3047         (testSavedFilterIdentifierMatch):
3048         (testRemoveFilter):
3049         (testSaveMultipleFilters):
3050         (testSaveFilterFromFile):
3051         (testFilterPersistence):
3052         (beforeAll):
3053         (afterAll):
3054         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
3055         (removeOldInjectedContentAndResetLists): Also reset content filters.
3056         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
3057         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
3058         the element affected by the style sheet.
3059         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
3060         and returns it to be used by tests.
3061         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
3062         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
3063         (serverCallback): Add support for serving a CSS style sheet for testing.
3064         (beforeAll): Add call to testUserContentManagerContentFilter().
3065         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
3066
3067 2019-02-19  Keith Rollin  <krollin@apple.com>
3068
3069         Add timing information to build output
3070         https://bugs.webkit.org/show_bug.cgi?id=194839
3071         <rdar://problem/48219609>
3072
3073         Reviewed by Alexey Proskuryakov.
3074
3075         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
3076         emit each project's build time to its output. E.g.,
3077
3078             ** BUILD SUCCEEDED ** [0.132 sec]
3079
3080         * Scripts/webkitdirs.pm:
3081         (XcodeOptions):
3082
3083 2019-02-19  Truitt Savell  <tsavell@apple.com>
3084
3085         Unreviewed, rolling out r241784.
3086
3087         Broke all OpenSource builds.
3088
3089         Reverted changeset:
3090
3091         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
3092         instances view"
3093         https://bugs.webkit.org/show_bug.cgi?id=172848
3094         https://trac.webkit.org/changeset/241784
3095
3096 2019-02-19  Zalan Bujtas  <zalan@apple.com>
3097
3098         [LFC][Floats] Remove redundant intersecting logic
3099         https://bugs.webkit.org/show_bug.cgi?id=194804
3100
3101         Reviewed by Antti Koivisto.
3102
3103         * LayoutReloaded/misc/LFC-passing-tests.txt:
3104
3105 2019-02-19  Dean Jackson  <dino@apple.com>
3106
3107         Clean-up output from generate-xcfilelists so it can be filtered
3108         https://bugs.webkit.org/show_bug.cgi?id=194795
3109
3110         Reviewed by Joseph Pecoraro (and Keith Rollin).
3111
3112         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
3113         make a slight tweak to filter-build-webkit so such lines are marked
3114         as plain.
3115
3116         * Scripts/filter-build-webkit:
3117         * Scripts/generate-xcfilelists:
3118
3119 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
3120
3121         pytest is not correctly auto-installed
3122         https://bugs.webkit.org/show_bug.cgi?id=194707
3123
3124         Reviewed by Carlos Garcia Campos.
3125
3126         * Scripts/webkitpy/thirdparty/__init__.py:
3127         (AutoinstallImportHook._install_pytest):
3128
3129 2019-02-18  Chris Dumez  <cdumez@apple.com>
3130
3131         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
3132         https://bugs.webkit.org/show_bug.cgi?id=194797
3133         <rdar://problem/48055151>
3134
3135         Reviewed by Geoffrey Garen.
3136
3137         Add API test coverage.
3138
3139         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3140
3141 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3142
3143         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
3144         https://bugs.webkit.org/show_bug.cgi?id=194670
3145         <rdar://problem/39066529>
3146
3147         Reviewed by Tim Horton.
3148
3149         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
3150         pasted in an editable area as attachment elements.
3151
3152         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
3153         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3154         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
3155         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3156         (TestWebKitAPI::TEST):
3157         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3158         (WTR::InjectedBundlePage::InjectedBundlePage):
3159
3160 2019-02-18  Alex Christensen  <achristensen@webkit.org>
3161
3162         Fix API test after r241728
3163        ​https://bugs.webkit.org/show_bug.cgi?id=194723
3164
3165         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3166         (TEST):
3167         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
3168
3169 2019-02-18  Daniel Bates  <dabates@apple.com>
3170
3171         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
3172         https://bugs.webkit.org/show_bug.cgi?id=192824
3173         <rdar://problem/47100332>
3174
3175         Reviewed by Wenson Hsieh.
3176
3177         Fix a bug where the wrong usage code was used for F13 thru F24.
3178
3179         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3180         (keyCodeForDOMFunctionKey):
3181
3182 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
3183
3184         Bytecode cache should a have a boot-specific validation
3185         https://bugs.webkit.org/show_bug.cgi?id=194769
3186         <rdar://problem/48149509>
3187
3188         Reviewed by Keith Miller.
3189
3190         Add test for WTF::bootSessionUUIDString()
3191
3192         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3193         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
3194         (TEST):
3195
3196 2019-02-18  Alex Christensen  <achristensen@webkit.org>
3197
3198         Disable safe browsing in WKWebView and remove its WKPreferences API
3199         https://bugs.webkit.org/show_bug.cgi?id=194723
3200         <rdar://problem/48122993>
3201
3202         Reviewed by Geoffrey Garen.
3203
3204         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3205         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3206         (TEST):
3207         (safeBrowsingView):
3208         Make tests use SPI instead of API.
3209
3210 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
3211
3212         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
3213         https://bugs.webkit.org/show_bug.cgi?id=194586
3214
3215         Reviewed by Ross Kirsling.
3216
3217         * DumpRenderTree/win/DumpRenderTree.cpp:
3218         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
3219         * Scripts/webkitpy/port/driver.py:
3220         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
3221
3222 2019-02-17  David Kilzer  <ddkilzer@apple.com>
3223
3224         Unreviewed, rolling out r241620.
3225
3226         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
3227         (Requested by ddkilzer on #webkit.)
3228
3229         Reverted changeset:
3230
3231         "[WTF] Add environment variable helpers"
3232         https://bugs.webkit.org/show_bug.cgi?id=192405
3233         https://trac.webkit.org/changeset/241620
3234
3235 2019-02-16  Zalan Bujtas  <zalan@apple.com>
3236
3237         [LFC] RenderImage's default intrinsic size is 0.
3238         https://bugs.webkit.org/show_bug.cgi?id=194745
3239
3240         Reviewed by Antti Koivisto.
3241
3242         * LayoutReloaded/misc/LFC-passing-tests.txt:
3243
3244 2019-02-16  Zalan Bujtas  <zalan@apple.com>
3245
3246         [LFC][BFC] Add support for block replaced intrinsic width.
3247         https://bugs.webkit.org/show_bug.cgi?id=194705
3248
3249         Reviewed by Simon Fraser.
3250
3251         * LayoutReloaded/misc/LFC-passing-tests.txt:
3252
3253 2019-02-16  Zalan Bujtas  <zalan@apple.com>
3254
3255         [LFC] Apply min/max width constraints to preferred width computation
3256         https://bugs.webkit.org/show_bug.cgi?id=194739
3257
3258         Reviewed by Simon Fraser.
3259
3260         * LayoutReloaded/misc/LFC-passing-tests.txt:
3261
3262 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
3263
3264         [WTF] Add environment variable helpers
3265         https://bugs.webkit.org/show_bug.cgi?id=192405
3266
3267         Reviewed by Michael Catanzaro.
3268
3269         * DumpRenderTree/mac/DumpRenderTree.mm:
3270         (libraryPathForDumpRenderTree):
3271         * DumpRenderTree/win/DumpRenderTree.cpp:
3272         (libraryPathForDumpRenderTree):
3273         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
3274         (setUpIOSLayoutTestCommunication):
3275         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3276         (beforeAll):
3277         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
3278         (main):
3279         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3280         (WebKitTestBus::run):
3281         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3282         (WTR::getOutputDir):
3283         (WTR::initializeFontConfigSetting):
3284         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
3285         (WTR::InjectedBundle::platformInitialize):
3286         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
3287         (WTR::topLevelPath):
3288         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
3289         (WTR::topLevelPath):
3290         (WTR::getOutputDir):
3291         (WTR::activateFonts):
3292         * WebKitTestRunner/TestController.cpp:
3293         (WTR::TestController::libraryPathForTesting):
3294         (WTR::TestController::generateContextConfiguration const):
3295         (WTR::TestController::generatePageConfiguration):
3296         (WTR::TestController::decideDestinationWithSuggestedFilename):
3297         (WTR::TestController::platformAdjustContext):
3298         * WebKitTestRunner/TestController.h:
3299         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3300         (WTR::TestController::cocoaPlatformInitialize):
3301         (WTR::TestController::platformAdjustContext):
3302         * WebKitTestRunner/gtk/main.cpp:
3303         (main):
3304         * WebKitTestRunner/mac/TestControllerMac.mm:
3305         (WTR::TestController::configureContentExtensionForTest):
3306         * WebKitTestRunner/wpe/main.cpp:
3307         (main):
3308         Utilize WTF::Environment where possible.
3309
3310 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3311
3312         [iOS] WKWebView callout bar is missing Change Writing Direction item
3313         https://bugs.webkit.org/show_bug.cgi?id=190015
3314         <rdar://problem/44810366>
3315
3316         Reviewed by Tim Horton.
3317
3318         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
3319         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
3320
3321         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
3322         (TestWebKitAPI::TEST):
3323
3324 2019-02-15  Chris Dumez  <cdumez@apple.com>
3325
3326         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
3327         https://bugs.webkit.org/show_bug.cgi?id=194717
3328         <rdar://problem/47884404>
3329
3330         Reviewed by Brady Eidson.
3331
3332         Add API test coverage.
3333
3334         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3335
3336 2019-02-15  Youenn Fablet  <youenn@apple.com>
3337
3338         Make navigator.mediaDevices SecureContext
3339         https://bugs.webkit.org/show_bug.cgi?id=194666
3340
3341         Reviewed by Eric Carlson.
3342
3343         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
3344         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
3345         (TEST_F):
3346
3347 2019-02-15  Brian Burg  <bburg@apple.com>
3348
3349         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
3350         https://bugs.webkit.org/show_bug.cgi?id=194411
3351         <rdar://problem/47787614>
3352
3353         Reviewed by Joseph Pecoraro.
3354
3355         Remove unnecessary soft linking macro usage.
3356
3357         * DumpRenderTree/mac/TestRunnerMac.mm:
3358         (TestRunner::inspectorTestStubURL):
3359         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
3360         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3361         (WTR::TestRunner::inspectorTestStubURL):
3362
3363 2019-02-15  Commit Queue  <commit-queue@webkit.org>
3364
3365         Unreviewed, rolling out r241559 and r241566.
3366         https://bugs.webkit.org/show_bug.cgi?id=194710
3367
3368         Causes layout test crashes under GuardMalloc (Requested by
3369         ryanhaddad on #webkit).
3370
3371         Reverted changesets:
3372
3373         "[WTF] Add environment variable helpers"
3374         https://bugs.webkit.org/show_bug.cgi?id=192405
3375         https://trac.webkit.org/changeset/241559
3376
3377         "Unreviewed build fix for WinCairo Debug after r241559."
3378         https://trac.webkit.org/changeset/241566
3379
3380 2019-02-15  Zalan Bujtas  <zalan@apple.com>
3381
3382         [LFC] Out-of-flow box is never a float box
3383         https://bugs.webkit.org/show_bug.cgi?id=194704
3384
3385         Reviewed by Antti Koivisto.
3386
3387         * LayoutReloaded/misc/LFC-passing-tests.txt:
3388
3389 2019-02-10  Darin Adler  <darin@apple.com>
3390
3391         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
3392         https://bugs.webkit.org/show_bug.cgi?id=194487
3393
3394         Reviewed by Daniel Bates.
3395
3396         * DumpRenderTree/win/DumpRenderTree.cpp:
3397         (applicationId): Use makeString instead of String::format.
3398         (main): Ditto.
3399         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3400         (TestWebKitAPI::Util::createURLForResource): Ditto.
3401         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3402         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
3403
3404         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3405         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
3406         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
3407         (WTR::createStringWithAttributes): Use appendLiteral.
3408         (WTR::AccessibilityUIElement::helpText const): Ditto.
3409         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
3410         directly instead of using String::format.
3411         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
3412         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
3413
3414 2019-02-15  Truitt Savell  <tsavell@apple.com>
3415
3416         Unreviewed, rolling out r241564.
3417
3418         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
3419
3420         Reverted changeset:
3421
3422         "[Mac] WebInspectorUI.framework does not need to be soft-
3423         linked anymore"
3424         https://bugs.webkit.org/show_bug.cgi?id=194411
3425         https://trac.webkit.org/changeset/241564
3426
3427 2019-02-15  Saam barati  <sbarati@apple.com>
3428
3429         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
3430         https://bugs.webkit.org/show_bug.cgi?id=194036
3431
3432         Reviewed by Yusuke Suzuki.
3433
3434         * Scripts/run-jsc-stress-tests:
3435
3436 2019-02-14  Tim Horton  <timothy_horton@apple.com>
3437
3438         Fix the build.
3439
3440         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3441         (WTR::UIScriptController::drawSquareInEditableImage):
3442         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3443         (TestWebKitAPI::drawSquareInEditableImage):
3444
3445 2019-02-14  Tim Horton  <timothy_horton@apple.com>
3446
3447         Fix the build.
3448
3449         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3450         (WTR::UIScriptController::drawSquareInEditableImage):
3451         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3452         (TestWebKitAPI::drawSquareInEditableImage):
3453
3454 2019-02-14  Brian Burg  <bburg@apple.com>
3455
3456         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
3457         https://bugs.webkit.org/show_bug.cgi?id=194411
3458         <rdar://problem/47787614>
3459
3460         Reviewed by Joseph Pecoraro.
3461
3462         Remove unnecessary soft linking macro usage.
3463
3464         * DumpRenderTree/mac/TestRunnerMac.mm:
3465         (TestRunner::inspectorTestStubURL):
3466         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
3467         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3468         (WTR::TestRunner::inspectorTestStubURL):
3469
3470 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
3471
3472         [ews-app] status bubble should fetch builder name info from BuilderMapping table
3473         https://bugs.webkit.org/show_bug.cgi?id=194599
3474
3475         Reviewed by Lucas Forschler.
3476
3477         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3478         (StatusBubble._build_bubble):
3479
3480 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
3481
3482         [ews-app] Set Foreign Key in Django build model
3483         https://bugs.webkit.org/show_bug.cgi?id=194667
3484
3485         Reviewed by Lucas Forschler.
3486
3487         * BuildSlaveSupport/ews-app/ews/models/build.py:
3488         (Build):
3489
3490 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
3491
3492         [WTF] Add environment variable helpers
3493         https://bugs.webkit.org/show_bug.cgi?id=192405
3494
3495         Reviewed by Michael Catanzaro.
3496
3497         * DumpRenderTree/mac/DumpRenderTree.mm:
3498         (libraryPathForDumpRenderTree):
3499         * DumpRenderTree/win/DumpRenderTree.cpp:
3500         (libraryPathForDumpRenderTree):
3501         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
3502         (setUpIOSLayoutTestCommunication):
3503         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3504         (TestWebKitAPI::strip):
3505         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3506         (beforeAll):
3507         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
3508         (main):
3509         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3510         (WebKitTestBus::run):
3511         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3512         (WTR::getOutputDir):
3513         (WTR::initializeFontConfigSetting):
3514         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
3515         (WTR::InjectedBundle::platformInitialize):
3516         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
3517         (WTR::topLevelPath):
3518         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
3519         (WTR::topLevelPath):
3520         (WTR::getOutputDir):
3521         (WTR::activateFonts):
3522         * WebKitTestRunner/TestController.cpp:
3523         (WTR::TestController::libraryPathForTesting):
3524         (WTR::TestController::generateContextConfiguration const):
3525         (WTR::TestController::generatePageConfiguration):
3526         (WTR::TestController::decideDestinationWithSuggestedFilename):
3527         (WTR::TestController::platformAdjustContext):
3528         * WebKitTestRunner/TestController.h:
3529         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3530         (WTR::TestController::cocoaPlatformInitialize):
3531         (WTR::TestController::platformAdjustContext):
3532         * WebKitTestRunner/gtk/main.cpp:
3533         (main):
3534         * WebKitTestRunner/mac/TestControllerMac.mm:
3535         (WTR::TestController::configureContentExtensionForTest):
3536         * WebKitTestRunner/wpe/main.cpp:
3537         (main):
3538         Utilize WTF::Environment where possible.
3539
3540 2019-02-14  Chris Dumez  <cdumez@apple.com>
3541
3542         [PSON] Introduce a WebContent Process cache
3543         https://bugs.webkit.org/show_bug.cgi?id=194594
3544         <rdar://problem/46793397>
3545
3546         Reviewed by Geoff Garen.
3547
3548         Update API tests to turn on the WebContent Process cache.
3549
3550         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3551
3552 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
3553
3554         Unreviewed, build fix after r241480
3555
3556         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3557         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
3558         (-[DragAndDropSimulator initWithWebView:]):
3559
3560 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
3561
3562         AX: ARIA Reflection was disabled in error
3563         https://bugs.webkit.org/show_bug.cgi?id=194647
3564         <rdar://problem/48068336>
3565
3566         Reviewed by Ryosuke Niwa.
3567
3568         Remove test override now that this feature should be enabled by default.
3569
3570         * WebKitTestRunner/TestController.cpp:
3571         (WTR::TestController::resetPreferencesToConsistentValues):
3572
3573 2019-02-14  Commit Queue  <commit-queue@webkit.org>
3574
3575         Unreviewed, rolling out r241486.
3576         https://bugs.webkit.org/show_bug.cgi?id=194655
3577
3578         causing API failures in builds (Requested by ShawnRoberts on
3579         #webkit).
3580
3581         Reverted changeset:
3582
3583         "[Cocoa] Media elements will restart network buffering just
3584         before suspending"
3585         https://bugs.webkit.org/show_bug.cgi?id=193691
3586         https://trac.webkit.org/changeset/241486
3587
3588 2019-02-14  Zalan Bujtas  <zalan@apple.com>
3589
3590         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
3591         https://bugs.webkit.org/show_bug.cgi?id=194622
3592
3593         Reviewed by Antti Koivisto.
3594
3595         * LayoutReloaded/misc/LFC-passing-tests.txt:
3596
3597 2019-02-14  Zalan Bujtas  <zalan@apple.com>
3598
3599         [LFC] Shrink-to-fit-width should be constrained by min/max width
3600         https://bugs.webkit.org/show_bug.cgi?id=194653
3601
3602         Reviewed by Antti Koivisto.
3603
3604         * LayoutReloaded/misc/LFC-passing-tests.txt:
3605
3606 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
3607
3608         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
3609         https://bugs.webkit.org/show_bug.cgi?id=194641
3610
3611         Reviewed by Geoffrey Garen.
3612
3613         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
3614         so that the test would fail without this fix.
3615
3616         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
3617         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
3618
3619 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
3620
3621         [ews-app] Change log level for a log statement
3622
3623         Unreviewed minor fix.
3624
3625         * BuildSlaveSupport/ews-app/ews/models/patch.py:
3626         (Patch.save_patch):
3627
3628 2019-02-13  Jer Noble  <jer.noble@apple.com>
3629
3630         [Cocoa] Media elements will restart network buffering just before suspending
3631         https://bugs.webkit.org/show_bug.cgi?id=193691
3632
3633         Reviewed by Eric Carlson.
3634
3635         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3636         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3637         (TEST):
3638
3639 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
3640
3641         [ews-app] Fetch builder id to name mapping
3642         https://bugs.webkit.org/show_bug.cgi?id=194355
3643
3644         Reviewed by Lucas Forschler.
3645
3646         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3647         (Buildbot.get_builder_id_to_name_mapping):
3648         (Buildbot._get_display_name_from_builder_name):
3649
3650 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
3651
3652         Further restricting webarchive loads
3653         https://bugs.webkit.org/show_bug.cgi?id=194567
3654         <rdar://problem/47610130>
3655
3656         Reviewed by Youenn Fablet.
3657
3658         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
3659         navigations on drop.
3660
3661         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3662         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
3663         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
3664         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3665         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3666         (TestWebKitAPI::TEST):
3667         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
3668         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
3669         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
3670         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
3671         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
3672         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
3673         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
3674
3675 2019-02-13  John Wilander  <wilander@apple.com>
3676
3677         Store Ad Click Attribution requests in the network process
3678         https://bugs.webkit.org/show_bug.cgi?id=194510
3679         <rdar://problem/47650118>
3680
3681         Reviewed by Alex Christensen and Daniel Bates.
3682
3683         This patch adds two TestRunner functions:
3684         - dumpAdClickAttribution()
3685         - clearAdClickAttribution()
3686
3687         They call into the network process to dump and clear Ad Click
3688         Attribution state, respectively.
3689
3690         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3691         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3692         (WTR::TestRunner::dumpAdClickAttribution):
3693         (WTR::TestRunner::clearAdClickAttribution):
3694         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3695         * WebKitTestRunner/TestController.cpp:
3696         (WTR::TestController::resetStateToConsistentValues):
3697         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
3698         (WTR::adClickAttributionStringResultCallback):
3699         (WTR::TestController::dumpAdClickAttribution):
3700         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
3701         (WTR::adClickAttributionVoidCallback):
3702         (WTR::TestController::clearAdClickAttribution):
3703         * WebKitTestRunner/TestController.h:
3704         * WebKitTestRunner/TestInvocation.cpp:
3705         (WTR::TestInvocation::dumpResults):
3706         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3707         (WTR::TestInvocation::dumpAdClickAttribution):
3708         * WebKitTestRunner/TestInvocation.h:
3709
3710 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
3711
3712         [ews-app] Generate status-bubble