URL set by document.open() is not communicated to the UIProcess
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-15  Chris Dumez  <cdumez@apple.com>
2
3         URL set by document.open() is not communicated to the UIProcess
4         https://bugs.webkit.org/show_bug.cgi?id=196941
5         <rdar://problem/49237544>
6
7         Reviewed by Geoffrey Garen.
8
9         Add API test coverage.
10
11         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
12         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
13         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
14         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
15         (TEST):
16
17 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
18
19         Using Tools/Scripts/clean-webkit should not install requests
20         https://bugs.webkit.org/show_bug.cgi?id=196940
21
22         Reviewed by Lucas Forschler.
23
24         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
25         existing, depending on the path autoinstalled is run through.
26         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
27         needed.
28         (Port.configuration_for_upload):
29         (Port.commits_for_upload):
30
31 2019-04-15  Alex Christensen  <achristensen@webkit.org>
32
33         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
34         https://bugs.webkit.org/show_bug.cgi?id=196773
35
36         Reviewed by Jer Noble.
37
38         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
39         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
40         (TEST):
41
42 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
43
44         ews-build should clearly indicate flaky test failures
45         https://bugs.webkit.org/show_bug.cgi?id=196947
46
47         Reviewed by Lucas Forschler.
48
49         * BuildSlaveSupport/ews-build/steps.py:
50         (AnalyzeAPITestsResults.analyzeResults):
51
52 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
53
54         InjectedBundle parameters often need initialization function called before unarchiving
55         https://bugs.webkit.org/show_bug.cgi?id=189709
56         <rdar://problem/44573653>
57
58         Reviewed by Ryosuke Niwa.
59
60         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
61         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
62
63 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
64
65         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
66         https://bugs.webkit.org/show_bug.cgi?id=196681
67
68         Reviewed by Darin Adler.
69
70         Added tests.
71
72         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
73         (WTF_HashSet.RemoveIf):
74         (WTF_HashSet.RemoveIfShrinkToBestSize):
75
76 2019-04-15  John Wilander  <wilander@apple.com>
77
78         Send delayed Ad Click Attribution conversion requests to the click source
79         https://bugs.webkit.org/show_bug.cgi?id=196838
80         <rdar://problem/47650157>
81
82         Reviewed by Chris Dumez and Youenn Fablet.
83
84         This patch adds test infrastructure to override the default behavior in
85         WebKit::NetworkAdClickAttribution.
86
87         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
88         (TestWebKitAPI::TEST):
89         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
90         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
91         (WTR::TestRunner::dumpAdClickAttribution):
92         (WTR::TestRunner::clearAdClickAttribution):
93         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
94         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
95         * WebKitTestRunner/InjectedBundle/TestRunner.h:
96         * WebKitTestRunner/TestController.cpp:
97         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
98         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
99         * WebKitTestRunner/TestController.h:
100         * WebKitTestRunner/TestInvocation.cpp:
101         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
102
103 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
104
105         [ews-app] status-bubble should display position in queue
106         https://bugs.webkit.org/show_bug.cgi?id=196607
107
108         Reviewed by Lucas Forschler.
109
110         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
111         (StatusBubble._build_bubble):
112         (StatusBubble._queue_position): Method to calculate patch's position in queue.
113
114 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
115
116         [ews-build] Do not run clean build by default on EWS builders
117         https://bugs.webkit.org/show_bug.cgi?id=196897
118
119         Reviewed by Lucas Forschler.
120
121         * BuildSlaveSupport/ews-build/steps.py:
122         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
123         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
124         untracked directories like WebKitBuild).
125         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
126         untracked files/directories (like WebKitBuild).
127
128 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
129
130         TestRunner::notifyDone() should be safely reentrant
131         https://bugs.webkit.org/show_bug.cgi?id=196898
132
133         Reviewed by Darin Adler.
134
135         It is currently possible that TestRunner::notifyDone() will call itself, since
136         notifyDone() will force a repaint, which can start executing JavaScript, which
137         may call notifyDone() again. This can lead to test failures and flakiness.
138         Fix this by setting the m_waitToDump flag before calling the dump() method.
139
140         * DumpRenderTree/mac/TestRunnerMac.mm:
141         (TestRunner::notifyDone):
142         (TestRunner::forceImmediateCompletion):
143         * DumpRenderTree/win/TestRunnerWin.cpp:
144         (TestRunner::notifyDone):
145         (TestRunner::forceImmediateCompletion):
146
147 2019-04-15  Philippe Normand  <pnormand@igalia.com>
148
149         [GTK][WPE] Add enable-media websetting
150         https://bugs.webkit.org/show_bug.cgi?id=196863
151
152         Reviewed by Michael Catanzaro.
153
154         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
155         (testWebKitSettings): Add test for the enable-media web-setting.
156
157 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
158
159         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
160         https://bugs.webkit.org/show_bug.cgi?id=196905
161         <rdar://problem/49886096>
162
163         Reviewed by Tim Horton.
164
165         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
166         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
167         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
168         delay timer, we end up with this sequence of events in the problematic (failure) case:
169
170         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
171             ...IPC from UI to web process...
172         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
173             ...IPC from web to UI process...
174         (c) [UI]    Invoke completion handler for script #1
175         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
176             ...IPC from UI to web process...
177         (e) [Web]   Evaluate script #2 in the web process
178         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
179
180         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
181         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
182         #2 is run in step (e).
183
184         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
185         the UI process by waiting on a script message posted by the web process, after attachment updates are
186         dispatched.
187
188         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
189         (TestWebKitAPI::TEST):
190
191 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
192
193         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
194         https://bugs.webkit.org/show_bug.cgi?id=196909
195
196         Reviewed by Wenson Hsieh.
197
198         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
199         (TestWebKitAPI::TEST):
200
201 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
202
203         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
204         https://bugs.webkit.org/show_bug.cgi?id=196880
205
206         Reviewed by Yusuke Suzuki.
207
208         Add a new function for bytecode cache tests that does not forceDiskCache
209         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
210         test added in this patch, since the code is invalid and therefore won't be
211         cached. It should also be useful for tests that evaluate dynamically
212         generated code.
213
214         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
215         * Scripts/run-jsc-stress-tests:
216
217 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
218
219         Update AudioSession route sharing policy
220         https://bugs.webkit.org/show_bug.cgi?id=196776
221         <rdar://problem/46501611>
222
223         Reviewed by Jer Noble.
224
225         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
226         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
227         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
228         (TestWebKitAPI::TEST):
229
230 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
231
232         [iOS] Software keyboard is shown too frequently on some websites
233         https://bugs.webkit.org/show_bug.cgi?id=195856
234         <rdar://problem/49191395>
235
236         Reviewed by Darin Adler.
237
238         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
239
240         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
241         (WTR::UIScriptController::setHardwareKeyboardAttached):
242         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
243         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
244         (WTR::UIScriptController::setHardwareKeyboardAttached):
245         * TestRunnerShared/UIScriptContext/UIScriptController.h:
246         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
247
248         Additionally link against GraphicsServices in WebKitTestRunner.
249
250         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
251         (WTR::TestController::platformResetStateToConsistentValues):
252         (WTR::UIScriptController::setHardwareKeyboardAttached):
253
254 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
255
256         [GTK][WPE] Fix pacman install-dependencies packages
257         https://bugs.webkit.org/show_bug.cgi?id=196817
258
259         Reviewed by Žan Doberšek.
260         
261         python3-setuptools is called python-setuptools
262         ruby-highline is only available on AUR
263         libv4l-devel is incorporated in v4l-utils
264
265         * gtk/install-dependencies:
266         * wpe/install-dependencies:
267
268 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
269
270         [GTK] REGRESSION(r243860): Many tests failing
271         https://bugs.webkit.org/show_bug.cgi?id=196791
272
273         Reviewed by Joanmarie Diggs.
274
275         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
276         multiple documents and check that accessibility hierarchy is updated after a navigation.
277
278         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
279         (loadChangedCallback):
280         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
281         (AccessibilityTest::AccessibilityTest):
282         (AccessibilityTest::~AccessibilityTest):
283         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
284         (AccessibilityTest::findTestServerApplication):
285         (AccessibilityTest::findDocumentWeb):
286         (AccessibilityTest::findRootObject):
287         (AccessibilityTest::waitUntilChildrenRemoved):
288         (AccessibilityTest::ensureProxy):
289         (testAtspiBasicHierarchy):
290         (beforeAll):
291         (afterAll):
292
293 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
294
295         [ews-build] Handle bug titles with unicode characters
296         https://bugs.webkit.org/show_bug.cgi?id=196802
297
298         Reviewed by Dewei Zhu.
299
300         * BuildSlaveSupport/ews-build/steps.py:
301         (ValidatePatch._is_bug_closed):
302
303 2019-04-11  Michael Saboff  <msaboff@apple.com>
304
305         Improve the Inline Cache Stats code
306         https://bugs.webkit.org/show_bug.cgi?id=196836
307
308         Reviewed by Saam Barati.
309
310         Added a new script to consolidate and arrange the output of --useICStats option.
311
312         This script merges the output from every group into one large table and sorts it from most common to
313         least common.  It also counts the slow path GetById and PutById variants and then calculates the
314         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
315         Put together, this is useful to see what property accesses are not getting cached.
316
317         * Scripts/ic-stats.py: Added.
318         (ICStats):
319         (ICStats.__init__):
320         (ICStats.parse):
321         (ICStats.dumpStats):
322         (usage):
323
324 2019-04-10  Alex Christensen  <achristensen@webkit.org>
325
326         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
327         https://bugs.webkit.org/show_bug.cgi?id=196809
328         <rdar://49800762>
329
330         Reviewed by Brady Eidson.
331
332         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
333         (TEST):
334
335 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
336
337         requestAnimationFrame should execute before the next frame
338         https://bugs.webkit.org/show_bug.cgi?id=177484
339
340         Reviewed by Simon Fraser.
341
342         Add trace points for the page RenderingUpdate.
343
344         * Tracing/SystemTracePoints.plist:
345
346 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
347
348         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
349         https://bugs.webkit.org/show_bug.cgi?id=196760
350
351         Reviewed by Don Olmstead.
352
353         vswhere.exe has been bundled since Visual Studio 2017 version
354         15.2. We shouldn't download vswhere.exe.
355
356         * Scripts/build-jsc: Do not call update-vswhere.py.
357         * Scripts/build-webkit: Ditto.
358         * Scripts/update-vswhere.py: Removed.
359         * Scripts/webkitdirs.pm:
360         (requireModulesForVSWhere): Deleted.
361         (pickCurrentVisualStudioInstallation): Deleted.
362         (visualStudioInstallDirVSWhere): Return the latest installed VS
363         installation path by using the bundled vswhere.exe.
364         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
365         (visualStudioInstallDirFallback): Removed.
366
367 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
368
369         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
370         https://bugs.webkit.org/show_bug.cgi?id=196780
371
372         Reviewed by Alexey Proskuryakov.
373
374         * BuildSlaveSupport/ews-build/steps.py:
375         * BuildSlaveSupport/ews-build/steps_unittest.py:
376
377 2019-04-10  Alex Christensen  <achristensen@webkit.org>
378
379         Add SPI WKNavigationResponse._downloadAttribute
380         https://bugs.webkit.org/show_bug.cgi?id=196755
381         <rdar://49587365>
382
383         Reviewed by Brady Eidson.
384
385         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
386         (-[NavigationResponseTestDelegate navigationResponse]):
387         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
388         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
389         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
390         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
391         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
392         (readRequest):
393         (writeResponse):
394         (TEST):
395
396 2019-04-10  Tim Horton  <timothy_horton@apple.com>
397
398         Add modern API for overriding the page's specified viewport configuration
399         https://bugs.webkit.org/show_bug.cgi?id=167734
400         <rdar://problem/30331795>
401
402         Reviewed by Simon Fraser.
403
404         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
405         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
406
407 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
408
409         Add support for incremental bytecode cache updates
410         https://bugs.webkit.org/show_bug.cgi?id=195000
411
412         Reviewed by Filip Pizlo.
413
414         Exit when the initial run to generate bytecode fails.
415
416         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
417
418 2019-04-10  Alex Christensen  <achristensen@webkit.org>
419
420         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
421         https://bugs.webkit.org/show_bug.cgi?id=196744
422         <rdar://49415309>
423
424         Reviewed by Chris Dumez.
425
426         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
427         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
428
429 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
430
431         Add a way to opt into modern compatibility mode in layout tests
432         https://bugs.webkit.org/show_bug.cgi?id=196770
433         <rdar://problem/49777550>
434
435         Reviewed by Antoine Quint.
436
437         Add a new test option to enable modern compatibility mode in layout tests.
438
439         * WebKitTestRunner/TestController.cpp:
440         (WTR::updateTestOptionsFromTestHeader):
441         * WebKitTestRunner/TestController.h:
442         * WebKitTestRunner/TestOptions.h:
443         (WTR::TestOptions::hasSameInitializationOptions const):
444         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
445         (WTR::TestController::platformCreateWebView):
446         (WTR::TestController::enableModernCompatibilityMode):
447
448 2019-04-10  Andy Estes  <aestes@apple.com>
449
450         Try to fix the 32-bit watchOS build.
451
452         * TestWebKitAPI/cocoa/TestWKWebView.mm:
453         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
454
455 2019-04-10  Antoine Quint  <graouts@apple.com>
456
457         Enable Pointer Events on watchOS
458         https://bugs.webkit.org/show_bug.cgi?id=196771
459         <rdar://problem/49040909>
460
461         Reviewed by Dean Jackson.
462
463         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
464
465 2019-04-10  Philippe Normand  <pnormand@igalia.com>
466
467         Unreviewed. Fix WPE accessibility tests after r244059.
468
469         We are failing to load the injected bundle due to undefined symbol
470         AccessibilityUIElement::replaceTextInRange().
471
472         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
473         (WTR::AccessibilityUIElement::replaceTextInRange):
474
475 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
476
477         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
478         https://bugs.webkit.org/show_bug.cgi?id=196727
479
480         Reviewed by Fujii Hironori.
481
482         * MiniBrowser/win/WebKitBrowserWindow.cpp:
483         (WebKitBrowserWindow::create):
484
485 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
486
487         [ews-build] Add unit tests for PrintConfiguration
488         https://bugs.webkit.org/show_bug.cgi?id=196752
489
490         Reviewed by Dewei Zhu.
491
492         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
493
494 2019-04-09  Keith Rollin  <krollin@apple.com>
495
496         Unreviewed build maintenance -- update .xcfilelists.
497
498         * DumpRenderTree/DerivedSources-input.xcfilelist:
499         * DumpRenderTree/DerivedSources-output.xcfilelist:
500
501 2019-04-09  Zalan Bujtas  <zalan@apple.com>
502
503         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
504         https://bugs.webkit.org/show_bug.cgi?id=196743
505         <rdar://problem/43897551>
506
507         Reviewed by Tim Horton.
508
509         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
510         (TEST):
511
512 2019-04-09  Youenn Fablet  <youenn@apple.com>
513
514         Close service worker database on network process suspension
515         https://bugs.webkit.org/show_bug.cgi?id=196623
516         <rdar://problem/48930869>
517
518         Reviewed by Alex Christensen.
519
520         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
521
522 2019-04-09  Daniel Bates  <dabates@apple.com>
523
524         [iPad] Should open popover when the spacebar is pressed
525         https://bugs.webkit.org/show_bug.cgi?id=196360
526         <rdar://problem/49389129>
527
528         Reviewed by Brent Fulgham.
529
530         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
531
532         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
533         (WTR::UIScriptController::isShowingPopover const): Added.
534         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
535         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
536         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
537         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
538         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
539         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
540         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
541         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
542         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
543         (WTR::UIScriptController::isShowingPopover const): Added.
544         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
545         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
546         * TestRunnerShared/UIScriptContext/UIScriptController.h:
547         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
548         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
549         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
550         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
551         (-[TestRunnerWKWebView _willPresentPopover]): Added.
552         (-[TestRunnerWKWebView _didDismissPopover]): Added.
553         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
554         (WTR::UIScriptController::isShowingPopover const): Added.
555         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
556         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
557
558 2019-04-09  Alex Christensen  <achristensen@webkit.org>
559
560         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
561         https://bugs.webkit.org/show_bug.cgi?id=196665
562         <rdar://45115669>
563
564         Reviewed by Geoff Garen.
565
566         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
567         (goBack):
568         (+[SimpleLookupContext sharedLookupContext]):
569         (-[SimpleLookupContext lookUpURL:completionHandler:]):
570         (TEST):
571         (+[Simple3LookupContext sharedLookupContext]): Deleted.
572         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
573
574 2019-04-09  John Wilander  <wilander@apple.com>
575
576         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
577         https://bugs.webkit.org/show_bug.cgi?id=196558
578         <rdar://problem/47650245>
579
580         Reviewed by Youenn Fablet.
581
582         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
583         (TestWebKitAPI::TEST):
584             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
585
586 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
587
588         [CMake] Apple builds should use ICU_INCLUDE_DIRS
589         https://bugs.webkit.org/show_bug.cgi?id=196720
590
591         Reviewed by Konstantin Tokarev.
592
593         * TestWebKitAPI/PlatformMac.cmake:
594
595 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
596
597         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
598         https://bugs.webkit.org/show_bug.cgi?id=196694
599         <rdar://problem/48388734>
600
601         Rubber-stamped by Aakash Jain.
602
603         * Scripts/webkitpy/port/image_diff.py:
604         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
605         * Scripts/webkitpy/port/server_process.py:
606         (ServerProcess.has_available_stdout): Check if stdout has data in it.
607         (ServerProcess._wait_for_data_and_update_buffers_using_select):
608         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
609         * Scripts/webkitpy/port/server_process_mock.py:
610         (MockServerProcess.has_available_stdout):
611         * Scripts/webkitpy/port/server_process_unittest.py:
612         (TestServerProcess.serial_test_basic):
613
614 2019-04-09  Jer Noble  <jer.noble@apple.com>
615
616         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
617         https://bugs.webkit.org/show_bug.cgi?id=196097
618
619         Reviewed by Eric Carlson.
620
621         Drive-by bug fix: allow tests to play audio without a user gesture by default.
622
623         * DumpRenderTree/mac/DumpRenderTree.mm:
624         (resetWebPreferencesToConsistentValues):
625         * WebKitTestRunner/TestController.cpp:
626         (WTR::TestController::resetPreferencesToConsistentValues):
627
628 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
629
630         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
631         https://bugs.webkit.org/show_bug.cgi?id=196690
632
633         Reviewed by Michael Catanzaro.
634
635         * QueueStatusServer/config/queues.py:
636         * Scripts/webkitpy/common/config/ews.json:
637         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
638         (test_ews_name):
639
640 2019-04-09  Chris Dumez  <cdumez@apple.com>
641
642         Loads using loadHTMLString() cause flashing when process-swapping
643         https://bugs.webkit.org/show_bug.cgi?id=196714
644         <rdar://problem/49637354>
645
646         Reviewed by Antti Koivisto.
647
648         Add API test coverage.
649
650         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
651
652 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
653
654         Unreviewed. Fix ATK accessibility tests after r244059.
655
656         We are failing to load the injected bundle due to undefined symbol
657         AccessibilityUIElement::replaceTextInRange().
658
659         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
660         (WTR::AccessibilityUIElement::replaceTextInRange):
661
662 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
663
664         AX: Support API: accessibilityReplaceRange:withText
665         https://bugs.webkit.org/show_bug.cgi?id=196636
666
667         Unreviewed build fix for Windows port.
668
669         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
670         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
671
672 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
673
674         [CMake][WinCairo] Separate copied headers into different directories
675         https://bugs.webkit.org/show_bug.cgi?id=196655
676
677         Reviewed by Michael Catanzaro.
678
679         * DumpRenderTree/CMakeLists.txt:
680         * MiniBrowser/win/CMakeLists.txt:
681         * TestWebKitAPI/CMakeLists.txt:
682         * TestWebKitAPI/PlatformWin.cmake:
683
684 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
685
686         Log stack-trace for run-webkit-tests when interrupted
687         https://bugs.webkit.org/show_bug.cgi?id=176393
688         <rdar://problem/34262310>
689
690         Reviewed by Lucas Forschler.
691
692         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
693         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
694         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
695         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
696         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
697         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
698         (main): Set handlers to log stack trace on interruption.
699
700 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
701
702         AX: Support API: accessibilityReplaceRange:withText
703         https://bugs.webkit.org/show_bug.cgi?id=196636
704
705         Unreviewed build fix for Windows port.
706
707         * DumpRenderTree/AccessibilityUIElement.cpp:
708         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
709
710 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
711
712         [ews-build] Scripts using Buildbot API have CORS error
713         https://bugs.webkit.org/show_bug.cgi?id=196709
714
715         Reviewed by Alexey Proskuryakov.
716
717         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
718
719 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
720
721         AX: Support API: accessibilityReplaceRange:withText
722         https://bugs.webkit.org/show_bug.cgi?id=196636
723
724         Reviewed by Daniel Bates.
725
726         * DumpRenderTree/AccessibilityUIElement.cpp:
727         (replaceTextInRangeCallback):
728         (AccessibilityUIElement::replaceTextInRange):
729         (AccessibilityUIElement::getJSClass):
730         * DumpRenderTree/AccessibilityUIElement.h:
731         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
732         (AccessibilityUIElement::replaceTextInRange):
733         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
734         (AccessibilityUIElement::replaceTextInRange):
735         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
736         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
737         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
738         (WTR::AccessibilityUIElement::replaceTextInRange):
739         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
740         (WTR::AccessibilityUIElement::replaceTextInRange):
741
742 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
743
744         [iOS] Do not allow starting selection drags when selection views are not visible
745         https://bugs.webkit.org/show_bug.cgi?id=196686
746         <rdar://problem/49399192>
747
748         Reviewed by Tim Horton.
749
750         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
751         also add some new API tests to cover scenarios where the web view is not first responder.
752
753         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
754         (TestWebKitAPI::TEST):
755         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
756
757         Add a switch to optionally make the web view first responder when starting the simulated drag.
758
759         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
760         (-[DragAndDropSimulator initWithWebView:]):
761         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
762
763 2019-04-08  Justin Fan  <justin_fan@apple.com>
764
765         [Web GPU] Fix Web GPU experimental feature on iOS
766         https://bugs.webkit.org/show_bug.cgi?id=196632
767
768         Reviewed by Myles C. Maxfield.
769
770         Properly make Web GPU available on iOS 11+.
771
772         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
773
774 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
775
776         [ews-build] Do not upload archive when Compile Fails
777         https://bugs.webkit.org/show_bug.cgi?id=196674
778
779         Reviewed by Alexey Proskuryakov.
780
781         * BuildSlaveSupport/ews-build/factories.py:
782         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
783         * BuildSlaveSupport/ews-build/steps.py:
784         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
785         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
786         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
787
788 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
789
790         Enable DFG on MIPS
791         https://bugs.webkit.org/show_bug.cgi?id=196689
792
793         Reviewed by Žan Doberšek.
794
795         Since the bytecode change, we enabled the baseline JIT on mips in
796         r240432, but DFG is still missing. With this change, all tests are
797         passing on a ci20 board.
798
799         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
800
801 2019-04-08  Philippe Normand  <pnormand@igalia.com>
802
803         [Flatpak] Second run update-webkitwpe-flatpak fails
804         https://bugs.webkit.org/show_bug.cgi?id=192702
805
806         Reviewed by Carlos Garcia Campos.
807
808         * flatpak/flatpakutils.py:
809         (FlatpakObject.flatpak): Fix typo.
810         (FlatpakPackage.install): When installing, also update to the configured remote commit.
811         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
812
813 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
814
815         [GTK][WPE] outlook.live.com displays old-fashioned UI
816         https://bugs.webkit.org/show_bug.cgi?id=196642
817
818         Reviewed by Carlos Garcia Campos.
819
820         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
821         (TestWebKitAPI::TEST): New Mac platform quirk test.
822
823 2019-04-07  Commit Queue  <commit-queue@webkit.org>
824
825         Unreviewed, rolling out r243956.
826         https://bugs.webkit.org/show_bug.cgi?id=196688
827
828         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
829         by aakashjain on #webkit).
830
831         Reverted changeset:
832
833         "Clicking "Go Back" from a safe browsing warning from an
834         iframe should navigate the WKWebView back to the previous
835         page"
836         https://bugs.webkit.org/show_bug.cgi?id=196665
837         https://trac.webkit.org/changeset/243956
838
839 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
840
841         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
842         https://bugs.webkit.org/show_bug.cgi?id=196669
843
844         Reviewed by Geoffrey Garen.
845
846         Added three new unit tests for WeakHashSet.
847
848         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
849         (WTF_WeakPtr.WeakHashSetConstObjects):
850         (WTF_WeakPtr.WeakHashSetComputesEmpty):
851         (WTF_WeakPtr.WeakHashSetComputeSize):
852
853 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
854
855         Hide next and previous form control buttons when WKWebView is editable
856         https://bugs.webkit.org/show_bug.cgi?id=196672
857         <rdar://problem/35625321>
858
859         Reviewed by Tim Horton.
860
861         Add a new API test.
862
863         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
864         (-[TestWKWebView lastTrailingBarButtonGroup]):
865         (TestWebKitAPI::TEST):
866         * TestWebKitAPI/ios/UIKitSPI.h:
867
868 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
869
870         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
871         https://bugs.webkit.org/show_bug.cgi?id=196077
872         <rdar://problem/49108202>
873
874         Reviewed by Chris Dumez.
875
876         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
877         on new web view.
878
879         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
880
881 2019-04-05  Saam Barati  <sbarati@apple.com>
882
883         Make compare-results understand MotionMark
884         https://bugs.webkit.org/show_bug.cgi?id=196666
885
886         Reviewed by Yusuke Suzuki.
887
888         * Scripts/compare-results:
889         (PLT5Results):
890         (detectMotionMark):
891         (detectMotionMark1_1):
892         (motionMarkResults):
893         (motionMark1_1Results):
894         (detectBenchmark):
895         (biggerIsBetter):
896         (main):
897
898 2019-04-05  Alex Christensen  <achristensen@webkit.org>
899
900         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
901         https://bugs.webkit.org/show_bug.cgi?id=196665
902         <rdar://45115669>
903
904         Reviewed by Geoff Garen.
905
906         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
907         (goBack):
908         (+[SimpleLookupContext sharedLookupContext]):
909         (-[SimpleLookupContext lookUpURL:completionHandler:]):
910         (TEST):
911         (+[Simple3LookupContext sharedLookupContext]): Deleted.
912         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
913
914 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
915
916         [ews-build] Add configuration and architecture for windows builders
917         https://bugs.webkit.org/show_bug.cgi?id=196660
918
919         Reviewed by Lucas Forschler.
920
921         * BuildSlaveSupport/ews-build/config.json:
922
923 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
924
925         webkitpy: Don't run subsequent rounds if interrupted
926         https://bugs.webkit.org/show_bug.cgi?id=196646
927
928         Reviewed by Aakash Jain.
929
930         * Scripts/webkitpy/layout_tests/controllers/manager.py:
931         (Manager.run): Bail out if interrupted.
932
933 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
934
935         Test sessionStorage in PSON private browsing mode
936         https://bugs.webkit.org/show_bug.cgi?id=196561
937
938         Reviewed by Alex Christensen.
939
940         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
941
942 2019-04-05  Commit Queue  <commit-queue@webkit.org>
943
944         Unreviewed, rolling out r243833.
945         https://bugs.webkit.org/show_bug.cgi?id=196645
946
947         This change breaks build of WPE and GTK ports (Requested by
948         annulen on #webkit).
949
950         Reverted changeset:
951
952         "[CMake][WTF] Mirror XCode header directories"
953         https://bugs.webkit.org/show_bug.cgi?id=191662
954         https://trac.webkit.org/changeset/243833
955
956 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
957
958         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
959         https://bugs.webkit.org/show_bug.cgi?id=196635
960
961         Reviewed by Antti Koivisto.
962         
963         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
964         for a test to enable async frame scrolling via:
965             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
966         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
967         
968         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
969
970         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
971         (WTR::InjectedBundle::beginTesting):
972         * WebKitTestRunner/TestController.cpp:
973         (WTR::TestController::resetPreferencesToConsistentValues):
974
975 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
976
977         Use a correct LC_RPATH when building with ASan
978         https://bugs.webkit.org/show_bug.cgi?id=196576
979
980         Reviewed by David Kilzer.
981
982         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
983         so that ../Frameworks is checked. This is simpler and more reliable than updating
984         each SPC service xcconfig.
985
986 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
987
988         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
989         https://bugs.webkit.org/show_bug.cgi?id=196629
990
991         Reviewed by Lucas Forschler.
992
993         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
994
995 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
996
997         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
998         https://bugs.webkit.org/show_bug.cgi?id=196618
999
1000         Reviewed by Lucas Forschler.
1001
1002         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1003         (StatusBubble): Added QUEUE_TRIGGERS.
1004         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
1005         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
1006         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
1007         its parent(builder).
1008
1009 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1010
1011         [ews-app] Status-bubble steps are sometimes displayed in reverse order
1012         https://bugs.webkit.org/show_bug.cgi?id=196625
1013
1014         Reviewed by Lucas Forschler.
1015
1016         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1017         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
1018
1019 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1020
1021         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
1022         https://bugs.webkit.org/show_bug.cgi?id=196630
1023
1024         Reviewed by Wenson Hsieh.
1025
1026         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1027
1028 2019-04-04  Youenn Fablet  <youenn@apple.com>
1029
1030         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
1031         https://bugs.webkit.org/show_bug.cgi?id=196543
1032
1033         Reviewed by Alex Christensen.
1034
1035         * WebKitTestRunner/TestController.cpp:
1036         (WTR::TestController::generatePageConfiguration):
1037
1038 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1039
1040         [ews-app] Status bubble should not display skipped buildbot steps
1041         https://bugs.webkit.org/show_bug.cgi?id=196584
1042
1043         Reviewed by Lucas Forschler.
1044
1045         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1046
1047 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
1048
1049         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
1050         https://bugs.webkit.org/show_bug.cgi?id=196620
1051
1052         Reviewed by Lucas Forschler.
1053
1054         * BuildSlaveSupport/ews-app/ews/config.py:
1055
1056 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
1057
1058         [Win] DumpRenderTreeWatchDog.py is not checked into source
1059         https://bugs.webkit.org/show_bug.cgi?id=196567
1060         <rdar://problem/49525901>
1061
1062         Reviewed by Lucas Forschler.
1063
1064         This script is used on Win EWS bots to terminate hanging DRT processes.
1065
1066         * EWSTools/dumprendertreewatchdog.py: Added.
1067
1068 2019-04-04  Chris Dumez  <cdumez@apple.com>
1069
1070         Unreviewed, roll out r243858 which made tests time out.
1071
1072         Disable new API tests on Windows instead.
1073
1074         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1075         (TestWebKitAPI::TEST):
1076
1077 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1078
1079         [ATK] Cleanup WebPageAccessibilityObjectAtk
1080         https://bugs.webkit.org/show_bug.cgi?id=196537
1081
1082         Reviewed by Michael Catanzaro.
1083
1084         Also consider files under atk directories as exceptions for GObject conventions.
1085
1086         * Scripts/webkitpy/style/checkers/cpp.py:
1087         (check_identifier_name_in_declaration):
1088
1089 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1090
1091         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1092         https://bugs.webkit.org/show_bug.cgi?id=196588
1093         <rdar://problem/49365787>
1094
1095         Unreviewed build fix for Windows port.
1096
1097         error C3861: 'kill': identifier not found
1098
1099         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1100         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
1101
1102 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1103
1104         [ews-build] Cancel build and similar operations should have authentication
1105         https://bugs.webkit.org/show_bug.cgi?id=196520
1106
1107         Reviewed by Dewei Zhu.
1108
1109         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
1110         environment variables.
1111
1112 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1113
1114         [ews-build] Do not trigger queues which are not in production yet
1115         https://bugs.webkit.org/show_bug.cgi?id=196581
1116
1117         Reviewed by Dewei Zhu.
1118
1119         * BuildSlaveSupport/ews-build/config.json:
1120
1121 2019-04-03  Chris Dumez  <cdumez@apple.com>
1122
1123         Unreviewed, fix typo in the name of API test added in r243848.
1124
1125         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1126         (TestWebKitAPI::TEST):
1127
1128 2019-04-03  Chris Dumez  <cdumez@apple.com>
1129
1130         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
1131         https://bugs.webkit.org/show_bug.cgi?id=196588
1132         <rdar://problem/49365787>
1133
1134         Reviewed by Ryosuke Niwa.
1135
1136         Add API test coverage.
1137
1138         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1139         (TestWebKitAPI::nullJavaScriptCallback):
1140         (TestWebKitAPI::didCrashCheckFrames):
1141         (TestWebKitAPI::TEST):
1142
1143 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1144
1145         run-webkit-tests: Upload test results (new results database)
1146         https://bugs.webkit.org/show_bug.cgi?id=196577
1147         <rdar://problem/34841155>
1148
1149         Reviewed by Lucas Forschler.
1150
1151         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1152         (Manager.run): Upload results after each device shard, since the configuration will be
1153         different for each device.
1154         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
1155         uploaded to a results database.
1156         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1157         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
1158
1159 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1160
1161         -apple-trailing-word is needed for browser detection
1162         https://bugs.webkit.org/show_bug.cgi?id=196575
1163
1164         Unreviewed.
1165
1166         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1167
1168 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
1169
1170         [CMake][WTF] Mirror XCode header directories
1171         https://bugs.webkit.org/show_bug.cgi?id=191662
1172
1173         Reviewed by Konstantin Tokarev.
1174
1175         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
1176         builds.
1177
1178         * CMakeLists.txt:
1179         * DumpRenderTree/CMakeLists.txt:
1180         * DumpRenderTree/PlatformWin.cmake:
1181         * MiniBrowser/win/CMakeLists.txt:
1182         * TestWebKitAPI/CMakeLists.txt:
1183         * TestWebKitAPI/PlatformWin.cmake:
1184         * WebKitTestRunner/PlatformGTK.cmake:
1185         * WebKitTestRunner/PlatformWin.cmake:
1186
1187 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1188
1189         [ews-app] Status bubble should not display certain infrastructure status messages
1190         https://bugs.webkit.org/show_bug.cgi?id=196550
1191
1192         Reviewed by Lucas Forschler.
1193
1194         Do not display the steps which are un-needed for end-user. This information is still avaiable
1195         if the user click on the bubble and look at the Buildbot build.
1196         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1197         (StatusBubble._steps_messages):
1198         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
1199
1200 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
1201
1202         [ews-build] Use https for sending data to ews-app
1203         https://bugs.webkit.org/show_bug.cgi?id=196492
1204
1205         Reviewed by Lucas Forschler.
1206
1207         * BuildSlaveSupport/ews-build/events.py:
1208
1209 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
1210
1211         Remove support for -apple-trailing-word
1212         https://bugs.webkit.org/show_bug.cgi?id=196525
1213
1214         Reviewed by Zalan Bujtas.
1215
1216         This CSS property is nonstandard and not used.
1217
1218         * Scripts/webkitperl/FeatureList.pm:
1219         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1220
1221 2019-04-03  Youenn Fablet  <youenn@apple.com>
1222
1223         Add a test for DOMCache on multiple browsing in case of private browsing
1224         https://bugs.webkit.org/show_bug.cgi?id=196524
1225
1226         Reviewed by Alex Christensen.
1227
1228         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1229         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
1230
1231 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
1232
1233         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
1234         https://bugs.webkit.org/show_bug.cgi?id=196540
1235
1236         Reviewed by Aakash Jain.
1237
1238         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
1239
1240 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1241
1242         Add plumbing for a compatibility mode preference in WebKit
1243         https://bugs.webkit.org/show_bug.cgi?id=196005
1244
1245         Reviewed by Tim Horton.
1246
1247         Add new API tests.
1248
1249         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1250         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
1251
1252 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
1253
1254         [WPE][GTK] Update libsrtp dependency package for Debian
1255         https://bugs.webkit.org/show_bug.cgi?id=196528
1256
1257         Reviewed by Frédéric Wang.
1258
1259         * gtk/install-dependencies:
1260         * wpe/install-dependencies:
1261
1262 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1263
1264         [WK2] Add support for Window's beforeprint / afterprint events
1265         https://bugs.webkit.org/show_bug.cgi?id=196478
1266         <rdar://problem/49535124>
1267
1268         Unreviewed build fix for MSVC.
1269
1270         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
1271
1272         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
1273
1274         * WebKitTestRunner/TestController.cpp:
1275         (WTR::printFrame): Use int and float literals.
1276
1277 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1278
1279         [ews-build] Reassign bots to queues
1280
1281         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
1282
1283 2019-04-02  Chris Dumez  <cdumez@apple.com>
1284
1285         [WK2] Add support for Window's beforeprint / afterprint events
1286         https://bugs.webkit.org/show_bug.cgi?id=196478
1287
1288         Reviewed by Alex Christensen.
1289
1290         Add minimal implementation for printFrame in WebKitTestRunner.
1291
1292         * WebKitTestRunner/TestController.cpp:
1293         (WTR::printFrame):
1294         (WTR::TestController::createOtherPage):
1295         (WTR::TestController::createWebViewWithOptions):
1296
1297 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1298
1299         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
1300         https://bugs.webkit.org/show_bug.cgi?id=196491
1301
1302         Reviewed by Lucas Forschler.
1303
1304         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1305
1306 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
1307
1308         [ews-build] Configure buildbot try credentials in environment variables
1309         https://bugs.webkit.org/show_bug.cgi?id=196501
1310
1311         Reviewed by Lucas Forschler.
1312
1313         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
1314         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
1315         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
1316
1317 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1318
1319         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
1320         https://bugs.webkit.org/show_bug.cgi?id=196496
1321         <rdar://problem/49521634>
1322
1323         Reviewed by Chris Dumez.
1324
1325         Add new API tests (see WebKit ChangeLog for more detail).
1326
1327         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1328         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1329         (TEST):
1330
1331 2019-04-02  David Kilzer  <ddkilzer@apple.com>
1332
1333         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
1334         <https://webkit.org/b/196499>
1335
1336         Reviewed by Alexey Proskuryakov.
1337
1338         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
1339         ENABLE_ADDRESS_SANITIZER.
1340
1341 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1342
1343         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
1344         https://bugs.webkit.org/show_bug.cgi?id=182757
1345
1346         Reviewed by Don Olmstead.
1347
1348         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
1349         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1350
1351 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
1352
1353         run-api-tests: Upload test results
1354         https://bugs.webkit.org/show_bug.cgi?id=196323
1355         <rdar://problem/49356714>
1356
1357         Reviewed by Lucas Forschler.
1358
1359         * Scripts/webkitpy/api_tests/manager.py:
1360         (Manager):
1361         (Manager.run): Upload results to a results database.
1362         * Scripts/webkitpy/api_tests/run_api_tests.py:
1363         (parse_args): Add upload arguments.
1364         * Scripts/webkitpy/port/base.py:
1365         (Port):
1366         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
1367         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
1368         with commits from any other associated repositories.
1369         * Scripts/webkitpy/port/device.py:
1370         (Device):
1371         (Device.build_version): Access build_versoin of underlying platform device.
1372         * Scripts/webkitpy/port/ios_simulator_unittest.py:
1373         (IOSSimulatorTest):
1374         (IOSSimulatorTest.test_configuration_for_upload):
1375         * Scripts/webkitpy/port/device_port.py:
1376         (DevicePort):
1377         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
1378         the same as the machine uploading results.
1379         * Scripts/webkitpy/port/mac.py:
1380         (MacPort):
1381         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
1382         * Scripts/webkitpy/port/mac_unittest.py:
1383         (MacTest):
1384         (MacTest.test_configuration_for_upload):
1385         * Scripts/webkitpy/xcode/simulated_device.py:
1386         (SimulatedDeviceManager._create_device_with_runtime):
1387         (SimulatedDevice.__init__): Create simulated device with a build_version.
1388         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1389         (test_existing_simulator):
1390
1391 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1392
1393         Remove extra newline characters (Follow-up fix to r243707)
1394
1395         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1396
1397 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1398
1399         [ews-app] Use API_KEY to accept results data
1400         https://bugs.webkit.org/show_bug.cgi?id=196461
1401
1402         Reviewed by Dewei Zhu.
1403
1404         * BuildSlaveSupport/ews-app/ews/views/results.py:
1405         (Results.post): Validate EWS_API_KEY before accepting any data.
1406         * BuildSlaveSupport/ews-build/events.py:
1407         (Events.sendData): Send EWS_API_KEY if available along with event data.
1408
1409 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1410
1411         Unable to copy and paste a PDF from Notes into Mail compose body
1412         https://bugs.webkit.org/show_bug.cgi?id=196442
1413         <rdar://problem/48573098>
1414
1415         Reviewed by Tim Horton.
1416
1417         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
1418         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
1419         to be specified on the item providers.
1420
1421         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1422         (TestWebKitAPI::mapItemForTesting):
1423         (TestWebKitAPI::contactItemForTesting):
1424
1425 2019-04-01  Tim Horton  <timothy_horton@apple.com>
1426
1427         Make UIWKDocumentContext rects per-character instead of per-word
1428         https://bugs.webkit.org/show_bug.cgi?id=196459
1429
1430         Reviewed by Wenson Hsieh.
1431
1432         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1433         (TEST):
1434         Adjust test results due to switching to per-character rects.
1435
1436 2019-04-01  Chris Dumez  <cdumez@apple.com>
1437
1438         UIProcess crash when a prewarmed process is terminated
1439         https://bugs.webkit.org/show_bug.cgi?id=196451
1440         <rdar://problem/49245471>
1441
1442         Reviewed by Geoffrey Garen.
1443
1444         Add API test coverage.
1445
1446         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1447         (TEST):
1448
1449 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1450
1451         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
1452         https://bugs.webkit.org/show_bug.cgi?id=196449
1453
1454         Reviewed by Lucas Forschler.
1455
1456         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1457         (StatusBubble.get_os_details): Method to get OS and Xcode details.
1458         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
1459         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
1460
1461 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
1462
1463         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
1464         https://bugs.webkit.org/show_bug.cgi?id=196444
1465
1466         Reviewed by Lucas Forschler.
1467
1468         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
1469
1470 2019-04-01  Alex Christensen  <achristensen@webkit.org>
1471
1472         Add SPI to canonicalize NSURLs with WTF::URL
1473         https://bugs.webkit.org/show_bug.cgi?id=196415
1474         <rdar://problem/44980271>
1475
1476         Reviewed by Darin Adler.
1477
1478         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1479         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
1480         (TestWebKitAPI::TEST):
1481
1482 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
1483
1484         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
1485         https://bugs.webkit.org/show_bug.cgi?id=196441
1486
1487         Reviewed by Carlos Garcia Campos.
1488
1489         Don't cache the wpe_view_backend object that might not exist yet at the
1490         time of EventSenderProxy constructor invocation, but instead retrieve
1491         that object whenever it's required for event dispatching. This should
1492         avoid crashes in this constructor now that it's invoked before any
1493         PlatformWindow has been set up (as changed in r243496).
1494
1495         * WebKitTestRunner/EventSenderProxy.h:
1496         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1497         (WTR::viewBackend):
1498         (WTR::EventSenderProxy::EventSenderProxy):
1499         (WTR::EventSenderProxy::mouseDown):
1500         (WTR::EventSenderProxy::mouseUp):
1501         (WTR::EventSenderProxy::mouseMoveTo):
1502         (WTR::EventSenderProxy::mouseScrollBy):
1503         (WTR::EventSenderProxy::keyDown):
1504         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
1505
1506 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1507
1508         [Win][WebKit] MiniBrowser should support high DPI display
1509         https://bugs.webkit.org/show_bug.cgi?id=196391
1510
1511         Reviewed by Alex Christensen.
1512
1513         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1514         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
1515         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
1516         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
1517
1518 2019-03-31  Sam Weinig  <weinig@apple.com>
1519
1520         Remove more i386 specific configurations
1521         https://bugs.webkit.org/show_bug.cgi?id=196430
1522
1523         Reviewed by Alexey Proskuryakov.
1524
1525         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1526         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
1527
1528 2019-03-31  Andy Estes  <aestes@apple.com>
1529
1530         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
1531         https://bugs.webkit.org/show_bug.cgi?id=196433
1532         <rdar://problem/49293305>
1533
1534         Reviewed by Tim Horton.
1535
1536         Enhanced API test coverage to include all navigation response policy decisions in both
1537         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
1538
1539         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1540         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
1541         (TestWebKitAPI::TEST):
1542         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
1543         (readFile):
1544         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
1545         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
1546         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1547         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1548         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1549         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
1550         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
1551         (-[QuickLookDelegate _downloadDidStart:]):
1552         (-[QuickLookDelegate _download:didReceiveResponse:]):
1553         (-[QuickLookDelegate _download:didReceiveData:]):
1554         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1555         (-[QuickLookDelegate _downloadDidFinish:]):
1556         (-[QuickLookDelegate _download:didFailWithError:]):
1557         (-[QuickLookDelegate _downloadDidCancel:]):
1558         (-[QuickLookDelegate verifyDownload]):
1559         (runTest):
1560         (runTestDecideBeforeLoading):
1561         (runTestDecideAfterLoading):
1562         (TEST):
1563         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1564         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1565         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
1566         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1567         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1568         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
1569         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1570         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
1571         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
1572         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
1573         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
1574         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
1575         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
1576         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
1577
1578 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
1579
1580         [CMake] add testdfg as target with build-jsc
1581         https://bugs.webkit.org/show_bug.cgi?id=196393
1582
1583         Reviewed by Saam Barati.
1584
1585         Added testdfg as one of the targets to build when
1586         using CMake.
1587
1588         * Scripts/build-jsc:
1589
1590 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
1591
1592         Delete WebMetal implementation in favor of WebGPU
1593         https://bugs.webkit.org/show_bug.cgi?id=195418
1594
1595         Reviewed by Dean Jackson.
1596
1597         * DumpRenderTree/mac/DumpRenderTree.mm:
1598         (enableExperimentalFeatures):
1599         (resetWebPreferencesToConsistentValues):
1600         * Scripts/webkitperl/FeatureList.pm:
1601         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1602         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1603         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
1604         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
1605         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
1606         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
1607         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
1608         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
1609         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
1610         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1611         (WTR::InjectedBundle::beginTesting):
1612         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1613         (WTR::TestRunner::setWebMetalEnabled): Deleted.
1614         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1615
1616 2019-03-29  Chris Dumez  <cdumez@apple.com>
1617
1618         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
1619         https://bugs.webkit.org/show_bug.cgi?id=196405
1620         <rdar://problem/49428130>
1621
1622         Reviewed by Wenson Hsieh.
1623
1624         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
1625         the popover presentation methods to be no-ops. Use this in the new test added in
1626         r243523 so that we do not swizzle those methods for all tests. This is needed because
1627         those WatchOS tests rely on the popover getting presented and interactive.
1628
1629         * WebKitTestRunner/TestController.cpp:
1630         (WTR::updateTestOptionsFromTestHeader):
1631         * WebKitTestRunner/TestController.h:
1632         * WebKitTestRunner/TestOptions.h:
1633         (WTR::TestOptions::hasSameInitializationOptions const):
1634         * WebKitTestRunner/ios/TestControllerIOS.mm:
1635         (WTR::TestController::platformInitialize):
1636         (WTR::TestController::platformResetStateToConsistentValues):
1637
1638 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
1639
1640         [Curl] Add Server Trust Evaluation Support.
1641         https://bugs.webkit.org/show_bug.cgi?id=191646
1642
1643         Reviewed by Fujii Hironori.
1644
1645         Implemented MiniBrowser UI for asking if user trusts the server.
1646
1647         * MiniBrowser/win/Common.cpp:
1648         (askServerTrustEvaluation):
1649         (replaceString):
1650         * MiniBrowser/win/Common.h:
1651         * MiniBrowser/win/MiniBrowserLib.rc:
1652         * MiniBrowser/win/MiniBrowserLibResource.h:
1653         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1654         (createPEMString):
1655         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1656         (WebKitBrowserWindow::canTrustServerCertificate):
1657         * MiniBrowser/win/WebKitBrowserWindow.h:
1658
1659 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
1660
1661         Implement ResizeObserver.
1662         https://bugs.webkit.org/show_bug.cgi?id=157743
1663
1664         Reviewed by Simon Fraser.
1665
1666         Support resizeObserverEnabled webPreferences.
1667
1668         * DumpRenderTree/TestOptions.cpp:
1669         (TestOptions::TestOptions):
1670         * DumpRenderTree/TestOptions.h:
1671         * DumpRenderTree/mac/DumpRenderTree.mm:
1672         (setWebPreferencesForTestOptions):
1673         * DumpRenderTree/win/DumpRenderTree.cpp:
1674         (enableExperimentalFeatures):
1675         * Scripts/webkitperl/FeatureList.pm:
1676         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1677
1678 2019-03-28  John Wilander  <wilander@apple.com>
1679
1680         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
1681         https://bugs.webkit.org/show_bug.cgi?id=196281
1682         <rdar://problem/48938748>
1683
1684         Reviewed by Alex Christensen.
1685
1686         This patch adds the function isStatisticsHasLocalStorage() to the
1687         TestRunner. With it, the page can query the WebsiteDataStore in the
1688         UI process to make sure that it sees LocalStorage.
1689
1690         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1691         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1692         (WTR::TestRunner::isStatisticsHasLocalStorage):
1693         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1694         * WebKitTestRunner/TestController.cpp:
1695         (WTR::TestController::isStatisticsHasLocalStorage):
1696         * WebKitTestRunner/TestController.h:
1697         * WebKitTestRunner/TestInvocation.cpp:
1698         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1699
1700 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
1701
1702         API::Data::createWithoutCopying should do a null check before calling CFRelease
1703         https://bugs.webkit.org/show_bug.cgi?id=196276
1704         <rdar://problem/48059859>
1705
1706         Reviewed by Alex Christensen.
1707
1708         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
1709
1710         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1711         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
1712         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
1713         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
1714         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1715         (TestWebKitAPI::TEST):
1716
1717 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1718
1719         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
1720         https://bugs.webkit.org/show_bug.cgi?id=186276
1721
1722         Reviewed by Carlos Garcia Campos.
1723
1724         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1725         (webViewLoadChanged):
1726         (testWebResourceGetDataError):
1727         (testWebResourceGetDataEmpty):
1728         (beforeAll):
1729         (webViewloadChanged): Deleted.
1730
1731 2019-03-27  Andy Estes  <aestes@apple.com>
1732
1733         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
1734         https://bugs.webkit.org/show_bug.cgi?id=196317
1735
1736         Reviewed by Dan Bernstein.
1737
1738         package-root copies built products into a staging directory using ditto(1), which does not
1739         follow symbolic links as it traverses a directory. Now that the files in
1740         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
1741         itself, these become broken links when ditto'd into the staging directory.
1742
1743         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
1744
1745         * Scripts/package-root:
1746
1747 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
1748
1749         [ews-app] Update display text of Submit for ews analysis
1750         https://bugs.webkit.org/show_bug.cgi?id=196309
1751
1752         Reviewed by Dewei Zhu.
1753
1754         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1755
1756 2019-03-27  David Kilzer  <ddkilzer@apple.com>
1757
1758         run-webkit-tests should check for leaks in WebKit processes
1759         <https://webkit.org/b/193772>
1760         <rdar://problem/46526680>
1761
1762         Reviewed by Ryosuke Niwa.
1763
1764         This works by doing the following:
1765         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
1766           The list of child processes are returned one per line:
1767           process.name: pid
1768         - Run the "#LIST CHILD PROCESSES" command just before the
1769           "#CHECK FOR WORLD LEAKS" command, and store the list of child
1770           processes on the ServerProcess object.
1771         - When the `--leaks` switch is handled, run check_for_leaks() on
1772           each child process after the main test harness.
1773
1774         * DumpRenderTree/mac/DumpRenderTree.mm:
1775         (handleControlCommand):
1776         - Use strncmp() instead of strcmp().
1777         - Add support for handling "#LIST CHILD PROCESSES" command.
1778
1779         * Scripts/webkitpy/port/base.py:
1780         (Port.check_for_leaks):
1781         * Scripts/webkitpy/port/darwin.py:
1782         (DarwinPort.check_for_leaks):
1783         - Rename redundant 'process_pid' argument to 'process_id'.
1784
1785         * Scripts/webkitpy/port/driver.py:
1786         (Driver.do_post_tests_work):
1787         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
1788           longer the only command this sends to WebKitTestRunner.
1789         - If the `--leaks` switch is present, send the
1790           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
1791           result using Port.set_webkit_processes().
1792         (Driver._parse_child_processes_output):
1793         - Add helper method to parse list of child process names and
1794           process IDs returned from WebKitTestRunner.
1795
1796         * Scripts/webkitpy/port/ios_device.py:
1797         (IOSDevicePort.check_for_leaks):
1798         - Rename redundant 'process_pid' argument to 'process_id'.
1799
1800         * Scripts/webkitpy/port/leakdetector.py:
1801         (LeakDetector._parse_leaks_output):
1802         - Return early if there is no leaks_output.
1803         (LeakDetector.check_for_leaks):
1804         - Rename redundant 'process_pid' argument to 'process_id'.
1805
1806         * Scripts/webkitpy/port/server_process.py:
1807         (ServerProcess.__init__):
1808         (ServerProcess.child_processes):
1809         (ServerProcess.set_child_processes):
1810         - Add instance variable to Port to store list of child process
1811           names and process IDs returned from WebKitTestRunner.
1812         (ServerProcess._start):
1813         - Clear self._child_processes.
1814         (ServerProcess.stop):
1815         - If self._child_processes is set, call
1816           self._port.check_for_leaks() for each child process.
1817
1818         * Scripts/webkitpy/port/server_process_unittest.py:
1819         (TrivialMockPort.check_for_leaks):
1820         - Rename redundant 'process_pid' argument to 'process_id'.
1821
1822         * Scripts/webkitpy/port/simulator_process.py:
1823         (SimulatorProcess.stop):
1824         - If self._child_processes is set, call
1825           self._port.check_for_leaks() for each child process.
1826
1827         * Scripts/webkitpy/port/watch_device.py:
1828         (WatchDevicePort.check_for_leaks):
1829         - Rename redundant 'process_pid' argument to 'process_id'.
1830
1831         * WebKitTestRunner/TestController.cpp:
1832         (WTR::TestController::dumpResponse):
1833         - Extract method from findAndDumpWorldLeaks() so that it may be
1834           reused by findAndDumpWebKitProcessIdentifiers().
1835         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1836         - Add method to output process name and process ID of both the
1837           WebContent and Networking processes.
1838         (WTR::TestController::findAndDumpWorldLeaks):
1839         - Fix missing newline in output when there were no abandoned
1840           documents.
1841         - Call dumpResponse() for extracted code.
1842         (WTR::TestController::handleControlCommand):
1843         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
1844         - Use strncmp() instead of strcmp().
1845         - Call findAndDumpWebKitProcessIdentifiers() when
1846           "#LIST CHILD PROCESSES" command is sent.
1847         * WebKitTestRunner/TestController.h:
1848         (WTR::TestController::dumpResponse):
1849         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
1850         - Declare methods.
1851
1852 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1853
1854         Unreviewed. Add GLib API test cases after r243434.
1855
1856         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1857         (testWebViewActiveURI):
1858         (serverCallback):
1859         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1860         (sendRequestCallback):
1861
1862 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1863
1864         Geolocation request not complete when watch request was started in a different web process
1865         https://bugs.webkit.org/show_bug.cgi?id=195996
1866
1867         Reviewed by Alex Christensen.
1868
1869         Add a test case.
1870
1871         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1872         (TestWebKitAPI::runJavaScriptAlert):
1873         (TestWebKitAPI::TEST):
1874
1875 2019-03-26  Keith Rollin  <krollin@apple.com>
1876
1877         Update the way generate-xcfilelists returns strings from functions
1878         https://bugs.webkit.org/show_bug.cgi?id=195975
1879         <rdar://problem/49040807>
1880
1881         Reviewed by Dean Jackson.
1882
1883         There are places where generate-xcfilelists executes assignments with
1884         statements like:
1885
1886             FOO=$(some_function)
1887
1888         where "some_function" return a string by echoing it. E.g.
1889
1890             some_function()
1891             {
1892                 echo "Hello, World"
1893             }
1894
1895         This is a common idiom, but it has a problem if "some_function" needs
1896         to call "exit" in an attempt to halt the entire script right then and
1897         there. Since "some_function" is called inside of $(), it's being
1898         executed in a sub-shell. Calling exit in that sub-shell simply exits
1899         that shell; it doesn't not exit the outer shell in which the main part
1900         of the script is still running. As such, the main script keeps
1901         executing when the intent was for the script to halt.
1902
1903         The solution to this is to use a different idiom for returning
1904         strings. The one we now is to pass in the name of the variable to
1905         receive the string result:
1906
1907             some_function()
1908             {
1909                 variable_name=$1
1910                 eval $variable_name ="Hello, World"
1911             }
1912
1913         The call site now looks like
1914
1915             some_function FOO
1916
1917         Because there's no invocation of a sub-shell, some_function can now
1918         call "exit" if it wants to, and the entire script will exit at that
1919         point.
1920
1921         * Scripts/generate-xcfilelists:
1922
1923 2019-03-26  Chris Dumez  <cdumez@apple.com>
1924
1925         Add basic layout test coverage for File Picker on iOS
1926         https://bugs.webkit.org/show_bug.cgi?id=196265
1927
1928         Reviewed by Wenson Hsieh.
1929
1930         Add layout test infrastructure to test the file picker on iOS.
1931
1932         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1933         (WTR::UIScriptController::dismissFilePicker):
1934         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1935         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1936         (WTR::UIScriptController::dismissFilePicker):
1937         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1938         * WebKitTestRunner/TestController.cpp:
1939         (WTR::TestController::createWebViewWithOptions):
1940         (WTR::updateTestOptionsFromTestHeader):
1941         * WebKitTestRunner/TestOptions.h:
1942         (WTR::TestOptions::hasSameInitializationOptions const):
1943         * WebKitTestRunner/ios/TestControllerIOS.mm:
1944         (overridePresentViewController):
1945         (WTR::TestController::platformInitialize):
1946         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1947         (WTR::UIScriptController::dismissFilePicker):
1948
1949 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1950
1951         Implement async paste method on UIWKInteractionViewProtocol
1952         https://bugs.webkit.org/show_bug.cgi?id=196267
1953         <rdar://problem/49236346>
1954
1955         Reviewed by Tim Horton.
1956
1957         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
1958         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
1959         are now a part of all iOS 12 internal SDKs.
1960
1961         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1962
1963         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
1964         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
1965
1966         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1967         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1968         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
1969         * TestWebKitAPI/ios/UIKitSPI.h:
1970
1971 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1972
1973         [ews-build] Use PostgreSQL for ews.webkit.org database
1974         https://bugs.webkit.org/show_bug.cgi?id=196270
1975
1976         Reviewed by Lucas Forschler.
1977
1978         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1979
1980 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
1981
1982         [ews] Reset simctl states on reboot
1983         https://bugs.webkit.org/show_bug.cgi?id=196260
1984
1985         Rubber-stamped by Aakash Jain.
1986
1987         * EWSTools/start-queue-mac.sh:
1988
1989 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1990
1991         [ews-build] Use PostgreSQL for ews-build database
1992         https://bugs.webkit.org/show_bug.cgi?id=196229
1993
1994         Reviewed by Lucas Forschler.
1995
1996         * BuildSlaveSupport/ews-build/master.cfg:
1997
1998 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
1999
2000         [ews-build] Get master_hostname dynamically in master.cfg
2001         https://bugs.webkit.org/show_bug.cgi?id=196255
2002
2003         Reviewed by Lucas Forschler.
2004
2005         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
2006         send events data in test mode.
2007
2008 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2009
2010         [ews-app] Set db_constraint to False for Foreign Keys
2011         https://bugs.webkit.org/show_bug.cgi?id=196252
2012
2013         Reviewed by Lucas Forschler.
2014
2015         * BuildSlaveSupport/ews-app/ews/models/build.py:
2016         * BuildSlaveSupport/ews-app/ews/models/step.py:
2017
2018 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2019
2020         [ews-build] is_test_mode_enabled should default to True
2021         https://bugs.webkit.org/show_bug.cgi?id=196248
2022
2023         Reviewed by Lucas Forschler.
2024
2025         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
2026
2027 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
2028
2029         [ews-app] Add webkitperl to ENABLED_QUEUES
2030         https://bugs.webkit.org/show_bug.cgi?id=196253
2031
2032         Reviewed by Lucas Forschler.
2033
2034         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2035
2036 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
2037
2038         Address NSWindow sometimes using WebKitTestRunnerEvent too early
2039         https://bugs.webkit.org/show_bug.cgi?id=196211
2040         rdar://problem/49110552
2041
2042         Reviewed by Tim Horton.
2043
2044         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
2045         Make sure that EventSenderProxy always exists when running tests. We used to create
2046         it when resetting before the first test, which is a bit too late.
2047
2048         * WebKitTestRunner/TestController.h:
2049         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2050         (WTR::TestController::platformCreateWebView):
2051         (WTR::TestController::platformCreateOtherPage):
2052         (WTR::TestController::finishCreatingPlatformWebView):
2053         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2054         (WTR::PlatformWebView::PlatformWebView):
2055         Moved some code that made NSWindow use NSEvent during web view creation. We may
2056         need to move more if some other case us found, but this is enough for now.
2057
2058 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2059
2060         Unreviewed. Fix typo in GLib geolocation API after r243285.
2061
2062         gelocation -> geolocation.
2063
2064         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
2065         (testGeolocationManagerWatchPosition):
2066
2067 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2068
2069         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2070         https://bugs.webkit.org/show_bug.cgi?id=196213
2071
2072         Reviewed by Geoff Garen.
2073
2074         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2075         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2076         (credentialWithIdentityAndKeychainPath):
2077         (-[ChallengeDelegate webView:didFinishNavigation:]):
2078         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2079         (TestWebKitAPI::TEST):
2080
2081 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2082
2083         Expected shouldn't assume its contained types are copyable
2084         https://bugs.webkit.org/show_bug.cgi?id=195986
2085
2086         Reviewed by JF Bastien.
2087
2088         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2089         (TestWebKitAPI::NonCopyable::operator== const):
2090         (TestWebKitAPI::NonCopyable::operator!= const):
2091         (TestWebKitAPI::TEST):
2092
2093 2019-03-25  Tim Horton  <timothy_horton@apple.com>
2094
2095         Remove some now-unnecessary dynamic class lookup
2096         https://bugs.webkit.org/show_bug.cgi?id=196237
2097
2098         Reviewed by Simon Fraser.
2099
2100         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2101         (makeRequest):
2102         (TEST):
2103
2104 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
2105
2106         Unreviewed, rolling out r243450.
2107
2108         AppleWin and WinCairo port builds get broken.
2109
2110         Reverted changeset:
2111
2112         "Add test for fix of #196095"
2113         https://bugs.webkit.org/show_bug.cgi?id=196097
2114         https://trac.webkit.org/changeset/243450
2115
2116 2019-03-25  Commit Queue  <commit-queue@webkit.org>
2117
2118         Unreviewed, rolling out r243465.
2119         https://bugs.webkit.org/show_bug.cgi?id=196226
2120
2121         the test doesn't build (Requested by thorton on #webkit).
2122
2123         Reverted changeset:
2124
2125         "Do not terminate the NetworkProcess if a third party
2126         application sends a NSCredential with a SecIdentityRef"
2127         https://bugs.webkit.org/show_bug.cgi?id=196213
2128         https://trac.webkit.org/changeset/243465
2129
2130 2019-03-25  Alex Christensen  <achristensen@webkit.org>
2131
2132         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
2133         https://bugs.webkit.org/show_bug.cgi?id=196213
2134
2135         Reviewed by Geoff Garen.
2136
2137         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2138         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
2139         (credentialWithIdentityAndKeychainPath):
2140         (-[ChallengeDelegate webView:didFinishNavigation:]):
2141         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2142         (TestWebKitAPI::TEST):
2143
2144 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2145
2146         [ews-build] Gracefully handle missing patch_id in events
2147         https://bugs.webkit.org/show_bug.cgi?id=196216
2148
2149         Reviewed by Lucas Forschler.
2150
2151         * BuildSlaveSupport/ews-build/events.py:
2152
2153 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
2154
2155         [ews-build] use lz4 compression for improving buildbot performance
2156         https://bugs.webkit.org/show_bug.cgi?id=196155
2157
2158         Reviewed by Lucas Forschler.
2159
2160         * BuildSlaveSupport/ews-build/master.cfg:
2161
2162 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2163
2164         Pull some API testing helper methods out of TestWKWebView
2165         https://bugs.webkit.org/show_bug.cgi?id=196212
2166
2167         Reviewed by Tim Horton.
2168
2169         Refactor some more API testing utility methods, so that they can be used in
2170         tests that do not use TestWKWebView.
2171
2172         * TestWebKitAPI/cocoa/TestWKWebView.h:
2173         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2174         (-[WKWebView loadTestPageNamed:]):
2175         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
2176         (-[WKWebView synchronouslyLoadHTMLString:]):
2177         (-[WKWebView synchronouslyLoadTestPageNamed:]):
2178         (-[TestWKWebView loadTestPageNamed:]): Deleted.
2179         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
2180         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
2181         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
2182
2183 2019-03-25  Jer Noble  <jer.noble@apple.com>
2184
2185         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2186         https://bugs.webkit.org/show_bug.cgi?id=196097
2187
2188         Reviewed by Eric Carlson.
2189
2190         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2191
2192         * DumpRenderTree/mac/DumpRenderTree.mm:
2193         (resetWebPreferencesToConsistentValues):
2194         * WebKitTestRunner/TestController.cpp:
2195         (WTR::TestController::resetPreferencesToConsistentValues):
2196
2197 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2198
2199         Pull IPadUserInterfaceSwizzler out into a separate header file
2200         https://bugs.webkit.org/show_bug.cgi?id=196193
2201
2202         Reviewed by Anders Carlsson.
2203
2204         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
2205         be used in other API tests.
2206
2207         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2208         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2209         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
2210         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
2211         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
2212         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
2213         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
2214
2215 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2216
2217         Remove NavigatorContentUtils in WebCore/Modules
2218         https://bugs.webkit.org/show_bug.cgi?id=196070
2219
2220         Reviewed by Alex Christensen.
2221
2222         NavigatorContentUtils was to support the custom scheme spec [1].
2223         However, in WebKit side, no port has supported the feature in
2224         WebKit layer after EFL port was removed. So there has been the
2225         only IDL implementation of the NavigatorContentUtils in WebCore.
2226         So we don't need to keep the implementation in WebCore anymore.
2227
2228         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
2229
2230         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2231
2232 2019-03-24  Andy Estes  <aestes@apple.com>
2233
2234         [watchOS] Remove unused Proximity Networking code
2235         https://bugs.webkit.org/show_bug.cgi?id=196188
2236
2237         Reviewed by Tim Horton.
2238
2239         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2240         (TEST):
2241
2242 2019-03-23  Keith Miller  <keith_miller@apple.com>
2243
2244         Refactor clz/ctz and fix getLSBSet.
2245         https://bugs.webkit.org/show_bug.cgi?id=196162
2246
2247         Reviewed by Saam Barati.
2248
2249         Add tests for clz, ctz, getLSBSet, and getMSBSet.
2250
2251         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2252         (TestWebKitAPI::TEST):
2253
2254 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2255
2256         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
2257         https://bugs.webkit.org/show_bug.cgi?id=196143
2258
2259         Reviewed by Michael Catanzaro.
2260
2261         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
2262         directories.
2263
2264         * Scripts/webkitpy/style/checkers/cpp.py:
2265         (check_identifier_name_in_declaration):
2266         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2267         (WebKitStyleTest.test_names):
2268
2269 2019-03-22  Philippe Normand  <pnormand@igalia.com>
2270
2271         [Flatpak] Manifest expanding fails for qt WPE extension
2272         https://bugs.webkit.org/show_bug.cgi?id=196148
2273
2274         Reviewed by Alex Christensen.
2275
2276         * flatpak/flatpakutils.py:
2277         (expand_submodules_recurse): The last recurse manifest expand
2278         iteration might lead to a single module so take it into account
2279         and don't try to recurse further.
2280
2281 2019-03-22  Chris Dumez  <cdumez@apple.com>
2282
2283         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
2284         https://bugs.webkit.org/show_bug.cgi?id=195348
2285         <rdar://problem/48622090>
2286
2287         Reviewed by Alex Christensen.
2288
2289         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
2290         to NO when test.options().shouldIgnoreMetaViewport is false.
2291
2292         * WebKitTestRunner/ios/TestControllerIOS.mm:
2293         (WTR::TestController::platformConfigureViewForTest):
2294
2295 2019-03-22  Chris Dumez  <cdumez@apple.com>
2296
2297         Prewarmed processes should be usable with any website data store
2298         https://bugs.webkit.org/show_bug.cgi?id=196104
2299
2300         Reviewed by Alex Christensen.
2301
2302         Add API test coverage.
2303
2304         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2305         (runInitialWarmedProcessUsedTest):
2306         (TEST):
2307
2308 2019-03-22  David Kilzer  <ddkilzer@apple.com>
2309
2310         Back out local changes to Alex's Subversion working directory
2311
2312         They were accidentally committed.
2313
2314         * Scripts/webkitpy/common/system/abstractexecutive.py:
2315         (AbstractExecutive.wait_newest):
2316         * Scripts/webkitpy/common/system/executive.py:
2317         (Executive.running_pids):
2318         * Scripts/webkitpy/common/system/executive_mock.py:
2319         (MockExecutive.running_pids):
2320         * Scripts/webkitpy/common/system/executive_unittest.py:
2321         (ExecutiveTest.serial_test_running_pids):
2322         * Scripts/webkitpy/port/darwin.py:
2323         (DarwinPort.check_for_leaks):
2324         * Scripts/webkitpy/port/leakdetector.py:
2325         (LeakDetector.check_for_leaks):
2326         - This was the hack attached to Bug 193772.
2327
2328         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
2329         (+[WebKitTestRunnerEvent mouseLocation]):
2330         - This works around a crash on an internal build.
2331
2332 2019-03-22  Tim Horton  <timothy_horton@apple.com>
2333
2334         Fix the build after r243354
2335         https://bugs.webkit.org/show_bug.cgi?id=196138
2336         <rdar://problem/49145951>
2337
2338         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2339         (TEST):
2340         * TestWebKitAPI/ios/UIKitSPI.h:
2341
2342 2019-03-21  Tim Horton  <timothy_horton@apple.com>
2343
2344         Adopt UIWKDocumentContext
2345         https://bugs.webkit.org/show_bug.cgi?id=196040
2346         <rdar://problem/48642440>
2347
2348         Reviewed by Ryosuke Niwa.
2349
2350         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2351         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
2352         (makeRequest):
2353         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
2354         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
2355         (applyStyle):
2356         (TEST):
2357         Add tests for UIWKDocumentContext.
2358
2359         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
2360         (TEST):
2361         (recursiveFindWKContentView): Deleted.
2362         * TestWebKitAPI/cocoa/TestWKWebView.h:
2363         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2364         (recursiveFindWKContentView):
2365         (-[TestWKWebView wkContentView]):
2366         * TestWebKitAPI/ios/UIKitSPI.h:
2367         Share the WKContentView finding code between tests.
2368
2369 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
2370
2371         [iOS WK2] Turn on async overflow scrolling by default
2372         https://bugs.webkit.org/show_bug.cgi?id=196011
2373         rdar://problem/48453859
2374
2375         Reviewed by Antti Koivisto.
2376         
2377         Explicitly turn off the async overflow scrolling internal feature for tests by default,
2378         since so many basic layout tests have different results when compositing is triggered for
2379         overflow.
2380         
2381         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
2382
2383         * WebKitTestRunner/TestController.cpp:
2384         (WTR::TestController::resetPreferencesToConsistentValues):
2385
2386 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2387
2388         [ews-build] Retry API test in case of failures
2389         https://bugs.webkit.org/show_bug.cgi?id=196004
2390
2391         Reviewed by Lucas Forschler.
2392
2393         * BuildSlaveSupport/ews-build/steps.py:
2394         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
2395         (CompileWebKitToT.doStepIf): Ditto.
2396         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
2397         (ReRunAPITests): Re-run API tests.
2398         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
2399         (RunAPITestsWithoutPatch): Run API tests without patch.
2400         (RunAPITestsWithoutPatch.doStepIf):
2401         (RunAPITestsWithoutPatch.hideStepIf):
2402         (RunAPITestsWithoutPatch.evaluateCommand):
2403         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
2404         (AnalyzeAPITestsResults.start):
2405         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
2406         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
2407         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
2408         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
2409
2410 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2411
2412         [ews-build] Update queues configurations
2413         https://bugs.webkit.org/show_bug.cgi?id=196074
2414
2415         Reviewed by Dewei Zhu.
2416
2417         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
2418         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
2419
2420 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
2421
2422         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
2423         https://bugs.webkit.org/show_bug.cgi?id=195680
2424         <rdar://problem/48903534>
2425
2426         Unreviewed infrastructure fix.
2427
2428         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2429         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
2430
2431 2019-03-21  Andy Estes  <aestes@apple.com>
2432
2433         [iOS] Apple Pay should be available in documents with no user agent scripts
2434         https://bugs.webkit.org/show_bug.cgi?id=196061
2435         <rdar://problem/48649391>
2436
2437         Reviewed by Brady Eidson.
2438
2439         Added API tests and related infrastructure.
2440
2441         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2442         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
2443         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
2444         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2445         (TestWebKitAPI::TEST):
2446         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
2447         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
2448         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
2449         * TestWebKitAPI/cocoa/TestProtocol.mm:
2450         (-[TestProtocol startLoading]):
2451         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
2452         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
2453         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
2454         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
2455
2456 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
2457
2458         REGRESSSION (r243297): webkitpy tests broken
2459         https://bugs.webkit.org/show_bug.cgi?id=196108
2460
2461         Reviewed by Aakash Jain.
2462
2463         r243297 updated contributors.json, which broke a few unit tests.
2464
2465         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2466         (IRCCommandTest.test_whois):
2467         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2468
2469 2019-03-21  Chris Dumez  <cdumez@apple.com>
2470
2471         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
2472         https://bugs.webkit.org/show_bug.cgi?id=196041
2473         <rdar://problem/49083230>
2474
2475         Reviewed by Alex Christensen.
2476
2477         Add API test coverage.
2478
2479         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
2480         (TEST):
2481
2482 2019-03-21  Alex Christensen  <achristensen@webkit.org>
2483
2484         Add SPI to inform applications of WKContentRuleList actions
2485         https://bugs.webkit.org/show_bug.cgi?id=195965
2486         <rdar://problem/42664365>
2487
2488         Reviewed by Geoff Garen.
2489
2490         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2491         (TestWebKitAPI::allActionsForResourceLoad):
2492         (TestWebKitAPI::testRequest):
2493         (TestWebKitAPI::TEST_F):
2494         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
2495         (Notification::description):
2496         (Notification::operator== const):
2497         (toVector):
2498         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
2499         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
2500         (makeContentRuleList):
2501         (TEST):
2502         (makeWarnContentRuleList): Deleted.
2503
2504 2019-03-21  Timothy Hatcher  <timothy@apple.com>
2505
2506         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
2507         https://bugs.webkit.org/show_bug.cgi?id=196088
2508
2509         Reviewed by Brian Burg.
2510
2511         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
2512         Support checks when only one platform is specified. Also deprecate macosx() and
2513         force the use of macos() instead.
2514
2515         * Scripts/webkitpy/style/checkers/cpp.py:
2516         (check_min_versions_of_wk_api_available):
2517         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2518         (WebKitStyleTest.test_min_versions_of_wk_api_available):
2519
2520 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
2521
2522         Update status inactive committers' status to 'contributor'.
2523
2524         * Scripts/webkitpy/common/config/contributors.json:
2525
2526 2019-03-21  Xan Lopez  <xan@igalia.com>
2527
2528         [JSC][x86] Drop support for x87 floating point
2529         https://bugs.webkit.org/show_bug.cgi?id=194853
2530
2531         Reviewed by Don Olmstead.
2532
2533         Force SSE2 on x86/32bit builds.
2534
2535         * Scripts/webkitdirs.pm:
2536         (generateBuildSystemFromCMakeProject):
2537
2538 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2539
2540         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
2541         https://bugs.webkit.org/show_bug.cgi?id=196073
2542
2543         Reviewed by Michael Catanzaro.
2544
2545         Add test cases to check functions and constructors with no arguments but receiving user data.
2546
2547         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2548         (checkUserData):
2549         (testJSCFunction):
2550         (fooCreateWithUserData):
2551         (testJSCClass):
2552
2553 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2554
2555         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
2556
2557         Add g_assert_cmpfloat_with_epsilon macro if not defined.
2558
2559         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
2560
2561 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2562
2563         [GTK][WPE] Add API to provide geolocation information
2564         https://bugs.webkit.org/show_bug.cgi?id=195940
2565
2566         Reviewed by Michael Catanzaro.
2567
2568         Add a new test to check the new API.
2569
2570         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
2571         (testGeolocationManagerCurrentPosition):
2572         (testGeolocationManagerWatchPosition):
2573         (beforeAll):
2574         (afterAll):
2575         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2576         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
2577         (beforeAll): Ditto.
2578         * TestWebKitAPI/glib/CMakeLists.txt:
2579
2580 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2581
2582         [GLib] Returning G_TYPE_OBJECT from a method does not work
2583         https://bugs.webkit.org/show_bug.cgi?id=195574
2584
2585         Reviewed by Michael Catanzaro.
2586
2587         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
2588
2589         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2590         (getGFile):
2591         (getParent):
2592         (createGString):
2593         (getGString):
2594         (getGStringCopyWillRaise):
2595         (getGStringCopy):
2596         (getGStringStr):
2597         (getGStringLen):
2598         (freeGString):
2599         (testJSCClass):
2600
2601 2019-03-20  Saam Barati  <sbarati@apple.com>
2602
2603         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
2604         https://bugs.webkit.org/show_bug.cgi?id=195721
2605
2606         Reviewed by Filip Pizlo.
2607
2608         * Scripts/run-javascriptcore-tests:
2609
2610 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
2611
2612         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
2613         https://bugs.webkit.org/show_bug.cgi?id=196049
2614
2615         Reviewed by Tim Horton.
2616
2617         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
2618         overflow scrolling in general, so rename it.
2619
2620         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2621
2622 2019-03-20  Daniel Bates  <dabates@apple.com>
2623
2624         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
2625         https://bugs.webkit.org/show_bug.cgi?id=196031
2626         <rdar://problem/49078172>
2627
2628         Reviewed by Tim Horton.
2629
2630         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
2631         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
2632         same code path used when the Done button is pressed to dismiss the <select> picker.
2633
2634         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2635         (TestWebKitAPI::TEST):
2636
2637 2019-03-20  Chris Dumez  <cdumez@apple.com>
2638
2639         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
2640         https://bugs.webkit.org/show_bug.cgi?id=196029
2641         <rdar://problem/48954651>
2642
2643         Reviewed by Tim Horton.
2644
2645         Add API test coverage.
2646
2647         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2648
2649 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
2650
2651         [ews-build] Improve failure summary string for ApplyPatch step
2652         https://bugs.webkit.org/show_bug.cgi?id=195995
2653
2654         Reviewed by Alexey Proskuryakov.
2655
2656         * BuildSlaveSupport/ews-build/steps.py:
2657         (ApplyPatch.getResultSummary): Override getResultSummary.
2658
2659 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
2660
2661         AX: Implement support for new meter ARIA role
2662         https://bugs.webkit.org/show_bug.cgi?id=195966
2663
2664         Reviewed by Chris Fleizach.
2665
2666         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
2667         to AXLevelIndicator.
2668
2669         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2670
2671 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
2672
2673         [WebAuthN] Implement FIDO AppID extension
2674         https://bugs.webkit.org/show_bug.cgi?id=143491
2675         <rdar://problem/48298273>
2676
2677         Reviewed by Brent Fulgham.
2678
2679         Add a test that covers the new flag of convertToU2fSignCommand.
2680
2681         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
2682         (TestWebKitAPI::TEST):
2683         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
2684         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
2685         (TestWebKitAPI::TEST):
2686
2687 2019-03-19  Keith Rollin  <krollin@apple.com>
2688
2689         Add support for more platforms to generate-xcfilelists
2690         https://bugs.webkit.org/show_bug.cgi?id=195977
2691
2692         Reviewed by Alexey Proskuryakov.
2693
2694         generate-xcfilelists incorrectly complains when involved with building
2695         WebKit for iphonesimulator:
2696
2697             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
2698             …
2699             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
2700
2701         Address this by teaching generate-xcfilelists about more platforms.
2702
2703         * Scripts/generate-xcfilelists:
2704
2705 2019-03-19  John Wilander  <wilander@apple.com>
2706
2707         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
2708         https://bugs.webkit.org/show_bug.cgi?id=195923
2709         <rdar://problem/49001272>
2710
2711         Reviewed by Alex Christensen.
2712
2713         This patch does the following to the TestRunner:
2714         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
2715         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
2716         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
2717
2718         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2719         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2720         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
2721         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2722         * WebKitTestRunner/TestController.cpp:
2723         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2724         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2725         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2726         * WebKitTestRunner/TestController.h:
2727         * WebKitTestRunner/TestInvocation.cpp:
2728         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2729
2730 2019-03-19  Christopher Reid  <chris.reid@sony.com>
2731
2732         [CMake] Support more clang and gcc sanitizers
2733         https://bugs.webkit.org/show_bug.cgi?id=195956
2734
2735         Reviewed by Michael Catanzaro.
2736
2737         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
2738
2739 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2740
2741         [ews-build] Improve summary for PrintConfiguration step
2742         https://bugs.webkit.org/show_bug.cgi?id=195945
2743
2744         Reviewed by Lucas Forschler.
2745
2746         * BuildSlaveSupport/ews-build/steps.py:
2747         (PrintConfiguration.getResultSummary): Override getResultSummary.
2748
2749 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
2750
2751         [ews-build] Improve summary for CheckOutSource step
2752         https://bugs.webkit.org/show_bug.cgi?id=195963
2753
2754         Reviewed by Lucas Forschler.
2755
2756         * BuildSlaveSupport/ews-build/steps.py:
2757         (CheckOutSource.getResultSummary):
2758
2759 2019-03-19  Daniel Bates  <dabates@apple.com>
2760
2761         [iOS] Focus not preserved when switching between tabs
2762         https://bugs.webkit.org/show_bug.cgi?id=195820
2763         <rdar://problem/43614450>
2764
2765         Reviewed by Brent Fulgham.
2766
2767         Add tests to ensure that we restore focus when resigning and becoming first responder.
2768
2769         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2770         (TestWebKitAPI::TEST):
2771
2772 2019-03-19  Alex Christensen  <achristensen@webkit.org>
2773
2774         Make WTFLogChannelState and WTFLogLevel enum classes
2775         https://bugs.webkit.org/show_bug.cgi?id=195904
2776
2777         Reviewed by Eric Carlson.
2778
2779         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2780         (TestWebKitAPI::TEST_F):
2781
2782 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2783
2784         [GStreamer][EME] Backported mssdemux protection data crash fix
2785         https://bugs.webkit.org/show_bug.cgi?id=195918
2786
2787         Reviewed by Philippe Normand.
2788
2789         * gstreamer/jhbuild.modules:
2790         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
2791
2792 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2793
2794         Unreviewed, rolling out r243132.
2795
2796         Broke GTK build
2797
2798         Reverted changeset:
2799
2800         "Make WTFLogChannelState and WTFLogLevel enum classes"
2801         https://bugs.webkit.org/show_bug.cgi?id=195904
2802         https://trac.webkit.org/changeset/243132
2803
2804 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
2805
2806         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
2807
2808         * Scripts/webkitdirs.pm:
2809         (builtDylibPathForName): Adjust the shared library name that's changed
2810         with the API version bump in r243073.
2811
2812 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2813
2814         Make WTFLogChannelState and WTFLogLevel enum classes
2815         https://bugs.webkit.org/show_bug.cgi?id=195904
2816
2817         Reviewed by Eric Carlson.
2818
2819         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2820         (TestWebKitAPI::TEST_F):
2821
2822 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2823
2824         Disable flaky test added in r2431100
2825         https://webkit.org/b/195785
2826
2827         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2828         (TestWebKitAPI::TEST):
2829         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
2830
2831 2019-03-18  Timothy Hatcher  <timothy@apple.com>
2832
2833         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
2834         https://bugs.webkit.org/show_bug.cgi?id=195916
2835
2836         Reviewed by Tim Horton.
2837
2838         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
2839         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
2840
2841 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
2842
2843         Add a secondary e-mail address for Fujii Hironori to make tools happier.
2844
2845         * Scripts/webkitpy/common/config/contributors.json:
2846
2847 2019-03-18  Alex Christensen  <achristensen@webkit.org>
2848
2849         Implement DownloadMonitor to prevent long-running slow downloads from background apps
2850         https://bugs.webkit.org/show_bug.cgi?id=195785
2851
2852         Reviewed by Geoffrey Garen.
2853
2854         * TestWebKitAPI/TCPServer.cpp: Added.
2855         (TestWebKitAPI::TCPServer::TCPServer):
2856         (TestWebKitAPI::TCPServer::~TCPServer):
2857         (TestWebKitAPI::TCPServer::socketBindListen):
2858         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
2859         * TestWebKitAPI/TCPServer.h: Added.
2860         (TestWebKitAPI::TCPServer::port const):
2861         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2862         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2863         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
2864         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
2865         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
2866         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
2867         (TestWebKitAPI::respondSlowly):
2868         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
2869         (TestWebKitAPI::downloadAtRate):
2870         (TestWebKitAPI::TEST):
2871
2872 2019-03-18  Saam Barati  <sbarati@apple.com>
2873
2874         Add a plan file for JetStream 2
2875         https://bugs.webkit.org/show_bug.cgi?id=190734
2876
2877         Reviewed by Mark Lam.
2878
2879         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
2880
2881 2019-03-18  Chris Dumez  <cdumez@apple.com>
2882
2883         Delay WebProcess launch until a load is triggered in a Web view
2884         https://bugs.webkit.org/show_bug.cgi?id=195758
2885         <rdar://problem/48126013>
2886
2887         Reviewed by Geoff Garen.
2888
2889         Add API test coverage. Also update some existing API tests to not expect
2890         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
2891
2892         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
2893         (TestWebKitAPI::TEST):
2894         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
2895         (TestWebKitAPI::TEST):
2896         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2897         (TEST):
2898         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2899         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2900         (TEST):
2901         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2902         (TEST):
2903         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
2904
2905 2019-03-18  Xan Lopez  <xan@igalia.com>
2906
2907         [CMake] Prevent potential warning when determining $architecture
2908         https://bugs.webkit.org/show_bug.cgi?id=195891
2909
2910         Reviewed by Michael Catanzaro.
2911
2912         It's possible for generateBuildSystemForCMakeProject to be called
2913         before determineArchitecture() is ever called. This will make the
2914         first eq check with $architecture to be bogus (and print a
2915         warning). Change that to an eq check with architecture(), which
2916         implicitly calls determineArchitecture() if needed, and change all
2917         the other similar cases in the method in the same way to prevent
2918         future bugs like this one.
2919
2920         * Scripts/webkitdirs.pm:
2921         (generateBuildSystemFromCMakeProject):
2922
2923 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2924
2925         [WPE] Tarballs generated with “make dist” cannot build documentation
2926         https://bugs.webkit.org/show_bug.cgi?id=195885
2927
2928         Reviewed by Carlos Garcia Campos.
2929
2930         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
2931
2932 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2933
2934         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
2935         https://bugs.webkit.org/show_bug.cgi?id=195883
2936
2937         Reviewed by Carlos Garcia Campos.
2938
2939         * gtkdoc/gtkdoc.py:
2940         (GTKDoc._run_command): When commands fail to run, include the full command line for
2941         the program invocation and the output it has generated on the standard error stream.
2942
2943 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
2944
2945         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
2946         https://bugs.webkit.org/show_bug.cgi?id=195786
2947
2948         Reviewed by Philippe Normand.
2949
2950         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
2951         * wpe/jhbuild.modules: Ditto.
2952
2953 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
2954
2955         [ews-build] Don't run clean builds on EWS builders
2956         https://bugs.webkit.org/show_bug.cgi?id=195851
2957
2958         Reviewed by Geoffrey Garen.
2959
2960         * BuildSlaveSupport/ews-build/factories.py:
2961
2962 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2963
2964         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
2965         https://bugs.webkit.org/show_bug.cgi?id=195849
2966
2967         Reviewed by Chris Dumez.
2968
2969         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
2970
2971         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2972         (runWebsiteDataStoreCustomPaths):
2973
2974 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
2975
2976         webkitpy: Upload test results
2977         https://bugs.webkit.org/show_bug.cgi?id=195755
2978         <rdar://problem/48896182>
2979
2980         Reviewed by Aakash Jain.
2981
2982         Establish a new format for uploading results that is not tied to layout tests, apply
2983         that format to webkitpy tests.
2984
2985         * Scripts/webkitpy/common/checkout/scm/git.py:
2986         (Git.native_branch): Return what branch the current checkout is on.
2987         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2988         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2989         * Scripts/webkitpy/common/checkout/scm/svn.py:
2990         (SVN.native_branch): Ditto.
2991         * Scripts/webkitpy/common/system/platforminfo.py:
2992         (PlatformInfo.build_version): Return a build version for Mac.
2993         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2994         (MockPlatformInfo.__init__):
2995         (MockPlatformInfo.build_version):
2996         * Scripts/webkitpy/results: Added.
2997         * Scripts/webkitpy/results/__init__.py: Added.
2998         * Scripts/webkitpy/results/options.py: Added.
2999         (upload_options): OptParse list for upload options.
3000         * Scripts/webkitpy/results/upload.py: Added.
3001         (Upload): Class which enforces the upload format expected by the results server.
3002         (Upload.Expectations):
3003         (Upload.create_configuration):
3004         (Upload.create_commit):
3005         (Upload.create_details):
3006         (Upload.create_run_stats):
3007         (Upload.create_test_result):
3008         (Upload.__init__):
3009         (Upload.Encoder): Encode Upload object as json.
3010         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
3011         * Scripts/webkitpy/results/upload_unittest.py: Added.
3012         * Scripts/webkitpy/test/main.py:
3013         (Tester._parse_args): Add upload arguments.
3014         (Tester._run_tests): Allow results to be uploaded.
3015         * Scripts/webkitpy/test/runner.py:
3016         (Runner.__init__): Record which tests were run, rather than just counting them.
3017         (Runner.handle):
3018         * Scripts/webkitpy/test/runner_unittest.py:
3019         (RunnerTest.test_run):
3020         * Scripts/webkitpy/thirdparty/__init__.py:
3021         (AutoinstallImportHook.find_module): Add requests auto-install.
3022         (AutoinstallImportHook._install_requests):
3023         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3024         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
3025
3026 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3027
3028         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
3029         https://bugs.webkit.org/show_bug.cgi?id=195810
3030
3031         Reviewed by Tim Horton.
3032
3033         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
3034         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
3035         ending certain layout tests.
3036
3037         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3038         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3039         (-[TestRunnerWKWebView dealloc]):
3040         (-[TestRunnerWKWebView resetInteractionCallbacks]):
3041
3042         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
3043         helper method when destroying the web view, and when resetting state between tests.
3044
3045         * WebKitTestRunner/ios/TestControllerIOS.mm:
3046         (WTR::TestController::platformResetStateToConsistentValues):
3047
3048         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
3049
3050 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
3051
3052         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
3053         https://bugs.webkit.org/show_bug.cgi?id=190350
3054         <rdar://problem/45089503>
3055
3056         Reviewed by Geoffrey Garen.
3057
3058         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3059         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
3060         (TEST):
3061         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
3062         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
3063         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
3064         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
3065         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
3066         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
3067         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
3068         (runTest):
3069         (createDirectories):
3070         (TEST):
3071         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
3072         (TEST):
3073         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
3074         (TEST):
3075
3076 2019-03-15  Timothy Hatcher  <timothy@apple.com>
3077
3078         Add support to WebPage for getting the contents as an attributed string.
3079         https://bugs.webkit.org/show_bug.cgi?id=195636
3080         rdar://problem/45055697
3081
3082         Reviewed by Tim Horton.
3083
3084         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
3085         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
3086
3087 2019-03-15  Chris Dumez  <cdumez@apple.com>
3088
3089         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3090         https://bugs.webkit.org/show_bug.cgi?id=195747
3091
3092         Reviewed by Geoff Garen.
3093
3094         Add API test coverage.
3095
3096         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3097
3098 2019-03-15  Shawn Roberts  <sroberts@apple.com>
3099
3100         Unreviewed, rolling out r242952.
3101
3102         Causing API failures on iOS Simulator
3103
3104         Reverted changeset:
3105
3106         "[PSON] Make sure the WebProcessCache is leverage when
3107         relaunching a process after termination"
3108         https://bugs.webkit.org/show_bug.cgi?id=195747
3109         https://trac.webkit.org/changeset/242952
3110
3111 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
3112
3113         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
3114         https://bugs.webkit.org/show_bug.cgi?id=195740
3115
3116         Reviewed by Ross Kirsling.
3117
3118         window.open doesn't work for WebKitBrowserWindow because it is not
3119         implemented yet.
3120
3121         1. Implemented createNewPage callback of WKPageUIClient.
3122         2. Changed MainWindow to take a BrowserWindow factory function
3123           instead of BrowserWindowType to be flexible to create
3124           BrowserWindow with extra settings.
3125         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
3126           because it is not relevant with MainWindow anymore.
3127
3128         * MiniBrowser/win/Common.cpp:
3129         (parseCommandLine):
3130         * MiniBrowser/win/Common.h:
3131         (CommandLineOptions::CommandLineOptions):
3132         * MiniBrowser/win/MainWindow.cpp:
3133         (MainWindow::MainWindow):
3134         (MainWindow::create):
3135         (MainWindow::init):
3136         (MainWindow::WndProc):
3137         * MiniBrowser/win/MainWindow.h:
3138         * MiniBrowser/win/PrintWebUIDelegate.cpp:
3139         (PrintWebUIDelegate::createWebViewWithRequest):
3140         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3141         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
3142         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
3143         (WebKitBrowserWindow::updateProxySettings):
3144         (WebKitBrowserWindow::createNewPage):
3145         * MiniBrowser/win/WebKitBrowserWindow.h:
3146         * MiniBrowser/win/WinMain.cpp:
3147         (wWinMain):
3148
3149 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
3150
3151         Make it possible to test scrolling tree layer manipulation more easily
3152         https://bugs.webkit.org/show_bug.cgi?id=195780
3153
3154         Reviewed by Tim Horton.
3155         
3156         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
3157         cuts off communication of scrolling tree scrolls back to the web process
3158         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
3159         allows tests to trigger scrolls which run the scrolling tree layer positioning
3160         logic, but never get another commit from the web process that might mask
3161         scrolling tree bugs.
3162         
3163         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
3164         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
3165         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
3166
3167         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3168         (WTR::UIScriptController::scrollUpdatesDisabled const):
3169         (WTR::UIScriptController::setScrollUpdatesDisabled):
3170         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3171         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3172         (WTR::UIScriptController::scrollUpdatesDisabled const):
3173         (WTR::UIScriptController::setScrollUpdatesDisabled):
3174         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3175         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
3176         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3177         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
3178         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
3179         * WebKitTestRunner/ios/TestControllerIOS.mm:
3180         (WTR::TestController::platformResetStateToConsistentValues):
3181         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3182         (WTR::UIScriptController::scrollUpdatesDisabled const):
3183         (WTR::UIScriptController::setScrollUpdatesDisabled):
3184
3185 2019-03-14  Youenn Fablet  <youenn@apple.com>
3186
3187         Move IDB storage in private browsing mode to NetworkProcess
3188         https://bugs.webkit.org/show_bug.cgi?id=195602
3189
3190         Reviewed by Brady Eidson.
3191
3192         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
3193         (TEST):
3194
3195 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3196
3197         [ews-build] Make descriptionDone messages more readable
3198         https://bugs.webkit.org/show_bug.cgi?id=195760
3199
3200         Reviewed by Lucas Forschler.
3201
3202         * BuildSlaveSupport/ews-build/steps.py:
3203         * BuildSlaveSupport/ews-build/steps_unittest.py:
3204
3205 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3206
3207         [ews-build] Generate status-bubble hover-over messages
3208         https://bugs.webkit.org/show_bug.cgi?id=195680
3209
3210         Reviewed by Lucas Forschler.
3211
3212         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3213         (StatusBubble):
3214         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
3215         on hover-over.
3216         (StatusBubble._iso_time):
3217         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
3218         hover-over message.
3219         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
3220
3221 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3222
3223         [ews-app] Gracefully handle the case when state_string is None
3224         https://bugs.webkit.org/show_bug.cgi?id=195753
3225
3226         Reviewed by Lucas Forschler.
3227
3228         * BuildSlaveSupport/ews-app/ews/models/build.py:
3229         * BuildSlaveSupport/ews-app/ews/models/step.py:
3230
3231 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
3232
3233         [ews-app] Status bubble display pending for currently running build step
3234         https://bugs.webkit.org/show_bug.cgi?id=195744
3235
3236         Reviewed by Lucas Forschler.
3237
3238         * BuildSlaveSupport/ews-build/events.py:
3239         (Events.stepStarted): If state_string is pending, replace it with step name.
3240
3241 2019-03-14  Chris Dumez  <cdumez@apple.com>
3242
3243         Add WebsitePolicy for the client to specify the device orientation & motion access policy
3244         https://bugs.webkit.org/show_bug.cgi?id=195750
3245
3246         Reviewed by Geoffrey Garen.
3247
3248         Add API test coverage.
3249
3250         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3251         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
3252         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3253         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3254
3255 2019-03-14  Chris Dumez  <cdumez@apple.com>
3256
3257         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
3258         https://bugs.webkit.org/show_bug.cgi?id=195747
3259
3260         Reviewed by Geoff Garen.
3261
3262         Add API test coverage.
3263
3264         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3265
3266 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
3267
3268         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
3269         https://bugs.webkit.org/show_bug.cgi?id=195725
3270         <rdar://problem/48545062>
3271
3272         Reviewed by Tim Horton.
3273
3274         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
3275         handler is nil.
3276
3277         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3278         (TestWebKitAPI::TEST):
3279
3280 2019-03-13  Sam Weinig  <sam@webkit.org>
3281
3282         Add utility function to allow easy reverse range-based iteration of a container
3283         https://bugs.webkit.org/show_bug.cgi?id=195542
3284
3285         Reviewed by Antti Koivisto.
3286
3287         * TestWebKitAPI/CMakeLists.txt:
3288         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3289         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
3290         (TestWebKitAPI::TEST):
3291         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
3292
3293 2019-03-13  Chris Dumez  <cdumez@apple.com>
3294
3295         Use a ServiceWorker process per registrable domain
3296         https://bugs.webkit.org/show_bug.cgi?id=195649
3297
3298         Reviewed by Youenn Fablet.
3299
3300         Update API test coverage.
3301
3302         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3303
3304 2019-03-13  Chris Dumez  <cdumez@apple.com>
3305
3306         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
3307         https://bugs.webkit.org/show_bug.cgi?id=195684
3308         <rdar://problem/48294714>
3309
3310         Reviewed by Antti Koivisto.
3311
3312         Add API test coverage.
3313
3314         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3315
3316 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3317
3318         [ews-app] Remove unused patch view
3319         https://bugs.webkit.org/show_bug.cgi?id=195669
3320
3321         Reviewed by Lucas Forschler.
3322
3323         * BuildSlaveSupport/ews-app/ews/urls.py:
3324         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
3325
3326 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3327
3328         [ews-app] Use Buildbot result code variables
3329         https://bugs.webkit.org/show_bug.cgi?id=195668
3330
3331         Reviewed by Alexey Proskuryakov.
3332
3333         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3334         (Buildbot): Added Buildbot result code variables.
3335         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3336         (StatusBubble._build_bubble): Used Buildbot result code variables.
3337
3338 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
3339
3340         [Flatpak] Expand submodule recursively
3341         https://bugs.webkit.org/show_bug.cgi?id=195672
3342
3343         Building WPE with flatpak was impossible without that as it was raising an exception.
3344         Also update wpebackend-fdo to match what is built in jhbuild
3345
3346         Reviewed by Philippe Normand.
3347
3348         * flatpak/flatpakutils.py:
3349         (expand_submodules_recurse):
3350         (expand_manifest):
3351         * flatpak/org.webkit.WPEModules.yaml:
3352
3353 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
3354
3355         [ews-app] status bubble should be hidden for certain builds
3356         https://bugs.webkit.org/show_bug.cgi?id=194597
3357
3358         Reviewed by Dewei Zhu.
3359
3360         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3361         (StatusBubble._build_bubble):
3362         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
3363         because the patch didn't have relevant changes.
3364         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
3365         in production yet.
3366
3367 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
3368
3369         [Win] Fix a slew of simple clang-cl warnings.
3370         https://bugs.webkit.org/show_bug.cgi?id=195652
3371
3372         Reviewed by Don Olmstead.
3373
3374         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3375         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
3376
3377 2019-03-12  Justin Fan  <justin_fan@apple.com>
3378
3379         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
3380         https://bugs.webkit.org/show_bug.cgi?id=195518
3381         <rdar://problem/46322356>
3382
3383         Reviewed by Myles C. Maxfield.
3384
3385         * DumpRenderTree/DerivedSources-input.xcfilelist:
3386         * DumpRenderTree/DerivedSources-output.xcfilelist:
3387
3388 2019-03-12  Commit Queue  <commit-queue@webkit.org>
3389
3390         Unreviewed, rolling out r242825.
3391         https://bugs.webkit.org/show_bug.cgi?id=195648
3392
3393         "Broke webkitpy tests with my change to
3394         lldb_dump_class_layout.py" (Requested by rmorisset on
3395         #webkit).
3396
3397         Reverted changeset:
3398
3399         "Alter Tools/Scripts/dump-class-layout to be able to dump all
3400         classes with suspicious padding"
3401         https://bugs.webkit.org/show_bug.cgi?id=195573
3402         https://trac.webkit.org/changeset/242825
3403
3404 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3405
3406         [ews-build] Show status bubbles while the patch is waiting in queue
3407         https://bugs.webkit.org/show_bug.cgi?id=195618
3408
3409         Reviewed by Lucas Forschler.
3410
3411         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3412         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
3413         enabled in initial deployment.
3414         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
3415         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
3416         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
3417         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
3418         (StatusBubble._build_bubbles_for_patch):
3419
3420 2019-03-12  Robin Morisset  <rmorisset@apple.com>
3421
3422         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
3423         https://bugs.webkit.org/show_bug.cgi?id=195573
3424
3425         Reviewed by Simon Fraser.
3426
3427         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
3428
3429         * Scripts/dump-class-layout:
3430         (main):
3431         * lldb/lldb_dump_class_layout.py:
3432         (ClassLayout.__init__):
3433         (ClassLayout._compute_padding_recursive):
3434         (LLDBDebuggerInstance.dump_layout_for_classname):
3435         (LLDBDebuggerInstance):
3436         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
3437         (LLDBDebuggerInstance.layout_for_classname): Deleted.
3438
3439 2019-03-12  Chris Dumez  <cdumez@apple.com>
3440
3441         Device Orientation access permission should be denied unless explicitly granted by the client
3442         https://bugs.webkit.org/show_bug.cgi?id=195625
3443
3444         Reviewed by Youenn Fablet.
3445
3446         add API test coverage.
3447
3448         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3449         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
3450         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
3451         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
3452         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3453         (runDeviceOrientationTest):
3454         (TEST):
3455         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3456         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
3457
3458 2019-03-12  Jer Noble  <jer.noble@apple.com>
3459
3460         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
3461         https://bugs.webkit.org/show_bug.cgi?id=195137
3462         <rdar://problem/48810307>
3463
3464         Reviewed by Eric Carlson.
3465
3466         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
3467         (TestWebKitAPI::TEST):
3468
3469 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3470
3471         [ews-build] Change urls from uat to production
3472         https://bugs.webkit.org/show_bug.cgi?id=195566
3473
3474         Reviewed by Lucas Forschler.
3475
3476         * BuildSlaveSupport/ews-app/ews/config.py:
3477         * BuildSlaveSupport/ews-build/events.py:
3478         * BuildSlaveSupport/ews-build/steps.py:
3479
3480 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
3481
3482         [ews-build] change max_builds for local-worker to 1
3483         https://bugs.webkit.org/show_bug.cgi?id=195568
3484
3485         Reviewed by Lucas Forschler.
3486
3487         * BuildSlaveSupport/ews-build/loadConfig.py:
3488
3489 2019-03-12  Tim Horton  <timothy_horton@apple.com>
3490
3491         Fix the build
3492
3493         * TestRunnerShared/spi/PencilKitTestSPI.h:
3494         * TestWebKitAPI/ios/PencilKitTestSPI.h:
3495
3496 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
3497
3498         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
3499         https://bugs.webkit.org/show_bug.cgi?id=194131
3500
3501         Reviewed by Michael Catanzaro.
3502
3503         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3504         (uriChanged):
3505         (testUnfinishedSubresourceLoad):
3506         (serverCallback):
3507         (beforeAll):
3508
3509 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3510
3511         WTF::Expected should use std::addressof instead of operator&
3512         https://bugs.webkit.org/show_bug.cgi?id=195604
3513
3514         Reviewed by Myles Maxfield.
3515
3516         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3517         (TestWebKitAPI::Unique::Unique):
3518         (TestWebKitAPI::Unique::operator&):
3519         (TestWebKitAPI::TEST):
3520
3521 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
3522
3523         Add Optional to Forward.h.
3524         https://bugs.webkit.org/show_bug.cgi?id=195586
3525
3526         Reviewed by Darin Adler.
3527
3528         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
3529         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
3530         Remove unnecessary includes from headers.
3531
3532 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
3533
3534         Add testing API to hit-test and scroll overflow scrollers
3535         https://bugs.webkit.org/show_bug.cgi?id=195278
3536
3537         Reviewed by Antti Koivisto.
3538         
3539         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
3540         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
3541         
3542         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
3543
3544         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3545         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3546         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3547         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3548         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3549         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3550         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3551         (WTR::enclosingScrollViewIncludingSelf):
3552         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
3553
3554 2019-03-11  Tim Horton  <timothy_horton@apple.com>
3555
3556         API test WebKit.RequestTextInputContext fails on iOS
3557         https://bugs.webkit.org/show_bug.cgi?id=195585
3558
3559         Reviewed by Wenson Hsieh and Simon Fraser.
3560
3561         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3562         (applyStyle):
3563         (TEST):
3564         Add a viewport, so that the coordinates match up on iOS.
3565         Scroll by moving the UIScrollView's contentOffset.
3566
3567 2019-03-11  Chris Dumez  <cdumez@apple.com>
3568
3569         Assert in WebPageProxy::suspendCurrentPageIfPossible()
3570         https://bugs.webkit.org/show_bug.cgi?id=195506
3571         <rdar://problem/48733477>
3572
3573         Reviewed by Alex Christensen.
3574
3575         Add API test coverage.
3576
3577         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3578
3579 2019-03-11  Shawn Roberts  <sroberts@apple.com>
3580
3581         Adding myself to contributors.json
3582
3583         Unreviewed, addming myself to contributors.json .
3584
3585         * Scripts/webkitpy/common/config/contributors.json:
3586
3587 2019-03-11  Alex Christensen  <achristensen@webkit.org>
3588
3589         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
3590         https://bugs.webkit.org/show_bug.cgi?id=195511
3591         <rdar://problem/44873269>
3592
3593         Reviewed by Darin Adler.
3594
3595         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
3596         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
3597         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
3598         (TEST_F):
3599
3600 2019-03-11  Chris Dumez  <cdumez@apple.com>
3601
3602         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
3603         https://bugs.webkit.org/show_bug.cgi?id=195561
3604
3605         Reviewed by Youenn Fablet.
3606
3607         Make sure the JS in the test requests for permission to receive device orientation events.
3608
3609         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3610
3611 2019-03-11  Youenn Fablet  <youenn@apple.com>
3612
3613         Allow storage quota increase by default in WTR
3614         https://bugs.webkit.org/show_bug.cgi?id=195541
3615
3616         Reviewed by Geoffrey Garen.
3617
3618         Allow storage quota increase by default in WTR.
3619         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
3620         Use this for tests that explicitly need cache increase.
3621
3622         Instead of increasing quota by 2, make sure the next request is
3623         granted by adding all given parameters.
3624
3625         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3626         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3627         (WTR::TestRunner::setAllowStorageQuotaIncrease):
3628         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
3629         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3630         * WebKitTestRunner/TestController.cpp:
3631         (WTR::TestController::setAllowStorageQuotaIncrease):
3632         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3633         * WebKitTestRunner/TestController.h:
3634         * WebKitTestRunner/TestInvocation.cpp:
3635         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3636         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3637         (WTR::TestController::cocoaResetStateToConsistentValues):
3638         (WTR::TestController::setAllowStorageQuotaIncrease):
3639         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
3640         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3641         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3642
3643 2019-03-11  Xan Lopez  <xan@igalia.com>
3644
3645         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
3646         https://bugs.webkit.org/show_bug.cgi?id=194147
3647
3648         Reviewed by Michael Saboff.
3649
3650         To make --32-bit work correctly on Linux/64bit we need to:
3651
3652         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
3653         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
3654         unfortunately CMake only allows us to do this during
3655         crosscompilation, which is overkill here.
3656         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
3657         pkg-config detection module uses the x86 .pc files instead of the
3658         x86_64 ones.
3659         - Set the -m32 flags for the compiler.
3660
3661         * Scripts/webkitdirs.pm:
3662         (generateBuildSystemFromCMakeProject):
3663
3664 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
3665
3666         Add MotionMark-1.1 plan file for run-benchmark script.
3667         https://bugs.webkit.org/show_bug.cgi?id=195481
3668
3669         Rubber-stamped by Darin Adler.
3670
3671         Run-benchmark script should support MontionMark-1.1.
3672
3673         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
3674
3675 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
3676
3677         [ews-app] Add support for submit-to-ews url
3678         https://bugs.webkit.org/show_bug.cgi?id=195477
3679
3680         Reviewed by Lucas Forschler.
3681
3682         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3683         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3684         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
3685         * BuildSlaveSupport/ews-app/ews/urls.py:
3686         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
3687
3688 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
3689
3690         Unreviewed, rolling out r242688, r242643, r242624.
3691
3692         Caused multiple layout test failures and crashes on iOS and macOS.
3693
3694         Reverted changeset:
3695
3696         "requestAnimationFrame should execute before the next frame"