51a9d3e455362a22532ad3527867dc7b2c66b09e
[WebKit-https.git] / Tools / ChangeLog
1 2013-10-31  Geoffrey Garen  <ggaren@apple.com>
2
3         Added Mark Lam as a reviewer.
4
5         Unreviewed.
6
7         * Scripts/webkitpy/common/config/contributors.json:
8
9 2013-10-30  Alexey Proskuryakov  <ap@apple.com>
10
11         Teach the style checker about ENUM_CLASS
12         https://bugs.webkit.org/show_bug.cgi?id=123528
13
14         Reviewed by Andy Estes.
15
16         * Scripts/webkitpy/style/checkers/cpp.py:
17         (_EnumState.process_clean_line): Make content of an ENUM_CLASS declaration
18         equivalent to enum content for checking.
19         (check_braces): Allow semicolon at the end.
20
21         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
22         (NoNonVirtualDestructorsTest.test_enum_casing):
23         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon):
24         (WebKitStyleTest.test_braces):
25         Test it.
26
27 2013-10-30  Ryosuke Niwa  <rniwa@webkit.org>
28
29         kill-old-processes should kill Web Socket script
30         https://bugs.webkit.org/show_bug.cgi?id=123546
31
32         Reviewed by Benjamin Poulain.
33
34         * BuildSlaveSupport/kill-old-processes:
35         (main):
36
37 2013-10-30  Alexey Proskuryakov  <ap@apple.com>
38
39         Set svn:ignore for .pyc files created for test-webkitpy.
40
41         * Scripts/webkitpy/layout_tests/reftests: Added property svn:ignore.
42         * Scripts/webkitpy/performance_tests: Added property svn:ignore.
43         * Scripts/webkitpy/to_be_moved: Added property svn:ignore.
44         * Scripts/webkitpy/w3c: Added property svn:ignore.
45
46 2013-10-30  Alexey Proskuryakov  <ap@apple.com>
47
48         85 inspector tests asserting in DrawingAreaProxyImpl::updateAcceleratedCompositingMode()
49         when there is a stale WebKitTestRunner preference
50         https://bugs.webkit.org/show_bug.cgi?id=115115
51
52         Reviewed by Darin Adler.
53
54         Delete stale preferences on launch.
55
56         * WebKitTestRunner/TestController.h:
57         * WebKitTestRunner/TestController.cpp:
58         (WTR::TestController::initialize): Now that we don't have preferences stored from
59         the previous run, we need th reinstate them before creating a WKView. Not all preferences
60         can be applied to an existing view retroactively.
61         (WTR::TestController::resetPreferencesToConsistentValues): Split out of resetStateToConsistentValues,
62         because there is no injected bundle yet when calling this function from initialize().
63
64         * WebKitTestRunner/mac/main.mm: (setDefaultsToConsistentValuesForTesting): Delete
65         the preferences.
66
67         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):
68         Added some FIXMEs.
69
70 2013-10-30  Anders Carlsson  <andersca@apple.com>
71
72         Try to fix the 32-bit build.
73         
74         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
75         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm:
76
77 2013-10-30  Anders Carlsson  <andersca@apple.com>
78
79         Begin fleshing out an API test for WKRemoteObjectRegistry
80         https://bugs.webkit.org/show_bug.cgi?id=123531
81
82         Reviewed by Andreas Kling.
83
84         Add a very simple test that doesn't really test anything for now.
85
86         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
87         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm: Added.
88         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm: Added.
89         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Shared.h: Added.
90
91 2013-10-30  Filip Pizlo  <fpizlo@apple.com>
92
93         Remove unnecessary touch
94
95         Rubber stamped by Mark Hahnenberg.
96
97         * Scripts/run-jsc-stress-tests:
98
99 2013-10-30  Samuel White  <samuel_white@apple.com>
100
101         AX: Add samuel_white@apple.com to accessibility watchlist cc rules
102         https://bugs.webkit.org/show_bug.cgi?id=123515
103
104         Reviewed by Chris Fleizach.
105
106         Adding myself and jcraig@apple.com (per his request) to the accessibility watchlist. Also
107         updating contributors.json with permission from bweinstein@apple.com to make this possible.
108
109         * Scripts/webkitpy/common/config/contributors.json:
110         * Scripts/webkitpy/common/config/watchlist:
111
112 2013-10-30  Patrick Gansterer  <paroga@webkit.org>
113
114         [WIN] Add executable entry points to DRT and WinLauncher
115         https://bugs.webkit.org/show_bug.cgi?id=121837
116
117         Reviewed by Brent Fulgham.
118
119         This allows to compile and run the executables without DLLLauncher.
120
121         * DumpRenderTree/win/DumpRenderTree.cpp:
122         (main):
123         (dllLauncherEntryPoint):
124         * WinLauncher/WinLauncher.cpp:
125         (wWinMain):
126         (dllLauncherEntryPoint):
127
128 2013-10-30  Filip Pizlo  <fpizlo@apple.com>
129
130         run-jsc-stress-tests should handle ".." in paths and "slow!" in cmd's
131         https://bugs.webkit.org/show_bug.cgi?id=123521
132
133         Reviewed by Mark Hahnenberg.
134
135         * Scripts/run-jsc-stress-tests:
136
137 2013-10-30  Alexey Proskuryakov  <ap@apple.com>
138
139         Mavericks: 128 tests are failing due to pixel differences
140         https://bugs.webkit.org/show_bug.cgi?id=123488
141
142         Reviewed by Simon Fraser.
143
144         Apple font preferences cannot be fully reset after they've been read, so we
145         need to set them using CFPreferences before initializing NSApplication.
146
147         In theory, this should be an issue on WebKit2 as well, but somehow it doesn't
148         appear to be. I guess we can figure out the reasons for this difference when/if
149         any observable problems start to occur.
150
151         * DumpRenderTree/mac/DumpRenderTree.mm:
152         (setDefaultsToConsistentValuesForTesting): Only set defaults here, move other work
153         to prepareConsistentTestingEnvironment().
154         (main): Call setDefaultsToConsistentValuesForTesting before [NSApplication sharedApplication]
155         (which is unnecessary anyway since NSUserDefaults will implicitly call it, but seems
156         useful to keep in case we change out approach to defaults again).
157
158 2013-10-29  Andy Estes  <aestes@apple.com>
159
160         Teach the style checker how to handle Objective-C categories and NS_ENUM
161         https://bugs.webkit.org/show_bug.cgi?id=123482
162
163         Reviewed by Dan Bernstein.
164
165         * Scripts/webkitpy/style/checkers/cpp.py:
166         (check_spacing_for_function_call): Allow a space before '(' in a line
167         starting with @interface or @implementation, since this is defining an
168         Objective-C category rather than a function.
169         (check_braces): The opening brace of an NS_ENUM should not be on its
170         own line.
171         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added unit tests.
172
173 2013-10-30  Robert Plociennik  <r.plociennik@samsung.com>
174
175         [EFL] accessibility/textarea-selected-text-range.html is failing
176         https://bugs.webkit.org/show_bug.cgi?id=112016
177
178         Reviewed by Mario Sanchez Prada.
179
180         Provided implementation for AccessibilityUIElement::selectedTextRange() and
181         AccessibilityUIElement::setSelectedTextRange().
182
183         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
184         (AccessibilityUIElement::selectedTextRange): Implemented.
185         (AccessibilityUIElement::setSelectedTextRange): Implemented
186         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
187         (WTR::AccessibilityUIElement::selectedTextRange): Implemented.
188         (WTR::AccessibilityUIElement::setSelectedTextRange): Implemented.
189
190 2013-10-30  Robert Plociennik  <r.plociennik@samsung.com>
191
192         [GTK] accessibility/svg-remote-element.html is failing
193         https://bugs.webkit.org/show_bug.cgi?id=101185
194
195         Reviewed by Chris Fleizach.
196
197         Implemented missing methods by mimicing existing functionality in
198         AccessibilityObject::clickPoint() using available ATK API.
199
200         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
201         (AccessibilityUIElement::clickPointX): Implemented.
202         (AccessibilityUIElement::clickPointY): Implemented.
203         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
204         (WTR::AccessibilityUIElement::clickPointX): Implemented.
205         (WTR::AccessibilityUIElement::clickPointY): Implemented.
206
207 2013-10-30  Tamas Gergely  <gertom@inf.u-szeged.hu>
208
209         Removed Windows platform configurations from WebKitTestRunner.
210         https://bugs.webkit.org/show_bug.cgi?id=123152
211
212         Reviewed by Csaba Osztrogonác.
213
214         Removed Windows specific parts from the source files, Windows specific
215         subdirectory (win) and Visual Studio property files from the WebKitTestRunner,
216         as the platform is no longer supported by this tool.
217
218         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Removed.
219         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Removed.
220         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: Removed.
221         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Removed.
222         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Removed.
223         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Removed.
224         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Removed.
225         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
226         (WTR::AccessibilityController::rootElement):
227         (WTR::AccessibilityController::focusedElement):
228         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
229         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
230         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
231         * WebKitTestRunner/InjectedBundle/TestRunner.h:
232         * WebKitTestRunner/PlatformWebView.h:
233         * WebKitTestRunner/TestController.cpp:
234         (WTR::TestController::initialize):
235         * WebKitTestRunner/TestInvocation.cpp:
236         (WTR::createWKURL):
237         * WebKitTestRunner/cg/TestInvocationCG.cpp:
238         * WebKitTestRunner/config.h:
239         * WebKitTestRunner/win/InjectedBundle.vcproj: Removed.
240         * WebKitTestRunner/win/InjectedBundleDebug.vsprops: Removed.
241         * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops: Removed.
242         * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops: Removed.
243         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Removed.
244         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Removed.
245         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd: Removed.
246         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd: Removed.
247         * WebKitTestRunner/win/InjectedBundleProduction.vsprops: Removed.
248         * WebKitTestRunner/win/InjectedBundleRelease.vsprops: Removed.
249         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops: Removed.
250         * WebKitTestRunner/win/PlatformWebViewWin.cpp: Removed.
251         * WebKitTestRunner/win/TestControllerWin.cpp: Removed.
252         * WebKitTestRunner/win/TestInvocationWin.cpp: Removed.
253         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Removed.
254         * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops: Removed.
255         * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops: Removed.
256         * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops: Removed.
257         * WebKitTestRunner/win/WebKitTestRunnerLauncher.vcproj: Removed.
258         * WebKitTestRunner/win/WebKitTestRunnerLauncherCommon.vsprops: Removed.
259         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebug.vsprops: Removed.
260         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugAll.vsprops: Removed.
261         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops: Removed.
262         * WebKitTestRunner/win/WebKitTestRunnerLauncherProduction.vsprops: Removed.
263         * WebKitTestRunner/win/WebKitTestRunnerLauncherRelease.vsprops: Removed.
264         * WebKitTestRunner/win/WebKitTestRunnerLauncherReleaseCairoCFLite.vsprops: Removed.
265         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd: Removed.
266         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd: Removed.
267         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops: Removed.
268         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops: Removed.
269         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops: Removed.
270         * WebKitTestRunner/win/build-generated-files.sh: Removed.
271         * WebKitTestRunner/win/main.cpp: Removed.
272
273 2013-10-29  Alexey Proskuryakov  <ap@apple.com>
274
275         Result of focus-option-control-on-page.html depends on system preferences
276         https://bugs.webkit.org/show_bug.cgi?id=123304
277
278         Reviewed by Simon Fraser.
279
280         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
281         Override a preference that WebKit reads to decide what Tab does, so that current
282         user default doesn't affect tests.
283
284         * WebKitTestRunner/mac/main.mm: (setDefaultsToConsistentValuesForTesting):
285         Ditto.
286
287 2013-10-29  Filip Pizlo  <fpizlo@apple.com>
288
289         It should be possible to specify extra tests to run-javascriptcore-tests
290         https://bugs.webkit.org/show_bug.cgi?id=123495
291
292         Reviewed by Oliver Hunt.
293         
294         This adds two ways to specify additional tests: the option --extra-tests=<blah>, and
295         the environment variable EXTRA_JSC_TESTS.
296         
297         Those two values (the command-line option and the environment variable) are passed
298         as extra arguments to run-jsc-stress-tests.
299         
300         To make this extra super useful, run-jsc-stress-tests now allows yaml configuration
301         files to be recursive: if a "- collection:" line is found, the string is handled
302         just as if it was a command-line argument. This allows you to use --extra-tests=file
303         where file contains a bunch of "- collection:" lines, and this is equivalent to each
304         of those lines being a command-line argument.
305
306         * Scripts/run-javascriptcore-tests:
307         * Scripts/run-jsc-stress-tests:
308
309 2013-10-29  Ryosuke Niwa  <rniwa@webkit.org>
310
311         Add Mavericks builders to the old flakiness dashboard.
312
313         * TestResultServer/static-dashboards/builders.jsonp:
314         * TestResultServer/static-dashboards/flakiness_dashboard.js:
315
316 2013-10-29  Seokju Kwon  <seokju@webkit.org>
317
318         Fix memory leak in Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp
319         https://bugs.webkit.org/show_bug.cgi?id=123478
320
321         Reviewed by Anders Carlsson.
322
323         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
324         (NPP_Destroy): Add a missing free() for 'obj->evaluateScriptOnMouseDownOrKeyDown'.
325
326 2013-10-29  Lucas Forschler  <lforschler@apple.com>
327
328         Move the SEO bots from testers to archivers.
329         
330         Unreviewed.
331         
332         * BuildSlaveSupport/build.webkit.org-config/config.json:
333
334 2013-10-29  Hugo Parente Lima  <hugo.lima@openbossa.org>
335
336         Adding Nix files in Source/Platform to trunk
337         https://bugs.webkit.org/show_bug.cgi?id=118331
338
339         Reviewed by Benjamin Poulain.
340
341         Add a special rule for Nix API files located at Source/Platform/nix.
342
343         * Scripts/webkitpy/style/checker.py:
344
345  2013-10-29  Nadav Rotem  <nrotem@apple.com>
346  
347          Add myself as a comitter.
348          https://bugs.webkit.org/show_bug.cgi?id=123455
349  
350          Reviewed by Anders Carlsson.
351  
352          * Scripts/webkitpy/common/config/contributors.json:
353  
354 2013-10-29  Lucas Forschler  <lforschler@apple.com>
355
356         Teach the WebKit2 testers to abort early by setting the shouldAbortEarly property to True.
357         https://bugs.webkit.org/show_bug.cgi?id=123450
358
359         Reviewed by Alexey Proskuryakov.
360
361         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
362         (RunWebKit2Tests.start):
363
364 2013-10-29  Alexey Proskuryakov  <ap@apple.com>
365
366         [Mac] Rationalize user defaults override code
367         https://bugs.webkit.org/show_bug.cgi?id=123436
368
369         Reviewed by Dan Bernstein.
370
371         * DumpRenderTree/mac/DumpRenderTree.mm:
372         (resetWebPreferencesToConsistentValues): Renamed from resetDefaultsToConsistentValues,
373         because this function only resets WebPreferences now.
374         (setDefaultsToConsistentValuesForTesting): Moved code for setting the defaults
375         here, because tests never change them, and they only need to be set once, not
376         before each test. Removed long obsolete workaround for HIToolbox preferences.
377         Don't call resetWebPreferencesToConsistentValues, because it will be called before
378         the first test anyway.
379         (main): Don't set AppleMagnifiedMode here, moved that to setDefaultsToConsistentValuesForTesting.
380         (resetWebViewToConsistentStateBeforeTesting): Moved TestRunner::setSerializeHTTPLoads
381         and setlocale calls out of resetWebPreferencesToConsistentValues().
382         Added AppleAquaAntiAliasingChanged notification that we had in WK2, because it's
383         also needed in WK1.
384
385         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
386         (WTR::InjectedBundle::platformInitialize): Use literal syntax for defaults
387         dictionary.
388
389         * WebKitTestRunner/mac/main.mm:
390         (setDefaultsToConsistentValuesForTesting): Factored out of main(), and changed to
391         use NSArgumentDomain for everything.
392
393 2013-10-29  Philippe Normand  <pnormand@igalia.com>
394
395         [GTK] enable media-stream in build-webkit
396         https://bugs.webkit.org/show_bug.cgi?id=123144
397
398         Reviewed by Martin Robinson.
399
400         * Scripts/webkitperl/FeatureList.pm: Enable media-stream build
401         for the GTK+ port.
402
403 2013-10-29  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
404
405         EFL 32 bit buildbot doesn't work on dashboard
406         https://bugs.webkit.org/show_bug.cgi?id=123435
407
408         Reviewed by Csaba Osztrogonác.
409
410         32 bit buildbot doesn't work on dashboard because name is different from buildbot list.
411
412         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
413         (WebKitBuildbot):
414
415 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
416
417         Floating left the header broke other pages, and this CSS has no way to customize
418         per-page.
419
420         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
421
422 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
423
424         Remove underlines on the bot names in the header.
425         
426         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
427         (td.LastBuild a):
428
429 2013-10-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
430
431         Add EFL release bots to the buildbot dashboard
432         https://bugs.webkit.org/show_bug.cgi?id=123430
433
434         Reviewed by Darin Adler.
435
436         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png: Added.
437         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
438         (WebKitBuildbot): add 64 bits release wk2 and wk1 testers and 32 bits release builder.
439         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
440         (table.queue-grid tr.platform.linux-efl img.logo): use the EFL logo in its dashboard line.
441
442 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
443
444         More waterfall tweaking.
445
446         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
447         (body > .header):
448         (td.LastBuild):
449         (td.LastBuild a):
450         (td.LastBuild,td.Activity a,td.Change a,td.Builder a):
451
452 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
453
454         More waterfall tweaking.
455
456         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
457         (body.interface):
458         (body > hr):
459         (div.content h1):
460         (body > .header):
461         (td.Activity a,td.Change a,td.Builder a):
462         (td.Builder):
463
464 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
465
466         Apply changes to default.css, revert buildbot.css which seems to be unused.
467
468         * BuildSlaveSupport/build.webkit.org-config/public_html/buildbot.css:
469         (body):
470         (body, td):
471         (a:link,a:visited,a:active):
472         (td.Time):
473         (td.Activity):
474         (.exception, td.offline):
475         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
476         (body.interface):
477         (.auth):
478         (td.LastBuild):
479         (td.Time):
480         (td.Activity):
481         (.offline,td.offline,.retry):
482
483 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
484
485         Prettify the waterfall page, and make it a little more space-efficient.
486         
487         * BuildSlaveSupport/build.webkit.org-config/public_html/buildbot.css:
488         (body, td):
489         (body.interface):
490         (.auth):
491         (.header):
492         (div.content h1):
493         (a):
494         (a:link,a:active):
495         (a:link,a:visited,a:active):
496         (td.LastBuild):
497         (td.Time):
498         (td.Activity):
499         (.exception, td.offline, .retry):
500
501 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
502
503         Fix Lion readableName (spotted by Dan Bernstein).
504
505         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
506
507 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
508
509         Add tooltips to the platform icons in Dashboard
510         https://bugs.webkit.org/show_bug.cgi?id=123429
511
512         Reviewed by Alexey Proskuryakov.
513         
514         Add a human readable name to Buildbot.Platform entries, and use it to
515         show a tooltip on the ring image.
516
517         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
518         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
519         (documentReady):
520
521 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
522
523         Allow explicit sort order for Dashboard platforms
524         https://bugs.webkit.org/show_bug.cgi?id=123419
525
526         Reviewed by Tim Hatcher.
527         
528         Assign a specific sort order to Dashboard platforms, rather than
529         just using object property order.
530
531         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
532         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
533         (BuildbotQueue):
534         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
535         (documentReady):
536
537 2013-10-28  Simon Fraser  <simon.fraser@apple.com>
538
539         Tidy up main http://build.webkit.org page
540         https://bugs.webkit.org/show_bug.cgi?id=123413
541
542         Reviewed by Alexey Proskuryakov.
543         
544         Break the list of links into sections. Add some font style.
545
546         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
547
548 2013-10-28  Myles C. Maxfield  <mmaxfield@apple.com>
549
550         Parsing support for -webkit-text-decoration-skip: ink
551         https://bugs.webkit.org/show_bug.cgi?id=123358
552
553         Reviewed by Dean Jackson.
554
555         Adding ENABLE(CSS3_TEXT_DECORATION)
556
557         * Scripts/webkitperl/FeatureList.pm:
558
559 2013-10-28  Lucas Forschler  <lforschler@apple.com>
560
561         Add additional Apple Mavericks test bots.
562         
563         Unreviewed.
564         
565         * BuildSlaveSupport/build.webkit.org-config/config.json:
566
567 2013-10-28  Bastien Nocera <hadess@hadess.net>
568
569         Name all the GLib timeout sources
570         https://bugs.webkit.org/show_bug.cgi?id=123229
571
572         Reviewed by Anders Carlsson.
573
574         Give a name to GLib timeout sources, this is helpful when
575         profiling WebKitGTK applications.
576
577 2013-10-28  Bastien Nocera <hadess@hadess.net>
578
579         Replace 0 timeouts g_timeout_add() by g_idle_add()
580         https://bugs.webkit.org/show_bug.cgi?id=123260
581
582         Reviewed by Carlos Garcia Campos.
583
584         A zero timeout should be equivalent to using g_idle_add_full(G_PRIORITY_DEFAULT, ...)
585         without the nagging feeling that the wrong API was used.
586
587         * DumpRenderTree/gtk/DumpRenderTree.cpp: Use g_idle_add() instead
588         of 0-timer.
589         (topLoadingFrameLoadFinished):
590         * DumpRenderTree/gtk/EventSender.cpp: Ditto.
591         (scheduleAsynchronousClickCallback):
592         (scheduleAsynchronousKeyDownCallback):
593
594 2013-10-25  Anton Obzhirov  <a.obzhirov@samsung.com>
595
596         [GTK] [WebKit2] CanHandleRequest API test fails
597         https://bugs.webkit.org/show_bug.cgi?id=88453
598
599         Reviewed by Martin Robinson.
600
601         * Scripts/run-gtk-tests:
602         (TestRunner):
603
604 2013-10-25  Ryosuke Niwa  <rniwa@webkit.org>
605
606         Build fix after r157815. Don't resolve the path from webkit_base. Use the relative path as is.
607
608         * Scripts/webkitpy/port/base.py:
609         (Port.repository_paths):
610
611 2013-10-25  Jer Noble  <jer.noble@apple.com>
612
613         [WTF] Add a multiplication operator (and a few others) to MediaTime
614         https://bugs.webkit.org/show_bug.cgi?id=123137
615
616         Reviewed by Eric Carlson.
617
618         Add tests for new MediaTime operators.
619
620         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
621         (TestWebKitAPI::TEST):
622
623 2013-10-24  Mark Rowe  <mrowe@apple.com>
624
625         Remove references to OS X 10.7 from Xcode configuration settings.
626
627         Now that we're not building for OS X 10.7 they're no longer needed.
628
629         Reviewed by Anders Carlsson.
630
631         * DumpRenderTree/mac/Configurations/Base.xcconfig:
632         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
633         * MiniBrowser/Configurations/Base.xcconfig:
634         * MiniBrowser/Configurations/DebugRelease.xcconfig:
635         * TestWebKitAPI/Configurations/Base.xcconfig:
636         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
637         * WebKitLauncher/Configurations/Base.xcconfig:
638         * WebKitTestRunner/Configurations/Base.xcconfig:
639         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
640
641 2013-10-24  Mark Rowe  <mrowe@apple.com>
642
643         <rdar://problem/15312643> Prepare for the mysterious future.
644
645         Reviewed by David Kilzer.
646
647         * DumpRenderTree/mac/Configurations/Base.xcconfig:
648         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
649         * MiniBrowser/Configurations/Base.xcconfig:
650         * MiniBrowser/Configurations/DebugRelease.xcconfig:
651         * TestWebKitAPI/Configurations/Base.xcconfig:
652         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
653         * WebKitLauncher/Configurations/Base.xcconfig:
654         * WebKitTestRunner/Configurations/Base.xcconfig:
655         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
656
657 2013-10-24  Daniel Bates  <dabates@apple.com>
658
659         Crash in WebCore::NavigationScheduler::startTimer()
660         https://bugs.webkit.org/show_bug.cgi?id=123288
661         <rdar://problem/14055644>
662
663         Reviewed by Alexey Proskuryakov.
664
665         Add API test.
666
667         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
668         * TestWebKitAPI/Tests/mac/WillPerformClientRedirectToURLCrash.html: Added.
669         * TestWebKitAPI/Tests/mac/WillPerformClientRedirectToURLCrash.mm: Added.
670
671 2013-10-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
672
673         [GTK] Disable css-image-orientation
674         https://bugs.webkit.org/show_bug.cgi?id=123257
675
676         Reviewed by Martin Robinson.
677
678         CSS image orientation isn't stable yet. So, test regression happen since r157909.
679         This feature should be enabled again after it is stable.
680
681         * Scripts/webkitperl/FeatureList.pm:
682
683 2013-10-24  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
684
685         Fix argument passing for jhbuild.
686         https://bugs.webkit.org/show_bug.cgi?id=123253
687
688         Reviewed by Gustavo Noronha Silva.
689
690         The update-webkit-libs-jhbuild previously didn't allowed
691         extra arguments to be passed to jhbuild.
692
693         * Scripts/update-webkit-libs-jhbuild:
694         (runJhbuild):
695         * Scripts/update-webkitefl-libs:
696
697 2013-10-24  Sanghyup Lee  <sh53.lee@samsung.com>
698
699         [EFL] Compilation warning in DumpRenderTreeView.cpp on 64-Bit
700         https://bugs.webkit.org/show_bug.cgi?id=123251
701
702         Reviewed by Csaba Osztrogonác.
703
704         Replace %llu by PRIu64 macro to print an uint64_t value and silent a
705         compilation warning on 64-Bit.
706
707         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
708         (onExceededDatabaseQuota):
709
710 2013-10-24  Ryuan Choi  <ryuan.choi@samsung.com>
711
712         [EFL] Build break with latest EFL 1.8 libraries.
713         https://bugs.webkit.org/show_bug.cgi?id=123245
714
715         Reviewed by Gyuyoung Kim.
716
717         After fixed build break on EFL 1.8 at r138326, EFL libraries are changed
718         Eo typedef and splitted header files which contain version macro.
719
720         * TestWebKitAPI/PlatformWebView.h: Changed Eo typedef.
721         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
722         * WebKitTestRunner/PlatformWebView.h: Ditto.
723
724 2013-10-24  Carlos Garcia Campos  <cgarcia@igalia.com>
725
726         [GObject bindings] Make EventTarget interface introspectable
727         https://bugs.webkit.org/show_bug.cgi?id=77835
728
729         Reviewed by Gustavo Noronha Silva.
730
731         * Scripts/webkitpy/style/checker.py: Add exceptions for custom
732         GObject DOM bindings headers.
733
734 2013-10-23  Lucas Forschler  <lforschler@apple.com>
735
736         Add two more mac bots to the Mavericks Test Queue.
737         
738         Unreviewed.
739         
740         * BuildSlaveSupport/build.webkit.org-config/config.json:
741
742 2013-10-23  Filip Pizlo  <fpizlo@apple.com>
743
744         Have a way of dealing with slow tests in run-jsc-stress-tests
745         https://bugs.webkit.org/show_bug.cgi?id=123221
746
747         Reviewed by Mark Hahnenberg.
748         
749         If you add the slow! command to //@ then all subsequent plans are prepended to the run list
750         rather than appended to it. This means that slow tests get queued up first and are less likely
751         to block completion.
752
753         * Scripts/run-jsc-stress-tests:
754
755 2013-10-23  Alex Christensen  <achristensen@webkit.org>
756
757         Explicitly build Win32 or x64 configuration on Windows.
758         https://bugs.webkit.org/show_bug.cgi?id=123206
759
760         Reviewed by Brent Fulgham.
761
762         * Scripts/webkitdirs.pm:
763         (jscPath):
764         (determineConfigurationForVisualStudio):
765         (determinePassedConfiguration):
766         Add |Win32 to the end of 32-bit Visual Studio build configurations.
767         (safariPath):
768         * Scripts/build-webkit:
769         * Scripts/old-run-webkit-tests:
770         * Scripts/run-api-tests:
771         (testToolPath):
772         * Scripts/run-javascriptcore-tests:
773         (testapiPath):
774         * Scripts/run-regexp-tests:
775         (testapiPath):
776         * Scripts/sunspider-compare-results:
777         (pathToBuiltJSC):
778         Use configuration instead of configurationForVisualStudio, which are now always different.
779
780 2013-10-23  Mark Lam  <mark.lam@apple.com>
781
782         Re-instate ProposedDatabases needed by detailsForNameAndOrigin().
783         https://bugs.webkit.org/show_bug.cgi?id=123131.
784
785         Reviewed by Geoffrey Garen.
786
787         Updated these files to allow database quotas to grow within a limit for
788         testing purposes.
789
790         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
791         (BlackBerry::WebKit::DumpRenderTree::exceededDatabaseQuota):
792         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
793         (onExceededDatabaseQuota):
794         * DumpRenderTree/mac/UIDelegate.mm:
795         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]):
796         * DumpRenderTree/win/UIDelegate.cpp:
797         (UIDelegate::exceededDatabaseQuota):
798         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
799         (WTR::InjectedBundlePage::didExceedDatabaseQuota):
800         * WebKitTestRunner/TestController.cpp:
801         (WTR::exceededDatabaseQuota):
802
803 2013-10-23  Simon Fraser  <simon.fraser@apple.com>
804
805         It's valid to have a build ID of 0.
806
807         Reviewed by Tim Hatcher.
808
809         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
810         (BuildbotIteration):
811
812 2013-10-23  Simon Fraser  <simon.fraser@apple.com>
813
814         Remove Lion bots from the Dashboard.
815
816         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
817         (WebKitBuildbot):
818
819 2013-10-23  Mario Sanchez Prada  <mario.prada@samsung.com>
820
821         [GTK] Expose image links properly
822         https://bugs.webkit.org/show_bug.cgi?id=84044
823
824         Reviewed by Chris Fleizach.
825
826         Expose the accessible URL if present, as yet another attribute
827         for the AccessibilityUIElement wrapper. For coherence with what
828         the Mac port does (and what you would expect as the output of
829         the layout test), we strip the absolute URL path for relative
830         references, if it's the case, leaving the base of the URL path
831         out of the exposed string.
832
833         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
834         (attributesOfElement): Print the AXURL, if available.
835         (AccessibilityUIElement::url): Expose the URL if present. That
836         is, if the wrapped AtkObject implements AtkHyperlinkImpl.
837         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
838         (attributesOfElement): Print the AXURL, if available.
839         (WTR::AccessibilityUIElement::url): Expose the URL if present.
840         That is, if the wrapped AtkObject implements AtkHyperlinkImpl.
841
842 2013-10-23  Simon Fraser  <simon.fraser@apple.com>
843
844         Remove Lion bots.
845
846         * BuildSlaveSupport/build.webkit.org-config/config.json:
847
848 2013-10-22  Simon Fraser  <simon.fraser@apple.com>
849
850         Dashboard repaints constantly
851         https://bugs.webkit.org/show_bug.cgi?id=122133
852
853         Reviewed by Tim Horton.
854         
855         Pulsing shadows are really bad for battery life.
856
857         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
858         (.status-line.bad .bubble):
859         (.status-line.bad .message):
860
861 2013-10-22  Commit Queue  <commit-queue@webkit.org>
862
863         Unreviewed, rolling out r157835.
864         http://trac.webkit.org/changeset/157835
865         https://bugs.webkit.org/show_bug.cgi?id=123192
866
867         broke 32-bit builds (Requested by smfr on #webkit).
868
869         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
870         (TestWebKitAPI::TEST):
871
872 2013-10-22  Jer Noble  <jer.noble@apple.com>
873
874         [WTF] Add a multiplication operator (and a few others) to MediaTime
875         https://bugs.webkit.org/show_bug.cgi?id=123137
876
877         Reviewed by Eric Carlson.
878
879         Add tests for new MediaTime operators.
880
881         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
882         (TestWebKitAPI::TEST):
883
884 2013-10-22  Simon Fraser  <simon.fraser@apple.com>
885
886         Educate webkitpy about Mavericks.
887
888         Reviewed by Ryosuke Niwa.
889
890         * Scripts/webkitpy/common/system/platforminfo.py:
891         (PlatformInfo._determine_mac_version):
892         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
893         (TestPlatformInfo.test_os_version):
894         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
895         (TestExpectationParser):
896         * Scripts/webkitpy/port/builders.py:
897         * Scripts/webkitpy/port/mac.py:
898         (MacPort):
899         * Scripts/webkitpy/port/mac_unittest.py:
900         (test_versions):
901         (test_baseline_search_path):
902         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
903         (TestRebaselineTest.test_baseline_directory):
904         (TestRebaselineExpectations.test_rebaseline_expectations):
905
906 2013-10-22  Stephanie Lewis  <slewis@apple.com>
907
908         Update the build trigger list for Mavericks.
909
910         Unreviewed.
911
912         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
913         (_should_file_trigger_build):
914
915 2013-10-22  Simon Fraser  <simon.fraser@apple.com>
916
917         Add Mavericks bots to the dashboard.
918
919         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
920         (WebKitBuildbot):
921
922 2013-10-22  Samuel White  <samuel_white@apple.com>
923
924         AX: Add paramAttrs to fetch start and end text markers in a given rect.
925         https://bugs.webkit.org/show_bug.cgi?id=122164
926
927         Reviewed by Chris Fleizach.
928
929         Added accessibility element hooks to test endTextMarkerForBounds and startTextMarkerForBounds.
930
931         * DumpRenderTree/AccessibilityUIElement.cpp:
932         (endTextMarkerForBoundsCallback):
933         (startTextMarkerForBoundsCallback):
934         (AccessibilityUIElement::endTextMarkerForBounds):
935         (AccessibilityUIElement::startTextMarkerForBounds):
936         (AccessibilityUIElement::getJSClass):
937         * DumpRenderTree/AccessibilityUIElement.h:
938         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
939         (AccessibilityUIElement::endTextMarkerForBounds):
940         (AccessibilityUIElement::startTextMarkerForBounds):
941         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
942         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
943         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
944         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
945         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
946         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
947         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
948         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
949         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
950         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
951         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
952
953 2013-10-22  Ryosuke Niwa  <rniwa@webkit.org>
954
955         There should be a way to specify additional repository paths in NRWT
956         https://bugs.webkit.org/show_bug.cgi?id=123135
957
958         Reviewed by Alexey Proskuryakov.
959
960         Added --additional-repository-name and --additional-repository-path options to NRWT.
961         These options allow us to submit addtional repository information, such as of Safari's
962         to the new flakiness dashboard.
963
964         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
965         (parse_args):
966         * Scripts/webkitpy/port/base.py:
967         (Port.repository_paths):
968
969 2013-10-22  Commit Queue  <commit-queue@webkit.org>
970
971         Unreviewed, rolling out r157774.
972         http://trac.webkit.org/changeset/157774
973         https://bugs.webkit.org/show_bug.cgi?id=123167
974
975         causes python test to fail (Requested by smfr on #webkit).
976
977         * Scripts/webkitpy/layout_tests/controllers/manager.py:
978         (Manager.run):
979         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
980         (TestExpectations.__init__):
981         (TestExpectations._add_expectations):
982         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
983         (parse_args):
984         (_set_up_derived_options):
985
986 2013-10-22  Lucas Forschler  <lforschler@apple.com>
987
988         Prepare WebKit Buildbot master for Mavericks.
989         This adds the following bot configurations:
990             Mavericks Release/Debug builders
991             Mavericks Release/Debug WK1 Testers
992             Mavericks Release/Debug WK2 Testers
993
994         Unreviewed.
995         
996         * BuildSlaveSupport/build.webkit.org-config/config.json:
997
998 2013-10-21  Tamas Gergely  <gertom@inf.u-szeged.hu>
999
1000         Run tests as if they are expected to pass when --force is given.
1001         https://bugs.webkit.org/show_bug.cgi?id=112890
1002
1003         Reviewed by Ryosuke Niwa.
1004
1005         The --force switch of new-run-webkit-tests is now forces all tests to
1006         be run with 'PASS' as expected result.
1007
1008         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1009         (Manager.run):
1010         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1011         (TestExpectations.__init__):
1012         (TestExpectations._add_expectations):
1013         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1014         (parse_args):
1015         (_set_up_derived_options):
1016
1017 2013-10-21  Mark Rowe  <mrowe@apple.com>
1018
1019         Add a version of WebKitSystemInterface for Mavericks.
1020
1021         Reviewed by Ryosuke Niwa.
1022
1023         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1024         * Scripts/copy-webkitlibraries-to-product-directory:
1025         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1026
1027 2013-10-21  Anders Carlsson  <andersca@apple.com>
1028
1029         Navigation policy callback not called when performing the same fragment navigation twice
1030         https://bugs.webkit.org/show_bug.cgi?id=123121
1031         <rdar://problem/15230466>
1032
1033         Reviewed by Beth Dakin.
1034
1035         Add a test.
1036
1037         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1038         * TestWebKitAPI/Tests/mac/FragmentNavigation.html: Added.
1039         * TestWebKitAPI/Tests/mac/FragmentNavigation.mm: Added.
1040         (+[WebKit1FragmentNavigationTestDelegate shared]):
1041         (-[WebKit1FragmentNavigationTestDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
1042         (-[WebKit1FragmentNavigationTestDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
1043         (-[WebKit1FragmentNavigationTestDelegate webView:didFinishLoadForFrame:]):
1044         (-[WebKit1FragmentNavigationTestDelegate _runNextTestWithWebView:]):
1045         (TestWebKitAPI::TEST):
1046
1047 2013-10-21  Dan Bernstein  <mitz@apple.com>
1048
1049         Style checker should allow a space after the @property keyword
1050         https://bugs.webkit.org/show_bug.cgi?id=123117
1051
1052         Reviewed by Anders Carlsson.
1053
1054         * Scripts/webkitpy/style/checkers/cpp.py:
1055         (check_spacing_for_function_call): Allow a space between @property and the following (
1056         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1057         (CppStyleTest.test_spacing_for_fncall): Added a test case.
1058
1059 2013-10-21  peavo@outlook.com  <peavo@outlook.com>
1060
1061         [WinCairo] Build does not start.
1062         https://bugs.webkit.org/show_bug.cgi?id=123059
1063
1064         Reviewed by Csaba Osztrogonác.
1065
1066         The function isAppleWinWebKit() does no longer return true for WinCairo, need to add isWinCairo() checks instead.
1067
1068         * Scripts/build-webkit:
1069
1070 2013-10-21  Zan Dobersek  <zdobersek@igalia.com>
1071
1072         [Jhbuild] Bump the required Jhbuild revision
1073         https://bugs.webkit.org/show_bug.cgi?id=123089
1074
1075         Reviewed by Carlos Garcia Campos.
1076
1077         * jhbuild/jhbuild-wrapper: Latest versions of the gnome-common tools produce failures when configuring Jhbuild
1078         due to the configure.ac script using both IT_PROG_INTLTOOL and AM_GNU_GETTEXT macros. This is already fixed
1079         in the Jhbuild source so a more recent revision of it should be used.
1080
1081 2013-10-19  Alexey Proskuryakov  <ap@apple.com>
1082
1083         Mac build fix.
1084
1085         * DumpRenderTree/mac/DumpRenderTree.mm: Cast the length for %lu specifier.
1086
1087 2013-10-19  Alexey Proskuryakov  <ap@apple.com>
1088
1089         Enable webaudio/ tests on DRT/Mac
1090         https://bugs.webkit.org/show_bug.cgi?id=86914
1091
1092         Reviewed by Darin Adler.
1093
1094         * DumpRenderTree/ForwardingHeaders/runtime/ArrayBufferView.h: Copied from Source/WebCore/ForwardingHeaders/runtime/ArrayBufferView.h.
1095         * DumpRenderTree/ForwardingHeaders/runtime/JSArrayBufferView.h: Copied from Source/WebCore/ForwardingHeaders/runtime/JSArrayBufferView.h.
1096         * DumpRenderTree/ForwardingHeaders/runtime/TypedArrayInlines.h: Copied from Source/WebCore/ForwardingHeaders/runtime/TypedArrayInlines.h.
1097         There is no way to efficiently get TypedArray buffer using API, so we need some internal headers.
1098
1099         * DumpRenderTree/TestRunner.cpp:
1100         (setAudioResultCallback): 
1101         (TestRunner::staticFunctions):
1102         * DumpRenderTree/TestRunner.h:
1103         (TestRunner::audioResult):
1104         (TestRunner::setAudioResult):
1105         The function has a different name and argument type now, updated accordingly.
1106         Changed buffer from std::string to std::vector<char>, because it's more idiomatic.
1107
1108         * DumpRenderTree/mac/DumpRenderTree.mm:
1109         (dumpAudio): Updated for the new name of audioResult accessor.
1110         (dump): Print the result in the format webkitpy currently expects.
1111
1112         * WebKitTestRunner/TestInvocation.cpp:
1113         (WTR::TestInvocation::dumpAudio): fwrite the whole block at once, splitting into
1114         chunks made no sense.
1115
1116         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1117         (WTR::TestRunner::setAudioResult): Added a FIXME about getting off WKBundle SPI.
1118
1119         * DumpRenderTree/CMakeLists.txt: Added JavaScriptCore/parser to include search list,
1120         so that "SourceProvider.h" can be found.
1121
1122 2013-10-19  Ryosuke Niwa  <rniwa@webkit.org>
1123
1124         run-webkit-tests should submit time and modifiers to the new flakiness dashboard
1125         https://bugs.webkit.org/show_bug.cgi?id=123070
1126
1127         Reviewed by Alexey Proskuryakov.
1128
1129         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1130         (Manager.run):
1131         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1132         (summarize_results): Added include_time_and_modifiers. Report test_run_time and modifiers
1133         in the test expectations when this argument is set to true.
1134
1135 2013-10-19  Alexey Proskuryakov  <ap@apple.com>
1136
1137         Mac DumpRenderTree builds without NDEBUG even in release mode
1138         https://bugs.webkit.org/show_bug.cgi?id=123066
1139
1140         Reviewed by Dan Bernstein.
1141
1142         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1143         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1144         Use the same pattern as WebCore and WebKitTestRunner.
1145
1146 2013-10-19  Zan Dobersek  <zdobersek@igalia.com>
1147
1148         REGRESSION(r155373): Mac WK2 EWS bots is actually Mac WK1 debug
1149         https://bugs.webkit.org/show_bug.cgi?id=123064
1150
1151         Reviewed by Ryosuke Niwa.
1152
1153         Revert r155373 as it is causing incorrect port/platform deduction for the Mac EWS systems.
1154
1155         * Scripts/webkitpy/common/config/ports.py: Added.
1156         (DeprecatedPort):
1157         (DeprecatedPort.name):
1158         (DeprecatedPort.flag):
1159         (DeprecatedPort.script_path):
1160         (DeprecatedPort.script_shell_command):
1161         (DeprecatedPort.port):
1162         (DeprecatedPort.makeArgs):
1163         (DeprecatedPort.update_webkit_command):
1164         (DeprecatedPort.check_webkit_style_command):
1165         (DeprecatedPort.prepare_changelog_command):
1166         (DeprecatedPort.build_webkit_command):
1167         (DeprecatedPort.run_javascriptcore_tests_command):
1168         (DeprecatedPort.run_webkit_unit_tests_command):
1169         (DeprecatedPort.run_webkit_tests_command):
1170         (DeprecatedPort.run_python_unittests_command):
1171         (DeprecatedPort.run_perl_unittests_command):
1172         (DeprecatedPort.run_bindings_tests_command):
1173         (MacPort):
1174         (MacWK2Port):
1175         (MacWK2Port.run_webkit_tests_command):
1176         (WinPort):
1177         (WinPort.run_bindings_tests_command):
1178         (GtkPort):
1179         (GtkPort.build_webkit_command):
1180         (GtkPort.run_webkit_tests_command):
1181         (GtkWK2Port):
1182         (GtkWK2Port.build_webkit_command):
1183         (GtkWK2Port.run_webkit_tests_command):
1184         (QtPort):
1185         (QtPort.build_webkit_command):
1186         (QtPort.run_webkit_tests_command):
1187         (QtWK2Port):
1188         (QtWK2Port.build_webkit_command):
1189         (QtWK2Port.run_webkit_tests_command):
1190         (EflPort):
1191         (EflPort.build_webkit_command):
1192         (EflWK2Port):
1193         (EflWK2Port.build_webkit_command):
1194         * Scripts/webkitpy/common/config/ports_mock.py: Added.
1195         (MockPort):
1196         (MockPort.name):
1197         (MockPort.check_webkit_style_command):
1198         (MockPort.update_webkit_command):
1199         (MockPort.build_webkit_command):
1200         (MockPort.prepare_changelog_command):
1201         (MockPort.run_python_unittests_command):
1202         (MockPort.run_perl_unittests_command):
1203         (MockPort.run_javascriptcore_tests_command):
1204         (MockPort.run_webkit_unit_tests_command):
1205         (MockPort.run_webkit_tests_command):
1206         (MockPort.run_bindings_tests_command):
1207         * Scripts/webkitpy/common/config/ports_unittest.py: Added.
1208         (DeprecatedPortTest):
1209         (DeprecatedPortTest.test_mac_port):
1210         (DeprecatedPortTest.test_gtk_port):
1211         (DeprecatedPortTest.test_gtk_wk2_port):
1212         (DeprecatedPortTest.test_efl_port):
1213         (DeprecatedPortTest.test_qt_port):
1214         (DeprecatedPortTest.test_qt_wk2_port):
1215         * Scripts/webkitpy/port/base.py:
1216         (Port._port_flag_for_scripts):
1217         (Port._wk2_port_name):
1218         * Scripts/webkitpy/port/base_unittest.py:
1219         (PortTest.test_build_path):
1220         * Scripts/webkitpy/port/efl_unittest.py:
1221         (EflPortTest.test_show_results_html_file):
1222         * Scripts/webkitpy/port/gtk_unittest.py:
1223         (GtkPortTest.test_get_crash_log):
1224         * Scripts/webkitpy/port/mac_unittest.py:
1225         (test_64bit):
1226         * Scripts/webkitpy/port/test.py:
1227         (TestPort.virtual_test_suites):
1228         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1229         (FlakyTestReporter.__init__):
1230         * Scripts/webkitpy/tool/bot/irc_command.py:
1231         (Rollout._update_working_copy):
1232         * Scripts/webkitpy/tool/commands/download_unittest.py:
1233         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1234         (AbstractEarlyWarningSystem.run_command):
1235         * Scripts/webkitpy/tool/commands/queues.py:
1236         (PatchProcessingQueue.begin_work_queue):
1237         (CommitQueue.run_command):
1238         * Scripts/webkitpy/tool/main.py:
1239         (WebKitPatch.__init__):
1240         (WebKitPatch.deprecated_port):
1241         (WebKitPatch.handle_global_options):
1242         * Scripts/webkitpy/tool/mocktool.py:
1243         (MockTool.__init__):
1244         (MockTool.deprecated_port):
1245         * Scripts/webkitpy/tool/steps/build.py:
1246         (Build.build):
1247         * Scripts/webkitpy/tool/steps/checkstyle.py:
1248         (CheckStyle.run):
1249         * Scripts/webkitpy/tool/steps/commit.py:
1250         (Commit._check_test_expectations):
1251         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1252         (PrepareChangeLog.run):
1253         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1254         (PrepareChangeLogForRevert.run):
1255         * Scripts/webkitpy/tool/steps/runtests.py:
1256         (RunTests.run):
1257         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1258         (RunTestsTest.test_webkit_run_unit_tests):
1259         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1260         (StepsTest.test_runtests_args):
1261         * Scripts/webkitpy/tool/steps/update.py:
1262         (Update._update_command):
1263         * Scripts/webkitpy/tool/steps/update_unittest.py:
1264         (UpdateTest.test_update_command_non_interactive):
1265         (UpdateTest.test_update_command_interactive):
1266
1267 2013-10-19  Andreas Kling  <akling@apple.com>
1268
1269         RefPtr::releaseNonNull() incorrectly increments the refcount.
1270         <https://webkit.org/b/123063>
1271
1272         Add an API test to verify that no extra refs are added when calling
1273         RefPtr::releaseNonNull().
1274
1275         Reviewed by Anders Carlsson.
1276
1277 2013-10-18  Rik Cabanier <cabanier@adobe.com>
1278         Add Rik Cabanier to list of committers
1279         https://bugs.webkit.org/show_bug.cgi?id=123031
1280
1281         reviewed by Dirk Schulze.
1282
1283         * Tools/Scripts/webkitpy/common/config/contributors.json: Added name.
1284
1285 2013-10-18  Denis Nomiyama  <d.nomiyama@samsung.com>
1286
1287         [ATK] Fix invalid signal to set objects to an unknown state "layout-complete"
1288         https://bugs.webkit.org/show_bug.cgi?id=122970
1289
1290         Reviewed by Mario Sanchez Prada.
1291
1292         Removed an invalid signal to set an object state to layout-complete
1293         that does not exist. It was replaced by ATK:AtkDocument:load-complete.
1294
1295         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
1296         (axObjectEventListener): Replaced layout-complete with load-complete.
1297         (connectAccessibilityCallbacks): Connect callback to new listener for
1298         ATK:AtkDocument:load-complete.
1299         (disconnectAccessibilityCallbacks): Disconnect callback to new listener
1300         for ATK:AtkDocument:load-complete.
1301         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1302         (axObjectEventListener): Replaced layout-complete with load-complete.
1303         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
1304         Connect callback to new listener for ATK:AtkDocument:load-complete.
1305         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
1306         Disconnect callback to new listener for ATK:AtkDocument:load-complete.
1307
1308 2013-10-18  Carlos Garcia Campos  <cgarcia@igalia.com>
1309
1310         [GTK] Generate API documentation for GObject DOM bindings
1311         https://bugs.webkit.org/show_bug.cgi?id=121538
1312
1313         Reviewed by Gustavo Noronha Silva.
1314
1315         The .symbols file that is now generated for checking GObject DOM
1316         bindings API compatibility while building can also be used to
1317         generate the files needed to produce the gtk-doc
1318         documentation. The new script generate-webkitdom-doc-files can
1319         generate the docs.sgml and sections.txt files from the given list
1320         of .symbols files.
1321
1322         * gtk/GNUmakefile.am: Add rules to generate webkitdomgtk-docs.sgml
1323         and webkitdomgtk-sections.txt as well as rules to install the
1324         generated WebKitDOMGTK documentation.
1325         * gtk/generate-gtkdoc:
1326         (webkitdom_docs_html_path): New helper function that returns the
1327         path where the DOM API documentation has been generated.
1328         (get_webkit2_options): Include DOM API docs to the list of xref
1329         dependencies.
1330         (get_webkit1_options): Ditto.
1331         (get_webkitdom_options): Return the gtk-doc options to generate
1332         the DOM API docs.
1333         (get_webkitdom_options.derived_sources_path):
1334         (get_webkitdom_options.src_path):
1335         * gtk/generate-webkitdom-doc-files: Added.
1336         (WebKitDOMDocGenerator):
1337         (WebKitDOMDocGenerator.write_header):
1338         (WebKitDOMDocGenerator.write_section):
1339         (WebKitDOMDocGenerator.write_footer):
1340         (WebKitDOMDocGeneratorDocs):
1341         (WebKitDOMDocGeneratorDocs.write_header):
1342         (write_section):
1343         (write_footer):
1344         (WebKitDOMDocGeneratorSections):
1345         (WebKitDOMDocGeneratorSections.__init__):
1346         (WebKitDOMDocGeneratorSections._dom_class):
1347         (WebKitDOMDocGeneratorSections._dom_class_decamelize):
1348         (WebKitDOMDocGeneratorSections._symbol_list):
1349         (WebKitDOMDocGeneratorSections.write_section):
1350
1351 2013-10-17  Alex Christensen  <achristensen@webkit.org>
1352
1353         Run JavaScriptCore tests again on Windows.
1354         https://bugs.webkit.org/show_bug.cgi?id=122787
1355
1356         Reviewed by Tim Horton.
1357
1358         * Scripts/build-jsc:
1359         (buildMyProject): Use JavaScriptCore.sln to build JavaScriptCore and WTF.
1360         * Scripts/run-javascriptcore-tests: Don't run stress tests on WinCairo.
1361         * Scripts/webkitdirs.pm:
1362         (determineConfigurationForVisualStudio):
1363         (determineConfigurationProductDir):
1364         Build directory should end with bin64 and configuration should end with |x64 on Win64.
1365         (isAppleWinWebKit):
1366         (copyInspectorFrontendFiles):
1367         (setPathForRunningWebKitApp):
1368         Separated WinCairo directories and options from AppleWin.
1369
1370 2013-10-17  Mihnea Ovidenie  <mihnea@adobe.com>
1371
1372         Unreviewed. Add myself as a reviewer.
1373
1374         * Scripts/webkitpy/common/config/contributors.json:
1375
1376 2013-10-17  Andreas Kling  <akling@apple.com>
1377
1378         Make it possible to assign a PassRef to a RefPtr.
1379         <https://webkit.org/b/122943>
1380
1381         Added a small API test for RefPtr=(PassRef) so we know this code
1382         will compile (and work.)
1383
1384         Reviewed by Antti Koivisto.
1385
1386 2013-10-16  Filip Pizlo  <fpizlo@apple.com>
1387
1388         We need test coverage for just the Baseline JIT
1389         https://bugs.webkit.org/show_bug.cgi?id=122929
1390
1391         Reviewed by Sam Weinig.
1392         
1393         Adds no-LLInt versions of all tests. For the Mozilla tests, also add a BaselineJIT-only
1394         variant.
1395
1396         * Scripts/run-jsc-stress-tests:
1397
1398 2013-10-16  Ryosuke Niwa  <rniwa@webkit.org>
1399
1400         Support multiple repositories in submitting results to --results-server-host
1401         https://bugs.webkit.org/show_bug.cgi?id=122935
1402
1403         Reviewed by Anders Carlsson.
1404
1405         Remoevd --got-revision and added the logic to extract revision information
1406         from multiple repositories as done in run-perf-tests.
1407
1408         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1409         (Manager.upload_results):
1410         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1411         (parse_args):
1412
1413 2013-10-16  Darin Adler  <darin@apple.com>
1414
1415         Add PassRef and createRefCounted so we can improve creation of RefCounted objects
1416         https://bugs.webkit.org/show_bug.cgi?id=122904
1417
1418         Reviewed by Anders Carlsson.
1419
1420         * TestWebKitAPI/Tests/WTF/Ref.cpp: Added some basic tests for adoptRef and PassRef.
1421
1422 2013-10-16  Darin Adler  <darin@apple.com>
1423
1424         Need tests for RefPtr self-assignment and self-move-assignment.
1425
1426         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Added tests.
1427
1428 2013-10-16  Robert Plociennik  <r.plociennik@samsung.com>
1429
1430         [EFL] Minibrowser can't load child window's location
1431         https://bugs.webkit.org/show_bug.cgi?id=122485
1432
1433         Reviewed by Gyuyoung Kim.
1434
1435         * MiniBrowser/efl/main.c: Now calling window_create() without the url parameter
1436             followed by an explicit call to ewk_view_url_set() where appropriate.
1437         (on_key_down):
1438         (on_window_create):
1439         (window_create):
1440         (elm_main):
1441
1442 2013-10-15  Sergio Correia  <sergio.correia@openbossa.org>
1443
1444         [EFL][WK2] Make SeccompFilters build again after r156349 and r156353
1445         https://bugs.webkit.org/show_bug.cgi?id=122872
1446
1447         Reviewed by Anders Carlsson.
1448
1449         * TestWebKitAPI/PlatformEfl.cmake: Mark SeccompFilters API test as
1450         failing.
1451
1452 2013-10-15  Dean Jackson  <dino@apple.com>
1453
1454         Add ENABLE_WEB_ANIMATIONS flag
1455         https://bugs.webkit.org/show_bug.cgi?id=122871
1456
1457         Reviewed by Tim Horton.
1458
1459         Eventually might be http://dev.w3.org/fxtf/web-animations/
1460         but this is just engine-internal work at the moment.
1461
1462         * Scripts/webkitperl/FeatureList.pm:
1463
1464 2013-10-15  Darin Adler  <darin@apple.com>
1465
1466         Add some API tests for Vector, RefPtr, and Ref
1467         https://bugs.webkit.org/show_bug.cgi?id=122840
1468
1469         Reviewed by Andreas Kling.
1470
1471         * TestWebKitAPI/CMakeLists.txt: Added new files.
1472         * TestWebKitAPI/GNUmakefile.am: Ditto.
1473         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
1474         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
1475         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
1476
1477         * TestWebKitAPI/Tests/WTF/Ref.cpp: Added.
1478         * TestWebKitAPI/Tests/WTF/RefLogger.h: Added.
1479         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Added.
1480         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added move-only insert tests.
1481
1482 2013-10-14  Roger Fong  <roger_fong@apple.com>
1483
1484         Adding myself to CC list for some components.
1485
1486         * Scripts/webkitpy/common/config/watchlist:
1487
1488 2013-10-13  Darin Adler  <darin@apple.com>
1489
1490         Deprecate or remove deleteAllValues functions; there are only a few call sites left
1491         https://bugs.webkit.org/show_bug.cgi?id=122738
1492
1493         Reviewed by Anders Carlsson.
1494
1495         * DumpRenderTree/win/DRTDataObject.cpp:
1496         (DRTDataObject::~DRTDataObject):
1497         * DumpRenderTree/win/UIDelegate.cpp:
1498         (DRTUndoStack::~DRTUndoStack):
1499         (DRTUndoStack::clear):
1500         Renamed deleteAllValues to deprecatedDeleteAllValues.
1501
1502         * Scripts/do-webcore-rename: Updated to perform this rename, as is traditional.
1503
1504 2013-10-13  Alexey Proskuryakov  <ap@apple.com>
1505
1506         build.webkit.org/dashboard incorrectly shows interrupted builds as green
1507         https://bugs.webkit.org/show_bug.cgi?id=122732
1508
1509         Reviewed by Tim Hatcher.
1510
1511         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1512         (BuildbotIteration.prototype.update): Removed a special case for status 4 (EXCEPTION).
1513         I don't see it occur any time in recent history, but judging from what happens for
1514         status 5 (RETRY), we can just finish this function normally.
1515         Record overall text description for iteration as BuildbotIteration.text.
1516
1517         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1518         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): If an iteration is a failure,
1519         but no tests failed, make it yellow, and use buildbot-provided description for it.
1520
1521 2013-10-13  Alexey Proskuryakov  <ap@apple.com>
1522
1523         Remove Chromium specific code from flakiness dashboard
1524         https://bugs.webkit.org/show_bug.cgi?id=122714
1525
1526         Reviewed by Sam Weinig.
1527
1528         Also removed code related to GPU tests and virtual suites.
1529         "Fallbacks map" was chromium only too, not sure why they needed special handling there.
1530
1531         * TestResultServer/model/jsonresults_unittest.py:
1532         * TestResultServer/static-dashboards/builders.js:
1533         * TestResultServer/static-dashboards/dashboard_base.js:
1534         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1535         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1536         * TestResultServer/static-dashboards/flakiness_dashboard_tests.css:
1537         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1538         * TestResultServer/static-dashboards/history.js:
1539         * TestResultServer/static-dashboards/loader.js:
1540         * TestResultServer/static-dashboards/ui.js:
1541         * TestResultServer/templates/uploadform.html:
1542
1543 2013-10-11  Timothy Hatcher  <timothy@apple.com>
1544
1545         Remove preference support for picking the old Web Inspector.
1546         https://bugs.webkit.org/show_bug.cgi?id=122655
1547
1548         Reviewed by Alexey Proskuryakov.
1549
1550         * WebKitTestRunner/TestController.cpp:
1551         (WTR::TestController::resetStateToConsistentValues):
1552
1553 2013-10-11  Filip Pizlo  <fpizlo@apple.com>
1554
1555         Fix 64-bit build on everything but Windows.
1556
1557         Rubber stamped by Brent Fulgham.
1558
1559         * Scripts/webkitdirs.pm:
1560         (argumentsForConfiguration):
1561
1562 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
1563
1564         Touch a file to see how auto-update works.
1565
1566         Rubber-stamped by Tim Hatcher.
1567
1568         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1569
1570 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
1571
1572         LeaksViewer fails to present recent results list if current build is still updating svn
1573         https://bugs.webkit.org/show_bug.cgi?id=122670
1574
1575         Fixed an obvious mistake in the previous patch.
1576
1577         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1578         (RecentBuildsLoader.prototype.start):
1579
1580 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
1581
1582         LeaksViewer fails to present recent results list if current build is still updating svn
1583         https://bugs.webkit.org/show_bug.cgi?id=122670
1584
1585         Reviewed by Adam Roben.
1586
1587         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1588         (RecentBuildsLoader.prototype.start): Skip builds that don't have an svn revision yet.
1589
1590 2013-10-11  Brent Fulgham  <bfulgham@apple.com>
1591
1592         Unreviewed build fix for --64-bit target.
1593
1594         * Scripts/webkitdirs.pm:
1595         (argumentsForConfiguration): Use 'isWin64' test, since @ARGV value may have
1596         been removed by this point.
1597         (hasArgument): Remove unused temporary.
1598
1599 2013-10-10  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1600
1601         webkit-patch failure-reason has a quite low limit for 'too many failures'
1602         https://bugs.webkit.org/show_bug.cgi?id=122556
1603
1604         Reviewed by Darin Adler.
1605
1606         * Scripts/webkitpy/tool/commands/queries.py:
1607         (FailureReason._explain_failures_for_builder): adjust the number of too many failures
1608         to match what the layout test runners use these days.
1609
1610 2013-10-10  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1611
1612         webkit-patch failure-reason should allow specifying failures one is interested in
1613         https://bugs.webkit.org/show_bug.cgi?id=122554
1614
1615         Reviewed by Darin Adler.
1616
1617         * Scripts/webkitpy/tool/commands/queries.py:
1618         (FailureReason):
1619         (FailureReason._explain_failures_for_builder): keep track of explained failures and drop out of the
1620         loop if the ones we're interested in been explained.
1621         (FailureReason._done_explaining): check the failures we're interested in have been explained, if any.
1622         (FailureReason.execute): initialize failures to explain and the explained set.
1623
1624 2013-10-10  Filip Pizlo  <fpizlo@apple.com>
1625
1626         Make sure that DataTypes.h is in the binary drop.
1627
1628         Rubber stamped by Michael Saboff.
1629
1630         * Scripts/export-llvm-build:
1631
1632 2013-10-10  Filip Pizlo  <fpizlo@apple.com>
1633
1634         FTL: Soft-link LLVM as a workaround for LLVM's static initializers and exit-time destructors
1635         https://bugs.webkit.org/show_bug.cgi?id=122566
1636
1637         Reviewed by Mark Rowe.
1638
1639         * Scripts/configure-llvm:
1640
1641 2013-10-10  Mark Rowe  <mrowe@apple.com>
1642
1643         <rdar://problem/13341666> WebKit should always build against an SDK.
1644
1645         Have all projects default to building against the OS X Internal SDK for the Production
1646         configuration. For the Debug and Release configurations, look for UseInternalSDK.xcconfig
1647         to determine whether the OS X Internal SDK should be used. If not, use the normal OS X SDK.
1648
1649         Reviewed by Dan Bernstein.
1650
1651         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1652         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1653         * MiniBrowser/Configurations/Base.xcconfig:
1654         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1655         * TestWebKitAPI/Configurations/Base.xcconfig:
1656         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1657         * WebKitTestRunner/Configurations/Base.xcconfig:
1658         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1659
1660 2013-10-10  Gustavo Noronha Silva  <gns@gnome.org>
1661
1662         Unreviewed gardening, the inspector protocol timeouts are also affecting TestInspectorServer.
1663
1664         * Scripts/run-gtk-tests:
1665         (TestRunner): skip TestInspectorServer.
1666
1667 2013-10-10  Andres Gomez  <agomez@igalia.com>
1668
1669         [GTK] Provide search functionality to MiniBrowser
1670         https://bugs.webkit.org/show_bug.cgi?id=117631
1671
1672         Reviewed by Carlos Garcia Campos.
1673
1674         Adds a search bar to MiniBrowser with the minimum functionality
1675         and a new button to the toolbar for showing the new search
1676         bar. Typical keyboard shortcuts are also added.
1677
1678         * MiniBrowser/gtk/BrowserSearchBar.c: Added.
1679         (doSearch):
1680         (searchNext):
1681         (searchPrevious):
1682         (searchCloseButtonClickedCallback):
1683         (searchEntryMenuIconPressedCallback):
1684         (searchEntryClearIconReleasedCallback):
1685         (searchEntryChangedCallback):
1686         (searchEntryActivatedCallback):
1687         (searchPrevButtonClickedCallback):
1688         (searchNextButtonClickedCallback):
1689         (searchMenuCheckButtonToggledCallback):
1690         (browser_search_bar_init):
1691         (browserSearchBarFinalize):
1692         (browser_search_bar_class_init):
1693         (browser_search_bar_new):
1694         (browser_search_bar_add_accelerators):
1695         (browser_search_bar_open):
1696         (browser_search_bar_close):
1697         * MiniBrowser/gtk/BrowserSearchBar.h: Added.
1698         * MiniBrowser/gtk/BrowserWindow.c:
1699         (webViewEnterFullScreen): Closes new search bar.
1700         (webViewLeaveFullScreen): Opens new search bar if previously
1701         visible.
1702         (searchCallback): Added. Shows and hides the new search bar.
1703         (browser_window_init): Added search button to the toolbar.
1704         (browserWindowConstructed): Creates the new search bar.
1705         * MiniBrowser/gtk/GNUmakefile.am: Added new files to compilation.
1706
1707 2013-10-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1708
1709         webkit-patch failure-reason fails with UnicodeDecodeError when name has non-ascii characters
1710         https://bugs.webkit.org/show_bug.cgi?id=122552
1711
1712         Reviewed by Darin Adler.
1713
1714         * Scripts/webkitpy/common/checkout/commitinfo.py:
1715         (CommitInfo.blame_string): ensure objects are made into unicode strings, not regular ones that
1716         will cause UnicodeDecodeError for non-ascii characters.
1717
1718 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
1719
1720         Would like a link to dashboard from build.webkit.org main page
1721         https://bugs.webkit.org/show_bug.cgi?id=122577
1722
1723         Reviewed by Tim Hatcher.
1724
1725         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added.
1726
1727 2013-10-09  Brent Fulgham  <bfulgham@apple.com>
1728
1729         [Win] Check for MathML fonts and warn user if they are missing.
1730         https://bugs.webkit.org/show_bug.cgi?id=122568
1731
1732         Reviewed by Tim Horton.
1733
1734         * Scripts/webkitdirs.pm:
1735         (checkRequiredSystemConfig): Use common gperf/bison/flex tests, rather than
1736         Windows-specific code I added previously.
1737         (fontExists): Added
1738         (checkInstalledTools): Add check for MathML fonts.
1739
1740 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
1741
1742         http://build.webkit.org/dashboard/ doesn't link to webkitpy failures
1743         https://bugs.webkit.org/show_bug.cgi?id=122471
1744
1745         Reviewed by Tim Hatcher.
1746
1747         Added links to webkitpy, webkitperl and bindings-tests results.
1748
1749         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1750         (Buildbot.prototype.apiTestResultsURLForIteration):
1751         (Buildbot.prototype.webkitpyTestResultsURLForIteration):
1752         (Buildbot.prototype.webkitperlTestResultsURLForIteration):
1753         (Buildbot.prototype.bindingsTestResultsURLForIteration):
1754         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1755         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1756
1757 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
1758
1759         Move some functions from WebKitBuildbot to Buildbot class.
1760
1761         Suggested by Tim Hatcher.
1762
1763         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1764         (Buildbot.prototype.javascriptTestResultsURLForIteration):
1765         (Buildbot.prototype.apiTestResultsURLForIteration):
1766         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1767         (WebKitBuildbot.prototype.layoutTestResultsURLForIteration):
1768
1769 2013-10-09  Timothy Hatcher  <timothy@apple.com>
1770
1771         Add API tests to the Dashbord page.
1772
1773         https://bugs.webkit.org/show_bug.cgi?id=122283
1774
1775         Reviewed by Timothy Hatcher.
1776
1777         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1778         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1779         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1780         (WebKitBuildbot.prototype.apiTestResultsURLForIteration):
1781
1782 2013-10-09  Timothy Hatcher  <timothy@apple.com>
1783
1784         Attempt to fix faulty Dashboard iteration updating by always rebuilding test result objects.
1785
1786         https://bugs.webkit.org/show_bug.cgi?id=122515
1787
1788         Reviewed by Alexey Proskuryakov.
1789
1790         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1791         (BuildbotIteration.prototype.update):
1792
1793 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
1794
1795         build.webkit.org/dashboard doesn't provide a results link when there issues at multiple steps
1796         https://bugs.webkit.org/show_bug.cgi?id=122573
1797
1798         Reviewed by Tim Hatcher.
1799
1800         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1801         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Provide a URL.
1802
1803         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1804         (Buildbot.prototype.buildPageURLForIteration): Added.
1805
1806 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
1807
1808         http://build.webkit.org/dashboard/ links to a wrong jscore-test results page
1809         https://bugs.webkit.org/show_bug.cgi?id=122569
1810
1811         Reviewed by Tim Hatcher.
1812
1813         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1814         (WebKitBuildbot.prototype.javascriptTestResultsURLForIteration): "actual.html" used
1815         to be produced by the old Mozilla test harness that we don't use any more.
1816
1817 2013-10-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1818
1819         Add GTK 64 bits release to the buildbot dashboard
1820         https://bugs.webkit.org/show_bug.cgi?id=122548
1821
1822         Reviewed by Darin Adler.
1823
1824         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png: Added.
1825         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1826         (WebKitBuildbot): add 64 bits release wk2 and wk1 testers.
1827         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1828         (table.queue-grid tr.platform.linux-gtk img.logo): use the GTK+ logo in its dashboard line.
1829
1830 2013-10-09  Mario Sanchez Prada  <mario.prada@samsung.com>
1831
1832         [ATK] Implement new API in AtkText: atk_text_get_string_at_offset()
1833         https://bugs.webkit.org/show_bug.cgi?id=120638
1834
1835         Reviewed by Gustavo Noronha Silva.
1836
1837         * gtk/jhbuild.modules: Raised ATK and AT-SPI versions to 2.10.0, so we
1838         can check both the old and new APIs to retrieve text at a given offset.
1839
1840 2013-10-08  Alex Christensen  <achristensen@webkit.org>
1841
1842         Improved WinLauncher.
1843         https://bugs.webkit.org/show_bug.cgi?id=122536
1844
1845         Reviewed by Brent Fulgham.
1846
1847         * WinLauncher/PrintWebUIDelegate.cpp:
1848         (PrintWebUIDelegate::runJavaScriptAlertPanelWithMessage): Added.
1849         (PrintWebUIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
1850         * WinLauncher/PrintWebUIDelegate.h: Removed stubs.
1851         * WinLauncher/WinLauncher.cpp:
1852         (createCrashReport): Use the executable name instead of "WinLauncher".
1853         * WinLauncher/WinLauncher.vcxproj/WinLauncher.exe.manifest: Removed.
1854         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link to Wininet.lib.
1855         * win/DLLLauncher/DLLLauncherMain.cpp: Remove VS2005 dependency for WinCairo.
1856
1857 2013-10-08  Mark Lam  <mark.lam@apple.com>
1858
1859         Fix ruby LoadError when running run-javascriptcore-tests.
1860         https://bugs.webkit.org/show_bug.cgi?id=122519.
1861
1862         Reviewed by Mark Hahnenberg.
1863
1864         The scripts needed to explicitly require 'rubygems' for older versions of ruby
1865         (versions before 1.9).
1866
1867         * Scripts/jsc-stress-test-helpers/profiler-test-helper:
1868         * Scripts/run-jsc-stress-tests:
1869
1870 2013-10-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1871
1872         Unreviewed, add my new email to contributors.json.
1873
1874         * Scripts/webkitpy/common/config/contributors.json:
1875
1876 2013-10-08  Brent Fulgham  <bfulgham@apple.com>
1877
1878         Unreviewed build correction.
1879
1880         * Scripts/webkitpy/port/win.py:
1881         (WinPort.write_registry_value): Use string representation of error message to avoid
1882         format conversion problem.
1883
1884 2013-10-07  Brent Fulgham  <bfulgham@apple.com>
1885
1886         [Win] Add checks for proper build and test environment
1887         https://bugs.webkit.org/show_bug.cgi?id=122466
1888
1889         Reviewed by Darin Adler.
1890
1891         This patch makes two changes:
1892         1. Update webkitdirs.pm to check for some common misconfigurations and provide helpful warnings or
1893            error messages so that people know what to fix to get things working.
1894         2. Modify the win.py port to handle the 32-bit and 64-bit test environments, as well as making sure
1895            the various environment settings are properly configured for our test environment.
1896
1897         * Scripts/webkitdirs.pm:
1898         (checkInstalledTools): Add checks for some common Cygwin configuration problems that have
1899         caused problems in the past.
1900         (setupAppleWinEnv):
1901         * Scripts/webkitpy/port/win.py:
1902         (WinPort):
1903         (WinPort.read_registry_string): Parameterize for run architecture and registry root.
1904         (WinPort.write_registry_value): Parameterize registry writing by data type (string versus
1905         DWORD, etc.)
1906         (WinPort.write_registry_string): Revise to call new generic registry write function.
1907         (WinPort.setup_crash_log_saving): Revise for new API
1908         (WinPort.restore_crash_log_saving): Ditto
1909         (WinPort.prevent_error_dialogs): Add new methods to prevent Windows dialogs that block our test
1910         servers from running.
1911         (WinPort.allow_error_dialogs): Ditto.
1912         (WinPort.setup_test_run): Call new API to turn off user input dialogs on program failure.
1913         (WinPort.clean_up_test_run): Call new API to reactivatea user input dialogs after test run finished.
1914
1915 2013-10-08  Philippe Normand  <pnormand@igalia.com>
1916
1917         [GStreamer] enable v4l2 plugin
1918         https://bugs.webkit.org/show_bug.cgi?id=122503
1919
1920         Reviewed by Martin Robinson.
1921
1922         * gtk/jhbuild.modules: Enable the plugin, it now builds fine since
1923         we updated our GStreamer version to 1.0.8.
1924
1925 2013-10-08  Mario Sanchez Prada  <mario.prada@samsung.com>
1926
1927         [ATK] Expose state of aria-invalid as ATK_STATE_INVALID_ENTRY
1928         https://bugs.webkit.org/show_bug.cgi?id=122104
1929
1930         Reviewed by Chris Fleizach.
1931
1932         Updated stringAttributeValue to double check that the exposure of
1933         aria-invalid as a state is consistent with its exposure as a text
1934         attribute as well, when it applies (implementations of AtkText).
1935
1936         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1937         (AccessibilityUIElement::stringAttributeValue): Add double check.
1938         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1939         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
1940
1941 2013-10-07  Filip Pizlo  <fpizlo@apple.com>
1942
1943         run-jsc-stress-tests progress meter should update more quickly on older Rubies
1944         https://bugs.webkit.org/show_bug.cgi?id=122459
1945
1946         Reviewed by Darin Adler.
1947
1948         * Scripts/run-jsc-stress-tests:
1949
1950 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
1951
1952         [buildbot] parse tests that are reported as crashed correctly for GTK+
1953         https://bugs.webkit.org/show_bug.cgi?id=122476
1954
1955         Reviewed by Martin Robinson.
1956
1957         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1958         (RunGtkAPITests.commandComplete): parse the crashed tests output so that is reported
1959         as a failure of the API tests.
1960
1961 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
1962
1963         Unreviewed. Skipping API test that is causing the next one to crash,
1964         see https://bugs.webkit.org/show_bug.cgi?id=121970.
1965
1966         * Scripts/run-gtk-tests:
1967         (TestRunner):
1968
1969 2013-10-07  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1970
1971         [GTK] run-gtk-tests does not distinguish between failure and crashes
1972         https://bugs.webkit.org/show_bug.cgi?id=122135
1973
1974         Reviewed by Martin Robinson.
1975
1976         The GTK+ API test runner does not distinguish between failures and crashes. This change
1977         makes it do that, so it's easier for us to spot the more important/higher priority crash
1978         case.
1979
1980         * Scripts/run-gtk-tests:
1981         (TestRunner._run_test_command): return the exit code instead of a boolean true/false,
1982         so we have more information on how the process ended.
1983         (TestRunner._run_test): check the exit code to distinguish between crashes and failures.
1984         (TestRunner.run_tests): report crashes.
1985
1986 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
1987
1988         [GTK] Missing packages for APT on install-dependencies
1989         https://bugs.webkit.org/show_bug.cgi?id=121555
1990
1991         Reviewed by Martin Robinson.
1992
1993         * gtk/install-dependencies: add packages that are needed for
1994         building WebKit itself and the jhbuild dependencies.
1995
1996 2013-10-07  Anders Carlsson  <andersca@apple.com>
1997
1998         Fix test failures.
1999
2000         * Scripts/webkitpy/port/base.py:
2001         (Port.to.start_helper):
2002         * Scripts/webkitpy/port/mock_drt.py:
2003         (MockDRTPort.start_helper):
2004
2005 2013-10-07  Anders Carlsson  <andersca@apple.com>
2006
2007         Always force discrete mode when running layout tests
2008         https://bugs.webkit.org/show_bug.cgi?id=122465
2009
2010         Reviewed by Tim Horton.
2011
2012         This should speed up WebGL tests and hopefully prevent race conditions that may cause window server crashes from happening.
2013         
2014         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2015         Link with IOKit.
2016
2017         * DumpRenderTree/mac/LayoutTestHelper.m:
2018         (installLayoutTestColorProfile):
2019         Check installColorProfile.
2020
2021         (restoreUserColorProfile):
2022         Check installColorProfile.
2023
2024         (lockDownDiscreteGraphics):
2025         New function to force discrete graphics.
2026
2027         (main):
2028         Add '--install-color-profile' option.
2029
2030         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2031         (Manager._set_up_run):
2032         Always start the helper, but pass self._options.pixel_tests to it.
2033
2034         * Scripts/webkitpy/port/mac.py:
2035         (MacPort.start_helper):
2036         Pass --install-color-profile' to the helper if pixel_tests is true.
2037
2038 2013-10-07  Timothy Hatcher  <timothy@apple.com>
2039
2040         Properly count binding test failures as failures.
2041
2042         Fix the total for multiple failures in different steps too by avoiding undefined.
2043
2044         https://bugs.webkit.org/show_bug.cgi?id=122232
2045
2046         Reviewed by Alexey Proskuryakov.
2047
2048         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2049         (BuildbotTestResults):
2050         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2051         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2052
2053 2013-10-07  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
2054
2055         [GTK] Fails to build with jhbuild with newer system glib
2056         https://bugs.webkit.org/show_bug.cgi?id=122132
2057
2058         Reviewed by Martin Robinson.
2059
2060         Newer glib includes new symbols that some system libraries which we depend on, such as pango, have
2061         started relying on. glib is not a dependency that should change test results, and is provided in
2062         jhbuild with the intention of supporting the other bits that do, so using a newer stable release
2063         should not be an issue.
2064
2065         * gtk/jhbuild.modules:
2066
2067 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
2068
2069         run-jsc-stress-tests shouldn't print its goofy progress meter when running on the bots
2070         https://bugs.webkit.org/show_bug.cgi?id=122437
2071
2072         Reviewed by Antoine Quint.
2073
2074         * Scripts/run-jsc-stress-tests:
2075
2076 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
2077
2078         Unreviewed, fix build on old Rubies.
2079
2080         * Scripts/run-jsc-stress-tests:
2081
2082 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
2083
2084         Unified test infrastructure via the jsc shell
2085         https://bugs.webkit.org/show_bug.cgi?id=120696
2086
2087         Reviewed by Oliver Hunt.
2088         
2089         Make run-jsc-stress-tests smart enough to be able to handle different styles of test
2090         output (silent or noisy) and different styles of test failure (just bad exit code,
2091         text diff, filtering for some magical text, etc.). This allows me to get rid of the
2092         layout-test-helper. It also allows me to switch all of the old Mozilla tests to
2093         running in run-jsc-stress-tests.
2094         
2095         Also removes all of the code paths that defended against not having shellwords. Just
2096         install the shellwords gem if you want to run tests.
2097         
2098         Also removes the non-parallel test running code. No reason for it to exist anymore.
2099         
2100         This is a massive increase in test coverage. It uncovered bugs. I fixed two of them
2101         as part of this patch, and left three more as new bugzillas.
2102
2103         * Scripts/create-mozilla-js-test-list: Added.
2104         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
2105         * Scripts/jsc-stress-test-helpers/layout-test-helper: Removed.
2106         * Scripts/run-javascriptcore-tests:
2107         * Scripts/run-jsc-stress-tests:
2108
2109 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
2110
2111         run-jsc-stress-tests should be less verbose
2112         https://bugs.webkit.org/show_bug.cgi?id=122397
2113
2114         Reviewed by Sam Weinig.
2115         
2116         It now just prints something like:
2117         
2118          965/1831 ....
2119         
2120         Where the first number is the number of tests that completed, the second number is the
2121         number of tests total, and the dots are the number of tests running right now - which is
2122         useful towards the end when you're waiting for the last slow tests to finish.
2123         
2124         It will also print out the output from failing tests and it will print a line for skipped
2125         tests (to annoy you into getting them into a shape where they can be unskipped). For
2126         example, for LayoutTests, it will print just the diff, if the test fails. It's cool.
2127
2128         * Scripts/run-jsc-stress-tests:
2129
2130 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
2131
2132         Allow skipping of run-jsc-stress-tests that are configured using yaml files
2133         https://bugs.webkit.org/show_bug.cgi?id=122385
2134
2135         Reviewed by Sam Wieinig.
2136         
2137         Make tests run via YAML be able to do the parse-for-commands trick that allows
2138         us to skip tests and do other custom per-test stuff.
2139
2140         * Scripts/jsc-stress-test-helpers/layout-test-helper:
2141         * Scripts/run-jsc-stress-tests:
2142
2143 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
2144
2145         Unreviewed, fix tests on older Rubies.
2146
2147         * Scripts/run-jsc-stress-tests:
2148
2149 2013-10-05  Anders Carlsson  <andersca@apple.com>
2150
2151         Don't filter the weak symbols.
2152
2153         * Scripts/check-for-weak-vtables-and-externals:
2154
2155 2013-10-04  Filip Pizlo  <fpizlo@apple.com>
2156
2157         Have run-javascriptcore-tests run JS LayoutTests using run-jsc-stress-tests so that it runs in parallel
2158         https://bugs.webkit.org/show_bug.cgi?id=122376
2159
2160         Reviewed by Mark Hahnenberg.
2161
2162         * Scripts/jsc-stress-test-helpers/layout-test-helper: Added.
2163         * Scripts/run-javascriptcore-tests:
2164         (printThingsFound):
2165         * Scripts/run-jsc-stress-tests:
2166
2167 2013-10-04  Filip Pizlo  <fpizlo@apple.com>
2168
2169         It should be even easier to run and debug a failing JSC stress test
2170         https://bugs.webkit.org/show_bug.cgi?id=122337
2171
2172         Reviewed by Oliver Hunt.
2173         
2174         If a test fails, you can now just say:
2175
2176         sh WebKitBuild/Debug/jsc-stress-results/regress/script-tests/emscripten-cube2hash.js.ftl-eager-no-cjit
2177
2178         and get the reproduction. You don't have to set any environment variables like before.
2179         Also if you want to debug the failing test you can now just say:
2180
2181         sh WebKitBuild/Debug/jsc-stress-results/regress/script-tests/emscripten-cube2hash.js.ftl-eager-no-cjit lldb --
2182
2183         Broadly, any arguments passed to the reproduction script are prepended to the command to
2184         run the test. This is sort of quirky and won't work for some tests (for example the
2185         profiler tests run a ruby script that runs some other stuff) but it'll work for most of
2186         them and that's good enough for now.
2187
2188         * Scripts/run-jsc-stress-tests:
2189
2190 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
2191
2192         [Windows] Correct run-path when using 64-bit binaries.
2193
2194         Reviewed by David Kilzer.
2195
2196         * Scripts/webkitdirs.pm:
2197         (determineConfigurationProductDir): If running in 64-bit mode, use the 'bin64'
2198         directory. Otherwise use the existing 'bin32' directory.
2199
2200 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
2201
2202         Teach webkitdirs.pm to honor the --64-bit flag
2203         https://bugs.webkit.org/show_bug.cgi?id=122357
2204
2205         Reviewed by David Kilzer.
2206
2207         * Scripts/webkitdirs.pm:
2208         (argumentsForConfiguration): Modify to check if --64-bit is supplied
2209         by the user.
2210         (findMatchingArguments): Added.
2211         (hasArgument): Added.
2212         (checkForArgumentAndRemoveFromArrayRef): Refactor to use the new
2213         findMatchingArguments subroutine.
2214
2215 2013-10-04  Alexey Proskuryakov  <ap@apple.com>
2216
2217         Update svn-config for new Visual Studio extensions
2218         https://bugs.webkit.org/show_bug.cgi?id=122344
2219
2220         Reviewed by Brent Fulgham.
2221
2222         * svn-config: Add new Visual Studio extensions.
2223
2224 2013-10-04  Alex Christensen  <achristensen@webkit.org>
2225
2226         Made WinLauncher have better error handling, crash reporting, and modifiability.
2227         https://bugs.webkit.org/show_bug.cgi?id=122319
2228
2229         Reviewed by Brent Fulgham.
2230
2231         * WinLauncher/WinLauncher.cpp:
2232         (WinLauncherWebHost::didFailProvisionalLoadWithError):
2233         Don't display the numerous "Cancelled" messages that are obviously from the user.
2234         (createCrashReport): Added.
2235         (dllLauncherEntryPoint):
2236         Made main loop back into while loop and write a crash report if it crashes.
2237         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2238         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
2239         Added WinLauncherReplace.h.
2240         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:
2241         Added linking to DbgHelp.lib.
2242         * WinLauncher/WinLauncherReplace.h:
2243         Added to make modifying WinLauncher behaviour and appearance easy.
2244         (processCrashDump): Added.
2245
2246 2013-10-04  Dirk Pranke  <dpranke@chromium.org>
2247
2248         remove dpranke from webkitpy watchlist
2249         https://bugs.webkit.org/show_bug.cgi?id=122331
2250
2251         Reviewed by Brent Fulgham.
2252
2253         * Scripts/webkitpy/common/config/watchlist:
2254
2255 2013-10-04  Tim Horton  <timothy_horton@apple.com>
2256
2257         [mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommands fail after r156793
2258         https://bugs.webkit.org/show_bug.cgi?id=122299
2259
2260         Reviewed by Beth Dakin.
2261
2262         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2263         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
2264         The last fix didn't work; instead of trying to block, turn off threaded scrolling for all three tests.
2265
2266 2013-10-04  Alexey Proskuryakov  <ap@apple.com>
2267
2268         Watchlist is broken after <http://trac.webkit.org/r156880>
2269
2270         * Scripts/webkitpy/common/config/watchlist: Remove an incorrect change.
2271
2272 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
2273
2274         Remove Qt features from build and test tools
2275         https://bugs.webkit.org/show_bug.cgi?id=122312
2276
2277         Reviewed by Anders Carlsson.
2278
2279         * Scripts/build-dumprendertree:
2280         * Scripts/build-jsc:
2281         * Scripts/build-webkit:
2282         * Scripts/build-webkittestrunner:
2283         * Scripts/old-run-webkit-tests:
2284         (openDumpTool):
2285         (buildPlatformResultHierarchy):
2286         (buildPlatformTestHierarchy):
2287         (readSkippedFiles):
2288         * Scripts/run-launcher:
2289         * Scripts/run-qtwebkit-tests: Removed.
2290         * Scripts/run-webkit-tests:
2291         (useNewRunWebKitTests):
2292         * Scripts/update-webkit:
2293         * Scripts/webkit-build-directory:
2294         * Scripts/webkitdirs.pm:
2295         (argumentsForConfiguration):
2296         (jscProductDir):
2297         (builtDylibPathForName):
2298         (isAppleWebKit):
2299         (launcherPath):
2300         (launcherName):
2301         (checkRequiredSystemConfig):
2302         (setupCygwinEnv):
2303         (copyInspectorFrontendFiles):
2304         (setPathForRunningWebKitApp):
2305         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
2306         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
2307         (BaselineOptimizerTest.test_mac_future):
2308         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
2309         (BaselineOptimizerTest.test_common_directory_includes_root):
2310         (BaselineOptimizerTest.test_virtual_ports_filtered):
2311         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2312         (test_parse_reviewer_text):
2313         * Scripts/webkitpy/common/config/watchlist:
2314         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2315         (PortTest.disabled_test_chromium_mac_lion_in_test_shell_mode):
2316         * Scripts/webkitpy/port/base.py:
2317         (Port.__init__):
2318         (Port._port_flag_for_scripts):
2319         (Port._wk2_port_name):
2320         * Scripts/webkitpy/port/builders.py:
2321         * Scripts/webkitpy/port/factory.py:
2322         (platform_options):
2323         (PortFactory):
2324         (PortFactory._default_port):
2325         * Scripts/webkitpy/port/factory_unittest.py:
2326         (FactoryTest.test_gtk):
2327         * Scripts/webkitpy/port/qt.py: Removed.
2328         * Scripts/webkitpy/port/qt_unittest.py: Removed.
2329         * Scripts/webkitpy/style/checker.py:
2330         * Scripts/webkitpy/style/checker_unittest.py:
2331         (GlobalVariablesTest.test_path_rules_specifier):
2332         * Scripts/webkitpy/style/checkers/cmake.py:
2333         (CMakeChecker):
2334         * Scripts/webkitpy/style/checkers/cpp.py:
2335         (_classify_include):
2336         (check_include_line):
2337         (check_identifier_name_in_declaration):
2338         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2339         (OrderOfIncludesTest.test_classify_include):
2340         (WebKitStyleTest.test_names):
2341         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2342         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
2343         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2344         (TestRebaselineTest.test_baseline_directory):
2345         * Scripts/webkitpy/tool/main.py:
2346         (WebKitPatch):
2347
2348 2013-10-03  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2349
2350         Unreviewed. Add myself to some watchlists.
2351
2352         * Scripts/webkitpy/common/config/watchlist:
2353
2354 2013-10-03  Ryosuke Niwa  <rniwa@webkit.org>
2355
2356         Remove Qt builders from the flakiness dashboard.
2357
2358         * TestResultServer/static-dashboards/builders.jsonp:
2359         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2360         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2361         * TestResultServer/static-dashboards/loader_unittests.js:
2362
2363 2013-10-03  Tim Horton  <timothy_horton@apple.com>
2364
2365         [mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommands fail after r156793
2366         https://bugs.webkit.org/show_bug.cgi?id=122299
2367
2368         Reviewed by Beth Dakin.
2369
2370         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
2371         Disable threaded scrolling.
2372
2373         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2374         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
2375         Synchronously wait for the scrolling thread to inform the main thread of the new scroll position.
2376
2377 2013-10-03  Anders Carlsson  <andersca@apple.com>
2378
2379         Use numeric strings in the OS version dictionary
2380         https://bugs.webkit.org/show_bug.cgi?id=122300
2381
2382         Reviewed by Mark Rowe.
2383
2384         * Scripts/webkitpy/common/system/platforminfo.py:
2385         (PlatformInfo._determine_mac_version):
2386
2387 2013-10-03  Alexey Proskuryakov  <ap@apple.com>
2388
2389         Fix LeaksViewer to load leaks results from MountainLion, not Lion.
2390
2391         Rubber-stamped by Tim Horton.
2392
2393         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2394         (LeaksViewer._displayURLPrompt):
2395
2396 2013-10-03  Dan Bernstein  <mitz@apple.com>
2397
2398         REGRESSION (r156811): Objective-C JavaScriptCore API test failing on Mountain Lion bots
2399         https://bugs.webkit.org/show_bug.cgi?id=122260
2400
2401         Reviewed by Alexey Proskuryakov.
2402
2403         For the API to work, the tests need to be compiled with a newer version of the LLVM
2404         compiler. Until the bots are updated to that version, disable the tests on 10.8.
2405
2406         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
2407
2408 2013-10-02  Mario Sanchez Prada  <mario.prada@samsung.com>
2409
2410         [ATK] Expose aria-invalid as a text attribute (not object attribute)
2411         https://bugs.webkit.org/show_bug.cgi?id=122015
2412
2413         Reviewed by Chris Fleizach.
2414
2415         Adapted DRT and WKTR to check the exposure of the aria-invalid
2416         attribute as a text attribute, instead of an object attribute.
2417
2418         Also, done some refactoring of the code to try to keep things
2419         simpler and more coherent, by defining new helper functions,
2420         simplifying code, moving static variables and functions into
2421         unnammed namespaces and so on, without altering the logic other
2422         than for checking the text attribute for aria-invalid.
2423
2424         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2425         (coreAttributeToAtkAttribute): Consider 'invalid' as the name of
2426         the attribute exposed by the ATK wrapper, not 'aria-invalid'.
2427         Also, never return an empty string if not falling through any of
2428         the cases checked here, and return the original attribute instead.
2429         (atkAttributeValueToCoreAttributeValue): New helper function to
2430         match the attributes values returned by the ATK wrapper with the
2431         values expected by the layout tests. Moved the mappings for the
2432         values of AXSortDirection here as well.
2433         (getAttributeSet): New helper function to retrieve a list of
2434         attributes (an AtkAttributeSet) from an AtkObject using the right
2435         API depending on whether we want the object attributes or the text
2436         attributes (in case the object implements AtkText).
2437         (getAttributeSetValueForId): Simplified by using getAttributeSet
2438         and atkAttributeValueToCoreAttributeValue. Also, added a new
2439         parameter to indicater whether we are interested in object
2440         attributes or text attributes.
2441         (getAtkAttributeSetAsString): Ditto.
2442         (attributesOfElement): Updated to pass the new required parameter
2443         to getAtkAttributeSetAsString, indicating that we want the object
2444         attributes in this case, for backwards compatibility.
2445         (indexRangeInTable): Moved up in the file into the unnammed namespace.
2446         (alterCurrentValue): Ditto.
2447         (AccessibilityUIElement::stringAttributeValue): After moving most
2448         of the code here to the new helper functions, simplified it by
2449         just checking whether the required attribute is provided as an
2450         object attribute or, if that's not the case, as a text attribute.
2451         (AccessibilityUIElement::isAttributeSupported): Ditto.
2452         (AccessibilityUIElement::intValue): Updated to pass the new
2453         required parameter to getAttributeSetValueForId, indicating that
2454         we want the object attributes in this case.
2455         (AccessibilityUIElement::hasPopup): Ditto.
2456
2457         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2458         (WTR::coreAttributeToAtkAttribute): Same changes than for DRT.
2459         (WTR::atkAttributeValueToCoreAttributeValue): Ditto.
2460         (WTR::getAttributeSet): Ditto.
2461         (WTR::getAttributeSetValueForId): Ditto.
2462         (WTR::getAtkAttributeSetAsString): Ditto.
2463         (WTR::attributesOfElement): Ditto.
2464         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
2465         (WTR::AccessibilityUIElement::isAttributeSupported): Ditto.
2466         (WTR::AccessibilityUIElement::intValue): Ditto.
2467         (WTR::AccessibilityUIElement::hasPopup): Ditto.
2468
2469 2013-10-02  Ryosuke Niwa  <rniwa@webkit.org>
2470
2471         EWS build fix after the Qt EWS removal.
2472
2473         * QueueStatusServer/model/attachment.py:
2474         (Attachment._calculate_queue_positions):
2475
2476 2013-10-02  Anders Carlsson  <andersca@apple.com>
2477
2478         Remove Qt code from Tools/
2479         https://bugs.webkit.org/show_bug.cgi?id=122227
2480
2481         Reviewed by Andreas Kling.
2482
2483         * DumpRenderTree/WorkQueue.cpp:
2484         * DumpRenderTree/blackberry/src.pro: Removed.
2485         * DumpRenderTree/qt/DumpRenderTree.pro: Removed.
2486         * DumpRenderTree/qt/DumpRenderTree.qrc: Removed.
2487         * DumpRenderTree/qt/DumpRenderTreeMain.cpp: Removed.
2488         * DumpRenderTree/qt/DumpRenderTreeQt.cpp: Removed.
2489         * DumpRenderTree/qt/DumpRenderTreeQt.h: Removed.
2490         * DumpRenderTree/qt/EventSenderQt.cpp: Removed.
2491         * DumpRenderTree/qt/EventSenderQt.h: Removed.
2492         * DumpRenderTree/qt/GCControllerQt.cpp: Removed.
2493         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Removed.
2494         * DumpRenderTree/qt/TestRunnerQt.cpp: Removed.
2495         * DumpRenderTree/qt/TestRunnerQt.h: Removed.
2496         * DumpRenderTree/qt/TextInputControllerQt.cpp: Removed.
2497         * DumpRenderTree/qt/TextInputControllerQt.h: Removed.
2498         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Removed.
2499         * DumpRenderTree/qt/WorkQueueItemQt.h: Removed.
2500         * DumpRenderTree/qt/fonts/AHEM____.TTF: Removed.
2501         * DumpRenderTree/qt/resources/user.css: Removed.
2502         * DumpRenderTree/qt/testplugin.cpp: Removed.
2503         * DumpRenderTree/qt/testplugin.h: Removed.
2504         * ImageDiff/ImageDiff.pro: Removed.
2505         * ImageDiff/qt/ImageDiff.cpp: Removed.
2506         * MiniBrowser/qt/BrowserWindow.cpp: Removed.
2507         * MiniBrowser/qt/BrowserWindow.h: Removed.
2508         * MiniBrowser/qt/MiniBrowser.pro: Removed.
2509         * MiniBrowser/qt/MiniBrowser.qrc: Removed.
2510         * MiniBrowser/qt/MiniBrowserApplication.cpp: Removed.
2511         * MiniBrowser/qt/MiniBrowserApplication.h: Removed.
2512         * MiniBrowser/qt/UrlLoader.cpp: Removed.
2513         * MiniBrowser/qt/UrlLoader.h: Removed.
2514         * MiniBrowser/qt/icons/checkbox_checked.png: Removed.
2515         * MiniBrowser/qt/icons/checkbox_unchecked.png: Removed.
2516         * MiniBrowser/qt/icons/contents_width.png: Removed.
2517         * MiniBrowser/qt/icons/favicon.png: Removed.
2518         * MiniBrowser/qt/icons/find.png: Removed.
2519         * MiniBrowser/qt/icons/folder.png: Removed.
2520         * MiniBrowser/qt/icons/info.png: Removed.
2521         * MiniBrowser/qt/icons/next.png: Removed.
2522         * MiniBrowser/qt/icons/plus.png: Removed.
2523         * MiniBrowser/qt/icons/previous.png: Removed.
2524         * MiniBrowser/qt/icons/refresh.png: Removed.
2525         * MiniBrowser/qt/icons/stop.png: Removed.
2526         * MiniBrowser/qt/icons/titlebar.png: Removed.
2527         * MiniBrowser/qt/icons/touch.png: Removed.
2528         * MiniBrowser/qt/icons/touchpoint.png: Removed.
2529         * MiniBrowser/qt/icons/up.png: Removed.
2530         * MiniBrowser/qt/js/MultiSelect.js: Removed.
2531         * MiniBrowser/qt/main.cpp: Removed.
2532         * MiniBrowser/qt/qml/AlertDialog.qml: Removed.
2533         * MiniBrowser/qt/qml/AuthenticationDialog.qml: Removed.
2534         * MiniBrowser/qt/qml/BrowserWindow.qml: Removed.
2535         * MiniBrowser/qt/qml/CheckBox.qml: Removed.
2536         * MiniBrowser/qt/qml/ColorChooser.qml: Removed.
2537         * MiniBrowser/qt/qml/ConfirmDialog.qml: Removed.
2538         * MiniBrowser/qt/qml/Dialog.qml: Removed.
2539         * MiniBrowser/qt/qml/DialogButton.qml: Removed.
2540         * MiniBrowser/qt/qml/DialogLineInput.qml: Removed.
2541         * MiniBrowser/qt/qml/FilePicker.qml: Removed.
2542         * MiniBrowser/qt/qml/ItemSelector.qml: Removed.
2543         * MiniBrowser/qt/qml/MockTouchPoint.qml: Removed.
2544         * MiniBrowser/qt/qml/PromptDialog.qml: Removed.
2545         * MiniBrowser/qt/qml/ProxyAuthenticationDialog.qml: Removed.
2546         * MiniBrowser/qt/qml/ScrollIndicator.qml: Removed.
2547         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Removed.
2548         * MiniBrowser/qt/raw/DerivedSources.pri: Removed.
2549         * MiniBrowser/qt/raw/MiniBrowserRaw.pro: Removed.
2550         * MiniBrowser/qt/raw/Target.pri: Removed.
2551         * MiniBrowser/qt/raw/View.cpp: Removed.
2552         * MiniBrowser/qt/raw/View.h: Removed.
2553         * MiniBrowser/qt/utils.cpp: Removed.
2554         * MiniBrowser/qt/utils.h: Removed.
2555         * QtTestBrowser/QtTestBrowser.pro: Removed.
2556         * QtTestBrowser/QtTestBrowser.qrc: Removed.
2557         * QtTestBrowser/cookiejar.cpp: Removed.
2558         * QtTestBrowser/cookiejar.h: Removed.
2559         * QtTestBrowser/favicon.png: Removed.
2560         * QtTestBrowser/fpstimer.cpp: Removed.
2561         * QtTestBrowser/fpstimer.h: Removed.
2562         * QtTestBrowser/launcherwindow.cpp: Removed.
2563         * QtTestBrowser/launcherwindow.h: Removed.
2564         * QtTestBrowser/locationedit.cpp: Removed.
2565         * QtTestBrowser/locationedit.h: Removed.
2566         * QtTestBrowser/mainwindow.cpp: Removed.
2567         * QtTestBrowser/mainwindow.h: Removed.
2568         * QtTestBrowser/qttestbrowser.cpp: Removed.
2569         * QtTestBrowser/urlloader.cpp: Removed.
2570         * QtTestBrowser/urlloader.h: Removed.
2571         * QtTestBrowser/useragentlist.txt: Removed.
2572         * QtTestBrowser/utils.cpp: Removed.
2573         * QtTestBrowser/utils.h: Removed.
2574         * QtTestBrowser/webinspector.h: Removed.
2575         * QtTestBrowser/webpage.cpp: Removed.
2576         * QtTestBrowser/webpage.h: Removed.
2577         * QtTestBrowser/webview.cpp: Removed.
2578         * QtTestBrowser/webview.h: Removed.
2579         * TestWebKitAPI/DerivedSources.pri: Removed.
2580         * TestWebKitAPI/InjectedBundle.pri: Removed.
2581         * TestWebKitAPI/PlatformWebView.h:
2582         * TestWebKitAPI/TestWebKitAPI.pri: Removed.
2583         * TestWebKitAPI/TestWebKitAPI.pro: Removed.
2584         * TestWebKitAPI/Tests.pri: Removed.
2585         * TestWebKitAPI/Tests/JavaScriptCore/JavaScriptCore.pro: Removed.
2586         * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp:
2587         * TestWebKitAPI/Tests/WTF/WTF.pro: Removed.
2588         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro: Removed.
2589         * TestWebKitAPI/qt/InjectedBundleControllerQt.cpp: Removed.
2590         * TestWebKitAPI/qt/PlatformUtilitiesQt.cpp: Removed.
2591         * TestWebKitAPI/qt/PlatformWebViewQt.cpp: Removed.
2592         * TestWebKitAPI/qt/main.cpp: Removed.
2593         * Tools.pro: Removed.
2594         * WebKitTestRunner/DerivedSources.pri: Removed.
2595         * WebKitTestRunner/EventSenderProxy.h:
2596         * WebKitTestRunner/InjectedBundle/DerivedSources.pri: Removed.
2597         * WebKitTestRunner/InjectedBundle/InjectedBundle.pro: Removed.
2598         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2599         (WTR::InjectedBundlePage::resetAfterTest):
2600         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
2601         (WTR::InjectedBundlePage::didClearWindowForFrame):
2602         * WebKitTestRunner/InjectedBundle/Target.pri: Removed.
2603         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2604         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: Removed.
2605         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp: Removed.
2606         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp: Removed.
2607         * WebKitTestRunner/PlatformWebView.h:
2608         * WebKitTestRunner/Target.pri: Removed.
2609         * WebKitTestRunner/TestController.cpp:
2610         (WTR::TestController::resetStateToConsistentValues):
2611         * WebKitTestRunner/TestController.h:
2612         * WebKitTestRunner/WebKitTestRunner.pro: Removed.
2613         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Removed.
2614         * WebKitTestRunner/qt/PlatformWebViewQt.cpp: Removed.
2615         * WebKitTestRunner/qt/TestControllerQt.cpp: Removed.
2616         * WebKitTestRunner/qt/TestInvocationQt.cpp: Removed.
2617         * WebKitTestRunner/qt/WebKitTestRunner.qrc: Removed.
2618         * WebKitTestRunner/qt/main.cpp: Removed.
2619         * WebKitTestRunner/qt/resources/user.css: Removed.
2620         * qmake/.qmake.cache: Removed.
2621         * qmake/.qmake.conf: Removed.
2622         * qmake/README: Removed.
2623         * qmake/config.tests/README: Removed.
2624         * qmake/config.tests/fontconfig/fontconfig.cpp: Removed.
2625         * qmake/config.tests/fontconfig/fontconfig.pro: Removed.
2626         * qmake/config.tests/gccdepends/empty.cpp: Removed.
2627         * qmake/config.tests/gccdepends/gccdepends.pro: Removed.
2628         * qmake/config.tests/glx/glx.cpp: Removed.
2629         * qmake/config.tests/glx/glx.pro: Removed.
2630         * qmake/config.tests/gnuld/gnuld.pro: Removed.
2631         * qmake/config.tests/gnuld/main.cpp: Removed.
2632         * qmake/config.tests/libXcomposite/libXcomposite.cpp: Removed.
2633         * qmake/config.tests/libXcomposite/libXcomposite.pro: Removed.
2634         * qmake/config.tests/libXrender/libXrender.cpp: Removed.
2635         * qmake/config.tests/libXrender/libXrender.pro: Removed.
2636         * qmake/config.tests/libwebp/libwebp.cpp: Removed.
2637         * qmake/config.tests/libwebp/libwebp.pro: Removed.
2638         * qmake/config.tests/libxml2/libxml2.cpp: Removed.
2639         * qmake/config.tests/libxml2/libxml2.pro: Removed.
2640         * qmake/config.tests/libxslt/libxslt.cpp: Removed.
2641         * qmake/config.tests/libxslt/libxslt.pro: Removed.
2642         * qmake/config.tests/libzlib/libzlib.cpp: Removed.
2643         * qmake/config.tests/libzlib/libzlib.pro: Removed.
2644         * qmake/dump-features.pl: Removed.
2645         * qmake/mkspecs/features/configure.prf: Removed.
2646         * qmake/mkspecs/features/default_post.prf: Removed.
2647         * qmake/mkspecs/features/default_pre.prf: Removed.
2648         * qmake/mkspecs/features/features.prf: Removed.
2649         * qmake/mkspecs/features/features.pri: Removed.
2650         * qmake/mkspecs/features/force_static_libs_as_shared.prf: Removed.
2651         * qmake/mkspecs/features/functions.prf: Removed.
2652         * qmake/mkspecs/features/gprof.prf: Removed.
2653         * qmake/mkspecs/features/mac/default_post.prf: Removed.
2654         * qmake/mkspecs/features/mac/default_pre.prf: Removed.
2655         * qmake/mkspecs/features/minimal_qt.prf: Removed.
2656         * qmake/mkspecs/features/production_build.prf: Removed.
2657         * qmake/mkspecs/features/rpath.prf: Removed.
2658         * qmake/mkspecs/features/unix/default_post.prf: Removed.
2659         * qmake/mkspecs/features/unix/default_pre.prf: Removed.
2660         * qmake/mkspecs/features/unix/icc.prf: Removed.
2661         * qmake/mkspecs/features/use_all_in_one_files.prf: Removed.
2662         * qmake/mkspecs/features/valgrind.prf: Removed.
2663         * qmake/mkspecs/features/webkit_modules.prf: Removed.
2664         * qmake/mkspecs/features/win32/default_post.prf: Removed.
2665         * qmake/mkspecs/features/win32/default_pre.prf: Removed.
2666         * qmake/mkspecs/modules/angle.prf: Removed.
2667         * qmake/mkspecs/modules/javascriptcore.prf: Removed.
2668         * qmake/mkspecs/modules/webcore.prf: Removed.
2669         * qmake/mkspecs/modules/webkit1.prf: Removed.
2670         * qmake/mkspecs/modules/webkit2.prf: Removed.
2671         * qmake/mkspecs/modules/wtf.prf: Removed.
2672
2673 2013-10-02  Tim Horton  <timothy_horton@apple.com>
2674
2675         [mac] Stop using DrawingAreaImpl on PLATFORM(MAC) 
2676         https://bugs.webkit.org/show_bug.cgi?id=121859
2677         <rdar://problem/15069359>
2678
2679         Reviewed by Anders Carlsson.
2680
2681         * WebKitTestRunner/TestInvocation.cpp:
2682         (WTR::shouldUseThreadedScrolling):
2683         (WTR::updateThreadedScrollingForCurrentTest):
2684         (WTR::TestInvocation::invoke):
2685         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2686         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useThreadedScrolling:]):
2687         (WTR::PlatformWebView::PlatformWebView):
2688         (WTR::PlatformWebView::viewSupportsOptions):
2689         Rename the tiled drawing switch to threaded scrolling, since that's really
2690         all it switches now that we use tiled drawing everywhere.
2691
2692         Use an unbuffered window, as well, to avoid snapshotting issues on some platforms
2693         and to more closely match the case we're interested in testing.
2694
2695 2013-10-02  Anders Carlsson  <andersca@apple.com>
2696
2697         Move AHEM____.TTF from qt/fonts/ to fonts/.
2698
2699         Rubber-stamped by Andreas Kling.
2700
2701         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2702         * DumpRenderTree/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/qt/fonts/AHEM____.TTF.
2703
2704 2013-10-02  Ádám Kallai  <kadam@inf.u-szeged.hu>
2705
2706         Remove Qt bots and EWS from trunk.
2707         https://bugs.webkit.org/show_bug.cgi?id=122210.
2708
2709         Reviewed by Allan Sandfeld Jensen.
2710
2711         Remove Qt buil dbots.
2712
2713         * BuildSlaveSupport/build.webkit.org-config/config.json:
2714         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2715         (appendCustomBuildFlags):
2716         (RunGtkAPITests.getText2):
2717         (Factory.__init__):
2718         (TestFactory.__init__):
2719         (BuildAndTestFactory.__init__):
2720         (loadBuilderConfig):
2721         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2722
2723 2013-10-02  Ádám Kallai  <kadam@inf.u-szeged.hu>
2724
2725         Remove Qt bots and EWS from trunk.
2726         https://bugs.webkit.org/show_bug.cgi?id=122210.
2727
2728         Reviewed by Allan Sandfeld Jensen.
2729
2730         Remove Qt EWS bots.
2731
2732         * QueueStatusServer/config/queues.py:
2733         * Scripts/webkitpy/common/config/ews.json:
2734
2735 2013-10-01  Timothy Hatcher  <timothy@apple.com>
2736
2737         Fix singular labels for test failures.
2738
2739         https://bugs.webkit.org/show_bug.cgi?id=122200
2740
2741         Reviewed by Joseph Pecoraro.
2742
2743         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2744         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2745
2746 2013-10-01  Timothy Hatcher  <timothy@apple.com>
2747
2748         Don't keep appending iterations each time the queue updates.
2749
2750         https://bugs.webkit.org/show_bug.cgi?id=122198
2751
2752         Reviewed by Joseph Pecoraro.
2753
2754         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2755         (BuildbotQueue.prototype.update):
2756
2757 2013-10-01  Timothy Hatcher  <timothy@apple.com>
2758
2759         Properly sort iterations in the Dashboard by revision for out-of-order queues.
2760
2761         https://bugs.webkit.org/show_bug.cgi?id=122196
2762
2763         Reviewed by Brent Fulgham.
2764
2765         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2766         (BuildbotIteration):
2767         (BuildbotIteration.prototype.update):
2768         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2769         (BuildbotQueue.prototype.update):
2770         (BuildbotQueue.prototype.sortIterations):
2771
2772 2013-10-01  Timothy Hatcher  <timothy@apple.com>
2773
2774         Fix some exceptions seen in the Buildbot Dashboard when looking at unloaded iterations.
2775
2776         Also fix some URLs to not have extras slashes and add a page title.
2777
2778         https://bugs.webkit.org/show_bug.cgi?id=122192
2779
2780         Reviewed by Joseph Pecoraro.
2781
2782         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2783         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2784         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2785         (WebKitBuildbot.prototype.buildLogURLForIteration):
2786         (WebKitBuildbot.prototype.layoutTestResultsURLForIteration):
2787         (WebKitBuildbot.prototype.javascriptTestResultsURLForIteration):
2788         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
2789
2790 2013-10-01  Alexey Proskuryakov  <ap@apple.com>
2791
2792         [Mac] Set NSApplication current event while sending events directly to views
2793         https://bugs.webkit.org/show_bug.cgi?id=122179
2794
2795         Reviewed by Darin Adler.
2796
2797         DumpRenderTree and WebKitTestRunner send events directly to WebHMTLView or WKView,
2798         which doesn't update [NSApp currentEvent]. But there are many places in WebKit that
2799         use the current event.
2800
2801         * DumpRenderTree/mac/EventSendingController.mm:
2802         (-[EventSendingController mouseDown:withModifiers:]):
2803         (-[EventSendingController mouseUp:withModifiers:]):
2804         (-[EventSendingController mouseMoveToX:Y:]):
2805         (-[EventSendingController mouseScrollByX:andY:continuously:]):
2806         (-[EventSendingController contextClick]):
2807         (-[EventSendingController keyDown:withModifiers:withLocation:]):
2808         * WebKitTestRunner/mac/EventSenderProxy.mm:
2809         (WTR::EventSenderProxy::mouseDown):
2810         (WTR::EventSenderProxy::mouseUp):
2811         (WTR::EventSenderProxy::mouseMoveTo):
2812         (WTR::EventSenderProxy::keyDown):
2813         (WTR::EventSenderProxy::mouseScrollBy):
2814         Update the current event. We were already using the SPI in WebKit.
2815
2816 2013-10-01  Joseph Pecoraro  <pecoraro@apple.com>
2817
2818         Buildbot Dashboard: Fix JSHint issue: 'perlTestResults' used out of scope.
2819         https://bugs.webkit.org/show_bug.cgi?id=122183
2820
2821         Reviewed by Timothy Hatcher.
2822
2823         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2824         (BuildbotIteration.prototype.update):
2825
2826 2013-10-01  Timothy Hatcher  <timothy@apple.com>
2827
2828         Tweaks to the Buildbot Dashboard
2829
2830         https://bugs.webkit.org/show_bug.cgi?id=122169
2831
2832         Reviewed by Alexey Proskuryakov.
2833
2834         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2835         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
2836         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2837         (BuildbotQueueView.prototype.revisionLinksForIteration):
2838         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2839         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2840         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Added.
2841         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2842         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2843         (WebKitBuildbot.prototype.buildLogURLForIteration):
2844         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
2845
2846 2013-10-01  Commit Queue  <commit-queue@webkit.org>
2847
2848         Unreviewed, rolling out r156725.
2849         http://trac.webkit.org/changeset/156725
2850         https://bugs.webkit.org/show_bug.cgi?id=122176
2851
2852         broke all the mismatch tests again (Requested by thorton on
2853         #webkit).
2854
2855         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2856         (WTR::PlatformWebView::PlatformWebView):
2857
2858 2013-10-01  Alex Christensen  <achristensen@webkit.org>
2859
2860         Implemented createWebViewWithRequest in WinLauncher.
2861         https://bugs.webkit.org/show_bug.cgi?id=122069
2862
2863         Reviewed by Brent Fulgham.
2864
2865         * WinLauncher/PrintWebUIDelegate.cpp:
2866         (PrintWebUIDelegate::createWebViewWithRequest): Added.
2867         * WinLauncher/PrintWebUIDelegate.h:
2868         Removed createWebViewWithRequest stub.
2869
2870 2013-10-01  Tim Horton  <timothy_horton@apple.com>
2871
2872         [wk2] WebKitTestRunner's window snapshots are blank with tiled drawing
2873         https://bugs.webkit.org/show_bug.cgi?id=122006
2874         <rdar://problem/15095197>
2875
2876         Reviewed by Dean Jackson.
2877
2878         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2879         (WTR::PlatformWebView::PlatformWebView):
2880         Layer-back the root view in WebKitTestRunner's window, to work around a bug
2881         where the window server snapshot API returns blank snapshots.
2882
2883         Re-landing after r156724, this should not break everything now.
2884
2885 2013-10-01  Tim Horton  <timothy_horton@apple.com>
2886
2887         [mac] 1x emulation on Retina hardware shouldn't use SPI
2888         https://bugs.webkit.org/show_bug.cgi?id=122152
2889         <rdar://problem/15119384>
2890
2891         Reviewed by Anders Carlsson.
2892
2893         * DumpRenderTree/mac/DumpRenderTree.mm:
2894         (createWebViewAndOffscreenWindow):
2895         (main):
2896         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2897         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2898         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2899         (WTR::PlatformWebView::PlatformWebView):
2900         * WebKitTestRunner/mac/main.mm:
2901         (main):
2902         Register for AppleMagnifiedMode instead of using _setWindowResolution:displayIfChanged:.
2903
2904 2013-09-30  Sam Weinig  <sam@webkit.org>
2905
2906         check-webkit-style should not warn about use of C++11 “>>”  instead of “> >"
2907         https://bugs.webkit.org/show_bug.cgi?id=116474
2908
2909         Reviewed by Ryosuke Niwa.
2910
2911         * Scripts/webkitpy/style/checkers/cpp.py:
2912         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2913
2914 2013-09-30  Sam Weinig  <sam@webkit.org>
2915
2916         Remove support for DOMFileSystem
2917         https://bugs.webkit.org/show_bug.cgi?id=122137
2918
2919         Reviewed by Anders Carlsson.
2920
2921         * Scripts/webkitperl/FeatureList.pm:
2922         * Scripts/webkitpy/style/checkers/cpp.py:
2923         (check_spacing):
2924         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2925         (CppStyleTest.test_spacing_for_binary_ops):
2926         * qmake/mkspecs/features/features.pri:
2927
2928 2013-09-30  Mark Rowe  <mrowe@apple.com>
2929
2930         More build fixage for builds with SDKs.
2931
2932         * WebKitTestRunner/Configurations/Base.xcconfig:
2933         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
2934
2935 2013-09-30  Timothy Hatcher  <timothy@apple.com>
2936
2937         Add initial version of a new Buildbot dashboard view.
2938
2939         https://bugs.webkit.org/show_bug.cgi?id=122131
2940
2941         Reviewed by Alexey Proskuryakov.
2942
2943         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion.png: Added.
2944         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion@2x.png: Added.
2945         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks.png: Added.
2946         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks@2x.png: Added.
2947         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: Added.
2948         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: Added.
2949         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing.png: Added.
2950         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing@2x.png: Added.
2951         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7.png: Added.
2952         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7@2x.png: Added.
2953         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8.png: Added.
2954         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8@2x.png: Added.
2955         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP.png: Added.
2956         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP@2x.png: Added.
2957         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BaseObject.js: Added.
2958         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js: Added.
2959         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js: Added.
2960         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Added.
2961         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js: Added.
2962         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: Added.
2963         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js: Added.
2964         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js: Added.
2965         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Added.
2966         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js: Added.
2967         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js: Added.
2968         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: Added.
2969         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotBuilderQueueView.css: Added.
2970         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css: Added.
2971         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotTesterQueueView.css: Added.
2972         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: Added.
2973         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css: Added.
2974         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added.
2975
2976 2013-09-30  Benjamin Poulain  <benjamin@webkit.org>
2977
2978         Remove the code guarded by STYLE_SCOPED
2979         https://bugs.webkit.org/show_bug.cgi?id=122123
2980
2981         Reviewed by Anders Carlsson.
2982
2983         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2984         (resetDefaultsToConsistentValues):
2985         * Scripts/webkitperl/FeatureList.pm:
2986         * qmake/mkspecs/features/features.pri:
2987
2988 2013-09-30  Mark Rowe  <mrowe@apple.com>
2989
2990         Fix the build when building against an SDK.
2991
2992         Xcode helpfully prepends $(SDKROOT) to the paths in FRAMEWORK_SEARCH_PATHS when generating
2993         the compiler command lines. It can't know to do this for the system framework search paths
2994         we add manually via OTHER_CFLAGS though, so we need to prefix them with $(SDKROOT) ourself.
2995
2996         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
2997         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
2998
2999 2013-09-30  Brent Fulgham  <bfulgham@apple.com>
3000
3001         [Windows] Unreviewed test fix. Prevent crash when changing URL paths during testing.
3002
3003         A shared BSTR value (_bstr_t) was being reallocated outside the smart pointer, causing
3004         it to be double-freed.
3005
3006         * WinLauncher/WinLauncher.cpp:
3007         (EditProc): Be explicit about type passed to loadURL.
3008         (loadURL): Create a shallow copy of the BSTR so we only allocate memory if needed. Use _bstr_t so
3009         that reallocating the BSTR is done with the knowledge of the smart pointer.
3010
3011 2013-09-30  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3012
3013         [Qt] Fix force_static_libs_as_shared in WebKit2
3014         https://bugs.webkit.org/show_bug.cgi?id=121961
3015
3016         Reviewed by Csaba Osztrogonác.
3017
3018         Get rid of the unused WebKit2QML library
3019
3020         * qmake/mkspecs/features/webkit_modules.prf:
3021         * qmake/mkspecs/modules/webkit2qml.prf: Removed.
3022
3023 2013-09-30  Krzysztof Wolanski  <k.wolanski@samsung.com>
3024
3025         [EFL] Fix incorrect click counting in EventSenderProxy
3026         https://bugs.webkit.org/show_bug.cgi?id=122098
3027
3028         Reviewed by Gyuyoung Kim.
3029
3030         Previously used two types of recording time, which conflicted with each other.
3031
3032         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
3033         (WTR::EventSenderProxy::mouseUp):
3034
3035 2013-09-30  Zan Dobersek  <zdobersek@igalia.com>
3036
3037         [webkitpy] Make the Xvfb screen depth overridable
3038         https://bugs.webkit.org/show_bug.cgi?id=122089
3039
3040         Reviewed by Gyuyoung Kim.
3041
3042         Make the Xvfb screen depth overridable by checking if the XVFB_SCREEN_DEPTH environment variable
3043         was set. The default value that's used if the variable wasn't set is 24.
3044
3045         * Scripts/webkitpy/port/xvfbdriver.py:
3046         (XvfbDriver._xvfb_screen_depth):
3047         (XvfbDriver._start):
3048         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
3049         (XvfbDriverTest.make_driver):
3050         (XvfbDriverTest.test_start_no_pixel_tests):
3051         (XvfbDriverTest.test_start_pixel_tests):
3052         (XvfbDriverTest.test_start_arbitrary_worker_number):
3053         (XvfbDriverTest.test_next_free_display):
3054         (XvfbDriverTest.test_start_next_worker):
3055
3056 2013-09-29  Mark Rowe  <mrowe@apple.com>
3057
3058         Fix the Lion build.
3059
3060         Ensure that C++ and Objective-C++ files build with the right compiler flags.
3061
3062         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
3063         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
3064
3065 2013-09-28  Mark Rowe  <mrowe@apple.com>
3066
3067         Fix some failures with newer versions of clang.
3068
3069         Some CoreGraphics headers generate warnings under newer versions of clang. Since they're system headers the warnings would
3070         usually be suppressed, but we're adding the frameworks to the non-system framework search path so they're no longer treated
3071         as system headers. We address this by removing the system paths from FRAMEWORK_SEARCH_PATHS and using the -iframework compiler
3072         flag in OTHER_CFLAGS to add the paths to the system framework search path. We have to set OTHER_CFLAGS at the target level
3073         in order for it to coexist with the ASAN-related OTHER_CFLAGS that's set in DebugRelease.xcconfig.
3074
3075         Reviewed by Dan Bernstein.
3076
3077         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3078         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: A new .xcconfig file that's included by all target-specific .xcconfig files.
3079         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3080         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
3081         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
3082         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
3083         * WebKitTestRunner/Configurations/Base.xcconfig:
3084         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: A new .xcconfig file that's included by all target-specific .xcconfig files.
3085         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3086         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
3087         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
3088
3089 2013-09-27  Commit Queue  <commit-queue@webkit.org>
3090
3091         Unreviewed, rolling out r156569.
3092         http://trac.webkit.org/changeset/156569
3093         https://bugs.webkit.org/show_bug.cgi?id=122035
3094
3095         broke a lot of mismatch tests (Requested by thorton on
3096         #webkit).
3097
3098         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3099         (WTR::PlatformWebView::PlatformWebView):
3100
3101 2013-09-27  Alexey Proskuryakov  <ap@apple.com>
3102
3103         Don't retry failures on Apple MountainLion Release WK1 tester
3104         https://bugs.webkit.org/show_bug.cgi?id=122026
3105
3106         Reviewed by Mark Rowe.
3107
3108         * BuildSlaveSupport/build.webkit.org-config/config.json: Added --no-retry-failures
3109         on this bot.
3110
3111 2013-09-27  Alexey Proskuryakov  <ap@apple.com>
3112
3113         Don't hardcode builder specific configuration in buildbot master.cfg
3114         https://bugs.webkit.org/show_bug.cgi?id=122023
3115
3116         Reviewed by Mark Rowe.
3117
3118         * BuildSlaveSupport/build.webkit.org-config/config.json: Added an additionalArguments
3119         property to Qt Mountain Lion Release, making it run pixel tests.
3120
3121         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3122         (RunWebKitTests.start): Use additionalArguments.
3123         (RunWebKit2Tests.start): Don't hardcode individual bot behavior here.
3124
3125 2013-09-27  Tim Horton  <timothy_horton@apple.com>
3126
3127         [wk2] WebKitTestRunner's window snapshots are blank with tiled drawing
3128         https://bugs.webkit.org/show_bug.cgi?id=122006
3129         <rdar://problem/15095197>
3130
3131         Reviewed by Dean Jackson.
3132
3133         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3134         (WTR::PlatformWebView::PlatformWebView):
3135         Layer-back the root view in WebKitTestRunner's window, to work around a bug
3136         where the window server snapshot API returns blank snapshots.
3137
3138 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
3139
3140         [GTK] GTK does not expose heading level correctly. Was: accessibility/heading-level.html is failing
3141         https://bugs.webkit.org/show_bug.cgi?id=106924
3142
3143         Reviewed by Chris Fleizach.
3144
3145         Consider headings levels as values to be returned in intValue()
3146         both in DRT and WKTR, so we can share more tests with other ports.
3147
3148         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3149         (AccessibilityUIElement::intValue): Consider headings too.
3150         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3151         (WTR::AccessibilityUIElement::intValue): Ditto.
3152
3153 2013-09-26  Darin Adler  <darin@apple.com>
3154
3155         rename KURL to URL
3156         https://bugs.webkit.org/show_bug.cgi?id=16214
3157
3158         Reviewed by Andreas Kling.
3159
3160         * many files: Renamed, using script.
3161
3162 2013-09-27  Darin Adler  <darin@apple.com>
3163
3164         Fix Python scripts test failures.
3165
3166         * Scripts/webkitpy/style/checkers/cpp.py:
3167         (_FunctionState.modifiers_and_return_type): Added this back. Used only by tests
3168         now, not by the checker itself.
3169
3170 2013-09-27  Denis Nomiyama  <d.nomiyama@samsung.com>
3171
3172         [GTK][WK2] Logging of accessibility events is not disabled between tests
3173         https://bugs.webkit.org/show_bug.cgi?id=121957
3174
3175         Reviewed by Mario Sanchez Prada.
3176
3177         Fixed an issue in AccessibilityNotificationHandler where the destructor
3178         was not disconnecting accessibility event callbacks if logging was on.
3179         The decision of disconnecting events can solely rely on the existence of
3180         notification handlers because logging uses the global notification
3181         handler.
3182
3183         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3184         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks): Fixed
3185         disconnection when logging is on.
3186
3187 2013-09-27  Patrick Gansterer  <paroga@webkit.org>
3188
3189         Add general CMakeLists.txt for DRT
3190         https://bugs.webkit.org/show_bug.cgi?id=119268
3191
3192         Reviewed by Gyuyoung Kim.
3193
3194         The new file allows better sharing between ports.
3195
3196         * CMakeLists.txt:
3197         * DumpRenderTree/CMakeLists.txt: Added.
3198         * DumpRenderTree/PlatformEfl.cmake: Added.
3199         * DumpRenderTree/efl/CMakeLists.txt: Removed.
3200
3201 2013-09-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3202
3203         [Qt] Fix force_static_libs_as_shared in WebKit2
3204         https://bugs.webkit.org/show_bug.cgi?id=121961
3205
3206         Reviewed by Csaba Osztrogonác.
3207
3208         Reenable force_static_libs_as_shared when building WebKit2.
3209
3210         * qmake/mkspecs/features/default_post.prf:
3211
3212 2013-09-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3213
3214         [Qt] Mock implementations of positioning and orientation not used
3215         https://bugs.webkit.org/show_bug.cgi?id=121956
3216
3217         Reviewed by Csaba Osztrogonác.
3218
3219         Move production_build checks to sanitizeFeatures where its value is actually known.
3220
3221         * qmake/mkspecs/features/features.prf:
3222         * qmake/mkspecs/features/features.pri:
3223
3224 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
3225
3226         [ATK] Normalize checks in entry points for DRT and WKTR
3227         https://bugs.webkit.org/show_bug.cgi?id=121959
3228
3229         Reviewed by Chris Fleizach.
3230
3231         Always check if we have a proper instance of AtkObject,
3232         implementing the interfaces that we might need for each case, at
3233         the entry point of every method of AccessibilityUIElement for ATK,
3234         and do those checks in an uniform way across DRT and WKTR, to
3235         avoid confusion and issues when modifying these files in the future.
3236
3237         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3238         (AccessibilityUIElement::getChildren): Use normalized checks.
3239         (AccessibilityUIElement::getChildrenWithRange): Ditto.
3240         (AccessibilityUIElement::rowCount): Ditto.
3241         (AccessibilityUIElement::columnCount): Ditto.
3242         (AccessibilityUIElement::childrenCount): Ditto.
3243         (AccessibilityUIElement::elementAtPoint): Ditto.
3244         (AccessibilityUIElement::getChildAtIndex): Ditto.
3245         (AccessibilityUIElement::allAttributes): Ditto.
3246         (AccessibilityUIElement::titleUIElement): Ditto.
3247         (AccessibilityUIElement::parentElement): Ditto.
3248         (AccessibilityUIElement::attributesOfChildren): Ditto.
3249         (AccessibilityUIElement::role): Ditto.
3250         (AccessibilityUIElement::title): Ditto.
3251         (AccessibilityUIElement::description): Ditto.
3252         (AccessibilityUIElement::stringValue): Ditto.
3253         (AccessibilityUIElement::language): Ditto.
3254         (AccessibilityUIElement::x): Ditto.
3255         (AccessibilityUIElement::y): Ditto.
3256         (AccessibilityUIElement::width): Ditto.
3257         (AccessibilityUIElement::height): Ditto.
3258         (AccessibilityUIElement::orientation): Ditto.
3259         (AccessibilityUIElement::intValue): Ditto.
3260         (AccessibilityUIElement::minValue): Ditto.
3261         (AccessibilityUIElement::maxValue): Ditto.
3262         (indexRangeInTable): Ditto.
3263         (AccessibilityUIElement::cellForColumnAndRow): Ditto.
3264         (AccessibilityUIElement::stringAttributeValue): Ditto.
3265         (alterCurrentValue): Ditto.
3266         (AccessibilityUIElement::press): Ditto.
3267         (AccessibilityUIElement::documentEncoding): Ditto.
3268         (AccessibilityUIElement::documentURI): Ditto.
3269         (AccessibilityUIElement::hasPopup): Ditto.
3270
3271         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3272         (WTR::indexRangeInTable): Use normalized checks.
3273         (WTR::alterCurrentValue): Ditto.
3274         (WTR::AccessibilityUIElement::getChildren): Ditto.
3275         (WTR::AccessibilityUIElement::getChildrenWithRange): Ditto.
3276         (WTR::AccessibilityUIElement::childrenCount): Ditto.
3277         (WTR::AccessibilityUIElement::elementAtPoint): Ditto.
3278         (WTR::AccessibilityUIElement::indexOfChild): Ditto.
3279         (WTR::AccessibilityUIElement::childAtIndex): Ditto.
3280         (WTR::AccessibilityUIElement::titleUIElement): Ditto.
3281         (WTR::AccessibilityUIElement::parentElement): Ditto.
3282         (WTR::AccessibilityUIElement::attributesOfChildren): Ditto.
3283         (WTR::AccessibilityUIElement::allAttributes): Ditto.
3284         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
3285         (WTR::AccessibilityUIElement::role): Ditto.
3286         (WTR::AccessibilityUIElement::title): Ditto.
3287         (WTR::AccessibilityUIElement::description): Ditto.
3288         (WTR::AccessibilityUIElement::orientation): Ditto.
3289         (WTR::AccessibilityUIElement::stringValue): Ditto.
3290         (WTR::AccessibilityUIElement::language): Ditto.
3291         (WTR::AccessibilityUIElement::x): Ditto.
3292         (WTR::AccessibilityUIElement::y): Ditto.
3293         (WTR::AccessibilityUIElement::width): Ditto.
3294         (WTR::AccessibilityUIElement::height): Ditto.
3295         (WTR::AccessibilityUIElement::intValue): Ditto.
3296         (WTR::AccessibilityUIElement::minValue): Ditto.
3297         (WTR::AccessibilityUIElement::maxValue): Ditto.
3298         (WTR::AccessibilityUIElement::rowCount): Ditto.
3299         (WTR::AccessibilityUIElement::columnCount): Ditto.
3300         (WTR::AccessibilityUIElement::cellForColumnAndRow): Ditto.
3301         (WTR::AccessibilityUIElement::press): Ditto.
3302         (WTR::AccessibilityUIElement::documentEncoding): Ditto.
3303         (WTR::AccessibilityUIElement::documentURI): Ditto.
3304         (WTR::AccessibilityUIElement::hasPopup): Ditto.
3305
3306 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
3307
3308         [ATK] accessibility/aria-sort.html is failing after r156409
3309         https://bugs.webkit.org/show_bug.cgi?id=121947
3310
3311         Reviewed by Chris Fleizach.
3312
3313         Implement AccessibilityUIElement::isSupported for the ATK
3314         platforms, just by checking whether we have an associated object
3315         attribute exposed for the wrapper object matching the required
3316         attribute in the layout test (e.g "AXSortDirection" -> "sort").
3317
3318         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3319         (AccessibilityUIElement::isAttributeSupported): Implemented.
3320         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3321         (WTR::AccessibilityUIElement::isAttributeSupported): Implemented.
3322
3323 2013-09-26  Eric Carlson  <eric.carlson@apple.com>
3324
3325         [MediaStream] make MediaStream testable
3326         https://bugs.webkit.org/show_bug.cgi?id=121967
3327
3328         Reviewed by Dean Jackson.
3329
3330         * DumpRenderTree/mac/UIDelegate.mm:
3331         (-[UIDelegate webView:decidePolicyForUserMediaRequestFromOrigin:listener:]): Add a very permissive
3332             user media request policy delegate.
3333
3334 2013-09-26  Brian J. Burg  <burg@cs.washington.edu>
3335
3336         build-webkit --inspector-frontend should copy WebInspectorUI files
3337         https://bugs.webkit.org/show_bug.cgi?id=117851
3338
3339         Reviewed by Joseph Pecoraro.
3340
3341         Change the --inspector-frontend build option to additionally build/copy 
3342         WebInspectorUI by setting it as the only project that needs to be built.
3343
3344         * Scripts/build-webkit:
3345
3346 2013-09-26  Zan Dobersek  <zdobersek@igalia.com>
3347
3348         XvfbDriver should set up Xvfb instances providing screens of 8-bit depth
3349         https://bugs.webkit.org/show_bug.cgi?id=121951
3350
3351         Reviewed by Carlos Garcia Campos.
3352
3353         Screens with 24-bit depth are causing problems as it doesn't seem to be possible to fall back to
3354         software rendering successfully on the GTK 64-bit release builder, resulting in crashes in almost
3355         500 layout tests that trigger accelerated compositing to be used.
3356
3357         * Scripts/webkitpy/port/xvfbdriver.py:
3358         (XvfbDriver._start):
3359         * Scripts/webkitpy/port/xvfbdriver_unittest.py: Update unit test baselines.
3360         (XvfbDriverTest.test_start_no_pixel_tests):
3361         (XvfbDriverTest.test_start_pixel_tests):
3362         (XvfbDriverTest.test_start_arbitrary_worker_number):
3363         (XvfbDriverTest.test_next_free_display):
3364         (XvfbDriverTest.test_start_next_worker):
3365
3366 2013-09-26  Tim Horton  <timothy_horton@apple.com>
3367
3368         Tiled drawing should not imply threaded scrolling
3369         https://bugs.webkit.org/show_bug.cgi?id=121874
3370         <rdar://problem/15071494>
3371
3372         Reviewed by Sam Weinig.
3373
3374         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3375         (WTR::PlatformWebView::PlatformWebView):
3376         The existing tiled-drawing layout tests require threaded scrolling to be enabled.
3377
3378 2013-09-26  Commit Queue  <commit-queue@webkit.org>
3379
3380         Unreviewed, rolling out r156457.
3381         http://trac.webkit.org/changeset/156457
3382         https://bugs.webkit.org/show_bug.cgi?id=121960
3383
3384         Broke webkitpy tests. (Requested by kling on #webkit).
3385
3386         * Scripts/webkitpy/port/xvfbdriver.py:
3387         (XvfbDriver._start):
3388
3389 2013-09-26  Zan Dobersek  <zdobersek@igalia.com>
3390
3391         XvfbDriver should set up Xvfb instances providing screens of 8-bit depth
3392         https://bugs.webkit.org/show_bug.cgi?id=121951
3393
3394         Reviewed by Carlos Garcia Campos.
3395
3396         Screens with 24-bit depth are causing problems as it doesn't seem to be possible to fall back to
3397         software rendering successfully on the GTK 64-bit release builder, resulting in crashes in almost
3398         500 layout tests that trigger accelerated compositing to be used.
3399
3400         * Scripts/webkitpy/port/xvfbdriver.py:
3401         (XvfbDriver._start):
3402
3403 2013-09-25  Alex Christensen  <achristensen@webkit.org>
3404
3405         Removed check for Apple Application Support directory in WinCairo port.
3406         https://bugs.webkit.org/show_bug.cgi?id=121869
3407
3408         Reviewed by Brent Fulgham.
3409
3410         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
3411         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
3412         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
3413         Use DLLLauncherWinCairo.props for WinCairo ports.
3414         * win/DLLLauncher/DLLLauncherMain.cpp:
3415         (wWinMain):
3416         Don't call modifyPath to check for AAS in the WinCairo port.
3417         * win/DLLLauncher/DLLLauncherWinCairo.props: Added to define WIN_CAIRO.
3418
3419 2013-09-25  Alex Christensen  <achristensen@webkit.org>
3420
3421         Enabled AssembleBuildLogs on WinCairo port.
3422         https://bugs.webkit.org/show_bug.cgi?id=121923
3423
3424         Reviewed by Brent Fulgham.
3425
3426         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
3427         Fixed reference to README, added WinCairo configurations.
3428         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj.filters:
3429         Fixed reference to README.
3430         * win/AssembleBuildLogs/AssembleLogs.cmd:
3431         Added ANGLE projects, skipped QTMovieWin for WinCairo, use PlatformArchitecture for Win64.
3432         * win/AssembleBuildLogs/README: Fixed spelling.
3433
3434 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
3435
3436         [WIN] Fix MSVC C4146 compiler warning
3437         https://bugs.webkit.org/show_bug.cgi?id=121838
3438
3439         Reviewed by Brent Fulgham.
3440
3441         Fix some variables from unsinged to int to fix the compiler warning
3442         "unary minus operator applied to unsigned type, result still unsigned".
3443
3444         * DumpRenderTree/WorkQueueItem.h:
3445         (BackItem::BackItem):
3446         (ForwardItem::ForwardItem):
3447         * DumpRenderTree/win/DumpRenderTree.cpp:
3448         (createWebViewAndOffscreenWindow):
3449
3450 2013-09-25  Zan Dobersek  <zdobersek@igalia.com>
3451
3452         [GTK] Switch the 64-bit Release builder to testing layout tests under WK2
3453         https://bugs.webkit.org/show_bug.cgi?id=121256
3454
3455         Reviewed by Martin Robinson.
3456
3457         Switch the GTK 64-bit Release builder to testing the layout tests under WebKit2.
3458         The GTK 64-bit Release WK2 testing builder is switched to now run layout tests under WebKit1.
3459
3460         * BuildSlaveSupport/build.webkit.org-config/config.json:
3461
3462 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
3463
3464         Add style checker for CMake lists
3465         https://bugs.webkit.org/show_bug.cgi?id=121764
3466
3467         Reviewed by Ryosuke Niwa.
3468
3469         Add an additional check to make sure that list of files are sorted.
3470         Exclude lists of include directories for now, since the order
3471         can be importent for compilation of some files.
3472
3473         * Scripts/webkitpy/style/checkers/cmake.py:
3474         (CMakeChecker.check):
3475         (CMakeChecker._check_indent):
3476         (CMakeChecker):
3477         (CMakeChecker._check_list_order):
3478         (CMakeChecker._list_item_path):
3479         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
3480         (CMakeCheckerTest.test_check):
3481
3482 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
3483
3484         CMakeChecker takes unusually long time to run
3485         https://bugs.webkit.org/show_bug.cgi?id=105662
3486
3487         Reviewed by Ryosuke Niwa.
3488
3489         Move the caching mechanism for regular expression of the C++ checker into
3490         a common file and use it for the CMake and ChangeLog checkers too.
3491
3492         * Scripts/webkitpy/style/checkers/changelog.py:
3493         (ChangeLogChecker.check_entry):
3494         * Scripts/webkitpy/style/checkers/cmake.py:
3495         (CMakeChecker._process_line):
3496         (CMakeChecker._check_no_space_cmds):
3497         (CMakeChecker._check_one_space_cmds):
3498         (CMakeChecker._check_non_lowercase_cmd):
3499         * Scripts/webkitpy/style/checkers/common.py:
3500         (match):
3501         (search):
3502         (searchIgnorecase):
3503         (sub):
3504         (subn):
3505         * Scripts/webkitpy/style/checkers/cpp.py:
3506
3507 2013-09-25  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3508
3509         [Qt] Fix build with Qt 5.2 QtPosition module
3510         https://bugs.webkit.org/show_bug.cgi?id=121089
3511
3512         Reviewed by Simon Hausmann.
3513
3514         QtLocation -> QtPositioning. Make sure we set build type before doing configure checks
3515         that might depend on them.
3516
3517         * qmake/mkspecs/features/default_pre.prf:
3518         * qmake/mkspecs/features/features.prf:
3519
3520 2013-09-25  Mario Sanchez Prada  <mario.prada@samsung.com>
3521
3522         [ATK] Fix style issues in AccessibilityUIElementAtk
3523         https://bugs.webkit.org/show_bug.cgi?id=121898
3524
3525         Reviewed by Chris Fleizach.
3526
3527         Avoid the '.f' suffix for float literals and use G_VALUE_INIT
3528         instead of { 0, { { 0 } } } to initialize a GValue.
3529
3530         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3531         (AccessibilityUIElement::clickPointX): Remove suffix.
3532         (AccessibilityUIElement::clickPointY): Ditto.
3533         (AccessibilityUIElement::intValue): Use G_VALUE_INIT and remove suffix.
3534         (AccessibilityUIElement::minValue): Ditto.
3535         (AccessibilityUIElement::maxValue): Ditto.
3536         (AccessibilityUIElement::numberAttributeValue): Remove suffix.
3537         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3538         (WTR::AccessibilityUIElement::numberAttributeValue): Remove suffix.
3539         (WTR::AccessibilityUIElement::x): Ditto.
3540         (WTR::AccessibilityUIElement::y): Ditto.
3541         (WTR::AccessibilityUIElement::width): Ditto.
3542         (WTR::AccessibilityUIElement::height): Ditto.
3543         (WTR::AccessibilityUIElement::clickPointX): Ditto.
3544         (WTR::AccessibilityUIElement::clickPointY): Ditto.
3545         (WTR::AccessibilityUIElement::intValue): Ditto.
3546         (WTR::AccessibilityUIElement::minValue): Ditto.
3547         (WTR::AccessibilityUIElement::maxValue): Ditto.
3548
3549 2013-09-25  Krzysztof Czech  <k.czech@samsung.com>
3550
3551         [EFL] accessibility/loading-iframe-sends-notification.html is failing
3552         https://bugs.webkit.org/show_bug.cgi?id=112003
3553
3554         Reviewed by Mario Sanchez Prada.
3555
3556         Enabled addNotificationListener and removeNotificationListener for EFL port.
3557
3558         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3559         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
3560         (WTR::AccessibilityController::removeNotificationListener):
3561
3562 2013-09-24  Filip Pizlo  <fpizlo@apple.com>
3563
3564         Crashing under JSC::DFG::SpeculativeJIT::spill visiting citicards.com
3565         https://bugs.webkit.org/show_bug.cgi?id=121844
3566
3567         Reviewed by Mark Hahnenberg.
3568
3569         * Scripts/run-javascriptcore-tests: Be more clear about what test suite failed.
3570
3571 2013-09-24  Alexey Proskuryakov  <ap@apple.com>
3572
3573         [Mac][WK2] Multiple font tests fail is there is a global setting for font antialiasing threshold
3574         https://bugs.webkit.org/show_bug.cgi?id=121854
3575
3576         Reviewed by Anders Carlsson.
3577
3578         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3579         (WTR::InjectedBundle::platformInitialize): Post a notification to update cached
3580         settings in underlying frameworks.
3581
3582 2013-09-24  Mark Rowe  <mrowe@apple.com>
3583
3584         <rdar://problem/14971518> WebKit should build against the Xcode default toolchain when targeting OS X 10.8
3585
3586         Reviewed by Dan Bernstein.
3587
3588         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3589         * MiniBrowser/Configurations/Base.xcconfig:
3590         * TestWebKitAPI/Configurations/Base.xcconfig:
3591         * WebKitLauncher/Configurations/Base.xcconfig:
3592         * WebKitTestRunner/Configurations/Base.xcconfig:
3593
3594 2013-09-24  Denis Nomiyama  <d.nomiyama@samsung.com>
3595
3596         [ATK] Missing WTR AccessibilityController::addNotificationListener implementation
3597         https://bugs.webkit.org/show_bug.cgi?id=121674
3598
3599         Reviewed by Mario Sanchez Prada.
3600
3601         Implemented the global notification listener for
3602         AccessibilityController. The signal is generated by
3603         AXObjectCache::postPlatformNotification() and received by
3604         axObjectEventListener(). axObjectEventListener will then invoke
3605         JSObjectCallAsFunction() with the respective callback function.
3606
3607         There is no additional test for this patch since its implementation will
3608         be tested by an accessibility layout test that is currently failing
3609         (accessibility/loading-iframe-sends-notification.html).
3610
3611         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Removed
3612         stub implementations of addNotificationListener and
3613         removeNotificationListener for the GTK port.
3614         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
3615         (WTR::AccessibilityController::addNotificationListener): Creates the
3616         notification handler and sets the notification function callback.
3617         (WTR::AccessibilityController::removeNotificationListener): Removes the
3618         global handler.
3619
3620 2013-09-24  Anton Obzhirov  <a.obzhirov@samsung.com>
3621
3622         [GTK] fast/images/exif-orientation-composited.html is failing
3623         https://bugs.webkit.org/show_bug.cgi?id=119731
3624
3625         Reviewed by Carlos Garcia Campos.
3626
3627         Add handling respect image orientation property in DRT.
3628
3629         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3630         (TestRunner::overridePreference):
3631
3632 2013-09-24  Zan Dobersek  <zdobersek@igalia.com>
3633
3634         [GTK] Bump the GTK+ dependency in the Wayland-specific Jhbuild moduleset
3635         https://bugs.webkit.org/show_bug.cgi?id=121787
3636
3637         Reviewed by Gustavo Noronha Silva.
3638
3639         * gtk/jhbuild-wayland.modules: Bump the GTK+ dependency that's intended for use when building
3640         with the Wayland target enabled to version 3.10.0.
3641
3642 2013-09-23  Patrick Gansterer  <paroga@webkit.org>
3643
3644         use NOMINMAX instead of #define min min
3645         https://bugs.webkit.org/show_bug.cgi?id=73563
3646
3647         Reviewed by Brent Fulgham.
3648
3649         Use NOMINMAX instead of #define min/max as a cleaner
3650         way of ensuring that Windows system header files don't
3651         define min/max as macro in the first place.
3652
3653         * DumpRenderTree/DumpRenderTreePrefix.h:
3654         * DumpRenderTree/cg/ImageDiffCG.cpp:
3655         * DumpRenderTree/config.h:
3656         * DumpRenderTree/win/ImageDiffCairo.cpp:
3657         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3658         * WebKitTestRunner/config.h:
3659
3660 2013-09-23  Benjamin Poulain  <benjamin@webkit.org>
3661
3662         Delete TestWebKitAPI domain or some keys before running TestWebKitAPI
3663         https://bugs.webkit.org/show_bug.cgi?id=121715 & <rdar://problem/14269434>
3664
3665         Reviewed by Alexey Proskuryakov.
3666
3667         Previously, initalizing a WebPreference would change the cache model
3668         to WebCacheModelDocumentBrowser. That behavior was due to a stale
3669         preference file on disk.
3670
3671         This patch fixes the tests by resetting the default, and using the proper
3672         default values after initializing WebPreference.
3673
3674         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
3675         (TestWebKitAPI::TEST): Use the proper initial value, unrelated
3676         to the previous runs.
3677
3678         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
3679         (TestWebKitAPI::TEST): This test needs b/f cache to be enabled, so change
3680         cache model to the one required.
3681
3682         * TestWebKitAPI/ios/mainIOS.mm:
3683         (main): Reset the preferences before testing.
3684         * TestWebKitAPI/mac/mainMac.mm:
3685         (main): Ditto.
3686
3687 2013-09-23  Benjamin Poulain  <benjamin@webkit.org>
3688
3689         Delete TestWebKitAPI domain or some keys before running TestWebKitAPI
3690         https://bugs.webkit.org/show_bug.cgi?id=121715 & <rdar://problem/14269434>
3691
3692         Reviewed by Alexey Proskuryakov.
3693
3694         Previously, initalizing a WebPreference would change the cache model
3695         to WebCacheModelDocumentBrowser. That behavior was due to a stale
3696         preference file on disk.
3697
3698         This patch fixes the tests by resetting the default, and using the proper
3699         default values after initializing WebPreference.
3700
3701         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
3702         (TestWebKitAPI::TEST): Use the proper initial value, unrelated
3703         to the previous runs.
3704
3705         * TestWebKitAPI/ios/mainIOS.mm:
3706         (main): Reset the preferences before testing.
3707         * TestWebKitAPI/mac/mainMac.mm:
3708         (main): Ditto.
3709
3710 2013-09-23  Anders Carlsson  <andersca@apple.com>
3711
3712         ListHashSet should work with move-only types
3713         https://bugs.webkit.org/show_bug.cgi?id=121802
3714
3715         Reviewed by Andreas Kling.
3716
3717         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
3718         (TestWebKitAPI::TEST):
3719         Add a test for move-only types.
3720
3721 2013-09-23  Alex Christensen  <alex.christensen@flexsim.com>
3722
3723         Added --64-bit option for Windows build.
3724         https://bugs.webkit.org/show_bug.cgi?id=121799
3725
3726         Reviewed by Brent Fulgham.
3727
3728         * Scripts/webkitdirs.pm:
3729         (determinePassedConfiguration): Add "|x64" for 64-bit configuration.
3730         (isWin64): Added.
3731         (determineIsWin64): Added.
3732
3733 2013-09-23  Anders Carlsson  <andersca@apple.com>
3734
3735         ListHashSet should use std::reverse_iterator for reverse iterators
3736         https://bugs.webkit.org/show_bug.cgi?id=121795
3737
3738         Reviewed by Antti Koivisto.
3739
3740         Add test for reverse iterators.
3741
3742         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
3743         (TestWebKitAPI::TEST):
3744
3745 2013-09-23  Krzysztof Czech  <k.czech@samsung.com>
3746
3747         [EFL] accessibility/aria-invalid is failing
3748         https://bugs.webkit.org/show_bug.cgi?id=111986
3749
3750         Reviewed by Mario Sanchez Prada.
3751
3752         Adds possibility to retrieve JS context.
3753         This is part of the implementation of AccessibilityUIElement::addNotificationListener
3754         from 119883 and 120421.
3755
3756         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
3757         (axObjectEventListener):
3758         (addAccessibilityNotificationHandler):
3759         (removeAccessibilityNotificationHandler):
3760         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3761         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
3762         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
3763
3764 2013-09-20  Mark Rowe  <mrowe@apple.com>
3765
3766         <https://webkit.org/b/90090> build-webkit should verify that your tools are up-to-date
3767
3768         Enforce a minimum OS version of 10.7.5 and Xcode version of 4.6.
3769
3770         Reviewed by David Kilzer.
3771
3772         * Scripts/webkitdirs.pm:
3773         (checkRequiredSystemConfig):
3774
3775 2013-09-20  Mario Sanchez Prada  <mario.prada@samsung.com>
3776
3777         [ATK] Do not expose aria-help in ATK based platforms
3778         https://bugs.webkit.org/show_bug.cgi?id=121675
3779
3780         Reviewed by Chris Fleizach.
3781
3782         Remove the implementations for AccessibilityUIElement::helpText()
3783         from DRT and WKTR for GTK and EFL, since they are based on the
3784         AccessibilityObject::helpText() method and the 'aria-help'
3785         attributes, which is wrong since they should not depend on that
3786         but in ATK specific API (see also http://webkit.org/b/121684).
3787
3788         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3789         (AccessibilityUIElement::helpText): Added a new and empty
3790         implementation, now that we are no longer using this in ATK.
3791         * DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Removed file
3792         as the only function provided here was helpText().
3793         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Ditto.
3794         * DumpRenderTree/efl/CMakeLists.txt: AccessibilityUIElementEfl.cpp
3795         removed from the list of sources to compile.
3796         * GNUmakefile.am: Likewise, but for AccessibilityUIElementGtk.cpp.
3797         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3798         (WTR::AccessibilityUIElement::helpText): Replaced old implementation
3799         based in DumpRenderTreeSupportGtk with an empty one.
3800
3801 2013-09-20  Dan Bernstein  <mitz@apple.com>
3802
3803         Make extract-localizable-strings available to WebCore clients
3804         https://bugs.webkit.org/show_bug.cgi?id=121699
3805
3806         Reviewed by Darin Adler.
3807
3808         * Scripts/extract-localizable-strings: Copied to
3809         Soure/WebCore/extract-localizaebl-strings.pl, and changed this into a shell script that
3810         executes the script from its new location. This is a temporary measure until certain code
3811         that is external to WebKit is adapted to the new location.
3812         * Scripts/update-webkit-localizable-strings: Changed to call extract-localizable-strings.pl
3813         from its new location.
3814
3815 2013-09-20  Patrick Gansterer  <paroga@webkit.org>
3816
3817         Nuke remaining VS2005 tools from the tree.
3818         https://bugs.webkit.org/show_bug.cgi?id=121691
3819
3820         Reviewed by Brent Fulgham.
3821
3822         * CLWrapper/CLWrapper.cpp: Removed.
3823         * CLWrapper/CLWrapper.sln: Removed.
3824         * CLWrapper/CLWrapper.vcproj: Removed.
3825         * MIDLWrapper/MIDLWrapper.cpp: Removed.
3826         * MIDLWrapper/MIDLWrapper.sln: Removed.
3827         * MIDLWrapper/MIDLWrapper.vcproj: Removed.
3828         * Scripts/parallelcl: Removed.
3829         * vcbin/cl.exe: Removed.
3830         * vcbin/midl.exe: Removed.
3831
3832 2013-09-20  Mario Sanchez Prada  <mario.prada@samsung.com>
3833
3834         [GTK] socket_embed_hook hitting NULL-check assertion running TestWebKit2
3835         https://bugs.webkit.org/show_bug.cgi?id=121294
3836
3837         Reviewed by Martin Robinson.
3838
3839         Provide a new patch to deal with the issue in the GTK+ module from
3840         the internal jhbuild environment. This issue has been reported
3841         upstream (see https://bugzilla.gnome.org/show_bug.cgi?id=708024).
3842
3843         * gtk/jhbuild.modules: Apply the new patch to the GTK+ module.
3844         * gtk/patches/gtk-3.6-do-not-shutdown-accessibility.patch: Added.
3845
3846 2013-09-20  Denis Nomiyama  <d.nomiyama@samsung.com>
3847
3848         [ATK][WTR] accessibility/aria-invalid.html times out
3849         https://bugs.webkit.org/show_bug.cgi?id=121668
3850
3851         Reviewed by Mario Sanchez Prada.
3852
3853         Fixed WTR::AccessibilityUIElement::stringAttributeValue() to return
3854         false in case of aria-invalid event with empty value.
3855
3856         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3857         (WTR::AccessibilityUIElement::stringAttributeValue): Returns false in
3858         case of aria-invalid event with empty value.
3859
3860 2013-09-20  Denis Nomiyama  <d.nomiyama@samsung.com>
3861
3862         [ATK] Missing WTR AccessibilityUIElement::addNotificationListener implementation
3863         https://bugs.webkit.org/show_bug.cgi?id=120421
3864
3865         Reviewed by Mario Sanchez Prada.
3866
3867         Implemented the notification listener for AccessibilityUIElement for
3868         WebKitTestRunner. The signal is generated by
3869         AXObjectCache::postPlatformNotification() and received by
3870         axObjectEventListener(). axObjectEventListener() will then invoke
3871         JSObjectCallAsFunction() with the respective callback function. The
3872         notification handlers are stored in HashMap in
3873         AccessibilityNotificationHandlerAtk.cpp.
3874
3875         Moved ATK signal handling (printAccessibilityEvent and
3876         axObjectEventListener) to AccessibilityNotificationHandlerAtk.cpp.
3877
3878         * WebKitTestRunner/CMakeLists.txt: Added InjectedBundle/atk to the
3879         include path.
3880         * WebKitTestRunner/GNUmakefile.am:
3881         Added AccessibilityNotificationHandlerAtk.cpp/h.
3882         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Moved
3883         listener IDs to AccessibilityNotificationHandlerAtk.cpp.
3884         * WebKitTestRunner/InjectedBundle/AccessibilityController.h: Moved
3885         listener IDs to AccessibilityNotificationHandlerAtk.cpp.
3886         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added a
3887         notification handler for GTK+ and EFL.
3888         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
3889         Moved printAccessibilityEvent and axObjectEventListener to
3890         AccessibilityNotificationHandlerAtk.cpp.
3891         (WTR::AccessibilityController::logAccessibilityEvents): Moved listener
3892         IDs to AccessibilityNotificationHandlerAtk.cpp.
3893         (WTR::AccessibilityController::resetToConsistentState): Moved listener
3894         IDs to AccessibilityNotificationHandlerAtk.cpp.
3895         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Added.
3896         (WTR::printAccessibilityEvent): Prints accessibility events. This
3897         function was moved from AccessibilityControllerAtk.cpp.
3898         (WTR::axObjectEventListener): Callback for signals. This function was
3899         moved from AccessibilityControllerAtk.cpp.
3900         (WTR::AccessibilityNotificationHandler::AccessibilityNotificationHandler):
3901         Initialize element and function callback.
3902         (WTR::AccessibilityNotificationHandler::~AccessibilityNotificationHandler):
3903         Removes handler from HashMap and disconnects callbacks if necessary.
3904         (WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Sets
3905         logging mode and connects callbacks.
3906         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
3907         Sets the notification callback and connects callback to signals.
3908         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
3909         Removes the notification callback from HashMap.
3910         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
3911         Connects axObjectEventListener to ATK signals.
3912         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
3913         Disconnects callback.
3914         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h: Added.
3915         (WTR::AccessibilityNotificationHandler::create): Creates a new instance
3916         of AccessibilityNotificationHandler.
3917         (WTR::AccessibilityNotificationHandler::setPlatformElement): Sets the
3918         element.
3919         (WTR::AccessibilityNotificationHandler::platformElement): Gets the
3920         element.
3921         (WTR::AccessibilityNotificationHandler::notificationFunctionCallback):
3922         Gets the notification callback.
3923         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3924         (WTR::AccessibilityUIElement::addNotificationListener): Creates
3925         notification handler, set the platform element and the notification
3926         callback.
3927         (WTR::AccessibilityUIElement::removeNotificationListener): Deletes the
3928         notification handler.
3929         * WebKitTestRunner/PlatformEfl.cmake:
3930         Added AccessibilityNotificationHandlerAtk.cpp.
3931
3932 2013-09-20  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3933
3934         Update features.pri
3935         https://bugs.webkit.org/show_bug.cgi?id=121670
3936
3937         Reviewed by Jocelyn Turcotte.
3938
3939         Remove feature flags that no longer exists and new ones added to FeatureList.pm
3940
3941         * qmake/mkspecs/features/features.pri:
3942
3943 2013-09-20  Krzysztof Czech  <k.czech@samsung.com>
3944
3945         [GTK][WK2] accessibility/selection-states.html is failing
3946         https://bugs.webkit.org/show_bug.cgi?id=116972
3947
3948         Reviewed by Mario Sanchez Prada.
3949
3950         isSelectable() was not exposed in Accessibility.
3951
3952         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3953
3954 2013-09-19  Dan Bernstein  <mitz@apple.com>
3955
3956         Attempted build fix after r156114.
3957
3958         * Scripts/copy-webkitlibraries-to-product-directory: Removed references to WebCoreSQLite3.
3959
3960 2013-09-19  Alexey Proskuryakov  <ap@apple.com>
3961
3962         REGRESSION (r129451): run-safari --no-saved-state is broken
3963         https://bugs.webkit.org/show_bug.cgi?id=121566
3964
3965         Undo a last minute change that doesn't actually work.
3966
3967         * Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp): "-1" cannot be passed
3968         via command line, <rdar://problem/15032886>.
3969
3970 2013-09-19  Dan Bernstein  <mitz@apple.com>
3971
3972         Add a style guideline regarding spacing in range-based for loops
3973         https://bugs.webkit.org/show_bug.cgi?id=121620
3974
3975         Reviewed by Anders Carlsson.
3976
3977         * Scripts/webkitpy/style/checkers/cpp.py:
3978         (check_spacing): Added checking that there are spaces around the colon in a range-based for
3979         loop.
3980         (CppChecker): Added whitespace/colon to the categories set.
3981         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3982         (WebKitStyleTest.test_spacing): Added two tests for the new check.
3983
3984 2013-09-18  Sam Weinig  <sam@webkit.org>
3985
3986         Replace use of OwnArrayPtr<Foo> with std::unique_ptr<Foo[]> in Tools
3987         https://bugs.webkit.org/show_bug.cgi?id=121588
3988
3989         Reviewed by Anders Carlsson.
3990
3991         * DumpRenderTree/TestRunner.cpp:
3992         * ImageDiff/efl/ImageDiff.cpp:
3993         * TestWebKitAPI/JavaScriptTest.cpp:
3994         * TestWebKitAPI/PlatformUtilities.cpp:
3995         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3996         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3997         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3998         * WebKitTestRunner/StringFunctions.h:
3999         * WebKitTestRunner/TestInvocation.cpp:
4000         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
4001         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
4002
4003 2013-09-18  Bem Jones-Bey  <bjonesbe@adobe.com>
4004
4005         W3C Test Import script reformats test HTML
4006         https://bugs.webkit.org/show_bug.cgi?id=119159
4007
4008         Reviewed by Dirk Pranke.
4009
4010         Completely rewrite the test conversion process to minimize
4011         reformatting when adding prefixes, etc. This isn't 100% perfect, there
4012         are still places where it will end up changing the formatting, but it
4013         is much better than before. Most notably, the public interface to the
4014         test converter has changed: now one calls a method instead of creating
4015         an instance of the test converter class. This is because the test
4016         converter class now has state, so one really needs a new instance for
4017         each test.
4018
4019         Note that this also lays some simple groundwork for being able to use
4020         a MockHost in the tests.
4021
4022         * Scripts/webkitpy/w3c/test_converter.py:
4023         (convert_for_webkit):
4024         (_W3CTestConverter):
4025         (_W3CTestConverter.__init__):
4026         (_W3CTestConverter.output):
4027         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
4028         (_W3CTestConverter.convert_style_data):
4029         (_W3CTestConverter.convert_attributes_if_needed):
4030         (_W3CTestConverter.handle_starttag):
4031         (_W3CTestConverter.handle_endtag):
4032         (_W3CTestConverter.handle_startendtag):
4033         (_W3CTestConverter.handle_data):
4034         (_W3CTestConverter.handle_entityref):
4035         (_W3CTestConverter.handle_charref):
4036         (_W3CTestConverter.handle_comment):
4037         (_W3CTestConverter.handle_decl):
4038         (_W3CTestConverter.handle_pi):
4039         * Scripts/webkitpy/w3c/test_converter_unittest.py:
4040         (W3CTestConverterTest):
4041         (W3CTestConverterTest.fake_dir_path):
4042         (W3CTestConverterTest.test_read_prefixed_property_list):
4043         (verify_no_conversion_happened):
4044         * Scripts/webkitpy/w3c/test_importer.py:
4045         (TestImporter.import_tests):
4046
4047 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
4048
4049         Get rid of the jsc-test-list by moving all not-jsc-capable tests into js/dom
4050         https://bugs.webkit.org/show_bug.cgi?id=121578
4051
4052         Rubber stamped by Geoffrey Garen.
4053
4054         * Scripts/run-layout-jsc:
4055
4056 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
4057
4058         Unreviewed, fix for Ruby 1.8.
4059
4060         * Scripts/run-jsc-stress-tests:
4061
4062 2013-09-17  Filip Pizlo  <fpizlo@apple.com>
4063
4064         run-jsc-stress-tests should make it easier to look at error spew from tests
4065         https://bugs.webkit.org/show_bug.cgi?id=121531
4066
4067         Reviewed by Mark Hahnenberg.
4068         
4069         This makes two changes:
4070         
4071         - The out/err spew from each test is now saved to a .out file in jsc-stress-results.
4072         
4073         - The same spew also goes to the console but is prefixed by the test's name.
4074         
4075         This required some tee and awk hacks, and then some sh hacks to work around the fact
4076         that if you do "(foo | bar) || baz", and foo fails, then baz won't run - the ||
4077         operator will only see a failure of bar failed. So to pass output to tee and awk, I
4078         needed to do weird things.
4079
4080         * Scripts/run-jsc-stress-tests:
4081
4082 2013-09-18  Alexey Proskuryakov  <ap@apple.com>
4083
4084         REGRESSION (r129451): run-safari --no-saved-state is broken
4085         https://bugs.webkit.org/show_bug.cgi?id=121566
4086
4087         Reviewed by Mark Rowe.
4088
4089         * Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp):
4090         Check arguments, not the newly created empty array. Pass a value that silences warnings.
4091         While at it, removed a check for Snow Leopard.
4092
4093 2013-09-18  Alex Christensen  <achristensen@webkit.org>
4094
4095         Improved WinLauncher's URL handling.
4096         https://bugs.webkit.org/show_bug.cgi?id=121535
4097
4098         Reviewed by Brent Fulgham.
4099
4100         * WinLauncher/WinLauncher.cpp:
4101         (EditProc):
4102         Use INTERNET_MAX_URL_LENGTH instead of our MAX_URL_LENGTH.
4103         (loadURL):
4104         Prepend "http://" to URLs with no scheme.
4105
4106 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
4107
4108         DFG should support Int52 for local variables
4109         https://bugs.webkit.org/show_bug.cgi?id=121064
4110
4111         Reviewed by Oliver Hunt.
4112
4113         * Scripts/run-jsc-stress-tests:
4114
4115 2013-09-18  peavo@outlook.com  <peavo@outlook.com>
4116
4117         [Win] TestWebKitAPI does not compile.
4118         https://bugs.webkit.org/show_bug.cgi?id=121485
4119
4120         Reviewed by Brent Fulgham.
4121
4122         It is no longer possible to inherit from WebCore::BitmapImage, which the test relies on.
4123         Instead, load a bitmap, then destroy the decoded data, which will cause WebCore::frameAtIndex()
4124         to return null, which is the case we want to test.
4125
4126         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
4127         (TestWebKitAPI::TEST):
4128
4129 2013-09-18  Mario Sanchez Prada  <mario.prada@samsung.com>
4130
4131         [ATK] Expose aria-haspopup and aria-sort without the 'aria-' prefix
4132         https://bugs.webkit.org/show_bug.cgi?id=121495
4133
4134         Reviewed by Chris Fleizach.
4135
4136         Adapted DRT and WKTR to deal with the new names for the ATK object
4137         attributes being exposed for 'aria-haspopup' and 'aria-sort'.
4138
4139         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
4140         (coreAttributeToAtkAttribute): Updated translation between ATK and DRT.
4141         (AccessibilityUIElement::stringAttributeValue): Ditto.
4142         (AccessibilityUIElement::hasPopup): Ditto.
4143         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4144         (WTR::coreAttributeToAtkAttribute): Updated translation between ATK and WKTR.
4145         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
4146         (WTR::AccessibilityUIElement::hasPopup): Ditto.
4147
4148 2013-09-18  Commit Queue  <commit-queue@webkit.org>
4149
4150         Unreviewed, rolling out r156019 and r156020.
4151         http://trac.webkit.org/changeset/156019
4152         http://trac.webkit.org/changeset/156020
4153         https://bugs.webkit.org/show_bug.cgi?id=121540
4154
4155         Broke tests (Requested by ap on #webkit).
4156
4157         * Scripts/run-jsc-stress-tests:
4158
4159 2013-09-17  Gwang Yoon Hwang  <ryumiel@company100.net>
4160
4161         Unreviewed. Add myself as a committer.
4162
4163         * Scripts/webkitpy/common/config/contributors.json:
4164
4165 2013-09-17  Jae Hyun Park  <jae.park@company100.net>
4166
4167         Unreviewed. Add myself as a committer.
4168
4169         * Scripts/webkitpy/common/config/contributors.json:
4170
4171 2013-09-17  Filip Pizlo  <fpizlo@apple.com>
4172
4173         DFG should support Int52 for local variables
4174         https://bugs.webkit.org/show_bug.cgi?id=121064
4175
4176         Reviewed by Oliver Hunt.
4177
4178         * Scripts/run-jsc-stress-tests:
4179
4180 2013-09-17  Alex Christensen  <alex.christensen@flexsim.com>
4181
4182         Added back and forward buttons to WinLauncher.
4183         https://bugs.webkit.org/show_bug.cgi?id=121212
4184
4185         Reviewed by Brent Fulgham.
4186
4187         * WinLauncher/WinLauncher.cpp:
4188         (resizeSubViews):
4189         Move new back and forward buttons to correct positions before URL bar.
4190         (dllLauncherEntryPoint): 
4191         Store the default button window procedure and replace with my button procedures.
4192         (EditProc): Updated style and renamed from MyEditProc.
4193         (BackButtonProc): Added.
4194         (ForwardButtonProc): Added.
4195
4196 2013-09-17  Michael Saboff  <msaboff@apple.com>
4197
4198         Unreviewed typo fix after r155999
4199
4200         Changed en_US.UTB-8 to en_US.UTF-8
4201
4202         * Scripts/run-javascriptcore-tests:
4203
4204 2013-09-17  Michael Saboff  <msaboff@apple.com>
4205
4206         run-jsc-stress-tests fails with ruby version 2
4207         https://bugs.webkit.org/show_bug.cgi?id=121521
4208
4209         Reviewed by Jessie Berlin.
4210
4211         Explicitly set LANG to en_US.UTB-8 before starting run-jsc-stress-tests.
4212
4213         * Scripts/run-javascriptcore-tests:
4214
4215 2013-09-17  Brent Fulgham  <bfulgham@apple.com>
4216
4217         [Windows] Unreviewed build fix after r155963.
4218
4219         * DumpRenderTree/win/TestRunnerWin.cpp:
4220         (TestRunner::evaluateScriptInIsolatedWorld): Pass nullptr rather than 0.
4221
4222 2013-09-17  Anders Carlsson  <andersca@apple.com>
4223
4224         Fix a typo.
4225
4226         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
4227         (TestWebKitAPI::TEST):
4228
4229 2013-09-16  Anders Carlsson  <andersca@apple.com>
4230
4231         HashMap should work with move-only keys
4232         https://bugs.webkit.org/show_bug.cgi?id=121310
4233
4234         Reviewed by Darin Adler.
4235
4236         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
4237         (TestWebKitAPI::TEST):
4238         Add test.
4239
4240 2013-09-17  YuTeh Shen  <shenyute@hotmail.com>
4241
4242         BrowserMarshal.h build fail
4243         https://bugs.webkit.org/show_bug.cgi?id=102938
4244
4245         Reviewed by Carlos Garcia Campos.
4246
4247         Fix variable name.
4248
4249         * MiniBrowser/gtk/GNUmakefile.am:
4250
4251 2013-09-16  Brent Fulgham  <bfulgham@apple.com>
4252
4253         [Windows] Clean up WinLauncher by using smart pointers
4254         https://bugs.webkit.org/show_bug.cgi?id=121467
4255
4256         Reviewed by Anders Carlsson.
4257
4258         * WinLauncher/PrintWebUIDelegate.cpp:
4259         (PrintWebUIDelegate::webViewPrintingMarginRect): Switch to smart pointers.
4260         * WinLauncher/WinLauncher.cpp:
4261         (WinLauncherWebHost::updateAddressBar): Use _bstr_t and smart pointers.
4262         (WinLauncherWebHost::didFailProvisionalLoadWithError): Ditto.
4263         (showLastVisitedSites): Smart pointer updates.
4264         (WinLauncherWebHost::didFinishLoadForFrame): Ditto.
4265         (setToDefaultPreferences): Ditto.
4266         (dllLauncherEntryPoint): Ditto.
4267         (PrintView): Ditto.
4268         (LaunchInspector): Ditto.
4269         (NavigateToHistory): Ditto.
4270         (MyEditProc): Ditto.
4271         (loadURL): Ditto.
4272
4273 2013-09-16  Brent Fulgham  <bfulgham@apple.com>
4274
4275         [Windows] Add rudimentary history to WinLauncher.
4276         https://bugs.webkit.org/show_bug.cgi?id=121463
4277
4278         Reviewed by Anders Carlsson.
4279
4280         * WinLauncher/WinLauncher.cpp:
4281         (updateMenuItemForHistoryItem): Added
4282         (showLastVisitedSites): Added
4283         (WinLauncherWebHost::didFinishLoadForFrame): Add history item once
4284         a new page has been visited.
4285         (dllLauncherEntryPoint): Deallocate history on exit.
4286         (NavigateToHistory): Added
4287         (WndProc): Add handler for history entries
4288         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add menu items to hold
4289         up to 10 history slots.
4290         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link against
4291         Windows utility library to allow use of _bstr_t type.
4292         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Add menu items
4293         to hold up to 10 history slots.
4294         * WinLauncher/stdafx.h: Add <comutil.h> to precompiled headers.
4295
4296 2013-09-16  Gustavo Noronha Silva  <gns@gnome.org>
4297
4298         [GTK] Make symbol export filter more strict, and disable for dev/test builds
4299         https://bugs.webkit.org/show_bug.cgi?id=120586
4300
4301         Reviewed by Martin Robinson.
4302
4303         * GNUmakefile.am: moved GtkLauncher and documentation builds to their own
4304         makefiles, so they can be included unconditionally.
4305         * GtkLauncher/GNUmakefile.am: added.
4306         * Scripts/webkitdirs.pm:
4307         (runAutogenForAutotoolsProjectIfNecessary): always pass --enable-developer-mode