iOS build fix after Yosemite build fix broke iOS build.
[WebKit-https.git] / Tools / ChangeLog
1 2016-02-03  Jer Noble  <jer.noble@apple.com>
2
3         iOS build fix after Yosemite build fix broke iOS build.
4
5         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
6
7 2016-02-03  Jer Noble  <jer.noble@apple.com>
8
9         Yosemite build fix; hide the entire WebCoreNSURLSessionDataTask class from Yosemite and prior.
10
11         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
12
13 2016-02-03  Joonghun Park  <jh718.park@samsung.com>
14
15         [Tools] Remove $additionalCMakeArgs variable because without this variable --cmakeargs options works well
16         https://bugs.webkit.org/show_bug.cgi?id=153827
17
18         Reviewed by Michael Catanzaro.
19
20         When an array is passed to subroutines as argument in perl,
21         a list containing its element is returned from the array.
22         Currently @$ arguments are being passed, then it is going to be one list
23         including all the elements not only from @ but also from $.
24         As a result, --cmakeargs option's value is included in @cmakeArgs
25         at generateBuildSystemFromCMakeProject subroutine,
26         so $additionalCMakeArgs doesn't needed anymore.
27
28         * Scripts/webkitdirs.pm:
29         (generateBuildSystemFromCMakeProject):
30
31 2016-02-03  Jer Noble  <jer.noble@apple.com>
32
33         [Mac] Wrap a resource and resource loader in a NSURLSession-like object for use by lower level frameworks
34         https://bugs.webkit.org/show_bug.cgi?id=153669
35
36         Reviewed by Alex Christensen.
37
38         Add an API test for WebCoreNSURLSession, testing that it behaves like a regulare NSURLSession, including
39         calling appropriate NSURLSessionDelegate callbacks.
40
41         Drive-by fix: Add a FeatureDefines.xcconfig to TestWebKitAPI.  Without this, the ENABLE macros in WebCore
42         header files will not match the one used when compiling WebCore, leading to strange crashes and weird
43         inconsistencies when calling, e.g., inline methods.
44
45         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Added.
46         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
47         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
48         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm: Added.
49         (-[TestNSURLSessionLoaderDelegate webView:didCommitLoadForFrame:]):
50         (-[TestNSURLSessionDataDelegate URLSession:task:didCompleteWithError:]):
51         (-[TestNSURLSessionDataDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):
52         (-[TestNSURLSessionDataDelegate URLSession:dataTask:didReceiveData:]):
53         (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
54         (TestWebKitAPI::WebCoreNSURLSessionTest::TearDown):
55         (TestWebKitAPI::TEST_F):
56
57 2016-02-03  Konstantin Tokarev  <annulen@yandex.ru>
58
59         [webkitdirs] Clarify logic behind is{PortName} functions.
60         https://bugs.webkit.org/show_bug.cgi?id=153554
61
62         Reviewed by Michael Catanzaro.
63
64         * Scripts/webkitdirs.pm:
65         (prohibitUnknownPort): This function makes determinePortName()
66         failure fatal.
67         (determinePortName): Added new function which decides which port are
68         we building based on command line switches and platform defaults.
69         (portName): Added getter for determined $portName.
70         (isEfl): Modified to use portName().
71         (isGtk): Ditto.
72         (isWinCairo): Ditto.
73         (isAppleMacWebKit): Ditto.
74         (isAppleWinWebKit): Ditto.
75         (isIOSWebKit): Ditto.
76         (cmakeBasedPortName): Return portName() with capitalized first letter.
77         (determineIsEfl): Deleted.
78         (determineIsGtk): Deleted.
79         (determineIsWinCairo): Deleted.
80
81         * Scripts/build-jsc: Call prohibitUnknownPort().
82         * Scripts/run-minibrowser: Ditto.
83         * Scripts/webkitperl/FeatureList.pm: Ditto.
84         * Scripts/update-webkit: Call determinePortName() instead of
85         determineIsWinCairo().
86
87 2016-02-02  Dan Bernstein  <mitz@apple.com>
88
89         Better fix for Layout Test fast/parser/external-entities-in-xslt.xml is flaky on El Capitan (but fails most of the time)
90         https://bugs.webkit.org/show_bug.cgi?id=153683
91
92         Reviewed by Darin Adler.
93
94         * Scripts/webkitpy/port/driver.py:
95         (Driver._setup_environ_for_driver): Reverted change from r196013. DUMPRENDERTREE_TEMP is not
96           used by any code in the Web Content process. If that ever changed, we should send it over
97           as a bundle parameter.
98
99         * Scripts/webkitpy/port/ios.py:
100         (IOSSimulatorPort.setup_environ_for_server): Reverted change from r196013.
101
102         * Scripts/webkitpy/port/mac.py:
103         (MacPort.setup_environ_for_server): Ditto.
104
105         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
106         (WTR::InjectedBundle::platformInitialize): Set XML_CATALOG_FILES in the Web Process
107           environment. This is early enough that libxml2 has not been initialized yet.
108
109         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
110         (WTR::InjectedBundle::platformInitialize): Ditto.
111
112 2016-02-02  Dan Bernstein  <mitz@apple.com>
113
114         Layout Test fast/parser/external-entities-in-xslt.xml is flaky on El Capitan (but fails most of the time)
115         https://bugs.webkit.org/show_bug.cgi?id=153683
116
117         Reviewed by Alexey Proskuryakov.
118
119         Ensure that XML_CATALOG_FILES is set in the Web Content service’s environment as well.
120
121         * Scripts/webkitpy/port/driver.py:
122         (Driver._setup_environ_for_driver): Also set __XPC_DUMPRENDERTREE_TEMP.
123         * Scripts/webkitpy/port/ios.py:
124         (IOSSimulatorPort.setup_environ_for_server): Set __XPC_XML_CATALOG_FILES.
125         * Scripts/webkitpy/port/mac.py:
126         (MacPort.setup_environ_for_server): Ditto.
127
128 2016-01-29 Grzegorz Czajkowski  <g.czajkowski@samsung.com>
129
130         [EFL] Virtual Keyboard overlaps MiniBrowser's WebView
131         https://bugs.webkit.org/show_bug.cgi?id=153009
132
133         Reviewed by Gyuyoung Kim.
134
135         On mobile, virtual keyboard represented by ecore_imf module appears on
136         the top of application layer usually covering bottom part of the screen.
137         If the web page contains the editable content on the bottom of the page
138         it will be overlapped by keyboard which prevents user from seeing the
139         typed text.
140
141         Pack MiniBrowser layout into conformant widget to allow EFL to guess
142         the space that will be required by the keyboard, finally resizing it
143         to the desired size. As a result, webview gets resized and scrolled
144         into focused elements which makes the editable elements visible while
145         typing.
146
147         More details about elm_conformant widger can be found at:
148         https://docs.enlightenment.org/elementary/1.15.0/group__Conformant.html
149         https://docs.enlightenment.org/elementary/1.15.0/conformant_example.html
150
151         * MiniBrowser/efl/main.c:
152         (window_create): pack a box into conformant widget.
153
154 2016-02-02  Alejandro G. Castro  <alex@igalia.com>
155
156         [GTK][EFL] Upgrade OpenWebRTC dependency
157         https://bugs.webkit.org/show_bug.cgi?id=153489
158
159         Reviewed by Philippe Normand.
160
161         * Scripts/run-gtk-tests:
162         (TestRunner): Avoid running the mediastream API test.
163         * Scripts/webkitperl/FeatureList.pm: Stop compiling mediastream by
164         default for gtk and efl.
165         * gtk/jhbuild-webrtc.modules: Added modules files with
166         dependencies required to compile and test the mediastream.
167
168 2016-02-01  Jason Marcell  <jmarcell@apple.com>
169
170         Add code to parse the git branches out of the Trac RSS feed
171         https://bugs.webkit.org/show_bug.cgi?id=153624
172
173         Reviewed by Daniel Bates.
174
175         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
176         (Trac.prototype.commitsOnBranch): Update filter to check for Git branches.
177         (Trac.prototype._convertCommitInfoElementToObject): Parse Git branches from the Trac RSS feed. Also changed "branchName" to
178         "branches" and updated the code to work with an array instead of a string.
179         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
180         (MockTrac): Refactored example commits out into a constant, MockTrac.EXAMPLE_TRAC_COMMITS.
181         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-git-trac-rss.xml: Added. Test
182         fixture that contains XML with a Git branch.
183         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit test to test parsing Git
184         branches from Trac RSS feed. Also updated code to work with the new MockTrac.EXAMPLE_TRAC_COMMITS constant.
185
186 2016-02-01  Brady Eidson  <beidson@apple.com>
187
188         Add command line flag to DRT to output the number of tests completed in server mode.
189         https://bugs.webkit.org/show_bug.cgi?id=153750
190
191         Reviewed by Darin Adler.
192
193         * DumpRenderTree/mac/DumpRenderTree.mm:
194         (initializeGlobalsFromCommandLineOptions):
195         (runTestingServerLoop):
196
197 2016-02-01  Jason Marcell  <jmarcell@apple.com>
198
199         Improvements to botwatcher's dashboard unit tests.
200         https://bugs.webkit.org/show_bug.cgi?id=153621
201
202         Reviewed by Darin Adler.
203
204         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
205         (PopoverTracker): Retain a reference to the PopoverTracker so that we can make assertions about it in the unit tests.
206         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
207         (MockTrac): Changing revision 33019 to be on a different branch so that _appendPendingRevisionCount and
208         _popoverLinesForCommitRange have to traverse commits from different branches.
209         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Changing equal to strictEqual
210         in unit test for _appendPendingRevisionCount. Also added assertions for Popover in test for
211         _revisionContentWithPopoverForIteration.
212
213 2016-02-01  Jason Marcell  <jmarcell@apple.com>
214
215         Refactor to add event listeners and start periodic updates for all trac instances.
216         https://bugs.webkit.org/show_bug.cgi?id=153609
217
218         Reviewed by Darin Adler.
219
220         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
221         (BuildbotQueueView): Adding event listeners for all trac instances.
222         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Starting periodic updates
223         for all trac instances.
224
225 2016-01-31  Darin Adler  <darin@apple.com>
226
227         Replace CaseFoldingHash with ASCIICaseInsensitiveHash
228         https://bugs.webkit.org/show_bug.cgi?id=153639
229
230         Reviewed by Filip Pizlo.
231
232         * Scripts/do-webcore-rename: Use script to do this rename.
233
234 2016-01-30  Commit Queue  <commit-queue@webkit.org>
235
236         Unreviewed, rolling out r195911.
237         https://bugs.webkit.org/show_bug.cgi?id=153723
238
239         Caused frequent assertion failures on bots (Requested by ap on
240         #webkit).
241
242         Reverted changeset:
243
244         "Replace CaseFoldingHash with ASCIICaseInsensitiveHash"
245         https://bugs.webkit.org/show_bug.cgi?id=153639
246         http://trac.webkit.org/changeset/195911
247
248 2016-01-30  Darin Adler  <darin@apple.com>
249
250         Replace CaseFoldingHash with ASCIICaseInsensitiveHash
251         https://bugs.webkit.org/show_bug.cgi?id=153639
252
253         Reviewed by Filip Pizlo.
254
255         * Scripts/do-webcore-rename: Use script to do this rename.
256
257 2016-01-30  Ryosuke Niwa  <rniwa@webkit.org>
258
259         TouchList should be retargeted
260         https://bugs.webkit.org/show_bug.cgi?id=149592
261
262         Reviewed by Antti Koivisto.
263
264         Added touchDownAtPoint and liftUpAtPoint to UIScriptController so that we can test touch events with
265         multiple touch targets on iOS. fast/shadow-dom/touch-event-ios.html uses this new testing feature.
266
267         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
268         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
269         (WTR::UIScriptController::touchDownAtPoint): Added.
270         (WTR::UIScriptController::liftUpAtPoint): Added.
271         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
272         * WebKitTestRunner/ios/HIDEventGenerator.h:
273         * WebKitTestRunner/ios/HIDEventGenerator.mm:
274         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]): Added. Sends touch down and waits.
275         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]): Ditto for lift up.
276         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
277         (WTR::UIScriptController::touchDownAtPoint): Added.
278         (WTR::UIScriptController::liftUpAtPoint): Added.
279
280 2016-01-30  Yusuke Suzuki  <utatane.tea@gmail.com>
281
282         Enable SamplingProfiler on POSIX environment
283         https://bugs.webkit.org/show_bug.cgi?id=153584
284
285         Reviewed by Michael Saboff.
286
287         * Scripts/run-jsc-stress-tests:
288
289 2016-01-29  Nikos Andronikos  <nikos.andronikos-webkit@cisra.canon.com.au>
290
291         update-webkit-dependency fails to fetch updates through firewall on Windows
292         https://bugs.webkit.org/show_bug.cgi?id=153619
293
294         Reviewed by Myles C. Maxfield.
295
296         On Windows, when a firewall is present we need to read proxy settings
297         from environment variables.
298
299         This patch relies on the following environment variables being set:
300         HTTP_PROXY
301         HTTPS_PROXY
302
303         * Scripts/update-webkit-dependency:
304
305 2016-01-28  Dan Bernstein  <mitz@apple.com>
306
307         [Cocoa] Use the non-Development variants of XPC services for development
308         https://bugs.webkit.org/show_bug.cgi?id=152545
309
310         Reviewed by Darin Adler.
311
312         * Scripts/webkitdirs.pm:
313         (setUpGuardMallocIfNeeded): Ensure that libgmalloc is loaded into XPC services as well.
314
315         * Scripts/webkitpy/port/driver.py:
316         (Driver._setup_environ_for_driver): Ensure that the DYLD_LIBRARY_PATH and ASAN_OPTIONS are
317           set in the XPC services as well.
318
319         * Scripts/webkitpy/port/ios.py:
320         (IOSSimulatorPort.setup_environ_for_server): Ensure that malloc stack logging for leaks and
321           Guard Malloc are enabled in XPC services as well.
322
323         * Scripts/webkitpy/port/mac.py:
324         (MacPort.setup_environ_for_server): Ditto.
325
326 2016-01-28  Csaba Osztrogonác  <ossy@webkit.org>
327
328         Unreviewed buildfix after r195743.
329
330         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
331         (WTR::AccessibilityUIElement::isPressActionSupported):
332
333 2016-01-12  Jer Noble  <jer.noble@apple.com>
334
335         Custom protocol loading through AVFoundation does not support byte-range requests.
336         https://bugs.webkit.org/show_bug.cgi?id=152919
337         <rdar://problem/23664657>
338
339         Reviewed by Alex Christensen.
340
341         Add tests for new ParsedContntRange class.
342
343         * TestWebKitAPI/PlatformWin.cmake:
344         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
345         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
346         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
347         * TestWebKitAPI/Tests/WebCore/ParsedContentRange.cpp: Added.
348         (TestWebKitAPI::TEST):
349
350 2016-01-28  Konstantin Tokarev  <annulen@yandex.ru>
351
352         Use isAnyWindows() instead of isCygwin() || isWindows() in Perl scripts.
353         https://bugs.webkit.org/show_bug.cgi?id=153594
354
355         Reviewed by Alex Christensen.
356
357         * Scripts/webkitdirs.pm:
358         (determineNumberOfCPUs):
359         (jscPath):
360         (checkFrameworks):
361         (setupCygwinEnv):
362         (wrapperPrefixIfNeeded):
363         (cmakeGeneratedBuildfile):
364         (generateBuildSystemFromCMakeProject):
365         * Scripts/webkitperl/features.pm:
366         (libraryContainsSymbol):
367
368 2016-01-28  Chris Dumez  <cdumez@apple.com>
369
370         Unreviewed, rolling out r195742.
371
372         Broke EWS
373
374         Reverted changeset:
375
376         "[webkitdirs] Clarify logic behind is{PortName} functions."
377         https://bugs.webkit.org/show_bug.cgi?id=153554
378         http://trac.webkit.org/changeset/195742
379
380 2016-01-28  Darin Adler  <darin@apple.com>
381
382         Remove equalIgnoringCase since all callers really wanted equalIgnoringASCIICase
383         https://bugs.webkit.org/show_bug.cgi?id=153411
384
385         Reviewed by Ryosuke Niwa.
386
387         * Scripts/do-webcore-rename: Removed rename of equalIgnoringCase since we
388         have removed the function instead.
389
390         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
391         (TestWebKitAPI::TEST): Updated test since nullptr is now ambiguous since we
392         added overloads for const char*.
393
394         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
395         (WTR::AccessibilityUIElement::isPressActionSupported): Use equalLettersIgnoringASCIICase.
396         (WTR::AccessibilityUIElement::hasPopup): Ditto.
397         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
398         (WTR::testPathFromURL): Ditto.
399
400 2016-01-28  Konstantin Tokarev  <annulen@yandex.ru>
401
402         [webkitdirs] Clarify logic behind is{PortName} functions.
403         https://bugs.webkit.org/show_bug.cgi?id=153554
404
405         Reviewed by Darin Adler.
406
407         * Scripts/webkitdirs.pm:
408         (determinePortName): Added new function which decides which port are
409         we building based on command line switches and platform defaults.
410         (portName): Added getter for determined $portName.
411         (isEfl): Modified to use portName().
412         (isGtk): Ditto.
413         (isWinCairo): Ditto.
414         (isAppleMacWebKit): Ditto.
415         (isAppleWinWebKit): Ditto.
416         (isIOSWebKit): Ditto.
417         (cmakeBasedPortName): Code replaced with portName() call.
418         (determineIsEfl): Deleted.
419         (determineIsGtk): Deleted.
420         (determineIsWinCairo): Deleted.
421
422 2016-01-28  Konstantin Tokarev  <annulen@yandex.ru>
423
424         [webkitdirs] Don't pass cmakeBasedPortName around.
425         https://bugs.webkit.org/show_bug.cgi?id=153589
426
427         Reviewed by Darin Adler.
428
429         It should be local function of webkitdirs.pm instead.
430
431         * Scripts/build-jsc: Don't pass cmakeBasedPortName to
432         buildCMakeProjectOrExit().
433         * Scripts/build-webkit: Don't pass cmakeBasedPortName to
434         buildCMakeProjectOrExit() and generateBuildSystemFromCMakeProject().
435         * Scripts/run-efl-tests: Don't pass cmakeBasedPortName to
436         generateBuildSystemFromCMakeProject().
437         * Scripts/webkitdirs.pm: Don't export cmakeBasedPortName.
438         (generateBuildSystemFromCMakeProject): Removed $port argument as we
439         can get it from cmakeBasedPortName().
440         (buildCMakeProjectOrExit): Ditto.
441
442 2016-01-28  Gwang Yoon Hwang  <yoon@igalia.com>
443
444         [GStreamer] Clean up includes and headers related with GStreamerGL
445         https://bugs.webkit.org/show_bug.cgi?id=153590
446
447         Reviewed by Philippe Normand.
448
449         * Scripts/webkitpy/style/checker.py: Skips
450         include_order check for MediaPlayerPrivateGStreamerBase.cpp
451         Removes VideoSinkGStreamer1.cpp which doesn't exist anymore.
452
453 2016-01-27  Krzysztof Czech  <k.czech@samsung.com>
454
455         [EFL] Remove unused accessibility related code
456         https://bugs.webkit.org/show_bug.cgi?id=153543
457
458         Reviewed by Darin Adler.
459
460         Removed reference to EAIL library.
461         It not going to be support anymore. There have been changes in
462         EFL/Elementary in terms of the accessibility and we should
463         follow those.
464
465         * efl/jhbuild-optional.modules:
466
467 2016-01-27  Daniel Bates  <dabates@apple.com>
468
469         Remove WebKitSystemInterface for iOS SDK < 9
470         https://bugs.webkit.org/show_bug.cgi?id=153570
471
472         Reviewed by Andy Estes.
473
474         * Scripts/copy-webkitlibraries-to-product-directory:
475
476 2016-01-27  Jason Marcell  <jmarcell@apple.com>
477
478         Fix bugs caused by incorrect usage of "branch" vs. "branchName".
479         https://bugs.webkit.org/show_bug.cgi?id=153330
480
481         Reviewed by Daniel Bates.
482
483         In an earlier patch we started using the name "branch" to indicate a branch object, whereas
484         "branchName" implies that the variable or property in question is simply a string. We fixed some
485         inconsistencies regarding this issue in 152982 but further bugs and inconsistencies were recently
486         spotted in BuildbotQueueView.js.
487
488         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
489         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Change branchName to branch in method signature.
490         Changed branchName to branch.name in call to commitsOnBranch.
491         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Change branch.name to branch in call to
492         _popoverLinesForCommitRange.
493         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Changed context.branchName to context.branch.name.
494         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Changed branch.name to branch.
495         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests to verify
496         fix.
497
498 2016-01-27  Ryosuke Niwa  <rniwa@webkit.org>
499
500         Add API to access closed shadowRoot in InjectedBundle
501         https://bugs.webkit.org/show_bug.cgi?id=153533
502
503         Reviewed by Antti Koivisto.
504
505         Added WebKit2 API test for WKBundleScriptWorldMakeAllShadowRootsOpen.
506
507         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
508         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp: Added.
509         (TestWebKitAPI::runJavaScriptAlert):
510         (TestWebKitAPI::TEST):
511         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakrAllShadowRootOpen_Bundle.cpp: Added.
512         (TestWebKitAPI::InjectedBundleMakrAllShadowRootOpenTest::InjectedBundleMakrAllShadowRootOpenTest):
513         (TestWebKitAPI::InjectedBundleMakrAllShadowRootOpenTest::initialize):
514
515 2016-01-27  Jason Marcell  <jmarcell@apple.com>
516
517         Refactor logic for parsing Trac revisions into its own function and add logic for parsing git hashes.
518         https://bugs.webkit.org/show_bug.cgi?id=153332
519
520         Reviewed by Alexey Proskuryakov.
521
522         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
523         (Trac.prototype._xmlTimelineURL): Uses new function.
524         (Trac.prototype._parseRevisionFromURL): Added. Pulled out logic for parsing revisions from a URL. Also added
525         logic for parsing git hashes.
526         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests for
527         Trac._parseRevisionFromURL.
528
529 2016-01-27  Alexey Proskuryakov  <ap@apple.com>
530
531         Remove Mavericks from the flakiness dashboard
532         https://bugs.webkit.org/show_bug.cgi?id=153521
533
534         Reviewed by Dan Bernstein.
535
536         * TestResultServer/static-dashboards/builders.jsonp:
537         * TestResultServer/static-dashboards/flakiness_dashboard.js:
538
539 2016-01-27  Alexey Proskuryakov  <ap@apple.com>
540
541         Remove ENABLE_CURRENTSRC
542         https://bugs.webkit.org/show_bug.cgi?id=153545
543
544         Reviewed by Simon Fraser.
545
546         * Scripts/webkitperl/FeatureList.pm:
547
548 2016-01-26  Jason Marcell  <jmarcell@apple.com>
549
550         Sort incoming commits via date instead of revision number.
551         https://bugs.webkit.org/show_bug.cgi?id=153467
552
553         Reviewed by Alexey Proskuryakov.
554
555         Future Trac instances may use Git or other revision control systems where we cannnot rely on the revision number
556         for sorting revisions. Instead we use the commit date to sort revisions chronologically.
557
558         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
559         (Trac.prototype._loaded): Sort via date instead of revision number.
560         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
561         (MockTrac): Fix up the mock data to look more like real-world data.
562         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-trac-rss.xml: Added.
563         Fake RSS feed that adds three more commits.
564         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit tests to test
565         Trac._loaded().
566
567 2016-01-26  I-Ting Liu  <iting_liu@apple.com>
568
569         Add a test for WebKit::stringMatchesWildcardString.
570         https://bugs.webkit.org/show_bug.cgi?id=153090
571
572         Reviewed by Darin Adler.
573
574         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
575         Add the file to the project.
576
577         * TestWebKitAPI/Tests/WebKit2/mac/StringUtilities.mm: Added.
578         (TestWebKitAPI::TEST):
579         Test that a string matches another string that may contain wildcard characters.
580
581 2016-01-26  Konstantin Tokarev  <annulen@yandex.ru>
582
583         [webkitdirs] Removed check for bison, gperf, and flex.
584         https://bugs.webkit.org/show_bug.cgi?id=153496
585
586         Reviewed by Alex Christensen.
587
588         This prerequisites are checked in WebKitCommon.cmake and don't
589         have to be in $PATH.
590
591         * Scripts/webkitdirs.pm:
592         (checkRequiredSystemConfig):
593
594 2016-01-26  Konstantin Tokarev  <annulen@yandex.ru>
595
596         [webkitdirs] isCMakeBuild should be true by default
597         https://bugs.webkit.org/show_bug.cgi?id=153497
598
599         Reviewed by Michael Catanzaro.
600
601         * Scripts/webkitdirs.pm:
602         (isCMakeBuild):
603
604 2016-01-26  Daniel Bates  <dabates@apple.com>
605
606         Add WebKitSystemInterface for iOS 9.2
607         https://bugs.webkit.org/show_bug.cgi?id=153355
608
609         Rubber-stamped by David Kilzer.
610
611         * Scripts/copy-webkitlibraries-to-product-directory:
612
613 2016-01-26  Daniel Bates  <dabates@apple.com>
614
615         WebKitTestRunner: Credential cache is not cleared between tests
616         https://bugs.webkit.org/show_bug.cgi?id=153407
617         <rdar://problem/24280834>
618
619         Reviewed by Alexey Proskuryakov.
620
621         * WebKitTestRunner/TestController.cpp:
622         (WTR::TestController::resetStateToConsistentValues): Call WKContextClearCachedCredentials()
623         to clear cached credentials.
624
625 2016-01-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
626
627         kill-old-processes: allow to specify on the environment of the bot a list of process that should be killed.
628         https://bugs.webkit.org/show_bug.cgi?id=153483
629
630         Reviewed by Csaba Osztrogonác.
631
632         * BuildSlaveSupport/kill-old-processes:
633         (main): Allow to specify extra tasks to kill via the environment variable WEBKITBOT_TASKSTOKILL
634
635 2016-01-25  Simon Fraser  <simon.fraser@apple.com>
636
637         Give the layout test results file a <title> showing the date and time the tests were run
638         https://bugs.webkit.org/show_bug.cgi?id=153187
639
640         Reviewed by Darin Adler.
641         
642         Include a 'date' property in the JSON with the date and time the tests completed.
643
644         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
645         (summarize_results):
646
647 2016-01-25  Commit Queue  <commit-queue@webkit.org>
648
649         Unreviewed, rolling out r195543.
650         https://bugs.webkit.org/show_bug.cgi?id=153451
651
652         regressed performance of test bots by ~6% (Requested by dydz
653         on #webkit).
654
655         Reverted changeset:
656
657         "WebKitTestRunner: Credential cache is not cleared between
658         tests"
659         https://bugs.webkit.org/show_bug.cgi?id=153407
660         http://trac.webkit.org/changeset/195543
661
662 2016-01-25  Aakash Jain  <aakash_jain@apple.com>
663
664         Failing to upload to flakiness dashboard should not be a hard error
665         https://bugs.webkit.org/show_bug.cgi?id=153444
666         <rdar://problem/22146294>
667
668         Reviewed by Alexey Proskuryakov.
669
670         * Scripts/webkitpy/layout_tests/controllers/manager.py:
671         (Manager._upload_json_files): If JSON file is not generated, do not try to upload it.
672
673 2016-01-25  Daniel Bates  <dabates@apple.com>
674
675         WebKitTestRunner: Credential cache is not cleared between tests
676         https://bugs.webkit.org/show_bug.cgi?id=153407
677         <rdar://problem/24280834>
678
679         Reviewed by Brady Eidson.
680
681         * WebKitTestRunner/TestController.cpp:
682         (WTR::TestController::resetStateToConsistentValues): Reset testing network session
683         to clear cached credentials.
684
685 2016-01-24  Dan Bernstein  <mitz@apple.com>
686
687         Added project.xcworkspace and xcuserdata to this project’s svn:ignore.
688
689         * LayoutTestRelay/LayoutTestRelay.xcodeproj: Added property svn:ignore.
690
691 2016-01-22  Enrica Casucci  <enrica@apple.com>
692
693         Unreviewed build fix after http://trac.webkit.org/changeset/195474.
694
695         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
696         (WTR::TestController::platformCreateWebView):
697
698 2016-01-22  Tim Horton  <timothy_horton@apple.com>
699
700         Add a test for iOS arrow-key repeat
701         https://bugs.webkit.org/show_bug.cgi?id=152857
702         <rdar://problem/24017380>
703
704         Reviewed by Darin Adler.
705
706         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
707         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
708         (WTR::UIScriptController::keyUpUsingHardwareKeyboard):
709         (WTR::UIScriptController::keyDownUsingHardwareKeyboard):
710         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
711         * WebKitTestRunner/ios/HIDEventGenerator.h:
712         * WebKitTestRunner/ios/HIDEventGenerator.mm:
713         (-[HIDEventGenerator keyPress:completionBlock:]):
714         (-[HIDEventGenerator keyDown:completionBlock:]):
715         (-[HIDEventGenerator keyUp:completionBlock:]):
716         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
717         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
718         (WTR::UIScriptController::keyDownUsingHardwareKeyboard):
719         (WTR::UIScriptController::keyUpUsingHardwareKeyboard):
720         Make it possible to independently send keyUp/keyDown, instead of just paired.
721
722 2016-01-22  Tim Horton  <timothy_horton@apple.com>
723
724         Reproducible "Unhanded web process message 'WebUserContentController:AddUserScripts'" and friends
725         https://bugs.webkit.org/show_bug.cgi?id=153193
726         <rdar://problem/24222034>
727
728         Reviewed by Darin Adler.
729
730         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
731         (webViewForScriptMessageHandlerMultipleHandlerRemovalTest):
732         (TEST):
733         Add a test that exhibits the problems we're fixing here.
734         Before, it would both log and assert in debug, and crash in release.
735         Now it runs happily to completion.
736
737 2016-01-22  Enrica Casucci  <enrica@apple.com>
738
739         Add support for testing data detection.
740         https://bugs.webkit.org/show_bug.cgi?id=153360
741
742         Reviewed by Tim Horton.
743
744         Adding a new testing option (useDataDetection) to turn on
745         data detection when running the a test.
746
747         * WebKitTestRunner/TestController.cpp:
748         (WTR::updateTestOptionsFromTestHeader):
749         * WebKitTestRunner/TestOptions.h:
750         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
751         (WTR::TestController::platformCreateWebView):
752
753 2016-01-21  Simon Fraser  <simon.fraser@apple.com>
754
755         Fix the lldb WebCoreLayoutUnitProvider to not dynamically look up the LayoutUnit denominator
756         https://bugs.webkit.org/show_bug.cgi?id=153334
757
758         Reviewed by Zalan Bujtas.
759         
760         Evaluating expressions in the LayoutUnit summary provider seems to cause
761         re-entrancy problems in lldb python bindings, so just hardcode the LayoutUnit
762         denominator to 64.
763
764         * lldb/lldb_webkit.py:
765         (WebCoreLayoutUnitProvider.to_string):
766
767 2016-01-21  Filip Pizlo  <fpizlo@apple.com>
768
769         display-profiler-output should be able to display code blocks sorted by machine counts
770         https://bugs.webkit.org/show_bug.cgi?id=153298
771
772         Reviewed by Oliver Hunt.
773
774         * Scripts/display-profiler-output:
775
776 2016-01-21  Julien Isorce  <j.isorce@samsung.com>
777
778         Ensure to use compatible liborc version with wanted gstreamer version
779         https://bugs.webkit.org/show_bug.cgi?id=153276
780
781         For example gst-plugins-base-1.4.4 fails to build with liborc-0.4.24.
782         The user may have a very recent liborc installed on his system.
783
784         Reviewed by Philippe Normand.
785
786         * efl/jhbuild.modules: add liborc-0.4.17 and make it a gst dependency.
787         * gtk/jhbuild.modules: add liborc-0.4.17 and make it a gst depencendy.
788
789 2016-01-21  Nan Wang  <n_wang@apple.com>
790
791         AX: [IOS] Implement next/previous text marker functions using TextIterator
792         https://bugs.webkit.org/show_bug.cgi?id=153292
793         <rdar://problem/24268243>
794
795         Reviewed by Chris Fleizach.
796
797         Made text marker tests available on iOS.
798
799         * DumpRenderTree/AccessibilityTextMarker.h:
800         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
801         * DumpRenderTree/ios/AccessibilityTextMarkerIOS.mm: Added.
802         (AccessibilityTextMarker::AccessibilityTextMarker):
803         (AccessibilityTextMarker::~AccessibilityTextMarker):
804         (AccessibilityTextMarker::isEqual):
805         (AccessibilityTextMarker::platformTextMarker):
806         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
807         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
808         (AccessibilityTextMarkerRange::isEqual):
809         (AccessibilityTextMarkerRange::platformTextMarkerRange):
810         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
811         (AccessibilityUIElement::pathDescription):
812         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
813         (AccessibilityUIElement::textMarkerRangeForElement):
814         (AccessibilityUIElement::selectedTextMarkerRange):
815         (AccessibilityUIElement::resetSelectedTextMarkerRange):
816         (AccessibilityUIElement::textMarkerRangeLength):
817         (AccessibilityUIElement::textMarkerRangeForMarkers):
818         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
819         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
820         (AccessibilityUIElement::accessibilityElementForTextMarker):
821         (AccessibilityUIElement::endTextMarkerForBounds):
822         (AccessibilityUIElement::startTextMarkerForBounds):
823         (AccessibilityUIElement::textMarkerForPoint):
824         (AccessibilityUIElement::previousTextMarker):
825         (AccessibilityUIElement::nextTextMarker):
826         (AccessibilityUIElement::stringForTextMarkerRange):
827         (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
828         (AccessibilityUIElement::indexForTextMarker):
829         (AccessibilityUIElement::isTextMarkerValid):
830         (AccessibilityUIElement::textMarkerForIndex):
831         (AccessibilityUIElement::startTextMarker):
832         (AccessibilityUIElement::endTextMarker):
833         (AccessibilityUIElement::setSelectedVisibleTextRange):
834         (AccessibilityUIElement::getLinkedUIElements):
835         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
836         (AccessibilityTextMarkerRange::platformTextMarkerRange):
837         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
838         (AccessibilityUIElement::removeSelection):
839         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
840         (AccessibilityUIElement::setSelectedVisibleTextRange):
841         (AccessibilityUIElement::supportedActions):
842         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
843         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
844         (WTR::AccessibilityUIElement::textMarkerRangeLength):
845         (WTR::AccessibilityUIElement::previousTextMarker):
846         (WTR::AccessibilityUIElement::nextTextMarker):
847         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
848         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
849         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
850         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
851         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
852         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
853         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
854
855 2016-01-20  Filip Pizlo  <fpizlo@apple.com>
856
857         Unreviewed, revert accidental unreviewed commit.
858
859         * Scripts/display-profiler-output:
860
861 2016-01-20  Jason Marcell  <jmarcell@apple.com>
862
863         Refactor compareIterations to remove duplicate code.
864         https://bugs.webkit.org/show_bug.cgi?id=152913
865
866         Reviewed by Daniel Bates.
867
868         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
869         (BuildbotQueue.prototype.compareIterations): Refactored to remove duplicate code.
870         (BuildbotQueue.prototype.sortIterations): Add binding to call to compareIterations.
871         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests in order to ensure
872         the same behavior before and after refactor.
873
874 2016-01-20  Dana Burkart  <dburkart@apple.com>
875
876         Botwatcher's dashboard should show an 'X' when the build is broken
877         https://bugs.webkit.org/show_bug.cgi?id=152507
878
879         Reviewed by David Kilzer.
880
881         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
882         (BuildbotStaticAnalyzerQueueView.prototype.appendStaticAnalyzerQueueStatus):
883         (BuildbotStaticAnalyzerQueueView.prototype.update):
884
885 2016-01-19  Jason Marcell  <jmarcell@apple.com>
886
887         Remove assertion from revisionContentForIteration that is causing errors on the dashboard.
888         https://bugs.webkit.org/show_bug.cgi?id=153262
889
890         Reviewed by Alexey Proskuryakov.
891
892         Occasionaly some buildbot iterations will not have their "got_revisions" property populated. In
893         such cases this revisionContentForIteration method does not have any content to return, thus the
894         assertion fails.
895
896         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
897         (BuildbotQueueView.prototype.revisionContentForIteration): Removed assertion that was causing errors.
898
899 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
900
901         [GTK] Runtime critical warnings when loading a URL after a session restore
902         https://bugs.webkit.org/show_bug.cgi?id=153233
903
904         Reviewed by Michael Catanzaro.
905
906         Add new test case.
907
908         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
909         (viewLoadChanged):
910         (testWebKitWebViewNavigationAfterSessionRestore):
911         (beforeAll):
912
913 2016-01-19  Michael Catanzaro  <mcatanzaro@igalia.com>
914
915         [GTK] Remove jhbuild-optional.modules
916         https://bugs.webkit.org/show_bug.cgi?id=152964
917
918         Reviewed by Alex Christensen.
919
920         * gtk/jhbuild-optional.modules: Removed.
921         * gtk/jhbuild.modules:
922
923 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
924
925         [GTK] Add support to load/save session in MiniBrowser
926         https://bugs.webkit.org/show_bug.cgi?id=153201
927
928         Reviewed by Michael Catanzaro.
929
930         It makes it easier to test the new WebView session API.
931
932         * MiniBrowser/gtk/BrowserWindow.c:
933         (browserWindowFinalize): Free the session file path.
934         (browserWindowSaveSession): Save the current WebView session if
935         there's a session file path.
936         (browserWindowDeleteEvent): Call browserWindowSaveSession().
937         (browser_window_load_session): Try to load the session from the
938         given file path, otherwise fall back to homepage and keep the
939         session file to save the session on window close.
940         * MiniBrowser/gtk/BrowserWindow.h:
941         * MiniBrowser/gtk/main.c:
942         (createBrowserWindow): Pass the given session file path when
943         shouldLoadSession is TRUE.
944         (main): Only allow to restore/save session when MiniBrowser is
945         launched without URL arguments.
946
947 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
948
949         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/geolocation-permission-requests after r195075.
950
951         Geolocation is no longer allowed for unique origins after r195075.
952
953         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
954         (testWebViewGeolocationPermissionRequests):
955
956 2016-01-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
957
958         [GTK][EFL] Layout tests abort with PulseAudioSanitizer instance has no attribute '_pa_module_index' when the build is not ready.
959         https://bugs.webkit.org/show_bug.cgi?id=153216
960
961         Reviewed by Michael Catanzaro.
962
963         * Scripts/webkitpy/port/pulseaudio_sanitizer.py:
964         (PulseAudioSanitizer.__init__): initialize _pa_module_index in the constructor.
965
966 2016-01-18  Nan Wang  <n_wang@apple.com>
967
968         AX: [Mac] Implement next/previous text marker functions using TextIterator
969         https://bugs.webkit.org/show_bug.cgi?id=152728
970
971         Reviewed by Chris Fleizach.
972
973         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
974         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
975
976 2016-01-18  Csaba Osztrogonác  <ossy@webkit.org>
977
978         [cmake] Add testair to the build system
979         https://bugs.webkit.org/show_bug.cgi?id=153126
980
981         Reviewed by Michael Catanzaro.
982
983         * Scripts/build-jsc:
984
985 2016-01-16  Myles C. Maxfield  <mmaxfield@apple.com>
986
987         Remove TextRun::allowsRoundingHacks()
988         https://bugs.webkit.org/show_bug.cgi?id=153185
989
990         Reviewed by Simon Fraser.
991
992         * DumpRenderTree/mac/DumpRenderTree.mm:
993         (resetWebViewToConsistentStateBeforeTesting): Deleted.
994
995 2016-01-15  Konstantin Tokarev  <annulen@yandex.ru>
996
997         [webkitdirs] Avoid list form of open because it broke WinCairo
998         https://bugs.webkit.org/show_bug.cgi?id=153106
999
1000         Reviewed by Alex Christensen.
1001
1002         * Scripts/webkitdirs.pm:
1003         (determineArchitecture):
1004
1005 2016-01-15  Simon Fraser  <simon.fraser@apple.com>
1006
1007         Add kdebug_trace signposts for a few WebCore operations
1008         https://bugs.webkit.org/show_bug.cgi?id=153136
1009         rdar://problem/24208487
1010
1011         Reviewed by Sam Weinig.
1012         
1013         Plist used by kdebug_trace() viewing tools.
1014
1015         * Tracing/SystemTracePoints.plist: Added.
1016
1017 2016-01-14  Konstantin Tokarev  <annulen@yandex.ru>
1018
1019         [webkitdirs] Replaced grep invocation with perl code
1020         https://bugs.webkit.org/show_bug.cgi?id=153106
1021
1022         Reviewed by Alex Christensen.
1023
1024         * Scripts/webkitdirs.pm:
1025         (determineArchitecture):
1026
1027 2016-01-14  Brian Burg  <bburg@apple.com>
1028
1029         prepare-changelog does not read paths containing spaces properly
1030         https://bugs.webkit.org/show_bug.cgi?id=137982
1031
1032         Reviewed by Joseph Pecoraro.
1033
1034         Escape whitespace in filenames before passing the file path to other functions.
1035
1036         * Scripts/prepare-ChangeLog:
1037         (generateFunctionLists): Use the more explicit 3-argument form of 'open'.
1038
1039 2016-01-14  Jason Marcell  <jmarcell@apple.com>
1040
1041         Standardize the usage of "branch" vs. "branchName".
1042         https://bugs.webkit.org/show_bug.cgi?id=152982
1043
1044         Reviewed by Daniel Bates.
1045
1046         In an earlier patch we started using the name "branch" to indicate a branch object, whereas
1047         "branchName" implies that the variable or property in question is simply a string.
1048
1049         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1050         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Change branch to branchName.
1051         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Change branch to branch.name.
1052         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Change branch to branchName.
1053         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1054         (Trac.prototype.commitsOnBranch): Change branch to branchName.
1055         (Trac.prototype._convertCommitInfoElementToObject): Ditto.
1056         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
1057         (MockTrac): Ditto.
1058
1059 2016-01-14  Jason Marcell  <jmarcell@apple.com>
1060
1061         Add a unit test to test BuildbotQueueView._appendPendingRevisionCount.
1062         https://bugs.webkit.org/show_bug.cgi?id=152910
1063
1064         Reviewed by Daniel Bates.
1065
1066         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueue.js: Added.
1067         (MockBuildbotQueue): Added. Mock BuildbotQueue object that doesn't need to talk to an actual Buildbot server.
1068         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js: Added.
1069         (MockBuildbotQueueView): Added. Mock BuildbotQueueView object that returns a pre-specified _latestProductiveIteration without
1070         the need to talk to a real Buildbot server.
1071         (MockBuildbotQueueView.prototype._latestProductiveIteration): Added. Returns a pre-specified _latestProductiveIteration
1072         without the need to talk to a real Buildbot server.
1073         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js: Added.
1074         (MockTrac): Added. Mock Trac constructor that has pre-populated "recordedCommits" and does not need to talk to a real Trac
1075         server.
1076         (MockTrac.prototype.get oldestRecordedRevisionNumber): Added. Returns a pre-specified revision.
1077         (MockTrac.prototype.get latestRecordedRevisionNumber): Ditto.
1078         (MockTrac.prototype.loadMoreHistoricalData): Added. Overrides the real loadMoreHistoricalData so that we don't waste time
1079         trying to talk to Trac.
1080         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Added. Web page container for
1081         QUnit unit tests.
1082         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added. QUnit unit tests.
1083
1084 2016-01-14  Nikos Andronikos  <nikos.andronikos-webkit@cisra.canon.com.au>
1085
1086         [CMake][GTK] CMake Error: Could not create named generator Eclipse CDT4 - Ninja
1087         https://bugs.webkit.org/show_bug.cgi?id=132599
1088
1089         Reviewed by Michael Catanzaro.
1090
1091         Check if cmake Ninja generators are installed.
1092
1093         * Scripts/webkitdirs.pm:
1094         (canUseNinjaGenerator):
1095         (canUseEclipseNinjaGenerator):
1096         (generateBuildSystemFromCMakeProject):
1097         (canUseEclipse): Deleted.
1098
1099 2016-01-13  Myles C. Maxfield  <mmaxfield@apple.com>
1100
1101         [Cocoa] Testing with font family name "System Font" is unused
1102         https://bugs.webkit.org/show_bug.cgi?id=153073
1103         <rdar://problem/24091683>
1104
1105         Reviewed by Brent Fulgham.
1106
1107         * DumpRenderTree/mac/DumpRenderTree.mm:
1108         (allowedFontFamilySet): Deleted.
1109         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1110         (WTR::allowedFontFamilySet): Deleted.
1111         * WebKitTestRunner/mac/TestControllerMac.mm:
1112         (WTR::allowedFontFamilySet): Deleted.
1113
1114 2016-01-13  Daniel Bates  <dabates@apple.com>
1115
1116         [XSS Auditor] Add test when XSS payload is in the path portion of the URL
1117         https://bugs.webkit.org/show_bug.cgi?id=152871
1118
1119         Reviewed by Brent Fulgham.
1120
1121         Merged from Blink (patch by Tom Sepez <tsepez@chromium.org>):
1122         <https://src.chromium.org/viewvc/blink?revision=164746&view=revision>
1123
1124         * Scripts/webkitpy/layout_tests/servers/lighttpd.conf:
1125
1126 2016-01-08  Andy Estes  <aestes@apple.com>
1127
1128         [Content Filtering] Lazily load platform frameworks
1129         https://bugs.webkit.org/show_bug.cgi?id=152881
1130         rdar://problem/23270886
1131
1132         Reviewed by Brady Eidson.
1133
1134         Added an API test that verifies that the Parental Controls and Network Extension frameworks are loaded at the
1135         expected times. The test verifies that they are not loaded after creating a WKWebView, loading an HTML string,
1136         loading NSData, loading a file, or loading from a custom protocol. It verifies that Network Extension on Mac/iOS
1137         and Parental Controls on iOS are loaded after an HTTP request. It finally verifies that Parental Controls on Mac
1138         is loaded after an HTTPS request.
1139
1140         To accomplish this, TestProtocol was generalized to allow tests to specify the scheme they wish to use.
1141         Other tests that used TestProtocol were updated to account for this change. TestProtocol was removed from
1142         WebKit2.PreventImageLoadWithAutoResizingTest, which didn't actually need to use it. ContentFiltering tests were
1143         also re-enabled on iOS after mistakenly being disabled by r188892.
1144
1145         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1146         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1147         (TestWebKitAPI::TEST):
1148         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.h: Added.
1149         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.html: Added.
1150         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
1151         (TEST):
1152         (downloadTest):
1153         (-[LazilyLoadPlatformFrameworksController init]):
1154         (-[LazilyLoadPlatformFrameworksController webView]):
1155         (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
1156         (-[LazilyLoadPlatformFrameworksController webView:didFinishNavigation:]):
1157         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
1158         (-[ContentFilteringPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1159         (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]):
1160         (-[ContentFilteringPlugIn checkIfPlatformFrameworksAreLoaded:]):
1161         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1162         (TestWebKitAPI::TEST):
1163         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
1164         (TestWebKitAPI::TEST): Deleted.
1165         * TestWebKitAPI/cocoa/TestProtocol.h:
1166         * TestWebKitAPI/cocoa/TestProtocol.mm:
1167         (+[TestProtocol registerWithScheme:]):
1168         (+[TestProtocol unregister]):
1169
1170 2016-01-12  Dewei Zhu  <dewei_zhu@apple.com>
1171
1172         Fix the Sunpider converage in slow device.
1173         https://bugs.webkit.org/show_bug.cgi?id=152938
1174         <rdar://problem/22511411>
1175
1176         Reviewed by Ryosuke Niwa.
1177
1178         Updated the patch for RunBenchmark to resume sunspider coverage by removing unused subresources in sub-tests.
1179
1180         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch:
1181
1182 2016-01-12  Ryosuke Niwa  <rniwa@webkit.org>
1183
1184         Add a build flag for custom element
1185         https://bugs.webkit.org/show_bug.cgi?id=153005
1186
1187         Reviewed by Alex Christensen.
1188
1189         Added --custom-elements option to enable custom elements support.
1190
1191         * Scripts/webkitperl/FeatureList.pm:
1192
1193 2016-01-12  Benjamin Poulain  <bpoulain@apple.com>
1194
1195         [JSC] Add a help message when run-jsc-stress-tests fails
1196         https://bugs.webkit.org/show_bug.cgi?id=153014
1197
1198         Reviewed by Csaba Osztrogonác.
1199
1200         * Scripts/run-jsc-stress-tests:
1201
1202 2016-01-11  Saam barati  <sbarati@apple.com>
1203
1204         run-jsc-stress-tests should try to figure out a JSC path
1205         https://bugs.webkit.org/show_bug.cgi?id=152971
1206
1207         Reviewed by Yusuke Suzuki.
1208
1209         This patch now allows run-jsc-stress-tests to be run
1210         without a "--jsc <jsc-path>" argument. It tries
1211         to take its best guess at a <jsc-path> automagically.
1212         
1213         This makes it much easier to just run run-jsc-stress-tests
1214         with a directory or a yaml file as an argument.
1215         You now just do this:
1216         `run-jsc-stress-tests <path-to-yaml>`
1217         or
1218         `run-jsc-stress-tests <path-to-directory-of-js-files>`
1219         
1220         I wrote this patch because I'd often find myself hacking the 
1221         run-javascriptcore-tests file just to run a particular subset of tests.
1222         Because I always forget the arguments to run-jsc-stress-tests (which means
1223         I always forgot to provide a --jsc argument), I always found it easier to 
1224         just hack on that file instead of calling run-jsc-stress-tests directly.
1225         No longer is this true!
1226
1227         * Scripts/run-jsc-stress-tests:
1228
1229 2016-01-09  Andy Estes  <aestes@apple.com>
1230
1231         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
1232         https://bugs.webkit.org/show_bug.cgi?id=152950
1233         rdar://problem/24066652
1234
1235         Reviewed by Tim Horton.
1236
1237         Added an API test.
1238
1239         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1240         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
1241         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
1242         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
1243         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
1244         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
1245         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
1246         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
1247         (TEST):
1248
1249 2016-01-11  Commit Queue  <commit-queue@webkit.org>
1250
1251         Unreviewed, rolling out r194866.
1252         https://bugs.webkit.org/show_bug.cgi?id=152986
1253
1254         This change broke the mac build (Requested by ryanhaddad on
1255         #webkit).
1256
1257         Reverted changeset:
1258
1259         "[Cocoa] Add SPI to opt out a URL scheme from the memory
1260         cache"
1261         https://bugs.webkit.org/show_bug.cgi?id=152950
1262         http://trac.webkit.org/changeset/194866
1263
1264 2016-01-11  Andy Estes  <aestes@apple.com>
1265
1266         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
1267         https://bugs.webkit.org/show_bug.cgi?id=152950
1268         rdar://problem/24066652
1269
1270         Reviewed by Tim Horton.
1271
1272         Added an API test.
1273
1274         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1275         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
1276         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
1277         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
1278         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
1279         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
1280         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
1281         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
1282         (TEST):
1283
1284 2016-01-11  Konstantin Tokarev  <annulen@yandex.ru>
1285
1286         [webkitdirs] Use CMake to determine architecture on isCMakeBuild()
1287         https://bugs.webkit.org/show_bug.cgi?id=152959
1288
1289         Reviewed by Brent Fulgham.
1290
1291         * Scripts/webkitdirs.pm:
1292         (determineArchitecture):
1293
1294 2016-01-11  Michael Catanzaro  <mcatanzaro@igalia.com>
1295
1296         [GTK] W3C CSS2.1 anonymous table tests are failing
1297         https://bugs.webkit.org/show_bug.cgi?id=152455
1298
1299         Reviewed by Mario Sanchez Prada.
1300
1301         Add shared-mime-info to the jhbuild environment, since it affects the results of layout
1302         tests. Add upstream patches to fix detection of XHTML files.
1303
1304         * gtk/jhbuild.modules:
1305         * gtk/patches/shared-mime-info-xht-glob.patch: Added.
1306         * gtk/patches/shared-mime-info-xhtml-magic.patch: Added.
1307
1308 2016-01-10  Saam barati  <sbarati@apple.com>
1309
1310         Implement a sampling profiler
1311         https://bugs.webkit.org/show_bug.cgi?id=151713
1312
1313         Reviewed by Filip Pizlo.
1314
1315         * Scripts/run-jsc-stress-tests:
1316
1317 2016-01-10  Konstantin Tokarev  <annulen@yandex.ru>
1318
1319         [webkitdirs] Try arch and uname commands on non-windows OS
1320         https://bugs.webkit.org/show_bug.cgi?id=152958
1321
1322         Reviewed by Michael Catanzaro.
1323
1324         Right now, determineArchitecture()  uses `arch` and `uname -m`
1325         commands to determine architecture in case of condition (isGtk() ||
1326         isAppleMacWebKit() || isEfl()) is true. This should be !anyWindows()
1327         instead, because this code is applicable to any non-windows OS WebKit
1328         supports (even Haiku which once was supported is moderately
1329         POSIX-compliant and has uname command).
1330
1331         * Scripts/webkitdirs.pm:
1332         (determineArchitecture):
1333
1334 2016-01-08  Aakash Jain  <aakash_jain@apple.com>
1335
1336         run-webkit-tests mis-counts totals when there are other crashes
1337         https://bugs.webkit.org/show_bug.cgi?id=152894
1338         <rdar://problem/24098697>
1339
1340         Reviewed by Alexey Proskuryakov.
1341
1342         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1343         (TestRunResults.add): Do not update result counters for other crashes.
1344
1345 2016-01-08  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1346
1347         webkit-patch build-and-test should have an option to iterate over new tests
1348         https://bugs.webkit.org/show_bug.cgi?id=143093
1349
1350         Reviewed by Michael Catanzaro.
1351
1352         This patch introduces the --iterate-on-new-tests option to webkit-patch build-and-test.
1353         It allows running run-webkit-tests on modified or new paths in LayoutTests.
1354         Computation of new or modified tests is done by LayoutTestFinder.find_touched_tests
1355         It implements the translation of -expected.* paths to their related tests.
1356         It also implements the removal of skipped tests.
1357
1358         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
1359         (LayoutTestFinder.find_touched_tests):
1360         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py: Added.
1361         (MockPort):
1362         (MockPort.__init__):
1363         (MockPort.tests):
1364         (LayoutTestFinderTests):
1365         (LayoutTestFinderTests.touched_files):
1366         (LayoutTestFinderTests.test_touched_test):
1367         (LayoutTestFinderTests.test_expected_touched_test):
1368         (LayoutTestFinderTests.test_platform_expected_touched_test):
1369         (LayoutTestFinderTests.test_platform_duplicate_touched_test):
1370         (LayoutTestFinderTests.test_touched_but_skipped_test):
1371         * Scripts/webkitpy/port/base.py:
1372         (Port.potential_test_names_from_expected_file):
1373         * Scripts/webkitpy/tool/commands/download_unittest.py:
1374         (DownloadCommandsTest._default_options):
1375         * Scripts/webkitpy/tool/steps/options.py:
1376         (Options):
1377         * Scripts/webkitpy/tool/steps/runtests.py:
1378         (RunTests.options):
1379         (RunTests.run):
1380         (RunTests):
1381         (RunTests._new_or_modified_tests):
1382         (RunTests._run_webkit_tests):
1383         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1384         (RunTestsTest.test_webkit_run_unit_tests):
1385         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1386         (StepsTest._step_options):
1387
1388 2016-01-07  Joseph Pecoraro  <pecoraro@apple.com>
1389
1390         prepare-ChangeLog should include radar number
1391         https://bugs.webkit.org/show_bug.cgi?id=152839
1392         <rdar://problem/24093563>
1393
1394         Reviewed by Daniel Bates.
1395
1396         When running `prepare-ChangeLog -b ###`, check for a bugzilla comment that
1397         starts with a "<rdar://problem/####>" URL. If found, include that radar URL
1398         in the ChangeLog description after the bug URL.
1399
1400         * Scripts/prepare-ChangeLog:
1401         (main): Update signatures.
1402         (fetchBugXMLData): XML Data is now used for multiple reasons. Extract this to just get the data.
1403         (fetchBugDescriptionFromBugXMLData): Search data for <short_desc>.
1404         (fetchRadarURLFromBugXMLData): Search comment text for radar URL.
1405         (generateNewChangeLogs): Include radar URL if we found one.
1406
1407         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl: Added.
1408         Tests for the radar URL extraction.
1409
1410 2016-01-07  Alexey Proskuryakov  <ap@apple.com>
1411
1412         testRunner.runUIScript crashes while running multiple tests in a row that invokes the same UIScript
1413         https://bugs.webkit.org/show_bug.cgi?id=152390
1414         <rdar://problem/23948321>
1415
1416         Reviewed by Simon Fraser.
1417
1418         Fix two use-after-frees.
1419
1420         1. WKPageCallAfterNextPresentationUpdate's callback has a pointer to TestInvocation,
1421         but we may have already progressed to another test by the time the callback fires,
1422         having destroyed the TestInvocation.
1423         2. UIScriptController is a RefCounted object, but it has a raw pointer to
1424         UIScriptContext which has the same lifetime as a TestInvocation.
1425         As a result, completion blocks of UIScriptController actions would use a destroyed
1426         TestInvocation.
1427
1428         * WebKitTestRunner/TestInvocation.cpp:
1429         (WTR::TestInvocation::~TestInvocation):
1430         (WTR::TestInvocation::url):
1431         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1432         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
1433         (WTR::TestInvocation::runUISideScript):
1434         * WebKitTestRunner/TestInvocation.h:
1435         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
1436         (UIScriptContext::UIScriptContext):
1437         (UIScriptContext::~UIScriptContext):
1438         (UIScriptContext::runUIScript):
1439         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
1440         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1441         (WTR::UIScriptController::UIScriptController):
1442         (WTR::UIScriptController::contextDestroyed):
1443         (WTR::UIScriptController::makeWindowObject):
1444         (WTR::UIScriptController::setWillBeginZoomingCallback):
1445         (WTR::UIScriptController::willBeginZoomingCallback):
1446         (WTR::UIScriptController::setDidEndZoomingCallback):
1447         (WTR::UIScriptController::didEndZoomingCallback):
1448         (WTR::UIScriptController::setDidEndScrollingCallback):
1449         (WTR::UIScriptController::didEndScrollingCallback):
1450         (WTR::UIScriptController::setDidShowKeyboardCallback):
1451         (WTR::UIScriptController::didShowKeyboardCallback):
1452         (WTR::UIScriptController::setDidHideKeyboardCallback):
1453         (WTR::UIScriptController::didHideKeyboardCallback):
1454         (WTR::UIScriptController::uiScriptComplete):
1455         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1456         (WTR::UIScriptController::create):
1457         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1458         (WTR::UIScriptController::doAsyncTask):
1459         (WTR::UIScriptController::zoomToScale):
1460         (WTR::UIScriptController::singleTapAtPoint):
1461         (WTR::UIScriptController::doubleTapAtPoint):
1462         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
1463         (WTR::UIScriptController::contentVisibleRect):
1464         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
1465         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
1466         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
1467         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
1468         (WTR::UIScriptController::platformSetDidEndScrollingCallback):
1469         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1470         (WTR::UIScriptController::doAsyncTask):
1471
1472 2016-01-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1473
1474         [buildbot] clean-build script should remove untracked files and revert local changes too
1475         https://bugs.webkit.org/show_bug.cgi?id=142400
1476
1477         Reviewed by Ryosuke Niwa.
1478
1479         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
1480         A helper routine SCM.discard_untracked_files is added for that purpose.
1481
1482         * BuildSlaveSupport/clean-build:
1483         (main): Making call to Scripts/clean-webkit
1484         * Scripts/clean-webkit: Added.
1485         (main): Revert changes and delete untracked files.
1486         * Scripts/webkitpy/common/checkout/scm/scm.py:
1487         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
1488         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1489         (SCMTest._shared_test_discard_untracked_files):
1490         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
1491
1492 2016-01-06  Simon Fraser  <simon.fraser@apple.com>
1493
1494         Add a setting and preferences to enable display-list drawing. Does nothing yet.
1495         https://bugs.webkit.org/show_bug.cgi?id=152807
1496
1497         Reviewed by Zalan Bujtas.
1498         
1499         Add an item to the Settings menu to toggle display-list drawing.
1500
1501         * MiniBrowser/mac/SettingsController.h:
1502         * MiniBrowser/mac/SettingsController.m:
1503         (-[SettingsController _populateMenu]):
1504         (-[SettingsController validateMenuItem:]):
1505         (-[SettingsController toggleDisplayListDrawingEnabled:]):
1506         (-[SettingsController displayListDrawingEnabled]):
1507         * MiniBrowser/mac/WK2BrowserWindowController.m:
1508         (-[WK2BrowserWindowController didChangeSettings]):
1509
1510 2016-01-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1511
1512         Python SCM should be able to retrieve untracked files - Add GIT support
1513         https://bugs.webkit.org/show_bug.cgi?id=143135
1514
1515         Reviewed by Michael Catanzaro.
1516
1517         * Scripts/webkitpy/common/checkout/scm/git.py:
1518         (Git.untracked_files): Adding support for git.
1519         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1520         (GitTest.setUp):
1521         (GitTest.test_untracked_files): Adding test.
1522
1523 2016-01-05  Mark Lam  <mark.lam@apple.com>
1524
1525         Rename badly named JSC_timeout env var to JSCTEST_timeout.
1526         https://bugs.webkit.org/show_bug.cgi?id=152748
1527
1528         Reviewed by Geoffrey Garen.
1529
1530         Now that we validate JSC options, the badly named JSC_timeout env var causes the
1531         bots to have a bad time.
1532
1533         * Scripts/run-javascriptcore-tests:
1534         * Scripts/run-jsc-stress-tests:
1535
1536 2016-01-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1537
1538         [GTK] Allow to save and restore session
1539         https://bugs.webkit.org/show_bug.cgi?id=115600
1540
1541         Reviewed by Michael Catanzaro.
1542
1543         Add test case to check the new session API.
1544
1545         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
1546         (testWebKitWebViewSessionState):
1547         (testWebKitWebViewSessionStateWithFormData):
1548         (beforeAll):
1549
1550 2016-01-04  Csaba Osztrogonác  <ossy@webkit.org>
1551
1552         [EFL] Bump EFL version to 1.16.1
1553         https://bugs.webkit.org/show_bug.cgi?id=152688
1554
1555         Reviewed by Gyuyoung Kim.
1556
1557         * efl/jhbuild.modules:
1558
1559 2016-01-04  Aakash Jain  <aakash_jain@apple.com>
1560
1561         error running layout tests on iOS simulator on latest build
1562         https://bugs.webkit.org/show_bug.cgi?id=152719
1563         <rdar://problem/24009549>
1564
1565         Reviewed by Alexey Proskuryakov.
1566
1567         * Scripts/webkitpy/xcode/simulator.py:
1568         (Simulator.wait_until_device_is_booted): Ensure that simulator device is in booted state
1569           before running simctl spawn command.
1570
1571 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1572
1573         Unreviewed, move Frédéric Wang to committers list
1574
1575         He seems to be on the contributors list by accident. He has been landing his own commits for
1576         about two years now.
1577
1578         * Scripts/webkitpy/common/config/contributors.json:
1579
1580 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1581
1582         Unreviewed, move Sebastian Dröge to committers list harder
1583
1584         He accidentally added himself to the reviewers list because the file is confusing. Then I
1585         accidentially moved him to the contributors list because the file is confusing, even though
1586         I knew the contributors list existed in this file and was attempting to add him to the
1587         committers list. Really move him to the committers list now.
1588
1589         * Scripts/webkitpy/common/config/contributors.json:
1590
1591 2016-01-02  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1592
1593         Python SCM should be able to retrieve untracked files - Add SVN support
1594         https://bugs.webkit.org/show_bug.cgi?id=152546
1595
1596         Reviewed by Michael Catanzaro.
1597
1598         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1599         (test_untracked_files): Activating test for SVN.
1600         * Scripts/webkitpy/common/checkout/scm/svn.py:
1601         (SVN.untracked_files): Implementing untracked files retrieval for SVN.
1602
1603 2015-12-31  Andy Estes  <aestes@apple.com>
1604
1605         Replace WTF::move with WTFMove
1606         https://bugs.webkit.org/show_bug.cgi?id=152601
1607
1608         Reviewed by Brady Eidson.
1609
1610         * DumpRenderTree/TestRunner.h:
1611         (TestRunner::setAllowedHosts):
1612         * DumpRenderTree/win/DRTDataObject.cpp:
1613         (DRTDataObject::SetData):
1614         * TestWebKitAPI/Tests/WTF/Deque.cpp:
1615         (TestWebKitAPI::TEST):
1616         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1617         (TestWebKitAPI::TEST):
1618         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1619         (TestWebKitAPI::TEST):
1620         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
1621         (TestWebKitAPI::TEST):
1622         * TestWebKitAPI/Tests/WTF/Ref.cpp:
1623         (TestWebKitAPI::passWithRef):
1624         (TestWebKitAPI::TEST):
1625         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
1626         (TestWebKitAPI::TEST):
1627         * TestWebKitAPI/Tests/WTF/Vector.cpp:
1628         (TestWebKitAPI::TEST):
1629         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1630         (TestWebKitAPI::TEST):
1631         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
1632         (TestWebKitAPI::TEST):
1633         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
1634         (TestWebKitAPI::createTestValue):
1635         (TestWebKitAPI::TEST):
1636         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1637         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1638         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
1639         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
1640         (TestWebKitAPI::createNFAs):
1641         (TestWebKitAPI::TEST_F):
1642         * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp:
1643         (TestWebKitAPI::combine):
1644         * TestWebKitAPI/Tests/WebCore/DFAHelpers.h:
1645         (TestWebKitAPI::createNFAs):
1646         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm:
1647         (TEST):
1648         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
1649         (WebProcessTest::add):
1650
1651 2016-01-01  Michael Catanzaro  <mcatanzaro@igalia.com>
1652
1653         [SOUP] REGRESSION(r192761): Broke resource URIs for applications that use g_resource_load in a web extension
1654         https://bugs.webkit.org/show_bug.cgi?id=152634
1655
1656         Reviewed by Carlos Garcia Campos.
1657
1658         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1659         (testLoadFromGResource): Added test.
1660         (beforeAll):
1661         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1662         (registerGResource): Added.
1663         (webkit_web_extension_initialize_with_user_data): Load the test gresource.
1664         * TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html: Added.
1665         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Add an HTML file.
1666
1667 2015-12-31  David Kilzer  <ddkilzer@apple.com>
1668
1669         REGRESSION (r194470): Fix warnings uncovered by migrating to WTF_MOVE
1670         <https://bugs.webkit.org/show_bug.cgi?id=152601>
1671
1672         Ignore unknown pragmas on older clangs.  Fixes the following
1673         build failure:
1674
1675             Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp:184:34: error: unknown warning group '-Wself-move', ignored [-Werror,-Wunknown-pragmas]
1676             #pragma clang diagnostic ignored "-Wself-move"
1677                                              ^
1678             1 error generated.
1679
1680         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
1681         (TestWebKitAPI::TEST):
1682         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
1683         (TestWebKitAPI::TEST):
1684
1685 2015-12-31  Andy Estes  <aestes@apple.com>
1686
1687         Update the style checker to advise using WTFMove() instead of WTF::move()
1688         https://bugs.webkit.org/show_bug.cgi?id=152601
1689
1690         Reviewed by Daniel Bates.
1691
1692         * Scripts/webkitpy/style/checkers/cpp.py:
1693         (check_wtf_move):
1694         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1695         (WebKitStyleTest.test_wtf_move):
1696
1697 2015-12-31  Andy Estes  <aestes@apple.com>
1698
1699         Fix warnings uncovered by migrating to WTF_MOVE
1700         https://bugs.webkit.org/show_bug.cgi?id=152601
1701
1702         Reviewed by Daniel Bates.
1703
1704         Ignored -Wself-move warnings in these two API tests. It's useful to test that these classes properly handle
1705         self-move, even if doing so would trigger a warning.
1706
1707         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
1708         (TestWebKitAPI::TEST):
1709         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
1710         (TestWebKitAPI::TEST):
1711
1712 2015-12-31  Martin Robinson  <mrobinson@igalia.com>
1713
1714         [GTK] The install-dependencies script has a syntax error
1715         https://bugs.webkit.org/show_bug.cgi?id=152613
1716
1717         Reviewed by Michael Catanzaro.
1718
1719         * gtk/install-dependencies: Add the missing 'then.'
1720
1721 2015-12-30  Philippe Normand  <pnormand@igalia.com>
1722
1723         [Mac][GTK] Jhbuild support for OSX
1724         https://bugs.webkit.org/show_bug.cgi?id=150799
1725
1726         Reviewed by Michael Catanzaro.
1727
1728         * gtk/install-dependencies: Install dependencies on OSX with Homebrew.
1729         * gtk/jhbuild.modules: Moved platform-specific build settings in condition tags.
1730         * gtk/patches/foxbntconfig-fix-osx-cache.diff: Added.
1731         * gtk/jhbuildrc: GTK+ makeargs clean-up, the 3.0.12 hack is no longer needed.
1732
1733 2015-12-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1734
1735         Unreviewed, move Sebastian Dröge to committers list
1736
1737         He accidentally added himself to the reviewers list because the file is confusing.
1738
1739         * Scripts/webkitpy/common/config/contributors.json:
1740
1741 2015-12-24  Simon Fraser  <simon.fraser@apple.com>
1742
1743         Remove the unused #define _USE_MATH_DEFINES
1744         https://bugs.webkit.org/show_bug.cgi?id=152034
1745
1746         Reviewed by Tim Horton.
1747         
1748         Update this test to use piDouble from MathExtras.h, and
1749         std::numeric_limits<>.
1750
1751         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1752
1753 2015-12-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1754
1755         Python SCM should be able to retrieve untracked files - Generic changes
1756         https://bugs.webkit.org/show_bug.cgi?id=152536
1757
1758         Reviewed by Brent Fulgham.
1759
1760         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
1761         No support is yet added to GIT and SVN specific implementations.
1762
1763         * Scripts/webkitpy/common/checkout/scm/scm.py:
1764         (SCM.untracked_files):
1765         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1766         (SCMTest._shared_test_untracked_files):
1767
1768 2015-12-23  Dewei Zhu  <dewei_zhu@apple.com>
1769
1770         SVN checkout used by RunBenchmark should be non-interactive
1771         https://bugs.webkit.org/show_bug.cgi?id=152542
1772
1773         Reviewed by Ryosuke Niwa.
1774
1775         RunBenchmark should not require user interaction while running.
1776
1777         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
1778         (BenchmarkBuilder._checkout_with_subversion):
1779
1780 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
1781
1782         Web Inspector: add support for running protocol-test.js tests on Windows
1783         https://bugs.webkit.org/show_bug.cgi?id=148037
1784         <rdar://problem/22292237>
1785
1786         Reviewed by Simon Fraser.
1787
1788         * DumpRenderTree/win/TestRunnerWin.cpp:
1789         (TestRunner::inspectorTestStubURL): Provide implementation.
1790
1791 2015-12-23  Eric Carlson  <eric.carlson@apple.com>
1792
1793         [MediaStream] MediaDeviceInfo.label must be empty in some situations
1794         https://bugs.webkit.org/show_bug.cgi?id=152000
1795
1796         Reviewed by Brent Fulgham.
1797
1798         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1799         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1800         (WTR::InjectedBundle::setUserMediaPermission):
1801         (WTR::InjectedBundle::setUserMediaPermissionForOrigin): New.
1802         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1803
1804         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1805         (WTR::TestRunner::setUserMediaPermissionForOrigin): New.
1806         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1807
1808         * WebKitTestRunner/TestController.cpp:
1809         (WTR::TestController::setUserMediaPermissionForOrigin):
1810         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Add NULL check.
1811         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Don't add 
1812           persistent permission for origin, that can be done from script now.
1813         * WebKitTestRunner/TestController.h:
1814
1815         * WebKitTestRunner/TestInvocation.cpp:
1816         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Add support for
1817           SetUserMediaPermissionForOrigin.
1818
1819 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
1820
1821         [Win] Unreviewed build fix: Recognize Windows 10 variants.
1822
1823         * Scripts/webkitpy/common/system/platforminfo.py:
1824         (PlatformInfo._determine_win_version):
1825
1826 2015-12-23  Chris Aljoudi <chris@chrismatic.io> and Alex Christensen <achristensen@webkit.org>
1827
1828         Content blockers should be able to promote http to https
1829         https://bugs.webkit.org/show_bug.cgi?id=148966
1830
1831         Reviewed by Benjamin Poulain.
1832
1833         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1834         (WebCore::ContentExtensions::operator<<):
1835         (TestWebKitAPI::TEST_F):
1836
1837 2015-12-22  Hunseop Jeong  <hs85.jeong@samsung.com>
1838
1839         [EFL] MiniBrowser should be able to choose the offline-web-application-cache option
1840         https://bugs.webkit.org/show_bug.cgi?id=152516
1841
1842         Reviewed by Gyuyoung Kim.
1843
1844         * MiniBrowser/efl/main.c:
1845
1846 2015-12-22  Brent Fulgham  <bfulgham@apple.com>
1847
1848         Unreviewed: Add John Wilander as a contributor.
1849
1850         * Scripts/webkitpy/common/config/contributors.json:
1851
1852 2015-12-22  Chris Fleizach  <cfleizach@apple.com>
1853
1854         [WK2] Looping in testcase: fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
1855         https://bugs.webkit.org/show_bug.cgi?id=152482
1856
1857         Reviewed by Brent Fulgham.
1858
1859         vertical/horizontalScrollbar returns an accessibility element. That element can also be queried
1860         for the same property. On WK2, the element returned will not be valid, but is still present and
1861         that can lead to looping.
1862
1863         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1864         (AccessibilityUIElement::horizontalScrollbar):
1865         (AccessibilityUIElement::verticalScrollbar):
1866         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1867         (WTR::AccessibilityUIElement::horizontalScrollbar):
1868         (WTR::AccessibilityUIElement::verticalScrollbar):
1869
1870 2015-12-22  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1871
1872         Unreviewed.
1873
1874         * Scripts/webkitpy/common/config/contributors.json: Marking myself as reviewer.
1875
1876 2015-12-21  Hunseop Jeong  <hs85.jeong@samsung.com>
1877
1878         [EFL] test_ewk2_context failed after r192808
1879         https://bugs.webkit.org/show_bug.cgi?id=151846
1880
1881         Reviewed by Gyuyoung Kim.
1882
1883         Used the added ewk_context_web_process_count_limit_set api
1884         instead of the deprecated ewk_context_process_model_set.
1885
1886         * MiniBrowser/efl/main.c:
1887         (elm_main):
1888
1889 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
1890
1891         Unreviewed, move myself to reviewer list.
1892
1893         * Scripts/webkitpy/common/config/contributors.json:
1894
1895 2015-12-21  Aakash Jain  <aakash_jain@apple.com>
1896
1897         Unreviewed, add myself to the committers list.
1898
1899         * Scripts/webkitpy/common/config/contributors.json:
1900
1901 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
1902
1903         [GTK] jquery.min.js violates DFSG
1904         https://bugs.webkit.org/show_bug.cgi?id=152428
1905
1906         Reviewed by Joseph Pecoraro.
1907
1908         Stop distributing Source/WebInspectorUI/Tools. It is not needed in tarballs. This brings us
1909         into compliance with DFSG by removing a bundled, minified copy of jQuery from our tarball.
1910
1911         * gtk/manifest.txt.in:
1912
1913 2015-12-19  Dan Bernstein  <mitz@apple.com>
1914
1915         [Mac] WebKit contains dead source code for OS X Mavericks and earlier
1916         https://bugs.webkit.org/show_bug.cgi?id=152462
1917
1918         Reviewed by Alexey Proskuryakov.
1919
1920         - Removed definitions of MACOSX_DEPLOYMENT_TARGET and WEBKIT_SYSTEM_INTERFACE_LIBRARY for
1921           OS X 10.9:
1922
1923         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1924         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1925         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1926         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1927         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1928
1929         - Simplified expressions involving __MAC_OS_X_VERSION_MIN_REQUIRED and removed code that was
1930           never getting compiled:
1931
1932         * DumpRenderTree/mac/TextInputController.m:
1933         * MiniBrowser/mac/BrowserWindowController.m:
1934         * TestWebKitAPI/Tests/mac/AttributedString.mm:
1935         * WebKitTestRunner/mac/EventSenderProxy.mm:
1936
1937 2015-12-18  Michael Catanzaro  <mcatanzaro@igalia.com>
1938
1939         Unreviewed, add WebKitGTK+ Bugzilla email to committers list
1940
1941         This is to make it easy to CC it on Bugzilla.
1942
1943         * Scripts/webkitpy/common/config/contributors.json:
1944
1945 2015-12-18  Aakash Jain  <aakash_jain@apple.com>
1946
1947         Pasteboard get messed up after running kill-old-processes
1948         https://bugs.webkit.org/show_bug.cgi?id=152426
1949
1950         Reviewed by Alexey Proskuryakov.
1951
1952         * BuildSlaveSupport/kill-old-processes:
1953         (main): Do not kill pasteboard anymore.
1954
1955 2015-12-17  Aakash Jain  <aakash_jain@apple.com>
1956
1957         run-webkit-tests shouldn't start multiple iOS simulators while only running one test
1958         https://bugs.webkit.org/show_bug.cgi?id=152157
1959         <rdar://problem/23851817>
1960
1961         Reviewed by Alexey Proskuryakov.
1962
1963         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1964         (LayoutTestRunner.get_worker_count): Calculate required number of workers.
1965         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1966         (Manager._get_test_inputs): Common method to calculate test_inputs.
1967         (Manager._update_worker_count): Calculate and update required number of workers.
1968
1969 2015-12-16  Aakash Jain  <aakash_jain@apple.com>
1970
1971         run-webkit-tests fails to delete Simulator device during cleanup
1972         https://bugs.webkit.org/show_bug.cgi?id=152363
1973
1974         Reviewed by Alexey Proskuryakov.
1975
1976         * Scripts/webkitpy/xcode/simulator.py:
1977         (Simulator.delete_device): Ensure that device is Shutdown before deleting it.
1978
1979 2015-12-16  Tim Horton  <timothy_horton@apple.com>
1980
1981         [mac-wk2] fast/events force click tests crashing
1982         https://bugs.webkit.org/show_bug.cgi?id=152339
1983
1984         Reviewed by Beth Dakin.
1985
1986         * WebKitTestRunner/mac/EventSenderProxy.mm:
1987         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
1988         Set the NSEvent's _type member in addition to overriding -type,
1989         because there are assertions in touch event handling code that depend on it.
1990
1991 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1992
1993         Enforce temporarily bots to sync WebKit and WPT testharness.js
1994         https://bugs.webkit.org/show_bug.cgi?id=152334
1995
1996         Reviewed by Darin Adler.
1997
1998         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1999         (WebPlatformTestServer._copy_webkit_test_files): Temporarily overwrite wpt testharness.js with WebKit testharness.js.
2000
2001 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2002
2003         [Fetch API] Add fetch API compile time flag
2004         https://bugs.webkit.org/show_bug.cgi?id=152254
2005
2006         Reviewed by Darin Adler.
2007
2008         * Scripts/webkitperl/FeatureList.pm:
2009
2010 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2011
2012         Unreviewed.
2013
2014         Added files that have impact in building Streams API to the watchlist.
2015
2016         * Scripts/webkitpy/common/config/watchlist:
2017
2018 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2019
2020         Unreviewed.
2021
2022         Added imported tests to Streams API watchlist.
2023
2024         * Scripts/webkitpy/common/config/watchlist:
2025
2026 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2027
2028         Remove default copy of wpt testharness.js when launching wpt server
2029         https://bugs.webkit.org/show_bug.cgi?id=152298
2030
2031         Reviewed by Darin Adler.
2032
2033         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2034         (WebPlatformTestServer._copy_webkit_test_files): Deleted default copy of WebKit testharness.js to WPT.
2035
2036 2015-12-15  David Kilzer  <ddkilzer@apple.com>
2037
2038         REGRESSION (r192375): DumpRenderTree.app exits immediately with no error
2039         <http://webkit.org/b/152314>
2040
2041         Reviewed by Daniel Bates.
2042
2043         The change to DumpRenderTreeMain.mm in r192375 caused the iOS
2044         code path to exit immediately when calling main().
2045         Unfortunately, DumpRenderTreeMain.mm was used for both
2046         DumpRenderTree command-line binary and DumpRenderTree.app, which
2047         meant that the app would exit immediately with no error code
2048         when run!
2049
2050         The workaround is to introduce a separate source file called
2051         DumpRenderTreeAppMain.mm, similar to what WebKitTestRunner
2052         already does.
2053
2054         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add
2055         DumpRenderTreeAppMain.mm to the project.  Make it the only
2056         compiled source for the DumpRenderTree.app target.
2057         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm: Copied from Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm.
2058         (main): Call DumpRenderTreeMain() on iOS.  Assert on OS X in
2059         case someone tries mistakenly to use the app.
2060         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2061         Link to JavaScriptCore.framework on iOS for the assert.
2062         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
2063         Link to JavaScriptCore.framework on OS X for the assert.  Remove
2064         unneeded EXCLUDED_SOURCE_FILE_NAMES setting.
2065         * DumpRenderTree/mac/DumpRenderTreeMain.mm:
2066         (main): Add assert for iOS so that a crash occurs if someone
2067         tries to run the wrong command.
2068
2069 2015-12-14  Tim Horton  <timothy_horton@apple.com>
2070
2071         Frequent crash under -[WKPDFView web_setMinimumSize:]_block_invoke
2072         https://bugs.webkit.org/show_bug.cgi?id=152266
2073         <rdar://problem/22092676>
2074
2075         Reviewed by Simon Fraser.
2076
2077         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2078         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Added.
2079         Add a test that crashed before this change, and doesn't crash after.
2080
2081 2015-12-14  Chris Fleizach  <cfleizach@apple.com>
2082
2083         AX: iOS: Text field variations do not have the correct traits
2084         https://bugs.webkit.org/show_bug.cgi?id=152237
2085
2086         Reviewed by Mario Sanchez Prada.
2087
2088         Add iOS calls for determing if an object is a search field or a text area.
2089
2090         * DumpRenderTree/AccessibilityUIElement.cpp:
2091         (getIsSearchFieldCallback):
2092         (getIsTextAreaCallback):
2093         (stringForSelectionCallback):
2094         (AccessibilityUIElement::getJSClass):
2095         * DumpRenderTree/AccessibilityUIElement.h:
2096         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2097         (AccessibilityUIElement::identifier):
2098         (AccessibilityUIElement::isTextArea):
2099         (AccessibilityUIElement::isSearchField):
2100         (AccessibilityUIElement::traits):
2101         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2102         (WTR::AccessibilityUIElement::scrollPageRight):
2103         (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
2104         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
2105         (WTR::AccessibilityUIElement::isSearchField):
2106         (WTR::AccessibilityUIElement::isTextArea):
2107         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2108         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2109         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2110         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
2111         (WTR::AccessibilityUIElement::isTextArea):
2112         (WTR::AccessibilityUIElement::isSearchField):
2113         (WTR::AccessibilityUIElement::rowCount):
2114
2115 2015-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2116
2117         [GTK] [JHBuild] package libtool-bin is now required on Debian systems.
2118         https://bugs.webkit.org/show_bug.cgi?id=152252
2119
2120         Reviewed by Sergio Villar Senin.
2121
2122         * gtk/install-dependencies: Add libtool-bin to the list of packages required
2123         for building the JHBuild on Debian systems.
2124
2125 2015-12-11  Joseph Pecoraro  <pecoraro@apple.com>
2126
2127         check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
2128         https://bugs.webkit.org/show_bug.cgi?id=152156
2129
2130         Reviewed by Dan Bernstein.
2131
2132         Our frameworks should appropriately prefix all ObjC classes,
2133         not just external symbols.
2134
2135         * Scripts/check-for-inappropriate-objc-class-names:
2136         Remove the -g switch to check all ObjC class names.
2137
2138 2015-12-10  Eric Carlson  <eric.carlson@apple.com>
2139
2140         [MediaStream] Expose media capture devices persistent permissions to WebCore
2141         https://bugs.webkit.org/show_bug.cgi?id=152087
2142
2143         Add support for the new user media permission checker page UI client method.
2144
2145         Reviewed by Chris Dumez.
2146
2147         * WebKitTestRunner/TestController.cpp:
2148         (WTR::decidePolicyForUserMediaPermissionRequest):
2149         (WTR::checkUserMediaPermissionForOrigin):
2150         (WTR::TestController::createOtherPage): Add checkUserMediaPermissionForOrigin.
2151         (WTR::TestController::createWebViewWithOptions): Ditto.
2152         (WTR::TestController::resetStateToConsistentValues): Clear m_userMediaOriginPermissions.
2153         (WTR::originUserVisibleName): New, create a string for the origin.
2154         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Set the WKUserMediaPermissionCheckRef
2155           according to the state of the origin permission map.
2156         (WTR::TestController::handleUserMediaPermissionRequest): Remember both the origin and the
2157           request so we can update the origin permission map in decidePolicyForUserMediaPermissionRequestIfPossible.
2158         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update the
2159           origin permission map.
2160         * WebKitTestRunner/TestController.h:
2161
2162 2015-12-10  Alex Christensen  <achristensen@webkit.org>
2163
2164         REGRESSION (r192796) WKBundlePageResourceLoadClient should be able to setHTTPBody in willSendRequestForFrame
2165         https://bugs.webkit.org/show_bug.cgi?id=152022
2166         rdar://problem/23763584
2167
2168         Reviewed by Darin Adler.
2169
2170         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2171         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2172         (WTR::InjectedBundlePage::willSendRequestForFrame):
2173         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2174         (WTR::TestRunner::setWillSendRequestReturnsNull):
2175         (WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
2176         (WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
2177         (WTR::TestRunner::setWillSendRequestAddsHTTPBody):
2178         (WTR::TestRunner::willSendRequestHTTPBody):
2179         Added setWillSendRequestAddsHTTPBody that uses new SPI for testing.
2180
2181 2015-12-10  Aakash Jain  <aakash_jain@apple.com>
2182
2183         Remove additional simulator checks before running layout-tests
2184         https://bugs.webkit.org/show_bug.cgi?id=152146
2185
2186         Reviewed by Darin Adler.
2187
2188         * Scripts/webkitpy/port/ios.py:
2189         (IOSSimulatorPort.check_sys_deps): Removed additional simulators verifications.
2190         * Scripts/webkitpy/xcode/simulator.py:
2191         (Simulator._boot_and_shutdown_simulator_device): Deleted.
2192         (Simulator.check_simulator_device_and_erase_if_needed): Deleted.
2193
2194 2015-12-09  Aakash Jain  <aakash_jain@apple.com>
2195
2196         Run atleast one simulator even if max process limit is low
2197         https://bugs.webkit.org/show_bug.cgi?id=152081
2198         <rdar://problem/23819694>
2199
2200         Reviewed by Alexey Proskuryakov.
2201
2202 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
2203
2204         [GTK] Crash in WebProcess when loading large content with custom URI schemes
2205         https://bugs.webkit.org/show_bug.cgi?id=144262
2206
2207         Reviewed by Carlos Garcia Campos.
2208
2209         Added new unit test to check the additional scenarios we now
2210         handle for custom URI schemes.
2211
2212         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2213         (generateHTMLContent): New helper function to generate big enough content.
2214         (testWebContextURIScheme): New unit test.
2215
2216 2015-12-09  Ryuan Choi  <ryuan.choi@navercorp.com>
2217
2218         [EFL] Fix unhandled web process message when launching MiniBrowser
2219         https://bugs.webkit.org/show_bug.cgi?id=152048
2220
2221         Reviewed by Gyuyoung Kim.
2222
2223         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
2224         (TestWebKitAPI::TEST):
2225
2226 2015-12-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2227
2228         [GTK] Add API to handle beforeunload events
2229         https://bugs.webkit.org/show_bug.cgi?id=139090
2230
2231         Reviewed by Gustavo Noronha Silva.
2232
2233         * MiniBrowser/gtk/BrowserWindow.c:
2234         (browserWindowConstructed):
2235         (browserWindowDeleteEvent):
2236         (browser_window_class_init):
2237         Handle delete-event to prevent the window from being closed when
2238         the page has beforeunload handlers. Use
2239         webkit_web_view_try_close() when the window is requested to be
2240         closed.
2241         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
2242         (testWebViewJavaScriptDialogs):
2243         Add a test case for the WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM
2244         script dialog type.
2245
2246 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
2247
2248         Refactored initialization code in LoadTrackingTest.
2249
2250         Rubber-stamped by Carlos Garcia Campos.
2251
2252         Small refactoring to make sure that the state of a LoadTrackingTest
2253         gets properly reset before loading new web content.
2254
2255         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
2256         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
2257         (LoadTrackingTest::reset): New, refactored code from *load*() and go*()
2258         functions and reset the remaining local variables.
2259         (LoadTrackingTest::loadURI): Call reset();
2260         (LoadTrackingTest::loadHtml): Ditto.
2261         (LoadTrackingTest::loadPlainText): Ditto.
2262         (LoadTrackingTest::loadBytes): Ditto.
2263         (LoadTrackingTest::loadRequest): Ditto.
2264         (LoadTrackingTest::reload): Ditto.
2265         (LoadTrackingTest::goBack): Ditto.
2266         (LoadTrackingTest::goForward): Ditto.
2267
2268 2015-12-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2269
2270         [EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
2271         https://bugs.webkit.org/show_bug.cgi?id=151942
2272
2273         Reviewed by Darin Adler.
2274
2275         * MiniBrowser/efl/main.c:
2276         (window_create): Enable offline web application cache feature on MiniBrowser.
2277         (elm_main):
2278
2279 2015-12-08  Aakash Jain  <aakash_jain@apple.com>
2280
2281         https://bugs.webkit.org/show_bug.cgi?id=151243
2282         <rdar://problem/22955197>
2283
2284         Reviewed by Alexey Proskuryakov.
2285
2286         * LayoutTestRelay/LayoutTestRelay/main.m:
2287         (getTestingSimDevice): Use separate testing device for each worker.
2288         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2289         (Manager.run): Perform cleanup even if setup fails.
2290         * Scripts/webkitpy/port/ios.py:
2291         (IOSSimulatorPort.default_child_processes): Calculate number of simulators to use.
2292         (IOSSimulatorPort.child_processes): Gets the number of simulators from options variable.
2293         (IOSSimulatorPort.setup_test_run): Handle mulitple simulators.
2294         (IOSSimulatorPort._quit_ios_simulator): Same
2295         (IOSSimulatorPort.clean_up_test_run): Same
2296         (IOSSimulatorPort.check_sys_deps): Same
2297         (IOSSimulatorPort.testing_device): Same
2298         (IOSSimulatorPort.reset_preferences): Same
2299         (IOSSimulatorPort.get_simulator_path): Return simulator path.
2300         (IOSSimulatorPort._createSimulatorApp): Create the copy of simulator app.
2301         * Scripts/webkitpy/xcode/simulator.py:
2302         (Device.delete): Delete the simulator device.
2303         (Simulator.delete_device): Same
2304         (Simulator.wait_until_device_is_booted): Wait for device booting.
2305
2306 2015-12-08  Ryuan Choi  <ryuan.choi@navercorp.com>
2307
2308         [EFL] Add API to provide preferences before creating ewk_view
2309         https://bugs.webkit.org/show_bug.cgi?id=151587
2310
2311         Reviewed by Gyuyoung Kim.
2312
2313         * MiniBrowser/efl/main.c:
2314         (on_key_down):
2315         (quit):
2316         (window_create):
2317         Moved settings related code to configuration() not to update settings
2318         whenever ewk_view is created.
2319         (configuration):
2320         (elm_main):
2321
2322 2015-12-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2323
2324         Unreviewed. Fix GTK+ API tests after r193639.
2325
2326         The new jhbuild version needs some more variables ot be present in
2327         the builtin dict, even if they are set to None.
2328
2329         * jhbuild/jhbuildutils.py:
2330         (enter_jhbuild_environment_if_available):
2331
2332 2015-12-07  Gustavo Noronha Silva  <gns@gnome.org>
2333
2334         [GTK] Notify WebCore when notification is clicked
2335         https://bugs.webkit.org/show_bug.cgi?id=151951
2336
2337         Reviewed by Carlos Garcia Campos.
2338
2339         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2340         (testWebViewNotification): test the new API.
2341
2342 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
2343
2344         'jhbuild build' should fail immediately when building any module fails
2345         https://bugs.webkit.org/show_bug.cgi?id=145697
2346
2347         Reviewed by Carlos Garcia Campos.
2348
2349         * efl/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
2350         * gtk/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
2351         Everything is placed under lib instead of lib64 now.
2352         * jhbuild/jhbuild-wrapper: Update jhbuild to the latest upstream commit, and pass
2353         --exit-on-error when running 'jhbuild build'.
2354         * jhbuild/jhbuildrc_common.py:
2355         (init): Don't override PKG_CONFIG_PATH, CMAKE_PREFIX_PATH, or CMAKE_LIBRARY_PATH. Modern
2356         jhbuild should be able to handle these for us without breaking things....
2357
2358 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2359
2360         Add support to import w3c tests from a repository with a different root that the main repo dir
2361         https://bugs.webkit.org/show_bug.cgi?id=151751
2362
2363         Reviewed by Ryosuke Niwa and Youenn Fablet.
2364
2365         We should be able to import tests from repositories that are not pure test repositories and where tests are kept
2366         in a different directory than the repository root.
2367
2368         This patch introduces a new parameter tests_directory that we will use as root directory to search for
2369         tests. All paths will be flattened when copying tests to have a less complicated directory structure. This
2370         requires having the copy_path lists including tuples of origin and destination directories.
2371
2372         * Scripts/webkitpy/w3c/test_downloader.py:
2373         (TestDownloader._add_test_suite_paths): Adds the paths as a tuple of origin and destination directory.
2374         (TestDownloader.copy_tests): Uses the origin and destination tuple for the paths to copy when copying files.
2375         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2376         (TestImporterTest.test_tests_directory): Test.
2377
2378 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2379
2380         Mock TestRepositories in W3C importer tests
2381         https://bugs.webkit.org/show_bug.cgi?id=151938
2382
2383         Reviewed by Youenn Fablet.
2384
2385         The test importer tests should use a fake repository instead of using the real one. The reason why this happened
2386         is because the test repository method reading the file was using the filesystem directly instead of taking the
2387         host one. This patch changes that.
2388
2389         * Scripts/webkitpy/w3c/test_downloader.py:
2390         (TestDownloader.load_test_repositories): Take a filesystem and use it. If we get no filesystem, we use the
2391         default one.
2392         (TestDownloader.__init__): When loading the repositories, pass the host filesystem.
2393         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2394         (TestImporterTest.test_harnesslinks_conversion):
2395         (TestImporterTest.test_submodules_generation): Use a fake test repository file.
2396
2397 2015-12-07  David Kilzer  <ddkilzer@apple.com>
2398
2399         TestNetscapePlugIn: Address review comment on 193607
2400         <http://webkit.org/b/151881>
2401
2402         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2403         (testSetStatus): Initializing std::unique_ptr<char[]> with
2404         nullptr is redundant.
2405
2406 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2407
2408         [GTK] Add webkit_uri_request_get_http_method
2409         https://bugs.webkit.org/show_bug.cgi?id=151601
2410
2411         Reviewed by Martin Robinson.
2412
2413         Add test case to check HTTP method of WebKitURIRequest.
2414
2415         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
2416         (testURIRequestHTTPMethod):
2417         (serverCallback):
2418         (beforeAll):
2419         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2420         (sendRequestCallback):
2421
2422 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2423
2424         [GTK] Add WebKitWebPage::console-message-sent signal to Web Extensions API
2425         https://bugs.webkit.org/show_bug.cgi?id=79918
2426
2427         Reviewed by Gustavo Noronha Silva.
2428
2429         Add unit tests to check the different console messages.
2430
2431         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2432         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp: Added.
2433         (ConsoleMessageTest::ConsoleMessage::operator==):
2434         (ConsoleMessageTest::consoleMessageReceivedCallback):
2435         (ConsoleMessageTest::ConsoleMessageTest):
2436         (ConsoleMessageTest::~ConsoleMessageTest):
2437         (ConsoleMessageTest::waitUntilConsoleMessageReceived):
2438         (testWebKitConsoleMessageConsoleAPI):
2439         (testWebKitConsoleMessageJavaScriptException):
2440         (testWebKitConsoleMessageNetworkError):
2441         (testWebKitConsoleMessageSecurityError):
2442         (beforeAll):
2443         (afterAll):
2444         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2445         (consoleMessageSentCallback):
2446         (pageCreatedCallback):
2447
2448 2015-12-07  Ryuan Choi  <ryuan.choi@navercorp.com>
2449
2450         [EFL] MiniBrowser doesn't exit when called ewk_view_try_close()
2451         https://bugs.webkit.org/show_bug.cgi?id=151934
2452
2453         Reviewed by Csaba Osztrogonác.
2454
2455         * MiniBrowser/efl/main.c:
2456         (on_window_deletion): Revert the changes of r192767.
2457
2458 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
2459
2460         [GTK] update-webkitgtk-libs cannot build mesa
2461         https://bugs.webkit.org/show_bug.cgi?id=151535
2462
2463         Reviewed by Martin Robinson.
2464
2465         Upgrade to newer mesa in order to build successfully against LLVM 3.7. Add missing
2466         dependency of mesa on LLVM, to ensure LLVM is built first. Build LLVM unconditionally, even
2467         on architectures where FTL is not supported, to ensure mesa is always buildable, since LLVM
2468         does not have a stable API and we cannot expect mesa to be buildable unless we control the
2469         LLVM version. Build mesa with --disable-egl since --enable-egl conflicts with
2470         --enable-xlib-glx. This fixes update-webkitgtk-libs on distros with LLVM 3.7.
2471
2472         * gtk/jhbuild.modules:
2473
2474 2015-12-07  Philippe Normand  <pnormand@igalia.com>
2475
2476         [GTK][Mac] libWebExtensionTest link error
2477         https://bugs.webkit.org/show_bug.cgi?id=150802
2478
2479         Reviewed by Carlos Garcia Campos.
2480
2481         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: add dependencies to the webextension library.
2482
2483 2015-12-06  David Kilzer  <ddkilzer@apple.com>
2484
2485         TestNetscapePlugIn: Fix leaks found by static analyzer
2486         <http://webkit.org/b/151881>
2487
2488         Reviewed by Darin Adler.
2489
2490         Fixes the following leaks found by the static analyzer:
2491             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'path'
2492                     return false;
2493                            ^~~~~
2494             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'target'
2495                     return false;
2496                            ^~~~~
2497             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'url'
2498                     return false;
2499                            ^~~~~
2500
2501         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2502         (toCString): Switch to returning std::unique_ptr<char[]>.  Add
2503         early return if allocation fails.
2504         (testPostURLFile): Switch to using std::unique_ptr<char[]>.
2505         Make sure to call fclose() on filehandle, even for an early
2506         return.
2507         (testSetStatus): Switch to using std::unique_ptr<char[]>.
2508
2509 2015-12-05  David Kilzer  <ddkilzer@apple.com>
2510
2511         prepare-ChangeLog: Fix some warning messages when using svn
2512         <http://webkit.org/b/151914>
2513
2514         Reviewed by Daniel Bates.
2515
2516         * Scripts/prepare-ChangeLog:
2517         (generateFunctionLists): Simplify logic so that we never call
2518         normalizePath() with an undefined value.
2519         (attributeCommand): Quote $subPath for the shell so that we
2520         don't try to run "svn propget" on invalid paths.
2521
2522 2015-12-04  David Kilzer  <ddkilzer@apple.com>
2523
2524         TestNetscapePlugIn: Fix remaining static analyzer warnings
2525         <http://webkit.org/b/151888>
2526
2527         Reviewed by Alexey Proskuryakov.
2528
2529         Fixes the following static analyzer warnings:
2530             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:101:9: warning: Called function pointer is null (null dereference)
2531                     CRASH();
2532                     ^~~~~~~
2533             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:46:5: note: expanded from macro 'CRASH'
2534                 ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ \
2535                 ^~~~~~~~~~~~~~~~
2536             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:375:12: warning: Access to field 'pluginTest' results in a dereference of a null pointer (loaded from variable 'obj')
2537                 return obj->pluginTest->NPP_SetWindow(window);
2538                        ^~~~~~~~~~~~~~~
2539             2 warnings generated.
2540
2541         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2542         (CRASH): Use __builtin_trap() for gcc/clang.
2543         (NPP_SetWindow): Add early return if obj is nullptr.
2544
2545 2015-12-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2546
2547         [GTK] Test /webkit2/WebKitWebResource/get-data is flaky
2548         https://bugs.webkit.org/show_bug.cgi?id=151797
2549
2550         Reviewed by Martin Robinson.
2551
2552         Since we switched to use the network process to run the unit tests
2553         the test /webkit2/WebKitWebResource/get-data sometimes fails and
2554         sometimes passes. We are now also getting the notification for the
2555         css image. Since we wait for 3 resources, sometimes the css image
2556         is loaded before and then checkResourceData is called for it, but
2557         not handled. When the css image is the last one loaded the test
2558         passes. So, we just need to wait for the 4 resources.
2559
2560         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2561         (testWebResourceGetData):
2562
2563 2015-12-03  David Kilzer  <ddkilzer@apple.com>
2564
2565         DumpRenderTree: Use-after-free in createBitmapContext() in PixelDumpSupportMac.mm
2566         <http://webkit.org/b/151845>
2567
2568         Reviewed by Simon Fraser.
2569
2570         Fixes the following static analyzer warning:
2571             DumpRenderTree/mac/PixelDumpSupportMac.mm:67:9: warning: Use of memory after it is freed
2572                     WTFLogAlways("DumpRenderTree: CGBitmapContextCreate(%p, %llu, %llu, 8, %llu, %p, 0x%x) failed\n", buffer, pixelsHigh, pixelsWide, rowBytes, colorSpace.get(), kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host);
2573                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2574
2575         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2576         (createBitmapContext): Free 'buffer' after using it in logging
2577         to fix the use-after-free.  Assign a value of nullptr to buffer
2578         so we don't return with it set to a freed address.
2579
2580 2015-12-03  Jer Noble  <jer.noble@apple.com>
2581
2582         Expose WebCore's InvisibleAutoplayNotPermitted setting to WebKit & WebKit2
2583         https://bugs.webkit.org/show_bug.cgi?id=151830
2584
2585         Reviewed by Anders Carlsson.
2586
2587         Set invisibleAutoplayNotPermitted to NO by default both in WKTR and DRT.
2588
2589         * DumpRenderTree/mac/DumpRenderTree.mm:
2590         (resetWebPreferencesToConsistentValues):
2591         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2592         (WTR::initializeWebViewConfiguration):
2593
2594 2015-12-03  Anders Carlsson  <andersca@apple.com>
2595
2596         Remove Objective-C GC support
2597         https://bugs.webkit.org/show_bug.cgi?id=151819
2598         rdar://problem/23746991
2599
2600         Reviewed by Dan Bernstein.
2601
2602         * asan/asan.xcconfig:
2603
2604 2015-12-02  Yusuke Suzuki  <utatane.tea@gmail.com>
2605
2606         Allow nil for unspecified benchmark pathes
2607         https://bugs.webkit.org/show_bug.cgi?id=151784
2608
2609         Reviewed by Filip Pizlo.
2610
2611         `Pathname.new(nil)` will raise an error.
2612         Only generate Pathname if the benchmark path is specified.
2613
2614         * Scripts/run-jsc-benchmarks:
2615
2616 2015-12-02  Brent Fulgham  <bfulgham@apple.com>
2617
2618         [Win] Run non-http tests without Cygwin
2619         https://bugs.webkit.org/show_bug.cgi?id=151721
2620
2621         Reviewed by Andy Estes.
2622
2623         Support native 32-bit and 64-bit Python (and Perl) builds
2624         for running tests:
2625
2626         1. Use "startswith('win')", rather than "== 'win32'" to support
2627         various Windows build types.
2628         2. Supply full path for some native Windows utilities, since the
2629         path environment does not always have the specified, and they are
2630         guaranteed to exist in those specific locations.
2631         3. Make sure native Windows Python test runs pass proper environment
2632         variables to run programs.
2633         4. Append 'exe' suffix when running Windows executables.
2634         5. Use the _winreg Python module on Windows, since the Cygwin 'regtool'
2635         command doesn't exist.
2636         
2637         * Scripts/update-webkit: Use Perl $^X command to refer to the path of
2638         the current Perl executable, rather than requiring a new path search.
2639         * Scripts/webkitpy/common/find_files_unittest.py:
2640         (TestWinNormalize.test_win): Use startswith('win').
2641         * Scripts/webkitpy/common/prettypatch_unittest.py:
2642         (test_pretty_diff_encodings): Ditto.
2643         * Scripts/webkitpy/common/system/executive.py:
2644         (Executive._should_close_fds): Ditto.
2645         (Executive.shell_command_for_script): Use startswith('win').
2646         (Executive.kill_process): Use full path to killall executable.
2647         (Executive.check_running_pid): Use startswith('win').
2648         (Executive.running_pids): Ditto.
2649         (Executive.kill_all): Ditto. Also use path to 'killall' executable when
2650         running under native Windows Python.
2651         (Executive._child_process_encoding): Use startswith('win').
2652         (Executive._should_encode_child_process_arguments): Ditto.
2653         (Executive.popen): Recognize proper script engine on Windows, since it
2654         does not support the shebang syntax.
2655         (Executive.run_in_parallel): Use startswith('win').
2656         * Scripts/webkitpy/common/system/executive_unittest.py:
2657         (never_ending_command): Ditto.
2658         (ExecutiveTest.test_run_command_with_unicode): Ditto.
2659         (ExecutiveTest.serial_test_kill_process): Ditto.
2660         (ExecutiveTest.serial_test_kill_all): Ditto.
2661         (ExecutiveTest.serial_test_check_running_pid): Ditto.
2662         (ExecutiveTest.serial_test_run_in_parallel): Ditto.
2663         (main): Ditto.
2664         * Scripts/webkitpy/common/system/file_lock.py:
2665         (FileLock._create_lock): Ditto.
2666         (FileLock._remove_lock): Ditto.
2667         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2668         (RealFileSystemTest.test_chdir): Ditto.
2669         (RealFileSystemTest.test_chdir__notexists): Ditto.
2670         (RealFileSystemTest.test_maybe_make_directory__failure): Ditto.
2671         * Scripts/webkitpy/common/system/path_unittest.py:
2672         (AbspathTest.test_abspath_to_uri_win): Ditto.
2673         * Scripts/webkitpy/common/system/platforminfo.py:
2674         (PlatformInfo._determine_os_name): Ditto.
2675         * Scripts/webkitpy/common/system/user.py: Ditto.
2676         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2677         (ManagerTest.integration_test_needs_servers): Ditto.
2678         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2679         (LayoutTestApacheHttpd.__init__): Handle upper and lower-case
2680         driver letters.
2681         (LayoutTestApacheHttpd._get_apache_config_file_path): Ditto.
2682         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
2683         (TestLayoutTestApacheHttpd.test_start_cmd): Ditto.
2684         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2685         (HttpServerBase._check_that_all_ports_are_available): Ditto.
2686         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2687         (TestHttpServer.test_start_cmd): Ditto.
2688         * Scripts/webkitpy/port/base.py:
2689         (Port.to.setup_environ_for_server): Include 'COMSPEC', 'SYSTEMDRIVE',
2690         and 'SYSTEMROOT' in environment passed to test runners.
2691         (Port._apache_config_file_name_for_platform): Use startswith('win').
2692         (Port._build_path): Ditto.
2693         (Port._path_to_driver): Include 'exe' suffix when running under native
2694         Windows.
2695         * Scripts/webkitpy/port/driver.py:
2696         (Driver._setup_environ_for_driver): Explicitly make some environment
2697         variables strings.
2698         * Scripts/webkitpy/port/server_process.py:
2699         (ServerProcess.__init__): Use startswith('win').
2700         * Scripts/webkitpy/port/win.py:
2701         (WinPort): Use the win32 registry utilities on Windows, and appropriate
2702         registry key formats.
2703         (WinPort._ntsd_location): Revise tool search paths for Windows 10.
2704         (WinPort.read_registry_value): Revise to use _winreg library on Windows,
2705         and regtool on Cygwin.
2706         (WinPort.write_registry_value): Ditto.
2707         (WinPort.setup_crash_log_saving): Ditto.
2708         (WinPort.restore_crash_log_saving): Ditto.
2709         (WinPort.prevent_error_dialogs): Ditto.
2710         (WinPort.allow_error_dialogs): Ditto.
2711         (WinPort.find_system_pid): Revise to use Windows management
2712         infrastructure on native Windows, continue using 'ps' on Cygwin.
2713         (WinPort.read_registry_string): Deleted.
2714         (WinPort.write_registry_string): Deleted.
2715         * Scripts/webkitpy/test/main.py:
2716         (main): Use startswith('win').
2717         (Tester._parse_args): Ditto.
2718
2719 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
2720
2721         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
2722         https://bugs.webkit.org/show_bug.cgi?id=150792
2723
2724         Reviewed by Saam Barati.
2725
2726         * Scripts/webkitperl/FeatureList.pm:
2727
2728 2015-12-01  Commit Queue  <commit-queue@webkit.org>
2729
2730         Unreviewed, rolling out r192914.
2731         https://bugs.webkit.org/show_bug.cgi?id=151734
2732
2733         JSC tests for this change are failing on 32 and 64-bit bots
2734         (Requested by ryanhaddad on #webkit).
2735
2736         Reverted changeset:
2737
2738         "[ES6] Implement LLInt/Baseline Support for ES6 Generators and
2739         enable this feature"
2740         https://bugs.webkit.org/show_bug.cgi?id=150792
2741         http://trac.webkit.org/changeset/192914
2742
2743 2015-12-01  David Kilzer  <ddkilzer@apple.com>
2744
2745         EventSenderProxy::swipeGestureWithWheelAndMomentumPhases() leaks an EventSenderSyntheticEvent
2746         <http://webkit.org/b/151726>
2747
2748         Reviewed by Simon Fraser.
2749
2750         * WebKitTestRunner/mac/EventSenderProxy.mm:
2751         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
2752         Deploy RetainPtr<EventSenderSyntheticEvent> to fix leak.
2753
2754 2015-12-01  Myles C. Maxfield  <mmaxfield@apple.com>
2755
2756         Give String and AtomicString an existingHash() function
2757         https://bugs.webkit.org/show_bug.cgi?id=151717
2758
2759         Reviewed by Andreas Kling.
2760
2761         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
2762         (TestWebKitAPI::TEST):
2763         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2764         (TestWebKitAPI::TEST):
2765
2766 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
2767
2768         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
2769         https://bugs.webkit.org/show_bug.cgi?id=150792
2770
2771         Reviewed by Saam Barati.
2772
2773         * Scripts/webkitperl/FeatureList.pm:
2774
2775 2015-12-01  Sam Weinig  <sam@webkit.org>
2776
2777         Need completionHandler-based WebKit C SPI for alert, confirm, and prompt
2778         <rdar://problem/23320863>
2779         https://bugs.webkit.org/show_bug.cgi?id=151708
2780
2781         Reviewed by Anders Carlsson.
2782
2783         * WebKitTestRunner/TestController.cpp:
2784         (WTR::TestController::createOtherPage):
2785         (WTR::TestController::createWebViewWithOptions):
2786         Update for new WKPageUIClient.
2787
2788 2015-12-01  Anders Carlsson  <andersca@apple.com>
2789
2790         Remove WebKit2.framework
2791         https://bugs.webkit.org/show_bug.cgi?id=151715
2792
2793         Reviewed by Dan Bernstein.
2794
2795         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
2796         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
2797         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
2798         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2799         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
2800         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
2801         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
2802
2803 2015-12-01  Joseph Pecoraro  <pecoraro@apple.com>
2804
2805         Unreviewed common typo fix "occurance" => "occurrence".
2806
2807         * Scripts/webkitpy/tool/commands/queries.py:
2808         (FindFlakyTests._print_statistics):
2809
2810 2015-11-30  Alex Christensen  <achristensen@webkit.org>
2811
2812         Make ProcessModel always MultipleSecondaryProcesses
2813         https://bugs.webkit.org/show_bug.cgi?id=151662
2814
2815         Reviewed by Antti Koivisto.
2816
2817         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2818         (TestWebKitAPI::TEST):
2819         * WebKitTestRunner/TestController.cpp:
2820         (WTR::TestController::generatePageConfiguration):
2821
2822 2015-11-30  Alex Christensen  <achristensen@webkit.org>
2823
2824         Make usesNetworkProcess always true
2825         https://bugs.webkit.org/show_bug.cgi?id=151580
2826
2827         Reviewed by Darin Adler.
2828
2829         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2830         (TestWebKitAPI::TEST):
2831         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
2832         (TestWebKitAPI::TEST):
2833         * WebKitTestRunner/TestController.cpp:
2834         (WTR::TestController::generatePageConfiguration):
2835
2836 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2837
2838         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/editable/editable in Debug.
2839
2840         Add a way to skip unit tests only for Debug or Release builds and
2841         skipt the test /webkit2/WebKitWebView/editable/editable only for Debug.
2842
2843         * Scripts/run-gtk-tests:
2844         (SkippedTest):
2845         (SkippedTest.__init__):
2846         (SkippedTest.__str__):
2847         (SkippedTest.skip_entire_suite):
2848         (SkippedTest.skip_for_build_type):
2849         (TestRunner):
2850         (TestRunner.__init__):
2851
2852 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2853
2854         Unreviewed. Fix a crash in GTK+ test /webkit2/WebKitWebView/custom-charset.
2855
2856         It's an assert hit because we are reloading a view loaded with
2857         HTML data which is not supported. Use loadURI instead.
2858
2859         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2860         (testWebViewCustomCharset):
2861
2862 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2863
2864         [GLIB] Remove GMainLoopSource and GThreadSafeMainLoopSource
2865         https://bugs.webkit.org/show_bug.cgi?id=151633
2866
2867         Reviewed by Csaba Osztrogonác.
2868
2869         * TestWebKitAPI/PlatformGTK.cmake:
2870         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Removed.
2871
2872 2015-11-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2873
2874         [GTK] Remove the remaining uses of GMainLoopSource
2875         https://bugs.webkit.org/show_bug.cgi?id=151632
2876
2877         Reviewed by Žan Doberšek.
2878
2879         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2880         (testWebViewSyncRequestOnMaxConns):
2881         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2882         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2883         (WTR::TestRunner::TestRunner):
2884         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2885         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2886         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
2887         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2888         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2889         (WTR::timeoutSource):
2890         (WTR::TestController::notifyDone):
2891         (WTR::TestController::platformRunUntil):
2892
2893 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
2894
2895         [cmake] Add testb3 to the build system
2896         https://bugs.webkit.org/show_bug.cgi?id=151619
2897
2898         Reviewed by Gyuyoung Kim.
2899
2900         * Scripts/build-jsc:
2901
2902 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
2903
2904         [jhbuild] Fix pixman build with clang
2905         https://bugs.webkit.org/show_bug.cgi?id=151441
2906
2907         Reviewed by Carlos Garcia Campos.
2908
2909         * efl/jhbuild.modules:
2910         * gtk/jhbuild.modules:
2911
2912 2015-11-26  David Kilzer  <ddkilzer@apple.com>
2913
2914         Extract prependToEnvironmentVariableList
2915         <http://webkit.org/b/151536>
2916
2917         Reviewed by Daniel Bates.
2918
2919         Tests: webkitdirs_unittest/appendToEnvironmentVariableList.pl
2920                webkitdirs_unittest/prependToEnvironmentVariableList.pl
2921
2922         * Scripts/webkitdirs.pm: Export appendToEnvironmentVariableList
2923         and prependToEnvironmentVariableList.
2924         (appendToEnvironmentVariableList): Simplify variable name.
2925         Switch to use $Config{path_sep}.
2926         (prependToEnvironmentVariableList): Add new method.
2927         (setupMacWebKitEnvironment): Switch to use
2928         prependToEnvironmentVariableList().
2929         (setupIOSWebKitEnvironment): Ditto.
2930
2931         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl: Added.
2932         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl: Added.
2933
2934 2015-11-24  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2935
2936         REGRESSION(r192053): MiniBrowser doesn't exit when clicking on the close-window button
2937         https://bugs.webkit.org/show_bug.cgi?id=151567
2938
2939         Reviewed by Darin Adler.
2940
2941         * MiniBrowser/efl/main.c: Call window_close() instead of ewk_view_try_close().
2942         (on_window_deletion):
2943
2944 2015-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2945
2946         [GTK] Use the network process unconditionally
2947         https://bugs.webkit.org/show_bug.cgi?id=151541
2948
2949         Reviewed by Alex Christensen.
2950
2951         Fix TestInspectorServer test. Do not assume we already have the
2952         title we want when the page has been loaded, since the title is
2953         changed afterwards. So, check if the title has already been set,
2954         and if not wait for it.
2955
2956         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
2957         (openRemoteDebuggingSession):
2958
2959 2015-11-23  Alex Christensen  <achristensen@webkit.org>
2960
2961         Fix crash in ~WebProcessPool when using Geolocation with useNetworkProcess=true
2962         https://bugs.webkit.org/show_bug.cgi?id=151532
2963
2964         Reviewed by Benjamin Poulain.
2965
2966         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2967         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
2968         (TestWebKitAPI::TEST):
2969         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
2970         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker): Deleted.
2971         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker): Deleted.
2972         Properly load about:blank in all WebViews to clean up.  Without this change, we had a 
2973         Geolocation provider stopping after its state tracker was destroyed with its stack frame,
2974         so it was calling a function on a test object that had gone out of scope.
2975         Also, call WKContextSetUsesNetworkProcess(context, true) to show what crash this fixed,
2976         but that will become the default soon and that call will be removed.
2977
2978 2015-11-22  David Kilzer  <ddkilzer@apple.com>
2979
2980         run-webkit-tests: http server for imported W3C tests doesn't work with --layout-tests-directory switch
2981         <http://webkit.org/b/151542>
2982
2983         Reviewed by Daniel Bates.
2984
2985         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2986         (base_url): Use the Port object (already passed in) to give us
2987         the path to the LayoutTests directory, which already checks for a
2988         --layout-tests-directory command-line switch.
2989         (WebPlatformTestServer.__init__): Remove layout_test_results_dir
2990         argument since we can get this from the Port object already
2991         passed in via Port.results_directory().  Also switch to use
2992         Port.layout_tests_dir() to get the LayoutTests directory.
2993
2994         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
2995         (TestWebPlatformTestServer.test_custom_layout_tests_directory):
2996         Add test case for custom LayoutTests directory.
2997         (TestWebPlatformTestServer.test_previously_spawned_instance):
2998         Update Port object to set mock results directory as if it was
2999         set on the command-line.  Remove unneeded argument from
3000         WebPlatformTestServer constructor.
3001         (TestWebPlatformTestServer.test_corrupted_subserver_files): Ditto.
3002
3003         * Scripts/webkitpy/port/base.py:
3004         (Port.to.start_web_platform_test_server): Remove unneeded
3005         argument from WebPlatformTestServer constuctor.
3006
3007 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3008
3009         [GTK] Some unit tests fail when using the network process
3010         https://bugs.webkit.org/show_bug.cgi?id=151490
3011
3012         Reviewed by Martin Robinson.
3013
3014         Run the soup server in a separate thread in TestResources test to
3015         avoid deadlocks.
3016
3017         This fixes /webkit2/WebKitWebView/sync-request-on-max-conns and
3018         /webkit2/WebKitWebResource/get-data when using the network process.
3019
3020         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
3021         (beforeAll): Create the WebKitTestServer with ServerRunInThread flag.
3022         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
3023         (WebKitTestServer::WebKitTestServer): When ServerRunInThread is
3024         present, create a WorkQueue to run the server.
3025         (WebKitTestServer::run): Run the server in the work queue if it
3026         has been created.
3027         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h: Convert server
3028         type into server options as flags.
3029
3030 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3031
3032         [GTK] ImageDiff should normalize the diff image
3033         https://bugs.webkit.org/show_bug.cgi?id=151261
3034
3035         Reviewed by Sergio Villar Senin.
3036
3037         * ImageDiff/gtk/ImageDiff.cpp:
3038         (readPixbufFromStdin): Fix memory leak.
3039         (differenceImageFromDifferenceBuffer): Normalize diff buffer.
3040         (calculateDifference): Pass max distance to differenceImageFromDifferenceBuffer.
3041
3042 == Rolled over to ChangeLog-2015-11-21 ==