[EFL] Build break with latest EFL 1.8 libraries.
[WebKit-https.git] / Tools / ChangeLog
1 2013-10-24  Ryuan Choi  <ryuan.choi@samsung.com>
2
3         [EFL] Build break with latest EFL 1.8 libraries.
4         https://bugs.webkit.org/show_bug.cgi?id=123245
5
6         Reviewed by Gyuyoung Kim.
7
8         After fixed build break on EFL 1.8 at r138326, EFL libraries are changed
9         Eo typedef and splitted header files which contain version macro.
10
11         * TestWebKitAPI/PlatformWebView.h: Changed Eo typedef.
12         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
13         * WebKitTestRunner/PlatformWebView.h: Ditto.
14
15 2013-10-24  Carlos Garcia Campos  <cgarcia@igalia.com>
16
17         [GObject bindings] Make EventTarget interface introspectable
18         https://bugs.webkit.org/show_bug.cgi?id=77835
19
20         Reviewed by Gustavo Noronha Silva.
21
22         * Scripts/webkitpy/style/checker.py: Add exceptions for custom
23         GObject DOM bindings headers.
24
25 2013-10-23  Lucas Forschler  <lforschler@apple.com>
26
27         Add two more mac bots to the Mavericks Test Queue.
28         
29         Unreviewed.
30         
31         * BuildSlaveSupport/build.webkit.org-config/config.json:
32
33 2013-10-23  Filip Pizlo  <fpizlo@apple.com>
34
35         Have a way of dealing with slow tests in run-jsc-stress-tests
36         https://bugs.webkit.org/show_bug.cgi?id=123221
37
38         Reviewed by Mark Hahnenberg.
39         
40         If you add the slow! command to //@ then all subsequent plans are prepended to the run list
41         rather than appended to it. This means that slow tests get queued up first and are less likely
42         to block completion.
43
44         * Scripts/run-jsc-stress-tests:
45
46 2013-10-23  Alex Christensen  <achristensen@webkit.org>
47
48         Explicitly build Win32 or x64 configuration on Windows.
49         https://bugs.webkit.org/show_bug.cgi?id=123206
50
51         Reviewed by Brent Fulgham.
52
53         * Scripts/webkitdirs.pm:
54         (jscPath):
55         (determineConfigurationForVisualStudio):
56         (determinePassedConfiguration):
57         Add |Win32 to the end of 32-bit Visual Studio build configurations.
58         (safariPath):
59         * Scripts/build-webkit:
60         * Scripts/old-run-webkit-tests:
61         * Scripts/run-api-tests:
62         (testToolPath):
63         * Scripts/run-javascriptcore-tests:
64         (testapiPath):
65         * Scripts/run-regexp-tests:
66         (testapiPath):
67         * Scripts/sunspider-compare-results:
68         (pathToBuiltJSC):
69         Use configuration instead of configurationForVisualStudio, which are now always different.
70
71 2013-10-23  Mark Lam  <mark.lam@apple.com>
72
73         Re-instate ProposedDatabases needed by detailsForNameAndOrigin().
74         https://bugs.webkit.org/show_bug.cgi?id=123131.
75
76         Reviewed by Geoffrey Garen.
77
78         Updated these files to allow database quotas to grow within a limit for
79         testing purposes.
80
81         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
82         (BlackBerry::WebKit::DumpRenderTree::exceededDatabaseQuota):
83         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
84         (onExceededDatabaseQuota):
85         * DumpRenderTree/mac/UIDelegate.mm:
86         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]):
87         * DumpRenderTree/win/UIDelegate.cpp:
88         (UIDelegate::exceededDatabaseQuota):
89         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
90         (WTR::InjectedBundlePage::didExceedDatabaseQuota):
91         * WebKitTestRunner/TestController.cpp:
92         (WTR::exceededDatabaseQuota):
93
94 2013-10-23  Simon Fraser  <simon.fraser@apple.com>
95
96         It's valid to have a build ID of 0.
97
98         Reviewed by Tim Hatcher.
99
100         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
101         (BuildbotIteration):
102
103 2013-10-23  Simon Fraser  <simon.fraser@apple.com>
104
105         Remove Lion bots from the Dashboard.
106
107         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
108         (WebKitBuildbot):
109
110 2013-10-23  Mario Sanchez Prada  <mario.prada@samsung.com>
111
112         [GTK] Expose image links properly
113         https://bugs.webkit.org/show_bug.cgi?id=84044
114
115         Reviewed by Chris Fleizach.
116
117         Expose the accessible URL if present, as yet another attribute
118         for the AccessibilityUIElement wrapper. For coherence with what
119         the Mac port does (and what you would expect as the output of
120         the layout test), we strip the absolute URL path for relative
121         references, if it's the case, leaving the base of the URL path
122         out of the exposed string.
123
124         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
125         (attributesOfElement): Print the AXURL, if available.
126         (AccessibilityUIElement::url): Expose the URL if present. That
127         is, if the wrapped AtkObject implements AtkHyperlinkImpl.
128         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
129         (attributesOfElement): Print the AXURL, if available.
130         (WTR::AccessibilityUIElement::url): Expose the URL if present.
131         That is, if the wrapped AtkObject implements AtkHyperlinkImpl.
132
133 2013-10-23  Simon Fraser  <simon.fraser@apple.com>
134
135         Remove Lion bots.
136
137         * BuildSlaveSupport/build.webkit.org-config/config.json:
138
139 2013-10-22  Simon Fraser  <simon.fraser@apple.com>
140
141         Dashboard repaints constantly
142         https://bugs.webkit.org/show_bug.cgi?id=122133
143
144         Reviewed by Tim Horton.
145         
146         Pulsing shadows are really bad for battery life.
147
148         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
149         (.status-line.bad .bubble):
150         (.status-line.bad .message):
151
152 2013-10-22  Commit Queue  <commit-queue@webkit.org>
153
154         Unreviewed, rolling out r157835.
155         http://trac.webkit.org/changeset/157835
156         https://bugs.webkit.org/show_bug.cgi?id=123192
157
158         broke 32-bit builds (Requested by smfr on #webkit).
159
160         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
161         (TestWebKitAPI::TEST):
162
163 2013-10-22  Jer Noble  <jer.noble@apple.com>
164
165         [WTF] Add a multiplication operator (and a few others) to MediaTime
166         https://bugs.webkit.org/show_bug.cgi?id=123137
167
168         Reviewed by Eric Carlson.
169
170         Add tests for new MediaTime operators.
171
172         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
173         (TestWebKitAPI::TEST):
174
175 2013-10-22  Simon Fraser  <simon.fraser@apple.com>
176
177         Educate webkitpy about Mavericks.
178
179         Reviewed by Ryosuke Niwa.
180
181         * Scripts/webkitpy/common/system/platforminfo.py:
182         (PlatformInfo._determine_mac_version):
183         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
184         (TestPlatformInfo.test_os_version):
185         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
186         (TestExpectationParser):
187         * Scripts/webkitpy/port/builders.py:
188         * Scripts/webkitpy/port/mac.py:
189         (MacPort):
190         * Scripts/webkitpy/port/mac_unittest.py:
191         (test_versions):
192         (test_baseline_search_path):
193         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
194         (TestRebaselineTest.test_baseline_directory):
195         (TestRebaselineExpectations.test_rebaseline_expectations):
196
197 2013-10-22  Stephanie Lewis  <slewis@apple.com>
198
199         Update the build trigger list for Mavericks.
200
201         Unreviewed.
202
203         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
204         (_should_file_trigger_build):
205
206 2013-10-22  Simon Fraser  <simon.fraser@apple.com>
207
208         Add Mavericks bots to the dashboard.
209
210         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
211         (WebKitBuildbot):
212
213 2013-10-22  Samuel White  <samuel_white@apple.com>
214
215         AX: Add paramAttrs to fetch start and end text markers in a given rect.
216         https://bugs.webkit.org/show_bug.cgi?id=122164
217
218         Reviewed by Chris Fleizach.
219
220         Added accessibility element hooks to test endTextMarkerForBounds and startTextMarkerForBounds.
221
222         * DumpRenderTree/AccessibilityUIElement.cpp:
223         (endTextMarkerForBoundsCallback):
224         (startTextMarkerForBoundsCallback):
225         (AccessibilityUIElement::endTextMarkerForBounds):
226         (AccessibilityUIElement::startTextMarkerForBounds):
227         (AccessibilityUIElement::getJSClass):
228         * DumpRenderTree/AccessibilityUIElement.h:
229         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
230         (AccessibilityUIElement::endTextMarkerForBounds):
231         (AccessibilityUIElement::startTextMarkerForBounds):
232         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
233         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
234         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
235         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
236         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
237         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
238         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
239         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
240         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
241         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
242         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
243
244 2013-10-22  Ryosuke Niwa  <rniwa@webkit.org>
245
246         There should be a way to specify additional repository paths in NRWT
247         https://bugs.webkit.org/show_bug.cgi?id=123135
248
249         Reviewed by Alexey Proskuryakov.
250
251         Added --additional-repository-name and --additional-repository-path options to NRWT.
252         These options allow us to submit addtional repository information, such as of Safari's
253         to the new flakiness dashboard.
254
255         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
256         (parse_args):
257         * Scripts/webkitpy/port/base.py:
258         (Port.repository_paths):
259
260 2013-10-22  Commit Queue  <commit-queue@webkit.org>
261
262         Unreviewed, rolling out r157774.
263         http://trac.webkit.org/changeset/157774
264         https://bugs.webkit.org/show_bug.cgi?id=123167
265
266         causes python test to fail (Requested by smfr on #webkit).
267
268         * Scripts/webkitpy/layout_tests/controllers/manager.py:
269         (Manager.run):
270         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
271         (TestExpectations.__init__):
272         (TestExpectations._add_expectations):
273         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
274         (parse_args):
275         (_set_up_derived_options):
276
277 2013-10-22  Lucas Forschler  <lforschler@apple.com>
278
279         Prepare WebKit Buildbot master for Mavericks.
280         This adds the following bot configurations:
281             Mavericks Release/Debug builders
282             Mavericks Release/Debug WK1 Testers
283             Mavericks Release/Debug WK2 Testers
284
285         Unreviewed.
286         
287         * BuildSlaveSupport/build.webkit.org-config/config.json:
288
289 2013-10-21  Tamas Gergely  <gertom@inf.u-szeged.hu>
290
291         Run tests as if they are expected to pass when --force is given.
292         https://bugs.webkit.org/show_bug.cgi?id=112890
293
294         Reviewed by Ryosuke Niwa.
295
296         The --force switch of new-run-webkit-tests is now forces all tests to
297         be run with 'PASS' as expected result.
298
299         * Scripts/webkitpy/layout_tests/controllers/manager.py:
300         (Manager.run):
301         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
302         (TestExpectations.__init__):
303         (TestExpectations._add_expectations):
304         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
305         (parse_args):
306         (_set_up_derived_options):
307
308 2013-10-21  Mark Rowe  <mrowe@apple.com>
309
310         Add a version of WebKitSystemInterface for Mavericks.
311
312         Reviewed by Ryosuke Niwa.
313
314         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
315         * Scripts/copy-webkitlibraries-to-product-directory:
316         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
317
318 2013-10-21  Anders Carlsson  <andersca@apple.com>
319
320         Navigation policy callback not called when performing the same fragment navigation twice
321         https://bugs.webkit.org/show_bug.cgi?id=123121
322         <rdar://problem/15230466>
323
324         Reviewed by Beth Dakin.
325
326         Add a test.
327
328         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
329         * TestWebKitAPI/Tests/mac/FragmentNavigation.html: Added.
330         * TestWebKitAPI/Tests/mac/FragmentNavigation.mm: Added.
331         (+[WebKit1FragmentNavigationTestDelegate shared]):
332         (-[WebKit1FragmentNavigationTestDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
333         (-[WebKit1FragmentNavigationTestDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
334         (-[WebKit1FragmentNavigationTestDelegate webView:didFinishLoadForFrame:]):
335         (-[WebKit1FragmentNavigationTestDelegate _runNextTestWithWebView:]):
336         (TestWebKitAPI::TEST):
337
338 2013-10-21  Dan Bernstein  <mitz@apple.com>
339
340         Style checker should allow a space after the @property keyword
341         https://bugs.webkit.org/show_bug.cgi?id=123117
342
343         Reviewed by Anders Carlsson.
344
345         * Scripts/webkitpy/style/checkers/cpp.py:
346         (check_spacing_for_function_call): Allow a space between @property and the following (
347         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
348         (CppStyleTest.test_spacing_for_fncall): Added a test case.
349
350 2013-10-21  peavo@outlook.com  <peavo@outlook.com>
351
352         [WinCairo] Build does not start.
353         https://bugs.webkit.org/show_bug.cgi?id=123059
354
355         Reviewed by Csaba Osztrogonác.
356
357         The function isAppleWinWebKit() does no longer return true for WinCairo, need to add isWinCairo() checks instead.
358
359         * Scripts/build-webkit:
360
361 2013-10-21  Zan Dobersek  <zdobersek@igalia.com>
362
363         [Jhbuild] Bump the required Jhbuild revision
364         https://bugs.webkit.org/show_bug.cgi?id=123089
365
366         Reviewed by Carlos Garcia Campos.
367
368         * jhbuild/jhbuild-wrapper: Latest versions of the gnome-common tools produce failures when configuring Jhbuild
369         due to the configure.ac script using both IT_PROG_INTLTOOL and AM_GNU_GETTEXT macros. This is already fixed
370         in the Jhbuild source so a more recent revision of it should be used.
371
372 2013-10-19  Alexey Proskuryakov  <ap@apple.com>
373
374         Mac build fix.
375
376         * DumpRenderTree/mac/DumpRenderTree.mm: Cast the length for %lu specifier.
377
378 2013-10-19  Alexey Proskuryakov  <ap@apple.com>
379
380         Enable webaudio/ tests on DRT/Mac
381         https://bugs.webkit.org/show_bug.cgi?id=86914
382
383         Reviewed by Darin Adler.
384
385         * DumpRenderTree/ForwardingHeaders/runtime/ArrayBufferView.h: Copied from Source/WebCore/ForwardingHeaders/runtime/ArrayBufferView.h.
386         * DumpRenderTree/ForwardingHeaders/runtime/JSArrayBufferView.h: Copied from Source/WebCore/ForwardingHeaders/runtime/JSArrayBufferView.h.
387         * DumpRenderTree/ForwardingHeaders/runtime/TypedArrayInlines.h: Copied from Source/WebCore/ForwardingHeaders/runtime/TypedArrayInlines.h.
388         There is no way to efficiently get TypedArray buffer using API, so we need some internal headers.
389
390         * DumpRenderTree/TestRunner.cpp:
391         (setAudioResultCallback): 
392         (TestRunner::staticFunctions):
393         * DumpRenderTree/TestRunner.h:
394         (TestRunner::audioResult):
395         (TestRunner::setAudioResult):
396         The function has a different name and argument type now, updated accordingly.
397         Changed buffer from std::string to std::vector<char>, because it's more idiomatic.
398
399         * DumpRenderTree/mac/DumpRenderTree.mm:
400         (dumpAudio): Updated for the new name of audioResult accessor.
401         (dump): Print the result in the format webkitpy currently expects.
402
403         * WebKitTestRunner/TestInvocation.cpp:
404         (WTR::TestInvocation::dumpAudio): fwrite the whole block at once, splitting into
405         chunks made no sense.
406
407         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
408         (WTR::TestRunner::setAudioResult): Added a FIXME about getting off WKBundle SPI.
409
410         * DumpRenderTree/CMakeLists.txt: Added JavaScriptCore/parser to include search list,
411         so that "SourceProvider.h" can be found.
412
413 2013-10-19  Ryosuke Niwa  <rniwa@webkit.org>
414
415         run-webkit-tests should submit time and modifiers to the new flakiness dashboard
416         https://bugs.webkit.org/show_bug.cgi?id=123070
417
418         Reviewed by Alexey Proskuryakov.
419
420         * Scripts/webkitpy/layout_tests/controllers/manager.py:
421         (Manager.run):
422         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
423         (summarize_results): Added include_time_and_modifiers. Report test_run_time and modifiers
424         in the test expectations when this argument is set to true.
425
426 2013-10-19  Alexey Proskuryakov  <ap@apple.com>
427
428         Mac DumpRenderTree builds without NDEBUG even in release mode
429         https://bugs.webkit.org/show_bug.cgi?id=123066
430
431         Reviewed by Dan Bernstein.
432
433         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
434         * DumpRenderTree/mac/Configurations/Base.xcconfig:
435         Use the same pattern as WebCore and WebKitTestRunner.
436
437 2013-10-19  Zan Dobersek  <zdobersek@igalia.com>
438
439         REGRESSION(r155373): Mac WK2 EWS bots is actually Mac WK1 debug
440         https://bugs.webkit.org/show_bug.cgi?id=123064
441
442         Reviewed by Ryosuke Niwa.
443
444         Revert r155373 as it is causing incorrect port/platform deduction for the Mac EWS systems.
445
446         * Scripts/webkitpy/common/config/ports.py: Added.
447         (DeprecatedPort):
448         (DeprecatedPort.name):
449         (DeprecatedPort.flag):
450         (DeprecatedPort.script_path):
451         (DeprecatedPort.script_shell_command):
452         (DeprecatedPort.port):
453         (DeprecatedPort.makeArgs):
454         (DeprecatedPort.update_webkit_command):
455         (DeprecatedPort.check_webkit_style_command):
456         (DeprecatedPort.prepare_changelog_command):
457         (DeprecatedPort.build_webkit_command):
458         (DeprecatedPort.run_javascriptcore_tests_command):
459         (DeprecatedPort.run_webkit_unit_tests_command):
460         (DeprecatedPort.run_webkit_tests_command):
461         (DeprecatedPort.run_python_unittests_command):
462         (DeprecatedPort.run_perl_unittests_command):
463         (DeprecatedPort.run_bindings_tests_command):
464         (MacPort):
465         (MacWK2Port):
466         (MacWK2Port.run_webkit_tests_command):
467         (WinPort):
468         (WinPort.run_bindings_tests_command):
469         (GtkPort):
470         (GtkPort.build_webkit_command):
471         (GtkPort.run_webkit_tests_command):
472         (GtkWK2Port):
473         (GtkWK2Port.build_webkit_command):
474         (GtkWK2Port.run_webkit_tests_command):
475         (QtPort):
476         (QtPort.build_webkit_command):
477         (QtPort.run_webkit_tests_command):
478         (QtWK2Port):
479         (QtWK2Port.build_webkit_command):
480         (QtWK2Port.run_webkit_tests_command):
481         (EflPort):
482         (EflPort.build_webkit_command):
483         (EflWK2Port):
484         (EflWK2Port.build_webkit_command):
485         * Scripts/webkitpy/common/config/ports_mock.py: Added.
486         (MockPort):
487         (MockPort.name):
488         (MockPort.check_webkit_style_command):
489         (MockPort.update_webkit_command):
490         (MockPort.build_webkit_command):
491         (MockPort.prepare_changelog_command):
492         (MockPort.run_python_unittests_command):
493         (MockPort.run_perl_unittests_command):
494         (MockPort.run_javascriptcore_tests_command):
495         (MockPort.run_webkit_unit_tests_command):
496         (MockPort.run_webkit_tests_command):
497         (MockPort.run_bindings_tests_command):
498         * Scripts/webkitpy/common/config/ports_unittest.py: Added.
499         (DeprecatedPortTest):
500         (DeprecatedPortTest.test_mac_port):
501         (DeprecatedPortTest.test_gtk_port):
502         (DeprecatedPortTest.test_gtk_wk2_port):
503         (DeprecatedPortTest.test_efl_port):
504         (DeprecatedPortTest.test_qt_port):
505         (DeprecatedPortTest.test_qt_wk2_port):
506         * Scripts/webkitpy/port/base.py:
507         (Port._port_flag_for_scripts):
508         (Port._wk2_port_name):
509         * Scripts/webkitpy/port/base_unittest.py:
510         (PortTest.test_build_path):
511         * Scripts/webkitpy/port/efl_unittest.py:
512         (EflPortTest.test_show_results_html_file):
513         * Scripts/webkitpy/port/gtk_unittest.py:
514         (GtkPortTest.test_get_crash_log):
515         * Scripts/webkitpy/port/mac_unittest.py:
516         (test_64bit):
517         * Scripts/webkitpy/port/test.py:
518         (TestPort.virtual_test_suites):
519         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
520         (FlakyTestReporter.__init__):
521         * Scripts/webkitpy/tool/bot/irc_command.py:
522         (Rollout._update_working_copy):
523         * Scripts/webkitpy/tool/commands/download_unittest.py:
524         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
525         (AbstractEarlyWarningSystem.run_command):
526         * Scripts/webkitpy/tool/commands/queues.py:
527         (PatchProcessingQueue.begin_work_queue):
528         (CommitQueue.run_command):
529         * Scripts/webkitpy/tool/main.py:
530         (WebKitPatch.__init__):
531         (WebKitPatch.deprecated_port):
532         (WebKitPatch.handle_global_options):
533         * Scripts/webkitpy/tool/mocktool.py:
534         (MockTool.__init__):
535         (MockTool.deprecated_port):
536         * Scripts/webkitpy/tool/steps/build.py:
537         (Build.build):
538         * Scripts/webkitpy/tool/steps/checkstyle.py:
539         (CheckStyle.run):
540         * Scripts/webkitpy/tool/steps/commit.py:
541         (Commit._check_test_expectations):
542         * Scripts/webkitpy/tool/steps/preparechangelog.py:
543         (PrepareChangeLog.run):
544         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
545         (PrepareChangeLogForRevert.run):
546         * Scripts/webkitpy/tool/steps/runtests.py:
547         (RunTests.run):
548         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
549         (RunTestsTest.test_webkit_run_unit_tests):
550         * Scripts/webkitpy/tool/steps/steps_unittest.py:
551         (StepsTest.test_runtests_args):
552         * Scripts/webkitpy/tool/steps/update.py:
553         (Update._update_command):
554         * Scripts/webkitpy/tool/steps/update_unittest.py:
555         (UpdateTest.test_update_command_non_interactive):
556         (UpdateTest.test_update_command_interactive):
557
558 2013-10-19  Andreas Kling  <akling@apple.com>
559
560         RefPtr::releaseNonNull() incorrectly increments the refcount.
561         <https://webkit.org/b/123063>
562
563         Add an API test to verify that no extra refs are added when calling
564         RefPtr::releaseNonNull().
565
566         Reviewed by Anders Carlsson.
567
568 2013-10-18  Rik Cabanier <cabanier@adobe.com>
569         Add Rik Cabanier to list of committers
570         https://bugs.webkit.org/show_bug.cgi?id=123031
571
572         reviewed by Dirk Schulze.
573
574         * Tools/Scripts/webkitpy/common/config/contributors.json: Added name.
575
576 2013-10-18  Denis Nomiyama  <d.nomiyama@samsung.com>
577
578         [ATK] Fix invalid signal to set objects to an unknown state "layout-complete"
579         https://bugs.webkit.org/show_bug.cgi?id=122970
580
581         Reviewed by Mario Sanchez Prada.
582
583         Removed an invalid signal to set an object state to layout-complete
584         that does not exist. It was replaced by ATK:AtkDocument:load-complete.
585
586         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
587         (axObjectEventListener): Replaced layout-complete with load-complete.
588         (connectAccessibilityCallbacks): Connect callback to new listener for
589         ATK:AtkDocument:load-complete.
590         (disconnectAccessibilityCallbacks): Disconnect callback to new listener
591         for ATK:AtkDocument:load-complete.
592         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
593         (axObjectEventListener): Replaced layout-complete with load-complete.
594         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
595         Connect callback to new listener for ATK:AtkDocument:load-complete.
596         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
597         Disconnect callback to new listener for ATK:AtkDocument:load-complete.
598
599 2013-10-18  Carlos Garcia Campos  <cgarcia@igalia.com>
600
601         [GTK] Generate API documentation for GObject DOM bindings
602         https://bugs.webkit.org/show_bug.cgi?id=121538
603
604         Reviewed by Gustavo Noronha Silva.
605
606         The .symbols file that is now generated for checking GObject DOM
607         bindings API compatibility while building can also be used to
608         generate the files needed to produce the gtk-doc
609         documentation. The new script generate-webkitdom-doc-files can
610         generate the docs.sgml and sections.txt files from the given list
611         of .symbols files.
612
613         * gtk/GNUmakefile.am: Add rules to generate webkitdomgtk-docs.sgml
614         and webkitdomgtk-sections.txt as well as rules to install the
615         generated WebKitDOMGTK documentation.
616         * gtk/generate-gtkdoc:
617         (webkitdom_docs_html_path): New helper function that returns the
618         path where the DOM API documentation has been generated.
619         (get_webkit2_options): Include DOM API docs to the list of xref
620         dependencies.
621         (get_webkit1_options): Ditto.
622         (get_webkitdom_options): Return the gtk-doc options to generate
623         the DOM API docs.
624         (get_webkitdom_options.derived_sources_path):
625         (get_webkitdom_options.src_path):
626         * gtk/generate-webkitdom-doc-files: Added.
627         (WebKitDOMDocGenerator):
628         (WebKitDOMDocGenerator.write_header):
629         (WebKitDOMDocGenerator.write_section):
630         (WebKitDOMDocGenerator.write_footer):
631         (WebKitDOMDocGeneratorDocs):
632         (WebKitDOMDocGeneratorDocs.write_header):
633         (write_section):
634         (write_footer):
635         (WebKitDOMDocGeneratorSections):
636         (WebKitDOMDocGeneratorSections.__init__):
637         (WebKitDOMDocGeneratorSections._dom_class):
638         (WebKitDOMDocGeneratorSections._dom_class_decamelize):
639         (WebKitDOMDocGeneratorSections._symbol_list):
640         (WebKitDOMDocGeneratorSections.write_section):
641
642 2013-10-17  Alex Christensen  <achristensen@webkit.org>
643
644         Run JavaScriptCore tests again on Windows.
645         https://bugs.webkit.org/show_bug.cgi?id=122787
646
647         Reviewed by Tim Horton.
648
649         * Scripts/build-jsc:
650         (buildMyProject): Use JavaScriptCore.sln to build JavaScriptCore and WTF.
651         * Scripts/run-javascriptcore-tests: Don't run stress tests on WinCairo.
652         * Scripts/webkitdirs.pm:
653         (determineConfigurationForVisualStudio):
654         (determineConfigurationProductDir):
655         Build directory should end with bin64 and configuration should end with |x64 on Win64.
656         (isAppleWinWebKit):
657         (copyInspectorFrontendFiles):
658         (setPathForRunningWebKitApp):
659         Separated WinCairo directories and options from AppleWin.
660
661 2013-10-17  Mihnea Ovidenie  <mihnea@adobe.com>
662
663         Unreviewed. Add myself as a reviewer.
664
665         * Scripts/webkitpy/common/config/contributors.json:
666
667 2013-10-17  Andreas Kling  <akling@apple.com>
668
669         Make it possible to assign a PassRef to a RefPtr.
670         <https://webkit.org/b/122943>
671
672         Added a small API test for RefPtr=(PassRef) so we know this code
673         will compile (and work.)
674
675         Reviewed by Antti Koivisto.
676
677 2013-10-16  Filip Pizlo  <fpizlo@apple.com>
678
679         We need test coverage for just the Baseline JIT
680         https://bugs.webkit.org/show_bug.cgi?id=122929
681
682         Reviewed by Sam Weinig.
683         
684         Adds no-LLInt versions of all tests. For the Mozilla tests, also add a BaselineJIT-only
685         variant.
686
687         * Scripts/run-jsc-stress-tests:
688
689 2013-10-16  Ryosuke Niwa  <rniwa@webkit.org>
690
691         Support multiple repositories in submitting results to --results-server-host
692         https://bugs.webkit.org/show_bug.cgi?id=122935
693
694         Reviewed by Anders Carlsson.
695
696         Remoevd --got-revision and added the logic to extract revision information
697         from multiple repositories as done in run-perf-tests.
698
699         * Scripts/webkitpy/layout_tests/controllers/manager.py:
700         (Manager.upload_results):
701         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
702         (parse_args):
703
704 2013-10-16  Darin Adler  <darin@apple.com>
705
706         Add PassRef and createRefCounted so we can improve creation of RefCounted objects
707         https://bugs.webkit.org/show_bug.cgi?id=122904
708
709         Reviewed by Anders Carlsson.
710
711         * TestWebKitAPI/Tests/WTF/Ref.cpp: Added some basic tests for adoptRef and PassRef.
712
713 2013-10-16  Darin Adler  <darin@apple.com>
714
715         Need tests for RefPtr self-assignment and self-move-assignment.
716
717         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Added tests.
718
719 2013-10-16  Robert Plociennik  <r.plociennik@samsung.com>
720
721         [EFL] Minibrowser can't load child window's location
722         https://bugs.webkit.org/show_bug.cgi?id=122485
723
724         Reviewed by Gyuyoung Kim.
725
726         * MiniBrowser/efl/main.c: Now calling window_create() without the url parameter
727             followed by an explicit call to ewk_view_url_set() where appropriate.
728         (on_key_down):
729         (on_window_create):
730         (window_create):
731         (elm_main):
732
733 2013-10-15  Sergio Correia  <sergio.correia@openbossa.org>
734
735         [EFL][WK2] Make SeccompFilters build again after r156349 and r156353
736         https://bugs.webkit.org/show_bug.cgi?id=122872
737
738         Reviewed by Anders Carlsson.
739
740         * TestWebKitAPI/PlatformEfl.cmake: Mark SeccompFilters API test as
741         failing.
742
743 2013-10-15  Dean Jackson  <dino@apple.com>
744
745         Add ENABLE_WEB_ANIMATIONS flag
746         https://bugs.webkit.org/show_bug.cgi?id=122871
747
748         Reviewed by Tim Horton.
749
750         Eventually might be http://dev.w3.org/fxtf/web-animations/
751         but this is just engine-internal work at the moment.
752
753         * Scripts/webkitperl/FeatureList.pm:
754
755 2013-10-15  Darin Adler  <darin@apple.com>
756
757         Add some API tests for Vector, RefPtr, and Ref
758         https://bugs.webkit.org/show_bug.cgi?id=122840
759
760         Reviewed by Andreas Kling.
761
762         * TestWebKitAPI/CMakeLists.txt: Added new files.
763         * TestWebKitAPI/GNUmakefile.am: Ditto.
764         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
765         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
766         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
767
768         * TestWebKitAPI/Tests/WTF/Ref.cpp: Added.
769         * TestWebKitAPI/Tests/WTF/RefLogger.h: Added.
770         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Added.
771         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added move-only insert tests.
772
773 2013-10-14  Roger Fong  <roger_fong@apple.com>
774
775         Adding myself to CC list for some components.
776
777         * Scripts/webkitpy/common/config/watchlist:
778
779 2013-10-13  Darin Adler  <darin@apple.com>
780
781         Deprecate or remove deleteAllValues functions; there are only a few call sites left
782         https://bugs.webkit.org/show_bug.cgi?id=122738
783
784         Reviewed by Anders Carlsson.
785
786         * DumpRenderTree/win/DRTDataObject.cpp:
787         (DRTDataObject::~DRTDataObject):
788         * DumpRenderTree/win/UIDelegate.cpp:
789         (DRTUndoStack::~DRTUndoStack):
790         (DRTUndoStack::clear):
791         Renamed deleteAllValues to deprecatedDeleteAllValues.
792
793         * Scripts/do-webcore-rename: Updated to perform this rename, as is traditional.
794
795 2013-10-13  Alexey Proskuryakov  <ap@apple.com>
796
797         build.webkit.org/dashboard incorrectly shows interrupted builds as green
798         https://bugs.webkit.org/show_bug.cgi?id=122732
799
800         Reviewed by Tim Hatcher.
801
802         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
803         (BuildbotIteration.prototype.update): Removed a special case for status 4 (EXCEPTION).
804         I don't see it occur any time in recent history, but judging from what happens for
805         status 5 (RETRY), we can just finish this function normally.
806         Record overall text description for iteration as BuildbotIteration.text.
807
808         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
809         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): If an iteration is a failure,
810         but no tests failed, make it yellow, and use buildbot-provided description for it.
811
812 2013-10-13  Alexey Proskuryakov  <ap@apple.com>
813
814         Remove Chromium specific code from flakiness dashboard
815         https://bugs.webkit.org/show_bug.cgi?id=122714
816
817         Reviewed by Sam Weinig.
818
819         Also removed code related to GPU tests and virtual suites.
820         "Fallbacks map" was chromium only too, not sure why they needed special handling there.
821
822         * TestResultServer/model/jsonresults_unittest.py:
823         * TestResultServer/static-dashboards/builders.js:
824         * TestResultServer/static-dashboards/dashboard_base.js:
825         * TestResultServer/static-dashboards/flakiness_dashboard.html:
826         * TestResultServer/static-dashboards/flakiness_dashboard.js:
827         * TestResultServer/static-dashboards/flakiness_dashboard_tests.css:
828         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
829         * TestResultServer/static-dashboards/history.js:
830         * TestResultServer/static-dashboards/loader.js:
831         * TestResultServer/static-dashboards/ui.js:
832         * TestResultServer/templates/uploadform.html:
833
834 2013-10-11  Timothy Hatcher  <timothy@apple.com>
835
836         Remove preference support for picking the old Web Inspector.
837         https://bugs.webkit.org/show_bug.cgi?id=122655
838
839         Reviewed by Alexey Proskuryakov.
840
841         * WebKitTestRunner/TestController.cpp:
842         (WTR::TestController::resetStateToConsistentValues):
843
844 2013-10-11  Filip Pizlo  <fpizlo@apple.com>
845
846         Fix 64-bit build on everything but Windows.
847
848         Rubber stamped by Brent Fulgham.
849
850         * Scripts/webkitdirs.pm:
851         (argumentsForConfiguration):
852
853 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
854
855         Touch a file to see how auto-update works.
856
857         Rubber-stamped by Tim Hatcher.
858
859         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
860
861 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
862
863         LeaksViewer fails to present recent results list if current build is still updating svn
864         https://bugs.webkit.org/show_bug.cgi?id=122670
865
866         Fixed an obvious mistake in the previous patch.
867
868         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
869         (RecentBuildsLoader.prototype.start):
870
871 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
872
873         LeaksViewer fails to present recent results list if current build is still updating svn
874         https://bugs.webkit.org/show_bug.cgi?id=122670
875
876         Reviewed by Adam Roben.
877
878         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
879         (RecentBuildsLoader.prototype.start): Skip builds that don't have an svn revision yet.
880
881 2013-10-11  Brent Fulgham  <bfulgham@apple.com>
882
883         Unreviewed build fix for --64-bit target.
884
885         * Scripts/webkitdirs.pm:
886         (argumentsForConfiguration): Use 'isWin64' test, since @ARGV value may have
887         been removed by this point.
888         (hasArgument): Remove unused temporary.
889
890 2013-10-10  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
891
892         webkit-patch failure-reason has a quite low limit for 'too many failures'
893         https://bugs.webkit.org/show_bug.cgi?id=122556
894
895         Reviewed by Darin Adler.
896
897         * Scripts/webkitpy/tool/commands/queries.py:
898         (FailureReason._explain_failures_for_builder): adjust the number of too many failures
899         to match what the layout test runners use these days.
900
901 2013-10-10  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
902
903         webkit-patch failure-reason should allow specifying failures one is interested in
904         https://bugs.webkit.org/show_bug.cgi?id=122554
905
906         Reviewed by Darin Adler.
907
908         * Scripts/webkitpy/tool/commands/queries.py:
909         (FailureReason):
910         (FailureReason._explain_failures_for_builder): keep track of explained failures and drop out of the
911         loop if the ones we're interested in been explained.
912         (FailureReason._done_explaining): check the failures we're interested in have been explained, if any.
913         (FailureReason.execute): initialize failures to explain and the explained set.
914
915 2013-10-10  Filip Pizlo  <fpizlo@apple.com>
916
917         Make sure that DataTypes.h is in the binary drop.
918
919         Rubber stamped by Michael Saboff.
920
921         * Scripts/export-llvm-build:
922
923 2013-10-10  Filip Pizlo  <fpizlo@apple.com>
924
925         FTL: Soft-link LLVM as a workaround for LLVM's static initializers and exit-time destructors
926         https://bugs.webkit.org/show_bug.cgi?id=122566
927
928         Reviewed by Mark Rowe.
929
930         * Scripts/configure-llvm:
931
932 2013-10-10  Mark Rowe  <mrowe@apple.com>
933
934         <rdar://problem/13341666> WebKit should always build against an SDK.
935
936         Have all projects default to building against the OS X Internal SDK for the Production
937         configuration. For the Debug and Release configurations, look for UseInternalSDK.xcconfig
938         to determine whether the OS X Internal SDK should be used. If not, use the normal OS X SDK.
939
940         Reviewed by Dan Bernstein.
941
942         * DumpRenderTree/mac/Configurations/Base.xcconfig:
943         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
944         * MiniBrowser/Configurations/Base.xcconfig:
945         * MiniBrowser/Configurations/DebugRelease.xcconfig:
946         * TestWebKitAPI/Configurations/Base.xcconfig:
947         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
948         * WebKitTestRunner/Configurations/Base.xcconfig:
949         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
950
951 2013-10-10  Gustavo Noronha Silva  <gns@gnome.org>
952
953         Unreviewed gardening, the inspector protocol timeouts are also affecting TestInspectorServer.
954
955         * Scripts/run-gtk-tests:
956         (TestRunner): skip TestInspectorServer.
957
958 2013-10-10  Andres Gomez  <agomez@igalia.com>
959
960         [GTK] Provide search functionality to MiniBrowser
961         https://bugs.webkit.org/show_bug.cgi?id=117631
962
963         Reviewed by Carlos Garcia Campos.
964
965         Adds a search bar to MiniBrowser with the minimum functionality
966         and a new button to the toolbar for showing the new search
967         bar. Typical keyboard shortcuts are also added.
968
969         * MiniBrowser/gtk/BrowserSearchBar.c: Added.
970         (doSearch):
971         (searchNext):
972         (searchPrevious):
973         (searchCloseButtonClickedCallback):
974         (searchEntryMenuIconPressedCallback):
975         (searchEntryClearIconReleasedCallback):
976         (searchEntryChangedCallback):
977         (searchEntryActivatedCallback):
978         (searchPrevButtonClickedCallback):
979         (searchNextButtonClickedCallback):
980         (searchMenuCheckButtonToggledCallback):
981         (browser_search_bar_init):
982         (browserSearchBarFinalize):
983         (browser_search_bar_class_init):
984         (browser_search_bar_new):
985         (browser_search_bar_add_accelerators):
986         (browser_search_bar_open):
987         (browser_search_bar_close):
988         * MiniBrowser/gtk/BrowserSearchBar.h: Added.
989         * MiniBrowser/gtk/BrowserWindow.c:
990         (webViewEnterFullScreen): Closes new search bar.
991         (webViewLeaveFullScreen): Opens new search bar if previously
992         visible.
993         (searchCallback): Added. Shows and hides the new search bar.
994         (browser_window_init): Added search button to the toolbar.
995         (browserWindowConstructed): Creates the new search bar.
996         * MiniBrowser/gtk/GNUmakefile.am: Added new files to compilation.
997
998 2013-10-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
999
1000         webkit-patch failure-reason fails with UnicodeDecodeError when name has non-ascii characters
1001         https://bugs.webkit.org/show_bug.cgi?id=122552
1002
1003         Reviewed by Darin Adler.
1004
1005         * Scripts/webkitpy/common/checkout/commitinfo.py:
1006         (CommitInfo.blame_string): ensure objects are made into unicode strings, not regular ones that
1007         will cause UnicodeDecodeError for non-ascii characters.
1008
1009 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
1010
1011         Would like a link to dashboard from build.webkit.org main page
1012         https://bugs.webkit.org/show_bug.cgi?id=122577
1013
1014         Reviewed by Tim Hatcher.
1015
1016         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added.
1017
1018 2013-10-09  Brent Fulgham  <bfulgham@apple.com>
1019
1020         [Win] Check for MathML fonts and warn user if they are missing.
1021         https://bugs.webkit.org/show_bug.cgi?id=122568
1022
1023         Reviewed by Tim Horton.
1024
1025         * Scripts/webkitdirs.pm:
1026         (checkRequiredSystemConfig): Use common gperf/bison/flex tests, rather than
1027         Windows-specific code I added previously.
1028         (fontExists): Added
1029         (checkInstalledTools): Add check for MathML fonts.
1030
1031 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
1032
1033         http://build.webkit.org/dashboard/ doesn't link to webkitpy failures
1034         https://bugs.webkit.org/show_bug.cgi?id=122471
1035
1036         Reviewed by Tim Hatcher.
1037
1038         Added links to webkitpy, webkitperl and bindings-tests results.
1039
1040         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1041         (Buildbot.prototype.apiTestResultsURLForIteration):
1042         (Buildbot.prototype.webkitpyTestResultsURLForIteration):
1043         (Buildbot.prototype.webkitperlTestResultsURLForIteration):
1044         (Buildbot.prototype.bindingsTestResultsURLForIteration):
1045         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1046         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1047
1048 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
1049
1050         Move some functions from WebKitBuildbot to Buildbot class.
1051
1052         Suggested by Tim Hatcher.
1053
1054         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1055         (Buildbot.prototype.javascriptTestResultsURLForIteration):
1056         (Buildbot.prototype.apiTestResultsURLForIteration):
1057         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1058         (WebKitBuildbot.prototype.layoutTestResultsURLForIteration):
1059
1060 2013-10-09  Timothy Hatcher  <timothy@apple.com>
1061
1062         Add API tests to the Dashbord page.
1063
1064         https://bugs.webkit.org/show_bug.cgi?id=122283
1065
1066         Reviewed by Timothy Hatcher.
1067
1068         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1069         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1070         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1071         (WebKitBuildbot.prototype.apiTestResultsURLForIteration):
1072
1073 2013-10-09  Timothy Hatcher  <timothy@apple.com>
1074
1075         Attempt to fix faulty Dashboard iteration updating by always rebuilding test result objects.
1076
1077         https://bugs.webkit.org/show_bug.cgi?id=122515
1078
1079         Reviewed by Alexey Proskuryakov.
1080
1081         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1082         (BuildbotIteration.prototype.update):
1083
1084 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
1085
1086         build.webkit.org/dashboard doesn't provide a results link when there issues at multiple steps
1087         https://bugs.webkit.org/show_bug.cgi?id=122573
1088
1089         Reviewed by Tim Hatcher.
1090
1091         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1092         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Provide a URL.
1093
1094         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1095         (Buildbot.prototype.buildPageURLForIteration): Added.
1096
1097 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
1098
1099         http://build.webkit.org/dashboard/ links to a wrong jscore-test results page
1100         https://bugs.webkit.org/show_bug.cgi?id=122569
1101
1102         Reviewed by Tim Hatcher.
1103
1104         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1105         (WebKitBuildbot.prototype.javascriptTestResultsURLForIteration): "actual.html" used
1106         to be produced by the old Mozilla test harness that we don't use any more.
1107
1108 2013-10-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1109
1110         Add GTK 64 bits release to the buildbot dashboard
1111         https://bugs.webkit.org/show_bug.cgi?id=122548
1112
1113         Reviewed by Darin Adler.
1114
1115         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png: Added.
1116         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1117         (WebKitBuildbot): add 64 bits release wk2 and wk1 testers.
1118         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1119         (table.queue-grid tr.platform.linux-gtk img.logo): use the GTK+ logo in its dashboard line.
1120
1121 2013-10-09  Mario Sanchez Prada  <mario.prada@samsung.com>
1122
1123         [ATK] Implement new API in AtkText: atk_text_get_string_at_offset()
1124         https://bugs.webkit.org/show_bug.cgi?id=120638
1125
1126         Reviewed by Gustavo Noronha Silva.
1127
1128         * gtk/jhbuild.modules: Raised ATK and AT-SPI versions to 2.10.0, so we
1129         can check both the old and new APIs to retrieve text at a given offset.
1130
1131 2013-10-08  Alex Christensen  <achristensen@webkit.org>
1132
1133         Improved WinLauncher.
1134         https://bugs.webkit.org/show_bug.cgi?id=122536
1135
1136         Reviewed by Brent Fulgham.
1137
1138         * WinLauncher/PrintWebUIDelegate.cpp:
1139         (PrintWebUIDelegate::runJavaScriptAlertPanelWithMessage): Added.
1140         (PrintWebUIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
1141         * WinLauncher/PrintWebUIDelegate.h: Removed stubs.
1142         * WinLauncher/WinLauncher.cpp:
1143         (createCrashReport): Use the executable name instead of "WinLauncher".
1144         * WinLauncher/WinLauncher.vcxproj/WinLauncher.exe.manifest: Removed.
1145         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link to Wininet.lib.
1146         * win/DLLLauncher/DLLLauncherMain.cpp: Remove VS2005 dependency for WinCairo.
1147
1148 2013-10-08  Mark Lam  <mark.lam@apple.com>
1149
1150         Fix ruby LoadError when running run-javascriptcore-tests.
1151         https://bugs.webkit.org/show_bug.cgi?id=122519.
1152
1153         Reviewed by Mark Hahnenberg.
1154
1155         The scripts needed to explicitly require 'rubygems' for older versions of ruby
1156         (versions before 1.9).
1157
1158         * Scripts/jsc-stress-test-helpers/profiler-test-helper:
1159         * Scripts/run-jsc-stress-tests:
1160
1161 2013-10-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1162
1163         Unreviewed, add my new email to contributors.json.
1164
1165         * Scripts/webkitpy/common/config/contributors.json:
1166
1167 2013-10-08  Brent Fulgham  <bfulgham@apple.com>
1168
1169         Unreviewed build correction.
1170
1171         * Scripts/webkitpy/port/win.py:
1172         (WinPort.write_registry_value): Use string representation of error message to avoid
1173         format conversion problem.
1174
1175 2013-10-07  Brent Fulgham  <bfulgham@apple.com>
1176
1177         [Win] Add checks for proper build and test environment
1178         https://bugs.webkit.org/show_bug.cgi?id=122466
1179
1180         Reviewed by Darin Adler.
1181
1182         This patch makes two changes:
1183         1. Update webkitdirs.pm to check for some common misconfigurations and provide helpful warnings or
1184            error messages so that people know what to fix to get things working.
1185         2. Modify the win.py port to handle the 32-bit and 64-bit test environments, as well as making sure
1186            the various environment settings are properly configured for our test environment.
1187
1188         * Scripts/webkitdirs.pm:
1189         (checkInstalledTools): Add checks for some common Cygwin configuration problems that have
1190         caused problems in the past.
1191         (setupAppleWinEnv):
1192         * Scripts/webkitpy/port/win.py:
1193         (WinPort):
1194         (WinPort.read_registry_string): Parameterize for run architecture and registry root.
1195         (WinPort.write_registry_value): Parameterize registry writing by data type (string versus
1196         DWORD, etc.)
1197         (WinPort.write_registry_string): Revise to call new generic registry write function.
1198         (WinPort.setup_crash_log_saving): Revise for new API
1199         (WinPort.restore_crash_log_saving): Ditto
1200         (WinPort.prevent_error_dialogs): Add new methods to prevent Windows dialogs that block our test
1201         servers from running.
1202         (WinPort.allow_error_dialogs): Ditto.
1203         (WinPort.setup_test_run): Call new API to turn off user input dialogs on program failure.
1204         (WinPort.clean_up_test_run): Call new API to reactivatea user input dialogs after test run finished.
1205
1206 2013-10-08  Philippe Normand  <pnormand@igalia.com>
1207
1208         [GStreamer] enable v4l2 plugin
1209         https://bugs.webkit.org/show_bug.cgi?id=122503
1210
1211         Reviewed by Martin Robinson.
1212
1213         * gtk/jhbuild.modules: Enable the plugin, it now builds fine since
1214         we updated our GStreamer version to 1.0.8.
1215
1216 2013-10-08  Mario Sanchez Prada  <mario.prada@samsung.com>
1217
1218         [ATK] Expose state of aria-invalid as ATK_STATE_INVALID_ENTRY
1219         https://bugs.webkit.org/show_bug.cgi?id=122104
1220
1221         Reviewed by Chris Fleizach.
1222
1223         Updated stringAttributeValue to double check that the exposure of
1224         aria-invalid as a state is consistent with its exposure as a text
1225         attribute as well, when it applies (implementations of AtkText).
1226
1227         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1228         (AccessibilityUIElement::stringAttributeValue): Add double check.
1229         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1230         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
1231
1232 2013-10-07  Filip Pizlo  <fpizlo@apple.com>
1233
1234         run-jsc-stress-tests progress meter should update more quickly on older Rubies
1235         https://bugs.webkit.org/show_bug.cgi?id=122459
1236
1237         Reviewed by Darin Adler.
1238
1239         * Scripts/run-jsc-stress-tests:
1240
1241 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
1242
1243         [buildbot] parse tests that are reported as crashed correctly for GTK+
1244         https://bugs.webkit.org/show_bug.cgi?id=122476
1245
1246         Reviewed by Martin Robinson.
1247
1248         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1249         (RunGtkAPITests.commandComplete): parse the crashed tests output so that is reported
1250         as a failure of the API tests.
1251
1252 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
1253
1254         Unreviewed. Skipping API test that is causing the next one to crash,
1255         see https://bugs.webkit.org/show_bug.cgi?id=121970.
1256
1257         * Scripts/run-gtk-tests:
1258         (TestRunner):
1259
1260 2013-10-07  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1261
1262         [GTK] run-gtk-tests does not distinguish between failure and crashes
1263         https://bugs.webkit.org/show_bug.cgi?id=122135
1264
1265         Reviewed by Martin Robinson.
1266
1267         The GTK+ API test runner does not distinguish between failures and crashes. This change
1268         makes it do that, so it's easier for us to spot the more important/higher priority crash
1269         case.
1270
1271         * Scripts/run-gtk-tests:
1272         (TestRunner._run_test_command): return the exit code instead of a boolean true/false,
1273         so we have more information on how the process ended.
1274         (TestRunner._run_test): check the exit code to distinguish between crashes and failures.
1275         (TestRunner.run_tests): report crashes.
1276
1277 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
1278
1279         [GTK] Missing packages for APT on install-dependencies
1280         https://bugs.webkit.org/show_bug.cgi?id=121555
1281
1282         Reviewed by Martin Robinson.
1283
1284         * gtk/install-dependencies: add packages that are needed for
1285         building WebKit itself and the jhbuild dependencies.
1286
1287 2013-10-07  Anders Carlsson  <andersca@apple.com>
1288
1289         Fix test failures.
1290
1291         * Scripts/webkitpy/port/base.py:
1292         (Port.to.start_helper):
1293         * Scripts/webkitpy/port/mock_drt.py:
1294         (MockDRTPort.start_helper):
1295
1296 2013-10-07  Anders Carlsson  <andersca@apple.com>
1297
1298         Always force discrete mode when running layout tests
1299         https://bugs.webkit.org/show_bug.cgi?id=122465
1300
1301         Reviewed by Tim Horton.
1302
1303         This should speed up WebGL tests and hopefully prevent race conditions that may cause window server crashes from happening.
1304         
1305         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1306         Link with IOKit.
1307
1308         * DumpRenderTree/mac/LayoutTestHelper.m:
1309         (installLayoutTestColorProfile):
1310         Check installColorProfile.
1311
1312         (restoreUserColorProfile):
1313         Check installColorProfile.
1314
1315         (lockDownDiscreteGraphics):
1316         New function to force discrete graphics.
1317
1318         (main):
1319         Add '--install-color-profile' option.
1320
1321         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1322         (Manager._set_up_run):
1323         Always start the helper, but pass self._options.pixel_tests to it.
1324
1325         * Scripts/webkitpy/port/mac.py:
1326         (MacPort.start_helper):
1327         Pass --install-color-profile' to the helper if pixel_tests is true.
1328
1329 2013-10-07  Timothy Hatcher  <timothy@apple.com>
1330
1331         Properly count binding test failures as failures.
1332
1333         Fix the total for multiple failures in different steps too by avoiding undefined.
1334
1335         https://bugs.webkit.org/show_bug.cgi?id=122232
1336
1337         Reviewed by Alexey Proskuryakov.
1338
1339         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1340         (BuildbotTestResults):
1341         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1342         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1343
1344 2013-10-07  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1345
1346         [GTK] Fails to build with jhbuild with newer system glib
1347         https://bugs.webkit.org/show_bug.cgi?id=122132
1348
1349         Reviewed by Martin Robinson.
1350
1351         Newer glib includes new symbols that some system libraries which we depend on, such as pango, have
1352         started relying on. glib is not a dependency that should change test results, and is provided in
1353         jhbuild with the intention of supporting the other bits that do, so using a newer stable release
1354         should not be an issue.
1355
1356         * gtk/jhbuild.modules:
1357
1358 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
1359
1360         run-jsc-stress-tests shouldn't print its goofy progress meter when running on the bots
1361         https://bugs.webkit.org/show_bug.cgi?id=122437
1362
1363         Reviewed by Antoine Quint.
1364
1365         * Scripts/run-jsc-stress-tests:
1366
1367 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
1368
1369         Unreviewed, fix build on old Rubies.
1370
1371         * Scripts/run-jsc-stress-tests:
1372
1373 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
1374
1375         Unified test infrastructure via the jsc shell
1376         https://bugs.webkit.org/show_bug.cgi?id=120696
1377
1378         Reviewed by Oliver Hunt.
1379         
1380         Make run-jsc-stress-tests smart enough to be able to handle different styles of test
1381         output (silent or noisy) and different styles of test failure (just bad exit code,
1382         text diff, filtering for some magical text, etc.). This allows me to get rid of the
1383         layout-test-helper. It also allows me to switch all of the old Mozilla tests to
1384         running in run-jsc-stress-tests.
1385         
1386         Also removes all of the code paths that defended against not having shellwords. Just
1387         install the shellwords gem if you want to run tests.
1388         
1389         Also removes the non-parallel test running code. No reason for it to exist anymore.
1390         
1391         This is a massive increase in test coverage. It uncovered bugs. I fixed two of them
1392         as part of this patch, and left three more as new bugzillas.
1393
1394         * Scripts/create-mozilla-js-test-list: Added.
1395         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
1396         * Scripts/jsc-stress-test-helpers/layout-test-helper: Removed.
1397         * Scripts/run-javascriptcore-tests:
1398         * Scripts/run-jsc-stress-tests:
1399
1400 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
1401
1402         run-jsc-stress-tests should be less verbose
1403         https://bugs.webkit.org/show_bug.cgi?id=122397
1404
1405         Reviewed by Sam Weinig.
1406         
1407         It now just prints something like:
1408         
1409          965/1831 ....
1410         
1411         Where the first number is the number of tests that completed, the second number is the
1412         number of tests total, and the dots are the number of tests running right now - which is
1413         useful towards the end when you're waiting for the last slow tests to finish.
1414         
1415         It will also print out the output from failing tests and it will print a line for skipped
1416         tests (to annoy you into getting them into a shape where they can be unskipped). For
1417         example, for LayoutTests, it will print just the diff, if the test fails. It's cool.
1418
1419         * Scripts/run-jsc-stress-tests:
1420
1421 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
1422
1423         Allow skipping of run-jsc-stress-tests that are configured using yaml files
1424         https://bugs.webkit.org/show_bug.cgi?id=122385
1425
1426         Reviewed by Sam Wieinig.
1427         
1428         Make tests run via YAML be able to do the parse-for-commands trick that allows
1429         us to skip tests and do other custom per-test stuff.
1430
1431         * Scripts/jsc-stress-test-helpers/layout-test-helper:
1432         * Scripts/run-jsc-stress-tests:
1433
1434 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
1435
1436         Unreviewed, fix tests on older Rubies.
1437
1438         * Scripts/run-jsc-stress-tests:
1439
1440 2013-10-05  Anders Carlsson  <andersca@apple.com>
1441
1442         Don't filter the weak symbols.
1443
1444         * Scripts/check-for-weak-vtables-and-externals:
1445
1446 2013-10-04  Filip Pizlo  <fpizlo@apple.com>
1447
1448         Have run-javascriptcore-tests run JS LayoutTests using run-jsc-stress-tests so that it runs in parallel
1449         https://bugs.webkit.org/show_bug.cgi?id=122376
1450
1451         Reviewed by Mark Hahnenberg.
1452
1453         * Scripts/jsc-stress-test-helpers/layout-test-helper: Added.
1454         * Scripts/run-javascriptcore-tests:
1455         (printThingsFound):
1456         * Scripts/run-jsc-stress-tests:
1457
1458 2013-10-04  Filip Pizlo  <fpizlo@apple.com>
1459
1460         It should be even easier to run and debug a failing JSC stress test
1461         https://bugs.webkit.org/show_bug.cgi?id=122337
1462
1463         Reviewed by Oliver Hunt.
1464         
1465         If a test fails, you can now just say:
1466
1467         sh WebKitBuild/Debug/jsc-stress-results/regress/script-tests/emscripten-cube2hash.js.ftl-eager-no-cjit
1468
1469         and get the reproduction. You don't have to set any environment variables like before.
1470         Also if you want to debug the failing test you can now just say:
1471
1472         sh WebKitBuild/Debug/jsc-stress-results/regress/script-tests/emscripten-cube2hash.js.ftl-eager-no-cjit lldb --
1473
1474         Broadly, any arguments passed to the reproduction script are prepended to the command to
1475         run the test. This is sort of quirky and won't work for some tests (for example the
1476         profiler tests run a ruby script that runs some other stuff) but it'll work for most of
1477         them and that's good enough for now.
1478
1479         * Scripts/run-jsc-stress-tests:
1480
1481 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
1482
1483         [Windows] Correct run-path when using 64-bit binaries.
1484
1485         Reviewed by David Kilzer.
1486
1487         * Scripts/webkitdirs.pm:
1488         (determineConfigurationProductDir): If running in 64-bit mode, use the 'bin64'
1489         directory. Otherwise use the existing 'bin32' directory.
1490
1491 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
1492
1493         Teach webkitdirs.pm to honor the --64-bit flag
1494         https://bugs.webkit.org/show_bug.cgi?id=122357
1495
1496         Reviewed by David Kilzer.
1497
1498         * Scripts/webkitdirs.pm:
1499         (argumentsForConfiguration): Modify to check if --64-bit is supplied
1500         by the user.
1501         (findMatchingArguments): Added.
1502         (hasArgument): Added.
1503         (checkForArgumentAndRemoveFromArrayRef): Refactor to use the new
1504         findMatchingArguments subroutine.
1505
1506 2013-10-04  Alexey Proskuryakov  <ap@apple.com>
1507
1508         Update svn-config for new Visual Studio extensions
1509         https://bugs.webkit.org/show_bug.cgi?id=122344
1510
1511         Reviewed by Brent Fulgham.
1512
1513         * svn-config: Add new Visual Studio extensions.
1514
1515 2013-10-04  Alex Christensen  <achristensen@webkit.org>
1516
1517         Made WinLauncher have better error handling, crash reporting, and modifiability.
1518         https://bugs.webkit.org/show_bug.cgi?id=122319
1519
1520         Reviewed by Brent Fulgham.
1521
1522         * WinLauncher/WinLauncher.cpp:
1523         (WinLauncherWebHost::didFailProvisionalLoadWithError):
1524         Don't display the numerous "Cancelled" messages that are obviously from the user.
1525         (createCrashReport): Added.
1526         (dllLauncherEntryPoint):
1527         Made main loop back into while loop and write a crash report if it crashes.
1528         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1529         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
1530         Added WinLauncherReplace.h.
1531         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:
1532         Added linking to DbgHelp.lib.
1533         * WinLauncher/WinLauncherReplace.h:
1534         Added to make modifying WinLauncher behaviour and appearance easy.
1535         (processCrashDump): Added.
1536
1537 2013-10-04  Dirk Pranke  <dpranke@chromium.org>
1538
1539         remove dpranke from webkitpy watchlist
1540         https://bugs.webkit.org/show_bug.cgi?id=122331
1541
1542         Reviewed by Brent Fulgham.
1543
1544         * Scripts/webkitpy/common/config/watchlist:
1545
1546 2013-10-04  Tim Horton  <timothy_horton@apple.com>
1547
1548         [mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommands fail after r156793
1549         https://bugs.webkit.org/show_bug.cgi?id=122299
1550
1551         Reviewed by Beth Dakin.
1552
1553         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1554         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
1555         The last fix didn't work; instead of trying to block, turn off threaded scrolling for all three tests.
1556
1557 2013-10-04  Alexey Proskuryakov  <ap@apple.com>
1558
1559         Watchlist is broken after <http://trac.webkit.org/r156880>
1560
1561         * Scripts/webkitpy/common/config/watchlist: Remove an incorrect change.
1562
1563 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
1564
1565         Remove Qt features from build and test tools
1566         https://bugs.webkit.org/show_bug.cgi?id=122312
1567
1568         Reviewed by Anders Carlsson.
1569
1570         * Scripts/build-dumprendertree:
1571         * Scripts/build-jsc:
1572         * Scripts/build-webkit:
1573         * Scripts/build-webkittestrunner:
1574         * Scripts/old-run-webkit-tests:
1575         (openDumpTool):
1576         (buildPlatformResultHierarchy):
1577         (buildPlatformTestHierarchy):
1578         (readSkippedFiles):
1579         * Scripts/run-launcher:
1580         * Scripts/run-qtwebkit-tests: Removed.
1581         * Scripts/run-webkit-tests:
1582         (useNewRunWebKitTests):
1583         * Scripts/update-webkit:
1584         * Scripts/webkit-build-directory:
1585         * Scripts/webkitdirs.pm:
1586         (argumentsForConfiguration):
1587         (jscProductDir):
1588         (builtDylibPathForName):
1589         (isAppleWebKit):
1590         (launcherPath):
1591         (launcherName):
1592         (checkRequiredSystemConfig):
1593         (setupCygwinEnv):
1594         (copyInspectorFrontendFiles):
1595         (setPathForRunningWebKitApp):
1596         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
1597         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1598         (BaselineOptimizerTest.test_mac_future):
1599         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
1600         (BaselineOptimizerTest.test_common_directory_includes_root):
1601         (BaselineOptimizerTest.test_virtual_ports_filtered):
1602         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1603         (test_parse_reviewer_text):
1604         * Scripts/webkitpy/common/config/watchlist:
1605         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1606         (PortTest.disabled_test_chromium_mac_lion_in_test_shell_mode):
1607         * Scripts/webkitpy/port/base.py:
1608         (Port.__init__):
1609         (Port._port_flag_for_scripts):
1610         (Port._wk2_port_name):
1611         * Scripts/webkitpy/port/builders.py:
1612         * Scripts/webkitpy/port/factory.py:
1613         (platform_options):
1614         (PortFactory):
1615         (PortFactory._default_port):
1616         * Scripts/webkitpy/port/factory_unittest.py:
1617         (FactoryTest.test_gtk):
1618         * Scripts/webkitpy/port/qt.py: Removed.
1619         * Scripts/webkitpy/port/qt_unittest.py: Removed.
1620         * Scripts/webkitpy/style/checker.py:
1621         * Scripts/webkitpy/style/checker_unittest.py:
1622         (GlobalVariablesTest.test_path_rules_specifier):
1623         * Scripts/webkitpy/style/checkers/cmake.py:
1624         (CMakeChecker):
1625         * Scripts/webkitpy/style/checkers/cpp.py:
1626         (_classify_include):
1627         (check_include_line):
1628         (check_identifier_name_in_declaration):
1629         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1630         (OrderOfIncludesTest.test_classify_include):
1631         (WebKitStyleTest.test_names):
1632         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1633         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
1634         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1635         (TestRebaselineTest.test_baseline_directory):
1636         * Scripts/webkitpy/tool/main.py:
1637         (WebKitPatch):
1638
1639 2013-10-03  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1640
1641         Unreviewed. Add myself to some watchlists.
1642
1643         * Scripts/webkitpy/common/config/watchlist:
1644
1645 2013-10-03  Ryosuke Niwa  <rniwa@webkit.org>
1646
1647         Remove Qt builders from the flakiness dashboard.
1648
1649         * TestResultServer/static-dashboards/builders.jsonp:
1650         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1651         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1652         * TestResultServer/static-dashboards/loader_unittests.js:
1653
1654 2013-10-03  Tim Horton  <timothy_horton@apple.com>
1655
1656         [mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommands fail after r156793
1657         https://bugs.webkit.org/show_bug.cgi?id=122299
1658
1659         Reviewed by Beth Dakin.
1660
1661         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
1662         Disable threaded scrolling.
1663
1664         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1665         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
1666         Synchronously wait for the scrolling thread to inform the main thread of the new scroll position.
1667
1668 2013-10-03  Anders Carlsson  <andersca@apple.com>
1669
1670         Use numeric strings in the OS version dictionary
1671         https://bugs.webkit.org/show_bug.cgi?id=122300
1672
1673         Reviewed by Mark Rowe.
1674
1675         * Scripts/webkitpy/common/system/platforminfo.py:
1676         (PlatformInfo._determine_mac_version):
1677
1678 2013-10-03  Alexey Proskuryakov  <ap@apple.com>
1679
1680         Fix LeaksViewer to load leaks results from MountainLion, not Lion.
1681
1682         Rubber-stamped by Tim Horton.
1683
1684         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1685         (LeaksViewer._displayURLPrompt):
1686
1687 2013-10-03  Dan Bernstein  <mitz@apple.com>
1688
1689         REGRESSION (r156811): Objective-C JavaScriptCore API test failing on Mountain Lion bots
1690         https://bugs.webkit.org/show_bug.cgi?id=122260
1691
1692         Reviewed by Alexey Proskuryakov.
1693
1694         For the API to work, the tests need to be compiled with a newer version of the LLVM
1695         compiler. Until the bots are updated to that version, disable the tests on 10.8.
1696
1697         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
1698
1699 2013-10-02  Mario Sanchez Prada  <mario.prada@samsung.com>
1700
1701         [ATK] Expose aria-invalid as a text attribute (not object attribute)
1702         https://bugs.webkit.org/show_bug.cgi?id=122015
1703
1704         Reviewed by Chris Fleizach.
1705
1706         Adapted DRT and WKTR to check the exposure of the aria-invalid
1707         attribute as a text attribute, instead of an object attribute.
1708
1709         Also, done some refactoring of the code to try to keep things
1710         simpler and more coherent, by defining new helper functions,
1711         simplifying code, moving static variables and functions into
1712         unnammed namespaces and so on, without altering the logic other
1713         than for checking the text attribute for aria-invalid.
1714
1715         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1716         (coreAttributeToAtkAttribute): Consider 'invalid' as the name of
1717         the attribute exposed by the ATK wrapper, not 'aria-invalid'.
1718         Also, never return an empty string if not falling through any of
1719         the cases checked here, and return the original attribute instead.
1720         (atkAttributeValueToCoreAttributeValue): New helper function to
1721         match the attributes values returned by the ATK wrapper with the
1722         values expected by the layout tests. Moved the mappings for the
1723         values of AXSortDirection here as well.
1724         (getAttributeSet): New helper function to retrieve a list of
1725         attributes (an AtkAttributeSet) from an AtkObject using the right
1726         API depending on whether we want the object attributes or the text
1727         attributes (in case the object implements AtkText).
1728         (getAttributeSetValueForId): Simplified by using getAttributeSet
1729         and atkAttributeValueToCoreAttributeValue. Also, added a new
1730         parameter to indicater whether we are interested in object
1731         attributes or text attributes.
1732         (getAtkAttributeSetAsString): Ditto.
1733         (attributesOfElement): Updated to pass the new required parameter
1734         to getAtkAttributeSetAsString, indicating that we want the object
1735         attributes in this case, for backwards compatibility.
1736         (indexRangeInTable): Moved up in the file into the unnammed namespace.
1737         (alterCurrentValue): Ditto.
1738         (AccessibilityUIElement::stringAttributeValue): After moving most
1739         of the code here to the new helper functions, simplified it by
1740         just checking whether the required attribute is provided as an
1741         object attribute or, if that's not the case, as a text attribute.
1742         (AccessibilityUIElement::isAttributeSupported): Ditto.
1743         (AccessibilityUIElement::intValue): Updated to pass the new
1744         required parameter to getAttributeSetValueForId, indicating that
1745         we want the object attributes in this case.
1746         (AccessibilityUIElement::hasPopup): Ditto.
1747
1748         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1749         (WTR::coreAttributeToAtkAttribute): Same changes than for DRT.
1750         (WTR::atkAttributeValueToCoreAttributeValue): Ditto.
1751         (WTR::getAttributeSet): Ditto.
1752         (WTR::getAttributeSetValueForId): Ditto.
1753         (WTR::getAtkAttributeSetAsString): Ditto.
1754         (WTR::attributesOfElement): Ditto.
1755         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
1756         (WTR::AccessibilityUIElement::isAttributeSupported): Ditto.
1757         (WTR::AccessibilityUIElement::intValue): Ditto.
1758         (WTR::AccessibilityUIElement::hasPopup): Ditto.
1759
1760 2013-10-02  Ryosuke Niwa  <rniwa@webkit.org>
1761
1762         EWS build fix after the Qt EWS removal.
1763
1764         * QueueStatusServer/model/attachment.py:
1765         (Attachment._calculate_queue_positions):
1766
1767 2013-10-02  Anders Carlsson  <andersca@apple.com>
1768
1769         Remove Qt code from Tools/
1770         https://bugs.webkit.org/show_bug.cgi?id=122227
1771
1772         Reviewed by Andreas Kling.
1773
1774         * DumpRenderTree/WorkQueue.cpp:
1775         * DumpRenderTree/blackberry/src.pro: Removed.
1776         * DumpRenderTree/qt/DumpRenderTree.pro: Removed.
1777         * DumpRenderTree/qt/DumpRenderTree.qrc: Removed.
1778         * DumpRenderTree/qt/DumpRenderTreeMain.cpp: Removed.
1779         * DumpRenderTree/qt/DumpRenderTreeQt.cpp: Removed.
1780         * DumpRenderTree/qt/DumpRenderTreeQt.h: Removed.
1781         * DumpRenderTree/qt/EventSenderQt.cpp: Removed.
1782         * DumpRenderTree/qt/EventSenderQt.h: Removed.
1783         * DumpRenderTree/qt/GCControllerQt.cpp: Removed.
1784         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Removed.
1785         * DumpRenderTree/qt/TestRunnerQt.cpp: Removed.
1786         * DumpRenderTree/qt/TestRunnerQt.h: Removed.
1787         * DumpRenderTree/qt/TextInputControllerQt.cpp: Removed.
1788         * DumpRenderTree/qt/TextInputControllerQt.h: Removed.
1789         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Removed.
1790         * DumpRenderTree/qt/WorkQueueItemQt.h: Removed.
1791         * DumpRenderTree/qt/fonts/AHEM____.TTF: Removed.
1792         * DumpRenderTree/qt/resources/user.css: Removed.
1793         * DumpRenderTree/qt/testplugin.cpp: Removed.
1794         * DumpRenderTree/qt/testplugin.h: Removed.
1795         * ImageDiff/ImageDiff.pro: Removed.
1796         * ImageDiff/qt/ImageDiff.cpp: Removed.
1797         * MiniBrowser/qt/BrowserWindow.cpp: Removed.
1798         * MiniBrowser/qt/BrowserWindow.h: Removed.
1799         * MiniBrowser/qt/MiniBrowser.pro: Removed.
1800         * MiniBrowser/qt/MiniBrowser.qrc: Removed.
1801         * MiniBrowser/qt/MiniBrowserApplication.cpp: Removed.
1802         * MiniBrowser/qt/MiniBrowserApplication.h: Removed.
1803         * MiniBrowser/qt/UrlLoader.cpp: Removed.
1804         * MiniBrowser/qt/UrlLoader.h: Removed.
1805         * MiniBrowser/qt/icons/checkbox_checked.png: Removed.
1806         * MiniBrowser/qt/icons/checkbox_unchecked.png: Removed.
1807         * MiniBrowser/qt/icons/contents_width.png: Removed.
1808         * MiniBrowser/qt/icons/favicon.png: Removed.
1809         * MiniBrowser/qt/icons/find.png: Removed.
1810         * MiniBrowser/qt/icons/folder.png: Removed.
1811         * MiniBrowser/qt/icons/info.png: Removed.
1812         * MiniBrowser/qt/icons/next.png: Removed.
1813         * MiniBrowser/qt/icons/plus.png: Removed.
1814         * MiniBrowser/qt/icons/previous.png: Removed.
1815         * MiniBrowser/qt/icons/refresh.png: Removed.
1816         * MiniBrowser/qt/icons/stop.png: Removed.
1817         * MiniBrowser/qt/icons/titlebar.png: Removed.
1818         * MiniBrowser/qt/icons/touch.png: Removed.
1819         * MiniBrowser/qt/icons/touchpoint.png: Removed.
1820         * MiniBrowser/qt/icons/up.png: Removed.
1821         * MiniBrowser/qt/js/MultiSelect.js: Removed.
1822         * MiniBrowser/qt/main.cpp: Removed.
1823         * MiniBrowser/qt/qml/AlertDialog.qml: Removed.
1824         * MiniBrowser/qt/qml/AuthenticationDialog.qml: Removed.
1825         * MiniBrowser/qt/qml/BrowserWindow.qml: Removed.
1826         * MiniBrowser/qt/qml/CheckBox.qml: Removed.
1827         * MiniBrowser/qt/qml/ColorChooser.qml: Removed.
1828         * MiniBrowser/qt/qml/ConfirmDialog.qml: Removed.
1829         * MiniBrowser/qt/qml/Dialog.qml: Removed.
1830         * MiniBrowser/qt/qml/DialogButton.qml: Removed.
1831         * MiniBrowser/qt/qml/DialogLineInput.qml: Removed.
1832         * MiniBrowser/qt/qml/FilePicker.qml: Removed.
1833         * MiniBrowser/qt/qml/ItemSelector.qml: Removed.
1834         * MiniBrowser/qt/qml/MockTouchPoint.qml: Removed.
1835         * MiniBrowser/qt/qml/PromptDialog.qml: Removed.
1836         * MiniBrowser/qt/qml/ProxyAuthenticationDialog.qml: Removed.
1837         * MiniBrowser/qt/qml/ScrollIndicator.qml: Removed.
1838         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Removed.
1839         * MiniBrowser/qt/raw/DerivedSources.pri: Removed.
1840         * MiniBrowser/qt/raw/MiniBrowserRaw.pro: Removed.
1841         * MiniBrowser/qt/raw/Target.pri: Removed.
1842         * MiniBrowser/qt/raw/View.cpp: Removed.
1843         * MiniBrowser/qt/raw/View.h: Removed.
1844         * MiniBrowser/qt/utils.cpp: Removed.
1845         * MiniBrowser/qt/utils.h: Removed.
1846         * QtTestBrowser/QtTestBrowser.pro: Removed.
1847         * QtTestBrowser/QtTestBrowser.qrc: Removed.
1848         * QtTestBrowser/cookiejar.cpp: Removed.
1849         * QtTestBrowser/cookiejar.h: Removed.
1850         * QtTestBrowser/favicon.png: Removed.
1851         * QtTestBrowser/fpstimer.cpp: Removed.
1852         * QtTestBrowser/fpstimer.h: Removed.
1853         * QtTestBrowser/launcherwindow.cpp: Removed.
1854         * QtTestBrowser/launcherwindow.h: Removed.
1855         * QtTestBrowser/locationedit.cpp: Removed.
1856         * QtTestBrowser/locationedit.h: Removed.
1857         * QtTestBrowser/mainwindow.cpp: Removed.
1858         * QtTestBrowser/mainwindow.h: Removed.
1859         * QtTestBrowser/qttestbrowser.cpp: Removed.
1860         * QtTestBrowser/urlloader.cpp: Removed.
1861         * QtTestBrowser/urlloader.h: Removed.
1862         * QtTestBrowser/useragentlist.txt: Removed.
1863         * QtTestBrowser/utils.cpp: Removed.
1864         * QtTestBrowser/utils.h: Removed.
1865         * QtTestBrowser/webinspector.h: Removed.
1866         * QtTestBrowser/webpage.cpp: Removed.
1867         * QtTestBrowser/webpage.h: Removed.
1868         * QtTestBrowser/webview.cpp: Removed.
1869         * QtTestBrowser/webview.h: Removed.
1870         * TestWebKitAPI/DerivedSources.pri: Removed.
1871         * TestWebKitAPI/InjectedBundle.pri: Removed.
1872         * TestWebKitAPI/PlatformWebView.h:
1873         * TestWebKitAPI/TestWebKitAPI.pri: Removed.
1874         * TestWebKitAPI/TestWebKitAPI.pro: Removed.
1875         * TestWebKitAPI/Tests.pri: Removed.
1876         * TestWebKitAPI/Tests/JavaScriptCore/JavaScriptCore.pro: Removed.
1877         * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp:
1878         * TestWebKitAPI/Tests/WTF/WTF.pro: Removed.
1879         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro: Removed.
1880         * TestWebKitAPI/qt/InjectedBundleControllerQt.cpp: Removed.
1881         * TestWebKitAPI/qt/PlatformUtilitiesQt.cpp: Removed.
1882         * TestWebKitAPI/qt/PlatformWebViewQt.cpp: Removed.
1883         * TestWebKitAPI/qt/main.cpp: Removed.
1884         * Tools.pro: Removed.
1885         * WebKitTestRunner/DerivedSources.pri: Removed.
1886         * WebKitTestRunner/EventSenderProxy.h:
1887         * WebKitTestRunner/InjectedBundle/DerivedSources.pri: Removed.
1888         * WebKitTestRunner/InjectedBundle/InjectedBundle.pro: Removed.
1889         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1890         (WTR::InjectedBundlePage::resetAfterTest):
1891         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
1892         (WTR::InjectedBundlePage::didClearWindowForFrame):
1893         * WebKitTestRunner/InjectedBundle/Target.pri: Removed.
1894         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1895         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: Removed.
1896         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp: Removed.
1897         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp: Removed.
1898         * WebKitTestRunner/PlatformWebView.h:
1899         * WebKitTestRunner/Target.pri: Removed.
1900         * WebKitTestRunner/TestController.cpp:
1901         (WTR::TestController::resetStateToConsistentValues):
1902         * WebKitTestRunner/TestController.h:
1903         * WebKitTestRunner/WebKitTestRunner.pro: Removed.
1904         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Removed.
1905         * WebKitTestRunner/qt/PlatformWebViewQt.cpp: Removed.
1906         * WebKitTestRunner/qt/TestControllerQt.cpp: Removed.
1907         * WebKitTestRunner/qt/TestInvocationQt.cpp: Removed.
1908         * WebKitTestRunner/qt/WebKitTestRunner.qrc: Removed.
1909         * WebKitTestRunner/qt/main.cpp: Removed.
1910         * WebKitTestRunner/qt/resources/user.css: Removed.
1911         * qmake/.qmake.cache: Removed.
1912         * qmake/.qmake.conf: Removed.
1913         * qmake/README: Removed.
1914         * qmake/config.tests/README: Removed.
1915         * qmake/config.tests/fontconfig/fontconfig.cpp: Removed.
1916         * qmake/config.tests/fontconfig/fontconfig.pro: Removed.
1917         * qmake/config.tests/gccdepends/empty.cpp: Removed.
1918         * qmake/config.tests/gccdepends/gccdepends.pro: Removed.
1919         * qmake/config.tests/glx/glx.cpp: Removed.
1920         * qmake/config.tests/glx/glx.pro: Removed.
1921         * qmake/config.tests/gnuld/gnuld.pro: Removed.
1922         * qmake/config.tests/gnuld/main.cpp: Removed.
1923         * qmake/config.tests/libXcomposite/libXcomposite.cpp: Removed.
1924         * qmake/config.tests/libXcomposite/libXcomposite.pro: Removed.
1925         * qmake/config.tests/libXrender/libXrender.cpp: Removed.
1926         * qmake/config.tests/libXrender/libXrender.pro: Removed.
1927         * qmake/config.tests/libwebp/libwebp.cpp: Removed.
1928         * qmake/config.tests/libwebp/libwebp.pro: Removed.
1929         * qmake/config.tests/libxml2/libxml2.cpp: Removed.
1930         * qmake/config.tests/libxml2/libxml2.pro: Removed.
1931         * qmake/config.tests/libxslt/libxslt.cpp: Removed.
1932         * qmake/config.tests/libxslt/libxslt.pro: Removed.
1933         * qmake/config.tests/libzlib/libzlib.cpp: Removed.
1934         * qmake/config.tests/libzlib/libzlib.pro: Removed.
1935         * qmake/dump-features.pl: Removed.
1936         * qmake/mkspecs/features/configure.prf: Removed.
1937         * qmake/mkspecs/features/default_post.prf: Removed.
1938         * qmake/mkspecs/features/default_pre.prf: Removed.
1939         * qmake/mkspecs/features/features.prf: Removed.
1940         * qmake/mkspecs/features/features.pri: Removed.
1941         * qmake/mkspecs/features/force_static_libs_as_shared.prf: Removed.
1942         * qmake/mkspecs/features/functions.prf: Removed.
1943         * qmake/mkspecs/features/gprof.prf: Removed.
1944         * qmake/mkspecs/features/mac/default_post.prf: Removed.
1945         * qmake/mkspecs/features/mac/default_pre.prf: Removed.
1946         * qmake/mkspecs/features/minimal_qt.prf: Removed.
1947         * qmake/mkspecs/features/production_build.prf: Removed.
1948         * qmake/mkspecs/features/rpath.prf: Removed.
1949         * qmake/mkspecs/features/unix/default_post.prf: Removed.
1950         * qmake/mkspecs/features/unix/default_pre.prf: Removed.
1951         * qmake/mkspecs/features/unix/icc.prf: Removed.
1952         * qmake/mkspecs/features/use_all_in_one_files.prf: Removed.
1953         * qmake/mkspecs/features/valgrind.prf: Removed.
1954         * qmake/mkspecs/features/webkit_modules.prf: Removed.
1955         * qmake/mkspecs/features/win32/default_post.prf: Removed.
1956         * qmake/mkspecs/features/win32/default_pre.prf: Removed.
1957         * qmake/mkspecs/modules/angle.prf: Removed.
1958         * qmake/mkspecs/modules/javascriptcore.prf: Removed.
1959         * qmake/mkspecs/modules/webcore.prf: Removed.
1960         * qmake/mkspecs/modules/webkit1.prf: Removed.
1961         * qmake/mkspecs/modules/webkit2.prf: Removed.
1962         * qmake/mkspecs/modules/wtf.prf: Removed.
1963
1964 2013-10-02  Tim Horton  <timothy_horton@apple.com>
1965
1966         [mac] Stop using DrawingAreaImpl on PLATFORM(MAC) 
1967         https://bugs.webkit.org/show_bug.cgi?id=121859
1968         <rdar://problem/15069359>
1969
1970         Reviewed by Anders Carlsson.
1971
1972         * WebKitTestRunner/TestInvocation.cpp:
1973         (WTR::shouldUseThreadedScrolling):
1974         (WTR::updateThreadedScrollingForCurrentTest):
1975         (WTR::TestInvocation::invoke):
1976         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1977         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useThreadedScrolling:]):
1978         (WTR::PlatformWebView::PlatformWebView):
1979         (WTR::PlatformWebView::viewSupportsOptions):
1980         Rename the tiled drawing switch to threaded scrolling, since that's really
1981         all it switches now that we use tiled drawing everywhere.
1982
1983         Use an unbuffered window, as well, to avoid snapshotting issues on some platforms
1984         and to more closely match the case we're interested in testing.
1985
1986 2013-10-02  Anders Carlsson  <andersca@apple.com>
1987
1988         Move AHEM____.TTF from qt/fonts/ to fonts/.
1989
1990         Rubber-stamped by Andreas Kling.
1991
1992         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1993         * DumpRenderTree/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/qt/fonts/AHEM____.TTF.
1994
1995 2013-10-02  Ádám Kallai  <kadam@inf.u-szeged.hu>
1996
1997         Remove Qt bots and EWS from trunk.
1998         https://bugs.webkit.org/show_bug.cgi?id=122210.
1999
2000         Reviewed by Allan Sandfeld Jensen.
2001
2002         Remove Qt buil dbots.
2003
2004         * BuildSlaveSupport/build.webkit.org-config/config.json:
2005         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2006         (appendCustomBuildFlags):
2007         (RunGtkAPITests.getText2):
2008         (Factory.__init__):
2009         (TestFactory.__init__):
2010         (BuildAndTestFactory.__init__):
2011         (loadBuilderConfig):
2012         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2013
2014 2013-10-02  Ádám Kallai  <kadam@inf.u-szeged.hu>
2015
2016         Remove Qt bots and EWS from trunk.
2017         https://bugs.webkit.org/show_bug.cgi?id=122210.
2018
2019         Reviewed by Allan Sandfeld Jensen.
2020
2021         Remove Qt EWS bots.
2022
2023         * QueueStatusServer/config/queues.py:
2024         * Scripts/webkitpy/common/config/ews.json:
2025
2026 2013-10-01  Timothy Hatcher  <timothy@apple.com>
2027
2028         Fix singular labels for test failures.
2029
2030         https://bugs.webkit.org/show_bug.cgi?id=122200
2031
2032         Reviewed by Joseph Pecoraro.
2033
2034         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2035         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2036
2037 2013-10-01  Timothy Hatcher  <timothy@apple.com>
2038
2039         Don't keep appending iterations each time the queue updates.
2040
2041         https://bugs.webkit.org/show_bug.cgi?id=122198
2042
2043         Reviewed by Joseph Pecoraro.
2044
2045         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2046         (BuildbotQueue.prototype.update):
2047
2048 2013-10-01  Timothy Hatcher  <timothy@apple.com>
2049
2050         Properly sort iterations in the Dashboard by revision for out-of-order queues.
2051
2052         https://bugs.webkit.org/show_bug.cgi?id=122196
2053
2054         Reviewed by Brent Fulgham.
2055
2056         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2057         (BuildbotIteration):
2058         (BuildbotIteration.prototype.update):
2059         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2060         (BuildbotQueue.prototype.update):
2061         (BuildbotQueue.prototype.sortIterations):
2062
2063 2013-10-01  Timothy Hatcher  <timothy@apple.com>
2064
2065         Fix some exceptions seen in the Buildbot Dashboard when looking at unloaded iterations.
2066
2067         Also fix some URLs to not have extras slashes and add a page title.
2068
2069         https://bugs.webkit.org/show_bug.cgi?id=122192
2070
2071         Reviewed by Joseph Pecoraro.
2072
2073         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2074         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2075         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2076         (WebKitBuildbot.prototype.buildLogURLForIteration):
2077         (WebKitBuildbot.prototype.layoutTestResultsURLForIteration):
2078         (WebKitBuildbot.prototype.javascriptTestResultsURLForIteration):
2079         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
2080
2081 2013-10-01  Alexey Proskuryakov  <ap@apple.com>
2082
2083         [Mac] Set NSApplication current event while sending events directly to views
2084         https://bugs.webkit.org/show_bug.cgi?id=122179
2085
2086         Reviewed by Darin Adler.
2087
2088         DumpRenderTree and WebKitTestRunner send events directly to WebHMTLView or WKView,
2089         which doesn't update [NSApp currentEvent]. But there are many places in WebKit that
2090         use the current event.
2091
2092         * DumpRenderTree/mac/EventSendingController.mm:
2093         (-[EventSendingController mouseDown:withModifiers:]):
2094         (-[EventSendingController mouseUp:withModifiers:]):
2095         (-[EventSendingController mouseMoveToX:Y:]):
2096         (-[EventSendingController mouseScrollByX:andY:continuously:]):
2097         (-[EventSendingController contextClick]):
2098         (-[EventSendingController keyDown:withModifiers:withLocation:]):
2099         * WebKitTestRunner/mac/EventSenderProxy.mm:
2100         (WTR::EventSenderProxy::mouseDown):
2101         (WTR::EventSenderProxy::mouseUp):
2102         (WTR::EventSenderProxy::mouseMoveTo):
2103         (WTR::EventSenderProxy::keyDown):
2104         (WTR::EventSenderProxy::mouseScrollBy):
2105         Update the current event. We were already using the SPI in WebKit.
2106
2107 2013-10-01  Joseph Pecoraro  <pecoraro@apple.com>
2108
2109         Buildbot Dashboard: Fix JSHint issue: 'perlTestResults' used out of scope.
2110         https://bugs.webkit.org/show_bug.cgi?id=122183
2111
2112         Reviewed by Timothy Hatcher.
2113
2114         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2115         (BuildbotIteration.prototype.update):
2116
2117 2013-10-01  Timothy Hatcher  <timothy@apple.com>
2118
2119         Tweaks to the Buildbot Dashboard
2120
2121         https://bugs.webkit.org/show_bug.cgi?id=122169
2122
2123         Reviewed by Alexey Proskuryakov.
2124
2125         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2126         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
2127         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2128         (BuildbotQueueView.prototype.revisionLinksForIteration):
2129         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2130         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2131         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Added.
2132         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2133         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2134         (WebKitBuildbot.prototype.buildLogURLForIteration):
2135         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
2136
2137 2013-10-01  Commit Queue  <commit-queue@webkit.org>
2138
2139         Unreviewed, rolling out r156725.
2140         http://trac.webkit.org/changeset/156725
2141         https://bugs.webkit.org/show_bug.cgi?id=122176
2142
2143         broke all the mismatch tests again (Requested by thorton on
2144         #webkit).
2145
2146         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2147         (WTR::PlatformWebView::PlatformWebView):
2148
2149 2013-10-01  Alex Christensen  <achristensen@webkit.org>
2150
2151         Implemented createWebViewWithRequest in WinLauncher.
2152         https://bugs.webkit.org/show_bug.cgi?id=122069
2153
2154         Reviewed by Brent Fulgham.
2155
2156         * WinLauncher/PrintWebUIDelegate.cpp:
2157         (PrintWebUIDelegate::createWebViewWithRequest): Added.
2158         * WinLauncher/PrintWebUIDelegate.h:
2159         Removed createWebViewWithRequest stub.
2160
2161 2013-10-01  Tim Horton  <timothy_horton@apple.com>
2162
2163         [wk2] WebKitTestRunner's window snapshots are blank with tiled drawing
2164         https://bugs.webkit.org/show_bug.cgi?id=122006
2165         <rdar://problem/15095197>
2166
2167         Reviewed by Dean Jackson.
2168
2169         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2170         (WTR::PlatformWebView::PlatformWebView):
2171         Layer-back the root view in WebKitTestRunner's window, to work around a bug
2172         where the window server snapshot API returns blank snapshots.
2173
2174         Re-landing after r156724, this should not break everything now.
2175
2176 2013-10-01  Tim Horton  <timothy_horton@apple.com>
2177
2178         [mac] 1x emulation on Retina hardware shouldn't use SPI
2179         https://bugs.webkit.org/show_bug.cgi?id=122152
2180         <rdar://problem/15119384>
2181
2182         Reviewed by Anders Carlsson.
2183
2184         * DumpRenderTree/mac/DumpRenderTree.mm:
2185         (createWebViewAndOffscreenWindow):
2186         (main):
2187         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2188         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2189         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2190         (WTR::PlatformWebView::PlatformWebView):
2191         * WebKitTestRunner/mac/main.mm:
2192         (main):
2193         Register for AppleMagnifiedMode instead of using _setWindowResolution:displayIfChanged:.
2194
2195 2013-09-30  Sam Weinig  <sam@webkit.org>
2196
2197         check-webkit-style should not warn about use of C++11 “>>”  instead of “> >"
2198         https://bugs.webkit.org/show_bug.cgi?id=116474
2199
2200         Reviewed by Ryosuke Niwa.
2201
2202         * Scripts/webkitpy/style/checkers/cpp.py:
2203         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2204
2205 2013-09-30  Sam Weinig  <sam@webkit.org>
2206
2207         Remove support for DOMFileSystem
2208         https://bugs.webkit.org/show_bug.cgi?id=122137
2209
2210         Reviewed by Anders Carlsson.
2211
2212         * Scripts/webkitperl/FeatureList.pm:
2213         * Scripts/webkitpy/style/checkers/cpp.py:
2214         (check_spacing):
2215         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2216         (CppStyleTest.test_spacing_for_binary_ops):
2217         * qmake/mkspecs/features/features.pri:
2218
2219 2013-09-30  Mark Rowe  <mrowe@apple.com>
2220
2221         More build fixage for builds with SDKs.
2222
2223         * WebKitTestRunner/Configurations/Base.xcconfig:
2224         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
2225
2226 2013-09-30  Timothy Hatcher  <timothy@apple.com>
2227
2228         Add initial version of a new Buildbot dashboard view.
2229
2230         https://bugs.webkit.org/show_bug.cgi?id=122131
2231
2232         Reviewed by Alexey Proskuryakov.
2233
2234         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion.png: Added.
2235         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion@2x.png: Added.
2236         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks.png: Added.
2237         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks@2x.png: Added.
2238         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: Added.
2239         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: Added.
2240         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing.png: Added.
2241         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing@2x.png: Added.
2242         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7.png: Added.
2243         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7@2x.png: Added.
2244         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8.png: Added.
2245         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8@2x.png: Added.
2246         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP.png: Added.
2247         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP@2x.png: Added.
2248         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BaseObject.js: Added.
2249         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js: Added.
2250         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js: Added.
2251         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Added.
2252         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js: Added.
2253         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: Added.
2254         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js: Added.
2255         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js: Added.
2256         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Added.
2257         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js: Added.
2258         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js: Added.
2259         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: Added.
2260         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotBuilderQueueView.css: Added.
2261         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css: Added.
2262         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotTesterQueueView.css: Added.
2263         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: Added.
2264         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css: Added.
2265         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added.
2266
2267 2013-09-30  Benjamin Poulain  <benjamin@webkit.org>
2268
2269         Remove the code guarded by STYLE_SCOPED
2270         https://bugs.webkit.org/show_bug.cgi?id=122123
2271
2272         Reviewed by Anders Carlsson.
2273
2274         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2275         (resetDefaultsToConsistentValues):
2276         * Scripts/webkitperl/FeatureList.pm:
2277         * qmake/mkspecs/features/features.pri:
2278
2279 2013-09-30  Mark Rowe  <mrowe@apple.com>
2280
2281         Fix the build when building against an SDK.
2282
2283         Xcode helpfully prepends $(SDKROOT) to the paths in FRAMEWORK_SEARCH_PATHS when generating
2284         the compiler command lines. It can't know to do this for the system framework search paths
2285         we add manually via OTHER_CFLAGS though, so we need to prefix them with $(SDKROOT) ourself.
2286
2287         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
2288         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
2289
2290 2013-09-30  Brent Fulgham  <bfulgham@apple.com>
2291
2292         [Windows] Unreviewed test fix. Prevent crash when changing URL paths during testing.
2293
2294         A shared BSTR value (_bstr_t) was being reallocated outside the smart pointer, causing
2295         it to be double-freed.
2296
2297         * WinLauncher/WinLauncher.cpp:
2298         (EditProc): Be explicit about type passed to loadURL.
2299         (loadURL): Create a shallow copy of the BSTR so we only allocate memory if needed. Use _bstr_t so
2300         that reallocating the BSTR is done with the knowledge of the smart pointer.
2301
2302 2013-09-30  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2303
2304         [Qt] Fix force_static_libs_as_shared in WebKit2
2305         https://bugs.webkit.org/show_bug.cgi?id=121961
2306
2307         Reviewed by Csaba Osztrogonác.
2308
2309         Get rid of the unused WebKit2QML library
2310
2311         * qmake/mkspecs/features/webkit_modules.prf:
2312         * qmake/mkspecs/modules/webkit2qml.prf: Removed.
2313
2314 2013-09-30  Krzysztof Wolanski  <k.wolanski@samsung.com>
2315
2316         [EFL] Fix incorrect click counting in EventSenderProxy
2317         https://bugs.webkit.org/show_bug.cgi?id=122098
2318
2319         Reviewed by Gyuyoung Kim.
2320
2321         Previously used two types of recording time, which conflicted with each other.
2322
2323         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
2324         (WTR::EventSenderProxy::mouseUp):
2325
2326 2013-09-30  Zan Dobersek  <zdobersek@igalia.com>
2327
2328         [webkitpy] Make the Xvfb screen depth overridable
2329         https://bugs.webkit.org/show_bug.cgi?id=122089
2330
2331         Reviewed by Gyuyoung Kim.
2332
2333         Make the Xvfb screen depth overridable by checking if the XVFB_SCREEN_DEPTH environment variable
2334         was set. The default value that's used if the variable wasn't set is 24.
2335
2336         * Scripts/webkitpy/port/xvfbdriver.py:
2337         (XvfbDriver._xvfb_screen_depth):
2338         (XvfbDriver._start):
2339         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
2340         (XvfbDriverTest.make_driver):
2341         (XvfbDriverTest.test_start_no_pixel_tests):
2342         (XvfbDriverTest.test_start_pixel_tests):
2343         (XvfbDriverTest.test_start_arbitrary_worker_number):
2344         (XvfbDriverTest.test_next_free_display):
2345         (XvfbDriverTest.test_start_next_worker):
2346
2347 2013-09-29  Mark Rowe  <mrowe@apple.com>
2348
2349         Fix the Lion build.
2350
2351         Ensure that C++ and Objective-C++ files build with the right compiler flags.
2352
2353         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
2354         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
2355
2356 2013-09-28  Mark Rowe  <mrowe@apple.com>
2357
2358         Fix some failures with newer versions of clang.
2359
2360         Some CoreGraphics headers generate warnings under newer versions of clang. Since they're system headers the warnings would
2361         usually be suppressed, but we're adding the frameworks to the non-system framework search path so they're no longer treated
2362         as system headers. We address this by removing the system paths from FRAMEWORK_SEARCH_PATHS and using the -iframework compiler
2363         flag in OTHER_CFLAGS to add the paths to the system framework search path. We have to set OTHER_CFLAGS at the target level
2364         in order for it to coexist with the ASAN-related OTHER_CFLAGS that's set in DebugRelease.xcconfig.
2365
2366         Reviewed by Dan Bernstein.
2367
2368         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2369         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: A new .xcconfig file that's included by all target-specific .xcconfig files.
2370         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2371         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2372         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
2373         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
2374         * WebKitTestRunner/Configurations/Base.xcconfig:
2375         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: A new .xcconfig file that's included by all target-specific .xcconfig files.
2376         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2377         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
2378         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2379
2380 2013-09-27  Commit Queue  <commit-queue@webkit.org>
2381
2382         Unreviewed, rolling out r156569.
2383         http://trac.webkit.org/changeset/156569
2384         https://bugs.webkit.org/show_bug.cgi?id=122035
2385
2386         broke a lot of mismatch tests (Requested by thorton on
2387         #webkit).
2388
2389         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2390         (WTR::PlatformWebView::PlatformWebView):
2391
2392 2013-09-27  Alexey Proskuryakov  <ap@apple.com>
2393
2394         Don't retry failures on Apple MountainLion Release WK1 tester
2395         https://bugs.webkit.org/show_bug.cgi?id=122026
2396
2397         Reviewed by Mark Rowe.
2398
2399         * BuildSlaveSupport/build.webkit.org-config/config.json: Added --no-retry-failures
2400         on this bot.
2401
2402 2013-09-27  Alexey Proskuryakov  <ap@apple.com>
2403
2404         Don't hardcode builder specific configuration in buildbot master.cfg
2405         https://bugs.webkit.org/show_bug.cgi?id=122023
2406
2407         Reviewed by Mark Rowe.
2408
2409         * BuildSlaveSupport/build.webkit.org-config/config.json: Added an additionalArguments
2410         property to Qt Mountain Lion Release, making it run pixel tests.
2411
2412         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2413         (RunWebKitTests.start): Use additionalArguments.
2414         (RunWebKit2Tests.start): Don't hardcode individual bot behavior here.
2415
2416 2013-09-27  Tim Horton  <timothy_horton@apple.com>
2417
2418         [wk2] WebKitTestRunner's window snapshots are blank with tiled drawing
2419         https://bugs.webkit.org/show_bug.cgi?id=122006
2420         <rdar://problem/15095197>
2421
2422         Reviewed by Dean Jackson.
2423
2424         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2425         (WTR::PlatformWebView::PlatformWebView):
2426         Layer-back the root view in WebKitTestRunner's window, to work around a bug
2427         where the window server snapshot API returns blank snapshots.
2428
2429 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
2430
2431         [GTK] GTK does not expose heading level correctly. Was: accessibility/heading-level.html is failing
2432         https://bugs.webkit.org/show_bug.cgi?id=106924
2433
2434         Reviewed by Chris Fleizach.
2435
2436         Consider headings levels as values to be returned in intValue()
2437         both in DRT and WKTR, so we can share more tests with other ports.
2438
2439         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2440         (AccessibilityUIElement::intValue): Consider headings too.
2441         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2442         (WTR::AccessibilityUIElement::intValue): Ditto.
2443
2444 2013-09-26  Darin Adler  <darin@apple.com>
2445
2446         rename KURL to URL
2447         https://bugs.webkit.org/show_bug.cgi?id=16214
2448
2449         Reviewed by Andreas Kling.
2450
2451         * many files: Renamed, using script.
2452
2453 2013-09-27  Darin Adler  <darin@apple.com>
2454
2455         Fix Python scripts test failures.
2456
2457         * Scripts/webkitpy/style/checkers/cpp.py:
2458         (_FunctionState.modifiers_and_return_type): Added this back. Used only by tests
2459         now, not by the checker itself.
2460
2461 2013-09-27  Denis Nomiyama  <d.nomiyama@samsung.com>
2462
2463         [GTK][WK2] Logging of accessibility events is not disabled between tests
2464         https://bugs.webkit.org/show_bug.cgi?id=121957
2465
2466         Reviewed by Mario Sanchez Prada.
2467
2468         Fixed an issue in AccessibilityNotificationHandler where the destructor
2469         was not disconnecting accessibility event callbacks if logging was on.
2470         The decision of disconnecting events can solely rely on the existence of
2471         notification handlers because logging uses the global notification
2472         handler.
2473
2474         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2475         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks): Fixed
2476         disconnection when logging is on.
2477
2478 2013-09-27  Patrick Gansterer  <paroga@webkit.org>
2479
2480         Add general CMakeLists.txt for DRT
2481         https://bugs.webkit.org/show_bug.cgi?id=119268
2482
2483         Reviewed by Gyuyoung Kim.
2484
2485         The new file allows better sharing between ports.
2486
2487         * CMakeLists.txt:
2488         * DumpRenderTree/CMakeLists.txt: Added.
2489         * DumpRenderTree/PlatformEfl.cmake: Added.
2490         * DumpRenderTree/efl/CMakeLists.txt: Removed.
2491
2492 2013-09-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2493
2494         [Qt] Fix force_static_libs_as_shared in WebKit2
2495         https://bugs.webkit.org/show_bug.cgi?id=121961
2496
2497         Reviewed by Csaba Osztrogonác.
2498
2499         Reenable force_static_libs_as_shared when building WebKit2.
2500
2501         * qmake/mkspecs/features/default_post.prf:
2502
2503 2013-09-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2504
2505         [Qt] Mock implementations of positioning and orientation not used
2506         https://bugs.webkit.org/show_bug.cgi?id=121956
2507
2508         Reviewed by Csaba Osztrogonác.
2509
2510         Move production_build checks to sanitizeFeatures where its value is actually known.
2511
2512         * qmake/mkspecs/features/features.prf:
2513         * qmake/mkspecs/features/features.pri:
2514
2515 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
2516
2517         [ATK] Normalize checks in entry points for DRT and WKTR
2518         https://bugs.webkit.org/show_bug.cgi?id=121959
2519
2520         Reviewed by Chris Fleizach.
2521
2522         Always check if we have a proper instance of AtkObject,
2523         implementing the interfaces that we might need for each case, at
2524         the entry point of every method of AccessibilityUIElement for ATK,
2525         and do those checks in an uniform way across DRT and WKTR, to
2526         avoid confusion and issues when modifying these files in the future.
2527
2528         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2529         (AccessibilityUIElement::getChildren): Use normalized checks.
2530         (AccessibilityUIElement::getChildrenWithRange): Ditto.
2531         (AccessibilityUIElement::rowCount): Ditto.
2532         (AccessibilityUIElement::columnCount): Ditto.
2533         (AccessibilityUIElement::childrenCount): Ditto.
2534         (AccessibilityUIElement::elementAtPoint): Ditto.
2535         (AccessibilityUIElement::getChildAtIndex): Ditto.
2536         (AccessibilityUIElement::allAttributes): Ditto.
2537         (AccessibilityUIElement::titleUIElement): Ditto.
2538         (AccessibilityUIElement::parentElement): Ditto.
2539         (AccessibilityUIElement::attributesOfChildren): Ditto.
2540         (AccessibilityUIElement::role): Ditto.
2541         (AccessibilityUIElement::title): Ditto.
2542         (AccessibilityUIElement::description): Ditto.
2543         (AccessibilityUIElement::stringValue): Ditto.
2544         (AccessibilityUIElement::language): Ditto.
2545         (AccessibilityUIElement::x): Ditto.
2546         (AccessibilityUIElement::y): Ditto.
2547         (AccessibilityUIElement::width): Ditto.
2548         (AccessibilityUIElement::height): Ditto.
2549         (AccessibilityUIElement::orientation): Ditto.
2550         (AccessibilityUIElement::intValue): Ditto.
2551         (AccessibilityUIElement::minValue): Ditto.
2552         (AccessibilityUIElement::maxValue): Ditto.
2553         (indexRangeInTable): Ditto.
2554         (AccessibilityUIElement::cellForColumnAndRow): Ditto.
2555         (AccessibilityUIElement::stringAttributeValue): Ditto.
2556         (alterCurrentValue): Ditto.
2557         (AccessibilityUIElement::press): Ditto.
2558         (AccessibilityUIElement::documentEncoding): Ditto.
2559         (AccessibilityUIElement::documentURI): Ditto.
2560         (AccessibilityUIElement::hasPopup): Ditto.
2561
2562         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2563         (WTR::indexRangeInTable): Use normalized checks.
2564         (WTR::alterCurrentValue): Ditto.
2565         (WTR::AccessibilityUIElement::getChildren): Ditto.
2566         (WTR::AccessibilityUIElement::getChildrenWithRange): Ditto.
2567         (WTR::AccessibilityUIElement::childrenCount): Ditto.
2568         (WTR::AccessibilityUIElement::elementAtPoint): Ditto.
2569         (WTR::AccessibilityUIElement::indexOfChild): Ditto.
2570         (WTR::AccessibilityUIElement::childAtIndex): Ditto.
2571         (WTR::AccessibilityUIElement::titleUIElement): Ditto.
2572         (WTR::AccessibilityUIElement::parentElement): Ditto.
2573         (WTR::AccessibilityUIElement::attributesOfChildren): Ditto.
2574         (WTR::AccessibilityUIElement::allAttributes): Ditto.
2575         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
2576         (WTR::AccessibilityUIElement::role): Ditto.
2577         (WTR::AccessibilityUIElement::title): Ditto.
2578         (WTR::AccessibilityUIElement::description): Ditto.
2579         (WTR::AccessibilityUIElement::orientation): Ditto.
2580         (WTR::AccessibilityUIElement::stringValue): Ditto.
2581         (WTR::AccessibilityUIElement::language): Ditto.
2582         (WTR::AccessibilityUIElement::x): Ditto.
2583         (WTR::AccessibilityUIElement::y): Ditto.
2584         (WTR::AccessibilityUIElement::width): Ditto.
2585         (WTR::AccessibilityUIElement::height): Ditto.
2586         (WTR::AccessibilityUIElement::intValue): Ditto.
2587         (WTR::AccessibilityUIElement::minValue): Ditto.
2588         (WTR::AccessibilityUIElement::maxValue): Ditto.
2589         (WTR::AccessibilityUIElement::rowCount): Ditto.
2590         (WTR::AccessibilityUIElement::columnCount): Ditto.
2591         (WTR::AccessibilityUIElement::cellForColumnAndRow): Ditto.
2592         (WTR::AccessibilityUIElement::press): Ditto.
2593         (WTR::AccessibilityUIElement::documentEncoding): Ditto.
2594         (WTR::AccessibilityUIElement::documentURI): Ditto.
2595         (WTR::AccessibilityUIElement::hasPopup): Ditto.
2596
2597 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
2598
2599         [ATK] accessibility/aria-sort.html is failing after r156409
2600         https://bugs.webkit.org/show_bug.cgi?id=121947
2601
2602         Reviewed by Chris Fleizach.
2603
2604         Implement AccessibilityUIElement::isSupported for the ATK
2605         platforms, just by checking whether we have an associated object
2606         attribute exposed for the wrapper object matching the required
2607         attribute in the layout test (e.g "AXSortDirection" -> "sort").
2608
2609         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2610         (AccessibilityUIElement::isAttributeSupported): Implemented.
2611         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2612         (WTR::AccessibilityUIElement::isAttributeSupported): Implemented.
2613
2614 2013-09-26  Eric Carlson  <eric.carlson@apple.com>
2615
2616         [MediaStream] make MediaStream testable
2617         https://bugs.webkit.org/show_bug.cgi?id=121967
2618
2619         Reviewed by Dean Jackson.
2620
2621         * DumpRenderTree/mac/UIDelegate.mm:
2622         (-[UIDelegate webView:decidePolicyForUserMediaRequestFromOrigin:listener:]): Add a very permissive
2623             user media request policy delegate.
2624
2625 2013-09-26  Brian J. Burg  <burg@cs.washington.edu>
2626
2627         build-webkit --inspector-frontend should copy WebInspectorUI files
2628         https://bugs.webkit.org/show_bug.cgi?id=117851
2629
2630         Reviewed by Joseph Pecoraro.
2631
2632         Change the --inspector-frontend build option to additionally build/copy 
2633         WebInspectorUI by setting it as the only project that needs to be built.
2634
2635         * Scripts/build-webkit:
2636
2637 2013-09-26  Zan Dobersek  <zdobersek@igalia.com>
2638
2639         XvfbDriver should set up Xvfb instances providing screens of 8-bit depth
2640         https://bugs.webkit.org/show_bug.cgi?id=121951
2641
2642         Reviewed by Carlos Garcia Campos.
2643
2644         Screens with 24-bit depth are causing problems as it doesn't seem to be possible to fall back to
2645         software rendering successfully on the GTK 64-bit release builder, resulting in crashes in almost
2646         500 layout tests that trigger accelerated compositing to be used.
2647
2648         * Scripts/webkitpy/port/xvfbdriver.py:
2649         (XvfbDriver._start):
2650         * Scripts/webkitpy/port/xvfbdriver_unittest.py: Update unit test baselines.
2651         (XvfbDriverTest.test_start_no_pixel_tests):
2652         (XvfbDriverTest.test_start_pixel_tests):
2653         (XvfbDriverTest.test_start_arbitrary_worker_number):
2654         (XvfbDriverTest.test_next_free_display):
2655         (XvfbDriverTest.test_start_next_worker):
2656
2657 2013-09-26  Tim Horton  <timothy_horton@apple.com>
2658
2659         Tiled drawing should not imply threaded scrolling
2660         https://bugs.webkit.org/show_bug.cgi?id=121874
2661         <rdar://problem/15071494>
2662
2663         Reviewed by Sam Weinig.
2664
2665         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2666         (WTR::PlatformWebView::PlatformWebView):
2667         The existing tiled-drawing layout tests require threaded scrolling to be enabled.
2668
2669 2013-09-26  Commit Queue  <commit-queue@webkit.org>
2670
2671         Unreviewed, rolling out r156457.
2672         http://trac.webkit.org/changeset/156457
2673         https://bugs.webkit.org/show_bug.cgi?id=121960
2674
2675         Broke webkitpy tests. (Requested by kling on #webkit).
2676
2677         * Scripts/webkitpy/port/xvfbdriver.py:
2678         (XvfbDriver._start):
2679
2680 2013-09-26  Zan Dobersek  <zdobersek@igalia.com>
2681
2682         XvfbDriver should set up Xvfb instances providing screens of 8-bit depth
2683         https://bugs.webkit.org/show_bug.cgi?id=121951
2684
2685         Reviewed by Carlos Garcia Campos.
2686
2687         Screens with 24-bit depth are causing problems as it doesn't seem to be possible to fall back to
2688         software rendering successfully on the GTK 64-bit release builder, resulting in crashes in almost
2689         500 layout tests that trigger accelerated compositing to be used.
2690
2691         * Scripts/webkitpy/port/xvfbdriver.py:
2692         (XvfbDriver._start):
2693
2694 2013-09-25  Alex Christensen  <achristensen@webkit.org>
2695
2696         Removed check for Apple Application Support directory in WinCairo port.
2697         https://bugs.webkit.org/show_bug.cgi?id=121869
2698
2699         Reviewed by Brent Fulgham.
2700
2701         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
2702         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2703         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
2704         Use DLLLauncherWinCairo.props for WinCairo ports.
2705         * win/DLLLauncher/DLLLauncherMain.cpp:
2706         (wWinMain):
2707         Don't call modifyPath to check for AAS in the WinCairo port.
2708         * win/DLLLauncher/DLLLauncherWinCairo.props: Added to define WIN_CAIRO.
2709
2710 2013-09-25  Alex Christensen  <achristensen@webkit.org>
2711
2712         Enabled AssembleBuildLogs on WinCairo port.
2713         https://bugs.webkit.org/show_bug.cgi?id=121923
2714
2715         Reviewed by Brent Fulgham.
2716
2717         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
2718         Fixed reference to README, added WinCairo configurations.
2719         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj.filters:
2720         Fixed reference to README.
2721         * win/AssembleBuildLogs/AssembleLogs.cmd:
2722         Added ANGLE projects, skipped QTMovieWin for WinCairo, use PlatformArchitecture for Win64.
2723         * win/AssembleBuildLogs/README: Fixed spelling.
2724
2725 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
2726
2727         [WIN] Fix MSVC C4146 compiler warning
2728         https://bugs.webkit.org/show_bug.cgi?id=121838
2729
2730         Reviewed by Brent Fulgham.
2731
2732         Fix some variables from unsinged to int to fix the compiler warning
2733         "unary minus operator applied to unsigned type, result still unsigned".
2734
2735         * DumpRenderTree/WorkQueueItem.h:
2736         (BackItem::BackItem):
2737         (ForwardItem::ForwardItem):
2738         * DumpRenderTree/win/DumpRenderTree.cpp:
2739         (createWebViewAndOffscreenWindow):
2740
2741 2013-09-25  Zan Dobersek  <zdobersek@igalia.com>
2742
2743         [GTK] Switch the 64-bit Release builder to testing layout tests under WK2
2744         https://bugs.webkit.org/show_bug.cgi?id=121256
2745
2746         Reviewed by Martin Robinson.
2747
2748         Switch the GTK 64-bit Release builder to testing the layout tests under WebKit2.
2749         The GTK 64-bit Release WK2 testing builder is switched to now run layout tests under WebKit1.
2750
2751         * BuildSlaveSupport/build.webkit.org-config/config.json:
2752
2753 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
2754
2755         Add style checker for CMake lists
2756         https://bugs.webkit.org/show_bug.cgi?id=121764
2757
2758         Reviewed by Ryosuke Niwa.
2759
2760         Add an additional check to make sure that list of files are sorted.
2761         Exclude lists of include directories for now, since the order
2762         can be importent for compilation of some files.
2763
2764         * Scripts/webkitpy/style/checkers/cmake.py:
2765         (CMakeChecker.check):
2766         (CMakeChecker._check_indent):
2767         (CMakeChecker):
2768         (CMakeChecker._check_list_order):
2769         (CMakeChecker._list_item_path):
2770         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
2771         (CMakeCheckerTest.test_check):
2772
2773 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
2774
2775         CMakeChecker takes unusually long time to run
2776         https://bugs.webkit.org/show_bug.cgi?id=105662
2777
2778         Reviewed by Ryosuke Niwa.
2779
2780         Move the caching mechanism for regular expression of the C++ checker into
2781         a common file and use it for the CMake and ChangeLog checkers too.
2782
2783         * Scripts/webkitpy/style/checkers/changelog.py:
2784         (ChangeLogChecker.check_entry):
2785         * Scripts/webkitpy/style/checkers/cmake.py:
2786         (CMakeChecker._process_line):
2787         (CMakeChecker._check_no_space_cmds):
2788         (CMakeChecker._check_one_space_cmds):
2789         (CMakeChecker._check_non_lowercase_cmd):
2790         * Scripts/webkitpy/style/checkers/common.py:
2791         (match):
2792         (search):
2793         (searchIgnorecase):
2794         (sub):
2795         (subn):
2796         * Scripts/webkitpy/style/checkers/cpp.py:
2797
2798 2013-09-25  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2799
2800         [Qt] Fix build with Qt 5.2 QtPosition module
2801         https://bugs.webkit.org/show_bug.cgi?id=121089
2802
2803         Reviewed by Simon Hausmann.
2804
2805         QtLocation -> QtPositioning. Make sure we set build type before doing configure checks
2806         that might depend on them.
2807
2808         * qmake/mkspecs/features/default_pre.prf:
2809         * qmake/mkspecs/features/features.prf:
2810
2811 2013-09-25  Mario Sanchez Prada  <mario.prada@samsung.com>
2812
2813         [ATK] Fix style issues in AccessibilityUIElementAtk
2814         https://bugs.webkit.org/show_bug.cgi?id=121898
2815
2816         Reviewed by Chris Fleizach.
2817
2818         Avoid the '.f' suffix for float literals and use G_VALUE_INIT
2819         instead of { 0, { { 0 } } } to initialize a GValue.
2820
2821         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2822         (AccessibilityUIElement::clickPointX): Remove suffix.
2823         (AccessibilityUIElement::clickPointY): Ditto.
2824         (AccessibilityUIElement::intValue): Use G_VALUE_INIT and remove suffix.
2825         (AccessibilityUIElement::minValue): Ditto.
2826         (AccessibilityUIElement::maxValue): Ditto.
2827         (AccessibilityUIElement::numberAttributeValue): Remove suffix.
2828         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2829         (WTR::AccessibilityUIElement::numberAttributeValue): Remove suffix.
2830         (WTR::AccessibilityUIElement::x): Ditto.
2831         (WTR::AccessibilityUIElement::y): Ditto.
2832         (WTR::AccessibilityUIElement::width): Ditto.
2833         (WTR::AccessibilityUIElement::height): Ditto.
2834         (WTR::AccessibilityUIElement::clickPointX): Ditto.
2835         (WTR::AccessibilityUIElement::clickPointY): Ditto.
2836         (WTR::AccessibilityUIElement::intValue): Ditto.
2837         (WTR::AccessibilityUIElement::minValue): Ditto.
2838         (WTR::AccessibilityUIElement::maxValue): Ditto.
2839
2840 2013-09-25  Krzysztof Czech  <k.czech@samsung.com>
2841
2842         [EFL] accessibility/loading-iframe-sends-notification.html is failing
2843         https://bugs.webkit.org/show_bug.cgi?id=112003
2844
2845         Reviewed by Mario Sanchez Prada.
2846
2847         Enabled addNotificationListener and removeNotificationListener for EFL port.
2848
2849         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2850         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2851         (WTR::AccessibilityController::removeNotificationListener):
2852
2853 2013-09-24  Filip Pizlo  <fpizlo@apple.com>
2854
2855         Crashing under JSC::DFG::SpeculativeJIT::spill visiting citicards.com
2856         https://bugs.webkit.org/show_bug.cgi?id=121844
2857
2858         Reviewed by Mark Hahnenberg.
2859
2860         * Scripts/run-javascriptcore-tests: Be more clear about what test suite failed.
2861
2862 2013-09-24  Alexey Proskuryakov  <ap@apple.com>
2863
2864         [Mac][WK2] Multiple font tests fail is there is a global setting for font antialiasing threshold
2865         https://bugs.webkit.org/show_bug.cgi?id=121854
2866
2867         Reviewed by Anders Carlsson.
2868
2869         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2870         (WTR::InjectedBundle::platformInitialize): Post a notification to update cached
2871         settings in underlying frameworks.
2872
2873 2013-09-24  Mark Rowe  <mrowe@apple.com>
2874
2875         <rdar://problem/14971518> WebKit should build against the Xcode default toolchain when targeting OS X 10.8
2876
2877         Reviewed by Dan Bernstein.
2878
2879         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2880         * MiniBrowser/Configurations/Base.xcconfig:
2881         * TestWebKitAPI/Configurations/Base.xcconfig:
2882         * WebKitLauncher/Configurations/Base.xcconfig:
2883         * WebKitTestRunner/Configurations/Base.xcconfig:
2884
2885 2013-09-24  Denis Nomiyama  <d.nomiyama@samsung.com>
2886
2887         [ATK] Missing WTR AccessibilityController::addNotificationListener implementation
2888         https://bugs.webkit.org/show_bug.cgi?id=121674
2889
2890         Reviewed by Mario Sanchez Prada.
2891
2892         Implemented the global notification listener for
2893         AccessibilityController. The signal is generated by
2894         AXObjectCache::postPlatformNotification() and received by
2895         axObjectEventListener(). axObjectEventListener will then invoke
2896         JSObjectCallAsFunction() with the respective callback function.
2897
2898         There is no additional test for this patch since its implementation will
2899         be tested by an accessibility layout test that is currently failing
2900         (accessibility/loading-iframe-sends-notification.html).
2901
2902         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Removed
2903         stub implementations of addNotificationListener and
2904         removeNotificationListener for the GTK port.
2905         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2906         (WTR::AccessibilityController::addNotificationListener): Creates the
2907         notification handler and sets the notification function callback.
2908         (WTR::AccessibilityController::removeNotificationListener): Removes the
2909         global handler.
2910
2911 2013-09-24  Anton Obzhirov  <a.obzhirov@samsung.com>
2912
2913         [GTK] fast/images/exif-orientation-composited.html is failing
2914         https://bugs.webkit.org/show_bug.cgi?id=119731
2915
2916         Reviewed by Carlos Garcia Campos.
2917
2918         Add handling respect image orientation property in DRT.
2919
2920         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2921         (TestRunner::overridePreference):
2922
2923 2013-09-24  Zan Dobersek  <zdobersek@igalia.com>
2924
2925         [GTK] Bump the GTK+ dependency in the Wayland-specific Jhbuild moduleset
2926         https://bugs.webkit.org/show_bug.cgi?id=121787
2927
2928         Reviewed by Gustavo Noronha Silva.
2929
2930         * gtk/jhbuild-wayland.modules: Bump the GTK+ dependency that's intended for use when building
2931         with the Wayland target enabled to version 3.10.0.
2932
2933 2013-09-23  Patrick Gansterer  <paroga@webkit.org>
2934
2935         use NOMINMAX instead of #define min min
2936         https://bugs.webkit.org/show_bug.cgi?id=73563
2937
2938         Reviewed by Brent Fulgham.
2939
2940         Use NOMINMAX instead of #define min/max as a cleaner
2941         way of ensuring that Windows system header files don't
2942         define min/max as macro in the first place.
2943
2944         * DumpRenderTree/DumpRenderTreePrefix.h:
2945         * DumpRenderTree/cg/ImageDiffCG.cpp:
2946         * DumpRenderTree/config.h:
2947         * DumpRenderTree/win/ImageDiffCairo.cpp:
2948         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
2949         * WebKitTestRunner/config.h:
2950
2951 2013-09-23  Benjamin Poulain  <benjamin@webkit.org>
2952
2953         Delete TestWebKitAPI domain or some keys before running TestWebKitAPI
2954         https://bugs.webkit.org/show_bug.cgi?id=121715 & <rdar://problem/14269434>
2955
2956         Reviewed by Alexey Proskuryakov.
2957
2958         Previously, initalizing a WebPreference would change the cache model
2959         to WebCacheModelDocumentBrowser. That behavior was due to a stale
2960         preference file on disk.
2961
2962         This patch fixes the tests by resetting the default, and using the proper
2963         default values after initializing WebPreference.
2964
2965         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
2966         (TestWebKitAPI::TEST): Use the proper initial value, unrelated
2967         to the previous runs.
2968
2969         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
2970         (TestWebKitAPI::TEST): This test needs b/f cache to be enabled, so change
2971         cache model to the one required.
2972
2973         * TestWebKitAPI/ios/mainIOS.mm:
2974         (main): Reset the preferences before testing.
2975         * TestWebKitAPI/mac/mainMac.mm:
2976         (main): Ditto.
2977
2978 2013-09-23  Benjamin Poulain  <benjamin@webkit.org>
2979
2980         Delete TestWebKitAPI domain or some keys before running TestWebKitAPI
2981         https://bugs.webkit.org/show_bug.cgi?id=121715 & <rdar://problem/14269434>
2982
2983         Reviewed by Alexey Proskuryakov.
2984
2985         Previously, initalizing a WebPreference would change the cache model
2986         to WebCacheModelDocumentBrowser. That behavior was due to a stale
2987         preference file on disk.
2988
2989         This patch fixes the tests by resetting the default, and using the proper
2990         default values after initializing WebPreference.
2991
2992         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
2993         (TestWebKitAPI::TEST): Use the proper initial value, unrelated
2994         to the previous runs.
2995
2996         * TestWebKitAPI/ios/mainIOS.mm:
2997         (main): Reset the preferences before testing.
2998         * TestWebKitAPI/mac/mainMac.mm:
2999         (main): Ditto.
3000
3001 2013-09-23  Anders Carlsson  <andersca@apple.com>
3002
3003         ListHashSet should work with move-only types
3004         https://bugs.webkit.org/show_bug.cgi?id=121802
3005
3006         Reviewed by Andreas Kling.
3007
3008         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
3009         (TestWebKitAPI::TEST):
3010         Add a test for move-only types.
3011
3012 2013-09-23  Alex Christensen  <alex.christensen@flexsim.com>
3013
3014         Added --64-bit option for Windows build.
3015         https://bugs.webkit.org/show_bug.cgi?id=121799
3016
3017         Reviewed by Brent Fulgham.
3018
3019         * Scripts/webkitdirs.pm:
3020         (determinePassedConfiguration): Add "|x64" for 64-bit configuration.
3021         (isWin64): Added.
3022         (determineIsWin64): Added.
3023
3024 2013-09-23  Anders Carlsson  <andersca@apple.com>
3025
3026         ListHashSet should use std::reverse_iterator for reverse iterators
3027         https://bugs.webkit.org/show_bug.cgi?id=121795
3028
3029         Reviewed by Antti Koivisto.
3030
3031         Add test for reverse iterators.
3032
3033         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
3034         (TestWebKitAPI::TEST):
3035
3036 2013-09-23  Krzysztof Czech  <k.czech@samsung.com>
3037
3038         [EFL] accessibility/aria-invalid is failing
3039         https://bugs.webkit.org/show_bug.cgi?id=111986
3040
3041         Reviewed by Mario Sanchez Prada.
3042
3043         Adds possibility to retrieve JS context.
3044         This is part of the implementation of AccessibilityUIElement::addNotificationListener
3045         from 119883 and 120421.
3046
3047         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
3048         (axObjectEventListener):
3049         (addAccessibilityNotificationHandler):
3050         (removeAccessibilityNotificationHandler):
3051         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3052         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
3053         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
3054
3055 2013-09-20  Mark Rowe  <mrowe@apple.com>
3056
3057         <https://webkit.org/b/90090> build-webkit should verify that your tools are up-to-date
3058
3059         Enforce a minimum OS version of 10.7.5 and Xcode version of 4.6.
3060
3061         Reviewed by David Kilzer.
3062
3063         * Scripts/webkitdirs.pm:
3064         (checkRequiredSystemConfig):
3065
3066 2013-09-20  Mario Sanchez Prada  <mario.prada@samsung.com>
3067
3068         [ATK] Do not expose aria-help in ATK based platforms
3069         https://bugs.webkit.org/show_bug.cgi?id=121675
3070
3071         Reviewed by Chris Fleizach.
3072
3073         Remove the implementations for AccessibilityUIElement::helpText()
3074         from DRT and WKTR for GTK and EFL, since they are based on the
3075         AccessibilityObject::helpText() method and the 'aria-help'
3076         attributes, which is wrong since they should not depend on that
3077         but in ATK specific API (see also http://webkit.org/b/121684).
3078
3079         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3080         (AccessibilityUIElement::helpText): Added a new and empty
3081         implementation, now that we are no longer using this in ATK.
3082         * DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Removed file
3083         as the only function provided here was helpText().
3084         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Ditto.
3085         * DumpRenderTree/efl/CMakeLists.txt: AccessibilityUIElementEfl.cpp
3086         removed from the list of sources to compile.
3087         * GNUmakefile.am: Likewise, but for AccessibilityUIElementGtk.cpp.
3088         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3089         (WTR::AccessibilityUIElement::helpText): Replaced old implementation
3090         based in DumpRenderTreeSupportGtk with an empty one.
3091
3092 2013-09-20  Dan Bernstein  <mitz@apple.com>
3093
3094         Make extract-localizable-strings available to WebCore clients
3095         https://bugs.webkit.org/show_bug.cgi?id=121699
3096
3097         Reviewed by Darin Adler.
3098
3099         * Scripts/extract-localizable-strings: Copied to
3100         Soure/WebCore/extract-localizaebl-strings.pl, and changed this into a shell script that
3101         executes the script from its new location. This is a temporary measure until certain code
3102         that is external to WebKit is adapted to the new location.
3103         * Scripts/update-webkit-localizable-strings: Changed to call extract-localizable-strings.pl
3104         from its new location.
3105
3106 2013-09-20  Patrick Gansterer  <paroga@webkit.org>
3107
3108         Nuke remaining VS2005 tools from the tree.
3109         https://bugs.webkit.org/show_bug.cgi?id=121691
3110
3111         Reviewed by Brent Fulgham.
3112
3113         * CLWrapper/CLWrapper.cpp: Removed.
3114         * CLWrapper/CLWrapper.sln: Removed.
3115         * CLWrapper/CLWrapper.vcproj: Removed.
3116         * MIDLWrapper/MIDLWrapper.cpp: Removed.
3117         * MIDLWrapper/MIDLWrapper.sln: Removed.
3118         * MIDLWrapper/MIDLWrapper.vcproj: Removed.
3119         * Scripts/parallelcl: Removed.
3120         * vcbin/cl.exe: Removed.
3121         * vcbin/midl.exe: Removed.
3122
3123 2013-09-20  Mario Sanchez Prada  <mario.prada@samsung.com>
3124
3125         [GTK] socket_embed_hook hitting NULL-check assertion running TestWebKit2
3126         https://bugs.webkit.org/show_bug.cgi?id=121294
3127
3128         Reviewed by Martin Robinson.
3129
3130         Provide a new patch to deal with the issue in the GTK+ module from
3131         the internal jhbuild environment. This issue has been reported
3132         upstream (see https://bugzilla.gnome.org/show_bug.cgi?id=708024).
3133
3134         * gtk/jhbuild.modules: Apply the new patch to the GTK+ module.
3135         * gtk/patches/gtk-3.6-do-not-shutdown-accessibility.patch: Added.
3136
3137 2013-09-20  Denis Nomiyama  <d.nomiyama@samsung.com>
3138
3139         [ATK][WTR] accessibility/aria-invalid.html times out
3140         https://bugs.webkit.org/show_bug.cgi?id=121668
3141
3142         Reviewed by Mario Sanchez Prada.
3143
3144         Fixed WTR::AccessibilityUIElement::stringAttributeValue() to return
3145         false in case of aria-invalid event with empty value.
3146
3147         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3148         (WTR::AccessibilityUIElement::stringAttributeValue): Returns false in
3149         case of aria-invalid event with empty value.
3150
3151 2013-09-20  Denis Nomiyama  <d.nomiyama@samsung.com>
3152
3153         [ATK] Missing WTR AccessibilityUIElement::addNotificationListener implementation
3154         https://bugs.webkit.org/show_bug.cgi?id=120421
3155
3156         Reviewed by Mario Sanchez Prada.
3157
3158         Implemented the notification listener for AccessibilityUIElement for
3159         WebKitTestRunner. The signal is generated by
3160         AXObjectCache::postPlatformNotification() and received by
3161         axObjectEventListener(). axObjectEventListener() will then invoke
3162         JSObjectCallAsFunction() with the respective callback function. The
3163         notification handlers are stored in HashMap in
3164         AccessibilityNotificationHandlerAtk.cpp.
3165
3166         Moved ATK signal handling (printAccessibilityEvent and
3167         axObjectEventListener) to AccessibilityNotificationHandlerAtk.cpp.
3168
3169         * WebKitTestRunner/CMakeLists.txt: Added InjectedBundle/atk to the
3170         include path.
3171         * WebKitTestRunner/GNUmakefile.am:
3172         Added AccessibilityNotificationHandlerAtk.cpp/h.
3173         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Moved
3174         listener IDs to AccessibilityNotificationHandlerAtk.cpp.
3175         * WebKitTestRunner/InjectedBundle/AccessibilityController.h: Moved
3176         listener IDs to AccessibilityNotificationHandlerAtk.cpp.
3177         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added a
3178         notification handler for GTK+ and EFL.
3179         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
3180         Moved printAccessibilityEvent and axObjectEventListener to
3181         AccessibilityNotificationHandlerAtk.cpp.
3182         (WTR::AccessibilityController::logAccessibilityEvents): Moved listener
3183         IDs to AccessibilityNotificationHandlerAtk.cpp.
3184         (WTR::AccessibilityController::resetToConsistentState): Moved listener
3185         IDs to AccessibilityNotificationHandlerAtk.cpp.
3186         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Added.
3187         (WTR::printAccessibilityEvent): Prints accessibility events. This
3188         function was moved from AccessibilityControllerAtk.cpp.
3189         (WTR::axObjectEventListener): Callback for signals. This function was
3190         moved from AccessibilityControllerAtk.cpp.
3191         (WTR::AccessibilityNotificationHandler::AccessibilityNotificationHandler):
3192         Initialize element and function callback.
3193         (WTR::AccessibilityNotificationHandler::~AccessibilityNotificationHandler):
3194         Removes handler from HashMap and disconnects callbacks if necessary.
3195         (WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Sets
3196         logging mode and connects callbacks.
3197         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
3198         Sets the notification callback and connects callback to signals.
3199         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
3200         Removes the notification callback from HashMap.
3201         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
3202         Connects axObjectEventListener to ATK signals.
3203         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
3204         Disconnects callback.
3205         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h: Added.
3206         (WTR::AccessibilityNotificationHandler::create): Creates a new instance
3207         of AccessibilityNotificationHandler.
3208         (WTR::AccessibilityNotificationHandler::setPlatformElement): Sets the
3209         element.
3210         (WTR::AccessibilityNotificationHandler::platformElement): Gets the
3211         element.
3212         (WTR::AccessibilityNotificationHandler::notificationFunctionCallback):
3213         Gets the notification callback.
3214         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3215         (WTR::AccessibilityUIElement::addNotificationListener): Creates
3216         notification handler, set the platform element and the notification
3217         callback.
3218         (WTR::AccessibilityUIElement::removeNotificationListener): Deletes the
3219         notification handler.
3220         * WebKitTestRunner/PlatformEfl.cmake:
3221         Added AccessibilityNotificationHandlerAtk.cpp.
3222
3223 2013-09-20  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3224
3225         Update features.pri
3226         https://bugs.webkit.org/show_bug.cgi?id=121670
3227
3228         Reviewed by Jocelyn Turcotte.
3229
3230         Remove feature flags that no longer exists and new ones added to FeatureList.pm
3231
3232         * qmake/mkspecs/features/features.pri:
3233
3234 2013-09-20  Krzysztof Czech  <k.czech@samsung.com>
3235
3236         [GTK][WK2] accessibility/selection-states.html is failing
3237         https://bugs.webkit.org/show_bug.cgi?id=116972
3238
3239         Reviewed by Mario Sanchez Prada.
3240
3241         isSelectable() was not exposed in Accessibility.
3242
3243         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3244
3245 2013-09-19  Dan Bernstein  <mitz@apple.com>
3246
3247         Attempted build fix after r156114.
3248
3249         * Scripts/copy-webkitlibraries-to-product-directory: Removed references to WebCoreSQLite3.
3250
3251 2013-09-19  Alexey Proskuryakov  <ap@apple.com>
3252
3253         REGRESSION (r129451): run-safari --no-saved-state is broken
3254         https://bugs.webkit.org/show_bug.cgi?id=121566
3255
3256         Undo a last minute change that doesn't actually work.
3257
3258         * Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp): "-1" cannot be passed
3259         via command line, <rdar://problem/15032886>.
3260
3261 2013-09-19  Dan Bernstein  <mitz@apple.com>
3262
3263         Add a style guideline regarding spacing in range-based for loops
3264         https://bugs.webkit.org/show_bug.cgi?id=121620
3265
3266         Reviewed by Anders Carlsson.
3267
3268         * Scripts/webkitpy/style/checkers/cpp.py:
3269         (check_spacing): Added checking that there are spaces around the colon in a range-based for
3270         loop.
3271         (CppChecker): Added whitespace/colon to the categories set.
3272         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3273         (WebKitStyleTest.test_spacing): Added two tests for the new check.
3274
3275 2013-09-18  Sam Weinig  <sam@webkit.org>
3276
3277         Replace use of OwnArrayPtr<Foo> with std::unique_ptr<Foo[]> in Tools
3278         https://bugs.webkit.org/show_bug.cgi?id=121588
3279
3280         Reviewed by Anders Carlsson.
3281
3282         * DumpRenderTree/TestRunner.cpp:
3283         * ImageDiff/efl/ImageDiff.cpp:
3284         * TestWebKitAPI/JavaScriptTest.cpp:
3285         * TestWebKitAPI/PlatformUtilities.cpp:
3286         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3287         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3288         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3289         * WebKitTestRunner/StringFunctions.h:
3290         * WebKitTestRunner/TestInvocation.cpp:
3291         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
3292         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3293
3294 2013-09-18  Bem Jones-Bey  <bjonesbe@adobe.com>
3295
3296         W3C Test Import script reformats test HTML
3297         https://bugs.webkit.org/show_bug.cgi?id=119159
3298
3299         Reviewed by Dirk Pranke.
3300
3301         Completely rewrite the test conversion process to minimize
3302         reformatting when adding prefixes, etc. This isn't 100% perfect, there
3303         are still places where it will end up changing the formatting, but it
3304         is much better than before. Most notably, the public interface to the
3305         test converter has changed: now one calls a method instead of creating
3306         an instance of the test converter class. This is because the test
3307         converter class now has state, so one really needs a new instance for
3308         each test.
3309
3310         Note that this also lays some simple groundwork for being able to use
3311         a MockHost in the tests.
3312
3313         * Scripts/webkitpy/w3c/test_converter.py:
3314         (convert_for_webkit):
3315         (_W3CTestConverter):
3316         (_W3CTestConverter.__init__):
3317         (_W3CTestConverter.output):
3318         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
3319         (_W3CTestConverter.convert_style_data):
3320         (_W3CTestConverter.convert_attributes_if_needed):
3321         (_W3CTestConverter.handle_starttag):
3322         (_W3CTestConverter.handle_endtag):
3323         (_W3CTestConverter.handle_startendtag):
3324         (_W3CTestConverter.handle_data):
3325         (_W3CTestConverter.handle_entityref):
3326         (_W3CTestConverter.handle_charref):
3327         (_W3CTestConverter.handle_comment):
3328         (_W3CTestConverter.handle_decl):
3329         (_W3CTestConverter.handle_pi):
3330         * Scripts/webkitpy/w3c/test_converter_unittest.py:
3331         (W3CTestConverterTest):
3332         (W3CTestConverterTest.fake_dir_path):
3333         (W3CTestConverterTest.test_read_prefixed_property_list):
3334         (verify_no_conversion_happened):
3335         * Scripts/webkitpy/w3c/test_importer.py:
3336         (TestImporter.import_tests):
3337
3338 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
3339
3340         Get rid of the jsc-test-list by moving all not-jsc-capable tests into js/dom
3341         https://bugs.webkit.org/show_bug.cgi?id=121578
3342
3343         Rubber stamped by Geoffrey Garen.
3344
3345         * Scripts/run-layout-jsc:
3346
3347 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
3348
3349         Unreviewed, fix for Ruby 1.8.
3350
3351         * Scripts/run-jsc-stress-tests:
3352
3353 2013-09-17  Filip Pizlo  <fpizlo@apple.com>
3354
3355         run-jsc-stress-tests should make it easier to look at error spew from tests
3356         https://bugs.webkit.org/show_bug.cgi?id=121531
3357
3358         Reviewed by Mark Hahnenberg.
3359         
3360         This makes two changes:
3361         
3362         - The out/err spew from each test is now saved to a .out file in jsc-stress-results.
3363         
3364         - The same spew also goes to the console but is prefixed by the test's name.
3365         
3366         This required some tee and awk hacks, and then some sh hacks to work around the fact
3367         that if you do "(foo | bar) || baz", and foo fails, then baz won't run - the ||
3368         operator will only see a failure of bar failed. So to pass output to tee and awk, I
3369         needed to do weird things.
3370
3371         * Scripts/run-jsc-stress-tests:
3372
3373 2013-09-18  Alexey Proskuryakov  <ap@apple.com>
3374
3375         REGRESSION (r129451): run-safari --no-saved-state is broken
3376         https://bugs.webkit.org/show_bug.cgi?id=121566
3377
3378         Reviewed by Mark Rowe.
3379
3380         * Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp):
3381         Check arguments, not the newly created empty array. Pass a value that silences warnings.
3382         While at it, removed a check for Snow Leopard.
3383
3384 2013-09-18  Alex Christensen  <achristensen@webkit.org>
3385
3386         Improved WinLauncher's URL handling.
3387         https://bugs.webkit.org/show_bug.cgi?id=121535
3388
3389         Reviewed by Brent Fulgham.
3390
3391         * WinLauncher/WinLauncher.cpp:
3392         (EditProc):
3393         Use INTERNET_MAX_URL_LENGTH instead of our MAX_URL_LENGTH.
3394         (loadURL):
3395         Prepend "http://" to URLs with no scheme.
3396
3397 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
3398
3399         DFG should support Int52 for local variables
3400         https://bugs.webkit.org/show_bug.cgi?id=121064
3401
3402         Reviewed by Oliver Hunt.
3403
3404         * Scripts/run-jsc-stress-tests:
3405
3406 2013-09-18  peavo@outlook.com  <peavo@outlook.com>
3407
3408         [Win] TestWebKitAPI does not compile.
3409         https://bugs.webkit.org/show_bug.cgi?id=121485
3410
3411         Reviewed by Brent Fulgham.
3412
3413         It is no longer possible to inherit from WebCore::BitmapImage, which the test relies on.
3414         Instead, load a bitmap, then destroy the decoded data, which will cause WebCore::frameAtIndex()
3415         to return null, which is the case we want to test.
3416
3417         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
3418         (TestWebKitAPI::TEST):
3419
3420 2013-09-18  Mario Sanchez Prada  <mario.prada@samsung.com>
3421
3422         [ATK] Expose aria-haspopup and aria-sort without the 'aria-' prefix
3423         https://bugs.webkit.org/show_bug.cgi?id=121495
3424
3425         Reviewed by Chris Fleizach.
3426
3427         Adapted DRT and WKTR to deal with the new names for the ATK object
3428         attributes being exposed for 'aria-haspopup' and 'aria-sort'.
3429
3430         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3431         (coreAttributeToAtkAttribute): Updated translation between ATK and DRT.
3432         (AccessibilityUIElement::stringAttributeValue): Ditto.
3433         (AccessibilityUIElement::hasPopup): Ditto.
3434         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3435         (WTR::coreAttributeToAtkAttribute): Updated translation between ATK and WKTR.
3436         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
3437         (WTR::AccessibilityUIElement::hasPopup): Ditto.
3438
3439 2013-09-18  Commit Queue  <commit-queue@webkit.org>
3440
3441         Unreviewed, rolling out r156019 and r156020.
3442         http://trac.webkit.org/changeset/156019
3443         http://trac.webkit.org/changeset/156020
3444         https://bugs.webkit.org/show_bug.cgi?id=121540
3445
3446         Broke tests (Requested by ap on #webkit).
3447
3448         * Scripts/run-jsc-stress-tests:
3449
3450 2013-09-17  Gwang Yoon Hwang  <ryumiel@company100.net>
3451
3452         Unreviewed. Add myself as a committer.
3453
3454         * Scripts/webkitpy/common/config/contributors.json:
3455
3456 2013-09-17  Jae Hyun Park  <jae.park@company100.net>
3457
3458         Unreviewed. Add myself as a committer.
3459
3460         * Scripts/webkitpy/common/config/contributors.json:
3461
3462 2013-09-17  Filip Pizlo  <fpizlo@apple.com>
3463
3464         DFG should support Int52 for local variables
3465         https://bugs.webkit.org/show_bug.cgi?id=121064
3466
3467         Reviewed by Oliver Hunt.
3468
3469         * Scripts/run-jsc-stress-tests:
3470
3471 2013-09-17  Alex Christensen  <alex.christensen@flexsim.com>
3472
3473         Added back and forward buttons to WinLauncher.
3474         https://bugs.webkit.org/show_bug.cgi?id=121212
3475
3476         Reviewed by Brent Fulgham.
3477
3478         * WinLauncher/WinLauncher.cpp:
3479         (resizeSubViews):
3480         Move new back and forward buttons to correct positions before URL bar.
3481         (dllLauncherEntryPoint): 
3482         Store the default button window procedure and replace with my button procedures.
3483         (EditProc): Updated style and renamed from MyEditProc.
3484         (BackButtonProc): Added.
3485         (ForwardButtonProc): Added.
3486
3487 2013-09-17  Michael Saboff  <msaboff@apple.com>
3488
3489         Unreviewed typo fix after r155999
3490
3491         Changed en_US.UTB-8 to en_US.UTF-8
3492
3493         * Scripts/run-javascriptcore-tests:
3494
3495 2013-09-17  Michael Saboff  <msaboff@apple.com>
3496
3497         run-jsc-stress-tests fails with ruby version 2
3498         https://bugs.webkit.org/show_bug.cgi?id=121521
3499
3500         Reviewed by Jessie Berlin.
3501
3502         Explicitly set LANG to en_US.UTB-8 before starting run-jsc-stress-tests.
3503
3504         * Scripts/run-javascriptcore-tests:
3505
3506 2013-09-17  Brent Fulgham  <bfulgham@apple.com>
3507
3508         [Windows] Unreviewed build fix after r155963.
3509
3510         * DumpRenderTree/win/TestRunnerWin.cpp:
3511         (TestRunner::evaluateScriptInIsolatedWorld): Pass nullptr rather than 0.
3512
3513 2013-09-17  Anders Carlsson  <andersca@apple.com>
3514
3515         Fix a typo.
3516
3517         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3518         (TestWebKitAPI::TEST):
3519
3520 2013-09-16  Anders Carlsson  <andersca@apple.com>
3521
3522         HashMap should work with move-only keys
3523         https://bugs.webkit.org/show_bug.cgi?id=121310
3524
3525         Reviewed by Darin Adler.
3526
3527         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3528         (TestWebKitAPI::TEST):
3529         Add test.
3530
3531 2013-09-17  YuTeh Shen  <shenyute@hotmail.com>
3532
3533         BrowserMarshal.h build fail
3534         https://bugs.webkit.org/show_bug.cgi?id=102938
3535
3536         Reviewed by Carlos Garcia Campos.
3537
3538         Fix variable name.
3539
3540         * MiniBrowser/gtk/GNUmakefile.am:
3541
3542 2013-09-16  Brent Fulgham  <bfulgham@apple.com>
3543
3544         [Windows] Clean up WinLauncher by using smart pointers
3545         https://bugs.webkit.org/show_bug.cgi?id=121467
3546
3547         Reviewed by Anders Carlsson.
3548
3549         * WinLauncher/PrintWebUIDelegate.cpp:
3550         (PrintWebUIDelegate::webViewPrintingMarginRect): Switch to smart pointers.
3551         * WinLauncher/WinLauncher.cpp:
3552         (WinLauncherWebHost::updateAddressBar): Use _bstr_t and smart pointers.
3553         (WinLauncherWebHost::didFailProvisionalLoadWithError): Ditto.
3554         (showLastVisitedSites): Smart pointer updates.
3555         (WinLauncherWebHost::didFinishLoadForFrame): Ditto.
3556         (setToDefaultPreferences): Ditto.
3557         (dllLauncherEntryPoint): Ditto.
3558         (PrintView): Ditto.
3559         (LaunchInspector): Ditto.
3560         (NavigateToHistory): Ditto.
3561         (MyEditProc): Ditto.
3562         (loadURL): Ditto.
3563
3564 2013-09-16  Brent Fulgham  <bfulgham@apple.com>
3565
3566         [Windows] Add rudimentary history to WinLauncher.
3567         https://bugs.webkit.org/show_bug.cgi?id=121463
3568
3569         Reviewed by Anders Carlsson.
3570
3571         * WinLauncher/WinLauncher.cpp:
3572         (updateMenuItemForHistoryItem): Added
3573         (showLastVisitedSites): Added
3574         (WinLauncherWebHost::didFinishLoadForFrame): Add history item once
3575         a new page has been visited.
3576         (dllLauncherEntryPoint): Deallocate history on exit.
3577         (NavigateToHistory): Added
3578         (WndProc): Add handler for history entries
3579         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add menu items to hold
3580         up to 10 history slots.
3581         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link against
3582         Windows utility library to allow use of _bstr_t type.
3583         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Add menu items
3584         to hold up to 10 history slots.
3585         * WinLauncher/stdafx.h: Add <comutil.h> to precompiled headers.
3586
3587 2013-09-16  Gustavo Noronha Silva  <gns@gnome.org>
3588
3589         [GTK] Make symbol export filter more strict, and disable for dev/test builds
3590         https://bugs.webkit.org/show_bug.cgi?id=120586
3591
3592         Reviewed by Martin Robinson.
3593
3594         * GNUmakefile.am: moved GtkLauncher and documentation builds to their own
3595         makefiles, so they can be included unconditionally.
3596         * GtkLauncher/GNUmakefile.am: added.
3597         * Scripts/webkitdirs.pm:
3598         (runAutogenForAutotoolsProjectIfNecessary): always pass --enable-developer-mode
3599         to configure, since we consider builds done through build-webkit to be development
3600         and test builds.
3601         * gtk/GNUmakefile.am: added.
3602         * gtk/common.py: do not use the Scripts directory as a reference to the top path;
3603         it's not necessary and it will not work now that the Scripts directory is not
3604         shipped in the tarball.
3605
3606 2013-09-16  Anders Carlsson  <andersca@apple.com>
3607
3608         WTF::Deque should work with move only types
3609         https://bugs.webkit.org/show_bug.cgi?id=121446
3610
3611         Reviewed by Andreas Kling.
3612
3613         * TestWebKitAPI/Tests/WTF/Deque.cpp:
3614         (TestWebKitAPI::TEST):
3615         Add a test.
3616
3617 2013-09-16  Wojciech Bielawski  <w.bielawski@samsung.com>
3618
3619         [WKTR] WebKitTestRunner's eventSender.contextClick() returns objects without implemented click() method.
3620         https://bugs.webkit.org/show_bug.cgi?id=98410
3621
3622         Reviewed by Darin Adler.
3623
3624         Add implementation of click() method of objects returned by eventSender.contextClick().
3625
3626         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3627         (MenuItemPrivateData):
3628         (WTR::menuItemClickCallback):
3629         (WTR::getMenuItemTitleCallback):
3630         (WTR::staticMenuItemFinalize):
3631         (WTR::getMenuItemClass):
3632         (WTR::EventSendingController::contextClick):
3633
3634 2013-09-15  Zan Dobersek  <zdobersek@igalia.com>
3635