Tools/ChangeLog

   1 2014-05-02  Simon Fraser  <simon.fraser@apple.com>
   2
   3         Fix several memory leaks found by code inspection
   4         https://bugs.webkit.org/show_bug.cgi?id=132472
   5
   6         Reviewed by Geoffrey Garen.
   7
   8         Fix memory leaks.
   9
  10         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
  11         (TestWebKitAPI::TEST):
  12         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  13         (WTR::InjectedBundlePage::willSendRequestForFrame):
  14         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
  15         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
  16
  17 2014-05-02  Filip Pizlo  <fpizlo@apple.com>
  18
  19         DFGAbstractInterpreter should not claim Int52 arithmetic creates Int52s
  20         https://bugs.webkit.org/show_bug.cgi?id=132446
  21
  22         Reviewed by Mark Hahnenberg.
  23
  24         Test the FTL by default now that it's enabled by default.
  25
  26         * Scripts/run-javascriptcore-tests:
  27
  28 2014-05-01  Ryuan Choi  <ryuan.choi@samsung.com>
  29
  30         [EFL][WK1] Drop ewk_view_setting_tiled_backingstore APIs
  31         https://bugs.webkit.org/show_bug.cgi?id=132240
  32
  33         Reviewed by Anders Carlsson.
  34
  35         Removed ewk_view_setting_tiled_backingstore related code.
  36
  37         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  38         (DumpRenderTreeChrome::createView):
  39         (shouldUseTiledBackingStore): Deleted.
  40         * EWebLauncher/main.c:
  41         (windowCreate):
  42         (parseUserArguments):
  43
  44 2014-05-01  Anders Carlsson  <andersca@apple.com>
  45
  46         window.testRunner.keepWebHistory() should update the UI process state
  47         https://bugs.webkit.org/show_bug.cgi?id=132440
  48
  49         Reviewed by Dan Bernstein.
  50
  51         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  52         (WTR::InjectedBundle::postSetAddsVisitedLinks):
  53         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
  54         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  55         (WTR::TestRunner::keepWebHistory):
  56         * WebKitTestRunner/TestInvocation.cpp:
  57         (WTR::TestInvocation::invoke):
  58         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
  59
  60 2014-05-01  David Kilzer  <ddkilzer@apple.com>
  61
  62         Really remove ENABLE_PLUGIN_PROXY_FOR_VIDEO
  63         <http://webkit.org/b/132432>
  64
  65         Reviewed by Tim Horton.
  66
  67         * Scripts/webkitperl/FeatureList.pm: Remove support for
  68         --plugin-proxy-for-video switch.
  69
  70 2014-04-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
  71
  72         Kernel sysctl interface hw.activecpu don't exists on Linux.
  73         https://bugs.webkit.org/show_bug.cgi?id=132286
  74
  75         Reviewed by Filip Pizlo.
  76
  77         * Scripts/run-jsc-stress-tests: Redirect stderr to null when
  78         calling sysctl over hw.activecpu
  79
  80 2014-04-30  Anders Carlsson  <andersca@apple.com>
  81
  82         Move the legacy WebKit API into WebKitLegacy.framework and move it inside WebKit.framework
  83         https://bugs.webkit.org/show_bug.cgi?id=132399
  84         <rdar://problem/15920046>
  85
  86         Reviewed by Dan Bernstein.
  87
  88         * Scripts/check-for-webkit-framework-include-consistency:
  89         Allos WAK headers in WebKitLegacy as well as WebKit.
  90
  91         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
  92         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
  93         Update header imports.
  94
  95 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
  96
  97         [iOS WK2] Add test URL to crash reports for the UI process, clean up project
  98         https://bugs.webkit.org/show_bug.cgi?id=131954
  99
 100         Reviewed by Darin Adler.
 101
 102         WebKitTestRunner was adding application-specific information to crash reports
 103         to log the test path, but only in the web process. Fix it to also do this
 104         for the UI process, for both iOS and OS X.
 105
 106         Moved InjectedBundlePageMac.mm to InjectedBundlePageCocoa.mm and compile it for
 107         both iOS and OS X.
 108
 109         Factored crash reprorter-related code into CrashReporterInfo, and call it from
 110         a new TestController::platformWillRunTest() function on Mac and iOS.
 111
 112         Also remove Xcode-added unit test junk from the project.
 113
 114         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
 115         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
 116         * WebKitTestRunner/TestController.cpp:
 117         (WTR::TestController::runTest):
 118         * WebKitTestRunner/TestController.h:
 119         * WebKitTestRunner/TestInvocation.cpp:
 120         (WTR::TestInvocation::url):
 121         * WebKitTestRunner/TestInvocation.h:
 122         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
 123         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Removed.
 124         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Removed.
 125         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Removed.
 126         * WebKitTestRunner/cocoa/CrashReporterInfo.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
 127         * WebKitTestRunner/cocoa/CrashReporterInfo.mm: Renamed from Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm.
 128         (WTR::testPathFromURL):
 129         (WTR::setCrashReportApplicationSpecificInformationToURL):
 130         * WebKitTestRunner/efl/TestControllerEfl.cpp:
 131         (WTR::TestController::platformWillRunTest):
 132         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
 133         (WTR::TestController::platformWillRunTest):
 134         * WebKitTestRunner/ios/TestControllerIOS.mm:
 135         (WTR::TestController::platformWillRunTest):
 136         (WTR::TestController::setHidden):
 137         * WebKitTestRunner/mac/TestControllerMac.mm:
 138         (WTR::TestController::platformWillRunTest):
 139
 140 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
 141
 142         Fix DRT assertion about mock scrollbars, which doesn't apply to iOS.
 143
 144         Reviewed by Tim Horton.
 145
 146         * DumpRenderTree/mac/DumpRenderTree.mm:
 147         (resetWebPreferencesToConsistentValues):
 148         (prepareConsistentTestingEnvironment):
 149
 150 2014-04-30  Anders Carlsson  <andersca@apple.com>
 151
 152         check-for-inappropriate-macros-in-external-headers should get the product name, not the project name
 153         https://bugs.webkit.org/show_bug.cgi?id=132397
 154
 155         Reviewed by Dan Bernstein.
 156
 157         * Scripts/check-for-inappropriate-macros-in-external-headers:
 158
 159 2014-04-29  Martin Robinson  <mrobinson@igalia.com>
 160
 161         [GTK] Make it easier to run CMake for downstreams
 162         https://bugs.webkit.org/show_bug.cgi?id=132370
 163
 164         Reviewed by Carlos Garcia Campos.
 165
 166         * Scripts/webkitdirs.pm:
 167         (generateBuildSystemFromCMakeProject): Pass -DDEVELOPER_MODE when building
 168         the GTK+ port.
 169
 170 2014-04-29  Stephanie Lewis  <slewis@apple.com>
 171
 172         <rdar://problem/16765765> Use JSON::PP in perl scripts instead of JSON.
 173
 174         Rubber stamped by Jessie Berlin.
 175
 176         JSON.pm was removed from our tools setup.
 177
 178         * Scripts/generate-coverage-data:
 179
 180 2014-04-29  Filip Pizlo  <fpizlo@apple.com>
 181
 182         Use LLVM as a backend for the fourth-tier DFG JIT (a.k.a. the FTL JIT)
 183         https://bugs.webkit.org/show_bug.cgi?id=112840
 184
 185         Rubber stamped by Geoffrey Garen.
 186
 187         * Scripts/build-jsc: Enable it on Mac.
 188         * Scripts/build-webkit: Enable it on Mac.
 189         * Scripts/export-llvm-build: Make it slightly easier to export the build if you've done a "make install".
 190
 191 2014-04-28  Sam Weinig  <sam@webkit.org>
 192
 193         REGRESSION (r167751): svn-create-patch is very slow
 194         https://bugs.webkit.org/show_bug.cgi?id=132300
 195
 196         Reviewed by Alexey Proskuryakov.
 197
 198         * Scripts/svn-create-patch:
 199         Change default behavior of svn-create-patch to no longer run the style checker. It can still be run
 200         by calling `svn-create-patch --style`.
 201
 202 2014-04-29  Enrique Ocaña González  <eocanha@igalia.com>
 203
 204         Generate Eclipse project + ninja build for GTK+ if Eclipse in available in the PATH
 205         https://bugs.webkit.org/show_bug.cgi?id=132190
 206
 207         Reviewed by Gustavo Noronha Silva.
 208
 209         * Scripts/webkitdirs.pm:
 210         (canUseEclipse): Test if Eclipse is in the path. This is the same method used to test
 211             if ninja is in the path.
 212         (generateBuildSystemFromCMakeProject): Use the eclipse generator if possible, fallback
 213             to the previous ninja generator if not.
 214
 215 2014-04-29  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
 216
 217         check-webkit-style should understand --git-index
 218         https://bugs.webkit.org/show_bug.cgi?id=125364
 219
 220         Reviewed by Csaba Osztrogonác.
 221
 222         * Scripts/webkitpy/common/checkout/scm/git.py:
 223         (Git.create_patch): The command now supports the --cached option.
 224         * Scripts/webkitpy/style/main.py:
 225         (CheckWebKitStyle.main): Passing the --git-index option.
 226         * Scripts/webkitpy/style/optparser.py:
 227         (CommandOptionValues.__init__): The git-index option is switched off by default.
 228         (CommandOptionValues.__eq__): Equality check for the new option.
 229         (ArgumentParser._create_option_parser):Adding the --git-index option
 230         (ArgumentParser.parse):
 231         * Scripts/webkitpy/style/optparser_unittest.py: New tests for the --git-index option
 232         (CommandOptionValuesTest.test_init):
 233         (CommandOptionValuesTest.test_eq):
 234
 235 2014-04-28  Michael Saboff  <msaboff@apple.com>
 236
 237         Crash in platform/mac/accessibility/table-visible-rows.html
 238         https://bugs.webkit.org/show_bug.cgi?id=132146
 239
 240         Reviewed by Filip Pizlo.
 241
 242         Instead of creating a local JSValueRef array on the stack and passing that to
 243         JSObjectMakeArray(), changed to create an empty JSArray and then populate the
 244         values using the JSObjectSetPropertyAtIndex() API.
 245
 246         * DumpRenderTree/AccessibilityUIElement.cpp:
 247         (elementsForRangeCallback):
 248         (convertElementsToObjectArray):
 249         * DumpRenderTree/mac/TestRunnerMac.mm:
 250         (originsArrayToJS):
 251         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
 252         (WTR::EventSendingController::contextClick):
 253         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
 254         (WTR::stringArrayToJS):
 255         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
 256         (WTR::convertElementsToObjectArray):
 257
 258 2014-04-28  Filip Pizlo  <fpizlo@apple.com>
 259
 260         Make sure that the coverage of our tests doesn't change much if we change the thresholds now and in the future, but making
 261         "no-cjit" runs force the old-school threshold.
 262
 263         Rubber stamped by Mark Hahnenberg.
 264
 265         * Scripts/run-jsc-stress-tests:
 266
 267 2014-04-28  Carlos Alberto Lopez Perez  <clopez@igalia.com>
 268
 269         [GTK] install-dependencies should also install ruby-json and ruby-highline
 270         https://bugs.webkit.org/show_bug.cgi?id=132292
 271
 272         Reviewed by Philippe Normand.
 273
 274         * gtk/install-dependencies: Install ruby json and highline packages.
 275
 276 2014-04-27  Joonghun Park  <jh718.park@samsung.com>
 277
 278         [EFL] Remove indexedDB's dependency on leveldb and disable indexedDB
 279         https://bugs.webkit.org/show_bug.cgi?id=132176
 280
 281         Reviewed by Gyuyoung Kim.
 282
 283         EFL port will use sqlite to support indexedDB. So, this patch removes levelDB dependency
 284         and turn off indexedDB feature until the sqlite implementation is introduced.
 285
 286         * Scripts/webkitperl/FeatureList.pm:
 287
 288 2014-04-25  James Craig  <jcraig@apple.com>
 289
 290         Set prepare-Changelog flag so that it no longer runs check-webkit-style by default
 291         https://bugs.webkit.org/show_bug.cgi?id=132209
 292
 293         Reviewed by Daniel Bates.
 294
 295         Set default to --no-style to avoid additional spew from false positives in check-webkit-style.
 296         Run check-webkit-style before generating changelogs to avoid additional spurious errors.
 297
 298         * Scripts/prepare-ChangeLog:
 299         (main):
 300
 301 2014-04-25  Michael Saboff  <msaboff@apple.com>
 302
 303         Crash in platform/mac/accessibility/table-visible-rows.html
 304         https://bugs.webkit.org/show_bug.cgi?id=132146
 305
 306         Reviewed by Mark Lam.
 307
 308         Changed to use a local JSValueRef array temporary instead of a
 309         std::make_unique<JSValueRef[]> when making an array of JSValues so that the temporary
 310         JSValues are visited during garbage collection when the stack is scanned.  Otherwise,
 311         the temporary values could be collected.
 312
 313         * DumpRenderTree/AccessibilityUIElement.cpp:
 314         (convertElementsToObjectArray):
 315         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
 316         (WTR::EventSendingController::contextClick):
 317         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
 318         (WTR::convertElementsToObjectArray):
 319
 320 2014-04-24  Eduardo Lima Mitev  <elima@igalia.com>
 321
 322         Unreviewed GTK gardening
 323
 324         * Scripts/run-gtk-tests: Skips one flaky accesibility test in WK2API suite
 325         (TestRunner):
 326
 327 2014-04-24  László Langó  <llango.u-szeged@partner.samsung.com>
 328
 329         prepare-ChangeLog reports as deleted methods that has not been removed.
 330         https://bugs.webkit.org/show_bug.cgi?id=131733
 331
 332         Reviewed by Ryosuke Niwa.
 333
 334         * Scripts/prepare-ChangeLog:
 335         (originalFile): Set merge base to origin/master by default.
 336
 337 2014-04-23  James Craig  <jcraig@apple.com>
 338
 339         prepare-Changelog and svn-create-patch should optionally run check-webkit-style.
 340         https://bugs.webkit.org/show_bug.cgi?id=131115
 341
 342         Reviewed by Daniel Bates.
 343
 344         Added [--[no-]style] param to run check-webkit-style as part of prepare-Changelog and svn-create-patch.
 345
 346         * Scripts/commit-log-editor: Added --no-style.
 347         * Scripts/prepare-ChangeLog: Primary patch.
 348         (main): Primary patch.
 349         (createPatchCommand): Added --no-style.
 350         * Scripts/svn-create-patch: Primary patch.
 351         * Scripts/webkit-tools-completion.sh: Added --style and --no-style.
 352         * Scripts/webkitpy/common/checkout/scm/svn.py: Added --no-style.
 353         (SVN.create_patch): Added --no-style.
 354
 355 2014-04-23  Anders Carlsson  <andersca@apple.com>
 356
 357         Try to fix iOS build.
 358
 359         * DumpRenderTree/mac/DumpRenderTree.mm:
 360
 361 2014-04-23  Alexey Proskuryakov  <ap@apple.com>
 362
 363         Eliminate internals.setMockScrollbarsEnabled()
 364         https://bugs.webkit.org/show_bug.cgi?id=132085
 365
 366         Reviewed by Tim Horton.
 367
 368         * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues):
 369         No need to reset the preference, there is no way it can change.
 370
 371 2014-04-23  James Craig  <jcraig@apple.com>
 372
 373         Unreviewed. Moving myself from Contributors to Committers list.
 374
 375         * Scripts/webkitpy/common/config/contributors.json:
 376
 377 2014-04-23  Tim Horton  <timothy_horton@apple.com>
 378
 379         Mock scrollbars don't always work in DumpRenderTree
 380         https://bugs.webkit.org/show_bug.cgi?id=132082
 381
 382         Reviewed by Alexey Proskuryakov.
 383
 384         * DumpRenderTree/mac/DumpRenderTree.mm:
 385         (prepareConsistentTestingEnvironment):
 386         Set the mock scrollbar setting before creating the WebView, as this setting
 387         cannot be dynamically changed, so any scrollbars that are created during
 388         WebView initialization and are not replaced before snapshotting will end
 389         up being platform scrollbars instead of mock ones.
 390         WebKitTestRunner already sets this preference before creating WKViews,
 391         so we're just matching its behavior.
 392
 393 2014-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
 394
 395         [GTK] ShadowRoot API was removed in r164131
 396         https://bugs.webkit.org/show_bug.cgi?id=132059
 397
 398         Reviewed by Gustavo Noronha Silva.
 399
 400         Add WebKitDOMShadowRoot to the list of deleted classes to generate
 401         the API docs.
 402
 403         * gtk/webkitdom.py:
 404         (WebKitDOMDocGenerator):
 405
 406 2014-04-23  Lorenzo Tilve  <ltilve@igalia.com>
 407
 408         [GTK] run-webkit-tests script is failing to invoke run-launcher
 409         https://bugs.webkit.org/show_bug.cgi?id=132051
 410
 411         Reviewed by Philippe Normand.
 412
 413         After the WK1 support was dropped, if run-webkit-tests is executed
 414         without --no-show-results parameter, the launcher is being called
 415         using a -2 parameter that is it causing the run-launcher to break.
 416
 417         * Scripts/webkitpy/port/gtk.py:
 418         (GtkPort.show_results_html_file):
 419
 420 2014-04-22  Tim Horton  <timothy_horton@apple.com>
 421
 422         DumpRenderTree generates black snapshots on some platforms
 423         https://bugs.webkit.org/show_bug.cgi?id=132029
 424         <rdar://problem/16679363>
 425
 426         Reviewed by Simon Fraser.
 427
 428         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
 429         (createBitmapContextFromWebView):
 430         DRT checks with the WebView to determine whether it can use the window's
 431         backing store directly or (because of compositing) needs to take a WindowServer
 432         snapshot. However, on some platforms and in some situations, the window can
 433         be layer backed without the WebView necessarily currently being composited.
 434         We should check with the window in addition to the WebView before going
 435         ahead and using its backing store.
 436
 437 2014-04-22  Tim Horton  <timothy_horton@apple.com>
 438
 439         DumpRenderTree generates white snapshots on some platforms
 440         https://bugs.webkit.org/show_bug.cgi?id=132026
 441         <rdar://problem/16679363>
 442
 443         Reviewed by Simon Fraser.
 444
 445         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
 446         Link DRT against QuartzCore.
 447
 448         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
 449         (createBitmapContextFromWebView):
 450         Force CoreAnimation to synchronously update layers in a more explicit
 451         way that doesn't depend on AppKit behavior. This is very similar to what
 452         WebKitTestRunner does (indirectly) during its force repaint.
 453
 454 2014-04-22  Brent Fulgham  <bfulgham@apple.com>
 455
 456         [Win] Support Python 2.7 in Cygwin
 457         https://bugs.webkit.org/show_bug.cgi?id=132023
 458
 459         Reviewed by Michael Saboff.
 460
 461         * Scripts/webkitdirs.pm:
 462         (checkInstalledTools): Remove check for Python 2.7, since
 463         it now works properly.
 464
 465 2014-04-22  Filip Pizlo  <fpizlo@apple.com>
 466
 467         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
 468         https://bugs.webkit.org/show_bug.cgi?id=130867
 469         <rdar://problem/16432456>
 470
 471         Reviewed by Mark Hahnenberg.
 472
 473         * Scripts/build-webkit:
 474         * Scripts/copy-webkitlibraries-to-product-directory:
 475
 476 2014-04-22  Gustavo Noronha Silva  <gns@gnome.org>
 477
 478         [GTK] Fails to build documentation when output is redirected
 479         https://bugs.webkit.org/show_bug.cgi?id=131178
 480
 481         Reviewed by Martin Robinson.
 482
 483         * gtk/generate-gtkdoc: set the output for stdout and stderr to UTF-8
 484         explicitly to avoid encoding issues when they are redirected.
 485
 486 2014-04-22  ChangSeok Oh  <changseok.oh@collabora.com>
 487
 488         [GTK] YCM choose a newer compile_commands.json in between Release or Debug
 489         https://bugs.webkit.org/show_bug.cgi?id=131911
 490
 491         Reviewed by Martin Robinson.
 492
 493         common.get_build_path returns release path even though Debug configuration
 494         is newer than Release. So YouCompleteMe is used to refer old build setup inadvertently.
 495
 496         * gtk/ycm_extra_conf.py:
 497         (get_build_path): Compare modified time of Release and Debug. And return a recent modified path.
 498         (FlagsForFile):
 499
 500 2014-04-21  Brent Fulgham  <bfulgham@apple.com>
 501
 502         Unreviewed build fix.
 503
 504         * DumpRenderTree/mac/EventSendingController.mm:
 505         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
 506         Correct a typo that prevented tests from working properly.
 507
 508 2014-04-21  Martin Robinson  <mrobinson@igalia.com>
 509
 510         [GTK] Should have the ability to output composited contents during layout testing
 511         https://bugs.webkit.org/show_bug.cgi?id=131864
 512
 513         Reviewed by Philippe Normand.
 514
 515         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
 516         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Add a path that paints the widget contents
 517         to an image surface. We run the main loop a bit to match the implementation from WebKit1 and EFL.
 518         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
 519         (WTR::PlatformWebView::windowSnapshotImage): Use the new UI-process path on GTK+.
 520
 521 2014-04-21  Sam Weinig  <sam@webkit.org>
 522
 523         Attempt to fix the tests.
 524
 525         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
 526         (-[DidFailProvisionalNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
 527         Add policy handler to override the new default of denying loads that NSURLConnection cannot handle.
 528
 529 2014-04-21  Filip Pizlo  <fpizlo@apple.com>
 530
 531         Unreviewed test gardening, make no-eager runs run everything except eager (as opposed to
 532         being the same as a "quick run", which is meant for genuinely slow tests).
 533
 534         * Scripts/run-jsc-stress-tests:
 535
 536 2014-04-21  Darin Adler  <darin@apple.com>
 537
 538         Add HashSet::takeAny
 539         https://bugs.webkit.org/show_bug.cgi?id=131928
 540
 541         Reviewed by Benjamin Poulain.
 542
 543         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Added a test for takeAny.
 544
 545 2014-04-20  Dan Bernstein  <mitz@apple.com>
 546
 547         Fixed a test timing out after r167572.
 548
 549         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
 550         (-[NavigationDelegate webView:didFinishNavigation:]): Renamed from
 551         -webView:didFinishLoadingNavigation:.
 552
 553 2014-04-20  Commit Queue  <commit-queue@webkit.org>
 554
 555         Unreviewed, rolling out r167510.
 556         https://bugs.webkit.org/show_bug.cgi?id=131915
 557
 558         broke GTK Debug bot (Requested by philn on #webkit).
 559
 560         Reverted changeset:
 561
 562         "[GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force
 563         it when running layout tests"
 564         https://bugs.webkit.org/show_bug.cgi?id=131472
 565         http://trac.webkit.org/changeset/167510
 566
 567 2014-04-18  Martin Robinson  <mrobinson@igalia.com>
 568
 569         [GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
 570         https://bugs.webkit.org/show_bug.cgi?id=131472
 571
 572         Reviewed by Philippe Normand.
 573
 574         * Scripts/webkitpy/port/gtk.py:
 575         (GtkPort.setup_environ_for_server): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
 576         when running WebKitTestRunner with run-webkit-tests.
 577         * gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not
 578         installed.
 579         * gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows
 580         how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
 581         calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
 582         deal.
 583
 584 2014-04-18  Alexey Proskuryakov  <ap@apple.com>
 585
 586         DownloadDecideDestinationCrash API test uses an incorrect value for path
 587         https://bugs.webkit.org/show_bug.cgi?id=131845
 588         <rdar://problem/15925560>
 589
 590         Reviewed by Enrica Casucci.
 591
 592         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
 593         (TestWebKitAPI::decideDestinationWithSuggestedFilename):
 594
 595 2014-04-17  Alexey Proskuryakov  <ap@apple.com>
 596
 597         [Mac] AttributedStringTest API tests fail with async text input
 598         https://bugs.webkit.org/show_bug.cgi?id=131833
 599
 600         Reviewed by Enrica Casucci.
 601
 602         Don't run sync NSTextInputClient tests where we don't implement these calls.
 603
 604         * TestWebKitAPI/Tests/mac/AttributedString.mm:
 605         (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
 606         (TestWebKitAPI::AttributedStringTest_CustomFont::runSyncTest):
 607         (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
 608         (TestWebKitAPI::AttributedStringTest_Strikethrough::runSyncTest):
 609         (TestWebKitAPI::AttributedStringTest_CustomFont::runTest): Deleted.
 610         (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest): Deleted.
 611
 612 2014-04-18  Philippe Normand  <pnormand@igalia.com>
 613
 614         Remove NETWORK_INFO support
 615         https://bugs.webkit.org/show_bug.cgi?id=131841
 616
 617         Reviewed by Gyuyoung Kim.
 618
 619         * Scripts/webkitperl/FeatureList.pm:
 620
 621 2014-04-17  ChangSeok Oh  <changseok.oh@collabora.com>
 622
 623         [GTK] YouCompleteMe doesn't work for cmake build system.
 624         https://bugs.webkit.org/show_bug.cgi?id=131591
 625
 626         Reviewed by Martin Robinson.
 627
 628         Add cmake build system support for YouCompleteMe. It should work regardless of
 629         using make or ninja. In addition, autotools related code is removed since it's
 630         not used anymore in WebKit.
 631
 632         * Scripts/webkitdirs.pm:
 633         (generateBuildSystemFromCMakeProject):
 634         * gtk/ycm_extra_conf.py:
 635         (transform_relative_paths_to_absolute_paths):
 636         (FlagsForFile):
 637
 638 2014-04-17  Anders Carlsson  <andersca@apple.com>
 639
 640         Fix build.
 641
 642         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
 643         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
 644         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
 645
 646 2014-04-17  Anders Carlsson  <andersca@apple.com>
 647
 648         Remove unused API enums
 649         https://bugs.webkit.org/show_bug.cgi?id=131836
 650
 651         Reviewed by Tim Horton.
 652
 653         * MiniBrowser/mac/WK2BrowserWindowController.m:
 654         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
 655
 656 2014-04-16  Brent Fulgham  <bfulgham@apple.com>
 657
 658         [Win] A few final cleanups to the DataObject classes.
 659         https://bugs.webkit.org/show_bug.cgi?id=131784
 660
 661         Reviewed by Anders Carlsson.
 662
 663         * DumpRenderTree/win/DRTDataObject.cpp:
 664         (DRTDataObject::clearData): Use 'last()' method.
 665         * DumpRenderTree/win/UIDelegate.cpp:
 666         (DRTUndoStack::pop): Use 'takeLast()' method.
 667
 668 2014-04-17  Andres Gomez  <agomez@igalia.com>
 669
 670         [Win] cygwin to keep installing curl 7.33.0-1 and subversion 1.7.14-1
 671         https://bugs.webkit.org/show_bug.cgi?id=131365
 672
 673         Reviewed by Brent Fulgham.
 674
 675         The cygwin installer is now downloading the wanted versions for
 676         the local installation given to the setup wizard.
 677
 678         * CygwinDownloader/cygwin-downloader.py:
 679         * CygwinDownloader/cygwin-downloader.zip:
 680
 681 2014-04-17  Adrian Perez de Castro  <aperez@igalia.com>
 682
 683         [GTK] Make run-webkit-tests always use WKTR
 684         https://bugs.webkit.org/show_bug.cgi?id=131737
 685
 686         Reviewed by Darin Adler.
 687
 688         Now that the GTK+ port only has support for WebKit2, instruct
 689         run-webkit-tests to always use WKTR. This avoids needing to pass
 690         flag "-2" every time.
 691
 692         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 693         (_set_up_derived_options): Always set webkit_test_runner when
 694         the platform is GTK+.
 695
 696 2014-04-17  Brendan Long  <b.long@cablelabs.com>
 697
 698         [Gtk] Install ninja-build in Tools/gtk/install-dependencies
 699         https://bugs.webkit.org/show_bug.cgi?id=131760
 700
 701         Reviewed by Philippe Normand.
 702
 703         * gtk/install-dependencies: Install ninja-build when it's available.
 704
 705 2014-04-16  peavo@outlook.com  <peavo@outlook.com>
 706
 707         [Win] run-javascriptcore-tests fails to run.
 708         https://bugs.webkit.org/show_bug.cgi?id=131761
 709
 710         Reviewed by Brent Fulgham.
 711
 712         * Scripts/build-jsc: For now, don't try to build bmalloc on Windows.
 713
 714 2014-04-16  Andres Gomez  <agomez@igalia.com>
 715
 716         [Win] Pass default parameters to cygwin setup wizard
 717         https://bugs.webkit.org/show_bug.cgi?id=131361
 718
 719         Reviewed by Brent Fulgham.
 720
 721         Added some parameters to the cygwin setup wizard so the user
 722         doesn't really have to do any interaction.
 723
 724         * CygwinDownloader/cygwin-downloader.py:
 725         * CygwinDownloader/cygwin-downloader.zip:
 726
 727 2014-04-15  Brent Fulgham  <bfulgham@apple.com>
 728
 729         [Win] Eliminate use of deleteAllValues in Windows Files
 730         https://bugs.webkit.org/show_bug.cgi?id=131631
 731
 732         Reviewed by Darin Adler.
 733
 734         Switch to std::unique_ptr for memory lifetime. Get rid of
 735         deleteAllValues now that it is no longer needed. Use ranged
 736         for loops where possible.
 737
 738         * DumpRenderTree/win/DRTDataObject.cpp:
 739         (WCEnumFormatEtc::WCEnumFormatEtc):
 740         (DRTDataObject::~DRTDataObject):
 741         (DRTDataObject::GetData):
 742         (DRTDataObject::QueryGetData):
 743         (DRTDataObject::SetData):
 744         (DRTDataObject::clearData):
 745         * DumpRenderTree/win/DRTDataObject.h:
 746         * DumpRenderTree/win/UIDelegate.cpp:
 747         (DRTUndoObject::DRTUndoObject):
 748         (DRTUndoObject::~DRTUndoObject):
 749         (DRTUndoStack::~DRTUndoStack):
 750         (DRTUndoStack::clear):
 751         (DRTUndoStack::pop):
 752         (DRTUndoManager::DRTUndoManager):
 753         (DRTUndoManager::redo):
 754         (DRTUndoManager::undo):
 755         (UIDelegate::UIDelegate):
 756         (UIDelegate::resetUndoManager):
 757         * DumpRenderTree/win/UIDelegate.h:
 758
 759 2014-04-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
 760
 761         [GTK] Unreviewed GTK gardening.
 762
 763         Update list of skipped unit tests:
 764
 765           Skip test: WebKit2Gtk/TestWebKitWebView:/webkit2/WebKitWebView/page-visibility
 766
 767           Unskip tests: WebKit2/TestWebKit2:WebKit2.ResizeReversePaginatedWebView
 768           and WebKit2/TestWebKit2:WebKit2.ScrollPinningBehaviors
 769
 770         * Scripts/run-gtk-tests:
 771         (TestRunner):
 772
 773 2014-04-16  Tim Horton  <timothy_horton@apple.com>
 774
 775         check-webkit-style doesn't check code style in .mm or .m files
 776         https://bugs.webkit.org/show_bug.cgi?id=131708
 777
 778         Reviewed by Darin Adler.
 779
 780         * Scripts/webkitpy/style/checker.py:
 781         * Scripts/webkitpy/style/checker_unittest.py:
 782         (CheckerDispatcherDispatchTest.test_cpp_paths):
 783         (CheckerDispatcherDispatchTest.test_text_paths):
 784         Check .mm and .m files as C++.
 785
 786         * Scripts/webkitpy/style/checkers/cpp.py:
 787         (check_spacing):
 788         Add an override for our ordinary "missing spaces around =" for @synthesize,
 789         which should look like "@synthesize propertyName=_varName;"
 790
 791         Add an override for "missing space before {" for blocks' "^{".
 792
 793         Don't follow the "extra space before [" rule for Objective-C, because
 794         it breaks this rule in a multitude of ways because of method calls.
 795
 796         (check_braces):
 797         Don't complain about { not being on the end of the previous line if
 798         the previous line starts with "- (" or "+ (", which would indicate a
 799         Objective-C method definition.
 800
 801 2014-04-16  Darin Adler  <darin@apple.com>
 802
 803         Make Vector::takeLast work with move-only types (and optimize for types where move is faster)
 804         https://bugs.webkit.org/show_bug.cgi?id=131735
 805
 806         Reviewed by Alexey Proskuryakov.
 807
 808         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added a test for Vector::takeLast with move only types.
 809         Fixed invocations of EXPECT macros so the expected value is on the left, and the test result
 810         is on the right. This can be confusing since our JavaScript test framework does it the opposite
 811         way, but gtest works better this way.
 812
 813 2014-04-15  Hyowon Kim  <hw1008.kim@samsung.com>
 814
 815         [EFL] Fix problems with the pixel dump.
 816         https://bugs.webkit.org/show_bug.cgi?id=131265
 817
 818         Reviewed by Gyuyoung Kim.
 819
 820         Painting and compositing paths of WebKit-EFL were totally modified from r166768.
 821         However pixel dump codes still call deprecated functions like ewk_view_paint(),
 822         which causes that nothing is drawn.
 823
 824         This patch adds new member functions to AcceleratedCompositingContext to support pixel dump.
 825         One of new functions is AcceleratedCompositingContext::extractImageData(),
 826         which replaces deprecated function calls. Besides the extractImageData() is invoked by
 827         ewk_view_screenshot_contents_get() in order to take the visible content displayed on the EFL webview.
 828
 829         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
 830         (createBitmapContextFromWebView): Add to call DumpRenderTreeSupportEfl::forcePaint().
 831
 832 2014-04-15  Filip Pizlo  <fpizlo@apple.com>
 833
 834         Update LLVM export scrpt to handle the build directory being different from the
 835         source directory.
 836
 837         Rubber stamped by Geoffrey Garen.
 838
 839         * Scripts/export-llvm-build:
 840
 841 2014-04-15  Ryosuke Niwa  <rniwa@webkit.org>
 842
 843         Update the hyperlink to waterfall views of perf bots on build.webkit.org
 844         https://bugs.webkit.org/show_bug.cgi?id=131695
 845
 846         Reviewed by Antti Koivisto.
 847
 848         Updated.
 849
 850         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
 851
 852 2014-04-15  Carlos Garcia Campos  <cgarcia@igalia.com>
 853
 854         [GTK] Reduce the binary size by compressing the text based web inspector resources
 855         https://bugs.webkit.org/show_bug.cgi?id=121545
 856
 857         Reviewed by Gustavo Noronha Silva.
 858
 859         Compress text based files when compiling inspector resources. It
 860         reduces the binary size in 3MB.
 861
 862         * gtk/generate-inspector-gresource-manifest.py:
 863         (find_all_files_in_directory):
 864         (is_compressible):
 865
 866 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
 867
 868         Remove Gtk WebKit1 tester.
 869
 870         Gtk WebKit1 port no longer exists, and dashboard was trying to load its tester
 871         results over and over as fast as it could.
 872
 873         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
 874         (WebKitBuildbot):
 875
 876 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
 877
 878         Wrong link for webkitpy tests results in dashboard popover
 879         https://bugs.webkit.org/show_bug.cgi?id=131664
 880
 881         Reviewed by Timothy Hatcher.
 882
 883         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
 884         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
 885         Use a correct link.
 886
 887 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
 888
 889         Update webkitpy regression test result that started to fail after http://trac.webkit.org/r167243
 890
 891         I'm not sure whether the changes are desirable, but am not suspicious enough to roll out.
 892
 893         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
 894         (CommitMessageForThisCommitTest):
 895
 896 2014-04-14  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
 897
 898         Fix commit-log-editor bug revealed by r165447
 899         https://bugs.webkit.org/show_bug.cgi?id=130676
 900
 901         Reviewed by Csaba Osztrogonác.
 902
 903         * Scripts/commit-log-editor:
 904         (createCommitMessage): Omitting empty Source/JavaScriptCore:... blocks.
 905         Add \n before the first block too, because the longest common prefix now ends with only one newline.
 906         (removeLongestCommonPrefixEndingInNewline): The longest common prefix ends with only one newline,
 907         now the last block of the common prefix isn't duplicated below. Changing the function name accordingly.
 908
 909 2014-04-13  Darin Adler  <darin@apple.com>
 910
 911         userVisibleString should not try to "encode" host names
 912         https://bugs.webkit.org/show_bug.cgi?id=131587
 913         rdar://problem/14686849
 914
 915         Reviewed by Alexey Proskuryakov.
 916
 917         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added URLExtras.mm.
 918
 919         * TestWebKitAPI/Tests/mac/URLExtras.mm: Added. A few tests for WebCoreNSURLExtras.
 920         Coverage is tiny at this point; we could add a lot more cases!
 921
 922 2014-04-13  Jaehun Lim  <ljaehun.lim@samsung.com>
 923
 924         Use #include instead of #import
 925         https://bugs.webkit.org/show_bug.cgi?id=131604
 926
 927         Reviewed by Darin Adler.
 928
 929         Fix "warning: #import is a deprecated GCC extension [-Wdeprecated]".
 930
 931         * TestWebKitAPI/Tests/WTF/StringView.cpp:
 932
 933 2014-04-12  Filip Pizlo  <fpizlo@apple.com>
 934
 935         Make slow-stress tests run faster by running fewer VM variants.
 936
 937         Rubber stamped by Geoffrey Garen.
 938
 939         * Scripts/run-javascriptcore-tests:
 940         * Scripts/run-jsc-stress-tests:
 941
 942 2014-04-10  Zan Dobersek  <zdobersek@igalia.com>
 943
 944         [CMake] Add missing WTF unit tests
 945         https://bugs.webkit.org/show_bug.cgi?id=131459
 946
 947         Reviewed by Martin Robinson.
 948
 949         * TestWebKitAPI/CMakeLists.txt: Add a few missing source files
 950         that should be compiled into the TestWTF binary.
 951
 952 2014-04-10  Brendan Long  <b.long@cablelabs.com>
 953
 954         [Gtk] run-launcher doesn't work by default
 955         https://bugs.webkit.org/show_bug.cgi?id=131494
 956
 957         Reviewed by Philippe Normand.
 958
 959         * Scripts/run-launcher: Always use MiniBrowser for WebKitGTK.
 960         * Scripts/webkitdirs.pm:
 961         (launcherName): Same.
 962         * Scripts/webkitpy/style/checker.py: Remove reference to GtkLauncher.
 963         * gtk/common.py:
 964         (get_build_path.is_valid_build_directory): Same.
 965         * gtk/manifest.txt: Same.
 966
 967 2014-04-09  Commit Queue  <commit-queue@webkit.org>
 968
 969         Unreviewed, rolling out r167046.
 970         https://bugs.webkit.org/show_bug.cgi?id=131479
 971
 972         Caused 300+ failures on Mavericks WK1 tester (Requested by ap
 973         on #webkit).
 974
 975         Reverted changeset:
 976
 977         "Remove "System Font" from whitelisted DRT fonts and char
 978         width calculations"
 979         https://bugs.webkit.org/show_bug.cgi?id=131411
 980         http://trac.webkit.org/changeset/167046
 981
 982 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
 983
 984         Remove "System Font" from whitelisted DRT fonts and char width calculations
 985         https://bugs.webkit.org/show_bug.cgi?id=131411
 986
 987         Reviewed by Tim Horton.
 988
 989         Covered by existing tests.
 990
 991         * DumpRenderTree/mac/DumpRenderTree.mm:
 992         (allowedFontFamilySet):
 993
 994 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
 995
 996         systemHiddenFontFamilySet in DRT is unnecessary
 997         https://bugs.webkit.org/show_bug.cgi?id=131414
 998
 999         Reviewed by Tim Horton.
1000
1001         It doesn't seem to affect test results on my machine.
1002
1003         * DumpRenderTree/mac/DumpRenderTree.mm:
1004         (drt_NSFontManager_availableFonts):
1005         (systemHiddenFontFamilySet): Deleted.
1006
1007 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
1008
1009         [Win] Unreviewed test fix: Don't double-release BSTR.
1010
1011         * DumpRenderTree/win/DumpRenderTree.cpp:
1012         (dump): Remove unneeded call to SysFreeString now that we are
1013         using _bstr_t for this variable.
1014
1015 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
1016
1017         [Win] Various DumpRenderTree Fixes.
1018         https://bugs.webkit.org/show_bug.cgi?id=131446.
1019
1020         Reviewed by Tim Horton.
1021
1022         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1023         (AccessibilityUIElement::title): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1024         (AccessibilityUIElement::description): Ditto.
1025         (AccessibilityUIElement::helpText): Ditto.
1026         (AccessibilityUIElement::intValue): Ditto.
1027         (AccessibilityUIElement::isPressActionSupported): Ditto.
1028         (AccessibilityUIElement::accessibilityValue): Ditto.
1029         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1030         (DRTDesktopNotificationPresenter::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1031         (DRTDesktopNotificationPresenter::AddRef): Ditto.
1032         (DRTDesktopNotificationPresenter::Release): Ditto.
1033         (DRTDesktopNotificationPresenter::showDesktopNotification): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1034         (DRTDesktopNotificationPresenter::cancelDesktopNotification): Ditto.
1035         (DRTDesktopNotificationPresenter::notificationDestroyed): Ditto.
1036         (DRTDesktopNotificationPresenter::checkNotificationPermission): Ditto.
1037         (DRTDesktopNotificationPresenter::requestNotificationPermission): Ditto.
1038         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
1039         * DumpRenderTree/win/DumpRenderTree.cpp:
1040         (dumpFrameScrollPosition): Ditto.
1041         (dumpFramesAsText): Ditto.
1042         (compareHistoryItems): Ditto.
1043         (dumpHistoryItem): Ditto.
1044         (dump): Ditto.
1045         (resetDefaultsToConsistentValues): Ditto.
1046         (resetWebViewToConsistentStateBeforeTesting): Ditto.
1047         (runTest): Ditto.
1048         (createWebViewAndOffscreenWindow): Ditto.
1049         * DumpRenderTree/win/EditingDelegate.cpp:
1050         (EditingDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1051         (EditingDelegate::AddRef): Ditto.
1052         (EditingDelegate::Release): Ditto.
1053         (dumpPath): Switch to _bstr_t. Use JSStringCreateWithBSTR
1054         (EditingDelegate::shouldBeginEditingInDOMRange): Get rid of uneeded STDMETHODCALLTYPE declaration.
1055         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
1056         (EditingDelegate::shouldInsertNode): Ditto.
1057         (EditingDelegate::shouldInsertText): Ditto.
1058         (EditingDelegate::shouldDeleteDOMRange): Ditto.
1059         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
1060         (EditingDelegate::shouldApplyStyle): Ditto.
1061         (EditingDelegate::shouldChangeTypingStyle): Ditto.
1062         (EditingDelegate::doPlatformCommand): Ditto.
1063         (EditingDelegate::webViewDidBeginEditing): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1064         (EditingDelegate::webViewDidChange): Ditto.
1065         (EditingDelegate::webViewDidEndEditing): Ditto.
1066         (EditingDelegate::webViewDidChangeTypingStyle): Ditto.
1067         (EditingDelegate::webViewDidChangeSelection): Ditto.
1068         (EditingDelegate::checkSpellingOfString): Ditto.
1069         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1070         (descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1071         (FrameLoadDelegate::FrameLoadDelegate): Ditto.
1072         (FrameLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1073         (FrameLoadDelegate::AddRef): Ditto.
1074         (FrameLoadDelegate::Release): Ditto.
1075         (FrameLoadDelegate::didStartProvisionalLoadForFrame): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1076         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
1077         (FrameLoadDelegate::didFailProvisionalLoadWithError): Ditto.
1078         (FrameLoadDelegate::didCommitLoadForFrame): Ditto.
1079         (FrameLoadDelegate::didReceiveTitle): Ditto.
1080         (FrameLoadDelegate::didChangeIcons): Ditto.
1081         (delegatesWithDelayedWork): Ditto.
1082         (FrameLoadDelegate::didFinishLoadForFrame): Ditto.
1083         (FrameLoadDelegate::didFailLoadWithError): Ditto.
1084         (FrameLoadDelegate::willPerformClientRedirectToURL): Ditto.
1085         (FrameLoadDelegate::didCancelClientRedirectForFrame): Ditto.
1086         (FrameLoadDelegate::willCloseFrame): Ditto.
1087         (FrameLoadDelegate::didFinishDocumentLoadForFrame): Ditto.
1088         (FrameLoadDelegate::didHandleOnloadEventsForFrame): Ditto.
1089         (FrameLoadDelegate::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
1090         (FrameLoadDelegate::didDisplayInsecureContent): Ditto.
1091         (FrameLoadDelegate::didRunInsecureContent): Ditto.
1092         * DumpRenderTree/win/FrameLoadDelegate.h:
1093         * DumpRenderTree/win/HistoryDelegate.cpp:
1094         (HistoryDelegate::didNavigateWithNavigationData): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1095         (HistoryDelegate::updateHistoryTitle): Ditto.
1096         (HistoryDelegate::populateVisitedLinksForWebView): Ditto.
1097         * DumpRenderTree/win/PolicyDelegate.cpp:
1098         (dumpPath):
1099         (PolicyDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1100         (PolicyDelegate::AddRef): Ditto.
1101         (PolicyDelegate::Release): Ditto.
1102         (PolicyDelegate::decidePolicyForNavigationAction): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1103         (PolicyDelegate::unableToImplementPolicyWithError): Ditto.
1104         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1105         (ResourceLoadDelegate::descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1106         (ResourceLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1107         (ResourceLoadDelegate::AddRef): Ditto.
1108         (ResourceLoadDelegate::Release): Ditto.
1109         (ResourceLoadDelegate::identifierForInitialRequest): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1110         (ResourceLoadDelegate::removeIdentifierForRequest): Ditto.
1111         (ResourceLoadDelegate::willSendRequest): Ditto.
1112         (ResourceLoadDelegate::didReceiveAuthenticationChallenge): Ditto.
1113         (ResourceLoadDelegate::didReceiveResponse): Ditto.
1114         (ResourceLoadDelegate::didFinishLoadingFromDataSource): Ditto.
1115         (ResourceLoadDelegate::didFailLoadingWithError): Ditto.
1116         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
1117         (TestRunner::queueLoad): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1118         (TestRunner::setUserStyleSheetLocation): Ditto.
1119         (TestRunner::execCommand): Ditto.
1120         (TestRunner::overridePreference): Ditto.
1121         (TestRunner::evaluateScriptInIsolatedWorld): Ditto.
1122         * DumpRenderTree/win/TextInputControllerWin.cpp: Ditto.
1123         (TextInputController::setMarkedText): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1124         (TextInputController::insertText): Ditto.
1125         * DumpRenderTree/win/UIDelegate.cpp:
1126         (UIDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1127         (UIDelegate::AddRef): Ditto.
1128         (UIDelegate::Release): Ditto.
1129         (UIDelegate::hasCustomMenuImplementation): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1130         (UIDelegate::trackCustomPopupMenu): Ditto.
1131         (UIDelegate::registerUndoWithTarget): Ditto.
1132         (UIDelegate::removeAllActionsWithTarget): Ditto.
1133         (UIDelegate::setActionTitle): Ditto.
1134         (UIDelegate::undo): Ditto.
1135         (UIDelegate::redo): Ditto.
1136         (UIDelegate::canUndo): Ditto.
1137         (UIDelegate::canRedo): Ditto.
1138         (UIDelegate::printFrame): Ditto.
1139         (UIDelegate::ftpDirectoryTemplatePath): Ditto.
1140         (UIDelegate::webViewHeaderHeight): Ditto.
1141         (UIDelegate::webViewFooterHeight): Ditto.
1142         (UIDelegate::drawHeaderInRect): Ditto.
1143         (UIDelegate::drawFooterInRect): Ditto.
1144         (UIDelegate::webViewPrintingMarginRect): Ditto.
1145         (UIDelegate::canRunModal): Ditto.
1146         (UIDelegate::createModalDialog): Ditto.
1147         (UIDelegate::runModal): Ditto.
1148         (UIDelegate::isMenuBarVisible): Ditto.
1149         (UIDelegate::setMenuBarVisible): Ditto.
1150         (UIDelegate::runDatabaseSizeLimitPrompt): Ditto.
1151         (UIDelegate::paintCustomScrollbar): Ditto.
1152         (UIDelegate::paintCustomScrollCorner): Ditto.
1153         (UIDelegate::setFrame): Ditto.
1154         (UIDelegate::webViewFrame): Ditto.
1155         (UIDelegate::runJavaScriptAlertPanelWithMessage): Ditto.
1156         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
1157         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
1158         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
1159         (UIDelegate::webViewAddMessageToConsole): Ditto.
1160         (UIDelegate::doDragDrop): Ditto.
1161         (UIDelegate::webViewGetDlgCode): Ditto.
1162         (UIDelegate::createWebViewWithRequest): Ditto.
1163         (UIDelegate::webViewClose): Ditto.
1164         (UIDelegate::webViewFocus): Ditto.
1165         (UIDelegate::webViewUnfocus): Ditto.
1166         (UIDelegate::webViewPainted): Ditto.
1167         (UIDelegate::exceededDatabaseQuota): Ditto.
1168         (UIDelegate::embeddedViewWithArguments): Ditto.
1169         (UIDelegate::webViewClosing): Ditto.
1170         (UIDelegate::webViewSetCursor): Ditto.
1171         (UIDelegate::webViewDidInvalidate): Ditto.
1172         (UIDelegate::setStatusText): Ditto.
1173         (UIDelegate::desktopNotificationsDelegate): Ditto.
1174         (UIDelegate::drawBackground): Ditto.
1175         (UIDelegate::decidePolicyForGeolocationRequest): Ditto.
1176         (UIDelegate::didPressMissingPluginButton): Ditto.
1177         * DumpRenderTree/win/WorkQueueItemWin.cpp: Ditto.
1178         (LoadItem::invoke):  Switch to _bstr_t. Use JSStringCreateWithBSTR.
1179         (LoadHTMLStringItem::invoke): Ditto.
1180         (ScriptItem::invoke): Ditto.
1181
1182 2014-04-09  Gergo Balogh  <gbalogh.u-szeged@partner.samsung.com>
1183
1184         Stylechecker: False positive on inline asm code.
1185         https://bugs.webkit.org/show_bug.cgi?id=130570
1186
1187         Reviewed by Csaba Osztrogonác.
1188
1189         Disable stylechecking in asm blocks.
1190
1191         * Scripts/webkitpy/style/checkers/cpp.py:
1192         (process_line):
1193         (_InlineASMState):
1194         (_InlineASMState.__init__):
1195         (_InlineASMState.process_line):
1196         (_InlineASMState.isInside):
1197         (_process_lines):
1198         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1199         (WebKitStyleTest.test_member_initialization_list):
1200
1201 2014-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1202
1203         [GTK] Move WebKit1 unit tests resources used by WebKit2 unit tests to WebKit2 resources dir
1204         https://bugs.webkit.org/show_bug.cgi?id=131029
1205
1206         Reviewed by Philippe Normand.
1207
1208         Add blank.ico and test.pdf to resources dir of WebKit2Gtk unit
1209         tests and remove the getWebKit1TestResoucesDir() method.
1210
1211         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1212         (testDownloadLocalFile): Use Test::getResourcesDir().
1213         (testDownloadLocalFileError): Ditto.
1214         (serverCallback): Ditto.
1215         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1216         (serverCallback): Ditto.
1217         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1218         (httpServerCallback): Ditto.
1219         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1220         (serverCallback): Ditto.
1221         * TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico: Added.
1222         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf: Added.
1223         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1224         (Test::getWebKit1TestResoucesDir): Deleted.
1225
1226 2014-04-09  Alexey Proskuryakov  <ap@apple.com>
1227
1228         [WK2] HTTP authentication regression tests fail
1229         https://bugs.webkit.org/show_bug.cgi?id=81627
1230         <rdar://problem/11079296>
1231
1232         Reviewed by Anders Carlsson.
1233
1234         * WebKitTestRunner/TestController.h:
1235         * WebKitTestRunner/TestController.cpp:
1236         (WTR::TestController::createWebViewWithOptions): Added canAuthenticateAgainstProtectionSpaceInFrame
1237         to pageLoaderClient structure.
1238         (WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true
1239         for password based authentication (we do get server trust challenges on some tests,
1240         which WKTR can't handle).
1241         When this client call is not implemented or returns false, didReceiveAuthenticationChallengeInFrame
1242         calls won't be made, at least on CFNetwork based platforms.
1243         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Changed the output
1244         to omit <unknown>. The resource is always unknown with WK2, and it doesn't really
1245         make sense to associate auth requests with individual resources - there can be
1246         multiple resources loading at once from the same protection space, so WebKit1 API
1247         that had a resource identifier was inherently racy.
1248
1249 2014-04-09  Ryuan Choi  <ryuan.choi@samsung.com>
1250
1251         [EFL] Change font path for DumpRenderTree and WebKitTestRunner
1252         https://bugs.webkit.org/show_bug.cgi?id=131427
1253
1254         Reviewed by Gyuyoung Kim.
1255
1256         Since r166973, font path was changed.
1257
1258         * DumpRenderTree/PlatformEfl.cmake:
1259         * WebKitTestRunner/PlatformEfl.cmake:
1260
1261 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
1262
1263         Fix the build-jsc build
1264         https://bugs.webkit.org/show_bug.cgi?id=131410
1265
1266         Reviewed by Michael Saboff.
1267
1268         * Scripts/build-jsc: Make sure to build bmalloc before WTF, since
1269         WTF depends on it.
1270
1271 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
1272
1273         [GTK] Remove WebKit1 unit tests
1274         https://bugs.webkit.org/show_bug.cgi?id=131359
1275
1276         Reviewed by Anders Carlsson.
1277
1278         Remove all WebKit1 GTK+ unit tests, in preparation for removing the WebKit1 port
1279         entirely. We also remove the list of skipped WebKi1 tests from run-gtk-tests, as
1280         they were inadvertently left in http://trac.webkit.org/changeset/166504.
1281
1282         * CMakeLists.txt: No longer load the WebKit1 unit test CMakeLists.txt file.
1283         * Scripts/run-gtk-tests: Remove skipped WebKit1 unit tests.
1284         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Removed.
1285         * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Removed.
1286         * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Removed.
1287         * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Removed.
1288         * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Removed.
1289         * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Removed.
1290         * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Removed.
1291         * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Removed.
1292         * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Removed.
1293         * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Removed.
1294         * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Removed.
1295         * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Removed.
1296         * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Removed.
1297         * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Removed.
1298         * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Removed.
1299         * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Removed.
1300         * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Removed.
1301         * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Removed.
1302         * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Removed.
1303         * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Removed.
1304         * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Removed.
1305         * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Removed.
1306         * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Removed.
1307         * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Removed.
1308         * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Removed.
1309         * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Removed.
1310         * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Removed.
1311         * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Removed.
1312         * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Removed.
1313         * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Removed.
1314         * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Removed.
1315         * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Removed.
1316         * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Removed.
1317         * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Removed.
1318         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Removed.
1319         * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Removed.
1320
1321 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
1322
1323         Unreviewed gardening (Take 2): Prevent users from attempting
1324         to build with known invalid cURL.
1325
1326         * Scripts/webkitdirs.pm:
1327         (checkInstalledTools): Check for 7.34.0 (the broken version), not
1328         7.33.0 (the known good version).
1329
1330 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
1331
1332         [GTK] Remove DumpRenderTree and GtkLauncher
1333         https://bugs.webkit.org/show_bug.cgi?id=131373
1334
1335         Reviewed by Andreas Kling.
1336
1337         Remove the GTK+ port of DumpRenderTree and GtkLauncher. These tools are
1338         no longer necessary now that WebKit1 GTK+ will be removed.
1339
1340         * CMakeLists.txt:
1341         * DumpRenderTree/PlatformGTK.cmake: Removed.
1342         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Removed.
1343         * DumpRenderTree/gtk/DumpRenderTree.cpp: Removed.
1344         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Removed.
1345         * DumpRenderTree/gtk/EditingCallbacks.cpp: Removed.
1346         * DumpRenderTree/gtk/EditingCallbacks.h: Removed.
1347         * DumpRenderTree/gtk/EventSender.cpp: Removed.
1348         * DumpRenderTree/gtk/EventSender.h: Removed.
1349         * DumpRenderTree/gtk/GCControllerGtk.cpp: Removed.
1350         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Removed.
1351         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Removed.
1352         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Removed.
1353         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Removed.
1354         * DumpRenderTree/gtk/TextInputController.cpp: Removed.
1355         * DumpRenderTree/gtk/TextInputController.h: Removed.
1356         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Removed.
1357         * GtkLauncher/CMakeLists.txt: Removed.
1358         * GtkLauncher/LauncherInspectorWindow.c: Removed.
1359         * GtkLauncher/LauncherInspectorWindow.h: Removed.
1360         * GtkLauncher/main.c: Removed.
1361         * GtkLauncher/simple.svg: Removed.
1362         * GtkLauncher/text.html: Removed.
1363         * WebKitTestRunner/PlatformGTK.cmake:
1364         * WebKitTestRunner/gtk/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/gtk/fonts/AHEM____.TTF.
1365         * WebKitTestRunner/gtk/fonts/FontWithNoValidEncoding.fon: Renamed from Tools/DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon.
1366         * WebKitTestRunner/gtk/fonts/fonts.conf: Renamed from Tools/DumpRenderTree/gtk/fonts/fonts.conf.
1367
1368 2014-04-08  Mark Rowe  <mrowe@apple.com>
1369
1370         XPC services launched by Safari have wrong DYLD_FRAMEWORK_PATH set when launched via run-safari / debug-safari
1371         <https://webkit.org/b/131388> / <rdar://problem/16291687>
1372
1373         Reviewed by Alexey Proskuryakov.
1374
1375         * Scripts/webkitdirs.pm:
1376         (runMacWebKitApp): Set __XPC_DYLD_FRAMEWORK_PATH to the absolute path to the built products directory.
1377         (execMacWebKitAppForDebugging): Ditto.
1378
1379 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
1380
1381         Build bmalloc on iOS too
1382         https://bugs.webkit.org/show_bug.cgi?id=131381
1383
1384         Reviewed by Andreas Kling.
1385
1386         * Scripts/build-webkit:
1387
1388 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
1389
1390         Unreviewed gardening: Prevent users from attempting
1391         to build with known invalid cURL.
1392
1393         * Scripts/webkitdirs.pm:
1394         (checkInstalledTools): Block build attempts with bad
1395         Cygwin tool set.
1396
1397 2014-04-07  Geoffrey Garen  <ggaren@apple.com>
1398
1399         Build bmalloc on Mac
1400         https://bugs.webkit.org/show_bug.cgi?id=131333
1401
1402         Reviewed by Mark Rowe.
1403
1404         * Scripts/build-webkit: Add the bmalloc target if we're on Mac.
1405         (Note: Just testing Mac is not good enough because in this
1406         script 'Mac' means 'Mac or iOS'.)
1407
1408 2014-03-30  Filip Pizlo  <fpizlo@apple.com>
1409
1410         Move slow JSRegress tests out of the way so that they don't show up in run-jsc-benchmarks runs and also skip tests that are extremely long-running
1411         https://bugs.webkit.org/show_bug.cgi?id=130951
1412
1413         Reviewed by Geoffrey Garen.
1414
1415         * Scripts/run-javascriptcore-tests:
1416
1417 2014-04-06  Darin Adler  <darin@apple.com>
1418
1419         Rework CSS calc logic, fixing some reference count mistakes in Length
1420         https://bugs.webkit.org/show_bug.cgi?id=131280
1421
1422         Reviewed by Andreas Kling.
1423
1424         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added CalculationValue.cpp.
1425         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp: Added.
1426
1427 2014-04-04  Brian J. Burg  <burg@cs.washington.edu>
1428
1429         Enable WEB_REPLAY for PLATFORM(MAC)
1430         https://bugs.webkit.org/show_bug.cgi?id=130700
1431
1432         Reviewed by Timothy Hatcher.
1433
1434         * Scripts/webkitperl/FeatureList.pm: Set the default for WEB_REPLAY for OS X engineering builds.
1435
1436 2014-04-05  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1437
1438         [CMake] Include X11's include dirs in TestNetscapePlugin
1439         https://bugs.webkit.org/show_bug.cgi?id=131270
1440
1441         Reviewed by Martin Robinson.
1442
1443         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Include X11_INCLUDE_DIR since
1444         TestNetscapePlugin includes WebCore code that includes X headers.
1445
1446 2014-04-05  David Kilzer  <ddkilzer@apple.com>
1447
1448         REGRESSION (r166529): Fix build after renaming TileCache to LegacyTileCache
1449         <http://webkit.org/b/130986>
1450
1451         * Scripts/check-for-inappropriate-objc-class-names: Add 'Legacy'
1452         prefix to TileCache class names in exception list.
1453
1454 2014-04-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1455
1456         [GTK] kill-old-processes should kill dbus-daemon processes
1457         https://bugs.webkit.org/show_bug.cgi?id=127352
1458
1459         Reviewed by Martin Robinson.
1460
1461         * BuildSlaveSupport/kill-old-processes:
1462         (main):
1463
1464 2014-04-04  Andres Gomez  <agomez@igalia.com>
1465
1466         [Win] Update obsolete packages in cygwin
1467         https://bugs.webkit.org/show_bug.cgi?id=126264
1468
1469         Reviewed by Brent Fulgham.
1470
1471         Removed "apache" and "minires" as the first has been replaced by
1472         "lighttpd" and the second is now integrated into
1473         "cygwin". Replaced the transitional and now obsolete "gcc" package
1474         with "gcc-g++" and ensure that "python" stays at version "2.6.8"
1475         since the newer version available is "2.7.3" which breaks the
1476         build due to some funniness with environment variable handling.
1477
1478         * CygwinDownloader/cygwin-downloader.py:
1479         * CygwinDownloader/cygwin-downloader.zip:
1480
1481 2014-04-03  Joseph Pecoraro  <pecoraro@apple.com>
1482
1483         check-webkit-style: Improve warnings on Objective-C @property syntax
1484         https://bugs.webkit.org/show_bug.cgi?id=131200
1485
1486         Reviewed by Dan Bernstein.
1487
1488         * Scripts/webkitpy/style/checkers/cpp.py:
1489         (check_spacing):
1490         (CppChecker):
1491         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1492         (CppStyleTest.test_spacing_in_objective_c_properties):
1493
1494 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
1495
1496         Unreviewed. Moving my name to commiter section
1497
1498         * Scripts/webkitpy/common/config/contributors.json:
1499
1500 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
1501
1502         Unreviewed. Add myself as a committer.
1503
1504         * Scripts/webkitpy/common/config/contributors.json:
1505
1506 2014-04-03  Andrzej Badowski  <a.badowski@samsung.com>
1507
1508         [EFL][WK2] Replacing zoom functionality of MiniBrowser from scale_set to page_zoom_set.
1509         https://bugs.webkit.org/show_bug.cgi?id=130391
1510
1511         Reviewed by Gyuyoung Kim.
1512
1513         Change the implementation of the zoom functionality from ewk_view_scale_set
1514         to ewk_view_page_zoom_set.
1515
1516         * MiniBrowser/efl/main.c:
1517
1518 2014-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1519
1520         [webkitpy] perf profiler does not understand --call-graph argument
1521         https://bugs.webkit.org/show_bug.cgi?id=131132
1522
1523         Reviewed by Ryosuke Niwa.
1524
1525         New versions of perf profiler have changed the argument from --call-graph to -g.
1526
1527         * Scripts/webkitpy/common/system/profiler.py:
1528         (Perf.wrapper_arguments): Use -g instead of --call-graph.
1529         * Scripts/webkitpy/port/driver_unittest.py:
1530         (DriverTest.test_profiler_as_wrapper): Update test accordingly.
1531
1532 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1533
1534         Add EFL WK2 performance bot to build.webkit.org
1535         https://bugs.webkit.org/show_bug.cgi?id=131034
1536
1537         Fix after r166707, use "Perf" instead of "perf" for consistency.
1538
1539         Reviewed by Csaba Osztrogonác.
1540
1541         * BuildSlaveSupport/build.webkit.org-config/config.json:
1542
1543 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1544
1545         Add EFL WK2 performance bot to build.webkit.org
1546         https://bugs.webkit.org/show_bug.cgi?id=131034
1547
1548         Reviewed by Csaba Osztrogonác.
1549
1550         * BuildSlaveSupport/build.webkit.org-config/config.json:
1551
1552 2014-04-02  Ryuan Choi  <ryuan.choi@samsung.com>
1553
1554         [EFL][WK1] Use Evas_Touch_Point_State instead of Ewk_Touch_Point_Type
1555         https://bugs.webkit.org/show_bug.cgi?id=131151
1556
1557         Reviewed by Gyuyoung Kim.
1558
1559         * DumpRenderTree/efl/EventSender.cpp: Replace Ewk_Touch_Point_Type to Evas_Touch_Point_State.
1560         (TouchEventInfo::TouchEventInfo):
1561         (sendTouchEvent):
1562         (addTouchPointCallback):
1563         (updateTouchPointCallback):
1564         (cancelTouchPointCallback):
1565         (releaseTouchPointCallback):
1566
1567 2014-04-02  David Kilzer  <ddkilzer@apple.com>
1568
1569         filter-build-webkit: Ignore xcodebuild warnings when compiling with newer builds of clang
1570         <http://webkit.org/b/131045>
1571
1572         Reviewed by Daniel Bates.
1573
1574         * Scripts/filter-build-webkit:
1575         (shouldIgnoreLine): Ignore DVTAssertions related to new builds
1576         of clang, plus debug data for all DVTAssertions.
1577
1578 2014-04-01  Dean Jackson  <dino@apple.com>
1579
1580         Load Media Controls js/css from bundle
1581         https://bugs.webkit.org/show_bug.cgi?id=131086
1582
1583         Reviewed by Eric Carlson.
1584
1585         We're now putting CSS files into the bundle, so remove the test for them.
1586
1587         * Scripts/check-for-inappropriate-files-in-framework:
1588
1589 2014-04-02  Martin Hock  <mhock@apple.com>
1590
1591         Unify private browsing with sessions.
1592         https://bugs.webkit.org/show_bug.cgi?id=130099
1593
1594         Reviewed by Alexey Proskuryakov.
1595
1596         Add an API test for ephemeral sessions similar to PrivateBrowsingPushStateNoHistoryCallback.
1597         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1598         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
1599         (TestWebKitAPI::didNavigateWithNavigationData):
1600         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1601         (TestWebKitAPI::TEST):
1602
1603         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Also test to make sure private browsing can be disabled.
1604         (TestWebKitAPI::didNavigateWithoutNavigationData):
1605         (TestWebKitAPI::didNavigateWithNavigationData):
1606         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1607         (TestWebKitAPI::TEST):
1608
1609 2014-04-02  Martin Robinson  <mrobinson@igalia.com>
1610
1611         REGRESSION(r165704): [GTK] Inspector resources not correctly generated
1612         https://bugs.webkit.org/show_bug.cgi?id=130343
1613
1614         Reviewed by Gustavo Noronha Silva.
1615
1616         * gtk/generate-inspector-gresource-manifest.py: Instead of hard-coding the file list, accept a list
1617         of directories on the command line and look for all appropriate files in those directories for the
1618         GResource archive. Also make archive paths relative to those directories.
1619         (find_all_files_in_directory): This helper looks for all the appropriate files in a given directory.
1620         (find_all_files_in_directory.select_file): Whether or not to add the file to the archive.
1621
1622 2014-04-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1623
1624         [webkitpy] Avoid multiple "Preparing rollout for bug" log messages
1625         https://bugs.webkit.org/show_bug.cgi?id=131106
1626
1627         Reviewed by Csaba Osztrogonác.
1628
1629         * Scripts/webkitpy/tool/commands/download.py:
1630         (AbstractRolloutPrepCommand._prepare_state):
1631         * Scripts/webkitpy/tool/commands/download_unittest.py:
1632         (test_prepare_rollout):
1633         (test_create_rollout):
1634         (test_create_rollout_resolved):
1635         (test_rollout):
1636
1637 2014-04-02  Krzysztof Wolanski  <k.wolanski@samsung.com>
1638
1639         [EFL] Add option to use separate web process for new window in MiniBrowser
1640         https://bugs.webkit.org/show_bug.cgi?id=130190
1641
1642         Reviewed by Gyuyoung Kim.
1643
1644         New created window (CTRL + n) will be open in separated web process.
1645         This option is enabled by adding a flag (S/separate-process) with launching
1646         MiniBrowser.
1647
1648         * MiniBrowser/efl/main.c:
1649         (elm_main):
1650
1651 2014-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1652
1653         [GTK] Move NEWS file to a new location
1654         https://bugs.webkit.org/show_bug.cgi?id=130901
1655
1656         Reviewed by Brent Fulgham.
1657
1658         * gtk/manifest.txt: Update the NEWS file path.
1659
1660 2014-04-01  Anders Carlsson  <andersca@apple.com>
1661
1662         Fix build.
1663
1664         * MiniBrowser/mac/WK2BrowserWindowController.m:
1665         (-[WK2BrowserWindowController awakeFromNib]):
1666         (-[WK2BrowserWindowController dealloc]):
1667         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
1668
1669 2014-04-01  Brent Fulgham  <bfulgham@apple.com>
1670
1671         Unreviewed test gardening.
1672
1673         * Scripts/webkitpy/port/base_unittest.py:
1674         (PortTest.test_build_path): Handle the Debug case so we don't get webkitpy-test failures on our test bots.
1675
1676 2014-04-01  Zoltan Horvath  <zoltan@webkit.org>
1677
1678         [CSS Exclusions] Remove exclusions parsing support
1679         https://bugs.webkit.org/show_bug.cgi?id=131046
1680
1681         Reviewed by David Hyatt.
1682
1683         * Scripts/webkitperl/FeatureList.pm:
1684
1685 2014-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
1686
1687         [GTK] Remove last reference to GTK+ WK1 EWS
1688         https://bugs.webkit.org/show_bug.cgi?id=131058
1689
1690         Reviewed by Martin Robinson.
1691
1692         In r166427 WK1 GTK+ bots and EWS where removed, but this file was missing.
1693
1694         * QueueStatusServer/config/queues.py: Remove reference to GTK+ WK1 EWS.
1695
1696 2014-04-01  Lucas Forschler  <lforschler@apple.com>
1697
1698         Add a 32bit JSC builder/tester.
1699         https://bugs.webkit.org/show_bug.cgi?id=131054
1700
1701         Reviewed by Michael Saboff.
1702
1703         * BuildSlaveSupport/build.webkit.org-config/config.json:
1704         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1705         (Compile32bitJSC):
1706         (Run32bitJSCTests):
1707         (Run32bitJSCTests.countFailures):
1708         (BuildAndTest32bitJSCFactory):
1709         (BuildAndTest32bitJSCFactory.__init__):
1710
1711 2014-04-01  Martin Robinson  <mrobinson@igalia.com>
1712
1713         [GTK] No longer build WebKit1 gtkdoc
1714         https://bugs.webkit.org/show_bug.cgi?id=130970
1715
1716         Reviewed by Anders Carlsson.
1717
1718         * gtk/common.py:
1719         (gtk_version_of_pkg_config_file): Deleted.
1720         * gtk/generate-gtkdoc:
1721         (get_gtkdoc_module_paths): We no longer need to worry about GTK+ 2, since it
1722         was only applicable for WebKit1.
1723         (get_generator_for_config): No longer look for the WebKit1 configuration file.
1724
1725 2014-04-01  Mario Sanchez Prada  <mario.prada@samsung.com>
1726
1727         [GTK] Running minibrowser with url crashes in debug build
1728         https://bugs.webkit.org/show_bug.cgi?id=130492
1729
1730         Reviewed by Martin Robinson.
1731
1732         Update "uri-scheme" test not to use invalid URIs in it, so we
1733         don't get a mistmatch when comparing the original URI stored in
1734         the test class with the one returned by the WebKitWebView.
1735
1736         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1737         (testWebContextURIScheme): Update the test.
1738
1739 2014-04-01  Mihai Tica  <mitica@adobe.com>
1740
1741         Unreviewed: Add myself as a commiter to the contributors list.
1742
1743         * Scripts/webkitpy/common/config/contributors.json:
1744
1745 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
1746
1747         [EFL][WK2] Extract the control of page background out of color_set
1748         https://bugs.webkit.org/show_bug.cgi?id=127539
1749
1750         Reviewed by Gyuyoung Kim.
1751
1752         Added an option(C) to change background color.
1753
1754         * MiniBrowser/efl/main.c:
1755         (window_create):
1756         (elm_main):
1757
1758 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
1759
1760         Unreviewed build fix on the EFL port with latest EFL libraries since r166149
1761
1762         * ImageDiff/PlatformEfl.cmake: Added ECORE_IMF_INCLUDE_DIRS to include dirs
1763
1764 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
1765
1766         Unreviewed test correction after r166530.
1767
1768         * DumpRenderTree/mac/DumpRenderTree.mm:
1769         (setDefaultsToConsistentValuesForTesting): No need to change preference for all tests. We set the proper
1770         fine-grained setting for swipe tests. This prevents existing tests from breaking.
1771
1772 2014-03-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1773
1774         Remove the trigger for webkit1 tests on the gtk-linux-64-release bot
1775         https://bugs.webkit.org/show_bug.cgi?id=130987
1776
1777         r166427 removed the WebKit1 GTK+ bots, so we don't longer need to
1778         trigger the webkit1 bot tests on the gtk-linux-64-release bot.
1779
1780         Reviewed by Martin Robinson.
1781
1782         * BuildSlaveSupport/build.webkit.org-config/config.json:
1783
1784 2014-03-31  Dean Jackson  <dino@apple.com>
1785
1786         Remove WEB_ANIMATIONS
1787         https://bugs.webkit.org/show_bug.cgi?id=130989
1788
1789         Reviewed by Simon Fraser.
1790
1791         Remove this feature flag until we plan to implement.
1792
1793         * Scripts/webkitperl/FeatureList.pm:
1794
1795 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
1796
1797         Reduced Latched Scroll Test Flakiness
1798         https://bugs.webkit.org/show_bug.cgi?id=130983
1799
1800         Reviewed by Darin Adler.
1801
1802         * DumpRenderTree/mac/DumpRenderTree.mm:
1803         (setDefaultsToConsistentValuesForTesting): Test user should have 'high resolution' scrolling.
1804         * DumpRenderTree/mac/EventSendingController.mm:
1805         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Generate mouse wheel events
1806         with high resolution flags turned on.
1807         * WebKitTestRunner/mac/EventSenderProxy.mm:
1808         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
1809
1810 2014-03-31  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
1811
1812         run-webkit-tests should have a --no-timeout option
1813         https://bugs.webkit.org/show_bug.cgi?id=128286
1814
1815         Reviewed by Joseph Pecoraro.
1816
1817         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1818         (Worker._run_test): Renaming _run_test_with_timeout()
1819         (Worker._run_test_with_or_without_timeout): Renaming _run_test_with_timeout(), because tests can now run without timeout.
1820         (Worker._run_test_in_another_thread): Passing the --no-timeout option to the driver
1821         (Worker._run_test_in_this_thread):
1822         (Worker._run_test_with_timeout): Deleted.
1823         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1824         (parse_args): Added the --no-timeout option
1825
1826 2014-03-31  Samuel White  <samuel_white@apple.com>
1827
1828         AX: Need ability to get line range for text marker.
1829         https://bugs.webkit.org/show_bug.cgi?id=130906
1830
1831         Reviewed by Chris Fleizach.
1832
1833         Added a new function in DRT and TestRunner to test that AXLineTextMarkerRangeForTextMarker works as expected.
1834
1835         * DumpRenderTree/AccessibilityUIElement.cpp:
1836         (lineTextMarkerRangeForTextMarkerCallback):
1837         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1838         (AccessibilityUIElement::getJSClass):
1839         * DumpRenderTree/AccessibilityUIElement.h:
1840         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1841         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1842         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1843         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1844         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1845         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1846         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1847         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1848         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1849         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1850         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1851         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1852
1853 2014-03-31  Filip Pizlo  <fpizlo@apple.com>
1854
1855         More validation for FTL inline caches
1856         https://bugs.webkit.org/show_bug.cgi?id=130948
1857
1858         Reviewed by Geoffrey Garen.
1859
1860         * Scripts/run-jsc-stress-tests:
1861
1862 2014-03-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1863
1864         [GTK] Do not run WebKit1 unit tests by default
1865         https://bugs.webkit.org/show_bug.cgi?id=130968
1866
1867         Reviewed by Martin Robinson.
1868
1869         * Scripts/run-gtk-tests:
1870         (TestRunner):
1871
1872 2014-03-31  Martin Robinson  <mrobinson@igalia.com>
1873
1874         [GTK] Remove scripts code only applicable to autotools
1875         https://bugs.webkit.org/show_bug.cgi?id=130841
1876
1877         Reviewed by Anders Carlsson.
1878
1879         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1880         (_should_file_trigger_build): Update file list to reflect GTK+ CMake port.
1881         * Scripts/webkitpy/common/config/watchlist: Remove the GTK+ build watchlist.
1882         * Scripts/webkitpy/style/checker.py: The GNUmakefile doesn't exist any longer.
1883         * gtk/find-make-dist-errors: Removed.
1884         * gtk/generate-feature-defines-files: Removed.
1885         * gtk/manifest.txt: No longer need to consider autotools files.
1886
1887 2014-03-30  Andy Estes  <aestes@apple.com>
1888
1889         Fix two failing layout tests on Mountain Lion after r166466.
1890
1891         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1892         (-[DownloadDelegate _downloadDidStart:]):
1893
1894 2014-03-30  Andy Estes  <aestes@apple.com>
1895
1896         [Cocoa] Add an originatingWebView property to _WKDownload
1897         https://bugs.webkit.org/show_bug.cgi?id=130945
1898
1899         Reviewed by Anders Carlsson.
1900
1901         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1902         (-[DownloadDelegate _downloadDidStart:]):
1903         (-[OriginatingWebViewDownloadDelegate initWithWebView:]):
1904         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
1905         (TEST):
1906
1907 2014-03-28  Filip Pizlo  <fpizlo@apple.com>
1908
1909         Land the stackmap register liveness glue with the uses of the liveness disabled
1910         https://bugs.webkit.org/show_bug.cgi?id=130924
1911
1912         Reviewed by Oliver Hunt.
1913
1914         * Scripts/run-jsc-stress-tests:
1915
1916 2014-03-29  Alexey Proskuryakov  <ap@apple.com>
1917
1918         Update WebKit1.StringTruncator for Mountain Lion.
1919
1920         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Looks like one subtest was failing
1921         due to different font metrics on 10.8.
1922
1923 2014-03-28  Darin Adler  <darin@apple.com>
1924
1925         Fix recently-introduced off-by-one error in centerTruncateToBuffer
1926         https://bugs.webkit.org/show_bug.cgi?id=130889
1927
1928         Reviewed by Alexey Proskuryakov.
1929
1930         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringTruncator.mm.
1931         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Added. One test for each of the
1932         WebStringTruncator methods; should be good for a start. These are dependent on the
1933         metrics of Helvetica 12, but I am hoping that will be consistent across OS X machines.
1934
1935 2014-03-28  Martin Hock  <mhock@apple.com>
1936
1937         Unreviewed. Add myself as a committer.
1938
1939         * Scripts/webkitpy/common/config/contributors.json:
1940
1941 2014-03-28  Martin Robinson  <mrobinson@igalia.com>
1942
1943         Remove WebKit1 GTK+ bots
1944         https://bugs.webkit.org/show_bug.cgi?id=130904
1945
1946         Reviewed by Anders Carlsson.
1947
1948         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove references to GTK+ WebKit1 test bot and ensure
1949         all bots are testing WebKit2 only.
1950         * Scripts/webkitpy/common/config/ews.json: Remove references to GTK+ WK1 EWS.
1951         * Scripts/webkitpy/common/config/ports.py: Remove references to GTK+ WK1 bots.
1952         * Scripts/webkitpy/common/config/ports_unittest.py: Ditto.
1953         * Scripts/webkitpy/port/builders.py: Ditto.
1954         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
1955         * TestResultServer/static-dashboards/builders.jsonp: Ditto.
1956
1957 2014-03-28  Timothy Hatcher  <timothy@apple.com>
1958
1959         Remove Brian Burg's apple.com email address.
1960
1961         * Scripts/webkitpy/common/config/contributors.json:
1962
1963 2014-03-28  David Kilzer  <ddkilzer@apple.com>
1964
1965         bisect-builds should print Trac 'changeset' URL if only one build is detected
1966         <http://webkit.org/b/130903>
1967
1968         Reviewed by Dan Bernstein.
1969
1970         * Scripts/bisect-builds:
1971         (printTracLink): Print a direct link to the Trac 'changeset'
1972         URL if there is only one revision in the range.
1973
1974 2014-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1975
1976         [EFL] Bump glib version from 2.36 to 2.38
1977         https://bugs.webkit.org/show_bug.cgi?id=130886
1978
1979         Reviewed by Csaba Osztrogonác.
1980
1981         There is a build break on EFL port when using glib 2.36 ver. To fix it,
1982         we need to bump glib version up to 2.38 as gtk port.
1983
1984         * efl/jhbuild.modules:
1985
1986 2014-03-27  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1987
1988         <https://webkit.org/b/42704> WebKitTestRunner needs to print history delegate information
1989
1990         Provide an implementation of WKContextHistoryClient that logs when called for tests in
1991         the globalhistory directory.
1992
1993         Reviewed by Sam Weinig.
1994
1995         * WebKitTestRunner/TestController.cpp:
1996         (WTR::TestController::TestController):
1997         (WTR::TestController::initialize): Set the history client.
1998         (WTR::TestController::resetStateToConsistentValues): Disable logging of history client callbacks.
1999         (WTR::TestController::didNavigateWithNavigationData): Log information about the navigation. Some portions
2000         of the output are hard-coded to match WebKit1's results for now since they're fixed in our existing tests
2001         and we don't yet have API to access the data in question.
2002         (WTR::TestController::didPerformClientRedirect):
2003         (WTR::TestController::didPerformServerRedirect):
2004         (WTR::TestController::didUpdateHistoryTitle):
2005         * WebKitTestRunner/TestController.h:
2006         (WTR::TestController::setShouldLogHistoryClientCallbacks):
2007         * WebKitTestRunner/TestInvocation.cpp:
2008         (WTR::shouldLogHistoryClientCallbacks): Log history client callbacks for tests in a globalhistory directory.
2009         (WTR::TestInvocation::invoke):
2010
2011 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
2012
2013         Revert http://trac.webkit.org/changeset/166386 because it broke builds.
2014
2015         * Scripts/build-webkit:
2016         * Scripts/copy-webkitlibraries-to-product-directory:
2017
2018 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
2019
2020         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
2021         https://bugs.webkit.org/show_bug.cgi?id=130867
2022         <rdar://problem/16432456>
2023
2024         Reviewed by Mark Hahnenberg.
2025
2026         * Scripts/build-webkit:
2027         * Scripts/copy-webkitlibraries-to-product-directory:
2028
2029 2014-03-26  Andy Estes  <aestes@apple.com>
2030
2031         [Cocoa] Expose DownloadClient::didFail() and DownloadClient::didCancel()
2032         https://bugs.webkit.org/show_bug.cgi?id=130805
2033
2034         Reviewed by Dan Bernstein.
2035
2036         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2037         (-[DownloadDelegate _download:didReceiveResponse:]):
2038         (-[DownloadDelegate _downloadDidFinish:]):
2039         (runTest):
2040         (TEST):
2041         (-[FailingDownloadDelegate _downloadDidFinish:]):
2042         (-[FailingDownloadDelegate _download:didFailWithError:]):
2043         (-[FailingDownloadDelegate _downloadDidCancel:]):
2044         (-[CancelledDownloadDelegate _downloadDidStart:]):
2045         (-[CancelledDownloadDelegate _downloadDidFinish:]):
2046         (-[CancelledDownloadDelegate _download:didFailWithError:]):
2047         (-[CancelledDownloadDelegate _downloadDidCancel:]):
2048         (-[DownloadDelegate initWithSourceURL:]): Deleted.
2049         (-[DownloadDelegate sourceURL]): Deleted.
2050         (runTestWithNavigationDelegate): Deleted.
2051
2052 2014-03-26  Anders Carlsson  <andersca@apple.com>
2053
2054         Change MiniBrowser to hold on to window controllers instead of windows
2055         https://bugs.webkit.org/show_bug.cgi?id=130797
2056
2057         Reviewed by Oliver Hunt.
2058
2059         * MiniBrowser/mac/AppDelegate.h:
2060         * MiniBrowser/mac/AppDelegate.m:
2061         (-[BrowserAppDelegate init]):
2062         (-[BrowserAppDelegate newWindow:]):
2063         (-[BrowserAppDelegate browserWindowWillClose:]):
2064         (-[BrowserAppDelegate applicationWillTerminate:]):
2065         (-[BrowserAppDelegate frontmostBrowserWindowController]):
2066
2067 2014-03-26  Commit Queue  <commit-queue@webkit.org>
2068
2069         Unreviewed, rolling out r166264.
2070         https://bugs.webkit.org/show_bug.cgi?id=130785
2071
2072         Broke some window.opener tests for WK2 Mavericks (Requested by
2073         brrian__ on #webkit).
2074
2075         Reverted changeset:
2076
2077         "Web Replay: resource unique identifiers should be unique-per-
2078         frame, not globally"
2079         https://bugs.webkit.org/show_bug.cgi?id=130632
2080         http://trac.webkit.org/changeset/166264
2081
2082 2014-03-26  Zoltan Horvath  <zoltan@webkit.org>
2083
2084         [CSS Shapes] Remove shape-inside support
2085         https://bugs.webkit.org/show_bug.cgi?id=130698
2086
2087         Reviewed by David Hyatt.
2088
2089         * Scripts/webkitperl/FeatureList.pm:
2090
2091 2014-02-27  Gurpreet Kaur  <k.gurpreet@samsung.com>
2092
2093         Unreviewed. Add myself as a committer.
2094
2095         * Scripts/webkitpy/common/config/contributors.json:
2096
2097 2014-03-26  Tomas Popela  <tpopela@redhat.com>
2098
2099         run-launcher is Perl script so use elsif and not elif
2100         https://bugs.webkit.org/show_bug.cgi?id=130771
2101
2102         Reviewed by Carlos Garcia Campos.
2103
2104         * Scripts/run-launcher:
2105
2106 2014-03-26  Krzysztof Czech  <k.czech@samsung.com>
2107
2108         [ATK] Utilize new AtkValue interface coming in ATK 2.11.92
2109         https://bugs.webkit.org/show_bug.cgi?id=130575
2110
2111         Reviewed by Mario Sanchez Prada.
2112
2113         Change ATK version to 2.11.92. Adjust current implementation.
2114
2115         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2116         (AccessibilityUIElement::intValue):
2117         (AccessibilityUIElement::minValue):
2118         (AccessibilityUIElement::maxValue):
2119         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2120         (WTR::AccessibilityUIElement::intValue):
2121         (WTR::AccessibilityUIElement::minValue):
2122         (WTR::AccessibilityUIElement::maxValue):
2123         * efl/jhbuild.modules:
2124         * gtk/jhbuild.modules:
2125
2126 2014-03-12  Philippe Normand  <pnormand@igalia.com>
2127
2128         [GTK] The gnumake package is no longer needed in jhbuild
2129         https://bugs.webkit.org/show_bug.cgi?id=130121
2130
2131         Reviewed by Martin Robinson.
2132
2133         For GTK build-webkit now relies on cmake and ninja/gnumake. Even
2134         for a debug build cmake/system-gnumake worked just fine for me.
2135
2136         * gtk/jhbuild.modules: Removed gnumake.
2137         * gtk/patches/make-3.82-arg-list-length.patch: Removed.
2138         * gtk/patches/make-3.82-parallel-build.patch: Removed.
2139
2140 2014-03-25  Andy Estes  <aestes@apple.com>
2141
2142         Fix a failing API test on Mountain Lion and remove temporary debug logging.
2143
2144         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2145         (-[DownloadDelegate _download:didReceiveData:]):
2146         (-[DownloadDelegate _downloadDidFinish:]):
2147
2148 2014-03-25  Brian Burg  <bburg@apple.com>
2149
2150         Web Replay: resource unique identifiers should be unique-per-frame, not globally
2151         https://bugs.webkit.org/show_bug.cgi?id=130623
2152
2153         Reviewed by Timothy Hatcher.
2154
2155         The resource loader callback dumping routines assumed that resource identifiers
2156         were globally unique. Its map of resource identifiers to URLs must also track the
2157         frame associated with the resource.
2158
2159         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2160         (WTR::dumpResourceURL): Additionally take a WKBundleFrameRef argument, and use the
2161         opaque pointer as part of the key for assignedUrlsCache. The frame pointer is
2162         stable as long as the frame is valid.
2163         (WTR::InjectedBundlePage::didInitiateLoadForResource):
2164         (WTR::InjectedBundlePage::willSendRequestForFrame):
2165         (WTR::InjectedBundlePage::didReceiveResponseForResource):
2166         (WTR::InjectedBundlePage::didFinishLoadForResource):
2167         (WTR::InjectedBundlePage::didFailLoadForResource):
2168
2169 2014-03-25  Andy Estes  <aestes@apple.com>
2170
2171         Fix one API test expectation failure on Mountain Lion, and add additional logging to help diagnose another.
2172
2173         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2174         (-[DownloadDelegate _download:didReceiveResponse:]):
2175         (-[DownloadDelegate _download:didReceiveData:]):
2176
2177 2014-03-25  Andy Estes  <aestes@apple.com>
2178
2179         Add some debug logging to an API test that's failing on Mountain Lion.
2180
2181         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2182         (-[DownloadDelegate _download:didReceiveResponse:]):
2183         (-[DownloadDelegate _downloadDidFinish:]):
2184
2185 2014-03-25  Anders Carlsson  <andersca@apple.com>
2186
2187         Add goBack: and goForward: IBActions and move stopLoading: to a new WKIBActions category on WKWebView
2188         https://bugs.webkit.org/show_bug.cgi?id=130732
2189
2190         Reviewed by Tim Horton.
2191
2192         * MiniBrowser/mac/WK2BrowserWindowController.m:
2193         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
2194
2195 2014-03-25  Martin Robinson  <mrobinson@igalia.com>
2196
2197         [GTK] Remove the autotools build
2198         https://bugs.webkit.org/show_bug.cgi?id=130717
2199
2200         Reviewed by Anders Carlsson.
2201
2202         * DumpRenderTree/config.h: Remove references to the autotools configure file.
2203         * GNUmakefile.am: Removed.
2204         * GtkLauncher/GNUmakefile.am: Removed.
2205         * GtkLauncher/main.c: Remove references to the autotools configure file.
2206         * MiniBrowser/gtk/BrowserDownloadsBar.c: Ditto.
2207         * MiniBrowser/gtk/BrowserSearchBar.c: Ditto.
2208         * MiniBrowser/gtk/BrowserWindow.c: Ditto.
2209         * MiniBrowser/gtk/GNUmakefile.am: Removed.
2210         * MiniBrowser/gtk/main.c: Remove references to the autotools configure file.
2211         * Scripts/build-webkit: No longer handle autotools.
2212         * Scripts/run-gtk-tests: Ditto.
2213         (TestRunner._setup_testing_environment):
2214         * Scripts/run-launcher: Ditto.
2215         * Scripts/webkitdirs.pm: Ditto.
2216         * Scripts/webkitpy/common/config/contributionareas.py: Remove autotools as a contribution area.
2217         * Scripts/webkitpy/common/config/contributors.json: Ditto.
2218         * Scripts/webkitpy/port/gtk.py: No longer handle autotools.
2219         * Scripts/webkitpy/style/checker.py:
2220         * TestWebKitAPI/GNUmakefile.am: Removed.
2221         * TestWebKitAPI/config.h: Remove references to the autotools configure file.
2222         * WebKitTestRunner/GNUmakefile.am: Removed.
2223         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Ditto.
2224         * gtk/GNUmakefile.am: Removed.
2225         * gtk/common.py: Remove checks for the autotools build.
2226         * gtk/symbols.filter: Renamed from Source/autotools/symbols.filter.
2227
2228 2014-03-25  László Langó  <llango.u-szeged@partner.samsung.com>
2229
2230         prepare-ChangeLog throws false positive warnings for modified files.
2231         https://bugs.webkit.org/show_bug.cgi?id=130687
2232
2233         Reviewed by Darin Adler.
2234
2235         * Scripts/prepare-ChangeLog:
2236         (originalFile): Ignore git commit paremeter.
2237         We don't need this to get the unmodified file.
2238         (extractLineRangeBeforeChange):
2239         Simplify the if statement. Follow-up after r166189.
2240
2241 2014-03-25  Gabor Rapcsanyi  <rgabor@webkit.org>
2242
2243         [EFL] Add ARM64 build support
2244         https://bugs.webkit.org/show_bug.cgi?id=130506
2245
2246         Rubber stamped by Gyuyoung Kim.
2247
2248         * Scripts/webkitdirs.pm:
2249         (isARM): Detect aarch64 as ARM.
2250
2251 2014-03-25  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2252
2253         [webkitpy] Improve _parse_bug_description to recognize more descriptions
2254         https://bugs.webkit.org/show_bug.cgi?id=130137
2255
2256         Reviewed by Csaba Osztrogonác.
2257
2258         * Scripts/webkitpy/common/checkout/changelog.py:
2259         (ChangeLogEntry._parse_bug_description):
2260         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2261         (test_parse_log_entries_from_changelog):
2262         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2263         (CheckoutTest.test_commit_info_for_revision):
2264
2265 2014-03-24  Andy Estes  <aestes@apple.com>
2266
2267         Fix the iOS build of TestWebKitAPI.
2268
2269         * TestWebKitAPI/Configurations/Base.xcconfig:
2270         * TestWebKitAPI/PlatformUtilities.h:
2271
2272 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
2273
2274         Fix prepare-ChangeLog after r166156.
2275         https://bugs.webkit.org/show_bug.cgi?id=130674
2276
2277         Reviewed by Darin Adler.
2278
2279         * Scripts/prepare-ChangeLog:
2280         (generateFunctionLists):
2281         (extractLineRangeBeforeChange):
2282
2283 2014-03-24  Andy Estes  <aestes@apple.com>
2284
2285         [iOS] Download support by CFURLDownloadRef under USE(CFNETWORK).
2286         https://bugs.webkit.org/show_bug.cgi?id=129322
2287
2288         Reviewed by Anders Carlsson.
2289
2290         Add an API test suite for _WKDownload.
2291
2292         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2293         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: Added.
2294         (-[DownloadDelegate initWithSourceURL:]):
2295         (-[DownloadDelegate sourceURL]):
2296         (-[DownloadDelegate _downloadDidStart:]):
2297         (-[DownloadDelegate _download:didReceiveResponse:]):
2298         (-[DownloadDelegate _download:didReceiveData:]):
2299         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
2300         (-[DownloadDelegate _downloadDidFinish:]):
2301         (TEST):
2302         (runTestWithNavigationDelegate):
2303         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2304         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2305
2306 2014-03-24  Joseph Pecoraro  <pecoraro@apple.com>
2307
2308         filter-build-webkit: reduce unfiltered output
2309         https://bugs.webkit.org/show_bug.cgi?id=130485
2310
2311         Reviewed by Brent Fulgham.
2312
2313         * Scripts/filter-build-webkit:
2314         (shouldIgnoreLine):
2315
2316 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
2317
2318         prepare-ChangeLog should list functions that have been removed too.
2319         https://bugs.webkit.org/show_bug.cgi?id=130508
2320
2321         Reviewed by Darin Adler.
2322
2323         The prepare-ChangeLog does not list the deleted functions in the Changelog.
2324         We have to read the functions and the line ranges of them from the source
2325         before the change, then search for overlaps between them and the changed
2326         line ranges from diff.
2327
2328         * Scripts/prepare-ChangeLog:
2329         (originalFile): Get original source command.
2330         (generateFunctionLists): Collect deleted functions too.
2331         (generateFunctionListsByRanges): Duplicated code is moved to a separate subroutine.
2332         (extractLineRangeBeforeChange): Extract line ranges from the original source to get
2333         deleted functions ranges too.
2334         (extractLineRange): Renamed to extractLineRangeAfterChange.
2335
2336 2014-03-23  Hyowon Kim  <hw1008.kim@samsung.com>
2337
2338         Move all EFL typedefs into EflTypedefs.h.
2339         https://bugs.webkit.org/show_bug.cgi?id=130511
2340
2341         Reviewed by Gyuyoung Kim.
2342
2343         * TestWebKitAPI/PlatformWebView.h: Remove EFL typedefs.
2344         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
2345         * WebKitTestRunner/PlatformWebView.h: Ditto.
2346
2347 2014-03-21  Simon Fraser  <simon.fraser@apple.com>
2348
2349         Don't flush compositing layers within FrameView::willPaintContents()
2350         https://bugs.webkit.org/show_bug.cgi?id=130627
2351         <rdar://problem/16368869>
2352
2353         Reviewed by Sam Weinig.
2354
2355         Fix DRT to correctly render tests with layers now that FrameView::paintContents
2356         does not flush.
2357
2358         Move the -[WebView displayIfNeeded] from -[FrameLoadDelegate webView:didFinishLoadForFrame:]
2359         into an explicit function called before dumping.
2360
2361         Then explicitly call _flushCompositingChanges to ensure that GraphicsLayer changes
2362         are flushed to CA. They will be pushed to the window by snapshotting.
2363
2364         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2365         Fix weird path to IOKit.framework.
2366         * DumpRenderTree/mac/DumpRenderTree.mm:
2367         (updateDisplay):
2368         (dump):
2369         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2370         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): Fix parameter name.
2371         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Remove display call.
2372
2373 2014-03-21  David Kilzer  <ddkilzer@apple.com>
2374
2375         fix-blink-patch: tool to fix up renamed directory paths in Blink
2376         <http://webkit.org/b/130609>
2377
2378         Reviewed by Ryosuke Niwa.
2379
2380         Usage: cat blink.patch | fix-blink-patch | svn-apply
2381
2382         * Scripts/fix-blink-patch: Added.
2383
2384 2014-03-21  Darin Adler  <darin@apple.com>
2385
2386         Remove use of deprecatedCharacters in WebKit API tests
2387         https://bugs.webkit.org/show_bug.cgi?id=130602
2388
2389         Reviewed by Antti Koivisto.
2390
2391         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2392         (TestWebKitAPI::expectBuilderContent): Use characters8/16 instead of deprecatedCharacters.
2393         (TestWebKitAPI::expectEmpty): Use characters8.
2394         (TestWebKitAPI::TEST): Use characters8 instead of deprecatedCharacters in most cases.
2395
2396         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2397         Removed the test that is entirely about 16-bit conversion since that's basically a test of
2398         the deprecatedCharacters function itself, which we are about to delete.
2399
2400 2014-03-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2401
2402         [webkitpy] Fix has_valid_reviewer()
2403         https://bugs.webkit.org/show_bug.cgi?id=130589
2404
2405         Reviewed by Csaba Osztrogonác.
2406
2407         * Scripts/webkitpy/common/checkout/changelog.py:
2408         (ChangeLogEntry.has_valid_reviewer):
2409         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2410         (test_has_valid_reviewer):
2411         * Scripts/webkitpy/common/config/committers.py:
2412         (CommitterList._reviewer_only):
2413         (CommitterList.committer_by_name):
2414         (CommitterList.reviewer_by_email):
2415         (CommitterList):
2416         (CommitterList.reviewer_by_name):
2417
2418 2014-03-21  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
2419
2420         Add cache support for jhbuild
2421         https://bugs.webkit.org/show_bug.cgi?id=130588
2422
2423         Reviewed by Csaba Osztrogonác.
2424
2425         * jhbuild/jhbuildrc_common.py:
2426         (init): Jhbuild can now save the dependencies locally, if the JHBUILD_MIRROR environment variable is set.
2427
2428 2014-03-21  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2429
2430         [CMake] Add support for MAX_CPU_LOAD translated to -l in ninja and make
2431         https://bugs.webkit.org/show_bug.cgi?id=130504
2432
2433         Reviewed by Martin Robinson.
2434
2435         * Scripts/build-webkit: Add the maxCPULoad() to the makeArgs in
2436         CMake if not specified.
2437         * Scripts/webkitdirs.pm:
2438         (determineMaxCPULoad): Read MAX_CPU_LOAD as maxCPULoad.
2439         (maxCPULoad): determineMaxCPULoad and return maxCPULoad.
2440
2441 2014-03-21  Andreas Kling  <akling@apple.com>
2442
2443         RetainPtr API test should use CFArray instead of CFString for testing.
2444         <rdar://problem/16384899>
2445
2446         Unreviewed bot fix.
2447
2448         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
2449         (TestWebKitAPI::TEST):
2450         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
2451         (TestWebKitAPI::TEST):
2452
2453 2014-03-20  Hyowon Kim  <hw1008.kim@samsung.com>
2454
2455         Move to using std::unique_ptr for EFL objects.
2456         https://bugs.webkit.org/show_bug.cgi?id=129853
2457
2458         Reviewed by Gyuyoung Kim.
2459
2460         EflUniquePtr is a template alias of std::unique_ptr
2461         with a custom deleter for each Efl Objects, which is motivated by GUniquePtr.
2462         This patch replaces uses of OwnPtr and PassOwnPtr for Efl objects with EflUniquePtr.
2463
2464         * DumpRenderTree/efl/DumpRenderTree.cpp:
2465         (main):
2466         * ImageDiff/efl/ImageDiff.cpp:
2467         (initEfl):
2468         (main):
2469
2470 2014-03-20  Ryuan Choi  <ryuan.choi@samsung.com>
2471
2472         Unreviewed buildfix after r165983 for non Cocoa platforms
2473
2474         Renamed WKPreferencesPrivate.h to WKPreferencesRefPrivate.h
2475
2476         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
2477         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2478         * WebKitTestRunner/TestController.cpp:
2479
2480 2014-03-20  Zan Dobersek  <zdobersek@igalia.com>
2481
2482         [GTK][CMake] Add support for building with Clang
2483         https://bugs.webkit.org/show_bug.cgi?id=130260
2484
2485         Reviewed by Martin Robinson.
2486
2487         * TestWebKitAPI/CMakeLists.txt: When building with Clang TestWebKitAPI should be
2488         built with GTEST_HAS_TR1_TUPLE defined to 0 to avoid build failures occuring in the
2489         included GTest framework headers.
2490         * gtk/generate-gtkdoc:
2491         (prepare_environment_for_gtkdoc_generation): Don't modify the CFLAGS env anymore
2492         in case of using Clang since that is now set by the CMake rule.
2493
2494 2014-03-19  Simon Fraser  <simon.fraser@apple.com>
2495
2496         Expose text and page zoom in WK2 SPI, and hook them up in MiniBrowser
2497         https://bugs.webkit.org/show_bug.cgi?id=130476
2498
2499         Reviewed by Anders Carlsson.
2500
2501         Hook up page/text zoom in MiniBrowser, make reload work, remove some logging.
2502
2503         * MiniBrowser/mac/WK1BrowserWindowController.m:
2504         (-[WK1BrowserWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2505         Remove log.
2506         * MiniBrowser/mac/WK2BrowserWindowController.m:
2507         (-[WK2BrowserWindowController awakeFromNib]):
2508         (-[WK2BrowserWindowController validateMenuItem:]):
2509         (-[WK2BrowserWindowController reload:]):
2510         Hook up reload.
2511         (-[WK2BrowserWindowController toggleZoomMode:]):
2512         (-[WK2BrowserWindowController resetZoom:]):
2513         (-[WK2BrowserWindowController canResetZoom]):
2514         (-[WK2BrowserWindowController currentZoomFactor]):
2515         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
2516         (-[WK2BrowserWindowController canZoomIn]):
2517         (-[WK2BrowserWindowController canZoomOut]):
2518
2519 2014-03-19  Alexey Proskuryakov  <ap@apple.com>
2520
2521         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
2522         https://bugs.webkit.org/show_bug.cgi?id=130463
2523
2524         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Disable the test.
2525
2526 2014-03-18  Samuel White  <samuel_white@apple.com>
2527
2528         AX: Not able to use arrow keys to read text with VoiceOver before selection is set someplace (anyplace).
2529         https://bugs.webkit.org/show_bug.cgi?id=130250
2530
2531         Reviewed by Chris Fleizach.
2532
2533         Added ability to toggle enhanced accessibility on and off to support tests that require it.
2534
2535         * DumpRenderTree/AccessibilityController.cpp:
2536         (enableEnhancedAccessibilityCallback):
2537         (getEnhancedAccessibilityEnabledCallback):
2538         (AccessibilityController::getJSClass):
2539         * DumpRenderTree/AccessibilityController.h:
2540         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
2541         (AccessibilityController::enableEnhancedAccessibility):
2542         (AccessibilityController::enhancedAccessibilityEnabled):
2543         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
2544         (AccessibilityController::enableEnhancedAccessibility):
2545         (AccessibilityController::enhancedAccessibilityEnabled):
2546         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2547         (AccessibilityController::enableEnhancedAccessibility):
2548         (AccessibilityController::enhancedAccessibilityEnabled):
2549         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2550         (AccessibilityController::enableEnhancedAccessibility):
2551         (AccessibilityController::enhancedAccessibilityEnabled):
2552         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2553         (WTR::AccessibilityController::enableEnhancedAccessibility):
2554         (WTR::AccessibilityController::enhancedAccessibilityEnabled):
2555         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2556         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
2557
2558 2014-03-18  Filip Pizlo  <fpizlo@apple.com>
2559
2560         Unreviewed, add some contributors, and fix Nadav's entry (he's not really a reviewer
2561         yet).
2562
2563         * Scripts/webkitpy/common/config/contributors.json:
2564
2565 2014-03-18  Joseph Pecoraro  <pecoraro@apple.com>
2566
2567         Web Inspector: Remove stale ReportMemoryUsagePlugin
2568         https://bugs.webkit.org/show_bug.cgi?id=130405
2569
2570         Reviewed by Andreas Kling.
2571
2572         This clang plugin looks like it was used for the old Inspector memory
2573         instrumentation that was removed. So the tool can be removed.
2574
2575         * clang/ReportMemoryUsagePlugin/CMakeLists.txt: Removed.
2576         * clang/ReportMemoryUsagePlugin/Makefile: Removed.
2577         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp: Removed.
2578         * clang/ReportMemoryUsagePlugin/tests/Source/WebCore/Test.cpp: Removed.
2579
2580 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2581
2582         webkit-patch land shouldn't add a reviewer for unreviewed build fixes
2583         https://bugs.webkit.org/show_bug.cgi?id=130220
2584
2585         Reviewed by Csaba Osztrogonác.
2586
2587         * Scripts/webkitpy/common/checkout/changelog.py:
2588         (ChangeLog.set_reviewer):
2589         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2590         (test_set_reviewer):
2591
2592 2014-03-17  Filip Pizlo  <fpizlo@apple.com>
2593
2594         More FTL enabling.
2595
2596         Rubber stamped by Dan Bernstein.
2597
2598         * Tools/Scripts/build-webkit:
2599
2600 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2601
2602         Renable pagination mode in WK2 MiniBrowser
2603         https://bugs.webkit.org/show_bug.cgi?id=130374
2604
2605         Reviewed by Anders Carlsson.
2606
2607         Put the implementation of togglePaginationMode: back, and correctly
2608         enable the menu item.
2609
2610         * MiniBrowser/mac/WK2BrowserWindowController.m:
2611         (-[WK2BrowserWindowController validateMenuItem:]):
2612         (-[WK2BrowserWindowController isPaginated]):
2613         (-[WK2BrowserWindowController togglePaginationMode:]):
2614
2615 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2616
2617         Add --reset option to Tools/Scripts/set-webkit-configuration script
2618         https://bugs.webkit.org/show_bug.cgi?id=130401
2619
2620         Reviewed by Csaba Osztrogonác.
2621
2622         * Scripts/set-webkit-configuration:
2623
2624 2014-03-18  Alberto Garcia  <berto@igalia.com>
2625
2626         [GTK] [CMake] build-webkit-options.txt is not generated during a fresh build
2627         https://bugs.webkit.org/show_bug.cgi?id=130388
2628
2629         Reviewed by Sergio Villar Senin.
2630
2631         * Scripts/webkitdirs.pm:
2632         (shouldRemoveCMakeCache): make sure that the build directory
2633         exists before attempting to create a file in it.
2634
2635 2014-03-18  Robert Plociennik  <r.plociennik@samsung.com>
2636
2637         [EFL] fontconfig-2.8.0 is not compliant with C++11 leading to a build break
2638         https://bugs.webkit.org/show_bug.cgi?id=130336
2639
2640         Reviewed by Gyuyoung Kim.
2641
2642         Compilation with gcc 4.8.x results in 'invalid suffix on literal; C++11
2643         requires a space between literal and string macro [-Wliteral-suffix]'
2644         warning treated as error.
2645
2646         This patch applies a solution from r162448 to the EFL port.
2647
2648         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
2649         * efl/jhbuild.modules: Added appropriate patch section.
2650
2651 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
2652
2653         webkitpy test rebaseline.
2654
2655         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2656         (MainTest.test_default_args):
2657
2658 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
2659
2660         --profile should imply --test-runner-count=1 in run-perf-tests
2661         https://bugs.webkit.org/show_bug.cgi?id=130375
2662
2663         Reviewed by Benjamin Poulain.
2664
2665         Use the test runner count of 1 when --profile is specified but not --test-runner-count.
2666
2667         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2668         (PerfTestsRunner._parse_args): Use -1 as the default value.
2669         (PerfTestsRunner._collect_tests): If --test-runner-count is set (i.e. it's a positive value),
2670         then use that value. Otherwise, if it's never set and --profile is present, test-runner-count
2671         should be 1.
2672
2673 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2674
2675         Address some style nits.
2676
2677         * MiniBrowser/mac/WK2BrowserWindowController.m:
2678
2679 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2680
2681         Add transparent window support back into MiniBrowser
2682         https://bugs.webkit.org/show_bug.cgi?id=130363
2683
2684         Reviewed by Anders Carlsson.
2685
2686         Re-enable transparent window support for WK2.
2687
2688         * MiniBrowser/mac/WK2BrowserWindowController.m:
2689         (-[WK2BrowserWindowController validateMenuItem:]):
2690         (-[WK2BrowserWindowController toggleTransparentWindow:]):
2691
2692 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2693
2694         Fix the 32-bit build; make the open panel make a WK1 window.
2695
2696         * MiniBrowser/mac/AppDelegate.m:
2697         (-[BrowserAppDelegate openDocument:]):
2698
2699 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2700
2701         Convert MiniBrowser to use WKWebView API
2702         https://bugs.webkit.org/show_bug.cgi?id=130061
2703
2704         Reviewed by Anders Carlsson.
2705
2706         Convert the MiniBrowser WK2 window to use WebKit2 API as much
2707         as possible.
2708
2709         Some functionality was removed temporarily:
2710             - text zoom, page zoom
2711             - reload
2712             - pagination mode
2713             - transparent window
2714             - dumping source
2715             - window.open support
2716             - beforeUnload panel
2717             - find in page
2718
2719         * MiniBrowser/mac/AppDelegate.h:
2720         * MiniBrowser/mac/AppDelegate.m:
2721         (-[BrowserAppDelegate init]):
2722         (-[BrowserAppDelegate newWindow:]):
2723         (-[BrowserAppDelegate applicationWillTerminate:]):
2724         (-[BrowserAppDelegate openDocument:]):
2725         * MiniBrowser/mac/WK2BrowserWindowController.h:
2726         * MiniBrowser/mac/WK2BrowserWindowController.m:
2727         (-[WK2BrowserWindowController awakeFromNib]):
2728         (-[WK2BrowserWindowController dealloc]):
2729         (-[WK2BrowserWindowController fetch:]):
2730         (-[WK2BrowserWindowController validateMenuItem:]):
2731         (-[WK2BrowserWindowController reload:]):
2732         (-[WK2BrowserWindowController goBack:]):
2733         (-[WK2BrowserWindowController goForward:]):
2734         (-[WK2BrowserWindowController toggleZoomMode:]):
2735         (-[WK2BrowserWindowController resetZoom:]):
2736         (-[WK2BrowserWindowController canResetZoom]):
2737         (-[WK2BrowserWindowController dumpSourceToConsole:]):
2738         (-[WK2BrowserWindowController togglePaginationMode:]):
2739         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
2740         (-[WK2BrowserWindowController windowShouldClose:]):
2741         (-[WK2BrowserWindowController applicationTerminating]):
2742         (-[WK2BrowserWindowController currentZoomFactor]):
2743         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
2744         (-[WK2BrowserWindowController toggleTransparentWindow:]):
2745         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
2746         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2747         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
2748         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
2749         (-[WK2BrowserWindowController find:]):
2750         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
2751         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
2752         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
2753         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
2754         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
2755         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
2756         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
2757         * WebKitTestRunner/PlatformWebView.h:
2758         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2759         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2760
2761 2014-03-17  Zan Dobersek  <zdobersek@igalia.com>
2762
2763         Use RunLoop objects through references instead of pointers
2764         https://bugs.webkit.org/show_bug.cgi?id=130313
2765
2766         Reviewed by Andreas Kling.
2767
2768         Adjust the code accordingly now that RunLoop::current() and RunLoop::main()
2769         return RunLoop reference instead of a pointer.
2770
2771         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
2772         (loadedCallback):
2773         (clickedCallback):
2774
2775 2014-03-17  Tim Horton  <timothy_horton@apple.com>
2776
2777         sort-export-file --help doesn't work (missing 'use')
2778         https://bugs.webkit.org/show_bug.cgi?id=130338
2779
2780         Reviewed by Anders Carlsson.
2781
2782         * Scripts/sort-export-file:
2783         Add a missing 'use', and fix a typo in an error message.
2784
2785 2014-03-17  Martin Robinson  <mrobinson@igalia.com>
2786
2787         [GTK][CMake] Ensure that HAVE_GTK_UNIX_PRINTING is defined when appropriate
2788         https://bugs.webkit.org/show_bug.cgi?id=130155
2789
2790         Reviewed by Philippe Normand.
2791
2792         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add GTK_UNIX_PRINT flags to the build.
2793
2794 2014-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2795
2796         [GTK] MiniBrowser fails to load injected bundle lib
2797         https://bugs.webkit.org/show_bug.cgi?id=130332
2798
2799         Reviewed by Anders Carlsson.
2800
2801         This is because WEBKIT_INJECTED_BUNDLE_PATH env var is set too late.
2802
2803         * MiniBrowser/gtk/main.c:
2804         (main): Make sure WEBKIT_INJECTED_BUNDLE_PATH is set before a web
2805         process is spawn.
2806
2807 2014-03-16  Kim Byung Jun  <bj1987.kim@samsung.com>
2808
2809         [EFL] Enable TOUCH_SLIDER macro
2810         https://bugs.webkit.org/show_bug.cgi?id=130185
2811
2812         Reviewed by Gyuyoung Kim.
2813
2814         * Scripts/webkitperl/FeatureList.pm:
2815
2816 2014-03-16  Zan Dobersek  <zdobersek@igalia.com>
2817
2818         [GTK][CMake] Build with -fno-rtti
2819         https://bugs.webkit.org/show_bug.cgi?id=130261
2820
2821         Reviewed by Martin Robinson.
2822
2823         * TestWebKitAPI/CMakeLists.txt: Build TestWebKitAPI with GTEST_HAS_RTTI macro
2824         defined to 0 to prevent typeid use in included GTest headers.
2825
2826 2014-03-16  Brian Burg  <bburg@apple.com>
2827
2828         Web Inspector: vended backend commands file should be generated as part of the build
2829         https://bugs.webkit.org/show_bug.cgi?id=130110
2830
2831         Reviewed by Timothy Hatcher.
2832
2833         * Scripts/build-webkit: build WebInspectorUI after WebCore but before WebKit.
2834
2835 2014-03-16  Diego Pino García  <dpino@igalia.com>
2836
2837         [GTK] Minibrowser: Add shortcuts for reloading page and reloading page ignoring cache
2838         https://bugs.webkit.org/show_bug.cgi?id=128999
2839
2840         Reviewed by Philippe Normand.
2841
2842         * MiniBrowser/gtk/BrowserWindow.c:
2843         (reloadPage):
2844         (reloadPageIgnoringCache):
2845         (browser_window_init):
2846
2847 2014-03-15  Martin Robinson  <mrobinson@igalia.com>
2848
2849         [GTK] Improve ninja detection in webkitdirs.pm
2850         https://bugs.webkit.org/show_bug.cgi?id=129902
2851
2852         Reviewed by Daniel Bates.
2853
2854         * Scripts/webkitdirs.pm:
2855         (canUseNinja): Use which instead of trying to invoke ninja directly. This also allows
2856         us to look for ninja-build as well.
2857
2858 2014-03-14  Maciej Stachowiak  <mjs@apple.com>
2859
2860         Replace "Apple Computer, Inc." with "Apple Inc." in copyright headers
2861         https://bugs.webkit.org/show_bug.cgi?id=130276
2862         <rdar://problem/16266927>
2863
2864         Reviewed by Simon Fraser.
2865
2866         * BuildSlaveSupport/build-launcher-app:
2867         * BuildSlaveSupport/build-launcher-dmg:
2868         * DumpRenderTree/DumpRenderTree.h:
2869         * DumpRenderTree/DumpRenderTreePrefix.h:
2870         * DumpRenderTree/GCController.cpp:
2871         * DumpRenderTree/GCController.h:
2872         * DumpRenderTree/JavaScriptThreading.cpp:
2873         * DumpRenderTree/JavaScriptThreading.h:
2874         * DumpRenderTree/PixelDumpSupport.cpp:
2875         * DumpRenderTree/PixelDumpSupport.h:
2876         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
2877         * DumpRenderTree/TestRunner.cpp:
2878         * DumpRenderTree/TestRunner.h:
2879         * DumpRenderTree/WorkQueue.cpp:
2880         * DumpRenderTree/WorkQueue.h:
2881         * DumpRenderTree/WorkQueueItem.h:
2882         * DumpRenderTree/atk/AccessibilityCallbacks.h:
2883         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
2884         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
2885         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
2886         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2887         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2888         * DumpRenderTree/efl/EditingCallbacks.cpp:
2889         * DumpRenderTree/efl/EditingCallbacks.h:
2890         * DumpRenderTree/efl/EventSender.cpp:
2891         * DumpRenderTree/efl/EventSender.h:
2892         * DumpRenderTree/efl/GCControllerEfl.cpp:
2893         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
2894         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2895         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2896         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
2897         * DumpRenderTree/gtk/EditingCallbacks.cpp:
2898         * DumpRenderTree/gtk/EditingCallbacks.h:
2899         * DumpRenderTree/gtk/EventSender.cpp:
2900         * DumpRenderTree/gtk/EventSender.h:
2901         * DumpRenderTree/gtk/GCControllerGtk.cpp:
2902         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
2903         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp:
2904         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h:
2905         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2906         * DumpRenderTree/gtk/TextInputController.cpp:
2907         * DumpRenderTree/gtk/TextInputController.h:
2908         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL:
2909         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
2910         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2911         * DumpRenderTree/mac/AppleScriptController.h:
2912         * DumpRenderTree/mac/AppleScriptController.m:
2913         * DumpRenderTree/mac/CheckedMalloc.cpp:
2914         * DumpRenderTree/mac/CheckedMalloc.h:
2915         * DumpRenderTree/mac/DumpRenderTree.mm:
2916         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
2917         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2918         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2919         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
2920         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
2921         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2922         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2923         * DumpRenderTree/mac/EditingDelegate.h:
2924         * DumpRenderTree/mac/EditingDelegate.mm:
2925         * DumpRenderTree/mac/EventSendingController.h:
2926         * DumpRenderTree/mac/EventSendingController.mm:
2927         * DumpRenderTree/mac/FrameLoadDelegate.h:
2928         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2929         * DumpRenderTree/mac/GCControllerMac.mm:
2930         * DumpRenderTree/mac/MockWebNotificationProvider.h:
2931         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
2932         * DumpRenderTree/mac/NavigationController.h:
2933         * DumpRenderTree/mac/NavigationController.m:
2934         * DumpRenderTree/mac/ObjCController.h:
2935         * DumpRenderTree/mac/ObjCController.m:
2936         * DumpRenderTree/mac/ObjCPlugin.h:
2937         * DumpRenderTree/mac/ObjCPlugin.m:
2938         * DumpRenderTree/mac/ObjCPluginFunction.h:
2939         * DumpRenderTree/mac/ObjCPluginFunction.m:
2940         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2941         * DumpRenderTree/mac/PolicyDelegate.h:
2942         * DumpRenderTree/mac/PolicyDelegate.mm:
2943         * DumpRenderTree/mac/ResourceLoadDelegate.h:
2944         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2945         * DumpRenderTree/mac/TestRunnerMac.mm:
2946         * DumpRenderTree/mac/TextInputController.h:
2947         * DumpRenderTree/mac/TextInputController.m:
2948         * DumpRenderTree/mac/UIDelegate.h:
2949         * DumpRenderTree/mac/UIDelegate.mm:
2950         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2951         * DumpRenderTree/win/DRTDataObject.cpp:
2952         * DumpRenderTree/win/DRTDataObject.h:
2953         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
2954         * DumpRenderTree/win/DRTDropSource.cpp:
2955         * DumpRenderTree/win/DRTDropSource.h:
2956         * DumpRenderTree/win/DraggingInfo.h:
2957         * DumpRenderTree/win/DumpRenderTree.cpp:
2958         * DumpRenderTree/win/DumpRenderTreeWin.h:
2959         * DumpRenderTree/win/EditingDelegate.cpp:
2960         * DumpRenderTree/win/EditingDelegate.h:
2961         * DumpRenderTree/win/EventSender.cpp:
2962         * DumpRenderTree/win/EventSender.h:
2963         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2964         * DumpRenderTree/win/FrameLoadDelegate.h:
2965         * DumpRenderTree/win/GCControllerWin.cpp:
2966         * DumpRenderTree/win/HistoryDelegate.cpp:
2967         * DumpRenderTree/win/HistoryDelegate.h:
2968         * DumpRenderTree/win/MD5.cpp:
2969         * DumpRenderTree/win/MD5.h:
2970         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2971         * DumpRenderTree/win/PolicyDelegate.cpp:
2972         * DumpRenderTree/win/PolicyDelegate.h:
2973         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2974         * DumpRenderTree/win/ResourceLoadDelegate.h:
2975         * DumpRenderTree/win/TestRunnerWin.cpp:
2976         * DumpRenderTree/win/TextInputController.cpp:
2977         * DumpRenderTree/win/TextInputController.h:
2978         * DumpRenderTree/win/TextInputControllerWin.cpp:
2979         * DumpRenderTree/win/UIDelegate.cpp:
2980         * DumpRenderTree/win/UIDelegate.h:
2981         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2982         * EWebLauncher/main.c:
2983         * GtkLauncher/main.c:
2984         * ImageDiff/efl/ImageDiff.cpp:
2985         * ImageDiff/gtk/ImageDiff.cpp:
2986         * MiniBrowser/gtk/main.c:
2987         * Scripts/SpacingHeuristics.pm:
2988         * Scripts/VCSUtils.pm:
2989         * Scripts/bisect-builds:
2990         * Scripts/build-dumprendertree:
2991         * Scripts/build-jsc:
2992         * Scripts/build-webkit:
2993         * Scripts/check-dom-results:
2994         * Scripts/check-for-exit-time-destructors:
2995         * Scripts/check-for-global-initializers:
2996         * Scripts/commit-log-editor:
2997         * Scripts/compare-timing-files:
2998         * Scripts/debug-minibrowser:
2999         * Scripts/debug-safari:
3000         * Scripts/do-file-rename:
3001         * Scripts/find-extra-includes:
3002         * Scripts/generate-coverage-data:
3003         * Scripts/make-script-test-wrappers:
3004         * Scripts/malloc-tree:
3005         * Scripts/old-run-webkit-tests:
3006         * Scripts/parse-malloc-history:
3007         * Scripts/report-include-statistics:
3008         * Scripts/resolve-ChangeLogs:
3009         * Scripts/run-bindings-tests:
3010         * Scripts/run-iexploder-tests:
3011         * Scripts/run-javascriptcore-tests:
3012         * Scripts/run-jsc:
3013         * Scripts/run-launcher:
3014         * Scripts/run-leaks:
3015         * Scripts/run-mangleme-tests:
3016         * Scripts/run-minibrowser:
3017         * Scripts/run-pageloadtest:
3018         * Scripts/run-regexp-tests:
3019         * Scripts/run-safari:
3020         * Scripts/run-sunspider:
3021         * Scripts/run-webkit-app:
3022         * Scripts/sampstat:
3023         * Scripts/set-webkit-configuration:
3024         * Scripts/sort-Xcode-project-file:
3025         * Scripts/sort-export-file:
3026         * Scripts/split-file-by-class:
3027         * Scripts/sunspider-compare-results:
3028         * Scripts/svn-apply:
3029         * Scripts/svn-create-patch:
3030         * Scripts/svn-unapply:
3031         * Scripts/test-webkit-scripts:
3032         * Scripts/update-javascriptcore-test-results:
3033         * Scripts/update-webkit:
3034         * Scripts/update-webkit-auxiliary-libs:
3035         * Scripts/update-webkit-dependency:
3036         * Scripts/update-webkit-localizable-strings:
3037         * Scripts/update-webkit-support-libs:
3038         * Scripts/update-webkit-wincairo-libs:
3039         * Scripts/webkit-build-directory:
3040         * Scripts/webkitdirs.pm:
3041         (installedSafariPath):
3042         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
3043         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
3044         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
3045         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
3046         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
3047         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
3048         * Scripts/webkitperl/features.pm:
3049         * Scripts/webkitperl/httpd.pm:
3050         * Scripts/webkitpy/bindings/main.py:
3051         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
3052         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3053         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3054         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
3055         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
3056         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
3057         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
3058         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3059         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
3060         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.h:
3061         * WebKitTestRunner/PixelDumpSupport.cpp:
3062         * WebKitTestRunner/PixelDumpSupport.h:
3063         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3064         * WinLauncher/WinLauncher.cpp:
3065         * WinLauncher/WinLauncher.h:
3066         * WinLauncher/stdafx.cpp:
3067         * WinLauncher/stdafx.h:
3068
3069 2014-03-14  Filip Pizlo  <fpizlo@apple.com>
3070
3071         Sometimes we need to be explicit about the SDK when running ranlib on Darwin
3072         https://bugs.webkit.org/show_bug.cgi?id=130265
3073
3074         Reviewed by Michael Saboff.
3075
3076         * Scripts/build-webkit:
3077         * Scripts/copy-webkitlibraries-to-product-directory:
3078
3079 2014-03-14  Landry Breuil  <landry@openbsd.org>
3080
3081         Recognize openbsd/netbsd and am64 archs in Tools/Scripts.
3082         Also allow to set MAKE in the environment.
3083         https://bugs.webkit.org/show_bug.cgi?id=129991
3084
3085         Reviewed by Andreas Kling.
3086
3087         * Scripts/webkitdirs.pm:
3088         (determineArchitecture):
3089         (determineNumberOfCPUs):
3090         (isBSD):
3091         (buildAutotoolsProject):
3092         * Scripts/webkitpy/common/system/platforminfo.py:
3093         (PlatformInfo.__init__):
3094         (PlatformInfo.is_openbsd):
3095         (PlatformInfo):
3096         (PlatformInfo.is_netbsd):
3097         (PlatformInfo._determine_os_name):
3098
3099 2014-03-14  Dean Jackson  <dino@apple.com>
3100
3101         Remove libWebKitSystemInterfaceLion.a
3102         https://bugs.webkit.org/show_bug.cgi?id=130254
3103
3104         Reviewed by Geoffrey Garen and Andreas Kling.
3105
3106         No need to copy the Lion libraries into the build.
3107
3108         * Scripts/copy-webkitlibraries-to-product-directory:
3109
3110 2014-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
3111
3112         [EFL][MiniBrowser] Revise help messages of command line parameters
3113         https://bugs.webkit.org/show_bug.cgi?id=130222
3114
3115         Reviewed by Csaba Osztrogonác.
3116
3117         Correct the default value description and make help messages to be consistent.
3118
3119         * MiniBrowser/efl/main.c:
3120
3121 2014-03-12  Sergio Villar Senin  <svillar@igalia.com>
3122
3123         Rename DEFINE_STATIC_LOCAL to DEPRECATED_DEFINE_STATIC_LOCAL
3124         https://bugs.webkit.org/show_bug.cgi?id=129612
3125
3126         Reviewed by Darin Adler.
3127
3128         For new code use static NeverDestroyed<T> instead.
3129
3130         * DumpRenderTree/JavaScriptThreading.cpp:
3131         (javaScriptThreadsMutex):
3132         (javaScriptThreads):
3133         * DumpRenderTree/efl/EventSender.cpp:
3134         (touchPointList):
3135         (delayedEventQueue):
3136         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3137         (delegatesWithDelayedWork):
3138         * Scripts/check-for-exit-time-destructors:
3139         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
3140         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
3141         (testsMap):
3142
3143 2014-03-13  Sanghyup Lee  <sh53.lee@samsung.com>
3144
3145         [EFL][WK2] Fix compilation warning in Minibrowser
3146         https://bugs.webkit.org/show_bug.cgi?id=130132
3147
3148         Reviewed by Csaba Osztrogonác.
3149
3150         Replace mktemp() with mkstemp() to fix compilation warning in MiniBrowser.
3151
3152         * MiniBrowser/efl/main.c:
3153         (on_download_request):
3154
3155 2014-03-13  Filip Pizlo  <fpizlo@apple.com>
3156
3157         FTL should support IsBlah
3158         https://bugs.webkit.org/show_bug.cgi?id=130202
3159
3160         Reviewed by Geoffrey Garen.
3161
3162         Running existing JSRegress tests with noInline gives us coverage for these
3163         changes. Chances are, this will also give coverage for other interesting things
3164         as well.
3165
3166         * Scripts/run-jsc-stress-tests:
3167
3168 2014-03-12  Brian Burg  <bburg@apple.com>
3169
3170         Web Inspector: Remove unused callId parameter from evaluateInWebInspector
3171         https://bugs.webkit.org/show_bug.cgi?id=129744
3172
3173         Reviewed by Timothy Hatcher.
3174
3175         * DumpRenderTree/TestRunner.cpp:
3176         (evaluateInWebInspectorCallback):
3177         * DumpRenderTree/TestRunner.h:
3178         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3179         (TestRunner::evaluateInWebInspector):
3180         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3181         (TestRunner::evaluateInWebInspector):
3182         * DumpRenderTree/mac/TestRunnerMac.mm:
3183         (TestRunner::evaluateInWebInspector):
3184         * DumpRenderTree/win/TestRunnerWin.cpp:
3185         (TestRunner::evaluateInWebInspector):
3186         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3187         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3188         (WTR::TestRunner::evaluateInWebInspector):
3189         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3190
3191 2014-03-13  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
3192
3193         [GTK] build-webkit shouldn't show error message when ninja isn't installed
3194         https://bugs.webkit.org/show_bug.cgi?id=130129
3195
3196         Reviewed by Csaba Osztrogonác.
3197
3198         * Scripts/webkitdirs.pm:
3199         (canUseNinja): Redirecting stderr to /dev/null
3200
3201 2014-03-13  Andres Gomez  <agomez@igalia.com>
3202
3203         [GTK] "Tools/jhbuild/jhbuild-wrapper --gtk" build fails even after running Tools/gtk/install-dependencies due to missing proper libxml2 python bindings
3204         https://bugs.webkit.org/show_bug.cgi?id=130092
3205
3206         Reviewed by Csaba Osztrogonác.
3207
3208         Added "python-dev" as dependency for deb based distros. It is
3209         already present for rpm based distros. This dependency will allow
3210         libxml2 to generate its python bindings, needed by gtk-doc.
3211
3212         * gtk/install-dependencies:
3213
3214 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3215
3216         Unreviewed. Fix GTK+ cmake build after r165488.
3217
3218         * MiniBrowser/gtk/CMakeLists.txt: Add CMAKE_BINARY_DIR to include dirs.
3219
3220 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3221
3222         [GTK][CMAKE] Remove compile warnings about GTK+ deprecated API
3223         https://bugs.webkit.org/show_bug.cgi?id=130014
3224
3225         Reviewed by Martin Robinson.
3226
3227         Include cmake or autotools config header.
3228
3229         * MiniBrowser/gtk/BrowserDownloadsBar.c:
3230         * MiniBrowser/gtk/BrowserSearchBar.c:
3231         * MiniBrowser/gtk/BrowserWindow.c:
3232         * MiniBrowser/gtk/main.c:
3233
3234 2014-03-12  Commit Queue  <commit-queue@webkit.org>
3235
3236         Unreviewed, rolling out r165471.
3237         https://bugs.webkit.org/show_bug.cgi?id=130139
3238
3239         Didn't really fix the issue and broke another bot (Requested
3240         by mrobinson on #webkit).
3241
3242         Reverted changeset:
3243
3244         "[CMake] Newer versions of CMake cannot find older versions of
3245         Freetype"
3246         https://bugs.webkit.org/show_bug.cgi?id=130107
3247         http://trac.webkit.org/changeset/165471
3248
3249 2014-03-11  Filip Pizlo  <fpizlo@apple.com>
3250
3251         It should be possible to build WebKit with FTL on iOS
3252         https://bugs.webkit.org/show_bug.cgi?id=130116
3253
3254         Reviewed by Dan Bernstein.
3255
3256         * Scripts/build-webkit:
3257         * Scripts/copy-webkitlibraries-to-product-directory:
3258
3259 2014-03-12  Brent Fulgham  <bfulgham@apple.com>
3260
3261         [Win] Remove use of QTSDK
3262         https://bugs.webkit.org/show_bug.cgi?id=130049
3263
3264         Reviewed by Darin Adler.
3265
3266         * DumpRenderTree/win/DumpRenderTree.cpp:
3267         (initialize): Remove QuickTime code.
3268         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't grab logs from
3269         building QTMovieWin.
3270
3271 2014-03-12  Martin Robinson  <mrobinson@igalia.com>
3272
3273         [GTK][CMAKE] Too verbose build output
3274         https://bugs.webkit.org/show_bug.cgi?id=130076
3275
3276         Reviewed by Carlos Garcia Campos.
3277
3278         Instead of building with cmake --build which isn't smart about pretty printing and
3279         colors, we build with a script which calls the proper build command.
3280
3281         * Scripts/webkitdirs.pm:
3282         (buildCMakeGeneratedProject): For GTK+ call the script that we generate during
3283         the CMake configuration pass.
3284
3285 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
3286
3287         [CMake] Newer versions of CMake cannot find older versions of Freetype
3288         https://bugs.webkit.org/show_bug.cgi?id=130107
3289
3290         Reviewed by Gustavo Noronha Silva.
3291
3292         * gtk/jhbuildrc: Work around a bug in newer CMakes by giving the FREETYPE_DIR hint
3293         to CMake during jhbuild initialization.
3294
3295 2014-03-12  Zalan Bujtas  <zalan@apple.com>
3296
3297         Add hiDPI support for compositing content in DumpRenderTree/WebKitTestRunner
3298         https://bugs.webkit.org/show_bug.cgi?id=129961
3299
3300         Reviewed by Simon Fraser.
3301
3302         Now scaled content can go through the window capturing mechanism too for compositing content.
3303         AppleMagnifiedMode is redundant.
3304
3305         * DumpRenderTree/mac/DumpRenderTree.mm:
3306         (setDefaultsToConsistentValuesForTesting):
3307         (runTest):
3308         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3309         (createBitmapContextFromWebView):
3310         * WebKitTestRunner/PlatformWebView.h:
3311         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3312         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3313         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3314         (WTR::PlatformWebView::didInitializeClients):
3315         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3316         (WTR::PlatformWebView::forceWindowFramesChanged):
3317         * WebKitTestRunner/mac/main.mm:
3318         (setDefaultsToConsistentValuesForTesting):
3319
3320 2014-03-12  Anton Obzhirov  <a.obzhirov@samsung.com>
3321
3322         Unreviewed. Add myself as a committer.
3323
3324         * Scripts/webkitpy/common/config/contributors.json:
3325
3326 2014-03-12  Ryuan Choi  <ryuan.choi@samsung.com>
3327
3328         Unreviewed build fix on the EFL port when used lower version of ATK
3329
3330         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3331         (WTR::AccessibilityUIElement::y): Fixed typo.
3332
3333 2014-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
3334
3335         Some images are blank in the rebaseline server UI
3336         https://bugs.webkit.org/show_bug.cgi?id=130104
3337
3338         Reviewed by Tim Horton.
3339
3340         Let the server check for images in the 'retries' directory
3341         if it can't find an image otherwise.
3342
3343         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3344         (RebaselineHTTPRequestHandler.test_result):
3345
3346 2014-03-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
3347
3348         [GTK][CMake] --update-gtk has no effect
3349         https://bugs.webkit.org/show_bug.cgi?id=130088
3350
3351         Reviewed by Philippe Normand.
3352
3353         * Scripts/webkitdirs.pm:
3354         (buildCMakeProjectOrExit): call update-webkitgtk-libs if --update-gtk has been passed
3355         as an argument.
3356
3357 2014-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
3358
3359         Add "System Font" to the list of whitelisted DRT fonts
3360         https://bugs.webkit.org/show_bug.cgi?id=130046
3361
3362         Reviewed by Darin Adler.
3363
3364         * DumpRenderTree/mac/DumpRenderTree.mm:
3365         (allowedFontFamilySet):
3366         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3367
3368 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
3369
3370         [GTK] The jhbuild environment should set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_PATH
3371         https://bugs.webkit.org/show_bug.cgi?id=130064
3372
3373         Reviewed by Philippe Normand.
3374
3375         * efl/jhbuildrc: Remove duplicated code.
3376         * gtk/jhbuildrc: Remove duplicated code.
3377         * jhbuild/jhbuildrc_common.py:
3378         (init): Move duplicated code from jhbuildrc's and extend setting CMake environment variables to
3379         GTK+. We always set the CMAKE_LIBRARY_PATH, which should be harmless for EFL 32-bit systems.
3380         and is apparently necessary for GTK+.
3381
3382 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
3383
3384         check-webkit-style failed to complain about missing braces
3385         https://bugs.webkit.org/show_bug.cgi?id=34189
3386
3387         Reviewed by Ryosuke Niwa.
3388
3389         * Scripts/webkitpy/style/checkers/cpp.py:
3390         (check_braces):
3391         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3392         (WebKitStyleTest.test_braces):
3393
3394 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
3395
3396         Remove Qt cruft from style checker.
3397         https://bugs.webkit.org/show_bug.cgi?id=130085
3398
3399         Reviewed by Csaba Osztrogonác.
3400
3401         There is no 'foreach' keyword in c++. That was a Qt feature
3402         added in: http://trac.webkit.org/changeset/46113
3403         Qt was removed from WebKit, so we should remove the checks
3404         of this keyword from check-webkit-style scripts.
3405
3406         * Scripts/webkitpy/style/checkers/cpp.py:
3407         (check_spacing_for_function_call):
3408         (check_spacing):
3409         (check_braces):
3410         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3411         (CppStyleTest.test_mismatching_spaces_in_parens):
3412         (CppStyleTest.test_spacing_for_fncall):
3413         (WebKitStyleTest.test_braces):
3414
3415 2014-03-11  Martin Hodovan  <mhodovan@inf.u-szeged.hu>
3416
3417         [GTK] update-webkitgtk-libs needs itstool
3418         https://bugs.webkit.org/show_bug.cgi?id=130082
3419
3420         After http://trac.webkit.org/changeset/165110 WebKitGTK+ uses gtk-doc 1.20.
3421         itstool is a dependency of building gtk-doc from version 1.19, so it should
3422         be added to Tools/gtk/install-dependencies script, too.
3423
3424         Reviewed by Philippe Normand.
3425
3426         * gtk/install-dependencies:
3427
3428 2014-03-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3429
3430         webkitbot rollout ChangeLogs should be nicer
3431         https://bugs.webkit.org/show_bug.cgi?id=122654
3432
3433         Reviewed by Csaba Osztrogonác.
3434
3435         Added bug urls and descriptions of rolled out patches to the rollout changelog
3436         if they are present in the original changelog. Additionally removed the list of
3437         changed files and functions.
3438
3439         * Scripts/webkitpy/common/checkout/changelog.py:
3440         (ChangeLog.update_with_unreviewed_message): Cut off the list of modified files.
3441         * Scripts/webkitpy/common/checkout/checkout.py:
3442         (Checkout._changelog_data_for_revision): Store bug description.
3443         * Scripts/webkitpy/common/checkout/checkout_mock.py:
3444         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3445         (CheckoutTest.test_commit_info_for_revision):
3446         * Scripts/webkitpy/common/checkout/commitinfo.py:
3447         (CommitInfo.bug_description): Added.
3448         (CommitInfo.to_json):
3449         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
3450         (CommitInfoTest.test_commit_info_creation):
3451         * Scripts/webkitpy/tool/commands/download.py:
3452         (AbstractRolloutPrepCommand._prepare_state): Store bug ids and descriptions of rolled
3453         out patches for creating rollout changelog.
3454         (CreateRollout._prepare_state): Remove obsolete comments and code, the bug id that
3455         caused the regression is stored in state["bug_blocked"] now.
3456         * Scripts/webkitpy/tool/commands/download_unittest.py:
3457         (test_prepare_rollout):
3458         (test_create_rollout_multiple_revision):
3459         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3460         (PrepareChangeLogForRevert._message_for_revert): Add bug urls and descriptions of
3461         rolled out patches to the changelog.
3462         (PrepareChangeLogForRevert.run):
3463         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
3464         (UpdateChangeLogsForRevertTest):
3465         (test_message_for_revert):
3466         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
3467         (ReopenBugAfterRollout.run):
3468
3469 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
3470
3471         [ATK] Adjust WKTR/DRT to use new API from ATK 2.11.90
3472         https://bugs.webkit.org/show_bug.cgi?id=130021
3473
3474         Reviewed by Mario Sanchez Prada.
3475
3476         Replace deprecated functions to use new API from ATK 2.11.90.
3477
3478         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3479         (AccessibilityUIElement::x):
3480         (AccessibilityUIElement::y):
3481         (AccessibilityUIElement::width):
3482         (AccessibilityUIElement::height):
3483         (AccessibilityUIElement::clickPointX):
3484         (AccessibilityUIElement::clickPointY):
3485         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3486         (WTR::AccessibilityUIElement::x):
3487         (WTR::AccessibilityUIElement::y):
3488         (WTR::AccessibilityUIElement::width):
3489         (WTR::AccessibilityUIElement::height):
3490         (WTR::AccessibilityUIElement::clickPointX):
3491         (WTR::AccessibilityUIElement::clickPointY):
3492
3493 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
3494
3495         [ATK] Expose aria-posinset and aria-setsize through object attributes
3496         https://bugs.webkit.org/show_bug.cgi?id=130011
3497
3498         Reviewed by Chris Fleizach.
3499
3500         Added missing implementation of numberAttributeValue both to WKTR and DRT.
3501
3502         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3503         (AccessibilityUIElement::numberAttributeValue):
3504         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3505         (WTR::AccessibilityUIElement::numberAttributeValue):
3506
3507 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
3508
3509         [Win] Unreviewed build fix.
3510
3511         Some bad Windows code was committed at some point that prevents the Apple Windows port
3512         from finding its runtime dependencies reliably.
3513
3514         * win/DLLLauncher/DLLLauncherMain.cpp:
3515         (appleApplicationSupportDirectory): Restored this function.
3516         (modifyPath): Update to use appleApplicationSupportDirectory function.
3517
3518 2014-03-10  Zoltan Horvath  <zoltan@webkit.org>
3519
3520         Let the user define the full address of the performance-site-server for uploading results
3521         https://bugs.webkit.org/show_bug.cgi?id=129819
3522
3523         Reviewed by Ryosuke Niwa.
3524
3525         Currently perftestsrunner.py assumes that the server uses https protocol all the time, which
3526         can be confusing. It's more straightforward, if you need to define explicitly the server's full
3527         address along with the protocol, when you're using this parameter. I added HTTPS as the default
3528         protocol for now, in order to avoid breaking the perf bots.
3529
3530         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3531         (_upload_json):
3532         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3533         (MainTest.test_upload_json):
3534
3535 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
3536
3537         [Win] Pass environment to Pre-Build, Pre-Link, and Post-Build Stages.
3538         https://bugs.webkit.org/show_bug.cgi?id=130023
3539
3540         Reviewed by Dean Jackson.
3541
3542         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add missing
3543         /SAFESEH flag to DLL launcher process.
3544
3545 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
3546
3547         RunGtkWebKitGObjectDOMBindingsAPIBreakTests should be added to the BuildAndTestFactory not the TestFactory
3548         https://bugs.webkit.org/show_bug.cgi?id=129980
3549
3550         Reviewed by Carlos Garcia Campos.
3551
3552         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add RunGtkWebKitGObjectDOMBindingsAPIBreakTests to the correct factory.
3553
3554 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
3555
3556         [GTK] Remove the WebView source-mode WebKit1 test
3557         https://bugs.webkit.org/show_bug.cgi?id=129976
3558
3559         Reviewed by Carlos Garcia Campos.
3560
3561         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Remove the source-mode test.
3562
3563 2014-03-08  Martin Robinson  <mrobinson@igalia.com>
3564
3565         Unreviewed build fix for GTKbuild after the switch to CMake
3566
3567         * gtk/common.py:
3568         (is_cmake_build): Like r165284, we need to assume CMake by default, since the
3569         test-only bot doesn't have any build files.
3570
3571 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
3572
3573         [GTK] built-product-archive does not handle GTK+ CMake build
3574         https://bugs.webkit.org/show_bug.cgi?id=129941
3575
3576         * BuildSlaveSupport/built-product-archive:
3577         (archiveBuiltProduct): Fix the build by adding support to built-product-archive for
3578         the CMake build.
3579
3580 2014-03-07  Lorenzo Tilve  <ltilve@igalia.com>
3581
3582         [GTK] Include CMake into install-dependencies script
3583         https://bugs.webkit.org/show_bug.cgi?id=129909
3584
3585         Reviewed by Martin Robinson.
3586
3587         As since r165267 buid-webkit uses CMake by default, the dependency
3588         with 'cmake' package should be introduced.
3589
3590         * gtk/install-dependencies: Ditto.
3591
3592 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
3593
3594         REGRESSION(165267): Broke a webkitpy unit tests
3595         https://bugs.webkit.org/show_bug.cgi?id=129904
3596
3597         Reviewed by Jon Honeycutt.
3598
3599         * Scripts/webkitpy/port/gtk.py: Flip the default test to assume CMake by default.
3600         (GtkPort._is_cmake_build):
3601
3602 2014-03-07  Andres Gomez  <agomez@igalia.com>
3603
3604         [GTK] webkit-patch setup-git-clone fails even after running Tools/gtk/install-dependencies
3605         https://bugs.webkit.org/show_bug.cgi?id=129893
3606
3607         Reviewed by Martin Robinson.
3608
3609         Added "git-svn" as dependency for deb based distros and,
3610         additionally, "subversion" for rpm based distros.
3611
3612         * gtk/install-dependencies:
3613
3614 2014-03-07  Roger Fong  <roger_fong@apple.com>
3615
3616         Remove dummy setSystemWebGLLoadPolicy client method.
3617         https://bugs.webkit.org/show_bug.cgi?id=129873.
3618
3619         Reviewed by Dean Jackson.
3620
3621         * WebKitTestRunner/TestController.cpp:
3622         (WTR::TestController::createWebViewWithOptions):
3623
3624 2014-03-07  Mark Hahnenberg  <mhahnenberg@apple.com>
3625
3626         run-jsc-stress-tests doesn't eagerly report test failures when using the shell runner
3627         https://bugs.webkit.org/show_bug.cgi?id=129886
3628
3629         Reviewed by Mark Lam.
3630
3631         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Added a "verbose" mode to the shell runner.
3632         If we're in verbose mode, then we don't redirect any output when running each test. If we're not
3633         in verbose mode then we redirect stdout to /dev/null and allow any stderr output through.
3634         * Scripts/run-jsc-stress-tests: Redirect any sort of error output to stderr so that it will
3635         make it through when in non-verbose mode.
3636
3637 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
3638
3639         [GTK] buid-webkit should use CMake by default
3640         https://bugs.webkit.org/show_bug.cgi?id=129855
3641
3642         Reviewed by Carlos Garcia Campos.
3643
3644         Make the CMake build the default GTK+ build when using build-webkit. This will
3645         ensure that all bots are using CMake. We do this by swapping --gtk and --gtkcmake,
3646         so that we have --gtk and --gtkautotools.
3647
3648         * Scripts/webkitdirs.pm: Swap --gtkcmake/--gtk for --gtk/--gtkautotools.
3649         * Scripts/webkitpy/port/gtk.py: Ditto.
3650
3651 2014-03-06  Martin Robinson  <mrobinson@igalia.com>
3652
3653         [CMake] [GTK] Build with ninja when it is available
3654         https://bugs.webkit.org/show_bug.cgi?id=129805
3655
3656         Reviewed by Philippe Normand.
3657
3658         * Scripts/webkitdirs.pm:
3659         (canUseNinja): Added this helper which tries to execute Ninja, in an effort to determine
3660         if it's available on the system.
3661         (cmakeGeneratedBuildfile): Return the path to the generated build file. Only Unix support ATM.
3662         (generateBuildSystemFromCMakeProject): For GTK+ compile with Ninja when possible.
3663
3664 2014-03-06  Filip Pizlo  <fpizlo@apple.com>
3665
3666         If the FTL is build-time enabled then it should be run-time enabled.
3667
3668         Rubber stamped by Geoffrey Garen.
3669
3670         * Scripts/run-jsc-stress-test