[GTK] Implement connected and disconnected events of GAMEPAD API with libmanette
[WebKit-https.git] / Tools / ChangeLog
1 2020-05-20  ChangSeok Oh  <changseok@webkit.org>
2
3         [GTK] Implement connected and disconnected events of GAMEPAD API with libmanette
4         https://bugs.webkit.org/show_bug.cgi?id=133854
5
6         Reviewed by Carlos Garcia Campos.
7
8         This patch brings initial GAMEPAD API support to the gtk port. We use libmanette,
9         a simple GObject game controller library to handle gamepad connection and input.
10         In particular, we use libmanette-0.2.4 which is the latest version and minimum
11         version to build in c++.
12
13         * gtk/jhbuild.modules:
14
15 2020-05-20  Kate Cheney  <katherine_cheney@apple.com>
16
17         Support operating dates in ResourceLoadStatisticsDatabaseStore
18         https://bugs.webkit.org/show_bug.cgi?id=212034
19         <rdar://problem/63349242>
20
21         Reviewed by Brent Fulgham.
22
23         Add a testing function to insert an expired statistic.
24
25         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
26         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
27         (WTR::InjectedBundle::didReceiveMessageToPage):
28         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
29         (WTR::TestRunner::setStatisticsExpiredStatistic):
30         (WTR::TestRunner::statisticsCallDidSetExpiredStatisticCallback):
31         * WebKitTestRunner/InjectedBundle/TestRunner.h:
32         * WebKitTestRunner/TestController.cpp:
33         (WTR::TestController::setStatisticsExpiredStatistic):
34         * WebKitTestRunner/TestController.h:
35         * WebKitTestRunner/TestInvocation.cpp:
36         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
37         (WTR::TestInvocation::didSetExpiredStatistic):
38         * WebKitTestRunner/TestInvocation.h:
39
40 2020-05-20  Chris Dumez  <cdumez@apple.com>
41
42         Deprecate WKBundlePageSetPolicyClient() Injected bundle C API
43         https://bugs.webkit.org/show_bug.cgi?id=212166
44
45         Reviewed by Alex Christensen.
46
47         * TestWebKitAPI/Tests/WebKitObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
48         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
49         (WTR::InjectedBundlePage::InjectedBundlePage):
50
51 2020-05-20  Myles C. Maxfield  <mmaxfield@apple.com>
52
53         [iPadOS] -webkit-text-size-adjust:percentage doesn't work in native apps
54         https://bugs.webkit.org/show_bug.cgi?id=212122
55         <rdar://problem/54560875>
56
57         Reviewed by Wenson Hsieh.
58
59         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
60         * TestWebKitAPI/Tests/WebKit/idempotent-mode-autosizing-only-honors-percentages.html: Added.
61         * TestWebKitAPI/ios/PreferredContentMode.mm:
62
63 2020-05-20  Lauro Moura  <lmoura@igalia.com>
64
65         [WPE][WebDriver] Allow subviews to create new views
66         https://bugs.webkit.org/show_bug.cgi?id=212118
67
68         Reviewed by Carlos Garcia Campos.
69
70         Required by some WebDriver tests.
71
72         * MiniBrowser/wpe/main.cpp:
73         (createWebView):
74
75 2020-05-20  Philippe Normand  <pnormand@igalia.com>
76
77         [FlatPak SDK] Missing ruby gems json and highline
78         https://bugs.webkit.org/show_bug.cgi?id=212086
79
80         Reviewed by Žan Doberšek.
81
82         Add the json and highline Ruby gems in the Flatpak SDK.
83
84         * buildstream/elements/sdk-platform.bst:
85         * buildstream/elements/sdk/ruby-highline.bst: Added.
86         * buildstream/elements/sdk/ruby-json.bst: Added.
87         * buildstream/project.conf:
88
89 2020-05-20  Diego Pino Garcia  <dpino@igalia.com>
90
91         Unreviewed, reverting r261909.
92
93         Execution of LayoutTests returns syntax error in the bots (GTK, WPE)
94
95         Reverted changeset:
96
97         "[Flatpak SDK] Add bubblewrap ... wrapper"
98         https://bugs.webkit.org/show_bug.cgi?id=212077
99         https://trac.webkit.org/changeset/261909
100
101 2020-05-20  Philippe Normand  <pnormand@igalia.com>
102
103         [Flatpak SDK] Bump rr and bst
104         https://bugs.webkit.org/show_bug.cgi?id=212074
105
106         Reviewed by Adrian Perez de Castro.
107
108         Update Buildstream to 1.4.3 which is their latest stable release. Also bump rr to their
109         latest git master commit, which makes it usable in the Flatpak sandbox.
110
111         * buildstream/Pipfile:
112         * buildstream/Pipfile.lock:
113         * buildstream/elements/sdk/rr.bst:
114
115 2020-05-20  Carlos Alberto Lopez Perez  <clopez@igalia.com>
116
117         update-test-expectations-from-bugzilla tool not working with new EWS
118         https://bugs.webkit.org/show_bug.cgi?id=210975
119
120         Reviewed by Youenn Fablet.
121
122         With the new EWS, the layout test archive results are not longer
123         posted to bugzilla as attachment. Now we need to inspect the EWS
124         server to get the status of the runs for the patch id, and then
125         query the EWS builbot server in order to get the details of each
126         run to finally obtain the URL with the zip file for the results.
127
128         The tool now automatically applies platform-specific and generic
129         results automatically (its not longer needed to specify whether
130         the result its generic or not). It uses mac-wk2 results as generic.
131
132         Also now it updates the test results for tests where the result
133         is MISSING.
134
135         * Scripts/webkitpy/common/net/bugzilla/test_expectation_updater.py:
136         (configure_logging):
137         (argument_parser):
138         (TestExpectationUpdater.__init__):
139         (TestExpectationUpdater._platform_name):
140         (TestExpectationUpdater):
141         (TestExpectationUpdater._get_layout_tests_run):
142         (TestExpectationUpdater._lookup_ews_results):
143         (TestExpectationUpdater._tests_to_update):
144         (TestExpectationUpdater._update_for_generic_bot):
145         (TestExpectationUpdater._update_for_platform_specific_bot):
146         (TestExpectationUpdater.do_update):
147         (main):
148         * Scripts/webkitpy/common/net/bugzilla/test_expectation_updater_unittest.py:
149         (MockAttachment.__init__):
150         (MockAttachment.is_patch):
151         (MockAttachment):
152         (MockAttachment.is_obsolete):
153         (MockBugzilla):
154         (MockBugzilla.attachments):
155         (MockRequests):
156         (MockRequests.__init__):
157         (MockRequests.get):
158         (MockRequests.content):
159         (MockRequests.text):
160         (MockZip.__init__):
161         (TestExpectationUpdaterTest.test_update_test_expectations):
162
163 2020-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
164
165         Unreviewed. Fix GTK4 build with GTK 3.98.4
166
167         * MiniBrowser/gtk/BrowserTab.c:
168         (loadChanged):
169         (browserTabConstructed):
170         * MiniBrowser/gtk/BrowserWindow.c:
171         (webViewClose):
172         (browserWindowSetupToolbarItem):
173         (browser_window_init):
174
175 2020-05-20  Sam Weinig  <weinig@apple.com>
176
177         Remove unused Color::getHSV function
178         https://bugs.webkit.org/show_bug.cgi?id=212119
179
180         Reviewed by Simon Fraser.
181
182         * TestWebKitAPI/Tests/WebCore/ColorTests.cpp:
183         Remove tests for Color::getHSV().
184
185 2020-05-20  Philippe Normand  <pnormand@igalia.com>
186
187         [Flatpak SDK] Add bubblewrap ... wrapper
188         https://bugs.webkit.org/show_bug.cgi?id=212077
189
190         Reviewed by Carlos Alberto Lopez Perez.
191
192         The bind-mounts are now handled through webkit-bwrap.
193
194         * flatpak/flatpakutils.py:
195         (WebkitFlatpak.execute_command):
196         (WebkitFlatpak.run_in_sandbox):
197         * flatpak/webkit-bwrap: Added.
198
199 2020-05-19  Darin Adler  <darin@apple.com>
200
201         REGRESSION (r259930): Dictation marker at start of text is removed when added trailing whitespace is collapsed
202         https://bugs.webkit.org/show_bug.cgi?id=212093
203
204         Reviewed by Daniel Bates.
205
206         * TestWebKitAPI/Tests/WebKitCocoa/InsertTextAlternatives.mm:
207         (TestWebKitAPI::TEST): Expect success rather than failure.
208
209 2020-05-19  Alex Christensen  <achristensen@webkit.org>
210
211         Add _WKDownloadDelegate callback including totalBytesWritten
212         https://bugs.webkit.org/show_bug.cgi?id=212110
213         <rdar://problem/63358981>
214
215         Reviewed by Geoffrey Garen.
216
217         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
218         (TEST):
219         * TestWebKitAPI/cocoa/TestDownloadDelegate.h:
220         * TestWebKitAPI/cocoa/TestDownloadDelegate.mm:
221         (-[TestDownloadDelegate _download:didWriteData:totalBytesWritten:totalBytesExpectedToWrite:]):
222         (-[TestDownloadDelegate _download:didReceiveData:]): Deleted.
223
224 2020-05-19  Daniel Bates  <dabates@apple.com>
225
226         Blue dotted underline with alternatives only shown for last word, gets lost for previous insertions
227         https://bugs.webkit.org/show_bug.cgi?id=212097
228         <rdar://problem/61913405>
229
230         Reviewed by Darin Adler.
231
232         Add tests. As I was writing them I discovered a few bugs in the existing code:
233                 1. <https://webkit.org/b/212093> REGRESSION (r259930): Dictation marker at start of text is removed when added trailing whitespace is collapsed
234                 2. <https://webkit.org/b/212098> Inserting a no-break space before or after a marker removes the marker
235
236         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
237         * TestWebKitAPI/Tests/WebKitCocoa/InsertTextAlternatives.mm: Added.
238         (TestWebKitAPI::TEST):
239         (TestWebKitAPI::makeNSStringWithCharacter): Added.
240
241 2020-05-19  Sergio Villar Senin  <svillar@igalia.com>
242
243         [WPE] Sync jhbuild to flatpak
244         https://bugs.webkit.org/show_bug.cgi?id=212087
245
246         Reviewed by Adrian Perez de Castro.
247
248         * wpe/jhbuild.modules: Updated meson, libwpe and wpebackend-fdo.
249
250 2020-05-19  Chris Dumez  <cdumez@apple.com>
251
252         Turn on ITP in TestController::resetStateToConsistentValues()
253         https://bugs.webkit.org/show_bug.cgi?id=212076
254
255         Reviewed by Darin Adler.
256
257         Turn on ITP in TestController::resetStateToConsistentValues(), in a single place
258         instead of doing it in different places depending on whether or not the session
259         is ephemeral or not. It is also important to do it in resetStateToConsistentValues()
260         instead of doing it on data store creation because there is a testRunner method
261         that allows tests to turn off ITP.
262
263         * WebKitTestRunner/TestController.cpp:
264         (WTR::TestController::generatePageConfiguration):
265         (WTR::TestController::resetStateToConsistentValues):
266         (WTR::TestController::platformAdjustContext):
267         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
268         (WTR::initializeWebViewConfiguration):
269         (WTR::TestController::platformInitializeDataStore):
270
271 2020-05-19  Lauro Moura  <lmoura@igalia.com>
272
273         [Flatpak SDK] Use items instead of iteritems to make Python 3 happier.
274
275         Rubber-stamped by Philippe Normand.
276
277         * flatpak/flatpakutils.py:
278         (WebkitFlatpak.pack_toolchain):
279
280 2020-05-19  Wenson Hsieh  <wenson_hsieh@apple.com>
281
282         [macOS] Drag and drop within a contenteditable area duplicates attachment-backed images
283         https://bugs.webkit.org/show_bug.cgi?id=212075
284         <rdar://problem/62434146>
285
286         Reviewed by Andy Estes.
287
288         Add a new API test to verify that starting a drag on an attachment-backed image in an editable container with
289         queued mouse move events does not cause the selection to collapse. See Source/WebKit/ChangeLog for more details.
290
291         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
292         * TestWebKitAPI/cocoa/TestWKWebView.h:
293         * TestWebKitAPI/cocoa/TestWKWebView.mm:
294         (-[TestWKWebView waitForPendingMouseEvents]):
295
296         Move this method from DragAndDropSimulator into TestWKWebView.
297
298         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
299         (-[DragAndDropTestWKWebView waitForPendingMouseEvents]): Deleted.
300
301 2020-05-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
302
303         [buildbot][GTK][WPE] Pass --verbose flag when running JavaScriptCore tests
304         https://bugs.webkit.org/show_bug.cgi?id=212088
305
306         Reviewed by Philippe Normand.
307
308         Pass the "--verbose" flag to run-javascriptcore-tests also for GTK and WPE.
309         Also change the way we are currently passing "--memory-limited" to make
310         it more obvious that this is needed for all Linux bots (GTK+WPE+JSCOnly).
311
312         * BuildSlaveSupport/build.webkit.org-config/steps.py:
313         (RunJavaScriptCoreTests.start):
314         (RunRemoteJavaScriptCoreTests.start):
315
316 2020-05-19  Michael Catanzaro  <mcatanzaro@gnome.org>
317
318         Fixups for r261689 "stress/array-buffer-view-watchpoint-can-be-fired-in-really-add-in-dfg.js failing on ppc64le and s390x"
319         https://bugs.webkit.org/show_bug.cgi?id=211724
320         <rdar://problem/63227393>
321
322         Reviewed by Carlos Alberto Lopez Perez.
323
324         Rewrite determineArchitectureFromELFBinary to properly handle big endian architectures.
325         Also, properly account for 32-bit PowerPC.
326
327         * Scripts/run-jsc-stress-tests:
328
329 2020-05-19  Michael Catanzaro  <mcatanzaro@gnome.org>
330
331         [GTK] Add WEBKIT_EDITING_COMMAND_PASTE_AS_PLAIN_TEXT
332         https://bugs.webkit.org/show_bug.cgi?id=212038
333
334         Reviewed by Carlos Garcia Campos.
335
336         * TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
337         (testWebViewEditorCutCopyPasteNonEditable):
338         (testWebViewEditorCutCopyPasteEditable):
339         (testWebViewEditorNonEditable):
340
341 2020-05-18  Zan Dobersek  <zdobersek@igalia.com>
342
343         [WPE] HeadlessViewBackend should exclusively use software rasterization mode
344         https://bugs.webkit.org/show_bug.cgi?id=211982
345
346         Reviewed by Carlos Garcia Campos.
347
348         Instead of using WPEBackend-fdo's EGL mode that optionally allows the
349         GL operations to be done through software rasterization, have the
350         HeadlessViewBackend use the SHM mode which enforces this behavior.
351
352         Under the hood, the graphics library will be forced to set up and use
353         the software rasterization mechanisms, and on our side we are required
354         to properly handle SHM-backed buffers. This avoids any use of EGL or
355         GL operations inside HeadlessViewBackend, enabling to use this setup
356         in systems and environments that don't have GPUs available.
357
358         All GL-y things are pushed into the WindowViewBackend class. Inside
359         HeadlessViewBackend, the whole SHM logic requires WPEBackend-fdo APIs
360         that are part of the current 1.7 development cycle. When building
361         against older versions, HeadlessViewBackend itself remains buildable
362         but is not operational otherwise.
363
364         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:
365         (WTR::PlatformWebView::windowSnapshotImage):
366         * wpe/backends/HeadlessViewBackend.cpp:
367         (WPEToolingBackends::HeadlessInstance::singleton):
368         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend):
369         (WPEToolingBackends::HeadlessViewBackend::~HeadlessViewBackend):
370         (WPEToolingBackends::HeadlessViewBackend::backend const):
371         (WPEToolingBackends::HeadlessViewBackend::snapshot):
372         (WPEToolingBackends::HeadlessViewBackend::updateSnapshot):
373         (WPEToolingBackends::HeadlessViewBackend::vsync):
374         (): Deleted.
375         (WPEToolingBackends::HeadlessEGLConnection::singleton): Deleted.
376         (WPEToolingBackends::HeadlessViewBackend::createSnapshot): Deleted.
377         (WPEToolingBackends::HeadlessViewBackend::createEGLSnapshot): Deleted.
378         (WPEToolingBackends::HeadlessViewBackend::createSHMSnapshot): Deleted.
379         (WPEToolingBackends::HeadlessViewBackend::performUpdate): Deleted.
380         (WPEToolingBackends::HeadlessViewBackend::displayBuffer): Deleted.
381         * wpe/backends/HeadlessViewBackend.h:
382         * wpe/backends/ViewBackend.cpp:
383         (WPEToolingBackends::ViewBackend::initialize): Deleted.
384         (WPEToolingBackends::ViewBackend::deinitialize): Deleted.
385         (WPEToolingBackends::ViewBackend::backend const): Deleted.
386         * wpe/backends/ViewBackend.h:
387         * wpe/backends/WindowViewBackend.cpp:
388         (WPEToolingBackends::WindowViewBackend::backend const):
389         (WPEToolingBackends::WindowViewBackend::initialize):
390         (WPEToolingBackends::WindowViewBackend::deinitialize):
391         * wpe/backends/WindowViewBackend.h:
392
393 2020-05-18  Zan Dobersek  <zdobersek@igalia.com>
394
395         [WPE] Disable modern media controls for testing
396         https://bugs.webkit.org/show_bug.cgi?id=212023
397
398         Reviewed by Philippe Normand.
399
400         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
401         (WTR::TestController::updatePlatformSpecificTestOptionsForTest const):
402         Since using the same Adwaita-based media controls as the GTK port, WPE
403         too should disable modern media controls during testing by overriding
404         the default value. This fixes a couple of obscure crashes in text track
405         tests.
406
407 2020-05-18  Christopher Reid  <chris.reid@sony.com>
408
409         [WinCairo] WKTR WebsiteDataStore is being overwritten by the default one
410         https://bugs.webkit.org/show_bug.cgi?id=212044
411
412         Reviewed by Fujii Hironori.
413
414         Ensure TestController::defaultWebSiteDataStore is being used for WinCairo as done in r259705.
415
416         Also consolidate platformInitializeDataStore implementations with GTK/WPE since WinCairo WKTR
417         also started crashing since r261758.
418
419         * WebKitTestRunner/TestController.cpp:
420         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
421         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
422
423 2020-05-18  Andy Estes  <aestes@apple.com>
424
425         http/tests/ssl/applepay/ApplePayInstallmentConfiguration.https.html fails in public SDK builds
426         https://bugs.webkit.org/show_bug.cgi?id=212000
427         <rdar://problem/63323082>
428
429         Reviewed by Youenn Fablet.
430
431         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
432
433 2020-05-18  Wenson Hsieh  <wenson_hsieh@apple.com>
434
435         Replace uses of +self with +class
436         https://bugs.webkit.org/show_bug.cgi?id=212041
437
438         Reviewed by Darin Adler.
439
440         * DumpRenderTree/mac/EventSendingController.mm:
441         (-[EventSendingController monitorWheelEventsWithOptions:]):
442         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
443         (TestWebKitAPI::TEST):
444         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
445         (WTR::enclosingScrollViewIncludingSelf):
446
447 2020-05-18  Simon Fraser  <simon.fraser@apple.com>
448
449         Implement conversion between P3 and sRGB color
450         https://bugs.webkit.org/show_bug.cgi?id=211998
451
452         Reviewed by Daniel Bates.
453
454         API test for conversions from P3 to sRGB, and linearRGB to sRGB. Values were confirmed
455         as close to those provided by ColorSync Utility.
456
457         * TestWebKitAPI/Tests/WebCore/ExtendedColorTests.cpp:
458         (TestWebKitAPI::TEST):
459
460 2020-05-18  Mark Lam  <mark.lam@apple.com>
461
462         Implement a faster findBitInWord() using the hardware ctz instruction.
463         https://bugs.webkit.org/show_bug.cgi?id=212032
464         <rdar://problem/63348086>
465
466         Reviewed by Saam Barati.
467
468         Add tests to make sure that the ctz implementation matches the loop implementation
469         in behavior.
470
471         * TestWebKitAPI/CMakeLists.txt:
472         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
473         * TestWebKitAPI/Tests/WTF/StdLibExtras.cpp: Added.
474         (TestWebKitAPI::testFindBitInWord):
475         (TestWebKitAPI::TEST):
476
477 2020-05-18  Wenson Hsieh  <wenson_hsieh@apple.com>
478
479         Allow clipboard API access when pasting from a menu item or key binding
480         https://bugs.webkit.org/show_bug.cgi?id=211990
481         <rdar://problem/63308916>
482
483         Reviewed by Megan Gardner.
484
485         Add a UIScriptController method to trigger a paste from the application process.
486
487         * DumpRenderTree/cocoa/UIScriptControllerCocoa.h:
488         * DumpRenderTree/cocoa/UIScriptControllerCocoa.mm:
489         (WTR::UIScriptControllerCocoa::paste):
490         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
491         * TestRunnerShared/UIScriptContext/UIScriptController.h:
492         (WTR::UIScriptController::paste):
493         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
494         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:
495         (WTR::UIScriptControllerCocoa::paste):
496
497 2020-05-18  Darin Adler  <darin@apple.com>
498
499         Add iterator checking to ListHashSet
500         https://bugs.webkit.org/show_bug.cgi?id=211669
501
502         Reviewed by Anders Carlsson.
503
504         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: Removed use of the DID_CREATE_WEAK_PTR_IMPL
505         and WILL_DESTROY_WEAK_PTR_IMPL, which didn't work consistently because of the
506         one-definition rule. Instead, this file parameterizes the WeakPtr family of
507         class templates with a counter class. To avoid having to rewrite test code, used
508         alias templates to insert these class template into the TestWebKitAPI namespace,
509         hiding the class templates from the WTF namespace.
510
511 2020-05-18  Peng Liu  <peng.liu6@apple.com>
512
513         [iPad Simulator] TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia is timing out
514         https://bugs.webkit.org/show_bug.cgi?id=211792
515
516         Reviewed by Daniel Bates.
517
518         Fix deadlocks in two API tests (only reproducible on iPad simulators).
519
520         * TestWebKitAPI/Tests/WebKitLegacy/ios/PreemptVideoFullscreen.mm:
521         (TestWebKitAPI::TEST):
522         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
523         (TestWebKitAPI::TEST):
524
525 2020-05-18  Wenson Hsieh  <wenson_hsieh@apple.com>
526
527         Single selection <select> with <optgroups> shows multiple selected options
528         https://bugs.webkit.org/show_bug.cgi?id=199485
529         <rdar://problem/52757531>
530
531         Reviewed by Megan Gardner.
532
533         Add a new helper method to check whether the currently presented form accessory is a select menu, and has a
534         checked menu item at the given row.
535
536         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
537         * TestRunnerShared/UIScriptContext/UIScriptController.h:
538         (WTR::UIScriptController::selectFormAccessoryHasCheckedItemAtRow const):
539         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
540         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
541         (WTR::UIScriptControllerIOS::selectFormAccessoryHasCheckedItemAtRow const):
542
543 2020-05-18  Wenson Hsieh  <wenson_hsieh@apple.com>
544
545         [iOS] Unexpected capitalization of next word after repositioning caret
546         https://bugs.webkit.org/show_bug.cgi?id=211969
547         <rdar://problem/62605526>
548
549         Reviewed by Alex Christensen.
550
551         Add a new UIScriptController hook to query whether or not the software keyboard is in shifted state.
552
553         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
554         * TestRunnerShared/UIScriptContext/UIScriptController.h:
555         (WTR::UIScriptController::keyboardIsAutomaticallyShifted const):
556         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
557
558         Adjust a couple of API tests that copy and paste back-to-back, so that they wait for the copy to finish before
559         attempting to paste.
560
561         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
562         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
563         (WTR::UIScriptControllerIOS::keyboardIsAutomaticallyShifted const):
564
565 2020-05-18  Carlos Garcia Campos  <cgarcia@igalia.com>
566
567         [GTK] Add WebKitContextMenuItemType for paste as plaintext
568         https://bugs.webkit.org/show_bug.cgi?id=177638
569
570         Reviewed by Michael Catanzaro.
571
572         Update default context menu test case to also test the context menu for rich editable content.
573
574         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
575         (prepareContextMenuTestView):
576         (testContextMenuDefaultMenu):
577
578 2020-05-17  Simon Fraser  <simon.fraser@apple.com>
579
580         Fix operator== and hash() for ExtendedColor
581         https://bugs.webkit.org/show_bug.cgi?id=211993
582
583         Reviewed by Sam Weinig.
584
585         * TestWebKitAPI/Tests/WebCore/ExtendedColorTests.cpp:
586         (TestWebKitAPI::TEST):
587
588 2020-05-16  Simon Fraser  <simon.fraser@apple.com>
589
590         Rename some API test files
591         https://bugs.webkit.org/show_bug.cgi?id=211992
592
593         Reviewed by Zalan Bujtas.
594
595         I'm tired of Quick Open of Color.cpp opening the test file rather than the one I want.
596
597         * TestWebKitAPI/CMakeLists.txt:
598         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
599         * TestWebKitAPI/Tests/WebCore/ColorTests.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/Color.cpp.
600         * TestWebKitAPI/Tests/WebCore/ExtendedColorTests.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ExtendedColor.cpp.
601         * TestWebKitAPI/Tests/WebCore/FloatPointTests.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FloatPoint.cpp.
602         * TestWebKitAPI/Tests/WebCore/FloatRectTests.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FloatRect.cpp.
603         * TestWebKitAPI/Tests/WebCore/FloatSizeTests.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FloatSize.cpp.
604         * TestWebKitAPI/Tests/WebCore/IntPointTests.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/IntPoint.cpp.
605         * TestWebKitAPI/Tests/WebCore/IntRectTests.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/IntRect.cpp.
606         * TestWebKitAPI/Tests/WebCore/IntSizeTests.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/IntSize.cpp.
607         * TestWebKitAPI/Tests/WebCore/LayoutUnitTests.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp.
608
609 2020-05-15  Lauro Moura  <lmoura@igalia.com>
610
611         [GTK][WPE] Add default initialization of WebsiteDataStore to WebKitTestRunner after r261758
612         https://bugs.webkit.org/show_bug.cgi?id=211977
613
614         As GTK/WPE does not explicitly create WebSiteDataStore for the tests,
615         assign the default one.
616
617         Not sure if this is the correct fix, but should allow running tests
618         again.
619
620         Reviewed by Žan Doberšek.
621
622         * WebKitTestRunner/TestController.cpp: Add GTK/WPE guards.
623         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
624         (WTR::TestController::platformInitializeDataStore): Use default
625         WebsiteDataStore.
626         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
627         (WTR::TestController::platformInitializeDataStore): Use default
628         websiteDataStore.
629
630 2020-05-15  Alex Christensen  <achristensen@webkit.org>
631
632         Use enum serialization instead of casting to/from uint32_t
633         https://bugs.webkit.org/show_bug.cgi?id=211885
634
635         Reviewed by Geoffrey Garen.
636
637         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
638         (AccessibilityUIElement::increaseTextSelection):
639         (AccessibilityUIElement::decreaseTextSelection):
640         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
641         (WTR::AccessibilityUIElement::increaseTextSelection):
642         (WTR::AccessibilityUIElement::decreaseTextSelection):
643
644 2020-05-15  Ryan Haddad  <ryanhaddad@apple.com>
645
646         [iOS EWS] TestWebKitAPI.WKWebsiteDataStore.RemoveAndFetchData is failing
647         https://bugs.webkit.org/show_bug.cgi?id=208451
648
649         Unreviewed test gardening.
650
651         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
652         (TestWebKitAPI::TEST): Re-enable the test for iOS.
653
654 2020-05-15  Geoffrey Garen  <ggaren@apple.com>
655
656         Update Sihui Liu's status to reviewer
657         https://bugs.webkit.org/show_bug.cgi?id=211966
658
659         Reviewed by Per Arne Vollan.
660
661         See email thread on webkit-reviewers on 5/7, "Reviewer nomination:
662         Sihui Liu".
663
664         * Scripts/webkitpy/common/config/contributors.json:
665
666 2020-05-15  Alex Christensen  <achristensen@webkit.org>
667
668         TestWebKitAPI.WKHTTPCookieStore.Basic is a flaky failure
669         https://bugs.webkit.org/show_bug.cgi?id=211752
670
671         Reviewed by Geoffrey Garen.
672
673         The ordering of cookiesDidChangeInCookieStore callbacks with regard to other callbacks isn't quite deterministic.
674         No problem.  If the number of callbacks isn't what it is expected, wait until it is.
675         When I reproduce this test failure, I need to spin the run loop at max once to have it succeed, but the bots may take a few more run loop spins.
676         Spin until the number of callbacks is the expected value.
677
678         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
679         (runTestWithWebsiteDataStore):
680
681 2020-05-15  Alex Christensen  <achristensen@webkit.org>
682
683         [iOS Simulator] TestWebKitAPI._WKDownload.Resume is a flaky crash
684         https://bugs.webkit.org/show_bug.cgi?id=211786
685
686         Reviewed by Geoffrey Garen.
687
688         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
689         (TEST):
690         Add a short sleep (<1/10s) to make this test so it would've almost always failed without this fix.
691         Checking the file immediately usually succeeded, but waiting a few run loop iterations revealed that CFNetwork
692         was deleting resumed then finished downloads.
693
694 2020-05-15  Alex Christensen  <achristensen@webkit.org>
695
696         Regression (iOS 13.4, r249142): WKWebView.loading is never reset after a Back navigation in an iframe
697         https://bugs.webkit.org/show_bug.cgi?id=211449
698
699         Reviewed by Geoffrey Garen.
700
701         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
702         (-[LoadingObserver changesObserved]):
703         (-[LoadingObserver observeValueForKeyPath:ofObject:change:context:]):
704         (TEST):
705
706 2020-05-15  Chris Dumez  <cdumez@apple.com>
707
708         Make sure we use current data store in WKTR's TestController
709         https://bugs.webkit.org/show_bug.cgi?id=211920
710
711         Reviewed by Alex Christensen.
712
713         Make sure we use current data store in WKTR's TestController. Currently, a lot of code
714         uses defaultDataStore(), even though the test may be using another data store (e.g. an
715         ephemeral one). I suspect this is contributing to test flakiness.
716
717         We now also make sure that TestController::websiteDataStore() returns the actual store
718         that will be used by the test when resetPreferencesToConsistentValues() is called.
719         Previously, it would not since it would get the store from the m_mainView and m_mainView
720         would only get initialized after calling resetPreferencesToConsistentValues(). To support
721         this, we now initialize a m_websiteDataStore member in platformInitializeDataStore(),
722         which gets called right before resetPreferencesToConsistentValues(). When
723         platformCreateWebView() gets called right after resetPreferencesToConsistentValues(),
724         it now simply relies on m_websiteDataStore instead of creating the data store at this
725         point.
726
727         * WebKitTestRunner/TestController.cpp:
728         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
729         (WTR::TestController::clearServiceWorkerRegistrations):
730         (WTR::TestController::clearDOMCache):
731         (WTR::TestController::clearDOMCaches):
732         (WTR::TestController::hasDOMCache):
733         (WTR::TestController::domCacheSize):
734         (WTR::TestController::clearStatisticsDataForDomain):
735         * WebKitTestRunner/TestInvocation.cpp:
736         (WTR::TestInvocation::invoke):
737         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
738
739 2020-05-15  Diego Pino Garcia  <dpino@igalia.com>
740
741         [buildbot] Increase blocksize of file transfer in UploadTestResults step
742         https://bugs.webkit.org/show_bug.cgi?id=211847
743
744         Reviewed by Aakash Jain.
745
746         All other steps involving file transfer uploads use 256kb as block
747         size. Make this step in line with others.
748
749         * BuildSlaveSupport/build.webkit.org-config/steps.py:
750         (UploadTestResults.__init__):
751
752 2020-05-15  Adrian Perez de Castro  <aperez@igalia.com>
753
754         [GTK3] Bring back usage of GtkMenu for context menus
755         https://bugs.webkit.org/show_bug.cgi?id=211557
756
757         Reviewed by Carlos Garcia Campos.
758
759         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp: Add preprocessor conditionals
760         for GTK4 and bring back some bits previously removed in r260889 for GTK3.
761
762 2020-05-14  Kate Cheney  <katherine_cheney@apple.com>
763
764         Attribute non-network loads and loads with html strings as automatically app-bound
765         https://bugs.webkit.org/show_bug.cgi?id=211913
766         <rdar://problem/63157801
767
768         Reviewed by Brent Fulgham.
769
770         Adds new tests to check that WebView loads with HTML strings have
771         proper behavior.
772
773         Some tests need to test behavior on app-bound domains on webviews which do not specify
774         limitsNavigationsToAppBoundDomains. Since local files now do this
775         automatically, this patch updates those to use actual app-bound
776         domains from the WKAppBoundDomains list instead to maintain behavior.
777
778         Remove limitsNavigationsToAppBoundDomains for local files to make sure
779         they are forced into this mode automatically.
780
781         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
782         (-[InAppBrowserSchemeHandler webView:startURLSchemeTask:]):
783         (TEST):
784
785 2020-05-14  Jiewen Tan  <jiewen_tan@apple.com>
786
787         [WebAuthn] Relaxing signature length requirements for U2fRegister
788         https://bugs.webkit.org/show_bug.cgi?id=209645
789         <rdar://problem/63204591>
790
791         Reviewed by Brent Fulgham.
792
793         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
794         (TestWebKitAPI::TEST):
795
796 2020-05-14  Jonathan Bedard  <jbedard@apple.com>
797
798         run-webkit-tests shouldn't need Xcode to run Mac tests
799         https://bugs.webkit.org/show_bug.cgi?id=211903
800         <rdar://problem/63205839>
801
802         Reviewed by Stephanie Lewis.
803
804         * Scripts/webkitpy/common/system/platforminfo.py:
805         (PlatformInfo):
806         (PlatformInfo.xcode_sdk_version): Memoize SDK version retrieval.
807         (PlatformInfo.xcode_version): Only run xcodebuild if macosx SDK is present.
808         (PlatformInfo.available_sdks): Ditto.
809         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
810         (TestPlatformInfo.test_available_sdks):
811
812 2020-05-14  Daniel Bates  <dabates@apple.com>
813
814         Include LocalOverrides.xcconfig in all Tools projects
815         https://bugs.webkit.org/show_bug.cgi?id=211789
816
817         Reviewed by Dan Bernstein.
818
819         Matches what is done for all Source projects so as to support local overriding of configs.
820
821         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
822         * MiniBrowser/Configurations/DebugRelease.xcconfig:
823         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig:
824         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
825         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
826
827 2020-05-14  Andres Gonzalez  <andresg_22@apple.com>
828
829         Fix for crashes in LayoutTests related to TextMarkers in isolated tree mode.
830         https://bugs.webkit.org/show_bug.cgi?id=211912
831
832         Reviewed by Chris Fleizach.
833
834         Check for null pointer parameters before dereferencing.
835
836         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
837         (WTR::misspellingSearchParameterizedAttributeForCriteria):
838         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
839         (WTR::AccessibilityUIElement::textMarkerRangeLength):
840         (WTR::AccessibilityUIElement::previousTextMarker):
841         (WTR::AccessibilityUIElement::nextTextMarker):
842         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
843         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
844         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
845         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
846         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
847         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRange):
848         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions):
849         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
850         (WTR::AccessibilityUIElement::indexForTextMarker):
851         (WTR::AccessibilityUIElement::isTextMarkerValid):
852         (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker):
853         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker):
854         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker):
855         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker):
856         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker):
857         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker):
858         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker):
859         (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker):
860         (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker):
861         (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker):
862
863 2020-05-14  Michael Catanzaro  <mcatanzaro@gnome.org>
864
865         stress/array-buffer-view-watchpoint-can-be-fired-in-really-add-in-dfg.js failing on ppc64le and s390x
866         https://bugs.webkit.org/show_bug.cgi?id=211724
867
868         Reviewed by Carlos Alberto Lopez Perez.
869
870         Add architecture detection for PowerPC and S/390.
871
872         * Scripts/run-jsc-stress-tests:
873
874 2020-05-14  Philippe Normand  <pnormand@igalia.com>
875
876         [WPE] Tools/wpe/install-dependencies fails due to missing pipenv
877         https://bugs.webkit.org/show_bug.cgi?id=211849
878
879         Reviewed by Žan Doberšek.
880
881         Ubuntu Bionic doesn't ship pipenv. So fallback to the pip3 install path. Also remove the
882         libpng12-dev fallback, this doesn't seem necessary any longer (tested on a Ubuntu Bionic
883         docker).
884
885         * gtk/install-dependencies:
886         * wpe/install-dependencies:
887
888 2020-05-14  Philippe Normand  <pnormand@igalia.com>
889
890         [Flatpak SDK] Path references shouldn't point to the sandbox in compile_commands.json
891         https://bugs.webkit.org/show_bug.cgi?id=209901
892
893         Reviewed by Žan Doberšek.
894
895         Add ccls to the SDK. It can then be used through a wrapper script by Emacs's lsp-mode.
896         
897         * buildstream/elements/sdk-build-depends/rapidjson.bst: Added.
898         * buildstream/elements/sdk-platform.bst:
899         * buildstream/elements/sdk/ccls.bst: Added.
900
901 2020-05-13  Jer Noble  <jer.noble@apple.com>
902
903         Replace isNullFunctionPointer with real weak-linking support
904         https://bugs.webkit.org/show_bug.cgi?id=211751
905
906         Reviewed by Sam Weinig.
907
908         * TestWebKitAPI/Tests/WTF/darwin/WeakLinking.cpp:
909         (TestWebKitAPI::TEST):
910         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-iOS-v2.tbd:
911         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-iOS.tbd:
912         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-macOS-v2.tbd:
913         * TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-macOS.tbd:
914
915 2020-05-13  Tim Horton  <timothy_horton@apple.com>
916
917         Add SPI for reverting to touch events for iPad trackpad interactions
918         https://bugs.webkit.org/show_bug.cgi?id=211824
919         <rdar://problem/61363084>
920
921         Reviewed by Megan Gardner.
922
923         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
924         * TestWebKitAPI/Tests/WebKitCocoa/iOSMouseSupport.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/MacCatalystMouseSupport.mm.
925         (-[WKTestingEvent locationInView:]):
926         (-[WKTestingEvent _setButtonMask:]):
927         (-[WKTestingEvent _buttonMask]):
928         (-[WKTestingTouch locationInView:]):
929         (-[WKTestingTouch setTapCount:]):
930         (-[WKTestingTouch tapCount]):
931         (mouseGesture):
932         (TEST):
933         Rename and enable MacCatalystMouseSupport tests for iOS.
934         Add a test that ensures that the next load after setting the
935         WKWebpagePreference causes the WKMouseGestureRecognizer to get disabled.
936
937 2020-05-13  Wenson Hsieh  <wenson_hsieh@apple.com>
938
939         [iOS] "Copy" context menu action for attachment element does not work in Mail
940         https://bugs.webkit.org/show_bug.cgi?id=211817
941         <rdar://problem/58043110>
942
943         Reviewed by Tim Horton.
944
945         Add a new iOS API test that simulates the context menu action to "copy" on an attachment element.
946
947         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
948
949 2020-05-12  Matt Lewis  <jlewis3@apple.com>
950
951         Run-webkit-tests should not fail if all tests found to run are skipped.
952         https://bugs.webkit.org/show_bug.cgi?id=210880
953
954         Reviewed by Jonathan Bedard.
955
956         * Scripts/webkitpy/layout_tests/controllers/manager.py:
957         (Manager.run): Added a check to see if we skiped all tests. If so We return a successful exit
958         code as we performed as expected.
959         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
960         (RunDetails.__init__): Added in an additional class variable to be used as a way to record an
961         all skipped result check.
962         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
963         (main): Added a all test skipped check and we return early with the exit code.
964         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Added a new test and removed the old
965         ones that no longer test the correct functionality.
966         (RunTest.test_all_tests_skipped):
967         (RunTest.test_no_tests_found): Deleted.
968         (RunTest.test_no_tests_found_2): Deleted.
969
970 2020-05-13  Kate Cheney  <katherine_cheney@apple.com>
971
972         Add test for non-app-bound iframe under app-bound domain
973         https://bugs.webkit.org/show_bug.cgi?id=211815
974         <rdar://problem/63159707>
975
976         Reviewed by Brent Fulgham.
977
978         Clear the main frame app-bound session before loading the iframe so
979         we can be sure the iframe uses an app-bound session.
980
981         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
982         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
983         (WTR::TestRunner::clearAppBoundSession):
984         * WebKitTestRunner/InjectedBundle/TestRunner.h:
985         * WebKitTestRunner/TestInvocation.cpp:
986         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
987
988 2020-05-13  Philippe Normand  <pnormand@igalia.com>
989
990         [Flatpak SDK] Proper handling of sccache scheduler URL command-line argument
991
992         Rubber-stamped by Carlos Alberto Lopez Perez.
993
994         * flatpak/flatpakutils.py:
995         (WebkitFlatpak.load_from_args):
996         (WebkitFlatpak.__init__):
997
998 2020-05-13  Philippe Normand  <pnormand@igalia.com>
999
1000         [Flatpak SDK] Craft a custom sccache config file from SDK toolchains
1001         https://bugs.webkit.org/show_bug.cgi?id=211781
1002
1003         Reviewed by Carlos Alberto Lopez Perez.
1004
1005         Optionally generate a sccache config file and use it when building WebKit.
1006
1007         * Scripts/webkitpy/thirdparty/__init__.py:
1008         (AutoinstallImportHook.find_module):
1009         (AutoinstallImportHook._install_toml):
1010         * flatpak/flatpakutils.py:
1011         (WebkitFlatpak.load_from_args):
1012         (WebkitFlatpak.__init__):
1013         (WebkitFlatpak.clean_args):
1014         (WebkitFlatpak.host_path_to_sandbox_path):
1015         (WebkitFlatpak.run_in_sandbox):
1016         (WebkitFlatpak.main):
1017         (WebkitFlatpak.save_config):
1018         (WebkitFlatpak):
1019         (WebkitFlatpak.pack_toolchain):
1020         (WebkitFlatpak.setup_icecc): Deleted.
1021
1022 2020-05-13  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
1023
1024         [Flatpak] *PROCESS_CMD_PREFIX are ignored
1025         https://bugs.webkit.org/show_bug.cgi?id=211830
1026
1027         Reviewed by Philippe Normand.
1028
1029         Checking the last slice of the splitted environment variable won't
1030         match with any of the list of suffixes since they are composed by
1031         several slices if they are splitted too.
1032
1033         A new internal function is defined where the suffixes list is
1034         traversed and matched with the end of the passend enviroment
1035         variable.
1036
1037         * flatpak/flatpakutils.py:
1038         (WebkitFlatpak.run_in_sandbox.envvar_in_suffixes_to_keep):
1039         (WebkitFlatpak.run_in_sandbox):
1040
1041 2020-05-12  Alex Christensen  <achristensen@webkit.org>
1042
1043         [iOS Simulator] TestWebKitAPI._WKDownload.Resume is a flaky crash
1044         https://bugs.webkit.org/show_bug.cgi?id=211786
1045
1046         Reviewed by Darin Adler.
1047
1048         This should turn the test crash into a failure, which is a step in the right direction.
1049         Still investigating...
1050
1051         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1052         (TEST):
1053
1054 2020-05-12  Ryan Haddad  <ryanhaddad@apple.com>
1055
1056         [iOS] TestWTF.WTF_Lock.ContendedShortSection is consistently timing out on debug
1057         https://bugs.webkit.org/show_bug.cgi?id=211650
1058
1059         Unreviewed test gardening.
1060
1061         * TestWebKitAPI/Tests/WTF/Lock.cpp: Skip the test for iOS Debug queues.
1062
1063 2020-05-12  Philippe Normand  <pnormand@igalia.com>
1064
1065         [FlatPak SDK] Some packages in the SDK have missing debug symbols
1066         https://bugs.webkit.org/show_bug.cgi?id=211621
1067
1068         Reviewed by Carlos Alberto Lopez Perez.
1069
1070         * flatpak/flatpakutils.py:
1071         (WebkitFlatpak._get_packages): Unconditionally install SDK Debug symbols, even for Release
1072         builds. This should help improve the crash reports on the bots.
1073
1074 2020-05-12  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1075
1076         WPT test importer fails to update references in <link> tags
1077         https://bugs.webkit.org/show_bug.cgi?id=211762
1078
1079         Reviewed by Youenn Fablet.
1080
1081         When importing WPT test references, ensure relative paths are also
1082         updated for the href attribute in <link> tags.
1083         Also fix a bug that was causing wrong updates on the paths due to
1084         the characters in reference_relpath not escaped when performing
1085         the regex substitution in convert_reference_relpaths(). For example:
1086         "resources/script.js" was changed to "resourcscript.js" when reference_relpath was '../'
1087
1088         Improve also the unit test case to check for the fixes in this patch.
1089
1090         * Scripts/webkitpy/w3c/test_converter.py:
1091         (_W3CTestConverter.convert_reference_relpaths):
1092         (_W3CTestConverter.convert_attributes_if_needed):
1093         * Scripts/webkitpy/w3c/test_converter_unittest.py:
1094
1095 2020-05-12  Philippe Normand  <pnormand@igalia.com>
1096
1097         [Flatpak SDK] Include clang++ and g++ in toolchains
1098         https://bugs.webkit.org/show_bug.cgi?id=211663
1099
1100         Reviewed by Adrian Perez de Castro.
1101
1102         /usr/bin/clang++ wasn't included before. Also a small unrelated drive-by, white-list RUST
1103         env vars, such as RUST_LOG, useful when debugging sccache.
1104
1105         * flatpak/flatpakutils.py:
1106         (WebkitFlatpak.run_in_sandbox):
1107         (WebkitFlatpak.main):
1108         (WebkitFlatpak.setup_icecc):
1109
1110 2020-05-11  Simon Fraser  <simon.fraser@apple.com>
1111
1112         [ macOS ] scrollingcoordinator/mac/latching/scrolling-select-should-not-latch-mainframe.html is a flaky failure
1113         https://bugs.webkit.org/show_bug.cgi?id=211747
1114
1115         Reviewed by Tim Horton.
1116
1117         Add an option to monitorWheelEvents to reset latching.
1118
1119         * DumpRenderTree/mac/EventSendingController.mm:
1120         (+[EventSendingController isSelectorExcludedFromWebScript:]):
1121         (+[EventSendingController webScriptNameForSelector:]):
1122         (-[EventSendingController monitorWheelEventsWithOptions:]):
1123         (-[EventSendingController monitorWheelEvents]): Deleted.
1124         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1125         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1126         (WTR::toMonitorWheelEventsOptions): We have to return a pointer to a static, because the generated code
1127         doesn't use smart pointers.
1128         (WTR::EventSendingController::monitorWheelEvents):
1129         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1130         (WTR::MonitorWheelEventsOptions::MonitorWheelEventsOptions):
1131
1132 2020-05-11  Kate Cheney  <katherine_cheney@apple.com>
1133
1134         Fail navigations to non app-bound domains after use of app-bound APIs
1135         https://bugs.webkit.org/show_bug.cgi?id=211647
1136         <rdar://problem/62978159>
1137
1138         Reviewed by Brent Fulgham.
1139
1140         Added a new test to confirm a non-app bound navigation fails after
1141         using script injection.
1142
1143         This fix also required changing any test which uses a restricted API
1144         to confirm behavior of another restricted API. Tests can set
1145         _setNeedsInAppBrowserPrivacyQuirks in the configuration to indicate
1146         APIs should not be blocked, then toggle it to test actual behavior.
1147
1148         Also, we can remove any calls to _setInAppBrowserPrivacyEnabled
1149         now that this is just an internal test flag. 
1150
1151         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
1152         (-[AppBoundDomainDelegate webView:didFinishNavigation:]):
1153         (-[AppBoundDomainDelegate webView:didFailProvisionalNavigation:withError:]):
1154         (-[AppBoundDomainDelegate waitForDidFinishNavigation]):
1155         (-[AppBoundDomainDelegate waitForDidFailProvisionalNavigationError]):
1156         (TEST):
1157
1158 2020-05-11  Alex Christensen  <achristensen@webkit.org>
1159
1160         Add some logs to diagnose why WebKitLegacy.CrossPartitionFileSchemeAccess API test times out in EWS
1161         https://bugs.webkit.org/show_bug.cgi?id=211738
1162
1163         Reviewed by Darin Adler.
1164
1165         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm:
1166         (TestWebKitAPI::TEST):
1167         I saw an instance of failing to make a partition because the "file" already existed.
1168         Try cleaning up anything left from last time this test timed out to prevent it from timing out again.
1169
1170 2020-05-11  Alex Christensen  <achristensen@webkit.org>
1171
1172         Add some logs to diagnose why WebKitLegacy.CrossPartitionFileSchemeAccess API test times out in EWS
1173         https://bugs.webkit.org/show_bug.cgi?id=211738
1174
1175         Reviewed by Mark Lam.
1176
1177         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm:
1178         (TestWebKitAPI::TEST):
1179
1180 2020-05-11  Andres Gonzalez  <andresg_22@apple.com>
1181
1182         Add mechanism to turn on accessibility isolated tree mode from WebKitTestRunner.
1183         https://bugs.webkit.org/show_bug.cgi?id=211725
1184
1185         Reviewed by Chris Fleizach.
1186
1187         Turn on isolated tree mode when appropriate.
1188
1189         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1190         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1191         (WTR::AccessibilityController::updateIsolatedTreeMode):
1192
1193 2020-05-11  Per Arne Vollan  <pvollan@apple.com>
1194
1195         Unreviewed, reverting r261296.
1196
1197         Rolling r260769 back in, since this was not causing a
1198         regression.
1199
1200         Reverted changeset:
1201
1202         "Unreviewed, reverting r260769."
1203         https://bugs.webkit.org/show_bug.cgi?id=211578
1204         https://trac.webkit.org/changeset/261296
1205
1206 2020-05-11  Philippe Normand  <pnormand@igalia.com>
1207
1208         [GTK] Media and audio permission request unit tests are timing out
1209         https://bugs.webkit.org/show_bug.cgi?id=158257
1210
1211         Reviewed by Carlos Garcia Campos.
1212
1213         Fix getUserMedia glib tests. They require unsecure capture device context.
1214
1215         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1216         (testWebViewUserMediaEnumerateDevicesPermissionCheck):
1217         (testWebViewUserMediaPermissionRequests):
1218         (testWebViewAudioOnlyUserMediaPermissionRequests):
1219         * TestWebKitAPI/glib/TestExpectations.json:
1220
1221 2020-05-11  Paulo Matos  <pmatos@igalia.com>
1222
1223         Fix typo 'Detacted' -> 'Detected'
1224         https://bugs.webkit.org/show_bug.cgi?id=211715
1225
1226         Unreviewed.
1227
1228         * Scripts/run-jsc-stress-tests:
1229
1230 2020-05-10  Michael Catanzaro  <mcatanzaro@gnome.org>
1231
1232         Update user agent quirk for bankofamerica.com
1233         https://bugs.webkit.org/show_bug.cgi?id=211700
1234
1235         Reviewed by Carlos Garcia Campos.
1236
1237         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1238         (TestWebKitAPI::TEST):
1239
1240 2020-05-08  Darin Adler  <darin@apple.com>
1241
1242         Streamline MarkupAccumulator to improve efficiency a bit
1243         https://bugs.webkit.org/show_bug.cgi?id=211656
1244
1245         Reviewed by Anders Carlsson.
1246
1247         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1248         (TestWebKitAPI::TEST): Fix spellling error in the word "explicitly".
1249
1250 2020-05-08  David Kilzer  <ddkilzer@apple.com>
1251
1252         Remove empty directories from from svn.webkit.org repository
1253         <https://webkit.org/b/211644>
1254
1255         Reviewed by Darin Adler.
1256
1257         * BuildSlaveSupport/gtk: Removed.
1258         * flatpak/files: Removed.
1259         * flatpak/patches: Removed.
1260
1261 2020-05-08  Basuke Suzuki  <basuke.suzuki@sony.com>
1262
1263         [WTF] Share Linux's MemoryPressureHandler among other Unix ports
1264         https://bugs.webkit.org/show_bug.cgi?id=208955
1265
1266         Reviewed by Yusuke Suzuki.
1267
1268         Fix unneeded library dependency.
1269
1270         * TestWebKitAPI/CMakeLists.txt:
1271
1272 2020-05-08  Jonathan Bedard  <jbedard@apple.com>
1273
1274         webkitpy: 'iPhone SE' should match 'iPhone SE 1st generation'
1275         https://bugs.webkit.org/show_bug.cgi?id=211642
1276         <rdar://problems/62986242>
1277
1278         Rubber-stamped by Aakash Jain.
1279
1280         * Scripts/webkitpy/xcode/device_type.py:
1281         (DeviceType):
1282         (DeviceType.standardized_hardware_type): Strip '1st generation' from models.
1283         (DeviceType.__eq__): Use standardized hardware type.
1284         (DeviceType.__contains__): Ditto.
1285         (DeviceType.__hash__): Ditto.
1286         * Scripts/webkitpy/xcode/device_type_unittest.py:
1287         (DeviceTypeTest):
1288         (DeviceTypeTest.test_generation_matching):
1289         * Scripts/webkitpy/xcode/simulated_device.py:
1290         (SimulatedDeviceManager._get_device_identifier_for_type): Handle case where the requests model does not
1291         end with '(1st generation)', but the simctl model does.
1292         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1293
1294 2020-05-08  Ryan Haddad  <ryanhaddad@apple.com>
1295
1296         TestWebKitAPI.WebKit.AllowsContentJavaScript fails on iPad simulator
1297         https://bugs.webkit.org/show_bug.cgi?id=207874
1298
1299         Unreviewed test gardening.
1300
1301         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
1302         Disable the test for iOS.
1303
1304 2020-05-08  David Kilzer  <ddkilzer@apple.com>
1305
1306         check-webkit-style false positive for [readability/naming/protected] with method declaration
1307         <https://webkit.org/b/210682>
1308
1309         Reviewed by Darin Adler.
1310
1311         * Scripts/webkitpy/style/checkers/cpp.py:
1312         (check_identifier_name_in_declaration):
1313         - Don't check for invalid protector name if the capitalized
1314           protected name is the same as the original protected name,
1315           indicating it's a type name.
1316         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1317         (WebKitStyleTest.test_names):
1318         - Add test cases.
1319
1320 2020-05-08  Alex Christensen  <achristensen@webkit.org>
1321
1322         Fix build on platforms without network framework.
1323         https://bugs.webkit.org/show_bug.cgi?id=211603
1324
1325         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:
1326         Add HAVE(NETWORK_FRAMEWORK) around test that uses network framework.
1327
1328 2020-05-08  Aakash Jain  <aakash_jain@apple.com>
1329
1330         Delete old ews client side code
1331         https://bugs.webkit.org/show_bug.cgi?id=211638
1332
1333         Reviewed by Jonathan Bedard.
1334
1335         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1336         * Scripts/webkitpy/common/config/urls.py: Removed old ews server url.
1337         * Scripts/webkitpy/common/net/statusserver.py: Removed.
1338         * Scripts/webkitpy/common/net/statusserver_mock.py: Removed.
1339         * Scripts/webkitpy/tool/bot/botinfo.py:
1340         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
1341         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1342         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1343         * Scripts/webkitpy/tool/bot/queueengine.py:
1344         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1345         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1346         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1347         * Scripts/webkitpy/tool/commands/perfalizer.py:
1348         * Scripts/webkitpy/tool/commands/queues.py:
1349         (AbstractQueue._log_from_script_error_for_upload): Deleted.
1350         (AbstractQueue._update_status_for_script_error): Deleted.
1351         (AbstractPatchQueue._update_status): Deleted.
1352         (AbstractPatchQueue._release_work_item): Deleted.
1353         (AbstractPatchQueue._did_pass): Deleted.
1354         (AbstractPatchQueue._did_fail): Deleted.
1355         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1356         (AbstractQueueTest._assert_run_webkit_patch):
1357         (AbstractQueueTest.test_no_iteration_count):
1358         (PatchProcessingQueueTest.test_upload_results_archive_for_patch):
1359         (AbstractQueueTest._assert_log_message): Deleted.
1360         (AbstractQueueTest.test_log_from_script_error_for_upload): Deleted.
1361         (AbstractPatchQueueTest): Deleted.
1362         (NeedsUpdateSequence): Deleted.
1363         (NeedsUpdateSequence._run): Deleted.
1364         (StyleQueueTest): Deleted.
1365         (StyleQueueTest.test_style_queue_with_style_exception): Deleted.
1366         * Scripts/webkitpy/tool/commands/queuestest.py:
1367         (QueuesTest._default_begin_work_queue_logs):
1368         (QueuesTest._default_begin_work_queue_stderr): Deleted.
1369         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1370         * Scripts/webkitpy/tool/main.py:
1371         * Scripts/webkitpy/tool/mocktool.py:
1372
1373 2020-05-08  Alex Christensen  <achristensen@webkit.org>
1374
1375         Limit HTTP referer to 4kb
1376         https://bugs.webkit.org/show_bug.cgi?id=211603
1377         <rdar://problem/56768823>
1378
1379         Reviewed by Chris Dumez.
1380
1381         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:
1382         (TEST):
1383
1384 2020-05-08  Dean Jackson  <dino@apple.com>
1385
1386         Allow run-safari to launch an iPad simulator
1387         https://bugs.webkit.org/show_bug.cgi?id=211606
1388         <rdar://problem/63002849>
1389
1390         Reviewed by Jon Lee.
1391
1392         Add an "--ipad-simulator" command line option to run-safari.
1393
1394         * Scripts/webkitdirs.pm:
1395         (argumentsForConfiguration):
1396         (determineXcodeSDK): Mark the device idiom depending on the command line argument.
1397         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded):
1398         (findOrCreateSimulatorForIOSDevice): Create an iPad Pro simulator if requested.
1399
1400 2020-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1401
1402         Preserve character set information when writing to the pasteboard when copying rich text
1403         https://bugs.webkit.org/show_bug.cgi?id=211524
1404
1405         Reviewed by Darin Adler.
1406
1407         Add a new API test to verify that the HTML data written to the pasteboard when copying a rich text selection
1408         can be converted into an `NSAttributedString` that contains correctly encoded non-Latin characters.
1409
1410         * TestWebKitAPI/Tests/WebKitCocoa/CopyHTML.mm:
1411
1412 2020-05-08  Chris Dumez  <cdumez@apple.com>
1413
1414         REGRESSION(r259209) Webview's pending URL is null after restoring session state
1415         https://bugs.webkit.org/show_bug.cgi?id=211626
1416         <rdar://problem/62992262>
1417
1418         Reviewed by Alex Christensen.
1419
1420         Add API test coverage.
1421
1422         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
1423         (TestWebKitAPI::TEST):
1424
1425 2020-05-08  Alex Christensen  <achristensen@webkit.org>
1426
1427         WKWebView.title should be safe browsing warning's title during a safe browsing warning
1428         https://bugs.webkit.org/show_bug.cgi?id=211403
1429
1430         Reviewed by Tim Horton.
1431
1432         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1433         (TEST):
1434
1435 2020-05-08  Lauro Moura  <lmoura@igalia.com>
1436
1437         [GTK][WPE] Create common glib expectation file
1438         https://bugs.webkit.org/show_bug.cgi?id=211183
1439
1440         Reviewed by Carlos Garcia Campos.
1441
1442         * Scripts/webkitpy/port/gtk.py:
1443         (GtkPort._search_paths): Add glib to expectations search path
1444         (GtkPort.test_expectations_file_position): Update test
1445         * Scripts/webkitpy/port/gtk_unittest.py:
1446         (GtkPortTest.test_default_baseline_search_path): Update test
1447         (GtkPortTest.test_port_specific_expectations_files): Update test and
1448         make check-webkit-style happier
1449         * Scripts/webkitpy/port/wpe.py:
1450         (WPEPort._search_paths): Add glib to expectations search path
1451         (WPEPort.test_expectations_file_position): Update test
1452         * Scripts/webkitpy/port/wpe_unittest.py:
1453         (WPEPortTest.test_default_baseline_search_path): Update test
1454         (WPEPortTest.test_port_specific_expectations_files): Update test and
1455         make check-webkit-style happier
1456
1457 2020-05-08  Paulo Matos  <pmatos@igalia.com>
1458
1459         Add myself as committer to contributors.json
1460
1461         * Scripts/webkitpy/common/config/contributors.json:
1462
1463 2020-05-07  Jiewen Tan  <jiewen_tan@apple.com>
1464
1465         [WebAuthn] Roll back newly created credentials if an error occurs
1466         https://bugs.webkit.org/show_bug.cgi?id=183530
1467         <rdar://problem/43357305>
1468
1469         Reviewed by Brent Fulgham.
1470
1471         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1472         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
1473         (TestWebKitAPI::TEST):
1474         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-no-attestation.html: Added.
1475         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la.html:
1476
1477 2020-05-07  Saam Barati  <sbarati@apple.com>
1478
1479         run-javascriptcore-tests with remote should be verbose
1480         https://bugs.webkit.org/show_bug.cgi?id=211596
1481
1482         Reviewed by Alexey Proskuryakov.
1483
1484         Our iOS testing bots could use this better output.
1485
1486         * Scripts/run-javascriptcore-tests:
1487         (runJSCStressTests):
1488
1489 2020-05-07  Jonathan Bedard  <jbedard@apple.com>
1490
1491         webkitpy: Use apple_additions certificate path if available
1492         https://bugs.webkit.org/show_bug.cgi?id=211584
1493
1494         Rubber-stamped by Aakash Jain
1495
1496         * Scripts/webkitpy/results/upload.py:
1497         (Upload):
1498         (Upload.certificate_chain): Certificate chain to be used, prefer apple_additions
1499         over certifi.
1500         (Upload.upload): Use Upload.certificate_chain().
1501         (Upload.upload_archive): Ditto.
1502
1503 2020-05-07  Commit Queue  <commit-queue@webkit.org>
1504
1505         Unreviewed, reverting r260959.
1506         https://bugs.webkit.org/show_bug.cgi?id=211587
1507
1508         "Causes MiniBrowser to crash when closing a window" (Requested
1509         by ddkilzer on #webkit).
1510
1511         Reverted changeset:
1512
1513         "REGRESSION (r176862, r210483): Leaks of
1514         BrowserWindowController in MiniBrowser/mac/AppDelegate.m"
1515         https://bugs.webkit.org/show_bug.cgi?id=211243
1516         https://trac.webkit.org/changeset/260959
1517
1518 2020-05-07  Darin Adler  <darin@apple.com>
1519
1520         Remove USE(INSERTION_UNDO_GROUPING) checks in macOS platform code
1521         https://bugs.webkit.org/show_bug.cgi?id=211525
1522
1523         Reviewed by Anders Carlsson.
1524
1525         * DumpRenderTree/mac/TextInputControllerMac.m: Use NSTextInputContextSPI.h.
1526         (-[TextInputController stringWithUndoGroupingInsertion:]): Removed
1527         SUPPORT_INSERTION_UNDO_GROUPING.
1528         * DumpRenderTree/mac/UIScriptControllerMac.mm: Use NSTextInputContextSPI.h.
1529         * TestRunnerShared/spi/AppKitTestSPI.h: Removed
1530         NSTextInputContext_Private.h, clients can use NSTextInputContextSPI.h.
1531         * TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h: Ditto.
1532         * TestWebKitAPI/Tests/mac/CandidateTests.mm: Use NSTextInputContextSPI.h.
1533         * TestWebKitAPI/Tests/mac/WKWebViewMacEditingTests.mm: Ditto.
1534
1535 2020-05-07  Aakash Jain  <aakash_jain@apple.com>
1536
1537         Delete code for old commit queue
1538         https://bugs.webkit.org/show_bug.cgi?id=211581
1539
1540         Reviewed by Alexey Proskuryakov.
1541
1542         * Scripts/webkitpy/common/config/committervalidator.py: Removed.
1543         * Scripts/webkitpy/common/config/committervalidator_unittest.py: Removed.
1544         * Scripts/webkitpy/tool/bot/commitqueuetask.py: Removed.
1545         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: Removed.
1546         * Scripts/webkitpy/tool/commands/queues.py:
1547         (PatchProcessingQueue._upload_results_archive_for_patch):
1548         (CommitQueue): Deleted.
1549         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1550         (NeedsUpdateSequence._run):
1551         (TestCommitQueue): Deleted.
1552         (AlwaysCommitQueueTool): Deleted.
1553         (SecondThoughtsCommitQueue): Deleted.
1554         (CommitQueueTest): Deleted.
1555         (test_did_pass_testing_ews): Deleted.
1556         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
1557         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1558
1559 2020-05-07  Ryan Haddad  <ryanhaddad@apple.com>
1560
1561         Unreviewed, reverting r261286.
1562
1563         Tests are still crashing / failing
1564
1565         Reverted changeset:
1566
1567         "Unskip the test since it should now be passing"
1568         https://trac.webkit.org/changeset/261286
1569
1570 2020-05-07  Commit Queue  <commit-queue@webkit.org>
1571
1572         Unreviewed, reverting r260769.
1573         https://bugs.webkit.org/show_bug.cgi?id=211578
1574
1575         Introduced regressions related to sharing (Requested by
1576         perarne on #webkit).
1577
1578         Reverted changeset:
1579
1580         "[Cocoa] After r258891, r255119 can be reverted"
1581         https://bugs.webkit.org/show_bug.cgi?id=211083
1582         https://trac.webkit.org/changeset/260769
1583
1584 2020-05-07  Lauro Moura  <lmoura@igalia.com>
1585
1586         [Flatpak SDK] Fix string.format invocation
1587
1588         Reviewed by Philippe Normand.
1589
1590         * flatpak/flatpakutils.py:
1591         (WebkitFlatpak.run_in_sandbox):
1592
1593 2020-05-07  Philippe Normand  <pnormand@igalia.com>
1594
1595         [Flatpak SDK] Doesn't generate crash logs on the bots
1596         https://bugs.webkit.org/show_bug.cgi?id=211568
1597
1598         Reviewed by Carlos Alberto Lopez Perez.
1599
1600         * flatpak/flatpakutils.py:
1601         (WebkitFlatpak.run_in_sandbox): Bind-mount the
1602         WEBKIT_CORE_DUMPS_DIRECTORY so that the crash-log generator is
1603         able to write crash log reports there.
1604
1605 2020-05-07  Truitt Savell  <tsavell@apple.com>
1606
1607         Unskip the test since it should now be passing
1608
1609         Unreviewed test gardening.
1610
1611         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
1612
1613 2020-05-07  Philippe Normand  <pnormand@igalia.com>
1614
1615         [GTK] Test failures after Flatpak upgrade
1616         https://bugs.webkit.org/show_bug.cgi?id=211497
1617
1618         Reviewed by Adrian Perez de Castro.
1619
1620         * flatpak/flatpakutils.py:
1621         (WebkitFlatpak.run_in_sandbox): Don't set WEBKIT_TOP_LEVEL. I'm
1622         not sure why it's needed at all. If it needs to be set it should
1623         be /app/webkit/ anyway. Setting it to /app triggers test failures
1624         due to invalid computed paths by internals' pathToLocalResource().
1625
1626 2020-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1627
1628         Unreviewed. Fix GTK4 build with current GTK
1629
1630         GtkWindow and GtkOverlay aren't a GtkContainer anymore.
1631
1632         * MiniBrowser/gtk/BrowserTab.c:
1633         (browserTabConstructed):
1634         * MiniBrowser/gtk/BrowserWindow.c:
1635         (browser_window_init):
1636
1637 2020-05-07  Philippe Normand  <pnormand@igalia.com>
1638
1639         [Flatpak SDK] Import build definitions
1640         https://bugs.webkit.org/show_bug.cgi?id=211448
1641
1642         Reviewed by Carlos Alberto Lopez Perez.
1643
1644         To build the SDK, run `Tools/Scripts/webkit-flatpak-sdk --build`,
1645         this can take hours and use gigabytes of your hard-drive. To build
1646         a single recipe, use something like:
1647
1648         `Tools/Scripts/bst-wrapper build sdk/gtk.bst`
1649
1650         To enter the Buildstream SDK shell and debug stuff when hacking on
1651         a specific dependency, `Tools/Scripts/bst-wrapper shell sdk/gtk.bst`.
1652
1653         To test your changes in WebKit:
1654         ```shell
1655         $ Tools/Scripts/webkit-flatpak -u --repo=Tools/buildstream/repo
1656         $ Tools/Scripts/run-minibrowser --gtk --flatpak-repo=Tools/buildstream/repo <url>
1657         ...
1658         ```
1659
1660         bst-wrapper has the same options as bst itself, documented on
1661         https://docs.buildstream.build/1.4.2/index.html.
1662
1663         Internally the bst-wrapper will install Buildstream and a few
1664         other python dependencies in a local virtualenv managed by pipenv.
1665         This is all abstracted though, in theory direct access to the
1666         pipenv environment shouldn't be needed.
1667
1668         * Scripts/bst-wrapper: Added.
1669         * Scripts/webkit-flatpak-sdk: Added.
1670         * buildstream/Makefile: Added.
1671         * buildstream/Pipfile: Added.
1672         * buildstream/Pipfile.lock: Added.
1673         * buildstream/elements/filtered-openh264.bst: Added.
1674         * buildstream/elements/filtered.bst: Added.
1675         * buildstream/elements/flatpak-platform-extensions.bst: Added.
1676         * buildstream/elements/flatpak-runtimes.bst: Added.
1677         * buildstream/elements/flatpak/platform-arch-libs-debug.bst: Added.
1678         * buildstream/elements/flatpak/platform-arch-libs.bst: Added.
1679         * buildstream/elements/flatpak/platform-image.bst: Added.
1680         * buildstream/elements/flatpak/platform-locale.bst: Added.
1681         * buildstream/elements/flatpak/platform.bst: Added.
1682         * buildstream/elements/flatpak/sdk-arch-libs-debug.bst: Added.
1683         * buildstream/elements/flatpak/sdk-arch-libs.bst: Added.
1684         * buildstream/elements/flatpak/sdk-debug.bst: Added.
1685         * buildstream/elements/flatpak/sdk-docs.bst: Added.
1686         * buildstream/elements/flatpak/sdk-image.bst: Added.
1687         * buildstream/elements/flatpak/sdk-locale.bst: Added.
1688         * buildstream/elements/flatpak/sdk.bst: Added.
1689         * buildstream/elements/freedesktop-sdk.bst: Added.
1690         * buildstream/elements/manifests/platform-manifest.bst: Added.
1691         * buildstream/elements/manifests/sdk-manifest.bst: Added.
1692         * buildstream/elements/qt5.bst: Added.
1693         * buildstream/elements/qt5/qtbase.bst: Added.
1694         * buildstream/elements/qt5/qtdeclarative.bst: Added.
1695         * buildstream/elements/qt5/qtquickcontrols.bst: Added.
1696         * buildstream/elements/qt5/qtquickcontrols2.bst: Added.
1697         * buildstream/elements/qt5/qtwayland.bst: Added.
1698         * buildstream/elements/qt5/qtx11extras.bst: Added.
1699         * buildstream/elements/sdk-build-depends/libusb.bst: Added.
1700         * buildstream/elements/sdk-build-depends/sassc.bst: Added.
1701         * buildstream/elements/sdk-build-depends/utf8proc.bst: Added.
1702         * buildstream/elements/sdk-depends/libsass.bst: Added.
1703         * buildstream/elements/sdk-platform.bst: Added.
1704         * buildstream/elements/sdk.bst: Added.
1705         * buildstream/elements/sdk/adwaita-icon-theme.bst: Added.
1706         * buildstream/elements/sdk/at-spi2-atk.bst: Added.
1707         * buildstream/elements/sdk/at-spi2-core.bst: Added.
1708         * buildstream/elements/sdk/atk.bst: Added.
1709         * buildstream/elements/sdk/brotli.bst: Added.
1710         * buildstream/elements/sdk/capnp.bst: Added.
1711         * buildstream/elements/sdk/enchant-2.bst: Added.
1712         * buildstream/elements/sdk/glib-networking.bst: Added.
1713         * buildstream/elements/sdk/glib.bst: Added.
1714         * buildstream/elements/sdk/gobject-introspection.bst: Added.
1715         * buildstream/elements/sdk/graphene.bst: Added.
1716         * buildstream/elements/sdk/graphviz.bst: Added.
1717         * buildstream/elements/sdk/gst-libav.bst: Added.
1718         * buildstream/elements/sdk/gst-plugins-bad.bst: Added.
1719         * buildstream/elements/sdk/gst-plugins-base.bst: Added.
1720         * buildstream/elements/sdk/gst-plugins-good.bst: Added.
1721         * buildstream/elements/sdk/gst-plugins-ugly.bst: Added.
1722         * buildstream/elements/sdk/gstreamer.bst: Added.
1723         * buildstream/elements/sdk/gtk+-3.bst: Added.
1724         * buildstream/elements/sdk/gtk.bst: Added.
1725         * buildstream/elements/sdk/icecc.bst: Added.
1726         * buildstream/elements/sdk/intltool.bst: Added.
1727         * buildstream/elements/sdk/krb5.bst: Added.
1728         * buildstream/elements/sdk/libcap-ng.bst: Added.
1729         * buildstream/elements/sdk/libevent.bst: Added.
1730         * buildstream/elements/sdk/libgcrypt.bst: Added.
1731         * buildstream/elements/sdk/libmanette.bst: Added.
1732         * buildstream/elements/sdk/libnotify.bst: Added.
1733         * buildstream/elements/sdk/libopenh264.bst: Added.
1734         * buildstream/elements/sdk/libsecret.bst: Added.
1735         * buildstream/elements/sdk/libsoup.bst: Added.
1736         * buildstream/elements/sdk/libsrtp2.bst: Added.
1737         * buildstream/elements/sdk/libusrsctp.bst: Added.
1738         * buildstream/elements/sdk/libwpe.bst: Added.
1739         * buildstream/elements/sdk/libzstd.bst: Added.
1740         * buildstream/elements/sdk/lzo2.bst: Added.
1741         * buildstream/elements/sdk/openjpeg.bst: Added.
1742         * buildstream/elements/sdk/openxr.bst: Added.
1743         * buildstream/elements/sdk/os-release.bst: Added.
1744         * buildstream/elements/sdk/patchelf.bst: Added.
1745         * buildstream/elements/sdk/psmisc.bst: Added.
1746         * buildstream/elements/sdk/pycairo.bst: Added.
1747         * buildstream/elements/sdk/pygobject.bst: Added.
1748         * buildstream/elements/sdk/python2-pycairo.bst: Added.
1749         * buildstream/elements/sdk/python2-pygobject.bst: Added.
1750         * buildstream/elements/sdk/python2-six.bst: Added.
1751         * buildstream/elements/sdk/python2-subprocess32.bst: Added.
1752         * buildstream/elements/sdk/python2.bst: Added.
1753         * buildstream/elements/sdk/rr.bst: Added.
1754         * buildstream/elements/sdk/sccache.bst: Added.
1755         * buildstream/elements/sdk/shared-mime-info.bst: Added.
1756         * buildstream/elements/sdk/subversion.bst: Added.
1757         * buildstream/elements/sdk/v4lutils.bst: Added.
1758         * buildstream/elements/sdk/woff2.bst: Added.
1759         * buildstream/elements/sdk/wpebackend-fdo.bst: Added.
1760         * buildstream/elements/sdk/x264.bst: Added.
1761         * buildstream/elements/sdk/xorg-server.bst: Added.
1762         * buildstream/elements/test-infra.bst: Added.
1763         * buildstream/elements/test-infra/apr-util.bst: Added.
1764         * buildstream/elements/test-infra/apr.bst: Added.
1765         * buildstream/elements/test-infra/httpd.bst: Added.
1766         * buildstream/elements/test-infra/perl-cgi-pm.bst: Added.
1767         * buildstream/elements/test-infra/perl-http-date-pm.bst: Added.
1768         * buildstream/elements/test-infra/php.bst: Added.
1769         * buildstream/elements/test-infra/webkitgtk-test-dicts.bst: Added.
1770         * buildstream/elements/test-infra/webkitgtk-test-fonts.bst: Added.
1771         * buildstream/files/krb5/krb5.conf: Added.
1772         * buildstream/files/os-release/issue.in: Added.
1773         * buildstream/files/os-release/issue.net.in: Added.
1774         * buildstream/files/os-release/org.webkit.Platform.appdata.xml.in: Added.
1775         * buildstream/files/os-release/org.webkit.Sdk.appdata.xml.in: Added.
1776         * buildstream/files/os-release/os-release.in: Added.
1777         * buildstream/patches/fdo-0001-Update-gcc-to-9.3.0.patch: Added.
1778         * buildstream/patches/fdo/0001-Add-Jack.patch: Added.
1779         * buildstream/patches/fdo/0001-components-xdg-desktop-portal.bst-Update-to-1.6.0.patch: Added.
1780         * buildstream/patches/fdo/0001-ffmpeg-Add-MS-MPEG-DivX-variants.patch: Added.
1781         * buildstream/patches/fdo/0002-Update-PipeWire-to-0.3.1.patch: Added.
1782         * buildstream/patches/fdo/0002-ffmpeg-Add-VP6-and-Sorenson-Spark-video-codecs.patch: Added.
1783         * buildstream/patches/fdo/0003-Add-Bluez.patch: Added.
1784         * buildstream/patches/fdo/0003-ffmpeg-Add-Intel-Indeo-and-Cinepak-video-support.patch: Added.
1785         * buildstream/patches/fdo/0004-ffmpeg-Add-MPEG-2-video-decoder.patch: Added.
1786         * buildstream/patches/fdo/0005-ffmpeg-Add-msmpeg4v3-support.patch: Added.
1787         * buildstream/patches/gst-libav-stop-caching-codecs.patch: Added.
1788         * buildstream/patches/gst-plugins-bad-0001-h264parse-Post-a-WARNING-when-data-is-broken.patch: Added.
1789         * buildstream/patches/gst-plugins-base-0001-glupload-Fix-fallback-from-direct-dmabuf-to-dmabuf-u.patch: Added.
1790         * buildstream/patches/gst-plugins-base-0001-playbin-Handle-error-message-with-redirection-indica.patch: Added.
1791         * buildstream/patches/gst-plugins-base-0002-glupload-fix-segfault.patch: Added.
1792         * buildstream/patches/gst-plugins-good-qtdemux-Specify-REDIRECT-information-in-error-messag.patch: Added.
1793         * buildstream/patches/gtk-meson-Bump-to-latest-version-of-the-3.24-branch.patch: Added.
1794         * buildstream/patches/httpd-0001-configure-use-pkg-config-for-PCRE-detection.patch: Added.
1795         * buildstream/patches/libav-0001-gstavviddec-Limit-default-number-of-decoder-threads.patch: Added.
1796         * buildstream/patches/libgcrypt-0001-Use-pkg-config-to-detect-gpg-error.patch: Added.
1797         * buildstream/patches/libgcrypt-use-only-dev-urandom-for-testing.patch: Added.
1798         * buildstream/patches/libsecret-b53e9876f4611525b7a8f69a3110fbec51dcede0.patch: Added.
1799         * buildstream/patches/nettle-no-debug.diff: Added.
1800         * buildstream/patches/qtbase-avoid-hardcoding-kernel-version.patch: Added.
1801         * buildstream/patches/qtbase-revert-correct-handling-for-xdg-runtime-dir.patch: Added.
1802         * buildstream/patches/qtbase-use-wayland-on-gnome.patch: Added.
1803         * buildstream/patches/qtdeclarative-use-python3.patch: Added.
1804         * buildstream/patches/qtwayland-use-gnome-platform-theme-on-gnome-based-desktops.patch: Added.
1805         * buildstream/patches/sccache-no-selenium.patch: Added.
1806         * buildstream/patches/xserver-search-for-DRI-drivers-at-LIBGL_DRIVERS_PATH-environ.patch: Added.
1807         * buildstream/project.conf: Added.
1808         * buildstream/utils/generate-version: Added.
1809         * gtk/install-dependencies:
1810         * wpe/install-dependencies:
1811
1812 2020-05-07  Mark Lam  <mark.lam@apple.com>
1813
1814         Fix broken exceptionFuzz tests.
1815         https://bugs.webkit.org/show_bug.cgi?id=211550
1816
1817         Reviewed by Yusuke Suzuki.
1818
1819         Pass the --useExceptionFuzz=true option from the command line for runExceptionFuzz.
1820
1821         * Scripts/run-jsc-stress-tests:
1822
1823 2020-05-06  Kate Cheney  <katherine_cheney@apple.com>
1824
1825         ResourceLoadStatistics data summary call should create a web process pool if one doesn't exist
1826         https://bugs.webkit.org/show_bug.cgi?id=211520
1827         <rdar://problem/59869619>
1828
1829         Reviewed by Chris Dumez.
1830
1831         Added API test coverage.
1832
1833         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1834         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1835         Removed stray comment from previous test.
1836
1837         (TEST):
1838         * TestWebKitAPI/basicITPDatabase.db: Added.
1839         * TestWebKitAPI/basicITPDatabase.db-shm: Added.
1840         * TestWebKitAPI/basicITPDatabase.db-wal: Added.
1841         New database resource with 2 entries: apple.com and webkit.org, with
1842         webkit.org registered as a subframe of apple.com
1843
1844 2020-05-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1845
1846         Cut and paste from Google Doc to Notes in several (non-Latin) languages doesn't work
1847         https://bugs.webkit.org/show_bug.cgi?id=211498
1848         <rdar://problem/56675345>
1849
1850         Reviewed by Darin Adler.
1851
1852         Add a test to verify that when writing markup to the clipboard via DOM API, if non-ASCII characters appear in
1853         the written markup, they can still be converted to `NSAttributedString`s containing the expected non-Latin text.
1854
1855         * TestWebKitAPI/Configurations/Base.xcconfig:
1856
1857         Adjust header search paths so that we can import CocoaColor.h in WebKit.
1858
1859         * TestWebKitAPI/Tests/WebKitCocoa/CopyHTML.mm:
1860         (readHTMLDataFromPasteboard):
1861         (readHTMLStringFromPasteboard):
1862         (readHTMLFromPasteboard): Deleted.
1863
1864 2020-05-06  Ryan Haddad  <ryanhaddad@apple.com>
1865
1866         REGRESSION (r260278): TestWebKitAPI.Fullscreen.Delegate is timing out on macOS bots
1867         https://bugs.webkit.org/show_bug.cgi?id=210676
1868
1869         Unreviewed test gardening.
1870
1871         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenAlert.mm:
1872         (TestWebKitAPI::TEST): Skip the test to get the bots to green.
1873
1874 2020-05-06  John Wilander  <wilander@apple.com>
1875
1876         Exempt app-bound domains from ITP's website data deletion and third-party cookie blocking between themselves
1877         https://bugs.webkit.org/show_bug.cgi?id=210674
1878         <rdar://problem/61950767>
1879
1880         Reviewed by Chris Dumez.
1881
1882         This change adds a new TestRunner function
1883         setAppBoundDomain() which takes an array of origin
1884         strings and sets them to app-bound domains.
1885
1886         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1887         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1888         (WTR::InjectedBundle::didReceiveMessageToPage):
1889         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1890         (WTR::TestRunner::setAppBoundDomains):
1891         (WTR::TestRunner::didSetAppBoundDomainsCallback):
1892         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1893         * WebKitTestRunner/TestController.cpp:
1894         (WTR::AppBoundDomainsCallbackContext::AppBoundDomainsCallbackContext):
1895         (WTR::didSetAppBoundDomainsCallback):
1896         (WTR::TestController::setAppBoundDomains):
1897         * WebKitTestRunner/TestController.h:
1898         * WebKitTestRunner/TestInvocation.cpp:
1899         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1900         (WTR::TestInvocation::didSetAppBoundDomains):
1901         * WebKitTestRunner/TestInvocation.h:
1902
1903 2020-05-06  Aakash Jain  <aakash_jain@apple.com>
1904
1905         Delete code for feeder queue
1906         https://bugs.webkit.org/show_bug.cgi?id=211518
1907
1908         Reviewed by Jonathan Bedard.
1909
1910         * Scripts/webkitpy/tool/bot/feeders.py: Removed.
1911         * Scripts/webkitpy/tool/bot/feeders_unittest.py: Removed.
1912         * Scripts/webkitpy/tool/commands/queues.py:
1913         (FeederQueue): Deleted.
1914         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1915         (TestFeederQueue): Deleted.
1916         (FeederQueueTest): Deleted.
1917         (PatchProcessingQueueTest): Deleted.
1918
1919 2020-05-06  Darin Adler  <darin@apple.com>
1920
1921         Eliminate checks of USE(DICTATION_ALTERNATIVES) in Cocoa-specific code
1922         https://bugs.webkit.org/show_bug.cgi?id=211460
1923
1924         Reviewed by Anders Carlsson.
1925
1926         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm: Remove USE(DICTATION_ALTERNATIVES).
1927
1928 2020-05-06  Pablo Saavedra  <psaavedra@igalia.com>
1929
1930         Python3: Support Python3 in Tools/webkitpy/benchmark_runner
1931         https://bugs.webkit.org/show_bug.cgi?id=211249
1932
1933         Reviewed by Jonathan Bedard.
1934
1935         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
1936         (BenchmarkBuilder._fetch_remote_archive):
1937         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
1938         (BenchmarkResults._format_values):
1939         (BenchmarkResults._subtest_values_by_config_iteration):
1940         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1941         (istext):
1942         (BenchmarkRunner._run_benchmark):
1943         (BenchmarkRunner._merge):
1944         (BenchmarkRunner.show_results):
1945         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1946         (OSXSafariDriver.launch_url):
1947         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
1948         (HTTPServerDriver):
1949         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
1950         (SimpleHTTPServerDriver.serve):
1951         (SimpleHTTPServerDriver._wait_for_http_server):
1952         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1953         (parse_args):
1954         (list_benchmark_plans):
1955         * Scripts/webkitpy/style/checker.py:
1956         (CheckerDispatcher._create_checker):
1957
1958 2020-05-06  Aakash Jain  <aakash_jain@apple.com>
1959
1960         Delete code for QueueStatusServer
1961         https://bugs.webkit.org/show_bug.cgi?id=211504
1962
1963         Reviewed by Jonathan Bedard.
1964
1965         * QueueStatusServer: Removed.
1966         * BuildSlaveSupport/ews-build/steps.py:
1967         (CheckPatchRelevance): Removed QueueStatusServer.
1968         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
1969         (CheckPatchRelevance): Removed QueueStatusServer.
1970         * Scripts/webkitpy/common/net/statusserver.py: Removed implementation of most methods. Will delete it completely
1971         in subsequent patch along-with all its callers.
1972         * Scripts/webkitpy/common/net/statusserver_unittest.py: Removed.
1973         * Scripts/webkitpy/test/main.py:
1974
1975 2020-05-05  Ross Kirsling  <ross.kirsling@sony.com>
1976
1977         [ECMA-402] Implement Intl.Locale
1978         https://bugs.webkit.org/show_bug.cgi?id=209772
1979
1980         Reviewed by Darin Adler and Saam Barati.
1981
1982         * Scripts/run-jsc-stress-tests:
1983         Add runIntlLocaleEnabled.
1984
1985 2020-05-05  Saam Barati  <sbarati@apple.com>
1986
1987         Don't use the DebugHeap for catalyst
1988         https://bugs.webkit.org/show_bug.cgi?id=211471
1989
1990         Reviewed by Tim Horton.
1991
1992         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
1993         (TEST):
1994
1995 2020-05-05  Daniel Bates  <dabates@apple.com>
1996
1997         Should show selection highlight during text interaction
1998         https://bugs.webkit.org/show_bug.cgi?id=211362
1999         <rdar://problem/59191873>
2000
2001         Reviewed by Wenson Hsieh.
2002
2003         Add a test to ensure the selection view has rects after selecting
2004         text during a text interaction. These rects represents the highlight.
2005
2006         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2007         (TestWebKitAPI::TEST):
2008
2009 2020-05-05  Aakash Jain  <aakash_jain@apple.com>
2010
2011         webkitbot isn't responding properly in irc
2012         https://bugs.webkit.org/show_bug.cgi?id=211458
2013
2014         Reviewed by Jonathan Bedard.
2015
2016         * Scripts/webkitpy/tool/commands/queues.py:
2017         (AbstractQueue.run_webkit_patch): Removed status-host paramter since old ews server has been decommissioned.
2018         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: Updated unit-tests.
2019         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2020
2021 2020-05-05  Aakash Jain  <aakash_jain@apple.com>
2022
2023         EWS should skip Apple Win build and tests for patches that only change WebKit2 sources
2024         https://bugs.webkit.org/show_bug.cgi?id=211210
2025
2026         Reviewed by Jonathan Bedard.
2027
2028         * BuildSlaveSupport/ews-build/factories.py:
2029         (WindowsFactory.__init__): enabled relevance checking for windows ews.
2030         * BuildSlaveSupport/ews-build/factories_unittest.py: Updated unit-test.
2031         * BuildSlaveSupport/ews-build/steps.py:
2032         (CheckPatchRelevance): Defined relevance info for windows ews. 
2033         * BuildSlaveSupport/ews-build/steps_unittest.py:
2034         (TestCheckPatchRelevance.test_relevant_windows_wk1_patch): Added unit test.
2035         (TestCheckPatchRelevance.test_queues_without_relevance_info): Fixed unit-test.
2036
2037 2020-05-05  Mark Lam  <mark.lam@apple.com>
2038
2039         Allow Bitmap to use up to a UCPURegister word size for internal bit storage.
2040         https://bugs.webkit.org/show_bug.cgi?id=211328
2041         <rdar://problem/62755865>
2042
2043         Reviewed by Yusuke Suzuki.
2044
2045         Added API tests for WTF::Bitmap to make sure that Bitmap is behaving correctly.
2046         Since Bitmap is used in critical infrastructure like the GC, it is important to
2047         ensure that there are no latent bugs.
2048
2049         * TestWebKitAPI/CMakeLists.txt:
2050         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2051         * TestWebKitAPI/Tests/WTF/Bitmap.cpp: Added.
2052         (TestWebKitAPI::countBits):
2053         (TestWebKitAPI::testBitmapSize):
2054         (TestWebKitAPI::testBitmapConstructedEmpty):
2055         (TestWebKitAPI::testBitmapSetGet):
2056         (TestWebKitAPI::testBitmapTestAndSet):
2057         (TestWebKitAPI::testBitmapTestAndClear):
2058         (TestWebKitAPI::testBitmapConcurrentTestAndSet):
2059         (TestWebKitAPI::testBitmapConcurrentTestAndClear):
2060         (TestWebKitAPI::testBitmapClear):
2061         (TestWebKitAPI::testBitmapClearAll):
2062         (TestWebKitAPI::testBitmapInvert):
2063         (TestWebKitAPI::testBitmapFindRunOfZeros):
2064         (TestWebKitAPI::testBitmapCount):
2065         (TestWebKitAPI::testBitmapIsEmpty):
2066         (TestWebKitAPI::testBitmapIsFull):
2067         (TestWebKitAPI::testBitmapMerge):
2068         (TestWebKitAPI::testBitmapFilter):
2069         (TestWebKitAPI::testBitmapExclude):
2070         (TestWebKitAPI::testBitmapConcurrentFilter):
2071         (TestWebKitAPI::testBitmapSubsumes):
2072         (TestWebKitAPI::testBitmapForEachSetBit):
2073         (TestWebKitAPI::testBitmapFindBit):
2074         (TestWebKitAPI::testBitmapIteration):
2075         (TestWebKitAPI::testBitmapMergeAndClear):
2076         (TestWebKitAPI::testBitmapSetAndClear):
2077         (TestWebKitAPI::testBitmapOperatorEqual):
2078         (TestWebKitAPI::testBitmapOperatorNotEqual):
2079         (TestWebKitAPI::testBitmapHash):
2080         (TestWebKitAPI::TEST):
2081
2082 2020-05-05  Alexey Shvayka  <shvaikalesh@gmail.com>
2083
2084         Object.prototype.toString is not spec-perfect
2085         https://bugs.webkit.org/show_bug.cgi?id=199138
2086
2087         Reviewed by Darin Adler and Keith Miller.
2088
2089         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
2090
2091 2020-05-05  Tim Horton  <timothy_horton@apple.com>
2092
2093         Excessive error logging from daemons trying to use WebKit, under -[UIDevice currentDevice]
2094         https://bugs.webkit.org/show_bug.cgi?id=211397
2095         <rdar://problem/61635403>
2096
2097         Reviewed by Simon Fraser.
2098
2099         * TestWebKitAPI/ios/UserInterfaceSwizzler.h:
2100         We need a UIApplication or WebKit won't look at UIDevice.
2101
2102 2020-05-04  Darin Adler  <darin@apple.com>
2103
2104         [Mac] Remove __MAC_OS_X_VERSION_MIN_REQUIRED checks for versions older than 10.14
2105         https://bugs.webkit.org/show_bug.cgi?id=211420
2106
2107         Reviewed by Alex Christensen.
2108
2109         * TestWebKitAPI/Tests/WebCore/CtapPinTest.cpp: Remove
2110         __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400.
2111
2112         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2113         Removed code disabling this test for __MAC_OS_X_VERSION_MIN_REQUIRED < 101400.
2114
2115         * TestWebKitAPI/config.h: Removed __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400.
2116
2117         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2118         (WTR::installFakeHelvetica): Removed __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400.
2119
2120 2020-05-04  Darin Adler  <darin@apple.com>
2121
2122         Remove now-unneeded HAVE(NETWORK_EXTENSION)
2123         https://bugs.webkit.org/show_bug.cgi?id=211424
2124
2125         Reviewed by Alex Christensen.
2126
2127         * TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm:
2128         (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
2129         Remove check of HAVE(NETWORK_EXTENSION).
2130         * TestWebKitAPI/Tests/WebKitCocoa/ContentFilteringPlugIn.mm:
2131         (-[ContentFilteringPlugIn checkIfPlatformFrameworksAreLoaded:]): Ditto.
2132
2133 2020-05-04  Ben Nham  <nham@apple.com>
2134
2135         IndexedDB WAL file keeps growing while app is in use
2136         https://bugs.webkit.org/show_bug.cgi?id=202137
2137
2138         Reviewed by Brady Eidson.
2139
2140         Add a test to make sure that WAL auto-checkpointing actually works.
2141
2142         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2143         * TestWebKitAPI/Tests/WebKitCocoa/IDBCheckpointWAL.html: Added.
2144         * TestWebKitAPI/Tests/WebKitCocoa/IDBCheckpointWAL.mm: Added.
2145         (-[IDBCheckpointWALMessageHandler userContentController:didReceiveScriptMessage:]):
2146         (fileSizeAtPath):
2147         (TEST):
2148
2149 2020-05-04  Darin Adler  <darin@apple.com>
2150
2151         Make __IPHONE_OS_VERSION_MIN_REQUIRED checks against old versions explicit about watchOS and tvOS
2152         https://bugs.webkit.org/show_bug.cgi?id=211402
2153
2154         Reviewed by Alexey Proskuryakov.
2155
2156         * TestWebKitAPI/Tests/WebKitCocoa/DataDetection.mm:
2157         Remove unneeded __IPHONE_OS_VERSION_MIN_REQUIRED check.
2158
2159         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2160         Move from __IPHONE_OS_VERSION_MIN_REQUIRED to
2161         !PLATFORM(WATCHOS) && !PLATFORM(APPLETV).
2162
2163         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2164         Move from __IPHONE_OS_VERSION_MIN_REQUIRED to
2165         PLATFORM(IOS).
2166
2167         * TestWebKitAPI/Tests/ios/OverflowScrollViewTests.mm:
2168         Move from __IPHONE_OS_VERSION_MIN_REQUIRED to
2169         !PLATFORM(WATCHOS) && !PLATFORM(APPLETV).
2170         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2171         (-[TestRunnerWKWebView setOverrideSafeAreaInsets:]): Ditto.
2172
2173 2020-05-04  Darin Adler  <darin@apple.com>
2174
2175         [Cocoa] Remove a few unneeded __IPHONE_OS_VERSION_MIN_REQUIRED checks
2176         https://bugs.webkit.org/show_bug.cgi?id=211383
2177
2178         Reviewed by Alexey Proskuryakov.
2179
2180         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
2181         (TestWebKitAPI::TEST): Removed checks against iOS 12 and 13 in code that
2182         uses PLATFORM(IOS), not PLATFORM(IOS_FAMILY).
2183
2184         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm: Removed a
2185         check against iOS 11 in code using PLATFORM(IOS).
2186
2187 2020-05-04  Darin Adler  <darin@apple.com>
2188
2189         Remove HAVE(IOSURFACE) checks in Cocoa-platform-specific code
2190         https://bugs.webkit.org/show_bug.cgi?id=211389
2191
2192         Reviewed by Alexey Proskuryakov.
2193
2194         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2195         (createBitmapContextFromWebView): Remove BEGIN/END_BLOCK_OBJC_EXCEPTIONS
2196         since they are not needed/appropriate in test code. Remove HAVE(IOSURFACE)
2197         since this is Cocoa-specific.
2198         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2199         (WTR::PlatformWebView::windowSnapshotImage): Ditto.
2200
2201 2020-05-04  Alexey Proskuryakov  <ap@apple.com>
2202
2203         block-spammers tool should hide attachments
2204         https://bugs.webkit.org/show_bug.cgi?id=211406
2205
2206         Reviewed by Darin Adler.
2207
2208         The logic is nearly identical to hiding comments. Just need to limit fields in the
2209         search, so that we don't have to download attachment data.
2210
2211         * Scripts/block-spammers:
2212         (get_comments):
2213         (get_bugs_with_attachments_created_by_user):
2214         (get_attachments):
2215         (hide_comments):
2216         (hide_attachments):
2217         (main):
2218
2219 2020-05-04  Darin Adler  <darin@apple.com>
2220
2221         Remove unneeded USE(MEDIAREMOTE)
2222         https://bugs.webkit.org/show_bug.cgi?id=211385
2223
2224         Reviewed by Eric Carlson.
2225
2226         * TestWebKitAPI/Tests/WebKitCocoa/NowPlaying.mm: Reverse conditional so it's
2227         consistently listing which platforms we do *not* compile the test on.
2228
2229 2020-05-04  Alex Christensen  <achristensen@webkit.org>
2230
2231         [Catalina] ASSERTION FAILED: Unsafe to ref/deref from different threads seen with TestWebKitAPI.MultipleClientCertificateConnections.Failure
2232         https://bugs.webkit.org/show_bug.cgi?id=211300
2233
2234         Reviewed by Youenn Fablet.
2235
2236         RequestData references are stored in blocks given to the network framework, which does things on background threads.
2237         To make them safe to ref and deref on non-main threads, make RequestData ThreadSafeRefCounted.
2238
2239         * TestWebKitAPI/cocoa/HTTPServer.mm:
2240
2241 2020-05-04  Darin Adler  <darin@apple.com>
2242
2243         Remove now-unneeded HAVE(MEDIA_PLAYER)
2244         https://bugs.webkit.org/show_bug.cgi?id=211378
2245
2246         Reviewed by Alex Christensen.
2247
2248         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
2249         (TestWebKitAPI::TEST): Removed HAVE(MEDIA_PLAYER) check since it's now always
2250         true in Objective-C source files.
2251
2252 2020-05-04  Michael Catanzaro  <mcatanzaro@gnome.org>
2253
2254         [WPE][GTK] Should install python3-secretstorage
2255         https://bugs.webkit.org/show_bug.cgi?id=207473
2256
2257         Reviewed by Adrian Perez de Castro.
2258
2259         If python3-secretstorage is not installed, webkit-patch will use a custom encrypted file
2260         for password storage instead of utilizing the system keyring. This means unnecessary
2261         password prompts to unlock the custom encrypted key storage.
2262
2263         There is no benefit to using custom key storage over the system keyring.
2264
2265         * gtk/install-dependencies:
2266         * wpe/install-dependencies:
2267
2268 2020-05-04  Andres Gonzalez  <andresg_22@apple.com>
2269
2270         Add WTR::AccessibilityUIElement::attributeValueAsync to retrieve attribute values in isolated tree mode.
2271         https://bugs.webkit.org/show_bug.cgi?id=211341
2272
2273         Reviewed by Chris Fleizach.
2274
2275         To simulate running WebAccessibilityObjectWrapper methods on the secondary
2276         thread, WTR::AccessibilityUIElement dispatches those calls to the AX
2277         thread. But some WebAccessibilityObjectWrapper calls cannot be fulfilled
2278         on the secondary thread and in turn have to be dispatched to the main
2279         thread. This was causing a thread lock during LayoutTests in isolated
2280         tree mode since the initial dispatch to the secondary thread blocks the
2281         main thread. The solution in this patch is to add an asynchronous
2282         mechanism to retrieve attribute values.
2283         - Added WTR::AccessibilityUIElement::attributeValueAsync.
2284         - Made several fixes consisting of retaining variables in the main
2285         thread whose values are computed on the secondary thread.
2286
2287         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2288         (WTR::AccessibilityController::executeOnAXThreadAndWait):
2289         (WTR::AccessibilityController::executeOnAXThread):
2290         (WTR::AccessibilityController::executeOnMainThread):
2291         (WTR::AXThread::dispatchBarrier):
2292         (WTR::AccessibilityController::executeOnAXThreadIfPossible): Renamed executeOnAXThreadAndWait.
2293         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2294         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2295         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2296         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
2297         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
2298         (WTR::webAccessibilityObjectWrapperClass):
2299         (WTR::makeArrayRefForArray):
2300         (WTR::makeObjectRefForDictionary):
2301         (WTR::makeValueRefForValue):
2302         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
2303         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
2304         (WTR::AccessibilityController::accessibleElementById):
2305         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
2306         (-[AccessibilityNotificationHandler startObserving]):
2307         (-[AccessibilityNotificationHandler _notificationReceived:]):
2308         (webAccessibilityObjectWrapperClass): Moved to AccessibilityCommonMac.
2309         (makeValueRefForValue): Moved to AccessibilityCommonMac.
2310         (makeArrayRefForArray): Moved to AccessibilityCommonMac.
2311         (makeObjectRefForDictionary): Moved to AccessibilityCommonMac.
2312         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2313         (WTR::supportedAttributes):
2314         (WTR::attributeValue):
2315         (WTR::setAttributeValue):
2316         (WTR::attributesOfElement):
2317         (WTR::AccessibilityUIElement::getChildrenWithRange):
2318         (WTR::AccessibilityUIElement::elementAtPoint):
2319         (WTR::AccessibilityUIElement::indexOfChild):
2320         (WTR::AccessibilityUIElement::selectedChildrenCount const):
2321         (WTR::AccessibilityUIElement::attributeValueAsync):
2322         (WTR::AccessibilityUIElement::selectTextWithCriteria):
2323
2324 2020-05-04  Commit Queue  <commit-queue@webkit.org>
2325
2326         Unreviewed, reverting r261076.
2327         https://bugs.webkit.org/show_bug.cgi?id=211371
2328
2329         Triggers obscure X11 error on GTK bots (Requested by philn on
2330         #webkit).
2331
2332         Reverted changeset:
2333
2334         "[Flatpak SDK] Query the doc portal path with DBus"
2335         https://bugs.webkit.org/show_bug.cgi?id=211281
2336         https://trac.webkit.org/changeset/261076
2337
2338 2020-05-04  Philippe Normand  <pnormand@igalia.com>
2339
2340         [Flatpak SDK] Support for local repository and drive-by fixes
2341         https://bugs.webkit.org/show_bug.cgi?id=211370
2342
2343         Reviewed by Žan Doberšek.
2344
2345         This patch adds a new --repo option to webkit-flatpak, allowing
2346         SDK developers to test local changes made to the SDK. As future
2347         versions of the SDK will depend on the ffmpeg FDO extension,
2348         flatpakutils installs it from now on. One consequence is that the
2349         LD_LIBRARY_PATH set in the GTK layout test driver is no longer
2350         overriden when running in the flatpak SDK, in order to allow the
2351         extension to set it correctly.
2352
2353         * Scripts/webkitpy/port/gtk.py:
2354         (GtkPort.setup_environ_for_server):
2355         * flatpak/flatpakutils.py:
2356         (FlatpakRepos.add):
2357         (FlatpakRepo.repo_file):
2358         (WebkitFlatpak.load_from_args):
2359         (WebkitFlatpak.__init__):
2360         (WebkitFlatpak.clean_args):
2361         (WebkitFlatpak._reset_repository):
2362         (WebkitFlatpak.run_in_sandbox):
2363         (WebkitFlatpak._get_packages):
2364         (run_in_sandbox_if_available):
2365
2366 2020-05-04  Philippe Normand  <pnormand@igalia.com>
2367
2368         [Flatpak SDK] Query the doc portal path with DBus
2369         https://bugs.webkit.org/show_bug.cgi?id=211281
2370
2371         Reviewed by Žan Doberšek.
2372
2373         * flatpak/flatpakutils.py:
2374         (WebkitFlatpak.run_in_sandbox):
2375
2376 2020-05-04  Emilio Cobos Álvarez  <emilio@crisal.io>
2377
2378         Put lh / rlh units behind a flag until bug 211351 is sorted out.
2379         https://bugs.webkit.org/show_bug.cgi?id=211356
2380
2381         Reviewed by Antti Koivisto.
2382
2383         * DumpRenderTree/TestOptions.cpp:
2384         (TestOptions::TestOptions):
2385         * DumpRenderTree/TestOptions.h:
2386         * DumpRenderTree/mac/DumpRenderTree.mm:
2387         (setWebPreferencesForTestOptions):
2388
2389 2020-05-04  Patrick Griffis  <pgriffis@igalia.com>
2390
2391         [Flatpak SDK] Misc flatpakutils.py fixes
2392         https://bugs.webkit.org/show_bug.cgi?id=211032
2393
2394         Reviewed by Philippe Normand.
2395
2396         Pass SSLKEYLOGFILE into sandbox which is useful for debugging with Wireshark.
2397
2398         Sanitize G_MESSAGES_DEBUG env var when checking output of flatpak command.
2399
2400         Fix check for --noninteractive support.
2401
2402         Fix python 3 exception when setting up icecc mixing strings and bytes.
2403
2404         * flatpak/flatpakutils.py:
2405         (Console.warning_message):
2406         (flatpak_check_output):
2407         (check_flatpak):
2408         (FlatpakObject.flatpak):
2409         * flatpak/flatpakutils.py:
2410         (WebkitFlatpak.run_in_sandbox):
2411
2412 2020-05-03  Daniel Bates  <dabates@apple.com>
2413
2414         Attempt to fix the iOS build after r261068
2415         (https://bugs.webkit.org/show_bug.cgi?id=208281)
2416
2417         Wrap TEST()s in namespace TestWebKitAPI so as to not need to qualify IPhoneUserInterfaceSwizzler.
2418
2419         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
2420         (TEST): Deleted.
2421
2422 2020-05-03  Daniel Bates  <dabates@apple.com>
2423
2424         [iPad Simulator] TestWebKitAPI.UIWKInteractionViewProtocol.SelectPositionAtPointAfterBecomingFirstResponder is failing
2425         https://bugs.webkit.org/show_bug.cgi?id=208281
2426         <rdar://problem/59829265>
2427
2428         Reviewed by Wenson Hsieh.
2429
2430         I tried to write the test SelectPositionAtPointAfterBecomingFirstResponder for both iPad and iPhone,
2431         but it turns out that I forgot an impl detail on how form control dismissal works for iPad and fixing
2432         this would require adding more SPI/IPI. This is largely due to differences in form control UI and
2433         conventions for dismissing such UI. This test isn't testing such UI it just needs to ensure that the
2434         view is not first responder before it runs the actual test code. It uses an iPhone specific set of
2435         steps to do this. It's enough to test this functionality on iPhone.
2436
2437         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
2438         (TEST):
2439
2440 2020-05-03  Daniel Bates  <dabates@apple.com>
2441
2442         Update info.
2443
2444         * Scripts/webkitpy/common/config/contributors.json:
2445
2446 2020-05-02  ChangSeok Oh  <changseok@webkit.org>
2447
2448         Unreviewed, add myself to some watch lists.
2449
2450         * Scripts/webkitpy/common/config/watchlist:
2451
2452 2020-05-02  Daniel Bates  <dabates@apple.com>
2453
2454         Page::editableElementsInRect() should return root editable elements
2455         https://bugs.webkit.org/show_bug.cgi?id=211343
2456         <rdar://problem/60015801>
2457
2458         Reviewed by Simon Fraser.
2459
2460         Add some tests.
2461
2462         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2463         (TestWebKitAPI::TEST):
2464
2465 2020-05-02  Diego Pino Garcia  <dpino@igalia.com>
2466
2467         [GTK] Gardening, update API test expectations
2468         https://bugs.webkit.org/show_bug.cgi?id=211337
2469
2470         Unreviewed gardening.
2471
2472         Some tests became flaky under Flatpak.
2473
2474         * TestWebKitAPI/glib/TestExpectations.json:
2475
2476 2020-05-01  Tim Horton  <timothy_horton@apple.com>
2477
2478         Books sometimes ends up with blank pages, especially after adjusting font size
2479         https://bugs.webkit.org/show_bug.cgi?id=211265
2480         <rdar://problem/59898144>
2481
2482         Reviewed by Darin Adler.
2483
2484         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2485         * TestWebKitAPI/Tests/WebKitCocoa/ViewExposedRect.mm: Added.
2486         (forceRepaintCallback):
2487         (TEST):
2488         Add a test for the first problem, which would previously attempt to allocate
2489         ~90TB of tiles, spinning and exploding, and now happily just allocates a few.
2490
2491 2020-05-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2492
2493         Text manipulation should observe the value attribute of some input elements
2494         https://bugs.webkit.org/show_bug.cgi?id=211307
2495         <rdar://problem/61568528>
2496
2497         Reviewed by Darin Adler.
2498
2499         Add a new API test that covers `<input type="submit">` and `<input type="button">`.
2500
2501         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2502
2503 2020-05-01  Alex Christensen  <achristensen@webkit.org>
2504
2505         Add SPI to move localStorage to a different domain
2506         https://bugs.webkit.org/show_bug.cgi?id=209260
2507         <rdar://problem/60285683>
2508
2509         Reviewed by Brady Eidson.
2510
2511         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2512         (TEST):
2513
2514 2020-05-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2515
2516         Add a test for webkit.org/b/211311
2517         https://bugs.webkit.org/show_bug.cgi?id=211319
2518         <rdar://problem/62663459>
2519
2520         Reviewed by Tim Horton.
2521
2522         Exercise the crash fixed in r261017 with a new API test that loads a page and then uses
2523         `-[WebHTMLView attributedSubstringFromRange:]` to try and grab the contents of the page as an attributed string.
2524
2525         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2526         * TestWebKitAPI/Tests/mac/AttributedString.mm:
2527         (TestWebKitAPI::AttributedStringTest_NewlineAtEndOfDocument::didLoadURL):
2528         (TestWebKitAPI::AttributedStringTest_NewlineAtEndOfDocument::url const):
2529         (TestWebKitAPI::AttributedStringTest_NewlineAtEndOfDocument::runSyncTest):
2530         * TestWebKitAPI/Tests/mac/attributedStringNewlineAtEndOfDocument.html: Added.
2531
2532 2020-05-01  Per Arne Vollan  <pvollan@apple.com>
2533
2534         [iOS] Every running WebContent process should be granted access to frontboard services when Accessibility is enabled
2535         https://bugs.webkit.org/show_bug.cgi?id=211238
2536
2537         Reviewed by Daniel Bates.
2538
2539         * TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm:
2540         (TEST):
2541
2542 2020-05-01  Don Olmstead  <don.olmstead@sony.com>
2543
2544         [GTK] Add additional exports to support hidden visibility
2545         https://bugs.webkit.org/show_bug.cgi?id=211246
2546
2547         Reviewed by Michael Catanzaro.
2548
2549         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2550         * TestWebKitAPI/InjectedBundleMain.cpp:
2551         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2552         (webkit_web_extension_initialize_with_user_data):
2553         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
2554         (webkit_web_extension_initialize):
2555         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
2556
2557 2020-05-01  Don Olmstead  <don.olmstead@sony.com>
2558
2559         Use export macros on all platforms
2560         https://bugs.webkit.org/show_bug.cgi?id=211293
2561
2562         Reviewed by Michael Catanzaro.
2563
2564         Remove uses of USE_EXPORT_MACROS from the DumpRenderTree xcode project. This
2565         is the only xcode project that had any references to this value.
2566
2567         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2568
2569 2020-05-01  Peng Liu  <peng.liu6@apple.com>
2570
2571         A PiP window doesn’t actually dismiss after the browser navigates to a different page within the same domain
2572         https://bugs.webkit.org/show_bug.cgi?id=211257
2573
2574         Reviewed by Jer Noble.
2575
2576         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2577         * TestWebKitAPI/Tests/WebKit/AGXCompilerService.mm:
2578         (TEST):
2579         * TestWebKitAPI/Tests/WebKitCocoa/ExitPiPOnSuspendVideoElement.mm: Added.
2580         (-[ExitPiPOnSuspendVideoElementUIDelegate _webView:hasVideoInPictureInPictureDidChange:]):
2581         (TestWebKitAPI::TEST):
2582
2583 2020-05-01  Jonathan Bedard  <jbedard@apple.com>
2584
2585         results.webkit.org: Dropped connections when uploading archives shouldn't be fatal
2586         https://bugs.webkit.org/show_bug.cgi?id=211248
2587
2588         Rubber-stamped by Aakash Jain.
2589
2590         * Scripts/webkitpy/results/upload.py:
2591         (Upload.upload_archive): Dropping a connection when uploading archives shouldn't
2592         be a fatal error.
2593         * Scripts/webkitpy/results/upload_unittest.py:
2594         (UploadTest.test_archive_upload):
2595
2596 2020-05-01  Lauro Moura  <lmoura@igalia.com>
2597
2598         [Flatpak SDK] Honor XDG_RUNTIME_DIR when setting the document path
2599         https://bugs.webkit.org/show_bug.cgi?id=211277
2600
2601         Reviewed by Philippe Normand.
2602
2603         * flatpak/flatpakutils.py:
2604         (WebkitFlatpak.run_in_sandbox): Prefer using the value of
2605         $XDG_RUNTIME_DIR instead of the hardcoded path when setting the
2606         document portal path mount.
2607
2608 2020-05-01  Adrian Perez de Castro  <aperez@igalia.com>
2609
2610         [GTK] File GtkVersioning.h should be excluded from the style checker
2611         https://bugs.webkit.org/show_bug.cgi?id=211262
2612
2613         Reviewed by Carlos Garcia Campos.
2614
2615         * Scripts/webkitpy/style/checker.py: Exclude Source/WebCore/platform/gtk/GtkVersioning.h
2616         from style checks.
2617
2618 2020-04-30  Jiewen Tan  <jiewen_tan@apple.com>
2619
2620         [WebAuthn] Require user gestures for LocalAuthenticator
2621         https://bugs.webkit.org/show_bug.cgi?id=182893
2622         <rdar://problem/43357293>
2623
2624         Reviewed by Brent Fulgham.
2625
2626         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2627         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
2628         (TestWebKitAPI::TEST):
2629         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la-no-mock.html: Added.
2630         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-no-mock.html: Added.
2631
2632 2020-04-30  Alex Christensen  <achristensen@webkit.org>
2633
2634         TestWebKitAPI.WebKit.DefaultDisplayName and TestWebKitAPI.WebKit.CustomDisplayName are flaky failures
2635         https://bugs.webkit.org/show_bug.cgi?id=209993
2636         <rdar://problem/61282602>
2637
2638         Reviewed by Chris Dumez.
2639
2640         The display name for the web process is set on a low-priority background queue in WebProcess::updateProcessName()
2641         so sometimes in our test it hasn't executed yet.  If it hasn't executed yet, it will soon, so try until it succeeds.
2642
2643         * TestWebKitAPI/Tests/WebKitCocoa/DisplayName.mm:
2644         (TestWebKitAPI::checkUntilDisplayNameIs):
2645         (TestWebKitAPI::TEST):
2646
2647 2020-04-30  Jiewen Tan  <jiewen_tan@apple.com>
2648
2649         [WebAuthn] Optimize LocalAuthenticator
2650         https://bugs.webkit.org/show_bug.cgi?id=183534
2651         <rdar://problem/43357408>
2652
2653         Reviewed by Brent Fulgham.
2654
2655         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
2656         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:source:completionHandler:]):
2657         (TestWebKitAPI::TEST):
2658         Adds a new test case for the LRU.
2659
2660 2020-04-30  Kate Cheney  <katherine_cheney@apple.com>
2661
2662         Change default of "inAppBrowserPrivacyQuirks" testing toggle to use it for tests only
2663         https://bugs.webkit.org/show_bug.cgi?id=211209
2664         <rdar://problem/62619659>
2665
2666         Reviewed by Brent Fulgham.
2667
2668         Manually enable inAppBrowserPrivacyQuirks for certain tests which
2669         need script evaluation to test other aspects of In-App Browser Privacy.
2670
2671         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
2672         (TEST):
2673
2674 2020-04-30  Jonathan Bedard  <jbedard@apple.com>
2675
2676         results.webkit.org: Sort out certificates on Catalina
2677         https://bugs.webkit.org/show_bug.cgi?id=202837
2678         <rdar://problem/56177210>
2679
2680         Reviewed by Alex Christensen.
2681
2682         * Scripts/run-javascriptcore-tests:
2683         (uploadResults): Do not allow insecure requests.
2684         * Scripts/webkitpy/results/upload.py:
2685         (Upload.upload): Verify ssl certificates.
2686         (Upload.upload_archive): Ditto.
2687
2688 2020-04-30  Alex Christensen  <achristensen@webkit.org>
2689
2690         Add SPI to change a WKWebView's CORS disabling pattern after initialization
2691         https://bugs.webkit.org/show_bug.cgi?id=211211
2692         <rdar://problem/61837474>
2693
2694         Reviewed by Chris Dumez.
2695
2696         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2697
2698 2020-04-30  Alex Christensen  <achristensen@webkit.org>
2699
2700         REGRESSION: [ iOS ] http/tests/resourceLoadStatistics/standalone-web-application-exempt-from-website-data-deletion tests are flaky crashing, failing an timing out.
2701         https://bugs.webkit.org/show_bug.cgi?id=211190
2702
2703         Reviewed by Chris Dumez.
2704
2705         * WebKitTestRunner/TestController.cpp:
2706         (WTR::TestController::configureWebsiteDataStoreTemporaryDirectories):
2707         In tests that swap out the WebsiteDataStore, don't use the same paths as the other WebsiteDataStore.
2708
2709 2020-04-30  David Kilzer  <ddkilzer@apple.com>
2710
2711         REGRESSION (r176862, r210483): Leaks of BrowserWindowController in MiniBrowser/mac/AppDelegate.m
2712         <https://webkit.org/b/211243>
2713
2714         Reviewed by Tim Horton.
2715
2716         * MiniBrowser/mac/AppDelegate.m:
2717         (-[BrowserAppDelegate createBrowserWindowController:]):
2718         - Autorelease return value to fix leak.
2719         (-[BrowserAppDelegate newPrivateWindow:]):
2720         - Release controller to fix leak.
2721
2722 2020-04-30  David Kilzer  <ddkilzer@apple.com>
2723
2724         REGRESSION (r247490): Leak of MiniBrowserNSTextFinder._hideInterfaceCallback
2725         <https://webkit.org/b/211242>
2726
2727         Reviewed by Tim Horton.
2728
2729         * MiniBrowser/mac/WK2BrowserWindowController.m:
2730         (-[MiniBrowserNSTextFinder dealloc]): Add.
2731         - Release _hideInterfaceCallback to fix the leak.
2732
2733 2020-04-30  Daniel Bates  <dabates@apple.com>
2734
2735         [iOS] Implement -markedTextRange
2736         https://bugs.webkit.org/show_bug.cgi?id=211148
2737         <rdar://problem/57865890>
2738
2739         Reviewed by Wenson Hsieh.
2740
2741         Add some tests.
2742
2743         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
2744         (TestWebKitAPI::applyAhemStyle): Added.
2745         (TestWebKitAPI::TEST):
2746         * TestWebKitAPI/cocoa/TestWKWebView.h:
2747         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2748         (-[TestWKWebView synchronouslyLoadHTMLStringAndWaitUntilAllImmediateChildFramesPaint:]): Added.
2749
2750 2020-04-30  Claudio Saavedra  <csaavedra@igalia.com>
2751
2752         [GTK4] Add navigation and reload buttons to MiniBrowser
2753         https://bugs.webkit.org/show_bug.cgi?id=211231
2754
2755         Reviewed by Adrian Perez de Castro.
2756
2757         * MiniBrowser/gtk/BrowserWindow.c:
2758         (browserWindowUpdateNavigationMenu):
2759         (webViewIsLoadingChanged):
2760         (browserWindowSetupToolbarItem):
2761         (browser_window_init):
2762
2763 2020-04-30  Philippe Normand  <pnormand@igalia.com>
2764
2765         [SOUP] http/tests/media/video-accept-encoding.html fails
2766         https://bugs.webkit.org/show_bug.cgi?id=211228
2767
2768         Reviewed by Carlos Garcia Campos.
2769
2770         * Scripts/webkitpy/port/gtk.py:
2771         (GtkPort.setup_environ_for_server):
2772         * Scripts/webkitpy/port/wpe.py:
2773         (WPEPort.setup_environ_for_server):
2774
2775 2020-04-30  Andres Gonzalez  <andresg_22@apple.com>
2776
2777         Fix for crashes in accessibility/accessibility-node-memory-management.html in isolated tree mode.
2778         https://bugs.webkit.org/show_bug.cgi?id=211215
2779
2780         Reviewed by Chris Fleizach.
2781
2782         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2783         (WTR::AccessibilityController::executeOnAXThreadIfPossible):
2784         Removed the call CFRunLoopRunInMode and instead we'll use setTimeout in
2785         each of the tests that require to complete a spin of the main run loop.
2786
2787         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
2788         (WTR::AccessibilityController::accessibleElementById):
2789         Need to retain ObjectiveC object when it is retrieved from the secondary thread.
2790
2791         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2792         (WTR::AccessibilityUIElement::getChildrenWithRange): Dito as above.
2793
2794 2020-04-30  Claudio Saavedra  <csaavedra@igalia.com>
2795
2796         [GTK4] Bring back the URI entry to MiniBrowser
2797         https://bugs.webkit.org/show_bug.cgi?id=211186
2798
2799         Reviewed by Carlos Garcia Campos.
2800
2801         GTK4 support for the URI entry added, using a GtkCenterBox
2802         to start layouting a modern version of the toolbar.
2803
2804         * MiniBrowser/gtk/BrowserWindow.c:
2805         (activateUriEntryCallback):
2806         (webViewURIChanged):
2807         (updateUriEntryIcon):
2808         (faviconChanged):
2809         (insertLinkCommandCallback):
2810         (browser_window_init):
2811
2812 2020-04-29  Simon Fraser  <simon.fraser@apple.com>
2813
2814         Add a MiniBrowser option to inset the web view so it doesn't fill the window
2815         https://bugs.webkit.org/show_bug.cgi?id=211216
2816
2817         Reviewed by Tim Horton.
2818
2819         Add a menu item, Debug > Inset Web View to MiniBrowser which insets the view from
2820         the edges of the window, making it possible to debug coordinate conversion issues.
2821
2822         The state is stored in Settings, but unlike other Settings this one doesn't
2823         get populated into the Settings menu because it makes more logical sense grouped
2824         with the options to Hide and Remove the web view.
2825
2826         * MiniBrowser/mac/BrowserWindowController.h:
2827         * MiniBrowser/mac/BrowserWindowController.m:
2828         (-[BrowserWindowController toggleFullWindowWebView:]):
2829         (-[BrowserWindowController webViewFillsWindow]):
2830         (-[BrowserWindowController setWebViewFillsWindow:]):
2831         * MiniBrowser/mac/MainMenu.xib:
2832         * MiniBrowser/mac/SettingsController.h:
2833         * MiniBrowser/mac/SettingsController.m:
2834         (-[SettingsController initWithMenu:]):
2835         (-[SettingsController webViewFillsWindow]):
2836         (-[SettingsController setWebViewFillsWindow:]):
2837         * MiniBrowser/mac/WK1BrowserWindowController.m:
2838         (-[WK1BrowserWindowController validateMenuItem:]):
2839         (-[WK1BrowserWindowController didChangeSettings]):
2840         * MiniBrowser/mac/WK2BrowserWindowController.m:
2841         (-[WK2BrowserWindowController validateMenuItem:]):
2842         (-[WK2BrowserWindowController didChangeSettings]):
2843
2844 2020-04-29  Chris Dumez  <cdumez@apple.com>
2845
2846         REGRESSION(r260791) Network process fails to suspend promptly
2847         https://bugs.webkit.org/show_bug.cgi?id=211207
2848         <rdar://problem/62620454>
2849
2850         Reviewed by Alex Christensen.
2851
2852         Add API test coverage.
2853
2854         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2855         (TEST):
2856
2857 2020-04-29  Kate Cheney  <katherine_cheney@apple.com>
2858
2859         Add better handling of an uncleared bundle identifier in WebKitTestRunner
2860         https://bugs.webkit.org/show_bug.cgi?id=211195
2861         <rdar://problem/62117145>
2862
2863         Reviewed by Alexey Proskuryakov.
2864
2865         * WebKitTestRunner/TestController.cpp:
2866         (WTR::TestController::createWebViewWithOptions):
2867
2868 2020-04-29  Saam Barati  <sbarati@apple.com>
2869
2870         build-jsc should quote the value of compile flags it forwards
2871         https://bugs.webkit.org/show_bug.cgi?id=211204
2872
2873         Reviewed by Mark Lam.
2874
2875         We should quote outgoing compile flags that have an equal in them. Before,
2876         if build-jsc were invoked like:
2877         $ build-jsc --release ARCHS="x86_64 i386"
2878         It'd invoke make like:
2879         $ make release ARCHS=x86_64 i386
2880         leading us to try to build the "i386" target, which doesn't exist.
2881         
2882         This patch makes us invoke make like so:
2883         $ make release ARCHS="x86_64 i386"
2884
2885         * Scripts/build-jsc:
2886         (buildMyProject):
2887
2888 2020-04-29  Alex Christensen  <achristensen@webkit.org>
2889
2890         Add WKNavigationDelegate API shouldAllowDeprecatedTLS
2891         https://bugs.webkit.org/show_bug.cgi?id=210981
2892         <rdar://problem/61742976>
2893
2894         Reviewed by Geoffrey Garen.
2895
2896         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
2897         (-[TLSNavigationDelegate receivedShouldAllowDeprecatedTLS]):
2898         (-[TLSNavigationDelegate webView:authenticationChallenge:shouldAllowDeprecatedTLS:]):
2899         (TestWebKitAPI::TEST):
2900         (-[TLSNavigationDelegate receivedShouldAllowLegacyTLS]): Deleted.
2901         (-[TLSNavigationDelegate _webView:authenticationChallenge:shouldAllowLegacyTLS:]): Deleted.
2902         * TestWebKitAPI/config.h:
2903
2904 2020-04-29  Kate Cheney  <katherine_cheney@apple.com>
2905
2906         Refactor layout tests after updates to In-App Browser Privacy
2907         https://bugs.webkit.org/show_bug.cgi?id=211146
2908         <rdar://problem/62524127>
2909
2910         Reviewed by Brent Fulgham.
2911
2912         Removes two unused functions after updating the test cases.
2913         setInAppBrowserPrivacyEnabled is no longer needed, setting this
2914         in TestOptions is enough. getWebViewCategory is not needed because
2915         this patch deletes the only test which uses it.
2916
2917         Adds a function to clear app-bound sessions between tests now that
2918         multiple tests check for them.
2919
2920         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2921         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2922         (WTR::InjectedBundle::didReceiveMessageToPage):
2923         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2924         (WTR::TestRunner::getWebViewCategory): Deleted.
2925         (WTR::TestRunner::callDidReceiveWebViewCategoryCallback): Deleted.
2926         (WTR::TestRunner::setInAppBrowserPrivacyEnabled): Deleted.
2927         (WTR::TestRunner::callDidSetInAppBrowserPrivacyEnabledCallback): Deleted.
2928         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2929         * WebKitTestRunner/TestController.cpp:
2930         (WTR::TestController::createWebViewWithOptions):
2931         (WTR::TestController::resetStateToConsistentValues):
2932         Move the call to clear the bundle id to happen in
2933         resetStateToConsistentValues to make sure the next test can set the
2934         value if needed (otherwise results in a call to exit(1)).
2935
2936         (WTR::updateTestOptionsFromTestHeader):
2937         (WTR::TestController::clearAppBoundSession):
2938         (WTR::TestController::getWebViewCategory): Deleted.
2939         (WTR::TestController::setInAppBrowserPrivacyEnabled): Deleted.
2940         * WebKitTestRunner/TestController.h:
2941         * WebKitTestRunner/TestInvocation.cpp:
2942         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2943         (WTR::TestInvocation::didSetInAppBrowserPrivacyEnabled): Deleted.
2944         (WTR::TestInvocation::didReceiveWebViewCategory): Deleted.
2945         * WebKitTestRunner/TestInvocation.h:
2946         * WebKitTestRunner/TestOptions.h:
2947         (WTR::TestOptions::hasSameInitializationOptions const):
2948         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2949         (WTR::TestController::platformCreateWebView):
2950         App-bound WebViews now require a special configuration argument. This
2951         patch adds logic to enable that using a new TestOption.
2952         (WTR::TestController::getWebViewCategory): Deleted.
2953
2954 2020-04-29  Aakash Jain  <aakash_jain@apple.com>
2955
2956         [ews] Display flaky test names in build summary when ReRunJavaScriptCoreTests passes
2957         https://bugs.webkit.org/show_bug.cgi?id=210855
2958
2959         Reviewed by Jonathan Bedard.
2960
2961         * BuildSlaveSupport/ews-build/steps.py:
2962         (ReRunJavaScriptCoreTests.evaluateCommand): Display flaky test names in build summary.
2963         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests and removed extra TestReRunJavaScriptCoreTests class.
2964
2965 2020-04-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2966
2967         Unreviewed. Fix GTK4 build after r260891
2968
2969         * MiniBrowser/gtk/BrowserWindow.c:
2970
2971 2020-04-29  Claudio Saavedra  <csaavedra@igalia.com>
2972
2973         [GTK] Remove deprecated GTK API calls from MiniBrowser
2974         https://bugs.webkit.org/show_bug.cgi?id=211171
2975
2976         Reviewed by Carlos Garcia Campos.
2977
2978         In preparation to porting MiniBrowser to GTK4, remove
2979         all deprecated API calls. Also get rid of the --geometry
2980         command-line argument and make it a no-op.
2981
2982         * MiniBrowser/gtk/BrowserDownloadsBar.c:
2983         (browser_downloads_bar_init):
2984         (browser_downloads_bar_new):
2985         (actionButtonClicked):
2986         (browser_download_init):
2987         (downloadFinished):
2988         * MiniBrowser/gtk/BrowserSearchBar.c:
2989         (doSearch):
2990         (searchEntryMenuIconPressedCallback):
2991         (browser_search_bar_init):
2992         * MiniBrowser/gtk/BrowserSettingsDialog.c:
2993         (browser_settings_dialog_init):
2994         * MiniBrowser/gtk/BrowserTab.c:
2995         (createInfoBarQuestionMessage):
2996         (browserTabConstructed):
2997         * MiniBrowser/gtk/BrowserWindow.c:
2998         (browserWindowHistoryItemSelected):
2999         (browserWindowHistoryItemActivated):
3000         (browserWindowCreateBackForwardMenu):
3001         (browserWindowUpdateNavigationMenu):
3002         (backForwardlistChanged):
3003         (updateUriEntryIcon):
3004         (webViewIsLoadingChanged):
3005         (browserWindowSetupEditorToolbarItem):
3006         (browserWindowSetupEditorToolbar):
3007         (browserWindowSwitchTab):
3008         (browserWindowSetupToolbarItem):
3009         (browser_window_init):
3010         (browserWindowUpdateNavigationActions): Deleted.
3011         * MiniBrowser/gtk/main.c:
3012         (main):
3013
3014 2020-04-29  Adrian Perez de Castro  <aperez@igalia.com>
3015
3016         [GTK] Misplaced right click menu on web page due to deprecated gtk_menu_popup()
3017         https://bugs.webkit.org/show_bug.cgi?id=170553
3018
3019         Minor adaptations needed in the API tests to account for the differences between
3020         GtkMenuShell and GtkPopoverMenu.
3021
3022         Reviewed by Carlos Garcia Campos.
3023
3024         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
3025         (lookupWidgetsWalkChild): Added.
3026         (lookupWidgets): Added.
3027
3028 2020-04-28  Said Abou-Hallawa  <sabouhallawa@apple.com>
3029
3030         Upgrade motionmark1.1.plan to r260656
3031         https://bugs.webkit.org/show_bug.cgi?id=211143
3032
3033         Reviewed by Darin Adler.
3034
3035         r260656 includes a fix for the Multiply test.
3036
3037         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan:
3038
3039 2020-04-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3040
3041         [Text manipulation] Add a userInfo dictionary to _WKTextManipulationToken
3042         https://bugs.webkit.org/show_bug.cgi?id=211151
3043         <rdar://problem/62329534>
3044
3045         Reviewed by Darin Adler.
3046
3047         Add a new API test to check the userInfo dictionary on text manipulation tokens.
3048
3049         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
3050
3051 2020-04-28  David Kilzer  <ddkilzer@apple.com>
3052
3053         check-webkit-style should suggest CheckedSize for Checked<size_t, RecordOverflow>
3054         <https://webkit.org/b/211158>
3055
3056         Reviewed by Darin Adler.
3057
3058         * Scripts/webkitpy/style/checkers/cpp.py:
3059         (check_wtf_checked_size): Add checker.
3060         (check_style): Call check_wtf_checked_size() to check.
3061         (CppChecker): Add 'runtime/wtf_checked_size'.
3062         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3063         (WebKitStyleTest.test_wtf_checked_size): Add tests.
3064
3065 2020-04-28  Lauro Moura  <lmoura@igalia.com>
3066
3067         [GTK] update-webkitgtk-libs: TypeError: cannot use a string pattern on a bytes-like object
3068         https://bugs.webkit.org/show_bug.cgi?id=211144
3069
3070         Reviewed by Michael Catanzaro.
3071
3072         Unconditionally decode the output from the 'id' command to make it
3073         work with python3.
3074
3075         Also check if the doc directory exists before passing it to bwrap.
3076         Should avoid errors like these:
3077
3078         bwrap: Can't find source path /run/user/1000/doc: No such file or directory
3079
3080         * flatpak/flatpakutils.py:
3081         (WebkitFlatpak.run_in_sandbox):
3082
3083 2020-04-28  Kate Cheney  <katherine_cheney@apple.com>
3084
3085         Create a mechanism to add missing ITP Database tables when the schema is updated
3086         https://bugs.webkit.org/show_bug.cgi?id=211004
3087         <rdar://problem/62261187>
3088
3089         Reviewed by John Wilander.
3090
3091         Add test case which copies a database schema with a missing table into
3092         the ITP database file, then ensures the pre-seeded data is
3093         migrated over and that the schema now has all tables (including the
3094         previously missing one).
3095
3096         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3097         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3098         (TEST):
3099         * TestWebKitAPI/Tests/WebKitCocoa/missingTopFrameUniqueRedirectSameSiteStrictTableSchema.db: Added.
3100         * TestWebKitAPI/Tests/WebKitCocoa/missingTopFrameUniqueRedirectSameSiteStrictTableSchema.db-shm: Added.
3101         * TestWebKitAPI/Tests/WebKitCocoa/missingTopFrameUniqueRedirectSameSiteStrictTableSchema.db-wal: Added.
3102
3103 2020-04-28  Per Arne Vollan  <pvollan@apple.com>
3104
3105         [Cocoa] Global preferences are not accessible in the WebContent process when CFPrefs direct mode is enabled
3106         https://bugs.webkit.org/show_bug.cgi?id=211075
3107
3108         Reviewed by Brent Fulgham.
3109
3110         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm:
3111         (TEST):
3112
3113 2020-04-28  Jonathan Bedard  <jbedard@apple.com>
3114
3115         results.webkit.org: A suite running multiple times in a commit for a single configuration may overwrite upload metadata
3116         https://bugs.webkit.org/show_bug.cgi?id=211097
3117         <rdar://problem/62474538>
3118
3119         Rubber-stamped by Aakash Jain.
3120
3121         Create a new table for uploads which is indexed by both uuid and timestamp so that uploads which share
3122         a configuration and uuid but not a timestamp do not collide.
3123
3124         * resultsdbpy/resultsdbpy/model/upload_context.py:
3125         (UploadContext):
3126         (UploadContext.UploadsByConfigurationLegacy): Renamed from UploadContext.UploadsByConfiguration.
3127         (UploadContext.UploadsByConfiguration): New database table indexed by both timestamp and uuid.
3128         (UploadContext.UploadsByConfiguration.unpack):
3129         (UploadContext.__init__):
3130         (UploadContext.find_test_results): Search both versions of the UploadsByConfiguration table.
3131
3132 2020-04-28  Claudio Saavedra  <csaavedra@igalia.com>
3133
3134         [Linux] Replace --geometry with --fullscreen when using MiniBrowser for WebDriver tests
3135         https://bugs.webkit.org/show_bug.cgi?id=211123
3136
3137         Reviewed by Carlos Alberto Lopez Perez.
3138
3139         MiniBrowser's --geometry is on its way out, so use --fullscreen
3140         instead as it does the job.
3141
3142         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py:
3143         (GTKMiniBrowserDriver.launch_url):
3144
3145 2020-04-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3146
3147         [GTK4] Add support for motion events
3148         https://bugs.webkit.org/show_bug.cgi?id=211073
3149
3150         Reviewed by Adrian Perez de Castro.
3151
3152         Use the GtkOverlay in GTK4 too so that status label is shown when hovering elements.
3153
3154         * MiniBrowser/gtk/BrowserTab.c:
3155         (browserTabConstructed):
3156
3157 2020-04-28  Carlos Garcia Campos  <cgarcia@igalia.com>
3158
3159         [GTK4][Wayland] Add support for rendering web view contents
3160         https://bugs.webkit.org/show_bug.cgi?id=211021
3161
3162         Reviewed by Adrian Perez de Castro.
3163
3164         Set vertical expand of web view to TRUE.
3165
3166         * MiniBrowser/gtk/BrowserTab.c:
3167         (browserTabConstructed):
3168
3169 2020-04-27  Philippe Normand  <pnormand@igalia.com>
3170
3171         [GTK][WebInspector] platformSave broken when running within the Flatpak runtime
3172         https://bugs.webkit.org/show_bug.cgi?id=209473
3173
3174         Reviewed by Adrian Perez de Castro.
3175
3176         * flatpak/flatpakutils.py:
3177         (WebkitFlatpak.run_in_sandbox): White-list the user document
3178         folder into the sandbox. This seems needed by the file-chooser
3179         popup, somehow.
3180
3181 2020-04-27  Jonathan Bedard  <jbedard@apple.com>
3182
3183         results.webkit.org: A suite running multiple times in a commit for a single configuration may pre-empt processing
3184         https://bugs.webkit.org/show_bug.cgi?id=211094
3185         <rdar://problem/62470170>
3186
3187         Reviewed by Aakash Jain.
3188
3189         Hash collision in processing key when results only differ by upload time.
3190
3191         * resultsdbpy/resultsdbpy/model/upload_context.py:
3192         (UploadContext.process_test_results): Include upload timestamp in the hashed key.
3193
3194 2020-04-27  Zhifei Fang  <zhifei_fang@apple.com>
3195
3196         Add some debug output for run-jsc-stress-tests
3197         https://bugs.webkit.org/show_bug.cgi?id=210999
3198         <rdar://problem/61353156>
3199
3200         This will help to address where the script get stucked
3201
3202         Reviewed by Jonathan Bedard.
3203
3204         * Scripts/run-jsc-stress-tests:
3205
3206 2020-04-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3207
3208         Text manipulation should not aggregate text from different navigation anchor elements
3209         https://bugs.webkit.org/show_bug.cgi?id=211081
3210         <rdar://problem/59553658>
3211
3212         Reviewed by Megan Gardner.
3213
3214         Add a new API test, and augment an existing test.
3215
3216         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
3217
3218 2020-04-27  Jonathan Bedard  <jbedard@apple.com>
3219
3220         results.webkit.og: Add investigation endpoint
3221         https://bugs.webkit.org/show_bug.cgi?id=209562
3222
3223         Rubber-stamped by Aakash Jain.
3224
3225         Add an endpoint that allows users to list all test failures given some criteria, and
3226         provide a partial list of failures in the investigation drawer.
3227
3228         * resultsdbpy/resultsdbpy/view/static/js/commit.js:
3229         (CommitTable): Link commit to investigation endpoint.
3230         (_CommitBank.prototype.latest): Populate the CommitBank with the last x commits.
3231         (_CommitBank.prototype.commitsDuringUuid): Renamed commitsDuring.
3232         (_CommitBank.prototype. commitsDuring): Accept a range Uuids instead of a single Uuid.
3233         (_CommitBank.prototype._load): Load a single commit if the before and after uuid match.
3234         * resultsdbpy/resultsdbpy/view/static/js/common.js:
3235         (paramsToQuery): False should be added as a parameter, if provided.
3236         (percentage): Moved from investigate.js.
3237         (elapsedTime): Ditto.
3238         * resultsdbpy/resultsdbpy/view/static/js/configuration.js:
3239         (Configuration.combine): Allow configurations to be combined to a single, more general, configuration.
3240         * resultsdbpy/resultsdbpy/view/static/js/failures.js: Added.
3241         (Failures.prototype.fromEndpoint): Construct a failure object from the failures endpoint.
3242         (Failures.combine): Combine two failure objects together.
3243         (Failures):
3244         (Failures.prototype.toParams): Convert object to parameters for other results database queries.
3245         * resultsdbpy/resultsdbpy/view/static/js/investigate.js:
3246         (elapsed): Used shared time elapsed function.
3247         (percentage): Moved to common.js.
3248         (prioritizedFailures): Return a div with a truncated list of tests which failed.
3249         (resultsForData): Include some number of prioritized test failures based on how many bubbles are
3250         already displayed.
3251         (_InvestigateDrawer.prototype.expand): Dispatch failure request.
3252         (_InvestigateDrawer.prototype.dispatch): Start request to failures endpoint.
3253         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
3254         (TimelineFromEndpoint.prototype.render.onDotEnterFactory): Add link to investigation endpoint.
3255         (Legend): When search parameters change, we need to re-dispatch failure requests.
3256         * resultsdbpy/resultsdbpy/view/suite_view.py:
3257         (SuiteView._suites_for_investigation): Filter parameters for investigation endpoint.
3258         (SuiteView.investigate): Return investigation endpoint html template.
3259         * resultsdbpy/resultsdbpy/view/templates/investigate.html: Added.
3260         (willFilterExpected): Check if the query parameters indicate that expected failures are to be ignored.
3261         (commitsForRange): Return a list of commits for a uuid range.
3262         (SuiteFailuresView.constructor): Abstraction to hold the investigation data for a single suite.
3263         (SuiteFailuresView.reload): Dispatch requests to the results and failures endpoint to populate
3264         investigation data.
3265         (SuiteFailuresView.select): By default, failures for different configurations are collapsed into a single
3266         view. Allows the user to iterate through each configuration that comprises the view.
3267         (SuiteFailuresView.toString):
3268         (populateRanges): Either convert the provided arguments to a range to search for failures and results
3269         in, or use the most recent commit.
3270         (reload): Force all suite views to re-dispatch results and failures requests.
3271         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Add space between suite content and
3272         top bar.
3273         * resultsdbpy/resultsdbpy/view/view_routes.py:
3274         (ViewRoutes.__init__): Add investigate endpoint.
3275
3276 2020-04-27  Tim Horton  <timothy_horton@apple.com>
3277
3278         WebKit.ResizeReversePaginatedWebView is failing (21 pages instead of 20)
3279         https://bugs.webkit.org/show_bug.cgi?id=211001
3280         <rdar://problem/60972357>
3281
3282         Reviewed by Wenson Hsieh.
3283
3284         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
3285         * TestWebKitAPI/Tests/WebKit/lots-of-text-vertical-lr.html:
3286         Use Ahem to keep the layout more stable.
3287
3288 2020-04-27  Per Arne Vollan  <pvollan@apple.com>
3289
3290         [Cocoa] After r258891, r255119 can be reverted
3291         https://bugs.webkit.org/show_bug.cgi?id=211083
3292
3293         Unreviewed revert of r255119.
3294
3295         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3296         * TestWebKitAPI/Tests/WebKit/MimeTypes.mm: Removed.
3297
3298 2020-04-27  Daniel Bates  <dabates@apple.com>
3299
3300         Caret may be placed in the wrong spot for text input context that is a form control
3301         https://bugs.webkit.org/show_bug.cgi?id=210939
3302         <rdar://problem/61943089>
3303
3304         Reviewed by Darin Adler.
3305
3306         Add a test.
3307
3308         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3309         (TestWebKitAPI::TEST):
3310
3311 2020-04-27  Alexey Proskuryakov  <ap@apple.com>
3312
3313         Make run-safari --ios-simulator work again
3314         https://bugs.webkit.org/show_bug.cgi?id=211008
3315
3316         Reviewed by Darin Adler.
3317
3318         While at it, removed all direct uses of device.plist, and all use of Foundation.
3319
3320         * Scripts/webkitdirs.pm: Stopped exporting unused simulator related functions. New
3321         code should be using webkitpy.
3322         (simulatorDeviceFromJSON): Helper function for parsing simctl output.
3323         (iOSSimulatorDevices): Use simctl instead of reading device.plist.
3324         (createiOSSimulatorDevice): Device creation appears to be synchronous, I couldn't
3325         find any reason for waiting and retrying.
3326         (iosSimulatorApplicationsPath): This is part of the actual fix - runtime path built
3327         here was incorrect; switched to one provided by simctl.
3328         (shutDownIOSSimulatorDevice): Added an early return to avoid stderr spew.
3329         (relaunchIOSSimulator): Another part of the actual fix: open Simulator.app before booting the
3330         simulator to have it visible; CurrentDeviceUDID doesn't work.
3331         (iosSimulatorDeviceByUDID): Stop using device.plist.
3332         (runIOSWebKitAppInSimulator): Stop quitting Simulator.app, we only needed to shut down
3333         the device.
3334         (iOSSimulatorDevicesPath): Deleted.
3335         (quitIOSSimulator): Deleted.
3336
3337 2020-04-27  Daniel Bates  <dabates@apple.com>
3338
3339         Text interaction tests should ensure view is not scroll instead of looking for a zoom change
3340         https://bugs.webkit.org/show_bug.cgi?id=211056
3341
3342         Reviewed by Dean Jackson.
3343
3344         For the text interaction sub-tests, override the scroll view's delegate so as to track
3345         whether a scroll occurred or not instead of looking at the zoom scale. As the tests are
3346         written looking at the zoom scale is racy. It is simpler and deterministic to detect
3347         whether the scroll view scrolled.
3348
3349         The purpose of the text interaction sub-tests are to ensure that zooming to reveal
3350         the focused element is suppressed until the interaction completes with a call to
3351         -_didFinishTextInteractionInTextInputContext. I added some more assertions to ensure this.
3352
3353         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3354         (-[TextInteractionScrollDelegate scrollViewDidScroll:]):
3355         (TestWebKitAPI::TEST):
3356
3357 2020-04-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3358
3359         [GTK4] Make it possible to build with GTK4 without errors
3360         https://bugs.webkit.org/show_bug.cgi?id=210967
3361
3362         Reviewed by Adrian Perez de Castro.
3363
3364         * MiniBrowser/gtk/BrowserCellRendererVariant.c:
3365         * MiniBrowser/gtk/BrowserCellRendererVariant.h:
3366         * MiniBrowser/gtk/BrowserDownloadsBar.c:
3367         * MiniBrowser/gtk/BrowserDownloadsBar.h:
3368         * MiniBrowser/gtk/BrowserMain.c: Added.
3369         (browser_main):
3370         (browser_main_quit):
3371         * MiniBrowser/gtk/BrowserMain.h: Added.
3372         * MiniBrowser/gtk/BrowserSearchBar.c:
3373         * MiniBrowser/gtk/BrowserSearchBar.h:
3374         * MiniBrowser/gtk/BrowserSettingsDialog.c:
3375         * MiniBrowser/gtk/BrowserSettingsDialog.h:
3376         * MiniBrowser/gtk/BrowserTab.c:
3377         (browserTabConstructed):
3378         (browser_tab_start_search):
3379         (browser_tab_stop_search):
3380         (browser_tab_enter_fullscreen):
3381         (browser_tab_leave_fullscreen):
3382         * MiniBrowser/gtk/BrowserTab.h:
3383         * MiniBrowser/gtk/BrowserWindow.c:
3384         (webViewURIChanged):
3385         (resetEntryProgress):
3386         (webViewLoadProgressChanged):
3387         (downloadStarted):
3388         (browserWindowUpdateNavigationActions):
3389         (webViewReadyToShow):
3390         (browserWindowUpdateZoomActions):
3391         (webViewZoomLevelChanged):
3392         (updateUriEntryIcon):
3393         (webViewIsLoadingChanged):
3394         (browserWindowFinalize):
3395         (browserWindowSetupEditorToolbar):
3396         (browserWindowSwitchTab):
3397         (browser_window_init):
3398         (browser_window_class_init):
3399         (browser_window_new):
3400         (browser_window_append_view):
3401         (browser_window_set_background_color):
3402         (browser_window_get_or_create_web_view_for_automation):
3403         * MiniBrowser/gtk/CMakeLists.txt:
3404         * MiniBrowser/gtk/main.c:
3405         (main):
3406         * PlatformGTK.cmake:
3407         * Scripts/webkitpy/style/checker.py:
3408         * TestWebKitAPI/glib/PlatformGTK.cmake:
3409
3410 2020-04-27  Philippe Normand  <pnormand@igalia.com>
3411
3412         [Flatpak SDK] Regenerate toolchains only if new updates were downloaded
3413         https://bugs.webkit.org/show_bug.cgi?id=210804
3414
3415         Reviewed by Žan Doberšek.
3416
3417         The SDK toolchain archives are now regenerated only if an actual
3418         update was downloaded from the Flatpak repository. Some redundant
3419         flatpak calls were removed as well, such as the GL extension and
3420         Debug reinstalls that were happening during webkit-flatpak
3421         updates.
3422
3423         * flatpak/flatpakutils.py:
3424         (FlatpakObject.flatpak):
3425         (FlatpakRepo.__init__):
3426         (WebkitFlatpak.main):
3427         (WebkitFlatpak.setup_dev_env):
3428
3429 2020-04-27  Philippe Normand  <pnormand@igalia.com>
3430
3431         unable to build from tot - linux - flatpakutils.py - TypeError: not enough arguments for format string
3432         https://bugs.webkit.org/show_bug.cgi?id=210941
3433
3434         Reviewed by Žan Doberšek.
3435
3436         * flatpak/flatpakutils.py:
3437         (check_flatpak): Fix error message formating.
3438
3439 2020-04-26  Yoshiaki Jitsukawa  <yoshiaki.jitsukawa@sony.com>
3440
3441         [PlayStation] Enable TestWTF and TestWebCore
3442         https://bugs.webkit.org/show_bug.cgi?id=208849
3443
3444         Reviewed by Don Olmstead.
3445
3446         * TestWebKitAPI/PlatformPlayStation.cmake:
3447         * TestWebKitAPI/playstation/main.cpp: Added.
3448         (main): Load runtime libraries.
3449
3450 2020-04-26  Yusuke Suzuki  <ysuzuki@apple.com>
3451
3452         Warn when NeverDestroyed<Lock> is used
3453         https://bugs.webkit.org/show_bug.cgi?id=211054
3454
3455         Reviewed by Darin Adler.
3456
3457         WTF::Lock and WTF::Condition are designed to be constant-initialize compliant. So NeverDestroyed<> for these types are not necessary,
3458         or rather, introducing race condition issue while `static Lock` doesn't have that issue. This patch adds lint rules which prevent
3459         us from using `NeverDestroyed<Lock>` and `LazyNeverDestroyed<Lock>`.
3460
3461         * Scripts/webkitpy/style/checkers/cpp.py:
3462         (check_wtf_never_destroyed):
3463         (check_style):
3464         (CppChecker):
3465         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3466         (WebKitStyleTest.test_wtf_never_destroyed):
3467
3468 2020-04-25  Darin Adler  <darin@apple.com>
3469
3470         [Cocoa] Deal with another round of Xcode upgrade checks
3471         https://bugs.webkit.org/show_bug.cgi?id=211027
3472
3473         Reviewed by Alexey Proskuryakov.
3474
3475         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Bump the upgrade check version.
3476
3477         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Bump the upgrade check version.
3478         Add a harmless base localization; this project contains nothing localized. Also let the
3479         script sort the project.
3480
3481         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Bump the upgrade check version.
3482         Add a harmless base localization; this project contains nothing localized. Also let the
3483         script sort the project.
3484
3485 2020-04-25  Darin Adler  <darin@apple.com>
3486
3487         Move URL to use StringView when returning substrings of the URL
3488         https://bugs.webkit.org/show_bug.cgi?id=210431
3489
3490         Reviewed by Anders Carlsson.
3491
3492         * TestWebKitAPI/Tests/WTF/URL.cpp: Removed the test for
3493         equalIgnoringQueryAndFragment since we removed that function.
3494         Updated for rename of URL::password from URL::pass.
3495         Updated arguments to isMatchingDomain to pass literals that can be converted
3496         to StringView rather than ASCIILiteral, which StringView doesn't yet support.
3497
3498         * TestWebKitAPI/Tests/WebCore/URLParserTextEncoding.cpp:
3499         (TestWebKitAPI::checkURL): Updated for rename of URL::password from URL::pass.
3500         (TestWebKitAPI::checkRelativeURL): Ditto.
3501         (TestWebKitAPI::checkURLDifferences): Ditto.
3502         (TestWebKitAPI::checkRelativeURLDifferences): Ditto.
3503         (TestWebKitAPI::testUserPassword): Ditto.
3504
3505 2020-04-25  Diego Pino Garcia  <dpino@igalia.com>
3506
3507         [Flatpak SDK][EWS] Install dependencies step needs configuration as argument
3508         https://bugs.webkit.org/show_bug.cgi?id=210913
3509
3510         Follow-up on r260560. The same change is needed for EWS bots.
3511
3512         Reviewed by Philippe Normand.
3513
3514         * BuildSlaveSupport/ews-build/steps.py:
3515         (InstallGtkDependencies): Pass 'configuration' value (Release, Debug).
3516         (InstallWpeDependencies): Pass 'configuration' value (Release, Debug).
3517
3518 2020-04-24  Alex Christensen  <achristensen@webkit.org>
3519
3520         REGRESSION(260485) Payment requests don't do anything
3521         https://bugs.webkit.org/show_bug.cgi?id=210997
3522
3523         Reviewed by Darin Adler.
3524
3525         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
3526         (TestWebKitAPI::TEST):
3527
3528 2020-04-24  Wenson Hsieh  <wenson_hsieh@apple.com>
3529
3530         Make some more adjustments to TextManipulationController's paragraph boundary heuristic
3531         https://bugs.webkit.org/show_bug.cgi?id=210993
3532         <rdar://problem/61571299>
3533
3534         Reviewed by Tim Horton.
3535
3536         Add a new API test with buttons and links styled with `display: inline-block;`. Additionally, rebaseline an
3537         existing API test that exercises inline-block list items.
3538
3539         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
3540
3541 2020-04-24  Chris Dumez  <cdumez@apple.com>
3542
3543         [iOS] Always run WKTR's WKWebViews at foreground priority
3544         https://bugs.webkit.org/show_bug.cgi?id=210991
3545
3546         Reviewed by Keith Miller.
3547
3548         Always run WKTR's WKWebViews at foreground priority. This makes sure that they don't suspend and
3549         run at foreground priority on iOS, even if those views are not visible on screen.
3550         This is an issue to address flakiness on the bots.
3551
3552         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3553         (WTR::initializeWebViewConfiguration):
3554
3555 2020-04-24  Kate Cheney  <katherine_cheney@apple.com>
3556
3557         Removing website data for a domain should delete corresponding ITP entry
3558         https://bugs.webkit.org/show_bug.cgi?id=210864
3559         <rdar://problem/59473193>
3560
3561         Reviewed by John Wilander.
3562
3563         Created 2 new APIs for testing. One to mimic clearing website data
3564         for a domain, and one to check if the domain exists in the database
3565         after a deletion was requested.
3566
3567         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3568         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3569         (WTR::TestRunner::doesStatisticsDomainIDExistInDatabase):
3570         (WTR::TestRunner::domainIDExistsInDatabase): Deleted.
3571         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3572         * WebKitTestRunner/TestController.cpp:
3573         (WTR::TestController::doesStatisticsDomainIDExistInDatabase):
3574         (WTR::TestController::domainIDExistsInDatabase): Deleted.
3575         * WebKitTestRunner/TestController.h:
3576         * WebKitTestRunner/TestInvocation.cpp:
3577         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3578
3579 2020-04-24  Antoine Quint  <graouts@apple.com>
3580
3581         Update the css/css-animations WPT tests
3582         https://bugs.webkit.org/show_bug.cgi?id=210964
3583
3584         Reviewed by Dean Jackson.
3585
3586         Turn on the CSSCustomPropertiesAndValues experimental feature which a new test relies on.
3587
3588         * DumpRenderTree/mac/DumpRenderTree.mm:
3589         (enableExperimentalFeatures):
3590         * DumpRenderTree/win/DumpRenderTree.cpp:
3591         (enableExperimentalFeatures):
3592
3593 2020-04-24  David Kilzer  <ddkilzer@apple.com>
3594
3595         check-webkit-style should recognize *Internal.h and *Private.h as primary headers
3596         <https://webkit.org/b/210979>
3597
3598         Reviewed by Darin Adler.
3599
3600         * Scripts/webkitpy/style/checkers/cpp.py:
3601         (_classify_include): If a header has an "Internal.h" or a
3602         "Private.h" suffix with the same base name as the source file,
3603         consider it a primary header--the header that comes after
3604         "config.h".
3605         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3606         (OrderOfIncludesTest.test_classify_include): Add tests.
3607
3608 2020-04-24  Alex Christensen  <achristensen@webkit.org>
3609
3610         SPI clients using fastServerTrustEvaluationEnabled need SPI to inform them of modern TLS negotiation
3611         https://bugs.webkit.org/show_bug.cgi?id=210533
3612
3613         Reviewed by Brady Eidson.
3614
3615         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
3616         (-[TLSNavigationDelegate waitForDidNegotiateModernTLS]):
3617         (-[TLSNavigationDelegate _webView:didNegotiateModernTLS:]):
3618         (TestWebKitAPI::TEST):
3619
3620 2020-04-24  Brian Burg  <bburg@apple.com>
3621
3622         webkitpy: update autoinstalled mozprocess dependency to 1.1.0 (adds python3 support)
3623         https://bugs.webkit.org/show_bug.cgi?id=210220
3624         <rdar://problem/58881483>
3625
3626         Reviewed by Anders Carlsson.
3627
3628         * Scripts/webkitpy/thirdparty/__init__.py:
3629         (AutoinstallImportHook._install_mozprocess):
3630
3631 2020-04-24  Philippe Normand  <pnormand@igalia.com>
3632
3633         [GTK][WPE] White-list more GStreamer environment variables in webkitpy
3634         https://bugs.webkit.org/show_bug.cgi?id=210854
3635         <rdar://problem/62238305>
3636
3637         Reviewed by Carlos Alberto Lopez Perez.
3638
3639         Extra variables need to be white-listed when the webkitpy tooling