4fb821292b0a9744c33a2221efc0918bb06e4fd4
[WebKit-https.git] / Tools / ChangeLog
1 2016-01-27  Jason Marcell  <jmarcell@apple.com>
2
3         Fix bugs caused by incorrect usage of "branch" vs. "branchName".
4         https://bugs.webkit.org/show_bug.cgi?id=153330
5
6         Reviewed by Daniel Bates.
7
8         In an earlier patch we started using the name "branch" to indicate a branch object, whereas
9         "branchName" implies that the variable or property in question is simply a string. We fixed some
10         inconsistencies regarding this issue in 152982 but further bugs and inconsistencies were recently
11         spotted in BuildbotQueueView.js.
12
13         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
14         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Change branchName to branch in method signature.
15         Changed branchName to branch.name in call to commitsOnBranch.
16         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Change branch.name to branch in call to
17         _popoverLinesForCommitRange.
18         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Changed context.branchName to context.branch.name.
19         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Changed branch.name to branch.
20         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests to verify
21         fix.
22
23 2016-01-27  Ryosuke Niwa  <rniwa@webkit.org>
24
25         Add API to access closed shadowRoot in InjectedBundle
26         https://bugs.webkit.org/show_bug.cgi?id=153533
27
28         Reviewed by Antti Koivisto.
29
30         Added WebKit2 API test for WKBundleScriptWorldMakeAllShadowRootsOpen.
31
32         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
33         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp: Added.
34         (TestWebKitAPI::runJavaScriptAlert):
35         (TestWebKitAPI::TEST):
36         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakrAllShadowRootOpen_Bundle.cpp: Added.
37         (TestWebKitAPI::InjectedBundleMakrAllShadowRootOpenTest::InjectedBundleMakrAllShadowRootOpenTest):
38         (TestWebKitAPI::InjectedBundleMakrAllShadowRootOpenTest::initialize):
39
40 2016-01-27  Jason Marcell  <jmarcell@apple.com>
41
42         Refactor logic for parsing Trac revisions into its own function and add logic for parsing git hashes.
43         https://bugs.webkit.org/show_bug.cgi?id=153332
44
45         Reviewed by Alexey Proskuryakov.
46
47         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
48         (Trac.prototype._xmlTimelineURL): Uses new function.
49         (Trac.prototype._parseRevisionFromURL): Added. Pulled out logic for parsing revisions from a URL. Also added
50         logic for parsing git hashes.
51         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests for
52         Trac._parseRevisionFromURL.
53
54 2016-01-27  Alexey Proskuryakov  <ap@apple.com>
55
56         Remove Mavericks from the flakiness dashboard
57         https://bugs.webkit.org/show_bug.cgi?id=153521
58
59         Reviewed by Dan Bernstein.
60
61         * TestResultServer/static-dashboards/builders.jsonp:
62         * TestResultServer/static-dashboards/flakiness_dashboard.js:
63
64 2016-01-27  Alexey Proskuryakov  <ap@apple.com>
65
66         Remove ENABLE_CURRENTSRC
67         https://bugs.webkit.org/show_bug.cgi?id=153545
68
69         Reviewed by Simon Fraser.
70
71         * Scripts/webkitperl/FeatureList.pm:
72
73 2016-01-26  Jason Marcell  <jmarcell@apple.com>
74
75         Sort incoming commits via date instead of revision number.
76         https://bugs.webkit.org/show_bug.cgi?id=153467
77
78         Reviewed by Alexey Proskuryakov.
79
80         Future Trac instances may use Git or other revision control systems where we cannnot rely on the revision number
81         for sorting revisions. Instead we use the commit date to sort revisions chronologically.
82
83         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
84         (Trac.prototype._loaded): Sort via date instead of revision number.
85         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
86         (MockTrac): Fix up the mock data to look more like real-world data.
87         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-trac-rss.xml: Added.
88         Fake RSS feed that adds three more commits.
89         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit tests to test
90         Trac._loaded().
91
92 2016-01-26  I-Ting Liu  <iting_liu@apple.com>
93
94         Add a test for WebKit::stringMatchesWildcardString.
95         https://bugs.webkit.org/show_bug.cgi?id=153090
96
97         Reviewed by Darin Adler.
98
99         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
100         Add the file to the project.
101
102         * TestWebKitAPI/Tests/WebKit2/mac/StringUtilities.mm: Added.
103         (TestWebKitAPI::TEST):
104         Test that a string matches another string that may contain wildcard characters.
105
106 2016-01-26  Konstantin Tokarev  <annulen@yandex.ru>
107
108         [webkitdirs] Removed check for bison, gperf, and flex.
109         https://bugs.webkit.org/show_bug.cgi?id=153496
110
111         Reviewed by Alex Christensen.
112
113         This prerequisites are checked in WebKitCommon.cmake and don't
114         have to be in $PATH.
115
116         * Scripts/webkitdirs.pm:
117         (checkRequiredSystemConfig):
118
119 2016-01-26  Konstantin Tokarev  <annulen@yandex.ru>
120
121         [webkitdirs] isCMakeBuild should be true by default
122         https://bugs.webkit.org/show_bug.cgi?id=153497
123
124         Reviewed by Michael Catanzaro.
125
126         * Scripts/webkitdirs.pm:
127         (isCMakeBuild):
128
129 2016-01-26  Daniel Bates  <dabates@apple.com>
130
131         Add WebKitSystemInterface for iOS 9.2
132         https://bugs.webkit.org/show_bug.cgi?id=153355
133
134         Rubber-stamped by David Kilzer.
135
136         * Scripts/copy-webkitlibraries-to-product-directory:
137
138 2016-01-26  Daniel Bates  <dabates@apple.com>
139
140         WebKitTestRunner: Credential cache is not cleared between tests
141         https://bugs.webkit.org/show_bug.cgi?id=153407
142         <rdar://problem/24280834>
143
144         Reviewed by Alexey Proskuryakov.
145
146         * WebKitTestRunner/TestController.cpp:
147         (WTR::TestController::resetStateToConsistentValues): Call WKContextClearCachedCredentials()
148         to clear cached credentials.
149
150 2016-01-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
151
152         kill-old-processes: allow to specify on the environment of the bot a list of process that should be killed.
153         https://bugs.webkit.org/show_bug.cgi?id=153483
154
155         Reviewed by Csaba Osztrogonác.
156
157         * BuildSlaveSupport/kill-old-processes:
158         (main): Allow to specify extra tasks to kill via the environment variable WEBKITBOT_TASKSTOKILL
159
160 2016-01-25  Simon Fraser  <simon.fraser@apple.com>
161
162         Give the layout test results file a <title> showing the date and time the tests were run
163         https://bugs.webkit.org/show_bug.cgi?id=153187
164
165         Reviewed by Darin Adler.
166         
167         Include a 'date' property in the JSON with the date and time the tests completed.
168
169         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
170         (summarize_results):
171
172 2016-01-25  Commit Queue  <commit-queue@webkit.org>
173
174         Unreviewed, rolling out r195543.
175         https://bugs.webkit.org/show_bug.cgi?id=153451
176
177         regressed performance of test bots by ~6% (Requested by dydz
178         on #webkit).
179
180         Reverted changeset:
181
182         "WebKitTestRunner: Credential cache is not cleared between
183         tests"
184         https://bugs.webkit.org/show_bug.cgi?id=153407
185         http://trac.webkit.org/changeset/195543
186
187 2016-01-25  Aakash Jain  <aakash_jain@apple.com>
188
189         Failing to upload to flakiness dashboard should not be a hard error
190         https://bugs.webkit.org/show_bug.cgi?id=153444
191         <rdar://problem/22146294>
192
193         Reviewed by Alexey Proskuryakov.
194
195         * Scripts/webkitpy/layout_tests/controllers/manager.py:
196         (Manager._upload_json_files): If JSON file is not generated, do not try to upload it.
197
198 2016-01-25  Daniel Bates  <dabates@apple.com>
199
200         WebKitTestRunner: Credential cache is not cleared between tests
201         https://bugs.webkit.org/show_bug.cgi?id=153407
202         <rdar://problem/24280834>
203
204         Reviewed by Brady Eidson.
205
206         * WebKitTestRunner/TestController.cpp:
207         (WTR::TestController::resetStateToConsistentValues): Reset testing network session
208         to clear cached credentials.
209
210 2016-01-24  Dan Bernstein  <mitz@apple.com>
211
212         Added project.xcworkspace and xcuserdata to this project’s svn:ignore.
213
214         * LayoutTestRelay/LayoutTestRelay.xcodeproj: Added property svn:ignore.
215
216 2016-01-22  Enrica Casucci  <enrica@apple.com>
217
218         Unreviewed build fix after http://trac.webkit.org/changeset/195474.
219
220         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
221         (WTR::TestController::platformCreateWebView):
222
223 2016-01-22  Tim Horton  <timothy_horton@apple.com>
224
225         Add a test for iOS arrow-key repeat
226         https://bugs.webkit.org/show_bug.cgi?id=152857
227         <rdar://problem/24017380>
228
229         Reviewed by Darin Adler.
230
231         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
232         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
233         (WTR::UIScriptController::keyUpUsingHardwareKeyboard):
234         (WTR::UIScriptController::keyDownUsingHardwareKeyboard):
235         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
236         * WebKitTestRunner/ios/HIDEventGenerator.h:
237         * WebKitTestRunner/ios/HIDEventGenerator.mm:
238         (-[HIDEventGenerator keyPress:completionBlock:]):
239         (-[HIDEventGenerator keyDown:completionBlock:]):
240         (-[HIDEventGenerator keyUp:completionBlock:]):
241         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
242         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
243         (WTR::UIScriptController::keyDownUsingHardwareKeyboard):
244         (WTR::UIScriptController::keyUpUsingHardwareKeyboard):
245         Make it possible to independently send keyUp/keyDown, instead of just paired.
246
247 2016-01-22  Tim Horton  <timothy_horton@apple.com>
248
249         Reproducible "Unhanded web process message 'WebUserContentController:AddUserScripts'" and friends
250         https://bugs.webkit.org/show_bug.cgi?id=153193
251         <rdar://problem/24222034>
252
253         Reviewed by Darin Adler.
254
255         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
256         (webViewForScriptMessageHandlerMultipleHandlerRemovalTest):
257         (TEST):
258         Add a test that exhibits the problems we're fixing here.
259         Before, it would both log and assert in debug, and crash in release.
260         Now it runs happily to completion.
261
262 2016-01-22  Enrica Casucci  <enrica@apple.com>
263
264         Add support for testing data detection.
265         https://bugs.webkit.org/show_bug.cgi?id=153360
266
267         Reviewed by Tim Horton.
268
269         Adding a new testing option (useDataDetection) to turn on
270         data detection when running the a test.
271
272         * WebKitTestRunner/TestController.cpp:
273         (WTR::updateTestOptionsFromTestHeader):
274         * WebKitTestRunner/TestOptions.h:
275         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
276         (WTR::TestController::platformCreateWebView):
277
278 2016-01-21  Simon Fraser  <simon.fraser@apple.com>
279
280         Fix the lldb WebCoreLayoutUnitProvider to not dynamically look up the LayoutUnit denominator
281         https://bugs.webkit.org/show_bug.cgi?id=153334
282
283         Reviewed by Zalan Bujtas.
284         
285         Evaluating expressions in the LayoutUnit summary provider seems to cause
286         re-entrancy problems in lldb python bindings, so just hardcode the LayoutUnit
287         denominator to 64.
288
289         * lldb/lldb_webkit.py:
290         (WebCoreLayoutUnitProvider.to_string):
291
292 2016-01-21  Filip Pizlo  <fpizlo@apple.com>
293
294         display-profiler-output should be able to display code blocks sorted by machine counts
295         https://bugs.webkit.org/show_bug.cgi?id=153298
296
297         Reviewed by Oliver Hunt.
298
299         * Scripts/display-profiler-output:
300
301 2016-01-21  Julien Isorce  <j.isorce@samsung.com>
302
303         Ensure to use compatible liborc version with wanted gstreamer version
304         https://bugs.webkit.org/show_bug.cgi?id=153276
305
306         For example gst-plugins-base-1.4.4 fails to build with liborc-0.4.24.
307         The user may have a very recent liborc installed on his system.
308
309         Reviewed by Philippe Normand.
310
311         * efl/jhbuild.modules: add liborc-0.4.17 and make it a gst dependency.
312         * gtk/jhbuild.modules: add liborc-0.4.17 and make it a gst depencendy.
313
314 2016-01-21  Nan Wang  <n_wang@apple.com>
315
316         AX: [IOS] Implement next/previous text marker functions using TextIterator
317         https://bugs.webkit.org/show_bug.cgi?id=153292
318         <rdar://problem/24268243>
319
320         Reviewed by Chris Fleizach.
321
322         Made text marker tests available on iOS.
323
324         * DumpRenderTree/AccessibilityTextMarker.h:
325         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
326         * DumpRenderTree/ios/AccessibilityTextMarkerIOS.mm: Added.
327         (AccessibilityTextMarker::AccessibilityTextMarker):
328         (AccessibilityTextMarker::~AccessibilityTextMarker):
329         (AccessibilityTextMarker::isEqual):
330         (AccessibilityTextMarker::platformTextMarker):
331         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
332         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
333         (AccessibilityTextMarkerRange::isEqual):
334         (AccessibilityTextMarkerRange::platformTextMarkerRange):
335         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
336         (AccessibilityUIElement::pathDescription):
337         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
338         (AccessibilityUIElement::textMarkerRangeForElement):
339         (AccessibilityUIElement::selectedTextMarkerRange):
340         (AccessibilityUIElement::resetSelectedTextMarkerRange):
341         (AccessibilityUIElement::textMarkerRangeLength):
342         (AccessibilityUIElement::textMarkerRangeForMarkers):
343         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
344         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
345         (AccessibilityUIElement::accessibilityElementForTextMarker):
346         (AccessibilityUIElement::endTextMarkerForBounds):
347         (AccessibilityUIElement::startTextMarkerForBounds):
348         (AccessibilityUIElement::textMarkerForPoint):
349         (AccessibilityUIElement::previousTextMarker):
350         (AccessibilityUIElement::nextTextMarker):
351         (AccessibilityUIElement::stringForTextMarkerRange):
352         (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
353         (AccessibilityUIElement::indexForTextMarker):
354         (AccessibilityUIElement::isTextMarkerValid):
355         (AccessibilityUIElement::textMarkerForIndex):
356         (AccessibilityUIElement::startTextMarker):
357         (AccessibilityUIElement::endTextMarker):
358         (AccessibilityUIElement::setSelectedVisibleTextRange):
359         (AccessibilityUIElement::getLinkedUIElements):
360         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
361         (AccessibilityTextMarkerRange::platformTextMarkerRange):
362         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
363         (AccessibilityUIElement::removeSelection):
364         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
365         (AccessibilityUIElement::setSelectedVisibleTextRange):
366         (AccessibilityUIElement::supportedActions):
367         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
368         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
369         (WTR::AccessibilityUIElement::textMarkerRangeLength):
370         (WTR::AccessibilityUIElement::previousTextMarker):
371         (WTR::AccessibilityUIElement::nextTextMarker):
372         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
373         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
374         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
375         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
376         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
377         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
378         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
379
380 2016-01-20  Filip Pizlo  <fpizlo@apple.com>
381
382         Unreviewed, revert accidental unreviewed commit.
383
384         * Scripts/display-profiler-output:
385
386 2016-01-20  Jason Marcell  <jmarcell@apple.com>
387
388         Refactor compareIterations to remove duplicate code.
389         https://bugs.webkit.org/show_bug.cgi?id=152913
390
391         Reviewed by Daniel Bates.
392
393         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
394         (BuildbotQueue.prototype.compareIterations): Refactored to remove duplicate code.
395         (BuildbotQueue.prototype.sortIterations): Add binding to call to compareIterations.
396         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests in order to ensure
397         the same behavior before and after refactor.
398
399 2016-01-20  Dana Burkart  <dburkart@apple.com>
400
401         Botwatcher's dashboard should show an 'X' when the build is broken
402         https://bugs.webkit.org/show_bug.cgi?id=152507
403
404         Reviewed by David Kilzer.
405
406         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
407         (BuildbotStaticAnalyzerQueueView.prototype.appendStaticAnalyzerQueueStatus):
408         (BuildbotStaticAnalyzerQueueView.prototype.update):
409
410 2016-01-19  Jason Marcell  <jmarcell@apple.com>
411
412         Remove assertion from revisionContentForIteration that is causing errors on the dashboard.
413         https://bugs.webkit.org/show_bug.cgi?id=153262
414
415         Reviewed by Alexey Proskuryakov.
416
417         Occasionaly some buildbot iterations will not have their "got_revisions" property populated. In
418         such cases this revisionContentForIteration method does not have any content to return, thus the
419         assertion fails.
420
421         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
422         (BuildbotQueueView.prototype.revisionContentForIteration): Removed assertion that was causing errors.
423
424 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
425
426         [GTK] Runtime critical warnings when loading a URL after a session restore
427         https://bugs.webkit.org/show_bug.cgi?id=153233
428
429         Reviewed by Michael Catanzaro.
430
431         Add new test case.
432
433         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
434         (viewLoadChanged):
435         (testWebKitWebViewNavigationAfterSessionRestore):
436         (beforeAll):
437
438 2016-01-19  Michael Catanzaro  <mcatanzaro@igalia.com>
439
440         [GTK] Remove jhbuild-optional.modules
441         https://bugs.webkit.org/show_bug.cgi?id=152964
442
443         Reviewed by Alex Christensen.
444
445         * gtk/jhbuild-optional.modules: Removed.
446         * gtk/jhbuild.modules:
447
448 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
449
450         [GTK] Add support to load/save session in MiniBrowser
451         https://bugs.webkit.org/show_bug.cgi?id=153201
452
453         Reviewed by Michael Catanzaro.
454
455         It makes it easier to test the new WebView session API.
456
457         * MiniBrowser/gtk/BrowserWindow.c:
458         (browserWindowFinalize): Free the session file path.
459         (browserWindowSaveSession): Save the current WebView session if
460         there's a session file path.
461         (browserWindowDeleteEvent): Call browserWindowSaveSession().
462         (browser_window_load_session): Try to load the session from the
463         given file path, otherwise fall back to homepage and keep the
464         session file to save the session on window close.
465         * MiniBrowser/gtk/BrowserWindow.h:
466         * MiniBrowser/gtk/main.c:
467         (createBrowserWindow): Pass the given session file path when
468         shouldLoadSession is TRUE.
469         (main): Only allow to restore/save session when MiniBrowser is
470         launched without URL arguments.
471
472 2016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
473
474         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/geolocation-permission-requests after r195075.
475
476         Geolocation is no longer allowed for unique origins after r195075.
477
478         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
479         (testWebViewGeolocationPermissionRequests):
480
481 2016-01-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
482
483         [GTK][EFL] Layout tests abort with PulseAudioSanitizer instance has no attribute '_pa_module_index' when the build is not ready.
484         https://bugs.webkit.org/show_bug.cgi?id=153216
485
486         Reviewed by Michael Catanzaro.
487
488         * Scripts/webkitpy/port/pulseaudio_sanitizer.py:
489         (PulseAudioSanitizer.__init__): initialize _pa_module_index in the constructor.
490
491 2016-01-18  Nan Wang  <n_wang@apple.com>
492
493         AX: [Mac] Implement next/previous text marker functions using TextIterator
494         https://bugs.webkit.org/show_bug.cgi?id=152728
495
496         Reviewed by Chris Fleizach.
497
498         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
499         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
500
501 2016-01-18  Csaba Osztrogonác  <ossy@webkit.org>
502
503         [cmake] Add testair to the build system
504         https://bugs.webkit.org/show_bug.cgi?id=153126
505
506         Reviewed by Michael Catanzaro.
507
508         * Scripts/build-jsc:
509
510 2016-01-16  Myles C. Maxfield  <mmaxfield@apple.com>
511
512         Remove TextRun::allowsRoundingHacks()
513         https://bugs.webkit.org/show_bug.cgi?id=153185
514
515         Reviewed by Simon Fraser.
516
517         * DumpRenderTree/mac/DumpRenderTree.mm:
518         (resetWebViewToConsistentStateBeforeTesting): Deleted.
519
520 2016-01-15  Konstantin Tokarev  <annulen@yandex.ru>
521
522         [webkitdirs] Avoid list form of open because it broke WinCairo
523         https://bugs.webkit.org/show_bug.cgi?id=153106
524
525         Reviewed by Alex Christensen.
526
527         * Scripts/webkitdirs.pm:
528         (determineArchitecture):
529
530 2016-01-15  Simon Fraser  <simon.fraser@apple.com>
531
532         Add kdebug_trace signposts for a few WebCore operations
533         https://bugs.webkit.org/show_bug.cgi?id=153136
534         rdar://problem/24208487
535
536         Reviewed by Sam Weinig.
537         
538         Plist used by kdebug_trace() viewing tools.
539
540         * Tracing/SystemTracePoints.plist: Added.
541
542 2016-01-14  Konstantin Tokarev  <annulen@yandex.ru>
543
544         [webkitdirs] Replaced grep invocation with perl code
545         https://bugs.webkit.org/show_bug.cgi?id=153106
546
547         Reviewed by Alex Christensen.
548
549         * Scripts/webkitdirs.pm:
550         (determineArchitecture):
551
552 2016-01-14  Brian Burg  <bburg@apple.com>
553
554         prepare-changelog does not read paths containing spaces properly
555         https://bugs.webkit.org/show_bug.cgi?id=137982
556
557         Reviewed by Joseph Pecoraro.
558
559         Escape whitespace in filenames before passing the file path to other functions.
560
561         * Scripts/prepare-ChangeLog:
562         (generateFunctionLists): Use the more explicit 3-argument form of 'open'.
563
564 2016-01-14  Jason Marcell  <jmarcell@apple.com>
565
566         Standardize the usage of "branch" vs. "branchName".
567         https://bugs.webkit.org/show_bug.cgi?id=152982
568
569         Reviewed by Daniel Bates.
570
571         In an earlier patch we started using the name "branch" to indicate a branch object, whereas
572         "branchName" implies that the variable or property in question is simply a string.
573
574         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
575         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Change branch to branchName.
576         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Change branch to branch.name.
577         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Change branch to branchName.
578         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
579         (Trac.prototype.commitsOnBranch): Change branch to branchName.
580         (Trac.prototype._convertCommitInfoElementToObject): Ditto.
581         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:
582         (MockTrac): Ditto.
583
584 2016-01-14  Jason Marcell  <jmarcell@apple.com>
585
586         Add a unit test to test BuildbotQueueView._appendPendingRevisionCount.
587         https://bugs.webkit.org/show_bug.cgi?id=152910
588
589         Reviewed by Daniel Bates.
590
591         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueue.js: Added.
592         (MockBuildbotQueue): Added. Mock BuildbotQueue object that doesn't need to talk to an actual Buildbot server.
593         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js: Added.
594         (MockBuildbotQueueView): Added. Mock BuildbotQueueView object that returns a pre-specified _latestProductiveIteration without
595         the need to talk to a real Buildbot server.
596         (MockBuildbotQueueView.prototype._latestProductiveIteration): Added. Returns a pre-specified _latestProductiveIteration
597         without the need to talk to a real Buildbot server.
598         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js: Added.
599         (MockTrac): Added. Mock Trac constructor that has pre-populated "recordedCommits" and does not need to talk to a real Trac
600         server.
601         (MockTrac.prototype.get oldestRecordedRevisionNumber): Added. Returns a pre-specified revision.
602         (MockTrac.prototype.get latestRecordedRevisionNumber): Ditto.
603         (MockTrac.prototype.loadMoreHistoricalData): Added. Overrides the real loadMoreHistoricalData so that we don't waste time
604         trying to talk to Trac.
605         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Added. Web page container for
606         QUnit unit tests.
607         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added. QUnit unit tests.
608
609 2016-01-14  Nikos Andronikos  <nikos.andronikos-webkit@cisra.canon.com.au>
610
611         [CMake][GTK] CMake Error: Could not create named generator Eclipse CDT4 - Ninja
612         https://bugs.webkit.org/show_bug.cgi?id=132599
613
614         Reviewed by Michael Catanzaro.
615
616         Check if cmake Ninja generators are installed.
617
618         * Scripts/webkitdirs.pm:
619         (canUseNinjaGenerator):
620         (canUseEclipseNinjaGenerator):
621         (generateBuildSystemFromCMakeProject):
622         (canUseEclipse): Deleted.
623
624 2016-01-13  Myles C. Maxfield  <mmaxfield@apple.com>
625
626         [Cocoa] Testing with font family name "System Font" is unused
627         https://bugs.webkit.org/show_bug.cgi?id=153073
628         <rdar://problem/24091683>
629
630         Reviewed by Brent Fulgham.
631
632         * DumpRenderTree/mac/DumpRenderTree.mm:
633         (allowedFontFamilySet): Deleted.
634         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
635         (WTR::allowedFontFamilySet): Deleted.
636         * WebKitTestRunner/mac/TestControllerMac.mm:
637         (WTR::allowedFontFamilySet): Deleted.
638
639 2016-01-13  Daniel Bates  <dabates@apple.com>
640
641         [XSS Auditor] Add test when XSS payload is in the path portion of the URL
642         https://bugs.webkit.org/show_bug.cgi?id=152871
643
644         Reviewed by Brent Fulgham.
645
646         Merged from Blink (patch by Tom Sepez <tsepez@chromium.org>):
647         <https://src.chromium.org/viewvc/blink?revision=164746&view=revision>
648
649         * Scripts/webkitpy/layout_tests/servers/lighttpd.conf:
650
651 2016-01-08  Andy Estes  <aestes@apple.com>
652
653         [Content Filtering] Lazily load platform frameworks
654         https://bugs.webkit.org/show_bug.cgi?id=152881
655         rdar://problem/23270886
656
657         Reviewed by Brady Eidson.
658
659         Added an API test that verifies that the Parental Controls and Network Extension frameworks are loaded at the
660         expected times. The test verifies that they are not loaded after creating a WKWebView, loading an HTML string,
661         loading NSData, loading a file, or loading from a custom protocol. It verifies that Network Extension on Mac/iOS
662         and Parental Controls on iOS are loaded after an HTTP request. It finally verifies that Parental Controls on Mac
663         is loaded after an HTTPS request.
664
665         To accomplish this, TestProtocol was generalized to allow tests to specify the scheme they wish to use.
666         Other tests that used TestProtocol were updated to account for this change. TestProtocol was removed from
667         WebKit2.PreventImageLoadWithAutoResizingTest, which didn't actually need to use it. ContentFiltering tests were
668         also re-enabled on iOS after mistakenly being disabled by r188892.
669
670         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
671         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
672         (TestWebKitAPI::TEST):
673         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.h: Added.
674         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.html: Added.
675         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
676         (TEST):
677         (downloadTest):
678         (-[LazilyLoadPlatformFrameworksController init]):
679         (-[LazilyLoadPlatformFrameworksController webView]):
680         (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
681         (-[LazilyLoadPlatformFrameworksController webView:didFinishNavigation:]):
682         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
683         (-[ContentFilteringPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
684         (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]):
685         (-[ContentFilteringPlugIn checkIfPlatformFrameworksAreLoaded:]):
686         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
687         (TestWebKitAPI::TEST):
688         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
689         (TestWebKitAPI::TEST): Deleted.
690         * TestWebKitAPI/cocoa/TestProtocol.h:
691         * TestWebKitAPI/cocoa/TestProtocol.mm:
692         (+[TestProtocol registerWithScheme:]):
693         (+[TestProtocol unregister]):
694
695 2016-01-12  Dewei Zhu  <dewei_zhu@apple.com>
696
697         Fix the Sunpider converage in slow device.
698         https://bugs.webkit.org/show_bug.cgi?id=152938
699         <rdar://problem/22511411>
700
701         Reviewed by Ryosuke Niwa.
702
703         Updated the patch for RunBenchmark to resume sunspider coverage by removing unused subresources in sub-tests.
704
705         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch:
706
707 2016-01-12  Ryosuke Niwa  <rniwa@webkit.org>
708
709         Add a build flag for custom element
710         https://bugs.webkit.org/show_bug.cgi?id=153005
711
712         Reviewed by Alex Christensen.
713
714         Added --custom-elements option to enable custom elements support.
715
716         * Scripts/webkitperl/FeatureList.pm:
717
718 2016-01-12  Benjamin Poulain  <bpoulain@apple.com>
719
720         [JSC] Add a help message when run-jsc-stress-tests fails
721         https://bugs.webkit.org/show_bug.cgi?id=153014
722
723         Reviewed by Csaba Osztrogonác.
724
725         * Scripts/run-jsc-stress-tests:
726
727 2016-01-11  Saam barati  <sbarati@apple.com>
728
729         run-jsc-stress-tests should try to figure out a JSC path
730         https://bugs.webkit.org/show_bug.cgi?id=152971
731
732         Reviewed by Yusuke Suzuki.
733
734         This patch now allows run-jsc-stress-tests to be run
735         without a "--jsc <jsc-path>" argument. It tries
736         to take its best guess at a <jsc-path> automagically.
737         
738         This makes it much easier to just run run-jsc-stress-tests
739         with a directory or a yaml file as an argument.
740         You now just do this:
741         `run-jsc-stress-tests <path-to-yaml>`
742         or
743         `run-jsc-stress-tests <path-to-directory-of-js-files>`
744         
745         I wrote this patch because I'd often find myself hacking the 
746         run-javascriptcore-tests file just to run a particular subset of tests.
747         Because I always forget the arguments to run-jsc-stress-tests (which means
748         I always forgot to provide a --jsc argument), I always found it easier to 
749         just hack on that file instead of calling run-jsc-stress-tests directly.
750         No longer is this true!
751
752         * Scripts/run-jsc-stress-tests:
753
754 2016-01-09  Andy Estes  <aestes@apple.com>
755
756         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
757         https://bugs.webkit.org/show_bug.cgi?id=152950
758         rdar://problem/24066652
759
760         Reviewed by Tim Horton.
761
762         Added an API test.
763
764         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
765         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
766         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
767         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
768         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
769         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
770         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
771         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
772         (TEST):
773
774 2016-01-11  Commit Queue  <commit-queue@webkit.org>
775
776         Unreviewed, rolling out r194866.
777         https://bugs.webkit.org/show_bug.cgi?id=152986
778
779         This change broke the mac build (Requested by ryanhaddad on
780         #webkit).
781
782         Reverted changeset:
783
784         "[Cocoa] Add SPI to opt out a URL scheme from the memory
785         cache"
786         https://bugs.webkit.org/show_bug.cgi?id=152950
787         http://trac.webkit.org/changeset/194866
788
789 2016-01-11  Andy Estes  <aestes@apple.com>
790
791         [Cocoa] Add SPI to opt out a URL scheme from the memory cache
792         https://bugs.webkit.org/show_bug.cgi?id=152950
793         rdar://problem/24066652
794
795         Reviewed by Tim Horton.
796
797         Added an API test.
798
799         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
800         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm: Added.
801         (+[AlwaysRevalidatedURLSchemeProtocol canInitWithRequest:]):
802         (+[AlwaysRevalidatedURLSchemeProtocol canonicalRequestForRequest:]):
803         (+[AlwaysRevalidatedURLSchemeProtocol requestIsCacheEquivalent:toRequest:]):
804         (-[AlwaysRevalidatedURLSchemeProtocol startLoading]):
805         (-[AlwaysRevalidatedURLSchemeProtocol stopLoading]):
806         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]):
807         (TEST):
808
809 2016-01-11  Konstantin Tokarev  <annulen@yandex.ru>
810
811         [webkitdirs] Use CMake to determine architecture on isCMakeBuild()
812         https://bugs.webkit.org/show_bug.cgi?id=152959
813
814         Reviewed by Brent Fulgham.
815
816         * Scripts/webkitdirs.pm:
817         (determineArchitecture):
818
819 2016-01-11  Michael Catanzaro  <mcatanzaro@igalia.com>
820
821         [GTK] W3C CSS2.1 anonymous table tests are failing
822         https://bugs.webkit.org/show_bug.cgi?id=152455
823
824         Reviewed by Mario Sanchez Prada.
825
826         Add shared-mime-info to the jhbuild environment, since it affects the results of layout
827         tests. Add upstream patches to fix detection of XHTML files.
828
829         * gtk/jhbuild.modules:
830         * gtk/patches/shared-mime-info-xht-glob.patch: Added.
831         * gtk/patches/shared-mime-info-xhtml-magic.patch: Added.
832
833 2016-01-10  Saam barati  <sbarati@apple.com>
834
835         Implement a sampling profiler
836         https://bugs.webkit.org/show_bug.cgi?id=151713
837
838         Reviewed by Filip Pizlo.
839
840         * Scripts/run-jsc-stress-tests:
841
842 2016-01-10  Konstantin Tokarev  <annulen@yandex.ru>
843
844         [webkitdirs] Try arch and uname commands on non-windows OS
845         https://bugs.webkit.org/show_bug.cgi?id=152958
846
847         Reviewed by Michael Catanzaro.
848
849         Right now, determineArchitecture()  uses `arch` and `uname -m`
850         commands to determine architecture in case of condition (isGtk() ||
851         isAppleMacWebKit() || isEfl()) is true. This should be !anyWindows()
852         instead, because this code is applicable to any non-windows OS WebKit
853         supports (even Haiku which once was supported is moderately
854         POSIX-compliant and has uname command).
855
856         * Scripts/webkitdirs.pm:
857         (determineArchitecture):
858
859 2016-01-08  Aakash Jain  <aakash_jain@apple.com>
860
861         run-webkit-tests mis-counts totals when there are other crashes
862         https://bugs.webkit.org/show_bug.cgi?id=152894
863         <rdar://problem/24098697>
864
865         Reviewed by Alexey Proskuryakov.
866
867         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
868         (TestRunResults.add): Do not update result counters for other crashes.
869
870 2016-01-08  Youenn Fablet  <youenn.fablet@crf.canon.fr>
871
872         webkit-patch build-and-test should have an option to iterate over new tests
873         https://bugs.webkit.org/show_bug.cgi?id=143093
874
875         Reviewed by Michael Catanzaro.
876
877         This patch introduces the --iterate-on-new-tests option to webkit-patch build-and-test.
878         It allows running run-webkit-tests on modified or new paths in LayoutTests.
879         Computation of new or modified tests is done by LayoutTestFinder.find_touched_tests
880         It implements the translation of -expected.* paths to their related tests.
881         It also implements the removal of skipped tests.
882
883         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
884         (LayoutTestFinder.find_touched_tests):
885         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py: Added.
886         (MockPort):
887         (MockPort.__init__):
888         (MockPort.tests):
889         (LayoutTestFinderTests):
890         (LayoutTestFinderTests.touched_files):
891         (LayoutTestFinderTests.test_touched_test):
892         (LayoutTestFinderTests.test_expected_touched_test):
893         (LayoutTestFinderTests.test_platform_expected_touched_test):
894         (LayoutTestFinderTests.test_platform_duplicate_touched_test):
895         (LayoutTestFinderTests.test_touched_but_skipped_test):
896         * Scripts/webkitpy/port/base.py:
897         (Port.potential_test_names_from_expected_file):
898         * Scripts/webkitpy/tool/commands/download_unittest.py:
899         (DownloadCommandsTest._default_options):
900         * Scripts/webkitpy/tool/steps/options.py:
901         (Options):
902         * Scripts/webkitpy/tool/steps/runtests.py:
903         (RunTests.options):
904         (RunTests.run):
905         (RunTests):
906         (RunTests._new_or_modified_tests):
907         (RunTests._run_webkit_tests):
908         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
909         (RunTestsTest.test_webkit_run_unit_tests):
910         * Scripts/webkitpy/tool/steps/steps_unittest.py:
911         (StepsTest._step_options):
912
913 2016-01-07  Joseph Pecoraro  <pecoraro@apple.com>
914
915         prepare-ChangeLog should include radar number
916         https://bugs.webkit.org/show_bug.cgi?id=152839
917         <rdar://problem/24093563>
918
919         Reviewed by Daniel Bates.
920
921         When running `prepare-ChangeLog -b ###`, check for a bugzilla comment that
922         starts with a "<rdar://problem/####>" URL. If found, include that radar URL
923         in the ChangeLog description after the bug URL.
924
925         * Scripts/prepare-ChangeLog:
926         (main): Update signatures.
927         (fetchBugXMLData): XML Data is now used for multiple reasons. Extract this to just get the data.
928         (fetchBugDescriptionFromBugXMLData): Search data for <short_desc>.
929         (fetchRadarURLFromBugXMLData): Search comment text for radar URL.
930         (generateNewChangeLogs): Include radar URL if we found one.
931
932         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl: Added.
933         Tests for the radar URL extraction.
934
935 2016-01-07  Alexey Proskuryakov  <ap@apple.com>
936
937         testRunner.runUIScript crashes while running multiple tests in a row that invokes the same UIScript
938         https://bugs.webkit.org/show_bug.cgi?id=152390
939         <rdar://problem/23948321>
940
941         Reviewed by Simon Fraser.
942
943         Fix two use-after-frees.
944
945         1. WKPageCallAfterNextPresentationUpdate's callback has a pointer to TestInvocation,
946         but we may have already progressed to another test by the time the callback fires,
947         having destroyed the TestInvocation.
948         2. UIScriptController is a RefCounted object, but it has a raw pointer to
949         UIScriptContext which has the same lifetime as a TestInvocation.
950         As a result, completion blocks of UIScriptController actions would use a destroyed
951         TestInvocation.
952
953         * WebKitTestRunner/TestInvocation.cpp:
954         (WTR::TestInvocation::~TestInvocation):
955         (WTR::TestInvocation::url):
956         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
957         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
958         (WTR::TestInvocation::runUISideScript):
959         * WebKitTestRunner/TestInvocation.h:
960         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
961         (UIScriptContext::UIScriptContext):
962         (UIScriptContext::~UIScriptContext):
963         (UIScriptContext::runUIScript):
964         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
965         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
966         (WTR::UIScriptController::UIScriptController):
967         (WTR::UIScriptController::contextDestroyed):
968         (WTR::UIScriptController::makeWindowObject):
969         (WTR::UIScriptController::setWillBeginZoomingCallback):
970         (WTR::UIScriptController::willBeginZoomingCallback):
971         (WTR::UIScriptController::setDidEndZoomingCallback):
972         (WTR::UIScriptController::didEndZoomingCallback):
973         (WTR::UIScriptController::setDidEndScrollingCallback):
974         (WTR::UIScriptController::didEndScrollingCallback):
975         (WTR::UIScriptController::setDidShowKeyboardCallback):
976         (WTR::UIScriptController::didShowKeyboardCallback):
977         (WTR::UIScriptController::setDidHideKeyboardCallback):
978         (WTR::UIScriptController::didHideKeyboardCallback):
979         (WTR::UIScriptController::uiScriptComplete):
980         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
981         (WTR::UIScriptController::create):
982         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
983         (WTR::UIScriptController::doAsyncTask):
984         (WTR::UIScriptController::zoomToScale):
985         (WTR::UIScriptController::singleTapAtPoint):
986         (WTR::UIScriptController::doubleTapAtPoint):
987         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
988         (WTR::UIScriptController::contentVisibleRect):
989         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
990         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
991         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
992         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
993         (WTR::UIScriptController::platformSetDidEndScrollingCallback):
994         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
995         (WTR::UIScriptController::doAsyncTask):
996
997 2016-01-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
998
999         [buildbot] clean-build script should remove untracked files and revert local changes too
1000         https://bugs.webkit.org/show_bug.cgi?id=142400
1001
1002         Reviewed by Ryosuke Niwa.
1003
1004         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
1005         A helper routine SCM.discard_untracked_files is added for that purpose.
1006
1007         * BuildSlaveSupport/clean-build:
1008         (main): Making call to Scripts/clean-webkit
1009         * Scripts/clean-webkit: Added.
1010         (main): Revert changes and delete untracked files.
1011         * Scripts/webkitpy/common/checkout/scm/scm.py:
1012         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
1013         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1014         (SCMTest._shared_test_discard_untracked_files):
1015         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
1016
1017 2016-01-06  Simon Fraser  <simon.fraser@apple.com>
1018
1019         Add a setting and preferences to enable display-list drawing. Does nothing yet.
1020         https://bugs.webkit.org/show_bug.cgi?id=152807
1021
1022         Reviewed by Zalan Bujtas.
1023         
1024         Add an item to the Settings menu to toggle display-list drawing.
1025
1026         * MiniBrowser/mac/SettingsController.h:
1027         * MiniBrowser/mac/SettingsController.m:
1028         (-[SettingsController _populateMenu]):
1029         (-[SettingsController validateMenuItem:]):
1030         (-[SettingsController toggleDisplayListDrawingEnabled:]):
1031         (-[SettingsController displayListDrawingEnabled]):
1032         * MiniBrowser/mac/WK2BrowserWindowController.m:
1033         (-[WK2BrowserWindowController didChangeSettings]):
1034
1035 2016-01-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1036
1037         Python SCM should be able to retrieve untracked files - Add GIT support
1038         https://bugs.webkit.org/show_bug.cgi?id=143135
1039
1040         Reviewed by Michael Catanzaro.
1041
1042         * Scripts/webkitpy/common/checkout/scm/git.py:
1043         (Git.untracked_files): Adding support for git.
1044         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1045         (GitTest.setUp):
1046         (GitTest.test_untracked_files): Adding test.
1047
1048 2016-01-05  Mark Lam  <mark.lam@apple.com>
1049
1050         Rename badly named JSC_timeout env var to JSCTEST_timeout.
1051         https://bugs.webkit.org/show_bug.cgi?id=152748
1052
1053         Reviewed by Geoffrey Garen.
1054
1055         Now that we validate JSC options, the badly named JSC_timeout env var causes the
1056         bots to have a bad time.
1057
1058         * Scripts/run-javascriptcore-tests:
1059         * Scripts/run-jsc-stress-tests:
1060
1061 2016-01-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1062
1063         [GTK] Allow to save and restore session
1064         https://bugs.webkit.org/show_bug.cgi?id=115600
1065
1066         Reviewed by Michael Catanzaro.
1067
1068         Add test case to check the new session API.
1069
1070         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
1071         (testWebKitWebViewSessionState):
1072         (testWebKitWebViewSessionStateWithFormData):
1073         (beforeAll):
1074
1075 2016-01-04  Csaba Osztrogonác  <ossy@webkit.org>
1076
1077         [EFL] Bump EFL version to 1.16.1
1078         https://bugs.webkit.org/show_bug.cgi?id=152688
1079
1080         Reviewed by Gyuyoung Kim.
1081
1082         * efl/jhbuild.modules:
1083
1084 2016-01-04  Aakash Jain  <aakash_jain@apple.com>
1085
1086         error running layout tests on iOS simulator on latest build
1087         https://bugs.webkit.org/show_bug.cgi?id=152719
1088         <rdar://problem/24009549>
1089
1090         Reviewed by Alexey Proskuryakov.
1091
1092         * Scripts/webkitpy/xcode/simulator.py:
1093         (Simulator.wait_until_device_is_booted): Ensure that simulator device is in booted state
1094           before running simctl spawn command.
1095
1096 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1097
1098         Unreviewed, move Frédéric Wang to committers list
1099
1100         He seems to be on the contributors list by accident. He has been landing his own commits for
1101         about two years now.
1102
1103         * Scripts/webkitpy/common/config/contributors.json:
1104
1105 2016-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1106
1107         Unreviewed, move Sebastian Dröge to committers list harder
1108
1109         He accidentally added himself to the reviewers list because the file is confusing. Then I
1110         accidentially moved him to the contributors list because the file is confusing, even though
1111         I knew the contributors list existed in this file and was attempting to add him to the
1112         committers list. Really move him to the committers list now.
1113
1114         * Scripts/webkitpy/common/config/contributors.json:
1115
1116 2016-01-02  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1117
1118         Python SCM should be able to retrieve untracked files - Add SVN support
1119         https://bugs.webkit.org/show_bug.cgi?id=152546
1120
1121         Reviewed by Michael Catanzaro.
1122
1123         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1124         (test_untracked_files): Activating test for SVN.
1125         * Scripts/webkitpy/common/checkout/scm/svn.py:
1126         (SVN.untracked_files): Implementing untracked files retrieval for SVN.
1127
1128 2015-12-31  Andy Estes  <aestes@apple.com>
1129
1130         Replace WTF::move with WTFMove
1131         https://bugs.webkit.org/show_bug.cgi?id=152601
1132
1133         Reviewed by Brady Eidson.
1134
1135         * DumpRenderTree/TestRunner.h:
1136         (TestRunner::setAllowedHosts):
1137         * DumpRenderTree/win/DRTDataObject.cpp:
1138         (DRTDataObject::SetData):
1139         * TestWebKitAPI/Tests/WTF/Deque.cpp:
1140         (TestWebKitAPI::TEST):
1141         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1142         (TestWebKitAPI::TEST):
1143         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1144         (TestWebKitAPI::TEST):
1145         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
1146         (TestWebKitAPI::TEST):
1147         * TestWebKitAPI/Tests/WTF/Ref.cpp:
1148         (TestWebKitAPI::passWithRef):
1149         (TestWebKitAPI::TEST):
1150         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
1151         (TestWebKitAPI::TEST):
1152         * TestWebKitAPI/Tests/WTF/Vector.cpp:
1153         (TestWebKitAPI::TEST):
1154         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1155         (TestWebKitAPI::TEST):
1156         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
1157         (TestWebKitAPI::TEST):
1158         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
1159         (TestWebKitAPI::createTestValue):
1160         (TestWebKitAPI::TEST):
1161         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1162         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
1163         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
1164         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
1165         (TestWebKitAPI::createNFAs):
1166         (TestWebKitAPI::TEST_F):
1167         * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp:
1168         (TestWebKitAPI::combine):
1169         * TestWebKitAPI/Tests/WebCore/DFAHelpers.h:
1170         (TestWebKitAPI::createNFAs):
1171         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm:
1172         (TEST):
1173         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
1174         (WebProcessTest::add):
1175
1176 2016-01-01  Michael Catanzaro  <mcatanzaro@igalia.com>
1177
1178         [SOUP] REGRESSION(r192761): Broke resource URIs for applications that use g_resource_load in a web extension
1179         https://bugs.webkit.org/show_bug.cgi?id=152634
1180
1181         Reviewed by Carlos Garcia Campos.
1182
1183         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1184         (testLoadFromGResource): Added test.
1185         (beforeAll):
1186         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1187         (registerGResource): Added.
1188         (webkit_web_extension_initialize_with_user_data): Load the test gresource.
1189         * TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html: Added.
1190         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Add an HTML file.
1191
1192 2015-12-31  David Kilzer  <ddkilzer@apple.com>
1193
1194         REGRESSION (r194470): Fix warnings uncovered by migrating to WTF_MOVE
1195         <https://bugs.webkit.org/show_bug.cgi?id=152601>
1196
1197         Ignore unknown pragmas on older clangs.  Fixes the following
1198         build failure:
1199
1200             Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp:184:34: error: unknown warning group '-Wself-move', ignored [-Werror,-Wunknown-pragmas]
1201             #pragma clang diagnostic ignored "-Wself-move"
1202                                              ^
1203             1 error generated.
1204
1205         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
1206         (TestWebKitAPI::TEST):
1207         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
1208         (TestWebKitAPI::TEST):
1209
1210 2015-12-31  Andy Estes  <aestes@apple.com>
1211
1212         Update the style checker to advise using WTFMove() instead of WTF::move()
1213         https://bugs.webkit.org/show_bug.cgi?id=152601
1214
1215         Reviewed by Daniel Bates.
1216
1217         * Scripts/webkitpy/style/checkers/cpp.py:
1218         (check_wtf_move):
1219         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1220         (WebKitStyleTest.test_wtf_move):
1221
1222 2015-12-31  Andy Estes  <aestes@apple.com>
1223
1224         Fix warnings uncovered by migrating to WTF_MOVE
1225         https://bugs.webkit.org/show_bug.cgi?id=152601
1226
1227         Reviewed by Daniel Bates.
1228
1229         Ignored -Wself-move warnings in these two API tests. It's useful to test that these classes properly handle
1230         self-move, even if doing so would trigger a warning.
1231
1232         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
1233         (TestWebKitAPI::TEST):
1234         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
1235         (TestWebKitAPI::TEST):
1236
1237 2015-12-31  Martin Robinson  <mrobinson@igalia.com>
1238
1239         [GTK] The install-dependencies script has a syntax error
1240         https://bugs.webkit.org/show_bug.cgi?id=152613
1241
1242         Reviewed by Michael Catanzaro.
1243
1244         * gtk/install-dependencies: Add the missing 'then.'
1245
1246 2015-12-30  Philippe Normand  <pnormand@igalia.com>
1247
1248         [Mac][GTK] Jhbuild support for OSX
1249         https://bugs.webkit.org/show_bug.cgi?id=150799
1250
1251         Reviewed by Michael Catanzaro.
1252
1253         * gtk/install-dependencies: Install dependencies on OSX with Homebrew.
1254         * gtk/jhbuild.modules: Moved platform-specific build settings in condition tags.
1255         * gtk/patches/foxbntconfig-fix-osx-cache.diff: Added.
1256         * gtk/jhbuildrc: GTK+ makeargs clean-up, the 3.0.12 hack is no longer needed.
1257
1258 2015-12-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1259
1260         Unreviewed, move Sebastian Dröge to committers list
1261
1262         He accidentally added himself to the reviewers list because the file is confusing.
1263
1264         * Scripts/webkitpy/common/config/contributors.json:
1265
1266 2015-12-24  Simon Fraser  <simon.fraser@apple.com>
1267
1268         Remove the unused #define _USE_MATH_DEFINES
1269         https://bugs.webkit.org/show_bug.cgi?id=152034
1270
1271         Reviewed by Tim Horton.
1272         
1273         Update this test to use piDouble from MathExtras.h, and
1274         std::numeric_limits<>.
1275
1276         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1277
1278 2015-12-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1279
1280         Python SCM should be able to retrieve untracked files - Generic changes
1281         https://bugs.webkit.org/show_bug.cgi?id=152536
1282
1283         Reviewed by Brent Fulgham.
1284
1285         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
1286         No support is yet added to GIT and SVN specific implementations.
1287
1288         * Scripts/webkitpy/common/checkout/scm/scm.py:
1289         (SCM.untracked_files):
1290         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1291         (SCMTest._shared_test_untracked_files):
1292
1293 2015-12-23  Dewei Zhu  <dewei_zhu@apple.com>
1294
1295         SVN checkout used by RunBenchmark should be non-interactive
1296         https://bugs.webkit.org/show_bug.cgi?id=152542
1297
1298         Reviewed by Ryosuke Niwa.
1299
1300         RunBenchmark should not require user interaction while running.
1301
1302         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
1303         (BenchmarkBuilder._checkout_with_subversion):
1304
1305 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
1306
1307         Web Inspector: add support for running protocol-test.js tests on Windows
1308         https://bugs.webkit.org/show_bug.cgi?id=148037
1309         <rdar://problem/22292237>
1310
1311         Reviewed by Simon Fraser.
1312
1313         * DumpRenderTree/win/TestRunnerWin.cpp:
1314         (TestRunner::inspectorTestStubURL): Provide implementation.
1315
1316 2015-12-23  Eric Carlson  <eric.carlson@apple.com>
1317
1318         [MediaStream] MediaDeviceInfo.label must be empty in some situations
1319         https://bugs.webkit.org/show_bug.cgi?id=152000
1320
1321         Reviewed by Brent Fulgham.
1322
1323         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1324         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1325         (WTR::InjectedBundle::setUserMediaPermission):
1326         (WTR::InjectedBundle::setUserMediaPermissionForOrigin): New.
1327         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1328
1329         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1330         (WTR::TestRunner::setUserMediaPermissionForOrigin): New.
1331         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1332
1333         * WebKitTestRunner/TestController.cpp:
1334         (WTR::TestController::setUserMediaPermissionForOrigin):
1335         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Add NULL check.
1336         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Don't add 
1337           persistent permission for origin, that can be done from script now.
1338         * WebKitTestRunner/TestController.h:
1339
1340         * WebKitTestRunner/TestInvocation.cpp:
1341         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Add support for
1342           SetUserMediaPermissionForOrigin.
1343
1344 2015-12-23  Brent Fulgham  <bfulgham@apple.com>
1345
1346         [Win] Unreviewed build fix: Recognize Windows 10 variants.
1347
1348         * Scripts/webkitpy/common/system/platforminfo.py:
1349         (PlatformInfo._determine_win_version):
1350
1351 2015-12-23  Chris Aljoudi <chris@chrismatic.io> and Alex Christensen <achristensen@webkit.org>
1352
1353         Content blockers should be able to promote http to https
1354         https://bugs.webkit.org/show_bug.cgi?id=148966
1355
1356         Reviewed by Benjamin Poulain.
1357
1358         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1359         (WebCore::ContentExtensions::operator<<):
1360         (TestWebKitAPI::TEST_F):
1361
1362 2015-12-22  Hunseop Jeong  <hs85.jeong@samsung.com>
1363
1364         [EFL] MiniBrowser should be able to choose the offline-web-application-cache option
1365         https://bugs.webkit.org/show_bug.cgi?id=152516
1366
1367         Reviewed by Gyuyoung Kim.
1368
1369         * MiniBrowser/efl/main.c:
1370
1371 2015-12-22  Brent Fulgham  <bfulgham@apple.com>
1372
1373         Unreviewed: Add John Wilander as a contributor.
1374
1375         * Scripts/webkitpy/common/config/contributors.json:
1376
1377 2015-12-22  Chris Fleizach  <cfleizach@apple.com>
1378
1379         [WK2] Looping in testcase: fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
1380         https://bugs.webkit.org/show_bug.cgi?id=152482
1381
1382         Reviewed by Brent Fulgham.
1383
1384         vertical/horizontalScrollbar returns an accessibility element. That element can also be queried
1385         for the same property. On WK2, the element returned will not be valid, but is still present and
1386         that can lead to looping.
1387
1388         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1389         (AccessibilityUIElement::horizontalScrollbar):
1390         (AccessibilityUIElement::verticalScrollbar):
1391         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1392         (WTR::AccessibilityUIElement::horizontalScrollbar):
1393         (WTR::AccessibilityUIElement::verticalScrollbar):
1394
1395 2015-12-22  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1396
1397         Unreviewed.
1398
1399         * Scripts/webkitpy/common/config/contributors.json: Marking myself as reviewer.
1400
1401 2015-12-21  Hunseop Jeong  <hs85.jeong@samsung.com>
1402
1403         [EFL] test_ewk2_context failed after r192808
1404         https://bugs.webkit.org/show_bug.cgi?id=151846
1405
1406         Reviewed by Gyuyoung Kim.
1407
1408         Used the added ewk_context_web_process_count_limit_set api
1409         instead of the deprecated ewk_context_process_model_set.
1410
1411         * MiniBrowser/efl/main.c:
1412         (elm_main):
1413
1414 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
1415
1416         Unreviewed, move myself to reviewer list.
1417
1418         * Scripts/webkitpy/common/config/contributors.json:
1419
1420 2015-12-21  Aakash Jain  <aakash_jain@apple.com>
1421
1422         Unreviewed, add myself to the committers list.
1423
1424         * Scripts/webkitpy/common/config/contributors.json:
1425
1426 2015-12-21  Michael Catanzaro  <mcatanzaro@igalia.com>
1427
1428         [GTK] jquery.min.js violates DFSG
1429         https://bugs.webkit.org/show_bug.cgi?id=152428
1430
1431         Reviewed by Joseph Pecoraro.
1432
1433         Stop distributing Source/WebInspectorUI/Tools. It is not needed in tarballs. This brings us
1434         into compliance with DFSG by removing a bundled, minified copy of jQuery from our tarball.
1435
1436         * gtk/manifest.txt.in:
1437
1438 2015-12-19  Dan Bernstein  <mitz@apple.com>
1439
1440         [Mac] WebKit contains dead source code for OS X Mavericks and earlier
1441         https://bugs.webkit.org/show_bug.cgi?id=152462
1442
1443         Reviewed by Alexey Proskuryakov.
1444
1445         - Removed definitions of MACOSX_DEPLOYMENT_TARGET and WEBKIT_SYSTEM_INTERFACE_LIBRARY for
1446           OS X 10.9:
1447
1448         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1449         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1450         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1451         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1452         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1453
1454         - Simplified expressions involving __MAC_OS_X_VERSION_MIN_REQUIRED and removed code that was
1455           never getting compiled:
1456
1457         * DumpRenderTree/mac/TextInputController.m:
1458         * MiniBrowser/mac/BrowserWindowController.m:
1459         * TestWebKitAPI/Tests/mac/AttributedString.mm:
1460         * WebKitTestRunner/mac/EventSenderProxy.mm:
1461
1462 2015-12-18  Michael Catanzaro  <mcatanzaro@igalia.com>
1463
1464         Unreviewed, add WebKitGTK+ Bugzilla email to committers list
1465
1466         This is to make it easy to CC it on Bugzilla.
1467
1468         * Scripts/webkitpy/common/config/contributors.json:
1469
1470 2015-12-18  Aakash Jain  <aakash_jain@apple.com>
1471
1472         Pasteboard get messed up after running kill-old-processes
1473         https://bugs.webkit.org/show_bug.cgi?id=152426
1474
1475         Reviewed by Alexey Proskuryakov.
1476
1477         * BuildSlaveSupport/kill-old-processes:
1478         (main): Do not kill pasteboard anymore.
1479
1480 2015-12-17  Aakash Jain  <aakash_jain@apple.com>
1481
1482         run-webkit-tests shouldn't start multiple iOS simulators while only running one test
1483         https://bugs.webkit.org/show_bug.cgi?id=152157
1484         <rdar://problem/23851817>
1485
1486         Reviewed by Alexey Proskuryakov.
1487
1488         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1489         (LayoutTestRunner.get_worker_count): Calculate required number of workers.
1490         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1491         (Manager._get_test_inputs): Common method to calculate test_inputs.
1492         (Manager._update_worker_count): Calculate and update required number of workers.
1493
1494 2015-12-16  Aakash Jain  <aakash_jain@apple.com>
1495
1496         run-webkit-tests fails to delete Simulator device during cleanup
1497         https://bugs.webkit.org/show_bug.cgi?id=152363
1498
1499         Reviewed by Alexey Proskuryakov.
1500
1501         * Scripts/webkitpy/xcode/simulator.py:
1502         (Simulator.delete_device): Ensure that device is Shutdown before deleting it.
1503
1504 2015-12-16  Tim Horton  <timothy_horton@apple.com>
1505
1506         [mac-wk2] fast/events force click tests crashing
1507         https://bugs.webkit.org/show_bug.cgi?id=152339
1508
1509         Reviewed by Beth Dakin.
1510
1511         * WebKitTestRunner/mac/EventSenderProxy.mm:
1512         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
1513         Set the NSEvent's _type member in addition to overriding -type,
1514         because there are assertions in touch event handling code that depend on it.
1515
1516 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1517
1518         Enforce temporarily bots to sync WebKit and WPT testharness.js
1519         https://bugs.webkit.org/show_bug.cgi?id=152334
1520
1521         Reviewed by Darin Adler.
1522
1523         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1524         (WebPlatformTestServer._copy_webkit_test_files): Temporarily overwrite wpt testharness.js with WebKit testharness.js.
1525
1526 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1527
1528         [Fetch API] Add fetch API compile time flag
1529         https://bugs.webkit.org/show_bug.cgi?id=152254
1530
1531         Reviewed by Darin Adler.
1532
1533         * Scripts/webkitperl/FeatureList.pm:
1534
1535 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1536
1537         Unreviewed.
1538
1539         Added files that have impact in building Streams API to the watchlist.
1540
1541         * Scripts/webkitpy/common/config/watchlist:
1542
1543 2015-12-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1544
1545         Unreviewed.
1546
1547         Added imported tests to Streams API watchlist.
1548
1549         * Scripts/webkitpy/common/config/watchlist:
1550
1551 2015-12-16  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1552
1553         Remove default copy of wpt testharness.js when launching wpt server
1554         https://bugs.webkit.org/show_bug.cgi?id=152298
1555
1556         Reviewed by Darin Adler.
1557
1558         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1559         (WebPlatformTestServer._copy_webkit_test_files): Deleted default copy of WebKit testharness.js to WPT.
1560
1561 2015-12-15  David Kilzer  <ddkilzer@apple.com>
1562
1563         REGRESSION (r192375): DumpRenderTree.app exits immediately with no error
1564         <http://webkit.org/b/152314>
1565
1566         Reviewed by Daniel Bates.
1567
1568         The change to DumpRenderTreeMain.mm in r192375 caused the iOS
1569         code path to exit immediately when calling main().
1570         Unfortunately, DumpRenderTreeMain.mm was used for both
1571         DumpRenderTree command-line binary and DumpRenderTree.app, which
1572         meant that the app would exit immediately with no error code
1573         when run!
1574
1575         The workaround is to introduce a separate source file called
1576         DumpRenderTreeAppMain.mm, similar to what WebKitTestRunner
1577         already does.
1578
1579         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add
1580         DumpRenderTreeAppMain.mm to the project.  Make it the only
1581         compiled source for the DumpRenderTree.app target.
1582         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm: Copied from Tools/DumpRenderTree/mac/DumpRenderTreeMain.mm.
1583         (main): Call DumpRenderTreeMain() on iOS.  Assert on OS X in
1584         case someone tries mistakenly to use the app.
1585         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1586         Link to JavaScriptCore.framework on iOS for the assert.
1587         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1588         Link to JavaScriptCore.framework on OS X for the assert.  Remove
1589         unneeded EXCLUDED_SOURCE_FILE_NAMES setting.
1590         * DumpRenderTree/mac/DumpRenderTreeMain.mm:
1591         (main): Add assert for iOS so that a crash occurs if someone
1592         tries to run the wrong command.
1593
1594 2015-12-14  Tim Horton  <timothy_horton@apple.com>
1595
1596         Frequent crash under -[WKPDFView web_setMinimumSize:]_block_invoke
1597         https://bugs.webkit.org/show_bug.cgi?id=152266
1598         <rdar://problem/22092676>
1599
1600         Reviewed by Simon Fraser.
1601
1602         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1603         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm: Added.
1604         Add a test that crashed before this change, and doesn't crash after.
1605
1606 2015-12-14  Chris Fleizach  <cfleizach@apple.com>
1607
1608         AX: iOS: Text field variations do not have the correct traits
1609         https://bugs.webkit.org/show_bug.cgi?id=152237
1610
1611         Reviewed by Mario Sanchez Prada.
1612
1613         Add iOS calls for determing if an object is a search field or a text area.
1614
1615         * DumpRenderTree/AccessibilityUIElement.cpp:
1616         (getIsSearchFieldCallback):
1617         (getIsTextAreaCallback):
1618         (stringForSelectionCallback):
1619         (AccessibilityUIElement::getJSClass):
1620         * DumpRenderTree/AccessibilityUIElement.h:
1621         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1622         (AccessibilityUIElement::identifier):
1623         (AccessibilityUIElement::isTextArea):
1624         (AccessibilityUIElement::isSearchField):
1625         (AccessibilityUIElement::traits):
1626         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1627         (WTR::AccessibilityUIElement::scrollPageRight):
1628         (WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
1629         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
1630         (WTR::AccessibilityUIElement::isSearchField):
1631         (WTR::AccessibilityUIElement::isTextArea):
1632         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1633         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1634         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1635         (WTR::AccessibilityUIElement::fieldsetAncestorElement):
1636         (WTR::AccessibilityUIElement::isTextArea):
1637         (WTR::AccessibilityUIElement::isSearchField):
1638         (WTR::AccessibilityUIElement::rowCount):
1639
1640 2015-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1641
1642         [GTK] [JHBuild] package libtool-bin is now required on Debian systems.
1643         https://bugs.webkit.org/show_bug.cgi?id=152252
1644
1645         Reviewed by Sergio Villar Senin.
1646
1647         * gtk/install-dependencies: Add libtool-bin to the list of packages required
1648         for building the JHBuild on Debian systems.
1649
1650 2015-12-11  Joseph Pecoraro  <pecoraro@apple.com>
1651
1652         check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones
1653         https://bugs.webkit.org/show_bug.cgi?id=152156
1654
1655         Reviewed by Dan Bernstein.
1656
1657         Our frameworks should appropriately prefix all ObjC classes,
1658         not just external symbols.
1659
1660         * Scripts/check-for-inappropriate-objc-class-names:
1661         Remove the -g switch to check all ObjC class names.
1662
1663 2015-12-10  Eric Carlson  <eric.carlson@apple.com>
1664
1665         [MediaStream] Expose media capture devices persistent permissions to WebCore
1666         https://bugs.webkit.org/show_bug.cgi?id=152087
1667
1668         Add support for the new user media permission checker page UI client method.
1669
1670         Reviewed by Chris Dumez.
1671
1672         * WebKitTestRunner/TestController.cpp:
1673         (WTR::decidePolicyForUserMediaPermissionRequest):
1674         (WTR::checkUserMediaPermissionForOrigin):
1675         (WTR::TestController::createOtherPage): Add checkUserMediaPermissionForOrigin.
1676         (WTR::TestController::createWebViewWithOptions): Ditto.
1677         (WTR::TestController::resetStateToConsistentValues): Clear m_userMediaOriginPermissions.
1678         (WTR::originUserVisibleName): New, create a string for the origin.
1679         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Set the WKUserMediaPermissionCheckRef
1680           according to the state of the origin permission map.
1681         (WTR::TestController::handleUserMediaPermissionRequest): Remember both the origin and the
1682           request so we can update the origin permission map in decidePolicyForUserMediaPermissionRequestIfPossible.
1683         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update the
1684           origin permission map.
1685         * WebKitTestRunner/TestController.h:
1686
1687 2015-12-10  Alex Christensen  <achristensen@webkit.org>
1688
1689         REGRESSION (r192796) WKBundlePageResourceLoadClient should be able to setHTTPBody in willSendRequestForFrame
1690         https://bugs.webkit.org/show_bug.cgi?id=152022
1691         rdar://problem/23763584
1692
1693         Reviewed by Darin Adler.
1694
1695         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1696         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1697         (WTR::InjectedBundlePage::willSendRequestForFrame):
1698         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1699         (WTR::TestRunner::setWillSendRequestReturnsNull):
1700         (WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
1701         (WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
1702         (WTR::TestRunner::setWillSendRequestAddsHTTPBody):
1703         (WTR::TestRunner::willSendRequestHTTPBody):
1704         Added setWillSendRequestAddsHTTPBody that uses new SPI for testing.
1705
1706 2015-12-10  Aakash Jain  <aakash_jain@apple.com>
1707
1708         Remove additional simulator checks before running layout-tests
1709         https://bugs.webkit.org/show_bug.cgi?id=152146
1710
1711         Reviewed by Darin Adler.
1712
1713         * Scripts/webkitpy/port/ios.py:
1714         (IOSSimulatorPort.check_sys_deps): Removed additional simulators verifications.
1715         * Scripts/webkitpy/xcode/simulator.py:
1716         (Simulator._boot_and_shutdown_simulator_device): Deleted.
1717         (Simulator.check_simulator_device_and_erase_if_needed): Deleted.
1718
1719 2015-12-09  Aakash Jain  <aakash_jain@apple.com>
1720
1721         Run atleast one simulator even if max process limit is low
1722         https://bugs.webkit.org/show_bug.cgi?id=152081
1723         <rdar://problem/23819694>
1724
1725         Reviewed by Alexey Proskuryakov.
1726
1727 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
1728
1729         [GTK] Crash in WebProcess when loading large content with custom URI schemes
1730         https://bugs.webkit.org/show_bug.cgi?id=144262
1731
1732         Reviewed by Carlos Garcia Campos.
1733
1734         Added new unit test to check the additional scenarios we now
1735         handle for custom URI schemes.
1736
1737         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1738         (generateHTMLContent): New helper function to generate big enough content.
1739         (testWebContextURIScheme): New unit test.
1740
1741 2015-12-09  Ryuan Choi  <ryuan.choi@navercorp.com>
1742
1743         [EFL] Fix unhandled web process message when launching MiniBrowser
1744         https://bugs.webkit.org/show_bug.cgi?id=152048
1745
1746         Reviewed by Gyuyoung Kim.
1747
1748         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
1749         (TestWebKitAPI::TEST):
1750
1751 2015-12-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1752
1753         [GTK] Add API to handle beforeunload events
1754         https://bugs.webkit.org/show_bug.cgi?id=139090
1755
1756         Reviewed by Gustavo Noronha Silva.
1757
1758         * MiniBrowser/gtk/BrowserWindow.c:
1759         (browserWindowConstructed):
1760         (browserWindowDeleteEvent):
1761         (browser_window_class_init):
1762         Handle delete-event to prevent the window from being closed when
1763         the page has beforeunload handlers. Use
1764         webkit_web_view_try_close() when the window is requested to be
1765         closed.
1766         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1767         (testWebViewJavaScriptDialogs):
1768         Add a test case for the WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM
1769         script dialog type.
1770
1771 2015-12-09  Mario Sanchez Prada  <mario@endlessm.com>
1772
1773         Refactored initialization code in LoadTrackingTest.
1774
1775         Rubber-stamped by Carlos Garcia Campos.
1776
1777         Small refactoring to make sure that the state of a LoadTrackingTest
1778         gets properly reset before loading new web content.
1779
1780         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
1781         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
1782         (LoadTrackingTest::reset): New, refactored code from *load*() and go*()
1783         functions and reset the remaining local variables.
1784         (LoadTrackingTest::loadURI): Call reset();
1785         (LoadTrackingTest::loadHtml): Ditto.
1786         (LoadTrackingTest::loadPlainText): Ditto.
1787         (LoadTrackingTest::loadBytes): Ditto.
1788         (LoadTrackingTest::loadRequest): Ditto.
1789         (LoadTrackingTest::reload): Ditto.
1790         (LoadTrackingTest::goBack): Ditto.
1791         (LoadTrackingTest::goForward): Ditto.
1792
1793 2015-12-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1794
1795         [EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
1796         https://bugs.webkit.org/show_bug.cgi?id=151942
1797
1798         Reviewed by Darin Adler.
1799
1800         * MiniBrowser/efl/main.c:
1801         (window_create): Enable offline web application cache feature on MiniBrowser.
1802         (elm_main):
1803
1804 2015-12-08  Aakash Jain  <aakash_jain@apple.com>
1805
1806         https://bugs.webkit.org/show_bug.cgi?id=151243
1807         <rdar://problem/22955197>
1808
1809         Reviewed by Alexey Proskuryakov.
1810
1811         * LayoutTestRelay/LayoutTestRelay/main.m:
1812         (getTestingSimDevice): Use separate testing device for each worker.
1813         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1814         (Manager.run): Perform cleanup even if setup fails.
1815         * Scripts/webkitpy/port/ios.py:
1816         (IOSSimulatorPort.default_child_processes): Calculate number of simulators to use.
1817         (IOSSimulatorPort.child_processes): Gets the number of simulators from options variable.
1818         (IOSSimulatorPort.setup_test_run): Handle mulitple simulators.
1819         (IOSSimulatorPort._quit_ios_simulator): Same
1820         (IOSSimulatorPort.clean_up_test_run): Same
1821         (IOSSimulatorPort.check_sys_deps): Same
1822         (IOSSimulatorPort.testing_device): Same
1823         (IOSSimulatorPort.reset_preferences): Same
1824         (IOSSimulatorPort.get_simulator_path): Return simulator path.
1825         (IOSSimulatorPort._createSimulatorApp): Create the copy of simulator app.
1826         * Scripts/webkitpy/xcode/simulator.py:
1827         (Device.delete): Delete the simulator device.
1828         (Simulator.delete_device): Same
1829         (Simulator.wait_until_device_is_booted): Wait for device booting.
1830
1831 2015-12-08  Ryuan Choi  <ryuan.choi@navercorp.com>
1832
1833         [EFL] Add API to provide preferences before creating ewk_view
1834         https://bugs.webkit.org/show_bug.cgi?id=151587
1835
1836         Reviewed by Gyuyoung Kim.
1837
1838         * MiniBrowser/efl/main.c:
1839         (on_key_down):
1840         (quit):
1841         (window_create):
1842         Moved settings related code to configuration() not to update settings
1843         whenever ewk_view is created.
1844         (configuration):
1845         (elm_main):
1846
1847 2015-12-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1848
1849         Unreviewed. Fix GTK+ API tests after r193639.
1850
1851         The new jhbuild version needs some more variables ot be present in
1852         the builtin dict, even if they are set to None.
1853
1854         * jhbuild/jhbuildutils.py:
1855         (enter_jhbuild_environment_if_available):
1856
1857 2015-12-07  Gustavo Noronha Silva  <gns@gnome.org>
1858
1859         [GTK] Notify WebCore when notification is clicked
1860         https://bugs.webkit.org/show_bug.cgi?id=151951
1861
1862         Reviewed by Carlos Garcia Campos.
1863
1864         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1865         (testWebViewNotification): test the new API.
1866
1867 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1868
1869         'jhbuild build' should fail immediately when building any module fails
1870         https://bugs.webkit.org/show_bug.cgi?id=145697
1871
1872         Reviewed by Carlos Garcia Campos.
1873
1874         * efl/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
1875         * gtk/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
1876         Everything is placed under lib instead of lib64 now.
1877         * jhbuild/jhbuild-wrapper: Update jhbuild to the latest upstream commit, and pass
1878         --exit-on-error when running 'jhbuild build'.
1879         * jhbuild/jhbuildrc_common.py:
1880         (init): Don't override PKG_CONFIG_PATH, CMAKE_PREFIX_PATH, or CMAKE_LIBRARY_PATH. Modern
1881         jhbuild should be able to handle these for us without breaking things....
1882
1883 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1884
1885         Add support to import w3c tests from a repository with a different root that the main repo dir
1886         https://bugs.webkit.org/show_bug.cgi?id=151751
1887
1888         Reviewed by Ryosuke Niwa and Youenn Fablet.
1889
1890         We should be able to import tests from repositories that are not pure test repositories and where tests are kept
1891         in a different directory than the repository root.
1892
1893         This patch introduces a new parameter tests_directory that we will use as root directory to search for
1894         tests. All paths will be flattened when copying tests to have a less complicated directory structure. This
1895         requires having the copy_path lists including tuples of origin and destination directories.
1896
1897         * Scripts/webkitpy/w3c/test_downloader.py:
1898         (TestDownloader._add_test_suite_paths): Adds the paths as a tuple of origin and destination directory.
1899         (TestDownloader.copy_tests): Uses the origin and destination tuple for the paths to copy when copying files.
1900         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1901         (TestImporterTest.test_tests_directory): Test.
1902
1903 2015-12-07  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1904
1905         Mock TestRepositories in W3C importer tests
1906         https://bugs.webkit.org/show_bug.cgi?id=151938
1907
1908         Reviewed by Youenn Fablet.
1909
1910         The test importer tests should use a fake repository instead of using the real one. The reason why this happened
1911         is because the test repository method reading the file was using the filesystem directly instead of taking the
1912         host one. This patch changes that.
1913
1914         * Scripts/webkitpy/w3c/test_downloader.py:
1915         (TestDownloader.load_test_repositories): Take a filesystem and use it. If we get no filesystem, we use the
1916         default one.
1917         (TestDownloader.__init__): When loading the repositories, pass the host filesystem.
1918         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1919         (TestImporterTest.test_harnesslinks_conversion):
1920         (TestImporterTest.test_submodules_generation): Use a fake test repository file.
1921
1922 2015-12-07  David Kilzer  <ddkilzer@apple.com>
1923
1924         TestNetscapePlugIn: Address review comment on 193607
1925         <http://webkit.org/b/151881>
1926
1927         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1928         (testSetStatus): Initializing std::unique_ptr<char[]> with
1929         nullptr is redundant.
1930
1931 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1932
1933         [GTK] Add webkit_uri_request_get_http_method
1934         https://bugs.webkit.org/show_bug.cgi?id=151601
1935
1936         Reviewed by Martin Robinson.
1937
1938         Add test case to check HTTP method of WebKitURIRequest.
1939
1940         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1941         (testURIRequestHTTPMethod):
1942         (serverCallback):
1943         (beforeAll):
1944         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1945         (sendRequestCallback):
1946
1947 2015-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1948
1949         [GTK] Add WebKitWebPage::console-message-sent signal to Web Extensions API
1950         https://bugs.webkit.org/show_bug.cgi?id=79918
1951
1952         Reviewed by Gustavo Noronha Silva.
1953
1954         Add unit tests to check the different console messages.
1955
1956         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1957         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp: Added.
1958         (ConsoleMessageTest::ConsoleMessage::operator==):
1959         (ConsoleMessageTest::consoleMessageReceivedCallback):
1960         (ConsoleMessageTest::ConsoleMessageTest):
1961         (ConsoleMessageTest::~ConsoleMessageTest):
1962         (ConsoleMessageTest::waitUntilConsoleMessageReceived):
1963         (testWebKitConsoleMessageConsoleAPI):
1964         (testWebKitConsoleMessageJavaScriptException):
1965         (testWebKitConsoleMessageNetworkError):
1966         (testWebKitConsoleMessageSecurityError):
1967         (beforeAll):
1968         (afterAll):
1969         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1970         (consoleMessageSentCallback):
1971         (pageCreatedCallback):
1972
1973 2015-12-07  Ryuan Choi  <ryuan.choi@navercorp.com>
1974
1975         [EFL] MiniBrowser doesn't exit when called ewk_view_try_close()
1976         https://bugs.webkit.org/show_bug.cgi?id=151934
1977
1978         Reviewed by Csaba Osztrogonác.
1979
1980         * MiniBrowser/efl/main.c:
1981         (on_window_deletion): Revert the changes of r192767.
1982
1983 2015-12-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1984
1985         [GTK] update-webkitgtk-libs cannot build mesa
1986         https://bugs.webkit.org/show_bug.cgi?id=151535
1987
1988         Reviewed by Martin Robinson.
1989
1990         Upgrade to newer mesa in order to build successfully against LLVM 3.7. Add missing
1991         dependency of mesa on LLVM, to ensure LLVM is built first. Build LLVM unconditionally, even
1992         on architectures where FTL is not supported, to ensure mesa is always buildable, since LLVM
1993         does not have a stable API and we cannot expect mesa to be buildable unless we control the
1994         LLVM version. Build mesa with --disable-egl since --enable-egl conflicts with
1995         --enable-xlib-glx. This fixes update-webkitgtk-libs on distros with LLVM 3.7.
1996
1997         * gtk/jhbuild.modules:
1998
1999 2015-12-07  Philippe Normand  <pnormand@igalia.com>
2000
2001         [GTK][Mac] libWebExtensionTest link error
2002         https://bugs.webkit.org/show_bug.cgi?id=150802
2003
2004         Reviewed by Carlos Garcia Campos.
2005
2006         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: add dependencies to the webextension library.
2007
2008 2015-12-06  David Kilzer  <ddkilzer@apple.com>
2009
2010         TestNetscapePlugIn: Fix leaks found by static analyzer
2011         <http://webkit.org/b/151881>
2012
2013         Reviewed by Darin Adler.
2014
2015         Fixes the following leaks found by the static analyzer:
2016             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'path'
2017                     return false;
2018                            ^~~~~
2019             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'target'
2020                     return false;
2021                            ^~~~~
2022             DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:808:16: warning: Potential leak of memory pointed to by 'url'
2023                     return false;
2024                            ^~~~~
2025
2026         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2027         (toCString): Switch to returning std::unique_ptr<char[]>.  Add
2028         early return if allocation fails.
2029         (testPostURLFile): Switch to using std::unique_ptr<char[]>.
2030         Make sure to call fclose() on filehandle, even for an early
2031         return.
2032         (testSetStatus): Switch to using std::unique_ptr<char[]>.
2033
2034 2015-12-05  David Kilzer  <ddkilzer@apple.com>
2035
2036         prepare-ChangeLog: Fix some warning messages when using svn
2037         <http://webkit.org/b/151914>
2038
2039         Reviewed by Daniel Bates.
2040
2041         * Scripts/prepare-ChangeLog:
2042         (generateFunctionLists): Simplify logic so that we never call
2043         normalizePath() with an undefined value.
2044         (attributeCommand): Quote $subPath for the shell so that we
2045         don't try to run "svn propget" on invalid paths.
2046
2047 2015-12-04  David Kilzer  <ddkilzer@apple.com>
2048
2049         TestNetscapePlugIn: Fix remaining static analyzer warnings
2050         <http://webkit.org/b/151888>
2051
2052         Reviewed by Alexey Proskuryakov.
2053
2054         Fixes the following static analyzer warnings:
2055             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:101:9: warning: Called function pointer is null (null dereference)
2056                     CRASH();
2057                     ^~~~~~~
2058             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:46:5: note: expanded from macro 'CRASH'
2059                 ((void(*)())0)(); /* More reliable, but doesn't say BBADBEEF */ \
2060                 ^~~~~~~~~~~~~~~~
2061             Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:375:12: warning: Access to field 'pluginTest' results in a dereference of a null pointer (loaded from variable 'obj')
2062                 return obj->pluginTest->NPP_SetWindow(window);
2063                        ^~~~~~~~~~~~~~~
2064             2 warnings generated.
2065
2066         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2067         (CRASH): Use __builtin_trap() for gcc/clang.
2068         (NPP_SetWindow): Add early return if obj is nullptr.
2069
2070 2015-12-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2071
2072         [GTK] Test /webkit2/WebKitWebResource/get-data is flaky
2073         https://bugs.webkit.org/show_bug.cgi?id=151797
2074
2075         Reviewed by Martin Robinson.
2076
2077         Since we switched to use the network process to run the unit tests
2078         the test /webkit2/WebKitWebResource/get-data sometimes fails and
2079         sometimes passes. We are now also getting the notification for the
2080         css image. Since we wait for 3 resources, sometimes the css image
2081         is loaded before and then checkResourceData is called for it, but
2082         not handled. When the css image is the last one loaded the test
2083         passes. So, we just need to wait for the 4 resources.
2084
2085         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2086         (testWebResourceGetData):
2087
2088 2015-12-03  David Kilzer  <ddkilzer@apple.com>
2089
2090         DumpRenderTree: Use-after-free in createBitmapContext() in PixelDumpSupportMac.mm
2091         <http://webkit.org/b/151845>
2092
2093         Reviewed by Simon Fraser.
2094
2095         Fixes the following static analyzer warning:
2096             DumpRenderTree/mac/PixelDumpSupportMac.mm:67:9: warning: Use of memory after it is freed
2097                     WTFLogAlways("DumpRenderTree: CGBitmapContextCreate(%p, %llu, %llu, 8, %llu, %p, 0x%x) failed\n", buffer, pixelsHigh, pixelsWide, rowBytes, colorSpace.get(), kCGImageAlphaPremultipliedFirst | kCGBitmapByteOrder32Host);
2098                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2099
2100         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2101         (createBitmapContext): Free 'buffer' after using it in logging
2102         to fix the use-after-free.  Assign a value of nullptr to buffer
2103         so we don't return with it set to a freed address.
2104
2105 2015-12-03  Jer Noble  <jer.noble@apple.com>
2106
2107         Expose WebCore's InvisibleAutoplayNotPermitted setting to WebKit & WebKit2
2108         https://bugs.webkit.org/show_bug.cgi?id=151830
2109
2110         Reviewed by Anders Carlsson.
2111
2112         Set invisibleAutoplayNotPermitted to NO by default both in WKTR and DRT.
2113
2114         * DumpRenderTree/mac/DumpRenderTree.mm:
2115         (resetWebPreferencesToConsistentValues):
2116         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2117         (WTR::initializeWebViewConfiguration):
2118
2119 2015-12-03  Anders Carlsson  <andersca@apple.com>
2120
2121         Remove Objective-C GC support
2122         https://bugs.webkit.org/show_bug.cgi?id=151819
2123         rdar://problem/23746991
2124
2125         Reviewed by Dan Bernstein.
2126
2127         * asan/asan.xcconfig:
2128
2129 2015-12-02  Yusuke Suzuki  <utatane.tea@gmail.com>
2130
2131         Allow nil for unspecified benchmark pathes
2132         https://bugs.webkit.org/show_bug.cgi?id=151784
2133
2134         Reviewed by Filip Pizlo.
2135
2136         `Pathname.new(nil)` will raise an error.
2137         Only generate Pathname if the benchmark path is specified.
2138
2139         * Scripts/run-jsc-benchmarks:
2140
2141 2015-12-02  Brent Fulgham  <bfulgham@apple.com>
2142
2143         [Win] Run non-http tests without Cygwin
2144         https://bugs.webkit.org/show_bug.cgi?id=151721
2145
2146         Reviewed by Andy Estes.
2147
2148         Support native 32-bit and 64-bit Python (and Perl) builds
2149         for running tests:
2150
2151         1. Use "startswith('win')", rather than "== 'win32'" to support
2152         various Windows build types.
2153         2. Supply full path for some native Windows utilities, since the
2154         path environment does not always have the specified, and they are
2155         guaranteed to exist in those specific locations.
2156         3. Make sure native Windows Python test runs pass proper environment
2157         variables to run programs.
2158         4. Append 'exe' suffix when running Windows executables.
2159         5. Use the _winreg Python module on Windows, since the Cygwin 'regtool'
2160         command doesn't exist.
2161         
2162         * Scripts/update-webkit: Use Perl $^X command to refer to the path of
2163         the current Perl executable, rather than requiring a new path search.
2164         * Scripts/webkitpy/common/find_files_unittest.py:
2165         (TestWinNormalize.test_win): Use startswith('win').
2166         * Scripts/webkitpy/common/prettypatch_unittest.py:
2167         (test_pretty_diff_encodings): Ditto.
2168         * Scripts/webkitpy/common/system/executive.py:
2169         (Executive._should_close_fds): Ditto.
2170         (Executive.shell_command_for_script): Use startswith('win').
2171         (Executive.kill_process): Use full path to killall executable.
2172         (Executive.check_running_pid): Use startswith('win').
2173         (Executive.running_pids): Ditto.
2174         (Executive.kill_all): Ditto. Also use path to 'killall' executable when
2175         running under native Windows Python.
2176         (Executive._child_process_encoding): Use startswith('win').
2177         (Executive._should_encode_child_process_arguments): Ditto.
2178         (Executive.popen): Recognize proper script engine on Windows, since it
2179         does not support the shebang syntax.
2180         (Executive.run_in_parallel): Use startswith('win').
2181         * Scripts/webkitpy/common/system/executive_unittest.py:
2182         (never_ending_command): Ditto.
2183         (ExecutiveTest.test_run_command_with_unicode): Ditto.
2184         (ExecutiveTest.serial_test_kill_process): Ditto.
2185         (ExecutiveTest.serial_test_kill_all): Ditto.
2186         (ExecutiveTest.serial_test_check_running_pid): Ditto.
2187         (ExecutiveTest.serial_test_run_in_parallel): Ditto.
2188         (main): Ditto.
2189         * Scripts/webkitpy/common/system/file_lock.py:
2190         (FileLock._create_lock): Ditto.
2191         (FileLock._remove_lock): Ditto.
2192         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2193         (RealFileSystemTest.test_chdir): Ditto.
2194         (RealFileSystemTest.test_chdir__notexists): Ditto.
2195         (RealFileSystemTest.test_maybe_make_directory__failure): Ditto.
2196         * Scripts/webkitpy/common/system/path_unittest.py:
2197         (AbspathTest.test_abspath_to_uri_win): Ditto.
2198         * Scripts/webkitpy/common/system/platforminfo.py:
2199         (PlatformInfo._determine_os_name): Ditto.
2200         * Scripts/webkitpy/common/system/user.py: Ditto.
2201         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2202         (ManagerTest.integration_test_needs_servers): Ditto.
2203         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2204         (LayoutTestApacheHttpd.__init__): Handle upper and lower-case
2205         driver letters.
2206         (LayoutTestApacheHttpd._get_apache_config_file_path): Ditto.
2207         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
2208         (TestLayoutTestApacheHttpd.test_start_cmd): Ditto.
2209         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2210         (HttpServerBase._check_that_all_ports_are_available): Ditto.
2211         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2212         (TestHttpServer.test_start_cmd): Ditto.
2213         * Scripts/webkitpy/port/base.py:
2214         (Port.to.setup_environ_for_server): Include 'COMSPEC', 'SYSTEMDRIVE',
2215         and 'SYSTEMROOT' in environment passed to test runners.
2216         (Port._apache_config_file_name_for_platform): Use startswith('win').
2217         (Port._build_path): Ditto.
2218         (Port._path_to_driver): Include 'exe' suffix when running under native
2219         Windows.
2220         * Scripts/webkitpy/port/driver.py:
2221         (Driver._setup_environ_for_driver): Explicitly make some environment
2222         variables strings.
2223         * Scripts/webkitpy/port/server_process.py:
2224         (ServerProcess.__init__): Use startswith('win').
2225         * Scripts/webkitpy/port/win.py:
2226         (WinPort): Use the win32 registry utilities on Windows, and appropriate
2227         registry key formats.
2228         (WinPort._ntsd_location): Revise tool search paths for Windows 10.
2229         (WinPort.read_registry_value): Revise to use _winreg library on Windows,
2230         and regtool on Cygwin.
2231         (WinPort.write_registry_value): Ditto.
2232         (WinPort.setup_crash_log_saving): Ditto.
2233         (WinPort.restore_crash_log_saving): Ditto.
2234         (WinPort.prevent_error_dialogs): Ditto.
2235         (WinPort.allow_error_dialogs): Ditto.
2236         (WinPort.find_system_pid): Revise to use Windows management
2237         infrastructure on native Windows, continue using 'ps' on Cygwin.
2238         (WinPort.read_registry_string): Deleted.
2239         (WinPort.write_registry_string): Deleted.
2240         * Scripts/webkitpy/test/main.py:
2241         (main): Use startswith('win').
2242         (Tester._parse_args): Ditto.
2243
2244 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
2245
2246         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
2247         https://bugs.webkit.org/show_bug.cgi?id=150792
2248
2249         Reviewed by Saam Barati.
2250
2251         * Scripts/webkitperl/FeatureList.pm:
2252
2253 2015-12-01  Commit Queue  <commit-queue@webkit.org>
2254
2255         Unreviewed, rolling out r192914.
2256         https://bugs.webkit.org/show_bug.cgi?id=151734
2257
2258         JSC tests for this change are failing on 32 and 64-bit bots
2259         (Requested by ryanhaddad on #webkit).
2260
2261         Reverted changeset:
2262
2263         "[ES6] Implement LLInt/Baseline Support for ES6 Generators and
2264         enable this feature"
2265         https://bugs.webkit.org/show_bug.cgi?id=150792
2266         http://trac.webkit.org/changeset/192914
2267
2268 2015-12-01  David Kilzer  <ddkilzer@apple.com>
2269
2270         EventSenderProxy::swipeGestureWithWheelAndMomentumPhases() leaks an EventSenderSyntheticEvent
2271         <http://webkit.org/b/151726>
2272
2273         Reviewed by Simon Fraser.
2274
2275         * WebKitTestRunner/mac/EventSenderProxy.mm:
2276         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
2277         Deploy RetainPtr<EventSenderSyntheticEvent> to fix leak.
2278
2279 2015-12-01  Myles C. Maxfield  <mmaxfield@apple.com>
2280
2281         Give String and AtomicString an existingHash() function
2282         https://bugs.webkit.org/show_bug.cgi?id=151717
2283
2284         Reviewed by Andreas Kling.
2285
2286         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
2287         (TestWebKitAPI::TEST):
2288         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2289         (TestWebKitAPI::TEST):
2290
2291 2015-12-01  Yusuke Suzuki  <utatane.tea@gmail.com>
2292
2293         [ES6] Implement LLInt/Baseline Support for ES6 Generators and enable this feature
2294         https://bugs.webkit.org/show_bug.cgi?id=150792
2295
2296         Reviewed by Saam Barati.
2297
2298         * Scripts/webkitperl/FeatureList.pm:
2299
2300 2015-12-01  Sam Weinig  <sam@webkit.org>
2301
2302         Need completionHandler-based WebKit C SPI for alert, confirm, and prompt
2303         <rdar://problem/23320863>
2304         https://bugs.webkit.org/show_bug.cgi?id=151708
2305
2306         Reviewed by Anders Carlsson.
2307
2308         * WebKitTestRunner/TestController.cpp:
2309         (WTR::TestController::createOtherPage):
2310         (WTR::TestController::createWebViewWithOptions):
2311         Update for new WKPageUIClient.
2312
2313 2015-12-01  Anders Carlsson  <andersca@apple.com>
2314
2315         Remove WebKit2.framework
2316         https://bugs.webkit.org/show_bug.cgi?id=151715
2317
2318         Reviewed by Dan Bernstein.
2319
2320         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
2321         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
2322         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
2323         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2324         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
2325         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
2326         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
2327
2328 2015-12-01  Joseph Pecoraro  <pecoraro@apple.com>
2329
2330         Unreviewed common typo fix "occurance" => "occurrence".
2331
2332         * Scripts/webkitpy/tool/commands/queries.py:
2333         (FindFlakyTests._print_statistics):
2334
2335 2015-11-30  Alex Christensen  <achristensen@webkit.org>
2336
2337         Make ProcessModel always MultipleSecondaryProcesses
2338         https://bugs.webkit.org/show_bug.cgi?id=151662
2339
2340         Reviewed by Antti Koivisto.
2341
2342         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2343         (TestWebKitAPI::TEST):
2344         * WebKitTestRunner/TestController.cpp:
2345         (WTR::TestController::generatePageConfiguration):
2346
2347 2015-11-30  Alex Christensen  <achristensen@webkit.org>
2348
2349         Make usesNetworkProcess always true
2350         https://bugs.webkit.org/show_bug.cgi?id=151580
2351
2352         Reviewed by Darin Adler.
2353
2354         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2355         (TestWebKitAPI::TEST):
2356         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
2357         (TestWebKitAPI::TEST):
2358         * WebKitTestRunner/TestController.cpp:
2359         (WTR::TestController::generatePageConfiguration):
2360
2361 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2362
2363         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/editable/editable in Debug.
2364
2365         Add a way to skip unit tests only for Debug or Release builds and
2366         skipt the test /webkit2/WebKitWebView/editable/editable only for Debug.
2367
2368         * Scripts/run-gtk-tests:
2369         (SkippedTest):
2370         (SkippedTest.__init__):
2371         (SkippedTest.__str__):
2372         (SkippedTest.skip_entire_suite):
2373         (SkippedTest.skip_for_build_type):
2374         (TestRunner):
2375         (TestRunner.__init__):
2376
2377 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2378
2379         Unreviewed. Fix a crash in GTK+ test /webkit2/WebKitWebView/custom-charset.
2380
2381         It's an assert hit because we are reloading a view loaded with
2382         HTML data which is not supported. Use loadURI instead.
2383
2384         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2385         (testWebViewCustomCharset):
2386
2387 2015-11-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2388
2389         [GLIB] Remove GMainLoopSource and GThreadSafeMainLoopSource
2390         https://bugs.webkit.org/show_bug.cgi?id=151633
2391
2392         Reviewed by Csaba Osztrogonác.
2393
2394         * TestWebKitAPI/PlatformGTK.cmake:
2395         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Removed.
2396
2397 2015-11-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2398
2399         [GTK] Remove the remaining uses of GMainLoopSource
2400         https://bugs.webkit.org/show_bug.cgi?id=151632
2401
2402         Reviewed by Žan Doberšek.
2403
2404         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2405         (testWebViewSyncRequestOnMaxConns):
2406         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2407         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2408         (WTR::TestRunner::TestRunner):
2409         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2410         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2411         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
2412         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2413         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2414         (WTR::timeoutSource):
2415         (WTR::TestController::notifyDone):
2416         (WTR::TestController::platformRunUntil):
2417
2418 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
2419
2420         [cmake] Add testb3 to the build system
2421         https://bugs.webkit.org/show_bug.cgi?id=151619
2422
2423         Reviewed by Gyuyoung Kim.
2424
2425         * Scripts/build-jsc:
2426
2427 2015-11-27  Csaba Osztrogonác  <ossy@webkit.org>
2428
2429         [jhbuild] Fix pixman build with clang
2430         https://bugs.webkit.org/show_bug.cgi?id=151441
2431
2432         Reviewed by Carlos Garcia Campos.
2433
2434         * efl/jhbuild.modules:
2435         * gtk/jhbuild.modules:
2436
2437 2015-11-26  David Kilzer  <ddkilzer@apple.com>
2438
2439         Extract prependToEnvironmentVariableList
2440         <http://webkit.org/b/151536>
2441
2442         Reviewed by Daniel Bates.
2443
2444         Tests: webkitdirs_unittest/appendToEnvironmentVariableList.pl
2445                webkitdirs_unittest/prependToEnvironmentVariableList.pl
2446
2447         * Scripts/webkitdirs.pm: Export appendToEnvironmentVariableList
2448         and prependToEnvironmentVariableList.
2449         (appendToEnvironmentVariableList): Simplify variable name.
2450         Switch to use $Config{path_sep}.
2451         (prependToEnvironmentVariableList): Add new method.
2452         (setupMacWebKitEnvironment): Switch to use
2453         prependToEnvironmentVariableList().
2454         (setupIOSWebKitEnvironment): Ditto.
2455
2456         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl: Added.
2457         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl: Added.
2458
2459 2015-11-24  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2460
2461         REGRESSION(r192053): MiniBrowser doesn't exit when clicking on the close-window button
2462         https://bugs.webkit.org/show_bug.cgi?id=151567
2463
2464         Reviewed by Darin Adler.
2465
2466         * MiniBrowser/efl/main.c: Call window_close() instead of ewk_view_try_close().
2467         (on_window_deletion):
2468
2469 2015-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2470
2471         [GTK] Use the network process unconditionally
2472         https://bugs.webkit.org/show_bug.cgi?id=151541
2473
2474         Reviewed by Alex Christensen.
2475
2476         Fix TestInspectorServer test. Do not assume we already have the
2477         title we want when the page has been loaded, since the title is
2478         changed afterwards. So, check if the title has already been set,
2479         and if not wait for it.
2480
2481         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
2482         (openRemoteDebuggingSession):
2483
2484 2015-11-23  Alex Christensen  <achristensen@webkit.org>
2485
2486         Fix crash in ~WebProcessPool when using Geolocation with useNetworkProcess=true
2487         https://bugs.webkit.org/show_bug.cgi?id=151532
2488
2489         Reviewed by Benjamin Poulain.
2490
2491         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2492         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
2493         (TestWebKitAPI::TEST):
2494         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
2495         (TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker): Deleted.
2496         (TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker): Deleted.
2497         Properly load about:blank in all WebViews to clean up.  Without this change, we had a 
2498         Geolocation provider stopping after its state tracker was destroyed with its stack frame,
2499         so it was calling a function on a test object that had gone out of scope.
2500         Also, call WKContextSetUsesNetworkProcess(context, true) to show what crash this fixed,
2501         but that will become the default soon and that call will be removed.
2502
2503 2015-11-22  David Kilzer  <ddkilzer@apple.com>
2504
2505         run-webkit-tests: http server for imported W3C tests doesn't work with --layout-tests-directory switch
2506         <http://webkit.org/b/151542>
2507
2508         Reviewed by Daniel Bates.
2509
2510         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2511         (base_url): Use the Port object (already passed in) to give us
2512         the path to the LayoutTests directory, which already checks for a
2513         --layout-tests-directory command-line switch.
2514         (WebPlatformTestServer.__init__): Remove layout_test_results_dir
2515         argument since we can get this from the Port object already
2516         passed in via Port.results_directory().  Also switch to use
2517         Port.layout_tests_dir() to get the LayoutTests directory.
2518
2519         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
2520         (TestWebPlatformTestServer.test_custom_layout_tests_directory):
2521         Add test case for custom LayoutTests directory.
2522         (TestWebPlatformTestServer.test_previously_spawned_instance):
2523         Update Port object to set mock results directory as if it was
2524         set on the command-line.  Remove unneeded argument from
2525         WebPlatformTestServer constructor.
2526         (TestWebPlatformTestServer.test_corrupted_subserver_files): Ditto.
2527
2528         * Scripts/webkitpy/port/base.py:
2529         (Port.to.start_web_platform_test_server): Remove unneeded
2530         argument from WebPlatformTestServer constuctor.
2531
2532 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2533
2534         [GTK] Some unit tests fail when using the network process
2535         https://bugs.webkit.org/show_bug.cgi?id=151490
2536
2537         Reviewed by Martin Robinson.
2538
2539         Run the soup server in a separate thread in TestResources test to
2540         avoid deadlocks.
2541
2542         This fixes /webkit2/WebKitWebView/sync-request-on-max-conns and
2543         /webkit2/WebKitWebResource/get-data when using the network process.
2544
2545         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2546         (beforeAll): Create the WebKitTestServer with ServerRunInThread flag.
2547         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
2548         (WebKitTestServer::WebKitTestServer): When ServerRunInThread is
2549         present, create a WorkQueue to run the server.
2550         (WebKitTestServer::run): Run the server in the work queue if it
2551         has been created.
2552         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h: Convert server
2553         type into server options as flags.
2554
2555 2015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2556
2557         [GTK] ImageDiff should normalize the diff image
2558         https://bugs.webkit.org/show_bug.cgi?id=151261
2559
2560         Reviewed by Sergio Villar Senin.
2561
2562         * ImageDiff/gtk/ImageDiff.cpp:
2563         (readPixbufFromStdin): Fix memory leak.
2564         (differenceImageFromDifferenceBuffer): Normalize diff buffer.
2565         (calculateDifference): Pass max distance to differenceImageFromDifferenceBuffer.
2566
2567 == Rolled over to ChangeLog-2015-11-21 ==