Cleanup: Move js for treemap and aggregate_results into own js files.
[WebKit-https.git] / Tools / ChangeLog
1 2013-03-18  Julie Parent  <jparent@chromium.org>
2
3         Cleanup: Move js for treemap and aggregate_results into own js files.
4         https://bugs.webkit.org/show_bug.cgi?id=112618
5
6         Reviewed by Dirk Pranke.
7         
8         No functional changes, just moving the code into separate js file
9         rather than inlined in the html, so we can test it, make it more
10         modular, etc.  Other dashboard types are already done this way.
11
12         * TestResultServer/static-dashboards/aggregate_results.html:
13         * TestResultServer/static-dashboards/aggregate_results.js: Copied from Tools/TestResultServer/static-dashboards/aggregate_results.html.
14         (generatePage):
15         (handleValidHashParameter):
16         (htmlForBuilder):
17         (rawValuesHTML):
18         (chartHTML):
19         (filteredValues):
20         (chart):
21         (htmlForRevisionRows):
22         (wrapHTMLInTable):
23         (htmlForSummaryTable):
24         (valuesPerExpectation):
25         (htmlForTestType):
26         (htmlForTableRow):
27         (extendedEncode):
28         * TestResultServer/static-dashboards/treemap.html:
29         * TestResultServer/static-dashboards/treemap.js: Copied from Tools/TestResultServer/static-dashboards/treemap.html.
30         (humanReadableTime):
31         (convertToWebTreemapFormat):
32         (reverseSortByAverage):
33         (generatePage):
34         (focusPath):
35         (.switch.return):
36         (handleQueryParameterChange):
37         (extractName):
38         (fullName):
39         (handleFocus.):
40         (handleFocus):
41
42 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
43
44         [webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
45         https://bugs.webkit.org/show_bug.cgi?id=112622
46
47         Reviewed by Dirk Pranke.
48
49         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
50         (HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.
51
52 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
53
54         [NRWT][GTK] Add gtk-wk1 directory to the list of baseline search paths when using DumpRenderTree
55         https://bugs.webkit.org/show_bug.cgi?id=112619
56
57         Reviewed by Dirk Pranke.
58
59         When using DumpRenderTree on the Gtk port, NRWT should look for baselines first in the LayoutTests/platform/gtk-wk1
60         directory and then fall back to the generic LayoutTests/platform/gtk directory.
61
62         * Scripts/webkitpy/layout_tests/port/gtk.py:
63         (GtkPort.default_baseline_search_path): Implement the method on the GtkPort class, mapping every search path to the
64         Port._webkit_baseline_path method.
65         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
66         (GtkPortTest.test_default_baseline_search_path): Add a test for the changes that are being introduced.
67         (GtkPortTest.test_port_specific_expectations_files): Wrap a couple of long lines.
68         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
69         (TestRebaselineTest.test_baseline_directory): Enhance one and add an additional test case for baseline directories
70         that are expected based on the builder name.
71
72 2013-03-18  Mark Pilgrim  <pilgrim@chromium.org>
73
74         [Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring
75         https://bugs.webkit.org/show_bug.cgi?id=112571
76
77         Reviewed by Adam Barth.
78
79         Update function declarations for new WebFileSystemType enum. (All
80         changes are behind an #ifdef so we can sync required changes in embedders.)
81
82         * DumpRenderTree/chromium/WebViewHost.cpp:
83         (WebViewHost::openFileSystem):
84         (WebViewHost::deleteFileSystem):
85         * DumpRenderTree/chromium/WebViewHost.h:
86         (WebViewHost):
87
88 2013-03-18  Julie Parent  <jparent@chromium.org>
89
90         Cleanup: Move timeline_exporer js out of html file into js.
91         https://bugs.webkit.org/show_bug.cgi?id=112188
92
93         Reviewed by Dirk Pranke.
94         
95         Moves the javascript out of the html file and into a new js file.
96         This follows the format of flakiness_dashboard.{html|js}.
97         
98         Also moves code from dashboard_base that is used only by this one
99         dashboard, and makes it private to the dashboard.
100
101         * TestResultServer/static-dashboards/dashboard_base.js:
102         * TestResultServer/static-dashboards/timeline_explorer.html:
103         * TestResultServer/static-dashboards/timeline_explorer.js: Copied from Tools/TestResultServer/static-dashboards/timeline_explorer.html.
104         (generatePage):
105         (initCurrentBuilderTestResults):
106         (shouldShowWebKitRevisionsOnly):
107         (updateTimelineForBuilder.):
108         (updateTimelineForBuilder):
109         (selectBuild):
110         (updateBuildIndicator):
111         (.addRow):
112         (.addNumberRow):
113         (.inspectorNode.getElementsByTagName.0.onclick):
114         (.inspectorNode.getElementsByTagName.1.onclick):
115         (.inspectorNode.getElementsByTagName.2.onclick):
116         (updateBuildInspector):
117         (showResultsDelta):
118         (decompressResults.addFlakyDelta):
119         (decompressResults):
120
121 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
122
123         Unreviewed, rolling out r145272.
124         http://trac.webkit.org/changeset/145272
125         https://bugs.webkit.org/show_bug.cgi?id=111884
126
127         Turns out the ASAN build is still broken; possibly there's
128         something still setting LD_LIBRARY_PATH, or possibly there's
129         something else wrong. In the meantime, we need it to work again.
130
131         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
132
133 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
134
135         delete-stale-build-files is too aggressive
136         https://bugs.webkit.org/show_bug.cgi?id=112595
137
138         Reviewed by Tim Horton.
139
140         It appears that whitelisting file extensions to keep is not a good idea.
141         Blacklist files to delete instead, and only delete .o files for now.
142         We can add more file extensions as needed.
143
144         * BuildSlaveSupport/delete-stale-build-files:
145
146 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
147
148         Disable accessibility notifications after each test
149         https://bugs.webkit.org/show_bug.cgi?id=112579
150
151         Reviewed by Tim Horton.
152         
153         In WebKitTestRunner, if any tests triggered accessibility notifications,
154         the global notification handler would thereafter be active, and fire
155         notifications for all subsequent tests.
156         
157         Fix by implementing AccessibilityController::resetToConsistentState() for
158         Mac, and using it to clear the global notification handler.
159
160         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
161         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
162         (WTR::AccessibilityController::addNotificationListener): Remove stupid comment.
163         (WTR::AccessibilityController::removeNotificationListener): Explicitly call
164         -stopObserving so that unregistering the observer doesn't rely on object lifetimes
165         (e.g. because of -autorelease).
166         (WTR::AccessibilityController::logAccessibilityEvents): Stub.
167         (WTR::AccessibilityController::resetToConsistentState): Remove the notification listener
168         if there is one.
169         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h:
170         Add -stopObserving
171         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
172         (-[AccessibilityNotificationHandler dealloc]): Call -stopObserving
173         (-[AccessibilityNotificationHandler stopObserving]): Unregister from the notification
174         center.
175
176 2013-03-18  Dana Jansens  <danakj@chromium.org>
177
178         [chromium] Remove WebGraphicsContext3DInProcessImpl support from DRT.
179         https://bugs.webkit.org/show_bug.cgi?id=112392
180
181         Reviewed by James Robinson.
182
183         Removes the command line flag option from DRT.
184
185         * DumpRenderTree/chromium/DumpRenderTree.cpp:
186         (main):
187
188 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
189
190         [GTK] plugins/plugin-clip-subframe.html is failing
191         https://bugs.webkit.org/show_bug.cgi?id=112570
192
193         Reviewed by Martin Robinson.
194
195         * GNUmakefile.am: Add the LogNPPSetWindow.cpp file to the build.
196
197 2013-03-17  Morten Stenshorne  <mstensho@opera.com>
198
199         Add reload button (and F5 accelerator) to the GtkLauncher toolbar
200         https://bugs.webkit.org/show_bug.cgi?id=112442
201
202         Reviewed by Gustavo Noronha Silva.
203
204         * GtkLauncher/main.c:
205         (reloadCb):
206         (createToolbar):
207         (createWindow):
208
209 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
210
211         REGRESSION (r144884?): WebKit2.DOMWindowExtensionBasic API test is asserting
212         https://bugs.webkit.org/show_bug.cgi?id=112205
213
214         Disable this API test until Geoff can fix it.
215
216         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
217         (TestWebKitAPI::TEST):
218
219 2013-03-15  Jochen Eisinger  <jochen@chromium.org>
220
221         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
222         https://bugs.webkit.org/show_bug.cgi?id=112478
223
224         Reviewed by Tony Chang.
225
226         There is nothing that ensures that the log messages from the plugin
227         come in before the layout test finished loading.
228
229         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
230         (PassDifferentNPPStruct::NPP_SetWindow):
231         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
232         (NPP_SetWindow):
233
234 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
235
236         Have the mac port support per_test_timeout in webkitpy
237         https://bugs.webkit.org/show_bug.cgi?id=112466
238
239         Reviewed by Dirk Pranke.
240         
241         Both WTR and DRT handle --timeout arguments, so we can
242         have the scripts pass the timeout values down to the tools.
243
244         * Scripts/webkitpy/layout_tests/port/mac.py:
245         (MacPort.supports_per_test_timeout):
246
247 2013-03-15  Rouslan Solomakhin  <rouslan@chromium.org>
248
249         Remove setAsynchronousSpellCheckingEnabled from test runners
250         https://bugs.webkit.org/show_bug.cgi?id=112362
251
252         Reviewed by Tony Chang.
253
254         Remove setAsynchronousSpellCheckingEnabled from test runners. The setting is now
255         in internals.settings, so all ports can share it.
256
257         * DumpRenderTree/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
258         * DumpRenderTree/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
259         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
260         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
261         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
262         * DumpRenderTree/efl/TestRunnerEfl.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
263         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
264         * DumpRenderTree/mac/TestRunnerMac.mm: Remove setAsynchronousSpellCheckingEnabled() method.
265         * DumpRenderTree/qt/TestRunnerQt.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
266         * DumpRenderTree/qt/TestRunnerQt.h: Remove setAsynchronousSpellCheckingEnabled() method.
267         * DumpRenderTree/win/TestRunnerWin.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
268         * DumpRenderTree/wx/TestRunnerWx.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
269
270 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
271
272         Fix the stupid unit tests.
273
274         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
275         (test_sample_process):
276
277 2013-03-14  Simon Fraser  <simon.fraser@apple.com>
278
279         Collect samples for unresponsive web processes
280         https://bugs.webkit.org/show_bug.cgi?id=112409
281
282         Reviewed by Tim Horton.
283         
284         When we detect that a subprocess was unresponsive, run the 'sample'
285         tool on that process, for the Mac port.
286         
287         The sample will be linked to from the results.html page, next
288         to the crash log link.
289
290         * Scripts/webkitpy/layout_tests/controllers/manager.py:
291         (Manager._look_for_new_crash_logs): Before looking for crash logs,
292         look for samples on disk.
293         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
294         (TestResultWriter):
295         (TestResultWriter.copy_sample_file): Teach TestResultWriter about
296         -sample.txt files, and have it copy their contents to a new file
297         next to the test that spawned them (as we do for crash logs).
298         * Scripts/webkitpy/layout_tests/port/base.py:
299         (Port.look_for_new_samples): Base class does nothing for sampling.
300         * Scripts/webkitpy/layout_tests/port/driver.py:
301         (Driver._check_for_driver_crash): Kick off a sample if we detected
302         that the subprocess was unresponsive.
303         * Scripts/webkitpy/layout_tests/port/mac.py:
304         (MacPort.sample_file_path): Utility to generate the file path
305         to the generated sample files at the top level of layout-test-results.
306         (MacPort.look_for_new_crash_logs): Fix typo
307         (MacPort.look_for_new_samples): New function to find sample files.
308         (MacPort.sample_process): Use the utility function to get the file path.
309
310 2013-03-15  Zeno Albisser  <zeno@webkit.org>
311
312         [Qt] Remove simple getters and setters from TestRunnerQt
313         https://bugs.webkit.org/show_bug.cgi?id=112343
314
315         Reviewed by Benjamin Poulain.
316
317         The removed functions and boolean members
318         are being replaced by the implementations in the
319         generic TestRunner.h.
320
321         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
322         (DumpRenderTree::dumpFrameScrollPosition):
323         (DumpRenderTree::dumpFramesAsText):
324         (DumpRenderTree::dump):
325         (DumpRenderTree::titleChanged):
326         (DumpRenderTree::dumpDatabaseQuota):
327         (DumpRenderTree::dumpApplicationCacheQuota):
328         (DumpRenderTree::statusBarMessage):
329         (DumpRenderTree::createWindow):
330         * DumpRenderTree/qt/TestRunnerQt.cpp:
331         (TestRunnerQt::reset):
332         * DumpRenderTree/qt/TestRunnerQt.h:
333         (TestRunnerQt):
334
335 2013-03-15  Ryosuke Niwa  <rniwa@webkit.org>
336
337         Update the link on build.webkit.org to refer to perf.webkit.org
338         https://bugs.webkit.org/show_bug.cgi?id=112416
339
340         Reviewed by Philip Rogers.
341
342         Updated the link. Also updated the template to use HTML5 DOCTYPE.
343
344         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
345
346 2013-03-15  Tobias Mueller  <tobiasmue@gnome.org>
347
348         Build fix for Tools/GtkLauncher/Programs_GtkLauncher-main.o if gstreamer is not installed
349         https://bugs.webkit.org/show_bug.cgi?id=112394
350
351         Reviewed by Philippe Normand.
352
353         * GtkLauncher/main.c:
354         (main): Guard using the gstreamer function with #ifdef WTF_USE_GSTREAMER
355
356 2013-03-14  Andreas Kling  <akling@apple.com>
357
358         REGRESSION(r145169): [Mac][WK2] http/tests/security/cross-frame-access-put.html fails.
359         <http://webkit.org/b/111815>
360         <rdar://problem/13380145>
361
362         Reviewed by Anders Carlsson.
363
364         Add PlatformWebView::didInitializeClients() and call it after setting up all the clients
365         after creating a PlatformWebView. Otherwise, the initial WindowAndViewFramesChanged message
366         will be sent before there's a UI client set up to adjust the frame with WTR's fake origin.
367
368         * WebKitTestRunner/PlatformWebView.h:
369         (PlatformWebView):
370         * WebKitTestRunner/TestController.cpp:
371         (WTR::TestController::createOtherPage):
372         (WTR::TestController::createWebViewWithOptions):
373         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
374         (WTR::PlatformWebView::didInitializeClients):
375
376 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
377
378         [EFL][MiniBrowser] Add a search field to the MiniBrowser
379         https://bugs.webkit.org/show_bug.cgi?id=112122
380
381         Reviewed by Kenneth Rohde Christiansen.
382
383         Implement a search field to test API ewk_view_text_find() and add a shortcut 'ctrl' + f.
384
385         * MiniBrowser/efl/main.c:
386         (_Browser_Window):
387         (search_box_show):
388         (search_box_hide):
389         (on_key_down):
390         (on_url_changed):
391         (on_search_field_aborted):
392         (on_search_field_activated):
393         (on_search_field_clicked):
394         (on_search_backward_button_clicked):
395         (on_search_forward_button_clicked):
396         (window_create):
397
398 2013-03-14  Julie Parent  <jparent@chromium.org>
399
400         Cleanup: Remove g_resourceLoader.
401         https://bugs.webkit.org/show_bug.cgi?id=112305
402
403         Reviewed by Dirk Pranke.
404         
405         Removing another global.
406         
407         Now, each dashboard creates its own loader, rather than having
408         a general global one.
409         
410         Remove usage of g_resourceLoader.isLoadingComplete from 
411         handleLocationChange by ensuring that handleLocationChange is
412         never called before the loader is done.  It was called in two
413         places before: 1 was from the callback when the loader is done,
414         so that was obviously true, and the other was from onhashchange,
415         where it would just return rather than running.  Instead, lets
416         only register the onhashchange handler once the loader is
417         setup, so the check is no longer necessary.
418         
419         Remove isLoadingComplete since it is now unused.
420         
421         Callback for loader is now initializeHistory, rather than just
422         handleLocationChange which will set up the hashchange handler now.
423         This will all eventually be moving to a new History object.
424
425         * TestResultServer/static-dashboards/aggregate_results.html:
426         * TestResultServer/static-dashboards/dashboard_base.js:
427         (handleLocationChange):
428         (intializeHistory):
429         (decompressResults):
430         * TestResultServer/static-dashboards/flakiness_dashboard.js:
431         (generatePage):
432         * TestResultServer/static-dashboards/loader.js:
433         (.):
434         * TestResultServer/static-dashboards/loader_unittests.js:
435         * TestResultServer/static-dashboards/timeline_explorer.html:
436         * TestResultServer/static-dashboards/treemap.html:
437
438 2013-03-14  Manuel Rego Casasnovas  <rego@igalia.com>
439
440         Add selectTrailingWhitespaceEnabled setting to WebCore::Page
441         https://bugs.webkit.org/show_bug.cgi?id=109404
442
443         Reviewed by Tony Chang.
444
445         Removes all the code related to smartInsertDeleteEnabled and
446         selectTrailingWhitespaceEnabled settings as they will be managed from
447         internals from now on.
448
449         * DumpRenderTree/TestRunner.cpp:
450         (TestRunner::staticFunctions):
451         * DumpRenderTree/TestRunner.h:
452         (TestRunner):
453         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
454         (WebKit):
455         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
456         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
457         (DumpRenderTree):
458         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
459         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
460         (WebTestRunner::WebTestProxy::didStopLoading):
461         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
462         (WebTestRunner::TestRunner::TestRunner):
463         (WebTestRunner::TestRunner::reset):
464         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
465         (TestRunner):
466         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
467         (WebTestRunner::WebPreferences::applyTo): Set default values for
468         smartInsertDeleteEnabled and selectTrailingWhitespaceEnabled settings as
469         Chromium DRT default values are different from Chromium browser.
470         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
471         * DumpRenderTree/chromium/WebViewHost.cpp:
472         * DumpRenderTree/chromium/WebViewHost.h:
473         (WebViewHost):
474         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
475         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
476         * DumpRenderTree/efl/TestRunnerEfl.cpp:
477         * DumpRenderTree/gtk/DumpRenderTree.cpp:
478         (resetDefaultsToConsistentValues):
479         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
480         * DumpRenderTree/mac/DumpRenderTree.mm:
481         (resetWebViewToConsistentStateBeforeTesting):
482         * DumpRenderTree/mac/TestRunnerMac.mm:
483         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
484         (WebCore::WebPage::resetSettings):
485         * DumpRenderTree/qt/TestRunnerQt.cpp:
486         * DumpRenderTree/qt/TestRunnerQt.h:
487         (TestRunnerQt):
488         * DumpRenderTree/win/DumpRenderTree.cpp:
489         (resetWebViewToConsistentStateBeforeTesting):
490         * DumpRenderTree/win/TestRunnerWin.cpp:
491         * DumpRenderTree/wx/TestRunnerWx.cpp:
492
493 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
494
495         [Qt] Disable DRT on Windows
496
497         Reviewed by Jocelyn Turcotte.
498
499         We don't run and maintain DRT on Windows, so let's not try to maintain the build of it.
500
501         * qmake/mkspecs/features/configure.prf:
502
503 2013-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
504
505         [EFL][WK2] Add an API for adding and removing user style sheets from a page group
506         https://bugs.webkit.org/show_bug.cgi?id=110728
507
508         Reviewed by Gyuyoung Kim.
509
510         Use the page group to create the view object.
511
512         * MiniBrowser/efl/main.c:
513         (window_create):
514
515 2013-03-14  Simon Hausmann  <simon.hausmann@digia.com>
516
517         [Qt] Improve the handling of mock geolocation, device orientation and motion clients
518
519         Reviewed by Tor Arne Vestbø.
520
521         The mock versions of these web facing features should be instantiated when
522         running in DumpRenderTree only. In order for them to work, no extra Qt modules
523         such as QtLocation are actually needed.
524
525         This patch decouples enabling device orientation/motion and geolocation from
526         the underlying Qt modules and makes them available in developer builds
527         (!production_build) and backed by mock backends when running in drt.
528
529         So if the Qt 5 modules are available, they'll be used (unless drtRun). For
530         developers the web facing features are always enabled (although requests will
531         time out) and the mock backends are enabled inside DRT, allowing for the layout
532         tests to run with less dependencies.
533
534         In addition this also enables the mock device motion client, which was
535         previously never instantiated.
536
537         * qmake/mkspecs/features/features.prf:
538
539 2013-03-14  Zeno Albisser  <zeno@webkit.org>
540
541         [Qt] Removing no-ops and simple setters/getters from TestRunnerQt
542         https://bugs.webkit.org/show_bug.cgi?id=112340
543
544         Reviewed by Simon Hausmann.
545
546         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
547         (DumpRenderTree::dump):
548             Replace shouldDumpBackForwardList() with TestController:dumpBackForwardList().
549         (DumpRenderTree::dumpApplicationCacheQuota):
550         * DumpRenderTree/qt/TestRunnerQt.cpp:
551         (TestRunnerQt::reset):
552         * DumpRenderTree/qt/TestRunnerQt.h:
553         (TestRunnerQt):
554
555 2013-03-14  Zeno Albisser  <zeno@webkit.org>
556
557         [Qt] Port DRT to use TestRunner::dumpAsText()
558         https://bugs.webkit.org/show_bug.cgi?id=112260
559
560         Reviewed by Benjamin Poulain.
561
562         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
563         (WebCore::DumpRenderTree::open):
564         (WebCore::methodNameStringForFailedTest):
565             Change parameter from type TestRunnerQt* to TestRunner*.
566         (WebCore::DumpRenderTree::dump):
567             TestRunnerQt::shouldDumpPixels() always returned true in our case.
568             Instead we should rely on TestRunner::generatePixelResults().
569         * DumpRenderTree/qt/TestRunnerQt.cpp:
570         (TestRunnerQt::reset):
571         * DumpRenderTree/qt/TestRunnerQt.h:
572         (TestRunnerQt):
573
574 2013-03-13  Kunihiko Sakamoto  <ksakamoto@chromium.org>
575
576         Implement FontLoader interface
577         https://bugs.webkit.org/show_bug.cgi?id=98395
578
579         Reviewed by Eric Seidel.
580
581         Enable FontLoadEvents runtime flag for TestShell.
582
583         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
584         (WebTestRunner::TestInterfaces::TestInterfaces):
585
586 2013-03-13  Julie Parent  <jparent@chromium.org>
587
588         CLeanup: remove unnecessary call to parseParameters.
589         https://bugs.webkit.org/show_bug.cgi?id=112309
590
591         Reviewed by Ojan Vafai.
592         
593         We call parseCrossDashboardParameters when the dashboard initially
594         loads to set the state required for loadBuildersList, and then we
595         call it again once we are fully done with loading, so there is no
596         reason to call it in the middle of the loading process here.
597
598         * TestResultServer/static-dashboards/loader.js:
599         (.):
600
601 2013-03-13  Elliott Sprehn  <esprehn@chromium.org>
602
603         Unreviewed. Now I'm a reviewer :)
604
605         * Scripts/webkitpy/common/config/committers.py:
606
607 2013-03-13  Ryosuke Niwa  <rniwa@webkit.org>
608
609         Threaded HTML Parser is missing feature define flags in all but Chromium port's build files
610         https://bugs.webkit.org/show_bug.cgi?id=112277
611
612         Reviewed by Adam Barth.
613
614         * Scripts/webkitperl/FeatureList.pm:
615         * qmake/mkspecs/features/features.pri:
616
617 2013-03-13  Adam Barth  <abarth@webkit.org>
618
619         run-perf-tests should support content_shell
620         https://bugs.webkit.org/show_bug.cgi?id=112291
621
622         Reviewed by Eric Seidel.
623
624         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
625         (PerfTestsRunner._parse_args):
626
627 2013-03-13  Oliver Hunt  <oliver@apple.com>
628
629         Simplify Checked<> multiplication
630         https://bugs.webkit.org/show_bug.cgi?id=112286
631
632         Reviewed by James Robinson.
633
634         Add tests for multiplication by zero and max to ensure we don't
635         mess them up should we ever make changes to Checked<> in future.
636
637         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
638         (TestWebKitAPI):
639
640 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
641
642         [Qt] Unreviewed prospective Windows build fix
643
644         Do the usual thing, include the moc generated code in the .cpp file instead
645         of compiling it standalone, to ensure that config.h is included, too, and
646         NOMINMAX is defined to avoid the min/max conflict when also including qdatetime.h.
647
648         * DumpRenderTree/qt/EventSenderQt.cpp:
649
650 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
651
652         [Qt] Port TestRunner::findString to shared interface
653         https://bugs.webkit.org/show_bug.cgi?id=112147
654
655         Reviewed by Jocelyn Turcotte.
656
657         This patch also removes DumpRenderTree and some other helper classes from
658         the WebCore namespace, to which they do not really belong.
659
660         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
661         (main):
662         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
663         (DumpRenderTree::DumpRenderTree):
664         (DumpRenderTree::~DumpRenderTree):
665         (DumpRenderTree::instance):
666         (DumpRenderTree::setShouldTimeout):
667         * DumpRenderTree/qt/DumpRenderTreeQt.h:
668         (DumpRenderTree):
669         * DumpRenderTree/qt/EventSenderQt.cpp:
670         (EventSender::contextClick):
671         (EventSender::sendEvent):
672         (EventSender::postEvent):
673         * DumpRenderTree/qt/EventSenderQt.h:
674         (EventSender::isGraphicsBased):
675         * DumpRenderTree/qt/TestRunnerQt.cpp:
676         (TestRunnerQt::TestRunnerQt):
677         (TestRunner::findString):
678         (TestRunnerQt::setMockDeviceOrientation):
679         (TestRunnerQt::setGeolocationPermission):
680         (TestRunnerQt::numberOfPendingGeolocationPermissionRequests):
681         (TestRunnerQt::setMockGeolocationPositionUnavailableError):
682         (TestRunnerQt::setMockGeolocationPosition):
683         * DumpRenderTree/qt/TestRunnerQt.h:
684         (TestRunnerQt):
685
686 2013-03-13  Mikhail Naganov  <mnaganov@chromium.org>
687
688         [Chromium] Rename android_build_type to android_webview_build in .gyp files.
689         https://bugs.webkit.org/show_bug.cgi?id=112129
690
691         Reviewed by Adam Barth.
692
693         Following Chromium
694         http://src.chromium.org/viewvc/chrome?view=rev&revision=187556
695         this is being renamed to better explain what it does.
696
697         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
698
699 2013-03-13  Simon Hausmann  <simon.hausmann@digia.com>
700
701         [Qt] Unreviewed trivial typo fix
702
703         * DumpRenderTree/qt/DumpRenderTree.pro: It's TestRunner.h, not
704         TextRunner.h. Thanks Zeno :)
705
706 2013-03-12  Simon Hausmann  <simon.hausmann@digia.com>
707
708         [Qt] Prepare DRT for transition to shared TestRunner interface
709         https://bugs.webkit.org/show_bug.cgi?id=112144
710
711         Reviewed by Benjamin Poulain.
712
713         Prepare Qt's DRT for a transition from the QObject based TestRunner to
714         the JSC C API based one.
715
716         This is impplemented by instantiating the QObject based testRunner in
717         the global object, then instantiating the JSC C based TestRunner
718         separately and placing it "behind" the QObject based testRunner through
719         injection of the individual functions through proxies. (prototype
720         chaining doesn't work due to the this object and Function.prototype.bind
721         doesn't work due to the native function)
722
723         This allows for porting over method by method by removing the method
724         from the QObject TestRunnerQt and implementing it in the JSC C based
725         TestRunner.
726
727         In order for this to link and run dummy implementations of all the
728         necessary TestRunner functions are provided.
729
730         * DumpRenderTree/qt/DumpRenderTree.pro:
731         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
732         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
733         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
734         (WebCore::DumpRenderTree::initJSObjects):
735         * DumpRenderTree/qt/DumpRenderTreeQt.h:
736         (DumpRenderTree):
737         * DumpRenderTree/qt/TestRunnerQt.cpp:
738         (TestRunner::~TestRunner):
739         (TestRunner::addDisallowedURL):
740         (TestRunner::queueLoad):
741         (TestRunner::removeAllVisitedLinks):
742         (TestRunner::setAcceptsEditing):
743         (TestRunner::simulateLegacyWebNotificationClick):
744         (TestRunner::setWindowIsKey):
745         (TestRunner::setAlwaysAcceptCookies):
746         (TestRunner::addOriginAccessWhitelistEntry):
747         (TestRunner::setWebViewEditable):
748         (TestRunner::clearAllApplicationCaches):
749         (TestRunner::setTextDirection):
750         (TestRunner::notifyDone):
751         (TestRunner::numberOfPendingGeolocationPermissionRequests):
752         (TestRunner::overridePreference):
753         (TestRunner::pathToLocalResource):
754         (TestRunner::removeAllWebNotificationPermissions):
755         (TestRunner::simulateWebNotificationClick):
756         (TestRunner::closeIdleLocalStorageDatabases):
757         (TestRunner::focusWebView):
758         (TestRunner::setBackingScaleFactor):
759         (TestRunner::removeChromeInputField):
760         (TestRunner::addChromeInputField):
761         (TestRunner::originsWithLocalStorage):
762         (TestRunner::deleteAllLocalStorage):
763         (TestRunner::deleteLocalStorageForOrigin):
764         (TestRunner::observeStorageTrackerNotifications):
765         (TestRunner::syncLocalStorage):
766         (TestRunner::windowCount):
767         (TestRunner::setWaitToDump):
768         (TestRunner::waitForPolicyDelegate):
769         (TestRunner::webHistoryItemCount):
770         (TestRunner::showWebInspector):
771         (TestRunner::closeWebInspector):
772         (TestRunner::evaluateInWebInspector):
773         (TestRunner::setSerializeHTTPLoads):
774         (TestRunner::apiTestNewWindowDataLoadBaseURL):
775         (TestRunner::setCustomPolicyDelegate):
776         (TestRunner::setDatabaseQuota):
777         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
778         (TestRunner::resetPageVisibility):
779         (TestRunner::keepWebHistory):
780         (TestRunner::goBack):
781         (TestRunner::originsWithApplicationCache):
782         (TestRunner::applicationCacheDiskUsageForOrigin):
783         (TestRunner::display):
784         (TestRunner::dispatchPendingLoadRequests):
785         (TestRunner::clearPersistentUserStyleSheet):
786         (TestRunner::callShouldCloseOnWebView):
787         (TestRunner::copyDecodedHostName):
788         (TestRunner::clearBackForwardList):
789         (TestRunner::clearAllDatabases):
790         (TestRunner::clearApplicationCacheForOrigin):
791         (TestRunner::apiTestGoToCurrentBackForwardItem):
792         (TestRunner::authenticateSession):
793         (TestRunner::abortModal):
794         (TestRunner::setStorageDatabaseIdleInterval):
795         (TestRunner::setAsynchronousSpellCheckingEnabled):
796         (TestRunner::setXSSAuditorEnabled):
797         (TestRunner::setSpatialNavigationEnabled):
798         (TestRunner::setScrollbarPolicy):
799         (TestRunner::setJavaScriptCanAccessClipboard):
800         (TestRunner::setAutomaticLinkDetectionEnabled):
801         (TestRunner::setUserStyleSheetEnabled):
802         (TestRunner::setUserStyleSheetLocation):
803         (TestRunner::setUseDashboardCompatibilityMode):
804         (TestRunner::setTabKeyCyclesThroughElements):
805         (TestRunner::setSmartInsertDeleteEnabled):
806         (TestRunner::setSelectTrailingWhitespaceEnabled):
807         (TestRunner::setPrivateBrowsingEnabled):
808         (TestRunner::setPluginsEnabled):
809         (TestRunner::setPopupBlockingEnabled):
810         (TestRunner::setMockSpeechInputDumpRect):
811         (TestRunner::setPersistentUserStyleSheetLocation):
812         (TestRunner::setMockGeolocationPosition):
813         (TestRunner::setMockGeolocationPositionUnavailableError):
814         (TestRunner::setMockDeviceOrientation):
815         (TestRunner::setMainFrameIsFirstResponder):
816         (TestRunner::setIconDatabaseEnabled):
817         (TestRunner::setGeolocationPermission):
818         (TestRunner::setDefersLoading):
819         (TestRunner::setCacheModel):
820         (TestRunner::setAuthorAndUserStylesEnabled):
821         (TestRunner::setAllowFileAccessFromFileURLs):
822         (TestRunner::setAppCacheMaximumSize):
823         (TestRunner::setAllowUniversalAccessFromFileURLs):
824         (TestRunner::setApplicationCacheOriginQuota):
825         (TestRunner::denyWebNotificationPermission):
826         (TestRunner::grantWebNotificationPermission):
827         (TestRunner::setValueForUser):
828         (TestRunner::setViewModeMediaFeature):
829         (TestRunner::setPageVisibility):
830         (TestRunner::addMockSpeechInputResult):
831         (TestRunner::removeOriginAccessWhitelistEntry):
832         (TestRunner::addUserScript):
833         (TestRunner::isCommandEnabled):
834         (TestRunner::evaluateScriptInIsolatedWorld):
835         (TestRunner::evaluateScriptInIsolatedWorldAndReturnValue):
836         (TestRunner::copyEncodedHostName):
837         (TestRunner::addUserStyleSheet):
838         (TestRunner::findString):
839         (TestRunner::execCommand):
840         (TestRunner::localStorageDiskUsageForOrigin):
841
842 2013-03-12  Julie Parent  <jparent@chromium.org>
843
844         Cleanup: Move flatten-trie to loader.
845         https://bugs.webkit.org/show_bug.cgi?id=112196
846
847         Reviewed by Dirk Pranke.
848
849         flatten-trie is used only by the loader, so move it there and make it
850         private, rather than global in dashbaord_base. Moved the corresponding
851         unit test from flakiness_dashboard_unittests to loader_unittests.
852         
853         * TestResultServer/static-dashboards/dashboard_base.js:
854         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
855         * TestResultServer/static-dashboards/loader.js:
856         (.):
857         * TestResultServer/static-dashboards/loader_unittests.js:
858
859 2013-03-12  Oliver Hunt  <oliver@apple.com>
860
861         Unbreak api tests
862
863         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
864         (TestWebKitAPI):
865
866 2013-03-12  Tim Horton  <timothy_horton@apple.com>
867
868         Unreviewed, disabling tests for Win EWS.
869
870         win-ews obviously cannot keep up with running tests, it's >300 behind.
871         Probably doesn't help that its (likely) running tests serially.
872
873         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
874         (WinEWS):
875
876 2013-03-12  Tim Horton  <timothy_horton@apple.com>
877
878         Add a --build-directory argument to delete-stale-build-files
879         https://bugs.webkit.org/show_bug.cgi?id=112198
880
881         Reviewed by Ryosuke Niwa.
882
883         * BuildSlaveSupport/delete-stale-build-files:
884         (main): Add --build-directory argument.
885
886 2013-03-12  Oliver Hunt  <oliver@apple.com>
887
888         Appease MSVC
889
890         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
891         (TestWebKitAPI):
892
893 2013-03-12  Oliver Hunt  <oliver@apple.com>
894
895         Add more Checked<> tests
896         https://bugs.webkit.org/show_bug.cgi?id=112190
897
898         Reviewed by Geoffrey Garen.
899
900         Tests!
901
902         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
903         (TestWebKitAPI):
904
905 2013-03-12  Julie Parent  <jparent@chromium.org>
906
907         Cleanup: Move loading complete function into callback, rather than global.
908         https://bugs.webkit.org/show_bug.cgi?id=112167
909
910         Reviewed by Dirk Pranke.
911         
912         Stop calling global functions, pass in proper handler to Loader
913         constructor. Note that the callback is optional, as tests, and
914         some potential dashboards, do not need one.
915
916         * TestResultServer/static-dashboards/dashboard_base.js:
917         * TestResultServer/static-dashboards/loader.js:
918         (.):
919         * TestResultServer/static-dashboards/loader_unittests.js:
920
921 2013-03-12  Christophe Dumez  <ch.dumez@sisa.samsung.com>
922
923         [EFL][WK2] Add popup menu support to MiniBrowser
924         https://bugs.webkit.org/show_bug.cgi?id=108934
925
926         Reviewed by Kenneth Rohde Christiansen.
927
928         Implement popup menu support in MiniBrowser by handling popup_menu_show
929         and popup_menu_hide smart functions on the view and using the Ewk popup
930         menu API.
931
932         * MiniBrowser/efl/main.c:
933         (_Browser_Window):
934         (on_popup_menu_discarded):
935         (on_popup_menu_item_clicked):
936         (popup_menu_populate):
937         (on_popup_menu_show):
938         (on_popup_menu_hide):
939         (window_create): Use calloc() instead of malloc() to allocate memory for
940         Browser_Window. This makes sure all the structs members are initialized
941         to 0 (such as the new elm_popup_menu pointer).
942
943 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
944
945         [GTK] Set up the libPlatformGtk.la library
946         https://bugs.webkit.org/show_bug.cgi?id=111738
947
948         Reviewed by Martin Robinson.
949
950         * GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
951         Adjust the path to GtkVersioning.c, the file has moved under Source/Platform.
952         * TestWebKitAPI/GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.
953
954 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
955
956         [GTK] Enable Web Audio in development builds
957         https://bugs.webkit.org/show_bug.cgi?id=111831
958
959         Reviewed by Philippe Normand.
960
961         Web Audio is already quite well supported on the GTK port but still has a few issues
962         that must be addressed before it is enabled by default. Despite that it should be enabled
963         in development builds just so we are up-to-date with future feature infrastructure changes.
964         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
965         that's an obvious goal before enabling the feature in release builds.
966
967         * Scripts/webkitperl/FeatureList.pm:
968
969 2013-03-11  Andreas Kling  <akling@apple.com>
970
971         [Mac][WK1] Add support for alert() in MiniBrowser.
972         <http://webkit.org/b/112090>
973
974         Reviewed by Anders Carlsson.
975
976         * MiniBrowser/mac/WK1BrowserWindowController.m:
977         (-[WK1BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
978
979 2013-03-11  Julie Parent  <jparent@chromium.org>
980
981         Dashboard cleanup: Create ui.Errors
982         https://bugs.webkit.org/show_bug.cgi?id=111785
983
984         Reviewed by Ojan Vafai.
985         
986         Create ui.Errors for handling errors the dashboards
987         encounter. Loader now has a Error object that it can add to,
988         and individual dashboards can show errors when desired.
989         Currently, only flakiness_db shows errors, but this is 
990         generic and there is no reason why other dbs wouldn't want to
991         show errors.
992
993         * TestResultServer/static-dashboards/dashboard_base.js:
994         (resourceLoadingComplete):
995         * TestResultServer/static-dashboards/flakiness_dashboard.js:
996         (generatePage):
997         * TestResultServer/static-dashboards/loader.js:
998         (.):
999         * TestResultServer/static-dashboards/ui.js:
1000         (.):
1001
1002 2013-03-08  Geoffrey Garen  <ggaren@apple.com>
1003
1004         Some StringHasher tests are broken because of missing null termination
1005         https://bugs.webkit.org/show_bug.cgi?id=111284
1006
1007         Reviewed by Darin Adler.
1008
1009         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
1010         (TestWebKitAPI): Added null termination since C strings are null-terminated.
1011         (TestWebKitAPI::TEST): Removed #ifdef's that disabled this testing since
1012         the bug caught by it is now fixed.
1013
1014 2013-03-11  Sheriff Bot  <webkit.review.bot@gmail.com>
1015
1016         Unreviewed, rolling out r145200.
1017         http://trac.webkit.org/changeset/145200
1018         https://bugs.webkit.org/show_bug.cgi?id=112063
1019
1020         Broke a couple of unit tests (Requested by zdobersek on
1021         #webkit).
1022
1023         * Scripts/webkitperl/FeatureList.pm:
1024
1025 2013-03-11  Zan Dobersek  <zdobersek@igalia.com>
1026
1027         [GTK] WebKit2-only build fails
1028         https://bugs.webkit.org/show_bug.cgi?id=112033
1029
1030         Reviewed by Gustavo Noronha Silva.
1031
1032         * GNUmakefile.am: Split the list of files the docs-build.stamp target depends on into the
1033         generic part, WebKit1-specific part and WebKit2-specific part.
1034         * TestWebKitAPI/GNUmakefile.am: The TestGtk executable should not link agains libwebkitgtk
1035         as it is not WebKit1-specific, but should rather link to libWebCore.la and libWebCoreGtk.la
1036         directly.
1037
1038 2013-03-11  Dima Gorbik  <dgorbik@apple.com>
1039
1040         Adding myself to the committers list.
1041
1042         Unreviewed.
1043
1044         * Scripts/webkitpy/common/config/committers.py:
1045
1046 2013-03-11  Jeff Rogers  <jrogers@rim.com>
1047
1048         [BlackBerry] Disable MathML support
1049         https://bugs.webkit.org/show_bug.cgi?id=111929
1050
1051         Reviewed by Rob Buis.
1052
1053         * Scripts/webkitperl/FeatureList.pm:
1054
1055 2013-03-11  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1056
1057         [EFL][GTK][WKTR] Regression(r145231): Undefined symbol in libTestRunnerInjectedBundle.so
1058         https://bugs.webkit.org/show_bug.cgi?id=111970
1059
1060         Reviewed by Chris Fleizach.
1061
1062         Provide dummy implementation for AccessibilityUIElement::supportedActions() in ATK
1063         or libTestRunnerInjectedBundle.so cannot be loaded in EFL / GTK otherwise, due to
1064         undefined symbol.
1065
1066         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1067         (WTR::AccessibilityUIElement::supportedActions):
1068         (WTR):
1069
1070 2013-03-11  Chris Hopman  <cjhopman@chromium.org>
1071
1072         [chromium] Android apk targets should depend directly on Java library targets
1073         https://bugs.webkit.org/show_bug.cgi?id=111746
1074
1075         Reviewed by Eric Seidel.
1076
1077         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1078         Make DumpRenderTree_apk depend directly on base_java and net_java.
1079         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1080         Make TestWebKitAPI_apk depend directly on base_java.
1081
1082 2013-03-11  Jochen Eisinger  <jochen@chromium.org>
1083
1084         [chromium] remove obsolete user gesture methods from WebFrame
1085         https://bugs.webkit.org/show_bug.cgi?id=111696
1086
1087         Reviewed by Adam Barth.
1088
1089         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
1090         (WebTestRunner::TestPlugin::handleInputEvent):
1091         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1092
1093 2013-03-10  Silvia Pfeiffer  <silviapf@chromium.org>
1094
1095         Unreviewed, add myself to commiters.py.
1096
1097         * Scripts/webkitpy/common/config/committers.py:
1098
1099 2013-03-08  Julie Parent  <jparent@chromium.org>
1100
1101         Cleanup: Remove dead code.
1102         https://bugs.webkit.org/show_bug.cgi?id=111900
1103
1104         Reviewed by Dirk Pranke.
1105         
1106         Treemap overrides a global function that used to be in 
1107         dashboard_base, but was removed months ago in
1108         https://bugs.webkit.org/show_bug.cgi?id=99246, so this code has
1109         no caller. 
1110
1111         * TestResultServer/static-dashboards/treemap.html:
1112
1113 2013-03-08  Harald Alvestrand  <hta@chromium.org>
1114
1115         Implemented new API for RTCStatsReport object.
1116         https://bugs.webkit.org/show_bug.cgi?id=110333
1117
1118         Reviewed by Adam Barth.
1119
1120         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
1121         (WebTestRunner::MockWebRTCPeerConnectionHandler::getStats):
1122
1123 2013-03-08  Dirk Pranke  <dpranke@chromium.org>
1124
1125         [chromium] use custom freetype on linux asan builds again
1126         https://bugs.webkit.org/show_bug.cgi?id=111884
1127
1128         Reviewed by Tony Chang.
1129
1130         We no longer need the workaround after chromium r186540.
1131
1132         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1133
1134 2013-03-08  Ryosuke Niwa  <rniwa@webkit.org>
1135
1136         Warning about the user not having edit rights on Bugzilla is confusing new contributors
1137         https://bugs.webkit.org/show_bug.cgi?id=111798
1138
1139         Reviewed by Dirk Pranke.
1140
1141         Don't scare people by the warning. Instead, tell them to ignore it if they don't have EditBugs privileges.
1142
1143         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1144
1145 2013-03-08  James Robinson  <jamesr@chromium.org>
1146
1147         [chromium] Remove WebLayerTreeViewClient and WebLayerTreeView::Settings
1148         https://bugs.webkit.org/show_bug.cgi?id=111632
1149
1150         Reviewed by Adrienne Walker.
1151
1152         * DumpRenderTree/chromium/WebViewHost.cpp:
1153         (WebViewHost::initializeLayerTreeView):
1154         * DumpRenderTree/chromium/WebViewHost.h:
1155         (WebViewHost):
1156
1157 2013-03-08  Benjamin Poulain  <benjamin@webkit.org>
1158
1159         [Mac] Add a feature flag for 'view-mode' Media Feature, disable it on Mac
1160         https://bugs.webkit.org/show_bug.cgi?id=111297
1161
1162         Reviewed by Kenneth Rohde Christiansen.
1163
1164         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1165         (WTR::TestRunner::setViewModeMediaFeature):
1166
1167 2013-03-08  Chris Fleizach  <cfleizach@apple.com>
1168
1169         [Mac] [WK2] platform/mac/accessibility/press-action-is-first.html fails
1170         https://bugs.webkit.org/show_bug.cgi?id=111814
1171
1172         Reviewed by Ryosuke Niwa.
1173
1174         Add the needed supportedActions() attribute to WKTestRunner.
1175
1176         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1177         (WTR::AccessibilityUIElement::supportedActions):
1178         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1179         (AccessibilityUIElement):
1180         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1181         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1182         (WTR::AccessibilityUIElement::supportedActions):
1183
1184 2013-03-08  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1185
1186         [EFL] Memory leak at WKViewClientWebProcessCallbacks API test
1187         https://bugs.webkit.org/show_bug.cgi?id=111851
1188
1189         Reviewed by Kenneth Rohde Christiansen.
1190
1191         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
1192         (TestWebKitAPI::TEST):
1193
1194             Fixed WKURLRef instance leaking.
1195
1196 2013-03-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1197
1198         [EFL] [WK2] Some authentication tests fail in WebKit2
1199         https://bugs.webkit.org/show_bug.cgi?id=106407
1200
1201         Reviewed by Kenneth Rohde Christiansen.
1202
1203         Add patch from upstream for libsoup 2.40 to fix several authentication
1204         test cases.
1205
1206         * efl/jhbuild.modules:
1207         * efl/patches/libsoup-2.40-auth-fix.patch: Added.
1208
1209 2013-03-08  Zan Dobersek  <zdobersek@igalia.com>
1210
1211         [GTK] Enable Web Audio in development builds
1212         https://bugs.webkit.org/show_bug.cgi?id=111831
1213
1214         Reviewed by Philippe Normand.
1215
1216         Web Audio is already quite well supported on the GTK port but still has a few issues
1217         that must be addressed before it is enabled by default. Despite that it should be enabled
1218         in development builds just so we are up-to-date with future feature infrastructure changes.
1219         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
1220         that's an obvious goal before enabling the feature in release builds.
1221
1222         * Scripts/webkitperl/FeatureList.pm:
1223
1224 2013-03-07  Jochen Eisinger  <jochen@chromium.org>
1225
1226         [chromium] delay clearing the TestRunners until the main view was deleted
1227         https://bugs.webkit.org/show_bug.cgi?id=111823
1228
1229         Reviewed by Eric Seidel.
1230
1231         During WebViewHost::shutdown, we navigate the WebView to about:blank.
1232         This may call into the test runners which assume that the delegate is
1233         always non-NULL.
1234
1235         * DumpRenderTree/chromium/TestShell.cpp:
1236         (TestShell::~TestShell):
1237
1238 2013-03-07  Alan Cutter  <alancutter@chromium.org>
1239
1240         Sheriffbot whois command can't search by full name
1241         https://bugs.webkit.org/show_bug.cgi?id=111825
1242
1243         Reviewed by Eric Seidel.
1244
1245         Allowed multiple arguments to Sheriffbot's whois command.
1246         Updated test expectations.
1247
1248         * Scripts/webkitpy/tool/bot/irc_command.py:
1249         (Whois.execute):
1250         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1251         (IRCCommandTest.test_whois):
1252
1253 2013-03-07  Nils Barth  <nbarth@chromium.org>
1254
1255         Add Nils Barth and Koji Hara to committers.py
1256         https://bugs.webkit.org/show_bug.cgi?id=111806
1257
1258         Reviewed by Eric Seidel.
1259
1260         * Scripts/webkitpy/common/config/committers.py:
1261
1262 2013-03-07  Glenn Adams  <glenn@skynav.com>
1263
1264         run-pert-tests should have a --test-runner-count option
1265         https://bugs.webkit.org/show_bug.cgi?id=111726
1266
1267         Reviewed by Ryosuke Niwa.
1268
1269         Add --test-runner-count option to run-perf-tests, with default value of 4.
1270         This option allows command line configuration of the number of times to invoke
1271         the test runner (serially, not in parallel) when running a specific test in
1272         a test set.
1273
1274         * Scripts/webkitpy/performance_tests/perftest.py:
1275         (PerfTest): Add DEFAULT_TEST_RUNNER_COUNT constant.
1276         (PerfTest.__init__): Rename process_run_count to test_runner_count (throughout).
1277         (PerfTest.run): Rename process_run_count to test_runner_count.
1278         (SingleProcessPerfTest.__init__): Add test_runner_count optional argument.
1279         (ChromiumStylePerfTest.__init__): Add test_runner_count optional argument.
1280         (ReplayPerfTest.__init__): Add test_runner_count optional argument.
1281         (PerfTestFactory.create_perf_test): Add test_runner_count optional argument.
1282         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1283         (PerfTestsRunner._parse_args): Add '--test-runner-count' option.
1284         (PerfTestsRunner._collect_tests): Use test_runner_count when creating PerfTest.
1285         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1286         (MainTest._test_run_with_json_output): Add optional compare_logs argument.
1287         (MainTest.test_run_with_repeat):
1288         (MainTest.test_run_with_test_runner_count): Add new test for test-runner-count option semantics.
1289         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1290         (MainTest.test_default_args): Add test for default option argument values.
1291         (MainTest.test_parse_args): Add test for test-runner-count option parsing.
1292
1293 2013-03-07  Christian Biesinger  <cbiesinger@chromium.org>
1294
1295         Add myself to reviewers.py
1296         https://bugs.webkit.org/show_bug.cgi?id=111757
1297
1298         Reviewed by Eric Seidel.
1299
1300         * Scripts/webkitpy/common/config/committers.py:
1301
1302 2013-03-07  Glenn Adams  <glenn@skynav.com>
1303
1304         run-perf-tests should have a --repeat option
1305         https://bugs.webkit.org/show_bug.cgi?id=100030
1306
1307         Reviewed by Ryosuke Niwa.
1308
1309         Add --repeat option to run-perf-tests, with default value of 1. When greater
1310         than 1, runs test set specified number of times. Note that multiple runs are
1311         not aggregated for statistical purposes.
1312
1313         Incidentally fixed typo: s/suceeds/succeeds/.
1314
1315         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1316         (PerfTestsRunner._parse_args): Add repeat option.
1317         (PerfTestsRunner.run): Add outer repeat loop.
1318         (PerfTestsRunner._generate_results): Split from original _generate_and_show_results.
1319         (PerfTestsRunner._upload_and_show_results): Split from original _generate_and_show_results.
1320         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1321         (MainTest._test_run_with_json_output): Add repeat optional argument for generating expected logs. Fix typo.
1322         (MainTest._test_run_with_json_output.mock_upload_json): Fix typo.
1323         (MainTest.test_run_with_json_output): Fix typo.
1324         (MainTest.test_run_with_description): Fix typo.
1325         (MainTest.test_run_respects_no_results): Fix typo.
1326         (MainTest.test_run_with_slave_config_json): Fix typo.
1327         (MainTest.test_run_with_multiple_repositories): Fix typo.
1328         (MainTest.test_run_with_upload_json): Fix typo.
1329         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json): Fix typo.
1330         (MainTest.test_run_with_repeat): Added new test for repeat count semantics.
1331         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1332         (MainTest.test_parse_args): Add test for repeat option parsing.
1333
1334 2013-03-07  Julie Parent  <jparent@chromium.org>
1335
1336         showAllRuns checkbox no longer works on the stats dashboard
1337         https://bugs.webkit.org/show_bug.cgi?id=111673
1338
1339         Reviewed by Ojan Vafai.
1340
1341         Stats dashboard does not have any DB_SPECIFIC_INVALIDATING_PARAMETERS,
1342         so we were trying to index into an undefined object.
1343         
1344         * TestResultServer/static-dashboards/dashboard_base.js:
1345         (invalidateQueryParameters):
1346
1347 2013-03-07  Mark Pilgrim  <pilgrim@chromium.org>
1348
1349         [Chromium] Update #include for WebStorageNamespace.h
1350         https://bugs.webkit.org/show_bug.cgi?id=111748
1351
1352         Reviewed by Adam Barth.
1353
1354         In anticipation of removing
1355         WK/chromium/public/WebStorageNamespace.h (once downstream
1356         references have been updated)
1357
1358         * DumpRenderTree/chromium/WebViewHost.cpp:
1359
1360 2013-03-07  Dirk Pranke  <dpranke@chromium.org>
1361
1362         run-perf-tests fails due to svn_revision not working on a pure git clone
1363         https://bugs.webkit.org/show_bug.cgi?id=110839
1364
1365         Reviewed by Ryosuke Niwa.
1366
1367         Previously we would call git svn find-rev to look up the commit for
1368         a given revision, and that'll hang in a pure git checkout.
1369
1370         This patch changes the way we look up svn revisions in a git
1371         repository to use git log --grep 'git-svn-id', which is much faster
1372         than grepping ourselves. It also renames timestamp_of_latest_commit()
1373         to timestamp_of_revision() in order to accurately reflect what
1374         the method is doing. Note that this patch only changes the logic
1375         inside latest_revision() and svn_revision(). I'll file a separate
1376         bug to change git_commit_from_svn_revision().
1377
1378         This patch also contains some fixes to unit tests that had bit-rotted
1379         or were otherwise fragile, so that test-webkitpy --all would pass
1380         cleanly, and a fix to outputcapture so that
1381         test-webkitpy -p would work correctly again.
1382
1383         * Scripts/webkitpy/common/checkout/scm/git.py:
1384         (Git.svn_revision):
1385         (Git.timestamp_of_revision):
1386         * Scripts/webkitpy/common/checkout/scm/scm.py:
1387         (SCM.svn_revision):
1388         (SCM.timestamp_of_revision):
1389         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1390         (MockSCM.timestamp_of_revision):
1391         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1392         (_shared_test_commit_with_message):
1393         (test_commit_without_authorization):
1394         (test_timestamp_of_revision):
1395         * Scripts/webkitpy/common/checkout/scm/svn.py:
1396         (SVN.timestamp_of_revision):
1397         * Scripts/webkitpy/common/system/outputcapture.py:
1398           Importing unittest2 directly may not be safe if this module is
1399           imported before the autoinstaller gets a chance to set things up
1400           properly. We don't actually need unittest2 here.
1401         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1402         (PerfTestsRunner._generate_results_dict):
1403
1404 2013-03-07  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1405
1406         [EFL] Bump libsoup dependency to 2.40.3 to fix regressions
1407         https://bugs.webkit.org/show_bug.cgi?id=111756
1408
1409         Reviewed by Kenneth Rohde Christiansen.
1410
1411         Bump libsoup to v2.40.3 to fix the regressions introduced by
1412         previous v2.40.0 bump.
1413
1414         * efl/jhbuild.modules:
1415
1416 2013-03-07  Roger Fong  <roger_fong@apple.com>
1417
1418         Re-enable Win EWS tests.
1419
1420         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1421         (WinEWS):
1422
1423 2013-03-07  Dirk Pranke  <dpranke@chromium.org>
1424
1425         [nrwt] handle corrupt http server pid files cleanly
1426         https://bugs.webkit.org/show_bug.cgi?id=111628
1427
1428         Reviewed by Eric Seidel.
1429
1430         If the pid file from a previous http server is corrupt for some
1431         reason, NRWT will just raise errors and not clean it up or recover.
1432         This patch fixes that to at least delete the pid file and
1433         not throw; not that we may still have stale http servers left on
1434         the system, since there's no way to know which pid to kill if
1435         the file was corrupted.
1436
1437         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1438         (HttpServerBase.start):
1439         (HttpServerBase.stop):
1440         (HttpServerBase._remove_pid_file):
1441         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py: Added.
1442         (TestHttpServerBase):
1443         (TestHttpServerBase.test_corrupt_pid_file):
1444
1445 2013-03-07  Chris Fleizach  <cfleizach@apple.com>
1446
1447         AX: Can't activate links with VoiceOver in Safari
1448         https://bugs.webkit.org/show_bug.cgi?id=111755
1449
1450         Reviewed by Tim Horton.
1451
1452         * DumpRenderTree/AccessibilityUIElement.cpp:
1453         (supportedActionsCallback):
1454         (AccessibilityUIElement::getJSClass):
1455         * DumpRenderTree/AccessibilityUIElement.h:
1456         (AccessibilityUIElement):
1457         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1458         (AccessibilityUIElement::supportedActions):
1459
1460 2013-03-07  Roger Fong  <roger_fong@apple.com>
1461
1462         Windows debug layout tests are crashing like crazy again.
1463         Disable tests on Win EWS bots temporarily.
1464
1465         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1466         (WinEWS):
1467
1468 2013-03-07  Roger Fong  <roger_fong@apple.com>
1469
1470         Make EWS bots build and test in release.
1471
1472         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1473         (WinEWS):
1474         * Scripts/webkitpy/tool/steps/runtests.py:
1475         (RunTests.run):
1476
1477 2013-03-07  Jochen Eisinger  <jochen@chromium.org>
1478
1479         [chromium] don't track the top loading frame if no layout test is currently running
1480         https://bugs.webkit.org/show_bug.cgi?id=111716
1481
1482         Reviewed by Kentaro Hara.
1483
1484         In DRT, we synchronously stop the test and start loading the next test
1485         URL. However, in content_shell, this happens asynchronously. It's
1486         important that the top loading frame is not changed due to stray
1487         navigation events before the next test starts.
1488
1489         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1490         (WebTestRunner::TestRunner::setTopLoadingFrame):
1491
1492 2013-03-06  Julie Parent  <jparent@chromium.org>
1493
1494         Dashboard cleanup: Move all dashboard ui related code into ui.js.
1495         https://bugs.webkit.org/show_bug.cgi?id=111621
1496
1497         Reviewed by Ojan Vafai.
1498         
1499         Creates ui.js, a package for the common UI code the various
1500         dashboards use. HTML generation is now in the ui.html namespace
1501         and popup handling is in ui.popup.
1502         Also moves the event listening for popups to ui.popup.show and
1503         removes it on ui.popup.hid rather than having listener always
1504         around.
1505
1506         * TestResultServer/static-dashboards/aggregate_results.html:
1507         * TestResultServer/static-dashboards/dashboard_base.js:
1508         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1509         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1510         (showPopupForBuild):
1511         (htmlForNavBar):
1512         (generatePageForIndividualTests.if):
1513         (generatePageForIndividualTests):
1514         * TestResultServer/static-dashboards/flakiness_dashboard_embedded_unittests.js:
1515         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1516         * TestResultServer/static-dashboards/run-embedded-unittests.html:
1517         * TestResultServer/static-dashboards/run-unittests.html:
1518         * TestResultServer/static-dashboards/timeline_explorer.html:
1519         * TestResultServer/static-dashboards/treemap.html:
1520         * TestResultServer/static-dashboards/ui.js: Added.
1521         (.):
1522
1523 2013-03-06  Krzysztof Czech  <k.czech@samsung.com>
1524
1525         [EFL] Missing implementation of AccessibilityControllerEfl and AccessibilityUIElementEfl files
1526         https://bugs.webkit.org/show_bug.cgi?id=110584
1527
1528         Reviewed by Gyuyoung Kim.
1529
1530         Adds missing implementation of AccessibilityControllerEfl
1531         and AccessibilityUIElementEfl files. Modify DumpRenderTreeChrome
1532         so that it can make accessibilityController as a js object.
1533
1534         * DumpRenderTree/AccessibilityController.h:
1535         (AccessibilityController):
1536         * DumpRenderTree/AccessibilityUIElement.h:
1537         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
1538         (AccessibilityController::childElementById): Moved declaration to base class.
1539         Implementation can be shared among other ports.
1540         * DumpRenderTree/efl/AccessibilityControllerEfl.cpp: Copied from Tools/DumpRenderTree/gtk/AccessibilityControllerGtk.cpp.
1541         (AccessibilityController::focusedElement):
1542         (AccessibilityController::rootElement):
1543         (AccessibilityController::accessibleElementById):
1544         * DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Copied from Tools/DumpRenderTree/atk/AccessibilityControllerAtk.cpp.
1545         (AccessibilityUIElement::helpText):
1546         * DumpRenderTree/efl/CMakeLists.txt:
1547         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1548         (DumpRenderTreeChrome::DumpRenderTreeChrome):
1549         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1550         (DumpRenderTreeChrome::onWindowObjectCleared):
1551         (DumpRenderTreeChrome::accessibilityController):
1552         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1553         (DumpRenderTreeChrome):
1554         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1555
1556 2013-03-06  Benjamin Poulain  <benjamin@webkit.org>
1557
1558         WebKitTestRunner needs layoutTestController.elementDoesAutoCompleteForElementWithId
1559         https://bugs.webkit.org/show_bug.cgi?id=42696
1560
1561         Reviewed by Andreas Kling.
1562
1563         * DumpRenderTree/TestRunner.cpp:
1564         (TestRunner::staticFunctions):
1565         * DumpRenderTree/TestRunner.h:
1566         (TestRunner):
1567         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1568         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1569         (WebTestRunner::TestRunner::TestRunner):
1570         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1571         (TestRunner):
1572         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1573         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1574         * DumpRenderTree/mac/TestRunnerMac.mm:
1575         * DumpRenderTree/qt/TestRunnerQt.cpp:
1576         * DumpRenderTree/qt/TestRunnerQt.h:
1577         (TestRunnerQt):
1578         * DumpRenderTree/win/TestRunnerWin.cpp:
1579         * DumpRenderTree/wx/TestRunnerWx.cpp:
1580
1581 2013-03-06  Roger Fong  <roger_fong@apple.com>
1582
1583         Re-enable WinEWS test and decrease iterations before clean build back to 10.
1584
1585         * EWSTools/start-queue-win.sh:
1586         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1587         (WinEWS):
1588
1589 2013-03-06  Manuel Rego Casasnovas  <rego@igalia.com>
1590
1591         [WK2][GTK] Fix unit test WebKit2APITests/WebKitWebView/mouse-target
1592         https://bugs.webkit.org/show_bug.cgi?id=82866
1593
1594         Reviewed by Martin Robinson.
1595
1596         * Scripts/run-gtk-tests:
1597         (TestRunner): Unflag WebKit2APITests/WebKitWebView/mouse-target test as
1598         it is passing now.
1599
1600 2013-03-06  Julie Parent  <jparent@chromium.org>
1601
1602         Dashboard cleanup: remove dashboard time logging.
1603         https://bugs.webkit.org/show_bug.cgi?id=111608
1604
1605         Reviewed by Dirk Pranke.
1606
1607         Remove logTime.  It was never accurate, and the dev tools
1608         have better ways to measure this if anyone cares to look
1609         into dashboard perf.
1610         
1611         * TestResultServer/static-dashboards/dashboard_base.js:
1612         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1613         (processTestRunsForBuilder):
1614         (appendHTML):
1615
1616 2013-03-06  Tony Chang  <tony@chromium.org>
1617
1618         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
1619         https://bugs.webkit.org/show_bug.cgi?id=111509
1620
1621         Reviewed by Dirk Pranke.
1622
1623         Add DumpRenderTree.pak to DumpRenderTree.app again.
1624
1625         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1626
1627 2013-03-06  Jochen Eisinger  <jochen@chromium.org>
1628
1629         [chromium] introduce WebUserGestureIndicator
1630         https://bugs.webkit.org/show_bug.cgi?id=111531
1631
1632         Reviewed by Adam Barth.
1633
1634         * DumpRenderTree/chromium/WebViewHost.cpp:
1635         (WebViewHost::createView):
1636
1637 2013-03-06  Alan Cutter  <alancutter@chromium.org>
1638
1639         sheriffbot roll-chromium-deps shouldn't create a bug with None as the new revision.
1640         https://bugs.webkit.org/show_bug.cgi?id=73482
1641
1642         Reviewed by Ryosuke Niwa.
1643
1644         Added input checking to the UpdateChromiumDEPS step.
1645         Removed the default use of LKGR when the revision input is invalid. "LKGR" must be explicitly given instead.
1646
1647         * Scripts/webkitpy/tool/bot/irc_command.py: Updated input validation and error message handling.
1648         (RollChromiumDEPS):
1649         (RollChromiumDEPS._parse_args):
1650         (RollChromiumDEPS.execute):
1651         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Updated unit tests.
1652         (IRCCommandTest.test_roll_chromium_deps):
1653         * Scripts/webkitpy/tool/bot/ircbot_unittest.py: Updated unit tests.
1654         (IRCBotTest.test_roll_chromium_deps_to_lkgr):
1655         * Scripts/webkitpy/tool/commands/roll_unittest.py: Updated unit tests.
1656         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added input validation and added new error handling cases. Changed the logic of deciding to use LKGR to be only when the input is "LKGR".
1657         (UpdateChromiumDEPS._fetch_last_known_good_revision):
1658         (UpdateChromiumDEPS):
1659         (UpdateChromiumDEPS._parse_revision_number):
1660         (UpdateChromiumDEPS._validate_revisions):
1661         (UpdateChromiumDEPS.run):
1662         * Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Added unit tests.
1663         (UpdateChromiumDEPSTest):
1664         (UpdateChromiumDEPSTest.test_parse_revision_number):
1665         * Scripts/webkitpy/tool/commands/roll.py: Updated help text.
1666         (RollChromiumDEPS):
1667         (PostChromiumDEPSRoll):
1668
1669 2013-03-06  Andras Becsi  <andras.becsi@digia.com>
1670
1671         [Qt][MiniBrowser] Touch mocking broken for chained getures
1672         https://bugs.webkit.org/show_bug.cgi?id=111430
1673
1674         Reviewed by Jocelyn Turcotte.
1675
1676         Make it possible again to use touch mocking to test gesture chains
1677         like pan->pinch->pan->pinch without lifting the primary "finger".
1678         For this to work we need to track the pressed mouse buttons and
1679         only synthesize touch release events when the ctrl key is released
1680         if no mouse button is pressed. Else the pressed mouse button(s)
1681         should result in a stationary touch point in a touch update event.
1682         Since it has been fixed in Qt 5.0.1 use QGuiApplication::keyboardModifiers()
1683         to check for the state of the ctrl key modifier instead of getting
1684         it from the mouse events.
1685
1686         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1687         (MiniBrowserApplication::MiniBrowserApplication):
1688         (MiniBrowserApplication::notify):
1689
1690 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
1691
1692         [chromium] don't use custom freetype on linux asan for now
1693         https://bugs.webkit.org/show_bug.cgi?id=111516
1694
1695         Unreviewed, build fix.
1696
1697         Turns out the custom lib is getting picked up by other binaries
1698         on our bot, which is bad.
1699
1700         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1701
1702 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
1703
1704         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
1705         https://bugs.webkit.org/show_bug.cgi?id=111509
1706
1707         Unreviewed, build fix.
1708
1709         Actually comment out the flag :(.
1710
1711         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1712
1713 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
1714
1715         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
1716         https://bugs.webkit.org/show_bug.cgi?id=111509
1717
1718         Unreviewed, build fix.
1719
1720         r144863 appears to have broken the xcode build; I'm temporarily
1721         trying this instead, and if this doesn't work, I'll revert the
1722         other changes.
1723
1724         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1725
1726 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
1727
1728         [chromium] build a DumpRenderTree.pak even on windows
1729         https://bugs.webkit.org/show_bug.cgi?id=111504
1730
1731         Reviewed by Tony Chang.
1732
1733         The Chromium Aura build uses the default theme to draw
1734         controls, and that theme requires the ui ResourceBundle
1735         to be initialized. On every other platform, we build
1736         a DumpRenderTree.pak that works for this, but on Windows we
1737         still compile the resources directly into DRT. As a first step,
1738         let's build the pak file. I will then need to land a patch
1739         in Chromium to actually load it. Then I can go back and move
1740         the resources over to just use the .pak file and no longer need
1741         the .rc's.
1742
1743         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1744
1745 2013-03-05  Julie Parent  <jparent@chromium.org>
1746         Dashboard cleanup: move string utilities into their own namespace.
1747         
1748         https://bugs.webkit.org/show_bug.cgi?id=111485
1749
1750         Reviewed by Ojan Vafai.
1751         
1752         One of many pieces to clean up dashboard_base.
1753         
1754         Moves string utility functions into separate file (string.js) and into their own namespace rather than cluttering up the global scope.
1755
1756         * TestResultServer/static-dashboards/aggregate_results.html:
1757         * TestResultServer/static-dashboards/dashboard_base.js:
1758         (isTreeMap):
1759         (isFlakinessDashboard):
1760         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1761         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1762         (determineWKPlatform):
1763         (chromiumPlatform):
1764         (platformAndBuildType):
1765         (substringList):
1766         (individualTestsForSubstringList):
1767         (filterBugs):
1768         (populateExpectationsData):
1769         (processMissingTestsWithExpectations):
1770         (processMissingAndExtraExpectations):
1771         (htmlForSingleTestRow):
1772         (.dummyNode.onload):
1773         (expectationsTitle):
1774         * TestResultServer/static-dashboards/run-embedded-unittests.html:
1775         * TestResultServer/static-dashboards/run-unittests.html:
1776         * TestResultServer/static-dashboards/string.js: Added.
1777         * TestResultServer/static-dashboards/timeline_explorer.html:
1778         * TestResultServer/static-dashboards/treemap.html:
1779
1780 2013-03-05  Ryuan Choi  <ryuan.choi@samsung.com>
1781
1782         [EFL] Build break with latest EFL libraries
1783         https://bugs.webkit.org/show_bug.cgi?id=111028
1784
1785         Reviewed by Dirk Pranke.
1786
1787         * MiniBrowser/efl/CMakeLists.txt: Added ECORE_XXX_INCLUDE_DIRS.
1788         * TestWebKitAPI/PlatformEfl.cmake: Ditto.
1789         * WebKitTestRunner/PlatformEfl.cmake: Ditto.
1790
1791 2013-03-05  Roger Fong  <roger_fong@apple.com>
1792
1793         Increase number of WinEWS iterations to 20.
1794         Don't reboot after each iteration set.
1795         Make EWS bots just build temporarily so that the queue catches up again.
1796
1797         * EWSTools/start-queue-win.sh:
1798         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1799         (WinEWS):
1800
1801 2013-03-04  James Robinson  <jamesr@chromium.org>
1802
1803         [chromium] Move check for threaded compositing from WebCompositorSupport to Platform
1804         https://bugs.webkit.org/show_bug.cgi?id=111386
1805
1806         Reviewed by Adrienne Walker.
1807
1808         * DumpRenderTree/chromium/TestShell.cpp:
1809         (TestShell::initialize):
1810
1811 2013-03-05  Min Qin  <qinmin@chromium.org>
1812
1813         Copy dictionary to the external storage before running layout test on android
1814         https://bugs.webkit.org/show_bug.cgi?id=111480
1815
1816         Reviewed by Adam Barth.
1817
1818         TestWebKitPlatformSupport now needs to read an external dictionary file.
1819         This file does not exist on the device. We need to copy it before running layout tests.
1820
1821         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1822         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
1823         (ChromiumAndroidDriver._push_platform_resources):
1824
1825 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
1826
1827         [chromium] DRT crashes in an Aura/Win build
1828         https://bugs.webkit.org/show_bug.cgi?id=111394
1829
1830         Reviewed by Tony Chang.
1831
1832         When building (and running) with use_aura=1, we assume that
1833         we're using the default theme engine, but DRT creates the
1834         DRTWin theme engine and overwrites the default, leading to crashes
1835         in basically every test from the mismatch.
1836
1837         This fix gets us down to at least "lots of crashes" :).
1838
1839         * DumpRenderTree/chromium/TestShellWin.cpp:
1840         (platformInit):
1841
1842 2013-03-05  Eric Seidel  <eric@webkit.org>
1843
1844         Add html-parser-threaded perf test now that the threaded parser is enabled by default
1845         https://bugs.webkit.org/show_bug.cgi?id=111200
1846
1847         Reviewed by Ryosuke Niwa.
1848
1849         Had to teach run-perf-tests to ignore one more warning.
1850
1851         * Scripts/webkitpy/performance_tests/perftest.py:
1852         (PerfTest):
1853
1854 2013-03-05  Jochen Eisinger  <jochen@chromium.org>
1855
1856         Update list of builders for test results server
1857         https://bugs.webkit.org/show_bug.cgi?id=111166
1858
1859         Reviewed by Ojan Vafai.
1860
1861         * TestResultServer/static-dashboards/builders.jsonp:
1862
1863 2013-03-05  Martin Robinson  <mrobinson@igalia.com> and Tomas Popela  <tpopela@redhat.com>
1864
1865         [GTK] Move basic dependency installation to a script
1866         https://bugs.webkit.org/show_bug.cgi?id=110692
1867
1868         Reviewed by Gustavo Noronha Silva.
1869
1870         * gtk/install-dependencies: Added. A Script which installs all dependencies
1871         necessary for building for Debian-based distributions and Fedora.
1872
1873 2013-03-05  James Robinson  <jamesr@chromium.org>
1874
1875         Chromium DumpRenderTree dumps a core every time it's run (Linux/Debug)
1876         https://bugs.webkit.org/show_bug.cgi?id=111440
1877
1878         Reviewed by Adrienne Walker.
1879
1880         Remove unnecessary WebCompositorSupport::shutdown call
1881
1882         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1883         (main):
1884
1885 2013-03-05  Gustavo Noronha Silva  <gns@gnome.org>
1886
1887         Unreviewed build fix.
1888
1889         * GNUmakefile.am: add generate-feature-defines-files scripts to EXTRA_DIST.
1890
1891 2013-03-05  Andras Becsi  <andras.becsi@digia.com>
1892
1893         [Qt][MiniBrowser] Improve the update of touch indicators
1894         https://bugs.webkit.org/show_bug.cgi?id=111429
1895
1896         Reviewed by Jocelyn Turcotte.
1897
1898         MiniBrowserApplication::sendTouchEvent sends an empty list
1899         to BrowserWindow::updateVisualMockTouchPoints if the control
1900         button is released, in which case the touch indicators should
1901         be hidden so that we never end up with a leftover indicator
1902         sticking on the screen.
1903         This patch also simplifies the lookup of the indicator items by
1904         replacing the findChild search in the item tree with a QHash
1905         that stores the touch ID's and the pointers to the corresponding
1906         indicator items.
1907
1908         * MiniBrowser/qt/BrowserWindow.cpp:
1909         (BrowserWindow::updateVisualMockTouchPoints):
1910         * MiniBrowser/qt/BrowserWindow.h:
1911         (BrowserWindow):
1912
1913 2013-03-05  Tim Horton  <timothy_horton@apple.com>, Grzegorz Czajkowski  <g.czajkowski@samsung.com>
1914
1915         [WK2] WTR needs an implementation of setAsynchronousSpellCheckingEnabled
1916         https://bugs.webkit.org/show_bug.cgi?id=81042
1917
1918         Reviewed by Enrica Casucci.
1919
1920         Add setAsynchronousSpellCheckingEnabled implementation for
1921         WebKitTestRunner to have the possibility to test asynchronous
1922         spell checking implementation from bug 109577.
1923
1924         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1925         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1926         (WTR::TestRunner::setAsynchronousSpellCheckingEnabled):
1927         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1928         * WebKitTestRunner/TestController.cpp:
1929         (WTR::TestController::resetStateToConsistentValues):
1930
1931 2013-03-05  Tommy Widenflycht  <tommyw@google.com>
1932
1933         MediaStream API: Add the getStreamById method on RTCPeerConnection
1934         https://bugs.webkit.org/show_bug.cgi?id=111311
1935
1936         Reviewed by Adam Barth.
1937
1938         Changing mocks to be more realistic.
1939
1940         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
1941         (WebTestRunner::MockWebRTCPeerConnectionHandler::addStream):
1942         (WebTestRunner::MockWebRTCPeerConnectionHandler::removeStream):
1943         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp:
1944         (WebTestRunner::WebUserMediaClientMock::requestUserMedia):
1945
1946 2013-03-05  Jochen Eisinger  <jochen@chromium.org>
1947
1948         Add content shell bots to garden-o-matic for general failurse
1949         https://bugs.webkit.org/show_bug.cgi?id=111168
1950
1951         Reviewed by Adam Barth.
1952
1953         All but the WebKit (Content Shell) Android bot is stable enough. While
1954         they're not green yet, there must not be any non-layout test failures on
1955         them.
1956
1957         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1958         (.):
1959
1960 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
1961
1962         [chromium] remove deprecated WebTestRunner::setFocus API
1963         https://bugs.webkit.org/show_bug.cgi?id=111354
1964
1965         Reviewed by James Robinson.
1966
1967         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1968         (WebTestDelegate):
1969
1970 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
1971
1972         Run the bindings generation tests on EWS and CQ bots
1973         https://bugs.webkit.org/show_bug.cgi?id=111358
1974
1975         Reviewed by Adam Barth.
1976
1977         The tests are super fast and not flaky.
1978
1979         * Scripts/webkitpy/common/config/ports.py:
1980         (DeprecatedPort.run_bindings_tests_command):
1981         * Scripts/webkitpy/common/config/ports_mock.py:
1982         (MockPort.run_webkit_tests_command):
1983         (MockPort):
1984         (MockPort.run_bindings_tests_command):
1985         * Scripts/webkitpy/tool/commands/download_unittest.py:
1986         * Scripts/webkitpy/tool/steps/runtests.py:
1987         (RunTests.run):
1988         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1989         (RunTestsTest.test_webkit_run_unit_tests):
1990         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1991
1992 2013-03-04  Eric Seidel  <eric@webkit.org>
1993
1994         run-webkit-tests should support --profile and --profiler= just like run-perf-tests does
1995         https://bugs.webkit.org/show_bug.cgi?id=111384
1996
1997         Reviewed by Ryosuke Niwa.
1998
1999         Sometimes I want to know why various LayoutTests are slow
2000         without having to convert them into PerformanceTests in order
2001         to use our fancy profiling.  The Driver already knows how to
2002         do the right thing, we just need to expose the options to the user.
2003
2004         Handling of these options is already unittested in the perftests_unittest.
2005
2006         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2007         (parse_args):
2008
2009 2013-03-04  Alan Cutter  <alancutter@chromium.org>
2010
2011         check-webkit-style says "Have to enable auto props in the subversion config file"
2012         https://bugs.webkit.org/show_bug.cgi?id=107724
2013
2014         Reviewed by Tony Chang.
2015
2016         Added a standard svn config file for WebKit developers to use.
2017         Updated the style and commit queue bot build scripts to load this file.
2018
2019         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
2020         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
2021         * EWSTools/configure-svn-config.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
2022         * svn-config: Added.
2023
2024 2013-03-04  James Robinson  <jamesr@chromium.org>
2025
2026         [chromium] Switch to new webkit_support::CreateLayerTreeView interface
2027         https://bugs.webkit.org/show_bug.cgi?id=111285
2028
2029         Reviewed by Adrienne Walker.
2030
2031         This removes the need for WebCompositorSupport::initialize and exposes
2032         slightly fewer entry points across the repository boundary.
2033
2034         * DumpRenderTree/chromium/TestShell.cpp:
2035         (TestShell::initialize):
2036         * DumpRenderTree/chromium/TestShell.h:
2037         (TestShell::webCompositorThread):
2038         (TestShell):
2039         * DumpRenderTree/chromium/WebViewHost.cpp:
2040         (WebViewHost::initializeLayerTreeView):
2041
2042 2013-03-04  Roger Fong  <roger_fong@apple.com>
2043
2044         Unreviewed. Get rid of some AppleWin VS2010 build warnings.
2045
2046         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
2047
2048 2013-03-04  David Kilzer  <ddkilzer@apple.com>
2049
2050         BUILD FIX (r144657): Fix DumpRenderTree build failure on iOS
2051
2052             Tools/DumpRenderTree/ios/AccessibilityControllerIOS.mm:95:29: error: class method '+stringWithJSStringRef:' not found (return type defaults to 'id') [-Werror,-Wobjc-method-access]
2053                 NSString *idAttribute = [NSString stringWithJSStringRef:idAttributeRef];
2054                                         ^         ~~~~~~~~~~~~~~~~~~~~~
2055             1 error generated.
2056
2057         * DumpRenderTree/ios/AccessibilityControllerIOS.mm: Import
2058         AccessibilityCommonMac.h.
2059
2060 2013-03-04  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2061
2062         [WK2][EFL] Add callbacks to the WKViewClient to handle Web Process crash and relaunch
2063         https://bugs.webkit.org/show_bug.cgi?id=109828
2064
2065         Reviewed by Kenneth Rohde Christiansen.
2066
2067         Added API test for newly added Web Process crash and Web Process relaunch WKViewClient
2068         callbacks.
2069
2070         * TestWebKitAPI/CMakeLists.txt:
2071
2072             Tests located in 'TestWebKitAPI/Tests/WebKit2' subdirectories are also
2073             considered.
2074
2075         * TestWebKitAPI/PlatformEfl.cmake:
2076         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp: Added.
2077         (TestWebKitAPI):
2078         (TestWebKitAPI::didFinishLoadForFrame):
2079         (TestWebKitAPI::setPageLoaderClient):
2080         (TestWebKitAPI::webProcessCrashed):
2081         (TestWebKitAPI::webProcessDidRelaunch):
2082         (TestWebKitAPI::setViewClient):
2083         (TestWebKitAPI::TEST):
2084
2085 2013-03-04  Chris Fleizach  <cfleizach@apple.com>
2086
2087         AX: Upstream iOS Accessibility DumpRenderTree changes
2088         https://bugs.webkit.org/show_bug.cgi?id=111220
2089
2090         Reviewed by David Kilzer.
2091
2092         Upstream the iOS changes for accessibility in DumpRenderTree.
2093
2094         * DumpRenderTree/AccessibilityUIElement.cpp:
2095         (headerElementAtIndexCallback):
2096         (linkedElementCallback):
2097         (elementsForRangeCallback):
2098         (increaseTextSelectionCallback):
2099         (decreaseTextSelectionCallback):
2100         (assistiveTechnologySimulatedFocusCallback):
2101         (stringForSelectionCallback):
2102         (getIPhoneLabelCallback):
2103         (getIPhoneHintCallback):
2104         (getIPhoneValueCallback):
2105         (getIPhoneIdentifierCallback):
2106         (getIPhoneTraitsCallback):
2107         (getIPhoneIsElementCallback):
2108         (getIPhoneElementTextPositionCallback):
2109         (getIPhoneElementTextLengthCallback):
2110         (AccessibilityUIElement::getJSClass):
2111         * DumpRenderTree/AccessibilityUIElement.h:
2112         (AccessibilityUIElement):
2113         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2114         * DumpRenderTree/ios: Added.
2115         * DumpRenderTree/ios/AccessibilityControllerIOS.mm: Added.
2116         (AccessibilityController::AccessibilityController):
2117         (AccessibilityController::~AccessibilityController):
2118         (AccessibilityController::elementAtPoint):
2119         (AccessibilityController::focusedElement):
2120         (AccessibilityController::rootElement):
2121         (findAccessibleObjectById):
2122         (AccessibilityController::accessibleElementById):
2123         (AccessibilityController::setLogFocusEvents):
2124         (AccessibilityController::setLogScrollingStartEvents):
2125         (AccessibilityController::setLogValueChangeEvents):
2126         (AccessibilityController::setLogAccessibilityEvents):
2127         (AccessibilityController::addNotificationListener):
2128         (AccessibilityController::removeNotificationListener):
2129         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: Added.
2130         (AccessibilityUIElement::AccessibilityUIElement):
2131         (AccessibilityUIElement::~AccessibilityUIElement):
2132         (concatenateAttributeAndValue):
2133         (AccessibilityUIElement::iphoneLabel):
2134         (AccessibilityUIElement::iphoneHint):
2135         (AccessibilityUIElement::iphoneValue):
2136         (AccessibilityUIElement::iphoneIdentifier):
2137         (AccessibilityUIElement::iphoneTraits):
2138         (AccessibilityUIElement::iphoneIsElement):
2139         (AccessibilityUIElement::iphoneElementTextPosition):
2140         (AccessibilityUIElement::iphoneElementTextLength):
2141         (AccessibilityUIElement::url):
2142         (AccessibilityUIElement::x):
2143         (AccessibilityUIElement::y):
2144         (AccessibilityUIElement::width):
2145         (AccessibilityUIElement::height):
2146         (AccessibilityUIElement::clickPointX):
2147         (AccessibilityUIElement::clickPointY):
2148         (AccessibilityUIElement::getChildren):
2149         (AccessibilityUIElement::getChildrenWithRange):
2150         (AccessibilityUIElement::childrenCount):
2151         (AccessibilityUIElement::elementAtPoint):
2152         (AccessibilityUIElement::indexOfChild):
2153         (AccessibilityUIElement::getChildAtIndex):
2154         (AccessibilityUIElement::headerElementAtIndex):
2155         (AccessibilityUIElement::linkedElement):
2156         (AccessibilityUIElement::linkedUIElementAtIndex):
2157         (AccessibilityUIElement::ariaOwnsElementAtIndex):
2158         (AccessibilityUIElement::ariaFlowToElementAtIndex):
2159         (AccessibilityUIElement::disclosedRowAtIndex):
2160         (AccessibilityUIElement::selectedRowAtIndex):
2161         (AccessibilityUIElement::rowAtIndex):
2162         (AccessibilityUIElement::titleUIElement):
2163         (AccessibilityUIElement::parentElement):
2164         (AccessibilityUIElement::disclosedByRow):
2165         (AccessibilityUIElement::increaseTextSelection):
2166         (AccessibilityUIElement::decreaseTextSelection):
2167         (AccessibilityUIElement::stringForSelection):
2168         (AccessibilityUIElement::stringForRange):
2169         (AccessibilityUIElement::attributedStringForRange):
2170         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
2171         (AccessibilityUIElement::elementsForRange):
2172         (AccessibilityUIElement::getLinkedUIElements):
2173         (AccessibilityUIElement::getDocumentLinks):
2174         (AccessibilityUIElement::attributesOfLinkedUIElements):
2175         (AccessibilityUIElement::attributesOfDocumentLinks):
2176         (AccessibilityUIElement::attributesOfChildren):
2177         (AccessibilityUIElement::allAttributes):
2178         (AccessibilityUIElement::stringAttributeValue):
2179         (AccessibilityUIElement::isPressActionSupported):
2180         (AccessibilityUIElement::isIncrementActionSupported):
2181         (AccessibilityUIElement::isDecrementActionSupported):
2182         (AccessibilityUIElement::boolAttributeValue):
2183         (AccessibilityUIElement::isAttributeSettable):
2184         (AccessibilityUIElement::isAttributeSupported):
2185         (AccessibilityUIElement::parameterizedAttributeNames):
2186         (AccessibilityUIElement::role):
2187         (AccessibilityUIElement::subrole):
2188         (AccessibilityUIElement::roleDescription):
2189         (AccessibilityUIElement::title):
2190         (AccessibilityUIElement::description):
2191         (AccessibilityUIElement::orientation):
2192         (AccessibilityUIElement::stringValue):
2193         (AccessibilityUIElement::language):
2194         (AccessibilityUIElement::helpText):
2195         (AccessibilityUIElement::intValue):
2196         (AccessibilityUIElement::minValue):
2197         (AccessibilityUIElement::maxValue):
2198         (AccessibilityUIElement::valueDescription):
2199         (AccessibilityUIElement::insertionPointLineNumber):
2200         (AccessibilityUIElement::isEnabled):
2201         (AccessibilityUIElement::isRequired):
2202         (AccessibilityUIElement::isFocused):
2203         (AccessibilityUIElement::isSelected):
2204         (AccessibilityUIElement::isExpanded):
2205         (AccessibilityUIElement::isChecked):
2206         (AccessibilityUIElement::hierarchicalLevel):
2207         (AccessibilityUIElement::ariaIsGrabbed):
2208         (AccessibilityUIElement::ariaDropEffects):
2209         (AccessibilityUIElement::lineForIndex):
2210         (AccessibilityUIElement::boundsForRange):
2211         (AccessibilityUIElement::attributesOfColumnHeaders):
2212         (AccessibilityUIElement::attributesOfRowHeaders):
2213         (AccessibilityUIElement::attributesOfColumns):
2214         (AccessibilityUIElement::attributesOfRows):
2215         (AccessibilityUIElement::attributesOfVisibleCells):
2216         (AccessibilityUIElement::attributesOfHeader):
2217         (AccessibilityUIElement::rowCount):
2218         (AccessibilityUIElement::columnCount):
2219         (AccessibilityUIElement::indexInTable):
2220         (AccessibilityUIElement::rowIndexRange):
2221         (AccessibilityUIElement::columnIndexRange):
2222         (AccessibilityUIElement::cellForColumnAndRow):
2223         (AccessibilityUIElement::selectedTextRange):
2224         (AccessibilityUIElement::assistiveTechnologySimulatedFocus):
2225         (AccessibilityUIElement::setSelectedTextRange):
2226         (AccessibilityUIElement::increment):
2227         (AccessibilityUIElement::decrement):
2228         (AccessibilityUIElement::showMenu):
2229         (AccessibilityUIElement::press):
2230         (AccessibilityUIElement::accessibilityValue):
2231         (AccessibilityUIElement::documentEncoding):
2232         (AccessibilityUIElement::documentURI):
2233         (_accessibilityNotificationCallback):
2234         (AccessibilityUIElement::addNotificationListener):
2235         (AccessibilityUIElement::removeNotificationListener):
2236         (AccessibilityUIElement::isFocusable):
2237         (AccessibilityUIElement::isSelectable):
2238         (AccessibilityUIElement::isMultiSelectable):
2239         (AccessibilityUIElement::isSelectedOptionActive):
2240         (AccessibilityUIElement::isVisible):
2241         (AccessibilityUIElement::isOffScreen):
2242         (AccessibilityUIElement::isCollapsed):
2243         (AccessibilityUIElement::isIgnored):
2244         (AccessibilityUIElement::hasPopup):
2245         (AccessibilityUIElement::takeFocus):
2246         (AccessibilityUIElement::takeSelection):
2247         (AccessibilityUIElement::addSelection):
2248         (AccessibilityUIElement::removeSelection):
2249         (AccessibilityUIElement::uiElementForSearchPredicate):
2250         (AccessibilityUIElement::numberAttributeValue):
2251
2252 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
2253
2254         [chromium] pass all focus handling methods through the WebTestDelegate
2255         https://bugs.webkit.org/show_bug.cgi?id=111328
2256
2257         Reviewed by Nico Weber.
2258
2259         In content_shell, the focus handling is asynchronous. To allow for
2260         switching the focus synchronously between WebViews, we need to intercept
2261         didFocus and didBlur and forward it to the WebTestDelegate.
2262
2263         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2264         (WebTestDelegate):
2265         (WebTestRunner::WebTestDelegate::setFocus):
2266         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2267         (WebTestRunner::WebTestProxy::didFocus):
2268         (WebTestRunner::WebTestProxy::didBlur):
2269         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2270         (WebTestRunner::TestRunner::setWindowIsKey):
2271         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2272         (WebTestRunner::WebTestProxyBase::didFocus):
2273         (WebTestRunner):
2274         (WebTestRunner::WebTestProxyBase::didBlur):
2275         * DumpRenderTree/chromium/WebViewHost.cpp:
2276         (WebViewHost::didFocus):
2277         (WebViewHost::didBlur):
2278         (WebViewHost::setFocus):
2279         * DumpRenderTree/chromium/WebViewHost.h:
2280         (WebViewHost):
2281
2282 2013-03-04  Claudio Saavedra  <csaavedra@igalia.com>
2283
2284         [GTK] No need to manually add system paths to jhbuildrc
2285         https://bugs.webkit.org/show_bug.cgi?id=110850
2286
2287         Reviewed by Gustavo Noronha Silva.
2288
2289         * gtk/jhbuildrc: Remove calls to addpath() for items that jhbuild
2290         already takes care of.
2291
2292 2013-03-04  Kinuko Yasuda  <kinuko@chromium.org>
2293
2294         [chromium] TestWebKitAPI WTF.StringHasher_addCharacters is broken on Chromium Android
2295         https://bugs.webkit.org/show_bug.cgi?id=111284
2296
2297         Disabling the failing two tests on Android.
2298
2299         Reviewed by Jochen Eisinger.
2300
2301         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
2302         (TestWebKitAPI):
2303         (TestWebKitAPI::TEST):
2304
2305 2013-03-04  Kunihiko Sakamoto  <ksakamoto@chromium.org>
2306
2307         Add build flag for FontLoader
2308         https://bugs.webkit.org/show_bug.cgi?id=111289
2309
2310         Reviewed by Benjamin Poulain.
2311
2312         Add ENABLE_FONT_LOAD_EVENTS build flag (disabled by default).
2313
2314         * Scripts/webkitperl/FeatureList.pm:
2315         * qmake/mkspecs/features/features.pri:
2316
2317 2013-03-03  Benjamin Poulain  <benjamin@webkit.org>
2318
2319         [Mac] Get rid of a useless method from DOMHTMLInputElement
2320         https://bugs.webkit.org/show_bug.cgi?id=111279
2321
2322         Reviewed by Sam Weinig.
2323
2324         * DumpRenderTree/mac/TestRunnerMac.mm:
2325         (TestRunner::setValueForUser):
2326         The method _setValueForUser: was added for testing. This feature is already
2327         exposed by DOMHTMLInputElement as a private API and it is how this code is exercised
2328         in real use cases. Get rid of the method created for testing, use the real thing
2329         instead.
2330
2331 2013-03-03  Ryosuke Niwa  <rniwa@webkit.org>
2332
2333         Some perf. tests have variances that differ greatly between runs
2334         https://bugs.webkit.org/show_bug.cgi?id=97510
2335
2336         Reviewed by Benjamin Poulain.
2337
2338         Use multiple instances of DumpRenderTree or WebKitTestRunner to amortize the effect of the runtime
2339         environment on test results (we run each instance after one another, not in parallel).
2340
2341         We use 4 instances of the test runner, each executing 5 in-process iterations, for the total of 20
2342         iterations as it was done previously in single process. These values are hard-coded in perftest.py
2343         and runner.js but they are to be configurable in the future.
2344
2345         Set of 5 iterations obtained by the same test runner is treated as an "iteration group" and each
2346         metric now reports an array of the length 4 with each element containing an array of 5 iteration
2347         values obtained by each test runner instance as opposed to a flattened array of 20 iteration values.
2348
2349         Unfortunately, we can use the same trick on Dromaeo because we're already doing only 5 iterations
2350         and repeating the entire Dromaeo 4 times will take too long. We need to disable more Dromaeo tests
2351         as needed. To this end, added SingleProcessPerfTest to preserve the old behavior.
2352
2353         * Scripts/webkitpy/performance_tests/perftest.py:
2354         (PerfTestMetric.append_group): Renamed from append.
2355         (PerfTestMetric.grouped_iteration_values): Added.
2356         (PerfTestMetric.flattened_iteration_values): Renamed from iteration_values.
2357
2358         (PerfTest.__init__): Takes the number of processes (drivers) to run tests with.
2359         This parameter is only used by SingleProcessPerfTest.
2360
2361         (PerfTest.run): Repeat tests using different driver processes.
2362         (PerfTest._run_with_driver): Returns a boolean instead of a list of measured metrics
2363         since metrics are shared between multiple drivers (i.e. multiple calls to _run_with_driver).
2364         We instead use _ensure_metrics to obtain the matched metrics and store the data there.
2365         (PerfTest._ensure_metrics): Added.
2366
2367         (SingleProcessPerfTest): Added. Used to run Dromaeo tests where running it on 4 different
2368         instances of DumpRenderTree/WebKitTestRunner takes too long.
2369         (SingleProcessPerfTest.__init__):
2370
2371         (ReplayPerfTest._run_with_driver): Updated to use _ensure_metrics.
2372
2373         (PerfTestFactory): Use SingleProcessPerfTest to run Dromaeo tests.
2374
2375         * Scripts/webkitpy/performance_tests/perftest_unittest.py: Updated various tests that expect
2376         _run_with_driver to return a list of metrics. Now it returns a boolean indicating whether
2377         the test succeeded or not. Obtain the dictionary of metrics via test._metrics instead.
2378
2379         (TestPerfTestMetric.test_append): Updated per name and added some test cases for
2380         grouped_iteration_values.
2381
2382         (TestPerfTest._assert_results_are_correct):
2383
2384         (TestSingleProcessPerfTest): Added.
2385         (TestSingleProcessPerfTest.test_use_only_one_process):
2386         (TestSingleProcessPerfTest.test_use_only_one_process.run_single):
2387
2388         (TestReplayPerfTest.test_run_with_driver_accumulates_results):
2389         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):
2390
2391         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py: Updated values of
2392         sample standard deviations since we're now running tests 4 times.
2393         (MainTest._test_run_with_json_output.mock_upload_json):
2394         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
2395
2396 2013-03-03  Alexandre Elias  <aelias@chromium.org>
2397
2398         [chromium] Remove WebLayerTreeView::setViewportSize call
2399         https://bugs.webkit.org/show_bug.cgi?id=110727
2400
2401         Reviewed by James Robinson.
2402
2403         After https://codereview.chromium.org/12328080 lands,
2404         setViewportSize is called from the Chromium side. The multiplication
2405         by deviceScaleFactor here was prone to off-by-one errors.
2406         The layoutSize() function was only used here so delete it as well.
2407
2408         DumpRenderTree WebViewHost must now call this method as well.
2409
2410         * DumpRenderTree/chromium/WebViewHost.cpp:
2411         (WebViewHost::initializeLayerTreeView):
2412         (WebViewHost::setWindowRect):
2413         (WebViewHost::setDeviceScaleFactor):
2414         (WebViewHost::updateViewportSize):
2415         * DumpRenderTree/chromium/WebViewHost.h:
2416         (WebViewHost):
2417
2418 2013-02-27  Darin Adler  <darin@apple.com>
2419
2420         StringHasher functions require alignment that call sites do not all guarantee
2421         https://bugs.webkit.org/show_bug.cgi?id=110171
2422
2423         Reviewed by Benjamin Poulain.
2424
2425         * TestWebKitAPI/CMakeLists.txt:
2426         * TestWebKitAPI/GNUmakefile.am:
2427         * TestWebKitAPI/TestWebKitAPI.gypi:
2428         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2429         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
2430         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2431         * TestWebKitAPI/Tests/WTF/WTF.pro:
2432         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2433         Added the StringHasher.cpp file.
2434
2435         * TestWebKitAPI/Tests/WTF/StringHasher.cpp: Added. Contains a bunch of tests
2436         for the functions in the StringHasher class.
2437
2438 2013-03-02  Benjamin Poulain  <bpoulain@apple.com>
2439
2440         Move computedStyleIncludingVisitedInfo from TestRunner to Internals
2441         https://bugs.webkit.org/show_bug.cgi?id=109772
2442
2443         Reviewed by Andreas Kling.
2444
2445         * DumpRenderTree/TestRunner.cpp:
2446         (TestRunner::staticFunctions):
2447         * DumpRenderTree/TestRunner.h:
2448         (TestRunner):
2449         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2450         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2451         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2452         * DumpRenderTree/mac/TestRunnerMac.mm:
2453         * DumpRenderTree/qt/TestRunnerQt.cpp:
2454         * DumpRenderTree/qt/TestRunnerQt.h:
2455         (TestRunner):
2456         * DumpRenderTree/win/TestRunnerWin.cpp:
2457         * DumpRenderTree/wx/TestRunnerWx.cpp:
2458         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2459         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2460         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2461         (TestRunner):
2462
2463 2013-03-01  Ilya Tikhonovsky  <loislo@chromium.org>
2464
2465         Web Inspector: Native Memory Instrumentation: do not visit raw pointers by default.
2466         https://bugs.webkit.org/show_bug.cgi?id=110943
2467
2468         Reviewed by Yury Semikhatsky.
2469
2470         Unfortunately in many cases raw pointer may point to an object that has been deleted.
2471         There is no working solution to solve this problem in general.
2472         It could be solved only on case by case basis.
2473
2474         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
2475         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:
2476         (TestWebKitAPI::TEST):
2477
2478 2013-03-01  Jason Anderssen  <janderssen@gmail.com>
2479
2480         Move markerTextForListItem from TestRunner to Internals
2481         https://bugs.webkit.org/show_bug.cgi?id=110939
2482
2483         Reviewed by Benjamin Poulain.
2484
2485         * DumpRenderTree/TestRunner.cpp:
2486         (TestRunner::staticFunctions):
2487         * DumpRenderTree/TestRunner.h:
2488         (TestRunner):
2489         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2490         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2491         (WebTestRunner::TestRunner::TestRunner):
2492         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2493         (TestRunner):
2494         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2495         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2496         * DumpRenderTree/mac/TestRunnerMac.mm:
2497         * DumpRenderTree/qt/TestRunnerQt.cpp:
2498         * DumpRenderTree/qt/TestRunnerQt.h:
2499         (TestRunnerQt):
2500         * DumpRenderTree/win/TestRunnerWin.cpp:
2501         * DumpRenderTree/wx/TestRunnerWx.cpp:
2502         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2503         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2504         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2505         (TestRunner):
2506
2507 2013-03-01  Ryosuke Niwa  <rniwa@webkit.org>
2508
2509         Don't use legacy test names when returning results from PerfTest.run
2510         https://bugs.webkit.org/show_bug.cgi?id=111148
2511
2512         Reviewed by Dirk Pranke.
2513
2514         * Scripts/webkitpy/performance_tests/perftest.py:
2515         (PerfTestMetric.name): Renamed from metric.
2516         (PerfTest.test_name_without_file_extension): Extracted from legacy_chromium_bot_compatible_test_name.
2517         (PerfTest.run): Use metric name instead of the legacy name to store iteration values.
2518         (ChromiumStylePerfTest.parse_and_log_output): Use the metric name to store results as done in PerfTest.run.
2519
2520         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2521         (TestPerfTestMetric.test_init_set_time_metric):
2522         (TestPerfTestMetric.legacy_chromium_bot_compatible_test_name): Removed. The integration tests test this.
2523         (TestReplayPerfTest.test_run_with_driver_accumulates_results):
2524         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):
2525
2526         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2527         (PerfTestsRunner.__init__):
2528         (PerfTestsRunner._generate_results_dict): Updated to iterate over (test, metrics) pair. Use view_source_url
2529         to obtain the trac URL instead of hard coding it.
2530         (PerfTestsRunner._run_tests_set):
2531
2532 2013-03-01  Roger Fong  <roger_fong@apple.com>
2533
2534         Unreviewed. Add an extra project that assembles all project build logs on Windows into a single file.
2535         https://bugs.webkit.org/show_bug.cgi?id=111202
2536
2537         This is useful for running VCExpress builds from command line because there is
2538         no unified solution output, only per project build logs.
2539         The project will be run as the last project in the solution.
2540
2541         * win/AssembleBuildLogs: Added.
2542         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj: Added.
2543         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj.filters: Added.
2544         * win/AssembleBuildLogs/AssembleLogs.cmd: Added.
2545         * win/AssembleBuildLogs/README: Added.
2546
2547 2013-03-01  Roger Fong  <roger_fong@apple.com>
2548
2549         Unreviewed. Increase number of patches processed before clean building on WinEWS bots.
2550
2551         * EWSTools/start-queue-win.sh:
2552
2553 2013-03-01  Ryosuke Niwa  <rniwa@webkit.org>
2554
2555         Don't return statistics in PerfTest.run
2556         https://bugs.webkit.org/show_bug.cgi?id=111145
2557
2558         Reviewed by Dirk Pranke.
2559
2560         Simply return a list of values obtained in each iteration from PerfTest.run.
2561         Also simplify various methods as needed.
2562
2563         * Scripts/webkitpy/performance_tests/perftest.py:
2564         (PerfTestMetric.__init__): Moved the code to convert 'Time' metric to 'FrameRate' and 'Runs'
2565         as needed from PerfTestsRunner._generate_results_dict.
2566
2567         (PerfTestMetric.legacy_chromium_bot_compatible_test_name): Always append the metric name now
2568         that we don't have to worry about the backward compatibility here.
2569
2570         (PerfTestMetric.iteration_values): Added.
2571         (PerfTestMetric.unit): Added.
2572         (PerfTestMetric.metric_to_unit):
2573         (PerfTestMetric.time_unit_to_metric): Extracted from PerfTestsRunner._generate_results_dict.
2574
2575         (PerfTest.run):
2576         (PerfTest.log_statistics): Merged compute_statistics and self.output_statistics.
2577
2578         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2579         (TestPerfTestMetric.test_init_set_missing_unit):
2580         (TestPerfTestMetric.test_init_set_time_metric): Added.
2581         (TestPerfTestMetric.test_legacy_chromium_bot_compatible_test_name):
2582         (TestPerfTestMetric.test_append):
2583         (TestPerfTestMetric.test_compute_statistics): Removed. Integration tests check some of these
2584         test cases and it's not critical to keep math right as they're not used in output JSON anymore.
2585         (TestPerfTest._assert_results_are_correct):
2586         (TestReplayPerfTest.test_run_with_driver_accumulates_results):
2587         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):
2588
2589         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2590         (PerfTestsRunner._generate_results_dict):
2591
2592         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2593         (EventTargetWrapperTestData): The metric name shows up at the end of the test name as expected.
2594         (SomeParserTestData): Ditto.
2595         (MemoryTestData): Ditto.
2596
2597 2013-03-01  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2598
2599         [Qt] Enable LINK_PREFETCH
2600         https://bugs.webkit.org/show_bug.cgi?id=111158
2601
2602         Reviewed by Simon Hausmann.
2603
2604         * qmake/mkspecs/features/features.pri:
2605
2606 2013-03-01  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2607
2608         [Qt] Update features.pri with new features
2609         https://bugs.webkit.org/show_bug.cgi?id=111157
2610
2611         Reviewed by Jocelyn Turcotte.
2612
2613         * qmake/mkspecs/features/features.pri:
2614
2615 2013-03-01  Jochen Eisinger  <jochen@chromium.org>
2616
2617         [chromium] put WebTestProxy::scheduleComposite back in place
2618         https://bugs.webkit.org/show_bug.cgi?id=111146
2619
2620         Reviewed by Nico Weber.
2621
2622         The call was removed in http://trac.webkit.org/changeset/144398 because
2623         DRT doesn't need it. However, content shell depends on this call.
2624
2625         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2626         (WebTestRunner::WebTestProxy::scheduleComposite):
2627
2628 2013-02-28  Ryosuke Niwa  <rniwa@webkit.org>
2629
2630         Merge PerfTestRunner._run_single_test into PerfTestRunner._run_tests_set
2631         https://bugs.webkit.org/show_bug.cgi?id=111142
2632
2633         Reviewed by Adam Barth.
2634
2635         Merged _run_single_test into _run_tests_set. The code looks much cleaner now.
2636
2637         Also removed _print_status since it's never used anywhere.
2638
2639         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2640         (PerfTestsRunner.run):
2641         (PerfTestsRunner._run_tests_set):
2642         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2643         (MainTest.run_test):
2644         (MainTest.test_run_test_set):
2645         (MainTest.test_run_test_set_kills_drt_per_run):
2646         (MainTest.test_run_test_set_for_parser_tests):
2647
2648 2013-02-28  Kiran Muppala  <cmuppala@apple.com>
2649
2650         Disable window occlusion detection for WebKitTestRunner Web View on Mac
2651         https://bugs.webkit.org/show_bug.cgi?id=111116
2652
2653         Reviewed by Simon Fraser.
2654
2655         Window occlusion notifications were causing WebKitTestRunner's Web View
2656         to be detected as occluded and causing a few JavaScript timer layout
2657         tests to fail.  https://bugs.webkit.org/show_bug.cgi?id=111025, fixed this
2658         by initializing the page visibility to "visible" after creating the view.
2659         But a better solution is to disable window occlusion detection, so that
2660         not only the page but also the view is treated as visible.
2661
2662         * WebKitTestRunner/TestController.cpp:
2663         (WTR::TestController::createWebViewWithOptions): Remove call to
2664         setVisibilityState, since it is no longer necessary.
2665         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2666         (WTR::PlatformWebView::PlatformWebView): Disable window occlusion
2667         detection for the created WKView.
2668
2669 2013-02-28  Li Yin  <li.yin@intel.com>
2670
2671         [chromium] Events can't be triggered on MediaStreamTrack
2672         https://bugs.webkit.org/show_bug.cgi?id=110930
2673
2674         Reviewed by Kentaro Hara.
2675
2676         Related code was moved to MediaStreamCenterChromium::didStopLocalMediaStream
2677
2678         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp:
2679         (WebTestRunner::MockWebMediaStreamCenter::didStopLocalMediaStream):
2680
2681 2013-02-27  James Robinson  <jamesr@chromium.org>
2682
2683         [chromium] Use DumpRenderTree-specific interface for DRT's compositor embedding
2684         https://bugs.webkit.org/show_bug.cgi?id=111017
2685
2686         Reviewed by Adam Barth.
2687
2688         This decouples DumpRenderTree from WebLayerTreeViewClient.
2689
2690         * DumpRenderTree/chromium/WebViewHost.cpp:
2691         (WebViewHostDRTLayerTreeViewClient):
2692         (WebViewHostDRTLayerTreeViewClient::WebViewHostDRTLayerTreeViewClient):
2693         (WebViewHostDRTLayerTreeViewClient::~WebViewHostDRTLayerTreeViewClient):
2694         (WebViewHostDRTLayerTreeViewClient::Layout):
2695         (WebViewHostDRTLayerTreeViewClient::ScheduleComposite):
2696         (WebViewHost::initializeLayerTreeView):
2697         * DumpRenderTree/chromium/WebViewHost.h:
2698         (webkit_support):
2699         (WebViewHost):
2700
2701 2013-02-28  Ryuan Choi  <ryuan.choi@samsung.com>
2702
2703         Unreviewed, add my secondary email address to the list.
2704
2705         * Scripts/webkitpy/common/config/committers.py:
2706
2707 2013-02-28  Philip Rogers  <pdr@google.com>
2708
2709         Add Philip Rogers as a reviewer.
2710
2711         Unreviewed update of committers.py.
2712
2713         * Scripts/webkitpy/common/config/committers.py:
2714
2715 2013-02-28  Ryosuke Niwa  <rniwa@webkit.org>
2716
2717         Merge more methods on PerfTest
2718         https://bugs.webkit.org/show_bug.cgi?id=111030
2719
2720         Reviewed by Dirk Pranke.
2721
2722         Merged parse_output into _run_with_driver as it was the only caller. Also merged _should_ignore_line_in_stderr
2723         and _should_ignore_line_in_parser_test_result into _filter_output since it was their only caller.
2724
2725         This makes the control flow a lot more comprehensible.
2726
2727         * Scripts/webkitpy/performance_tests/perftest.py:
2728         (PerfTest._run_with_driver):
2729         (PerfTest._should_ignore_line):
2730         (PerfTest._filter_output):
2731
2732         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2733         (TestPerfTest._assert_results_are_correct):
2734         (test_ignored_stderr_lines):
2735
2736 2013-02-28  Robert Hogan  <robert@webkit.org>
2737
2738         Update my IRC nick
2739
2740         Unreviewed.
2741
2742         * Scripts/webkitpy/common/config/committers.py:
2743
2744 2013-02-28  Andras Becsi  <andras.becsi@digia.com>
2745
2746         [Qt] Enable thin archives before parsing the project files
2747
2748         Rubber-stamped by Simon Hausmann.
2749
2750         The targetSubDir() function can be called before default_post.prf has been
2751         parsed therefore the gnu_thin_archives option has to be set in default_pre.prf
2752         which is parsed before the main project file.
2753         This issue was revealed by r144299 and fixes the clean build.
2754
2755         * qmake/mkspecs/features/default_post.prf:
2756         * qmake/mkspecs/features/default_pre.prf:
2757
2758 2013-02-28  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2759
2760         [Qt] Enable CANVAS_PATH flag
2761         https://bugs.webkit.org/show_bug.cgi?id=108508
2762
2763         Reviewed by Simon Hausmann.
2764
2765         Also enable CANVAS_PATH flag for Qt.
2766
2767         * qmake/mkspecs/features/features.pri:
2768
2769 2013-02-28  Andras Becsi  <andras.becsi@digia.com>
2770
2771         [Qt][TestWebKitAPI] The activeBuildConfig() function has been replaced with targetSubDir()
2772
2773         Rubber-stamped by Csaba Osztrogonác.
2774
2775         Besides suppressing a warning about the non-existing function this
2776         fixes the build if there is a subdirectory (eg. debug-and-release).
2777
2778         * TestWebKitAPI/InjectedBundle.pri:
2779         * TestWebKitAPI/TestWebKitAPI.pri:
2780
2781 2013-02-28  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2782
2783         [EFL][WTR] WTR cannot load injected bundle
2784         https://bugs.webkit.org/show_bug.cgi?id=111063
2785
2786         Reviewed by Csaba Osztrogonác.
2787
2788         WTR was not able to load injected bundle because of undefined 
2789         symbols for AccessibilityUIElement::scrollToMakeVisible(). 
2790         Adding empty implementation of this function to AccessibilityUIElementAtk.cpp
2791         solves the problem.
2792
2793         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2794         (WTR::AccessibilityUIElement::scrollToMakeVisible):
2795
2796 2013-02-28  Alberto Garcia  <albgarcia@rim.com>
2797
2798         [BlackBerry] TestRunnerBlackBerry: remove layerTreeAsText, it's gone from upstream
2799         https://bugs.webkit.org/show_bug.cgi?id=110464
2800
2801         Reviewed by Rob Buis.
2802
2803         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2804
2805 2013-02-28  Xan Lopez  <xlopez@rim.com>
2806
2807         [BlackBerry] DumpRenderTreeSupport: update the set position methods
2808         https://bugs.webkit.org/show_bug.cgi?id=110578
2809
2810         Reviewed by Rob Buis.
2811
2812         TestRunner::setMockGeolocationPosition() changed in r130416:
2813         http://trac.webkit.org/changeset/130416/trunk/Tools/DumpRenderTree/TestRunner.h
2814
2815         DumpRenderTreeSupport::setMockGeolocationError() was renamed to
2816         setMockGeolocationPositionUnavailableError() in r129444:
2817         http://trac.webkit.org/changeset/129444/trunk/Source/WebKit/blackberry/WebKitSupport/DumpRenderTreeSupport.h
2818
2819         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2820         (TestRunner::setMockGeolocationPosition):
2821         (TestRunner::setMockGeolocationPositionUnavailableError):
2822
2823 2013-02-28  Xan Lopez  <xlopez@rim.com>
2824
2825         [BlackBerry] WorkQueueItemBlackBerry: use the new FrameLoader API
2826         https://bugs.webkit.org/show_bug.cgi?id=110465
2827
2828         Reviewed by Rob Buis.
2829
2830         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
2831         (LoadItem::invoke):
2832
2833 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
2834
2835         PerfTestRunner doesn't need _needs_http and _has_http_lock
2836         https://bugs.webkit.org/show_bug.cgi?id=111037
2837
2838         Reviewed by Adam Barth.
2839
2840         Delete these variables in favor of using a local variable.
2841
2842         Member variables are like global variables. They introduce implicit dependencies
2843         between member functions.
2844
2845         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2846         (PerfTestsRunner.__init__):
2847         (PerfTestsRunner._start_http_servers):
2848         (PerfTestsRunner):
2849         (PerfTestsRunner._stop_http_servers):
2850         (PerfTestsRunner.run):
2851
2852 2013-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2853
2854         Unreviewed, rolling out r144224.
2855         http://trac.webkit.org/changeset/144224
2856         https://bugs.webkit.org/show_bug.cgi?id=111045
2857
2858         Caused plugins/pass-different-npp-struct.html to time out
2859         (Requested by abarth on #webkit).
2860
2861         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
2862         (PassDifferentNPPStruct::NPP_SetWindow):
2863         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2864         (NPP_SetWindow):
2865
2866 2013-02-27  Adam Barth  <abarth@webkit.org>
2867
2868         [Chromium] Enable threaded HTML parser by default in DumpRenderTree
2869         https://bugs.webkit.org/show_bug.cgi?id=110907
2870
2871         Reviewed by Eric Seidel.
2872
2873         This patch changes --enable-threaded-html-parser into
2874         --disable-threaded-html-parser and thereby enables the threaded HTML
2875         parser by default for the Chromium port.
2876
2877         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2878         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2879         (WebTestRunner::WebPreferences::reset):
2880         * DumpRenderTree/chromium/TestShell.cpp:
2881         (TestShell::TestShell):
2882
2883 2013-02-27  Kiran Muppala  <cmuppala@apple.com>
2884
2885         Initialize page visibility after creating WebKitTestRunner WebView on Mac
2886         https://bugs.webkit.org/show_bug.cgi?id=111025
2887
2888         Reviewed by Simon Fraser.
2889
2890         Set page visibility to "visible" after creating WebView to override
2891         visibility state inferred from window occlusion notifications on Mac.
2892
2893         * WebKitTestRunner/TestController.cpp:
2894         (WTR::TestController::createWebViewWithOptions): Add call to
2895         setVisibilityState.
2896
2897 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
2898
2899         Merge PageLoadingPerfTest into ReplayPerfTest
2900         https://bugs.webkit.org/show_bug.cgi?id=111027
2901
2902         Reviewed by Dirk Pranke.
2903
2904         Merged two classes.
2905
2906         We should really move ahead with the bug 100991 and get rid of PageLoadingPerfTest
2907         part of ReplayPerfTest.
2908
2909         * Scripts/webkitpy/performance_tests/perftest.py:
2910         (ReplayPerfTest): Moved _FORCE_GC_FILE here.
2911         (ReplayPerfTest.__init__):
2912         (ReplayPerfTest._run_with_driver): Moved from PageLoadingPerfTest.
2913         (ReplayPerfTest.run_single): Load the GC page as run_single on PageLoadingPerfTest did.
2914         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2915         (TestReplayPerfTest):
2916         (TestReplayPerfTest.test_run_single.run_test):
2917         (TestReplayPerfTest.test_run_single): Make sure test_time is passed down properly from output.
2918         (TestReplayPerfTest.test_run_with_driver_accumulates_results): Renamed from
2919         TestPageLoadingPerfTest.test_run.
2920         (TestReplayPerfTest.test_run_with_driver_accumulates_results.mock_run_signle):
2921         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results): Renamed from
2922         TestPageLoadingPerfTest.test_run_with_memory_output
2923         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results.mock_run_signle):
2924         (TestReplayPerfTest.test_prepare_calls_run_single):
2925
2926 2013-02-27  Eric Seidel  <eric@webkit.org>
2927
2928         Add --additional-drt-flag option to run-perf-tests to make it easy to test runtime options
2929         https://bugs.webkit.org/show_bug.cgi?id=111021
2930
2931         Reviewed by Dirk Pranke.
2932
2933         The underlying code (which is shared with run-webkit-tests)
2934         already knew how to support this option, it just wasn't exposed
2935         via the run-perf-tests front-end.  This patch fixes that.
2936
2937         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2938         (PerfTestsRunner._parse_args):
2939
2940 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
2941
2942         Stop uploading results to webkit-perf.appspot.com
2943         https://bugs.webkit.org/show_bug.cgi?id=110954
2944
2945         Reviewed by Benjamin Poulain.
2946
2947         Pass in perf.webkit.org instead of webkit-perf.appspot.com as the test results server.
2948
2949         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2950         (RunAndUploadPerfTests):
2951
2952 2013-02-27  James Simonsen  <simonjam@chromium.org>
2953
2954         [chromium] Lower priority of preloaded images
2955         https://bugs.webkit.org/show_bug.cgi?id=110527
2956
2957         Plumb the didChangePriority signal into DRT so it can be tested.
2958
2959         Reviewed by Nate Chapin.
2960
2961         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2962         (WebKit):
2963         (WebTestRunner::WebTestProxy::didChangeResourcePriority):
2964         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2965         (WebTestRunner::TestRunner::TestRunner):
2966         (WebTestRunner::TestRunner::reset):
2967         (WebTestRunner::TestRunner::shouldDumpResourcePriorities):
2968         (WebTestRunner):
2969         (WebTestRunner::TestRunner::dumpResourceRequestPriorities):
2970         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2971         (TestRunner):
2972         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2973         (WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
2974         (WebTestRunner::WebTestProxyBase::willSendRequest):
2975         (WebTestRunner::WebTestProxyBase::didChangeResourcePriority):
2976         (WebTestRunner):
2977
2978 2013-02-27  Chris Fleizach  <cfleizach@apple.com>
2979
2980         AX: Mac platform should support ability to scroll an element into visible
2981         https://bugs.webkit.org/show_bug.cgi?id=109860
2982
2983         Reviewed by Beth Dakin.
2984
2985         * DumpRenderTree/AccessibilityUIElement.cpp:
2986         (scrollToMakeVisibleCallback):
2987         (AccessibilityUIElement::getJSClass):
2988         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2989         (AccessibilityUIElement::scrollToMakeVisible):
2990         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2991         (WTR::AccessibilityUIElement::scrollToMakeVisible):
2992         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2993         (AccessibilityUIElement):
2994         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2995         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2996         (WTR::AccessibilityUIElement::scrollToMakeVisible):
2997         (WTR):
2998
2999 2013-02-27  John Bauman  <jbauman@chromium.org>
3000
3001         Plugin in iframe may not display
3002         https://bugs.webkit.org/show_bug.cgi?id=109879
3003
3004         Reviewed by Simon Fraser.
3005
3006         LogNPPSetWindow will be used with other ports as well.
3007
3008         * DumpRenderTree/DumpRenderTree.gypi:
3009         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
3010
3011 2013-02-27  Jochen Eisinger  <jochen@chromium.org>
3012
3013         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
3014         https://bugs.webkit.org/show_bug.cgi?id=110973
3015
3016         Reviewed by Adam Barth.
3017
3018         There is nothing that ensures that the log messages from the plugin
3019         come in before the layout test finished loading.
3020
3021         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
3022         (PassDifferentNPPStruct::NPP_SetWindow):
3023         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3024         (NPP_SetWindow):
3025
3026 2013-02-27  Glenn Adams  <glenn@skynav.com>
3027
3028         Add ENABLE_CSS3_TEXT_LINE_BREAK flag.
3029         https://bugs.webkit.org/show_bug.cgi?id=110944
3030
3031         Reviewed by Dean Jackson.
3032
3033         * Scripts/webkitperl/FeatureList.pm:
3034         * qmake/mkspecs/features/features.pri:
3035
3036 2013-02-27  Yong Li  <yong.li.webkit@outlook.com>
3037
3038         Unreviewed. Remove myself from watchlist.
3039
3040         * Scripts/webkitpy/common/config/watchlist:
3041
3042 2013-02-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3043
3044         Switch QtWebKit to GStreamer 1.0.
3045         https://bugs.webkit.org/show_bug.cgi?id=106669.
3046
3047         Original patch by Sebastian Dröge.
3048         Reviewed by Csaba Osztrogonác.
3049
3050         Build with GStreamer 1.0 if available, but support GStreamer 0.10 
3051         temporarily to make upgrading easy and the patch suitable for Qt5.
3052
3053         * qmake/mkspecs/features/features.prf:
3054
3055 2013-02-27  Szilard Ledan  <szledan@inf.u-szeged.hu>
3056
3057         Unreviewed. Added myself to committers.py
3058
3059         * Scripts/webkitpy/common/config/committers.py:
3060
3061 2013-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
3062
3063         Unreviewed, rolling out r144192.
3064         http://trac.webkit.org/changeset/144192
3065         https://bugs.webkit.org/show_bug.cgi?id=110984
3066
3067         Stored svn password on wrong computer (Requested by kkristof
3068         on #webkit).
3069
3070         * Scripts/webkitpy/common/config/committers.py:
3071
3072 2013-02-27  Szilard Ledan  <szledan@inf.u-szeged.hu>
3073
3074         Unreviewed. Added myself to committers.py
3075
3076         * Scripts/webkitpy/common/config/committers.py:
3077
3078 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
3079
3080         Build fix after r144155. The report page is located at /api/report, not /api/test/report.
3081
3082         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3083         (PerfTestsRunner._upload_json):
3084
3085 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
3086
3087         Stop uploading results to webkit-perf.appspot.com
3088         https://bugs.webkit.org/show_bug.cgi?id=110954
3089
3090         Reviewed by Benjamin Poulain.
3091
3092         When the specified test results server was webkit-perf.appspot.com, replace it by perf.webkit.org.
3093         Also, always use the new JSON format. Removed the code to generate the old format.
3094
3095         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3096         (PerfTestsRunner._generate_and_show_results):
3097         (PerfTestsRunner._generate_results_dict):
3098         (PerfTestsRunner._merge_slave_config_json):
3099         (PerfTestsRunner._generate_output_files):
3100
3101 2013-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
3102
3103         Unreviewed, rolling out r144136, r144143, and r144147.
3104         http://trac.webkit.org/changeset/144136
3105         http://trac.webkit.org/changeset/144143
3106         http://trac.webkit.org/changeset/144147
3107         https://bugs.webkit.org/show_bug.cgi?id=110950
3108
3109         Caused some timeouts and flaky crashes (Requested by abarth on
3110         #webkit).
3111
3112         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3113         (main):
3114         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3115         (WebTestRunner::WebPreferences::reset):
3116         * DumpRenderTree/chromium/TestShell.cpp:
3117         (TestShell::TestShell):
3118
3119 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
3120
3121         Use perf.webkit.org JSON format in results page
3122         https://bugs.webkit.org/show_bug.cgi?id=110842
3123
3124         Reviewed by Benjamin Poulain.
3125
3126         Change the default JSON format from that of webkit-perf.appspot.com to that of perf.webkit.org.
3127
3128         A whole bunch of integration tests have been updated to use the new JSON format.
3129
3130         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3131         (PerfTestsRunner._generate_and_show_results): Renamed output and output_path to legacy_output
3132         and legacy_output_json_path respectively.
3133         (PerfTestsRunner._generate_results_dict): Don't assume meta build information is always available.
3134         (PerfTestsRunner._generate_output_files): Make json_output, which is used to generate the default
3135         JSON file and the results page out of perf_webkit_output instead of legacy_output.
3136
3137         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3138         (MainTest.test_run_memory_test):
3139         (MainTest._test_run_with_json_output.mock_upload_json):
3140         (MainTest):
3141         (MainTest.test_run_with_json_output):
3142         (MainTest.test_run_with_description):
3143         (MainTest.test_run_generates_json_by_default):
3144         (MainTest.test_run_merges_output_by_default):
3145         (MainTest.test_run_respects_reset_results):
3146         (MainTest.test_run_generates_and_show_results_page):
3147         (MainTest.test_run_with_slave_config_json):
3148         (MainTest.test_run_with_multiple_repositories):
3149         (MainTest.test_run_with_upload_json):
3150         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
3151
3152 2013-02-26  Adam Barth  <abarth@webkit.org>
3153
3154         [Chromium] Enable threaded HTML parser by default in DumpRenderTree
3155         https://bugs.webkit.org/show_bug.cgi?id=110907
3156
3157         Reviewed by Eric Seidel.
3158
3159         This patch changes --enable-threaded-html-parser into
3160         --disable-threaded-html-parser and thereby enables the threaded HTML
3161         parser by default for the Chromium port.
3162
3163         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3164         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3165         (WebTestRunner::WebPreferences::reset):
3166         * DumpRenderTree/chromium/TestShell.cpp:
3167         (TestShell::TestShell):
3168
3169 2013-02-26  Dirk Pranke  <dpranke@chromium.org>
3170
3171         [chromium] Re-enable the fixed version of freetype on linux
3172         https://bugs.webkit.org/show_bug.cgi?id=110542
3173
3174         Reviewed by Tony Chang.
3175
3176         Re-land the change in r143794 to switch to building with a fixed
3177         version of FreeType for just DumpRenderTree. This allows us to share
3178         one version of pixel baselines for both Lucid and Precise, and run the
3179         layout tests in a stock Precise install (instead of a Lucid chroot).
3180         Going forward, this approach isolates us from os-level changes to the
3181         version of FreeType. Note that Chromium itself still uses the system
3182         FreeType and is unaffected by this change.
3183         
3184         This setting can still be turned off (at compile/gyp-time) by
3185         manually setting use_custom_freetype=0.
3186
3187         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3188
3189 2013-02-26  Nico Weber  <thakis@chromium.org>
3190
3191         [chromium] content shell drt: Enable WebKit::setLayoutTestMode()
3192         https://bugs.webkit.org/show_bug.cgi?id=110890
3193
3194         Reviewed by Jochen Eisinger.
3195
3196         Several functions in webkit check that bit to change rendering
3197         in layout test mode. For example, platform/graphics/skia/FrontSkia.cpp
3198         disables font smoothing in this mode. TestShell and DRT both set
3199         this flag, so content shell drt should set it too.
3200
3201         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3202         (WebTestRunner::TestInterfaces::TestInterfaces):
3203
3204 2013-02-26  Vivek Galatage  <vivek.vg@samsung.com>
3205
3206         new-commit-bot: Fix the unit test newcommitbot-unittest.py due to r144040
3207         https://bugs.webkit.org/show_bug.cgi?id=110884
3208
3209         Reviewed by Csaba Osztrogonác.
3210
3211         Adding the missing spaces before ':' in the unit test.
3212
3213         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
3214
3215 2013-02-26  Vivek Galatage  <vivek.vg@samsung.com>
3216
3217         new-commit-bot: Some IRC clients doesn't linkify rollout messages
3218         https://bugs.webkit.org/show_bug.cgi?id=110861
3219
3220         Reviewed by Ryosuke Niwa.
3221
3222         Adding the space before ':' in order to fix the links shown for the rollout message.
3223
3224         * Scripts/webkitpy/tool/commands/newcommitbot.py:
3225         (NewCommitBot._summarize_commit_log):
3226
3227 2013-02-26  Joone Hur  <joone.hur@intel.com>
3228
3229         [GTK] Add Clutter to jhbuild
3230         https://bugs.webkit.org/show_bug.cgi?id=110245
3231
3232         Reviewed by Martin Robinson.
3233
3234         Add clutter, cogl, clutter-gtk, and atk to the optional moduleset.
3235         This allows to build WebKitGtk+ with clutter as an acceleration backend
3236         within the jhbuild environment. 
3237
3238         * gtk/jhbuild-optional.modules:
3239
3240 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
3241
3242         Another fix attempt after r143991 since having \r? after a greedy match doesn't help.
3243
3244         * Scripts/webkitpy/common/checkout/scm/svn.py:
3245         (SVN.value_from_svn_info):
3246
3247 2013-02-25  Alan Cutter  <alancutter@chromium.org>
3248
3249         GCE EWS bots failing intermittently on HTTP 502 error while updating their status
3250         https://bugs.webkit.org/show_bug.cgi?id=110845
3251
3252         Unreviewed EWS bot fix.
3253
3254         Switch the Queue Status Server address the EWS bots use to a more direct URL that
3255         doesn't seem to be having problems from GCE like queues.webkit.org.
3256
3257         * Scripts/webkitpy/common/net/statusserver.py:
3258         (StatusServer):
3259
3260 2013-02-25  Dirk Pranke  <dpranke@chromium.org>
3261
3262         Forgot to delete a no-longer-needed unit test after r143980.
3263
3264         Unreviewed, build fix.
3265
3266         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3267         (ChromiumWinTest.test_path_to_image_diff):
3268
3269 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
3270
3271         Build fix. run-perf-tests was reporting with revision numbers ending with \r.
3272         Don't include \r at the end of svn info lines on Windows.
3273
3274         This is similar to r143839.
3275
3276         * Scripts/webkitpy/common/checkout/scm/svn.py:
3277         (SVN.value_from_svn_info):
3278
3279 2013-02-25  James Simonsen  <simonjam@chromium.org>
3280
3281         [Resource Timing] Update test suite so it can be exported to the W3C
3282         https://bugs.webkit.org/show_bug.cgi?id=107343
3283
3284         Reviewed by Tony Gentilcore.
3285
3286         * Scripts/export-w3c-performance-wg-tests: Clean up output.
3287         * Scripts/import-w3c-performance-wg-tests:
3288
3289 2013-02-25  Anders Carlsson  <andersca@apple.com>
3290
3291         Add a new unavailablePluginButtonClicked callback that takes a WKDictionary of plug-in information
3292         https://bugs.webkit.org/show_bug.cgi?id=110821
3293         <rdar://problem/13265303>
3294
3295         Reviewed by Beth Dakin.
3296
3297         Update for WebKit2 changes.
3298
3299         * MiniBrowser/mac/WK2BrowserWindowController.m:
3300         (-[WK2BrowserWindowController awakeFromNib]):
3301         * WebKitTestRunner/TestController.cpp:
3302         (WTR::TestController::createOtherPage):
3303         (WTR::TestController::createWebViewWithOptions):
3304         (WTR::TestController::unavailablePluginButtonClicked):
3305         * WebKitTestRunner/TestController.h:
3306         (TestController):
3307
3308 2013-02-21  Jeffrey Pfau  <jpfau@apple.com>
3309
3310         Optionally partition cache to prevent using cache for tracking
3311         https://bugs.webkit.org/show_bug.cgi?id=110269
3312
3313         Reviewed by Maciej Stachowiak.
3314
3315         Add test suite for public suffix functions on Mac.
3316
3317         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3318         * TestWebKitAPI/Tests/mac/PublicSuffix.mm: Added.
3319         (TestWebKitAPI):
3320         (TestWebKitAPI::TEST_F):
3321
3322 2013-02-25  Dirk Pranke  <dpranke@chromium.org>
3323
3324         nrwt: reenable multiple http shards on chromium win
3325         https://bugs.webkit.org/show_bug.cgi?id=110814
3326
3327         Reviewed by Tony Chang.
3328
3329         The underlying bug in DumpRenderTree that was causing us to look for a
3330         pac file and timeout under load was fixed a while ago.
3331
3332         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3333         (ChromiumWinPort.relative_test_filename):
3334
3335 2013-02-25  Dirk Pranke  <dpranke@chromium.org>
3336
3337         Make ninja the default w/ build-webkit --chromium on windows.
3338         https://bugs.webkit.org/show_bug.cgi?id=110731
3339
3340         Unreviewed - TBR'ing thakis :).
3341
3342         * Scripts/update-webkit-chromium:
3343
3344 2013-02-25  Anders Carlsson  <andersca@apple.com>
3345
3346         Add a new pluginDidFail callback that takes a WKDictionary of plug-in information
3347         https://bugs.webkit.org/show_bug.cgi?id=110793
3348         <rdar://problem/13265303>
3349
3350         Reviewed by Sam Weinig.
3351
3352         Update for WebKit2 API changes.
3353
3354         * MiniBrowser/mac/WK2BrowserWindowController.m:
3355         (-[WK2BrowserWindowController awakeFromNib]):
3356         * WebKitTestRunner/TestController.cpp:
3357         (WTR::TestController::createWebViewWithOptions):
3358
3359 2013-02-25  Nico Weber  <thakis@chromium.org>
3360
3361         Fix python unit tests after yoli's email address update in http://trac.webkit.org/changeset/143922
3362         https://bugs.webkit.org/show_bug.cgi?id=110775
3363
3364         Unreviewed, basically a rebaseline.
3365
3366         * Scripts/webkitpy/common/config/watchlist:
3367
3368 2013-02-25  Nico Weber  <thakis@chromium.org>
3369
3370         [chromium] Try to get the webkit builder to use msvs again
3371         https://bugs.webkit.org/show_bug.cgi?id=110771
3372
3373         Reviewed by Eric Seidel.
3374
3375         The msvs gyp generator apparently doesn't write the sln file on every
3376         run, so check the vcxproj file instead.
3377
3378         * Scripts/webkitdirs.pm:
3379         (determineIsChromiumNinja):
3380
3381 2013-02-25  Nico Weber  <thakis@chromium.org>
3382
3383         [chromium] try to unbreak run-chromium-webkit-unit-tests on the mac bots
3384         https://bugs.webkit.org/show_bug.cgi?id=110767
3385
3386         Reviewed by Eric Seidel.
3387
3388         The tester runs gyp, which generates out/Release/build.ninja. The bot
3389         scripts use existence (and timestamp) of that file to decide if the
3390         current build is supposed to be ninja or xcodebuild. The file exists,
3391         so the snapshot is extracted to out/Release. The snapshot doesn't
3392         contain build.ninja however due to
3393         http://trac.webkit.org/changeset/140375 , so after extracting the
3394         snapshot the scripts think that this is an xcodebuild build. So remove
3395         the part of that revision that removed ninja files from the archive,
3396         and the bots should be happy again.
3397
3398         * BuildSlaveSupport/built-product-archive:
3399         (archiveBuiltProduct):
3400
3401 2013-02-25  Nico Weber  <thakis@chromium.org>
3402
3403         Fix tests after r143910
3404         https://bugs.webkit.org/show_bug.cgi?id=110757
3405
3406         Reviewed by Andreas Kling.
3407
3408         While here, also add a test for the bug r143910 fixed.
3409
3410         * Scripts/webkitpy/common/system/executive_unittest.py:
3411         (ScriptErrorTest.test_message_with_output):
3412         (ScriptErrorTest):
3413         (ScriptErrorTest.test_message_with_tuple):
3414
3415 2013-02-25  Nico Weber  <thakis@chromium.org>
3416
3417         [chromium] Apparently built-product-archive is written in Python, not Perl :-/
3418         https://bugs.webkit.org/show_bug.cgi?id=110755
3419
3420         Reviewed by Jochen Eisinger.
3421
3422         * BuildSlaveSupport/built-product-archive:
3423         (archiveBuiltProduct):
3424         (extractBuiltProduct):
3425
3426 2013-02-25  Sheriff Bot  <webkit.review.bot@gmail.com>
3427
3428         Unreviewed, rolling out r143895.
3429         http://trac.webkit.org/changeset/143895
3430         https://bugs.webkit.org/show_bug.cgi?id=110758
3431
3432         broke a bunch of tests (Requested by thakis__ on #webkit).
3433
3434         * Scripts/update-webkit-chromium:
3435
3436 2013-02-25  Andreas Kling  <akling@apple.com>
3437
3438         Unreviewed, fix simple mistake in r143903.
3439         <http://webkit.org/b/110746>
3440
3441         Reviewed by Andreas Kling.
3442
3443         Pass git revision, not svn revision, to git shell command.
3444
3445         * Scripts/webkitpy/common/checkout/scm/git.py:
3446         (Git.timestamp_of_latest_commit):
3447
3448 2013-02-25  Nico Weber  <thakis@chromium.org>
3449
3450         [chromium] Let built-product-archive log which directory it's archiving from and extracting to
3451         https://bugs.webkit.org/show_bug.cgi?id=110748
3452
3453         Reviewed by Jochen Eisinger.
3454
3455         One of the mac testers runs DRT from out/ but WebKitUnitTests from
3456         xcodebuild. I'm trying to understand what's going on.
3457
3458         * BuildSlaveSupport/built-product-archive:
3459         (archiveBuiltProduct):
3460         (extractBuiltProduct):
3461
3462 2013-02-23  Ilya Tikhonovsky  <loislo@chromium.org>
3463
3464         Web Inspector: Native Memory Instrumentation: replace String with const char* in MemoryObjectInfo
3465         https://bugs.webkit.org/show_bug.cgi?id=110599
3466
3467         Reviewed by Yury Semikhatsky.
3468
3469         Due to potentially dynamic nature of names and classNames we need to make a copy of the strings
3470         that were given us via MemoryInstrumentation calls.
3471         So I extended client api with registerString method that pushes the strings
3472         down to the serializer.
3473
3474         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
3475         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:
3476         (TestWebKitAPI::Helper::Helper):
3477         (Helper):
3478         (TestWebKitAPI::Helper::addNode):
3479         (TestWebKitAPI::TEST):
3480
3481 2013-02-25  Nico Weber  <thakis@chromium.org>
3482
3483         Make ScriptError not crash when args is a tuple
3484         https://bugs.webkit.org/show_bug.cgi?id=110747
3485
3486         Reviewed by Jochen Eisinger.
3487
3488         I'm trying to understand the error on
3489         http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/34563/steps/layout-test/logs/stdio
3490         better. I'll likely have to revert the ninja switch on windows, but
3491         having error reporting code that doesn't itself crash sounds like a
3492         good thing to have anyways.
3493
3494         The problem is that '%s' % (1, 2) errors out, and args is sometimes a
3495         tuple not a list.
3496
3497         * Scripts/run-chromium-webkit-unit-tests:
3498         * Scripts/webkitpy/common/system/executive.py:
3499         (ScriptError.__init__):
3500
3501 2013-02-25  Laszlo Gombos  <l.gombos@samsung.com>
3502
3503         [EFL] Align feature defaults
3504         https://bugs.webkit.org/show_bug.cgi?id=110715
3505
3506         Enable 3D_RENDERING in FeatureList.pm as it is enabled by default in
3507         OptionsEfl.cmake.
3508
3509         Reviewed by Gyuyoung Kim.
3510
3511         * Scripts/webkitperl/FeatureList.pm:
3512
3513 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
3514
3515         run-perf-tests reports wrong commit time
3516         https://bugs.webkit.org/show_bug.cgi?id=110746
3517
3518         Reviewed by Andreas Kling.
3519
3520         The bug was caused by running "svn info" on a subdirectory, which returns a timestamp
3521         of when the subdirectory was last modified.
3522
3523         Run "svn info -r <revision> <repository root>" instead. Specifying revision number is
3524         insufficient since running "svn log -r <revision>" on a partial checkout only returns
3525         an empty result if the revision didn't modify the subdirectory.
3526
3527         For git, there is no partial checkout, so we just need to pass in "-r" option to keep
3528         the interface compatible with svn.
3529
3530         * Scripts/webkitpy/common/checkout/scm/git.py:
3531         (Git.timestamp_of_latest_commit):
3532         * Scripts/webkitpy/common/checkout/scm/scm.py:
3533         (SCM.timestamp_of_latest_commit):
3534         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3535         (MockSCM.timestamp_of_latest_commit):
3536         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3537         (test_timestamp_of_latest_commit):
3538         * Scripts/webkitpy/common/checkout/scm/svn.py:
3539         (SVN.timestamp_of_latest_commit):
3540         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3541         (PerfTestsRunner._generate_results_dict):
3542
3543 2013-02-25  Jochen Eisinger  <jochen@chromium.org>
3544
3545         [chromium] move WebRuntimeFeatures configuration to TestRunner library
3546         https://bugs.webkit.org/show_bug.cgi?id=110712
3547
3548         Reviewed by Nico Weber.
3549
3550         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3551         (WebTestRunner::TestInterfaces::TestInterfaces):
3552         * DumpRenderTree/chromium/TestShell.cpp:
3553         (TestShell::TestShell):
3554
3555 2013-02-25  Nico Weber  <thakis@chromium.org>
3556
3557         Make ninja the default build system for build-webkit --chromium on windows
3558         https://bugs.webkit.org/show_bug.cgi?id=110731
3559
3560         Reviewed by Jochen Eisinger.
3561
3562         With http://crbug.com/169945 fixed, this should now work.
3563
3564         * Scripts/update-webkit-chromium:
3565
3566 2013-02-24  Gustavo Noronha Silva  <gns@gnome.org>
3567
3568         [GTK] GTK+ 2 build broken since GTK_API_VERSION_2 moved to autoconfig.h
3569         https://bugs.webkit.org/show_bug.cgi?id=110702
3570
3571         Reviewed by Martin Robinson.
3572
3573         * GtkLauncher/main.c: include autotoolsconfig.h.
3574         * Scripts/webkitpy/style/checker.py: make GtkLauncher/main.c exempt of
3575         the include ordering check, since it uses autotoolsconfig.h which needs to
3576         come first.
3577
3578 2013-02-24  Hajime Morrita  <morrita@google.com>
3579
3580         [Custom Elements] Implement bare-bone document.register()
3581         https://bugs.webkit.org/show_bug.cgi?id=100229
3582
3583         Reviewed by Adam Barth.
3584
3585         Added enableCustomDOMElements flag.
3586
3587         * DumpRenderTree/chromium/TestShell.cpp:
3588         (TestShell::TestShell):
3589
3590 2013-02-23  Mark Pilgrim  <pilgrim@chromium.org>
3591
3592         [Chromium] DumpRenderTree TestShell::initialize should take Platform* now that WebKitPlatformSupport is empty
3593         https://bugs.webkit.org/show_bug.cgi?id=110606
3594
3595         Reviewed by Adam Barth.
3596
3597         Part of a larger refactoring series; see tracking bug 82948.
3598
3599         * DumpRenderTree/DumpRenderTree.gypi:
3600         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3601         (WebKitSupportTestEnvironment::WebKitSupportTestEnvironment):
3602         (WebKitSupportTestEnvironment::mockPlatform):
3603         (WebKitSupportTestEnvironment):
3604         * DumpRenderTree/chromium/MockPlatform.cpp: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp.
3605         (MockPlatform::create):
3606         (MockPlatform::MockPlatform):
3607         (MockPlatform::~MockPlatform):
3608         (MockPlatform::setInterfaces):
3609         (MockPlatform::cryptographicallyRandomValues):
3610         (MockPlatform::createMediaStreamCenter):
3611         (MockPlatform::createRTCPeerConnectionHandler):
3612         * DumpRenderTree/chromium/MockPlatform.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h.
3613         (MockPlatform):
3614         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp: Removed.
3615         * DumpRenderTree/chromium/MockWebKitPlatformSupport.h: Removed.
3616         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3617         (WebTestDelegate):
3618         * DumpRenderTree/chromium/TestShell.cpp:
3619         (TestShell::initialize):
3620         * DumpRenderTree/chromium/TestShell.h:
3621         (TestShell):
3622
3623 2013-02-23  Ryosuke Niwa  <rniwa@webkit.org>
3624
3625         Chromium Windows Perf bot fix. Tolerate CR at the end of the line that contains the timestamp.
3626
3627         * Scripts/webkitpy/common/checkout/scm/svn.py:
3628         (SVN.timestamp_of_latest_commit):
3629
3630 2013-02-23  Jason Anderssen  <janderssen@gmail.com>
3631
3632         Move setAutofilled from TestRunner to WebCore
3633         https://bugs.webkit.org/show_bug.cgi?id=110521
3634
3635         Reviewed by Benjamin Poulain.
3636
3637         * DumpRenderTree/TestRunner.cpp:
3638         (TestRunner::staticFunctions):
3639         * DumpRenderTree/TestRunner.h:
3640         (TestRunner):
3641         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3642         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3643         (WebTestRunner::TestRunner::TestRunner):
3644         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3645         (TestRunner):
3646         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3647         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3648         * DumpRenderTree/mac/TestRunnerMac.mm:
3649         * DumpRenderTree/qt/TestRunnerQt.cpp:
3650         * DumpRenderTree/qt/TestRunnerQt.h:
3651         (TestRunnerQt):
3652         * DumpRenderTree/win/TestRunnerWin.cpp:
3653         * DumpRenderTree/wx/TestRunnerWx.cpp:
3654
3655 2013-02-22  Ryosuke Niwa  <rniwa@webkit.org>
3656
3657         Upload results to perf.webkit.org in addition to the one specified by --test-results-server
3658         https://bugs.webkit.org/show_bug.cgi?id=108577
3659
3660         Reviewed by Dirk Pranke.
3661