Tools/ChangeLog

   1 2015-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
   2
   3         [GTK] Test /webkit2/WebKitWebView/sync-request-on-max-conns might fail after finished
   4         https://bugs.webkit.org/show_bug.cgi?id=142385
   5
   6         Reviewed by Sergio Villar Senin.
   7
   8         Use stack allocated GMainLoopSources to make sure they are
   9         cancelled automatically if the test finishes before they have
  10         been processed.
  11
  12         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
  13         (testWebViewSyncRequestOnMaxConns):
  14
  15 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
  16
  17         Remove Mountain Lion libraries since ML isn't supported
  18         https://bugs.webkit.org/show_bug.cgi?id=142332
  19
  20         Reviewed by Darin Adler.
  21
  22         * Scripts/copy-webkitlibraries-to-product-directory:
  23
  24 2015-03-06  Carlos Alberto Lopez Perez <clopez@igalia.com> and Youenn Fablet  <youenn.fablet@crf.canon.fr>
  25
  26         Layout tests imported/w3c/web-platform-tests certificates should not be tracked on WebKit VCS
  27         https://bugs.webkit.org/show_bug.cgi?id=142083
  28
  29         Reviewed by Simon Fraser.
  30
  31         Modifying on the fly wpt config.json to set the directory where to generate/read certificates as a subfolder of the layout test results folder.
  32
  33         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
  34         (WebPlatformTestServer._copy_webkit_test_files):
  35
  36 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
  37
  38         setup-git-clone fails due to the failure to download python-irclib-0.4.8
  39         https://bugs.webkit.org/show_bug.cgi?id=141946
  40
  41         Reviewed by Ryosuke Niwa.
  42
  43         Check in ircbot.py and irclib.py to avoid network problems in the future.
  44
  45         * Scripts/webkitpy/common/net/irc/ircbot.py:
  46         * Scripts/webkitpy/thirdparty/__init__.py:
  47         (AutoinstallImportHook.find_module):
  48         (AutoinstallImportHook._install_irc): Deleted.
  49         * Scripts/webkitpy/thirdparty/__init___unittest.py:
  50         (ThirdpartyTest.test_imports):
  51         * Scripts/webkitpy/thirdparty/irc/__init__.py: Added.
  52         * Scripts/webkitpy/thirdparty/irc/ircbot.py: Added.
  53         * Scripts/webkitpy/thirdparty/irc/irclib.py: Added.
  54
  55 2015-03-06  David Kilzer  <ddkilzer@apple.com>
  56
  57         Dashboard: Perf bot status is missing for Apple {Mavericks,Yosemite} Release builds
  58
  59         See also fix to config.json in r181097.
  60
  61         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
  62         (WebKitBuildbot): Add missing "WK2" to the names of the perf
  63         bots.
  64
  65 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
  66
  67         run-jsc-stress-tests should determine the architecture from ELF binaries
  68         https://bugs.webkit.org/show_bug.cgi?id=142335
  69
  70         Reviewed by Darin Adler.
  71
  72         * Scripts/run-jsc-stress-tests:
  73
  74 2015-03-05  David Kilzer  <ddkilzer@apple.com>
  75
  76         [iOS] TestExpectations for ios-simulator-wk2 should fall back to 'wk2' after 'ios-simulator'
  77         <http://webkit.org/b/142226>
  78
  79         Reviewed by Darin Adler.
  80
  81         * Scripts/webkitpy/port/ios.py:
  82         (IOSSimulatorPort.default_baseline_search_path): Switch the
  83         TestExpectations order of ios-simulator-wk2 from this:
  84           ios-simulator-wk2, wk2, ios-simulator
  85         To this:
  86           ios-simulator-wk2, ios-simualtor, wk2
  87
  88 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
  89
  90         [Win] Provide tiered logging from MSBuild -- Errors on top, Warnings after
  91         https://bugs.webkit.org/show_bug.cgi?id=142370
  92
  93         Reviewed by Dean Jackson.
  94
  95         * Scripts/webkitdirs.pm:
  96         (buildVisualStudioProject): Tell MSBuild to output log files to two separate
  97         logs, one for warnings, the other for errors.
  98         * win/AssembleBuildLogs/AssembleLogs.cmd: Combine the error and warning logs
  99         into the standard BuildOutput.htm document.
 100
 101 2015-03-05  David Kilzer  <ddkilzer@apple.com>
 102
 103         Dashboard has trouble parsing iOS test output
 104         <http://webkit.org/b/142364>
 105
 106         Reviewed by Alex Christensen.
 107
 108         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
 109         (BuildbotTestResults.prototype._parseResults.resultSummarizer):
 110         Add fallback path to build a regex using 'matchString' so that
 111         it matches anywhere in the line.  In practice, 'matchString' is
 112         a prefix for the label following the number.
 113
 114 2015-03-05  Alex Christensen  <achristensen@webkit.org>
 115
 116         Fix linker warnings in TestWebKitAPI.
 117         https://bugs.webkit.org/show_bug.cgi?id=141912
 118
 119         Reviewed by David Kilzer.
 120
 121         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
 122         Do not export TearDownTestCase or SetUpTestCase symbols.
 123
 124 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
 125
 126         [Win] Unreviewed EWS fix.
 127
 128         * Scripts/webkitdirs.pm:
 129         (buildVisualStudioProject): Dial logging back to 'ErrorsOnly' to see if that makes
 130         the EWS output more usable.
 131
 132 2015-03-05  Chris Dumez  <cdumez@apple.com>
 133
 134         Regression(r173761): ASSERTION FAILED: !is8Bit() in StringImpl::characters16()
 135         https://bugs.webkit.org/show_bug.cgi?id=142350
 136
 137         Reviewed by Michael Saboff and Benjamin Poulain.
 138
 139         Add API test for WTFString::hasInfixStartingAt() to make sure it doesn't
 140         crash if the string is 8-bit but the pattern is 16-bit (and vice-versa).
 141
 142         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
 143         (TestWebKitAPI::TEST):
 144
 145 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
 146
 147         [Win] Ensure build target directory exists when launching MSBuild
 148         https://bugs.webkit.org/show_bug.cgi?id=142360
 149
 150         Reviewed by Dean Jackson.
 151
 152         Create the build output directory (if it doesn't exist) before
 153         launching MSBuild so that it can immediately begin writing logs.
 154
 155         * Scripts/webkitdirs.pm:
 156         (buildVisualStudioProject):
 157
 158 2015-03-05  Chris Dumez  <cdumez@apple.com>
 159
 160         run-webkit-tests and run-perf-tests should use WebKitTestRunner by default
 161         https://bugs.webkit.org/show_bug.cgi?id=142325
 162
 163         Reviewed by Csaba Osztrogonác.
 164
 165         run-webkit-tests and run-perf-tests now use WebKitTestRunner by default.
 166         As a result, "--webkit-test-runner / -2" parameters are replaced by
 167         "--dump-render-tree / -1" so developers can run DumpRenderTree rather
 168         than WebKitTestRunner.
 169
 170         * BuildSlaveSupport/build.webkit.org-config/config.json:
 171         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 172         (RunWebKit1Tests):
 173         (RunWebKit1Tests.start):
 174         (RunWebKit1LeakTests):
 175         (RunWebKit1LeakTests.start):
 176         (RunAndUploadPerfTestsWebKit1):
 177         (RunAndUploadPerfTestsWebKit1.start):
 178         (TestFactory):
 179         (TestWebKit1LeaksFactory):
 180         (TestWebKit1LeaksFactory.__init__):
 181         (TestWebKit1Factory):
 182         (TestWebKit1AllButJSCFactory):
 183         (TestAllButJSCFactory):
 184         (BuildAndPerfTestWebKit1Factory):
 185         (BuildAndPerfTestWebKit1Factory.__init__):
 186         (BuildAndPerfTestFactory):
 187         (BuildAndPerfTestFactory.__init__):
 188         (DownloadAndPerfTestWebKit1Factory):
 189         (DownloadAndPerfTestWebKit1Factory.__init__):
 190         (DownloadAndPerfTestFactory):
 191         (DownloadAndPerfTestFactory.__init__):
 192         (RunWebKitLeakTests): Deleted.
 193         (RunWebKitLeakTests.start): Deleted.
 194         (RunWebKit2Tests): Deleted.
 195         (RunWebKit2Tests.start): Deleted.
 196         (RunAndUploadPerfTestsWebKit2): Deleted.
 197         (RunAndUploadPerfTestsWebKit2.start): Deleted.
 198         (TestLeaksFactory): Deleted.
 199         (TestLeaksFactory.__init__): Deleted.
 200         (TestWebKit2Factory): Deleted.
 201         (TestWebKit2AndJSCFactory): Deleted.
 202         (BuildAndPerfTestWebKit2Factory): Deleted.
 203         (BuildAndPerfTestWebKit2Factory.__init__): Deleted.
 204         (DownloadAndPerfTestWebKit2Factory): Deleted.
 205         (DownloadAndPerfTestWebKit2Factory.__init__): Deleted.
 206         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 207         (parse_args):
 208         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
 209         (PerfTestsRunner._parse_args):
 210         * Scripts/webkitpy/port/port_testcase.py:
 211         (PortTestCase.test_build_driver):
 212
 213 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
 214
 215         [Win] Switch to MSBuild so we get more useful stdout logging in buildbot
 216         https://bugs.webkit.org/show_bug.cgi?id=140845
 217
 218         Reviewed by David Kilzer.
 219
 220         Update 'webkitdirs.pm' to locate the MSBuild used with Visual Studio 2013
 221         and generate suitable build commands to drive a full build from our
 222         existing solution files.
 223
 224         * Scripts/webkitdirs.pm:
 225         (msBuildInstallDir): Added.
 226         (determineConfigurationForVisualStudio): Revise to use MSBuild command
 227         line arguments to drive the build.
 228         (setupCygwinEnv): Warn user if MSBuild cannot be located.
 229         (buildVisualStudioProject): Revise to use MSBuild command line arguments
 230         to specify build architecture.
 231         * win/AssembleBuildLogs/AssembleLogs.cmd: MSBuild doesn't produce individual
 232         output logs, so don't attempt to consolidate them. Also: Drive-by fix: Don't
 233         bother looking for CoreUI or SafariTheme build logs.
 234
 235 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
 236
 237         [buildbot] mastercfg_unittest.py should be runnable easily
 238         https://bugs.webkit.org/show_bug.cgi?id=142219
 239
 240         Reviewed by Chris Dumez.
 241
 242         Buildbot 0.8.6p1 runs on build.webkit org with Twisted 12.1.0, which is
 243         the last Twisted version works together with this buildbot version.
 244
 245         * Scripts/webkitpy/common/system/autoinstall.py:
 246         (AutoInstaller): Added prepend_to_search_path argument to be able
 247         to prefer autoinstalled package to system package.
 248         (AutoInstaller.__init__):
 249         (AutoInstaller._set_up_target_dir):
 250         (AutoInstaller._extract_tar): Renamed from _extract_targz, now it works with tar.bz2 too.
 251         (AutoInstaller._prepare_package):
 252         (AutoInstaller._extract_targz): Renamed to _extract_tar.
 253         * Scripts/webkitpy/thirdparty/__init__.py:
 254         (AutoinstallImportHook._install_buildbot): Autoinstall Twisted 12.1.0.
 255
 256 2015-03-05  Lukasz Bialek  <l.bialek@samsung.com>
 257
 258         [EFL][WK2] Crash when "Download Linked File" from MiniBrowser context menu is clicked
 259         https://bugs.webkit.org/show_bug.cgi?id=131162
 260
 261         Reviewed by Gyuyoung Kim.
 262
 263         * MiniBrowser/efl/main.c:
 264         (on_download_request):
 265         (on_download_finished):
 266         (on_download_failed):
 267         (window_create):
 268         Adapt download callbacks to new callback mechanism
 269
 270 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
 271
 272         Unreviewed. Fix /webkit2/WebKitWebResource/mime-type after r180927.
 273
 274         In r180927 we updated the libsoup version used by the jhbuild. In
 275         this new version the sniffer uses image/x-icon instead of
 276         image/vnd.microsoft.icon for blank.ico resource.
 277
 278         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
 279         (testWebResourceMimeType):
 280
 281 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
 282
 283         [SOUP] Check TLS errors as soon as they are set in the SoupMessage
 284         https://bugs.webkit.org/show_bug.cgi?id=142244
 285
 286         Reviewed by Sergio Villar Senin.
 287
 288         Check that the SSL server doesn't process any request in case of
 289         TLS errors when the policy is set to FAIL.
 290
 291         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
 292         (testTLSErrorsPolicy):
 293         (testTLSErrorsRedirect):
 294         (testTLSErrorsHTTPAuth):
 295         (testLoadFailedWithTLSErrors):
 296         (testSubresourceLoadFailedWithTLSErrors):
 297         (httpsServerCallback):
 298
 299 2015-03-05  Pawel Forysiuk  <p.forysiuk@samsung.com>
 300
 301         [EFL] REGRESSION (r178685): ASSERTION FAILED: !parameters.mediaKeyStorageDirectory.isEmpty()
 302         https://bugs.webkit.org/show_bug.cgi?id=141154
 303
 304         Reviewed by Jer Noble.
 305
 306         Unlike GTK, EFL port enables ENABLE_ENCRYPTED_MEDIA_V2 build option by default.
 307
 308         For the sake of completeness WebKitTestRunner should specify temporary
 309         folder for MediaKeysStorageDirecory as well as IndexedDB, LocalStorage, etc.
 310
 311         Default non legacy paths are set up in ProcessPoolConfiguration constructor.
 312         They use WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
 313         to get data storage paths. Only Mac port has an actual implementation of it.
 314         However, WebKitTestRunner overrides them in favour of unique temporary dir
 315         which is taken from libraryPathForTesting().
 316
 317         Since WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
 318         is not implemented for EFL and GTK ports it returns an empty string.
 319         All default data folders besides MediaKeys are overridden in TestRunner
 320         code with unique temporary folders derived from DUMPRENDERTREE_TEMP
 321         env variable.
 322
 323         GTK port does not enable encrypted keys by default so
 324         WebMediaKeyStorageManager::initialize() code path is never triggered.
 325
 326         * WebKitTestRunner/TestController.cpp:
 327         (WTR::TestController::initialize): Set MediaKeysStorageDirectory for all
 328         WebKit ports.
 329
 330 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
 331
 332         [buildbot] Add regression test to check which builder runs which tests
 333         https://bugs.webkit.org/show_bug.cgi?id=142166
 334
 335         Reviewed by Alexey Proskuryakov.
 336
 337         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
 338         (BuildStepsConstructorTest.createTest):
 339         (BuildStepsTest):
 340         (BuildStepsTest.generateTests):
 341         (BuildStepsTest.createTest):
 342         (BuildStepsTest.createTest.doTest):
 343         (BuildStepsTest.test_unnecessary_expected_results):
 344
 345 2015-03-04  Commit Queue  <commit-queue@webkit.org>
 346
 347         Unreviewed, rolling out r181054.
 348         https://bugs.webkit.org/show_bug.cgi?id=142320
 349
 350         Broke the api tests (Requested by sundiamonde on #webkit).
 351
 352         Reverted changeset:
 353
 354         "Fix linker warnings in TestWebKitAPI."
 355         https://bugs.webkit.org/show_bug.cgi?id=141912
 356         http://trac.webkit.org/changeset/181054
 357
 358 2015-03-04  Alex Christensen  <achristensen@webkit.org>
 359
 360         Fix linker warnings in TestWebKitAPI.
 361         https://bugs.webkit.org/show_bug.cgi?id=141912
 362
 363         Reviewed by David Kilzer.
 364
 365         * TestWebKitAPI/Configurations/Base.xcconfig:
 366         Use GCC_SYMBOLS_PRIVATE_EXTERN like we do in WebCore.
 367
 368 2015-03-04  Alexey Proskuryakov  <ap@apple.com>
 369
 370         [Mac] Set SystemUIFontSelect in DRT and WKTR
 371         https://bugs.webkit.org/show_bug.cgi?id=142303
 372
 373         Reviewed by Myles C. Maxfield.
 374
 375         * DumpRenderTree/mac/DumpRenderTree.mm:
 376         (setDefaultsToConsistentValuesForTesting):
 377         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
 378         (WTR::InjectedBundle::platformInitialize):
 379
 380 2015-03-04  Chris Dumez  <cdumez@apple.com>
 381
 382         Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
 383         https://bugs.webkit.org/show_bug.cgi?id=142314
 384         <rdar://problem/20046835>
 385
 386         Reviewed by Ryosuke Niwa.
 387
 388         Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
 389         to get WK2 code coverage.
 390
 391         * BuildSlaveSupport/build.webkit.org-config/config.json:
 392
 393 2015-03-04  Alex Christensen  <achristensen@webkit.org>
 394
 395         Move content extensions test to properly named directory.
 396         https://bugs.webkit.org/show_bug.cgi?id=142299
 397
 398         Reviewed by Tim Horton.
 399
 400         * WebKitTestRunner/mac/TestControllerMac.mm:
 401         (WTR::TestController::platformConfigureViewForTest):
 402
 403 2015-03-04  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 404
 405         W3C test importer should use filesystem instead of os.walk
 406         https://bugs.webkit.org/show_bug.cgi?id=142085
 407
 408         Reviewed by Bem Jones-Bey.
 409
 410         Added FileSystem.dirs_under to remove the use of os.walk in test importer.
 411         Added MockFileSystem.dirs_under and MockFileSystem.getsize to enable unit testing of test importer.
 412         Added unit test for FileSystem.dirs_under and MockFileSystem.dirs_under.
 413
 414         Made use of FileSystem.dirs_under within TestImporter.find_importable_tests.
 415         Added a unit test to check that test importer is now black-box testable using a Mock system.
 416
 417         * Scripts/webkitpy/common/system/filesystem.py:
 418         (FileSystem.dirs_under): Returns a list of filtered sub-directories.
 419         (FileSystem.dirs_under.filter_all):
 420         * Scripts/webkitpy/common/system/filesystem_mock.py:
 421         (MockFileSystem.dirs_under):
 422         (MockFileSystem.dirs_under.filter_all):
 423         (MockFileSystem.getsize):
 424         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
 425         (MockFileSystemTest.test_dirs_under):
 426         (MockFileSystemTest.test_dirs_under.filter_dir):
 427         * Scripts/webkitpy/common/system/filesystem_unittest.py:
 428         (RealFileSystemTest.test_sep):
 429         (RealFileSystemTest):
 430         (RealFileSystemTest.test_dirs_under):
 431         (RealFileSystemTest.test_dirs_under.filter_this_dir):
 432         * Scripts/webkitpy/w3c/test_importer.py:
 433         (TestImporter.do_import):
 434         (TestImporter.find_importable_tests.should_keep_subdir):
 435         (TestImporter.find_importable_tests):
 436         (TestImporter.should_keep_subdir): Deleted.
 437         (TestImporter.should_skip_file): Deleted.
 438         * Scripts/webkitpy/w3c/test_importer_unittest.py:
 439         (TestImporterTest.test_import_dir_with_empty_init_py): Added test to ensure empty __init__.py are no longer empty once imported.
 440
 441 2015-03-04  Timothy Horton  <timothy_horton@apple.com>
 442
 443         [WebEditingTester] Add support for the find and replace bar
 444         https://bugs.webkit.org/show_bug.cgi?id=142247
 445
 446         Reviewed by Enrica Casucci.
 447
 448         While it's not hooked up yet in WKWebView, adding support for the
 449         find bar to WebEditingTester will help us implement that functionality.
 450
 451         * WebEditingTester/AppDelegate.h:
 452         * WebEditingTester/AppDelegate.m:
 453         (-[WebEditingAppDelegate performTextFinderAction:]):
 454         * WebEditingTester/MainMenu.xib:
 455         Receive performTextFinderAction: and forward it to the frontmost WebDocumentController.
 456
 457         * WebEditingTester/WK2WebDocumentController.m:
 458         (-[WK2WebDocumentController awakeFromNib]):
 459         (-[WK2WebDocumentController performTextFinderAction:]):
 460         (-[WK2WebDocumentController findBarView]):
 461         (-[WK2WebDocumentController setFindBarView:]):
 462         (-[WK2WebDocumentController isFindBarVisible]):
 463         (-[WK2WebDocumentController setFindBarVisible:]):
 464         (-[WK2WebDocumentController findBarViewDidChangeHeight]):
 465         (-[WK2WebDocumentController layout]):
 466         Implement performTextFinderAction: for WebKit2, and have a NSTextFinder
 467         pointing at the WKWebView (currently nothing will work, but the bar will
 468         show up). Install and uninstall the bar as needed.
 469
 470         * WebEditingTester/WebDocument.xib:
 471         Don't use a full-size content view. There's no need, and it makes find
 472         bar layout harder.
 473
 474         * WebEditingTester/WebDocumentController.h:
 475         * WebEditingTester/WebDocumentController.m:
 476         (-[WebDocumentController performTextFinderAction:]):
 477
 478 2015-03-03  Sam Weinig  <sam@webkit.org>
 479
 480         [Content Extensions] Split parsing and compiling of content extensions into their own files
 481         https://bugs.webkit.org/show_bug.cgi?id=142259
 482
 483         Reviewed by Anders Carlsson.
 484
 485         Add basic unit test for the content filter compiler.
 486
 487         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 488         * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Added.
 489         (WebCore::ContentExtensions::operator<<):
 490         (TestWebKitAPI::ContentFilterTest::SetUp):
 491         (TestWebKitAPI::TEST_F):
 492
 493 2015-03-04  Matthew Mirman  <mmirman@apple.com>
 494
 495         Cleaned up BuildAndTestFactory to not be a near duplicate of TestFactory
 496         https://bugs.webkit.org/show_bug.cgi?id=142230
 497
 498         Reviewed by Csaba Osztrogonác.
 499
 500         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 501         (TestFactory):
 502         (TestFactory.getProduct): Added
 503         (TestFactory.__init__): moved downloader to getProduct
 504         (BuildAndTestFactory):
 505         (BuildAndTestFactory.getProduct): Added
 506         (BuildAndTestFactory.__init__): made to call TestFactory.__init__ and append steps to the end.
 507         (BuildAndTestWebKit2Factory): Deleted.  Wasn't used anywhere.
 508
 509 2015-03-04  Debarshi Ray  <debarshir@gnome.org>
 510
 511         [GTK] WebView should hold a reference on WebContext because non-default contexts are a reality
 512         https://bugs.webkit.org/show_bug.cgi?id=142225
 513
 514         Reviewed by Carlos Garcia Campos.
 515
 516         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
 517         (testWebViewWebContextLifetime):
 518         (beforeAll):
 519
 520 2015-03-03  David Kilzer  <ddkilzer@apple.com>
 521
 522         [iOS] Crash logs can't be found on ios-simulator because WebKitTestRunner returns the wrong process name
 523         <http://webkit.org/b/142243>
 524
 525         Reviewed by Alexey Proskuryakov.
 526
 527         * WebKitTestRunner/TestController.cpp:
 528         (WTR::TestController::webProcessName):
 529         (WTR::TestController::networkProcessName):
 530         - Return the same process name on iOS and Mac because they both
 531           use the same process name for local engineering builds.
 532
 533 2015-03-03  David Kilzer  <ddkilzer@apple.com>
 534
 535         check-webkit-style: Add exception for FrameworkSoftLink.h header order
 536         <http://webkit.org/b/141872>
 537
 538         Reviewed by Alex Christensen.
 539
 540         * Scripts/webkitpy/style/checkers/cpp.py: Remove unneeded
 541         semi-colons in various places and fix whitespace.
 542         (_IncludeState): Add _SOFT_LINK_HEADER and _SOFT_LINK_SECTION
 543         constants.
 544         (_IncludeState.__init__): Add self._visited_soft_link_section
 545         boolean state variable.
 546         (_IncludeState.visited_soft_link_section): Getter for
 547         self._visited_soft_link_section.
 548         (_IncludeState.check_next_include_order): Update state machine
 549         for soft-link headers.  Add check that soft-link headers always
 550         appear last.
 551         (_classify_include): Add check for soft-link header type.
 552         (check_include_line): Return early if there is a soft-link
 553         header error.
 554
 555         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
 556         (OrderOfIncludesTest.test_public_primary_header): Add tests for
 557         including soft-link headers.
 558         (OrderOfIncludesTest.test_classify_include): Add test for
 559         _SOFT_LINK_HEADER type.
 560
 561 2015-03-03  Alexey Proskuryakov  <ap@apple.com>
 562
 563         build.webkit.org/dashboard: Don't repeatedly handle each test type
 564         https://bugs.webkit.org/show_bug.cgi?id=142211
 565
 566         Reviewed by Tim Horton and Matt Hanson.
 567
 568         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
 569         (Buildbot.prototype.javascriptTestResultsURLForIteration): Deleted.
 570         (Buildbot.prototype.apiTestResultsURLForIteration): Deleted.
 571         (Buildbot.prototype.platformAPITestResultsURLForIteration): Deleted.
 572         (Buildbot.prototype.webkitpyTestResultsURLForIteration): Deleted.
 573         (Buildbot.prototype.webkitperlTestResultsURLForIteration): Deleted.
 574         (Buildbot.prototype.bindingsTestResultsURLForIteration): Deleted.
 575         Removed functions that build a link to test step results. The buildbot provides
 576         these links in JSON.
 577
 578         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
 579         (BuildbotIteration): Put failing tests into an array, instead of named variables.
 580         (BuildbotIteration.ProductiveSteps): Removed step names that are not used on build.webkit.org.
 581         We can easily add them to the map as needed.
 582         (BuildbotIteration.TestSteps): Added a list of test steps to be displayed by test queues.
 583         (BuildbotIteration.prototype._parseData): Moved code for parsing step results away
 584         to BuildbotTestResults class. We used to parse here, build an intermediate data structure,
 585         and then build a BuildbotTestResults object, which was strange.
 586         (BuildbotIteration.prototype.loadLayoutTestResults): Ditto.
 587
 588         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
 589         Corrected an unrelated assertion that was buggy, and kept firing.
 590
 591         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
 592         (BuildbotTestResults):
 593         (BuildbotTestResults.prototype._parseResults.resultSummarizer):
 594         (BuildbotTestResults.prototype._parseResults):
 595         (BuildbotTestResults.prototype.addFullLayoutTestResults):
 596         Moved the code for parsing JSON results for a single step here.
 597
 598         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
 599         (BuildbotTesterQueueView.prototype._testStepFailureDescription):
 600         (BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount):
 601         (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
 602         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Deleted.
 603         (BuildbotTesterQueueView.prototype.update): Deleted.
 604         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): Deleted.
 605         Updated for the new data structures. One behavior change is that we now display individual
 606         counts when multiple test kinds fail, e.g. "1 javascript test failure, 83+ layout
 607         test failures, 3 platform api test failures".
 608
 609 2015-03-03  Matthew Mirman  <mmirman@apple.com>
 610
 611         JSC tests should not be repeated twice for each branch builder, and should if possible have their own queue.
 612         https://bugs.webkit.org/show_bug.cgi?id=142094
 613
 614         Reviewed by Csaba Osztrogonác.
 615
 616         * BuildSlaveSupport/build.webkit.org-config/config.json: Added bots 155 and 157
 617         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 618         (TestFactory):
 619         (TestFactory.__init__): Made running of JSC tests conditional.
 620         (TestAllButJSCFactory):
 621         (TestJSCFactory): Added.
 622         (TestJSCFactory.__init__):
 623         (TestWebKit2AndJSCFactory): Added factory to not run JSC tests on WebKit2.
 624
 625 2015-03-03  David Kilzer  <ddkilzer@apple.com>
 626
 627         `build-webkit --help` is wrong about how to build for the iOS simulator
 628         <http://webkit.org/b/142223>
 629
 630         Reviewed by Csaba Osztrogonác.
 631
 632         * Scripts/build-webkit: Fix help.
 633
 634 2015-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
 635
 636         Unreviewed. Bump libsoup version to 2.49.91.1 to fix 32 bit build.
 637
 638         * gtk/jhbuild.modules:
 639
 640 2015-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
 641
 642         [SOUP] Synchronous XMLHttpRequests can time out when we reach the max connections limit
 643         https://bugs.webkit.org/show_bug.cgi?id=141508
 644
 645         Reviewed by Sergio Villar Senin.
 646
 647         Add a unit test to check that synchronous XHRs load even if the
 648         maximum connection limits are reached.
 649
 650         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
 651         (testWebViewSyncRequestOnMaxConns):
 652         (serverCallback):
 653         (beforeAll):
 654         * gtk/jhbuild.modules: Bump libsoup version to 2.49.91.
 655
 656 2015-03-02  Alexey Proskuryakov  <ap@apple.com>
 657
 658         Update the name of ASan build step.
 659
 660         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
 661
 662 2015-03-02  Jer Noble  <jer.noble@apple.com>
 663
 664         [WK1][WK2][Mac] Fullscreen animation is incorrect when page is scaled.
 665         https://bugs.webkit.org/show_bug.cgi?id=142121
 666
 667         Reviewed by Simon Fraser.
 668
 669         Add a test which changes the WebView's page scale, then enters fullscreen mode, and verifies
 670         that the initial and final screen rects for the web content are as expected.
 671
 672         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 673         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.html: Added.
 674         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm: Added.
 675         (-[FullscreenStateDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
 676         (runJavaScriptAlert):
 677         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
 678         (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
 679         (TestWebKitAPI::FullscreenZoomInitialFrame::setPageScale):
 680         (TestWebKitAPI::FullscreenZoomInitialFrame::sendMouseDownEvent):
 681         (TestWebKitAPI::FullscreenZoomInitialFrame::runTest):
 682         (TestWebKitAPI::TEST_F):
 683
 684 2015-03-01  David Kilzer  <ddkilzer@apple.com>
 685
 686         LayoutTestRealy: Prepend __XPC_ to the key, not the value!
 687
 688         Follow-up fix for:
 689
 690         LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
 691         <http://webkit.org/b/142145>
 692
 693         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
 694         (-[LTRelayController _environmentVariables]): Fix think-o.
 695
 696 2015-03-01  David Kilzer  <ddkilzer@apple.com>
 697
 698         LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
 699         <http://webkit.org/b/142145>
 700
 701         Reviewed by Simon Fraser.
 702
 703         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
 704         (-[LTRelayController _environmentVariables]): Add.
 705         (-[LTRelayController launchApp]): Use -_environmentVariables.
 706
 707 2015-02-28  David Kilzer  <ddkilzer@apple.com>
 708
 709         [iOS] Stop running webkit-build-directory on every layout test
 710
 711         This was originally fixed by David Farler for Bug 135409 in
 712         r172602.
 713
 714         * Scripts/webkitpy/port/ios.py:
 715         (IOSSimulatorPort.relay_path): Mark as @memoized so it doesn't
 716         run webkit-build-directory every time it's called.
 717
 718 2015-02-28  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 719
 720         W3C importer should use filesystem instead of shutil/host
 721         https://bugs.webkit.org/show_bug.cgi?id=142012
 722
 723         Reviewed by Bem Jones-Bey.
 724
 725         Removed direct use of python shutil and os, except for os.walk which will require its own fix.
 726
 727         * Scripts/webkitpy/w3c/test_importer.py:
 728         (main):
 729         (TestImporter.do_import):
 730         (TestImporter.find_importable_tests):
 731         (TestImporter.import_tests):
 732         (TestImporter.remove_deleted_files):
 733         (TestImporter.write_import_log):
 734
 735 2015-02-28  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 736
 737         W3C test importer should use filesystem to read and write files
 738         https://bugs.webkit.org/show_bug.cgi?id=142084
 739
 740         Reviewed by Bem Jones-Bey.
 741
 742         Use of FileSystem.write_binary_file, read_text_file and write_text_file in lieu of open().
 743
 744         * Scripts/webkitpy/w3c/test_importer.py:
 745         (TestImporter.import_tests):
 746         (TestImporter.remove_deleted_files):
 747         (TestImporter.write_import_log):
 748
 749 2015-02-27  Sam Weinig  <sam@webkit.org>
 750
 751         Add WebKit2 SPI to create a DOM File object
 752         https://bugs.webkit.org/show_bug.cgi?id=142109
 753
 754         Reviewed by Tim Horton.
 755
 756         Add a test for WKBundleFileHandleRef.
 757
 758         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 759         * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle.cpp: Added.
 760         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
 761         (TestWebKitAPI::didFinishLoadForFrame):
 762         (TestWebKitAPI::TEST):
 763         * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle_Bundle.cpp: Added.
 764         (TestWebKitAPI::WKBundleFileHandleTest::WKBundleFileHandleTest):
 765         * TestWebKitAPI/Tests/WebKit2/bundle-file.html: Added.
 766
 767 2015-02-27  Michael Saboff  <msaboff@apple.com>
 768
 769         Add ability for run-jsc-benchmarks to set library path from test binary when run on a build bot
 770         https://bugs.webkit.org/show_bug.cgi?id=142112
 771
 772         Reviewed by Filip Pizlo.
 773
 774         Added check for VMs in the form of <someDir>/{DumpRenderTree,webkitTestRunner,jsc} and use
 775         <someDir> as the library path.
 776
 777         * Scripts/run-jsc-benchmarks:
 778
 779 2015-02-27  Alex Christensen  <achristensen@webkit.org>
 780
 781         [WinCairo] Unreviewed build fix.
 782
 783         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
 784         Use TestWebKitAPIPrefix.h like in TestWebKitAPICommon.props.
 785
 786 2015-02-27  Anders Carlsson  <andersca@apple.com>
 787
 788         Add infrastructure for handling website data in the network process
 789         https://bugs.webkit.org/show_bug.cgi?id=142092
 790
 791         Reviewed by Andreas Kling.
 792
 793         Add a menu item that will fetch all website data, delete the returned data records, and
 794         fetch all website data again so we can confirm that it's all empty.
 795
 796         * MiniBrowser/mac/WK2BrowserWindowController.m:
 797         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
 798
 799 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
 800
 801         [Win] Remove remaining SafariTheme cruft
 802         https://bugs.webkit.org/show_bug.cgi?id=142075
 803
 804         Reviewed by Anders Carlsson.
 805
 806         Remove reference to SafariTheme-switching preference.
 807
 808         * DumpRenderTree/win/DumpRenderTree.cpp:
 809         (resetWebPreferencesToConsistentValues):
 810         (prepareConsistentTestingEnvironment):
 811
 812 2015-02-26  Doug Russell  <d_russell@apple.com>
 813
 814         AX: Expose caret browsing preference to accessibility API
 815         https://bugs.webkit.org/show_bug.cgi?id=141862
 816
 817         Reviewed by Chris Fleizach.
 818
 819         Exposing the caret browsing setting on WebCore::Frame via the accessibility API would allow assistive tech apps to enable it contextually (for example, when the assistive tech app is running).
 820         Enabling caret browsing when assistive tech apps are running greatly improves the reliability of keyboard navigation on the web. Most especially in cases where selection would be disrupted by focus events.
 821
 822         * DumpRenderTree/AccessibilityUIElement.cpp:
 823         (setBoolAttributeValueCallback):
 824         (selectedTextMarkerRangeCallback):
 825         (resetSelectedTextMarkerRangeCallback):
 826         (AccessibilityUIElement::setBoolAttributeValue):
 827         (AccessibilityUIElement::selectedTextMarkerRange):
 828         (AccessibilityUIElement::resetSelectedTextMarkerRange):
 829         (AccessibilityUIElement::getJSClass):
 830         * DumpRenderTree/AccessibilityUIElement.h:
 831         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
 832         (AccessibilityUIElement::setBoolAttributeValue):
 833         (AccessibilityUIElement::selectedTextMarkerRange):
 834         (AccessibilityUIElement::resetSelectedTextMarkerRange):
 835         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
 836         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
 837         (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
 838         (WTR::AccessibilityUIElement::setBoolAttributeValue):
 839         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
 840         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
 841         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
 842         (WTR::AccessibilityUIElement::setBoolAttributeValue):
 843         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
 844         (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
 845
 846 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
 847
 848         [Win] Remove WebKitExportGenerator project (and related)
 849         https://bugs.webkit.org/show_bug.cgi?id=142035
 850
 851         Reviewed by Dean Jackson.
 852
 853         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't look for a
 854         build log from WebKitExportGenerator.
 855
 856 2015-02-26  Csaba Osztrogonác  <ossy@webkit.org>
 857
 858         [EFL] Bump EFL version to 1.13.0
 859         https://bugs.webkit.org/show_bug.cgi?id=141708
 860
 861         Reviewed by Gyuyoung Kim.
 862
 863         * efl/jhbuild.modules:
 864
 865 2015-02-26  Sam Weinig  <sam@webkit.org>
 866
 867         Check in missing WebEditingTester.xcconfig file.
 868
 869         * WebEditingTester/Configurations/WebEditingTester.xcconfig: Added.
 870
 871 2015-02-26  Csaba Osztrogonác  <ossy@webkit.org>
 872
 873         [webkitpy] Remove skipped file related crufts
 874         https://bugs.webkit.org/show_bug.cgi?id=142046
 875
 876         Reviewed by Ryosuke Niwa.
 877
 878         * Scripts/webkitpy/port/base.py:
 879         (Port.skipped_layout_tests):
 880         (Port._tests_from_skipped_file_contents): Deleted.
 881         (Port): Deleted.
 882         (Port._expectations_from_skipped_files): Deleted.
 883         * Scripts/webkitpy/port/mac_unittest.py:
 884         (MacTest.test_default_timeout_ms):
 885         (MacTest): Deleted.
 886         (test_tests_from_skipped_file_contents): Deleted.
 887
 888 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
 889
 890         [Win] Unreviewed WinCairo build fix after r180653.
 891
 892         TestWebKitAPI should know about proper WEBCORE_EXPORT definitions.
 893
 894         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
 895         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
 896         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
 897         * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Added.
 898         * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Added.
 899
 900 2015-02-25  Brent Fulgham  <bfulgham@apple.com>
 901
 902         [Win] Use WEBCORE_EXPORT instead of Definition file
 903         https://bugs.webkit.org/show_bug.cgi?id=141734
 904
 905         Reviewed by Alex Christensen.
 906
 907         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
 908         Use a precompiled header so we can define our export macros properly.
 909         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters:
 910         Visual studio automatic update stuff.
 911         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
 912         Set up Precompiled Header use for project..
 913         * DumpRenderTree/win/DumpRenderTreePrefix.cpp: Added.
 914         * DumpRenderTree/DumpRenderTreePrefix.h: Update with proper export
 915         declarations for building DumpRenderTree as a client of
 916         WebCore/WebKit.
 917
 918 2015-02-25  Mark Lam  <mark.lam@apple.com>
 919
 920         ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack.
 921         <https://webkit.org/b/141672>
 922
 923         Reviewed by Alexey Proskuryakov.
 924
 925         ASan does not like the fact that we memcpy the stack for GC scans.  So,
 926         we're working around this by using our own memcpy (asanUnsafeMemcpy)
 927         implementation that we can tell ASan to ignore.
 928
 929         Also removed the previous added directive to ignore *tryCopyOtherThreadStack*
 930         which isn't effective for working around this issue.
 931
 932         * asan/webkit-asan-ignore.txt:
 933
 934 2015-02-25  Benjamin Poulain  <bpoulain@apple.com>
 935
 936         CodeBlock crashes when dumping op_push_name_scope
 937         https://bugs.webkit.org/show_bug.cgi?id=141953
 938
 939         Reviewed by Filip Pizlo.
 940
 941         * Scripts/run-jsc-stress-tests:
 942
 943 2015-02-25  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 944
 945         W3C test importer should use argparse instead of optparse
 946         https://bugs.webkit.org/show_bug.cgi?id=142013
 947
 948         Reviewed by Bem Jones-Bey.
 949
 950         * Scripts/webkitpy/w3c/test_importer.py:
 951         (main): Updating according argparse.
 952         (parse_args): Moving from optparse to argparse.
 953
 954 2015-02-25  Brady Eidson  <beidson@apple.com>
 955
 956         Get rid of TestInvocation::pathOrURL
 957         https://bugs.webkit.org/show_bug.cgi?id=142021
 958
 959         Reviewed by Tim Horton.
 960
 961         The pathOrURL string is a relative path used as an argument to WebKitTestRunner,
 962         but most code that uses it expected an absolute path.
 963
 964         This gets rid of the member and replaces all uses with a more descriptive "urlContains" method.
 965
 966         * WebKitTestRunner/TestController.cpp:
 967         (WTR::TestController::updateWebViewSizeForTest):
 968         (WTR::TestController::updateWindowScaleForTest):
 969         (WTR::shouldUseFixedLayout):
 970         (WTR::TestController::updateLayoutTypeForTest):
 971
 972         * WebKitTestRunner/TestInvocation.cpp:
 973         (WTR::TestInvocation::TestInvocation):
 974         (WTR::TestInvocation::urlContains):
 975         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
 976         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
 977         (WTR::TestInvocation::invoke):
 978         (WTR::shouldLogFrameLoadDelegates): Deleted.
 979         (WTR::shouldLogHistoryClientCallbacks): Deleted.
 980         * WebKitTestRunner/TestInvocation.h:
 981         (WTR::TestInvocation::pathOrURL): Deleted.
 982
 983         * WebKitTestRunner/ios/TestControllerIOS.mm:
 984         (WTR::shouldMakeViewportFlexible):
 985         (WTR::TestController::platformConfigureViewForTest):
 986
 987         * WebKitTestRunner/mac/TestControllerMac.mm:
 988         (WTR::shouldUseThreadedScrolling):
 989         (WTR::TestController::platformConfigureViewForTest):
 990
 991 2015-02-25  Brady Eidson  <beidson@apple.com>
 992
 993         Layout test support for user content filters
 994         https://bugs.webkit.org/show_bug.cgi?id=142018
 995
 996         Reviewed by Tim Horton.
 997
 998         * WebKitTestRunner/TestController.cpp:
 999         (WTR::TestController::resetStateToConsistentValues): Clear all user content filters between tests.
1000
1001         * WebKitTestRunner/mac/TestControllerMac.mm:
1002         (WTR::TestController::platformConfigureViewForTest): For all tests with usercontentfilter/ in their path try to load a matching .json
1003           file before loading the test itself.
1004
1005 2015-02-24  Sam Weinig  <sam@webkit.org>
1006
1007         Convert WebEditingTester to use xcconfig files
1008         https://bugs.webkit.org/show_bug.cgi?id=141879
1009
1010         Reviewed by Darin Adler.
1011
1012         Add xcconfig files to WebEditingTester based on the ones used by MiniBrowser.
1013
1014         * WebEditingTester/Configurations: Added.
1015         * WebEditingTester/Configurations/Base.xcconfig: Added.
1016         * WebEditingTester/Configurations/DebugRelease.xcconfig: Added.
1017         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
1018
1019 2015-02-24  Andy Estes  <aestes@apple.com>
1020
1021         Teach MiniBrowser how to disable per-window web processes
1022         https://bugs.webkit.org/show_bug.cgi?id=141988
1023
1024         Reviewed by Darin Adler.
1025
1026         * MiniBrowser/mac/AppDelegate.m:
1027         (defaultConfiguration): Created a _WKProcessPoolConfiguration with maximumProcessCount == 1 if per-window web processes are disabled.
1028         * MiniBrowser/mac/SettingsController.h:
1029         * MiniBrowser/mac/SettingsController.m:
1030         (-[SettingsController _populateMenu]): Added a new Settings menu item.
1031         (-[SettingsController validateMenuItem:]): Validated the new Settings menu item.
1032         (-[SettingsController togglePerWindowWebProcessesDisabled:]): Displayed an alert informing the user that MiniBrowser must be restarted for the setting to take effect.
1033         (-[SettingsController perWindowWebProcessesDisabled]): Returned the value from user defaults.
1034
1035 2015-02-24  Alexey Proskuryakov  <ap@apple.com>
1036
1037         Bot watcher's dashboard sometimes hits an assertion: data.num_missing === this.layoutTestResults.testsWithMissingResults.length
1038         https://bugs.webkit.org/show_bug.cgi?id=141889
1039
1040         Reviewed by Darin Adler.
1041
1042         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1043
1044 2015-02-24  Yusuke Suzuki  <utatane.tea@gmail.com>
1045
1046         REGRESSION(r179429): Can't type comments in Facebook
1047         https://bugs.webkit.org/show_bug.cgi?id=141859
1048
1049         Reviewed by Brent Fulgham.
1050
1051         Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
1052
1053         * DumpRenderTree/mac/DumpRenderTree.mm:
1054         (resetWebPreferencesToConsistentValues):
1055         * DumpRenderTree/win/DumpRenderTree.cpp:
1056         (resetWebPreferencesToConsistentValues):
1057         * WebKitTestRunner/TestController.cpp:
1058         (WTR::TestController::resetPreferencesToConsistentValues):
1059
1060 2015-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1061
1062         Crash loading local file with WebPageProxy::loadAlternateHTMLString
1063         https://bugs.webkit.org/show_bug.cgi?id=141867
1064
1065         Reviewed by Anders Carlsson.
1066
1067         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
1068         (TestWebKitAPI::loadAlternateHTMLString): Split most of this test into a function so it can
1069         be shared with the new test.
1070         (TestWebKitAPI::TEST): Add a cross-platform test for this crash.
1071         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: Add a GTK+ test for this crash.
1072         (testLoadAlternateHTMLForLocalPage):
1073         (beforeAll):
1074
1075 2015-02-24  David Kilzer  <ddkilzer@apple.com>
1076
1077         [iOS] Implement WTR::activateFonts() to fix missing fonts in WebKit2 test runs
1078         <http://webkit.org/b/141900>
1079
1080         Reviewed by Myles C. Maxfield.
1081
1082         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1083         (OTHER_LDFLAGS_BASE): Link to CoreText.framework.
1084         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm: Rename from Tools/WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm.
1085         - Rename to share code with iOS.
1086         - Add USE(APPKIT) around AppKit-specific headers and code.
1087         - Fix a check-webkit-style warning.
1088         * WebKitTestRunner/InjectedBundle/ios/ActivateFontsIOS.mm: Remove.
1089         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1090         - Rename mac/ActivateFonts.mm to cocoa/ActivateFontsCocoa.mm.
1091         - Remove ios/ActivateFontsIOS.mm.
1092         - Fix InjectedBundle/cocoa group to represent the directory on
1093           disk.  Includes a change to InjectedBundlePageCocoa.mm.
1094
1095 2015-02-23  Commit Queue  <commit-queue@webkit.org>
1096
1097         Unreviewed, rolling out r180547 and r180550.
1098         https://bugs.webkit.org/show_bug.cgi?id=141957
1099
1100         Broke 10 Windows tests. (Requested by bfulgham_ on #webkit).
1101
1102         Reverted changesets:
1103
1104         "REGRESSION(r179429): Can't type comments in Facebook"
1105         https://bugs.webkit.org/show_bug.cgi?id=141859
1106         http://trac.webkit.org/changeset/180547
1107
1108         "Constructor returning null should construct an object instead
1109         of null"
1110         https://bugs.webkit.org/show_bug.cgi?id=141640
1111         http://trac.webkit.org/changeset/180550
1112
1113 2015-02-23  Yusuke Suzuki  <utatane.tea@gmail.com>
1114
1115         REGRESSION(r179429): Can't type comments in Facebook
1116         https://bugs.webkit.org/show_bug.cgi?id=141859
1117
1118         Reviewed by Geoffrey Garen.
1119
1120         Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
1121
1122         * DumpRenderTree/mac/DumpRenderTree.mm:
1123         (resetWebPreferencesToConsistentValues):
1124         * WebKitTestRunner/TestController.cpp:
1125         (WTR::TestController::resetPreferencesToConsistentValues):
1126
1127 2015-02-23  KwangHyuk Kim  <hyuki.kim@samsung.com>
1128
1129         [EFL] fix eo errors
1130         https://bugs.webkit.org/show_bug.cgi?id=141909
1131
1132         Reviewed by Gyuyoung Kim.
1133
1134         Fix eo errors that occur whenever minibrowser is launched.
1135         - elm_obj_entry_text_style_user_push can only be applied for elm_entry
1136         - elm_obj_win_resize_object_add's first parameter should be elm_win
1137
1138         * MiniBrowser/efl/main.c:
1139         (window_create):
1140
1141 2015-02-23  Ryosuke Niwa  <rniwa@webkit.org>
1142
1143         Unreviewed build fix after r180535. Removed the test case that wasn't compiling.
1144
1145         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1146         (TestWebKitAPI::TEST):
1147
1148 2015-02-23  Brent Fulgham  <bfulgham@apple.com>
1149
1150         WTF::WeakPtr should rename 'forgot' to 'clear' and support nullptr assignment
1151         https://bugs.webkit.org/show_bug.cgi?id=141935
1152
1153         Reviewed by Myles C. Maxfield.
1154
1155         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1156         (TestWebKitAPI::TEST): Updated for 'clear' method rename, and added a few
1157         tests for assigning from nullptr.
1158
1159 2015-02-23  Brent Fulgham  <bfulgham@apple.com>
1160
1161         WTF::WeakPtr should have a 'forget' method.
1162         https://bugs.webkit.org/show_bug.cgi?id=141923
1163
1164         Reviewed by Myles C. Maxfield.
1165
1166         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1167         (TestWebKitAPI::TEST): Added 'Forget' tests case.
1168
1169 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
1170
1171         build.webkit.org/dashboard CrashOnly queues should not show two green bubbles
1172         https://bugs.webkit.org/show_bug.cgi?id=141920
1173
1174         Reviewed by Tim Horton.
1175
1176         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1177         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1178         Do the same thing as we do for regular green bubbles.
1179
1180 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
1181
1182         Bot watcher's dashboard doesn't show a popover for commit history when all commits were to another branch
1183         https://bugs.webkit.org/show_bug.cgi?id=141925
1184
1185         Reviewed by Tim Horton.
1186
1187         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1188         (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
1189
1190 2015-02-23  Anders Carlsson  <andersca@apple.com>
1191
1192         Add API for fetching website data records to _WKWebsiteDataStore
1193         https://bugs.webkit.org/show_bug.cgi?id=141926
1194
1195         Reviewed by Beth Dakin.
1196
1197         * MiniBrowser/mac/MainMenu.xib:
1198         * MiniBrowser/mac/WK2BrowserWindowController.m:
1199         (-[WK2BrowserWindowController fetchWebsiteData:]):
1200         Add menu item to fetch and dump website data.
1201
1202 2015-02-23  David Kilzer  <ddkilzer@apple.com>
1203
1204         [iOS] run-webkit-tests --leaks is broken because IOSSimulatorPort has no is_snowleopard attribute
1205         <http://webkit.org/b/141884>
1206
1207         Reviewed by Alexey Proskuryakov.
1208
1209         * Scripts/webkitpy/port/leakdetector.py:
1210         (LeakDetector._callstacks_to_exclude_from_leaks): Remove
1211         snowleopard, lion and older leaks.  Add known leak for
1212         mavericks, but check Port.operating_system before calling
1213         Port.is_mavericks.
1214         * Scripts/webkitpy/port/mac.py:
1215         (MacPort.is_snowleopard): Delete.
1216         (MacPort.is_lion): Delete.
1217         (MacPort.is_mavericks): Add.
1218
1219 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
1220
1221         build.webkit.org/dashboard should filter out commits to other branches
1222         https://bugs.webkit.org/show_bug.cgi?id=140362
1223
1224         Reviewed by Tim Horton.
1225
1226         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1227         (BuildbotQueue):
1228         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1229         (BuildbotQueueView.prototype._presentPopoverForPendingCommits):
1230         (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
1231         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration):
1232         (BuildbotQueueView.prototype.revisionContentForIteration):
1233         (BuildbotQueueView.prototype._appendPendingRevisionCount): Deleted.
1234         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Deleted.
1235         (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Deleted.
1236         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1237         (Trac.prototype.get oldestRecordedRevisionNumber):
1238         (Trac.prototype.commitsOnBranch):
1239         (Trac.prototype._xmlTimelineURL):
1240         (Trac.prototype._convertCommitInfoElementToObject):
1241         (Trac.prototype._update):
1242         (Trac.prototype.startPeriodicUpdates):
1243         (Trac.prototype.loadMoreHistoricalData):
1244         (Trac.prototype.update): Deleted.
1245
1246 2015-02-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1247
1248         Tests don't work on some bots: Failed to stop wptwk
1249         https://bugs.webkit.org/show_bug.cgi?id=141235
1250
1251         Reviewed by Ryosuke Niwa.
1252
1253         Logging of server subprocesses in launcher script.
1254         Killing of server subprocesses when stopping/before starting.
1255         Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore.
1256
1257         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
1258         (main): Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore. Added logging in a file of server subprocesses to clean them in case of abnormal shutdown.
1259         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1260         (WebPlatformTestServer.__init__):
1261         (WebPlatformTestServer._stop_running_subservers): Kill server subprocesses based on file created by wpt launcher.
1262         (WebPlatformTestServer):
1263         (WebPlatformTestServer.stop): Overriden to ensure killing subprocesses in case of orphaned process.
1264         (WebPlatformTestServer._stop_running_server): Killing of wpt launcher process after regular shutdown.
1265         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
1266         (TestWebPlatformTestServer.test_server_closes_previously_spawned_instance): Reworked the test to call start/stop with an existing pid file.
1267         (TestWebPlatformTestServer.test_import_web_platform_test_modules): No change.
1268         (TestWebPlatformTestServer):
1269         (TestWebPlatformTestServer.test_corrupted_subserver_files): Checked that server subprocess cleaning does not throw in case of bad server pid file.
1270
1271 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
1272
1273         [WebEditingTester] Allow dropping HTML files on the app
1274         https://bugs.webkit.org/show_bug.cgi?id=141834
1275
1276         Reviewed by Simon Fraser.
1277
1278         * WebEditingTester/AppDelegate.m:
1279         (-[WebEditingAppDelegate openDocument:]):
1280         (-[WebEditingAppDelegate application:openFile:]):
1281         Implement application:openFile:, factoring file loading code out of openDocument.
1282
1283         * WebEditingTester/Info.plist:
1284         Register as an editor for HTML files.
1285
1286         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
1287         Enrica is not an organization.
1288
1289 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
1290
1291         [WebEditingTester] Expand "WK" to "WebKit" in a few places
1292         https://bugs.webkit.org/show_bug.cgi?id=141833
1293
1294         Reviewed by Anders Carlsson.
1295
1296         * WebEditingTester/AppDelegate.h:
1297         * WebEditingTester/AppDelegate.m:
1298         (-[WebEditingAppDelegate newEditor:]):
1299         (-[WebEditingAppDelegate toggleUseWebKit2ByDefault:]):
1300         (-[WebEditingAppDelegate validateMenuItem:]):
1301         (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
1302         (-[WebEditingAppDelegate applicationDidFinishLaunching:]): Deleted.
1303         (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
1304         (-[WebEditingAppDelegate showOperations:]): Deleted.
1305         * WebEditingTester/MainMenu.xib:
1306         The WK abbreviation is unnaturally grating in menu items for some reason.
1307
1308 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
1309
1310         [WebEditingTester] Add a custom protocol for loading canned content
1311         https://bugs.webkit.org/show_bug.cgi?id=141830
1312
1313         Reviewed by Enrica Casucci.
1314
1315         Add a canned:// protocol handler, which can be used to emulate behaviors
1316         in WebKit client apps (like Mail) that use custom protocol handlers,
1317         which can have important effects on editing (mostly, the URLs are only
1318         valid inside of the client application, but not when copied/dragged out).
1319
1320         For now, we only support two canned files:
1321
1322             canned://dice is a PNG of dice (stolen from LayoutTests/)
1323             canned://text is the string "canned text" served as text/html
1324
1325         In the future we could support things like very large (generated) files,
1326         progressive loading, etc. to further simulate conditions in other apps.
1327
1328         * WebEditingTester/AppDelegate.m:
1329         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
1330         Register the protocol with CFNetwork, and the scheme with WebKit2.
1331
1332         * WebEditingTester/Canned Content/dice.png: Added.
1333         * WebEditingTester/CannedContent.h: Added.
1334         * WebEditingTester/CannedContent.m: Added.
1335         (-[CannedContent initWithRequest:cachedResponse:client:]):
1336         (+[CannedContent canonicalRequestForRequest:]):
1337         (+[CannedContent canInitWithRequest:]):
1338         We only want to handle canned:// URLs.
1339
1340         (-[CannedContent startLoading]):
1341         For now, immediately load the two files we know about.
1342         Otherwise, immediately fail the load.
1343
1344         (-[CannedContent stopLoading]):
1345         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
1346
1347 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
1348
1349         [WebEditingTester] Implement an open panel
1350         https://bugs.webkit.org/show_bug.cgi?id=141829
1351
1352         Reviewed by Simon Fraser.
1353
1354         * WebEditingTester/AppDelegate.m:
1355         (-[WebEditingAppDelegate _useWebKit1ForOpeningDocument:]):
1356         (-[WebEditingAppDelegate _useWebKit2ForOpeningDocument:]):
1357         (-[WebEditingAppDelegate openDocument:]):
1358         Add an open panel (with radio buttons to pick which WebKit to open with).
1359         Loads the file as an HTML string.
1360
1361 2015-02-20  Simon Fraser  <simon.fraser@apple.com>
1362
1363         [WebEditingTester] @properties, dot syntax, and remember the window position
1364         https://bugs.webkit.org/show_bug.cgi?id=141843
1365
1366         Reviewed by Tim Horton.
1367
1368         Modernize a bit with more dot syntax, use @property for the web views,
1369         and give the main window an Autosave name so it remembers the widow position.
1370
1371         * WebEditingTester/WK1WebDocumentController.m:
1372         (-[WK1WebDocumentController awakeFromNib]):
1373         (-[WK1WebDocumentController loadHTMLString:]):
1374         * WebEditingTester/WK2WebDocumentController.m:
1375         (-[WK2WebDocumentController awakeFromNib]):
1376         * WebEditingTester/WebDocument.xib:
1377
1378 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
1379
1380         [WebEditingTester] Hook up key equivalents for new window action
1381         https://bugs.webkit.org/show_bug.cgi?id=141828
1382
1383         Reviewed by Enrica Casucci.
1384
1385         * WebEditingTester/AppDelegate.h:
1386         * WebEditingTester/AppDelegate.m:
1387         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
1388         (-[WebEditingAppDelegate newEditor:]):
1389         (-[WebEditingAppDelegate _defaultWebDocumentControllerClass]):
1390         (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
1391         (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
1392         (defaultConfiguration): Deleted.
1393         (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
1394         Move WKWebViewConfiguration setup into WK2WebDocumentController.
1395         Remove unused application termination code.
1396         Update new-window menu item key equivalents when launching and when
1397         changing the use-WebKit2-by-default setting.
1398         Make WebDocumentController subclasses all initialized the same way,
1399         and use that to factor out alloc/init.
1400         Rename loadContent to loadHTMLString for future use.
1401
1402         * WebEditingTester/MainMenu.xib:
1403         Add default key equivalents.
1404         Cmd-N will always make the default kind of window (controlled by the pref).
1405         Cmd-Opt-N will always make the other kind.
1406         The menu items are configured as alternates so they only show up if you
1407         press alt (just like in MiniBrowser).
1408
1409         * WebEditingTester/WK1WebDocumentController.m:
1410         (-[WK1WebDocumentController loadHTMLString:]):
1411         (-[WK1WebDocumentController loadContent]): Deleted.
1412         * WebEditingTester/WK2WebDocumentController.h:
1413         * WebEditingTester/WK2WebDocumentController.m:
1414         (defaultConfiguration):
1415         (-[WK2WebDocumentController awakeFromNib]):
1416         (-[WK2WebDocumentController loadHTMLString:]):
1417         (-[WK2WebDocumentController initWithConfiguration:]): Deleted.
1418         (-[WK2WebDocumentController dealloc]): Deleted.
1419         * WebEditingTester/WebDocumentController.h:
1420         * WebEditingTester/WebDocumentController.m:
1421         (-[WebDocumentController init]):
1422         (-[WebDocumentController initWithWindow:]):
1423         (+[WebDocumentController defaultEditingSource]):
1424         (-[WebDocumentController loadHTMLString:]):
1425         (-[WebDocumentController windowDidLoad]): Deleted.
1426         (-[WebDocumentController defaultEditingSource]): Deleted.
1427         (-[WebDocumentController applicationTerminating]): Deleted.
1428         (-[WebDocumentController loadContent]): Deleted.
1429
1430 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
1431
1432         [WebEditingTester] ARC-ify WebEditingTester
1433         https://bugs.webkit.org/show_bug.cgi?id=141827
1434
1435         Reviewed by Sam Weinig.
1436
1437         * WebEditingTester/AppDelegate.m:
1438         (-[WebEditingAppDelegate showOperations:]):
1439         * WebEditingTester/EditingOperations.m:
1440         (editingOperations):
1441         * WebEditingTester/WK1WebDocumentController.m:
1442         (-[WK1WebDocumentController dealloc]): Deleted.
1443         * WebEditingTester/WK2WebDocumentController.m:
1444         (-[WK2WebDocumentController dealloc]): Deleted.
1445         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
1446         Turn on ARC and remove a few retain/release/autorelease calls.
1447         We don't need to implement dealloc in either document controller
1448         because WebView and WKWebView's UIDelegate property does not hold a
1449         strong reference.
1450
1451 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
1452
1453         [WebEditingTester] Factor out list of editing operations
1454         https://bugs.webkit.org/show_bug.cgi?id=141826
1455
1456         Reviewed by Sam Weinig.
1457
1458         * WebEditingTester/AppDelegate.m:
1459         (-[WebEditingAppDelegate showOperations:]):
1460         * WebEditingTester/EditingOperations.h: Added.
1461         * WebEditingTester/EditingOperations.m: Added.
1462         (editingOperations):
1463         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
1464         Move EditingOperations array to its own file, and make it an NSArray
1465         instead of a C array. Adjust accordingly in showOperations:.
1466
1467 2015-02-20  Michael Saboff  <msaboff@apple.com>
1468
1469         DFG JIT needs to check for stack overflow at the start of Program and Eval execution
1470         https://bugs.webkit.org/show_bug.cgi?id=141676
1471
1472         Reviewed by Filip Pizlo.
1473
1474         Set the newly added --maximumEvalCacheableSourceLength option for eager test runs.  This is needed
1475         to allow the eval out of stack tests to tier up.  Without this option, we don't cache the likely
1476         large string expression that we want to eval.
1477
1478         * Scripts/run-jsc-stress-tests:
1479
1480 2015-02-19  Daniel Bates  <dabates@apple.com>
1481
1482         REGRESSION (r180239): run-webkit-test fails to boot simulator device that was booted by previous test run
1483         https://bugs.webkit.org/show_bug.cgi?id=141815
1484         <rdar://problem/19893933>
1485
1486         Reviewed by Simon Fraser.
1487
1488         Fixes an issue where run-webkit-tests would fail to boot the WebKit Tester simulator device if it
1489         was booted by iOS Simulator in a previous run of run-webkit-test.
1490
1491         * Scripts/webkitpy/port/ios.py:
1492         (IOSSimulatorPort.check_sys_deps): Added logic moved from IOSSimulatorPort.setup_test_run().
1493         (IOSSimulatorPort.setup_test_run): Moved logic to quit the iOS Simulator app and wait for the
1494         testing device to be in the shutdown state from here to IOSSimulatorPort.check_sys_deps().
1495
1496 2015-02-19  David Kilzer  <ddkilzer@apple.com>
1497
1498         check-webkit-style: do not warn about missing primary header for *SoftLink.cpp files
1499         <http://webkit.org/b/141799>
1500
1501         Reviewed by Alex Christensen.
1502
1503         * Scripts/webkitpy/style/checkers/cpp.py:
1504         (_IncludeState.check_next_include_order): Don't emit a warning
1505         if the primary header exists and the source file name ends with
1506         "SoftLink.cpp".  Add 'filename' argument to method.
1507         (check_include_line): Pass in 'filename'.
1508
1509         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1510         (OrderOfIncludesTest.test_check_next_include_order__no_config):
1511         (OrderOfIncludesTest.test_check_next_include_order__no_self):
1512         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config):
1513         (OrderOfIncludesTest.test_check_next_include_order__other_then_config):
1514         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely):
1515         - Add test filename arguments for calls to
1516           check_next_include_order().
1517         (OrderOfIncludesTest.test_primary_header): Add test for a file
1518         name ending in "SoftLink.cpp".
1519
1520 2015-02-18  Enrica Casucci  <enrica@apple.com>
1521
1522         Add new tool to test editable Webviews.
1523         https://bugs.webkit.org/show_bug.cgi?id=141772
1524
1525         Reviewed by Tim Horton.
1526
1527         Adding WebEditingTester, a Cocoa application to
1528         test WK1 and Wk2 views in editable mode.
1529
1530         * WebEditingTester: Added.
1531         * WebEditingTester/AppDelegate.h: Added.
1532         * WebEditingTester/AppDelegate.m: Added.
1533         (-[WebEditingAppDelegate init]):
1534         (defaultConfiguration):
1535         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
1536         (-[WebEditingAppDelegate applicationWillTerminate:]):
1537         (-[WebEditingAppDelegate newEditor:]):
1538         (-[WebEditingAppDelegate showOperations:]):
1539         (-[WebEditingAppDelegate useWebKit2ByDefault]):
1540         (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
1541         (-[WebEditingAppDelegate validateMenuItem:]):
1542         * WebEditingTester/Info.plist: Added.
1543         * WebEditingTester/MainMenu.xib: Added.
1544         * WebEditingTester/WK1WebDocumentController.h: Added.
1545         * WebEditingTester/WK1WebDocumentController.m: Added.
1546         (-[WK1WebDocumentController awakeFromNib]):
1547         (-[WK1WebDocumentController loadContent]):
1548         (-[WK1WebDocumentController dealloc]):
1549         (-[WK1WebDocumentController pasteAsMarkup:]):
1550         * WebEditingTester/WK2WebDocumentController.h: Added.
1551         * WebEditingTester/WK2WebDocumentController.m: Added.
1552         (-[WK2WebDocumentController initWithConfiguration:]):
1553         (-[WK2WebDocumentController pasteAsMarkup:]):
1554         (-[WK2WebDocumentController awakeFromNib]):
1555         (-[WK2WebDocumentController dealloc]):
1556         (-[WK2WebDocumentController loadContent]):
1557         * WebEditingTester/WebDocument.xib: Added.
1558         * WebEditingTester/WebDocumentController.h: Added.
1559         * WebEditingTester/WebDocumentController.m: Added.
1560         (-[WebDocumentController initWithWindow:]):
1561         (-[WebDocumentController windowDidLoad]):
1562         (-[WebDocumentController defaultEditingSource]):
1563         (-[WebDocumentController applicationTerminating]):
1564         (-[WebDocumentController loadContent]):
1565         * WebEditingTester/WebEditingTester.xcodeproj: Added.
1566         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj: Added.
1567         * WebEditingTester/main.m: Added.
1568         (main):
1569
1570 2015-02-18  Csaba Osztrogonác  <ossy@webkit.org>
1571
1572         Run JSC tests on ARM EFL bots
1573         https://bugs.webkit.org/show_bug.cgi?id=141165
1574
1575         Reviewed by Alexey Proskuryakov.
1576
1577         * BuildSlaveSupport/build.webkit.org-config/config.json:
1578         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1579         (RunJavaScriptCoreTests.countFailures):
1580         (RunRemoteJavaScriptCoreTests):
1581         (RunRemoteJavaScriptCoreTests.start):
1582         (BuildAndRemoteJSCTestsFactory):
1583         (BuildAndRemoteJSCTestsFactory.__init__):
1584
1585 2015-02-18  Alexey Proskuryakov  <ap@apple.com>
1586
1587         Streamline unexported function build fixes
1588         https://bugs.webkit.org/show_bug.cgi?id=141761
1589
1590         Reviewed by Alex Christensen.
1591
1592         * Scripts/check-for-weak-vtables-and-externals: (readXcode5SymbolsToIgnore): Deleted.
1593         We don't need to ignore symbols that are not exported due to the .unexp file.
1594
1595 2015-02-18  Timothy Horton  <timothy_horton@apple.com>
1596
1597         Remove more references to WebCore.exp.in
1598         https://bugs.webkit.org/show_bug.cgi?id=141747
1599
1600         Reviewed by Alexey Proskuryakov.
1601
1602         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1603         (ShouldBuildTest):
1604
1605 2015-02-17  Myles C. Maxfield  <mmaxfield@apple.com>
1606
1607         Windows test results should not fall back to mac-mountainlion after r180176
1608         https://bugs.webkit.org/show_bug.cgi?id=141719
1609
1610         Reviewed by Brent Fulgham.
1611
1612         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1613         (_should_file_trigger_build):
1614         * Scripts/webkitpy/port/win.py:
1615         (WinPort.default_baseline_search_path):
1616         * Scripts/webkitpy/port/win_unittest.py:
1617         (WinPortTest.test_baseline_search_path):
1618
1619 2015-02-17  Daniel Bates  <dabates@apple.com>
1620
1621         [iOS] run-webkit-tests should check that simctl can boot and shutdown simulator device before running tests
1622         https://bugs.webkit.org/show_bug.cgi?id=141718
1623
1624         Reviewed by Alex Christensen.
1625
1626         We should only run layout tests if simctl can successfully boot and shutdown the testing device.
1627
1628         * Scripts/webkitpy/port/ios.py:
1629         (IOSSimulatorPort.check_sys_deps): Modified to call Simulator.check_simulator_device_and_erase_if_needed().
1630         Log a error and return False if we are unable to boot the simulator device so that the caller can take
1631         appropriate action, say exit(3) before running any layout tests.
1632         * Scripts/webkitpy/xcode/simulator.py:
1633         (Simulator._boot_and_shutdown_simulator_device): Added. Boot and then shut down the simulator device
1634         with the specified UDID.
1635         (Simulator.check_simulator_device_and_erase_if_needed): Added. Checks that simulator device
1636         with the specified UDID can successfully boot and shut down. We make at most two attempts to
1637         boot and shut down the device, erasing the device between tries so as to restore the device
1638         to a known good state.
1639
1640 2015-02-17  Daniel Bates  <dabates@apple.com>
1641
1642         run_webkit_tests.py should not know about iOS Simulator details
1643         https://bugs.webkit.org/show_bug.cgi?id=141711
1644
1645         Reviewed by Alex Christensen.
1646
1647         Run_webkit_tests.py should only parse the iOS-specific command
1648         line options --runtime and --device-type. Let the port-specific
1649         logic in ios.py validate the parsed options and instantiate
1650         internal data structures.
1651
1652         Currently run_webkit_tests.py parses the iOS-specific command
1653         line options --runtime and --device-type, validates them, and
1654         instantiates internal data structures from the parsed strings.
1655         Instead the validation logic and instantiation of internal
1656         data structures should be handled by the iOS port object.
1657
1658         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1659         (_set_up_derived_options): Remove logic to validate --runtime and --device-type
1660         and instantiate internal data structures for them.
1661         * Scripts/webkitpy/port/driver.py:
1662         (IOSSimulatorDriver.cmd_line): Modified to reference IOSSimulatorPort.simulator_runtime
1663         and IOSSimulatorPort.simulator_device_type for the iOS Simulator runtime and device type,
1664         respectively.
1665         * Scripts/webkitpy/port/ios.py: Sort the list of imports.
1666         (IOSSimulatorPort.simulator_runtime): Added. Instantiates a Runtime
1667         object from --runtime, if specified. Otherwise, instantiates a Runtime
1668         object for the latest installed iphonesimulator SDK version.
1669         (IOSSimulatorPort.simulator_device_type): Added. Instantiates a DeviceType
1670         object from --device-type, if specified. Otherwise, instantiates
1671         a DeviceType object for a iPhone 5 or iPhone 5s when on a 32-bit and 64-bit
1672         machine, respectively.
1673         (IOSSimulatorPort.check_sys_deps): Added. Validate if the chosen iOS simulator
1674         runtime is available to use.
1675         (IOSSimulatorPort.testing_device): Modified to make use of properties simulator_device_type
1676         and simulator_runtime for the iOS Simulator device type and runtime, respectively.
1677         * Scripts/webkitpy/xcode/simulator.py:
1678         (Runtime.from_version_string): Added. Turns around and calls Runtime.from_identifier()
1679         with a runtime identifier for the specified iOS version.
1680
1681 2015-02-17  Dana Burkart  <dburkart@apple.com>
1682
1683         ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack
1684         https://bugs.webkit.org/show_bug.cgi?id=141672
1685
1686         Reviewed by David Kilzer.
1687
1688         * asan/webkit-asan-ignore.txt:
1689
1690 2015-02-17  Alex Christensen  <achristensen@webkit.org>
1691
1692         Remove WebCore.exp.in and clean up.
1693         https://bugs.webkit.org/show_bug.cgi?id=141491
1694
1695         Reviewed by Andreas Kling.
1696
1697         * Scripts/sort-export-file: Removed.
1698         * Scripts/webkitpy/style/checker.py:
1699         (_all_categories):
1700         (FileType):
1701         (CheckerDispatcher._file_type):
1702         (CheckerDispatcher._create_checker):
1703         Don't check if the export files are sorted.
1704         * Scripts/webkitpy/style/checkers/exportfile.py: Removed.
1705         * Scripts/webkitpy/style/checkers/exportfile_unittest.py: Removed.
1706
1707 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1708
1709         Unreviewed. Fix GTK+ make distcheck.
1710
1711         Do not exclude bmalloc directory from the tarball.
1712
1713         * gtk/manifest.txt.in:
1714
1715 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1716
1717         Unreviewed. Fix /webkit2/WebKitDOMNode/dom-cache after r180214.
1718
1719         I forgot to add the return of a bool function.
1720
1721         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
1722         (WebKitDOMNodeTest::testDOMCache):
1723
1724 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1725
1726         [GTK] GObject DOM bindings object are cached forever
1727         https://bugs.webkit.org/show_bug.cgi?id=141558
1728
1729         Reviewed by Sergio Villar Senin.
1730
1731         Add checks for all DOM objects to ensure they are not leaked. Also
1732         add a dedicated test for the DOM Object Cache.
1733
1734         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
1735         (WebKitDOMNodeFilterTest::testTreeWalker):
1736         (WebKitDOMNodeFilterTest::testNodeIterator):
1737         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
1738         (WebKitDOMNodeTest::testHierarchyNavigation):
1739         (WebKitDOMNodeTest::testInsertion):
1740         (WebKitDOMNodeTest::testTagNames):
1741         (WebKitDOMNodeTest::testDOMCache):
1742         (registerTests):
1743         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
1744         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
1745         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
1746         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
1747         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
1748         (testWebKitDOMObjectCache):
1749         (beforeAll):
1750         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1751         (documentLoadedCallback):
1752
1753 2015-02-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1754
1755         [GTK] WebKitFrame objects are never released
1756         https://bugs.webkit.org/show_bug.cgi?id=141641
1757
1758         Reviewed by Martin Robinson.
1759
1760         Add a way to check GObjects leaks for WebProcess tests and check
1761         WebKitFrame objects are not leaked.
1762
1763         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
1764         (WebKitFrameTest::testMainFrame):
1765         (WebKitFrameTest::testURI):
1766         (WebKitFrameTest::testJavaScriptContext):
1767         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
1768         (WebProcessTest::assertObjectIsDeletedWhenTestFinishes):
1769         (runTest):
1770         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
1771
1772 2015-02-16  Tim Horton  <timothy_horton@apple.com>
1773
1774         Fix the MiniBrowser build with newer clang
1775
1776         * MiniBrowser/mac/SettingsController.m:
1777         (-[SettingsController _toggleBooleanDefault:]):
1778         * MiniBrowser/mac/WK1BrowserWindowController.m:
1779         (-[WK1BrowserWindowController windowWillClose:]):
1780         * MiniBrowser/mac/WK2BrowserWindowController.m:
1781         (-[WK2BrowserWindowController windowWillClose:]):
1782         NSApp is id and clang gets confused about which -delegate we're talking about.
1783
1784 2015-02-16  Antti Koivisto  <antti@apple.com>
1785
1786         Develop/Disable Caches does not properly disable disk cache
1787         https://bugs.webkit.org/show_bug.cgi?id=141636
1788
1789         Reviewed by Anders Carlsson.
1790
1791         Make testRunner.setCacheModel() use the WKContext interface so the model gets passed to
1792         the network process too.
1793
1794         This makes setCacheModel asynchronous but there don't seem to be any tests that expect otherwise.
1795
1796         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1797         (WTR::InjectedBundle::beginTesting):
1798         (WTR::InjectedBundle::setCacheModel):
1799         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1800         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1801
1802             Forward to TestController.
1803
1804         (WTR::TestRunner::setCacheModel):
1805         * WebKitTestRunner/TestInvocation.cpp:
1806         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1807
1808 2015-02-16  Andrzej Badowski  <a.badowski@samsung.com>
1809
1810         Unreviewed. Add myself as a committer.
1811
1812         * Scripts/webkitpy/common/config/contributors.json:
1813
1814 2015-02-15  David Kilzer  <ddkilzer@apple.com>
1815
1816         REGRESSION (r180082): WebCore Debug builds fail on Mavericks due to weak export symbols
1817         <http://webkit.org/b/141607>
1818
1819         * Scripts/check-for-weak-vtables-and-externals: Ignore weak
1820         externals in Source/WebCore/Configurations/WebCore.unexp when
1821         building with Xcode 5.x.
1822         (readXcode5SymbolsToIgnore): Add.
1823
1824 2015-02-15  KwangHyuk Kim  <hyuki.kim@samsung.com>
1825
1826         [EFL] fix Evas GL engine error.
1827         https://bugs.webkit.org/show_bug.cgi?id=141621
1828
1829         Reviewed by Gyuyoung Kim.
1830
1831         As new elm engine api was added from efl 1.10, replace elm_config_preferred_engine_set with elm_config_accel_preference_set.
1832
1833         * MiniBrowser/efl/main.c:
1834         (elm_main):
1835
1836 2015-02-14  Csaba Osztrogonác  <ossy@webkit.org>
1837
1838         [buildbot] Enable run-api-tests on release Mac bots
1839         https://bugs.webkit.org/show_bug.cgi?id=141518
1840
1841         Reviewed by Darin Adler.
1842
1843         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1844         (RunUnitTests):
1845         (BuildFactory.__init__):
1846         (TestFactory.__init__):
1847         (BuildAndTestFactory.__init__):
1848         (RunUnitTests.start): Deleted.
1849         (unitTestsSupported): Deleted.
1850
1851 2015-02-13  Anders Carlsson  <andersca@apple.com>
1852
1853         Add a move constructor and move assignment operator to Deque
1854         https://bugs.webkit.org/show_bug.cgi?id=141571
1855
1856         Reviewed by Andreas Kling.
1857
1858         * TestWebKitAPI/Tests/WTF/Deque.cpp:
1859         (TestWebKitAPI::TEST):
1860
1861 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
1862
1863         run-jsc-stress-tests --remote should skip profiler tests
1864         https://bugs.webkit.org/show_bug.cgi?id=141470
1865
1866         Reviewed by Filip Pizlo.
1867
1868         * Scripts/run-jsc-stress-tests:
1869
1870 2015-02-13  Anders Carlsson  <andersca@apple.com>
1871
1872         Add an initializer list constructor to Deque
1873         https://bugs.webkit.org/show_bug.cgi?id=141565
1874
1875         Reviewed by Andreas Kling.
1876
1877         * TestWebKitAPI/Tests/WTF/Deque.cpp:
1878         (TestWebKitAPI::TEST):
1879
1880 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
1881
1882         [buildbot] Remove buildJSCTool cruft from master.cfg
1883         https://bugs.webkit.org/show_bug.cgi?id=141513
1884
1885         Reviewed by Alexey Proskuryakov.
1886
1887         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1888         (RunJavaScriptCoreTests):
1889         (RunJavaScriptCoreTests.start):
1890         (RunWebKitTests):
1891         (RunWebKitTests.start):
1892         (TestFactory.__init__):
1893         (TestLeaksFactory.__init__):
1894         (RunJavaScriptCoreTests.__init__): Deleted.
1895         (RunWebKitTests.__init__): Deleted.
1896
1897 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
1898
1899         Unreviewed, remove empty directories.
1900
1901         * DumpRenderTree/gtk: Removed.
1902         * DumpRenderTree/gtk/fonts: Removed.
1903         * DumpRenderTree/unix: Removed.
1904         * DumpRenderTree/unix/TestNetscapePlugin: Removed.
1905         * GtkLauncher: Removed.
1906         * TestWebKitAPI/Tests/WebKitGtk: Removed.
1907         * TestWebKitAPI/Tests/WebKitGtk/resources: Removed.
1908         * WebKitTestRunner/WebKitTestRunnerAppTests: Removed.
1909         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj: Removed.
1910
1911 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
1912
1913         Remove Windows cruft from Tools/Scripts/build-webkittestrunner
1914         https://bugs.webkit.org/show_bug.cgi?id=141519
1915
1916         Reviewed by Alexey Proskuryakov.
1917
1918         * Scripts/build-webkittestrunner:
1919
1920 2015-02-12  Alex Christensen  <achristensen@webkit.org>
1921
1922         Removed empty directory.
1923
1924         * WinCELauncher: Removed.
1925
1926 2015-02-12  Csaba Osztrogonác  <ossy@webkit.org>
1927
1928         run-jsc-stress-tests --remote should be able add the necessary libraries to the bundle on Linux
1929         https://bugs.webkit.org/show_bug.cgi?id=141202
1930
1931         Reviewed by Darin Adler.
1932
1933         * Scripts/run-jsc-stress-tests:
1934
1935 2015-02-12  Brent Fulgham  <bfulgham@apple.com>
1936
1937         [Win] Test bot infrastructure should not try to find/use old Safari DLLs
1938         https://bugs.webkit.org/show_bug.cgi?id=141517
1939
1940         Reviewed by Anders Carlsson.
1941
1942         We do not need to locate or use the DLL's that came with Safari, so stop
1943         failing when we cannot find them. Also remove some old Qt cruft from this
1944         script.
1945
1946         * BuildSlaveSupport/built-product-archive:
1947         (archiveBuiltProduct):
1948         (extractBuiltProduct):
1949
1950 2015-02-11  Brent Fulgham  <bfulgham@apple.com>
1951
1952         [Win] [64-bit] Work around MSVC2013 Runtime Bug
1953         https://bugs.webkit.org/show_bug.cgi?id=141498
1954         <rdar://problem/19803642>
1955
1956         Reviewed by Anders Carlsson.
1957
1958         Disable FMA3 instruction use in the MSVC math library to
1959         work around a VS2013 runtime crash. We can remove this
1960         workaround when we switch to VS2015.
1961
1962         * DumpRenderTree/cg/ImageDiffCG.cpp: Call _set_FMA3_enable(0) to
1963         disable FMA3 support.
1964         * DumpRenderTree/win/DumpRenderTree.cpp: Ditto.
1965         * DumpRenderTree/win/ImageDiffCairo.cpp: Ditto.
1966         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
1967         * Scripts/webkitperl/httpd.pm: Ditto.
1968         * TestWebKitAPI/win/main.cpp: Ditto.
1969         * WinLauncher/Common.cpp: Ditto.
1970         * win/DLLLauncher/DLLLauncherMain.cpp: Ditto.
1971
1972 2015-02-12  Csaba Osztrogonác  <ossy@webkit.org>
1973
1974         run-jsc-stress-tests should accept remote host config from JSON file
1975         https://bugs.webkit.org/show_bug.cgi?id=141509
1976
1977         Reviewed by Michael Saboff.
1978
1979         * Scripts/run-javascriptcore-tests:
1980         (runJSCStressTests):
1981         * Scripts/run-jsc-stress-tests:
1982
1983 2015-02-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1984
1985         [GTK] Add API to allow overriding the default color chooser implementation
1986         https://bugs.webkit.org/show_bug.cgi?id=98935
1987
1988         Reviewed by Gustavo Noronha Silva.
1989
1990         Add a color chooser implementation for MiniBrowser using
1991         GtkPopover when the GTK+ version is recent enough.
1992         And a test case to check the new color chooser API.
1993
1994         * MiniBrowser/gtk/BrowserWindow.c:
1995         (colorChooserRGBAChanged):
1996         (popoverColorClosed):
1997         (colorChooserRequestFinished):
1998         (runColorChooserCallback):
1999         (browserWindowConstructed):
2000         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
2001         (testWebViewColorChooserRequest):
2002         (beforeAll):
2003
2004 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
2005
2006         Make run-jsc-stress-tests --remote work with make-based runner
2007         https://bugs.webkit.org/show_bug.cgi?id=141079
2008
2009         Reviewed by Darin Adler.
2010
2011         * Scripts/run-javascriptcore-tests:
2012         (runJSCStressTests): Pass through the --shell-runner and --make-runner arguments.
2013         * Scripts/run-jsc-stress-tests: Made the make-based runner the default runner,
2014         except for remote testing on Darwin. Unified runShellTestRunner and runMakeTestRunner
2015         to avoid code duplication.
2016
2017 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
2018
2019         run-jsc-stress tests should detect the number of processors on the remote machine too
2020         https://bugs.webkit.org/show_bug.cgi?id=141196
2021
2022         Reviewed by Darin Adler.
2023
2024         * Scripts/run-javascriptcore-tests:
2025         (runJSCStressTests): Pass through the --child-processes argument.
2026         * Scripts/run-jsc-stress-tests: Added determineNumberOfProcessors function
2027         to detect the number of local and remote processors with the same algorithm.
2028         Additionally introduced $numChildProcesses to emphasize it isn't necessarily
2029         same as $numProcessors.
2030
2031 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
2032
2033         run-jsc-stress-tests should pass JSC_timeout to remote hosts
2034         https://bugs.webkit.org/show_bug.cgi?id=141164
2035
2036         Reviewed by Darin Adler.
2037
2038         Additonally removed IMPORTANT_ENVS, since JSC_timeout was the only one.
2039
2040         * Scripts/run-jsc-stress-tests:
2041
2042 2015-02-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2043
2044         [GTK] Add default color chooser implementation using GtkColorChooserDialog
2045         https://bugs.webkit.org/show_bug.cgi?id=141392
2046
2047         Reviewed by Gustavo Noronha Silva.
2048
2049         Enable INPUT_TYPE_COLOR by default for GTK+ port.
2050
2051         * Scripts/webkitperl/FeatureList.pm:
2052
2053 2015-02-09  Csaba Osztrogonác  <ossy@webkit.org>
2054
2055         run-jsc-stress-tests shell test runner should run tests in fixed order
2056         https://bugs.webkit.org/show_bug.cgi?id=141383
2057
2058         Reviewed by Darin Adler.
2059
2060         * Scripts/jsc-stress-test-helpers/shell-runner.sh:
2061
2062 2015-02-08  Chris Fleizach  <cfleizach@apple.com>
2063
2064         AX: VoiceOver appears unresponsive when JavaScript alerts are triggered via focus or blur events
2065         https://bugs.webkit.org/show_bug.cgi?id=140485
2066
2067         Reviewed by Anders Carlsson.
2068
2069         Implement takeFocus() as a way to set focus through accessibility wrappers.
2070
2071         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2072         (AccessibilityUIElement::takeFocus):
2073         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2074         (WTR::AccessibilityUIElement::takeFocus):
2075
2076 2015-02-08  Darin Adler  <darin@apple.com>
2077
2078         Remove the SVG instance tree
2079         https://bugs.webkit.org/show_bug.cgi?id=140602
2080
2081         Reviewed by Dean Jackson.
2082
2083         * Scripts/check-for-global-initializers: Removed special case for
2084         SVGElementInstance.o.
2085
2086 2015-02-07  David Kilzer  <ddkilzer@apple.com>
2087
2088         [iOS] run-webkit-tests fails due to simulator devices from previous SDK installs being marked as unavailable
2089         <http://webkit.org/b/141365>
2090
2091         Reviewed by Daniel Bates.
2092
2093         * Scripts/webkitpy/xcode/simulator.py:
2094         (Simulator): Add unavailable_version_re precompiled regex.
2095         (Simulator._parse_devices): Check for unavailable versions and
2096         ignore them if found when parsing the output of
2097         `xcrun simctl list`.
2098         * Scripts/webkitpy/xcode/simulator_unittest.py:
2099         (test_unavailable_devices): Add test with output from
2100         `xcrun simctl list` with unavailable runtimes that fails before
2101         the fix.
2102
2103 2015-02-07  Chris Dumez  <cdumez@apple.com>
2104
2105         Add Vector::removeFirstMatching() / removeAllMatching() methods taking lambda functions
2106         https://bugs.webkit.org/show_bug.cgi?id=141321
2107
2108         Reviewed by Darin Adler.
2109
2110         Use new Vector::removeFirstMatching() / removeAllMatching() methods.
2111
2112 2015-02-07  David Kilzer  <ddkilzer@apple.com>
2113
2114         [iOS] Make Simulator class testable
2115         <http://webkit.org/b/141358>
2116
2117         Rubber-stamped by Darin Adler.
2118
2119         * Scripts/webkitpy/common/system/platforminfo.py:
2120         (PlatformInfo.xcode_simctl_list): Move `xcrun simctl list`
2121         command to here from Simulator.refresh() in xcode/simulator.py
2122         so that the output of the command can be mocked.
2123
2124         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2125         (MockPlatformInfo.__init__): Set self.expected_xcode_simctl_list
2126         to None.
2127         (MockPlatformInfo.xcode_simctl_list): Add method that returns
2128         self.expected_xcode_simctl_list expectation.
2129
2130         * Scripts/webkitpy/xcode/simulator.py: Add missing copyright
2131         and license header.
2132         (Simulator.__init__): Add optional 'host' parameter to make it
2133         possible to pass in a mock object for testing.  Set self._host
2134         to 'host' parameter or create Host() object.
2135         (Simulator.refresh): Call new PlatformInfo.xcode_simctl_list()
2136         method.
2137
2138         * Scripts/webkitpy/xcode/simulator_unittest.py: Add unit test
2139         for current code.
2140         (SimulatorTest):
2141         (SimulatorTest.setUp):
2142         (SimulatorTest._set_expected_xcrun_simctl_list):
2143         (SimulatorTest.test_simulator_device_types):
2144         (test_invalid_device_types_header):
2145         (test_invalid_runtimes_header):
2146         (test_invalid_devices_header):
2147
2148 2015-02-07  Csaba Osztrogonác  <ossy@webkit.org>
2149
2150         run-jsc-stress-tests --remote should use the default ssh port
2151         https://bugs.webkit.org/show_bug.cgi?id=141287
2152
2153         Reviewed by Darin Adler.
2154
2155         * Scripts/run-jsc-stress-tests: Extended URI module to be able to handle ssh scheme with the default 22 port number.
2156
2157 2015-02-06  Dana Burkart  <dburkart@apple.com>
2158
2159         dashboard: BuildbotTesterQueueView crashesOnly logic is wrong
2160         https://bugs.webkit.org/show_bug.cgi?id=141349
2161
2162         Reviewed by Alexey Proskuryakov.
2163
2164         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2165         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2166         (BuildbotTesterQueueView.prototype.update):
2167
2168 2015-02-06  Alexey Proskuryakov  <ap@apple.com>
2169
2170         Report network process crashes during layout tests
2171         https://bugs.webkit.org/show_bug.cgi?id=139646
2172
2173         Reviewed by Anders Carlsson.
2174
2175         * WebKitTestRunner/TestController.cpp:
2176         (WTR::TestController::initialize):
2177         (WTR::TestController::networkProcessName):
2178         (WTR::TestController::networkProcessDidCrash):
2179         * WebKitTestRunner/TestController.h:
2180
2181 2015-02-06  Csaba Osztrogonác  <ossy@webkit.org>
2182
2183         run-jsc-stress-tests --remote should create remote directory before copying the bundle
2184         https://bugs.webkit.org/show_bug.cgi?id=141329
2185
2186         Reviewed by Michael Saboff.
2187
2188         * Scripts/run-jsc-stress-tests:
2189
2190 2015-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2191
2192         [GTK] Remove WebKitWebView::close-notification signal
2193         https://bugs.webkit.org/show_bug.cgi?id=141330
2194
2195         Reviewed by Gustavo Noronha Silva.
2196
2197         Update notifications unit tests according to the API changes, and
2198         add a test case to check that onclose event is fired when a
2199         notification is closed by the user.
2200
2201         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2202         (testWebViewNotification):
2203
2204 2015-02-05  Alexey Proskuryakov  <ap@apple.com>
2205
2206         Dashboard doesn't consider building ASan a productive step
2207         https://bugs.webkit.org/show_bug.cgi?id=141312
2208
2209         Reviewed by Simon Fraser.
2210
2211         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2212
2213 2015-02-05  Daniel Bates  <dabates@apple.com>
2214
2215         [iOS] webkitpy.xcode.simulator.Runtime.from_identifier() returns wrong result for non-existent runtime
2216         https://bugs.webkit.org/show_bug.cgi?id=141306
2217
2218         Reviewed by Alexey Proskuryakov.
2219
2220         The function webkitpy.xcode.simulator.Runtime.from_identifier always returns a Runtime object
2221         corresponding to the last-most runtime parsed from the output of `simctl list` for any non-
2222         existent runtime.
2223
2224         * Scripts/webkitpy/xcode/simulator.py:
2225         (Runtime.from_identifier):
2226
2227 2015-02-05  Daniel Bates  <dabates@apple.com>
2228
2229         LayoutTestRelay does not install DumpRenderTree.app/WebKitTestRunnerApp.app
2230         https://bugs.webkit.org/show_bug.cgi?id=139746
2231         <rdar://problem/19283658>
2232
2233         Reviewed by Alexey Proskuryakov.
2234
2235         Fixes an issues where LayoutTestRelay may fail to install DumpRenderTree.app/WebKitTestRunnerApp.app
2236         if the simulator device is not in state Booted.
2237
2238         Currently run-webkit-test --ios-sim executes LayoutTestRelay immediately after
2239         launching/relaunching the iOS Simulator app and a simulator app can only be installed
2240         on a device that is in the Booted state. LayoutTestRelay may run before the
2241         device is booted and hence fail to install DumpRenderTree.app/WebKitTestRunnerApp.app.
2242         We should defer executing LayoutTestRelay until the simulator device booted by
2243         iOS Simulator is in the Booted state.
2244
2245         * Scripts/webkitpy/port/ios.py: Import webkitpy.xcode.simulator.Simulator to avoid prefixing
2246         Simulator methods with the module name, simulator.
2247         (IOSSimulatorPort.setup_test_run): Wait for the simulator device to be in the Booted state
2248         after launching iOS Simulator. Also, wait until the simulator device is in the Shutdown state
2249         before launching iOS Simulator to boot it.
2250         (IOSSimulatorPort.testing_device): Fix up caller since we now import webkitpy.xcode.simulator.Simulator.
2251         (IOSSimulatorPort.simulator_path): Deleted; moved this function to class Simulator and renamed to device_directory().
2252         * Scripts/webkitpy/xcode/simulator.py:
2253         (Device.__init__): Remove parameter state and an instance variable of the same name, which represented
2254         the state of the device when we created this object as part of parsing the output of `simctl list`. Callers
2255         interested in the state of the device are more likely interested in the current state of the device as
2256         opposed to the state of the device when the Device object was created.
2257         (Device.state): Added; turn around and call Simulator.device_state() for the current state of the device.
2258         (Device.path): Extracted implementation into Simulator.device_directory() so that it can be called
2259         from both this function and Simulator.device_state().
2260         (Device.create): Use Simulator.wait_until_device_is_in_state() to simplify the implementation of this function.
2261         (Simulator.DeviceState): Added; class of constants.
2262         (Simulator.wait_until_device_is_in_state): Added; this function does not return until the specified
2263         device is in the specified state.
2264         (Simulator.device_state): Added; parses the state of the device from the appropriate CoreSimulator device.plist file.
2265         (Simulator.device_directory): Added.
2266         (Simulator._parse_devices): Do not pass argument state to Device constructor as it no longer accepts it.
2267
2268 2015-02-05  Alexey Proskuryakov  <ap@apple.com>
2269
2270         Disable retries on Mac debug testers
2271         https://bugs.webkit.org/show_bug.cgi?id=141296
2272
2273         Reviewed by Simon Fraser.
2274
2275         * BuildSlaveSupport/build.webkit.org-config/config.json:
2276
2277 2015-02-05  Dan Bernstein  <mitz@apple.com>
2278
2279         Need a way to force $xcodeSDK in webkitdirs.pm
2280         https://bugs.webkit.org/show_bug.cgi?id=141291
2281
2282         Reviewed by Anders Carlsson.
2283
2284         * Scripts/webkitdirs.pm:
2285         (setXcodeSDK): Added.
2286
2287 2015-02-05  Youenn Fablet  <youenn.fablet@crf.canon.fr> and Xabier Rodriguez Calvar <calvaris@igalia.com>
2288
2289         [Streams API] Implement a barebone ReadableStream interface
2290         https://bugs.webkit.org/show_bug.cgi?id=141045
2291
2292         Reviewed by Benjamin Poulain.
2293
2294         * Scripts/webkitperl/FeatureList.pm: Added streams-api compilation switch.
2295
2296 2015-02-04  Joseph Pecoraro  <pecoraro@apple.com>
2297
2298         filter-build-webkit: reduce more unfiltered output
2299         https://bugs.webkit.org/show_bug.cgi?id=141282
2300
2301         Reviewed by Daniel Bates.
2302
2303         * Scripts/filter-build-webkit:
2304         Report CompileDTraceScript and Preprocess lines as successful.
2305
2306 2015-02-04  Dana Burkart  <dburkart@apple.com>
2307
2308         Botwatcher's Dashboard is cramped
2309         https://bugs.webkit.org/show_bug.cgi?id=140273
2310
2311         Reviewed by Alexey Proskuryakov.
2312
2313         Add a heading key which will allow for arbitrary headings in builder queues.
2314
2315         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2316         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
2317         (BuildbotBuilderQueueView.prototype.update):
2318         (BuildbotBuilderQueueView.prototype.update.appendBuildArchitecture): Deleted.
2319         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2320         (BuildbotIteration.prototype._parseData):
2321         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
2322         (BuildbotLeaksQueueView.prototype.update):
2323         (BuildbotLeaksQueueView.prototype.update.appendBuild): Deleted.
2324         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
2325         (BuildbotPerformanceQueueView.prototype.update):
2326         (BuildbotPerformanceQueueView.prototype.update.appendBuild): Deleted.
2327         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2328         (BuildbotQueue):
2329         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2330         (BuildbotQueueView.prototype._unauthorizedAccess):
2331         (BuildbotQueueView.prototype._appendBuild):
2332         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2333         (BuildbotTestResults):
2334         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2335         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2336         (BuildbotTesterQueueView.prototype.update):
2337         (BuildbotTesterQueueView.prototype.update.appendBuild): Deleted.
2338
2339 2015-02-04  Simon Fraser  <simon.fraser@apple.com>
2340
2341         WKTR should not use -mainScreen to pick a color profile
2342         https://bugs.webkit.org/show_bug.cgi?id=141265
2343
2344         Reviewed by Tim Horton.
2345
2346         -[NSScreen mainScreen] depends on the active window, so use the first screen
2347         (which is the one we put the window on anyway).
2348
2349         Do some cleanup in DRT that makes the code look similar.
2350
2351         * DumpRenderTree/mac/DumpRenderTree.mm:
2352         (createWebViewAndOffscreenWindow):
2353         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2354         (WTR::PlatformWebView::PlatformWebView):
2355
2356 2015-02-04  Simon Fraser  <simon.fraser@apple.com>
2357
2358         LayoutTestHelper should set the color profile of all displays
2359         https://bugs.webkit.org/show_bug.cgi?id=141260
2360
2361         Reviewed by Tim Horton.
2362
2363         WebKitTestRunner can (erroneously) grab the colorspace of the "main" screen.
2364         which is the screen with the active window. Make things more robust by changing
2365         the colorspace of all displays, not just the main screen, when running layout tests.
2366
2367         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig: Enable ARC
2368         * DumpRenderTree/mac/LayoutTestHelper.m:
2369         (originalColorProfileURLs):
2370         (colorProfileURLForDisplay):
2371         (displayUUIDStrings):
2372         (saveDisplayColorProfiles):
2373         (setDisplayColorProfile):
2374         (restoreDisplayColorProfiles):
2375         (installLayoutTestColorProfile):
2376         (restoreUserColorProfile):
2377         (main):
2378         Store display color profiles by map of UUID strings to URLs (NSUUID and CFUUID are not
2379         toll-free bridged, sadly). Use the map to restore all profiles on exit.
2380         Convert to use more Obj-C types.
2381
2382 2015-02-04  Daniel Bates  <dabates@apple.com>
2383
2384         test-webkitpy fails on Mac without iphoneos SDK
2385         https://bugs.webkit.org/show_bug.cgi?id=141255
2386         <rdar://problem/19619691>
2387
2388         I inadvertently committed the wrong exception message. Fix up the exception message
2389         to instruct a person to install the iOS SDK when it cannot be found.
2390
2391         * Scripts/webkitpy/port/ios.py:
2392         (IOSPort.determine_full_port_name):
2393
2394 2015-02-04  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2395
2396         W3C test importer should sort the list of files when generating the w3c-import.log
2397         https://bugs.webkit.org/show_bug.cgi?id=141156
2398
2399         Reviewed by Bem Jones-Bey.
2400
2401         Sort explicitly the list of imported files written in the w3c-import.log.
2402         Removed logging of the import date.
2403
2404         * Scripts/webkitpy/w3c/test_importer.py:
2405         (TestImporter.write_import_log):
2406
2407 2015-02-04  Daniel Bates  <dabates@apple.com>
2408
2409         test-webkitpy fails on Mac without iphoneos SDK
2410         https://bugs.webkit.org/show_bug.cgi?id=141255
2411         <rdar://problem/19619691>
2412
2413         Reviewed by David Kilzer and Alexey Proskuryakov.
2414
2415         Fixes an issue where test-webkitpy fails on a Mac without the iOS SDK. We should
2416         should not require the iphoneos SDK to be installed to run the webkitpy tests.
2417
2418         * Scripts/webkitpy/common/system/platforminfo.py:
2419         (PlatformInfo.xcode_sdk_version): Added; return the version of the specified SDK, if
2420         installed. We take advantage of the behavior that xcrun --show-sdk-version only writes
2421         to standard output if the SDK is installed to return the empty string if the SDK is
2422         not installed.
2423         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2424         (MockPlatformInfo.xcode_sdk_version): Added.
2425         * Scripts/webkitpy/port/ios.py:
2426         (IOSPort.determine_full_port_name): Modified to call PlatformInfo.xcode_sdk_version()
2427         to get the version of the iphoneos SDK, if installed.
2428
2429 2015-02-04  Alexey Proskuryakov  <ap@apple.com>
2430
2431         run-webkit-tests doesn't always capture ASan violation reports
2432         https://bugs.webkit.org/show_bug.cgi?id=141231
2433
2434         Reviewed by Darin Adler.
2435
2436         * Scripts/webkitpy/port/driver.py:
2437         (Driver.run_test): Don't look for CrashReporter crash logs if a log was provided
2438         by the driver already (as is the case with ASan violations, which are printed to
2439         stderr).
2440         (Driver._check_for_address_sanitizer_violation): Check if the line is a start of ASan
2441         report.
2442         (Driver._read_block): Give ASan enough time to symbolicate a crash, and put it into
2443         a separate variable for reporting.
2444
2445 2015-02-03  Ryosuke Niwa  <rniwa@webkit.org>
2446
2447         [webkitpy] Add platform specific Skipped file mechanism for performance tests
2448         https://bugs.webkit.org/show_bug.cgi?id=141152
2449
2450         Reviewed by Csaba Osztrogonác.
2451
2452         Support a test-expectation-like syntax in performance tests' skipped files.
2453         e.g. [Mac] Parsed/BadTest.html will skip Parsed/BadTest.html on Mac ports.
2454
2455         * Scripts/webkitpy/port/base.py:
2456         (Port.skipped_perf_tests): Implemented the syntax support by a regular expression.
2457
2458         * Scripts/webkitpy/port/base_unittest.py:
2459         (PortTest.test_skipped_perf_tests): Test the new syntax.
2460
2461 2015-02-04  Alexey Proskuryakov  <ap@apple.com>
2462
2463         When tests fail on leaks bot so much that there are no leaks detected, dashboard erroneously shows green
2464         https://bugs.webkit.org/show_bug.cgi?id=141236
2465
2466         Reviewed by Sam Weinig.
2467
2468         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
2469         (BuildbotLeaksQueueView.prototype.update.appendLeaksQueueStatus):
2470
2471 2015-02-04  Chris Dumez  <cdumez@apple.com>
2472
2473         Add removeFirst(value) / removeAll(value) methods to WTF::Vector
2474         https://bugs.webkit.org/show_bug.cgi?id=141192
2475
2476         Reviewed by Benjamin Poulain.
2477
2478         Add API tests for Vector::removeFirst(value) and
2479         Vector::removeAll(value).
2480
2481         * TestWebKitAPI/Tests/WTF/Vector.cpp:
2482         (TestWebKitAPI::TEST):
2483
2484 2015-02-03  Tim Horton  <timothy_horton@apple.com>
2485
2486         Add WKPageNavigationClient as C SPI around API::NavigationClient, and adopt in WKTR
2487         https://bugs.webkit.org/show_bug.cgi?id=141217
2488
2489         Reviewed by Sam Weinig.
2490
2491         * WebKitTestRunner/TestController.cpp:
2492         (WTR::copyWebCryptoMasterKey):
2493         (WTR::TestController::createOtherPage):
2494         (WTR::TestController::createWebViewWithOptions):
2495         (WTR::TestController::ensureViewSupportsOptions):
2496         (WTR::TestController::didCommitNavigation):
2497         (WTR::TestController::didFinishNavigation):
2498         (WTR::TestController::canAuthenticateAgainstProtectionSpace):
2499         (WTR::TestController::didReceiveAuthenticationChallenge):
2500         (WTR::TestController::decidePolicyForPluginLoad):
2501         (WTR::TestController::decidePolicyForNavigationAction):
2502         (WTR::TestController::decidePolicyForNavigationResponse):
2503         (WTR::TestController::didCommitLoadForFrame): Deleted.
2504         (WTR::TestController::didFinishLoadForFrame): Deleted.
2505         * WebKitTestRunner/TestController.h:
2506         Adopt WKPageNavigationClient and adjust to its semantics (navigations are main-frame-only, etc.)
2507
2508 2015-02-03  Dhi Aurrahman  <diorahman@rockybars.com>
2509
2510         Unreviewed. Add myself as a committer.
2511
2512         * Scripts/webkitpy/common/config/contributors.json:
2513
2514 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
2515
2516         [Win] Unreviewed test fix.
2517
2518         * DumpRenderTree/win/PolicyDelegate.cpp:
2519         (PolicyDelegate::unableToImplementPolicyWithError): The message was missing a linefeed,
2520         so was not matching expected output.
2521
2522 2015-02-03  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2523
2524         Unreviewed. Moving myself to the committer section at last.
2525
2526         * Scripts/webkitpy/common/config/contributors.json:
2527
2528 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
2529
2530         [Win] Tests fail because DRT reports '(null)' instead of an empty string
2531         https://bugs.webkit.org/show_bug.cgi?id=141205
2532
2533         Reviewed by Anders Carlsson.
2534
2535         * DumpRenderTree/win/HistoryDelegate.cpp:
2536         (HistoryDelegate::didNavigateWithNavigationData): Deal with empty BSTR values
2537         properly so that we match expected DumpRenderTree output.
2538
2539 2015-02-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2540
2541         [GTK] TestWebKitAccessibility is not skipped
2542         https://bugs.webkit.org/show_bug.cgi?id=141179
2543
2544         Reviewed by Carlos Garcia Campos.
2545
2546         Don't attempt to skip TestWebKitAccessibility. This path is wrong so it was not being
2547         skipped, and it apparently works reliably on the bots.
2548
2549         * Scripts/run-gtk-tests:
2550         (TestRunner):
2551
2552 2015-02-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2553
2554         run-perf-tests: allow to specify a wrapper command.
2555         https://bugs.webkit.org/show_bug.cgi?id=141172
2556
2557         Reviewed by Ryosuke Niwa.
2558
2559         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2560         (parse_args): Update text to indicate is also valid for WTR.
2561         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2562         (PerfTestsRunner._parse_args): Add wrapper command.
2563
2564 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
2565
2566         [Win] Correct version parsing warning in update-webkit
2567         https://bugs.webkit.org/show_bug.cgi?id=141200
2568
2569         Reviewed by Anders Carlsson.
2570
2571         * Scripts/webkitdirs.pm:
2572         (setupAppleWinEnv): Strip out any specific version build level
2573         from the Cygwin version information.
2574
2575
2576 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
2577
2578         [Win] Attempt to improve the reliability of HTTP service
2579         https://bugs.webkit.org/show_bug.cgi?id=141191
2580
2581         Reviewed by Darin Adler.
2582
2583         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2584         (LayoutTestApacheHttpd.__init__): Use default XAMPP pidfile location.
2585         (LayoutTestApacheHttpd._stop_running_server): Delete the abandoned PID file
2586         when stopping the service doesn't do so on its own (for Windows runs).
2587
2588 2015-02-03  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2589
2590         Web platform test server should not need to create __init__.py files
2591         https://bugs.webkit.org/show_bug.cgi?id=141030
2592
2593         Reviewed by Ryosuke Niwa.
2594
2595         W3C TestImporter ensures that copied __init__.py files are not empty.
2596         If needed, a comment is inserted in __init__.py files.
2597         Added a unit test to check that web-platform-tests tools and scripts python modules can be imported.
2598
2599         * Scripts/webkitpy/common/system/filesystem.py:
2600         (FileSystem.getsize):
2601         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
2602         (TestWebPlatformTestServer.test_start_cmd):
2603         (TestWebPlatformTestServer):
2604         (TestWebPlatformTestServer.test_import_web_platform_test_modules):
2605         * Scripts/webkitpy/w3c/test_importer.py:
2606         (TestImporter.import_tests):
2607
2608 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2609
2610         Unreviewed. Moving myself to the committer section.
2611
2612         * Scripts/webkitpy/common/config/contributors.json:
2613
2614 2015-02-02  Saam Barati  <saambarati1@gmail.com>
2615
2616         Create tests for JSC's Control Flow Profiler
2617         https://bugs.webkit.org/show_bug.cgi?id=141123
2618
2619         Reviewed by Filip Pizlo.
2620
2621         * Scripts/run-javascriptcore-tests:
2622         (runJSCStressTests):
2623         * Scripts/run-jsc-stress-tests:
2624
2625 2015-02-02  Csaba Osztrogonác  <ossy@webkit.org>
2626
2627         Remove copy/paste code from run-jsc-stress-tests to determine numberOfTests
2628         https://bugs.webkit.org/show_bug.cgi?id=141158
2629
2630         Reviewed by Darin Adler.
2631
2632         * Scripts/run-jsc-stress-tests:
2633
2634 2015-02-02  Michael Catanzaro  <mcatanzaro@igalia.com>
2635
2636         [GTK] MiniBrowser should close itself on Ctrl+W or Ctrl+Q
2637         https://bugs.webkit.org/show_bug.cgi?id=141142
2638
2639         Reviewed by Carlos Garcia Campos.
2640
2641         * MiniBrowser/gtk/BrowserWindow.c:
2642         (browser_window_init): Quit on Ctrl+W or Ctrl+Q
2643
2644 2015-02-01  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2645
2646         Web platform test server is not always launching properly on Mac EWS bots
2647         https://bugs.webkit.org/show_bug.cgi?id=141141
2648
2649         Unreviewed.
2650
2651         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
2652         (create_wpt_empty_file_if_needed): Removed creation of empty __init.py__ files from AutoInstalled modules.
2653
2654 2015-01-31  Sam Weinig  <sam@webkit.org>
2655
2656         Remove even more Mountain Lion support
2657         https://bugs.webkit.org/show_bug.cgi?id=141124
2658
2659         Reviewed by Alexey Proskuryakov.
2660
2661         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2662         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
2663         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2664         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2665         * DumpRenderTree/mac/DumpRenderTree.mm:
2666         (activateTestingFonts):
2667         (prepareConsistentTestingEnvironment):
2668         * DumpRenderTree/mac/EventSendingController.mm:
2669         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
2670         (-[EventSendingController contextClick]):
2671         * DumpRenderTree/mac/TextInputController.m:
2672         * LayoutTestRelay/Configurations/Base.xcconfig:
2673         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
2674         * MiniBrowser/Configurations/Base.xcconfig:
2675         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2676         * MiniBrowser/mac/WK2BrowserWindowController.m:
2677         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2678         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
2679         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
2680         * TestWebKitAPI/Configurations/Base.xcconfig:
2681         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2682         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2683         (-[DownloadDelegate _downloadDidFinish:]):
2684         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
2685         (TestWebKitAPI::TEST):
2686         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
2687         (TestWebKitAPI::InjectedBundleController::platformInitialize):
2688         * WebKitLauncher/Configurations/Base.xcconfig:
2689         * WebKitTestRunner/Configurations/Base.xcconfig:
2690         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2691         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2692         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
2693         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
2694         (WTR::activateFonts):
2695         * WebKitTestRunner/TestController.cpp:
2696         (WTR::TestController::initialize):
2697         (WTR::TestController::webProcessName):
2698         * WebKitTestRunner/mac/EventSenderProxy.mm:
2699         * asan/asan.xcconfig:
2700
2701 2015-01-31  Commit Queue  <commit-queue@webkit.org>
2702
2703         Unreviewed, rolling out r179408.
2704         https://bugs.webkit.org/show_bug.cgi?id=141117
2705
2706         This didn't fully fix the issue (Requested by anttik on
2707         #webkit).
2708
2709         Reverted changeset:
2710
2711         "OSObjectPtr does not work with dispatch_data_t on Maverics"
2712         https://bugs.webkit.org/show_bug.cgi?id=141081
2713         http://trac.webkit.org/changeset/179408
2714
2715 2015-01-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2716
2717         https://trac.webkit.org/changeset/179439 breaks a python test
2718         https://bugs.webkit.org/show_bug.cgi?id=141114
2719
2720         Unreviewed.
2721
2722         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2723         (WebPlatformTestServer._install_modules): Checks whether WPTModules file exists before reading it as no such file exists in mock tests.
2724
2725 2015-01-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2726
2727         Import W3C web platform tests infrastructure
2728         https://bugs.webkit.org/show_bug.cgi?id=140934
2729
2730         Reviewed by Ryosuke Niwa.
2731
2732         Loading necessary web platform tests modules before launching server.
2733         Ensuring that some empty __init__.py files are present and create them if necessary.
2734
2735         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
2736         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2737
2738 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
2739
2740         [Win] Another unreviewed test fix.
2741
2742         Correct copy/paste error in buildbot handling.
2743
2744         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2745         (LayoutTestApacheHttpd.__init__):
2746         (LayoutTestApacheHttpd._get_apache_config_file_path):
2747
2748 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
2749
2750         [Win] Unreviewed test fix.
2751
2752         Correct path handling based on failures on test bots to get things running again.
2753
2754         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2755         (LayoutTestApacheHttpd.__init__):
2756         (LayoutTestApacheHttpd._get_apache_config_file_path):
2757
2758 2015-01-30  Chris Dumez  <cdumez@apple.com>
2759
2760         Unreviewed. Fix Windows build after r179409.
2761
2762         * DumpRenderTree/win/TestRunnerWin.cpp:
2763         (TestRunner::notifyDone):
2764         (TestRunner::queueLoad):
2765
2766 2015-01-30  Chris Dumez  <cdumez@apple.com>
2767
2768         Rename shared() static member functions to singleton() for singleton classes.
2769         https://bugs.webkit.org/show_bug.cgi?id=141088
2770
2771         Reviewed by Ryosuke Niwa and Benjamin Poulain.
2772
2773         Rename shared() static member functions to singleton() for singleton
2774         classes as per the recent coding style change.
2775
2776 2015-01-30  Antti Koivisto  <antti@apple.com>
2777
2778         OSObjectPtr does not work with dispatch_data_t on Maverics
2779         https://bugs.webkit.org/show_bug.cgi?id=141081
2780
2781         Reviewed by Pratik Solanki.
2782
2783         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp:
2784         (TestWebKitAPI::TEST):
2785
2786 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
2787
2788         [Win] Switch to Apache on Windows
2789         https://bugs.webkit.org/show_bug.cgi?id=141060
2790
2791         Reviewed by Alexey Proskuryakov.
2792
2793         Update our scripts under Windows (and Cygwin) to locate and use
2794         the XAMPP installation of Apache for running tests.
2795
2796         * Scripts/run-webkit-httpd:
2797         * Scripts/webkitperl/httpd.pm:
2798         (getHTTPDPath):
2799         (getDefaultConfigForTestDirectory):
2800         (getHTTPDConfigPathForTestDirectory):
2801         * Scripts/webkitpy/common/system/executive_unittest.py:
2802         (ExecutiveTest.serial_test_kill_process):
2803         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2804         (LayoutTestApacheHttpd.__init__):
2805         (LayoutTestApacheHttpd._get_apache_config_file_path):
2806         (LayoutTestApacheHttpd._stop_running_server):
2807         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2808         (HttpServerBase._is_server_running_on_all_ports):
2809         * Scripts/webkitpy/port/base.py:
2810         (Port._apache_config_file_name_for_platform):
2811         * Scripts/webkitpy/port/port_testcase.py:
2812         (test_apache_config_file_name_for_platform):
2813         * Scripts/webkitpy/port/win.py:
2814         (WinPort.show_results_html_file):
2815         (WinPort._uses_apache):
2816         (WinPort):
2817         (WinPort._path_to_apache):
2818
2819 2015-01-29  Alexey Proskuryakov  <ap@apple.com>
2820
2821         Built result takes too long to be compressed on bots
2822         https://bugs.webkit.org/show_bug.cgi?id=141056
2823
2824         Reviewed by Daniel Bates.
2825
2826         Reduces compression time from ~3.5 min to ~1.5 min. Archive size gets 2% bigger.
2827
2828         * BuildSlaveSupport/test-result-archive: (archiveTestResults):
2829
2830 2015-01-29  Sam Weinig  <sam@webkit.org>
2831
2832         Remove support for screen font substitution
2833         https://bugs.webkit.org/show_bug.cgi?id=141038
2834
2835         Reviewed by Tim Horton.
2836
2837         * DumpRenderTree/win/DumpRenderTree.cpp:
2838         (resetWebPreferencesToConsistentValues):
2839         Remove call to now setScreenFontSubstitutionEnabled() which is a no-op.
2840
2841 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
2842
2843         Make run-jsc-stress-tests --remote work on Linux too
2844         https://bugs.webkit.org/show_bug.cgi?id=141000
2845
2846         Reviewed by Darin Adler.
2847
2848         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Omit error message of sysctl,
2849         use bash/dash compatible signal names, use Linux/Mac compatible find options,
2850         use bash/dash compatible functions.
2851         * Scripts/run-jsc-stress-tests: Use Linux/Mac compatible find options.
2852
2853 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
2854
2855         [buildbot] Simplify jscore-test buildstep
2856         https://bugs.webkit.org/show_bug.cgi?id=140821
2857
2858         Reviewed by Alexey Proskuryakov.
2859
2860         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2861         (RunJavaScriptCoreTests): Inherited from TestWithFailureCount and removed useless actual.html logfile.
2862         (RunJavaScriptCoreTests.countFailures): Added.
2863         (RunJavaScriptCoreTests.commandComplete): Deleted.
2864         (RunJavaScriptCoreTests.evaluateCommand): Deleted.
2865         (RunJavaScriptCoreTests.getText): Deleted.
2866         (RunJavaScriptCoreTests.getText2): Deleted.
2867         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated.
2868         (RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output):
2869         (RunJavaScriptCoreTestsTest.test_mozilla_failures_old_output):
2870         (RunJavaScriptCoreTestsTest.test_jsc_stress_failure_new_output):
2871         (RunJavaScriptCoreTestsTest.test_jsc_stress_failures_new_output):
2872
2873 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
2874
2875         Unreviewed, revert r179337, we don't need this dependency.
2876
2877         * efl/install-dependencies:
2878         * gtk/install-dependencies:
2879
2880 2015-01-28  Shivakumar JM  <shiva.jm@samsung.com>
2881
2882         Unreviewed. Moving myself to the committer section.
2883
2884         * Scripts/webkitpy/common/config/contributors.json:
2885
2886 2015-01-28  Csaba Osztrogonác  <ossy@webkit.org>
2887
2888         URTBF after r179326, added uuid-dev package as new dependency.
2889
2890         * efl/install-dependencies:
2891         * gtk/install-dependencies:
2892
2893 2015-01-28  Timothy Horton  <timothy_horton@apple.com>
2894
2895         Add a WebKitMessageRecorder DTrace provider, exposing IPC details to DTrace
2896         https://bugs.webkit.org/show_bug.cgi?id=140673
2897
2898         Reviewed by Sam Weinig.
2899
2900         * Scripts/dtrace/trace-webkit2-messages.d: Added.
2901         Add a DTrace script that outputs a small blob of JSON per message.
2902
2903 2015-01-28  Geoffrey Garen  <ggaren@apple.com>
2904
2905         Removed fastMallocForbid / fastMallocAllow
2906         https://bugs.webkit.org/show_bug.cgi?id=141012
2907
2908         Reviewed by Mark Hahnenberg.
2909
2910         Fixed a test bug I noticed while testing.
2911
2912         * DumpRenderTree/JavaScriptThreading.cpp:
2913         (stopJavaScriptThreads): Lock the javaScriptThreads lock before
2914         accessing javaScriptThreads -- otherwise, you'll ASSERT.
2915
2916 2015-01-28  Dana Burkart  <dburkart@apple.com>
2917
2918         asan.xcconfig should use CLANG_ADDRESS_SANITIZER=YES instead of -fsanitize=address
2919         https://bugs.webkit.org/show_bug.cgi?id=141015
2920
2921         Reviewed by Alexey Proskuryakov.
2922
2923         * asan/asan.xcconfig:
2924
2925 2015-01-28  Sam Weinig  <sam@webkit.org>
2926
2927         Fix the build.
2928
2929         * Scripts/copy-webkitlibraries-to-product-directory:
2930
2931 2015-01-28  Lucas Forschler  <lforschler@apple.com>
2932
2933         Increase the FileUpload block size in an attempt to improve network performance.
2934
2935         Reviewed by Alexey Proskuryakov.
2936
2937         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2938         (UploadBuiltProduct.__init__):
2939
2940 2015-01-28  Dana Burkart  <dburkart@apple.com>
2941
2942         Move ASan flag settings from DebugRelease.xcconfig to Base.xcconfig
2943         https://bugs.webkit.org/show_bug.cgi?id=136765
2944
2945         Reviewed by Alexey Proskuryakov.
2946
2947         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2948         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2949         * LayoutTestRelay/Configurations/Base.xcconfig:
2950         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
2951         * MiniBrowser/Configurations/Base.xcconfig:
2952         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2953         * TestWebKitAPI/Configurations/Base.xcconfig:
2954         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2955         * WebKitLauncher/Configurations/Base.xcconfig:
2956         * WebKitTestRunner/Configurations/Base.xcconfig:
2957         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2958
2959 2015-01-28  Joanmarie Diggs  <jdiggs@igalia.com>
2960
2961         AX: [ATK] Implement support for new AtkRole types for MathML
2962         https://bugs.webkit.org/show_bug.cgi?id=140916
2963
2964         Reviewed by Chris Fleizach.
2965
2966         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Add mapping for new ATK roles
2967         * gtk/jhbuild.modules: Bump minimum version of ATK used by jhbuild to 2.15.4
2968
2969 2015-01-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2970
2971         [GTK] Stop removing color marks from unit tests output
2972         https://bugs.webkit.org/show_bug.cgi?id=140996
2973
2974         Reviewed by Philippe Normand.
2975
2976         Since r178236 google tests use a custom simplified output without
2977         any colors, so we don't need to handle the case of non ttys to
2978         remove the color marks.
2979
2980         * Scripts/run-gtk-tests:
2981         (TestRunner.__init__):
2982         (TestRunner._run_test_command.parse_line):
2983
2984 2015-01-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2985
2986         [GTK] Unit test /webkit2/WebKitWebView/page-visibility from WebKit2Gtk/TestWebKitWebView fails
2987         https://bugs.webkit.org/show_bug.cgi?id=131731
2988
2989         Reviewed by Žan Doberšek.
2990
2991         A web page loaded offscreen is in prerender state not hidden.
2992
2993         * Scripts/run-gtk-tests:
2994         (TestRunner): Unskip /webkit2/WebKitWebView/page-visibility.
2995         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2996         (testWebViewPageVisibility):
2997
2998 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
2999
3000         Partially revert r178802.
3001
3002         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png:
3003         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png:
3004
3005 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
3006
3007         build.webkit.org/dashboard asserts on some commits
3008         https://bugs.webkit.org/show_bug.cgi?id=140926
3009
3010         Reviewed by Tim Horton.
3011
3012         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3013         (Trac.prototype._convertCommitInfoElementToObject): Added a case for another root directory.
3014
3015 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
3016
3017         Make flakiness dashboard OS list actually match test_expectations.py
3018         https://bugs.webkit.org/show_bug.cgi?id=140969
3019
3020         Reviewed by Ryosuke Niwa.
3021
3022         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3023
3024 2015-01-27  Brent Fulgham  <bfulgham@apple.com>
3025
3026         [Win] WinLauncher crashes on eleventh site visited
3027         https://bugs.webkit.org/show_bug.cgi?id=140960
3028
3029         Reviewed by Anders Carlsson.
3030
3031         * WinLauncher/WinLauncher.cpp:
3032         (WinLauncher::showLastVisitedSites): Don't access off the end of
3033         the history array.
3034
3035 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
3036
3037         [Mac] Disable building Java applets by default
3038         https://bugs.webkit.org/show_bug.cgi?id=140957
3039         rdar://problem/19619529
3040
3041         Reviewed by Anders Carlsson.
3042
3043         It was actually already disabled unconditionally, by accident.
3044
3045         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args):
3046         * Scripts/webkitpy/port/mac.py:
3047         (MacPort._check_port_build):
3048         (MacPort._build_java_test_support):
3049
3050 2015-01-27  Daniel Bates  <dabates@apple.com>
3051
3052         [iOS] run-webkit-tests --platform=ios* --lint-test-files does not work
3053         https://bugs.webkit.org/show_bug.cgi?id=140949
3054
3055         Reviewed by Alexey Proskuryakov.
3056
3057         Add "ios-simulator" and "ios-simulator-wk2" to the list of ports without
3058         builders so that run-webkit-tests can lint the appropriate TestExpectation
3059         files.
3060
3061         * Scripts/webkitpy/port/builders.py:
3062         * Scripts/webkitpy/port/ios.py:
3063         (IOSSimulatorPort.__init__): Move logic to query for the Mac build directory from here...
3064         (IOSSimulatorPort.relay_path): to here as this is the only caller that makes use of that
3065         information to find the LayoutTestRelay tool. Otherwise, "self.assertEqual(len(calls), 1)"
3066         in unit test webkitpy.tool.commands.rebaseline_unittest.TestRebaselineExpectations.test_rebaseline_expectations
3067         will fail because IOSSimulatorPort.__init__() ultimately calls Tools/Scripts/webkit-build-directory
3068         to determine the Mac build directory for each instantiation of IOSSimulatorPort. And this unit
3069         test instantiates a port object for each builder listed in file Scripts/webkitpy/port/builders.py.
3070
3071
3072 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
3073
3074         Update bots on the flakiness dashboard
3075         https://bugs.webkit.org/show_bug.cgi?id=140956
3076
3077         Reviewed by Ryosuke Niwa.
3078
3079         * TestResultServer/static-dashboards/builders.jsonp:
3080         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3081
3082 2015-01-27  Daniel Bates  <dabates@apple.com>
3083
3084         [iOS WK2] Add directory LayoutTests/platform/wk2 to the list of baseline search paths
3085         https://bugs.webkit.org/show_bug.cgi?id=140942
3086
3087         Reviewed by Alexey Proskuryakov.
3088
3089         The directory LayoutTests/platform/wk2 contains test expectations and test results that
3090         are applicable to all WebKit2 ports. We should make use of this information when
3091         running layout tests using iOS WebKit2.
3092
3093         Additionally, make use of the convenience function Port._wk2_port_name() for the name
3094         of the WebKit2 port instead of directly using string concatenation.
3095
3096         * Scripts/webkitpy/port/ios.py:
3097         (IOSSimulatorPort.default_baseline_search_path):
3098
3099 2015-01-27  Csaba Osztrogonác  <ossy@webkit.org>
3100
3101         [Win] Disable FTL stress tests
3102         https://bugs.webkit.org/show_bug.cgi?id=140932
3103
3104         Reviewed by Brent Fulgham.
3105
3106         * Scripts/run-javascriptcore-tests:
3107
3108 2015-01-27  Daniel Bates  <dabates@apple.com>
3109
3110         REGRESSION (r179130): Perl warns about subroutine redefinition when running configure-xcode-for-ios-development
3111         https://bugs.webkit.org/show_bug.cgi?id=140939
3112
3113         Reviewed by Eric Carlson.
3114
3115         Fixes the Perl warning: "Subroutine wanted redefined at Tools/Scripts/configure-xcode-for-ios-development line 106."
3116
3117         * Scripts/webkitdirs.pm:
3118         (hasUserInstalledAppInSimulatorDevice): Pass a reference to an anonymous function instead
3119         of a named function to find() to avoid redefinition warnings in scripts that include webkitdirs.pm
3120         and define a function called wanted.
3121
3122 2015-01-27  Daniel Bates  <dabates@apple.com>
3123
3124         Teach run-webkit-app --simulator how to install custom built app
3125         https://bugs.webkit.org/show_bug.cgi?id=140691
3126
3127         Fix inadvertent omission of directory test flag in expression to check for the
3128         existence of the iOS simulator device-specific directory for user installed apps.
3129
3130         * Scripts/webkitdirs.pm:
3131         (hasUserInstalledAppInSimulatorDevice):
3132
3133 2015-01-26  Brent Fulgham  <bfulgham@apple.com>
3134
3135         [Win] ASSERTION FAILED !m_ptr under AccessibilityController::winAddNotificationListener
3136         https://bugs.webkit.org/show_bug.cgi?id=87426
3137         <rdar://problem/11527899>
3138
3139         Reviewed by Darin Adler.
3140
3141         Revise COMPtr to work better with our HashMap implementation. Use
3142         modern loop syntax.
3143
3144         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3145         (AccessibilityController::~AccessibilityController):
3146         (AccessibilityController::winNotificationReceived):
3147         * DumpRenderTree/win/DumpRenderTree.cpp:
3148         (dumpBackForwardListForAllWindows):
3149
3150 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
3151
3152         [Win] Enable JSC stress tests by default
3153         https://bugs.webkit.org/show_bug.cgi?id=128307
3154
3155         Reviewed by Brent Fulgham.
3156
3157         * Scripts/run-javascriptcore-tests:
3158
3159 2015-01-26  Simon Fraser  <simon.fraser@apple.com>
3160
3161         [iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in
3162         arguments for build and test scripts
3163         https://bugs.webkit.org/show_bug.cgi?id=139748
3164
3165         Reviewed by Daniel Bates.
3166
3167         There was much confusion resulting from the multitude of aliases used to build/test for
3168         the iOS simulator. Standardize on "--ios-simulator", which is also the name of the layout
3169         tests directory.
3170
3171         This fixes an issue where run-api-tests and some other scripts failed when run with
3172         --simulator.
3173
3174         * Scripts/build-webkit:
3175         * Scripts/package-root:
3176         (usage):
3177         * Scripts/webkitdirs.pm:
3178         (argumentsForConfiguration):
3179         (determineXcodeSDK):
3180         * Scripts/webkitpy/port/factory.py:
3181         (platform_options):
3182
3183 2015-01-26  Simon Fraser  <simon.fraser@apple.com>
3184
3185         [iOS WK2] Fix possible crash when -[WKWebView evaluateJavaScript:completionHandler:] was called then the WKWebView is destroyed
3186         https://bugs.webkit.org/show_bug.cgi?id=140203
3187         rdar://problem/19198492
3188
3189         Reviewed by Sam Weinig.
3190
3191         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3192         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm: Added.
3193         (TEST):
3194
3195 2015-01-26  David Kilzer  <ddkilzer@apple.com>
3196
3197         Add iOS EWS to build.webkit.org/dashboard
3198         <http://webkit.org/b/140627>
3199
3200         Reviewed by Alexey Proskuryakov.
3201
3202         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png: Add.
3203         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png: Add.
3204         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3205         (BubbleQueueServer): Add ios-ews queue info.
3206         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3207         Add iOS8Device platform.
3208         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3209         (table.queue-grid tr.platform.ios-8 img.logo): Add CSS to draw
3210         iOS device logo.
3211
3212 2015-01-26  Filip Pizlo  <fpizlo@apple.com>
3213
3214         copy-webkitlibraries-to-product-directory's hack to build LLVM from source should be hardened for Xcode deciding it needs SDKROOT set
3215         https://bugs.webkit.org/show_bug.cgi?id=140896
3216
3217         Reviewed by Michael Saboff.
3218
3219         I've encountered some Xcode setups where you need to set SDKROOT to get llvm to build. This
3220         makes our script do this.
3221
3222         Note that an alternative would be to run clang via "xcrun clang" rather than directly, but
3223         this would be harder given llvm's autoconf setup.
3224
3225         * Scripts/copy-webkitlibraries-to-product-directory:
3226
3227 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
3228
3229         Update bot assignments.
3230
3231         * BuildSlaveSupport/build.webkit.org-config/config.json:
3232
3233 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3234
3235         Integrate WP python server into WebKit test framework
3236         https://bugs.webkit.org/show_bug.cgi?id=127094
3237
3238         Reviewed by Ryosuke Niwa.
3239
3240         This patch adds W3C web server (wptserver) as a new HTTP server.
3241         wptserver is used to serve all tests inside LayoutTests/imported/w3c/wpt.
3242         wptserver implementation should be imported within the import of the Web Platform Test suite (to ensure keeping server and tests in sync) in LayoutTests/imported/w3c/wpt.
3243
3244         Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py serves as main entry point to wpt spawned process.
3245         Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py is responsible to start/stop the wpt server process.
3246         It also sets up the server config and testharness.js/testharnessreport.js files at start and stop of the wpt server.
3247
3248         * Scripts/webkitpy/common/system/executive_mock.py:
3249         (MockProcess.communicate):
3250         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py: Adding start/stop of web platform test server according boolean parameter.
3251         (LayoutTestRunner.__init__):
3252         (LayoutTestRunner.run_tests):
3253         (LayoutTestRunner.start_servers):
3254         (LayoutTestRunner.stop_servers):
3255         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py: Updated to check for wpt server start/stop.
3256         (LayoutTestRunnerTests._run_tests):
3257         (LayoutTestRunnerTests.test_servers_started.start_web_platform_test_server):
3258         (LayoutTestRunnerTests.test_servers_started.stop_web_platform_test_server):
3259         (LayoutTestRunnerTests):
3260         (LayoutTestRunnerTests.test_servers_started):
3261         * Scripts/webkitpy/layout_tests/controllers/manager.py:  Updated to check whether a test is a wpt test and whether wpt server launch is needed.
3262         (Manager.__init__):
3263         (Manager._is_http_test):
3264         (Manager._is_web_platform_test):
3265         (Manager._run_tests):
3266         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3267         (ManagerTest.test_needs_servers.get_wpt_doc_root):
3268         (ManagerTest.test_needs_servers.get_manager):
3269         (ManagerTest.test_needs_servers):
3270         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Added an option to control the doc_root of the wpt server.
3271         (parse_args):
3272         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py: Added.
3273         (main):
3274         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py: Added.
3275         (doc_root):
3276         (base_url):
3277         (WebPlatformTestServer):
3278         (WebPlatformTestServer.__init__):
3279         (WebPlatformTestServer._set_start_cmd):
3280         (WebPlatformTestServer._copy_webkit_test_files):
3281         (WebPlatformTestServer._clean_webkit_test_files):
3282         (WebPlatformTestServer._prepare_config):
3283         (WebPlatformTestServer._spawn_process):
3284         (WebPlatformTestServer._stop_running_server):
3285         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py: Added.
3286         (TestWebPlatformTestServer):
3287         (TestWebPlatformTestServer.test_start_cmd):
3288         * Scripts/webkitpy/port/base.py:
3289         (Port.__init__):
3290         (Port.to.start_web_platform_test_server):
3291         (Port.to):
3292         (Port.to.web_platform_test_server_doc_root):
3293         (Port.to.web_platform_test_server_base_url):
3294         (Port.to.stop_web_platform_test_server):
3295         * Scripts/webkitpy/port/driver.py: Updated the test name <-> test URL conversion routines.
3296         (Driver.__init__):
3297         (Driver.is_web_platform_test):
3298         (Driver.test_to_uri):
3299         (Driver.uri_to_test):
3300         (Driver._command_from_driver_input):
3301         * Scripts/webkitpy/port/driver_unittest.py:  Updated tests according new conversion rules.
3302         (DriverTest.test_test_to_uri):
3303         (DriverTest.test_uri_to_test):
3304
3305 2015-01-26  Daniel Bates  <dabates@apple.com>
3306
3307         Teach run-webkit-app --simulator how to install custom built app
3308         https://bugs.webkit.org/show_bug.cgi?id=140691
3309
3310         Reviewed by David Kilzer.
3311
3312         We should teach run-webkit-app --simulator how to install a custom built app.
3313
3314         Currently run-webkit-app --simulator can only run a system app or an app that
3315         was installed using the simctl command line tool. For convenience we should
3316         teach run-webkit-app --simulator how to install a custom built app.
3317
3318         As a side effect of this change run-safari --simulator will install and run
3319         a custom built of MobileSafari (if it exists).
3320
3321         * Scripts/webkitdirs.pm:
3322         (iOSSimulatorDevices): Added FIXME comment to decouple device representation in
3323         Perl from the structure of the device.plist file.
3324         (plistPathFromBundle): Fix if-statement condition so that we actually perform a
3325         file system check to determine the plist path for a Mac app bundle.
3326         (appIdentifierFromBundle): Pass absolute files system path to defaults(1). Otherwise,
3327         it will complain that it cannot find the file: "Domain ... does not exist".
3328         (appDisplayNameFromBundle): Ditto.
3329         (waitUntilIOSSimulatorDeviceIsInState): Added; helper function that does not return
3330         until a simulator device is the specified state.
3331         (relaunchIOSSimulator): Renamed; formerly named openIOSSimulator. Quits iOS Simulator
3332         (if it's open) before opening it again so as to ensure that the iOS Simulator boots
3333         the specified device.
3334         (quitIOSSimulator): Added optional parameter, $waitForShutdownOfSimulatedDeviceUDID.
3335         As implied by its name, this function will not return until the specified simulator
3336         device UDID is in the shutdown state.
3337         (iosSimulatorDeviceByUDID): Added; returns the device dictionary object for the simulator
3338         device with the specified UDID.
3339         (isIOSSimulatorSystemInstalledApp): Resolve symbolic links in iosSimulatorApplicationsPath()
3340         before using it as part of a prefix match to avoid a mismatch. In the public iOS 8.1 SDK the
3341         return value of iosSimulatorApplicationsPath(), which returns a result analogous to the shell
3342         expression echo `xcrun --sdk iphonesimulator --show-sdk-path`/Applications/, contains a
3343         symbolic link. Specifically, echo `xcrun --sdk iphonesimulator --show-sdk-path` returns
3344         /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator8.1.sdk,
3345         which is a symbolic link to /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator.sdk.
3346         (hasUserInstalledAppInSimulatorDevice): Added.
3347         (isSimulatorDeviceBooted): Added; returns whether the specified simulator device is in the
3348         "Booted" state.
3349         (runIOSWebKitAppInSimulator): Modified to install a custom built app (if needed). For now,
3350         switching between a system installed app and a custom built version of the same app (e.g.
3351         custom build of MobileSafari) will erase all contents and settings in the simulator device.
3352         (eraseIOSSimulatorDevice): Deleted; inline implementation into runIOSWebKitAppInSimulator()
3353         as that was the only caller of this function.
3354         (bootedIOSSimulatorDevice): Deleted.
3355         (openIOSSimulator): Deleted.
3356
3357 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
3358
3359         Update bot assignments.
3360
3361         * BuildSlaveSupport/build.webkit.org-config/config.json:
3362
3363 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
3364
3365         Leaks bot shouldn't run JSC tests
3366         https://bugs.webkit.org/show_bug.cgi?id=140877
3367
3368         Reviewed by Darin Adler.
3369
3370         Shaves off 48 minutes of time.
3371
3372         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3373         (TestLeaksFactory): Slim down the leaks queue.
3374
3375         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3376         * Scripts/webkitpy/port/ios.py:
3377         (IOSSimulatorPort.print_leaks_summary):
3378         * Scripts/webkitpy/port/mac.py:
3379         (MacPort.print_leaks_summary):
3380         Don't yell when leaks are detected.
3381
3382 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
3383
3384         Refactor run-javascriptcore-tests
3385         https://bugs.webkit.org/show_bug.cgi?id=140824
3386
3387         Reviewed by Darin Adler.
3388
3389         Separated mozilla, stress test code paths and
3390         determining skipped mozilla tests into subroutines.
3391
3392         * Scripts/run-javascriptcore-tests:
3393         (runMozillaTests):
3394         (runJSCStressTests):
3395         (defaultJsDriverArgsForMozillaTests):
3396
3397 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
3398
3399         [buildbot] Fix grammar of TestWithFailureCount
3400         https://bugs.webkit.org/show_bug.cgi?id=140884
3401
3402         Reviewed by Alexey Proskuryakov.
3403
3404         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3405         (TestWithFailureCount):
3406         (TestWithFailureCount.commandComplete):
3407         (TestWithFailureCount.getText2):
3408         (RunUnitTests):
3409         (RunPythonTests):
3410         (RunPerlTests):
3411         (RunLLINTCLoopTests):
3412         (Run32bitJSCTests):
3413         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3414         (RunLLINTCLoopTestsTest.test_failure):
3415         (Run32bitJSCTestsTest.test_failure):
3416         (RunUnitTestsTest.assertFailures):
3417
3418 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3419
3420         Unreviewed. Moving myself to the committer section.
3421
3422         * Scripts/webkitpy/common/config/contributors.json:
3423
3424 2015-01-26  Michael Catanzaro  <mcatanzaro@igalia.com> and Carlos Garcia Campos  <cgarcia@igalia.com>
3425
3426         [GTK] gtkdoc does not appear in DevHelp
3427         https://bugs.webkit.org/show_bug.cgi?id=139369
3428
3429         Reviewed by Philippe Normand.
3430
3431         * gtk/generate-gtkdoc: Create the generators in the main function
3432         and use them to get the local cross renference dependencies. Also
3433         pass the generator module name to webkitdom.write_doc_files().
3434         (get_gtkdoc_module_paths): Receive a list of local cross reference
3435         dependencies.
3436         (get_generator_for_config): Set the main_sgml_file property of the
3437         GtkDoc object from the configuration file.
3438         (generate_documentation): Generate the documentation for the given
3439         generator.
3440         (generate_documentation_for_config): Deleted.
3441         * gtk/manifest.txt.in: Expect the API version in the gtkdoc filenames.
3442         * gtk/webkitdom.py:
3443         (write_doc_files): Receive the module name used to build the
3444         -sections.txt filename.
3445
3446 2015-01-26  Commit Queue  <commit-queue@webkit.org>
3447
3448         Unreviewed, rolling out r179107.
3449         https://bugs.webkit.org/show_bug.cgi?id=140880
3450
3451         The GCC in the bots doesn't support the AsyncTask
3452         implementation (Requested by KaL on #webkit).
3453
3454         Reverted changeset:
3455
3456         "[GTK] Enable IndexedDB"
3457         https://bugs.webkit.org/show_bug.cgi?id=98932
3458         http://trac.webkit.org/changeset/179107
3459
3460 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
3461
3462         [EFL] Bump libseccomp version to 2.1.1
3463         https://bugs.webkit.org/show_bug.cgi?id=140357
3464
3465         Reviewed by Gyuyoung Kim.
3466
3467         * efl/jhbuild.modules:
3468
3469 2015-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
3470
3471         [GTK] Enable IndexedDB
3472         https://bugs.webkit.org/show_bug.cgi?id=98932
3473
3474         Reviewed by Žan Doberšek.
3475
3476         * Scripts/webkitperl/FeatureList.pm: Enable IndexedDB for the GTK port.
3477
3478 2015-01-25  Alexey Proskuryakov  <ap@apple.com>
3479
3480         Would like leaks bot results at build.webkit.org/dashboard
3481         https://bugs.webkit.org/show_bug.cgi?id=122657
3482
3483         Reviewed by Darin Adler.
3484
3485         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3486         Record links provided by buildbot steps. Currently, the dashboard hardcodes more links
3487         than necessary, could use the ones from buildbot in more places.
3488
3489         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3490         (BuildbotQueue): Reflect configuration option for leaks queues.
3491
3492         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3493         Add leaks queues to performance column. First, leaks are about performance indeed,
3494         and second, this is where we have some space to spare.
3495
3496         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3497         (WebKitBuildbot): Added Yosemite Leaks queue, which was sitting neglected for at
3498         least a year.
3499
3500         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3501         (table.queue-grid td): Moved height from queue-view - we can now have more than one
3502         queue view per cell. The heigt is needed to avoid ugly overlapping while loading
3503         results - once the results are loaded, all rows are currently higher than that.
3504
3505         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
3506         (.leaks-popover): Added.
3507
3508         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
3509         Added.
3510
3511         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
3512         Load BuildbotLeaksQueueView.js.
3513
3514 2015-01-25  peavo@outlook.com  <peavo@outlook.com>
3515
3516         [Win] Add WebKit message loop interface.
3517         https://bugs.webkit.org/show_bug.cgi?id=140857
3518
3519         Reviewed by Brent Fulgham.
3520
3521         Added message loop interface which will run the message loop,
3522         and perform required tasks (like calling CFRunLoopRunInMode)
3523         on each iteration of the loop.
3524
3525         * WinLauncher/WinMain.cpp:
3526         (wWinMain): Use new message loop interface.
3527
3528 2015-01-24  Dan Bernstein  <mitz@apple.com>
3529
3530         update-webkit’s --internal option is unused
3531         https://bugs.webkit.org/show_bug.cgi?id=140861
3532
3533         Reviewed by Anders Carlsson.
3534
3535         * Scripts/update-webkit: Removed the option.
3536
3537 2015-01-24  Brent Fulgham  <bfulgham@apple.com>
3538
3539         DumpRenderTree needs to run with Windows native controls on Windows
3540         https://bugs.webkit.org/show_bug.cgi?id=25592
3541
3542         Reviewed by Anders Carlsson.
3543
3544         * DumpRenderTree/win/DumpRenderTree.cpp:
3545         (resetWebPreferencesToConsistentValues): Tell DRT to use native controls.
3546         (prepareConsistentTestingEnvironment): Ditto.
3547
3548 2015-01-23  David Kilzer  <ddkilzer@apple.com>
3549
3550         test-webkitpy: webkitpy.tool.commands.earlywarningsystem_unittest.EarlyWarningSystemTest.test_ewses fails on EFL, GTK, Win ports
3551         <http://webkit.org/b/140787>
3552
3553         Reviewed by Daniel Bates.
3554
3555         * Scripts/webkitpy/port/ios.py:
3556         (IOSPort.determine_full_port_name): Instead of checking the type
3557         of the current host, test if /usr/bin/xcrun exists before trying
3558         to use it.
3559
3560 2015-01-23  Csaba Osztrogonác  <ossy@webkit.org>
3561
3562         Fix the false positive build failures on the Windows buildbots
3563         https://bugs.webkit.org/show_bug.cgi?id=140819
3564
3565         Reviewed by Brent Fulgham.
3566
3567         Increase the build timeout (without producing output) to 2 hours for Windows bots,
3568         the default 20 minutes is enough for others since they produce output during the build.
3569
3570         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3571         (BuildFactory.__init__):
3572
3573 2015-01-23  Brent Fulgham  <bfulgham@apple.com>
3574
3575         [Win] Teach WebKit to provide IAccessible2 'get_language' and access AXLanguage
3576         https://bugs.webkit.org/show_bug.cgi?id=140839
3577
3578         Reviewed by Dean Jackson.
3579
3580         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3581         (AccessibilityUIElement::language): Retrieve the 'language' BSTR
3582         from the IA2Locale structure and pass it to DRT.
3583
3584 2015-01-23  Brent Fulgham  <bfulgham@apple.com>
3585
3586         [Win] Update DRT Accessibility implementation to better match Mac.
3587         https://bugs.webkit.org/show_bug.cgi?id=140830
3588
3589         Reviewed by Dean Jackson.
3590
3591         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3592         (AccessibilityUIElement::titleUIElement):
3593         (AccessibilityUIElement::parentElement):
3594         (convertToDRTLabel):
3595         (AccessibilityUIElement::role):
3596         (AccessibilityUIElement::title):
3597         (AccessibilityUIElement::description):
3598         (AccessibilityUIElement::stringValue):
3599         (AccessibilityUIElement::helpText):
3600         (AccessibilityUIElement::isFocused):
3601
3602 2015-01-23  Sergio Villar Senin  <svillar@igalia.com>
3603
3604         REGRESSION: run-perf-tests --profiler= seems to have broken
3605         https://bugs.webkit.org/show_bug.cgi?id=113528
3606
3607         Reviewed by Daniel Bates.
3608
3609         The problem is that "perf --record" (or the equivalent call for
3610         other profilers) is never called whenever there is a wrapper
3611         option in the port. We should inject the profiler call first
3612         (should it exists) and then use the port wrapper.
3613
3614         * Scripts/webkitpy/port/driver.py:
3615         (Driver._command_wrapper):
3616         * Scripts/webkitpy/port/driver_unittest.py:
3617         (DriverTest.test_profiler_and_wrapper): New unit test.
3618
3619 2015-01-22  David Kilzer  <ddkilzer@apple.com>
3620
3621         configure-xcode-for-ios-development needs to import webkitdirs.pm
3622         <http://webkit.org/b/140704>
3623
3624         Fixes the following runtime error:
3625
3626             Undefined subroutine &main::exitStatus called at ./Tools/Scripts/configure-xcode-for-ios-development line 167.
3627
3628         * Scripts/configure-xcode-for-ios-development: Add back code to
3629         import webkitdirs.pm for the exitStatus() method.  Not sure why
3630         I removed it before patch review.
3631
3632 2015-01-22  Timothy Horton  <timothy_horton@apple.com>
3633
3634         REGRESSION (r178847): Yosemite 32-bit bot isn't doing any work
3635         https://bugs.webkit.org/show_bug.cgi?id=140795
3636
3637         Reviewed by Jon Honeycutt.
3638
3639         * BuildSlaveSupport/build.webkit.org-config/config.json:
3640         r178847 accidentally remove the scheduler for this bot. Re-add it to the
3641         Yosemite scheduler.
3642
3643 2015-01-22  Brent Fulgham  <bfulgham@apple.com>
3644
3645         [Win] Expose missing editing features through WebView interface
3646         https://bugs.webkit.org/show_bug.cgi?id=140773
3647         <rdar://problem/19565421>
3648
3649         Reviewed by Dean Jackson.
3650
3651         Connect the various WebView editing delegate methods to our
3652         test infrastructure. Also prefer _bstr_t to raw BSTR types
3653         to simplify life cycle management.
3654
3655         * DumpRenderTree/win/DumpRenderTree.cpp:
3656         (resetWebViewToConsistentStateBeforeTesting):
3657         * DumpRenderTree/win/EditingDelegate.cpp:
3658         (EditingDelegate::QueryInterface):
3659         (dumpPath):
3660         (dump):
3661         (EditingDelegate::shouldBeginEditingInDOMRange):
3662         (EditingDelegate::shouldEndEditingInDOMRange):
3663         (EditingDelegate::shouldInsertNode):
3664         (EditingDelegate::shouldInsertText):
3665         (EditingDelegate::shouldDeleteDOMRange):
3666         (EditingDelegate::shouldChangeSelectedDOMRange):
3667         (EditingDelegate::shouldApplyStyle):
3668         (EditingDelegate::shouldChangeTypingStyle):
3669         (EditingDelegate::doPlatformCommand):
3670         (EditingDelegate::webViewDidBeginEditing):
3671         (EditingDelegate::webViewDidChange):
3672         (EditingDelegate::webViewDidEndEditing):
3673         (EditingDelegate::webViewDidChangeTypingStyle):
3674         (EditingDelegate::webViewDidChangeSelection):
3675         (EditingDelegate::checkSpellingOfString):
3676         (EditingDelegate::onNotify):
3677         * DumpRenderTree/win/EditingDelegate.h:
3678
3679 2015-01-22  Ryosuke Niwa  <rniwa@webkit.org>
3680
3681         Add a build flag for ES6 class syntax
3682         https://bugs.webkit.org/show_bug.cgi?id=140760
3683
3684         Reviewed by Michael Saboff.
3685
3686         * Scripts/webkitperl/FeatureList.pm:
3687
3688 2015-01-22  Daniel Bates  <dabates@apple.com>
3689
3690         [iOS] run-webkit-tests --ios-sim dies with an error; fails to parse Apple Internal
3691         runtime in simctl output
3692         https://bugs.webkit.org/show_bug.cgi?id=140751
3693
3694         Reviewed by David Kilzer.
3695
3696         Following the fix for <rdar://problem/19444383>, run-webkit-tests --ios-sim dies
3697         with an error because it does not know how to parse the output of the simctl tool
3698         to identify an Apple Internal runtime.
3699
3700         * Scripts/webkitpy/xcode/simulator.py:
3701         (Runtime.__init__): Add parameter is_internal_runtime (defaults to False).
3702         (Runtime.__eq__): Take is_internal_runtime when comparing two Runtime objects for equality.
3703         (Runtime.__repr__): Update printable representation of Runtime object to indicate whether
3704         the runtime is an internal runtime.
3705         (Simulator): Update regular expressions runtime_re and version_re to match an internal runtime.
3706         (Simulator._parse_runtimes): Pass is_internal_runtime to the Runtime constructor with the
3707         appropriate value.
3708         (Simulator._parse_devices): Pass argument is_internal_runtime to Simulator.runtime() so that
3709         it updates the appropriate Runtime object.
3710         (Simulator.runtime): Added optional parameter, is_internal_runtime. Modified to support
3711         looking up a Runtime object for an internal runtime.
3712
3713 2015-01-22  Alexey Proskuryakov  <ap@apple.com>
3714
3715         LeaksViewer doesn't show recent builds if there are less than 10
3716         https://bugs.webkit.org/show_bug.cgi?id=140716
3717
3718         Reviewed by Tim Horton.
3719
3720         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
3721
3722 2015-01-22  Lucas Forschler  <lforschler@apple.com>
3723
3724         Add Apple build slaves.
3725         Fixed text alignment for slave list.
3726
3727         Unreviewed.
3728
3729         * BuildSlaveSupport/build.webkit.org-config/config.json:
3730
3731 2015-01-21  Lucas Forschler  <lforschler@apple.com>
3732
3733         Teach build.webkit.org about bot308 and bot309.
3734
3735         Unreviewed.
3736
3737         * BuildSlaveSupport/build.webkit.org-config/config.json:
3738
3739 2015-01-21  Lucas Forschler  <lforschler@apple.com>
3740
3741         Add two Apple Mavericks slaves.
3742
3743         Unreviewed.
3744
3745         * BuildSlaveSupport/build.webkit.org-config/config.json:
3746
3747 2015-01-21  Daniel Bates  <dabates@apple.com>
3748
3749         Add iOS WebKit1 TestExpectation file
3750         https://bugs.webkit.org/show_bug.cgi?id=140739
3751
3752         Reviewed by David Kilzer.
3753
3754         Teach run-webkit-tests to look for iOS WebKit1-specific test results and
3755         expectations in directory LayoutTests/platform/ios-simulator-wk1.
3756
3757         * Scripts/webkitpy/port/ios.py:
3758         (IOSSimulatorPort.default_baseline_search_path):
3759
3760 2015-01-21  David Kilzer  <ddkilzer@apple.com>
3761
3762         [iOS] Update configure-xcode-for-ios-development to copy missing headers to iphoneos SDK
3763         <http://webkit.org/b/140704>
3764
3765         Reviewed by Daniel Bates.
3766
3767         * Scripts/configure-xcode-for-ios-development:
3768         - Update copyright.
3769         - Remove FIXME addressed by r178709.
3770         - Call copyMissingHeadersToIPhoneOSSDKIfNeeded().
3771         (copyMissingHeadersToIPhoneOSSDKIfNeeded): Add method to copy
3772         missing headers from iphonesimulator SDK to iphoneos SDK.
3773         (sdkDirectory): Add method that returns SDK directory.
3774         (sdkPlatformDirectory): Extract method from
3775         xcodeSDKSpecificationsPath() that returns SDK platform
3776         directory.
3777         (xcodeSDKSpecificationsPath): Update to use
3778         sdkPlatformDirectory().
3779
3780 2015-01-21  Alexey Proskuryakov  <ap@apple.com>
3781
3782         https://build.webkit.org/dashboard/metrics.html fails because of ios-ews
3783         https://bugs.webkit.org/show_bug.cgi?id=140731
3784
3785         Reviewed by Tim Horton.
3786
3787         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
3788         (Analyzer.prototype._analyzeAllBubblesPerformance): Corrected a typo.
3789
3790 2015-01-21  Brent Fulgham  <bfulgham@apple.com>
3791
3792         [Win] eventSender does not support scalePageBy
3793         https://bugs.webkit.org/show_bug.cgi?id=140726
3794         <rdar://problem/19549865>
3795
3796         Reviewed by Dean Jackson.
3797
3798         * DumpRenderTree/win/EventSender.cpp:
3799         (scalePageByCallback): Provide implementation using new WebView method.
3800
3801 2015-01-21  Lucas Forschler  <lforschler@apple.com>
3802
3803         Remove Apple Mountain Lion Build & Test slaves.
3804
3805         Unreviewed.
3806
3807         * BuildSlaveSupport/build.webkit.org-config/config.json:
3808
3809 2015-01-21  Csaba Osztrogonác  <ossy@webkit.org>
3810
3811         Remove ENABLE(INSPECTOR) ifdef guards
3812         https://bugs.webkit.org/show_bug.cgi?id=140668
3813
3814         Reviewed by Darin Adler.
3815
3816         * DumpRenderTree/mac/TestRunnerMac.mm:
3817         (TestRunner::showWebInspector):
3818         (TestRunner::closeWebInspector):
3819         (TestRunner::evaluateInWebInspector):
3820         * Scripts/webkitperl/FeatureList.pm:
3821         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3822         (WTR::TestRunner::showWebInspector):
3823         (WTR::TestRunner::closeWebInspector):
3824         (WTR::TestRunner::evaluateInWebInspector):
3825         * WebKitTestRunner/TestInvocation.cpp:
3826         (WTR::TestInvocation::invoke):
3827
3828 2015-01-20  Alexey Proskuryakov  <ap@apple.com>
3829
3830         Update build.webkit.org/dashboard to match current Mac queues.
3831
3832         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion.png: Removed.
3833         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion@2x.png: Removed.
3834         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: Removed.
3835         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: Removed.
3836         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3837         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3838         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3839         (table.queue-grid tr.platform.mac-os-x-mountain-lion img.logo): Deleted.
3840         (table.queue-grid tr.platform.mac-os-x-lion img.logo): Deleted.
3841
3842 2015-01-20  Lucas Forschler  <lforschler@apple.com>
3843
3844         Update Apple MountainLion Leaks slave to Yosemite
3845         Update Apple MountainLion Release (32-bit) Build slave to Yosemite
3846
3847         Unreviewed.
3848
3849         * BuildSlaveSupport/build.webkit.org-config/config.json:
3850
3851 2015-01-20  Lucas Forschler  <lforschler@apple.com>
3852
3853         Update LeaksViewer from MountainLion to Yosemite
3854
3855         Reviewed by Alexey Proskuryakov.
3856
3857         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
3858         (LeaksViewer._displayURLPrompt):
3859
3860 2015-01-20  Jake Nielsen  <jacob_nielsen@apple.com>
3861
3862         Fix EWS python unit tests and address code comments as per 140476
3863         https://bugs.webkit.org/show_bug.cgi?id=140637
3864
3865         Reviewed by David Kilzer.
3866
3867         * Scripts/webkitpy/port/base.py:
3868         (Port):
3869         (Port.__init__):
3870         Adds DEFAULT_ARCHITECTURE member.
3871         (Port.architecture):
3872         Removes architecture member and instead uses
3873         self.get_option('architecture'). Also removes redundant architecture
3874         method.
3875         (Port.set_architecture):
3876         Adds a setter for the architecture variable to be able to set a flag
3877         upon modification.
3878         (Port.test_configuration):
3879         Uses self.architecture() instead of self._architecture.
3880         * Scripts/webkitpy/port/ios.py:
3881         Overrides DEFAULT_ARCHITECTURE.
3882         (IOSPort):
3883         (IOSPort.determine_full_port_name):
3884         Uses subprocess.check_output instead of Popen. Uses rstrip instead of
3885         strip. Fixes regex to not match arbitrary characters after the
3886         relevent digits are matched.
3887         (IOSPort.__init__):
3888         Removes old _architecture defaulting strategy.
3889         (IOSPort._build_driver_flags):
3890         Uses self.architecture() instead of self._architecture.
3891         (IOSSimulatorPort):
3892         Overrides DEFAULT_ARCHITECTURE.
3893         (IOSSimulatorPort.__init__):
3894         Removes old _architecture defaulting strategy.
3895         * Scripts/webkitpy/port/mac.py:
3896         (MacPort):
3897         Overrides DEFAULT_ARCHITECTURE.
3898         (MacPort.__init__):
3899         Removes old _architecture defaulting strategy.
3900         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3901         (AbstractEarlyWarningSystem.run_command):
3902         Checks the did_override_architecture flag to determine whether to add
3903         the --architecture option.
3904         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3905         Uses ews.architecture rather than trying to discern the correct
3906         architecture using a port object.
3907         (EarlyWarningSystemTest._default_expected_logs):
3908         * Scripts/webkitpy/tool/commands/queues.py:
3909         Removes use of optparse, and removes the import statement.
3910         (AbstractQueue.__init__):
3911         (PatchProcessingQueue.begin_work_queue):
3912
3913 2015-01-20  Sam Weinig  <sam@webkit.org>
3914
3915         Attempt to fix Mountain Lion and EFL tests.
3916
3917         * WebKitTestRunner/TestController.cpp:
3918         (WTR::TestController::initialize):
3919         Disable Process-per-tab and network process on Mountain Lion and EFL.
3920
3921 2015-01-20  Darin Adler  <darin@apple.com>
3922
3923         Remove SVGElementInstanceList, m_instanceUnderMouse, DUMP_INSTANCE_TREE, DUMP_SHADOW_TREE
3924         https://bugs.webkit.org/show_bug.cgi?id=140679
3925
3926         Reviewed by Anders Carlsson.
3927
3928         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
3929         Removed a reference to SVGElementInstanceList.
3930
3931 2015-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
3932
3933         [GTK] WebViewTest should prohibit overriding initializeWebExtensions()
3934         https://bugs.webkit.org/show_bug.cgi?id=140028
3935
3936         Reviewed by Carlos Garcia Campos.
3937
3938         This won't work as expected, since this function is called before the
3939         WebViewTest constructor completes.
3940
3941         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
3942
3943 2015-01-20  David Kilzer  <ddkilzer@apple.com>
3944
3945         configure-xcode-for-ios-development needs to update iPhoneOS SDK
3946         <http://webkit.org/b/140661>
3947
3948         Reviewed by Daniel Bates.
3949
3950         * Scripts/configure-xcode-for-ios-development: Add for() loop to
3951         run createXcodeSpecificationFilesForSDKIfNeeded() for both
3952         "iphoneos" and "iphonesimulator" SDKs.
3953         (createXcodeSpecificationFilesForSDKIfNeeded): Extracted from
3954         the main body of the script.
3955
3956 2015-01-20  Tomas Popela  <tpopela@redhat.com>
3957
3958         [GTK] Add API to set the web view editable into WebKit2 GTK+ API
3959         https://bugs.webkit.org/show_bug.cgi?id=139443
3960
3961         Reviewed by Carlos Garcia Campos.
3962
3963         Create the new test cases for setting the editable property on the web
3964         view and on the contenteditable enabled document. Also rework the
3965         current tests that are expecting that the web view is editable.
3966
3967         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
3968         (loadTestHtml):
3969         (testWebViewEditorCutCopyPasteNonEditable):
3970         (testWebViewEditorCutCopyPasteEditable):
3971         (testWebViewEditorSelectAllNonEditable):
3972         (testWebViewEditorSelectAllEditable):
3973         (runEditorEditableCutTests):
3974         (testWebViewEditorEditableOnNonEditable):
3975         (testWebViewEditorEditableOnContentEditable):
3976         (testWebViewEditorNonEditable):
3977         (beforeAll):
3978         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3979         (WebViewTest::isEditable):
3980         (WebViewTest::setEditable):
3981
3982 2015-01-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3983
3984         [GTK] Add an option to create WebKitWebView snapshots with transparent background
3985         https://bugs.webkit.org/show_bug.cgi?id=140617
3986
3987         Reviewed by Gustavo Noronha Silva.
3988
3989         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3990         (testWebViewSnapshot): Check that the same snapshot with
3991         transparent background is different than the default one filled
3992         with white.
3993
3994 2015-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3995
3996         [GTK] Add API to change the WebKitWebView background color
3997         https://bugs.webkit.org/show_bug.cgi?id=140610
3998
3999         Reviewed by Gustavo Noronha Silva.
4000
4001         Add --bg-color command line option to MiniBrowser to be able to
4002         manually test the API passing any RGBA color to MiniBrowser.
4003         Also add a simple unit test to check that getting and setting
4004         colors from the API point of view.
4005
4006         * MiniBrowser/gtk/BrowserWindow.c:
4007         (browser_window_set_background_color):
4008         * MiniBrowser/gtk/BrowserWindow.h:
4009         * MiniBrowser/gtk/main.c:
4010         (createBrowserWindow):
4011         (parseBackgroundColor):
4012         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
4013         (testWebViewBackgroundColor):
4014         (beforeAll):
4015
4016 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
4017
4018         [Win] Layout Test fast/xmlhttprequest/xmlhttprequest-no-file-access.html is failing
4019         https://bugs.webkit.org/show_bug.cgi?id=140665
4020
4021         Reviewed by Brian Burg.
4022
4023         * DumpRenderTree/win/UIDelegate.cpp:
4024         (UIDelegate::webViewAddMessageToConsole): Correct string search and concatenation to
4025         match expected test output.
4026
4027 2015-01-19  Benjamin Poulain  <bpoulain@apple.com>
4028
4029         Remove the support for custom suffixes on ChangeLog
4030         https://bugs.webkit.org/show_bug.cgi?id=140648
4031
4032         Reviewed by David Kilzer.
4033
4034         Custom suffixes were used for the iOS branch of WebKit.
4035         Now that everything is opensource, there is no need for it.
4036
4037         * Scripts/VCSUtils.pm:
4038         (changeLogSuffix): Deleted.
4039         (changeLogFileName): Deleted.
4040         * Scripts/commit-log-editor:
4041         * Scripts/prepare-ChangeLog:
4042         (getLatestChangeLogs):
4043         (generateNewChangeLogs):
4044         (generateFileList):
4045         * Scripts/resolve-ChangeLogs:
4046         (findChangeLog):
4047
4048 2015-01-19  Timothy Horton  <timothy_horton@apple.com>
4049
4050         Adjust naming of action menu SPI
4051         https://bugs.webkit.org/show_bug.cgi?id=140644
4052         <rdar://problem/19448129>
4053
4054         Reviewed by Brian Weinstein.
4055
4056         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
4057         (-[ActionMenusTestWKView runMenuSequenceAtPoint:preDidCloseMenuHandler:]):
4058         (TestWebKitAPI::TEST):
4059
4060 2015-01-19  Michael Catanzaro  <mcatanzaro@igalia.com>
4061
4062         [GTK] Generate the make dist manifest from a CMake template file
4063         https://bugs.webkit.org/show_bug.cgi?id=139387
4064
4065         Reviewed by Martin Robinson.
4066
4067         Remove the code that performs variable substitution on manifest.txt.
4068         Replace the custom variables used in that file with CMake variables.
4069
4070         * gtk/make-dist.py:
4071         (Manifest.add_directory):
4072         (Manifest.get_full_source_path):
4073         (Manifest.process_line):
4074         (Manifest.resolve_variables): Deleted.
4075         (Manifest.get_full_tarball_path): Deleted.
4076         * gtk/manifest.txt.in: Renamed from Tools/gtk/manifest.txt.
4077
4078 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
4079
4080         [Win] Correct merge error in last commit.
4081
4082         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
4083         (findAccessibleObjectById): Undo accidental paste made during landing.
4084
4085 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
4086
4087         [Win] Periodic failure in DumpRenderTree related to WebActionPropertyBag::Read
4088         https://bugs.webkit.org/show_bug.cgi?id=139906
4089
4090         Reviewed by Dean Jackson.
4091
4092         WebKit on Windows was creating uninitialized VARIANT structures, then attempting
4093         to use them. This patch fixes that.
4094
4095         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
4096         (findAccessibleObjectById):
4097         (AccessibilityController::focusedElement):
4098         (logEventProc):
4099         (notificationListenerProc):
4100         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
4101         (AccessibilityUIElement::getChildAtIndex):
4102         (AccessibilityUIElement::titleUIElement):
4103         (self):
4104         (AccessibilityUIElement::role):
4105         (AccessibilityUIElement::valueDescription):
4106         (accessibilityState):
4107         (AccessibilityUIElement::isChecked):
4108         * DumpRenderTree/win/DumpRenderTree.cpp:
4109         (dumpFrameScrollPosition):
4110         (dumpFramesAsText):
4111         * DumpRenderTree/win/PolicyDelegate.cpp:
4112         (PolicyDelegate::decidePolicyForNavigationAction):
4113         * DumpRenderTree/win/UIDelegate.cpp:
4114         (UIDelegate::exceededDatabaseQuota):
4115         * WinLauncher/Common.cpp:
4116         (setWindowText):
4117
4118 2015-01-19  Dean Jackson  <dino@apple.com>
4119
4120         Add "override" to fix the build with newer clangs.
4121
4122         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
4123         (TestWebKitAPI::CalculationDeletionTestNode::operator==):
4124
4125 2015-01-19  David Kilzer  <ddkilzer@apple.com>
4126
4127         [iOS] Do not hard-code iphoneos.internal SDK in buildXCodeProject()
4128         <http://webkit.org/b/140623>
4129
4130         Reviewed by Daniel Bates.
4131
4132         * Scripts/build-webkit: Update help for --device switch.
4133         * Scripts/webkitdirs.pm:
4134         (determineXcodeSDK): When passing --device, prefer the internal
4135         iOS SDK if it exists, else fall back to the external iOS SDK.
4136         (buildXCodeProject): Use xcodeSDK() as -sdk argument for
4137         xcodebuild instead of trying to sanitize values.
4138
4139 2015-01-19  Alexey Proskuryakov  <ap@apple.com>
4140
4141         "Unknown option: sharedworkerglobalscopeconstructorsfile" when running bindings tests.
4142         https://bugs.webkit.org/show_bug.cgi?id=140606
4143
4144         Reviewed by Csaba Osztrogonác.
4145
4146         * Scripts/webkitpy/bindings/main.py:
4147         (BindingsTests.generate_supplemental_dependency):
4148         (BindingsTests.main):
4149
4150 2015-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
4151
4152         [GTK] [WK2] TestWebKitWebView snapshot fails
4153         https://bugs.webkit.org/show_bug.cgi?id=120404
4154
4155         Reviewed by Žan Doberšek.
4156
4157         Rework the test to make sure the snapshot is always created at the
4158         desired size.
4159
4160         * Scripts/run-gtk-tests:
4161         (TestRunner): Unskip /webkit2/WebKitWebView/snapshot.
4162         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
4163         (testWebViewSnapshot): Use a fixed size for the document, and
4164         disable scrollbars to make sure the visible area is always the
4165         WebView size.
4166         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
4167         (WebViewTest::showInWindowAndWaitUntilMapped): Add optional width
4168         and height parameters to create the window with a given size.
4169         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
4170
4171 2015-01-18  David Kilzer  <ddkilzer@apple.com>
4172
4173         iOS EWS queue name should be consistent
4174         <http://webkit.org/b/140585>
4175
4176         Reviewed by Daniel Bates.
4177
4178         * Scripts/webkitpy/common/config/ews.json: Rename 'ios-device'
4179         to 'ios'.
4180         * Scripts/webkitpy/common/config/ports.py: Ditto.
4181         (DeprecatedPort.port):
4182         (IOSPort):
4183         * Scripts/webkitpy/port/ios.py: Ditto.
4184         (IOSPort):
4185
4186         * Scripts/webkitpy/port/factory.py:
4187         (PortFactory): Re-order PORT_CLASSES so ios.IOSSimulatorPort
4188         appears before ios.IOSPort.  If this is not done,
4189         `run-webkit-tests --ios-simulator` will get the wrong Port class
4190         (IOSPort instead of IOSSimulatorPort) due to the way that
4191         PortFactory.get() uses prefix matching of <Port>.port_name to
4192         find the correct class to use.
4193
4194 2015-01-18  Alexey Proskuryakov  <ap@apple.com>
4195
4196         build.webkit.org/dashboard: OS X EWS is now on Mavericks
4197         https://bugs.webkit.org/show_bug.cgi?id=140595
4198
4199         Reviewed by Csaba Osztrogonác.
4200
4201         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4202         (BubbleQueueServer):
4203
4204 2015-01-17  David Kilzer  <ddkilzer@apple.com>
4205
4206         Attempt to fix webkitpy tests on Mountain Lion, Mavericks bots
4207
4208         * Scripts/webkitpy/port/ios.py:
4209         (IOSPort): Add 'ios-device-7' to VERSION_FALLBACK_ORDER so that
4210         test-webkitpy doesn't fail since iOS 7.x SDKs are installed on
4211         the Mountain Lion and Mavericks bots.
4212
4213 2015-01-17  David Kilzer  <ddkilzer@apple.com>
4214
4215         Attempt to fix webkitpy tests on GTK Linux ports
4216
4217         * Scripts/webkitpy/port/ios.py:
4218         (IOSPort.determine_full_port_name): Set a sensible default if
4219         not running on a Mac platform or if no iOS SDK is installed.
4220
4221 2015-01-17  Jake Nielsen  <jacob_nielsen@apple.com>
4222
4223         Create iOS-EWS client queue
4224         https://bugs.webkit.org/show_bug.cgi?id=140476
4225
4226         Reviewed by Alexey Proskuryakov.
4227
4228         * EWSTools/start-queue-mac.sh:
4229         Adds call to configure-xcode-for-ios-development for iOS EWS.
4230         * Scripts/webkitpy/common/config/ews.json:
4231         Adds the iOS EWS config entry.
4232         * Scripts/webkitpy/common/config/ports.py:
4233         (DeprecatedPort.port):
4234         Adds IOSPort to the port map.
4235         (IOSPort):
4236         (IOSPort.build_webkit_command):
4237         Adds --sdk=iphoneos to the webkit build command.
4238         * Scripts/webkitpy/port/base.py:
4239         (Port.architecture):
4240         Adds an accessor for the architecture member variable.
4241         * Scripts/webkitpy/port/factory.py:
4242         (PortFactory):
4243         Adds IOSPort to the port class list.
4244         * Scripts/webkitpy/port/ios.py:
4245         Adds the IOSPort to encapsulate iOS-specific things.
4246         (IOSPort):
4247         (IOSPort.determine_full_port_name):
4248         (IOSPort.__init__):
4249         (IOSPort._build_driver_flags):
4250         (IOSPort.operating_system):
4251         * Scripts/webkitpy/tool/commands/download_unittest.py:
4252         Adds the archetecture option to the mock options.
4253         (DownloadCommandsTest._default_options):
4254         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4255         Appends the archetecture option into calls to webkit-patch.
4256         (AbstractEarlyWarningSystem.review_patch):
4257         (AbstractEarlyWarningSystem.run_command):
4258         (AbstractEarlyWarningSystem.load_ews_classes):
4259         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
4260         Adds logic to soothe the unittest now that --architecture is being
4261         thrown around everywhere.
4262         (EarlyWarningSystemTest._default_expected_logs):
4263         * Scripts/webkitpy/tool/commands/queues.py:
4264         Adds glue code to ferry the --architecture option around.
4265         (AbstractQueue.__init__):
4266         (PatchProcessingQueue.begin_work_queue):
4267         * Scripts/webkitpy/tool/steps/abstractstep.py:
4268         Adds the archetecture option to all AbstractSteps so that
4269         EarlyWarningSystem doesn't start shoving --architecture into
4270         unsuspecting commands.
4271         (AbstractStep.options):
4272         * Scripts/webkitpy/tool/steps/build.py:
4273         Translates the --architecture option into an ARCHS= format to pass to
4274         build-webkit.
4275         (Build.build):
4276         * Scripts/webkitpy/tool/steps/options.py:
4277         Adds a definition for the --architecture option.
4278         (Options):
4279
4280 2015-01-16  Sam Weinig  <sam@webkit.org>
4281
4282         Add a basic configuration object for WKView
4283         https://bugs.webkit.org/show_bug.cgi?id=140559
4284
4285         Reviewed by Anders Carlsson.
4286
4287         Add tests for WKPageConfigurationRef.
4288
4289         * TestWebKitAPI/PlatformWebView.h:
4290         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4291         * TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp: Added.
4292         (TestWebKitAPI::TEST):
4293         (TestWebKitAPI::didFinishLoadForFrame):
4294         (TestWebKitAPI::setPageLoaderClient):
4295         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
4296         (TestWebKitAPI::PlatformWebView::initialize):
4297         (TestWebKitAPI::PlatformWebView::PlatformWebView):
4298
4299 2015-01-16  Myles C. Maxfield  <mmaxfield@apple.com>
4300
4301         WeakPtr functions crash when created with default constructor
4302         https://bugs.webkit.org/show_bug.cgi?id=140479
4303
4304         Reviewed by Andreas Kling.
4305
4306         Add WeakPtr API tests.
4307
4308         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4309      &nbs