Hard to figure out how to run a single test with run-api-tests
[WebKit-https.git] / Tools / ChangeLog
1 2014-05-02  Brian J. Burg  <burg@cs.washington.edu>
2
3         Hard to figure out how to run a single test with run-api-tests
4         https://bugs.webkit.org/show_bug.cgi?id=116332
5
6         Reviewed by Alexey Proskuryakov.
7
8         * Scripts/run-api-tests: add two examples to the help message.
9
10 2014-05-02  Simon Fraser  <simon.fraser@apple.com>
11
12         Fix several memory leaks found by code inspection
13         https://bugs.webkit.org/show_bug.cgi?id=132472
14
15         Reviewed by Geoffrey Garen.
16         
17         Fix memory leaks.
18
19         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
20         (TestWebKitAPI::TEST):
21         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
22         (WTR::InjectedBundlePage::willSendRequestForFrame):
23         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
24         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
25
26 2014-05-02  Filip Pizlo  <fpizlo@apple.com>
27
28         DFGAbstractInterpreter should not claim Int52 arithmetic creates Int52s
29         https://bugs.webkit.org/show_bug.cgi?id=132446
30
31         Reviewed by Mark Hahnenberg.
32         
33         Test the FTL by default now that it's enabled by default.
34
35         * Scripts/run-javascriptcore-tests:
36
37 2014-05-01  Ryuan Choi  <ryuan.choi@samsung.com>
38
39         [EFL][WK1] Drop ewk_view_setting_tiled_backingstore APIs
40         https://bugs.webkit.org/show_bug.cgi?id=132240
41
42         Reviewed by Anders Carlsson.
43
44         Removed ewk_view_setting_tiled_backingstore related code.
45
46         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
47         (DumpRenderTreeChrome::createView):
48         (shouldUseTiledBackingStore): Deleted.
49         * EWebLauncher/main.c:
50         (windowCreate):
51         (parseUserArguments):
52
53 2014-05-01  Anders Carlsson  <andersca@apple.com>
54
55         window.testRunner.keepWebHistory() should update the UI process state
56         https://bugs.webkit.org/show_bug.cgi?id=132440
57
58         Reviewed by Dan Bernstein.
59
60         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
61         (WTR::InjectedBundle::postSetAddsVisitedLinks):
62         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
63         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
64         (WTR::TestRunner::keepWebHistory):
65         * WebKitTestRunner/TestInvocation.cpp:
66         (WTR::TestInvocation::invoke):
67         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
68
69 2014-05-01  David Kilzer  <ddkilzer@apple.com>
70
71         Really remove ENABLE_PLUGIN_PROXY_FOR_VIDEO
72         <http://webkit.org/b/132432>
73
74         Reviewed by Tim Horton.
75
76         * Scripts/webkitperl/FeatureList.pm: Remove support for
77         --plugin-proxy-for-video switch.
78
79 2014-04-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
80
81         Kernel sysctl interface hw.activecpu don't exists on Linux.
82         https://bugs.webkit.org/show_bug.cgi?id=132286
83
84         Reviewed by Filip Pizlo.
85
86         * Scripts/run-jsc-stress-tests: Redirect stderr to null when
87         calling sysctl over hw.activecpu
88
89 2014-04-30  Anders Carlsson  <andersca@apple.com>
90
91         Move the legacy WebKit API into WebKitLegacy.framework and move it inside WebKit.framework
92         https://bugs.webkit.org/show_bug.cgi?id=132399
93         <rdar://problem/15920046>
94
95         Reviewed by Dan Bernstein.
96
97         * Scripts/check-for-webkit-framework-include-consistency:
98         Allos WAK headers in WebKitLegacy as well as WebKit.
99
100         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
101         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
102         Update header imports.
103
104 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
105
106         [iOS WK2] Add test URL to crash reports for the UI process, clean up project
107         https://bugs.webkit.org/show_bug.cgi?id=131954
108
109         Reviewed by Darin Adler.
110         
111         WebKitTestRunner was adding application-specific information to crash reports
112         to log the test path, but only in the web process. Fix it to also do this
113         for the UI process, for both iOS and OS X.
114         
115         Moved InjectedBundlePageMac.mm to InjectedBundlePageCocoa.mm and compile it for
116         both iOS and OS X.
117         
118         Factored crash reprorter-related code into CrashReporterInfo, and call it from
119         a new TestController::platformWillRunTest() function on Mac and iOS.
120         
121         Also remove Xcode-added unit test junk from the project.
122
123         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
124         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
125         * WebKitTestRunner/TestController.cpp:
126         (WTR::TestController::runTest):
127         * WebKitTestRunner/TestController.h:
128         * WebKitTestRunner/TestInvocation.cpp:
129         (WTR::TestInvocation::url):
130         * WebKitTestRunner/TestInvocation.h:
131         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
132         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Removed.
133         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Removed.
134         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Removed.
135         * WebKitTestRunner/cocoa/CrashReporterInfo.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
136         * WebKitTestRunner/cocoa/CrashReporterInfo.mm: Renamed from Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm.
137         (WTR::testPathFromURL):
138         (WTR::setCrashReportApplicationSpecificInformationToURL):
139         * WebKitTestRunner/efl/TestControllerEfl.cpp:
140         (WTR::TestController::platformWillRunTest):
141         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
142         (WTR::TestController::platformWillRunTest):
143         * WebKitTestRunner/ios/TestControllerIOS.mm:
144         (WTR::TestController::platformWillRunTest):
145         (WTR::TestController::setHidden):
146         * WebKitTestRunner/mac/TestControllerMac.mm:
147         (WTR::TestController::platformWillRunTest):
148
149 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
150
151         Fix DRT assertion about mock scrollbars, which doesn't apply to iOS.
152
153         Reviewed by Tim Horton.
154
155         * DumpRenderTree/mac/DumpRenderTree.mm:
156         (resetWebPreferencesToConsistentValues):
157         (prepareConsistentTestingEnvironment):
158
159 2014-04-30  Anders Carlsson  <andersca@apple.com>
160
161         check-for-inappropriate-macros-in-external-headers should get the product name, not the project name
162         https://bugs.webkit.org/show_bug.cgi?id=132397
163
164         Reviewed by Dan Bernstein.
165
166         * Scripts/check-for-inappropriate-macros-in-external-headers:
167
168 2014-04-29  Martin Robinson  <mrobinson@igalia.com>
169
170         [GTK] Make it easier to run CMake for downstreams
171         https://bugs.webkit.org/show_bug.cgi?id=132370
172
173         Reviewed by Carlos Garcia Campos.
174
175         * Scripts/webkitdirs.pm:
176         (generateBuildSystemFromCMakeProject): Pass -DDEVELOPER_MODE when building
177         the GTK+ port.
178
179 2014-04-29  Stephanie Lewis  <slewis@apple.com>
180
181         <rdar://problem/16765765> Use JSON::PP in perl scripts instead of JSON.
182         
183         Rubber stamped by Jessie Berlin.
184
185         JSON.pm was removed from our tools setup.
186
187         * Scripts/generate-coverage-data:
188
189 2014-04-29  Filip Pizlo  <fpizlo@apple.com>
190
191         Use LLVM as a backend for the fourth-tier DFG JIT (a.k.a. the FTL JIT)
192         https://bugs.webkit.org/show_bug.cgi?id=112840
193
194         Rubber stamped by Geoffrey Garen.
195
196         * Scripts/build-jsc: Enable it on Mac.
197         * Scripts/build-webkit: Enable it on Mac.
198         * Scripts/export-llvm-build: Make it slightly easier to export the build if you've done a "make install".
199
200 2014-04-28  Sam Weinig  <sam@webkit.org>
201
202         REGRESSION (r167751): svn-create-patch is very slow
203         https://bugs.webkit.org/show_bug.cgi?id=132300
204
205         Reviewed by Alexey Proskuryakov.
206
207         * Scripts/svn-create-patch:
208         Change default behavior of svn-create-patch to no longer run the style checker. It can still be run
209         by calling `svn-create-patch --style`.
210
211 2014-04-29  Enrique Ocaña González  <eocanha@igalia.com>
212
213         Generate Eclipse project + ninja build for GTK+ if Eclipse in available in the PATH
214         https://bugs.webkit.org/show_bug.cgi?id=132190
215
216         Reviewed by Gustavo Noronha Silva.
217
218         * Scripts/webkitdirs.pm:
219         (canUseEclipse): Test if Eclipse is in the path. This is the same method used to test
220             if ninja is in the path.
221         (generateBuildSystemFromCMakeProject): Use the eclipse generator if possible, fallback
222             to the previous ninja generator if not.
223
224 2014-04-29  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
225
226         check-webkit-style should understand --git-index
227         https://bugs.webkit.org/show_bug.cgi?id=125364
228
229         Reviewed by Csaba Osztrogonác.
230
231         * Scripts/webkitpy/common/checkout/scm/git.py:
232         (Git.create_patch): The command now supports the --cached option.
233         * Scripts/webkitpy/style/main.py:
234         (CheckWebKitStyle.main): Passing the --git-index option.
235         * Scripts/webkitpy/style/optparser.py:
236         (CommandOptionValues.__init__): The git-index option is switched off by default.
237         (CommandOptionValues.__eq__): Equality check for the new option.
238         (ArgumentParser._create_option_parser):Adding the --git-index option
239         (ArgumentParser.parse):
240         * Scripts/webkitpy/style/optparser_unittest.py: New tests for the --git-index option
241         (CommandOptionValuesTest.test_init): 
242         (CommandOptionValuesTest.test_eq):
243
244 2014-04-28  Michael Saboff  <msaboff@apple.com>
245
246         Crash in platform/mac/accessibility/table-visible-rows.html
247         https://bugs.webkit.org/show_bug.cgi?id=132146
248
249         Reviewed by Filip Pizlo.
250
251         Instead of creating a local JSValueRef array on the stack and passing that to
252         JSObjectMakeArray(), changed to create an empty JSArray and then populate the
253         values using the JSObjectSetPropertyAtIndex() API.
254
255         * DumpRenderTree/AccessibilityUIElement.cpp:
256         (elementsForRangeCallback):
257         (convertElementsToObjectArray):
258         * DumpRenderTree/mac/TestRunnerMac.mm:
259         (originsArrayToJS):
260         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
261         (WTR::EventSendingController::contextClick):
262         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
263         (WTR::stringArrayToJS):
264         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
265         (WTR::convertElementsToObjectArray):
266
267 2014-04-28  Filip Pizlo  <fpizlo@apple.com>
268
269         Make sure that the coverage of our tests doesn't change much if we change the thresholds now and in the future, but making
270         "no-cjit" runs force the old-school threshold.
271
272         Rubber stamped by Mark Hahnenberg.
273
274         * Scripts/run-jsc-stress-tests:
275
276 2014-04-28  Carlos Alberto Lopez Perez  <clopez@igalia.com>
277
278         [GTK] install-dependencies should also install ruby-json and ruby-highline
279         https://bugs.webkit.org/show_bug.cgi?id=132292
280
281         Reviewed by Philippe Normand.
282
283         * gtk/install-dependencies: Install ruby json and highline packages.
284
285 2014-04-27  Joonghun Park  <jh718.park@samsung.com>
286
287         [EFL] Remove indexedDB's dependency on leveldb and disable indexedDB
288         https://bugs.webkit.org/show_bug.cgi?id=132176
289
290         Reviewed by Gyuyoung Kim.
291
292         EFL port will use sqlite to support indexedDB. So, this patch removes levelDB dependency
293         and turn off indexedDB feature until the sqlite implementation is introduced.
294
295         * Scripts/webkitperl/FeatureList.pm:
296
297 2014-04-25  James Craig  <jcraig@apple.com>
298
299         Set prepare-Changelog flag so that it no longer runs check-webkit-style by default
300         https://bugs.webkit.org/show_bug.cgi?id=132209
301
302         Reviewed by Daniel Bates.
303
304         Set default to --no-style to avoid additional spew from false positives in check-webkit-style.
305         Run check-webkit-style before generating changelogs to avoid additional spurious errors.
306
307         * Scripts/prepare-ChangeLog:
308         (main): 
309
310 2014-04-25  Michael Saboff  <msaboff@apple.com>
311
312         Crash in platform/mac/accessibility/table-visible-rows.html
313         https://bugs.webkit.org/show_bug.cgi?id=132146
314
315         Reviewed by Mark Lam.
316
317         Changed to use a local JSValueRef array temporary instead of a
318         std::make_unique<JSValueRef[]> when making an array of JSValues so that the temporary
319         JSValues are visited during garbage collection when the stack is scanned.  Otherwise,
320         the temporary values could be collected.
321
322         * DumpRenderTree/AccessibilityUIElement.cpp:
323         (convertElementsToObjectArray):
324         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
325         (WTR::EventSendingController::contextClick):
326         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
327         (WTR::convertElementsToObjectArray):
328
329 2014-04-24  Eduardo Lima Mitev  <elima@igalia.com>
330
331         Unreviewed GTK gardening
332
333         * Scripts/run-gtk-tests: Skips one flaky accesibility test in WK2API suite
334         (TestRunner):
335
336 2014-04-24  László Langó  <llango.u-szeged@partner.samsung.com>
337
338         prepare-ChangeLog reports as deleted methods that has not been removed.
339         https://bugs.webkit.org/show_bug.cgi?id=131733
340
341         Reviewed by Ryosuke Niwa.
342
343         * Scripts/prepare-ChangeLog:
344         (originalFile): Set merge base to origin/master by default.
345
346 2014-04-23  James Craig  <jcraig@apple.com>
347
348         prepare-Changelog and svn-create-patch should optionally run check-webkit-style.
349         https://bugs.webkit.org/show_bug.cgi?id=131115
350
351         Reviewed by Daniel Bates.
352
353         Added [--[no-]style] param to run check-webkit-style as part of prepare-Changelog and svn-create-patch.
354
355         * Scripts/commit-log-editor: Added --no-style.
356         * Scripts/prepare-ChangeLog: Primary patch.
357         (main): Primary patch.
358         (createPatchCommand): Added --no-style.
359         * Scripts/svn-create-patch: Primary patch.
360         * Scripts/webkit-tools-completion.sh: Added --style and --no-style.
361         * Scripts/webkitpy/common/checkout/scm/svn.py: Added --no-style.
362         (SVN.create_patch): Added --no-style.
363
364 2014-04-23  Anders Carlsson  <andersca@apple.com>
365
366         Try to fix iOS build.
367
368         * DumpRenderTree/mac/DumpRenderTree.mm:
369
370 2014-04-23  Alexey Proskuryakov  <ap@apple.com>
371
372         Eliminate internals.setMockScrollbarsEnabled()
373         https://bugs.webkit.org/show_bug.cgi?id=132085
374
375         Reviewed by Tim Horton.
376
377         * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues):
378         No need to reset the preference, there is no way it can change.
379
380 2014-04-23  James Craig  <jcraig@apple.com>
381
382         Unreviewed. Moving myself from Contributors to Committers list.
383
384         * Scripts/webkitpy/common/config/contributors.json:
385
386 2014-04-23  Tim Horton  <timothy_horton@apple.com>
387
388         Mock scrollbars don't always work in DumpRenderTree
389         https://bugs.webkit.org/show_bug.cgi?id=132082
390
391         Reviewed by Alexey Proskuryakov.
392
393         * DumpRenderTree/mac/DumpRenderTree.mm:
394         (prepareConsistentTestingEnvironment):
395         Set the mock scrollbar setting before creating the WebView, as this setting
396         cannot be dynamically changed, so any scrollbars that are created during
397         WebView initialization and are not replaced before snapshotting will end
398         up being platform scrollbars instead of mock ones.
399         WebKitTestRunner already sets this preference before creating WKViews,
400         so we're just matching its behavior.
401
402 2014-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
403
404         [GTK] ShadowRoot API was removed in r164131
405         https://bugs.webkit.org/show_bug.cgi?id=132059
406
407         Reviewed by Gustavo Noronha Silva.
408
409         Add WebKitDOMShadowRoot to the list of deleted classes to generate
410         the API docs.
411
412         * gtk/webkitdom.py:
413         (WebKitDOMDocGenerator):
414
415 2014-04-23  Lorenzo Tilve  <ltilve@igalia.com>
416
417         [GTK] run-webkit-tests script is failing to invoke run-launcher
418         https://bugs.webkit.org/show_bug.cgi?id=132051
419
420         Reviewed by Philippe Normand.
421
422         After the WK1 support was dropped, if run-webkit-tests is executed
423         without --no-show-results parameter, the launcher is being called
424         using a -2 parameter that is it causing the run-launcher to break.
425
426         * Scripts/webkitpy/port/gtk.py:
427         (GtkPort.show_results_html_file):
428
429 2014-04-22  Tim Horton  <timothy_horton@apple.com>
430
431         DumpRenderTree generates black snapshots on some platforms
432         https://bugs.webkit.org/show_bug.cgi?id=132029
433         <rdar://problem/16679363>
434
435         Reviewed by Simon Fraser.
436
437         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
438         (createBitmapContextFromWebView):
439         DRT checks with the WebView to determine whether it can use the window's
440         backing store directly or (because of compositing) needs to take a WindowServer
441         snapshot. However, on some platforms and in some situations, the window can
442         be layer backed without the WebView necessarily currently being composited.
443         We should check with the window in addition to the WebView before going
444         ahead and using its backing store.
445
446 2014-04-22  Tim Horton  <timothy_horton@apple.com>
447
448         DumpRenderTree generates white snapshots on some platforms
449         https://bugs.webkit.org/show_bug.cgi?id=132026
450         <rdar://problem/16679363>
451
452         Reviewed by Simon Fraser.
453
454         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
455         Link DRT against QuartzCore.
456
457         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
458         (createBitmapContextFromWebView):
459         Force CoreAnimation to synchronously update layers in a more explicit
460         way that doesn't depend on AppKit behavior. This is very similar to what
461         WebKitTestRunner does (indirectly) during its force repaint.
462
463 2014-04-22  Brent Fulgham  <bfulgham@apple.com>
464
465         [Win] Support Python 2.7 in Cygwin
466         https://bugs.webkit.org/show_bug.cgi?id=132023
467
468         Reviewed by Michael Saboff.
469
470         * Scripts/webkitdirs.pm:
471         (checkInstalledTools): Remove check for Python 2.7, since
472         it now works properly.
473
474 2014-04-22  Filip Pizlo  <fpizlo@apple.com>
475
476         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
477         https://bugs.webkit.org/show_bug.cgi?id=130867
478         <rdar://problem/16432456> 
479
480         Reviewed by Mark Hahnenberg.
481
482         * Scripts/build-webkit:
483         * Scripts/copy-webkitlibraries-to-product-directory:
484
485 2014-04-22  Gustavo Noronha Silva  <gns@gnome.org>
486
487         [GTK] Fails to build documentation when output is redirected
488         https://bugs.webkit.org/show_bug.cgi?id=131178
489
490         Reviewed by Martin Robinson.
491
492         * gtk/generate-gtkdoc: set the output for stdout and stderr to UTF-8
493         explicitly to avoid encoding issues when they are redirected.
494
495 2014-04-22  ChangSeok Oh  <changseok.oh@collabora.com>
496
497         [GTK] YCM choose a newer compile_commands.json in between Release or Debug
498         https://bugs.webkit.org/show_bug.cgi?id=131911
499
500         Reviewed by Martin Robinson.
501
502         common.get_build_path returns release path even though Debug configuration
503         is newer than Release. So YouCompleteMe is used to refer old build setup inadvertently.
504
505         * gtk/ycm_extra_conf.py:
506         (get_build_path): Compare modified time of Release and Debug. And return a recent modified path.
507         (FlagsForFile):
508
509 2014-04-21  Brent Fulgham  <bfulgham@apple.com>
510
511         Unreviewed build fix.
512
513         * DumpRenderTree/mac/EventSendingController.mm:
514         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
515         Correct a typo that prevented tests from working properly.
516
517 2014-04-21  Martin Robinson  <mrobinson@igalia.com>
518
519         [GTK] Should have the ability to output composited contents during layout testing
520         https://bugs.webkit.org/show_bug.cgi?id=131864
521
522         Reviewed by Philippe Normand.
523
524         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
525         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Add a path that paints the widget contents
526         to an image surface. We run the main loop a bit to match the implementation from WebKit1 and EFL.
527         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
528         (WTR::PlatformWebView::windowSnapshotImage): Use the new UI-process path on GTK+.
529
530 2014-04-21  Sam Weinig  <sam@webkit.org>
531
532         Attempt to fix the tests.
533
534         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
535         (-[DidFailProvisionalNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
536         Add policy handler to override the new default of denying loads that NSURLConnection cannot handle.
537
538 2014-04-21  Filip Pizlo  <fpizlo@apple.com>
539
540         Unreviewed test gardening, make no-eager runs run everything except eager (as opposed to
541         being the same as a "quick run", which is meant for genuinely slow tests).
542
543         * Scripts/run-jsc-stress-tests:
544
545 2014-04-21  Darin Adler  <darin@apple.com>
546
547         Add HashSet::takeAny
548         https://bugs.webkit.org/show_bug.cgi?id=131928
549
550         Reviewed by Benjamin Poulain.
551
552         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Added a test for takeAny.
553
554 2014-04-20  Dan Bernstein  <mitz@apple.com>
555
556         Fixed a test timing out after r167572.
557
558         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
559         (-[NavigationDelegate webView:didFinishNavigation:]): Renamed from
560         -webView:didFinishLoadingNavigation:.
561
562 2014-04-20  Commit Queue  <commit-queue@webkit.org>
563
564         Unreviewed, rolling out r167510.
565         https://bugs.webkit.org/show_bug.cgi?id=131915
566
567         broke GTK Debug bot (Requested by philn on #webkit).
568
569         Reverted changeset:
570
571         "[GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force
572         it when running layout tests"
573         https://bugs.webkit.org/show_bug.cgi?id=131472
574         http://trac.webkit.org/changeset/167510
575
576 2014-04-18  Martin Robinson  <mrobinson@igalia.com>
577
578         [GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
579         https://bugs.webkit.org/show_bug.cgi?id=131472
580
581         Reviewed by Philippe Normand.
582
583         * Scripts/webkitpy/port/gtk.py:
584         (GtkPort.setup_environ_for_server): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
585         when running WebKitTestRunner with run-webkit-tests.
586         * gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not
587         installed.
588         * gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows
589         how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
590         calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
591         deal.
592
593 2014-04-18  Alexey Proskuryakov  <ap@apple.com>
594
595         DownloadDecideDestinationCrash API test uses an incorrect value for path
596         https://bugs.webkit.org/show_bug.cgi?id=131845
597         <rdar://problem/15925560>
598
599         Reviewed by Enrica Casucci.
600
601         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
602         (TestWebKitAPI::decideDestinationWithSuggestedFilename):
603
604 2014-04-17  Alexey Proskuryakov  <ap@apple.com>
605
606         [Mac] AttributedStringTest API tests fail with async text input
607         https://bugs.webkit.org/show_bug.cgi?id=131833
608
609         Reviewed by Enrica Casucci.
610
611         Don't run sync NSTextInputClient tests where we don't implement these calls.
612
613         * TestWebKitAPI/Tests/mac/AttributedString.mm:
614         (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
615         (TestWebKitAPI::AttributedStringTest_CustomFont::runSyncTest):
616         (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
617         (TestWebKitAPI::AttributedStringTest_Strikethrough::runSyncTest):
618         (TestWebKitAPI::AttributedStringTest_CustomFont::runTest): Deleted.
619         (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest): Deleted.
620
621 2014-04-18  Philippe Normand  <pnormand@igalia.com>
622
623         Remove NETWORK_INFO support
624         https://bugs.webkit.org/show_bug.cgi?id=131841
625
626         Reviewed by Gyuyoung Kim.
627
628         * Scripts/webkitperl/FeatureList.pm:
629
630 2014-04-17  ChangSeok Oh  <changseok.oh@collabora.com>
631
632         [GTK] YouCompleteMe doesn't work for cmake build system.
633         https://bugs.webkit.org/show_bug.cgi?id=131591
634
635         Reviewed by Martin Robinson.
636
637         Add cmake build system support for YouCompleteMe. It should work regardless of
638         using make or ninja. In addition, autotools related code is removed since it's
639         not used anymore in WebKit.
640
641         * Scripts/webkitdirs.pm:
642         (generateBuildSystemFromCMakeProject):
643         * gtk/ycm_extra_conf.py:
644         (transform_relative_paths_to_absolute_paths):
645         (FlagsForFile):
646
647 2014-04-17  Anders Carlsson  <andersca@apple.com>
648
649         Fix build.
650
651         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
652         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
653         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
654
655 2014-04-17  Anders Carlsson  <andersca@apple.com>
656
657         Remove unused API enums
658         https://bugs.webkit.org/show_bug.cgi?id=131836
659
660         Reviewed by Tim Horton.
661
662         * MiniBrowser/mac/WK2BrowserWindowController.m:
663         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
664
665 2014-04-16  Brent Fulgham  <bfulgham@apple.com>
666
667         [Win] A few final cleanups to the DataObject classes.
668         https://bugs.webkit.org/show_bug.cgi?id=131784
669
670         Reviewed by Anders Carlsson.
671
672         * DumpRenderTree/win/DRTDataObject.cpp:
673         (DRTDataObject::clearData): Use 'last()' method.
674         * DumpRenderTree/win/UIDelegate.cpp:
675         (DRTUndoStack::pop): Use 'takeLast()' method.
676
677 2014-04-17  Andres Gomez  <agomez@igalia.com>
678
679         [Win] cygwin to keep installing curl 7.33.0-1 and subversion 1.7.14-1
680         https://bugs.webkit.org/show_bug.cgi?id=131365
681
682         Reviewed by Brent Fulgham.
683
684         The cygwin installer is now downloading the wanted versions for
685         the local installation given to the setup wizard.
686
687         * CygwinDownloader/cygwin-downloader.py:
688         * CygwinDownloader/cygwin-downloader.zip:
689
690 2014-04-17  Adrian Perez de Castro  <aperez@igalia.com>
691
692         [GTK] Make run-webkit-tests always use WKTR
693         https://bugs.webkit.org/show_bug.cgi?id=131737
694
695         Reviewed by Darin Adler.
696
697         Now that the GTK+ port only has support for WebKit2, instruct
698         run-webkit-tests to always use WKTR. This avoids needing to pass
699         flag "-2" every time.
700
701         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 
702         (_set_up_derived_options): Always set webkit_test_runner when
703         the platform is GTK+.
704
705 2014-04-17  Brendan Long  <b.long@cablelabs.com>
706
707         [Gtk] Install ninja-build in Tools/gtk/install-dependencies
708         https://bugs.webkit.org/show_bug.cgi?id=131760
709
710         Reviewed by Philippe Normand.
711
712         * gtk/install-dependencies: Install ninja-build when it's available.
713
714 2014-04-16  peavo@outlook.com  <peavo@outlook.com>
715
716         [Win] run-javascriptcore-tests fails to run.
717         https://bugs.webkit.org/show_bug.cgi?id=131761
718
719         Reviewed by Brent Fulgham.
720
721         * Scripts/build-jsc: For now, don't try to build bmalloc on Windows.
722
723 2014-04-16  Andres Gomez  <agomez@igalia.com>
724
725         [Win] Pass default parameters to cygwin setup wizard
726         https://bugs.webkit.org/show_bug.cgi?id=131361
727
728         Reviewed by Brent Fulgham.
729
730         Added some parameters to the cygwin setup wizard so the user
731         doesn't really have to do any interaction.
732
733         * CygwinDownloader/cygwin-downloader.py:
734         * CygwinDownloader/cygwin-downloader.zip:
735
736 2014-04-15  Brent Fulgham  <bfulgham@apple.com>
737
738         [Win] Eliminate use of deleteAllValues in Windows Files
739         https://bugs.webkit.org/show_bug.cgi?id=131631
740
741         Reviewed by Darin Adler.
742
743         Switch to std::unique_ptr for memory lifetime. Get rid of
744         deleteAllValues now that it is no longer needed. Use ranged
745         for loops where possible.
746
747         * DumpRenderTree/win/DRTDataObject.cpp:
748         (WCEnumFormatEtc::WCEnumFormatEtc):
749         (DRTDataObject::~DRTDataObject):
750         (DRTDataObject::GetData):
751         (DRTDataObject::QueryGetData):
752         (DRTDataObject::SetData):
753         (DRTDataObject::clearData):
754         * DumpRenderTree/win/DRTDataObject.h:
755         * DumpRenderTree/win/UIDelegate.cpp:
756         (DRTUndoObject::DRTUndoObject):
757         (DRTUndoObject::~DRTUndoObject):
758         (DRTUndoStack::~DRTUndoStack):
759         (DRTUndoStack::clear):
760         (DRTUndoStack::pop):
761         (DRTUndoManager::DRTUndoManager):
762         (DRTUndoManager::redo):
763         (DRTUndoManager::undo):
764         (UIDelegate::UIDelegate):
765         (UIDelegate::resetUndoManager):
766         * DumpRenderTree/win/UIDelegate.h:
767
768 2014-04-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
769
770         [GTK] Unreviewed GTK gardening.
771
772         Update list of skipped unit tests:
773
774           Skip test: WebKit2Gtk/TestWebKitWebView:/webkit2/WebKitWebView/page-visibility
775
776           Unskip tests: WebKit2/TestWebKit2:WebKit2.ResizeReversePaginatedWebView
777           and WebKit2/TestWebKit2:WebKit2.ScrollPinningBehaviors
778
779         * Scripts/run-gtk-tests:
780         (TestRunner):
781
782 2014-04-16  Tim Horton  <timothy_horton@apple.com>
783
784         check-webkit-style doesn't check code style in .mm or .m files
785         https://bugs.webkit.org/show_bug.cgi?id=131708
786
787         Reviewed by Darin Adler.
788
789         * Scripts/webkitpy/style/checker.py:
790         * Scripts/webkitpy/style/checker_unittest.py:
791         (CheckerDispatcherDispatchTest.test_cpp_paths):
792         (CheckerDispatcherDispatchTest.test_text_paths):
793         Check .mm and .m files as C++.
794
795         * Scripts/webkitpy/style/checkers/cpp.py:
796         (check_spacing):
797         Add an override for our ordinary "missing spaces around =" for @synthesize,
798         which should look like "@synthesize propertyName=_varName;"
799
800         Add an override for "missing space before {" for blocks' "^{".
801
802         Don't follow the "extra space before [" rule for Objective-C, because
803         it breaks this rule in a multitude of ways because of method calls.
804
805         (check_braces):
806         Don't complain about { not being on the end of the previous line if
807         the previous line starts with "- (" or "+ (", which would indicate a
808         Objective-C method definition.
809
810 2014-04-16  Darin Adler  <darin@apple.com>
811
812         Make Vector::takeLast work with move-only types (and optimize for types where move is faster)
813         https://bugs.webkit.org/show_bug.cgi?id=131735
814
815         Reviewed by Alexey Proskuryakov.
816
817         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added a test for Vector::takeLast with move only types.
818         Fixed invocations of EXPECT macros so the expected value is on the left, and the test result
819         is on the right. This can be confusing since our JavaScript test framework does it the opposite
820         way, but gtest works better this way.
821
822 2014-04-15  Hyowon Kim  <hw1008.kim@samsung.com>
823
824         [EFL] Fix problems with the pixel dump.
825         https://bugs.webkit.org/show_bug.cgi?id=131265
826
827         Reviewed by Gyuyoung Kim.
828
829         Painting and compositing paths of WebKit-EFL were totally modified from r166768.
830         However pixel dump codes still call deprecated functions like ewk_view_paint(),
831         which causes that nothing is drawn.
832
833         This patch adds new member functions to AcceleratedCompositingContext to support pixel dump.
834         One of new functions is AcceleratedCompositingContext::extractImageData(),
835         which replaces deprecated function calls. Besides the extractImageData() is invoked by
836         ewk_view_screenshot_contents_get() in order to take the visible content displayed on the EFL webview.
837
838         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
839         (createBitmapContextFromWebView): Add to call DumpRenderTreeSupportEfl::forcePaint().
840
841 2014-04-15  Filip Pizlo  <fpizlo@apple.com>
842
843         Update LLVM export scrpt to handle the build directory being different from the
844         source directory.
845
846         Rubber stamped by Geoffrey Garen.
847
848         * Scripts/export-llvm-build:
849
850 2014-04-15  Ryosuke Niwa  <rniwa@webkit.org>
851
852         Update the hyperlink to waterfall views of perf bots on build.webkit.org
853         https://bugs.webkit.org/show_bug.cgi?id=131695
854
855         Reviewed by Antti Koivisto.
856
857         Updated.
858
859         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
860
861 2014-04-15  Carlos Garcia Campos  <cgarcia@igalia.com>
862
863         [GTK] Reduce the binary size by compressing the text based web inspector resources
864         https://bugs.webkit.org/show_bug.cgi?id=121545
865
866         Reviewed by Gustavo Noronha Silva.
867
868         Compress text based files when compiling inspector resources. It
869         reduces the binary size in 3MB.
870
871         * gtk/generate-inspector-gresource-manifest.py:
872         (find_all_files_in_directory):
873         (is_compressible):
874
875 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
876
877         Remove Gtk WebKit1 tester.
878
879         Gtk WebKit1 port no longer exists, and dashboard was trying to load its tester
880         results over and over as fast as it could.
881
882         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
883         (WebKitBuildbot):
884
885 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
886
887         Wrong link for webkitpy tests results in dashboard popover
888         https://bugs.webkit.org/show_bug.cgi?id=131664
889
890         Reviewed by Timothy Hatcher.
891
892         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
893         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
894         Use a correct link.
895
896 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
897
898         Update webkitpy regression test result that started to fail after http://trac.webkit.org/r167243
899
900         I'm not sure whether the changes are desirable, but am not suspicious enough to roll out.
901
902         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
903         (CommitMessageForThisCommitTest):
904
905 2014-04-14  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
906
907         Fix commit-log-editor bug revealed by r165447
908         https://bugs.webkit.org/show_bug.cgi?id=130676
909
910         Reviewed by Csaba Osztrogonác.
911
912         * Scripts/commit-log-editor:
913         (createCommitMessage): Omitting empty Source/JavaScriptCore:... blocks.
914         Add \n before the first block too, because the longest common prefix now ends with only one newline.
915         (removeLongestCommonPrefixEndingInNewline): The longest common prefix ends with only one newline,
916         now the last block of the common prefix isn't duplicated below. Changing the function name accordingly.
917
918 2014-04-13  Darin Adler  <darin@apple.com>
919
920         userVisibleString should not try to "encode" host names
921         https://bugs.webkit.org/show_bug.cgi?id=131587
922         rdar://problem/14686849
923
924         Reviewed by Alexey Proskuryakov.
925
926         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added URLExtras.mm.
927
928         * TestWebKitAPI/Tests/mac/URLExtras.mm: Added. A few tests for WebCoreNSURLExtras.
929         Coverage is tiny at this point; we could add a lot more cases!
930
931 2014-04-13  Jaehun Lim  <ljaehun.lim@samsung.com>
932
933         Use #include instead of #import
934         https://bugs.webkit.org/show_bug.cgi?id=131604
935
936         Reviewed by Darin Adler.
937
938         Fix "warning: #import is a deprecated GCC extension [-Wdeprecated]".
939
940         * TestWebKitAPI/Tests/WTF/StringView.cpp:
941
942 2014-04-12  Filip Pizlo  <fpizlo@apple.com>
943
944         Make slow-stress tests run faster by running fewer VM variants.
945
946         Rubber stamped by Geoffrey Garen.
947
948         * Scripts/run-javascriptcore-tests:
949         * Scripts/run-jsc-stress-tests:
950
951 2014-04-10  Zan Dobersek  <zdobersek@igalia.com>
952
953         [CMake] Add missing WTF unit tests
954         https://bugs.webkit.org/show_bug.cgi?id=131459
955
956         Reviewed by Martin Robinson.
957
958         * TestWebKitAPI/CMakeLists.txt: Add a few missing source files
959         that should be compiled into the TestWTF binary.
960
961 2014-04-10  Brendan Long  <b.long@cablelabs.com>
962
963         [Gtk] run-launcher doesn't work by default
964         https://bugs.webkit.org/show_bug.cgi?id=131494
965
966         Reviewed by Philippe Normand.
967
968         * Scripts/run-launcher: Always use MiniBrowser for WebKitGTK.
969         * Scripts/webkitdirs.pm:
970         (launcherName): Same.
971         * Scripts/webkitpy/style/checker.py: Remove reference to GtkLauncher.
972         * gtk/common.py:
973         (get_build_path.is_valid_build_directory): Same.
974         * gtk/manifest.txt: Same.
975
976 2014-04-09  Commit Queue  <commit-queue@webkit.org>
977
978         Unreviewed, rolling out r167046.
979         https://bugs.webkit.org/show_bug.cgi?id=131479
980
981         Caused 300+ failures on Mavericks WK1 tester (Requested by ap
982         on #webkit).
983
984         Reverted changeset:
985
986         "Remove "System Font" from whitelisted DRT fonts and char
987         width calculations"
988         https://bugs.webkit.org/show_bug.cgi?id=131411
989         http://trac.webkit.org/changeset/167046
990
991 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
992
993         Remove "System Font" from whitelisted DRT fonts and char width calculations
994         https://bugs.webkit.org/show_bug.cgi?id=131411
995
996         Reviewed by Tim Horton.
997
998         Covered by existing tests.
999
1000         * DumpRenderTree/mac/DumpRenderTree.mm:
1001         (allowedFontFamilySet):
1002
1003 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
1004
1005         systemHiddenFontFamilySet in DRT is unnecessary
1006         https://bugs.webkit.org/show_bug.cgi?id=131414
1007
1008         Reviewed by Tim Horton.
1009
1010         It doesn't seem to affect test results on my machine.
1011
1012         * DumpRenderTree/mac/DumpRenderTree.mm:
1013         (drt_NSFontManager_availableFonts):
1014         (systemHiddenFontFamilySet): Deleted.
1015
1016 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
1017
1018         [Win] Unreviewed test fix: Don't double-release BSTR.
1019
1020         * DumpRenderTree/win/DumpRenderTree.cpp:
1021         (dump): Remove unneeded call to SysFreeString now that we are
1022         using _bstr_t for this variable.
1023
1024 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
1025
1026         [Win] Various DumpRenderTree Fixes.
1027         https://bugs.webkit.org/show_bug.cgi?id=131446.
1028
1029         Reviewed by Tim Horton.
1030
1031         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1032         (AccessibilityUIElement::title): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1033         (AccessibilityUIElement::description): Ditto.
1034         (AccessibilityUIElement::helpText): Ditto.
1035         (AccessibilityUIElement::intValue): Ditto.
1036         (AccessibilityUIElement::isPressActionSupported): Ditto.
1037         (AccessibilityUIElement::accessibilityValue): Ditto.
1038         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1039         (DRTDesktopNotificationPresenter::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1040         (DRTDesktopNotificationPresenter::AddRef): Ditto.
1041         (DRTDesktopNotificationPresenter::Release): Ditto.
1042         (DRTDesktopNotificationPresenter::showDesktopNotification): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1043         (DRTDesktopNotificationPresenter::cancelDesktopNotification): Ditto.
1044         (DRTDesktopNotificationPresenter::notificationDestroyed): Ditto.
1045         (DRTDesktopNotificationPresenter::checkNotificationPermission): Ditto.
1046         (DRTDesktopNotificationPresenter::requestNotificationPermission): Ditto.
1047         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
1048         * DumpRenderTree/win/DumpRenderTree.cpp:
1049         (dumpFrameScrollPosition): Ditto.
1050         (dumpFramesAsText): Ditto.
1051         (compareHistoryItems): Ditto.
1052         (dumpHistoryItem): Ditto.
1053         (dump): Ditto.
1054         (resetDefaultsToConsistentValues): Ditto.
1055         (resetWebViewToConsistentStateBeforeTesting): Ditto.
1056         (runTest): Ditto.
1057         (createWebViewAndOffscreenWindow): Ditto.
1058         * DumpRenderTree/win/EditingDelegate.cpp:
1059         (EditingDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1060         (EditingDelegate::AddRef): Ditto.
1061         (EditingDelegate::Release): Ditto.
1062         (dumpPath): Switch to _bstr_t. Use JSStringCreateWithBSTR
1063         (EditingDelegate::shouldBeginEditingInDOMRange): Get rid of uneeded STDMETHODCALLTYPE declaration.
1064         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
1065         (EditingDelegate::shouldInsertNode): Ditto.
1066         (EditingDelegate::shouldInsertText): Ditto.
1067         (EditingDelegate::shouldDeleteDOMRange): Ditto.
1068         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
1069         (EditingDelegate::shouldApplyStyle): Ditto.
1070         (EditingDelegate::shouldChangeTypingStyle): Ditto.
1071         (EditingDelegate::doPlatformCommand): Ditto.
1072         (EditingDelegate::webViewDidBeginEditing): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1073         (EditingDelegate::webViewDidChange): Ditto.
1074         (EditingDelegate::webViewDidEndEditing): Ditto.
1075         (EditingDelegate::webViewDidChangeTypingStyle): Ditto.
1076         (EditingDelegate::webViewDidChangeSelection): Ditto.
1077         (EditingDelegate::checkSpellingOfString): Ditto.
1078         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1079         (descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1080         (FrameLoadDelegate::FrameLoadDelegate): Ditto.
1081         (FrameLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1082         (FrameLoadDelegate::AddRef): Ditto.
1083         (FrameLoadDelegate::Release): Ditto.
1084         (FrameLoadDelegate::didStartProvisionalLoadForFrame): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1085         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
1086         (FrameLoadDelegate::didFailProvisionalLoadWithError): Ditto.
1087         (FrameLoadDelegate::didCommitLoadForFrame): Ditto.
1088         (FrameLoadDelegate::didReceiveTitle): Ditto.
1089         (FrameLoadDelegate::didChangeIcons): Ditto.
1090         (delegatesWithDelayedWork): Ditto.
1091         (FrameLoadDelegate::didFinishLoadForFrame): Ditto.
1092         (FrameLoadDelegate::didFailLoadWithError): Ditto.
1093         (FrameLoadDelegate::willPerformClientRedirectToURL): Ditto.
1094         (FrameLoadDelegate::didCancelClientRedirectForFrame): Ditto.
1095         (FrameLoadDelegate::willCloseFrame): Ditto.
1096         (FrameLoadDelegate::didFinishDocumentLoadForFrame): Ditto.
1097         (FrameLoadDelegate::didHandleOnloadEventsForFrame): Ditto.
1098         (FrameLoadDelegate::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
1099         (FrameLoadDelegate::didDisplayInsecureContent): Ditto.
1100         (FrameLoadDelegate::didRunInsecureContent): Ditto.
1101         * DumpRenderTree/win/FrameLoadDelegate.h:
1102         * DumpRenderTree/win/HistoryDelegate.cpp:
1103         (HistoryDelegate::didNavigateWithNavigationData): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1104         (HistoryDelegate::updateHistoryTitle): Ditto.
1105         (HistoryDelegate::populateVisitedLinksForWebView): Ditto.
1106         * DumpRenderTree/win/PolicyDelegate.cpp:
1107         (dumpPath):
1108         (PolicyDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1109         (PolicyDelegate::AddRef): Ditto.
1110         (PolicyDelegate::Release): Ditto.
1111         (PolicyDelegate::decidePolicyForNavigationAction): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1112         (PolicyDelegate::unableToImplementPolicyWithError): Ditto.
1113         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1114         (ResourceLoadDelegate::descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1115         (ResourceLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1116         (ResourceLoadDelegate::AddRef): Ditto.
1117         (ResourceLoadDelegate::Release): Ditto.
1118         (ResourceLoadDelegate::identifierForInitialRequest): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1119         (ResourceLoadDelegate::removeIdentifierForRequest): Ditto.
1120         (ResourceLoadDelegate::willSendRequest): Ditto.
1121         (ResourceLoadDelegate::didReceiveAuthenticationChallenge): Ditto.
1122         (ResourceLoadDelegate::didReceiveResponse): Ditto.
1123         (ResourceLoadDelegate::didFinishLoadingFromDataSource): Ditto.
1124         (ResourceLoadDelegate::didFailLoadingWithError): Ditto.
1125         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
1126         (TestRunner::queueLoad): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1127         (TestRunner::setUserStyleSheetLocation): Ditto.
1128         (TestRunner::execCommand): Ditto.
1129         (TestRunner::overridePreference): Ditto.
1130         (TestRunner::evaluateScriptInIsolatedWorld): Ditto.
1131         * DumpRenderTree/win/TextInputControllerWin.cpp: Ditto.
1132         (TextInputController::setMarkedText): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1133         (TextInputController::insertText): Ditto.
1134         * DumpRenderTree/win/UIDelegate.cpp:
1135         (UIDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
1136         (UIDelegate::AddRef): Ditto.
1137         (UIDelegate::Release): Ditto.
1138         (UIDelegate::hasCustomMenuImplementation): Switch to _bstr_t. Use JSStringCreateWithBSTR.
1139         (UIDelegate::trackCustomPopupMenu): Ditto.
1140         (UIDelegate::registerUndoWithTarget): Ditto.
1141         (UIDelegate::removeAllActionsWithTarget): Ditto.
1142         (UIDelegate::setActionTitle): Ditto.
1143         (UIDelegate::undo): Ditto.
1144         (UIDelegate::redo): Ditto.
1145         (UIDelegate::canUndo): Ditto.
1146         (UIDelegate::canRedo): Ditto.
1147         (UIDelegate::printFrame): Ditto.
1148         (UIDelegate::ftpDirectoryTemplatePath): Ditto.
1149         (UIDelegate::webViewHeaderHeight): Ditto.
1150         (UIDelegate::webViewFooterHeight): Ditto.
1151         (UIDelegate::drawHeaderInRect): Ditto.
1152         (UIDelegate::drawFooterInRect): Ditto.
1153         (UIDelegate::webViewPrintingMarginRect): Ditto.
1154         (UIDelegate::canRunModal): Ditto.
1155         (UIDelegate::createModalDialog): Ditto.
1156         (UIDelegate::runModal): Ditto.
1157         (UIDelegate::isMenuBarVisible): Ditto.
1158         (UIDelegate::setMenuBarVisible): Ditto.
1159         (UIDelegate::runDatabaseSizeLimitPrompt): Ditto.
1160         (UIDelegate::paintCustomScrollbar): Ditto.
1161         (UIDelegate::paintCustomScrollCorner): Ditto.
1162         (UIDelegate::setFrame): Ditto.
1163         (UIDelegate::webViewFrame): Ditto.
1164         (UIDelegate::runJavaScriptAlertPanelWithMessage): Ditto.
1165         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
1166         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
1167         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
1168         (UIDelegate::webViewAddMessageToConsole): Ditto.
1169         (UIDelegate::doDragDrop): Ditto.
1170         (UIDelegate::webViewGetDlgCode): Ditto.
1171         (UIDelegate::createWebViewWithRequest): Ditto.
1172         (UIDelegate::webViewClose): Ditto.
1173         (UIDelegate::webViewFocus): Ditto.
1174         (UIDelegate::webViewUnfocus): Ditto.
1175         (UIDelegate::webViewPainted): Ditto.
1176         (UIDelegate::exceededDatabaseQuota): Ditto.
1177         (UIDelegate::embeddedViewWithArguments): Ditto.
1178         (UIDelegate::webViewClosing): Ditto.
1179         (UIDelegate::webViewSetCursor): Ditto.
1180         (UIDelegate::webViewDidInvalidate): Ditto.
1181         (UIDelegate::setStatusText): Ditto.
1182         (UIDelegate::desktopNotificationsDelegate): Ditto.
1183         (UIDelegate::drawBackground): Ditto.
1184         (UIDelegate::decidePolicyForGeolocationRequest): Ditto.
1185         (UIDelegate::didPressMissingPluginButton): Ditto.
1186         * DumpRenderTree/win/WorkQueueItemWin.cpp: Ditto.
1187         (LoadItem::invoke):  Switch to _bstr_t. Use JSStringCreateWithBSTR.
1188         (LoadHTMLStringItem::invoke): Ditto.
1189         (ScriptItem::invoke): Ditto.
1190
1191 2014-04-09  Gergo Balogh  <gbalogh.u-szeged@partner.samsung.com>
1192
1193         Stylechecker: False positive on inline asm code.
1194         https://bugs.webkit.org/show_bug.cgi?id=130570
1195
1196         Reviewed by Csaba Osztrogonác.
1197
1198         Disable stylechecking in asm blocks.
1199
1200         * Scripts/webkitpy/style/checkers/cpp.py:
1201         (process_line):
1202         (_InlineASMState):
1203         (_InlineASMState.__init__):
1204         (_InlineASMState.process_line):
1205         (_InlineASMState.isInside):
1206         (_process_lines):
1207         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1208         (WebKitStyleTest.test_member_initialization_list):
1209
1210 2014-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1211
1212         [GTK] Move WebKit1 unit tests resources used by WebKit2 unit tests to WebKit2 resources dir
1213         https://bugs.webkit.org/show_bug.cgi?id=131029
1214
1215         Reviewed by Philippe Normand.
1216
1217         Add blank.ico and test.pdf to resources dir of WebKit2Gtk unit
1218         tests and remove the getWebKit1TestResoucesDir() method.
1219
1220         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1221         (testDownloadLocalFile): Use Test::getResourcesDir().
1222         (testDownloadLocalFileError): Ditto.
1223         (serverCallback): Ditto.
1224         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1225         (serverCallback): Ditto.
1226         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1227         (httpServerCallback): Ditto.
1228         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1229         (serverCallback): Ditto.
1230         * TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico: Added.
1231         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf: Added.
1232         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1233         (Test::getWebKit1TestResoucesDir): Deleted.
1234
1235 2014-04-09  Alexey Proskuryakov  <ap@apple.com>
1236
1237         [WK2] HTTP authentication regression tests fail
1238         https://bugs.webkit.org/show_bug.cgi?id=81627
1239         <rdar://problem/11079296>
1240
1241         Reviewed by Anders Carlsson.
1242
1243         * WebKitTestRunner/TestController.h:
1244         * WebKitTestRunner/TestController.cpp:
1245         (WTR::TestController::createWebViewWithOptions): Added canAuthenticateAgainstProtectionSpaceInFrame
1246         to pageLoaderClient structure.
1247         (WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true
1248         for password based authentication (we do get server trust challenges on some tests,
1249         which WKTR can't handle).
1250         When this client call is not implemented or returns false, didReceiveAuthenticationChallengeInFrame
1251         calls won't be made, at least on CFNetwork based platforms.
1252         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Changed the output
1253         to omit <unknown>. The resource is always unknown with WK2, and it doesn't really
1254         make sense to associate auth requests with individual resources - there can be
1255         multiple resources loading at once from the same protection space, so WebKit1 API
1256         that had a resource identifier was inherently racy.
1257
1258 2014-04-09  Ryuan Choi  <ryuan.choi@samsung.com>
1259
1260         [EFL] Change font path for DumpRenderTree and WebKitTestRunner
1261         https://bugs.webkit.org/show_bug.cgi?id=131427
1262
1263         Reviewed by Gyuyoung Kim.
1264
1265         Since r166973, font path was changed.
1266
1267         * DumpRenderTree/PlatformEfl.cmake:
1268         * WebKitTestRunner/PlatformEfl.cmake:
1269
1270 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
1271
1272         Fix the build-jsc build
1273         https://bugs.webkit.org/show_bug.cgi?id=131410
1274
1275         Reviewed by Michael Saboff.
1276
1277         * Scripts/build-jsc: Make sure to build bmalloc before WTF, since
1278         WTF depends on it.
1279
1280 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
1281
1282         [GTK] Remove WebKit1 unit tests
1283         https://bugs.webkit.org/show_bug.cgi?id=131359
1284
1285         Reviewed by Anders Carlsson.
1286
1287         Remove all WebKit1 GTK+ unit tests, in preparation for removing the WebKit1 port
1288         entirely. We also remove the list of skipped WebKi1 tests from run-gtk-tests, as
1289         they were inadvertently left in http://trac.webkit.org/changeset/166504.
1290
1291         * CMakeLists.txt: No longer load the WebKit1 unit test CMakeLists.txt file.
1292         * Scripts/run-gtk-tests: Remove skipped WebKit1 unit tests.
1293         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Removed.
1294         * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Removed.
1295         * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Removed.
1296         * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Removed.
1297         * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Removed.
1298         * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Removed.
1299         * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Removed.
1300         * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Removed.
1301         * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Removed.
1302         * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Removed.
1303         * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Removed.
1304         * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Removed.
1305         * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Removed.
1306         * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Removed.
1307         * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Removed.
1308         * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Removed.
1309         * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Removed.
1310         * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Removed.
1311         * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Removed.
1312         * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Removed.
1313         * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Removed.
1314         * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Removed.
1315         * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Removed.
1316         * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Removed.
1317         * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Removed.
1318         * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Removed.
1319         * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Removed.
1320         * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Removed.
1321         * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Removed.
1322         * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Removed.
1323         * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Removed.
1324         * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Removed.
1325         * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Removed.
1326         * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Removed.
1327         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Removed.
1328         * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Removed.
1329
1330 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
1331
1332         Unreviewed gardening (Take 2): Prevent users from attempting
1333         to build with known invalid cURL. 
1334
1335         * Scripts/webkitdirs.pm:
1336         (checkInstalledTools): Check for 7.34.0 (the broken version), not
1337         7.33.0 (the known good version).
1338
1339 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
1340
1341         [GTK] Remove DumpRenderTree and GtkLauncher
1342         https://bugs.webkit.org/show_bug.cgi?id=131373
1343
1344         Reviewed by Andreas Kling.
1345
1346         Remove the GTK+ port of DumpRenderTree and GtkLauncher. These tools are
1347         no longer necessary now that WebKit1 GTK+ will be removed.
1348
1349         * CMakeLists.txt:
1350         * DumpRenderTree/PlatformGTK.cmake: Removed.
1351         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Removed.
1352         * DumpRenderTree/gtk/DumpRenderTree.cpp: Removed.
1353         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Removed.
1354         * DumpRenderTree/gtk/EditingCallbacks.cpp: Removed.
1355         * DumpRenderTree/gtk/EditingCallbacks.h: Removed.
1356         * DumpRenderTree/gtk/EventSender.cpp: Removed.
1357         * DumpRenderTree/gtk/EventSender.h: Removed.
1358         * DumpRenderTree/gtk/GCControllerGtk.cpp: Removed.
1359         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Removed.
1360         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Removed.
1361         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Removed.
1362         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Removed.
1363         * DumpRenderTree/gtk/TextInputController.cpp: Removed.
1364         * DumpRenderTree/gtk/TextInputController.h: Removed.
1365         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Removed.
1366         * GtkLauncher/CMakeLists.txt: Removed.
1367         * GtkLauncher/LauncherInspectorWindow.c: Removed.
1368         * GtkLauncher/LauncherInspectorWindow.h: Removed.
1369         * GtkLauncher/main.c: Removed.
1370         * GtkLauncher/simple.svg: Removed.
1371         * GtkLauncher/text.html: Removed.
1372         * WebKitTestRunner/PlatformGTK.cmake:
1373         * WebKitTestRunner/gtk/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/gtk/fonts/AHEM____.TTF.
1374         * WebKitTestRunner/gtk/fonts/FontWithNoValidEncoding.fon: Renamed from Tools/DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon.
1375         * WebKitTestRunner/gtk/fonts/fonts.conf: Renamed from Tools/DumpRenderTree/gtk/fonts/fonts.conf.
1376
1377 2014-04-08  Mark Rowe  <mrowe@apple.com>
1378
1379         XPC services launched by Safari have wrong DYLD_FRAMEWORK_PATH set when launched via run-safari / debug-safari
1380         <https://webkit.org/b/131388> / <rdar://problem/16291687>
1381
1382         Reviewed by Alexey Proskuryakov.
1383
1384         * Scripts/webkitdirs.pm:
1385         (runMacWebKitApp): Set __XPC_DYLD_FRAMEWORK_PATH to the absolute path to the built products directory.
1386         (execMacWebKitAppForDebugging): Ditto.
1387
1388 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
1389
1390         Build bmalloc on iOS too
1391         https://bugs.webkit.org/show_bug.cgi?id=131381
1392
1393         Reviewed by Andreas Kling.
1394
1395         * Scripts/build-webkit:
1396
1397 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
1398
1399         Unreviewed gardening: Prevent users from attempting
1400         to build with known invalid cURL.
1401
1402         * Scripts/webkitdirs.pm:
1403         (checkInstalledTools): Block build attempts with bad
1404         Cygwin tool set.
1405
1406 2014-04-07  Geoffrey Garen  <ggaren@apple.com>
1407
1408         Build bmalloc on Mac
1409         https://bugs.webkit.org/show_bug.cgi?id=131333
1410
1411         Reviewed by Mark Rowe.
1412
1413         * Scripts/build-webkit: Add the bmalloc target if we're on Mac.
1414         (Note: Just testing Mac is not good enough because in this
1415         script 'Mac' means 'Mac or iOS'.)
1416
1417 2014-03-30  Filip Pizlo  <fpizlo@apple.com>
1418
1419         Move slow JSRegress tests out of the way so that they don't show up in run-jsc-benchmarks runs and also skip tests that are extremely long-running
1420         https://bugs.webkit.org/show_bug.cgi?id=130951
1421
1422         Reviewed by Geoffrey Garen.
1423
1424         * Scripts/run-javascriptcore-tests:
1425
1426 2014-04-06  Darin Adler  <darin@apple.com>
1427
1428         Rework CSS calc logic, fixing some reference count mistakes in Length
1429         https://bugs.webkit.org/show_bug.cgi?id=131280
1430
1431         Reviewed by Andreas Kling.
1432
1433         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added CalculationValue.cpp.
1434         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp: Added.
1435
1436 2014-04-04  Brian J. Burg  <burg@cs.washington.edu>
1437
1438         Enable WEB_REPLAY for PLATFORM(MAC)
1439         https://bugs.webkit.org/show_bug.cgi?id=130700
1440
1441         Reviewed by Timothy Hatcher.
1442
1443         * Scripts/webkitperl/FeatureList.pm: Set the default for WEB_REPLAY for OS X engineering builds.
1444
1445 2014-04-05  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1446
1447         [CMake] Include X11's include dirs in TestNetscapePlugin
1448         https://bugs.webkit.org/show_bug.cgi?id=131270
1449
1450         Reviewed by Martin Robinson.
1451
1452         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Include X11_INCLUDE_DIR since
1453         TestNetscapePlugin includes WebCore code that includes X headers.
1454
1455 2014-04-05  David Kilzer  <ddkilzer@apple.com>
1456
1457         REGRESSION (r166529): Fix build after renaming TileCache to LegacyTileCache
1458         <http://webkit.org/b/130986>
1459
1460         * Scripts/check-for-inappropriate-objc-class-names: Add 'Legacy'
1461         prefix to TileCache class names in exception list.
1462
1463 2014-04-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1464
1465         [GTK] kill-old-processes should kill dbus-daemon processes
1466         https://bugs.webkit.org/show_bug.cgi?id=127352
1467
1468         Reviewed by Martin Robinson.
1469
1470         * BuildSlaveSupport/kill-old-processes:
1471         (main):
1472
1473 2014-04-04  Andres Gomez  <agomez@igalia.com>
1474
1475         [Win] Update obsolete packages in cygwin
1476         https://bugs.webkit.org/show_bug.cgi?id=126264
1477
1478         Reviewed by Brent Fulgham.
1479
1480         Removed "apache" and "minires" as the first has been replaced by
1481         "lighttpd" and the second is now integrated into
1482         "cygwin". Replaced the transitional and now obsolete "gcc" package
1483         with "gcc-g++" and ensure that "python" stays at version "2.6.8"
1484         since the newer version available is "2.7.3" which breaks the
1485         build due to some funniness with environment variable handling.
1486
1487         * CygwinDownloader/cygwin-downloader.py:
1488         * CygwinDownloader/cygwin-downloader.zip:
1489
1490 2014-04-03  Joseph Pecoraro  <pecoraro@apple.com>
1491
1492         check-webkit-style: Improve warnings on Objective-C @property syntax
1493         https://bugs.webkit.org/show_bug.cgi?id=131200
1494
1495         Reviewed by Dan Bernstein.
1496
1497         * Scripts/webkitpy/style/checkers/cpp.py:
1498         (check_spacing):
1499         (CppChecker):
1500         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1501         (CppStyleTest.test_spacing_in_objective_c_properties):
1502
1503 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
1504
1505         Unreviewed. Moving my name to commiter section
1506
1507         * Scripts/webkitpy/common/config/contributors.json:
1508
1509 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
1510
1511         Unreviewed. Add myself as a committer.
1512
1513         * Scripts/webkitpy/common/config/contributors.json:
1514
1515 2014-04-03  Andrzej Badowski  <a.badowski@samsung.com>
1516
1517         [EFL][WK2] Replacing zoom functionality of MiniBrowser from scale_set to page_zoom_set.
1518         https://bugs.webkit.org/show_bug.cgi?id=130391
1519
1520         Reviewed by Gyuyoung Kim.
1521
1522         Change the implementation of the zoom functionality from ewk_view_scale_set
1523         to ewk_view_page_zoom_set.
1524
1525         * MiniBrowser/efl/main.c:
1526
1527 2014-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1528
1529         [webkitpy] perf profiler does not understand --call-graph argument
1530         https://bugs.webkit.org/show_bug.cgi?id=131132
1531
1532         Reviewed by Ryosuke Niwa.
1533
1534         New versions of perf profiler have changed the argument from --call-graph to -g.
1535
1536         * Scripts/webkitpy/common/system/profiler.py:
1537         (Perf.wrapper_arguments): Use -g instead of --call-graph.
1538         * Scripts/webkitpy/port/driver_unittest.py:
1539         (DriverTest.test_profiler_as_wrapper): Update test accordingly.
1540
1541 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1542
1543         Add EFL WK2 performance bot to build.webkit.org
1544         https://bugs.webkit.org/show_bug.cgi?id=131034
1545
1546         Fix after r166707, use "Perf" instead of "perf" for consistency.
1547
1548         Reviewed by Csaba Osztrogonác.
1549
1550         * BuildSlaveSupport/build.webkit.org-config/config.json:
1551
1552 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1553
1554         Add EFL WK2 performance bot to build.webkit.org
1555         https://bugs.webkit.org/show_bug.cgi?id=131034
1556
1557         Reviewed by Csaba Osztrogonác.
1558
1559         * BuildSlaveSupport/build.webkit.org-config/config.json:
1560
1561 2014-04-02  Ryuan Choi  <ryuan.choi@samsung.com>
1562
1563         [EFL][WK1] Use Evas_Touch_Point_State instead of Ewk_Touch_Point_Type
1564         https://bugs.webkit.org/show_bug.cgi?id=131151
1565
1566         Reviewed by Gyuyoung Kim.
1567
1568         * DumpRenderTree/efl/EventSender.cpp: Replace Ewk_Touch_Point_Type to Evas_Touch_Point_State.
1569         (TouchEventInfo::TouchEventInfo):
1570         (sendTouchEvent):
1571         (addTouchPointCallback):
1572         (updateTouchPointCallback):
1573         (cancelTouchPointCallback):
1574         (releaseTouchPointCallback):
1575
1576 2014-04-02  David Kilzer  <ddkilzer@apple.com>
1577
1578         filter-build-webkit: Ignore xcodebuild warnings when compiling with newer builds of clang
1579         <http://webkit.org/b/131045>
1580
1581         Reviewed by Daniel Bates.
1582
1583         * Scripts/filter-build-webkit:
1584         (shouldIgnoreLine): Ignore DVTAssertions related to new builds
1585         of clang, plus debug data for all DVTAssertions.
1586
1587 2014-04-01  Dean Jackson  <dino@apple.com>
1588
1589         Load Media Controls js/css from bundle
1590         https://bugs.webkit.org/show_bug.cgi?id=131086
1591
1592         Reviewed by Eric Carlson.
1593
1594         We're now putting CSS files into the bundle, so remove the test for them.
1595
1596         * Scripts/check-for-inappropriate-files-in-framework:
1597
1598 2014-04-02  Martin Hock  <mhock@apple.com>
1599
1600         Unify private browsing with sessions.
1601         https://bugs.webkit.org/show_bug.cgi?id=130099
1602
1603         Reviewed by Alexey Proskuryakov.
1604
1605         Add an API test for ephemeral sessions similar to PrivateBrowsingPushStateNoHistoryCallback.
1606         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1607         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
1608         (TestWebKitAPI::didNavigateWithNavigationData):
1609         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1610         (TestWebKitAPI::TEST):
1611
1612         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Also test to make sure private browsing can be disabled.
1613         (TestWebKitAPI::didNavigateWithoutNavigationData):
1614         (TestWebKitAPI::didNavigateWithNavigationData):
1615         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1616         (TestWebKitAPI::TEST):
1617
1618 2014-04-02  Martin Robinson  <mrobinson@igalia.com>
1619
1620         REGRESSION(r165704): [GTK] Inspector resources not correctly generated
1621         https://bugs.webkit.org/show_bug.cgi?id=130343
1622
1623         Reviewed by Gustavo Noronha Silva.
1624
1625         * gtk/generate-inspector-gresource-manifest.py: Instead of hard-coding the file list, accept a list
1626         of directories on the command line and look for all appropriate files in those directories for the
1627         GResource archive. Also make archive paths relative to those directories.
1628         (find_all_files_in_directory): This helper looks for all the appropriate files in a given directory.
1629         (find_all_files_in_directory.select_file): Whether or not to add the file to the archive.
1630
1631 2014-04-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1632
1633         [webkitpy] Avoid multiple "Preparing rollout for bug" log messages
1634         https://bugs.webkit.org/show_bug.cgi?id=131106
1635
1636         Reviewed by Csaba Osztrogonác.
1637
1638         * Scripts/webkitpy/tool/commands/download.py:
1639         (AbstractRolloutPrepCommand._prepare_state):
1640         * Scripts/webkitpy/tool/commands/download_unittest.py:
1641         (test_prepare_rollout):
1642         (test_create_rollout):
1643         (test_create_rollout_resolved):
1644         (test_rollout):
1645
1646 2014-04-02  Krzysztof Wolanski  <k.wolanski@samsung.com>
1647
1648         [EFL] Add option to use separate web process for new window in MiniBrowser
1649         https://bugs.webkit.org/show_bug.cgi?id=130190
1650
1651         Reviewed by Gyuyoung Kim.
1652
1653         New created window (CTRL + n) will be open in separated web process.
1654         This option is enabled by adding a flag (S/separate-process) with launching
1655         MiniBrowser.
1656
1657         * MiniBrowser/efl/main.c:
1658         (elm_main):
1659
1660 2014-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1661
1662         [GTK] Move NEWS file to a new location
1663         https://bugs.webkit.org/show_bug.cgi?id=130901
1664
1665         Reviewed by Brent Fulgham.
1666
1667         * gtk/manifest.txt: Update the NEWS file path.
1668
1669 2014-04-01  Anders Carlsson  <andersca@apple.com>
1670
1671         Fix build.
1672
1673         * MiniBrowser/mac/WK2BrowserWindowController.m:
1674         (-[WK2BrowserWindowController awakeFromNib]):
1675         (-[WK2BrowserWindowController dealloc]):
1676         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
1677
1678 2014-04-01  Brent Fulgham  <bfulgham@apple.com>
1679
1680         Unreviewed test gardening.
1681
1682         * Scripts/webkitpy/port/base_unittest.py:
1683         (PortTest.test_build_path): Handle the Debug case so we don't get webkitpy-test failures on our test bots.
1684
1685 2014-04-01  Zoltan Horvath  <zoltan@webkit.org>
1686
1687         [CSS Exclusions] Remove exclusions parsing support
1688         https://bugs.webkit.org/show_bug.cgi?id=131046
1689
1690         Reviewed by David Hyatt.
1691
1692         * Scripts/webkitperl/FeatureList.pm:
1693
1694 2014-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
1695
1696         [GTK] Remove last reference to GTK+ WK1 EWS
1697         https://bugs.webkit.org/show_bug.cgi?id=131058
1698
1699         Reviewed by Martin Robinson.
1700
1701         In r166427 WK1 GTK+ bots and EWS where removed, but this file was missing.
1702
1703         * QueueStatusServer/config/queues.py: Remove reference to GTK+ WK1 EWS.
1704
1705 2014-04-01  Lucas Forschler  <lforschler@apple.com>
1706
1707         Add a 32bit JSC builder/tester.
1708         https://bugs.webkit.org/show_bug.cgi?id=131054
1709         
1710         Reviewed by Michael Saboff.
1711
1712         * BuildSlaveSupport/build.webkit.org-config/config.json:
1713         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1714         (Compile32bitJSC):
1715         (Run32bitJSCTests):
1716         (Run32bitJSCTests.countFailures):
1717         (BuildAndTest32bitJSCFactory):
1718         (BuildAndTest32bitJSCFactory.__init__):
1719
1720 2014-04-01  Martin Robinson  <mrobinson@igalia.com>
1721
1722         [GTK] No longer build WebKit1 gtkdoc
1723         https://bugs.webkit.org/show_bug.cgi?id=130970
1724
1725         Reviewed by Anders Carlsson.
1726
1727         * gtk/common.py:
1728         (gtk_version_of_pkg_config_file): Deleted.
1729         * gtk/generate-gtkdoc:
1730         (get_gtkdoc_module_paths): We no longer need to worry about GTK+ 2, since it
1731         was only applicable for WebKit1.
1732         (get_generator_for_config): No longer look for the WebKit1 configuration file.
1733
1734 2014-04-01  Mario Sanchez Prada  <mario.prada@samsung.com>
1735
1736         [GTK] Running minibrowser with url crashes in debug build
1737         https://bugs.webkit.org/show_bug.cgi?id=130492
1738
1739         Reviewed by Martin Robinson.
1740
1741         Update "uri-scheme" test not to use invalid URIs in it, so we
1742         don't get a mistmatch when comparing the original URI stored in
1743         the test class with the one returned by the WebKitWebView.
1744
1745         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1746         (testWebContextURIScheme): Update the test.
1747
1748 2014-04-01  Mihai Tica  <mitica@adobe.com>
1749
1750         Unreviewed: Add myself as a commiter to the contributors list.
1751
1752         * Scripts/webkitpy/common/config/contributors.json:
1753
1754 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
1755
1756         [EFL][WK2] Extract the control of page background out of color_set
1757         https://bugs.webkit.org/show_bug.cgi?id=127539
1758
1759         Reviewed by Gyuyoung Kim.
1760
1761         Added an option(C) to change background color.
1762
1763         * MiniBrowser/efl/main.c:
1764         (window_create):
1765         (elm_main):
1766
1767 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
1768
1769         Unreviewed build fix on the EFL port with latest EFL libraries since r166149
1770
1771         * ImageDiff/PlatformEfl.cmake: Added ECORE_IMF_INCLUDE_DIRS to include dirs
1772
1773 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
1774
1775         Unreviewed test correction after r166530.
1776
1777         * DumpRenderTree/mac/DumpRenderTree.mm:
1778         (setDefaultsToConsistentValuesForTesting): No need to change preference for all tests. We set the proper
1779         fine-grained setting for swipe tests. This prevents existing tests from breaking.
1780
1781 2014-03-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1782
1783         Remove the trigger for webkit1 tests on the gtk-linux-64-release bot
1784         https://bugs.webkit.org/show_bug.cgi?id=130987
1785
1786         r166427 removed the WebKit1 GTK+ bots, so we don't longer need to
1787         trigger the webkit1 bot tests on the gtk-linux-64-release bot.
1788
1789         Reviewed by Martin Robinson.
1790
1791         * BuildSlaveSupport/build.webkit.org-config/config.json:
1792
1793 2014-03-31  Dean Jackson  <dino@apple.com>
1794
1795         Remove WEB_ANIMATIONS
1796         https://bugs.webkit.org/show_bug.cgi?id=130989
1797
1798         Reviewed by Simon Fraser.
1799
1800         Remove this feature flag until we plan to implement.
1801
1802         * Scripts/webkitperl/FeatureList.pm:
1803
1804 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
1805
1806         Reduced Latched Scroll Test Flakiness
1807         https://bugs.webkit.org/show_bug.cgi?id=130983
1808
1809         Reviewed by Darin Adler.
1810
1811         * DumpRenderTree/mac/DumpRenderTree.mm:
1812         (setDefaultsToConsistentValuesForTesting): Test user should have 'high resolution' scrolling.
1813         * DumpRenderTree/mac/EventSendingController.mm:
1814         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Generate mouse wheel events
1815         with high resolution flags turned on.
1816         * WebKitTestRunner/mac/EventSenderProxy.mm:
1817         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
1818
1819 2014-03-31  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
1820
1821         run-webkit-tests should have a --no-timeout option
1822         https://bugs.webkit.org/show_bug.cgi?id=128286
1823
1824         Reviewed by Joseph Pecoraro.
1825
1826         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1827         (Worker._run_test): Renaming _run_test_with_timeout()
1828         (Worker._run_test_with_or_without_timeout): Renaming _run_test_with_timeout(), because tests can now run without timeout.
1829         (Worker._run_test_in_another_thread): Passing the --no-timeout option to the driver
1830         (Worker._run_test_in_this_thread):
1831         (Worker._run_test_with_timeout): Deleted.
1832         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1833         (parse_args): Added the --no-timeout option
1834
1835 2014-03-31  Samuel White  <samuel_white@apple.com>
1836
1837         AX: Need ability to get line range for text marker.
1838         https://bugs.webkit.org/show_bug.cgi?id=130906
1839
1840         Reviewed by Chris Fleizach.
1841
1842         Added a new function in DRT and TestRunner to test that AXLineTextMarkerRangeForTextMarker works as expected.
1843
1844         * DumpRenderTree/AccessibilityUIElement.cpp:
1845         (lineTextMarkerRangeForTextMarkerCallback):
1846         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1847         (AccessibilityUIElement::getJSClass):
1848         * DumpRenderTree/AccessibilityUIElement.h:
1849         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1850         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1851         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1852         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1853         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1854         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1855         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1856         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1857         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1858         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1859         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1860         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1861
1862 2014-03-31  Filip Pizlo  <fpizlo@apple.com>
1863
1864         More validation for FTL inline caches
1865         https://bugs.webkit.org/show_bug.cgi?id=130948
1866
1867         Reviewed by Geoffrey Garen.
1868
1869         * Scripts/run-jsc-stress-tests:
1870
1871 2014-03-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1872
1873         [GTK] Do not run WebKit1 unit tests by default
1874         https://bugs.webkit.org/show_bug.cgi?id=130968
1875
1876         Reviewed by Martin Robinson.
1877
1878         * Scripts/run-gtk-tests:
1879         (TestRunner):
1880
1881 2014-03-31  Martin Robinson  <mrobinson@igalia.com>
1882
1883         [GTK] Remove scripts code only applicable to autotools
1884         https://bugs.webkit.org/show_bug.cgi?id=130841
1885
1886         Reviewed by Anders Carlsson.
1887
1888         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1889         (_should_file_trigger_build): Update file list to reflect GTK+ CMake port.
1890         * Scripts/webkitpy/common/config/watchlist: Remove the GTK+ build watchlist.
1891         * Scripts/webkitpy/style/checker.py: The GNUmakefile doesn't exist any longer.
1892         * gtk/find-make-dist-errors: Removed.
1893         * gtk/generate-feature-defines-files: Removed.
1894         * gtk/manifest.txt: No longer need to consider autotools files.
1895
1896 2014-03-30  Andy Estes  <aestes@apple.com>
1897
1898         Fix two failing layout tests on Mountain Lion after r166466.
1899
1900         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1901         (-[DownloadDelegate _downloadDidStart:]):
1902
1903 2014-03-30  Andy Estes  <aestes@apple.com>
1904
1905         [Cocoa] Add an originatingWebView property to _WKDownload
1906         https://bugs.webkit.org/show_bug.cgi?id=130945
1907
1908         Reviewed by Anders Carlsson.
1909
1910         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1911         (-[DownloadDelegate _downloadDidStart:]):
1912         (-[OriginatingWebViewDownloadDelegate initWithWebView:]):
1913         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
1914         (TEST):
1915
1916 2014-03-28  Filip Pizlo  <fpizlo@apple.com>
1917
1918         Land the stackmap register liveness glue with the uses of the liveness disabled
1919         https://bugs.webkit.org/show_bug.cgi?id=130924
1920
1921         Reviewed by Oliver Hunt.
1922
1923         * Scripts/run-jsc-stress-tests:
1924
1925 2014-03-29  Alexey Proskuryakov  <ap@apple.com>
1926
1927         Update WebKit1.StringTruncator for Mountain Lion.
1928
1929         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Looks like one subtest was failing
1930         due to different font metrics on 10.8.
1931
1932 2014-03-28  Darin Adler  <darin@apple.com>
1933
1934         Fix recently-introduced off-by-one error in centerTruncateToBuffer
1935         https://bugs.webkit.org/show_bug.cgi?id=130889
1936
1937         Reviewed by Alexey Proskuryakov.
1938
1939         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringTruncator.mm.
1940         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Added. One test for each of the
1941         WebStringTruncator methods; should be good for a start. These are dependent on the
1942         metrics of Helvetica 12, but I am hoping that will be consistent across OS X machines.
1943
1944 2014-03-28  Martin Hock  <mhock@apple.com>
1945
1946         Unreviewed. Add myself as a committer.
1947
1948         * Scripts/webkitpy/common/config/contributors.json:
1949
1950 2014-03-28  Martin Robinson  <mrobinson@igalia.com>
1951
1952         Remove WebKit1 GTK+ bots
1953         https://bugs.webkit.org/show_bug.cgi?id=130904
1954
1955         Reviewed by Anders Carlsson.
1956
1957         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove references to GTK+ WebKit1 test bot and ensure
1958         all bots are testing WebKit2 only.
1959         * Scripts/webkitpy/common/config/ews.json: Remove references to GTK+ WK1 EWS.
1960         * Scripts/webkitpy/common/config/ports.py: Remove references to GTK+ WK1 bots.
1961         * Scripts/webkitpy/common/config/ports_unittest.py: Ditto.
1962         * Scripts/webkitpy/port/builders.py: Ditto.
1963         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
1964         * TestResultServer/static-dashboards/builders.jsonp: Ditto.
1965
1966 2014-03-28  Timothy Hatcher  <timothy@apple.com>
1967
1968         Remove Brian Burg's apple.com email address.
1969
1970         * Scripts/webkitpy/common/config/contributors.json:
1971
1972 2014-03-28  David Kilzer  <ddkilzer@apple.com>
1973
1974         bisect-builds should print Trac 'changeset' URL if only one build is detected
1975         <http://webkit.org/b/130903>
1976
1977         Reviewed by Dan Bernstein.
1978
1979         * Scripts/bisect-builds:
1980         (printTracLink): Print a direct link to the Trac 'changeset'
1981         URL if there is only one revision in the range.
1982
1983 2014-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1984
1985         [EFL] Bump glib version from 2.36 to 2.38 
1986         https://bugs.webkit.org/show_bug.cgi?id=130886
1987
1988         Reviewed by Csaba Osztrogonác.
1989
1990         There is a build break on EFL port when using glib 2.36 ver. To fix it,
1991         we need to bump glib version up to 2.38 as gtk port.
1992
1993         * efl/jhbuild.modules:
1994
1995 2014-03-27  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1996
1997         <https://webkit.org/b/42704> WebKitTestRunner needs to print history delegate information
1998
1999         Provide an implementation of WKContextHistoryClient that logs when called for tests in
2000         the globalhistory directory.
2001
2002         Reviewed by Sam Weinig.
2003
2004         * WebKitTestRunner/TestController.cpp:
2005         (WTR::TestController::TestController):
2006         (WTR::TestController::initialize): Set the history client.
2007         (WTR::TestController::resetStateToConsistentValues): Disable logging of history client callbacks.
2008         (WTR::TestController::didNavigateWithNavigationData): Log information about the navigation. Some portions
2009         of the output are hard-coded to match WebKit1's results for now since they're fixed in our existing tests
2010         and we don't yet have API to access the data in question.
2011         (WTR::TestController::didPerformClientRedirect):
2012         (WTR::TestController::didPerformServerRedirect):
2013         (WTR::TestController::didUpdateHistoryTitle):
2014         * WebKitTestRunner/TestController.h:
2015         (WTR::TestController::setShouldLogHistoryClientCallbacks):
2016         * WebKitTestRunner/TestInvocation.cpp:
2017         (WTR::shouldLogHistoryClientCallbacks): Log history client callbacks for tests in a globalhistory directory.
2018         (WTR::TestInvocation::invoke):
2019
2020 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
2021
2022         Revert http://trac.webkit.org/changeset/166386 because it broke builds.
2023
2024         * Scripts/build-webkit:
2025         * Scripts/copy-webkitlibraries-to-product-directory:
2026
2027 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
2028
2029         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
2030         https://bugs.webkit.org/show_bug.cgi?id=130867
2031         <rdar://problem/16432456> 
2032
2033         Reviewed by Mark Hahnenberg.
2034
2035         * Scripts/build-webkit:
2036         * Scripts/copy-webkitlibraries-to-product-directory:
2037
2038 2014-03-26  Andy Estes  <aestes@apple.com>
2039
2040         [Cocoa] Expose DownloadClient::didFail() and DownloadClient::didCancel()
2041         https://bugs.webkit.org/show_bug.cgi?id=130805
2042
2043         Reviewed by Dan Bernstein.
2044
2045         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2046         (-[DownloadDelegate _download:didReceiveResponse:]):
2047         (-[DownloadDelegate _downloadDidFinish:]):
2048         (runTest):
2049         (TEST):
2050         (-[FailingDownloadDelegate _downloadDidFinish:]):
2051         (-[FailingDownloadDelegate _download:didFailWithError:]):
2052         (-[FailingDownloadDelegate _downloadDidCancel:]):
2053         (-[CancelledDownloadDelegate _downloadDidStart:]):
2054         (-[CancelledDownloadDelegate _downloadDidFinish:]):
2055         (-[CancelledDownloadDelegate _download:didFailWithError:]):
2056         (-[CancelledDownloadDelegate _downloadDidCancel:]):
2057         (-[DownloadDelegate initWithSourceURL:]): Deleted.
2058         (-[DownloadDelegate sourceURL]): Deleted.
2059         (runTestWithNavigationDelegate): Deleted.
2060
2061 2014-03-26  Anders Carlsson  <andersca@apple.com>
2062
2063         Change MiniBrowser to hold on to window controllers instead of windows
2064         https://bugs.webkit.org/show_bug.cgi?id=130797
2065
2066         Reviewed by Oliver Hunt.
2067
2068         * MiniBrowser/mac/AppDelegate.h:
2069         * MiniBrowser/mac/AppDelegate.m:
2070         (-[BrowserAppDelegate init]):
2071         (-[BrowserAppDelegate newWindow:]):
2072         (-[BrowserAppDelegate browserWindowWillClose:]):
2073         (-[BrowserAppDelegate applicationWillTerminate:]):
2074         (-[BrowserAppDelegate frontmostBrowserWindowController]):
2075
2076 2014-03-26  Commit Queue  <commit-queue@webkit.org>
2077
2078         Unreviewed, rolling out r166264.
2079         https://bugs.webkit.org/show_bug.cgi?id=130785
2080
2081         Broke some window.opener tests for WK2 Mavericks (Requested by
2082         brrian__ on #webkit).
2083
2084         Reverted changeset:
2085
2086         "Web Replay: resource unique identifiers should be unique-per-
2087         frame, not globally"
2088         https://bugs.webkit.org/show_bug.cgi?id=130632
2089         http://trac.webkit.org/changeset/166264
2090
2091 2014-03-26  Zoltan Horvath  <zoltan@webkit.org>
2092
2093         [CSS Shapes] Remove shape-inside support
2094         https://bugs.webkit.org/show_bug.cgi?id=130698
2095
2096         Reviewed by David Hyatt.
2097
2098         * Scripts/webkitperl/FeatureList.pm:
2099
2100 2014-02-27  Gurpreet Kaur  <k.gurpreet@samsung.com>
2101
2102         Unreviewed. Add myself as a committer.
2103
2104         * Scripts/webkitpy/common/config/contributors.json:
2105
2106 2014-03-26  Tomas Popela  <tpopela@redhat.com>
2107
2108         run-launcher is Perl script so use elsif and not elif
2109         https://bugs.webkit.org/show_bug.cgi?id=130771
2110
2111         Reviewed by Carlos Garcia Campos.
2112
2113         * Scripts/run-launcher:
2114
2115 2014-03-26  Krzysztof Czech  <k.czech@samsung.com>
2116
2117         [ATK] Utilize new AtkValue interface coming in ATK 2.11.92
2118         https://bugs.webkit.org/show_bug.cgi?id=130575
2119
2120         Reviewed by Mario Sanchez Prada.
2121
2122         Change ATK version to 2.11.92. Adjust current implementation.
2123
2124         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2125         (AccessibilityUIElement::intValue):
2126         (AccessibilityUIElement::minValue):
2127         (AccessibilityUIElement::maxValue):
2128         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2129         (WTR::AccessibilityUIElement::intValue):
2130         (WTR::AccessibilityUIElement::minValue):
2131         (WTR::AccessibilityUIElement::maxValue):
2132         * efl/jhbuild.modules:
2133         * gtk/jhbuild.modules:
2134
2135 2014-03-12  Philippe Normand  <pnormand@igalia.com>
2136
2137         [GTK] The gnumake package is no longer needed in jhbuild
2138         https://bugs.webkit.org/show_bug.cgi?id=130121
2139
2140         Reviewed by Martin Robinson.
2141
2142         For GTK build-webkit now relies on cmake and ninja/gnumake. Even
2143         for a debug build cmake/system-gnumake worked just fine for me.
2144
2145         * gtk/jhbuild.modules: Removed gnumake.
2146         * gtk/patches/make-3.82-arg-list-length.patch: Removed.
2147         * gtk/patches/make-3.82-parallel-build.patch: Removed.
2148
2149 2014-03-25  Andy Estes  <aestes@apple.com>
2150
2151         Fix a failing API test on Mountain Lion and remove temporary debug logging.
2152
2153         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2154         (-[DownloadDelegate _download:didReceiveData:]):
2155         (-[DownloadDelegate _downloadDidFinish:]):
2156
2157 2014-03-25  Brian Burg  <bburg@apple.com>
2158
2159         Web Replay: resource unique identifiers should be unique-per-frame, not globally
2160         https://bugs.webkit.org/show_bug.cgi?id=130623
2161
2162         Reviewed by Timothy Hatcher.
2163
2164         The resource loader callback dumping routines assumed that resource identifiers
2165         were globally unique. Its map of resource identifiers to URLs must also track the
2166         frame associated with the resource.
2167
2168         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2169         (WTR::dumpResourceURL): Additionally take a WKBundleFrameRef argument, and use the
2170         opaque pointer as part of the key for assignedUrlsCache. The frame pointer is
2171         stable as long as the frame is valid.
2172         (WTR::InjectedBundlePage::didInitiateLoadForResource):
2173         (WTR::InjectedBundlePage::willSendRequestForFrame):
2174         (WTR::InjectedBundlePage::didReceiveResponseForResource):
2175         (WTR::InjectedBundlePage::didFinishLoadForResource):
2176         (WTR::InjectedBundlePage::didFailLoadForResource):
2177
2178 2014-03-25  Andy Estes  <aestes@apple.com>
2179
2180         Fix one API test expectation failure on Mountain Lion, and add additional logging to help diagnose another.
2181
2182         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2183         (-[DownloadDelegate _download:didReceiveResponse:]):
2184         (-[DownloadDelegate _download:didReceiveData:]):
2185
2186 2014-03-25  Andy Estes  <aestes@apple.com>
2187
2188         Add some debug logging to an API test that's failing on Mountain Lion.
2189
2190         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2191         (-[DownloadDelegate _download:didReceiveResponse:]):
2192         (-[DownloadDelegate _downloadDidFinish:]):
2193
2194 2014-03-25  Anders Carlsson  <andersca@apple.com>
2195
2196         Add goBack: and goForward: IBActions and move stopLoading: to a new WKIBActions category on WKWebView
2197         https://bugs.webkit.org/show_bug.cgi?id=130732
2198
2199         Reviewed by Tim Horton.
2200
2201         * MiniBrowser/mac/WK2BrowserWindowController.m:
2202         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
2203
2204 2014-03-25  Martin Robinson  <mrobinson@igalia.com>
2205
2206         [GTK] Remove the autotools build
2207         https://bugs.webkit.org/show_bug.cgi?id=130717
2208
2209         Reviewed by Anders Carlsson.
2210
2211         * DumpRenderTree/config.h: Remove references to the autotools configure file.
2212         * GNUmakefile.am: Removed.
2213         * GtkLauncher/GNUmakefile.am: Removed.
2214         * GtkLauncher/main.c: Remove references to the autotools configure file.
2215         * MiniBrowser/gtk/BrowserDownloadsBar.c: Ditto.
2216         * MiniBrowser/gtk/BrowserSearchBar.c: Ditto.
2217         * MiniBrowser/gtk/BrowserWindow.c: Ditto.
2218         * MiniBrowser/gtk/GNUmakefile.am: Removed.
2219         * MiniBrowser/gtk/main.c: Remove references to the autotools configure file.
2220         * Scripts/build-webkit: No longer handle autotools.
2221         * Scripts/run-gtk-tests: Ditto.
2222         (TestRunner._setup_testing_environment):
2223         * Scripts/run-launcher: Ditto.
2224         * Scripts/webkitdirs.pm: Ditto.
2225         * Scripts/webkitpy/common/config/contributionareas.py: Remove autotools as a contribution area.
2226         * Scripts/webkitpy/common/config/contributors.json: Ditto.
2227         * Scripts/webkitpy/port/gtk.py: No longer handle autotools.
2228         * Scripts/webkitpy/style/checker.py:
2229         * TestWebKitAPI/GNUmakefile.am: Removed.
2230         * TestWebKitAPI/config.h: Remove references to the autotools configure file.
2231         * WebKitTestRunner/GNUmakefile.am: Removed.
2232         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Ditto.
2233         * gtk/GNUmakefile.am: Removed.
2234         * gtk/common.py: Remove checks for the autotools build.
2235         * gtk/symbols.filter: Renamed from Source/autotools/symbols.filter.
2236
2237 2014-03-25  László Langó  <llango.u-szeged@partner.samsung.com>
2238
2239         prepare-ChangeLog throws false positive warnings for modified files.
2240         https://bugs.webkit.org/show_bug.cgi?id=130687
2241
2242         Reviewed by Darin Adler.
2243
2244         * Scripts/prepare-ChangeLog:
2245         (originalFile): Ignore git commit paremeter.
2246         We don't need this to get the unmodified file.
2247         (extractLineRangeBeforeChange):
2248         Simplify the if statement. Follow-up after r166189.
2249
2250 2014-03-25  Gabor Rapcsanyi  <rgabor@webkit.org>
2251
2252         [EFL] Add ARM64 build support
2253         https://bugs.webkit.org/show_bug.cgi?id=130506
2254
2255         Rubber stamped by Gyuyoung Kim.
2256
2257         * Scripts/webkitdirs.pm:
2258         (isARM): Detect aarch64 as ARM.
2259
2260 2014-03-25  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2261
2262         [webkitpy] Improve _parse_bug_description to recognize more descriptions
2263         https://bugs.webkit.org/show_bug.cgi?id=130137
2264
2265         Reviewed by Csaba Osztrogonác.
2266
2267         * Scripts/webkitpy/common/checkout/changelog.py:
2268         (ChangeLogEntry._parse_bug_description):
2269         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2270         (test_parse_log_entries_from_changelog):
2271         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2272         (CheckoutTest.test_commit_info_for_revision):
2273
2274 2014-03-24  Andy Estes  <aestes@apple.com>
2275
2276         Fix the iOS build of TestWebKitAPI.
2277
2278         * TestWebKitAPI/Configurations/Base.xcconfig:
2279         * TestWebKitAPI/PlatformUtilities.h:
2280
2281 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
2282
2283         Fix prepare-ChangeLog after r166156.
2284         https://bugs.webkit.org/show_bug.cgi?id=130674
2285
2286         Reviewed by Darin Adler.
2287
2288         * Scripts/prepare-ChangeLog:
2289         (generateFunctionLists):
2290         (extractLineRangeBeforeChange):
2291
2292 2014-03-24  Andy Estes  <aestes@apple.com>
2293
2294         [iOS] Download support by CFURLDownloadRef under USE(CFNETWORK).
2295         https://bugs.webkit.org/show_bug.cgi?id=129322
2296
2297         Reviewed by Anders Carlsson.
2298
2299         Add an API test suite for _WKDownload.
2300
2301         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2302         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: Added.
2303         (-[DownloadDelegate initWithSourceURL:]):
2304         (-[DownloadDelegate sourceURL]):
2305         (-[DownloadDelegate _downloadDidStart:]):
2306         (-[DownloadDelegate _download:didReceiveResponse:]):
2307         (-[DownloadDelegate _download:didReceiveData:]):
2308         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
2309         (-[DownloadDelegate _downloadDidFinish:]):
2310         (TEST):
2311         (runTestWithNavigationDelegate):
2312         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2313         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2314
2315 2014-03-24  Joseph Pecoraro  <pecoraro@apple.com>
2316
2317         filter-build-webkit: reduce unfiltered output
2318         https://bugs.webkit.org/show_bug.cgi?id=130485
2319
2320         Reviewed by Brent Fulgham.
2321
2322         * Scripts/filter-build-webkit:
2323         (shouldIgnoreLine):
2324
2325 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
2326
2327         prepare-ChangeLog should list functions that have been removed too.
2328         https://bugs.webkit.org/show_bug.cgi?id=130508
2329
2330         Reviewed by Darin Adler.
2331
2332         The prepare-ChangeLog does not list the deleted functions in the Changelog.
2333         We have to read the functions and the line ranges of them from the source
2334         before the change, then search for overlaps between them and the changed
2335         line ranges from diff.
2336
2337         * Scripts/prepare-ChangeLog:
2338         (originalFile): Get original source command.
2339         (generateFunctionLists): Collect deleted functions too.
2340         (generateFunctionListsByRanges): Duplicated code is moved to a separate subroutine.
2341         (extractLineRangeBeforeChange): Extract line ranges from the original source to get
2342         deleted functions ranges too.
2343         (extractLineRange): Renamed to extractLineRangeAfterChange.
2344
2345 2014-03-23  Hyowon Kim  <hw1008.kim@samsung.com>
2346
2347         Move all EFL typedefs into EflTypedefs.h.
2348         https://bugs.webkit.org/show_bug.cgi?id=130511
2349
2350         Reviewed by Gyuyoung Kim.
2351
2352         * TestWebKitAPI/PlatformWebView.h: Remove EFL typedefs.
2353         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
2354         * WebKitTestRunner/PlatformWebView.h: Ditto.
2355
2356 2014-03-21  Simon Fraser  <simon.fraser@apple.com>
2357
2358         Don't flush compositing layers within FrameView::willPaintContents()
2359         https://bugs.webkit.org/show_bug.cgi?id=130627
2360         <rdar://problem/16368869>
2361
2362         Reviewed by Sam Weinig.
2363         
2364         Fix DRT to correctly render tests with layers now that FrameView::paintContents
2365         does not flush.
2366         
2367         Move the -[WebView displayIfNeeded] from -[FrameLoadDelegate webView:didFinishLoadForFrame:]
2368         into an explicit function called before dumping. 
2369         
2370         Then explicitly call _flushCompositingChanges to ensure that GraphicsLayer changes
2371         are flushed to CA. They will be pushed to the window by snapshotting.
2372
2373         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2374         Fix weird path to IOKit.framework.
2375         * DumpRenderTree/mac/DumpRenderTree.mm:
2376         (updateDisplay):
2377         (dump):
2378         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2379         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): Fix parameter name.
2380         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Remove display call.
2381
2382 2014-03-21  David Kilzer  <ddkilzer@apple.com>
2383
2384         fix-blink-patch: tool to fix up renamed directory paths in Blink
2385         <http://webkit.org/b/130609>
2386
2387         Reviewed by Ryosuke Niwa.
2388
2389         Usage: cat blink.patch | fix-blink-patch | svn-apply
2390
2391         * Scripts/fix-blink-patch: Added.
2392
2393 2014-03-21  Darin Adler  <darin@apple.com>
2394
2395         Remove use of deprecatedCharacters in WebKit API tests
2396         https://bugs.webkit.org/show_bug.cgi?id=130602
2397
2398         Reviewed by Antti Koivisto.
2399
2400         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2401         (TestWebKitAPI::expectBuilderContent): Use characters8/16 instead of deprecatedCharacters.
2402         (TestWebKitAPI::expectEmpty): Use characters8.
2403         (TestWebKitAPI::TEST): Use characters8 instead of deprecatedCharacters in most cases.
2404
2405         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2406         Removed the test that is entirely about 16-bit conversion since that's basically a test of
2407         the deprecatedCharacters function itself, which we are about to delete.
2408
2409 2014-03-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2410
2411         [webkitpy] Fix has_valid_reviewer()
2412         https://bugs.webkit.org/show_bug.cgi?id=130589
2413
2414         Reviewed by Csaba Osztrogonác.
2415
2416         * Scripts/webkitpy/common/checkout/changelog.py:
2417         (ChangeLogEntry.has_valid_reviewer):
2418         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2419         (test_has_valid_reviewer):
2420         * Scripts/webkitpy/common/config/committers.py:
2421         (CommitterList._reviewer_only):
2422         (CommitterList.committer_by_name):
2423         (CommitterList.reviewer_by_email):
2424         (CommitterList):
2425         (CommitterList.reviewer_by_name):
2426
2427 2014-03-21  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
2428
2429         Add cache support for jhbuild
2430         https://bugs.webkit.org/show_bug.cgi?id=130588
2431
2432         Reviewed by Csaba Osztrogonác.
2433
2434         * jhbuild/jhbuildrc_common.py:
2435         (init): Jhbuild can now save the dependencies locally, if the JHBUILD_MIRROR environment variable is set.
2436
2437 2014-03-21  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2438
2439         [CMake] Add support for MAX_CPU_LOAD translated to -l in ninja and make
2440         https://bugs.webkit.org/show_bug.cgi?id=130504
2441
2442         Reviewed by Martin Robinson.
2443
2444         * Scripts/build-webkit: Add the maxCPULoad() to the makeArgs in
2445         CMake if not specified.
2446         * Scripts/webkitdirs.pm:
2447         (determineMaxCPULoad): Read MAX_CPU_LOAD as maxCPULoad.
2448         (maxCPULoad): determineMaxCPULoad and return maxCPULoad.
2449
2450 2014-03-21  Andreas Kling  <akling@apple.com>
2451
2452         RetainPtr API test should use CFArray instead of CFString for testing.
2453         <rdar://problem/16384899>
2454
2455         Unreviewed bot fix.
2456
2457         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
2458         (TestWebKitAPI::TEST):
2459         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
2460         (TestWebKitAPI::TEST):
2461
2462 2014-03-20  Hyowon Kim  <hw1008.kim@samsung.com>
2463
2464         Move to using std::unique_ptr for EFL objects.
2465         https://bugs.webkit.org/show_bug.cgi?id=129853
2466
2467         Reviewed by Gyuyoung Kim.
2468
2469         EflUniquePtr is a template alias of std::unique_ptr
2470         with a custom deleter for each Efl Objects, which is motivated by GUniquePtr.
2471         This patch replaces uses of OwnPtr and PassOwnPtr for Efl objects with EflUniquePtr.
2472
2473         * DumpRenderTree/efl/DumpRenderTree.cpp:
2474         (main):
2475         * ImageDiff/efl/ImageDiff.cpp:
2476         (initEfl):
2477         (main):
2478
2479 2014-03-20  Ryuan Choi  <ryuan.choi@samsung.com>
2480
2481         Unreviewed buildfix after r165983 for non Cocoa platforms
2482
2483         Renamed WKPreferencesPrivate.h to WKPreferencesRefPrivate.h
2484
2485         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
2486         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2487         * WebKitTestRunner/TestController.cpp:
2488
2489 2014-03-20  Zan Dobersek  <zdobersek@igalia.com>
2490
2491         [GTK][CMake] Add support for building with Clang
2492         https://bugs.webkit.org/show_bug.cgi?id=130260
2493
2494         Reviewed by Martin Robinson.
2495
2496         * TestWebKitAPI/CMakeLists.txt: When building with Clang TestWebKitAPI should be
2497         built with GTEST_HAS_TR1_TUPLE defined to 0 to avoid build failures occuring in the
2498         included GTest framework headers.
2499         * gtk/generate-gtkdoc:
2500         (prepare_environment_for_gtkdoc_generation): Don't modify the CFLAGS env anymore
2501         in case of using Clang since that is now set by the CMake rule.
2502
2503 2014-03-19  Simon Fraser  <simon.fraser@apple.com>
2504
2505         Expose text and page zoom in WK2 SPI, and hook them up in MiniBrowser
2506         https://bugs.webkit.org/show_bug.cgi?id=130476
2507
2508         Reviewed by Anders Carlsson.
2509         
2510         Hook up page/text zoom in MiniBrowser, make reload work, remove some logging.
2511
2512         * MiniBrowser/mac/WK1BrowserWindowController.m:
2513         (-[WK1BrowserWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2514         Remove log.
2515         * MiniBrowser/mac/WK2BrowserWindowController.m:
2516         (-[WK2BrowserWindowController awakeFromNib]):
2517         (-[WK2BrowserWindowController validateMenuItem:]):
2518         (-[WK2BrowserWindowController reload:]):
2519         Hook up reload.
2520         (-[WK2BrowserWindowController toggleZoomMode:]):
2521         (-[WK2BrowserWindowController resetZoom:]):
2522         (-[WK2BrowserWindowController canResetZoom]):
2523         (-[WK2BrowserWindowController currentZoomFactor]):
2524         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
2525         (-[WK2BrowserWindowController canZoomIn]):
2526         (-[WK2BrowserWindowController canZoomOut]):
2527
2528 2014-03-19  Alexey Proskuryakov  <ap@apple.com>
2529
2530         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
2531         https://bugs.webkit.org/show_bug.cgi?id=130463
2532
2533         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Disable the test.
2534
2535 2014-03-18  Samuel White  <samuel_white@apple.com>
2536
2537         AX: Not able to use arrow keys to read text with VoiceOver before selection is set someplace (anyplace).
2538         https://bugs.webkit.org/show_bug.cgi?id=130250
2539
2540         Reviewed by Chris Fleizach.
2541
2542         Added ability to toggle enhanced accessibility on and off to support tests that require it.
2543
2544         * DumpRenderTree/AccessibilityController.cpp:
2545         (enableEnhancedAccessibilityCallback):
2546         (getEnhancedAccessibilityEnabledCallback):
2547         (AccessibilityController::getJSClass):
2548         * DumpRenderTree/AccessibilityController.h:
2549         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
2550         (AccessibilityController::enableEnhancedAccessibility):
2551         (AccessibilityController::enhancedAccessibilityEnabled):
2552         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
2553         (AccessibilityController::enableEnhancedAccessibility):
2554         (AccessibilityController::enhancedAccessibilityEnabled):
2555         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2556         (AccessibilityController::enableEnhancedAccessibility):
2557         (AccessibilityController::enhancedAccessibilityEnabled):
2558         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2559         (AccessibilityController::enableEnhancedAccessibility):
2560         (AccessibilityController::enhancedAccessibilityEnabled):
2561         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2562         (WTR::AccessibilityController::enableEnhancedAccessibility):
2563         (WTR::AccessibilityController::enhancedAccessibilityEnabled):
2564         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2565         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
2566
2567 2014-03-18  Filip Pizlo  <fpizlo@apple.com>
2568
2569         Unreviewed, add some contributors, and fix Nadav's entry (he's not really a reviewer
2570         yet).
2571
2572         * Scripts/webkitpy/common/config/contributors.json:
2573
2574 2014-03-18  Joseph Pecoraro  <pecoraro@apple.com>
2575
2576         Web Inspector: Remove stale ReportMemoryUsagePlugin
2577         https://bugs.webkit.org/show_bug.cgi?id=130405
2578
2579         Reviewed by Andreas Kling.
2580
2581         This clang plugin looks like it was used for the old Inspector memory
2582         instrumentation that was removed. So the tool can be removed.
2583
2584         * clang/ReportMemoryUsagePlugin/CMakeLists.txt: Removed.
2585         * clang/ReportMemoryUsagePlugin/Makefile: Removed.
2586         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp: Removed.
2587         * clang/ReportMemoryUsagePlugin/tests/Source/WebCore/Test.cpp: Removed.
2588
2589 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2590
2591         webkit-patch land shouldn't add a reviewer for unreviewed build fixes
2592         https://bugs.webkit.org/show_bug.cgi?id=130220
2593
2594         Reviewed by Csaba Osztrogonác.
2595
2596         * Scripts/webkitpy/common/checkout/changelog.py:
2597         (ChangeLog.set_reviewer):
2598         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2599         (test_set_reviewer):
2600
2601 2014-03-17  Filip Pizlo  <fpizlo@apple.com>
2602
2603         More FTL enabling.
2604
2605         Rubber stamped by Dan Bernstein.
2606
2607         * Tools/Scripts/build-webkit:
2608
2609 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2610
2611         Renable pagination mode in WK2 MiniBrowser
2612         https://bugs.webkit.org/show_bug.cgi?id=130374
2613
2614         Reviewed by Anders Carlsson.
2615         
2616         Put the implementation of togglePaginationMode: back, and correctly
2617         enable the menu item.
2618
2619         * MiniBrowser/mac/WK2BrowserWindowController.m:
2620         (-[WK2BrowserWindowController validateMenuItem:]):
2621         (-[WK2BrowserWindowController isPaginated]):
2622         (-[WK2BrowserWindowController togglePaginationMode:]):
2623
2624 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2625
2626         Add --reset option to Tools/Scripts/set-webkit-configuration script
2627         https://bugs.webkit.org/show_bug.cgi?id=130401
2628
2629         Reviewed by Csaba Osztrogonác.
2630
2631         * Scripts/set-webkit-configuration:
2632
2633 2014-03-18  Alberto Garcia  <berto@igalia.com>
2634
2635         [GTK] [CMake] build-webkit-options.txt is not generated during a fresh build
2636         https://bugs.webkit.org/show_bug.cgi?id=130388
2637
2638         Reviewed by Sergio Villar Senin.
2639
2640         * Scripts/webkitdirs.pm:
2641         (shouldRemoveCMakeCache): make sure that the build directory
2642         exists before attempting to create a file in it.
2643
2644 2014-03-18  Robert Plociennik  <r.plociennik@samsung.com>
2645
2646         [EFL] fontconfig-2.8.0 is not compliant with C++11 leading to a build break
2647         https://bugs.webkit.org/show_bug.cgi?id=130336
2648
2649         Reviewed by Gyuyoung Kim.
2650
2651         Compilation with gcc 4.8.x results in 'invalid suffix on literal; C++11
2652         requires a space between literal and string macro [-Wliteral-suffix]'
2653         warning treated as error.
2654
2655         This patch applies a solution from r162448 to the EFL port.
2656
2657         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
2658         * efl/jhbuild.modules: Added appropriate patch section.
2659
2660 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
2661
2662         webkitpy test rebaseline.
2663
2664         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2665         (MainTest.test_default_args):
2666
2667 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
2668
2669         --profile should imply --test-runner-count=1 in run-perf-tests
2670         https://bugs.webkit.org/show_bug.cgi?id=130375
2671
2672         Reviewed by Benjamin Poulain.
2673
2674         Use the test runner count of 1 when --profile is specified but not --test-runner-count.
2675
2676         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2677         (PerfTestsRunner._parse_args): Use -1 as the default value.
2678         (PerfTestsRunner._collect_tests): If --test-runner-count is set (i.e. it's a positive value),
2679         then use that value. Otherwise, if it's never set and --profile is present, test-runner-count
2680         should be 1.
2681
2682 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2683
2684         Address some style nits.
2685
2686         * MiniBrowser/mac/WK2BrowserWindowController.m:
2687
2688 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2689
2690         Add transparent window support back into MiniBrowser
2691         https://bugs.webkit.org/show_bug.cgi?id=130363
2692
2693         Reviewed by Anders Carlsson.
2694         
2695         Re-enable transparent window support for WK2.
2696
2697         * MiniBrowser/mac/WK2BrowserWindowController.m:
2698         (-[WK2BrowserWindowController validateMenuItem:]):
2699         (-[WK2BrowserWindowController toggleTransparentWindow:]):
2700
2701 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2702
2703         Fix the 32-bit build; make the open panel make a WK1 window.
2704
2705         * MiniBrowser/mac/AppDelegate.m:
2706         (-[BrowserAppDelegate openDocument:]):
2707
2708 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2709
2710         Convert MiniBrowser to use WKWebView API
2711         https://bugs.webkit.org/show_bug.cgi?id=130061
2712
2713         Reviewed by Anders Carlsson.
2714         
2715         Convert the MiniBrowser WK2 window to use WebKit2 API as much
2716         as possible.
2717         
2718         Some functionality was removed temporarily:
2719             - text zoom, page zoom
2720             - reload
2721             - pagination mode
2722             - transparent window
2723             - dumping source
2724             - window.open support
2725             - beforeUnload panel
2726             - find in page
2727
2728         * MiniBrowser/mac/AppDelegate.h:
2729         * MiniBrowser/mac/AppDelegate.m:
2730         (-[BrowserAppDelegate init]):
2731         (-[BrowserAppDelegate newWindow:]):
2732         (-[BrowserAppDelegate applicationWillTerminate:]):
2733         (-[BrowserAppDelegate openDocument:]):
2734         * MiniBrowser/mac/WK2BrowserWindowController.h:
2735         * MiniBrowser/mac/WK2BrowserWindowController.m:
2736         (-[WK2BrowserWindowController awakeFromNib]):
2737         (-[WK2BrowserWindowController dealloc]):
2738         (-[WK2BrowserWindowController fetch:]):
2739         (-[WK2BrowserWindowController validateMenuItem:]):
2740         (-[WK2BrowserWindowController reload:]):
2741         (-[WK2BrowserWindowController goBack:]):
2742         (-[WK2BrowserWindowController goForward:]):
2743         (-[WK2BrowserWindowController toggleZoomMode:]):
2744         (-[WK2BrowserWindowController resetZoom:]):
2745         (-[WK2BrowserWindowController canResetZoom]):
2746         (-[WK2BrowserWindowController dumpSourceToConsole:]):
2747         (-[WK2BrowserWindowController togglePaginationMode:]):
2748         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
2749         (-[WK2BrowserWindowController windowShouldClose:]):
2750         (-[WK2BrowserWindowController applicationTerminating]):
2751         (-[WK2BrowserWindowController currentZoomFactor]):
2752         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
2753         (-[WK2BrowserWindowController toggleTransparentWindow:]):
2754         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
2755         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2756         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
2757         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
2758         (-[WK2BrowserWindowController find:]):
2759         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
2760         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
2761         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
2762         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
2763         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
2764         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
2765         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
2766         * WebKitTestRunner/PlatformWebView.h:
2767         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2768         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2769
2770 2014-03-17  Zan Dobersek  <zdobersek@igalia.com>
2771
2772         Use RunLoop objects through references instead of pointers
2773         https://bugs.webkit.org/show_bug.cgi?id=130313
2774
2775         Reviewed by Andreas Kling.
2776
2777         Adjust the code accordingly now that RunLoop::current() and RunLoop::main()
2778         return RunLoop reference instead of a pointer.
2779
2780         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
2781         (loadedCallback):
2782         (clickedCallback):
2783
2784 2014-03-17  Tim Horton  <timothy_horton@apple.com>
2785
2786         sort-export-file --help doesn't work (missing 'use')
2787         https://bugs.webkit.org/show_bug.cgi?id=130338
2788
2789         Reviewed by Anders Carlsson.
2790
2791         * Scripts/sort-export-file:
2792         Add a missing 'use', and fix a typo in an error message.
2793
2794 2014-03-17  Martin Robinson  <mrobinson@igalia.com>
2795
2796         [GTK][CMake] Ensure that HAVE_GTK_UNIX_PRINTING is defined when appropriate
2797         https://bugs.webkit.org/show_bug.cgi?id=130155
2798
2799         Reviewed by Philippe Normand.
2800
2801         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add GTK_UNIX_PRINT flags to the build.
2802
2803 2014-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2804
2805         [GTK] MiniBrowser fails to load injected bundle lib
2806         https://bugs.webkit.org/show_bug.cgi?id=130332
2807
2808         Reviewed by Anders Carlsson.
2809
2810         This is because WEBKIT_INJECTED_BUNDLE_PATH env var is set too late.
2811
2812         * MiniBrowser/gtk/main.c:
2813         (main): Make sure WEBKIT_INJECTED_BUNDLE_PATH is set before a web
2814         process is spawn.
2815
2816 2014-03-16  Kim Byung Jun  <bj1987.kim@samsung.com>
2817
2818         [EFL] Enable TOUCH_SLIDER macro
2819         https://bugs.webkit.org/show_bug.cgi?id=130185
2820
2821         Reviewed by Gyuyoung Kim.
2822
2823         * Scripts/webkitperl/FeatureList.pm:
2824
2825 2014-03-16  Zan Dobersek  <zdobersek@igalia.com>
2826
2827         [GTK][CMake] Build with -fno-rtti
2828         https://bugs.webkit.org/show_bug.cgi?id=130261
2829
2830         Reviewed by Martin Robinson.
2831
2832         * TestWebKitAPI/CMakeLists.txt: Build TestWebKitAPI with GTEST_HAS_RTTI macro
2833         defined to 0 to prevent typeid use in included GTest headers.
2834
2835 2014-03-16  Brian Burg  <bburg@apple.com>
2836
2837         Web Inspector: vended backend commands file should be generated as part of the build
2838         https://bugs.webkit.org/show_bug.cgi?id=130110
2839
2840         Reviewed by Timothy Hatcher.
2841
2842         * Scripts/build-webkit: build WebInspectorUI after WebCore but before WebKit.
2843
2844 2014-03-16  Diego Pino García  <dpino@igalia.com>
2845
2846         [GTK] Minibrowser: Add shortcuts for reloading page and reloading page ignoring cache
2847         https://bugs.webkit.org/show_bug.cgi?id=128999
2848
2849         Reviewed by Philippe Normand.
2850
2851         * MiniBrowser/gtk/BrowserWindow.c:
2852         (reloadPage):
2853         (reloadPageIgnoringCache):
2854         (browser_window_init):
2855
2856 2014-03-15  Martin Robinson  <mrobinson@igalia.com>
2857
2858         [GTK] Improve ninja detection in webkitdirs.pm
2859         https://bugs.webkit.org/show_bug.cgi?id=129902
2860
2861         Reviewed by Daniel Bates.
2862
2863         * Scripts/webkitdirs.pm:
2864         (canUseNinja): Use which instead of trying to invoke ninja directly. This also allows
2865         us to look for ninja-build as well.
2866
2867 2014-03-14  Maciej Stachowiak  <mjs@apple.com>
2868
2869         Replace "Apple Computer, Inc." with "Apple Inc." in copyright headers
2870         https://bugs.webkit.org/show_bug.cgi?id=130276
2871         <rdar://problem/16266927>
2872         
2873         Reviewed by Simon Fraser.
2874
2875         * BuildSlaveSupport/build-launcher-app:
2876         * BuildSlaveSupport/build-launcher-dmg:
2877         * DumpRenderTree/DumpRenderTree.h:
2878         * DumpRenderTree/DumpRenderTreePrefix.h:
2879         * DumpRenderTree/GCController.cpp:
2880         * DumpRenderTree/GCController.h:
2881         * DumpRenderTree/JavaScriptThreading.cpp:
2882         * DumpRenderTree/JavaScriptThreading.h:
2883         * DumpRenderTree/PixelDumpSupport.cpp:
2884         * DumpRenderTree/PixelDumpSupport.h:
2885         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
2886         * DumpRenderTree/TestRunner.cpp:
2887         * DumpRenderTree/TestRunner.h:
2888         * DumpRenderTree/WorkQueue.cpp:
2889         * DumpRenderTree/WorkQueue.h:
2890         * DumpRenderTree/WorkQueueItem.h:
2891         * DumpRenderTree/atk/AccessibilityCallbacks.h:
2892         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
2893         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
2894         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
2895         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2896         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2897         * DumpRenderTree/efl/EditingCallbacks.cpp:
2898         * DumpRenderTree/efl/EditingCallbacks.h:
2899         * DumpRenderTree/efl/EventSender.cpp:
2900         * DumpRenderTree/efl/EventSender.h:
2901         * DumpRenderTree/efl/GCControllerEfl.cpp:
2902         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
2903         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2904         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2905         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
2906         * DumpRenderTree/gtk/EditingCallbacks.cpp:
2907         * DumpRenderTree/gtk/EditingCallbacks.h:
2908         * DumpRenderTree/gtk/EventSender.cpp:
2909         * DumpRenderTree/gtk/EventSender.h:
2910         * DumpRenderTree/gtk/GCControllerGtk.cpp:
2911         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
2912         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp:
2913         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h:
2914         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2915         * DumpRenderTree/gtk/TextInputController.cpp:
2916         * DumpRenderTree/gtk/TextInputController.h:
2917         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL:
2918         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
2919         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2920         * DumpRenderTree/mac/AppleScriptController.h:
2921         * DumpRenderTree/mac/AppleScriptController.m:
2922         * DumpRenderTree/mac/CheckedMalloc.cpp:
2923         * DumpRenderTree/mac/CheckedMalloc.h:
2924         * DumpRenderTree/mac/DumpRenderTree.mm:
2925         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
2926         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2927         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2928         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
2929         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
2930         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2931         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2932         * DumpRenderTree/mac/EditingDelegate.h:
2933         * DumpRenderTree/mac/EditingDelegate.mm:
2934         * DumpRenderTree/mac/EventSendingController.h:
2935         * DumpRenderTree/mac/EventSendingController.mm:
2936         * DumpRenderTree/mac/FrameLoadDelegate.h:
2937         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2938         * DumpRenderTree/mac/GCControllerMac.mm:
2939         * DumpRenderTree/mac/MockWebNotificationProvider.h:
2940         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
2941         * DumpRenderTree/mac/NavigationController.h:
2942         * DumpRenderTree/mac/NavigationController.m:
2943         * DumpRenderTree/mac/ObjCController.h:
2944         * DumpRenderTree/mac/ObjCController.m:
2945         * DumpRenderTree/mac/ObjCPlugin.h:
2946         * DumpRenderTree/mac/ObjCPlugin.m:
2947         * DumpRenderTree/mac/ObjCPluginFunction.h:
2948         * DumpRenderTree/mac/ObjCPluginFunction.m:
2949         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2950         * DumpRenderTree/mac/PolicyDelegate.h:
2951         * DumpRenderTree/mac/PolicyDelegate.mm:
2952         * DumpRenderTree/mac/ResourceLoadDelegate.h:
2953         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2954         * DumpRenderTree/mac/TestRunnerMac.mm:
2955         * DumpRenderTree/mac/TextInputController.h:
2956         * DumpRenderTree/mac/TextInputController.m:
2957         * DumpRenderTree/mac/UIDelegate.h:
2958         * DumpRenderTree/mac/UIDelegate.mm:
2959         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2960         * DumpRenderTree/win/DRTDataObject.cpp:
2961         * DumpRenderTree/win/DRTDataObject.h:
2962         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
2963         * DumpRenderTree/win/DRTDropSource.cpp:
2964         * DumpRenderTree/win/DRTDropSource.h:
2965         * DumpRenderTree/win/DraggingInfo.h:
2966         * DumpRenderTree/win/DumpRenderTree.cpp:
2967         * DumpRenderTree/win/DumpRenderTreeWin.h:
2968         * DumpRenderTree/win/EditingDelegate.cpp:
2969         * DumpRenderTree/win/EditingDelegate.h:
2970         * DumpRenderTree/win/EventSender.cpp:
2971         * DumpRenderTree/win/EventSender.h:
2972         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2973         * DumpRenderTree/win/FrameLoadDelegate.h:
2974         * DumpRenderTree/win/GCControllerWin.cpp:
2975         * DumpRenderTree/win/HistoryDelegate.cpp:
2976         * DumpRenderTree/win/HistoryDelegate.h:
2977         * DumpRenderTree/win/MD5.cpp:
2978         * DumpRenderTree/win/MD5.h:
2979         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2980         * DumpRenderTree/win/PolicyDelegate.cpp:
2981         * DumpRenderTree/win/PolicyDelegate.h:
2982         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2983         * DumpRenderTree/win/ResourceLoadDelegate.h:
2984         * DumpRenderTree/win/TestRunnerWin.cpp:
2985         * DumpRenderTree/win/TextInputController.cpp:
2986         * DumpRenderTree/win/TextInputController.h:
2987         * DumpRenderTree/win/TextInputControllerWin.cpp:
2988         * DumpRenderTree/win/UIDelegate.cpp:
2989         * DumpRenderTree/win/UIDelegate.h:
2990         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2991         * EWebLauncher/main.c:
2992         * GtkLauncher/main.c:
2993         * ImageDiff/efl/ImageDiff.cpp:
2994         * ImageDiff/gtk/ImageDiff.cpp:
2995         * MiniBrowser/gtk/main.c:
2996         * Scripts/SpacingHeuristics.pm:
2997         * Scripts/VCSUtils.pm:
2998         * Scripts/bisect-builds:
2999         * Scripts/build-dumprendertree:
3000         * Scripts/build-jsc:
3001         * Scripts/build-webkit:
3002         * Scripts/check-dom-results:
3003         * Scripts/check-for-exit-time-destructors:
3004         * Scripts/check-for-global-initializers:
3005         * Scripts/commit-log-editor:
3006         * Scripts/compare-timing-files:
3007         * Scripts/debug-minibrowser:
3008         * Scripts/debug-safari:
3009         * Scripts/do-file-rename:
3010         * Scripts/find-extra-includes:
3011         * Scripts/generate-coverage-data:
3012         * Scripts/make-script-test-wrappers:
3013         * Scripts/malloc-tree:
3014         * Scripts/old-run-webkit-tests:
3015         * Scripts/parse-malloc-history:
3016         * Scripts/report-include-statistics:
3017         * Scripts/resolve-ChangeLogs:
3018         * Scripts/run-bindings-tests:
3019         * Scripts/run-iexploder-tests:
3020         * Scripts/run-javascriptcore-tests:
3021         * Scripts/run-jsc:
3022         * Scripts/run-launcher:
3023         * Scripts/run-leaks:
3024         * Scripts/run-mangleme-tests:
3025         * Scripts/run-minibrowser:
3026         * Scripts/run-pageloadtest:
3027         * Scripts/run-regexp-tests:
3028         * Scripts/run-safari:
3029         * Scripts/run-sunspider:
3030         * Scripts/run-webkit-app:
3031         * Scripts/sampstat:
3032         * Scripts/set-webkit-configuration:
3033         * Scripts/sort-Xcode-project-file:
3034         * Scripts/sort-export-file:
3035         * Scripts/split-file-by-class:
3036         * Scripts/sunspider-compare-results:
3037         * Scripts/svn-apply:
3038         * Scripts/svn-create-patch:
3039         * Scripts/svn-unapply:
3040         * Scripts/test-webkit-scripts:
3041         * Scripts/update-javascriptcore-test-results:
3042         * Scripts/update-webkit:
3043         * Scripts/update-webkit-auxiliary-libs:
3044         * Scripts/update-webkit-dependency:
3045         * Scripts/update-webkit-localizable-strings:
3046         * Scripts/update-webkit-support-libs:
3047         * Scripts/update-webkit-wincairo-libs:
3048         * Scripts/webkit-build-directory:
3049         * Scripts/webkitdirs.pm:
3050         (installedSafariPath):
3051         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
3052         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
3053         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
3054         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
3055         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
3056         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
3057         * Scripts/webkitperl/features.pm:
3058         * Scripts/webkitperl/httpd.pm:
3059         * Scripts/webkitpy/bindings/main.py:
3060         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
3061         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3062         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3063         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
3064         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
3065         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
3066         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
3067         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3068         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
3069         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.h:
3070         * WebKitTestRunner/PixelDumpSupport.cpp:
3071         * WebKitTestRunner/PixelDumpSupport.h:
3072         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3073         * WinLauncher/WinLauncher.cpp:
3074         * WinLauncher/WinLauncher.h:
3075         * WinLauncher/stdafx.cpp:
3076         * WinLauncher/stdafx.h:
3077
3078 2014-03-14  Filip Pizlo  <fpizlo@apple.com>
3079
3080         Sometimes we need to be explicit about the SDK when running ranlib on Darwin
3081         https://bugs.webkit.org/show_bug.cgi?id=130265
3082
3083         Reviewed by Michael Saboff.
3084
3085         * Scripts/build-webkit:
3086         * Scripts/copy-webkitlibraries-to-product-directory:
3087
3088 2014-03-14  Landry Breuil  <landry@openbsd.org>
3089
3090         Recognize openbsd/netbsd and am64 archs in Tools/Scripts.
3091         Also allow to set MAKE in the environment.
3092         https://bugs.webkit.org/show_bug.cgi?id=129991
3093
3094         Reviewed by Andreas Kling.
3095
3096         * Scripts/webkitdirs.pm:
3097         (determineArchitecture):
3098         (determineNumberOfCPUs):
3099         (isBSD):
3100         (buildAutotoolsProject):
3101         * Scripts/webkitpy/common/system/platforminfo.py:
3102         (PlatformInfo.__init__):
3103         (PlatformInfo.is_openbsd):
3104         (PlatformInfo):
3105         (PlatformInfo.is_netbsd):
3106         (PlatformInfo._determine_os_name):
3107
3108 2014-03-14  Dean Jackson  <dino@apple.com>
3109
3110         Remove libWebKitSystemInterfaceLion.a
3111         https://bugs.webkit.org/show_bug.cgi?id=130254
3112
3113         Reviewed by Geoffrey Garen and Andreas Kling.
3114
3115         No need to copy the Lion libraries into the build.
3116
3117         * Scripts/copy-webkitlibraries-to-product-directory:
3118
3119 2014-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
3120
3121         [EFL][MiniBrowser] Revise help messages of command line parameters
3122         https://bugs.webkit.org/show_bug.cgi?id=130222
3123
3124         Reviewed by Csaba Osztrogonác.
3125
3126         Correct the default value description and make help messages to be consistent.
3127
3128         * MiniBrowser/efl/main.c:
3129
3130 2014-03-12  Sergio Villar Senin  <svillar@igalia.com>
3131
3132         Rename DEFINE_STATIC_LOCAL to DEPRECATED_DEFINE_STATIC_LOCAL
3133         https://bugs.webkit.org/show_bug.cgi?id=129612
3134
3135         Reviewed by Darin Adler.
3136
3137         For new code use static NeverDestroyed<T> instead.
3138
3139         * DumpRenderTree/JavaScriptThreading.cpp:
3140         (javaScriptThreadsMutex):
3141         (javaScriptThreads):
3142         * DumpRenderTree/efl/EventSender.cpp:
3143         (touchPointList):
3144         (delayedEventQueue):
3145         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3146         (delegatesWithDelayedWork):
3147         * Scripts/check-for-exit-time-destructors:
3148         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
3149         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
3150         (testsMap):
3151
3152 2014-03-13  Sanghyup Lee  <sh53.lee@samsung.com>
3153
3154         [EFL][WK2] Fix compilation warning in Minibrowser
3155         https://bugs.webkit.org/show_bug.cgi?id=130132
3156
3157         Reviewed by Csaba Osztrogonác.
3158
3159         Replace mktemp() with mkstemp() to fix compilation warning in MiniBrowser.
3160
3161         * MiniBrowser/efl/main.c:
3162         (on_download_request):
3163
3164 2014-03-13  Filip Pizlo  <fpizlo@apple.com>
3165
3166         FTL should support IsBlah
3167         https://bugs.webkit.org/show_bug.cgi?id=130202
3168
3169         Reviewed by Geoffrey Garen.
3170         
3171         Running existing JSRegress tests with noInline gives us coverage for these
3172         changes. Chances are, this will also give coverage for other interesting things
3173         as well.
3174
3175         * Scripts/run-jsc-stress-tests:
3176
3177 2014-03-12  Brian Burg  <bburg@apple.com>
3178
3179         Web Inspector: Remove unused callId parameter from evaluateInWebInspector
3180         https://bugs.webkit.org/show_bug.cgi?id=129744
3181
3182         Reviewed by Timothy Hatcher.
3183
3184         * DumpRenderTree/TestRunner.cpp:
3185         (evaluateInWebInspectorCallback):
3186         * DumpRenderTree/TestRunner.h:
3187         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3188         (TestRunner::evaluateInWebInspector):
3189         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3190         (TestRunner::evaluateInWebInspector):
3191         * DumpRenderTree/mac/TestRunnerMac.mm:
3192         (TestRunner::evaluateInWebInspector):
3193         * DumpRenderTree/win/TestRunnerWin.cpp:
3194         (TestRunner::evaluateInWebInspector):
3195         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3196         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3197         (WTR::TestRunner::evaluateInWebInspector):
3198         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3199
3200 2014-03-13  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
3201
3202         [GTK] build-webkit shouldn't show error message when ninja isn't installed
3203         https://bugs.webkit.org/show_bug.cgi?id=130129
3204
3205         Reviewed by Csaba Osztrogonác.
3206
3207         * Scripts/webkitdirs.pm:
3208         (canUseNinja): Redirecting stderr to /dev/null
3209
3210 2014-03-13  Andres Gomez  <agomez@igalia.com>
3211
3212         [GTK] "Tools/jhbuild/jhbuild-wrapper --gtk" build fails even after running Tools/gtk/install-dependencies due to missing proper libxml2 python bindings
3213         https://bugs.webkit.org/show_bug.cgi?id=130092
3214
3215         Reviewed by Csaba Osztrogonác.
3216
3217         Added "python-dev" as dependency for deb based distros. It is
3218         already present for rpm based distros. This dependency will allow
3219         libxml2 to generate its python bindings, needed by gtk-doc.
3220
3221         * gtk/install-dependencies:
3222
3223 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3224
3225         Unreviewed. Fix GTK+ cmake build after r165488.
3226
3227         * MiniBrowser/gtk/CMakeLists.txt: Add CMAKE_BINARY_DIR to include dirs.
3228
3229 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3230
3231         [GTK][CMAKE] Remove compile warnings about GTK+ deprecated API
3232         https://bugs.webkit.org/show_bug.cgi?id=130014
3233
3234         Reviewed by Martin Robinson.
3235
3236         Include cmake or autotools config header.
3237
3238         * MiniBrowser/gtk/BrowserDownloadsBar.c:
3239         * MiniBrowser/gtk/BrowserSearchBar.c:
3240         * MiniBrowser/gtk/BrowserWindow.c:
3241         * MiniBrowser/gtk/main.c:
3242
3243 2014-03-12  Commit Queue  <commit-queue@webkit.org>
3244
3245         Unreviewed, rolling out r165471.
3246         https://bugs.webkit.org/show_bug.cgi?id=130139
3247
3248         Didn't really fix the issue and broke another bot (Requested
3249         by mrobinson on #webkit).
3250
3251         Reverted changeset:
3252
3253         "[CMake] Newer versions of CMake cannot find older versions of
3254         Freetype"
3255         https://bugs.webkit.org/show_bug.cgi?id=130107
3256         http://trac.webkit.org/changeset/165471
3257
3258 2014-03-11  Filip Pizlo  <fpizlo@apple.com>
3259
3260         It should be possible to build WebKit with FTL on iOS
3261         https://bugs.webkit.org/show_bug.cgi?id=130116
3262
3263         Reviewed by Dan Bernstein.
3264
3265         * Scripts/build-webkit:
3266         * Scripts/copy-webkitlibraries-to-product-directory:
3267
3268 2014-03-12  Brent Fulgham  <bfulgham@apple.com>
3269
3270         [Win] Remove use of QTSDK
3271         https://bugs.webkit.org/show_bug.cgi?id=130049
3272
3273         Reviewed by Darin Adler.
3274
3275         * DumpRenderTree/win/DumpRenderTree.cpp:
3276         (initialize): Remove QuickTime code.
3277         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't grab logs from
3278         building QTMovieWin.
3279
3280 2014-03-12  Martin Robinson  <mrobinson@igalia.com>
3281
3282         [GTK][CMAKE] Too verbose build output
3283         https://bugs.webkit.org/show_bug.cgi?id=130076
3284
3285         Reviewed by Carlos Garcia Campos.
3286
3287         Instead of building with cmake --build which isn't smart about pretty printing and
3288         colors, we build with a script which calls the proper build command.
3289
3290         * Scripts/webkitdirs.pm:
3291         (buildCMakeGeneratedProject): For GTK+ call the script that we generate during
3292         the CMake configuration pass.
3293
3294 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
3295
3296         [CMake] Newer versions of CMake cannot find older versions of Freetype
3297         https://bugs.webkit.org/show_bug.cgi?id=130107
3298
3299         Reviewed by Gustavo Noronha Silva.
3300
3301         * gtk/jhbuildrc: Work around a bug in newer CMakes by giving the FREETYPE_DIR hint
3302         to CMake during jhbuild initialization.
3303
3304 2014-03-12  Zalan Bujtas  <zalan@apple.com>
3305
3306         Add hiDPI support for compositing content in DumpRenderTree/WebKitTestRunner
3307         https://bugs.webkit.org/show_bug.cgi?id=129961
3308
3309         Reviewed by Simon Fraser.
3310
3311         Now scaled content can go through the window capturing mechanism too for compositing content.
3312         AppleMagnifiedMode is redundant.
3313
3314         * DumpRenderTree/mac/DumpRenderTree.mm:
3315         (setDefaultsToConsistentValuesForTesting):
3316         (runTest):
3317         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3318         (createBitmapContextFromWebView):
3319         * WebKitTestRunner/PlatformWebView.h:
3320         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3321         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3322         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3323         (WTR::PlatformWebView::didInitializeClients):
3324         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3325         (WTR::PlatformWebView::forceWindowFramesChanged):
3326         * WebKitTestRunner/mac/main.mm:
3327         (setDefaultsToConsistentValuesForTesting):
3328
3329 2014-03-12  Anton Obzhirov  <a.obzhirov@samsung.com>
3330
3331         Unreviewed. Add myself as a committer.
3332
3333         * Scripts/webkitpy/common/config/contributors.json:
3334
3335 2014-03-12  Ryuan Choi  <ryuan.choi@samsung.com>
3336
3337         Unreviewed build fix on the EFL port when used lower version of ATK
3338
3339         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3340         (WTR::AccessibilityUIElement::y): Fixed typo.
3341
3342 2014-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
3343
3344         Some images are blank in the rebaseline server UI
3345         https://bugs.webkit.org/show_bug.cgi?id=130104
3346
3347         Reviewed by Tim Horton.
3348
3349         Let the server check for images in the 'retries' directory
3350         if it can't find an image otherwise.
3351
3352         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3353         (RebaselineHTTPRequestHandler.test_result):
3354
3355 2014-03-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
3356
3357         [GTK][CMake] --update-gtk has no effect
3358         https://bugs.webkit.org/show_bug.cgi?id=130088
3359
3360         Reviewed by Philippe Normand.
3361
3362         * Scripts/webkitdirs.pm:
3363         (buildCMakeProjectOrExit): call update-webkitgtk-libs if --update-gtk has been passed
3364         as an argument.
3365
3366 2014-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
3367
3368         Add "System Font" to the list of whitelisted DRT fonts
3369         https://bugs.webkit.org/show_bug.cgi?id=130046
3370
3371         Reviewed by Darin Adler.
3372
3373         * DumpRenderTree/mac/DumpRenderTree.mm:
3374         (allowedFontFamilySet):
3375         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3376
3377 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
3378
3379         [GTK] The jhbuild environment should set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_PATH
3380         https://bugs.webkit.org/show_bug.cgi?id=130064
3381
3382         Reviewed by Philippe Normand.
3383
3384         * efl/jhbuildrc: Remove duplicated code.
3385         * gtk/jhbuildrc: Remove duplicated code.
3386         * jhbuild/jhbuildrc_common.py:
3387         (init): Move duplicated code from jhbuildrc's and extend setting CMake environment variables to
3388         GTK+. We always set the CMAKE_LIBRARY_PATH, which should be harmless for EFL 32-bit systems.
3389         and is apparently necessary for GTK+.
3390
3391 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
3392
3393         check-webkit-style failed to complain about missing braces
3394         https://bugs.webkit.org/show_bug.cgi?id=34189
3395
3396         Reviewed by Ryosuke Niwa.
3397
3398         * Scripts/webkitpy/style/checkers/cpp.py:
3399         (check_braces):
3400         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3401         (WebKitStyleTest.test_braces):
3402
3403 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
3404
3405         Remove Qt cruft from style checker.
3406         https://bugs.webkit.org/show_bug.cgi?id=130085
3407
3408         Reviewed by Csaba Osztrogonác.
3409
3410         There is no 'foreach' keyword in c++. That was a Qt feature
3411         added in: http://trac.webkit.org/changeset/46113
3412         Qt was removed from WebKit, so we should remove the checks
3413         of this keyword from check-webkit-style scripts.
3414
3415         * Scripts/webkitpy/style/checkers/cpp.py:
3416         (check_spacing_for_function_call):
3417         (check_spacing):
3418         (check_braces):
3419         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3420         (CppStyleTest.test_mismatching_spaces_in_parens):
3421         (CppStyleTest.test_spacing_for_fncall):
3422         (WebKitStyleTest.test_braces):
3423
3424 2014-03-11  Martin Hodovan  <mhodovan@inf.u-szeged.hu>
3425
3426         [GTK] update-webkitgtk-libs needs itstool
3427         https://bugs.webkit.org/show_bug.cgi?id=130082
3428
3429         After http://trac.webkit.org/changeset/165110 WebKitGTK+ uses gtk-doc 1.20.
3430         itstool is a dependency of building gtk-doc from version 1.19, so it should
3431         be added to Tools/gtk/install-dependencies script, too.
3432
3433         Reviewed by Philippe Normand.
3434
3435         * gtk/install-dependencies:
3436
3437 2014-03-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3438
3439         webkitbot rollout ChangeLogs should be nicer
3440         https://bugs.webkit.org/show_bug.cgi?id=122654
3441
3442         Reviewed by Csaba Osztrogonác.
3443
3444         Added bug urls and descriptions of rolled out patches to the rollout changelog
3445         if they are present in the original changelog. Additionally removed the list of
3446         changed files and functions.
3447
3448         * Scripts/webkitpy/common/checkout/changelog.py:
3449         (ChangeLog.update_with_unreviewed_message): Cut off the list of modified files.
3450         * Scripts/webkitpy/common/checkout/checkout.py:
3451         (Checkout._changelog_data_for_revision): Store bug description.
3452         * Scripts/webkitpy/common/checkout/checkout_mock.py:
3453         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3454         (CheckoutTest.test_commit_info_for_revision):
3455         * Scripts/webkitpy/common/checkout/commitinfo.py:
3456         (CommitInfo.bug_description): Added.
3457         (CommitInfo.to_json):
3458         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
3459         (CommitInfoTest.test_commit_info_creation):
3460         * Scripts/webkitpy/tool/commands/download.py:
3461         (AbstractRolloutPrepCommand._prepare_state): Store bug ids and descriptions of rolled
3462         out patches for creating rollout changelog.
3463         (CreateRollout._prepare_state): Remove obsolete comments and code, the bug id that
3464         caused the regression is stored in state["bug_blocked"] now.
3465         * Scripts/webkitpy/tool/commands/download_unittest.py:
3466         (test_prepare_rollout):
3467         (test_create_rollout_multiple_revision):
3468         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3469         (PrepareChangeLogForRevert._message_for_revert): Add bug urls and descriptions of
3470         rolled out patches to the changelog.
3471         (PrepareChangeLogForRevert.run):
3472         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
3473         (UpdateChangeLogsForRevertTest):
3474         (test_message_for_revert):
3475         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
3476         (ReopenBugAfterRollout.run):
3477
3478 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
3479
3480         [ATK] Adjust WKTR/DRT to use new API from ATK 2.11.90
3481         https://bugs.webkit.org/show_bug.cgi?id=130021
3482
3483         Reviewed by Mario Sanchez Prada.
3484
3485         Replace deprecated functions to use new API from ATK 2.11.90.
3486
3487         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3488         (AccessibilityUIElement::x):
3489         (AccessibilityUIElement::y):
3490         (AccessibilityUIElement::width):
3491         (AccessibilityUIElement::height):
3492         (AccessibilityUIElement::clickPointX):
3493         (AccessibilityUIElement::clickPointY):
3494         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3495         (WTR::AccessibilityUIElement::x):
3496         (WTR::AccessibilityUIElement::y):
3497         (WTR::AccessibilityUIElement::width):
3498         (WTR::AccessibilityUIElement::height):
3499         (WTR::AccessibilityUIElement::clickPointX):
3500         (WTR::AccessibilityUIElement::clickPointY):
3501
3502 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
3503
3504         [ATK] Expose aria-posinset and aria-setsize through object attributes
3505         https://bugs.webkit.org/show_bug.cgi?id=130011
3506
3507         Reviewed by Chris Fleizach.
3508
3509         Added missing implementation of numberAttributeValue both to WKTR and DRT.
3510
3511         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3512         (AccessibilityUIElement::numberAttributeValue):
3513         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3514         (WTR::AccessibilityUIElement::numberAttributeValue):
3515
3516 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
3517
3518         [Win] Unreviewed build fix.
3519
3520         Some bad Windows code was committed at some point that prevents the Apple Windows port
3521         from finding its runtime dependencies reliably.
3522
3523         * win/DLLLauncher/DLLLauncherMain.cpp:
3524         (appleApplicationSupportDirectory): Restored this function.
3525         (modifyPath): Update to use appleApplicationSupportDirectory function.
3526
3527 2014-03-10  Zoltan Horvath  <zoltan@webkit.org>
3528
3529         Let the user define the full address of the performance-site-server for uploading results
3530         https://bugs.webkit.org/show_bug.cgi?id=129819
3531
3532         Reviewed by Ryosuke Niwa.
3533
3534         Currently perftestsrunner.py assumes that the server uses https protocol all the time, which
3535         can be confusing. It's more straightforward, if you need to define explicitly the server's full
3536         address along with the protocol, when you're using this parameter. I added HTTPS as the default
3537         protocol for now, in order to avoid breaking the perf bots.
3538
3539         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3540         (_upload_json):
3541         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3542         (MainTest.test_upload_json):
3543
3544 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
3545
3546         [Win] Pass environment to Pre-Build, Pre-Link, and Post-Build Stages.
3547         https://bugs.webkit.org/show_bug.cgi?id=130023
3548
3549         Reviewed by Dean Jackson.
3550
3551         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add missing
3552         /SAFESEH flag to DLL launcher process.
3553
3554 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
3555
3556         RunGtkWebKitGObjectDOMBindingsAPIBreakTests should be added to the BuildAndTestFactory not the TestFactory
3557         https://bugs.webkit.org/show_bug.cgi?id=129980
3558
3559         Reviewed by Carlos Garcia Campos.
3560
3561         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add RunGtkWebKitGObjectDOMBindingsAPIBreakTests to the correct factory.
3562
3563 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
3564
3565         [GTK] Remove the WebView source-mode WebKit1 test
3566         https://bugs.webkit.org/show_bug.cgi?id=129976
3567
3568         Reviewed by Carlos Garcia Campos.
3569
3570         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Remove the source-mode test.
3571
3572 2014-03-08  Martin Robinson  <mrobinson@igalia.com>
3573
3574         Unreviewed build fix for GTKbuild after the switch to CMake
3575
3576         * gtk/common.py:
3577         (is_cmake_build): Like r165284, we need to assume CMake by default, since the
3578         test-only bot doesn't have any build files.
3579
3580 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
3581
3582         [GTK] built-product-archive does not handle GTK+ CMake build
3583         https://bugs.webkit.org/show_bug.cgi?id=129941
3584
3585         * BuildSlaveSupport/built-product-archive:
3586         (archiveBuiltProduct): Fix the build by adding support to built-product-archive for
3587         the CMake build.
3588
3589 2014-03-07  Lorenzo Tilve  <ltilve@igalia.com>
3590
3591         [GTK] Include CMake into install-dependencies script
3592         https://bugs.webkit.org/show_bug.cgi?id=129909
3593
3594         Reviewed by Martin Robinson.
3595
3596         As since r165267 buid-webkit uses CMake by default, the dependency
3597         with 'cmake' package should be introduced.
3598
3599         * gtk/install-dependencies: Ditto.
3600
3601 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
3602
3603         REGRESSION(165267): Broke a webkitpy unit tests
3604         https://bugs.webkit.org/show_bug.cgi?id=129904
3605
3606         Reviewed by Jon Honeycutt.
3607
3608         * Scripts/webkitpy/port/gtk.py: Flip the default test to assume CMake by default.
3609         (GtkPort._is_cmake_build):
3610
3611 2014-03-07  Andres Gomez  <agomez@igalia.com>
3612
3613         [GTK] webkit-patch setup-git-clone fails even after running Tools/gtk/install-dependencies
3614         https://bugs.webkit.org/show_bug.cgi?id=129893
3615
3616         Reviewed by Martin Robinson.
3617
3618         Added "git-svn" as dependency for deb based distros and,
3619         additionally, "subversion" for rpm based distros.
3620
3621         * gtk/install-dependencies:
3622
3623 2014-03-07  Roger Fong  <roger_fong@apple.com>
3624
3625         Remove dummy setSystemWebGLLoadPolicy client method.
3626         https://bugs.webkit.org/show_bug.cgi?id=129873.
3627
3628         Reviewed by Dean Jackson.
3629
3630         * WebKitTestRunner/TestController.cpp:
3631         (WTR::TestController::createWebViewWithOptions):
3632
3633 2014-03-07  Mark Hahnenberg  <mhahnenberg@apple.com>
3634
3635         run-jsc-stress-tests doesn't eagerly report test failures when using the shell runner
3636         https://bugs.webkit.org/show_bug.cgi?id=129886
3637
3638         Reviewed by Mark Lam.
3639
3640         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Added a "verbose" mode to the shell runner.
3641         If we're in verbose mode, then we don't redirect any output when running each test. If we're not
3642         in verbose mode then we redirect stdout to /dev/null and allow any stderr output through.
3643         * Scripts/run-jsc-stress-tests: Redirect any sort of error output to stderr so that it will 
3644         make it through when in non-verbose mode.
3645
3646 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
3647
3648         [GTK] buid-webkit should use CMake by default
3649         https://bugs.webkit.org/show_bug.cgi?id=129855
3650
3651         Reviewed by Carlos Garcia Campos.
3652
3653         Make the CMake build the default GTK+ build when using build-webkit. This will
3654         ensure that all bots are using CMake. We do this by swapping --gtk and --gtkcmake,
3655         so that we have --gtk and --gtkautotools.
3656
3657         * Scripts/webkitdirs.pm: Swap --gtkcmake/--gtk for --gtk/--gtkautotools.
3658         * Scripts/webkitpy/port/gtk.py: Ditto.
3659
3660 2014-03-06  Martin Robinson  <mrobinson@igalia.com>
3661
3662         [CMake] [GTK] Build with ninja when it is available
3663         https://bugs.webkit.org/show_bug.cgi?id=129805
3664
3665         Reviewed by Philippe Normand.
3666
3667         * Scripts/webkitdirs.pm:
3668         (canUseNinja): Added this helper which tries to execute Ninja, in an effort to determine
3669         if it's available on the system.
3670         (cmakeGeneratedBuildfile): Return the path to the generated build file. Only Unix suppo