[GTK] Missing API detected in GObject DOM bindings after r176630
[WebKit-https.git] / Tools / ChangeLog
1 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2
3         [GTK] Missing API detected in GObject DOM bindings after r176630
4         https://bugs.webkit.org/show_bug.cgi?id=139201
5
6         Reviewed by Gustavo Noronha Silva.
7
8         Handle deprecated symbols again when generating the GObject DOM
9         bindings documentation.
10
11         * gtk/webkitdom.py:
12         (WebKitDOMDocGenerator):
13         (WebKitDOMDocGenerator.is_deprecated_symbol_file):
14         (WebKitDOMDocGenerator.generate):
15         (WebKitDOMDocGeneratorSections.__init__):
16         (WebKitDOMDocGeneratorSections._find_deprecated_symbols):
17         (WebKitDOMDocGeneratorSections.write_section):
18
19 2014-12-07  Csaba Osztrogonác  <ossy@webkit.org>
20
21         [EFL][jhbuild] Fix libsoup build with clang
22         https://bugs.webkit.org/show_bug.cgi?id=139088
23
24         Reviewed by Gyuyoung Kim.
25
26         * efl/jhbuild.modules:
27         * efl/patches/soup-clang-warning-fix1.patch: Added.
28         * efl/patches/soup-clang-warning-fix2.patch: Added.
29
30 2014-12-06  Alexey Proskuryakov  <ap@apple.com>
31
32         [Mac] DumpRenderTree sets storage directory incorrectly
33         https://bugs.webkit.org/show_bug.cgi?id=139347
34
35         Reviewed by Dan Bernstein.
36
37         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
38         Don't use user defaults to pass per-instance paths, as user defaults are shared
39         across all instances.
40
41 2014-12-05  Chris Fleizach  <cfleizach@apple.com>
42
43         AX: I cannot activate links on the mobile version of news.google.com
44         https://bugs.webkit.org/show_bug.cgi?id=139330
45
46         Reviewed by Simon Fraser.
47
48         Implement press for iOS.
49
50         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
51         (AccessibilityUIElement::press):
52
53 2014-12-05  Daniel Bates  <dabates@apple.com>
54
55         [iOS] Query -[WAKWindow screenScale] instead of using WKGetScreenScaleFactor()
56         https://bugs.webkit.org/show_bug.cgi?id=139326
57
58         Reviewed by Anders Carlsson.
59
60         Ask the window for its screen scale factor instead of calling WKGetScreenScaleFactor()
61         to query the OS for it. This approach will ensure DumpRenderTree takes the snapshot
62         using the same scale factor as used in WebKit.
63
64         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
65         (createBitmapContextFromWebView):
66
67 2014-12-05  Anders Carlsson  <andersca@apple.com>
68
69         REGRESSION (r176677): All tests crash on Windows
70         https://bugs.webkit.org/show_bug.cgi?id=139321
71
72         Reviewed by Alexey Proskuryakov.
73
74         * DumpRenderTree/win/DumpRenderTree.cpp:
75         (runTest):
76         Don't call CFRelease on the url while we have an outstanding pointer to its string,
77         and use the right number of bytes when allocating the testURL buffer.
78
79 2014-12-05  Daniel Bates  <dabates@apple.com>
80
81         [iOS] DumpRenderTree produces many reference test mismatches
82         https://bugs.webkit.org/show_bug.cgi?id=139314
83
84         Reviewed by Simon Fraser.
85
86         Fixes an issue where the scale factor used to render the snapshot taken by
87         DumpRenderTree may differ from the device scale factor. In particular, the
88         scale factor used to render a snapshot of a test may differ from the scale
89         factor used to render the snapshot of its expected result.
90
91         Currently DumpRenderTree uses SPI, -[UIView newSnapshotForRect], on iOS to
92         snapshot the UIWebBrowserView. This SPI always render using a scale factor
93         of one when the backing store for the LegacyTileLayer objects were out-of-
94         date regardless of the device scale factor. Instead we should use UIImage
95         and CALayer API to perform the snapshot with respect to the device scale
96         factor.
97
98         Additionally write iOS pixel dump support logic in terms of existing
99         DumpRenderTree abstractions so as to support generating and comparing
100         pixel dump checksums as well as make the iOS code more consistent with
101         the logic used by other ports.
102
103         * DumpRenderTree/PixelDumpSupport.cpp:
104         (dumpWebViewAsPixelsAndCompareWithExpected): Removed !PLATFORM(IOS)-guard.
105         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
106         (BitmapContext::createFromUIImage): Added.
107         (BitmapContext::pixelData): Added.
108         (BitmapContext::BitmapContext): Added.
109         (computeMD5HashStringForBitmapContext): Added.
110         (dumpBitmap): Added.
111         (createBitmapContextFromWebView): Moved logic from dumpWebViewAsPixelsAndCompareWithExpected() to here.
112         (dumpWebViewAsPixelsAndCompareWithExpected): Deleted.
113
114 2014-12-05  Anders Carlsson  <andersca@apple.com>
115
116         Give all web pages a website data store
117         https://bugs.webkit.org/show_bug.cgi?id=139317
118
119         Reviewed by Tim Horton.
120
121         * MiniBrowser/mac/AppDelegate.m:
122         (-[BrowserAppDelegate newPrivateWindow:]):
123         Don't release the controller - it's implicitly retained by the window.
124
125 2014-12-05  Daniel Bates  <dabates@apple.com>
126
127         [iOS] DumpRenderTree fails to render every other test when pixel tests are on
128         https://bugs.webkit.org/show_bug.cgi?id=137581
129         <rdar://problem/18642906>
130
131         Reviewed by Simon Fraser.
132
133         Fixes an issue where the DumpRenderTree snapshot may reflect the rendered content
134         of the test that proceeded the currently running test.
135
136         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
137         (dumpWebViewAsPixelsAndCompareWithExpected): Ensure that UIKit has performed a layout
138         of the UIWebBrowserView view. Also, remove unnecessary call to -[UIWebDocumentView layoutTilesNow]
139         as -[UIWebDocumentView newSnapshotWithRect] will layout the tiles.
140
141 2014-12-05  Jer Noble  <jer.noble@apple.com>
142
143         [WTF] MediaTime should support round-tripping from and to doubles.
144         https://bugs.webkit.org/show_bug.cgi?id=139248
145
146         Reviewed by Eric Carlson.
147
148         Add API tests for new features of MediaTime. Update the LLDB python provider to correctly display
149         the MediaTimes after this change.
150
151         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
152         (WTF::operator<<):
153         (TestWebKitAPI::TEST):
154         * lldb/lldb_webkit.py:
155         (WTFMediaTime_SummaryProvider):
156         (WTFMediaTimeProvider.timeValueAsDouble):
157         (WTFMediaTimeProvider.isIndefinite):
158         (WTFMediaTimeProvider):
159         (WTFMediaTimeProvider.hasDoubleValue):
160
161 2014-12-05  Anders Carlsson  <andersca@apple.com>
162
163         Add a private browsing mode to MiniBrowser
164         https://bugs.webkit.org/show_bug.cgi?id=139308
165
166         Reviewed by Sam Weinig.
167
168         * MiniBrowser/mac/AppDelegate.m:
169         (defaultConfiguration):
170         (-[BrowserAppDelegate newWindow:]):
171         (-[BrowserAppDelegate newPrivateWindow:]):
172         * MiniBrowser/mac/MainMenu.xib:
173         * MiniBrowser/mac/WK2BrowserWindowController.h:
174         * MiniBrowser/mac/WK2BrowserWindowController.m:
175         (-[WK2BrowserWindowController awakeFromNib]):
176         (-[WK2BrowserWindowController initWithConfiguration:]):
177         (-[WK2BrowserWindowController dealloc]):
178         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
179
180 2014-12-04  Alexey Proskuryakov  <ap@apple.com>
181
182         Run http tests parallel
183         https://bugs.webkit.org/show_bug.cgi?id=138958
184
185         Reviewed by Daniel Bates.
186
187         Remove the concept of "locked shard". Now http tests are just like any other tests.
188         We start HTTP and WebSocket servers at the start if we need them, and terminate them
189         when done with all the tests (not when the last http test runs, which is unnecessarily
190         unpredictable).
191
192         This makes debug tests run in 8 minutes and 12 seconds on my Mac Pro. Without the
193         patch, they used to take over 15 minutes.
194
195         As part of the fix, we no longer pass the number of servers to Apache. I don't
196         think that these parameters did what we wanted them to do; Apache handles the load
197         just fine without them.
198
199         The change applies to all platforms. I fixed everything I could find on Mac, and
200         Ossy told me that he's been running http tests in parallel for a long time. If
201         there is increased instability for some ports, it will need to be fixed - there is
202         generally nothing special about http tests at this point, and most code is
203         cross-platform in WebKit2.
204
205         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
206         (LayoutTestRunner.__init__):
207         (LayoutTestRunner.run_tests):
208         (LayoutTestRunner.start_servers_with_lock):
209         (LayoutTestRunner._handle_started_test):
210         (Worker.handle):
211         (Sharder.__init__):
212         (Sharder.shard_tests):
213         (Sharder._shard_every_file):
214         (Sharder._shard_by_directory):
215         (LayoutTestRunner._handle_finished_test_list): Deleted.
216         (LayoutTestRunner._handle_finished_test_list.find): Deleted.
217         (Sharder._shard_in_two): Deleted.
218         (Sharder): Deleted.
219         (Sharder._resize_shards): Deleted.
220         (Sharder._resize_shards.divide_and_round_up): Deleted.
221         (Sharder._resize_shards.extract_and_flatten): Deleted.
222         (Sharder._resize_shards.split_at): Deleted.
223         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
224         (FakePrinter.print_workers_and_shards):
225         (LayoutTestRunnerTests.test_servers_started.start_http_server):
226         (LayoutTestRunnerTests.test_servers_started):
227         (SharderTests.get_shards):
228         (SharderTests.test_shard_by_dir):
229         (SharderTests.test_shard_every_file):
230         (SharderTests): Deleted.
231         (SharderTests.test_shard_in_two): Deleted.
232         (SharderTests.test_shard_in_two_has_no_locked_shards): Deleted.
233         (SharderTests.test_shard_in_two_has_no_unlocked_shards): Deleted.
234         (SharderTests.test_multiple_locked_shards): Deleted.
235         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
236         (ManagerTest.test_needs_servers.get_manager):
237         (ManagerTest.integration_test_needs_servers.get_manager):
238         (ManagerTest.test_look_for_new_crash_logs.get_manager):
239         (ManagerTest):
240         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
241         (_set_up_derived_options):
242         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
243         (RunTest.test_batch_size):
244         (RunTest.test_max_locked_shards): Deleted.
245         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
246         (LayoutTestApacheHttpd.__init__):
247         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
248         (TestLayoutTestApacheHttpd.test_start_cmd):
249         * Scripts/webkitpy/layout_tests/servers/http_server.py:
250         (Lighttpd.__init__):
251         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
252         (HttpServerBase.__init__):
253         * Scripts/webkitpy/layout_tests/views/printing.py:
254         (Printer.print_workers_and_shards):
255         * Scripts/webkitpy/port/base.py:
256         (Port.default_child_processes):
257         (Port.to.start_http_server):
258         (Port.default_max_locked_shards): Deleted.
259         * Scripts/webkitpy/port/port_testcase.py:
260         (PortTestCase.make_port):
261         (PortTestCase.test_default_max_locked_shards): Deleted.
262         * Scripts/webkitpy/port/test.py:
263         (TestPort.start_http_server):
264
265 2014-12-04  Alexey Proskuryakov  <ap@apple.com>
266
267         Don't lock perf tests in run-webkit-tests
268         https://bugs.webkit.org/show_bug.cgi?id=139264
269
270         Reviewed by Daniel Bates.
271
272         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
273         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
274         * Scripts/webkitpy/layout_tests/controllers/manager.py:
275         * Scripts/webkitpy/layout_tests/models/test_input.py:
276         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
277
278 2014-12-03  Alexey Proskuryakov  <ap@apple.com>
279
280         http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html fails unless certain other tests run before it
281         https://bugs.webkit.org/show_bug.cgi?id=139243
282
283         Reviewed by Anders Carlsson.
284
285         We didn't get WKPageLoaderClient calls in secondary windows, so we didn't have a
286         chance to allow untrusted certificates.
287
288         * WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage):
289         Set up more client objects for secondary windows. We may be able to share some of the
290         code with main view creation function, but it's not exactly the same (notably, we
291         do not focus a secondary window when it's done loading).
292
293 2014-12-03  Joanmarie Diggs  <jdiggs@igalia.com>
294
295         AX: [ATK] Inline text elements with accessible object attributes and/or event handlers are not exposed
296         https://bugs.webkit.org/show_bug.cgi?id=139071
297
298         Reviewed by Chris Fleizach.
299
300         Add string value for ATK_ROLE_STATIC in roleToString.
301
302         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
303
304 2014-12-03  Renato Nagy  <rnagy@inf.u-szeged.hu>
305
306         check-webkit-style is confused by ternary expression inside first member initializer
307         https://bugs.webkit.org/show_bug.cgi?id=136442
308
309         Reviewed by Csaba Osztrogonác.
310
311         * Scripts/webkitpy/style/checkers/cpp.py:
312         (check_member_initialization_list):
313
314 2014-12-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
315
316         [GTK] [JHBuild] gst-plugins-bad fails to build if the GNUStep libraries are installed.
317         https://bugs.webkit.org/show_bug.cgi?id=139220
318
319         Reviewed by Philippe Normand.
320
321         * gtk/jhbuild.modules:
322         * gtk/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
323
324 2014-12-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
325
326         Remove unused JSC runtime options
327         https://bugs.webkit.org/show_bug.cgi?id=133070
328
329         Reviewed by Csaba Osztrogonác.
330
331         * Scripts/run-jsc-stress-tests:
332
333 2014-12-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
334
335         [EFL] Add subtle crypto to the build system
336         https://bugs.webkit.org/show_bug.cgi?id=138612
337
338         Reviewed by Csaba Osztrogonác.
339
340         * Scripts/webkitperl/FeatureList.pm:
341
342 2014-12-02  Joanmarie Diggs  <jdiggs@igalia.com>
343
344         AX: [ATK] Table captions and table rows are missing from the accessible hierarchy
345         https://bugs.webkit.org/show_bug.cgi?id=139005
346
347         Reviewed by Chris Fleizach.
348
349         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
350         Add mapping for ATK_ROLE_CAPTION to roleToString
351
352 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
353
354         http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
355         https://bugs.webkit.org/show_bug.cgi?id=139149
356
357         Reviewed by Anders Carlsson.
358
359         WebKit2 already cleared application caches between runs (although it wasn't entirely
360         effective without WebCore changes in this patch).
361
362         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Clear applicaiton caches between runs.
363
364         * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ditto (unfortunately, this
365         function is not implemented on Windows, see below).
366
367         * DumpRenderTree/win/TestRunnerWin.cpp: (TestRunner::clearAllApplicationCaches):
368         Ameded a FIXME.
369
370 2014-12-02  Gavin Barraclough  <barraclough@apple.com>
371
372         Generalize PageActivityAssertionToken
373         https://bugs.webkit.org/show_bug.cgi?id=139106
374
375         Reviewed by Sam Weinig.
376
377         Add an API test for WTF::RefCounter.
378
379         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
380         * TestWebKitAPI/Tests/WTF/RefCounter.cpp: Added.
381         (TestWebKitAPI::TEST):
382             - added RefCounter test.
383
384 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
385
386         [Mac, iOS] Crash log application information contains latest main frame URL instead of test URL
387         https://bugs.webkit.org/show_bug.cgi?id=139174
388
389         Reviewed by Simon Fraser.
390
391         * DumpRenderTree/TestRunner.cpp:
392         * DumpRenderTree/TestRunner.h:
393         Renamed testPathOrURL to testURL, because this variable always contains a URL.
394
395         * DumpRenderTree/mac/DumpRenderTree.mm:
396         (sizeWebViewForCurrentTest): Updated for testPathOrURL renaming.
397         (testPathFromURL): Moved from FrameLoadDelegate.mm.
398         (runTest): Set crash reporter information here, as we know the exact test URL.
399
400         * DumpRenderTree/mac/FrameLoadDelegate.mm:
401         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): Don't set crash
402         reporter information here.
403
404         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
405         * DumpRenderTree/mac/TestRunnerMac.mm:
406         Updated for testPathOrURL renaming.
407
408         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
409         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): WebProcess doesn't know
410         test URL until load starts, so save it into TestRunner now. A new TestRunner object
411         is created for each test.
412
413         * WebKitTestRunner/InjectedBundle/TestRunner.h:
414         (WTR::TestRunner::testURL):
415         (WTR::TestRunner::setTestURL):
416         Make TestRunner know the test name. For now, it's good enough to have it once load
417         starts, but if we ever need it earlier, we can send it with BeginTest message.
418
419         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
420         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
421         Use test URL, not currently loading URL for CrashReporter.
422
423         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
424         (WTR::setCrashReportApplicationSpecificInformationToURL): Added a space after colon
425         (WebKit1 already had it right).
426
427         * DumpRenderTree/win/DumpRenderTree.cpp:
428         (sizeWebViewForCurrentTest):
429         (runTest):
430         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
431         (ResourceLoadDelegate::willSendRequest):
432         Changed Windows DumpRenderTree to also use URL in TestRunner.
433
434 2014-12-02  Daniel Bates  <dabates@apple.com>
435
436         [iOS] run-webkit-tests records most DumpRenderTree.app crashes as time-outs
437         https://bugs.webkit.org/show_bug.cgi?id=139143
438
439         Reviewed by David Kilzer.
440
441         Similar to the Windows-specific fix in <https://bugs.webkit.org/show_bug.cgi?id=37859>,
442         teach DumpRenderTree for iOS to write "#CRASHED" to the standard error stream when it
443         crashes. Run-webkit-tests will record as crashing the test associated with the
444         DumpRenderTree instance that wrote that string.
445
446         Currently almost all of the DumpRenderTree.app crashes are recorded by run-
447         webkit-tests as a time-out because ReportCrash(8) delays delivery of the
448         process exit notification for DumpRenderTree.app to LayoutTestRelay, which
449         launched DumpRenderTree.app, past the time-out time limit. Notice LayoutTestRelay
450         was launched by run-webkit-tests. So, run-webkit-tests kills LayoutTestRelay
451         (since it exceeded the time-out time limit) before it can inform rub-webkit-tests
452         about a crash.
453
454         Additionally, update the crash message format written to standard error when LayoutTestRelay
455         detects that {WebKitTestRunner, DumpRenderTree}.app crashed so as to be similar to the
456         crash message format used by WebKitTestRunner when it detects that the WebProcess crashed.
457         Then run-webkit-tests will collect the crash logs for {WebKitTestRunner, DumpRenderTree}.app
458         when they crash in their test machinery logic/UI process code.
459
460         * DumpRenderTree/mac/DumpRenderTree.mm:
461         (writeCrashedMessageOnFatalError): Added.
462         (dumpRenderTree): Register signal handler, writeCrashedMessageOnFatalError(), for signals:
463         SIGILL, SIGFPE, SIGBUS and SIGSEGV.
464         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
465         (-[LTRelayController didCrashWithMessage:]): Emit a crash message with a format
466         similar to the format used by WebKitTestRunner so that run-webkit-tests will collect
467         the crash logs for WebKitTestRunner/DumpRenderTree.app.
468         * Scripts/webkitpy/port/driver.py:
469         (Driver.__init__): Update comment.
470         (Driver._check_for_driver_crash): Ditto.
471         * Scripts/webkitpy/port/ios.py:
472         (IOSSimulatorPort): Add class constant SUBPROCESS_CRASH_REGEX, which represents a compiled
473         regular expression. This constant is used as an optimization to avoid compiling the same
474         regular expression across invocations of _get_crash_log().
475         (IOSSimulatorPort._get_crash_log): Modified to parse the WebKitTestRunner-like crash message
476         for the subprocess name and pid. Also, moved variables crash_log, crash_logs, and now to be
477         closer to where they are used.
478
479 2014-12-01  Anders Carlsson  <andersca@apple.com>
480
481         Remove WKBundleRemoveAllVisitedLinks
482         https://bugs.webkit.org/show_bug.cgi?id=139163
483
484         Reviewed by Sam Weinig.
485
486         Remove the call to WKBundleRemoveAllVisitedLinks and add a FIXME instead.
487
488         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
489         (WTR::InjectedBundle::beginTesting):
490         * WebKitTestRunner/TestInvocation.cpp:
491         (WTR::TestInvocation::invoke):
492
493 2014-12-02  Anders Carlsson  <andersca@apple.com>
494
495         Fix Windows build.
496
497         * DumpRenderTree/win/DumpRenderTree.cpp:
498         (setAlwaysAcceptCookies):
499
500 2014-12-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
501
502         [EFL] Remove edbus dependency from jhbuild
503         https://bugs.webkit.org/show_bug.cgi?id=139130
504
505         Reviewed by Gyuyoung Kim.
506
507         After http://trac.webkit.org/changeset/176555 we
508         don't need it anymore.
509
510         * efl/jhbuild.modules:
511
512 2014-12-02  Philippe Normand  <pnormand@igalia.com>
513
514         [jhbuild] wrong Dependencies path
515         https://bugs.webkit.org/show_bug.cgi?id=139176
516
517         Reviewed by Martin Robinson.
518
519         * Scripts/webkitpy/port/base.py:
520         (Port._should_use_jhbuild):
521
522 2014-12-02  Philippe Normand  <pnormand@igalia.com>
523
524         [GStreamer] Bump internal jhbuild versions to 1.4.4
525         https://bugs.webkit.org/show_bug.cgi?id=138866
526
527         Reviewed by Carlos Garcia Campos.
528
529         * gtk/jhbuild.modules:
530         * gtk/patches/gst-events-arent-gstobjects.patch: Removed.
531         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed.
532         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
533
534 2014-12-01  Commit Queue  <commit-queue@webkit.org>
535
536         Unreviewed, rolling out r176566.
537         https://bugs.webkit.org/show_bug.cgi?id=139124
538
539         It broke the GTK performance tests. (Requested by clopez on
540         #webkit).
541
542         Reverted changeset:
543
544         "[GTK] Use GMainLoopSource in WebKitTestRunner"
545         https://bugs.webkit.org/show_bug.cgi?id=138831
546         http://trac.webkit.org/changeset/176566
547
548 2014-11-29  Anders Carlsson  <andersca@apple.com>
549
550         Crash when calling WKPageClose on the originated page from within createNewPage callback
551         https://bugs.webkit.org/show_bug.cgi?id=139099
552         <rdar://problem/19052564>
553
554         Reviewed by Sam Weinig.
555
556         Add a test.
557
558         * TestWebKitAPI/PlatformWebView.h:
559         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
560         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp: Added.
561         (TestWebKitAPI::runJavaScriptAlert):
562         (TestWebKitAPI::createNewPage):
563         (TestWebKitAPI::TEST):
564         * TestWebKitAPI/Tests/WebKit2/close-from-within-create-page.html: Added.
565         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
566         (TestWebKitAPI::PlatformWebView::PlatformWebView):
567
568 2014-11-28  Commit Queue  <commit-queue@webkit.org>
569
570         Unreviewed, rolling out r176564.
571         https://bugs.webkit.org/show_bug.cgi?id=139093
572
573         massive failures on release test bot (Requested by philn on
574         #webkit).
575
576         Reverted changeset:
577
578         "[GStreamer] Bump internal jhbuild versions to 1.4.4"
579         https://bugs.webkit.org/show_bug.cgi?id=138866
580         http://trac.webkit.org/changeset/176564
581
582 2014-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
583
584         [GTK] Use GMainLoopSource in WebKitTestRunner
585         https://bugs.webkit.org/show_bug.cgi?id=138831
586
587         Reviewed by Sergio Villar Senin.
588
589         * WebKitTestRunner/InjectedBundle/TestRunner.h:
590         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
591         (WTR::TestRunner::platformInitialize):
592         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
593         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
594         (WTR::waitToDumpWatchdogTimerCallback): Deleted.
595         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
596         (WTR::TestController::notifyDone):
597         (WTR::TestController::platformRunUntil):
598         (WTR::cancelTimeout): Deleted.
599
600 2014-11-24  Philippe Normand  <pnormand@igalia.com>
601
602         [GStreamer] Bump internal jhbuild versions to 1.4.4
603         https://bugs.webkit.org/show_bug.cgi?id=138866
604
605         Reviewed by Carlos Garcia Campos.
606
607         * gtk/jhbuild.modules:
608         * gtk/patches/gst-events-arent-gstobjects.patch: Removed.
609         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed.
610         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
611
612 2014-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
613
614         [GTK] Use custom JavaScript instead of DBus to implement WebProcess tests
615         https://bugs.webkit.org/show_bug.cgi?id=138834
616
617         Reviewed by Sergio Villar Senin.
618
619         It makes everyting simpler and the tests run faster too, since we
620         don't need to spawn the private bus and wait until the DBus name
621         is registered. The web extension registers a new JavaSCript class
622         with a status method to run the tests, similar to the DBus
623         method. In the UI process side, tests use webkit_web_view_run_java_script()
624         instead of sending a DBus message.
625
626         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
627         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
628         (WebKitDOMNodeFilterTest::create):
629         (WebKitDOMNodeFilterTest::testTreeWalker):
630         (WebKitDOMNodeFilterTest::testNodeIterator):
631         (WebKitDOMNodeFilterTest::webPageFromArgs): Deleted.
632         (WebKitDOMNodeFilterTest::runTest): Deleted.
633         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
634         (WebKitDOMNodeTest::create):
635         (WebKitDOMNodeTest::testHierarchyNavigation):
636         (WebKitDOMNodeTest::testInsertion):
637         (WebKitDOMNodeTest::testTagNames):
638         (WebKitDOMNodeTest::webPageFromArgs): Deleted.
639         (WebKitDOMNodeTest::runTest): Deleted.
640         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
641         (WebKitDOMXPathNSResolverTest::create):
642         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
643         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
644         (WebKitDOMXPathNSResolverTest::webPageFromArgs): Deleted.
645         (WebKitDOMXPathNSResolverTest::runTest): Deleted.
646         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
647         (WebKitFrameTest::create):
648         (WebKitFrameTest::testMainFrame):
649         (WebKitFrameTest::testURI):
650         (WebKitFrameTest::testJavaScriptContext):
651         (WebKitFrameTest::webPageFromArgs): Deleted.
652         (WebKitFrameTest::runTest): Deleted.
653         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
654         (testWebKitDOMNodeHierarchyNavigation):
655         (testWebKitDOMNodeInsertion):
656         (testWebKitDOMNodeTagNames):
657         (beforeAll):
658         (afterAll):
659         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp:
660         (runTest):
661         (beforeAll):
662         (afterAll):
663         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
664         (testWebKitDOMXPathNSResolverNative):
665         (testWebKitDOMXPathNSResolverCustom):
666         (beforeAll):
667         (afterAll):
668         (runTest): Deleted.
669         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp:
670         (webkitFrameTestRun):
671         (beforeAll):
672         (afterAll):
673         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
674         (testsMap):
675         (WebProcessTest::add):
676         (WebProcessTest::create):
677         (runTest):
678         (windowObjectClearedCallback):
679         (webkit_web_extension_initialize):
680         (methodCallCallback): Deleted.
681         (webkit_web_extension_initialize_with_user_data): Deleted.
682         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
683         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp: Removed.
684         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h: Removed.
685         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
686         (WebViewTest::runWebProcessTest):
687         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
688
689 2014-11-28  Csaba Osztrogonác  <ossy@webkit.org>
690
691         [EFL] libseccomp should pick up CC environment variable to be conform to other jhbuild modules
692         https://bugs.webkit.org/show_bug.cgi?id=139086
693
694         Reviewed by Gyuyoung Kim.
695
696         * efl/jhbuild.modules:
697         * efl/patches/libseccomp-pick-up-CC.patch: Added.
698
699 2014-11-28  Bartlomiej Gajda  <b.gajda@samsung.com>
700
701         [EFL] Add warning if CMake version is too old for building with ninja.
702         https://bugs.webkit.org/show_bug.cgi?id=139055
703
704         Reviewed by Gyuyoung Kim.
705
706         CMake need to be >= 2.8.10 to build WebKit using ninja, some repos don't have
707         that version in their repositories.
708
709         * efl/install-dependencies:
710
711 2014-11-28  Andrzej Badowski  <a.badowski@samsung.com>
712
713         [ATK] Allowing the use of AccessibilityUIElement::columnHeaders method for table.
714         https://bugs.webkit.org/show_bug.cgi?id=139044
715
716         Reviewed by Chris Fleizach.
717
718         ATK method AccessibilityUIElement::columnHeaders currently focused only on the object table cell.
719         The proposed solution will enable the use of this method for the object table.
720         Existing test shows the result.
721
722         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
723         (WTR::AccessibilityUIElement::columnHeaders):
724
725 2014-11-27  Ryuan Choi  <ryuan.choi@navercorp.com>
726
727         [EFL] Remove E_Dbus dependency
728         https://bugs.webkit.org/show_bug.cgi?id=136355
729
730         Reviewed by Gyuyoung Kim.
731
732         * MiniBrowser/efl/CMakeLists.txt: Removed E_DBUS includes.
733
734 2014-11-26  Akos Kiss  <akiss@inf.u-szeged.hu>
735
736         [EFL][GTK] Bump up FDE relocation fixing patch to version accepted to LLVM trunk.
737         https://bugs.webkit.org/show_bug.cgi?id=139047
738
739         Reviewed by Carlos Garcia Campos.
740
741         * efl/jhbuild.modules:
742         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
743         * efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.
744         * gtk/jhbuild-optional.modules:
745         * gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
746         * gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.
747
748 2014-11-25  Tanay C  <tanay.c@samsung.com>
749
750         [GTK] Minibrowser: Add support for zoom using Control Key + Mouse scroll
751         https://bugs.webkit.org/show_bug.cgi?id=138090
752
753         Reviewed by Carlos Garcia Campos.
754
755         * MiniBrowser/gtk/BrowserWindow.c: Implementing zoom using Cntrl + Mouse scroll
756         (browserWindowZoomIn): Added.
757         (browserWindowZoomOut): Added.
758         (scrollEventCallback): Added.
759         (zoomInCallback): Modified.
760         (zoomOutCallback): Modified.
761         (browserWindowConstructed): Modified.
762
763 2014-11-25  Csaba Osztrogonác  <ossy@webkit.org>
764
765         [EFL] REGRESSION(r176514): It made performance tests fail
766         https://bugs.webkit.org/show_bug.cgi?id=139037
767
768         Reviewed by Gyuyoung Kim.
769
770         * Scripts/webkitpy/port/efl.py:
771         (EflPort.setup_environ_for_server): Pass ACCESSIBILITY_EAIL_LIBRARY_PATH environment variable to WTR.
772         * efl/jhbuildrc: Set ACCESSIBILITY_EAIL_LIBRARY_PATH to point to DependenciesEFL/lib/libeail.so
773         only if ACCESSIBILITY_EAIL_LIBRARY_PATH isn't already set and DependenciesEFL/lib/libeail.so exists.
774
775 2014-11-24  Michael Catanzaro  <mcatanzaro@igalia.com>
776
777         [GTK] update-webkitgtk-libs fails to build fontconfig
778         https://bugs.webkit.org/show_bug.cgi?id=139032
779
780         Reviewed by Martin Robinson.
781
782         On Fedora, if docbook-utils is installed but docbook-utils-pdf is not,
783         fontconfig will try to generate documentation and fail.
784
785         * gtk/install-dependencies:
786
787 2014-11-24  Carlos Garcia Campos  <cgarcia@igalia.com>
788
789         Unreviewed. Fix GTK+ make distcheck.
790
791         * gtk/manifest.txt: Remove deleted files.
792
793 2014-11-24  Krzysztof Czech  <k.czech@samsung.com>
794
795         [EFL] Utilize Eail library to support accessibility in EFL
796         https://bugs.webkit.org/show_bug.cgi?id=137742
797
798         Reviewed by Gyuyoung Kim.
799
800         Eail, atk-bridge, at-spi2 are not mandatory modules for webkit-efl. They are rather optional.
801
802         * efl/jhbuild-optional.modules: Added.
803         * efl/jhbuild.modules:
804
805 2014-11-24  Carlos Garcia Campos  <cgarcia@igalia.com>
806
807         [GTK] WebKitWebView is created with the wrong web context when using webkit_web_view_new_with_related_view()
808         https://bugs.webkit.org/show_bug.cgi?id=139023
809
810         Reviewed by Sergio Villar Senin.
811
812         Rename WebKitWebView/default-context as WebKitWebView/web-context
813         and check we are always using the right context for new web views.
814
815         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
816         (testWebViewWebContext):
817         (beforeAll):
818         (testWebViewDefaultContext): Deleted.
819
820 2014-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
821
822         [GTK] Add API to override the default local storage directory
823         https://bugs.webkit.org/show_bug.cgi?id=138828
824
825         Reviewed by Gustavo Noronha Silva.
826
827         Add test to check that the local storage directory is created at
828         the path given on construction.
829
830         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
831         (testWebContextConfiguration):
832         (beforeAll):
833         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
834         (Test::Test):
835         (Test::~Test): Deleted.
836
837 2014-11-21  Zalan Bujtas  <zalan@apple.com>
838
839         Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser.
840         https://bugs.webkit.org/show_bug.cgi?id=138981
841
842         Reviewed by Simon Fraser.
843
844         * MiniBrowser/mac/SettingsController.h:
845         * MiniBrowser/mac/SettingsController.m:
846         (-[SettingsController _populateMenu]):
847         (-[SettingsController validateMenuItem:]):
848         (-[SettingsController toggleSimpleLineLayoutDebugBordersEnabled:]):
849         (-[SettingsController simpleLineLayoutDebugBordersEnabled]):
850         * MiniBrowser/mac/WK1BrowserWindowController.m:
851         (-[WK1BrowserWindowController didChangeSettings]):
852         * MiniBrowser/mac/WK2BrowserWindowController.m:
853         (-[WK2BrowserWindowController didChangeSettings]):
854
855 2014-11-21  Csaba Osztrogonác  <ossy@webkit.org>
856
857         Remove http lock code from webkitperl
858         https://bugs.webkit.org/show_bug.cgi?id=138959
859
860         Reviewed by Alexey Proskuryakov.
861
862         * Scripts/webkitperl/httpd.pm:
863         (cleanUp):
864         (extractLockNumber): Deleted.
865         (getLockFiles): Deleted.
866         (getNextAvailableLockNumber): Deleted.
867         (getLockNumberForCurrentRunning): Deleted.
868         (waitForHTTPDLock): Deleted.
869         (scheduleHttpTesting): Deleted.
870         (getWaitTime): Deleted.
871
872 2014-11-20  Hunseop Jeong  <hs85.jeong@samsung.com>
873
874         [EFL] The option value of fixed layout is false in MiniBrowser
875         https://bugs.webkit.org/show_bug.cgi?id=138830
876
877         Reviewed by Gyuyoung Kim.
878
879         Changed the option value of fixed layout to EINA_TRUE in MiniBrowser.
880
881         * MiniBrowser/efl/main.c:
882
883 2014-11-20  Adrian Perez de Castro  <aperez@igalia.com>
884
885         [GTK] Provide convenience API in DOM bindings to post messages to user message handlers
886         https://bugs.webkit.org/show_bug.cgi?id=138871
887
888         Reviewed by Carlos Garcia Campos.
889
890         Add a test case for the convenience API for posting user messages
891         added to the DOM bindings.
892
893         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
894         (testUserContentManagerMessageFromConvenienceDOMBindings):
895         (beforeAll):
896         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
897         (documentLoadedCallback):
898
899 2014-11-19  Dana Burkart  <dburkart@apple.com>
900
901         Work around the fact that different masters may have different names for their codebases.
902         https://bugs.webkit.org/show_bug.cgi?id=138878
903
904         Reviewed by Mark Rowe.
905
906         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
907         (parseRevisionProperty): Changed.
908         Take a "fallback key" in addition to the primary key, so we can deal with inconsistencies in
909         opensource / internal codebase naming convention.
910
911 2014-11-19  Chris Fleizach  <cfleizach@apple.com>
912
913         AX: Screen braille input doesn't work on forms.
914         https://bugs.webkit.org/show_bug.cgi?id=138804
915
916         Unreviewed build fix.
917
918         * DumpRenderTree/AccessibilityUIElement.cpp:
919         (AccessibilityUIElement::setValue):
920
921 2014-11-19  Chris Fleizach  <cfleizach@apple.com>
922
923         AX: Screen braille input doesn't work on forms.
924         https://bugs.webkit.org/show_bug.cgi?id=138804
925
926         Reviewed by Mario Sanchez Prada.
927
928         Add a method to setValue through the AX API in DRT.
929
930         * DumpRenderTree/AccessibilityUIElement.cpp:
931         (setValueCallback):
932         (AccessibilityUIElement::getJSClass):
933         * DumpRenderTree/AccessibilityUIElement.h:
934         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
935         (AccessibilityUIElement::setValue):
936         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
937         (AccessibilityUIElement::setValue):
938
939 2014-11-18  Csaba Osztrogonác  <ossy@webkit.org>
940
941         Remove the WinCairo buildbot
942         https://bugs.webkit.org/show_bug.cgi?id=138805
943
944         Reviewed by Alex Christensen.
945
946         * BuildSlaveSupport/build.webkit.org-config/config.json:
947         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
948         (appendCustomBuildFlags):
949         * BuildSlaveSupport/test-result-archive:
950         (archiveTestResults):
951
952 2014-11-18  Daniel Bates  <dabates@apple.com>
953
954         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
955         SPI are not available in public SDK
956         https://bugs.webkit.org/show_bug.cgi?id=138802
957
958         Reviewed by David Kilzer.
959
960         Include header MachVMSPI.h instead of including the private header mach/mach_vm.h.
961
962         * DumpRenderTree/mac/CheckedMalloc.cpp:
963
964 2014-11-18  Carlos Garcia Campos  <cgarcia@igalia.com>
965
966         Unreviewed. Fix after /webkit2/WebKitWebView/default-context r176256.
967
968         Forgot to fix this test before landing.
969
970         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
971         (testWebViewDefaultContext):
972
973 2014-11-18  Carlos Garcia Campos  <cgarcia@igalia.com>
974
975         [GTK] Add API to create a WebKitWebContext
976         https://bugs.webkit.org/show_bug.cgi?id=138826
977
978         Reviewed by Gustavo Noronha Silva.
979
980         Use a different WebKitWebContext for every test to ensure test
981         cases are independent to each other. Tests using DBus to
982         communicate with the injected bundle extension now use a unique
983         name for the well known DBus name.
984
985         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
986         (beforeAll): Remove comment about the order of the tests and
987         move the success test before the failed one now that tests don't
988         depend on each others.
989         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
990         (beforeAll): Remove call to set the web extensions directory,
991         since this is now done for all test in the Test constructor.
992         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
993         (beforeAll): Do not create a temporary directory, a temporary data
994         directory is now created for all tests.
995         (afterAll):
996         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
997         (testWebKitDOMNodeHierarchyNavigation): Pass the web extension ID
998         to the web process test runner.
999         (testWebKitDOMNodeInsertion): Ditto.
1000         (testWebKitDOMNodeTagNames): Ditto.
1001         (beforeAll): Remove call to set the web extensions directory.
1002         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp:
1003         (runTest): Pass the web extension ID to the web process test runner.
1004         (beforeAll): Remove call to set the web extensions directory.
1005         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
1006         (runTest): Pass the web extension ID to the web process test runner.
1007         (beforeAll): Remove call to set the web extensions directory.
1008         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1009         (createFileAtDestination): Use Test::dataDirectory() as base dir
1010         for temporary files.
1011         (beforeAll): Do not create a temporary directory.
1012         (afterAll):
1013         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp:
1014         (webkitFrameTestRun): Pass the web extension ID to the web process
1015         test runner.
1016         (beforeAll): Remove call to set the web extensions directory.
1017         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1018         (beforeAll): Remove call to set the web extensions directory.
1019         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
1020         (testProcessPerWebView): Use local member instead of global variable.
1021         (testMultiprocessWebViewCreateReadyClose): Ditto.
1022         (beforeAll): Do not connect to initialize-web-extensions, Test now
1023         connects to the signal for all tests and calls a virtual method
1024         that test can override.
1025         (afterAll):
1026         (initializeWebExtensions): Deleted.
1027         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
1028         (testPrintOperationPrint): Use Test::dataDirectory() as base dir
1029         for temporary files.
1030         (beforeAll): Do not create a temporary directory.
1031         (afterAll):
1032         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1033         (beforeAll): Remove call to set the web extensions directory.
1034         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1035         (beforeAll): Remove comment about the tests order.
1036         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
1037         (testWebExtensionGetTitle): Build the DBus service name using the
1038         web extension ID.
1039         (testDocumentLoadedSignal): Ditto.
1040         (testWebKitWebViewProcessCrashed): Ditto.
1041         (testWebExtensionIsolatedWorld): Ditto.
1042         (beforeAll): Remove initialization-user-data test, since now all
1043         tests are passing user data to the web extension.
1044         (testWebExtensionInitializationUserData): Deleted.
1045         (initializeWebExtensions): Deleted.
1046         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1047         (testSetDirectory): Use the web context member inherited from Test.
1048         (testClearDatabase): Ditto.
1049         (testGetFaviconURI): Ditto.
1050         (beforeAll): Do not create a temporary directory.
1051         (afterAll):
1052         (webkitFaviconDatabaseFinalizedCallback): Deleted.
1053         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
1054         (UserContentManagerTest::UserContentManagerTest):
1055         (beforeAll): Remove call to set the web extensions directory.
1056         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1057         (testWebContextDefault): Check also that a newly create web
1058         context is not the default web context.
1059         (testWebContextSpellChecker): Use the web context member inherited
1060         from Test.
1061         (testWebContextLanguages): Ditto.
1062         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1063         (methodCallCallback): Remove GetInitializationUserData method.
1064         (webkit_web_extension_initialize_with_user_data): Always create
1065         the DBus name using the user data provided.
1066         (makeBusName): Deleted.
1067         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
1068         (webkit_web_extension_initialize_with_user_data): Create the DBus
1069         name using the user data provided.
1070         (webkit_web_extension_initialize): Deleted.
1071         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:
1072         (Test::dataDirectory): Return the temporary data directory.
1073         (removeNonEmptyDirectory): Also remove directories recursively.
1074         (main): Remove the disk cache directory initialization, since this
1075         is now done in the Test constructor.
1076         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1077         (Test::initializeWebExtensionsCallback): Call the virtual method
1078         initializeWebExtensions()
1079         (Test::Test): Create a new WebKitWebContext and initialize it.
1080         (Test::~Test): Disconnect initialize-web-extensions signal.
1081         (Test::initializeWebExtensions): Set the web extensions directory
1082         and user data.
1083         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp:
1084         (WebProcessTestRunner::~WebProcessTestRunner): Use nullptr.
1085         (WebProcessTestRunner::runTest): Build the DBus proxy using a
1086         unique name created with the Test web extension ID.
1087         (WebProcessTestRunner::proxy): Deleted.
1088         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h:
1089         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1090         (WebViewTest::WebViewTest): Create the web view with the Test web
1091         context.
1092         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h: Add optional user
1093         content manager parameter to the constructor.
1094
1095 2014-11-18  ChangSeok Oh  <changseok.oh@collabora.com>
1096
1097         [GTK] Mesa build fails over llvm-3.5
1098         https://bugs.webkit.org/show_bug.cgi?id=138825
1099
1100         Reviewed by Gustavo Noronha Silva.
1101
1102         OwningPtr.h have been removed in llvm-3.5. Instread we should use std::unique_ptr for mesa build.
1103
1104         * gtk/jhbuild.modules:
1105         * gtk/patches/mesa-gallivm-Fix-build-after-LLVM-commit-211259.patch: Added.
1106
1107 2014-11-17  Daniel Bates  <dabates@apple.com>
1108
1109         Unreviewed, rolling out r176232.
1110
1111         Broke the Mac build. Will investigate offline.
1112
1113         Reverted changeset:
1114
1115         "[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions,
1116         MobileGestalt"
1117         https://bugs.webkit.org/show_bug.cgi?id=138802
1118         http://trac.webkit.org/changeset/176232
1119
1120 2014-11-17  Daniel Bates  <dabates@apple.com>
1121
1122         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
1123         SPI are not available in public SDK
1124         https://bugs.webkit.org/show_bug.cgi?id=138802
1125
1126         Reviewed by David Kilzer.
1127
1128         Include header MachVMSPI.h instead of including the private header mach/mach_vm.h.
1129
1130         * DumpRenderTree/mac/CheckedMalloc.cpp:
1131
1132 2014-11-17  Jake Nielsen  <jacob_nielsen@apple.com>
1133
1134         Having 30+ flaky failures breaks EWS
1135         https://bugs.webkit.org/show_bug.cgi?id=138743
1136
1137         Reviewed by Alexey Proskuryakov.
1138
1139         Adds tests to ensure that the problem has been solved.
1140         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1141         (test_first_failure_limit):
1142         (test_first_failure_limit_with_some_tree_redness):
1143         (test_second_failure_limit):
1144         (test_tree_failure_limit_with_patch_that_potentially_fixes_some_redness):
1145         (test_first_and_second_failure_limit):
1146         (test_first_and_clean_failure_limit):
1147         (test_first_second_and_clean_failure_limit):
1148         (test_very_red_tree_retry): Deleted.
1149         Really this was renamed to test_first_second_and_clean_failure_limit.
1150         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1151         Makes the appropriate changes to PatchAnalysisTask to make sure that
1152         even when the first test run hits the failure limit, it will still try
1153         a second run.
1154         (PatchAnalysisTask._results_failed_different_tests):
1155         (PatchAnalysisTask._test_patch):
1156         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try): Deleted.
1157
1158 2014-11-17  Ting-Wei Lan  <lantw44@gmail.com>
1159
1160         [GTK] Add library search paths from LDFLAGS before pkg-config --libs
1161         https://bugs.webkit.org/show_bug.cgi?id=136018
1162
1163         Reviewed by Carlos Garcia Campos.
1164
1165         It is possible that the order of -L arguments in the output of
1166         pkg-config is wrong, which causes the linker to find the wrong
1167         version (usually older version) of libraries when running
1168         gtkdoc-scangobj.
1169
1170         * gtk/gtkdoc.py:
1171         (GTKDoc._run_gtkdoc_scangobj):
1172
1173 2014-11-17  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1174
1175         Bump EFL version to 1.12.0
1176         https://bugs.webkit.org/show_bug.cgi?id=138733
1177
1178         Reviewed by Gyuyoung Kim.
1179
1180         * efl/jhbuild.modules:
1181
1182 2014-11-16  Joanmarie Diggs  <jdiggs@igalia.com>
1183
1184         AX: [ATK] Expose the blockquote element using ATK_ROLE_BLOCK_QUOTE
1185         https://bugs.webkit.org/show_bug.cgi?id=138771
1186
1187         Reviewed by Chris Fleizach.
1188
1189         Add mapping for ATK_ROLE_BLOCK_QUOTE in roleToString()
1190
1191         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1192
1193 2014-11-15  Joanmarie Diggs  <jdiggs@igalia.com>
1194
1195         AX: [ATK] Video and audio elements should be exposed using ATK's video and audio roles.
1196         https://bugs.webkit.org/show_bug.cgi?id=138767
1197
1198         Reviewed by Chris Fleizach.
1199
1200         Add mappings for ATK_ROLE_AUDIO and ATK_ROLE_VIDEO to roleToString().
1201
1202         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1203
1204 2014-11-14  Alexey Proskuryakov  <ap@apple.com>
1205
1206         Add shortcut macros to Mac TestExpectations
1207         https://bugs.webkit.org/show_bug.cgi?id=138729
1208
1209         Reviewed by Simon Fraser.
1210
1211         * Scripts/webkitpy/port/mac.py: (MacPort.configuration_specifier_macros):
1212         Add version macros for current OS versions.
1213
1214 2014-11-13  Alexey Proskuryakov  <ap@apple.com>
1215
1216         https://bugs.webkit.org/show_bug.cgi?id=138628
1217         A patch that doesn't apply is stuck in commit queue
1218
1219         Rubber-stamped by David Kilzer.
1220
1221         This also hopefully fixes other issues:
1222         - a patch that has cq+ flag set by a non-committer kills commit queue;
1223         - EWS never reports failing tests, and keeps spinning instead.
1224
1225         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1226         (Bugzilla.set_flag_on_attachment):
1227         (Bugzilla.obsolete_attachment):
1228         Apply the fix from r174797 to more places.
1229
1230 2014-11-13  Dan Bernstein  <mitz@apple.com>
1231
1232         Policy client not called for navigations through the page cache
1233         https://bugs.webkit.org/show_bug.cgi?id=138703
1234
1235         Reviewed by Alexey Proskuryakov.
1236
1237         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
1238         (-[DecidePolicyForPageCacheNavigationDelegate webView:didFinishNavigation:]):
1239         (-[DecidePolicyForPageCacheNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1240
1241 2014-11-13  Joanmarie Diggs  <jdiggs@igalia.com>
1242
1243         AX: [ATK] Do not return ATK_ROLE_UNKNOWN for null or otherwise invalid accessible objects
1244         https://bugs.webkit.org/show_bug.cgi?id=137867
1245
1246         Reviewed by Chris Fleizach.
1247
1248         Add ATK_ROLE_INVALID to roleToString. Remove the null AtkRole check in
1249         AccessibilityUIElement::role: ATK_ROLE_INVALID = 0, and we need to be
1250         able to test for the presence of ATK_ROLE_INVALID.
1251
1252         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1253         (WTR::AccessibilityUIElement::role):
1254
1255 2014-11-13  Juergen Ributzka  <juergen@apple.com>
1256
1257         Update the "combineModules" script to handel more LLVM metadata.
1258         https://bugs.webkit.org/show_bug.cgi?id=138514
1259
1260         Reviewed by Filip Pizlo.
1261
1262         * ReducedFTL/combineModules.rb:
1263
1264 2014-11-13  Myles C. Maxfield  <mmaxfield@apple.com>
1265
1266         Allow constructing a base PassRef with a derived Ref
1267         https://bugs.webkit.org/show_bug.cgi?id=138701
1268
1269         Reviewed by Andreas Kling
1270
1271         * TestWebKitAPI/Tests/WTF/Ref.cpp:
1272         (TestWebKitAPI::passWithPassRef):
1273         (TestWebKitAPI::passWithPassRefPtr):
1274         (TestWebKitAPI::TEST):
1275
1276 2014-11-05  Ada Chan  <adachan@apple.com>
1277
1278         Implement new plug-in API for muting plug-ins
1279         https://bugs.webkit.org/show_bug.cgi?id=138105
1280
1281         Reviewed by Anders Carlsson.
1282
1283         Add a new plug-in test for the mute API.
1284
1285         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1286         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SetMuted.cpp: Added.
1287         (SetMuted::SetMuted):
1288         (SetMuted::isMuted):
1289         (SetMuted::cachedIsMuted):
1290         (SetMuted::ScriptableObject::hasProperty):
1291         (SetMuted::ScriptableObject::getProperty):
1292         (SetMuted::ScriptableObject::pluginTest):
1293         (SetMuted::NPP_New):
1294         (SetMuted::NPP_GetValue):
1295         (SetMuted::NPP_SetValue):
1296
1297 2014-11-12  Philippe Normand  <pnormand@igalia.com>
1298
1299         Unreviewed, GTK gardening.
1300
1301         * Scripts/run-gtk-tests:
1302         (TestRunner): Skip the UserMediaBasic test because it depends on
1303         constraints validation which is going to be fixed in bug #136449.
1304
1305 2014-11-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1306
1307         [GTK] Expose user script messages to GObject DOM bindings
1308         https://bugs.webkit.org/show_bug.cgi?id=138411
1309
1310         Reviewed by Philippe Normand.
1311
1312         Add a test case to check that user script messages sent using the
1313         DOM bindings API are also received in the UI process.
1314
1315         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
1316         (UserScriptMessageTest::waitUntilMessageReceived):
1317         (UserScriptMessageTest::postMessageAndWaitUntilReceived):
1318         (testUserContentManagerScriptMessageFromDOMBindings):
1319         (beforeAll):
1320         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1321         (documentLoadedCallback):
1322
1323 2014-11-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1324
1325         Unreviewed. Fix GTK+ clean build after r175930.
1326
1327         Partial rollout of r175930 to not build the new unit test that
1328         broke clean builds in GTK+ port.
1329
1330         * TestWebKitAPI/PlatformGTK.cmake:
1331
1332 2014-09-01  Philippe Normand  <pnormand@igalia.com>
1333
1334         [WK2] UserMediaClient support
1335         https://bugs.webkit.org/show_bug.cgi?id=123158
1336
1337         Reviewed by Benjamin Poulain.
1338
1339         Simple API test for the UserMedia permission request API. The
1340         required test infrastructure is also added, inspired by the
1341         Geolocation infrastructure.
1342
1343         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: New API test for UserMedia
1344         Permission request.
1345         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp: Added.
1346         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
1347         (TestWebKitAPI::TEST):
1348         * TestWebKitAPI/Tests/WebKit2/getUserMedia.html: Added.
1349         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: new
1350         helper method to set the permission request result without user interaction.
1351         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Ditto.
1352         (WTR::InjectedBundle::setUserMediaPermission):
1353         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Ditto.
1354         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Ditto.
1355         (WTR::TestRunner::setUserMediaPermission):
1356         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
1357         * WebKitTestRunner/TestController.cpp:
1358         (WTR::decidePolicyForUserMediaPermissionRequest): Permission
1359         request handler.
1360         (WTR::TestController::createOtherPage): Enable the new UserMedia
1361         permission request handler.
1362         (WTR::TestController::createWebViewWithOptions): Ditto.
1363         (WTR::TestController::resetPreferencesToConsistentValues): Enable
1364         MediaStream support, this is needed for getUserMedia.
1365         (WTR::TestController::resetStateToConsistentValues): clear
1366         UserMedia permissions list and flags.
1367         (WTR::TestController::setUserMediaPermission): Set permission
1368         request result and distpatch it.
1369         (WTR::TestController::handleUserMediaPermissionRequest): Save
1370         request and dispatch it.
1371         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
1372         Dispatch cached permission requests.
1373         * WebKitTestRunner/TestController.h:
1374         * WebKitTestRunner/TestInvocation.cpp:
1375         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1376
1377 2014-11-11  David Kilzer  <ddkilzer@apple.com>
1378
1379         webkit-patch --suggest-reviewers is broken with newer versions of git
1380         <http://webkit.org/b/138627>
1381
1382         Reviewed by Michael Saboff with feedback from Daniel Bates.
1383
1384         * Scripts/webkitpy/common/checkout/scm/git.py:
1385         (Git._changes_files_for_commit): Strip blank lines instead of
1386         assuming there is always a blank line at the beginning of the
1387         list.
1388
1389 2014-11-11  Alexey Proskuryakov  <ap@apple.com>
1390
1391         DRT and WKTR touch disk cache
1392         https://bugs.webkit.org/show_bug.cgi?id=138622
1393
1394         Reviewed by Geoffrey Garen.
1395
1396         * DumpRenderTree/mac/DumpRenderTree.mm: (prepareConsistentTestingEnvironment):
1397         Set a shared cache before calling -_switchNetworkLoaderToNewTestingSession, not after,
1398         because this function uses the shared cache.
1399
1400         * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformInitializeContext):
1401         Create an empty shared cache to prevent a default one from being created on disk.
1402
1403 2014-10-07  Sergio Villar Senin  <svillar@igalia.com>
1404
1405         [CSS Grid Layout] Limit the size of explicit/implicit grid
1406         https://bugs.webkit.org/show_bug.cgi?id=136217
1407
1408         Reviewed by Andreas Kling.
1409
1410         Added a new unit test for the CSS parser. Right now it only checks
1411         that we properly clamp the maximum number of tracks on a grid to a
1412         maximum of 1 million.
1413
1414         * TestWebKitAPI/CMakeLists.txt:
1415         * TestWebKitAPI/PlatformEfl.cmake:
1416         * TestWebKitAPI/PlatformGTK.cmake:
1417         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1418         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp: Added.
1419         (TestWebKitAPI::computeNumberOfTracks): Helper function.
1420         (TestWebKitAPI::TEST): Added a
1421         CSSPropertyParserTest.GridTrackLimits test case.
1422
1423 2014-11-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1424
1425         webkitpy test fix after r175867
1426         https://bugs.webkit.org/show_bug.cgi?id=138607
1427
1428         Reviewed by Philippe Normand.
1429
1430         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1431         (GDBCrashLogGeneratorTest.test_generate_crash_log):
1432
1433 2014-11-10  Philippe Normand  <pnormand@igalia.com>
1434
1435         webkitpy: demangle C++ symbols from crash log stderr
1436         https://bugs.webkit.org/show_bug.cgi?id=138565
1437
1438         Reviewed by Alexey Proskuryakov.
1439
1440         * Scripts/webkitpy/port/linux_get_crash_log.py:
1441         (GDBCrashLogGenerator.generate_crash_log): Process stderr output
1442         with c++filt.
1443
1444 2014-11-10  Philippe Normand  <pnormand@igalia.com>
1445
1446         [GTK] fix up the GDB backtrace report tool
1447         https://bugs.webkit.org/show_bug.cgi?id=138564
1448
1449         Reviewed by Carlos Garcia Campos.
1450
1451         * Scripts/webkitpy/port/gtk.py:
1452         (GtkPort._get_crash_log): Match the process name reported by the
1453         driver with the GTK port WebProcess executable filename.
1454         * Scripts/webkitpy/port/linux_get_crash_log.py:
1455         (GDBCrashLogGenerator._get_gdb_output): Invoke gdb for the crashed
1456         program.
1457         (GDBCrashLogGenerator.generate_crash_log): Use %E in the core
1458         pattern to workaround the 16 characters size limit of %e.
1459
1460 2014-11-10  Conrad Shultz  <conrad_shultz@apple.com>
1461
1462         Unreviewed, moved myself to the list of committers.
1463
1464         * Scripts/webkitpy/common/config/contributors.json:
1465
1466 2014-11-10  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1467
1468         [EFL] Fix the test font path after r175555.
1469
1470         Reviewed by Csaba Osztrogonác.
1471
1472         * WebKitTestRunner/PlatformEfl.cmake: Dependencies -> DependenciesEFL
1473
1474 2014-11-10  Akos Kiss  <akiss@inf.u-szeged.hu>
1475
1476         Fix the exception fuzz helper to generate targets in the correct range
1477         https://bugs.webkit.org/show_bug.cgi?id=138544
1478
1479         Reviewed by Filip Pizlo.
1480
1481         Currently, the script generates exception fuzz targets in the range of
1482         0..($checkCount-1). However, target 0 is never hit, while target 1 is
1483         always outside of the outermost try block of the tests, which therefore
1484         prints unexpected output and results in false failures when fired at.
1485         Additionally, target $checkCount is never generated.
1486
1487         This patch fixes the script to generate targets in the range of
1488         2..$checkCount.
1489
1490         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
1491
1492 2014-11-09  Csaba Osztrogonác  <ossy@webkit.org>
1493
1494         make-passwords-json.py should generarate everything needed for testing
1495         https://bugs.webkit.org/show_bug.cgi?id=138503
1496
1497         Reviewed by Ryosuke Niwa.
1498
1499         * BuildSlaveSupport/build.webkit.org-config/make_passwords_json.py:
1500         Renamed from make-passwords-json.py to be able included from mastercfg_unittest.py.
1501         Additionally generate auth.json, credentials.cfg and committers.cfg too.
1502         (create_mock_slave_passwords_dict): Moved from mastercfg_unittest.py
1503         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1504         (BuildBotConfigLoader._mock_open): Use make_passwords_json.create_mock_slave_passwords_dict() to avoid duplication.
1505         (BuildBotConfigLoader._create_mock_passwords_dict): Deleted.
1506
1507 2014-11-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1508
1509         [GTK] generate-gtkdoc should ignore invalid files
1510         https://bugs.webkit.org/show_bug.cgi?id=138542
1511
1512         Reviewed by Darin Adler.
1513
1514         * gtk/generate-gtkdoc:
1515         (files_to_ignore.file_should_be_ignored): Return True to ignore
1516         invalid files.
1517
1518 2014-11-08  Alexey Proskuryakov  <ap@apple.com>
1519
1520         Delete cookies between tests
1521         https://bugs.webkit.org/show_bug.cgi?id=138528
1522
1523         Reviewed by Sam Weinig.
1524
1525         * DumpRenderTree/mac/DumpRenderTree.mm:
1526         (resetWebPreferencesToConsistentValues):
1527         * WebKitTestRunner/TestController.cpp:
1528         (WTR::TestController::resetPreferencesToConsistentValues):
1529         Do it.
1530
1531         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1532         (WTR::InjectedBundle::beginTesting):
1533         Added a FIXME.
1534
1535 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1536
1537         [GTK] Run layout tests using the network process
1538         https://bugs.webkit.org/show_bug.cgi?id=138428
1539
1540         Reviewed by Martin Robinson.
1541
1542         Shared secondary process is the default in the GTK+ port, but we
1543         should run the tests using the network process to ensure
1544         everything works with the network process. In the future, the
1545         shared secondary process model might be a special case of multiple
1546         processes with 1 as maximum number of processes, but always using
1547         the network process.
1548
1549         * WebKitTestRunner/TestController.cpp:
1550         (WTR::TestController::initialize):
1551
1552 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1553
1554         [GTK] Allow to create a view with a related page in WTR
1555         https://bugs.webkit.org/show_bug.cgi?id=138501
1556
1557         Reviewed by Martin Robinson.
1558
1559         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
1560         (TestWebKitAPI::PlatformWebView::PlatformWebView): Pass nullptr as
1561         related page to WKViewCreate.
1562         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1563         (WTR::PlatformWebView::PlatformWebView): Pass the given related
1564         page to WKViewCreate.
1565
1566 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1567
1568         WTR crashes after running a test when NetworkProcess enabled
1569         https://bugs.webkit.org/show_bug.cgi?id=138500
1570
1571         Reviewed by Alexey Proskuryakov.
1572
1573         WebNotificationProvider destructor is calling
1574         WKNotificationManagerSetProvider, but m_notificationManager is
1575         null because removeNotificationManager was already called.
1576
1577         * WebKitTestRunner/WebNotificationProvider.cpp:
1578         (WTR::WebNotificationProvider::~WebNotificationProvider): Check
1579         m_notificationManager is not null before calling WKNotificationManagerSetProvider.
1580
1581 2014-11-06  Jake Nielsen  <jacob_nielsen@apple.com>
1582
1583         Remove duplicate code from PatchAnalysisTask._test_patch and fix bug
1584         regarding incorrect call to PatchAnalysisTask.report_failure
1585         https://bugs.webkit.org/show_bug.cgi?id=138229
1586
1587         Reviewed by Daniel Bates.
1588
1589         * Scripts/webkitpy/common/net/layouttestresults.py:
1590         Makes sure test_results returns a list.
1591         (LayoutTestResults.test_results):
1592         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1593         Makes unit tests also check to make sure
1594         task.results_from_patch_test_run() and
1595         task.results_from_test_run_without_patch return instances of
1596         LayoutTestResults.
1597         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
1598         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1599         Condenses duplicate code into _should_defer_patch_or_throw, and
1600         removes the now-unused _clean_tree_results member.
1601         (PatchAnalysisTask.__init__):
1602         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try):
1603         (PatchAnalysisTask._should_defer_patch_or_throw):
1604         (PatchAnalysisTask._test_patch):
1605         (PatchAnalysisTask.results_from_patch_test_run):
1606         (PatchAnalysisTask.results_from_test_run_without_patch): Deleted.
1607         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1608         Removes needless call to results_from_test_run_without_patch
1609         (AbstractEarlyWarningSystem._failing_tests_message):
1610         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1611         Changes order of test failure messages to be in the order that they
1612         appear.
1613         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
1614         * Scripts/webkitpy/tool/commands/queues.py:
1615         Removes needless call to results_from_test_run_without_patch.
1616         (CommitQueue._failing_tests_message):
1617         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1618         (MockCommitQueueTask.results_from_test_run_without_patch): Deleted.
1619
1620 2014-11-06  Ryuan Choi  <ryuan.choi@navercorp.com>
1621
1622         Unreviewed. Reorder my e-mail addresses in contributors.json
1623
1624         * Scripts/webkitpy/common/config/contributors.json:
1625
1626 2014-11-06  Matthew Hanson  <matthew_hanson@apple.com>
1627
1628         Remove code that prepends a leading 'r' to the first argument of _run_git_svn_find_rev
1629         https://bugs.webkit.org/show_bug.cgi?id=138475
1630
1631         Reviewed by Ryosuke Niwa.
1632
1633         The change in https://trac.webkit.org/175603 introduced broke compatibility with svn_revision_from_git_commit.
1634         This patch reverts the part of that change that broke compatibility. In addition, this patch adds a comment to
1635         explain that SVN revisions require a leading 'r', moves an existing comment to a more appropriate location and
1636         renames the positional argument to better reflect that it can represent either an SVN revision or a Git tree-ish.
1637
1638         * Scripts/webkitpy/common/checkout/scm/git.py:
1639         (Git._run_git_svn_find_rev):
1640         Add comment mentioning that svn_revisions need to begin with 'r'.
1641         Move comment (explaining that git svn find-rev exits with code 0 when no match is found) to a more appropriate location.
1642         Rename the argument 'revision' to 'revision_or_treeish' to reflect the dual form that argument can take.
1643         Remove code that coerced the revision/treeish into a string and prepended an 'r'.
1644
1645 2014-11-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1646
1647         [GTK] Add context menu API to Web Process Extensions
1648         https://bugs.webkit.org/show_bug.cgi?id=138311
1649
1650         Reviewed by Gustavo Noronha Silva.
1651
1652         Add tests cases for WebKitWebPage::context-menu signal.
1653
1654         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
1655         (testContextMenuWebExtensionMenu):
1656         (testContextMenuWebExtensionNode):
1657         (beforeAll):
1658         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1659         (serializeContextMenu):
1660         (serializeNode):
1661         (contextMenuCallback):
1662         (pageCreatedCallback):
1663
1664 2014-11-06  Commit Queue  <commit-queue@webkit.org>
1665
1666         Unreviewed, rolling out r175690.
1667         https://bugs.webkit.org/show_bug.cgi?id=138460
1668
1669         We are not ready to run layout tests using the network process
1670         yet (Requested by KaL on #webkit).
1671
1672         Reverted changeset:
1673
1674         "[GTK] Run layout tests using the network process"
1675         https://bugs.webkit.org/show_bug.cgi?id=138428
1676         http://trac.webkit.org/changeset/175690
1677
1678 2014-11-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1679
1680         [GTK] Run layout tests using the network process
1681         https://bugs.webkit.org/show_bug.cgi?id=138428
1682
1683         Reviewed by Martin Robinson.
1684
1685         Shared secondary process is the default in the GTK+ port, but we
1686         should run the tests using the network process to ensure
1687         everything works with the network process. In the future, the
1688         shared secondary process model might be a special case of multiple
1689         processes with 1 as maximum number of processes, but always using
1690         the network process.
1691
1692         * WebKitTestRunner/TestController.cpp:
1693         (WTR::TestController::initialize):
1694
1695 2014-11-05  Dan Bernstein  <mitz@apple.com>
1696
1697         Remove the unused deletion UI feature
1698         https://bugs.webkit.org/show_bug.cgi?id=138442
1699
1700         Rubber-stamped by Alexey Proskuryakov.
1701
1702         * DumpRenderTree/mac/EditingDelegate.mm:
1703         (-[EditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Deleted implementation of
1704         delegate method that’s been removed.
1705
1706 2014-11-05  Alexey Proskuryakov  <ap@apple.com>
1707
1708         fast/dom/remove-body-during-body-replacement2.html fails on WK2
1709         https://bugs.webkit.org/show_bug.cgi?id=138334
1710
1711         Reviewed by Anders Carlsson.
1712
1713         Reset focus to main frame between tests. DumpRenderTree does this via -makeFirstResponder
1714         calls, which works because each frame is an NSView in WK1. WK2 makes equivalent
1715         -makeFirstResponder calls, which may or may not be needed for other reasons, but
1716         it also needs to reset internal focus explicitly.
1717
1718         It's not clear if this is the right long-term fix or a workaround for a WebKit bug.
1719         WebKit behavior appears wrong, but it matches Firefox.
1720
1721         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1722         (WTR::InjectedBundlePage::resetAfterTest):
1723
1724 2014-11-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1725
1726         [GTK] Add WebKitWebResource::failed-with-tls-errors signal
1727         https://bugs.webkit.org/show_bug.cgi?id=137862
1728
1729         Reviewed by Gustavo Noronha Silva.
1730
1731         Add a test case to check that WebKitWebResource::failed-with-tls-errors
1732         is emitted when a subresource load fails due to TLS errors.
1733
1734         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1735         (TLSSubresourceTest::resourceLoadStartedCallback):
1736         (TLSSubresourceTest::TLSSubresourceTest):
1737         (TLSSubresourceTest::subresourceFailedCallback):
1738         (TLSSubresourceTest::subresourceFailedWithTLSErrorsCallback):
1739         (TLSSubresourceTest::subresourceLoadStarted):
1740         (TLSSubresourceTest::subresourceFailedWithTLSErrors):
1741         (TLSSubresourceTest::waitUntilSubresourceLoadFail):
1742         (testSubresourceLoadFailedWithTLSErrors):
1743         (httpsServerCallback):
1744         (httpServerCallback):
1745         (beforeAll):
1746
1747 2014-11-05  Alexey Proskuryakov  <ap@apple.com>
1748
1749         Build fix for some compiler versions.
1750
1751         * TestWebKitAPI/Tests/mac/TypingStyleCrash.mm: (TestWebKitAPI::TEST): Compiler was
1752         unhappy because this is a getter, and these shouldn't have side effects.
1753
1754 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
1755
1756         Add a method for performing cherrypick-merges.
1757         https://bugs.webkit.org/show_bug.cgi?id=138375
1758
1759         Reviewed by Ryosuke Niwa.
1760
1761         Adds support for cherrypick-merges.
1762
1763         * Scripts/webkitpy/common/checkout/scm/git.py:
1764         (Git.cherrypick_merge): Added.
1765
1766 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
1767
1768         Add a way to ascertain the SVN URL associated with a Git branch.
1769         https://bugs.webkit.org/show_bug.cgi?id=138374
1770
1771         Reviewed by Ryosuke Niwa.
1772
1773         The svn_url method returns the SVN URL associated with the current Git branch.
1774
1775         * Scripts/webkitpy/common/checkout/scm/git.py:
1776         (Git.svn_url): Added.
1777
1778 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
1779
1780         Add the ability to search for modifications that are staged for commit.
1781         https://bugs.webkit.org/show_bug.cgi?id=138373
1782
1783         Reviewed by Ryosuke Niwa and Daniel Bates.
1784
1785         This makes is easy to do identify files that require merge post-processing,
1786         in addition to stand-alone utility.
1787
1788         * Scripts/webkitpy/common/checkout/scm/git.py:
1789         (Git.modifications_staged_for_commit): Added.
1790
1791 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
1792
1793         Add a branch keyword argument to _run_git_svn_find_rev.
1794         https://bugs.webkit.org/show_bug.cgi?id=138372
1795
1796         Reviewed by Ryosuke Niwa.
1797
1798         The addition of this keyword argument allows clients to determine the Git hash
1799         of commits made on an SVN branch, provided that branch has been fetched locally.
1800
1801         * Scripts/webkitpy/common/checkout/scm/git.py:
1802         (Git._run_git_svn_find_rev):
1803         Add a branch keyword argument that is added to the end of the command, if present.
1804
1805 2014-11-04  Chris Dumez  <cdumez@apple.com>
1806
1807         Add ptr() method to Ref class
1808         https://bugs.webkit.org/show_bug.cgi?id=138361
1809
1810         Reviewed by Darin Adler.
1811
1812         Use the new Ref::ptr() method.
1813
1814         * TestWebKitAPI/Tests/WTF/Ref.cpp:
1815         (TestWebKitAPI::TEST):
1816
1817 2014-11-04  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1818
1819         [jhbuild] Make it possible to build GTK/EFL in same repository
1820         https://bugs.webkit.org/show_bug.cgi?id=137448
1821
1822         Reviewed by Martin Robinson.
1823
1824         * Scripts/webkitdirs.pm:
1825         (getJhbuildPath):
1826         * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp:
1827         (getPlatformFontsPath):
1828         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1829         (WTR::getFontsPath):
1830         * jhbuild/jhbuild-wrapper:
1831         (determine_platform):
1832         (install_jhbuild):
1833         * jhbuild/jhbuildrc_common.py:
1834         (init):
1835
1836 2014-11-04  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
1837
1838         [EFL] Bump LLVM to version 3.5.0
1839         https://bugs.webkit.org/show_bug.cgi?id=138312
1840
1841         Reviewed by Csaba Osztrogonác.
1842
1843         * efl/jhbuild.modules:
1844         * efl/patches/llvm-elf-add-stackmaps.patch: Added.
1845         * efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Added.
1846
1847 2014-11-03  Simon Fraser  <simon.fraser@apple.com>
1848
1849         Add page overlays that show regions with mouseWheel event handlers, and the non-fast-scrollable region, and code to toggle them in MiniBrowser WK2
1850         https://bugs.webkit.org/show_bug.cgi?id=138257
1851
1852         Reviewed by Tim Horton.
1853         
1854         Add a "Debug Overlays" submenu item under "WebKit2-only Settings" which allows
1855         the user to toggle region page overlays on and off. Two overlays are available,
1856         for the non-fast scrollable region, and the region of element with wheel
1857         event handlers.
1858
1859         * MiniBrowser/mac/SettingsController.h:
1860         * MiniBrowser/mac/SettingsController.m:
1861         (-[SettingsController _populateMenu]):
1862         (-[SettingsController validateMenuItem:]):
1863         (-[SettingsController nonFastScrollableRegionOverlayVisible]):
1864         (-[SettingsController wheelEventHandlerRegionOverlayVisible]):
1865         (-[SettingsController preferenceKeyForRegionOverlayTag:]):
1866         (-[SettingsController toggleDebugOverlay:]):
1867         (-[SettingsController debugOverlayVisible:]):
1868         * MiniBrowser/mac/WK2BrowserWindowController.m:
1869         (-[WK2BrowserWindowController didChangeSettings]):
1870
1871 2014-11-03  Alexey Proskuryakov  <ap@apple.com>
1872
1873         REGRESSION (Subpixel layout): Bubbles don't fit in Bugzilla review page
1874         https://bugs.webkit.org/show_bug.cgi?id=138323
1875
1876         Reviewed by Zalan Bujtas.
1877
1878         * QueueStatusServer/templates/statusbubble.html: Round the sizes up, not down.
1879
1880 2014-11-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1881
1882         [ninja] Don't remove response files for verbose builds
1883         https://bugs.webkit.org/show_bug.cgi?id=137816
1884
1885         Reviewed by Csaba Osztrogonác.
1886
1887         * Scripts/webkitdirs.pm:
1888         (determineNinjaVersion):
1889         (buildCMakeGeneratedProject):
1890
1891 2014-11-02  Akos Kiss  <akiss@inf.u-szeged.hu>
1892
1893         [GTK] Fix the build of FTL JIT
1894         https://bugs.webkit.org/show_bug.cgi?id=138298
1895
1896         Reviewed by Carlos Garcia Campos.
1897
1898         * gtk/jhbuild-optional.modules:
1899         Bump up LLVM version to 3.5.0 release and apply patches.
1900         * gtk/patches/llvm-elf-add-stackmaps.patch:
1901         Added. Adds .llvm_stackmaps section to ELF files. Backported from LLVM
1902         trunk.
1903         * gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch:
1904         Added. Ensures that PC-relative relocations in EH frames are not
1905         truncated to 32 bits on x86_64.
1906
1907 2014-10-31  Michael Saboff  <msaboff@apple.com>
1908
1909         No way to specify target os or architecture when using the --no-copy option with run-jsc-stress-tests
1910         https://bugs.webkit.org/show_bug.cgi?id=138268
1911
1912         Reviewed by Andreas Kling.
1913
1914         Added a --arch and --os option to set or override the values that are
1915         normally computed based on examining the JavaScriptCore we want to test.
1916
1917         * Scripts/run-jsc-stress-tests:
1918
1919 2014-10-31  Dan Bernstein  <mitz@apple.com>
1920
1921         llvmForJSC build emits a linker warning that it can't find usr/local/LLVMForJavaScriptCore/lib under the build directory
1922         https://bugs.webkit.org/show_bug.cgi?id=138259
1923
1924         Reviewed by Geoff Garen.
1925
1926         * Scripts/copy-webkitlibraries-to-product-directory: Create this directory even if it’s
1927         going to be empty to silence the warning.
1928
1929 2014-10-31  Adrian Perez de Castro  <aperez@igalia.com>
1930
1931         [GTK] Support script message handlers WebKitUserContentManager
1932         https://bugs.webkit.org/show_bug.cgi?id=133730
1933
1934         Reviewed by Carlos Garcia Campos.
1935
1936         Support user script message handlers in WebKitUserContentManager.
1937         This needs building with ENABLE_USER_MESSAGE_HANDLERS, for which
1938         an option is added to the CMake build files. The option is disabled
1939         globally by default, and the WebKitGTK port enables it. On the API
1940         level, two new methods to register and unregister names are provided
1941         in the "window.webkit" namespace, and on message reception the
1942         "WebKitUserContentManager::script-message-received" signal is
1943         emitted, using the registered names as signal detail.
1944
1945         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
1946         Add test case for user script message handlers.
1947         (scriptMessageReceived):
1948         (testUserContentManagerScriptMessageReceived):
1949         (beforeAll):
1950
1951 2014-10-30  Matthew Hanson  <matthew_hanson@apple.com>
1952
1953         bisect-builds should support WebKit clients other than Safari
1954         https://bugs.webkit.org/show_bug.cgi?id=138225
1955
1956         This patch adds support for bisecting WebKit nightly builds with clients other than Safari.
1957
1958         The -a / --application optional argument allows the user to specify which application (or application bundle)
1959         should be run against the WebKit nightly builds.
1960
1961         Reviewed by David Kilzer.
1962
1963         * Scripts/bisect-builds:
1964         Swap out $safariPath for the more general $applicationPath
1965         Leave --safari-path as a commandline option for backwards compatibility
1966         (mountAndRunNightly):
1967         Use File::Spec->cat correctly (one directory per argument)
1968         Use open --wait-apps instead of running the target application directly
1969
1970 2014-10-30  Dana Burkart  <dburkart@apple.com>
1971
1972         <rdar://problem/18821260> Perpare for the mysterious future
1973
1974         Reviewed by Lucas Forschler.
1975
1976         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1977         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1978         * LayoutTestRelay/Configurations/Base.xcconfig:
1979         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
1980         * MiniBrowser/Configurations/Base.xcconfig:
1981         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1982         * TestWebKitAPI/Configurations/Base.xcconfig:
1983         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1984         * WebKitLauncher/Configurations/Base.xcconfig:
1985         * WebKitTestRunner/Configurations/Base.xcconfig:
1986         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1987
1988 2014-10-30  Matthew Hanson  <matthew_hanson@apple.com>
1989
1990         Update safariVersion to safariVersionString
1991         https://bugs.webkit.org/show_bug.cgi?id=138193
1992
1993         The preceding change updated safariVersion to safariVersionString for the "4 Public Beta" check in OS X 10.5.x,
1994         but it should have also been done for the "4 Public Beta" check in OS X 10.4.x.
1995
1996         Rubber-stamped by David Kilzer.
1997
1998         * Scripts/bisect-builds:
1999         (makeNightlyList):
2000         Compare safariVersionString to a string literal, instead of safariVersion.
2001
2002 2014-10-30  Rohit Kumar  <kumar.rohit@samsung.com>
2003
2004         [GTK] Minibrowser : Add window fullscreen support for Minibrowser
2005         https://bugs.webkit.org/show_bug.cgi?id=137775
2006
2007         Reviewed by Carlos Garcia Campos.
2008
2009         * MiniBrowser/gtk/BrowserWindow.c:
2010         (toggleFullScreen): Callback to toggle window fullscreen on pressing F11 key.
2011         (browser_window_init):
2012
2013 2014-10-29  Jake Nielsen  <jacob_nielsen@apple.com>
2014
2015         CommitQueue and EWS should reject any patches that result in consistent test
2016         failures that aren't present on the tree.
2017         https://bugs.webkit.org/show_bug.cgi?id=138184
2018
2019         Reviewed by Alexey Proskuryakov.
2020
2021         * Scripts/webkitpy/layout_tests/models/test_results.py:
2022         Adds a simple hashing function to allow for set operations to handle
2023         TestResult objects properly.
2024         (TestResult.__hash__):
2025         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2026         Adds one unit test, and modifies others to agree with the notion that
2027         patches that introduce new test failures (but also have flakyness)
2028         should be rejected rather than spin.
2029         (MockCommitQueue.report_flaky_tests):
2030         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
2031         (test_double_flaky_test_failure):
2032         (test_two_flaky_tests):
2033         (test_very_flaky_patch):
2034         (test_very_flaky_patch_with_some_tree_redness):
2035         (test_different_test_failures):
2036         (test_different_test_failures_with_some_tree_redness):
2037         (test_different_test_failures_with_some_tree_redness_and_some_fixes):
2038         (test_mildly_flaky_patch):
2039         (test_mildly_flaky_patch_with_some_tree_redness):
2040         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2041         Makes PatchAnalysisTask reject said patches.
2042         (PatchAnalysisTask._test_patch):
2043
2044 2014-10-29  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2045
2046         WinCairoRequirements.zip cannot be downloaded from dropbox
2047         https://bugs.webkit.org/show_bug.cgi?id=138113
2048
2049         Reviewed by Alexey Proskuryakov.
2050
2051         * Scripts/update-webkit-dependency: Removing --sslv3 option from curl
2052
2053 2014-10-29  Matthew Hanson  <matthew_hanson@apple.com>
2054
2055         bisect-builds should filter out nightlies that predate the introduction of an OS X operating system
2056         https://bugs.webkit.org/show_bug.cgi?id=138193
2057
2058         This patch restricts the set of nightles to bisect to only those nightlies that ship with frameworks
2059         for the target OS (only support for OS X Yosemite, Mavericks and Mountain Lion was added.)
2060
2061         It also does a bit of refactoring, including distinguishing between versions and version strings and
2062         saving versions to local variables instead of using eval in each conditional.
2063
2064         Reviewed by David Kilzer.
2065
2066         * Scripts/bisect-builds:
2067         (makeNightlyList):
2068         Restrict the set of nightlies to r174650 and above when running Yosemite.
2069         Restrict the set of nightlies to r157846 and above when running Mavericks.
2070         Restrict the set of nightlies to r122421 and above when running Mountain Lion.
2071
2072 2014-10-29  Csaba Osztrogonác  <ossy@webkit.org>
2073
2074         [EFL] build-webkit should try harder to avoid re-running cmake
2075         https://bugs.webkit.org/show_bug.cgi?id=137949
2076
2077         Reviewed by Martin Robinson.
2078
2079         * Scripts/webkitdirs.pm:
2080         (shouldRemoveCMakeCache): Don't remove CMakeCache unconditionally for EFL.
2081         (generateBuildSystemFromCMakeProject): Comment fix after r174681.
2082
2083 2014-10-28  Daniel Bates  <dabates@apple.com>
2084
2085         Unify logic in RunTests.run() to run the Python unit tests
2086         https://bugs.webkit.org/show_bug.cgi?id=138160
2087
2088         Reviewed by Martin Robinson.
2089
2090         Unify the interactive and non-interactive code path for running the Python unit tests
2091         in step RunTests so as to remove duplicate code to compute the the path to the script
2092         test-webkitpy and log an informative message ("Running Python unit tests") to the console.
2093
2094         No new tests since no functionality was changed.
2095
2096         * Scripts/webkitpy/port/base.py:
2097         (Port.python_unittest_results_directory):
2098         * Scripts/webkitpy/tool/steps/runtests.py:
2099         (RunTests.run):
2100
2101 2014-10-28  Jake Nielsen  <jacob_nielsen@apple.com>
2102
2103         Make runtest.py call test-webkitpy with the --json flag when in
2104         non-interactive mode.
2105         https://bugs.webkit.org/show_bug.cgi?id=137667
2106
2107         Reviewed by Daniel Bates.
2108
2109         * Scripts/webkitpy/port/base.py:
2110         Adds the python_unittest_results_directory method.
2111         (Port.python_unittest_results_directory):
2112         * Scripts/webkitpy/tool/steps/runtests.py:
2113         Changes RunTests to call test-webkitpy with the --json flag if the
2114         --non-interactive flag is set.
2115         (RunTests):
2116         (RunTests.run):
2117
2118 2014-10-28  Rebecca Hauck  <rhauck@adobe.com>
2119
2120         import-w3c-tests should use re.escape() wherever it's handling file paths
2121         https://bugs.webkit.org/show_bug.cgi?id=137934
2122
2123         This patch adds re.escape() to a few places where we're doing string
2124         conversions. This prevents errors when attribute values coincidentally
2125         have character sequences that can be interpreted as regular expressions.
2126
2127         Reviewed by Bem Jones-Bey.
2128
2129         * Scripts/webkitpy/w3c/test_converter.py:
2130         (_W3CTestConverter.convert_attributes_if_needed):
2131
2132 2014-10-28  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2133
2134         [EFL] Remove an unused include from Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp
2135         https://bugs.webkit.org/show_bug.cgi?id=138130
2136
2137         Reviewed by Csaba Osztrogonác.
2138
2139         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2140
2141 2014-10-25  Raniere Silva  <raniere@ime.unicamp.br>
2142
2143         Fix link to Arch Linux Wiki
2144         https://bugs.webkit.org/show_bug.cgi?id=138010
2145
2146         Reviewed by Benjamin Poulain.
2147
2148         * gtk/install-dependencies:
2149
2150 2014-10-25  Alexey Proskuryakov  <ap@apple.com>
2151
2152         Test regressions are not detected when image result is missing
2153         https://bugs.webkit.org/show_bug.cgi?id=138070
2154
2155         Reviewed by Simon Fraser.
2156
2157         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2158         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
2159         Count these as regressions, not as flaky tests.
2160
2161         * Scripts/webkitpy/port/test.py:
2162         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2163         Test it.
2164
2165 2014-10-24  Timothy Horton  <timothy_horton@apple.com>
2166
2167         Add Conrad Shultz to the contributors list.
2168
2169         * Scripts/webkitpy/common/config/contributors.json:
2170
2171 2014-10-24  Dan Bernstein  <mitz@apple.com>
2172
2173         build.webkit.org/dashboard immediately retries a request to buildbot when the response is 404
2174         https://bugs.webkit.org/show_bug.cgi?id=138046
2175
2176         Reviewed by Alexey Proskuryakov.
2177
2178         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2179         (BuildbotQueue.prototype._load): Only consider retrying immediately if the error code was
2180         401. Otherwise, we’ll retry normally in 45 seconds.
2181
2182 2014-10-24  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
2183
2184         [GTK] Implement is_selected method on WebKitHitTestResult
2185         https://bugs.webkit.org/show_bug.cgi?id=137110
2186
2187         Reviewed by Tim Horton.
2188
2189         Add tests for new context SELECTION on WebKitHitTestResult.
2190
2191         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
2192         (testContextMenuDefaultMenu):
2193         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
2194         (testWebViewMouseTarget):
2195
2196 2014-10-23  Roger Fong  <roger_fong@apple.com>
2197
2198         [Win] Skip failing JSC tests following r175078
2199         https://bugs.webkit.org/show_bug.cgi?id=130967.
2200
2201         * Scripts/run-javascriptcore-tests:
2202
2203 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
2204
2205         commitqueuetask_unittest.py should be made more concise.
2206         https://bugs.webkit.org/show_bug.cgi?id=137985
2207
2208         Reviewed by Alexey Proskuryakov.
2209
2210         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2211         Refactors tests to use MockSimpleTestPlanCommitQueue where possible.
2212         (MockCommitQueue.__init__):
2213         (MockCommitQueue.report_flaky_tests):
2214         (MockCommitQueue):
2215         (MockCommitQueue.get_reported_flaky_tests):
2216         (MockSimpleTestPlanCommitQueue.__init__):
2217         (MockSimpleTestPlanCommitQueue.run_command):
2218         (MockSimpleTestPlanCommitQueue.did_run_clean_tests):
2219         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
2220         (test_land_failure):
2221         (test_failed_archive):
2222         (test_double_flaky_test_failure):
2223         (test_test_failure):
2224         (test_red_test_failure):
2225         (test_very_red_tree_retry):
2226         (test_red_tree_patch_rejection):
2227         (test_one_flaky_test):
2228         (test_tree_more_red_than_patch):
2229         (MockCommitQueue.test_results): Deleted.
2230         (test_simple_flaky_test_failure): Deleted.
2231         (_expect_validate): Deleted.
2232         (_expect_validate.MockDelegate): Deleted.
2233         (_expect_validate.MockDelegate.refetch_patch): Deleted.
2234         (_expect_validate.MockDelegate.expected_failures): Deleted.
2235         (_mock_patch): Deleted.
2236         (test_validate): Deleted.
2237         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2238         Fixes a bug that slipped through the cracks prior to this change.
2239         (PatchAnalysisTask._test_patch):
2240
2241 2014-10-22  Alexey Proskuryakov  <ap@apple.com>
2242
2243         Flakiness dashboard should support OS X Yosemite
2244         https://bugs.webkit.org/show_bug.cgi?id=137986
2245
2246         Reviewed by Ryosuke Niwa.
2247
2248         * TestResultServer/app.yaml:
2249         * TestResultServer/static-dashboards/builders.jsonp:
2250         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2251
2252 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
2253
2254         commitqueuetask should include more tests to ensure that the behavior
2255         of PatchAnalysisTask._test_patch() is well defined
2256         https://bugs.webkit.org/show_bug.cgi?id=137977
2257
2258         Reviewed by Alexey Proskuryakov.
2259
2260         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2261         Adds the MockSimpleTestPlanCommitQueue class, which makes it easier
2262         and more readable to define tests that are meant to test the behaviour
2263         of PatchAnalysisTask._test_patch(), and adds several unit tests.
2264         (FailingTestCommitQueue.test_results):
2265         (PatchAnalysisResult):
2266         (MockSimpleTestPlanCommitQueue):
2267         (MockSimpleTestPlanCommitQueue.__init__):
2268         (MockSimpleTestPlanCommitQueue.run_command):
2269         (MockSimpleTestPlanCommitQueue._mock_test_result):
2270         (MockSimpleTestPlanCommitQueue.test_results):
2271         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
2272         (test_flaky_test_failure):
2273         (test_failed_archive):
2274         (test_two_flaky_tests):
2275         (test_one_flaky_test):
2276         (test_very_flaky_patch):
2277         (test_very_flaky_patch_with_some_tree_redness):
2278         (test_different_test_failures):
2279         (test_different_test_failures_with_some_tree_redness):
2280         (test_mildly_flaky_patch):
2281         (test_mildly_flaky_patch_with_some_tree_redness):
2282         (test_tree_more_red_than_patch):
2283
2284 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
2285
2286         PatchAnalysisTask._test_patch() needs refactoring
2287         https://bugs.webkit.org/show_bug.cgi?id=137904
2288
2289         Reviewed by Alexey Proskuryakov.
2290
2291         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2292         Fixes several small bugs, and makes minor changes to accomodate the
2293         changes in PatchAnalysisTask.
2294         (MockCommitQueue.refetch_patch):
2295         (MockCommitQueue.test_results):
2296         (test_flaky_test_failure):
2297         (test_failed_archive):
2298         (test_very_red_tree_retry):
2299         (_expect_validate.MockDelegate.refetch_patch):
2300         (MockCommitQueue.expected_failures): Deleted.
2301         (_expect_validate.MockDelegate.expected_failures): Deleted.
2302         * Scripts/webkitpy/tool/bot/expectedfailures.py: Removed.
2303         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py: Removed.
2304         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2305         Removes the unexpected_failures member, adds the _clean_tree_results
2306         member, adds a helper function for _test_patch, and refactors
2307         _test_patch to be more readable.
2308         (PatchAnalysisTask.__init__):
2309         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try):
2310         (PatchAnalysisTask._test_patch):
2311         (PatchAnalysisTask.results_from_test_run_without_patch):
2312         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2313         Removes AbstractEarlyWarningSystem's dependancy on ExpectedFailures. 
2314         (AbstractEarlyWarningSystem.begin_work_queue):
2315         (AbstractEarlyWarningSystem._failing_tests_message):
2316         (AbstractEarlyWarningSystem.command_failed):
2317         (AbstractEarlyWarningSystem.expected_failures): Deleted.
2318         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2319         Makes changes to accomodate the changes made to PatchAnalysisTask.
2320         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
2321         * Scripts/webkitpy/tool/commands/perfalizer.py:
2322         Removes Perfalizer's dependancy on ExpectedFailures. 
2323         (PerfalizerTask.refetch_patch):
2324         (PerfalizerTask.expected_failures): Deleted.
2325         * Scripts/webkitpy/tool/commands/queues.py:
2326         Removes CommitQueue's dependancy on ExpectedFailures, and adds an
2327         initializer to allow for mock injection.
2328         (CommitQueue.__init__):
2329         (CommitQueue.begin_work_queue):
2330         (CommitQueue.process_work_item):
2331         (CommitQueue._failing_tests_message):
2332         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2333         Removes dependancy on ExpectedFailures, and instead uses mock
2334         injection.
2335         (MockCommitQueueTask):
2336         (MockCommitQueueTask.results_from_patch_test_run):
2337         (MockCommitQueueTask.results_from_test_run_without_patch):
2338         (mock_run_webkit_patch):
2339
2340 2014-10-22  Rohit Kumar  <kumar.rohit@samsung.com>
2341
2342         [EFL][WK2] Minibrowser : Add support for mouse middle button to open links in new window
2343         https://bugs.webkit.org/show_bug.cgi?id=136736
2344
2345         Reviewed by Gyuyoung Kim.
2346
2347         * MiniBrowser/efl/main.c:
2348         (on_navigation_policy_decision): Check whether it's a link clicked with the middle mouse button and load the request in a new window.
2349         (window_create):
2350
2351 2014-10-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2352
2353         [GTK] Move GtkInputMethodFilter from Platform to WebKit2
2354         https://bugs.webkit.org/show_bug.cgi?id=137884
2355
2356         Reviewed by Gustavo Noronha Silva.
2357
2358         Move InputMethodFilter test from WebCore tests to WebKit2 tests
2359         and adapt it to use the new InputMethodFilter WebKit class. Instead
2360         of having virtual methods just for testing, it has a testing mode
2361         that logs the events.
2362
2363         * TestWebKitAPI/PlatformGTK.cmake:
2364         * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/gtk/InputMethodFilter.cpp.
2365         (TestWebKitAPI::TestInputMethodFilter::TestInputMethodFilter):
2366         (TestWebKitAPI::TestInputMethodFilter::~TestInputMethodFilter):
2367         (TestWebKitAPI::TestInputMethodFilter::sendKeyEventToFilter):
2368         (TestWebKitAPI::TestInputMethodFilter::sendPressAndReleaseKeyEventPairToFilter):
2369         (TestWebKitAPI::TEST):
2370         (TestWebKitAPI::temporaryGetPreeditStringOverride):
2371         (TestWebKitAPI::temporaryResetOverride):
2372         (TestWebKitAPI::verifyCanceledComposition):
2373
2374 2014-10-21  Alexey Proskuryakov  <ap@apple.com>
2375
2376         build.webkit.org/dashboard: Cannot click on green tester bubbles
2377         https://bugs.webkit.org/show_bug.cgi?id=137909
2378
2379         Reviewed by Darin Adler.
2380
2381         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2382         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2383
2384 2014-10-21  Brent Fulgham  <bfulgham@apple.com>
2385
2386         [Win] Run DumpRenderTree using native controls, not SafariTheme.dll.
2387         https://bugs.webkit.org/show_bug.cgi?id=137932
2388
2389         Reviewed by Simon Fraser.
2390
2391         This is the first step in moving over to native Windows rendering for our layout tests.
2392         Once this change lands, approximately 300 tests will start failing on Windows. I will
2393         rebaseline these changes against our test hardware and update this bug with the
2394         commits related to that work.
2395
2396         * DumpRenderTree/win/DumpRenderTree.cpp:
2397         (resetDefaultsToConsistentValues): Call 'setShouldPaintNativeControls(TRUE)' so that
2398         we use native Windows drawing style.
2399
2400 2014-10-21  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
2401
2402         Fix FTL Native Inlining for EFL
2403         https://bugs.webkit.org/show_bug.cgi?id=137774
2404
2405         Reviewed by Michael Saboff.
2406
2407         Added Clang as an optional module to jhbuild.
2408
2409         * efl/jhbuild.modules:
2410
2411 2014-10-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2412
2413         Change the default TLS errors policy to WEBKIT_TLS_ERRORS_POLICY_FAIL
2414         https://bugs.webkit.org/show_bug.cgi?id=137832
2415
2416         Reviewed by Carlos Garcia Campos.
2417
2418         Ensure each test sets the TLS errors policy that it really needs.
2419         Have each test except testTLSErrorsPolicy stash and restore the original
2420         TLS errors policy. Update testTLSErrorsPolicy to account for the new
2421         default policy.
2422
2423         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2424         (testSSL):
2425         (testInsecureContent):
2426         (testTLSErrorsPolicy):
2427         (testTLSErrorsRedirect):
2428         (testTLSErrorsHTTPAuth):
2429         (testLoadFailedWithTLSErrors):
2430         (beforeAll):
2431
2432 2014-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2433
2434         Unreviewed. Unskip inspector server unit tests.
2435
2436         They should pass now.
2437
2438         * Scripts/run-gtk-tests:
2439         (TestRunner):
2440
2441 2014-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2442
2443         [GTK] Test TestWebKitAPI/WebKit2Gtk/TestInspectorServer fails
2444         https://bugs.webkit.org/show_bug.cgi?id=132044
2445
2446         Reviewed by Brian Burg.
2447
2448         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
2449         (openRemoteDebuggingSession): Remove trailing slash when
2450         concatenating base inspector URL with the page, because the
2451         inspector returns the relative paths with a leading slash.
2452
2453 2014-10-20  Tanay C  <tanay.c@samsung.com>
2454
2455         [EFL][WK2] Minibrowser : Add support for Case sensitive and word start search
2456         https://bugs.webkit.org/show_bug.cgi?id=137023
2457
2458         Reviewed by Gyuyoung Kim.
2459
2460         * MiniBrowser/efl/main.c: Added functionality to support case sensitive and word start search
2461         (search_box_show): Modified.
2462         (search_box_hide): Modified.
2463         (on_search_field_activated): Modified.
2464         (on_search_backward_button_clicked): Modified.
2465         (on_search_forward_button_clicked): Modified.
2466         (on_search_case_option_changed): Added.
2467         (on_search_word_start_option_changed): Added.
2468         (window_create): Modified.
2469
2470 2014-10-20  Tanay C  <tanay.c@samsung.com>
2471
2472         [GTK][Minibrowser] Escape key does not hide the search box
2473         https://bugs.webkit.org/show_bug.cgi?id=137734
2474
2475         Reviewed by Philippe Normand.
2476
2477         * MiniBrowser/gtk/BrowserWindow.c: Added the check to handle search box hide
2478         (stopPageLoad): Modified.
2479
2480 2014-10-18  Antti Koivisto  <antti@apple.com>
2481
2482         REGRESSION (r173356): Safari can't install a profile, gets 'Download Failed error
2483         https://bugs.webkit.org/show_bug.cgi?id=137855
2484
2485         Reviewed by Dan Bernstein.
2486
2487         Test and warn if the dumped response mime type differs from the platform response mime type.
2488
2489         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2490         (WTR::InjectedBundlePage::didReceiveResponseForResource):
2491         (WTR::InjectedBundlePage::platformResponseMimeType):
2492         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2493         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2494         (WTR::InjectedBundlePage::platformResponseMimeType):
2495
2496 2014-10-17  Joseph Pecoraro  <pecoraro@apple.com>
2497
2498         Remove run-inspector-perf-tests.py there is no PerformanceTests/inspector anymore
2499         https://bugs.webkit.org/show_bug.cgi?id=137835
2500
2501         Reviewed by Andreas Kling.
2502
2503         * Scripts/run-inspector-perf-tests.py: Removed.
2504         This script is stale, as PerformanceTests/inspector no longer exists.
2505
2506 2014-10-17  Simon Fraser  <simon.fraser@apple.com>
2507
2508         Fix typo: should be ios-simulator-wk2, not ios-simulator_wk2.
2509
2510         * Scripts/webkitpy/port/ios.py:
2511         (IOSSimulatorPort.default_baseline_search_path):
2512
2513 2014-10-17  Simon Fraser  <simon.fraser@apple.com>
2514
2515         [iOS] Simplify test fallback paths for iOS Simulator testing
2516         https://bugs.webkit.org/show_bug.cgi?id=137830
2517
2518         Reviewed by Zalan Bujtas.
2519         
2520         Make the fallback paths be:
2521             ios-simulator -> generic
2522             ios-simulator-wk2->ios-simulator -> generic
2523         
2524         so don't include mac in the fallback path. Also remove the
2525         version handling for simplicity.
2526
2527         * Scripts/webkitpy/port/ios.py:
2528         (IOSSimulatorPort):
2529         (IOSSimulatorPort.default_baseline_search_path):
2530
2531 2014-10-17  Dana Burkart  <dburkart@apple.com>
2532
2533         Fix typos in the dashboard config file.
2534
2535         Unreviewed.
2536
2537         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2538         (WebKitBuildbot):
2539
2540 2014-10-17  Brent Fulgham  <bfulgham@apple.com>
2541
2542         [Win] Allow WinLauncher to specify Custom User Agent strings
2543         https://bugs.webkit.org/show_bug.cgi?id=137828
2544
2545         Reviewed by Dean Jackson.
2546
2547         * WinLauncher/Common.cpp: Add support for custom user agent strings.
2548         * WinLauncher/WinLauncher.cpp: Add some convenience methods to get
2549         and set the user agent strings.
2550         * WinLauncher/WinLauncher.h:
2551         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add new menu
2552         resources and dialog for setting custom User Agent strings.
2553         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
2554
2555 2014-10-16  Simon Fraser  <simon.fraser@apple.com>
2556
2557         [iOS] Turn off font autosizing for iOS WebKitTestRunner
2558         https://bugs.webkit.org/show_bug.cgi?id=137806
2559
2560         Reviewed by Sam Weinig.
2561
2562         Confusingly, WKPreferencesSetTextAutosizingEnabled() does nothing on iOS.
2563         Instead, we have to add WKPreferencesSetMinimumZoomFontSize() and set it to 0
2564         to disable font autosizing.
2565         
2566         Add platformResetPreferencesToConsistentValues() and implement it in the iOS
2567         test controller to set platform-specific prefs.
2568
2569         * WebKitTestRunner/TestController.cpp:
2570         (WTR::TestController::resetPreferencesToConsistentValues):
2571         (WTR::TestController::platformResetPreferencesToConsistentValues):
2572         * WebKitTestRunner/TestController.h:
2573         * WebKitTestRunner/ios/TestControllerIOS.mm:
2574         (WTR::TestController::platformResetPreferencesToConsistentValues):
2575         * WebKitTestRunner/mac/TestControllerMac.mm:
2576         (WTR::TestController::platformResetPreferencesToConsistentValues):
2577
2578 2014-10-16  Dan Bernstein  <mitz@apple.com>
2579
2580         OSObjectPtr is missing leakRef()
2581         https://bugs.webkit.org/show_bug.cgi?id=137798
2582
2583         Reviewed by Sam Weinig.
2584
2585         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp:
2586         (TestWebKitAPI::TEST(OSObjectPtr, LeakRef)): Added.
2587
2588 2014-10-16  Lucas Forschler  <lforschler@apple.com>
2589
2590         Update target platform to remove Leopard, Snow Leopard, Lion.
2591         Add Yosemite. 
2592         
2593         Unreviewed.
2594
2595         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2596         (_should_file_trigger_build):
2597
2598 2014-10-16  David Kilzer  <ddkilzer@apple.com>
2599
2600         commit-queue: fails to replace OO-PS! with reviewer name
2601         <http://webkit.org/b/137795>
2602
2603         Reviewed by Alexey Proskuryakov.
2604
2605         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2606         (Bugzilla.fetch_bug_dictionary): Bugzilla 4.2.x never gives out
2607         email addresses to unauthenticated page loads, so we must always
2608         authenticate before getting bug data so we get full email
2609         addresses.
2610
2611 2014-10-16  David Kilzer  <ddkilzer@apple.com>
2612
2613         commit-queue: fails to close bugs after successfully landing patches
2614         <http://webkit.org/b/137794>
2615
2616         Reviewed by Alexey Proskuryakov.
2617
2618         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2619         (Bugzilla.clear_attachment_flags): Change 'nr=0' to 'nr=1' to
2620         tell Mechanize to use the second <textarea> on the page with
2621         name="comment".
2622
2623 2014-10-16  Brent Fulgham  <bfulgham@apple.com>
2624
2625         [Win] Update DRT to match Mac Logic
2626         https://bugs.webkit.org/show_bug.cgi?id=137787
2627
2628         Reviewed by Dean Jackson.
2629
2630         * DumpRenderTree/win/DumpRenderTree.cpp:
2631         (initialize): 0 -> nullptr
2632         (runTest): Initialize MSG structure before using.
2633         (main): Add CRT debug flags if building DRT with debug malloc on Windows.
2634         Also, cleanly shut down COM when exiting.
2635         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2636         (FrameLoadDelegate::didChangeLocationWithinPageForFrame): Move from
2637         header and add printf to match Mac.
2638         (FrameLoadDelegate::windowScriptObjectAvailable): Ditto.
2639         * DumpRenderTree/win/FrameLoadDelegate.h:
2640         (FrameLoadDelegate::didChangeLocationWithinPageForFrame): Deleted.
2641         (FrameLoadDelegate::windowScriptObjectAvailable): Deleted.
2642         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2643         (isLocalhost): Added.
2644         (hostIsUsedBySomeTestsToGenerateError): Added.
2645         (ResourceLoadDelegate::willSendRequest): Add logic to mimic Mac's use
2646         of certain error and redirect host names.
2647         * DumpRenderTree/win/UIDelegate.cpp:
2648         (UIDelegate::runJavaScriptAlertPanelWithMessage): Use 'done' flag to decide if
2649         anything should be output to the console. This modifies behavior to match the Mac.
2650         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
2651         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
2652         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
2653         (UIDelegate::webViewAddMessageToConsole): Ditto.
2654         * WinLauncher/PageLoadTestClient.cpp:
2655         (PageLoadTestClient::pageLoadEndedAtTime): Drive-by-fix for an assertion that I
2656         added last week.
2657
2658 2014-10-16  Commit Queue  <commit-queue@webkit.org>
2659
2660         Unreviewed, rolling out r174754.
2661         https://bugs.webkit.org/show_bug.cgi?id=137789
2662
2663         Speculative fix for Windows test was ineffective. (Requested
2664         by rfong on #webkit).
2665
2666         Reverted changeset:
2667
2668         "[Windows] Add some more logging to debug Windows test
2669         issues."
2670         http://trac.webkit.org/changeset/174754
2671
2672 2014-10-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2673
2674         Unreviewed, add myself to CoordinatedGraphics watchers.
2675
2676         * Scripts/webkitpy/common/config/watchlist:
2677
2678 2014-10-15  Roger Fong  <roger_fong@apple.com>
2679
2680         [Windows] Speculative Windows test fix.
2681
2682         * DumpRenderTree/win/DumpRenderTree.cpp: Make sure that OLEAUT32.dll doesn't cache BSTRs.
2683
2684 2014-10-15  Rebecca Hauck  <rhauck@adobe.com>
2685
2686         import-w3c-test rewrites relative src paths in ref files incorrectly
2687         https://bugs.webkit.org/show_bug.cgi?id=137586
2688
2689         This patch fixes a bug in test_converter.py where src paths were getting 
2690         rewritten as ../../some-path instead of <script src="../../some-path>". 
2691         It also adds support for rewriting src paths in style  elements, which was 
2692         missing before and it adds tests for this case.
2693
2694         Reviewed by Bem Jones-Bey.
2695
2696         * Scripts/webkitpy/w3c/test_converter.py:
2697         (_W3CTestConverter.convert_attributes_if_needed):
2698         * Scripts/webkitpy/w3c/test_converter_unittest.py:
2699         (test_convert_attributes_if_needed):
2700         (verify_reference_relative_paths):
2701
2702 2014-10-15  Jake Nielsen  <jacob_nielsen@apple.com>
2703
2704         Add --json flag to test-webkitpy to emit JSON formatted test results
2705         to stdout
2706         https://bugs.webkit.org/show_bug.cgi?id=137353
2707
2708         Reviewed by Daniel Bates.
2709
2710         * Scripts/webkitpy/port/server_process_unittest.py:
2711         Adds the read method to MockFile to allow the stdout of test_webkitpy
2712         to be redirected without causing erroneous test failures.
2713         In particular,
2714         webkitpy.port.server_process_unittest.TestServerProcess.test_broken_pipe
2715         and
2716         webkitpy.port.server_process_unittest.TestServerProcess.test_cleanup
2717         because when redirecting to a file, the
2718         _wait_for_data_and_update_buffers_using_select method in 
2719         server_process.py will find that there is a read file descriptor in
2720         its call to select.select, which eventually leads to it calling read()
2721         on the MockFile object.
2722         (MockFile.read):
2723         * Scripts/webkitpy/test/main.py:
2724         Adds the _print_results_as_json method and the --json flag which
2725         determines whether _print_results_as_json will get called.
2726         (Tester._parse_args):
2727         (Tester._print_results_as_json):
2728         (Tester._print_results_as_json.result_dict_from_tuple):
2729         (Tester._run_tests):
2730
2731 2014-10-13  David Farler  <dfarler@apple.com>
2732
2733         [iOS] LayoutTestRelay: Detect broken pipe when reading simulator app's stdout and stderr.
2734         https://bugs.webkit.org/show_bug.cgi?id=137662
2735
2736         Reviewed by Darin Adler.
2737
2738         The layout test harness can close LayoutTestRelay's subprocess
2739         stdout and stderr in the case of a timeout or if a run is
2740         cancelled and the FIFOs are cleaned up. If LayoutTestRelay
2741         finds that no one is listening to its stdout/stderr (broken
2742         pipe), then just exit(1), there is nothing to report.
2743
2744         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2745         (-[LTRelayController didReceiveStdoutData:]):
2746         Add @try/@catch for NSFileHandleOperationException.
2747         (-[LTRelayController didReceiveStderrData:]):
2748         Add @try/@catch for NSFileHandleOperationException.
2749
2750 2014-10-15  Rohit Kumar  <kumar.rohit@samsung.com>
2751
2752         [GTK] Minibrowser : Add keyboard support for zoom in , zoom out and default zoom in GTK Minibrowser
2753         https://bugs.webkit.org/show_bug.cgi?id=137060
2754
2755         Reviewed by Philippe Normand.
2756
2757         Add keyboard support for zoom in , zoom out and default zoom using 'Ctrl' + '+', 'Ctrl' + '-' and 'Ctrl' + '0' respectively.
2758
2759         * MiniBrowser/gtk/BrowserWindow.c:
2760         (zoomInCallback):
2761         (zoomOutCallback):
2762         (defaultZoomCallback): Callback for default zoom keyboard support.
2763         (browser_window_init):
2764
2765 2014-10-14  Simon Fraser  <simon.fraser@apple.com>
2766
2767         [Mac] DRT stderr logging after the test completes gets attributed to the next test
2768
2769         Reviewed by Alexey Proskuryakov.
2770         
2771         DRT would send "#EOF" to stderr just after doing so to stdout, which cause any later
2772         logging to stderr to get associated with the next test.
2773         
2774         Fix by logging #EOF to stderr later, after we've completely finished with this test.
2775
2776         * DumpRenderTree/mac/DumpRenderTree.mm:
2777         (dumpTestResults):
2778         (runTest):
2779
2780 2014-10-14  Brent Fulgham  <bfulgham@apple.com>
2781
2782         [Win] Unreviewed gardening. Ignore Visual Studio *.sdf temporary files.
2783
2784         * DumpRenderTree/DumpRenderTree.vcxproj: Modified property svn:ignore.
2785
2786 2014-10-14  Csaba Osztrogonác  <ossy@webkit.org>
2787
2788         [cmake] Fix the make build after r174683
2789         https://bugs.webkit.org/show_bug.cgi?id=137703
2790
2791         Reviewed by Martin Robinson.
2792
2793         * Scripts/webkitdirs.pm:
2794         (buildCMakeGeneratedProject):
2795
2796 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
2797
2798         Adding myself to the watchlist to CachedFont
2799
2800         Unreviewed.
2801
2802         * Scripts/webkitpy/common/config/watchlist:
2803
2804 2014-10-14  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2805
2806         [EFL][GTK] Make it possible to get verbose output with ninja
2807         https://bugs.webkit.org/show_bug.cgi?id=137606
2808
2809         Reviewed by Csaba Osztrogonác.
2810
2811         * Scripts/webkitdirs.pm:
2812         (buildCMakeGeneratedProject):
2813
2814 2014-10-14  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2815
2816         [EFL] Make it possible to use ninja for EFL build too
2817         https://bugs.webkit.org/show_bug.cgi?id=137605
2818
2819         Reviewed by Csaba Osztrogonác.
2820
2821         * Scripts/webkitdirs.pm:
2822         (generateBuildSystemFromCMakeProject):
2823         * efl/install-dependencies:
2824
2825 2014-10-14  Rohit Kumar  <kumar.rohit@samsung.com>
2826
2827         [GTK] Minibrowser : Add home buton and keyboard support for home page load
2828         https://bugs.webkit.org/show_bug.cgi?id=137486
2829
2830         Reviewed by Philippe Normand.
2831
2832         * MiniBrowser/gtk/BrowserWindow.c:
2833         (loadHomePage): Callback for home page load.
2834         (browser_window_init):
2835         * MiniBrowser/gtk/BrowserWindow.h:
2836         * MiniBrowser/gtk/main.c:
2837         (main):
2838
2839 2014-10-14  Manuel Rego Casasnovas  <rego@igalia.com>
2840
2841         import-w3c-tests doesn't prefix property values
2842         https://bugs.webkit.org/show_bug.cgi?id=137600
2843
2844         Reviewed by Bem Jones-Bey.
2845
2846         Some property values are prefixed in WebKit. Modified the W3C import
2847         script in order to prefix property values and not only properties.
2848         The patch re-uses most of the already existent logic to prefix
2849         properties.
2850
2851         * Scripts/webkitpy/w3c/test_converter.py: Read prefixed property values
2852         from CSSValueKeywords.in and adapt converter to modify both properties
2853         and property values.
2854         (convert_for_webkit):
2855         (_W3CTestConverter.__init__):
2856         (_W3CTestConverter.output):
2857         (_W3CTestConverter.read_webkit_prefixed_css_property_list):
2858         (_W3CTestConverter):
2859         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties_and_values):
2860         (_W3CTestConverter.add_webkit_prefix_following_regex):
2861         (_W3CTestConverter.convert_reference_relpaths):
2862         (_W3CTestConverter.convert_style_data):
2863         (_W3CTestConverter.convert_attributes_if_needed):
2864         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties): Deleted.
2865         * Scripts/webkitpy/w3c/test_converter_unittest.py: Updated unit test to
2866         include checks for property values too.
2867         (W3CTestConverterTest.test_read_prefixed_property_list):
2868         (verify_no_conversion_happened):
2869         (verify_prefixed_properties):
2870         (verify_prefixed_property_values):
2871         (generate_test_content_properties_and_values):
2872         (generate_test_content):
2873         * Scripts/webkitpy/w3c/test_importer.py: Modified importer to manage
2874         prefixed property values and inform about them.
2875         (TestImporter.import_tests):
2876         (TestImporter.write_import_log):
2877
2878 2014-10-13  Jer Noble  <jer.noble@apple.com>
2879
2880         MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
2881         https://bugs.webkit.org/show_bug.cgi?id=137533
2882
2883         Reviewed by Andy Estes.
2884
2885         Follow up patch; bail out of the test early (without failing) if the platform does not support MSE.
2886
2887         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
2888         (TestWebKitAPI::isMSEEnabledCallback):
2889         (TestWebKitAPI::TEST):
2890
2891 2014-10-13  Brent Fulgham  <bfulgham@apple.com>
2892
2893         [Win] Implement a page load profiling tool
2894         https://bugs.webkit.org/show_bug.cgi?id=137673
2895
2896         Reviewed by Dean Jackson.
2897
2898         Add a tool to capture and summarize page load statistics.
2899
2900         * WinLauncher/Common.cpp:
2901         (parseCommandLine): Move from WinMain.cpp so that it can
2902         be shared with internal tools.
2903         * WinLauncher/PageLoadTestClient.cpp: Added.
2904         (PageLoadTestClient::PageLoadTestClient):
2905         (PageLoadTestClient::pageLoadStartedAtTime):
2906         (PageLoadTestClient::didStartProvisionalLoad):
2907         (PageLoadTestClient::didCommitLoad):
2908         (PageLoadTestClient::didFirstLayoutForMainFrame):
2909         (PageLoadTestClient::didHandleOnLoadEvents):
2910         (PageLoadTestClient::didFinishLoad):
2911         (PageLoadTestClient::didFailLoad):
2912         (PageLoadTestClient::didInitiateResourceLoad):
2913         (PageLoadTestClient::didEndResourceLoad):
2914         (PageLoadTestClient::pageLoadEndedAtTime):
2915         (PageLoadTestClient::endPageLoad):
2916         (PageLoadTestClient::clearPageLoadState):
2917         (PageLoadTestClient::shouldConsiderPageLoadEnded):
2918         (PageLoadTestClient::maybeEndPageLoadSoon):
2919         (PageLoadTestClient::setPageURL):
2920         (PageLoadTestClient::dumpRunStatistics):
2921         * WinLauncher/PrintWebUIDelegate.cpp:
2922         (PrintWebUIDelegate::createWebViewWithRequest): Handle
2923         nullptr URL properly.
2924         * WinLauncher/ResourceLoadDelegate.cpp: Added.
2925         (ResourceLoadDelegate::QueryInterface):
2926         (ResourceLoadDelegate::AddRef):
2927         (ResourceLoadDelegate::Release):
2928         (ResourceLoadDelegate::identifierForInitialRequest):
2929         (ResourceLoadDelegate::willSendRequest):
2930         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2931         (ResourceLoadDelegate::didCancelAuthenticationChallenge):
2932         (ResourceLoadDelegate::didReceiveResponse):
2933         (ResourceLoadDelegate::didReceiveContentLength):
2934         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
2935         (ResourceLoadDelegate::didFailLoadingWithError):
2936         (ResourceLoadDelegate::plugInFailedWithError):
2937         * WinLauncher/ResourceLoadDelegate.h: Added.
2938         (ResourceLoadDelegate::ResourceLoadDelegate):
2939         * WinLauncher/WinLauncher.cpp:
2940         (WinLauncher::WinLauncher): Accept argument to indicate we want to capture
2941         page loading statistics.
2942         (WinLauncher::setFrameLoadDelegatePrivate): Get rid of stub implementation
2943         and set private load delegate state.
2944         (WinLauncher::setResourceLoadDelegate): Replace stub with a full implementation
2945         that sets the view's resource load delegate.
2946         (WinLauncher::loadURL): If no URL is passed, load the test document.
2947         * WinLauncher/WinLauncher.h:
2948         (WinLauncher::pageLoadTestClient):
2949         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Updated for new source files.
2950         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Ditto.
2951         * WinLauncher/WinLauncherWebHost.cpp:
2952         (WinLauncherWebHost::updateAddressBar): Hook into page load statistics routine.
2953         (WinLauncherWebHost::loadURL): Moved 'SendMessage' call to its own method so that
2954         it could be used from other source files.
2955         (WinLauncherWebHost::didFinishLoadForFrame): Added overload to capture statistics.
2956         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Ditto.
2957         (WinLauncherWebHost::didFailLoadWithError): Ditto.
2958         (WinLauncherWebHost::didHandleOnloadEventsForFrame): Ditto.
2959         (WinLauncherWebHost::didFirstLayoutInFrame): Ditto.
2960         (WinLauncherWebHost::didFinishDocumentLoadForFrame): Ditto.
2961         (WinLauncherWebHost::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
2962         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Deleted.
2963         * WinLauncher/WinLauncherWebHost.h:
2964         * WinLauncher/WinMain.cpp:
2965         (wWinMain): Create and use new delegates for gathering page load data.
2966         * WinLauncher/stdafx.h: Need to add <wtf/Platform> include for various macros used in build.
2967
2968 2014-10-13  Simon Fraser  <simon.fraser@apple.com>
2969
2970         Improve the test image diffs page
2971         https://bugs.webkit.org/show_bug.cgi?id=137674
2972
2973         Reviewed by Alexey Proskuryakov.
2974         
2975         Don't treat the input file as a format string, otherwise we have to escape special
2976         characters. Just do a couple of replaces.
2977
2978         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2979         (TestResultWriter.write_image_diff_files):
2980
2981 2014-10-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2982
2983         [XvfbDriver] Regular expression used to match running X servers fails on Fedora 21.
2984         https://bugs.webkit.org/show_bug.cgi?id=137659
2985
2986         Reviewed by Martin Robinson.
2987
2988         * Scripts/webkitpy/port/xvfbdriver.py:
2989         (XvfbDriver._next_free_display): Update the regular expression to also match Xorg.bin
2990
2991 2014-10-13  Alexey Proskuryakov  <ap@apple.com>
2992
2993         Add more detailed wait time information to EWS metrics
2994         https://bugs.webkit.org/show_bug.cgi?id=137649
2995
2996         Reviewed by Daniel Bates.
2997
2998         Added average and worst time (we used to only have median), and also a percentage
2999         of patches that took a non-trivial time to start. Non-trivial is defined as 3 minutes.
3000
3001         There is always some wait due to the polling nature of the queues, which is well understood
3002         and doesn't need to be measured. What needs to be measured is whether there is enough
3003         bot machines to process patches as soon as they are submitted.
3004
3005         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
3006         (Analyzer.prototype._analyzeBubblePerformance):
3007         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
3008         (MetricsBubbleView.prototype._update):
3009
3010 2014-10-11  Jer Noble  <jer.noble@apple.com>
3011
3012         MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
3013         https://bugs.webkit.org/show_bug.cgi?id=137533
3014
3015         Reviewed by Darin Adler.
3016
3017         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3018         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
3019         (TestWebKitAPI::TEST):
3020         * TestWebKitAPI/Tests/WebKit2/file-with-mse.html: Added.
3021         * TestWebKitAPI/Tests/WebKit2/test-mse.mp4: Added.
3022
3023 2014-10-13  Simon Fraser  <simon.fraser@apple.com>
3024
3025         iOS DRT snapshots are limited to the page visible area
3026         https://bugs.webkit.org/show_bug.cgi?id=137650
3027
3028         Reviewed by Daniel Bates.
3029         
3030         LegacyTileCache drawing was limited to the window's visible area, found by
3031         crawling up the layer hierarchy to the root layer. This caused test snapshots to
3032         be missing non-composited content outside the iPhone visible area, which hinders
3033         testing.
3034         
3035         Fix by adding a test-only mode where the window visible area is the entire window.
3036         
3037         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3038         (dumpWebViewAsPixelsAndCompareWithExpected): Drive-by RetainPtr fix.
3039         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3040         (-[DumpRenderTreeWindow initWithLayer:]): Call setEntireWindowVisibleForTesting:YES
3041         for the DRT window.
3042         
3043
3044 2014-10-12  Simon Fraser  <simon.fraser@apple.com>
3045
3046         Page not fully rendered in iOS DRT snapshots
3047         https://bugs.webkit.org/show_bug.cgi?id=137638
3048
3049         Reviewed by Tim Horton.
3050         
3051         In iOS DumpRenderTree, we need to wait for a cycle of the WebThread runloop
3052         to ensure that the page has laid out and is rendered by the time we take
3053         the snapshot.
3054
3055         * DumpRenderTree/mac/DumpRenderTree.mm:
3056         (-[DumpRenderTree _webThreadEventLoopHasRun]): Moved.
3057         (-[DumpRenderTree _webThreadInvoked]): Moved.
3058         (-[DumpRenderTree _waitForWebThreadThenDump]):
3059         (dump): Use a performSelectorOnMainThread:withObject:waitUntilDone:NO to wait
3060         for a cycle of the WebThrewd runloop. We can't just call _waitForWebThread because
3061         that blocks on a delegate callback, and we can't dispatch_async because _waitForWebThread
3062         relies on dispatch_async too, and the inner block won't complete until the outer block
3063         has completed.
3064         (dumpTestResults): Move the guts of dump() here.
3065         (runTest): Whitespace.
3066
3067 2014-10-12  Alexey Proskuryakov  <ap@apple.com>
3068
3069         Adding svn:ignore so that .pyc files don't show up as new.
3070
3071         * Scripts/webkitpy/xcode: Added property svn:ignore.
3072
3073 2014-10-12  Ryuan Choi  <ryuan.choi@gmail.com>
3074
3075         [EFL] Introduce EWebKit_Extension
3076         https://bugs.webkit.org/show_bug.cgi?id=134921
3077
3078         Reviewed by Gyuyoung Kim.
3079
3080         * MiniBrowser/efl/main.c: Added x option to test extension path.
3081         (window_create):
3082         (elm_main):
3083         * Scripts/webkitpy/common/config/watchlist:
3084         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.
3085         * Scripts/webkitpy/style/checker.py:
3086         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.
3087
3088 2014-10-11  Simon Fraser  <simon.fraser@apple.com>
3089
3090         After r174628 we send the test process a SIGTERM before the SIGKILL.
3091
3092         * Scripts/webkitpy/common/system/executive_unittest.py:
3093         (ExecutiveTest.serial_test_kill_process):
3094
3095 2014-10-11  KwangHyuk Kim  <hyuki.kim@samsung.com>
3096
3097         [EFL] Enable WebP support.
3098         https://bugs.webkit.org/show_bug.cgi?id=136156
3099
3100         Reviewed by Gyuyoung Kim.
3101
3102         Include libwebp-dev package to support WebP for WK2 Efl.
3103
3104         * efl/install-dependencies:
3105
3106 2014-10-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3107
3108         [GLIB] Split GMainLoopSource moving thread safe implementation to its own class GThreadSafeMainLoopSource
3109         https://bugs.webkit.org/show_bug.cgi?id=137485
3110
3111         Reviewed by Sergio Villar Senin.
3112
3113         Update GMainLoopSource tests. Most of the tests are now run twice,
3114         first with a GMainLoopSource and then with a
3115         GThreadSafeMainLoopSource, since both should have the same
3116         behaviour. The threading test uses GThreadSafeMainLoopSource and
3117         the delete on destroy test uses GMainLoopSource. The tests
3118         themselves haven't changed, since there's no change in behaviour.
3119
3120         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
3121         (TestWebKitAPI::GMainLoopSourceTest::source):
3122         (TestWebKitAPI::basicRescheduling):
3123         (TestWebKitAPI::TEST):
3124         (TestWebKitAPI::reentrantRescheduling):
3125         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch):
3126         (TestWebKitAPI::basicDestroyCallbacks):
3127         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch):
3128         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch):
3129
3130 2014-10-10  Dana Burkart  <dburkart@apple.com>
3131
3132         Fix fat-fingered function name in git-add-reviewer.
3133
3134         Unreviewed.
3135
3136         * Scripts/git-add-reviewer:
3137         (getConfigValue):
3138
3139 2014-10-10  David Farler  <dfarler@apple.com>
3140
3141         [iOS] LayoutTestRelay should ensure its DRT/WKTR dies when receiving kill/term signals
3142         https://bugs.webkit.org/show_bug.cgi?id=137528
3143
3144         Reviewed by Simon Fraser.
3145
3146         Catch SIGINT and SIGTERM signals in the LayoutTestRelay
3147         and SIGKILL the paired simulator app before exiting cleanly.
3148
3149         webkitpy only uses SIGKILL to kill processes which you cannot
3150         catch. Send SIGTERM to the process and give it chance to do
3151         its thing before sending SIGKILL. Sending a SIGKILL to an already
3152         dead PID is safe.
3153
3154         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
3155         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3156         (-[LTRelayController finish]):
3157         * LayoutTestRelay/LayoutTestRelay/main.m:
3158         (receivedSignal):
3159         (main):
3160
3161 2014-10-10  David Farler  <dfarler@apple.com>
3162
3163         [iOS] LayoutTestRelay should detect EOF and properly signal underlying DRT/WKTR
3164         https://bugs.webkit.org/show_bug.cgi?id=137527
3165
3166         Reviewed by Simon Fraser.
3167
3168         NSFileHandle doesn't notify of EOF in its readability handler.
3169         Use a dispatch_source_t and an event handler that is called when reading is possible.
3170         In the handler block, do a run-of-the-mill read(2) from standard input and
3171         detect EOF in the usual way by checking that zero bytes were read.
3172
3173         Once an EOF is received, the FIFOs are disconnected, the simulator app
3174         is killed, and the relay exits with status 0.
3175
3176         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3177         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]):
3178         (-[LTRelayController didDisconnect]):
3179         (-[LTRelayController didConnect]):
3180         (-[LTRelayController launchApp]):
3181         Rename "dispatchSource" to "simulatorAppExitDispatchSource" to prevent any
3182         confusion with this new dispatch source, called "standardInputDispatchSource".
3183         (-[LTRelayController finish]): Added.
3184         (-[LTRelayController readFileHandle:]): Deleted.
3185
3186 2014-10-10  KwangHyuk Kim  <hyuki.kim@samsung.com>
3187
3188         [EFL] Crash on facebook.com
3189         https://bugs.webkit.org/show_bug.cgi?id=137562
3190
3191         Reviewed by Chris Dumez.
3192
3193         Crash occurs on the facebook.com when the webview is resized
3194         after the <select> item is clicked but no item is chosen.
3195         This crash is just caused by the reference of invalidated variable.
3196         From the EwkView::closePopupMenu(), ewk_menu is just invalidated.
3197         Therefore ewk_menu variable is not available anymore when on_popup_menu_hide()
3198         on MiniBrowser is called.
3199         As a result, just set ewk_menu to NULL in order to prevent crash condition.
3200
3201         * MiniBrowser/efl/main.c:
3202         (on_popup_menu_hide):
3203
3204 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
3205
3206         A small wording change for clarity.
3207
3208         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
3209         (MetricsBubbleView.prototype._update):
3210
3211 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
3212
3213         Dashboard metrics page should have EWS statistics
3214         https://bugs.webkit.org/show_bug.cgi?id=137626
3215
3216         Reviewed by Ryosuke Niwa.
3217
3218         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:
3219         (BubbleQueue): Put shortName in the object, so that it's actually useful.
3220
3221         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3222         (BubbleQueueServer): Re-ordered queues to match bubble order.
3223         (BubbleQueueServer.prototype.jsonProcessingTimesURL): Added URL for the new handler.
3224         (BubbleQueueServer.prototype.loadProcessingTimes): Load the data from webkit-queues.
3225
3226         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
3227         Added analysis for bubble queues.
3228
3229         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js: Added.
3230
3231         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
3232         (buildBubbleQueuesTable): Build the UI.
3233
3234         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/metrics.html:
3235         Added JS sources to load.
3236
3237         * QueueStatusServer/app.yaml: To update app version.
3238
3239         * QueueStatusServer/handlers/processingtimesjson.py: Added.
3240
3241         * QueueStatusServer/main.py: Added a handler for processing-times-json.
3242
3243 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
3244
3245         REGRESSION: Commit queue doesn't process rollouts
3246         https://bugs.webkit.org/show_bug.cgi?id=137623
3247
3248         Reviewed by Tim Horton.
3249
3250         * QueueStatusServer/app.yaml:
3251         * QueueStatusServer/handlers/updateworkitems.py:
3252         (UpdateWorkItems._work_items_from_request):
3253
3254 2014-10-10  Simon Fraser  <simon.fraser@apple.com>
3255
3256         Fix syntax error after r174601.
3257
3258         * Scripts/run-javascriptcore-tests:
3259
3260 2014-10-10  Michael Saboff  <msaboff@apple.com>
3261
3262         Add ability to select tarfile name in run-jsc-stress-tests
3263         https://bugs.webkit.org/show_bug.cgi?id=137614
3264
3265         Reviewed by Mark Hahnenberg.
3266
3267         Added optional file name argument to the --tarball option.  
3268
3269         * Scripts/run-javascriptcore-tests: Added "--" to terminate options so the first
3270         extra test given after the options wont be used for the optional tarball file name.
3271         * Scripts/run-jsc-stress-tests:
3272
3273 2014-10-10  Chris Dumez  <cdumez@apple.com>
3274
3275         Unreviewed, update my information in contributors.json
3276
3277         Use my preferred first name and update my expertise areas.
3278
3279         * Scripts/webkitpy/common/config/contributors.json:
3280
3281 2014-10-10  Adrien Destugues  <pulkomandy@gmail.com>
3282
3283         Fix perl scripts to run with env on Linux
3284         https://bugs.webkit.org/show_bug.cgi?id=137601
3285
3286         Reviewed by Csaba Osztrogonác.
3287
3288         Use of arguments in #! is nonstandard and does not behave the same on
3289         different systems. Linux would look for an executable named "perl -w" 
3290         "use warnings;" does the same things in a more portable way.
3291
3292         * Scripts/commit-log-editor:
3293         * Scripts/num-cpus:
3294         * Scripts/prepare-ChangeLog:
3295         * Scripts/run-launcher:
3296         * Scripts/svn-create-patch:
3297
3298 2014-10-10  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3299
3300         [jhbuild] We should be able to disable wiping on configuration change
3301         https://bugs.webkit.org/show_bug.cgi?id=137446
3302
3303         Reviewed by Csaba Osztrogonác.
3304
3305         The default behaviour isn't changed, wiping on configuration change feature can be disabled with
3306         setting JHBUILD_WIPE_ON_CHANGE=0 environment variable
3307         or passing --no-wipe-on-change command line option.
3308
3309         * Scripts/update-webkit-libs-jhbuild:
3310
3311 2014-10-09  Andy Estes  <aestes@apple.com>
3312
3313         Teach webkitpy about OS X Yosemite
3314         https://bugs.webkit.org/show_bug.cgi?id=137585
3315
3316         Reviewed by Simon Fraser.
3317
3318         * Scripts/webkitpy/common/system/platforminfo.py:
3319         (PlatformInfo._determine_mac_version):
3320         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
3321         (TestPlatformInfo.test_os_version):
3322         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3323         (TestExpectationParser):
3324         * Scripts/webkitpy/port/builders.py:
3325         * Scripts/webkitpy/port/mac.py:
3326         (MacPort):
3327         * Scripts/webkitpy/port/mac_unittest.py:
3328         (test_versions):
3329         (test_baseline_search_path):
3330         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3331         (TestRebaselineTest.test_baseline_directory):
3332         (TestRebaselineExpectations.test_rebaseline_expectations):
3333
3334 2014-10-09  Dana Burkart  <dburkart@apple.com>
3335
3336         Add Mac OS Yosemite dashboard support.
3337
3338         Rubber-stamped by Lucas Forschler.
3339
3340         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite.png: Added.
3341         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite@2x.png: Added.
3342         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3343         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3344         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3345
3346 2014-10-08  Ryosuke Niwa  <rniwa@webkit.org>
3347
3348         Add Babak to contributors.json and add historical email addresses for some contributors
3349         https://bugs.webkit.org/show_bug.cgi?id=137546
3350
3351         Reviewed by Christophe Dumez.
3352
3353         contributors.json is used to analyze historical commit data and change logs.
3354
3355         Add back historical email addresses for some contributors and also add Babak (Shafiei).
3356
3357         * Scripts/webkitpy/common/config/contributors.json:
3358
3359 2014-10-09  Lucas Forschler  <lforschler@apple.com>
3360
3361         Add Mac OS Yosemite webkit build infrastructure.
3362         
3363         This patch adds 15 bots to our build.webkit.org configuration.
3364         We are matching the current Mavericks machines 1:1.
3365         
3366         This patch includes some minor spacing changes to the buildslaves section to make everything similar.
3367         
3368         Reviewed by Matt Hanson.
3369
3370         * BuildSlaveSupport/build.webkit.org-config/config.json:
3371
3372 2014-10-09  Dana Burkart  <dburkart@apple.com>
3373
3374         Don't use backticks when running commands, as we run into sh-related
3375         interpolation issues. Also, fix our usage of system() to properly
3376         retrieve the status code.
3377         https://bugs.webkit.org/show_bug.cgi?id=137541
3378
3379         Reviewed by Darin Adler.
3380
3381         * Scripts/git-add-reviewer:
3382         (interactive):
3383         (nonInteractive):
3384         (requireCleanWorkTree):
3385         (cherryPick):
3386         (commit):
3387         (addReviewerToFile):
3388         (head):
3389         (isAncestor):
3390         (toCommit):
3391         (changeLogsForCommit):
3392         (resetToCommit):
3393         (getConfigValue):
3394         (runCommandWithOutput):
3395
3396 2014-10-09  Tim Horton  <timothy_horton@apple.com>
3397
3398         Add a WebKit1 preference for selection services
3399         https://bugs.webkit.org/show_bug.cgi?id=137498
3400         <rdar://problem/18572699>
3401
3402         Reviewed by Simon Fraser.
3403
3404         * MiniBrowser/mac/WK1BrowserWindowController.m:
3405         (-[WK1BrowserWindowController awakeFromNib]):
3406         Turn on image and selection services in the Legacy WebKit MiniBrowser.
3407
3408 2014-10-09  Adrien Destugues  <pulkomandy@gmail.com>
3409
3410         Get the patch scripts running on Haiku
3411         https://bugs.webkit.org/show_bug.cgi?id=137559
3412
3413         Reviewed by Benjamin Poulain.
3414
3415         Use /usr/bin/env instead of hardcoding path to perl.
3416         Declare haiku platform in platforminfo.py to avoid check-webkit-style
3417         failure.
3418
3419         * Scripts/commit-log-editor:
3420         * Scripts/num-cpus:
3421         * Scripts/prepare-ChangeLog:
3422         * Scripts/run-launcher:
3423         * Scripts/svn-create-patch:
3424         * Scripts/webkitpy/common/system/platforminfo.py:
3425         (PlatformInfo._determine_os_name):
3426
3427 2014-10-08  Jake Nielsen  <jacob_nielsen@apple.com>
3428
3429         StyleQueue should throw a PatchIsNotValid exception to achieve
3430         consistency with CommitQueue and EWS
3431         https://bugs.webkit.org/show_bug.cgi?id=137500
3432
3433         Reviewed by Alexey Proskuryakov.
3434
3435         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
3436         Adds a call to validate() in run().
3437         (StyleQueueTask.run):
3438         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3439         Adds a return False in the patch is not valid exception statement.
3440         (AbstractEarlyWarningSystem.review_patch):
3441         * Scripts/webkitpy/tool/commands/queues.py:
3442         Adds a return False in the patch is not valid exception statement in
3443         commit queue, and adds an except statement to catch PatchIsNotValid
3444         exceptions in style queue.
3445         (CommitQueue.process_work_item):
3446         (StyleQueue.review_patch):
3447
3448 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3449
3450         Race condition with WebKitWebView:is-loading after starting page load
3451         https://bugs.webkit.org/show_bug.cgi?id=136692
3452
3453         Reviewed by Gustavo Noronha Silva.
3454
3455         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
3456         (loadChangedCallback): Only check is-loading is false when load
3457         has finished if the load didn't fail due to a cancellation.
3458         (loadFailedCallback): Only check is-loading is false if the load
3459         didn't fail due to a cancellation.
3460         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3461         (WebViewTest::loadURI): Check is-loading is true and active URI is
3462         the requested one rigth after requesting the load.
3463         (WebViewTest::loadHtml): Ditto.
3464         (WebViewTest::loadPlainText): Ditto.
3465         (WebViewTest::loadBytes): Ditto.
3466         (WebViewTest::loadRequest): Ditto.
3467         (WebViewTest::loadAlternateHTML): Ditto.
3468         (WebViewTest::goBack): Ditto.
3469         (WebViewTest::goForward): Ditto.
3470         (WebViewTest::goToBackForwardListItem): Ditto.
3471
3472 2014-10-08  Brent Fulgham  <bfulgham@apple.com>
3473
3474         [Win] Resolve various static analyzer warnings in Tools.
3475         https://bugs.webkit.org/show_bug.cgi?id=137534
3476
3477         Reviewed by Dean Jackson.
3478
3479         * DumpRenderTree/cg/ImageDiffCG.cpp:
3480         (main): User proper printf specifiers.
3481         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3482         (AccessibilityUIElement::childrenCount): Handle possibility that
3483         gcc_accChildCount returns with an error.
3484         (accessibilityState): Ditto for gcc_accState.
3485         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
3486         (DRTDesktopNotificationPresenter::showDesktopNotification): Use proper
3487         check for return value from 'isHTML'. HRESULT is not a boolean and cannot
3488         be treated as such.
3489         * DumpRenderTree/win/DumpRenderTree.cpp:
3490         (DumpRenderTreeWndProc): Avoid possible infinite loop on teardown caused
3491         by comparing an unsigned value as being greater-than zero.
3492         * DumpRenderTree/win/EditingDelegate.cpp:
3493         (dump): Pass proper character pointer type to printf.
3494         (EditingDelegate::shouldBeginEditingInDOMRange): Ditto.
3495         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
3496         (EditingDelegate::shouldInsertNode): Ditto.
3497         (EditingDelegate::shouldInsertText): Ditto.
3498         (EditingDelegate::shouldDeleteDOMRange): Ditto.
3499         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
3500         (EditingDelegate::shouldApplyStyle): Ditto.
3501         * DumpRenderTree/win/EventSender.cpp:
3502         (beginDragWithFilesCallback): Handle possible error case for GlobalAlloc.
3503         * DumpRenderTree/win/EventSender.h: Add proper declaration for HRESULT to match
3504         system headers.
3505         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Handle possible failure
3506         from CreateDIBSection.
3507         * DumpRenderTree/win/UIDelegate.cpp: Ensure proper type is passed to printf.
3508         * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Get rid of workaround for NaN under
3509         older versions of MSVC we no longer support.
3510         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Use proper types and API
3511         for 64-bit builds.
3512         * TestWebKitAPI/TestsController.cpp: Use NeverDestroyed like a good citizen.
3513         * TestWebKitAPI/TestsController.h: Ditto.
3514         * WinLauncher/Common.cpp: Handle possible failure from GetModuleFileName.
3515         * WinLauncher/WinLauncher.cpp: Make order of operations explicit to avoid
3516         performing bitwise | before the comparison is done.
3517
3518 2014-10-08  Ada Chan  <adachan@apple.com>
3519
3520         Add a test for WKPageIsPlayingAudio().
3521         https://bugs.webkit.org/show_bug.cgi?id=137048
3522
3523         Reviewed by Darin Adler.
3524
3525         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3526         Add file-with-video.html, test.mp4, and WKPageIsPlayingAudio.cpp to the project.
3527         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp: Added.
3528         (TestWebKitAPI::nullJavaScriptCallback):
3529         (TestWebKitAPI::didFinishLoadForFrame):
3530         (TestWebKitAPI::isPlayingAudioDidChangeCallback):
3531         (TestWebKitAPI::setUpClients):
3532         (TestWebKitAPI::TEST):
3533         This test loads a page with a video in it. When the page is loaded, we first check that
3534         WKPageIsPlayingAudio() returns false for the page. Then we call a method to start the video.
3535         When the WKPageUIClient::isPlayingAudioDidChange callback gets called, check that WKPageIsPlayingAudio()
3536         now returns true for the page.
3537         * TestWebKitAPI/Tests/WebKit2/file-with-video.html: Added.
3538         * TestWebKitAPI/Tests/WebKit2/test.mp4: Added.
3539         This is a video copied from LayoutTests/media/content.
3540
3541 2014-10-08  Csaba Osztrogonác  <ossy@webkit.org>
3542
3543         [webkitpy] Use python-irclib-0.4.8.tar.gz instead of zip in AutoInstaller
3544         https://bugs.webkit.org/show_bug.cgi?id=137516
3545
3546         Reviewed by Alexey Proskuryakov.
3547
3548         * Scripts/webkitpy/thirdparty/__init__.py:
3549         (AutoinstallImportHook._install_irc):
3550
3551 2014-10-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3552
3553         [GTK] install-dependencies should install libjpeg-turbo on Debian and derivatives.
3554         https://bugs.webkit.org/show_bug.cgi?id=137520
3555
3556         Reviewed by Philippe Normand.
3557
3558         Debian is switching is default JPEG library to libjpeg-turbo <https://wiki.debian.org/LJTTransition#Text>
3559         For other distributions, we are already installing libjpeg-turbo.
3560         So, do the same for Debian and derivatives.
3561
3562         * gtk/install-dependencies: Install libjpeg-dev that depends on the default implementation of libjpeg.
3563
3564 2014-10-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3565
3566         [webkitpy] Add back the workaround to replace ZipFile.extractall()
3567         https://bugs.webkit.org/show_bug.cgi?id=137519
3568
3569         Reviewed by Csaba Osztrogonác.
3570
3571         It was removed by <http://trac.webkit.org/changeset/174266>,
3572         because the comment stated it is a workaround for buggy python
3573         2.6.1 which shipped on Snow Leopard. But it turned out the bug
3574         is still valid with python 2.7 shipped on the latest Ubuntu
3575         (12.04 and 14.04) and OS X 10.9.
3576
3577         * Scripts/webkitpy/common/system/autoinstall.py:
3578         (AutoInstaller):
3579         (AutoInstaller._extract_all):
3580         (AutoInstaller._unzip):
3581
3582 2014-10-08  Commit Queue  <commit-queue@webkit.org>
3583
3584         Unreviewed, rolling out r174335.
3585         https://bugs.webkit.org/show_bug.cgi?id=137515
3586
3587         It broke EFL layout test totally (Requested by gyuyoung on
3588         #webkit).
3589
3590         Reverted changeset:
3591
3592         "[EFL] Introduce EWebKit_Extension"
3593         https://bugs.webkit.org/show_bug.cgi?id=134921
3594         http://trac.webkit.org/changeset/174335
3595
3596 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3597
3598         [GTK] Make forwarding headers generation depend on source code
3599         https://bugs.webkit.org/show_bug.cgi?id=137394
3600
3601         Reviewed by Philippe Normand.
3602
3603         * TestWebKitAPI/CMakeLists.txt: Add missing dependency rule.
3604         * TestWebKitAPI/PlatformGTK.cmake: Only run
3605         generate-forwarding-headers.pl when source code changes.
3606         * WebKitTestRunner/PlatformGTK.cmake: Ditto.
3607
3608 2014-10-07  Tanay C  <tanay.c@samsung.com>
3609
3610         Remove build warnings in Hashmap API tests
3611         https://bugs.webkit.org/show_bug.cgi?id=137484
3612
3613         Reviewed by Darin Adler.
3614
3615         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3616         (TestWebKitAPI::TEST): Changed EXPECT_EQ(false, addResult.isNewEntry) to EXPECT_FALSE(addResult.isNewEntry) 
3617
3618 2014-10-07  Jake Nielsen  <jacob_nielsen@apple.com>
3619
3620         Commit queue doesn't drop obsolete patches sometimes
3621         https://bugs.webkit.org/show_bug.cgi?id=137460
3622
3623         Reviewed by Alexey Proskuryakov.
3624
3625         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
3626         Adds another test patch for use in queues_unittest.py.
3627         courtesy of Csaba Osztrogonác <ossy@webkit.org>
3628         (MockBugzilla):
3629         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3630         Raises a PatchIsNotValid exception in the case of validate() returning
3631         false.