Unreviewed, rolling out r102761.
[WebKit-https.git] / Tools / ChangeLog
1 2011-12-14  Kentaro Hara  <haraken@chromium.org>
2
3         Unreviewed, rolling out r102761.
4         http://trac.webkit.org/changeset/102761
5         https://bugs.webkit.org/show_bug.cgi?id=74485
6
7         we came up with a better fix than this (see comments in bug
8         74485)
9
10         * Scripts/prepare-ChangeLog:
11         (generateFunctionLists):
12         (printDiff):
13         (diffCommand):
14         (statusCommand):
15         (createPatchCommand):
16         (generateFileList):
17         (isAddedStatus):
18         (isConflictStatus):
19         (statusDescription):
20         (extractLineRange):
21
22 2011-12-14  Anders Carlsson  <andersca@apple.com>
23
24         Work around a bug in the MSVC2005 compiler
25         https://bugs.webkit.org/show_bug.cgi?id=74550
26
27         Reviewed by Sam Weinig.
28
29         Re-enable tests.
30
31         * TestWebKitAPI/Tests/WTF/Functional.cpp:
32
33 2011-12-14  Csaba Osztrogonác  <ossy@webkit.org>
34
35         [Qt] Test fonts are not used with Qt5
36         https://bugs.webkit.org/show_bug.cgi?id=72513
37
38         My last unreviewed buildfix for this crazy bug.
39
40         * qmake/mkspecs/features/features.prf:
41
42 2011-12-14  Anders Carlsson  <andersca@apple.com>
43
44         Another attempt at fixing the Windows build.
45
46         Disable all the tests until I can figure out what's going on here.
47
48         * TestWebKitAPI/Tests/WTF/Functional.cpp:
49
50 2011-12-14  Anders Carlsson  <andersca@apple.com>
51
52         Fix the Windows build.
53
54         Disable some of the tests for now.
55
56         * TestWebKitAPI/Tests/WTF/Functional.cpp:
57
58 2011-12-14  Anders Carlsson  <andersca@apple.com>
59
60         bind should handle member functions
61         https://bugs.webkit.org/show_bug.cgi?id=74529
62
63         Reviewed by Sam Weinig.
64
65         Add tests.
66
67         * TestWebKitAPI/Tests/WTF/Functional.cpp:
68         (TestWebKitAPI::A::A):
69         (TestWebKitAPI::A::f):
70         (TestWebKitAPI::A::addF):
71         (TestWebKitAPI::TEST):
72
73 2011-12-14  Anders Carlsson  <andersca@apple.com>
74
75         Add unary and binary bind overloads
76         https://bugs.webkit.org/show_bug.cgi?id=74524
77
78         Reviewed by Sam Weinig.
79
80         Add tests.
81
82         * TestWebKitAPI/Tests/WTF/Functional.cpp:
83         (TestWebKitAPI::TEST):
84         (TestWebKitAPI::multiplyByTwo):
85         (TestWebKitAPI::multiplyByOneAndAHalf):
86         (TestWebKitAPI::multiply):
87         (TestWebKitAPI::subtract):
88
89 2011-12-14  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
90
91         [Qt] Test fonts are not used with Qt5
92         https://bugs.webkit.org/show_bug.cgi?id=72513
93
94         MIPS and SH4 buildfix after r102776 and r102795.
95
96         Reviewed by Csaba Osztrogonác.
97
98         * qmake/mkspecs/features/features.prf:
99
100 2011-12-14  Csaba Osztrogonác  <ossy@webkit.org>
101
102         [Qt] Unreviewed speculative MIPS and SH4 buildfix after r102776.
103
104         * qmake/mkspecs/features/features.prf:
105
106 2011-12-14  Andreas Kling  <kling@webkit.org>
107
108         Make my e-mail address a little more awesome.
109
110         * Scripts/webkitpy/common/config/committers.py:
111
112 2011-12-14  Csaba Osztrogonác  <ossy@webkit.org>
113
114         [Qt] Rollout r102769, because it broke Qt-4.8 builds.
115
116         * qmake/mkspecs/features/webcore.prf:
117
118 2011-12-14  Balazs Kelemen  <kbalazs@webkit.org>
119
120         [Qt] Test fonts are not used with Qt5
121         https://bugs.webkit.org/show_bug.cgi?id=72513
122
123         Reviewed by Simon Hausmann.
124
125         Don't depend on Q_WS_X11 anymore since it's not the Qt5
126         way to detect the platform. Make the guards depend
127         on our own configtest for fontconfig. For Qt4 we can still
128         use the preassumption that we have it on Linux.
129
130         * DumpRenderTree/qt/DumpRenderTree.pro:
131         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
132         (WebCore::DumpRenderTree::open):
133         (WebCore::DumpRenderTree::initializeFonts):
134         * DumpRenderTree/qt/DumpRenderTreeQt.h:
135         * DumpRenderTree/qt/main.cpp:
136         (main): Additionally remove a nonsense piece of code that was
137         trying to reset the font settings - which is not necessary -
138         after we have already returned from main.
139         * WebKitTestRunner/InjectedBundle/Target.pri:
140         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
141         (WTR::activateFonts):
142         * WebKitTestRunner/Target.pri: Remove unnecessary fontconfig linkage
143         from WTR. It is not needed. We set up the fonts via the injected bundle.
144         * qmake/config.tests/fontconfig/fontconfig.cpp: Added.
145         (main):
146         * qmake/config.tests/fontconfig/fontconfig.pro: Added.
147         * qmake/mkspecs/features/features.prf:
148         * qmake/sync.profile:
149
150 2011-12-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
151
152         [Qt] Don't add WebCoreSupport and WebKit APIs to include WebCore's include path
153
154         Followup to r102679
155
156         https://bugs.webkit.org/show_bug.cgi?id=74413
157
158         Reviewed by Simon Hausmann.
159
160         * qmake/mkspecs/features/webcore.prf:
161
162 2011-12-14  Pierre Rossi  <pierre.rossi@gmail.com>
163
164         [Qt] Mobile theme could use a little refresh
165         https://bugs.webkit.org/show_bug.cgi?id=74293
166
167         Have MiniBrowser use the mobile theme when not
168         passed --desktop.
169
170         Reviewed by Kenneth Rohde Christiansen.
171
172         * MiniBrowser/qt/MiniBrowserApplication.cpp:
173         (MiniBrowserApplication::handleUserOptions):
174
175 2011-12-14  João Paulo Rechi Vita  <jprvita@openbossa.org>
176
177         [Qt] [Gardening] Remove qt-4.7 layout tests dir
178         https://bugs.webkit.org/show_bug.cgi?id=74426
179
180         Building trunk now depends on Qt >= 4.8, so no need to keep this directory
181         on the tree.
182
183         Reviewed by Csaba Osztrogonác.
184
185         * Scripts/webkitpy/layout_tests/port/qt.py:
186         (QtPort.qt_version):
187         (QtPort.baseline_search_path):
188         (QtPort._skipped_file_search_paths):
189         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
190         (QtPortTest._assert_search_path):
191
192 2011-12-14  Kentaro Hara  <haraken@chromium.org>
193
194         [Refactoring] In prepare-ChangeLog, make $isGit and $isSVN be used only
195         through parameter passing
196         https://bugs.webkit.org/show_bug.cgi?id=74485
197
198         Reviewed by Ryosuke Niwa.
199
200         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
201         manner. This bug is one of the incremental refactorings to remove all top-level
202         code and global variables from prepare-ChangeLog. In this patch,
203         we make the following global variables be used only through parameter passing.
204             - $isGit
205             - $isSVN
206
207         * Scripts/prepare-ChangeLog:
208         (generateFunctionLists):
209         (printDiff):
210         (diffFromToString):
211         (diffCommand):
212         (statusCommand):
213         (createPatchCommand):
214         (diffHeaderFormat):
215         (generateFileList):
216         (isAddedStatus):
217         (isConflictStatus):
218         (statusDescription):
219         (extractLineRange):
220
221 2011-12-14  Alexander Færøy  <alexander.faeroy@nokia.com>
222
223         [Qt] DeviceOrientationClientMockQt should be removed in favor of DeviceOrientationClientMock
224         https://bugs.webkit.org/show_bug.cgi?id=74417
225
226         Reviewed by Simon Hausmann.
227
228         Based on original patch by Kenneth Christiansen.
229
230         Already covered by current tests.
231
232         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
233         (WebCore::DumpRenderTree::DumpRenderTree):
234         (WebCore::DumpRenderTree::~DumpRenderTree):
235         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
236         (LayoutTestController::setMockDeviceOrientation):
237
238 2011-12-03  Philippe Normand  <pnormand@igalia.com>
239
240         [GTK] Bad text rendering since r101343
241         https://bugs.webkit.org/show_bug.cgi?id=73744
242
243         Reviewed by Martin Robinson.
244
245         Turn cairo hint metrics off for better font metrics reporting in
246         the tests. This is especially important for SVG.
247
248         * DumpRenderTree/gtk/DumpRenderTree.cpp:
249         (initializeGtkFontSettings):
250         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
251         (WTR::initializeGtkSettings):
252
253 2011-12-13  Kentaro Hara  <haraken@chromium.org>
254
255         [Refactoring] Remove several global variables from prepare-ChangeLog
256         https://bugs.webkit.org/show_bug.cgi?id=74389
257
258         Reviewed by David Kilzer.
259
260         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
261         manner. This bug is one of the incremental refactorings to remove all top-level
262         code and global variables from prepare-ChangeLog. In this patch,
263         we make the following global variables being used only through parameter passing.
264             - %paths
265             - $changedFiles
266             - $conflictFiles
267             - $functionLists
268             - $bugURL
269
270         * Scripts/prepare-ChangeLog:
271         (findChangeLogs):
272         (generateNewChangeLogs):
273         (processPaths):
274         (generateFileList):
275         (firstDirectoryOrCwd):
276
277 2011-12-13  Anders Carlsson  <andersca@apple.com>
278
279         Add a very bare-bones implementation of bind and Function to WTF
280         https://bugs.webkit.org/show_bug.cgi?id=74462
281
282         Reviewed by Sam Weinig.
283
284         Add basic tests for WTF::Function and WTF::bind.
285
286         * TestWebKitAPI/TestWebKitAPI.gypi:
287         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
288         * TestWebKitAPI/Tests/Functional.cpp: Added.
289         (TestWebKitAPI::returnFortyTwo):
290         (TestWebKitAPI::TEST):
291         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
292
293 2011-12-13  Robin Dunn  <robin@alldunn.com>
294
295         [wx] Add a URL argument to wxWebView constructor.
296         https://bugs.webkit.org/show_bug.cgi?id=74316
297         
298         Reviewed by Kevin Ollivier.
299
300         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
301         (MyApp::OnInit):
302         * wx/browser/browser.cpp:
303         (MyApp::OnInit):
304
305 2011-12-13  Raphael Kubo da Costa  <kubo@profusion.mobi>
306
307         watchlist: Add watchlist for EFL, CMake and libsoup code and put myself on it.
308         https://bugs.webkit.org/show_bug.cgi?id=74430
309
310         Reviewed by David Levin.
311
312         * Scripts/webkitpy/common/config/watchlist:
313
314 2011-12-13  Peter Beverloo  <peter@chromium.org>
315
316         [Chromium] Pull in FreeType and decrease check-out complexity for Android
317         https://bugs.webkit.org/show_bug.cgi?id=74401
318
319         Decrease the check-out complexity by removing the need to first run
320         "update-webkit-chromium --chromium" prior to running it with
321         "--chromium-android", which was caused by an unversioned third_party/
322         directory being created. This moves the Android NDK to Source/WebKit/
323         chromium/, coming from third_party/ in that directory.
324
325         Reviewed by Adam Barth.
326
327         * Scripts/update-webkit-chromium:
328         * Scripts/webkitdirs.pm:
329         (buildChromiumMakefile):
330
331 2011-12-13  Andy Wingo  <wingo@igalia.com> and Martin Robinson <mrobinson@igalia.com>
332
333         build-jsc passing incorrect args to buildGtkProject
334         https://bugs.webkit.org/show_bug.cgi?id=74308
335
336         Reviewed by Gustavo Noronha Silva.
337
338         * Scripts/build-webkit: Instead of invoking buildGtkProject with
339         another argument about webkit2, unshift a --disable-webkit2
340         argument onto the buildArgs.
341         * Scripts/webkitdirs.pm: Remove $enableWebKit2 arg. Only save autogen.sh
342         arguments for WebKit to prevent unnecessary reconfiguration when build-webkit
343         and build-jsc are run one after the other.
344
345 2011-12-13  Csaba Osztrogonác  <ossy@webkit.org>
346
347         [Qt] REGRESSION(102679): It broke Qt5-WK1 build
348         https://bugs.webkit.org/show_bug.cgi?id=74413
349
350         Unreviewed buildfix.
351
352         * qmake/mkspecs/features/webcore.prf: Temporarily revert a part of r102679 until a proper fix.
353
354 2011-12-13  Csaba Osztrogonác  <ossy@webkit.org>
355
356         [Qt] Unreviewed speculativ debug buildfix after r102679.
357
358         * QtTestBrowser/QtTestBrowser.pro:
359         * QtTestBrowser/main.cpp:
360
361 2011-12-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
362
363         [Qt] Get rid of layering violations in includes
364
365         WebKit/qt/API and WebKit/qt/WebCoreSupport should not be included
366         in the webcore.prf, but rather in each target that specificly needs
367         headers in these location. We used to include them directly in webcore
368         since we had layering violations between WebCore and WebKit, but now
369         that they are gone there's no reason to do that.
370
371         Reviewed by Simon Hausmann.
372
373         * DumpRenderTree/qt/DumpRenderTree.pro:
374         * QtTestBrowser/launcherwindow.h:
375         * WebKitTestRunner/InjectedBundle/Target.pri:
376         * qmake/mkspecs/features/webcore.prf:
377         * qmake/mkspecs/features/webkit2.prf:
378
379 2011-12-13  János Badics  <dicska@gmail.com>
380
381         [NRWT] It crashes intermittently when there are WebProcess crashes
382         https://bugs.webkit.org/show_bug.cgi?id=73451
383
384         Use self.poll() instead of self._proc.poll() because it checks if self._proc is None or not.
385
386         Reviewed by Kenneth Rohde Christiansen.
387
388         * Scripts/webkitpy/layout_tests/port/server_process.py:
389         (ServerProcess._check_for_crash):
390
391 2011-12-13  Carlos Garcia Campos  <cgarcia@igalia.com>
392
393         Unreviewed. Fix GTK+ API docs build.
394
395         * gtk/generate-gtkdoc:
396         (get_webkit2_options): Ignore WebKitUIClient since it's private
397         API.
398
399 2011-12-13  Kenichi Ishibashi  <bashi@chromium.org>
400
401         Reviewed, removed one of my email addresses to use the apprpriate one.
402
403         * Scripts/webkitpy/common/config/committers.py:
404
405 2011-12-12  Ádám Kallai  <Kallai.Adam@stud.u-szeged.hu>
406
407         [Qt] Fix skip list search path and expected file search path in ORWT
408         https://bugs.webkit.org/show_bug.cgi?id=74281
409
410         Expected file search path fixed.
411
412         Print all used skipped list and expected search path in verbose mode similar to NRWT.
413
414         Reviewed by Csaba Osztrogonác.
415
416         * Scripts/old-run-webkit-tests:
417         (buildPlatformResultHierarchy):
418         (buildPlatformTestHierarchy):
419         (readSkippedFiles):
420
421 2011-12-12  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
422
423         [Qt] Missing layoutTestController.dumpWillCacheResponse
424         https://bugs.webkit.org/show_bug.cgi?id=74287
425
426         Reviewed by Csaba Osztrogonác.
427
428         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
429         (LayoutTestController::reset):
430         (LayoutTestController::dumpWillCacheResponse):
431         * DumpRenderTree/qt/LayoutTestControllerQt.h:
432
433 2011-12-12  Martin Robinson  <mrobinson@igalia.com>
434
435         [GTK] platform/gtk/fonts/custom-font-missing-glyphs.html fails on 64-bit Debug
436         https://bugs.webkit.org/show_bug.cgi?id=73771
437
438         Reviewed by Gustavo Noronha Silva.
439
440         When using a fallback font during testing, always use DejaVu Sans. This prevents
441         falling back to DejaVu Serif on some systems.
442
443         * DumpRenderTree/gtk/fonts/fonts.conf: Fall back to DejaVu Sans.
444
445 2011-12-08  Pierre Rossi  <pierre.rossi@gmail.com>
446
447         Add myself as a committer
448
449         * Scripts/webkitpy/common/config/committers.py:
450
451 2011-12-12  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
452
453         [Qt] [WK2] Support customizing popup menus with QML
454         https://bugs.webkit.org/show_bug.cgi?id=73560
455
456         Reviewed by Tor Arne Vestbø.
457
458         Add an Item Selector to our WebView using the experimental API.
459
460         * MiniBrowser/qt/MiniBrowser.pro:
461         * MiniBrowser/qt/MiniBrowser.qrc:
462         * MiniBrowser/qt/qml/BrowserWindow.qml:
463         * MiniBrowser/qt/qml/ItemSelector.qml: Added.
464
465 2011-12-12  Alexander Færøy  <alexander.faeroy@nokia.com>
466
467         [Qt] MiniBrowser should only visualize mock touch points when in non-desktop mode
468         https://bugs.webkit.org/show_bug.cgi?id=74283
469
470         Reviewed by Simon Hausmann.
471
472         * MiniBrowser/qt/MiniBrowserApplication.cpp:
473         (MiniBrowserApplication::sendTouchEvent):
474
475 2011-12-12  Kentaro Hara  <haraken@chromium.org>
476
477         [Refactoring] In prepare-ChangeLog, move into a method the top-level code
478         to show ChangeLogs diff and open ChangeLogs in an editor
479         https://bugs.webkit.org/show_bug.cgi?id=74266
480
481         Reviewed by Ryosuke Niwa.
482
483         We are planning to write unit-tests for prepare-ChangeLog
484         in a run-leaks_unittest manner. This patch is one of the incremental
485         refactorings to remove all top-level code and global variables from
486         prepare-ChangeLog.
487
488         * Scripts/prepare-ChangeLog: Moved the top-level code to show ChangeLogs diff into printDiff().
489         Moved the top-level code to open ChangeLogs in an editor into openChangeLogs().
490         Renamed @changed_files to @changedFiles.
491         Renamed %conflict_files to %conflictFiles.
492         (generateFunctionLists):
493         (printDiff):
494         (openChangeLogs):
495
496 2011-12-11  Kentaro Hara  <haraken@chromium.org>
497
498         [Refactoring] Move top-level code to resolve conflicted ChangeLogs into a method
499         https://bugs.webkit.org/show_bug.cgi?id=74257
500
501         Reviewed by Ryosuke Niwa.
502
503         We are planning to write unit-tests for prepare-ChangeLog
504         in a run-leaks_unittest/ manner. This patch is one of the incremental
505         refactorings to remove all top-level code and global variables from
506         prepare-ChangeLog.
507
508         * Scripts/prepare-ChangeLog: Moved top-level code to get the latest ChangeLogs
509         into getLatestChangeLogs(), and moved top-level code to resolve conflicted ChangeLogs
510         into resolveConflictedChangeLogs().
511         (getLatestChangeLogs):
512         (resolveConflictedChangeLogs):
513
514 2011-12-11  Kentaro Hara  <haraken@chromium.org>
515
516         [Refactoring] Move top-level code to generate a new ChangeLog into a method
517         https://bugs.webkit.org/show_bug.cgi?id=74253
518
519         Reviewed by David Kilzer.
520
521         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing,
522         which requires to remove top-level code and global variables. This patch is one of
523         the incremental refactorings for that.
524
525         * Scripts/prepare-ChangeLog: Moved top-level code to generate a new ChangeLog into generateNewChangeLogs().
526         (generateFunctionLists):
527         (findChangeLogs):
528         (generateNewChangeLogs):
529         (generateFileList): Removed an unnecessary variable $didChangeRegressionTests.
530
531 2011-12-10  Kentaro Hara  <haraken@chromium.org>
532
533         [Refactoring] In prepare-ChangeLog, move top-level code to find ChangeLogs into a method
534         https://bugs.webkit.org/show_bug.cgi?id=74175
535
536         Reviewed by Ryosuke Niwa.
537
538         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
539         This requires to remove top-level code. This patch is one of the incremental refactorings
540         for that.
541
542         * Scripts/prepare-ChangeLog: Moved top-level code to find ChangeLogs into findChangeLogs().
543         (findChangeLogs):
544
545 2011-12-10  Andreas Kling  <kling@webkit.org>
546
547         Add my Apple e-mail to committers.py.
548
549         * Scripts/webkitpy/common/config/committers.py:
550
551 2011-12-09  Dirk Pranke  <dpranke@chromium.org>
552
553         chromium win build: revert build_webkit_exes_from_webkit_gyp change
554         https://bugs.webkit.org/show_bug.cgi?id=74225
555
556         This change sets build_webkit_exes_from_webkit_gyp back to 1;
557         the "All.gyp" solution doesn't work on windows.
558
559         * Scripts/webkitdirs.pm:
560         (buildChromium):
561
562 2011-12-09  Hugo Parente Lima  <hugo.lima@openbossa.org>
563
564         [Qt] Click's count is limited to three continuous clicks.
565         https://bugs.webkit.org/show_bug.cgi?id=45666
566
567         Reviewed by Kenneth Rohde Christiansen.
568
569         Update m_time at every call to leapForward, so double clicks
570         event are correctly sent by EventSender.
571
572         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
573         (WTR::EventSenderProxy::updateClickCountForButton):
574         (WTR::EventSenderProxy::leapForward):
575
576 2011-12-09  Kentaro Hara  <haraken@chromium.org>
577
578         [Refactoring] Reduce top-level code in prepare-ChangeLog
579         https://bugs.webkit.org/show_bug.cgi?id=74172
580
581         Reviewed by Ryosuke Niwa.
582
583         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
584         This requires to remove top-level code. This patch is one of the incremental refactorings
585         for that.
586
587         * Scripts/prepare-ChangeLog: Moved some top-level code into generateFunctionLists().
588         (generateFunctionLists):
589
590 2011-12-09  Sam Weinig  <sam@webkit.org>
591
592         Expose a WKConnectionRef which represents the connection to/from the WebProcess/UIProcess
593         https://bugs.webkit.org/show_bug.cgi?id=74218
594
595         Reviewed by Anders Carlsson.
596
597         Add a test of the WKConnectionRef API.
598
599         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
600         * TestWebKitAPI/Tests/WebKit2/WKConnection.cpp: Added.
601         (TestWebKitAPI::didCreateConnection):
602         (TestWebKitAPI::connectionDidReceiveMessage):
603         (TestWebKitAPI::connectionDidClose):
604         (TestWebKitAPI::TEST):
605         * TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp: Added.
606         (TestWebKitAPI::connectionDidReceiveMessage):
607         (TestWebKitAPI::WKConnectionTest::WKConnectionTest):
608         (TestWebKitAPI::WKConnectionTest::initialize):
609
610 2011-12-09  David Levin  <levin@chromium.org>
611
612         Hash* iterators should allow comparison between const and const versions.
613         https://bugs.webkit.org/show_bug.cgi?id=73370
614
615         Reviewed by Darin Adler.
616
617         * TestWebKitAPI/TestWebKitAPI.gypi: Add the new test file to the build.
618         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
619         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
620         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Added.
621         (TestWebKitAPI::TEST): Add a test for the new functionality.
622
623 2011-12-09  Dirk Pranke  <dpranke@chromium.org>
624
625         chromium: visual studio projects are busted when build_webkit_exes_from_webkit_gyp==0
626         https://bugs.webkit.org/show_bug.cgi?id=74212
627
628         Reviewed by Tony Chang.
629
630         The change introduced in r102201 to split the executables out of
631         WebKit.gyp apparently doesn't work right on Windows, since
632         WebKit.gyp and Tools.gyp refer to dependent projects by
633         different relative paths (it appears gyp doesn't normalize the
634         paths). This change moves Tools.gyp to be in the same directory
635         as WebKit.gyp (and All.gyp), which should fix this and
636         conveniently will also solve the problem of how to add Tools.gyp
637         to the chromium DEPS file.
638
639         * Tools.gyp: Renamed to ../Source/WebKit/chromium/Tools.gyp
640
641 2011-12-09  Kentaro Hara  <haraken@chromium.org>
642
643         [Refactoring] In prepare-ChangeLog, move top-level code to fetch a bug description from URL into a method
644         https://bugs.webkit.org/show_bug.cgi?id=74173
645
646         Reviewed by Ryosuke Niwa.
647
648         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
649         This requires to remove top-level code. This patch is one of the incremental refactorings
650         for that.
651
652         * Scripts/prepare-ChangeLog: Moved top-level code to fetch a bug description from URL into fetchBugDescriptionFromURL().
653         (fetchBugDescriptionFromURL):
654
655 2011-12-09  Tony Chang  <tony@chromium.org>
656
657         Switch the chromium mac bots to using skia test results
658         https://bugs.webkit.org/show_bug.cgi?id=74201
659
660         Reviewed by Ryosuke Niwa.
661
662         This is reverting http://trac.webkit.org/changeset/97781 and changing
663         the name in master.cfg to no longer have cg in the name.
664
665         * BuildSlaveSupport/build.webkit.org-config/config.json:
666         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
667         (appendCustomBuildFlags):
668         (RunWebKitTests.start):
669
670 2011-12-09  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
671
672         [Qt] Remove a wrongly placed ASSERT.
673
674         Reviewed by Tor Arne Vestbø.
675
676         * MiniBrowser/qt/MiniBrowserApplication.cpp:
677         (MiniBrowserApplication::notify):
678
679 2011-12-09  Cary Clark  <caryclark@google.com>
680
681         layout_test update to accommodate new use_skia=1 default on Chromium-Mac
682         https://bugs.webkit.org/show_bug.cgi?id=74118
683
684         Reviewed by Adam Barth.
685
686         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
687         (get):
688         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
689         (ChromiumMacPort.__init__):
690         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
691         (ChromiumMacPortTest.test_versions):
692         (ChromiumMacPortTest.test_graphics_type):
693
694 2011-12-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
695
696         [Qt] Use new qmake option in Qt5 to prevent dependency issues with GNUmake
697
698         The GNUmake + gcc_MD_depends options together produce .d files using GCC, but
699         this failed when moving files in the source tree, as the .d file would contain
700         stale dependencies on the old source file location. By keeping the object files
701         (and hence the depdendency files) in a proper tree structure inside the objects
702         directory we can prevent this failure.
703
704         A side benefit is that we can also have objects with the same name inside the
705         same project.
706
707         Reviewed by Simon Hausmann.
708
709         * qmake/mkspecs/features/unix/default_pre.prf:
710
711 2011-12-09  Csaba Osztrogonác  <ossy@webkit.org>
712
713         Unreviewed. Update unit test after r102412.
714
715         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
716         (IRCCommandTest.test_whois):
717
718 2011-12-09  Kentaro Hara  <haraken@chromium.org>
719
720         REGRESSION(r102105): run-bindings-tests should output full diff results
721         https://bugs.webkit.org/show_bug.cgi?id=74166
722
723         Reviewed by Adam Barth.
724
725         Since r102105, the output of run-bindings-tests is truncated to 500 characters.
726         run-bindings-tests should output full diff results.
727
728         * Scripts/webkitpy/bindings/main.py: Replaced e.message_with_output() with e.output.
729         (BindingsTests.generate_from_idl):
730         (BindingsTests.generate_supplemental_dependency):
731         (BindingsTests.detect_changes):
732
733 2011-12-09  Simon Hausmann  <simon.hausmann@nokia.com>
734
735         [Qt] Fix compilation with newly separated Qt 5 QtQuick module
736         https://bugs.webkit.org/show_bug.cgi?id=73990
737
738         Reviewed by Kenneth Rohde Christiansen, tweaked by Csaba Osztrogonác.
739
740         Fix QtQuick includes after move from QtDeclarative to QtQuick.
741
742         * MiniBrowser/qt/BrowserWindow.h:
743         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
744
745 2011-12-08  Adam Klein  <adamk@chromium.org>
746
747         [MutationObservers] V8LazyEventHandler breaks microtask delivery semantics
748         https://bugs.webkit.org/show_bug.cgi?id=73492
749
750         Reviewed by Adam Barth.
751
752         Add eventSender.scheduleAsynchronousKeyDown, needed to cause a
753         keypress event without any script on the stack.
754
755         * DumpRenderTree/chromium/EventSender.cpp:
756         (EventSender::EventSender):
757         (EventSender::keyDown):
758         (KeyDownTask::KeyDownTask):
759         (KeyDownTask::runIfValid):
760         (EventSender::scheduleAsynchronousKeyDown):
761         * DumpRenderTree/chromium/EventSender.h:
762
763 2011-12-08  Hayato Ito  <hayato@chromium.org>
764
765         [gdb] Pretty printer for a 8-bit version of WTF::StringImpl and LChar*.
766         https://bugs.webkit.org/show_bug.cgi?id=73980
767
768         Reviewed by Tony Chang.
769
770         * gdb/webkit.py:
771         (guess_string_length):
772         (ustring_to_string):
773         (lstring_to_string):
774         (LCharStringPrinter):
775         (LCharStringPrinter.to_string):
776         (WTFStringImplPrinter.get_length):
777         (WTFStringImplPrinter.to_string):
778         (WTFStringImplPrinter.is_8bit):
779         (WTFStringPrinter.stringimpl_ptr):
780         (WTFStringPrinter.get_length):
781         (WTFStringPrinter.to_string):
782         (add_pretty_printers.lookup_function):
783
784 2011-12-08  Pierre Rossi  <pierre.rossi@gmail.com>
785
786         Drop ENABLE_NO_LISTBOX_RENDERING, and make it a runtime decision.
787         https://bugs.webkit.org/show_bug.cgi?id=73916
788
789         Reviewed by Kent Tamura.
790
791         * qmake/mkspecs/features/features.prf:
792
793 2011-12-08  Adrienne Walker  <enne@google.com>
794
795         Unreviewed contributor additions to committers.py.
796
797         * Scripts/webkitpy/common/config/committers.py:
798
799 2011-12-08  David Reveman  <reveman@chromium.org>
800
801         [Chromium] Add per-tile painting flag to DumpRenderTree and rename AcceleratedDrawing to AcceleratedPainting in chromium specific code.
802         https://bugs.webkit.org/show_bug.cgi?id=74017
803
804         Reviewed by James Robinson.
805         
806         Add support for command line flag enable-per-tile-painting in DumpRenderTree.
807
808         * DumpRenderTree/chromium/DumpRenderTree.cpp:
809         (main):
810         * DumpRenderTree/chromium/TestShell.cpp:
811         (TestShell::TestShell):
812         (TestShell::resetWebSettings):
813         * DumpRenderTree/chromium/TestShell.h:
814         (TestShell::setAcceleratedPaintingEnabled):
815         (TestShell::setPerTilePaintingEnabled):
816         * DumpRenderTree/chromium/WebPreferences.cpp:
817         (WebPreferences::reset):
818         (WebPreferences::applyTo):
819         * DumpRenderTree/chromium/WebPreferences.h:
820         * Scripts/webkitpy/layout_tests/port/chromium.py:
821         (ChromiumDriver._wrapper_options):
822         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
823         (parse_args):
824
825 2011-12-08  Dirk Pranke  <dpranke@chromium.org>
826
827         create a "SystemHost" object for webkitpy to slim down the Host object
828         https://bugs.webkit.org/show_bug.cgi?id=72680
829
830         Reviewed by Eric Siedel.
831
832         This creates a SystemHost object that other objects that should
833         only have dependencies on functionality in webkitpy.common.system
834         can use; this will allow them to not require a full Host.
835
836         * Scripts/webkitpy/common/host.py:
837         * Scripts/webkitpy/common/host_mock.py:
838         * Scripts/webkitpy/common/system/systemhost.py: Added.
839         * Scripts/webkitpy/common/system/systemhost_mock.py: Added.
840
841 2011-12-08  Chris Fleizach  <cfleizach@apple.com>
842
843         AX: platform/mac/accessibility/search-with-frames.html crashes
844         https://bugs.webkit.org/show_bug.cgi?id=74093
845
846         Reviewed by Darin Adler.
847
848         Take care of the case when an incoming element is null.
849
850         * DumpRenderTree/AccessibilityUIElement.cpp:
851         (uiElementForSearchPredicateCallback):
852         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
853         (AccessibilityUIElement::uiElementForSearchPredicate):
854         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
855         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
856
857 2011-12-08  Alexander Færøy  <ahf@0x90.dk>
858
859         [Qt] Visualize mock point ID's in the MiniBrowser
860         https://bugs.webkit.org/show_bug.cgi?id=74098
861
862         Reviewed by Tor Arne Vestbø.
863
864         * MiniBrowser/qt/BrowserWindow.cpp:
865         (BrowserWindow::updateVisualMockTouchPoints):
866         * MiniBrowser/qt/qml/MockTouchPoint.qml:
867
868 2011-12-08  Dominic Mazzoni  <dmazzoni@google.com>
869
870         Accessibility: AccessibilityController should support listening to notifications on all elements.
871         https://bugs.webkit.org/show_bug.cgi?id=72866
872
873         Adds addNotificationListener and removeNotificationListener methods
874         to AccessibilityController, to listen to notifications on any element
875         rather than a specific element. Mac (DRT and WKTR) and Chromium (DRT)
876         implementations are all contained in this change.
877
878         On Mac, refactors AccessibilityNotificationHandler into its own
879         source file that can be used by both AccessibilityController and
880         AccessibilityUIElement. (Both DRT and WKTR.)
881
882         Reviewed by Chris Fleizach.
883
884         * DumpRenderTree/AccessibilityController.cpp:
885         (addNotificationListenerCallback):
886         (removeNotificationListenerCallback):
887         (AccessibilityController::getJSClass):
888         * DumpRenderTree/AccessibilityController.h:
889         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
890         * DumpRenderTree/chromium/AccessibilityController.cpp:
891         (AccessibilityController::AccessibilityController):
892         (AccessibilityController::notificationReceived):
893         (AccessibilityController::addNotificationListenerCallback):
894         (AccessibilityController::removeNotificationListenerCallback):
895         * DumpRenderTree/chromium/AccessibilityController.h:
896         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
897         (AccessibilityController::addNotificationListener):
898         (AccessibilityController::removeNotificationListener):
899         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
900         (AccessibilityController::~AccessibilityController):
901         (AccessibilityController::addNotificationListener):
902         (AccessibilityController::removeNotificationListener):
903         * DumpRenderTree/mac/AccessibilityNotificationHandler.h: Added.
904         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm: Added.
905         (-[NSString createJSStringRef]):
906         (-[AccessibilityNotificationHandler init]):
907         (-[AccessibilityNotificationHandler setPlatformElement:]):
908         (-[AccessibilityNotificationHandler dealloc]):
909         (-[AccessibilityNotificationHandler setCallback:]):
910         (-[AccessibilityNotificationHandler startObserving]):
911         (-[AccessibilityNotificationHandler _notificationReceived:]):
912         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
913         (AccessibilityUIElement::addNotificationListener):
914         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
915         (notificationListenerProc):
916         (AccessibilityController::addNotificationListener):
917         (AccessibilityController::removeNotificationListener):
918         (AccessibilityController::winNotificationReceived):
919         (AccessibilityController::winAddNotificationListener):
920         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
921         (AccessibilityUIElement::addNotificationListener):
922         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
923         (WTR::AccessibilityController::addNotificationListener):
924         (WTR::AccessibilityController::removeNotificationListener):
925         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
926         (WTR::AccessibilityController::logAccessibilityEvents):
927         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
928         (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
929         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
930         (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
931         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
932         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm: Added.
933         (WTR::AccessibilityController::addNotificationListener):
934         (WTR::AccessibilityController::removeNotificationListener):
935         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h: Added.
936         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm: Added.
937         (-[NSString createJSStringRef]):
938         (-[AccessibilityNotificationHandler init]):
939         (-[AccessibilityNotificationHandler setPlatformElement:]):
940         (-[AccessibilityNotificationHandler dealloc]):
941         (-[AccessibilityNotificationHandler setCallback:]):
942         (-[AccessibilityNotificationHandler startObserving]):
943         (-[AccessibilityNotificationHandler _notificationReceived:]):
944         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
945         (WTR::AccessibilityUIElement::AccessibilityUIElement):
946         (WTR::AccessibilityUIElement::verticalScrollbar):
947         (WTR::AccessibilityUIElement::addNotificationListener):
948         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
949
950 2011-12-08  Csaba Osztrogonác  <ossy@webkit.org>
951
952         [Qt][WK2] Unreviewed buildfix after r102352.
953
954         * qmake/mkspecs/features/webkit2.prf:
955
956 2011-12-08  Adam Roben  <aroben@apple.com>
957
958         Make finding crash logs by PID work on Snow Leopard
959
960         Crash Reporter on Snow Leopard doesn't set the "app_description" extended attribute that we
961         were using to check the PID of the crashed process. (Crash Reporter on Lion does.) Now we
962         read the first line of the crash log and pull the PID out of there.
963
964         Fixes <http://webkit.org/b/74094> "webkit-patch crash-log <process> <PID>" doesn't work on
965         Snow Leopard
966
967         Reviewed by Darin Adler.
968
969         * Scripts/webkitpy/common/system/crashlogs.py:
970         (CrashLogs._find_newest_log_darwin): Read the first line of the crash log to get the process
971         name and PID for the log, rather than checking the Lion-only app_description extended
972         attribute. We now also reject the log if the process name doesn't match what we expect.
973
974         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
975         (make_mock_crash_report_darwin): Added. Returns a mock crash report given a process name and
976         PID.
977         (CrashLogsTest.assertLinesEqual): Added. This is a compatibility shim around
978         unittest.TestCase.assertMultiLineEqual, which didn't exist before Python 2.7.
979         (CrashLogsTest.test_find_log_darwin): Made the mock crash reports more believable by using
980         the new make_mock_crash_report_darwin function. Also added tests for files that can't be
981         read, files that actually contain a crash log for some other process, and files that are
982         misformatted.
983
984         * Scripts/webkitpy/common/system/filesystem.py: Removed FileSystem.getxattr, which is now
985         unused.
986
987         * Scripts/webkitpy/common/system/filesystem_mock.py:
988         (MockFileSystem.__init__): Removed xattr support, which is now unused.
989         (MockFileSystem.open_text_file_for_reading): Changed to actually pass the file's data to
990         ReadableTextFileObject. This function was completely broken before!
991         (ReadableBinaryFileObject.__init__): Made the data parameter non-optional to try to prevent
992         bugs like the above.
993         (ReadableTextFileObject.__init__): Added. Wraps the data in a StringIO object so we can do
994         things like readline() and seek().
995
996         (ReadableTextFileObject.close):
997         (ReadableTextFileObject.read):
998         Added. We override the superclass implementation to account for using a StringIO object.
999
1000         (ReadableTextFileObject.readline):
1001         (ReadableTextFileObject.seek):
1002         Added. These just call through to StringIO.
1003
1004         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1005         (MainTest.test_crash_log):
1006         (MainTest.test_web_process_crash_log):
1007         Changed to use make_mock_crash_report_darwin.
1008
1009 2011-12-06  Jon Lee  <jonlee@apple.com>
1010
1011         [WK2] Add permissions support (73960)
1012         https://bugs.webkit.org/show_bug.cgi?id=73960
1013         <rdar://problem/10357008>
1014
1015         Reviewed by Darin Adler.
1016
1017         Add null function item to comply with added callback to WKPageUIClient.
1018
1019         * MiniBrowser/mac/BrowserWindowController.m:
1020         (-[BrowserWindowController awakeFromNib]):
1021         * WebKitTestRunner/TestController.cpp:
1022         (WTR::TestController::createOtherPage):
1023         (WTR::TestController::initialize):
1024
1025 2011-12-08  Alexander Færøy  <alexander.faeroy@nokia.com>
1026
1027         [Qt] Visualize mock points in the Qt MiniBrowser
1028         https://bugs.webkit.org/show_bug.cgi?id=74074
1029
1030         Reviewed by Tor Arne Vestbø.
1031
1032         * MiniBrowser/qt/BrowserWindow.cpp:
1033         (BrowserWindow::updateVisualMockTouchPoints):
1034         * MiniBrowser/qt/BrowserWindow.h:
1035         * MiniBrowser/qt/MiniBrowser.qrc:
1036         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1037         (MiniBrowserApplication::notify):
1038         (MiniBrowserApplication::sendTouchEvent):
1039         * MiniBrowser/qt/MiniBrowserApplication.h:
1040         * MiniBrowser/qt/icons/touchpoint.png: Added.
1041         * MiniBrowser/qt/qml/MockTouchPoint.qml: Added.
1042
1043 2011-12-08  Simon Hausmann  <simon.hausmann@nokia.com>
1044
1045         [Qt] WebKitTestRunner crashes with debug builds
1046         https://bugs.webkit.org/show_bug.cgi?id=74090
1047
1048         Reviewed by Tor Arne Vestbø.
1049
1050         * WebKitTestRunner/qt/TestControllerQt.cpp:
1051         (WTR::TestController::platformInitialize): Call QQuickWebView::platformInitialize
1052         to ensure WTF/JSC threading is initialized.
1053
1054 2011-12-08  Dirk Pranke  <dpranke@chromium.org>
1055
1056         fix build-webkit --chromium after breakage in r102201
1057         https://bugs.webkit.org/show_bug.cgi?id=74031
1058
1059         Reviewed by Tony Chang.
1060
1061         * Scripts/webkitdirs.pm:
1062         (buildChromium):
1063
1064 2011-12-08  Kentaro Hara  <haraken@chromium.org>
1065
1066         Unreviewed, rolling out r102280.
1067         http://trac.webkit.org/changeset/102280
1068         https://bugs.webkit.org/show_bug.cgi?id=74031
1069
1070         Chromium/Windows build is broken
1071
1072         * Scripts/webkitdirs.pm:
1073         (buildChromium):
1074
1075 2011-12-08  Nayan Kumar K  <nayankk@motorola.com>
1076
1077         Adding myself to committers list.
1078
1079         Unreviewed.
1080
1081         * Scripts/webkitpy/common/config/committers.py:
1082
1083 2011-12-07  Michael Saboff  <msaboff@apple.com>
1084
1085         StringBuilderTest.Append and StringBuilderTest.ToStringPreserveCapacity are failing.
1086         https://bugs.webkit.org/show_bug.cgi?id=73995
1087
1088         Reenabled failing tests that the code part of the patch fixes.
1089
1090         Reviewed by Geoffrey Garen.
1091
1092         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1093         (TestWebKitAPI::TEST):
1094
1095 2011-12-07  MORITA Hajime  <morrita@google.com>
1096
1097         [filter-build-webkit] should not emit reset color when --no-color is given
1098         https://bugs.webkit.org/show_bug.cgi?id=73992
1099
1100         Reviewed by Daniel Bates.
1101
1102         Stop printing control sequences when --no-color is given.
1103         After this change, the filter runs nicely even on environments
1104         like Emacs compilation-mode which cannot understand the control sequence.
1105
1106         * Scripts/filter-build-webkit:
1107         (printLine):
1108
1109 2011-12-07  Eric Seidel  <eric@webkit.org>
1110
1111         Use free memory to determine if we have space for DRT instances instead of total memory
1112         https://bugs.webkit.org/show_bug.cgi?id=74021
1113
1114         Reviewed by Adam Barth.
1115
1116         This will hopefully make the Mac buildbots behave better.
1117
1118         I also reduced the expected memory needed per DRT now that
1119         we're properly accounting for the system memory in our calculations.
1120
1121         * Scripts/webkitpy/common/system/platforminfo.py:
1122         (PlatformInfo.total_bytes_memory):
1123         (PlatformInfo._compute_free_bytes_from_vm_stat_output):
1124         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1125         (MockPlatformInfo.total_bytes_memory):
1126         * Scripts/webkitpy/layout_tests/port/base.py:
1127         (Port.default_child_processes):
1128         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1129         (PortTest.test_default_child_processes):
1130
1131 2011-12-07  Dirk Pranke  <dpranke@chromium.org>
1132
1133         fix build-webkit --chromium after breakage in r102201
1134         https://bugs.webkit.org/show_bug.cgi?id=74031
1135
1136         Reviewed by Tony Chang.
1137
1138         r102201 introduced a change to the chromium build that splits
1139         the executables out of WebKit.gyp into other gyp files, and adds
1140         a new "All.gyp" that builds everything. However, I forgot to
1141         update the build script to use All.gyp.
1142
1143         * Scripts/webkitdirs.pm:
1144         (buildChromium):
1145
1146 2011-12-07  Tom Zakrajsek  <tomz@codeaurora.org>
1147
1148         Moved myself to the committers list.
1149
1150         * Scripts/webkitpy/common/config/committers.py:
1151
1152 2011-11-30  Simon Hausmann  <simon.hausmann@nokia.com>
1153
1154         [Qt] Fix debug shlib build with V8.
1155
1156         Reviewed by Tor Arne Vestbø.
1157
1158         * qmake/mkspecs/features/qtwebkit.prf: Don't link jscore with
1159         v8 builds.
1160
1161 2011-11-30  Simon Hausmann  <simon.hausmann@nokia.com>
1162
1163         [Qt] V8 build fixes.
1164
1165         Reviewed by Tor Arne Vestbø.
1166
1167         * qmake/mkspecs/features/javascriptcore.prf: Don't add
1168         Source/Thirdparty to the include search path here.
1169         * qmake/mkspecs/features/webcore.prf: Instead it belongs here, because it's
1170         used when building WebCore as well as using it, because header files like
1171         GraphicsContext3D.h include stuff from ThirdParty.
1172
1173 2011-12-07  Peter Beverloo  <peter@chromium.org>
1174
1175         [Chromium] Fix project file generation for the Android bot after r102201
1176         https://bugs.webkit.org/show_bug.cgi?id=73996
1177
1178         The gyp refactoring in r102201 was didn't explicitly exclude
1179         the Android operating system in Tools/Tools.gyp, which broke
1180         as gcc_version is not defined for that configuration.
1181
1182         Reviewed by Andreas Kling.
1183
1184         * Tools.gyp:
1185
1186 2011-12-07  Vsevolod Vlasov  <vsevik@chromium.org>
1187
1188         Unreviewed. Disabled failing tests on chromium.
1189
1190         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1191         (TestWebKitAPI::TEST):
1192
1193 2011-12-06  Dirk Pranke  <dpranke@chromium.org>
1194
1195         binaries in webkit.gyp should be split into a new file to break circular dependencies on webkit_support
1196         https://bugs.webkit.org/show_bug.cgi?id=73382
1197
1198         Reviewed by Tony Chang.
1199
1200         XCode (and hence GYP) can't handle circular dependencies between
1201         files (and projects). Accordingly, although the binaries in
1202         WebKit.gyp depend on webkit_support and webkit_support depends
1203         on webkit, we don't mention the latter dependency in the file.
1204         To fix this, this change moves the binaries like DRT into a new
1205         GYP file, and modifies gyp_webkit to build from that file
1206         instead of WebKit.gyp.
1207
1208         * Tools.gyp: Added.
1209
1210 2011-12-06  Adam Roben  <aroben@apple.com>
1211
1212         Add a pid parameter to CrashLogs.find_newest_log
1213
1214         When a PID is passed, only crash logs corresponding to a crashed process with that PID are
1215         considered.
1216
1217         Fixes <http://webkit.org/b/73942> webkitpy provides no way to specify the PID of the crashed
1218         process whose crash log you want to find
1219
1220         Reviewed by Dirk Pranke.
1221
1222         * Scripts/webkitpy/common/system/crashlogs.py:
1223         (CrashLogs.find_newest_log): Added an optional pid parameter.
1224         (CrashLogs._find_newest_log_darwin): Added a pid parameter. When specified, we look at each
1225         candidate log's app_description extended attribute to see if that log corresponds to a
1226         crashed process with the specified PID.
1227
1228         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
1229         (CrashLogsTest.test_find_newest_log_darwin): Added a few more mock crash logs with various
1230         contents and PIDs. Added tests that show that the pid parameter to find_newest_log is
1231         respected. Also fixed an erroneous use of assertTrue instead of assertEqual.
1232
1233         * Scripts/webkitpy/common/system/filesystem.py:
1234         (FileSystem.getxattr): Added. On Darwin, calls through to the xattr module. On other
1235         systems, raises a KeyError, mimicking the behavior on Darwin when the given attribute isn't
1236         present.
1237
1238         * Scripts/webkitpy/common/system/filesystem_mock.py:
1239         (MockFileSystem.__init__): Added an optional xattrs parameter. Documented other parameters.
1240         (MockFileSystem.getxattr): Added. Just pulls the given attribute out of the xattrs
1241         dictionary.
1242
1243         * Scripts/webkitpy/tool/commands/queries.py:
1244         (CrashLog): Added help text. Added an optional PID parameter.
1245         (CrashLog.execute): Pass the PID, if any, through to find_newest_log.
1246
1247 2011-12-06  Adam Roben  <aroben@apple.com>
1248
1249         Wait for Crash Reporter to finish even when it lets the crashed process die quickly
1250
1251         NRWT was only waiting for Crash Reporter in cases where it was keeping the crashed process
1252         alive beyond the normal timeout limit. In cases where the crashed process was able to die
1253         faster, NRWT would assume that Crash Reporter had finished even though it often was still
1254         running, which would lead to an incorrect crash log being picked up.
1255
1256         Part of <http://webkit.org/b/71380> NRWT incorrectly associates crash logs with tests
1257
1258         Reviewed by Dirk Pranke.
1259
1260         * Scripts/webkitpy/layout_tests/port/server_process.py:
1261         (ServerProcess._reset):
1262         (ServerProcess.write):
1263         (ServerProcess._check_for_crash): Changed to use new set_crashed function instead of setting
1264         .crashed directly. Added wait_for_crash_reporter parameter, which we pass along to
1265         set_crashed.
1266
1267         (ServerProcess._handle_timeout): Fixed a logic error that would cause .crashed and
1268         .timed_out both to be set to True in cases where Crash Reporter took a long time to run. Now
1269         we bail out of handling the failure as a timeout if we find out that the process in fact
1270         crashed. We tell _check_for_crash not to wait for Crash Reporter because we've already done
1271         so.
1272         (ServerProcess.set_crashed): Added. When the process crashes, we wait for Crash Reporter to
1273         finish running (unless directed otherwise) so we can be sure the crash log has been saved to
1274         disk.
1275
1276         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
1277         (TrivialMockPort.is_crash_reporter): Added.
1278
1279         * Scripts/webkitpy/layout_tests/port/webkit.py:
1280         (WebKitDriver._check_for_driver_crash): Changed to use set_crashed. (This also fixed a typo
1281         that would have partially broken crash detection on Windows, if NRWT worked on Windows.)
1282
1283 2011-12-06  Adam Barth  <abarth@webkit.org>
1284
1285         NRWT fails on unreleased versions of Mac OS X
1286         https://bugs.webkit.org/show_bug.cgi?id=72748
1287
1288         Reviewed by Dirk Pranke.
1289
1290         Hopefully this patch will make NRWT work on future versions on Mac OS X.
1291         Most of the infrastructure was already in place, but there were some
1292         asserts that failed.  I've tested this patch by haxoring the version
1293         detection logic to simulate an unknown version.  We might need to
1294         iterate based on feedback from folks with a real future version.
1295
1296         * Scripts/webkitpy/layout_tests/port/apple.py:
1297         (ApplePort.__init__):
1298             - mac-future is an allowed port_name that's used internally by
1299               webkitpy to represent future versions of Mac OS X.
1300         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1301         (test_versions):
1302             - Test that we don't throw exceptions when dealing with future
1303               versions of Mac OS X.
1304         * Scripts/webkitpy/layout_tests/port/webkit.py:
1305         (WebKitPort._expectations_from_skipped_files):
1306             - Demote this logging message to "debug".  It's expected that
1307               mac-future doesn't have a Skipped file.
1308         * Scripts/webkitpy/layout_tests/port/mac.py:
1309         (MacPort.__init__):
1310         * Scripts/webkitpy/layout_tests/port/win.py:
1311         (WinPort.__init__):
1312             - Re-order some code in these constructors so that
1313               self._operating_system is available to the ApplePort constructor.
1314
1315 2011-12-06  Tommy Widenflycht  <tommyw@google.com>
1316
1317         Added myself as a committer.
1318
1319         * Scripts/webkitpy/common/config/committers.py:
1320
1321 2011-12-06  Peter Beverloo  <peter@chromium.org>
1322
1323         Added myself as a committer.
1324
1325         * Scripts/webkitpy/common/config/committers.py:
1326
1327 2011-12-06  Kentaro Hara  <haraken@chromium.org>
1328
1329         [Refactoring] In webkitpy/bindings/main.py, replace subprocess.Popen() with Executive
1330         https://bugs.webkit.org/show_bug.cgi?id=73637
1331
1332         Reviewed by Adam Barth.
1333
1334         This patch replaces subprocess.Popen() with Executive, similar to other
1335         Python scripts in webkitpy/. I manually confirmed that run-bindings-tests
1336         works well for cases where no exception is raised, no exception is raised
1337         but diff is found, and ScriptError is raised.
1338
1339         * Scripts/run-bindings-tests:
1340         (main):
1341         * Scripts/webkitpy/bindings/main.py: Replaces subprocess.Popen() with Executive.
1342         (BindingsTests.__init__):
1343         (BindingsTests.generate_from_idl):
1344         (BindingsTests.generate_supplemental_dependency):
1345         (BindingsTests.detect_changes):
1346
1347 2011-12-05  Alexander Færøy  <alexander.faeroy@nokia.com>
1348
1349         [Qt] MiniBrowser should default to touch behavior
1350         https://bugs.webkit.org/show_bug.cgi?id=73863
1351
1352         Reviewed by Chang Shu.
1353
1354         MiniBrowser currently defaults to the traditional desktop behaviour
1355         instead of touch behaviour which is prefered.
1356
1357         * MiniBrowser/qt/BrowserWindow.cpp:
1358         (BrowserWindow::BrowserWindow):
1359         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1360         (printHelp):
1361         (MiniBrowserApplication::handleUserOptions):
1362         * MiniBrowser/qt/MiniBrowserApplication.h:
1363         (WindowOptions::WindowOptions):
1364         (WindowOptions::setUseTraditionalDesktopBehavior):
1365         (WindowOptions::useTraditionalDesktopBehavior):
1366
1367 2011-12-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
1368
1369         webkit.py: Really fix the printing of StringImpl now that 8-bit strings are present.
1370         https://bugs.webkit.org/show_bug.cgi?id=73878
1371
1372         Reviewed by Tony Chang.
1373
1374         r98624 turned StringImpl::m_data into StringImpl::{m_data8,m_data16}.
1375         r98785 made webkit.py always use m_data16, which does not work when
1376         the string is an 8-bit string (such as KURL::string()).
1377
1378         I was not able to directly call StringImpl::is8Bit() in the Python
1379         code, so I just reproduced the implementation there.
1380
1381         * gdb/webkit.py:
1382         (WTFStringPrinter.is_8bit): Reproduced StringImpl::is8Bit().
1383         (WTFStringPrinter.to_string):
1384         (JSCUStringPrinter.is_8bit): Reproduced StringImpl::is8Bit().
1385         (JSCUStringPrinter.to_string):
1386
1387 2011-12-05  Eric Seidel  <eric@webkit.org>
1388
1389         Up the "expected ram for each DRT instance" to 400MB instead of 300MB
1390         in hopes of making the Snow Leopard bot stop timing out.
1391
1392         Unreviewed.
1393
1394         * Scripts/webkitpy/layout_tests/port/base.py:
1395         (Port.default_child_processes):
1396         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1397         (PortTest.test_default_child_processes):
1398
1399 2011-12-05  Eric Seidel  <eric@webkit.org>
1400
1401         NRWT creates too many workers on RAM-limited machines
1402         https://bugs.webkit.org/show_bug.cgi?id=73847
1403
1404         Reviewed by Dirk Pranke.
1405
1406         Make NRWT restrict its number of workers when there isn't enough
1407         RAM to support them.
1408         Also re-enable parallel testing on the Mac bots which were
1409         failing due to not enough ram.
1410
1411         * Scripts/run-webkit-tests:
1412         (platformIsReadyForParallelTesting):
1413         * Scripts/webkitpy/common/host.py:
1414         (Host.__init__):
1415         * Scripts/webkitpy/common/system/executive_mock.py:
1416         (MockExecutive.cpu_count):
1417         * Scripts/webkitpy/common/system/platforminfo.py:
1418         (PlatformInfo.__init__):
1419         (PlatformInfo.display_name):
1420         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1421         (MockPlatformInfo.display_name):
1422         * Scripts/webkitpy/layout_tests/port/base.py:
1423         (Port.default_child_processes):
1424         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1425         (PortTest.test_default_child_processes):
1426         (PortTest.test_pretty_patch_os_error):
1427
1428 2011-12-05  Hugo Parente Lima  <hugo.lima@openbossa.org>
1429
1430         Last mouse event could be lost if a JS call to eventSender.leapForward is made
1431         https://bugs.webkit.org/show_bug.cgi?id=73366
1432
1433         Reviewed by Kenneth Rohde Christiansen.
1434
1435         Empty the entire event queue when requested besides using
1436         sendEvent instead of postEvent to make sure all events were
1437         delivered.
1438
1439         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
1440         (WTR::EventSenderProxy::EventSenderProxy):
1441         (WTR::EventSenderProxy::sendOrQueueEvent):
1442         (WTR::EventSenderProxy::replaySavedEvents):
1443
1444 2011-12-05  Adam Barth  <abarth@webkit.org>
1445
1446         [Chromium] Remove no-longer-used forwarding headers in the WebKit API
1447         https://bugs.webkit.org/show_bug.cgi?id=73845
1448
1449         Reviewed by Darin Fisher.
1450
1451         Update includes to point to the new header locations.
1452
1453         * DumpRenderTree/chromium/AccessibilityController.cpp:
1454         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
1455         * DumpRenderTree/chromium/CppBoundClass.cpp:
1456         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1457         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1458         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1459         * DumpRenderTree/chromium/EventSender.cpp:
1460         * DumpRenderTree/chromium/EventSender.h:
1461         * DumpRenderTree/chromium/GamepadController.h:
1462         * DumpRenderTree/chromium/LayoutTestController.cpp:
1463         * DumpRenderTree/chromium/LayoutTestController.h:
1464         * DumpRenderTree/chromium/MockSpellCheck.cpp:
1465         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1466         * DumpRenderTree/chromium/PlainTextController.cpp:
1467         * DumpRenderTree/chromium/Task.cpp:
1468         * DumpRenderTree/chromium/TestNavigationController.h:
1469         * DumpRenderTree/chromium/TestShell.cpp:
1470         * DumpRenderTree/chromium/TestWebPlugin.cpp:
1471         * DumpRenderTree/chromium/TestWebPlugin.h:
1472         * DumpRenderTree/chromium/TextInputController.cpp:
1473         * DumpRenderTree/chromium/WebPermissions.cpp:
1474         * DumpRenderTree/chromium/WebPreferences.h:
1475         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
1476         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
1477         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
1478         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
1479         * DumpRenderTree/chromium/WebViewHost.cpp:
1480
1481 2011-12-05  Ryosuke Niwa  <rniwa@webkit.org>
1482
1483         Add Aharon Lanin to the contributors list.
1484
1485         * Scripts/webkitpy/common/config/committers.py:
1486
1487 2011-12-05  Jarred Nicholls  <jarred@sencha.com>
1488
1489         Moving myself from contributors to committers.
1490
1491         * Scripts/webkitpy/common/config/committers.py:
1492
1493 2011-12-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
1494
1495         Add myself as a committer.
1496
1497         * Scripts/webkitpy/common/config/committers.py:
1498
1499 2011-12-05  Michael Brüning  <michael.bruning@nokia.com>
1500
1501         [Qt] Rename QQuickWebView::canStop property to just loading 
1502         https://bugs.webkit.org/show_bug.cgi?id=73813
1503
1504         Reviewed by Kenneth Rohde Christiansen.
1505
1506         Replaced references to WebView.canStop with WebView.loading.
1507
1508         * MiniBrowser/qt/qml/BrowserWindow.qml:
1509
1510 2011-12-05  Dirk Pranke  <dpranke@chromium.org>
1511
1512         run-webkit-tests: limit --child-processes properly on apple mac
1513         https://bugs.webkit.org/show_bug.cgi?id=73856
1514
1515         Reviewed by Adam Roben.
1516
1517         Fix typos in r102013 so that we correctly pass --child-processes=1 on
1518         the apple mac bots temporarily.
1519
1520         * Scripts/run-webkit-tests:
1521         (platformIsReadyForParallelTesting):
1522
1523 2011-12-05  Ryosuke Niwa  <rniwa@webkit.org>
1524
1525         Temporarily set --child-process=1 on Mac because 20+ tests are timing out
1526         https://bugs.webkit.org/show_bug.cgi?id=73840
1527
1528         Reviewed by Simon Fraser.
1529
1530         Temporarily go back to single process mode on Mac.
1531
1532         * Scripts/run-webkit-tests:
1533         (platformIsReadyForParallelTesting):
1534
1535 2011-12-05  Adam Roben  <aroben@apple.com>
1536
1537         Redeploy apple-macpro-7 and apple-xserve-1
1538
1539         These slaves have been sitting idle since we removed our Leopard builders in r97496.
1540
1541         Fixes <http://webkit.org/b/73829> REGRESSION (r97496): apple-macpro-7 and apple-xserve-1 are
1542         sitting idle
1543
1544         Reviewed by Sam Weinig.
1545
1546         * BuildSlaveSupport/build.webkit.org-config/config.json: Re-added apple-macpro-7 and
1547         apple-xserve-1. The former is now doing "SnowLeopard Intel Debug (WebKit2 Tests)", which
1548         allows apple-xserve-9 to be a build-only slave, and the latter is doing "Lion Intel Debug
1549         (WebKit2 Tests)".
1550
1551 2011-12-05  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1552
1553         [Qt] Make the UI of the MiniBrowser slightly nicer
1554
1555         Rubberstamped by Simon Hausmann.
1556
1557         - Add proper padding
1558         - Show feedback when pressing on the toolbar icons
1559         - Make the text entry better looking
1560
1561         * MiniBrowser/qt/qml/BrowserWindow.qml:
1562
1563 2011-12-05  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1564
1565         NRWT should handle duplicated expectations
1566         https://bugs.webkit.org/show_bug.cgi?id=69750
1567
1568         Reviewed by Dirk Pranke.
1569
1570         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1571         (TestExpectations.__init__):
1572         (TestExpectations._report_errors):
1573         (TestExpectations._add_expectations):
1574         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1575         (test_add_skipped_tests):
1576         * Scripts/webkitpy/layout_tests/port/base.py:
1577         (Port.skipped_tests):
1578         * Scripts/webkitpy/layout_tests/port/webkit.py:
1579         (WebKitPort.test_expectations):
1580         (WebKitPort.skipped_tests):
1581         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1582         (test_test_expectations):
1583
1584 2011-12-04  Eric Seidel  <eric@webkit.org>
1585
1586         After success with Mac, Win and Gtk, turning on parallel testing
1587         by default for all platforms (except Qt).
1588
1589         We'll add more platforms to the blacklist if we see problems.
1590
1591         Unreviewed.
1592
1593         * Scripts/run-webkit-tests:
1594         (platformIsReadyForParallelTesting):
1595
1596 2011-12-04  Sam Weinig  <sam@webkit.org>
1597
1598         Add tests for RetainPtr::adoptNS/adoptCF
1599         https://bugs.webkit.org/show_bug.cgi?id=73470
1600
1601         Reviewed by Adam Roben and Darin Adler.
1602
1603         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1604         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp: Added.
1605         (TestWebKitAPI::TEST):
1606         Test that adopting using adoptCF creates a RetainPtr with a
1607         value whose retain count is 1.
1608
1609         * TestWebKitAPI/Tests/WTF/ns: Added.
1610         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm: Added.
1611         (TestWebKitAPI::TEST):
1612         Test that adopting using adoptNS creates a RetainPtr with a
1613         value whose retain count is 1.
1614
1615 2011-12-04  Martin Robinson  <mrobinson@igalia.com>
1616
1617         [GTK] Include cairo, pixman and gnome-icon-theme in the jhbuild modules
1618         https://bugs.webkit.org/show_bug.cgi?id=73748
1619
1620         Reviewed by Gustavo Noronha Silva.
1621
1622         * gtk/jhbuild.modules: Add some new modules the jhbuild moduleset.
1623
1624 2011-12-04  Philippe Normand  <pnormand@igalia.com>
1625
1626         Another GTK build fix after r101922.
1627
1628         Rubber-stamped by Martin Robinson.
1629
1630         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1631         (LayoutTestController::pathToLocalResource): Plug possible String ref leak.
1632
1633 2011-12-04  Xan Lopez  <xlopez@igalia.com>
1634
1635         Fix compiler warning in LayoutTestController
1636
1637         Reviewed by Philippe Normand.
1638
1639         * DumpRenderTree/LayoutTestController.cpp:
1640         (LayoutTestController::LayoutTestController): fix warning.
1641
1642 2011-12-04  Alexandre Mazari  <scaroo@gmail.com>
1643
1644         Add missing methods used by fast/notifications tests to LayoutTestController
1645         https://bugs.webkit.org/show_bug.cgi?id=63616
1646
1647         Reviewed by Martin Robinson.
1648
1649         Add missing simulateDesktopNotificationClick method used by
1650         fast/notifications. Provide a default implementation for
1651         areDesktopNotificationPermissionRequestsIgnored and
1652         ignoreDesktopNotificationPermissionRequests.
1653
1654         * DumpRenderTree/LayoutTestController.cpp:
1655         (LayoutTestController::LayoutTestController): call into the port implementation.
1656         (simulateDesktopNotificationClickCallback): ditto.
1657         (ignoreDesktopNotificationPermissionRequestsCallback): default implementation.
1658         (LayoutTestController::staticFunctions): declare new methods.
1659         (LayoutTestController::ignoreDesktopNotificationPermissionRequests): default implementation.
1660         * DumpRenderTree/LayoutTestController.h:
1661         (LayoutTestController::areDesktopNotificationPermissionRequestsIgnored):
1662         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1663         (LayoutTestController::simulateDesktopNotificationClick): dummy implementation.
1664         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1665         (LayoutTestController::simulateDesktopNotificationClick): ditto.
1666         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1667         (LayoutTestController::simulateDesktopNotificationClick): ditto.
1668         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1669         (LayoutTestController::simulateDesktopNotificationClick): ditto.
1670         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1671         (LayoutTestController::simulateDesktopNotificationClick): ditto.
1672
1673 2011-12-03  Mario Sanchez Prada  <msanchez@igalia.com>
1674
1675         [GTK] Don't log document events in DRT
1676         https://bugs.webkit.org/show_bug.cgi?id=73746
1677
1678         Reviewed by Martin Robinson.
1679
1680         Stop connecting globally to document-related events.
1681
1682         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
1683         (connectAccessibilityCallbacks): Removed connections.
1684         (disconnectAccessibilityCallbacks): Removed disconnections.
1685
1686 2011-12-03  Dan Bernstein  <mitz@apple.com>
1687
1688         Added a test for <rdar://problem/10523721> Crash at WebCore::SubresourceLoader::releaseResources
1689
1690         Reviewed by Darin Adler.
1691
1692         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1693         * TestWebKitAPI/Tests/mac/SubresourceErrorCrash.mm: Added.
1694         (TestWebKitAPI::TEST):
1695
1696 2011-12-03  Philippe Normand  <pnormand@igalia.com>
1697
1698         Another GTK build fix after r101922.
1699
1700         Rubber-stamped by Martin James Robinson.
1701
1702         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1703         (LayoutTestController::pathToLocalResource): return value needs to
1704         be a URI.
1705
1706 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
1707
1708         Small fix for my previous patch. Do not try to delete a member
1709         of a dictionary that does not exist.
1710
1711         Reviewed by Gustavo Noronha Silva.
1712
1713         * gtk/run-with-jhbuild:
1714         (install_and_run_jhbuild):
1715
1716 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
1717
1718         Fix jhbuild installation for people who have unusual MAKE environment
1719         variables such as 'make -j4' as the jhbuild build does not handle it.
1720
1721         Reviewed by Gustavo Noronha Silva.
1722
1723         * gtk/run-with-jhbuild:
1724         (install_and_run_jhbuild): Remove any MAKE environment variable before building jhbuild.
1725
1726 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
1727
1728         Fix the update-webkitgtk-libs script to properly trigger a jhbuild installation
1729         when run for the first time.
1730
1731         Reviewed by Gustavo Noronha Silva.
1732
1733         * Scripts/update-webkitgtk-libs: Fix first run.
1734
1735 2011-12-03  Philippe Normand  <pnormand@igalia.com>
1736
1737         Unreviewed, GTK build fix after r101922.
1738
1739         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1740         (LayoutTestController::pathToLocalResource): Added sentinel in
1741         g_build_filename call.
1742
1743 2011-12-03  Philippe Normand  <pnormand@igalia.com>
1744
1745         GTK API tests build fix. Run the tests inside jhbuild.
1746
1747         Rubber-stamped by Gustavo Noronha Silva.
1748
1749         * Scripts/run-gtk-tests:
1750         (TestRunner.__init__):
1751         (TestRunner.run._error_handler):
1752         (TestRunner):
1753         (TestRunner.run):
1754
1755 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
1756
1757         Small build fix. Properly specify the path to the locally installed jhbuild.
1758
1759         * Scripts/update-webkitgtk-libs: Fix jhbuild path.
1760
1761 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
1762
1763         [GTK][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
1764         https://bugs.webkit.org/show_bug.cgi?id=67256
1765
1766         Reviewed by Philippe Normand.
1767
1768         Implement LayoutTestController::pathToLocalResource for GTK+. Instead of passing 
1769         WEBKIT_TEST_FONTS to the GTK+ test harnesses, pass a more generic WEBKIT_TOP_LEVEL,
1770         which points to the more generic top-level path of the WebKit checkout. This code is
1771         duplicated between WK1 and WK2 harnesses because we do not currently have a way to
1772         share code here.
1773
1774         If WEBKIT_TOP_LEVEL is not provided, we search for the top level based on the binary
1775         location. This will cause the fallback to fail if you build into a non-typical location
1776         or even fake it with a symlink. In this case it's important to use the environment variable.
1777
1778         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1779         (getTopLevelPath): Added.
1780         (initializeFonts): Use the new helper to get the font path.
1781         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Expose the new helper.
1782         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1783         (LayoutTestController::pathToLocalResource):Use the new helper to normalize
1784         test paths.
1785         * Scripts/webkitpy/layout_tests/port/gtk.py:
1786         (GtkPort.setup_environ_for_server):Pass the top-level path of the
1787         checkout instead of passing the font path.
1788         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1789         (WTR::getTopLevelPath): Added this helper.
1790         (WTR::inititializeFontConfigSetting): Use the helper to find the font path.
1791
1792 2011-12-02  David Levin  <levin@chromium.org>
1793
1794         Rename WTF class from TemporarilyChange to TemporaryChange.
1795         https://bugs.webkit.org/show_bug.cgi?id=73479
1796
1797         Reviewed by Eric Seidel.
1798
1799         * DumpRenderTree/ForwardingHeaders/wtf/TemporarilyChange.h: Removed.
1800         * DumpRenderTree/ForwardingHeaders/wtf/TemporaryChange.h: Added.
1801         * TestWebKitAPI/TestWebKitAPI.gypi:
1802         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1803         * TestWebKitAPI/Tests/WTF/TemporaryChange.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/TemporarilyChange.cpp.
1804         (TestWebKitAPI::TEST):
1805         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1806
1807 2011-12-02  Tony Chang  <tony@chromium.org>
1808
1809         [NRWT] reftest asserts intermittently on the Qt-WK2 bot
1810         https://bugs.webkit.org/show_bug.cgi?id=73453
1811
1812         Reviewed by Ryosuke Niwa.
1813
1814         We used to assert if a ref test didn't generate pixel results. Instead, just claim it is a failing test.
1815         The verbose output will include the failure reason.
1816
1817         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Don't assert, return FailureReftestNoImagesGenerated instead.
1818         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1819         (write_test_result):
1820         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py: Remove stray letter t.
1821         * Scripts/webkitpy/layout_tests/models/test_failures.py: Add a new failure type: FailureReftestNoImagesGenerated
1822         (determine_result_type):
1823         (FailureReftestNoImagesGenerated.__init__):
1824         (FailureReftestNoImagesGenerated):
1825         (FailureReftestNoImagesGenerated.message):
1826         * Scripts/webkitpy/layout_tests/port/test.py: Add a test case for integration tests.
1827         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Update test counts.
1828         (MainTest.test_run_singly_actually_runs_tests):
1829         (MainTest.test_unexpected_failures):
1830         (EndToEndTest.test_end_to_end):
1831
1832 2011-12-02  Ryosuke Niwa  <rniwa@webkit.org>
1833
1834         ChangeLog should be able to parse annotated changelogs
1835         https://bugs.webkit.org/show_bug.cgi?id=72703
1836
1837         Reviewed by Eric Seidel.
1838
1839         Make parse_entries_from_file aware of svn blame annotation such as "100000 ossy@webkit.org ",
1840         and extract the revision number for each entry.
1841
1842         Also add a support to extract "svn blame" result from svn/git checkout to scm classes.
1843
1844         * Scripts/webkitpy/common/checkout/changelog.py:
1845         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1846         * Scripts/webkitpy/common/checkout/scm/git.py:
1847         * Scripts/webkitpy/common/checkout/scm/scm.py:
1848         * Scripts/webkitpy/common/checkout/scm/svn.py:
1849
1850 2011-12-02  Eric Seidel  <eric@webkit.org>
1851
1852         Enable parallel testing for Win and Gtk bots
1853         after confirming with Lucas and Martin the bots should be OK.
1854
1855         Unreviewed. (I ran the idea by Lucas and Martin.)
1856
1857         * Scripts/run-webkit-tests:
1858         (platformIsReadyForParallelTesting):
1859
1860 2011-12-02  Martin Robinson  <mrobinson@igalia.com>
1861
1862         Try to fix the GTK+ build.
1863
1864         * gtk/jhbuild.modules: Properly specify the glib-networking
1865         dependency for soup.
1866
1867 2011-12-02  Martin Robinson  <mrobinson@igalia.com>
1868
1869         Fix a syntax error in the committers.py file.
1870
1871         * Scripts/webkitpy/common/config/committers.py: Add a missing comma.
1872
1873 2011-12-02  Ryosuke Niwa  <rniwa@webkit.org>
1874
1875         Add Alan Stearns and Peter Linss to the contributors list.
1876
1877         * Scripts/webkitpy/common/config/committers.py:
1878
1879 2011-12-02  Kent Tamura  <tkent@chromium.org>
1880
1881         [Chromium] Fix compilation warnings for ASSERT()
1882         https://bugs.webkit.org/show_bug.cgi?id=73623
1883
1884         Reviewed by Tony Chang.
1885
1886         * DumpRenderTree/chromium/ImageDiff.cpp:
1887          - Fix fprintf format: %s -> %d for __LINE__
1888          - Do nothing for ASSERT() if NDEBUG.
1889
1890 2011-12-02  Eric Seidel  <eric@webkit.org>
1891
1892         Enable parallel testing for all Mac bots.
1893
1894         Unreviewed.
1895
1896         * Scripts/run-webkit-tests:
1897         (platformIsReadyForParallelTesting):
1898
1899 2011-12-02  Eric Seidel  <eric@webkit.org>
1900
1901         Enable parallel testing for run-webkit-tests on Mac Lion.
1902         I plan to move all the machines to parallel testing shortly
1903         but we're starting with Lion.
1904
1905         Unreviewed.
1906
1907         * Scripts/run-webkit-tests:
1908         (platformIsReadyForParallelTesting):
1909
1910 2011-12-02  Kausalya Madhusudhanan  <kmadhusu@chromium.org>
1911
1912         Added helper method to identify whether the page has custom page size style.
1913         https://bugs.webkit.org/show_bug.cgi?id=73585
1914
1915         Reviewed by Darin Fisher.
1916
1917         * DumpRenderTree/chromium/LayoutTestController.cpp:
1918         (LayoutTestController::LayoutTestController):
1919         (LayoutTestController::hasCustomPageSizeStyle):
1920         * DumpRenderTree/chromium/LayoutTestController.h:
1921
1922 2011-12-01  Ryosuke Niwa  <rniwa@webkit.org>
1923
1924         [NRWT] reftest should support having multiple references per test
1925         https://bugs.webkit.org/show_bug.cgi?id=73613
1926
1927         Reviewed by Dirk Pranke.
1928
1929         Add a support for having multiple reference files for a single test.
1930
1931         Because a reftest succeeds when it matches at least one of expected matches and fails when it matches
1932         at least one of expected mismatches, we compare expected mismatches first in order to minimize
1933         the number of reference files to open on DRT.
1934
1935         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1936         (interpret_test_failures): Remove checks no longer applicable.
1937         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1938         (ResultSummaryTest.test_interpret_test_failures): Ditto.
1939         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1940         (SingleTestRunner.__init__): Remove a bunch of code and just call port.reference_files.
1941         (SingleTestRunner._driver_input):
1942         (SingleTestRunner.run):
1943         (SingleTestRunner._run_reftest): Compare the output of the test to each reference file.
1944         * Scripts/webkitpy/layout_tests/models/test_input.py:
1945         (TestInput.__init__): Remove ref_file and is_mismatch_reftest because they are no longer used.
1946         * Scripts/webkitpy/layout_tests/port/base.py:
1947         (Port.reference_files): Renamed from _reference_file_for. Returns a list of expectation, filename pairs.
1948         (_parse_reftest_list): Now supports parsing multiple entries for a single test.
1949         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1950         (PortTest.test_parse_reftest_list):
1951         * Scripts/webkitpy/layout_tests/port/test.py:
1952         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1953         (MainTest.test_unexpected_failures):
1954         (MainTest.test_reftest_skipped_if_unlisted): Renamed from test_missing_and_unexpected_results.
1955         (EndToEndTest.test_end_to_end):
1956         (EndToEndTest.test_reftest_with_two_notrefs): Added.
1957
1958 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
1959
1960         Build libsoup without gnome dependencies (like keyring).
1961
1962         * gtk/jhbuild.modules:
1963
1964 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
1965
1966         Also build gcrypt and p11-kit, and make them dependencies of
1967         gnutls.
1968
1969         * gtk/jhbuild.modules:
1970
1971 2011-12-02  Kevin Ollivier  <kevino@theolliviers.com>
1972
1973         [wx] Unreviewed build fixes for Windows build.
1974
1975         * waf/build/wxpresets.py:
1976
1977 2011-12-01  Eric Seidel  <eric@webkit.org>
1978
1979         Reviewed by Adam Barth.
1980
1981         webkit-patch post, post-commits, upload should warn when posting to a closed bug, and offer to reopen it
1982         https://bugs.webkit.org/show_bug.cgi?id=32006
1983
1984         I decided not to make it warn, and just have it re-open the bug.
1985         That's not that different from today's behavior which will
1986         just silently attach the patch.
1987
1988         This patch makes behavior between upload and land-safely consistent
1989         (previously one would assign patches and the other would not)
1990         as well as adds the ability for both to ensure that the bug is open.
1991
1992         To test this I had to add a few more methods to MockBugzilla which
1993         (positively) affected a few other test results.
1994
1995         I also made AbstractStep keep a cached copy of the Bug object
1996         and used the cached copy where appropriate (including for 'bug_title').
1997         This should reduce the number of bug fetches we perform.
1998
1999         * Scripts/webkitpy/tool/commands/download_unittest.py:
2000         * Scripts/webkitpy/tool/commands/upload.py:
2001         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2002         * Scripts/webkitpy/tool/mocktool.py:
2003         * Scripts/webkitpy/tool/steps/__init__.py:
2004         * Scripts/webkitpy/tool/steps/abstractstep.py:
2005         * Scripts/webkitpy/tool/steps/closebug.py:
2006         * Scripts/webkitpy/tool/steps/ensurebugisopenandassigned.py: Added.
2007         * Scripts/webkitpy/tool/steps/postdiff.py:
2008         * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
2009         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2010         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2011         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
2012
2013 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
2014
2015         Also pass --no-interact to jhbuild when updating dependencies.
2016
2017         * Scripts/update-webkitgtk-libs:
2018
2019 2011-12-02  Alice Boxhall  <aboxhall@chromium.org>
2020
2021         Make _build_path check more thoroughly that build paths exist.
2022         https://bugs.webkit.org/show_bug.cgi?id=73601
2023
2024         Reviewed by Ojan Vafai.
2025
2026         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2027         (ChromiumMacPort._build_path):
2028
2029 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
2030
2031         Add libffi to the jhbuild modules list as a glib dependency.
2032
2033         Rubber-stamped by Martin Robinson.
2034
2035         * gtk/jhbuild.modules:
2036
2037 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
2038
2039         Build fix. Use internal pcre on glib, make gnutls a dependency of
2040         glib-networking, unset AR_FLAGS for jhbuild builds, and run jhbuild
2041         in non-interactive mode.
2042
2043         * Scripts/update-webkitgtk-libs:
2044         * gtk/jhbuild.modules:
2045         * gtk/run-with-jhbuild:
2046
2047 2011-12-02  Adam Roben  <aroben@apple.com>
2048
2049         Fix for Python 2.6
2050
2051         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2052         (RunUnitTests.countFailures): Removed the flags parameter to re.split, which was only added
2053         in Python 2.7, and used whitespace instead of start-of-string/end-of-string markers when
2054         searching for "Tests that timed out:" etc. This makes our check less strict, but it
2055         shouldn't matter given the kinds of content we parse.
2056
2057 2011-12-02  Adam Roben  <aroben@apple.com>
2058
2059         Fix names of failed/timed out tests in run-api-tests output
2060
2061         Fixes <http://webkit.org/b/73663> run-api-tests prints suite names twice for failed or timed
2062         out tests
2063
2064         We were ending up with the suite name doubled (e.g., "WebKit2.WebKit2.MouseMoveAfterCrash").
2065
2066         Reviewed by Simon Fraser.
2067
2068         * Scripts/run-api-tests:
2069         (runTest): Don't prepend the suite name to $test. It's already been prepended at the start
2070         of this function.
2071
2072 2011-11-29  Martin Robinson  <mrobinson@igalia.com>
2073
2074         [GTK] generate-gtkdoc should respect build type
2075         https://bugs.webkit.org/show_bug.cgi?id=73296
2076
2077         Reviewed by Philippe Normand.
2078
2079         * Scripts/webkitdirs.pm:
2080         (buildAutotoolsProject): Pass the --debug to the generate-gtkdoc script.
2081         * gtk/common.py: If --build is passed give preference to the Debug build directory.
2082
2083 2011-12-02  Tony Chang  <tony@chromium.org>
2084
2085         [nrwt] fix wdiff output
2086         https://bugs.webkit.org/show_bug.cgi?id=73604
2087
2088         Reviewed by Adam Barth.
2089
2090         * Scripts/webkitpy/layout_tests/port/base.py:
2091         (Port.wdiff_text):
2092         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2093         (PortTest.test_wdiff_text):
2094
2095 2011-12-02  Adam Roben  <aroben@apple.com>
2096
2097         Teach build.webkit.org to display how many unit tests failed or timed out
2098
2099         Fixes <http://webkit.org/b/73659> It's hard to tell how many unit tests are failing on
2100         build.webkit.org
2101
2102         We now display something like "5 unit tests failed or timed out". Eventually we might want
2103         to split out how many failure vs. timeouts there were.
2104
2105         Reviewed by Darin Adler.
2106
2107         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2108         (TestWithFailureCount): Moved this class up to the top of the file so it is before any other
2109         classes that may want to subclass it.
2110         (RunUnitTests): Changed to inherit from TestWithFailureCount.
2111         (RunUnitTests.countFailures): Added. Counts the number of tests following the "Tests that
2112         timed out:" and "Tests that failed:" lines, if present.
2113
2114         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2115         (StubStdio):
2116         (StubRemoteCommand):
2117         Added these two stub classes to mimic buildbot's RemoteCommand and log classes.
2118
2119         (RunUnitTestsTest.assertFailures): Helper method to check that we interpreted the results of
2120         the test run correctly.
2121
2122         (RunUnitTestsTest.test_no_failures_or_timeouts):
2123         (RunUnitTestsTest.test_one_failure):
2124         (RunUnitTestsTest.test_multiple_failures):
2125         (RunUnitTestsTest.test_one_timeout):
2126         (RunUnitTestsTest.test_multiple_timeouts):
2127         (RunUnitTestsTest.test_multiple_failures_and_timeouts):
2128         Test various cases.
2129
2130 2011-12-02  Adam Roben  <aroben@apple.com>
2131
2132         Teach prepare-ChangeLog to treat master.cfg as a Python file
2133
2134         Fixes <http://webkit.org/b/73658> prepare-ChangeLog doesn't show modified classes/functions
2135         in buildbot's master.cfg
2136
2137         Reviewed by Darin Adler.
2138
2139         * Scripts/prepare-ChangeLog:
2140         (get_function_line_ranges): Use get_function_line_ranges_for_python if the filename is
2141         master.cfg.
2142
2143 2011-12-02  Martin Robinson  <mrobinson@igalia.com>
2144
2145         [GTK] Create a wrapper script that knows how to install jhbuild and run commands with it
2146         https://bugs.webkit.org/show_bug.cgi?id=73669
2147
2148         Reviewed by Gustavo Noronha Silva.
2149
2150         Add a wrapper script that knows how to install jhbuild and also to wrap commands
2151         in the jhbuild shell.
2152
2153         * Scripts/webkitdirs.pm:
2154         (runAutogenForAutotoolsProject): Use the new wrapper script.
2155         (mustReRunAutogen): Ditto.
2156         (buildAutotoolsProject): Ditto.
2157         * Scripts/webkitpy/layout_tests/port/gtk.py:
2158         (GtkDriver.cmd_line): Ditto.
2159         * gtk/run-with-jhbuild: Added.
2160
2161 2011-12-01  Adam Roben  <aroben@apple.com>
2162
2163         Teach check-webkit-style how to check the syntax of JSON files
2164
2165         Fixes <http://webkit.org/b/73590> check-webkit-style doesn't flag JSON syntax errors
2166
2167         I previously landed this patch as r101711, but the new tests failed on Snow Leopard. This
2168         patch is identical to that one except for two change: assertIn(a, b) (which is new to Python
2169         2.7) has been replaced with assertTrue(a in b), and the test_missing_closing_brace test has
2170         been removed, since its output differs by platform.
2171
2172         Reviewed by Darin Adler.
2173
2174         * Scripts/webkitpy/style/checker.py:
2175         (_all_categories): Added JSONChecker's categories to the set of all categories.
2176         (FileType): Added a JSON type. Incremented other types.
2177         (CheckerDispatcher._file_type): Use the JSON file type for .json files.
2178         (CheckerDispatcher._create_checker): Use a JSONChecker for JSON files.
2179
2180         * Scripts/webkitpy/style/checker_unittest.py:
2181         (CheckerDispatcherDispatchTest.assert_checker_json): Added this helper method.
2182         (CheckerDispatcherDispatchTest.test_json_paths): Added. Based on test_python_paths.
2183
2184         * Scripts/webkitpy/style/checkers/jsonchecker.py: Added. (I didn't name this just "json",
2185         which would have matched our other checkers, because I couldn't figure out how to call
2186         "json.loads" without hitting namespace conflicts.)
2187         (JSONChecker.__init__): Turn of line filtering so that we always check the whole file, not
2188         just the modified lines from a patch.
2189         (JSONChecker.check): Try to parse the lines as JSON. Mark an error if there was an
2190         exception.
2191         (JSONChecker.line_number_from_json_exception): Parse the json modules exception message to
2192         try to extract a line number.
2193
2194         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Added.
2195         (MockErrorHandler.__init__):
2196         (MockErrorHandler.turn_off_line_filtering):
2197         (MockErrorHandler.__call__):
2198         Helper class. Copied from xml_unittest.py.
2199
2200         (JSONCheckerTest.test_line_number_from_json_exception): Test the
2201         line_number_from_json_exception helper method.
2202
2203         (JSONCheckerTest.assert_no_error):
2204         (JSONCheckerTest.assert_error):
2205         Helper methods to assert that we did or didn't get an error.
2206
2207         (JSONCheckerTest.mock_handle_style_error): Helper method.
2208
2209         (JSONCheckerTest.test_conflict_marker):
2210         (JSONCheckerTest.test_single_quote):
2211         (JSONCheckerTest.test_init):
2212         (JSONCheckerTest.test_no_error):
2213         Test various cases.
2214
2215 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
2216
2217         [GTK] Add glib, glib-networking, gnutls and libsoup to jhbuild
2218         https://bugs.webkit.org/show_bug.cgi?id=73664
2219
2220         Reviewed by Martin Robinson.
2221
2222         This patch adds our HTTP library and its main dependencies; this
2223         should not affect layout or rendering.
2224
2225         * gtk/jhbuild.modules:
2226
2227 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
2228
2229         [GTK] Also run DumpRenderTree under jhbuild
2230         https://bugs.webkit.org/show_bug.cgi?id=73646
2231
2232         Reviewed by Martin Robinson.
2233
2234         * Scripts/webkitpy/layout_tests/port/gtk.py:
2235         (GtkDriver.cmd_line):
2236
2237 2011-12-02  Hajime Morrita  <morrita@chromium.org>
2238
2239         Unreviewed, rolling out r101751 and r101775.
2240         http://trac.webkit.org/changeset/101751
2241         http://trac.webkit.org/changeset/101775
2242         https://bugs.webkit.org/show_bug.cgi?id=73191
2243
2244         breaks Windows build
2245
2246         * DumpRenderTree/chromium/config.h:
2247         * DumpRenderTree/config.h:
2248         * TestWebKitAPI/config.h:
2249         * WebKitTestRunner/config.h:
2250
2251 2011-12-02  Kentaro Hara  <haraken@chromium.org>
2252
2253         Move run-bindings-tests implementation to webkitpy/bindings/main.py
2254         https://bugs.webkit.org/show_bug.cgi?id=73619
2255
2256         Reviewed by Adam Barth.
2257
2258         As run-bindings-tests has been growing, this patch just moves its implementation
2259         to webkitpy/bindings/main.py to integrate with the rest of webkitpy.
2260
2261         No change in behavior.
2262
2263         * Scripts/run-bindings-tests:
2264         (main):
2265         * Scripts/webkitpy/bindings/__init__.py: Added.
2266         * Scripts/webkitpy/bindings/main.py: Added.
2267         (BindingsTests.__init__):
2268         (BindingsTests.generate_from_idl):
2269         (BindingsTests.generate_supplemental_dependency):
2270         (BindingsTests.detect_changes):
2271         (BindingsTests.run_tests):
2272
2273 2011-12-01  Ilya Tikhonovsky  <loislo@chromium.org>
2274
2275         Tools/Scripts: eliminate find_test_files from Port class.
2276         https://bugs.webkit.org/show_bug.cgi?id=73553
2277
2278         rebaseline.py and chromium_gpu.py use Port.find_test_files() the same way as it is used in Port.tests()
2279         I'd like to replace all calls to find_test_files with tests and eliminate find_tests_files.
2280         Also I'll move _is_test_file() and related functions close to Port.tests().
2281
2282         Reviewed by Dirk Pranke.
2283
2284         * Scripts/webkitpy/layout_tests/port/base.py:
2285         (Port.tests):
2286         (Port.is_reference_html_file):
2287         (Port._has_supported_extension):
2288         (Port._is_test_file):
2289         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2290         (PortTest.test_find_no_paths_specified):
2291         (PortTest.test_find_one_test):
2292         (PortTest.test_find_glob):
2293         (PortTest.test_find_with_skipped_directories):
2294         (PortTest.test_find_with_skipped_directories_2):
2295         (PortTest.test_is_test_file):
2296         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2297         (_default_tests_paths):
2298         (ChromiumGpuLinuxPort.tests):
2299         (ChromiumGpuCgMacPort.tests):
2300         (ChromiumGpuMacPort.tests):
2301         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2302         (ChromiumGpuTest.test_default_tests_paths.test_paths):
2303         (ChromiumGpuTest.test_default_tests_paths):
2304         (ChromiumGpuTest.test_test_files.test_paths):
2305         (ChromiumGpuTest):
2306         (ChromiumGpuTest.test_test_files):
2307         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2308         (get_tests_run.RecordingTestDriver.run_test):
2309         * Scripts/webkitpy/tool/commands/rebaseline.py:
2310         (OptimizeBaselines._optimize_baseline):
2311         (OptimizeBaselines.execute):
2312         (AnalyzeBaselines._analyze_baseline):
2313         (AnalyzeBaselines.execute):
2314
2315 2011-12-01  Hajime Morrita  <morrita@chromium.org>
2316
2317         JS_INLINE and WTF_INLINE should be visible from WebCore
2318         https://bugs.webkit.org/show_bug.cgi?id=73191
2319
2320         Reviewed by Kevin Ollivier.
2321
2322         Removed macro definitions which is now provided by Platform.h
2323
2324         * DumpRenderTree/chromium/config.h:
2325         * DumpRenderTree/config.h:
2326         * TestWebKitAPI/config.h:
2327         * WebKitTestRunner/config.h:
2328
2329 2011-12-01  Hayato Ito  <hayato@chromium.org>
2330
2331         Explicitly pass tolerance=0 to port.diff_image in case of RefTestMismatch failure.
2332         https://bugs.webkit.org/show_bug.cgi?id=73406
2333
2334         Reviewed by Ryosuke Niwa.
2335
2336         WebKitPort's image_diff uses tolerance='0.1' in default.
2337         When reftests fail, we should use tolerace=0 when diff-ing images.
2338
2339         Since ImageDiff on chromium port doesn't use tolerance value as of now,
2340         this change doesn't affect chromium port's behavior.
2341
2342         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2343         (write_test_result):
2344         * Scripts/webkitpy/layout_tests/port/base.py:
2345         (Port.diff_image):
2346         * Scripts/webkitpy/layout_tests/port/chromium.py:
2347         (ChromiumPort.diff_image):
2348         * Scripts/webkitpy/layout_tests/port/test.py:
2349         (TestPort.diff_image):
2350         * Scripts/webkitpy/layout_tests/port/webkit.py:
2351         (WebKitPort.diff_image):
2352         (WebKitPort._start_image_diff_process):
2353         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2354         (MainTest.test_tolerance.ImageDiffTestPort.diff_image):
2355
2356 2011-12-01  Adam Klein  <adamk@chromium.org>
2357
2358         Add Chromium ToT GTest build bots (and group selection support) to flakiness dashboard
2359         https://bugs.webkit.org/show_bug.cgi?id=73599
2360
2361         Reviewed by Ojan Vafai.
2362
2363         * TestResultServer/static-dashboards/builders.js:
2364         * TestResultServer/static-dashboards/dashboard_base.js:
2365         ():
2366         (htmlForTestTypeSwitcher):
2367         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2368         (testHtmlForTestTypeSwitcherGroup):
2369
2370 2011-12-01  Ryosuke Niwa  <rniwa@webkit.org>
2371
2372         Parse reftest.list and extract types of ref tests
2373         https://bugs.webkit.org/show_bug.cgi?id=66837
2374
2375         Reviewed by Dirk Pranke.
2376
2377         Add support for reftest.list to base port.
2378
2379         * Scripts/webkitpy/common/find_files.py:
2380         (find):
2381         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2382         (SingleTestRunner.__init__):
2383         * Scripts/webkitpy/layout_tests/port/base.py:
2384         (Port.__init__): Initialize self._reftest_list. It's a dictionary mapping from a test directory
2385         to a dictionary of {test path: ("==" or "!=", reference file path)}
2386         (Port._get_reftest_list): Added; calls test_file.parse_reftest_list to fill self._reftest_list.
2387         (Port._reference_file_for): Added; obtains the reference file name given a test name.
2388         (Port.is_reftest): Added; Calls _reference_file_for.
2389         (Port.reftest_expected_filename): Calls _reference_file_for.
2390         (Port.reftest_expected_mismatch_filename): Ditto.
2391         (Port.find_test_files):
2392         (is_reference_html_file): Treat any file that starts with ref- or notref- or ends with
2393         -expected, -expected-mismach, -ref, or -notref as a reference file.
2394         (_is_test_file):
2395         (_parse_reftest_list): Added.
2396         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2397         (PortTest.test_is_test_file):
2398         (PortTest.test_parse_reftest_list):
2399         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2400         (DryrunDriver.run_test):
2401         * Scripts/webkitpy/layout_tests/port/test.py:
2402         (unit_test_filesystem.add_test_file):
2403         (unit_test_filesystem.add_file):
2404         (unit_test_filesystem):
2405         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2406         (get_tests_run.RecordingTestDriver.run_test):
2407         (MainTest.test_unexpected_failures):
2408         (MainTest.test_missing_and_unexpected_results):
2409         (EndToEndTest.test_end_to_end):
2410         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2411         (Rebaseliner._compile_rebaselining_tests):
2412
2413 2011-12-01  Sheriff Bot  <webkit.review.bot@gmail.com>
2414
2415         Unreviewed, rolling out r101711.
2416         http://trac.webkit.org/changeset/101711
2417         https://bugs.webkit.org/show_bug.cgi?id=73605
2418
2419         Broke 3 webkitpy tests (Requested by rniwa on #webkit).
2420
2421         * Scripts/webkitpy/style/checker.py:
2422         (_all_categories):
2423         (FileType):
2424         (CheckerDispatcher._file_type):
2425         (CheckerDispatcher._create_checker):
2426         * Scripts/webkitpy/style/checker_unittest.py:
2427         (CheckerDispatcherDispatchTest.assert_checker_cpp):
2428         (CheckerDispatcherDispatchTest.test_cpp_paths):
2429         * Scripts/webkitpy/style/checkers/jsonchecker.py: Removed.
2430         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Removed.
2431
2432 2011-12-01  Gustavo Noronha Silva  <gns@gnome.org>
2433
2434         Unreviewed. Add myself to GStreamer and WebKit2GTK+ watchlists.
2435
2436         * Scripts/webkitpy/common/config/watchlist:
2437
2438 2011-12-01  Martin Robinson  <mrobinson@igalia.com>
2439
2440         [GTK] Read fonts from the jhbuild root
2441         https://bugs.webkit.org/show_bug.cgi?id=73487
2442
2443         Reviewed by Gustavo Noronha Silva.
2444
2445         Read fonts from the jhbuild root instead of from the system. This will ensure
2446         that all testers use the same fonts instead of leaving this up to luck.
2447
2448         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2449         (initializeFonts): Load fonts from jhbuild root.
2450         * Scripts/webkitpy/layout_tests/port/gtk.py:
2451         (GtkPort.setup_environ_for_server): Pass an environment variable containing
2452         the path to the jhbuild root.
2453         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2454         (WTR::inititializeFontConfigSetting): Load fonts from the jhbuild root.
2455
2456 2011-12-01  Adam Roben  <aroben@apple.com>
2457
2458         Teach check-webkit-style how to check the syntax of JSON files
2459
2460         Fixes <http://webkit.org/b/73590> check-webkit-style doesn't flag JSON syntax errors
2461
2462         Reviewed by Darin Adler.
2463
2464         * Scripts/webkitpy/style/checker.py:
2465         (_all_categories): Added JSONChecker's categories to the set of all categories.
2466         (FileType): Added a JSON type. Incremented other types.
2467         (CheckerDispatcher._file_type): Use the JSON file type for .json files.
2468         (CheckerDispatcher._create_checker): Use a JSONChecker for JSON files.
2469
2470         * Scripts/webkitpy/style/checker_unittest.py:
2471         (CheckerDispatcherDispatchTest.assert_checker_json): Added this helper method.
2472         (CheckerDispatcherDispatchTest.test_json_paths): Added. Based on test_python_paths.
2473
2474         * Scripts/webkitpy/style/checkers/jsonchecker.py: Added. (I didn't name this just "json",
2475         which would have matched our other checkers, because I couldn't figure out how to call
2476         "json.loads" without hitting namespace conflicts.)
2477         (JSONChecker.__init__): Turn of line filtering so that we always check the whole file, not
2478         just the modified lines from a patch.
2479         (JSONChecker.check): Try to parse the lines as JSON. Mark an error if there was an
2480         exception.
2481         (JSONChecker.line_number_from_json_exception): Parse the json modules exception message to
2482         try to extract a line number.
2483
2484         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Added.
2485         (MockErrorHandler.__init__):
2486         (MockErrorHandler.turn_off_line_filtering):
2487         (MockErrorHandler.__call__):
2488         Helper class. Copied from xml_unittest.py.
2489
2490         (JSONCheckerTest.test_line_number_from_json_exception): Test the
2491         line_number_from_json_exception helper method.
2492
2493         (JSONCheckerTest.assert_no_error):
2494         (JSONCheckerTest.assert_error):
2495         Helper methods to assert that we did or didn't get an error.
2496
2497         (JSONCheckerTest.mock_handle_style_error): Helper method.
2498
2499         (JSONCheckerTest.test_conflict_marker):
2500         (JSONCheckerTest.test_single_quote):
2501         (JSONCheckerTest.test_init):
2502         (JSONCheckerTest.test_missing_closing_brace):
2503         (JSONCheckerTest.test_no_error):
2504         Test various cases.
2505
2506 2011-12-01  Martin Robinson  <mrobinson@igalia.com>
2507
2508         [GTK] Add a helper function to find the current executable's path
2509         https://bugs.webkit.org/show_bug.cgi?id=73473
2510
2511         Reviewed by Gustavo Noronha Silva.
2512
2513         Update MiniBrowser to not pass the binary directory as an environment variable.
2514         This means that you can move the binaries around without it breaking.
2515
2516         * MiniBrowser/gtk/main.c:
2517         (main): No longer set the environment variable.
2518         * WebKitTestRunner/GNUmakefile.am: No longer add the directory path define.
2519         * WebKitTestRunner/gtk/main.cpp:  Ditto.
2520
2521 2011-12-01  Gustavo Noronha Silva  <gns@gnome.org>
2522
2523         Unreviewed. Fix bad file =(.
2524
2525         * gtk/jhbuild.modules:
2526         * Scripts/webkitdirs.pm:
2527         (runAutogenForAutotoolsProject):
2528
2529 2011-12-01  Gustavo Noronha Silva  <gns@gnome.org>
2530
2531         [GTK] Add freetype to our jhbuild setup
2532         https://bugs.webkit.org/show_bug.cgi?id=73488
2533
2534         Reviewed by Martin Robinson.
2535
2536         This adds the first library to our jhbuild setup, and makes sure
2537         build-webkit calls autogen.sh and make with jhbuild, so that the
2538         environment is properly set.
2539
2540         * Scripts/webkitdirs.pm:
2541         (saveSum):
2542         (hashFile):
2543         (runAutogenForAutotoolsProject): save md5sum of jhbuild-related files, and
2544         call autogen under jhbuild run;
2545         (mustRunAutogen): generalized the arguments change checking to also force
2546         running autogen when jhbuild files change;
2547         (buildAutotoolsProject): run make under jhbuild;
2548         * gtk/jhbuild.modules: add freetype.
2549
2550 2011-12-01  Dominic Mazzoni  <dmazzoni@google.com>
2551
2552         Fix WebKitTestRunner compile warnings with XCode 3.2
2553         https://bugs.webkit.org/show_bug.cgi?id=73378
2554
2555         Reviewed by Chris Fleizach.
2556
2557         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
2558         (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
2559         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
2560         (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
2561         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2562         (WTR::AccessibilityUIElement::AccessibilityUIElement):
2563         (WTR::AccessibilityUIElement::verticalScrollbar):
2564
2565 2011-12-01  Adam Roben  <aroben@apple.com>
2566
2567         Allow committers to use their Trac credentials to force builds on the buildbots
2568
2569         Fixes <http://webkit.org/b/73353>
2570
2571         A new class, CommitterAuth, handles authentication of WebKit committers. CommitterAuth uses
2572         three files to do its job: a config file that contains a list of WebKit committer usernames,
2573         an htdigest file that contains Trac credentials, and JSON file that gives the paths for
2574         those two files.
2575
2576         Reviewed by Darin Adler.
2577
2578         * BuildSlaveSupport/build.webkit.org-config/committer_auth.py: Added.
2579         (Error): Basic wrapper around Exception that we use for cases where we couldn't even check
2580         whether credentials were valid or not.
2581         (CommitterAuth.__init__): Just store the path to auth.json.
2582         (CommitterAuth.auth_json): Load, parse, and return auth.json.
2583         (CommitterAuth.auth_json_filename): Return the path to auth.json.
2584         (CommitterAuth.authenticate): Return true if the user is a WebKit committer and their
2585         credentials are valid Trac credentials. Return false otherwise or if an error occurred while
2586         checking those conditions.
2587         (CommitterAuth.is_webkit_committer): Return true if the user is a WebKit committer. Return
2588         false otherwise or if an exception was thrown.
2589         (CommitterAuth.is_webkit_trac_user): Return true if the username/password are present in the
2590         Trac credentials htdigest file. Return false otherwise or if an exception was thrown.
2591
2592         (CommitterAuth.open_auth_json_file):
2593         (CommitterAuth.open_trac_credentials_file):
2594         (CommitterAuth.open_webkit_committers_file):
2595         Open the specified file. These are mostly useful for testing purposes.
2596
2597         (CommitterAuth.trac_credentials_filename):
2598         (CommitterAuth.webkit_committers_filename):
2599         Return the path to the specified file by retrieving it from auth.json.
2600
2601         (CommitterAuth.webkit_committers): Load and parse the committers file and extract the list
2602         of WebKit committers from it.
2603
2604         * BuildSlaveSupport/build.webkit.org-config/committer_auth_unittest.py: Added.
2605         (CMStringIO.__enter__):
2606         (CMStringIO.__exit__):
2607         Helper class that makes it possible to use StringIO with the "with" statement.
2608
2609         (open_override): Helper context manager for overriding the global "open" function
2610         temporarily.
2611
2612         (CommitterAuthTest.setUp): Set up a somewhat-mocked CommitterAuth that is used by most
2613         tests.
2614         (CommitterAuthTest.fake_open_function): Returns a function that can be used in place of
2615         "open" to test that the expected path was opened.
2616         (CommitterAuthTest.test_authentication_success): Test that committers can authenticate
2617         successfully.
2618         (CommitterAuthTest.test_committer_without_trac_credentials_fails): Test that committers who
2619         somehow have no Trac account can't authenticate.
2620
2621         (CommitterAuthTest.test_fail_to_open_auth_json_file):
2622         (CommitterAuthTest.test_fail_to_open_trac_credentials_file):
2623         (CommitterAuthTest.test_fail_to_open_webkit_committers_file):
2624         Test what happens when we can't open the three files we depend upon.
2625
2626         (CommitterAuthTest.test_implements_IAuth): Test that we fulfill buildbot's expectations for
2627         an authentication class.
2628
2629         (CommitterAuthTest.test_invalid_auth_json_file):
2630         (CommitterAuthTest.test_invalid_committers_file):
2631         (CommitterAuthTest.test_invalid_trac_credentials_file):
2632         (CommitterAuthTest.test_missing_auth_json_keys):
2633         Test what happens when the three files we depend upon are invalid in some way.
2634
2635         (CommitterAuthTest.test_open_auth_json_file):
2636         (CommitterAuthTest.test_open_trac_credentials_file):
2637         (CommitterAuthTest.test_open_webkit_committers_file):
2638         Test that we open the expected paths.
2639
2640         (CommitterAuthTest.test_trac_credentials_filename):
2641         (CommitterAuthTest.test_webkit_committers_filename):
2642         Test that we extract filenames out of auth.json correctly.
2643
2644         (CommitterAuthTest.test_non_committer_fails):
2645         (CommitterAuthTest.test_unknown_user_fails):
2646         (CommitterAuthTest.test_username_is_prefix_of_valid_user):
2647         (CommitterAuthTest.test_wrong_password_fails):
2648         Test various failed authentication attempts.
2649
2650         (CommitterAuthTest.test_webkit_committers): Test that we can parse the list of WebKit
2651         committers out of the committers file correctly.
2652
2653         (CommitterAuthTest.fake_auth_json_file):
2654         (CommitterAuthTest.invalid_auth_json_file):
2655         (CommitterAuthTest.fake_committers_file):
2656         (CommitterAuthTest.invalid_committers_file):
2657         (CommitterAuthTest.fake_htdigest_file):
2658         (CommitterAuthTest.invalid_htdigest_file):
2659         Return various fake files for testing.
2660
2661         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Specify an instance of CommitterAuth
2662         to be used for authentication in the web interface, and specify that only authenticated
2663         users may force builds.
2664
2665 2011-12-01  Adam Roben  <aroben@apple.com>
2666
2667         Add an HTDigestParser class to webkitpy
2668
2669         Fixes <http://webkit.org/b/73575> webkitpy doesn't provide a way to parse htdigest files
2670
2671         This class can be used to parse Apache's htdigest files and check whether a given
2672         username/realm/password tuple is present in the file. Eventually this will be used for
2673         authenticating users on build.webkit.org (<http://webkit.org/b/73353>).
2674
2675         Reviewed by Eric Seidel.
2676
2677         * Scripts/webkitpy/common/net/htdigestparser.py: Added.
2678         (HTDigestParser.__init__): Stores the parsed representation of the file.
2679         (HTDigestParser.authenticate): Hashes the username/realm/password tuple to generate a hashed
2680         password and returns whether the resulting tuple is present in the file.
2681         (HTDigestParser.entries): Just returns the parsed representation of the file.
2682         (HTDigestParser.parse_file): Splits each line on colons and checks that each line has the
2683         expected syntax ('username:realm:hashed_password'). If any line is invalid, we treat the
2684         whole file as invalid and all authentication attempts will fail.
2685
2686         * Scripts/webkitpy/common/net/htdigestparser_unittest.py: Added.
2687         (HTDigestParserTest.assertEntriesEqual): Helper method to assert that fake_htdigest_file,
2688         optionally appended with some extra data, generates the expected entries.
2689         (HTDigestParserTest.test_authenticate): Tests that tuples present in the file can
2690         authenticate, and tuples not present cannot.
2691         (HTDigestParserTest.test_entries): Tests that we get the expected entries from
2692         fake_htdigest_file.
2693
2694         (HTDigestParserTest.test_empty_file):
2695         (HTDigestParserTest.test_too_few_colons):
2696         (HTDigestParserTest.test_too_many_colons):
2697         (HTDigestParserTest.test_invalid_hash):
2698         Test various forms of invalid files.
2699
2700         (HTDigestParserTest.fake_htdigest_file): Returns a fake valid htdigest file for testing.
2701
2702 2011-12-01  Philippe Normand  <pnormand@igalia.com>
2703
2704         [GTK] Make the new 64-bit Release bot part of the core set
2705         https://bugs.webkit.org/show_bug.cgi?id=73570
2706
2707         Reviewed by Adam Roben.
2708
2709         The 64-bit Release bot re-introduced in r101676 replaces the 64-bit
2710         Debug bot which was already part of the core set. The GTK
2711         gardeners are willing to actively maintain it.
2712
2713         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2714         (BuildBot.__init__):
2715         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2716         (test_builder_name_regexps):
2717
2718 2011-12-01  Philippe Normand  <pnormand@igalia.com>
2719
2720         [GTK] Buildslave switch from 32-bit Debug to 64-bit Release
2721         https://bugs.webkit.org/show_bug.cgi?id=73547
2722
2723         Reviewed by Adam Roben.
2724
2725         * BuildSlaveSupport/build.webkit.org-config/config.json: Rename
2726         the 32-bit Debug configuration to 64-bit Release. The new slave is
2727         a 64-bit machine already. The 32-bit slave will be shut down.
2728
2729 2011-12-01  Martin Robinson  <mrobinson@igalia.com>
2730
2731         [GTK] build-jsc should not trigger gtkdoc generation
2732         https://bugs.webkit.org/show_bug.cgi?id=73552
2733
2734         Reviewed by Philippe Normand.
2735
2736         Do not generate gtkdoc when building projects other than WebKit. In particular, this ensures
2737         that build-jsc does not try to generate gtkdoc.
2738
2739         * Scripts/webkitdirs.pm:
2740         (buildAutotoolsProject): Only generate gtkdoc if the project is "WebKit".
2741
2742 2011-12-01  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2743
2744         tests_run0.txt gets clobbered when re-running failing tests
2745         https://bugs.webkit.org/show_bug.cgi?id=63844
2746
2747         Reviewed by Dirk Pranke.
2748
2749         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2750         (Manager.results_directory):
2751         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2752         (AbstractWorker.__init__):
2753         (_ManagerConnection.start_worker):
2754         (_InlineManager.start_worker):
2755         (_MultiProcessManager.start_worker):
2756         (_WorkerConnection.__init__):
2757         (_InlineWorkerConnection.__init__):
2758         (_MultiProcessWorkerConnection.__init__):
2759         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
2760         (_TestWorker.__init__):
2761         (_TestsMixin.test_cancel):
2762         (_TestsMixin.test_done):
2763         (_TestsMixin.test_unknown_message):
2764         (InterfaceTest.test_managerconnection_is_abstract):
2765         (InterfaceTest.test_workerconnection_is_abstract):
2766         * Scripts/webkitpy/layout_tests/controllers/worker.py:
2767         (Worker.__init__):
2768         (Worker.safe_init):
2769         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2770         (MainTest.test_retries_directory):
2771
2772 2011-12-01  Adam Roben  <aroben@apple.com>
2773
2774         Buildbot fix
2775
2776         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Moved all of the initialization of
2777         BuildmasterConfig not performed by loadBuilderConfig up to the top of the file. This makes
2778         it possible for build steps to reference things like the buildbotURL property of the config.
2779
2780 2011-11-30  Adam Roben  <aroben@apple.com>
2781
2782         Use curl for downloading builds to test slaves
2783
2784         Buildbot's built-in file transfer capabilities are transferring files much more slowly than
2785         curl does. This seems to be due to a combination of buildbot being single-threaded (and thus
2786         often busy servicing web requests, etc.) and using an IPC mechanism with fairly high
2787         overhead (courtesy of the Twisted framework).
2788
2789         Eventually we'd like to make Buildbot's built-in transferring more efficient. In the
2790         meantime we'll try using curl for downloads and keep thinking about a solution for uploads.
2791         This should make the test slaves quite a bit faster, and should ease the CPU load on
2792         build.webkit.org a bit.
2793
2794         Part of <http://webkit.org/b/73484> Mac slaves take 7+ minutes to upload or download a build
2795
2796         Reviewed by Mark Rowe.
2797
2798         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added the CreateWebKitBuildDirectory
2799         to Test slaves. It's run just before DownloadBuiltProduct.
2800         (DownloadBuiltProduct): Changed to be a normal ShellCommand that invokes curl to perform the
2801         download.
2802         (CreateWebKitBuildDirectory): Added. Creates the WebKitBuild directory on a slave.
2803         FileDownload used to do this for us automatically.
2804
2805 2011-11-21  Philippe Normand  <pnormand@igalia.com>
2806
2807         [GTK] enable-webaudio websetting
2808         https://bugs.webkit.org/show_bug.cgi?id=69836
2809
2810         Reviewed by Martin Robinson.
2811
2812         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2813         (LayoutTestController::overridePreference): Update WebKitGTK
2814         enable-webaudio setting when a layout test requests it.
2815
2816 2011-11-30  Ilya Tikhonovsky  <loislo@chromium.org>
2817
2818         Web Inspector: chromium: I'd like to add a script for running perf tests for WebInspector.
2819         https://bugs.webkit.org/show_bug.cgi?id=73079
2820
2821         The idea is to have performance tests for WebInspector.
2822         I was suggested to put these tests into PerformanceTests/inspector.
2823         They produce output in a format that is suitable for chromium perf bot drawing scripts.
2824
2825         I'd like to reuse code for scanning folders for test files.
2826         Because of the fact that original test_files.py has common and layout specific parts
2827         I decided to extract the generic part and put it into webkitpy/common
2828         I think the two packages with name test_files look strange but I have no idea about a better name.
2829
2830         Reviewed by Dirk Pranke.
2831
2832         * Scripts/run-inspector-perf-tests.py: Added.
2833         * Scripts/webkitpy/common/find_files.py: Renamed from Tools/Scripts/webkitpy/layout_tests/port/test_files.py.
2834         (find):
2835         (_normalize):
2836         * Scripts/webkitpy/common/find_files_unittest.py: Added.
2837         (MockWinFileSystem.join):
2838         (MockWinFileSystem):
2839         (MockWinFileSystem.normpath):
2840         (TestWinNormalize.assert_filesystem_normalizes):
2841         (TestWinNormalize.test_mocked_win):
2842         (TestWinNormalize):
2843         (TestWinNormalize.test_win):
2844         * Scripts/webkitpy/layout_tests/port/base.py:
2845         (Port.tests):
2846         (Port.find_test_files):
2847         (Port._driver_class):
2848         (is_reference_html_file):
2849         (_has_supported_extension):
2850         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2851         (PortTest.test_find_no_paths_specified):
2852         (PortTest.test_find_one_test):
2853         (PortTest.test_find_glob):
2854         (PortTest.test_find_with_skipped_directories):
2855         (PortTest.test_find_with_skipped_directories_2):
2856         (PortTest):
2857         (PortTest.test_is_test_file):
2858         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2859         (_tests):
2860         * Scripts/webkitpy/layout_tests/port/test.py:
2861         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py: Removed.
2862         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2863         * Scripts/webkitpy/performance_tests/__init__.py: Added.
2864         * Scripts/webkitpy/performance_tests/perftestsrunner.py: Added.
2865         (PerfTestsRunner.__init__):
2866         (PerfTestsRunner._parse_args):
2867         (PerfTestsRunner._collect_tests._is_test_file):
2868         (PerfTestsRunner._collect_tests):
2869         (PerfTestsRunner.run):
2870         (PerfTestsRunner._run_tests_set):
2871         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: Added.
2872         (MainTest.TestPort):
2873         (MainTest.TestPort.create_driver):
2874         (MainTest.TestDriver.run_test):
2875         (MainTest.TestDriver):
2876         (MainTest.TestDriver.stop):
2877         (MainTest.create_runner):
2878         (MainTest.run_test):
2879         (MainTest.test_run_passing_test):
2880         (MainTest.test_run_silent_test):
2881         (MainTest.test_run_failed_test):
2882         (MainTest.test_run_tonguey_test):
2883         (MainTest.test_run_timeout_test):
2884         (MainTest.test_run_crash_test):
2885         (MainTest.test_run_test_set):
2886         (MainTest.test_collect_tests):
2887         (MainTest):
2888         (MainTest.test_parse_args):
2889         * Scripts/webkitpy/tool/commands/rebaseline.py:
2890         (OptimizeBaselines.execute):
2891         (AnalyzeBaselines.execute):
2892
2893 2011-11-30  nduca@chromium.org  <nduca@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
2894
2895         [chromium] Enable threaded compositing via CCThreadProxy::hasThread only
2896         https://bugs.webkit.org/show_bug.cgi?id=70838
2897
2898         Reviewed by James Robinson.
2899
2900         * DumpRenderTree/chromium/TestShell.cpp:
2901         (TestShell::resetWebSettings):
2902         * DumpRenderTree/chromium/TestShell.h:
2903         (TestShell::threadedCompositingEnabled):
2904         * DumpRenderTree/chromium/WebPreferences.cpp:
2905         (WebPreferences::reset):
2906         (WebPreferences::applyTo):
2907         * DumpRenderTree/chromium/WebPreferences.h:
2908         * DumpRenderTree/chromium/WebViewHost.cpp:
2909         (WebViewHost::WebViewHost):
2910         (WebViewHost::~WebViewHost):
2911
2912 2011-11-30  Chris Fleizach  <cfleizach@apple.com>
2913
2914         AX: Nodes are reporting that focus can be set when they really can't
2915         https://bugs.webkit.org/show_bug.cgi?id=72791
2916
2917         Reviewed by Beth Dakin.
2918
2919         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2920         (AccessibilityUIElement::isFocusable):
2921         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2922         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2923         (WTR::AccessibilityUIElement::isFocusable):
2924
2925 2011-11-30  Alejandro G. Castro  <alex@igalia.com>
2926
2927         Moved myself to the reviewers list.
2928
2929         * Scripts/webkitpy/common/config/committers.py:
2930
2931 2011-11-30  David Levin  <levin@chromium.org>
2932
2933         [chromium] Move didUpdateLayout from WebFrameClient to WebViewClient.
2934         https://bugs.webkit.org/show_bug.cgi?id=73415
2935
2936         Reviewed by Darin Fisher.
2937
2938         * DumpRenderTree/chromium/WebViewHost.cpp:
2939         (WebViewHost::didUpdateLayout): Move didUpdateLayout to account for
2940         it being moved to a new interface and having the parameter removed.
2941         * DumpRenderTree/chromium/WebViewHost.h: Ditto.
2942
2943 2011-11-30  Adam Roben  <aroben@apple.com>
2944
2945         Make NRWT show DRT/WTR build logs when the build fails or --verbose is passed
2946
2947         This will make it a lot easier to investigate build failures on the bots.
2948
2949         Fixes <http://webkit.org/b/71160> NRWT doesn't show build output when building DRT
2950
2951         Reviewed by Eric Seidel.
2952
2953         * Scripts/webkitpy/common/system/executive_mock.py:
2954         (MockExecutive.run_command): Include the mock output in the ScriptError we raise since it
2955         makes the expected output in WebKitPortTest.test_build_driver more closely mimic the output
2956         seen in practice.
2957
2958         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2959         (ManagerTest.test_http_locking): Pass False for the configure_logging parameter to Printer.
2960         The Printer was modifying the root logger in way that would cause my new tests in
2961         WebKitPort.test_build_driver to fail. The value of the configure_logging parameter doesn't
2962         seem important to the functioning of this test, and passing False makes Printer not modify
2963         the root logger.
2964
2965         * Scripts/webkitpy/layout_tests/port/webkit.py:
2966         (WebKitPort._run_script): Log the output of the command at the DEBUG level so it will show
2967         up when --verbose is passed but not otherwise.
2968         (WebKitPort._build_driver): When an error occurs, log the error message and the script's
2969         output at the ERROR level so it will always show up.
2970
2971         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2972         (WebKitPortTest.test_build_driver): Test that nothing is logged in the normal, successful
2973         cases. Test that the build scripts' output is logged when --verbose is passed or the build
2974         fails.
2975
2976 2011-11-30  Adam Roben  <aroben@apple.com>
2977
2978         Add a way to set OutputCapture's log level
2979
2980         This will be used by some unit tests I'm planning to add.
2981
2982         Fixes <http://webkit.org/b/73469> OutputCapture can't be used to capture DEBUG messages
2983
2984         Reviewed by Eric Seidel.
2985
2986         * Scripts/webkitpy/common/system/outputcapture.py:
2987         (OutputCapture.__init__): Initialize our internal logging level to INFO, which was the only
2988         level we ever used before this patch.
2989         (OutputCapture.set_log_level): Added. This is useful for testing what log level code that is
2990         being tested uses. Sets the log level for any current or future logging handlers.
2991         (OutputCapture.capture_output): Use our internal logging level instead of always using INFO.
2992
2993         * Scripts/webkitpy/common/system/outputcapture_unittest.py: Added.
2994         (OutputCaptureTest.setUp): Create an OutputCapture to test.
2995         (OutputCaptureTest.log_all_levels): Helper method to log a message at each log level.
2996         (OutputCaptureTest.assertLogged): Helper method to assert that a particular set of strings
2997         was logged.
2998         (OutputCaptureTest.test_initial_log_level): Test that we start out at the INFO level.
2999         (OutputCaptureTest.test_set_log_level): Test that set_log_level correctly modifies the log
3000         level.
3001
3002 2011-11-29  Beth Dakin  <bdakin@apple.com>
3003
3004         https://bugs.webkit.org/show_bug.cgi?id=72751
3005         WebKit2.MouseMoveAfterCrash API test is failing 
3006
3007         Reviewed by Sam Weinig.
3008
3009         Like DumpRenderTree, the NSWindow should act as an active window.
3010         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3011         (-[ActiveOffscreenWindow isKeyWindow]):
3012         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3013
3014 2011-11-30  Gustavo Noronha Silva  <gns@gnome.org>
3015
3016         Add step to update gtk dependencies to the buildbot
3017         https://bugs.webkit.org/show_bug.cgi?id=73455
3018
3019         Reviewed by Martin Robinson.
3020
3021         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3022
3023 2011-11-30  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3024
3025         [Qt] Add a fullscreen option to MiniBrowser.
3026         https://bugs.webkit.org/show_bug.cgi?id=73445
3027
3028         Reviewed by Noam Rosenthal.
3029
3030         This bypasses the compositor on the N9 to increase performances
3031         and remove the huge useless gray bar part of the window frame
3032         at the bottom.
3033
3034         * MiniBrowser/qt/BrowserWindow.cpp:
3035         (BrowserWindow::BrowserWindow):
3036         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3037         (printHelp):
3038         (MiniBrowserApplication::handleUserOptions):
3039         * MiniBrowser/qt/MiniBrowserApplication.h:
3040         (WindowOptions::setStartFullScreen):
3041         (WindowOptions::startFullScreen):
3042
3043 2011-11-30  Martin Robinson  <mrobinson@igalia.com>
3044
3045         [GTK] Add an initial jhbuild setup which installs fonts into the WebKitBuild
3046         https://bugs.webkit.org/show_bug.cgi?id=73425
3047
3048         Reviewed by Gustavo Noronha Silva.
3049
3050         Add initial jhbuild support to the GTK+ port. update-webkitgtk-libs will
3051         ensure that the jhbuild root is up-to-date. Currently the only module is
3052         the font module.
3053
3054         * Scripts/update-webkitgtk-libs: Added.
3055         * gtk/common.py: Added a helper to get the number of CPUs.
3056         * gtk/jhbuild.modules: Added.
3057         * gtk/jhbuildrc: Added.
3058
3059 2011-11-30  Simon Hausmann  <simon.hausmann@nokia.com>
3060
3061         [Qt] Remove dependency of Qt DRT on JavaScriptCore.
3062
3063         Reviewed by Csaba Osztrogonác.
3064
3065         * DumpRenderTree/WorkQueue.cpp: Include the correct header file we're using anyway,
3066         instead of one that pulls in JavaScriptCore headers.
3067         * DumpRenderTree/qt/DumpRenderTree.pro: There's no need to pull in the JSC headers
3068         with load(javascriptcore).
3069
3070 2011-11-30  Sheriff Bot  <webkit.review.bot@gmail.com>
3071
3072         Unreviewed, rolling out r101440 and r101442.
3073         http://trac.webkit.org/changeset/101440
3074         http://trac.webkit.org/changeset/101442
3075         https://bugs.webkit.org/show_bug.cgi?id=73429
3076
3077         multiple crashes on layout tests (Requested by hayato on
3078         #webkit).
3079
3080         * DumpRenderTree/chromium/TestShell.cpp:
3081         (TestShell::resetWebSettings):
3082         * DumpRenderTree/chromium/TestShell.h:
3083         * DumpRenderTree/chromium/WebPreferences.cpp:
3084         (WebPreferences::reset):
3085         (WebPreferences::applyTo):
3086         * DumpRenderTree/chromium/WebPreferences.h:
3087         * DumpRenderTree/chromium/WebViewHost.cpp:
3088         (WebViewHost::WebViewHost):
3089         (WebViewHost::~WebViewHost):
3090
3091 2011-11-30  Fady Samuel  <fsamuel@chromium.org>
3092
3093         [Chromium] Fix broken DRT build for Aura Linux
3094         https://bugs.webkit.org/show_bug.cgi?id=72667
3095
3096         Reviewed by Tony Chang.
3097
3098         DRT now builds for Aura Linux. This, more or less, shares the same code as Android.
3099
3100         The following changes have been made:
3101
3102           1. Renamed TestShellAndroid to TestShellLinux.
3103           2. Stub code moved added in TestShellStub that will only compile on non-GTK Linux builds.
3104           3. Code common to Gtk, Aura, and Android moved to TestShellLinux.
3105
3106         * DumpRenderTree/DumpRenderTree.gypi:
3107         * DumpRenderTree/chromium/EventSender.cpp:
3108         (EventSender::keyDown):
3109         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
3110         * DumpRenderTree/chromium/TestShellGtk.cpp:
3111         * DumpRenderTree/chromium/TestShellLinux.cpp: Copied from Tools/DumpRenderTree/chromium/TestShellGtk.cpp.
3112         (AlarmHandler):
3113         (TestShell::waitTestFinished):
3114         (setupFontconfig):
3115         (platformInit):
3116         * DumpRenderTree/chromium/TestShellStub.cpp: Added.
3117         (checkLayoutTestSystemDependencies):
3118         (openStartupDialog):
3119
3120 2011-11-30  Fady Samuel  <fsamuel@chromium.org>
3121
3122         [Chromium] Set Result Before Early Exit for Fixed Layout Methods in LayoutTestController
3123         https://bugs.webkit.org/show_bug.cgi?id=73328
3124
3125         Reviewed by Kent Tamura.
3126
3127         * DumpRenderTree/chromium/LayoutTestController.cpp:
3128         (LayoutTestController::enableFixedLayoutMode):
3129         (LayoutTestController::setFixedLayoutSize):
3130
3131 2011-11-29  Hayato Ito  <hayato@chromium.org>
3132
3133         Skip writing the result of diff_image since non-chromium ports don't implement diff_image.
3134         https://bugs.webkit.org/show_bug.cgi?id=73381
3135
3136         Reviewed by Ryosuke Niwa.
3137
3138         This is a quick fix for the breakage of tests on non-chromium port.
3139         We should implement diff_image later on non-chromium ports.
3140
3141         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3142         (write_test_result):
3143
3144 2011-11-29  Balazs Ankes  <Ankes.Balazs@stud.u-szeged.hu>
3145
3146         [NRWT] Fix --platform=qt-5.0 --new-baseline combo
3147         https://bugs.webkit.org/show_bug.cgi?id=72489
3148
3149         Reviewed by Eric Seidel.
3150
3151         Before the this fix always added "qt" option for the option list
3152         * Scripts/run-webkit-tests:
3153         * Scripts/webkitpy/layout_tests/port/qt.py:
3154
3155 2011-11-29  David Levin  <levin@chromium.org>
3156
3157         Add a way to revert a variable to its previous value after leaving a scope.
3158         https://bugs.webkit.org/show_bug.cgi?id=73371
3159
3160         Reviewed by Adam Barth.
3161
3162         * DumpRenderTree/ForwardingHeaders/wtf/TemporarilyChange.h: Added.
3163         * TestWebKitAPI/TestWebKitAPI.gypi: Added test file to the build.
3164         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
3165         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
3166         * TestWebKitAPI/Tests/WTF/TemporarilyChange.cpp: Added.
3167         (TestWebKitAPI::TEST): Added a test for TemporarilyChange.
3168
3169 2011-11-28  Kentaro Hara  <haraken@chromium.org>
3170
3171         Implement [Supplemental] IDL and support it in run-bindings-tests
3172         https://bugs.webkit.org/show_bug.cgi?id=73162
3173
3174         Reviewed by Adam Barth.
3175
3176         run-bindings-tests supports the [Supplemental] IDL in the following way.
3177             (1) It creates a file |x| listing all IDL files.
3178             (2) It generates a supplemental dependency file |y| using resolve-supplemental.pl and |x|.
3179             (3) For each IDL file |z|, it runs generate-bindings.pl with |y|.
3180                 Then, generate-bindings.pl generates .h and .cpp files for the IDL file |z|,
3181                 including all attributes in IDL files that are supplementing the IDL file |z|.
3182
3183         * Scripts/run-bindings-tests:
3184         (generate_from_idl):
3185         (generate_supplemental_dependency):
3186         (detect_changes):
3187         (run_tests):
3188         (main):
3189
3190 2011-11-18  Nat Duca  <nduca@chromium.org>
3191
3192         [chromium] Enable threaded compositing via CCThreadProxy::hasThread only
3193         https://bugs.webkit.org/show_bug.cgi?id=70838
3194
3195         Reviewed by James Robinson.
3196
3197         * DumpRenderTree/chromium/TestShell.cpp:
3198         (TestShell::resetWebSettings):
3199         * DumpRenderTree/chromium/TestShell.h:
3200         (TestShell::threadedCompositingEnabled):
3201         * DumpRenderTree/chromium/WebPreferences.cpp:
3202         (WebPreferences::reset):
3203         (WebPreferences::applyTo):
3204         * DumpRenderTree/chromium/WebPreferences.h:
3205         * DumpRenderTree/chromium/WebViewHost.cpp:
3206         (WebViewHost::WebViewHost):
3207         (WebViewHost::~WebViewHost):
3208
3209 2011-11-29  Ojan Vafai  <ojan@chromium.org>
3210
3211         List of builders in the flakiness dashboard is out of date
3212         https://bugs.webkit.org/show_bug.cgi?id=73347
3213
3214         Reviewed by Adam Barth.
3215
3216         The chromium gpu bots no longer run layout tests, so kill that
3217         group entirely.
3218
3219         * TestResultServer/static-dashboards/builders.js:
3220         * TestResultServer/static-dashboards/dashboard_base.js:
3221
3222 2011-11-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3223
3224         [Qt] Don't hard-code the list of WebKit2 generated sources
3225
3226         The generated sources are... wait for it... generated. So
3227         use the generator itself to figure out which sources we need
3228         to compile.
3229
3230         Reviewed by Simon Hausmann.
3231
3232         * qmake/mkspecs/features/default_post.prf:
3233
3234 2011-11-29  Martin Robinson  <mrobinson@igalia.com>
3235
3236         [GTK] Add a method to detect 'make dist' errors without running 'make dist'
3237         https://bugs.webkit.org/show_bug.cgi?id=73216
3238
3239         Reviewed by Philippe Normand.
3240
3241         Add a script that tries to sniff out 'make dist' problems without running
3242         'make dist.' 'make distcheck' takes a very long time to run and this should
3243         reduce the amount of times it needs to be run consecutively.
3244
3245         * gtk/common.py:
3246         (get_build_path.is_valid_build_directory): Guess the source directory
3247         by the existence of the GNUmakefile instead of the .libs directory. This
3248         allows one to run the script after running autogen.sh but before fully
3249         building.
3250         * gtk/find-make-dist-errors: Added.
3251
3252 2011-11-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3253
3254         [Qt] Remove use of internal headers in the MiniBrowser
3255
3256         Reviewed by Simon Hausmann.
3257
3258         * MiniBrowser/qt/MiniBrowser.pro:
3259
3260 2011-11-29  Simon Hausmann  <simon.hausmann@nokia.com>
3261
3262         [Qt] Fix debug-shlib build without webkit2
3263
3264         Reviewed by Tor Arne Vestbø.
3265
3266         * qmake/mkspecs/features/qtwebkit.prf: Respect no_webkit2.
3267
3268 2011-11-28  Csaba Osztrogonác  <ossy@webkit.org>
3269
3270         [Qt][WK2] Unreviewed buildfix after r101307.
3271
3272         * qmake/mkspecs/features/webkit2.prf: Add missing includepath.
3273
3274 2011-11-29  Roland Steiner  <rolandsteiner@chromium.org>
3275
3276         <style scoped>: add ENABLE(STYLE_SCOPED) flag to WebKit
3277         https://bugs.webkit.org/show_bug.cgi?id=72848
3278
3279         Add option to build-webkit.
3280
3281         Reviewed by Dimitri Glazkov.
3282
3283         * Scripts/build-webkit:
3284
3285 2011-11-28  Ojan Vafai  <ojan@chromium.org>
3286
3287         gtest normalization in the test results server is sometimes wrong
3288         https://bugs.webkit.org/show_bug.cgi?id=73262
3289
3290         Reviewed by Tony Chang.
3291
3292         If a gtest has it's modified changed (e.g. add FLAKY_) then it will have two
3293         entries in the incremental JSON, one of the entries will have the correct data
3294         from the run and the other will have dummy no-data values. Make sure to
3295         always pick the one with real data.
3296
3297         * TestResultServer/model/jsonresults.py:
3298         (JsonResults._remove_gtest_modifiers):
3299         * TestResultServer/model/jsonresults_unittest.py:
3300         (JsonResultsTest.test_remove_gtest_modifiers):
3301
3302 2011-11-28  Ojan Vafai  <ojan@chromium.org>
3303
3304         Some of the results.json files have results/times entries at the directory level
3305         https://bugs.webkit.org/show_bug.cgi?id=73261
3306
3307         Reviewed by Tony Chang.
3308
3309         This is just a bug that got introduced in a temporary push of the results server.
3310         This patch repairs the broken files. After all the bots have cycled, we can simplify
3311         this code to just assert that results/times are not at the directory level.
3312
3313         Also, when catching exceptions, log the full stacktrace.
3314
3315         * TestResultServer/model/jsonresults.py:
3316         (_is_directory):
3317         (JsonResults._load_json):
3318         (JsonResults._merge_tests):
3319         (JsonResults.merge):
3320         * TestResultServer/model/jsonresults_unittest.py:
3321         (JsonResultsTest.test_merge_directory_hierarchy_extra_results_and_times):
3322
3323 2011-11-28  Tony Chang  <tony@chromium.org>
3324
3325         ews bots should pass --force to update-webkit-chromium
3326         https://bugs.webkit.org/show_bug.cgi?id=73230
3327
3328         Reviewed by Adam Barth.
3329
3330         This makes it less likely for gclient changes to break the bots (e.g.,
3331         if a DEPS repository moves or is switched to a branch).
3332
3333         Also pass --force when using |build-webkit --update-chromium| since this
3334         appears to only be used by the bots.
3335
3336         Take 2: Add Options.non_interactive to update.py's options() method.
3337
3338         * Scripts/update-webkit:
3339         * Scripts/webkitdirs.pm:
3340         (determineIsChromium): Add --force-update to update-webkit --chromium.
3341         (forceChromiumUpdate):
3342         (buildChromium): Pass --force to update-webkit-chromium.
3343         * Scripts/webkitpy/tool/steps/update.py:
3344         (Update.run): Add --force-update if non-interactive (i.e., bots).
3345         * Scripts/webkitpy/tool/steps/update_unittest.py:
3346
3347 2011-11-28  Tony Chang  <tony@chromium.org>
3348
3349         Revert r101279, broke the ews and cq bots.
3350
3351         * Scripts/update-webkit:
3352         * Scripts/webkitdirs.pm:
3353         (determineIsChromium):
3354         (buildChromium):
3355         * Scripts/webkitpy/common/config/ports.py:
3356         (WebKitPort.update_webkit_command):
3357         (ChromiumPort.update_webkit_command):
3358         * Scripts/webkitpy/common/config/ports_mock.py:
3359         (MockPort.update_webkit_command):
3360         * Scripts/webkitpy/tool/steps/update.py:
3361         * Scripts/webkitpy/tool/steps/update_unittest.py: Removed.
3362
3363 2011-11-28  Ojan Vafai  <ojan@chromium.org>
3364
3365         testlistjson on the test results server doesn't understand hierarchical results format
3366         https://bugs.webkit.org/show_bug.cgi?id=73246
3367
3368         Reviewed by Tony Chang.
3369
3370         * TestResultServer/model/jsonresults.py:
3371         (JsonResults._delete_results_and_times):
3372         Instead of just getting the top-level keys, we now walk the tests tree and
3373         delete the results and times values.
3374
3375         * TestResultServer/model/jsonresults_unittest.py:
3376         Simplify the test harness to take in the same JSON format for the tests
3377         that the actual results.json uses instead of something very similar but
3378         needlessly different. This also allows for testing the broken case of
3379         results and times values being at non-leaf level.
3380
3381 2011-11-28  Tony Chang  <tony@chromium.org>
3382
3383         ews bots should pass --force to update-webkit-chromium
3384         https://bugs.webkit.org/show_bug.cgi?id=73230
3385
3386         Reviewed by Adam Barth.
3387
3388         This makes it less likely for gclient changes to break the bots (e.g.,
3389         if a DEPS repository moves or is switched to a branch).
3390
3391         Also pass --force when using |build-webkit --update-chromium| since this
3392         appears to only be used by the bots.
3393
3394         * Scripts/update-webkit:
3395         * Scripts/webkitdirs.pm:
3396         (determineIsChromium): Add --force-update to update-webkit --chromium.
3397         (forceChromiumUpdate):
3398         (buildChromium): Pass --force to update-webkit-chromium.
3399         * Scripts/webkitpy/tool/steps/update.py:
3400         (Update.run): Add --force-update if non-interactive (i.e., bots).
3401         * Scripts/webkitpy/tool/steps/update_unittest.py:
3402
3403 2011-11-28  Michael Saboff  <msaboff@apple.com>
3404
3405         Fixed help message for --exclude-kraken to say that
3406         it excludes Kraken and not SunSpider.
3407
3408         Rubber-stamped by Filip Pizlo.
3409
3410         * Scripts/bencher:
3411
3412 2011-11-28  Sheriff Bot  <webkit.review.bot@gmail.com>
3413
3414         Unreviewed, rolling out r101273.
3415         http://trac.webkit.org/changeset/101273
3416         https://bugs.webkit.org/show_bug.cgi?id=73244
3417
3418         multiple test failures and timeouts (Requested by tony^work on
3419         #webkit).
3420
3421         * DumpRenderTree/DumpRenderTree.gypi:
3422         * DumpRenderTree/chromium/EventSender.cpp:
3423         (EventSender::keyDown):
3424         * DumpRenderTree/chromium/TestShellAndroid.cpp: Copied from Tools/DumpRenderTree/chromium/TestShellGtk.cpp.
3425         (AlarmHandler):
3426         (TestShell::waitTestFinished):
3427         (platformInit):
3428         (openStartupDialog):
3429         (checkLayoutTestSystemDependencies):
3430         * DumpRenderTree/chromium/TestShellGtk.cpp:
3431         (AlarmHandler):
3432         (setupFontconfig):
3433         (TestShell::waitTestFinished):
3434         (platformInit):
3435         * DumpRenderTree/chromium/TestShellLinux.cpp: Removed.
3436         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
3437
3438 2011-11-28  John Yani  <vanuan@gmail.com>
3439
3440         new-run-webkit-tests is locale dependent
3441         https://bugs.webkit.org/show_bug.cgi?id=68691
3442
3443         Reviewed and modified by Eric Seidel.
3444
3445         This is a simpler version of John's patch which I'm landing.
3446         This just engages the hacks from the Host constructor on a global
3447         basis.
3448
3449         * Scripts/webkitpy/common/host.py:
3450         (Host.__init__):
3451         (Host._engage_awesome_locale_hacks):
3452
3453 2011-11-28  Fady Samuel  <fsamuel@chromium.org>
3454
3455         [Chromium] Fix broken DRT build for Aura Linux
3456         https://bugs.webkit.org/show_bug.cgi?id=72667
3457
3458         Reviewed by Tony Chang.
3459
3460         DRT now builds for Aura Linux. This, more or less, shares the same code as Android.
3461
3462         The following changes have been made:
3463
3464           1. Renamed TestShellAndroid to TestShellLinux.
3465           2. Stub code moved added in TestShellStub that will only compile on non-GTK Linux builds.
3466           3. Code common to Gtk, Aura, and Android moved to TestShellLinux.
3467
3468         * DumpRenderTree/DumpRenderTree.gypi:
3469         * DumpRenderTree/chromium/EventSender.cpp:
3470         (EventSender::keyDown):
3471         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
3472         * DumpRenderTree/chromium/TestShellGtk.cpp:
3473         * DumpRenderTree/chromium/TestShellLinux.cpp: Copied from Tools/DumpRenderTree/chromium/TestShellGtk.cpp.
3474         (AlarmHandler):
3475         (TestShell::waitTestFinished):
3476         (setupFontconfig):
3477         (platformInit):
3478         * DumpRenderTree/chromium/TestShellStub.cpp: Added.
3479         (checkLayoutTestSystemDependencies):
3480         (openStartupDialog):
3481
3482 2011-11-28  Eric Seidel  <eric@webkit.org>
3483
3484         Add Environment object to Host and fix the GCC smartquotes trouble seen on the commit-queue
3485         https://bugs.webkit.org/show_bug.cgi?id=71983
3486
3487         Reviewed by Adam Barth.
3488
3489         We'll add more code to Environment overtime,
3490         allowing us to mock out more of our direct interactions with os.environ.
3491
3492         This patch also makes run_command print the passed in environment.
3493
3494         * Scripts/webkitpy/common/host_mock.py:
3495         * Scripts/webkitpy/common/system/environment.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
3496         * Scripts/webkitpy/common/system/environment_mock.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
3497         * Scripts/webkitpy/common/system/environment_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
3498         * Scripts/webkitpy/common/system/executive.py:
3499         * Scripts/webkitpy/common/system/executive_mock.py:
3500         * Scripts/webkitpy/layout_tests/port/webkit.py:
3501         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3502         * Scripts/webkitpy/tool/commands/download_unittest.py:
3503         * Scripts/webkitpy/tool/steps/build.py:
3504
3505 2011-11-28  Simon Hausmann  <simon.hausmann@nokia.com>
3506
3507         [Qt] Build system fixes against V8.
3508
3509         Reviewed by Tor Arne Vestbø.
3510
3511         * qmake/mkspecs/features/webcore.prf: Get rid of old v8 cruft.
3512         * qmake/mkspecs/features/wtf.prf: If requested, pull in v8 from Qt and configure
3513         WTF accordingly to use v8. (WTF in the implementation needs it as well as users of WTF)
3514
3515 2011-11-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3516
3517         Make sure the useFixedLayout feature is consistently handled
3518         https://bugs.webkit.org/show_bug.cgi?id=73212
3519
3520         Reviewed by Simon Hausmann.
3521
3522         The web page parameters are set to our Qt defaults and are now altered
3523         in the WebKitTestRunner.
3524
3525         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3526         (WTR::WrapperWindow::WrapperWindow):
3527
3528 2011-11-28  Simon Hausmann  <simon.hausmann@nokia.com>
3529
3530         [Qt] WTF should be built as separate static library
3531         https://bugs.webkit.org/show_bug.cgi?id=73201
3532
3533         Reviewed by Tor Arne Vestbø.
3534
3535         * DumpRenderTree/qt/DumpRenderTree.pro: Require wtf.
3536         * MiniBrowser/qt/BrowserWindow.cpp: Remove unnecessary config.h inclusion and
3537         thus wtf dependency.
3538         * WebKitTestRunner/InjectedBundle/Target.pri: Require wtf.
3539         * WebKitTestRunner/Target.pri: Ditto.
3540         * qmake/mkspecs/features/default_post.prf: When re-ordering the static libs
3541         consider wtf, too.
3542         * qmake/mkspecs/features/javascriptcore.prf: Remove WTF specific build stuff,
3543         moved into wtf.prf.
3544         * qmake/mkspecs/features/qtwebkit.prf: For debug builds with shared libs, also
3545         link in libwtf.
3546         * qmake/mkspecs/features/wtf.prf: Added. Stuff needed for building and using WTF.
3547
3548 2011-11-28  Kentaro Hara  <haraken@chromium.org>
3549
3550         run-bindings-tests shows diff error for a newly added binding test
3551         https://bugs.webkit.org/show_bug.cgi?id=73179
3552
3553         Reviewed by Adam Barth.
3554
3555         Currently, when we add a new binding test, say bindings/scripts/test/TestSupplemental.idl,
3556         run-bindings-tests just shows diff error because reference files
3557         (i.e. {V8,JS,...}TestSupplemental.h and {V8,JS,...}TestSupplemental.cpp) do not yet exist:
3558
3559             FAIL: (V8) V8TestSupplemental.h
3560             diff: WebCore/bindings/scripts/test/V8/V8TestSupplemental.h: No such file or directory
3561
3562         Instead, this patch treats a non-existent reference file as an empty file and
3563         shows the result of the newly added binding test, like this:
3564
3565             FAIL: (V8) V8TestSupplemental.h
3566             --- WebCore/bindings/scripts/test/V8/V8TestSupplemental.h       1970-01-01 09:00:00.000000000 +0900
3567             +++ /tmp/tmpmX2i2F/V8TestSupplemental.h 2011-11-28 11:08:34.150707677 +0900
3568             @@ -0,0 +1,84 @@
3569             +/*
3570             +    This file is part of the WebKit open source project.
3571             +    This file has been generated by generate-bindings.pl. DO NOT MODIFY!
3572             +
3573             (omitted)
3574
3575         * Scripts/run-bindings-tests:
3576         (detect_changes): Just added an -N option to the diff command.
3577
3578 2011-11-28  Martin Robinson  <mrobinson@igalia.com>
3579
3580         [Gtk][gtkdoc] Syntax error in Tools/gtk/generate-gtkdoc
3581         https://bugs.webkit.org/show_bug.cgi?id=73165
3582
3583         Reviewed by Philippe Normand.
3584
3585         Fix some syntax errors in this script and remove an unused variable.
3586
3587         * gtk/generate-gtkdoc:
3588         (get_webkit2_options.src_path): 
3589         (get_webkit2_options):
3590         (get_webkit1_options.src_path):
3591
3592 2011-11-26  Kevin Ollivier  <kevino@theolliviers.com>
3593
3594         [wx] Unreviewed build fix. Enable the inspector.
3595         
3596         * waf/build/settings.py:
3597
3598 2011-11-26  Martin Robinson  <mrobinson@igalia.com>
3599
3600         Try to fix the build after r101174.
3601
3602         * gtk/generate-gtkdoc: Properly handle empty PKG_CONFIG_PATHs.
3603
3604 2011-11-17  Martin Robinson  <mrobinson@igalia.com>
3605
3606         [GTK] Integrate build-gtkdoc into build-webkit and make
3607         https://bugs.webkit.org/show_bug.cgi?id=72626
3608
3609         Reviewed by Philippe Normand.
3610
3611         * GNUmakefile.am: Added support for new scripts and "make docs".
3612         * Scripts/webkitdirs.pm: Call generate-gtkdoc when building.
3613         (buildAutotoolsProject):
3614         * gtk/generate-gtkdoc: Added.
3615         * gtk/gtkdoc.py: Renamed from Source/WebKit2/UIProcess/API/gtk/docs/gtkdoc.py.
3616
3617 2011-11-25  Ádám Kallai  <Kallai.Adam@stud.u-szeged.hu>
3618
3619         [Qt] Add support for using OWRT with Qt5
3620         https://bugs.webkit.org/show_bug.cgi?id=72947
3621
3622         Add qt-5.0 platform and don't pass -graphicssystem to QtTestBrowser if using Qt5.
3623
3624         Reviewed by Csaba Osztrogonác.
3625
3626         * Scripts/old-run-webkit-tests:
3627
3628 2011-11-25  Yury Semikhatsky  <yurys@chromium.org>
3629
3630         [Chromium] Web Inspector: get rid of WebDevToolsFrontendClient::sendFrontendLoaded method
3631         https://bugs.webkit.org/show_bug.cgi?id=73126
3632
3633         No need to have a separate client call for this. The front-end can store messages
3634         which arrive before front-end loaded and dispatch them later. This happens in layout
3635         tests only by the way as all other messages should be initiated by the front-end code.
3636
3637         Reviewed by Pavel Feldman.
3638
3639         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
3640         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3641         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
3642