[GTK] Allow to run any jhbuild command with jhbuild-wrapper script
[WebKit-https.git] / Tools / ChangeLog
1 2012-03-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2
3         [GTK] Allow to run any jhbuild command with jhbuild-wrapper script
4         https://bugs.webkit.org/show_bug.cgi?id=81888
5
6         Reviewed by Philippe Normand.
7
8         * Scripts/update-webkit-libs-jhbuild:
9         (runJhbuild): Helper function to run jhbuild with a given command.
10         Instead of running jhbuild directly, use the jhbuild-wrapper, so
11         that we don't need to run it first to check whether jhbuild is
12         installed or not.
13         * efl/run-with-jhbuild: Call jhbuild-wrapper with run command.
14         * gtk/run-with-jhbuild: Ditto.
15         * jhbuild/jhbuild-wrapper: Allow to execute any jhbuild command,
16         not only run.
17
18 2012-03-22  Philippe Normand  <pnormand@igalia.com>
19
20         Unreviewed, test-webkitpy fix after r111661.
21
22         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
23         (MainTest.test_crash_log):
24         (MainTest.test_web_process_crash_log):
25
26 2012-03-22  Philippe Normand  <pnormand@igalia.com>
27
28         Unreviewed, test-webkitpy fix after r111642.
29
30         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
31         (ChromiumDriverTest.setUp):
32         (ChromiumDriverTest.test_two_drivers):
33
34 2012-03-22  Csaba Osztrogonác  <ossy@webkit.org>
35
36         webkitpy: clean up actually getting crash logs from DRT/WTR crashes
37         https://bugs.webkit.org/show_bug.cgi?id=81603
38
39         Unreviewed rolling out r111609 and part of r111615,
40         because it broke NRWT on Qt-WK2 platform.
41
42         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
43         (SingleTestRunner._handle_error):
44         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
45         (write_test_result):
46         (TestResultWriter.write_crash_report):
47         * Scripts/webkitpy/layout_tests/port/base.py:
48         (Port.is_crash_reporter):
49         (Port._driver_class):
50         * Scripts/webkitpy/layout_tests/port/chromium.py:
51         (ChromiumDriver.run_test):
52         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
53         (ChromiumDriverTest.test_crashed_process_name):
54         * Scripts/webkitpy/layout_tests/port/driver.py:
55         (DriverOutput.__init__):
56         * Scripts/webkitpy/layout_tests/port/mac.py:
57         (MacPort):
58         (MacPort.is_crash_reporter):
59         (MacPort.release_http_lock):
60         * Scripts/webkitpy/layout_tests/port/test.py:
61         (TestDriver.run_test):
62         * Scripts/webkitpy/layout_tests/port/webkit.py:
63         (WebKitDriver.__init__):
64         (WebKitDriver._start):
65         (WebKitDriver.has_crashed):
66         (WebKitDriver._check_for_driver_crash):
67         (WebKitDriver.run_test):
68
69 2012-03-22  Csaba Osztrogonác  <ossy@webkit.org>
70
71         [Qt] Add full platforms to Qt buildslaves
72         https://bugs.webkit.org/show_bug.cgi?id=81877
73
74         Reviewed by Ryosuke Niwa.
75
76         * BuildSlaveSupport/build.webkit.org-config/config.json:
77
78 2012-03-21  Johnny Ding  <jnd@chromium.org>
79
80         Customize layout test timeout value for different ports.
81         https://bugs.webkit.org/show_bug.cgi?id=79859
82
83         Reviewed by Ojan Vafai.
84
85         * Scripts/webkitpy/layout_tests/controllers/manager.py:
86         (Manager):
87         * Scripts/webkitpy/layout_tests/port/base.py:
88         (Port.default_test_timeout_ms):
89         * Scripts/webkitpy/layout_tests/port/chromium.py:
90         (ChromiumDriver.stop):
91         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
92         (ChromiumAndroidPort.default_test_timeout_ms):
93         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
94         (_set_up_derived_options):
95
96 2012-03-21  Mark Rowe  <mrowe@apple.com>
97
98         Fix the build.
99
100         Ensure that our test tools don't try and use RTTI unnecessarily.
101
102         * DumpRenderTree/mac/Configurations/Base.xcconfig:
103         * TestWebKitAPI/Configurations/Base.xcconfig:
104         * WebKitTestRunner/Configurations/Base.xcconfig:
105
106 2012-03-21  Adam Barth  <abarth@webkit.org>
107
108         WebKit should have some scripts to smooth interactions with GitHub
109         https://bugs.webkit.org/show_bug.cgi?id=81842
110
111         Reviewed by Eric Seidel.
112
113         These scripts support the workflow in
114         https://trac.webkit.org/wiki/UsingGitHub by automating the
115         configuration and syncing operations needed for a GitHub fork of WebKit
116         to track the main WebKit repository.
117
118         * Scripts/configure-github-as-upstream: Added.
119         * Scripts/sync-master-with-upstream: Added.
120
121 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
122
123         WTR - log the pid of a crashing WebProcess
124         https://bugs.webkit.org/show_bug.cgi?id=81575
125
126         Reviewed by Alexey Proskuryakov.
127
128         This allows run-webkit-tests to find the right crash log for a
129         given crashed WebProcess in WebKit2.
130
131         * WebKitTestRunner/TestController.cpp:
132         (WTR::exceededDatabaseQuota):
133         (WTR::TestController::createOtherPage):
134         (WTR::TestController::initialize):
135         (WTR::TestController::resetStateToConsistentValues):
136         (WTR::TestController::runTest):
137         (WTR::TestController::processDidCrash):
138
139 2012-03-21  Enrica Casucci  <enrica@apple.com>
140
141         WebKitURLWithTitles pasteboard format should support URLs containing Emoji characters.
142         https://bugs.webkit.org/show_bug.cgi?id=81835
143         <rdar://problem/11082749>
144
145         Reviewed by Brady Eidson.
146
147         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html:
148         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
149         (TestWebKitAPI::contextMenuCopyLink):
150
151 2012-03-21  Alexandru Chiculita  <achicu@adobe.com>
152
153         [CSS Shaders] Make CSS Shaders compile on Chromium
154         https://bugs.webkit.org/show_bug.cgi?id=81435
155
156         Reviewed by Stephen White.
157         
158         I've added WebKitCSSCustomFilterEnabled support for the layoutTestController.overridePreference function.
159
160         * DumpRenderTree/chromium/LayoutTestController.cpp:
161         (LayoutTestController::overridePreference):
162         * DumpRenderTree/chromium/WebPreferences.cpp:
163         (WebPreferences::reset):
164         (WebPreferences::applyTo):
165         * DumpRenderTree/chromium/WebPreferences.h:
166         (WebPreferences):
167
168 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
169
170         fix regression on gtk port introduced by r111609
171         https://bugs.webkit.org/show_bug.cgi?id=81839
172
173         Reviewed by Philippe Normand.
174
175         r111609 should've initialized a couple of missing fields in
176         WebKitDriver, and also should've checked for method overrides
177         in the other ports :(.
178
179         * Scripts/webkitpy/layout_tests/port/gtk.py:
180         (GtkDriver._start):
181         * Scripts/webkitpy/layout_tests/port/webkit.py:
182         (WebKitDriver.__init__):
183         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
184         (MainTest.test_crash_log):
185         (MainTest.test_web_process_crash_log):
186
187 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
188
189         webkitpy: clean up actually getting crash logs from DRT/WTR crashes
190         https://bugs.webkit.org/show_bug.cgi?id=81603
191
192         Reviewed by Adam Barth.
193
194         Add a new _get_crash_log() overridable method on the Port
195         object to customize how we fetch crash logs per port.
196         Mac will now slow-spin with a timeout waiting for the crash log, rather
197         than waiting for the ReportCrash process to exit (it appears
198         that the mac will manage multiple crashes with a single
199         ReportCrash process, the process waits around longer than
200         necessary, presumably to avoid thrashing if processes are
201         repeatedly crashing).
202
203         Also, add the DriverOutput should contain the crash log and other info,
204         which is created in a port-specific manner but can then be
205         treated generically. Previously single_test_runner would get
206         told that something crashed and attempt to do something to get
207         the crash log, but it didn't have the information it needed to
208         od the right thing; better to make the driver hand back the
209         right info.
210
211         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
212         (SingleTestRunner._handle_error):
213         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
214         (write_test_result):
215         (TestResultWriter.write_crash_log):
216         * Scripts/webkitpy/layout_tests/port/base.py:
217         (Port.diff_text):
218         (Port._get_crash_log):
219         * Scripts/webkitpy/layout_tests/port/chromium.py:
220         (ChromiumDriver.run_test):
221         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
222         (ChromiumDriverTest.test_crash_log):
223         * Scripts/webkitpy/layout_tests/port/driver.py:
224         (DriverOutput.__init__):
225         * Scripts/webkitpy/layout_tests/port/mac.py:
226         (MacPort.is_lion):
227         (MacPort._get_crash_log):
228         * Scripts/webkitpy/layout_tests/port/test.py:
229         (TestDriver.run_test):
230         * Scripts/webkitpy/layout_tests/port/webkit.py:
231         (WebKitDriver.__init__):
232         (WebKitDriver._start):
233         (WebKitDriver.has_crashed):
234         (WebKitDriver._check_for_driver_crash):
235         (WebKitDriver.run_test):
236
237 2012-03-21  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
238
239         [EFL] Use jhbuild downloaded fonts instead of hardcoded system font paths
240         https://bugs.webkit.org/show_bug.cgi?id=81507
241
242         Now that we're only loading from one directory, no need to
243         iterate over a list of directories anymore.
244
245         Reviewed by Martin Robinson.
246
247         * DumpRenderTree/efl/CMakeLists.txt:
248         * DumpRenderTree/efl/FontManagement.cpp:
249         (addFontDirectory):
250         (addFontsToEnvironment):
251
252 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
253
254         webkitpy: get ServerProcess out of the reportcrash business
255         https://bugs.webkit.org/show_bug.cgi?id=81600
256
257         Unreviewed, build fix.
258
259         Re-land r111307 and r111293 with another fix for a crash in NRWT;
260         we need to check if the driver has crashed before attempting to
261         read from it.
262
263
264         * Scripts/webkitpy/layout_tests/port/server_process.py:
265         (ServerProcess._reset):
266         (ServerProcess._handle_possible_interrupt):
267         (ServerProcess.write):
268         (ServerProcess.read_stdout):
269         (ServerProcess.has_crashed):
270         (ServerProcess._read):
271         (ServerProcess.stop):
272         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
273         (TrivialMockPort.check_for_leaks):
274         (TestServerProcess.test_broken_pipe):
275         * Scripts/webkitpy/layout_tests/port/webkit.py:
276         (WebKitPort._read_image_diff):
277         (WebKitDriver.has_crashed):
278         (WebKitDriver._check_for_driver_crash):
279         (WebKitDriver.run_test):
280         (WebKitDriver._read_block):
281         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
282         (MockServerProcess.__init__):
283         (MockServerProcess):
284         (MockServerProcess.has_crashed):
285
286 2012-03-21  Zeno Albisser  <zeno@webkit.org>
287
288         [Qt][Mac] ranlib segfaults when creating symbol tables for libWebCore.a.
289         https://bugs.webkit.org/show_bug.cgi?id=81750
290
291         Building WebCore on mac currently creates an archive that is bigger than
292         4GB. But ranlib fails to create a symbol table for such a big archive,
293         even on 64bit machines.
294         Therefore we start using SVGAllInOne.cpp when building debug
295         on mac. This reduces the size of the archive by about 300MB.
296
297         Reviewed by Tor Arne Vestbø.
298
299         * qmake/mkspecs/features/mac/default_pre.prf:
300
301 2012-03-21  Szilard Ledan  <szledan@inf.u-szeged.hu>
302
303         Updated the address list of committers.py.
304
305         Reviewed by Csaba Osztrogonác.
306
307         * Scripts/webkitpy/common/config/committers.py:
308
309 2012-03-21  W. James MacLean  <wjmaclean@chromium.org>
310
311         Updating my nick in committers file.
312
313         Unreviewed.
314
315         * Scripts/webkitpy/common/config/committers.py:
316
317 2012-03-21  Peter Beverloo  <peter@chromium.org>
318
319         [Chromium] Remove Android build-fix when the proper fix rolled into WebKit
320         https://bugs.webkit.org/show_bug.cgi?id=80861
321
322         Reviewed by Tony Chang.
323
324         Remove most Android-specific logic from webkitdirs.pm in favor of
325         handling this during project generation time.
326
327         * Scripts/webkitdirs.pm:
328         (buildChromiumMakefile):
329
330 2012-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
331
332         [GTK] Allow running javascript from location bar in MiniBrowser
333         https://bugs.webkit.org/show_bug.cgi?id=81331
334
335         Reviewed by Martin Robinson.
336
337         * MiniBrowser/gtk/BrowserWindow.c:
338         (activateUriEntryCallback): Use browser_window_load_uri().
339         (browser_window_load_uri): Check whether uri starts with
340         javascript: and run the given script, or just call
341         webkit_web_view_load_uri() to load the given uri.
342         * MiniBrowser/gtk/BrowserWindow.h:
343         * MiniBrowser/gtk/main.c:
344         (createBrowserWindow): Use browser_window_load_uri().
345
346 2012-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
347
348         [GTK] Add webkit_web_view_run_javascript() to WebKit2 GTK+
349         https://bugs.webkit.org/show_bug.cgi?id=75543
350
351         Reviewed by Martin Robinson.
352
353         * MiniBrowser/gtk/GNUmakefile.am: Add javascriptcore_cppflags to
354         MiniBrowser CPP flags.
355
356 2012-03-20  Eric Seidel  <eric@webkit.org>
357
358         Move wtf/Platform.h from JavaScriptCore to Source/WTF/wtf
359         https://bugs.webkit.org/show_bug.cgi?id=80911
360
361         Reviewed by Adam Barth.
362
363         Update include paths for Source/WTF.
364
365         * DumpRenderTree/efl/CMakeLists.txt:
366         * DumpRenderTree/qt/DumpRenderTree.pro:
367         * QtTestBrowser/QtTestBrowser.pro:
368         * Scripts/build-webkit: Build Source/WTF on AppleWin as well.
369
370 2012-03-20  Adam Barth  <abarth@webkit.org>
371
372         svn-apply should move inflight patches from WebCore/webaudio to WebCore/Modules/webaudio
373         https://bugs.webkit.org/show_bug.cgi?id=81567
374
375         Reviewed by Eric Seidel.
376
377         This temporary measure should help us avoid disrupting the folks
378         working on WebAudio when we move the webaudio directory to Modules.
379
380         * Scripts/VCSUtils.pm:
381         (adjustPathForRecentRenamings):
382         (parseGitDiffHeader):
383         (parseSvnDiffHeader):
384
385 2012-03-20  Dirk Pranke  <dpranke@chromium.org>
386
387         Unreviewed, rolling out r111453.
388         http://trac.webkit.org/changeset/111453
389         https://bugs.webkit.org/show_bug.cgi?id=81600
390
391         still broken
392
393         * Scripts/webkitpy/layout_tests/port/server_process.py:
394         (ServerProcess._reset):
395         (ServerProcess.handle_interrupt):
396         (ServerProcess.write):
397         (ServerProcess._check_for_crash):
398         (ServerProcess._handle_timeout):
399         (ServerProcess._check_for_abort):
400         (ServerProcess._read):
401         (ServerProcess.stop):
402         (ServerProcess):
403         (ServerProcess.set_crashed):
404         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
405         (TrivialMockPort.is_crash_reporter):
406         (TestServerProcess.test_broken_pipe):
407         * Scripts/webkitpy/layout_tests/port/webkit.py:
408         (WebKitPort._read_image_diff):
409         (WebKitDriver.has_crashed):
410         (WebKitDriver._check_for_driver_crash):
411         (WebKitDriver):
412         (WebKitDriver._detected_crash):
413         (WebKitDriver._subprocess_crashed):
414         (WebKitDriver._crashed_process_name):
415         (WebKitDriver.run_test):
416         (WebKitDriver._read_block):
417         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
418         (MockServerProcess.__init__):
419
420 2012-03-20  Dirk Pranke  <dpranke@chromium.org>
421
422         webkitpy: get ServerProcess out of the reportcrash business
423         https://bugs.webkit.org/show_bug.cgi?id=81600
424
425         Unreviewed, build fix.
426
427         Re-land r111307 and r111293 with fix for crash in NRWT; I
428         was failing to set the crashing process name.
429
430         * Scripts/webkitpy/layout_tests/port/server_process.py:
431         (ServerProcess._reset):
432         (ServerProcess._handle_possible_interrupt):
433         (ServerProcess.write):
434         (ServerProcess.read_stdout):
435         (ServerProcess.has_crashed):
436         (ServerProcess._read):
437         (ServerProcess.stop):
438         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
439         (TrivialMockPort.check_for_leaks):
440         (TestServerProcess.test_broken_pipe):
441         * Scripts/webkitpy/layout_tests/port/webkit.py:
442         (WebKitPort._read_image_diff):
443         (WebKitDriver.has_crashed):
444         (WebKitDriver._check_for_driver_crash):
445         (WebKitDriver.run_test):
446         (WebKitDriver._read_block):
447         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
448         (MockServerProcess.__init__):
449         (MockServerProcess):
450         (MockServerProcess.has_crashed):
451
452 2012-03-20  Tim Horton  <timothy_horton@apple.com>
453
454         [mac] Restore color space switching code to run-webkit-tests
455         https://bugs.webkit.org/show_bug.cgi?id=80571
456         <rdar://problem/11008529>
457
458         Reviewed by Simon Fraser.
459
460         http://trac.webkit.org/changeset/111429 broke tools build on Snow Leopard.
461         
462         Use the old CM* API on Snow Leopard, since CGDisplayCreateUUIDFromDisplayID
463         didn't exist until Lion.
464
465         * DumpRenderTree/mac/LayoutTestHelper.m:
466         (installLayoutTestColorProfile):
467         (restoreUserColorProfile):
468
469 2012-03-20  Adele Peterson  <adele@apple.com>
470
471         Update the last test to use EXPECT_WK_STREQ.
472
473         Reviewed by Dan Bernstein.
474
475         * TestWebKitAPI/Tests/mac/AttributedString.mm: (TestWebKitAPI::TEST):
476
477 2012-03-20  Adele Peterson  <adele@apple.com>
478
479         "Attempt to insert nil value " exception when calling attributed string APIs on content with a custom font
480         https://bugs.webkit.org/show_bug.cgi?id=81630
481         <rdar://problem/10650660>
482
483         Reviewed by Alexey Proskuryakov.
484
485         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
486         * TestWebKitAPI/Tests/mac/Ahem.ttf: Added.
487         * TestWebKitAPI/Tests/mac/AttributedString.mm: Added.
488         (-[AttributedStringTest webView:didFinishLoadForFrame:]):
489         (TestWebKitAPI):
490         (TestWebKitAPI::didFinishLoadForFrame):
491         (TestWebKitAPI::TEST):
492         * TestWebKitAPI/Tests/mac/attributedStringCustomFont.html: Added.
493
494 2012-03-20  Eric Seidel  <eric@webkit.org>
495
496         Add link on queues.webkit.org to kov's fancy queue-depth graph
497         https://bugs.webkit.org/show_bug.cgi?id=81690
498
499         Reviewed by Adam Barth.
500
501         * QueueStatusServer/templates/recentstatus.html:
502
503 2012-03-20  Tim Horton  <timothy_horton@apple.com>
504
505         [mac] Restore color space switching code to run-webkit-tests
506         https://bugs.webkit.org/show_bug.cgi?id=80571
507         <rdar://problem/11008529>
508
509         Reviewed by Simon Fraser.
510
511         Make use of the layout test helper hooks to restore the Mac system-wide
512         color profile switching code. This makes WkTR and DRT results match, and
513         causes the main display's color profile to not affect results on Lion.
514
515         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
516         * DumpRenderTree/mac/LayoutTestHelper.m: Added.
517         (installLayoutTestColorProfile):
518         (restoreUserColorProfile):
519         (simpleSignalHandler):
520         (main):
521         * Scripts/webkitpy/layout_tests/port/mac.py:
522         (MacPort.release_http_lock):
523         (MacPort):
524         (MacPort._path_to_helper):
525         (MacPort.start_helper):
526         (MacPort.stop_helper):
527         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
528         (WTR::PlatformWebView::PlatformWebView):
529         (WTR::PlatformWebView::windowSnapshotImage):
530
531 2012-02-24  Darin Fisher  <darin@chromium.org>
532
533         Add more Chromium WebKit API reviewers
534         https://bugs.webkit.org/show_bug.cgi?id=81576
535
536         Reviewed by Adam Barth and David Levin.
537
538         Simplify watchlist to lump all WebKit API into one.
539
540         * Scripts/webkitpy/common/config/watchlist:
541
542 2012-03-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
543
544         Convert hasSpellingMarker to use Internals interface.
545         https://bugs.webkit.org/show_bug.cgi?id=81300
546
547         Reviewed by Ryosuke Niwa.
548
549         Remove hasSpellingMarker functions, because it is able to work in the
550         cross-port way through the Internals interface.
551
552         * DumpRenderTree/LayoutTestController.cpp:
553         (LayoutTestController::staticFunctions):
554         * DumpRenderTree/LayoutTestController.h:
555         (LayoutTestController):
556         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
557         * DumpRenderTree/chromium/LayoutTestController.cpp:
558         (LayoutTestController::LayoutTestController):
559         * DumpRenderTree/chromium/LayoutTestController.h:
560         (LayoutTestController):
561         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
562         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
563         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
564         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
565         * DumpRenderTree/qt/LayoutTestControllerQt.h:
566         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
567         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
568
569 2012-03-20  Csaba Osztrogonác  <ossy@webkit.org>
570
571         Add new Qt-WK2 performance tester bot to build.webkit.org
572         https://bugs.webkit.org/show_bug.cgi?id=80842
573
574         Reviewed by Ryosuke Niwa.
575
576         * BuildSlaveSupport/build.webkit.org-config/config.json:
577         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
578         (RunAndUploadPerfTestsWebKit2):
579         (RunAndUploadPerfTestsWebKit2.start):
580         (BuildAndPerfTestWebKit2Factory):
581         (BuildAndPerfTestWebKit2Factory.__init__):
582         (DownloadAndPerfTestWebKit2Factory):
583         (DownloadAndPerfTestWebKit2Factory.__init__):
584
585 2012-03-20  Peter Beverloo  <peter@chromium.org>
586
587         [Chromium] Update to Android NDK r7b
588         https://bugs.webkit.org/show_bug.cgi?id=81005
589
590         Reviewed by Adam Barth.
591
592         Update to version r7b of the Android NDK, release notes of which are
593         available on the following page:
594         http://developer.android.com/sdk/ndk/index.html
595
596         * Scripts/update-webkit-chromium:
597
598 2012-03-20  Csaba Osztrogonác  <ossy@webkit.org>
599
600         x86 GCC bug triggers a compilation error in generated copy constructor of CollapsedBorderValue
601         https://bugs.webkit.org/show_bug.cgi?id=81502
602
603         Unreviewed.
604
605         * qmake/mkspecs/features/unix/default_post.prf: Reenable Werror after r111171.
606
607 2012-03-19  Jessie Berlin  <jberlin@apple.com>
608
609         Unreviewed; roll out http://trac.webkit.org/changeset/111307 and http://trac.webkit.org/changeset/111293
610         because they broke running the layout tests on mac.
611
612         * Scripts/webkitpy/layout_tests/port/webkit.py:
613         (WebKitDriver._check_for_driver_crash):
614
615 2012-03-16  Martin Robinson  <mrobinson@igalia.com>
616
617         [GTK] Allow running run-gtk-tests during 'make distcheck'
618         https://bugs.webkit.org/show_bug.cgi?id=81415
619
620         Reviewed by Philippe Normand.
621
622         Modify the build and run-gtk-tests so that it can run during 'make distcheck'
623
624         * GNUmakefile.am: Distribute run-gtk-tests during 'make dist' and make it the
625         main command run during 'make check.'
626         * Scripts/run-gtk-tests: Refactored run-gtk-tests so that jhbuild is no longer
627         a requirement to run it. If jhbuild isn't around it will simply not start the
628         SPI daemons and skip the WebKit2 accessibility test. Remove test runs from the
629         main loop and simply use the main loop in a synchronous method to start SPI
630         daemons. Did a bunch of general cleanup around these tasks.
631
632 2012-03-19  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
633
634         jhbuild: Use the multiprocessing module to get the number of CPUs.
635         https://bugs.webkit.org/show_bug.cgi?id=81585
636
637         Reviewed by Martin Robinson.
638
639         Now that support for Python 2.5 has been dropped, we can safely
640         use multiprocessing.cpu_count() to obtain the current number of
641         CPUs in the system instead of running a webkitperl script for
642         that.
643
644         * efl/common.py:
645         (top_level_path):
646         * efl/jhbuildrc:
647         * gtk/common.py:
648         (build_path):
649         * gtk/jhbuildrc:
650
651 2012-03-19  Ojan Vafai  <ojan@chromium.org>
652
653         We should only add a live event listener once, not once per TestSelector.
654         Adding one per TestSelector would cause accordion('option', 'active') to
655         incorrectly be "false" if you examine multiple sets of tests.
656
657         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
658
659 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
660
661         Fix typo introduced in r111293.
662
663         Unreviewed, build fix.
664
665         * Scripts/webkitpy/layout_tests/port/webkit.py:
666         (WebKitDriver._check_for_driver_crash):
667
668 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
669
670         webkitpy: get ServerProcess out of the reportcrash business
671         https://bugs.webkit.org/show_bug.cgi?id=81600
672
673         Reviewed by Adam Barth.
674
675         ServerProcess was half-aware that ReportCrash might run
676         sometimes, and that the process ServerProcess was talking to
677         might have its own crashing subprocesses; neither of these
678         things really worked right and it made the logic convoluted, so
679         this change makes handling crashes completely separate from the
680         server_process code, so that it can focus on just I/O to the
681         subprocess.
682
683         There should be no functional changes resulting from this patch.
684
685         * Scripts/webkitpy/layout_tests/port/server_process.py:
686         (ServerProcess._reset):
687         (ServerProcess._handle_possible_interrupt):
688         (ServerProcess.write):
689         (ServerProcess.read_stdout):
690         (ServerProcess.has_crashed):
691         (ServerProcess._read):
692         (ServerProcess.stop):
693         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
694         (TrivialMockPort.check_for_leaks):
695         (TestServerProcess.test_broken_pipe):
696         * Scripts/webkitpy/layout_tests/port/webkit.py:
697         (WebKitPort._read_image_diff):
698         (WebKitDriver.has_crashed):
699         (WebKitDriver._check_for_driver_crash):
700         (WebKitDriver.run_test):
701         (WebKitDriver._read_block):
702         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
703         (MockServerProcess.__init__):
704         (MockServerProcess):
705         (MockServerProcess.has_crashed):
706
707 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
708
709         webkitpy: crashlog parsing is broken
710         https://bugs.webkit.org/show_bug.cgi?id=81586
711
712         Reviewed by Adam Barth.
713
714         Seeking on a file opened through codecs() appears to not work
715         correctly (at least on SL).
716         
717         The code was more complicated than it needed to be, so I have
718         revamped it to just read a full crashlog at once and then look
719         for matches. 
720         
721         I have also added the ability to optionally propagate
722         errors back (which can be helpful to debug races when ReportCrash is
723         still running and you need to see that you couldn't open some
724         files, rather than just ignoring them).
725
726         * Scripts/webkitpy/common/system/crashlogs.py:
727         (CrashLogs.find_newest_log):
728         (CrashLogs._find_newest_log_darwin):
729         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
730         (CrashLogsTest.test_find_log_darwin):
731
732 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
733
734         webkitpy: clean up some port._filesystem references to not reference private members
735         https://bugs.webkit.org/show_bug.cgi?id=81595
736
737         Reviewed by Eric Seidel.
738
739         There should be no functional changes in this patch, just some
740         refactoring. Also, fixes a minor nit in write_image_diff_files(()
741
742         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
743         (SingleTestRunner.__init__):
744         (SingleTestRunner._run_compare_test):
745         (SingleTestRunner._run_rebaseline):
746         (SingleTestRunner._save_baseline_data):
747         (SingleTestRunner._handle_error):
748         (SingleTestRunner._run_reftest):
749         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
750         (write_test_result):
751         (TestResultWriter.__init__):
752         (TestResultWriter._make_output_directory):
753         (TestResultWriter.output_filename):
754         (TestResultWriter._output_testname):
755         (TestResultWriter.write_output_files):
756         (TestResultWriter.write_stderr):
757         (TestResultWriter.write_crash_report):
758         (TestResultWriter.create_text_diff_and_write_result):
759         (TestResultWriter.write_image_diff_files):
760         (copy_file):
761         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
762         (TestResultWriterTest.test_reftest_diff_image):
763
764 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
765
766         webkitpy: fix nit - incorrect reference to DRT in test_expectations.py
767         https://bugs.webkit.org/show_bug.cgi?id=81598
768
769         Reviewed by Eric Seidel.
770
771         "DumpRenderTree" shouldn't be hard-coded here, since some other
772         process may actually be crashing (WebKitTestRunner, WebProcess, etc.)
773         
774         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
775         (TestExpectations):
776
777 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
778
779         webkitpy: allow instance data in TestFailure objects
780         https://bugs.webkit.org/show_bug.cgi?id=81580
781
782         Reviewed by Tony Chang.
783
784         Current TestFailures are basically enums, but it would be nice,
785         especially for crashes, if they contained the name and pid of
786         the process that crashed.
787
788         * Scripts/webkitpy/layout_tests/models/test_failures.py:
789         (TestFailure.message):
790         (FailureTimeout.message):
791         (FailureCrash):
792         (FailureCrash.__init__):
793         (FailureCrash.message):
794         (FailureMissingResult.message):
795         (FailureTextMismatch.message):
796         (FailureMissingImageHash.message):
797         (FailureMissingImage.message):
798         (FailureImageHashMismatch.message):
799         (FailureImageHashIncorrect.message):
800         (FailureReftestMismatch.message):
801         (FailureReftestMismatchDidNotOccur.message):
802         (FailureReftestNoImagesGenerated.message):
803         (FailureMissingAudio.message):
804         (FailureAudioMismatch.message):
805         * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
806         (TestFailuresTest.test_equals):
807         (TestFailuresTest):
808         (TestFailuresTest.test_crashes):
809
810 2012-03-19  Brady Eidson  <beidson@apple.com>
811
812         <rdar://problem/10917120> and https://bugs.webkit.org/show_bug.cgi?id=81066
813         Crash in 3rd party WebKit apps under XHR/Cache code
814
815         Reviewed by Antti Koivisto.
816
817         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
818         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.html: Added.
819         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm: Added.
820         (-[MemoryCachePruneTestResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
821         (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
822         (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
823         (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
824         (TestWebKitAPI):
825         (TestWebKitAPI::TEST):
826
827 2012-03-19  Brady Eidson  <beidson@apple.com>
828
829         <rdar://problem/10848575> and https://bugs.webkit.org/show_bug.cgi?id=81516
830         REGRESSION (r107435) URLs copied from WebKit apps aren't in the right pasteboard format
831
832         Reviewed by Enrica Casucci.
833
834         Bring up a context menu on a link, copy the link, then verify the pasteboard contents
835         are in the correct format.
836
837         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
838         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html: Added.
839         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm: Added.
840         (-[ContextMenuCanCopyURLDelegate webView:didFinishLoadForFrame:]):
841         (TestWebKitAPI::contextMenuCopyLink):
842         (TestWebKitAPI::TEST):
843
844 2012-03-19  Ojan Vafai  <ojan@chromium.org>
845
846         Make the selected item in the accordion a link to the flakiness dashboard
847         https://bugs.webkit.org/show_bug.cgi?id=81571
848
849         Reviewed by Dimitri Glazkov.
850
851         Also, make it so that you can select the text of the link, instead of the current behavior
852         of acting as if you had clicked on the accordion header.
853
854         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
855         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
856
857 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
858
859         NRWT runs some tests that are skipped with -i command line option
860         https://bugs.webkit.org/show_bug.cgi?id=81535
861
862         Reviewed by Ojan Vafai.
863
864         This change modifies the interaction of Skipped files and
865         test_expectations files so that entries in Skipped files (and
866         the -i command line) override *everything* in the expectations
867         file.
868
869         Specifically, a directory in a Skipped file will cause all of
870         the tests in the dir to be skipped even if individual tests in
871         the dir are listed in the test_expectations.txt.
872
873         Skipped files also override anything in an overrides files.
874
875         This seems to make more intuitive sense, since if you list
876         something in the Skips file (and even more specify it on the
877         command line) you probably want it to be universally applied.
878
879         Theoretically we could add more precedence levels and have full
880         paths in an expectations file override dirs in a Skipped file
881         (but not the command line), but I don't know yet that that level
882         of complexity is justified.
883         
884         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
885         (TestExpectations.__init__):
886         (TestExpectations._add_skipped_tests):
887         (TestExpectations._add_test):
888         (TestExpectations._add_expectations):
889         (TestExpectations._add_expectation_line):
890         (TestExpectations._already_seen_better_match):
891         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
892         (test_more_specific_override_resets_skip):
893         (SkippedTests):
894         (SkippedTests.get_exp):
895         (SkippedTests.assert_exp):
896         (SkippedTests.test_skipped_tests_work):
897         (SkippedTests.test_duplicate_skipped_test_fails_lint):
898         (SkippedTests.test_skipped_file_overrides_expectations):
899         (SkippedTests.test_skipped_dir_overrides_expectations):
900         (SkippedTests.test_skipped_file_overrides_overrides):
901         (SkippedTests.test_skipped_dir_overrides_overrides):
902
903 2012-03-19  Eric Seidel  <eric@webkit.org>
904
905         Fix WTF header include discipline in Chromium WebKit
906         https://bugs.webkit.org/show_bug.cgi?id=81281
907
908         Reviewed by James Robinson.
909
910         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
911         * Scripts/update-webkit-chromium: Made it possible to run this from a directory other than the root.
912
913 2012-03-19  Andy Chen  <andchen@rim.com>
914
915         [BlackBerry] Add new layout test for text match marker
916         https://bugs.webkit.org/show_bug.cgi?id=81531
917
918         Make the LayoutTestControllerBlackBerry::findString to test the
919         BlackBerry port implementation.
920
921         Reviewed by Rob Buis.
922
923         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
924         (LayoutTestController::findString):
925
926 2012-03-19  Ojan Vafai  <ojan@chromium.org>
927
928         Don't show WONTFIX tests in garden-o-matic
929         https://bugs.webkit.org/show_bug.cgi?id=81554
930
931         Reviewed by Dimitri Glazkov.
932
933         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
934         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
935
936 2012-03-19  Chris Fleizach  <cfleizach@apple.com>
937
938         platform/mac/accessibility/selected-rows-table.html failing on Lion Intel Debug WebKit2 testers
939         https://bugs.webkit.org/show_bug.cgi?id=81530
940
941         Reviewed by Jessie Berlin.
942
943         Add rowAtIndex to WebKitTestRunner.
944
945         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
946         (WTR::AccessibilityUIElement::rowAtIndex):
947         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
948         (AccessibilityUIElement):
949         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
950         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
951         (WTR):
952         (WTR::AccessibilityUIElement::rowAtIndex):
953
954 2012-03-19  Ojan Vafai  <ojan@chromium.org>
955
956         Change garden-o-matic All Failures tab to Expected Failures
957         https://bugs.webkit.org/show_bug.cgi?id=81540
958
959         Reviewed by Dimitri Glazkov.
960
961         Also, fix some broken unittests that had just gotten stale.
962
963         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
964         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers/rebaseline.js:
965         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
966         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
967         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
968         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
969         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
970         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
971         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
972         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
973
974 2012-03-19  Hao Zheng  <zhenghao@chromium.org>
975
976         [chromium] DRT crashes at shutdown.
977         https://bugs.webkit.org/show_bug.cgi?id=81504
978
979         Reviewed by James Robinson.
980
981         WebCompositor must be destroyed after WebView is properly destroyed,
982         or some compositor objects like CCLayerTreeHost may not be destroyed.
983         However, it is really hard to make the destruction order correct
984         explicitly in ~TestShell. So move it out to DumpRenderTree.
985
986         * DumpRenderTree/chromium/DumpRenderTree.cpp:
987         (main):
988         * DumpRenderTree/chromium/TestShell.cpp:
989         (TestShell::~TestShell):
990
991 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
992
993         add dpranke to webkitpy watchlist
994         https://bugs.webkit.org/show_bug.cgi?id=81433
995
996         Reviewed by Benjamin Poulain.
997
998         * Scripts/webkitpy/common/config/watchlist:
999
1000 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
1001
1002         test-webkitpy is failing on SL/Python 2.6.1
1003         https://bugs.webkit.org/show_bug.cgi?id=81533
1004
1005         Reviewed by Ojan Vafai.
1006
1007         It appears that itertools.combinations() is buggy in 2.6.1; this
1008         backports the implementation from 2.7.
1009
1010         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
1011         (TestConfigurationConverter.collapse_macros):
1012         (TestConfigurationConverter):
1013         (TestConfigurationConverter.combinations):
1014
1015 2012-03-19  David Michael Barr  <davidbarr@google.com>
1016
1017         Optimize the cleanup sequence in the start-queue.sh script
1018         https://github.com/abarth/webkit/pull/1
1019
1020         Reviewed by Adam Barth.
1021
1022         Updating the working copy is an expensive operation
1023         for a repository the size of WebKit.
1024         Attempt to reset only to the target revision.
1025
1026         * EWSTools/start-queue.sh:
1027
1028 2012-03-19  Raphael Kubo da Costa  <kubo@profusion.mobi>
1029
1030         Adjust architecture type of the EFL build bot.
1031         https://bugs.webkit.org/show_bug.cgi?id=81452
1032
1033         Reviewed by Tony Chang.
1034
1035         * BuildSlaveSupport/build.webkit.org-config/config.json: The
1036         buildslave is a 64-bit machine, therefore describe it as being
1037         x86_64, not i386.
1038
1039 2012-03-19  Alexander Færøy  <alexander.faeroy@nokia.com>
1040
1041         [Qt] printLoadedUrls prints "Object" instead of the actual URL.
1042         https://bugs.webkit.org/show_bug.cgi?id=81514
1043
1044         Reviewed by Simon Hausmann.
1045
1046         * MiniBrowser/qt/qml/BrowserWindow.qml:
1047
1048 2012-03-19  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
1049
1050         [EFL] jhbuild: Set CMAKE_PREFIX_PATH in jhbuildrc.
1051         https://bugs.webkit.org/show_bug.cgi?id=81491
1052
1053         Reviewed by Philippe Normand.
1054
1055         For the find_path(), find_library() etc CMake calls to find the
1056         dependencies built with jhbuild, CMAKE_PREFIX_PATH must be properly
1057         set, otherwise CMake cannot know the dependencies exist and will only
1058         look in the standard directories.
1059
1060         * efl/jhbuildrc: Set the CMAKE_PREFIX_PATH environment variable with
1061         the jhbuild Root directory.
1062
1063 2012-03-19  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
1064
1065         [EFL] Add XDG env vars to jhbuildrc
1066         https://bugs.webkit.org/show_bug.cgi?id=81510
1067
1068         Needed to ensure correct glib behaviour in jhbuild environment.
1069
1070         Reviewed by Philippe Normand.
1071
1072         * efl/jhbuildrc:
1073
1074 2012-03-19  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
1075
1076         Select best target for tap gesture.
1077         https://bugs.webkit.org/show_bug.cgi?id=78801
1078
1079         Reviewed by Kenneth Rohde Christiansen.
1080
1081         Add TOUCH_ADJUSTMENT to enabled features.
1082
1083         * qmake/mkspecs/features/features.prf:
1084
1085 2012-03-19  Robert Kroeger  <rjkroege@chromium.org>
1086
1087         [chromium] synthesize wheel events for fling on main thread
1088         https://bugs.webkit.org/show_bug.cgi?id=81458
1089
1090         Added the ability to dispatch GestureFlingStart and GestureFlingCancel from EventSender.
1091
1092         Reviewed by James Robinson.
1093
1094         * DumpRenderTree/chromium/EventSender.cpp:
1095         (EventSender::EventSender):
1096         (EventSender::gestureFlingCancel):
1097         (EventSender::gestureFlingStart):
1098         * DumpRenderTree/chromium/EventSender.h:
1099         (EventSender):
1100
1101 2012-03-19  Alexander Færøy  <alexander.faeroy@nokia.com>
1102
1103         [Qt] Add command line option to set the user agent in the MiniBrowser
1104         https://bugs.webkit.org/show_bug.cgi?id=81508
1105
1106         Reviewed by Simon Hausmann.
1107
1108         * MiniBrowser/qt/BrowserWindow.cpp:
1109         (BrowserWindow::BrowserWindow):
1110         (BrowserWindow::webViewExperimental):
1111         * MiniBrowser/qt/BrowserWindow.h:
1112         (BrowserWindow):
1113         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1114         (printHelp):
1115         (MiniBrowserApplication::handleUserOptions):
1116         * MiniBrowser/qt/MiniBrowserApplication.h:
1117         (WindowOptions::WindowOptions):
1118         (WindowOptions::setUserAgent):
1119         (WindowOptions::userAgent):
1120         (WindowOptions):
1121
1122 2012-03-19  Alexander Færøy  <alexander.faeroy@nokia.com>
1123
1124         [Qt] Remove dead user agent code from the MiniBrowser.
1125
1126         Reviewed by Simon Hausmann.
1127
1128         * MiniBrowser/qt/BrowserWindow.cpp:
1129         * MiniBrowser/qt/BrowserWindow.h:
1130         (BrowserWindow):
1131         * MiniBrowser/qt/MiniBrowser.qrc:
1132         * MiniBrowser/qt/useragentlist.txt: Removed.
1133
1134 2012-03-19  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
1135
1136         jhbuild: Call jhbuild's autogen.sh via bash.
1137         https://bugs.webkit.org/show_bug.cgi?id=81485
1138
1139         Reviewed by Philippe Normand.
1140
1141         jhbuild's autogen.sh uses "/bin/bash" in the shebang line, however
1142         this is usually true only on Linux systems, and even then bash for
1143         some reason might not be available in that location. It is safer to
1144         call bash directly and pass autogen.sh to it instead.
1145
1146         * jhbuild/jhbuild-wrapper:
1147         (install_jhbuild):
1148
1149 2012-03-19  Philippe Normand  <pnormand@igalia.com>
1150
1151         [GTK] Prefix run-launcher with run-with-jhbuild
1152         https://bugs.webkit.org/show_bug.cgi?id=81503
1153
1154         Reviewed by Hajime Morita.
1155
1156         * Scripts/run-launcher:
1157
1158 2012-03-19  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
1159
1160         [EFL] Prefix run-launcher with run-with-jhbuild
1161         https://bugs.webkit.org/show_bug.cgi?id=80026
1162
1163         Reviewed by Hajime Morita.
1164
1165         * Scripts/run-launcher:
1166
1167 2012-03-18  Csaba Osztrogonác  <ossy@webkit.org>
1168
1169         [Qt] Unreviewed. Disable -Werror on x86 until proper fix.
1170         https://bugs.webkit.org/show_bug.cgi?id=81498
1171
1172         * qmake/mkspecs/features/unix/default_post.prf:
1173
1174 2012-03-17  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
1175
1176         Unreviewed; switch to using my FreeBSD.org email address, the
1177         other one is going to disappear soon.
1178
1179         * Scripts/webkitpy/common/config/committers.py:
1180         * Scripts/webkitpy/common/config/watchlist:
1181
1182 2012-03-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
1183
1184         Unreviewed; fix webkitpy unit test failures after r111116.
1185
1186         It turns out that cmd_line in the patch in bug 80025 had the right
1187         signature when it was submitted, but r109242 added a few more
1188         required parameters, and since the method (and EflDriver) did not
1189         exist at the time we ended up committing a broken method.
1190
1191         * Scripts/webkitpy/layout_tests/port/efl.py:
1192         (EflDriver.cmd_line): Add the `pixel_tests' and `per_test_args'
1193         arguments.
1194
1195 2012-03-17  Charles Wei  <charles.wei@torchmobile.com.cn>
1196
1197         [BlackBerry] Enable Web Timing for performance profiling and improvement.
1198         https://bugs.webkit.org/show_bug.cgi?id=81085
1199
1200         Reviewed by Rob Buis.
1201
1202         * Scripts/build-webkit:
1203
1204 2012-03-17  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
1205
1206         Add a dependencies installation step for EFL to buildbot master.cfg
1207         https://bugs.webkit.org/show_bug.cgi?id=81337
1208
1209         Reviewed by Gustavo Noronha Silva.
1210
1211         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1212         (InstallEflDependencies):
1213         (Factory.__init__):
1214
1215 2012-03-17  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
1216
1217         [EFL] Prefixing run-webkit-tests with run-with-jhbuild
1218         https://bugs.webkit.org/show_bug.cgi?id=80025
1219
1220         Reviewed by Gustavo Noronha Silva.
1221
1222         * Scripts/webkitpy/layout_tests/port/efl.py:
1223         (EflDriver):
1224         (EflDriver.cmd_line):
1225         (EflPort._driver_class):
1226
1227 2012-03-17  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
1228
1229         [EFL] Add and use run-with-jhbuild and update-webkitefl-libs scripts for EFL
1230         https://bugs.webkit.org/show_bug.cgi?id=79904
1231
1232         build-webkit --efl will use jhbuild for fetching and building dependencies.
1233
1234         Reviewed by Gustavo Noronha Silva.
1235
1236         * Scripts/update-webkitefl-libs: Added.
1237         * Scripts/webkitdirs.pm:
1238         (jhbuildWrapperPrefixIfNeeded):
1239         (generateBuildSystemFromCMakeProject):
1240         (buildCMakeGeneratedProject):
1241         * efl/common.py: Added.
1242         (script_path):
1243         (top_level_path):
1244         (number_of_cpus):
1245         * efl/jhbuild.modules: Added.
1246         * efl/jhbuildrc: Added.
1247         * efl/run-with-jhbuild: Added.
1248
1249 2012-03-16  Stephanie Lewis  <slewis@apple.com>
1250
1251         https://bugs.webkit.org/show_bug.cgi?id=81065
1252         <rdar://problem/10944309> CrashTracer: [USER] 111 crashes in WebProcess at WebKitTestRunnerInjectedBundle: WTR::InjectedBundle::done + 142
1253         Fix crash preventing WebKitTestRunner from working in Release.  
1254         WebKitTestRunner used ostringstream to collect output from the test.  ostringstream is incompatible with our
1255         FastMalloc overrides.  When copying strings out ostringstream a new string is allocated with FastMalloc because
1256         the allocation is inlined.  When that string is freed is uses the system malloc because that call is not inlined.
1257
1258         I removed ostringstream in favor of StringBuilder.  
1259
1260         Properly set NDEBUG on Release builds so we don't crash when when we free the strings StringBuilder created.
1261
1262         Reviewed by Geoff Garen.
1263
1264         Add DEBUG_DEFINES to set NDEBUG on release builds.
1265         * WebKitTestRunner/Configurations/Base.xcconfig:
1266         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1267
1268         Remove ostringstream member in favor of StringBuilder.
1269         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1270         (WTR::InjectedBundle::initialize):
1271         (WTR::InjectedBundle::beginTesting):
1272         (WTR::InjectedBundle::done):
1273         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1274         (WTF):
1275         (WTR::InjectedBundle::stringBuilder):
1276         (InjectedBundle):
1277
1278         Append output to StringBuilder.
1279         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1280         (WTR::hasPrefix):
1281         (WTR::dumpPath):
1282         (WTR::rangeToStr):
1283         (WTR::styleDecToStr):
1284         (WTR::frameToStr):
1285         (WTR::dumpFrameScrollPosition):
1286         (WTR::dumpFrameText):
1287         (WTR::dumpDescendantFramesText):
1288         (WTR::InjectedBundlePage::dump):
1289         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
1290         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
1291         (WTR::InjectedBundlePage::willSendRequestForFrame):
1292         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1293         (WTR::lastFileURLPathComponent):
1294         (WTR::InjectedBundlePage::willAddMessageToConsole):
1295         (WTR::InjectedBundlePage::willSetStatusbarText):
1296         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
1297         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
1298         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
1299         (WTR::InjectedBundlePage::shouldBeginEditing):
1300         (WTR::InjectedBundlePage::shouldEndEditing):
1301         (WTR::InjectedBundlePage::shouldInsertNode):
1302         (WTR::InjectedBundlePage::shouldInsertText):
1303         (WTR::InjectedBundlePage::shouldDeleteRange):
1304         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
1305         (WTR::InjectedBundlePage::shouldApplyStyle):
1306         (WTR::InjectedBundlePage::didBeginEditing):
1307         (WTR::InjectedBundlePage::didEndEditing):
1308         (WTR::InjectedBundlePage::didChange):
1309         (WTR::InjectedBundlePage::didChangeSelection):
1310         (WTR::InjectedBundlePage::supportsFullScreen):
1311         (WTR::InjectedBundlePage::enterFullScreenForElement):
1312         (WTR::InjectedBundlePage::exitFullScreenForElement):
1313         (WTR::InjectedBundlePage::beganEnterFullScreen):
1314         (WTR::InjectedBundlePage::beganExitFullScreen):
1315         (WTR::dumpBackForwardListItem):
1316         (WTR::InjectedBundlePage::dumpBackForwardList):
1317         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1318         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired):
1319         (WTR::LayoutTestController::dumpConfigurationForViewport):
1320         
1321         Convert between WTF::String and WKStringRef.
1322         * WebKitTestRunner/StringFunctions.h:
1323         (WTR::toWTFString):
1324         (WTR):
1325         * WebKitTestRunner/TestInvocation.cpp:
1326         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1327
1328 2012-03-16  Eric Seidel  <eric@webkit.org>
1329
1330         Add a land-from-url command
1331         https://bugs.webkit.org/show_bug.cgi?id=81411
1332
1333         Reviewed by Adam Barth.
1334
1335         Very basic so far.  The goal is to make it landing smarter
1336         so that users don't have to bother to parse out the ids out of the urls.
1337
1338         * Scripts/webkitpy/common/config/urls.py:
1339         (parse_bug_id):
1340         (parse_attachment_id):
1341         * Scripts/webkitpy/common/config/urls_unittest.py:
1342         (URLsTest.test_parse_bug_id):
1343         (URLsTest):
1344         (URLsTest.test_parse_attachment_id):
1345         * Scripts/webkitpy/tool/commands/download.py:
1346         (ProcessURLsMixin):
1347         (ProcessURLsMixin._fetch_list_of_patches_to_process):
1348         (LandFromURL):
1349         * Scripts/webkitpy/tool/commands/download_unittest.py:
1350         (test_land_from_bug):
1351         (test_land_from_url):
1352
1353 2012-03-16  Dave Tharp  <dtharp@codeaurora.org>
1354
1355         build-webkit launcher instructions use wrong relative path for Qt
1356         https://bugs.webkit.org/show_bug.cgi?id=81357
1357
1358         Reviewed by Eric Seidel.
1359
1360         Ensure we are at the proper directory before generating run-launcher
1361         instructions.
1362
1363         * Scripts/build-webkit:
1364
1365 2012-03-16  Brady Eidson  <beidson@apple.com>
1366
1367         <rdar://problem/11027997> and https://bugs.webkit.org/show_bug.cgi?id=81412
1368         REGRESSION (r107435) Copy a link and paste to Mail: Nothing is pasted
1369
1370         Reviewed by Geoff Garen.
1371
1372         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1373         * TestWebKitAPI/Tests/mac/WebViewCanPasteURL.mm: Added.
1374
1375 2012-03-16  Ojan Vafai  <ojan@chromium.org>
1376
1377         Mark wontfix tests in full_results.json so we can ignore them in garden-o-matic
1378         https://bugs.webkit.org/show_bug.cgi?id=81407
1379
1380         Reviewed by Adam Barth.
1381
1382         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1383         (summarize_results):
1384         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1385         (ResultSummaryTest.summarized_results):
1386         (ResultSummaryTest.test_no_svn_revision):
1387         (ResultSummaryTest.test_svn_revision):
1388         (ResultSummaryTest):
1389         (ResultSummaryTest.test_summarized_results_wontfix):
1390
1391 2012-03-16  Ojan Vafai  <ojan@chromium.org>
1392
1393         Have webkit-patch rebaseline-test update test_expectations.txt
1394         https://bugs.webkit.org/show_bug.cgi?id=81054
1395
1396         Recommit http://trac.webkit.org/changeset/110783 now that
1397         http://trac.webkit.org/changeset/111034 has landed.
1398
1399         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1400         (TestExpectations.remove_configuration_from_test):
1401         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1402         (RemoveConfigurationsTest):
1403         (RemoveConfigurationsTest.test_remove):
1404         (test_remove_line):
1405         * Scripts/webkitpy/tool/commands/rebaseline.py:
1406         (RebaselineTest._update_expectations_file):
1407         (RebaselineTest._rebaseline_test_and_update_expectations):
1408         (RebaselineTest):
1409         (RebaselineTest.execute):
1410         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1411         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
1412         (test_rebaseline_updates_expectations_file):
1413
1414 2012-03-15  Ojan Vafai  <ojan@chromium.org>
1415
1416         Specifier collapsing when writing test expectations lines gets a number of cases wrong
1417         https://bugs.webkit.org/show_bug.cgi?id=81309
1418
1419         Reviewed by Dimitri Glazkov.
1420
1421         I've run this over all the lines in the current Chromium test_expectations.txt file,
1422         so I'm relatively confident we now cover all the cases.
1423
1424         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
1425         (TestConfigurationConverter.__init__):
1426         (TestConfigurationConverter.collapse_macros):
1427         (TestConfigurationConverter.collapse_macros.collapse_individual_specifier_set):
1428         (TestConfigurationConverter):
1429         (TestConfigurationConverter.intersect_combination):
1430         (TestConfigurationConverter.symmetric_difference):
1431         (TestConfigurationConverter.to_specifiers_list):
1432         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
1433         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
1434         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
1435         (make_mock_all_test_configurations_set):
1436         (TestConfigurationConverterTest.test_symmetric_difference):
1437         (TestConfigurationConverterTest.test_to_config_set):
1438         (TestConfigurationConverterTest.test_macro_expansion):
1439         (TestConfigurationConverterTest.test_to_specifier_lists):
1440         (TestConfigurationConverterTest.test_converter_macro_collapsing):
1441         * Scripts/webkitpy/layout_tests/port/chromium.py:
1442         (ChromiumPort):
1443         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1444         (ChromiumAndroidPort.__init__):
1445         The android port uses "arm" as it's architecture, which is technically correct,
1446         but considerably complicates making collapsing work. We probably should kill
1447         the concept of architecture entirely. The benefits are not worth the code
1448         complexity.
1449
1450         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1451         (ChromiumPortTest.test_all_test_configurations):
1452         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1453         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
1454         (test_rebaseline_updates_expectations_file):
1455
1456 2012-03-16  Dinu Jacob  <dinu.jacob@nokia.com>
1457
1458         [Qt][Wk2] Assertion Failure and crash on file upload
1459         https://bugs.webkit.org/show_bug.cgi?id=80854
1460
1461         Reviewed by Simon Hausmann.
1462
1463         Added filePicker to WebView using experimental API.
1464
1465         * MiniBrowser/qt/MiniBrowser.qrc:
1466         * MiniBrowser/qt/icons/folder.png: Added.
1467         * MiniBrowser/qt/icons/titlebar.png: Added.
1468         * MiniBrowser/qt/icons/up.png: Added.
1469         * MiniBrowser/qt/qml/BrowserWindow.qml:
1470         * MiniBrowser/qt/qml/FilePicker.qml: Added.
1471
1472 2012-03-16  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1473
1474         Updating email for committer.py script.
1475
1476         * Scripts/webkitpy/common/config/committers.py:
1477
1478 2012-03-16  Robert Kroeger  <rjkroege@chromium.org>
1479
1480         [chromium] DRT: Add support for sending gesture scrolls without a begin
1481         https://bugs.webkit.org/show_bug.cgi?id=81292
1482
1483         Reviewed by Kent Tamura.
1484
1485         * DumpRenderTree/chromium/EventSender.cpp:
1486         (EventSender::EventSender):
1487         (EventSender::gestureScrollFirstPoint):
1488         * DumpRenderTree/chromium/EventSender.h:
1489         (EventSender):
1490
1491 2012-03-02  Carlos Garcia Campos  <cgarcia@igalia.com> and Sergio Villar Senin  <svillar@igalia.com>
1492
1493         [GTK] WebKitIconDatabase doesn't keep icons cached
1494         https://bugs.webkit.org/show_bug.cgi?id=56200
1495
1496         Reviewed by Martin Robinson.
1497
1498         Add support for favicons in GtkLauncher.
1499
1500         * GtkLauncher/main.c:
1501         (activateUriEntryCb):
1502         (iconLoadedCb):
1503         (createBrowser):
1504
1505 2012-03-16  Adam Barth  <abarth@webkit.org>
1506
1507         Remove sheriff-bot's last-green-revision command
1508         https://bugs.webkit.org/show_bug.cgi?id=81314
1509
1510         Reviewed by Eric Seidel.
1511
1512         This command is a cruel joke.  WebKit doesn't really ever have a
1513         last-green-revision.
1514
1515         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1516         (BuildBot._find_green_revision):
1517         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
1518         (MockBuildBot.builder_statuses):
1519         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1520         (test_find_green_revision):
1521         * Scripts/webkitpy/tool/bot/irc_command.py:
1522         (IRCCommand.execute):
1523         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1524         (SheriffIRCBotTest.test_help):
1525         * Scripts/webkitpy/tool/commands/queries.py:
1526         (PatchesToReview.execute):
1527
1528 2012-03-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1529
1530         [Qt] Make gccdepends test aware of broken icecream deps generation
1531
1532         Icecream seems to build the files without passing -o to gcc with
1533         the original destination path, which means the target name in the
1534         dependency file is wrong.
1535
1536         Also, echo something to the final file instead of just touching it,
1537         so it's not deleted on every build.
1538
1539         Reviewed by Simon Hausmann.
1540
1541         * qmake/config.tests/gccdepends/gccdepends.pro:
1542
1543 2012-03-16  Kihong Kwon  <kihong.kwon@samsung.com>
1544
1545         Support for Battery Status API
1546         https://bugs.webkit.org/show_bug.cgi?id=62698
1547
1548         Add include directory and file.
1549         http://www.w3.org/TR/battery-status/
1550
1551         Reviewed by Adam Barth.
1552
1553         * Scripts/build-webkit:
1554
1555 2012-03-16  Kishore Bolisetty  <kbolisetty@innominds.com>
1556
1557         check-webkit-style fails on LayoutTests/platform/efl/test_expectations.txt
1558         https://bugs.webkit.org/show_bug.cgi?id=81007
1559
1560         Reviewed by Adam Barth.
1561
1562         A dedidcated build slave is available for efl on build.webkit.org. 
1563         This change add's an entry for the elf port in list of available port builders.
1564         This is required because test_expectations.py when triggered, looks for a valid port object for the specified port. 
1565
1566         * Scripts/webkitpy/layout_tests/port/builders.py:
1567
1568 2012-03-16  Adam Barth  <abarth@webkit.org>
1569
1570         [webkitpy] StatusServer.next_work_item has an incorrectly named local variable
1571         https://bugs.webkit.org/show_bug.cgi?id=81302
1572
1573         Reviewed by Eric Seidel.
1574
1575         This is a trivial patch, but the variable name turned up in a grep of
1576         webkitpy and looks like copy pasta.
1577
1578         * Scripts/webkitpy/common/net/statusserver.py:
1579         (StatusServer.next_work_item):
1580
1581 2012-03-16  Andrew Lo  <anlo@rim.com>
1582
1583         [BlackBerry] Enable PAGE_VISIBILITY_API
1584         https://bugs.webkit.org/show_bug.cgi?id=81257
1585
1586         Enable Page Visibility API for BlackBerry.
1587
1588         Reviewed by Rob Buis.
1589
1590         * Scripts/build-webkit:
1591
1592 2012-03-16  Zan Dobersek  <zandobersek@gmail.com>
1593
1594         [Gtk] Add computedStyleIncludingVisitedInfo to DumpRenderTreeSupport
1595         https://bugs.webkit.org/show_bug.cgi?id=81232
1596
1597         Reviewed by Philippe Normand.
1598
1599         Use the newly-added helper method in DumpRenderTreeSupportGtk.
1600
1601         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1602         (LayoutTestController::computedStyleIncludingVisitedInfo):
1603
1604 2012-03-15  Eric Seidel  <eric@webkit.org>
1605
1606         Move parse_bug_id into config/urls in preparation for re-use elsewhere.
1607         https://bugs.webkit.org/show_bug.cgi?id=81313
1608
1609         Reviewed by Adam Barth.
1610
1611         * Scripts/webkitpy/common/checkout/changelog.py:
1612         (parse_bug_id_from_changelog):
1613         * Scripts/webkitpy/common/config/urls.py:
1614         (parse_bug_id):
1615         * Scripts/webkitpy/common/config/urls_unittest.py: Copied from Tools/Scripts/webkitpy/common/config/urls.py.
1616         (URLsTest):
1617         (URLsTest.test_parse_bug_id):
1618         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1619         (test_parse_bug_id):
1620         * Scripts/webkitpy/tool/bot/irc_command.py:
1621         (_post_error_and_check_for_bug_url):
1622         * Scripts/webkitpy/tool/bot/sheriff.py:
1623         (Sheriff.post_rollout_patch):
1624         (Sheriff.post_chromium_deps_roll):
1625
1626 2012-03-15  Adam Barth  <abarth@webkit.org>
1627
1628         The commit-queue should fast-track patches that have already passed the testing EWS bots
1629         https://bugs.webkit.org/show_bug.cgi?id=81305
1630
1631         Reviewed by Eric Seidel.
1632
1633         If a patch has already passed the testing EWS bots (currently only the
1634         chromium-ews bot), we should be able to land the patch without running
1635         the tests again.  This patch is somewhat risky in that the tests might
1636         have been broken between when the EWS bots ran and when the
1637         commit-queue is processing the patch.  If that turns out to be a
1638         problem in practice, we'll tighten up this fast-track in some way,
1639         likely by making sure that the pass status is recent.
1640
1641         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1642         (CommitQueueTaskDelegate.did_pass_testing_ews):
1643         (CommitQueueTask._did_pass_tests_recently):
1644         (CommitQueueTask.run):
1645         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1646         (MockCommitQueue.did_pass_testing_ews):
1647         (test_fast_success_case):
1648         * Scripts/webkitpy/tool/commands/queues.py:
1649         (CommitQueue.did_pass_testing_ews):
1650         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1651         (test_did_pass_testing_ews):
1652
1653 2012-03-15  Kentaro Hara  <haraken@chromium.org>
1654
1655         [PerformanceTests] run-perf-tests should output correct units
1656         https://bugs.webkit.org/show_bug.cgi?id=78303
1657
1658         Reviewed by Ryosuke Niwa.
1659
1660         Previously run-perf-tests just supported "ms" for units.
1661         Consequently, Dromaeo perf tests had been reporting runs/s as "ms".
1662         This patch fixes run-perf-tests so that they can support custom units.
1663         The default unit is "ms".
1664
1665         The test result looks like this:
1666
1667         $ ./Tools/Scripts/run-perf-tests Dromaeo/dom-attr.html
1668         RESULT Dromaeo: dom-attr= 6465.9525483 runs/s
1669         median= 0.0 runs/s, stdev= 24.2983433436 runs/s, min= 6435.87649402 runs/s, max= 6515.63693392 runs/s
1670
1671         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1672         (PerfTestsRunner._process_parser_test_result):
1673
1674 2012-03-15  Brent Fulgham  <bfulgham@webkit.org>
1675
1676         [WinCairo] Unreviewed build change after wtf path changes.
1677
1678         * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Updated include
1679         directories to look at the private header directory to find 'wtf'.
1680
1681 2012-03-15  Kent Tamura  <tkent@chromium.org>
1682
1683         REGRESSION(r110595): webkit-patch suggest-reviewers doesn't work
1684         https://bugs.webkit.org/show_bug.cgi?id=81293
1685
1686         Reviewed by Adam Barth.
1687
1688         r110595 introduced new format of the author field of ChangeLog entry:
1689         "Adam Barth  <abarth@webkit.org> && Benjamin Poulain  <bpoulain@apple.com>"
1690         Updte chanelog.py to support it.
1691
1692         * Scripts/webkitpy/common/checkout/changelog.py:
1693         (ChangeLogEntry._split_contributor_names):
1694         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1695         (test_parse_authors):
1696
1697 2012-03-15  Lynn Neir  <lynn.neir@skype.net>
1698
1699         Implement LayoutTestController::setValueForUser on Windows https://bugs.webkit.org/show_bug.cgi?id=55834
1700
1701         Implemented setValueForUser in both DumpRenderTree and WebKitTestRunner.
1702
1703         Reviewed by Jessie Berlin.
1704
1705         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1706         (LayoutTestController::setValueForUser):
1707         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1708         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1709         (WTR::LayoutTestController::setValueForUser):
1710         (WTR):
1711         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1712         (LayoutTestController):
1713
1714 2012-03-15  Adam Barth  <abarth@webkit.org>
1715
1716         Update the start-queue.sh script to match what we're using on the bots
1717         https://bugs.webkit.org/show_bug.cgi?id=81277
1718
1719         Reviewed by Eric Seidel.
1720
1721         Over time we've added more magic git commands to clean up the local repo after
1722         it has been borked in various ways. The idea behind this sequence is to clear
1723         out any changes in the working copy and then to rebuild the master branch from
1724         origin/master.
1725
1726         This patch also removes the watchdog timer that we've stopped using on the
1727         bots.
1728
1729         This patch was reviewed on <https://github.com/eseidel/webkit/pull/1>.
1730         Note: Eric and I are experimenting with GitHub to see if it might be
1731         useful for WebKit.  If you have thoughts on this topic, please feel
1732         free to grab Eric or me on #webkit to chat.  I assume that he and I are
1733         the only ones who care about this file so using this alternative
1734         process for this patch shouldn't cause any trouble.
1735
1736         * EWSTools/start-queue.sh:
1737
1738 2012-03-15  Adam Barth  <abarth@webkit.org>
1739
1740         The commit-queue can hang when the test_expectations.txt style check fails during commit
1741         https://bugs.webkit.org/show_bug.cgi?id=81251
1742
1743         Reviewed by Eric Seidel.
1744
1745         We forgot to check the --non-interactive flag, so we end up prompting
1746         the "user" who doesn't exist on the bot.  We might consider teaching
1747         the User class about non-interactive if we have this sort of bug again.
1748
1749         * Scripts/webkitpy/tool/steps/commit.py:
1750         (Commit.options):
1751         (Commit._check_test_expectations):
1752         (Commit.run):
1753         * Scripts/webkitpy/tool/steps/commit_unittest.py:
1754         (CommitTest.test_check_test_expectations):
1755
1756 2012-03-15  Jessie Berlin  <jberlin@apple.com>
1757
1758         fast/dom/Window/window-properties.html and fast/dom/prototype-inheritance-2.html failing on
1759         Mac WK2 because WebAudio is not enabled
1760         https://bugs.webkit.org/show_bug.cgi?id=81259
1761
1762         Reviewed by Dan Bernstein.
1763
1764         Enable WebAudio so that it appears in the window object in the tests.
1765         The webaudio tests are all still skipped in the Mac Skipped list.
1766
1767         * WebKitTestRunner/TestController.cpp:
1768         (WTR::TestController::resetStateToConsistentValues):
1769
1770 2012-03-15  David Levin  <levin@chromium.org>
1771
1772         Various autoresize fixes.
1773         https://bugs.webkit.org/show_bug.cgi?id=81199
1774
1775         Reviewed by Darin Fisher.
1776
1777         * DumpRenderTree/chromium/LayoutTestController.cpp:
1778         (LayoutTestController::reset): Stop using the deprecated api that was removed.
1779
1780 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1781
1782         [GTK] Actually use --release and --debug command line options in run-gtk-test
1783         https://bugs.webkit.org/show_bug.cgi?id=81234
1784
1785         Reviewed by Philippe Normand.
1786
1787         Actually handle --release and --debug command line options to
1788         create the build directory, falling back to current hack to detect
1789         whether it's a Release or Debug build when both options are missed.
1790
1791         * Scripts/run-gtk-tests:
1792         (TestRunner.__init__): Receive options too.
1793         (TestRunner._get_top_level_directory): Helper function to get the
1794         top level directory.
1795         (TestRunner._get_build_directory): Helper function to get the
1796         build directory depending on --release/--debug command line
1797         options or gessing it if both options are missing.
1798         (TestRunner._ensure_accessibility_daemon_is_running): Use
1799         self-options now.
1800         (TestRunner.run): Ditto.
1801         (TestRunner.run.run_tests): Pass options to the constructor
1802         instead of run().
1803
1804 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1805
1806         [GTK] Run unit tests with --verbose in the bots
1807         https://bugs.webkit.org/show_bug.cgi?id=81230
1808
1809         Reviewed by Martin Robinson.
1810
1811         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1812         (RunGtkAPITests): Add --verbose to run-gtk-test command.
1813
1814 2012-03-15  Kevin Ollivier  <kevino@theolliviers.com>
1815
1816         Move wx port to using export macros
1817         https://bugs.webkit.org/show_bug.cgi?id=77279
1818
1819         Reviewed by Hajime Morita.
1820
1821         * waf/build/settings.py:
1822         (common_configure):
1823
1824 2012-03-15  Philippe Normand  <pnormand@igalia.com>
1825
1826         Unreviewed, GTK build fix attempt after r110845.
1827
1828         * Scripts/run-gtk-tests: Added --release and --debug options.
1829
1830 2012-03-15  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
1831
1832         Parametrize run-with-jhbuild and update-webkitgtk-libs with platform --gtk/--efl
1833         https://bugs.webkit.org/show_bug.cgi?id=79673
1834
1835         Preparatory work for bringing jhbuild enabled build to EFL port.
1836
1837         Reviewed by Philippe Normand.
1838
1839         * Scripts/update-webkit-libs-jhbuild: Copied from Tools/Scripts/update-webkitgtk-libs.
1840         * Scripts/update-webkitgtk-libs:
1841         * gtk/run-with-jhbuild:
1842         * jhbuild/jhbuild-wrapper: Copied from Tools/gtk/run-with-jhbuild.
1843         (top_level_path):
1844         (jhbuild_installed):
1845         (jhbuild_cloned):
1846         (jhbuild_at_expected_revision):
1847         (update_jhbuild):
1848         (clone_jhbuild):
1849         (install_jhbuild):
1850         (update_webkit_libs_jhbuild):
1851         (determine_platform):
1852         (ensure_jhbuild):
1853
1854 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1855
1856         [GTK] Add command line options to run-gtk-tests script
1857         https://bugs.webkit.org/show_bug.cgi?id=81218
1858
1859         Reviewed by Philippe Normand.
1860
1861         Following command line options have been added:
1862
1863         -v, --verbose: to run gtester with --verbose. That would be used
1864         by the bots to make it easier to know which test case it failing.
1865
1866         --display: to use a different display for Xvfb
1867
1868         It's also possible to pass one or more tests as arguments.
1869
1870         * Scripts/run-gtk-tests:
1871         (TestRunner.__init__): Receive command line arguments.
1872         (TestRunner._get_tests): Get all the tests or the ones passed by
1873         command line arguments.
1874         (TestRunner._ensure_accessibility_daemon_is_running): Use display
1875         command line argument.
1876         (TestRunner.run): Pas command line options.
1877         (TestRunner.run.run_tests): Pass command line arguments.
1878
1879 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1880
1881         [GTK] WebKit2APITests/TestPrinting timeout in the bots
1882         https://bugs.webkit.org/show_bug.cgi?id=81211
1883
1884         Reviewed by Philippe Normand.
1885
1886         Add gtk+ patch to fix timeout in the bots. A similar patch has
1887         already landed in updatream gtk+, see
1888         http://git.gnome.org/browse/gtk+/commit/?id=5ebfad5d091f4c9d9c6e60364fad4c60842f027f
1889
1890         * gtk/jhbuild.modules:
1891         * gtk/patches/gtk+-3.0.12-gtkprinter.patch: Added.
1892
1893 2012-03-14  Gustavo Noronha Silva  <gns@gnome.org>
1894
1895         sheriffbot should also be addressable with a comma in addition to colon
1896         https://bugs.webkit.org/show_bug.cgi?id=81101
1897
1898         Reviewed by Adam Barth.
1899
1900         * Scripts/webkitpy/common/net/irc/ircbot.py:
1901         (IRCBot.on_pubmsg):
1902
1903 2012-03-15  Alexander Færøy  <alexander.faeroy@nokia.com>
1904
1905         [Qt] MiniBrowser scroll indicators should not scroll out of view
1906         https://bugs.webkit.org/show_bug.cgi?id=81131
1907
1908         Reviewed by Kenneth Rohde Christiansen.
1909
1910         * MiniBrowser/qt/qml/ScrollIndicator.qml:
1911
1912 2012-03-14  Chris Fleizach  <cfleizach@apple.com>
1913
1914         AX: ARIA tables need to support selected rows attribute/select rows changed notification
1915         https://bugs.webkit.org/show_bug.cgi?id=79821
1916
1917         Reviewed by Beth Dakin.
1918
1919         * DumpRenderTree/AccessibilityUIElement.cpp:
1920         (rowAtIndexCallback):
1921         (AccessibilityUIElement::getJSClass):
1922         * DumpRenderTree/AccessibilityUIElement.h:
1923         (AccessibilityUIElement):
1924         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1925         (AccessibilityUIElement::rowAtIndex):
1926         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1927         (AccessibilityUIElement::rowAtIndex):
1928         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1929         (AccessibilityUIElement::rowAtIndex):
1930         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1931         (AccessibilityUIElement::rowAtIndex):
1932
1933 2012-03-14  Tim Horton  <timothy_horton@apple.com>
1934
1935         NRWT should respect --additional-platform-directory's Skipped list
1936         https://bugs.webkit.org/show_bug.cgi?id=81172
1937
1938         Reviewed by Timothy Hatcher.
1939
1940         Respect the Skipped file inside all paths included via the --additional-platform-directory option. Test results
1941         from said path are already used, but the Skipped file is ignored.
1942
1943         * Scripts/webkitpy/layout_tests/port/webkit.py:
1944         (WebKitPort._skipped_file_search_paths):
1945         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1946         (test_skipped_file_search_paths):
1947
1948 2012-03-14  Ojan Vafai  <ojan@chromium.org>
1949
1950         Unreviewed, rolling out r110783.
1951         http://trac.webkit.org/changeset/110783
1952         https://bugs.webkit.org/show_bug.cgi?id=81054
1953
1954         Caused existing test expectation lines to expand to one for
1955         each test configuration.
1956
1957         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1958         (TestExpectations.has_warnings):
1959         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1960         (test_macro_overrides):
1961         * Scripts/webkitpy/tool/commands/rebaseline.py:
1962         (RebaselineTest._save_baseline):
1963         (RebaselineTest._rebaseline_test):
1964         (RebaselineTest.execute):
1965         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1966         (TestRebaseline.test_tests_to_update):
1967
1968 2012-03-13  Jon Lee  <jonlee@apple.com>
1969
1970         Separate NOTIFICATIONS and LEGACY_NOTIFICATIONS
1971         https://bugs.webkit.org/show_bug.cgi?id=80922
1972         <rdar://problem/11035082>
1973
1974         Reviewed by Jian Li.
1975
1976         You can include either NOTIFICATIONS or LEGACY_NOTIFICATIONS and have a complete API.
1977         LEGACY_NOTIFICATIONS should cover all of the previous functionality, and NOTIFICATIONS will cover the
1978         new API. Therefore, APIs that are common between the two will have:
1979         #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
1980
1981         This patch initially sets both to be exactly the same. As other bugs with patches begin to migrate to
1982         the new API, the defines will begin to split. This allows ports to decide which set of APIs to include.
1983
1984         Update everything to be #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
1985         * DumpRenderTree/chromium/LayoutTestController.cpp:
1986         (LayoutTestController::grantDesktopNotificationPermission):
1987         (LayoutTestController::simulateDesktopNotificationClick):
1988         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1989         * DumpRenderTree/chromium/TestShell.cpp:
1990         (TestShell::TestShell):
1991         (TestShell::resetTestController):
1992         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1993         (DRTDesktopNotificationPresenter::checkNotificationPermission):
1994
1995 2012-03-13  Ojan Vafai  <ojan@chromium.org>
1996
1997         Have webkit-patch rebaseline-test update test_expectations.txt
1998         https://bugs.webkit.org/show_bug.cgi?id=81054
1999
2000         Reviewed by Dirk Pranke.
2001
2002         This will allow us to use the All Failures tab in garden-o-matic
2003         to rebaseline tests without making test_expectations.txt stale.
2004
2005         It's conservative and only removes lines if the test is
2006         not flaky and fails in a way the rebaseline would fix (e.g.
2007         CRASH/TIMEOUT will not be touched).
2008
2009         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2010         (TestExpectations.remove_configuration_from_test):
2011         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2012         (RemoveConfigurationsTest):
2013         (RemoveConfigurationsTest.test_remove):
2014         (test_remove_line):
2015         * Scripts/webkitpy/tool/commands/rebaseline.py:
2016         (RebaselineTest._is_supported_port):
2017         (RebaselineTest):
2018         (RebaselineTest._update_expectations_file):
2019         (RebaselineTest._rebaseline_test_and_update_expectations):
2020         (RebaselineTest.execute):
2021         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2022         (TestRebaseline.test_rebaseline_updates_expectations_file):
2023
2024 2012-03-14  Jessie Berlin  <jberlin@apple.com>
2025
2026         Crash in WKTR under addChromeInputField due to using 0 as a key in a HashMap
2027         https://bugs.webkit.org/show_bug.cgi?id=81167
2028
2029         Reviewed by Sam Weinig.
2030
2031         Do not use 0 as a key in a HashMap.
2032
2033         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2034         cacheLayoutTestControllerCallback uses the enum as keys for the callback map.
2035
2036 2012-03-14  Ojan Vafai  <ojan@chromium.org>
2037
2038         Add the chromium lion bot to garden-o-matic and remove
2039         the platform_move_to in builders.py since the Chromium Lion
2040         port is now a normal port.
2041
2042         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2043         * Scripts/webkitpy/layout_tests/port/builders.py:
2044
2045 2012-03-14  Dirk Pranke  <dpranke@chromium.org>
2046
2047         Fix regression/crash introduced in r110724 - bad type passed from skipped_tests() by default.
2048
2049         Unreviewed, build fix.
2050
2051         * Scripts/webkitpy/layout_tests/port/base.py:
2052         (Port.skipped_tests):
2053
2054 2012-03-14  Dirk Pranke  <dpranke@chromium.org>
2055
2056         Please add a way to manually skip some tests in NRWT
2057         https://bugs.webkit.org/show_bug.cgi?id=81019
2058
2059         Reviewed by Ojan Vafai.
2060
2061         This patch implements the -i / --ignore-tests flag from ORWT
2062         and refactors the test_expectations.py code slightly to handle
2063         it.
2064
2065         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2066         (Manager.parse_expectations):
2067         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2068         (TestExpectations.__init__):
2069         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2070         (test_add_skipped_tests):
2071         (test_add_skipped_tests_duplicate):
2072         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2073         (parse_args):
2074         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2075         (MainTest.test_ignore_tests):
2076         (MainTest.test_ignore_tests.assert_ignored):
2077
2078 2012-03-14  Dirk Pranke  <dpranke@chromium.org>
2079
2080         nrwt: run with no args on lion, is putting baselines in platform/mac-lion, not platform/mac
2081         https://bugs.webkit.org/show_bug.cgi?id=81028
2082
2083         Reviewed by Ojan Vafai.
2084
2085         The mac port had incorrect lookups for 'mac-lion' and
2086         'mac-future' in some places. This patch fixes that and adds a
2087         bunch of tests.
2088
2089         * Scripts/webkitpy/layout_tests/port/mac.py:
2090         (MacPort.baseline_path):
2091         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2092         (MacTest.assert_skipped_file_search_paths):
2093         (MacTest.test_skipped_file_search_paths):
2094         (_assert_search_path):
2095         (test_baseline_search_path):
2096         * Scripts/webkitpy/layout_tests/port/webkit.py:
2097         (WebKitPort._skipped_file_search_paths):
2098
2099 2012-03-13  Jer Noble  <jer.noble@apple.com>
2100
2101         Lion Intel Debug WebKit2 Tests crashing under [WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]
2102         https://bugs.webkit.org/show_bug.cgi?id=81056
2103
2104         Reviewed by Jessie Berlin.
2105
2106         Intercept beganEnterFullScreen and beganExitFullScreen and turn them into no-ops (plus logging).
2107
2108         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2109         (WTR::InjectedBundlePage::InjectedBundlePage):
2110         (WTR::InjectedBundlePage::beganEnterFullScreen):
2111         (WTR::InjectedBundlePage::beganExitFullScreen):
2112
2113 2012-03-14  Alexander Færøy  <alexander.faeroy@nokia.com>
2114
2115         The width and height of the scroll indicators in the MiniBrowser does
2116         not consider the offset margins.
2117         https://bugs.webkit.org/show_bug.cgi?id=81112
2118
2119         Reviewed by Kenneth Rohde Christiansen.
2120
2121         This patch fixes the issue by withdrawing two times the anchor
2122         margins.
2123
2124         * MiniBrowser/qt/qml/ScrollIndicator.qml:
2125
2126 2012-03-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2127
2128         [EFL] Implement LayoutTestController::clearBackForwardList
2129         https://bugs.webkit.org/show_bug.cgi?id=80142
2130
2131         Adding missing implementation clearBackForwardList to EFL's
2132         LayoutTestController. This implementation allows us to unskip 
2133         tests connected with history.
2134
2135         Reviewed by Antonio Gomes.
2136
2137         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2138         (LayoutTestController::clearBackForwardList): Implemented.
2139
2140 2012-03-13  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2141
2142         [EFL][DRT] Expose window.internals object
2143         https://bugs.webkit.org/show_bug.cgi?id=79900
2144
2145         Exposes window.internals for EFL's DRT. Makes possible to
2146         remove some tests from the skip list.
2147
2148         Reviewed by Antonio Gomes.
2149
2150         * DumpRenderTree/efl/CMakeLists.txt:
2151         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2152         (DumpRenderTreeChrome::onWindowObjectCleared):
2153
2154 2012-03-13  Adam Barth  <abarth@webkit.org> && Benjamin Poulain  <bpoulain@apple.com>
2155
2156         Always enable ENABLE(CLIENT_BASED_GEOLOCATION)
2157         https://bugs.webkit.org/show_bug.cgi?id=78853
2158
2159         Reviewed by Adam Barth.
2160
2161         * Scripts/build-webkit:
2162         * qmake/mkspecs/features/features.prf:
2163
2164 2012-03-12  Antonio Gomes  <agomes@rim.com>
2165
2166         Convert nodesFromRect tests to use Internals interface
2167         https://bugs.webkit.org/show_bug.cgi?id=80886
2168
2169         Reviewed by Ryosuke Niwa.
2170
2171         This clean up allows to remove port specific bits of each
2172         DRT implementation that supports testing Document::nodesFromRect,
2173         in favor of making use of the 'Internals' interface to test it.
2174
2175         This makes its code conveniently more expansible and cleaner.
2176
2177         Also removed stubs from Win and EFL DRTs.
2178
2179         * DumpRenderTree/LayoutTestController.cpp:
2180         (LayoutTestController::staticFunctions):
2181         * DumpRenderTree/LayoutTestController.h:
2182         (LayoutTestController):
2183         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2184         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2185         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2186         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2187         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2188         (LayoutTestController):
2189         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2190
2191 2012-03-13  Ojan Vafai  <ojan@chromium.org>
2192
2193         Rebaselining for a new port doesn't work right with multiple fallback ports
2194         https://bugs.webkit.org/show_bug.cgi?id=80932
2195
2196         Reviewed by Adam Barth.
2197
2198         Since chromium-leopard also falls back to mac-leopard, we need to
2199         copy the existing result for both chromium-leopard and chromium-snowleopard
2200         before doing lion rebaselines.
2201
2202         * Scripts/webkitpy/layout_tests/port/builders.py:
2203         (fallback_port_names_for_new_port):
2204         * Scripts/webkitpy/tool/commands/rebaseline.py:
2205         (RebaselineTest):
2206         (RebaselineTest._copy_existing_baseline):
2207         (RebaselineTest._rebaseline_test):
2208         (RebaselineTest.execute):
2209         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2210         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2211         (GardeningHTTPRequestHandler.rebaseline):
2212         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2213         (GardeningServerTest.test_rebaseline_new_port):
2214
2215 2012-03-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2216
2217         [Qt] Tweak minibrowser UI
2218
2219         Add some margins to the scroll indicators, and set a dark background
2220         color so you see the page dimensions.
2221
2222         Reviewed by Antonio Gomes.
2223
2224         * MiniBrowser/qt/qml/BrowserWindow.qml:
2225         * MiniBrowser/qt/qml/ScrollIndicator.qml:
2226
2227 2012-03-13  ChangSeok Oh  <shivamidow@gmail.com>
2228
2229         [EFL] [DRT] Implement scheduleAsynchronousKeyDown.
2230         https://bugs.webkit.org/show_bug.cgi?id=79601
2231
2232         Reviewed by Gustavo Noronha Silva.
2233
2234         Extracted shareable code from keyDownCallback and then added createKeyEventInfo.
2235         createKeyEventInfo creates a new structure KeyEventInfo that has keyName and modifiers
2236         and is taken over to sendKeyDown.
2237         Added sendKeyDown and sendAsynchronousKeyDown to evaluate keyDown event directly
2238         and asynchronously. Eventually, sendAsynchronousKeyDown calls sendKeyDown.
2239
2240         * DumpRenderTree/efl/EventSender.cpp:
2241         (KeyEventInfo::KeyEventInfo):
2242         (KeyEventInfo):
2243         (createKeyEventInfo):
2244         (sendKeyDown):
2245         (keyDownCallback):
2246         (sendAsynchronousKeyDown):
2247         (scheduleAsynchronousKeyDownCallback):
2248
2249 2012-03-12  Ojan Vafai  <ojan@chromium.org>
2250
2251         webkit-patch optimize-baselines sometimes creates a mac-future result
2252         https://bugs.webkit.org/show_bug.cgi?id=80717
2253
2254         Reviewed by Adam Barth.
2255
2256         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
2257         (_baseline_search_hypergraph):
2258         (BaselineOptimizer._find_optimal_result_placement):
2259         (BaselineOptimizer._filter_virtual_ports):
2260         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
2261         (BaselineOptimizerTest.test_no_add_mac_future):
2262
2263 2012-03-12  Jessie Berlin  <jberlin@apple.com>
2264
2265         More Windows build fixing.
2266
2267         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2268
2269 2012-03-12  Jessie Berlin  <jberlin@apple.com>
2270
2271         More Windows build fixing.
2272
2273         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2274         * DumpRenderTree/win/EditingDelegate.cpp:
2275         * DumpRenderTree/win/EventSender.cpp:
2276         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2277         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2278         * DumpRenderTree/win/UIDelegate.cpp:
2279
2280 2012-03-12  Dirk Pranke  <dpranke@chromium.org>
2281
2282         remove the 'gpu' group from the flakiness dashboard
2283         https://bugs.webkit.org/show_bug.cgi?id=80353
2284
2285         Reviewed by Adam Barth.
2286
2287         Since those bots are obsolete, we don't need this any more.
2288
2289         * TestResultServer/static-dashboards/builders.js:
2290         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2291         (testPlatformAndBuildType):
2292         (testHtmlForTestTypeSwitcherGroup):
2293
2294 2012-03-12  Dirk Pranke  <dpranke@chromium.org>
2295
2296         remove graphics_type from webkitpy.layout_tests.models.test_configuration
2297         https://bugs.webkit.org/show_bug.cgi?id=80643
2298
2299         Reviewed by Ojan Vafai.
2300
2301         Now that the chromium-gpu ports are gone, there's no need for
2302         the graphics_type CPU/GPU distinction. Most of this change is
2303         just updating tests accordingly.
2304
2305         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
2306         (TestExpectationEditorTests):
2307         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
2308         (TestConfiguration.__init__):
2309         (TestConfiguration.category_order):
2310         (TestConfiguration.__str__):
2311         (TestConfiguration.__repr__):
2312         (TestConfiguration.__hash__):
2313         (TestConfigurationConverter.to_specifiers_list):
2314         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
2315         (make_mock_all_test_configurations_set):
2316         (TestConfigurationTest.test_items):
2317         (TestConfigurationTest.test_keys):
2318         (TestConfigurationTest.test_str):
2319         (TestConfigurationTest.test_repr):
2320         (TestConfigurationTest.test_hash):
2321         (TestConfigurationTest.test_hash.query_unknown_key):
2322         (TestConfigurationTest.test_eq):
2323         (TestConfigurationTest.test_values):
2324         (SpecifierSorterTest.test_specifier_priority):
2325         (SpecifierSorterTest.test_sort_specifiers):
2326         (TestConfigurationConverterTest.test_to_config_set):
2327         (TestConfigurationConverterTest.test_macro_expansion):
2328         (TestConfigurationConverterTest.test_to_specifier_lists):
2329         (TestConfigurationConverterTest.test_converter_macro_collapsing):
2330         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2331         (test_error_on_different_build_type):
2332         (TestExpectationSerializerTests.test_parsed_to_string):
2333         (TestExpectationSerializerTests.test_reconstitute_only_these):
2334         * Scripts/webkitpy/layout_tests/port/apple.py:
2335         (ApplePort._generate_all_test_configurations):
2336         * Scripts/webkitpy/layout_tests/port/base.py:
2337         (Port.__init__):
2338         (Port.name):
2339         (Port.version):
2340         (Port.test_configuration):
2341         * Scripts/webkitpy/layout_tests/port/builders.py:
2342         * Scripts/webkitpy/layout_tests/port/chromium.py:
2343         (ChromiumPort):
2344         (ChromiumPort._generate_all_test_configurations):
2345         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2346         (ChromiumLinuxPort.__init__):
2347         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2348         (ChromiumLinuxPortTest.test_check_illegal_port_names):
2349         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2350         (ChromiumMacPortTest.test_baseline_path):
2351         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2352         (ChromiumPortTest.test_all_test_configurations):
2353         * Scripts/webkitpy/layout_tests/port/efl.py:
2354         (EflPort._generate_all_test_configurations):
2355         * Scripts/webkitpy/layout_tests/port/gtk.py:
2356         (GtkPort._generate_all_test_configurations):
2357         * Scripts/webkitpy/layout_tests/port/qt.py:
2358         (QtPort._generate_all_test_configurations):
2359         * Scripts/webkitpy/layout_tests/port/test.py:
2360         (TestPort.all_test_configurations):
2361         (TestPort._all_build_types):
2362         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2363         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2364         (BuildCoverageExtrapolatorTest.test_extrapolate):
2365         (GardeningExpectationsUpdaterTest.test_unknown_failure_type):
2366         (GardeningExpectationsUpdaterTest.test_add_new_expectation):
2367         (GardeningExpectationsUpdaterTest.test_replace_old_expectation):
2368         (GardeningExpectationsUpdaterTest.test_pass_expectation):
2369         (GardeningExpectationsUpdaterTest.test_supplement_old_expectation):
2370         (GardeningExpectationsUpdaterTest.test_spurious_updates):
2371
2372 2012-03-12  Dirk Pranke  <dpranke@chromium.org>
2373
2374         _runtime_feature_list isn't supported on Apple Mac DRT
2375         https://bugs.webkit.org/show_bug.cgi?id=80906
2376
2377         Reviewed by Eric Seidel.
2378
2379         It looks like this feature is actually only supported on the Win
2380         DRT port, so this patch reworks the code to make that clearer
2381         and reduce unnecessary overrides.
2382
2383         * Scripts/webkitpy/layout_tests/port/efl.py:
2384         (EflPort._path_to_webcore_library):
2385         * Scripts/webkitpy/layout_tests/port/gtk.py:
2386         (GtkPort._path_to_webcore_library):
2387         * Scripts/webkitpy/layout_tests/port/qt.py:
2388         (QtPort._skipped_file_search_paths):
2389         * Scripts/webkitpy/layout_tests/port/webkit.py:
2390         (WebKitPort._runtime_feature_list):
2391         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2392         (TestWebKitPort.__init__):
2393         (TestWebKitPort.all_test_configurations):
2394         (test_skipped_directories_for_features):
2395         * Scripts/webkitpy/layout_tests/port/win.py:
2396         (WinPort):
2397         (WinPort._runtime_feature_list):
2398         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2399         (WinPortTest.test_operating_system):
2400         (WinPortTest):
2401         (WinPortTest.test_runtime_feature_list):
2402
2403 2012-03-12  Peter Beverloo  <peter@chromium.org>
2404
2405         [Chromium] Temporary build-fix for the Android bot
2406         https://bugs.webkit.org/show_bug.cgi?id=80862
2407
2408         Reviewed by Adam Barth.
2409
2410         Manually set the environmental variables required to compile source
2411         files through the Android NDK instead of relying on the envsetup.sh
2412         script. A proper fix will be landed to Chromium ASAP, and following
2413         a Chromium roll into WebKit this code will be removed.
2414
2415         * Scripts/webkitdirs.pm:
2416         (buildChromiumMakefile):
2417
2418 2012-03-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2419
2420         [Qt] Use right construct to detect config_test_gccdepends
2421
2422         Reviewed by Andreas Kling.
2423
2424         * qmake/mkspecs/features/default_pre.prf:
2425
2426 2012-03-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2427
2428         [Qt] Expose location of WebKit's bin and imports dir through module file
2429
2430         Reviewed by Andreas Kling.
2431
2432         * qmake/qt_webkit.pri:
2433
2434 2012-03-12  Andras Becsi  <andras.becsi@nokia.com>
2435
2436         [Qt][WK2] Add support for rudimentary scroll indicators in MiniBrowser
2437         https://bugs.webkit.org/show_bug.cgi?id=80832
2438
2439         Reviewed by Tor Arne Vestbø.
2440
2441         Add a basic scroll indicator component to MiniBrowser so that it
2442         behaves similar to the ScrollDecorator QML component.
2443
2444         * MiniBrowser/qt/MiniBrowser.qrc:
2445         * MiniBrowser/qt/qml/BrowserWindow.qml:
2446         * MiniBrowser/qt/qml/ScrollIndicator.qml: Added.
2447
2448 2012-03-12  C Anthony Risinger  <anthony@xtfx.me>
2449
2450         [GTK] r110296 included an extra $ in @$(AM_V_GEN)
2451         https://bugs.webkit.org/show_bug.cgi?id=80809
2452
2453         Reviewed by Philippe Normand.
2454
2455         * GNUmakefile.am: Add `$` to @(AM_V_GEN), else /bin/sh syntax error
2456
2457 2012-03-12  Ming Xie  <mxie@rim.com>
2458
2459         [BlackBerry] build-webkit doesn't recognize "--cmakearg" for the BlackBerry port
2460         https://bugs.webkit.org/show_bug.cgi?id=80812
2461
2462         Reviewed by Rob Buis.
2463
2464         * Scripts/build-webkit: Add $cmakeArgs to buildCMakeProjectOrExit()
2465         * Scripts/webkitdirs.pm:
2466         (blackberryCMakeArguments): Remove "PUBLIC_BUILD=0" define
2467
2468
2469 2012-03-12  Simon Hausmann  <simon.hausmann@nokia.com>
2470
2471         [Qt] Fix build with newer Qt 5.
2472
2473         Reviewed by Tor Arne Vestbø.
2474
2475         Newer Qt 5 renames QDeclarativeFoo to QQmlFoo and provides backwards compatible
2476         renames, which however do trigger a #warning. Until we _require_ a newer Qt 5
2477         we should disable -Werror.
2478
2479         Also load(moc) for the availability of QMAKE_MOC in various derived sources. The
2480         implicit load was removed recently.
2481
2482         * qmake/mkspecs/features/default_pre.prf:
2483         * qmake/mkspecs/features/unix/default_post.prf:
2484
2485 2012-03-11  Maciej Stachowiak  <mjs@apple.com>
2486
2487         Add --instruments option to sunspider to profile with Instruments
2488         https://bugs.webkit.org/show_bug.cgi?id=80783
2489
2490         Reviewed by Filip Pizlo.
2491
2492         * Scripts/run-sunspider:
2493
2494 2012-03-11  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
2495
2496         [Qt] [WK2] Support threaded renderer in WK2
2497         https://bugs.webkit.org/show_bug.cgi?id=76661
2498
2499         Remove disabling of threaded rendering.
2500
2501         Reviewed by Noam Rosenthal.
2502
2503         * MiniBrowser/qt/main.cpp:
2504         (main):
2505
2506 2012-03-09  Zan Dobersek  <zandobersek@gmail.com>
2507
2508         [WK2] run-perf-tests should be able to run with WTR
2509         https://bugs.webkit.org/show_bug.cgi?id=80042
2510
2511         Reviewed by Martin Robinson.
2512
2513         Add an option to PerfTestRunner to use WebKitTestRunner instead of
2514         DumpRenderTree and add the '--no-timeout' flag to WebKitTestRunner
2515         to avoid timing out when running performance tests.
2516
2517         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2518         (PerfTestsRunner._parse_args):
2519         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2520         (WTR::InjectedBundle::InjectedBundle): Initialize m_useWaitToDumpWatchdogTimer
2521         to true.
2522         (WTR::InjectedBundle::didReceiveMessage): Unpack the 'BeginTest' message
2523         as a dictionary containing DumpPixels and UseWaitToDumpWatchdogTimer keys.
2524         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2525         (WTR::InjectedBundle::useWaitToDumpWatchdogTimer): Make m_useWaitToDumpWatchdogTimer
2526         publicly accessible.
2527         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2528         (WTR::LayoutTestController::waitUntilDone): Only initialize the watchdog if it
2529         is required.
2530         * WebKitTestRunner/TestController.cpp:
2531         (WTR::TestController::TestController): Initialize m_useWaitToDumpWatchdogTimer
2532         to true.
2533         (WTR::TestController::initialize): Set m_useWaitToDumpWatchdogTimer to false
2534         if '--no-timeout' option is present.
2535         (WTR::TestController::runUntil): Translate TimeoutDuration to a proper timeout
2536         value, or -1.0 if timeout should not occur.
2537         * WebKitTestRunner/TestController.h:
2538         (WTR::TestController::useWaitToDumpWatchdogTimer): Make m_useWaitToDumpWatchdogTimer
2539         publicly accessible.
2540         * WebKitTestRunner/TestInvocation.cpp:
2541         (WTR::TestInvocation::invoke): Pack the 'BeginTest' message as a dictionary,
2542         containing DumpPixels and UseWaitToDumpWatchdogTimer keys and corresponding values.
2543         Waiting for final message should not time out if not necessary.
2544         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2545         (WTR::TestController::platformRunUntil): Only set up a timeout if necessary.
2546         * WebKitTestRunner/qt/TestControllerQt.cpp:
2547         (WTR::TestController::platformRunUntil): Ditto.
2548         * WebKitTestRunner/mac/TestControllerMac.mm:
2549         (WTR::TestController::platformRunUntil): Add a FIXME, indicating functionality
2550         is missing.
2551         * WebKitTestRunner/win/TestControllerWin.cpp:
2552         (WTR::TestController::platformRunUntil): Ditto.
2553
2554 2012-03-09  Jon Lee  <jonlee@apple.com>
2555
2556         Rename NotificationPresenter to NotificationClient
2557         https://bugs.webkit.org/show_bug.cgi?id=80488
2558         <rdar://problem/10965558>
2559
2560         Reviewed by Kentaro Hara.
2561
2562         Refactor to use renamed WebCore::NotificationClient.
2563         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2564         (DRTDesktopNotificationPresenter::checkNotificationPermission):
2565
2566 2012-03-07  James Robinson  <jamesr@chromium.org>
2567
2568         [chromium] Deprecate renderDirectlyToWebView parameter of WebViewClient::createGraphicsContext3D()
2569         https://bugs.webkit.org/show_bug.cgi?id=80523
2570
2571         Reviewed by Darin Fisher.
2572
2573         * DumpRenderTree/chromium/WebViewHost.cpp:
2574         (WebViewHost::createGraphicsContext3D):
2575         * DumpRenderTree/chromium/WebViewHost.h:
2576         (WebViewHost):
2577
2578 2012-03-09  Eric Seidel  <eric@webkit.org>
2579
2580         build-webkit should build Source/WTF on Mac
2581         https://bugs.webkit.org/show_bug.cgi?id=80728
2582
2583         Reviewed by Adam Barth.
2584
2585         We'll add other ports to this list in future commits.
2586
2587         * Scripts/build-webkit:
2588
2589 2012-03-09  Jon Lee  <jonlee@apple.com>
2590
2591         Add support for ENABLE(LEGACY_NOTIFICATIONS)
2592         https://bugs.webkit.org/show_bug.cgi?id=80497
2593
2594         Reviewed by Adam Barth.
2595
2596         Prep for b80472: Update API for Web Notifications
2597         * Scripts/build-webkit:
2598         * qmake/mkspecs/features/features.prf:
2599
2600 2012-03-09  Ashod Nakashian  <ashodnakashian@yahoo.com>
2601
2602         Bash scripts should support LF endings only
2603         https://bugs.webkit.org/show_bug.cgi?id=79509
2604
2605         Reviewed by David Kilzer.
2606
2607         * EWSTools/boot.sh: Added properties svn:executable and svn:eol-style.
2608         * EWSTools/start-queue.sh: Added property svn:eol-style.
2609         * Scripts/webkit-tools-completion.sh: Added properties svn:executable and svn:eol-style.
2610         * WebKitTestRunner/win/build-generated-files.sh: Added properties svn:executable and svn:eol-style.
2611         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added property svn:eol-style.
2612         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added property svn:eol-style.
2613
2614 2012-03-09  Ionut Biru  <ibiru@archlinux.org>
2615
2616         [BUILD] use detected python to run generate-gtkdoc
2617         https://bugs.webkit.org/show_bug.cgi?id=80695
2618
2619         Reviewed by Gustavo Noronha Silva.
2620
2621         * GNUmakefile.am: Use $(PYTHON) instead of plain `python`
2622
2623 2012-03-09  Nat Duca  <nduca@chromium.org>
2624
2625         Make check-webkit-style complain about "no new tests" lines in changelogs
2626         https://bugs.webkit.org/show_bug.cgi?id=80582
2627
2628         Reviewed by David Levin.
2629
2630         * Scripts/webkitpy/style/checkers/changelog.py:
2631         (ChangeLogChecker.check_entry):
2632         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
2633         (ChangeLogCheckerTest.test_no_new_tests):
2634
2635 2012-03-09  Sheriff Bot  <webkit.review.bot@gmail.com>
2636
2637         Unreviewed, rolling out r110250.
2638         http://trac.webkit.org/changeset/110250
2639         https://bugs.webkit.org/show_bug.cgi?id=80682
2640
2641         It made NRWT ignore test_expectations.txt on Qt-WK2 and ignore
2642         qt-linux at all. (Requested by Ossy on #webkit).
2643
2644         * Scripts/old-run-webkit-tests:
2645         * Scripts/webkitpy/layout_tests/port/qt.py:
2646         (QtPort):
2647         (QtPort.determine_full_port_name):
2648         (QtPort.baseline_search_path):
2649         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2650         (QtPortTest):
2651         (QtPortTest._assert_search_path):
2652         (QtPortTest.test_baseline_search_path):
2653
2654 2012-03-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2655
2656         [Qt] Use Qt's module system for install rules and depending on QtWebKit
2657
2658         Instead of rolling our own install rules we now use the same approach as
2659         every other Qt module, by loading qt_module.prf and qt_module_config.prf.
2660
2661         This ensures that we follow the same semantics as the rest of Qt on
2662         what sort of config options are enabled by default (create_cmake eg.).
2663         It also allows us to use QT += webkit instead of the workaround we had
2664         with CONFIG += qtwebkit.
2665
2666         We do however force Qt to always treat our build as a non-developer build,
2667         so the libraries will end up in the WebKit lib directory instead of the
2668         qtbase directory (as with a normal developer-build). This allows us to
2669         keep the webkit-build self-contained. If Qt is a developer build we still
2670         copy the module file manually to Qt, so that you don't have to install
2671         WebKit to make it available.
2672
2673         For non-developer builds of Qt, it is still possible to use the built
2674         WebKit libraries without having to install them, by having the variable
2675         QMAKE_EXTRA_MODULE_FORWARDS set in the project's .qmake.cache file,
2676         pointing to $WEBKITOUTUTDIR/$CONFIGURATION/modules.
2677
2678         https://bugs.webkit.org/show_bug.cgi?id=80590
2679
2680         Reviewed by Simon Hausmann.
2681
2682         * DumpRenderTree/qt/DumpRenderTree.pro:
2683         * MiniBrowser/qt/BrowserWindow.cpp:
2684         * MiniBrowser/qt/MiniBrowser.pro:
2685         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2686         * MiniBrowser/qt/UrlLoader.cpp:
2687         * QtTestBrowser/QtTestBrowser.pro:
2688         * Tools.pro:
2689         * WebKitTestRunner/InjectedBundle/Target.pri:
2690         * WebKitTestRunner/Target.pri:
2691         * qmake/mkspecs/features/default_post.prf:
2692         * qmake/mkspecs/features/default_pre.prf:
2693         * qmake/mkspecs/features/functions.prf:
2694         * qmake/mkspecs/features/qtwebkit-private.prf: Removed.
2695         * qmake/mkspecs/features/qtwebkit.prf:
2696         * qmake/mkspecs/features/rpath.prf:
2697         * qmake/mkspecs/modules/qt_webkit.pri: Removed.
2698         * qmake/qt_webkit.pri: Added.
2699
2700 2012-03-08  Igor Oliveira  <igor.o@sisa.samsung.com>
2701
2702         Unreviewed. Update my email.
2703
2704         * Scripts/webkitpy/common/config/committers.py:
2705
2706 2012-03-08  Xianzhu Wang  <wangxianzhu@chromium.org>
2707
2708         Recent changes to chromium.py etc. broke chromium_android.py
2709         https://bugs.webkit.org/show_bug.cgi?id=80623
2710
2711         Reviewed by Dirk Pranke.
2712
2713         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2714         (ChromiumAndroidDriver.__init__):
2715         (ChromiumAndroidDriver._start):
2716
2717 2012-03-08  Xianzhu Wang  <wangxianzhu@chromium.org>
2718
2719         [Chromium] Exception running reftest with --no-pixel-tests
2720         https://bugs.webkit.org/show_bug.cgi?id=80642
2721
2722         Reviewed by Dirk Pranke.
2723
2724         * Scripts/webkitpy/layout_tests/port/chromium.py:
2725         (ChromiumDriver.__init__):
2726         (ChromiumDriver._wrapper_options):
2727
2728 2012-03-08  Rafael Brandao  <rafael.lobo@openbossa.org>
2729
2730         [NRWT] Fix --platform=qt-5.0 --new-baseline combo
2731         https://bugs.webkit.org/show_bug.cgi?id=72489
2732
2733         Reviewed by Dirk Pranke.
2734
2735         NRWT: The default platform name for Qt combined with --webkit-test-runner is now
2736         "qt-5.0-wk2" instead of "qt-linux" and that name is now prefered for tests.
2737         --platform will override the platform name and then we'll use it.
2738
2739         ORWT: We check for qt version and use platform name "qt-4.8" if the version is lower
2740         than 5.0.0, and then we choose between "qt-5.0-wk1" and "qt-5.0-wk2". --platform will
2741         override it in the end.
2742
2743         * Scripts/old-run-webkit-tests:
2744         * Scripts/webkitpy/layout_tests/port/qt.py:
2745         (QtPort):
2746         (QtPort.determine_full_port_name):
2747         (QtPort.baseline_search_path):
2748         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2749         (QtPortTest):
2750         (QtPortTest._assert_search_path):
2751         (QtPortTest.test_baseline_search_path):
2752
2753 2012-03-08  Beth Dakin  <bdakin@apple.com>
2754
2755         https://bugs.webkit.org/show_bug.cgi?id=80463
2756         RenderImage is using the wrong origin when calling addRelevantRepaintedObject
2757         -and corresponding-
2758         <rdar://problem/10970221>
2759
2760         Reviewed by Dan Bernstein.
2761
2762         New test!
2763         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2764         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp: Added.
2765         (TestWebKitAPI):
2766         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
2767         (TestWebKitAPI::setPageLoaderClient):
2768         (TestWebKitAPI::TEST):
2769         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp: Added.
2770         (TestWebKitAPI):
2771         (NewFirstVisuallyNonEmptyLayoutForImagesTest):
2772         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutForImagesTest::NewFirstVisuallyNonEmptyLayoutForImagesTest):
2773         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutForImagesTest::didCreatePage):
2774         * TestWebKitAPI/Tests/WebKit2/lots-of-images.html: Added.
2775
2776 2012-03-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2777
2778         [Qt] Prospective Windows build fix
2779
2780         Don't assume that windows-builds will always run inside a cmd.exe shell.
2781
2782         * qmake/mkspecs/features/default_pre.prf:
2783
2784 2012-03-08  Dan Bernstein  <mitz@apple.com>
2785
2786         <rdar://problem/10981173> Dashboard regions should not be in device space
2787
2788         Reviewed by John Sullivan.
2789
2790         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2791         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm: Added.
2792         (-[DeviceScaleFactorInDashboardRegionsUIDelegate webView:dashboardRegionsChanged:]):
2793         (TestWebKitAPI):
2794         (TestWebKitAPI::TEST):
2795
2796 2012-03-08  Dirk Pranke  <dpranke@chromium.org>
2797
2798         webkit-patch works oddly on local Git branches
2799         https://bugs.webkit.org/show_bug.cgi?id=76958
2800
2801         Reviewed by Ojan Vafai.
2802
2803         This change makes the '-g' flag to webkit-patch behave a
2804         little more consistently with git. The 'HEAD..' syntax
2805         is changed to 'HEAD....' (four dots), so as to not
2806         collide with the underlying git syntax. We also generalize
2807         the syntax to support any refname, so 'foo....' means
2808         diff against foo and include working copy changes.
2809
2810         This change also adds the 'UPSTREAM' shortcut to identify
2811         whatever the current upstream/tracking branch is; this is
2812         useful if you have multiple local branches stacked up.
2813
2814         * Scripts/webkitpy/common/checkout/scm/git.py:
2815         (Git._branch_from_ref):
2816         (Git):
2817         (Git._current_branch):
2818         (Git._upstream_branch):
2819         (Git.merge_base):
2820         (Git._commit_on_branch):
2821         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2822         (GitSVNTest._second_local_commit):
2823         (GitSVNTest._two_local_commits):
2824         (GitSVNTest.test_commit_with_message_git_commit_range):
2825         (GitSVNTest.test_upstream_branch):
2826         (GitSVNTest.test_create_patch_working_copy_only):
2827         (GitSVNTest.test_changed_files_local_plus_working_copy):
2828         (GitSVNTest.test_changed_files_working_copy_only):
2829         (GitSVNTest.test_changed_files_upstream):
2830         * Scripts/webkitpy/tool/steps/options.py:
2831         (Options):
2832
2833 2012-03-08  John Sullivan  <sullivan@apple.com>
2834
2835         Made extract-localizable-strings ignore NSLocalizedFileSizeDescription
2836
2837         Reviewed by Eric Carlson.
2838
2839         * Scripts/extract-localizable-strings:
2840         Added NSLocalizedFileSizeDescription to allowed list of tokens that start
2841         with NSLocalized. Also improved an error message to include the troublesome token.
2842
2843 2012-03-08  Sheriff Bot  <webkit.review.bot@gmail.com>
2844
2845         Unreviewed, rolling out r110115.
2846         http://trac.webkit.org/changeset/110115
2847         https://bugs.webkit.org/show_bug.cgi?id=80581
2848
2849         broke test-webkitpy (Requested by philn-tp on #webkit).
2850
2851         * Scripts/old-run-webkit-tests:
2852         * Scripts/webkitpy/layout_tests/port/qt.py:
2853         (QtPort):
2854         (QtPort.determine_full_port_name):
2855         (QtPort.baseline_search_path):
2856
2857 2012-03-08  Kentaro Hara  <haraken@chromium.org>
2858
2859         Unreviewed. Added myself to watchlist.
2860
2861         * Scripts/webkitpy/common/config/watchlist:
2862
2863 2012-03-07  Jessie Berlin  <jberlin@apple.com>
2864
2865         Clean Windows build fails after r110033
2866         https://bugs.webkit.org/show_bug.cgi?id=80553
2867
2868         Rubber-stamped by Jon Honeycutt and Eric Seidel.
2869
2870         Add the new JavaScriptCore include directory to some more vsprops files.
2871
2872         * DumpRenderTree/win/ImageDiffCommon.vsprops:
2873         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2874         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
2875
2876 2012-03-07  Rafael Brandao  <rafael.lobo@openbossa.org>
2877
2878         [NRWT] Fix --platform=qt-5.0 --new-baseline combo
2879         https://bugs.webkit.org/show_bug.cgi?id=72489
2880
2881         Reviewed by Dirk Pranke.
2882
2883         NRWT: The default platform name for Qt combined with --webkit-test-runner is now
2884         "qt-5.0-wk2" instead of "qt-linux" and that name is now prefered for tests.
2885         --platform will override the platform name and then we'll use it.
2886
2887         ORWT: We check for qt version and use platform name "qt-4.8" if the version is lower
2888         than 5.0.0, and then we choose between "qt-5.0-wk1" and "qt-5.0-wk2". --platform will
2889         override it in the end.
2890
2891         * Scripts/old-run-webkit-tests:
2892         * Scripts/webkitpy/layout_tests/port/qt.py:
2893         (QtPort):
2894         (QtPort.determine_full_port_name):
2895         (QtPort.baseline_search_path):
2896
2897 2012-03-07  Hugo Parente Lima  <hugo.lima@openbossa.org>
2898
2899         [Qt][WK2] MiniBrowser on desktop does not react to click events
2900         https://bugs.webkit.org/show_bug.cgi?id=80314
2901
2902         Reviewed by Kenneth Rohde Christiansen.
2903
2904         Do not enable touch mocking on desktop mode.
2905
2906         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2907         (MiniBrowserApplication::handleUserOptions):
2908
2909 2012-03-07  Ojan Vafai  <ojan@chromium.org>
2910
2911         Automatically move to the next test after rebaseline in the results view
2912         https://bugs.webkit.org/show_bug.cgi?id=80527
2913
2914         Reviewed by Dimitri Glazkov.
2915
2916         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2917         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2918
2919 2012-03-07  Ojan Vafai  <ojan@chromium.org>
2920
2921         garden-o-matic rebaseline is broken for ports that don't have a fallback port
2922         https://bugs.webkit.org/show_bug.cgi?id=80526
2923
2924         Reviewed by Adam Barth.
2925
2926         Passing "None" as the fallback port throws an error in "webkit-patch rebaseline-test"
2927         since there is no "None" port.
2928
2929         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2930         (GardeningHTTPRequestHandler.rebaseline):
2931         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2932         (GardeningServerTest.test_rebaseline):
2933
2934 2012-03-07  James Robinson  <jamesr@chromium.org>
2935
2936         [chromium] Remove the TestWebPlugin's use of implicit FBO for offscreen contexts
2937         https://bugs.webkit.org/show_bug.cgi?id=80521
2938
2939         Reviewed by Kenneth Russell.
2940
2941         Switches TestWebPlugin from using a context created by WebViewClient::createGraphicsContext3D(..., false) over
2942         to an explicitly offscreen context with explicitly managed texture / FBO, so we can deprecate the
2943         renderDirectlyToHostWindow flag from WebViewClient::createGraphicsContext3D.
2944
2945         Covered by platform/chromium/compositing/plugins/*
2946
2947         * DumpRenderTree/chromium/TestWebPlugin.cpp:
2948         (TestWebPlugin::TestWebPlugin):
2949         (TestWebPlugin::initialize):
2950         (TestWebPlugin::updateGeometry):
2951         (TestWebPlugin::initScene):
2952         (TestWebPlugin::destroyScene):
2953         * DumpRenderTree/chromium/TestWebPlugin.h:
2954         (TestWebPlugin):
2955         * DumpRenderTree/chromium/WebViewHost.cpp:
2956         (WebViewHost::createPlugin):
2957
2958 2012-03-07  Philippe Normand  <pnormand@igalia.com>
2959
2960         [GTK] remove webkitpy dependency in run-gtk-tests
2961         https://bugs.webkit.org/show_bug.cgi?id=80500
2962
2963         Reviewed by Martin Robinson.
2964
2965         Replace Executive calls with bare subprocess calls.
2966
2967         * Scripts/run-gtk-tests:
2968         (TestRunner):
2969         (TestRunner._lookup_atspi2_binary):
2970         (TestRunner.run):
2971         (TestRunner.run.run_for_real):
2972
2973 2012-03-07  Philippe Normand  <pnormand@igalia.com>
2974
2975         Unreviewed, GTK build fix after r110059.
2976
2977         * Scripts/run-gtk-tests:
2978         (TestRunner._check_if_tests_have_timed_out):
2979         (TestRunner.run.run_tests):
2980         (TestRunner):
2981
2982 2012-03-07  Philippe Normand  <pnormand@igalia.com>
2983
2984         [GTK] race condition in run-gtk-tests
2985         https://bugs.webkit.org/show_bug.cgi?id=80495
2986
2987         Reviewed by Martin Robinson.
2988
2989         Refactored the script to wait the a11y dbus service becomes
2990         available before starting the tests.
2991
2992         * Scripts/run-gtk-tests:
2993         (TestRunner._lookup_atspi2_binary):
2994         (TestRunner):
2995         (TestRunner._wait_dbus_service_and_run):
2996         (TestRunner._wait_dbus_service_and_run.on_name_appeared):
2997         (TestRunner._wait_dbus_service_and_run.on_name_vanished):
2998         (TestRunner.run):
2999         (TestRunner.run.bailout):
3000         (TestRunner.run.run_for_real):
3001
3002 2012-03-07  Dinu Jacob  <dinu.jacob@nokia.com>
3003
3004         [Qt] REGRESSION(r109575) Broke tap-to-zoom gesture
3005         https://bugs.webkit.org/show_bug.cgi?id=80425
3006
3007         Reviewed by Simon Hausmann.
3008
3009         Set startScreenPos in mock touch point
3010
3011         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3012         (MiniBrowserApplication::notify):
3013         * MiniBrowser/qt/MiniBrowserApplication.h:
3014         (MiniBrowserApplication):
3015
3016 2012-03-07  Simon Hausmann  <simon.hausmann@nokia.com>
3017
3018         [Qt] Windows build fix.
3019
3020         Reviewed by Tor Arne Vestbø.
3021
3022         Pass the -j parameter only to "make", not "nmake".
3023
3024         * Scripts/webkitdirs.pm:
3025         (buildQMakeProjects):
3026
3027 2012-03-07  Simon Hausmann  <simon.hausmann@nokia.com>
3028
3029         [Qt] Fix compilation without QtQuick1
3030         https://bugs.webkit.org/show_bug.cgi?id=80503
3031
3032         Reviewed by Tor Arne Vestbø.
3033
3034         Introduce HAVE_QQUICK1 as feature and added haveQtModule
3035         as convenience function.
3036
3037         * qmake/mkspecs/features/features.prf:
3038         * qmake/mkspecs/features/functions.prf:
3039
3040 2012-03-07  Zoltan Horvath  <zoltan@webkit.org>
3041
3042         [Qt] Add qmake config tests for JPEG and PNG library
3043         https://bugs.webkit.org/show_bug.cgi?id=80398
3044
3045         Add JPEG and PNG library tests to config.tests and
3046         add error() abort to WebCore.pri if tests don't work.
3047
3048         Reviewed by Tor Arne Vestbø.
3049
3050         * qmake/config.tests/libjpeg/libjpeg.cpp: Added.
3051         (main):
3052         * qmake/config.tests/libjpeg/libjpeg.pro: Added.
3053         * qmake/config.tests/libpng/libpng.cpp: Added.
3054         (main):
3055         * qmake/config.tests/libpng/libpng.pro: Added.
3056         * qmake/sync.profile:
3057
3058 2012-03-07  Byungwoo Lee  <bw80.lee@samsung.com>
3059
3060         [EFL] Build warning: Fix warn_unused_result warnings.
3061         https://bugs.webkit.org/show_bug.cgi?id=79194
3062
3063         Reviewed by Filip Pizlo.
3064
3065         Fixed build warning which is getting generated when not using return
3066         value of a fuction, especially declared with warn_unused_result
3067         attribute.
3068
3069         * DumpRenderTree/efl/ImageDiff.cpp:
3070         (printImage):
3071
3072 2012-03-07  Kangil Han  <kangil.han@samsung.com>
3073
3074         [DRT] Remove PlainTextController implementations.
3075         https://bugs.webkit.org/show_bug.cgi?id=79959
3076
3077         Reviewed by Hajime Morita.
3078
3079         PlainTextController usages in existing tests have been
3080         replaced by internals API by bug 78570.
3081         So this patch will remove PlainTextController implementations
3082         to avoid further usage in new tests.
3083
3084         * DumpRenderTree/DumpRenderTree.gypi:
3085         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3086         * DumpRenderTree/chromium/PlainTextController.cpp: Removed.
3087         * DumpRenderTree/chromium/PlainTextController.h: Removed.
3088         * DumpRenderTree/chromium/TestShell.cpp:
3089         (TestShell::TestShell):
3090         (TestShell::bindJSObjectsToWindow):
3091         * DumpRenderTree/chromium/TestShell.h:
3092         (TestShell):
3093         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3094         (webViewWindowObjectCleared):
3095         * DumpRenderTree/gtk/PlainTextController.cpp: Removed.
3096         * DumpRenderTree/gtk/PlainTextController.h: Removed.
3097         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3098         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
3099         * DumpRenderTree/mac/PlainTextController.h: Removed.
3100         * DumpRenderTree/mac/PlainTextController.mm: Removed.
3101         * DumpRenderTree/qt/DumpRenderTree.pro:
3102         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3103         (WebCore::DumpRenderTree::DumpRenderTree):
3104         (WebCore::DumpRenderTree::initJSObjects):
3105         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3106         (DumpRenderTree):
3107         * DumpRenderTree/qt/PlainTextControllerQt.cpp: Removed.
3108         * DumpRenderTree/qt/PlainTextControllerQt.h: Removed.
3109         * GNUmakefile.am:
3110
3111 2012-03-06  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
3112
3113         [EFL][DRT] Implements LayoutTestController's setPopupBlockingEnabled.
3114         https://bugs.webkit.org/show_bug.cgi?id=80137
3115
3116         Reviewed by Eric Seidel.
3117
3118         Adds implementation LayoutTestController's setPopupBlockingEnabled.
3119         To pass popup-blocking-click-in-iframe.html EventSender should not
3120         repeat click events in idler's function. EventSender allows to
3121         asynchronously send click event through ecore_idler_add.
3122         This event will be called repeatedly as long as it return true.
3123         Click event should be called only once by returning ECORE_CALLBACK_CANCEL.
3124
3125         * DumpRenderTree/efl/EventSender.cpp:
3126         (sendMouseEvent): Changed return value from bool to void because it always returns true.
3127         (sendClick): Idler is deleted by returning ECORE_CALLBACK_CANCEL.
3128         (mouseDownCallback): Remove unnecessary checking of return value.
3129         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3130         (LayoutTestController::setPopupBlockingEnabled):
3131
3132 2012-03-06  Dirk Pranke  <dpranke@chromium.org>
3133
3134         rebaseline_chromium_webkit_tests is obsolete and should be removed
3135         https://bugs.webkit.org/show_bug.cgi?id=80347
3136
3137         Reviewed by Tony Chang.
3138
3139         * Scripts/rebaseline-chromium-webkit-tests: Removed.
3140         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py: Removed.
3141         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py: Removed.
3142
3143 2012-03-06  Dirk Pranke  <dpranke@chromium.org>
3144
3145         test_start_cmd (webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer) is broken
3146         https://bugs.webkit.org/show_bug.cgi?id=80468
3147
3148         Unreviewed, build fix.
3149
3150         Fixing a bug revealed by r80443 when we fixed filesystem.copyfile().
3151
3152         * Scripts/webkitpy/layout_tests/servers/http_server.py:
3153         (Lighttpd._prepare_config):
3154
3155 2012-03-06  Dirk Pranke  <dpranke@chromium.org>
3156
3157         remove chromium_gpu ports
3158         https://bugs.webkit.org/show_bug.cgi?id=80345
3159
3160         Reviewed by Ojan Vafai.
3161
3162         This change leaves in the 'graphics_type' distinction in the
3163         test_expectations; removing that will require more updates and a
3164         pass over test_expectations.txt, so I'm separating that out.
3165
3166         * Scripts/webkitpy/layout_tests/port/builders.py:
3167         * Scripts/webkitpy/layout_tests/port/chromium.py:
3168         (ChromiumPort):
3169         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: Removed.
3170         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py: Removed.
3171         * Scripts/webkitpy/layout_tests/port/factory.py:
3172         (PortFactory):
3173         (PortFactory.get):
3174         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3175         (FactoryTest.test_qt):
3176         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3177         (TestRebaseline.test_rebaseline_expectations):
3178
3179 2012-03-06  Raphael Kubo da Costa  <kubo@profusion.mobi>
3180
3181         undefined reference to JSC::IdentifierTable::~IdentifierTable() on EFL port
3182         https://bugs.webkit.org/show_bug.cgi?id=80282
3183
3184         Reviewed by Antonio Gomes.
3185
3186         Remove transitive library dependencies; they are especially
3187         dangerous when one ends up linking against WTF, JSC and then WTF
3188         again, since some symbols will not be defined.
3189
3190         Passing --no-copy-dt-needed-entries and --as-needed to the linker
3191         (which some recent Linux distros do by default) makes the issue
3192         even more evident.
3193
3194         * DumpRenderTree/efl/CMakeLists.txt: Do not link directly to WTF,
3195         as the other libraries have the needed symbols. Explicitly link
3196         against fontconfig.
3197
3198 2012-03-06  Dean Jackson  <dino@apple.com>
3199
3200         filter-build-webkit needs more filters
3201         https://bugs.webkit.org/show_bug.cgi?id=80440
3202
3203         Reviewed by Joseph Pecoraro.
3204
3205         Added as many missing filters as I could find for Apple
3206         builds. Plus a few minor style updates.
3207
3208         * Scripts/filter-build-webkit:
3209         (printLine):
3210
3211 2012-03-06  Ojan Vafai  <ojan@chromium.org>
3212
3213         Copying old baselines throws an error if the new directory doesn't exist
3214         https://bugs.webkit.org/show_bug.cgi?id=80443
3215
3216         Reviewed by Adam Barth.
3217
3218         Existing tests cover the new code with the fix to filesystem_mock.
3219
3220         * Scripts/webkitpy/common/system/filesystem_mock.py:
3221         (MockFileSystem.copyfile):
3222         Fix the mock to better match python's copyfile semantics.
3223
3224         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3225         (Rebaseliner._create_html_baseline_files):
3226         * Scripts/webkitpy/tool/commands/rebaseline.py:
3227         (RebaselineTest._copy_existing_baseline):
3228
3229 2012-03-05  Ojan Vafai  <ojan@chromium.org>
3230
3231         Add a mechanism to rebaseline new ports
3232         https://bugs.webkit.org/show_bug.cgi?id=80355
3233
3234         Reviewed by Adam Barth.
3235
3236         For a test that's only failing on a new port, we want
3237         to first copy the existing result into the location for the
3238         port it's replacing in order to not break that port.
3239
3240         For example, bringing up the chromium-lion port, if we just
3241         stick the results in the chromium-mac directory, the snow leopard
3242         will start failing. Instead, we first copy the existing result
3243         to the chromium-mac-snowleopard directory.
3244
3245         * Scripts/webkitpy/layout_tests/port/builders.py:
3246         (builder_path_for_port_name):
3247         (fallback_port_name_for_new_port):
3248         * Scripts/webkitpy/tool/commands/rebaseline.py:
3249         (RebaselineTest):
3250         (RebaselineTest._copy_existing_baseline):
3251         (RebaselineTest._rebaseline_test):
3252         (RebaselineTest.execute):
3253         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3254         (TestRebaseline.test_rebaseline_test):
3255         (TestRebaseline):
3256         (TestRebaseline.test_rebaseline_and_copy_test):
3257         (test_rebaseline_and_copy_test_no_existing_result):
3258         (test_rebaseline_and_copy_test_with_lion_result):
3259         (test_rebaseline_and_copy_no_overwrite_test):
3260         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3261         (GardeningHTTPRequestHandler.rebaseline):
3262         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3263         (GardeningServerTest.test_rebaseline):
3264         (GardeningServerTest):
3265         (GardeningServerTest.test_rebaseline_new_port):
3266
3267 2012-03-06  Beth Dakin  <bdakin@apple.com>
3268
3269         https://bugs.webkit.org/show_bug.cgi?id=80351
3270         InlineTextBox is using the wrong origin when calling 
3271         addRelevantRepaintedObject
3272         -and corresponding-
3273         <rdar://problem/10970221>
3274
3275         Reviewed by Sam Weinig.
3276
3277         This test has actually been broken since revision 109273. This change makes 
3278         the test pass again, and it makes it specifically exercise the fix for this 
3279         bug.
3280         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3281         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
3282         (TestWebKitAPI::TEST):
3283
3284         Adjust comments in the other tests to reflect the API changes from 109273.
3285         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
3286         (TestWebKitAPI::TEST):
3287         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
3288         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::didCreatePage):
3289         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
3290         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::didCreatePage):
3291         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
3292         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::didCreatePage):
3293         * TestWebKitAPI/Tests/WebKit2/lots-of-text.html: Added.
3294
3295 2012-03-06  Hans Wennborg  <hans@chromium.org>
3296
3297         Speech JavaScript API: add SpeechRecognitionError
3298         https://bugs.webkit.org/show_bug.cgi?id=80410
3299
3300         Chromium: enable the runtime flag for scripted speech so we can run
3301         the layout tests for it.
3302
3303         Reviewed by Adam Barth.
3304
3305         * DumpRenderTree/chromium/TestShell.cpp:
3306         (TestShell::TestShell):
3307
3308 2012-03-06  Sami Kyostila  <skyostil@chromium.org>
3309
3310         Enable universal newlines in chromium android layout test runner
3311         https://bugs.webkit.org/show_bug.cgi?id=80418
3312
3313         Reviewed by Adam Barth.
3314
3315         The Chromium Android layout test runner uses the 'adb' program to
3316         communicate with the Android device. Adb uses CRLF ('\r\n') to delimit
3317         output lines from the test runner, while the test expectation files are
3318         written with LF ('\n') delimiters. This causes the results to have
3319         spurious whitespace differences, making them more difficult to
3320         interpret.
3321
3322         The fix is to enable universal newlines for the DumpRenderTree pipe,
3323         causing the output to only contain LF newlines like on other platforms.
3324
3325         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3326         (ChromiumAndroidDriver._start):
3327
3328 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3329
3330         [Qt] Revert r109900, it was completly busted
3331
3332         HAVE_FOO does _not_ have a WTF_ prefix, go figure.
3333
3334         We still leave in the HAVE(FOO) in QtInitializeTestFonts.cpp, instead
3335         of manual define checks.
3336
3337         Reviewed by Ossy.
3338
3339         * DumpRenderTree/qt/DumpRenderTree.pro:
3340         * QtTestBrowser/QtTestBrowser.pro:
3341         * WebKitTestRunner/InjectedBundle/Target.pri:
3342         * qmake/mkspecs/features/features.prf:
3343
3344 2012-03-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3345
3346         [Qt] Use config test to determine if the compiler supports -MD
3347
3348         We used to assume that unix systems building against Qt5 would have
3349         a compiler that supported -MD. Although this was usually the case,
3350         we failed to take into account broken tools for distributed builds
3351         (e.g. teambuilder or icecream) which would end up producing .d files
3352         in the root of the build dir instead of along-side the object file.
3353
3354         Now that we use a config-test to determine the support, we'll capture
3355         those cases, unless distributed builds are enabled after the initial
3356         build-webkit run.
3357
3358         Reviewed by Csaba Osztrogonác.
3359
3360         * Tools.pro:
3361         * qmake/config.tests/gccdepends/empty.cpp: Added.
3362         * qmake/config.tests/gccdepends/gccdepends.pro: Added.
3363         * qmake/mkspecs/features/default_pre.prf:
3364         * qmake/mkspecs/features/features.prf:
3365         * qmake/mkspecs/features/unix/default_pre.prf:
3366         * qmake/sync.profile:
3367
3368 2012-03-06  Csaba Osztrogonác  <ossy@webkit.org>
3369
3370         REGRESSION(r109294): It broke the unittest of master.cfg
3371         https://bugs.webkit.org/show_bug.cgi?id=80253
3372
3373         Reviewed by Tor Arne Vestbø.
3374
3375         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Use json instead of simplejson.
3376         (BuildBotConfigLoader._create_mock_passwords_dict):
3377         (BuildBotConfigLoader._mock_open):
3378         (BuildBotConfigLoader._add_dependant_modules_to_sys_modules):
3379         (BuildBotConfigLoader.load_config):
3380
3381 2012-03-06  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3382
3383         Qt API test buildstep throws exception after buildmaster update
3384         https://bugs.webkit.org/show_bug.cgi?id=80249
3385
3386         This patch based on Peter Gal's work.
3387
3388         Reviewed by Csaba Osztrogonác.
3389
3390         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3391         (RunQtAPITests):
3392         (BuildAndTestFactory.__init__): Enable API tests on the Qt platform again.
3393
3394 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3395
3396         [Qt] Use correct define names for HAVE(FOO) style optional dependencies
3397
3398         Reviewed by Simon Hausmann.
3399         Reviewed by Ossy.
3400
3401         * DumpRenderTree/qt/DumpRenderTree.pro:
3402         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
3403         (WebKit::initializeTestFonts):
3404         * QtTestBrowser/QtTestBrowser.pro:
3405         * WebKitTestRunner/InjectedBundle/Target.pri:
3406         * qmake/mkspecs/features/features.prf:
3407
3408 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3409
3410         [Qt] Don't add recursive qmake_all target if there are no subdirs to recurse
3411
3412         Reviewed by Ossy.
3413
3414         * qmake/mkspecs/features/default_post.prf:
3415
3416 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3417
3418         [Qt] Make sure clean builds are followed by make qmake && make if needed
3419
3420         On non-GNUmake systems we have to run make qmake so that the generated
3421         sources are generated before we run qmake on the target pro files. This
3422         is achieved by using the 'incremental' target.
3423
3424         Reviewed by Ossy.
3425
3426         * Scripts/webkitdirs.pm:
3427         (buildQMakeProjects):
3428
3429 2012-03-06  Filip Pizlo  <fpizlo@apple.com>
3430
3431         DumpRenderTree should support preciseTime()
3432         https://bugs.webkit.org/show_bug.cgi?id=80397
3433
3434         Reviewed by Gavin Barraclough.
3435
3436         * DumpRenderTree/LayoutTestController.cpp:
3437         (preciseTimeCallback):
3438         (LayoutTestController::staticFunctions):
3439
3440 2012-03-06  Sheriff Bot  <webkit.review.bot@gmail.com>
3441
3442         Unreviewed, rolling out r109887.
3443         http://trac.webkit.org/changeset/109887
3444         https://bugs.webkit.org/show_bug.cgi?id=80402
3445
3446         It broke the build (Requested by Ossy on #webkit).
3447
3448         * DumpRenderTree/qt/DumpRenderTree.pro:
3449         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
3450         (WebKit::initializeTestFonts):
3451         * QtTestBrowser/QtTestBrowser.pro:
3452         * WebKitTestRunner/InjectedBundle/Target.pri:
3453         * qmake/mkspecs/features/features.prf:
3454
3455 2012-03-06  Sheriff Bot  <webkit.review.bot@gmail.com>
3456
3457         Unreviewed, rolling out r109837.
3458         http://trac.webkit.org/changeset/109837
3459         https://bugs.webkit.org/show_bug.cgi?id=80399
3460
3461         breaks Mac Productions builds, too late to try and fix it
3462         tonight (Requested by eseidel on #webkit).
3463
3464         * Scripts/build-webkit:
3465
3466 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3467
3468         [Qt] Use correct define names for HAVE(FOO) style optional dependencies
3469
3470         Reviewed by Simon Hausmann.
3471
3472         * DumpRenderTree/qt/DumpRenderTree.pro:
3473         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
3474         (WebKit::initializeTestFonts):
3475         * QtTestBrowser/QtTestBrowser.pro:
3476         * WebKitTestRunner/InjectedBundle/Target.pri:
3477         * qmake/mkspecs/features/features.prf:
3478
3479 2012-03-06  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3480
3481         [Qt] Create EWS to build WebKit2
3482         https://bugs.webkit.org/show_bug.cgi?id=80277
3483
3484         Reviewed by Csaba Osztrogonác.
3485
3486         * QueueStatusServer/model/queues.py:
3487         (Queue):
3488         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3489         (QtWK2EWS):
3490         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3491         (EarlyWarningSytemTest.test_builder_ewses):
3492
3493 2012-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
3494
3495         Unreviewed, rolling out r109733.
3496         http://trac.webkit.org/changeset/109733
3497         https://bugs.webkit.org/show_bug.cgi?id=80378
3498
3499         It broke Qt5 build system (Requested by Ossy on #webkit).
3500
3501         * Tools.pro:
3502         * qmake/config.tests/gccdepends/empty.cpp: Removed.
3503         * qmake/config.tests/gccdepends/gccdepends.pro: Removed.
3504         * qmake/mkspecs/features/default_pre.prf:
3505         * qmake/mkspecs/features/features.prf:
3506         * qmake/mkspecs/features/unix/default_pre.prf:
3507         * qmake/sync.profile:
3508
3509 2012-03-05  Eric Seidel  <eric@webkit.org>
3510
3511         Update JavaScriptCore files to use fully-qualified WTF include path
3512         https://bugs.webkit.org/show_bug.cgi?id=79960
3513
3514         Reviewed by Adam Barth.
3515
3516         Build WTF/WTF.xcodeproj by default on Mac.
3517
3518         * Scripts/build-webkit:
3519
3520 2012-03-05  Dirk Pranke  <dpranke@chromium.org>
3521
3522         There should be a way to disable optimizer in webkit-patch rebaseline-expectations
3523         https://bugs.webkit.org/show_bug.cgi?id=69590
3524
3525         Reviewed by Ryosuke Niwa.
3526
3527         Adds a --no-optimize flag to webkit-patch rebaseline-expectations
3528         to skip the 'optimize-expectations' step.
3529
3530         * Scripts/webkitpy/tool/commands/rebaseline.py:
3531         (RebaselineExpectations.__init__):
3532         (RebaselineExpectations.execute):
3533         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3534
3535 2012-03-05  Kent Tamura  <tkent@chromium.org>
3536
3537         [Chromium] Add new popup type: PagePopup
3538         https://bugs.webkit.org/show_bug.cgi?id=80106
3539
3540         Reviewed by Darin Fisher.
3541
3542         * DumpRenderTree/chromium/WebViewHost.cpp:
3543         (WebViewHost::createPopupMenu):
3544
3545 2012-03-05  Jessie Berlin  <jberlin@apple.com>
3546
3547         Add myself as a reviewer.
3548
3549         * Scripts/webkitpy/common/config/committers.py:
3550         Also, add my IRC nick so it is easier to find and yell at me.
3551
3552 2012-03-05  Robert Kroeger  <rjkroege@chromium.org>
3553
3554         Correctly compute the positions of GestureScroll* events on
3555         Chromium.
3556         https://bugs.webkit.org/show_bug.cgi?id=80075
3557
3558         Reviewed by Adam Barth.
3559
3560         * DumpRenderTree/chromium/EventSender.cpp:
3561         (EventSender::reset):
3562         (EventSender::gestureEvent):
3563         * DumpRenderTree/chromium/EventSender.h:
3564         (EventSender):
3565
3566 2012-03-05  Dirk Pranke  <dpranke@chromium.org>
3567
3568         flakiness dashboard doesn't display baselines for virtual tests correctly
3569         https://bugs.webkit.org/show_bug.cgi?id=80341
3570
3571         Reviewed by Ojan Vafai.
3572
3573         If the test is part of a virtual test suite, we need to look for
3574         baselines in the underlying fallback path for the actual test
3575         being run, as well as baselines for the virtual version.
3576
3577         This patch adds code to handle both branches and also pulls the
3578         mapping of the test suites up into a constant.
3579
3580         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3581         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3582         (testLookupVirtualTestSuite):
3583         (testBaseTest):
3584
3585 2012-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
3586
3587         Unreviewed, rolling out r109760.
3588         http://trac.webkit.org/changeset/109760
3589         https://bugs.webkit.org/show_bug.cgi?id=80320
3590
3591         Caused many GTK+ tests to crash (Requested by mrobinson on
3592         #webkit).
3593
3594         * gtk/jhbuild.modules:
3595
3596 2012-03-05  Charlie Reis  <creis@chromium.org>
3597
3598         [chromium] Pass WebNavigationPolicy to WebViewClient::createView
3599         https://bugs.webkit.org/show_bug.cgi?id=80057
3600
3601         Reviewed by Darin Fisher.
3602
3603         * DumpRenderTree/chromium/WebViewHost.cpp:
3604         (WebViewHost::createView):
3605         * DumpRenderTree/chromium/WebViewHost.h:
3606         (WebViewHost):
3607
3608 2012-03-05  Martin Robinson  <mrobinson@igalia.com>
3609
3610         [soup] Crash while loading http://www.jusco.cn
3611         https://bugs.webkit.org/show_bug.cgi?id=68238
3612
3613         Reviewed by Philippe Normand.
3614
3615         * gtk/jhbuild.modules: Bumped the libsoup and glib dependencies
3616         in the jhbuild file.
3617
3618 2012-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
3619
3620         Unreviewed, rolling out r109748.
3621         http://trac.webkit.org/changeset/109748
3622         https://bugs.webkit.org/show_bug.cgi?id=80296
3623
3624         Made some tests crash, will fix and recommit (Requested by
3625         noamr on #webkit).
3626
3627         * MiniBrowser/qt/main.cpp:
3628         (main):
3629
3630 2012-03-05  Zan Dobersek  <zandobersek@gmail.com>
3631
3632         [GTK] plugins/netscape-plugin-page-cache-works.html fails
3633         https://bugs.webkit.org/show_bug.cgi?id=74409
3634
3635         Reviewed by Martin Robinson.
3636
3637         Add support for overriding the page-cache-for-plugins preference
3638         through DumpRenderTreeSupport.
3639
3640         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3641         (booleanFromValue): A helper function to convert a string to boolean.
3642         (LayoutTestController::overridePreference):
3643
3644 2012-03-05  Rob Buis  <rbuis@rim.com>
3645
3646         [BlackBerry] Update Tools/DumpRenderTree
3647         https://bugs.webkit.org/show_bug.cgi?id=80287
3648
3649         Reviewed by Antonio Gomes.
3650
3651         Update so we are sure we can build our implementation of DRT.
3652
3653         * DumpRenderTree/DumpRenderTree.h: include DumpRenderTreeBlackBerry.h.
3654         * DumpRenderTree/PixelDumpSupport.cpp: include PixelDumpSupportBlackBerry.h.
3655         * DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp:
3656         (AccessibilityController::addNotificationListener): add missing hook.
3657         (AccessibilityController::removeNotificationListener): add missing hook.
3658         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
3659         (AccessibilityUIElement::isSelectedOptionActive): add missing hook.
3660         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
3661         (LayoutTestController::setMockSpeechInputDumpRect): add missing hook.
3662         (LayoutTestController::simulateDesktopNotificationClick): add missing hook.
3663
3664 2012-03-05  No'am Rosenthal  <noam.rosenthal@nokia.com>
3665
3666         [Qt] [WK2] Support threaded renderer in WK2
3667         https://bugs.webkit.org/show_bug.cgi?id=76661
3668
3669         Remove the QML_NO_THREADED_RENDERER environment variable from MiniBrowser.
3670
3671         Reviewed by Kenneth Rohde Christiansen.
3672
3673         * MiniBrowser/qt/main.cpp:
3674         (main):
3675
3676 2012-03-05  Alexander Færøy  <alexander.faeroy@nokia.com>
3677
3678         Unreviewed. Add myself to committer list.
3679
3680         * Scripts/webkitpy/common/config/committers.py:
3681
3682 2012-03-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3683
3684         [Qt] Use config test to determine if the compiler supports -MD
3685
3686         We used to assume that unix systems building against Qt5 would have
3687         a compiler that supported -MD. Although this was usually the case,
3688         we failed to take into account broken tools for distributed builds
3689         (e.g. teambuilder or icecream) which would end up producing .d files
3690         in the root of the build dir instead of along-side the object file.