4ceee7b903e926e7fe0e19f6eae7b4795841ea2c
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
2
3         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
4         https://bugs.webkit.org/show_bug.cgi?id=194158
5         <rdar://problem/47737268>
6
7         Rubber-stamped by Aakash Jain.
8
9         * Scripts/webkitpy/port/device_port.py:
10         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
11
12 2019-02-04  Said Abou-Hallawa  <said@apple.com>
13
14         [CG] Enable setAdditionalSupportedImageTypes for WK1
15         https://bugs.webkit.org/show_bug.cgi?id=194190
16
17         Reviewed by Tim Horton.
18
19         Add a test similar to the one under WebKit Cocoa but make it create a
20         WebView instead of a WKWebView.
21
22         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
23         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
24         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
25         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
26         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
27         (TestWebKitAPI::runTest):
28         (TestWebKitAPI::TEST):
29
30 2019-02-04  Zalan Bujtas  <zalan@apple.com>
31
32         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
33         https://bugs.webkit.org/show_bug.cgi?id=194168
34
35         Reviewed by Simon Fraser.
36
37         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
38
39         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
40         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
41         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
42         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
43         (TEST):
44         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
45         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
46
47 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
48
49         REGRESSION (r237269): webkit-patch what-broke is broken 
50         https://bugs.webkit.org/show_bug.cgi?id=193025
51
52         Reviewed by Aakash Jain.
53
54         * Scripts/webkitpy/common/host.py:
55         (Host.buildbot):
56         (Host.bugzilla): Renamed to 'buildbot'.
57
58 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
59
60         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
61         https://bugs.webkit.org/show_bug.cgi?id=194207
62
63         Reviewed by Tim Horton.
64
65         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
66         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
67         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
68         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
69         start and delete forwards to remove the original attachment.
70
71         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
72         (TestWebKitAPI::TEST):
73
74 2019-02-04  Youenn Fablet  <youenn@apple.com>
75
76         Capture state should be managed consistently when doing process swapping
77         https://bugs.webkit.org/show_bug.cgi?id=194122
78         <rdar://problem/47609293>
79
80         Reviewed by Eric Carlson.
81
82         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
83         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
84         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
85         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
86         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
87         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
88         (WTR::TestRunner::isDoingMediaCapture const):
89         * WebKitTestRunner/InjectedBundle/TestRunner.h:
90         * WebKitTestRunner/TestController.cpp:
91         (WTR::TestController::isDoingMediaCapture const):
92         * WebKitTestRunner/TestController.h:
93         * WebKitTestRunner/TestInvocation.cpp:
94         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
95         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
96         (WTR::TestController::isDoingMediaCapture const):
97
98 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
99
100         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
101         https://bugs.webkit.org/show_bug.cgi?id=194142
102
103         Reviewed by Ross Kirsling.
104
105         There three 'separator' variables in TestController.cpp. Renamed
106         it 'pathSeparator', and unified them.
107
108         * WebKitTestRunner/TestController.cpp:
109         (WTR::TestController::generateContextConfiguration const):
110         (WTR::createTestURL):
111         (WTR::TestController::platformAdjustContext):
112
113 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
114
115         Make setNeedsLayout on the root more explicitly about triggering its side-effects
116         https://bugs.webkit.org/show_bug.cgi?id=194198
117
118         Reviewed by Antti Koivisto.
119
120         No need to set the banner heights on navigation now, since Page stores them.
121
122         * MiniBrowser/mac/WK2BrowserWindowController.m:
123         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
124
125 2019-02-03  John Wilander  <wilander@apple.com>
126
127         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
128         https://bugs.webkit.org/show_bug.cgi?id=194104
129         <rdar://problem/47649991>
130
131         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
132
133         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
134         (TestWebKitAPI::TEST):
135             Changed numeric types from unsigned short to uint32_t.
136
137 2019-02-02  David Kilzer  <ddkilzer@apple.com>
138
139         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
140         <https://webkit.org/b/194178>
141         <rdar://problem/47753473>
142
143         Reviewed by Alexey Proskuryakov.
144
145         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
146         (WTR::uninstallFakeHelvetica): Pass nullptr into
147         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
148
149 2019-02-02  Zalan Bujtas  <zalan@apple.com>
150
151         [LFC] Initialize ICB's style with fixed width/height.
152         https://bugs.webkit.org/show_bug.cgi?id=194188
153
154         Reviewed by Antti Koivisto.
155
156         * LayoutReloaded/misc/LFC-passing-tests.txt:
157
158 2019-02-02  Zalan Bujtas  <zalan@apple.com>
159
160         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
161         https://bugs.webkit.org/show_bug.cgi?id=194185
162
163         Reviewed by Antti Koivisto.
164
165         * LayoutReloaded/misc/LFC-passing-tests.txt:
166
167 2018-12-16  Darin Adler  <darin@apple.com>
168
169         Convert additional String::format clients to alternative approaches
170         https://bugs.webkit.org/show_bug.cgi?id=192746
171
172         Reviewed by Alexey Proskuryakov.
173
174         * WebKitTestRunner/TestController.cpp:
175         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
176         as an intermediate in code that ultimately constructs a WTF::String.
177         (WTR::userMediaOriginHash): Use makeString.
178         (WTR::TestController::didNavigateWithNavigationData): More of the same.
179         (WTR::TestController::didPerformClientRedirect): Ditto.
180         (WTR::TestController::didPerformServerRedirect): Ditto.
181         (WTR::TestController::didUpdateHistoryTitle): Ditto.
182
183 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
184
185         [ews-build] Add unit test to verify builder keys
186         https://bugs.webkit.org/show_bug.cgi?id=194152
187
188         Reviewed by Lucas Forschler.
189
190         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
191         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
192
193 2019-02-01  Zalan Bujtas  <zalan@apple.com>
194
195         [LFC] Expand tests coverage (12 new tests -> 787)
196
197         Unreviewed test gardening.
198
199         * LayoutReloaded/misc/LFC-passing-tests.txt:
200
201 2019-02-01  Zalan Bujtas  <zalan@apple.com>
202
203         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
204         https://bugs.webkit.org/show_bug.cgi?id=194163
205
206         Reviewed by Simon Fraser.
207
208         775
209
210         * LayoutReloaded/misc/LFC-passing-tests.txt:
211
212 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
213
214         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
215         https://bugs.webkit.org/show_bug.cgi?id=194140
216         <rdar://problem/47728098>
217
218         Reviewed by Tim Horton.
219
220         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
221         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
222         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
223
224         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
225         test to induce an IPC deadlock when presenting a modal alert during touch start.
226
227         * WebKitTestRunner/InjectedBundle/TestRunner.h:
228         * WebKitTestRunner/TestController.cpp:
229         (WTR::runJavaScriptAlert):
230
231         Add a client callback function for running JavaScript alerts.
232
233         (WTR::TestController::createOtherPage):
234         (WTR::TestController::generateContextConfiguration const):
235
236         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
237         the fix in this patch.
238
239         (WTR::TestController::createWebViewWithOptions):
240
241         Plumb TestOptions to generateContextConfiguration.
242
243         (WTR::TestController::resetPreferencesToConsistentValues):
244         (WTR::TestController::resetStateToConsistentValues):
245         (WTR::updateTestOptionsFromTestHeader):
246         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
247         (WTR::TestController::handleJavaScriptAlert):
248         * WebKitTestRunner/TestController.h:
249         * WebKitTestRunner/TestInvocation.cpp:
250         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
251         * WebKitTestRunner/TestOptions.h:
252         (WTR::TestOptions::hasSameInitializationOptions const):
253
254 2019-02-01  Chris Dumez  <cdumez@apple.com>
255
256         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
257         https://bugs.webkit.org/show_bug.cgi?id=193740
258         <rdar://problem/47527267>
259
260         Reviewed by Alex Christensen.
261
262         Add API test coverage.
263
264         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
265
266 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
267
268         [ews-app] Add display name field to BuilderMapping model
269         https://bugs.webkit.org/show_bug.cgi?id=194153
270
271         Reviewed by Lucas Forschler.
272
273         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
274         (BuilderMapping):
275
276 2019-02-01  Youenn Fablet  <youenn@apple.com>
277
278         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
279         https://bugs.webkit.org/show_bug.cgi?id=194155
280
281         Reviewed by Eric Carlson.
282
283         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
284         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
285         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
286
287 2019-02-01  Zalan Bujtas  <zalan@apple.com>
288
289         [LFC] Adjust replaced element's intrinsic ratio
290         https://bugs.webkit.org/show_bug.cgi?id=194154
291
292         Reviewed by Antti Koivisto.
293
294         761
295
296         * LayoutReloaded/misc/LFC-passing-tests.txt:
297
298 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
299
300         [WPE] Show test results in minibrowser
301         https://bugs.webkit.org/show_bug.cgi?id=194150
302
303         Reviewed by Žan Doberšek.
304
305         * Scripts/webkitpy/port/wpe.py:
306         (WPEPort.show_results_html_file):
307
308 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
309
310         [WPE] MiniBrowser: add ky bindings for back/forward navigation
311         https://bugs.webkit.org/show_bug.cgi?id=194151
312
313         Reviewed by Žan Doberšek.
314
315         ALT + <- go back
316         ALT + -> go forward
317
318         * MiniBrowser/wpe/main.cpp:
319         (main):
320
321 2019-02-01  Zalan Bujtas  <zalan@apple.com>
322
323         [LFC] Set intrinsic size on Layout::Replaced
324         https://bugs.webkit.org/show_bug.cgi?id=194139
325
326         Reviewed by Antti Koivisto.
327
328         744
329
330         * LayoutReloaded/misc/LFC-passing-tests.txt:
331
332 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
333
334         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
335         https://bugs.webkit.org/show_bug.cgi?id=194146
336
337         Reviewed by Xabier Rodriguez-Calvar.
338
339         It allows to open relative paths.
340
341         * MiniBrowser/wpe/main.cpp:
342         (main):
343
344 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
345
346         Update flakiness dashboard configuration after recent queue changes
347         https://bugs.webkit.org/show_bug.cgi?id=194127
348
349         Rubber-stamped by Aakash Jain.
350
351         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
352
353         * TestResultServer/static-dashboards/builders.jsonp:
354
355 2019-01-31  Youenn Fablet  <youenn@apple.com>
356
357         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
358         https://bugs.webkit.org/show_bug.cgi?id=194106
359         <rdar://problem/47676333>
360
361         Reviewed by Ryosuke Niwa.
362
363         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
364         (TestWebKitAPI::didFinishNavigation):
365         (TestWebKitAPI::TEST):
366         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
367
368 2019-01-31  Chris Dumez  <cdumez@apple.com>
369
370         Page zoom level is lost after a process swap or a crash
371         https://bugs.webkit.org/show_bug.cgi?id=194105
372         <rdar://problem/47610781>
373
374         Reviewed by Alex Christensen.
375
376         Add API test coverage.
377
378         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
379         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
380
381 2019-01-31  Alex Christensen  <achristensen@webkit.org>
382
383         Revert r238819 which is unneeded and caused a performance regression.
384         https://bugs.webkit.org/show_bug.cgi?id=192272
385         <rdar://problem/46664625>
386
387         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
388         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
389         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
390
391 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
392
393         Formalize WebKitAdditions mechanism of LoadOptimizer
394         https://bugs.webkit.org/show_bug.cgi?id=193886
395         <rdar://problem/47696809>
396
397         Reviewed by Brent Fulgham.
398
399         * MiniBrowser/MiniBrowser.entitlements:
400         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
401
402 2019-01-31  Zalan Bujtas  <zalan@apple.com>
403
404         [LFC] Margin before/after/start/end initial value is 0 and not auto.
405         https://bugs.webkit.org/show_bug.cgi?id=194090
406
407         Reviewed by Antti Koivisto.
408
409         * LayoutReloaded/misc/LFC-passing-tests.txt:
410
411 2019-01-31  Zalan Bujtas  <zalan@apple.com>
412
413         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
414         https://bugs.webkit.org/show_bug.cgi?id=194074
415
416         Reviewed by Antti Koivisto.
417
418         * LayoutReloaded/misc/LFC-passing-tests.txt:
419
420 2019-01-31  Zalan Bujtas  <zalan@apple.com>
421
422         [LFC][BFC] Add support for block level replaced box.
423         https://bugs.webkit.org/show_bug.cgi?id=194071
424
425         Reviewed by Antti Koivisto.
426
427         * LayoutReloaded/misc/LFC-passing-tests.txt:
428
429 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
430
431         Fix WebKitTestRunner's testPath with Windows full paths
432         https://bugs.webkit.org/show_bug.cgi?id=194012
433
434         Reviewed by Alex Christensen.
435
436         updateTestOptionsFromTestHeader failed to open test files because
437         testPath returned wrong file paths. It returned a path "/C:/..."
438         if a URL "file:///C:/..." was given.
439
440         * WebKitTestRunner/TestController.cpp:
441         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
442
443 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
444
445         [WPE] Bump font related dependencies to match the GTK+ port
446         https://bugs.webkit.org/show_bug.cgi?id=194017
447
448         Reviewed by Žan Doberšek.
449
450         * wpe/jhbuild.modules:
451         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
452         * wpe/patches/icudata-stdlibs.patch: Added.
453
454 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
455
456         Enable swipe tests on iOS
457         https://bugs.webkit.org/show_bug.cgi?id=194076
458
459         Reviewed by Geoffrey Garen.
460
461         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
462         it causes a debug assertion failure in runUIScript.
463
464         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
465         (WTR::UIScriptController::beginBackSwipe):
466         (WTR::UIScriptController::completeBackSwipe):
467
468 2019-01-30  Keith Rollin  <krollin@apple.com>
469
470         Use correct printf format specifier
471         https://bugs.webkit.org/show_bug.cgi?id=194062
472         <rdar://problem/47686167>
473
474         Reviewed by Alexey Proskuryakov.
475
476         LayoutTestSpellChecker.mm is trying to format a variable of type
477         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
478         actually an unsigned long long. Fix this by formatting with %llu.
479
480         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
481         (-[LayoutTestTextCheckingResult description]):
482
483 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
484
485         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
486         https://bugs.webkit.org/show_bug.cgi?id=193979
487
488         Reviewed by Wenson Hsieh.
489
490         Fix the test for iOS. Make the test work with iOS UA string.
491
492         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
493
494 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
495
496         Replace High Sierra LLINT CLoop bot due to hardware failure
497         https://bugs.webkit.org/show_bug.cgi?id=194066
498
499         Reviewed by Aakash Jain.
500
501         * BuildSlaveSupport/build.webkit.org-config/config.json:
502
503 2019-01-30  Keith Rollin  <krollin@apple.com>
504
505         [NSDragItem init] is unavailable
506         https://bugs.webkit.org/show_bug.cgi?id=194059
507         <rdar://problem/47685715>
508
509         Reviewed by Wenson Hsieh.
510
511         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
512         DumpRenderTree and TestWebKitAPI, which both try to create an
513         NSDragItem in a manner that invokes this method. Address this by using
514         -initWithPasteboardWriter instead.
515
516         Note that the parameter passed to initWithPasteboardWriter is likely
517         incorrect. In both cases, the object passed does not conform to
518         NSPasteboardWriting. However, with this fix, we're no worse off than
519         before, and can now perform builds with newer compilers and SDKs until
520         a real fix can be crafted. That work is tracked in
521         https://bugs.webkit.org/show_bug.cgi?id=194060
522
523         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
524         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
525         * TestWebKitAPI/mac/TestDraggingInfo.mm:
526         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
527
528 2019-01-30  Daniel Bates  <dabates@apple.com>
529
530         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
531         https://bugs.webkit.org/show_bug.cgi?id=192824
532         <rdar://problem/47100332>
533
534         Reviewed by Wenson Hsieh.
535
536         Fix a bug where the wrong usage code was used for F13 thru F24.
537
538         * WebKitTestRunner/ios/HIDEventGenerator.mm:
539         (keyCodeForDOMFunctionKey):
540
541 2019-01-30  Chris Dumez  <cdumez@apple.com>
542
543         Regression(PSON) Load hang can occur on history navigation
544         https://bugs.webkit.org/show_bug.cgi?id=194030
545         <rdar://problem/47656939>
546
547         Reviewed by Antti Koivisto.
548
549         Add API test coverage.
550
551         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
552
553 2019-01-30  Zalan Bujtas  <zalan@apple.com>
554
555         [LFC] Expand tests coverage.
556
557         Unreviewed test gardening.
558
559         * LayoutReloaded/misc/LFC-passing-tests.txt:
560
561 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
562
563         [Flatpak] Add openjpeg support
564         https://bugs.webkit.org/show_bug.cgi?id=194019
565
566         Reviewed by Michael Catanzaro.
567
568         * flatpak/org.webkit.CommonModules.yaml:
569
570 2019-01-30  Commit Queue  <commit-queue@webkit.org>
571
572         Unreviewed, rolling out r240708.
573         https://bugs.webkit.org/show_bug.cgi?id=194022
574
575         It broke WPE build (Requested by KaL on #webkit).
576
577         Reverted changeset:
578
579         "[WPE] Bump font related dependencies to match the GTK+ port"
580         https://bugs.webkit.org/show_bug.cgi?id=194017
581         https://trac.webkit.org/changeset/240708
582
583 2019-01-30  Zalan Bujtas  <zalan@apple.com>
584
585         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
586         https://bugs.webkit.org/show_bug.cgi?id=194001
587
588         Reviewed by Antti Koivisto.
589
590         * LayoutReloaded/misc/LFC-passing-tests.txt:
591
592 2019-01-30  Zalan Bujtas  <zalan@apple.com>
593
594         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
595         https://bugs.webkit.org/show_bug.cgi?id=194020
596
597         Reviewed by Antti Koivisto.
598
599         * LayoutReloaded/misc/LFC-passing-tests.txt:
600
601 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
602
603         AX: Support color well on iOS
604         https://bugs.webkit.org/show_bug.cgi?id=194010
605
606         Reviewed by Joanmarie Diggs.
607
608         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
609         (WTR::AccessibilityUIElement::stringAttributeValue):
610
611 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
612
613         [WPE] Bump font related dependencies to match the GTK+ port
614         https://bugs.webkit.org/show_bug.cgi?id=194017
615
616         Reviewed by Žan Doberšek.
617
618         * wpe/jhbuild.modules:
619         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
620         * wpe/patches/icudata-stdlibs.patch: Added.
621
622 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
623
624         [Mac] Update window scale API usage
625         https://bugs.webkit.org/show_bug.cgi?id=193991
626         rdar://problem/47614795
627
628         Reviewed by Tim Horton.
629
630         * DumpRenderTree/mac/DumpRenderTree.mm:
631         (changeWindowScaleIfNeeded):
632         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
633         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
634         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
635
636 2019-01-29  Chris Dumez  <cdumez@apple.com>
637
638         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
639         https://bugs.webkit.org/show_bug.cgi?id=193977
640         <rdar://problem/47643716>
641
642         Reviewed by Geoff Garen.
643
644         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
645         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
646         to the previous provisional committing *before* we make the last load. 
647
648         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
649
650 2019-01-29  Youenn Fablet  <youenn@apple.com>
651
652         Adopt new SPI to evaluate server certificate trust
653         https://bugs.webkit.org/show_bug.cgi?id=193355
654
655         Reviewed by Alex Christensen.
656
657         Add infrastructure to handle HTTPS server trust evaluation testing.
658
659         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
660         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
661         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
662         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
663         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
664         * WebKitTestRunner/InjectedBundle/TestRunner.h:
665         * WebKitTestRunner/TestController.cpp:
666         (WTR::TestController::resetPreferencesToConsistentValues):
667         (WTR::TestController::didReceiveAuthenticationChallenge):
668         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
669         * WebKitTestRunner/TestController.h:
670         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
671         * WebKitTestRunner/TestInvocation.cpp:
672         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
673         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
674         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
675
676 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
677
678         [ews-build] Add build step to print bot Configuration
679         https://bugs.webkit.org/show_bug.cgi?id=193887
680
681         Reviewed by Lucas Forschler.
682
683         * BuildSlaveSupport/ews-build/steps.py:
684         (PrintConfiguration): Build step to print configuration.
685         * BuildSlaveSupport/ews-build/factories.py:
686
687 2019-01-29  Chris Dumez  <cdumez@apple.com>
688
689         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
690         https://bugs.webkit.org/show_bug.cgi?id=193967
691         <rdar://problem/47635348>
692
693         Reviewed by Alex Christensen.
694
695         Add API test coverage.
696
697         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
698         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
699
700 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
701
702         [ews-app] Handle incoming results data
703         https://bugs.webkit.org/show_bug.cgi?id=193973
704
705         Reviewed by Lucas Forschler.
706
707         * BuildSlaveSupport/ews-app/ews/views/results.py:
708
709 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
710
711         [ews-app] Make the results url generic
712         https://bugs.webkit.org/show_bug.cgi?id=193928
713
714         Reviewed by Lucas Forschler.
715
716         * BuildSlaveSupport/ews-app/ews/urls.py:
717
718 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
719
720         [ews-build] Configure buildbot to send events to ews-app
721         https://bugs.webkit.org/show_bug.cgi?id=193968
722
723         Reviewed by Lucas Forschler.
724
725         * BuildSlaveSupport/ews-build/events.py: Added.
726         * BuildSlaveSupport/ews-build/master.cfg:
727
728 2019-01-29  Keith Rollin  <krollin@apple.com>
729
730         Add .xcfilelists to Run Script build phases
731         https://bugs.webkit.org/show_bug.cgi?id=193792
732         <rdar://problem/47201785>
733
734         Reviewed by Alex Christensen.
735
736         As part of supporting XCBuild, update the necessary Run Script build
737         phases in their Xcode projects to refer to their associated
738         .xcfilelist files.
739
740         Note that the addition of these files bumps the Xcode project version
741         number to something that's Xcode 10 compatible. This change means that
742         older versions of the Xcode IDE can't read these projects. Nor can it
743         fully load workspaces that refer to these projects (the updated
744         projects are shown as non-expandable placeholders). `xcodebuild` can
745         still build these projects; it's just that the IDE can't open them.
746
747         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
748         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
749
750 2019-01-29  John Wilander  <wilander@apple.com>
751
752         Add data abstraction and validation for Ad Click Attribution
753         https://bugs.webkit.org/show_bug.cgi?id=193916
754         <rdar://problem/47603481>
755
756         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
757
758         Ad click attribution has two steps. First, the storage of an ad
759         campaign ID for a click that takes the user to a destination
760         site. Second, a conversion on the destination site that can be
761         attributed to the ad click.
762
763         This patch adds a class that represents a request for ad click
764         attribution. Validation makes sure that the bits of entropy
765         reported through this mechanism is limited.
766
767         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
768         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
769         (TestWebKitAPI::TEST):
770
771 2019-01-29  Chris Dumez  <cdumez@apple.com>
772
773         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
774         https://bugs.webkit.org/show_bug.cgi?id=193932
775         <rdar://problem/47598947>
776
777         Reviewed by Brady Eidson.
778
779         Add API test coverage.
780
781         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
782
783 2019-01-29  Zalan Bujtas  <zalan@apple.com>
784
785         Adding new passing LFC tests.
786
787         Unreviewed test gardening.
788
789         * LayoutReloaded/misc/LFC-passing-tests.txt:
790
791 2019-01-29  Zalan Bujtas  <zalan@apple.com>
792
793         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
794         https://bugs.webkit.org/show_bug.cgi?id=193964
795
796         Reviewed by Antti Koivisto.
797
798         * LayoutReloaded/misc/LFC-passing-tests.txt:
799
800 2019-01-29  Zalan Bujtas  <zalan@apple.com>
801
802         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
803         https://bugs.webkit.org/show_bug.cgi?id=193954
804
805         Reviewed by Antti Koivisto.
806
807         * LayoutReloaded/misc/LFC-passing-tests.txt:
808
809 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
810
811         WebDriver: add support for running subtests
812         https://bugs.webkit.org/show_bug.cgi?id=193904
813
814         Reviewed by Michael Catanzaro.
815
816         pytest already supports it by passing test.py::subtest, so we can do the same.
817
818         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
819         (get_item_name): Made this global.
820         (CollectRecorder.__init__): Receive the parameter to ignore.
821         (CollectRecorder.pytest_collectreport): Collect also the subtests.
822         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
823         (collect): Add parameter to ignore.
824         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
825         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
826         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
827         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
828         (WebDriverTestRunnerSelenium.run): Ditto.
829         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
830         (WebDriverTestRunnerW3C.collect_tests): Ditto.
831         (WebDriverTestRunnerW3C.run): Ditto.
832
833 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
834
835         User agent string override for navigator.userAgent should be site specific quirks
836         https://bugs.webkit.org/show_bug.cgi?id=193950
837
838         Reviewed by Brent Fulgham.
839
840         Updated per the _WKWebsitePolicies rename.
841
842         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
843         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
844
845 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
846
847         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
848         https://bugs.webkit.org/show_bug.cgi?id=193941
849
850         Reviewed by Alex Christensen.
851
852         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
853         * TestWebKitAPI/Tests/WTF/Condition.cpp:
854         * TestWebKitAPI/Tests/WTF/Lock.cpp:
855         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
856         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
857         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
858         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
859         * TestWebKitAPI/Tests/WTF/Time.cpp:
860         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
861         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
862         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
863         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
864
865 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
866
867         Unreviewed, reorder my emails to fix autocomplete in bugzilla
868
869         * Scripts/webkitpy/common/config/contributors.json:
870
871 2019-01-28  Andy Estes  <aestes@apple.com>
872
873         [watchOS] Enable Parental Controls content filtering
874         https://bugs.webkit.org/show_bug.cgi?id=193939
875         <rdar://problem/46641912>
876
877         Reviewed by Ryosuke Niwa.
878
879         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
880
881 2019-01-28  David Kilzer  <ddkilzer@apple.com>
882
883         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
884         <https://webkit.org/b/193884>
885
886         Reviewed by Jiewen Tan.
887
888         * Scripts/webkitpy/style/checkers/cpp.py:
889         (check_language): Add LocalAuthentication to
890         `frameworks_with_soft_links`.
891
892 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
893
894         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
895         https://bugs.webkit.org/show_bug.cgi?id=193891
896
897         Reviewed by Ross Kirsling.
898
899         There were three problems in window sizes of WebView and the host window.
900         1. The sizes of pixel image output were incorrect.
901         2. The host window is going to appear after window.resize was invoked.
902         3. window.resize resized only the host window, not WebView.
903
904         This change solves them with a following approach.
905         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
906         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
907            as well as DumpRenderTree in order to match the client area and the window area.
908         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
909         d. PlatformWebView::setWindowFrame changes both window sizes.
910         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
911
912         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
913         (WTR::PlatformWebView::PlatformWebView): Create the host window
914         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
915         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
916         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
917
918 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
919
920         [ews-app] Add method to save Step data to database
921         https://bugs.webkit.org/show_bug.cgi?id=193890
922
923         Reviewed by Lucas Forschler.
924
925         * BuildSlaveSupport/ews-app/ews/models/step.py:
926         (Step.save_step): Method to save step data.
927         (Step.update_step): Method to update step data.
928         (Step.get_existing_step): Method to fetch existing step from database.
929         (Step.is_valid_result): Method to validate valid step result.
930
931 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
932
933         [ews-app] Add method to save Build data to database
934         https://bugs.webkit.org/show_bug.cgi?id=193735
935
936         Reviewed by Lucas Forschler.
937
938         * BuildSlaveSupport/ews-app/ews/models/build.py:
939         (Build.save_build): Method to save build information to database.
940         (Build.get_existing_build): Method to fetch existing build from database.
941         (Build.is_valid_result): Method to validate build result.
942         * BuildSlaveSupport/ews-app/ews/common/util.py:
943         (is_valid_int_id): Method to validate valid id.
944
945 2019-01-28  Chris Dumez  <cdumez@apple.com>
946
947         Regression(PSON) Crash under WebPageProxy::didStartProgress()
948         https://bugs.webkit.org/show_bug.cgi?id=193915
949         <rdar://problem/47560907>
950
951         Reviewed by Alex Christensen.
952
953         Add API test coverage.
954
955         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
956
957 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
958
959         [ews-app] Rename id variables
960         https://bugs.webkit.org/show_bug.cgi?id=193883
961
962         Reviewed by Lucas Forschler.
963
964         * BuildSlaveSupport/ews-app/ews/models/build.py:
965         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
966         * BuildSlaveSupport/ews-app/ews/models/step.py:
967         * BuildSlaveSupport/ews-app/ews/urls.py:
968         * BuildSlaveSupport/ews-app/ews/views/patch.py:
969         * BuildSlaveSupport/ews-app/ews/views/results.py:
970         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
971
972 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
973
974         [ews-app] Allow certain fields to be empty
975         https://bugs.webkit.org/show_bug.cgi?id=193892
976
977         Reviewed by Lucas Forschler.
978
979         * BuildSlaveSupport/ews-app/ews/models/build.py:
980         * BuildSlaveSupport/ews-app/ews/models/step.py:
981
982 2019-01-28  Rob Buis  <rbuis@igalia.com>
983
984         Update MIME type parser
985         https://bugs.webkit.org/show_bug.cgi?id=180526
986
987         Reviewed by Frédéric Wang.
988
989         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
990         (TestWebKitAPI::TEST):
991
992 2019-01-28  Zalan Bujtas  <zalan@apple.com>
993
994         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
995         https://bugs.webkit.org/show_bug.cgi?id=193896
996
997         Reviewed by Antti Koivisto.
998
999         * LayoutReloaded/misc/LFC-passing-tests.txt:
1000
1001 2018-12-15  Darin Adler  <darin@apple.com>
1002
1003         Replace many uses of String::format with more type-safe alternatives
1004         https://bugs.webkit.org/show_bug.cgi?id=192742
1005
1006         Reviewed by Mark Lam.
1007
1008         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1009         (WTR::cacheTestRunnerCallback): Use makeString.
1010         * WebKitTestRunner/TestController.cpp:
1011         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
1012         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
1013
1014 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
1015
1016         Use a load optimizer for some sites
1017         https://bugs.webkit.org/show_bug.cgi?id=193881
1018         <rdar://problem/46325455>
1019
1020         Reviewed by Brent Fulgham.
1021
1022         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1023         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
1024
1025 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
1026
1027         AX: Introduce a static accessibility tree
1028         https://bugs.webkit.org/show_bug.cgi?id=193348
1029         <rdar://problem/47203295>
1030
1031         Reviewed by Ryosuke Niwa.
1032
1033         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1034
1035 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1036
1037         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
1038         https://bugs.webkit.org/show_bug.cgi?id=193867
1039
1040         Reviewed by Antti Koivisto.
1041
1042         * LayoutReloaded/misc/LFC-passing-tests.txt:
1043
1044 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1045
1046         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
1047         https://bugs.webkit.org/show_bug.cgi?id=193865
1048
1049         Reviewed by Antti Koivisto.
1050
1051         * LayoutReloaded/misc/LFC-passing-tests.txt:
1052
1053 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1054
1055         Need a mechanism to override navigator.userAgent
1056         https://bugs.webkit.org/show_bug.cgi?id=193762
1057         <rdar://problem/47504939>
1058
1059         Reviewed by Brent Fulgham.
1060
1061         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
1062
1063         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1064         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1065         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
1066
1067 2019-01-25  Dean Jackson  <dino@apple.com>
1068
1069         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
1070         https://bugs.webkit.org/show_bug.cgi?id=193831
1071         <rdar://problem/47399263>
1072
1073         Reviewed by Chris Dumez.
1074
1075         Two new tests that exercise cross-origin and same-origin System
1076         Previews.
1077
1078         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1079
1080 2019-01-25  Keith Rollin  <krollin@apple.com>
1081
1082         Update Xcode projects with "Check .xcfilelists" build phase
1083         https://bugs.webkit.org/show_bug.cgi?id=193790
1084         <rdar://problem/47201374>
1085
1086         Reviewed by Alex Christensen.
1087
1088         Support for XCBuild includes specifying inputs and outputs to various
1089         Run Script build phases. These inputs and outputs are specified as
1090         .xcfilelist files. Once created, these .xcfilelist files need to be
1091         kept up-to-date. In order to check that they are up-to-date or not,
1092         add an Xcode build step that invokes an external script that performs
1093         the checking. If the .xcfilelists are found to be out-of-date, update
1094         them, halt the build, and instruct the developer to restart the build
1095         with up-to-date files.
1096
1097         At this time, the checking and regenerating is performed only if the
1098         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
1099         who want to use this facility can set this variable and test out the
1100         checking/regenerating. Once it seems like there are no egregious
1101         issues that upset a developer's workflow, we'll unconditionally enable
1102         this facility.
1103
1104         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1105         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
1106         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
1107         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1108
1109 2019-01-25  Keith Rollin  <krollin@apple.com>
1110
1111         Update Xcode projects with "Apply Configuration to XCFileLists" build target
1112         https://bugs.webkit.org/show_bug.cgi?id=193781
1113         <rdar://problem/47201153>
1114
1115         Reviewed by Alex Christensen.
1116
1117         Part of generating the .xcfilelists used as part of adopting XCBuild
1118         includes running `make DerivedSources.make` from a standalone script.
1119         It’s important for this invocation to have the same environment as
1120         when the actual build invokes `make DerivedSources.make`. If the
1121         environments are different, then the two invocations will provide
1122         different results. In order to get the same environment in the
1123         standalone script, have the script launch xcodebuild targeting the
1124         "Apply Configuration to XCFileLists" build target, which will then
1125         re-invoke our standalone script. The script is now running again, this
1126         time in an environment with all workspace, project, target, xcconfig
1127         and other environment variables established.
1128
1129         The "Apply Configuration to XCFileLists" build target accomplishes
1130         this task via a small embedded shell script that consists only of:
1131
1132             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
1133
1134         The process that invokes "Apply Configuration to XCFileLists" first
1135         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
1136         evaluated and exports it into the shell environment. When xcodebuild
1137         is invoked, it inherits the value of this variable and can `eval` the
1138         contents of that variable. Our external standalone script can then set
1139         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
1140         of command-line parameters needed to restart itself in the appropriate
1141         state.
1142
1143         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1144         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1145
1146 2019-01-25  Alex Christensen  <achristensen@webkit.org>
1147
1148         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
1149         https://bugs.webkit.org/show_bug.cgi?id=193802
1150         <rdar://problem/46010580>
1151
1152         Reviewed by Andy Estes.
1153
1154         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1155         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
1156         (TEST):
1157
1158 2019-01-25  Daniel Bates  <dabates@apple.com>
1159
1160         [iOS] uiController.keyDown() does not translate Control modified key
1161         https://bugs.webkit.org/show_bug.cgi?id=192898
1162
1163         Reviewed by Wenson Hsieh.
1164
1165         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
1166         key translation, as applicable. Among other cases, key translation occurs when performing
1167         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
1168         also makes the behavior of uiController.keyDown() more closely match the behavior of a
1169         human pressing down and releasing key(s) using a hardware keyboard.
1170
1171         * WebKitTestRunner/ios/HIDEventGenerator.h:
1172         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1173         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
1174
1175         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
1176         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
1177         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1178         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1179         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
1180         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1181         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
1182         (-[HIDEventGenerator longPress:completionBlock:]):
1183         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
1184         Update code for above renaming.
1185
1186         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
1187         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
1188
1189         (-[HIDEventGenerator keyDown:]): Added.
1190         (-[HIDEventGenerator keyUp:]): Added.
1191         (-[HIDEventGenerator keyPress:completionBlock:]):
1192         (-[HIDEventGenerator eventDispatchThreadEntry:]):
1193         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
1194         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1195         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
1196         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
1197         (WTR::parseModifier): Deleted.
1198
1199 2019-01-25  Keith Rollin  <krollin@apple.com>
1200
1201         Complete the implementation of generate-xcfilelists
1202         https://bugs.webkit.org/show_bug.cgi?id=193782
1203
1204         Reviewed by Alex Christensen.
1205
1206         A preliminary version of generate-xcfilelists was added in r238008.
1207         This patch updates that script in order to:
1208
1209         - Support checking of .xcfilelists
1210         - Perform better execution of `make DerivedSources.make` by
1211           relaunching generate-xcfilelists under xcodebuild
1212         - Support incremental generation and checking of .xcfilelists
1213         - Support supplementary .xcfilelists files from WebKitAdditions
1214         - Support being wrapped by parallel version of generate-xcfilelists in
1215           Internal that adds support for (re)generating WebKit projects in
1216           that repo.
1217         - Support builds that have been performed in WebKitBuild as well as
1218           ~/Library/Developer/code/DerivedData
1219         - Increase robustness and debugging facilities.
1220
1221         * Scripts/generate-xcfilelists:
1222
1223 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
1224
1225         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1226         https://bugs.webkit.org/show_bug.cgi?id=193297
1227         <rdar://problem/47158841>
1228
1229         Unreviewed test case fix.
1230
1231         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
1232         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
1233
1234         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1235         (TEST):
1236
1237 2019-01-25  Keith Rollin  <krollin@apple.com>
1238
1239         Update existing .xcfilelists
1240         https://bugs.webkit.org/show_bug.cgi?id=193791
1241         <rdar://problem/47201706>
1242
1243         Reviewed by Alex Christensen.
1244
1245         Many .xcfilelist files were added in r238824 in order to support
1246         XCBuild. Update these with recent changes to the set of build files
1247         and with the current generate-xcfilelist script.
1248
1249         * DumpRenderTree/DerivedSources-input.xcfilelist:
1250         * DumpRenderTree/DerivedSources-output.xcfilelist:
1251         * WebKitTestRunner/DerivedSources-input.xcfilelist:
1252         * WebKitTestRunner/DerivedSources-output.xcfilelist:
1253
1254 2019-01-25  Keith Rollin  <krollin@apple.com>
1255
1256         Fix missing dependencies in extract-dependencies-from-makefile
1257         https://bugs.webkit.org/show_bug.cgi?id=193783
1258         <rdar://problem/47201571>
1259
1260         Reviewed by Alex Christensen.
1261
1262         The extract-dependencies-from-makefile script generates .xcfilelists
1263         for XCBuild by invoking a makefile in --debug mode, parsing the
1264         dependency information in the output, and extracting information
1265         regarding targets and dependents. However, the way `make` emits this
1266         dependency information is not rigorous, and so we need to determine
1267         what lines to look for and parse by trial and error. This approach
1268         didn't coriginally atch all the information we needed to collect, so
1269         update the script to look for the additional lines we now know to look
1270         for.
1271
1272         * Scripts/extract-dependencies-from-makefile:
1273         (Parser):
1274         (Parser.addTarget):
1275         (Parser.addPrereq):
1276         (Parser.doParse):
1277
1278 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
1279
1280         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1281         https://bugs.webkit.org/show_bug.cgi?id=193297
1282         <rdar://problem/47158841>
1283
1284         Reviewed by Alex Christensen.
1285
1286         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
1287             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
1288         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1289         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
1290         activating the message used to trigger the callback when it is set.
1291
1292 2019-01-25  Alex Christensen  <achristensen@webkit.org>
1293
1294         WKWebView.goBack should reload if there is a safe browsing warning
1295         https://bugs.webkit.org/show_bug.cgi?id=193805
1296         <rdar://problem/46908216>
1297
1298         Reviewed by Geoff Garen.
1299
1300         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1301         (+[Simple3LookupContext sharedLookupContext]):
1302         (-[Simple3LookupContext lookUpURL:completionHandler:]):
1303         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
1304         (TEST):
1305
1306 2019-01-25  Chris Dumez  <cdumez@apple.com>
1307
1308         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
1309         https://bugs.webkit.org/show_bug.cgi?id=193788
1310         <rdar://problem/47531231>
1311
1312         Reviewed by Alex Christensen.
1313
1314         Add API test coverage.
1315
1316         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1317         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1318
1319 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
1320
1321         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
1322         https://bugs.webkit.org/show_bug.cgi?id=193771
1323
1324         Unreviewed infrastructure fix.
1325
1326         * Scripts/webkitpy/port/darwin.py:
1327         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
1328
1329 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
1330
1331         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
1332
1333 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
1334
1335         Add contributors.json entries for Ling Ho and for a new bot watchers group.
1336
1337         * Scripts/webkitpy/common/config/contributors.json:
1338
1339 2019-01-25  Chris Dumez  <cdumez@apple.com>
1340
1341         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
1342         https://bugs.webkit.org/show_bug.cgi?id=193779
1343         <rdar://problem/46170903>
1344
1345         Reviewed by Antti Koivisto.
1346
1347         Add API test that quickly navigates forward to a previous process without waiting for it to
1348         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
1349         the process' previous page when reconnecting the it for the forward navigation.
1350
1351         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1352
1353 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1354
1355         Need a way for JavaScript (or bundle) code to participate in undo
1356         https://bugs.webkit.org/show_bug.cgi?id=190009
1357         <rdar://problem/44807048>
1358
1359         Reviewed by Ryosuke Niwa.
1360
1361         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
1362         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
1363
1364         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1365         (WTR::UIScriptController::lastUndoLabel const):
1366         (WTR::UIScriptController::firstRedoLabel const):
1367         (WTR::UIScriptController::platformUndoManager const):
1368         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1369         (WTR::UIScriptController::lastUndoLabel const):
1370         (WTR::UIScriptController::firstRedoLabel const):
1371         (WTR::UIScriptController::platformUndoManager const):
1372         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1373         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1374         (WTR::UIScriptController::lastUndoLabel const):
1375         (WTR::UIScriptController::firstRedoLabel const):
1376         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1377         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1378         (WTR::UIScriptController::lastUndoLabel const):
1379         (WTR::UIScriptController::firstRedoLabel const):
1380         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1381         (WTR::UIScriptController::platformUndoManager const):
1382         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1383         (WTR::UIScriptController::platformUndoManager const):
1384
1385 2019-01-25  Zalan Bujtas  <zalan@apple.com>
1386
1387         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
1388         https://bugs.webkit.org/show_bug.cgi?id=193824
1389
1390         Reviewed by Antti Koivisto.
1391
1392         * LayoutReloaded/misc/LFC-passing-tests.txt:
1393
1394 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
1395
1396         Update macOS JSC bot configurations
1397         https://bugs.webkit.org/show_bug.cgi?id=193739
1398
1399         Reviewed by Alexey Proskuryakov.
1400
1401         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
1402         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1403         (BubbleQueueServer): Move JSC EWS to Mojave section.
1404         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1405         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
1406         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
1407
1408 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
1409
1410         [Win][WebKitTestRunner] Implement EventSenderProxy
1411         https://bugs.webkit.org/show_bug.cgi?id=193755
1412
1413         Reviewed by Don Olmstead.
1414
1415         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
1416         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
1417         (WTR::EventSenderProxy::dispatchMessage):
1418         (WTR::EventSenderProxy::EventSenderProxy):
1419         (WTR::EventSenderProxy::mouseDown):
1420         (WTR::EventSenderProxy::mouseUp):
1421         (WTR::EventSenderProxy::mouseMoveTo):
1422         (WTR::EventSenderProxy::mouseScrollBy):
1423         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
1424
1425 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
1426
1427         Unreviewed fix for API test failure after r240437.
1428
1429         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
1430
1431         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
1432
1433 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
1434
1435         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
1436         https://bugs.webkit.org/show_bug.cgi?id=193787
1437         <rdar://problem/47497634>
1438
1439         Reviewed by Alexey Proskuryakov.
1440
1441         * Scripts/webkitdirs.pm:
1442         (iosSimulatorApplicationsPath): Pick from available runtime directories.
1443
1444 2019-01-24  Truitt Savell  <tsavell@apple.com>
1445
1446         Unreviewed, rolling out r240446.
1447
1448         Casued 5 API failures
1449
1450         Reverted changeset:
1451
1452         "Activate the WebResourceLoadStatisticsStore in the
1453         NetworkProcess and deactivate it in the UIProcess."
1454         https://bugs.webkit.org/show_bug.cgi?id=193297
1455         https://trac.webkit.org/changeset/240446
1456
1457 2019-01-24  Zalan Bujtas  <zalan@apple.com>
1458
1459         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
1460         https://bugs.webkit.org/show_bug.cgi?id=193741
1461         <rdar://problem/47135030>
1462
1463         Reviewed by Antti Koivisto and Simon Fraser.
1464
1465         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1466         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
1467         (TestWebKitAPI::TEST):
1468
1469 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
1470
1471         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1472         https://bugs.webkit.org/show_bug.cgi?id=193297
1473         <rdar://problem/47158841>
1474
1475         Reviewed by Alex Christensen.
1476
1477         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1478         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
1479         activating the message used to trigger the callback when it is set.
1480
1481 2019-01-24  John Wilander  <wilander@apple.com>
1482
1483         Add Ad Click Attribution as an internal/experimental feature
1484         https://bugs.webkit.org/show_bug.cgi?id=193685
1485         <rdar://problem/47450399>
1486
1487         Reviewed by Brent Fulgham.
1488
1489         Added test option adClickAttributionEnabled.
1490
1491         * DumpRenderTree/TestOptions.cpp:
1492         (TestOptions::TestOptions):
1493         * DumpRenderTree/TestOptions.h:
1494         * DumpRenderTree/mac/DumpRenderTree.mm:
1495         (setWebPreferencesForTestOptions):
1496
1497 2019-01-24  Antti Koivisto  <antti@apple.com>
1498
1499         [PSON] Flash on back navigation on Mac
1500         https://bugs.webkit.org/show_bug.cgi?id=193716
1501         <rdar://problem/47148458>
1502
1503         Reviewed by Chris Dumez.
1504
1505         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1506
1507         Closing of the previous page is delayed so waiting for didFinishNavigation is
1508         not sufficient to guarantee we have received all the messages. Wait for them.
1509
1510 2019-01-24  Chris Dumez  <cdumez@apple.com>
1511
1512         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
1513         https://bugs.webkit.org/show_bug.cgi?id=193761
1514         <rdar://problem/47456405>
1515
1516         Reviewed by Alex Christensen.
1517
1518         Add API test coverage.
1519
1520         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1521
1522 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
1523
1524         webkitpy: Missing PID in crashlog name should not be fatal
1525         https://bugs.webkit.org/show_bug.cgi?id=193771
1526
1527         If we can't determine the PID of a crashlog, just ignore the crashlog instead
1528         of raising an exception.
1529
1530         Reviewed by Lucas Forschler.
1531
1532         * Scripts/webkitpy/port/darwin.py:
1533         (DarwinPort._merge_crash_logs):
1534
1535 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1536
1537         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
1538         https://bugs.webkit.org/show_bug.cgi?id=193746
1539
1540         Reviewed by Youenn Fablet.
1541
1542         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
1543         so we'd best just not call it.
1544
1545         * Scripts/webkitpy/w3c/test_exporter.py:
1546         (WebPlatformTestExporter.create_branch_with_patch):
1547
1548 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
1549
1550         Move FileSystem to WTF
1551         https://bugs.webkit.org/show_bug.cgi?id=193602
1552
1553         Reviewed by Yusuke Suzuki.
1554
1555         * DumpRenderTree/win/DumpRenderTree.cpp:
1556         * TestWebKitAPI/CMakeLists.txt:
1557         * TestWebKitAPI/PlatformGTK.cmake:
1558         * TestWebKitAPI/PlatformJSCOnly.cmake:
1559         * TestWebKitAPI/PlatformPlayStation.cmake:
1560         * TestWebKitAPI/PlatformWPE.cmake:
1561         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1562         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
1563         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1564         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
1565         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
1566         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
1567         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
1568         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1569         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
1570         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1571
1572 2019-01-24  Philippe Normand  <pnormand@igalia.com>
1573
1574         [WPE] Remove hard dependency on subprocess32 for the API tests
1575
1576         Rubber-stamped by Carlos Garcia Campos.
1577
1578         * glib/api_test_runner.py:
1579         (TestRunner._run_test_qt): Lazily import subprocess32 and check
1580         its presence only when running WPEQt tests.
1581
1582 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1583
1584         [GLIB] Expose JavaScriptCore options in GLib public API
1585         https://bugs.webkit.org/show_bug.cgi?id=188742
1586
1587         Reviewed by Michael Catanzaro.
1588
1589         Add a test for the new API.
1590
1591         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1592         (testsJSCOptions):
1593         (main):
1594
1595 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1596
1597         [GTK][WPE] Support JPEG 2000 images
1598         https://bugs.webkit.org/show_bug.cgi?id=186272
1599
1600         Reviewed by Žan Doberšek.
1601
1602         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
1603
1604         * gtk/jhbuild.modules:
1605         * wpe/jhbuild.modules:
1606
1607 2019-01-23  David Kilzer  <ddkilzer@apple.com>
1608
1609         check-webkit-style should warn when using soft-linking macros in a header
1610         <https://webkit.org/b/193750>
1611
1612         Reviewed by Darin Adler.
1613
1614         * Scripts/webkitpy/style/checkers/cpp.py:
1615         (check_language): Add softlink/header check by refactoring the
1616         softlink/framework check.
1617         (CppChecker): Enable softlink/header check by default.
1618         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1619         (CppStyleTest.test_softlink_framework): Rename from
1620         CppStyleTest.test_softlink() and change test framework name in
1621         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
1622         files. Set file_name for macros that only appear in headers.
1623         (CppStyleTest.test_softlink_header): Add tests for using
1624         soft-link macros in headers.
1625
1626 2019-01-23  Chris Dumez  <cdumez@apple.com>
1627
1628         Deprecate API to limit the maximum number of WebProcesses
1629         https://bugs.webkit.org/show_bug.cgi?id=193725
1630         <rdar://problem/47464879>
1631
1632         Reviewed by Geoff Garen.
1633
1634         Update existing API tests to stop using deprecated API.
1635
1636         * MiniBrowser/mac/AppDelegate.m:
1637         (defaultConfiguration):
1638         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1639         (TestWebKitAPI::TEST):
1640         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
1641         (TestWebKitAPI::TEST):
1642         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1643         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
1644         (TEST):
1645         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1646         (TEST):
1647
1648 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
1649
1650         [ews-app] Rename ews model buildermappings to buildermapping
1651         https://bugs.webkit.org/show_bug.cgi?id=193729
1652
1653         Reviewed by Lucas Forschler.
1654
1655         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
1656         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
1657         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
1658
1659 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
1660
1661         [ews-app] Rename ews model steps to step
1662         https://bugs.webkit.org/show_bug.cgi?id=193697
1663
1664         Reviewed by Lucas Forschler.
1665
1666         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
1667         (Step): Renamed Steps to Step.
1668
1669 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
1670
1671         Clean up IndexedDB files between tests
1672         https://bugs.webkit.org/show_bug.cgi?id=192796
1673         <rdar://problem/46824999>
1674
1675         Reviewed by Geoffrey Garen.
1676
1677         * DumpRenderTree/mac/DumpRenderTree.mm:
1678         (runTest):
1679         * WebKitTestRunner/TestController.cpp:
1680         (WTR::TestController::resetStateToConsistentValues):
1681         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
1682         (WTR::RemoveAllIndexedDatabasesCallback):
1683         (WTR::TestController::ClearIndexedDatabases):
1684         * WebKitTestRunner/TestController.h:
1685         * WebKitTestRunner/TestInvocation.cpp:
1686         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1687
1688 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
1689
1690         [ews-app] Rename ews model Builds to Build
1691         https://bugs.webkit.org/show_bug.cgi?id=193695
1692
1693         Reviewed by Lucas Forschler.
1694
1695         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
1696         (Build): Renamed Builds to Build.
1697
1698 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
1699
1700         webkitpy: Wait longer when launching WebKitTestRunner
1701         https://bugs.webkit.org/show_bug.cgi?id=193734
1702
1703         Reviewed by Aakash Jain.
1704
1705         * Scripts/webkitpy/port/simulator_process.py:
1706         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
1707
1708 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1709
1710         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
1711         https://bugs.webkit.org/show_bug.cgi?id=193182
1712         <rdar://problem/47452154>
1713
1714         Reviewed by Tim Horton.
1715
1716         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
1717         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
1718         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
1719
1720         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
1721         preventing later tests from recognizing gestures.
1722
1723         * WebKitTestRunner/ios/TestControllerIOS.mm:
1724         (WTR::TestController::platformResetStateToConsistentValues):
1725
1726         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
1727
1728 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
1729
1730         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
1731         https://bugs.webkit.org/show_bug.cgi?id=193722
1732         <rdar://problem/47481475>
1733
1734         Reviewed by Lucas Forschler.
1735
1736         iPhone and iPad ports should both use the iOS config.
1737
1738         * Scripts/webkitpy/port/ios_simulator.py:
1739         (IPhoneSimulatorPort.__init__):
1740         (IPadSimulatorPort.__init__):
1741
1742 2019-01-23  Rob Buis  <rbuis@igalia.com>
1743
1744         Update MIME type parser
1745         https://bugs.webkit.org/show_bug.cgi?id=180526
1746
1747         Reviewed by Frédéric Wang.
1748
1749         Add unit tests for both parse modes of ParsedContentType.
1750
1751         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1752         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
1753         (TestWebKitAPI::TEST):
1754
1755 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
1756
1757         [ews-app] fetch loop should not stop on network issues
1758         https://bugs.webkit.org/show_bug.cgi?id=193666
1759
1760         Reviewed by Lucas Forschler.
1761
1762         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1763         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
1764
1765 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1766
1767         [iOS] Multiple WKWebViewAutofillTests are flaky failures
1768         https://bugs.webkit.org/show_bug.cgi?id=189165
1769         <rdar://problem/47433765>
1770
1771         Reviewed by Tim Horton.
1772
1773         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
1774         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
1775         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
1776         process in sufficient to ensure that any previous action that blurred the focused element in the web process
1777         would make its way to the UI process by the time the layer tree commit is finished.
1778
1779         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
1780         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
1781         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
1782         will fail because it asks for -_autofillContext too early.
1783
1784         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
1785         is handled in the UI process.
1786
1787         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1788
1789         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
1790         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
1791         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
1792         input session.
1793
1794         (-[AutofillTestView textInputHasAutofillContext]):
1795
1796         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
1797
1798         * TestWebKitAPI/cocoa/TestWKWebView.h:
1799         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1800         (nextInputSessionChangeCount):
1801
1802         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
1803         This includes changing the focused element from one to another.
1804
1805         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
1806         (-[TestWKWebView didStartFormControlInteraction]):
1807         (-[TestWKWebView didEndFormControlInteraction]):
1808         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
1809
1810         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
1811         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
1812         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
1813         that doesn't require an input session to one that doesn't.
1814
1815 2019-01-22  David Kilzer  <ddkilzer@apple.com>
1816
1817         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
1818         <https://webkit.org/b/193676>
1819
1820         Reviewed by Alexey Proskuryakov.
1821
1822         * Scripts/webkitpy/style/checkers/cpp.py:
1823         (check_member_initialization_list):
1824         - Don't report missing whitespace around colon if the colon at
1825           the start of the line is formatted correctly.
1826         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1827         (WebKitStyleTest.test_member_initialization_list):
1828         - Add a test for a missing permutation of existing tests.
1829         - Add a test this false-positive.
1830         - Add blank lines between subtests to make them easier to read.
1831
1832 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
1833
1834         [build.webkit.org] Unit-test failure after r237113
1835         https://bugs.webkit.org/show_bug.cgi?id=193669
1836
1837         Reviewed by Michael Catanzaro.
1838
1839         * BuildSlaveSupport/build.webkit.org-config/factories.py:
1840         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
1841         multiple or zero flags.
1842
1843 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
1844
1845         Cache bytecode to disk
1846         https://bugs.webkit.org/show_bug.cgi?id=192782
1847         <rdar://problem/46084932>
1848
1849         Reviewed by Keith Miller.
1850
1851         Add test helper to execute bytecode-cache tests: it executes each test
1852         twice, the first with JSC_diskCachePath set to a temporary directory
1853         and second with JSC_forceDiskCache=true (in addition to the cache path)
1854         to guarantee that only the disk cache is being used and no new
1855         UnlinkedCodeBlocks are being created.
1856
1857         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
1858         * Scripts/run-jsc-stress-tests:
1859
1860 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
1861
1862         [css-logical] Implement flow-relative margin, padding and border shorthands
1863         https://bugs.webkit.org/show_bug.cgi?id=188697
1864
1865         Reviewed by Simon Fraser and Antti Koivisto.
1866
1867         * DumpRenderTree/TestOptions.cpp:
1868         (TestOptions::TestOptions):
1869         * DumpRenderTree/TestOptions.h:
1870         * DumpRenderTree/mac/DumpRenderTree.mm:
1871         (setWebPreferencesForTestOptions):
1872         Allow tests to enable the CSSLogicalEnabled flag in WK1.
1873
1874         * Scripts/webkitpy/style/checkers/jsonchecker.py:
1875         (JSONCSSPropertiesChecker.check_codegen_properties):
1876         Allow CSS property definitions to have a 'runtime-flag' parameter which
1877         disables the property when the specified runtime flag is disabled.
1878
1879 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
1880
1881         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
1882         https://bugs.webkit.org/show_bug.cgi?id=193643
1883
1884         Reviewed by Michael Catanzaro.
1885
1886         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
1887         * wpe/jhbuild.modules: Ditto.
1888
1889 2019-01-21  Zalan Bujtas  <zalan@apple.com>
1890
1891         [LFC][Floats] Take float top position into account when computing containing block height.
1892         https://bugs.webkit.org/show_bug.cgi?id=193655
1893
1894         Reviewed by Antti Koivisto.
1895
1896         * LayoutReloaded/misc/LFC-passing-tests.txt:
1897
1898 2019-01-21  David Kilzer  <ddkilzer@apple.com>
1899
1900         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
1901         <https://webkit.org/b/193645>
1902         <rdar://problem/47421574>
1903
1904         Reviewed by Alex Christensen.
1905
1906         - Now checks for local soft-linking of all frameworks that have
1907           their own *SoftLinking.{cpp,h,mm} files.
1908         - Changes softlink/uikit warning to softlink/framework.
1909
1910         * Scripts/webkitpy/style/checkers/cpp.py:
1911         (check_language):
1912         (CppChecker):
1913         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1914         (CppStyleTest):
1915
1916 2019-01-20  Saam Barati  <sbarati@apple.com>
1917
1918         Rollout r240210: It broke tests on iOS
1919         https://bugs.webkit.org/show_bug.cgi?id=193640
1920
1921         Unreviewed.
1922
1923         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
1924         * Scripts/run-jsc-stress-tests:
1925
1926 2019-01-20  chris fleizach  <cfleizach@apple.com>
1927
1928         AX: Support returning relative frames for accessibility
1929         https://bugs.webkit.org/show_bug.cgi?id=193414
1930         <rdar://problem/47268501>
1931
1932         Reviewed by Zalan Bujtas.
1933
1934         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1935         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1936         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1937         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1938         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1939         (WTR::attributesOfElement):
1940         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
1941
1942 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
1943
1944         Unreviewed, add my new email address
1945
1946         * Scripts/webkitpy/common/config/contributors.json:
1947
1948 2019-01-19  Zalan Bujtas  <zalan@apple.com>
1949
1950         [LFC][BFC] <body>'s overflow property value is propagated to viewport
1951         https://bugs.webkit.org/show_bug.cgi?id=193617
1952
1953         Reviewed by Antti Koivisto.
1954
1955         * LayoutReloaded/misc/LFC-passing-tests.txt:
1956
1957 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
1958
1959         Unreviewed, rolling out r240209.
1960
1961         Broke GTK/WPE injected bundle
1962
1963         Reverted changeset:
1964
1965         "AX: Support returning relative frames for accessibility"
1966         https://bugs.webkit.org/show_bug.cgi?id=193414
1967         https://trac.webkit.org/changeset/240209
1968
1969 2019-01-12  Dan Bernstein  <mitz@apple.com>
1970
1971         [Cocoa] Avoid importing directly from subumbrella frameworks
1972         https://bugs.webkit.org/show_bug.cgi?id=186016
1973         <rdar://problem/40591038>
1974
1975         Reviewed by Sam Weinig.
1976
1977         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
1978           LaunchServices header.
1979         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1980           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1981         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
1982           when using SDKs earlier than 10.13.
1983         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
1984           and OTHER_CPLUSPLUSFLAGS.
1985         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
1986           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
1987         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
1988           LaunchServices header.
1989
1990 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
1991
1992         Cache bytecode to disk
1993         https://bugs.webkit.org/show_bug.cgi?id=192782
1994         <rdar://problem/46084932>
1995
1996         Reviewed by Keith Miller.
1997
1998         Add test helper to execute bytecode-cache tests: it executes each test
1999         twice, the first with JSC_diskCachePath set to a temporary directory
2000         and second with JSC_forceDiskCache=true (in addition to the cache path)
2001         to guarantee that only the disk cache is being used and no new
2002         UnlinkedCodeBlocks are being created.
2003
2004         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
2005         * Scripts/run-jsc-stress-tests:
2006
2007 2019-01-20  chris fleizach  <cfleizach@apple.com>
2008
2009         AX: Support returning relative frames for accessibility
2010         https://bugs.webkit.org/show_bug.cgi?id=193414
2011         <rdar://problem/47268501>
2012
2013         Reviewed by Zalan Bujtas.
2014
2015         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2016         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2017         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2018         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2019         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2020         (WTR::attributesOfElement):
2021         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2022
2023 2019-01-20  Antoine Quint  <graouts@apple.com>
2024
2025         Add a POINTER_EVENTS feature flag
2026         https://bugs.webkit.org/show_bug.cgi?id=193577
2027         <rdar://problem/47408511>
2028
2029         Unreviewed. Also enable Pointer Events for iosmac.
2030
2031         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2032
2033 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2034
2035         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
2036         https://bugs.webkit.org/show_bug.cgi?id=193613
2037
2038         Reviewed by Antti Koivisto.
2039
2040         * LayoutReloaded/misc/LFC-passing-tests.txt:
2041
2042 2019-01-19  Antoine Quint  <graouts@apple.com>
2043
2044         Add a POINTER_EVENTS feature flag
2045         https://bugs.webkit.org/show_bug.cgi?id=193577
2046
2047         Reviewed by Dean Jackson.
2048
2049         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2050
2051 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
2052
2053         Disable the run-jsc-stress-test remote host key check [second round].
2054         https://bugs.webkit.org/show_bug.cgi?id=192988
2055
2056         Reviewed by Dewei Zhu.
2057
2058         * Scripts/run-jsc-stress-tests:
2059
2060 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2061
2062         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
2063         https://bugs.webkit.org/show_bug.cgi?id=193597
2064
2065         Reviewed by Lucas Forschler.
2066
2067         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2068
2069 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2070
2071         [build.webkit.org] api tests failures are incorrectly named as unit test failures
2072         https://bugs.webkit.org/show_bug.cgi?id=193595
2073
2074         Reviewed by Lucas Forschler.
2075
2076         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
2077         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
2078         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
2079
2080 2019-01-18  Chris Dumez  <cdumez@apple.com>
2081
2082         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
2083         https://bugs.webkit.org/show_bug.cgi?id=193588
2084         <rdar://problem/47131566>
2085
2086         Reviewed by Alex Christensen.
2087
2088         Add layout test coverage.
2089
2090         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2091
2092 2019-01-18  Jer Noble  <jer.noble@apple.com>
2093
2094         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
2095         https://bugs.webkit.org/show_bug.cgi?id=189553
2096
2097         Reviewed by Tim Horton.
2098
2099         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
2100
2101         * ContentExtensionTester/Configurations/Base.xcconfig:
2102         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
2103         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2104         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
2105         * ImageDiff/cg/Configurations/Base.xcconfig:
2106         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
2107         * MiniBrowser/Configurations/Base.xcconfig:
2108         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2109         * MobileMiniBrowser/Configurations/Base.xcconfig:
2110         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2111         * Scripts/webkitpy/style/checker.py:
2112         (_all_categories):
2113         (FileType):
2114         (CheckerDispatcher._file_type):
2115         (CheckerDispatcher._create_checker):
2116         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
2117         (SDKVariantChecker):
2118         (SDKVariantChecker.__init__):
2119         (SDKVariantChecker.check):
2120         * TestWebKitAPI/Configurations/Base.xcconfig:
2121         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
2122         * WebEditingTester/Configurations/Base.xcconfig:
2123         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
2124         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
2125         * WebKitTestRunner/Configurations/Base.xcconfig:
2126         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
2127         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
2128         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
2129
2130 2019-01-18  David Kilzer  <ddkilzer@apple.com>
2131
2132         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
2133         <https://webkit.org/b/193568>
2134         <rdar://problem/47381130>
2135
2136         Reviewed by Alex Christensen.
2137
2138         Make sure no one re-introduces UIKit soft-linking by adding a
2139         style rule.
2140
2141         * Scripts/webkitpy/style/checkers/cpp.py:
2142         (check_language): Add softlink/uikit check.
2143         (CppChecker): Enable softlink/uikit check.
2144         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2145         (CppStyleTest): Add test for softlink/uikit.
2146
2147 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
2148
2149         [GTK] install-dependencies tool looks for libunistring-dev for dnf
2150         https://bugs.webkit.org/show_bug.cgi?id=193584
2151
2152         Change "-dev" to "-devel".
2153
2154         Reviewed by Michael Catanzaro.
2155
2156         * gtk/install-dependencies:
2157
2158 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2159
2160         webkitpy: Add iPhone and iPad ports
2161         https://bugs.webkit.org/show_bug.cgi?id=193537
2162         <rdar://problem/47353390>
2163
2164         Reviewed by Lucas Forschler.
2165
2166         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
2167         ports. Note that this separation is optional, the --ios-simulator command remains.
2168
2169         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2170         (RunTest.test_device_type_test_division): Drive-by fix.
2171         (RunTest.test_device_type_specific_listing): Ditto.
2172         (RunTest.test_ipad_test_division):
2173         (RunTest):
2174         (RunTest.test_ipad_listing):
2175         * Scripts/webkitpy/port/factory.py:
2176         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
2177         (PortFactory):
2178         * Scripts/webkitpy/port/ios_simulator.py:
2179         (IPhoneSimulatorPort):
2180         (IPadSimulatorPort):
2181
2182 2019-01-18  Chris Dumez  <cdumez@apple.com>
2183
2184         Regression(PSON) Scroll position is not always restored properly when navigating back
2185         https://bugs.webkit.org/show_bug.cgi?id=193578
2186         <rdar://problem/47386331>
2187
2188         Reviewed by Tim Horton.
2189
2190         Add API test coverage.
2191
2192         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2193
2194 2019-01-18  Youenn Fablet  <youenn@apple.com>
2195
2196         Add a new SPI to request for cache storage quota increase
2197         https://bugs.webkit.org/show_bug.cgi?id=193323
2198
2199         Reviewed by Alex Christensen.
2200
2201         Implement WebsiteDataStore quota delegate to handle quota requests.
2202         By default, do not update quota.
2203         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
2204
2205         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2206         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2207         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
2208         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2209         * WebKitTestRunner/TestController.cpp:
2210         (WTR::TestController::allowCacheStorageQuotaIncrease):
2211         * WebKitTestRunner/TestController.h:
2212         * WebKitTestRunner/TestInvocation.cpp:
2213         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2214         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2215         (-[CacheStorageQuotaManager init]):
2216         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2217         (WTR::initializeWebViewConfiguration):
2218         (WTR::TestController::cocoaResetStateToConsistentValues):
2219         (WTR::TestController::allowCacheStorageQuotaIncrease):
2220
2221 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2222
2223         [ews-build] Pass owner to the triggered builds
2224         https://bugs.webkit.org/show_bug.cgi?id=193574
2225
2226         Reviewed by Lucas Forschler.
2227
2228         * BuildSlaveSupport/ews-build/factories.py:
2229         (BuildFactory.propertiesToPassToTriggers):
2230
2231 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2232
2233         [ews-app] Send patch author as a build property
2234         https://bugs.webkit.org/show_bug.cgi?id=193560
2235
2236         Reviewed by Lucas Forschler.
2237
2238         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2239         (BugzillaPatchFetcher.fetch):
2240
2241 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2242
2243         webkitpy: Implement device type specific expected results (Follow-up fix)
2244         https://bugs.webkit.org/show_bug.cgi?id=192162
2245         <rdar://problem/46345449>
2246
2247         Unreviewed infrastructure fix.
2248
2249         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2250         (Manager.run): Don't boot a device if no tests are available to run on it.
2251
2252 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2253
2254         webkitpy: Implement device type specific expected results (Follow-up fix)
2255         https://bugs.webkit.org/show_bug.cgi?id=192162
2256         <rdar://problem/46345449>
2257
2258         Unreviewed infrastructure fix.
2259
2260         * Scripts/webkitpy/api_tests/manager.py:
2261         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
2262
2263 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2264
2265         webkitpy: Implement device type specific expected results (Part 2)
2266         https://bugs.webkit.org/show_bug.cgi?id=192162
2267         <rdar://problem/46345449>
2268
2269         Rubber-stamped by Aakash Jain.
2270
2271         This change uses device_type to select a different set of TestExpectation files based on the type of device running
2272         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
2273         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
2274
2275         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
2276         (LayoutTestFinder.find_tests): Pass device_type through.
2277         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
2278         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
2279         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2280         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
2281         (Manager._collect_tests): Pass device type to test finder.
2282         (Manager._needs_web_platform_test):
2283         (Manager._prepare_lists): Index _expectations by device type.
2284         (Manager._test_input_for_file):
2285         (Manager._test_is_slow): Ditto.
2286         (Manager._test_should_dump_jsconsolelog_in_stderr):
2287         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
2288         (Manager._get_test_inputs):
2289         (Manager._update_worker_count):
2290         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
2291         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
2292         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
2293         the one which runs the test.
2294         (Manager._run_test_subset):
2295         (Manager._run_tests): Index _expectations by current_device_type.
2296         (Manager._print_expectation_line_for_test): Ditto.
2297         (Manager._print_expectations_for_subset): Ditto.
2298         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
2299         Unlike run, this function will behave the same regardless of what devices are available.
2300         (Manager._custom_device_for_test): Deleted.
2301         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2302         (ManagerTest.test_uses_custom_device): Deleted.
2303         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
2304         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2305         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
2306         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
2307         all of the expectations.
2308         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
2309         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
2310         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2311         (TestExpectations.__init__): Allow device_type to be passed through.
2312         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
2313         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
2314         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2315         (summarize_results):
2316         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2317         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
2318         a test ran with, one must check all expectations to find the first non-skip expectation.
2319         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2320         (RunTest.test_device_type_test_division):
2321         (RunTest):
2322         (RunTest.test_device_type_specific_listing):
2323         * Scripts/webkitpy/port/base.py:
2324         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
2325         (Port.supported_device_types): The result of this function will change based on what devices are available.
2326         * Scripts/webkitpy/port/device_port.py:
2327         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
2328         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
2329         can be used.
2330         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
2331         any, or the DEFAULT_DEVICE_TYPES of the port.
2332         * Scripts/webkitpy/port/ios.py:
2333         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
2334         * Scripts/webkitpy/port/ios_simulator.py:
2335         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
2336         * Scripts/webkitpy/port/watch.py:
2337         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
2338         * Scripts/webkitpy/port/watch_simulator.py:
2339         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
2340         * Scripts/webkitpy/xcode/device_type.py:
2341         (DeviceType):
2342         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
2343
2344 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2345
2346         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
2347         https://bugs.webkit.org/show_bug.cgi?id=193575
2348
2349         Reviewed by Michael Catanzaro.
2350
2351         Allow the script to run without explicit port argument because
2352         it's specific to the WPE port anyway.
2353
2354         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
2355         and simplify the rest of the code accordingly.
2356
2357 2019-01-18  Charlie Turner  <cturner@igalia.com>
2358
2359         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
2360         https://bugs.webkit.org/show_bug.cgi?id=192229
2361
2362         Reviewed by Xabier Rodriguez-Calvar.
2363
2364         * MiniBrowser/wpe/main.cpp:
2365         (main): Enable encrypted-media by default.
2366
2367 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2368
2369         [Flatpak] Missing KeyboardInterrupt exception handler
2370         https://bugs.webkit.org/show_bug.cgi?id=193570
2371
2372         Reviewed by Michael Catanzaro.
2373
2374         * flatpak/flatpakutils.py:
2375         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
2376
2377 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2378
2379         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
2380         https://bugs.webkit.org/show_bug.cgi?id=193564
2381
2382         Reviewed by Antti Koivisto.
2383
2384         * LayoutReloaded/misc/LFC-passing-tests.txt:
2385
2386 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2387
2388         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
2389         https://bugs.webkit.org/show_bug.cgi?id=193562
2390
2391         Reviewed by Antti Koivisto.
2392
2393         * LayoutReloaded/misc/LFC-passing-tests.txt:
2394
2395 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2396
2397         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
2398         https://bugs.webkit.org/show_bug.cgi?id=193555
2399
2400         Reviewed by Antti Koivisto.
2401
2402         * LayoutReloaded/misc/LFC-passing-tests.txt:
2403
2404 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2405
2406         [WPE] Add Qt extension
2407         https://bugs.webkit.org/show_bug.cgi?id=191464
2408
2409         Reviewed by Carlos Garcia Campos.
2410
2411         MiniBrowser and API tests for the WPE Qt API. To run the
2412         MiniBrowser a new script is introduced. Example invocation:
2413
2414         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
2415
2416         Also note-worthy is the introduction of the python2-subprocess32
2417         dependency to run the GLib API tests.
2418
2419         * MiniBrowser/wpe/CMakeLists.txt:
2420         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
2421         * MiniBrowser/wpe/qt/main.cpp: Added.
2422         (main):
2423         * MiniBrowser/wpe/qt/main.qml: Added.
2424         * MiniBrowser/wpe/qt/qml.qrc: Added.
2425         * Scripts/run-gtk-tests:
2426         (GtkTestRunner.is_google_test):
2427         (GtkTestRunner):
2428         (GtkTestRunner.is_qt_test):
2429         * Scripts/run-qt-wpe-minibrowser: Added.
2430         * Scripts/run-wpe-tests:
2431         (WPETestRunner):
2432         (WPETestRunner.is_google_test):
2433         (WPETestRunner.is_qt_test):
2434         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
2435         (TestLoad::main):
2436         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
2437         (TestLoadHtml::main):
2438         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
2439         (TestLoadRequest::main):
2440         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
2441         (TestRunJavaScript::main):
2442         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
2443         (waitForSignal):
2444         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
2445         (LoadSpy::LoadSpy):
2446         (LoadSpy::~LoadSpy):
2447         (LoadSpy::onLoadingChanged):
2448         (LoadStartedCatcher::LoadStartedCatcher):
2449         (LoadStartedCatcher::~LoadStartedCatcher):
2450         (LoadStartedCatcher::onLoadingChanged):
2451         (waitForLoadSucceeded):
2452         (waitForLoadFailed):
2453         * TestWebKitAPI/glib/CMakeLists.txt:
2454         * flatpak/flatpakutils.py:
2455         (WebkitFlatpak.load_from_args):
2456         (WebkitFlatpak.__init__):
2457         (WebkitFlatpak.clean_args):
2458         (WebkitFlatpak.run_in_sandbox):
2459         * flatpak/org.webkit.CommonModules.yaml:
2460         * flatpak/org.webkit.WPE.yaml:
2461         * flatpak/org.webkit.WPEModules.yaml:
2462         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
2463         * flatpak/org.webkit.WebKit.yaml:
2464         * glib/api_test_runner.py:
2465         (TestRunner._run_test_qt):
2466         (TestRunner.is_qt_test):
2467         (TestRunner._run_test):
2468
2469 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2470
2471         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
2472         https://bugs.webkit.org/show_bug.cgi?id=193494
2473         <rdar://problem/46859627>
2474
2475         Reviewed by Simon Fraser and Tim Horton.
2476
2477         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
2478         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
2479
2480         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2481         (WTR::UIScriptController::contentOffsetX const):
2482         (WTR::UIScriptController::contentOffsetY const):
2483         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2484         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2485         (WTR::UIScriptController::contentOffsetX const):
2486         (WTR::UIScriptController::contentOffsetY const):
2487         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2488
2489         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
2490
2491         * WebKitTestRunner/TestController.cpp:
2492         (WTR::updateTestOptionsFromTestHeader):
2493         * WebKitTestRunner/TestOptions.h:
2494         (WTR::TestOptions::hasSameInitializationOptions const):
2495         * WebKitTestRunner/ios/TestControllerIOS.mm:
2496         (WTR::TestController::platformResetStateToConsistentValues):
2497         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2498         (WTR::UIScriptController::contentOffsetX const):
2499         (WTR::UIScriptController::contentOffsetY const):
2500
2501 2019-01-17  Truitt Savell  <tsavell@apple.com>
2502
2503         Unreviewed, rolling out r240124.
2504
2505         This commit broke an internal build.
2506
2507         Reverted changeset:
2508
2509         "SDK_VARIANT build destinations should be separate from non-
2510         SDK_VARIANT builds"
2511         https://bugs.webkit.org/show_bug.cgi?id=189553
2512         https://trac.webkit.org/changeset/240124
2513
2514 2019-01-17  Alex Christensen  <achristensen@webkit.org>
2515
2516         Fix string concatenation API test after r239920
2517         https://bugs.webkit.org/show_bug.cgi?id=193551
2518         <rdar://problem/47359304>
2519
2520         Reviewed by Youenn Fablet.
2521
2522         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
2523         (TestWebKitAPI::TEST):
2524         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
2525         in WebKit's build configuration like it apparently is on Linux.
2526
2527 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2528
2529         [ews-build] validate-patch should handle the case when bug_id is None
2530         https://bugs.webkit.org/show_bug.cgi?id=193547
2531
2532         Reviewed by Lucas Forschler.
2533
2534         * BuildSlaveSupport/ews-build/steps.py:
2535         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
2536         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
2537
2538 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2539
2540         [ews-build] Add patch author information in build
2541         https://bugs.webkit.org/show_bug.cgi?id=193465
2542
2543         Reviewed by Lucas Forschler.
2544
2545         * BuildSlaveSupport/ews-build/steps.py:
2546         (ValidatePatch._is_patch_obsolete):
2547
2548 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2549
2550         [ews-build] Pass bug_id to the triggered builds
2551         https://bugs.webkit.org/show_bug.cgi?id=193548
2552
2553         Reviewed by Lucas Forschler.
2554
2555         * BuildSlaveSupport/ews-build/factories.py:
2556         (BuildFactory.propertiesToPassToTriggers):
2557
2558 2019-01-17  Jer Noble  <jer.noble@apple.com>
2559
2560         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
2561         https://bugs.webkit.org/show_bug.cgi?id=189553
2562
2563         Reviewed by Tim Horton.
2564
2565         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
2566
2567         * ContentExtensionTester/Configurations/Base.xcconfig:
2568         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
2569         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2570         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
2571         * ImageDiff/cg/Configurations/Base.xcconfig:
2572         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
2573         * MiniBrowser/Configurations/Base.xcconfig:
2574         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2575         * MobileMiniBrowser/Configurations/Base.xcconfig:
2576         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2577         * Scripts/webkitpy/style/checker.py:
2578         (_all_categories):
2579         (FileType):
2580         (CheckerDispatcher._file_type):
2581         (CheckerDispatcher._create_checker):
2582         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
2583         (SDKVariantChecker):
2584         (SDKVariantChecker.__init__):
2585         (SDKVariantChecker.check):
2586         * TestWebKitAPI/Configurations/Base.xcconfig:
2587         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
2588         * WebEditingTester/Configurations/Base.xcconfig:
2589         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
2590         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
2591         * WebKitTestRunner/Configurations/Base.xcconfig:
2592         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
2593         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
2594         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
2595
2596 2019-01-17  Zalan Bujtas  <zalan@apple.com>
2597
2598         [LFC][BFC] An element with transform is a containing block for positioned descendants.
2599         https://bugs.webkit.org/show_bug.cgi?id=193534
2600
2601         Reviewed by Antti Koivisto.
2602
2603         * LayoutReloaded/misc/LFC-passing-tests.txt:
2604
2605 2019-01-17  Zalan Bujtas  <zalan@apple.com>
2606
2607         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
2608         https://bugs.webkit.org/show_bug.cgi?id=193528
2609
2610         Reviewed by Antti Koivisto.
2611
2612         * LayoutReloaded/misc/LFC-passing-tests.txt:
2613
2614 2019-01-17  Zalan Bujtas  <zalan@apple.com>
2615
2616         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
2617         https://bugs.webkit.org/show_bug.cgi?id=193520
2618
2619         Reviewed by Antti Koivisto.
2620
2621         * LayoutReloaded/misc/LFC-passing-tests.txt:
2622
2623 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2624
2625         [ews-build] unapply-patch step should not update source
2626         https://bugs.webkit.org/show_bug.cgi?id=193234
2627
2628         Reviewed by Lucas Forschler.
2629
2630         * BuildSlaveSupport/ews-build/steps.py:
2631         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
2632         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
2633
2634 2019-01-16  Youenn Fablet  <youenn@apple.com>
2635
2636         Add a new SPI for controlling getUserMedia
2637         https://bugs.webkit.org/show_bug.cgi?id=192793
2638
2639         Reviewed by Eric Carlson.
2640
2641         * MiniBrowser/mac/WK2BrowserWindowController.m:
2642         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
2643         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
2644         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
2645         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2646         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
2647         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2648         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
2649         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2650         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
2651         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2652         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
2653         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
2654         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2655         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
2656
2657 2019-01-16  Zalan Bujtas  <zalan@apple.com>
2658
2659         [LFC][BFC] Inflow non-replaced used width should not be negative.
2660         https://bugs.webkit.org/show_bug.cgi?id=193495
2661
2662         Reviewed by Antti Koivisto.
2663
2664         * LayoutReloaded/misc/LFC-passing-tests.txt:
2665
2666 2019-01-16  Chris Dumez  <cdumez@apple.com>
2667
2668         Regression(PSON) View becomes blank after click a cross-site download link
2669         https://bugs.webkit.org/show_bug.cgi?id=193361
2670         <rdar://problem/47099573>
2671
2672         Reviewed by Geoffrey Garen.
2673
2674         Add API test coverage.
2675
2676         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2677         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2678
2679 2019-01-16  Zalan Bujtas  <zalan@apple.com>
2680
2681         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
2682         https://bugs.webkit.org/show_bug.cgi?id=193470
2683
2684         Reviewed by Antti Koivisto.
2685
2686         * LayoutReloaded/misc/LFC-passing-tests.txt:
2687
2688 2019-01-16  Zalan Bujtas  <zalan@apple.com>
2689
2690         [LFC] Adjust margin box verification.
2691         https://bugs.webkit.org/show_bug.cgi?id=193482
2692
2693         Reviewed by Antti Koivisto.
2694
2695         * LayoutReloaded/misc/LFC-passing-tests.txt:
2696
2697 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
2698
2699         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
2700         https://bugs.webkit.org/show_bug.cgi?id=193451
2701
2702         Reviewed by Geoffrey Garen.
2703
2704         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
2705         (TEST):
2706         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2707         (runWebsiteDataStoreCustomPaths):
2708
2709 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
2710
2711         webkitpy: Support boolean simctl isAvailable
2712         https://bugs.webkit.org/show_bug.cgi?id=193472
2713         <rdar://problem/47296150>
2714
2715         Reviewed by Ryosuke Niwa.
2716
2717         * Scripts/webkitpy/xcode/simulated_device.py:
2718         (SimulatedDeviceManager._create_runtimes):
2719         (SimulatedDeviceManager._create_device_with_runtime):
2720
2721 2019-01-15  Chris Dumez  <cdumez@apple.com>
2722
2723         Unreviewed, rolling out r239993, r239995, r239997, and
2724         r239999.
2725
2726         Caused assertions under
2727         ViewGestureController::disconnectFromProcess()
2728
2729         Reverted changesets:
2730
2731         "Regression(PSON) View becomes blank after click a cross-site
2732         download link"
2733         https://bugs.webkit.org/show_bug.cgi?id=193361
2734         https://trac.webkit.org/changeset/239993
2735
2736         "Unreviewed iOS build fix after r239993."
2737         https://trac.webkit.org/changeset/239995
2738
2739         "Fix iOS build after r239993"
2740         https://bugs.webkit.org/show_bug.cgi?id=193361
2741         https://trac.webkit.org/changeset/239997
2742
2743         "Unreviewed, revert part of r239997 as it is not needed to fix
2744         the build."
2745         https://trac.webkit.org/changeset/239999
2746
2747 2019-01-15  Tim Horton  <timothy_horton@apple.com>
2748
2749         Cannot tab out of WKWebView on macOS
2750         https://bugs.webkit.org/show_bug.cgi?id=161448
2751         <rdar://problem/28100085>
2752
2753         Reviewed by Dean Jackson.
2754
2755         Add a test that tabbing into and out of WKWebView works correctly.
2756
2757         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2758         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
2759         (WebKit2_CommandBackForwardTest::SetUp):
2760         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
2761         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
2762         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
2763         (-[FocusableView canBecomeKeyView]):
2764         (TEST):
2765         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
2766         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
2767         (-[OffscreenWindow initWithSize:]):
2768         (-[OffscreenWindow isKeyWindow]):
2769         (-[OffscreenWindow isVisible]):
2770         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2771         (TestWebKitAPI::PlatformWebView::initialize):
2772         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
2773         (-[ActiveOffscreenWindow isVisible]): Deleted.
2774         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
2775
2776 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
2777
2778         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
2779         https://bugs.webkit.org/show_bug.cgi?id=193459
2780
2781         Reviewed by Mark Lam.
2782
2783         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2784         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
2785
2786 2019-01-15  Chris Dumez  <cdumez@apple.com>
2787
2788         Regression(PSON) View becomes blank after click a cross-site download link
2789         https://bugs.webkit.org/show_bug.cgi?id=193361
2790         <rdar://problem/47099573>
2791
2792         Reviewed by Geoff Garen.
2793
2794         Add API test coverage.
2795
2796         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2797         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2798
2799 2019-01-15  Zalan Bujtas  <zalan@apple.com>
2800
2801         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
2802         https://bugs.webkit.org/show_bug.cgi?id=193448
2803
2804         Reviewed by Antti Koivisto.
2805
2806         * LayoutReloaded/misc/LFC-passing-tests.txt:
2807
2808 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
2809
2810         webkitpy: Implement device type specific expected results (Part 1)
2811         https://bugs.webkit.org/show_bug.cgi?id=192162
2812
2813         Reviewed by Lucas Forschler.
2814
2815         Device type specific expected results covers two related ideas. The first (covered by this change)
2816         is where to search for -expected.* files. The second is which tests to run based on the
2817         TestExpectations.txt file.
2818
2819         After this change, the baseline search path will be determined by the type of device running a
2820         test. Device type will be passed into any function which picks a file based on the baseline search
2821         path.
2822
2823         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2824         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
2825         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2826         (Manager.run): Print baseline search path for each round of devices.
2827         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2828         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
2829         (SingleTestRunner._expected_driver_output): Ditto.
2830         (SingleTestRunner._driver_input): Ditto.
2831         * Scripts/webkitpy/layout_tests/views/printing.py:
2832         (Printer.print_config): Move printing of baseline search path to a separate function.
2833         (Printer.print_baseline_search_path): Moved from Printer.print_config.
2834         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2835         (Testprinter.test_print_config):
2836         (Testprinter.test_print_baseline_search_path):
2837         * Scripts/webkitpy/port/base.py:
2838         (Port.baseline_search_path): Pass device_type through.
2839         (Port._expected_baselines_for_suffixes): Ditto.
2840         (Port.expected_baselines): Ditto.
2841         (Port.expected_filename): Ditto.
2842         (Port.expected_checksum): Ditto.
2843         (Port.expected_image): Ditto.
2844         (Port.expected_audio): Ditto.
2845         (Port.expected_text): Ditto.
2846         (Port.reference_files): Ditto.
2847         (Port.tests): Ditto.
2848         (Port._expanded_paths): Ditto.
2849         (Port.skipped_layout_tests): Ditto.
2850         (Port.expectations_dict): Ditto.
2851         (Port._port_specific_expectations_files): Ditto.
2852         (Port.expectations_files): Ditto.
2853         (Port.test_search_path): Ditto.
2854         (Port._tests_for_other_platforms): Ditto.
2855         * Scripts/webkitpy/port/base_unittest.py:
2856         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
2857         (PortTest.test_nonexistant_expectations): Ditto.
2858         (test_ref_tests_platform_directory): Ditto.
2859         * Scripts/webkitpy/port/darwin.py:
2860         (DarwinPort._port_specific_expectations_files): Accept device_type.
2861         * Scripts/webkitpy/port/driver.py:
2862         (DriverProxy):
2863         (DriverProxy.host): Expose _target_host for device_type information.
2864         * Scripts/webkitpy/port/gtk.py:
2865         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
2866         * Scripts/webkitpy/port/ios.py:
2867         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
2868         * Scripts/webkitpy/port/mac.py:
2869         (MacPort. default_baseline_search_path): Ditto.
2870         * Scripts/webkitpy/port/port_testcase.py:
2871         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
2872         * Scripts/webkitpy/port/test.py:
2873         * Scripts/webkitpy/port/watch.py:
2874         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
2875         * Scripts/webkitpy/port/win.py:
2876         (WinPort.test_search_path): Accept, but do not use, device_type.
2877         * Scripts/webkitpy/port/wpe.py:
2878         (WPEPort._port_specific_expectations_files): Ditto.
2879         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2880         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
2881
2882 2019-01-15  Zalan Bujtas  <zalan@apple.com>
2883
2884         [LFC] Use the containing block's padding box to position out-of-flow elements.
2885         https://bugs.webkit.org/show_bug.cgi?id=193431
2886
2887         Reviewed by Antti Koivisto.
2888
2889         * LayoutReloaded/misc/LFC-passing-tests.txt:
2890
2891 2019-01-14  Tim Horton  <timothy_horton@apple.com>
2892
2893         Move a test implementation file that got misplaced in the Xcode project
2894
2895         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2896
2897 2019-01-14  Commit Queue  <commit-queue@webkit.org>
2898
2899         Unreviewed, rolling out r239901, r239909, r239910, r239912,
2900         r239913, and r239914.
2901         https://bugs.webkit.org/show_bug.cgi?id=193407
2902
2903         These revisions caused an internal failure (Requested by
2904         Truitt on #webkit).
2905
2906         Reverted changesets:
2907
2908         "[Cocoa] Avoid importing directly from subumbrella frameworks"
2909         https://bugs.webkit.org/show_bug.cgi?id=186016
2910         https://trac.webkit.org/changeset/239901
2911
2912         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
2913         https://trac.webkit.org/changeset/239909
2914
2915         "Tried to fix the build."
2916         https://trac.webkit.org/changeset/239910
2917
2918         "Fixed iOS builds after r239910."
2919         https://trac.webkit.org/changeset/239912
2920
2921         "More build fixing."
2922         https://trac.webkit.org/changeset/239913
2923
2924         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
2925         https://trac.webkit.org/changeset/239914
2926
2927 2019-01-14  Mark Lam  <mark.lam@apple.com>
2928
2929         Re-enable ability to build --cloop builds.
2930         https://bugs.webkit.org/show_bug.cgi?id=192955
2931         <rdar://problem/46882363>
2932
2933         Reviewed by Saam barati and Keith Miller.
2934
2935         The --cloop build option was being ignored this whole time since r236381.
2936         This patch makes it possible to build CLoop builds again.
2937
2938         * Scripts/build-jsc:
2939         * Scripts/webkitperl/FeatureList.pm:
2940         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2941
2942 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
2943
2944         webkitpy: Expose device_type from host-like objects
2945         https://bugs.webkit.org/show_bug.cgi?id=193406
2946         <rdar://problem/47262305>
2947
2948         Reviewed by Lucas Forschler.
2949
2950         Devices should expose device_type. As a result, all host objects should
2951         provide a device_type property, even if they do not yet define a device_type.
2952
2953         * Scripts/webkitpy/common/system/systemhost.py:
2954         (SystemHost):
2955         (SystemHost.device_type):
2956         * Scripts/webkitpy/common/system/systemhost_mock.py:
2957         (MockSystemHost):
2958         (MockSystemHost.device_type):
2959         * Scripts/webkitpy/port/device.py:
2960         (Device):
2961         (Device.device_type):
2962         * Scripts/webkitpy/xcode/simulated_device.py:
2963         (SimulatedDeviceManager._find_exisiting_device_for_request):
2964         (SimulatedDeviceManager._disambiguate_device_type):
2965         (SimulatedDeviceManager._does_fulfill_request):
2966         (SimulatedDeviceManager.device_count_for_type):
2967         (SimulatedDeviceManager.initialize_devices):
2968         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
2969         (test_available_devices):
2970         (test_swapping_devices):
2971
2972 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
2973
2974         webkitpy: Support alternate simctl device list output (Follow-up fix)
2975         https://bugs.webkit.org/show_bug.cgi?id=193362
2976         <rdar://problem/47122965>
2977
2978         Rubber-stamped by Lucas Forschler.
2979
2980         * Scripts/webkitpy/xcode/simulated_device.py:
2981         (SimulatedDeviceManager.populate_available_devices):
2982
2983 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
2984
2985         [iOS] Expose SPI to access the current sentence boundary and selection state
2986         https://bugs.webkit.org/show_bug.cgi?id=193398
2987         <rdar://problem/45893108>
2988
2989         Reviewed by Dean Jackson.
2990
2991         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
2992         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
2993         expected.
2994
2995         * TestWebKitAPI/EditingTestHarness.h:
2996         * TestWebKitAPI/EditingTestHarness.mm:
2997         (-[EditingTestHarness moveBackward]):
2998         (-[EditingTestHarness moveForward]):
2999         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
3000
3001         Add a couple of new helper methods on EditingTestHarness.
3002
3003         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
3004         (-[SelectionChangeObserver initWithWebView:]):
3005         (-[SelectionChangeObserver webView]):
3006         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
3007         (-[SelectionChangeObserver currentSelectionAttributes]):
3008
3009 2019-01-14  Zalan Bujtas  <zalan@apple.com>
3010
3011         [LFC][BFC] Add basic box-sizing support.
3012         https://bugs.webkit.org/show_bug.cgi?id=193392
3013
3014         Reviewed by Antti Koivisto.
3015
3016         * LayoutReloaded/misc/LFC-passing-tests.txt:
3017
3018 2019-01-14  Charlie Turner  <cturner@igalia.com>
3019
3020         [WPE] API test gardening
3021         https://bugs.webkit.org/show_bug.cgi?id=193319
3022
3023         Reviewed by Michael Catanzaro.
3024
3025         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
3026         passing tests.
3027
3028 2019-01-14  Charlie Turner  <cturner@igalia.com>
3029
3030         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
3031         https://bugs.webkit.org/show_bug.cgi?id=192977
3032
3033         Reviewed by Carlos Garcia Campos.
3034
3035         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
3036         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
3037         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
3038         (TestWebKitAPI::GStreamerTest::SetUp):
3039         (TestWebKitAPI::GStreamerTest::TearDown):
3040         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
3041         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
3042         (TestWebKitAPI::TEST_F):
3043
3044 2019-01-14  Charlie Turner  <cturner@igalia.com>
3045
3046         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
3047         https://bugs.webkit.org/show_bug.cgi?id=193332
3048
3049         Reviewed by Michael Catanzaro.
3050
3051         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
3052         defined as a char16_t, which changed in ICU 59, the
3053         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
3054         unsigned short. This test is relying on the behaviour that
3055         UChar=unsigned short, which doesn't hold across platforms and ICU
3056         library versions. The full fix would be a special syntax for
3057         literal characters so that these ambiguities do not arise. That
3058         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
3059         (TestWebKitAPI::TEST):
3060
3061 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
3062
3063         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
3064
3065         * Scripts/make-dist:
3066         (Distcheck.configure):
3067
3068 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
3069
3070         [ews-build] Update macOS queue configurations
3071         https://bugs.webkit.org/show_bug.cgi?id=193365
3072         <rdar://problem/47221073>
3073
3074         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
3075
3076         * BuildSlaveSupport/ews-build/config.json:
3077
3078 2019-01-13  Zalan Bujtas  <zalan@apple.com>
3079
3080         [LFC] Adjust assert for statically positioned fixed elements
3081         https://bugs.webkit.org/show_bug.cgi?id=193385
3082
3083         Reviewed by Antti Koivisto.
3084
3085         * LayoutReloaded/misc/LFC-passing-tests.txt:
3086
3087 2019-01-13  Philippe Normand  <pnormand@igalia.com>
3088
3089         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
3090         https://bugs.webkit.org/show_bug.cgi?id=193387
3091
3092         Reviewed by Carlos Garcia Campos.
3093
3094         * MiniBrowser/wpe/main.cpp:
3095         (main):
3096
3097 2019-01-12  Timothy Hatcher  <timothy@apple.com>
3098
3099         Have prefers-color-scheme: light always match on macOS versions before Mojave.
3100         https://bugs.webkit.org/show_bug.cgi?id=191655
3101         rdar://problem/46074680
3102
3103         Reviewed by Megan Gardner.
3104
3105         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
3106         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
3107
3108 2019-01-12  Dan Bernstein  <mitz@apple.com>
3109
3110         [Cocoa] Avoid importing directly from subumbrella frameworks
3111         https://bugs.webkit.org/show_bug.cgi?id=186016
3112         <rdar://problem/40591038>
3113
3114         Reviewed by Sam Weinig.
3115
3116         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
3117           LaunchServices header.
3118         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3119           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3120         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
3121           when using SDKs earlier than 10.13.
3122         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
3123           and OTHER_CPLUSPLUSFLAGS.
3124         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3125           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3126         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
3127           LaunchServices header.
3128
3129 2019-01-11  John Wilander  <wilander@apple.com>
3130
3131         Compile out Web API Statistics Collection
3132         https://bugs.webkit.org/show_bug.cgi?id=193370
3133         <rdar://problem/45388584>
3134
3135         Reviewed by Brent Fulgham.
3136
3137         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3138             Defined ENABLE_WEB_API_STATISTICS, off by default.
3139
3140 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
3141
3142         [WPE] Add gtk-doc
3143         https://bugs.webkit.org/show_bug.cgi?id=178900
3144
3145         Reviewed by Michael Catanzaro.
3146
3147         Add Tools/gtkdoc to manifest.txt.in files.
3148         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
3149
3150         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
3151         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
3152
3153 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3154
3155         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
3156         https://bugs.webkit.org/show_bug.cgi?id=193364
3157         <rdar://problem/47214117>
3158
3159         Reviewed by Tim Horton.
3160
3161         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
3162         precise, whereas dragging near the middle of the textarea does.
3163
3164         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3165         (TestWebKitAPI::TEST):
3166
3167 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3168
3169         webkitpy: Support alternate simctl device list output
3170         https://bugs.webkit.org/show_bug.cgi?id=193362
3171         <rdar://problem/47122965>
3172
3173         Reviewed by Lucas Forschler.
3174
3175         * Scripts/webkitpy/xcode/simulated_device.py:
3176         (SimulatedDeviceManager.populate_available_devices):
3177
3178 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
3179
3180         [ews-build] Update macOS queue configurations
3181         https://bugs.webkit.org/show_bug.cgi?id=193365
3182
3183         Reviewed by Lucas Forschler.
3184
3185         * BuildSlaveSupport/ews-build/config.json:
3186
3187 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3188
3189         webkitpy: Incorporate device type into baseline search path
3190         https://bugs.webkit.org/show_bug.cgi?id=193356
3191         <rdar://problem/47215515>
3192
3193         Reviewed by Lucas Forschler.
3194
3195         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
3196
3197         * Scripts/webkitpy/port/base.py:
3198         (Port.default_baseline_search_path): Allow device type to be passed in.
3199         * Scripts/webkitpy/port/gtk.py:
3200         (GtkPort.default_baseline_search_path): Ignore device type.
3201         * Scripts/webkitpy/port/ios.py:
3202         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
3203         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
3204         * Scripts/webkitpy/port/ios_device_unittest.py:
3205         (IOSDeviceTest):
3206         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3207         (IOSSimulatorTest):
3208         * Scripts/webkitpy/port/mac.py:
3209         (MacPort.default_baseline_search_path): Ignore device type.
3210         * Scripts/webkitpy/port/watch.py:
3211         (WatchPort.default_baseline_search_path): Ditto.
3212         * Scripts/webkitpy/port/win.py:
3213         (WinPort.default_baseline_search_path): Ditto.
3214         (WinCairoPort.default_baseline_search_path): Ditto.
3215         * Scripts/webkitpy/port/wpe.py:
3216         (WPEPort.default_baseline_search_path): Ditto.
3217
3218 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3219
3220         webkitpy: Print abbreviated baseline search path that includes only folders that exist
3221         https://bugs.webkit.org/show_bug.cgi?id=193352
3222         <rdar://problem/47210736>
3223
3224         Reviewed by Lucas Forschler.
3225
3226         * Scripts/webkitpy/layout_tests/views/printing.py:
3227         (Printer.print_config): Print list on only baseline search paths which exist. 
3228         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3229         (Testprinter.test_print_config):
3230
3231 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
3232
3233         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
3234         https://bugs.webkit.org/show_bug.cgi?id=193340
3235
3236         Reviewed by David Kilzer.
3237
3238         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3239         (WTR::InjectedBundle::didReceiveMessageToPage):
3240         Pull the strings out into a WKRetainPtr.
3241
3242         * WebKitTestRunner/WebNotificationProvider.cpp:
3243         (WTR::WebNotificationProvider::closeWebNotification):
3244         Adopt the created value into the WKRetainPtr.
3245
3246         * WebKitTestRunner/mac/TestControllerMac.mm:
3247         (WTR::generateWhitelist):
3248         Immediately adopt a created value to avoid potential mistakes.
3249
3250 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
3251
3252         Enable DFG on ARM/Linux again
3253         https://bugs.webkit.org/show_bug.cgi?id=192496
3254
3255         Reviewed by Yusuke Suzuki.
3256
3257         After changing the bytecode format DFG was disabled on all 32-bit
3258         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
3259         on ARM by default.
3260
3261         * Scripts/run-jsc-stress-tests:
3262
3263 2019-01-11  Timothy Hatcher  <timothy@apple.com>
3264
3265         Unreviewed, fix #ifdef in API test added in r239851.
3266         https://bugs.webkit.org/show_bug.cgi?id=193327
3267         rdar://problem/47093222
3268
3269         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
3270
3271 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3272
3273         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
3274         https://bugs.webkit.org/show_bug.cgi?id=193109
3275         <rdar://problem/44807048>
3276
3277         Reviewed by Ryosuke Niwa.
3278
3279         Introduce and respect a test option to enable the UndoManager API.
3280
3281         * WebKitTestRunner/TestController.cpp:
3282         (WTR::updateTestOptionsFromTestHeader):
3283         * WebKitTestRunner/TestOptions.h:
3284         (WTR::TestOptions::hasSameInitializationOptions const):
3285         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3286         (WTR::TestController::platformCreateWebView):
3287
3288 2019-01-11  Zalan Bujtas  <zalan@apple.com>
3289
3290         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
3291         https://bugs.webkit.org/show_bug.cgi?id=193346
3292
3293         Reviewed by Antti Koivisto.
3294
3295         * LayoutReloaded/misc/LFC-passing-tests.txt:
3296
3297 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3298
3299         Unreviewed, fix typo that breaks dashboard link.
3300
3301         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3302         (WebKitBuildbot):
3303
3304 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3305
3306         Update macOS queue configurations
3307         https://bugs.webkit.org/show_bug.cgi?id=193329
3308
3309         Reviewed by Alexey Proskuryakov.
3310
3311         * BuildSlaveSupport/build.webkit.org-config/config.json:
3312         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3313         (BubbleQueueServer):
3314         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3315         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3316         (WebKitBuildbot):
3317         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3318         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
3319         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3320
3321 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3322
3323         MiniBrowser should be able to navigate to about:blank
3324         https://bugs.webkit.org/show_bug.cgi?id=193345
3325
3326         Reviewed by Simon Fraser.
3327
3328         * MiniBrowser/mac/BrowserWindowController.m:
3329         (-[BrowserWindowController addProtocolIfNecessary:]):
3330         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
3331
3332         * MiniBrowser/mac/WK1BrowserWindowController.m:
3333         (-[WK1BrowserWindowController fetch:]):
3334         * MiniBrowser/mac/WK2BrowserWindowController.m:
3335         (-[WK2BrowserWindowController fetch:]):
3336         Clean up the code that uses this to match style.
3337
3338 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3339
3340         Remove MiniBrowser custom "Process Swap" menu item which does not work
3341         https://bugs.webkit.org/show_bug.cgi?id=193344
3342
3343         Reviewed by Simon Fraser.
3344
3345         There is a menu item under the Experimental menu that does work.
3346
3347         * MiniBrowser/mac/AppDelegate.m:
3348         (defaultConfiguration):
3349         * MiniBrowser/mac/SettingsController.h:
3350         * MiniBrowser/mac/SettingsController.m:
3351         (-[SettingsController _populateMenu]):
3352         (-[SettingsController validateMenuItem:]):
3353         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
3354         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
3355
3356 2019-01-10  Timothy Hatcher  <timothy@apple.com>
3357
3358         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
3359         https://bugs.webkit.org/show_bug.cgi?id=193327
3360         rdar://problem/47093222
3361
3362         Reviewed by Tim Horton.
3363
3364         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3365         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
3366         (TestWebKitAPI::didFinishNavigation):
3367         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3368         (TestWebKitAPI::TEST):
3369         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm: Added.
3370         (TestWebKitAPI::ForceLightAppearanceInBundleTest::ForceLightAppearanceInBundleTest):
3371         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didCreatePage):
3372         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
3373         * TestWebKitAPI/Tests/WebKit/mac/dark-mode.html: Added.
3374
3375 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3376
3377         Leak of WKWebProcessPlugInHitTestResult (160 bytes) in com.apple.WebKit.WebContent running layout tests
3378         https://bugs.webkit.org/show_bug.cgi?id=193338
3379         <rdar://problem/46664774>
3380
3381         Reviewed by David Kilzer.
3382
3383         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3384         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
3385
3386 2019-01-10  Commit Queue  <commit-queue@webkit.org>
3387
3388         Unreviewed, rolling out r239825.
3389         https://bugs.webkit.org/show_bug.cgi?id=193330
3390
3391         Broke tests on armv7/linux bots (Requested by guijemont on
3392         #webkit).
3393
3394         Reverted changeset:
3395
3396         "Enable DFG on ARM/Linux again"
3397         https://bugs.webkit.org/show_bug.cgi?id=192496
3398         https://trac.webkit.org/changeset/239825
3399
3400 2019-01-10  Zhifei Fang  <zhifei_fang@apple.com>
3401
3402         Disable the run-jsc-stress-test remote host key check.
3403         https://bugs.webkit.org/show_bug.cgi?id=192988
3404
3405         Reviewed by Alexey Proskuryakov.
3406
3407         * Scripts/run-jsc-stress-tests:
3408
3409 2019-01-10  John Wilander  <wilander@apple.com>
3410
3411         Override the session configuration for cookieAcceptPolicy
3412         https://bugs.webkit.org/show_bug.cgi?id=190925
3413         <rdar://problem/45497382>
3414
3415         Reviewed by Alexey Proskuryakov and Alex Christensen.
3416
3417         Test infrastructure for setting a first-party-only cookie policy.
3418
3419         * DumpRenderTree/TestRunner.cpp:
3420         (setOnlyAcceptFirstPartyCookiesCallback):
3421         (TestRunner::staticFunctions):
3422         * DumpRenderTree/TestRunner.h:
3423         * DumpRenderTree/mac/TestRunnerMac.mm:
3424         (TestRunner::setOnlyAcceptFirstPartyCookies):
3425         * DumpRenderTree/win/TestRunnerWin.cpp:
3426         (TestRunner::setOnlyAcceptFirstPartyCookies):
3427         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3428         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3429         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
3430         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3431         * WebKitTestRunner/TestInvocation.cpp:
3432         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3433
3434 2019-01-09  Matt Rajca  <mrajca@apple.com>
3435
3436         Put per-document autoplay behavior behind runtime website policies quirk instead of a compile time flag
3437         https://bugs.webkit.org/show_bug.cgi?id=193301
3438
3439         Reviewed by Jer Noble.
3440         
3441         Added API tests.
3442
3443         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3444         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3445         (TEST):
3446         * TestWebKitAPI/Tests/WebKitCocoa/autoplaying-multiple-media-elements.html: Added.
3447
3448 2019-01-10  Zalan Bujtas  <zalan@apple.com>
3449
3450         [LFC][BFC][MarginCollapsing] Take collapsed through siblings into account when computing vertical position
3451         https://bugs.webkit.org/show_bug.cgi?id=193310
3452
3453         Reviewed by Antti Koivisto.
3454
3455         * LayoutReloaded/misc/LFC-passing-tests.txt:
3456
3457 2019-01-10  Dominik Infuehr  <dinfuehr@igalia.com>
3458
3459         Enable DFG on ARM/Linux again
3460         https://bugs.webkit.org/show_bug.cgi?id=192496
3461
3462         Reviewed by Yusuke Suzuki.
3463
3464         After changing the bytecode format DFG was disabled on all 32-bit
3465         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
3466         on ARM by default.
3467
3468         * Scripts/run-jsc-stress-tests:
3469
3470 2019-01-09  Fujii Hironori  <Hironori.Fujii@sony.com>
3471
3472         [Win][MiniBrowser] wchar_t strings shouldn't be treated as BSTR
3473         https://bugs.webkit.org/show_bug.cgi?id=193271
3474
3475         Reviewed by Brent Fulgham.
3476
3477         BSTR is a special data structure created by SysAllocString, not a
3478         wchar_t null-terminated string.
3479
3480         * DumpRenderTree/win/TestRunnerWin.cpp:
3481         (TestRunner::setDatabaseQuota): Use L"" instead of "" for _bstr_t.
3482         * MiniBrowser/win/MiniBrowserWebHost.cpp:
3483         (MiniBrowserWebHost::didFinishLoadForFrame): Use _bstr_t to create
3484         BSTR from wide string literals.
3485
3486 2019-01-09  Alexey Proskuryakov  <ap@apple.com>
3487
3488         Tweak wording for build/version_check style checker error
3489         https://bugs.webkit.org/show_bug.cgi?id=193256
3490
3491         Reviewed by Tim Horton.
3492
3493         * Scripts/webkitpy/style/checkers/cpp.py:
3494         (check_os_version_checks):
3495         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3496         (WebKitStyleTest.test_os_version_checks):
3497
3498 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3499
3500         [ews-build] Add link to bug along with bug title
3501         https://bugs.webkit.org/show_bug.cgi?id=193293
3502
3503         Reviewed by Lucas Forschler.
3504
3505         * BuildSlaveSupport/ews-build/steps.py:
3506         (ValidatePatch._is_bug_closed): Fetch bug title from Bugzilla and add it to the build.
3507         (ConfigureBuild.add_bug_id_url): Deleted.
3508         (ConfigureBuild.getBugURL): Deleted.
3509
3510 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3511
3512         [ews-build] Use https for ews-build server
3513         https://bugs.webkit.org/show_bug.cgi?id=193193
3514
3515         Reviewed by Lucas Forschler.
3516
3517         * BuildSlaveSupport/ews-build/steps.py:
3518
3519 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3520
3521         [ews-build] Parse and display number of style failures
3522         https://bugs.webkit.org/show_bug.cgi?id=193280
3523
3524         Reviewed by Lucas Forschler.
3525
3526         * BuildSlaveSupport/ews-build/steps.py:
3527         (CheckStyle): Use TestWithFailureCount as base class.
3528         (CheckStyle.countFailures): Count the number of style failures.
3529
3530 2019-01-09  Aakash Jain  <aakash_jain@apple.com>
3531
3532         [ews-build] use patch_id instead of ewspatchid
3533         https://bugs.webkit.org/show_bug.cgi?id=193235
3534
3535         Reviewed by Lucas Forschler.
3536
3537         * BuildSlaveSupport/ews-build/factories.py: Replaced ewspatchid with patch_id.
3538         * BuildSlaveSupport/ews-build/steps.py: Ditto.
3539         * BuildSlaveSupport/ews-build/steps_unittest.py: Ditto.
3540
3541 2019-01-09  Zalan Bujtas  <zalan@apple.com>
3542
3543         [LFC][BFC][MarginCollapsing] Add support for peculiar cases.
3544         https://bugs.webkit.org/show_bug.cgi?id=192625
3545
3546         Reviewed by Antti Koivisto.
3547
3548         * LayoutReloaded/misc/LFC-passing-tests.txt:
3549
3550 2019-01-09  Michael Catanzaro  <mcatanzaro@igalia.com>
3551
3552         [WPE][GTK] Purge use of g_assert() under TestWebKitAPI
3553         https://bugs.webkit.org/show_bug.cgi?id=192841
3554
3555         Reviewed by Carlos Garcia Campos.
3556
3557         There are separate g_assert_*() macros for use in tests, which we use inconsistently
3558         currently. Use them always. We'll get nicer error messages now when tests fail, and the
3559         assertions will now run during tests even if G_DISABLE_ASSERT is used when building.
3560
3561         Note that the documentation of g_assert() says that it is not to be used when writing tests.
3562
3563         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3564         * TestWebKitAPI/Tests/WebKitGLib/EditorTest.cpp:
3565         (WebKitWebEditorTest::testSelectionChanged):
3566         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
3567         (WebKitFrameTest::testMainFrame):
3568         (WebKitFrameTest::testURI):
3569         (WebKitFrameTest::testJavaScriptContext):
3570         (WebKitFrameTest::testJavaScriptValues):
3571         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
3572         (testWebViewAuthenticationRequest):
3573         (testWebViewAuthenticationLoadCancelled):
3574         (testWebViewAuthenticationFailure):
3575         (testWebViewAuthenticationStorage):
3576         (ProxyAuthenticationTest::ProxyAuthenticationTest):
3577         (testWebViewAuthenticationProxy):
3578         (testWebViewAuthenticationProxyHTTPS):
3579         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3580         (testAutomationSessionRequestSession):
3581         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
3582         (testBackForwardListNavigation):
3583         (testWebKitWebViewSessionState):
3584         (testWebKitWebViewSessionStateWithFormData):
3585         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
3586         (ConsoleMessageTest::consoleMessageReceivedCallback):
3587         (testWebKitConsoleMessageConsoleAPI):
3588         (testWebKitConsoleMessageJavaScriptException):
3589         (testWebKitConsoleMessageNetworkError):
3590         (testWebKitConsoleMessageSecurityError):
3591         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3592         (testCookieManagerAcceptPolicy):
3593         (testCookieManagerCookiesChanged):
3594         (testCookieManagerPersistentStorage):
3595         (testCookieManagerPersistentStorageDeleteAll):
3596         (testCookieManagerEphemeral):
3597         * TestWebKitAPI/Tests/WebKitGLib/TestDOMElement.cpp:
3598         (testWebKitDOMElementAutoFill):
3599         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
3600         (downloadLocalFileSuccessfully):
3601         (createFileAtDestination):
3602         (testDownloadOverwriteDestinationDisallowed):
3603         (testDownloadLocalFileError):
3604         (testDownloadRemoteFile):
3605         (testDownloadRemoteFileError):
3606         (testWebViewDownloadURI):
3607         (testPolicyResponseDownload):
3608         (testPolicyResponseDownloadCancel):
3609         (testDownloadMIMEType):
3610         (contextMenuCallback):
3611         (testContextMenuDownloadActions):
3612         (testBlobDownload):
3613         * TestWebKitAPI/Tests/WebKitGLib/TestEditor.cpp:
3614         (testWebKitWebEditorSelectionChanged):
3615         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
3616         (testWebKitFrameMainFrame):
3617         (testWebKitFrameURI):
3618         (testWebKitFrameJavaScriptContext):
3619         (testWebKitFrameJavaScriptValues):
3620         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3621         (LoadStopTrackingTest::loadFailed):
3622         (testWebViewTitle):
3623         (testURIRequestHTTPHeaders):
3624         (testURIRequestHTTPMethod):
3625         (testURIResponseHTTPHeaders):
3626         (testRedirectToDataURI):
3627         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
3628         (testProcessPerWebView):
3629         (testWebProcessLimit):
3630         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
3631         (testWebViewResources):
3632         (testWebResourceLoading):
3633         (testWebResourceSuggestedFilename):
3634         (testWebResourceGetData):
3635         (testWebResourceGetDataError):
3636         (testWebViewResourcesHistoryCache):
3637         (testWebResourceSendRequest):
3638         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
3639         (testSSL):
3640         (testInsecureContent):
3641         (testTLSErrorsPolicy):
3642         (testTLSErrorsRedirect):
3643         (testTLSErrorsHTTPAuth):
3644         (testLoadFailedWithTLSErrors):
3645         (testSubresourceLoadFailedWithTLSErrors):
3646         (httpsServerCallback):
3647         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3648         (testWebViewCreateNavigationData):
3649         (testWebViewJavaScriptDialogs):
3650         (testWebViewWindowProperties):
3651         (testWebViewMouseTarget):
3652         (testWebViewFileChooserRequest):
3653         (testWebViewColorChooserRequest):
3654         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
3655         (testWebExtensionGetTitle):
3656         (testDocumentLoadedSignal):
3657         (testWebKitWebViewProcessCrashed):
3658         (testWebExtensionWindowObjectCleared):
3659         (testWebExtensionIsolatedWorld):
3660         (permissionRequestCallback):
3661         (didAssociateFormControlsCallback):
3662         (testWebExtensionFormControlsAssociated):
3663         (FormSubmissionTest::FormSubmissionTest):
3664         (FormSubmissionTest::testFormSubmissionResult):
3665         (testWebExtensionFormSubmissionSteps):
3666         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
3667         (testNotInitialized):
3668         (testClearDatabase):
3669         (testPrivateBrowsing):
3670         (testGetFavicon):
3671         (testWebViewFavicon):
3672         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
3673         (testFindControllerTextFound):
3674         (testFindControllerTextNotFound):
3675         (testFindControllerMatchCount):
3676         (testFindControllerMaxMatchCount):
3677         (testFindControllerNext):
3678         (testFindControllerPrevious):
3679         (testFindControllerCountedMatches):
3680         (testFindControllerOptions):
3681         (testFindControllerHide):
3682         (testFindControllerInstance):
3683         (testFindControllerGetters):
3684         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp:
3685         (testNavigationPolicy):
3686         (testResponsePolicy):
3687         (testNewWindowPolicy):
3688         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
3689         (testSecurityOriginBasicConstructor):
3690         (testSecurityOriginURIConstructor):
3691         (testSecurityOriginDefaultPort):
3692         (testSecurityOriginFileURI):
3693         (testOpaqueSecurityOrigin):
3694         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3695         (testWebKitSettings):
3696         (testWebKitSettingsNewWithSettings):
3697         (testWebKitSettingsUserAgent):
3698         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
3699         (testWebViewNewWithUserContentManager):
3700         (isStyleSheetInjectedForURLAtPath):
3701         (isScriptInjectedForURLAtPath):
3702         (testUserContentManagerInjectedStyleSheet):
3703         (testUserContentManagerInjectedScript):
3704         (UserScriptMessageTest::scriptMessageReceived):
3705         (UserScriptMessageTest::waitUntilMessageReceived):
3706         (UserScriptMessageTest::runJavaScriptFinished):
3707         (testUserContentManagerScriptMessageReceived):
3708         (testUserContentManagerScriptMessageInWorldReceived):
3709         (testUserContentManagerScriptMessageFromDOMBindings):
3710         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
3711         (testWebContextDefault):
3712         (testWebContextEphemeral):
3713         (testWebContextGetPlugins):
3714         (testWebContextURIScheme):
3715         (testWebContextSpellChecker):
3716         (testWebContextLanguages):
3717         (consoleMessageReceivedCallback):
3718         (testWebContextSecurityFileXHR):
3719         (ProxyTest::ProxyTest):
3720         (testWebContextProxySettings):
3721         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3722         (testWebViewWebContext):
3723         (testWebViewWebBackend):
3724         (testWebViewEphemeral):
3725         (testWebViewCustomCharset):
3726         (testWebViewSettings):
3727         (testWebViewRunJavaScript):
3728         (testWebViewCanShowMIMEType):
3729         (testWebViewSubmitForm):
3730         (testWebViewSave):
3731         (testWebViewPageVisibility):
3732         (testWebViewSnapshot):
3733         (testWebViewNotification):
3734         (testWebViewNotificationInitialPermissionAllowed):
3735         (testWebViewNotificationInitialPermissionDisallowed):
3736         (testWebViewIsPlayingAudio):
3737         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
3738         (WebsiteDataTest::WebsiteDataTest):
3739         (WebsiteDataTest::remove):
3740         (WebsiteDataTest::clear):
3741         (testWebsiteDataConfiguration):
3742         (testWebsiteDataEphemeral):
3743         (testWebsiteDataCache):
3744         (testWebsiteDataStorage):
3745         (testWebsiteDataDatabases):
3746         (testWebsiteDataAppcache):
3747         (testWebsiteDataCookies):
3748         (testWebsiteDataDeviceIdHashSalt):
3749         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3750         (emitDocumentLoaded):
3751         (emitURIChanged):
3752         (sendRequestCallback):
3753         (contextMenuCallback):
3754         (consoleMessageSentCallback):
3755         (emitFormControlsAssociated):
3756         (formControlsAssociatedCallback):
3757         (emitFormSubmissionEvent):
3758         (willSubmitFormCallback):
3759         (windowObjectCleared):
3760         (methodCallCallback):
3761         (registerGResource):
3762         (webkit_web_extension_initialize_with_user_data):
3763         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp:
3764         (checkLeaks):
3765         (WebProcessTest::create):
3766         (runTest):
3767         * TestWebKitAPI/Tests/WebKitGtk/AutocleanupsTest.cpp:
3768         (AutocleanupsTest::testWebProcessAutocleanups):
3769         * TestWebKitAPI/Tests/WebKitGtk/DOMClientRectTest.cpp:
3770         (WebKitDOMClientRectTest::testDivBoundingClientRectPosition):
3771         (WebKitDOMClientRectTest::testDivClientRectsPositionAndLength):
3772         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
3773         (WebKitDOMDOMWindowTest::testSignals):
3774         (WebKitDOMDOMWindowTest::testDispatchEvent):
3775         (WebKitDOMDOMWindowTest::testGetComputedStyle):
3776         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeFilterTest.cpp:
3777         (WebKitDOMNodeFilterTest::testTreeWalker):
3778         (WebKitDOMNodeFilterTest::testNodeIterator):
3779         * TestWebKitAPI/Tests/WebKitGtk/DOMNodeTest.cpp:
3780         (WebKitDOMNodeTest::testHierarchyNavigation):
3781         (WebKitDOMNodeTest::testInsertion):
3782         (WebKitDOMNodeTest::testTagNamesNodeList):
3783         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
3784         (WebKitDOMNodeTest::testDOMCache):
3785         * TestWebKitAPI/Tests/WebKitGtk/DOMXPathNSResolverTest.cpp:
3786         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
3787         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
3788         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
3789         * TestWebKitAPI/Tests/WebKitGtk/TestAutocleanups.cpp:
3790         (testUIProcessAutocleanups):
3791         (testWebProcessAutocleanups):
3792         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
3793         (testContextMenuPopulateMenu):
3794         (testContextMenuDismissed):
3795         * TestWebKitAPI/Tests/WebKitGtk/TestDOMClientRect.cpp:
3796         (testWebKitDOMClientRectDivBoundingClientRectPosition):
3797         (testWebKitDOMClientRectDivClientRectsPositionAndLength):
3798         * TestWebKitAPI/Tests/WebKitGtk/TestDOMDOMWindow.cpp:
3799         (testWebKitDOMDOMWindowSignals):
3800         (testWebKitDOMDOMWindowDispatchEvent):
3801         (testWebKitDOMDOMWindowGetComputedStyle):
3802         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNode.cpp:
3803         (testWebKitDOMNodeHierarchyNavigation):
3804         (testWebKitDOMNodeInsertion):
3805         (testWebKitDOMNodeTagNamesNodeList):
3806         (testWebKitDOMNodeTagNamesHTMLCollection):
3807         (testWebKitDOMObjectCache):
3808         * TestWebKitAPI/Tests/WebKitGtk/TestDOMNodeFilter.cpp:
3809         (testWebKitDOMNodeFilterTreeWalker):
3810         (testWebKitDOMNodeFilterNodeIterator):
3811         * TestWebKitAPI/Tests/WebKitGtk/TestDOMXPathNSResolver.cpp:
3812         (testWebKitDOMXPathNSResolverNative):
3813         (testWebKitDOMXPathNSResolverCustom):
3814         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
3815         (testInspectorDefault):
3816         (testInspectorManualAttachDetach):
3817         (testInspectorCustomContainerDestroyed):
3818         * TestWebKitAPI/Tests/WebKitGtk/TestInspectorServer.cpp:
3819         (startTestServer):
3820         (testInspectorServerPageList):
3821         * TestWebKitAPI/Tests/WebKitGtk/TestOptionMenu.cpp:
3822         (OptionMenuTest::showOptionMenuCallback):
3823         (OptionMenuTest::menuCloseCallback):
3824         (OptionMenuTest::close):
3825         (OptionMenuTest::activateItem):
3826         (OptionMenuTest::selectItem):
3827         (testOptionMenuSimple):
3828         (testOptionMenuGroups):
3829         (testOptionMenuActivate):
3830         (testOptionMenuSelect):
3831         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
3832         (testPrintOperationPrintSettings):
3833         (webViewPrintCallback):
3834         (testPrintOperationPrint):
3835         (testPrintCustomWidget):
3836         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
3837         (checkAtspiAccessible):
3838         (testAtspiBasicHierarchy):
3839         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitVersion.cpp:
3840         (testWebKitCheckVersion):
3841         * TestWebKitAPI/Tests/WebKitGtk/TestWebViewEditor.cpp:
3842         (testWebViewEditorCutCopyPasteNonEditable):
3843         (testWebViewEditorCutCopyPasteEditable):
3844         (testWebViewEditorSelectAllNonEditable):
3845         (testWebViewEditorSelectAllEditable):
3846         (loadContentsAndTryToCutSelection):
3847         (testWebViewEditorNonEditable):
3848         (testWebViewEditorEditable):
3849         (testWebViewEditorEditorStateTypingAttributes):
3850         (testWebViewEditorInsertImage):
3851         (testWebViewEditorCreateLink):
3852         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
3853         (loadChangedCallback):
3854         (loadFailedCallback):
3855         (loadFailedWithTLSErrorsCallback):
3856         (LoadTrackingTest::LoadTrackingTest):
3857         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
3858         (registerGResource):
3859         (removeNonEmptyDirectory):
3860         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3861         (Test::adoptView):
3862         (Test::~Test):
3863         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
3864         (WebKitTestBus::getOrCreateConnection):
3865         (WebKitTestBus::createProxy):
3866         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
3867         (WebKitTestServer::getWebSocketURIForPath const):
3868         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
3869         (WebViewTest::initializeWebView):
3870         (WebViewTest::loadURI):
3871         (WebViewTest::loadHtml):
3872         (WebViewTest::loadPlainText):
3873         (WebViewTest::loadBytes):
3874         (WebViewTest::loadRequest):
3875         (WebViewTest::loadAlternateHTML):
3876         (WebViewTest::goBack):
3877         (WebViewTest::goForward):
3878         (WebViewTest::goToBackForwardListItem):
3879         (resourceGetDataCallback):
3880         (WebViewTest::mainResourceData):
3881         (WebViewTest::javascriptResultToCString):
3882         (WebViewTest::javascriptResultToNumber):
3883         (WebViewTest::javascriptResultToBoolean):
3884         (WebViewTest::javascriptResultIsNull):
3885         (WebViewTest::javascriptResultIsUndefined):
3886         (onSnapshotReady):
3887         (WebViewTest::runWebProcessTest):
3888         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
3889         (WebViewTest::platformInitializeWebView):
3890         (WebViewTest::showInWindow):
3891         (WebViewTest::showInWindowAndWaitUntilMapped):
3892         (WebViewTest::mouseMoveTo):
3893         (WebViewTest::emitPopupMenuSignal):
3894         (WebViewTest::keyStroke):
3895         (WebViewTest::doMouseButtonEvent):
3896
3897 2019-01-09  Philippe Normand  <pnormand@igalia.com>
3898
3899         [WPE] API tests can't run in flatpak environment
3900         https://bugs.webkit.org/show_bug.cgi?id=193242
3901
3902         Reviewed by Michael Catanzaro.
3903
3904         * Scripts/run-wpe-tests: Add --wpe to arguments passed to
3905         flatpakutils so that it knows which port it's dealing with.
3906         * glib/common.py: Remove build_dir globals so that subsequent
3907         calls actually take args into account.
3908         (library_build_path):
3909         (binary_build_path):
3910
3911 2019-01-08  Dean Jackson  <dino@apple.com>
3912
3913         Blob references for System Previews don't get a correct file extension
3914         https://bugs.webkit.org/show_bug.cgi?id=193268
3915         <rdar://problem/47133037>
3916
3917         Reviewed by Tim Horton.
3918
3919         New test that a Blob download of a USDZ file gets named correctly.
3920
3921         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3922         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3923         (-[BlobWithUSDZExtensionDownloadDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3924         (-[BlobWithUSDZExtensionDownloadDelegate _downloadDidFinish:]):
3925         (TEST):
3926         * TestWebKitAPI/Tests/WebKitCocoa/SystemPreviewBlobNaming.html: Added.
3927
3928 2019-01-08  Jiewen Tan  <jiewen_tan@apple.com>
3929
3930         [WebAuthN] Support U2F HID Authenticators on macOS
3931         https://bugs.webkit.org/show_bug.cgi?id=191535
3932         <rdar://problem/47102027>
3933
3934         Reviewed by Brent Fulgham.
3935
3936         This patch:
3937         1) adds support for U2F mocking mechanism;
3938         2) updates tests to reflect U2fCommandConstructor changes.
3939
3940         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
3941         (TestWebKitAPI::TEST):
3942         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
3943         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3944         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
3945
3946 2019-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3947
3948         [iOS] Dispatch a synthetic mousedown event prior to starting drags
3949         https://bugs.webkit.org/show_bug.cgi?id=193229
3950         <rdar://problem/46717097>
3951
3952         Reviewed by Tim Horton.
3953
3954         Add a cross-platform drag and drop test to verify that calling `preventDefault()` on the mousedown event
3955         prevents a drag from starting.
3956
3957         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
3958         * TestWebKitAPI/Tests/WebKitCocoa/link-and-target-div.html:
3959
3960         Tweak this test to make it robust when dragging the link to the target element multiple times in a single test.
3961
3962 2019-01-08  Zhifei Fang  <zhifei_fang@apple.com>
3963   
3964         Layout test will generate a perf metric file to results dir.
3965         https://bugs.webkit.org/show_bug.cgi?id=192030
3966         <rdar://problem/32779516>
3967
3968         Reviewed by Aakash Jain.
3969
3970         Layout test running time will be collected to a perf metric file.
3971         For now, instead of outputing running time of all tests (which is huge),
3972         we aggregate them by test directories which are at most two level deep. 
3973
3974         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3975         (Manager._end_test_run):
3976         (Manager._output_perf_metrics):
3977         (Manager._print_expectation_line_for_test):
3978         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3979         (add_test_perf_metric):
3980         (test_perf_metrics):
3981         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3982         (JSONGeneratorTest.test_test_timings_trie):
3983         (JSONGeneratorTest):
3984         (JSONGeneratorTest.test_test_perf_metrics):
3985         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3986         (RebaselineTest.test_reset_results):
3987         (RebaselineTest.test_missing_results):
3988         (RebaselineTest.test_new_baseline):
3989
3990 2019-01-08  Patrick Griffis  <pgriffis@igalia.com>
3991
3992         [WPE][GTK] Add php-json to install-dependencies
3993         https://bugs.webkit.org/show_bug.cgi?id=193233
3994
3995         Reviewed by Michael Catanzaro.
3996
3997         * gtk/install-dependencies:
3998         * wpe/install-dependencies:
3999
4000 2019-01-08  Chris Dumez  <cdumez@apple.com>
4001
4002         Regression(PSON-r239182): Blank view when navigating back and forth between google.com and stack overflow
4003         https://bugs.webkit.org/show_bug.cgi?id=193224
4004         <rdar://problem/47097726>
4005
4006         Reviewed by Alex Christensen.
4007
4008         Add API test coverage.
4009
4010         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4011
4012 2019-01-07  David Kilzer  <ddkilzer@apple.com>
4013
4014         Leak of ScrollCompletionCallbackData (16 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
4015         <https://webkit.org/b/193222>
4016         <rdar://problem/46862309>
4017
4018         Reviewed by Joseph Pecoraro.
4019
4020         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
4021         (WTR::executeCallback): Fix camel case of variable name.
4022         (WTR::EventSendingController::callAfterScrollingCompletes): If
4023         WKBundlePageRegisterScrollOperationCompletionCallback() returns
4024         false, make sure to release the ScrollCompletionCallbackData
4025         object.  This fixes the leak.
4026
4027 2019-01-07  Fujii Hironori  <Hironori.Fujii@sony.com>
4028
4029         [Win] EWS: wincairo-ews cannot apply a patch with *.png
4030         https://bugs.webkit.org/show_bug.cgi?id=193044
4031
4032         Reviewed by Daniel Bates.
4033
4034         WinCairo EWS bots are using Windows Perl. Binary files should be
4035         opened as binary mode.
4036
4037         * Scripts/svn-apply:
4038         (handleGitBinaryChange): Use 'binmode' for binary file handles.
4039
4040 2019-01-07  Don Olmstead  <don.olmstead@sony.com>
4041
4042         [CMake] Add ENABLE_CSS_TYPED_OM option
4043         https://bugs.webkit.org/show_bug.cgi?id=193216
4044
4045         Reviewed by Michael Catanzaro.
4046
4047         * Scripts/webkitperl/FeatureList.pm:
4048
4049 2019-01-07  David Kilzer  <ddkilzer@apple.com>
4050
4051         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
4052         <https://webkit.org/b/193056>
4053
4054         Reviewed by Alex Christensen.
4055
4056         * Scripts/webkitpy/style/checker.py:
4057         - Ignore use of new runtime/retainptr check in
4058           Tools/TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm since it
4059           contains tests to ensure RetainPtr<NSObject *> is compatible
4060           with RetainPtr<NSObject>.
4061
4062         * Scripts/webkitpy/style/checkers/cpp.py:
4063         (check_language):
4064         (CppChecker):
4065         - Add checker for use of '*' in RetainPtr<> type.  A for loop
4066           was used instead of a single regex so that angle brackets
4067           could be matched up when checking the type contained within
4068           the RetainPtr<> type.
4069
4070         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4071         (CppStyleTest):
4072         - Add unit test for new runtime/retainptr check.
4073
4074         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.h:
4075         * TestWebKitAPI/EditingTestHarness.h:
4076         - Remove '*' from RetainPtr<> type.
4077
4078         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4079         - Add cf/RetainPtr.cpp back to TestWTFLibrary target!  This
4080           regressed in r201938.
4081
4082         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
4083         (TestWebKitAPI::TEST):
4084         - Update tests to match RetainPtr.mm tests (except for the
4085           `*SimilarNSType` tests since there is no CF equivalent of
4086           RetainPtr<NSString> and RetainPtr<NSString *>).
4087
4088         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
4089         (TestWebKitAPI::TEST):
4090         - Update tests to:
4091           - Not conflict by name with equivalent CF tests in
4092             RetainPtr.cpp.
4093           - Add test cases for RetainPtr<NSObject>,
4094             RetainPtr<NSObject *> and RetainPtr<id> were appropriate.
4095           - Add `*SimilarNSType` tests for converting between
4096             RetainPtr<NSObject> and RetainPtr<NSObject *>.
4097           - Change `0` to `nil` as appropriate.
4098           - Re-alphabetize the tests by name.
4099           - Add Optional<RetainPtr<>> tests.
4100           - Add retainPtr() tests.
4101
4102         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
4103         (-[DownloadProgressTestRunner _download:decideDestinationWithSuggestedFilename:completionHandler:]):
4104         * TestWebKitAPI/Tests/WebKitCocoa/IconLoadingDelegate.mm:
4105         (TEST):
4106         - Remove '*' from RetainPtr<> type.
4107
4108         * TestWebKitAPI/Tests/WebKitCocoa/JITEnabled.mm:
4109         (TEST(WebKit, JITEnabled)):
4110         - Add missing WTFMove().  Apparently a temporary was being
4111           created before in the argument list due to mismatched
4112           RetainPtr<> types.
4113
4114         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4115         * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
4116         (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager):
4117         (TestWebKitAPI::TEST):
4118         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4119         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
4120         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
4121         (WTR::resourcesDirectoryURL):
4122         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
4123         (WTR::InjectedBundle::platformInitialize):
4124         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
4125         - Remove '*' from RetainPtr<> type.
4126
4127 2019-01-07  Eric Carlson  <eric.carlson@apple.com>
4128
4129         A MediaTime timescale must never be zero
4130         https://bugs.webkit.org/show_bug.cgi?id=193156
4131         <rdar://problem/32504501>
4132
4133         Reviewed by Jer Noble.
4134
4135         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
4136         (TestWebKitAPI::TEST): Add tests for zero timescale.
4137
4138 2019-01-07  Youenn Fablet  <youenn@apple.com>
4139
4140         API test broken: TestWebKitAPI.WebKit.CustomDataStorePathsVersusCompletionHandlers
4141         https://bugs.webkit.org/show_bug.cgi?id=193175
4142
4143         Reviewed by Chris Dumez.
4144
4145         Updated API test as we bumped the SW schema to version 4.
4146
4147         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4148         * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-4.sqlite3: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-3.sqlite3.
4149         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
4150         (TEST):
4151
4152 2019-01-06  Fujii Hironori  <Hironori.Fujii@sony.com>
4153
4154         [Win][Clang] Fix compilation warnings of MiniBrowser
4155         https://bugs.webkit.org/show_bug.cgi?id=193029
4156
4157         Reviewed by Ross Kirsling.
4158
4159         * MiniBrowser/win/MiniBrowserWebHost.h: Removed unused m_oldFont
4160         and m_URLBarFont. Reorder member variables to fix -Wreorder
4161         warning.
4162         * MiniBrowser/win/PageLoadTestClient.cpp:
4163         (PageLoadTestClient::PageLoadTestClient): Reorder the member initializer list.
4164         * MiniBrowser/win/PageLoadTestClient.h: Removed 'virtual' of
4165         pageLoadStartedAtTime and pageLoadEndedAtTime. Removed unused
4166         m_currentURLIndex.
4167         * MiniBrowser/win/WebKitBrowserWindow.cpp:
4168         (WebKitBrowserWindow::WebKitBrowserWindow): Initialize
4169         navigationClient with '{ }' to fix the missing field warning.
4170         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
4171         (initDocStruct): Changed the argument type docname to const.
4172
4173 2019-01-06  Jiewen Tan  <jiewen_tan@apple.com>
4174
4175         [WebAuthN] Import U2F command/response converters from Chromium
4176         https://bugs.webkit.org/show_bug.cgi?id=193150
4177         <rdar://problem/47054028>
4178
4179         Reviewed by Brent Fulgham.
4180
4181         Adds API tests.
4182
4183         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4184         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp:
4185         (TestWebKitAPI::getTestAttestedCredentialDataBytes):
4186         (TestWebKitAPI::getTestAuthenticatorDataBytes):
4187         (TestWebKitAPI::getTestAttestationObjectBytes):
4188         (TestWebKitAPI::getTestSignResponse):
4189         (TestWebKitAPI::getTestU2fRegisterResponse):
4190         (TestWebKitAPI::TEST):
4191         (TestWebKitAPI::convertToVector): Deleted.
4192         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
4193         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp: Added.
4194         (TestWebKitAPI::constructMakeCredentialRequest):
4195         (TestWebKitAPI::constructGetAssertionRequest):
4196         (TestWebKitAPI::TEST):
4197
4198 2019-01-05  Oriol Brufau  <obrufau@igalia.com>
4199
4200         [GTK] Add python3-setuptools, libunistring-dev, bison and flex dependencies
4201         https://bugs.webkit.org/show_bug.cgi?id=193136
4202
4203         Reviewed by Michael Catanzaro.
4204
4205         * gtk/install-dependencies:
4206         Add python3-setuptools, libunistring-dev, bison and flex to install-dependencies,
4207         they are needed by update-webkitgtk-libs.
4208
4209 2019-01-05  Aakash Jain  <aakash_jain@apple.com>
4210
4211         Unreviewed follow-up fix to r239650
4212         https://bugs.webkit.org/show_bug.cgi?id=193140
4213         <rdar://problem/47063037>
4214
4215         Typecast patch_id to string.
4216
4217         * BuildSlaveSupport/ews-build/steps.py:
4218         (ValidatePatch._is_patch_obsolete):
4219
4220 2019-01-04  Daniel Bates  <dabates@apple.com>
4221
4222         [lldb-webkit]: Add support for pretty-printing raw bitmask types
4223         https://bugs.webkit.org/show_bug.cgi?id=193024
4224
4225         Reviewed by Jer Noble.
4226
4227         Add support infrastructure to pretty-print a raw bitmask type. Included is a pretty-printer
4228         for the bitmask type WebEventFlags as an example.
4229
4230         Exposed a new function lldb_webkit.addSummaryAndSyntheticFormattersForRawBitmaskType()
4231         that can be used to register summary and synthetic child formatters for a bitmask type.
4232         For example, consider the following enum and bitmask typedefs:
4233
4234         typedef enum {
4235             A = 1 << 0,
4236             B = 1 << 1,
4237             C = 1 << 2,
4238         } SpecialFlagValues;
4239         typedef unsigned SpecialFlags;
4240
4241         To teach lldb-webkit how to pretty print SpecialFlags types, add the following code inside
4242         __lldb_init_module():
4243
4244             addSummaryAndSyntheticFormattersForRawBitmaskType(debugger, "SpecialFlags", {
4245                     1 << 0: "A",
4246                     1 << 1: "B",
4247                     1 << 2: "C",
4248             })
4249
4250         * lldb/lldb_webkit.py:
4251         (addSummaryAndSyntheticFormattersForRawBitmaskType):
4252         (addSummaryAndSyntheticFormattersForRawBitmaskType.GeneratedRawBitmaskProvider):
4253         (addSummaryAndSyntheticFormattersForRawBitmaskType.raw_bitmask_summary_provider):
4254         (addSummaryAndSyntheticFormattersForRawBitmaskType.lldb_webkit):
4255         A convenience function to dynamically creaste a synthetic formatter class and summary
4256         string function for the specified bitmask type and enumerator value to name map. This
4257         function register the dynamically created class and function with LLDB.
4258
4259         (__lldb_init_module):
4260         (FlagEnumerationProvider):
4261         (FlagEnumerationProvider._enumerator_value_to_name_map):
4262         (FlagEnumerationProvider._bitmask):
4263         (FlagEnumerationProvider._update):
4264         (FlagEnumerationProvider.has_children):
4265         (FlagEnumerationProvider.num_children):
4266         (FlagEnumerationProvider.get_child_index):
4267         (FlagEnumerationProvider.get_child_at_index):
4268         (FlagEnumerationProvider.update):
4269         Extract out provider logic from WTFOptionSetProvider into a base class that can be shared.
4270
4271         (WTFOptionSetProvider):
4272         (WTFOptionSetProvider._enumerator_value_to_name_map):
4273         (WTFOptionSetProvider._bitmask):
4274         (WTFOptionSetProvider._update):
4275         Write in terms of the base class.
4276
4277         (RawBitmaskProviderBase):
4278         (RawBitmaskProviderBase._enumerator_value_to_name_map):
4279         (RawBitmaskProviderBase._bitmask):
4280         Added. Base synthetic formatter class for a raw bitmask type. Derived classes are expected to
4281         override the class variable ENUMERATOR_VALUE_TO_NAME_MAP with a dictionary of the form:
4282         {
4283             1 << 0: "A",
4284             1 << 1: "B",
4285             1 << 2: "C",
4286         }
4287         It is not necessary to instantiate such a derived class directory. Instead use the convenience
4288         function addSummaryAndSyntheticFormattersForRawBitmaskType.
4289
4290         (WTFOptionSetProvider.has_children): Deleted.
4291         (WTFOptionSetProvider.num_children): Deleted.
4292         (WTFOptionSetProvider.get_child_index): Deleted.
4293         (WTFOptionSetProvider.get_child_at_index): Deleted.
4294         (WTFOptionSetProvider.update): Deleted.
4295
4296 2019-01-04  Aakash Jain  <aakash_jain@apple.com>
4297
4298         [ews-build] Add build step to validate the patch before processing it
4299         https://bugs.webkit.org/show_bug.cgi?id=193140
4300
4301         Reviewed by Lucas Forschler.
4302
4303         * BuildSlaveSupport/ews-build/factories.py:
4304         (Factory.__init__): Added ValidatePatch step.
4305         * BuildSlaveSupport/ews-build/steps.py:
4306         (ValidatePatch):
4307         (ValidatePatch.fetch_data_from_url): Fetch data from a url.
4308         (ValidatePatch.get_patch_json): Get patch json data.
4309         (ValidatePatch.get_bug_json): Get bug json data.
4310         (ValidatePatch.get_bug_id_from_patch): Get bug id from a patch id.
4311         (ValidatePatch._is_patch_obsolete): Check if the patch is obsolete.
4312         (ValidatePatch._is_patch_review_denied): Check if the patch is marked r-.
4313         (ValidatePatch._is_bug_closed): Check if the bug is already closed.
4314         (ValidatePatch.skip_build): Skip the build.
4315         (ValidatePatch.start):
4316
4317 2019-01-04  Alex Christensen  <achristensen@webkit.org>
4318
4319         Progress towards fixing Mac CMake build
4320         https://bugs.webkit.org/show_bug.cgi?id=193105
4321
4322         Reviewed by Don Olmstead.
4323
4324         * TestWebKitAPI/PlatformMac.cmake:
4325
4326 2019-01-04  Alex Christensen  <achristensen@webkit.org>
4327
4328         Fix API test after r239631
4329         https://bugs.webkit.org/show_bug.cgi?id=193118
4330
4331         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
4332         (TestWebKitAPI::TEST):
4333         This test relied on m_maximumProcessCount being set to 1 in ProcessPoolConfiguration::createWithLegacyOptions.