4cc097ffff6d7a0cc280d6561b0acb6e7baf8d82
[WebKit-https.git] / Tools / ChangeLog
1 2013-02-01  Roger Fong  <roger_fong@apple.com>
2
3         Unreviewed. Fix webkitpy tests since a build_style is not specified in some cases.
4
5         * Scripts/webkitpy/tool/steps/runtests.py:
6         (RunTests.run):
7
8 2013-02-01  Roger Fong  <roger_fong@apple.com>
9
10         Unreviewed. Re-try enabling Win-EWS tests for the third time. 
11         https://bugs.webkit.org/show_bug.cgi?id=107968
12
13         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
14         (WinEWS):
15
16 2013-01-31  Roger Fong  <roger_fong@apple.com>
17
18         Fix test scripts for EWS bots to get them running once and for all.
19         https://bugs.webkit.org/show_bug.cgi?id=108422
20
21         Reviewed by Timothy Horton.
22
23         Disabling --quiet option on Windows for now because that fails when we try to use /dev/null.
24         runtests.py was not passing in a configuration to run-webkit-tests which causes DRT to build in release by default.
25         However, we build in Debug only on the EWS Windows bots, which caused the build to fail.
26
27         * Scripts/webkitpy/tool/steps/runtests.py:
28         (RunTests.options):
29         (RunTests.run):
30
31 2013-02-01  Nico Weber  <thakis@chromium.org>
32
33         [chromium] Build webkit with enable_web_intents set to 0.
34         https://bugs.webkit.org/show_bug.cgi?id=108408
35
36         Reviewed by Tony Chang.
37
38         I'll then make chromium build fine with that, then switch
39         enable_web_intents to 0, roll that into webkit, and then
40         actually remove the code hidden behind this flag.
41
42         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
43         (WebTestRunner::TestRunner::TestRunner):
44         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
45         (WebTestRunner::WebTestProxyBase::registerIntentService):
46         (WebTestRunner::WebTestProxyBase::dispatchIntent):
47         * DumpRenderTree/chromium/WebViewHost.cpp:
48         * DumpRenderTree/chromium/WebViewHost.h:
49         (WebViewHost):
50
51 2013-02-01  Zan Dobersek  <zdobersek@igalia.com>
52
53         Set the GTK 64-bit Debug builder to build and test only WebKit1
54         https://bugs.webkit.org/show_bug.cgi?id=108648
55
56         Reviewed by Philippe Normand.
57
58         * BuildSlaveSupport/build.webkit.org-config/config.json: Change the builder name, type and
59         build directory to note that the builder builds and tests only the WebKit1 port on the GTK platform.
60         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
61         (CompileWebKit1Only): Add the new build class that builds only the WebKit1 port of the builder's platform.
62         (BuildAndTestWebKit1OnlyFactory): Add the new factory that uses the CompileWebKit1Only build class
63         for building and testing only WebKit1 on the builder's platform.
64
65 2013-02-01  Jochen Eisinger  <jochen@chromium.org>
66
67         [chromium] move ownership of TestRunner object to TestInterfaces
68         https://bugs.webkit.org/show_bug.cgi?id=108464
69
70         Reviewed by Adam Barth.
71
72         Before, TestShell owned the class. This also removes the last include
73         from DumpRenderTree to TestRunner/src.
74
75         This also deletes TestDelegate and uses WebTestDelegate everywhere
76         instead.
77
78         * DumpRenderTree/DumpRenderTree.gypi:
79         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
80         (WebTestInterfaces):
81         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
82         (WebKit):
83         (WebTestRunner):
84         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp:
85         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h:
86         (WebTestRunner):
87         (WebTestRunner::AccessibilityController::setDelegate):
88         (AccessibilityController):
89         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
90         (WebTestRunner):
91         (WebTestRunner::makeMenuItemStringsFor):
92         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
93         (WebTestRunner):
94         (WebTestRunner::EventSender::setDelegate):
95         (EventSender):
96         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp:
97         (WebTestRunner::GamepadController::setDelegate):
98         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h:
99         (WebTestRunner):
100         (GamepadController):
101         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h: Removed.
102         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
103         (WebTestRunner::TestInterfaces::TestInterfaces):
104         (WebTestRunner::TestInterfaces::~TestInterfaces):
105         (WebTestRunner::TestInterfaces::setWebView):
106         (WebTestRunner::TestInterfaces::setDelegate):
107         (WebTestRunner::TestInterfaces::bindTo):
108         (WebTestRunner::TestInterfaces::resetAll):
109         (WebTestRunner):
110         (WebTestRunner::TestInterfaces::setTestIsRunning):
111         (WebTestRunner::TestInterfaces::testRunner):
112         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
113         (WebTestRunner):
114         (TestInterfaces):
115         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
116         (WebTestRunner::TestRunner::TestRunner):
117         (WebTestRunner::TestRunner::reset):
118         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
119         (WebKit):
120         (TestRunner):
121         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
122         (WebTestRunner::WebTestInterfaces::Internal::testRunner):
123         (WebTestInterfaces::Internal):
124         (WebTestRunner::WebTestInterfaces::Internal::Internal):
125         (WebTestRunner::WebTestInterfaces::Internal::setDelegate):
126         (WebTestRunner::WebTestInterfaces::Internal::setTestIsRunning):
127         * DumpRenderTree/chromium/TestRunner/src/WebTestRunner.cpp: Added.
128         (WebTestRunner):
129         (WebTestRunner::WebTestRunner::WebTestRunner):
130         (WebTestRunner::WebTestRunner::shouldDumpEditingCallbacks):
131         (WebTestRunner::WebTestRunner::shouldDumpAsText):
132         (WebTestRunner::WebTestRunner::setShouldDumpAsText):
133         (WebTestRunner::WebTestRunner::shouldGeneratePixelResults):
134         (WebTestRunner::WebTestRunner::setShouldGeneratePixelResults):
135         (WebTestRunner::WebTestRunner::shouldDumpChildFrameScrollPositions):
136         (WebTestRunner::WebTestRunner::shouldDumpChildFramesAsText):
137         (WebTestRunner::WebTestRunner::shouldDumpAsAudio):
138         (WebTestRunner::WebTestRunner::audioData):
139         (WebTestRunner::WebTestRunner::shouldDumpFrameLoadCallbacks):
140         (WebTestRunner::WebTestRunner::setShouldDumpFrameLoadCallbacks):
141         (WebTestRunner::WebTestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
142         (WebTestRunner::WebTestRunner::stopProvisionalFrameLoads):
143         (WebTestRunner::WebTestRunner::shouldDumpTitleChanges):
144         (WebTestRunner::WebTestRunner::shouldDumpCreateView):
145         (WebTestRunner::WebTestRunner::canOpenWindows):
146         (WebTestRunner::WebTestRunner::shouldDumpResourceLoadCallbacks):
147         (WebTestRunner::WebTestRunner::shouldDumpResourceRequestCallbacks):
148         (WebTestRunner::WebTestRunner::shouldDumpResourceResponseMIMETypes):
149         (WebTestRunner::WebTestRunner::webPermissions):
150         (WebTestRunner::WebTestRunner::shouldDumpStatusCallbacks):
151         (WebTestRunner::WebTestRunner::shouldDumpProgressFinishedCallback):
152         (WebTestRunner::WebTestRunner::shouldDumpBackForwardList):
153         (WebTestRunner::WebTestRunner::deferMainResourceDataLoad):
154         (WebTestRunner::WebTestRunner::shouldDumpSelectionRect):
155         (WebTestRunner::WebTestRunner::testRepaint):
156         (WebTestRunner::WebTestRunner::sweepHorizontally):
157         (WebTestRunner::WebTestRunner::isPrinting):
158         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
159         (WebTestRunner::WebTestRunner::setTitleTextDirection):
160         (WebTestRunner::WebTestRunner::httpHeadersToClear):
161         (WebTestRunner::WebTestRunner::shouldBlockRedirects):
162         (WebTestRunner::WebTestRunner::willSendRequestShouldReturnNull):
163         (WebTestRunner::WebTestRunner::setTopLoadingFrame):
164         (WebTestRunner::WebTestRunner::topLoadingFrame):
165         (WebTestRunner::WebTestRunner::policyDelegateDone):
166         (WebTestRunner::WebTestRunner::policyDelegateEnabled):
167         (WebTestRunner::WebTestRunner::policyDelegateIsPermissive):
168         (WebTestRunner::WebTestRunner::policyDelegateShouldNotifyDone):
169         (WebTestRunner::WebTestRunner::shouldInterceptPostMessage):
170         (WebTestRunner::WebTestRunner::isSmartInsertDeleteEnabled):
171         (WebTestRunner::WebTestRunner::isSelectTrailingWhitespaceEnabled):
172         * DumpRenderTree/chromium/TestShell.cpp:
173         (TestShell::initialize):
174         (TestShell::createMainWindow):
175         (TestShell::~TestShell):
176         (TestShell::runFileTest):
177         (TestShell::resetTestController):
178         (TestShell::dump):
179         (TestShell::bindJSObjectsToWindow):
180         * DumpRenderTree/chromium/TestShell.h:
181         (TestShell::testRunner):
182         (TestShell):
183
184 2013-02-01  Alan Cutter  <alancutter@chromium.org>
185
186         PatchLog process durations are increasing linearly with time (faulty data logging)
187         https://bugs.webkit.org/show_bug.cgi?id=108621
188
189         Reviewed by Eric Seidel.
190
191         Added a check to prevent a stop event from happening to the same patch multiple times.
192
193         * QueueStatusServer/loggers/recordpatchevent.py:
194         (RecordPatchEvent.stopped):
195
196 2013-02-01  Manuel Rego Casasnovas  <rego@igalia.com>
197
198         [GTK][WK2] MiniBrowser fullscreen signals support
199         https://bugs.webkit.org/show_bug.cgi?id=108005
200
201         Reviewed by Carlos Garcia Campos.
202
203         Shows a label for 2 seconds using overlay (if GTK >= 3.2.0) and hides
204         the toolbar when entering fullscreen. When leaving fullscreen the
205         label is hidden (if it's not hidden yet) and the toolbar is shown again.
206
207         * MiniBrowser/gtk/BrowserWindow.c:
208         (_BrowserWindow):
209         (fullScreenMessageTimeoutCallback):
210         (webViewEnterFullScreen):
211         (webViewLeaveFullScreen):
212         (browserWindowFinalize):
213         (browserWindowConstructed):
214
215 2013-02-01  Alexis Menard  <alexis@webkit.org>
216
217         Enable unprefixed CSS transitions by default.
218         https://bugs.webkit.org/show_bug.cgi?id=108216
219
220         Reviewed by Dean Jackson.
221
222         Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
223         to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to 
224         guard the unprefixing work for CSS Transforms and animations.
225
226         * Scripts/webkitperl/FeatureList.pm:
227         * qmake/mkspecs/features/features.pri:
228
229 2013-01-31  David Farler  <dfarler@apple.com>
230
231         Provide a sensible default architecture when building on iOS SDKs
232         https://bugs.webkit.org/show_bug.cgi?id=108395
233
234         Reviewed by Anders Carlsson.
235
236         * Scripts/webkitdirs.pm:
237         (determineArchitecture): Anchor SDK regex matches at the beginning.
238
239 2013-01-31  Ryosuke Niwa  <rniwa@webkit.org>
240
241         buildbot should not rely on webkitpy
242         https://bugs.webkit.org/show_bug.cgi?id=107379
243
244         Reviewed by Eric Seidel.
245
246         Move all Python files used in buildbot configuration into BuildSlaveSupport directory.
247         Once this patch is landed, we can stop restarting the master on webkitpy changes.
248
249         * BuildSlaveSupport/build.webkit.org-config/committer_auth.py:
250         * BuildSlaveSupport/build.webkit.org-config/htdigestparser.py: Copied from Tools/Scripts/webkitpy/common/net/htdigestparser.py.
251         * BuildSlaveSupport/build.webkit.org-config/htdigestparser_unittest.py: Copied from Tools/Scripts/webkitpy/common/net/htdigestparser_unittest.py.
252         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
253         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py: Copied from Tools/Scripts/webkitpy/common/config/build.py.
254         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py: Copied from Tools/Scripts/webkitpy/common/config/build_unittest.py.
255         (ShouldBuildTest.test_should_build):
256         * Scripts/webkitpy/common/config/build.py: Removed.
257         * Scripts/webkitpy/common/config/build_unittest.py: Removed.
258         * Scripts/webkitpy/common/net/htdigestparser.py: Removed.
259         * Scripts/webkitpy/common/net/htdigestparser_unittest.py: Removed.
260
261 2013-01-31  Sheriff Bot  <webkit.review.bot@gmail.com>
262
263         Unreviewed, rolling out r141349.
264         http://trac.webkit.org/changeset/141349
265         https://bugs.webkit.org/show_bug.cgi?id=108422
266
267         "yet another windows ews fix needed" (Requested by lforschler
268         on #webkit).
269
270         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
271         (WinEWS):
272
273 2013-01-31  Rouslan Solomakhin  <rouslan@chromium.org>
274
275         [Chromium] Suggest 'uppercase' for multi-word misspelling 'upper case'
276         https://bugs.webkit.org/show_bug.cgi?id=108509
277
278         Reviewed by Tony Chang.
279
280         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
281         (append): Added utility function to append WebString to WebVector.
282         (MockSpellCheck::fillSuggestionList): Suggest 'uppercase' for misspelling 'upper case'.
283
284 2013-01-31  David Farler  <dfarler@apple.com>
285
286         Provide a sensible default architecture when building on iOS SDKs
287         https://bugs.webkit.org/show_bug.cgi?id=108395
288
289         Reviewed by Joseph Pecoraro.
290
291         * Scripts/webkitdirs.pm:
292         (determineArchitecture):
293         Check for iphoneos and iphonesimulator SDKs for a default arch.
294         (determineXcodeSDK): Added.
295         (xcodeSDK): Added.
296         (XcodeOptions): Add ARCHS= if defined.
297
298 2013-01-31  Christopher Cameron  <ccameron@chromium.org>
299
300         Fix rubber-band effect on non-scrollable pages
301         https://bugs.webkit.org/show_bug.cgi?id=107611
302
303         Add mouseWheelBegin function to EventSender to allow
304         event-based rubber-banding tests.
305
306         Reviewed by Antonio Gomes.
307
308         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
309         (WebTestRunner):
310         (WebTestRunner::EventSender::EventSender):
311         (WebTestRunner::EventSender::mouseDragBegin):
312         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
313         (EventSender):
314
315 2013-01-31  James Robinson  <jamesr@chromium.org>
316
317         [chromium] Notify the WebWidget when the WebViewHost is about to tear down compositing support
318         https://bugs.webkit.org/show_bug.cgi?id=108518
319
320         Reviewed by Adrienne Walker.
321
322         * DumpRenderTree/chromium/WebViewHost.cpp:
323         (WebViewHost::shutdown):
324
325 2013-01-31  Pratik Solanki  <psolanki@apple.com>
326
327         DumpRenderTree should put NSSound calls inside USE(APPKIT)
328         https://bugs.webkit.org/show_bug.cgi?id=108499
329
330         Reviewed by Andy Estes.
331
332         * DumpRenderTree/mac/DumpRenderTree.mm:
333         (dumpRenderTree):
334
335 2013-01-30  Brian Weinstein  <bweinstein@apple.com>
336
337         Add a call to the page UI client to determine if a plug-in should load
338         https://bugs.webkit.org/show_bug.cgi?id=108407
339         <rdar://problem/13066332>
340
341         Add entries for the new function in the necessary structs.
342
343         Reviewed by Anders Carlsson.
344
345         * MiniBrowser/mac/WK2BrowserWindowController.m:
346         (-[WK2BrowserWindowController awakeFromNib]):
347         * WebKitTestRunner/TestController.cpp:
348         (WTR::TestController::createOtherPage):
349         (WTR::TestController::createWebViewWithOptions):
350
351 2013-01-31  Florin Malita  <fmalita@chromium.org>
352
353         [Chromium] Unreviewed gardening.
354
355         Win build fix after http://trac.webkit.org/changeset/141471.
356
357         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
358         (MockSpellCheck::spellCheckWord):
359
360 2013-01-31  Enrica Casucci  <enrica@apple.com>
361
362         WebKit2: provide new bundle APIs to allow bundle clients to be notified of pasteboard access.
363         https://bugs.webkit.org/show_bug.cgi?id=108396.
364         <rdar://problem/12920461>
365
366         Reviewed by Alexey Proskuryakov.
367         
368         Adding new WebKit2 test with relevant bundle, to test the new APIs.
369
370         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
371         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm: Added.
372         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
373         (TestWebKitAPI::setInjectedBundleClient):
374         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp: Added.
375         (PasteboardNotificationsTest):
376         (TestWebKitAPI::willWriteToPasteboard):
377         (TestWebKitAPI::getPasteboardDataForRange):
378         (TestWebKitAPI::didWriteToPasteboard):
379         (TestWebKitAPI::PasteboardNotificationsTest::PasteboardNotificationsTest):
380         (TestWebKitAPI::PasteboardNotificationsTest::didCreatePage):
381         * TestWebKitAPI/Tests/WebKit2/execCopy.html: Added.
382         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Updated to reflect
383         changes in InjectedBundleEditorClient.
384         (WTR::InjectedBundlePage::InjectedBundlePage):
385
386 2013-01-31  Rouslan Solomakhin  <rouslan@chromium.org>
387
388         [Chromium] Add two-word misspelling to mock spellchecker
389         https://bugs.webkit.org/show_bug.cgi?id=108498
390
391         Reviewed by Tony Chang.
392
393         Some layout tests verify spellcheck behavior when multiple words are
394         marked as a single misspelling. This change adds a two-word misspelling
395         'upper case' to the mock spellchecker used by layout tests.
396
397         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
398         (MockSpellCheck::spellCheckWord): Modified to handle spaces in misspellings.
399         (MockSpellCheck::initializeIfNeeded):  Modified to use a vector instead of a hash table.
400         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:
401         (MockSpellCheck): Changed misspellings container from hash table to vector.
402
403 2013-01-31  Simon Hausmann  <simon.hausmann@digia.com>
404
405         [Qt] Prospective build fix.
406
407         Reviewed by Jocelyn Turcotte.
408
409         Don't create .prl files for intermediate libs as their contents get
410         injected within -Wl,-whole-archive -lFoo -wl,-no-whole-archive.
411
412         * qmake/mkspecs/features/default_post.prf:
413
414 2013-01-31  Alan Cutter  <alancutter@chromium.org>
415
416         EWS graphs have unusual data for patch waiting times
417         https://bugs.webkit.org/show_bug.cgi?id=108427
418
419         Reviewed by Eric Seidel.
420
421         The max_patches_waiting QueueLog property may have missed recording patches waiting in idle times when no events are fired to update it. I added a cron job to take care of this issue.
422         The patch wait duration in PatchLogs was being incorrectly updated after a patch expired and was picked up again from the queue. That period should really count towards the processing time instead.
423         Added a WarningLog to record if any erroneous situations occur due to invalid contents in the datastore. These basically highlight if any "impossible" execution paths get executed.
424
425         * QueueStatusServer/app.yaml:
426         * QueueStatusServer/cron.yaml:
427         * QueueStatusServer/handlers/syncqueuelogs.py: Copied from Tools/QueueStatusServer/model/patchlog.py.
428         (SyncQueueLogs):
429         (SyncQueueLogs.get):
430         * QueueStatusServer/loggers/recordpatchevent.py:
431         (RecordPatchEvent.added):
432         (RecordPatchEvent.retrying):
433         (RecordPatchEvent.started):
434         (RecordPatchEvent.stopped):
435         (RecordPatchEvent.updated):
436         * QueueStatusServer/main.py:
437         * QueueStatusServer/model/patchlog.py:
438         (PatchLog.lookup):
439         (PatchLog):
440         (PatchLog.lookup_if_exists):
441         (PatchLog.calculate_process_duration):
442         (PatchLog._generate_key):
443         * QueueStatusServer/model/queuelog.py:
444         (QueueLog.update_max_patches_waiting):
445         (QueueLog._get_or_create_txn):
446         (QueueLog):
447         (QueueLog._get_patches_waiting):
448         * QueueStatusServer/model/warninglog.py: Copied from Tools/QueueStatusServer/model/patchlog.py.
449         (WarningLog):
450         (WarningLog.record):
451
452 2013-01-31  Anders Carlsson  <andersca@apple.com>
453
454         Remove Web Intents code from WebKit2
455         https://bugs.webkit.org/show_bug.cgi?id=108506
456
457         Reviewed by Simon Fraser.
458
459         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
460         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
461         (WTR::InjectedBundlePage::InjectedBundlePage):
462         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
463         (InjectedBundlePage):
464         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
465         * WebKitTestRunner/InjectedBundle/TestRunner.h:
466         (TestRunner):
467
468 2013-01-31  Tommy Widenflycht  <tommyw@google.com>
469
470         [chromium] MediaStream API: Rename WebMediaStreamDescriptor and WebMediaStreamComponent to WebMediaStream and WebMediaStreamTrack
471         https://bugs.webkit.org/show_bug.cgi?id=108458
472
473         Reviewed by Adam Barth.
474
475         Only renames, no other code changes.
476
477         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
478         (MockWebMediaStreamCenter::didEnableMediaStreamTrack):
479         (MockWebMediaStreamCenter::didDisableMediaStreamTrack):
480         (MockWebMediaStreamCenter::didAddMediaStreamTrack):
481         (MockWebMediaStreamCenter::didRemoveMediaStreamTrack):
482         (MockWebMediaStreamCenter::didStopLocalMediaStream):
483         (MockWebMediaStreamCenter::didCreateMediaStream):
484         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
485         (MockWebMediaStreamCenter):
486         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
487         (MockWebRTCPeerConnectionHandler::addStream):
488         (MockWebRTCPeerConnectionHandler::removeStream):
489         (MockWebRTCPeerConnectionHandler::getStats):
490         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
491         (MockWebRTCPeerConnectionHandler):
492         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
493         (UserMediaRequestTask::UserMediaRequestTask):
494         (WebUserMediaClientMock::requestUserMedia):
495
496 2013-01-31  Zan Dobersek  <zdobersek@igalia.com>
497
498         REGRESSION (r141402): incorrectly set injected bundle path when running GTK unit tests
499         https://bugs.webkit.org/show_bug.cgi?id=108496
500
501         Reviewed by Philippe Normand.
502
503         * Scripts/run-gtk-tests:
504         (TestRunner.__init__): Add the build type as a member on the TestRunner interface.
505         (TestRunner._setup_testing_environment): Use the build type member to determine correct path
506         to the injected bundle.
507
508 2013-01-31  Christophe Dumez  <dchris@gmail.com>
509
510         [EFL] Disable Web Intents
511         https://bugs.webkit.org/show_bug.cgi?id=108457
512
513         Reviewed by Alexey Proskuryakov.
514
515         Remove EFL DRT code related to Web intents.
516
517         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
518         (DumpRenderTreeChrome::createView):
519         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
520         (DumpRenderTreeChrome::onFrameCreated):
521         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
522         (DumpRenderTreeChrome):
523         * DumpRenderTree/efl/TestRunnerEfl.cpp:
524         (TestRunner::sendWebIntentResponse):
525         (TestRunner::deliverWebIntent):
526         * Scripts/webkitperl/FeatureList.pm: Turn off WEB_INTENTS flag
527         for EFL port.
528
529 2013-01-31  Simon Hausmann  <simon.hausmann@digia.com>
530
531         [Qt] Disable force_static_libs_as_shared in developer builds if wk2 is enabled
532
533         Reviewed by Jocelyn Turcotte.
534
535         This is a temporary workaround during the development of #108471, where we move files around
536         but some link time dependencies might remain.
537
538         * qmake/mkspecs/features/default_post.prf:
539
540 2013-01-31  Simon Hausmann  <simon.hausmann@digia.com>
541
542         [Qt] Make it possible to compile WebKit2 Qt related files without access to internal WK2 C++ API
543         https://bugs.webkit.org/show_bug.cgi?id=108472
544
545         Reviewed by Andreas Kling.
546
547         Add a new module to the qmake build system that represents the part of the WebKit2 Qt integration
548         that doesn't depend on WebKit2 internals.
549
550         * qmake/mkspecs/features/webkit_modules.prf:
551         * qmake/mkspecs/modules/webkit2qml.prf: Copied from Source/WebKit2/WebKit2.pro.
552
553 2013-01-31  James Robinson  <jamesr@chromium.org>
554
555         [chromium] Remove dead transitional code from WebViewImpl
556         https://bugs.webkit.org/show_bug.cgi?id=107889
557
558         Reviewed by Adam Barth.
559
560         ScrollingCoordinatorChromiumTests need to initialize compositing, so its implementation of
561         WebWidgetClient has to support the new compositor initialization path.
562
563         * DumpRenderTree/chromium/WebViewHost.cpp:
564         (WebViewHost::initializeLayerTreeView):
565         (WebViewHost::setWebWidget):
566
567 2013-01-31  Gustavo Noronha Silva  <gns@gnome.org>
568
569         [GTK] run-gtk-tests does not respect the -d argument
570         https://bugs.webkit.org/show_bug.cgi?id=107822
571
572         Reviewed by Philippe Normand.
573
574         * Scripts/run-gtk-tests:
575         (TestRunner.__init__): use the value for the debug option to decide what
576         build_type to request a path for.
577         * gtk/common.py:
578         (get_build_path): now accepts a build_type argument instead of trying both
579         Release and Debug in order, defaults to release.
580         (build_path): takes and passes a build_type argument, no default value.
581
582 2013-01-31  Christophe Dumez  <dchris@gmail.com>
583
584         Update Christophe Dumez's email address
585         https://bugs.webkit.org/show_bug.cgi?id=108453
586
587         Reviewed by Kenneth Rohde Christiansen.
588
589         Update my email address in committers.py.
590
591         * Scripts/webkitpy/common/config/committers.py:
592
593 2013-01-31  Jochen Eisinger  <jochen@chromium.org>
594
595         [chromium] move runModalBeforeUnloadDialog to TestRunner library
596         https://bugs.webkit.org/show_bug.cgi?id=108442
597
598         Reviewed by Adam Barth.
599
600         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
601         (WebTestRunner::WebTestProxy::runModalBeforeUnloadDialog):
602         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
603         (WebTestRunner::WebTestProxyBase::runModalBeforeUnloadDialog):
604         * DumpRenderTree/chromium/WebViewHost.cpp:
605         * DumpRenderTree/chromium/WebViewHost.h:
606
607 2013-01-31  Jochen Eisinger  <jochen@chromium.org>
608
609         [chromium] move postMessage related methods to TestRunner library
610         https://bugs.webkit.org/show_bug.cgi?id=108343
611
612         Reviewed by Adam Barth.
613
614         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
615         (WebKit):
616         (WebTestProxyBase):
617         (WebTestRunner::WebTestProxy::willCheckAndDispatchMessageEvent):
618         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
619         (WebTestRunner::WebTestProxyBase::willCheckAndDispatchMessageEvent):
620         (WebTestRunner):
621         * DumpRenderTree/chromium/WebViewHost.cpp:
622         (WebViewHost::willCheckAndDispatchMessageEvent):
623
624 2013-01-30  Jochen Eisinger  <jochen@chromium.org>
625
626         [chromium] move remaining resource load related methods to TestRunner library
627         https://bugs.webkit.org/show_bug.cgi?id=108334
628
629         Reviewed by Adam Barth.
630
631         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
632         (WebTestRunner::WebTestDelegate::allowExternalPages):
633         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
634         (WebKit):
635         (WebTestProxyBase):
636         (WebTestRunner::WebTestProxy::canHandleRequest):
637         (WebTestRunner::WebTestProxy::cannotHandleRequestError):
638         (WebTestRunner::WebTestProxy::didCreateDataSource):
639         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
640         (WebTestRunner::WebTestProxyBase::canHandleRequest):
641         (WebTestRunner):
642         (WebTestRunner::WebTestProxyBase::cannotHandleRequestError):
643         (WebTestRunner::WebTestProxyBase::didCreateDataSource):
644         (WebTestRunner::WebTestProxyBase::willSendRequest):
645         * DumpRenderTree/chromium/WebViewHost.cpp:
646         (WebViewHost::canHandleRequest):
647         (WebViewHost::didCreateDataSource):
648         (WebViewHost::willSendRequest):
649         (WebViewHost::allowExternalPages):
650         * DumpRenderTree/chromium/WebViewHost.h:
651
652 2013-01-30  Hajime Morrita  <morrita@google.com>
653
654         Unreviewed test failure fix for r141341.
655
656         * Scripts/webkitpy/tool/steps/runtests.py:
657         (RunTests.run):
658         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
659
660 2013-01-30  Levi Weintraub  <leviw@chromium.org>
661
662         [Chromium] WebPluginContainerImpl adding imbalanced touch handler refs
663         https://bugs.webkit.org/show_bug.cgi?id=108381
664
665         Reviewed by James Robinson.
666
667         * DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp: Adding an attribute that
668         tickles the case in WebPluginContainerImpl that imbalanced touch handler refs in Document.
669
670 2013-01-30  Julie Parent  <jparent@chromium.org>
671
672         Add a concept of dashboard parameters that invalidate others
673         https://bugs.webkit.org/show_bug.cgi?id=108362
674
675         Reviewed by Dirk Pranke.
676
677         There are certain parameters to the dashboards, that when selected,
678         invalidate others, such as selecting the test type invalidates the
679         builder group. Add this concept to dashboard_base and allow specifc
680         dashboard to add their own invalidating parameters.
681         
682         The result is that when the user takes a specific action, like changing
683         the test type, the builder would get reset to the default for the new
684         test type, rather than erroring or not matching the query param, as is
685         the current behavior.
686         
687         Also deletes some unused code (selectBuilder).
688         
689         * TestResultServer/static-dashboards/dashboard_base.js:
690         (invalidateQueryParameters):
691         (setQueryParameter):
692         * TestResultServer/static-dashboards/flakiness_dashboard.js:
693         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
694         * TestResultServer/static-dashboards/timeline_explorer.html:
695         * TestResultServer/static-dashboards/treemap.html:
696
697 2013-01-30  Kiran Muppala  <cmuppala@apple.com>
698
699         Disable process suppression of DumpRenderTree on Mac
700         https://bugs.webkit.org/show_bug.cgi?id=108400
701
702         Reviewed by Jessie Berlin.
703
704         * DumpRenderTree/mac/DumpRenderTree.mm:
705         (prepareConsistentTestingEnvironment): Take assertion to prevent
706         process suppression.
707
708 2013-01-30  Roger Fong  <roger_fong@apple.com>
709
710         Enable tests for Windows EWS!
711         https://bugs.webkit.org/show_bug.cgi?id=107968.
712         Patch by Lucas Forschler.
713
714         Reviewed by Adam Barth.
715
716         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
717         (WinEWS):
718
719 2013-01-30  Christophe Dumez  <christophe.dumez@intel.com>
720
721         Add a StringTypeAdapter for ASCIILiteral
722         https://bugs.webkit.org/show_bug.cgi?id=108338
723
724         Reviewed by Benjamin Poulain.
725
726         Add API tests for operator+() taking an ASCIILiteral.
727
728         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
729         (TestWebKitAPI::TEST):
730
731 2013-01-30  Roger Fong  <roger_fong@apple.com>
732
733         Modify runtests.py script so that --skip-failing-tests option is not added when platform is cygwin.
734
735         Rubberstamped by Timothy Horton.
736
737         * Scripts/webkitpy/tool/steps/runtests.py:
738         (RunTests.run):
739
740 2013-01-30  Sheriff Bot  <webkit.review.bot@gmail.com>
741
742         Unreviewed, rolling out r141205.
743         http://trac.webkit.org/changeset/141205
744         https://bugs.webkit.org/show_bug.cgi?id=108353
745
746         Command for running tests on windows needs to be investigated.
747         (Requested by lforschler on #webkit).
748
749         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
750         (WinEWS):
751
752 2013-01-30  Tony Chang  <tony@chromium.org>
753
754         [Chromium] Enable textarea resize corner for tests
755         https://bugs.webkit.org/show_bug.cgi?id=108385
756
757         Reviewed by Ojan Vafai.
758
759         We should test what we ship. Also, this makes us pass more tests in content_shell.
760
761         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
762         (WebTestRunner::WebPreferences::reset): Turn on resize corner.
763
764 2013-01-30  Jochen Eisinger  <jochen@chromium.org>
765
766         [chromium] move custom policy delegate to TestRunner library
767         https://bugs.webkit.org/show_bug.cgi?id=108328
768
769         Reviewed by Adam Barth.
770
771         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
772         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
773         (WebTestProxyBase):
774         (WebTestRunner::WebTestProxy::decidePolicyForNavigation):
775         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
776         (WebTestRunner::WebTestRunner::policyDelegateEnabled):
777         (WebTestRunner::WebTestRunner::policyDelegateIsPermissive):
778         (WebTestRunner::WebTestRunner::policyDelegateShouldNotifyDone):
779         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
780         (WebTestRunner::TestRunner::reset):
781         (WebTestRunner::TestRunner::policyDelegateEnabled):
782         (WebTestRunner):
783         (WebTestRunner::TestRunner::policyDelegateIsPermissive):
784         (WebTestRunner::TestRunner::policyDelegateShouldNotifyDone):
785         (WebTestRunner::TestRunner::setCustomPolicyDelegate):
786         (WebTestRunner::TestRunner::waitForPolicyDelegate):
787         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
788         (TestRunner):
789         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
790         (WebTestRunner::WebTestProxyBase::decidePolicyForNavigation):
791         (WebTestRunner):
792         * DumpRenderTree/chromium/WebViewHost.cpp:
793         (WebViewHost::decidePolicyForNavigation):
794         (WebViewHost::reset):
795         * DumpRenderTree/chromium/WebViewHost.h:
796         (WebViewHost):
797
798 2013-01-30  Allan Sandfeld Jensen  <allan.jensen@digia.com>
799
800         [Qt][WK1] Support better testing of Web Notifications
801         https://bugs.webkit.org/show_bug.cgi?id=107696
802
803         Reviewed by Jocelyn Turcotte.
804
805         Do not dump notification output to the console by default, instead allow the 
806         tests that need this feature to enable it.
807
808         Implement denyWebNotificationPermission and removeAllWebNotificationPermissions.
809         Remove unused m_desktopNotificationAllowedOrigins variable.
810
811         * DumpRenderTree/qt/TestRunnerQt.cpp:
812         (TestRunner::TestRunner):
813         (TestRunner::reset):
814         (TestRunner::dumpNotifications):
815         (TestRunner::grantWebNotificationPermission):
816         (TestRunner::denyWebNotificationPermission):
817         (TestRunner::removeAllWebNotificationPermissions):
818         * DumpRenderTree/qt/TestRunnerQt.h:
819         (TestRunner):
820
821 2013-01-30  Jochen Eisinger  <jochen@chromium.org>
822
823         [chromium] move methods from WebTestDelegate to WebTestRunner
824         https://bugs.webkit.org/show_bug.cgi?id=108309
825
826         Reviewed by Adam Barth.
827
828         By moving more logic to the TestRunner library, we can share more
829         code with content shell.
830
831         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
832         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
833         (WebTestProxyBase):
834         (WebTestRunner::WebTestProxy::createView):
835         (WebTestRunner::WebTestProxy::isSmartInsertDeleteEnabled):
836         (WebTestRunner::WebTestProxy::isSelectTrailingWhitespaceEnabled):
837         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
838         (WebTestRunner::WebTestRunner::isSmartInsertDeleteEnabled):
839         (WebTestRunner::WebTestRunner::isSelectTrailingWhitespaceEnabled):
840         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
841         (WebTestRunner::TestRunner::reset):
842         (WebTestRunner::TestRunner::isSmartInsertDeleteEnabled):
843         (WebTestRunner):
844         (WebTestRunner::TestRunner::isSelectTrailingWhitespaceEnabled):
845         (WebTestRunner::TestRunner::setSmartInsertDeleteEnabled):
846         (WebTestRunner::TestRunner::setSelectTrailingWhitespaceEnabled):
847         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
848         (TestRunner):
849         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
850         (WebTestRunner::WebTestProxyBase::createView):
851         (WebTestRunner::WebTestProxyBase::isSmartInsertDeleteEnabled):
852         (WebTestRunner):
853         (WebTestRunner::WebTestProxyBase::isSelectTrailingWhitespaceEnabled):
854         * DumpRenderTree/chromium/TestShell.h:
855         (TestShell):
856         * DumpRenderTree/chromium/WebViewHost.cpp:
857         (WebViewHost::createView):
858         (WebViewHost::didStartLoading):
859         (WebViewHost::didStopLoading):
860         (WebViewHost::isSmartInsertDeleteEnabled):
861         (WebViewHost::isSelectTrailingWhitespaceEnabled):
862         (WebViewHost::reset):
863         * DumpRenderTree/chromium/WebViewHost.h:
864         (WebViewHost):
865
866 2013-01-30  Kwang Yul Seo  <skyul@company100.net>
867
868         Unreviewed. Add Jae Hyun Park to contributor list.
869
870         * Scripts/webkitpy/common/config/committers.py:
871
872 2013-01-29  Alan Cutter  <alancutter@chromium.org>
873
874         Need a cr-linux debug EWS bot
875         https://bugs.webkit.org/show_bug.cgi?id=98957
876
877         Reviewed by Eric Seidel.
878
879         Added cr-linux-debug-ews bot to webkit-patch, QueueStatusServer and GCE build scripts.
880
881         * EWSTools/GoogleComputeEngine/build-cr-linux-debug-ews.sh: Added.
882         * QueueStatusServer/app.yaml:
883         * QueueStatusServer/config/queues.py: Added.
884         * QueueStatusServer/model/queues.py:
885         (Queue.__init__):
886         (Queue.queue_with_name):
887         (Queue.all):
888         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
889         (ChromiumLinuxDebugEWS):
890
891 2013-01-29  Alan Cutter  <alancutter@chromium.org>
892
893         Tidy up Sheriffbot's Sheriffs command's unit tests
894         https://bugs.webkit.org/show_bug.cgi?id=108262
895
896         Reviewed by Eric Seidel.
897
898         Added the use of MockWeb instead of the filesystem to test the sheriffs command.
899
900         * Scripts/webkitpy/tool/bot/irc_command.py:
901         (Sheriffs._retrieve_webkit_sheriffs):
902         (Sheriffs.execute):
903         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
904         (IRCCommandTest.test_sheriffs):
905         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_0.js: Removed.
906         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_1.js: Removed.
907         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_2.js: Removed.
908         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_malformed.js: Removed.
909         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_zero.js: Removed.
910
911 2013-01-29  Lucas Forschler  <lforschler@apple.com>
912
913         Enable tests for Windows EWS!
914         https://bugs.webkit.org/show_bug.cgi?id=107968
915         
916         Reviewed by Adam Barth.
917
918         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
919         (WinEWS):
920
921 2013-01-29  Alan Cutter  <alancutter@chromium.org>
922
923         MockWeb should be able to serve mock web content
924         https://bugs.webkit.org/show_bug.cgi?id=108240
925
926         Reviewed by Dirk Pranke.
927
928         Added the ability to have MockWeb serve mock web data.
929
930         * Scripts/webkitpy/common/host_mock.py:
931         (MockHost.__init__):
932         * Scripts/webkitpy/common/net/web_mock.py:
933         (MockWeb.__init__):
934         (MockWeb.get_binary):
935
936 2013-01-29  Jessie Berlin  <jberlin@apple.com>
937
938         run-api-tests should have an option to specify root
939         https://bugs.webkit.org/show_bug.cgi?id=108210
940
941         Reviewed by Ryosuke Niwa.
942
943         * Scripts/run-api-tests:
944         Add the option and use it to set the configuration product directory. Since it is supposed
945         to point to the built products, do not build the products if root is specified (this mimics
946         the behavior of run-javascriptcore-tests).
947
948 2013-01-29  Bruno de Oliveira Abinader  <bruno.abinader@basyskom.com>
949
950         [EFL] Add Toggle fullscreen (F11) to MiniBrowser
951         https://bugs.webkit.org/show_bug.cgi?id=108122
952
953         Reviewed by Antonio Gomes.
954
955         Adds fullscreen mode toggle (F11) option to MiniBrowser using native API.
956
957         * MiniBrowser/efl/main.c:
958         (on_key_down): Add 'F11' key handler.
959
960 2013-01-29  Patrick Gansterer  <paroga@webkit.org>
961
962         [CMake] Use offical Windows CE support
963         https://bugs.webkit.org/show_bug.cgi?id=108061
964
965         Reviewed by Laszlo Gombos.
966
967         Recent version of CMake has added Windows CE support, but uses a
968         slightly different interface than the patched version used before.
969         Change the command line parameters to use the offical CMake binaries.
970
971         * Scripts/webkitdirs.pm:
972         (cmakeBasedPortArguments):
973
974 2013-01-29  Alan Cutter  <alancutter@chromium.org>
975
976         QueueStatusServer needs pages to display historical queue data
977         https://bugs.webkit.org/show_bug.cgi?id=107659
978
979         Reviewed by Eric Seidel.
980
981         Created a /queue-charts/<queue-name> handler to present queue and patch data using Google Chart Tools.
982
983         * QueueStatusServer/app.yaml:
984         * QueueStatusServer/config/charts.py: Copied from Tools/QueueStatusServer/model/queuelog.py.
985         (get_time_unit):
986         * QueueStatusServer/filters/webkit_extras.py:
987         (webkit_linkify):
988         (webkit_bug_id):
989         (webkit_attachment_id):
990         (results_link):
991         (queue_status_link):
992         (queue_charts_link):
993         * QueueStatusServer/handlers/queuecharts.py: Added.
994         (QueueCharts):
995         (QueueCharts.get):
996         (QueueCharts._get_min_med_max):
997         (QueueCharts._get_patch_data):
998         (QueueCharts._get_patch_logs):
999         (QueueCharts._get_queue_data):
1000         (QueueCharts._get_queue_logs):
1001         (QueueCharts._get_time_unit):
1002         (QueueCharts._get_timestamp):
1003         (QueueCharts._get_view_range):
1004         * QueueStatusServer/handlers/queuestatus.py:
1005         (QueueStatus.get):
1006         * QueueStatusServer/index.yaml:
1007         * QueueStatusServer/main.py:
1008         * QueueStatusServer/model/queuelog.py:
1009         (QueueLog):
1010         (QueueLog.create_key):
1011         (QueueLog.get_at):
1012         (QueueLog.get_current):
1013         (QueueLog.get_or_create):
1014         (QueueLog._get_or_create_txn):
1015         * QueueStatusServer/stylesheets/charts.css: Added.
1016         (.chart):
1017         (.choices):
1018         * QueueStatusServer/templates/queuecharts.html: Added.
1019         * QueueStatusServer/templates/queuestatus.html:
1020
1021 2013-01-29  Mario Sanchez Prada  <mario.prada@samsung.com>
1022
1023         [GTK] Missing build flags when building with Harfbuzz
1024         https://bugs.webkit.org/show_bug.cgi?id=108174
1025
1026         Reviewed by Martin Robinson.
1027
1028         Add FREETYPE_CFLAGS and FREETYPE_LIBS to makefiles so -lharfbuzz
1029         parameter will be added to linking lines when needed.
1030
1031         * GNUmakefile.am: Added FREETYPE_CFLAGS and FREETYPE_LIBS.
1032         * MiniBrowser/gtk/GNUmakefile.am: Ditto.
1033         * TestWebKitAPI/GNUmakefile.am: Ditto.
1034
1035 2013-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1036
1037         [GTK] Implement resources API using injected bundle
1038         https://bugs.webkit.org/show_bug.cgi?id=107457
1039
1040         Reviewed by Sam Weinig.
1041
1042         * Scripts/run-gtk-tests:
1043         (TestRunner): Unksip resources unit tests.
1044
1045 2013-01-29  Michael Brüning  <michael.bruning@digia.com>
1046
1047         Unreviewed, updated my email information.
1048
1049         * Scripts/webkitpy/common/config/committers.py:
1050
1051 2013-01-29  Jochen Eisinger  <jochen@chromium.org>
1052
1053         [chromium] delete DRTTestRunner
1054         https://bugs.webkit.org/show_bug.cgi?id=108082
1055
1056         Reviewed by Adam Barth.
1057
1058         * DumpRenderTree/DumpRenderTree.gypi:
1059         * DumpRenderTree/chromium/DRTTestRunner.cpp: Removed.
1060         * DumpRenderTree/chromium/DRTTestRunner.h: Removed.
1061         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1062         (WebTestRunner::WebTestDelegate::testFinished):
1063         (WebTestRunner::WebTestDelegate::testTimedOut):
1064         (WebTestRunner::WebTestDelegate::isBeingDebugged):
1065         (WebTestRunner::WebTestDelegate::layoutTestTimeout):
1066         (WebTestRunner::WebTestDelegate::closeRemainingWindows):
1067         (WebTestRunner::WebTestDelegate::navigationEntryCount):
1068         (WebTestRunner::WebTestDelegate::windowCount):
1069         (WebTestRunner::WebTestDelegate::setCustomPolicyDelegate):
1070         (WebTestRunner::WebTestDelegate::waitForPolicyDelegate):
1071         (WebTestRunner::WebTestDelegate::goToOffset):
1072         (WebTestRunner::WebTestDelegate::reload):
1073         (WebTestRunner::WebTestDelegate::loadURLForFrame):
1074         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1075         (WebTestRunner::WebTestRunner::policyDelegateDone):
1076         (WebTestRunner::WebTestRunner::shouldInterceptPostMessage):
1077         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1078         (WebTestRunner::TestRunner::WorkQueue::~WorkQueue):
1079         (WebTestRunner):
1080         (WebTestRunner::TestRunner::WorkQueue::processWorkSoon):
1081         (WebTestRunner::TestRunner::WorkQueue::processWork):
1082         (WebTestRunner::TestRunner::WorkQueue::reset):
1083         (WebTestRunner::TestRunner::WorkQueue::addWork):
1084         (WebTestRunner::TestRunner::TestRunner):
1085         (WebTestRunner::TestRunner::reset):
1086         (WebTestRunner::TestRunner::policyDelegateDone):
1087         (WebTestRunner::TestRunner::shouldInterceptPostMessage):
1088         (WebTestRunner::TestRunner::waitUntilDone):
1089         (WebTestRunner::TestRunner::notifyDone):
1090         (WebTestRunner::TestRunner::completeNotifyDone):
1091         (WorkItemBackForward):
1092         (WebTestRunner::WorkItemBackForward::WorkItemBackForward):
1093         (WebTestRunner::WorkItemBackForward::run):
1094         (WebTestRunner::TestRunner::queueBackNavigation):
1095         (WebTestRunner::TestRunner::queueForwardNavigation):
1096         (WorkItemReload):
1097         (WebTestRunner::WorkItemReload::run):
1098         (WebTestRunner::TestRunner::queueReload):
1099         (WorkItemLoadingScript):
1100         (WebTestRunner::WorkItemLoadingScript::WorkItemLoadingScript):
1101         (WebTestRunner::WorkItemLoadingScript::run):
1102         (WorkItemNonLoadingScript):
1103         (WebTestRunner::WorkItemNonLoadingScript::WorkItemNonLoadingScript):
1104         (WebTestRunner::WorkItemNonLoadingScript::run):
1105         (WebTestRunner::TestRunner::queueLoadingScript):
1106         (WebTestRunner::TestRunner::queueNonLoadingScript):
1107         (WorkItemLoad):
1108         (WebTestRunner::WorkItemLoad::WorkItemLoad):
1109         (WebTestRunner::WorkItemLoad::run):
1110         (WebTestRunner::TestRunner::queueLoad):
1111         (WorkItemLoadHTMLString):
1112         (WebTestRunner::WorkItemLoadHTMLString::WorkItemLoadHTMLString):
1113         (WebTestRunner::WorkItemLoadHTMLString::run):
1114         (WebTestRunner::TestRunner::queueLoadHTMLString):
1115         (WebTestRunner::TestRunner::locationChangeDone):
1116         (WebTestRunner::TestRunner::windowCount):
1117         (WebTestRunner::TestRunner::setCloseRemainingWindowsWhenComplete):
1118         (WebTestRunner::TestRunner::setCustomPolicyDelegate):
1119         (WebTestRunner::TestRunner::waitForPolicyDelegate):
1120         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1121         (TestRunner):
1122         (WorkItem):
1123         (WebTestRunner::TestRunner::WorkItem::~WorkItem):
1124         (WorkQueue):
1125         (WebTestRunner::TestRunner::WorkQueue::WorkQueue):
1126         (WebTestRunner::TestRunner::WorkQueue::setFrozen):
1127         (WebTestRunner::TestRunner::WorkQueue::isEmpty):
1128         (WebTestRunner::TestRunner::WorkQueue::taskList):
1129         * DumpRenderTree/chromium/TestShell.cpp:
1130         (TestShell::initialize):
1131         (TestShell::runFileTest):
1132         (TestShell::loadURL):
1133         (TestShell::createNewWindow):
1134         * DumpRenderTree/chromium/TestShell.h:
1135         (TestShell::testRunner):
1136         (TestShell):
1137         * DumpRenderTree/chromium/WebViewHost.cpp:
1138         (WebViewHost::testFinished):
1139         (WebViewHost::testTimedOut):
1140         (WebViewHost::isBeingDebugged):
1141         (WebViewHost::layoutTestTimeout):
1142         (WebViewHost::closeRemainingWindows):
1143         (WebViewHost::navigationEntryCount):
1144         (WebViewHost::windowCount):
1145         (WebViewHost::setCustomPolicyDelegate):
1146         (WebViewHost::waitForPolicyDelegate):
1147         (WebViewHost::goToOffset):
1148         (WebViewHost::reload):
1149         (WebViewHost::loadURLForFrame):
1150         (WebViewHost::shutdown):
1151         (WebViewHost::testRunner):
1152         * DumpRenderTree/chromium/WebViewHost.h:
1153         (WebTestRunner):
1154         (WebViewHost):
1155
1156 2013-01-28  Timothy Loh  <timloh@chromium.com>
1157
1158         Refactor ChangeLog and PrepareChangeLog to use FileSystem objects
1159         https://bugs.webkit.org/show_bug.cgi?id=107903
1160
1161         Reviewed by Eric Seidel.
1162
1163         To make ChangeLog and PrepareChangeLog easier to test, we can use
1164         FileSystem objects instead of just passing around paths.
1165
1166         * Scripts/webkitpy/common/checkout/changelog.py:
1167         (ChangeLog.__init__):
1168         (ChangeLog.parse_latest_entry_from_file):
1169         (ChangeLog.parse_entries_from_file):
1170         (ChangeLog.latest_entry):
1171         (ChangeLog.update_with_unreviewed_message):
1172         (ChangeLog.set_reviewer):
1173         (ChangeLog.set_short_description_and_bug_url):
1174         (ChangeLog.delete_entries):
1175         (ChangeLog.prepend_text):
1176         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1177         (ChangeLogTest):
1178         (test_parse_log_entries_from_changelog):
1179         (test_latest_entry_parse_single_entry):
1180         (test_set_reviewer):
1181         (test_set_short_description_and_bug_url):
1182         (test_delete_entries):
1183         (test_prepend_text):
1184         * Scripts/webkitpy/common/system/filesystem_mock.py:
1185         (ReadableTextFileObject.__init__):
1186         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1187         (PrepareChangeLog._ensure_bug_url):
1188         (PrepareChangeLog._resolve_existing_entry):
1189         (PrepareChangeLog.run):
1190         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
1191         (test_ensure_bug_url):
1192         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
1193         (_assert_message_for_revert_output):
1194
1195 2013-01-28  Raymond Toy  <rtoy@google.com>
1196
1197         Add myself to committers.py
1198         https://bugs.webkit.org/show_bug.cgi?id=107992
1199
1200         Reviewed by kbr@google.com.
1201
1202         * Scripts/webkitpy/common/config/committers.py:
1203
1204 2013-01-28  Joseph Pecoraro  <pecoraro@apple.com>
1205
1206         [Mac] Update PageVisibilityState when WebView is hidden / visible
1207         https://bugs.webkit.org/show_bug.cgi?id=107509
1208
1209         Reviewed by Sam Weinig.
1210
1211         Add a test that PageVisibility of WK1 WebViews and WK2 WKViews
1212         automatically changes between hidden and visible as the view is added
1213         and removed from window, or when it is in a window that changes
1214         visibility, for instance by minimizing / deminimizing.
1215
1216         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1217         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.html: Added.
1218         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Added.
1219         (-[PageVisibilityStateDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
1220         (runJavaScriptAlert):
1221         (PageVisibilityStateWithWindowChanges):
1222         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
1223         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::teardownView):
1224         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
1225         (TestWebKitAPI::TEST_F):
1226         Test visibility state of a page in a WebView/WKView with different window states.
1227
1228         * TestWebKitAPI/mac/WebKitAgnosticTest.h:
1229         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
1230         (TestWebKitAPI::WebKitAgnosticTest::teardownView):
1231         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
1232         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
1233         Add a WK1 and WK2 teardownView to balance initializeView.
1234
1235 2013-01-28  Joseph Pecoraro  <pecoraro@apple.com>
1236
1237         Improve PageVisibility API with enums
1238         https://bugs.webkit.org/show_bug.cgi?id=107364
1239
1240         Reviewed by Sam Weinig.
1241
1242         * DumpRenderTree/mac/TestRunnerMac.mm:
1243         (TestRunner::resetPageVisibility):
1244         (TestRunner::setPageVisibility):
1245         Update the WK1 test code to use the new WK1 enums.
1246
1247         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1248         (WTR::InjectedBundle::setVisibilityState):
1249         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1250         (InjectedBundle):
1251         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1252         (WTR::TestRunner::setPageVisibility):
1253         (WTR::TestRunner::resetPageVisibility):
1254         * WebKitTestRunner/TestController.cpp:
1255         (WTR::TestController::setVisibilityState):
1256         * WebKitTestRunner/TestController.h:
1257         (TestController):
1258         * WebKitTestRunner/TestInvocation.cpp:
1259         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1260         Update the WK2 test code to use the new WK2 API and enums.
1261
1262         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1263         * TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp: Added.
1264         (TestWebKitAPI):
1265         (TestWebKitAPI::setPageVisibilityStateWithEvalContinuation):
1266         (TestWebKitAPI::assertSerializedScriptValueIsStringValue):
1267         (TestWebKitAPI::didRunStep1StateChangeVisibleToHidden):
1268         (TestWebKitAPI::didRunStep2StateChangeHiddenToPrerender):
1269         (TestWebKitAPI::didRunStep3StateChangePrerenderToPreview):
1270         (TestWebKitAPI::didRunStep4InStatePreview):
1271         (TestWebKitAPI::TEST):
1272         Test the new WK2 API with all enum types.
1273
1274 2013-01-28  Jochen Eisinger  <jochen@chromium.org>
1275
1276         [chromium] remove temporary define used for updating TestRunner API
1277
1278         Unreviewed. Clean-up change.
1279
1280         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1281
1282 2013-01-28  James Craig  <james@cookiecrook.com>
1283
1284         HTML5 promotes DL from specific 'definition list' to superset 'description list'; accessibility strings and accessors should be updated to match.
1285         https://bugs.webkit.org/show_bug.cgi?id=107650
1286
1287         Reviewed by Chris Fleizach.
1288
1289         Updating accessibility strings and accessors for DL/DT/DD.
1290
1291         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities.js:
1292         (createDescriptionList):
1293         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
1294         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1295
1296 2013-01-28  Manuel Rego Casasnovas  <rego@igalia.com>
1297
1298         [GTK][WTR] Update layoutTestController.pathToLocalResource
1299         https://bugs.webkit.org/show_bug.cgi?id=107538
1300
1301         Reviewed by Martin Robinson.
1302
1303         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1304         (WTR::TestRunner::pathToLocalResource): Update implementation based on
1305         DRT code.
1306
1307 2013-01-28  Manuel Rego Casasnovas  <rego@igalia.com>
1308
1309         [GTK][WTR] Move getTopLevelPath() to utilities file
1310         https://bugs.webkit.org/show_bug.cgi?id=107541
1311
1312         Reviewed by Martin Robinson.
1313
1314         * WebKitTestRunner/GNUmakefile.am: Add new files.
1315         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1316         (WTR::getOutputDir): Uses the moved method from InjectedBundleUtilities.
1317         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp: Added.
1318         (WTR):
1319         (WTR::topLevelPath): Implementation moved from ActivateFontsGtk.
1320         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.h: Added.
1321         (WTR): Add new method header and documentation.
1322
1323 2013-01-28  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1324
1325         [EFL] Include Ecore_Getopt.h in MiniBrowser.
1326         https://bugs.webkit.org/show_bug.cgi?id=108067
1327
1328         Reviewed by Kenneth Rohde Christiansen.
1329
1330         Be explicit and include Ecore_Getopt.h since we use it for parsing
1331         command line options. It is safer than relying on other headers
1332         including it for us.
1333
1334         * MiniBrowser/efl/main.c:
1335
1336 2013-01-28  Renata Hodovan  <reni@webkit.org>
1337
1338         [WK2] Putting QtWebProcess into a chrooted sandbox
1339         https://bugs.webkit.org/show_bug.cgi?id=90005
1340
1341         Reviewed by Anders Carlsson and  Zoltan Herczeg.
1342
1343         Add feature flag for suid sandbox in linux.
1344
1345         * Scripts/webkitperl/FeatureList.pm:
1346
1347 2013-01-27  David Farler  <dfarler@apple.com>
1348
1349         REGRESSION (r140912): Broke specifying non-trivial ARCHS value to make / build-webkit
1350         https://bugs.webkit.org/show_bug.cgi?id=108028
1351
1352         Reviewed by Dan Bernstein.
1353
1354         * DumpRenderTree/Makefile: Reverted.
1355         * Makefile: Reverted.
1356         * Scripts/webkitdirs.pm: Reverted.
1357
1358 2013-01-27  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
1359
1360         Fixing atomicIncrement implementation for Windows by dropping support before XP SP2.
1361         https://bugs.webkit.org/show_bug.cgi?id=106740
1362
1363         Reviewed by Benjamin Poulain.
1364
1365         * DumpRenderTree/config.h:
1366         * WinLauncher/stdafx.h:
1367
1368 2013-01-26  David Farler  <dfarler@apple.com>
1369
1370         Makefiles should work for arbitrary SDKs and architectures on Apple ports
1371         https://bugs.webkit.org/show_bug.cgi?id=107863
1372
1373         Reviewed by David Kilzer.
1374
1375         * Makefile:
1376         Added temporary filters for projects not yet building on iOS.
1377         * DumpRenderTree/Makefile:
1378         Building with iOS SDKs -> -target All-iOS
1379         * Scripts/webkitdirs.pm:
1380         (determineConfiguration):
1381         Added --configuration switch detection.
1382         (determineArchitecture):
1383         Added --architecture and ARCH=(.*) switch detection.
1384         (argumentsForConfiguration):
1385         (determineXcodeSDK):
1386         Look for --device, --simulator, and --sdk switches.
1387         (xcodeSDK):
1388         Added.
1389         (XcodeOptions):
1390         Determine Xcode SDK and generate -arch switches.
1391
1392 2013-01-25  Jochen Eisinger  <jochen@chromium.org>
1393
1394         [chromium] move tracking of the top loading frame to TestRunner library
1395         https://bugs.webkit.org/show_bug.cgi?id=107948
1396
1397         Reviewed by Adam Barth.
1398
1399         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1400         (DRTTestRunner::WorkQueue::processWorkSoon):
1401         (DRTTestRunner::WorkQueue::processWork):
1402         (DRTTestRunner::completeNotifyDone):
1403         * DumpRenderTree/chromium/DRTTestRunner.h:
1404         (DRTTestRunner):
1405         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1406         (WebTestProxyBase):
1407         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1408         (WebTestRunner::WebTestRunner::setTopLoadingFrame):
1409         (WebTestRunner::WebTestRunner::topLoadingFrame):
1410         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1411         (WebTestRunner::TestRunner::TestRunner):
1412         (WebTestRunner::TestRunner::reset):
1413         (WebTestRunner::TestRunner::setTopLoadingFrame):
1414         (WebTestRunner):
1415         (WebTestRunner::TestRunner::topLoadingFrame):
1416         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1417         (TestRunner):
1418         (WebTestRunner::TestRunner::locationChangeDone):
1419         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1420         (WebTestRunner::WebTestProxyBase::didStartProvisionalLoad):
1421         (WebTestRunner::WebTestProxyBase::didFailProvisionalLoad):
1422         (WebTestRunner::WebTestProxyBase::didFailLoad):
1423         (WebTestRunner::WebTestProxyBase::didFinishLoad):
1424         (WebTestRunner::WebTestProxyBase::locationChangeDone):
1425         (WebTestRunner):
1426         * DumpRenderTree/chromium/WebViewHost.cpp:
1427         (WebViewHost::reset):
1428         (WebViewHost::updateURL):
1429         * DumpRenderTree/chromium/WebViewHost.h:
1430         (WebViewHost):
1431
1432 2013-01-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1433
1434         Unreviewed, rolling out r140774.
1435         http://trac.webkit.org/changeset/140774
1436         https://bugs.webkit.org/show_bug.cgi?id=107932
1437
1438          Tests ScrollingCoordinatorChromiumTest.fastScrollingByDefault
1439         and fastScrollingForFixedPosition are failing (Requested by
1440         keishi on #webkit).
1441
1442         * DumpRenderTree/chromium/WebViewHost.cpp:
1443         (WebViewHost::initializeLayerTreeView):
1444         (WebViewHost::setWebWidget):
1445
1446 2013-01-25  Alan Cutter  <alancutter@chromium.org>
1447
1448         Quick fix for Chromium EWS bots running out of space due to a tmp file leak
1449         https://bugs.webkit.org/show_bug.cgi?id=107905
1450
1451         Reviewed by Eric Seidel.
1452
1453         Added line to EWS loop to clear /tmp of known Chromium test leak.
1454         Directories named ".org.chromium.Chromium.XXXXXX" not getting cleaned up.
1455
1456         * EWSTools/start-queue.sh:
1457
1458 2013-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1459
1460         Update Anne's email address
1461         https://bugs.webkit.org/show_bug.cgi?id=107866
1462
1463         Reviewed by Adam Barth.
1464
1465         * Scripts/webkitpy/common/config/committers.py:
1466
1467 2013-01-24  Alan Cutter  <alancutter@chromium.org>
1468
1469         HTTP 500 error between QueueStatusServer and bot(s)
1470         https://bugs.webkit.org/show_bug.cgi?id=107184
1471
1472         Reviewed by Adam Barth.
1473
1474         Removed the use of memcache which was the source of the exception.
1475
1476         * QueueStatusServer/handlers/updatestatus.py:
1477         (UpdateStatus.post):
1478         * QueueStatusServer/model/attachment.py:
1479         (Attachment):
1480         (Attachment.summary):
1481
1482 2013-01-24  Sheriff Bot  <webkit.review.bot@gmail.com>
1483
1484         Unreviewed, rolling out r140653.
1485         http://trac.webkit.org/changeset/140653
1486         https://bugs.webkit.org/show_bug.cgi?id=107916
1487
1488         Causes a temp file leak on the bots (Requested by abarth on
1489         #webkit).
1490
1491         * DumpRenderTree/chromium/TestShell.cpp:
1492         (TestShell::resetTestController):
1493
1494 2013-01-24  Eric Seidel  <eric@webkit.org>
1495
1496         Skip haslanded_unittest.py on systems which do not have interdiff installed
1497         https://bugs.webkit.org/show_bug.cgi?id=106402
1498
1499         Unreviewed.
1500
1501         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
1502         (HasLandedTest):
1503
1504 2013-01-24  Ryosuke Niwa  <rniwa@webkit.org>
1505
1506         Disable the failing webkitpy test for now.
1507
1508         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
1509
1510 2013-01-24  Tim 'mithro' Ansell  <mithro@mithis.com>
1511
1512         Fixing the diff_parser to correctly identify git diffs even with leading comments.
1513         https://bugs.webkit.org/show_bug.cgi?id=107871
1514
1515         Reviewed by Eric Seidel.
1516
1517         * Scripts/webkitpy/common/checkout/diff_parser.py:
1518         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
1519         * Scripts/webkitpy/tool/steps/haslanded.py:
1520
1521 2013-01-24  James Robinson  <jamesr@chromium.org>
1522
1523         [chromium] Remove dead transitional code from WebViewImpl
1524         https://bugs.webkit.org/show_bug.cgi?id=107889
1525
1526         Reviewed by Adrienne Walker.
1527
1528         * DumpRenderTree/chromium/WebViewHost.cpp:
1529         (WebViewHost::initializeLayerTreeView):
1530         (WebViewHost::setWebWidget):
1531
1532 2013-01-24  Joshua Bell  <jsbell@chromium.org>
1533
1534         Add watchlist for IndexedDB development, and add myself and others.
1535
1536         Unreviewed.
1537
1538         * Scripts/webkitpy/common/config/watchlist:
1539
1540 2013-01-24  Martin Robinson  <mrobinson@igalia.com>
1541
1542         Abstract the logic for appending a UChar32 onto StringBuilder
1543         https://bugs.webkit.org/show_bug.cgi?id=107505
1544
1545         Reviewed by Darin Adler.
1546
1547         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1548         (TestWebKitAPI::TEST): Added a simple test for appending UChar32.
1549
1550 2013-01-24  Erik Arvidsson  <arv@chromium.org>
1551
1552         Unreviewed, rolling out r140703.
1553         http://trac.webkit.org/changeset/140703
1554         https://bugs.webkit.org/show_bug.cgi?id=107556
1555
1556         r140561 was not the reason for the Android breakage
1557
1558         * DumpRenderTree/chromium/TestShell.cpp:
1559         (TestShell::~TestShell):
1560         (TestShell::closeWindow):
1561         * DumpRenderTree/chromium/WebViewHost.cpp:
1562         (WebViewHost::WebViewHost):
1563         (WebViewHost::~WebViewHost):
1564         (WebViewHost::shutdown):
1565         * DumpRenderTree/chromium/WebViewHost.h:
1566         (WebViewHost):
1567
1568 2013-01-24  Dean Jackson  <dino@apple.com>
1569
1570         Allow some plugin snapshot UI content to come from Injected Bundle
1571         https://bugs.webkit.org/show_bug.cgi?id=107852
1572
1573         Reviewed by Anders Carlsson.
1574
1575         Null implementations of plugInStartLabelTitle, plugInStartLabelSubtitle and
1576         plugInExtraStyleSheet.
1577
1578         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1579         (WTR::InjectedBundlePage::InjectedBundlePage):
1580
1581 2013-01-24  Erik Arvidsson  <arv@chromium.org>
1582
1583         Unreviewed, rolling out r140561.
1584         http://trac.webkit.org/changeset/140561
1585         https://bugs.webkit.org/show_bug.cgi?id=107556
1586
1587         Suspected to break Android which prevens WebKit roll
1588
1589         * DumpRenderTree/chromium/TestShell.cpp:
1590         (TestShell::~TestShell):
1591         (TestShell::closeWindow):
1592         * DumpRenderTree/chromium/WebViewHost.cpp:
1593         (WebViewHost::WebViewHost):
1594         (WebViewHost::~WebViewHost):
1595         * DumpRenderTree/chromium/WebViewHost.h:
1596         (WebViewHost):
1597
1598 2013-01-24  Tim 'mithro' Ansell  <mithro@mithis.com>
1599
1600         Adding "has-landed" command to webkit-patch which compares a
1601         committed patch to the changes which exist locally (ignoring the
1602         ChangeLog file).
1603
1604         https://bugs.webkit.org/show_bug.cgi?id=106402
1605
1606         Reviewed by Eric Seidel.
1607
1608         * Scripts/webkitpy/common/checkout/diff_parser.py:
1609         (git_diff_to_svn_diff):
1610         * Scripts/webkitpy/common/net/bugzilla/bug.py:
1611         (Bug.commit_revision):
1612         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
1613         (BugTest.test_is_in_comments):
1614         (BugTest):
1615         (BugTest.test_commit_revision):
1616         * Scripts/webkitpy/tool/commands/upload.py:
1617         (HasLanded):
1618         * Scripts/webkitpy/tool/steps/__init__.py:
1619         * Scripts/webkitpy/tool/steps/haslanded.py: Added.
1620         (HasLanded):
1621         (HasLanded.convert_to_svn):
1622         (HasLanded.strip_change_log):
1623         (run):
1624
1625         * Scripts/webkitpy/common/net/bugzilla/bug.py:
1626         (Bug.commit_revision):
1627         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
1628         (BugTest.test_is_in_comments):
1629         (BugTest):
1630         (BugTest.test_commit_revision):
1631         * Scripts/webkitpy/tool/commands/upload.py:
1632         (HasLanded):
1633         * Scripts/webkitpy/tool/steps/__init__.py:
1634         * Scripts/webkitpy/tool/steps/haslanded.py: Added.
1635         (HasLanded):
1636         (HasLanded.convert_to_svn):
1637         (HasLanded.strip_change_log):
1638         (HasLanded.diff_diff):
1639         (HasLanded.run):
1640         * Scripts/webkitpy/tool/steps/haslanded_unittest.py: Added.
1641         (HasLandedTest):
1642         (HasLandedTest.test_run):
1643         (test_convert_to_svn_and_strip_change_log):
1644
1645 2013-01-24  Dan Carney  <dcarney@google.com>
1646
1647         [chromium] move most WebViewHost printf calls to WebTestProxy
1648         https://bugs.webkit.org/show_bug.cgi?id=107553
1649
1650         Reviewed by Jochen Eisinger.
1651
1652         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1653         (WebKit):
1654         (WebTestProxyBase):
1655         (WebTestRunner::WebTestProxy::unableToImplementPolicyWithError):
1656         (WebTestRunner::WebTestProxy::didAddMessageToConsole):
1657         (WebTestRunner::WebTestProxy::runModalAlertDialog):
1658         (WebTestRunner::WebTestProxy::runModalConfirmDialog):
1659         (WebTestRunner::WebTestProxy::runModalPromptDialog):
1660         (WebTestRunner::WebTestProxy::runModalBeforeUnloadDialog):
1661         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1662         (WebTestRunner::WebTestProxyBase::WebTestProxyBase):
1663         (WebTestRunner::WebTestProxyBase::reset):
1664         (WebTestRunner::WebTestProxyBase::setLogConsoleOutput):
1665         (WebTestRunner):
1666         (WebTestRunner::WebTestProxyBase::unableToImplementPolicyWithError):
1667         (WebTestRunner::WebTestProxyBase::didAddMessageToConsole):
1668         (WebTestRunner::WebTestProxyBase::runModalAlertDialog):
1669         (WebTestRunner::WebTestProxyBase::runModalConfirmDialog):
1670         (WebTestRunner::WebTestProxyBase::runModalPromptDialog):
1671         (WebTestRunner::WebTestProxyBase::runModalBeforeUnloadDialog):
1672         * DumpRenderTree/chromium/TestShell.cpp:
1673         (TestShell::showDevTools):
1674         * DumpRenderTree/chromium/WebViewHost.cpp:
1675         (WebViewHost::didAddMessageToConsole):
1676         (WebViewHost::runModalAlertDialog):
1677         (WebViewHost::runModalConfirmDialog):
1678         (WebViewHost::runModalPromptDialog):
1679         (WebViewHost::runModalBeforeUnloadDialog):
1680         (WebViewHost::unableToImplementPolicyWithError):
1681         (WebViewHost::reset):
1682         * DumpRenderTree/chromium/WebViewHost.h:
1683         (WebViewHost):
1684
1685 2013-01-23  Mark Pilgrim  <pilgrim@chromium.org>
1686
1687         [Chromium] Give webkit_support a chance to reset state between layout test runs
1688         https://bugs.webkit.org/show_bug.cgi?id=107132
1689
1690         Reviewed by Adam Barth.
1691
1692         We currently only have need for this on OS(ANDROID), but now it
1693         would be useful to have a hook for resetting state on all
1694         platforms. Will soon be using this for IDBFactory initialization.
1695
1696         * DumpRenderTree/chromium/TestShell.cpp:
1697         (TestShell::resetTestController): Call webkit_support::ResetTestEnvironment()
1698
1699 2013-01-23  Alan Cutter  <alancutter@chromium.org>
1700
1701         QueueStatusServer crashes in production on next-patch
1702         https://bugs.webkit.org/show_bug.cgi?id=107775
1703
1704         Reviewed by Adam Barth.
1705
1706         Replaced Python 2.5 incompatible call to timedelta.total_seconds().
1707
1708         * QueueStatusServer/app.yaml:
1709         * QueueStatusServer/model/patchlog.py:
1710         (PatchLog.calculate_wait_duration):
1711         (PatchLog.calculate_process_duration):
1712         (PatchLog):
1713         (PatchLog._time_delta_to_seconds):
1714
1715 2013-01-23  Ryosuke Niwa  <rniwa@webkit.org>
1716
1717         The previous patch wasn't complete. Finish reverting r139998 for real.
1718
1719         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
1720         (ProfilerAgent.getProfile):
1721
1722 2013-01-23  Ryosuke Niwa  <rniwa@webkit.org>
1723
1724         Revert r139998 for now since the Leaks Viewer pulls in a specific version of Inspector code.
1725
1726         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
1727         (ProfilerAgent.getProfile):
1728
1729 2013-01-23  Mark Pilgrim  <pilgrim@chromium.org>
1730
1731         [Chromium] Remove unused header files in chromium/public/platform/
1732         https://bugs.webkit.org/show_bug.cgi?id=107741
1733
1734         Reviewed by James Robinson.
1735
1736         These header files have migrated to the new Platform directory.
1737         This patch updates the remaining #include references and removes
1738         the old files that did nothing but redirect to the new ones.
1739
1740         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp:
1741         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:
1742
1743 2013-01-23  Martin Robinson  <mrobinson@igalia.com>
1744
1745         [GTK] Bump webkitgtk-test-fonts dependency to cover fallbacks for Tamil, Bengali, and others
1746         https://bugs.webkit.org/show_bug.cgi?id=107727
1747
1748         Reviewed by Gustavo Noronha Silva.
1749
1750         * gtk/jhbuild.modules: Update the JHBuild moduleset to point to the new webkitgtk-test-fonts.
1751         We are using the git repository now that github has deprecated the downloads feature.
1752
1753 2013-01-23  Tony Chang  <tony@chromium.org>
1754
1755         Unreviewed, set svn:eol-style to CRLF on Windows .sln files.
1756
1757         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
1758         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
1759         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
1760         * WebKitTestRunner/WebKitTestRunner.sln: Modified property svn:eol-style.
1761
1762 2013-01-23  Mark Pilgrim  <pilgrim@chromium.org>
1763
1764         [Chromium] Update some #includes in DumpRenderTree for headers in the new Platform directory
1765         https://bugs.webkit.org/show_bug.cgi?id=107145
1766
1767         Reviewed by Adam Barth.
1768
1769         Part of a larger refactoring series; see tracking bug 82948.
1770         
1771         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1772         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1773         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1774         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1775         * DumpRenderTree/chromium/DRTTestRunner.h:
1776         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h:
1777         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
1778         * DumpRenderTree/chromium/MockWebSpeechInputController.h:
1779         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1780         * DumpRenderTree/chromium/TestNavigationController.h:
1781         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp:
1782         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1783         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:
1784         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
1785         (WebTestRunner):
1786         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
1787         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h:
1788         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
1789         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
1790         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1791         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1792         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:
1793         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp:
1794         * DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp:
1795         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1796         * DumpRenderTree/chromium/TestShell.cpp:
1797         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
1798         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
1799         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
1800         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
1801         * DumpRenderTree/chromium/WebViewHost.cpp:
1802
1803 2013-01-23  Jochen Eisinger  <jochen@chromium.org>
1804
1805         [chromium] Use after free in plugins/geturlnotify-during-document-teardown.html
1806         https://bugs.webkit.org/show_bug.cgi?id=107556
1807
1808         Reviewed by Tony Chang.
1809
1810         WebViewHost initiates a navigation to about:blank in its destructor.
1811         However, since WebTestProxy inherits from WebViewHost, at this point
1812         the WebViewClient and WebFrameClient interfaces are already partially
1813         destructed resulting in the use after free.
1814
1815         This does not affect the chromium implementation since it doesn't
1816         invoke WebKit API methods in its destructor.
1817
1818         * DumpRenderTree/chromium/TestShell.cpp:
1819         (TestShell::~TestShell):
1820         (TestShell::closeWindow):
1821         * DumpRenderTree/chromium/WebViewHost.cpp:
1822         (WebViewHost::WebViewHost):
1823         (WebViewHost::~WebViewHost):
1824         (WebViewHost::shutdown):
1825         * DumpRenderTree/chromium/WebViewHost.h:
1826         (WebViewHost):
1827
1828 2013-01-23  Andrei Bucur  <abucur@adobe.com>
1829
1830         [CSS Regions] Create Regions watchlist
1831         https://bugs.webkit.org/show_bug.cgi?id=107281
1832
1833         Reviewed by Adam Barth.
1834
1835         This patch adds 4 new definitions:
1836         - RegionsDevelopment - used to track the development progress for regions
1837         - RegionsExpectationsMore and RegionsExpectationsLess - used to track expectations changes for the regions tests
1838         - RegionsUsage - used to track changes that make use of regions in all the code base
1839
1840         For now, the Adobe internal tracker is the only email address listening for these patterns.
1841
1842         * Scripts/webkitpy/common/config/watchlist:
1843
1844 2013-01-22  Pavel Feldman  <pfeldman@chromium.org>
1845
1846         Web Inspector: only allow evaluateForTestInFrontend for front-ends under test.
1847         https://bugs.webkit.org/show_bug.cgi?id=107523
1848
1849         Reviewed by Yury Semikhatsky.
1850
1851         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1852         (DRTDevToolsClient::isUnderTest):
1853         (DRTDevToolsClient::call):
1854         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1855         (DRTDevToolsClient):
1856
1857 2013-01-23  Tim 'mithro' Ansell  <mithro@mithis.com>
1858
1859         Removing command line shortening as it makes it difficult to see the command during errors.
1860         https://bugs.webkit.org/show_bug.cgi?id=107643
1861
1862         Reviewed by Eric Seidel.
1863
1864         * Scripts/webkitpy/common/system/executive.py:
1865         (ScriptError):
1866         (ScriptError.__init__):
1867         * Scripts/webkitpy/common/system/executive_unittest.py:
1868
1869 2013-01-23  Tim 'mithro' Ansell  <mithro@mithis.com>
1870
1871         Adding myself as contributor in committers.py (as requested by eseidel).
1872         https://bugs.webkit.org/show_bug.cgi?id=107647
1873
1874         Reviewed by Eric Seidel.
1875
1876         * Scripts/webkitpy/common/config/committers.py:
1877
1878 2013-01-22  Alan Cutter  <alancutter@chromium.org>
1879
1880         Add monitoring of patches and queues to the QueueStatusServer
1881         https://bugs.webkit.org/show_bug.cgi?id=107612
1882
1883         Reviewed by Adam Barth.
1884
1885         Created classes for recording events into the datastore and integrated them into the existing handlers.
1886         Code for presenting the recorded data will come in a separate patch.
1887
1888         * QueueStatusServer/app.yaml:
1889         * QueueStatusServer/config/__init__.py: Added.
1890         * QueueStatusServer/config/logging.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
1891         * QueueStatusServer/config/messages.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
1892         * QueueStatusServer/handlers/nextpatch.py:
1893         (NextPatch.get):
1894         (NextPatch._assign_patch):
1895         * QueueStatusServer/handlers/releasepatch.py:
1896         (ReleasePatch.post):
1897         * QueueStatusServer/handlers/updatestatus.py:
1898         (UpdateStatus.post):
1899         * QueueStatusServer/handlers/updateworkitems.py:
1900         (UpdateWorkItems._parse_work_items_string):
1901         (UpdateWorkItems):
1902         (UpdateWorkItems._update_work_items_from_request):
1903         (UpdateWorkItems._queue_from_request):
1904         (UpdateWorkItems.post):
1905         * QueueStatusServer/loggers/__init__.py: Added.
1906         * QueueStatusServer/loggers/recordbotevent.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
1907         (RecordBotEvent):
1908         (RecordBotEvent.activity):
1909         * QueueStatusServer/loggers/recordpatchevent.py: Added.
1910         (RecordPatchEvent):
1911         (RecordPatchEvent.added):
1912         (RecordPatchEvent.retrying):
1913         (RecordPatchEvent.started):
1914         (RecordPatchEvent.stopped):
1915         (RecordPatchEvent.updated):
1916         (RecordPatchEvent._get_patches_waiting):
1917         * QueueStatusServer/model/patchlog.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
1918         (PatchLog):
1919         (PatchLog.lookup):
1920         (PatchLog.calculate_wait_duration):
1921         (PatchLog.calculate_process_duration):
1922         * QueueStatusServer/model/queuelog.py: Copied from Tools/QueueStatusServer/handlers/nextpatch.py.
1923         (QueueLog):
1924         (QueueLog.get_current):
1925         (QueueLog.create_key):
1926         * QueueStatusServer/model/queuestatus.py:
1927         (QueueStatus.is_retry_request):
1928
1929 2013-01-22  Timothy Loh  <timloh@chromium.com>
1930
1931         prepare-Changelog should support updating the list of changed files
1932         https://bugs.webkit.org/show_bug.cgi?id=74358
1933
1934         Reviewed by Eric Seidel.
1935
1936         Needing to re-make ChangeLog entries when the list of files/functions
1937         changes is a bit annoying, it'd be nice to have this more automated.
1938         This patch makes `webkit-patch update' update the date line and bug
1939         description if needed, and if the list of changed files/functions has
1940         changed, either updates the list (if there are no annotations), or
1941         otherwise appends the new list below.
1942
1943         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1944         (PrepareChangeLog._resolve_existing_entry):
1945         (PrepareChangeLog):
1946         (PrepareChangeLog._merge_entries):
1947         (PrepareChangeLog.run):
1948         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
1949         (PrepareChangeLogTest.test_resolve_existing_entry):
1950         (make_entry):
1951         (test_ensure_bug_url):
1952
1953 2013-01-22  Tim 'mithro' Ansell  <mithro@mithis.com>
1954
1955         Use Python 2.7 unittest syntax in our unittests
1956         https://bugs.webkit.org/show_bug.cgi?id=105607
1957
1958         Reviewed by Eric Seidel.
1959
1960         * Scripts/webkitpy/**/*_unittest.py:
1961
1962 2013-01-22  Tim 'mithro' Ansell  <mithro@mithis.com>
1963
1964         Convert disable-msg to disable for new pylint.
1965         https://bugs.webkit.org/show_bug.cgi?id=107627
1966
1967         Reviewed by Eric Seidel.
1968
1969         * Scripts/webkitpy/common/checkout/scm/svn.py:
1970         (SVNRepository.has_authorization_for_realm):
1971         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1972         (Builder.force_build):
1973         * Scripts/webkitpy/common/system/executive_mock.py:
1974         (MockExecutive2.run_command):
1975         * Scripts/webkitpy/layout_tests/port/base.py:
1976         (Port.reference_files):
1977         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
1978         (ChromiumPortTestCase.test_default_configuration):
1979         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1980         (PortTestCase.test_expectations_ordering):
1981         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1982         (HttpServerBase._check_that_all_ports_are_available):
1983         * Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
1984         (AbstractLocalServerCommand.execute):
1985         * Scripts/webkitpy/tool/commands/download.py:
1986         (AbstractPatchProcessingCommand):
1987         * Scripts/webkitpy/tool/commands/rebaseline.py:
1988         (AbstractRebaseliningCommand):
1989         (AbstractParallelRebaselineCommand):
1990         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1991         (_BaseTestCase.setUp):
1992         (TestAnalyzeBaselines.setUp):
1993
1994 2013-01-22  Frank Farzan  <frankf@chromium.org>
1995
1996         Flakiness dashboard: update builders.jsonp
1997         https://bugs.webkit.org/show_bug.cgi?id=107610
1998
1999         Reviewed by Ojan Vafai.
2000
2001         * TestResultServer/static-dashboards/builders.jsonp:
2002
2003 2013-01-22  Frank Farzan  <frankf@chromium.org>
2004
2005         Add Android instrumentation tests from ChromiumLinux waterfall
2006         https://bugs.webkit.org/show_bug.cgi?id=107597
2007
2008         Reviewed by Ojan Vafai.
2009
2010         * TestResultServer/static-dashboards/builders.js:
2011         (loadBuildersList):
2012
2013 2013-01-21  Kentaro Hara  <haraken@chromium.org>
2014
2015         Implement UIEvent constructor
2016         https://bugs.webkit.org/show_bug.cgi?id=107430
2017
2018         Reviewed by Adam Barth.
2019
2020         Editor's draft: https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm
2021
2022         UIEvent constructor is implemented under a DOM4_EVENTS_CONSTRUCTOR flag,
2023         which is enabled on Safari and Chromium for now.
2024
2025         * Scripts/webkitperl/FeatureList.pm:
2026
2027 2013-01-22  Timothy Loh  <timloh@chromium.com>
2028
2029         Add functions to ChangeLog - parse bug desc/changed functions, delete/prepend entries
2030         https://bugs.webkit.org/show_bug.cgi?id=107478
2031
2032         Reviewed by Eric Seidel.
2033
2034         On the road to resolving Bug 74358, we need a few more functions in
2035         changelog.py.
2036         To make things easier to mock, change @staticmethods to @classmethods.
2037
2038         * Scripts/webkitpy/common/checkout/changelog.py:
2039         (ChangeLogEntry):
2040         (ChangeLogEntry._parse_reviewer_text):
2041         (ChangeLogEntry._split_contributor_names):
2042         (ChangeLogEntry._parse_author_name_and_email):
2043         (ChangeLogEntry._parse_author_text):
2044         (ChangeLogEntry._parse_touched_functions):
2045         (ChangeLogEntry._parse_bug_description):
2046         (ChangeLogEntry._parse_entry):
2047         (ChangeLogEntry.date_line):
2048         (ChangeLogEntry.bug_description):
2049         (ChangeLogEntry.touched_functions):
2050         (ChangeLogEntry.touched_files_text):
2051         (ChangeLogEntry.is_touched_files_text_clean):
2052         (ChangeLog):
2053         (ChangeLog.parse_latest_entry_from_file):
2054         (ChangeLog._separate_revision_and_line):
2055         (ChangeLog.parse_entries_from_file):
2056         (ChangeLog.set_short_description_and_bug_url):
2057         (ChangeLog.delete_entries):
2058         (ChangeLog.prepend_text):
2059         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2060         (test_parse_log_entries_from_changelog):
2061         (test_latest_entry_parse):
2062         (test_set_short_description_and_bug_url):
2063         (test_delete_entries):
2064         (test_prepend_text):
2065
2066 2013-01-22  Lucas Forschler  <lforschler@apple.com>
2067
2068         Create a MAC EWS startup shell script.
2069
2070         Reviewed by Ryosuke Niwa.
2071
2072         * EWSTools/start-queue-mac.sh: Added.
2073
2074 2013-01-22  Joseph Pecoraro  <pecoraro@apple.com>
2075
2076         [Mac] Enable Page Visibility (PAGE_VISIBILITY_API)
2077         https://bugs.webkit.org/show_bug.cgi?id=107230
2078
2079         Reviewed by David Kilzer.
2080
2081         * DumpRenderTree/mac/TestRunnerMac.mm:
2082         (TestRunner::resetPageVisibility):
2083         Fix a typo in the original implementation. resetPageVisibility should
2084         pass initialState YES so an event is not dispatched, which causes
2085         issues in multiple tests. This now matches other ports.
2086
2087 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
2088
2089         [GTK] Enable CSS Image Orientation feature
2090         https://bugs.webkit.org/show_bug.cgi?id=99040
2091
2092         Reviewed by Martin Robinson.
2093
2094         Enable the CSS Image Orientation feature in the development
2095         builds of the GTK port. The feature is still disabled in the release
2096         builds.
2097
2098         * Scripts/webkitperl/FeatureList.pm:
2099
2100 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
2101
2102         [GTK] Enable the <template> element support in development builds
2103         https://bugs.webkit.org/show_bug.cgi?id=106575
2104
2105         Reviewed by Martin Robinson.
2106
2107         Enable the <template> element support in the development builds of the GTK port.
2108
2109         * Scripts/webkitperl/FeatureList.pm:
2110
2111 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
2112
2113         Prettify the output of the override-feature-defines script
2114         https://bugs.webkit.org/show_bug.cgi?id=106542
2115
2116         Reviewed by Martin Robinson.
2117
2118         The output now clearly lists the feature defines being overridden
2119         along with the default and overriding values for each feature define.
2120
2121         * gtk/override-feature-defines:
2122         (adjust_feature_defines_makefile):
2123         (adjust_feature_defines_makefile.override_feature_define):
2124
2125 2013-01-22  Zan Dobersek  <zdobersek@igalia.com>
2126
2127         Remove uses of deprecated unittest.TestCase aliases
2128         https://bugs.webkit.org/show_bug.cgi?id=102252
2129
2130         Reviewed by Adam Barth.
2131
2132         Replace the deprecated assertEquals method of the TestCase interface
2133         used in some webkitpy unittests with the assertEqual method.
2134
2135         * Scripts/webkitpy/common/system/profiler_unittest.py:
2136         (ProfilerFactoryTest._assert_default_profiler_name):
2137         (ProfilerFactoryTest.test_default_profiler_output):
2138         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2139         (GtkPortTest.test_expectations_files):
2140         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2141         (TestHttpServer.test_win32_start_and_stop):
2142
2143 2013-01-22  Jer Noble  <jer.noble@apple.com>
2144
2145         REGRESSION(r140344): Repeated crashes in WKTR PlatformWebView::viewSupportsOptions().
2146         https://bugs.webkit.org/show_bug.cgi?id=107562
2147
2148         Rubber-stamped by Alexy Proskuryakov.
2149
2150         The input to WKBooleanGetValue() is not NULL-safe, so NULL check its inputs before calling.
2151
2152         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2153         (WTR::PlatformWebView::PlatformWebView):
2154         (WTR::PlatformWebView::viewSupportsOptions):
2155
2156 2013-01-22  Alexey Proskuryakov  <ap@apple.com>
2157
2158         One is not allowed to use commit-queue to make oneself a committer.
2159
2160         * Scripts/webkitpy/common/config/committers.py: Removing eustas@chromium.org.
2161
2162 2013-01-22  Eugene Klyuchnikov  <eustas@chromium.org>
2163
2164         Add myself to commiters.py
2165         https://bugs.webkit.org/show_bug.cgi?id=107546
2166
2167         Reviewed by Kentaro Hara.
2168
2169         * Scripts/webkitpy/common/config/committers.py:
2170
2171 2013-01-22  Manuel Rego Casasnovas  <rego@igalia.com>
2172
2173         [GTK] Implement TestRunner::setTextDirection
2174         https://bugs.webkit.org/show_bug.cgi?id=107131
2175
2176         Reviewed by Philippe Normand.
2177
2178         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2179         (resetDefaultsToConsistentValues): Reset direction to default value.
2180         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2181         (TestRunner::setTextDirection): Implement method using
2182         gtk_widget_set_direction.
2183
2184 2013-01-22  Jochen Eisinger  <jochen@chromium.org>
2185
2186         [chromium] move spell checking mocks to TestRunner library
2187         https://bugs.webkit.org/show_bug.cgi?id=107455
2188
2189         Reviewed by Kent Tamura.
2190
2191         The content module doesn't provide its own WebSpellCheckClient.
2192
2193         * DumpRenderTree/DumpRenderTree.gypi:
2194         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2195         (WebTestRunner::WebTestDelegate::fillSpellingSuggestionList):
2196         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2197         (WebKit):
2198         (WebTestRunner):
2199         (WebTestProxyBase):
2200         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
2201         (WebTestRunner):
2202         (WebTestRunner::makeMenuItemStringsFor):
2203         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Renamed from Tools/DumpRenderTree/chromium/MockGrammarCheck.cpp.
2204         (MockGrammarCheck::checkGrammarOfString):
2205         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Renamed from Tools/DumpRenderTree/chromium/MockGrammarCheck.h.
2206         (WebKit):
2207         (MockGrammarCheck):
2208         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Renamed from Tools/DumpRenderTree/chromium/MockSpellCheck.cpp.
2209         (MockSpellCheck::MockSpellCheck):
2210         (MockSpellCheck::~MockSpellCheck):
2211         (isNotASCIIAlpha):
2212         (MockSpellCheck::spellCheckWord):
2213         (MockSpellCheck::fillSuggestionList):
2214         (MockSpellCheck::initializeIfNeeded):
2215         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Renamed from Tools/DumpRenderTree/chromium/MockSpellCheck.h.
2216         (MockSpellCheck):
2217         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Added.
2218         (WebTestRunner::SpellCheckClient::SpellCheckClient):
2219         (WebTestRunner):
2220         (WebTestRunner::SpellCheckClient::~SpellCheckClient):
2221         (WebTestRunner::SpellCheckClient::setDelegate):
2222         (WebTestRunner::SpellCheckClient::spellCheck):
2223         (WebTestRunner::SpellCheckClient::checkTextOfParagraph):
2224         (WebTestRunner::SpellCheckClient::requestCheckingOfText):
2225         (WebTestRunner::SpellCheckClient::finishLastTextCheck):
2226         (WebTestRunner::SpellCheckClient::autoCorrectWord):
2227         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.
2228         (WebTestRunner):
2229         (SpellCheckClient):
2230         (WebTestRunner::SpellCheckClient::taskList):
2231         (WebTestRunner::SpellCheckClient::mockSpellCheck):
2232         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
2233         (TestDelegate):
2234         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2235         (WebTestInterfaces::Internal):
2236         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2237         (WebTestRunner::WebTestProxyBase::WebTestProxyBase):
2238         (WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
2239         (WebTestRunner::WebTestProxyBase::setDelegate):
2240         (WebTestRunner::WebTestProxyBase::spellCheckClient):
2241         (WebTestRunner):
2242         * DumpRenderTree/chromium/WebViewHost.cpp:
2243         (WebViewHost::WebViewHost):
2244         (WebViewHost::setWebWidget):
2245         * DumpRenderTree/chromium/WebViewHost.h:
2246         (WebViewHost):
2247
2248 2013-01-22  Krzysztof Czech  <k.czech@samsung.com>
2249
2250         [EFL] Adds Accessibility support to wk1
2251         https://bugs.webkit.org/show_bug.cgi?id=107440
2252
2253         Reviewed by Gyuyoung Kim.
2254
2255         * DumpRenderTree/efl/CMakeLists.txt: Adds ATK headers and libraries.
2256
2257 2013-01-21  Joseph Pecoraro  <pecoraro@apple.com>
2258
2259         [Mac] WK1 MiniBrowser should clear delegates before releasing webview
2260         https://bugs.webkit.org/show_bug.cgi?id=107506
2261
2262         Reviewed by Dan Bernstein.
2263
2264         * MiniBrowser/mac/WK1BrowserWindowController.m:
2265         (-[WK1BrowserWindowController dealloc]):
2266
2267 2013-01-21  Dirk Schulze  <dschulze@adobe.com>
2268
2269         Add build flag for Canvas's Path object (disabled by default)
2270         https://bugs.webkit.org/show_bug.cgi?id=107473
2271
2272         Reviewed by Dean Jackson.
2273
2274         Add CANVAS_PATH build flag to build systems.
2275
2276         * Scripts/webkitperl/FeatureList.pm:
2277
2278 2013-01-21  Jinwoo Song  <jinwoo7.song@samsung.com>
2279
2280         [EFL][WK2] Add APIs to set/get view source mode
2281         https://bugs.webkit.org/show_bug.cgi?id=106633
2282
2283         Reviewed by Gyuyoung Kim.
2284
2285         Added a shotcut 'F8' in Minibrowser to display a source code
2286         of the web page in a new window.
2287
2288        * MiniBrowser/efl/main.c:
2289         (on_key_down):
2290         (on_window_create):
2291         (window_create):
2292         (elm_main):
2293
2294 2013-01-21  Nico Weber  <thakis@chromium.org>
2295
2296         [chromium] Don't archive generated source files.
2297         https://bugs.webkit.org/show_bug.cgi?id=106736
2298
2299         Reviewed by Eric Seidel.
2300
2301         They shouldn't be needed to run tests. They don't need a lot of space,
2302         but add many lines to the "extracting" stdout. This attempts to reduce
2303         that noise a bit.
2304
2305         * BuildSlaveSupport/built-product-archive:
2306         (archiveBuiltProduct):
2307
2308 2013-01-21  Benjamin Poulain  <benjamin@webkit.org>
2309
2310         Mac DumpRenderTree's installSignalHandlers() is unreachable code
2311         https://bugs.webkit.org/show_bug.cgi?id=107383
2312
2313         Reviewed by Sam Weinig.
2314
2315         The CrashHandler of DumpRenderTree were originally used for restoring
2316         the color profile of the main display even if DRT crashes.
2317
2318         That feature was later limited to pixel tests only in r29999.
2319
2320         In r104351, the DRT was changed to use device color space. Making the crash
2321         handlers useless, but they were left in the code since the error reporting
2322         code was still reachable.
2323
2324         Later, r124581 refactored the code and dumpPixelsForCurrentTest
2325         is being used before being assigned its value.
2326         This did cause any regression because the code had become useless with the previous change.
2327
2328         * DumpRenderTree/mac/DumpRenderTree.mm:
2329         Remove crashHandler() and installSignalHandlers() as they have become useless and
2330         have been unreachable code for 6 months.
2331         (dumpRenderTree):
2332         Remove the code that was unreachable due to dumpPixelsForCurrentTest being always false
2333         at those points.
2334
2335 2013-01-21  Nico Weber  <thakis@chromium.org>
2336
2337         Make ninja the default build system for build-webkit --chromium on mac
2338         https://bugs.webkit.org/show_bug.cgi?id=106737
2339
2340         Reviewed by Eric Seidel.
2341
2342         * Scripts/update-webkit-chromium:
2343
2344 2013-01-21  Christophe Dumez  <christophe.dumez@intel.com>
2345
2346         Regression(r140262): Causes a lot of flakiness
2347         https://bugs.webkit.org/show_bug.cgi?id=107454
2348
2349         Reviewed by Alexey Proskuryakov.
2350
2351         r140262 introduced a lot of flakiness due to fixed layout mode
2352         not getting disabled on the view after being enabled for
2353         specific test cases. This patch makes sure fixed layout mode
2354         properly gets reset in WebKitTestRunner to avoid flakiness.
2355
2356         * WebKitTestRunner/TestInvocation.cpp:
2357         (WTR::updateLayoutType):
2358
2359 2013-01-21  Gustavo Noronha Silva  <gns@gnome.org>
2360
2361         REGRESSION (r140285): GTK uses WKPageResourceLoadClient which was removed
2362         https://bugs.webkit.org/show_bug.cgi?id=107421
2363
2364         Unreviewed build fix.
2365
2366         * Scripts/run-gtk-tests:
2367         (TestRunner): skip Resource tests.
2368
2369 2013-01-21  Christophe Dumez  <christophe.dumez@intel.com>
2370
2371         [EFL][WKTR] platformRunUntil() should keep the main loop running
2372         https://bugs.webkit.org/show_bug.cgi?id=107442
2373
2374         Reviewed by Noam Rosenthal.
2375
2376         EFL's implementation of platformRunUntil() should keep the main loop
2377         running and avoid calling sleep() between calls to
2378         ecore_main_loop_iterate(). This call to sleep seems to be a source
2379         of deadlocks (see Bug 106884).
2380
2381         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2382         (WTR::TestController::platformRunUntil):
2383
2384 2013-01-21  Vivek Galatage  <vivek.vg@samsung.com>
2385
2386         QtTestBrowser should provide way to clear selected elements
2387         https://bugs.webkit.org/show_bug.cgi?id=107437
2388
2389         Reviewed by Simon Hausmann.
2390
2391         Provide a way to "Clear selection" in the "Develop" menu to clear the previous search highlight.
2392         Invoke the clearSelection prior to highlighting new elements.
2393
2394         * QtTestBrowser/launcherwindow.cpp:
2395         (ElementHighlight):
2396         (LauncherWindow::createChrome):
2397         (LauncherWindow::selectElements):
2398         (LauncherWindow::clearSelection):
2399         * QtTestBrowser/launcherwindow.h:
2400         (LauncherWindow):
2401
2402 2013-01-21  Jochen Eisinger  <jochen@chromium.org>
2403
2404         [chromium] move methods interacting with willSendRequest to TestRunner
2405         https://bugs.webkit.org/show_bug.cgi?id=107270
2406
2407         Reviewed by Kent Tamura.
2408
2409         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2410         (DRTTestRunner::DRTTestRunner):
2411         (DRTTestRunner::waitForPolicyDelegate):
2412         * DumpRenderTree/chromium/DRTTestRunner.h:
2413         (DRTTestRunner):
2414         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2415         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
2416         (WebTestRunner::WebTestRunner::httpHeadersToClear):
2417         (WebTestRunner::WebTestRunner::shouldBlockRedirects):
2418         (WebTestRunner::WebTestRunner::willSendRequestShouldReturnNull):
2419         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2420         (WebTestRunner::TestRunner::TestRunner):
2421         (WebTestRunner::TestRunner::reset):
2422         (WebTestRunner::TestRunner::httpHeadersToClear):
2423         (WebTestRunner):
2424         (WebTestRunner::TestRunner::shouldBlockRedirects):
2425         (WebTestRunner::TestRunner::willSendRequestShouldReturnNull):
2426         (WebTestRunner::TestRunner::setWillSendRequestClearHeader):
2427         (WebTestRunner::TestRunner::setWillSendRequestReturnsNullOnRedirect):
2428         (WebTestRunner::TestRunner::setWillSendRequestReturnsNull):
2429         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2430         (TestRunner):
2431         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2432         (WebTestRunner::WebTestProxyBase::willSendRequest):
2433         * DumpRenderTree/chromium/WebViewHost.cpp:
2434         (WebViewHost::willSendRequest):
2435         (WebViewHost::reset):
2436         * DumpRenderTree/chromium/WebViewHost.h:
2437         (WebViewHost):
2438
2439 2013-01-21  Zan Dobersek  <zdobersek@igalia.com>
2440
2441         [GTK] Stop building WebKit2 on GTK EWSs
2442         https://bugs.webkit.org/show_bug.cgi?id=107435
2443
2444         Reviewed by Philippe Normand.
2445
2446         The WebKit2 build of the GTK is at the moment not efficiently maintainable,
2447         so stop building it on GTK EWSs.
2448
2449         * Scripts/webkitpy/common/config/ports.py:
2450         (GtkPort.build_webkit_command):
2451         * Scripts/webkitpy/common/config/ports_unittest.py:
2452         (DeprecatedPortTest.test_gtk_port):
2453
2454 2013-01-21  Tommy Widenflycht  <tommyw@google.com>
2455
2456         MediaStream API: Update the RTCPeerConnection states to match the latest specification
2457         https://bugs.webkit.org/show_bug.cgi?id=107120
2458
2459         Reviewed by Adam Barth.
2460
2461         Updating mock to use the new states.
2462
2463         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2464         (RTCPeerConnectionStateTask::RTCPeerConnectionStateTask):
2465         (MockWebRTCPeerConnectionHandler::initialize):
2466         (MockWebRTCPeerConnectionHandler::updateICE):
2467
2468 2013-01-20  Tim 'mithro' Ansell  <mithro@mithis.com>
2469
2470         Extend diff_parser to support the --full-index output.
2471         https://bugs.webkit.org/show_bug.cgi?id=107408
2472
2473         Reviewed by Maciej Stachowiak.
2474
2475         * Scripts/webkitpy/common/checkout/diff_parser.py:
2476         (git_diff_to_svn_diff):
2477         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
2478         (DiffParserTest):
2479         (DiffParserTest.test_git_diff_to_svn_diff):
2480         (git_diff_to_svn_diff):
2481
2482 2013-01-20  Yoshifumi Inoue  <yosin@chromium.org>
2483
2484         Dragging over an element with scrollbars should scroll the element when dragging near edges
2485         https://bugs.webkit.org/show_bug.cgi?id=39725
2486
2487         Reviewed by Hajime Morita.
2488
2489         This patch introduces canceling drag-and-drop by escape key for testing
2490         behavior after cancellation drag-and-drop.
2491
2492         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
2493         (WebTestRunner):
2494         (WebTestRunner::EventSender::doMouseUp):
2495         (WebTestRunner::EventSender::finishDragAndDrop):
2496         (WebTestRunner::EventSender::keyDown):
2497         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
2498         (EventSender):
2499         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Added VKEY_ESCAPE.
2500
2501 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
2502
2503         [chromium] move frame generation related methods to TestRunner
2504         https://bugs.webkit.org/show_bug.cgi?id=107268
2505
2506         Reviewed by Adam Barth.
2507
2508         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2509         (DRTTestRunner::DRTTestRunner):
2510         (DRTTestRunner::setWillSendRequestReturnsNull):
2511         * DumpRenderTree/chromium/DRTTestRunner.h:
2512         (DRTTestRunner):
2513         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2514         (WebTestRunner::WebTestDelegate::display):
2515         (WebTestRunner::WebTestDelegate::displayInvalidatedRegion):
2516         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2517         (WebTestRunner::TestRunner::TestRunner):
2518         (WebTestRunner::TestRunner::display):
2519         (WebTestRunner):
2520         (WebTestRunner::TestRunner::displayInvalidatedRegion):
2521         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2522         (TestRunner):
2523         * DumpRenderTree/chromium/WebViewHost.cpp:
2524         (WebViewHost::display):
2525         (WebViewHost::displayInvalidatedRegion):
2526         * DumpRenderTree/chromium/WebViewHost.h:
2527
2528 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
2529
2530         [chromium] move speech related methods to TestRunner library
2531         https://bugs.webkit.org/show_bug.cgi?id=107266
2532
2533         Reviewed by Adam Barth.
2534
2535         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2536         (DRTTestRunner::DRTTestRunner):
2537         (DRTTestRunner::displayInvalidatedRegion):
2538         * DumpRenderTree/chromium/DRTTestRunner.h:
2539         (DRTTestRunner):
2540         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2541         (WebTestDelegate):
2542         (WebTestRunner::WebTestDelegate::addMockSpeechInputResult):
2543         (WebTestRunner::WebTestDelegate::setMockSpeechInputDumpRect):
2544         (WebTestRunner::WebTestDelegate::addMockSpeechRecognitionResult):
2545         (WebTestRunner::WebTestDelegate::setMockSpeechRecognitionError):
2546         (WebTestRunner::WebTestDelegate::wasMockSpeechRecognitionAborted):
2547         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2548         (WebTestRunner::TestRunner::TestRunner):
2549         (WebTestRunner):
2550         (WebTestRunner::TestRunner::addMockSpeechInputResult):
2551         (WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
2552         (WebTestRunner::TestRunner::addMockSpeechRecognitionResult):
2553         (WebTestRunner::TestRunner::setMockSpeechRecognitionError):
2554         (WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
2555         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2556         (TestRunner):
2557         * DumpRenderTree/chromium/WebViewHost.cpp:
2558         (WebViewHost::addMockSpeechInputResult):
2559         (WebViewHost::setMockSpeechInputDumpRect):
2560         (WebViewHost::addMockSpeechRecognitionResult):
2561         (WebViewHost::setMockSpeechRecognitionError):
2562         (WebViewHost::wasMockSpeechRecognitionAborted):
2563         * DumpRenderTree/chromium/WebViewHost.h:
2564
2565 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
2566
2567         [chromium] move notification related methods to TestRunner
2568         https://bugs.webkit.org/show_bug.cgi?id=107269
2569
2570         Reviewed by Adam Barth.
2571
2572         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2573         (DRTTestRunner::DRTTestRunner):
2574         * DumpRenderTree/chromium/DRTTestRunner.h:
2575         (DRTTestRunner):
2576         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2577         (WebTestDelegate):
2578         (WebTestRunner::WebTestDelegate::grantWebNotificationPermission):
2579         (WebTestRunner::WebTestDelegate::simulateLegacyWebNotificationClick):
2580         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2581         (WebTestRunner::TestRunner::TestRunner):
2582         (WebTestRunner):
2583         (WebTestRunner::TestRunner::grantWebNotificationPermission):
2584         (WebTestRunner::TestRunner::simulateLegacyWebNotificationClick):
2585         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2586         (TestRunner):
2587         * DumpRenderTree/chromium/WebViewHost.cpp:
2588         (WebViewHost::grantWebNotificationPermission):
2589         (WebViewHost::simulateLegacyWebNotificationClick):
2590         * DumpRenderTree/chromium/WebViewHost.h:
2591
2592 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
2593
2594         [chromium] move geolocation related methods to TestRunner
2595         https://bugs.webkit.org/show_bug.cgi?id=107267
2596
2597         Reviewed by Adam Barth.
2598
2599         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2600         (DRTTestRunner::DRTTestRunner):
2601         * DumpRenderTree/chromium/DRTTestRunner.h:
2602         (DRTTestRunner):
2603         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2604         (WebTestRunner::WebTestDelegate::numberOfPendingGeolocationPermissionRequests):
2605         (WebTestRunner::WebTestDelegate::setGeolocationPermission):
2606         (WebTestRunner::WebTestDelegate::setMockGeolocationPosition):
2607         (WebTestRunner::WebTestDelegate::setMockGeolocationPositionUnavailableError):
2608         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2609         (WebTestRunner::TestRunner::TestRunner):
2610         (WebTestRunner::TestRunner::numberOfPendingGeolocationPermissionRequests):
2611         (WebTestRunner):
2612         (WebTestRunner::TestRunner::setGeolocationPermission):
2613         (WebTestRunner::TestRunner::setMockGeolocationPosition):
2614         (WebTestRunner::TestRunner::setMockGeolocationPositionUnavailableError):
2615         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2616         (TestRunner):
2617         * DumpRenderTree/chromium/WebViewHost.cpp:
2618         (WebViewHost::numberOfPendingGeolocationPermissionRequests):
2619         (WebViewHost::setGeolocationPermission):
2620         (WebViewHost::setMockGeolocationPosition):
2621         (WebViewHost::setMockGeolocationPositionUnavailableError):
2622         * DumpRenderTree/chromium/WebViewHost.h:
2623
2624 2013-01-19  Zan Dobersek  <zdobersek@igalia.com>
2625
2626         Unreviewed build fix for Qt WK2 after r140258.
2627         Use the size_t type instead of unsigned for the variable
2628         which holds the position of the first null character in the
2629         console message.
2630
2631         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2632         (WTR::InjectedBundlePage::willAddMessageToConsole):
2633
2634 2013-01-19  Sheriff Bot  <webkit.review.bot@gmail.com>
2635
2636         Unreviewed, rolling out r140260.
2637         http://trac.webkit.org/changeset/140260
2638         https://bugs.webkit.org/show_bug.cgi?id=107387
2639
2640         breaks fast/text/hyphens.html, fast/text/hyphenate-* (but
2641         nothing else) (Requested by thakis__ on #webkit).
2642
2643         * Scripts/update-webkit-chromium:
2644
2645 2013-01-19  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2646
2647         Delegated scrolling: Assertion on attempt to show a CSS sticky element
2648         https://bugs.webkit.org/show_bug.cgi?id=106890
2649
2650         Reviewed by Kenneth Rohde Christiansen.
2651
2652         Enabled fixed layout mode in WTR for 'fast/css/sticky' tests.
2653
2654         * WebKitTestRunner/TestInvocation.cpp:
2655         (WTR::shouldUseFixedLayout):
2656         (WTR):
2657         (WTR::updateLayoutType):
2658
2659 2013-01-19  Nico Weber  <thakis@chromium.org>
2660
2661         Make ninja the default build system for build-webkit --chromium on mac
2662         https://bugs.webkit.org/show_bug.cgi?id=106737
2663
2664         Reviewed by Eric Seidel.
2665
2666         * Scripts/update-webkit-chromium:
2667
2668 2013-01-19  Zan Dobersek  <zdobersek@igalia.com>
2669
2670         [WK2] svg/dom/fuzz-path-parser.html is failing
2671         https://bugs.webkit.org/show_bug.cgi?id=107133
2672
2673         Reviewed by Alexey Proskuryakov.
2674
2675         Console messages can contain null characters before the end of string.
2676         Appending such message to the StringBuilder as a WTFString appends the
2677         complete string, including the null character. This later cuts off everything
2678         after the null character when the string is being printed out to the test
2679         output.
2680
2681         To avoid this, truncate the string up to the first null character. This
2682         preserves the newline character appended immediately after this and
2683         stops giving incorrect output.
2684
2685         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2686         (WTR::InjectedBundlePage::willAddMessageToConsole):
2687
2688 2013-01-19  Eric Seidel  <eric@webkit.org>
2689
2690         Update error regexps so that Parser/html-parser-srcdoc.html can "pass"
2691         https://bugs.webkit.org/show_bug.cgi?id=107367
2692
2693         Reviewed by Ryosuke Niwa.
2694
2695         Using srcdoc instead of document.write changes the error output
2696         ever so slightly.  Clearly we were already trying to ignore these
2697         messages, just not succeeding.  This change makes this new test "pass" correctly.
2698
2699         * Scripts/webkitpy/performance_tests/perftest.py:
2700         (PerfTest):
2701
2702 2013-01-18  Dan Winship  <danw@gnome.org>
2703
2704         REGRESSION (r139071): run-webkit-httpd complains at launch
2705         https://bugs.webkit.org/show_bug.cgi?id=107310
2706
2707         Reviewed by Alexey Proskuryakov.
2708
2709         * Scripts/webkitperl/httpd.pm:
2710         (getApacheVersion): use preferred perl syntax
2711
2712 2013-01-18  Julie Parent  <jparent@chromium.org>
2713
2714         Add back 'group' as a default cross dashboard parameter, but with null as its value.
2715         https://bugs.webkit.org/show_bug.cgi?id=107336
2716
2717         We need to have 'group' listed as a parameter, else we never parse it,
2718         as we only parse parameters with defaults.
2719         
2720         Reviewed by Ojan Vafai.
2721
2722         * TestResultServer/static-dashboards/dashboard_base.js:
2723
2724 2013-01-18  Emil A Eklund  <eae@chromium.org>
2725
2726         Update LayoutUnit rounding unit test
2727         https://bugs.webkit.org/show_bug.cgi?id=107322
2728
2729         Reviewed by Levi Weintraub.
2730         
2731         Update the LayoutUnitRounding test to use fromFloatRound for
2732         values that cannot accurately be represented as a LayoutUnit
2733         (the default behavior is to floor the value to the nearest
2734         LayoutUnit).
2735
2736         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
2737         (TestWebKitAPI::TEST):
2738
2739 2013-01-18  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2740
2741         VCSUtils.pm: Stop calling git repo-config.
2742         https://bugs.webkit.org/show_bug.cgi?id=107294
2743
2744         Reviewed by Dirk Pranke.
2745
2746         The `repo-config' git command has been deprecated since early
2747         2008, and recent versions have started warning it is deprecated.
2748
2749         Basically revert r27870 and use the `config' command all the time.
2750
2751         * Scripts/VCSUtils.pm:
2752         (gitConfig):
2753
2754 2013-01-18  Levi Weintraub  <leviw@chromium.org>
2755
2756         LayoutUnit should round half consistently, not away from zero
2757         https://bugs.webkit.org/show_bug.cgi?id=107208
2758
2759         Reviewed by Eric Seidel.
2760
2761         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp: Updating to reflect and
2762         cover this change in rounding behavior.
2763
2764 2013-01-18  Tim Horton  <timothy_horton@apple.com>
2765
2766         [mac] DumpRenderTree/WebKitTestRunner should not participate in Exposé/Mission Control
2767         https://bugs.webkit.org/show_bug.cgi?id=107234
2768
2769         Reviewed by Simon Fraser.
2770
2771         * DumpRenderTree/mac/DumpRenderTree.mm:
2772         (createWebViewAndOffscreenWindow): Disable participation in Exposé via NSWindowCollectionBehaviorStationary.
2773         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2774         (WTR::PlatformWebView::PlatformWebView): Ditto.
2775
2776 2013-01-18  Tim Horton  <timothy_horton@apple.com>
2777
2778         [mac] DumpRenderTree/WebKitTestRunner should disable NSBeep
2779         https://bugs.webkit.org/show_bug.cgi?id=107251
2780
2781         Reviewed by Simon Fraser.
2782
2783         Disable NSBeep in DumpRenderTree and WebKitTestRunner using NSSound SPI.
2784
2785         * DumpRenderTree/mac/DumpRenderTree.mm:
2786         (dumpRenderTree):
2787         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2788         (WTR::InjectedBundle::platformInitialize):
2789
2790 2013-01-18  Martin Robinson  <mrobinson@igalia.com>
2791
2792         [GTK] Enable indexed database for development builds
2793         https://bugs.webkit.org/show_bug.cgi?id=107299
2794
2795         Reviewed by Gustavo Noronha Silva.
2796
2797         * Scripts/webkitperl/FeatureList.pm: Enable indexed database by default
2798         for GTK+ development builds.
2799
2800 2013-01-18  Dominic Mazzoni  <dmazzoni@google.com>
2801
2802         AX: Improve table-guessing heuristics
2803         https://bugs.webkit.org/show_bug.cgi?id=107042
2804
2805         Reviewed by Chris Fleizach.
2806
2807         Implement parentElementCallback on Chromium to make testing easier.
2808
2809         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2810         (WebTestRunner::AccessibilityUIElement::parentElementCallback):
2811
2812 2013-01-18  Martin Robinson  <mrobinson@igalia.com>
2813
2814         [GTK] Add property for IndexedDB database path to WebKitGTK+
2815         https://bugs.webkit.org/show_bug.cgi?id=106136
2816
2817         Reviewed by Gustavo Noronha Silva.
2818
2819         During testing, set the web database directory to DUMPRENDERTREE_TEMP
2820         before falling back to the old default. This is necessary because
2821         indexed database tests require that each DRT shard is using a different
2822         IDB database location.
2823
2824         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2825         (temporaryDatabaseDirectory): Added this helper for getting the
2826         database directory.
2827         (setDefaultsToConsistentStateValuesForTesting): Use the new helper.
2828
2829 2013-01-18  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2830
2831         [EFL][WK2] Enable API test InjectedBundleFrameHitTest on EFL
2832         https://bugs.webkit.org/show_bug.cgi?id=107264
2833
2834         Reviewed by Laszlo Gombos.
2835
2836         Enable API test InjectedBundleFrameHitTest for hit-testing,
2837         since it is now passing on both Debug and Release builds.
2838
2839         * TestWebKitAPI/CMakeLists.txt:
2840         * TestWebKitAPI/PlatformEfl.cmake:
2841
2842 2013-01-18  Manuel Rego Casasnovas  <rego@igalia.com>
2843
2844         [GTK] Implement TestRunner::addUserScript
2845         https://bugs.webkit.org/show_bug.cgi?id=107275
2846
2847         Reviewed by Philippe Normand.
2848
2849         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2850         (TestRunner::addUserScript): Implement method using
2851         DumpRenderTreeSupportGtk::addUserScript.
2852
2853 2013-01-18  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2854
2855         Unreviewed, add my secondary email address to the list.
2856
2857         * Scripts/webkitpy/common/config/committers.py:
2858
2859 2013-01-18  Dan Carney  <dcarney@google.com>
2860
2861         [chromium] move pointerlock functions to TestRunner library
2862         https://bugs.webkit.org/show_bug.cgi?id=107241
2863
2864         Reviewed by Jochen Eisinger.
2865
2866         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2867         (DRTTestRunner::DRTTestRunner):
2868         * DumpRenderTree/chromium/DRTTestRunner.h:
2869         (DRTTestRunner):
2870         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2871         (WebTestRunner::WebTestDelegate::didAcquirePointerLock):
2872         (WebTestRunner::WebTestDelegate::didNotAcquirePointerLock):
2873         (WebTestRunner::WebTestDelegate::didLosePointerLock):
2874         (WebTestRunner::WebTestDelegate::setPointerLockWillRespondAsynchronously):
2875         (WebTestRunner::WebTestDelegate::setPointerLockWillFailSynchronously):
2876         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2877         (WebTestRunner::TestRunner::TestRunner):
2878         (WebTestRunner):
2879         (WebTestRunner::TestRunner::didAcquirePointerLock):
2880         (WebTestRunner::TestRunner::didNotAcquirePointerLock):
2881         (WebTestRunner::TestRunner::didLosePointerLock):
2882         (WebTestRunner::TestRunner::setPointerLockWillRespondAsynchronously):
2883         (WebTestRunner::TestRunner::setPointerLockWillFailSynchronously):
2884         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2885         (TestRunner):
2886         * DumpRenderTree/chromium/WebViewHost.h:
2887         (WebViewHost):
2888
2889 2013-01-14  Dominik Röttsches  <dominik.rottsches@intel.com>
2890
2891         [EFL] Update freetype in jhbuild to 2.4.11 and activate subpixel layout
2892         https://bugs.webkit.org/show_bug.cgi?id=106774
2893
2894         Reviewed by Martin Robinson.
2895
2896         In order to fix a long standing linespacing/font ascent & descent issue
2897         we found that FreeType commit b0962ac34e660 solves that problem.
2898         Let's update FreeType accordingly, but bump it to 2.4.11 due to the
2899         maintainer recommending several security updates after that said commit.
2900
2901         Also, in order to avoid extra rebaselining, let's activate subpixel
2902         layout at the same time.
2903
2904         * efl/jhbuild.modules: New freetype 2.4.11
2905
2906 2013-01-17  Xiaobo Wang  <xbwang@torchmobile.com.cn>
2907
2908         [BlackBerry] DRT - Accept http/file URL when running drt-launcher from command line
2909         https://bugs.webkit.org/show_bug.cgi?id=107107
2910         PR 282192
2911
2912         Reviewed by Rob Buis.
2913
2914         The DRT application will convert relative/absolute file path to
2915         file://<real-file-path> format, so we only check for http/file prefix.
2916
2917         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2918         (BlackBerry::WebKit::isFullUrl):
2919         (WebKit):
2920         (BlackBerry::WebKit::DumpRenderTree::runCurrentTest):
2921
2922 2013-01-17  Frank Farzan  <frankf@chromium.org>
2923
2924         Flakiness dashboard: Add ChromiumFYI master
2925         https://bugs.webkit.org/show_bug.cgi?id=107180
2926
2927         Reviewed by Ojan Vafai.
2928
2929         This is needed to enable Chrome Android bots
2930         to upload results for instrumentation tests.
2931
2932         * TestResultServer/generate_builders_json.py:
2933         (main):
2934         * TestResultServer/static-dashboards/builders.jsonp:
2935
2936 2013-01-17  Frank Farzan  <frankf@chromium.org>
2937
2938         Add Chrome on Android instrumentation test types to flakiness dashboard
2939         https://bugs.webkit.org/show_bug.cgi?id=106964
2940
2941         Reviewed by Ojan Vafai.
2942
2943         Specifically, add these test types:
2944         
2945          androidwebview_instrumentation_tests
2946          chromiumtestshell_instrumentation_tests
2947          contentshell_instrumentation_tests
2948         
2949         Also, add ChromiumFYI to the list of masters.
2950
2951         * TestResultServer/static-dashboards/builders.js:
2952         (loadBuildersList):
2953         * TestResultServer/static-dashboards/dashboard_base.js:
2954         (currentBuilderGroupCategory):
2955
2956 2013-01-17  Tim 'mithro' Ansell  <mithro@mithis.com>
2957
2958         Fixing webkitpy's SCM unit tests.
2959         https://bugs.webkit.org/show_bug.cgi?id=106429
2960
2961         Reviewed by Eric Seidel.
2962
2963         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
2964         (SCMDetectorTest.test_detect_scm_system):
2965         * Scripts/webkitpy/common/checkout/scm/git.py:
2966         (Git.in_working_directory):
2967         (Git.read_git_config):
2968         (Git._assert_can_squash):
2969         (Git.remote_branch_ref):
2970         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2971         (GitSVNTest.test_commit_with_message_multiple_local_commits_always_squash):
2972         (GitTestWithMock):
2973         (GitTestWithMock.make_scm):
2974         (GitTestWithMock.test_create_patch):
2975         * Scripts/webkitpy/common/system/outputcapture.py:
2976         (OutputCapture.assert_outputs):
2977         (OutputCaptureTestCaseBase):
2978         * Scripts/webkitpy/test/printer.py:
2979         (Printer.configure):
2980
2981 2013-01-17  Julie Parent  <jparent@chromium.org>
2982
2983         Flakiness dashboard assumes there must be ToT tests
2984         https://bugs.webkit.org/show_bug.cgi?id=107155
2985
2986         Remove group as a default parameter, since we can't actually know
2987         the name of a group initially.  Instead, introduces 
2988         currentBuilderGroupName which returns the current builder group
2989         if it has been explicitly set, or picks the first one available
2990         as a default. Allows us to remove some extra code tracking this
2991         stuff as well.
2992         
2993         Reviewed by Ojan Vafai.
2994
2995         * TestResultServer/static-dashboards/dashboard_base.js:
2996         (parseCrossDashboardParameters):
2997         (currentBuilderGroupName):
2998         (currentBuilderGroup):
2999         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3000         (platformAndBuildType):
3001         * TestResultServer/static-dashboards/loader.js:
3002         (.):
3003
3004 2013-01-16  Ryosuke Niwa  <rniwa@webkit.org>
3005
3006         Remove NodeListsNodeData when it's no longer needed
3007         https://bugs.webkit.org/show_bug.cgi?id=107074
3008
3009         Reviewed by Darin Adler.
3010
3011         Generalize the warning a little so that it's also ignored on PerformanceTests/DOM/TraverseChildNodes.html
3012
3013         * Scripts/webkitpy/performance_tests/perftest.py:
3014         (PerfTest):
3015
3016 2013-01-17  Simon Fraser  <simon.fraser@apple.com>
3017
3018         Ref test images are upside-down in WebKit2
3019         https://bugs.webkit.org/show_bug.cgi?id=105457
3020
3021         Reviewed by Sam "Speedy" Weinig.
3022         
3023         The bitmap context created in TestInvocation::dumpPixelsAndCompareWithExpected()
3024         from the window snapshot contained a flipped copy of the image, causing all ref
3025         and pixel images to be upside-down.
3026
3027         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3028         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3029
3030 2013-01-17  Timothy Loh  <timloh@google.com>
3031
3032         Replaced specifiers variable with is_debug in builders.py
3033         https://bugs.webkit.org/show_bug.cgi?id=107057
3034
3035         Reviewed by Dirk Pranke.
3036
3037         Replaced specifiers variable with is_debug in builders.py to simplify
3038         Bug 106259. The other specifiers are not used elsewhere in the code.
3039         Fixed builder_name_for_port_name to return a debug builder if we don't
3040         have a release builder.
3041
3042         * Scripts/webkitpy/layout_tests/port/builders.py:
3043         (all_port_names):
3044         (builder_name_for_port_name):
3045         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3046         (TestRebaselineExpectations.test_rebaseline_expectations):
3047
3048 2013-01-17  Martin Robinson  <mrobinson@igalia.com>
3049
3050         [GTK] Build with LevelDB when IndexedDB is enabled
3051         https://bugs.webkit.org/show_bug.cgi?id=103220
3052
3053         Reviewed by Gustavo Noronha Silva.
3054
3055         * Scripts/webkitpy/style/checker.py: Do not style check the leveldb source code
3056         as it does not conform to WebKit style.
3057
3058 2013-01-17  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
3059
3060         [EFL][WK2] Fix misuse of ASSERT on ecore_evas_init()
3061         https://bugs.webkit.org/show_bug.cgi?id=107119
3062
3063         Reviewed by Laszlo Gombos.
3064
3065         Do not use ASSERT on ecore_evas_init(), since the expression inside
3066         the macro compiles out of release builds.
3067
3068         * TestWebKitAPI/PlatformEfl.cmake: Enable API test UserMessage.
3069         * TestWebKitAPI/efl/PlatformWebView.cpp:
3070         (TestWebKitAPI::initEcoreEvas): Remove ASSERT on ecore_evas_init().
3071
3072 2013-01-17  Eugene Klyuchnikov  <eustas@chromium.org>
3073
3074         Web Inspector: Profiler: split "getProfile" to "getCPUProfile" and "loadHeapSnapshot"
3075         https://bugs.webkit.org/show_bug.cgi?id=104545
3076
3077         Reviewed by Yury Semikhatsky.
3078
3079         Adopt signature changes.
3080
3081         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
3082         (ProfilerAgent.getCPUProfile): Renamed.
3083         (ProfilerAgent.getHeapSnapshot): Added.
3084
3085 2013-01-17  Zan Dobersek  <zdobersek@igalia.com>
3086
3087         [GTK][EFL] NWRT should check that Xvfb is installed
3088         https://bugs.webkit.org/show_bug.cgi?id=71767
3089
3090         Reviewed by Dirk Pranke.
3091
3092         EFL and GTK ports now check that Xvfb is installed before running
3093         layout tests. The command line used to check whether Xvfb is present
3094         is a simple `which Xvfb` that should return 0 as the exit code upon
3095         success.
3096
3097         * Scripts/webkitpy/layout_tests/port/efl.py:
3098         (EflPort.show_results_html_file):
3099         (EflPort):
3100         (EflPort.check_sys_deps):
3101         * Scripts/webkitpy/layout_tests/port/gtk.py:
3102         (GtkPort.check_sys_deps):
3103         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
3104         (XvfbDriver):
3105         (XvfbDriver.check_xvfb):
3106
3107 2013-01-16  Alan Cutter  <alancutter@chromium.org>
3108
3109         sheriffbot can't tell me who "kov" is
3110         https://bugs.webkit.org/show_bug.cgi?id=106184
3111
3112         Reviewed by Eric Seidel.
3113
3114         Added glob style searching to the CommitterList contributors_by_search_string function so exact matches are favoured.
3115
3116         * Scripts/webkitpy/common/config/committers.py:
3117         (Account.matches_glob):
3118         (CommitterList.contributors_by_search_string):
3119         * Scripts/webkitpy/common/config/committers_unittest.py:
3120         (CommittersTest.test_committer_lookup):
3121         * Scripts/webkitpy/tool/bot/irc_command.py:
3122         (Whois):
3123
3124 2013-01-16  David Kilzer  <ddkilzer@apple.com>
3125
3126         Use xcrun to find path to make for Mac port
3127         <http://webkit.org/b/107091>
3128
3129         Reviewed by Dan Bernstein.
3130
3131         * Scripts/webkitpy/layout_tests/port/mac.py:
3132         (MacPort._build_java_test_support): Call self.make_command().
3133         (MacPort.make_command): Add.  Call xcrun_find().
3134         (MacPort.nm_command): Use self.xcrun_find().
3135         (MacPort.xcrun_find): Add.  Extract from nm_command().
3136
3137 2013-01-16  Sam Weinig  <sam@webkit.org>
3138
3139         Make debug-safari --target-web-process work again
3140         https://bugs.webkit.org/show_bug.cgi?id=107088
3141
3142         Reviewed by Anders Carlsson.
3143
3144         * Scripts/webkitdirs.pm:
3145         (execMacWebKitAppForDebugging):
3146         The shim is now called SecItemShim.
3147
3148 2013-01-16  Alan Cutter  <alancutter@chromium.org>
3149
3150         GCE build scripts don't take working directory into account when calling findzone.sh
3151         https://bugs.webkit.org/show_bug.cgi?id=106962
3152
3153         Reviewed by Adam Barth.
3154
3155         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
3156         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
3157         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
3158
3159 2013-01-16  Alan Cutter  <alancutter@chromium.org>
3160
3161         start-queue.sh does not pass remaining parameters correctly
3162         https://bugs.webkit.org/show_bug.cgi?id=107054
3163
3164         Reviewed by Adam Barth.
3165
3166         start-queue.sh now passes all remaining params to the webkit-patch command.
3167         Previously only one additional queue parameter could be sent.
3168
3169         * EWSTools/start-queue.sh:
3170
3171 2013-01-16  Xueqing Huang  <huangxueqing@baidu.com>
3172
3173         check-webkit-style script cannot running in Chinese windows.
3174         https://bugs.webkit.org/show_bug.cgi?id=87548
3175
3176         Reviewed by Darin Adler.
3177
3178         * Scripts/webkitpy/common/system/platforminfo.py:
3179         (PlatformInfo._win_version_tuple_from_cmd):
3180
3181 2013-01-16  Dirk Pranke  <dpranke@chromium.org>
3182
3183         Delete an extraneous print statement.
3184         https://bugs.webkit.org/show_bug.cgi?id=106562
3185
3186         Delete the extraneous print statement introduced in r139841.
3187
3188         * Scripts/webkitpy/layout_tests/views/printing.py:
3189         (Printer.print_found):
3190
3191 2013-01-16  Zan Dobersek  <zdobersek@igalia.com>
3192
3193         Please reinstate --pixel
3194         https://bugs.webkit.org/show_bug.cgi?id=101995
3195
3196         Reviewed by Dirk Pranke.
3197
3198         Add the '--pixel' and '--no-pixel' options for NRWT as aliases for
3199         the '--pixel-tests' (or '-p') and '--no-pixel-tests' options respectively.
3200         Some developers are still used to these options that were available in the ORWT.
3201
3202         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3203         (parse_args):
3204
3205 2013-01-16  Eric Seidel  <eric@webkit.org>
3206
3207         Remove --shark* support from sunspider/run-sunspider now that Shark is dead
3208         https://bugs.webkit.org/show_bug.cgi?id=99512
3209
3210         Reviewed by Darin Adler.
3211
3212         * Scripts/run-sunspider:
3213
3214 2013-01-16  Eric Seidel  <eric@webkit.org>
3215
3216         Remove webkitpy Visual Studio files, as core developers are not interested in maintaining them
3217         https://bugs.webkit.org/show_bug.cgi?id=106036
3218
3219         Reviewed by Darin Adler.
3220
3221         * Scripts/webkitpy/webkitpy.pyproj: Removed.
3222         * Scripts/webkitpy/webkitpy.sln: Removed.
3223
3224 2013-01-16  Chris Hopman  <cjhopman@chromium.org>
3225
3226         [Chromium] Remove hardcoded chromium_*.jar in gyp files
3227         https://bugs.webkit.org/show_bug.cgi?id=104049
3228
3229         Reviewed by Eric Seidel.
3230
3231         Targets with dependencies (direct/indirect) on a java target receive
3232         the chromium_*.jar paths in the variable input_jars_paths. Targets
3233         should use that rather than hardcoding where they think the jar will
3234         be. These can be passed directly to ant as INPUT_JARS_PATHS rather
3235         than as --jars to generate_native_test.py.
3236
3237         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3238         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3239
3240 2013-01-16  Dan Carney  <dcarney@google.com>
3241
3242         [chromium] move setMockDeviceOrientation to TestRunner library
3243         https://bugs.webkit.org/show_bug.cgi?id=106895
3244
3245         Reviewed by Jochen Eisinger.
3246
3247         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3248         (DRTTestRunner::DRTTestRunner):
3249         * DumpRenderTree/chromium/DRTTestRunner.h:
3250         (DRTTestRunner):
3251         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3252         (WebKit):
3253         (WebTestRunner::WebTestDelegate::setDeviceOrientation):
3254         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3255         (WebTestRunner::TestRunner::TestRunner):
3256         (WebTestRunner::TestRunner::setMockDeviceOrientation):
3257         (WebTestRunner):
3258         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3259         (TestRunner):
3260         * DumpRenderTree/chromium/WebViewHost.cpp:
3261         (WebViewHost::setDeviceOrientation):
3262         * DumpRenderTree/chromium/WebViewHost.h:
3263         (WebViewHost):
3264
3265 2013-01-16  Jochen Eisinger  <jochen@chromium.org>
3266
3267         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
3268         https://bugs.webkit.org/show_bug.cgi?id=106904
3269
3270         Reviewed by Adam Barth.
3271
3272         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3273         (DRTTestRunner::DRTTestRunner):
3274         (DRTTestRunner::notifyDone):
3275         (DRTTestRunner::reset):
3276         * DumpRenderTree/chromium/DRTTestRunner.h:
3277         (DRTTestRunner):
3278         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3279         (WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
3280         (WebTestRunner::WebTestDelegate::setFocus):
3281         (WebTestRunner::WebTestDelegate::setAcceptAllCookies):
3282         (WebTestRunner::WebTestDelegate::pathToLocalResource):
3283         (WebTestRunner::WebTestDelegate::setLocale):
3284         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3285         (WebTestRunner::TestRunner::TestRunner):
3286         (WebTestRunner::TestRunner::reset):
3287         (WebTestRunner::TestRunner::setAlwaysAcceptCookies):
3288         (WebTestRunner):
3289         (WebTestRunner::TestRunner::setWindowIsKey):
3290         (WebTestRunner::TestRunner::pathToLocalResource):
3291         (WebTestRunner::TestRunner::setBackingScaleFactor):
3292         (WebTestRunner::TestRunner::setPOSIXLocale):
3293         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3294         (WebTestRunner::TestRunner::taskList):
3295         (TestRunner):
3296         * DumpRenderTree/chromium/WebViewHost.cpp:
3297         (WebViewHost::setDeviceScaleFactor):
3298         (WebViewHost::setFocus):
3299         (WebViewHost::setAcceptAllCookies):
3300         (WebViewHost::pathToLocalResource):
3301         (WebViewHost::setLocale):
3302         * DumpRenderTree/chromium/WebViewHost.h:
3303         (WebViewHost):
3304
3305 2013-01-16  Sergio Villar Senin  <svillar@igalia.com>
3306
3307         [GTK] build-webkit fails if the jhbuild wrapper is not used
3308         https://bugs.webkit.org/show_bug.cgi?id=106769
3309
3310         Reviewed by Martin Robinson.
3311
3312         Return an empty array instead of "" in
3313         jhbuildWrapperPrefixIfNeeded() because otherwise that empty string
3314         will not be recognized as a valid command when the returned array
3315         is directly passed to perl's system() call.
3316
3317         * Scripts/webkitdirs.pm:
3318         (jhbuildWrapperPrefixIfNeeded):
3319
3320 2013-01-16  Jochen Eisinger  <jochen@chromium.org>
3321
3322         [chromium] add title text direction attribute to TestRunner
3323         https://bugs.webkit.org/show_bug.cgi?id=106907
3324
3325         Reviewed by Adam Barth.
3326
3327         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3328         (DRTTestRunner::DRTTestRunner):
3329         (DRTTestRunner::reset):
3330         * DumpRenderTree/chromium/DRTTestRunner.h:
3331         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3332         (WebTestRunner::WebTestRunner::setTitleTextDirection):
3333         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3334         (WebTestRunner::TestRunner::TestRunner):
3335         (WebTestRunner::TestRunner::reset):
3336         (WebTestRunner::TestRunner::setTitleTextDirection):
3337         (WebTestRunner):
3338         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3339         (TestRunner):
3340         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3341         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
3342         * DumpRenderTree/chromium/WebViewHost.cpp:
3343         (WebViewHost::didReceiveTitle):
3344
3345 2013-01-16  Jussi Kukkonen  <jussi.kukkonen@intel.com>
3346
3347         NRWT still confused about test count with --repeat-each and --iterations
3348         https://bugs.webkit.org/show_bug.cgi?id=106562
3349
3350         Reviewed by Dirk Pranke.
3351
3352         Fix the printed unique test count and skipped count. This
3353         seems to have broken in r127688 ("NRWT lies about the number
3354         of tests that it's skipping when used with --repeat-each").
3355
3356         Also add a test for print_found()
3357
3358         * Scripts/webkitpy/layout_tests/views/printing.py:
3359         (Printer.print_found):
3360         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3361         (Testprinter.test_details):
3362         (Testprinter):
3363         (Testprinter.test_found):
3364
3365 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
3366
3367         Unreviewed follow-up to r139769.
3368
3369         Note that omitting the WebKit1 code from the build now
3370         works for GTK as well.
3371
3372         * Scripts/build-webkit:
3373
3374 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
3375
3376         test-webkitpy: truncate output to the terminal width when necessary
3377         https://bugs.webkit.org/show_bug.cgi?id=106973
3378
3379         Reviewed by Ojan Vafai.
3380
3381         this implements the same logic for test-webkitpy that we have
3382         for run-webkit-tests (and ninja).
3383
3384         No tests written as this is exercised by running test-webkitpy itself.
3385
3386         * Scripts/webkitpy/test/printer.py:
3387         (Printer.configure):
3388         (Printer._test_line):
3389
3390 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
3391
3392         remove extraneous output in test-webkitpy
3393         https://bugs.webkit.org/show_bug.cgi?id=106971
3394
3395         Reviewed by Ojan Vafai.
3396
3397         We weren't ignoring or capturing the echoed output from
3398         these two tests, and getting noise in the logs as a result.
3399
3400         * Scripts/webkitpy/common/system/executive_unittest.py:
3401         (ExecutiveTest.test_auto_stringify_args):
3402         (ExecutiveTest.test_popen_args):
3403
3404 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
3405
3406         webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer.test_win32_start_and_stop is flaky
3407         https://bugs.webkit.org/show_bug.cgi?id=106974
3408
3409         Reviewed by Ryosuke Niwa.
3410
3411         I forgot to stub out the call to check to ensure that the ports were
3412         available, so this test could fail if something was listening on 8000 or
3413         8443 on the machine.
3414
3415         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
3416         (TestHttpServer.test_win32_start_and_stop):
3417
3418 2013-01-15  Levi Weintraub  <leviw@chromium.org>
3419
3420         Unreviewed, rolling out r139792.
3421         http://trac.webkit.org/changeset/139792
3422         https://bugs.webkit.org/show_bug.cgi?id=106970
3423
3424         Broke the windows build.
3425
3426         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3427         (DRTTestRunner::DRTTestRunner):
3428         (DRTTestRunner::notifyDone):
3429         (DRTTestRunner::reset):
3430         (DRTTestRunner::setAlwaysAcceptCookies):
3431         (DRTTestRunner::setWindowIsKey):
3432         (DRTTestRunner::pathToLocalResource):
3433         (DRTTestRunner::setPOSIXLocale):
3434         (InvokeCallbackTask):
3435         (InvokeCallbackTask::InvokeCallbackTask):
3436         (InvokeCallbackTask::runIfValid):
3437         (DRTTestRunner::setBackingScaleFactor):
3438         * DumpRenderTree/chromium/DRTTestRunner.h:
3439         (DRTTestRunner):
3440         (DRTTestRunner::taskList):
3441         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3442         (WebTestRunner::WebTestDelegate::setDatabaseQuota):
3443         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3444         (WebTestRunner::TestRunner::TestRunner):
3445         (WebTestRunner::TestRunner::reset):
3446         (WebTestRunner::TestRunner::setDatabaseQuota):
3447         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3448         (TestRunner):
3449         * DumpRenderTree/chromium/WebViewHost.cpp:
3450         (WebViewHost::setPendingExtraData):
3451         (WebViewHost::setDeviceScaleFactor):
3452         * DumpRenderTree/chromium/WebViewHost.h:
3453         (WebViewHost):
3454
3455 2013-01-15  Ryosuke Niwa  <rniwa@webkit.org>
3456
3457         Build fix after r139357. The port name of MacWK2EWS should be 'mac-wk2'.
3458
3459         * Scripts/webkitpy/common/config/ports.py:
3460         (MacWK2Port):
3461
3462 2013-01-15  Alan Cutter  <alancutter@chromium.org>
3463
3464         Extend sheriffbot's "help" command to be able to get help on individual commands
3465         https://bugs.webkit.org/show_bug.cgi?id=106629
3466
3467         Reviewed by Eric Seidel.
3468
3469         Added a help command to sheriffbot.
3470         Fixed some style issues and ordered the commands alphabetically.
3471
3472         * Scripts/webkitpy/tool/bot/irc_command.py:
3473         (IRCCommand):
3474         (IRCCommand.execute):
3475         (IRCCommand.usage):
3476         (IRCCommand.help):
3477         (CreateBug):
3478         (CreateBug.execute):
3479         (Help):
3480         (Help.execute):
3481         (Help._post_command_help):
3482         (Hi):
3483         (Hi.execute):
3484         (Restart):
3485         (RollChromiumDEPS):
3486         (RollChromiumDEPS._parse_args):
3487         (RollChromiumDEPS._expand_irc_nickname):
3488         (RollChromiumDEPS.execute):
3489         (Rollout):
3490         (Rollout._extract_revisions):
3491         (Rollout.execute):
3492         (Sheriffs):
3493         (Sheriffs.execute):
3494         (Whois):
3495         (Whois.execute):
3496         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
3497         (IRCBotTest.test_help):
3498
3499 2013-01-15  Enrica Casucci  <enrica@apple.com>
3500
3501         Add a new set of WebKit2 APIs for text search and
3502         search results management.
3503         https://bugs.webkit.org/show_bug.cgi?id=106834.
3504         <rdar://problem/12597159>
3505
3506         Added new test for the new WebKit2 API for
3507         text search.
3508         
3509         Reviewed by Simon Fraser.
3510
3511         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3512         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm: Added.
3513
3514 2013-01-15  Levi Weintraub  <leviw@chromium.org>
3515
3516         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
3517         https://bugs.webkit.org/show_bug.cgi?id=106904
3518
3519         Reverting 139794. It broke the build. It appears that a header file,
3520         WebTextDirection.h, was left out.
3521
3522         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3523         (DRTTestRunner::DRTTestRunner):
3524         (DRTTestRunner::reset):
3525         * DumpRenderTree/chromium/DRTTestRunner.h:
3526         (DRTTestRunner::setTitleTextDirection):
3527         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3528         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
3529         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3530         (WebTestRunner::TestRunner::TestRunner):
3531         (WebTestRunner::TestRunner::reset):
3532         (WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
3533         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3534         (TestRunner):
3535         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3536         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
3537         * DumpRenderTree/chromium/WebViewHost.cpp:
3538         (WebViewHost::didReceiveTitle):
3539
3540 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
3541
3542         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
3543         https://bugs.webkit.org/show_bug.cgi?id=106904
3544
3545         Reviewed by Adam Barth.
3546
3547         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3548         (DRTTestRunner::DRTTestRunner):
3549         (DRTTestRunner::notifyDone):
3550         (DRTTestRunner::reset):
3551         * DumpRenderTree/chromium/DRTTestRunner.h:
3552         (DRTTestRunner):
3553         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3554         (WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
3555         (WebTestRunner::WebTestDelegate::setFocus):
3556         (WebTestRunner::WebTestDelegate::setAcceptAllCookies):
3557         (WebTestRunner::WebTestDelegate::pathToLocalResource):
3558         (WebTestRunner::WebTestDelegate::setLocale):
3559         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3560         (WebTestRunner::TestRunner::TestRunner):
3561         (WebTestRunner::TestRunner::reset):
3562         (WebTestRunner::TestRunner::setAlwaysAcceptCookies):
3563         (WebTestRunner):
3564         (WebTestRunner::TestRunner::setWindowIsKey):
3565         (WebTestRunner::TestRunner::pathToLocalResource):
3566         (WebTestRunner::TestRunner::setBackingScaleFactor):
3567         (WebTestRunner::TestRunner::setPOSIXLocale):
3568         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3569         (WebTestRunner::TestRunner::taskList):
3570         (TestRunner):
3571         * DumpRenderTree/chromium/WebViewHost.cpp:
3572         (WebViewHost::setDeviceScaleFactor):
3573         (WebViewHost::setFocus):
3574         (WebViewHost::setAcceptAllCookies):
3575         (WebViewHost::pathToLocalResource):
3576         (WebViewHost::setLocale):
3577         * DumpRenderTree/chromium/WebViewHost.h:
3578         (WebViewHost):
3579
3580 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
3581
3582         Tests with WontFix expectation are (indirectly) skipped
3583         https://bugs.webkit.org/show_bug.cgi?id=105860
3584
3585         Reviewed by Dirk Pranke.
3586
3587         Only skip the WontFix expectation if there are no other layout test
3588         expectations (like Failure, ImageOnlyFailure) listed for the test.
3589         This makes it possible to run an expected failure for which there
3590         is no reason or interest to fix. There are some ports that would like
3591         to exercise this behavior as well as specific test cases that should use
3592         such expectations.
3593
3594         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3595         (TestExpectationParser._tokenize_line): Only add the SKIP modifier for a
3596         WONTFIX test if there are no expectations listed. The warning is adjusted
3597         to reflect the new behavior.
3598         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Add
3599         and adjust test cases for these changes.
3600         (ExpectationSyntaxTests.test_wontfix):
3601         (SemanticTests.test_skip_and_wontfix):
3602
3603 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
3604
3605         [chromium] add title text direction attribute to TestRunner
3606         https://bugs.webkit.org/show_bug.cgi?id=106907
3607
3608         Reviewed by Adam Barth.
3609
3610         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3611         (DRTTestRunner::DRTTestRunner):
3612         (DRTTestRunner::reset):
3613         * DumpRenderTree/chromium/DRTTestRunner.h:
3614         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3615         (WebTestRunner::WebTestRunner::setTitleTextDirection):
3616         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3617         (WebTestRunner::TestRunner::TestRunner):
3618         (WebTestRunner::TestRunner::reset):
3619         (WebTestRunner::TestRunner::setTitleTextDirection):
3620         (WebTestRunner):
3621         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3622         (TestRunner):
3623         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3624         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
3625         * DumpRenderTree/chromium/WebViewHost.cpp:
3626         (WebViewHost::didReceiveTitle):
3627
3628 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
3629
3630         nrwt: change the default # of locked shards on chromium_win to 1
3631         https://bugs.webkit.org/show_bug.cgi?id=106938
3632
3633         Reviewed by Eric Seidel.
3634
3635         It looks like LigHTTPd might be buggy or unstable if we are
3636         running multiple http tests in parallel; see
3637         http://code.google.com/p/chromium/issues/detail?id=169530 for more
3638         context as well. This change will stop running http tests in parallel
3639         and we can see if this fixes things.
3640
3641         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3642         (ChromiumWinPort.default_max_locked_shards):
3643         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3644         (ChromiumWinTest.test_path_to_image_diff):
3645         (ChromiumWinTest):
3646         (ChromiumWinTest.test_default_max_locked_shards):
3647
3648 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
3649
3650         [chromium] move WebDatabase related methods to TestRunner library
3651         https://bugs.webkit.org/show_bug.cgi?id=106905
3652
3653         Reviewed by Adam Barth.
3654
3655         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3656         (DRTTestRunner::DRTTestRunner):
3657         (DRTTestRunner::reset):
3658         * DumpRenderTree/chromium/DRTTestRunner.h:
3659         (DRTTestRunner):
3660         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3661         (WebTestRunner::WebTestDelegate::clearAllDatabases):
3662         (WebTestRunner::WebTestDelegate::setDatabaseQuota):
3663         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3664         (WebTestRunner::TestRunner::TestRunner):
3665         (WebTestRunner::TestRunner::reset):
3666         (WebTestRunner::TestRunner::clearAllDatabases):
3667         (WebTestRunner):
3668         (WebTestRunner::TestRunner::setDatabaseQuota):
3669         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3670         (TestRunner):
3671         * DumpRenderTree/chromium/WebViewHost.cpp:
3672         (WebViewHost::clearAllDatabases):
3673         (WebViewHost::setDatabaseQuota):
3674         * DumpRenderTree/chromium/WebViewHost.h:
3675         (WebViewHost):
3676
3677 2013-01-15  Tim 'mithro' Ansell  <mithro@mithis.com>
3678
3679         Renaming CleanWorkingDirectory step to DiscardLocalChanges to make
3680         functionality match the name.
3681         https://bugs.webkit.org/show_bug.cgi?id=106870
3682
3683         Reviewed by Adam Barth.
3684
3685         * Scripts/webkitpy/tool/commands/download.py:
3686         (Clean):
3687         (Update):
3688         (Build):
3689         (BuildAndTest):
3690         (CheckStyle):
3691         (BuildAttachment):
3692         (BuildAndTestAttachment):
3693         (AbstractPatchApplyingCommand):
3694         (ApplyWatchList):
3695         (AbstractPatchLandingCommand):
3696         (CreateRollout):
3697         * Scripts/webkitpy/tool/steps/__init__.py:
3698         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
3699         (CleanWorkingDirectory.options):
3700         (CleanWorkingDirectory.run):
3701         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
3702         * Scripts/webkitpy/tool/steps/discardlocalchanges.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
3703         * Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py.
3704
3705 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
3706
3707         [Autotools] Add support for WebKit2-only builds
3708         https://bugs.webkit.org/show_bug.cgi?id=106889
3709
3710         Reviewed by Gustavo Noronha Silva.
3711
3712         * GNUmakefile.am: Only build the GtkLauncher and DumpRenderTree if building WebKit1.
3713         * Scripts/build-webkit: Pass along the information on whether to build WebKit1 when
3714         building the GTK port through build-webkit.
3715         * Scripts/webkitdirs.pm:
3716         (buildAutotoolsProject): Add the --disable-webkit1 configuration flag to the build
3717         arguments when not building WebKit1.
3718         (buildGtkProject): Pass along the information on whether to build WebKit1 when building
3719         through the Autotools build system.
3720
3721 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
3722
3723         [GTK] Enable Performance Timeline, Resource Timing, Navigation Timing features
3724         https://bugs.webkit.org/show_bug.cgi?id=106197
3725
3726         Reviewed by Martin Robinson.
3727
3728         * Scripts/webkitperl/FeatureList.pm: Add the configuration options for all three
3729         features. Enable them on GTK, meaning they will be enabled in development builds
3730         (i.e. when building with build-webkit).
3731
3732 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
3733
3734         [GTK] Enable CSS Image Resolution feature
3735         https://bugs.webkit.org/show_bug.cgi?id=99038
3736
3737         Reviewed by Gustavo Noronha Silva.
3738
3739         Enable the CSS Image Resolution feature for the development
3740         builds of the GTK port.
3741
3742         * Scripts/webkitperl/FeatureList.pm:
3743
3744 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
3745
3746         [GTK] Stop passing the unstable features flag to configure script when using build-webkit
3747         https://bugs.webkit.org/show_bug.cgi?id=106579
3748
3749         Reviewed by Gustavo Noronha Silva.
3750
3751         The --enable-unstable-features flag is not required to be passed anymore
3752         to the configure script as it was removed in r138252.
3753
3754         * Scripts/webkitdirs.pm:
3755         (buildAutotoolsProject):
3756
3757 2013-01-15  Tony Chang  <tony@chromium.org>
3758
3759         [chromium] Unreviewed, fix a bug where we don't properly shutdown lighttpd.
3760
3761         * Scripts/webkitpy/layout_tests/servers/http_server.py:
3762         (Lighttpd._check_and_kill): Pass /pid so taskkill.exe doesn't error out on us.
3763         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
3764         (TestHttpServer.test_win32_start_and_stop):
3765
3766 2013-01-15  Joshua Bell  <jsbell@chromium.org>
3767
3768         Unreviewed. Adding Michael Pruett as contributor.
3769
3770         * Scripts/webkitpy/common/config/committers.py:
3771
3772 2013-01-15  Victor Carbune  <victor@rosedu.org>
3773
3774         Unreviewed. Update my email addresses.
3775
3776         * Scripts/webkitpy/common/config/committers.py:
3777
3778 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
3779
3780         [GTK] Waiting on the gdb process will lead to deadlock
3781         https://bugs.webkit.org/show_bug.cgi?id=106906
3782
3783         Reviewed by Philippe Normand.
3784
3785         Use communicate() rather than wait() on the Popen object that's running the gdb
3786         command. This avoids the deadlock that occurs on the GTK builders.
3787
3788         * Scripts/webkitpy/layout_tests/port/gtk.py:
3789         (GtkPort._get_gdb_output):
3790
3791 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
3792
3793         [GTK] Limit the number of frames printed out when backtracing with gdb
3794         https://bugs.webkit.org/show_bug.cgi?id=106901
3795
3796         Reviewed by Philippe Normand.
3797
3798         Printing an unlimited number of frames when dumping the gdb backtracing
3799         output can cause timeouts in the builders. This patch limits the number
3800         of frames that are printed out to 1024.
3801
3802         * Scripts/webkitpy/layout_tests/port/gtk.py:
3803         (GtkPort._get_gdb_output):
3804
3805 2013-01-15  Andras Becsi  <andras.becsi@digia.com>
3806
3807         [Qt] Fix ImageDiff's image format conversion
3808         https://bugs.webkit.org/show_bug.cgi?id=106880
3809
3810         Reviewed by Csaba Osztrogonác.
3811
3812         Besides actually doing the conversion this also silences the suspicious warning:
3813         "ignoring return value of function declared with warn_unused_result attribute".
3814
3815         * ImageDiff/qt/ImageDiff.cpp:
3816         (main): QImage::convertToFormat, contrary to the assumed behaviour, returns a
3817         copy of the image in the given format and does not alter the image itself.
3818
3819 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
3820
3821         [chromium] move remaining methods that just set a boolean flag to TestRunner library
3822         https://bugs.webkit.org/show_bug.cgi?id=106823
3823
3824         Reviewed by Darin Fisher.
3825
3826         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3827         (DRTTestRunner::DRTTestRunner):
3828         (DRTTestRunner::reset):
3829         * DumpRenderTree/chromium/DRTTestRunner.h:
3830         (DRTTestRunner):
3831         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3832         (WebTestRunner::WebTestRunner::shouldDumpBackForwardList):
3833         (WebTestRunner::WebTestRunner::deferMainResourceDataLoad):
3834         (WebTestRunner::WebTestRunner::shouldDumpSelectionRect):
3835         (WebTestRunner::WebTestRunner::testRepaint):
3836         (WebTestRunner::WebTestRunner::sweepHorizontally):
3837         (WebTestRunner::WebTestRunner::isPrinting):
3838         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
3839         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3840         (WebTestRunner::TestRunner::TestRunner):
3841         (WebTestRunner::TestRunner::reset):
3842         (WebTestRunner::TestRunner::shouldDumpBackForwardList):
3843         (WebTestRunner):
3844         (WebTestRunner::TestRunner::deferMainResourceDataLoad):
3845         (WebTestRunner::TestRunner::shouldDumpSelectionRect):
3846         (WebTestRunner::TestRunner::testRepaint):
3847         (WebTestRunner::TestRunner::sweepHorizontally):
3848         (WebTestRunner::TestRunner::isPrinting):
3849         (WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
3850         (WebTestRunner::TestRunner::dumpBackForwardList):
3851         (WebTestRunner::TestRunner::setDeferMainResourceDataLoad):
3852         (WebTestRunner::TestRunner::dumpSelectionRect):
3853         (WebTestRunner::TestRunner::repaintSweepHorizontally):
3854         (WebTestRunner::TestRunner::setPrinting):
3855         (WebTestRunner::TestRunner::setShouldStayOnPageAfterHandlingBeforeUnload):
3856         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3857         (TestRunner):
3858
3859 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
3860
3861         nrwt: stub out show_results_html for mock ports
3862         https://bugs.webkit.org/show_bug.cgi?id=106848
3863
3864         Reviewed by Ojan Vafai.
3865
3866         We were accidentally using the underlying ports'
3867         show_results_html_file() implementation, which would, unsurprisingly,
3868         fail in many cases (e.g., running mock-efl on the mac).
3869
3870         No test added since we don't generally add tests for the mock
3871         implementation.
3872
3873         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
3874         (MockDRTPort.show_results_html_file):
3875
3876 2013-01-14  Tim 'mithro' Ansell  <mithro@mithis.com>
3877
3878         Changing clean_working_directory/clean_local_commits and related
3879         functions to have consistent naming.
3880
3881         https://bugs.webkit.org/show_bug.cgi?id=104198
3882
3883         Reviewed by Adam Barth.
3884
3885         * Scripts/webkitpy/common/checkout/scm/git.py:
3886         * Scripts/webkitpy/common/checkout/scm/scm.py:
3887         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3888         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3889         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
3890         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
3891
3892 2013-01-14  Alan Cutter  <alancutter@chromium.org>
3893
3894         Fix EWS GCE build scripts to detect which zone is available
3895         https://bugs.webkit.org/show_bug.cgi?id=106524
3896
3897         Reviewed by Adam Barth.
3898
3899         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
3900         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
3901         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
3902         * EWSTools/GoogleComputeEngine/findzone.sh: Added.
3903
3904 2013-01-14  Tim 'mithro' Ansell  <mithro@mithis.com>
3905
3906         Adding an error string to AmbiguousCommitError.
3907         https://bugs.webkit.org/show_bug.cgi?id=106846
3908
3909         Reviewed by Adam Barth.
3910
3911         * Scripts/webkitpy/common/checkout/scm/git.py:
3912         (AmbiguousCommitError.__init__):
3913
3914 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
3915
3916         kill whole lighttpd process tree for chromium win
3917         https://bugs.webkit.org/show_bug.cgi?id=106838
3918
3919         Reviewed by Tony Chang.
3920
3921         Land a speculative fix for lighttpd.exe hanging on some chromium bots;
3922         I think a test is causing a httpd server child process to wedge and
3923         killing the parent httpd server process isn't sufficient to ensure
3924         that the children are also killed.
3925
3926         * Scripts/webkitpy/layout_tests/servers/http_server.py:
3927         (Lighttpd._check_and_kill):
3928         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
3929         (TestHttpServer.test_start_cmd):
3930         (TestHttpServer):
3931         (TestHttpServer.test_win32_start_and_stop):
3932         (TestHttpServer.test_win32_start_and_stop.wait_for_action):
3933         (TestHttpServer.test_win32_start_and_stop.mock_returns):
3934         (TestHttpServer.test_win32_start_and_stop.mock_returns.return_value_thunk):
3935
3936 2013-01-14  Nico Weber  <thakis@chromium.org>
3937
3938         [chromium] Enable `update-webkit --chromium --ninja` on windows
3939         https://bugs.webkit.org/show_bug.cgi?id=106836
3940
3941         Reviewed by Eric Seidel.
3942
3943         After running this, build-webkit --chromium will use ninja to build.
3944         Apparently there are some minor issues with that still, so it's
3945         not quite ready for use yet.
3946
3947         * Scripts/webkitdirs.pm:
3948         (determineIsChromiumNinja):
3949         (buildChromium):
3950
3951 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
3952
3953         nrwt: use the same search path for baselines and TestExpectations on apple mac
3954         https://bugs.webkit.org/show_bug.cgi?id=105599
3955
3956         Reviewed by Ryosuke Niwa.
3957
3958         Bug 105583 revealed some confusion due to the fact that the Apple
3959         Mac port used a different list of directories to search for baselines
3960         and TestExpectations files (actually, pretty much every port does).
3961
3962         It seems like a good idea to use the same list for both by default, but
3963         making this happen will affect every port in slightly different ways, so
3964         we'll try this on the Apple Mac port first.
3965
3966         Note that the effective changes for this are that:
3967         1) The apple mac port will look in platform/wk2 for baselines where
3968         it didn't before (it will look after looking in mac-wk2 but before
3969         the non-wk2 dirs)
3970         2) The apple mac-snowleopard port will use the expectations in
3971         mac-lion as well as the expectations in mac-snowleopard, although
3972         I'm not even sure if mac-snowleopard is still supported ...
3973
3974         * Scripts/webkitpy/layout_tests/port/mac.py:
3975         (MacPort.default_baseline_search_path):
3976         (MacPort.expectations_files):
3977         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3978         (test_baseline_search_path):
3979
3980 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
3981
3982         AX: Need to implement ColorWellRole
3983         https://bugs.webkit.org/show_bug.cgi?id=106756
3984
3985         Reviewed by Chris Fleizach.
3986
3987         Returns a string representation of the value of a color
3988         when the role is Color Well, to make it easy to write layout
3989         tests for color controls.
3990
3991         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
3992
3993 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
3994
3995         Chromium: Error in AccessibilityUIElement::intValueGetterCallback
3996         https://bugs.webkit.org/show_bug.cgi?id=106682
3997
3998         Reviewed by Chris Fleizach.
3999
4000         Modify Chromium's DRT implementation of intValue to return a
4001         different value depending on the role.
4002
4003         There are actually platform-specific differences in what should
4004         be returned in the "value" of an object, so Chromium normally keeps
4005         these separate (i.e. valueForRange, headingLevel, hierarchicalLevel, etc.)
4006         but this is a fine simplification to make cross-platform tests easier.
4007
4008         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
4009         (WebTestRunner::AccessibilityUIElement::intValueGetterCallback):
4010
4011 2013-01-14  Jochen Eisinger  <jochen@chromium.org>
4012
4013         [chromium] move remaining methods to dump WebViewClient callbacks to TestRunner library
4014         https://bugs.webkit.org/show_bug.cgi?id=106785
4015
4016         Reviewed by Adam Barth.
4017
4018         * DumpRenderTree/chromium/DRTTestRunner.cpp:
4019         (DRTTestRunner::DRTTestRunner):
4020         (DRTTestRunner::reset):
4021         * DumpRenderTree/chromium/DRTTestRunner.h:
4022         (DRTTestRunner):
4023         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
4024         (WebTestProxyBase):
4025         (WebTestRunner::WebTestProxy::setStatusText):
4026         (WebTestRunner::WebTestProxy::didStopLoading):
4027         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
4028         (WebTestRunner::WebTestRunner::shouldDumpStatusCallbacks):
4029         (WebTestRunner::WebTestRunner::shouldDumpProgressFinishedCallback):
4030         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
4031         (WebTestRunner::TestRunner::TestRunner):
4032         (WebTestRunner::TestRunner::reset):
4033         (WebTestRunner::TestRunner::shouldDumpStatusCallbacks):
4034         (WebTestRunner):
4035         (WebTestRunner::TestRunner::shouldDumpProgressFinishedCallback):
4036         (WebTestRunner::TestRunner::dumpWindowStatusChanges):
4037         (WebTestRunner::TestRunner::dumpProgressFinishedCallback):
4038         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
4039         (TestRunner):
4040         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
4041         (WebTestRunner::WebTestProxyBase::setStatusText):
4042         (WebTestRunner):
4043         (WebTestRunner::WebTestProxyBase::didStopLoading):
4044         * DumpRenderTree/chromium/WebViewHost.cpp:
4045         (WebViewHost::didStopLoading):
4046         * DumpRenderTree/chromium/WebViewHost.h:
4047         (WebViewHost):
4048
4049 2013-01-14  Andrey Lushnikov  <lushnikov@chromium.org>
4050
4051         Web Inspector: devtools front-end doesn't have focus in TestShell
4052         https://bugs.webkit.org/show_bug.cgi?id=106778
4053
4054         Reviewed by Pavel Feldman.
4055
4056         Focus devTools window after loadURL method.
4057
4058         * DumpRenderTree/chromium/TestShell.cpp:
4059         (TestShell::runFileTest):
4060
4061 2013-01-14  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
4062
4063         [EFL][jhbuild] Build the GStreamer-related dependencies with the "configure" script
4064         https://bugs.webkit.org/show_bug.cgi?id=106573
4065
4066         Reviewed by Philippe Normand.
4067
4068         Similarly to what's been described in bug 106569, we're building
4069         from release tarballs, so there's no reason to regenerate the
4070         autoconf-related stuff with autogen.sh, especially since we might
4071         run into trouble with automake 1.13 and deprecated macros.
4072
4073         * efl/jhbuild.modules:
4074
4075 2013-01-14  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
4076
4077         [Qt] The Qt's configuration isn't honoured regarding the use of the system libpng and libjpeg
4078         https://bugs.webkit.org/show_bug.cgi?id=104909
4079
4080         Reviewed by Simon Hausmann.
4081
4082         To be able to build redistribuable binary packages, Qt's configure switches
4083         -qt-libpng and -qt-libjpeg are used to avoid having the binaries trying to
4084         dynamically link to optional system libraries.
4085         QtWebKit is doing its own configure checks for those libraries, thus adding a
4086         runtime dependency that might not be fulfilled if the packager's machine had
4087         those libraries while the user's machine won't.
4088
4089         Since in most cases where WebKit will want to use those system libraries, Qt will
4090         also be using them, remove these configure tests from WebKit.
4091
4092         * qmake/config.tests/libjpeg/libjpeg.cpp: Removed.
4093         * qmake/config.tests/libjpeg/libjpeg.pro: Removed.
4094         * qmake/config.tests/libpng/libpng.cpp: Removed.
4095         * qmake/config.tests/libpng/libpng.pro: Removed.
4096         * qmake/mkspecs/features/features.prf:
4097
4098 2013-01-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
4099
4100         [EFL][jhbuild] Bump the EFL dependencies in jhbuild to 1.7.5.
4101         https://bugs.webkit.org/show_bug.cgi?id=106574
4102
4103         Reviewed by Laszlo Gombos.
4104
4105         Rely on a more recent stable release, which includes support for
4106         Lua 5.2 in Edje and other assorted minor fixes.
4107
4108         While here, also use the "configure" script to build the libraries
4109         instead of relying on autogen.sh, which is not really needed with
4110         a release tarball and may have problems with automake 1.13.
4111
4112         * efl/jhbuild.modules:
4113
4114 2013-01-14  Andrey Lushnikov  <lushnikov@chromium.org>
4115
4116         Web Inspector: fix DRT to deliver simulated events to devtools front-end
4117         https://bugs.webkit.org/show_bug.cgi?id=106650
4118
4119         Reviewed by Pavel Feldman.
4120
4121         Add separated m_devToolsTestInterfaces object to testShell which is
4122         bind to devTools webview.
4123
4124         * DumpRenderTree/chromium/TestShell.cpp:
4125         (TestShell::initialize):
4126         (TestShell::createMainWindow):
4127         (TestShell::~TestShell):
4128         (TestShell::showDevTools):
4129         (TestShell::resetTestController):
4130         (TestShell::bindJSObjectsToWindow):
4131         (TestShell::createNewWindow):
4132         * DumpRenderTree/chromium/TestShell.h:
4133         (TestShell):
4134
4135 2013-01-14  Alan Cutter  <alancutter@chromium.org>
4136
4137         Sheriffbot command aliases need test cases
4138         https://bugs.webkit.org/show_bug.cgi?id=106754
4139
4140         Reviewed by Eric Seidel.
4141
4142         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
4143         (SheriffBotTest.test_command_aliases):
4144
4145 2013-01-13  Alan Cutter  <alancutter@chromium.org>
4146
4147         Allow users to misspell the "sheriffs" command in sheriffbot
4148         https://bugs.webkit.org/show_bug.cgi?id=106628
4149
4150         Reviewed by Steve Block.
4151
4152         * Scripts/webkitpy/tool/bot/irc_command.py:
4153
4154 2013-01-13  Alan Cutter  <alancutter@chromium.org>
4155
4156         Make "gardeners" an alias for "sheriffs" in sherrifbot
4157         https://bugs.webkit.org/show_bug.cgi?id=106627
4158
4159         Reviewed by Eric Seidel.
4160
4161         * Scripts/webkitpy/tool/bot/irc_command.py:
4162
4163 2013-01-13  Dirk Pranke  <dpranke@chromium.org>
4164
4165         [chromium] webkitpy-test: executive.py stringify_args error on the release test bot
4166         https://bugs.webkit.org/show_bug.cgi?id=105380
4167
4168         Reviewed by Eric Seidel.
4169
4170         Fix a regression introduced in r137692 where we were double-encoding
4171         the arguments to popen(); this was only an issue on windows, where
4172         we would try to encode something to mbcs, then try to encode it
4173         to unicode as if the input as ascii.
4174
4175         * Scripts/webkitpy/common/system/executive.py:
4176         (Executive.run_command):
4177
4178 2013-01-13  Alan Cutter  <alancutter@chromium.org>
4179
4180         State who told sheriffbot to roll the Chromium deps and to what revision
4181         https://bugs.webkit.org/show_bug.cgi?id=106626
4182
4183         Reviewed by Eric Seidel.
4184
4185         Added optional argument to post-chromium-deps-roll so Sheriffbot can specify ChangeLog message.
4186
4187         * Scripts/webkitpy/tool/bot/irc_command.py:
4188         (RollChromiumDEPS._expand_irc_nickname):
4189         (RollChromiumDEPS.execute):
4190         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
4191         (IRCCommandTest.test_roll_chromium_deps):
4192         * Scripts/webkitpy/tool/bot/sheriff.py:
4193         (Sheriff.post_chromium_deps_roll):
4194         * Scripts/webkitpy/tool/commands/roll.py:
4195         (RollChromiumDEPS._prepare_state):
4196         (PostChromiumDEPSRoll):
4197         (PostChromiumDEPSRoll._prepare_state):
4198         * Scripts/webkitpy/tool/commands/roll_unittest.py:
4199         (PostRollCommandsTest.test_prepare_state):
4200         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
4201         (PrepareChangeLogForDEPSRoll.run):
4202
4203 2013-01-13  Alan Cutter  <alancutter@chromium.org>
4204
4205         Add Alan Cutter as contributor
4206         https://bugs.webkit.org/show_bug.cgi?id=106747
4207
4208         Reviewed by Eric Seidel.
4209
4210         * Scripts/webkitpy/common/config/committers.py:
4211
4212 2013-01-13  Jonathan Liu  <net147@gmail.com>
4213
4214         Fix CONFIG missing link_pkgconfig on Windows
4215         https://bugs.webkit.org/show_bug.cgi?id=106647
4216
4217         Some libraries (e.g. libxslt, libxml2 and sqlite3) fail to link
4218         properly on Windows because they are added to PKGCONFIG but
4219         CONFIG does not contain link_pkgconfig.
4220
4221         This is because link_pkgconfig is added in unix/default_pre.prf
4222         which is only used for UNIX platforms. To fix this, move it to
4223         the general default_pre.prf.
4224
4225         Reviewed by Simon Hausmann.
4226
4227         * qmake/mkspecs/features/default_pre.prf:
4228         * qmake/mkspecs/features/unix/default_pre.prf:
4229
4230 2013-01-12  Nico Weber  <thakis@chromium.org>
4231
4232         nrwt/chromium: Don't prefer chromium over webkit build directories
4233         https://bugs.webkit.org/show_bug.cgi?id=105597
4234
4235         Reviewed by Dirk Pranke.
4236
4237         Rely on the new timestamp logic instead. Requested by dpranke in
4238         https://bugs.webkit.org/show_bug.cgi?id=105498
4239
4240         * Scripts/webkitpy/layout_tests/port/chromium.py:
4241         (ChromiumPort._static_build_path):
4242         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
4243         (ChromiumLinuxPortTest.test_build_path):
4244         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
4245         (ChromiumMacPortTest.test_build_path):
4246         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
4247         (ChromiumWinTest.test_build_path):
4248
4249 2013-01-12  Nico Weber  <thakis@chromium.org>
4250
4251         Use ninja by default on Linux for build-webkit --chromium, bot edition
4252         https://bugs.webkit.org/show_bug.cgi?id=104434
4253
4254         Reviewed by Eric Seidel.
4255
4256         r139557 changed update-webkit to pick ninja by default on linux, but
4257         the bots run update-webkit-chromium directly so they didn't see this.
4258         Move the default for ninja into update-webkit-chromium so that it's
4259         picked up by the bots, and let update-webkit forward non-default
4260         options to there.
4261
4262         This way, the default is in one place only and both developers (who
4263         usually use update-webkit which then shells out to
4264         updat-webkit-chromium) and bots (which use update-webkit-chromium
4265         directly) see the same behavior.
4266
4267         * Scripts/update-webkit:
4268         * Scripts/update-webkit-chromium:
4269
4270 2013-01-12  Nico Weber  <thakis@chromium.org>
4271
4272         Make ninja the default build system on Linux for build-webkit --chromium
4273         https://bugs.webkit.org/show_bug.cgi?id=104434
4274
4275         Reviewed by Eric Seidel.
4276
4277         * Scripts/update-webkit:
4278
4279 2013-01-12  Alan Cutter  <alancutter@chromium.org>
4280
4281         Migrate the remaining bots in EC2 to Google Compute Engine
4282         https://bugs.webkit.org/show_bug.cgi?id=106005
4283
4284         Reviewed by Eric Seidel.
4285
4286         Updated bot scripts for launching feeder-queue, style-queue and sheriffbot on GCE.
4287
4288         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh: Copied from Tools/EWSTools/build-repo.sh.
4289         * EWSTools/boot.sh:
4290         * EWSTools/build-repo.sh:
4291         * EWSTools/start-queue.sh:
4292
4293 2013-01-12  Jochen Eisinger  <jochen@chromium.org>
4294
4295         [chromium] move inspector related methods to TestRunner library
4296         https://bugs.webkit.org/show_bug.cgi?id=106654
4297
4298         Reviewed by Adam Barth.
4299
4300         * DumpRenderTree/chromium/DRTTestRunner.cpp:
4301         (DRTTestRunner::DRTTestRunner):
4302         * DumpRenderTree/chromium/DRTTestRunner.h:
4303         (DRTTestRunner):
4304         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
4305         (WebTestRunner::WebTestDelegate::showDevTools):
4306         (WebTestRunner::WebTestDelegate::closeDevTools):
4307         (WebTestRunner::WebTestDelegate::evaluateInWebInspector):
4308         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
4309         (WebTestRunner::TestRunner::TestRunner):
4310         (WebTestRunner::TestRunner::showWebInspector):
4311         (WebTestRunner):
4312         (WebTestRunner::TestRunner::closeWebInspector):
4313         (WebTestRunner::TestRunner::evaluateInWebInspector):
4314         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
4315         (TestRunner):
4316         * DumpRenderTree/chromium/WebViewHost.cpp:
4317         (WebViewHost::showDevTools):
4318         (WebViewHost::closeDevTools):
4319         (WebViewHost::evaluateInWebInspector):
4320         * DumpRenderTree/chromium/WebViewHost.h:
4321         (WebViewHost):
4322
4323 2013-01-11  Julie Parent  <jparent@chromium.org>
4324
4325         Builder should not be a valid parameter for stats dashboard
4326         https://bugs.webkit.org/show_bug.cgi?id=106698
4327
4328         Reviewed by Dirk Pranke.
4329         
4330         Since builder is a dashboard specific parameter, dashboard_base
4331         should not be handling it in handleValidHashParameterWrapper, rather,
4332         each specific dashboard should in its handleValidHashParameter function.
4333     
4334         Note that the FIXME in dashboard_base about this was actually wrong -
4335         we don't want to move it to g_crossDashboardState, because it isn't
4336         actually cross dashboard state.
4337         
4338         In fact, flakiness and treemap have the code in 
4339         handleValidHashParameter, but it is currently dead code because 
4340         dashboard_base gets to it first.
4341         
4342         Added the proper handling to timeline_explorer, since builder is
4343         valid there.
4344
4345         * TestResultServer/static-dashboards/dashboard_base.js:
4346         * TestResultServer/static-dashboards/timeline_explorer.html:
4347
4348 2013-01-11  Ryosuke Niwa  <rniwa@webkit.org>
4349
4350         REGRESSION: buildbot mangles error messages with timestamps run-webkit-tests outputs
4351         https://bugs.webkit.org/show_bug.cgi?id=106688
4352
4353         Reviewed by Eric Seidel.
4354
4355      &nb