4cbc1c58d4890889e0b0599060353bd3f1eb215a
[WebKit-https.git] / Tools / ChangeLog
1 2013-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2
3         Update Anne's email address
4         https://bugs.webkit.org/show_bug.cgi?id=107866
5
6         Reviewed by Adam Barth.
7
8         * Scripts/webkitpy/common/config/committers.py:
9
10 2013-01-24  Alan Cutter  <alancutter@chromium.org>
11
12         HTTP 500 error between QueueStatusServer and bot(s)
13         https://bugs.webkit.org/show_bug.cgi?id=107184
14
15         Reviewed by Adam Barth.
16
17         Removed the use of memcache which was the source of the exception.
18
19         * QueueStatusServer/handlers/updatestatus.py:
20         (UpdateStatus.post):
21         * QueueStatusServer/model/attachment.py:
22         (Attachment):
23         (Attachment.summary):
24
25 2013-01-24  Sheriff Bot  <webkit.review.bot@gmail.com>
26
27         Unreviewed, rolling out r140653.
28         http://trac.webkit.org/changeset/140653
29         https://bugs.webkit.org/show_bug.cgi?id=107916
30
31         Causes a temp file leak on the bots (Requested by abarth on
32         #webkit).
33
34         * DumpRenderTree/chromium/TestShell.cpp:
35         (TestShell::resetTestController):
36
37 2013-01-24  Eric Seidel  <eric@webkit.org>
38
39         Skip haslanded_unittest.py on systems which do not have interdiff installed
40         https://bugs.webkit.org/show_bug.cgi?id=106402
41
42         Unreviewed.
43
44         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
45         (HasLandedTest):
46
47 2013-01-24  Ryosuke Niwa  <rniwa@webkit.org>
48
49         Disable the failing webkitpy test for now.
50
51         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
52
53 2013-01-24  Tim 'mithro' Ansell  <mithro@mithis.com>
54
55         Fixing the diff_parser to correctly identify git diffs even with leading comments.
56         https://bugs.webkit.org/show_bug.cgi?id=107871
57
58         Reviewed by Eric Seidel.
59
60         * Scripts/webkitpy/common/checkout/diff_parser.py:
61         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
62         * Scripts/webkitpy/tool/steps/haslanded.py:
63
64 2013-01-24  James Robinson  <jamesr@chromium.org>
65
66         [chromium] Remove dead transitional code from WebViewImpl
67         https://bugs.webkit.org/show_bug.cgi?id=107889
68
69         Reviewed by Adrienne Walker.
70
71         * DumpRenderTree/chromium/WebViewHost.cpp:
72         (WebViewHost::initializeLayerTreeView):
73         (WebViewHost::setWebWidget):
74
75 2013-01-24  Joshua Bell  <jsbell@chromium.org>
76
77         Add watchlist for IndexedDB development, and add myself and others.
78
79         Unreviewed.
80
81         * Scripts/webkitpy/common/config/watchlist:
82
83 2013-01-24  Martin Robinson  <mrobinson@igalia.com>
84
85         Abstract the logic for appending a UChar32 onto StringBuilder
86         https://bugs.webkit.org/show_bug.cgi?id=107505
87
88         Reviewed by Darin Adler.
89
90         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
91         (TestWebKitAPI::TEST): Added a simple test for appending UChar32.
92
93 2013-01-24  Erik Arvidsson  <arv@chromium.org>
94
95         Unreviewed, rolling out r140703.
96         http://trac.webkit.org/changeset/140703
97         https://bugs.webkit.org/show_bug.cgi?id=107556
98
99         r140561 was not the reason for the Android breakage
100
101         * DumpRenderTree/chromium/TestShell.cpp:
102         (TestShell::~TestShell):
103         (TestShell::closeWindow):
104         * DumpRenderTree/chromium/WebViewHost.cpp:
105         (WebViewHost::WebViewHost):
106         (WebViewHost::~WebViewHost):
107         (WebViewHost::shutdown):
108         * DumpRenderTree/chromium/WebViewHost.h:
109         (WebViewHost):
110
111 2013-01-24  Dean Jackson  <dino@apple.com>
112
113         Allow some plugin snapshot UI content to come from Injected Bundle
114         https://bugs.webkit.org/show_bug.cgi?id=107852
115
116         Reviewed by Anders Carlsson.
117
118         Null implementations of plugInStartLabelTitle, plugInStartLabelSubtitle and
119         plugInExtraStyleSheet.
120
121         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
122         (WTR::InjectedBundlePage::InjectedBundlePage):
123
124 2013-01-24  Erik Arvidsson  <arv@chromium.org>
125
126         Unreviewed, rolling out r140561.
127         http://trac.webkit.org/changeset/140561
128         https://bugs.webkit.org/show_bug.cgi?id=107556
129
130         Suspected to break Android which prevens WebKit roll
131
132         * DumpRenderTree/chromium/TestShell.cpp:
133         (TestShell::~TestShell):
134         (TestShell::closeWindow):
135         * DumpRenderTree/chromium/WebViewHost.cpp:
136         (WebViewHost::WebViewHost):
137         (WebViewHost::~WebViewHost):
138         * DumpRenderTree/chromium/WebViewHost.h:
139         (WebViewHost):
140
141 2013-01-24  Tim 'mithro' Ansell  <mithro@mithis.com>
142
143         Adding "has-landed" command to webkit-patch which compares a
144         committed patch to the changes which exist locally (ignoring the
145         ChangeLog file).
146
147         https://bugs.webkit.org/show_bug.cgi?id=106402
148
149         Reviewed by Eric Seidel.
150
151         * Scripts/webkitpy/common/checkout/diff_parser.py:
152         (git_diff_to_svn_diff):
153         * Scripts/webkitpy/common/net/bugzilla/bug.py:
154         (Bug.commit_revision):
155         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
156         (BugTest.test_is_in_comments):
157         (BugTest):
158         (BugTest.test_commit_revision):
159         * Scripts/webkitpy/tool/commands/upload.py:
160         (HasLanded):
161         * Scripts/webkitpy/tool/steps/__init__.py:
162         * Scripts/webkitpy/tool/steps/haslanded.py: Added.
163         (HasLanded):
164         (HasLanded.convert_to_svn):
165         (HasLanded.strip_change_log):
166         (run):
167
168         * Scripts/webkitpy/common/net/bugzilla/bug.py:
169         (Bug.commit_revision):
170         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
171         (BugTest.test_is_in_comments):
172         (BugTest):
173         (BugTest.test_commit_revision):
174         * Scripts/webkitpy/tool/commands/upload.py:
175         (HasLanded):
176         * Scripts/webkitpy/tool/steps/__init__.py:
177         * Scripts/webkitpy/tool/steps/haslanded.py: Added.
178         (HasLanded):
179         (HasLanded.convert_to_svn):
180         (HasLanded.strip_change_log):
181         (HasLanded.diff_diff):
182         (HasLanded.run):
183         * Scripts/webkitpy/tool/steps/haslanded_unittest.py: Added.
184         (HasLandedTest):
185         (HasLandedTest.test_run):
186         (test_convert_to_svn_and_strip_change_log):
187
188 2013-01-24  Dan Carney  <dcarney@google.com>
189
190         [chromium] move most WebViewHost printf calls to WebTestProxy
191         https://bugs.webkit.org/show_bug.cgi?id=107553
192
193         Reviewed by Jochen Eisinger.
194
195         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
196         (WebKit):
197         (WebTestProxyBase):
198         (WebTestRunner::WebTestProxy::unableToImplementPolicyWithError):
199         (WebTestRunner::WebTestProxy::didAddMessageToConsole):
200         (WebTestRunner::WebTestProxy::runModalAlertDialog):
201         (WebTestRunner::WebTestProxy::runModalConfirmDialog):
202         (WebTestRunner::WebTestProxy::runModalPromptDialog):
203         (WebTestRunner::WebTestProxy::runModalBeforeUnloadDialog):
204         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
205         (WebTestRunner::WebTestProxyBase::WebTestProxyBase):
206         (WebTestRunner::WebTestProxyBase::reset):
207         (WebTestRunner::WebTestProxyBase::setLogConsoleOutput):
208         (WebTestRunner):
209         (WebTestRunner::WebTestProxyBase::unableToImplementPolicyWithError):
210         (WebTestRunner::WebTestProxyBase::didAddMessageToConsole):
211         (WebTestRunner::WebTestProxyBase::runModalAlertDialog):
212         (WebTestRunner::WebTestProxyBase::runModalConfirmDialog):
213         (WebTestRunner::WebTestProxyBase::runModalPromptDialog):
214         (WebTestRunner::WebTestProxyBase::runModalBeforeUnloadDialog):
215         * DumpRenderTree/chromium/TestShell.cpp:
216         (TestShell::showDevTools):
217         * DumpRenderTree/chromium/WebViewHost.cpp:
218         (WebViewHost::didAddMessageToConsole):
219         (WebViewHost::runModalAlertDialog):
220         (WebViewHost::runModalConfirmDialog):
221         (WebViewHost::runModalPromptDialog):
222         (WebViewHost::runModalBeforeUnloadDialog):
223         (WebViewHost::unableToImplementPolicyWithError):
224         (WebViewHost::reset):
225         * DumpRenderTree/chromium/WebViewHost.h:
226         (WebViewHost):
227
228 2013-01-23  Mark Pilgrim  <pilgrim@chromium.org>
229
230         [Chromium] Give webkit_support a chance to reset state between layout test runs
231         https://bugs.webkit.org/show_bug.cgi?id=107132
232
233         Reviewed by Adam Barth.
234
235         We currently only have need for this on OS(ANDROID), but now it
236         would be useful to have a hook for resetting state on all
237         platforms. Will soon be using this for IDBFactory initialization.
238
239         * DumpRenderTree/chromium/TestShell.cpp:
240         (TestShell::resetTestController): Call webkit_support::ResetTestEnvironment()
241
242 2013-01-23  Alan Cutter  <alancutter@chromium.org>
243
244         QueueStatusServer crashes in production on next-patch
245         https://bugs.webkit.org/show_bug.cgi?id=107775
246
247         Reviewed by Adam Barth.
248
249         Replaced Python 2.5 incompatible call to timedelta.total_seconds().
250
251         * QueueStatusServer/app.yaml:
252         * QueueStatusServer/model/patchlog.py:
253         (PatchLog.calculate_wait_duration):
254         (PatchLog.calculate_process_duration):
255         (PatchLog):
256         (PatchLog._time_delta_to_seconds):
257
258 2013-01-23  Ryosuke Niwa  <rniwa@webkit.org>
259
260         The previous patch wasn't complete. Finish reverting r139998 for real.
261
262         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
263         (ProfilerAgent.getProfile):
264
265 2013-01-23  Ryosuke Niwa  <rniwa@webkit.org>
266
267         Revert r139998 for now since the Leaks Viewer pulls in a specific version of Inspector code.
268
269         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
270         (ProfilerAgent.getProfile):
271
272 2013-01-23  Mark Pilgrim  <pilgrim@chromium.org>
273
274         [Chromium] Remove unused header files in chromium/public/platform/
275         https://bugs.webkit.org/show_bug.cgi?id=107741
276
277         Reviewed by James Robinson.
278
279         These header files have migrated to the new Platform directory.
280         This patch updates the remaining #include references and removes
281         the old files that did nothing but redirect to the new ones.
282
283         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp:
284         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:
285
286 2013-01-23  Martin Robinson  <mrobinson@igalia.com>
287
288         [GTK] Bump webkitgtk-test-fonts dependency to cover fallbacks for Tamil, Bengali, and others
289         https://bugs.webkit.org/show_bug.cgi?id=107727
290
291         Reviewed by Gustavo Noronha Silva.
292
293         * gtk/jhbuild.modules: Update the JHBuild moduleset to point to the new webkitgtk-test-fonts.
294         We are using the git repository now that github has deprecated the downloads feature.
295
296 2013-01-23  Tony Chang  <tony@chromium.org>
297
298         Unreviewed, set svn:eol-style to CRLF on Windows .sln files.
299
300         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
301         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
302         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
303         * WebKitTestRunner/WebKitTestRunner.sln: Modified property svn:eol-style.
304
305 2013-01-23  Mark Pilgrim  <pilgrim@chromium.org>
306
307         [Chromium] Update some #includes in DumpRenderTree for headers in the new Platform directory
308         https://bugs.webkit.org/show_bug.cgi?id=107145
309
310         Reviewed by Adam Barth.
311
312         Part of a larger refactoring series; see tracking bug 82948.
313         
314         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
315         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
316         * DumpRenderTree/chromium/DRTDevToolsClient.h:
317         * DumpRenderTree/chromium/DRTTestRunner.cpp:
318         * DumpRenderTree/chromium/DRTTestRunner.h:
319         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h:
320         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
321         * DumpRenderTree/chromium/MockWebSpeechInputController.h:
322         * DumpRenderTree/chromium/NotificationPresenter.cpp:
323         * DumpRenderTree/chromium/TestNavigationController.h:
324         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp:
325         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
326         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp:
327         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
328         (WebTestRunner):
329         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
330         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h:
331         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
332         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
333         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
334         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
335         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp:
336         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp:
337         * DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp:
338         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
339         * DumpRenderTree/chromium/TestShell.cpp:
340         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
341         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
342         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
343         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
344         * DumpRenderTree/chromium/WebViewHost.cpp:
345
346 2013-01-23  Jochen Eisinger  <jochen@chromium.org>
347
348         [chromium] Use after free in plugins/geturlnotify-during-document-teardown.html
349         https://bugs.webkit.org/show_bug.cgi?id=107556
350
351         Reviewed by Tony Chang.
352
353         WebViewHost initiates a navigation to about:blank in its destructor.
354         However, since WebTestProxy inherits from WebViewHost, at this point
355         the WebViewClient and WebFrameClient interfaces are already partially
356         destructed resulting in the use after free.
357
358         This does not affect the chromium implementation since it doesn't
359         invoke WebKit API methods in its destructor.
360
361         * DumpRenderTree/chromium/TestShell.cpp:
362         (TestShell::~TestShell):
363         (TestShell::closeWindow):
364         * DumpRenderTree/chromium/WebViewHost.cpp:
365         (WebViewHost::WebViewHost):
366         (WebViewHost::~WebViewHost):
367         (WebViewHost::shutdown):
368         * DumpRenderTree/chromium/WebViewHost.h:
369         (WebViewHost):
370
371 2013-01-23  Andrei Bucur  <abucur@adobe.com>
372
373         [CSS Regions] Create Regions watchlist
374         https://bugs.webkit.org/show_bug.cgi?id=107281
375
376         Reviewed by Adam Barth.
377
378         This patch adds 4 new definitions:
379         - RegionsDevelopment - used to track the development progress for regions
380         - RegionsExpectationsMore and RegionsExpectationsLess - used to track expectations changes for the regions tests
381         - RegionsUsage - used to track changes that make use of regions in all the code base
382
383         For now, the Adobe internal tracker is the only email address listening for these patterns.
384
385         * Scripts/webkitpy/common/config/watchlist:
386
387 2013-01-22  Pavel Feldman  <pfeldman@chromium.org>
388
389         Web Inspector: only allow evaluateForTestInFrontend for front-ends under test.
390         https://bugs.webkit.org/show_bug.cgi?id=107523
391
392         Reviewed by Yury Semikhatsky.
393
394         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
395         (DRTDevToolsClient::isUnderTest):
396         (DRTDevToolsClient::call):
397         * DumpRenderTree/chromium/DRTDevToolsClient.h:
398         (DRTDevToolsClient):
399
400 2013-01-23  Tim 'mithro' Ansell  <mithro@mithis.com>
401
402         Removing command line shortening as it makes it difficult to see the command during errors.
403         https://bugs.webkit.org/show_bug.cgi?id=107643
404
405         Reviewed by Eric Seidel.
406
407         * Scripts/webkitpy/common/system/executive.py:
408         (ScriptError):
409         (ScriptError.__init__):
410         * Scripts/webkitpy/common/system/executive_unittest.py:
411
412 2013-01-23  Tim 'mithro' Ansell  <mithro@mithis.com>
413
414         Adding myself as contributor in committers.py (as requested by eseidel).
415         https://bugs.webkit.org/show_bug.cgi?id=107647
416
417         Reviewed by Eric Seidel.
418
419         * Scripts/webkitpy/common/config/committers.py:
420
421 2013-01-22  Alan Cutter  <alancutter@chromium.org>
422
423         Add monitoring of patches and queues to the QueueStatusServer
424         https://bugs.webkit.org/show_bug.cgi?id=107612
425
426         Reviewed by Adam Barth.
427
428         Created classes for recording events into the datastore and integrated them into the existing handlers.
429         Code for presenting the recorded data will come in a separate patch.
430
431         * QueueStatusServer/app.yaml:
432         * QueueStatusServer/config/__init__.py: Added.
433         * QueueStatusServer/config/logging.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
434         * QueueStatusServer/config/messages.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
435         * QueueStatusServer/handlers/nextpatch.py:
436         (NextPatch.get):
437         (NextPatch._assign_patch):
438         * QueueStatusServer/handlers/releasepatch.py:
439         (ReleasePatch.post):
440         * QueueStatusServer/handlers/updatestatus.py:
441         (UpdateStatus.post):
442         * QueueStatusServer/handlers/updateworkitems.py:
443         (UpdateWorkItems._parse_work_items_string):
444         (UpdateWorkItems):
445         (UpdateWorkItems._update_work_items_from_request):
446         (UpdateWorkItems._queue_from_request):
447         (UpdateWorkItems.post):
448         * QueueStatusServer/loggers/__init__.py: Added.
449         * QueueStatusServer/loggers/recordbotevent.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
450         (RecordBotEvent):
451         (RecordBotEvent.activity):
452         * QueueStatusServer/loggers/recordpatchevent.py: Added.
453         (RecordPatchEvent):
454         (RecordPatchEvent.added):
455         (RecordPatchEvent.retrying):
456         (RecordPatchEvent.started):
457         (RecordPatchEvent.stopped):
458         (RecordPatchEvent.updated):
459         (RecordPatchEvent._get_patches_waiting):
460         * QueueStatusServer/model/patchlog.py: Copied from Tools/QueueStatusServer/model/queuestatus.py.
461         (PatchLog):
462         (PatchLog.lookup):
463         (PatchLog.calculate_wait_duration):
464         (PatchLog.calculate_process_duration):
465         * QueueStatusServer/model/queuelog.py: Copied from Tools/QueueStatusServer/handlers/nextpatch.py.
466         (QueueLog):
467         (QueueLog.get_current):
468         (QueueLog.create_key):
469         * QueueStatusServer/model/queuestatus.py:
470         (QueueStatus.is_retry_request):
471
472 2013-01-22  Timothy Loh  <timloh@chromium.com>
473
474         prepare-Changelog should support updating the list of changed files
475         https://bugs.webkit.org/show_bug.cgi?id=74358
476
477         Reviewed by Eric Seidel.
478
479         Needing to re-make ChangeLog entries when the list of files/functions
480         changes is a bit annoying, it'd be nice to have this more automated.
481         This patch makes `webkit-patch update' update the date line and bug
482         description if needed, and if the list of changed files/functions has
483         changed, either updates the list (if there are no annotations), or
484         otherwise appends the new list below.
485
486         * Scripts/webkitpy/tool/steps/preparechangelog.py:
487         (PrepareChangeLog._resolve_existing_entry):
488         (PrepareChangeLog):
489         (PrepareChangeLog._merge_entries):
490         (PrepareChangeLog.run):
491         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
492         (PrepareChangeLogTest.test_resolve_existing_entry):
493         (make_entry):
494         (test_ensure_bug_url):
495
496 2013-01-22  Tim 'mithro' Ansell  <mithro@mithis.com>
497
498         Use Python 2.7 unittest syntax in our unittests
499         https://bugs.webkit.org/show_bug.cgi?id=105607
500
501         Reviewed by Eric Seidel.
502
503         * Scripts/webkitpy/**/*_unittest.py:
504
505 2013-01-22  Tim 'mithro' Ansell  <mithro@mithis.com>
506
507         Convert disable-msg to disable for new pylint.
508         https://bugs.webkit.org/show_bug.cgi?id=107627
509
510         Reviewed by Eric Seidel.
511
512         * Scripts/webkitpy/common/checkout/scm/svn.py:
513         (SVNRepository.has_authorization_for_realm):
514         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
515         (Builder.force_build):
516         * Scripts/webkitpy/common/system/executive_mock.py:
517         (MockExecutive2.run_command):
518         * Scripts/webkitpy/layout_tests/port/base.py:
519         (Port.reference_files):
520         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
521         (ChromiumPortTestCase.test_default_configuration):
522         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
523         (PortTestCase.test_expectations_ordering):
524         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
525         (HttpServerBase._check_that_all_ports_are_available):
526         * Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
527         (AbstractLocalServerCommand.execute):
528         * Scripts/webkitpy/tool/commands/download.py:
529         (AbstractPatchProcessingCommand):
530         * Scripts/webkitpy/tool/commands/rebaseline.py:
531         (AbstractRebaseliningCommand):
532         (AbstractParallelRebaselineCommand):
533         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
534         (_BaseTestCase.setUp):
535         (TestAnalyzeBaselines.setUp):
536
537 2013-01-22  Frank Farzan  <frankf@chromium.org>
538
539         Flakiness dashboard: update builders.jsonp
540         https://bugs.webkit.org/show_bug.cgi?id=107610
541
542         Reviewed by Ojan Vafai.
543
544         * TestResultServer/static-dashboards/builders.jsonp:
545
546 2013-01-22  Frank Farzan  <frankf@chromium.org>
547
548         Add Android instrumentation tests from ChromiumLinux waterfall
549         https://bugs.webkit.org/show_bug.cgi?id=107597
550
551         Reviewed by Ojan Vafai.
552
553         * TestResultServer/static-dashboards/builders.js:
554         (loadBuildersList):
555
556 2013-01-21  Kentaro Hara  <haraken@chromium.org>
557
558         Implement UIEvent constructor
559         https://bugs.webkit.org/show_bug.cgi?id=107430
560
561         Reviewed by Adam Barth.
562
563         Editor's draft: https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm
564
565         UIEvent constructor is implemented under a DOM4_EVENTS_CONSTRUCTOR flag,
566         which is enabled on Safari and Chromium for now.
567
568         * Scripts/webkitperl/FeatureList.pm:
569
570 2013-01-22  Timothy Loh  <timloh@chromium.com>
571
572         Add functions to ChangeLog - parse bug desc/changed functions, delete/prepend entries
573         https://bugs.webkit.org/show_bug.cgi?id=107478
574
575         Reviewed by Eric Seidel.
576
577         On the road to resolving Bug 74358, we need a few more functions in
578         changelog.py.
579         To make things easier to mock, change @staticmethods to @classmethods.
580
581         * Scripts/webkitpy/common/checkout/changelog.py:
582         (ChangeLogEntry):
583         (ChangeLogEntry._parse_reviewer_text):
584         (ChangeLogEntry._split_contributor_names):
585         (ChangeLogEntry._parse_author_name_and_email):
586         (ChangeLogEntry._parse_author_text):
587         (ChangeLogEntry._parse_touched_functions):
588         (ChangeLogEntry._parse_bug_description):
589         (ChangeLogEntry._parse_entry):
590         (ChangeLogEntry.date_line):
591         (ChangeLogEntry.bug_description):
592         (ChangeLogEntry.touched_functions):
593         (ChangeLogEntry.touched_files_text):
594         (ChangeLogEntry.is_touched_files_text_clean):
595         (ChangeLog):
596         (ChangeLog.parse_latest_entry_from_file):
597         (ChangeLog._separate_revision_and_line):
598         (ChangeLog.parse_entries_from_file):
599         (ChangeLog.set_short_description_and_bug_url):
600         (ChangeLog.delete_entries):
601         (ChangeLog.prepend_text):
602         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
603         (test_parse_log_entries_from_changelog):
604         (test_latest_entry_parse):
605         (test_set_short_description_and_bug_url):
606         (test_delete_entries):
607         (test_prepend_text):
608
609 2013-01-22  Lucas Forschler  <lforschler@apple.com>
610
611         Create a MAC EWS startup shell script.
612
613         Reviewed by Ryosuke Niwa.
614
615         * EWSTools/start-queue-mac.sh: Added.
616
617 2013-01-22  Joseph Pecoraro  <pecoraro@apple.com>
618
619         [Mac] Enable Page Visibility (PAGE_VISIBILITY_API)
620         https://bugs.webkit.org/show_bug.cgi?id=107230
621
622         Reviewed by David Kilzer.
623
624         * DumpRenderTree/mac/TestRunnerMac.mm:
625         (TestRunner::resetPageVisibility):
626         Fix a typo in the original implementation. resetPageVisibility should
627         pass initialState YES so an event is not dispatched, which causes
628         issues in multiple tests. This now matches other ports.
629
630 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
631
632         [GTK] Enable CSS Image Orientation feature
633         https://bugs.webkit.org/show_bug.cgi?id=99040
634
635         Reviewed by Martin Robinson.
636
637         Enable the CSS Image Orientation feature in the development
638         builds of the GTK port. The feature is still disabled in the release
639         builds.
640
641         * Scripts/webkitperl/FeatureList.pm:
642
643 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
644
645         [GTK] Enable the <template> element support in development builds
646         https://bugs.webkit.org/show_bug.cgi?id=106575
647
648         Reviewed by Martin Robinson.
649
650         Enable the <template> element support in the development builds of the GTK port.
651
652         * Scripts/webkitperl/FeatureList.pm:
653
654 2013-01-22  Zan Dobersek  <zandobersek@gmail.com>
655
656         Prettify the output of the override-feature-defines script
657         https://bugs.webkit.org/show_bug.cgi?id=106542
658
659         Reviewed by Martin Robinson.
660
661         The output now clearly lists the feature defines being overridden
662         along with the default and overriding values for each feature define.
663
664         * gtk/override-feature-defines:
665         (adjust_feature_defines_makefile):
666         (adjust_feature_defines_makefile.override_feature_define):
667
668 2013-01-22  Zan Dobersek  <zdobersek@igalia.com>
669
670         Remove uses of deprecated unittest.TestCase aliases
671         https://bugs.webkit.org/show_bug.cgi?id=102252
672
673         Reviewed by Adam Barth.
674
675         Replace the deprecated assertEquals method of the TestCase interface
676         used in some webkitpy unittests with the assertEqual method.
677
678         * Scripts/webkitpy/common/system/profiler_unittest.py:
679         (ProfilerFactoryTest._assert_default_profiler_name):
680         (ProfilerFactoryTest.test_default_profiler_output):
681         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
682         (GtkPortTest.test_expectations_files):
683         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
684         (TestHttpServer.test_win32_start_and_stop):
685
686 2013-01-22  Jer Noble  <jer.noble@apple.com>
687
688         REGRESSION(r140344): Repeated crashes in WKTR PlatformWebView::viewSupportsOptions().
689         https://bugs.webkit.org/show_bug.cgi?id=107562
690
691         Rubber-stamped by Alexy Proskuryakov.
692
693         The input to WKBooleanGetValue() is not NULL-safe, so NULL check its inputs before calling.
694
695         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
696         (WTR::PlatformWebView::PlatformWebView):
697         (WTR::PlatformWebView::viewSupportsOptions):
698
699 2013-01-22  Alexey Proskuryakov  <ap@apple.com>
700
701         One is not allowed to use commit-queue to make oneself a committer.
702
703         * Scripts/webkitpy/common/config/committers.py: Removing eustas@chromium.org.
704
705 2013-01-22  Eugene Klyuchnikov  <eustas@chromium.org>
706
707         Add myself to commiters.py
708         https://bugs.webkit.org/show_bug.cgi?id=107546
709
710         Reviewed by Kentaro Hara.
711
712         * Scripts/webkitpy/common/config/committers.py:
713
714 2013-01-22  Manuel Rego Casasnovas  <rego@igalia.com>
715
716         [GTK] Implement TestRunner::setTextDirection
717         https://bugs.webkit.org/show_bug.cgi?id=107131
718
719         Reviewed by Philippe Normand.
720
721         * DumpRenderTree/gtk/DumpRenderTree.cpp:
722         (resetDefaultsToConsistentValues): Reset direction to default value.
723         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
724         (TestRunner::setTextDirection): Implement method using
725         gtk_widget_set_direction.
726
727 2013-01-22  Jochen Eisinger  <jochen@chromium.org>
728
729         [chromium] move spell checking mocks to TestRunner library
730         https://bugs.webkit.org/show_bug.cgi?id=107455
731
732         Reviewed by Kent Tamura.
733
734         The content module doesn't provide its own WebSpellCheckClient.
735
736         * DumpRenderTree/DumpRenderTree.gypi:
737         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
738         (WebTestRunner::WebTestDelegate::fillSpellingSuggestionList):
739         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
740         (WebKit):
741         (WebTestRunner):
742         (WebTestProxyBase):
743         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
744         (WebTestRunner):
745         (WebTestRunner::makeMenuItemStringsFor):
746         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Renamed from Tools/DumpRenderTree/chromium/MockGrammarCheck.cpp.
747         (MockGrammarCheck::checkGrammarOfString):
748         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Renamed from Tools/DumpRenderTree/chromium/MockGrammarCheck.h.
749         (WebKit):
750         (MockGrammarCheck):
751         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Renamed from Tools/DumpRenderTree/chromium/MockSpellCheck.cpp.
752         (MockSpellCheck::MockSpellCheck):
753         (MockSpellCheck::~MockSpellCheck):
754         (isNotASCIIAlpha):
755         (MockSpellCheck::spellCheckWord):
756         (MockSpellCheck::fillSuggestionList):
757         (MockSpellCheck::initializeIfNeeded):
758         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Renamed from Tools/DumpRenderTree/chromium/MockSpellCheck.h.
759         (MockSpellCheck):
760         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Added.
761         (WebTestRunner::SpellCheckClient::SpellCheckClient):
762         (WebTestRunner):
763         (WebTestRunner::SpellCheckClient::~SpellCheckClient):
764         (WebTestRunner::SpellCheckClient::setDelegate):
765         (WebTestRunner::SpellCheckClient::spellCheck):
766         (WebTestRunner::SpellCheckClient::checkTextOfParagraph):
767         (WebTestRunner::SpellCheckClient::requestCheckingOfText):
768         (WebTestRunner::SpellCheckClient::finishLastTextCheck):
769         (WebTestRunner::SpellCheckClient::autoCorrectWord):
770         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.
771         (WebTestRunner):
772         (SpellCheckClient):
773         (WebTestRunner::SpellCheckClient::taskList):
774         (WebTestRunner::SpellCheckClient::mockSpellCheck):
775         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
776         (TestDelegate):
777         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
778         (WebTestInterfaces::Internal):
779         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
780         (WebTestRunner::WebTestProxyBase::WebTestProxyBase):
781         (WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
782         (WebTestRunner::WebTestProxyBase::setDelegate):
783         (WebTestRunner::WebTestProxyBase::spellCheckClient):
784         (WebTestRunner):
785         * DumpRenderTree/chromium/WebViewHost.cpp:
786         (WebViewHost::WebViewHost):
787         (WebViewHost::setWebWidget):
788         * DumpRenderTree/chromium/WebViewHost.h:
789         (WebViewHost):
790
791 2013-01-22  Krzysztof Czech  <k.czech@samsung.com>
792
793         [EFL] Adds Accessibility support to wk1
794         https://bugs.webkit.org/show_bug.cgi?id=107440
795
796         Reviewed by Gyuyoung Kim.
797
798         * DumpRenderTree/efl/CMakeLists.txt: Adds ATK headers and libraries.
799
800 2013-01-21  Joseph Pecoraro  <pecoraro@apple.com>
801
802         [Mac] WK1 MiniBrowser should clear delegates before releasing webview
803         https://bugs.webkit.org/show_bug.cgi?id=107506
804
805         Reviewed by Dan Bernstein.
806
807         * MiniBrowser/mac/WK1BrowserWindowController.m:
808         (-[WK1BrowserWindowController dealloc]):
809
810 2013-01-21  Dirk Schulze  <dschulze@adobe.com>
811
812         Add build flag for Canvas's Path object (disabled by default)
813         https://bugs.webkit.org/show_bug.cgi?id=107473
814
815         Reviewed by Dean Jackson.
816
817         Add CANVAS_PATH build flag to build systems.
818
819         * Scripts/webkitperl/FeatureList.pm:
820
821 2013-01-21  Jinwoo Song  <jinwoo7.song@samsung.com>
822
823         [EFL][WK2] Add APIs to set/get view source mode
824         https://bugs.webkit.org/show_bug.cgi?id=106633
825
826         Reviewed by Gyuyoung Kim.
827
828         Added a shotcut 'F8' in Minibrowser to display a source code
829         of the web page in a new window.
830
831        * MiniBrowser/efl/main.c:
832         (on_key_down):
833         (on_window_create):
834         (window_create):
835         (elm_main):
836
837 2013-01-21  Nico Weber  <thakis@chromium.org>
838
839         [chromium] Don't archive generated source files.
840         https://bugs.webkit.org/show_bug.cgi?id=106736
841
842         Reviewed by Eric Seidel.
843
844         They shouldn't be needed to run tests. They don't need a lot of space,
845         but add many lines to the "extracting" stdout. This attempts to reduce
846         that noise a bit.
847
848         * BuildSlaveSupport/built-product-archive:
849         (archiveBuiltProduct):
850
851 2013-01-21  Benjamin Poulain  <benjamin@webkit.org>
852
853         Mac DumpRenderTree's installSignalHandlers() is unreachable code
854         https://bugs.webkit.org/show_bug.cgi?id=107383
855
856         Reviewed by Sam Weinig.
857
858         The CrashHandler of DumpRenderTree were originally used for restoring
859         the color profile of the main display even if DRT crashes.
860
861         That feature was later limited to pixel tests only in r29999.
862
863         In r104351, the DRT was changed to use device color space. Making the crash
864         handlers useless, but they were left in the code since the error reporting
865         code was still reachable.
866
867         Later, r124581 refactored the code and dumpPixelsForCurrentTest
868         is being used before being assigned its value.
869         This did cause any regression because the code had become useless with the previous change.
870
871         * DumpRenderTree/mac/DumpRenderTree.mm:
872         Remove crashHandler() and installSignalHandlers() as they have become useless and
873         have been unreachable code for 6 months.
874         (dumpRenderTree):
875         Remove the code that was unreachable due to dumpPixelsForCurrentTest being always false
876         at those points.
877
878 2013-01-21  Nico Weber  <thakis@chromium.org>
879
880         Make ninja the default build system for build-webkit --chromium on mac
881         https://bugs.webkit.org/show_bug.cgi?id=106737
882
883         Reviewed by Eric Seidel.
884
885         * Scripts/update-webkit-chromium:
886
887 2013-01-21  Christophe Dumez  <christophe.dumez@intel.com>
888
889         Regression(r140262): Causes a lot of flakiness
890         https://bugs.webkit.org/show_bug.cgi?id=107454
891
892         Reviewed by Alexey Proskuryakov.
893
894         r140262 introduced a lot of flakiness due to fixed layout mode
895         not getting disabled on the view after being enabled for
896         specific test cases. This patch makes sure fixed layout mode
897         properly gets reset in WebKitTestRunner to avoid flakiness.
898
899         * WebKitTestRunner/TestInvocation.cpp:
900         (WTR::updateLayoutType):
901
902 2013-01-21  Gustavo Noronha Silva  <gns@gnome.org>
903
904         REGRESSION (r140285): GTK uses WKPageResourceLoadClient which was removed
905         https://bugs.webkit.org/show_bug.cgi?id=107421
906
907         Unreviewed build fix.
908
909         * Scripts/run-gtk-tests:
910         (TestRunner): skip Resource tests.
911
912 2013-01-21  Christophe Dumez  <christophe.dumez@intel.com>
913
914         [EFL][WKTR] platformRunUntil() should keep the main loop running
915         https://bugs.webkit.org/show_bug.cgi?id=107442
916
917         Reviewed by Noam Rosenthal.
918
919         EFL's implementation of platformRunUntil() should keep the main loop
920         running and avoid calling sleep() between calls to
921         ecore_main_loop_iterate(). This call to sleep seems to be a source
922         of deadlocks (see Bug 106884).
923
924         * WebKitTestRunner/efl/TestControllerEfl.cpp:
925         (WTR::TestController::platformRunUntil):
926
927 2013-01-21  Vivek Galatage  <vivek.vg@samsung.com>
928
929         QtTestBrowser should provide way to clear selected elements
930         https://bugs.webkit.org/show_bug.cgi?id=107437
931
932         Reviewed by Simon Hausmann.
933
934         Provide a way to "Clear selection" in the "Develop" menu to clear the previous search highlight.
935         Invoke the clearSelection prior to highlighting new elements.
936
937         * QtTestBrowser/launcherwindow.cpp:
938         (ElementHighlight):
939         (LauncherWindow::createChrome):
940         (LauncherWindow::selectElements):
941         (LauncherWindow::clearSelection):
942         * QtTestBrowser/launcherwindow.h:
943         (LauncherWindow):
944
945 2013-01-21  Jochen Eisinger  <jochen@chromium.org>
946
947         [chromium] move methods interacting with willSendRequest to TestRunner
948         https://bugs.webkit.org/show_bug.cgi?id=107270
949
950         Reviewed by Kent Tamura.
951
952         * DumpRenderTree/chromium/DRTTestRunner.cpp:
953         (DRTTestRunner::DRTTestRunner):
954         (DRTTestRunner::waitForPolicyDelegate):
955         * DumpRenderTree/chromium/DRTTestRunner.h:
956         (DRTTestRunner):
957         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
958         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
959         (WebTestRunner::WebTestRunner::httpHeadersToClear):
960         (WebTestRunner::WebTestRunner::shouldBlockRedirects):
961         (WebTestRunner::WebTestRunner::willSendRequestShouldReturnNull):
962         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
963         (WebTestRunner::TestRunner::TestRunner):
964         (WebTestRunner::TestRunner::reset):
965         (WebTestRunner::TestRunner::httpHeadersToClear):
966         (WebTestRunner):
967         (WebTestRunner::TestRunner::shouldBlockRedirects):
968         (WebTestRunner::TestRunner::willSendRequestShouldReturnNull):
969         (WebTestRunner::TestRunner::setWillSendRequestClearHeader):
970         (WebTestRunner::TestRunner::setWillSendRequestReturnsNullOnRedirect):
971         (WebTestRunner::TestRunner::setWillSendRequestReturnsNull):
972         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
973         (TestRunner):
974         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
975         (WebTestRunner::WebTestProxyBase::willSendRequest):
976         * DumpRenderTree/chromium/WebViewHost.cpp:
977         (WebViewHost::willSendRequest):
978         (WebViewHost::reset):
979         * DumpRenderTree/chromium/WebViewHost.h:
980         (WebViewHost):
981
982 2013-01-21  Zan Dobersek  <zdobersek@igalia.com>
983
984         [GTK] Stop building WebKit2 on GTK EWSs
985         https://bugs.webkit.org/show_bug.cgi?id=107435
986
987         Reviewed by Philippe Normand.
988
989         The WebKit2 build of the GTK is at the moment not efficiently maintainable,
990         so stop building it on GTK EWSs.
991
992         * Scripts/webkitpy/common/config/ports.py:
993         (GtkPort.build_webkit_command):
994         * Scripts/webkitpy/common/config/ports_unittest.py:
995         (DeprecatedPortTest.test_gtk_port):
996
997 2013-01-21  Tommy Widenflycht  <tommyw@google.com>
998
999         MediaStream API: Update the RTCPeerConnection states to match the latest specification
1000         https://bugs.webkit.org/show_bug.cgi?id=107120
1001
1002         Reviewed by Adam Barth.
1003
1004         Updating mock to use the new states.
1005
1006         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1007         (RTCPeerConnectionStateTask::RTCPeerConnectionStateTask):
1008         (MockWebRTCPeerConnectionHandler::initialize):
1009         (MockWebRTCPeerConnectionHandler::updateICE):
1010
1011 2013-01-20  Tim 'mithro' Ansell  <mithro@mithis.com>
1012
1013         Extend diff_parser to support the --full-index output.
1014         https://bugs.webkit.org/show_bug.cgi?id=107408
1015
1016         Reviewed by Maciej Stachowiak.
1017
1018         * Scripts/webkitpy/common/checkout/diff_parser.py:
1019         (git_diff_to_svn_diff):
1020         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
1021         (DiffParserTest):
1022         (DiffParserTest.test_git_diff_to_svn_diff):
1023         (git_diff_to_svn_diff):
1024
1025 2013-01-20  Yoshifumi Inoue  <yosin@chromium.org>
1026
1027         Dragging over an element with scrollbars should scroll the element when dragging near edges
1028         https://bugs.webkit.org/show_bug.cgi?id=39725
1029
1030         Reviewed by Hajime Morita.
1031
1032         This patch introduces canceling drag-and-drop by escape key for testing
1033         behavior after cancellation drag-and-drop.
1034
1035         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
1036         (WebTestRunner):
1037         (WebTestRunner::EventSender::doMouseUp):
1038         (WebTestRunner::EventSender::finishDragAndDrop):
1039         (WebTestRunner::EventSender::keyDown):
1040         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
1041         (EventSender):
1042         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Added VKEY_ESCAPE.
1043
1044 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
1045
1046         [chromium] move frame generation related methods to TestRunner
1047         https://bugs.webkit.org/show_bug.cgi?id=107268
1048
1049         Reviewed by Adam Barth.
1050
1051         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1052         (DRTTestRunner::DRTTestRunner):
1053         (DRTTestRunner::setWillSendRequestReturnsNull):
1054         * DumpRenderTree/chromium/DRTTestRunner.h:
1055         (DRTTestRunner):
1056         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1057         (WebTestRunner::WebTestDelegate::display):
1058         (WebTestRunner::WebTestDelegate::displayInvalidatedRegion):
1059         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1060         (WebTestRunner::TestRunner::TestRunner):
1061         (WebTestRunner::TestRunner::display):
1062         (WebTestRunner):
1063         (WebTestRunner::TestRunner::displayInvalidatedRegion):
1064         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1065         (TestRunner):
1066         * DumpRenderTree/chromium/WebViewHost.cpp:
1067         (WebViewHost::display):
1068         (WebViewHost::displayInvalidatedRegion):
1069         * DumpRenderTree/chromium/WebViewHost.h:
1070
1071 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
1072
1073         [chromium] move speech related methods to TestRunner library
1074         https://bugs.webkit.org/show_bug.cgi?id=107266
1075
1076         Reviewed by Adam Barth.
1077
1078         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1079         (DRTTestRunner::DRTTestRunner):
1080         (DRTTestRunner::displayInvalidatedRegion):
1081         * DumpRenderTree/chromium/DRTTestRunner.h:
1082         (DRTTestRunner):
1083         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1084         (WebTestDelegate):
1085         (WebTestRunner::WebTestDelegate::addMockSpeechInputResult):
1086         (WebTestRunner::WebTestDelegate::setMockSpeechInputDumpRect):
1087         (WebTestRunner::WebTestDelegate::addMockSpeechRecognitionResult):
1088         (WebTestRunner::WebTestDelegate::setMockSpeechRecognitionError):
1089         (WebTestRunner::WebTestDelegate::wasMockSpeechRecognitionAborted):
1090         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1091         (WebTestRunner::TestRunner::TestRunner):
1092         (WebTestRunner):
1093         (WebTestRunner::TestRunner::addMockSpeechInputResult):
1094         (WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
1095         (WebTestRunner::TestRunner::addMockSpeechRecognitionResult):
1096         (WebTestRunner::TestRunner::setMockSpeechRecognitionError):
1097         (WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
1098         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1099         (TestRunner):
1100         * DumpRenderTree/chromium/WebViewHost.cpp:
1101         (WebViewHost::addMockSpeechInputResult):
1102         (WebViewHost::setMockSpeechInputDumpRect):
1103         (WebViewHost::addMockSpeechRecognitionResult):
1104         (WebViewHost::setMockSpeechRecognitionError):
1105         (WebViewHost::wasMockSpeechRecognitionAborted):
1106         * DumpRenderTree/chromium/WebViewHost.h:
1107
1108 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
1109
1110         [chromium] move notification related methods to TestRunner
1111         https://bugs.webkit.org/show_bug.cgi?id=107269
1112
1113         Reviewed by Adam Barth.
1114
1115         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1116         (DRTTestRunner::DRTTestRunner):
1117         * DumpRenderTree/chromium/DRTTestRunner.h:
1118         (DRTTestRunner):
1119         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1120         (WebTestDelegate):
1121         (WebTestRunner::WebTestDelegate::grantWebNotificationPermission):
1122         (WebTestRunner::WebTestDelegate::simulateLegacyWebNotificationClick):
1123         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1124         (WebTestRunner::TestRunner::TestRunner):
1125         (WebTestRunner):
1126         (WebTestRunner::TestRunner::grantWebNotificationPermission):
1127         (WebTestRunner::TestRunner::simulateLegacyWebNotificationClick):
1128         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1129         (TestRunner):
1130         * DumpRenderTree/chromium/WebViewHost.cpp:
1131         (WebViewHost::grantWebNotificationPermission):
1132         (WebViewHost::simulateLegacyWebNotificationClick):
1133         * DumpRenderTree/chromium/WebViewHost.h:
1134
1135 2013-01-20  Jochen Eisinger  <jochen@chromium.org>
1136
1137         [chromium] move geolocation related methods to TestRunner
1138         https://bugs.webkit.org/show_bug.cgi?id=107267
1139
1140         Reviewed by Adam Barth.
1141
1142         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1143         (DRTTestRunner::DRTTestRunner):
1144         * DumpRenderTree/chromium/DRTTestRunner.h:
1145         (DRTTestRunner):
1146         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1147         (WebTestRunner::WebTestDelegate::numberOfPendingGeolocationPermissionRequests):
1148         (WebTestRunner::WebTestDelegate::setGeolocationPermission):
1149         (WebTestRunner::WebTestDelegate::setMockGeolocationPosition):
1150         (WebTestRunner::WebTestDelegate::setMockGeolocationPositionUnavailableError):
1151         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1152         (WebTestRunner::TestRunner::TestRunner):
1153         (WebTestRunner::TestRunner::numberOfPendingGeolocationPermissionRequests):
1154         (WebTestRunner):
1155         (WebTestRunner::TestRunner::setGeolocationPermission):
1156         (WebTestRunner::TestRunner::setMockGeolocationPosition):
1157         (WebTestRunner::TestRunner::setMockGeolocationPositionUnavailableError):
1158         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1159         (TestRunner):
1160         * DumpRenderTree/chromium/WebViewHost.cpp:
1161         (WebViewHost::numberOfPendingGeolocationPermissionRequests):
1162         (WebViewHost::setGeolocationPermission):
1163         (WebViewHost::setMockGeolocationPosition):
1164         (WebViewHost::setMockGeolocationPositionUnavailableError):
1165         * DumpRenderTree/chromium/WebViewHost.h:
1166
1167 2013-01-19  Zan Dobersek  <zdobersek@igalia.com>
1168
1169         Unreviewed build fix for Qt WK2 after r140258.
1170         Use the size_t type instead of unsigned for the variable
1171         which holds the position of the first null character in the
1172         console message.
1173
1174         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1175         (WTR::InjectedBundlePage::willAddMessageToConsole):
1176
1177 2013-01-19  Sheriff Bot  <webkit.review.bot@gmail.com>
1178
1179         Unreviewed, rolling out r140260.
1180         http://trac.webkit.org/changeset/140260
1181         https://bugs.webkit.org/show_bug.cgi?id=107387
1182
1183         breaks fast/text/hyphens.html, fast/text/hyphenate-* (but
1184         nothing else) (Requested by thakis__ on #webkit).
1185
1186         * Scripts/update-webkit-chromium:
1187
1188 2013-01-19  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1189
1190         Delegated scrolling: Assertion on attempt to show a CSS sticky element
1191         https://bugs.webkit.org/show_bug.cgi?id=106890
1192
1193         Reviewed by Kenneth Rohde Christiansen.
1194
1195         Enabled fixed layout mode in WTR for 'fast/css/sticky' tests.
1196
1197         * WebKitTestRunner/TestInvocation.cpp:
1198         (WTR::shouldUseFixedLayout):
1199         (WTR):
1200         (WTR::updateLayoutType):
1201
1202 2013-01-19  Nico Weber  <thakis@chromium.org>
1203
1204         Make ninja the default build system for build-webkit --chromium on mac
1205         https://bugs.webkit.org/show_bug.cgi?id=106737
1206
1207         Reviewed by Eric Seidel.
1208
1209         * Scripts/update-webkit-chromium:
1210
1211 2013-01-19  Zan Dobersek  <zdobersek@igalia.com>
1212
1213         [WK2] svg/dom/fuzz-path-parser.html is failing
1214         https://bugs.webkit.org/show_bug.cgi?id=107133
1215
1216         Reviewed by Alexey Proskuryakov.
1217
1218         Console messages can contain null characters before the end of string.
1219         Appending such message to the StringBuilder as a WTFString appends the
1220         complete string, including the null character. This later cuts off everything
1221         after the null character when the string is being printed out to the test
1222         output.
1223
1224         To avoid this, truncate the string up to the first null character. This
1225         preserves the newline character appended immediately after this and
1226         stops giving incorrect output.
1227
1228         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1229         (WTR::InjectedBundlePage::willAddMessageToConsole):
1230
1231 2013-01-19  Eric Seidel  <eric@webkit.org>
1232
1233         Update error regexps so that Parser/html-parser-srcdoc.html can "pass"
1234         https://bugs.webkit.org/show_bug.cgi?id=107367
1235
1236         Reviewed by Ryosuke Niwa.
1237
1238         Using srcdoc instead of document.write changes the error output
1239         ever so slightly.  Clearly we were already trying to ignore these
1240         messages, just not succeeding.  This change makes this new test "pass" correctly.
1241
1242         * Scripts/webkitpy/performance_tests/perftest.py:
1243         (PerfTest):
1244
1245 2013-01-18  Dan Winship  <danw@gnome.org>
1246
1247         REGRESSION (r139071): run-webkit-httpd complains at launch
1248         https://bugs.webkit.org/show_bug.cgi?id=107310
1249
1250         Reviewed by Alexey Proskuryakov.
1251
1252         * Scripts/webkitperl/httpd.pm:
1253         (getApacheVersion): use preferred perl syntax
1254
1255 2013-01-18  Julie Parent  <jparent@chromium.org>
1256
1257         Add back 'group' as a default cross dashboard parameter, but with null as its value.
1258         https://bugs.webkit.org/show_bug.cgi?id=107336
1259
1260         We need to have 'group' listed as a parameter, else we never parse it,
1261         as we only parse parameters with defaults.
1262         
1263         Reviewed by Ojan Vafai.
1264
1265         * TestResultServer/static-dashboards/dashboard_base.js:
1266
1267 2013-01-18  Emil A Eklund  <eae@chromium.org>
1268
1269         Update LayoutUnit rounding unit test
1270         https://bugs.webkit.org/show_bug.cgi?id=107322
1271
1272         Reviewed by Levi Weintraub.
1273         
1274         Update the LayoutUnitRounding test to use fromFloatRound for
1275         values that cannot accurately be represented as a LayoutUnit
1276         (the default behavior is to floor the value to the nearest
1277         LayoutUnit).
1278
1279         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
1280         (TestWebKitAPI::TEST):
1281
1282 2013-01-18  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1283
1284         VCSUtils.pm: Stop calling git repo-config.
1285         https://bugs.webkit.org/show_bug.cgi?id=107294
1286
1287         Reviewed by Dirk Pranke.
1288
1289         The `repo-config' git command has been deprecated since early
1290         2008, and recent versions have started warning it is deprecated.
1291
1292         Basically revert r27870 and use the `config' command all the time.
1293
1294         * Scripts/VCSUtils.pm:
1295         (gitConfig):
1296
1297 2013-01-18  Levi Weintraub  <leviw@chromium.org>
1298
1299         LayoutUnit should round half consistently, not away from zero
1300         https://bugs.webkit.org/show_bug.cgi?id=107208
1301
1302         Reviewed by Eric Seidel.
1303
1304         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp: Updating to reflect and
1305         cover this change in rounding behavior.
1306
1307 2013-01-18  Tim Horton  <timothy_horton@apple.com>
1308
1309         [mac] DumpRenderTree/WebKitTestRunner should not participate in Exposé/Mission Control
1310         https://bugs.webkit.org/show_bug.cgi?id=107234
1311
1312         Reviewed by Simon Fraser.
1313
1314         * DumpRenderTree/mac/DumpRenderTree.mm:
1315         (createWebViewAndOffscreenWindow): Disable participation in Exposé via NSWindowCollectionBehaviorStationary.
1316         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1317         (WTR::PlatformWebView::PlatformWebView): Ditto.
1318
1319 2013-01-18  Tim Horton  <timothy_horton@apple.com>
1320
1321         [mac] DumpRenderTree/WebKitTestRunner should disable NSBeep
1322         https://bugs.webkit.org/show_bug.cgi?id=107251
1323
1324         Reviewed by Simon Fraser.
1325
1326         Disable NSBeep in DumpRenderTree and WebKitTestRunner using NSSound SPI.
1327
1328         * DumpRenderTree/mac/DumpRenderTree.mm:
1329         (dumpRenderTree):
1330         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1331         (WTR::InjectedBundle::platformInitialize):
1332
1333 2013-01-18  Martin Robinson  <mrobinson@igalia.com>
1334
1335         [GTK] Enable indexed database for development builds
1336         https://bugs.webkit.org/show_bug.cgi?id=107299
1337
1338         Reviewed by Gustavo Noronha Silva.
1339
1340         * Scripts/webkitperl/FeatureList.pm: Enable indexed database by default
1341         for GTK+ development builds.
1342
1343 2013-01-18  Dominic Mazzoni  <dmazzoni@google.com>
1344
1345         AX: Improve table-guessing heuristics
1346         https://bugs.webkit.org/show_bug.cgi?id=107042
1347
1348         Reviewed by Chris Fleizach.
1349
1350         Implement parentElementCallback on Chromium to make testing easier.
1351
1352         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1353         (WebTestRunner::AccessibilityUIElement::parentElementCallback):
1354
1355 2013-01-18  Martin Robinson  <mrobinson@igalia.com>
1356
1357         [GTK] Add property for IndexedDB database path to WebKitGTK+
1358         https://bugs.webkit.org/show_bug.cgi?id=106136
1359
1360         Reviewed by Gustavo Noronha Silva.
1361
1362         During testing, set the web database directory to DUMPRENDERTREE_TEMP
1363         before falling back to the old default. This is necessary because
1364         indexed database tests require that each DRT shard is using a different
1365         IDB database location.
1366
1367         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1368         (temporaryDatabaseDirectory): Added this helper for getting the
1369         database directory.
1370         (setDefaultsToConsistentStateValuesForTesting): Use the new helper.
1371
1372 2013-01-18  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1373
1374         [EFL][WK2] Enable API test InjectedBundleFrameHitTest on EFL
1375         https://bugs.webkit.org/show_bug.cgi?id=107264
1376
1377         Reviewed by Laszlo Gombos.
1378
1379         Enable API test InjectedBundleFrameHitTest for hit-testing,
1380         since it is now passing on both Debug and Release builds.
1381
1382         * TestWebKitAPI/CMakeLists.txt:
1383         * TestWebKitAPI/PlatformEfl.cmake:
1384
1385 2013-01-18  Manuel Rego Casasnovas  <rego@igalia.com>
1386
1387         [GTK] Implement TestRunner::addUserScript
1388         https://bugs.webkit.org/show_bug.cgi?id=107275
1389
1390         Reviewed by Philippe Normand.
1391
1392         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1393         (TestRunner::addUserScript): Implement method using
1394         DumpRenderTreeSupportGtk::addUserScript.
1395
1396 2013-01-18  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1397
1398         Unreviewed, add my secondary email address to the list.
1399
1400         * Scripts/webkitpy/common/config/committers.py:
1401
1402 2013-01-18  Dan Carney  <dcarney@google.com>
1403
1404         [chromium] move pointerlock functions to TestRunner library
1405         https://bugs.webkit.org/show_bug.cgi?id=107241
1406
1407         Reviewed by Jochen Eisinger.
1408
1409         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1410         (DRTTestRunner::DRTTestRunner):
1411         * DumpRenderTree/chromium/DRTTestRunner.h:
1412         (DRTTestRunner):
1413         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1414         (WebTestRunner::WebTestDelegate::didAcquirePointerLock):
1415         (WebTestRunner::WebTestDelegate::didNotAcquirePointerLock):
1416         (WebTestRunner::WebTestDelegate::didLosePointerLock):
1417         (WebTestRunner::WebTestDelegate::setPointerLockWillRespondAsynchronously):
1418         (WebTestRunner::WebTestDelegate::setPointerLockWillFailSynchronously):
1419         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1420         (WebTestRunner::TestRunner::TestRunner):
1421         (WebTestRunner):
1422         (WebTestRunner::TestRunner::didAcquirePointerLock):
1423         (WebTestRunner::TestRunner::didNotAcquirePointerLock):
1424         (WebTestRunner::TestRunner::didLosePointerLock):
1425         (WebTestRunner::TestRunner::setPointerLockWillRespondAsynchronously):
1426         (WebTestRunner::TestRunner::setPointerLockWillFailSynchronously):
1427         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1428         (TestRunner):
1429         * DumpRenderTree/chromium/WebViewHost.h:
1430         (WebViewHost):
1431
1432 2013-01-14  Dominik Röttsches  <dominik.rottsches@intel.com>
1433
1434         [EFL] Update freetype in jhbuild to 2.4.11 and activate subpixel layout
1435         https://bugs.webkit.org/show_bug.cgi?id=106774
1436
1437         Reviewed by Martin Robinson.
1438
1439         In order to fix a long standing linespacing/font ascent & descent issue
1440         we found that FreeType commit b0962ac34e660 solves that problem.
1441         Let's update FreeType accordingly, but bump it to 2.4.11 due to the
1442         maintainer recommending several security updates after that said commit.
1443
1444         Also, in order to avoid extra rebaselining, let's activate subpixel
1445         layout at the same time.
1446
1447         * efl/jhbuild.modules: New freetype 2.4.11
1448
1449 2013-01-17  Xiaobo Wang  <xbwang@torchmobile.com.cn>
1450
1451         [BlackBerry] DRT - Accept http/file URL when running drt-launcher from command line
1452         https://bugs.webkit.org/show_bug.cgi?id=107107
1453         PR 282192
1454
1455         Reviewed by Rob Buis.
1456
1457         The DRT application will convert relative/absolute file path to
1458         file://<real-file-path> format, so we only check for http/file prefix.
1459
1460         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1461         (BlackBerry::WebKit::isFullUrl):
1462         (WebKit):
1463         (BlackBerry::WebKit::DumpRenderTree::runCurrentTest):
1464
1465 2013-01-17  Frank Farzan  <frankf@chromium.org>
1466
1467         Flakiness dashboard: Add ChromiumFYI master
1468         https://bugs.webkit.org/show_bug.cgi?id=107180
1469
1470         Reviewed by Ojan Vafai.
1471
1472         This is needed to enable Chrome Android bots
1473         to upload results for instrumentation tests.
1474
1475         * TestResultServer/generate_builders_json.py:
1476         (main):
1477         * TestResultServer/static-dashboards/builders.jsonp:
1478
1479 2013-01-17  Frank Farzan  <frankf@chromium.org>
1480
1481         Add Chrome on Android instrumentation test types to flakiness dashboard
1482         https://bugs.webkit.org/show_bug.cgi?id=106964
1483
1484         Reviewed by Ojan Vafai.
1485
1486         Specifically, add these test types:
1487         
1488          androidwebview_instrumentation_tests
1489          chromiumtestshell_instrumentation_tests
1490          contentshell_instrumentation_tests
1491         
1492         Also, add ChromiumFYI to the list of masters.
1493
1494         * TestResultServer/static-dashboards/builders.js:
1495         (loadBuildersList):
1496         * TestResultServer/static-dashboards/dashboard_base.js:
1497         (currentBuilderGroupCategory):
1498
1499 2013-01-17  Tim 'mithro' Ansell  <mithro@mithis.com>
1500
1501         Fixing webkitpy's SCM unit tests.
1502         https://bugs.webkit.org/show_bug.cgi?id=106429
1503
1504         Reviewed by Eric Seidel.
1505
1506         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
1507         (SCMDetectorTest.test_detect_scm_system):
1508         * Scripts/webkitpy/common/checkout/scm/git.py:
1509         (Git.in_working_directory):
1510         (Git.read_git_config):
1511         (Git._assert_can_squash):
1512         (Git.remote_branch_ref):
1513         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1514         (GitSVNTest.test_commit_with_message_multiple_local_commits_always_squash):
1515         (GitTestWithMock):
1516         (GitTestWithMock.make_scm):
1517         (GitTestWithMock.test_create_patch):
1518         * Scripts/webkitpy/common/system/outputcapture.py:
1519         (OutputCapture.assert_outputs):
1520         (OutputCaptureTestCaseBase):
1521         * Scripts/webkitpy/test/printer.py:
1522         (Printer.configure):
1523
1524 2013-01-17  Julie Parent  <jparent@chromium.org>
1525
1526         Flakiness dashboard assumes there must be ToT tests
1527         https://bugs.webkit.org/show_bug.cgi?id=107155
1528
1529         Remove group as a default parameter, since we can't actually know
1530         the name of a group initially.  Instead, introduces 
1531         currentBuilderGroupName which returns the current builder group
1532         if it has been explicitly set, or picks the first one available
1533         as a default. Allows us to remove some extra code tracking this
1534         stuff as well.
1535         
1536         Reviewed by Ojan Vafai.
1537
1538         * TestResultServer/static-dashboards/dashboard_base.js:
1539         (parseCrossDashboardParameters):
1540         (currentBuilderGroupName):
1541         (currentBuilderGroup):
1542         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1543         (platformAndBuildType):
1544         * TestResultServer/static-dashboards/loader.js:
1545         (.):
1546
1547 2013-01-16  Ryosuke Niwa  <rniwa@webkit.org>
1548
1549         Remove NodeListsNodeData when it's no longer needed
1550         https://bugs.webkit.org/show_bug.cgi?id=107074
1551
1552         Reviewed by Darin Adler.
1553
1554         Generalize the warning a little so that it's also ignored on PerformanceTests/DOM/TraverseChildNodes.html
1555
1556         * Scripts/webkitpy/performance_tests/perftest.py:
1557         (PerfTest):
1558
1559 2013-01-17  Simon Fraser  <simon.fraser@apple.com>
1560
1561         Ref test images are upside-down in WebKit2
1562         https://bugs.webkit.org/show_bug.cgi?id=105457
1563
1564         Reviewed by Sam "Speedy" Weinig.
1565         
1566         The bitmap context created in TestInvocation::dumpPixelsAndCompareWithExpected()
1567         from the window snapshot contained a flipped copy of the image, causing all ref
1568         and pixel images to be upside-down.
1569
1570         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1571         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1572
1573 2013-01-17  Timothy Loh  <timloh@google.com>
1574
1575         Replaced specifiers variable with is_debug in builders.py
1576         https://bugs.webkit.org/show_bug.cgi?id=107057
1577
1578         Reviewed by Dirk Pranke.
1579
1580         Replaced specifiers variable with is_debug in builders.py to simplify
1581         Bug 106259. The other specifiers are not used elsewhere in the code.
1582         Fixed builder_name_for_port_name to return a debug builder if we don't
1583         have a release builder.
1584
1585         * Scripts/webkitpy/layout_tests/port/builders.py:
1586         (all_port_names):
1587         (builder_name_for_port_name):
1588         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1589         (TestRebaselineExpectations.test_rebaseline_expectations):
1590
1591 2013-01-17  Martin Robinson  <mrobinson@igalia.com>
1592
1593         [GTK] Build with LevelDB when IndexedDB is enabled
1594         https://bugs.webkit.org/show_bug.cgi?id=103220
1595
1596         Reviewed by Gustavo Noronha Silva.
1597
1598         * Scripts/webkitpy/style/checker.py: Do not style check the leveldb source code
1599         as it does not conform to WebKit style.
1600
1601 2013-01-17  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1602
1603         [EFL][WK2] Fix misuse of ASSERT on ecore_evas_init()
1604         https://bugs.webkit.org/show_bug.cgi?id=107119
1605
1606         Reviewed by Laszlo Gombos.
1607
1608         Do not use ASSERT on ecore_evas_init(), since the expression inside
1609         the macro compiles out of release builds.
1610
1611         * TestWebKitAPI/PlatformEfl.cmake: Enable API test UserMessage.
1612         * TestWebKitAPI/efl/PlatformWebView.cpp:
1613         (TestWebKitAPI::initEcoreEvas): Remove ASSERT on ecore_evas_init().
1614
1615 2013-01-17  Eugene Klyuchnikov  <eustas@chromium.org>
1616
1617         Web Inspector: Profiler: split "getProfile" to "getCPUProfile" and "loadHeapSnapshot"
1618         https://bugs.webkit.org/show_bug.cgi?id=104545
1619
1620         Reviewed by Yury Semikhatsky.
1621
1622         Adopt signature changes.
1623
1624         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
1625         (ProfilerAgent.getCPUProfile): Renamed.
1626         (ProfilerAgent.getHeapSnapshot): Added.
1627
1628 2013-01-17  Zan Dobersek  <zdobersek@igalia.com>
1629
1630         [GTK][EFL] NWRT should check that Xvfb is installed
1631         https://bugs.webkit.org/show_bug.cgi?id=71767
1632
1633         Reviewed by Dirk Pranke.
1634
1635         EFL and GTK ports now check that Xvfb is installed before running
1636         layout tests. The command line used to check whether Xvfb is present
1637         is a simple `which Xvfb` that should return 0 as the exit code upon
1638         success.
1639
1640         * Scripts/webkitpy/layout_tests/port/efl.py:
1641         (EflPort.show_results_html_file):
1642         (EflPort):
1643         (EflPort.check_sys_deps):
1644         * Scripts/webkitpy/layout_tests/port/gtk.py:
1645         (GtkPort.check_sys_deps):
1646         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
1647         (XvfbDriver):
1648         (XvfbDriver.check_xvfb):
1649
1650 2013-01-16  Alan Cutter  <alancutter@chromium.org>
1651
1652         sheriffbot can't tell me who "kov" is
1653         https://bugs.webkit.org/show_bug.cgi?id=106184
1654
1655         Reviewed by Eric Seidel.
1656
1657         Added glob style searching to the CommitterList contributors_by_search_string function so exact matches are favoured.
1658
1659         * Scripts/webkitpy/common/config/committers.py:
1660         (Account.matches_glob):
1661         (CommitterList.contributors_by_search_string):
1662         * Scripts/webkitpy/common/config/committers_unittest.py:
1663         (CommittersTest.test_committer_lookup):
1664         * Scripts/webkitpy/tool/bot/irc_command.py:
1665         (Whois):
1666
1667 2013-01-16  David Kilzer  <ddkilzer@apple.com>
1668
1669         Use xcrun to find path to make for Mac port
1670         <http://webkit.org/b/107091>
1671
1672         Reviewed by Dan Bernstein.
1673
1674         * Scripts/webkitpy/layout_tests/port/mac.py:
1675         (MacPort._build_java_test_support): Call self.make_command().
1676         (MacPort.make_command): Add.  Call xcrun_find().
1677         (MacPort.nm_command): Use self.xcrun_find().
1678         (MacPort.xcrun_find): Add.  Extract from nm_command().
1679
1680 2013-01-16  Sam Weinig  <sam@webkit.org>
1681
1682         Make debug-safari --target-web-process work again
1683         https://bugs.webkit.org/show_bug.cgi?id=107088
1684
1685         Reviewed by Anders Carlsson.
1686
1687         * Scripts/webkitdirs.pm:
1688         (execMacWebKitAppForDebugging):
1689         The shim is now called SecItemShim.
1690
1691 2013-01-16  Alan Cutter  <alancutter@chromium.org>
1692
1693         GCE build scripts don't take working directory into account when calling findzone.sh
1694         https://bugs.webkit.org/show_bug.cgi?id=106962
1695
1696         Reviewed by Adam Barth.
1697
1698         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
1699         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
1700         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
1701
1702 2013-01-16  Alan Cutter  <alancutter@chromium.org>
1703
1704         start-queue.sh does not pass remaining parameters correctly
1705         https://bugs.webkit.org/show_bug.cgi?id=107054
1706
1707         Reviewed by Adam Barth.
1708
1709         start-queue.sh now passes all remaining params to the webkit-patch command.
1710         Previously only one additional queue parameter could be sent.
1711
1712         * EWSTools/start-queue.sh:
1713
1714 2013-01-16  Xueqing Huang  <huangxueqing@baidu.com>
1715
1716         check-webkit-style script cannot running in Chinese windows.
1717         https://bugs.webkit.org/show_bug.cgi?id=87548
1718
1719         Reviewed by Darin Adler.
1720
1721         * Scripts/webkitpy/common/system/platforminfo.py:
1722         (PlatformInfo._win_version_tuple_from_cmd):
1723
1724 2013-01-16  Dirk Pranke  <dpranke@chromium.org>
1725
1726         Delete an extraneous print statement.
1727         https://bugs.webkit.org/show_bug.cgi?id=106562
1728
1729         Delete the extraneous print statement introduced in r139841.
1730
1731         * Scripts/webkitpy/layout_tests/views/printing.py:
1732         (Printer.print_found):
1733
1734 2013-01-16  Zan Dobersek  <zdobersek@igalia.com>
1735
1736         Please reinstate --pixel
1737         https://bugs.webkit.org/show_bug.cgi?id=101995
1738
1739         Reviewed by Dirk Pranke.
1740
1741         Add the '--pixel' and '--no-pixel' options for NRWT as aliases for
1742         the '--pixel-tests' (or '-p') and '--no-pixel-tests' options respectively.
1743         Some developers are still used to these options that were available in the ORWT.
1744
1745         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1746         (parse_args):
1747
1748 2013-01-16  Eric Seidel  <eric@webkit.org>
1749
1750         Remove --shark* support from sunspider/run-sunspider now that Shark is dead
1751         https://bugs.webkit.org/show_bug.cgi?id=99512
1752
1753         Reviewed by Darin Adler.
1754
1755         * Scripts/run-sunspider:
1756
1757 2013-01-16  Eric Seidel  <eric@webkit.org>
1758
1759         Remove webkitpy Visual Studio files, as core developers are not interested in maintaining them
1760         https://bugs.webkit.org/show_bug.cgi?id=106036
1761
1762         Reviewed by Darin Adler.
1763
1764         * Scripts/webkitpy/webkitpy.pyproj: Removed.
1765         * Scripts/webkitpy/webkitpy.sln: Removed.
1766
1767 2013-01-16  Chris Hopman  <cjhopman@chromium.org>
1768
1769         [Chromium] Remove hardcoded chromium_*.jar in gyp files
1770         https://bugs.webkit.org/show_bug.cgi?id=104049
1771
1772         Reviewed by Eric Seidel.
1773
1774         Targets with dependencies (direct/indirect) on a java target receive
1775         the chromium_*.jar paths in the variable input_jars_paths. Targets
1776         should use that rather than hardcoding where they think the jar will
1777         be. These can be passed directly to ant as INPUT_JARS_PATHS rather
1778         than as --jars to generate_native_test.py.
1779
1780         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1781         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1782
1783 2013-01-16  Dan Carney  <dcarney@google.com>
1784
1785         [chromium] move setMockDeviceOrientation to TestRunner library
1786         https://bugs.webkit.org/show_bug.cgi?id=106895
1787
1788         Reviewed by Jochen Eisinger.
1789
1790         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1791         (DRTTestRunner::DRTTestRunner):
1792         * DumpRenderTree/chromium/DRTTestRunner.h:
1793         (DRTTestRunner):
1794         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1795         (WebKit):
1796         (WebTestRunner::WebTestDelegate::setDeviceOrientation):
1797         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1798         (WebTestRunner::TestRunner::TestRunner):
1799         (WebTestRunner::TestRunner::setMockDeviceOrientation):
1800         (WebTestRunner):
1801         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1802         (TestRunner):
1803         * DumpRenderTree/chromium/WebViewHost.cpp:
1804         (WebViewHost::setDeviceOrientation):
1805         * DumpRenderTree/chromium/WebViewHost.h:
1806         (WebViewHost):
1807
1808 2013-01-16  Jochen Eisinger  <jochen@chromium.org>
1809
1810         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
1811         https://bugs.webkit.org/show_bug.cgi?id=106904
1812
1813         Reviewed by Adam Barth.
1814
1815         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1816         (DRTTestRunner::DRTTestRunner):
1817         (DRTTestRunner::notifyDone):
1818         (DRTTestRunner::reset):
1819         * DumpRenderTree/chromium/DRTTestRunner.h:
1820         (DRTTestRunner):
1821         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1822         (WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
1823         (WebTestRunner::WebTestDelegate::setFocus):
1824         (WebTestRunner::WebTestDelegate::setAcceptAllCookies):
1825         (WebTestRunner::WebTestDelegate::pathToLocalResource):
1826         (WebTestRunner::WebTestDelegate::setLocale):
1827         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1828         (WebTestRunner::TestRunner::TestRunner):
1829         (WebTestRunner::TestRunner::reset):
1830         (WebTestRunner::TestRunner::setAlwaysAcceptCookies):
1831         (WebTestRunner):
1832         (WebTestRunner::TestRunner::setWindowIsKey):
1833         (WebTestRunner::TestRunner::pathToLocalResource):
1834         (WebTestRunner::TestRunner::setBackingScaleFactor):
1835         (WebTestRunner::TestRunner::setPOSIXLocale):
1836         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1837         (WebTestRunner::TestRunner::taskList):
1838         (TestRunner):
1839         * DumpRenderTree/chromium/WebViewHost.cpp:
1840         (WebViewHost::setDeviceScaleFactor):
1841         (WebViewHost::setFocus):
1842         (WebViewHost::setAcceptAllCookies):
1843         (WebViewHost::pathToLocalResource):
1844         (WebViewHost::setLocale):
1845         * DumpRenderTree/chromium/WebViewHost.h:
1846         (WebViewHost):
1847
1848 2013-01-16  Sergio Villar Senin  <svillar@igalia.com>
1849
1850         [GTK] build-webkit fails if the jhbuild wrapper is not used
1851         https://bugs.webkit.org/show_bug.cgi?id=106769
1852
1853         Reviewed by Martin Robinson.
1854
1855         Return an empty array instead of "" in
1856         jhbuildWrapperPrefixIfNeeded() because otherwise that empty string
1857         will not be recognized as a valid command when the returned array
1858         is directly passed to perl's system() call.
1859
1860         * Scripts/webkitdirs.pm:
1861         (jhbuildWrapperPrefixIfNeeded):
1862
1863 2013-01-16  Jochen Eisinger  <jochen@chromium.org>
1864
1865         [chromium] add title text direction attribute to TestRunner
1866         https://bugs.webkit.org/show_bug.cgi?id=106907
1867
1868         Reviewed by Adam Barth.
1869
1870         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1871         (DRTTestRunner::DRTTestRunner):
1872         (DRTTestRunner::reset):
1873         * DumpRenderTree/chromium/DRTTestRunner.h:
1874         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1875         (WebTestRunner::WebTestRunner::setTitleTextDirection):
1876         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1877         (WebTestRunner::TestRunner::TestRunner):
1878         (WebTestRunner::TestRunner::reset):
1879         (WebTestRunner::TestRunner::setTitleTextDirection):
1880         (WebTestRunner):
1881         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1882         (TestRunner):
1883         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1884         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
1885         * DumpRenderTree/chromium/WebViewHost.cpp:
1886         (WebViewHost::didReceiveTitle):
1887
1888 2013-01-16  Jussi Kukkonen  <jussi.kukkonen@intel.com>
1889
1890         NRWT still confused about test count with --repeat-each and --iterations
1891         https://bugs.webkit.org/show_bug.cgi?id=106562
1892
1893         Reviewed by Dirk Pranke.
1894
1895         Fix the printed unique test count and skipped count. This
1896         seems to have broken in r127688 ("NRWT lies about the number
1897         of tests that it's skipping when used with --repeat-each").
1898
1899         Also add a test for print_found()
1900
1901         * Scripts/webkitpy/layout_tests/views/printing.py:
1902         (Printer.print_found):
1903         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1904         (Testprinter.test_details):
1905         (Testprinter):
1906         (Testprinter.test_found):
1907
1908 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
1909
1910         Unreviewed follow-up to r139769.
1911
1912         Note that omitting the WebKit1 code from the build now
1913         works for GTK as well.
1914
1915         * Scripts/build-webkit:
1916
1917 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
1918
1919         test-webkitpy: truncate output to the terminal width when necessary
1920         https://bugs.webkit.org/show_bug.cgi?id=106973
1921
1922         Reviewed by Ojan Vafai.
1923
1924         this implements the same logic for test-webkitpy that we have
1925         for run-webkit-tests (and ninja).
1926
1927         No tests written as this is exercised by running test-webkitpy itself.
1928
1929         * Scripts/webkitpy/test/printer.py:
1930         (Printer.configure):
1931         (Printer._test_line):
1932
1933 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
1934
1935         remove extraneous output in test-webkitpy
1936         https://bugs.webkit.org/show_bug.cgi?id=106971
1937
1938         Reviewed by Ojan Vafai.
1939
1940         We weren't ignoring or capturing the echoed output from
1941         these two tests, and getting noise in the logs as a result.
1942
1943         * Scripts/webkitpy/common/system/executive_unittest.py:
1944         (ExecutiveTest.test_auto_stringify_args):
1945         (ExecutiveTest.test_popen_args):
1946
1947 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
1948
1949         webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer.test_win32_start_and_stop is flaky
1950         https://bugs.webkit.org/show_bug.cgi?id=106974
1951
1952         Reviewed by Ryosuke Niwa.
1953
1954         I forgot to stub out the call to check to ensure that the ports were
1955         available, so this test could fail if something was listening on 8000 or
1956         8443 on the machine.
1957
1958         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1959         (TestHttpServer.test_win32_start_and_stop):
1960
1961 2013-01-15  Levi Weintraub  <leviw@chromium.org>
1962
1963         Unreviewed, rolling out r139792.
1964         http://trac.webkit.org/changeset/139792
1965         https://bugs.webkit.org/show_bug.cgi?id=106970
1966
1967         Broke the windows build.
1968
1969         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1970         (DRTTestRunner::DRTTestRunner):
1971         (DRTTestRunner::notifyDone):
1972         (DRTTestRunner::reset):
1973         (DRTTestRunner::setAlwaysAcceptCookies):
1974         (DRTTestRunner::setWindowIsKey):
1975         (DRTTestRunner::pathToLocalResource):
1976         (DRTTestRunner::setPOSIXLocale):
1977         (InvokeCallbackTask):
1978         (InvokeCallbackTask::InvokeCallbackTask):
1979         (InvokeCallbackTask::runIfValid):
1980         (DRTTestRunner::setBackingScaleFactor):
1981         * DumpRenderTree/chromium/DRTTestRunner.h:
1982         (DRTTestRunner):
1983         (DRTTestRunner::taskList):
1984         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1985         (WebTestRunner::WebTestDelegate::setDatabaseQuota):
1986         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1987         (WebTestRunner::TestRunner::TestRunner):
1988         (WebTestRunner::TestRunner::reset):
1989         (WebTestRunner::TestRunner::setDatabaseQuota):
1990         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1991         (TestRunner):
1992         * DumpRenderTree/chromium/WebViewHost.cpp:
1993         (WebViewHost::setPendingExtraData):
1994         (WebViewHost::setDeviceScaleFactor):
1995         * DumpRenderTree/chromium/WebViewHost.h:
1996         (WebViewHost):
1997
1998 2013-01-15  Ryosuke Niwa  <rniwa@webkit.org>
1999
2000         Build fix after r139357. The port name of MacWK2EWS should be 'mac-wk2'.
2001
2002         * Scripts/webkitpy/common/config/ports.py:
2003         (MacWK2Port):
2004
2005 2013-01-15  Alan Cutter  <alancutter@chromium.org>
2006
2007         Extend sheriffbot's "help" command to be able to get help on individual commands
2008         https://bugs.webkit.org/show_bug.cgi?id=106629
2009
2010         Reviewed by Eric Seidel.
2011
2012         Added a help command to sheriffbot.
2013         Fixed some style issues and ordered the commands alphabetically.
2014
2015         * Scripts/webkitpy/tool/bot/irc_command.py:
2016         (IRCCommand):
2017         (IRCCommand.execute):
2018         (IRCCommand.usage):
2019         (IRCCommand.help):
2020         (CreateBug):
2021         (CreateBug.execute):
2022         (Help):
2023         (Help.execute):
2024         (Help._post_command_help):
2025         (Hi):
2026         (Hi.execute):
2027         (Restart):
2028         (RollChromiumDEPS):
2029         (RollChromiumDEPS._parse_args):
2030         (RollChromiumDEPS._expand_irc_nickname):
2031         (RollChromiumDEPS.execute):
2032         (Rollout):
2033         (Rollout._extract_revisions):
2034         (Rollout.execute):
2035         (Sheriffs):
2036         (Sheriffs.execute):
2037         (Whois):
2038         (Whois.execute):
2039         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
2040         (IRCBotTest.test_help):
2041
2042 2013-01-15  Enrica Casucci  <enrica@apple.com>
2043
2044         Add a new set of WebKit2 APIs for text search and
2045         search results management.
2046         https://bugs.webkit.org/show_bug.cgi?id=106834.
2047         <rdar://problem/12597159>
2048
2049         Added new test for the new WebKit2 API for
2050         text search.
2051         
2052         Reviewed by Simon Fraser.
2053
2054         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2055         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm: Added.
2056
2057 2013-01-15  Levi Weintraub  <leviw@chromium.org>
2058
2059         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
2060         https://bugs.webkit.org/show_bug.cgi?id=106904
2061
2062         Reverting 139794. It broke the build. It appears that a header file,
2063         WebTextDirection.h, was left out.
2064
2065         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2066         (DRTTestRunner::DRTTestRunner):
2067         (DRTTestRunner::reset):
2068         * DumpRenderTree/chromium/DRTTestRunner.h:
2069         (DRTTestRunner::setTitleTextDirection):
2070         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2071         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
2072         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2073         (WebTestRunner::TestRunner::TestRunner):
2074         (WebTestRunner::TestRunner::reset):
2075         (WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
2076         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2077         (TestRunner):
2078         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2079         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
2080         * DumpRenderTree/chromium/WebViewHost.cpp:
2081         (WebViewHost::didReceiveTitle):
2082
2083 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
2084
2085         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
2086         https://bugs.webkit.org/show_bug.cgi?id=106904
2087
2088         Reviewed by Adam Barth.
2089
2090         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2091         (DRTTestRunner::DRTTestRunner):
2092         (DRTTestRunner::notifyDone):
2093         (DRTTestRunner::reset):
2094         * DumpRenderTree/chromium/DRTTestRunner.h:
2095         (DRTTestRunner):
2096         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2097         (WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
2098         (WebTestRunner::WebTestDelegate::setFocus):
2099         (WebTestRunner::WebTestDelegate::setAcceptAllCookies):
2100         (WebTestRunner::WebTestDelegate::pathToLocalResource):
2101         (WebTestRunner::WebTestDelegate::setLocale):
2102         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2103         (WebTestRunner::TestRunner::TestRunner):
2104         (WebTestRunner::TestRunner::reset):
2105         (WebTestRunner::TestRunner::setAlwaysAcceptCookies):
2106         (WebTestRunner):
2107         (WebTestRunner::TestRunner::setWindowIsKey):
2108         (WebTestRunner::TestRunner::pathToLocalResource):
2109         (WebTestRunner::TestRunner::setBackingScaleFactor):
2110         (WebTestRunner::TestRunner::setPOSIXLocale):
2111         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2112         (WebTestRunner::TestRunner::taskList):
2113         (TestRunner):
2114         * DumpRenderTree/chromium/WebViewHost.cpp:
2115         (WebViewHost::setDeviceScaleFactor):
2116         (WebViewHost::setFocus):
2117         (WebViewHost::setAcceptAllCookies):
2118         (WebViewHost::pathToLocalResource):
2119         (WebViewHost::setLocale):
2120         * DumpRenderTree/chromium/WebViewHost.h:
2121         (WebViewHost):
2122
2123 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
2124
2125         Tests with WontFix expectation are (indirectly) skipped
2126         https://bugs.webkit.org/show_bug.cgi?id=105860
2127
2128         Reviewed by Dirk Pranke.
2129
2130         Only skip the WontFix expectation if there are no other layout test
2131         expectations (like Failure, ImageOnlyFailure) listed for the test.
2132         This makes it possible to run an expected failure for which there
2133         is no reason or interest to fix. There are some ports that would like
2134         to exercise this behavior as well as specific test cases that should use
2135         such expectations.
2136
2137         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2138         (TestExpectationParser._tokenize_line): Only add the SKIP modifier for a
2139         WONTFIX test if there are no expectations listed. The warning is adjusted
2140         to reflect the new behavior.
2141         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Add
2142         and adjust test cases for these changes.
2143         (ExpectationSyntaxTests.test_wontfix):
2144         (SemanticTests.test_skip_and_wontfix):
2145
2146 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
2147
2148         [chromium] add title text direction attribute to TestRunner
2149         https://bugs.webkit.org/show_bug.cgi?id=106907
2150
2151         Reviewed by Adam Barth.
2152
2153         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2154         (DRTTestRunner::DRTTestRunner):
2155         (DRTTestRunner::reset):
2156         * DumpRenderTree/chromium/DRTTestRunner.h:
2157         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2158         (WebTestRunner::WebTestRunner::setTitleTextDirection):
2159         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2160         (WebTestRunner::TestRunner::TestRunner):
2161         (WebTestRunner::TestRunner::reset):
2162         (WebTestRunner::TestRunner::setTitleTextDirection):
2163         (WebTestRunner):
2164         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2165         (TestRunner):
2166         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2167         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
2168         * DumpRenderTree/chromium/WebViewHost.cpp:
2169         (WebViewHost::didReceiveTitle):
2170
2171 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
2172
2173         nrwt: change the default # of locked shards on chromium_win to 1
2174         https://bugs.webkit.org/show_bug.cgi?id=106938
2175
2176         Reviewed by Eric Seidel.
2177
2178         It looks like LigHTTPd might be buggy or unstable if we are
2179         running multiple http tests in parallel; see
2180         http://code.google.com/p/chromium/issues/detail?id=169530 for more
2181         context as well. This change will stop running http tests in parallel
2182         and we can see if this fixes things.
2183
2184         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2185         (ChromiumWinPort.default_max_locked_shards):
2186         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2187         (ChromiumWinTest.test_path_to_image_diff):
2188         (ChromiumWinTest):
2189         (ChromiumWinTest.test_default_max_locked_shards):
2190
2191 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
2192
2193         [chromium] move WebDatabase related methods to TestRunner library
2194         https://bugs.webkit.org/show_bug.cgi?id=106905
2195
2196         Reviewed by Adam Barth.
2197
2198         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2199         (DRTTestRunner::DRTTestRunner):
2200         (DRTTestRunner::reset):
2201         * DumpRenderTree/chromium/DRTTestRunner.h:
2202         (DRTTestRunner):
2203         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2204         (WebTestRunner::WebTestDelegate::clearAllDatabases):
2205         (WebTestRunner::WebTestDelegate::setDatabaseQuota):
2206         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2207         (WebTestRunner::TestRunner::TestRunner):
2208         (WebTestRunner::TestRunner::reset):
2209         (WebTestRunner::TestRunner::clearAllDatabases):
2210         (WebTestRunner):
2211         (WebTestRunner::TestRunner::setDatabaseQuota):
2212         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2213         (TestRunner):
2214         * DumpRenderTree/chromium/WebViewHost.cpp:
2215         (WebViewHost::clearAllDatabases):
2216         (WebViewHost::setDatabaseQuota):
2217         * DumpRenderTree/chromium/WebViewHost.h:
2218         (WebViewHost):
2219
2220 2013-01-15  Tim 'mithro' Ansell  <mithro@mithis.com>
2221
2222         Renaming CleanWorkingDirectory step to DiscardLocalChanges to make
2223         functionality match the name.
2224         https://bugs.webkit.org/show_bug.cgi?id=106870
2225
2226         Reviewed by Adam Barth.
2227
2228         * Scripts/webkitpy/tool/commands/download.py:
2229         (Clean):
2230         (Update):
2231         (Build):
2232         (BuildAndTest):
2233         (CheckStyle):
2234         (BuildAttachment):
2235         (BuildAndTestAttachment):
2236         (AbstractPatchApplyingCommand):
2237         (ApplyWatchList):
2238         (AbstractPatchLandingCommand):
2239         (CreateRollout):
2240         * Scripts/webkitpy/tool/steps/__init__.py:
2241         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2242         (CleanWorkingDirectory.options):
2243         (CleanWorkingDirectory.run):
2244         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
2245         * Scripts/webkitpy/tool/steps/discardlocalchanges.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
2246         * Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py.
2247
2248 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
2249
2250         [Autotools] Add support for WebKit2-only builds
2251         https://bugs.webkit.org/show_bug.cgi?id=106889
2252
2253         Reviewed by Gustavo Noronha Silva.
2254
2255         * GNUmakefile.am: Only build the GtkLauncher and DumpRenderTree if building WebKit1.
2256         * Scripts/build-webkit: Pass along the information on whether to build WebKit1 when
2257         building the GTK port through build-webkit.
2258         * Scripts/webkitdirs.pm:
2259         (buildAutotoolsProject): Add the --disable-webkit1 configuration flag to the build
2260         arguments when not building WebKit1.
2261         (buildGtkProject): Pass along the information on whether to build WebKit1 when building
2262         through the Autotools build system.
2263
2264 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
2265
2266         [GTK] Enable Performance Timeline, Resource Timing, Navigation Timing features
2267         https://bugs.webkit.org/show_bug.cgi?id=106197
2268
2269         Reviewed by Martin Robinson.
2270
2271         * Scripts/webkitperl/FeatureList.pm: Add the configuration options for all three
2272         features. Enable them on GTK, meaning they will be enabled in development builds
2273         (i.e. when building with build-webkit).
2274
2275 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
2276
2277         [GTK] Enable CSS Image Resolution feature
2278         https://bugs.webkit.org/show_bug.cgi?id=99038
2279
2280         Reviewed by Gustavo Noronha Silva.
2281
2282         Enable the CSS Image Resolution feature for the development
2283         builds of the GTK port.
2284
2285         * Scripts/webkitperl/FeatureList.pm:
2286
2287 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
2288
2289         [GTK] Stop passing the unstable features flag to configure script when using build-webkit
2290         https://bugs.webkit.org/show_bug.cgi?id=106579
2291
2292         Reviewed by Gustavo Noronha Silva.
2293
2294         The --enable-unstable-features flag is not required to be passed anymore
2295         to the configure script as it was removed in r138252.
2296
2297         * Scripts/webkitdirs.pm:
2298         (buildAutotoolsProject):
2299
2300 2013-01-15  Tony Chang  <tony@chromium.org>
2301
2302         [chromium] Unreviewed, fix a bug where we don't properly shutdown lighttpd.
2303
2304         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2305         (Lighttpd._check_and_kill): Pass /pid so taskkill.exe doesn't error out on us.
2306         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2307         (TestHttpServer.test_win32_start_and_stop):
2308
2309 2013-01-15  Joshua Bell  <jsbell@chromium.org>
2310
2311         Unreviewed. Adding Michael Pruett as contributor.
2312
2313         * Scripts/webkitpy/common/config/committers.py:
2314
2315 2013-01-15  Victor Carbune  <victor@rosedu.org>
2316
2317         Unreviewed. Update my email addresses.
2318
2319         * Scripts/webkitpy/common/config/committers.py:
2320
2321 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
2322
2323         [GTK] Waiting on the gdb process will lead to deadlock
2324         https://bugs.webkit.org/show_bug.cgi?id=106906
2325
2326         Reviewed by Philippe Normand.
2327
2328         Use communicate() rather than wait() on the Popen object that's running the gdb
2329         command. This avoids the deadlock that occurs on the GTK builders.
2330
2331         * Scripts/webkitpy/layout_tests/port/gtk.py:
2332         (GtkPort._get_gdb_output):
2333
2334 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
2335
2336         [GTK] Limit the number of frames printed out when backtracing with gdb
2337         https://bugs.webkit.org/show_bug.cgi?id=106901
2338
2339         Reviewed by Philippe Normand.
2340
2341         Printing an unlimited number of frames when dumping the gdb backtracing
2342         output can cause timeouts in the builders. This patch limits the number
2343         of frames that are printed out to 1024.
2344
2345         * Scripts/webkitpy/layout_tests/port/gtk.py:
2346         (GtkPort._get_gdb_output):
2347
2348 2013-01-15  Andras Becsi  <andras.becsi@digia.com>
2349
2350         [Qt] Fix ImageDiff's image format conversion
2351         https://bugs.webkit.org/show_bug.cgi?id=106880
2352
2353         Reviewed by Csaba Osztrogonác.
2354
2355         Besides actually doing the conversion this also silences the suspicious warning:
2356         "ignoring return value of function declared with warn_unused_result attribute".
2357
2358         * ImageDiff/qt/ImageDiff.cpp:
2359         (main): QImage::convertToFormat, contrary to the assumed behaviour, returns a
2360         copy of the image in the given format and does not alter the image itself.
2361
2362 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
2363
2364         [chromium] move remaining methods that just set a boolean flag to TestRunner library
2365         https://bugs.webkit.org/show_bug.cgi?id=106823
2366
2367         Reviewed by Darin Fisher.
2368
2369         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2370         (DRTTestRunner::DRTTestRunner):
2371         (DRTTestRunner::reset):
2372         * DumpRenderTree/chromium/DRTTestRunner.h:
2373         (DRTTestRunner):
2374         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2375         (WebTestRunner::WebTestRunner::shouldDumpBackForwardList):
2376         (WebTestRunner::WebTestRunner::deferMainResourceDataLoad):
2377         (WebTestRunner::WebTestRunner::shouldDumpSelectionRect):
2378         (WebTestRunner::WebTestRunner::testRepaint):
2379         (WebTestRunner::WebTestRunner::sweepHorizontally):
2380         (WebTestRunner::WebTestRunner::isPrinting):
2381         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
2382         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2383         (WebTestRunner::TestRunner::TestRunner):
2384         (WebTestRunner::TestRunner::reset):
2385         (WebTestRunner::TestRunner::shouldDumpBackForwardList):
2386         (WebTestRunner):
2387         (WebTestRunner::TestRunner::deferMainResourceDataLoad):
2388         (WebTestRunner::TestRunner::shouldDumpSelectionRect):
2389         (WebTestRunner::TestRunner::testRepaint):
2390         (WebTestRunner::TestRunner::sweepHorizontally):
2391         (WebTestRunner::TestRunner::isPrinting):
2392         (WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
2393         (WebTestRunner::TestRunner::dumpBackForwardList):
2394         (WebTestRunner::TestRunner::setDeferMainResourceDataLoad):
2395         (WebTestRunner::TestRunner::dumpSelectionRect):
2396         (WebTestRunner::TestRunner::repaintSweepHorizontally):
2397         (WebTestRunner::TestRunner::setPrinting):
2398         (WebTestRunner::TestRunner::setShouldStayOnPageAfterHandlingBeforeUnload):
2399         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2400         (TestRunner):
2401
2402 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
2403
2404         nrwt: stub out show_results_html for mock ports
2405         https://bugs.webkit.org/show_bug.cgi?id=106848
2406
2407         Reviewed by Ojan Vafai.
2408
2409         We were accidentally using the underlying ports'
2410         show_results_html_file() implementation, which would, unsurprisingly,
2411         fail in many cases (e.g., running mock-efl on the mac).
2412
2413         No test added since we don't generally add tests for the mock
2414         implementation.
2415
2416         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2417         (MockDRTPort.show_results_html_file):
2418
2419 2013-01-14  Tim 'mithro' Ansell  <mithro@mithis.com>
2420
2421         Changing clean_working_directory/clean_local_commits and related
2422         functions to have consistent naming.
2423
2424         https://bugs.webkit.org/show_bug.cgi?id=104198
2425
2426         Reviewed by Adam Barth.
2427
2428         * Scripts/webkitpy/common/checkout/scm/git.py:
2429         * Scripts/webkitpy/common/checkout/scm/scm.py:
2430         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2431         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2432         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2433         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
2434
2435 2013-01-14  Alan Cutter  <alancutter@chromium.org>
2436
2437         Fix EWS GCE build scripts to detect which zone is available
2438         https://bugs.webkit.org/show_bug.cgi?id=106524
2439
2440         Reviewed by Adam Barth.
2441
2442         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
2443         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
2444         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
2445         * EWSTools/GoogleComputeEngine/findzone.sh: Added.
2446
2447 2013-01-14  Tim 'mithro' Ansell  <mithro@mithis.com>
2448
2449         Adding an error string to AmbiguousCommitError.
2450         https://bugs.webkit.org/show_bug.cgi?id=106846
2451
2452         Reviewed by Adam Barth.
2453
2454         * Scripts/webkitpy/common/checkout/scm/git.py:
2455         (AmbiguousCommitError.__init__):
2456
2457 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
2458
2459         kill whole lighttpd process tree for chromium win
2460         https://bugs.webkit.org/show_bug.cgi?id=106838
2461
2462         Reviewed by Tony Chang.
2463
2464         Land a speculative fix for lighttpd.exe hanging on some chromium bots;
2465         I think a test is causing a httpd server child process to wedge and
2466         killing the parent httpd server process isn't sufficient to ensure
2467         that the children are also killed.
2468
2469         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2470         (Lighttpd._check_and_kill):
2471         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2472         (TestHttpServer.test_start_cmd):
2473         (TestHttpServer):
2474         (TestHttpServer.test_win32_start_and_stop):
2475         (TestHttpServer.test_win32_start_and_stop.wait_for_action):
2476         (TestHttpServer.test_win32_start_and_stop.mock_returns):
2477         (TestHttpServer.test_win32_start_and_stop.mock_returns.return_value_thunk):
2478
2479 2013-01-14  Nico Weber  <thakis@chromium.org>
2480
2481         [chromium] Enable `update-webkit --chromium --ninja` on windows
2482         https://bugs.webkit.org/show_bug.cgi?id=106836
2483
2484         Reviewed by Eric Seidel.
2485
2486         After running this, build-webkit --chromium will use ninja to build.
2487         Apparently there are some minor issues with that still, so it's
2488         not quite ready for use yet.
2489
2490         * Scripts/webkitdirs.pm:
2491         (determineIsChromiumNinja):
2492         (buildChromium):
2493
2494 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
2495
2496         nrwt: use the same search path for baselines and TestExpectations on apple mac
2497         https://bugs.webkit.org/show_bug.cgi?id=105599
2498
2499         Reviewed by Ryosuke Niwa.
2500
2501         Bug 105583 revealed some confusion due to the fact that the Apple
2502         Mac port used a different list of directories to search for baselines
2503         and TestExpectations files (actually, pretty much every port does).
2504
2505         It seems like a good idea to use the same list for both by default, but
2506         making this happen will affect every port in slightly different ways, so
2507         we'll try this on the Apple Mac port first.
2508
2509         Note that the effective changes for this are that:
2510         1) The apple mac port will look in platform/wk2 for baselines where
2511         it didn't before (it will look after looking in mac-wk2 but before
2512         the non-wk2 dirs)
2513         2) The apple mac-snowleopard port will use the expectations in
2514         mac-lion as well as the expectations in mac-snowleopard, although
2515         I'm not even sure if mac-snowleopard is still supported ...
2516
2517         * Scripts/webkitpy/layout_tests/port/mac.py:
2518         (MacPort.default_baseline_search_path):
2519         (MacPort.expectations_files):
2520         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2521         (test_baseline_search_path):
2522
2523 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
2524
2525         AX: Need to implement ColorWellRole
2526         https://bugs.webkit.org/show_bug.cgi?id=106756
2527
2528         Reviewed by Chris Fleizach.
2529
2530         Returns a string representation of the value of a color
2531         when the role is Color Well, to make it easy to write layout
2532         tests for color controls.
2533
2534         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2535
2536 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
2537
2538         Chromium: Error in AccessibilityUIElement::intValueGetterCallback
2539         https://bugs.webkit.org/show_bug.cgi?id=106682
2540
2541         Reviewed by Chris Fleizach.
2542
2543         Modify Chromium's DRT implementation of intValue to return a
2544         different value depending on the role.
2545
2546         There are actually platform-specific differences in what should
2547         be returned in the "value" of an object, so Chromium normally keeps
2548         these separate (i.e. valueForRange, headingLevel, hierarchicalLevel, etc.)
2549         but this is a fine simplification to make cross-platform tests easier.
2550
2551         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2552         (WebTestRunner::AccessibilityUIElement::intValueGetterCallback):
2553
2554 2013-01-14  Jochen Eisinger  <jochen@chromium.org>
2555
2556         [chromium] move remaining methods to dump WebViewClient callbacks to TestRunner library
2557         https://bugs.webkit.org/show_bug.cgi?id=106785
2558
2559         Reviewed by Adam Barth.
2560
2561         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2562         (DRTTestRunner::DRTTestRunner):
2563         (DRTTestRunner::reset):
2564         * DumpRenderTree/chromium/DRTTestRunner.h:
2565         (DRTTestRunner):
2566         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2567         (WebTestProxyBase):
2568         (WebTestRunner::WebTestProxy::setStatusText):
2569         (WebTestRunner::WebTestProxy::didStopLoading):
2570         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2571         (WebTestRunner::WebTestRunner::shouldDumpStatusCallbacks):
2572         (WebTestRunner::WebTestRunner::shouldDumpProgressFinishedCallback):
2573         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2574         (WebTestRunner::TestRunner::TestRunner):
2575         (WebTestRunner::TestRunner::reset):
2576         (WebTestRunner::TestRunner::shouldDumpStatusCallbacks):
2577         (WebTestRunner):
2578         (WebTestRunner::TestRunner::shouldDumpProgressFinishedCallback):
2579         (WebTestRunner::TestRunner::dumpWindowStatusChanges):
2580         (WebTestRunner::TestRunner::dumpProgressFinishedCallback):
2581         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2582         (TestRunner):
2583         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2584         (WebTestRunner::WebTestProxyBase::setStatusText):
2585         (WebTestRunner):
2586         (WebTestRunner::WebTestProxyBase::didStopLoading):
2587         * DumpRenderTree/chromium/WebViewHost.cpp:
2588         (WebViewHost::didStopLoading):
2589         * DumpRenderTree/chromium/WebViewHost.h:
2590         (WebViewHost):
2591
2592 2013-01-14  Andrey Lushnikov  <lushnikov@chromium.org>
2593
2594         Web Inspector: devtools front-end doesn't have focus in TestShell
2595         https://bugs.webkit.org/show_bug.cgi?id=106778
2596
2597         Reviewed by Pavel Feldman.
2598
2599         Focus devTools window after loadURL method.
2600
2601         * DumpRenderTree/chromium/TestShell.cpp:
2602         (TestShell::runFileTest):
2603
2604 2013-01-14  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2605
2606         [EFL][jhbuild] Build the GStreamer-related dependencies with the "configure" script
2607         https://bugs.webkit.org/show_bug.cgi?id=106573
2608
2609         Reviewed by Philippe Normand.
2610
2611         Similarly to what's been described in bug 106569, we're building
2612         from release tarballs, so there's no reason to regenerate the
2613         autoconf-related stuff with autogen.sh, especially since we might
2614         run into trouble with automake 1.13 and deprecated macros.
2615
2616         * efl/jhbuild.modules:
2617
2618 2013-01-14  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
2619
2620         [Qt] The Qt's configuration isn't honoured regarding the use of the system libpng and libjpeg
2621         https://bugs.webkit.org/show_bug.cgi?id=104909
2622
2623         Reviewed by Simon Hausmann.
2624
2625         To be able to build redistribuable binary packages, Qt's configure switches
2626         -qt-libpng and -qt-libjpeg are used to avoid having the binaries trying to
2627         dynamically link to optional system libraries.
2628         QtWebKit is doing its own configure checks for those libraries, thus adding a
2629         runtime dependency that might not be fulfilled if the packager's machine had
2630         those libraries while the user's machine won't.
2631
2632         Since in most cases where WebKit will want to use those system libraries, Qt will
2633         also be using them, remove these configure tests from WebKit.
2634
2635         * qmake/config.tests/libjpeg/libjpeg.cpp: Removed.
2636         * qmake/config.tests/libjpeg/libjpeg.pro: Removed.
2637         * qmake/config.tests/libpng/libpng.cpp: Removed.
2638         * qmake/config.tests/libpng/libpng.pro: Removed.
2639         * qmake/mkspecs/features/features.prf:
2640
2641 2013-01-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2642
2643         [EFL][jhbuild] Bump the EFL dependencies in jhbuild to 1.7.5.
2644         https://bugs.webkit.org/show_bug.cgi?id=106574
2645
2646         Reviewed by Laszlo Gombos.
2647
2648         Rely on a more recent stable release, which includes support for
2649         Lua 5.2 in Edje and other assorted minor fixes.
2650
2651         While here, also use the "configure" script to build the libraries
2652         instead of relying on autogen.sh, which is not really needed with
2653         a release tarball and may have problems with automake 1.13.
2654
2655         * efl/jhbuild.modules:
2656
2657 2013-01-14  Andrey Lushnikov  <lushnikov@chromium.org>
2658
2659         Web Inspector: fix DRT to deliver simulated events to devtools front-end
2660         https://bugs.webkit.org/show_bug.cgi?id=106650
2661
2662         Reviewed by Pavel Feldman.
2663
2664         Add separated m_devToolsTestInterfaces object to testShell which is
2665         bind to devTools webview.
2666
2667         * DumpRenderTree/chromium/TestShell.cpp:
2668         (TestShell::initialize):
2669         (TestShell::createMainWindow):
2670         (TestShell::~TestShell):
2671         (TestShell::showDevTools):
2672         (TestShell::resetTestController):
2673         (TestShell::bindJSObjectsToWindow):
2674         (TestShell::createNewWindow):
2675         * DumpRenderTree/chromium/TestShell.h:
2676         (TestShell):
2677
2678 2013-01-14  Alan Cutter  <alancutter@chromium.org>
2679
2680         Sheriffbot command aliases need test cases
2681         https://bugs.webkit.org/show_bug.cgi?id=106754
2682
2683         Reviewed by Eric Seidel.
2684
2685         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2686         (SheriffBotTest.test_command_aliases):
2687
2688 2013-01-13  Alan Cutter  <alancutter@chromium.org>
2689
2690         Allow users to misspell the "sheriffs" command in sheriffbot
2691         https://bugs.webkit.org/show_bug.cgi?id=106628
2692
2693         Reviewed by Steve Block.
2694
2695         * Scripts/webkitpy/tool/bot/irc_command.py:
2696
2697 2013-01-13  Alan Cutter  <alancutter@chromium.org>
2698
2699         Make "gardeners" an alias for "sheriffs" in sherrifbot
2700         https://bugs.webkit.org/show_bug.cgi?id=106627
2701
2702         Reviewed by Eric Seidel.
2703
2704         * Scripts/webkitpy/tool/bot/irc_command.py:
2705
2706 2013-01-13  Dirk Pranke  <dpranke@chromium.org>
2707
2708         [chromium] webkitpy-test: executive.py stringify_args error on the release test bot
2709         https://bugs.webkit.org/show_bug.cgi?id=105380
2710
2711         Reviewed by Eric Seidel.
2712
2713         Fix a regression introduced in r137692 where we were double-encoding
2714         the arguments to popen(); this was only an issue on windows, where
2715         we would try to encode something to mbcs, then try to encode it
2716         to unicode as if the input as ascii.
2717
2718         * Scripts/webkitpy/common/system/executive.py:
2719         (Executive.run_command):
2720
2721 2013-01-13  Alan Cutter  <alancutter@chromium.org>
2722
2723         State who told sheriffbot to roll the Chromium deps and to what revision
2724         https://bugs.webkit.org/show_bug.cgi?id=106626
2725
2726         Reviewed by Eric Seidel.
2727
2728         Added optional argument to post-chromium-deps-roll so Sheriffbot can specify ChangeLog message.
2729
2730         * Scripts/webkitpy/tool/bot/irc_command.py:
2731         (RollChromiumDEPS._expand_irc_nickname):
2732         (RollChromiumDEPS.execute):
2733         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2734         (IRCCommandTest.test_roll_chromium_deps):
2735         * Scripts/webkitpy/tool/bot/sheriff.py:
2736         (Sheriff.post_chromium_deps_roll):
2737         * Scripts/webkitpy/tool/commands/roll.py:
2738         (RollChromiumDEPS._prepare_state):
2739         (PostChromiumDEPSRoll):
2740         (PostChromiumDEPSRoll._prepare_state):
2741         * Scripts/webkitpy/tool/commands/roll_unittest.py:
2742         (PostRollCommandsTest.test_prepare_state):
2743         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
2744         (PrepareChangeLogForDEPSRoll.run):
2745
2746 2013-01-13  Alan Cutter  <alancutter@chromium.org>
2747
2748         Add Alan Cutter as contributor
2749         https://bugs.webkit.org/show_bug.cgi?id=106747
2750
2751         Reviewed by Eric Seidel.
2752
2753         * Scripts/webkitpy/common/config/committers.py:
2754
2755 2013-01-13  Jonathan Liu  <net147@gmail.com>
2756
2757         Fix CONFIG missing link_pkgconfig on Windows
2758         https://bugs.webkit.org/show_bug.cgi?id=106647
2759
2760         Some libraries (e.g. libxslt, libxml2 and sqlite3) fail to link
2761         properly on Windows because they are added to PKGCONFIG but
2762         CONFIG does not contain link_pkgconfig.
2763
2764         This is because link_pkgconfig is added in unix/default_pre.prf
2765         which is only used for UNIX platforms. To fix this, move it to
2766         the general default_pre.prf.
2767
2768         Reviewed by Simon Hausmann.
2769
2770         * qmake/mkspecs/features/default_pre.prf:
2771         * qmake/mkspecs/features/unix/default_pre.prf:
2772
2773 2013-01-12  Nico Weber  <thakis@chromium.org>
2774
2775         nrwt/chromium: Don't prefer chromium over webkit build directories
2776         https://bugs.webkit.org/show_bug.cgi?id=105597
2777
2778         Reviewed by Dirk Pranke.
2779
2780         Rely on the new timestamp logic instead. Requested by dpranke in
2781         https://bugs.webkit.org/show_bug.cgi?id=105498
2782
2783         * Scripts/webkitpy/layout_tests/port/chromium.py:
2784         (ChromiumPort._static_build_path):
2785         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2786         (ChromiumLinuxPortTest.test_build_path):
2787         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2788         (ChromiumMacPortTest.test_build_path):
2789         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2790         (ChromiumWinTest.test_build_path):
2791
2792 2013-01-12  Nico Weber  <thakis@chromium.org>
2793
2794         Use ninja by default on Linux for build-webkit --chromium, bot edition
2795         https://bugs.webkit.org/show_bug.cgi?id=104434
2796
2797         Reviewed by Eric Seidel.
2798
2799         r139557 changed update-webkit to pick ninja by default on linux, but
2800         the bots run update-webkit-chromium directly so they didn't see this.
2801         Move the default for ninja into update-webkit-chromium so that it's
2802         picked up by the bots, and let update-webkit forward non-default
2803         options to there.
2804
2805         This way, the default is in one place only and both developers (who
2806         usually use update-webkit which then shells out to
2807         updat-webkit-chromium) and bots (which use update-webkit-chromium
2808         directly) see the same behavior.
2809
2810         * Scripts/update-webkit:
2811         * Scripts/update-webkit-chromium:
2812
2813 2013-01-12  Nico Weber  <thakis@chromium.org>
2814
2815         Make ninja the default build system on Linux for build-webkit --chromium
2816         https://bugs.webkit.org/show_bug.cgi?id=104434
2817
2818         Reviewed by Eric Seidel.
2819
2820         * Scripts/update-webkit:
2821
2822 2013-01-12  Alan Cutter  <alancutter@chromium.org>
2823
2824         Migrate the remaining bots in EC2 to Google Compute Engine
2825         https://bugs.webkit.org/show_bug.cgi?id=106005
2826
2827         Reviewed by Eric Seidel.
2828
2829         Updated bot scripts for launching feeder-queue, style-queue and sheriffbot on GCE.
2830
2831         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh: Copied from Tools/EWSTools/build-repo.sh.
2832         * EWSTools/boot.sh:
2833         * EWSTools/build-repo.sh:
2834         * EWSTools/start-queue.sh:
2835
2836 2013-01-12  Jochen Eisinger  <jochen@chromium.org>
2837
2838         [chromium] move inspector related methods to TestRunner library
2839         https://bugs.webkit.org/show_bug.cgi?id=106654
2840
2841         Reviewed by Adam Barth.
2842
2843         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2844         (DRTTestRunner::DRTTestRunner):
2845         * DumpRenderTree/chromium/DRTTestRunner.h:
2846         (DRTTestRunner):
2847         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2848         (WebTestRunner::WebTestDelegate::showDevTools):
2849         (WebTestRunner::WebTestDelegate::closeDevTools):
2850         (WebTestRunner::WebTestDelegate::evaluateInWebInspector):
2851         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2852         (WebTestRunner::TestRunner::TestRunner):
2853         (WebTestRunner::TestRunner::showWebInspector):
2854         (WebTestRunner):
2855         (WebTestRunner::TestRunner::closeWebInspector):
2856         (WebTestRunner::TestRunner::evaluateInWebInspector):
2857         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2858         (TestRunner):
2859         * DumpRenderTree/chromium/WebViewHost.cpp:
2860         (WebViewHost::showDevTools):
2861         (WebViewHost::closeDevTools):
2862         (WebViewHost::evaluateInWebInspector):
2863         * DumpRenderTree/chromium/WebViewHost.h:
2864         (WebViewHost):
2865
2866 2013-01-11  Julie Parent  <jparent@chromium.org>
2867
2868         Builder should not be a valid parameter for stats dashboard
2869         https://bugs.webkit.org/show_bug.cgi?id=106698
2870
2871         Reviewed by Dirk Pranke.
2872         
2873         Since builder is a dashboard specific parameter, dashboard_base
2874         should not be handling it in handleValidHashParameterWrapper, rather,
2875         each specific dashboard should in its handleValidHashParameter function.
2876     
2877         Note that the FIXME in dashboard_base about this was actually wrong -
2878         we don't want to move it to g_crossDashboardState, because it isn't
2879         actually cross dashboard state.
2880         
2881         In fact, flakiness and treemap have the code in 
2882         handleValidHashParameter, but it is currently dead code because 
2883         dashboard_base gets to it first.
2884         
2885         Added the proper handling to timeline_explorer, since builder is
2886         valid there.
2887
2888         * TestResultServer/static-dashboards/dashboard_base.js:
2889         * TestResultServer/static-dashboards/timeline_explorer.html:
2890
2891 2013-01-11  Ryosuke Niwa  <rniwa@webkit.org>
2892
2893         REGRESSION: buildbot mangles error messages with timestamps run-webkit-tests outputs
2894         https://bugs.webkit.org/show_bug.cgi?id=106688
2895
2896         Reviewed by Eric Seidel.
2897
2898         Update the regular expression used to strip the garbage at the beginning.
2899
2900         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2901         (RunWebKitTests.nrwt_log_message_regexp):
2902
2903 2013-01-11  Pratik Solanki  <psolanki@apple.com>
2904
2905         TestRunner leaks when running tests
2906         https://bugs.webkit.org/show_bug.cgi?id=106683
2907
2908         Reviewed by Simon Fraser.
2909
2910         Remove extra ref() that we missed out on deleting when refactoring window.layoutTestController
2911         to window.testRunner in r124705. This caused the TestRunner object to be leaked when running
2912         tests.
2913
2914         * DumpRenderTree/TestRunner.cpp:
2915         (TestRunner::makeWindowObject):
2916
2917 2013-01-11  Julie Parent  <jparent@chromium.org>
2918
2919         Dashboard Cleanup: Add isLoadingComplete to the loader.Loader object.
2920         https://bugs.webkit.org/show_bug.cgi?id=106247
2921
2922         Old code nulled out the loader instance when it completed loading and
2923         then later used the fact that it was null to determine if it had loaded
2924         or not.  This is not only unintuitive, but it also prevents using the
2925         loader object later on.
2926         
2927         Added new method, used it, added unit test for it.
2928         
2929         Reviewed by Dirk Pranke.
2930
2931         * TestResultServer/static-dashboards/dashboard_base.js:
2932         (resourceLoadingComplete):
2933         (handleLocationChange):
2934         * TestResultServer/static-dashboards/loader.js:
2935         (.):
2936         * TestResultServer/static-dashboards/loader_unittests.js:
2937
2938 2013-01-11  Ryosuke Niwa  <rniwa@webkit.org>
2939
2940         Try CRLF to LF change in r139407 again.
2941
2942         * BuildSlaveSupport/delete-stale-build-files:
2943         (main):
2944         (webkitBuildDirectory):
2945         * BuildSlaveSupport/kill-old-processes:
2946         (main):
2947
2948 2013-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2949
2950         [GTK] Disable the unit tests timeout when running from make check
2951         https://bugs.webkit.org/show_bug.cgi?id=106670
2952
2953         Reviewed by Philippe Normand.
2954
2955         * GNUmakefile.am: Pass --timeout=-1 to run-gtk-test.
2956
2957 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2958
2959         Yet another unreviewed fix after r139431.
2960
2961         * Scripts/run-launcher: Pass the arguments to `jhbuild-wrapper' in
2962         the correct order.
2963
2964 2013-01-11  Dan Carney  <dcarney@google.com>
2965
2966         [chromium] move some whitespace and resize related methods to TestRunner library
2967         https://bugs.webkit.org/show_bug.cgi?id=106655
2968
2969         Reviewed by Jochen Eisinger.
2970
2971         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2972         (DRTTestRunner::DRTTestRunner):
2973         * DumpRenderTree/chromium/DRTTestRunner.h:
2974         (DRTTestRunner):
2975         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2976         (WebKit):
2977         (WebTestRunner::WebTestDelegate::setClientWindowRect):
2978         (WebTestRunner::WebTestDelegate::setSelectTrailingWhitespaceEnabled):
2979         (WebTestRunner::WebTestDelegate::setSmartInsertDeleteEnabled):
2980         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2981         (WebTestRunner::TestRunner::TestRunner):
2982         (WebTestRunner::TestRunner::setSmartInsertDeleteEnabled):
2983         (WebTestRunner):
2984         (WebTestRunner::TestRunner::setSelectTrailingWhitespaceEnabled):
2985         (WebTestRunner::TestRunner::enableAutoResizeMode):
2986         (WebTestRunner::TestRunner::disableAutoResizeMode):
2987         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2988         (TestRunner):
2989         * DumpRenderTree/chromium/WebViewHost.cpp:
2990         (WebViewHost::setClientWindowRect):
2991         * DumpRenderTree/chromium/WebViewHost.h:
2992         (WebViewHost):
2993
2994 2013-01-11  Mario Sanchez Prada  <mario.prada@samsung.com>
2995
2996         Unreviewed. Update my e-mail addresses.
2997
2998         * Scripts/webkitpy/common/config/committers.py:
2999
3000 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3001
3002         Another unreviewed fix after r139431.
3003
3004         In a way, this is also a generic bug fix, since previously isEfl()
3005         would fail when called from run-efl-tests and we thus did not use
3006         jhbuild to run our tests. This now resulted in us calling
3007         "jhbuild-wrapper run" without specifying a platform.
3008
3009         * Scripts/run-efl-tests: Pass "--efl" to ARGV manually for isEfl()
3010         to work.
3011
3012 2013-01-11  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3013
3014         [Qt][WK1] Web Audio support
3015         https://bugs.webkit.org/show_bug.cgi?id=106651
3016
3017         Reviewed by Jocelyn Turcotte.
3018
3019         Implements support for dumping audio data in DumpRenderTree.
3020
3021         Adds WebAudio to toggleable features in QtTestBrowser.
3022
3023         Enables LEGACY_WEB_AUDIO. This feature is required for 2/3 of the web audio regression tests. It is enabled by default
3024         because it has no effect when WEB_AUDIO is not enabled. This combination matches the settings in FeatureList.pm.
3025
3026         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3027         (WebCore::DumpRenderTree::dump):
3028         * DumpRenderTree/qt/TestRunnerQt.cpp:
3029         (TestRunner::reset):
3030         (TestRunner::overridePreference):
3031         (TestRunner::setAudioData):
3032         * DumpRenderTree/qt/TestRunnerQt.h:
3033         (TestRunner::shouldDumpAsAudio):
3034         (TestRunner::audioData):
3035         (TestRunner):
3036         * QtTestBrowser/launcherwindow.cpp:
3037         (LauncherWindow::applyPrefs):
3038         (LauncherWindow::createChrome):
3039         (LauncherWindow::toggleWebAudio):
3040         * QtTestBrowser/launcherwindow.h:
3041         (WindowOptions::WindowOptions):
3042         (WindowOptions):
3043         (LauncherWindow):
3044         * qmake/mkspecs/features/features.prf:
3045         * qmake/mkspecs/features/features.pri:
3046
3047 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3048
3049         Unreviewed jhbuild-related fix after r139431.
3050
3051         * Scripts/webkitpy/layout_tests/port/efl.py:
3052         (EflPort.__init__): Pass a string to set_option_default(), since
3053         shlex.split() will be called on it later.
3054
3055 2013-01-11  Csaba Osztrogonác  <ossy@webkit.org>
3056
3057         Unreviewed typo fixes after r139431.
3058
3059         * Scripts/run-javascriptcore-tests:
3060
3061 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3062
3063         [jhbuild] Remove the "run-with-jhbuild" scripts.
3064         https://bugs.webkit.org/show_bug.cgi?id=106572
3065
3066         Reviewed by Martin Robinson.
3067
3068         Both ports which use jhbuild were mostly duplicating the
3069         `run-with-jhbuild' script in their own directories for no clear reason.
3070
3071         The script itself was just a thin wrapper around the `jhbuild-wrapper',
3072         so just start using that directly and get rid of a useless middle man.
3073
3074         Adjust scripts which called run-with-jhbuild to call jhbuild-wrapper
3075         instead.
3076
3077         * Scripts/run-javascriptcore-tests:
3078         * Scripts/run-launcher:
3079         * Scripts/webkitdirs.pm:
3080         (runAutogenForAutotoolsProjectIfNecessary):
3081         (buildAutotoolsProject):
3082         (jhbuildWrapperPrefixIfNeeded):
3083         (generateBuildSystemFromCMakeProject):
3084         (buildCMakeGeneratedProject):
3085         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
3086         (run):
3087         * Scripts/webkitpy/layout_tests/port/efl.py:
3088         (EflPort.__init__):
3089         (EflPort._image_diff_command):
3090         * efl/run-with-jhbuild: Removed.
3091         * gtk/run-with-jhbuild: Removed.
3092
3093 2013-01-11  Alan Cutter  <alancutter@chromium.org>
3094
3095         Allow arbitrary queue launch parameters in EWSTools/start-queue.sh
3096         https://bugs.webkit.org/show_bug.cgi?id=106636
3097
3098         Reviewed by Adam Barth.
3099
3100         This parameter will allow the bot boot script to use start-queue.sh and provide an IRC password for sheriffbot.
3101
3102         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
3103         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
3104         * EWSTools/screen-config:
3105         * EWSTools/start-queue.sh:
3106
3107 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
3108
3109         kill-old-processes and delete-stale-build-files use CRLF linebreaks
3110         https://bugs.webkit.org/show_bug.cgi?id=106622
3111
3112         Reviewed by Simon Fraser.
3113
3114         Use LF instead of CRLF in kill-old-processes and delete-stale-build-files.
3115         Also escape clang\+\+ correctly in kill-old-processes.
3116
3117         * BuildSlaveSupport/delete-stale-build-files:
3118         * BuildSlaveSupport/kill-old-processes:
3119
3120 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
3121
3122         Build fix after r139357. It was missing a comma.
3123
3124         * QueueStatusServer/model/queues.py:
3125         (Queue):
3126
3127 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
3128
3129         Fixing AuthenticationError when running test-webkitpy as a non-committer.
3130         https://bugs.webkit.org/show_bug.cgi?id=106420
3131
3132         Reviewed by Eric Seidel.
3133
3134         * Scripts/webkitpy/common/checkout/scm/git.py:
3135         (Git.push_local_commits_to_server):
3136         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3137         * Scripts/webkitpy/common/checkout/scm/svn.py:
3138         (SVNRepository):
3139         (SVNRepository.has_authorization_for_realm):
3140
3141 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
3142
3143         [EFL][jhbuild] Use tarballs for gstreamer instead of git
3144         https://bugs.webkit.org/show_bug.cgi?id=106552
3145
3146         Reviewed by Laszlo Gombos.
3147
3148         Use tarballs for gstreamer instead of git in EFL's jhbuild
3149         to work around intermittent network issues on our build
3150         bots. Tarballs are fully cached and require no network
3151         operation if their checksum matches.
3152
3153         * efl/jhbuild.modules:
3154
3155 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
3156
3157         Add Mac WK2 EWS bots
3158         https://bugs.webkit.org/show_bug.cgi?id=106590
3159
3160         Reviewed by Adam Barth.
3161
3162         Added MacWK2EWS, and made myself a watcher for MacEWS and MacWK2EWS.
3163         Also add a deprecated MacWK2Port class.
3164
3165         * QueueStatusServer/model/queues.py:
3166         (Queue):
3167         * Scripts/webkitpy/common/config/ports.py:
3168         (DeprecatedPort.port):
3169         (MacWK2Port):
3170         (MacWK2Port.run_webkit_tests_command):
3171         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3172         (MacEWS):
3173         (MacWK2EWS):
3174         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3175         (_test_ewses):
3176
3177 2013-01-10  Dan Carney  <dcarney@google.com>
3178
3179         [chromium] move webpermissionclient related methods to TestRunner library
3180         https://bugs.webkit.org/show_bug.cgi?id=106548
3181
3182         Reviewed by Jochen Eisinger.
3183
3184         * DumpRenderTree/DumpRenderTree.gypi:
3185         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3186         (DRTTestRunner::DRTTestRunner):
3187         (DRTTestRunner::reset):
3188         * DumpRenderTree/chromium/DRTTestRunner.h:
3189         (DRTTestRunner):
3190         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3191         (WebTestRunner::WebTestDelegate::normalizeLayoutTestURL):
3192         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3193         (WebKit):
3194         (WebTestRunner::WebTestRunner::webPermissions):
3195         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3196         (WebTestRunner::TestRunner::TestRunner):
3197         (WebTestRunner::TestRunner::setDelegate):
3198         (WebTestRunner):
3199         (WebTestRunner::TestRunner::reset):
3200         (WebTestRunner::TestRunner::webPermissions):
3201         (WebTestRunner::TestRunner::dumpPermissionClientCallbacks):
3202         (WebTestRunner::TestRunner::setImagesAllowed):
3203         (WebTestRunner::TestRunner::setScriptsAllowed):
3204         (WebTestRunner::TestRunner::setStorageAllowed):
3205         (WebTestRunner::TestRunner::setPluginsAllowed):
3206         (WebTestRunner::TestRunner::setAllowDisplayOfInsecureContent):
3207         (WebTestRunner::TestRunner::setAllowRunningOfInsecureContent):
3208         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3209         (WebTestRunner):
3210         (TestRunner):
3211         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.cpp.
3212         (WebTestRunner):
3213         (WebTestRunner::WebPermissions::WebPermissions):
3214         (WebTestRunner::WebPermissions::~WebPermissions):
3215         (WebTestRunner::WebPermissions::allowImage):
3216         (WebTestRunner::WebPermissions::allowScriptFromSource):
3217         (WebTestRunner::WebPermissions::allowStorage):
3218         (WebTestRunner::WebPermissions::allowPlugins):
3219         (WebTestRunner::WebPermissions::allowDisplayingInsecureContent):
3220         (WebTestRunner::WebPermissions::allowRunningInsecureContent):
3221         (WebTestRunner::WebPermissions::setImagesAllowed):
3222         (WebTestRunner::WebPermissions::setScriptsAllowed):
3223         (WebTestRunner::WebPermissions::setStorageAllowed):
3224         (WebTestRunner::WebPermissions::setPluginsAllowed):
3225         (WebTestRunner::WebPermissions::setDisplayingInsecureContentAllowed):
3226         (WebTestRunner::WebPermissions::setRunningInsecureContentAllowed):
3227         (WebTestRunner::WebPermissions::setDelegate):
3228         (WebTestRunner::WebPermissions::setDumpCallbacks):
3229         (WebTestRunner::WebPermissions::reset):
3230         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.h.
3231         (WebTestRunner):
3232         (WebPermissions):
3233         * DumpRenderTree/chromium/TestShell.cpp:
3234         (TestShell::initialize):
3235         (TestShell::resetTestController):
3236         (TestShell::createNewWindow):
3237         * DumpRenderTree/chromium/TestShell.h:
3238         (TestShell):
3239         * DumpRenderTree/chromium/WebViewHost.cpp:
3240         (WebViewHost::normalizeLayoutTestURL):
3241         * DumpRenderTree/chromium/WebViewHost.h:
3242         (WebViewHost):
3243
3244 2013-01-10  Alan Cutter  <alancutter@chromium.org>
3245
3246         Split EWS tool cold-boot.sh into modular components
3247         https://bugs.webkit.org/show_bug.cgi?id=106527
3248
3249         Reviewed by Adam Barth.
3250
3251         Split cold-boot.sh script up into build-vm.sh, build-repo.sh and build-boot-cmd.sh.
3252         Updated GCE bot build scripts to match.
3253         Unable to test scripts directly as they depend on being in the repository to work!
3254
3255         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
3256         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
3257         * EWSTools/build-boot-cmd.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-chromium-ews.sh.
3258         * EWSTools/build-repo.sh: Copied from Tools/EWSTools/cold-boot.sh.
3259         * EWSTools/build-vm.sh: Renamed from Tools/EWSTools/cold-boot.sh.
3260
3261 2013-01-10  Julie Parent  <jparent@chromium.org>
3262
3263         Dashboard Cleanup: Do not generate the page if we are about to reload.
3264         https://bugs.webkit.org/show_bug.cgi?id=106584
3265
3266         Reviewed by Dirk Pranke.
3267
3268         Move the logic to determine if we should generate the page into
3269         parseParameters() since that is where we have the knowledge to
3270         determine it, and return that value to handleLocationChange, 
3271         rather than passing the changed parameters back to handleLocationChange
3272         and having it make the decision.
3273         
3274         This is logically equivalent, save one case: when we are about to do
3275         a reload, we know that there is no reason to generate the page.  Old
3276         code was causing an extra page generation in this case.
3277         
3278         * TestResultServer/static-dashboards/dashboard_base.js:
3279         (parseParameters):
3280         (handleLocationChange):
3281
3282 2013-01-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3283
3284         [jhbuild] Use the "configure" script to build glib
3285         https://bugs.webkit.org/show_bug.cgi?id=106569
3286
3287         Reviewed by Martin Robinson.
3288
3289         So far both EFL and GTK have been using autogen.sh to build glib.
3290         While that does work most of the time, it's not really needed since
3291         we are downloading and building stable releases from tarballs.
3292         Additionally, autogen.sh fails to work with automake 1.13 due to the
3293         usage of some macros that have been removed (this has already been
3294         fixed in glib master).
3295
3296         * efl/jhbuild.modules:
3297         * gtk/jhbuild.modules:
3298
3299 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
3300
3301         Changing tests to be consistent and use self.scm rather then recreating the scm object.
3302         (Missed a couple)
3303         https://bugs.webkit.org/show_bug.cgi?id=106536
3304
3305         Reviewed by Eric Seidel.
3306
3307         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3308
3309 2013-01-10  Tony Chang  <tony@chromium.org>
3310
3311         Speed up supplemental dependency computation
3312         https://bugs.webkit.org/show_bug.cgi?id=106503
3313
3314         Reviewed by Adam Barth.
3315
3316         Pass the IDL attributes file for generating the bindings in WebKitTestRunner.
3317
3318         * WebKitTestRunner/CMakeLists.txt:
3319
3320 2013-01-10  Zan Dobersek  <zandobersek@gmail.com>
3321
3322         Remove the ENABLE_ANIMATION_API feature define occurences
3323         https://bugs.webkit.org/show_bug.cgi?id=106544
3324
3325         Reviewed by Simon Fraser.
3326
3327         The Animation API code was removed in r137243. The ENABLE_ANIMATION_API
3328         feature define handling still lingers in various build systems and configurations
3329         but is of no use, so it should be removed.
3330
3331         * Scripts/webkitperl/FeatureList.pm:
3332         * qmake/mkspecs/features/features.pri:
3333
3334 2013-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
3335
3336         [GTK] Add support for loading web process extensions
3337         https://bugs.webkit.org/show_bug.cgi?id=105631
3338
3339         Reviewed by Gustavo Noronha Silva.
3340
3341         * MiniBrowser/gtk/GNUmakefile.am:
3342         * MiniBrowser/gtk/main.c:
3343         (main): Set WEBKIT_INJECTED_BUNDLE env var to use the injected
3344         bundle lib from build dir.
3345         * Scripts/webkitpy/style/checker.py: Add exceptions for GTK+ API
3346         located in WebProcess/InjectedBundle/API/gtk.
3347         * gtk/generate-gtkdoc:
3348         (get_webkit2_options): Scan also files in
3349         WebProcess/InjectedBundle/API/gtk to generate API docs.
3350         (get_webkit2_options.injected_bundle_src_path): Helper function to
3351         build paths in WebProcess/InjectedBundle/API/gtk.
3352
3353 2013-01-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3354
3355         [EFL][WK2] Writing immediately to created windows (open) fails
3356         https://bugs.webkit.org/show_bug.cgi?id=105276
3357
3358         Reviewed by Kenneth Rohde Christiansen.
3359
3360         Do not reset 'about:blank' url for the new pages in mini browser.
3361
3362         * MiniBrowser/efl/main.c:
3363         (window_create):
3364
3365 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
3366
3367         Changing tests to be consistent and use self.scm rather then recreating the scm object.
3368         https://bugs.webkit.org/show_bug.cgi?id=106536
3369
3370         Reviewed by Eric Seidel.
3371
3372         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3373
3374 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
3375
3376         Converting to unittest2 so we can use assertItemsEqual, making tests
3377         not dependent on order of items.
3378         https://bugs.webkit.org/show_bug.cgi?id=106532
3379
3380         Before:
3381         Ran 1733 tests in 38.385s
3382         FAILED (failures=1, errors=22)
3383
3384         After:
3385         Ran 1733 tests in 32.298s
3386         FAILED (failures=0, errors=22)
3387
3388         Reviewed by Eric Seidel.
3389
3390         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3391         * Scripts/webkitpy/thirdparty/__init__.py:
3392         (AutoinstallImportHook._install_unittest2):
3393
3394 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
3395
3396         [EFL] Add gstreamer 1.0.5 to jhbuild
3397         https://bugs.webkit.org/show_bug.cgi?id=106178
3398
3399         Reviewed by Laszlo Gombos.
3400
3401         Add gstreamer 1.0.5 to EFL's jhbuild configuration.
3402
3403         * efl/jhbuild.modules:
3404
3405 2013-01-09  Alan Cutter  <alancutter@chromium.org>
3406
3407         Updated parameters in GCE build scripts so they now work.
3408         https://bugs.webkit.org/show_bug.cgi?id=106523
3409
3410         Reviewed by Adam Barth.
3411
3412         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
3413         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
3414         * EWSTools/cold-boot.sh:
3415
3416 2013-01-09  Mark Pilgrim  <pilgrim@chromium.org>
3417
3418         [Chromium] Remove some stray references to WebKitPlatformSupport.h in DumpRenderTree
3419         https://bugs.webkit.org/show_bug.cgi?id=106520
3420
3421         Reviewed by James Robinson.
3422
3423         Part of a larger refactoring series. See tracking bug 82948.
3424
3425         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
3426         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
3427
3428 2013-01-09  Julie Parent  <jparent@chromium.org>
3429
3430         Dashboard cleanup: Remove code for currentState and window.location.hash getting out of state
3431         https://bugs.webkit.org/show_bug.cgi?id=106514
3432
3433         This is old code, as these can no longer get out of sync.
3434         permmaLinkURLHash is generated from currentState, which is set only
3435         from the location.  The commment about how these can get out of sync
3436         refers to a function that no longer exists.
3437         
3438         Reviewed by Dirk Pranke.
3439
3440         * TestResultServer/static-dashboards/dashboard_base.js:
3441         (handleLocationChange):
3442
3443 2013-01-09  Julie Parent  <jparent@chromium.org>
3444
3445         Dashboard Cleanup: Reload the page as soon as we know we need to.
3446         https://bugs.webkit.org/show_bug.cgi?id=106515
3447
3448         No need to continue parsing all of the data once we know that
3449         we need to do a reload.
3450         
3451         Reviewed by Dirk Pranke.
3452
3453         * TestResultServer/static-dashboards/dashboard_base.js:
3454         (parseParameters):
3455
3456 2013-01-09  Eric Seidel  <eric@webkit.org>
3457
3458         run-perf-tests --chromium-android --profile should show symbols for the kernel
3459         https://bugs.webkit.org/show_bug.cgi?id=106498
3460
3461         Reviewed by Adam Barth.
3462
3463         Turns out this was easy, once I finally read the output from "perf report".
3464         It appears there may be a bug in "perf record" on android, as it complains
3465         about not being able to read from /proc/kallsyms even when
3466         /proc/sys/kernel/kptr_restrict is 0.  For now I've not bothered
3467         to keep /proc/sys/kernel/kptr_restrict as 0 during the actual record
3468         but rather just flip it to 0 long enough to grab the /proc/kallsyms
3469         and then flip it back to whatever the device had.
3470
3471         /proc/sys/kernel/kptr_restrict controls what /proc/kallsyms returns
3472         on Linux.  /proc/kallsyms contains a mapping of kernel addresses
3473         to symbol names.  Its world-readable, but will return all 0s if you
3474         don't have permission to see the kernel symbols.  kptr_restrict
3475         supports values 0, 1, 2.  Where 0 means "everyone can see the real symbols"
3476         1 is only a specific group, and 2 is "no one, not even root".
3477         By default kptr_restrict is 2 on Android it seems.
3478         More kptr_restrict docs: http://lwn.net/Articles/420403/
3479
3480         I also took this opportunity to clean up how the perf record command
3481         was built for use/display in AndroidPerf.profile_after_exit and
3482         change to always using long-form names for the arguments (to hopefully help readability).
3483
3484         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3485         (AndroidPerf.__init__):
3486         (profile_after_exit):
3487         (ChromiumAndroidDriver.__init__):
3488         (ChromiumAndroidDriver._update_kallsyms_cache):
3489         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3490
3491 2013-01-09  Julie Parent  <jparent@chromium.org>
3492
3493         Dashboard cleanup: remove dead code.
3494         https://bugs.webkit.org/show_bug.cgi?id=106509
3495
3496         Reviewed by Dirk Pranke.
3497
3498         * TestResultServer/static-dashboards/dashboard_base.js:
3499         (parseParameters):
3500
3501 2013-01-09  Joanmarie Diggs  <jdiggs@igalia.com>
3502
3503         [GTK] accessibility/aria-labelledby-overrides-label.html requires a proper baseline
3504         https://bugs.webkit.org/show_bug.cgi?id=105638
3505
3506         Reviewed by Martin Robinson.
3507
3508         The test was failing for two reasons:
3509         - AccessibilityRenderObject::correspondingLabelForControlElement() was
3510           not ignoring the ARIA labelled-by property
3511         - AccessibilityController::accessibleElementById() was not implemented
3512
3513         Because getting an element by ID cannot be done in the UIProcess, the
3514         decision was made to expose the element's ID as an accessible attribute
3515         of the object.
3516
3517         In addition, fixing the bug in AccessibilityRenderObject made it possible
3518         to eliminate the Gtk platform-specific expectations for another test.
3519
3520         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3521         (childElementById): Added. Walks the tree looking for the AtkObject
3522         Attribute which exposes the HTML element's ID.
3523         (AccessibilityController::accessibleElementById): Implemented.
3524         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3525         (AccessibilityUIElement::title): Modified to print out "AXTitle: " even
3526         when there is no title, as is done with the Mac port.
3527         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3528         (WTR):
3529         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
3530         (WTR::childElementById): Added. Walks the tree looking for the AtkObject
3531         Attribute which exposes the HTML element's ID.
3532         (WTR):
3533         (WTR::AccessibilityController::accessibleElementById): Implemented.
3534         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3535         (WTR::AccessibilityUIElement::title): Modified to print out "AXTitle: "
3536         even when there is no title, as is done with the Mac port.
3537
3538 2013-01-09  Gregg Tavares  <gman@google.com>
3539
3540         Add Gregg Tavares as a committer
3541         https://bugs.webkit.org/show_bug.cgi?id=106492
3542
3543         Unreviewed.
3544
3545         * Scripts/webkitpy/common/config/committers.py:
3546
3547 2013-01-09  Roger Fong  <roger_fong@apple.com>
3548
3549         Enable seamless iFrames for Windows DRT.
3550         https://bugs.webkit.org/show_bug.cgi?id=106468.
3551
3552         Rubberstamped by Timothy Horton.
3553
3554         * DumpRenderTree/win/DumpRenderTree.cpp:
3555         (resetDefaultsToConsistentValues):
3556
3557 2013-01-09  Christophe Dumez  <christophe.dumez@intel.com>
3558
3559         [WK2] Implement eventSender.scheduleAsynchronousKeyDown
3560         https://bugs.webkit.org/show_bug.cgi?id=93979
3561
3562         Reviewed by Benjamin Poulain.
3563
3564         Implement eventSender.scheduleAsynchronousKeyDown() in
3565         WebKitTestRunner.
3566
3567         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3568         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3569         (WTR::createKeyDownMessageBody):
3570         (WTR::EventSendingController::keyDown):
3571         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
3572         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3573         (EventSendingController):
3574         * WebKitTestRunner/TestController.cpp:
3575         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
3576         (WTR::TestController::didReceiveMessageFromInjectedBundle):
3577         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3578         * WebKitTestRunner/TestController.h:
3579         (TestController):
3580
3581 2013-01-09  Jochen Eisinger  <jochen@chromium.org>
3582
3583         [chromium] move resource load callback dumping to TestRunner library
3584         https://bugs.webkit.org/show_bug.cgi?id=106449
3585
3586         Reviewed by Adam Barth.
3587
3588         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3589         (DRTTestRunner::DRTTestRunner):
3590         (DRTTestRunner::reset):
3591         * DumpRenderTree/chromium/DRTTestRunner.h:
3592         (DRTTestRunner):
3593         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3594         (WebKit):
3595         (WebTestRunner::WebTestDelegate::makeURLErrorDescription):
3596         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3597         (WebKit):
3598         (WebTestProxyBase):
3599         (WebTestRunner::WebTestProxy::assignIdentifierToRequest):
3600         (WebTestRunner::WebTestProxy::willRequestResource):
3601         (WebTestRunner::WebTestProxy::willSendRequest):
3602         (WebTestRunner::WebTestProxy::didReceiveResponse):
3603         (WebTestRunner::WebTestProxy::didFinishResourceLoad):
3604         (WebTestRunner::WebTestProxy::didFailResourceLoad):
3605         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3606         (WebTestRunner::WebTestRunner::shouldDumpResourceLoadCallbacks):
3607         (WebTestRunner::WebTestRunner::shouldDumpResourceRequestCallbacks):
3608         (WebTestRunner::WebTestRunner::shouldDumpResourceResponseMIMETypes):
3609         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3610         (WebTestRunner::TestRunner::TestRunner):
3611         (WebTestRunner::TestRunner::reset):
3612         (WebTestRunner::TestRunner::shouldDumpResourceLoadCallbacks):
3613         (WebTestRunner::TestRunner::shouldDumpResourceRequestCallbacks):
3614         (WebTestRunner::TestRunner::shouldDumpResourceResponseMIMETypes):
3615         (WebTestRunner):
3616         (WebTestRunner::TestRunner::dumpResourceLoadCallbacks):
3617         (WebTestRunner::TestRunner::dumpResourceRequestCallbacks):
3618         (WebTestRunner::TestRunner::dumpResourceResponseMIMETypes):
3619         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3620         (TestRunner):
3621         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3622         (WebTestRunner::WebTestProxyBase::reset):
3623         (WebTestRunner):
3624         (WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
3625         (WebTestRunner::WebTestProxyBase::willRequestResource):
3626         (WebTestRunner::WebTestProxyBase::willSendRequest):
3627         (WebTestRunner::WebTestProxyBase::didReceiveResponse):
3628         (WebTestRunner::WebTestProxyBase::didFinishResourceLoad):
3629         (WebTestRunner::WebTestProxyBase::didFailResourceLoad):
3630         * DumpRenderTree/chromium/WebViewHost.cpp:
3631         (WebViewHost::willSendRequest):
3632         (WebViewHost::makeURLErrorDescription):
3633         (WebViewHost::reset):
3634         * DumpRenderTree/chromium/WebViewHost.h:
3635         (WebViewHost):
3636
3637 2013-01-09  Dan Carney  <dcarney@google.com>
3638
3639         [chromium] move dumpcreateview methods to testrunner library
3640         https://bugs.webkit.org/show_bug.cgi?id=106434
3641
3642         Reviewed by Adam Barth.
3643
3644         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3645         (DRTTestRunner::DRTTestRunner):
3646         (DRTTestRunner::reset):
3647         * DumpRenderTree/chromium/DRTTestRunner.h:
3648         (DRTTestRunner):
3649         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3650         (WebTestRunner::WebTestRunner::shouldDumpCreateView):
3651         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3652         (WebTestRunner::TestRunner::TestRunner):
3653         (WebTestRunner::TestRunner::reset):
3654         (WebTestRunner::TestRunner::shouldDumpCreateView):
3655         (WebTestRunner):
3656         (WebTestRunner::TestRunner::dumpCreateView):
3657         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3658         (TestRunner):
3659
3660 2013-01-09  Csaba Osztrogonác  <ossy@webkit.org>
3661
3662         webkitpy cleanup: Merge additional_comment_text into comment_text
3663         https://bugs.webkit.org/show_bug.cgi?id=106421
3664
3665         Reviewed by Adam Barth.
3666
3667         * Scripts/webkitpy/common/config/committervalidator.py:
3668         (CommitterValidator.reject_patch_from_commit_queue):
3669         (CommitterValidator.reject_patch_from_review_queue):
3670         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3671         (Bugzilla.set_flag_on_attachment):
3672         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
3673         (MockBugzilla.set_flag_on_attachment):
3674         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3675         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3676         (AbstractEarlyWarningSystem._post_reject_message_on_bug):
3677         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3678
3679 2013-01-09  Mario Sanchez Prada  <mario.prada@samsung.com>
3680
3681         [GTK] Raise version of gdk-pixbuf in jhbuild up to 2.26.5
3682         https://bugs.webkit.org/show_bug.cgi?id=106464
3683
3684         Reviewed by Martin Robinson.
3685
3686         Current version in jhbuild.modules (2.26.0) is giving trouble to
3687         when trying to build WebKitGTK from scratch, due to a segmentation
3688         fault error in gdk-pixbuf-query-loader during the 'make'
3689         phase. Raising the version to 2.26.5 fixes this issue.
3690
3691         * gtk/jhbuild.modules: Version raised, checksums updated.
3692
3693 2013-01-09  János Badics  <jbadics@inf.u-szeged.hu>
3694
3695         [Qt][NRWT] Pass --timeout to DRT/WTR if a test is marked as SLOW.
3696         https://bugs.webkit.org/show_bug.cgi?id=90968.
3697
3698         Reviewed by Csaba Osztrogonác.
3699
3700         Added functionality in DRT and WTR to use any timeout value while running
3701         slow tests (eventually, any test). Now NRWT --time-out-ms determines the
3702         timeout value for the test. Added a flag in NRWT (supports_per_test_timeout)
3703         to indicate whether the current port supports setting timeout value
3704         per test (it's False by default; I enabled it only on Qt).
3705         Also corrected a typo in driver.py
3706
3707         * DumpRenderTree/DumpRenderTree.h:
3708         (TestCommand::TestCommand):
3709         (TestCommand):
3710         * DumpRenderTree/DumpRenderTreeCommon.cpp:
3711         (parseInputLine):
3712         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3713         (WebCore::DumpRenderTree::processLine):
3714         * Scripts/webkitpy/layout_tests/port/base.py:
3715         (Port.supports_per_test_timeout):
3716         * Scripts/webkitpy/layout_tests/port/driver.py:
3717         (Driver.run_test):
3718         (Driver._command_from_driver_input):
3719         * Scripts/webkitpy/layout_tests/port/qt.py:
3720         (QtPort.supports_per_test_timeout):
3721         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3722         (WTR::InjectedBundle::InjectedBundle):
3723         (WTR::InjectedBundle::didReceiveMessage):
3724         (WTR::InjectedBundle::beginTesting):
3725         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3726         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3727         (WTR::TestRunner::setCustomTimeout):
3728         (WTR):
3729         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3730         (TestRunner):
3731         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
3732         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
3733         * WebKitTestRunner/TestController.cpp:
3734         (WTR::TestController::TestController):
3735         (WTR::TestController::getCustomTimeout):
3736         (WTR):
3737         (WTR::TestCommand::TestCommand):
3738         (TestCommand):
3739         (WTR::parseInputLine):
3740         (WTR::TestController::runTest):
3741         (WTR::TestController::runUntil):
3742         * WebKitTestRunner/TestController.h:
3743         (TestController):
3744         * WebKitTestRunner/TestInvocation.cpp:
3745         (WTR::TestInvocation::TestInvocation):
3746         (WTR::TestInvocation::setCustomTimeout):
3747         (WTR):
3748         (WTR::TestInvocation::invoke):
3749         * WebKitTestRunner/TestInvocation.h:
3750         (TestInvocation):
3751
3752 2013-01-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3753
3754         Regression(r138681): Add HAVE(ACCESSIBILITY) guard to atk files
3755         https://bugs.webkit.org/show_bug.cgi?id=106290
3756
3757         Reviewed by Martin Robinson.
3758
3759         Some atk files don't use HAVE(ACCESSIBILITY). It might make build errors when
3760         the macro isn't enabled.
3761
3762         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3763
3764 2013-01-08  Martin Robinson  <mrobinson@igalia.com>
3765
3766         WebKitTestRunner needs support for setHandlesAuthenticationChallenges
3767         https://bugs.webkit.org/show_bug.cgi?id=103653
3768
3769         Reviewed by Anders Carlsson.
3770
3771         Implement setHandlesAuthenticationChallenges in the UIProcess by sending credentials
3772         and the enabled boolean to the UIProcess and then implementing the didReceiveAuthenticationChallengeInFrame
3773         client callback.
3774
3775         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Exposed the new TestRunner
3776         methods to the JavaScript API.
3777         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3778         (WTR::TestRunner::setHandlesAuthenticationChallenges): Added this callback for the JavaScript API.
3779         (WTR::TestRunner::setAuthenticationUsername): Ditto.
3780         (WTR::TestRunner::setAuthenticationPassword): Ditto.
3781         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3782         (TestRunner): Added new declarations for the above.
3783         * WebKitTestRunner/TestController.cpp:
3784         (WTR::TestController::createWebViewWithOptions): Hook up the new didReceiveSynchronousMessageFromInjectedBundle
3785         callback.
3786         (WTR::TestController::resetStateToConsistentValues): Reset the credentials and enabled boolean between tests.
3787         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Handle the callback by using
3788         the authentication information passed from the InjectedBundle.
3789         * WebKitTestRunner/TestController.h:
3790         (WTR::TestController::setHandlesAuthenticationChallenges): Added setter to allow TestInvocation
3791         to communicate with the TestController.
3792         (WTR::TestController::setAuthenticationUsername): Ditto.
3793         (WTR::TestController::setAuthenticationPassword): Ditto.
3794         (TestController):
3795         * WebKitTestRunner/TestInvocation.cpp:
3796         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the messages sending authentication
3797         information from the InjectedBundle.
3798         (WTR::TestInvocation::outputText): Added this method so that the TestController can output
3799         text to the TestInvocation text output.
3800         * WebKitTestRunner/TestInvocation.h:
3801         (TestInvocation): Added declaration for new method.
3802
3803 2013-01-08  Benjamin Poulain  <benjamin@webkit.org>
3804
3805         Add myself as a watcher for Web Geolocation
3806
3807         Unreviewed.
3808
3809         * Scripts/webkitpy/common/config/watchlist:
3810
3811 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
3812
3813         [webkitpy] Call setup_test_run method of the parent Port interface when method is called on subclasses
3814         https://bugs.webkit.org/show_bug.cgi?id=106364
3815
3816         Reviewed by Eric Seidel.
3817
3818         When the setup_test_run method is called on the subclasses of the base Port
3819         interface, the parent method should also be called via super(), despite the
3820         parent method not doing anything at the moment.
3821
3822         The according calls to super() are required in the ChromiumPort, EflPort
3823         and GtkPort implementations.
3824
3825         * Scripts/webkitpy/layout_tests/port/chromium.py:
3826         (ChromiumPort.setup_test_run):
3827         * Scripts/webkitpy/layout_tests/port/efl.py:
3828         (EflPort.setup_test_run):
3829         * Scripts/webkitpy/layout_tests/port/gtk.py:
3830         (GtkPort.setup_test_run):
3831
3832 2013-01-08  Julie Parent  <jparent@chromium.org>
3833
3834         Dashboard cleanup: Remove globals g_buildersThatFailedToLoad and g_staleBuilders
3835         https://bugs.webkit.org/show_bug.cgi?id=106356
3836
3837         g_buildersThatFailedToLoad and g_staleBuilders were globals defined in
3838         dashboard_base, assigned by Loader, and used only by dashboard_base to
3839         create error messages.  Moved the variables to be privates on the Loader
3840         object, moved error message creation to _getLoadingErrorMessages on the
3841         Loader object, and now pass the errors back to dashboard base via the
3842         resourceLoadingComplete callback.
3843         
3844         Also removed the now unused clearError function, it was only being used
3845         by unit tests to clean up global state.
3846         
3847         Reviewed by Dirk Pranke.
3848
3849         * TestResultServer/static-dashboards/dashboard_base.js:
3850         (resourceLoadingComplete):
3851         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3852         * TestResultServer/static-dashboards/loader.js:
3853         (.):
3854         * TestResultServer/static-dashboards/loader_unittests.js:
3855
3856 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
3857
3858         [EFL][GTK] Make the PulseAudioSanitizer an object on the EflPort, GtkPort
3859         https://bugs.webkit.org/show_bug.cgi?id=106354
3860
3861         Reviewed by Eric Seidel.
3862
3863         Put the PulseAudioSanitizer object on the EflPort and GtkPort interfaces
3864         instead of those two inheriting from it. Also add a mock object of the
3865         sanitizer that's used in unit tests.
3866
3867         * Scripts/webkitpy/layout_tests/port/efl.py:
3868         (EflPort):
3869         (EflPort.__init__):
3870         (EflPort.setup_test_run):
3871         (EflPort.clean_up_test_run):
3872         * Scripts/webkitpy/layout_tests/port/efl_unittest.py: Also correct the
3873         importing order.
3874         (EflPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.
3875         * Scripts/webkitpy/layout_tests/port/gtk.py:
3876         (GtkPort):
3877         (GtkPort.__init__):
3878         (GtkPort.setup_test_run):
3879         (GtkPort.clean_up_test_run):
3880         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py: Also correct the
3881         importing order.
3882         (GtkPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.
3883         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer.py:
3884         (PulseAudioSanitizer.unload_pulseaudio_module): Stylize the method as public.
3885         (PulseAudioSanitizer.restore_pulseaudio_module): Ditto.
3886         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer_mock.py: Added.
3887         (PulseAudioSanitizerMock): A simple mock interface for PulseAudioSanitizer.
3888         (PulseAudioSanitizerMock.unload_pulseaudio_module):
3889         (PulseAudioSanitizerMock.restore_pulseaudio_module):
3890
3891 2013-01-08  Jochen Eisinger  <jochen@chromium.org>
3892
3893         [chromium] move dumpFrameLoadCallbacks and friends to the TestRunner library
3894         https://bugs.webkit.org/show_bug.cgi?id=106324
3895
3896         Reviewed by Adam Barth.
3897
3898         Since the frame load callbacks are part of the WebFrameClient, the
3899         WebTestProxy is now intercepting both WebViewClient and WebFrameClient
3900         methods.
3901
3902         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3903         (DRTTestRunner::DRTTestRunner):
3904         (DRTTestRunner::reset):
3905         * DumpRenderTree/chromium/DRTTestRunner.h:
3906         (DRTTestRunner):
3907         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3908         (WebTestInterfaces):
3909         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3910         (WebKit):
3911         (WebTestProxyBase):
3912         (WebTestRunner):
3913         (WebTestRunner::WebTestProxy::WebTestProxy):
3914         (WebTestProxy):
3915         (WebTestRunner::WebTestProxy::didInvalidateRect):
3916         (WebTestRunner::WebTestProxy::didScrollRect):
3917         (WebTestRunner::WebTestProxy::scheduleComposite):
3918         (WebTestRunner::WebTestProxy::scheduleAnimation):
3919         (WebTestRunner::WebTestProxy::setWindowRect):
3920         (WebTestRunner::WebTestProxy::show):
3921         (WebTestRunner::WebTestProxy::didAutoResize):
3922         (WebTestRunner::WebTestProxy::postAccessibilityNotification):
3923         (WebTestRunner::WebTestProxy::startDragging):
3924         (WebTestRunner::WebTestProxy::shouldBeginEditing):
3925         (WebTestRunner::WebTestProxy::shouldEndEditing):
3926         (WebTestRunner::WebTestProxy::shouldInsertNode):
3927         (WebTestRunner::WebTestProxy::shouldInsertText):
3928         (WebTestRunner::WebTestProxy::shouldChangeSelectedRange):
3929         (WebTestRunner::WebTestProxy::shouldDeleteRange):
3930         (WebTestRunner::WebTestProxy::shouldApplyStyle):
3931         (WebTestRunner::WebTestProxy::didBeginEditing):
3932         (WebTestRunner::WebTestProxy::didChangeSelection):
3933         (WebTestRunner::WebTestProxy::didChangeContents):
3934         (WebTestRunner::WebTestProxy::didEndEditing):
3935         (WebTestRunner::WebTestProxy::registerIntentService):
3936         (WebTestRunner::WebTestProxy::dispatchIntent):
3937         (WebTestRunner::WebTestProxy::willPerformClientRedirect):
3938         (WebTestRunner::WebTestProxy::didCancelClientRedirect):
3939         (WebTestRunner::WebTestProxy::didStartProvisionalLoad):
3940         (WebTestRunner::WebTestProxy::didReceiveServerRedirectForProvisionalLoad):
3941         (WebTestRunner::WebTestProxy::didFailProvisionalLoad):
3942         (WebTestRunner::WebTestProxy::didCommitProvisionalLoad):
3943         (WebTestRunner::WebTestProxy::didReceiveTitle):
3944         (WebTestRunner::WebTestProxy::didFinishDocumentLoad):
3945         (WebTestRunner::WebTestProxy::didHandleOnloadEvents):
3946         (WebTestRunner::WebTestProxy::didFailLoad):
3947         (WebTestRunner::WebTestProxy::didFinishLoad):
3948         (WebTestRunner::WebTestProxy::didChangeLocationWithinPage):
3949         (WebTestRunner::WebTestProxy::didDisplayInsecureContent):
3950         (WebTestRunner::WebTestProxy::didRunInsecureContent):
3951         (WebTestRunner::WebTestProxy::didDetectXSS):
3952         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
3953         (WebTestRunner::WebTestRunner::setTestIsRunning):
3954         (WebTestRunner::WebTestRunner::shouldDumpFrameLoadCallbacks):
3955         (WebTestRunner::WebTestRunner::setShouldDumpFrameLoadCallbacks):
3956         (WebTestRunner::WebTestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
3957         (WebTestRunner::WebTestRunner::stopProvisionalFrameLoads):
3958         (WebTestRunner::WebTestRunner::shouldDumpTitleChanges):
3959         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3960         (WebTestRunner::TestRunner::TestRunner):
3961         (WebTestRunner::TestRunner::reset):
3962         (WebTestRunner::TestRunner::setTestIsRunning):
3963         (WebTestRunner):
3964         (WebTestRunner::TestRunner::shouldDumpFrameLoadCallbacks):
3965         (WebTestRunner::TestRunner::setShouldDumpFrameLoadCallbacks):
3966         (WebTestRunner::TestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
3967         (WebTestRunner::TestRunner::stopProvisionalFrameLoads):
3968         (WebTestRunner::TestRunner::shouldDumpTitleChanges):
3969         (WebTestRunner::TestRunner::dumpFrameLoadCallbacks):
3970         (WebTestRunner::TestRunner::dumpUserGestureInFrameLoadCallbacks):
3971         (WebTestRunner::TestRunner::setStopProvisionalFrameLoads):
3972         (WebTestRunner::TestRunner::dumpTitleChanges):
3973         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3974         (TestRunner):
3975         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3976         (WebTestInterfaces::Internal):
3977         (WebTestRunner::WebTestInterfaces::Internal::webView):
3978         (WebTestRunner::WebTestInterfaces::Internal::Internal):
3979         (WebTestRunner::WebTestInterfaces::Internal::setWebView):
3980         (WebTestRunner):
3981         (WebTestRunner::WebTestInterfaces::Internal::setTestIsRunning):
3982         (WebTestRunner::WebTestInterfaces::setWebView):
3983         (WebTestRunner::WebTestInterfaces::setTestIsRunning):
3984         (WebTestRunner::WebTestInterfaces::webView):
3985         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3986         (WebTestRunner::WebTestProxyBase::willPerformClientRedirect):
3987         (WebTestRunner):
3988         (WebTestRunner::WebTestProxyBase::didCancelClientRedirect):
3989         (WebTestRunner::WebTestProxyBase::didStartProvisionalLoad):
3990         (WebTestRunner::WebTestProxyBase::didReceiveServerRedirectForProvisionalLoad):
3991         (WebTestRunner::WebTestProxyBase::didFailProvisionalLoad):
3992         (WebTestRunner::WebTestProxyBase::didCommitProvisionalLoad):
3993         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
3994         (WebTestRunner::WebTestProxyBase::didFinishDocumentLoad):
3995         (WebTestRunner::WebTestProxyBase::didHandleOnloadEvents):
3996         (WebTestRunner::WebTestProxyBase::didFailLoad):
3997         (WebTestRunner::WebTestProxyBase::didFinishLoad):
3998         (WebTestRunner::WebTestProxyBase::didChangeLocationWithinPage):
3999         (WebTestRunner::WebTestProxyBase::didDisplayInsecureContent):
4000         (WebTestRunner::WebTestProxyBase::didRunInsecureContent):
4001         (WebTestRunner::WebTestProxyBase::didDetectXSS):
4002         * DumpRenderTree/chromium/TestShell.cpp:
4003         (TestShell::runFileTest):
4004         (TestShell::testFinished):
4005         * DumpRenderTree/chromium/TestShell.h:
4006         (TestShell):
4007         * DumpRenderTree/chromium/WebViewHost.cpp:
4008         (WebViewHost::didStartProvisionalLoad):
4009         (WebViewHost::didReceiveServerRedirectForProvisionalLoad):
4010         (WebViewHost::didFailProvisionalLoad):
4011         (WebViewHost::didCommitProvisionalLoad):
4012         (WebViewHost::didReceiveTitle):
4013         (WebViewHost::didFailLoad):
4014         (WebViewHost::didFinishLoad):
4015         * DumpRenderTree/chromium/WebViewHost.h:
4016         (WebViewHost):
4017
4018 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
4019
4020         [GTK] Lower the default timeout value for WebKitTestRunner
4021         https://bugs.webkit.org/show_bug.cgi?id=106353
4022
4023         Reviewed by Dirk Pranke.
4024
4025         The default timeout value for WebKitTestRunner should be lowered.
4026         The current value (80 seconds) is irrational and just leads to producing
4027         text failures for layout tests that genuinely time out. This just leads
4028         to more deviation from the GTK WK1 port in terms of test expectations.
4029
4030         The value used is the same as when running the DumpRenderTree, that's
4031         6 seconds in release builds and 12 seconds in debug builds.
4032
4033         * Scripts/webkitpy/layout_tests/port/gtk.py:
4034         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
4035         (GtkPortTest.test_default_timeout_ms):
4036
4037 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
4038
4039         test-webkitpy shows failure output on my linux box
4040         https://bugs.webkit.org/show_bug.cgi?id=101261
4041
4042         Reviewed by Eric Seidel.
4043
4044         Mock out the PulseAudioSanitizer methods when creating testing instances
4045         of EflPort and GtkPort interfaces in unit tests. This stops throwing up
4046         PulseAudio output when the sanitizer was trying to unload modules which
4047         were already unloaded by another unit test that was being run in parallel.
4048
4049         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
4050         (EflPortTest):
4051         (EflPortTest.make_port):
4052         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
4053         (GtkPortTest):
4054         (GtkPortTest.make_port):
4055
4056 2013-01-08  Julie Parent  <jparent@chromium.org>
4057
4058         Dashboard Cleanup: Remove g_hasDoneInitialPageGeneration
4059         https://bugs.webkit.org/show_bug.cgi?id=106254
4060
4061         Remove the global variable g_hasDoneInitialPageGeneration.  It was used
4062         only to figure out if we should call addBuilderLoadErrors during
4063         handleLocationChange, which was called when the loader completed and on
4064         any hash change, but we only ever wanted to call addBuilderLoadErrors
4065         on the initial loader load.  Moved the call of addBuilderLoadErrors to
4066         resourceLoadingComplete rather than handleLocationChange, so now we
4067         only call it when we want to, and the check can go away completely.
4068
4069         Reviewed by Dirk Pranke.
4070
4071         * TestResultServer/static-dashboards/dashboard_base.js:
4072         (addBuilderLoadErrors):
4073         (resourceLoadingComplete):
4074         (handleLocationChange):
4075         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
4076
4077 2013-01-08  Dominic Mazzoni  <dmazzoni@google.com>
4078
4079         Add aboxhall@chromium.org to accessibility watchlist.
4080
4081         Unreviewed.
4082
4083         * Scripts/webkitpy/common/config/watchlist:
4084
4085 2013-01-08  Dan Winship  <danw@gnome.org>
4086
4087         Add Apache 2.4 support for Fedora 18
4088         https://bugs.webkit.org/show_bug.cgi?id=104478
4089
4090         Reviewed by Martin Robinson.
4091
4092         Apache 2.4's httpd.conf is slightly incompatible with 2.2's, so we
4093         need a separate config.
4094
4095         * Scripts/webkitpy/layout_tests/port/base.py:
4096         (Port._apache_version):
4097         (Port._apache_config_file_name_for_platform):
4098         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
4099         * Scripts/run-webkit-httpd:
4100         * Scripts/webkitperl/httpd.pm:
4101         (getApacheVersion):
4102         (getDefaultConfigForTestDirectory):
4103         (getHTTPDConfigPathForTestDirectory):
4104
4105 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
4106
4107         Make the override-feature-defines script compatible with Python v3
4108         https://bugs.webkit.org/show_bug.cgi?id=105742
4109
4110         Reviewed by Martin Robinson.
4111
4112         Instead of printing output through a statement, use the print function and format
4113         the output using the str.format method. This makes the script runnable with Python v3.
4114
4115         * gtk/override-feature-defines:
4116         (adjust_feature_defines_makefile):
4117
4118 2013-01-08  Heikki Paajanen  <heikki.paajanen@palm.com>
4119
4120         [Qt] Fix libxml2 config test
4121         https://bugs.webkit.org/show_bug.cgi?id=106317
4122
4123         Reviewed by Simon Hausmann.
4124
4125         Don't assume standard include/libxml2, libxml-2.0.pc should know
4126         where it's headers are.
4127
4128         * qmake/config.tests/libxml2/libxml2.cpp: Fix include
4129
4130 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
4131
4132         [GTK] Make Tools/gtk/generate-gtkdoc compatible with Python 3
4133         https://bugs.webkit.org/show_bug.cgi?id=106195
4134
4135         Reviewed by Philippe Normand.
4136
4137         Perform changes in the generate-gtkdoc script and common and gtkdoc modules
4138         to make the Python code compatible with Python 3. This includes modifying
4139         print statements, exception handling, dictionary iteration and
4140         byte-sequence-to-string conversion.
4141
4142         * gtk/common.py:
4143         (get_build_path):
4144         (pkg_config_file_variable):
4145         (gtk_version_of_pkg_config_file):
4146         * gtk/generate-gtkdoc:
4147         (print_missing_api):
4148         * gtk/gtkdoc.py:
4149         (GTKDoc.__init__):
4150         (GTKDoc._run_command):
4151
4152 2013-01-02  Steve Block  <steveblock@chromium.org>
4153
4154         Add chromium.org email address for Steve Block.
4155
4156         Unreviewed.
4157
4158         * Scripts/webkitpy/common/config/committers.py:
4159
4160 2013-01-07  Filip Pizlo  <fpizlo@apple.com>
4161
4162         Rationalize closure call heuristics and profiling
4163         https://bugs.webkit.org/show_bug.cgi?id=106270
4164
4165         Reviewed by Oliver Hunt.
4166         
4167         Add ability to use display-profiler-output via a pipe, and add the ability to dump
4168         all generated code ('display *' or 'd *').
4169
4170         * Scripts/display-profiler-output:
4171
4172 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
4173
4174         Sorted more xcodeproj files.
4175
4176         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
4177         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4178         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
4179
4180 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
4181
4182         Sorted xcodeproj files.
4183
4184         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4185         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4186
4187 2013-01-07  Dan Bernstein  <mitz@apple.com>
4188
4189         [mac] WebKit1 clients can’t tell when a frame has been removed from the hierarchy
4190         https://bugs.webkit.org/show_bug.cgi?id=106261
4191
4192         Reviewed by Simon Fraser.
4193
4194         Added a test for -[WebFrameLoadDelegate webView:didRemoveFrameFromHierarchy:].
4195
4196         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4197         * TestWebKitAPI/Tests/mac/WebViewDidRemoveFrameFromHierarchy.mm: Added.
4198         (-[DidRemoveFrameFromHierarchyFrameLoadDelegate webView:didFinishLoadForFrame:]):
4199         (-[DidRemoveFrameFromHierarchyFrameLoadDelegate webView:didRemoveFrameFromHierarchy:]):
4200         (TestWebKitAPI):
4201         (TestWebKitAPI::TEST):
4202
4203 2013-01-07  Ojan Vafai  <ojan@chromium.org>
4204
4205         Add the Apple MountainLion bots to garden-o-matic.
4206         Eventually, we really should move away from hardcoding
4207         the list of bots.
4208
4209         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
4210
4211 2013-01-07  Jochen Eisinger  <jochen@chromium.org>
4212
4213         [chromium] move web audio related methods to testrunner library
4214         https://bugs.webkit.org/show_bug.cgi?id=106211
4215
4216         Reviewed by Adam Barth.
4217
4218         * DumpRenderTree/chromium/DRTTestRunner.cpp:
4219         (DRTTestRunner::DRTTestRunner):
4220         (DRTTestRunner::reset):
4221         * DumpRenderTree/chromium/DRTTestRunner.h:
4222         (DRTTestRunner):
4223         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
4224         (WebKit):
4225         (WebTestRunner::WebTestRunner::shouldDumpAsAudio):
4226         (WebTestRunner::WebTestRunner::audioData):
4227         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
4228         (WebTestRunner::TestRunner::TestRunner):
4229         (WebTestRunner::TestRunner::reset):
4230         (WebTestRunner::TestRunner::shouldDumpAsAudio):
4231         (WebTestRunner):
4232         (WebTestRunner::TestRunner::audioData):
4233         (WebTestRunner::TestRunner::setAudioData):
4234         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
4235         (TestRunner):
4236         * DumpRenderTree/chromium/TestShell.cpp:
4237         (TestShell::dump):
4238
4239 2013-01-07  Mike West  <mkwst@chromium.org>
4240
4241         Make the IFRAME_SEAMLESS flag runtime-enabled.
4242         https://bugs.webkit.org/show_bug.cgi?id=106213
4243
4244         Reviewed by Ojan Vafai.
4245
4246         * DumpRenderTree/chromium/TestShell.cpp:
4247         (TestShell::TestShell):
4248         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
4249         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
4250         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4251         (resetDefaultsToConsistentValues):
4252         * DumpRenderTree/mac/DumpRenderTree.mm:
4253         (resetDefaultsToConsistentValues):
4254         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4255         (WebCore::WebPage::resetSettings):
4256         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4257         (WTR::InjectedBundle::beginTesting):
4258             Ensure that seamless IFrames are enabled for layout tests in each of
4259             the ports that support seamless IFrames.
4260
4261 2013-01-07  Jochen Eisinger  <jochen@chromium.org>
4262
4263         [chromium] move dumpAsText and friends to the TestRunner library
4264         https://bugs.webkit.org/show_bug.cgi?id=106222
4265
4266         Reviewed by Adam Barth.
4267
4268         This moves dumpAsText, dumpChildFramesAsText, and dumpChildFrameScrollPositions to the TestRunner library.
4269
4270         * DumpRenderTree/chromium/DRTTestRunner.cpp:
4271         (DRTTestRunner::DRTTestRunner):
4272         (DRTTestRunner::reset):
4273         * DumpRenderTree/chromium/DRTTestRunner.h:
4274         (DRTTestRunner):
4275         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
4276         (WebTestRunner::WebTestRunner::shouldDumpAsText):
4277         (WebTestRunner::WebTestRunner::setShouldDumpAsText):
4278         (WebTestRunner::WebTestRunner::shouldGeneratePixelResults):
4279         (WebTestRunner::WebTestRunner::setShouldGeneratePixelResults):
4280         (WebTestRunner::WebTestRunner::shouldDumpChildFrameScrollPositions):
4281         (WebTestRunner::WebTestRunner::shouldDumpChildFramesAsText):
4282         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
4283         (WebTestRunner::TestRunner::TestRunner):
4284         (WebTestRunner::TestRunner::reset):
4285         (WebTestRunner::TestRunner::shouldDumpAsText):
4286         (WebTestRunner):
4287         (WebTestRunner::TestRunner::setShouldDumpAsText):
4288         (WebTestRunner::TestRunner::shouldGeneratePixelResults):
4289         (WebTestRunner::TestRunner::setShouldGeneratePixelResults):
4290         (WebTestRunner::TestRunner::shouldDumpChildFrameScrollPositions):
4291         (WebTestRunner::TestRunner::shouldDumpChildFramesAsText):
4292         (WebTestRunner::TestRunner::dumpAsText):
4293         (WebTestRunner::TestRunner::dumpChildFrameScrollPositions):
4294         (WebTestRunner::TestRunner::dumpChildFramesAsText):
4295         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
4296         (TestRunner):
4297
4298 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
4299
4300         Build fix attempt after r138810.
4301
4302         Apparently python 2.6 is really bad at floating point computation.
4303
4304         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
4305         (MainTest.test_run_memory_test):
4306
4307 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
4308
4309         Extract a class to represent a test result to simplify PerfTest.parse_output and PageLoadPerfTest._run_with_driver
4310         https://bugs.webkit.org/show_bug.cgi?id=106172
4311
4312         Reviewed by Tony Chang.
4313
4314         Extracted PerfTestMetric, which represents a test result and knows how to compute statistics and convert itself
4315         to a dictionary. A metric is a type of measurement each test makes such as "Time", "Malloc", and "JSHeap".
4316         A single test (e.g. html5-full-render.html) may have multiple metrics, each of which is reported as a separate
4317         test on perf-o-matic and perf. test's results page.
4318
4319         Also, use python's compute_statistics instead of reading statistics off of DriverOutput to simplify the code.
4320
4321         * Scripts/webkitpy/performance_tests/perftest.py:
4322         (PerfTestMetric): Added.
4323         (PerfTestMetric.__init__): Added.
4324         (PerfTestMetric.metric): Added.
4325         (PerfTestMetric.has_values): Added.
4326         (PerfTestMetric.legacy_chromium_bot_compatible_test_name): Added. Following the legacy convention, "Malloc" and
4327         "JSHeap" will use "test_name:Malloc" whereas "Time" uses "test_name" itself. We should eventually move these
4328         conversions to be done on the client side (perf-o-matic and results page).
4329         (PerfTestMetric.append): Added.
4330         (PerfTestMetric.to_dict): Added. Computes the statistics and generates the dictionary object that represents
4331         a result for this metric.
4332         (PerfTestMetric.metric_to_unit): Added. Each metric maps to exactly one unit (it's not one-to-one).
4333         (PerfTestMetric.compute_statistics): Moved from PerfTest.
4334
4335         (PerfTest._create_driver): Extracted from PerfTest.run.
4336         (PerfTest.run): Given an array of PerfTestMetric, generate the&