4c943998088645d70560d6bf21b81284db7b0b3c
[WebKit-https.git] / Tools / ChangeLog
1 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
2
3         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
4         https://bugs.webkit.org/show_bug.cgi?id=195849
5
6         Reviewed by Chris Dumez.
7
8         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
9
10         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
11         (runWebsiteDataStoreCustomPaths):
12
13 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
14
15         webkitpy: Upload test results
16         https://bugs.webkit.org/show_bug.cgi?id=195755
17         <rdar://problem/48896182>
18
19         Reviewed by Aakash Jain.
20
21         Establish a new format for uploading results that is not tied to layout tests, apply
22         that format to webkitpy tests.
23
24         * Scripts/webkitpy/common/checkout/scm/git.py:
25         (Git.native_branch): Return what branch the current checkout is on.
26         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
27         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
28         * Scripts/webkitpy/common/checkout/scm/svn.py:
29         (SVN.native_branch): Ditto.
30         * Scripts/webkitpy/common/system/platforminfo.py:
31         (PlatformInfo.build_version): Return a build version for Mac.
32         * Scripts/webkitpy/common/system/platforminfo_mock.py:
33         (MockPlatformInfo.__init__):
34         (MockPlatformInfo.build_version):
35         * Scripts/webkitpy/results: Added.
36         * Scripts/webkitpy/results/__init__.py: Added.
37         * Scripts/webkitpy/results/options.py: Added.
38         (upload_options): OptParse list for upload options.
39         * Scripts/webkitpy/results/upload.py: Added.
40         (Upload): Class which enforces the upload format expected by the results server.
41         (Upload.Expectations):
42         (Upload.create_configuration):
43         (Upload.create_commit):
44         (Upload.create_details):
45         (Upload.create_run_stats):
46         (Upload.create_test_result):
47         (Upload.__init__):
48         (Upload.Encoder): Encode Upload object as json.
49         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
50         * Scripts/webkitpy/results/upload_unittest.py: Added.
51         * Scripts/webkitpy/test/main.py:
52         (Tester._parse_args): Add upload arguments.
53         (Tester._run_tests): Allow results to be uploaded.
54         * Scripts/webkitpy/test/runner.py:
55         (Runner.__init__): Record which tests were run, rather than just counting them.
56         (Runner.handle):
57         * Scripts/webkitpy/test/runner_unittest.py:
58         (RunnerTest.test_run):
59         * Scripts/webkitpy/thirdparty/__init__.py:
60         (AutoinstallImportHook.find_module): Add requests auto-install.
61         (AutoinstallImportHook._install_requests):
62         * Scripts/webkitpy/tool/commands/queues_unittest.py:
63         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
64
65 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
66
67         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
68         https://bugs.webkit.org/show_bug.cgi?id=195810
69
70         Reviewed by Tim Horton.
71
72         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
73         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
74         ending certain layout tests.
75
76         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
77         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
78         (-[TestRunnerWKWebView dealloc]):
79         (-[TestRunnerWKWebView resetInteractionCallbacks]):
80
81         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
82         helper method when destroying the web view, and when resetting state between tests.
83
84         * WebKitTestRunner/ios/TestControllerIOS.mm:
85         (WTR::TestController::platformResetStateToConsistentValues):
86
87         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
88
89 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
90
91         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
92         https://bugs.webkit.org/show_bug.cgi?id=190350
93         <rdar://problem/45089503>
94
95         Reviewed by Geoffrey Garen.
96
97         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
98         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
99         (TEST):
100         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
101         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
102         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
103         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
104         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
105         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
106         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
107         (runTest):
108         (createDirectories):
109         (TEST):
110         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
111         (TEST):
112         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
113         (TEST):
114
115 2019-03-15  Timothy Hatcher  <timothy@apple.com>
116
117         Add support to WebPage for getting the contents as an attributed string.
118         https://bugs.webkit.org/show_bug.cgi?id=195636
119         rdar://problem/45055697
120
121         Reviewed by Tim Horton.
122
123         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
124         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
125
126 2019-03-15  Chris Dumez  <cdumez@apple.com>
127
128         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
129         https://bugs.webkit.org/show_bug.cgi?id=195747
130
131         Reviewed by Geoff Garen.
132
133         Add API test coverage.
134
135         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
136
137 2019-03-15  Shawn Roberts  <sroberts@apple.com>
138
139         Unreviewed, rolling out r242952.
140
141         Causing API failures on iOS Simulator
142
143         Reverted changeset:
144
145         "[PSON] Make sure the WebProcessCache is leverage when
146         relaunching a process after termination"
147         https://bugs.webkit.org/show_bug.cgi?id=195747
148         https://trac.webkit.org/changeset/242952
149
150 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
151
152         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
153         https://bugs.webkit.org/show_bug.cgi?id=195740
154
155         Reviewed by Ross Kirsling.
156
157         window.open doesn't work for WebKitBrowserWindow because it is not
158         implemented yet.
159
160         1. Implemented createNewPage callback of WKPageUIClient.
161         2. Changed MainWindow to take a BrowserWindow factory function
162           instead of BrowserWindowType to be flexible to create
163           BrowserWindow with extra settings.
164         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
165           because it is not relevant with MainWindow anymore.
166
167         * MiniBrowser/win/Common.cpp:
168         (parseCommandLine):
169         * MiniBrowser/win/Common.h:
170         (CommandLineOptions::CommandLineOptions):
171         * MiniBrowser/win/MainWindow.cpp:
172         (MainWindow::MainWindow):
173         (MainWindow::create):
174         (MainWindow::init):
175         (MainWindow::WndProc):
176         * MiniBrowser/win/MainWindow.h:
177         * MiniBrowser/win/PrintWebUIDelegate.cpp:
178         (PrintWebUIDelegate::createWebViewWithRequest):
179         * MiniBrowser/win/WebKitBrowserWindow.cpp:
180         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
181         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
182         (WebKitBrowserWindow::updateProxySettings):
183         (WebKitBrowserWindow::createNewPage):
184         * MiniBrowser/win/WebKitBrowserWindow.h:
185         * MiniBrowser/win/WinMain.cpp:
186         (wWinMain):
187
188 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
189
190         Make it possible to test scrolling tree layer manipulation more easily
191         https://bugs.webkit.org/show_bug.cgi?id=195780
192
193         Reviewed by Tim Horton.
194         
195         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
196         cuts off communication of scrolling tree scrolls back to the web process
197         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
198         allows tests to trigger scrolls which run the scrolling tree layer positioning
199         logic, but never get another commit from the web process that might mask
200         scrolling tree bugs.
201         
202         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
203         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
204         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
205
206         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
207         (WTR::UIScriptController::scrollUpdatesDisabled const):
208         (WTR::UIScriptController::setScrollUpdatesDisabled):
209         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
210         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
211         (WTR::UIScriptController::scrollUpdatesDisabled const):
212         (WTR::UIScriptController::setScrollUpdatesDisabled):
213         * TestRunnerShared/UIScriptContext/UIScriptController.h:
214         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
215         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
216         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
217         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
218         * WebKitTestRunner/ios/TestControllerIOS.mm:
219         (WTR::TestController::platformResetStateToConsistentValues):
220         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
221         (WTR::UIScriptController::scrollUpdatesDisabled const):
222         (WTR::UIScriptController::setScrollUpdatesDisabled):
223
224 2019-03-14  Youenn Fablet  <youenn@apple.com>
225
226         Move IDB storage in private browsing mode to NetworkProcess
227         https://bugs.webkit.org/show_bug.cgi?id=195602
228
229         Reviewed by Brady Eidson.
230
231         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
232         (TEST):
233
234 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
235
236         [ews-build] Make descriptionDone messages more readable
237         https://bugs.webkit.org/show_bug.cgi?id=195760
238
239         Reviewed by Lucas Forschler.
240
241         * BuildSlaveSupport/ews-build/steps.py:
242         * BuildSlaveSupport/ews-build/steps_unittest.py:
243
244 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
245
246         [ews-build] Generate status-bubble hover-over messages
247         https://bugs.webkit.org/show_bug.cgi?id=195680
248
249         Reviewed by Lucas Forschler.
250
251         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
252         (StatusBubble):
253         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
254         on hover-over.
255         (StatusBubble._iso_time):
256         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
257         hover-over message.
258         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
259
260 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
261
262         [ews-app] Gracefully handle the case when state_string is None
263         https://bugs.webkit.org/show_bug.cgi?id=195753
264
265         Reviewed by Lucas Forschler.
266
267         * BuildSlaveSupport/ews-app/ews/models/build.py:
268         * BuildSlaveSupport/ews-app/ews/models/step.py:
269
270 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
271
272         [ews-app] Status bubble display pending for currently running build step
273         https://bugs.webkit.org/show_bug.cgi?id=195744
274
275         Reviewed by Lucas Forschler.
276
277         * BuildSlaveSupport/ews-build/events.py:
278         (Events.stepStarted): If state_string is pending, replace it with step name.
279
280 2019-03-14  Chris Dumez  <cdumez@apple.com>
281
282         Add WebsitePolicy for the client to specify the device orientation & motion access policy
283         https://bugs.webkit.org/show_bug.cgi?id=195750
284
285         Reviewed by Geoffrey Garen.
286
287         Add API test coverage.
288
289         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
290         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
291         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
292         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
293
294 2019-03-14  Chris Dumez  <cdumez@apple.com>
295
296         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
297         https://bugs.webkit.org/show_bug.cgi?id=195747
298
299         Reviewed by Geoff Garen.
300
301         Add API test coverage.
302
303         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
304
305 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
306
307         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
308         https://bugs.webkit.org/show_bug.cgi?id=195725
309         <rdar://problem/48545062>
310
311         Reviewed by Tim Horton.
312
313         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
314         handler is nil.
315
316         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
317         (TestWebKitAPI::TEST):
318
319 2019-03-13  Sam Weinig  <sam@webkit.org>
320
321         Add utility function to allow easy reverse range-based iteration of a container
322         https://bugs.webkit.org/show_bug.cgi?id=195542
323
324         Reviewed by Antti Koivisto.
325
326         * TestWebKitAPI/CMakeLists.txt:
327         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
328         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
329         (TestWebKitAPI::TEST):
330         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
331
332 2019-03-13  Chris Dumez  <cdumez@apple.com>
333
334         Use a ServiceWorker process per registrable domain
335         https://bugs.webkit.org/show_bug.cgi?id=195649
336
337         Reviewed by Youenn Fablet.
338
339         Update API test coverage.
340
341         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
342
343 2019-03-13  Chris Dumez  <cdumez@apple.com>
344
345         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
346         https://bugs.webkit.org/show_bug.cgi?id=195684
347         <rdar://problem/48294714>
348
349         Reviewed by Antti Koivisto.
350
351         Add API test coverage.
352
353         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
354
355 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
356
357         [ews-app] Remove unused patch view
358         https://bugs.webkit.org/show_bug.cgi?id=195669
359
360         Reviewed by Lucas Forschler.
361
362         * BuildSlaveSupport/ews-app/ews/urls.py:
363         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
364
365 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
366
367         [ews-app] Use Buildbot result code variables
368         https://bugs.webkit.org/show_bug.cgi?id=195668
369
370         Reviewed by Alexey Proskuryakov.
371
372         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
373         (Buildbot): Added Buildbot result code variables.
374         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
375         (StatusBubble._build_bubble): Used Buildbot result code variables.
376
377 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
378
379         [Flatpak] Expand submodule recursively
380         https://bugs.webkit.org/show_bug.cgi?id=195672
381
382         Building WPE with flatpak was impossible without that as it was raising an exception.
383         Also update wpebackend-fdo to match what is built in jhbuild
384
385         Reviewed by Philippe Normand.
386
387         * flatpak/flatpakutils.py:
388         (expand_submodules_recurse):
389         (expand_manifest):
390         * flatpak/org.webkit.WPEModules.yaml:
391
392 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
393
394         [ews-app] status bubble should be hidden for certain builds
395         https://bugs.webkit.org/show_bug.cgi?id=194597
396
397         Reviewed by Dewei Zhu.
398
399         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
400         (StatusBubble._build_bubble):
401         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
402         because the patch didn't have relevant changes.
403         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
404         in production yet.
405
406 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
407
408         [Win] Fix a slew of simple clang-cl warnings.
409         https://bugs.webkit.org/show_bug.cgi?id=195652
410
411         Reviewed by Don Olmstead.
412
413         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
414         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
415
416 2019-03-12  Justin Fan  <justin_fan@apple.com>
417
418         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
419         https://bugs.webkit.org/show_bug.cgi?id=195518
420         <rdar://problem/46322356>
421
422         Reviewed by Myles C. Maxfield.
423
424         * DumpRenderTree/DerivedSources-input.xcfilelist:
425         * DumpRenderTree/DerivedSources-output.xcfilelist:
426
427 2019-03-12  Commit Queue  <commit-queue@webkit.org>
428
429         Unreviewed, rolling out r242825.
430         https://bugs.webkit.org/show_bug.cgi?id=195648
431
432         "Broke webkitpy tests with my change to
433         lldb_dump_class_layout.py" (Requested by rmorisset on
434         #webkit).
435
436         Reverted changeset:
437
438         "Alter Tools/Scripts/dump-class-layout to be able to dump all
439         classes with suspicious padding"
440         https://bugs.webkit.org/show_bug.cgi?id=195573
441         https://trac.webkit.org/changeset/242825
442
443 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
444
445         [ews-build] Show status bubbles while the patch is waiting in queue
446         https://bugs.webkit.org/show_bug.cgi?id=195618
447
448         Reviewed by Lucas Forschler.
449
450         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
451         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
452         enabled in initial deployment.
453         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
454         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
455         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
456         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
457         (StatusBubble._build_bubbles_for_patch):
458
459 2019-03-12  Robin Morisset  <rmorisset@apple.com>
460
461         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
462         https://bugs.webkit.org/show_bug.cgi?id=195573
463
464         Reviewed by Simon Fraser.
465
466         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
467
468         * Scripts/dump-class-layout:
469         (main):
470         * lldb/lldb_dump_class_layout.py:
471         (ClassLayout.__init__):
472         (ClassLayout._compute_padding_recursive):
473         (LLDBDebuggerInstance.dump_layout_for_classname):
474         (LLDBDebuggerInstance):
475         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
476         (LLDBDebuggerInstance.layout_for_classname): Deleted.
477
478 2019-03-12  Chris Dumez  <cdumez@apple.com>
479
480         Device Orientation access permission should be denied unless explicitly granted by the client
481         https://bugs.webkit.org/show_bug.cgi?id=195625
482
483         Reviewed by Youenn Fablet.
484
485         add API test coverage.
486
487         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
488         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
489         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
490         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
491         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
492         (runDeviceOrientationTest):
493         (TEST):
494         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
495         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
496
497 2019-03-12  Jer Noble  <jer.noble@apple.com>
498
499         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
500         https://bugs.webkit.org/show_bug.cgi?id=195137
501         <rdar://problem/48810307>
502
503         Reviewed by Eric Carlson.
504
505         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
506         (TestWebKitAPI::TEST):
507
508 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
509
510         [ews-build] Change urls from uat to production
511         https://bugs.webkit.org/show_bug.cgi?id=195566
512
513         Reviewed by Lucas Forschler.
514
515         * BuildSlaveSupport/ews-app/ews/config.py:
516         * BuildSlaveSupport/ews-build/events.py:
517         * BuildSlaveSupport/ews-build/steps.py:
518
519 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
520
521         [ews-build] change max_builds for local-worker to 1
522         https://bugs.webkit.org/show_bug.cgi?id=195568
523
524         Reviewed by Lucas Forschler.
525
526         * BuildSlaveSupport/ews-build/loadConfig.py:
527
528 2019-03-12  Tim Horton  <timothy_horton@apple.com>
529
530         Fix the build
531
532         * TestRunnerShared/spi/PencilKitTestSPI.h:
533         * TestWebKitAPI/ios/PencilKitTestSPI.h:
534
535 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
536
537         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
538         https://bugs.webkit.org/show_bug.cgi?id=194131
539
540         Reviewed by Michael Catanzaro.
541
542         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
543         (uriChanged):
544         (testUnfinishedSubresourceLoad):
545         (serverCallback):
546         (beforeAll):
547
548 2019-03-11  Alex Christensen  <achristensen@webkit.org>
549
550         WTF::Expected should use std::addressof instead of operator&
551         https://bugs.webkit.org/show_bug.cgi?id=195604
552
553         Reviewed by Myles Maxfield.
554
555         * TestWebKitAPI/Tests/WTF/Expected.cpp:
556         (TestWebKitAPI::Unique::Unique):
557         (TestWebKitAPI::Unique::operator&):
558         (TestWebKitAPI::TEST):
559
560 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
561
562         Add Optional to Forward.h.
563         https://bugs.webkit.org/show_bug.cgi?id=195586
564
565         Reviewed by Darin Adler.
566
567         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
568         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
569         Remove unnecessary includes from headers.
570
571 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
572
573         Add testing API to hit-test and scroll overflow scrollers
574         https://bugs.webkit.org/show_bug.cgi?id=195278
575
576         Reviewed by Antti Koivisto.
577         
578         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
579         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
580         
581         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
582
583         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
584         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
585         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
586         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
587         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
588         * TestRunnerShared/UIScriptContext/UIScriptController.h:
589         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
590         (WTR::enclosingScrollViewIncludingSelf):
591         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
592
593 2019-03-11  Tim Horton  <timothy_horton@apple.com>
594
595         API test WebKit.RequestTextInputContext fails on iOS
596         https://bugs.webkit.org/show_bug.cgi?id=195585
597
598         Reviewed by Wenson Hsieh and Simon Fraser.
599
600         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
601         (applyStyle):
602         (TEST):
603         Add a viewport, so that the coordinates match up on iOS.
604         Scroll by moving the UIScrollView's contentOffset.
605
606 2019-03-11  Chris Dumez  <cdumez@apple.com>
607
608         Assert in WebPageProxy::suspendCurrentPageIfPossible()
609         https://bugs.webkit.org/show_bug.cgi?id=195506
610         <rdar://problem/48733477>
611
612         Reviewed by Alex Christensen.
613
614         Add API test coverage.
615
616         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
617
618 2019-03-11  Shawn Roberts  <sroberts@apple.com>
619
620         Adding myself to contributors.json
621
622         Unreviewed, addming myself to contributors.json .
623
624         * Scripts/webkitpy/common/config/contributors.json:
625
626 2019-03-11  Alex Christensen  <achristensen@webkit.org>
627
628         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
629         https://bugs.webkit.org/show_bug.cgi?id=195511
630         <rdar://problem/44873269>
631
632         Reviewed by Darin Adler.
633
634         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
635         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
636         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
637         (TEST_F):
638
639 2019-03-11  Chris Dumez  <cdumez@apple.com>
640
641         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
642         https://bugs.webkit.org/show_bug.cgi?id=195561
643
644         Reviewed by Youenn Fablet.
645
646         Make sure the JS in the test requests for permission to receive device orientation events.
647
648         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
649
650 2019-03-11  Youenn Fablet  <youenn@apple.com>
651
652         Allow storage quota increase by default in WTR
653         https://bugs.webkit.org/show_bug.cgi?id=195541
654
655         Reviewed by Geoffrey Garen.
656
657         Allow storage quota increase by default in WTR.
658         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
659         Use this for tests that explicitly need cache increase.
660
661         Instead of increasing quota by 2, make sure the next request is
662         granted by adding all given parameters.
663
664         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
665         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
666         (WTR::TestRunner::setAllowStorageQuotaIncrease):
667         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
668         * WebKitTestRunner/InjectedBundle/TestRunner.h:
669         * WebKitTestRunner/TestController.cpp:
670         (WTR::TestController::setAllowStorageQuotaIncrease):
671         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
672         * WebKitTestRunner/TestController.h:
673         * WebKitTestRunner/TestInvocation.cpp:
674         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
675         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
676         (WTR::TestController::cocoaResetStateToConsistentValues):
677         (WTR::TestController::setAllowStorageQuotaIncrease):
678         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
679         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
680         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
681
682 2019-03-11  Xan Lopez  <xan@igalia.com>
683
684         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
685         https://bugs.webkit.org/show_bug.cgi?id=194147
686
687         Reviewed by Michael Saboff.
688
689         To make --32-bit work correctly on Linux/64bit we need to:
690
691         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
692         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
693         unfortunately CMake only allows us to do this during
694         crosscompilation, which is overkill here.
695         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
696         pkg-config detection module uses the x86 .pc files instead of the
697         x86_64 ones.
698         - Set the -m32 flags for the compiler.
699
700         * Scripts/webkitdirs.pm:
701         (generateBuildSystemFromCMakeProject):
702
703 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
704
705         Add MotionMark-1.1 plan file for run-benchmark script.
706         https://bugs.webkit.org/show_bug.cgi?id=195481
707
708         Rubber-stamped by Darin Adler.
709
710         Run-benchmark script should support MontionMark-1.1.
711
712         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
713
714 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
715
716         [ews-app] Add support for submit-to-ews url
717         https://bugs.webkit.org/show_bug.cgi?id=195477
718
719         Reviewed by Lucas Forschler.
720
721         * BuildSlaveSupport/ews-app/ews/fetcher.py:
722         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
723         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
724         * BuildSlaveSupport/ews-app/ews/urls.py:
725         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
726
727 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
728
729         Unreviewed, rolling out r242688, r242643, r242624.
730
731         Caused multiple layout test failures and crashes on iOS and macOS.
732
733         Reverted changeset:
734
735         "requestAnimationFrame should execute before the next frame"
736         https://bugs.webkit.org/show_bug.cgi?id=177484
737         https://trac.webkit.org/changeset/242624/webkit
738
739         * Tracing/SystemTracePoints.plist:
740
741 2019-03-11  John Wilander  <wilander@apple.com>
742
743         Resource Load Statistics: Make it possible exclude localhost from classification
744         https://bugs.webkit.org/show_bug.cgi?id=195474
745         <rdar://problem/47520577>
746
747         Reviewed by Brent Fulgham.
748
749         This patch allows for localhost to be excluded from classification and
750         treatment as a prevalent resource.
751
752         The WebKit Tools change adds a new function called
753         testRunner.setStatisticsIsRunningTest() which can be used to control this
754         behavior.
755
756         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
757         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
758         (WTR::TestRunner::setStatisticsIsRunningTest):
759         * WebKitTestRunner/InjectedBundle/TestRunner.h:
760         * WebKitTestRunner/TestController.cpp:
761         (WTR::TestController::setStatisticsIsRunningTest):
762         * WebKitTestRunner/TestController.h:
763         * WebKitTestRunner/TestInvocation.cpp:
764         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
765
766 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
767
768         [ews-build] Disable waterfall and console view for ews-build.webkit.org
769         https://bugs.webkit.org/show_bug.cgi?id=195560
770
771         Reviewed by Lucas Forschler.
772
773         * BuildSlaveSupport/ews-build/master.cfg:
774
775 2019-03-11  Alex Christensen  <achristensen@webkit.org>
776
777         Unreviewed, rolling out r242698.
778
779         API test crashes on bots.
780
781         Reverted changeset:
782
783         "Add a WKContentRuleList variant that uses copied memory
784         instead of mmap'd shared memory for class A containerized
785         apps"
786         https://bugs.webkit.org/show_bug.cgi?id=195511
787         https://trac.webkit.org/changeset/242698
788
789 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
790
791         [WPE] Enable web process sandbox
792         https://bugs.webkit.org/show_bug.cgi?id=195169
793
794         Reviewed by Daniel Bates.
795
796         * wpe/install-dependencies:
797         * wpe/jhbuild.modules:
798
799 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
800
801         [ews-app] Use port 17000 for worker communication
802         https://bugs.webkit.org/show_bug.cgi?id=195558
803
804         Reviewed by Lucas Forschler.
805
806         * BuildSlaveSupport/ews-build/master.cfg:
807
808 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
809
810         [ews-build] unit-tests fail when passwords.json is missing
811         https://bugs.webkit.org/show_bug.cgi?id=195557
812
813         Reviewed by Lucas Forschler.
814
815         * BuildSlaveSupport/ews-build/loadConfig.py:
816         (loadBuilderConfig):
817         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
818         (ConfigDotJSONTest.test_configuration):
819         * BuildSlaveSupport/ews-build/master.cfg:
820
821 2019-03-11  Truitt Savell  <tsavell@apple.com>
822
823         Unreviewed, rolling out r242702.
824
825         Broke High Sierra builders.
826
827         Reverted changeset:
828
829         "Add utility function to allow easy reverse range-based
830         iteration of a container"
831         https://bugs.webkit.org/show_bug.cgi?id=195542
832         https://trac.webkit.org/changeset/242702
833
834 2019-03-11  Sam Weinig  <sam@webkit.org>
835
836         Add utility function to allow easy reverse range-based iteration of a container
837         https://bugs.webkit.org/show_bug.cgi?id=195542
838
839         Reviewed by Antti Koivisto.
840
841         * TestWebKitAPI/CMakeLists.txt:
842         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
843         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
844         (TestWebKitAPI::TEST):
845         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
846
847 2019-03-10  Alex Christensen  <achristensen@webkit.org>
848
849         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
850         https://bugs.webkit.org/show_bug.cgi?id=195511
851         <rdar://problem/44873269>
852
853         Reviewed by Darin Adler.
854
855         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
856         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
857         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
858         (TEST_F):
859
860 2019-03-10  Tim Horton  <timothy_horton@apple.com>
861
862         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
863         https://bugs.webkit.org/show_bug.cgi?id=195499
864
865         Reviewed by Darin Adler.
866
867         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
868         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
869         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
870         (-[WKWebView synchronouslyFocusTextInputContext:]):
871         (applyStyle):
872         (applyIframe):
873         (TEST):
874         Add some tests for this SPI.
875
876 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
877
878         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
879         https://bugs.webkit.org/show_bug.cgi?id=181151
880
881         Reviewed by Don Olmstead.
882
883         * TestWebKitAPI/CMakeLists.txt:
884         * TestWebKitAPI/PlatformWin.cmake:
885         Enable TestWTF RunLoop tests in all platforms.
886
887         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
888         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
889         (TestWebKitAPI::DerivedOneShotTimer::fired):
890         (TestWebKitAPI::TEST):
891         Only a few platforms support nested RunLoop.
892
893         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
894         (TestWebKitAPI::DerivedRepeatingTimer::fired):
895
896 2019-03-10  David Quesada  <david_quesada@apple.com>
897
898         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
899         https://bugs.webkit.org/show_bug.cgi?id=152480
900
901         Reviewed by Chris Dumez.
902
903         Add a unit test based on Daniel Bates's test case that starts a download, ensures
904         there are no additional references to the process pool besides the one held by
905         the download, waits for the download to finish (in the sense that the
906         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
907         measure, also check that the process pool has been deallocated at the end of the
908         test. The test wouldn't be meaningful if the process pool were still alive.
909
910         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
911         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
912         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
913             The download will be canceled because the delegate does not implement the
914             method to decide the download's destination, so this is where we know the
915             DownloadProxyMap is done with the DownloadProxy.
916         (TEST):
917
918 2019-03-08  Chris Dumez  <cdumez@apple.com>
919
920         Add support for Device Orientation / Motion permission API
921         https://bugs.webkit.org/show_bug.cgi?id=195329
922         <rdar://problem/47645367>
923
924         Reviewed by Geoffrey Garen.
925
926         Add test infrastructure to help test the Device Orientation / Motion permission API.
927
928         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
929         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
930         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
931         * WebKitTestRunner/InjectedBundle/TestRunner.h:
932         * WebKitTestRunner/TestController.cpp:
933         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
934         (WTR::TestController::createWebViewWithOptions):
935         (WTR::TestController::resetStateToConsistentValues):
936         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
937         * WebKitTestRunner/TestController.h:
938         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
939         * WebKitTestRunner/TestInvocation.cpp:
940         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
941
942 2019-03-08  Saam barati  <sbarati@apple.com>
943
944         Add a compare-results script to compare benchmark results
945         https://bugs.webkit.org/show_bug.cgi?id=195486
946         <rdar://problem/48723397>
947
948         Reviewed by Geoffrey Garen.
949
950         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
951         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
952         to extend it to learn about our other benchmarks.
953
954         * Scripts/compare-results: Added.
955         (readJSONFile):
956         (detectJetStream2):
957         (JetStream2Results):
958         (detectSpeedometer2):
959         (Speedometer2Results):
960         (detectPLT5):
961         (PLT5Results):
962         (detectBenchmark):
963         (biggerIsBetter):
964         (ttest):
965         (getOptions):
966         (main):
967
968 2019-03-08  Stephanie Lewis  <slewis@apple.com>
969
970         Ensure old tab state is cleared between iterations of run-benchmark
971         https://bugs.webkit.org/show_bug.cgi?id=195393
972         <rdar://problem/46885583>
973
974         Reviewed by Dewei Zhu.
975
976         a) ensure the default to restore state is not set
977         b) terminate Safari correctly
978         c) Set the system default to ignore Persistent State in Safari
979
980         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
981         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
982         (OSXBrowserDriver.prepare_env): 
983         (OSXBrowserDriver.restore_env):
984         (OSXBrowserDriver.close_browsers):
985         (OSXBrowserDriver._terminate_processes):
986         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
987         (OSXChromeDriver):
988         (OSXChromeCanaryDriver):
989         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
990         (OSXFirefoxDriver):
991         (OSXFirefoxNightlyDriver):
992         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
993         (OSXSafariDriver):
994         (OSXSafariDriver.prepare_env):
995
996 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
997
998         [GTK] Several InputMethodFilter tests are failing
999         https://bugs.webkit.org/show_bug.cgi?id=195408
1000
1001         Reviewed by Carlos Garcia Campos.
1002
1003         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
1004         Regressed in r241751.
1005         Hexadecimal values of keycodes are expressed now in upper letters.
1006         Composited characters should be cast to UTF8 strings.
1007
1008         (TestWebKitAPI::TEST):
1009
1010 2019-03-07  Tomas Popela  <tpopela@redhat.com>
1011
1012         [GTK] Make Tools/gtkdoc python3 compatible
1013         https://bugs.webkit.org/show_bug.cgi?id=195359
1014
1015         Reviewed by Carlos Garcia Campos.
1016
1017         * gtkdoc/generate-gtkdoc:
1018         ConfigParser was reworked in Python 3.2 so we have adapt the code to
1019         work with Python 2 and 3.
1020         (get_gtkdoc_module_paths):
1021         The iteritems() was removed in Python 3, so let's use items() that's
1022         available in Python 2 and 3.
1023         (get_generator_for_config):
1024         * gtkdoc/gtkdoc.py:
1025         (GTKDoc._run_command):
1026         The sys.stdout.write() is expecting str in Python 3 and not bytes
1027         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
1028         for passing the bytes there.
1029
1030 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
1031
1032         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
1033         https://bugs.webkit.org/show_bug.cgi?id=195346
1034         <rdar://problem/48667048>
1035
1036         Unreviewed build fix for clang-cl.
1037
1038         * DumpRenderTree/win/DumpRenderTree.cpp:
1039         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
1040
1041 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
1042
1043         requestAnimationFrame should execute before the next frame
1044         https://bugs.webkit.org/show_bug.cgi?id=177484
1045
1046         Reviewed by Simon Fraser.
1047
1048         Add trace points for the page RenderingUpdate.
1049
1050         * Tracing/SystemTracePoints.plist:
1051
1052 2019-03-07  Zalan Bujtas  <zalan@apple.com>
1053
1054         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
1055         https://bugs.webkit.org/show_bug.cgi?id=195353
1056         <rdar://problem/48626394>
1057
1058         Reviewed by Simon Fraser.
1059
1060         * WebKitTestRunner/ios/TestControllerIOS.mm:
1061         (WTR::TestController::platformResetPreferencesToConsistentValues):
1062
1063 2019-03-07  John Wilander  <wilander@apple.com>
1064
1065         Resource Load Statistics: Make it possible to purge only script-accessible cookies
1066         https://bugs.webkit.org/show_bug.cgi?id=195383
1067         <rdar://problem/48570136>
1068
1069         Reviewed by Brent Fulgham.
1070
1071         This patch adds test infrastructure to purge only script-accessible cookies,
1072         including a new testRunner function called statisticsDeleteCookiesForHost().git a
1073
1074         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1075         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1076         (WTR::TestRunner::statisticsDeleteCookiesForHost):
1077         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1078         * WebKitTestRunner/TestController.cpp:
1079         (WTR::TestController::statisticsDeleteCookiesForHost):
1080         * WebKitTestRunner/TestController.h:
1081         * WebKitTestRunner/TestInvocation.cpp:
1082         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1083
1084 2019-03-07  Commit Queue  <commit-queue@webkit.org>
1085
1086         Unreviewed, rolling out r242354.
1087         https://bugs.webkit.org/show_bug.cgi?id=195402
1088
1089         breaks layout tests in all configurations (Requested by
1090         zdobersek on #webkit).
1091
1092         Reverted changeset:
1093
1094         "[WPE] Enable web process sandbox"
1095         https://bugs.webkit.org/show_bug.cgi?id=195169
1096         https://trac.webkit.org/changeset/242354
1097
1098 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
1099
1100         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
1101         https://bugs.webkit.org/show_bug.cgi?id=195346
1102
1103         Reviewed by Fujii Hironori.
1104
1105         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
1106         (TestWebKitAPI::TEST):
1107         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
1108
1109         * DumpRenderTree/win/DumpRenderTree.cpp:
1110         (findFontFallback):
1111         (addFontFallbackIfPresent):
1112         (removeFontFallbackIfPresent):
1113         (main):
1114         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1115         (TestWebKitAPI::Util::moduleDirectory):
1116         (TestWebKitAPI::Util::createInjectedBundlePath):
1117         Use wchar helpers as needed.
1118
1119 2019-03-06  Rob Buis  <rbuis@igalia.com>
1120
1121         Consider supporting the `referrerpolicy` attribute.
1122         https://bugs.webkit.org/show_bug.cgi?id=179053
1123
1124         Reviewed by Darin Adler.
1125
1126         Add a runtime flag for referrerpolicy attribute.
1127
1128         * DumpRenderTree/mac/DumpRenderTree.mm:
1129         (enableExperimentalFeatures):
1130
1131 2019-03-05  Daniel Bates  <dabates@apple.com>
1132
1133         Update expected API test result following r242379
1134         (https://bugs.webkit.org/show_bug.cgi?id=195125)
1135
1136         Update expected x-coordinate of selection rect now that the left padding of
1137         a textarea is sized in ems (so dependent on the font size) just like the left
1138         padding of a text field.
1139
1140         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1141         (TestWebKitAPI::TEST):
1142
1143 2019-03-05  David Quesada  <david_quesada@apple.com>
1144
1145         [WK2] It should be possible to follow links with 'download' attributes
1146         https://bugs.webkit.org/show_bug.cgi?id=195145
1147         rdar://problem/48462642
1148
1149         Reviewed by Alex Christensen.
1150
1151         Add a unit test to verify that activating links with 'download' attributes now
1152         navigates to the linked resource, rather than starts downloading it. Add another
1153         to verify that it is still possible to explicitly download the link via the
1154         'Download' navigation action policy.
1155
1156         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1157         (-[DownloadAttributeTestDelegate init]):
1158         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
1159         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
1160         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
1161         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
1162         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1163         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
1164         (TEST):
1165         * WebKitTestRunner/TestController.cpp:
1166         (WTR::TestController::decidePolicyForNavigationAction):
1167         * WebKitTestRunner/TestController.h:
1168
1169 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
1170
1171         [Curl] Implement Cookie Accept Policy.
1172         https://bugs.webkit.org/show_bug.cgi?id=191645
1173
1174         Reviewed by Fujii Hironori.
1175
1176         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
1177         (TestWebKitAPI::Curl::TEST_F):
1178
1179 2019-03-05  Youenn Fablet  <youenn@apple.com>
1180
1181         Rename requestCacheStorageSpace to requestStorageSpace
1182         https://bugs.webkit.org/show_bug.cgi?id=195282
1183
1184         Reviewed by Chris Dumez.
1185
1186         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
1187         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
1188         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
1189
1190 2019-03-05  Brady Eidson  <beidson@apple.com>
1191
1192         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
1193         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
1194
1195         Reviewed by Tim Horton.
1196
1197         Loading a file: URL into a WKWebView and then loading another file: url from a completely
1198         different directory into that same WKWebView should work.
1199
1200         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1201         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
1202
1203 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
1204
1205         Add WeakHashSet
1206         https://bugs.webkit.org/show_bug.cgi?id=195152
1207
1208         Reviewed by Antti Koivisto.
1209
1210         Added tests for WeakHashSet.
1211
1212         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1213         (TestWebKitAPI::Base::Base): Moved.
1214         (TestWebKitAPI::Derived::foo): Moved.
1215         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
1216         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
1217         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
1218         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
1219
1220 2019-03-04  Chris Dumez  <cdumez@apple.com>
1221
1222         Do not share WebProcesses between private and regular sessions
1223         https://bugs.webkit.org/show_bug.cgi?id=195189
1224         <rdar://problem/48421064>
1225
1226         Reviewed by Alex Christensen.
1227
1228         Add API test coverage.
1229
1230         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1231         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1232
1233 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
1234
1235         [WPE] Enable web process sandbox
1236         https://bugs.webkit.org/show_bug.cgi?id=195169
1237
1238         Reviewed by Daniel Bates.
1239
1240         * wpe/install-dependencies:
1241         * wpe/jhbuild.modules:
1242
1243 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1244
1245         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
1246         https://bugs.webkit.org/show_bug.cgi?id=195206
1247
1248         Reviewed by Žan Doberšek.
1249
1250         Add a new test case.
1251
1252         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1253         (testJSCClass):
1254
1255 2019-03-04  Charlie Turner  <cturner@igalia.com>
1256
1257         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
1258         https://bugs.webkit.org/show_bug.cgi?id=194898
1259
1260         Reviewed by Žan Doberšek.
1261
1262         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
1263         a GCC extension that permits arithmetic on void* pointer. Inline
1264         the macro until this issue is fixed upstream.
1265
1266 2019-03-03  Tim Horton  <timothy_horton@apple.com>
1267
1268         Rid the world of WK_API_ENABLED
1269         https://bugs.webkit.org/show_bug.cgi?id=195263
1270
1271         Reviewed by Dan Bernstein.
1272
1273         List of changed files elided because it's useless.
1274
1275 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
1276
1277         Unreviewed follow-up to r242292.
1278
1279         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
1280
1281         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
1282         (TestWebKitAPI::testStrip): Renamed from strip.
1283         (TestWebKitAPI::TEST):
1284
1285 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1286
1287         Unreviewed, remove accidentally-committed URLHelpers.cpp test
1288
1289         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
1290         and bug #194272 for details.
1291
1292         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
1293
1294 2019-03-03  Tim Horton  <timothy_horton@apple.com>
1295
1296         Remove some more unused 32-bit code
1297         https://bugs.webkit.org/show_bug.cgi?id=195255
1298
1299         Reviewed by Darin Adler.
1300
1301         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1302         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
1303         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1304         (NPP_New):
1305         (NPP_HandleEvent):
1306         (handleEventCarbon): Deleted.
1307
1308 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
1309
1310         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
1311
1312         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
1313         (TestWebKitAPI::TEST):
1314
1315 2019-03-01  Darin Adler  <darin@apple.com>
1316
1317         Finish removing String::format
1318         https://bugs.webkit.org/show_bug.cgi?id=194893
1319
1320         Reviewed by Daniel Bates.
1321 '
1322         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
1323
1324 2019-03-01  Alex Christensen  <achristensen@webkit.org>
1325
1326         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
1327         https://bugs.webkit.org/show_bug.cgi?id=195229
1328         <rdar://problem/48520362>
1329
1330         Reviewed by Chris Dumez.
1331
1332         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1333         (TEST):
1334
1335 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
1336
1337         Add a system trace scope for event region building
1338         https://bugs.webkit.org/show_bug.cgi?id=195226
1339
1340         Reviewed by Jon Lee.
1341
1342         This trace scope measures the time spend converting element rects into Region objects,
1343         which can be large on some pages.
1344
1345         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
1346
1347         * Tracing/SystemTracePoints.plist:
1348
1349 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
1350
1351         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
1352         https://bugs.webkit.org/show_bug.cgi?id=194612
1353
1354         Reviewed by Alex Christensen.
1355
1356         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
1357         Just test the new string-processing function and don't touch the actual environment.
1358         (Test cases are all as before, but based on operator== instead of strcmp.)
1359
1360 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
1361
1362         [ews-app] Update primary keys for handling multiple Buildbot instances
1363         https://bugs.webkit.org/show_bug.cgi?id=195120
1364
1365         Reviewed by Stephanie Lewis.
1366
1367         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
1368         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
1369         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
1370
1371         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
1372         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
1373         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
1374         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
1375         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
1376         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
1377
1378 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
1379
1380         [WinCairo] Enable service worker
1381         https://bugs.webkit.org/show_bug.cgi?id=188318
1382
1383         Reviewed by Youenn Fablet.
1384
1385         * DumpRenderTree/DumpRenderTreePrefix.h:
1386         * TestWebKitAPI/PlatformWin.cmake:
1387         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
1388         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
1389         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1390
1391 2019-03-01  Justin Fan  <justin_fan@apple.com>
1392
1393         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
1394         https://bugs.webkit.org/show_bug.cgi?id=195191
1395
1396         Rubber-stamped by Dean Jackson.
1397
1398         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
1399
1400         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1401
1402 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
1403
1404         Unreviewed, fix lldb webkitpy tests
1405         https://bugs.webkit.org/show_bug.cgi?id=194375
1406
1407         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
1408
1409         * lldb/lldb_webkit.py:
1410         (WTFStringImplProvider.is_8bit):
1411
1412 2019-02-28  David Quesada  <david_quesada@apple.com>
1413
1414         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
1415         https://bugs.webkit.org/show_bug.cgi?id=195121
1416         rdar://problem/48450302
1417
1418         Reviewed by Alex Christensen.
1419
1420         Add API tests for -WKNavigationAction._shouldPerformDownload in various
1421         configurations where the 'download' attribute is absent, blank, or populated
1422         with a filename, and where the anchor element is same-origin or cross-origin
1423         (meaning the 'download' attribute shouldn't be honored).
1424
1425         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1426         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
1427         (-[NavigationActionTestDelegate init]):
1428         (-[NavigationActionTestDelegate navigationAction]):
1429         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
1430         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
1431         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1432         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
1433         (TEST):
1434
1435 2019-02-28  Antoine Quint  <graouts@apple.com>
1436
1437         Enable the Pointer Events runtime flag by default
1438         https://bugs.webkit.org/show_bug.cgi?id=195156
1439
1440         Reviewed by Dean Jackson.
1441
1442         * DumpRenderTree/mac/DumpRenderTree.mm:
1443         (enableExperimentalFeatures):
1444
1445 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
1446
1447         Several PasteImage API tests are flaky
1448         https://bugs.webkit.org/show_bug.cgi?id=195160
1449
1450         Reviewed by Tim Horton.
1451
1452         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
1453         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
1454         listening for a "load" event after image load is already complete.
1455
1456         To address this, make these tests first register a "load" event handler, then run script to insert an image
1457         element into the document, and finally wait until the load event is observed before checking image size.
1458
1459         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
1460
1461 2019-02-28  Chris Dumez  <cdumez@apple.com>
1462
1463         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
1464         https://bugs.webkit.org/show_bug.cgi?id=195107
1465
1466         Reviewed by Alex Christensen.
1467
1468         Give some time for the zoom level to get restored.
1469
1470         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1471
1472 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
1473
1474         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
1475         https://bugs.webkit.org/show_bug.cgi?id=194958
1476
1477         Reviewed by Geoffrey Garen.
1478
1479         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
1480         (TEST):
1481
1482 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
1483
1484         [ews-app] Update method to save build to handle builder_display_name
1485         https://bugs.webkit.org/show_bug.cgi?id=195047
1486
1487         Reviewed by Dewei Zhu.
1488
1489         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
1490         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
1491
1492 2019-02-28  Justin Fan  <justin_fan@apple.com>
1493
1494         [Web GPU] Enable Web GPU only on 64-bit
1495         https://bugs.webkit.org/show_bug.cgi?id=195139
1496
1497         Because Metal is only supported on 64 bit apps.
1498
1499         Unreviewed build fix.
1500
1501         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1502
1503 2019-02-27  Youenn Fablet  <youenn@apple.com>
1504
1505         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
1506         https://bugs.webkit.org/show_bug.cgi?id=194959
1507
1508         Reviewed by Chris Dumez.
1509
1510         Spin loop until getting the condition to remove flakiness.
1511
1512         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1513
1514 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
1515
1516         [ews-build] Buildbot should include builder_display_name in the build events
1517         https://bugs.webkit.org/show_bug.cgi?id=195045
1518
1519         Reviewed by Dewei Zhu.
1520
1521         * BuildSlaveSupport/ews-build/events.py:
1522         (Events.buildStarted): Included builder_display_name in event data. Also renamed
1523         buildername to builder_name to be consistent in naming style.
1524         (Events.buildFinished): Ditto.
1525
1526 2019-02-27  Chris Dumez  <cdumez@apple.com>
1527
1528         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
1529         https://bugs.webkit.org/show_bug.cgi?id=194480
1530
1531         Reviewed by Brady Eidson.
1532
1533         Update existing API test to make it more likely to reproduce the issue.
1534
1535         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1536
1537 2019-02-27  Brady Eidson  <beidson@apple.com>
1538
1539         Universal links from Google search results pages don't open the app.
1540         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
1541
1542         Reviewed by Geoffrey Garen.
1543
1544         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
1545         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
1546         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1547         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1548
1549 2019-02-27  Chris Dumez  <cdumez@apple.com>
1550
1551         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
1552         https://bugs.webkit.org/show_bug.cgi?id=195102
1553
1554         Reviewed by Geoffrey Garen.
1555
1556         If the number of processes is not yet what we expect, wait a bit and check again to give
1557         processes some time to exit.
1558
1559         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1560
1561 2019-02-27  Chris Dumez  <cdumez@apple.com>
1562
1563         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
1564         https://bugs.webkit.org/show_bug.cgi?id=194545
1565
1566         Reviewed by Brady Eidson.
1567
1568         Make sure the test navigates forward and then back only once. Previously, navigating
1569         back would trigger a navigation again in a timer.
1570
1571         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1572
1573 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
1574
1575         High Sierra Debug JSC test queue should use faster hardware
1576         https://bugs.webkit.org/show_bug.cgi?id=194603
1577
1578         Rubber-stamped by Alexey Proskuryakov.
1579
1580         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
1581
1582         * BuildSlaveSupport/build.webkit.org-config/config.json:
1583         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1584         (BubbleQueueServer):
1585         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1586         (WebKitBuildbot):
1587         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1588         * QueueStatusServer/config/queues.py:
1589         * Scripts/webkitpy/common/config/ews.json:
1590         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1591         (test_ews_name):
1592
1593 2019-02-27  John Wilander  <wilander@apple.com>
1594
1595         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
1596         https://bugs.webkit.org/show_bug.cgi?id=195071
1597         <rdar://problem/48417690>
1598
1599         Reviewed by Alex Christensen and Brent Fulgham.
1600
1601         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1602         (TestWebKitAPI::createURL):
1603             Convenience function.
1604         (TestWebKitAPI::TEST):
1605             WebCore::AdClickAttribution now takes a URL when creating Source and
1606             Destination.
1607         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
1608         (TestWebKitAPI::TEST):
1609             WebCore::AdClickAttribution now takes a URL when creating Source and
1610             Destination.
1611
1612 2019-02-27  Antoine Quint  <graouts@apple.com>
1613
1614         Support Pointer Events on macOS
1615         https://bugs.webkit.org/show_bug.cgi?id=195008
1616         <rdar://problem/47454419>
1617
1618         Reviewed by Dean Jackson.
1619
1620         * DumpRenderTree/mac/DumpRenderTree.mm:
1621         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
1622         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1623
1624 2019-02-26  Mark Lam  <mark.lam@apple.com>
1625
1626         Remove remaining poisoning code.
1627         https://bugs.webkit.org/show_bug.cgi?id=194138
1628
1629         Reviewed by Saam Barati.
1630
1631         * TestWebKitAPI/CMakeLists.txt:
1632         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1633         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
1634         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
1635         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
1636         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
1637         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
1638         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
1639
1640 2019-02-26  Alex Christensen  <achristensen@webkit.org>
1641
1642         Move ephemeral local storage from WebProcess to UIProcess
1643         https://bugs.webkit.org/show_bug.cgi?id=195074
1644         <rdar://problem/47937975>
1645
1646         Reviewed by Geoff Garen.
1647
1648         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1649
1650 2019-02-20  Jer Noble  <jer.noble@apple.com>
1651
1652         [Cocoa] Media elements will restart network buffering just before suspending
1653         https://bugs.webkit.org/show_bug.cgi?id=193691
1654
1655         Reviewed by Eric Carlson.
1656
1657         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1658         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
1659         (TEST):
1660
1661 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
1662
1663         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
1664         https://bugs.webkit.org/show_bug.cgi?id=191652
1665
1666         Reviewed by Alex Christensen.
1667
1668         Fix WinCairo MiniBrowser behavior of authentication dialog.
1669
1670         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1671         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
1672
1673 2019-02-26  Youenn Fablet  <youenn@apple.com>
1674
1675         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
1676         https://bugs.webkit.org/show_bug.cgi?id=195028
1677         <rdar://problem/48243733>
1678
1679         Reviewed by Eric Carlson.
1680
1681         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1682
1683 2019-02-26  Philippe Normand  <pnormand@igalia.com>
1684
1685         [WPE] Add API for webview background color configuration
1686         https://bugs.webkit.org/show_bug.cgi?id=192305
1687
1688         Reviewed by Michael Catanzaro.
1689
1690         * MiniBrowser/wpe/main.cpp:
1691         (main): Add a new option to configure the webview background
1692         color. Example: --bg-color=transparent.
1693         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
1694         (testWebViewBackgroundColor): Enable background color API tests for WPE.
1695         (beforeAll): Ditto.
1696
1697 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
1698
1699         scalableNativeWebpageParameters() is not preserved on new page navigation.
1700         https://bugs.webkit.org/show_bug.cgi?id=194892
1701         <rdar://problem/47538280>
1702
1703         Reviewed by Wenson Hsieh.
1704         
1705         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
1706
1707         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1708         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
1709         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1710         (WTR::UIScriptController::allowsViewportShrinkToFit):
1711         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1712         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1713         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
1714         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1715         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1716         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
1717
1718 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
1719
1720         [ews-app] Add model for handling multiple Buildbot instances
1721         https://bugs.webkit.org/show_bug.cgi?id=194863
1722
1723         Reviewed by Stephanie Lewis.
1724
1725         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
1726
1727 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
1728
1729         [ews-app] Remove BuilderMapping table
1730         https://bugs.webkit.org/show_bug.cgi?id=194961
1731
1732         Reviewed by Stephanie Lewis.
1733
1734         Store builder name directly in build table, instead of having a separate
1735         table for it.
1736
1737         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
1738         * BuildSlaveSupport/ews-app/ews/models/build.py:
1739         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
1740         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1741
1742 2019-02-25  John Wilander  <wilander@apple.com>
1743
1744         Introduce and adopt new class RegistrableDomain for eTLD+1
1745         https://bugs.webkit.org/show_bug.cgi?id=194791
1746         <rdar://problem/48179240>
1747
1748         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
1749
1750         This patch adds an API test and replaces two instances of
1751         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
1752
1753         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1754         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1755         (TestWebKitAPI::TEST):
1756             Changed two strings to make sure the registrable domains are still considered
1757             invalid and pass the test.
1758         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
1759         (TestWebKitAPI::TEST):
1760         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1761         (WTR::InjectedBundle::didReceiveMessageToPage):
1762
1763 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
1764
1765         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
1766         https://bugs.webkit.org/show_bug.cgi?id=195001
1767
1768         Reviewed by Carlos Garcia Campos.
1769
1770         API version 1.0 always includes the functionality previously guarded with
1771         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
1772         unconditionally.
1773
1774         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1775         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
1776         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
1777         (WebViewTest::showInWindow): Ditto.
1778         (WebViewTest::hideView): Ditto.
1779         * wpe/backends/HeadlessViewBackend.cpp:
1780         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
1781         * wpe/backends/ViewBackend.cpp:
1782         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
1783         * wpe/backends/WindowViewBackend.cpp:
1784         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
1785         WPE_BACKEND_CHECK_VERSION().
1786         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
1787
1788 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
1789
1790         [Flatpak] Add support for flatpak > 1.1.2
1791         https://bugs.webkit.org/show_bug.cgi?id=194088
1792
1793         Flatpak 1.2 is now out so we need to support that
1794         version now.
1795
1796         Reviewed by Michael Catanzaro.
1797
1798         * flatpak/flatpakutils.py:
1799         (check_flatpak):
1800         (FlatpakPackages.__init__):
1801         (FlatpakPackages.__detect_packages):
1802         (FlatpakPackages.__detect_packages.in):
1803         (FlatpakRepos.update):
1804
1805 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
1806
1807         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
1808         https://bugs.webkit.org/show_bug.cgi?id=194998
1809
1810         Reviewed by Carlos Garcia Campos.
1811
1812         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
1813         to a Git checkout and using the latest commit containing various fixes
1814         and improvements.
1815
1816 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1817
1818         [WPE][GTK] Remove user agent quirk for washingtonpost.com
1819         https://bugs.webkit.org/show_bug.cgi?id=194981
1820
1821         Reviewed by Žan Doberšek.
1822
1823         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1824         (TestWebKitAPI::TEST):
1825
1826 2019-02-23  Keith Miller  <keith_miller@apple.com>
1827
1828         Add new mac target numbers
1829         https://bugs.webkit.org/show_bug.cgi?id=194955
1830
1831         Reviewed by Tim Horton.
1832
1833         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1834         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1835         * MiniBrowser/Configurations/Base.xcconfig:
1836         * TestWebKitAPI/Configurations/Base.xcconfig:
1837         * WebKitTestRunner/Configurations/Base.xcconfig:
1838
1839 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
1840
1841         [WinCairo] Enable wk1/wk2 suffix for platform search path.
1842         https://bugs.webkit.org/show_bug.cgi?id=194846
1843
1844         Reviewed by Don Olmstead.
1845
1846         Added _search_paths() and _port_specific_expectations_files() for
1847         WinCairoPort.
1848
1849         * Scripts/webkitpy/port/win.py:
1850         (WinCairoPort.default_baseline_search_path):
1851         (WinCairoPort):
1852         (WinCairoPort._port_specific_expectations_files):
1853         (WinCairoPort._search_paths):
1854
1855 2019-02-22  Tim Horton  <timothy_horton@apple.com>
1856
1857         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
1858         https://bugs.webkit.org/show_bug.cgi?id=194963
1859
1860         Reviewed by Dean Jackson.
1861
1862         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1863         Do a `contains` check instead of `equals`, because in debug builds we
1864         put the GraphicsLayer pointer in a prefix.
1865
1866 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1867
1868         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
1869         https://bugs.webkit.org/show_bug.cgi?id=194873
1870         <rdar://problem/46701974>
1871
1872         Reviewed by Tim Horton.
1873
1874         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
1875
1876         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1877         (WTR::UIScriptController::menuRect const):
1878         (WTR::UIScriptController::isShowingMenu const):
1879         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1880         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1881         (WTR::UIScriptController::menuRect const):
1882
1883         Add a function to query the bounds of the callout menu in content coordinates.
1884
1885         (WTR::UIScriptController::isShowingMenu const):
1886
1887         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
1888
1889         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1890         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1891         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1892         (WTR::UIScriptController::rectForMenuAction const):
1893         (WTR::UIScriptController::menuRect const):
1894         (WTR::UIScriptController::isShowingMenu const):
1895         (WTR::findViewInHierarchyOfType): Deleted.
1896
1897 2019-02-22  Chris Dumez  <cdumez@apple.com>
1898
1899         Regression(PSON) Unable to preview password-protected documents on iCloud.com
1900         https://bugs.webkit.org/show_bug.cgi?id=194954
1901         <rdar://problem/48127957>
1902
1903         Reviewed by Alex Christensen.
1904
1905         Add API test coverage.
1906
1907         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1908         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
1909         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1910         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1911
1912 2019-02-22  Chris Dumez  <cdumez@apple.com>
1913
1914         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
1915         https://bugs.webkit.org/show_bug.cgi?id=194924
1916         <rdar://problem/48216125>
1917
1918         Reviewed by Geoffrey Garen.
1919
1920         Add API test coverage.
1921
1922         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1923
1924 2019-02-22  Chris Dumez  <cdumez@apple.com>
1925
1926         Unreviewed, disable API test added in r241928 on iOS.
1927
1928         The cache is not enabled on devices with less than 3GB of RAM.
1929
1930         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1931
1932 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
1933
1934         Hardcode Visual Viewports on everywhere except iOS WK1
1935         https://bugs.webkit.org/show_bug.cgi?id=194928
1936
1937         Reviewed by Zalan Bujtas.
1938
1939         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
1940         change the default value of the Setting to 'true', and hardcode WebView on iOS to
1941         set it to false. The setting has shipped for several years and there's no need to turn
1942         it off now.
1943
1944         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
1945         Visual Viewports are not enabled.
1946         
1947         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
1948         that only runs in WK2
1949
1950         * MiniBrowser/mac/SettingsController.h:
1951         * MiniBrowser/mac/SettingsController.m:
1952         (-[SettingsController init]):
1953         (-[SettingsController _populateMenu]):
1954         (-[SettingsController validateMenuItem:]):
1955         (-[SettingsController visualViewportEnabled]): Deleted.
1956         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
1957         * MiniBrowser/mac/WK1BrowserWindowController.m:
1958         (-[WK1BrowserWindowController didChangeSettings]):
1959         * MiniBrowser/mac/WK2BrowserWindowController.m:
1960         (-[WK2BrowserWindowController didChangeSettings]):
1961
1962 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
1963
1964         Discard cached processes when clearing website data store
1965         https://bugs.webkit.org/show_bug.cgi?id=194894
1966
1967         Reviewed by Chris Dumez.
1968
1969         Added a test case.
1970
1971         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1972         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
1973
1974 2019-02-21  Alex Christensen  <achristensen@webkit.org>
1975
1976         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
1977         https://bugs.webkit.org/show_bug.cgi?id=194914
1978         <rdar://problem/47586889>
1979
1980         Reviewed by Geoffrey Garen.
1981
1982         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1983         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
1984         (TEST):
1985         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
1986
1987 2019-02-21  David Kilzer  <ddkilzer@apple.com>
1988
1989         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
1990         <https://webkit.org/b/194761>
1991
1992         Reviewed by Myles Maxfield.
1993
1994         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1995         (WTR::activateSystemCoreWebFonts): Log `error` to console if
1996         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
1997         to use ARC-compliant cast.
1998         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
1999         ARC-compliant cast.
2000         (WTR::installFakeHelvetica): Log `error` to console if
2001         CTFontManagerRegisterFontsForURL() fails, but only on supported
2002         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
2003         Call CFRelease() on `error` to fix the leak.  Update to use
2004         ARC-compliant cast.
2005         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
2006         cast.
2007
2008 2019-02-21  Chris Dumez  <cdumez@apple.com>
2009
2010         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
2011         https://bugs.webkit.org/show_bug.cgi?id=194481
2012
2013         Reviewed by Alex Christensen.
2014
2015         Give the processes a chance to shutdown and wait until we reached the expected number
2016         of processes.
2017
2018         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2019
2020 2019-02-21  Tim Horton  <timothy_horton@apple.com>
2021
2022         Fix the macOS build
2023
2024         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2025
2026 2019-02-21  Tim Horton  <timothy_horton@apple.com>
2027
2028         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
2029
2030         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2031         I am a backwards.
2032
2033 2019-02-21  Tim Horton  <timothy_horton@apple.com>
2034
2035         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
2036
2037         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2038         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
2039         We could force on UI-side compositing, but I feel like the test might be more
2040         valuable exercising the normal path on each platform (though the original
2041         bug was also UI-side specific). Though we can't validate that the overlay
2042         layer was installed successfully, there are layout tests that do that.
2043
2044 2019-02-21  Tim Horton  <timothy_horton@apple.com>
2045
2046         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
2047         https://bugs.webkit.org/show_bug.cgi?id=194845
2048         <rdar://problem/47944579>
2049
2050         Reviewed by Antti Koivisto.
2051
2052         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2053         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2054
2055 2019-02-21  Zalan Bujtas  <zalan@apple.com>
2056
2057         [LFC][Floats] Add support for placing formatting roots in-between floats.
2058         https://bugs.webkit.org/show_bug.cgi?id=194902
2059
2060         Reviewed by Antti Koivisto.
2061
2062         * LayoutReloaded/misc/LFC-passing-tests.txt:
2063
2064 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
2065
2066         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
2067         https://bugs.webkit.org/show_bug.cgi?id=194901
2068
2069         Unreviewed build fix.
2070
2071         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
2072         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
2073         WPEBackend-fdo-0.1 as library name.
2074
2075 2019-02-21  Rob Buis  <rbuis@igalia.com>
2076
2077         Update MIME type parser
2078         https://bugs.webkit.org/show_bug.cgi?id=180526
2079
2080         Reviewed by Darin Adler.
2081
2082         Add tests involving leading and trailing whitespace, non-token
2083         characters and quoted strings.
2084
2085         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2086         (TestWebKitAPI::TEST):
2087
2088 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
2089
2090         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
2091         https://bugs.webkit.org/show_bug.cgi?id=194884
2092
2093         Reviewed by Michael Catanzaro.
2094
2095         * PlatformWin.cmake:
2096
2097 2019-02-20  Chris Dumez  <cdumez@apple.com>
2098
2099         Add API test for <rdar://problem/47471222>
2100         https://bugs.webkit.org/show_bug.cgi?id=194847
2101
2102         Reviewed by Alex Christensen.
2103
2104         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2105
2106 2019-02-20  Chris Dumez  <cdumez@apple.com>
2107
2108         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
2109         https://bugs.webkit.org/show_bug.cgi?id=194872
2110         <rdar://problem/47924500>
2111
2112         Reviewed by Alex Christensen.
2113
2114         Add API test coverage.
2115
2116         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2117
2118 2019-02-20  Jer Noble  <jer.noble@apple.com>
2119
2120         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
2121         https://bugs.webkit.org/show_bug.cgi?id=191332
2122
2123         Reviewed by Dean Jackson.
2124
2125         * Scripts/git-is-in-range: Added.
2126
2127 2019-02-20  Andy Estes  <aestes@apple.com>
2128
2129         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
2130         https://bugs.webkit.org/show_bug.cgi?id=194869
2131
2132         Rubber-stamped by Jer Noble.
2133
2134         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2135         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
2136         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2137         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
2138         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2139         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2140
2141 2019-02-20  Chris Dumez  <cdumez@apple.com>
2142
2143         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
2144         https://bugs.webkit.org/show_bug.cgi?id=194857
2145         <rdar://problem/47759323>
2146
2147         Reviewed by Alex Christensen.
2148
2149         Add API test coverage.
2150
2151         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2152
2153 2019-02-20  Chris Dumez  <cdumez@apple.com>
2154
2155         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
2156         https://bugs.webkit.org/show_bug.cgi?id=194829
2157         <rdar://problem/47889906>
2158
2159         Reviewed by Alexey Proskuryakov.
2160
2161         Every time the TestOptions were changing we were creating both a new Web view and
2162         a new WKContext, which would start a new Network process. In most cases, we only
2163         need to contruct a new Web view and we do can keep reusing the same WKContext.
2164         This patch implements this optimization and thus avoids spinning a lot of new
2165         Network processes while running the layout tests.
2166
2167         * WebKitTestRunner/TestController.cpp:
2168         (WTR::TestController::generateContextConfiguration const):
2169         (WTR::TestController::generatePageConfiguration):
2170         (WTR::TestController::createWebViewWithOptions):
2171         (WTR::TestController::resetPreferencesToConsistentValues):
2172         (WTR::updateTestOptionsFromTestHeader):
2173         * WebKitTestRunner/TestController.h:
2174         * WebKitTestRunner/TestOptions.h:
2175         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
2176         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
2177         (WTR::TestOptions::hasSameInitializationOptions const):
2178         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
2179         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2180         (WTR::TestController::platformAddTestOptions const):
2181
2182 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
2183
2184         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
2185         https://bugs.webkit.org/show_bug.cgi?id=167941
2186
2187         Reviewed by Carlos Garcia Campos.
2188
2189         * MiniBrowser/gtk/main.c:
2190         (filterSavedCallback): Added.
2191         (main): Support loading a JSON rule set file for content filtering.
2192         * MiniBrowser/wpe/main.cpp:
2193         (filterSavedCallback): Added.
2194         (main): Support loading a JSON rule set file for content filtering.
2195         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
2196         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
2197         (WTF::derefGPtr): Ditto.
2198         (testEmptyStore):
2199         (testSaveInvalidFilter):
2200         (testSaveLoadFilter):
2201         (testSavedFilterIdentifierMatch):
2202         (testRemoveFilter):
2203         (testSaveMultipleFilters):
2204         (testSaveFilterFromFile):
2205         (testFilterPersistence):
2206         (beforeAll):
2207         (afterAll):
2208         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
2209         (removeOldInjectedContentAndResetLists): Also reset content filters.
2210         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
2211         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
2212         the element affected by the style sheet.
2213         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
2214         and returns it to be used by tests.
2215         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
2216         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
2217         (serverCallback): Add support for serving a CSS style sheet for testing.
2218         (beforeAll): Add call to testUserContentManagerContentFilter().
2219         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
2220
2221 2019-02-19  Keith Rollin  <krollin@apple.com>
2222
2223         Add timing information to build output
2224         https://bugs.webkit.org/show_bug.cgi?id=194839
2225         <rdar://problem/48219609>
2226
2227         Reviewed by Alexey Proskuryakov.
2228
2229         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
2230         emit each project's build time to its output. E.g.,
2231
2232             ** BUILD SUCCEEDED ** [0.132 sec]
2233
2234         * Scripts/webkitdirs.pm:
2235         (XcodeOptions):
2236
2237 2019-02-19  Truitt Savell  <tsavell@apple.com>
2238
2239         Unreviewed, rolling out r241784.
2240
2241         Broke all OpenSource builds.
2242
2243         Reverted changeset:
2244
2245         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
2246         instances view"
2247         https://bugs.webkit.org/show_bug.cgi?id=172848
2248         https://trac.webkit.org/changeset/241784
2249
2250 2019-02-19  Zalan Bujtas  <zalan@apple.com>
2251
2252         [LFC][Floats] Remove redundant intersecting logic
2253         https://bugs.webkit.org/show_bug.cgi?id=194804
2254
2255         Reviewed by Antti Koivisto.
2256
2257         * LayoutReloaded/misc/LFC-passing-tests.txt:
2258
2259 2019-02-19  Dean Jackson  <dino@apple.com>
2260
2261         Clean-up output from generate-xcfilelists so it can be filtered
2262         https://bugs.webkit.org/show_bug.cgi?id=194795
2263
2264         Reviewed by Joseph Pecoraro (and Keith Rollin).
2265
2266         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
2267         make a slight tweak to filter-build-webkit so such lines are marked
2268         as plain.
2269
2270         * Scripts/filter-build-webkit:
2271         * Scripts/generate-xcfilelists:
2272
2273 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
2274
2275         pytest is not correctly auto-installed
2276         https://bugs.webkit.org/show_bug.cgi?id=194707
2277
2278         Reviewed by Carlos Garcia Campos.
2279
2280         * Scripts/webkitpy/thirdparty/__init__.py:
2281         (AutoinstallImportHook._install_pytest):
2282
2283 2019-02-18  Chris Dumez  <cdumez@apple.com>
2284
2285         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
2286         https://bugs.webkit.org/show_bug.cgi?id=194797
2287         <rdar://problem/48055151>
2288
2289         Reviewed by Geoffrey Garen.
2290
2291         Add API test coverage.
2292
2293         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2294
2295 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2296
2297         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
2298         https://bugs.webkit.org/show_bug.cgi?id=194670
2299         <rdar://problem/39066529>
2300
2301         Reviewed by Tim Horton.
2302
2303         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
2304         pasted in an editable area as attachment elements.
2305
2306         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
2307         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2308         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
2309         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2310         (TestWebKitAPI::TEST):
2311         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2312         (WTR::InjectedBundlePage::InjectedBundlePage):
2313
2314 2019-02-18  Alex Christensen  <achristensen@webkit.org>
2315
2316         Fix API test after r241728
2317        ​https://bugs.webkit.org/show_bug.cgi?id=194723
2318
2319         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2320         (TEST):
2321         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
2322
2323 2019-02-18  Daniel Bates  <dabates@apple.com>
2324
2325         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
2326         https://bugs.webkit.org/show_bug.cgi?id=192824
2327         <rdar://problem/47100332>
2328
2329         Reviewed by Wenson Hsieh.
2330
2331         Fix a bug where the wrong usage code was used for F13 thru F24.
2332
2333         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2334         (keyCodeForDOMFunctionKey):
2335
2336 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
2337
2338         Bytecode cache should a have a boot-specific validation
2339         https://bugs.webkit.org/show_bug.cgi?id=194769
2340         <rdar://problem/48149509>
2341
2342         Reviewed by Keith Miller.
2343
2344         Add test for WTF::bootSessionUUIDString()
2345
2346         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2347         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
2348         (TEST):
2349
2350 2019-02-18  Alex Christensen  <achristensen@webkit.org>
2351
2352         Disable safe browsing in WKWebView and remove its WKPreferences API
2353         https://bugs.webkit.org/show_bug.cgi?id=194723
2354         <rdar://problem/48122993>
2355
2356         Reviewed by Geoffrey Garen.
2357
2358         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2359         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2360         (TEST):
2361         (safeBrowsingView):
2362         Make tests use SPI instead of API.
2363
2364 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
2365
2366         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
2367         https://bugs.webkit.org/show_bug.cgi?id=194586
2368
2369         Reviewed by Ross Kirsling.
2370
2371         * DumpRenderTree/win/DumpRenderTree.cpp:
2372         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
2373         * Scripts/webkitpy/port/driver.py:
2374         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
2375
2376 2019-02-17  David Kilzer  <ddkilzer@apple.com>
2377
2378         Unreviewed, rolling out r241620.
2379
2380         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
2381         (Requested by ddkilzer on #webkit.)
2382
2383         Reverted changeset:
2384
2385         "[WTF] Add environment variable helpers"
2386         https://bugs.webkit.org/show_bug.cgi?id=192405
2387         https://trac.webkit.org/changeset/241620
2388
2389 2019-02-16  Zalan Bujtas  <zalan@apple.com>
2390
2391         [LFC] RenderImage's default intrinsic size is 0.
2392         https://bugs.webkit.org/show_bug.cgi?id=194745
2393
2394         Reviewed by Antti Koivisto.
2395
2396         * LayoutReloaded/misc/LFC-passing-tests.txt:
2397
2398 2019-02-16  Zalan Bujtas  <zalan@apple.com>
2399
2400         [LFC][BFC] Add support for block replaced intrinsic width.
2401         https://bugs.webkit.org/show_bug.cgi?id=194705
2402
2403         Reviewed by Simon Fraser.
2404
2405         * LayoutReloaded/misc/LFC-passing-tests.txt:
2406
2407 2019-02-16  Zalan Bujtas  <zalan@apple.com>
2408
2409         [LFC] Apply min/max width constraints to preferred width computation
2410         https://bugs.webkit.org/show_bug.cgi?id=194739
2411
2412         Reviewed by Simon Fraser.
2413
2414         * LayoutReloaded/misc/LFC-passing-tests.txt:
2415
2416 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
2417
2418         [WTF] Add environment variable helpers
2419         https://bugs.webkit.org/show_bug.cgi?id=192405
2420
2421         Reviewed by Michael Catanzaro.
2422
2423         * DumpRenderTree/mac/DumpRenderTree.mm:
2424         (libraryPathForDumpRenderTree):
2425         * DumpRenderTree/win/DumpRenderTree.cpp:
2426         (libraryPathForDumpRenderTree):
2427         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
2428         (setUpIOSLayoutTestCommunication):
2429         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2430         (beforeAll):
2431         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
2432         (main):
2433         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
2434         (WebKitTestBus::run):
2435         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2436         (WTR::getOutputDir):
2437         (WTR::initializeFontConfigSetting):
2438         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
2439         (WTR::InjectedBundle::platformInitialize):
2440         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
2441         (WTR::topLevelPath):
2442         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
2443         (WTR::topLevelPath):
2444         (WTR::getOutputDir):
2445         (WTR::activateFonts):
2446         * WebKitTestRunner/TestController.cpp:
2447         (WTR::TestController::libraryPathForTesting):
2448         (WTR::TestController::generateContextConfiguration const):
2449         (WTR::TestController::generatePageConfiguration):
2450         (WTR::TestController::decideDestinationWithSuggestedFilename):
2451         (WTR::TestController::platformAdjustContext):
2452         * WebKitTestRunner/TestController.h:
2453         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2454         (WTR::TestController::cocoaPlatformInitialize):
2455         (WTR::TestController::platformAdjustContext):
2456         * WebKitTestRunner/gtk/main.cpp:
2457         (main):
2458         * WebKitTestRunner/mac/TestControllerMac.mm:
2459         (WTR::TestController::configureContentExtensionForTest):
2460         * WebKitTestRunner/wpe/main.cpp:
2461         (main):
2462         Utilize WTF::Environment where possible.
2463
2464 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2465
2466         [iOS] WKWebView callout bar is missing Change Writing Direction item
2467         https://bugs.webkit.org/show_bug.cgi?id=190015
2468         <rdar://problem/44810366>
2469
2470         Reviewed by Tim Horton.
2471
2472         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
2473         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
2474
2475         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
2476         (TestWebKitAPI::TEST):
2477
2478 2019-02-15  Chris Dumez  <cdumez@apple.com>
2479
2480         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
2481         https://bugs.webkit.org/show_bug.cgi?id=194717
2482         <rdar://problem/47884404>
2483
2484         Reviewed by Brady Eidson.
2485
2486         Add API test coverage.
2487
2488         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2489
2490 2019-02-15  Youenn Fablet  <youenn@apple.com>
2491
2492         Make navigator.mediaDevices SecureContext
2493         https://bugs.webkit.org/show_bug.cgi?id=194666
2494
2495         Reviewed by Eric Carlson.
2496
2497         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
2498         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
2499         (TEST_F):
2500
2501 2019-02-15  Brian Burg  <bburg@apple.com>
2502
2503         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
2504         https://bugs.webkit.org/show_bug.cgi?id=194411
2505         <rdar://problem/47787614>
2506
2507         Reviewed by Joseph Pecoraro.
2508
2509         Remove unnecessary soft linking macro usage.
2510
2511         * DumpRenderTree/mac/TestRunnerMac.mm:
2512         (TestRunner::inspectorTestStubURL):
2513         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
2514         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2515         (WTR::TestRunner::inspectorTestStubURL):
2516
2517 2019-02-15  Commit Queue  <commit-queue@webkit.org>
2518
2519         Unreviewed, rolling out r241559 and r241566.
2520         https://bugs.webkit.org/show_bug.cgi?id=194710
2521
2522         Causes layout test crashes under GuardMalloc (Requested by
2523         ryanhaddad on #webkit).
2524
2525         Reverted changesets:
2526
2527         "[WTF] Add environment variable helpers"
2528         https://bugs.webkit.org/show_bug.cgi?id=192405
2529         https://trac.webkit.org/changeset/241559
2530
2531         "Unreviewed build fix for WinCairo Debug after r241559."
2532         https://trac.webkit.org/changeset/241566
2533
2534 2019-02-15  Zalan Bujtas  <zalan@apple.com>
2535
2536         [LFC] Out-of-flow box is never a float box
2537         https://bugs.webkit.org/show_bug.cgi?id=194704
2538
2539         Reviewed by Antti Koivisto.
2540
2541         * LayoutReloaded/misc/LFC-passing-tests.txt:
2542
2543 2019-02-10  Darin Adler  <darin@apple.com>
2544
2545         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
2546         https://bugs.webkit.org/show_bug.cgi?id=194487
2547
2548         Reviewed by Daniel Bates.
2549
2550         * DumpRenderTree/win/DumpRenderTree.cpp:
2551         (applicationId): Use makeString instead of String::format.
2552         (main): Ditto.
2553         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2554         (TestWebKitAPI::Util::createURLForResource): Ditto.
2555         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2556         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
2557
2558         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2559         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
2560         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
2561         (WTR::createStringWithAttributes): Use appendLiteral.
2562         (WTR::AccessibilityUIElement::helpText const): Ditto.
2563         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
2564         directly instead of using String::format.
2565         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
2566         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
2567
2568 2019-02-15  Truitt Savell  <tsavell@apple.com>
2569
2570         Unreviewed, rolling out r241564.
2571
2572         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
2573
2574         Reverted changeset:
2575
2576         "[Mac] WebInspectorUI.framework does not need to be soft-
2577         linked anymore"
2578         https://bugs.webkit.org/show_bug.cgi?id=194411
2579         https://trac.webkit.org/changeset/241564
2580
2581 2019-02-15  Saam barati  <sbarati@apple.com>
2582
2583         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
2584         https://bugs.webkit.org/show_bug.cgi?id=194036
2585
2586         Reviewed by Yusuke Suzuki.
2587
2588         * Scripts/run-jsc-stress-tests:
2589
2590 2019-02-14  Tim Horton  <timothy_horton@apple.com>
2591
2592         Fix the build.
2593
2594         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2595         (WTR::UIScriptController::drawSquareInEditableImage):
2596         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2597         (TestWebKitAPI::drawSquareInEditableImage):
2598
2599 2019-02-14  Tim Horton  <timothy_horton@apple.com>
2600
2601         Fix the build.
2602
2603         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2604         (WTR::UIScriptController::drawSquareInEditableImage):
2605         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2606         (TestWebKitAPI::drawSquareInEditableImage):
2607
2608 2019-02-14  Brian Burg  <bburg@apple.com>
2609
2610         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
2611         https://bugs.webkit.org/show_bug.cgi?id=194411
2612         <rdar://problem/47787614>
2613
2614         Reviewed by Joseph Pecoraro.
2615
2616         Remove unnecessary soft linking macro usage.
2617
2618         * DumpRenderTree/mac/TestRunnerMac.mm:
2619         (TestRunner::inspectorTestStubURL):
2620         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
2621         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2622         (WTR::TestRunner::inspectorTestStubURL):
2623
2624 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
2625
2626         [ews-app] status bubble should fetch builder name info from BuilderMapping table
2627         https://bugs.webkit.org/show_bug.cgi?id=194599
2628
2629         Reviewed by Lucas Forschler.
2630
2631         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2632         (StatusBubble._build_bubble):
2633
2634 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
2635
2636         [ews-app] Set Foreign Key in Django build model
2637         https://bugs.webkit.org/show_bug.cgi?id=194667
2638
2639         Reviewed by Lucas Forschler.
2640
2641         * BuildSlaveSupport/ews-app/ews/models/build.py:
2642         (Build):
2643
2644 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
2645
2646         [WTF] Add environment variable helpers
2647         https://bugs.webkit.org/show_bug.cgi?id=192405
2648
2649         Reviewed by Michael Catanzaro.
2650
2651         * DumpRenderTree/mac/DumpRenderTree.mm:
2652         (libraryPathForDumpRenderTree):
2653         * DumpRenderTree/win/DumpRenderTree.cpp:
2654         (libraryPathForDumpRenderTree):
2655         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
2656         (setUpIOSLayoutTestCommunication):
2657         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
2658         (TestWebKitAPI::strip):
2659         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
2660         (beforeAll):
2661         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
2662         (main):
2663         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
2664         (WebKitTestBus::run):
2665         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2666         (WTR::getOutputDir):
2667         (WTR::initializeFontConfigSetting):
2668         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
2669         (WTR::InjectedBundle::platformInitialize):
2670         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
2671         (WTR::topLevelPath):
2672         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
2673         (WTR::topLevelPath):
2674         (WTR::getOutputDir):
2675         (WTR::activateFonts):
2676         * WebKitTestRunner/TestController.cpp:
2677         (WTR::TestController::libraryPathForTesting):
2678         (WTR::TestController::generateContextConfiguration const):
2679         (WTR::TestController::generatePageConfiguration):
2680         (WTR::TestController::decideDestinationWithSuggestedFilename):
2681         (WTR::TestController::platformAdjustContext):
2682         * WebKitTestRunner/TestController.h:
2683         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2684         (WTR::TestController::cocoaPlatformInitialize):
2685         (WTR::TestController::platformAdjustContext):
2686         * WebKitTestRunner/gtk/main.cpp:
2687         (main):
2688         * WebKitTestRunner/mac/TestControllerMac.mm:
2689         (WTR::TestController::configureContentExtensionForTest):
2690         * WebKitTestRunner/wpe/main.cpp:
2691         (main):
2692         Utilize WTF::Environment where possible.
2693
2694 2019-02-14  Chris Dumez  <cdumez@apple.com>
2695
2696         [PSON] Introduce a WebContent Process cache
2697         https://bugs.webkit.org/show_bug.cgi?id=194594
2698         <rdar://problem/46793397>
2699
2700         Reviewed by Geoff Garen.
2701
2702         Update API tests to turn on the WebContent Process cache.
2703
2704         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2705
2706 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
2707
2708         Unreviewed, build fix after r241480
2709
2710         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2711         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
2712         (-[DragAndDropSimulator initWithWebView:]):
2713
2714 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
2715
2716         AX: ARIA Reflection was disabled in error
2717         https://bugs.webkit.org/show_bug.cgi?id=194647
2718         <rdar://problem/48068336>
2719
2720         Reviewed by Ryosuke Niwa.
2721
2722         Remove test override now that this feature should be enabled by default.
2723
2724         * WebKitTestRunner/TestController.cpp:
2725         (WTR::TestController::resetPreferencesToConsistentValues):
2726
2727 2019-02-14  Commit Queue  <commit-queue@webkit.org>
2728
2729         Unreviewed, rolling out r241486.
2730         https://bugs.webkit.org/show_bug.cgi?id=194655
2731
2732         causing API failures in builds (Requested by ShawnRoberts on
2733         #webkit).
2734
2735         Reverted changeset:
2736
2737         "[Cocoa] Media elements will restart network buffering just
2738         before suspending"
2739         https://bugs.webkit.org/show_bug.cgi?id=193691
2740         https://trac.webkit.org/changeset/241486
2741
2742 2019-02-14  Zalan Bujtas  <zalan@apple.com>
2743
2744         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
2745         https://bugs.webkit.org/show_bug.cgi?id=194622
2746
2747         Reviewed by Antti Koivisto.
2748
2749         * LayoutReloaded/misc/LFC-passing-tests.txt:
2750
2751 2019-02-14  Zalan Bujtas  <zalan@apple.com>
2752
2753         [LFC] Shrink-to-fit-width should be constrained by min/max width
2754         https://bugs.webkit.org/show_bug.cgi?id=194653
2755
2756         Reviewed by Antti Koivisto.
2757
2758         * LayoutReloaded/misc/LFC-passing-tests.txt:
2759
2760 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
2761
2762         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
2763         https://bugs.webkit.org/show_bug.cgi?id=194641
2764
2765         Reviewed by Geoffrey Garen.
2766
2767         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
2768         so that the test would fail without this fix.
2769
2770         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
2771         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
2772
2773 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2774
2775         [ews-app] Change log level for a log statement
2776
2777         Unreviewed minor fix.
2778
2779         * BuildSlaveSupport/ews-app/ews/models/patch.py:
2780         (Patch.save_patch):
2781
2782 2019-02-13  Jer Noble  <jer.noble@apple.com>
2783
2784         [Cocoa] Media elements will restart network buffering just before suspending
2785         https://bugs.webkit.org/show_bug.cgi?id=193691
2786
2787         Reviewed by Eric Carlson.
2788
2789         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2790         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
2791         (TEST):
2792
2793 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2794
2795         [ews-app] Fetch builder id to name mapping
2796         https://bugs.webkit.org/show_bug.cgi?id=194355
2797
2798         Reviewed by Lucas Forschler.
2799
2800         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2801         (Buildbot.get_builder_id_to_name_mapping):
2802         (Buildbot._get_display_name_from_builder_name):
2803
2804 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
2805
2806         Further restricting webarchive loads
2807         https://bugs.webkit.org/show_bug.cgi?id=194567
2808         <rdar://problem/47610130>
2809
2810         Reviewed by Youenn Fablet.
2811
2812         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
2813         navigations on drop.
2814
2815         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2816         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
2817         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
2818         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
2819         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2820         (TestWebKitAPI::TEST):
2821         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
2822         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
2823         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
2824         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2825         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
2826         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
2827         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
2828
2829 2019-02-13  John Wilander  <wilander@apple.com>
2830
2831         Store Ad Click Attribution requests in the network process
2832         https://bugs.webkit.org/show_bug.cgi?id=194510
2833         <rdar://problem/47650118>
2834
2835         Reviewed by Alex Christensen and Daniel Bates.
2836
2837         This patch adds two TestRunner functions:
2838         - dumpAdClickAttribution()
2839         - clearAdClickAttribution()
2840
2841         They call into the network process to dump and clear Ad Click
2842         Attribution state, respectively.
2843
2844         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2845         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2846         (WTR::TestRunner::dumpAdClickAttribution):
2847         (WTR::TestRunner::clearAdClickAttribution):
2848         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2849         * WebKitTestRunner/TestController.cpp:
2850         (WTR::TestController::resetStateToConsistentValues):
2851         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
2852         (WTR::adClickAttributionStringResultCallback):
2853         (WTR::TestController::dumpAdClickAttribution):
2854         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
2855         (WTR::adClickAttributionVoidCallback):
2856         (WTR::TestController::clearAdClickAttribution):
2857         * WebKitTestRunner/TestController.h:
2858         * WebKitTestRunner/TestInvocation.cpp:
2859         (WTR::TestInvocation::dumpResults):
2860         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2861         (WTR::TestInvocation::dumpAdClickAttribution):
2862         * WebKitTestRunner/TestInvocation.h:
2863
2864 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2865
2866         [ews-app] Generate status-bubble
2867         https://bugs.webkit.org/show_bug.cgi?id=194572
2868
2869         Reviewed by Lucas Forschler.
2870
2871         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2872         (StatusBubble._build_bubble):
2873         (StatusBubble._should_show_bubble_for):
2874         (StatusBubble._build_bubbles_for_patch):
2875
2876 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
2877
2878         [ews-app] Add status bubble html template
2879         https://bugs.webkit.org/show_bug.cgi?id=194571
2880
2881         Reviewed by Lucas Forschler.
2882
2883         * BuildSlaveSupport/ews-app/ews/templates: Added.
2884         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
2885
2886 2019-02-12  Chris Dumez  <cdumez@apple.com>
2887
2888         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
2889         https://bugs.webkit.org/show_bug.cgi?id=194568
2890         <rdar://problem/47944490>
2891
2892         Reviewed by Ryosuke Niwa.
2893
2894         Add API test coverage.
2895
2896         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2897         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
2898
2899 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
2900
2901         webkitpy: Remove bug_dummy from parsed test expectations
2902         https://bugs.webkit.org/show_bug.cgi?id=194562
2903         <rdar://problem/47853999>
2904
2905         Reviewed by Lucas Forschler.
2906
2907         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2908         (TestExpectationParser):
2909         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
2910         skipped tests.
2911         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2912
2913 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
2914
2915         [ews-app] Add method to fetch patch
2916         https://bugs.webkit.org/show_bug.cgi?id=194518
2917
2918         Reviewed by Lucas Forschler.
2919
2920         * BuildSlaveSupport/ews-app/ews/models/patch.py:
2921         (Patch.get_patch):
2922
2923 2019-02-12  Zalan Bujtas  <zalan@apple.com>
2924
2925         [LFC] Expand tests coverage (60 new tests -> 860)
2926
2927         Unreviewed test gardening (run-singly, --child-processes=1).
2928
2929         * LayoutReloaded/misc/LFC-passing-tests.txt:
2930
2931 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2932
2933         Allow pages to trigger programmatic paste from script on iOS
2934         https://bugs.webkit.org/show_bug.cgi?id=194271
2935         <rdar://problem/47808810>
2936
2937         Reviewed by Tim Horton.
2938
2939         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
2940
2941         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2942         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2943         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2944         (WTR::UIScriptController::rectForMenuAction const):
2945
2946         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
2947         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
2948         for when the menu is shown or hidden.
2949
2950         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2951         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
2952         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2953         (WTR::UIScriptController::setDidShowMenuCallback):
2954         (WTR::UIScriptController::didShowMenuCallback const):
2955         (WTR::UIScriptController::setDidHideMenuCallback):
2956         (WTR::UIScriptController::didHideMenuCallback const):
2957         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2958         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2959         (WTR::UIScriptController::rectForMenuAction const):
2960         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2961         * WebKitTestRunner/TestController.cpp:
2962         (WTR::TestController::resetPreferencesToConsistentValues):
2963         (WTR::updateTestOptionsFromTestHeader):
2964         * WebKitTestRunner/TestOptions.h:
2965
2966         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
2967         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
2968
2969         (WTR::TestOptions::hasSameInitializationOptions const):
2970         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2971         (WTR::UIScriptController::calendarType const):
2972         (WTR::UIScriptController::platformUndoManager const):
2973         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2974         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2975         (-[TestRunnerWKWebView initWithFrame:configuration:]):
2976         (-[TestRunnerWKWebView dealloc]):
2977         (-[TestRunnerWKWebView _didShowMenu]):
2978         (-[TestRunnerWKWebView _didHideMenu]):
2979
2980         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
2981
2982         * WebKitTestRunner/ios/TestControllerIOS.mm:
2983         (WTR::handleMenuWillHideNotification):
2984         (WTR::handleMenuDidHideNotification):
2985         (WTR::TestController::platformInitialize):
2986         (WTR::TestController::platformDestroy):
2987         (WTR::TestController::platformResetStateToConsistentValues):
2988
2989         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
2990         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
2991
2992         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2993         (WTR::forEachViewInHierarchy):
2994         (WTR::findViewInHierarchyOfType):
2995
2996         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
2997         functions that dig through a given view's hierarchy in search of a view of a given class.
2998
2999         (WTR::UIScriptController::selectionStartGrabberViewRect const):
3000         (WTR::UIScriptController::selectionEndGrabberViewRect const):
3001         (WTR::UIScriptController::selectionCaretViewRect const):
3002         (WTR::UIScriptController::selectionRangeViewRects const):
3003         (WTR::UIScriptController::platformSetDidShowMenuCallback):
3004         (WTR::UIScriptController::platformSetDidHideMenuCallback):
3005
3006         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
3007
3008         (WTR::UIScriptController::rectForMenuAction const):
3009
3010         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
3011         callout bar) whose label matches the given string.
3012
3013         (WTR::UIScriptController::platformContentView const):
3014
3015         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
3016         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
3017         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
3018
3019         (WTR::UIScriptController::platformUndoManager const): Deleted.
3020         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3021         (WTR::UIScriptController::platformContentView const):
3022         (WTR::UIScriptController::platformUndoManager const): Deleted.
3023
3024 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
3025
3026         webkitpy: No option to only show unexpected failures in results.html for iPad
3027         https://bugs.webkit.org/show_bug.cgi?id=194554
3028         <rdar://problem/47922442>
3029
3030         Rubber-stamped by Aakash Jain.
3031
3032         Just because a TestExpecations file does not exist for a specific platform does not mean that
3033         TestExpecations are not being used, given that platforms inherit test expectations.
3034
3035         * Scripts/webkitpy/port/base.py:
3036         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
3037         * Scripts/webkitpy/port/base_unittest.py:
3038         (PortTest.test_uses_test_expectations_file):
3039
3040 2019-02-12  Alex Christensen  <achristensen@webkit.org>
3041
3042         Remove setDefersLoading infrastructure from WebKit2
3043         https://bugs.webkit.org/show_bug.cgi?id=194506
3044
3045         Reviewed by Brady Eidson.
3046
3047         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3048         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3049         (WTR::TestRunner::setDefersLoading): Deleted.
3050         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3051
3052 2019-02-12  Alex Christensen  <achristensen@webkit.org>
3053
3054         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
3055         https://bugs.webkit.org/show_bug.cgi?id=194522
3056         <rdar://problem/47789393>
3057
3058         Reviewed by Chris Dumez.
3059
3060         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3061         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
3062         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3063         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3064
3065 2019-02-12  Andy Estes  <aestes@apple.com>
3066
3067         [iOSMac] Enable Parental Controls Content Filtering
3068         https://bugs.webkit.org/show_bug.cgi?id=194521
3069         <rdar://39732376>
3070
3071         Reviewed by Tim Horton.
3072
3073         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3074
3075 2019-02-12  Zalan Bujtas  <zalan@apple.com>
3076
3077         [LFC][IFC] Add intrinsic width support for float boxes.
3078         https://bugs.webkit.org/show_bug.cgi?id=194528
3079
3080         Reviewed by Antti Koivisto.
3081
3082         Expand tests coverage (2 new tests -> 800).
3083         (This is the correct test ordering --runs-singly --child-processes=1)
3084
3085         * LayoutReloaded/misc/LFC-passing-tests.txt:
3086
3087 2019-02-12  Rob Buis  <rbuis@igalia.com>
3088
3089         Implement serializing in MIME type parser
3090         https://bugs.webkit.org/show_bug.cgi?id=193909
3091
3092         Reviewed by Darin Adler.
3093
3094         Add various tests involving upper case, non-ASCII, control/null characters,
3095         various HTTP whitespace, single quotes and an unpaired surrogate.
3096
3097         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3098         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
3099         (TestWebKitAPI::serializeIfValid):
3100         (TestWebKitAPI::TEST):
3101
3102 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
3103
3104         [Cocoa] Ask platform for generic font family mappings
3105         https://bugs.webkit.org/show_bug.cgi?id=187723
3106         <rdar://problem/41892438>
3107
3108         Reviewed by Brent Fulgham.
3109
3110         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
3111
3112         * DumpRenderTree/mac/DumpRenderTree.mm:
3113         (allowedFontFamilySet):
3114         * WebKitTestRunner/mac/TestControllerMac.mm:
3115         (WTR::allowedFontFamilySet):
3116
3117 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
3118
3119         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
3120         https://bugs.webkit.org/show_bug.cgi?id=193622
3121
3122         Reviewed by Michael Catanzaro.
3123
3124         This adds support for loading content extension rule sets from the JSON files which
3125         accompany the corresponding layout test, using the C API. The Cocoa specific parts
3126         of WKTR for this could be removed, but that is left for a follow-up patch with
3127         cleanups.
3128
3129         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
3130         * WebKitTestRunner/TestController.cpp:
3131         (WTR::testPath): Subtract one from the length when constructing the result std::string to
3132         avoid having the null-terminator copied into the result.
3133         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
3134         part of the preparations to run a test.
3135         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
3136         (WTR::contentExtensionStoreCallback): Added.
3137         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
3138         used for content extensions test.
3139         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
3140         extensions and compiling the JSON rule set for tests involving content extensions.
3141         (WTR::TestController::resetContentExtensions): Removes the content extension built for
3142         testing and disables content extensions.
3143         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
3144         resetContentExtensions().
3145         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
3146         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
3147         configureContentExtensionForTest(), and userContentController().
3148
3149 2019-02-11  Daniel Bates  <dabates@apple.com>
3150
3151         [iOS] Mouse/Touch/Pointer events are missing modifier keys
3152         https://bugs.webkit.org/show_bug.cgi?id=191446
3153         <rdar://problem/45929460>
3154
3155         Reviewed by Tim Horton.
3156
3157         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
3158
3159         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3160         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
3161         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
3162         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3163         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3164         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
3165         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
3166         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3167         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3168         (WTR::arrayLength):
3169         (WTR::parseModifierArray):
3170         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
3171         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
3172         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
3173         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
3174
3175 2019-02-11  Commit Queue  <commit-queue@webkit.org>
3176
3177         Unreviewed, rolling out r241272 and r241276.
3178         https://bugs.webkit.org/show_bug.cgi?id=194514
3179
3180         Broke the Apple Internal build and the fix requires human
3181         intervention :( (Requested by dydz on #webkit).
3182
3183         Reverted changesets:
3184
3185         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
3186         https://bugs.webkit.org/show_bug.cgi?id=191446
3187         https://trac.webkit.org/changeset/241272
3188
3189         "Fix internal iOS build after r241272"
3190         https://bugs.webkit.org/show_bug.cgi?id=191446
3191         https://trac.webkit.org/changeset/241276
3192
3193 2019-02-11  Truitt Savell  <tsavell@apple.com>
3194
3195         Unreviewed, rolling out r241269.
3196
3197         Caused 5 layout tests crashes on Mac WK1
3198
3199         Reverted changeset:
3200
3201         "DumpRenderTree should report unknown options"
3202         https://bugs.webkit.org/show_bug.cgi?id=191303
3203         https://trac.webkit.org/changeset/241269
3204
3205 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3206
3207         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
3208         https://bugs.webkit.org/show_bug.cgi?id=194313
3209
3210         Reviewed by Tim Horton.
3211
3212         Add a helper to determine whether the web view is presenting modal UI.
3213
3214         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3215         (WTR::UIScriptController::isPresentingModally const):
3216         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3217         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3218         (WTR::UIScriptController::isPresentingModally const):
3219         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3220         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3221         (WTR::UIScriptController::calendarType const): Deleted.
3222         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3223         (WTR::UIScriptController::isPresentingModally const):
3224         (WTR::UIScriptController::calendarType const):
3225         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3226         (WTR::UIScriptController::calendarType const):
3227
3228 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
3229
3230         GCHeapInspector: Show the retained sizes in more places
3231         https://bugs.webkit.org/show_bug.cgi?id=194464
3232
3233         Reviewed by Simon Fraser.
3234
3235         * GCHeapInspector/gc-heap-inspector.html:
3236         * GCHeapInspector/script/interface.js:
3237         (HeapInspectorUtils.humanReadableSize):
3238         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
3239         (HeapInspectorUtils.spanForNode.span.span):
3240         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
3241         (HeapSnapshotInspector.prototype.buildRoots):
3242
3243 2019-02-11  Daniel Bates  <dabates@apple.com>
3244
3245         [iOS] Mouse/Touch/Pointer events are missing modifier keys
3246         https://bugs.webkit.org/show_bug.cgi?id=191446
3247         <rdar://problem/45929460>
3248
3249         Reviewed by Tim Horton.
3250
3251         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
3252
3253         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3254         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
3255         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
3256         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3257         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3258         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
3259         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
3260         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3261         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3262         (WTR::arrayLength):
3263         (WTR::parseModifierArray):
3264         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
3265         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
3266         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
3267         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
3268
3269 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
3270
3271         DumpRenderTree should report unknown options
3272         https://bugs.webkit.org/show_bug.cgi?id=191303
3273
3274         Reviewed by Frédéric Wang.
3275
3276         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
3277         to report unknown options.
3278         Added and assigned test options which are currently used in tests.
3279
3280         * DumpRenderTree/TestOptions.cpp:
3281         (TestOptions::TestOptions):
3282
3283 2019-02-11  Truitt Savell  <tsavell@apple.com>
3284
3285         Unreviewed, rolling out r241229.
3286
3287         Revision broke internal builds for watchOS.
3288
3289         Reverted changeset:
3290
3291         "[Cocoa] Ask platform for generic font family mappings"
3292         https://bugs.webkit.org/show_bug.cgi?id=187723
3293         https://trac.webkit.org/changeset/241229
3294
3295 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
3296
3297         [WinCairo][MiniBrowser] Basic authentication always fails.
3298         https://bugs.webkit.org/show_bug.cgi?id=194496
3299
3300         Reviewed by Don Olmstead.
3301
3302         * MiniBrowser/win/DialogHelper.h:
3303         (Dialog::getText):
3304
3305 2019-02-11  Philippe Normand  <pnormand@igalia.com>
3306
3307         [GStreamer] GstMappedBuffer testsuite build fails
3308         https://bugs.webkit.org/show_bug.cgi?id=194495
3309
3310         Reviewed by Carlos Garcia Campos.
3311
3312         Fix the build by explicitely adding the gstreamer1.0-audio include
3313         directories to the include path.
3314
3315         * TestWebKitAPI/PlatformGTK.cmake:
3316         * TestWebKitAPI/PlatformWPE.cmake:
3317
3318 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3319
3320         [GTK][WPE] Add enable-javascript-markup setting
3321         https://bugs.webkit.org/show_bug.cgi?id=193439
3322
3323         Reviewed by Michael Catanzaro.
3324
3325         Add test cases to check the new setting.
3326
3327         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3328         (testWebKitSettings):
3329         (testWebKitSettingsJavaScriptMarkup):
3330         (beforeAll):
3331
3332 2019-02-10  Darin Adler  <darin@apple.com>
3333
3334         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
3335         https://bugs.webkit.org/show_bug.cgi?id=194485
3336
3337         Reviewed by Daniel Bates.
3338
3339         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
3340
3341 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
3342
3343         Add more tests for clampTo<>()
3344         https://bugs.webkit.org/show_bug.cgi?id=194462
3345
3346         Reviewed by Geoffrey Garen.
3347
3348         Darin suggested to test the very last floating point number
3349         at the boundaries when truncating to integer.
3350         I added test for max/min and max-1/min-1.
3351
3352         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3353         (TestWebKitAPI::TEST):
3354
3355 2019-02-09  Darin Adler  <darin@apple.com>
3356
3357         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
3358         https://bugs.webkit.org/show_bug.cgi?id=194021
3359
3360         Reviewed by Geoffrey Garen.
3361
3362         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
3363         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
3364         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
3365
3366 2019-02-09  Zalan Bujtas  <zalan@apple.com>
3367
3368         [LFC][IFC] Add intrinsic width support for basic inline containers
3369         https://bugs.webkit.org/show_bug.cgi?id=194473
3370
3371         Reviewed by Antti Koivisto.
3372
3373         Expand tests coverage (11 new tests -> 798)
3374
3375         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
3376
3377 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
3378
3379         Fix MiniBrowser's entitlements
3380         https://bugs.webkit.org/show_bug.cgi?id=192431
3381
3382         Reviewed by Joseph Pecoraro.
3383
3384         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
3385         files, making it impossible to load any extension.
3386
3387         * MiniBrowser/MiniBrowser.entitlements:
3388
3389 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
3390
3391         [Cocoa] Ask platform for generic font family mappings
3392         https://bugs.webkit.org/show_bug.cgi?id=187723
3393         <rdar://problem/41892438>
3394
3395         Reviewed by Brent Fulgham.
3396
3397         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
3398
3399         * DumpRenderTree/mac/DumpRenderTree.mm:
3400         (allowedFontFamilySet):
3401         * WebKitTestRunner/mac/TestControllerMac.mm:
3402         (WTR::allowedFontFamilySet):
3403
3404 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
3405
3406         [GTK] Implement back/forward touchpad gesture
3407         https://bugs.webkit.org/show_bug.cgi?id=193919
3408
3409         Reviewed by Michael Catanzaro.
3410
3411         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
3412         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
3413
3414 2019-02-08  Alex Christensen  <achristensen@webkit.org>
3415
3416         Add SPI to use networking daemon instead of XPC service
3417         https://bugs.webkit.org/show_bug.cgi?id=194427
3418
3419         Reviewed by Geoffrey Garen
3420
3421         * MiniBrowser/MiniBrowser.entitlements:
3422
3423 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
3424
3425         [ews-build] Ensure that every builder in config.json has short name
3426         https://bugs.webkit.org/show_bug.cgi?id=194461
3427
3428         Reviewed by Lucas Forschler.
3429
3430         * BuildSlaveSupport/ews-build/loadConfig.py:
3431         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
3432
3433 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
3434
3435         [ews-build] Add short name to config.json
3436         https://bugs.webkit.org/show_bug.cgi?id=194456
3437
3438         Reviewed by Lucas Forschler.
3439
3440         * BuildSlaveSupport/ews-build/config.json: Added short name.
3441         * BuildSlaveSupport/ews-build/loadConfig.py:
3442         (loadBuilderConfig): Set the short name as the builder description.
3443
3444 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
3445
3446         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
3447         https://bugs.webkit.org/show_bug.cgi?id=194418
3448
3449         Reviewed by Lucas Forschler.
3450
3451         Do not include errors trying when finding crashlogs at the end of
3452         a run-webkit-tests run since we don't process those errors.
3453
3454         * Scripts/webkitpy/port/darwin.py:
3455         (DarwinPort._look_for_all_crash_logs_in_log_dir):
3456         * Scripts/webkitpy/port/ios_device.py:
3457         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
3458         * Scripts/webkitpy/port/watch_device.py:
3459         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
3460
3461 2019-02-08  Beth Dakin  <bdakin@apple.com>
3462
3463         Add afterScreenUpdates to WKSnapshotConfiguration
3464         https://bugs.webkit.org/show_bug.cgi?id=194362
3465         -and corresponding-
3466         <rdar://problem/40655528> Please add an "after screen updates" property to 
3467         WKSnapshotConfiguration (to solve blank snapshots)
3468
3469         Reviewed by Tim Horton.
3470
3471         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
3472         (TEST):
3473
3474 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
3475
3476         clampTo(): do not convert the input to double when dealing with integers
3477         https://bugs.webkit.org/show_bug.cgi?id=194263
3478         <rdar://problem/47692312>
3479
3480         Reviewed by Darin Adler.
3481
3482         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3483         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
3484         (TestWebKitAPI::testClampFloatingPointToInteger):
3485         (TestWebKitAPI::testClampSameSignIntegers):
3486         (TestWebKitAPI::testClampUnsignedToSigned):
3487         (TestWebKitAPI::testClampSignedToUnsigned):
3488
3489 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
3490
3491         webkitpy: Respect --dedicated-simulators flag
3492         https://bugs.webkit.org/show_bug.cgi?id=194416
3493         <rdar://problem/47894722>
3494
3495         Reviewed by Lucas Forschler.
3496
3497         * Scripts/webkitpy/port/device_port.py:
3498         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
3499         available devices can be safely ignored.
3500
3501 2019-02-07  Keith Rollin  <krollin@apple.com>
3502
3503         Remove extra copy of 100x100-red.tga
3504         https://bugs.webkit.org/show_bug.cgi?id=194371
3505         <rdar://problem/47873465>
3506
3507         Reviewed by Said Abou-Hallawa.
3508
3509         In order to help it pass its tests, Bug 194190 added a second copy of
3510         the file 100x100-red.tga. However, it turns out that this additional
3511         file wasn't actually needed, and that that sole previous copy was
3512         sufficient. At the same time, this second copy -- which was copied to
3513         the same location in the build output as the first copy -- now caused
3514         XCBuild to complain because there were two production rules for the
3515         same output file. Address this by removing the newly-added extra copy.
3516
3517         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3518         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
3519
3520 2019-02-07  Alex Christensen  <achristensen@webkit.org>
3521
3522         Deprecate WKBundlePageSetDefersLoading
3523         https://bugs.webkit.org/show_bug.cgi?id=191394
3524
3525         Reviewed by Dean Jackson.
3526
3527         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3528         (WTR::TestRunner::setDefersLoading):
3529
3530 2019-02-07  Zalan Bujtas  <zalan@apple.com>
3531
3532         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
3533         https://bugs.webkit.org/show_bug.cgi?id=194391
3534
3535         Reviewed by Antti Koivisto.
3536
3537         * LayoutReloaded/misc/LFC-passing-tests.txt:
3538
3539 2019-02-06  Keith Rollin  <krollin@apple.com>
3540
3541         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
3542         https://bugs.webkit.org/show_bug.cgi?id=193975
3543         <rdar://problem/47643306>
3544
3545         Reviewed by Tim Horton.
3546
3547         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
3548         the Info.plist file into the bundle. This step is not necessary as the
3549         implicit "bundle up all the build products into a framework" build
3550         phase does this already. Having the Copy Bundle Resources phase do
3551         this causes a conflict under XCBuild, which objects to two build
3552         phases producing the same file (Info.plist). Address this by removing
3553         Info.plist from the Copy Bundle Resources phase.
3554
3555         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
3556
3557 2019-02-06  Keith Rollin  <krollin@apple.com>
3558
3559         Really enable the automatic checking and regenerations of .xcfilelists during builds
3560         https://bugs.webkit.org/show_bug.cgi?id=194357
3561         <rdar://problem/47861231>
3562
3563         Reviewed by Chris Dumez.
3564
3565         Bug 194124 was supposed to enable the automatic checking and
3566         regenerating of .xcfilelist files during the build. While related
3567         changes were included in that patch, the change to actually enable the
3568         operation somehow was omitted. This patch actually enables the
3569         operation. The check-xcfilelist.sh scripts now check
3570         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
3571         from the checking.
3572
3573         * DumpRenderTree/Scripts/check-xcfilelists.sh:
3574         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
3575
3576 2019-02-06  David Kilzer  <ddkilzer@apple.com>
3577
3578         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
3579         <https://webkit.org/b/194286>
3580         <rdar://problem/47815558>
3581
3582         Reviewed by Alexey Proskuryakov.
3583
3584         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3585         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
3586         WKRetainPtr<> to avoid leaking the WKDataRef.
3587
3588 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
3589
3590         Unreviewed, fix a typo
3591
3592         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3593
3594 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
3595
3596         [GTK][WPE] force libpsl build to use ICU in jhbuild
3597         https://bugs.webkit.org/show_bug.cgi?id=194288
3598
3599         Reviewed by Carlos Garcia Campos.
3600
3601         * gtk/jhbuild.modules:
3602         Require ICU for libpsl build in jhbuild, like done in WPE.
3603
3604 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
3605
3606         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
3607         https://bugs.webkit.org/show_bug.cgi?id=194209
3608
3609         Reviewed by Carlos Garcia Campos.
3610
3611         Enhance TestCookieManager to ensure this doesn't happen again.
3612
3613         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
3614         (testCookieManagerPersistentStorage):
3615         (beforeAll):
3616
3617 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
3618
3619         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
3620         https://bugs.webkit.org/show_bug.cgi?id=194324
3621
3622         Reviewed by Andy Estes.
3623
3624         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
3625         part of the name is already implicit, since this is in testing code in TestOptions.
3626
3627         * WebKitTestRunner/TestController.cpp:
3628         (WTR::TestController::generateContextConfiguration const):
3629         (WTR::updateTestOptionsFromTestHeader):
3630         * WebKitTestRunner/TestOptions.h:
3631         (WTR::TestOptions::hasSameInitializationOptions const):
3632
3633 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3634
3635         [ews-build] Allow * as platform for builders and workers
3636         https://bugs.webkit.org/show_bug.cgi?id=188533
3637
3638         Reviewed by Lucas Forschler.
3639
3640         * BuildSlaveSupport/ews-build/loadConfig.py:
3641         (checkWorkersAndBuildersForConsistency):
3642
3643 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3644
3645         [ews-build] Add few bots to config.json
3646         https://bugs.webkit.org/show_bug.cgi?id=194304
3647
3648         Reviewed by Lucas Forschler.
3649
3650         * BuildSlaveSupport/ews-build/config.json:
3651
3652 2019-02-05  Keith Rollin  <krollin@apple.com>
3653
3654         Enable the automatic checking and regenerations of .xcfilelists during builds
3655         https://bugs.webkit.org/show_bug.cgi?id=194124
3656         <rdar://problem/47721277>
3657
3658         Reviewed by Tim Horton.
3659
3660         Bug 193790 add a facility for checking -- during build time -- that
3661         any needed .xcfilelist files are up-to-date and for updating them if
3662         they are not. This facility was initially opt-in by setting
3663         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
3664         the process seemed robust. Its now time to enable this facility and
3665         make it opt-out. If there is a need to disable this facility, set and
3666         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
3667         running `make` or `build-webkit`, or before running Xcode from the
3668         command line.
3669
3670         Additionally, remove the step that generates a list of source files
3671         going into the UnifiedSources build step. It's only necessarily to
3672         specify Sources.txt and SourcesCocoa.txt as inputs.
3673
3674         * Scripts/generate-xcfilelists:
3675
3676 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
3677
3678         [GTK][WPE] force libpsl build to use ICU in jhbuild
3679         https://bugs.webkit.org/show_bug.cgi?id=194288
3680
3681         Reviewed by Philippe Normand.
3682
3683         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
3684         This can cause build failures if libidn is detected but libunistring is not available.
3685
3686         Make sure that ICU is used for runtime and builtin PSL data.
3687
3688         * gtk/jhbuild.modules:
3689         * wpe/jhbuild.modules:
3690
3691 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3692
3693         [ews-app] Modified timestamp should be updated on updating data
3694         https://bugs.webkit.org/show_bug.cgi?id=194295
3695
3696         Reviewed by Lucas Forschler.
3697
3698         * BuildSlaveSupport/ews-app/ews/models/build.py:
3699         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3700         * BuildSlaveSupport/ews-app/ews/models/step.py:
3701
3702 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
3703
3704         Unreviewed, rolling out r240742.
3705
3706         Causes crashes on iOS simulator.
3707
3708         Reverted changeset:
3709
3710         "[iOS] Keyups for non-modifier keys identified as "Dead" when
3711         not focused in a content-editable element"
3712         https://bugs.webkit.org/show_bug.cgi?id=192824
3713         https://trac.webkit.org/changeset/240742
3714
3715 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
3716
3717         run-webkit-tests emits message "...running None" when running tests
3718         https://bugs.webkit.org/show_bug.cgi?id=194133
3719         <rdar://problem/47724738>
3720
3721         Reviewed by Lucas Forschler.
3722
3723         * Scripts/webkitpy/xcode/device_type.py:
3724         (DeviceType.__str__): Use both version mapping tables and use just the variant
3725         name if no version name is available.
3726         * Scripts/webkitpy/xcode/device_type_unittest.py:
3727         (DeviceTypeTest):
3728         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
3729         an associated named.
3730
3731 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
3732
3733         [WPE] require python3-setuptools for meson build in jhbuild
3734         https://bugs.webkit.org/show_bug.cgi?id=194287
3735
3736         Reviewed by Philippe Normand.
3737
3738         python3-setuptools is needed to build meson in jhbuild.
3739         It is already required by the GTK port.
3740
3741         * wpe/install-dependencies:
3742
3743 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3744
3745         [ews-app] Add method to save BuilderMapping to database
3746         https://bugs.webkit.org/show_bug.cgi?id=194264
3747
3748         Reviewed by Lucas Forschler.
3749
3750         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3751         (BuilderMapping.__str__):
3752         (BuilderMapping):
3753         (BuilderMapping.save_mapping):
3754         (BuilderMapping.update_mapping):
3755         (BuilderMapping.get_existing_mapping):
3756         (BuilderMapping.is_valid_mapping):
3757
3758 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
3759
3760         [ews-app] Add timestamp fields for BuilderMappings
3761         https://bugs.webkit.org/show_bug.cgi?id=194266
3762
3763         Reviewed by Lucas Forschler.
3764
3765         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3766         (BuilderMapping):
3767
3768 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
3769
3770         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
3771         https://bugs.webkit.org/show_bug.cgi?id=174816
3772
3773         Reviewed by Michael Catanzaro.
3774
3775         Add tests for webkit_uri_for_display().
3776
3777         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
3778         (testURIForDisplayUnaffected):
3779         (testURIForDisplayAffected):
3780         (beforeAll):
3781         (afterAll):
3782         * TestWebKitAPI/glib/CMakeLists.txt:
3783
3784 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
3785
3786         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
3787         https://bugs.webkit.org/show_bug.cgi?id=194158
3788         <rdar://problem/47737268>
3789
3790         Rubber-stamped by Aakash Jain.
3791
3792         * Scripts/webkitpy/port/device_port.py:
3793         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
3794
3795 2019-02-04  Said Abou-Hallawa  <said@apple.com>
3796
3797         [CG] Enable setAdditionalSupportedImageTypes for WK1
3798         https://bugs.webkit.org/show_bug.cgi?id=194190
3799
3800         Reviewed by Tim Horton.
3801
3802         Add a test similar to the one under WebKit Cocoa but make it create a
3803         WebView instead of a WKWebView.
3804
3805         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3806         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
3807         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
3808         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
3809         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
3810         (TestWebKitAPI::runTest):
3811         (TestWebKitAPI::TEST):
3812
3813 2019-02-04  Zalan Bujtas  <zalan@apple.com>
3814
3815         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
3816         https://bugs.webkit.org/show_bug.cgi?id=194168
3817
3818         Reviewed by Simon Fraser.
3819
3820         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
3821
3822         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3823         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
3824         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
3825         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
3826         (TEST):
3827         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
3828         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
3829
3830 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
3831
3832         REGRESSION (r237269): webkit-patch what-broke is broken 
3833         https://bugs.webkit.org/show_bug.cgi?id=193025
3834
3835         Reviewed by Aakash Jain.
3836
3837         * Scripts/webkitpy/common/host.py:
3838         (Host.buildbot):
3839         (Host.bugzilla): Renamed to 'buildbot'.
3840
3841 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3842
3843         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
3844         https://bugs.webkit.org/show_bug.cgi?id=194207
3845
3846         Reviewed by Tim Horton.
3847
3848         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
3849         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
3850         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
3851         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
3852         start and delete forwards to remove the original attachment.
3853
3854         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3855         (TestWebKitAPI::TEST):
3856
3857 2019-02-04  Youenn Fablet  <youenn@apple.com>
3858
3859         Capture state should be managed consistently when doing process swapping
3860         https://bugs.webkit.org/show_bug.cgi?id=194122
3861         <rdar://problem/47609293>
3862
3863         Reviewed by Eric Carlson.
3864
3865         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3866         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
3867         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
3868         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
3869         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3870         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3871         (WTR::TestRunner::isDoingMediaCapture const):
3872         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3873         * WebKitTestRunner/TestController.cpp:
3874         (WTR::TestController::isDoingMediaCapture const):
3875         * WebKitTestRunner/TestController.h:
3876         * WebKitTestRunner/TestInvocation.cpp:
3877         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3878         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3879         (WTR::TestController::isDoingMediaCapture const):
3880
3881 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
3882
3883         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
3884         https://bugs.webkit.org/show_bug.cgi?id=194142
3885
3886         Reviewed by Ross Kirsling.
3887
3888         There three 'separator' variables in TestController.cpp. Renamed
3889         it 'pathSeparator', and unified them.
3890
3891         * WebKitTestRunner/TestController.cpp:
3892         (WTR::TestController::generateContextConfiguration const):
3893         (WTR::createTestURL):
3894         (WTR::TestController::platformAdjustContext):
3895
3896 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
3897
3898         Make setNeedsLayout on the root more explicitly about triggering its side-effects
3899         https://bugs.webkit.org/show_bug.cgi?id=194198
3900
3901         Reviewed by Antti Koivisto.
3902
3903         No need to set the banner heights on navigation now, since Page stores them.
3904
3905         * MiniBrowser/mac/WK2BrowserWindowController.m:
3906         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
3907
3908 2019-02-03  John Wilander  <wilander@apple.com>
3909
3910         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
3911         https://bugs.webkit.org/show_bug.cgi?id=194104
3912         <rdar://problem/47649991>
3913
3914         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
3915
3916         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3917         (TestWebKitAPI::TEST):
3918             Changed numeric types from unsigned short to uint32_t.
3919
3920 2019-02-02  David Kilzer  <ddkilzer@apple.com>
3921
3922         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
3923         <https://webkit.org/b/194178>
3924         <rdar://problem/47753473>
3925
3926         Reviewed by Alexey Proskuryakov.
3927
3928         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3929         (WTR::uninstallFakeHelvetica): Pass nullptr into
3930         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
3931
3932 2019-02-02  Zalan Bujtas  <zalan@apple.com>
3933
3934         [LFC] Initialize ICB's style with fixed width/height.
3935         https://bugs.webkit.org/show_bug.cgi?id=194188
3936
3937         Reviewed by Antti Koivisto.
3938
3939         * LayoutReloaded/misc/LFC-passing-tests.txt:
3940
3941 2019-02-02  Zalan Bujtas  <zalan@apple.com>
3942
3943         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
3944         https://bugs.webkit.org/show_bug.cgi?id=194185
3945
3946         Reviewed by Antti Koivisto.
3947
3948         * LayoutReloaded/misc/LFC-passing-tests.txt:
3949
3950 2018-12-16  Darin Adler  <darin@apple.com>
3951
3952         Convert additional String::format clients to alternative approaches
3953         https://bugs.webkit.org/show_bug.cgi?id=192746
3954
3955         Reviewed by Alexey Proskuryakov.
3956
3957         * WebKitTestRunner/TestController.cpp:
3958         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
3959         as an intermediate in code that ultimately constructs a WTF::String.
3960         (WTR::userMediaOriginHash): Use makeString.
3961         (WTR::TestController::didNavigateWithNavigationData): More of the same.
3962         (WTR::TestController::didPerformClientRedirect): Ditto.
3963         (WTR::TestController::didPerformServerRedirect): Ditto.
3964         (WTR::TestController::didUpdateHistoryTitle): Ditto.
3965
3966 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
3967
3968         [ews-build] Add unit test to verify builder keys
3969         https://bugs.webkit.org/show_bug.cgi?id=194152
3970
3971         Reviewed by Lucas Forschler.
3972
3973         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3974         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
3975
3976 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3977
3978         [LFC] Expand tests coverage (12 new tests -> 787)
3979
3980         Unreviewed test gardening.
3981
3982         * LayoutReloaded/misc/LFC-passing-tests.txt:
3983
3984 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3985
3986         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
3987         https://bugs.webkit.org/show_bug.cgi?id=194163
3988
3989         Reviewed by Simon Fraser.
3990
3991         775
3992
3993         * LayoutReloaded/misc/LFC-passing-tests.txt:
3994
3995 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3996
3997         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
3998         https://bugs.webkit.org/show_bug.cgi?id=194140
3999         <rdar://problem/47728098>
4000
4001         Reviewed by Tim Horton.
4002
4003         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4004         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4005         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
4006
4007         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
4008         test to induce an IPC deadlock when presenting a modal alert during touch start.
4009
4010         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4011         * WebKitTestRunner/TestController.cpp:
4012         (WTR::runJavaScriptAlert):
4013
4014         Add a client callback function for running JavaScript alerts.
4015
4016         (WTR::TestController::createOtherPage):
4017         (WTR::TestController::generateContextConfiguration const):
4018
4019         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
4020         the fix in this patch.
4021
4022         (WTR::TestController::createWebViewWithOptions):
4023
4024         Plumb TestOptions to generateContextConfiguration.
4025
4026         (WTR::TestController::resetPreferencesToConsistentValues):
4027         (WTR::TestController::resetStateToConsistentValues):
4028         (WTR::updateTestOptionsFromTestHeader):
4029         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
4030         (WTR::TestController::handleJavaScriptAlert):
4031         * WebKitTestRunner/TestController.h:
4032         * WebKitTestRunner/TestInvocation.cpp:
4033         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4034         * WebKitTestRunner/TestOptions.h:
4035         (WTR::TestOptions::hasSameInitializationOptions const):
4036
4037 2019-02-01  Chris Dumez  <cdumez@apple.com>
4038
4039         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
4040         https://bugs.webkit.org/show_bug.cgi?id=193740
4041         <rdar://problem/47527267>
4042
4043         Reviewed by Alex Christensen.
4044
4045         Add API test coverage.
4046
4047         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4048
4049 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
4050
4051         [ews-app] Add display name field to BuilderMapping model
4052         https://bugs.webkit.org/show_bug.cgi?id=194153
4053
4054         Reviewed by Lucas Forschler.
4055
4056         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
4057         (BuilderMapping):
4058
4059 2019-02-01  Youenn Fablet  <youenn@apple.com>
4060
4061         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
4062         https://bugs.webkit.org/show_bug.cgi?id=194155
4063
4064         Reviewed by Eric Carlson.
4065
4066         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
4067         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
4068         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
4069
4070 2019-02-01  Zalan Bujtas  <zalan@apple.com>
4071
4072         [LFC] Adjust replaced element's intrinsic ratio
4073         https://bugs.webkit.org/show_bug.cgi?id=194154
4074
4075         Reviewed by Antti Koivisto.
4076
4077         761
4078
4079         * LayoutReloaded/misc/LFC-passing-tests.txt:
4080
4081 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
4082
4083         [WPE] Show test results in minibrowser
4084         https://bugs.webkit.org/show_bug.cgi?id=194150
4085
4086         Reviewed by Žan Doberšek.
4087
4088         * Scripts/webkitpy/port/wpe.py:
4089         (WPEPort.show_results_html_file):
4090
4091 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
4092
4093         [WPE] MiniBrowser: add ky bindings for back/forward navigation
4094         https://bugs.webkit.org/show_bug.cgi?id=194151
4095
4096         Reviewed by Žan Doberšek.
4097
4098         ALT + <- go back
4099         ALT + -> go forward
4100
4101         * MiniBrowser/wpe/main.cpp:
4102         (main):
4103
4104 2019-02-01  Zalan Bujtas  <zalan@apple.com>
4105
4106         [LFC] Set intrinsic size on Layout::Replaced
4107         https://bugs.webkit.org/show_bug.cgi?id=194139
4108
4109         Reviewed by Antti Koivisto.
4110
4111         744
4112
4113         * LayoutReloaded/misc/LFC-passing-tests.txt:
4114
4115 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
4116
4117         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
4118         https://bugs.webkit.org/show_bug.cgi?id=194146
4119
4120         Reviewed by Xabier Rodriguez-Calvar.
4121
4122         It allows to open relative paths.
4123
4124         * MiniBrowser/wpe/main.cpp:
4125         (main):
4126
4127 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
4128
4129         Update flakiness dashboard configuration after recent queue changes
4130         https://bugs.webkit.org/show_bug.cgi?id=194127
4131
4132         Rubber-stamped by Aakash Jain.
4133
4134         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
4135
4136         * TestResultServer/static-dashboards/builders.jsonp:
4137
4138 2019-01-31  Youenn Fablet  <youenn@apple.com>
4139
4140         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
4141         https://bugs.webkit.org/show_bug.cgi?id=194106
4142         <rdar://problem/47676333>
4143
4144         Reviewed by Ryosuke Niwa.
4145
4146         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
4147         (TestWebKitAPI::didFinishNavigation):
4148         (TestWebKitAPI::TEST):
4149         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
4150
4151 2019-01-31  Chris Dumez  <cdumez@apple.com>
4152
4153         Page zoom level is lost after a process swap or a crash
4154         https://bugs.webkit.org/show_bug.cgi?id=194105
4155         <rdar://problem/47610781>
4156
4157         Reviewed by Alex Christensen.
4158
4159         Add API test coverage.
4160
4161         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4162         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
4163
4164 2019-01-31  Alex Christensen  <achristensen@webkit.org>
4165
4166         Revert r238819 which is unneeded and caused a performance regression.
4167         https://bugs.webkit.org/show_bug.cgi?id=192272
4168         <rdar://problem/46664625>
4169
4170         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
4171         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
4172         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
4173
4174 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
4175
4176         Formalize WebKitAdditions mechanism of LoadOptimizer
4177         https://bugs.webkit.org/show_bug.cgi?id=193886
4178         <rdar://problem/47696809>
4179
4180         Reviewed by Brent Fulgham.
4181
4182         * MiniBrowser/MiniBrowser.entitlements:
4183         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
4184
4185 2019-01-31  Zalan Bujtas  <zalan@apple.com>
4186
4187         [LFC] Margin before/after/start/end initial value is 0 and not auto.
4188         https://bugs.webkit.org/show_bug.cgi?id=194090
4189
4190         Reviewed by Antti Koivisto.
4191
4192         * LayoutReloaded/misc/LFC-passing-tests.txt:
4193
4194 2019-01-31  Zalan Bujtas  <zalan@apple.com>
4195
4196         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
4197         https://bugs.webkit.org/show_bug.cgi?id=194074
4198
4199         Reviewed by Antti Koivisto.
4200
4201         * LayoutReloaded/misc/LFC-passing-tests.txt:
4202
4203 2019-01-31  Zalan Bujtas  <zalan@apple.com>
4204
4205         [LFC][BFC] Add support for block level replaced box.
4206         https://bugs.webkit.org/show_bug.cgi?id=194071
4207
4208         Reviewed by Antti Koivisto.
4209
4210         * LayoutReloaded/misc/LFC-passing-tests.txt:
4211
4212 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
4213
4214         Fix WebKitTestRunner's testPath with Windows full paths
4215         https://bugs.webkit.org/show_bug.cgi?id=194012
4216
4217         Reviewed by Alex Christensen.
4218
4219         updateTestOptionsFromTestHeader failed to open test files because
4220         testPath returned wrong file paths. It returned a path "/C:/..."
4221         if a URL "file:///C:/..." was given.
4222
4223         * WebKitTestRunner/TestController.cpp:
4224         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
4225
4226 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
4227
4228         [WPE] Bump font related dependencies to match the GTK+ port
4229         https://bugs.webkit.org/show_bug.cgi?id=194017
4230
4231         Reviewed by Žan Doberšek.
4232
4233         * wpe/jhbuild.modules:
4234         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
4235         * wpe/patches/icudata-stdlibs.patch: Added.
4236
4237 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
4238
4239         Enable swipe tests on iOS
4240         https://bugs.webkit.org/show_bug.cgi?id=194076
4241
4242         Reviewed by Geoffrey Garen.
4243
4244         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
4245         it causes a debug assertion failure in runUIScript.
4246
4247         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4248         (WTR::UIScriptController::beginBackSwipe):
4249         (WTR::UIScriptController::completeBackSwipe):
4250
4251 2019-01-30  Keith Rollin  <krollin@apple.com>
4252
4253         Use correct printf format specifier
4254         https://bugs.webkit.org/show_bug.cgi?id=194062
4255         <rdar://problem/47686167>
4256
4257         Reviewed by Alexey Proskuryakov.
4258
4259         LayoutTestSpellChecker.mm is trying to format a variable of type
4260         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
4261         actually an unsigned long long. Fix this by formatting with %llu.
4262
4263         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
4264         (-[LayoutTestTextCheckingResult description]):
4265
4266 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
4267
4268         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
4269         https://bugs.webkit.org/show_bug.cgi?id=193979
4270
4271         Reviewed by Wenson Hsieh.
4272
4273         Fix the test for iOS. Make the test work with iOS UA string.
4274
4275         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4276
4277 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
4278
4279         Replace High Sierra LLINT CLoop bot due to hardware failure
4280         https://bugs.webkit.org/show_bug.cgi?id=194066
4281
4282         Reviewed by Aakash Jain.
4283
4284         * BuildSlaveSupport/build.webkit.org-config/config.json:
4285
4286 2019-01-30  Keith Rollin  <krollin@apple.com>
4287
4288         [NSDragItem init] is unavailable
4289         https://bugs.webkit.org/show_bug.cgi?id=194059
4290         <rdar://problem/47685715>
4291
4292         Reviewed by Wenson Hsieh.
4293
4294         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
4295         DumpRenderTree and TestWebKitAPI, which both try to create an
4296         NSDragItem in a manner that invokes this method. Address this by using
4297         -initWithPasteboardWriter instead.
4298
4299         Note that the parameter passed to initWithPasteboardWriter is likely
4300         incorrect. In both cases, the object passed does not conform to
4301         NSPasteboardWriting. However, with this fix, we're no worse off than
4302         before, and can now perform builds with newer compilers and SDKs until
4303         a real fix can be crafted. That work is tracked in
4304         https://bugs.webkit.org/show_bug.cgi?id=194060
4305
4306         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
4307         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
4308         * TestWebKitAPI/mac/TestDraggingInfo.mm:
4309         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
4310
4311 2019-01-30  Daniel Bates  <dabates@apple.com>
4312
4313         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
4314         https://bugs.webkit.org/show_bug.cgi?id=192824
4315         <rdar://problem/47100332>
4316
4317         Reviewed by Wenson Hsieh.
4318
4319         Fix a bug where the wrong usage code was used for F13 thru F24.
4320
4321         * WebKitTestRunner/ios/HIDEventGenerator.mm:
4322         (keyCodeForDOMFunctionKey):
4323
4324 2019-01-30  Chris Dumez  <cdumez@apple.com>
4325
4326         Regression(PSON) Load hang can occur on history navigation
4327         https://bugs.webkit.org/show_bug.cgi?id=194030
4328         <rdar://problem/47656939>
4329
4330         Reviewed by Antti Koivisto.
4331
4332         Add API test coverage.
4333
4334         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4335
4336 2019-01-30  Zalan Bujtas  <zalan@apple.com>
4337
4338         [LFC] Expand tests coverage.
4339
4340         Unreviewed test gardening.
4341
4342         * LayoutReloaded/misc/LFC-passing-tests.txt:
4343
4344 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
4345
4346         [Flatpak] Add openjpeg support
4347         https://bugs.webkit.org/show_bug.cgi?id=194019
4348
4349         Reviewed by Michael Catanzaro.
4350
4351         * flatpak/org.webkit.CommonModules.yaml:
4352
4353 2019-01-30  Commit Queue  <commit-queue@webkit.org>
4354
4355         Unreviewed, rolling out r240708.
4356         https://bugs.webkit.org/show_bug.cgi?id=194022
4357
4358         It broke WPE build (Requested by KaL on #webkit).
4359
4360         Reverted changeset:
4361
4362         "[WPE] Bump font related dependencies to match the GTK+ port"
4363         https://bugs.webkit.org/show_bug.cgi?id=194017
4364         https://trac.webkit.org/changeset/240708
4365
4366 2019-01-30  Zalan Bujtas  <zalan@apple.com>
4367
4368         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
4369         https://bugs.webkit.org/show_bug.cgi?id=194001
4370
4371         Reviewed by Antti Koivisto.
4372
4373         * LayoutReloaded/misc/LFC-passing-tests.txt:
4374
4375 2019-01-30  Zalan Bujtas  <zalan@apple.com>
4376
4377         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
4378         https://bugs.webkit.org/show_bug.cgi?id=194020
4379
4380         Reviewed by Antti Koivisto.
4381
4382         * LayoutReloaded/misc/LFC-passing-tests.txt:
4383
4384 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
4385
4386         AX: Support color well on iOS
4387         https://bugs.webkit.org/show_bug.cgi?id=194010
4388
4389         Reviewed by Joanmarie Diggs.
4390
4391         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
4392         (WTR::AccessibilityUIElement::stringAttributeValue):
4393
4394 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
4395
4396         [WPE] Bump font related dependencies to match the GTK+ port
4397         https://bugs.webkit.org/show_bug.cgi?id=194017
4398
4399         Reviewed by Žan Doberšek.
4400
4401         * wpe/jhbuild.modules:
4402         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
<