Enable client certificate authentication unit test
[WebKit-https.git] / Tools / ChangeLog
1 2019-07-12  Alex Christensen  <achristensen@webkit.org>
2
3         Enable client certificate authentication unit test
4         https://bugs.webkit.org/show_bug.cgi?id=199735
5
6         Reviewed by Chris Dumez.
7
8         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
9         (TEST):
10         I originally wrote this in https://bugs.webkit.org/show_bug.cgi?id=197800 but it was disabled because it crashed.
11         I found what was crashing.  I was reading out of bounds on my vector of 2 strings :(
12
13 2019-07-12  Alex Christensen  <achristensen@webkit.org>
14
15         Begin unifying TestWebKitAPI build
16         https://bugs.webkit.org/show_bug.cgi?id=199728
17
18         Reviewed by Keith Miller.
19
20         * TestWebKitAPI/Configurations/Base.xcconfig:
21         * TestWebKitAPI/Scripts/generate-unified-sources.sh: Added.
22         * TestWebKitAPI/Sources.txt: Added.
23         * TestWebKitAPI/SourcesCocoa.txt: Added.
24         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
25
26 2019-07-12  Zhifei Fang  <zhifei_fang@apple.com>
27
28         run-javascriptcore-tests won't report test results for testmasm, testair, testb3, testdfg and test api
29         https://bugs.webkit.org/show_bug.cgi?id=199489
30         <rdar://problem/47891081>
31
32         Reviewed by Aakash Jain.
33
34         * BuildSlaveSupport/build.webkit.org-config/steps.py:
35         (RunJavaScriptCoreTests.countFailures):
36         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
37         * Scripts/run-javascriptcore-tests:
38         (runTest):
39         (reportTestFailures):
40         (runJSCStressTests):
41
42 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
43
44         [ews-build] Make layout-tests' full_results.json accessible in Buildbot
45         https://bugs.webkit.org/show_bug.cgi?id=199743
46
47         Reviewed by Jonathan Bedard.
48
49         * BuildSlaveSupport/ews-build/steps.py:
50         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
51
52 2019-07-11  Aakash Jain  <aakash_jain@apple.com>
53
54         Unreviewed follow-up fix to r247364.
55         [ews-build] Add build step to clean up .git/index.lock file
56         https://bugs.webkit.org/show_bug.cgi?id=199722
57
58         * BuildSlaveSupport/ews-build/steps.py:
59         (CheckOutSource): CheckOutSource should not haltOnFailure since CleanUpGitIndexLock step needs
60         to be run after this step.
61
62 2019-07-11  Yusuke Suzuki  <ysuzuki@apple.com>
63
64         Flaky API Test TestWTF.bmalloc.ScavengedMemoryShouldBeReused
65         https://bugs.webkit.org/show_bug.cgi?id=199524
66         <rdar://problem/52783816>
67
68         Reviewed by Saam Barati.
69
70         This test is white-box one and it has strong assumption how IsoHeap allocates pages.
71         But this test has several problems.
72
73         1. IsoPage::numObjects is not the exact number of how many we allocate objects. This
74            number is calculated by pageSize / sizeof(T), and this does not account the header
75            size of IsoPage. So, # of objects per IsoPage is less than numObjects. Since sizeof(double)
76            is very small, we can have many objects in one IsoPage. As a result, we need a large
77            bitmap in IsoPage. This reduces # of objects in IsoPage largely. So, `ptrs.size()` becomes
78            less than numObjects.
79
80         2. We now have lower tier of allocation in IsoHeap. It means that we allocate 8 objects in
81            shared page (page is shared, but memory is pinned for a specific type) before using IsoHeap's
82            page. This also makes the intention of this test wrong.
83
84         Due to (1), we access OoB of ptrs vector, passing a garbage to IsoHeap::deallocate, and crashing.
85
86         We make this test robust while we still keep this test white-box one to test the critical feature
87         of IsoHeap. We first exhaust lower tier of IsoHeap, and after that, start testing the memory. We
88         allocate many pointers, deallocate them, allocate one pointer while keeping pointers in the lower
89         tier live, and check whether the deallocated memory is reused.
90
91         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
92         (TEST):
93
94 2019-07-11  Pablo Saavedra  <psaavedra@igalia.com>
95
96         [WPE][GTK] Build failure with ENABLE_ACCESSIBILITY=OFF
97         https://bugs.webkit.org/show_bug.cgi?id=199625
98
99         Added ENABLE(ACCESSIBILITY) and replaced HAVE(ACCESSIBILITY)
100         with ENABLE(ACCESSIBILITY) in the code.
101
102         Additionally, the TestRunner code generator now honors the
103         Conditional IDL format.
104
105         Reviewed by Konstantin Tokarev.
106
107         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
108         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
109         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
110         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
111         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
112         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl:
113         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl:
114         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
115         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
116         (_generateImplementationFile):
117
118 2019-07-11  Aakash Jain  <aakash_jain@apple.com>
119
120         [ews-build] Add build step to clean up .git/index.lock file
121         https://bugs.webkit.org/show_bug.cgi?id=199722
122
123         Reviewed by Jonathan Bedard.
124
125         * BuildSlaveSupport/ews-build/steps.py:
126         (CheckOutSource.getResultSummary): Run CleanUpGitIndexLock step when CheckOutSource fails.
127         (CleanUpGitIndexLock.__init__): Configure timeout and logEnviron.
128         (CleanUpGitIndexLock.evaluateCommand): Always RETRY the build after this step is run.
129         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
130
131 2019-07-11  Jonathan Bedard  <jbedard@apple.com>
132
133         [iOS 13] Enable WebKit build
134         https://bugs.webkit.org/show_bug.cgi?id=199481
135         <rdar://problem/52619048>
136
137         Reviewed by Tim Horton.
138
139         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Add iOS framework stubs.
140
141 2019-07-11  Ryan Haddad  <ryanhaddad@apple.com>
142
143         Add test expectations and baselines for iOS 13
144         https://bugs.webkit.org/show_bug.cgi?id=199329
145
146         Reviewed by Jonathan Bedard.
147
148         * Scripts/webkitpy/port/ios.py:
149         (IOSPort): Increment current version to 13.
150         * Scripts/webkitpy/port/ios_device_unittest.py: Update unit tests.
151         (IOSDeviceTest.test_layout_test_searchpath_with_apple_additions):
152         (IOSDeviceTest.test_layout_test_searchpath_without_apple_additions):
153         (IOSDeviceTest.test_layout_searchpath_wih_device_type):
154         * Scripts/webkitpy/port/ios_simulator_unittest.py: Ditto.
155         (IOSSimulatorTest.make_port):
156         (IOSSimulatorTest.test_layout_test_searchpath_with_apple_additions):
157         (IOSSimulatorTest.test_layout_test_searchpath_without_apple_additions):
158         (IOSSimulatorTest.test_layout_searchpath_wih_device_type):
159         * Scripts/webkitpy/port/ios_testcase.py: Ditto.
160         (IOSTest.make_port):
161
162 2019-07-11  Joanmarie Diggs  <jdiggs@igalia.com>
163
164         AX: Implement support for ARIA roles insertion, deletion, subscript, superscript, and time
165         https://bugs.webkit.org/show_bug.cgi?id=199692
166
167         Reviewed by Chris Fleizach.
168
169         Add support for output of AXDeletion and AXInsertion roles for tests.
170         Update GTK and WPE jhbuild modules to use version of ATK and AT-SPI2
171         which include ROLE_CONTENT_DELETION and ROLE_CONTENT_INSERTION.
172
173         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
174         * gtk/jhbuild.modules:
175         * wpe/jhbuild.modules:
176
177 2019-07-11  Adrian Perez de Castro  <aperez@igalia.com>
178
179         [ews-build] Remove workers {ltilve,tanty}-gtk-wk2-ews from configuration
180         https://bugs.webkit.org/show_bug.cgi?id=199707
181
182         Reviewed by Aakash Jain.
183
184         * BuildSlaveSupport/ews-build/config.json: Remove old unused workers.
185
186 2019-07-10  Simon Fraser  <simon.fraser@apple.com>
187
188         [iOS WK2] With modal overlay and body overflow:hidden, can't access all the content
189         https://bugs.webkit.org/show_bug.cgi?id=199693
190         rdar://problem/51930364
191
192         Reviewed by Tim Horton.
193         
194         New API tests that test scrollability with various combinations of content, insets,
195         input accessory bars etc.
196
197         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
198         * TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm: Added.
199         (TestWebKitAPI::webViewWithAutofocusedInput):
200         (TestWebKitAPI::TEST):
201
202 2019-07-10  Tim Horton  <timothy_horton@apple.com>
203
204         Long pressing on attachments will crash the WebContent process
205         https://bugs.webkit.org/show_bug.cgi?id=199696
206         <rdar://problem/52920241>
207
208         Reviewed by Dean Jackson.
209
210         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
211         (TestWebKitAPI::TEST):
212         Add a test that previously crashed.
213
214 2019-07-10  Dean Jackson  <dino@apple.com>
215
216         Support MacCatalyst in run-webkit-app
217         https://bugs.webkit.org/show_bug.cgi?id=199690
218
219         Reviewed by Tim Horton.
220
221         Add a --maccatalyst option to run-webkit-app that
222         can launch MacCatalyst applications with a built WebKit.
223
224         * Scripts/webkitdirs.pm:
225         (argumentsForConfiguration):
226         (determineXcodeSDK):
227         (xcodeSDKPlatformName):
228         (determineConfigurationProductDir):
229         (determinePortName):
230         (isCatalystWebKit):
231         (isAppleCocoaWebKit):
232         (willUseCatalystSDK):
233
234 2019-07-10  Ryan Haddad  <ryanhaddad@apple.com>
235
236         [MacOS] Filter VPA info logged to stdout
237         https://bugs.webkit.org/show_bug.cgi?id=199673
238
239         Reviewed by Eric Carlson.
240
241         * Scripts/webkitpy/port/mac.py:
242         (MacPort.logging_patterns_to_strip):
243
244 2019-07-10  Ryan Haddad  <ryanhaddad@apple.com>
245
246         Unreviewed, rolling out r247286.
247
248         Caused TestWTF.WTF.StringOperators to fail on debug bots
249
250         Reverted changeset:
251
252         "Add StringBuilder member function which allows makeString()
253         style variadic argument construction"
254         https://bugs.webkit.org/show_bug.cgi?id=198997
255         https://trac.webkit.org/changeset/247286
256
257 2019-07-10  Aakash Jain  <aakash_jain@apple.com>
258
259         [ews-build] Explicitly use perl or python while invoking scripts
260         https://bugs.webkit.org/show_bug.cgi?id=199669
261
262         Reviewed by Jonathan Bedard.
263
264         * BuildSlaveSupport/ews-build/steps.py: Explicitly added perl or python while invoking scripts.
265         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
266
267 2019-07-10  Guillaume Emont  <guijemont@igalia.com>
268
269         Run tests on mips EWS
270         https://bugs.webkit.org/show_bug.cgi?id=196854
271
272         Reviewed by Carlos Garcia Campos.
273
274         * Scripts/webkitpy/common/config/ews.json:
275
276 2019-07-09  Michael Catanzaro  <mcatanzaro@igalia.com>
277
278         [WPE][GTK] GUniqueOutPtr::release should return a raw pointer
279         https://bugs.webkit.org/show_bug.cgi?id=199579
280
281         Reviewed by Carlos Garcia Campos.
282
283         * TestWebKitAPI/Tests/WTF/glib/GUniquePtr.cpp:
284         (TestWebKitAPI::TEST):
285
286 2019-07-09  Chris Dumez  <cdumez@apple.com>
287
288         Fix integer type encoding / decoding in WKRemoteObjectCoder
289         https://bugs.webkit.org/show_bug.cgi?id=199643
290         <rdar://problem/52732342>
291
292         Reviewed by Anders Carlsson.
293
294         Update API test coverage.
295
296         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
297         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
298         (TEST):
299         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
300         (-[RemoteObjectRegistryPlugIn takeUnsignedLongLong:completionHandler:]):
301         (-[RemoteObjectRegistryPlugIn takeLongLong:completionHandler:]):
302         (-[RemoteObjectRegistryPlugIn takeUnsignedLong:completionHandler:]):
303         (-[RemoteObjectRegistryPlugIn takeLong:completionHandler:]):
304
305 2019-07-09  Sam Weinig  <weinig@apple.com>
306
307         Add StringBuilder member function which allows makeString() style variadic argument construction
308         https://bugs.webkit.org/show_bug.cgi?id=198997
309
310         Reviewed by Darin Adler.
311
312         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
313         Add basic test showing that StringBuilder::flexibleAppend can be used to 
314         append one or more string adaptable types. 
315
316 2019-07-09  Sihui Liu  <sihui_liu@apple.com>
317
318         Only allow fetching and removing session credentials from WebsiteDataStore
319         https://bugs.webkit.org/show_bug.cgi?id=199385
320         <rdar://problem/52622080>
321
322         Reviewed by Alex Christensen.
323
324         removeDataOfTypes will no longer remove persistent credentials. We should clear persistent credentials using
325         the new SPI after each test that creates persistent credentials, otherwise the later tests may use credentials
326         left by previous tests and didReceiveAuthenticationChallenge will not be invoked.
327
328         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
329         (TEST):
330         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
331         (TestWebKitAPI::TEST):
332
333 2019-07-09  Alex Christensen  <achristensen@webkit.org>
334
335         When parsing an IPv4 address, wait until after deciding it is indeed an IPv4 address before reporting syntax violations
336         https://bugs.webkit.org/show_bug.cgi?id=199628
337
338         Reviewed by Brady Eidson.
339
340         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
341         (TestWebKitAPI::TEST_F):
342
343 2019-07-09  Alex Christensen  <achristensen@webkit.org>
344
345         Remove invalid assertion in URLParser::domainToASCII
346         https://bugs.webkit.org/show_bug.cgi?id=199624
347
348         Reviewed by Brady Eidson.
349
350         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
351         (TestWebKitAPI::TEST_F):
352
353 2019-07-09  Alex Christensen  <achristensen@webkit.org>
354
355         URLParser should reserialize IPv6 addresses that end with a colon
356         https://bugs.webkit.org/show_bug.cgi?id=199627
357
358         Reviewed by Brady Eidson.
359
360         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
361         (TestWebKitAPI::TEST_F):
362
363 2019-07-08  Aakash Jain  <aakash_jain@apple.com>
364
365         [ews-build] Do not run unix commands for windows in PrintConfiguration
366         https://bugs.webkit.org/show_bug.cgi?id=199605
367
368         Reviewed by Jonathan Bedard.
369
370         * BuildSlaveSupport/ews-build/steps.py:
371
372 2019-07-08  Fujii Hironori  <Hironori.Fujii@sony.com>
373
374         JSTestGlobalObject.cpp of bindings-generation-tests is failing for Windows Python
375         https://bugs.webkit.org/show_bug.cgi?id=199487
376
377         Reviewed by Ross Kirsling.
378
379         In Windows Python, preprocessor.pm is using cl.exe. cl.exe was
380         failing to open testglobalscope_constructors_file which was
381         created by using tempfile.mkstemp() because it keeps the file
382         open. Use tempfile.mkdtemp() to create temporary files in the
383         temporary directory instead of tempfile.mkstemp().
384
385         * Scripts/webkitpy/bindings/main.py:
386         (BindingsTests.run_tests):
387         (BindingsTests.main):
388         (BindingsTests.close_and_remove): Deleted.
389
390 2019-07-08  Aakash Jain  <aakash_jain@apple.com>
391
392         [ews-build] Add KillOldProcesses step before running API or Layout tests
393         https://bugs.webkit.org/show_bug.cgi?id=199592
394
395         Reviewed by Jonathan Bedard.
396
397         * BuildSlaveSupport/ews-build/factories.py:
398
399 2019-07-08  Jonathan Bedard  <jbedard@apple.com>
400
401         test-webkitpy: Explicitly use Python 2.7 lldb library
402         https://bugs.webkit.org/show_bug.cgi?id=199578
403         <rdar://problem/51853557>
404
405         Reviewed by Aakash Jain.
406
407         * Scripts/webkitpy/common/system/systemhost.py:
408         (SystemHost.path_to_lldb_python_directory): Explicitly use Python 2.7 lldb libary.
409         * Scripts/webkitpy/test/main.py:
410         (_supports_building_and_running_lldb_tests): Run lldb tests on Catalina again.
411
412 2019-07-08  Ryan Haddad  <ryanhaddad@apple.com>
413
414         Add test expectations and baselines for Catalina
415         https://bugs.webkit.org/show_bug.cgi?id=199328
416
417         Reviewed by Jonathan Bedard.
418
419         * Scripts/webkitpy/port/mac.py:
420         (MacPort): Increment current version to 10.15 so that baseline search paths are correctly constructed for High Sierra.
421
422 2019-07-08  Christopher Reid  <chris.reid@sony.com>
423
424         Implement MappedFileData for Windows
425         https://bugs.webkit.org/show_bug.cgi?id=198269
426
427         Reviewed by Darin Adler.
428
429         * TestWebKitAPI/PlatformWin.cmake:
430
431 2019-07-08  Charlie Turner  <cturner@igalia.com>
432
433         REGRESSION(r243197): [GStreamer] Web process hangs when scrolling twitter timeline which contains HLS videos
434         https://bugs.webkit.org/show_bug.cgi?id=197558
435
436         Reviewed by Xabier Rodriguez-Calvar.
437
438         On shutdown we can easily deadlock the web process if we don't
439         ensure all network operations are completed before comitting state
440         changes. In HLS, make sure the network operations are cancelled,
441         and also prevent hlsdemux's retry logic from scuppering our
442         efforts.
443
444         * gstreamer/jhbuild.modules: Include the patch.
445         * gstreamer/patches/gst-plugins-bad-do-not-retry-downloads-during-shutdown.patch: Added.
446
447 2019-07-08  Antoine Quint  <graouts@apple.com>
448
449         [Pointer Events] Enable only on the most recent version of the supported iOS family
450         https://bugs.webkit.org/show_bug.cgi?id=199562
451         <rdar://problem/52766511>
452
453         Reviewed by Dean Jackson.
454
455         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
456
457 2019-07-06  Simon Fraser  <simon.fraser@apple.com>
458
459         Long hang when loading a cnn.com page on iOS
460         https://bugs.webkit.org/show_bug.cgi?id=199556
461
462         Reviewed by Zalan Bujtas.
463
464         Add code to load a page by default in MobileMiniBrowser so it's easy to hack it
465         to load a test page of your choice.
466
467         * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.m:
468         (-[WebViewController viewDidLoad]):
469
470 2019-07-05  Ryosuke Niwa  <rniwa@webkit.org>
471
472         [iOS] Crash in WebKit::WebPage::positionInformation via Range::startPosition
473         https://bugs.webkit.org/show_bug.cgi?id=199503
474
475         Reviewed by Wenson Hsieh.
476
477         Added UIScriptController.ensurePositionInformationIsUpToDateAt using the existing WKWebView SPI:
478         _requestActivatedElementAtPosition
479
480         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
481         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
482         * DumpRenderTree/mac/UIScriptControllerMac.mm:
483         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
484         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
485         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
486         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
487         * TestRunnerShared/UIScriptContext/UIScriptController.h:
488         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
489         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
490         * WebKitTestRunner/ios/UIScriptControllerMac.mm:
491         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
492
493 2019-07-05  Ryan Haddad  <ryanhaddad@apple.com>
494
495         Unreviewed, rolling out r247115.
496
497         Breaks lldbWebKitTester (and by extension, test-webkitpy)
498
499         Reverted changeset:
500
501         "[WHLSL] Standard library is too big to directly include in
502         WebCore"
503         https://bugs.webkit.org/show_bug.cgi?id=198186
504         https://trac.webkit.org/changeset/247115
505
506 2019-07-05  Ryan Haddad  <ryanhaddad@apple.com>
507
508         Unreviewed, rolling out r247123.
509
510         Caused TestWebKitAPI.Challenge.BasicProposedCredential to
511         fail.
512
513         Reverted changeset:
514
515         "Only allow fetching and removing session credentials from
516         WebsiteDataStore"
517         https://bugs.webkit.org/show_bug.cgi?id=199385
518         https://trac.webkit.org/changeset/247123
519
520 2019-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
521
522         Touching media controls sometimes shows software keyboard
523         https://bugs.webkit.org/show_bug.cgi?id=199490
524         <rdar://problem/52076270>
525
526         Reviewed by Eric Carlson.
527
528         Adds plumbing for a new testing hook to check whether or not there is an active input session. See other
529         ChangeLog entries for more detail.
530
531         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
532         (WTR::UIScriptController::hasInputSession const):
533         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
534         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
535         (WTR::UIScriptController::hasInputSession const):
536         * TestRunnerShared/UIScriptContext/UIScriptController.h:
537         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
538         (WTR::UIScriptController::hasInputSession const):
539
540 2019-07-04  Aakash Jain  <aakash_jain@apple.com>
541
542         [ews-build] Remove GTK and WPE queue from old EWS and dashboard
543         https://bugs.webkit.org/show_bug.cgi?id=199458
544
545         Reviewed by Michael Catanzaro.
546
547         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
548         * QueueStatusServer/config/queues.py:
549
550 2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
551
552         [GTK] Fix browserperfdash script after r239522
553         https://bugs.webkit.org/show_bug.cgi?id=199496
554
555         Reviewed by Michael Catanzaro.
556
557         * Scripts/webkitpy/browserperfdash/browserperfdash_runner.py:
558         (BrowserPerfDashRunner.run): Pass None for the new required BenchmarkRunner constructor.
559
560 2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
561
562         [webkitpy] test-webkitpy is broken on Linux since r246662
563         https://bugs.webkit.org/show_bug.cgi?id=199493
564
565         Reviewed by Michael Catanzaro.
566
567         * Scripts/webkitpy/test/main.py:
568         (_supports_building_and_running_lldb_tests): Add a check for None before calling startswith().
569
570 2019-07-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
571
572         [GTK][WPE] Not longer needed to build woff2 on the JHBuild
573         https://bugs.webkit.org/show_bug.cgi?id=199406
574
575         Reviewed by Michael Catanzaro.
576
577         Install the Woff2 libraries and headers from the system package
578         and stop building them on the JHBuild.
579
580         * gtk/install-dependencies:
581         * gtk/jhbuild.modules:
582         * wpe/install-dependencies:
583         * wpe/jhbuild.modules:
584
585 2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
586
587         [GTK][WPE][CMake] The CMake cache should be clean when the JHBuild is rebuilt
588         https://bugs.webkit.org/show_bug.cgi?id=199449
589
590         Reviewed by Michael Catanzaro.
591
592         * Scripts/webkitdirs.pm:
593         (shouldRemoveCMakeCache): Clean the CMake cache if we detect that the JHBuild has been rebuilt.
594
595 2019-07-01  Philippe Normand  <pnormand@igalia.com>
596
597         Unreviewed, GTK a11y tests fix after r247071
598
599         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
600         (WTR::AccessibilityUIElement::popupValue const):
601
602 2019-07-03  Aakash Jain  <aakash_jain@apple.com>
603
604         [ews-build] Enable WPE and GTK queues on new EWS
605         https://bugs.webkit.org/show_bug.cgi?id=199234
606
607         Reviewed by Jonathan Bedard.
608
609         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for GTK and WPE builders.
610         * BuildSlaveSupport/ews-build/factories.py: Added required build steps for GTKFactory and WPEFactory.
611         * BuildSlaveSupport/ews-build/steps.py:
612         (CompileWebKit.evaluateCommand): Added InstallGtkDependencies/InstallWpeDependencies step before Compiling WebKit without patch.
613         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
614         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
615         (StatusBubble): Enable gtk and wpe status-bubbles.
616
617 2019-07-03  Sihui Liu  <sihui_liu@apple.com>
618
619         Only allow fetching and removing session credentials from WebsiteDataStore
620         https://bugs.webkit.org/show_bug.cgi?id=199385
621
622         Reviewed by Alex Christensen.
623
624         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
625         (TestWebKitAPI::TEST):
626
627 2019-07-03  Tim Horton  <timothy_horton@apple.com>
628
629         UI process exception when dragging an <attachment> with no content type
630         https://bugs.webkit.org/show_bug.cgi?id=199480
631         <rdar://problem/44351353>
632
633         Reviewed by Wenson Hsieh.
634
635         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
636         (TestWebKitAPI::TEST):
637         Add a test; before the change, it crashes.
638
639 2019-07-03  Jonathan Bedard  <jbedard@apple.com>
640
641         [Catalina] Enable WebKit build
642         https://bugs.webkit.org/show_bug.cgi?id=199209
643
644         Reviewed by Darin Adler.
645
646         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Add Mac framework stubs.
647
648 2019-07-03  Sam Weinig  <weinig@apple.com>
649
650         Adopt simple structured bindings in more places
651         https://bugs.webkit.org/show_bug.cgi?id=199247
652
653         Reviewed by Alex Christensen.
654
655         Replaces simple uses of std::tie() with structured bindings. Does not touch
656         uses of std::tie() that are not initial declarations, use std::ignore or in
657         case where the binding is captured by a lambda, as structured bindings don't
658         work for those cases yet.
659
660         * TestWebKitAPI/ios/PreferredContentMode.mm:
661         (TestWebKitAPI::TEST):
662
663 2019-07-03  Aakash Jain  <aakash_jain@apple.com>
664
665         Unreviewed follow-up fix to r247049, default the platform to '*' when platform property is not set.
666
667         * BuildSlaveSupport/ews-build/steps.py:
668         (PrintConfiguration.run):
669
670 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
671
672         [ews-build] Add build steps to Install Wpe and Gtk dependencies
673         https://bugs.webkit.org/show_bug.cgi?id=199408
674
675         Reviewed by Michael Catanzaro.
676
677         * BuildSlaveSupport/ews-build/steps.py:
678         (InstallGtkDependencies): Build step to install dependencies for GTK. Set haltOnFailure=False so that in case of failure, build isn't
679         marked as failed (which would indicated patch failed EWS), instead subsequent steps would be run and the build would be marked as RETRY.
680         (InstallWpeDependencies): Ditto for WPE.
681         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
682
683 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
684
685         [ews-build] Allow skipping uploading built product for few builders
686         https://bugs.webkit.org/show_bug.cgi?id=199422
687
688         Reviewed by Michael Catanzaro.
689
690         * BuildSlaveSupport/ews-build/steps.py:
691         (CompileWebKit.__init__): Added optional skipUpload parameter.
692         (CompileWebKit.evaluateCommand): Allow to skip upload if there are no triggers and skipUpload is True.
693
694 2019-07-02  Tim Horton  <timothy_horton@apple.com>
695
696         REGRESSION (r243240): Unable to swipe back in Safari
697         https://bugs.webkit.org/show_bug.cgi?id=199394
698         <rdar://problem/51137447>
699
700         Reviewed by Wenson Hsieh.
701
702         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
703         Make sure that we actually end up with swipe gesture recognizers installed
704         after process swap and crash.
705
706 2019-07-02  Andres Gonzalez  <andresg_22@apple.com>
707
708         Enhance support of aria-haspopup per ARIA 1.1 specification.
709         https://bugs.webkit.org/show_bug.cgi?id=199216
710         <rdar://problem/46221342>
711
712         Reviewed by Chris Fleizach.
713
714         * DumpRenderTree/AccessibilityUIElement.cpp:
715         (getPopupValueCallback):
716         (AccessibilityUIElement::getJSClass):
717         * DumpRenderTree/AccessibilityUIElement.h:
718         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
719         (AccessibilityUIElement::popupValue const):
720         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
721         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
722         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
723         (WTR::AccessibilityUIElement::popupValue const):
724         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
725         (WTR::AccessibilityUIElement::popupValue const):
726
727 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
728
729         [ews-build] Do not print worker environment variables in each build step [part 2]
730         https://bugs.webkit.org/show_bug.cgi?id=199405
731
732         Reviewed by Jonathan Bedard.
733
734         * BuildSlaveSupport/ews-build/steps.py:
735         (CheckOutSpecificRevision.__init__): Disabled logging of environment variables.
736         (CleanWorkingDirectory.__init__): Ditto.
737         (RunBindingsTests.__init__): Ditto.
738         (RunWebKitPerlTests.__init__): Ditto.
739         (RunWebKitPyTests.__init__): Ditto.
740         (CompileWebKit.__init__): Ditto.
741         (ArchiveTestResults.__init__): Ditto.
742         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
743
744 2019-07-02  Jer Noble  <jer.noble@apple.com>
745
746         Pipe suport for 'cenc' init data type into CDMFairPlayStreaming
747         https://bugs.webkit.org/show_bug.cgi?id=199381
748         <rdar://problem/52483103>
749
750         Reviewed by Eric Carlson.
751
752         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
753
754 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
755
756         [ews-build] Update bot configuration for WPE and GTK
757         https://bugs.webkit.org/show_bug.cgi?id=199238
758
759         Reviewed by Michael Catanzaro.
760
761         * BuildSlaveSupport/ews-build/config.json:
762
763 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
764
765         [ews-build] Make PrintConfiguration platform aware
766         https://bugs.webkit.org/show_bug.cgi?id=196657
767
768         Reviewed by Lucas Forschler.
769
770         * BuildSlaveSupport/ews-build/steps.py:
771         (PrintConfiguration): Specified platform-specific command lists.
772         (PrintConfiguration.run): Override run method and specify platform specific commands.
773         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
774
775 2019-07-01  Justin Michaud  <justin_michaud@apple.com>
776
777         [Wasm-References] Disable references by default
778         https://bugs.webkit.org/show_bug.cgi?id=199390
779
780         Reviewed by Saam Barati.
781
782         * Scripts/run-jsc-stress-tests:
783
784 2019-07-01  Joonghun Park  <pjh0718@gmail.com>
785
786         Unreviewed. Revert r246965 to fix build break
787         since r247019 reverted its related changes.
788
789         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
790         (WTR::AccessibilityUIElement::popupValue const): Deleted.
791
792 2019-07-01  Alex Christensen  <achristensen@webkit.org>
793
794         Add new decidePolicyForNavigationAction SPI with preferences and userInfo
795         https://bugs.webkit.org/show_bug.cgi?id=199371
796         <rdar://problem/52352905>
797
798         Reviewed by Tim Horton.
799
800         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
801         (-[NavigationActionSPIDelegate webView:didFinishNavigation:]):
802         (-[NavigationActionSPIDelegate _webView:decidePolicyForNavigationAction:preferences:userInfo:decisionHandler:]):
803         (-[NavigationActionSPIDelegate spiCalled]):
804         (TEST):
805
806 2019-07-01  Alex Christensen  <achristensen@webkit.org>
807
808         Deprecate _webView:showCustomSheetForElement: after transition to UIContextMenuInteraction
809         https://bugs.webkit.org/show_bug.cgi?id=199296
810         <rdar://problem/51041960>
811
812         Reviewed by Darin Adler.
813
814         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
815         (-[DragAndDropSimulator _webView:showCustomSheetForElement:]):
816
817 2019-07-01  Truitt Savell  <tsavell@apple.com>
818
819         Unreviewed, rolling out r246958.
820
821         Broke inspector/dom/getAccessibilityPropertiesForNode.html
822
823         Reverted changeset:
824
825         "Enhance support of aria-haspopup per ARIA 1.1 specification."
826         https://bugs.webkit.org/show_bug.cgi?id=199216
827         https://trac.webkit.org/changeset/246958
828
829 2019-07-01  Philippe Normand  <pnormand@igalia.com>
830
831         Unreviewed, GTK a11y tests fix after r246958
832
833         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
834         (WTR::AccessibilityUIElement::popupValue const):
835
836 2019-06-30  Andres Gonzalez  <andresg_22@apple.com>
837
838         Enhance support of aria-haspopup per ARIA 1.1 specification.
839         https://bugs.webkit.org/show_bug.cgi?id=199216
840         <rdar://problem/46221342>
841
842         Reviewed by Chris Fleizach.
843
844         * DumpRenderTree/AccessibilityUIElement.cpp:
845         (getPopupValueCallback):
846         (AccessibilityUIElement::getJSClass):
847         * DumpRenderTree/AccessibilityUIElement.h:
848         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
849         (AccessibilityUIElement::popupValue const):
850         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
851         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
852         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
853         (WTR::AccessibilityUIElement::popupValue const):
854         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
855         (WTR::AccessibilityUIElement::popupValue const):
856
857 2019-06-28  Robin Morisset  <rmorisset@apple.com>
858
859         Adding myself as a reviewer to contributors.json.
860
861         Unreviewed.
862
863         * Scripts/webkitpy/common/config/contributors.json:
864
865 2019-06-28  Jer Noble  <jer.noble@apple.com>
866
867         Add new -[WKWebView _closeAllMediaPresentations] SPI
868         https://bugs.webkit.org/show_bug.cgi?id=199294
869         <rdar://problem/51965958>
870
871         Reviewed by Alex Christensen.
872
873         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
874         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm: Added.
875         (TEST):
876
877 2019-06-28  Sihui Liu  <sihui_liu@apple.com>
878
879         Add a regression test for change r246901
880         https://bugs.webkit.org/show_bug.cgi?id=199290
881
882         Reviewed by Geoffrey Garen.
883
884         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
885         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
886         (-[LocalStorageNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
887         (TEST):
888         * TestWebKitAPI/Tests/WebKitCocoa/localstorage-open-window-private.html: Added.
889
890 2019-06-28  Konstantin Tokarev  <annulen@yandex.ru>
891
892         Remove traces of ENABLE_ICONDATABASE remaining after its removal in 219733
893         https://bugs.webkit.org/show_bug.cgi?id=199317
894
895         Reviewed by Michael Catanzaro.
896
897         While IconDatabase and all code using it was removed,
898         ENABLE_ICONDATABASE still exists as build option and C++ macro.
899
900         * Scripts/webkitperl/FeatureList.pm:
901         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
902         * gtk/manifest.txt.in: Remove reference to unused urlIcon.png file.
903         * wpe/manifest.txt.in: Remove reference to unused urlIcon.png file.
904
905 2019-06-28  Wenson Hsieh  <wenson_hsieh@apple.com>
906
907         -[WKContentView _selectionClipRects] returns a bogus value in -reloadInputViews when focusing an element
908         https://bugs.webkit.org/show_bug.cgi?id=199310
909         <rdar://problem/52292137>
910
911         Reviewed by Megan Gardner.
912
913         Add a new API test to verify that _selectionClipRects returns the correct value when invoked under the scope of
914         _elementDidFocus.
915
916         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
917         (TestWebKitAPI::TEST):
918         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
919         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
920         (-[TestInputDelegate setDidStartInputSessionHandler:]):
921         (-[TestInputDelegate didStartInputSessionHandler]):
922
923         Add plumbing for a handler block in TestInputDelegate.
924
925         (-[TestInputDelegate setWillStartInputSessionHandler:]):
926
927         Drive-by style fixes to add a space between id and < for Objective-C protocols.
928
929         (-[TestInputDelegate willStartInputSessionHandler]):
930         (-[TestInputDelegate _webView:willStartInputSession:]):
931         (-[TestInputDelegate _webView:didStartInputSession:]):
932         * TestWebKitAPI/cocoa/TestWKWebView.h:
933         * TestWebKitAPI/ios/UIKitSPI.h:
934
935         Add a declaration for _selectionClipRects.
936
937 2019-06-27  Zalan Bujtas  <zalan@apple.com>
938
939         REGRESSION(r244633): e-mail with "height: 100%" causes unstable layout.
940         https://bugs.webkit.org/show_bug.cgi?id=199303
941         <rdar://problem/51340927>
942
943         Reviewed by Tim Horton.
944
945         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
946         (TEST):
947
948 2019-06-27  Beth Dakin  <bdakin@apple.com>
949
950         Upstream use of MACCATALYST
951         https://bugs.webkit.org/show_bug.cgi?id=199245
952         rdar://problem/51687723
953
954         Reviewed by Tim Horton.
955
956         * ContentExtensionTester/Configurations/SDKVariant.xcconfig:
957         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig:
958         * ImageDiff/cg/Configurations/SDKVariant.xcconfig:
959         * MiniBrowser/Configurations/SDKVariant.xcconfig:
960         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig:
961         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
962         (JavaScriptCoreGenerator):
963         (WebCoreGenerator):
964         (WebKitGenerator):
965         * TestWebKitAPI/Configurations/Base.xcconfig:
966         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
967         * TestWebKitAPI/Configurations/SDKVariant.xcconfig:
968         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
969         * WebEditingTester/Configurations/SDKVariant.xcconfig:
970         * WebKitLauncher/Configurations/SDKVariant.xcconfig:
971         * WebKitTestRunner/Configurations/SDKVariant.xcconfig:
972         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig:
973
974 2019-06-27  Saam Barati  <sbarati@apple.com>
975
976         Make WEBGPU enabled only on Mojave and later.
977
978         Rubber-stamped by Myles C. Maxfield.
979
980         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
981
982 2019-06-27  Aakash Jain  <aakash_jain@apple.com>
983
984         [ews-build] Do not print worker environment variables in each build step
985         https://bugs.webkit.org/show_bug.cgi?id=197319
986
987         Reviewed by Lucas Forschler.
988
989         * BuildSlaveSupport/ews-build/steps.py:
990         (CheckOutSource.__init__): Disabled logging of environment variables.
991         (ApplyPatch.__init__): Ditto.
992         (KillOldProcesses.__init__): Ditto.
993         (ArchiveBuiltProduct.__init__): Ditto.
994         (DownloadBuiltProduct.__init__): Ditto.
995         (ExtractBuiltProduct.__init__): Ditto.
996         (RunAPITests.__init__): Ditto.
997         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
998
999 2019-06-26  Jiewen Tan  <jiewen_tan@apple.com>
1000
1001         SubFrameSOAuthorizationSession should preserve the referrer header when fall back to web path
1002         https://bugs.webkit.org/show_bug.cgi?id=199232
1003         <rdar://problem/51718328>
1004
1005         Reviewed by Youenn Fablet.
1006
1007         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
1008         (TestWebKitAPI::TEST):
1009         Add a test that utilizes TCPServer as local files always omit referrer.
1010
1011 2019-06-26  Aakash Jain  <aakash_jain@apple.com>
1012
1013         [ews-build] Add configuration and architecture for WPE and GTK builders
1014         https://bugs.webkit.org/show_bug.cgi?id=199249
1015
1016         Reviewed by Jonathan Bedard.
1017
1018         * BuildSlaveSupport/ews-build/config.json:
1019
1020 2019-06-26  Aakash Jain  <aakash_jain@apple.com>
1021
1022         [ews-build] Add check for duplicate workers in config.json
1023         https://bugs.webkit.org/show_bug.cgi?id=199240
1024
1025         Reviewed by Jonathan Bedard.
1026
1027         * BuildSlaveSupport/ews-build/loadConfig.py:
1028         (checkWorkersAndBuildersForConsistency._find_worker_with_name): Check for duplicate worker entry.
1029         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1030         (TestcheckWorkersAndBuildersForConsistency.test_duplicate_worker): Added unit-test.
1031
1032 2019-06-26  Ross Kirsling  <ross.kirsling@sony.com>
1033
1034         [Win] MiniBrowser should make better font choices
1035         https://bugs.webkit.org/show_bug.cgi?id=199244
1036
1037         Reviewed by Brent Fulgham.
1038
1039         * MiniBrowser/win/MainWindow.cpp:
1040         (MainWindow::updateDeviceScaleFactor):
1041         * MiniBrowser/win/MiniBrowserLib.rc:
1042
1043 2019-06-26  Alex Christensen  <achristensen@webkit.org>
1044
1045         testRunner.setAlwaysAcceptCookies should wait for cookie accept policy to be set
1046         https://bugs.webkit.org/show_bug.cgi?id=199230
1047         <rdar://51757107>
1048
1049         Reviewed by Andy Estes.
1050
1051         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp:
1052         (TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy):
1053         (TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy):
1054         * WebKitTestRunner/TestController.cpp:
1055         (WTR::TestController::generatePageConfiguration):
1056         (WTR::TestController::createWebViewWithOptions):
1057         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundleWithListener):
1058         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundleWithListener):
1059         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1060         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle): Deleted.
1061         * WebKitTestRunner/TestController.h:
1062         * WebKitTestRunner/TestInvocation.cpp:
1063         (WTR::TestInvocation::invoke):
1064         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1065
1066 2019-06-26  Ross Kirsling  <ross.kirsling@sony.com>
1067
1068         [Win][MiniBrowser] Remove obsolete code after r246814.
1069         https://bugs.webkit.org/show_bug.cgi?id=199233
1070
1071         Reviewed by Fujii Hironori.
1072
1073         * MiniBrowser/win/MiniBrowserWebHost.cpp:
1074         (MiniBrowserWebHost::didFinishLoadForFrame):
1075         (SimpleEventListener::SimpleEventListener): Deleted.
1076         (SimpleEventListener::handleEvent): Deleted.
1077
1078 2019-06-25  Jiewen Tan  <jiewen_tan@apple.com>
1079
1080         Implement a new SPI to inform clients about AppSSO
1081         https://bugs.webkit.org/show_bug.cgi?id=199085
1082         <rdar://problem/50028246>
1083
1084         Reviewed by Geoffrey Garen.
1085
1086         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
1087         (-[TestSOAuthorizationBasicDelegate webView:didFinishNavigation:]):
1088         (-[TestSOAuthorizationNavigationDelegate init]):
1089         (-[TestSOAuthorizationNavigationDelegate _webView:decidePolicyForSOAuthorizationLoadWithCurrentPolicy:forExtension:completionHandler:]):
1090         (TestWebKitAPI::TEST):
1091
1092 2019-06-25  Aakash Jain  <aakash_jain@apple.com>
1093
1094         [ews-build] Retry Layout test in case of failures
1095         https://bugs.webkit.org/show_bug.cgi?id=199194
1096
1097         Reviewed by Jonathan Bedard.
1098
1099         * BuildSlaveSupport/ews-build/steps.py:
1100         (RunWebKitTests.evaluateCommand): Check if tests failed and retry them if required.
1101         (ReRunWebKitTests): Build step to re-run layout tests.
1102         (ReRunWebKitTests.evaluateCommand): Check if tests failed and retry on clean build if required.
1103         (RunWebKitTestsWithoutPatch): Build step to run tests without patch.
1104         (RunWebKitTestsWithoutPatch.evaluateCommand):
1105
1106 2019-06-25  Aakash Jain  <aakash_jain@apple.com>
1107
1108         [ews-build] Combine various patchFailed*Tests properties
1109         https://bugs.webkit.org/show_bug.cgi?id=199193
1110
1111         Reviewed by Jonathan Bedard.
1112
1113         * BuildSlaveSupport/ews-build/steps.py: Renamed patchFailedJSCTests and patchFailedAPITests to patchFailedTests. This property 
1114         can also be used for layout-tests later on.
1115         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
1116
1117 2019-06-25  Ross Kirsling  <ross.kirsling@sony.com>
1118
1119         [Win] MiniBrowser should default to webkit.org
1120         https://bugs.webkit.org/show_bug.cgi?id=199201
1121
1122         Reviewed by Don Olmstead.
1123
1124         * MiniBrowser/win/BrowserWindow.h:
1125         * MiniBrowser/win/MiniBrowserReplace.h:
1126         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1127         (WebKitBrowserWindow::loadHTMLString): Deleted.
1128         * MiniBrowser/win/WebKitBrowserWindow.h:
1129         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
1130         (WebKitLegacyBrowserWindow::loadHTMLString): Deleted.
1131         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
1132         * MiniBrowser/win/WinMain.cpp:
1133         (wWinMain):
1134
1135 2019-06-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1136
1137         [iOS] Occasional crash under -[UIPreviewTarget initWithContainer:center:transform:] when generating a drag preview
1138         https://bugs.webkit.org/show_bug.cgi?id=199192
1139         <rdar://problem/51554509>
1140
1141         Reviewed by Tim Horton.
1142
1143         Tweak the drag and drop simulator to ask for drag cancellation previews, and use this to write a couple tests to
1144         verify that we gracefully handle web process termination and web view unparenting mid-drag.
1145
1146         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1147         (TestWebKitAPI::TEST):
1148         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1149         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1150         (-[DragAndDropSimulator _resetSimulatedState]):
1151         (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
1152         (-[DragAndDropSimulator _advanceProgress]):
1153         (-[DragAndDropSimulator liftPreviews]):
1154         (-[DragAndDropSimulator cancellationPreviews]):
1155         (-[DragAndDropSimulator setSessionWillBeginBlock:]):
1156         (-[DragAndDropSimulator sessionWillBeginBlock]):
1157         (-[DragAndDropSimulator _webView:dataInteraction:sessionWillBegin:]):
1158
1159 2019-06-25  Aakash Jain  <aakash_jain@apple.com>
1160
1161         [ews-build] UploadTestResults and ExtractTestResults clobber results in case of multiple layout test runs in a build
1162         https://bugs.webkit.org/show_bug.cgi?id=199178
1163
1164         Reviewed by Jonathan Bedard.
1165
1166         * BuildSlaveSupport/ews-build/steps.py:
1167         (UploadTestResults.__init__): Add an optional identifier and append the identifier to the file name.
1168         (ExtractTestResults.__init__): Ditto.
1169         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit tests.
1170
1171 2019-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
1172
1173         Add user agent quirk for bankofamerica.com
1174         https://bugs.webkit.org/show_bug.cgi?id=199154
1175
1176         Reviewed by Carlos Garcia Campos.
1177
1178         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1179         (TestWebKitAPI::TEST):
1180
1181 2019-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
1182
1183         Fully rename WebKitGTK+ -> WebKitGTK everywhere
1184         https://bugs.webkit.org/show_bug.cgi?id=199159
1185
1186         Reviewed by Carlos Garcia Campos.
1187
1188         * BuildSlaveSupport/gtk/README:
1189         * MiniBrowser/gtk/BrowserWindow.c:
1190         * MiniBrowser/gtk/main.c:
1191         (aboutURISchemeRequestCallback):
1192         * Scripts/webkitpy/common/config/contributionareas.py:
1193         * Scripts/webkitpy/common/config/contributors.json:
1194         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py:
1195         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1196         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1197         (testWebViewResources):
1198         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1199         (testWebViewMouseTarget):
1200         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1201         (testWebExtensionGetTitle):
1202         (testDocumentLoadedSignal):
1203         (testWebExtensionFormControlsAssociated):
1204         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1205         (testWebKitSettingsUserAgent):
1206         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
1207         (testWebViewRunJavaScript):
1208         * TestWebKitAPI/Tests/WebKitGtk/InspectorTestServer.cpp:
1209         (main):
1210         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
1211         (prepareContextMenuTestView):
1212         (testContextMenuPopulateMenu):
1213         (testContextMenuCustomMenu):
1214         (testContextMenuDisableMenu):
1215         (testContextMenuSubMenu):
1216         (testContextMenuDismissed):
1217         (testContextMenuWebExtensionMenu):
1218         (testContextMenuWebExtensionNode):
1219         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
1220         (testInspectorDefault):
1221         (testInspectorManualAttachDetach):
1222         (testInspectorCustomContainerDestroyed):
1223         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
1224         (testWebViewPrint):
1225         (testPrintOperationPrint):
1226         (testPrintOperationErrors):
1227         * gtk/install-dependencies:
1228         * gtk/jhbuild.modules:
1229         * gtkdoc/generate-gtkdoc:
1230         * wpe/install-dependencies:
1231
1232 2019-06-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1233
1234         contributors.json not canonicalized since r243297
1235         https://bugs.webkit.org/show_bug.cgi?id=199161
1236
1237         Reviewed by Alexey Proskuryakov.
1238
1239         Canonicalize it using 'validate-committer-lists --canonicalize'
1240
1241         * Scripts/webkitpy/common/config/contributors.json:
1242
1243 2019-06-24  Jonathan Bedard  <jbedard@apple.com>
1244
1245         webkitpy: Build style should be lower-case
1246         https://bugs.webkit.org/show_bug.cgi?id=199158
1247
1248         Reviewed by Aakash Jain.
1249
1250         * Scripts/webkitpy/test/main.py:
1251         (Tester._run_tests): Make all styles lower-case.
1252
1253 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
1254
1255         [ews-build] Remove iOS queue from old EWS and dashboard
1256         https://bugs.webkit.org/show_bug.cgi?id=199150
1257
1258         Reviewed by Jonathan Bedard.
1259
1260         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1261         * QueueStatusServer/config/queues.py:
1262
1263 2019-06-21  Ryan Haddad  <ryanhaddad@apple.com>
1264
1265         API Test [Mojave+ WK2 Debug ] TestWebKitAPI.WKAttachmentTestsMac.InsertDroppedFilePromisesAsAttachments is a flaky crash
1266         https://bugs.webkit.org/show_bug.cgi?id=198795
1267
1268         Unreviewed test gardening.
1269
1270         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1271         (TestWebKitAPI::TEST): Disable flaky test.
1272
1273 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
1274
1275         [ews-build] Enable iOS-12-Build queue on new EWS
1276         https://bugs.webkit.org/show_bug.cgi?id=199149
1277
1278         Reviewed by Jonathan Bedard.
1279
1280         * BuildSlaveSupport/ews-build/config.json: Enable iOS-12-Build-EWS trigger. Also temporarily share ews152 and ews154 with
1281         this queue.
1282         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1283         (StatusBubble): Enable ios status-bubble. Also display the ios bubble first (left). Going forward
1284         will keep the builders to the left and testers to the right.
1285
1286 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
1287
1288         [ews-build] Upload test results after running layout-tests
1289         https://bugs.webkit.org/show_bug.cgi?id=199120
1290
1291         Reviewed by Jonathan Bedard.
1292
1293         * BuildSlaveSupport/ews-build/steps.py:
1294         (RunWebKitTests.evaluateCommand):
1295         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1296
1297 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
1298
1299         [ews-build] EWS should provide option to download layout test results zip file
1300         https://bugs.webkit.org/show_bug.cgi?id=199121
1301
1302         Reviewed by Jonathan Bedard.
1303
1304         * BuildSlaveSupport/ews-build/steps.py:
1305         (ExtractTestResults.resultsDownloadURL): Method to return layout test result zip file url. 
1306         (ExtractTestResults.addCustomURLs): Add url to download layout test results zip file.
1307
1308 2019-06-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1309
1310         Add user agent quirk for Google Drive
1311         https://bugs.webkit.org/show_bug.cgi?id=199153
1312
1313         Reviewed by Carlos Garcia Campos.
1314
1315         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1316         (TestWebKitAPI::TEST):
1317
1318 2019-06-22  Zalan Bujtas  <zalan@apple.com>
1319
1320         [LFC] Expand tests coverage (328 new tests -> 2652).
1321
1322         * LayoutReloaded/misc/LFC-passing-tests.txt:
1323
1324 2019-06-22  Andres Gonzalez  <andresg_22@apple.com>
1325
1326         Accessibility objects contained in links should honor the aria-haspopup attribute in the ancestor link.
1327         https://bugs.webkit.org/show_bug.cgi?id=199107
1328         <rdar://problem/43663611>
1329
1330         Reviewed by Chris Fleizach.
1331
1332         iOS implementation for AccessibilityUIElement::hasPopup.
1333         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1334         (WTR::AccessibilityUIElement::hasPopup const):
1335
1336 2019-06-22  Konstantin Tokarev  <annulen@yandex.ru>
1337
1338         Unreviewed, add myself to CMake watchlist
1339
1340         * Scripts/webkitpy/common/config/watchlist:
1341
1342 2019-06-21  Sihui Liu  <sihui_liu@apple.com>
1343
1344         openDatabase should return an empty object when WebSQL is disabled
1345         https://bugs.webkit.org/show_bug.cgi?id=198805
1346
1347         Reviewed by Geoffrey Garen.
1348
1349         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1350         * TestWebKitAPI/Tests/WebKitCocoa/WebSQLBasics.mm: Added.
1351         (-[WebSQLBasicsMessageHandler userContentController:didReceiveScriptMessage:]):
1352         (TEST):
1353         * TestWebKitAPI/Tests/WebKitCocoa/opendatabase-always-exists.html: Added.
1354
1355 2019-06-21  Jiewen Tan  <jiewen_tan@apple.com>
1356
1357         WebPageProxy::loadData should accept ShouldOpenExternalURLsPolicy
1358         https://bugs.webkit.org/show_bug.cgi?id=199114
1359         <rdar://problem/51671674>
1360
1361         Reviewed by Youenn Fablet.
1362
1363         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
1364         (-[TestSOAuthorizationNavigationDelegate init]):
1365         (-[TestSOAuthorizationNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1366         (configureSOAuthorizationWebView):
1367         (TestWebKitAPI::TEST):
1368
1369 2019-06-21  Youenn Fablet  <youenn@apple.com>
1370
1371         WebPageProxy should use the right path for sandbox extension
1372         https://bugs.webkit.org/show_bug.cgi?id=198902
1373         <rdar://problem/50772810>
1374
1375         Reviewed by Geoffrey Garen.
1376
1377         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
1378         (TEST):
1379         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1380
1381 2019-06-21  Michael Catanzaro  <mcatanzaro@igalia.com>
1382
1383         [WPE][GTK] Bump minimum versions of GLib, GTK, libsoup, ATK, GStreamer, and Cairo
1384         https://bugs.webkit.org/show_bug.cgi?id=199094
1385
1386         Reviewed by Carlos Garcia Campos.
1387
1388         * MiniBrowser/gtk/BrowserTab.c:
1389         (runColorChooserCallback):
1390         (browserTabConstructed):
1391         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1392         (testWebViewSyncRequestOnMaxConns):
1393         (beforeAll):
1394         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
1395         (testWebSocketTLSErrors):
1396         (beforeAll):
1397         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
1398         (WebKitTestServer::~WebKitTestServer):
1399         (WebKitTestServer::getWebSocketURIForPath const):
1400         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1401         (WTR::AccessibilityUIElement::rowHeaders const):
1402         (WTR::AccessibilityUIElement::columnHeaders const):
1403         (WTR::AccessibilityUIElement::isAttributeSettable):
1404         (WTR::AccessibilityUIElement::x):
1405         (WTR::AccessibilityUIElement::y):
1406         (WTR::AccessibilityUIElement::width):
1407         (WTR::AccessibilityUIElement::height):
1408         (WTR::AccessibilityUIElement::clickPointX):
1409         (WTR::AccessibilityUIElement::clickPointY):
1410         (WTR::AccessibilityUIElement::intValue const):
1411         (WTR::AccessibilityUIElement::minValue):
1412         (WTR::AccessibilityUIElement::maxValue):
1413         (WTR::stringAtOffset):
1414
1415 2019-06-20  Dean Johnson  <dean_johnson@apple.com>
1416
1417         test-webkitpy is broken on macOS Catalina
1418         https://bugs.webkit.org/show_bug.cgi?id=199078
1419
1420         Reviewed by Jonathan Bedard.
1421
1422         * Scripts/webkitpy/test/main.py: Check if lldb tests are supported before adding them
1423         to the runner.
1424         (main): 
1425         (_supports_building_and_running_lldb_tests): Check if you are running macOS Catalina.
1426
1427 2019-06-20  Dean Johnson  <dean_johnson@apple.com>
1428
1429         Change status to "committer" in contributors.json
1430
1431         Unreviewed.
1432
1433         * Scripts/webkitpy/common/config/contributors.json:
1434
1435 2019-06-20  Alex Christensen  <achristensen@webkit.org>
1436
1437         Add unit test for UIContextMenuConfiguration API
1438         https://bugs.webkit.org/show_bug.cgi?id=199043
1439
1440         Reviewed by Wenson Hsieh.
1441
1442         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1443         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm: Added.
1444         (-[TestContextMenuUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
1445         (-[TestContextMenuUIDelegate webView:contextMenuWillPresentForElement:]):
1446         (-[TestContextMenuUIDelegate webView:contextMenuForElement:willCommitWithAnimator:]):
1447         (-[TestContextMenuUIDelegate webView:contextMenuDidEndForElement:]):
1448         (TEST):
1449         * TestWebKitAPI/cocoa/TestContextMenuDriver.h: Added.
1450         * TestWebKitAPI/cocoa/TestContextMenuDriver.mm: Added.
1451         (-[TestContextMenuDriver delegate]):
1452         (-[TestContextMenuDriver setDelegate:]):
1453         (-[TestContextMenuDriver view]):
1454         (-[TestContextMenuDriver setView:]):
1455         (-[TestContextMenuDriver allowableMovement]):
1456         (-[TestContextMenuDriver setAllowableMovement:]):
1457         (-[TestContextMenuDriver primaryGestureRecognizer]):
1458         (-[TestContextMenuDriver setPrimaryGestureRecognizer:]):
1459         (-[TestContextMenuDriver touchDuration]):
1460         (-[TestContextMenuDriver setTouchDuration:]):
1461         (-[TestContextMenuDriver locationInCoordinateSpace:]):
1462         (-[TestContextMenuDriver cancelInteraction]):
1463         (-[TestContextMenuDriver begin:]):
1464         (-[TestContextMenuDriver clickDown]):
1465         (-[TestContextMenuDriver clickUp]):
1466         (-[TestContextMenuDriver end]):
1467         * TestWebKitAPI/ios/UIKitSPI.h:
1468
1469 2019-06-20  Aakash Jain  <aakash_jain@apple.com>
1470
1471         [ews-app] Status bubble should not turn orange when any build step is skipped
1472         https://bugs.webkit.org/show_bug.cgi?id=199079
1473
1474         Reviewed by Jonathan Bedard.
1475
1476         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1477
1478 2019-06-20  Alex Christensen  <achristensen@webkit.org>
1479
1480         Fix an internal engineering build after r246605
1481        ​https://bugs.webkit.org/show_bug.cgi?id=197800
1482
1483         * TestWebKitAPI/TCPServer.cpp:
1484
1485 2019-06-20  Aakash Jain  <aakash_jain@apple.com>
1486
1487         [ews-build] Triggered builds should use same revision as parent build
1488         https://bugs.webkit.org/show_bug.cgi?id=198289
1489
1490         Reviewed by Jonathan Bedard.
1491
1492         * BuildSlaveSupport/ews-build/steps.py:
1493         (CheckOutSpecificRevision): Build step to checkout specific revision.
1494         (CheckOutSpecificRevision.doStepIf): Run this step only if ews_revision property is set.
1495         (CheckOutSpecificRevision.hideStepIf): Hide this step when it is skipped.
1496         (CheckOutSpecificRevision.start): Run appropriate git command.
1497         (Trigger.propertiesToPassToTriggers): Pass ews_revision property to triggered builds, so that triggered
1498         builds use same revision as parent build.
1499         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1500         * BuildSlaveSupport/ews-build/factories.py:
1501         (Factory.__init__): Added CheckOutSpecificRevision step.
1502
1503 2019-06-20  Aakash Jain  <aakash_jain@apple.com>
1504
1505         [ews-build] Add unit tests for AnalyzeCompileWebKitResults
1506         https://bugs.webkit.org/show_bug.cgi?id=199073
1507
1508         Reviewed by Jonathan Bedard.
1509
1510         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests for AnalyzeCompileWebKitResults.
1511
1512 2019-06-20  Alexander Mikhaylenko  <exalm7659@gmail.com>
1513
1514         [GTK] Enable navigation swipe layout tests
1515         https://bugs.webkit.org/show_bug.cgi?id=198995
1516
1517         Reviewed by Michael Catanzaro.
1518
1519         Add a way for tests to enable and then control swipe gesture on GTK.
1520
1521         * TestRunnerShared/UIScriptContext/UIScriptController.cpp: Hide
1522         empty implementations of beginBackSwipe() and completeBackSwipe() for GTK.
1523         * WebKitTestRunner/PlatformGTK.cmake:
1524         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1525         (WTR::PlatformWebView::setNavigationGesturesEnabled): Implemented.
1526         * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp: Added.
1527         (WTR::UIScriptController::beginBackSwipe):
1528         (WTR::UIScriptController::completeBackSwipe):
1529
1530 2019-06-20  Alexander Mikhaylenko  <exalm7659@gmail.com>
1531
1532         [GTK] HTTP layout tests don't run in flatpak
1533         https://bugs.webkit.org/show_bug.cgi?id=199067
1534
1535         Reviewed by Michael Catanzaro.
1536
1537         Stop bind mounting /app/lib/perl to /etc/perl because Perl doesn't actually
1538         check that path. Instead, add /app/lib/perl to Apache config directly.
1539
1540         /usr/manifest.json file is not guaranteed to exist in sandbox, check for
1541         /.flatpak-info instead.
1542
1543         * Scripts/webkitpy/port/base.py:
1544         (Port._is_flatpak):
1545         (Port._in_flatpak_sandbox):
1546         * flatpak/flatpakutils.py:
1547         (WebkitFlatpak.run_in_sandbox):
1548         (is_sandboxed):
1549
1550 2019-06-18  Darin Adler  <darin@apple.com>
1551
1552         Tidy up the remaining bits of the AtomicString to AtomString rename
1553         https://bugs.webkit.org/show_bug.cgi?id=198990
1554
1555         Reviewed by Michael Catanzaro.
1556
1557         * Scripts/do-webcore-rename: Removed already-done renames.
1558         * TestWebKitAPI/Tests/WTF/StringImpl.cpp: Rename one use of "atomic".
1559
1560 2019-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1561
1562         [GTK] Remove support for GTK2 plugins
1563         https://bugs.webkit.org/show_bug.cgi?id=199065
1564
1565         Reviewed by Sergio Villar Senin.
1566
1567         * EWSTools/ubuntu-ews-packages:
1568         * TestWebKitAPI/PlatformGTK.cmake:
1569         * WebKitTestRunner/PlatformGTK.cmake:
1570         * flatpak/org.webkit.GTK.yaml:
1571         * gtk/install-dependencies:
1572
1573 2019-06-19  Yusuke Suzuki  <ysuzuki@apple.com>
1574
1575         [bmalloc] IsoHeap's initialization is racy with IsoHeap::isInitialized
1576         https://bugs.webkit.org/show_bug.cgi?id=199053
1577
1578         Reviewed by Saam Barati.
1579
1580         Added a test stressing IsoHeap with multiple threads.
1581
1582         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
1583         (assertHasObjects):
1584         (assertHasOnlyObjects):
1585         (assertClean):
1586         (TEST):
1587
1588 2019-06-19  Zalan Bujtas  <zalan@apple.com>
1589
1590         [LFC] Expand tests coverage (1126 new tests -> 2324).
1591
1592         * LayoutReloaded/misc/LFC-passing-tests.txt:
1593
1594 2019-06-19  Fujii Hironori  <Hironori.Fujii@sony.com>
1595
1596         Add WTF::crossThreadCopy(T&&) to utilize String::isolatedCopy() &&
1597         https://bugs.webkit.org/show_bug.cgi?id=198957
1598
1599         Reviewed by Alex Christensen.
1600
1601         * TestWebKitAPI/CMakeLists.txt:
1602         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1603         * TestWebKitAPI/Tests/WTF/CrossThreadCopier.cpp: Added.
1604
1605 2019-06-19  Keith Rollin  <krollin@apple.com>
1606
1607         Relocate some test tools in non-mac builds
1608         https://bugs.webkit.org/show_bug.cgi?id=198984
1609         <rdar://problem/51873261>
1610
1611         Reviewed by Andy Estes.
1612
1613         The tools DumpRenderTree, WebKitTestRunner, LayoutTestHelper, and
1614         TestNetscapePlugin get created in
1615         WebKit.framework/Versions/A/Resources on non-mac builds. This is
1616         incorrect, as those bundles are shallow bundles that don't use the
1617         Versions hierarchy. Instead, store these files directly in
1618         WebKit.framework.
1619
1620         Note that getting rid of just the "Versions/A" path components and
1621         putting the files in WebKit.framework/Resources doesn't work as
1622         `codesign` treats the result as an invalid layout.
1623
1624         The work in this patch involves changing the definition of the custom
1625         build variable WEBKIT_FRAMEWORK_RESOURCES_PATH. The standard build
1626         variable INSTALL_PATH is defined in terms of this variable. In order
1627         to increase visiblity into this relationship, move both of these
1628         variables into .xcconfig files if they weren't already. This
1629         refactoring was done in a way to be the least disruptive and most
1630         compatible with the previous definitions, even at the cost of being
1631         repetitive.
1632
1633         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1634         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1635         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1636         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
1637         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
1638         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
1639
1640 2019-06-19  Aakash Jain  <aakash_jain@apple.com>
1641
1642         [ews-build] Patch link should open the pretty patch
1643         https://bugs.webkit.org/show_bug.cgi?id=199031
1644
1645         Reviewed by Jonathan Bedard.
1646
1647         * BuildSlaveSupport/ews-build/steps.py:
1648         (ConfigureBuild.getPatchURL): Use the prettypatch url for patch.
1649
1650 2019-06-19  Aakash Jain  <aakash_jain@apple.com>
1651
1652         [ews-build] Add step to analyze Compile WebKit failures
1653         https://bugs.webkit.org/show_bug.cgi?id=199025
1654
1655         Reviewed by Jonathan Bedard.
1656
1657         * BuildSlaveSupport/ews-build/steps.py:
1658         (CompileWebKit.evaluateCommand): Add AnalyzeCompileWebKitResults step.
1659         (CompileWebKitToT): set haltOnFailure to False since we need to run AnalyzeCompileWebKitResults step.
1660         (AnalyzeCompileWebKitResults): Class to analyze compile webkit steps results.
1661         (AnalyzeCompileWebKitResults.start): If ToT fails to build, retry the build, else marked the build as failed. Note that
1662         this step is run only when compile-webkit failed.
1663
1664 2019-06-19  Aakash Jain  <aakash_jain@apple.com>
1665
1666         [ews-build] Send email notifications for failures
1667         https://bugs.webkit.org/show_bug.cgi?id=198919
1668
1669         Reviewed by Jonathan Bedard.
1670
1671         * BuildSlaveSupport/ews-build/master.cfg:
1672
1673 2019-06-19  Alex Christensen  <achristensen@webkit.org>
1674
1675         Add a unit test for client certificate authentication
1676         https://bugs.webkit.org/show_bug.cgi?id=197800
1677
1678         Reviewed by Youenn Fablet.
1679
1680         Make better abstractions for reading and writing from/to TCPServer.
1681         Add a unit test that causes a client certificate authentication challenge to happen.
1682
1683         * TestWebKitAPI/TCPServer.cpp:
1684         (TestWebKitAPI::TCPServer::TCPServer):
1685         (TestWebKitAPI::TCPServer::read):
1686         (TestWebKitAPI::TCPServer::write):
1687         (TestWebKitAPI::TCPServer::respondWithChallengeThenOK):
1688         (TestWebKitAPI::TCPServer::respondWithOK):
1689         * TestWebKitAPI/TCPServer.h:
1690         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1691         (credentialWithIdentity):
1692         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1693         (TEST):
1694         (-[ClientCertificateDelegate webView:didFinishNavigation:]):
1695         (-[ClientCertificateDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1696         (-[ClientCertificateDelegate challengeCount]):
1697         (TestWebKitAPI::TEST):
1698         (respondWithChallengeThenOK): Deleted.
1699         (credentialWithIdentityAndKeychainPath): Deleted.
1700         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
1701         (TEST):
1702         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
1703         (TestWebKitAPI::TEST):
1704         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1705         (TEST):
1706         (readRequest): Deleted.
1707         (writeResponse): Deleted.
1708         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1709         (TestWebKitAPI::TEST):
1710         (TestWebKitAPI::respondWithChallengeThenOK): Deleted.
1711
1712 2019-06-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1713
1714         Unreviewed, fix build warnings in TestWebKitAPIInjectedBundle
1715
1716         System headers are being included without SYSTEM again here.
1717
1718         * TestWebKitAPI/PlatformGTK.cmake:
1719
1720 2019-06-18  Yusuke Suzuki  <ysuzuki@apple.com>
1721
1722         [JSC] JSLock should be WebThread aware
1723         https://bugs.webkit.org/show_bug.cgi?id=198911
1724
1725         Reviewed by Geoffrey Garen.
1726
1727         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1728         * TestWebKitAPI/Tests/WebKitLegacy/ios/JSLockTakesWebThreadLock.mm: Added.
1729         (TestWebKitAPI::TEST):
1730
1731 2019-06-18  Keith Miller  <keith_miller@apple.com>
1732
1733         webkit-patch should allow for a bugzilla url not just bugzilla id
1734         https://bugs.webkit.org/show_bug.cgi?id=198972
1735
1736         Reviewed by Dewei Zhu.
1737
1738         When prompting for a bugzilla id or a new title we should also
1739         allow for a bugzilla url.
1740
1741         * Scripts/webkitpy/tool/steps/promptforbugortitle.py:
1742         (PromptForBugOrTitle.run):
1743
1744 2019-06-18  David Quesada  <david_quesada@apple.com>
1745
1746         REGRESSION: _WKDownload.OriginatingWebView and _WKDownload.CrashAfterDownloadDidFinishWhenDownloadProxyHoldsTheLastRefOnWebProcessPool failing
1747         https://bugs.webkit.org/show_bug.cgi?id=198954
1748         rdar://problem/51711556
1749
1750         Reviewed by Alex Christensen.
1751
1752         For these tests, kill the web process after the download starts. This makes the deallocation
1753         of the download-originating web views, which these tests depend on, more reliable.
1754
1755         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1756         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
1757         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
1758
1759 2019-06-18  Dan Bernstein  <mitz@apple.com>
1760
1761         Revert workaround for bug 198904 from run-webkit-archive
1762         https://bugs.webkit.org/show_bug.cgi?id=198931
1763
1764         Reviewed by Alexey Proskuryakov.
1765
1766         Reverted r245965, now that the load commands in the XPC service binaries make them correctly
1767         pick up the built frameworks.
1768
1769         * WebKitArchiveSupport/run-webkit-archive:
1770         (set_dyld_framework_path):
1771
1772 2019-06-17  Sihui Liu  <sihui_liu@apple.com>
1773
1774         -[WKWebsiteDataStore removeDataOfTypes:modifiedSince:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
1775         https://bugs.webkit.org/show_bug.cgi?id=198854
1776         <rdar://problem/51386058>
1777
1778         Reviewed by Geoffrey Garen.
1779
1780         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1781         (TestWebKitAPI::TEST):
1782
1783 2019-06-17  Adrian Perez de Castro  <aperez@igalia.com>
1784
1785         [Flatpak][JHBuild] Update build environments to use WPEBackend-fdo 1.3.1
1786         https://bugs.webkit.org/show_bug.cgi?id=198831
1787
1788         Reviewed by Žan Doberšek.
1789
1790         * flatpak/org.webkit.WPEModules.yaml: Bump versions of libwpe and WPEBackend-fdo to 1.3.1
1791         * wpe/jhbuild.modules: Ditto.
1792         * wpe/patches/wpebackend-fdo-Handle-the-case-of-new-target-created-for-the-same-v.patch: Removed.
1793         * wpe/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Removed.
1794
1795 2019-06-17  Jiewen Tan  <jiewen_tan@apple.com>
1796
1797         Move SOAuthorization from WebKitAdditions to WebKit
1798         https://bugs.webkit.org/show_bug.cgi?id=198874
1799         <rdar://problem/47573431>
1800
1801         Reviewed by Brent Fulgham.
1802
1803         This patch moves all SOAuthorization tests from WebKitAdditions to WebKit.
1804
1805         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1806         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1807         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm: Added.
1808         (-[TestSOAuthorizationNavigationDelegate init]):
1809         (-[TestSOAuthorizationNavigationDelegate webView:didFinishNavigation:]):
1810         (-[TestSOAuthorizationNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1811         (-[TestSOAuthorizationNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1812         (-[TestSOAuthorizationViewController viewDidAppear]):
1813         (-[TestSOAuthorizationViewController viewDidDisappear]):
1814         (overrideCanPerformAuthorizationWithURL):
1815         (overrideSetDelegate):
1816         (overrideBeginAuthorizationWithURL):
1817         (overrideCancelAuthorization):
1818         (overrideAddObserverForName):
1819         (overrideIsURLFromAppleOwnedDomain):
1820         (resetState):
1821         (configureSOAuthorizationWebView):
1822         (generateHtml):
1823         (checkAuthorizationOptions):
1824         (TestWebKitAPI::TEST):
1825
1826 2019-06-17  Brent Fulgham  <bfulgham@apple.com>
1827
1828         Ensure ITP state is relayed to Network Process on restart
1829         https://bugs.webkit.org/show_bug.cgi?id=198797
1830         <rdar://problem/51646944>
1831
1832         Reviewed by Youenn Fablet.
1833
1834         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1835         (cleanupITPDatabase): Added.
1836         (TEST:EnableDisableITP): Update to use cleanup method.
1837         (TEST:NetworkProcessRestart): Added.
1838
1839 2019-06-17  Aakash Jain  <aakash_jain@apple.com>
1840
1841         New EWS can't process patches larger than 640kb
1842         https://bugs.webkit.org/show_bug.cgi?id=198851
1843
1844         Reviewed by Jonathan Bedard.
1845
1846         * BuildSlaveSupport/ews-build/master.cfg: Increase the patch size limit to 100 MB.
1847
1848 2019-06-17  Jonathan Bedard  <jbedard@apple.com>
1849
1850         webkitpy: Add macOS Catalina, iOS 13
1851         https://bugs.webkit.org/show_bug.cgi?id=198492
1852
1853         Reviewed by Alexey Proskuryakov.
1854
1855         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Catalina.png: Added.
1856         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Catalina@2x.png: Added.
1857         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13.png: Added.
1858         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13@2x.png: Added.
1859         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13Simulator.png: Added.
1860         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13Simulator@2x.png: Added.
1861         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1862         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1863         * BuildSlaveSupport/ews-build/steps.py:
1864         * Scripts/webkitpy/common/version_name_map.py:
1865         * Scripts/webkitpy/common/version_name_map_unittest.py:
1866         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1867         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1868
1869 2019-06-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1870
1871         Unreviewed. [GTK] Bump WPEBackend-fdo requirement to 1.3.1
1872
1873         * gtk/jhbuild.modules:
1874         * gtk/patches/wpebackend-fdo-Handle-the-case-of-new-target-created-for-the-same-v.patch: Removed.
1875         * gtk/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Removed.
1876
1877 2019-06-16  Zalan Bujtas  <zalan@apple.com>
1878
1879         [LFC] Expand tests coverage (325 new tests -> 1198).
1880
1881         * LayoutReloaded/misc/LFC-passing-tests.txt:
1882
1883 2019-06-16  Darin Adler  <darin@apple.com>
1884
1885         Rename AtomicString to AtomString
1886         https://bugs.webkit.org/show_bug.cgi?id=195276
1887
1888         Reviewed by Michael Catanzaro.
1889
1890         * many files: Let do-webcore-rename do the renaming.
1891
1892         * Scripts/do-webcore-rename: Updated with a list of all the identifiers
1893         that mention "atomic string" and changed them to instead say "atom string".
1894
1895 2019-06-16  Zalan Bujtas  <zalan@apple.com>
1896
1897         [LFC] Unreviewed test gardening.
1898
1899         Unsupported alignments.
1900
1901         fast/inline/absolute-positioned-inline-in-centred-block.html -align: center
1902         fast/borders/empty-outline-border-assert.html -vertical-align: super
1903         css2.1/20110323/vertical-align-boxes-001.htm - vertical-align: middle
1904
1905         * LayoutReloaded/misc/LFC-passing-tests.txt:
1906
1907 2019-06-15  Youenn Fablet  <youenn@apple.com>
1908
1909         WPT test importer WTR option reader should not throw if the file is not proper UTF-8
1910         https://bugs.webkit.org/show_bug.cgi?id=198780
1911
1912         Reviewed by Jonathan Bedard.
1913
1914         * Scripts/webkitpy/w3c/test_importer.py:
1915         (TestImporter._webkit_test_runner_options):
1916         In case the test file cannot be read as text, consider that there is no WTR option.
1917
1918 2019-06-14  Youenn Fablet  <youenn@apple.com>
1919
1920         WebResourceLoadStatisticsStore should not use its network session if invalidated
1921         https://bugs.webkit.org/show_bug.cgi?id=198814
1922
1923         Reviewed by Geoffrey Garen.
1924
1925         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1926         (TEST):
1927
1928 2019-06-14  Youenn Fablet  <youenn@apple.com>
1929
1930         import-w3c-tests should respect WEBKIT_OUTPUTDIR
1931         https://bugs.webkit.org/show_bug.cgi?id=198682
1932         <rdar://problem/51536931>
1933
1934         Reviewed by Jonathan Bedard.
1935
1936         Check for WEBKIT_OUTPUTDIR environment variable to compute the w3c-tests folder.
1937         Made some refactoring to also teach WPTPaths users about WEBKIT_OUTPUTDIR.
1938
1939         * Scripts/webkitpy/common/webkit_finder.py:
1940         (WebKitFinder.path_from_webkit_outputdir):
1941         * Scripts/webkitpy/w3c/common.py:
1942         (WPTPaths):
1943         (WPTPaths.checkout_directory):
1944         (WPTPaths.wpt_checkout_path):
1945         * Scripts/webkitpy/w3c/test_importer.py:
1946         (TestImporter.__init__):
1947         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1948         (test_checkout_directory):
1949
1950 2019-06-13  Antoine Quint  <graouts@apple.com>
1951
1952         REGRESSION (r246103) [ Mojave+ WK1 ] Layout Test scrollbars/scrollbar-iframe-click-does-not-blur-content.html is timing out
1953         https://bugs.webkit.org/show_bug.cgi?id=198800
1954         <rdar://problem/51679634>
1955
1956         Reviewed by Tim Horton.
1957
1958         We didn't detect an NSScroller in a sub-frame due to WebHTMLView's implementation of -[NSView hitTest:]. We now use a private method
1959         which lets us use the default implementation and correctly returns an NSScroller in a sub-frame.
1960
1961         * DumpRenderTree/mac/EventSendingController.mm:
1962         (eventPressedMouseButtonsSwizzlerForViewAndEvent):
1963         (-[EventSendingController mouseDown:withModifiers:]):
1964         (-[EventSendingController mouseUp:withModifiers:]):
1965         (-[EventSendingController mouseMoveToX:Y:]):
1966
1967 2019-06-13  Fujii Hironori  <Hironori.Fujii@sony.com>
1968
1969         [WinCairo][WebKitTestRunner] pixel image dump outputs blank images
1970         https://bugs.webkit.org/show_bug.cgi?id=198820
1971
1972         Reviewed by Ross Kirsling.
1973
1974         WebView window paints nothing because it is moved out of the
1975         screen. Send WM_PRINT with memory DC instead of WM_PAINT as well
1976         as DumpRenderTree does.
1977
1978         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1979         (WTR::PlatformWebView::windowSnapshotImage): Send WM_PRINT instead of BitBlt.
1980
1981 2019-06-13  Tim Horton  <timothy_horton@apple.com>
1982
1983         Make it possible for validate-committer-lists to dump a mailmap file
1984         https://bugs.webkit.org/show_bug.cgi?id=198517
1985
1986         Reviewed by Simon Fraser.
1987
1988         Mailmaps wildly improve the output of various Git tools, including
1989         `git shortlog -sne`, mapping committers to our canonical name/email pair.
1990
1991         * Scripts/validate-committer-lists:
1992         (CommitterListFromGit):
1993         (CommitterListBugzillaChecker.print_committers_with_invalid_bugzilla_emails):
1994         Add some missing legacy username mappings.
1995
1996         (dump_mailmap):
1997         (dump_mailmap.format_email):
1998         (dump_mailmap.format_email_with_gitsvn_uuid):
1999         (dump_mailmap.map_emails_to_legacy_username):
2000         (main):
2001         Add `validate-committer-lists --dump-mailmap`, which generates
2002         one given committers.json and the existing mapping of legacy username
2003         to email addresses that exists in validate-committer-lists.
2004
2005 2019-06-12  Aakash Jain  <aakash_jain@apple.com>
2006
2007         Replace double-quotes with single quotes in loadConfig.py
2008         https://bugs.webkit.org/show_bug.cgi?id=198792
2009
2010         Reviewed by Jonathan Bedard.
2011
2012         * BuildSlaveSupport/ews-build/loadConfig.py:
2013         * BuildSlaveSupport/ews-build/steps_unittest.py:
2014
2015 22019-06-11  Brent Fulgham  <bfulgham@apple.com>
2016
2017         Add mechanism and test case to check if ITP is active
2018         https://bugs.webkit.org/show_bug.cgi?id=198694
2019         <rdar://problem/51557704>
2020
2021         Reviewed by Youenn Fablet.
2022
2023         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2024         (TEST):
2025
2026 2019-06-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2027
2028         [WPE][GTK] Deprecate WebSQL APIs
2029         https://bugs.webkit.org/show_bug.cgi?id=195011
2030
2031         Reviewed by Carlos Garcia Campos.
2032
2033         * MiniBrowser/gtk/main.c:
2034         (gotWebsiteDataCallback):
2035         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
2036         (testWebsiteDataConfiguration):
2037         (testWebsiteDataEphemeral):
2038         (testWebsiteDataDatabases):
2039
2040 2019-06-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2041
2042         [WPE][GTK] Enable hyperlink auditing
2043         https://bugs.webkit.org/show_bug.cgi?id=197845
2044
2045         Reviewed by Carlos Garcia Campos.
2046
2047         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2048         (testWebKitSettings):
2049
2050 2019-06-11  Keith Rollin  <krollin@apple.com>
2051
2052         Open up xcfilelist processing to more platforms
2053         https://bugs.webkit.org/show_bug.cgi?id=198675
2054         <rdar://problem/51533238>
2055
2056         Reviewed by Jonathan Bedard.
2057
2058         Now that it's been tested, add AppleTV{OS,Simulator} to the set of
2059         platforms on which to perform xcfilelist generation/updating.
2060
2061         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
2062         (JavaScriptCoreGenerator):
2063         (WebCoreGenerator):
2064         (WebKitGenerator):
2065
2066 2019-06-11  Jonathan Bedard  <jbedard@apple.com>
2067
2068         webkitpy: Fix device ASan reporting, add testing for report configurations
2069         https://bugs.webkit.org/show_bug.cgi?id=198756
2070
2071         Reviewed by Aakash Jain.
2072
2073         ASan results were reporting an incorrect style. This indicates we need to be testing this upload
2074         configuration thoroughly in webkitpy.
2075
2076         * Scripts/webkitpy/port/config.py:
2077         (clear_cached_configuration): Clearing configurations should clear the ASan cache as well.
2078         * Scripts/webkitpy/port/device_port.py:
2079         (DevicePort.configuration_for_upload): Add ASan as style.
2080         * Scripts/webkitpy/port/ios_device_unittest.py:
2081         (IOSDeviceTest):
2082         (IOSDeviceTest.test_default_upload_configuration):
2083         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2084         (IOSSimulatorTest.test_default_upload_configuration):
2085         * Scripts/webkitpy/port/mock_drt_unittest.py:
2086         (MockDRTPortTest.test_asan_upload_configuration):
2087         * Scripts/webkitpy/port/port_testcase.py:
2088         (test_default_upload_configuration):
2089         (test_debug_upload_configuration):
2090         (test_asan_upload_configuration):
2091         (test_guard_malloc_configuration):
2092         * Scripts/webkitpy/port/watch_simulator_unittest.py:
2093         (WatchSimulatorTest):
2094         (WatchSimulatorTest.test_default_upload_configuration):
2095
2096 2019-06-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2097
2098         tu-berlin university email web interface (Outlook Web App) goes directly to the light version instead of the normal web app
2099         https://bugs.webkit.org/show_bug.cgi?id=198749
2100
2101         Reviewed by Carlos Garcia Campos.
2102
2103         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2104         (TestWebKitAPI::TEST):
2105
2106 2019-06-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2107
2108         Quotes are always inserted as smart quotes on stackblitz.com, causing compilation errors
2109         https://bugs.webkit.org/show_bug.cgi?id=198735
2110         <rdar://problem/51557159>
2111
2112         Reviewed by Megan Gardner.
2113
2114         Add a test to verify that spellcheck="false" disables smart quotes and dashes, but any other value defers to the
2115         user's preferences by using UITextSmartQuotesTypeDefault and UITextSmartDashesTypeDefault.
2116
2117         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2118         (TestWebKitAPI::TEST):
2119
2120 2019-06-11  Tadeu Zagallo  <tzagallo@apple.com>
2121
2122         Unreviewed, add myself to the JavaScriptCore watchlist.
2123
2124         * Scripts/webkitpy/common/config/watchlist:
2125
2126 2019-06-11  Tadeu Zagallo  <tzagallo@apple.com>
2127
2128         Unreviewed, change my status to be a WebKit reviewer
2129
2130         * Scripts/webkitpy/common/config/contributors.json:
2131
2132 2019-06-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2133
2134         [WPE] Use new exported image API from fdo backend
2135         https://bugs.webkit.org/show_bug.cgi?id=198558
2136
2137         Reviewed by Philippe Normand.
2138
2139         * WebKitTestRunner/PlatformWPE.cmake: Do not find fdo backend and libxkb again here, since WKTR depends on
2140         WPEToolingBackends that already depends on fdo backend and libxkb
2141         * wpe/backends/CMakeLists.txt: Bump fdo requirements to 1.3.0 version.
2142         * wpe/backends/HeadlessViewBackend.cpp:
2143         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend):
2144         (WPEToolingBackends::HeadlessViewBackend::createSnapshot):
2145         (WPEToolingBackends::HeadlessViewBackend::performUpdate):
2146         (WPEToolingBackends::HeadlessViewBackend::displayBuffer):
2147         * wpe/backends/HeadlessViewBackend.h:
2148         * wpe/backends/ViewBackend.cpp:
2149         (WPEToolingBackends::ViewBackend::initialize):
2150         * wpe/backends/ViewBackend.h:
2151         * wpe/backends/WindowViewBackend.cpp:
2152         (WPEToolingBackends::WindowViewBackend::displayBuffer):
2153         * wpe/backends/WindowViewBackend.h:
2154
2155 2019-06-10  Dewei Zhu  <dewei_zhu@apple.com>
2156
2157         Extend run-benchmark to allow diagnosing before closing browser on test failure.
2158         https://bugs.webkit.org/show_bug.cgi?id=198729
2159
2160         Reviewed by Ryosuke Niwa.
2161
2162         Add '--diagnose-directory' option to store diagnose information when test failed.
2163
2164         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2165         (BenchmarkRunner.__init__):
2166         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2167         (BrowserDriver.diagnose_test_failure): Add default no-op function to base class.
2168         * Scripts/webkitpy/benchmark_runner/run_benchmark.py: Added '--diagnose-directory' option.
2169         (parse_args):
2170         (run_benchmark_plan):
2171         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
2172         (WebDriverBenchmarkRunner._run_one_test): Added 'diagnose_test_failure' invocation on test failure.
2173         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
2174         (WebServerBenchmarkRunner.__init__):
2175         (WebServerBenchmarkRunner._run_one_test): Added 'diagnose_test_failure' invocation on test failure.
2176
2177 2019-06-10  Sam Weinig  <weinig@apple.com>
2178
2179         Remove Dashboard support
2180         https://bugs.webkit.org/show_bug.cgi?id=198615
2181
2182         Reviewed by Ryosuke Niwa.
2183
2184         * DumpRenderTree/TestRunner.cpp:
2185         (TestRunner::staticFunctions):
2186         (setUseDashboardCompatibilityModeCallback): Deleted.
2187         * DumpRenderTree/TestRunner.h:
2188         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2189         * DumpRenderTree/mac/DumpRenderTree.mm:
2190         (resetWebViewToConsistentStateBeforeTesting):
2191         * DumpRenderTree/mac/TestRunnerMac.mm:
2192         (TestRunner::setUseDashboardCompatibilityMode): Deleted.
2193         * ImageDiff/cg/Configurations/Base.xcconfig:
2194         * Scripts/webkitperl/FeatureList.pm:
2195         * TestWebKitAPI/Configurations/Base.xcconfig:
2196         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2197         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2198         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm: Removed.
2199         * WebKitTestRunner/Configurations/Base.xcconfig:
2200         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2201         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2202         (WTR::InjectedBundle::beginTesting):
2203         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2204         (WTR::TestRunner::setUseDashboardCompatibilityMode): Deleted.
2205         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2206
2207 2019-06-10  Alexey Proskuryakov  <ap@apple.com>
2208
2209         Tool binaries like WebKitTestRunner have too aggressive stripping, resulting in non-symbolicated crash logs
2210         https://bugs.webkit.org/show_bug.cgi?id=198616
2211         rdar://problem/36386573
2212
2213         Reviewed by David Kilzer.
2214
2215         Adding an explicit STRIP_STYLE to appropriate xcconfigs.
2216
2217         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2218         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
2219         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
2220         * ImageDiff/cg/Configurations/ImageDiff.xcconfig:
2221         * MiniBrowser/Configurations/MiniBrowser.xcconfig:
2222         * MobileMiniBrowser/Configurations/MobileMiniBrowser.xcconfig:
2223         * TestWebKitAPI/Configurations/TestWTF.xcconfig:
2224         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2225         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2226         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
2227
2228 2019-06-10  Wenson Hsieh  <wenson_hsieh@apple.com>
2229
2230         [iOS] fast/xsl tests are flaky when run after certain viewport shrink-to-fit tests
2231         https://bugs.webkit.org/show_bug.cgi?id=198699
2232         <rdar://problem/50501718>
2233
2234         Reviewed by Simon Fraser.
2235
2236         Add logic to platformResetPreferencesToConsistentValues, to reset the "ShouldIgnoreMetaViewport" preference.
2237         While this is already being adjusted in platformConfigureViewForTest using the correct, TestOptions, this might
2238         happen too late, allowing the shrink-to-fit-content heuristic to unexpectedly kick in on tests where testing
2239         viewport parameters are used.
2240
2241         * WebKitTestRunner/ios/TestControllerIOS.mm:
2242         (WTR::TestController::platformResetPreferencesToConsistentValues):
2243         (WTR::TestController::platformConfigureViewForTest):
2244
2245 2019-06-10  Yusuke Suzuki  <ysuzuki@apple.com>
2246
2247         [JSC] UnlinkedCodeBlock should be eventually jettisoned in VM mini mode
2248         https://bugs.webkit.org/show_bug.cgi?id=198023
2249
2250         Reviewed by Saam Barati.
2251
2252         * Scripts/run-jsc-stress-tests:
2253
2254 2019-06-10  Timothy Hatcher  <timothy@apple.com>
2255
2256         Integrate dark mode support for iOS.
2257         https://bugs.webkit.org/show_bug.cgi?id=198687
2258         rdar://problem/51545643
2259
2260         Reviewed by Tim Horton.
2261
2262         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2263
2264 2019-06-10  Jonathan Bedard  <jbedard@apple.com>
2265
2266         webkitpy: xcrun simctl spawn *** launchctl print system output is not utf-8
2267         https://bugs.webkit.org/show_bug.cgi?id=198723
2268
2269         Reviewed by Aakash Jain.
2270
2271         * Scripts/webkitpy/xcode/simulated_device.py:
2272         (SimulatedDevice.is_usable): Do not decode 'print system' output, it's already ASCII.
2273
2274 2019-06-10  Sihui Liu  <sihui_liu@apple.com>
2275
2276         [WKHTTPCookieStore getAllCookies:] may return duplicate cookies
2277         https://bugs.webkit.org/show_bug.cgi?id=198635
2278         <rdar://problem/46010232>
2279
2280         Reviewed by Ryosuke Niwa.
2281
2282         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2283         (areCookiesEqual):
2284         (TEST):
2285
2286 2019-06-10  Adrian Perez de Castro  <aperez@igalia.com>
2287
2288         [JHBuild] Bump shared-mime-info to version ≥ 1.6
2289         https://bugs.webkit.org/show_bug.cgi?id=198714
2290
2291         Reviewed by Carlos Garcia Campos.
2292
2293         * gtk/jhbuild.modules: Bump shared-mime-info version to 1.10.
2294         * gtk/patches/shared-mime-info-xht-glob.patch: Removed.
2295         * gtk/patches/shared-mime-info-xhtml-magic.patch: Removed.
2296
2297 2019-06-10  Philippe Normand  <pnormand@igalia.com>
2298
2299         [WPE][Qt] Port to new wpe_fdo_egl_exported_image API
2300         https://bugs.webkit.org/show_bug.cgi?id=198713
2301
2302         Reviewed by Carlos Garcia Campos.
2303
2304         * flatpak/org.webkit.WPEModules.yaml: Include wpebackend-fdo
2305         patches currently used in JHBuild.
2306
2307 2019-06-10  Adrian Perez de Castro  <aperez@igalia.com>
2308
2309         [GTK][Flatpak] webkit-build fails due to missing libwpe in Flatpak environment
2310         https://bugs.webkit.org/show_bug.cgi?id=198711
2311
2312         Reviewed by Philippe Normand.
2313
2314         * flatpak/org.webkit.GTK.yaml: Also include modules from
2315         org.webkit.WPEModules.yaml, which brings in libwpe and WPEBackend-fdo
2316
2317 2019-06-10  Zan Dobersek  <zdobersek@igalia.com>
2318
2319         Unreviewed follow-up to r246148. Add another WPEBackend-fdo patch that
2320         avoids double-free condition that's causing bots to exit early.
2321
2322         * gtk/jhbuild.modules:
2323         * gtk/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Added.
2324         * wpe/jhbuild.modules:
2325         * wpe/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Added.
2326
2327 2019-06-09  Fujii Hironori  <Hironori.Fujii@sony.com>
2328
2329         [WinCairo][MiniBrowser] Disable MediaCapabilities until it's ready
2330         https://bugs.webkit.org/show_bug.cgi?id=198655
2331
2332         Reviewed by Ross Kirsling.
2333
2334         MediaCapabilities is enabled by default for WK2, but WinCairo
2335         doesn't implemented yet. Disable it in MiniBrowser.
2336
2337         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2338         (WebKitBrowserWindow::create):
2339
2340 2019-06-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2341
2342         [iOS] The default application name for user agent when requesting desktop content is still "Mobile/15E148"
2343         https://bugs.webkit.org/show_bug.cgi?id=198693
2344         <rdar://problem/51555371>
2345
2346         Reviewed by Tim Horton.
2347
2348         Augment an existing API test to exercise three additional scenarios:
2349             -   The web view configuration's application name is never set; the default should not include
2350                 "Mobile/15E148" in desktop mode.
2351             -   The application name is explicitly set to nil; the default application name should still not include
2352                 "Mobile/15E148".
2353             -   The application name is explicitly set to the default value, "Mobile/15E148". WKWebView should honor
2354                 this when generating the user agent, even in desktop mode.
2355
2356         * TestWebKitAPI/ios/PreferredContentMode.mm:
2357         (TestWebKitAPI::setUpWebViewForPreferredContentModeTestingWithoutNavigationDelegate):
2358         (TestWebKitAPI::setUpWebViewForPreferredContentModeTesting):
2359         (TestWebKitAPI::TEST):
2360
2361 2019-06-08  Zalan Bujtas  <zalan@apple.com>
2362
2363         [LFC] Unreviewed test gardening.
2364
2365         Remove rtl tests. They were mistakenly marked as pass.
2366
2367         * LayoutReloaded/misc/LFC-passing-tests.txt:
2368
2369 2019-06-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
2370
2371         REGRESSION (r244182) [WK1]: Page updates should always scheduleCompositingLayerFlush() immediately
2372         https://bugs.webkit.org/show_bug.cgi?id=198664
2373
2374         Reviewed by Simon Fraser.
2375
2376         Delete repeated entries which were submitted by mistake.
2377
2378         * Tracing/SystemTracePoints.plist:
2379
2380 2019-06-07  Wenson Hsieh  <wenson_hsieh@apple.com>
2381
2382         Allow clients to vend custom -inputView and -inputAccessoryView by overriding WKWebView methods
2383         https://bugs.webkit.org/show_bug.cgi?id=198631
2384         <rdar://problem/51505431>
2385
2386         Reviewed by Tim Horton.
2387
2388         Add an API test that overrides -[WKWebView inputView] and -[WKWebView inputAccessoryView].
2389
2390         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2391         (-[CustomInputWebView initWithFrame:configuration:inputView:inputAccessoryView:]):
2392         (-[CustomInputWebView inputView]):
2393         (-[CustomInputWebView inputAccessoryView]):
2394         (TestWebKitAPI::TEST):
2395
2396 2019-06-07  Daniel Bates  <dabates@apple.com>
2397
2398         [lldb-webkit] Pretty-print all kinds of Documents
2399         https://bugs.webkit.org/show_bug.cgi?id=198620
2400
2401         Reviewed by Simon Fraser.
2402
2403         Register formatters for all classes derived from WebCore::Document so we get nice summaries
2404         without having to drill down in Xcode- or casting- to the base class, Document.
2405
2406         Older LLDB versions use to do this automatically, but this functionality was removed in newer
2407         versions:
2408             [[
2409                 Warning: previous versions of LLDB defined cascading to mean not only going through typedef
2410                 chains, but also through inheritance chains. This feature has been removed since it
2411                 significantly degrades performance. You need to set up your formatters for every type in
2412                 inheritance chains to which you want the formatter to apply.
2413             ]]
2414             <https://lldb.llvm.org/use/variable.html> (as of 06/06/2019)
2415
2416         * lldb/lldb_webkit.py:
2417         (__lldb_init_module):
2418
2419 2019-06-07  Jonathan Bedard  <jbedard@apple.com>
2420
2421         webkitpy: Support reporting results for uncommon test configurations
2422         https://bugs.webkit.org/show_bug.cgi?id=198662
2423         <rdar://problem/51524128>
2424
2425         Reviewed by Aakash Jain.
2426
2427         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2428         (Manager.run): Override wk1 and wk2 flavors with specified flavor.
2429         * Scripts/webkitpy/port/base.py:
2430         (Port.configuration_for_upload): Set flavor based on options.
2431         * Scripts/webkitpy/results/options.py:
2432         (upload_options): Add result-report-flavor option.
2433         * Scripts/webkitpy/test/main.py:
2434         (Tester._run_tests): Set flavor based on options.
2435
2436 2019-06-07  Wenson Hsieh  <wenson_hsieh@apple.com>
2437
2438         [iOS] At least 6 API tests are failing due to an exception when writing NSAttributedString to the pasteboard
2439         https://bugs.webkit.org/show_bug.cgi?id=198641
2440         <rdar://problem/51266310>
2441
2442         Reviewed by Tim Horton.
2443
2444         Work around a bug in a lower-level framework, which currently prevents NSAttributedStrings from being written to
2445         UIPasteboard by way of -[NSItemProvider registerObject:visibility:]. This is because, when saving a
2446         representation of "public.rtfd" to disk, the default suggested filename (determined using CoreServices APIs
2447         _UTTypeCreateSuggestedFilename and UTTypeCopyDescription) ends up being nil; UIKit then subsequently tries to
2448         append nil as a path component using -URLByAppendingPathComponent:, which throws an exception. This only
2449         reproduces on iOS simulator.
2450
2451         To work around this for the time being, simply avoid writing a representation of "public.rtfd" to disk. This
2452         representation is actually ignored by most clients anyways (including WebKit), in favor of using
2453         "com.apple.flat-rtfd".
2454
2455         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2456         (TestWebKitAPI::TEST):
2457         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2458         (applyWorkaroundToAllowWritingAttributedStringsToItemProviders):
2459         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
2460
2461 2019-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2462
2463         REGRESSION(r244857): [GTK][WPE] Many tests are no longer run in the bots after r244857
2464         https://bugs.webkit.org/show_bug.cgi?id=198607
2465
2466         Reviewed by Michael Catanzaro.
2467
2468         Since r244857 several test executables are compiled in the base tests directory instead of using their own sub
2469         directory. Our scripts to run the tests rely on the tests location to decide whether to run them or not, or
2470         determine the type of the tests.
2471
2472         * Scripts/run-gtk-tests:
2473         (GtkTestRunner): Rename TEST_DIRS as TEST_TARGETS and use the executable names for tests not in a subdirectory.
2474         (GtkTestRunner._setup_testing_environment): Fix TestWebKitAccessibility directory name.
2475         (GtkTestRunner.is_glib_test): Use the test name for the ones not using a subdirectory.
2476         (GtkTestRunner.is_google_test): Ditto.
2477         * Scripts/run-wpe-tests:
2478         (WPETestRunner): Rename TEST_DIRS as TEST_TARGETS and use the executable names for tests not in a subdirectory.
2479         (WPETestRunner.is_glib_test): Use the test name for the ones not using a subdirectory.
2480         (WPETestRunner.is_google_test): Ditto.
2481         * glib/api_test_runner.py:
2482         (TestRunner): Rename TEST_DIRS as TEST_TARGETS.
2483         (TestRunner._get_tests): Handle test targets which can now contain directories and executables.
2484
2485 2019-06-06  Keith Rollin  <krollin@apple.com>
2486
2487         Remove SSL-based tests from TestWebKitAPI on some configurations
2488         https://bugs.webkit.org/show_bug.cgi?id=198551
2489         <rdar://problem/51424996>
2490
2491         Reviewed by Jonathan Bedard.
2492
2493         Not all platforms have SSL handy, so don't include SSL-based tests on
2494         those platforms.
2495
2496         * TestWebKitAPI/TCPServer.cpp:
2497         * TestWebKitAPI/TCPServer.h:
2498         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2499         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
2500         * TestWebKitAPI/config.h:
2501
2502 2019-06-06  Daniel Bates  <dabates@apple.com>
2503
2504         [lldb-webkit] TypeError: cannot concatenate 'str' and 'int' objects when prettify SecurityOrigin with
2505         non-default port number
2506         https://bugs.webkit.org/show_bug.cgi?id=198618
2507
2508         Reviewed by Brent Fulgham.
2509
2510         WebCoreSecurityOriginProvider.port() returns an int data type. We need to explicitly convert this to
2511         a string before we concatenate it with another string when building the string representation
2512         for the WebCore::SecurityOrigin object. Otherwise, Python complains that we are concatenating a str
2513         with an int and we don't get a pretty-printed representation for WebCore::SecurityOrigin.
2514
2515         * lldb/lldb_webkit.py:
2516         (WebCoreSecurityOriginProvider.to_string): Call str() on the port before concatenting it.
2517
2518 2019-06-06  Jonathan Bedard  <jbedard@apple.com>
2519
2520         Remove obsolete TOOLCHAINS overrides from as asan.xcconfig
2521         https://bugs.webkit.org/show_bug.cgi?id=198613
2522
2523         Reviewed by Alexey Proskuryakov.
2524
2525         * asan/asan.xcconfig: XCBuild doesn't support overriding toolchains.
2526
2527 2019-06-06  Jonathan Bedard  <jbedard@apple.com>
2528
2529         webkitpluginhost: Support ASan as a style
2530         https://bugs.webkit.org/show_bug.cgi?id=198586
2531         <rdar://problem/51459088>
2532
2533         Reviewed by Alexey Proskuryakov.
2534
2535         * Scripts/webkitpy/port/base.py:
2536         (Port.configuration_for_upload): Add ASan as a style.
2537         * Scripts/webkitpy/port/config.py:
2538         (Config._read_configuration):
2539         (Config):
2540         (Config.asan): Add property to check if the ASan configuration is active.
2541         * Scripts/webkitpy/port/config_unittest.py:
2542         (ConfigTest.test_default_configuration__scripterror):
2543         (ConfigTest):
2544         (ConfigTest.test_asan):
2545         * Scripts/webkitpy/test/main.py:
2546         (Tester._run_tests): Add Asan as a style.
2547
2548 2019-06-06  Alexey Proskuryakov  <ap@apple.com>
2549
2550         block-spammers tool doesn't block e-mail
2551         https://bugs.webkit.org/show_bug.cgi?id=198570
2552
2553         Reviewed by Jonathan Bedard.
2554
2555         * Scripts/block-spammers: (disable_user): Corrected the parameters, Bugzilla doesn't
2556         recognize "false" here. Also, request body is unnecessary.
2557
2558 2019-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2559
2560         [GTK][WPE] Enable PSON
2561         https://bugs.webkit.org/show_bug.cgi?id=194979
2562
2563         Reviewed by Žan Doberšek.
2564
2565         Add WPEBackend-fdo patch required for PSON to work. It can be removed once we have a new version to depend on.
2566
2567         * gtk/jhbuild.modules:
2568         * gtk/patches/wpebackend-fdo-Handle-the-case-of-new-target-created-for-the-same-v.patch: Added.
2569         * wpe/jhbuild.modules:
2570         * wpe/patches/wpebackend-fdo-Handle-the-case-of-new-target-created-for-the-same-v.patch: Added.
2571
2572 2019-06-05  Andy Estes  <aestes@apple.com>
2573
2574         [macOS] Stop calling -[NSDraggingItem setItem:]
2575         https://bugs.webkit.org/show_bug.cgi?id=198588
2576         <rdar://problem/48297453>
2577
2578         On macOS Catalina, use -[NSDraggingItem _initWithItem:] instead.
2579
2580         Reviewed by Wenson Hsieh.
2581
2582         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Fixed up file paths in the
2583         TestRunnerShared group.
2584
2585         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2586         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2587         Changed to call -[NSDraggingItem _initWithItem:] when available.
2588
2589         * TestRunnerShared/spi/AppKitTestSPI.h: Renamed from
2590         Tools/DumpRenderTree/mac/AppKitTestSPI.h and moved NSDraggingItem internal interface
2591         declarations here from DumpRenderTree.
2592
2593         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2594         Added TestRunnerShared/spi/AppKitTestSPI.h.
2595
2596         * TestWebKitAPI/mac/TestDraggingInfo.mm:
2597         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2598         Changed to call -[NSDraggingItem _initWithItem:] when available.
2599
2600 2019-06-05  Jer Noble  <jer.noble@apple.com>
2601
2602         -[WKWebView _suspendAllMediaPlayback] does not persist across navigation.
2603         https://bugs.webkit.org/show_bug.cgi?id=198585
2604
2605         Reviewed by Chris Dumez.
2606
2607         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2608         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2609         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSuspendAllMediaPlayback.mm: Added.
2610         (TEST):
2611         * TestWebKitAPI/Tests/WebKitLegacy/ios/video-with-audio.html:
2612
2613 2019-06-05  Alex Christensen  <achristensen@webkit.org>
2614
2615         Re-enable safe browsing in WKWebView
2616         https://bugs.webkit.org/show_bug.cgi?id=196161
2617         <rdar://problem/49171413>
2618
2619         Reviewed by Ryosuke Niwa.
2620
2621         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2622         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2623         (TEST):
2624         (safeBrowsingView):
2625
2626 == Rolled over to ChangeLog-2019-06-05 ==