4bb210667243de4b22e5af0bcd24689ac79a817e
[WebKit-https.git] / Tools / ChangeLog
1 2011-03-31  Chang Shu  <cshu@webkit.org>
2
3         Reviewed by Darin Adler.
4
5         WebKitTestRunner needs layoutTestController.clearAllDatabases
6         https://bugs.webkit.org/show_bug.cgi?id=42540
7
8         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
9         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
10         (WTR::InjectedBundle::beginTesting):
11         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
12         (WTR::LayoutTestController::clearAllDatabases):
13         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
14
15 2011-03-31  Chang Shu  <cshu@webkit.org>
16
17         Reviewed by Darin Adler.
18
19         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
20         https://bugs.webkit.org/show_bug.cgi?id=42692
21
22         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
23
24 2011-03-31  Darin Adler  <darin@apple.com>
25
26         Reviewed by Sam Weinig.
27
28         Implement mouseDown, mouseUp, and mouseMoveTo in WebKitTestRunner
29         https://bugs.webkit.org/show_bug.cgi?id=57573
30
31         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
32         Added real definitions for mouseDown, mouseUp, mouseMoveTo and leapForward.
33         Removed fake definitions of keyDown and contextClick.
34
35         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
36         (WTR::operator==): Added. So we can compare two WKPoint structs.
37         (WTR::parseModifier): Added.
38         (WTR::parseModifierArray): Added.
39         (WTR::EventSendingController::EventSendingController): Initialize the
40         new data members.
41         (WTR::EventSendingController::mouseDown): Added. Calls
42         WKBundlePageSimulateMouseDown.
43         (WTR::EventSendingController::mouseUp): Added. Calls
44         WKBundlePageSimulateMouseUp.
45         (WTR::EventSendingController::mouseMoveTo): Added. Calls
46         WKBundlePageSimulateMouseMotion.
47         (WTR::EventSendingController::leapForward): Added.
48         (WTR::EventSendingController::updateClickCount): Added. Used by the
49         mouseDown/Up functions to create a click count.
50
51         * WebKitTestRunner/InjectedBundle/EventSendingController.h: Updated
52         for the changes above.
53
54 2011-03-31  Sergio Villar Senin  <svillar@igalia.com>
55
56         Reviewed by Martin Robinson.
57
58         [GTK] implement LayoutTestController::setWillSendRequestReturnsNull
59         https://bugs.webkit.org/show_bug.cgi?id=57362
60
61         Do not generate DRT output if willSendRequestReturnsNull is set.
62
63         * DumpRenderTree/gtk/DumpRenderTree.cpp:
64         (willSendRequestCallback):
65
66 2011-03-31  Vamshikrishna.Yellenki  <vamshi@motorola.com> and Alejandro G. Castro  <alex@igalia.com>
67
68         Reviewed by Martin Robinson.
69
70         Implement MiniBrowser for Gtk port.
71         https://bugs.webkit.org/show_bug.cgi?id=48512
72
73         Initial implementation of the Gtk MiniBrowser.
74
75         * MiniBrowser/gtk/GNUmakefile.am: Added.
76         * MiniBrowser/gtk/main.c: Added.
77         (activateUriEntryCallback):
78         (destroyCallback):
79         (goBackCallback):
80         (goForwardCallback):
81         (createToolbar):
82         (createWebView):
83         (createWindow):
84         (argumentToURL):
85         (main):
86
87 2011-03-30  Dominic Cooney  <dominicc@google.com>
88
89         Reviewed by Dimitri Glazkov.
90
91         Adds layoutTestController.shadowRoot accessor to Mac DRT.
92         https://bugs.webkit.org/show_bug.cgi?id=57415
93
94         * DumpRenderTree/LayoutTestController.cpp:
95         (shadowRootCallback):
96         (LayoutTestController::staticFunctions):
97         * DumpRenderTree/LayoutTestController.h:
98         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
99         (LayoutTestController::shadowRoot):
100         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
101         (LayoutTestController::shadowRoot):
102
103 2011-03-30  Matthew Delaney  <mdelaney@apple.com>
104
105         Reviewed by Chris Marrin.
106
107         Update fast/canvas tests to avoid dumping the render tree when possible
108         https://bugs.webkit.org/show_bug.cgi?id=57493
109
110         * DumpRenderTree/mac/DumpRenderTree.mm: Make DRT aware of new default values for
111           accelerated drawing and accelerated drawing for canvas
112
113 2011-03-30  Adam Roben  <aroben@apple.com>
114
115         Stop ignoring leaks in CGGradientCreateWithColorStops
116
117         Fixes <rdar://problem/7888547>.
118
119         Rubber-stamped by John Sullivan.
120
121         * Scripts/old-run-webkit-tests:
122         (countAndPrintLeaks): Removed some code to ignore those leaks.
123
124 2011-03-30  Timur Iskhodzhanov  <timurrrr@google.com>
125
126         Reviewed by Alexey Proskuryakov.
127
128         Add some dynamic annotations to JavaScriptCore/wtf
129         https://bugs.webkit.org/show_bug.cgi?id=53747
130
131         By using these annotations we can improve the precision of finding
132         WebKit errors using dynamic analysis tools like ThreadSanitizer and Valgrind.
133         These annotations don't affect the compiled binaries unless USE(DYNAMIC_ANNOTATIONS) is "1".
134
135         These files don't add new functionality, so don't need extra tests.
136
137         * DumpRenderTree/ForwardingHeaders/wtf/DynamicAnnotations.h: Added.
138
139 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
140
141         Reviewed by Adam Roben.
142
143         Share most vsprops between Release and Production builds in releaseproduction.vsprops
144         https://bugs.webkit.org/show_bug.cgi?id=57508
145
146         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
147         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops:
148         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops:
149         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
150         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops:
151         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops:
152         * DumpRenderTree/win/ImageDiffProduction.vsprops:
153         * DumpRenderTree/win/ImageDiffRelease.vsprops:
154         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops:
155         * FindSafari/FindSafariProduction.vsprops:
156         * FindSafari/FindSafariRelease.vsprops:
157         * FindSafari/FindSafariReleaseCairoCFLite.vsprops:
158         * FindSafari/FindSafariReleasePGO.vsprops:
159         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
160         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops:
161         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops:
162         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops:
163         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops:
164         * WebKitAPITest/WebKitAPITestProduction.vsprops:
165         * WebKitAPITest/WebKitAPITestRelease.vsprops:
166         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops:
167         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
168         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops:
169         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops:
170         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
171         * WebKitTestRunner/win/InjectedBundleRelease.vsprops:
172         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops:
173         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
174         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops:
175         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops:
176         * WinLauncher/WinLauncherProduction.vsprops:
177         * WinLauncher/WinLauncherRelease.vsprops:
178         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops:
179         * record-memory-win/record-memory-winProduction.vsprops:
180         * record-memory-win/record-memory-winRelease.vsprops:
181         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops:
182
183 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
184
185         Reviewed by Adam Roben.
186
187         Update Windows production build logic for new production configurations
188         https://bugs.webkit.org/show_bug.cgi?id=57494
189
190         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
191         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
192         * DumpRenderTree/win/ImageDiffProduction.vsprops:
193         * FindSafari/FindSafariProduction.vsprops:
194         * FindSafari/FindSafariReleasePGO.vsprops:
195         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
196         * WebKitAPITest/WebKitAPITestProduction.vsprops:
197         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
198         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
199         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
200         * WinLauncher/WinLauncherProduction.vsprops:
201         * record-memory-win/record-memory-winProduction.vsprops:
202
203 2011-03-30  Robert Hogan  <robert@webkit.org>
204
205         Reviewed by Antonio Gomes.
206
207         [Qt] Fix LoadHTMLStringItem::invoke() after r75966
208         Unskip http/tests/navigation/go-back-to-error-page.html
209
210         Also add the location of DumpRenderTreeSupportQt.h
211         to DRT's include paths.
212
213         https://bugs.webkit.org/show_bug.cgi?id=52614
214
215         * DumpRenderTree/qt/DumpRenderTree.pro:
216         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
217         * DumpRenderTree/qt/DumpRenderTreeQt.h:
218         * DumpRenderTree/qt/GCControllerQt.cpp:
219         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
220         (LayoutTestController::queueLoadHTMLString):
221         * DumpRenderTree/qt/LayoutTestControllerQt.h:
222         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
223         * DumpRenderTree/qt/TextInputControllerQt.cpp:
224         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
225         (LoadAlternateHTMLStringItem::invoke):
226         * DumpRenderTree/qt/WorkQueueItemQt.h:
227         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
228         * QtTestBrowser/QtTestBrowser.pro:
229         * QtTestBrowser/launcherwindow.h:
230
231 2011-03-30  Adam Barth  <abarth@webkit.org>
232
233         Reviewed by Adam Roben.
234
235         SheriffBot rollouts take too long
236         https://bugs.webkit.org/show_bug.cgi?id=57498
237
238         We used to build before landing rollouts via the commit-queue to
239         prevent further breakage, but now that our individual commit-queue
240         machines are slower, building takes too long.  I can't remember the
241         last time a rollout broke compile.  It seems like just landing the
242         patch is the better trade-off.
243
244         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
245         * Scripts/webkitpy/tool/commands/queues_unittest.py:
246
247 2011-03-30  Adam Barth  <abarth@webkit.org>
248
249         Remove platform/chromium-mac-snowleopard
250         https://bugs.webkit.org/show_bug.cgi?id=57486
251
252         This directory no longer exists, so we can remove it from the fallback
253         chain.
254
255         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
256
257 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
258
259         Reviewed by Adam Roben.
260
261         Rename Windows configuration Release_LTCG to Production for clarity
262         https://bugs.webkit.org/show_bug.cgi?id=57465
263
264         * DumpRenderTree/DumpRenderTree.sln:
265         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
266         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops: Copied from Tools/DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops.
267         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Removed.
268         * DumpRenderTree/win/DumpRenderTree.vcproj:
269         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops: Copied from Tools/DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops.
270         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Removed.
271         * DumpRenderTree/win/ImageDiff.vcproj:
272         * DumpRenderTree/win/ImageDiffProduction.vsprops: Copied from Tools/DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops.
273         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Removed.
274         * FindSafari/FindSafari.vcproj:
275         * FindSafari/FindSafariProduction.vsprops: Copied from Tools/FindSafari/FindSafariReleaseLTCG.vsprops.
276         * FindSafari/FindSafariReleaseLTCG.vsprops: Removed.
277         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops: Copied from Tools/MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops.
278         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Removed.
279         * MiniBrowser/MiniBrowser.vcproj:
280         * Scripts/webkitdirs.pm:
281         * TestWebKitAPI/win/TestWebKitAPI.sln:
282         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
283         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
284         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
285         * WebKitAPITest/WebKitAPITest.vcproj:
286         * WebKitAPITest/WebKitAPITestProduction.vsprops: Copied from Tools/WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops.
287         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Removed.
288         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
289         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops: Copied from Tools/WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops.
290         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Removed.
291         * WebKitTestRunner/WebKitTestRunner.sln:
292         * WebKitTestRunner/win/InjectedBundle.vcproj:
293         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
294         * WebKitTestRunner/win/InjectedBundleProduction.vsprops: Copied from Tools/WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops.
295         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Removed.
296         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
297         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops: Copied from Tools/WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops.
298         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Removed.
299         * WinLauncher/WinLauncher.vcproj:
300         * WinLauncher/WinLauncherProduction.vsprops: Copied from Tools/WinLauncher/WinLauncherReleaseLTCG.vsprops.
301         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Removed.
302         * record-memory-win/record-memory-win.vcproj:
303         * record-memory-win/record-memory-winProduction.vsprops: Copied from Tools/record-memory-win/record-memory-winReleaseLTCG.vsprops.
304         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Removed.
305
306 2011-03-30  MORITA Hajime  <morrita@google.com>
307
308         Reviewed by Dimitri Glazkov.
309
310         [Chromium] Expose the shadow DOM to DumpRenderTree JS tests.
311         https://bugs.webkit.org/show_bug.cgi?id=56573
312
313         Added LayoutTestController.shadowRoot() to Chromium DRT.
314
315         * DumpRenderTree/chromium/LayoutTestController.cpp:
316         (LayoutTestController::LayoutTestController):
317         (LayoutTestController::shadowRoot):
318         * DumpRenderTree/chromium/LayoutTestController.h:
319
320 2011-03-30  Yuta Kitamura  <yutak@chromium.org>
321
322         Reviewed by Kent Tamura.
323
324         [Chromium] DumpRenderTree: Implement LayoutTestController::setPluginsEnabled
325         https://bugs.webkit.org/show_bug.cgi?id=57430
326
327         * DumpRenderTree/chromium/LayoutTestController.cpp:
328         (LayoutTestController::LayoutTestController):
329         (LayoutTestController::setPluginsEnabled):
330         * DumpRenderTree/chromium/LayoutTestController.h:
331
332 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
333
334         Reviewed by Adam Barth.
335
336         make webkit-patch upload respect -d
337         https://bugs.webkit.org/show_bug.cgi?id=57425
338
339         * Scripts/webkitpy/common/checkout/scm.py:
340         * Scripts/webkitpy/tool/steps/commit.py:
341
342 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
343
344         Reviewed by Adam Barth.
345
346         Make "webkit-patch --dry-run --verbose land" log the SVN command it's going to use
347         https://bugs.webkit.org/show_bug.cgi?id=57429
348
349         * Scripts/webkitpy/common/checkout/scm.py:
350
351 2011-03-29  Sheriff Bot  <webkit.review.bot@gmail.com>
352
353         Unreviewed, rolling out r82383.
354         http://trac.webkit.org/changeset/82383
355         https://bugs.webkit.org/show_bug.cgi?id=57417
356
357         "nrwt isn't shutting down cleanly" (Requested by dpranke on
358         #webkit).
359
360         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
361         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
362         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
363
364 2011-03-29  Kent Tamura  <tkent@chromium.org>
365
366         Reviewed by Dimitri Glazkov.
367
368         Make validation message bubble testable
369         https://bugs.webkit.org/show_bug.cgi?id=57290
370
371         * DumpRenderTree/mac/DumpRenderTree.mm:
372         (createWebViewAndOffscreenWindow): Change a setting so that validation
373           bubbles isn't hidden automatically.
374
375 2011-03-29  Dirk Pranke  <dpranke@chromium.org>
376
377         Reviewed by Ojan Vafai.
378
379         new-run-webkit-tests: use 'threads' on win instead of 'old-threads'
380
381         It's a bit unclear whether multiple threads or multiple
382         processes will be a better model on windows. This change will
383         test threads for now while we're still working out the bugs in
384         multiple-processes.
385
386         https://bugs.webkit.org/show_bug.cgi?id=57410
387
388         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
389         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
390         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
391
392 2011-03-29  David Levin  <levin@chromium.org>
393
394         Reviewed by Shinichiro Hamaji.
395
396         check-webkit-style confused by two ChangeLog entries in a row from same user
397         https://bugs.webkit.org/show_bug.cgi?id=57250
398
399         * Scripts/webkitpy/style/checker.py: Add the line should be checked function to ChangeLogChecker.
400         * Scripts/webkitpy/style/checker_unittest.py: Fix test due to that new function.
401         * Scripts/webkitpy/style/checkers/changelog.py: Made this code aware of what lines were being checked.
402           It basically assumes only one ChangeLog entry is being processed because that is the standard case and
403           checking more than that would be very messey.
404         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Add testing to catch the broken case.
405         * Scripts/webkitpy/style/error_handlers.py: Added should_line_be_checked.
406
407 2011-03-29  Kent Tamura  <tkent@chromium.org>
408
409         Reviewed by Dimitri Glazkov.
410
411         [Mac] Enable interactive-validation tests on Mac DRT
412         https://bugs.webkit.org/show_bug.cgi?id=57308
413
414         * DumpRenderTree/mac/DumpRenderTree.mm:
415         (createWebViewAndOffscreenWindow): Enable the form interactive validation feature.
416
417 2011-03-29  Chang Shu  <cshu@webkit.org>
418
419         Reviewed by Kenneth Rohde Christiansen.
420
421         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
422         https://bugs.webkit.org/show_bug.cgi?id=42692
423
424         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
425         (WTR::InjectedBundle::beginTesting):
426         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
427         (WTR::LayoutTestController::setAllowUniversalAccessFromFileURLs):
428         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
429
430 2011-03-24  Martin Robinson  <mrobinson@igalia.com>
431
432         Reviewed by Xan Lopez.
433
434         [GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
435         https://bugs.webkit.org/show_bug.cgi?id=57067
436
437         Eliminate extra spacing between the DRT GtkScrolledWindow and the DRT WebView. This
438         will allow WebKit1GTK+ and WebKit2GTK+ to share test results. Followup commits will
439         update DRT and pixel results as hundreds of results will need to be updated.
440
441         * DumpRenderTree/gtk/DumpRenderTree.cpp:
442         (setDefaultsToConsistentStateValuesForTesting): Eliminate spacing on the GtkScrolledWindow
443         by overriding the theme RC/CSS files.
444
445 2011-03-29  Steve Falkenburg  <sfalken@apple.com>
446
447         Reviewed by Adam Roben.
448
449         Use per-configuration vsprops in tools projects to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
450         https://bugs.webkit.org/show_bug.cgi?id=57394
451
452         Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
453         InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
454         the IDE. To avoid this, add a separate vsprops file for each project configuration that
455         contains the required inherited property sheets.
456
457         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
458         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops: Added.
459         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops: Added.
460         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops: Added.
461         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: Added.
462         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: Added.
463         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Added.
464         * DumpRenderTree/win/DumpRenderTree.vcproj:
465         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops: Added.
466         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops: Added.
467         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Added.
468         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops: Added.
469         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: Added.
470         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Added.
471         * DumpRenderTree/win/ImageDiff.vcproj:
472         * DumpRenderTree/win/ImageDiffDebug.vsprops: Added.
473         * DumpRenderTree/win/ImageDiffDebugAll.vsprops: Added.
474         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Added.
475         * DumpRenderTree/win/ImageDiffRelease.vsprops: Added.
476         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Added.
477         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Added.
478         * FindSafari/FindSafari.vcproj:
479         * FindSafari/FindSafariDebug.vsprops: Added.
480         * FindSafari/FindSafariDebugAll.vsprops: Added.
481         * FindSafari/FindSafariDebugCairoCFLite.vsprops: Added.
482         * FindSafari/FindSafariRelease.vsprops: Added.
483         * FindSafari/FindSafariReleaseCairoCFLite.vsprops: Added.
484         * FindSafari/FindSafariReleaseLTCG.vsprops: Added.
485         * FindSafari/FindSafariReleasePGO.vsprops: Added.
486         * MiniBrowser/Configurations/MiniBrowserDebug.vsprops: Added.
487         * MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops: Added.
488         * MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops: Added.
489         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops: Added.
490         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops: Added.
491         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Added.
492         * MiniBrowser/MiniBrowser.vcproj:
493         * WebKitAPITest/WebKitAPITest.vcproj:
494         * WebKitAPITest/WebKitAPITestDebug.vsprops: Added.
495         * WebKitAPITest/WebKitAPITestDebugAll.vsprops: Added.
496         * WebKitAPITest/WebKitAPITestDebugCairoCFLite.vsprops: Added.
497         * WebKitAPITest/WebKitAPITestRelease.vsprops: Added.
498         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops: Added.
499         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Added.
500         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
501         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops: Added.
502         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops: Added.
503         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops: Added.
504         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: Added.
505         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: Added.
506         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Added.
507         * WebKitTestRunner/win/InjectedBundle.vcproj:
508         * WebKitTestRunner/win/InjectedBundleDebug.vsprops: Added.
509         * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops: Added.
510         * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops: Added.
511         * WebKitTestRunner/win/InjectedBundleRelease.vsprops: Added.
512         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops: Added.
513         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Added.
514         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
515         * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops: Added.
516         * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops: Added.
517         * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops: Added.
518         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops: Added.
519         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops: Added.
520         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Added.
521         * WinLauncher/WinLauncher.vcproj:
522         * WinLauncher/WinLauncherDebug.vsprops: Added.
523         * WinLauncher/WinLauncherDebugAll.vsprops: Added.
524         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops: Added.
525         * WinLauncher/WinLauncherRelease.vsprops: Added.
526         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: Added.
527         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Added.
528         * record-memory-win/record-memory-win.vcproj:
529         * record-memory-win/record-memory-winDebug.vsprops: Added.
530         * record-memory-win/record-memory-winDebugAll.vsprops: Added.
531         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops: Added.
532         * record-memory-win/record-memory-winRelease.vsprops: Added.
533         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: Added.
534         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Added.
535
536 2011-03-29  Adam Barth  <abarth@webkit.org>
537
538         Reviewed by Darin Adler.
539
540         test_runner2.py can crash due to undefined variable
541         https://bugs.webkit.org/show_bug.cgi?id=57356
542
543         Replace reference to undefined variable with a variable that's actually
544         defined.  AFAICT, there's no way to test this code.
545
546         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
547
548 2011-03-29  Tony Chang  <tony@chromium.org>
549
550         Reviewed by Eric Seidel.
551
552         cleanup rebaseline-chromium-webkit-tests
553         https://bugs.webkit.org/show_bug.cgi?id=57375
554
555         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
556             - Split _extract_and_add_new_baselines into 3 functions
557             - Reduce the amount of line wrapping (the file already has lines
558               over 80 col, so may as well try to make the file consistent)
559             - Remove unnecessary ()s
560
561 2011-03-29  Brent Fulgham  <bfulgham@webkit.org>
562
563         Reviewed by Adam Roben.
564
565         Make WinCairo a core builder.
566         https://bugs.webkit.org/show_bug.cgi?id=57373
567
568         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Add WinCairo.
569         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Add WinCairo.
570
571 2011-03-29  Timothy Hatcher  <timothy@apple.com>
572
573         Update update-webkit-localizable-strings to understand that WebKit and
574         WebKit2 strings go in WebCore.
575
576         Also make extract-localizable-strings optionally use an exclude file. No individual
577         warnings are produced about unlocalized strings when there is no exclude file. This
578         is needed for WebCore, since there are too many bare strings.
579
580         https://webkit.org/b/57354
581
582         Reviewed by Sam Weinig.
583
584         * Scripts/extract-localizable-strings: Support "-" to mean no exclude file.
585         * Scripts/update-webkit-localizable-strings: Update paths to scan WebCore and WebKit2.
586
587 2011-03-29  Darin Adler  <darin@apple.com>
588
589         Reviewed by Adam Roben.
590
591         WebKit2 bundle page needs to offer generated file hooks
592         https://bugs.webkit.org/show_bug.cgi?id=57279
593
594         (Land missing part of the original patch after r82289.)
595
596         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
597         (WTR::InjectedBundlePage::InjectedBundlePage): Added new callbacks.
598
599 2011-03-29  Tony Chang  <tony@chromium.org>
600
601         Reviewed by Ojan Vafai.
602
603         [chromium] NRWT should be able to read checksums from png comments
604         https://bugs.webkit.org/show_bug.cgi?id=57280
605
606         * Scripts/read-checksum-from-png: Added. Utility script to read the checksum
607             from a file.
608         * Scripts/webkitpy/common/system/filesystem.py: Add open_binary_file_for_reading
609         * Scripts/webkitpy/common/system/filesystem_mock.py:
610         * Scripts/webkitpy/layout_tests/port/base.py: When loading a checksum,
611             if the -checksum.txt file doesn't exist, try looking in the png.
612         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
613         * Scripts/webkitpy/layout_tests/port/test.py:
614         * Scripts/webkitpy/layout_tests/read_checksum_from_png.py: Added. Scan the first
615             2k for a png comment with the checksum
616         * Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py: Added.
617
618 2011-03-29  Philippe Normand  <pnormand@igalia.com>
619
620         Rubber-stamped by Gustavo Noronha Silva.
621
622         [GTK] http/tests/uri/username-with-no-hostname.html fails
623         https://bugs.webkit.org/show_bug.cgi?id=57325
624
625         * DumpRenderTree/gtk/DumpRenderTree.cpp:
626         (willSendRequestCallback): URI host value check done case-insensitively.
627
628 2011-03-29  Philippe Normand  <pnormand@igalia.com>
629
630         Reviewed by Martin Robinson.
631
632         [GTK] http/tests/uri/username-with-no-hostname.html fails
633         https://bugs.webkit.org/show_bug.cgi?id=57325
634
635         * DumpRenderTree/gtk/DumpRenderTree.cpp:
636         (willSendRequestCallback): Check URI before submitting the request
637         to WebCore.
638
639 2011-03-29  Noel Gordon  <noel.gordon@gmail.com>
640
641         Reviewed by Ojan Vafai.
642
643         [chromium] DRT EventSender: remove identity from dragTargetDragEnter() calls
644         https://bugs.webkit.org/show_bug.cgi?id=57303
645
646         * DumpRenderTree/chromium/EventSender.cpp:
647         (EventSender::doDragDrop):
648         (EventSender::beginDragWithFiles):
649
650 2011-03-29  Zoltan Horvath  <zoltan@webkit.org>
651
652         Reviewed by Andreas Kling.
653
654         [Qt] Add -print-loaded-urls option to Qt's MiniBrowser and to QtTestBrowser
655         https://bugs.webkit.org/show_bug.cgi?id=57314
656
657         Provide possibility to print loaded urls to the standard output.
658
659         * MiniBrowser/qt/BrowserWindow.cpp:
660         (BrowserWindow::BrowserWindow):
661         (BrowserWindow::printURL):
662         * MiniBrowser/qt/BrowserWindow.h:
663         * MiniBrowser/qt/MiniBrowserApplication.cpp:
664         (MiniBrowserApplication::handleUserOptions):
665         * MiniBrowser/qt/MiniBrowserApplication.h:
666         (WindowOptions::WindowOptions):
667         * QtTestBrowser/launcherwindow.cpp:
668         (LauncherWindow::initializeView):
669         (LauncherWindow::printURL):
670         (LauncherWindow::cloneWindow):
671         * QtTestBrowser/launcherwindow.h:
672         (WindowOptions::WindowOptions):
673         * QtTestBrowser/main.cpp:
674         (LauncherApplication::handleUserOptions):
675
676 2011-03-29  Gabor Loki  <loki@webkit.org>
677
678         Rubber-stamped by Csaba Osztrogonác.
679
680         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
681         https://bugs.webkit.org/show_bug.cgi?id=56918
682
683         * Scripts/build-jsc: Remove duplicated --qt options to avoid passing them to qmake.
684
685 2011-03-28  Gabor Loki  <loki@webkit.org>
686
687         Reviewed by Csaba Osztrogonác.
688
689         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
690         https://bugs.webkit.org/show_bug.cgi?id=56918
691
692         * Scripts/build-jsc:
693         * Scripts/webkitdirs.pm:
694
695 2011-03-28  Andrew Foster  <andrewf@chromium.org>
696
697         Reviewed by Ojan Vafai.
698
699         webkit-patch should be more intelligent about whether a bug applies to a patch
700         Create a new function, parse_bug_id_from_changelog() which determines
701         that a bug is related to a patch by parsing the output generated from
702         prepare-ChangeLog, rather than arbitrarily matching a URL to a bug in
703         the description of a patch.
704         https://bugs.webkit.org/show_bug.cgi?id=56989
705
706         * Scripts/webkitpy/common/checkout/api.py:
707         * Scripts/webkitpy/common/checkout/changelog.py:
708         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
709         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
710         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
711         * Scripts/webkitpy/style/checkers/changelog.py:
712         * Scripts/webkitpy/tool/commands/upload.py:
713
714 2011-03-28  Maciej Stachowiak  <mjs@apple.com>
715
716         Revert accidentally commited change.
717
718         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
719         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
720
721 2011-03-28  Tony Chang  <tony@chromium.org>
722
723         Reviewed by Adam Barth.
724
725         [chromium] have DRT write the png checksum into a png comment
726         https://bugs.webkit.org/show_bug.cgi?id=57255
727
728         * DumpRenderTree/chromium/TestShell.cpp:
729         (TestShell::dumpImage):
730
731 2011-03-28  Adele Peterson  <adele@apple.com>
732
733         Removing Qt stub, since it doesn't use the same header as the others.
734
735         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
736
737 2011-03-28  Adele Peterson  <adele@apple.com>
738
739         Added a few more stubs.
740
741         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
742         (LayoutTestController::hasGrammarMarker):
743         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
744         (LayoutTestController::hasGrammarMarker):
745         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
746         (LayoutTestController::hasGrammarMarker):
747
748 2011-03-28  Adele Peterson  <adele@apple.com>
749
750         Build fix.
751
752         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
753         (LayoutTestController::hasGrammarMarker):
754
755 2011-03-28  Adele Peterson  <adele@apple.com>
756
757         Reviewed by Eric Seidel.
758
759         Testing support for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
760         https://bugs.webkit.org/show_bug.cgi?id=57173
761
762         * DumpRenderTree/LayoutTestController.cpp:
763         (hasGrammarMarkerCallback): Added.
764         (LayoutTestController::staticFunctions): Added case for hasGrammarMarker.
765         * DumpRenderTree/LayoutTestController.h:
766         * DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): Call setGrammarCheckingEnabled.
767         * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::hasGrammarMarker): Added. Call new hasGrammarMarker method.
768
769 2011-03-28  Csaba Osztrogonác  <ossy@webkit.org>
770
771         Reviewed by Benjamin Poulain.
772
773         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
774         https://bugs.webkit.org/show_bug.cgi?id=57087
775
776         Trivial typo fix after r82082.
777
778         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
779         (WTR::activateFonts):
780
781 2011-03-28  Alexis Menard  <alexis.menard@openbossa.org>
782
783         Reviewed by Andreas Kling.
784
785         Add myself to the committers list.
786
787         * Scripts/webkitpy/common/config/committers.py:
788
789 2011-03-28  Simon Fraser  <simon.fraser@apple.com>
790
791         Reviewed by Sam Weinig.
792
793         WebKit2 unfortunately uses code from WebKit, so MiniBrowser needs
794         to link against WebKit.framework for now.
795
796         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
797
798 2011-03-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
799
800         Reviewed by Andreas Kling.
801
802         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
803         https://bugs.webkit.org/show_bug.cgi?id=57087
804
805         Disable QT_ASCII_CAST_WARNINGS for applications.
806
807         * DumpRenderTree/qt/DumpRenderTree.pro:
808         * DumpRenderTree/qt/ImageDiff.pro:
809         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
810         * MiniBrowser/qt/MiniBrowser.pro:
811         * QtTestBrowser/QtTestBrowser.pro:
812         * WebKitTestRunner/qt/WebKitTestRunner.pro:
813
814 2011-03-28  Andreas Kling  <kling@webkit.org>
815
816         Reviewed by Kenneth Rohde Christiansen.
817
818         [Qt] QtTestBrowser doesn't reset its window title when opening about:blank
819         https://bugs.webkit.org/show_bug.cgi?id=57224
820
821         * QtTestBrowser/mainwindow.cpp:
822         (MainWindow::buildUI):
823         (MainWindow::onTitleChanged):
824         * QtTestBrowser/mainwindow.h:
825
826 2011-03-27  Jer Noble  <jer.noble@apple.com>
827
828         Reviewed by Maciej Stachowiak.
829
830         Full Screen: disable keyboard access by default
831         https://bugs.webkit.org/show_bug.cgi?id=56684
832
833         Accept the withKeyboard parameter to supportsFullScreenForElement.
834
835         * DumpRenderTree/mac/UIDelegate.mm:
836         (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
837
838 2011-03-27  Patrick Gansterer  <paroga@webkit.org>
839
840         Reviewed by David Levin.
841
842         check-webkit-style should check ChangeLog for a valid bug number
843         https://bugs.webkit.org/show_bug.cgi?id=57184
844
845         * Scripts/webkitpy/style/checker.py:
846         * Scripts/webkitpy/style/checker_unittest.py:
847         * Scripts/webkitpy/style/checkers/changelog.py: Added.
848         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Added.
849
850 2011-03-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
851
852         Reviewed by Andreas Kling.
853
854         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
855         https://bugs.webkit.org/show_bug.cgi?id=57087
856
857         Use explicit conversion for string to avoid depending on the default codec
858         installed by the user code.
859
860         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
861         (WTR::activateFonts):
862
863 2011-03-26  Maciej Stachowiak  <mjs@apple.com>
864
865         Revert inadvertantly committed changes.
866
867         * Scripts/old-run-webkit-tests:
868         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
869
870 2011-03-26  Andreas Kling  <kling@webkit.org>
871
872         Reviewed by Kenneth Rohde Christiansen.
873
874         [Qt] Show page icons (favicons) in QtTestBrowser location bar.
875         https://bugs.webkit.org/show_bug.cgi?id=57162
876
877         * QtTestBrowser/QtTestBrowser.qrc:
878         * QtTestBrowser/favicon.png: Added.
879         * QtTestBrowser/locationedit.cpp:
880         (defaultPageIcon):
881         (LocationEdit::LocationEdit):
882         (LocationEdit::setPageIcon):
883         (LocationEdit::resizeEvent):
884         (LocationEdit::updateInternalGeometry):
885         * QtTestBrowser/locationedit.h:
886         * QtTestBrowser/mainwindow.cpp:
887         (MainWindow::buildUI):
888         (MainWindow::onIconChanged):
889         (MainWindow::onLoadStarted):
890         * QtTestBrowser/mainwindow.h:
891
892 2011-03-23  Martin Robinson  <mrobinson@igalia.com>
893
894         Reviewed by Xan Lopez.
895
896         [GTK] Force DumpRenderTree to use 96 DPI
897         https://bugs.webkit.org/show_bug.cgi?id=56866
898
899         Make sure that GTK+ is set to use 96 DPI when running tests. This ensures
900         broader compatibility with WebKit2 and makes setting font sizes more straightforward.
901
902         * DumpRenderTree/gtk/DumpRenderTree.cpp:
903         (initializeGtkFontSettings): Set the screen resolution and GTK+ xft property to 96 DPI.
904         (resetDefaultsToConsistentValues):Remove the call which repeatedly set the GDK screen resolution.
905         (setDefaultsToConsistentStateValuesForTesting): Update the font sizes to reflect the new DPI.
906
907 2011-03-25  Andy Estes  <aestes@apple.com>
908
909         Reviewed by Adele Peterson.
910
911         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
912         https://bugs.webkit.org/show_bug.cgi?id=49016
913
914         TestNetscapePlugIn needs to register support for an image MIME type so
915         we can test that the embed tag prefers plug-ins to render image MIME
916         types.
917
918         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Register image/png.
919         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
920         (NP_GetMIMEDescription): Ditto.
921         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Ditto.
922
923 2011-03-25  Jessie Berlin  <jberlin@apple.com>
924
925         Reviewed by Sam Weinig.
926
927         WebKit2: Need to be able to set and get the Cookie Storage Policy.
928         https://bugs.webkit.org/show_bug.cgi?id=50780
929
930         Add a test for getting and setting the HTTP Cookie Accept Policy in WebKit2.
931
932         The test is named "CookieManager" so that we can eventually exercise more of the
933         CookieManager functionality in the test.
934
935         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp: Added.
936         (TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy):
937         Assert that the policy returned is equal to the policy set in
938         didGetUserHTTPCookieAcceptPolicy, and then restore the user's policy.
939         (TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy):
940         Set the policy to something different than the user's policy and get the policy again.
941         (TestWebKitAPI::didFinishLoadForFrame):
942         Get the user's policy so that it can be restored at the end of the test.
943         (TestWebKitAPI::TEST):
944         Load about:blank so that the Web Process gets instatiated (needed to get the
945         CookieManager).
946
947         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
948         Add CookieManager.cpp.
949
950 2011-03-24  Kevin Ollivier  <kevino@theolliviers.com>
951
952         [wx] Fix the build so that gcc-4.1 and up can be used to build on SnowLeopard.
953
954         * wx/build/settings.py:
955
956 2011-03-24  Ilya Sherman  <isherman@chromium.org>
957
958         Reviewed by Adam Roben.
959
960         Implement layoutTestController.setAutoFilled in DRT on Windows
961         https://bugs.webkit.org/show_bug.cgi?id=56828
962
963         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
964         (LayoutTestController::setAutofilled): Implemented.
965
966 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
967
968         Unreviewed build correction.
969
970         Correct vsprops file for Debug variant of the CFLite build.
971         Disable a CFNETWORK-specific test when building for CFLite.
972
973         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops:
974         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
975
976 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
977
978         Reviewed by Adam Barth.
979
980         fix regressions introduced in 81908 - there were a couple of
981         code paths that only fired under python 2.5 that I missed.
982
983         Also change a couple of 'python' references to sys.executable
984         in order to handle runing test-webkitpy with a binary other than
985         something called 'python'.
986
987         https://bugs.webkit.org/show_bug.cgi?id=57063
988
989         * Scripts/webkitpy/layout_tests/port/mac.py:
990         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
991         * Scripts/webkitpy/test/cat.py:
992         * Scripts/webkitpy/test/echo.py:
993
994 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
995
996         Unreviewed build correction.
997
998         Add a stub implementation of the TestInvocation dumping logic.
999         Update project files to reflect new file.
1000
1001         * WebKitTestRunner/cairo: Added.
1002         * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added.
1003         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1004         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1005
1006 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
1007
1008         Reviewed by Tony Chang.
1009
1010         new-run-webkit-tests: clean up worker model defaults. This
1011         changes the default behavior to 'threads' instead of
1012         'old-threads', and clarifies that chromium-win-* and
1013         chromium-mac-leopard are exceptions.
1014
1015         https://bugs.webkit.org/show_bug.cgi?id=56971
1016
1017         * Scripts/webkitpy/layout_tests/port/base.py:
1018         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1019         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1020         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1021         * Scripts/webkitpy/layout_tests/port/test.py:
1022         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1023
1024 2011-03-23  Leandro Gracia Gil  <leandrogracia@chromium.org>
1025
1026         Reviewed by Darin Adler.
1027
1028         Media Stream API: fix the order of the options in build-webkit.
1029         https://bugs.webkit.org/show_bug.cgi?id=56949
1030
1031         Fix the order of the options in build-webkit.
1032
1033         * Scripts/build-webkit:
1034
1035 2011-03-23  Adam Klein  <adamk@chromium.org>
1036
1037         Reviewed by Mihai Parparita.
1038
1039         Add an option to new-run-webkit-httpd to allow overriding the location of LayoutTests directory
1040         https://bugs.webkit.org/show_bug.cgi?id=56884
1041
1042         This option will be utilized by Chromium's ui_tests to allow
1043         referencing js-test-resources from a layout test over HTTP.
1044
1045         * Scripts/new-run-webkit-httpd:
1046         Added --layout_tests_dir option.
1047         * Scripts/webkitpy/layout_tests/port/http_server.py:
1048         Plumbed through as layout_tests_dir param.
1049
1050 2011-03-23  Dirk Pranke  <dpranke@chromium.org>
1051
1052         Reviewed by Mihai Parparita.
1053
1054         new-run-webkit-tests: run tests in ascending alphabetical order per
1055         dir. This is a second attempt at the fix; the first attempt, in 
1056         r81597, broke the behavior on the old-inline and old-threads
1057         worker models.
1058
1059         https://bugs.webkit.org/show_bug.cgi?id=56760
1060
1061         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1062         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1063         * Scripts/webkitpy/layout_tests/port/test.py:
1064         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1065
1066 2011-03-23  Mario Sanchez Prada  <msanchez@igalia.com>
1067
1068         Reviewed by Martin Robinson.
1069
1070         [GTK] GTK's DRT to ouput detail's string for the 'property-change' signal
1071         https://bugs.webkit.org/show_bug.cgi?id=56953
1072
1073         Print the string for the detail of 'property-change' signal.
1074
1075         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
1076         (axObjectEventListener): Print the detail string.
1077
1078 2011-03-23  Yury Semikhatsky  <yurys@chromium.org>
1079
1080         Reviewed by Pavel Feldman.
1081
1082         [V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
1083         https://bugs.webkit.org/show_bug.cgi?id=56843
1084
1085         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1086         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1087
1088 2011-03-22  Eric Seidel  <eric@webkit.org>
1089
1090         Reviewed by Adam Barth.
1091
1092         Teach update-webkit about gyp
1093         https://bugs.webkit.org/show_bug.cgi?id=56881
1094
1095         This makes it possible for someone who builds from Xcode
1096         to just run update-webkit --gyp and have the project files
1097         generated after update automatically.
1098
1099         I also added a stand-alone "generate-project-files" script
1100         wrapping Source/gyp/configure.  This makes running gyp simpler
1101         since most people will not have gyp or Source/gyp in their path.
1102
1103         * Scripts/build-webkit:
1104         * Scripts/generate-project-files: Added.
1105         * Scripts/update-webkit:
1106
1107 2011-03-22  Anton D'Auria  <adauria@apple.com>
1108
1109         Reviewed by Alexey Proskuryakov.
1110
1111         Add +[WebApplicationCache getOriginsWithCache]
1112         https://bugs.webkit.org/show_bug.cgi?id=56722
1113
1114         * DumpRenderTree/LayoutTestController.cpp:
1115         (originsWithApplicationCacheCallback):
1116         (LayoutTestController::staticFunctions):
1117         * DumpRenderTree/LayoutTestController.h:
1118         * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
1119         (LayoutTestController::originsWithApplicationCache):
1120         * DumpRenderTree/chromium/LayoutTestController.h:
1121         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
1122         (LayoutTestController::originsWithApplicationCache):
1123         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Pass array of origin's database identifiers.
1124         (originsArrayToJS): Helper function for converting array of WebSecurityOrigins to a JS array of origin identifiers.
1125         (LayoutTestController::originsWithApplicationCache):
1126         (LayoutTestController::originsWithLocalStorage):
1127         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
1128         (LayoutTestController::originsWithApplicationCache):
1129         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1130         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
1131         (LayoutTestController::originsWithApplicationCache):
1132         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Added stub.
1133         (LayoutTestController::originsWithApplicationCache):
1134
1135 2011-03-22  Eric Seidel  <eric@webkit.org>
1136
1137         Reviewed by Adam Barth.
1138
1139         Add support to build-webkit for building with gyp-generated project files
1140         https://bugs.webkit.org/show_bug.cgi?id=56877
1141
1142         build-webkit is a cesspool.  This change just hacks in --gyp support for Mac.
1143         Eventually we'll want to support gyp-generated projects in a more general manner.
1144
1145         * Scripts/build-webkit:
1146
1147 2011-03-22  David Kilzer  <ddkilzer@apple.com>
1148
1149         <http://webkit.org/b/56781> Add --dsym switch to enable dsym generation when building with Xcode
1150
1151         Reviewed by Joseph Pecoraro.
1152
1153         * Scripts/build-webkit: Updated usage statement to include
1154         --dsym.
1155         * Scripts/webkitdirs.pm: Added $generateDsym variable.
1156         (generateDsym): Added. Call determineGenerateDsym() and
1157         return $generateDsym.
1158         (determineGenerateDsym): Added.  Parse @ARGV for --dsym and set
1159         $generateDsym.
1160         (argumentsForXcode): Added.  Returns additional arguments for
1161         xcodebuild based on command-line switches.
1162         (XcodeOptions): Updated to include argumentsForXcode() in the
1163         array returned.
1164
1165 2011-03-22  Adam Roben  <aroben@apple.com>
1166
1167         Make Leopard Debug bots and Windows XP Debug (Tests) core builders
1168
1169         These bots are consistently green again.
1170
1171         Fixes <http://webkit.org/b/56830> Leopard Debug bots and Windows XP Debug (Tests) should be
1172         core builders
1173
1174         Rubber-stamped by Antti Koivisto.
1175
1176         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1177         (BuildBot.__init__): Loosened the regexps for Leopard and Windows.
1178
1179         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1180         (BuildBotTest.test_builder_name_regexps): Updated expectations.
1181
1182 2011-03-21  Sheriff Bot  <webkit.review.bot@gmail.com>
1183
1184         Unreviewed, rolling out r81597.
1185         http://trac.webkit.org/changeset/81597
1186         https://bugs.webkit.org/show_bug.cgi?id=56801
1187
1188         Change results in lots of unexpected flaky on the dashboard.
1189         (Requested by pfeldman on #webkit).
1190
1191         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1192         * Scripts/webkitpy/layout_tests/port/test.py:
1193         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1194
1195 2011-03-21  Sam Weinig  <sam@webkit.org>
1196
1197         Fix failing tests on the WebKit2 bots.
1198
1199         * WebKitTestRunner/TestController.cpp:
1200         (WTR::TestController::resetStateToConsistentValues):
1201
1202 2011-03-21  Daniel Sievers  <sievers@google.com>
1203
1204         Reviewed by Simon Fraser.
1205
1206         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
1207         https://bugs.webkit.org/show_bug.cgi?id=56139
1208
1209         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1210         (main):
1211         * DumpRenderTree/chromium/LayoutTestController.cpp:
1212         (LayoutTestController::LayoutTestController):
1213         (LayoutTestController::layerTreeAsText):
1214         * DumpRenderTree/chromium/LayoutTestController.h:
1215         (LayoutTestController::setShowDebugLayerTree):
1216         * DumpRenderTree/chromium/TestShell.cpp:
1217         (TestShell::runFileTest):
1218         (TestShell::dump):
1219         * DumpRenderTree/chromium/TestShell.h:
1220         (TestParams::TestParams):
1221
1222 2011-03-21  Adam Roben  <aroben@apple.com>
1223
1224         Try again to get buildbot to show run-javascriptcore-tests's actual.html as an HTML file
1225
1226         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
1227         output as plain text
1228
1229         Reviewed by David Kilzer.
1230
1231         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1232         (RunJavaScriptCoreTests): List actual.html as one of our log files so it will get uploaded
1233         to the master.
1234         (RunJavaScriptCoreTests.commandComplete): Reading the actual.html file here won't work,
1235         since we're running on the build master, not the slave. Instead, turn the raw source of
1236         actual.html which the build slave uploaded into an HTML log.
1237
1238 2011-03-21  Dirk Pranke  <dpranke@chromium.org>
1239
1240         Reviewed by Mihai Parparita.
1241
1242         new-run-webkit-tests: run tests in ascending alphabetical order per dir
1243         https://bugs.webkit.org/show_bug.cgi?id=56760
1244
1245         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1246         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1247         * Scripts/webkitpy/layout_tests/port/test.py:
1248
1249 2011-03-21  Leandro Gracia Gil  <leandrogracia@chromium.org>
1250
1251         Reviewed by Steve Block.
1252
1253         Media Stream API patch 0: adding compilation guards.
1254         https://bugs.webkit.org/show_bug.cgi?id=56458
1255
1256         Adding options to enable the media stream API feature in Chromium.
1257
1258         * Scripts/build-webkit:
1259
1260 2011-03-21  Qi Zhang  <qi.2.zhang@nokia.com>
1261
1262         Reviewed by Laszlo Gombos.
1263
1264         [Qt] Add a command line option to capture stdout and stderr for DumpRenderTree
1265         https://bugs.webkit.org/show_bug.cgi?id=56323
1266
1267         Using freopen to redirect STDOUT and STDERR when DumpRenderTree command line provide 
1268         "--stdout" or "--stderr" option.
1269
1270         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1271         (WebCore::DumpRenderTree::~DumpRenderTree):
1272         (WebCore::DumpRenderTree::processArgsLine):
1273         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
1274         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1275         (WebCore::DumpRenderTree::setRedirectOutputFileName):
1276         (WebCore::DumpRenderTree::setRedirectErrorFileName):
1277         * DumpRenderTree/qt/main.cpp:
1278         (isOption):
1279         (takeOptionValue):
1280         (printUsage):
1281         (main):
1282
1283 2011-03-21  Adam Roben  <aroben@apple.com>
1284
1285         Fix exceptions on the buildbot due to my last change
1286
1287         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1288         (RunJavaScriptCoreTests.commandComplete): Catch exceptions due to actual.html not existing.
1289
1290 2011-03-21  Adam Roben  <aroben@apple.com>
1291
1292         Teach buildbot to treat run-javascriptcore-tests's actual.html as an HTML file
1293
1294         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
1295         output as plain text
1296
1297         Reviewed by Darin Adler.
1298
1299         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1300         (RunJavaScriptCoreTests): Removed the logfiles variable, which can only handle plaintext
1301         logs.
1302         (RunJavaScriptCoreTests.commandComplete): Use the addHTMLLog method to upload actual.html to
1303         the build master. This will correctly treat it as HTML.
1304
1305 2011-03-20  Bill Budge  <bbudge@chromium.org>
1306
1307         Reviewed by Adam Barth.
1308
1309         Rename ThreadSafeShared to ThreadSafeRefCounted
1310         https://bugs.webkit.org/show_bug.cgi?id=56714
1311
1312         No new tests. Exposes no new functionality.
1313
1314         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeRefCounted.h: Copied from DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h.
1315         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
1316         * Scripts/do-webcore-rename:
1317
1318 2011-03-19  Anton D'Auria  <adauria@apple.com>
1319
1320         Reviewed by Dan Bernstein.
1321
1322         Add stub to LayoutTestControllerGtk.cpp to fix GTK build
1323         https://bugs.webkit.org/show_bug.cgi?id=56719
1324
1325         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Adding stub.
1326         (LayoutTestController::clearApplicationCacheForOrigin):
1327
1328 2011-03-19  Anton D'Auria  <adauria@apple.com>
1329
1330         Reviewed by Alexey Proskuryakov.
1331
1332         ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
1333         https://bugs.webkit.org/show_bug.cgi?id=56415
1334
1335         * DumpRenderTree/LayoutTestController.cpp:
1336         (clearApplicationCacheForOriginCallback):
1337         (LayoutTestController::staticFunctions):
1338         * DumpRenderTree/LayoutTestController.h:
1339         * DumpRenderTree/chromium/LayoutTestController.cpp: Adding stubs.
1340         (LayoutTestController::LayoutTestController):
1341         (LayoutTestController::clearAllApplicationCaches):
1342         (LayoutTestController::clearApplicationCacheForOrigin): 
1343         * DumpRenderTree/chromium/LayoutTestController.h:
1344         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Adding stub.
1345         (LayoutTestController::clearApplicationCacheForOrigin):
1346         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Adding stub.
1347         (LayoutTestController::clearApplicationCacheForOrigin):
1348         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1349         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Adding stub.
1350         (LayoutTestController::clearApplicationCacheForOrigin):
1351         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Adding stub.
1352         (LayoutTestController::clearApplicationCacheForOrigin):
1353
1354 2011-03-18  Dan Bernstein  <mitz@apple.com>
1355
1356         Revised build fix for r81135.
1357
1358         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1359         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1360
1361 2011-03-18  Adam Roben  <aroben@apple.com>
1362
1363         Windows build fix
1364
1365         * WebKitTestRunner/config.h: Add a missing #endif.
1366
1367 2011-03-18  Andreas Kling  <kling@webkit.org>
1368
1369         Unbreak Qt build after r81494.
1370
1371         * WebKitTestRunner/qt/TestInvocationQt.cpp:
1372         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1373
1374 2011-03-18  Sam Weinig  <sam@webkit.org>
1375
1376         Fix windows build. This was really Adam Roben's fault. I swear!
1377
1378         * WebKitTestRunner/config.h:
1379
1380 2011-03-18  Sam Weinig  <sam@webkit.org>
1381
1382         Reviewed by Adam Roben.
1383
1384         Pixel tests don't work in WebKitTestRunner on Windows
1385         https://bugs.webkit.org/show_bug.cgi?id=56630
1386
1387         Cross-platformize (Mac and Windows CG) the pixel dumping code in WebKitTestRunner to use WebKit2
1388         built-in snapshotting instead of using the window server on the Mac.
1389
1390         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1391         (WTR::InjectedBundle::InjectedBundle):
1392         (WTR::InjectedBundle::didReceiveMessage):
1393         (WTR::InjectedBundle::beginTesting):
1394         (WTR::InjectedBundle::done):
1395         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1396         (WTR::InjectedBundle::setPixelResult):
1397         (WTR::InjectedBundle::shouldDumpPixels):
1398         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1399         (WTR::InjectedBundlePage::dump):
1400         Take the snapshot in the bundle and send it to the UIProcess for dumping.
1401
1402         * WebKitTestRunner/TestInvocation.cpp:
1403         (WTR::TestInvocation::invoke):
1404         (WTR::TestInvocation::dump):
1405         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1406         * WebKitTestRunner/TestInvocation.h:
1407         * WebKitTestRunner/cg: Added.
1408         * WebKitTestRunner/cg/TestInvocationCG.cpp: Copied from WebKitTestRunner/mac/TestInvocationMac.mm.
1409         (WTR::createCGContextFromImage):
1410         (WTR::computeMD5HashStringForContext):
1411         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1412         * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
1413         Making pixel dumping code shared for CG ports. Also use the WTF/MD5 instead of platform specific code.
1414
1415         * WebKitTestRunner/win/TestInvocationWin.cpp:
1416         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1417         Keep stub for Cairo build.
1418
1419         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Added.
1420         Add CG configuration.
1421
1422         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1423         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1424         Add new files.
1425
1426 2011-03-18  Adam Roben  <aroben@apple.com>
1427
1428         Don't allow Leaks Viewer's vertical scrollbar to cover up long function names
1429
1430         Rubber-stamped by Simon Fraser.
1431
1432         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
1433         (.data-grid .data-container): Use overflow-y:auto instead of the Inspector's default
1434         overflow-y:overlay so that the scrollbar doesn't overlay the content.
1435
1436 2011-03-18  Adam Roben  <aroben@apple.com>
1437
1438         Don't ellipsize long or indented function names in Leaks Viewer
1439
1440         Fixes <http://webkit.org/b/56037> Leaks viewer needs horizontal
1441         scrollbar
1442
1443         Reviewed by Simon Fraser.
1444
1445         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
1446         (.data-grid .data-container):
1447         (.data-grid td > div, .data-grid th > div):
1448         Allow the contents to extend to the right.
1449
1450 2011-03-18  Adam Roben  <aroben@apple.com>
1451
1452         Fix some leaks in DRT seen on the leaks bot
1453
1454         Fixes <http://webkit.org/b/56638> addURLToRedirectCallback and
1455         setWillSendRequestClearHeaderCallback in DRT are leaky
1456
1457         Reviewed by Alexey Proskuryakov.
1458
1459         * DumpRenderTree/ForwardingHeaders/wtf/OwnArrayPtr.h: Added.
1460
1461         * DumpRenderTree/LayoutTestController.cpp:
1462         (addURLToRedirectCallback):
1463         (setWillSendRequestClearHeaderCallback):
1464         Use OwnArrayPtr to cause the strings to be deleted.
1465
1466 2011-03-18  Adam Roben  <aroben@apple.com>
1467
1468         Fix a NSURLCredential leak seen on the leaks bot
1469
1470         Fixes <http://webkit.org/b/56637> -[SynchronousLoader
1471         connection:didReceiveAuthenticationChallenge:] is leaky
1472
1473         Reviewed by John Sullivan.
1474
1475         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1476         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]): Use a RetainPtr to
1477         cause the NSURLCredential to be released.
1478
1479 2011-03-18  John Knottenbelt  <jknotten@chromium.org>
1480
1481         Unreviewed.
1482
1483         Remove unnecessary brackets around my email address.
1484
1485         * Scripts/webkitpy/common/config/committers.py:
1486
1487 2011-03-18  Adam Roben  <aroben@apple.com>
1488         
1489         Remove some files I accidentally added in r81454
1490
1491         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Removed.
1492         * WebKitTestRunner/cg/TestInvocationCG.cpp: Removed.
1493
1494 2011-03-18  Adam Roben  <aroben@apple.com>
1495
1496         Ignore an NSNumberFormatter leak on SnowLeopard
1497
1498         * Scripts/old-run-webkit-tests:
1499         (countAndPrintLeaks): Ignore leaks in -[NSNumberFormatter
1500         getObjectValue:forString:errorDescription:].
1501
1502 2011-03-18  Adam Roben  <aroben@apple.com>
1503
1504         Fix a leak beneath LayoutTestController::authenticateSession seen on the bots
1505
1506         Rubber-stamped by Mark Rowe.
1507
1508         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1509         (LayoutTestController::authenticateSession): Use a RetainPtr to cause the NSURLRequest to be
1510         released.
1511
1512 2011-03-17  Adam Roben  <aroben@apple.com>
1513
1514         Address a review comment I missed in r81445
1515
1516         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
1517         (LeaksParserWorker.prototype._parseLeaks): Anchor the RegExp used to find the number of
1518         leaked bytes to speed up searching on long lines.
1519
1520 2011-03-17  Adam Roben  <aroben@apple.com>
1521
1522         Mark leaky builds orange, even if all regression tests passed
1523
1524         Fixes <http://webkit.org/b/56609> SnowLeopard Intel Leaks bot appears green on
1525         build.webkit.org when all tests pass even though there are still leaks
1526
1527         Reviewed by Dan Bernstein.
1528
1529         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1530         (RunWebKitLeakTests): Set the warnOnWarnings property to True so that the entire build will
1531         be marked orange if this build step generates warnings.
1532
1533 2011-03-17  Adam Roben  <aroben@apple.com>
1534
1535         Allow values in Leaks Viewer to be shown as percentages
1536
1537         Double-clicking on a column will toggle between showing percentages and showing real values.
1538
1539         Fixes <http://webkit.org/b/56628> Would like to view values as percentages of the total
1540         number of leaked bytes in Leaks Viewer
1541
1542         Reviewed by Joe Pecoraro.
1543
1544         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
1545         (LeaksParserWorker.prototype._incorporateLeaks): Calculate the (never-shown) top-level
1546         node's totalTime, which is used in calculating percentages.
1547
1548         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
1549         (monkeyPatchInspectorObjects): Only format values as bytes if we aren't supposed to be
1550         showing them as percentages.
1551
1552 2011-03-17  Adam Roben  <aroben@apple.com>
1553
1554         Show the number of leaked bytes, not just leaked allocations, in Leaks Viewer
1555
1556         The Self and Total columns now report the number of leaked bytes. The new Calls column shows
1557         the number of leaked allocations. And the new Average column shows the average number of
1558         leaked bytes per call.
1559
1560         Fixes <http://webkit.org/b/56344> Leaks Viewer should show how many bytes were leaked, not
1561         just how many allocations
1562
1563         Reviewed by Joe Pecoraro.
1564
1565         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
1566         (LeaksParserWorker.prototype._parseLeaks): Parse the number of leaked bytes from the "Leak:"
1567         line and store it with the leak stack.
1568         (LeaksParserWorker.prototype._createNode): Initialize the averageTime and numberOfCalls
1569         properties.
1570         (LeaksParserWorker.prototype._incorporateLeaks): Updated to get the stack from the .stack
1571         property, and changed to store the number of leaked bytes in .selfTime/.totalTime.
1572         .numberOfCalls now holds the number of leaked allocations.
1573
1574         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
1575         (Preferences): Set samplingCPUProfiler to false so that the Average and Calls columns will
1576         appear.
1577         (monkeyPatchInspectorObjects): Format the values as bytes.
1578
1579 2011-03-17  Adam Roben  <aroben@apple.com>
1580
1581         Make Leaks Viewer able to count leaks in builds that didn't fail any regression tests
1582
1583         Fixes <http://webkit.org/b/56626> Leaks Viewer omits recent builds which didn't fail any
1584         regression tests
1585
1586         Reviewed by James Robinson.
1587
1588         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1589         (RecentBuildsLoader.prototype.start): Get the number of leaks out of the "text" array, which
1590         is always populated, even when all regression tests pass.
1591
1592 2011-03-10  Hayato Ito  <hayato@chromium.org>
1593
1594         Reviewed by Tony Chang.
1595
1596         Add a check logic for reftests in case that a reftest is marked AS REBASELINE.
1597
1598         https://bugs.webkit.org/show_bug.cgi?id=56076
1599
1600         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1601
1602 2011-03-17  Adam Roben  <aroben@apple.com>
1603
1604         Skip a compositing-sensitive test when accelerated compositing is disabled
1605
1606         Reviewed by Sam Weinig.
1607
1608         * Scripts/old-run-webkit-tests: Skip media/media-document-audio-repaint.html when
1609         accelerated compositing is disabled.
1610
1611 2011-03-17  Adam Roben  <aroben@apple.com>
1612
1613         Start using PlatformSpecificScheduler for the Mac builders
1614
1615         The current set of file/directory patterns should work for Mac builders. We may discover
1616         that there are more files and directories we can exclude from the Mac builds, but they can
1617         be added later.
1618
1619         Fixes <http://webkit.org/b/56593> Mac builders do lots of unnecessary builds
1620
1621         Reviewed by Mark Rowe.
1622
1623         * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the Mac builders into two
1624         PlatformSpecificSchedulers: one for Leopard, and one for SnowLeopard.
1625
1626         * Scripts/webkitpy/common/config/build.py:
1627         (_should_file_trigger_build): Allow "mac-leopard" and "mac-snowleopard" platforms, and
1628         cleaned up patterns a little bit.
1629
1630         * Scripts/webkitpy/common/config/build_unittest.py:
1631         (ShouldBuildTest): Fixed some expected results.
1632         (ShouldBuildTest.test_should_build): Start testing "mac-leopard" and "mac-snowleopard"
1633         platforms.
1634
1635 2011-03-17  Jeff Miller  <jeffm@apple.com>
1636
1637         Use a consistent set of file patterns in the svn:ignore property for all .xcodeproj directories, specifically:
1638         
1639         *.mode*
1640         *.pbxuser
1641         *.perspective*
1642         project.xcworkspace
1643         xcuserdata
1644
1645         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
1646         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
1647         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
1648         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
1649         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
1650
1651 2011-03-17  Adam Roben  <aroben@apple.com>
1652
1653         Make old-run-webkit-tests pick up mac-wk2 results when running in WebKit2 mode on Windows
1654
1655         Fixes <http://webkit.org/b/56563> Running WebKit2 tests on Windows should use results from
1656         mac-wk2
1657
1658         Reviewed by Anders Carlsson.
1659
1660         * Scripts/old-run-webkit-tests:
1661         (expectedDirectoryForTest): Clean up the code to search in extra Mac platform result
1662         directories on Windows. Add mac-wk2 to the set of extra platforms we look in on Windows when
1663         we're running in WebKit2 mode.
1664
1665 2011-03-17  Mikhail Naganov  <mnaganov@chromium.org>
1666
1667         Reviewed by Yury Semikhatsky.
1668
1669         Web Inspector: Clean up Inspector strings.
1670         https://bugs.webkit.org/show_bug.cgi?id=56557
1671
1672         Modify the script to deal correctly with "\xNN" escapes, and to
1673         check strings in Chromium's DevTools.js.
1674
1675         * Scripts/check-inspector-strings:
1676
1677 2011-03-17  Keith Kyzivat  <keith.kyzivat@nokia.com>
1678
1679         Reviewed by Benjamin Poulain.
1680
1681         Update autoinstall to install mechanize 0.2.4
1682         https://bugs.webkit.org/show_bug.cgi?id=56499
1683
1684         Newer versions of mechanize support HTTPS proxies, which is necessary
1685         for people using webkit-patch behind firewalls.
1686
1687         * Scripts/webkitpy/common/system/autoinstall.py:
1688         * Scripts/webkitpy/thirdparty/__init__.py:
1689
1690 2011-03-16  Sam Weinig  <sam@webkit.org>
1691
1692         Reviewed by Adam Roben.
1693
1694         REGRESSION (r81084): media/invalid-media-url-crash.html and editing/execCommand/indent-paragraphs.html failing on WebKit2
1695         https://bugs.webkit.org/show_bug.cgi?id=56541
1696
1697         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1698         (WTR::InjectedBundlePage::willSendRequestForFrame):
1699         Check for an empty host in addition to a null host.  This bug was introduced
1700         when porting off of the KURL code and onto the WKURLRef version.
1701
1702 2011-03-16  Sam Weinig  <sam@webkit.org>
1703
1704         Reviewed by Adam Roben.
1705
1706         Add Lucas Forschler to the list of WebKit committers.
1707
1708         * Scripts/webkitpy/common/config/committers.py:
1709
1710 2011-03-16  Sam Weinig  <sam@webkit.org>
1711
1712         Reviewed upon and dictated through Adam Roben.
1713
1714         Escape crashing function names in results.html. This fixes an issue
1715         when a crash involves a type with templates.
1716
1717         * Scripts/old-run-webkit-tests:
1718
1719 2011-03-16  Daniel Sievers  <sievers@google.com>
1720
1721         Reviewed by James Robinson.
1722
1723         Add setting to always force compositing mode
1724         https://bugs.webkit.org/show_bug.cgi?id=56156
1725
1726         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1727         (main):
1728         * DumpRenderTree/chromium/TestShell.cpp:
1729         (TestShell::TestShell):
1730         (TestShell::resetWebSettings):
1731         * DumpRenderTree/chromium/TestShell.h:
1732         (TestShell::setForceCompositingMode):
1733         * DumpRenderTree/chromium/WebPreferences.cpp:
1734         (WebPreferences::reset):
1735         (WebPreferences::applyTo):
1736         * DumpRenderTree/chromium/WebPreferences.h:
1737
1738 2011-03-15  Hayato Ito  <hayato@chromium.org>
1739
1740         Reviewed by Ojan Vafai.
1741
1742         Ignore files that will be used by reftests in old-run-webkit-tests.
1743
1744         https://bugs.webkit.org/show_bug.cgi?id=55936
1745
1746         * Scripts/old-run-webkit-tests:
1747
1748 2011-03-15  Felipe Oliveira da Silva Netto  <f.dachshund@gmail.com>
1749
1750         Reviewed by Adam Roben.
1751
1752         Function relativeScriptsDir doesn't return the correct relative
1753         Scripts directory.
1754
1755         * Scripts/webkitdirs.pm:
1756         (relativeScriptsDir): Ensure we use the directory that contains
1757         webkitdirs.pm, not the one that contains the original script that
1758         was invoked.
1759
1760 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
1761
1762         [wx] Build fixes for long linker commands on Win and method return error, plus a Mac
1763         fix to link against the Security framework after recent WebKitSystemInterface changes.
1764
1765         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1766         (LayoutTestController::originsWithLocalStorage):
1767         * wx/build/settings.py:
1768         * wx/build/waf_extensions.py:
1769
1770 2011-03-15  Sam Weinig  <sam@webkit.org>
1771
1772         Reviewed by Darin Adler.
1773
1774         Add script to convert a patch to a prettypatch and show in the default browser
1775         https://bugs.webkit.org/show_bug.cgi?id=56416
1776
1777         This can be used either like
1778             $ svn-create-patch | show-pretty-diff
1779         or
1780             $ show-pretty-diff patch.diff
1781
1782         * Scripts/show-pretty-diff: Added.
1783
1784 2011-03-15  Brian Weinstein  <bweinstein@apple.com>
1785
1786         Rubber-stamped by Adam Roben.
1787
1788         Adding myself as a reviewer.
1789
1790         * Scripts/webkitpy/common/config/committers.py:
1791
1792 2011-03-15  Anders Carlsson  <andersca@apple.com>
1793
1794         Try to fix the Windows build.
1795
1796         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
1797         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
1798
1799 2011-03-15  Anders Carlsson  <andersca@apple.com>
1800
1801         Reviewed by Sam Weinig.
1802
1803         Make sure that NP_Shutdown is always the last NPP function called
1804         https://bugs.webkit.org/show_bug.cgi?id=56391
1805
1806         Add a test that times out if an NP_Deallocate object is called after NP_Shutdown.
1807
1808         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1809         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1810         (PluginTest::PluginTest):
1811         (PluginTest::NP_Shutdown):
1812         (PluginTest::registerNPShutdownFunction):
1813         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1814         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp: Added.
1815         (NPDeallocateCalledBeforeNPShutdown::NPDeallocateCalledBeforeNPShutdown):
1816         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
1817         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::hasProperty):
1818         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::getProperty):
1819         (NPDeallocateCalledBeforeNPShutdown::NPP_New):
1820         (NPDeallocateCalledBeforeNPShutdown::NPP_GetValue):
1821         (NPDeallocateCalledBeforeNPShutdown::shutdown):
1822         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1823         (NP_Shutdown):
1824         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1825         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1826         * GNUmakefile.am:
1827
1828 2011-03-15  Ilya Sherman  <isherman@chromium.org>
1829
1830         Reviewed by Tony Chang.
1831
1832         Autofilled form elements are assigned fixed background color but not text color
1833         https://bugs.webkit.org/show_bug.cgi?id=48382
1834
1835         * DumpRenderTree/LayoutTestController.cpp:
1836         (setAutofilledCallback): Added.
1837         (LayoutTestController::staticFunctions):
1838         * DumpRenderTree/LayoutTestController.h:
1839         * DumpRenderTree/chromium/LayoutTestController.cpp:
1840         (LayoutTestController::LayoutTestController):
1841         (LayoutTestController::setAutofilled): Added.
1842         * DumpRenderTree/chromium/LayoutTestController.h:
1843         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1844         (LayoutTestController::setAutofilled): Added.
1845         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1846         (LayoutTestController::setAutofilled): Added.
1847         (LayoutTestController::setValueForUser): Style tweak.
1848         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1849         (LayoutTestController::setAutofilled): Added (stub).
1850         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1851         (LayoutTestController::setAutofilled): Added (stub).
1852
1853 2011-03-15  Dan Bernstein  <mitz@apple.com>
1854
1855         Build fix after r81135.
1856
1857         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
1858
1859 2011-03-15  Dan Bernstein  <mitz@apple.com>
1860
1861         Build fix after r81135.
1862
1863         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1864         * WebKitTestRunner/mac/TestControllerMac.mm:
1865         * WebKitTestRunner/mac/TestInvocationMac.mm:
1866         * WebKitTestRunner/mac/main.mm:
1867
1868 2011-03-15  Balazs Kelemen  <kbalazs@webkit.org>
1869
1870         Reviewed by Adam Barth.
1871
1872         REGRESSION(80977): breaks Qt ARMv7 Linux Release bot
1873         https://bugs.webkit.org/show_bug.cgi?id=56349
1874
1875         * QtTestBrowser/QtTestBrowser.pro: Link against fontconfig
1876         on platforms where we use it. Copied from DumpRenderTree.pro.
1877
1878 2011-03-15  Dan Bernstein  <mitz@apple.com>
1879
1880         Build fix after r81135.
1881
1882         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
1883         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
1884
1885 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
1886
1887         Reviewed by Darin Adler.
1888
1889         Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
1890         info into the headers rather than in export symbol definition files, but disable it on 
1891         all platforms initially so we can deal with port build issues one port at a time.
1892         
1893         https://bugs.webkit.org/show_bug.cgi?id=27551
1894
1895         * DumpRenderTree/cg/ImageDiffCG.cpp:
1896         * DumpRenderTree/chromium/config.h:
1897         * DumpRenderTree/config.h:
1898         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1899         * TestWebKitAPI/TestWebKitAPIPrefix.h:
1900         * WebKitAPITest/HostWindow.cpp:
1901         * WebKitAPITest/TestsController.cpp:
1902         * WebKitAPITest/config.h: Added.
1903         * WebKitAPITest/main.cpp:
1904         * WebKitAPITest/tests/WebViewDestruction.cpp:
1905         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
1906         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1907         * WebKitTestRunner/InjectedBundle/GCController.cpp:
1908         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1909         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
1910         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1911         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1912         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1913         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
1914         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
1915         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:
1916         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:
1917         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
1918         * WebKitTestRunner/TestController.cpp:
1919         * WebKitTestRunner/TestInvocation.cpp:
1920         * WebKitTestRunner/config.h: Added.
1921         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1922         * WebKitTestRunner/qt/TestControllerQt.cpp:
1923         * WebKitTestRunner/qt/TestInvocationQt.cpp:
1924         * WebKitTestRunner/qt/main.cpp:
1925         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1926         * WebKitTestRunner/win/TestControllerWin.cpp:
1927         * WebKitTestRunner/win/TestInvocationWin.cpp:
1928         * WebKitTestRunner/win/main.cpp:
1929         * wx/build/settings.py:
1930
1931 2011-03-15  Hayato Ito  <hayato@chromium.org>
1932
1933         Reviewed by Shinichiro Hamaji.
1934
1935         [NRWT] Add support for reftests to new-run-webkit-tests.
1936
1937         https://bugs.webkit.org/show_bug.cgi?id=55457
1938
1939         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
1940         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1941         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1942         * Scripts/webkitpy/layout_tests/port/base.py:
1943         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1944         * Scripts/webkitpy/layout_tests/port/test.py:
1945         * Scripts/webkitpy/layout_tests/port/test_files.py:
1946         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1947
1948 2011-03-15  Alejandro G. Castro  <alex@igalia.com>
1949
1950         Reviewed by Martin Robinson.
1951
1952         [GTK] Fix compilation warning after r80892
1953         https://bugs.webkit.org/show_bug.cgi?id=56302
1954
1955         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1956         (LayoutTestController::originsWithLocalStorage):
1957
1958 2011-03-15  Robert Hogan  <robert@webkit.org>
1959
1960         Reviewed by Adam Barth.
1961
1962         Document the qmakearg argument, and hint how to build webkit2 on Qt
1963         https://bugs.webkit.org/show_bug.cgi?id=56326
1964
1965         * Scripts/build-webkit: add --qmakearg to build-webkit --help
1966
1967 2011-03-15  Adam Roben  <aroben@apple.com>
1968
1969         Make Windows 7 Release (Tests) a core builder
1970
1971         We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
1972         give it a few more days of greenness first.
1973
1974         Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
1975
1976         Reviewed by Sam Weinig.
1977
1978         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1979         (BuildBot): Added a regexp to match Windows 7 Release (Tests).
1980
1981         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1982         (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
1983         Updated the core regexps to match the buildbot module. Updated the expected results to match
1984         the current set of core builders.
1985
1986 2011-03-14  Adam Roben  <aroben@apple.com>
1987
1988         Add forgotten file from r81116
1989
1990         * TestWebKitAPI/Configurations/TestWebKitAPICFNetwork.vsprops: Added.
1991
1992 2011-03-14  Sam Weinig  <sam@webkit.org>
1993
1994         Reviewed by Adam Roben.
1995
1996         about:blank fake responses don't get serialized when sent the UIProcess
1997         <rdar://problem/9108119>
1998         https://bugs.webkit.org/show_bug.cgi?id=56357
1999
2000         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: Added.
2001         (TestWebKitAPI::decidePolicyForResponse):
2002         (TestWebKitAPI::TEST):
2003         Add test that loads of about:blank have a response with a MIMEType of text/html.
2004
2005         * TestWebKitAPI/PlatformUtilities.h:
2006         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2007         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
2008         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2009         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
2010         Add helper to get the MIMEType from a WKURLResponse.
2011
2012         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2013         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2014         Add new files.
2015
2016 2011-03-14  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
2017
2018         Reviewed by Kenneth Rohde Christiansen.
2019
2020         [Qt] Command-line options for QGLWidget and WebGL to QtTestBrowser
2021         https://bugs.webkit.org/show_bug.cgi?id=56006
2022
2023         * QtTestBrowser/launcherwindow.cpp:
2024         (LauncherWindow::initializeView):
2025         * QtTestBrowser/main.cpp:
2026         (LauncherApplication::handleUserOptions):
2027
2028 2011-03-14  James Kozianski  <koz@chromium.org>
2029
2030         Reviewed by Ojan Vafai.
2031
2032         Add method to make BuildBot return test outputs
2033         https://bugs.webkit.org/show_bug.cgi?id=54374
2034
2035         The Builder.latest_cached_build will be used by the new rebaseline
2036         script to determine the build to use baselines from.
2037
2038         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2039         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2040
2041 2011-03-14  Adam Roben  <aroben@apple.com>
2042
2043         Test that WKBundlePageCanHandleRequest returns true for empty document URLs
2044
2045         Reviewed by Sam Weinig.
2046
2047         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp: Added.
2048         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Store the result of the test.
2049         (TestWebKitAPI::setInjectedBundleClient): Hook up our callback.
2050         (TestWebKitAPI::TEST): Register "emptyscheme" as an empty document scheme, load a page to
2051         ensure the web process is initialized, then ask the bundle to run the test and assert that
2052         it succeeded.
2053
2054         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp: Added.
2055         (TestWebKitAPI::CanHandleRequestTest::CanHandleRequestTest): Just call up to the base class.
2056         (TestWebKitAPI::canHandleURL): Helper function to test whether WebKit2 claims to be able to
2057         handle a given URL.
2058         (TestWebKitAPI::runTest): Check that empty document URLs can be handled (and that an unknown
2059         URL type cannot be handled).
2060         (TestWebKitAPI::CanHandleRequestTest::didReceiveMessage): Run the test and return the
2061         result.
2062
2063         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2064         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2065         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
2066         Added new files to the project.
2067
2068 2011-03-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2069
2070         Unreviewed, rolling out r81094.
2071         http://trac.webkit.org/changeset/81094
2072         https://bugs.webkit.org/show_bug.cgi?id=56355
2073
2074         Broke the chromium DRT related build. (Requested by dave_levin
2075         on #webkit).
2076
2077         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2078         (main):
2079         * DumpRenderTree/chromium/LayoutTestController.cpp:
2080         (LayoutTestController::LayoutTestController):
2081         (LayoutTestController::layerTreeAsText):
2082         * DumpRenderTree/chromium/LayoutTestController.h:
2083         * DumpRenderTree/chromium/TestShell.cpp:
2084         (TestShell::runFileTest):
2085         (TestShell::dump):
2086         * DumpRenderTree/chromium/TestShell.h:
2087         (TestParams::TestParams):
2088
2089 2011-03-14  Daniel Sievers  <sievers@google.com>
2090
2091         Reviewed by Simon Fraser.
2092
2093         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
2094         https://bugs.webkit.org/show_bug.cgi?id=56139
2095
2096         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2097         (main):
2098         * DumpRenderTree/chromium/LayoutTestController.cpp:
2099         (LayoutTestController::LayoutTestController):
2100         (LayoutTestController::layerTreeAsText):
2101         * DumpRenderTree/chromium/LayoutTestController.h:
2102         (LayoutTestController::setShowDebugLayerTree):
2103         * DumpRenderTree/chromium/TestShell.cpp:
2104         (TestShell::runFileTest):
2105         (TestShell::dump):
2106         * DumpRenderTree/chromium/TestShell.h:
2107         (TestParams::TestParams):
2108
2109 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
2110
2111         Reviewed by Adam Roben.
2112
2113         [Qt][WK2]Unbreak InjectedBundle on Qt
2114         https://bugs.webkit.org/show_bug.cgi?id=54109
2115
2116         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2117         (WTR::InjectedBundlePage::willSendRequestForFrame): Use new WebKit2
2118         API's instead of KURL to analyze the URL.
2119         * WebKitTestRunner/StringFunctions.h:
2120         (WTR::adoptWK): Moved from InjectedBundlePage.cpp to make it available globally
2121         in the WebKitTestRunner project.
2122         (WTR::toWK): Use adoptWK.
2123         (WTR::operator<<): Added helper for printing a WKURL.
2124         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Do not link
2125         against WebCore.
2126
2127 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
2128
2129         Reviewed by Kenneth Rohde Christiansen.
2130
2131         check-webkit-style falsely should not complain about WebKit2 API headers in the Shared directory
2132         https://bugs.webkit.org/show_bug.cgi?id=56321
2133
2134         * Scripts/webkitpy/style/checker.py: Add the patch "Source/WebKit2/Shared/API/c"
2135         to the list of exceptions for WebKit2 C API headers.
2136
2137 2011-03-14  Adam Roben  <aroben@apple.com>
2138
2139         Show the list of recent leaky builds in reverse chronological order
2140
2141         Previously they were being shown in a deterministic but surprising order based on
2142         lexicographically sorting the build offsets (-1, -10, -2, -3...).
2143
2144         Fixes <http://webkit.org/b/56342> Leaks Viewer shows recent builds in a strange order
2145
2146         Reviewed by Darin Adler.
2147
2148         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
2149         (RecentBuildsLoader.prototype.start): Sort the builds by revision before passing them to our
2150         callback.
2151
2152 2011-03-14  Adam Roben  <aroben@apple.com>
2153
2154         Show a list of up to 10 recent leaky builds when Leaks Viewer loads
2155
2156         Fixes <http://webkit.org/b/56043> Leaks Viewer should present a list of recent builds to
2157         analyze
2158
2159         Reviewed by David Kilzer and Joe Pecoraro.
2160
2161         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
2162         (#url-prompt): Made this a bit taller to make room for the list of builds.
2163
2164         (#recent-builds-loading-indicator):
2165         (#recent-builds-list):
2166         Added styles for the build list and loading indicator.
2167
2168         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2169         (LeaksViewer.loaded): Pass the URL from the query through decodeURIComponent before loading
2170         it. This will unescape it.
2171         (LeaksViewer.urlPromptButtonClicked): Moved code from here to _urlChosenFromPrompt.
2172         (LeaksViewer._didLoadRecentBuilds): Added. Stores the builds and updates the prompt.
2173         (LeaksViewer._displayURLPrompt): Start loading the recent leaky builds.
2174         (LeaksViewer._updateURLPrompt): Create a list of the recent leaky builds and add them to the
2175         prompt UI.
2176         (LeaksViewer._urlChosenFromPrompt): Added. Code came from urlPromptButtonClicked. This is
2177         now also used when a recent build is clicked.
2178
2179         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js: Added.
2180         (RecentBuildsLoader): Store the callback.
2181         (RecentBuildsLoader.prototype.start): Load the N most recent builds from the specified
2182         builder. Find the revision number, leak count, and results URL for each one. Pass the
2183         resulting info to our callback.
2184
2185         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
2186         (range): Added this helper function to return an array containing the integers [0, n).
2187
2188         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added
2189         RecentBuildsLoader.js and added text to the prompt UI to show the recent builds.
2190
2191 2011-03-14  Mark Rowe  <mrowe@apple.com>
2192
2193         Reviewed by Adam Roben.
2194
2195         Fix two memory leaks within LayoutTestController's storage support.
2196
2197         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2198         (LayoutTestController::originsWithLocalStorage): Don't leak the JSStringRef that is returned
2199         by JSStringCreateWithCFString.
2200         (LayoutTestController::deleteLocalStorageForOrigin): Don't leak the WebSecurityOrigin that we
2201         allocate.
2202
2203 2011-03-14  Mark Rowe  <mrowe@apple.com>
2204
2205         Reviewed by Oliver Hunt.
2206
2207         <http://webkit.org/b/56304> REGRESSION(r80892): 100,000+ leaks seen on the build bot
2208
2209         * DumpRenderTree/LayoutTestController.cpp:
2210         (LayoutTestController::staticFunctions): Remove duplicate entries.
2211
2212 2011-03-14  Alice Liu  <alice.liu@apple.com>
2213
2214         Reviewed by Dan Bernstein.
2215
2216         DumpRenderTree Perl Support fails to build with ARCHS="i386 x86_64"
2217
2218         * DumpRenderTree/mac/PerlSupport/Makefile:
2219         Add whitespace when joining "-arch" with the architectures passed in as arguments.
2220
2221 2011-03-14  Daniel Bates  <dbates@rim.com>
2222
2223         https://bugs.webkit.org/show_bug.cgi?id=55438
2224         Add double quotes around value of -DCMAKE_WINCE_SDK that I inadvertently did not add
2225         when landing changeset 81041 <http://trac.webkit.org/changeset/81041>.
2226
2227         * Scripts/build-webkit:
2228
2229 2011-03-14  Daniel Bates  <dbates@rim.com>
2230
2231         Reviewed by David Kilzer.
2232
2233         Cleanup: Separate port-specific implementation details from webkitdirs::buildCMakeProject()
2234         https://bugs.webkit.org/show_bug.cgi?id=55438
2235
2236         Separate out the EFL- and WinCE-specific logic from the port-independent logic in
2237         webkitdirs::buildCMakeProject(). Also, remove redundant code for generating the
2238         CMake arguments for feature defines.
2239
2240         * Scripts/build-webkit:
2241           - Added cMakeArgsFromFeatures() to convert the @features array to CMake arguments.
2242           - Modified EFL and WinCE-specific building logic to call buildCMakeProjectOrExit().
2243           - Sorted forward declarations.
2244           - Initialize $makeArgs with the empty string so as to simplify its use in string operations;
2245             Modified call sites as needed.
2246         * Scripts/webkitdirs.pm:
2247           - Added cleanCMakeGeneratedProject() to clean a CMake build.
2248           - Added buildCMakeGeneratedProject() to build using generated build system.
2249           - Added buildCMakeProjectOrExit() which is a facade for building a CMake project.
2250           - Added generateBuildSystemFromCMakeProject() to generate the build system from
2251             a CMake project.
2252           - Removed buildCMakeProject(). This functionality is in buildCMakeProjectOrExit().
2253
2254 2011-03-14  John Knottenbelt  <jknotten@chromium.org>
2255
2256         Reviewed by Steve Block.
2257
2258         Detach Geolocation from Frame when Page destroyed.
2259         https://bugs.webkit.org/show_bug.cgi?id=52877
2260
2261         Extend the layout test controller to expose the number of pending
2262         geolocation requests, so that we can test that the requests have
2263         been cancelled on page close.
2264
2265         * DumpRenderTree/LayoutTestController.cpp:
2266         (numberOfPendingGeolocationPermissionRequestsCallback):
2267         (LayoutTestController::staticFunctions):
2268         * DumpRenderTree/LayoutTestController.h:
2269         * DumpRenderTree/chromium/LayoutTestController.cpp:
2270         (LayoutTestController::LayoutTestController):
2271         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2272         * DumpRenderTree/chromium/LayoutTestController.h:
2273         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2274         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2275         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2276         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2277         * DumpRenderTree/mac/UIDelegate.h:
2278         * DumpRenderTree/mac/UIDelegate.mm:
2279         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
2280         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2281         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2282         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2283         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2284         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2285         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2286         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2287
2288
2289 2011-03-14  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2290
2291         Unreviewed. Modify my email address in committers.py.
2292
2293         * Scripts/webkitpy/common/config/committers.py:
2294
2295 2011-03-13  Joe Wild  <joseph.wild@nokia.com>
2296
2297         Reviewed by Kenneth Rohde Christiansen.
2298
2299         [Qt] QtLauncher does not load the same set of fonts as the DRT
2300         https://bugs.webkit.org/show_bug.cgi?id=34959
2301
2302         This patch adds the option "-use-test-fonts" to the QtTestBrowser.
2303         When this option is used the webkit fonts are loaded the same
2304         as they are in DumpRenderTree.  This option can be used on
2305         QtTestBrowser and run-launcher.  It can only be used
2306         on Linux systems with FcInit and is configured as such.
2307
2308         * QtTestBrowser/launcherwindow.h:
2309         (WindowOptions::WindowOptions):
2310         * QtTestBrowser/main.cpp:
2311         (initWebKitTestFonts):
2312         (launcherMain):
2313         (LauncherApplication::handleUserOptions):
2314
2315 2011-03-12  Dan Bernstein  <mitz@apple.com>
2316
2317         Reviewed by Mark Rowe.
2318
2319         <rdar://problem/8995822> Build DumpRenderTree perl support only for the architectures
2320         DumpRenderTree is being built for.
2321
2322         * DumpRenderTree/mac/PerlSupport/Makefile:
2323
2324 2011-03-12  Dan Bernstein  <mitz@apple.com>
2325
2326         Suggested by Mark Rowe.
2327
2328         * DumpRenderTree/mac/Configurations/Base.xcconfig: Leave C++ exceptions enabled
2329         as they were before r80915.
2330
2331 2011-03-12  Anders Carlsson  <andersca@apple.com>
2332
2333         Reviewed by Sam Weinig.
2334
2335         Should be able to download a PDF to the Downloads folder
2336         https://bugs.webkit.org/show_bug.cgi?id=56256
2337
2338         * MiniBrowser/mac/BrowserWindowController.m:
2339         (-[BrowserWindowController awakeFromNib]):
2340         * WebKitTestRunner/TestController.cpp:
2341         (WTR::TestController::createOtherPage):
2342         (WTR::TestController::initialize):
2343         Update for API changes.
2344
2345 2011-03-11  Anton D'Auria  <adauria@apple.com>
2346
2347         Reviewed and landed by Brady Eidson.
2348
2349         https://bugs.webkit.org/show_bug.cgi?id=51878
2350         Add WebKit1 API to view and delete local storage
2351
2352         Added tests that write to LocalStorage, delete one origin, get list of origins with local storage, delete all origins.
2353
2354         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2355         * DumpRenderTree/LayoutTestController.cpp:
2356         (syncLocalStorageCallback):
2357         (observeStorageTrackerNotificationsCallback):
2358         (deleteAllLocalStorageCallback):
2359         (deleteLocalStorageForOriginCallback):
2360         (originsWithLocalStorageCallback):
2361         (LayoutTestController::staticFunctions):
2362         * DumpRenderTree/LayoutTestController.h:
2363         * DumpRenderTree/StorageTrackerDelegate.h: Added.
2364         * DumpRenderTree/StorageTrackerDelegate.mm: Added.
2365         (-[StorageTrackerDelegate init]):
2366         (-[StorageTrackerDelegate logNotifications:controller:]):
2367         (-[StorageTrackerDelegate originModified:]):
2368         (-[StorageTrackerDelegate dealloc]):
2369         (-[StorageTrackerDelegate setControllerToNotifyDone:]):
2370         * DumpRenderTree/chromium/LayoutTestController.cpp:
2371         (LayoutTestController::LayoutTestController):
2372         (LayoutTestController::deleteAllLocalStorage):
2373         (LayoutTestController::originsWithLocalStorage):
2374         (LayoutTestController::deleteLocalStorageForOrigin):
2375         (observeStorageTrackerNotifications):
2376         (syncLocalStorage):
2377         * DumpRenderTree/chromium/LayoutTestController.h:
2378         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2379         (LayoutTestController::originsWithLocalStorage):
2380         (LayoutTestController::deleteAllLocalStorage):
2381         (LayoutTestController::deleteLocalStorageForOrigin):
2382         (LayoutTestController::observeStorageTrackerNotifications):
2383         (LayoutTestController::syncLocalStorage):
2384         * DumpRenderTree/mac/DumpRenderTree.mm:
2385         (resetDefaultsToConsistentValues):
2386         (allocateGlobalControllers):
2387         (releaseGlobalControllers):
2388         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2389         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2390         (LayoutTestController::syncLocalStorage):
2391         (LayoutTestController::observeStorageTrackerNotifications):
2392         (LayoutTestController::deleteAllLocalStorage):
2393         (LayoutTestController::originsWithLocalStorage):
2394         (LayoutTestController::deleteLocalStorageForOrigin):
2395         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2396         (LayoutTestController::originsWithLocalStorage):
2397         (LayoutTestController::deleteAllLocalStorage):
2398         (LayoutTestController::deleteLocalStorageForOrigin):
2399         (LayoutTestController::observeStorageTrackerNotifications):
2400         (LayoutTestController::syncLocalStorage):
2401         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2402         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2403         (LayoutTestController::clearAllApplicationCaches):
2404         (LayoutTestController::syncLocalStorage):
2405         (LayoutTestController::observeStorageTrackerNotifications):
2406         (LayoutTestController::clearAllDatabases):
2407         (LayoutTestController::deleteAllLocalStorage):
2408         (LayoutTestController::originsWithLocalStorage):
2409         (LayoutTestController::deleteLocalStorageForOrigin):
2410         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2411         (LayoutTestController::syncLocalStorage):
2412         (LayoutTestController::observeStorageTrackerNotifications):
2413         (LayoutTestController::clearAllDatabases):
2414         (LayoutTestController::deleteAllLocalStorage):
2415         (LayoutTestController::originsWithLocalStorage):
2416         (LayoutTestController::deleteLocalStorageForOrigin):
2417
2418 2011-03-11  Jessie Berlin  <jberlin@apple.com>
2419
2420         Reviewed by Adam Roben.
2421
2422         Crash calling WebContext::clearResourceCaches(InMemoryResourceCachesOnly) before the Web
2423         Process has finished launching.
2424         https://bugs.webkit.org/show_bug.cgi?id=56208
2425
2426         * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Added.
2427         (TestWebKitAPI::TEST):
2428         Test that calling WKContextClearResourceCaches works with both options when called before
2429         the Web Process is valid.
2430
2431         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2432         Add the new test.
2433         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2434         Ditto.
2435
2436 2011-03-11  Adam Roben  <aroben@apple.com>
2437
2438         Make it possible to view all leaks from a build at once in Leaks Viewer
2439
2440         You can now give Leaks Viewer the URL of a build results page (e.g.,
2441         <http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r80847%20(15493)/>), and it
2442         will load all the leaks files from that build.
2443
2444         Fixes <http://webkit.org/b/56030> Leaks Viewer: Would like to be able to look at all leaks
2445         files from a particular build at once, rather than one at a time
2446
2447         Reviewed by David Kilzer.
2448
2449         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksLoader.js: Added.
2450         (LeaksLoader): Initialize our properties.
2451         (LeaksLoader.prototype.start): If the URL ends in .txt, assume it's a single leaks file and
2452         load it. Otherwise assume it's a build results page URL and start fetching the leaks files
2453         from that page.
2454         (LeaksLoader.prototype._loadLeaksFiles): Tell our client how many leaks files we're loading
2455         so it can provide feedback. Then load each one and pass it to the client.
2456         (LeaksLoader.prototype._loadLeaksFromResultsPage): Load the HTML of the results page, parse
2457         it into a DOM, pull out all the links to leaks files, and load each one.
2458
2459         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParser.js: Added.
2460         (LeaksParser): Initialize our worker.
2461         (LeaksParser.prototype.addLeaksFile): Tell the worker about the leaks file's contents.
2462
2463         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js: Added.
2464         This code mostly came from Worker.js.
2465         (LeaksParserWorker): Initialize our profile.
2466         (LeaksParserWorker.prototype.addLeaksFile): Parse the leaks file and incorporate it into our
2467         profile.
2468         (LeaksParserWorker.prototype._parseLeaks):
2469         (LeaksParserWorker.prototype._createNode):
2470         (LeaksParserWorker.prototype._incorporateLeaks):
2471         Moved these functions here from LeaksViewer. _incorporateLeaks is essentially just a renamed
2472         version of createProfile which adds to this.profile instead of making a new profile each
2473         time.
2474         (onmessage): Parse the file and send back the new profile.
2475
2476         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
2477         (#loading-indicator):
2478         (#spinner):
2479         (#loading-indicator-label):
2480         Tweaked styles to accomodate a longer label.
2481
2482         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2483         (LeaksViewer.loaded): Set up a loader and parser.
2484
2485         (LeaksViewer.get filesLeftToParse):
2486         (LeaksViewer.set filesLeftToParse):
2487         Added these simple accessors.
2488
2489         (LeaksViewer._didCountLeaksFiles): Callback from LeaksLoader. Stores the count.
2490         (LeaksViewer._didLoadLeaksFile): Callback from LeaksLoader. Passes the file contents off to
2491         the parser.
2492         (LeaksViewer._didParseLeaksFile): Callback from LeaksParser. If all files have been parsed,
2493         tell the ProfilerAgent and mark that we're done loading. (Code came from the old
2494         _loadLeaksFromURL function).
2495         (LeaksViewer._loadLeaksFromURL): Now just calls through to the loader.
2496         (LeaksViewer._loadingIndicatorText): Added. Returns the text that should show up in the
2497         loading indicator, including the number of files being loaded.
2498         (LeaksViewer._loadingStatusChanged): Update the loading indicator's label, too.
2499         (LeaksViewer._updateLoadingIndicatorLabel): Added. Just updates the label!
2500         (LeaksViewer._updateTitle): Moved code to compute the "Loading" text to
2501         _loadingIndicatorText.
2502
2503         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js: Added.
2504         (getResource): Moved here from LeaksViewer.js.
2505
2506         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Subsumed by
2507         LeaksParserWorker.js.
2508
2509         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added new JS
2510         files, added a #loading-indicator-label element, and tweaked the prompt wording.
2511
2512 2011-03-11  Adam Roben  <aroben@apple.com>
2513
2514         Don't trigger a build when build.webkit.org's HTML files are modified
2515
2516         Fixes <http://webkit.org/b/56190> Windows bots shouldn't have built r80848/r80851, but did
2517
2518         Reviewed by Dan Bernstein.
2519
2520         * Scripts/webkitpy/common/config/build.py:
2521         (_should_file_trigger_build): Added build.webkit.org's public_html directory to the list of
2522         directories that shouldn't trigger builds. Re-sorted the list.
2523
2524         * Scripts/webkitpy/common/config/build_unittest.py:
2525         (ShouldBuildTest): Added a test to cover the above change.
2526
2527 2011-03-11  Adam Roben  <aroben@apple.com>
2528
2529         Roll out r80848
2530
2531         It was accidentally committed.
2532
2533         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2534         (LeaksViewer._loadLeaksFromURL):
2535
2536 2011-03-11  Tony Chang  <tony@chromium.org>
2537
2538         Reviewed by Ojan Vafai.
2539
2540         kill hung lighttpd processes on the chromium win bot
2541         https://bugs.webkit.org/show_bug.cgi?id=56152
2542
2543         Sometimes this process doesn't exit and it holds on to
2544         a log file that we can't delete or copy, causing the tests
2545         to go red.
2546
2547         * BuildSlaveSupport/win/kill-old-processes:
2548
2549 2011-03-11  Ilya Sherman  <isherman@chromium.org>
2550
2551         Reviewed by Kent Tamura.
2552
2553         [Chromium] missing HTMLInputElement::setValueForUser() to tests
2554         https://bugs.webkit.org/show_bug.cgi?id=55854
2555
2556         * DumpRenderTree/chromium/LayoutTestController.cpp:
2557         (LayoutTestController::LayoutTestController):
2558         (LayoutTestController::setValueForUser): Added.
2559         * DumpRenderTree/chromium/LayoutTestController.h:
2560
2561 2011-03-10  Peter Kasting  <pkasting@google.com>
2562
2563         Reviewed by Dimitri Glazkov.
2564
2565         Clean up some gross code in TestShellWin.cpp.  No functional change.
2566         https://bugs.webkit.org/show_bug.cgi?id=56048
2567
2568         * DumpRenderTree/chromium/TestShellWin.cpp:
2569         (checkLayoutTestSystemDependencies):
2570
2571 2011-03-10  Keith Kyzivat  <keith.kyzivat@nokia.com>
2572
2573         Reviewed by Laszlo Gombos.
2574
2575         [Qt] Buildfix for platforms where X11 is not available (e.g. Symbian)
2576
2577         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2578         (WTR::activateFonts): Guard X11-specific code with Q_WS_X11.
2579
2580 2011-03-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2581
2582         Reviewed by Kenneth Rohde Christiansen.
2583
2584         [EFL] Make single backing store the default for EWebLauncher
2585         https://bugs.webkit.org/show_bug.cgi?id=55753
2586
2587         Set single backing store the default for EWebLauncher.
2588
2589         * EWebLauncher/main.c:
2590         (main):
2591
2592 2011-03-10  Adam Roben  <aroben@apple.com>
2593
2594         Ignore errors from files being held open when creating a test result archive
2595
2596         Fixes <http://webkit.org/b/55581> Test results don't get uploaded if test-result-archive
2597         fails to delete the results directory
2598
2599         Reviewed by Mark Rowe.
2600
2601         * BuildSlaveSupport/test-result-archive:
2602         (archiveTestResults): Ignore errno 2 when deleting the results directory, since it can be
2603         thrown when a process is holding a file open.
2604
2605 2011-03-10  Sheriff Bot  <webkit.review.bot@gmail.com>
2606
2607         Unreviewed, rolling out r80701.
2608         http://trac.webkit.org/changeset/80701
2609         https://bugs.webkit.org/show_bug.cgi?id=56126
2610
2611         fast/dom/Geolocation/window-close-crash.html fails on Snow
2612         Leopard release builds (Requested by mihaip on #webkit).
2613
2614         * DumpRenderTree/LayoutTestController.cpp:
2615         (LayoutTestController::staticFunctions):
2616         * DumpRenderTree/LayoutTestController.h:
2617         * DumpRenderTree/chromium/LayoutTestController.cpp:
2618         (LayoutTestController::LayoutTestController):
2619         * DumpRenderTree/chromium/LayoutTestController.h:
2620         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2621         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2622         * DumpRenderTree/mac/UIDelegate.h:
2623         * DumpRenderTree/mac/UIDelegate.mm:
2624         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2625         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2626         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2627         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2628
2629 2011-03-10  Philippe Normand  <pnormand@igalia.com>
2630
2631         Reviewed by Gustavo Noronha Silva.
2632
2633         [GTK] run-gtk-tests doesn't fail if a test crashes
2634         https://bugs.webkit.org/show_bug.cgi?id=56089
2635
2636         * Scripts/run-gtk-tests: gtester -k exits with a 0 exit status
2637         even if a test crashes. So run the tests individually and if a
2638         test fails remember its exit code so run-gtk-test fails too, if
2639         required.
2640
2641 2011-01-26  John Knottenbelt  <jknotten@chromium.org>
2642
2643         Reviewed by Dmitry Titov.
2644
2645         Detach Geolocation from Frame when Page destroyed.
2646         https://bugs.webkit.org/show_bug.cgi?id=52877
2647
2648         Extend the layout test controller to expose the number of pending
2649         geolocation requests, so that we can test that the requests have
2650         been cancelled on page close.
2651
2652         * DumpRenderTree/LayoutTestController.cpp:
2653         (numberOfPendingGeolocationPermissionRequestsCallback):
2654         (LayoutTestController::staticFunctions):
2655         * DumpRenderTree/LayoutTestController.h:
2656         * DumpRenderTree/chromium/LayoutTestController.cpp:
2657         (LayoutTestController::LayoutTestController):
2658         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2659         * DumpRenderTree/chromium/LayoutTestController.h:
2660         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2661         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2662         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2663         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2664         * DumpRenderTree/mac/UIDelegate.h:
2665         * DumpRenderTree/mac/UIDelegate.mm:
2666         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
2667         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2668         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2669         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2670         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2671         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2672         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2673         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2674
2675
2676 2011-03-09  Adam Roben  <aroben@apple.com>
2677
2678         Hide Leaks Viewer's URL prompt by default
2679
2680         We will show it as needed. I think I left it visible by default by accident after doing some
2681         testing.
2682
2683         Fixes <http://webkit.org/b/56031> Leaks Viewer: URL prompt overlay shouldn't appear when a
2684         URL is passed as a query parameter, but does
2685
2686         Reviewed by Simon Fraser.
2687
2688         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
2689
2690 2011-03-09  Adam Roben  <aroben@apple.com>
2691
2692         Don't use Element.classList or box-shadow in Leaks Viewer
2693
2694         They aren't supported by Safari 5. Luckily we have substitutes for them!
2695
2696         Fixes <http://webkit.org/b/56035> Leaks viewer doesn't work in Safari 5
2697
2698         Reviewed by Simon Fraser.
2699
2700         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
2701         (#url-prompt): Use -webkit-box-shadow instead of box-shadow.
2702
2703         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2704         (LeaksViewer.urlPromptButtonClicked):
2705         (LeaksViewer._displayURLPrompt):
2706         (LeaksViewer._setLoadingIndicatorHidden):
2707         Use add/removeStyleClass (from utilities.js) instead of Element.classList.
2708
2709 2011-03-09  Adam Roben  <aroben@apple.com>
2710
2711         Add a link to the Leaks Viewer tool on the build.webkit.org homepage
2712
2713         Rubber-stamped by David Kilzer.
2714
2715         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2716
2717 2011-03-09  Adam Roben  <aroben@apple.com>
2718
2719         Add a Leaks Viewer tool to build.webkit.org
2720
2721         This tool parses leaks from the files generated by the leaks bot and displays them in a
2722         view similar to the Web Inspector's Profiles pane (in fact, it uses the Web Inspector's
2723         code).
2724
2725         The URL of the leaks file can be entered in a prompt when the tools is first shown, or can
2726         be passed to the tool via the "url" query parameter.
2727
2728         Only one leaks file can be viewed at a time for now. Only the number of leaks, as opposed to
2729         the number of leaked bytes, is shown. And this tool has made apparent some bugs in the Web
2730         Inspector's Heavy profile view. But it's still pretty useful as-is.
2731
2732         Fixes <http://webkit.org/b/56028> Would like a Shark-like tool for viewing leaks from leak bots
2733
2734         Reviewed by Darin Adler.
2735
2736         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css: Added.
2737         (#url-prompt-container): This is the dark overlay that is shown behind the URL prompt.
2738         (#url-prompt): This is the prompt itself.
2739
2740         (#loading-indicator):
2741         (#loading-indicator > img):
2742         These show a spinner in the bottom-right when we're loading a leaks file.
2743
2744         (.percent-time-status-bar-item): Hide the Percent button since we never want to show leaks
2745         as percentages.
2746
2747         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js: Added.
2748         (LeaksViewer.loaded): Initialize ourselves and start loading the leaks file (or prompt for a
2749         URL if one wasn't given to us as a query parameter).
2750
2751         (LeaksViewer.get loading):
2752         (LeaksViewer.set loading):
2753         (LeaksViewer.get url):
2754         (LeaksViewer.set url):
2755         Pretty simple accessors.
2756
2757         (LeaksViewer.urlPromptButtonClicked): Start loading the URL from the prompt and hide the
2758         prompt.
2759         (LeaksViewer._displayURLPrompt): Show the prompt and focus the URL input.
2760         (LeaksViewer._loadLeaksFromURL): Start fetching the leaks file. When we've retrieved the
2761         file, hand it off to a Web Worker that will parse it into a fake "profile", then hand off
2762         the profile to the Web Inspector code once it's been created.
2763         (LeaksViewer._loadingStatusChanged): Update our loading indicator and title.
2764         (LeaksViewer._setLoadingIndicatorHidden): Simply hide or show the indicator.
2765         (LeaksViewer._updateTitle): Set our title based on our URL and loading status.
2766         (getResource): Helper function to fetch a resource via XHR and pass it to a callback.
2767
2768         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js: Added.
2769         (WebInspector.UIString): Just a simple implementation since this tool isn't localized.
2770         (ProfilerAgent.getProfile): Store the callback.
2771         (ProfilerAgent.profileReady): Call the callback.
2772         (monkeyPatchInspectorObjects): Fix up WebInspector.ProfileDataGridNode to show the self leak
2773         count and total leak counts as real values, not percentages or milliseconds.
2774
2775         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Added.
2776         (onmessage): Create a profile based on the leaks file and pass it back to our caller.
2777         (parseLeaks): Extract call stacks out of a leaks file.
2778         (createNode): Helper function to create a new empty profile node.
2779         (createProfile): Take the leak stacks and turn them into a fake "profile" for consumption by
2780         WebInspector.ProfileView.
2781
2782         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added.
2783
2784 2011-03-09  Dan Bernstein  <mitz@apple.com>
2785
2786         Reviewed by Adam Roben.
2787
2788         Combine multiple --ignore-tests values
2789         https://bugs.webkit.org/show_bug.cgi?id=56016
2790
2791         * Scripts/old-run-webkit-tests:
2792
2793 2011-03-08  Kenji Imasaki  <imasaki@chromium.org>
2794
2795         Reviewed by David Levin.
2796
2797         Adding myself to the committer file.
2798
2799         * Scripts/webkitpy/common/config/committers.py:
2800
2801 2011-03-08  Jessie Berlin  <jberlin@apple.com>
2802
2803         Rubber-stamped by Adam Roben.
2804
2805         Fix two leaks I introduced into the API tests.
2806
2807         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
2808         (TestWebKitAPI::TEST):
2809
2810 2011-03-08  Jessie Berlin  <jberlin@apple.com>
2811
2812         Reviewed by Anders Carlsson.
2813
2814         Crash in CFNetwork visiting google.com
2815         https://bugs.webkit.org/show_bug.cgi?id=55958
2816
2817         Add a test for not trying to copy a null CFURLResponse.
2818
2819         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp: Added.
2820         (TestWebKitAPI::TEST):
2821         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2822
2823 2011-03-08  Hayato Ito  <hayato@chromium.org>
2824
2825         Reviewed by Ojan Vafai.
2826
2827         [NRWT] Renamed a FailureWithType class to a ComparisonTestFailure class.
2828
2829         FailureWithType is a confusing naming because we have removed test_type/* classes in r79840.
2830
2831         https://bugs.webkit.org/show_bug.cgi?id=55450
2832
2833         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2834
2835 2011-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2836
2837         Reviewed by Martin Robinson.
2838
2839         [GTK] Add layoutTestController.setValueForUser() after r80412
2840         https://bugs.webkit.org/show_bug.cgi?id=55862
2841
2842         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2843         (LayoutTestController::setValueForUser): Implement setValueForUser()
2844
2845 2011-03-08  Patrick Gansterer  <paroga@webkit.org>
2846
2847         Reviewed by Adam Barth.
2848
2849         Add script_shell_command to WebKitPort
2850         https://bugs.webkit.org/show_bug.cgi?id=55925
2851
2852         Add a central place where we generate the shell command from the script name.
2853         This function will be used later to detect the correct script interpreter on Win32.
2854
2855         * Scripts/webkitpy/common/config/ports.py:
2856         * Scripts/webkitpy/layout_tests/port/base.py:
2857         * Scripts/webkitpy/tool/steps/abstractstep.py:
2858         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2859
2860 2011-03-07  Ojan Vafai  <ojan@chromium.org>
2861
2862         Reviewed by Adam Barth.
2863
2864         add webkit-patch attach-to-bug for posting to bugzilla from the commandline
2865         https://bugs.webkit.org/show_bug.cgi?id=55749
2866
2867         * Scripts/webkitpy/tool/commands/upload.py:
2868         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2869         * Scripts/webkitpy/tool/steps/__init__.py:
2870         * Scripts/webkitpy/tool/steps/attachtobug.py: Added.
2871         * Scripts/webkitpy/tool/steps/options.py:
2872
2873 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
2874
2875         Reviewed by David Levin.
2876
2877         Add support for DataTransferItems
2878         https://bugs.webkit.org/show_bug.cgi?id=55115
2879
2880         Enable data transfer items in DRT.
2881
2882         * DumpRenderTree/chromium/TestShell.cpp:
2883         (TestShell::TestShell):
2884
2885 2011-03-06  Ojan Vafai  <ojan@chromium.org>
2886
2887         Reviewed by Tony Chang.
2888
2889         [test dashboard] pull treemap files
2890         https://bugs.webkit.org/show_bug.cgi?id=55852
2891
2892         * TestResultServer/handlers/dashboardhandler.py:
2893
2894 2011-03-03  Hayato Ito  <hayato@chromium.org>
2895
2896         Reviewed by Mihai Parparita.
2897
2898         [NRWT] Clear output image file used by DumpRenderTree to make sure the
2899         previous image should not be used in the ChromiumDriver.
2900
2901         Also make sure that output image from the ChromiumDriver should be ''
2902         (empty string) if a test crashes for consistency with the WebKitDriver
2903         implementation.
2904
2905         https://bugs.webkit.org/show_bug.cgi?id=55746
2906
2907         * Scripts/webkitpy/layout_tests/port/chromium.py:
2908
2909 2011-03-07  Zan Dobersek  <zandobersek@gmail.com>
2910
2911         Reviewed by Martin Robinson.
2912
2913         [Gtk] fast/js/navigator-language.html fails locally
2914         https://bugs.webkit.org/show_bug.cgi?id=55880
2915
2916         Add LANG variable to the clean environment when running
2917         old-run-webkit-tests script.
2918
2919         * Scripts/old-run-webkit-tests:
2920
2921 2011-03-07  Tony Chang  <tony@chromium.org>
2922
2923         Reviewed by Mihai Parparita.
2924
2925         [Chromium] Find .checksum files without .pngs and vice-versa
2926         https://bugs.webkit.org/show_bug.cgi?id=55236
2927
2928         * Scripts/find-mismatched-layout-test-results: Added. A script for finding
2929             mismatched results.
2930
2931 2011-03-07  Chris Fleizach  <cfleizach@apple.com>
2932
2933         Reviewed by Beth Dakin.
2934
2935         AX: WK1 needs to use the ScrollView attachment for AXScrollArea, WK2 should not use this element.
2936         https://bugs.webkit.org/show_bug.cgi?id=55706
2937
2938         The rootElement in DRT should point to the scroll view. In WK1, that will be the parent of the rootObject.
2939
2940         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2941         (AccessibilityController::focusedElement):
2942            Remove FIXME comment about caching the focusedElement. In fact, we shouldn't cache this 
2943            because it could change at any time.
2944         (AccessibilityController::rootElement):
2945
2946 2011-03-07  Sam Weinig  <sam@webkit.org>
2947
2948         Reviewed by Anders Carlsson.
2949
2950         Add unableToImplementPolicy callback for WebKit2 policy client
2951         <rdar://problem/9071902>
2952         https://bugs.webkit.org/show_bug.cgi?id=55884
2953
2954         * MiniBrowser/mac/BrowserWindowController.m:
2955         (-[BrowserWindowController awakeFromNib]):
2956         Update policy client initialization struct for new member.
2957
2958 2011-03-07  Sam Weinig  <sam@webkit.org>
2959
2960         Reviewed by Anders Carlsson.
2961
2962         Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
2963         https://bugs.webkit.org/show_bug.cgi?id=55827
2964
2965         * MiniBrowser/mac/BrowserWindowController.m:
2966         (decidePolicyForResponse):
2967         (-[BrowserWindowController awakeFromNib]):
2968         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2969         (TestWebKitAPI::decidePolicyForResponse):
2970         (TestWebKitAPI::TEST):
2971         Update tools for new name.
2972
2973 2011-03-06  Daniel Bates  <dbates@rim.com>
2974
2975         Reviewed by Eric Seidel and David Kilzer.
2976
2977         Fix misspelled word in build-webkit's checkForJavaSDK() and sort forward declarations
2978         https://bugs.webkit.org/show_bug.cgi?id=55503
2979
2980         Fix misspelled word "Dowloads" [sic] in the message printed to standard output
2981         in checkForJavaSDK().
2982
2983         Also, remove extraneous space in function prototype for unlinkZeroFiles.
2984
2985         * Scripts/build-webkit:
2986
2987 2011-03-05  Brian Weinstein  <bweinstein@apple.com>
2988
2989         Reviewed by Sam Weinig.
2990
2991         Fix Web Process crashes caused by https://bugs.webkit.org/show_bug.cgi?id=53919.
2992
2993         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2994         (WTR::InjectedBundlePage::willSendRequestForFrame): Retain the WKURLRequestRef returned
2995             by willSendRequestForFrame. The API expects a retained reference to the URL request.
2996
2997 2011-03-05  Ilya Sherman  <isherman@chromium.org>
2998
2999         Reviewed by Darin Adler.
3000
3001         HTMLInputElement::setValue() should schedule change event when the element is focused
3002         In service of https://code.google.com/p/chromium/issues/detail?id=42716
3003         https://bugs.webkit.org/show_bug.cgi?id=53160
3004
3005         * DumpRenderTree/LayoutTestController.cpp:
3006         (setValueForUserCallback):
3007         (LayoutTestController::staticFunctions):
3008         * DumpRenderTree/LayoutTestController.h:
3009         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3010         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
3011         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3012         (LayoutTestController::setValueForUser): Expose HTMLInputElement::setValueForUser() to tests
3013         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3014         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
3015         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3016         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
3017         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3018         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
3019
3020 2011-03-04  Mark Rowe  <mrowe@apple.com>
3021
3022         Reviewed by Alexey Proskuryakov.
3023
3024         <rdar://problem/9055252> DumpRenderTree is crashing with GuardMalloc
3025
3026         GuardMalloc does not expect the memory containing its malloc_zone_t to ever be read-only.
3027         
3028         * DumpRenderTree/mac/CheckedMalloc.cpp:
3029         (protectionOfRegion): Retrieve the protection flags for the VM region containing the given address.
3030         (makeLargeMallocFailSilently): Save the initial protection flags, temporarily make the region writeable,
3031         and then restore the initial protection flags when we're done.
3032
3033 2011-03-04  Evan Martin  <evan@chromium.org>
3034
3035         Reviewed by Tony Chang.
3036
3037         [gdb] pretty-print KURL in gdb
3038         https://bugs.webkit.org/show_bug.cgi?id=55788
3039
3040         * gdb/webkit.py: extend the pretty-printers to print WTF::CString
3041         and KURLGooglePrivate.  As always, "p/r" can be used to sidestep
3042         pretty-printing.
3043
3044 2011-03-03  Timothy Hatcher  <timothy@apple.com>
3045
3046         Update the tests that use WKPageRunJavaScriptInMainFrame use the WKSerializedScriptValueRef.
3047
3048         Reviewed by Darin Adler.
3049
3050         * TestWebKitAPI/JavaScriptTest.cpp:
3051         (TestWebKitAPI::javaScriptCallback):
3052         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
3053         (TestWebKitAPI::didRunJavaScript):
3054         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3055         (TestWebKitAPI::nullJavaScriptCallback):
3056         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
3057         (TestWebKitAPI::didRunJavaScript):
3058
3059 2011-03-03  Timothy Hatcher  <timothy@apple.com>
3060
3061         Make run-api-tests show failed if a test fails.
3062
3063         https://webkit.org/b/55725
3064
3065         Reviewed by Sam Weinig.
3066
3067         * Scripts/run-api-tests:
3068         (runTest): Remove "my" from the nested $result assignment so the
3069         check outside the condition sees the real result.
3070
3071 2011-03-02  MORITA Hajime  <morrita@google.com>
3072
3073         Reviewed by Kent Tamura.
3074
3075         [Chromium][DRT] WebTask should use webkit_support::TaskAdaptor
3076         https://bugs.webkit.org/show_bug.cgi?id=55434
3077
3078         Changed WebTask to be a subclass of webkit_support::TaskAdaptor
3079         and passed the object webkit_support::PostDelayedTask directly.
3080
3081         Note that the change keeps postTask() as is because it has a
3082         semantics taht webkit_support::PostDelayedTask() has; It jumps to
3083         the main thread.
3084
3085         * DumpRenderTree/chromium/Task.cpp:
3086         (postDelayedTask):
3087         * DumpRenderTree/chromium/Task.h:
3088         (WebTask::Run):
3089
3090 2011-03-03  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
3091
3092         Reviewed by Kenneth Rohde Christiansen.
3093
3094         [QT] Implement mock client-based geolocation for layout testing
3095         https://bugs.webkit.org/show_bug.cgi?id=54334
3096
3097         Implement testing for Client-Based geolocation for QtWebkit.
3098
3099         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3100         (WebCore::DumpRenderTree::DumpRenderTree):
3101         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3102         (LayoutTestController::reset):
3103         (LayoutTestController::setGeolocationPermission):
3104         (LayoutTestController::setMockGeolocationError):
3105         (LayoutTestController::setMockGeolocationPosition):
3106
3107 2011-03-03  Sheriff Bot  <webkit.review.bot@gmail.com>
3108
3109         Unreviewed, rolling out r80237.
3110         http://trac.webkit.org/changeset/80237
3111         https://bugs.webkit.org/show_bug.cgi?id=55714
3112
3113         Windows bots aren't ready to be core (Requested by aroben on
3114         #webkit).
3115
3116         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3117         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3118
3119 2011-03-03  Mihai Parparita  <mihaip@chromium.org>
3120
3121         Reviewed by Tony Chang.
3122
3123         NRWT: AttributeError: TestRunner2 instance has no attribute '_cancel_workers'
3124         https://bugs.webkit.org/show_bug.cgi?id=55694
3125         
3126         Fixes for interruptions in NRWT:
3127         - Make TestRunInterruptedException be pickleable correctly (the base
3128           Exception class defines a __reduce__ that does not include the reason)
3129         - Fix ordering of returned arguments from TestRunner2._run_tests
3130           (interrupted and keyboard_interrupted were reversed)
3131         - Fix cancel_workers callsites (was using old name).
3132         - In handle_exception re-raise actual exception instance that was thrown
3133
3134         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3135         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
3136         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
3137         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3138
3139 2011-03-03  Qi Zhang  <qi.2.zhang@nokia.com>
3140
3141         Unreviewed.
3142
3143         Adding myself as a committer.
3144
3145         * Scripts/webkitpy/common/config/committers.py:
3146
3147 2011-03-03  Tony Gentilcore  <tonyg@chromium.org>
3148
3149         Reviewed by Mihai Parparita.
3150
3151         Teach sheriffbot to answer whois commands
3152         https://bugs.webkit.org/show_bug.cgi?id=55687
3153
3154         * Scripts/webkitpy/tool/bot/irc_command.py:
3155         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3156         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3157
3158 2011-03-03  Victoria Kirst  <vrk@google.com>
3159
3160         Reviewed by Eric Carlson.
3161
3162         Enable media tests in chromium-gpu/test_expectations
3163         https://bugs.webkit.org/show_bug.cgi?id=53608
3164
3165         Add media folder to the list of GPU test paths.
3166
3167         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3168
3169 2011-03-03  Adam Roben  <aroben@apple.com>
3170
3171         Work around a bug in KURL's parsing of Windows-style absolute file: URLs
3172
3173         Fixes <http://webkit.org/b/55674> Many tests fail in WebKit2 mode on Windows due to
3174         incorrect parsing of absolute Windows-style file: URLs
3175
3176         Reviewed by Tim Hatcher.
3177
3178         * WebKitTestRunner/TestInvocation.cpp:
3179         (WTR::createWKURL): Add a "localhost" host to file: URLs we create to work around
3180         <http://webkit.org/b/55683>.
3181
3182 2011-03-03  Tony Chang  <tony@chromium.org>
3183
3184         Reviewed by Dimitri Glazkov.
3185
3186         [chromium] Run kill-old-processes on the chromium-win bot too
3187         https://bugs.webkit.org/show_bug.cgi?id=55630
3188
3189         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3190         * BuildSlaveSupport/win/kill-old-processes: Add wdiff.exe to the kill list.
3191
3192 2011-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3193
3194         Reviewed by Martin Robinson.
3195
3196         [GTK] DRT needs implementation of EventSender.scheduleAsynchronousClick
3197         https://bugs.webkit.org/show_bug.cgi?id=53960
3198
3199         * DumpRenderTree/gtk/EventSender.cpp:
3200         (sendClick):
3201         (scheduleAsynchronousClickCallback):
3202
3203 2011-03-03  Adam Roben  <aroben@apple.com>
3204
3205         Look for Windows-style paths when checking whether a test is an Inspector test
3206
3207         WTR part of <http://webkit.org/b/55672> <rdar://problem/9080867> All inspector tests time
3208         out or crash on Windows 7 Release (WebKit2 Tests)
3209
3210         Reviewed by Darin Adler.
3211
3212         * WebKitTestRunner/TestInvocation.cpp:
3213         (WTR::shouldOpenWebInspector): Also look for backslashes, since that's what we'll get on
3214         Windows.
3215
3216 2011-03-03  Adam Roben  <aroben@apple.com>
3217
3218         Make Windows 7 Release (Tests) a core builder
3219
3220         We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
3221         give it a few more days of greenness first.
3222
3223         Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
3224
3225         Reviewed by Andreas Kling.
3226
3227         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3228         (BuildBot): Added a regexp to match Windows 7 Release (Tests).
3229
3230         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3231         (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
3232         Updated the core regexps to match the buildbot module. Updated the expected results to match
3233         the current set of core builders.
3234
3235 2011-03-03  Benjamin Poulain  <benjamin.poulain@nokia.com>
3236
3237         Reviewed by Andreas Kling.
3238
3239         Adding myself as a reviewer.
3240
3241         * Scripts/webkitpy/common/config/committers.py:
3242
3243 2011-03-03  Lukasz Slachciak  <l.slachciak@samsung.com>
3244
3245         Reviewed by Xan Lopez.
3246
3247         [GTK] Extended application cache database API and added unit tests file.
3248         https://bugs.webkit.org/show_bug.cgi?id=55335
3249
3250         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: removed external declaration
3251         of webkit_application_cache_set_maximum_size due to API exposal.
3252
3253 2011-03-02  Ojan Vafai  <ojan@chromium.org>
3254
3255         Reviewed by Adam Barth.
3256
3257         make webkit-patch upload work for security bugs
3258         https://bugs.webkit.org/show_bug.cgi?id=55655
3259
3260         The problem is that we shell out to prepare-ChangeLog,
3261         which does not authenticate with bugzilla. All it needs from
3262         bugzilla is the bug title though. We just pass it through from
3263         webkit-patch instead.
3264
3265         * Scripts/prepare-ChangeLog:
3266         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3267         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3268
3269 2011-03-01  Ojan Vafai  <ojan@chromium.org>
3270
3271         Reviewed by Tony Chang.
3272
3273         [test-dashboard] make gtest JSON match layout-tests JSON
3274         https://bugs.webkit.org/show_bug.cgi?id=55556
3275
3276         http://trac.webkit.org/changeset/80090 stopped converting time_ms to t.
3277         Make this code match.
3278
3279         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3280
3281 2011-03-02  Dirk Pranke  <dpranke@chromium.org>
3282
3283         Reviewed by Tony Chang.
3284
3285         NRWT - implement Linux Hardy 64-bit port support. This involves
3286         adding support for non-'x86' architectures and updating the
3287         "deduplicate_tests" script to correctly understand that
3288         port.name() is not always equal to basename(port.baseline_path()).
3289
3290         This change introduces two new port names: 'chromium-linux-x86'
3291         and 'chromium-linux-x86_64'. Using the prior 'chromium-linux'
3292         flag will cause the code to determine which one to use at
3293         runtime, just like we currently do with 'chromium-win'.
3294
3295         https://bugs.webkit.org/show_bug.cgi?id=55535
3296
3297         * Scripts/webkitpy/common/system/executive_mock.py:
3298           Handle 'return_stderr' keyword arg to run_command()
3299         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
3300         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3301         * Scripts/webkitpy/layout_tests/port/base.py:
3302         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3303         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3304         * Scripts/webkitpy/layout_tests/port/factory.py:
3305         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3306
3307 2011-03-02  Kevin Ollivier  <kevino@theolliviers.com>
3308
3309         [wx] Build fix, make sure we put the wxWebKit dylib in the right directory and
3310         update symlinks accordingly.
3311
3312         * wx/packaging/build-mac-installer.py:
3313
3314 2011-03-02  Sheriff Bot  <webkit.review.bot@gmail.com>
3315
3316         Unreviewed, rolling out r80139.
3317         http://trac.webkit.org/changeset/80139
3318         https://bugs.webkit.org/show_bug.cgi?id=55620
3319
3320         failing and crashing tests on Snow Leopard bot (Requested by
3321         mihaip1 on #webkit).
3322
3323         * DumpRenderTree/LayoutTestController.cpp:
3324         (LayoutTestController::staticFunctions):
3325         * DumpRenderTree/LayoutTestController.h:
3326         * DumpRenderTree/chromium/LayoutTestController.cpp:
3327         (LayoutTestController::LayoutTestController):
3328         * DumpRenderTree/chromium/LayoutTestController.h:
3329         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3330         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3331         * DumpRenderTree/mac/UIDelegate.h:
3332         * DumpRenderTree/mac/UIDelegate.mm:
3333         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3334         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3335         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3336         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3337
3338 2011-03-02  Adam Roben  <aroben@apple.com>
3339
3340         Wait for force a paint in WebKitTestRunner until we're actually ready to dump the output
3341
3342         This matches DumpRenderTree on Windows.
3343
3344         Fixes <http://webkit.org/b/55469> <rdar://problem/9068539> REGRESSION (r79863): Lots of
3345         dom/html/level2/html/HTMLFrameElement*.html tests crashing in FrameView::paintOverhangAreas
3346         in WebKit2
3347
3348         Reviewed by Beth Dakin.
3349
3350         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3351         (WTR::InjectedBundlePage::dump): Moved code to force a paint here...
3352         (WTR::InjectedBundlePage::didFinishLoadForFrame): ...from here.
3353
3354 2011-03-02  Daniel Cheng  <dcheng@chromium.org>
3355
3356         Reviewed by David Levin.
3357
3358         Add feature define for data transfer items
3359         https://bugs.webkit.org/show_bug.cgi?id=55510
3360
3361         * Scripts/build-webkit:
3362
3363 2011-03-02  Adam Roben  <aroben@apple.com>
3364
3365         Look in the new-to-SnowLeopard location for crash logs on SnowLeopard and newer
3366
3367         ReportCrash saves logs to ~/Library/Logs/CrashReporter on Leopard, but to
3368         ~/Library/Logs/DiagnosticReports on SnowLeopard. old-run-webkit-tests was only looking in
3369         the former location, but was getting lucky on some SnowLeopard machines because symlinks
3370         were being created there pointing into DiagnosticReports. For machines without these
3371         symlinks, crash logs were not getting captured.
3372
3373         Fixes <http://webkit.org/b/55607> old-run-webkit-tests doesn't capture crash logs on some
3374         SnowLeopard machines
3375
3376         Reviewed by Eric Seidel.
3377
3378         * Scripts/old-run-webkit-tests:
3379         (captureSavedCrashLog): Look in ~/Library/Logs/DiagnosticReports on SnowLeopard and newer.
3380
3381 2011-03-02  Adam Roben  <aroben@apple.com>
3382
3383         Don't try to capture crash logs on platforms that haven't implemented that feature
3384
3385         Fixes <http://webkit.org/b/55504> Use of uninitialized value in numeric lt (<) at
3386         Tools/Scripts/old-run-webkit-tests line 1778 seen on Qt bots after a crash
3387
3388         Reviewed by Joseph Pecoraro.
3389
3390         * Scripts/old-run-webkit-tests:
3391         (captureSavedCrashLog): Bail if we don't have a crash log glob.
3392         (findNewestFileMatchingGlob): Fix a buggy test for when no paths match the glob. This isn't
3393         strictly required to fix bug 55504, but seems worthwhile.
3394
3395 2011-01-26  John Knottenbelt  <jknotten@chromium.org>
3396
3397         Reviewed by Dmitry Titov.
3398
3399         Detach Geolocation from Frame when Page destroyed.
3400         https://bugs.webkit.org/show_bug.cgi?id=52877
3401
3402         Extend the layout test controller to expose the number of pending
3403         geolocation requests, so that we can test that the requests have
3404         been cancelled on page close.
3405
3406         * DumpRenderTree/LayoutTestController.cpp:
3407         (numberOfPendingGeolocationPermissionRequestsCallback):
3408         (LayoutTestController::staticFunctions):
3409         * DumpRenderTree/LayoutTestController.h:
3410         * DumpRenderTree/chromium/LayoutTestController.cpp:
3411         (LayoutTestController::LayoutTestController):
3412         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3413         * DumpRenderTree/chromium/LayoutTestController.h:
3414         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3415         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3416         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3417         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3418         * DumpRenderTree/mac/UIDelegate.h:
3419         * DumpRenderTree/mac/UIDelegate.mm:
3420         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
3421         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3422         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3423         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3424         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3425         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3426         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3427         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3428
3429
3430 2011-03-01  Kent Tamura  <tkent@chromium.org>
3431
3432         Reviewed by Dimitri Glazkov.
3433
3434         Assertion fails when a form validation bubble appears
3435         https://bugs.webkit.org/show_bug.cgi?id=55550
3436
3437         Test: fast/forms/interactive-validation-attach-assertion.html
3438
3439         * DumpRenderTree/chromium/WebPreferences.cpp:
3440         (WebPreferences::applyTo): Enable the interactive validation feature by
3441           default. This matches to Chromium browser.
3442
3443 2011-03-01  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3444
3445         Reviewed by Kent Tamura.
3446
3447         Remove efl port style exception of Webcore/JavaScriptCore
3448         https://bugs.webkit.org/show_bug.cgi?id=55549
3449
3450         WebCore and JavaScriptCore need to adhere WebKit coding style.
3451
3452         * Scripts/webkitpy/style/checker.py:
3453
3454 2011-03-01  Tony Chang  <tony@chromium.org>
3455
3456         Reviewed by Ojan Vafai.
3457
3458         [chromium] clean up temp files on chromium-mac builder too
3459         https://bugs.webkit.org/show_bug.cgi?id=55525
3460
3461         * BuildSlaveSupport/chromium/remove-crash-logs:
3462
3463 2011-02-28  Ojan Vafai  <ojan@chromium.org>
3464
3465         Reviewed by Tony Chang.
3466
3467         wrap json in a function call to afford cross-domain loading
3468         https://bugs.webkit.org/show_bug.cgi?id=55353
3469
3470         Also delete the code that compacts the JSON. It turns out this
3471         breaks the rebaseline tool and is probably a premature optimization anyways.
3472
3473         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3474         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3475         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3476         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3477
3478 2011-03-01  Sheriff Bot  <webkit.review.bot@gmail.com>
3479
3480         Unreviewed, rolling out r80079.
3481         http://trac.webkit.org/changeset/80079
3482         https://bugs.webkit.org/show_bug.cgi?id=55547
3483
3484         "Broke the Win debug build?" (Requested by dcheng on #webkit).
3485
3486         * Scripts/build-webkit:
3487
3488 2011-03-01  Mark Rowe  <mrowe@apple.com>
3489
3490         Reviewed by Sam Weinig.
3491
3492         Update verification scripts to handle WebKit2.
3493
3494         * Scripts/check-for-global-initializers: Skip object files that use RefCountedLeakChecker.
3495         * Scripts/check-for-inappropriate-files-in-framework: Add some inappropriate file types for
3496         WebKit2.
3497
3498 2011-03-01  Daniel Cheng  <dcheng@chromium.org>
3499
3500         Reviewed by David Levin.
3501
3502         Add feature define for data transfer items
3503         https://bugs.webkit.org/show_bug.cgi?id=55510
3504
3505         * Scripts/build-webkit:
3506
3507 2011-02-23  Joseph Pecoraro  <joepeck@webkit.org>
3508
3509         Reviewed by Timothy Hatcher.
3510
3511         All Console Messages should be passed to ChromeClients.
3512         https://bugs.webkit.org/show_bug.cgi?id=54926
3513
3514         Update DumpRenderTree's UIDelegate to use the new console message delegate.
3515
3516         * DumpRenderTree/mac/UIDelegate.mm:
3517         (-[UIDelegate webView:addMessageToConsole:withSource:]):
3518
3519 2011-03-01  Dirk Pranke  <dpranke@chromium.org>
3520
3521         Reviewed by Adam Barth.
3522
3523         Tragically, we stopped running the python unit tests
3524         on Chromium Win just as I was getting them to be green.
3525         This patch turns them back on.
3526
3527         https://bugs.webkit.org/show_bug.cgi?id=55521
3528
3529         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3530
3531 2011-03-01  Dirk Pranke  <dpranke@chromium.org>
3532
3533         Reviewed by Adam Roben.
3534
3535         Disable
3536         webkitpy.common.system.executive_unittest.ExecutiveTest.\
3537            test_kill_all fails on win until it can be properly triaged.
3538
3539         https://bugs.webkit.org/show_bug.cgi?id=54790
3540
3541         * Scripts/webkitpy/common/system/executive_unittest.py:
3542
3543     2011-03-01  Helder Correia  <helder@sencha.com>
3544
3545             Unreviewed. Add myself to committers.py.
3546
3547             * Scripts/webkitpy/common/config/committers.py:
3548
3549 2011-03-01  Adam Roben  <aroben@apple.com>
3550
3551         Give up if a crash log for the web process is taking too long to be saved on Windows
3552
3553         This should keep the bots from getting stuck while waiting for a crash log, if writing a
3554         crash log ever hangs or the UI process for some reason doesn't notice it's finished.
3555
3556         Fixes <http://webkit.org/b/55499> WebKitTestRunner can hang forever waiting for a crash log
3557         to be saved for the web process
3558
3559         Reviewed by Steve Falkenburg.
3560
3561         * WebKitTestRunner/win/TestControllerWin.cpp:
3562         (WTR::runRunLoopUntil): Moved code to run the run loop here here from platformRunUntil.
3563         Generalized the code slightly to handle the optional object to wait on.
3564         (WTR::TestController::platformRunUntil): Use the new runRunLoopUntil function, and also use
3565         it (with a timeout) when waiting for a crash log for the web process to be saved. This will
3566         prevent us from waiting forever.
3567
3568 2011-03-01  Adam Roben  <aroben@apple.com>
3569
3570         Give WebKitLauncherWin's PDB file a name different from WebKit's
3571
3572         WebKitLauncherWin (which builds WebKit.exe) and WebKit (which builds WebKit.dll) were
3573         fighting over the same PDB file, meaning that one of them was going to lose and not have
3574         symbols. WebKitLauncherWin's PDB file is now named WebKitLauncherWin.pdb.
3575
3576         Fixes <http://webkit.org/b/55495> Crashes in WebKit.dll have bad backtraces for some test
3577         runs (due to missing symbols)
3578
3579         Reviewed by David Kilzer.
3580
3581         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Use the project name,
3582         "WebKitLauncherWin", instead of the target name, "WebKit", when naming the PDB file.
3583
3584 2011-03-01  Adam Roben  <aroben@apple.com>
3585
3586         Count web process crashes toward the --exit-after-n-crashes-or-timeouts limit
3587
3588         Fixes <http://webkit.org/b/55492> Web process crashes aren't counted toward the
3589         --exit-after-n-crashes-or-timeouts limit
3590
3591         Reviewed by David Kilzer.
3592
3593         * Scripts/old-run-webkit-tests:
3594         (stopRunningTestsEarlyIfNeeded): Include web process crashes in the computation, and print
3595         the number of tests that caused the web process to crash when exiting early.
3596
3597 2011-03-01  Adam Roben  <aroben@apple.com>
3598
3599         Save a crash log when the web process crashes
3600
3601         On Windows, WebKitTestRunner now detects when the web process is crashing and waits to exit
3602         until it has finished crashing, which guarantees that the crash log will have had time to be
3603         saved, too. On Mac, we always wait until ReportCrash has exited before capturing the crash
3604         log, so all we have to do is choose the right crash log out of the CrashReporter directory.
3605
3606         Fixes <http://webkit.org/b/44121> <rdar://problem/8320759> When the web process crashes and
3607         a crash log is being saved, WebKitTestRunner thinks the web process has become unresponsive
3608
3609         Reviewed by Sam Weinig.
3610
3611         * Scripts/old-run-webkit-tests:
3612         (testCrashedOrTimedOut): Don't kill WebKitTestRunner when the web process crashes. It will
3613         kill itself. On Windows, this will cause us to wait until the crash log has been saved. On
3614         Mac, it should have no effect. Capture saved crash logs for web process crashes, too.
3615         (captureSavedCrashLog): Added $webProcessCrashed argument. On Mac, look for
3616         WebProces_*.crash files when the web process crashes.
3617
3618         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3619         (WTR::InjectedBundle::initialize): Added an initializationUserData argument. Updated for
3620         initializePlatformDefaults -> platformInitialize rename. Pass the initializationUserData
3621         along to platformInitialize.
3622
3623         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: See above.
3624
3625         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
3626         (WKBundleInitialize): Pass along the initializationUserData to the InjectedBundle.
3627
3628         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3629         (WTR::InjectedBundle::platformInitialize):
3630         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
3631         (WTR::InjectedBundle::platformInitialize):
3632         Updated function signature.
3633
3634         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:
3635         (WTR::exceptionFilter): Added. Tells the UI process we're crashing by signaling the
3636         webProcessCrashingEvent, then lets the crash continue as normal.
3637
3638         (WTR::InjectedBundle::platformInitialize): Hook up exceptionFilter. Retrieve the name of the
3639         event we should use to tell the UI process we're crashing from the initializationUserData,
3640         and get a handle to that event.
3641
3642         * WebKitTestRunner/TestController.cpp:
3643         (WTR::TestController::TestController): Initialize new members.
3644         (WTR::TestController::processDidCrash): Removed unnecessary WKPageRef argument. Changed to
3645         only print the "#CRASHED - WebProcess" message once, since this can be called more than once
3646         when a crash log is being saved on Windows. Exit right away if specified. (This is the
3647         default.)
3648
3649         * WebKitTestRunner/TestController.h: Added new members.
3650
3651         * WebKitTestRunner/win/TestControllerWin.cpp:
3652         (WTR::TestController::platformInitialize): Set up the event the web process will use to tell
3653         us it's crashing.
3654         (WTR::TestController::platformRunUntil): Pass MWMO_INPUTAVAILABLE to
3655         ::MsgWaitForMultipleObjectsEx so we'll process messages that have already been seen by
3656         ::PeekMessage. (This is unrelated to the bug fix.) Notice when the webProcessCrashingEvent
3657         has been signaled. When this happens, print the "#CRASHED - WebProcess" message right away
3658         so the test harness will know the web process has crashed and not try to kill us, then wait
3659         for the web process to finish crashing so a crash log will have time to be saved.
3660         (WTR::toWK): Simple hepler function.
3661         (WTR::TestController::platformInitializeContext): Pass along the name of the event the web
3662         process should use to tell us it is crashing in the context's initialization user data.
3663
3664 2011-03-01  Dimitri Glazkov  <dglazkov@chromium.org>
3665
3666         Reviewed by Tony Gentilcore.
3667
3668         Move the checks to exclude Python/Perl tests for Chromium Win build to the right place.
3669         https://bugs.webkit.org/show_bug.cgi?id=55476
3670
3671         Chromium Win uses BuildAndTestFactory, not TestFactory.
3672
3673         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Moved to the right place.
3674
3675 2011-03-01  Adam Roben  <aroben@apple.com>
3676
3677         Test that the WebKit2 responsiveness timer doesn't fire too early
3678
3679         Test for <http://webkit.org/b/55417> <rdar://problem/9065287> RunLoop::Timer fires 1000x too
3680         early on Windows
3681
3682         Reviewed by Anders Carlsson.
3683
3684         * TestWebKitAPI/PlatformUtilities.h: Added sleep().
3685
3686         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp: Added.
3687         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3688         (TestWebKitAPI::didFinishLoadForFrame):
3689         (TestWebKitAPI::processDidBecomeUnresponsive):
3690         (TestWebKitAPI::setInjectedBundleClient):
3691         (TestWebKitAPI::setPageLoaderClient):
3692         Simple helper functions.
3693
3694         (TestWebKitAPI::TEST): Load an HTML file to make sure the web process is initialized. Then
3695         tell the web process to pause and press the spacebar key. The spacebar keypress should cause
3696         the responsiveness timer to start, but the web process should unpause before it has a chance
3697         to fire. Run until the web process has unpaused, and assert that the timer didn't fire.
3698
3699         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp: Added.
3700         (TestWebKitAPI::ResponsivenessTimerDoesntFireEarlyTest::ResponsivenessTimerDoesntFireEarlyTest):
3701         Call up to the base class.
3702         (TestWebKitAPI::ResponsivenessTimerDoesntFireEarlyTest::didReceiveMessage): When asked to
3703         pause, sleep for 0.5 seconds, then send back a message saying we paused.
3704
3705         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3706         (TestWebKitAPI::Util::sleep): Added. Calls through to usleep.
3707         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3708         (TestWebKitAPI::Util::sleep): Added. Calls through to ::Sleep.
3709
3710         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3711         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3712         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
3713         Added new files.
3714
3715 2011-03-01  Andras Becsi  <abecsi@webkit.org>
3716
3717         Reviewed by Csaba Osztrogonác.
3718
3719         [Qt] Clean up the project files and move common options to WebKit.pri.
3720
3721         * WebKitTestRunner/qt/WebKitTestRunner.pro: Deduplicate.
3722
3723
3724 2011-03-01  Adam Roben  <aroben@apple.com>
3725
3726         Skip another multiprocessing test on Windows
3727
3728         It is sometimes failing (and may be leaving child Python processes around).
3729         <http://webkit.org/b/55087> tracks the failure.
3730
3731         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
3732         (FuncitonTests.test_get__processes): Skip this test on Windows.
3733
3734 2011-03-01  Ilya Tikhonovsky  <loislo@chromium.org>
3735
3736         Reviewed by Pavel Feldman.
3737
3738         Web Inspector: reduce inspector tests flakiness.
3739         https://bugs.webkit.org/show_bug.cgi?id=55401
3740
3741         * DumpRenderTree/chromium/TestShell.cpp:
3742         (TestShell::runFileTest):
3743         * DumpRenderTree/chromium/WebPreferences.cpp:
3744         (WebPreferences::reset):
3745
3746 2011-02-28  Mihai Parparita  <mihaip@chromium.org>
3747
3748         Reviewed by James Robinson.
3749
3750         NRWT should still upload results when it exits early due to too many failures
3751         https://bugs.webkit.org/show_bug.cgi?id=55432
3752         
3753         Only keyboard interrupts should prevent results from being uploaded.
3754
3755         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3756         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3757
3758 2011-02-28  Alice Liu  <alice.liu@apple.com>
3759
3760         Reviewed by Adam Roben and Gavin Barraclough.
3761
3762         Test for https://bugs.webkit.org/show_bug.cgi?id=54898
3763         InjectedBundleNodeHandle dies too early in WKBundleHitTestResultGetNodeHandle.
3764
3765         * TestWebKitAPI/InjectedBundleController.h:
3766         (TestWebKitAPI::InjectedBundleController::bundle):
3767         * TestWebKitAPI/PlatformWebView.h:
3768         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp: Added.
3769         (TestWebKitAPI::didFinishLoadForFrame):
3770         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3771         (TestWebKitAPI::setPageLoaderClient):
3772         (TestWebKitAPI::TEST):
3773         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp: Added.
3774         (TestWebKitAPI::HitTestResultNodeHandleTest::HitTestResultNodeHandleTest):
3775         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
3776         (TestWebKitAPI::HitTestResultNodeHandleTest::didCreatePage):
3777         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3778         (TestWebKitAPI::PlatformWebView::simulateRightClick):
3779         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3780         (TestWebKitAPI::PlatformWebView::simulateRightClick):
3781         
3782         Added files to:
3783         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3784         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3785         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
3786
3787 2011-02-28  Adam Roben  <aroben@apple.com>
3788
3789         Start running InjectedBundle API tests on Windows
3790
3791         A new project, TestWebKitAPIInjectedBundle, builds the injected bundle DLL.
3792
3793         Fixes <http://webkit.org/b/55420> run-api-tests doesn't run injected bundle tests on Windows
3794
3795         Reviewed by Darin Adler.
3796
3797         * TestWebKitAPI/Configurations/TestWebKitAPIDebug.vsprops: Added.
3798         * TestWebKitAPI/Configurations/TestWebKitAPIDebugAll.vsprops: Added.
3799         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops: Added.
3800         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops: Added.
3801         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops: Added.
3802         These are just extracted from TestWebKitAPI.vcproj.
3803
3804         * TestWebKitAPI/Configurations/TestWebKitAPIInjectedBundleCommon.vsprops: Added. Just sets
3805         up the DLL's filename.
3806
3807         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Fixed DLL name.
3808         (TestWebKitAPI::Util::createInjectedBundlePath): Changed to use kCFAllocatorNull instead of
3809         0 (== kCFAllocatorDefault) so that CF won't try to deallocate our C string.
3810
3811         * TestWebKitAPI/win/TestWebKitAPI.sln: Added TestWebKitAPIInjectedBundle. Removed the bogus
3812         "all" configuration.
3813
3814         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Changed to use the new .vsprops files. Added
3815         injected bundle tests. Let VS resort things.
3816
3817         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Copied from Tools/TestWebKitAPI/win/TestWebKitAPI.vcproj.
3818
3819 2011-02-28  Adam Roben  <aroben@apple.com>
3820
3821         Add a test for the paint rect passed via WM_PAINT to windowless plugins
3822
3823         Test for <http://webkit.org/b/55365> <rdar://problem/9031089> REGRESSION (r79040): WebKit2:
3824         Large portions of pages with plugins paint black
3825
3826         Reviewed by Anders Carlsson.
3827
3828         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3829         (PluginTest::NPP_HandleEvent):
3830         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3831         Added NPP_HandleEvent. Just returns 0 at this level.
3832
3833         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowlessPaintRectCoordinates.cpp: Added.
3834         (WindowlessPaintRectCoordinates::WindowlessPaintRectCoordinates): Call up to the base class.
3835         (WindowlessPaintRectCoordinates::NPP_New): Mark ourselves as windowless.
3836         (WindowlessPaintRectCoordinates::NPP_HandleEvent): Check that the paint rect passed via
3837         WM_PAINT has the expected coordinates.
3838
3839         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3840         (NPP_HandleEvent): Give the PluginTest a chance to handle the event before doing anything
3841         else.
3842
3843         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added new file, let VS
3844         resort things.
3845
3846         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3847         (WTR::InjectedBundlePage::didFinishLoadForFrame): Added a call to WKBundlePageForceRepaint.
3848         This is roughly equivalent to the call to -[WebView displayIfNeeded] in -[FrameLoadDelegate
3849         webView:didFinishLoadForFrame:] in DumpRenderTree.
3850
3851         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3852         (WTR::PlatformWebView::PlatformWebView): Tell the WKView it's in a window so that plugins
3853         can start running.
3854
3855 2011-02-28  Adam Roben  <aroben@apple.com>
3856
3857         Tell MiniBrowser's WKViews that they're in a window
3858
3859         Fixes <http://webkit.org/b/55364> Plugins don't work in MiniBrowser on Windows
3860
3861         Reviewed by Anders Carlsson.
3862
3863         * MiniBrowser/win/BrowserView.cpp:
3864         (BrowserView::create): Call WKViewSetIsInWindow after creating the view.
3865
3866 2011-02-28  Alexis Menard  <alexis.menard@openbossa.org>
3867
3868         Reviewed by Csaba Osztrogonác.
3869
3870         The new QML tests require QML_IMPORT_PATH variable to be set in order to
3871         load the proper plugin.
3872
3873         * Scripts/run-qtwebkit-tests:
3874
3875 2011-02-28  Joone Hur  <joone.hur@collabora.co.uk>
3876
3877         Unreviewed, fix spelling mistake.
3878
3879         hardware-accelated => hardware-accelerated.
3880
3881         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3882
3883 2011-02-28  Kristian Amlie  <kristian.amlie@nokia.com>
3884
3885         Reviewed by Andreas Kling.
3886
3887         Made sure that the build-webkit --qmake argument is always respected.
3888
3889         Previously, it would be respected during the build, but not during
3890         the early feature detection. The build would also fail if qmake was
3891         not in your path, even if you specified --qmake with a valid qmake
3892         binary.
3893
3894         [Qt] WebKit patches required to work with a modularized version of Qt
3895         https://bugs.webkit.org/show_bug.cgi?id=53916
3896
3897         * Scripts/build-webkit:
3898         * Scripts/webkitdirs.pm:
3899
3900 2011-02-27  Ojan Vafai  <ojan@chromium.org>
3901
3902         Fix failing tests from http://trac.webkit.org/changeset/79837.
3903
3904         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3905         This was just a mistake that would break if someone tried printing with this configuration.
3906         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3907         Method signature changed. Didn't notice that this method was being calling in a unittest.
3908
3909 2011-02-24  Hayato Ito  <hayato@chromium.org>
3910
3911         Reviewed by Eric Seidel.
3912
3913         [NRWT] Remove test_types/* classes.
3914
3915         This is the last patch in the series of efforts which tried to remove test_types classes.
3916         A single_test_runner module will take over responsibilities of test_type classes.
3917
3918         From this patch, we won't display statistics per test_type even if a '--verbose' option is given.
3919
3920         https://bugs.webkit.org/show_bug.cgi?id=55123
3921
3922         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
3923         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
3924         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
3925         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3926         * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
3927         * Scripts/webkitpy/layout_tests/test_types/__init__.py: Removed.
3928         * Scripts/webkitpy/layout_tests/test_types/image_diff.py: Removed.
3929         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: Removed.
3930         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: Removed.
3931         * Scripts/webkitpy/layout_tests/test_types/text_diff.py: Removed.
3932
3933 2011-02-25  Ojan Vafai  <ojan@chromium.org>
3934
3935         Reviewed by Tony Chang.
3936
3937         Change results.json format to the one used by unexpected_results.json
3938         https://bugs.webkit.org/show_bug.cgi?id=52267
3939
3940         Also add runtimes in milliseconds to the JSON and make the output format more compact.
3941         Named the file full_results.json to avoid conflicting with the results.json
3942         file the test-results server currently serves up.
3943
3944         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3945         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3946         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3947         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3948         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
3949         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3950
3951 2011-02-27  Adam Roben  <aroben@apple.com>
3952
3953         Followup fix to r79827
3954
3955         * DumpRenderTree/win/UIDelegate.cpp:
3956         (UIDelegate::webViewAddMessageToConsole): Replaced call to urlSuitableForTestResult with
3957         lastPathComponent. This matches what we did here before r79827, and matches Mac.
3958
3959 2011-02-27  Dan Bernstein  <mitz@apple.com>
3960
3961         Reviewed by Adam Roben.
3962
3963         Make bisect-builds print a trac link for the regression range
3964         https://bugs.webkit.org/show_bug.cgi?id=55331
3965
3966         * Scripts/bisect-builds:
3967
3968 2011-02-27  Adam Roben  <aroben@apple.com>
3969
3970         Use iswalpha instead of isalpha when dealing with wchar_ts in EditingDelegate
3971
3972         Fixes <http://webkit.org/b/55062> <rdar://problem/9059907> Crash beneath
3973         EditingDelegate::checkSpellingOfString when running fast/forms/input-text-maxlength.html or
3974         fast/forms/input-text-paste-maxlength.html on Windows with full page heap enabled
3975
3976         Reviewed by Anders Carlsson.
3977
3978         * DumpRenderTree/win/EditingDelegate.cpp:
3979         (indexOfFirstWordCharacter):
3980         (wordLength):
3981         Use iswalpha instead of isalpha, since TCHAR is really just wchar_t.
3982
3983 2011-02-27  Adam Roben  <aroben@apple.com>
3984
3985         Make ResourceLoadDelegate print URLs relative to the main resource on Windows
3986
3987         This matches Mac. (In fact, the code was ported from Mac!)
3988
3989         Fixes <http://webkit.org/b/55328> URLs printed by ResourceLoadDelegate on Windows don't
3990         match Mac
3991
3992         Reviewed by Anders Carlsson.
3993
3994         * DumpRenderTree/win/DumpRenderTree.cpp:
3995         (substringFromIndex): Added. Emulates -[NSString substringFromIndex:].
3996         (urlSuitableForTestResult): Ported code from -[NSURL(DRTExtras)
3997         _drt_descriptionSuitableForTestResult].
3998         (cfStringRefToWString): Moved here from LayoutTestControllerWin.cpp.
3999
4000         * DumpRenderTree/win/DumpRenderTreeWin.h: Added declaration of cfStringRefToWString.
4001
4002         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Moved cfStringRefToWString to
4003         DumpRenderTree.cpp.
4004
4005 2011-02-27  Adam Roben  <aroben@apple.com>
4006
4007         Change the order of Chang Shu's email addresses so the first one is their Bugzilla username
4008
4009         This makes Bugzilla autocompletion work correctly.
4010
4011         * Scripts/webkitpy/common/config/committers.py:
4012
4013 2011-02-27  Patrick Gansterer  <paroga@webkit.org>
4014
4015         Reviewed by Andreas Kling.
4016
4017         [Qt] fast/loader/user-stylesheet-fast-path.html fails
4018         https://bugs.webkit.org/show_bug.cgi?id=50911
4019
4020         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4021         (LayoutTestController::setUserStyleSheetLocation):
4022         Use QUrl::fromEncoded since the passed string is already encoded.
4023
4024 2011-02-27  Adam Roben  <aroben@apple.com>
4025
4026         Ensure $testResultsDirectory is an absolute path before setting up Windows crash log saving
4027
4028         Windows 7 (and maybe Vista?) launches the post-mortem debugger with a working directory that
4029         is different from old-run-webkit-test's. Because of this, the path to the crash log file
4030         (which is relative to $testResultsDirectory) must be an absolute path. See the bug for more
4031         details.
4032
4033         Fixes <http://webkit.org/b/55318> Crash logs aren't saved on Windows 7 when a relative
4034         --results-directory path is used (like on the test slaves)
4035
4036         Reviewed by Dan Bernstein.
4037
4038         * Scripts/old-run-webkit-tests: Moved the call to setUpWindowsCrashLogSaving after we've
4039         made $testResultsDirectory an absolute path.
4040
4041 2011-02-26  Dominic Mazzoni  <dmazzoni@google.com>
4042
4043         Reviewed by Adam Barth.
4044
4045         m_dumpAccessibilityNotifications should be initialized.
4046         https://bugs.webkit.org/show_bug.cgi?id=54874
4047
4048         * DumpRenderTree/chromium/AccessibilityController.cpp:
4049         (AccessibilityController::AccessibilityController):
4050
4051 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
4052
4053         Reviewed by Pavel Feldman.
4054
4055         DumpRenderTree should reset frame opener between tests.
4056         https://bugs.webkit.org/show_bug.cgi?id=54874
4057
4058         Added clearOpener() calls between tests.
4059         Some tests are using window.open() to change current window location.
4060         This changes window.opener property whose nullity is checked before
4061         showing xml viewer.
4062
4063         * DumpRenderTree/chromium/TestShell.cpp:
4064         (TestShell::resetTestController):
4065         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4066         (resetDefaultsToConsistentValues):
4067         * DumpRenderTree/mac/DumpRenderTree.mm:
4068         (resetWebViewToConsistentStateBeforeTesting):
4069         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4070         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
4071         * DumpRenderTree/win/DumpRenderTree.cpp:
4072         (resetWebViewToConsistentStateBeforeTesting):
4073         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4074         (WTR::InjectedBundlePage::reset):
4075
4076 2011-02-26  Yael Aharon  <yael.aharon@nokia.com>
4077
4078         Reviewed by Andreas Kling.
4079
4080         [Qt] Fix the focus in MiniBrowser.
4081         https://bugs.webkit.org/show_bug.cgi?id=55288
4082
4083         Give focus to the web view when a load starts.
4084
4085         * MiniBrowser/qt/BrowserWindow.cpp:
4086         (BrowserWindow::urlChanged):
4087
4088 2011-02-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
4089
4090         Reviewed by Adam Barth.
4091
4092         [EFL] Add coding style exceptions for EFL port
4093         https://bugs.webkit.org/show_bug.cgi?id=54733
4094
4095         The EFL APIs use EFL naming style, which includes both lower-cased and camel-cased,
4096         underscore-sparated values. But, style checking rule have found parameter_name errors
4097         in efl directories so far.
4098
4099         * Scripts/webkitpy/style/checker.py: Add prameter_name rule's exception and efl directories.
4100
4101 2011-02-26  David Levin  <levin@chromium.org>
4102
4103         Reviewed by Darin Adler.
4104
4105         check-webkit-style should check for spaces after periods in comments
4106         https://bugs.webkit.org/show_bug.cgi?id=55253
4107
4108         * Scripts/webkitpy/style/checkers/cpp.py: Added the check.
4109         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests
4110           and fixed the name of one related test.
4111
4112 2011-02-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>
4113
4114         Reviewed by Andreas Kling.
4115
4116         Make it possible to test the targetdensity-dpi support
4117         https://bugs.webkit.org/show_bug.cgi?id=55142
4118
4119         Test the viewport meta tag feature targetdensity-dpi by
4120         adding extra arguments to dumpConfigurationForViewport
4121
4122         Add the new arguments to the shared header and all
4123         implementation.
4124
4125         * DumpRenderTree/LayoutTestController.cpp:
4126         (dumpConfigurationForViewportCallback):
4127         * DumpRenderTree/LayoutTestController.h:
4128         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4129         (LayoutTestController::dumpConfigurationForViewport):
4130         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4131         (LayoutTestController::dumpConfigurationForViewport):
4132         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4133         (LayoutTestController::dumpConfigurationForViewport):
4134         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4135         (LayoutTestController::dumpConfigurationForViewport):
4136         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4137         (LayoutTestController::dumpConfigurationForViewport):
4138         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4139
4140 2011-02-26  Sheriff Bot  <webkit.review.bot@gmail.com>
4141
4142         Unreviewed, rolling out r79764.
4143         http://trac.webkit.org/changeset/79764
4144         https://bugs.webkit.org/show_bug.cgi?id=55295
4145
4146         "broke Chromium builds" (Requested by rniwa on #webkit).
4147
4148         * DumpRenderTree/chromium/TestShell.cpp:
4149         (TestShell::resetTestController):
4150         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4151         (resetDefaultsToConsistentValues):
4152         * DumpRenderTree/mac/DumpRenderTree.mm:
4153         (resetWebViewToConsistentStateBeforeTesting):
4154         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4155         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
4156         * DumpRenderTree/win/DumpRenderTree.cpp:
4157         (resetWebViewToConsistentStateBeforeTesting):
4158         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4159         (WTR::InjectedBundlePage::reset):
4160
4161 2011-02-26  Yongjun Zhang  <yongjun_zhang@apple.com>
4162
4163         Reviewed by David Kilzer.
4164
4165         https://bugs.webkit.org/show_bug.cgi?id=48781
4166
4167         Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.
4168
4169         Add a new resource load client method (shouldPaintBrokenImage).  WebKit client can decide if WebCore
4170         should paint the default broken image when an image fails to load or decode.
4171
4172         * DumpRenderTree/LayoutTestController.cpp:
4173         (LayoutTestController::LayoutTestController):
4174         (setShouldPaintBrokenImageCallback):
4175         (LayoutTestController::staticFunctions):
4176         (LayoutTestController::setShouldPaintBrokenImage):
4177         * DumpRenderTree/LayoutTestController.h:
4178         (LayoutTestController::shouldPaintBrokenImage):
4179         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
4180         (-[ResourceLoadDelegate webView:shouldPaintBrokenImageForURL:]):
4181
4182 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
4183
4184         Reviewed by Pavel Feldman.
4185
4186         DumpRenderTree should reset frame opener between tests.
4187         https://bugs.webkit.org/show_bug.cgi?id=54874
4188
4189         Added clearOpener() calls between tests.
4190         Some tests are using window.open() to change current window location.
4191         This changes window.opener property whose nullity is checked before
4192         showing xml viewer.
4193
4194         * DumpRenderTree/chromium/TestShell.cpp:
4195         (TestShell::resetTestController):
4196         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4197         (resetDefaultsToConsistentValues):
4198         * DumpRenderTree/mac/DumpRenderTree.mm:
4199         (resetWebViewToConsistentStateBeforeTesting):
4200         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4201         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
4202         * DumpRenderTree/win/DumpRenderTree.cpp:
4203         (resetWebViewToConsistentStateBeforeTesting):
4204         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4205         (WTR::InjectedBundlePage::reset):
4206
4207 2011-02-25  Lukasz Slachciak  <l.slachciak@samsung.com>
4208
4209         Reviewed by Kenneth Rohde Christiansen.
4210
4211         [EFL] Added EWebLauncher command line option to turn on/off frame flattening
4212         https://bugs.webkit.org/show_bug.cgi?id=54809
4213
4214         * EWebLauncher/main.c: Handling -f option added.
4215         (on_key_down):
4216         (browserCreate):
4217         (main):
4218
4219 2011-02-25  Sheriff Bot  <webkit.review.bot@gmail.com>
4220
4221         Unreviewed, rolling out r79324.
4222         http://trac.webkit.org/changeset/79324
4223         https://bugs.webkit.org/show_bug.cgi?id=55260
4224
4225         Leopard Debug is once again running out of address space while
4226         linking (Requested by aroben on #webkit).
4227
4228         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
4229         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
4230
4231 2011-02-25  Tony Chang  <tony@chromium.org>
4232
4233         Reviewed by James Robinson.
4234
4235         Clean up temp files left by crashing DRTs on chromium-win
4236         https://bugs.webkit.org/show_bug.cgi?id=55182
4237
4238         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4239         * BuildSlaveSupport/chromium/remove-crash-logs: Added.
4240
4241 2011-02-25  Adam Roben  <aroben@apple.com>
4242
4243         Double-check that modifying the registry worked
4244
4245         On Windows Vista/7 with UAC enabled, regtool will fail to modify the registry, but it will
4246         still return a successful exit code. So we double-check here that the value we tried to
4247         write to the registry was really written.
4248
4249         Fixes <http://webkit.org/b/55227> old-run-webkit-tests falsely claims to be saving crash
4250         logs on Windows Vista/7
4251
4252         Reviewed by Darin Adler.
4253
4254         * Scripts/old-run-webkit-tests:
4255         (writeRegistryString): After trying to write the string value, check that it was really
4256         written.
4257
4258 2011-02-25  Adam Roben  <aroben@apple.com>
4259
4260         Set the 32-bit post-mortem debugger on 64-bit OSes
4261
4262         The post-mortem debugger is controlled by some registry values in
4263         HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\AeDebug. On 64-bit OSes, you can either
4264         set the values in that key, which will be used for 64-bit apps, or in the equivalent key
4265         under Wow6432Node, which will be used for 32-bit apps. Since DumpRenderTree and
4266         WebKitTestRunner are 32-bit, we want to use the latter location.
4267
4268         Fixes <http://webkit.org/b/55225> old-run-webkit-tests sets the post-mortem debugger for
4269         64-bit apps, but should set it for 32-bit apps instead
4270
4271         Reviewed by Darin Adler.
4272
4273         * Scripts/old-run-webkit-tests:
4274         (readRegistryString):
4275         (writeRegistryString):
4276         Pass --wow32 to regtool so it will get/set values beneath Wow6432Node, which is where
4277         Windows looks for the post-mortem debugger values when a 32-bit app crashes on a 64-bit OS.
4278         Passing --wow32 on a 32-bit OS will not have any effect.
4279
4280 2011-02-25  Adam Roben  <aroben@apple.com>
4281
4282         Clean up code to set up crash log saving on Windows
4283
4284         Fixes <http://webkit.org/b/55224> old-run-webkit-test's Windows registry code is ugly
4285
4286         Reviewed by David Kilzer.
4287
4288         * Scripts/old-run-webkit-tests:
4289         (readRegistryString):
4290         (writeRegistryString):
4291         Moved code to read strings from and write strings to the registry here...
4292
4293         (setUpWindowsCrashLogSaving): ...from here.
4294
4295 2011-02-25  Adam Roben  <aroben@apple.com>
4296
4297         Work around Cygwin's crash-suppression behavior
4298
4299         Cygwin calls ::SetErrorMode(SEM_FAILCRITICALERRORS), which any processes it launches will
4300         inherit. This is bad for testing/debugging, as it causes the post-mortem debugger not to be
4301         invoked. (Cygwin does this because it makes&n