4baee288cde2716d69b37e43d34931c0ffb4e089
[WebKit-https.git] / Tools / ChangeLog
1 2016-09-07  Youenn Fablet  <youenn@apple.com>
2
3         [Streams API] Separate compile flag for ReadableStream and WritableStream
4         https://bugs.webkit.org/show_bug.cgi?id=161044
5
6         Reviewed by Alex Christensen.
7
8         Moving from STREAMS_API to READABLE_STREAM_API and WRITABLE_STREAM_API compilation flags.
9
10         * Scripts/webkitperl/FeatureList.pm:
11         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
12
13 2016-09-07  Carlos Garcia Campos  <cgarcia@igalia.com>
14
15         [GTK] Move some GObject DOM unstable API to stable
16         https://bugs.webkit.org/show_bug.cgi?id=161681
17
18         Reviewed by Žan Doberšek.
19
20         Do not use user message handler unstable API in the tests, since we have stable convenient API for that.
21
22         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
23         (testUserContentManagerScriptMessageFromDOMBindings):
24         (serverCallback): Deleted.
25         (beforeAll): Deleted.
26         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
27         (documentLoadedCallback):
28         (emitURIChanged): Deleted.
29
30 2016-09-07  Youenn Fablet  <youenn@apple.com>
31
32         Using tests-options.json to compute whether tests are slow
33         https://bugs.webkit.org/show_bug.cgi?id=161626
34
35         Reviewed by Darin Adler.
36
37         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: Updated first test to use a MockHost.
38         * Scripts/webkitpy/layout_tests/controllers/manager.py:
39         (Manager.__init__): Loading tests-options.json
40         (Manager._test_is_slow): Computing timeout value based on tests-options.json.
41
42 2016-09-07  Hunseop Jeong  <hs85.jeong@samsung.com>
43
44         [EFL] Need the libosmesa to support the software backend drawing.
45         https://bugs.webkit.org/show_bug.cgi?id=147065
46
47         Reviewed by Gyuyoung Kim.
48
49         Added the libosmesa to support the software backend drawing.
50
51         * efl/install-dependencies:
52
53 2016-09-06  Commit Queue  <commit-queue@webkit.org>
54
55         Unreviewed, rolling out r205521, r205526, and r205532.
56         https://bugs.webkit.org/show_bug.cgi?id=161668
57
58         broke API tests (Requested by alexchristensen on #webkit).
59
60         Reverted changesets:
61
62         "Punycode encode non-ascii hosts in URLParser"
63         https://bugs.webkit.org/show_bug.cgi?id=161655
64         http://trac.webkit.org/changeset/205521
65
66         "Fix query-only and fragment-only relative URLs when using
67         URLParser"
68         https://bugs.webkit.org/show_bug.cgi?id=161657
69         http://trac.webkit.org/changeset/205526
70
71         "URLParser should parse / as a relative URL"
72         https://bugs.webkit.org/show_bug.cgi?id=161667
73         http://trac.webkit.org/changeset/205532
74
75 2016-09-06  Alex Christensen  <achristensen@webkit.org>
76
77         URLParser should parse / as a relative URL
78         https://bugs.webkit.org/show_bug.cgi?id=161667
79
80         Reviewed by Tim Horton.
81
82         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
83         (TestWebKitAPI::TEST_F):
84
85 2016-09-06  Daniel Bates  <dabates@apple.com>
86
87         [iOS] DumpRenderTree and WebKitTestRunner fail to build - "Ad Hoc code signing is not allowed with SDK 'Simulator - iOS 10.0'"
88         https://bugs.webkit.org/show_bug.cgi?id=161661
89
90         Reviewed by Darin Adler.
91
92         Allow ad-hoc code signing when building the dummy DumpRenderTree and WebKitTestRunner
93         command line tools for simulator with the iOS 10 beta SDK.
94
95         * DumpRenderTree/mac/Configurations/Base.xcconfig:
96         * WebKitTestRunner/Configurations/Base.xcconfig:
97
98 2016-09-06  Alex Christensen  <achristensen@webkit.org>
99
100         Fix query-only and fragment-only relative URLs when using URLParser
101         https://bugs.webkit.org/show_bug.cgi?id=161657
102
103         Reviewed by Tim Horton.
104
105         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
106         (TestWebKitAPI::TEST_F):
107
108 2016-09-06  Alex Christensen  <achristensen@webkit.org>
109
110         Punycode encode non-ascii hosts in URLParser
111         https://bugs.webkit.org/show_bug.cgi?id=161655
112
113         Reviewed by Tim Horton.
114
115         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
116         (TestWebKitAPI::wideString):
117         (TestWebKitAPI::TEST_F):
118
119 2016-09-05  Alex Christensen  <achristensen@webkit.org>
120
121         Implement relative file urls and begin implementing character encoding in URLParser
122         https://bugs.webkit.org/show_bug.cgi?id=161618
123
124         Reviewed by Tim Horton.
125
126         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
127         (TestWebKitAPI::TEST_F):
128
129 2016-09-06  Commit Queue  <commit-queue@webkit.org>
130
131         Unreviewed, rolling out r205480.
132         https://bugs.webkit.org/show_bug.cgi?id=161630
133
134         tests-options.json is not known from knockout filesystem
135         (Requested by youenn on #webkit).
136
137         Reverted changeset:
138
139         "Using tests-options.json to compute whether tests are slow"
140         https://bugs.webkit.org/show_bug.cgi?id=161626
141         http://trac.webkit.org/changeset/205480
142
143 2016-09-06  Michael Catanzaro  <mcatanzaro@igalia.com>
144
145         "Redundant argument in sprintf" warning spam from prepare-ChangeLog
146         https://bugs.webkit.org/show_bug.cgi?id=161606
147
148         Reviewed by Darin Adler.
149
150         Avoid extra arguments in call to sprintf, hopefully without introducing new warnings this
151         time.
152
153         * Scripts/prepare-ChangeLog:
154         (statusDescription):
155
156 2016-09-06  Youenn Fablet  <youenn@apple.com>
157
158         Using tests-options.json to compute whether tests are slow
159         https://bugs.webkit.org/show_bug.cgi?id=161626
160
161         Reviewed by Darin Adler.
162
163         * Scripts/webkitpy/layout_tests/controllers/manager.py:
164         (Manager.__init__): Loading tests-options.json
165         (Manager._test_is_slow): Computing timeout value based on tests-options.json.
166
167 2016-09-06  Commit Queue  <commit-queue@webkit.org>
168
169         Unreviewed, rolling out r205461.
170         https://bugs.webkit.org/show_bug.cgi?id=161628
171
172         Introduced "Use of uninitialized value $original in sprintf"
173         warning (Requested by mcatanzaro on #webkit).
174
175         Reverted changeset:
176
177         ""Redundant argument in sprintf" warning spam from prepare-
178         ChangeLog"
179         https://bugs.webkit.org/show_bug.cgi?id=161606
180         http://trac.webkit.org/changeset/205461
181
182 2016-09-06  Youenn Fablet  <youenn@apple.com>
183
184         W3C test importer should be able to identify slow test
185         https://bugs.webkit.org/show_bug.cgi?id=161601
186
187         Reviewed by Darin Adler.
188
189         Test parser is now identifying slow tests based on "meta element name=timeout content=long" elements.
190         Test importer is updating test-options.json file according that information.
191
192         In case of clean import, the test-options.json is cleaned from 'slow' options for all W3C tests.
193
194         * Scripts/webkitpy/w3c/test_importer.py:
195         (TestImporter.__init__):
196         (TestImporter.find_importable_tests):
197         (TestImporter.import_tests):
198         (TestImporter.update_test_options):
199         (TestImporter):
200         (TestImporter.remove_slow_from_w3c_test_options):
201         * Scripts/webkitpy/w3c/test_parser.py:
202         (TestParser.analyze_test):
203         (TestParser.is_slow_test):
204         (TestParser.potential_ref_filename):
205
206 2016-09-06  Per Arne Vollan  <pvollan@apple.com>
207
208         [Win] Crash logs have incorrect symbols.
209         https://bugs.webkit.org/show_bug.cgi?id=161603
210
211         Reviewed by Darin Adler.
212
213         Add build path to _NT_SYMBOL_PATH environment variable.
214
215         * Scripts/webkitpy/port/win.py:
216         (WinPort.setup_crash_log_saving):
217
218 2016-08-31  Filip Pizlo  <fpizlo@apple.com>
219
220         Butterflies should be allocated in Auxiliary MarkedSpace instead of CopiedSpace and we should rewrite as much of the GC as needed to make this not a regression
221         https://bugs.webkit.org/show_bug.cgi?id=160125
222
223         Reviewed by Geoffrey Garen and Keith Miller.
224
225         * DumpRenderTree/TestRunner.cpp:
226         * DumpRenderTree/mac/DumpRenderTree.mm:
227         (DumpRenderTreeMain):
228         * Scripts/run-jsc-stress-tests:
229         * TestWebKitAPI/Tests/WTF/Vector.cpp:
230         (TestWebKitAPI::TEST):
231
232 2016-09-05  Michael Catanzaro  <mcatanzaro@igalia.com>
233
234         "Redundant argument in sprintf" warning spam from prepare-ChangeLog
235         https://bugs.webkit.org/show_bug.cgi?id=161606
236
237         Reviewed by Darin Adler.
238
239         Avoid extra arguments in call to sprintf.
240
241         * Scripts/prepare-ChangeLog:
242         (statusDescription):
243
244 2016-09-05  Michael Catanzaro  <mcatanzaro@igalia.com>
245
246         [GTK] Skip several failing API tests
247
248         Unfortunately we don't have any form of test expectations for API tests, so we'll just skip
249         them after bugs are filed.
250
251         * Scripts/run-gtk-tests:
252         (TestRunner):
253
254 2016-09-05  Youenn Fablet  <youenn@apple.com>
255
256         Fix W3C test importer unit tests after r205447
257         https://bugs.webkit.org/show_bug.cgi?id=161604
258
259         Unreviewed.
260
261         * Scripts/webkitpy/w3c/test_importer.py:
262         (TestImporter.__init__): Skip cleaning test_resource_files files if resource-files.json cannot be read.
263
264 2016-09-05  Philippe Normand  <pnormand@igalia.com>
265
266         WebRTC: Several media stream tests crashing
267         https://bugs.webkit.org/show_bug.cgi?id=161582
268
269         Reviewed by Alejandro G. Castro.
270
271         * gtk/jhbuild.modules: Bump to latest OpenWebRTC master fixing the crash on missing
272         glvideoflip GStreamer element.
273
274 2016-09-05  Youenn Fablet  <youenn@apple.com>
275
276         W3C test importer should generate the list of resource files
277         https://bugs.webkit.org/show_bug.cgi?id=161578
278
279         Reviewed by Ryosuke Niwa.
280
281         Generating LayoutTests/imported/w3c/resources/resource-files.json when importing tests.
282
283         * Scripts/webkitpy/w3c/test_importer.py:
284         (TestImporter.__init__): Reading test resource files configuration file.
285         (TestImporter.find_importable_tests):
286         (TestImporter.import_tests): Update the test resource files based on test parsed files.
287         (TestImporter):
288         (TestImporter._already_identified_as_resource_file): Helper routine to know whether a file is already set as a resource file.
289         (TestImporter._is_in_resources_directory: Helper routine to know whether a file is in a resources directory.
290
291 2016-09-03  Wenson Hsieh  <wenson_hsieh@apple.com>
292
293         Media controls behave strangely when videos mute from within a playing handler
294         https://bugs.webkit.org/show_bug.cgi?id=161559
295         <rdar://problem/28018438>
296
297         Reviewed by Darin Adler.
298
299         Accounts for changes when determining whether or not to show media controls for autoplaying videos that have not
300         begun playing yet. Rather than check for a controlled media element upon page load, we force tests to wait until
301         all autoplaying videos have actually begun playing. This extends to tests that involve interaction, such as
302         clicking or scrolling.
303
304         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
305         (-[VideoControlsManagerTestWebView callJavascriptFunction:]):
306         (-[VideoControlsManagerTestWebView expectControlsManager:afterReceivingMessage:]):
307         (-[VideoControlsManagerTestWebView performAfterReceivingMessage:action:]):
308         (-[VideoControlsManagerTestWebView waitForPageToLoadWithAutoplayingVideos:]):
309         (TestWebKitAPI::TEST):
310         (-[VideoControlsManagerTestWebView loadTestPageNamed:andExpectControlsManager:afterReceivingMessage:]): Deleted.
311         * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html:
312         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html:
313         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-playing-scroll-away.html:
314         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-click-to-pause.html:
315         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-scroll-to-video.html:
316         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-paused-video-hides-controls.html:
317         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-muted-video-hides-controls.html:
318         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-video-keeps-controls.html:
319         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html:
320
321 2016-09-03  Wenson Hsieh  <wenson_hsieh@apple.com>
322
323         Refactor the heuristic for showing media controls to take all media sessions into account
324         https://bugs.webkit.org/show_bug.cgi?id=161503
325         <rdar://problem/28033783>
326
327         Reviewed by Darin Adler.
328
329         Adds new unit tests verifying the behavior of media playback controls when scrolling another video into view.
330         Please see the WebCore ChangeLog for more details about this change. Also refactors existing
331         VideoControlsManager tests by folding duplicated setup and testing logic into helper methods to make the unit
332         tests more readable.
333
334         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
335         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
336         (-[MessageHandler initWithMessage:handler:]):
337         (-[MessageHandler userContentController:didReceiveScriptMessage:]):
338         (-[VideoControlsManagerTestWebView performAfterLoading:]):
339         (-[VideoControlsManagerTestWebView loadTestPageNamed:]):
340         (-[VideoControlsManagerTestWebView loadTestPageNamed:andExpectControlsManager:afterReceivingMessage:]):
341         (-[VideoControlsManagerTestWebView performAfterReceivingMessage:action:]):
342         (-[VideoControlsManagerTestWebView controlledElementID]):
343         (-[VideoControlsManagerTestWebView _handleControlledElementIDResponse:]):
344         (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager):
345         (TestWebKitAPI::TEST):
346         (-[MediaPlaybackMessageHandler initWithWKWebView:finalMessageString:]): Deleted.
347         (-[MediaPlaybackMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
348         (-[OnLoadMessageHandler initWithWKWebView:handler:]): Deleted.
349         (-[OnLoadMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
350         (-[WKWebView performAfterLoading:]): Deleted.
351         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-playing-scroll-away.html: Added.
352         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-click-to-pause.html: Added.
353         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-scroll-to-video.html: Added.
354         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-paused-video-hides-controls.html: Added.
355         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-muted-video-hides-controls.html: Added.
356         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-video-keeps-controls.html: Added.
357
358 2016-09-03  Youenn Fablet  <youenn@apple.com>
359
360         run-webkit-tests should detect w3c test resource files
361         https://bugs.webkit.org/show_bug.cgi?id=161307
362
363         Reviewed by Ryosuke Niwa.
364
365         * Scripts/webkitpy/port/base.py:
366         (Port.__init__): Adding self._w3c_resource_files to store the list of resource files.
367         (Port.potential_test_names_from_expected_file):
368         (Port._real_tests):
369         (Port.is_w3c_resource_file): Computing whether a file is a resource file based on imported/w3c/resources/resource-files.json.
370         (Port._is_test_file): Updated to call Port.is_w3c_resource_file. _is_test_file is no longer static.
371         (Port): Deleted.
372         * Scripts/webkitpy/port/base_unittest.py:
373         (PortTest.test_additional_platform_directory):
374         (PortTest.test_find_no_paths_specified):
375         (PortTest.test_is_test_file): Updated to use non-static version of _is_test_file.
376         (PortTest.test_is_w3c_resource_file): Adding tests.
377
378 2016-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
379
380         Unreviewed. Fix archive-built-product step in GTK+ bots after r205280.
381
382         * BuildSlaveSupport/built-product-archive:
383         (archiveBuiltProduct): Do not copy to the archive the files needed to run GObject DOM bindings API breaks tests
384         that no longer exist.
385
386 2016-09-02  Alex Christensen  <achristensen@webkit.org>
387
388         URLParser should parse file URLs
389         https://bugs.webkit.org/show_bug.cgi?id=161556
390
391         Reviewed by Tim Horton.
392
393         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
394         (TestWebKitAPI::TEST_F):
395         (TestWebKitAPI::checkURLDifferences):
396
397 2016-09-01  Michael Saboff  <msaboff@apple.com>
398
399         Import Chakra tests to JSC
400         https://bugs.webkit.org/show_bug.cgi?id=154697
401
402         Reviewed by Saam Barati.
403
404         Added "runChakra" and "chakraPassFailErrorHandler" to support the running of
405         Chakra tests.
406
407         * Scripts/run-jsc-stress-tests:
408
409 2016-09-02  Jonathan Bedard  <jbedard@apple.com>
410
411         WebKitTestRunner needs layoutTestController.setDashboardCompatibilityMode
412         https://bugs.webkit.org/show_bug.cgi?id=42547
413  
414         Reviewed by Darin Adler.
415
416         Added JavaScript bindings and C++ implementation of setUseDashboardCompatibilityMode for the WebKit2 sTestRunner.
417         Note: this bug mistakenly called this function setDashboardCompatibilityMode, it is actually setUseDashboardCompatibilityMode.
418
419         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Added dashboard compatiblity mode setter.
420         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
421         (WTR::InjectedBundle::beginTesting): Reset dashboard compatibility mode.
422         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
423         (WTR::TestRunner::setJavaScriptCanAccessClipboard): Code style changes.
424         (WTR::TestRunner::setPrivateBrowsingEnabled): Code style changes.
425         (WTR::TestRunner::setUseDashboardCompatibilityMode): Added dashboard compatiblity mode setter.
426         (WTR::TestRunner::setPopupBlockingEnabled): Code style changes.
427         (WTR::TestRunner::setAuthorAndUserStylesEnabled): Code style changes.
428         (WTR::TestRunner::addOriginAccessWhitelistEntry): Code style changes.
429         * WebKitTestRunner/InjectedBundle/TestRunner.h: Added dashboard compatiblity mode setter.
430
431 2016-09-02  Jer Noble  <jer.noble@apple.com>
432
433         Unreviewed build fix: restore storyboard files to Xcode 7-compatability.
434
435         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard:
436         * MobileMiniBrowser/MobileMiniBrowserFramework/Base.lproj/Main.storyboard:
437
438 2016-09-02  Tim Horton  <timothy_horton@apple.com>
439
440         REGRESSION (r205329): Two API tests time out on iOS Simulator
441         https://bugs.webkit.org/show_bug.cgi?id=161542
442
443         Reviewed by Brady Eidson.
444
445         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
446         (createAnimatedResizeWebView):
447         (createFirstVisuallyNonEmptyWatchingNavigationDelegate):
448         (TEST):
449         (animatedResizeWebView): Deleted.
450         The navigation delegate was being stored in a local and went out of scope
451         before the test was over. Keep it around, instead.
452
453 2016-08-31  Jer Noble  <jer.noble@apple.com>
454
455         Refactor MobileMiniBrowser into an application framework to allow external XCTesting
456         https://bugs.webkit.org/show_bug.cgi?id=161462
457
458         Reviewed by Eric Carlson.
459
460         XCTest targets need to be in the same project as the application which they're testing. To facilitate
461         having external projects with XCTest targets, move the application's implementation into a framework
462         that can be included with a bare-bones application shell for testing.
463
464         Simultaneously, add the ability to load files from within the new framework's bundle by using a
465         'bundle:/' URL scheme. Update the tests to use this new bundle URL and remove the dependency on
466         an external server for testing.
467
468         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
469         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard:
470         * MobileMiniBrowser/MobileMiniBrowser/Info.plist:
471         * MobileMiniBrowser/MobileMiniBrowser/main.m:
472         * MobileMiniBrowser/MobileMiniBrowserFramework/AppDelegate.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h.
473         * MobileMiniBrowser/MobileMiniBrowserFramework/AppDelegate.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m.
474         (-[AppDelegate application:didFinishLaunchingWithOptions:]): Manually instantiate the main view
475             controller from the framework's bundle.
476         * MobileMiniBrowser/MobileMiniBrowserFramework/Assets.xcassets/AppIcon.appiconset/Contents.json: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/Assets.xcassets/AppIcon.appiconset/Contents.json.
477         * MobileMiniBrowser/MobileMiniBrowserFramework/Base.lproj/Main.storyboard: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard.
478         * MobileMiniBrowser/MobileMiniBrowserFramework/Info.plist: Added.
479         * MobileMiniBrowser/MobileMiniBrowserFramework/MobileMiniBrowser.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h.
480         * MobileMiniBrowser/MobileMiniBrowserFramework/TabViewController.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/TabViewController.h.
481         * MobileMiniBrowser/MobileMiniBrowserFramework/TabViewController.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/TabViewController.m.
482         * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/WebViewController.h.
483         * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/WebViewController.m.
484         (+[NSURL __bundleURLForFileURL:bundle:]): Add utility method.
485         (+[NSURL __fileURLForBundleURL:bundle:]): Ditto.
486         (-[WebViewController navigateTo:]): Support loading "bundle:/" URLs which are really just "file:" URLs
487             pointing to the framework's resources directory.
488         (-[WebViewController observeValueForKeyPath:ofObject:change:context:]): Ditto.
489         * MobileMiniBrowser/MobileMiniBrowserUITests/MobileMiniBrowserUITests.m:
490         (-[MobileMiniBrowserUITests testBasicVideoPlayback]):
491
492 2016-09-02  Jonathan Bedard  <jbedard@apple.com>
493
494         Fix --no-sample-on-timeout command line argument
495         https://bugs.webkit.org/show_bug.cgi?id=161507
496
497         Reviewed by Alexey Proskuryakov.
498
499         This patch fixes the —no-sample-on-timeout flag and correctly names spindumps as spindump.txt.
500
501         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
502         (parse_args): Fixed —-no-sample-on-timeout.
503         * Scripts/webkitpy/port/apple.py:
504         (ApplePort.sample_process): Use correct file name.
505         (ApplePort.spindump_file_path): Spindump and sample file names are different.
506         * Scripts/webkitpy/port/driver.py:
507         (Driver._check_for_driver_timeout): Check “sample_on_timeout” flag.
508         * Scripts/webkitpy/port/mac_unittest.py:
509         (MacTest.test_spindump): Modified for correct filename.
510
511 2016-09-02  Jonathan Bedard  <jbedard@apple.com>
512
513         Unreviewed: moved myself to the reviewers list.
514
515         * Scripts/webkitpy/common/config/contributors.json:
516
517 2016-09-02  Tomas Popela  <tpopela@redhat.com>
518
519         [GTK] Fix compiler warning in MiniBrowser
520         https://bugs.webkit.org/show_bug.cgi?id=161529
521
522         We were missing a return statement in decidePermissionRequest() and
523         also there was unused variable in browserWindowConstructed().
524
525         Reviewed by Carlos Garcia Campos.
526
527         * MiniBrowser/gtk/BrowserTab.c:
528         (decidePermissionRequest):
529         * MiniBrowser/gtk/BrowserWindow.c:
530         (browserWindowConstructed):
531
532 2016-09-01  Dan Bernstein  <mitz@apple.com>
533
534         Build fix.
535
536         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
537
538 2016-09-01  Tim Horton  <timothy_horton@apple.com>
539
540         Provide a TestWebKitAPI-wide WKNavigationDelegate to simplify tests
541         https://bugs.webkit.org/show_bug.cgi?id=161413
542
543         Reviewed by Simon Fraser.
544
545         Add TestNavigationDelegate, which provides block properties to make
546         writing tests feel a little more natural (the callbacks can be inline),
547         and also add WKWebView _test_waitForDidFinishNavigation, so that many
548         tests don't even need to manually allocate a navigation delegate at all.
549
550         Adopt in some of the simpler tests; there are a few navigation delegates
551         left behind, which we can move to the new model in the future.
552
553         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
554         * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm:
555         (TEST):
556         (-[WKBackForwardListTestNavigationDelegate webView:didFinishNavigation:]): Deleted.
557         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm:
558         (TEST):
559         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]): Deleted.
560         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
561         (animatedResizeWebView):
562         (-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]): Deleted.
563         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
564         (-[AutoLayoutWKWebView initWithFrame:configuration:]):
565         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]):
566         (TEST):
567         (-[AutoLayoutNavigationDelegate webView:didFinishNavigation:]): Deleted.
568         * TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresource.mm:
569         (TEST):
570         (-[CancelFontSubresourceNavigationDelegate webView:didFinishNavigation:]): Deleted.
571         * TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm:
572         (WebKit2_CommandBackForwardTestWKWebView::SetUp):
573         (WebKit2_CommandBackForwardTestWKWebView::loadFiles):
574         (TEST_F):
575         (-[CommandBackForwardNavigationDelegate webView:didFinishNavigation:]): Deleted.
576         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
577         (expectLinkCount):
578         (TEST):
579         (-[DataDetectionNavigationDelegate webView:didFinishNavigation:]): Deleted.
580         * TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm:
581         (TEST):
582         (-[FindInPageNavigationDelegate webView:didFinishNavigation:]): Deleted.
583         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm:
584         (TEST):
585         (-[FixedLayoutSizeNavigationDelegate webView:didFinishNavigation:]): Deleted.
586         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
587         (TEST):
588         (-[DatabaseProcessKillNavigationDelegate webView:didFinishNavigation:]): Deleted.
589         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
590         (-[IndexedDBNavigationDelegate webView:didFinishNavigation:]): Deleted.
591         * TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLNotChange.mm:
592         (TEST):
593         (-[ProvisionalURLNotChangeController webView:didFinishNavigation:]): Deleted.
594         (-[ProvisionalURLNotChangeController webView:didFailProvisionalNavigation:withError:]): Deleted.
595         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
596         (RequiresUserActionForPlaybackTest::createWebView):
597         (RequiresUserActionForPlaybackTest::testVideoWithAudio):
598         (RequiresUserActionForPlaybackTest::testVideoWithoutAudio):
599         (RequiresUserActionForPlaybackTest::testAudioOnly):
600         (-[RequiresUserActionForPlaybackNavigationDelegate webView:didFinishNavigation:]): Deleted.
601         * TestWebKitAPI/Tests/WebKit2Cocoa/ShrinkToFit.mm:
602         (TEST):
603         (-[ShrinkToFitNavigationDelegate webView:didFinishNavigation:]): Deleted.
604         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
605         (TEST):
606         (webViewForScriptMessageHandlerMultipleHandlerRemovalTest):
607         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentWorld.mm:
608         (TEST):
609         (-[SimpleDelegate webView:didFinishNavigation:]): Deleted.
610         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm:
611         (TEST):
612         (-[WKPDFViewResizeNavigationDelegate webView:didFinishNavigation:]): Deleted.
613         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
614         (TEST):
615         (-[EvaluateJavaScriptNavigationDelegate webView:didFinishNavigation:]): Deleted.
616         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewTextInput.mm:
617         (TEST):
618         (-[DummyNavigationDelegate webView:didFinishNavigation:]): Deleted.
619         * TestWebKitAPI/cocoa/TestNavigationDelegate.h: Added.
620         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm: Added.
621         (-[TestNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
622         (-[TestNavigationDelegate webView:didFinishNavigation:]):
623         (-[TestNavigationDelegate _webView:renderingProgressDidChange:]):
624         (-[TestNavigationDelegate waitForDidFinishNavigation]):
625         (-[WKWebView _test_waitForDidFinishNavigation]):
626
627 2016-09-01  Ricky Mondello  <rmondello@apple.com>
628
629         YouTube Flash plug-in replacement facility should not insert showinfo=0 into iframe URLs
630         https://bugs.webkit.org/show_bug.cgi?id=161478
631         <rdar://problem/28050847>
632
633         Reviewed by Eric Carlson.
634
635         * TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp:
636         (TestWebKitAPI::TEST_F): Update expected results.
637
638 2016-09-01  Anders Carlsson  <andersca@apple.com>
639
640         add BlockPtr::fromCallable
641         https://bugs.webkit.org/show_bug.cgi?id=161504
642
643         Reviewed by Tim Horton.
644
645         Add a test.
646
647         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
648         * TestWebKitAPI/Tests/WTF/BlockPtr.mm: Added.
649         (TestWebKitAPI::TEST):
650
651 2016-09-01  Alex Christensen  <achristensen@webkit.org>
652
653         URLParser should handle . and .. in URL paths
654         https://bugs.webkit.org/show_bug.cgi?id=161443
655
656         Reviewed by Brady Eidson.
657
658         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
659         (TestWebKitAPI::eq):
660         (TestWebKitAPI::TEST_F):
661
662 2016-09-01  Commit Queue  <commit-queue@webkit.org>
663
664         Unreviewed, rolling out r205295 and r205303.
665         https://bugs.webkit.org/show_bug.cgi?id=161505
666
667         Broke the iOS build (Requested by ryanhaddad on #webkit).
668
669         Reverted changesets:
670
671         "Refactor MobileMiniBrowser into an application framework to
672         allow external XCTesting"
673         https://bugs.webkit.org/show_bug.cgi?id=161462
674         http://trac.webkit.org/changeset/205295
675
676         "Unreviewed build-fix; don't specify an explicit deployment
677         target."
678         http://trac.webkit.org/changeset/205303
679
680 2016-09-01  Ricky Mondello  <rmondello@apple.com>
681
682         YouTube Flash plug-in replacement facility should more gracefully handle malformed queries
683         https://bugs.webkit.org/show_bug.cgi?id=161476
684         <rdar://problem/28050847>
685
686         Reviewed by Eric Carlson.
687
688         * TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp:
689         (TestWebKitAPI::TEST_F): New tests. The first two and second-to-last test cases cover the "malformed" query
690             logic. A few other tests are added, too.
691
692 2016-09-01  Jer Noble  <jer.noble@apple.com>
693
694         Unreviewed build-fix; don't specify an explicit deployment target.
695
696         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
697
698 2016-08-31  Jer Noble  <jer.noble@apple.com>
699
700         Refactor MobileMiniBrowser into an application framework to allow external XCTesting
701         https://bugs.webkit.org/show_bug.cgi?id=161462
702
703         Reviewed by Eric Carlson.
704
705         XCTest targets need to be in the same project as the application which they're testing. To facilitate
706         having external projects with XCTest targets, move the application's implementation into a framework
707         that can be included with a bare-bones application shell for testing.
708
709         Simultaneously, add the ability to load files from within the new framework's bundle by using a
710         'bundle:/' URL scheme. Update the tests to use this new bundle URL and remove the dependency on
711         an external server for testing.
712
713         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
714         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard:
715         * MobileMiniBrowser/MobileMiniBrowser/Info.plist:
716         * MobileMiniBrowser/MobileMiniBrowser/main.m:
717         * MobileMiniBrowser/MobileMiniBrowserFramework/AppDelegate.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h.
718         * MobileMiniBrowser/MobileMiniBrowserFramework/AppDelegate.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m.
719         (-[AppDelegate application:didFinishLaunchingWithOptions:]): Manually instantiate the main view
720             controller from the framework's bundle.
721         * MobileMiniBrowser/MobileMiniBrowserFramework/Assets.xcassets/AppIcon.appiconset/Contents.json: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/Assets.xcassets/AppIcon.appiconset/Contents.json.
722         * MobileMiniBrowser/MobileMiniBrowserFramework/Base.lproj/Main.storyboard: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard.
723         * MobileMiniBrowser/MobileMiniBrowserFramework/Info.plist: Added.
724         * MobileMiniBrowser/MobileMiniBrowserFramework/MobileMiniBrowser.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h.
725         * MobileMiniBrowser/MobileMiniBrowserFramework/TabViewController.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/TabViewController.h.
726         * MobileMiniBrowser/MobileMiniBrowserFramework/TabViewController.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/TabViewController.m.
727         * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/WebViewController.h.
728         * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/WebViewController.m.
729         (+[NSURL __bundleURLForFileURL:bundle:]): Add utility method.
730         (+[NSURL __fileURLForBundleURL:bundle:]): Ditto.
731         (-[WebViewController navigateTo:]): Support loading "bundle:/" URLs which are really just "file:" URLs
732             pointing to the framework's resources directory.
733         (-[WebViewController observeValueForKeyPath:ofObject:change:context:]): Ditto.
734         * MobileMiniBrowser/MobileMiniBrowserUITests/MobileMiniBrowserUITests.m:
735         (-[MobileMiniBrowserUITests testBasicVideoPlayback]):
736
737 2016-09-01  Carlos Garcia Campos  <cgarcia@igalia.com>
738
739         Unreviewed. Fix webkitpy unit tests after r205280.
740
741         * Scripts/webkitpy/style/checker_unittest.py:
742         (GlobalVariablesTest.test_path_rules_specifier):
743
744 2016-08-31  Carlos Garcia Campos  <cgarcia@igalia.com>
745
746         [GTK] Move GObject DOM bindings to WebKit2 layer and stop auto generating them
747         https://bugs.webkit.org/show_bug.cgi?id=161438
748
749         Reviewed by Michael Catanzaro.
750
751         Remove scripts related to the GObject DOM bindings auto-generation.
752
753         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
754         (RunGtkAPITests.getText2):
755         (TestFactory.__init__):
756         (RunWebKit1Tests): Deleted.
757         (RunWebKit1Tests.start): Deleted.
758         (RunWebKit1LeakTests): Deleted.
759         (RunWebKit1LeakTests.start): Deleted.
760         (RunAndUploadPerfTests): Deleted.
761         (RunAndUploadPerfTests.start): Deleted.
762         (BuildAndRemoteJSCTestsFactory.__init__): Deleted.
763         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
764         (BuildStepsTest.test_unnecessary_expected_results):
765         (RunAndUploadPerfTestsTest): Deleted.
766         (RunAndUploadPerfTestsTest.assertResults): Deleted.
767         (RunAndUploadPerfTestsTest.test_success): Deleted.
768         (RunAndUploadPerfTestsTest.test_tests_failed): Deleted.
769         (RunAndUploadPerfTestsTest.test_build_bad_build): Deleted.
770         (RunAndUploadPerfTestsTest.test_build_bad_source_json): Deleted.
771         (RunAndUploadPerfTestsTest.test_build_bad_marge): Deleted.
772         (RunAndUploadPerfTestsTest.test_build_bad_failed_uploading): Deleted.
773         (RunAndUploadPerfTestsTest.test_build_bad_preparation): Deleted.
774         (RunAndUploadPerfTestsTest.test_buildbot_timeout): Deleted.
775         (RunBenchmarkTest): Deleted.
776         (RunBenchmarkTest.assertResults): Deleted.
777         (RunBenchmarkTest.test_success): Deleted.
778         * Scripts/run-bindings-tests:
779         (main):
780         * Scripts/webkitpy/style/checker.py:
781         * gtk/check-for-webkitdom-api-breaks: Removed.
782         * gtk/generate-gtkdoc:
783         * gtk/webkitdom.py: Removed.
784
785 2016-08-31  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
786
787         [EFL] Small clean up in MiniBrowser
788         https://bugs.webkit.org/show_bug.cgi?id=161428
789
790         Reviewed by Yusuke Suzuki.
791
792         This patch resizes MiniBrowser, add *char* constants for scheme,
793         does line breaking, and remove unnecessary spaces.
794
795         * MiniBrowser/efl/main.c:
796         (on_mouse_wheel):
797         (history_list_hide):
798         (script_execute_callback):
799         (on_key_down):
800         (on_url_changed):
801         (on_error):
802         (on_color_picker_request):
803         (url_from_user_input):
804         (url_load_from_user_input):
805         (on_back_button_clicked):
806         (on_search_case_option_changed):
807         (on_search_word_start_option_changed):
808         (on_list_item_select):
809         (navigation_button_longpress_process):
810         (on_navigation_policy_decision):
811         (window_create):
812         (parse_cookies_policy):
813
814 2016-08-31  Alex Christensen  <achristensen@webkit.org>
815
816         Implement IPv6 parsing in URLParser
817         https://bugs.webkit.org/show_bug.cgi?id=161390
818
819         Reviewed by Darin Adler.
820
821         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
822         (TestWebKitAPI::TEST_F):
823         (TestWebKitAPI::checkURLDifferences):
824
825 2016-08-31  Brady Eidson  <beidson@apple.com>
826
827         WK2 Gamepad provider on iOS.
828         https://bugs.webkit.org/show_bug.cgi?id=161412
829
830         Reviewed by Tim Horton.
831
832         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
833
834 2016-08-30  Ricky Mondello  <rmondello@apple.com>
835
836         YouTubePluginReplacementTest's URL transformation logic should have tests
837         https://bugs.webkit.org/show_bug.cgi?id=161406
838         <rdar://problem/28050847>
839
840         Reviewed by Eric Carlson.
841
842         Add some very basic tests. Future patches should expand on these to find and fix bugs.
843
844         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add YouTubePluginReplacement.cpp.
845         * TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp: Added.
846         (TestWebKitAPI::test): Added.
847         (TestWebKitAPI::TEST_F): Added.
848
849 2016-08-30  Brady Eidson  <beidson@apple.com>
850
851         GameController.framework backend for gamepad API.
852         https://bugs.webkit.org/show_bug.cgi?id=161086
853
854         Reviewed by Alex Christensen.
855
856         * MiniBrowser/mac/AppDelegate.m:
857         (-[BrowserAppDelegate awakeFromNib]):
858
859         * MiniBrowser/mac/SettingsController.h:
860         * MiniBrowser/mac/SettingsController.m:
861         (-[SettingsController _populateMenu]):
862         (-[SettingsController validateMenuItem:]):
863         (-[SettingsController usesGameControllerFramework]):
864         (-[SettingsController toggleUsesGameControllerFramework:]):
865
866 2016-08-30  Brent Fulgham  <bfulgham@apple.com>
867
868         Use of uninitialised memory in TransformationMatrx::blend4()
869         https://bugs.webkit.org/show_bug.cgi?id=134621
870         <rdar://problem/27337539>
871
872         Reviewed by Dean Jackson.
873
874         Change is based on the Blink change (patch by <alancutter@chromium.org>):
875         <https://src.chromium.org/viewvc/blink?revision=177453&view=revision>
876
877         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
878         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp: Added.
879         (TestWebKitAPI::TEST):
880
881 2016-08-30  Alex Christensen  <achristensen@webkit.org>
882
883         URLParser should handle relative URLs that start with //
884         https://bugs.webkit.org/show_bug.cgi?id=161364
885
886         Reviewed by Darin Adler.
887
888         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
889         (TestWebKitAPI::checkRelativeURL):
890         (TestWebKitAPI::TEST_F):
891
892 2016-08-29  Aakash Jain  <aakash_jain@apple.com>
893
894         EWS patch status page should indicate bot corresponding to each status message
895         https://bugs.webkit.org/show_bug.cgi?id=161280
896
897         Reviewed by Alexey Proskuryakov.
898
899         * QueueStatusServer/templates/patch.html: Formatting changes.
900
901 2016-08-29  Aakash Jain  <aakash_jain@apple.com>
902
903         EWS should indicate which bot processed the patch
904         https://bugs.webkit.org/show_bug.cgi?id=161222
905
906         Reviewed by Alexey Proskuryakov.
907
908         * QueueStatusServer/handlers/statusbubble.py:
909         (StatusBubble._build_bubble): Remove the bot id from bubbles as it is confusing.
910         bot ids are now displayed in patch status page.
911
912 2016-08-29  Alex Christensen  <achristensen@webkit.org>
913
914         URLParser should parse about:blank
915         https://bugs.webkit.org/show_bug.cgi?id=161324
916
917         Reviewed by Brady Eidson.
918
919         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
920         (TestWebKitAPI::TEST_F):
921
922 2016-08-29  JF Bastien  <jfbastien@apple.com>
923
924         Bug 161165 - check-webkit-style doesn't understand macros containing `else` or labels
925         https://bugs.webkit.org/show_bug.cgi?id=161165
926
927         Reviewed by Geoffrey Garen.
928
929         Fix handling of `else` in a macro. Don't handle labels in a macro:
930         the checker is already pretty messy in that area and it should be
931         a rare thing.
932
933         * Scripts/webkitpy/style/checkers/cpp.py:
934         (check_braces):
935         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
936         (CppStyleTest.test_else_clause_not_on_same_line_as_else):
937
938 2016-08-29  Alex Christensen  <achristensen@webkit.org>
939
940         API test URLParserTest.ParserFailures failing ASSERT_NOT_REACHED
941         https://bugs.webkit.org/show_bug.cgi?id=161317
942
943         Reviewed by Brady Eidson.
944
945         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
946         (TestWebKitAPI::TEST_F):
947
948 2016-08-29  Jer Noble  <jer.noble@apple.com>
949
950         Unreviewed gardening; only build MiniBrowser against iOS SDK targets.
951
952         * Makefile:
953
954 2016-08-29  Jonathan Bedard  <jbedard@apple.com>
955
956         Sample Process on notifyDone timed out
957         https://bugs.webkit.org/show_bug.cgi?id=161063
958
959         Reviewed by Darin Adler.
960
961         * Scripts/webkitpy/port/driver.py:
962         (Driver._check_for_driver_timeout): 
963         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Call sample_process during notifyDone timeouts.
964         (WTR::TestRunner::waitToDumpWatchdogTimerFired):
965         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm: Log pid and name for testing harness.
966
967 2016-08-29  Jonathan Bedard  <jbedard@apple.com>
968
969         Check-webkit-style does not work with Objective-C blocks
970         https://bugs.webkit.org/show_bug.cgi?id=161247
971
972         Reviewed by Darin Adler.
973
974         * Scripts/webkitpy/style/checkers/cpp.py:
975         (regex_for_lambda_functions): Changed to regex_for_lambdas_and_blocks.
976         (regex_for_lambdas_and_blocks): Added check for Objective-C blocks.
977         (check_spacing_for_function_call): Pass file state for lambda check.
978         (check_spacing): Pass file state for lambda check.
979         (check_braces): Pass file state for lambda check.
980         (check_style): Pass file state for lambda check.
981         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
982         (CppStyleTest.test_cpp_lambda_functions): Changed from ‘test_lambda_functions’.
983         (CppStyleTest.test_objective_c_block): Tests Objective-C blocks.
984         (CppStyleTest.test_lambda_functions): Changed to ‘test_cpp_lambda_functions’.
985
986 2016-08-29  Aakash Jain  <aakash_jain@apple.com>
987
988         EWS patch status page should indicate bot corresponding to each status message
989         https://bugs.webkit.org/show_bug.cgi?id=161280
990
991         Reviewed by Alexey Proskuryakov.
992
993         * QueueStatusServer/templates/patch.html: Added bot_id in the template so that bot id is displayed
994         for each status message.
995         * QueueStatusServer/stylesheets/common.css:
996         (.status-bot): Added corresponding stylesheet class.
997
998 2016-08-29  Per Arne Vollan  <pvollan@apple.com>
999
1000         Attempt to fix Windows build after r205090.
1001
1002         Unreviewed build fix.
1003
1004         * DumpRenderTree/win/DRTDataObject.cpp:
1005         (cfFileNameWFormat):
1006         (cfUrlWFormat):
1007
1008 2016-08-27  Alex Christensen  <achristensen@webkit.org>
1009
1010         URLParser should parse relative URLs
1011         https://bugs.webkit.org/show_bug.cgi?id=161282
1012
1013         Reviewed by Darin Adler.
1014
1015         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1016         (TestWebKitAPI::TEST):
1017         Added some tests for the new operator=.
1018         Test saving iterators, restoring iterators, and even assigning iterators to new CodePoints objects.
1019         Using the same iterator to iterate multiple objects is bad practice, but it's possible and now tested.
1020         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1021         (TestWebKitAPI::checkURL):
1022         (TestWebKitAPI::TEST_F):
1023         (TestWebKitAPI::checkRelativeURL):
1024         (TestWebKitAPI::checkURLDifferences):
1025         (TestWebKitAPI::shouldFail):
1026         Add some relative URL tests.
1027
1028 2016-08-27  Jonathan Bedard  <jbedard@apple.com>
1029
1030         WTR needs an implementation of setAutomaticLinkDetectionEnabled
1031         https://bugs.webkit.org/show_bug.cgi?id=87162
1032
1033         Reviewed by Darin Adler.
1034
1035         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Added setAutomaticLinkDetectionEnabled binding.
1036         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1037         (WTR::InjectedBundle::beginTesting): Set automatic link detection to false by default.
1038         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1039         (WTR::TestRunner::setAutomaticLinkDetectionEnabled): Added setAutomaticLinkDetectionEnabled definition.
1040         * WebKitTestRunner/InjectedBundle/TestRunner.h: Added setAutomaticLinkDetectionEnabled declaration.
1041
1042 2016-08-27  Joseph Pecoraro  <pecoraro@apple.com>
1043
1044         Web Inspector: Make localizedString.js diff and commit friendly (UTF16 -> UTF8)
1045         https://bugs.webkit.org/show_bug.cgi?id=28685
1046         <rdar://problem/16460975>
1047
1048         Reviewed by Darin Adler.
1049
1050         * Scripts/extract-localizable-js-strings:
1051         * Scripts/update-webkit-localizable-strings:
1052         WebInspectorUI localizedStrings.js is now UTF-8. Other clients of
1053         this script still use UTF-16, so keep that the default.
1054
1055 2016-08-27  Alexey Proskuryakov  <ap@apple.com>
1056
1057         REGRESSION (r204052): Popovers on bot watcher's dashboard are broken
1058         https://bugs.webkit.org/show_bug.cgi?id=161254
1059
1060         Reviewed by Darin Adler.
1061
1062         Simplify the CSS. My understanding that the CSS was correct, and the root cause
1063         is tracked in bug 160478.
1064
1065         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
1066
1067 2016-08-27  Simon Fraser  <simon.fraser@apple.com>
1068
1069         Add run-webkit-tests --print-expectations to show expectations for all or a subset of tests
1070         https://bugs.webkit.org/show_bug.cgi?id=161217
1071
1072         Reviewed by Ryosuke Niwa.
1073
1074         "run-webkit-tests --print-expectations" runs the same logic as running the tests, but
1075         dumps out the lists of tests that would be run and skipped, and, for each, the entry
1076         in TestExpectations that determines the expected outcome of the test.
1077
1078         This is an improved version of webkit-patch print-expectations.
1079
1080         See bug for sample output.
1081
1082         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1083         (Manager._print_expectations_for_subset): Print out the list of tests and expected
1084         outcome for some subset of tests.
1085         (Manager.print_expectations): Do the same splitting by device class that running tests
1086         does, and for each subset of tests, call _print_expectations_for_subset.
1087         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1088         (TestExpectationParser.expectation_for_skipped_test): Set the flag
1089         expectation_line.not_applicable_to_current_platform
1090         (TestExpectationLine.__init__): Init not_applicable_to_current_platform to False
1091         (TestExpectationLine.expected_behavior): line.expectation is ['PASS'] by default,
1092         even for skipped tests. This function returns a list relevant for display, taking the skipped
1093         modifier into account.
1094         (TestExpectationLine.create_passing_expectation): expectations is normally a list, not a set.
1095         (TestExpectations.readable_filename_and_line_number): Return something printable for 
1096         lines with and without filenames
1097         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1098         (main): Handle options.print_expectations
1099         (parse_args): Add support for --print-expectations
1100         (_print_expectations):
1101         * Scripts/webkitpy/port/ios.py:
1102         (IOSSimulatorPort.default_child_processes): Make this a debug log.
1103
1104 2016-08-26  Dan Bernstein  <mitz@apple.com>
1105
1106         Keep trying to fix the build after r205057.
1107
1108         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1109
1110 2016-08-26  Dan Bernstein  <mitz@apple.com>
1111
1112         Keep trying to fix the build after r205057.
1113
1114         * MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m: Don’t try to import nonexistent
1115           config.h. This file is only meant to be built with Xcode anyway.
1116         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard: Make this compile
1117           with Xcode 7.3 and deploy to iOS 9.0.
1118         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard: Ditto.
1119         * MobileMiniBrowser/MobileMiniBrowser/TabViewController.m: Don’t try to import config.h.
1120         * MobileMiniBrowser/MobileMiniBrowser/WebViewController.m: Ditto.
1121
1122 2016-08-26  Dan Bernstein  <mitz@apple.com>
1123
1124         Start trying to fix the build after r205057.
1125
1126         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1127
1128 2016-08-26  Alexey Proskuryakov  <ap@apple.com>
1129
1130         Remove Yosemite Leaks from the flakiness dashboard
1131         https://bugs.webkit.org/show_bug.cgi?id=161253
1132
1133         Reviewed by Anders Carlsson.
1134
1135         * TestResultServer/static-dashboards/builders.jsonp:
1136
1137 2016-08-26  Sam Weinig  <sam@webkit.org>
1138
1139         Remove support for ENABLE_LEGACY_WEB_AUDIO
1140         https://bugs.webkit.org/show_bug.cgi?id=161262
1141
1142         Reviewed by Anders Carlsson.
1143
1144         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1145
1146 2016-08-26  Jer Noble  <jer.noble@apple.com>
1147
1148         Add a test harness for running UI tests on the iOS Simulator
1149         https://bugs.webkit.org/show_bug.cgi?id=161265
1150
1151         Reviewed by Simon Fraser.
1152
1153         Add a new iOS Simulator application which uses WKWebView to implement a basic browser, and which
1154         can serve as a test harness for WebKit UI tests.
1155
1156         Also add a basic media playback test which verifies that a <video> element will begin playing in
1157         fullscreen on an iPhone device, but will play inline on an iPad device.
1158
1159         * Makefile: Add MobileMiniBrowser as a Module for iOS builds.
1160         * MobileMiniBrowser/Configurations/Base.xcconfig: Added.
1161         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig: Added.
1162         * MobileMiniBrowser/Configurations/MobileMiniBrowser.xcconfig: Added.
1163         * MobileMiniBrowser/Makefile: Added.
1164         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj: Added.
1165         * MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h: Added.
1166         * MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m: Added.
1167         (-[AppDelegate application:didFinishLaunchingWithOptions:]):
1168         (-[AppDelegate applicationWillResignActive:]):
1169         (-[AppDelegate applicationDidEnterBackground:]):
1170         (-[AppDelegate applicationWillEnterForeground:]):
1171         (-[AppDelegate applicationDidBecomeActive:]):
1172         (-[AppDelegate applicationWillTerminate:]):
1173         * MobileMiniBrowser/MobileMiniBrowser/Assets.xcassets/AppIcon.appiconset/Contents.json: Added.
1174         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard: Added.
1175         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard: Added.
1176         * MobileMiniBrowser/MobileMiniBrowser/Info.plist: Added.
1177         * MobileMiniBrowser/MobileMiniBrowser/TabViewController.h: Added.
1178         * MobileMiniBrowser/MobileMiniBrowser/TabViewController.m: Added.
1179         (-[TabViewController dealloc]):
1180         (-[TabViewController viewDidLoad]):
1181         (-[TabViewController observeValueForKeyPath:ofObject:change:context:]):
1182         (-[TabViewController tableView:cellForRowAtIndexPath:]):
1183         (-[TabViewController tableView:numberOfRowsInSection:]):
1184         (-[TabViewController numberOfSectionsInTableView:]):
1185         (-[TabViewController tableView:canEditRowAtIndexPath:]):
1186         (-[TabViewController tableView:canMoveRowAtIndexPath:]):
1187         (-[TabViewController tableView:commitEditingStyle:forRowAtIndexPath:]):
1188         (-[TabViewController tableView:didSelectRowAtIndexPath:]):
1189         * MobileMiniBrowser/MobileMiniBrowser/WebViewController.h: Added.
1190         * MobileMiniBrowser/MobileMiniBrowser/WebViewController.m: Added.
1191         (-[WebViewController viewDidLoad]):
1192         (-[WebViewController didReceiveMemoryWarning]):
1193         (-[WebViewController reload:]):
1194         (-[WebViewController goBack:]):
1195         (-[WebViewController goForward:]):
1196         (-[WebViewController urlFieldEditingBegan:]):
1197         (-[WebViewController navigateTo:]):
1198         (-[WebViewController showTabs:]):
1199         (-[WebViewController selectWebViewAtIndex:]):
1200         (-[WebViewController removeWebViewAtIndex:]):
1201         (-[WebViewController addWebView]):
1202         (-[WebViewController createWebView]):
1203         (-[WebViewController removeWebView:]):
1204         (-[WebViewController setCurrentWebView:]):
1205         (-[WebViewController webView:didFailNavigation:withError:]):
1206         (-[WebViewController observeValueForKeyPath:ofObject:change:context:]):
1207         * MobileMiniBrowser/MobileMiniBrowser/main.m: Added.
1208         (main):
1209         * MobileMiniBrowser/MobileMiniBrowserUITests/Info.plist: Added.
1210         * MobileMiniBrowser/MobileMiniBrowserUITests/MobileMiniBrowserUITests.m: Added.
1211         (-[MobileMiniBrowserUITests setUp]):
1212         (-[MobileMiniBrowserUITests tearDown]):
1213         (-[MobileMiniBrowserUITests testBasicVideoPlayback]):
1214
1215 2016-08-26  Aakash Jain  <aakash_jain@apple.com>
1216
1217         webkit-queues queue-status page should should list more recent statuses
1218         https://bugs.webkit.org/show_bug.cgi?id=161220
1219
1220         Reviewed by Daniel Bates.
1221
1222         * QueueStatusServer/handlers/queuestatus.py:
1223         (QueueStatus._fetch_statuses): Increase the number of recent statuses from 15 to 50.
1224
1225 2016-08-26  Dan Bernstein  <mitz@apple.com>
1226
1227         [Cocoa] Infinite recursion calling -charValue on a WKNSNumber
1228         https://bugs.webkit.org/show_bug.cgi?id=161258
1229
1230         Reviewed by Anders Carlsson.
1231
1232         * TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm:
1233         (TestWebKitAPI::TEST):
1234
1235 2016-08-26  Csaba Osztrogonác  <ossy@webkit.org>
1236
1237         Fix the ENABLE(WEBASSEMBLY) build on Linux
1238         https://bugs.webkit.org/show_bug.cgi?id=161197
1239
1240         Reviewed by Mark Lam.
1241
1242         * Scripts/build-jsc:
1243
1244 2016-08-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1245
1246         [GTK] run-gtk-tests should use the driver environment for checking the accessibility bus
1247         https://bugs.webkit.org/show_bug.cgi?id=161149
1248
1249         Reviewed by Carlos Garcia Campos.
1250
1251         Add a new function for waiting for the accesibility bus. It sets
1252         the test environment variables before starting the GLib mainloop.
1253         And restores the previous environment after it has finished.
1254         It also adds a timeout (5 seconds) to abort in case it has not
1255         been able to detect the accesibility bus before the timeout expires.
1256
1257         * Scripts/run-gtk-tests:
1258         (TestRunner):
1259         (TestRunner._wait_for_accessibility_bus):
1260         (TestRunner._wait_for_accessibility_bus.timeout_accessibility_bus):
1261         (TestRunner._start_accessibility_daemons):
1262         (TestRunner._get_tests_from_google_test_suite): Run this command also with the driver test environment.
1263
1264 2016-08-26  Per Arne Vollan  <pvollan@apple.com>
1265
1266         [Win] Warning fix.
1267         https://bugs.webkit.org/show_bug.cgi?id=161236
1268
1269         Reviewed by Brent Fulgham.
1270
1271         The & operator in the Test struct has no body.
1272
1273         * TestWebKitAPI/Tests/WTF/Vector.cpp:
1274         (TestWebKitAPI::TEST):
1275
1276 2016-08-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1277
1278         [GTK] run-gtk-tests should use webkitpy.port.gtk and webkitpy.port.xvfbdriver
1279         https://bugs.webkit.org/show_bug.cgi?id=160736
1280
1281         Reviewed by Carlos Garcia Campos.
1282
1283         This plugs run-gtk-tests into the webkitpy testing infrastructure.
1284         As a benefit of this, run-gtk-tests now can be executed over any of
1285         the existing supported gtk test display servers (xvfb, weston-over-xvfb,
1286         or native xorg). A new command line switch --wayland is added for
1287         run-gtk-tests.
1288
1289         * Scripts/run-gtk-tests:
1290         (TestRunner.__init__): Remove the --display command line switch, its not longer useful.
1291         Add a --wayland command line switch.
1292         (TestRunner._start_accessibility_daemons):
1293         (TestRunner):
1294         (TestRunner.__init__):
1295         (TestRunner._run_xvfb): Deleted.
1296         (TestRunner._create_driver):
1297         (TestRunner._setup_testing_environment): Delete the environment variable definitions that
1298         are now done by driver._setup_environ_for_test().
1299         (TestRunner._tear_down_testing_environment):
1300         * Scripts/webkitpy/port/driver.py:
1301         (Driver.__init__): Define self._server_name in the constructor of the base class.
1302         It is used by several functions, so it makes sense to store once the value here.
1303         (Driver._setup_environ_for_test): Factorize setting the environment for a given test.
1304         (Driver._start): Get the environment from self._setup_environ_for_test()
1305         * Scripts/webkitpy/port/driver_unittest.py:
1306         (DriverTest):
1307         (DriverTest.test_setup_environ_for_test): Add unittest for driver._setup_environ_for_test()
1308         * Scripts/webkitpy/port/gtk.py: Move the inspection of the env var USE_NATIVE_XDISPLAY to the constructor.
1309         (GtkPort.__init__):
1310         (GtkPort._driver_class):
1311         * Scripts/webkitpy/port/westondriver.py: Define and use self._setup_environ_for_test()
1312         (WestonDriver._setup_environ_for_test):
1313         (WestonDriver._start):
1314         * Scripts/webkitpy/port/xorgdriver.py: Define and use self._setup_environ_for_test()
1315         (XorgDriver._setup_environ_for_test):
1316         (XorgDriver._start):
1317         * Scripts/webkitpy/port/xvfbdriver.py: Define and use self._setup_environ_for_test()
1318         (XvfbDriver._setup_environ_for_test):
1319         (XvfbDriver._start):
1320
1321 2016-08-26  Csaba Osztrogonác  <ossy@webkit.org>
1322
1323         [EFL][GTK] REGRESSION(204877): Fix the clean build
1324         https://bugs.webkit.org/show_bug.cgi?id=161240
1325
1326         Reviewed by Carlos Garcia Campos.
1327
1328         * WebKitTestRunner/PlatformEfl.cmake:
1329         * WebKitTestRunner/PlatformGTK.cmake:
1330
1331 2016-08-26  Aakash Jain  <aakash_jain@apple.com>
1332
1333         EWS should indicate which bot processed the patch
1334         https://bugs.webkit.org/show_bug.cgi?id=161222
1335
1336         Reviewed by Daniel Bates.
1337
1338         * QueueStatusServer/handlers/statusbubble.py:
1339         (StatusBubble._build_bubble): Display the bot id in status bubble. Also removed "Started processing" message since
1340         after bug fix of 161223, bots send the "Started processing patch" message and it would be displayed in Recent messages.
1341         Also added "Started processing patch" message to progress_statuses.
1342         I might consider displaying bot id in other statuses as well later on.
1343
1344 2016-08-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1345
1346         [EFL] Change homepage url to www.ewebkit.org on MiniBrowser
1347         https://bugs.webkit.org/show_bug.cgi?id=161184
1348
1349         Reviewed by Carlos Garcia Campos.
1350
1351         * MiniBrowser/efl/main.c: Set www.ewebkit.org.
1352
1353 2016-08-25  Aakash Jain  <aakash_jain@apple.com>
1354
1355         ews queues should update status server when they start processing patch
1356         https://bugs.webkit.org/show_bug.cgi?id=161223
1357
1358         Reviewed by Daniel Bates.
1359
1360         * Scripts/webkitpy/tool/commands/queues.py:
1361         (AbstractReviewQueue.process_work_item): Update status server that the bot started processing the patch.
1362         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1363         (EarlyWarningSystemTest._default_expected_logs): Updated the unit test accordingly.
1364         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1365         (StyleQueueTest.test_style_queue_with_style_exception): Same.
1366         (test_style_queue_with_watch_list_exception): Same.
1367         (test_non_valid_patch): Same.
1368
1369 2016-08-25  Alex Christensen  <achristensen@webkit.org>
1370
1371         CMake build fix.
1372
1373         * DumpRenderTree/PlatformMac.cmake:
1374
1375 2016-08-25  Alex Christensen  <achristensen@webkit.org>
1376
1377         Fix URLParserTest with GuardMalloc
1378         https://bugs.webkit.org/show_bug.cgi?id=161214
1379         rdar://problem/28014390
1380
1381         Reviewed by Tim Horton.
1382
1383         The CString returned by String::utf8 was going out of scope before we were doing a string comparison on its data.
1384         This just does the comparison of the CStrings instead to keep them in scope during the comparison.
1385
1386         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1387         (TestWebKitAPI::eq):
1388         (TestWebKitAPI::checkURL):
1389         (TestWebKitAPI::checkURLDifferences):
1390         (TestWebKitAPI::s): Deleted.
1391
1392 2016-08-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1393
1394         Dragging against the end of the inline media scrubber causes the media scrubber to hide
1395         https://bugs.webkit.org/show_bug.cgi?id=161207
1396
1397         Reviewed by Eric Carlson.
1398
1399         Tweaks an existing WebKit API test covering this behavior change. After some discussion, rather than hide media
1400         controls in this case, we should actually continue showing them. This is because seeking due to user gestures
1401         similar to "scrubbing" are indistinguishable from gestures that immediately seek to the end.
1402
1403         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1404         (TestWebKitAPI::TEST):
1405
1406 2016-08-25  Daniel Bates  <dabates@apple.com>
1407
1408         Watch more things.
1409
1410         * Scripts/webkitpy/common/config/watchlist:
1411
1412 2016-08-25  Daniel Bates  <dabates@apple.com>
1413
1414         Fix test failure on GTK Linux bots after <http://trac.webkit.org/changeset/204695>
1415         (https://bugs.webkit.org/show_bug.cgi?id=148437)
1416
1417         Remove use of module File::Slurp as it is not part of the standard Perl 5 distribution
1418         and is not installed on the GTK Linux bots.
1419
1420         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
1421         (writeFileWithContent): Added.
1422
1423 2016-08-25  Per Arne Vollan  <pvollan@apple.com>
1424
1425         [Win] run-api-tests is failing.
1426         https://bugs.webkit.org/show_bug.cgi?id=161140
1427
1428         Reviewed by Brent Fulgham.
1429
1430         Since the move constructor is called 3 more times on Windows, we will have 3 more destructor calls.
1431
1432         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
1433         (TestWebKitAPI::TEST):
1434
1435 2016-08-24  Per Arne Vollan  <pvollan@apple.com>
1436
1437         [Win] run-api-tests is failing.
1438         https://bugs.webkit.org/show_bug.cgi?id=161140
1439
1440         Reviewed by Brent Fulgham.
1441
1442         The number of times the move constructor is called is different on Windows in this test. This seems
1443         to be caused by differences in MSVC's implementation of lambdas or std functions like std::make_tuple.
1444
1445         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
1446         (TestWebKitAPI::TEST):
1447
1448 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
1449
1450         Fix iOS DRT build.
1451
1452         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1453         (WTR::UIScriptController::zoomToScale):
1454
1455 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
1456
1457         [iOS DRT] Hook up uiController.zoomToScale() for DRT
1458         https://bugs.webkit.org/show_bug.cgi?id=161173
1459
1460         Reviewed by Tim Horton.
1461         
1462         Make a UIWebScrollView subclass, DumpRenderTreeWebScrollView, which has an internal delegate to get
1463         UIScrollView delegate callbacks. Store the zoomToScaleCompletionHandler on it.
1464         
1465         UIScriptController::zoomToScale() has to bounce the zoom to the main thread (no poking UIKit from
1466         the WebThread!), but queue up the callback first.
1467
1468         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
1469         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
1470         (-[DumpRenderTreeWebScrollView initWithFrame:]):
1471         (-[DumpRenderTreeWebScrollView dealloc]):
1472         (-[DumpRenderTreeWebScrollView zoomToScale:animated:completionHandler:]):
1473         (-[DumpRenderTreeWebScrollView completedZoomToScale]):
1474         (-[DumpRenderTreeWebScrollViewDelegate initWithScrollView:]):
1475         (-[DumpRenderTreeWebScrollViewDelegate viewForZoomingInScrollView:]): All UIScrollView delegates need to implement this.
1476         (-[DumpRenderTreeWebScrollViewDelegate scrollViewDidEndZooming:withView:atScale:]):
1477         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1478         (WTR::UIScriptController::zoomToScale):
1479         * DumpRenderTree/mac/DumpRenderTree.mm:
1480         (createWebViewAndOffscreenWindow):
1481         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1482         (WTR::UIScriptController::context):
1483
1484 2016-08-24  Ryan Haddad  <ryanhaddad@apple.com>
1485
1486         Attempt to fix Windows build after r204918.
1487
1488         Unreviewed build fix.
1489
1490         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1491         (ResourceLoadDelegate::willSendRequest):
1492
1493 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
1494
1495         [iOS DRT] Get basic viewport tests working in DRT
1496         https://bugs.webkit.org/show_bug.cgi?id=161160
1497
1498         Reviewed by Tim Horton.
1499         
1500         Hook up enough of UIScriptController in iOS DRT to be able to read viewport
1501         scale, and get the contentVisibleRect.
1502         
1503         Requires exposing a bit of UIWebBrowserView SPI from UIKit, which in turn
1504         requires typing the gWebBrowserView as a DumpRenderTreeBrowserView * everywhere.
1505         
1506         One test has different results between DRT and WTR, but DRT behavior seems to differ
1507         from UIWebView here, so just give it a WK1-specific result.
1508
1509         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
1510         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
1511         (-[DumpRenderTreeBrowserView documentVisibleRect]):
1512         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1513         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1514         (WTR::UIScriptController::zoomScale):
1515         (WTR::UIScriptController::minimumZoomScale):
1516         (WTR::UIScriptController::maximumZoomScale):
1517         (WTR::UIScriptController::contentVisibleRect):
1518         * DumpRenderTree/mac/DumpRenderTree.mm:
1519         (createWebViewAndOffscreenWindow):
1520         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1521
1522 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
1523
1524         Minor project rearrangement.
1525
1526         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1527
1528 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
1529
1530         [iOS DRT] Make iOS DRT use the same window size as WebKitTestRunner for flexible viewport tests
1531         https://bugs.webkit.org/show_bug.cgi?id=161124
1532
1533         Reviewed by Daniel Bates.
1534         
1535         Use the main UIScreen's bounds for the size of the window in flexible viewport mode,
1536         and remove the 'phoneBrowserAddressBarOffset' hack, so that it matches WTR.
1537         
1538         Remove some unnecessary zero initializations of static variables.
1539         
1540         Change _setVisibleSize to use the window size, which should not be a behavior change
1541         because this it just used for text autosizing, which is disabled by default,
1542         and only the width is consulted.
1543
1544         * DumpRenderTree/mac/DumpRenderTree.mm:
1545         (adjustWebDocumentForFlexibleViewport):
1546         (adjustWebDocumentForStandardViewport):
1547         (createWebViewAndOffscreenWindow):
1548
1549 2016-08-24  Jonathan Bedard  <jbedard@apple.com>
1550
1551         WebKit2 needs layoutTestController.setDeferMainResourceDataLoad
1552         https://bugs.webkit.org/show_bug.cgi?id=42777
1553
1554         Reviewed by Darin Adler.
1555
1556         The setDeferMainResourceDataLoad method was not correctly tested in DumpRenderTree and would pass even when setDeterMainResourceDataLoad was not called.  Removed function and test.
1557
1558         * DumpRenderTree/TestRunner.cpp:
1559         (setDeferMainResourceDataLoadCallback): Removed setDeferMainResourceDataLoad.
1560         * DumpRenderTree/TestRunner.h:
1561         (TestRunner::deferMainResourceDataLoad): Ditto.
1562         (TestRunner::setDeferMainResourceDataLoad): Ditto.
1563         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Ditto.
1564
1565 2016-08-23  Anders Carlsson  <andersca@apple.com>
1566
1567         Add enum traits and use them in the IPC::Decoder
1568         https://bugs.webkit.org/show_bug.cgi?id=161103
1569
1570         Reviewed by Sam Weinig.
1571
1572         Add API test.
1573
1574         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1575         * TestWebKitAPI/Tests/WTF/EnumTraits.cpp: Added.
1576         (TestWebKitAPI::TEST):
1577
1578 2016-08-24  Filip Pizlo  <fpizlo@apple.com>
1579
1580         Unreviewed, roll out r204901, r204897, r204866, r204856, r204854.
1581
1582         * DumpRenderTree/TestRunner.cpp:
1583         * DumpRenderTree/mac/DumpRenderTree.mm:
1584         (DumpRenderTreeMain):
1585         * Scripts/run-jsc-stress-tests:
1586         * TestWebKitAPI/Tests/WTF/Vector.cpp:
1587         (TestWebKitAPI::TEST):
1588
1589 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
1590
1591         Try to fix Production builds.
1592         
1593         PRODUCTION_FRAMEWORKS_DIR was undefined here.
1594
1595         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1596
1597 2016-08-24  Dan Bernstein  <mitz@apple.com>
1598
1599         Add a convenience function for creating a WKFrameHandleRef from a WKFrameRef without going through WKFrameInfoRef
1600         https://bugs.webkit.org/show_bug.cgi?id=161152
1601
1602         Reviewed by Anders Carlsson.
1603
1604         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1605         * TestWebKitAPI/Tests/WebKit2/FrameHandle.cpp: Added.
1606         (TestWebKitAPI::didFinishLoadForFrame):
1607         (TestWebKitAPI::TEST):
1608
1609 2016-08-24  Nan Wang  <n_wang@apple.com>
1610
1611         AX: Add test for line text marker range on iOS
1612         https://bugs.webkit.org/show_bug.cgi?id=161108
1613         <rdar://problem/27976405>
1614
1615         Reviewed by Chris Fleizach.
1616
1617         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1618         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1619         (AccessibilityUIElement::textMarkerRangeForElement):
1620         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1621         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1622         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
1623
1624 2016-08-24  Per Arne Vollan  <pvollan@apple.com>
1625
1626         [Win] Warning fixes.
1627         https://bugs.webkit.org/show_bug.cgi?id=161079
1628
1629         Reviewed by Brent Fulgham.
1630
1631         * MiniBrowser/win/WebDownloadDelegate.cpp:
1632         * MiniBrowser/win/WinMain.cpp:
1633         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1634         (TestWebKitAPI::TEST):
1635
1636 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
1637
1638         Fix Windows DRT build.
1639
1640         * DumpRenderTree/win/TestRunnerWin.cpp:
1641         (TestRunner::mainFrameJSContext):
1642
1643 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
1644
1645         Try to fix Windows build.
1646         
1647         Pass Tools/DumpRenderTree/Bindings as the working directory for the generate_bindings.pl
1648         so that perl finds CodeGeneratorDumpRenderTree.pm.
1649
1650         * DumpRenderTree/CMakeLists.txt:
1651
1652 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
1653
1654         Hook up UIScriptController in DumpRenderTree
1655         https://bugs.webkit.org/show_bug.cgi?id=161064
1656
1657         Reviewed by Sam Weinig.
1658
1659         Add a skeleton implementation of UIScriptController to DumpRenderTree, building for both
1660         Mac and iOS. Currently this is sufficient to test doAsyncTask(), enabling two tests
1661         in fast/harness which test this.
1662
1663         Add a DerivedSources target to DumpRenderTree to invoke DerivedSources.make.
1664
1665         Move related code shared between WTR and DRT into Tools/TestRunnerShared, and cleanse it of
1666         WK2-isms. Fix the makefiles to refer to the new location.
1667
1668         Hook up TestRunner::runUIScript() for DumpRenderTree, which requires keeping track of callbacks
1669         by ID and firing them once they are complete.
1670
1671         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm: Added (copied from WTR).
1672         * DumpRenderTree/CMakeLists.txt:
1673         * DumpRenderTree/DerivedSources.make: Copied from Tools/WebKitTestRunner/DerivedSources.make.
1674         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1675         * DumpRenderTree/TestRunner.cpp:
1676         (runUIScriptCallback):
1677         (TestRunner::staticFunctions):
1678         (TestRunner::cacheTestRunnerCallback):
1679         (TestRunner::callTestRunnerCallback):
1680         (TestRunner::clearTestRunnerCallbacks):
1681         (nextUIScriptCallbackID):
1682         (TestRunner::runUIScript):
1683         (TestRunner::callUIScriptCallback):
1684         (TestRunner::uiScriptDidComplete):
1685         (TestRunner::cleanup):
1686         * DumpRenderTree/TestRunner.h:
1687         * DumpRenderTree/ios/UIScriptControllerIOS.mm: Added.
1688         * DumpRenderTree/mac/Configurations/Base.xcconfig: DerivedSources.make needs WEBCORE_PRIVATE_HEADERS_DIR to be defined.
1689         * DumpRenderTree/mac/DumpRenderTree.mm:
1690         (runTest):
1691         * DumpRenderTree/mac/TestRunnerMac.mm:
1692         (TestRunner::mainFrameJSContext):
1693         * DumpRenderTree/mac/UIScriptControllerMac.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h.
1694         (WTR::UIScriptController::doAsyncTask):
1695         * DumpRenderTree/win/DumpRenderTree.cpp:
1696         * TestRunnerShared/Bindings/JSWrappable.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h.
1697         (WTR::JSWrappable::~JSWrappable):
1698         (WTR::JSValueMakeStringOrNull):
1699         * TestRunnerShared/Bindings/JSWrapper.cpp: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp.
1700         (WTR::JSWrapper::wrap):
1701         (WTR::JSWrapper::unwrap):
1702         (WTR::unwrapObject):
1703         (WTR::JSWrapper::initialize):
1704         (WTR::JSWrapper::finalize):
1705         * TestRunnerShared/Bindings/JSWrapper.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h.
1706         (WTR::toJS):
1707         (WTR::setProperty):
1708         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: Renamed from Tools/WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl.
1709         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptContext.cpp.
1710         * TestRunnerShared/UIScriptContext/UIScriptContext.h: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptContext.h.
1711         (WTR::UIScriptContext::currentParentCallbackIsPendingCompletion):
1712         * TestRunnerShared/UIScriptContext/UIScriptController.cpp: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptController.cpp.
1713         * TestRunnerShared/UIScriptContext/UIScriptController.h: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptController.h.
1714         * WebKitTestRunner/CMakeLists.txt:
1715         * WebKitTestRunner/DerivedSources.make:
1716         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
1717         (WTR::JSWrappable::~JSWrappable): Deleted.
1718         (WTR::JSValueMakeStringOrNull): Deleted.
1719         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
1720         (WTR::JSWrapper::wrap): Deleted.
1721         (WTR::JSWrapper::unwrap): Deleted.
1722         (WTR::unwrapObject): Deleted.
1723         (WTR::JSWrapper::initialize): Deleted.
1724         (WTR::JSWrapper::finalize): Deleted.
1725         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h:
1726         (WTR::toJS): Deleted.
1727         (WTR::setProperty): Deleted.
1728         * WebKitTestRunner/TestInvocation.cpp:
1729         (WTR::TestInvocation::runUISideScript):
1730         (WTR::TestInvocation::uiScriptDidComplete):
1731         * WebKitTestRunner/TestInvocation.h:
1732         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp: Moved
1733         * WebKitTestRunner/UIScriptContext/UIScriptContext.h: Moved
1734         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp: Moved
1735         * WebKitTestRunner/UIScriptContext/UIScriptController.h: Moved
1736         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1737         * WebKitTestRunner/config.h:
1738         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1739         (WTR::UIScriptController::contentVisibleRect):
1740
1741 2016-08-23  Saam Barati  <sbarati@apple.com>
1742
1743         JSC should have a "microbenchmarks" directory instead of "regress" directory
1744         https://bugs.webkit.org/show_bug.cgi?id=161096
1745
1746         Rubber stamped by Mark Lam.
1747
1748         This patch moves LayoutTests/js/regress/script-tests to the JSTests/microbenchmarks
1749         directory and removes all the related html and txt files. I did this because
1750         that directory was only there for microbenchmarks, and not for "regression"
1751         tests. I also changed the various scripts to point to it.
1752
1753         * Scripts/run-javascriptcore-tests:
1754         (runJSCStressTests):
1755         * Scripts/run-jsc-benchmarks:
1756
1757 2016-08-23  Alex Christensen  <achristensen@webkit.org>
1758
1759         Fix EFL build.
1760
1761         * TestWebKitAPI/CMakeLists.txt:
1762         Include new directory.
1763
1764 2016-08-22  Filip Pizlo  <fpizlo@apple.com>
1765
1766         Butterflies should be allocated in Auxiliary MarkedSpace instead of CopiedSpace and we should rewrite as much of the GC as needed to make this not a regression
1767         https://bugs.webkit.org/show_bug.cgi?id=160125
1768
1769         Reviewed by Geoffrey Garen.
1770
1771         * DumpRenderTree/TestRunner.cpp: Rewire some #includes.
1772         * Scripts/run-jsc-stress-tests: New test flag!
1773
1774 2016-08-23  Brady Eidson  <beidson@apple.com>
1775
1776         WK2 Gamepad layout test support.
1777         https://bugs.webkit.org/show_bug.cgi?id=134671
1778
1779         Reviewed by Alex Christensen.
1780         
1781         Have the injected bundle expose the MockGamepadProvider to the UI process, which will then 
1782         feed back into the UIGamepadProvider.
1783         
1784         Also, fool NSApplication into treating the most recently created "isKeyWindow" of the test windows
1785         as the actual keyWindow for the test runner, which will allow the view to get gamepad updates.
1786
1787         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
1788         
1789         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1790         (WTR::TestRunner::setMockGamepadDetails):
1791         (WTR::TestRunner::setMockGamepadAxisValue):
1792         (WTR::TestRunner::setMockGamepadButtonValue):
1793         
1794         * WebKitTestRunner/PlatformWebView.h:
1795         
1796         * WebKitTestRunner/TestController.cpp:
1797         (WTR::TestController::initialize):
1798         
1799         * WebKitTestRunner/TestInvocation.cpp:
1800         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1801         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Deleted.
1802         
1803         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1804         
1805         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1806         (-[WebKitTestRunnerWindow initWithFrame:]):
1807         (-[WebKitTestRunnerWindow dealloc]):
1808         (WTR::PlatformWebView::keyWindow):
1809         
1810         * WebKitTestRunner/ios/TestControllerIOS.mm:
1811         (WTR::wtr_NSApplication_keyWindow):
1812         (WTR::TestController::platformInitialize):
1813         
1814         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1815         (+[WebKitTestRunnerWindow _WTR_keyWindow]):
1816         (-[WebKitTestRunnerWindow initWithContentRect:styleMask:backing:defer:]):
1817         (-[WebKitTestRunnerWindow dealloc]):
1818         (WTR::PlatformWebView::keyWindow):
1819         
1820         * WebKitTestRunner/mac/TestControllerMac.mm:
1821         (WTR::wtr_NSApplication_keyWindow):
1822         (WTR::TestController::platformInitialize):
1823         * WebKitTestRunner/mac/main.mm:
1824
1825 2016-08-23  Alexey Proskuryakov  <ap@apple.com>
1826
1827         REGRESSION (PHP 5.6): http/tests/misc/bad-charset-alias.html fails
1828         https://bugs.webkit.org/show_bug.cgi?id=161047
1829         rdar://problem/27434307
1830
1831         Reviewed by Lucas Forschler.
1832
1833         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py: Specify a php.ini file.
1834
1835 2016-08-23  Chris Dumez  <cdumez@apple.com>
1836
1837         Unreviewed, rolling out r204243.
1838
1839         Caused some layout test failures
1840
1841         Reverted changeset:
1842
1843         "Write API test to cover crash fix in r204135"
1844         https://bugs.webkit.org/show_bug.cgi?id=160587
1845         http://trac.webkit.org/changeset/204243
1846
1847 2016-08-23  Rawinder Singh  <rawinder.singh-webkit@cisra.canon.com.au>
1848
1849         Order feature option list in FeatureList.pm
1850         https://bugs.webkit.org/show_bug.cgi?id=161074
1851
1852         Reviewed by Michael Catanzaro.
1853
1854         Reorder features in alphabetical order based on command line option. Also, sort variables in alphabetical order.
1855
1856         * Scripts/webkitperl/FeatureList.pm:
1857
1858 2016-08-22  Dewei Zhu  <dewei_zhu@apple.com>
1859
1860         Stop python icon bouncing in the dock while running browser benchmarks.
1861         https://bugs.webkit.org/show_bug.cgi?id=161066
1862
1863         Reviewed by Ryosuke Niwa.
1864
1865         Bouncing python icon may impact browser benchmark results.
1866         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1867         (OSXBrowserDriver.prepare_env):
1868         (OSXBrowserDriver.restore_env):
1869
1870 2016-08-22  Simon Fraser  <simon.fraser@apple.com>
1871
1872         <select> menu on iPad causes shifting of hit-testing areas
1873         https://bugs.webkit.org/show_bug.cgi?id=150079
1874
1875         Reviewed by Tim Horton.
1876
1877         -isAssistingNode (aka the poorly named isEditable) is input into WebPageProxy::computeCustomFixedPositionRect(),
1878         so when it changes we have to update visible rects. We were doing this on focus, but failing
1879         to do it on blur.
1880
1881         Added the ability to test by:
1882         1. Making it possible to initiate an animated scroll in the UI process
1883         2. Adding callbacks for starting and ending interaction with a form control. Sadly
1884         the "ending interaction" for <select> popovers on iPad isn't late enough, since we
1885         have no way currently to know when the dimming view behind the popover animates out,
1886         so for now the test keeps trying to tap a button.
1887
1888         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
1889         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
1890         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1891         (WTR::UIScriptController::setDidStartFormControlInteractionCallback):
1892         (WTR::UIScriptController::didStartFormControlInteractionCallback):
1893         (WTR::UIScriptController::setDidEndFormControlInteractionCallback):
1894         (WTR::UIScriptController::didEndFormControlInteractionCallback):
1895         (WTR::UIScriptController::scrollToOffset):
1896         (WTR::UIScriptController::platformSetDidStartFormControlInteractionCallback):
1897         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback):
1898         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1899         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1900         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1901         (-[TestRunnerWKWebView dealloc]):
1902         (-[TestRunnerWKWebView didStartFormControlInteraction]):
1903         (-[TestRunnerWKWebView didEndFormControlInteraction]):
1904         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1905         (WTR::contentOffsetBoundedInValidRange):
1906         (WTR::UIScriptController::scrollToOffset):
1907         (WTR::UIScriptController::platformSetDidStartFormControlInteractionCallback):
1908         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback):
1909
1910 2016-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1911
1912         [EFL][GTK] Script process-linux-coredump is not needed, switch back to use the kernel core dumper instead.
1913         https://bugs.webkit.org/show_bug.cgi?id=160927
1914
1915         Reviewed by Daniel Bates.
1916
1917         * Scripts/process-linux-coredump: Removed.
1918         * Scripts/webkitpy/port/efl.py:
1919         (EflPort._get_crash_log):
1920         * Scripts/webkitpy/port/gtk.py:
1921         (GtkPort._get_crash_log):
1922         * Scripts/webkitpy/port/linux_get_crash_log.py:
1923         (GDBCrashLogGenerator.__init__):
1924         (GDBCrashLogGenerator.generate_crash_log):
1925         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1926         (GDBCrashLogGeneratorTest.test_generate_crash_log):
1927
1928 2016-08-22  Jonathan Bedard  <jbedard@apple.com>
1929
1930         check-webkit-style does not work with Lambda functions in C++
1931         https://bugs.webkit.org/show_bug.cgi?id=160910
1932
1933         Reviewed by Darin Adler.
1934
1935         This change eliminates false positives on correctly styled lambda functions and includes a few basic checks on capture list.
1936
1937         * Scripts/webkitpy/style/checkers/cpp.py:
1938         (regex_for_lambda_functions): Added function which checks if a string is the start of a lambda function.
1939         (check_for_non_standard_constructs): Added lambda function check.
1940         (check_spacing_for_function_call): Added lambda function check.
1941         (check_braces): Added lambda function check.
1942         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1943         (CppStyleTest.test_lambda_functions): Added test function for lambda function style checks.
1944
1945 2016-08-21  Alex Christensen  <achristensen@webkit.org>
1946
1947         URLParser should parse IPv4 addresses
1948         https://bugs.webkit.org/show_bug.cgi?id=161023
1949
1950         Reviewed by Darin Adler.
1951
1952         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1953         (TestWebKitAPI::TEST_F):
1954         (TestWebKitAPI::checkURLDifferences):
1955         We are already getting differences between the old URL::parse and the new URLParser.
1956         (TestWebKitAPI::shouldFail):
1957
1958 2016-08-21  Daniel Bates  <dabates@apple.com>
1959
1960         prepare-ChangeLog lists unmodified functions as modified and marks functions with few changes as deleted
1961         https://bugs.webkit.org/show_bug.cgi?id=148437
1962
1963         Reviewed by Dan Bernstein.
1964
1965         * Scripts/prepare-ChangeLog:
1966         (diffCommand): When using a Subversion checkout, generate a unified diff without any context lines.
1967         This matches our behavior when using a Git checkout. The function overlap logic in generateFunctionListsByRanges()
1968         assumes that its line ranges were from a unified diff without any context lines.
1969         (extractLineRangeAfterChange): A deleted line should be represented with a ("begin line number", "end line number") = ("new starting line number", "new starting line number").
1970         (extractLineRangeBeforeChange): An added line should be represented with a ("begin line number", "end line number") = ("original starting line number", "original starting line number").
1971         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl: Update expected results
1972         based on changes to extractLineRangeAfterChange() and extractLineRangeBeforeChange().
1973         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl: Added.
1974         (discardOutput): Convenience function invokes the specified function redirecting standard output and standard error
1975         to /dev/null for the duration of the function call.
1976
1977 2016-08-20  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
1978
1979         [EFL] Remove unnecessary a patch to mute ecore warnings
1980         https://bugs.webkit.org/show_bug.cgi?id=160997
1981
1982         Reviewed by Darin Adler.
1983
1984         There is no warning messages during the layout test and perf test
1985         after bumping efl version from 1.17 to 1.18. Remove it.
1986
1987         * efl/patches/ecore_remove_warnings.patch: Removed.
1988
1989 2016-08-20  Simon Fraser  <simon.fraser@apple.com>
1990
1991         REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
1992         https://bugs.webkit.org/show_bug.cgi?id=160985
1993
1994         Re-land r204672, but don't check the result of 'xcrun simctl shutdown', because
1995         device shutdown seems to happen as result of killing Simulator.apps, and we're racing
1996         with that.
1997
1998         * Scripts/webkitpy/layout_tests/views/printing.py:
1999         (Printer.print_config):
2000         * Scripts/webkitpy/port/base.py:
2001         (Port.driver_cmd_line_for_logging):
2002         (Port.driver_cmd_line): Deleted.
2003         * Scripts/webkitpy/port/driver.py:
2004         (IOSSimulatorDriver.cmd_line):
2005         * Scripts/webkitpy/port/ios.py:
2006         (IOSSimulatorPort.__init__):
2007         (IOSSimulatorPort.driver_cmd_line_for_logging):
2008         (IOSSimulatorPort._create_simulators):
2009         (IOSSimulatorPort.setup_test_run):
2010         (IOSSimulatorPort._quit_ios_simulator):
2011         (IOSSimulatorPort.clean_up_test_run):
2012         (IOSSimulatorPort._create_device):
2013         (IOSSimulatorPort):
2014         (IOSSimulatorPort._remove_device):
2015         (IOSSimulatorPort._testing_device):
2016         (IOSSimulatorPort.device_id_for_worker_number):
2017         (IOSSimulatorPort._set_device_class): Deleted.
2018         (IOSSimulatorPort.testing_device): Deleted.
2019         * Scripts/webkitpy/port/port_testcase.py:
2020         (PortTestCase.test_driver_cmd_line):
2021         * Scripts/webkitpy/xcode/simulator.py:
2022         (Device.shutdown):
2023         (Device):
2024         (Device.delete):
2025         (Device.reset):
2026         (Simulator):
2027         (Simulator.create_device):
2028         (Simulator.remove_device):
2029         (Simulator.device_number):
2030         (Simulator.device_state_description):
2031         (Simulator.wait_until_device_is_in_state):
2032
2033 2016-08-19  Ryan Haddad  <ryanhaddad@apple.com>
2034
2035         Unreviewed, rolling out r204659.
2036
2037         This change appears to have caused ios-simulator LayoutTests
2038         to fail when shutting down the simulator
2039
2040         Reverted changeset:
2041
2042         "REGRESSION (r204477): Running LayoutTests on ios-simulator
2043         became ~15 minutes slower"
2044         https://bugs.webkit.org/show_bug.cgi?id=160985
2045         http://trac.webkit.org/changeset/204659
2046
2047 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
2048
2049         Build fix for non-USE_SIM_SERVICE_CONTEXT builds
2050         * LayoutTestRelay/LayoutTestRelay/main.m: (main):
2051
2052 2016-08-18  Simon Fraser  <simon.fraser@apple.com>
2053
2054         REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
2055         https://bugs.webkit.org/show_bug.cgi?id=160985
2056
2057         Reviewed by Alexey Proskuryakov.
2058         
2059         r204477 removed @memoized on a couple of ios.py functions, causing them to instantiate
2060         a Simulator() on every call, which causes 'xcrun simctl list' to run. The functions
2061         must not be @memoized, because their return value depends on the value of simulator_device_type().
2062         
2063         Fix by adding some global state in simulator.py that tracks the created devices 
2064         in a worker number -> Device dictionary. Explicitly create devices in _create_simulators(),
2065         and delete them in clean_up_test_run().
2066         
2067         Also explicitly called 'xcrun simctl shutdown' to shut down devices, since it seems
2068         that killing the Simulator apps isn't enough.
2069         
2070         Simulator tracks the devices in a global dictionary, since state needs to persist
2071         across different instances of IOSSimulatorPort.
2072         
2073         Annoyingly, the "Command line:" dumping tried to access a device before we'd done
2074         any setup. Rather than implicitly creating a device here (which the old code did),
2075         override the more clearly named driver_cmd_line_for_logging() in IOSSimulatorPort
2076         and set flag to say that device_id_for_worker_number() doesn't need to return a real
2077         device id.
2078
2079         * Scripts/webkitpy/layout_tests/views/printing.py:
2080         (print_options):
2081         (Printer.print_config):
2082         * Scripts/webkitpy/port/base.py:
2083         (Port.driver_cmd_line_for_logging):
2084         (Port.driver_cmd_line): Deleted.
2085         * Scripts/webkitpy/port/driver.py:
2086         (IOSSimulatorDriver.cmd_line):
2087         * Scripts/webkitpy/port/ios.py:
2088         (IOSSimulatorPort.__init__):
2089         (IOSSimulatorPort.driver_cmd_line_for_logging):
2090         (IOSSimulatorPort._create_simulators):
2091         (IOSSimulatorPort.setup_test_run):
2092         (IOSSimulatorPort.clean_up_test_run):
2093         (IOSSimulatorPort._create_device):
2094         (IOSSimulatorPort):
2095         (IOSSimulatorPort._remove_device):
2096         (IOSSimulatorPort._testing_device):
2097         (IOSSimulatorPort.device_id_for_worker_number):
2098         (IOSSimulatorPort._set_device_class): Deleted.
2099         (IOSSimulatorPort.testing_device): Deleted.
2100         * Scripts/webkitpy/port/port_testcase.py:
2101         (PortTestCase.test_driver_cmd_line):
2102         * Scripts/webkitpy/xcode/simulator.py:
2103         (Device.shutdown):
2104         (Device.delete):
2105         (Device.reset):
2106         (Simulator.create_device):
2107         (Simulator.remove_device):
2108         (Simulator.device_number):
2109         (Simulator.device_state_description):
2110         (Simulator.wait_until_device_is_in_state):
2111
2112 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
2113
2114         Adopt SimServiceContext in LayoutTestRelay
2115         https://bugs.webkit.org/show_bug.cgi?id=161000
2116         <rdar://problem/25765594>
2117
2118         Reviewed by Daniel Bates.
2119
2120         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
2121         * LayoutTestRelay/LayoutTestRelay/main.m:
2122
2123 2016-08-19  Lucas Forschler  <lforschler@apple.com>
2124
2125         Remove Yosemite Leaks bot after http://trac.webkit.org/projects/webkit/changeset/204629
2126
2127         Reviewed by Kocsen Chung.
2128
2129         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2130         (WebKitBuildbot):
2131
2132 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
2133
2134         Partial revert of r203811 - this key is not needed.
2135
2136         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: (-[LTRelayController installApp]):
2137
2138 2016-08-19  Daniel Bates  <dabates@apple.com>
2139
2140         Another attempt to fix the iOS 9.3 build
2141
2142         Define WK_EMPTY_, WK_NOT_, and WK_NOT_YES.
2143
2144         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2145         * WebKitTestRunner/Configurations/Base.xcconfig:
2146
2147 2016-08-19  Lucas Forschler  <lforschler@apple.com>
2148
2149         Remove Yosemite Leaks bot from config.json
2150         
2151         Reviewed by Alexey Proskuryakov.
2152
2153         * BuildSlaveSupport/build.webkit.org-config/config.json:
2154
2155 2016-08-18  Dan Bernstein  <mitz@apple.com>
2156
2157         [Cocoa] API::Number needs to be wrapped by an NSNumber
2158         https://bugs.webkit.org/show_bug.cgi?id=160977
2159         <rdar://problem/27877735>
2160
2161         Reviewed by Anders Carlsson.
2162
2163         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2164         * TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm: Added.
2165         (TestWebKitAPI::TEST):
2166
2167 2016-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
2168
2169         [Cocoa] Migrate off of deprecated CoreGraphics API CGContextSelectFont() and CGContextShowTextAtPoint()
2170         https://bugs.webkit.org/show_bug.cgi?id=160895
2171
2172         Reviewed by Dean Jackson.
2173
2174         Link to the existing CoreText framework.
2175
2176         * DumpRenderTree/PlatformWin.cmake:
2177         * TestWebKitAPI/PlatformWin.cmake:
2178
2179 2016-08-17  Brent Fulgham  <bfulgham@apple.com>
2180
2181         [Win] Remove old libraries from build inputs
2182         https://bugs.webkit.org/show_bug.cgi?id=160949
2183
2184         Reviewed by Dean Jackson.
2185
2186         Modify the download script to remove the old 'icuuc.lib' and
2187         'icuin.lib' files for Windows builds.
2188
2189         * Scripts/update-webkit-auxiliary-libs:
2190
2191 2016-08-17  Jonathan Bedard  <jbedard@apple.com>
2192
2193         Extra logging for crash reason
2194         https://bugs.webkit.org/show_bug.cgi?id=160943
2195
2196         Reviewed by Alexey Proskuryakov.
2197
2198         A number of tests have been erroneously marked as crashed, this should help diagnose these false crashes.
2199
2200         * Scripts/webkitpy/port/server_process.py:
2201         (ServerProcess.write): Add extra logging to determine why a process has been marked as crashed.
2202         (ServerProcess._wait_for_data_and_update_buffers_using_select): Ditto.
2203         (ServerProcess.has_crashed): Ditto.
2204
2205 2016-08-17  Dan Bernstein  <mitz@apple.com>
2206
2207         [Cocoa] -[NSString isEqualToString:] returns NO for any WKNSString argument
2208         https://bugs.webkit.org/show_bug.cgi?id=160938
2209         <rdar://problem/27876652>
2210
2211         Reviewed by Anders Carlsson.
2212
2213         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2214         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm: Added.
2215         (TestWebKitAPI::TEST):
2216
2217 2016-08-17  Chris Fleizach  <cfleizach@apple.com>
2218
2219         AX: Support abbreviations in iOS
2220         https://bugs.webkit.org/show_bug.cgi?id=160907
2221
2222         Reviewed by Joanmarie Diggs.
2223
2224         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2225         (AccessibilityUIElement::stringAttributeValue):
2226         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2227         (WTR::AccessibilityUIElement::stringAttributeValue):
2228
2229 2016-08-17  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
2230
2231         [EFL] Bump efl version from 1.17 to 1.18
2232         https://bugs.webkit.org/show_bug.cgi?id=160899
2233
2234         Reviewed by Antonio Gomes.
2235
2236         To use efl-1.18, EFL port needs to update install dependencies as well.
2237
2238         * efl/install-dependencies:
2239         * efl/jhbuild.modules:
2240
2241 2016-08-17  Per Arne Vollan  <pvollan@apple.com>
2242
2243         [Win] Add tests for linked fonts.
2244         https://bugs.webkit.org/show_bug.cgi?id=160898
2245
2246         Reviewed by Brent Fulgham.
2247
2248         Add tests for https://trac.webkit.org/changeset/204502.
2249
2250         * TestWebKitAPI/PlatformWin.cmake:
2251         * TestWebKitAPI/Tests/WebCore/win/LinkedFonts.cpp: Added.
2252         (TestWebKitAPI::TEST):
2253
2254 2016-08-16  Daniel Bates  <dabates@apple.com>
2255
2256         prepare-ChangeLog: Extract logic from generateFunctionLists() into a function that takes a delegate object
2257         https://bugs.webkit.org/show_bug.cgi?id=160924
2258
2259         Reviewed by Stephanie Lewis.
2260
2261         Towards adding unit tests for generateFunctionLists() we move its logic into actuallyGenerateFunctionLists()
2262         and have actuallyGenerateFunctionLists() take a delegate object to use to query the file system and SCM.
2263         We modify generateFunctionLists() to call actuallyGenerateFunctionLists(). This will make is possible to
2264         test the generate function list machinery without requiring a SCM checkout by substituting a delegate
2265         object that mocks out the file system and SCM operations.
2266
2267         * Scripts/VCSUtils.pm:
2268         (parseDiffStartLine): Parses an SVN or Git start line and returns the path to the target file.
2269         * Scripts/prepare-ChangeLog:
2270         (generateFunctionLists): Move functionality to actually generate the function lists to actuallyGenerateFunctionLists(),
2271         abstracting the logic to query the file system and SCM into functions on a delegate object that
2272         we pass to it.
2273         (actuallyGenerateFunctionLists): Extracted from generateFunctionLists().
2274         (diffHeaderFormat): Deleted.
2275
2276 2016-08-16  Alex Christensen  <achristensen@webkit.org>
2277
2278         URLParser should parse URLs without credentials
2279         https://bugs.webkit.org/show_bug.cgi?id=160913
2280
2281         Reviewed by Brady Eidson.
2282
2283         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2284         (TestWebKitAPI::s):
2285         (TestWebKitAPI::checkURL):
2286         (TestWebKitAPI::TEST_F):
2287
2288 2016-08-16  Anders Carlsson  <andersca@apple.com>
2289
2290         Add WTF::ScopeExit
2291         https://bugs.webkit.org/show_bug.cgi?id=160908
2292
2293         Reviewed by Geoffrey Garen.
2294
2295         * TestWebKitAPI/CMakeLists.txt:
2296         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2297         * TestWebKitAPI/Tests/WTF/Scope.cpp: Added.
2298         (TestWebKitAPI::TEST):
2299
2300 2016-08-16  Aakash Jain  <aakash_jain@apple.com>
2301
2302         EWS logs file are rotated too quickly
2303         https://bugs.webkit.org/show_bug.cgi?id=160724
2304
2305         Reviewed by Daniel Bates.
2306
2307         Currently we are rotating the log file after 10 iterations of queue. If the queue
2308         doesn't have any pending patches, these iterations result in very small amount of 
2309         logs (1 KB log file). Even if the queue process some patches, logs are few KBs.
2310         This results in a lot of log files in a day. This patch ensures that we rotate the
2311         log file when its file size is greater than or equal to 100 KB.
2312
2313         * EWSTools/start-queue-mac.sh: Added check for file size before rotating log file.
2314
2315 2016-08-16  Daniel Bates  <dabates@apple.com>
2316
2317         WKSI static library should be named by major iOS revision, not individual updates
2318         https://bugs.webkit.org/show_bug.cgi?id=160727
2319         <rdar://problem/22274848>
2320
2321         Reviewed by Alexey Proskuryakov.
2322
2323         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2324         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2325         * Scripts/copy-webkitlibraries-to-product-directory:
2326         * WebKitTestRunner/Configurations/Base.xcconfig:
2327         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2328
2329 2016-08-16  Simon Fraser  <simon.fraser@apple.com>
2330
2331         Make it possible to test iOS select elements, and add iPhone and iPad tests for them
2332         https://bugs.webkit.org/show_bug.cgi?id=160909
2333
2334         Reviewed by Enrica Casucci.
2335         
2336         Add functions to UIScriptController to dismiss the form accessory view for iOS,
2337         and to programmatically pick a row from a <select> picker.
2338
2339         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
2340         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
2341         (WTR::UIScriptController::dismissFormAccessoryView):
2342         (WTR::UIScriptController::selectFormAccessoryPickerRow):
2343         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
2344         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2345         (WTR::UIScriptController::dismissFormAccessoryView):
2346         (WTR::UIScriptController::selectFormAccessoryPickerRow):
2347
2348 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
2349
2350         [iOS] Add iPad viewport and form tests, and revert the iPad-testing part of r202132
2351         https://bugs.webkit.org/show_bug.cgi?id=160878
2352
2353         Reviewed by Tim Horton.
2354         
2355         Remove testing-specific "forceIPadStyleZoomOnInputFocus" behavior added in r202132
2356         now that we have the ability to run tests in the iPad simulator.
2357
2358         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
2359         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
2360         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
2361         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
2362         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
2363         * WebKitTestRunner/ios/TestControllerIOS.mm:
2364         (WTR::TestController::platformResetStateToConsistentValues): Deleted.
2365         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2366         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
2367         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
2368
2369 2016-08-15  Anders Carlsson  <andersca@apple.com>
2370
2371         Add an address-of operator to RetainPtr
2372         https://bugs.webkit.org/show_bug.cgi?id=160879
2373
2374         Reviewed by Tim Horton.
2375
2376         Test HashMap and HashSet with an object whose operator& is deleted.
2377
2378         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2379         Sort the Xcode project.
2380
2381         * TestWebKitAPI/Tests/WTF/DeletedAddressOfOperator.h: Added.
2382         (DeletedAddressOfOperator::DeletedAddressOfOperator):
2383         (DeletedAddressOfOperator::value):
2384         (DeletedAddressOfOperator::operator==):
2385         (WTF::HashTraits<DeletedAddressOfOperator>::constructDeletedValue):
2386         (WTF::HashTraits<DeletedAddressOfOperator>::isDeletedValue):
2387         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::hash):
2388         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::equal):
2389         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2390         (TestWebKitAPI::TEST):
2391         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2392         (TestWebKitAPI::TEST):
2393
2394 2016-08-16  Jonathan Bedard  <jbedard@apple.com>
2395
2396         False crashes in fast/text/emoji-gender-* tests
2397         https://bugs.webkit.org/show_bug.cgi?id=160779
2398
2399         Reviewed by Alexey Proskuryakov.
2400
2401         Fix from <rdar://problem/27786762>, where timed out tests falsely report as crashed.
2402
2403         * Scripts/webkitpy/port/driver.py:
2404         (Driver._check_for_driver_crash_or_unresponsiveness): Change call to ‘write’ to disable crash flag.
2405         * Scripts/webkitpy/port/driver_unittest.py: Added 3 variable to test version of ‘write.’
2406         * Scripts/webkitpy/port/server_process.py:
2407         (ServerProcess.write): Allow caller to disable crash flag on exception.
2408
2409 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
2410
2411         webkitpy error in TestRunResults.merge()
2412         https://bugs.webkit.org/show_bug.cgi?id=160882
2413
2414         Reviewed by Daniel Bates.
2415         
2416         The argument to TestRunResults.merge() can be None if there are no device-specifc
2417         initial results or retry results in Manager.run(), so just return early in that case.
2418
2419         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2420         (TestRunResults.merge):
2421
2422 2016-08-15  Sam Weinig  <sam@webkit.org>
2423
2424         Speed up compile times by not including wtf/Variant.h so much
2425         https://bugs.webkit.org/show_bug.cgi?id=160847
2426
2427         Reviewed by Alex Christensen and Saam Barati.
2428
2429         * TestWebKitAPI/Tests/WTF/Variant.cpp:
2430         (TestWebKitAPI::TEST):
2431         Explicitly use std::experimental::variant.
2432
2433 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
2434
2435         Allow a port to run tests with a custom device setup
2436         https://bugs.webkit.org/show_bug.cgi?id=160833
2437
2438         Reviewed by Daniel Bates.
2439
2440         These changes allow the IOSSimulator port to run tests in iPad mode.
2441
2442         This is made possible by allowing a platform to define CUSTOM_DEVICE_CLASSES,
2443         in this case 'ipad'. When specified, any test in a directory with a suffix that matches
2444         a custom device will be collected into a set, and run in that device's environment after
2445         the other tests have run.
2446
2447         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2448         (Manager._custom_device_for_test): If the test contains a directory matching a
2449         custom device suffix, return that custom device.
2450         (Manager._set_up_run): Push the custom device class, if any, into options so
2451         that the Worker can get to it.
2452         (Manager.run): Go through the list of tests, and break it down into device-generic
2453         tests, and tests for each device class. _run_test_subset is then called for
2454         each collection of tests, and the results merged.
2455         (Manager._run_test_subset): Some lines unwrapped.
2456         (Manager._end_test_run):
2457         (Manager._run_tests):
2458         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2459         (SingleTestRunner.__init__): Unwrapped a line.
2460         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2461         (TestRunResults.merge): Add this function to merge TestRunResults
2462         * Scripts/webkitpy/layout_tests/views/printing.py:
2463         (Printer.print_workers_and_shards): Print the custom device, if any.
2464         * Scripts/webkitpy/port/base.py:
2465         (Port): Base port has empty array of custom devices.
2466         (Port.setup_test_run): Add device_class argument.
2467         * Scripts/webkitpy/port/driver.py:
2468         (DriverInput.__repr__):
2469         (Driver.check_driver.implementation):
2470         * Scripts/webkitpy/port/efl.py:
2471         (EflPort.setup_test_run):
2472         * Scripts/webkitpy/port/gtk.py:
2473         (GtkPort.setup_test_run):
2474         * Scripts/webkitpy/port/ios.py:
2475         (IOSSimulatorPort): Add CUSTOM_DEVICE_CLASSES for ipad.
2476         (IOSSimulatorPort.__init__):
2477         (IOSSimulatorPort.simulator_device_type): Use a device name from the DEVICE_CLASS_MAP
2478         based on the custom device class.
2479         (IOSSimulatorPort._set_device_class):
2480         (IOSSimulatorPort._create_simulators): Factor some code into this function.
2481         (IOSSimulatorPort.setup_test_run):
2482         (IOSSimulatorPort.testing_device):
2483         (IOSSimulatorPort.reset_preferences): This used to create the simulator apps, but that
2484         seemed wrong for this function. That was moved to setup_test_run().
2485         (IOSSimulatorPort.check_sys_deps): This function used to create testing devices,
2486         but this happened too early, before we knew which kind of devices to create. Devices
2487         are now created in setup_test_run().
2488         * Scripts/webkitpy/port/win.py:
2489         (WinPort.setup_test_run):
2490
2491 2016-08-15  Daniel Bates  <dabates@apple.com>
2492
2493         Cannot build WebKit for iOS device using Xcode 7.3/iOS 9.3 public SDK due to missing
2494         private frameworks and libraries
2495         https://bugs.webkit.org/show_bug.cgi?id=155931
2496         <rdar://problem/25807989>
2497
2498         Reviewed by Dan Bernstein.
2499
2500         Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
2501         where X is the major version of the active iOS SDK.
2502
2503         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2504         * WebKitTestRunner/Configurations/Base.xcconfig:
2505
2506 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
2507
2508         Add a setting and preferences to enable visual viewport mode
2509         https://bugs.webkit.org/show_bug.cgi?id=160843
2510
2511         Reviewed by Sam Weinig.
2512         
2513         Pref and a menu item to toggle visualViewportEnabled for WebKits 1 and 2.
2514
2515         * MiniBrowser/mac/SettingsController.h:
2516         * MiniBrowser/mac/SettingsController.m:
2517         (-[SettingsController _populateMenu]):
2518         (-[SettingsController validateMenuItem:]):
2519         (-[SettingsController visualViewportEnabled]):
2520         (-[SettingsController toggleVisualViewportEnabled:]):
2521         * MiniBrowser/mac/WK1BrowserWindowController.m:
2522         (-[WK1BrowserWindowController didChangeSettings]):
2523         * MiniBrowser/mac/WK2BrowserWindowController.m:
2524         (-[WK2BrowserWindowController didChangeSettings]):
2525
2526 2016-08-15  Konstantin Tokarev  <annulen@yandex.ru>
2527
2528         Allow using make-dist with non-GTK ports
2529         https://bugs.webkit.org/show_bug.cgi?id=160842
2530
2531         Reviewed by Michael Catanzaro.
2532
2533         This patch adds support for setting base name of tarball and argument
2534         passed to cmake's -DPORT= via command line arguments.
2535
2536         * gtk/make-dist.py:
2537         (Distcheck.configure):
2538         (Distcheck.check):
2539         (get_tarball_root_and_output_filename_from_arguments):
2540
2541 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2542
2543         [GTK] Install script lacks gstreamer related dependencies
2544         https://bugs.webkit.org/show_bug.cgi?id=160814
2545
2546         Reviewed by Carlos Garcia Campos.
2547
2548         * gtk/install-dependencies: Fedora case had already listed this dependencies,
2549         but both Arch and Debian/Ubuntu were missing them.
2550
2551 2016-08-13  Konstantin Tokarev  <annulen@yandex.ru>
2552
2553         make-dist.py should not allow unknown rules in manifest
2554         https://bugs.webkit.org/show_bug.cgi?id=160841
2555
2556         Reviewed by Carlos Garcia Campos.
2557
2558         * gtk/make-dist.py:
2559         (Manifest.process_line):
2560
2561 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2562
2563         [EFL][GTK] Install script not working on Debian 9 (testing) and Ubuntu 16.10
2564         https://bugs.webkit.org/show_bug.cgi?id=160809
2565
2566         Reviewed by Carlos Garcia Campos.
2567
2568         * efl/install-dependencies: Factorize the previous logic for handling the php5/7
2569         case, and use it also for the new package names of libpng and libgeoclue.
2570         * gtk/install-dependencies: Ditto.
2571
2572 2016-08-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2573
2574         Skip to check directories existence in build-webkit
2575         https://bugs.webkit.org/show_bug.cgi?id=160691
2576
2577         Reviewed by Alex Christensen.
2578
2579         CMake checks if directories are there itself. So CMake ports
2580         don't need to check it in the build-webkit script.
2581
2582         * Scripts/build-webkit:
2583         * Scripts/webkitdirs.pm:
2584         (determineSourceDir):
2585         (isCMakeBuild):
2586
2587 2016-08-12  Alex Christensen  <achristensen@webkit.org>
2588
2589         Make URLParser work with URLs missing URL parts
2590         https://bugs.webkit.org/show_bug.cgi?id=160824
2591
2592         Reviewed by Brady Eidson.
2593
2594         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2595         (TestWebKitAPI::s):
2596         (TestWebKitAPI::checkURL):
2597         (TestWebKitAPI::TEST_F):
2598         (TestWebKitAPI::eq): Deleted.
2599
2600 2016-08-12  John Wilander  <wilander@apple.com>
2601
2602         Add HashCountedSet API tests to TestWTFLibrary target
2603         https://bugs.webkit.org/show_bug.cgi?id=160815
2604
2605         Reviewed by Alex Christensen.
2606
2607         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2608             Added HashCountedSet.cpp and sorted the file reference section
2609             according to UNIX sort.
2610
2611 2016-08-12  Ryosuke Niwa  <rniwa@webkit.org>
2612
2613         run-benchmark should run JetStream 1.1 instead of 1.0.1
2614         https://bugs.webkit.org/show_bug.cgi?id=160816
2615
2616         Reviewed by Filip Pizlo.
2617
2618         Use the latest JetStream 1.1 in run-benchmark.
2619
2620         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
2621         (BenchmarkBuilder.__exit__):
2622         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Updated to apply against 1.1 directory.
2623         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Updated to use r190897, which is the last
2624         change to JetStream directory.
2625
2626 2016-08-12  Alex Christensen  <achristensen@webkit.org>
2627
2628         Initial URLParser implementation
2629         https://bugs.webkit.org/show_bug.cgi?id=160811
2630
2631         Reviewed by Brady Eidson.
2632
2633         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2634         (TestWebKitAPI::eq):
2635         (TestWebKitAPI::checkURL):
2636         (TestWebKitAPI::TEST_F):
2637
2638 2016-08-12  Brady Eidson  <beidson@apple.com>
2639
2640         Fix the 32-bit Mac build after:
2641         Add WK2 ExperimentalFeature support to MiniBrowser
2642         https://bugs.webkit.org/show_bug.cgi?id=160788
2643
2644         Unreviewed.
2645
2646         Sprinkle "#if WK_API_ENABLED"s liberally.
2647         
2648         * MiniBrowser/mac/AppDelegate.m:
2649         (defaultConfiguration):
2650         * MiniBrowser/mac/SettingsController.m:
2651         (-[SettingsController _populateMenu]):
2652         (-[SettingsController validateMenuItem:]):
2653
2654 2016-08-12  Philippe Normand  <pnormand@igalia.com>
2655
2656         [GStreamer][OWR] Video rendering fixes
2657         https://bugs.webkit.org/show_bug.cgi?id=160764
2658
2659         Reviewed by Xabier Rodriguez-Calvar.
2660
2661         * gtk/jhbuild.modules: Bump to current OpenWebRTC master.
2662
2663 2016-08-12  Per Arne Vollan  <pvollan@apple.com>
2664
2665         Add missing return statement in convertFast function added in r204376.
2666
2667         Unreviewed.
2668
2669         * Scripts/webkitpy/common/system/path.py:
2670         (_CygPath.convertFast):
2671
2672 2016-08-11  Brady Eidson  <beidson@apple.com>
2673
2674         Add WK2 ExperimentalFeature support to MiniBrowser.
2675         https://bugs.webkit.org/show_bug.cgi?id=160788
2676
2677         Reviewed by Alex Christensen.
2678
2679         * MiniBrowser/mac/AppDelegate.h:
2680         * MiniBrowser/mac/AppDelegate.m:
2681         (defaultConfiguration):
2682         (defaultPreferences):
2683         
2684         * MiniBrowser/mac/SettingsController.m:
2685         (-[SettingsController _populateMenu]):
2686         (-[SettingsController validateMenuItem:]):
2687         (-[SettingsController toggleExperimentalFeature:]):
2688
2689 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
2690
2691         Keep EWS logs for longer
2692         https://bugs.webkit.org/show_bug.cgi?id=160776
2693
2694         Reviewed by Daniel Bates.
2695
2696         * EWSTools/start-queue-mac.sh: Keep logs for 30 days instead of 14 days.
2697
2698 2016-08-11  Simon Fraser  <simon.fraser@apple.com>
2699
2700         iOS DRT/WTR project cleanup
2701         https://bugs.webkit.org/show_bug.cgi?id=160778
2702
2703         Reviewed by Tim Horton.
2704
2705         Move TARGETED_DEVICE_FAMILY from the project to an xcconfig file.
2706
2707         Remove AppDelegate.* which were unused.
2708
2709         Exclude ios/Launch.storyboard on more platforms.
2710
2711         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2712         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
2713         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
2714         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2715         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Removed.
2716         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Removed.
2717         (-[AppDelegate application:didFinishLaunchingWithOptions:]): Deleted.
2718
2719 2016-08-11  Alex Christensen  <achristensen@webkit.org>
2720
2721         Fix Yosemite bots' cookie accept policies after r204365.
2722         https://bugs.webkit.org/show_bug.cgi?id=160758
2723
2724         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
2725         (TEST):
2726         This makes the test fully clean up after itself.
2727
2728 2016-08-11  Alex Christensen  <achristensen@webkit.org>
2729
2730         Fix Yosemite bots' cookie accept policies after r204365.
2731         https://bugs.webkit.org/show_bug.cgi?id=160758
2732
2733         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
2734         (TEST):
2735         I didn't restore the cookieAcceptPolicy of the sharedHTTPCookieStorage after changing it with this API test.
2736         On Yosemite, this is changing the cookieAcceptPolicy that DumpRenderTree uses.
2737         On more recent Cocoa platforms, it is only changing the cookieAcceptPolicy that TestWebKitAPI uses, which isn't
2738         causing any problems because there are no other API tests that do anything with cookies.
2739         My solution will be to restore the original cookieAcceptPolicy after running this API test to clean up,
2740         but first I am committing this patch setting the cookieAcceptPolicy to NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain
2741         to reset any bots that have run tests since r204365.  I will commit a followup that sets it to originalCookieAcceptPolicy.
2742
2743 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
2744
2745         EWS should check if the patch is still valid before executing every major step
2746         https://bugs.webkit.org/show_bug.cgi?id=160739
2747         rdar://problem/27768813
2748
2749         Reviewed by Alexey Proskuryakov.
2750
2751         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2752         (CommitQueueTask.run): validate method is now executed in base class.
2753         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
2754         (EarlyWarningSystemTask.run): validate method is now executed in base class.
2755         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
2756         (StyleQueueTask.validate): Raise an PatchIsNotValid exception instead of returning False.
2757         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2758         (PatchAnalysisTask._run_command): validate the patch before executing any command. This is to ensure
2759         that we do not waste time on any patch which has become invalid (e.g.: obsolete, r-).
2760         * Scripts/webkitpy/tool/commands/perfalizer.py:
2761         (PerfalizerTask.validate): Added.
2762         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2763         (test_manual_reject_during_processing): Updated test case.
2764
2765 2016-08-11  Alex Christensen  <achristensen@webkit.org>
2766
2767         Add URLParser stub
2768         https://bugs.webkit.org/show_bug.cgi?id=160770
2769
2770         Reviewed by Sam Weinig.
2771
2772         * TestWebKitAPI/PlatformGTK.cmake:
2773         * TestWebKitAPI/PlatformWin.cmake:
2774         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2775         * TestWebKitAPI/Tests/WebCore/URLParser.cpp: Added.
2776         (TestWebKitAPI::TEST_F):
2777
2778 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
2779
2780         [iOS DRT] Allow DRT to be iPad-sized in the iPad simulator
2781         https://bugs.webkit.org/show_bug.cgi?id=160761
2782
2783         Reviewed by Tim Horton.
2784
2785         Give iOS DRT a Launch storyboard.
2786
2787         Have it use a UIViewController so future forms testing works correctly.
2788
2789         Add TARGETED_DEVICE_FAMILY = "1,2" to the build settings for the .app, so that it
2790         can run in iPad mode.
2791
2792         Remove empty InfoPlist.strings files.
2793
2794         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2795         * DumpRenderTree/ios/Info.plist:
2796         * DumpRenderTree/ios/Launch.storyboard: Added.
2797         * DumpRenderTree/mac/DumpRenderTree.mm:
2798         (createWebViewAndOffscreenWindow):
2799         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2800         * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Removed.
2801         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2802         (WTR::PlatformWebView::PlatformWebView): Drive-by leak fix.
2803
2804 2016-08-11  Per Arne Vollan  <pvollan@apple.com>
2805
2806         [Win] Unable to reliably run tests in parallel
2807         https://bugs.webkit.org/show_bug.cgi?id=140914
2808
2809         Reviewed by Brent Fulgham.
2810
2811         The cygpath utility function can fail badly when running with multiple DumpRenderTree
2812         processes. We can use string replacement to convert the Cygwin path to a Windows path
2813         instead.
2814
2815         * Scripts/webkitpy/common/system/path.py:
2816         (cygpathFast):
2817         * Scripts/webkitpy/port/driver.py:
2818         (Driver._command_from_driver_input):
2819
2820 2016-08-10  Alex Christensen  <achristensen@webkit.org>
2821
2822         Fix crash when changing cookie accept policy after r204327
2823         https://bugs.webkit.org/show_bug.cgi?id=160758
2824
2825         Reviewed by Simon Fraser.
2826
2827         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2828         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm: Added.
2829         (-[CookieAcceptPolicyMessageHandler userContentController:didReceiveScriptMessage:]):
2830         (TEST):
2831         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieMessage.html: Added.
2832
2833 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
2834
2835         [iOS WK2] Have WebKitTestRunnerApp.app use a UIViewController, and fix to avoid the status bar
2836         https://bugs.webkit.org/show_bug.cgi?id=160757
2837
2838         Reviewed by Tim Horton.
2839
2840         When programmatically creating the test UIWindow, make a root UIViewController and parent
2841         the WKWebView in its view. This makes the app more like a normal UIKit application.
2842         
2843         Move the WKWebView down 20px to avoid the status bar.
2844         
2845         Give the UIWindow a gray background so it's obvious where the window and view positioned.
2846
2847         Sorted the project file. Removed the link to UIKit which showed red, and wasn't necessary.
2848         
2849         Remove duplicate references to Launch.storyboard.
2850
2851         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2852         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Add license.
2853         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Add license.
2854         (-[AppDelegate applicationWillResignActive:]): Deleted.
2855         (-[AppDelegate applicationDidEnterBackground:]): Deleted.
2856         (-[AppDelegate applicationWillEnterForeground:]): Deleted.
2857         (-[AppDelegate applicationDidBecomeActive:]): Deleted.
2858         (-[AppDelegate applicationWillTerminate:]): Deleted.
2859         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2860         (WTR::viewRectForWindowRect):
2861         (WTR::PlatformWebView::PlatformWebView):
2862         (WTR::PlatformWebView::setWindowFrame):
2863
2864 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
2865
2866         [iOS WK2] Use the simulated device's screen size, rather than a harcoded size
2867         https://bugs.webkit.org/show_bug.cgi?id=160748
2868
2869         Reviewed by Tim Horton.
2870         
2871         Use the main UIScreen's bounds for the window size if we're using a flexible viewport. This
2872         opens the door for tests using other device sizes.
2873
2874         * WebKitTestRunner/ios/TestControllerIOS.mm:
2875         (WTR::TestController::platformConfigureViewForTest):
2876
2877 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
2878
2879         Sort the feature flags in the FEATURE_DEFINES lines
2880         https://bugs.webkit.org/show_bug.cgi?id=160742
2881
2882         Reviewed by Anders Carlsson.
2883         
2884         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2885
2886 2016-08-09  Simon Fraser  <simon.fraser@apple.com>
2887
2888         Logging and other minor improvements to iOS webkitpy
2889         https://bugs.webkit.org/show_bug.cgi?id=160722
2890
2891         Reviewed by Dan Bates.
2892
2893         Fix --debug-rwt-logging to log all the calls to simctl as well as device state information,
2894         to make it easier to debug launching issues.
2895
2896         Have reset_preferences() reset the device, rather than just nuking the data
2897         directory (which broke some versions of the simulator).
2898
2899         Make the Simulator.app launch in the background with open -g.
2900
2901         Wait for the simulator device to be in a known state in some more places.
2902
2903         * Scripts/webkitpy/port/ios.py:
2904         (IOSSimulatorPort.setup_test_run):
2905         (IOSSimulatorPort._quit_ios_simulator):
2906         (IOSSimulatorPort.clean_up_test_run):
2907         (IOSSimulatorPort.setup_environ_for_server):
2908         (IOSSimulatorPort.reset_preferences):
2909         * Scripts/webkitpy/xcode/simulator.py:
2910         (Device.create):
2911         (Device.delete):
2912         (Device):
2913         (Device.reset):
2914         (Simulator.wait_until_device_is_booted):
2915         (Simulator.wait_until_device_is_in_state):
2916         (Simulator):
2917         (Simulator.delete_device):
2918         (Simulator.reset_device):
2919         (Simulator.lookup_or_create_device):
2920
2921 2016-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2922
2923         [GTK][EFL] ALSA_CARD environment variable is not passed for layout tests.
2924         https://bugs.webkit.org/show_bug.cgi?id=160697
2925
2926         Reviewed by Antonio Gomes.
2927
2928         * Scripts/webkitpy/port/base.py:
2929         (Port.to.setup_environ_for_server): Add ALSA_CARD and sort the Linux
2930         list of environment variables to copy.
2931
2932 2016-08-09  George Ruan  <gruan@apple.com>
2933
2934         Implement functionality of media capture on iOS
2935         https://bugs.webkit.org/show_bug.cgi?id=158945
2936         <rdar://problem/26893343>
2937
2938         Reviewed by Tim Horton.
2939
2940         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Enable Media
2941         Capture feature on iOS.
2942
2943 2016-08-09  Saam Barati  <sbarati@apple.com>
2944
2945         Parser<LexerType>::parseFunctionInfo() has the wrong info about captured vars when a function is not cached.
2946         https://bugs.webkit.org/show_bug.cgi?id=160671
2947         <rdar://problem/27756112>
2948
2949         Reviewed by Mark Lam.
2950
2951         * Scripts/run-jsc-stress-tests:
2952
2953 2016-08-09  Alexey Proskuryakov  <ap@apple.com>
2954
2955         Make directory reading code in iOSSimulatorDevices() more strict
2956         https://bugs.webkit.org/show_bug.cgi?id=160702
2957
2958         Reviewed by Tim Horton.
2959
2960         * Scripts/webkitdirs.pm:
2961         (iOSSimulatorDevices):
2962
2963 2016-08-06  Sam Weinig  <sam@webkit.org>
2964
2965         Replace NodeOrString with std::variant<RefPtr<Node>, String>
2966         https://bugs.webkit.org/show_bug.cgi?id=160638
2967
2968         Reviewed by Anders Carlsson.
2969
2970         * TestWebKitAPI/CMakeLists.txt:
2971         * TestWebKitAPI/Tests/WTF/Variant.cpp:
2972         Add additional tests for the initial state of std::variant and using
2973         makeVisitor for visiting.
2974
2975 2016-08-09  Aakash Jain  <aakash_jain@apple.com>
2976
2977         EWS logging should ensure the logging to file is stopped on queue termination
2978         https://bugs.webkit.org/show_bug.cgi?id=160698
2979         rdar://problem/24464570
2980
2981         Reviewed by Daniel Bates.
2982
2983         * Scripts/webkitpy/tool/bot/queueengine.py:
2984         (QueueEngine._stopping): Stop logging to file on queue termination.
2985         (QueueEngine._begin_logging): Configure the Python logger to log to file.
2986         * Scripts/webkitpy/common/system/logutils.py:
2987         (configure_logger_to_log_to_file): Return the handler so as to enable caller to remove it later.
2988         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2989         (QueueEngineTest._run_engine): Removed extra newline character to improve log readability.
2990         * Scripts/webkitpy/tool/commands/queues.py:
2991         (AbstractQueue._log_directory): Reverting to os.path.join as we don't have host object.
2992         (AbstractQueue.queue_log_path): Same.
2993         (AbstractQueue.begin_work_queue): Removed logging initialization, it is now being done in QueueEngine.
2994         (AbstractQueue.__init__): Removed host parameter, not required anymore, it was required by logging initialization
2995         which moved to QueueEngine now.
2996         (PatchProcessingQueue.__init__): Same.
2997         (CommitQueue.__init__): Same.
2998         (AbstractReviewQueue.__init__): Same.
2999         (StyleQueue.__init__): Same.
3000         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3001         (TestCommitQueue): Removed host parameter.
3002         (TestCommitQueue.__init__): Same.
3003         (AbstractPatchQueueTest.test_next_patch): Same.
3004         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
3005         (test_commit_queue_failure): Same.
3006         (mock_run_webkit_patch):
3007         (MockCommitQueueTask.results_from_patch_test_run): Same.
3008         (test_rollout_lands): Same.
3009         (test_non_valid_patch): Same.
3010         (test_auto_retry): Same.
3011         (test_style_queue_with_watch_list_exception): Same.
3012         (TestQueue.__init__): Deleted.
3013         (TestReviewQueue.__init__): Deleted.
3014         (TestFeederQueue.__init__): Deleted.
3015
3016 2016-08-09  Konstantin Tokarev  <annulen@yandex.ru>
3017
3018         webkit-gtk tarball fails to build due to missing files
3019         https://bugs.webkit.org/show_bug.cgi?id=160684
3020
3021         Reviewed by Alex Christensen.
3022
3023         * gtk/manifest.txt.in: Added back spi directories.
3024
3025 2016-08-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3026
3027         [GTK] Build the jhbuild with -O2 optimization level by default
3028         https://bugs.webkit.org/show_bug.cgi?id=160544
3029
3030         Reviewed by Michael Catanzaro.
3031
3032         * gtk/jhbuildrc: Pass -O2 when building the JHBuild, as also -g1
3033         which don't increases the required disk space significatively and
3034         provides better debug information than no passing it.
3035
3036 2016-08-09  Csaba Osztrogonác  <ossy@webkit.org>
3037
3038         Allow more --cmakeargs option in build-jsc and build-webkit
3039         https://bugs.webkit.org/show_bug.cgi?id=160340
3040
3041         Reviewed by Michael Catanzaro.
3042
3043         * Scripts/build-jsc:
3044         * Scripts/build-webkit:
3045
3046 2016-08-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3047
3048         Do not check if WebKitLibraries folder exists on EFL and GTK
3049         https://bugs.webkit.org/show_bug.cgi?id=160659
3050
3051         Reviewed by Csaba Osztrogonác.
3052
3053         Though WebKitLibraries is only needed by mac and win ports,
3054         EFL and GTK ports have checked whether it exists.
3055
3056         * Scripts/build-webkit:
3057
3058 2016-08-08  Aakash Jain  <aakash_jain@apple.com>
3059
3060         Some EWS console logs doesn't go to log file
3061         https://bugs.webkit.org/show_bug.cgi?id=160585
3062         rdar://problem/24464570
3063
3064         Reviewed by Daniel Bates.
3065
3066         * Scripts/webkitpy/common/system/logutils.py:
3067         (FileSystemHandler._open): Ensure that we open logfile in append mode in order to avoid
3068         any possible overwriting.
3069         * Scripts/webkitpy/common/system/filesystem.py:
3070         (FileSystem.open_text_file_for_writing): Add should_append parameter to append to file.
3071         * Scripts/webkitpy/common/system/filesystem_mock.py:
3072         (MockFileSystem.open_text_file_for_writing): Same.
3073         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3074         (RealFileSystemTest.test_read_and_write_text_file): Removed unused variable 'hex_equivalent'.
3075         (RealFileSystemTest.test_append_to_text_file): Added new unit test for testing append functionality.
3076         * Scripts/webkitpy/tool/commands/queues.py:
3077         (AbstractQueue.begin_work_queue): Configure the logger for overall webkitpy to log to file.
3078         This will ensure that all the sub-modules inside webkitpy will log to file.
3079
3080 2016-08-08  Simon Fraser  <simon.fraser@apple.com>
3081
3082         Have the iOS platform interit from the Apple platform in webkitpy
3083         https://bugs.webkit.org/show_bug.cgi?id=160672
3084
3085         Reviewed by Dan Bates.
3086         
3087         The IOSSimulatorPort used to inherit from Port, rather than ApplePort.
3088         Fix this, and move duplicated code from IOSSimulatorPort and MacPort into
3089         ApplePort.
3090         
3091         Since WinPort also inherits from ApplePort, it needs to stub out some things
3092         that are unavailable on Windows (leaks, sampling).
3093         
3094         Some SnowLeopard-related code and the associated test were removed.
3095
3096         * Scripts/webkitpy/port/apple.py:
3097         (ApplePort.__init__):
3098         (ApplePort):
3099         (ApplePort._make_leak_detector):
3100         (ApplePort.default_timeout_ms):
3101         (ApplePort.supports_per_test_timeout):
3102         (ApplePort.should_retry_crashes):
3103         (ApplePort._generate_all_test_configurations):
3104         (ApplePort.check_for_leaks):
3105         (ApplePort.print_leaks_summary):
3106         (ApplePort._path_to_webcore_library):
3107         (ApplePort.show_results_html_file):
3108         (ApplePort._merge_crash_logs):
3109         (ApplePort._look_for_all_crash_logs_in_log_dir):
3110         (ApplePort._get_crash_log):
3111         (ApplePort.look_for_new_crash_logs):
3112         (ApplePort.sample_process):
3113         (ApplePort.sample_file_path):
3114         (ApplePort.look_for_new_samples):
3115         (ApplePort._path_to_helper):
3116         (ApplePort.determine_full_port_name): Deleted.
3117         * Scripts/webkitpy/port/ios.py:
3118         (IOSSimulatorPort):
3119         (IOSSimulatorPort.__init__):
3120         (IOSSimulatorPort.default_timeout_ms): Deleted.
3121         (IOSSimulatorPort.supports_per_test_timeout): Deleted.
3122         (IOSSimulatorPort.should_retry_crashes): Deleted.
3123         (IOSSimulatorPort.check_for_leaks): Deleted.
3124         (IOSSimulatorPort.print_leaks_summary): Deleted.
3125         (IOSSimulatorPort._path_to_webcore_library): Deleted.
3126         (IOSSimulatorPort.show_results_html_file): Deleted.
3127         (IOSSimulatorPort.sample_file_path): Deleted.
3128         (IOSSimulatorPort._merge_crash_logs): Deleted.
3129         (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Deleted.
3130         (IOSSimulatorPort.look_for_new_crash_logs): Deleted.
3131         (IOSSimulatorPort.look_for_new_samples): Deleted.
3132         (IOSSimulatorPort.sample_process): Deleted.
3133         (IOSSimulatorPort._path_to_helper): Deleted.
3134         (IOSSimulatorPort.make_command): Deleted.
3135         * Scripts/webkitpy/port/mac.py:
3136         (MacPort.__init__):
3137         (MacPort.make_command):
3138         (MacPort._build_java_test_support):
3139         (MacPort): Deleted.
3140         (MacPort.default_timeout_ms): Deleted.
3141         (MacPort.supports_per_test_timeout): Deleted.
3142         (MacPort.should_retry_crashes): Deleted.
3143         (MacPort.default_child_processes): Deleted.
3144         (MacPort.check_for_leaks): Deleted.
3145         (MacPort.print_leaks_summary): Deleted.
3146         (MacPort._path_to_webcore_library): Deleted.
3147         (MacPort.show_results_html_file): Deleted.
3148         (MacPort.sample_file_path): Deleted.
3149         (MacPort._merge_crash_logs): Deleted.
3150         (MacPort._look_for_all_crash_logs_in_log_dir): Deleted.
3151         (MacPort.look_for_new_crash_logs): Deleted.
3152         (MacPort.look_for_new_samples): Deleted.
3153         (MacPort.sample_process): Deleted.
3154         (MacPort._path_to_helper): Deleted.
3155         * Scripts/webkitpy/port/mac_unittest.py:
3156         (MacTest.test_default_child_processes): Deleted.
3157         * Scripts/webkitpy/port/win.py:
3158         (WinPort.look_for_new_samples):
3159         (WinPort):
3160         (WinPort.sample_process):
3161         (WinPort._make_leak_detector):
3162         (WinPort.check_for_leaks):
3163         (WinPort.print_leaks_summary):
3164         (WinPort._path_to_webcore_library):
3165
3166 2016-08-08  Matt Baker  <mattbaker@apple.com>
3167
3168         Unreviewed: moved myself to the reviewers list.
3169
3170         * Scripts/webkitpy/common/config/contributors.json:
3171
3172 2016-08-08  Chris Dumez  <cdumez@apple.com>
3173
3174         Update API tests in mac/SetDocumentURI.mm after r204247
3175         https://bugs.webkit.org/show_bug.cgi?id=160660
3176
3177         Reviewed by Alex Christensen.
3178
3179         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
3180         (TestWebKitAPI::TEST):
3181
3182 2016-08-08  Jonathan Bedard  <jbedard@apple.com>
3183
3184         run-webkit-tests should trigger a spindump when WebContent process is unresponsive
3185         https://bugs.webkit.org/show_bug.cgi?id=159827
3186
3187         Reviewed by Daniel Bates.
3188
3189         This change was spurred by a process hang which occurred between tests and did
3190         not produce a meaningful crashlog.
3191
3192         * Scripts/webkitpy/port/driver.py:
3193         (Driver._check_for_driver_crash_or_unresponsiveness): Notify test controller when finished through stdin.
3194
3195          * Scripts/webkitpy/port/ios.py:
3196         (IOSSimulatorPort):
3197         (IOSSimulatorPort.sample_process): Attempt spindump, but use sample if spindump fails.
3198         * Scripts/webkitpy/port/mac.py:
3199         (MacPort):
3200         (MacPort.sample_process): Attempt spindump, but use sample if spindump fails.
3201
3202         * Scripts/webkitpy/port/mac_unittest.py: Changed expected values to match spindump calls, added specific spindump test.
3203         * Scripts/webkitpy/port/driver_unittest.py: Added dummy write function.
3204
3205         * WebKitTestRunner/TestController.h:
3206         (WTR::TestController::usingServerMode): Added accessor for m_usingServerMode.
3207         * WebKitTestRunner/TestInvocation.cpp:
3208         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Wait for stdin before continuing when in server mode.
3209
3210 2016-08-07  Dan Bernstein  <mitz@apple.com>
3211
3212         [Cocoa] Reply block leaks if the remote object doesn’t call it
3213         https://bugs.webkit.org/show_bug.cgi?id=160642
3214
3215         Reviewed by Sam Weinig.
3216
3217         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Declared a new method.
3218         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
3219         (TEST): Added a test case that checks that the reply block is released even when it’s not
3220           called.
3221         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
3222         (-[RemoteObjectRegistryPlugIn doNotCallCompletionHandler:]): Implement new method by not
3223           calling the completion handler.
3224
3225 2016-08-07  Chris Dumez  <cdumez@apple.com>
3226
3227         Write API test to cover crash fix in r204135
3228         https://bugs.webkit.org/show_bug.cgi?id=160587
3229
3230         Reviewed by Darin Adler.
3231
3232         Add API test to cover crash fix in r204135. This reproduces the crash
3233         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
3234         callback.
3235
3236         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
3237         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
3238         (TEST):
3239
3240 2016-08-06  Chris Dumez  <cdumez@apple.com>
3241
3242         Unreviewed, rolling out r204226.
3243
3244         Broke some API tests
3245
3246         Reverted changeset:
3247
3248         "Write API test to cover crash fix in r204135"
3249         https://bugs.webkit.org/show_bug.cgi?id=160587
3250         http://trac.webkit.org/changeset/204226
3251
3252 2016-08-06  Aakash Jain  <aakash_jain@apple.com>
3253
3254         EWS Style Queue fails to process patches which fails validation
3255         https://bugs.webkit.org/show_bug.cgi?id=160632
3256
3257         Reviewed by Alexey Proskuryakov.
3258
3259         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
3260         (StyleQueueTask.validate): Add more information about validation failure.
3261         (StyleQueueTask.run): Pass the error details in the PatchIsNotValid exception.
3262         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3263         (test_non_valid_patch): Add a unit test to test the above code path.
3264
3265 2016-08-06  Sam Weinig  <sam@webkit.org>
3266
3267         WTF needs a variant implementation
3268         https://bugs.webkit.org/show_bug.cgi?id=160618
3269
3270         Reviewed by Darin Adler.
3271
3272         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3273         * TestWebKitAPI/Tests/WTF/Variant.cpp: Added.
3274         Add tests for the variant implementation.
3275
3276 2016-08-06  Chris Dumez  <cdumez@apple.com>
3277
3278         Write API test to cover crash fix in r204135
3279         https://bugs.webkit.org/show_bug.cgi?id=160587
3280
3281         Reviewed by Darin Adler.
3282
3283         Add API test to cover crash fix in r204135. This reproduces the crash
3284         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
3285         callback.
3286
3287         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
3288         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
3289         (TEST):
3290
3291 2016-08-05  Tim Horton  <timothy_horton@apple.com>
3292
3293         run-api-tests should use a headed simulator
3294         https://bugs.webkit.org/show_bug.cgi?id=160611
3295
3296         Reviewed by Sam Weinig.
3297
3298         CADisplayLink doesn't work in a headless simulator, but is
3299         vital for the proper functioning of WebKit2 painting on iOS.
3300         So, we should not use a headless simulator.
3301
3302         * Scripts/run-api-tests:
3303         Launch a simulator app, don't just boot the simulator.
3304
3305         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
3306         Re-enable a test that works now.
3307
3308 2016-08-05  Dan Bernstein  <mitz@apple.com>
3309
3310         [Cocoa] WKRemoteObjectCoder doesn’t handle NSRange
3311         https://bugs.webkit.org/show_bug.cgi?id=160589
3312
3313         Reviewed by Tim Horton.
3314
3315         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
3316         (remoteObjectInterface): Fixed a mistake in the set of allowed classes in one of the reply
3317           blocks, which wasn’t caught because the test wasn’t run correctly.
3318         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
3319         (TEST): Fixed the -selectionAndClickInformationForClickAtPoint:completionHandler: test, and
3320           added a test that sends over an NSRange.
3321         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
3322         (-[RemoteObjectRegistryPlugIn takeRange:completionHandler:]): Added. Calls the completion
3323           handler with the range‘s location and length.
3324
3325 2016-08-05  Enrica Casucci  <enrica@apple.com>
3326
3327         Fixing tests failing after r204175.
3328
3329         Unreviewed.
3330
3331         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig:
3332
3333 2016-08-05  Enrica Casucci  <enrica@apple.com>
3334
3335         Build fix after 204053.
3336
3337         Unreviewed.
3338
3339         * TestWebKitAPI/Configurations/Base.xcconfig:
3340         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
3341         (-[MockContentFilterEnabler initWithCoder:]):
3342         (-[MockContentFilterEnabler dealloc]):
3343
3344 2016-08-05  Konstantin Tokarev  <annulen@yandex.ru>
3345
3346         Print test name in "Last character read from DRT..." error message.
3347         https://bugs.webkit.org/show_bug.cgi?id=160559
3348
3349         Reviewed by Michael Catanzaro.
3350
3351         * Scripts/webkitpy/port/driver.py:
3352         (Driver.run_test):
3353         (Driver._read_first_block):
3354         (Driver._read_optional_image_block):
3355         (Driver._read_block):
3356         * Scripts/webkitpy/port/driver_unittest.py:
3357         (DriverTest.test_read_block):
3358         (DriverTest.test_read_binary_block):
3359         (DriverTest.test_read_base64_block):
3360
3361 2016-08-05  Commit Queue  <commit-queue@webkit.org>
3362
3363         Unreviewed, rolling out r204123.
3364         https://bugs.webkit.org/show_bug.cgi?id=160597
3365
3366         Caused layout test timeouts on Windows. (Requested by perarne
3367         on #webkit).
3368
3369         Reverted changeset:
3370
3371         "[Win] Unable to reliably run tests in parallel"
3372         https://bugs.webkit.org/show_bug.cgi?id=140914
3373         http://trac.webkit.org/changeset/204123
3374
3375 2016-08-04  Saam Barati  <sbarati@apple.com>
3376
3377         Restore CodeBlock jettison code to jettison when a CodeBlock has been alive for a long time
3378         https://bugs.webkit.org/show_bug.cgi?id=151241
3379
3380         Reviewed by Benjamin Poulain.
3381
3382         * Scripts/run-jsc-stress-tests:
3383
3384 2016-08-04  Dean Johnson  <dean_johnson@apple.com>
3385
3386         UI improvements to Flakiness Dashboard.
3387         https://bugs.webkit.org/show_bug.cgi?id=153295
3388
3389         Reviewed by Alexey Proskuryakov.
3390
3391         * TestResultServer/static-dashboards/flakiness_dashboard.css:
3392         (td.options-container): Center text in most fields.
3393         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3394         (createBugHTML): Text/Grammar updates.
3395         (tableHeaders): Ditto.
3396         (htmlForSingleTestRow): Ditto.
3397         (headerForTestTableHtml): Ditto.
3398         * TestResultServer/static-dashboards/ui.js: Removed the "Group: " and "Test type: " headings.
3399         (ui.html.testTypeSwitcher): Deleted. Removes the "Group:" heading.
3400
3401 2016-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3402
3403         [GTK] install-dependencies script misses libxslt as build-dependency and some python libs for the run-benchmark script
3404         https://bugs.webkit.org/show_bug.cgi?id=160518
3405
3406         Reviewed by Michael Catanzaro.
3407
3408         * Scripts/webkitpy/thirdparty/__init__.py:
3409         (AutoinstallImportHook._install_twisted): Twisted requires zope.interface.
3410         * gtk/install-dependencies:
3411
3412 2016-08-04  Alexey Proskuryakov  <ap@apple.com>
3413
3414         Optimize bot watcher's dashboard a little
3415         https://bugs.webkit.org/show_bug.cgi?id=160515
3416         rdar://problem/26096900
3417
3418         Reviewed by Lucas Forschler.
3419
3420         Made re-sorting after loading an iteration more efficient.
3421
3422         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3423         (BuildbotIteration.prototype._updateWithData):
3424         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3425         (BuildbotQueue.prototype.updateIterationPosition):
3426
3427 2016-08-04  Per Arne Vollan  <pvollan@apple.com>
3428
3429         [Win] Unable to reliably run tests in parallel
3430         https://bugs.webkit.org/show_bug.cgi?id=140914
3431
3432         Reviewed by Brent Fulgham.
3433
3434         The cygpath utility function can fail badly when running with multiple DumpRenderTree
3435         processes. We can use string replacement to convert the Cygwin path to a Windows path
3436         instead.
3437  
3438         * Scripts/webkitpy/common/system/path.py:
3439         (cygpathFast):
3440         * Scripts/webkitpy/port/driver.py:
3441         (Driver._command_from_driver_input):
3442
3443 2016-08-03  Aakash Jain  <aakash_jain@apple.com>
3444
3445         Document instructions for increasing process and file limits
3446         https://bugs.webkit.org/show_bug.cgi?id=160528
3447         rdar://problem/24777576
3448
3449         Reviewed by Alexey Proskuryakov.
3450
3451         * Scripts/webkitpy/port/ios.py:
3452         (IOSSimulatorPort.default_child_processes):
3453
3454 2016-08-03  Anders Carlsson  <andersca@apple.com>
3455
3456         Remove the Objective-C bindings generator
3457         https://bugs.webkit.org/show_bug.cgi?id=160526
3458
3459         Reviewed by Sam Weinig.
3460
3461         * Scripts/run-bindings-tests:
3462         Update test.
3463
3464 2016-08-03  Tim Horton  <timothy_horton@apple.com>
3465
3466         Revise a TestWebKitAPI comment to mention the actual underlying problem
3467
3468         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
3469         Note that this is because of https://bugs.webkit.org/show_bug.cgi?id=160516
3470
3471 2016-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3472
3473         Benchmark test content-animation timeouts always
3474         https://bugs.webkit.org/show_bug.cgi?id=160057
3475
3476         Reviewed by Simon Fraser.
3477
3478         * Scripts/webkitpy/benchmark_runner/data/plans/Skipped: Added.
3479         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
3480         (start):
3481
3482 2016-08-02  Nan Wang  <n_wang@apple.com>
3483
3484         AX: Simulated touch events are not working on iOS
3485         https://bugs.webkit.org/show_bug.cgi?id=160395
3486         <rdar://problem/27633597>
3487
3488         Reviewed by Chris Fleizach.
3489
3490         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3491         (WTR::AccessibilityUIElement::press):
3492         (WTR::AccessibilityUIElement::setSelectedChild):
3493
3494 2016-08-02  Filip Pizlo  <fpizlo@apple.com>
3495
3496         run-javascriptcore-tests should accept multiple --extra-tests
3497         https://bugs.webkit.org/show_bug.cgi?id=160486
3498
3499         Reviewed by Saam Barati.
3500         
3501         We want to be able to pass --extra-tests multiple times, to supply an arbitrary number of extra
3502         test suites. This does it by using GetOpt::Long's array support.
3503
3504         * Scripts/run-javascriptcore-tests:
3505         (runJSCStressTests):
3506
3507 2016-08-02  Enrica Casucci  <enrica@apple.com>
3508
3509         Allow building with content filtering disabled.
3510         https://bugs.webkit.org/show_bug.cgi?id=160454
3511
3512         Reviewed by Simon Fraser.
3513
3514         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3515
3516 2016-08-02  Brady Eidson  <beidson@apple.com>
3517
3518         Removing IndexedDB WebsiteData can fail for some users.
3519         https://bugs.webkit.org/show_bug.cgi?id=160463
3520
3521         Reviewed by Alex Christensen.
3522
3523         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
3524
3525 2016-08-01  Alex Christensen  <achristensen@webkit.org>
3526
3527         _WKDownloadDelegate.didReceiveResponse should be called before decideDestinationWithSuggestedFilename
3528         https://bugs.webkit.org/show_bug.cgi?id=160437
3529         <rdar://problem/27578272>
3530
3531         Reviewed by Brady Eidson.
3532
3533         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3534         (-[DownloadDelegate _download:didReceiveResponse:]):
3535         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
3536         (runTest):
3537         Add a boolean to make sure that didReceiveResponse is called before decideDestinationWithSuggestedFilename.
3538
3539 2016-08-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3540
3541         [Tools] The GDB backtrace report tool don't checks the gdb return code.
3542         https://bugs.webkit.org/show_bug.cgi?id=160414
3543
3544         Reviewed by Michael Catanzaro.
3545
3546         * Scripts/webkitpy/port/linux_get_crash_log.py:
3547         (GDBCrashLogGenerator._wait_for_corefile):
3548
3549 2016-08-01  Youenn Fablet  <youenn@apple.com>
3550
3551         Make wpt server generate its certificates in layout test results folder
3552         https://bugs.webkit.org/show_bug.cgi?id=160422
3553
3554         Reviewed by Chris Dumez.
3555
3556         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3557         (WebPlatformTestServer._copy_webkit_test_files): Setting certificate folder to layout tests results directory.
3558
3559 2016-08-01  Jonathan Bedard  <jbedard@apple.com>
3560
3561         Function Call on NULL Object
3562         https://bugs.webkit.org/show_bug.cgi?id=160325
3563
3564         Reviewed by Darin Adler.
3565
3566         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3567         (WTR::InjectedBundle::didReceiveMessageToPage): Changed removeAllWebNotificationPermissions() call to static function call.
3568         * WebKitTestRunner/InjectedBundle/TestRunner.h: Made all web-notification functions static.
3569
3570 2016-08-01  Keith Miller  <keith_miller@apple.com>
3571
3572         We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory.
3573         https://bugs.webkit.org/show_bug.cgi?id=160372
3574
3575         Rubber stamped by Geoffrey Garen.
3576
3577         This patch moves all the JavaScript tests from Source/JavaScriptCore/tests to
3578         a new top level directory, JSTests. Having the tests in the Source directory
3579         was both confusing an inconvenient for people that just want to checkout the
3580         source code of WebKit. Since there is no other obvious place to put all the
3581         JavaScript tests a new top level directory seemed the most sensible.
3582
3583         * Scripts/import-test262-tests:
3584         * Scripts/run-javascriptcore-tests:
3585         * Scripts/update-javascriptcore-test-res:
3586
3587 2016-07-31  Nan Wang  <n_wang@apple.com>
3588
3589         AX: Add a check for touch event listener on iOS accessibility object
3590         https://bugs.webkit.org/show_bug.cgi?id=160388
3591
3592         Reviewed by Chris Fleizach.
3593
3594         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3595         (AccessibilityUIElement::boolAttributeValue):
3596         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3597         (WTR::AccessibilityUIElement::boolAttributeValue):
3598
3599 2016-07-30  Manuel Rego Casasnovas  <rego@igalia.com>
3600
3601         Unreviewed: add myself to the reviewers list.
3602
3603         * Scripts/webkitpy/common/config/contributors.json:
3604
3605 2016-07-29  Alexey Proskuryakov  <ap@apple.com>
3606
3607         Undo r203939, and copy over a rule that clips the logos.
3608
3609         Sierra wasn't the only logo without transparency.
3610
3611         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
3612         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
3613         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3614
3615 2016-07-29  Alan Sien Wei Hshieh  <hshieh@apple.com>
3616
3617         The Sierra asset at build.webkit.org/dashboard/images/Sierra*.png has a white background
3618         https://bugs.webkit.org/show_bug.cgi?id=160377
3619
3620         Reviewed by Brian Weinstein.
3621
3622         Update assets to remove the white background and use a transparent background instead.
3623
3624         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
3625         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
3626
3627 2016-07-29  David Kilzer  <ddkilzer@apple.com>
3628
3629         Ignore most check-webkit-style checks for ANGLE project
3630         <https://webkit.org/b/160333>
3631
3632         Reviewed by Daniel Bates.
3633
3634         * Scripts/webkitpy/style/checker.py: Ignore all checkers except:
3635         - No tabs.
3636         - No spaces at the end of lines.
3637         - No carriage returns (DOS line endings).
3638
3639 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
3640
3641         Media controls are not displayed for some autoplaying videos at certain browser dimensions
3642         https://bugs.webkit.org/show_bug.cgi?id=160360
3643         <rdar://problem/27179484>
3644
3645         Reviewed by Myles C. Maxfield.
3646
3647         Adds two tests verifying that videos may be considered main content as long as they
3648         are large enough and cover a majority of the mainframe's viewport.
3649
3650         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3651         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
3652         (TestWebKitAPI::TEST):
3653         * TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html: Added.
3654         * TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html: Added.
3655
3656 2016-07-29  Mark Lam  <mark.lam@apple.com>
3657
3658         Gardening: removed unused variable.
3659
3660         Not reviewed.
3661
3662         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3663         (TestWebKitAPI::TEST):
3664
3665 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
3666
3667         Add TestWebKitAPI support for interacting with media controls
3668         https://bugs.webkit.org/show_bug.cgi?id=160342
3669         <rdar://problem/27610246>
3670
3671         Reviewed by Beth Dakin.
3672
3673         Adds support for testing interaction with some media controls, as well as a basic test
3674         verifying that media control teardown after interaction does not result in a crash.
3675
3676         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
3677         (-[WKWebView mouseDownAtPoint:]):
3678         (-[WKWebView performAfterLoading:]):
3679         (TestWebKitAPI::TEST):
3680
3681 2016-07-29  Jonathan Bedard  <jbedard@apple.com>
3682
3683         Crash Log Clobbering on Unbound Crashes
3684         https://bugs.webkit.org/show_bug.cgi?id=160198
3685         <rdar://problem/27472618>
3686
3687         Reviewed by Alexey Proskuryakov.
3688
3689         * Scripts/webkitpy/common/system/crashlogs.py:
3690         (CrashLogs): Fix header order.
3691         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3692         (TestResultWriter.output_filename): Only remove file extension if it is clearly a file extension.
3693
3694 2016-07-29  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3695
3696         Update for contributors.json
3697         https://bugs.webkit.org/show_bug.cgi?id=160294
3698
3699         * Scripts/webkitpy/common/config/contributors.json:
3700
3701 2016-07-28  Myles C. Maxfield  <mmaxfield@apple.com>
3702
3703         Remove deprecated SPI for video inline / fullscreen controls
3704         https://bugs.webkit.org/show_bug.cgi?id=160318
3705
3706         Reviewed by Tim Horton.
3707
3708         * DumpRenderTree/mac/DumpRenderTree.mm:
3709         (setDefaultsToConsistentValuesForTesting): Deleted.
3710         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
3711         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
3712         * WebKitTestRunner/TestController.cpp:
3713         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
3714         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3715         (WTR::initializeWebViewConfiguration): Deleted.
3716
3717 2016-07-28  Daniel Bates  <dabates@apple.com>
3718
3719         [iOS] TestWebKitAPI bundle targets are not code signed
3720         https://bugs.webkit.org/show_bug.cgi?id=160328
3721         <rdar://problem/27409246>
3722
3723         Reviewed by Andy Estes.
3724
3725         Workaround <rdar://problem/27459890> by explicitly defining Xcode build settings
3726         CODE_SIGNING_ALLOWED and AD_HOC_CODE_SIGNING_ALLOWED to be YES so as to allow the
3727         the TestWebKitAPI bundle targets to be code signed when building for the iOS simulator.
3728
3729         * TestWebKitAPI/Configurations/Base.xcconfig:
3730
3731 2016-07-28  Tim Horton  <timothy_horton@apple.com>
3732
3733         Disable WebKit2.ResizeWithHiddenContentDoesNotHang for now
3734
3735         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
3736         (animatedResizeWebView):
3737         (TEST):
3738         This test times out only when run in the WebKit Testing simulator environment,
3739         but not in a fresh simulator. Disabling to keep the bots green while under investigation.
3740
3741 2016-07-28  Tim Horton  <timothy_horton@apple.com>
3742
3743         Frequent animation lags when interacting with Safari (sidebar, tab switching, etc.)
3744         https://bugs.webkit.org/show_bug.cgi?id=160289
3745         <rdar://problem/27553464>
3746
3747         Reviewed by Simon Fraser.
3748
3749         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3750         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3751         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm: Added.
3752         (-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]):
3753         (-[AnimatedResizeWebView _endAnimatedResize]):
3754         (animatedResizeWebView):
3755         (TEST):
3756         * TestWebKitAPI/Tests/WebKit2Cocoa/blinking-div.html: Added.
3757         Add two tests that ensure that hidden-content and animated resizes
3758         don't cause unnecessary synchronous waits. Only the hidden-content
3759         one fails before my patch, but it seemed reasonable to add both anyway.
3760
3761 2016-07-28  David Kilzer  <ddkilzer@apple.com>
3762
3763         webkit-patch upload --suggest-reviewers shouldn't break in the presence of deleted or moved files
3764         <https://webkit.org/b/83342>
3765
3766         Reviewed by Ryosuke Niwa.
3767
3768         * Scripts/webkitpy/common/checkout/scm/git.py:
3769         (Git.revisions_changing_file): Remove code to raise an exception
3770         when the file doesn't exist.  If a file was moved or renamed,
3771         then this caused the script to terminate, which was very
3772         frustrating when you wanted a list of reviewers.
3773         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3774         (SCMTest._shared_test_revisions_changing_file): Update test
3775         expectation to return an empty list of revisions.
3776         (test_create_patch_is_full_patch): Drive-by fix when running all
3777         webkitpy tests (including scm tests).
3778         * Scripts/webkitpy/common/checkout/scm/svn.py:
3779         (SVN.revisions_changing_file): Catch ScriptError exceptions and
3780         return an empty array of revisions if this occurs.
3781
3782 2016-07-28  Aakash Jain  <aakash_jain@apple.com>
3783
3784         EWS error message "Error: * did not process patch" should include explanation
3785         https://bugs.webkit.org/show_bug.cgi?id=159903
3786         <rdar://problem/27410788>
3787
3788         Reviewed by Alexey Proskuryakov.
3789
3790         * QueueStatusServer/handlers/statusbubble.py:
3791         (StatusBubble._build_bubble): Display more detailed error message on bubbles when patch
3792         is not processed.
3793         * QueueStatusServer/handlers/processingtimesjson.py:
3794         (ProcessingTimesJSON._resultFromFinalStatus): Updated error message to match with rest
3795         of the code.
3796         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3797         (CommitQueueTask.validate): Add more information about validation failure.
3798         (CommitQueueTask.run): Pass the error details in the PatchIsNotValid exception.
3799         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
3800         (EarlyWarningSystemTask.validate): Add more information about validation failure.
3801         (EarlyWarningSystemTask.run): Pass the error details in the PatchIsNotValid exception.
3802         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3803         (PatchIsNotValid.__init__): Add the failure_message argument.
3804         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3805         (AbstractEarlyWarningSystem.review_patch): Re-word the error message and include
3806         failure details.
3807         * Scripts/webkitpy/tool/commands/queues.py:
3808         (CommitQueue.process_work_item): Same.
3809         (StyleQueue.review_patch): Same.
3810         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3811         (test_non_valid_patch): Updated test-cases messages to match the above changes.
3812
3813 2016-07-27  Alexey Proskuryakov  <ap@apple.com>
3814
3815         LayoutTestRelay should wait for WebKitTestRunnerApp installation to complete
3816         https://bugs.webkit.org/show_bug.cgi?id=160262
3817
3818         Reviewed by Daniel Bates.
3819
3820         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3821         (-[LTRelayController installApp]):
3822
3823 2016-07-27  Ryan Haddad  <ryanhaddad@apple.com>
3824
3825         Disable WebCoreNSURLSessionTest API tests on ios-simulator
3826         https://bugs.webkit.org/show_bug.cgi?id=160225
3827
3828         Reviewed by Alexey Proskuryakov.
3829
3830         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
3831
3832 2016-07-27  Miguel Gomez  <magomez@igalia.com>
3833
3834         [GTK] Fix some video/canvas tests that should be passing
3835         https://bugs.webkit.org/show_bug.cgi?id=160023
3836
3837         Reviewed by Carlos Garcia Campos.
3838
3839         Add a platform identifier to the TestRunner's page user agent when the tests are run on the
3840         EFL or GTK platforms.
3841
3842         * WebKitTestRunner/efl/TestControllerEfl.cpp:
3843         (WTR::TestController::platformConfigureViewForTest):
3844         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3845         (WTR::TestController::platformConfigureViewForTest):
3846
3847 2016-07-27  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3848
3849         [Tools] The built product doesn't contains the dwo files when DEBUG_FISSION is enabled.
3850         https://bugs.webkit.org/show_bug.cgi?id=160247
3851
3852         Reviewed by Michael Catanzaro.
3853
3854         * BuildSlaveSupport/built-product-archive:
3855         (createZip):
3856         (dirContainsdwo):
3857         (archiveBuiltProduct):
3858
3859 2016-07-26  Alex Christensen  <achristensen@webkit.org>
3860
3861         Fix tests after r203743.
3862         https://bugs.webkit.org/show_bug.cgi?id=156947
3863
3864         * WebKitTestRunner/TestController.cpp:
3865         (WTR::TestController::resetStateToConsistentValues):
3866         Reset the new boolean m_rejectsProtectionSpaceAndContinueForAuthenticationChallenges.
3867
3868 2016-07-26  Myles C. Maxfield  <mmaxfield@apple.com>
3869
3870         [iPhone] Playing a video on tudou.com plays only sound, no video
3871         https://bugs.webkit.org/show_bug.cgi?id=160178
3872         <rdar://problem/27535468>
3873
3874         Reviewed by Dan Bernstein.
3875
3876         * DumpRenderTree/mac/DumpRenderTree.mm:
3877         (setDefaultsToConsistentValuesForTesting):
3878         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
3879         (RequiresUserActionForPlaybackTest::SetUp):
3880         * WebKitTestRunner/TestController.cpp:
3881         (WTR::TestController::resetPreferencesToConsistentValues):
3882         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3883         (WTR::initializeWebViewConfiguration):
3884
3885 2016-07-26  Simon Fraser  <simon.fraser@apple.com>
3886
3887         Allow LOG macros to be used outside the namespace, and other logging cleanup
3888         https://bugs.webkit.org/show_bug.cgi?id=160216
3889
3890         Reviewed by Anders Carlsson.
3891         
3892         initializeLoggingChannelsIfNecessary -> initializeLogChannelsIfNecessary
3893
3894         * DumpRenderTree/TestRunner.cpp:
3895         * DumpRenderTree/mac/DumpRenderTree.mm:
3896         (resetWebViewToConsistentStateBeforeTesting):
3897
3898 2016-07-26  David Kilzer <ddkilzer@apple.com>
3899
3900         Networking process crash due to missing -[WebCoreAuthenticationClientAsChallengeSender performDefaultHandlingForAuthenticationChallenge:] implementation
3901         https://bugs.webkit.org/show_bug.cgi?id=156947
3902         <rdar://problem/23325160>
3903
3904         Reviewed by Alex Christensen.
3905
3906         * DumpRenderTree/TestRunner.cpp:
3907         (TestRunner::TestRunner):
3908         (setRejectsProtectionSpaceAndContinueForAuthenticationChallengesCallback):
3909         * DumpRenderTree/TestRunner.h:
3910         (TestRunner::rejectsProtectionSpaceAndContinueForAuthenticationChallenges):
3911         (TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
3912         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3913         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
3914         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3915         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3916         (WTR::TestRunner::queueNonLoadingScript):
3917         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
3918         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3919         * WebKitTestRunner/TestController.cpp:
3920         (WTR::TestController::didReceiveAuthenticationChallenge):
3921         * WebKitTestRunner/TestController.h:
3922         (WTR::TestController::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
3923         * WebKitTestRunner/TestInvocation.cpp:
3924         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3925         Add TestRunner.setRejectsProtectionSpaceAndContinueForAuthenticationChallenges to use for testing.
3926
3927 2016-07-26  David Kilzer  <ddkilzer@apple.com>
3928
3929         check-for-exit-time-destructors should be usable outside Xcode
3930         <https://webkit.org/b/160195>
3931
3932         Reviewed by Darin Adler.
3933
3934         * Scripts/check-for-exit-time-destructors: Update to parse
3935         -h|--help switch, or to take one argument to a binary to check
3936         for exit time destructors on the command-line.  The clang
3937         compiler will find these at compile-time with the
3938         -Wexit-time-destructors switch, but this script will check for
3939         them after-the-fact.
3940
3941 2016-07-26  Lucas Forschler  <lforschler@apple.com>
3942
3943         Test svn.webkit.org functionality after maintenance.
3944
3945 2016-07-25  Brady Eidson  <beidson@apple.com>
3946
3947         Modern IDB: Make sure IndexedDB works from file:// url documents by default
3948         https://bugs.webkit.org/show_bug.cgi?id=153783
3949
3950         Reviewed by Alex Christensen.
3951
3952         Previously, to grant IndexedDB access to file:// urls for testing purposes, 
3953         we had to call the SPI [WKWebViewConfiguration _setAllowUniversalAccessFromFileURLs:].
3954         
3955         As of https://trac.webkit.org/changeset/203695 this is no longer required.
3956         
3957         Change the relevant API tests to make sure this continues to be no longer required.
3958
3959         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
3960         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
3961         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
3962         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
3963         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
3964         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
3965
3966 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3967
3968         Media controls should not be displayed for a video until it starts playing
3969         https://bugs.webkit.org/show_bug.cgi?id=160092
3970         <rdar://problem/26986673>
3971
3972         Reviewed by Beth Dakin.
3973
3974         Verify that multiple videos do or don't show the media controller depending on whether videos
3975         are playing. Also tweaks an existing API test (VideoControlsManagerSingleLargeVideo) that was
3976         passing because we were always showing media controls for large videos with audio, even if they
3977         had not played back yet. This change ensures that large videos with audio show media controls
3978         only after they begin to play back, and not by virtue of being large enough for main content.
3979
3980         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3981         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
3982         (TestWebKitAPI::TEST):
3983         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html:
3984         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html: Added.
3985         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio.html: Added.
3986
3987 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3988
3989         Media controls on apple.com don't disappear when movie finishes playing
3990         https://bugs.webkit.org/show_bug.cgi?id=160068
3991         <rdar://problem/26668526>
3992
3993         Reviewed by Darin Adler.
3994
3995         Adds new API tests. Please see WebCore ChangeLog for more details.
3996
3997         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3998         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
3999         (-[MediaPlaybackMessageHandler initWithWKWebView:finalMessageString:]):
4000         (-[MediaPlaybackMessageHandler userContentController:didReceiveScriptMessage:]):
4001         (TestWebKitAPI::TEST):
4002         (-[DidPlayMessageHandler initWithWKWebView:]): Deleted.
4003         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
4004         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html: Added.
4005         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html: Added.
4006         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html: Added.
4007
4008 2016-07-25  Philippe Normand  <pnormand@igalia.com>
4009
4010         Unreviewed, fix test-webkitpy after r203674.
4011
4012         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
4013         (GDBCrashLogGeneratorTest.test_generate_crash_log):
4014
4015 2016-07-24  Philippe Normand  <pnormand@igalia.com>
4016
4017         Unreviewed, forgot to commit this file in r203674.
4018
4019         * Scripts/process-linux-coredump: Added.
4020         (main):
4021
4022 2016-07-25  Philippe Normand  <pnormand@igalia.com>
4023
4024         Improve GDB backtrace generation for GTK/EFL
4025         https://bugs.webkit.org/show_bug.cgi?id=128928
4026
4027         Reviewed by Carlos Garcia Campos.
4028
4029         The PID of the crashed process is now correctly supplied to the
4030         crash log reporter. The kernel core_pattern needs to be updated
4031         after this change to something like:
4032
4033         echo "|/home/phil/WebKit/Tools/Scripts/process-linux-coredump /tmp/core-pid_%p.dump" > /proc/sys/kernel/core_pattern
4034
4035         * Scripts/process-linux-coredump: Added.
4036         (main): Minimal python script reading coredump data on stdin and writing it to a file in /tmp/.
4037         * Scripts/webkitpy/port/efl.py:
4038         (EflPort._get_crash_log): Supply path of the process-linux-coredump script.
4039         * Scripts/webkitpy/port/gtk.py:
4040         (GtkPort._get_crash_log): Ditto.
4041         * Scripts/webkitpy/port/linux_get_crash_log.py:
4042         (GDBCrashLogGenerator.__init__): New argument for supplying the path of a coredump processor script.
4043         (GDBCrashLogGenerator.generate_crash_log): Update error message, the core_pattern should now be set to pipe coredumps to a script.
4044         (GDBCrashLogGenerator): Deleted.
4045         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
4046         (GDBCrashLogGeneratorTest.test_generate_crash_log): Update test expectations.
4047         * WebKitTestRunner/TestController.cpp:
4048         (WTR::TestController::networkProcessDidCrash): Supply PID of crash process.
4049         (WTR::TestController::databaseProcessDidCrash): Ditto.
4050         (WTR::TestController::processDidCrash): Ditto.
4051
4052 2016-07-23  Youenn Fablet  <youenn@apple.com>
4053
4054         WPT stash server should be kept running when launching wpt server
4055         https://bugs.webkit.org/show_bug.cgi?id=160052
4056
4057         Reviewed by Sam Weinig.
4058
4059         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
4060         (main): waiting to read stdin while stash server is started.
4061
4062 2016-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
4063
4064         Media controls should be displayed for media in media documents
4065         https://bugs.webkit.org/show_bug.cgi?id=160104
4066         <rdar://problem/27438936>
4067
4068         Reviewed by Myles C. Maxfield.
4069
4070         Verifies that even a small video with audio in a media document gets media controls.
4071
4072         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
4073         (TestWebKitAPI::TEST):
4074
4075 2016-07-22  Michael Saboff  <msaboff@apple.com>
4076
4077         REGRESSION(203616): no FTL testing was inadvertently removed
4078         https://bugs.webkit.org/show_bug.cgi?id=160100
4079
4080         Rubber-stamped by Filip Pizlo.
4081
4082         Added runNoFTL back into the set of tests we run on FTL enabled platforms.
4083         Renamed runLayoutTestNoFTL to runLayoutTestDefault.  Restructured the test
4084         logic for the runLayout and runNoisy variants to match the run test logic,
4085         that is we always invoke runXXXDefault and invoke runXXXNoFTL for FTL
4086         enabled platforms.
4087
4088         * Scripts/run-jsc-stress-tests:
4089
4090 2016-07-22  Brady Eidson  <beidson@apple.com>
4091
4092         Removing IndexedDatabases that have stored blobs doesn't remove the blob files.
4093         https://bugs.webkit.org/show_bug.cgi?id=160089
4094
4095         Reviewed by Darin Adler.
4096
4097         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4098         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm: Added.
4099         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobToBeDeleted.html: Added.
4100
4101 2016-07-22  Konstantin Tokarev  <annulen@yandex.ru>
4102
4103         [GTK] Improved exclusion patterns in make-dist.py manifest.
4104         https://bugs.webkit.org/show_bug.cgi?id=160094
4105
4106         Reviewed by Michael Catanzaro.
4107
4108         * gtk/manifest.txt.in:
4109         Exclude Platform*.cmake files for more ports.
4110         Removed obsolete .gyp and .pro.user patterns.
4111         Exclude 'Configurations' and 'spi' directories.
4112         Exclude CMakeLists.txt.user (Qt Creator IDE).
4113
4114 2016-07-22  Michael Saboff  <msaboff@apple.com>
4115
4116         Don't run FTL related JSC stress tests on non-FTL platforms
4117         https://bugs.webkit.org/show_bug.cgi?id=160033
4118
4119         Reviewed by Mark Lam.
4120
4121         Added check for running tests on platforms that don't enable FTL to not run FTL tests.
4122         Refactored several of the runXXX test methods to always runXXXDefault and made those
4123         runXXXDefault to pass FTL_OPTIONS.  For platforms that don't enable the FTL, FTL_OPTIONS
4124         doesn't cause a problem.
4125
4126         * Scripts/run-jsc-stress-tests:
4127
4128 2016-07-22  Per Arne Vollan  <pvollan@apple.com>
4129
4130         IWebView::mainFrame crashes if called after IWebView::close
4131         https://bugs.webkit.org/show_bug.cgi?id=32868
4132
4133         Reviewed by Brent Fulgham.
4134
4135         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
4136         (TestWebKitAPI::TEST_F): Added test.
4137
4138 2016-07-22  Carlos Garcia Campos  <cgarcia@igalia.com>
4139
4140         [GTK] Enable threaded compositor by default
4141         https://bugs.webkit.org/show_bug.cgi?id=160079
4142
4143         Reviewed by Žan Doberšek.
4144
4145         * Scripts/webkitperl/FeatureList.pm:
4146
4147 2016-07-22  Youenn Fablet  <youenn@apple.com>
4148
4149         run-builtins-generator-tests should be able to test WebCore builtins wrapper with more than one file
4150         https://bugs.webkit.org/show_bug.cgi?id=159921
4151
4152         Reviewed by Brian Burg.
4153
4154         Updated builtin generator test runner to generate WebCore wrapper files based on all WebCore valid separate files.
4155
4156         * Scripts/webkitpy/codegen/main.py:
4157         (BuiltinsGeneratorTests.generate_from_js_builtins): Passing a list of builtin files to the script.
4158         (BuiltinsGeneratorTests):
4159         (BuiltinsGeneratorTests.single_builtin_test): Added to handle the case of single builtin generation.
4160         (BuiltinsGeneratorTests.wrappers_builtin_test): Added to handle the case of WebCore wrappers builtin generation.
4161         (BuiltinsGeneratorTests.run_test): Helper routine to run a test in reset mode or normal check mode.
4162         (BuiltinsGeneratorTests.run_tests): Updated to add WebCore wrappers builtin generation test.
4163
4164 2016-07-21  Dan Bernstein  <mitz@apple.com>
4165
4166         [Mac] webkitdirs.pm contains unused code to support outdated OS X and Xcode versions
4167         https://bugs.webkit.org/show_bug.cgi?id=160072
4168
4169         Reviewed by Andy Estes.
4170
4171         * Scripts/webkitdirs.pm:
4172         (readXcodeUserDefault): Changed to take a defaults key rather than a suffix. Removed support
4173           for old Xcode versions.
4174         (determineBaseProductDir): Removed support for old Xcode versions. Updated for the change
4175           to readXcodeUserDefault.
4176         (debugger): Deleted. This was only used for Darwin, where LLDB is now the only supported
4177           debugger.
4178         (determineDebugger): Ditto.
4179         (checkRequiredSystemConfig): Updated to require at least OS X Yosemite v10.10.5 and Xcode
4180           7.0.
4181         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Removed --use-gdb and --use-lldb
4182           switches.
4183         (execMacWebKitAppForDebugging): Removed support for GDB.
4184
4185 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
4186
4187         Remove support for deprecated SPI inlineMediaPlaybackRequiresPlaysInlineAttribute
4188         https://bugs.webkit.org/show_bug.cgi?id=160066
4189
4190         Reviewed by Dean Jackson.
4191
4192         * DumpRenderTree/mac/DumpRenderTree.mm:
4193         (setDefaultsToConsistentValuesForTesting): Deleted.
4194         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
4195         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
4196         * WebKitTestRunner/TestController.cpp:
4197         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
4198         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4199         (WTR::initializeWebViewConfiguration): Deleted.
4200
4201 2016-07-21  Chelsea Pugh  <cpugh@apple.com>
4202
4203         [iOS] Apps using WKWebView will crash if they set the scroll view's delegate and don't nil it out later
4204         https://bugs.webkit.org/show_bug.cgi?id=159980
4205         rdar://problem/27450825
4206
4207         Reviewed by Dan Bernstein.
4208
4209         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4210         * TestWebKitAPI/Tests/ios/WKScrollViewDelegateCrash.mm: Added.
4211         (-[TestDelegateForScrollView dealloc]): Update delegateIsDeallocated to true so that we can tell
4212         when our delegate has hit -dealloc.
4213         (TestWebKitAPI::TEST): Ensure that after an object has been set as the scroll view's delegate,
4214         and has then been deallocated, that the scroll view's delegate is nil and the deallocated delegate
4215         will not be messaged.
4216
4217 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
4218
4219         Follow-up patch to r203520
4220         https://bugs.webkit.org/show_bug.cgi?id=159967
4221         <rdar://problem/26964090>
4222
4223         Unreviewed.
4224
4225         * DumpRenderTree/mac/DumpRenderTree.mm:
4226         (setDefaultsToConsistentValuesForTesting):
4227         * WebKitTestRunner/TestController.cpp:
4228         (WTR::TestController::resetPreferencesToConsistentValues):
4229
4230 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
4231
4232         [iPhone] Playing a video on tudou.com plays only sound, no video
4233         https://bugs.webkit.org/show_bug.cgi?id=159967
4234         <rdar://problem/26964090>
4235
4236         Reviewed by Jon Lee, Jeremy Jones, and Anders Carlsson.
4237
4238         Migrate tests to use new SPI.
4239
4240         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
4241         (RequiresUserActionForPlaybackTest::SetUp):
4242         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4243         (WTR::initializeWebViewConfiguration):
4244
4245 2016-07-21  Csaba Osztrogonác  <ossy@webkit.org>
4246
4247         Clarify testing mode names in run-jsc-stress-tests
4248         https://bugs.webkit.org/show_bug.cgi?id=160021
4249
4250         Reviewed by Mark Lam.
4251
4252         Default should mean really default, not default with disabled FTL, renamed
4253         - runMozillaTestDefault to runMozillaTestNoFTL
4254         - runMozillaTestDefaultFTL to runMozillaTestDefault
4255         - runDefault to runNoFTL
4256         - runDefaultFTL to runDefault
4257         - runLayoutTestDefault to runLayoutTestNoFTL
4258         - runLayoutTestDefaultFTL to runLayoutTestDefault
4259         - runNoisyTestDefault to runNoisyTestNoFTL
4260         - runNoisyTestDefaultFTL to runNoisyTestDefault
4261
4262         * Scripts/run-jsc-stress-tests:
4263
4264 2016-07-21  Yongjun Zhang  <yongjun_zhang@apple.com>
4265
4266         WebBackForwardList's currentIndex could get out of bounds when filtering items.
4267         https://bugs.webkit.org/show_bug.cgi?id=159986
4268
4269         Add a test to verify filtering out 2 items from a 3-item list will set the currentIndex
4270         to 0.
4271
4272         Reviewed by Dan Bernstein.
4273
4274         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4275         * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm: Added.
4276         (-[WKBackForwardListTestNavigationDelegate webView:didFinishNavigation:]):
4277         (TEST):<