Tools/ChangeLog

   1 2014-07-01  Sam Weinig  <sam@webkit.org>
   2
   3         [Cocoa][Mac] WKWebView should automatically set topContentInset when beneath a toolbar
   4         <rdar://problem/17523159>
   5         https://bugs.webkit.org/show_bug.cgi?id=134496
   6
   7         Reviewed by Beth Dakin.
   8
   9         * MiniBrowser/mac/BrowserWindowController.m:
  10         (-[BrowserWindowController windowDidLoad]):
  11         Use the NSFullSizeContentViewWindowMask bit on Yosemite and later to enable toolbar blurring.
  12
  13 2014-07-01  Zan Dobersek  <zdobersek@igalia.com>
  14
  15         [CMake] Add necessary support for building for the Wayland target
  16         https://bugs.webkit.org/show_bug.cgi?id=134160
  17
  18         Reviewed by Darin Adler.
  19
  20         * CMakeLists.txt: Only build the TestNetscapePlugIn target in case
  21         the X11 windowing target is enabled.
  22
  23 2014-07-01  Chris Fleizach  <cfleizach@apple.com>
  24
  25         AX: HTML indeterminate IDL attribute not mapped to checkbox value=2
  26         https://bugs.webkit.org/show_bug.cgi?id=134492
  27
  28         Reviewed by Andreas Kling.
  29
  30         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
  31         (AccessibilityUIElement::isIndeterminate):
  32         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
  33         (WTR::AccessibilityUIElement::isIndeterminate):
  34
  35 2014-07-01  Daniel Bates  <dabates@apple.com>
  36
  37         Remove unnecessary calls to std::move()
  38         https://bugs.webkit.org/show_bug.cgi?id=134493
  39
  40         Reviewed by Anders Carlsson.
  41
  42         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
  43         (TestWebKitAPI::TEST):
  44         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
  45         (TestWebKitAPI::TEST):
  46
  47 2014-07-01  Pratik Solanki  <psolanki@apple.com>
  48
  49         Unreviewed. Adding myself to the reviewers list to make commit bot happy.
  50
  51         * Scripts/webkitpy/common/config/contributors.json:
  52
  53 2014-07-01  Youenn Fablet  <youenn.fablet@crf.canon.fr>
  54
  55         webkit-patch apply-from-bug / apply-attachment should not ask for credentials if none are required
  56         https://bugs.webkit.org/show_bug.cgi?id=40095
  57
  58         Reviewed by Csaba Osztrogonác.
  59
  60         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  61         (Bugzilla.fetch_attachment_contents): make a first fetch on bugzilla without authentication. If failing, use authentication (similar to fetch_bug_dictionary).
  62         (Bugzilla):
  63         (Bugzilla.bug_id_for_attachment_id): ditto.
  64
  65 2014-07-01  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
  66
  67         [webkitpy] Refactor pluralizer in grammar.py
  68         https://bugs.webkit.org/show_bug.cgi?id=133067
  69
  70         Reviewed by Csaba Osztrogonác.
  71
  72         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
  73         (LayoutTestRunner.run_tests):
  74         * Scripts/webkitpy/layout_tests/controllers/manager.py:
  75         (Manager.run):
  76         * Scripts/webkitpy/layout_tests/views/printing.py:
  77         (Printer.print_found):
  78         (Printer.print_workers_and_shards):
  79         (Printer._print_one_line_summary):
  80         * Scripts/webkitpy/test/printer.py:
  81         (Printer.print_result):
  82         * Scripts/webkitpy/tool/bot/feeders.py:
  83         (EWSFeeder.feed):
  84         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
  85         (FlakyTestReporter._lookup_bug_for_flaky_test):
  86         * Scripts/webkitpy/tool/bot/irc_command.py:
  87         (Rollout._check_diff_failure):
  88         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
  89         (IRCCommandTest.test_rollout):
  90         * Scripts/webkitpy/tool/commands/download.py:
  91         (AbstractPatchProcessingCommand._process_patch.execute):
  92         (ProcessBugsMixin._fetch_list_of_patches_to_process):
  93         (ProcessURLsMixin._fetch_list_of_patches_to_process):
  94         * Scripts/webkitpy/tool/commands/queries.py:
  95         (WhatBroke.execute):
  96         * Scripts/webkitpy/tool/commands/suggestnominations.py:
  97         (SuggestNominations._print_nominations):
  98         (SuggestNominations._print_counts):
  99         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
 100         (_make_options):
 101         (test_basic):
 102         (test_with_verbose):
 103         * Scripts/webkitpy/tool/commands/upload.py:
 104         (PostCommits.execute):
 105         * Scripts/webkitpy/tool/grammar.py:
 106         (pluralize):
 107         * Scripts/webkitpy/tool/grammar_unittest.py:
 108         (GrammarTest.test_join_with_separators):
 109         (GrammarTest):
 110         (GrammarTest.test_plural):
 111         (GrammarTest.test_pluralize):
 112         * Scripts/webkitpy/tool/multicommandtool.py:
 113         (Command.check_arguments_and_execute):
 114         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
 115         (ObsoletePatches.run):
 116         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
 117         (PrepareChangeLogForRevert._message_for_revert):
 118
 119 2014-06-30  Myles C. Maxfield  <mmaxfield@apple.com>
 120
 121         [iOS] GSFontAddCGFont is deprecated and we use it in DumpRenderTree
 122         https://bugs.webkit.org/show_bug.cgi?id=134133
 123
 124         Reviewed by Simon Fraser.
 125
 126         Replace it with CTFontManagerRegisterGraphicsFont
 127
 128         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 129         * DumpRenderTree/mac/DumpRenderTree.mm:
 130         (activateFontIOS):
 131
 132 2014-06-30  Michael Saboff  <msaboff@apple.com>
 133
 134         Add option to run-jsc-stress-testes to filter out tests that use large heaps
 135         https://bugs.webkit.org/show_bug.cgi?id=134458
 136
 137         Reviewed by Filip Pizlo.
 138
 139         Added new --memory-limited to filter out tests that have large heap usage.
 140         Such tests are either tagged with //@largeHeap or logic is added to their .yaml file.
 141
 142         * Scripts/run-jsc-stress-tests:
 143
 144 2014-06-30  Myles C. Maxfield  <mmaxfield@apple.com>
 145
 146         DRT in iOS sim crashes while loading fonts
 147         https://bugs.webkit.org/show_bug.cgi?id=134451
 148
 149         Reviewed by Geoffrey Garen.
 150
 151         The magic linker symbols had the same name, and were therefore being unified
 152         to a single font file. Then, adding the same file twice was failing.
 153
 154         * DumpRenderTree/mac/DumpRenderTree.mm:
 155         (activateFontsIOS):
 156
 157 2014-06-30  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
 158
 159         Remove Qt cruft from webkitpy
 160         https://bugs.webkit.org/show_bug.cgi?id=134445
 161
 162         Reviewed by Csaba Osztrogonác.
 163
 164         * Scripts/webkitpy/common/config/ports.py:
 165         (DeprecatedPort.port):
 166         (QtPort): Deleted.
 167         (QtPort.build_webkit_command): Deleted.
 168         (QtPort.run_webkit_tests_command): Deleted.
 169         (QtWK2Port): Deleted.
 170         (QtWK2Port.build_webkit_command): Deleted.
 171         (QtWK2Port.run_webkit_tests_command): Deleted.
 172         * Scripts/webkitpy/common/config/ports_unittest.py:
 173         (DeprecatedPortTest): Deleted.
 174         (DeprecatedPortTest.test_qt_port): Deleted.
 175         (DeprecatedPortTest.test_qt_wk2_port): Deleted.
 176
 177 2014-06-29  Yoav Weiss  <yoav@yoav.ws>
 178
 179         Add support for HTMLImageElement's sizes attribute
 180         https://bugs.webkit.org/show_bug.cgi?id=133620
 181
 182         Reviewed by Dean Jackson.
 183
 184         Added an ENABLE_PICTURE_SIZES compile flag.
 185
 186         * Scripts/webkitperl/FeatureList.pm:
 187
 188 2014-06-27  Tim Horton  <timothy_horton@apple.com>
 189
 190         check-webkit-style should check the order of #imports as well as #includes
 191         https://bugs.webkit.org/show_bug.cgi?id=134428
 192
 193         Reviewed by Dan Bernstein.
 194
 195         * Scripts/webkitpy/style/checkers/cpp.py:
 196         Allow "import" in addition to "include", so that the sort order of headers in ObjC files is checked.
 197
 198 2014-06-27  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
 199
 200         [EFL] Remove efl-wk2 from baseline search path
 201         https://bugs.webkit.org/show_bug.cgi?id=134391
 202
 203         Reviewed by Gyuyoung Kim.
 204
 205         As WebKit1 EFL is removed and platform/efl and platform/efl-wk2 baselines and test expectations files
 206         are merged efl-wk2 search path should be removed.
 207
 208         * Scripts/webkitpy/port/base.py:
 209         (Port.test_expectations_file_postion): Added method to determine port test expectations file position in expectations_dict.
 210         * Scripts/webkitpy/port/efl.py:
 211         (EflPort._search_paths): Changed baseline search paths from efl-wk2 -> wk2 -> efl -> generic is changed to: efl -> wk2 -> generic.
 212         (EflPort.test_expectations_file_postion): Added method to determine EFL port specific test expectation file position.
 213         * Scripts/webkitpy/port/port_testcase.py:
 214         (PortTestCase.test_expectations_ordering): Changed constant value to one returned from test_expectations_file_postion().
 215         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
 216         (TestExpectationsTestCase.test_determine_port_from_expectations_path): Removed efl-wk2 test case.
 217         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
 218         (TestRebaselineTest.test_baseline_directory): Changed directory name in assertion from platform/efl-wk2 to platform/efl.
 219
 220 2014-06-26  Dan Bernstein  <mitz@apple.com>
 221
 222         prepare-ChangeLog outputs (NS_ENUM): entries for Cocoa enums
 223         https://bugs.webkit.org/show_bug.cgi?id=134387
 224
 225         Reviewed by Tim Horton.
 226
 227         * Scripts/prepare-ChangeLog:
 228         (get_function_line_ranges_for_cpp): Don’t consider {CF,NS}_{ENUM,OPTIONS} as function names.
 229
 230 2014-06-26  Dan Bernstein  <mitz@apple.com>
 231
 232         prepare-ChangeLog mangles Objective-C selectors for methods with parameter types that contain colons
 233         https://bugs.webkit.org/show_bug.cgi?id=134383
 234
 235         Reviewed by Tim Horton.
 236
 237         * Scripts/prepare-ChangeLog:
 238         (method_decl_to_selector): Strip out the return type and parameter types before splitting at
 239         colons.
 240
 241 2014-06-26  Brady Eidson  <beidson@apple.com>
 242
 243         MiniBrowser should support a preference to override the default URL
 244         https://bugs.webkit.org/show_bug.cgi?id=134373
 245
 246         Reviewed by Darin Adler.
 247
 248         * MiniBrowser/mac/AppDelegate.m:
 249         (-[BrowserAppDelegate applicationDidFinishLaunching:]): See if there’s a pref
 250           overriding the default URL, and use it if there is.
 251
 252 2014-06-26  Brent Fulgham  <bfulgham@apple.com>
 253
 254         [Win] Fix potential buffer overrun in DLLLauncher
 255         https://bugs.webkit.org/show_bug.cgi?id=134351
 256         <rdar://problem/17469185>
 257
 258         Reviewed by Darin Adler.
 259
 260         * win/DLLLauncher/DLLLauncherMain.cpp: Correct error
 261         in end-of-buffer calculation.
 262
 263 2014-06-26  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
 264
 265         [EFL] Missing dependency between freetype6 and fontconfig libs.
 266         https://bugs.webkit.org/show_bug.cgi?id=134190
 267
 268         Reviewed by Gyuyoung Kim.
 269
 270         The external dependencies contain the freetype6 and the fontconfig libs.
 271         The fontconfig lib requires freetype, but the dependency is not set in
 272         the efl/jhbuild.modules file. So, during building the external libs,
 273         fontconfig uses the freetype package of the system, while WebKit
 274         binaries will use freetype from the WebKitBuild/Dependency directory.
 275         There are more similar dependencies that were not indicated in the
 276         jhbuild.modules file.
 277
 278         * efl/jhbuild.modules:
 279           Added dependencies between libs.
 280
 281 2014-06-25  Brent Fulgham  <bfulgham@apple.com>
 282
 283         [Win] Expose Cache Information to WinLauncher
 284         https://bugs.webkit.org/show_bug.cgi?id=134318
 285
 286         Reviewed by Dean Jackson.
 287
 288         * WinLauncher/Common.cpp: Update for new dialog.
 289         * WinLauncher/WinLauncher.cpp: Add support for WebCache
 290         and WebCoreStatistics.
 291         * WinLauncher/WinLauncher.h:
 292         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc:
 293         Update for new Cache Dialog.
 294         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link to
 295         WTF.lib
 296         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Update
 297         for new Dialog.
 298
 299 2014-06-26  Brent Fulgham  <bfulgham@apple.com>
 300
 301         [Win] Unreviewed gardening. Use consistent line-endings in file.
 302
 303         * WinLauncher/WinLauncher.h: Use '\n' EOL marker, not DOS-style
 304         '\r\n' EOL.
 305
 306 2014-06-25  László Langó  <llango.u-szeged@partner.samsung.com>
 307
 308         [JavaScriptCore] Make build-jsc output format better.
 309         https://bugs.webkit.org/show_bug.cgi?id=133547
 310
 311         Reviewed by Ryosuke Niwa.
 312
 313         * Scripts/build-jsc: Emit built time information on successful builds.
 314         (writeCongrats):
 315         * Scripts/build-webkit: Move formatBuildTime function into webkitdirs.pm.
 316         (cMakeArgsFromFeatures):
 317         (formatBuildTime): Deleted.
 318         * Scripts/webkitdirs.pm:
 319         (formatBuildTime):
 320
 321 2014-06-25  Chris Fleizach  <cfleizach@apple.com>
 322
 323         Add an undo group for each dictated utterance in WebKit
 324         https://bugs.webkit.org/show_bug.cgi?id=134086
 325
 326         Reviewed by Enrica Casucci.
 327
 328         Create a method for creating attributed strings with the undo insertion marker.
 329
 330         * DumpRenderTree/mac/TextInputController.m:
 331         (+[TextInputController isSelectorExcludedFromWebScript:]):
 332         (+[TextInputController webScriptNameForSelector:]):
 333         (-[TextInputController stringWithUndoGroupingInsertion:]):
 334
 335 2014-06-25  Michael Saboff  <msaboff@apple.com>
 336
 337         Provide javascript aware backtrace script for lldb
 338         https://bugs.webkit.org/show_bug.cgi?id=134276
 339
 340         Reviewed by Jer Noble.
 341
 342         * lldb/lldb_webkit.py:
 343         (__lldb_init_module):
 344         (btjs): New scripted command to display a backtrace that shows JavaScript frames with details.
 345
 346 2014-06-25  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
 347
 348         REGRESSION (r170426) Broke two python tests
 349         https://bugs.webkit.org/show_bug.cgi?id=134299
 350
 351         Reviewed by Csaba Osztrogonác.
 352
 353         * Scripts/webkitpy/port/efl.py:
 354         (EflPort._search_paths): Added search path for efl-wk2.
 355
 356 2014-06-25  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
 357
 358         [EFL] Remove WebKit1 related code from scripts
 359         https://bugs.webkit.org/show_bug.cgi?id=134195
 360
 361         Reviewed by Laszlo Gombos.
 362
 363         After removing WebKit1 from EFL port, still there is some code left related to DumpRenderTree,
 364         EWebLauncher. Also running layout tests does not require adding -2/--webkit-test-runner switch.
 365
 366         * Scripts/run-launcher: MiniBrowser now runs as default without -2 switch.
 367         * Scripts/webkitdirs.pm:
 368         (builtDylibPathForName): Remove reference to libewebkit.so
 369         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 370         (_set_up_derived_options): Script runs WKTR by default.
 371         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
 372         (PerfTestsRunner.__init__): Ditto.
 373         * Scripts/webkitpy/port/efl.py:
 374         (EflPort._search_paths): Remove efl-wk2 from baseline search path.
 375         (EflPort.show_results_html_file): Run MiniBrowser as result viewer.
 376
 377 2014-06-25  Laszlo Gombos  <l.gombos@samsung.com>
 378
 379         Remove build guard for progress element
 380         https://bugs.webkit.org/show_bug.cgi?id=134292
 381
 382         Reviewed by Benjamin Poulain.
 383
 384         * Scripts/webkitperl/FeatureList.pm:
 385
 386 2014-06-24  Tomas Popela  <tpopela@redhat.com>
 387
 388         [GTK] Some of DOM bindings macros are misnamed
 389         https://bugs.webkit.org/show_bug.cgi?id=121543
 390
 391         Reviewed by Carlos Garcia Campos.
 392
 393         As we are using WebKitDOM as a namespace we should unify all type macros
 394         to have WEBKIT_DOM_TYPE prefix instead of WEBKIT_TYPE_DOM. Also add
 395         more exceptions to decamelize function in GObject bindings generator
 396         to fix the names of bindings for BR, HR, UL, OL, DL and LI elements.
 397
 398         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
 399         * gtk/webkitdom.py:
 400         (WebKitDOMDocGeneratorSections._dom_class_decamelize):
 401         (WebKitDOMDocGeneratorSections.write_section):
 402
 403 2014-06-24  Frédéric Wang  <fred.wang@free.fr>
 404
 405         [EFL] Install Latin Modern Math on the bots
 406         https://bugs.webkit.org/show_bug.cgi?id=134153
 407
 408         Reviewed by Gyuyoung Kim.
 409
 410         * efl/jhbuild.modules: Switch back to https://github.com/ for the webkitgtk-test-fonts.
 411
 412 2014-06-24  Frédéric Wang  <fred.wang@free.fr>
 413
 414         [EFL] [GTK] Use Latin Modern Math in the jhbuild environments.
 415         https://bugs.webkit.org/show_bug.cgi?id=134153
 416
 417         Reviewed by Martin Robinson.
 418
 419         * efl/jhbuild.modules: Use webkitgtk-test-fonts.git instead of the zip archive and upgrade to 0.0.5.
 420         * gtk/jhbuild.modules: Upgrade webkitgtk-test-fonts to 0.0.5.
 421
 422 2014-06-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 423
 424         Unreviewed, update my speciality.
 425
 426         * Scripts/webkitpy/common/config/contributors.json:
 427
 428 2014-06-24  Brent Fulgham  <bfulgham@apple.com>
 429
 430         [Win] Clean up and refactor WinLauncher
 431         https://bugs.webkit.org/show_bug.cgi?id=134209
 432
 433         Reviewed by Tim Thorton.
 434
 435         Relanding r170339 and r170340 with correct WinLauncher.h file.
 436
 437         * WinLauncher/Common.cpp: Copied from WinLauncher/WinLauncher.cpp.
 438         (PrintView):
 439         (ToggleMenuItem):
 440         (WndProc):
 441         (BackButtonProc):
 442         (ForwardButtonProc):
 443         (loadURL):
 444         (shouldUseFullDesktop): Deleted.
 445         (SimpleEventListener::SimpleEventListener): Deleted.
 446         (SimpleEventListener::handleEvent): Deleted.
 447         (WinLauncherWebHost::updateAddressBar): Deleted.
 448         (WinLauncherWebHost::didFailProvisionalLoadWithError): Deleted.
 449         (WinLauncherWebHost::QueryInterface): Deleted.
 450         (WinLauncherWebHost::AddRef): Deleted.
 451         (WinLauncherWebHost::Release): Deleted.
 452         (updateMenuItemForHistoryItem): Deleted.
 453         (showLastVisitedSites): Deleted.
 454         (WinLauncherWebHost::didFinishLoadForFrame): Deleted.
 455         (resizeSubViews): Deleted.
 456         (setToDefaultPreferences): Deleted.
 457         (wWinMain): Deleted.
 458         (MyRegisterClass): Deleted.
 459         (LaunchInspector): Deleted.
 460         (NavigateForwardOrBackward): Deleted.
 461         (NavigateToHistory): Deleted.
 462         * WinLauncher/DOMDefaultImpl.cpp: Copied from WinLauncher/DOMDefaultImpl.h.
 463         (DOMEventListener::Release):
 464         (WebScriptObject::WebScriptObject): Deleted.
 465         (WebScriptObject::~WebScriptObject): Deleted.
 466         (WebScriptObject::throwException): Deleted.
 467         (WebScriptObject::callWebScriptMethod): Deleted.
 468         (WebScriptObject::evaluateWebScript): Deleted.
 469         (WebScriptObject::removeWebScriptKey): Deleted.
 470         (WebScriptObject::stringRepresentation): Deleted.
 471         (WebScriptObject::webScriptValueAtIndex): Deleted.
 472         (WebScriptObject::setWebScriptValueAtIndex): Deleted.
 473         (WebScriptObject::setException): Deleted.
 474         (DOMEventListener::throwException): Deleted.
 475         (DOMEventListener::callWebScriptMethod): Deleted.
 476         (DOMEventListener::evaluateWebScript): Deleted.
 477         (DOMEventListener::removeWebScriptKey): Deleted.
 478         (DOMEventListener::stringRepresentation): Deleted.
 479         (DOMEventListener::webScriptValueAtIndex): Deleted.
 480         (DOMEventListener::setWebScriptValueAtIndex): Deleted.
 481         (DOMEventListener::setException): Deleted.
 482         (DOMEventListener::handleEvent): Deleted.
 483         * WinLauncher/DOMDefaultImpl.h:
 484         (WebScriptObject::QueryInterface): Deleted.
 485         (WebScriptObject::AddRef): Deleted.
 486         (WebScriptObject::Release): Deleted.
 487         (DOMObject::QueryInterface): Deleted.
 488         (DOMEventListener::QueryInterface): Deleted.
 489         (DOMEventListener::AddRef): Deleted.
 490         (DOMEventListener::Release): Deleted.
 491         * WinLauncher/WinLauncher.cpp:
 492         (WinLauncher::WinLauncher):
 493         (WinLauncher::init):
 494         (WinLauncher::prepareViews):
 495         (WinLauncher::setFrameLoadDelegate):
 496         (WinLauncher::setUIDelegate):
 497         (WinLauncher::setAccessibilityDelegate):
 498         (WinLauncher::mainFrame):
 499         (WinLauncher::seedInitialDefaultPreferences):
 500         (WinLauncher::setToDefaultPreferences):
 501         (updateMenuItemForHistoryItem):
 502         (WinLauncher::showLastVisitedSites):
 503         (WinLauncher::launchInspector):
 504         (WinLauncher::navigateForwardOrBackward):
 505         (WinLauncher::navigateToHistory):
 506         (WinLauncher::goBack):
 507         (WinLauncher::goForward):
 508         (WinLauncher::loadURL):
 509         (shouldUseFullDesktop): Deleted.
 510         (SimpleEventListener::SimpleEventListener): Deleted.
 511         (SimpleEventListener::handleEvent): Deleted.
 512         (WinLauncherWebHost::updateAddressBar): Deleted.
 513         (WinLauncherWebHost::didFailProvisionalLoadWithError): Deleted.
 514         (WinLauncherWebHost::QueryInterface): Deleted.
 515         (WinLauncherWebHost::AddRef): Deleted.
 516         (WinLauncherWebHost::Release): Deleted.
 517         (showLastVisitedSites): Deleted.
 518         (WinLauncherWebHost::didFinishLoadForFrame): Deleted.
 519         (resizeSubViews): Deleted.
 520         (subclassForLayeredWindow): Deleted.
 521         (computeFullDesktopFrame): Deleted.
 522         (DllMain): Deleted.
 523         (getAppDataFolder): Deleted.
 524         (setToDefaultPreferences): Deleted.
 525         (setCacheFolder): Deleted.
 526         (createCrashReport): Deleted.
 527         (wWinMain): Deleted.
 528         (MyRegisterClass): Deleted.
 529         (AbortProc): Deleted.
 530         (getPrinterDC): Deleted.
 531         (initDocStruct): Deleted.
 532         (PrintView): Deleted.
 533         (ToggleMenuItem): Deleted.
 534         (LaunchInspector): Deleted.
 535         (NavigateForwardOrBackward): Deleted.
 536         (NavigateToHistory): Deleted.
 537         (WndProc): Deleted.
 538         (EditProc): Deleted.
 539         (BackButtonProc): Deleted.
 540         (ForwardButtonProc): Deleted.
 541         (About): Deleted.
 542         (loadURL): Deleted.
 543         (dllLauncherEntryPoint): Deleted.
 544         * WinLauncher/WinLauncher.h:
 545         (WinLauncher::standardPreferences):
 546         (WinLauncher::privatePreferences):
 547         (WinLauncher::hasWebView):
 548         (WinLauncher::usesLayeredWebView):
 549         (WinLauncherWebHost::WinLauncherWebHost): Deleted.
 550         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Deleted.
 551         (WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame): Deleted.
 552         (WinLauncherWebHost::didCommitLoadForFrame): Deleted.
 553         (WinLauncherWebHost::didReceiveTitle): Deleted.
 554         (WinLauncherWebHost::didChangeIcons): Deleted.
 555         (WinLauncherWebHost::didReceiveIcon): Deleted.
 556         (WinLauncherWebHost::didFailLoadWithError): Deleted.
 557         (WinLauncherWebHost::didChangeLocationWithinPageForFrame): Deleted.
 558         (WinLauncherWebHost::willPerformClientRedirectToURL): Deleted.
 559         (WinLauncherWebHost::didCancelClientRedirectForFrame): Deleted.
 560         (WinLauncherWebHost::willCloseFrame): Deleted.
 561         (WinLauncherWebHost::windowScriptObjectAvailable): Deleted.
 562         (WinLauncherWebHost::didClearWindowObject): Deleted.
 563         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
 564         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
 565         * WinLauncher/WinLauncherReplace.h:
 566         (processCrashReport):
 567         * WinLauncher/WinLauncherWebHost.cpp: Copied from WinLauncher/WinLauncher.cpp.
 568         (WinLauncherWebHost::updateAddressBar):
 569         (WinLauncherWebHost::QueryInterface):
 570         (WinLauncherWebHost::AddRef):
 571         (WinLauncherWebHost::Release):
 572         (WinLauncherWebHost::didFinishLoadForFrame):
 573         (shouldUseFullDesktop): Deleted.
 574         (updateMenuItemForHistoryItem): Deleted.
 575         (showLastVisitedSites): Deleted.
 576         (resizeSubViews): Deleted.
 577         (subclassForLayeredWindow): Deleted.
 578         (computeFullDesktopFrame): Deleted.
 579         (DllMain): Deleted.
 580         (getAppDataFolder): Deleted.
 581         (setToDefaultPreferences): Deleted.
 582         (setCacheFolder): Deleted.
 583         (createCrashReport): Deleted.
 584         (wWinMain): Deleted.
 585         (MyRegisterClass): Deleted.
 586         (AbortProc): Deleted.
 587         (getPrinterDC): Deleted.
 588         (initDocStruct): Deleted.
 589         (PrintView): Deleted.
 590         (ToggleMenuItem): Deleted.
 591         (LaunchInspector): Deleted.
 592         (NavigateForwardOrBackward): Deleted.
 593         (NavigateToHistory): Deleted.
 594         (WndProc): Deleted.
 595         (EditProc): Deleted.
 596         (BackButtonProc): Deleted.
 597         (ForwardButtonProc): Deleted.
 598         (About): Deleted.
 599         (loadURL): Deleted.
 600         (dllLauncherEntryPoint): Deleted.
 601         * WinLauncher/WinLauncherWebHost.h: Copied from WinLauncher/WinLauncher.h.
 602         (WinLauncherWebHost::WinLauncherWebHost):
 603         (WinLauncherWebHost::didStartProvisionalLoadForFrame):
 604         (WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame):
 605         (WinLauncherWebHost::didCommitLoadForFrame):
 606         (WinLauncherWebHost::didReceiveTitle):
 607         (WinLauncherWebHost::didChangeIcons):
 608         (WinLauncherWebHost::didReceiveIcon):
 609         (WinLauncherWebHost::didFailLoadWithError):
 610         (WinLauncherWebHost::didChangeLocationWithinPageForFrame):
 611         (WinLauncherWebHost::willPerformClientRedirectToURL):
 612         (WinLauncherWebHost::didCancelClientRedirectForFrame):
 613         (WinLauncherWebHost::willCloseFrame):
 614         (WinLauncherWebHost::windowScriptObjectAvailable):
 615         (WinLauncherWebHost::didClearWindowObject):
 616         * WinLauncher/WinMain.cpp: Copied from WinLauncher/WinLauncher.cpp.
 617         (wWinMain):
 618         (MyRegisterClass):
 619         (shouldUseFullDesktop): Deleted.
 620         (SimpleEventListener::SimpleEventListener): Deleted.
 621         (SimpleEventListener::handleEvent): Deleted.
 622         (WinLauncherWebHost::updateAddressBar): Deleted.
 623         (WinLauncherWebHost::didFailProvisionalLoadWithError): Deleted.
 624         (WinLauncherWebHost::QueryInterface): Deleted.
 625         (WinLauncherWebHost::AddRef): Deleted.
 626         (WinLauncherWebHost::Release): Deleted.
 627         (updateMenuItemForHistoryItem): Deleted.
 628         (showLastVisitedSites): Deleted.
 629         (WinLauncherWebHost::didFinishLoadForFrame): Deleted.
 630         (resizeSubViews): Deleted.
 631         (subclassForLayeredWindow): Deleted.
 632         (computeFullDesktopFrame): Deleted.
 633         (DllMain): Deleted.
 634         (getAppDataFolder): Deleted.
 635         (setToDefaultPreferences): Deleted.
 636         (setCacheFolder): Deleted.
 637         (createCrashReport): Deleted.
 638         (AbortProc): Deleted.
 639         (getPrinterDC): Deleted.
 640         (initDocStruct): Deleted.
 641         (PrintView): Deleted.
 642         (ToggleMenuItem): Deleted.
 643         (LaunchInspector): Deleted.
 644         (NavigateForwardOrBackward): Deleted.
 645         (NavigateToHistory): Deleted.
 646         (WndProc): Deleted.
 647         (EditProc): Deleted.
 648         (BackButtonProc): Deleted.
 649         (ForwardButtonProc): Deleted.
 650         (About): Deleted.
 651         (loadURL): Deleted.
 652         (dllLauncherEntryPoint): Deleted.
 653
 654 2014-06-20  Myles C. Maxfield  <mmaxfield@apple.com>
 655
 656         [iOS] getsectdata() is deprecated and we use it in DRT
 657         https://bugs.webkit.org/show_bug.cgi?id=134122
 658
 659         Reviewed by Alexey Proskuryakov.
 660
 661         Migrate to using magic linker symbols.
 662
 663         No tests because there should be no behavior change
 664
 665         * DumpRenderTree/mac/DumpRenderTree.mm:
 666         (activateFontsIOS):
 667
 668 2014-06-24  Javier Fernandez  <jfernandez@igalia.com>
 669
 670         Name moving. Unreviewed.
 671
 672         * Scripts/webkitpy/common/config/contributors.json:
 673
 674 2014-06-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 675
 676         Remove EFL WK1 watch category
 677         https://bugs.webkit.org/show_bug.cgi?id=134231
 678
 679         Reviewed by Csaba Osztrogonác.
 680
 681         * Scripts/webkitpy/common/config/watchlist: Removed EFL WK1 category.
 682
 683 2014-06-24  Krzysztof Czech  <k.czech@samsung.com>
 684
 685         [ATK] Remove some unused code from DumpRenderTree
 686         https://bugs.webkit.org/show_bug.cgi?id=134191
 687
 688         Reviewed by Chris Fleizach.
 689
 690         DumpRenderTree's accessibility code could be removed since GTK and EFL has stopped supporting WK1.
 691
 692         * DumpRenderTree/atk/AccessibilityCallbacks.h: Removed.
 693         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp: Removed.
 694         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp: Removed.
 695         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.cpp: Removed.
 696         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.h: Removed.
 697         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp: Removed.
 698
 699 2014-06-23  Shivakumar JM  <shiva.jm@samsung.com>
 700
 701         [EFL][WK2] Search field is not shown properly on doing ctrl+f on Minibrowser.
 702         https://bugs.webkit.org/show_bug.cgi?id=134025
 703
 704         Reviewed by Gyuyoung Kim.
 705
 706         Use EVAS_HINT_FILL in evas_object_size_hint_align_set() api.
 707
 708         * MiniBrowser/efl/main.c:
 709         (window_create):
 710
 711 2014-06-23  Ryuan Choi  <ryuan.choi@samsung.com>
 712
 713         [EFL] Replace RefPtr<Evas_Object> with UniquePtrEfl
 714         https://bugs.webkit.org/show_bug.cgi?id=134236
 715
 716         Reviewed by Gyuyoung Kim.
 717
 718         * ImageDiff/efl/ImageDiff.cpp:
 719         (calculateDifference):
 720         (printImageDifferences):
 721         (readImageFromStdin):
 722         (main):
 723
 724 2014-06-23  Daniel Bates  <dabates@apple.com>
 725
 726         Rolling out r170340 and r170339.
 727
 728         Changeset r170339 broke the Apple Windows Debug and Release builds.
 729
 730         Reverted changesets:
 731
 732         "[Win] Build fix after r134209"
 733         http://trac.webkit.org/changeset/170340
 734
 735         "[Win] Clean up and refactor WinLauncher"
 736         https://bugs.webkit.org/show_bug.cgi?id=134209
 737         http://trac.webkit.org/changeset/170339
 738
 739 2014-06-23  Brent Fulgham  <bfulgham@apple.com>
 740
 741         [Win] Build fix after r134209
 742
 743         * WinLauncher/WinMain.cpp: Must include the resources file
 744         before Common.cpp.
 745
 746 2014-06-23  Brent Fulgham  <bfulgham@apple.com>
 747
 748         [Win] Clean up and refactor WinLauncher
 749         https://bugs.webkit.org/show_bug.cgi?id=134209
 750
 751         Reviewed by Tim Horton.
 752
 753         Make WinLauncher a class, and move all non-class driver functions
 754         into "Common.cpp" and "WinMain.cpp". These files are distinct
 755         to allow some internal tools to reuse the code in 'Common'.
 756
 757         * WinLauncher/Common.cpp: Added. Consists of code moved from
 758         'WinLauncher.cpp' that can be reused for other tools.
 759         (subclassForLayeredWindow):
 760         (computeFullDesktopFrame):
 761         (DllMain):
 762         (getAppDataFolder):
 763         (setCacheFolder):
 764         (createCrashReport):
 765         (AbortProc):
 766         (getPrinterDC):
 767         (initDocStruct):
 768         (PrintView):
 769         (ToggleMenuItem):
 770         (WndProc):
 771         (EditProc):
 772         (BackButtonProc):
 773         (ForwardButtonProc):
 774         (About):
 775         (loadURL):
 776         (dllLauncherEntryPoint):
 777         * WinLauncher/DOMDefaultImpl.cpp: Copied from WinLauncher/DOMDefaultImpl.h.
 778         (DOMEventListener::Release):
 779         (WebScriptObject::WebScriptObject): Deleted.
 780         (WebScriptObject::~WebScriptObject): Deleted.
 781         (WebScriptObject::throwException): Deleted.
 782         (WebScriptObject::callWebScriptMethod): Deleted.
 783         (WebScriptObject::evaluateWebScript): Deleted.
 784         (WebScriptObject::removeWebScriptKey): Deleted.
 785         (WebScriptObject::stringRepresentation): Deleted.
 786         (WebScriptObject::webScriptValueAtIndex): Deleted.
 787         (WebScriptObject::setWebScriptValueAtIndex): Deleted.
 788         (WebScriptObject::setException): Deleted.
 789         (DOMEventListener::throwException): Deleted.
 790         (DOMEventListener::callWebScriptMethod): Deleted.
 791         (DOMEventListener::evaluateWebScript): Deleted.
 792         (DOMEventListener::removeWebScriptKey): Deleted.
 793         (DOMEventListener::stringRepresentation): Deleted.
 794         (DOMEventListener::webScriptValueAtIndex): Deleted.
 795         (DOMEventListener::setWebScriptValueAtIndex): Deleted.
 796         (DOMEventListener::setException): Deleted.
 797         (DOMEventListener::handleEvent): Deleted.
 798         * WinLauncher/DOMDefaultImpl.h:
 799         (WebScriptObject::QueryInterface): Deleted.
 800         (WebScriptObject::AddRef): Deleted.
 801         (WebScriptObject::Release): Deleted.
 802         (DOMObject::QueryInterface): Deleted.
 803         (DOMEventListener::QueryInterface): Deleted.
 804         (DOMEventListener::AddRef): Deleted.
 805         (DOMEventListener::Release): Deleted.
 806         * WinLauncher/WinLauncher.cpp: Converted stand-alone implementation
 807         into a C++ class and removed WinAPI code.
 808         (WinLauncher::WinLauncher):
 809         (WinLauncher::init):
 810         (WinLauncher::prepareViews):
 811         (WinLauncher::setFrameLoadDelegate):
 812         (WinLauncher::setUIDelegate):
 813         (WinLauncher::setAccessibilityDelegate):
 814         (WinLauncher::mainFrame):
 815         (WinLauncher::seedInitialDefaultPreferences):
 816         (WinLauncher::setToDefaultPreferences):
 817         (updateMenuItemForHistoryItem):
 818         (WinLauncher::showLastVisitedSites):
 819         (WinLauncher::launchInspector):
 820         (WinLauncher::navigateForwardOrBackward):
 821         (WinLauncher::navigateToHistory):
 822         (WinLauncher::goBack):
 823         (WinLauncher::goForward):
 824         (WinLauncher::loadURL):
 825         (shouldUseFullDesktop): Deleted.
 826         (SimpleEventListener::SimpleEventListener): Deleted.
 827         (SimpleEventListener::handleEvent): Deleted.
 828         (WinLauncherWebHost::updateAddressBar): Deleted.
 829         (WinLauncherWebHost::didFailProvisionalLoadWithError): Deleted.
 830         (WinLauncherWebHost::QueryInterface): Deleted.
 831         (WinLauncherWebHost::AddRef): Deleted.
 832         (WinLauncherWebHost::Release): Deleted.
 833         (showLastVisitedSites): Deleted.
 834         (WinLauncherWebHost::didFinishLoadForFrame): Deleted.
 835         (resizeSubViews): Deleted.
 836         (subclassForLayeredWindow): Deleted.
 837         (computeFullDesktopFrame): Deleted.
 838         (DllMain): Deleted.
 839         (getAppDataFolder): Deleted.
 840         (setToDefaultPreferences): Deleted.
 841         (setCacheFolder): Deleted.
 842         (createCrashReport): Deleted.
 843         (wWinMain): Deleted.
 844         (MyRegisterClass): Deleted.
 845         (AbortProc): Deleted.
 846         (getPrinterDC): Deleted.
 847         (initDocStruct): Deleted.
 848         (PrintView): Deleted.
 849         (ToggleMenuItem): Deleted.
 850         (LaunchInspector): Deleted.
 851         (NavigateForwardOrBackward): Deleted.
 852         (NavigateToHistory): Deleted.
 853         (WndProc): Deleted.
 854         (EditProc): Deleted.
 855         (BackButtonProc): Deleted.
 856         (ForwardButtonProc): Deleted.
 857         (About): Deleted.
 858         (loadURL): Deleted.
 859         (dllLauncherEntryPoint): Deleted.
 860         * WinLauncher/WinLauncher.h: Removed.
 861         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
 862         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
 863         * WinLauncher/WinLauncherReplace.h:
 864         (processCrashReport):
 865         * WinLauncher/WinLauncherWebHost.cpp: Added.
 866         (SimpleEventListener::SimpleEventListener):
 867         (SimpleEventListener::handleEvent):
 868         (WinLauncherWebHost::updateAddressBar):
 869         (WinLauncherWebHost::didFailProvisionalLoadWithError):
 870         (WinLauncherWebHost::QueryInterface):
 871         (WinLauncherWebHost::AddRef):
 872         (WinLauncherWebHost::Release):
 873         (WinLauncherWebHost::didFinishLoadForFrame):
 874         * WinLauncher/WinLauncherWebHost.h: Copied from WinLauncher/WinLauncher.h.
 875         Moved WinLauncherWebHost implementation from WinLauncher.cpp into
 876         its own set of files.
 877         (WinLauncherWebHost::WinLauncherWebHost):
 878         (WinLauncherWebHost::didStartProvisionalLoadForFrame):
 879         (WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame):
 880         (WinLauncherWebHost::didCommitLoadForFrame):
 881         (WinLauncherWebHost::didReceiveTitle):
 882         (WinLauncherWebHost::didChangeIcons):
 883         (WinLauncherWebHost::didReceiveIcon):
 884         (WinLauncherWebHost::didFailLoadWithError):
 885         (WinLauncherWebHost::didChangeLocationWithinPageForFrame):
 886         (WinLauncherWebHost::willPerformClientRedirectToURL):
 887         (WinLauncherWebHost::didCancelClientRedirectForFrame):
 888         (WinLauncherWebHost::willCloseFrame):
 889         (WinLauncherWebHost::windowScriptObjectAvailable):
 890         (WinLauncherWebHost::didClearWindowObject):
 891         * WinLauncher/WinMain.cpp: Added. This consists of code from
 892         WinLauncher that is unique to the WinLauncher utility, and is
 893         not part of the WinLauncher class.
 894         (wWinMain):
 895         (MyRegisterClass):
 896
 897 2014-06-23  Simon Fraser  <simon.fraser@apple.com>
 898
 899         Enable the Web Inspector in MiniBrowser
 900         https://bugs.webkit.org/show_bug.cgi?id=134148
 901
 902         Reviewed by Joseph Pecoraro.
 903
 904         Set the pref to enable Web Inspector in both WK1 and WK2 windows.
 905
 906         * MiniBrowser/mac/AppDelegate.m:
 907         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
 908
 909 2014-06-21  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 910
 911         Disable gamepad feature on EFL and GTK ports by default
 912         https://bugs.webkit.org/show_bug.cgi?id=134169
 913
 914         Reviewed by Brady Eidson.
 915
 916         EFL and GTK ports disabled Gamepad feature now. Besides current implementation
 917         was treated to 'deprecated' status.
 918
 919         ENABLE_GAMEPAD_DEPRECATED is disabled for now. There is build break on EFL port.
 920
 921         * Scripts/webkitperl/FeatureList.pm:
 922
 923 2014-06-21  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
 924
 925         [Inspector][EFL] Can't resume a special break point on EFL inspector
 926         https://bugs.webkit.org/show_bug.cgi?id=129294
 927
 928         Reviewed by Gyuyoung Kim.
 929
 930         Patch our EFL 1.9 with the fix landed in upstream EFL 1.10
 931         by Ryuan Choi - <https://phab.enlightenment.org/D790>
 932
 933         * efl/jhbuild.modules:
 934         * efl/patches/ecore.patch: Added.
 935
 936 2014-06-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
 937
 938         Removing PAGE_VISIBILITY_API compile guard.
 939         https://bugs.webkit.org/show_bug.cgi?id=133844
 940
 941         Reviewed by Gavin Barraclough.
 942
 943         * Scripts/webkitperl/FeatureList.pm:
 944
 945 2014-06-20  Ryuan Choi  <ryuan.choi@samsung.com>
 946
 947         [EFL] Remove DumpRenderTree/efl and EWebLauncher
 948         https://bugs.webkit.org/show_bug.cgi?id=134138
 949
 950         Reviewed by Gyuyoung Kim.
 951
 952         DumpRenderTree/efl and EWebLauncher are not necessary anymore because WebKit1 EFL will be removed.
 953
 954         * CMakeLists.txt:
 955         * DumpRenderTree/PlatformEfl.cmake: Removed.
 956         * DumpRenderTree/efl: Removed entire directory.
 957         * EWebLauncher: Ditto.
 958         * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp: Renamed from Tools/DumpRenderTree/efl/FontManagement.cpp.
 959         (buildPath):
 960         (getCoreFontFiles):
 961         (addFontDirectory):
 962         (addFontFiles):
 963         (getCustomBuildDir):
 964         (getPlatformFontsPath):
 965         (addFontsToEnvironment):
 966         * WebKitTestRunner/InjectedBundle/efl/FontManagement.h: Renamed from Tools/DumpRenderTree/efl/FontManagement.h.
 967         * WebKitTestRunner/PlatformEfl.cmake:
 968
 969 2014-06-20  Zalan Bujtas  <zalan@apple.com>
 970
 971         Name moving. Unreviewed.
 972
 973         * Scripts/webkitpy/common/config/contributors.json:
 974
 975 2014-06-20  Javier Fernandez  <jfernandez@igalia.com>
 976
 977         Unreviewed. Adding myself to committers.
 978
 979         * Scripts/webkitpy/common/config/contributors.json:
 980
 981 2014-06-20  Yusuke Suzuki  <utatane.tea@gmail.com>
 982
 983         Unreviewed. Adding myself to committers.
 984
 985         * Scripts/webkitpy/common/config/contributors.json:
 986
 987 2014-06-20  Tim Horton  <timothy_horton@apple.com>
 988
 989         Make WebKit2 more accessible in MiniBrowser
 990         https://bugs.webkit.org/show_bug.cgi?id=134099
 991
 992         Reviewed by Anders Carlsson.
 993
 994         * MiniBrowser/mac/AppDelegate.h:
 995         * MiniBrowser/mac/AppDelegate.m:
 996         (-[BrowserAppDelegate newWindow:]):
 997         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
 998         (-[BrowserAppDelegate toggleUseWebKit2ByDefault:]):
 999         (-[BrowserAppDelegate _useWebKit2ByDefault]):
1000         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
1001         (-[BrowserAppDelegate validateMenuItem:]):
1002         * MiniBrowser/mac/MainMenu.xib:
1003         Add a "Use WebKit2 By Default" menu item to the top of the Debug menu.
1004         When switched on, Cmd-N will make WebKit2 windows (and the default window will be WebKit2).
1005         Make the non-default new-window menu item always show up, because people often don't find it
1006         when you have to press option to have it show up.
1007
1008         * MiniBrowser/mac/BrowserWindowController.h:
1009         * MiniBrowser/mac/BrowserWindowController.m:
1010         (-[BrowserWindowController initWithWindow:]):
1011
1012         * MiniBrowser/mac/WK1BrowserWindowController.m:
1013         (-[WK1BrowserWindowController validateMenuItem:]):
1014         * MiniBrowser/mac/WK2BrowserWindowController.m:
1015         (-[WK2BrowserWindowController validateMenuItem:]):
1016         Use the cached [menuItem action] like the earlier cases do.
1017
1018 2014-06-20  Daniel Bates  <dabates@apple.com>
1019
1020         Teach run-{safari, webkit-app} about iOS Simulator
1021         https://bugs.webkit.org/show_bug.cgi?id=133986
1022
1023         Reviewed by David Kilzer.
1024
1025         Extract the logic from old-run-webkit-tests to install and launch {DumpRenderTree, WebKitTestRunnerApp}.app
1026         into general-purpose routines in webkitdirs.pm so that they can be used both by script old-run-webkit-tests
1027         and run-safari.
1028
1029         * Scripts/old-run-webkit-tests:
1030         (installAndLaunchDumpToolAppUsingNotification): Extracted logic to install and launch {DumpRenderTree,
1031         WebKitTestRunnerApp}.app into webkitdirs::installAndLaunchIOSWebKitAppInSimulator() and modified code
1032         to call it.
1033         (openIPhoneSimulator): Deleted; moved logic to webkitdirs::openIOSSimulator().
1034         (quitIPhoneSimulator): Deleted; moved logic to webkitdirs::quitIOSSimulator().
1035         * Scripts/run-webkit-app: Modified to call runIOSWebKitApp() when the iOS simulator SDK is used
1036         (say, by specifying the optional command-line argument --simulator). For now, die() with an error
1037         when the iOS device SDK is used as we don't support launching an app on the device at this time.
1038         * Scripts/webkitdirs.pm:
1039         (xcodeSDKVersion): Added.
1040         (setupIOSWebKitEnvironment): Added.
1041         (installedMobileSafariBundle): Added.
1042         (mobileSafariBundle): Added.
1043         (plistPathFromBundle): Added.
1044         (appIdentiferFromBundle): Added.
1045         (appDisplayNameFromBundle): Added.
1046         (loadIPhoneSimulatorNotificationIfNeeded): Added.
1047         (openIOSSimulator): Added.
1048         (quitIOSSimulator): Added.
1049         (iosSimulatorDeviceByName): Added.
1050         (iosSimulatorRuntime): Added.
1051         (findOrCreateSimulatorForIOSDevice): Added.
1052         (runIOSWebKitAppInSimulator): Added.
1053         (installAndLaunchIOSWebKitAppInSimulator): Added.
1054         (runIOSWebKitApp): Added.
1055         (runSafari): Modified to call runIOSWebKitAppInSimulator() the iOS simulator SDK is used. For now,
1056         die() with an error when the iOS device SDK is used as we don't support launching Safari on the
1057         device at this time.
1058
1059 2014-06-19  Anders Carlsson  <andersca@apple.com>
1060
1061         Add WTF::Optional class
1062         https://bugs.webkit.org/show_bug.cgi?id=134083
1063
1064         Reviewed by Andreas Kling.
1065
1066         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1067         * TestWebKitAPI/Tests/WTF/Optional.cpp: Added.
1068         (TestWebKitAPI::TEST):
1069
1070 2014-06-20  Ion Rosca  <rosca@adobe.com>
1071
1072         Unreviewed. Adding myself to Committers list.
1073
1074         * Scripts/webkitpy/common/config/contributors.json:
1075
1076 2014-06-20  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1077
1078         [EFL] Add gstreamer as dependecy of EFL after r169785
1079         https://bugs.webkit.org/show_bug.cgi?id=134066
1080
1081         Reviewed by Gyuyoung Kim.
1082
1083         * efl/jhbuild.modules:
1084
1085 2014-06-20  Ryuan Choi  <ryuan.choi@samsung.com>
1086
1087         [EFL] Merge url_utils.c to MiniBrowser
1088         https://bugs.webkit.org/show_bug.cgi?id=134095
1089
1090         Reviewed by Csaba Osztrogonác.
1091
1092         url_utils.c is simple code to share between EWebLauncher and MiniBrowser.
1093         This patch removes the dependency of url_utils.c from MiniBrowser to drop WebKit1 EFL port.
1094
1095         * MiniBrowser/efl/CMakeLists.txt:
1096         Remove the EWebLauncher/ from the includes and url_utils.h from the source lists.
1097         * MiniBrowser/efl/main.c:
1098         (has_scheme): Copied from url_utils.c
1099         (url_from_user_input): Ditto.
1100
1101 2014-06-19  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1102
1103         Fix webkitpy tests after EFL WK1 buildbot and EWS removal - r170172.
1104
1105         Reviewed by Csaba Osztrogonác.
1106
1107         * Scripts/webkitpy/common/config/ports_unittest.py:
1108         (DeprecatedPortTest.test_gtk_wk2_port):
1109         (DeprecatedPortTest.test_efl_port): Deleted.
1110         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1111         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
1112         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1113         (TestRebaselineExpectations.test_rebaseline_expectations):
1114
1115 2014-06-19  Ryuan Choi  <ryuan.choi@samsung.com>
1116
1117         [EFL][CMAKE] Disable WebKit1 build as a default
1118         https://bugs.webkit.org/show_bug.cgi?id=134093
1119
1120         Reviewed by Gyuyoung Kim.
1121
1122         * CMakeLists.txt:
1123
1124 2014-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1125
1126         [GTK] webkit_dom_document_create_tree_walker impossible to use due to WebKitDOMNodeFilter
1127         https://bugs.webkit.org/show_bug.cgi?id=93002
1128
1129         Reviewed by Gustavo Noronha Silva.
1130
1131         Add unit tests to check WebKitDOMNodefilter API used from both
1132         TreeWalker and NodeIterator.
1133
1134         * Scripts/webkitpy/style/checker.py: Add exceptions for GTK+
1135         public headers and add WebKitDOMNodeFilter to the list of exceptions.
1136         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add new files to compilation.
1137         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp: Added.
1138         (webkitNodeFilterAcceptNode):
1139         (webkitNodeFilterDOMNodeFilterIfaceInit):
1140         (webkit_node_filter_init):
1141         (webkit_node_filter_class_init):
1142         (WebKitDOMNodeFilterTest::create):
1143         (WebKitDOMNodeFilterTest::webPageFromArgs):
1144         (WebKitDOMNodeFilterTest::testTreeWalker):
1145         (WebKitDOMNodeFilterTest::testNodeIterator):
1146         (WebKitDOMNodeFilterTest::runTest):
1147         (registerTests):
1148         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp: Added.
1149         (runTest):
1150         (testWebKitDOMNodeFilterTreeWalker):
1151         (testWebKitDOMNodeFilterNodeIterator):
1152         (beforeAll):
1153         (afterAll):
1154         * gtk/webkitdom.py:
1155         (WebKitDOMDocGeneratorSections.__init__):
1156         (WebKitDOMDocGeneratorSections._symbol_list):
1157         (WebKitDOMDocGeneratorSections.write_section):
1158
1159 2014-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1160
1161         [GTK] Limit the amount of API exposed to GObject DOM bindings API
1162         https://bugs.webkit.org/show_bug.cgi?id=133726
1163
1164         Reviewed by Gustavo Noronha Silva.
1165
1166         Don't make fatal finding files without a .symbols file, since now
1167         only the stable DOM API has .symbols files.
1168
1169         * gtk/webkitdom.py:
1170         (get_all_webkitdom_symbol_files):
1171
1172 2014-06-19  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1173
1174         Remove efl wk1 buildbot and ews
1175         https://bugs.webkit.org/show_bug.cgi?id=134089
1176
1177         Reviewed by Benjamin Poulain.
1178
1179         EFL WK1 is not supported anymore. Removed all bots for EFL WK1 bots.
1180
1181         * BuildSlaveSupport/build.webkit.org-config/config.json:
1182         * QueueStatusServer/config/queues.py:
1183         * Scripts/webkitpy/common/config/ews.json:
1184         * Scripts/webkitpy/common/config/ports.py:
1185         (DeprecatedPort.port):
1186         (QtWK2Port.run_webkit_tests_command):
1187         (EflPort): Deleted.
1188         (EflPort.build_webkit_command): Deleted.
1189         * Scripts/webkitpy/port/builders.py:
1190         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1191         * TestResultServer/static-dashboards/loader_unittests.js:
1192
1193 2014-06-19  David Kilzer  <ddkilzer@apple.com>
1194
1195         check-webkit-style does not understand Obj-C literal syntax for NSDictionary
1196         <http://webkit.org/b/134061>
1197
1198         Reviewed by Dan Bernstein.
1199
1200         * Scripts/webkitpy/style/checkers/cpp.py:
1201         (check_spacing): Ignore '@' immediately before '{'.
1202         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1203         (CppStyleTest.test_spacing_before_braces): Add unit test for
1204         '^{' block syntax and '@{' Objective-C liternal NSDitionary
1205         syntax.
1206
1207 2014-06-18  Tim Horton  <timothy_horton@apple.com>
1208
1209         All of MiniBrowser's WKWebViews should share a configuration
1210         https://bugs.webkit.org/show_bug.cgi?id=134017
1211
1212         Reviewed by Anders Carlsson.
1213
1214         * MiniBrowser/mac/WK2BrowserWindowController.m:
1215         (-[WK2BrowserWindowController awakeFromNib]):
1216         Share a single WKWebViewConfiguration between all of MiniBrowser's views.
1217         This means that they'll share things like preferences, visited links, etc.
1218         It also means that we'll properly share processes once we hit the process limit.
1219
1220 2014-06-18  Zan Dobersek  <zdobersek@igalia.com>
1221
1222         [GTK] Bump the GLib and GTK+ dependencies in jhbuild-wayland.modules
1223         https://bugs.webkit.org/show_bug.cgi?id=133971
1224
1225         Reviewed by Martin Robinson.
1226
1227         * gtk/jhbuild-wayland.modules: Bump the GTK+ dependency that's required for
1228         building for the Wayland target. The latest 3.12 version is required to match
1229         the xdg_shell protocol version used in Weston 1.5. GLib dependency is bumped
1230         as well due to GTK+ depending on a newer version.
1231
1232 2014-06-17  Ryuan Choi  <ryuan.choi@samsung.com>
1233
1234         [EFL] Turn on NOSNIFF in FeatureList.pm
1235         https://bugs.webkit.org/show_bug.cgi?id=134010
1236
1237         Reviewed by Csaba Osztrogonác.
1238
1239         r164848 enabled NOSNIFF feature for EFL port but missed to change FeatureList.pm.
1240
1241         * Scripts/webkitperl/FeatureList.pm: Turn on NOSNIFF for the EFL port.
1242
1243 2014-06-17  Tim Horton  <timothy_horton@apple.com>
1244
1245         MiniBrowser should show Web Content process pids in the window title
1246         https://bugs.webkit.org/show_bug.cgi?id=134016
1247
1248         Reviewed by Sam Weinig.
1249
1250         * MiniBrowser/mac/WK2BrowserWindowController.m:
1251         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
1252
1253 2014-06-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1254
1255         [GTK] Fix the handling of resize events after r169505.
1256         https://bugs.webkit.org/show_bug.cgi?id=133517
1257
1258         Reviewed by Martin Robinson.
1259
1260         * Scripts/webkitpy/port/xvfbdriver.py:
1261         (XvfbDriver._start): Set the resolution of Xvfb to XGA (1024x768).
1262         The tests css3/viewport-percentage-lengths/viewport-percentage-lengths-*.html
1263         need at least 900x640 pixels to pass.
1264         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
1265         (XvfbDriverTest.test_start_no_pixel_tests): Update resolution.
1266         (XvfbDriverTest.test_start_pixel_tests): Update resolution.
1267         (XvfbDriverTest.test_start_arbitrary_worker_number): Update resolution.
1268         (XvfbDriverTest.test_start_next_worker): Update resolution.
1269         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1270         (WTR::PlatformWebView::PlatformWebView): gtk_widget_size_allocate should
1271         be requested over the main widget instead of the window.
1272         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame like
1273         the Mac port.
1274         (WTR::PlatformWebView::windowFrame): Remove legacy ifdef for GTK2.
1275         (WTR::PlatformWebView::setWindowFrame): Set the size and position
1276         of the Window and the web view.
1277
1278 2014-06-17  Matthew Mirman <mmirman@apple.com>
1279
1280         Unreviewed. Added myself to list of contributors.
1281
1282         * Scripts/webkitpy/common/config/contributors.json: Added myself.
1283
1284 2014-06-17  Commit Queue  <commit-queue@webkit.org>
1285
1286         Unreviewed, rolling out r170058.
1287         https://bugs.webkit.org/show_bug.cgi?id=133993
1288
1289         Caused 4 webkitpy failures on the bots (Requested by bradee-oh
1290         on #webkit).
1291
1292         Reverted changeset:
1293
1294         "[GTK] Fix the handling of resize events after r169505."
1295         https://bugs.webkit.org/show_bug.cgi?id=133517
1296         http://trac.webkit.org/changeset/170058
1297
1298 2014-06-17  Rebecca Hauck  <rhauck@adobe.com>
1299
1300         Update import-w3c-tests to reflect current W3C test repo directory structure
1301         https://bugs.webkit.org/show_bug.cgi?id=133460
1302
1303         Reviewed by Bem Jones-Bey.
1304
1305         Removed all references to test status, which are no longer reflected in the
1306         directory names in the W3C CSS test repo.  No tests are required for this
1307         change, the existing tests pass.
1308
1309         * Scripts/webkitpy/w3c/test_importer.py:
1310         (main):
1311         (TestImporter.__init__):
1312         (TestImporter.find_importable_tests):
1313         (TestImporter.setup_destination_directory):
1314         (TestImporter.write_import_log):
1315         (TestImporter.update_test_status): Deleted.
1316
1317 2014-06-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1318
1319         [GTK] Fix the handling of resize events after r169505.
1320         https://bugs.webkit.org/show_bug.cgi?id=133517
1321
1322         Reviewed by Martin Robinson.
1323
1324         * Scripts/webkitpy/port/xvfbdriver.py:
1325         (XvfbDriver._start): Set the resolution of Xvfb to XGA (1024x768).
1326         The tests css3/viewport-percentage-lengths/viewport-percentage-lengths-*.html
1327         need at least 900x640 pixels to pass.
1328         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1329         (WTR::PlatformWebView::PlatformWebView): gtk_widget_size_allocate should
1330         be requested over the main widget instead of the window.
1331         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame like
1332         the Mac port.
1333         (WTR::PlatformWebView::windowFrame): Remove legacy ifdef for GTK2.
1334         (WTR::PlatformWebView::setWindowFrame): Set the size and position
1335         of the Window and the web view.
1336
1337 2014-06-17  Dan Bernstein  <mitz@apple.com>
1338
1339         String::isolatedCopy doesn’t return an isolated copy when used on an rvalue reference
1340         https://bugs.webkit.org/show_bug.cgi?id=133968
1341
1342         Reviewed by Anders Carlsson.
1343
1344         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1345         (TestWebKitAPI::TEST): Added a test that an isolated copy of an rvalue reference doesn’t
1346         share an impl() with the original.
1347
1348 2014-06-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1349
1350         [EFL][WK2] Skip failing EFL API tests
1351         https://bugs.webkit.org/show_bug.cgi?id=133981
1352
1353         Reviewed by Csaba Osztrogonác.
1354
1355         UserMessage, WillLoad and test_ewk2_view have been failed since r169784.
1356
1357         * TestWebKitAPI/PlatformEfl.cmake:
1358
1359 2014-06-16  Ryuan Choi  <ryuan.choi@samsung.com>
1360
1361         [EFL][WK2] Remove workaround for icon display bug in MiniBrowser
1362         https://bugs.webkit.org/show_bug.cgi?id=133962
1363
1364         Reviewed by Gyuyoung Kim.
1365
1366         Since we bumped EFL to 1.9, this workaround is unnecessary.
1367
1368         * MiniBrowser/efl/main.c:
1369         (update_view_favicon):
1370
1371 2014-06-16  Gwang Yoon Hwang  <yoon@igalia.com>
1372
1373         [GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
1374         https://bugs.webkit.org/show_bug.cgi?id=131472
1375
1376         Reviewed by Martin Robinson.
1377
1378         This patch reapplies r167510 with fixes to add llvm as a dependency for llvmpipe.
1379
1380         * Scripts/webkitpy/port/xvfbdriver.py:
1381         (XvfbDriver._start): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
1382         when running WebKitTestRunner with the Xvfb driver.
1383         * gtk/install-dependencies: Add LLVM as a dependency to build llvmpipe.
1384         * gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not
1385         installed.
1386         * gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows
1387         how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
1388         calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
1389         deal.
1390
1391 2014-06-16  Tanay C  <tanay.c@samsung.com>
1392
1393         Remove deprecated API warnings in WebKit/Tools/MiniBrowser/efl/main.c
1394         https://bugs.webkit.org/show_bug.cgi?id=133792
1395
1396         Reviewed by Gyuyoung Kim.
1397
1398         * MiniBrowser/efl/main.c: replaced the deprecated API's with the latest ones
1399         (show_file_entry_dialog):
1400         (window_create):
1401
1402 2014-06-16  Mario Sanchez Prada  <mario.prada@samsung.com>
1403
1404         [ATK] Missing 'selection-changed' signal when navigating a combo box with keyboard
1405         https://bugs.webkit.org/show_bug.cgi?id=133512
1406
1407         Reviewed by Chris Fleizach.
1408
1409         Added support for connecting to AtkSelection's 'selection-changed'
1410         signal, and print it out as AXSelectedChildrenChanged in the tests.
1411
1412         Also removed some dead code, that became useless after r169487.
1413
1414         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1415         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Updated.
1416
1417 2014-06-15  Ryuan Choi  <ryuan.choi@samsung.com>
1418
1419         [EFL][WK2] Change ewk_view_settings_get to ewk_page_group_settings_get
1420         https://bugs.webkit.org/show_bug.cgi?id=133841
1421
1422         Reviewed by Gyuyoung Kim.
1423
1424         * MiniBrowser/efl/main.c:
1425         (window_create):
1426
1427 2014-06-15  Dan Bernstein  <mitz@apple.com>
1428
1429         Set the svn:ignore property on an Xcode project to ignore user and workspace data.
1430
1431         * jsc-cli/jsc-cli.xcodeproj: Added property svn:ignore.
1432
1433 2014-06-15  Anders Carlsson  <andersca@apple.com>
1434
1435         Fix build.
1436
1437         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
1438         (callRunJavaScriptBlockAndRelease):
1439         (runJavaScriptInMainFrame):
1440         (TEST_F):
1441
1442 2014-06-13  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1443
1444         Create MSE and EME watchlist
1445         https://bugs.webkit.org/show_bug.cgi?id=133810
1446
1447         Reviewed by Eric Carlson.
1448
1449         * Scripts/webkitpy/common/config/watchlist: Create MSEEME
1450         definition and add Eric Carlson and myself to it.
1451
1452 2014-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1453
1454         [GTK] Remove all deprecated API from GObject DOM bindings
1455         https://bugs.webkit.org/show_bug.cgi?id=133728
1456
1457         Reviewed by Martin Robinson.
1458
1459         * gtk/webkitdom.py:
1460         (WebKitDOMDocGenerator): Remove all deleted classes from the list.
1461         (WebKitDOMDocGeneratorSections.__init__): Fix a typo in member initialization.
1462
1463 2014-06-12  Simon Fraser  <simon.fraser@apple.com>
1464
1465         [iOS] Fix the view being half offscreen in WebKitTestRunner on iOS
1466         https://bugs.webkit.org/show_bug.cgi?id=133835
1467
1468         Reviewed by Tim Horton.
1469
1470         Don't do the _fakeOrigin stuff when -initWithFrame: is calling -setFrame:
1471
1472         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1473         (-[WebKitTestRunnerWindow initWithFrame:]):
1474         (-[WebKitTestRunnerWindow setFrame:]):
1475
1476 2014-06-12  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1477
1478         [GTK] Performance tests should be always ran with WKTR.
1479         https://bugs.webkit.org/show_bug.cgi?id=133780
1480
1481         Reviewed by Ryosuke Niwa.
1482
1483         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1484         (PerfTestsRunner.__init__): Enable webkit_test_runner when port
1485         is GTK.
1486
1487 2014-06-12  Sergio Villar Senin  <svillar@igalia.com>
1488
1489         [GTK] REGRESSION: application name is not correctly appended to the UA
1490         https://bugs.webkit.org/show_bug.cgi?id=133793
1491
1492         Reviewed by Carlos Garcia Campos.
1493
1494         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1495         (testWebKitSettingsUserAgent):
1496
1497 2014-06-12  Sergio Villar Senin  <svillar@igalia.com>
1498
1499         [GTK] Unsupported browser in www.icloud.com
1500         https://bugs.webkit.org/show_bug.cgi?id=133403
1501
1502         Reviewed by Martin Robinson.
1503
1504         * TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp:
1505         (TestWebKitAPI::TEST): removed a test for the NeedsSafariVersion6
1506         quirk that was removed.
1507
1508 2014-06-11  Simon Fraser  <simon.fraser@apple.com>
1509
1510         [iOS WK2] Give WebKitTestRunner a viewport configuration with initial scale=1 for testing
1511         https://bugs.webkit.org/show_bug.cgi?id=133779
1512
1513         Reviewed by Benjamin Poulain.
1514
1515         Tell the WebPage to use the testing viewport configuration from the injected bundle.
1516
1517         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1518         (WTR::InjectedBundle::didReceiveMessage): Code cleanup.
1519         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1520         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Call WKBundlePageSetUseTestingViewportConfiguration()
1521         on iOS.
1522
1523 2014-06-11  Simon Fraser  <simon.fraser@apple.com>
1524
1525         WTR cleanup: push per-test viewport configuration into TestController, where platforms can customize it
1526         https://bugs.webkit.org/show_bug.cgi?id=133770
1527
1528         Reviewed by Anders Carlsson.
1529
1530         Push the per-test view configuration up to TestController, so that platforms
1531         can modify the behavior. This also allows platform-specific changes (e.g.
1532         for threaded scrolling) to made without #ifefs.
1533
1534         * WebKitTestRunner/TestController.cpp:
1535         (WTR::TestController::updateWebViewSizeForTest):
1536         (WTR::TestController::updateWindowScaleForTest):
1537         (WTR::shouldUseFixedLayout):
1538         (WTR::TestController::updateLayoutTypeForTest):
1539         (WTR::TestController::platformConfigureViewForTest):
1540         (WTR::TestController::configureViewForTest):
1541         * WebKitTestRunner/TestController.h:
1542         * WebKitTestRunner/TestInvocation.cpp:
1543         (WTR::TestInvocation::invoke):
1544         (WTR::sizeWebViewForCurrentTest): Deleted.
1545         (WTR::changeWindowScaleIfNeeded): Deleted.
1546         (WTR::shouldUseThreadedScrolling): Deleted.
1547         (WTR::updateThreadedScrollingForCurrentTest): Deleted.
1548         (WTR::shouldUseFixedLayout): Deleted.
1549         (WTR::updateLayoutType): Deleted.
1550         * WebKitTestRunner/TestInvocation.h:
1551         (WTR::TestInvocation::pathOrURL):
1552         * WebKitTestRunner/ios/TestControllerIOS.mm:
1553         (WTR::shouldMakeViewportFlexible):
1554         (WTR::TestController::platformConfigureViewForTest):
1555         * WebKitTestRunner/mac/TestControllerMac.mm:
1556         (WTR::shouldUseThreadedScrolling):
1557         (WTR::TestController::platformConfigureViewForTest):
1558
1559 2014-06-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1560
1561         [EFL] Add dependencies packages to efl install-dependencies file
1562         https://bugs.webkit.org/show_bug.cgi?id=133720
1563
1564         Reviewed by Csaba Osztrogonác.
1565
1566         After r169785, EFL port starts to use efl 1.9 ver. EFL port needs to
1567         install doxygen and libssl-dev because efl 1.9 depends on those libraries.
1568
1569         * efl/install-dependencies:
1570
1571 2014-06-11  Zoltan Horvath  <zoltan@webkit.org>
1572
1573         Unreviewed. Moving myself to the list of reviewers.
1574
1575         * Scripts/webkitpy/common/config/contributors.json:
1576
1577 2014-06-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1578
1579         [EFL] Drop to maintain EFL 32bit release bot
1580         https://bugs.webkit.org/show_bug.cgi?id=133710
1581
1582         Reviewed by Csaba Osztrogonác.
1583
1584         * BuildSlaveSupport/build.webkit.org-config/config.json: Removed EFL 32bit bot.
1585
1586 2014-06-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1587
1588         [GTK] Use a different user agent string depending on the site
1589         https://bugs.webkit.org/show_bug.cgi?id=132681
1590
1591         Reviewed by Anders Carlsson.
1592
1593         Add a unit test to check user agent quirks.
1594
1595         * TestWebKitAPI/PlatformGTK.cmake:
1596         * TestWebKitAPI/Tests/WebCore/gtk/UserAgentQuirks.cpp: Added.
1597         (TestWebKitAPI::TEST):
1598         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1599         (testWebKitSettings): Site specific quirks setting is now enabled
1600         by default.
1601
1602 2014-06-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1603
1604         Unreviewed, update my list of email addresses in contributors.json.
1605
1606         * Scripts/webkitpy/common/config/contributors.json:
1607
1608 2014-06-10  Simon Fraser  <simon.fraser@apple.com>
1609
1610         Always switch to an sRGB screen color profile when running tests
1611         https://bugs.webkit.org/show_bug.cgi?id=133712
1612
1613         Reviewed by Tim Horton.
1614
1615         Switch the screen color profile to sRGB when running tests, because even ref
1616         tests need the screen to use the correct color profile.
1617
1618         * DumpRenderTree/mac/LayoutTestHelper.m:
1619         (installLayoutTestColorProfile):
1620         * Scripts/webkitpy/port/mac.py:
1621         (MacPort.start_helper):
1622
1623 2014-06-10  Martin Hodovan  <mhodovan@partner.samsung.com>
1624
1625         [EFL] Bump EFL libraries to 1.9
1626         https://bugs.webkit.org/show_bug.cgi?id=125479
1627
1628         Reviewed by Gyuyoung Kim.
1629
1630         Based on the work of Ryuan Choi <ryuan.choi@samsung.com>
1631         and László Langó <llango.u-szeged@partner.samsung.com>.
1632
1633         * ImageDiff/CMakeLists.txt:
1634         * MiniBrowser/efl/CMakeLists.txt:
1635         * efl/install-dependencies:
1636         * efl/jhbuild.modules:
1637         * efl/jhbuildrc:
1638
1639 2014-06-10  David Farler  <dfarler@apple.com>
1640
1641         old-run-webkit-tests: Create CoreSimulator device on demand and find it by name
1642         https://bugs.webkit.org/show_bug.cgi?id=133663
1643
1644         Reviewed by David Kilzer.
1645
1646         * Scripts/old-run-webkit-tests:
1647         (installAndLaunchDumpToolAppUsingNotification):
1648         - Remove obsolete notification keys
1649         - Key off of mandatory device UDID (a UUID)
1650         - Create a device on demand via CoreSimulator if necessary
1651         -- Grab the UDID from the created device plist.
1652         * Scripts/webkitdirs.pm:
1653         (iOSSimulatorDevicesPath): Added
1654         (iOSSimulatorDevices): Added
1655         (createiOSSimulatorDevice): Added
1656         (deleteiOSSimulatorDevice): Added
1657
1658 2014-06-10  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
1659
1660         [GTK][gtkdoc] remove -Wcast-align
1661         https://bugs.webkit.org/show_bug.cgi?id=133640
1662
1663         Apparently gcc warns that GParamSpec is not castable to
1664         GParamSpecInt64/GParamSpecUInt64/GParamSpecDouble due they are 64bit, even
1665         though ARM hackers claim that those only need 4byte alignment. As long as gcc
1666         behaves that way, this warning is not very useful, also they break the Debian
1667         packaging.
1668
1669         This patch appends the compiler flag -Wno-align-cast for the gtkdoc
1670         scanner compilation, thus the compiler ignores the previous
1671         -Waling-cast flag.
1672
1673         Reviewed by Martin Robinson.
1674
1675         * gtk/generate-gtkdoc:
1676         (get_generator_for_config):
1677
1678 2014-06-09  Alexey Proskuryakov  <ap@apple.com>
1679
1680         Disable button animations in regression tests
1681         https://bugs.webkit.org/show_bug.cgi?id=133647
1682         <rdar://problem/16677530>
1683
1684         Reviewed by Tim Horton.
1685
1686         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1687         (WTR::InjectedBundle::platformInitialize):
1688
1689 2014-06-09  Simon Fraser  <simon.fraser@apple.com>
1690
1691         Move scrolling-related tests to tiled-drawing/scrolling subdirectory, and minor cleanup
1692         https://bugs.webkit.org/show_bug.cgi?id=133650
1693
1694         Reviewed by Tim Horton.
1695
1696         No point checking for a Windows-style path in Cocoa code.
1697
1698         * WebKitTestRunner/TestInvocation.cpp:
1699         (WTR::shouldUseThreadedScrolling):
1700
1701 2014-06-09  Simon Fraser  <simon.fraser@apple.com>
1702
1703         Fix more latched scrolling test flakiness and slowness
1704         https://bugs.webkit.org/show_bug.cgi?id=133601
1705
1706         Reviewed by Brent Fulgham.
1707
1708         Latched scrolling tests were flakey for two reasons. First, the EventSender
1709         wheel events were async from the web to the UI process, and the resulting
1710         synthetic events also async from the UI to the web process. Make them sync
1711         for testing.
1712
1713         Secondly, the timer-based scrolling tree commit could result in the scrolling
1714         tree (specifically the frame node's notion of the scrollable area and content
1715         size) not being updated before the scrolling thread starts getting wheel events.
1716         Fix by having WebPage::wheelEventSyncForTesting() commit if necessary.
1717
1718         Finally remove all the now-unnecessary timeouts from the tests.
1719
1720         * WebKitTestRunner/mac/EventSenderProxy.mm:
1721         (WTR::EventSenderProxy::mouseMoveTo):
1722         (WTR::EventSenderProxy::mouseScrollBy):
1723         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
1724
1725 2014-06-09  Andrzej Badowski  <a.badowski@samsung.com>
1726
1727         [EFL] Add parameter to MiniBrowser to disable web security
1728         https://bugs.webkit.org/show_bug.cgi?id=121095
1729
1730         Reviewed by Gyuyoung Kim.
1731
1732         -w (--web-security) commandline allows to disable/enable web security (enabled by default).
1733         The reason for this is to test and debug (using, for example, MiniBrowser) scripts accessing
1734         resources from other domains (cross-domain requests) such as access map location on another server.
1735         Another possibility is to launch in a webkit browser local file tests that will refer to the links
1736         in the http website loaded in an iframe. It will not be possible without deactivation of web security.
1737
1738         * MiniBrowser/efl/main.c:
1739         (window_create):
1740         (elm_main):
1741
1742 2014-06-06  Simon Fraser  <simon.fraser@apple.com>
1743
1744         32-bit build fix.
1745
1746         * WebKitTestRunner/mac/EventSenderProxy.mm:
1747         (WTR::EventSenderProxy::mouseMoveTo):
1748         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
1749
1750 2014-06-06  Simon Fraser  <simon.fraser@apple.com>
1751
1752         Fix builds on 10.8; -firstObject isn't declared on NSArray there.
1753
1754         * DumpRenderTree/mac/DumpRenderTree.mm:
1755         (createWebViewAndOffscreenWindow):
1756         * DumpRenderTree/mac/EventSendingController.mm:
1757         (-[EventSendingController mouseScrollByX:andY:continuously:]):
1758         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
1759         * WebKitTestRunner/mac/EventSenderProxy.mm:
1760         (WTR::EventSenderProxy::mouseScrollBy):
1761         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
1762
1763 2014-06-06  Simon Fraser  <simon.fraser@apple.com>
1764
1765         Latched scrolling tests are flakey on Mavericks
1766         https://bugs.webkit.org/show_bug.cgi?id=133578
1767         <rdar://problem/17180591>
1768
1769         Reviewed by Brent Fulgham.
1770
1771         The latched scrolling tests rely on synthetic mousewheel events whose coordinates can
1772         be wrong on machines with more than one screen. This is because we use
1773         [NSScreen mainScreen] when computing the global coordinates of the events, but
1774         [NSScreen mainScreen] returns the screen with the key window, not the first screen.
1775
1776         So replace calls to [NSScreen mainScreen] with [[NSScreen screens] firstObject]. Also
1777         add comments clarifying why the coordinate math works (which is not obvious given
1778         the events have no target window).
1779
1780         Some scrolling tests also dispatched events outside the 800x600 test window, so
1781         fix those tests, and add logging that will appear in test output when this happens.
1782
1783         * DumpRenderTree/mac/DumpRenderTree.mm:
1784         (createWebViewAndOffscreenWindow):
1785         * DumpRenderTree/mac/EventSendingController.mm:
1786         (-[EventSendingController mouseScrollByX:andY:continuously:]):
1787         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
1788         * WebKitTestRunner/mac/EventSenderProxy.mm:
1789         (WTR::EventSenderProxy::mouseMoveTo):
1790         (WTR::EventSenderProxy::mouseScrollBy):
1791         (WTR::EventSenderProxy::continuousMouseScrollBy):
1792         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
1793
1794 2014-06-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1795
1796         [GTK] run-perf-tests should run the tests inside the jhbuild shell.
1797         https://bugs.webkit.org/show_bug.cgi?id=133533
1798
1799         Reviewed by Carlos Garcia Campos.
1800
1801         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
1802         (run): Remove the jhbuild-wrapper wrapper from here. It should be
1803         on Scripts/webkitpy/port/gtk.py.
1804         * Scripts/webkitpy/port/base.py:
1805         (Port.set_option): Add a set_option(name, value) function to set
1806         the optparse parameter "name" to the value "value", even if the
1807         parameter "name" is already initialized.
1808         * Scripts/webkitpy/port/gtk.py:
1809         (GtkPort.__init__): Set the default wrapper to jhbuild-wrapper.
1810         If another wrapper is specified via the option "-l --wrapper=x",
1811         then prepend the jhbuild-wrapper to the one specified.
1812
1813 2014-06-04  David Farler  <dfarler@apple.com>
1814
1815         Build ASan WebKit for iOS Simulator
1816         https://bugs.webkit.org/show_bug.cgi?id=133489
1817
1818         Reviewed by Darin Adler.
1819
1820         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1821         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1822         - Add missing ASan LDFLAGS.
1823         * asan/asan.xcconfig:
1824         - Split compiler-rt linker flags for OS X and iOS Simulator
1825
1826 2014-06-03  Yoav Weiss  <yoav@yoav.ws>
1827
1828         Add myself (yoav@yoav.ws) to contributors.json
1829         https://bugs.webkit.org/show_bug.cgi?id=133492
1830
1831         * Scripts/webkitpy/common/config/contributors.json:
1832
1833 2014-06-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1834
1835         REGRESSION(r169092 and r169102): Skip failing JSC tests poperly on non-x86 Darwin platforms
1836         https://bugs.webkit.org/show_bug.cgi?id=133149
1837
1838         Reviewed by Csaba Osztrogonác.
1839
1840         * Scripts/run-jsc-stress-tests: Added determineOS to determine the host operating system the script run on.
1841
1842 2014-06-02  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1843
1844         Add a verbose flag to binding tests
1845         https://bugs.webkit.org/show_bug.cgi?id=122303
1846
1847         Reviewed by Csaba Osztrogonác.
1848
1849         This patch will:
1850         - Add a verbose keyword argument to the BindingsTests constructor,
1851         - Add --no-verbose option to the run-bindigs-test.
1852         Verbose mode, which is on by default, prints positive results to stdout as before.
1853         When the --no-verbose option added to run-bindings-tests, positive results are not printed at all.
1854
1855         Original patch from Matthew Hanson <matthew_hanson@apple.com>
1856
1857         * Scripts/run-bindings-tests:
1858         (main):
1859         * Scripts/webkitpy/bindings/main.py:
1860         (BindingsTests.__init__):
1861         (BindingsTests.detect_changes):
1862
1863 2014-06-01  Ryosuke Niwa  <rniwa@webkit.org>
1864
1865         Rename DoYouEvenBench 0.17 to Speedometer 1.0 and add a new look.
1866         https://bugs.webkit.org/show_bug.cgi?id=133455
1867
1868         Reviewed by Timothy Hatcher.
1869
1870         Since the perf. dashboard doesn't support following renamed benchmarks,
1871         keep reporting Speedometer results as DoYouEvenBench results.
1872
1873         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1874         (_generate_results_dict):
1875
1876 2014-05-31  Darin Adler  <darin@apple.com>
1877
1878         Viewport percentage tests that resize the viewport are flaky
1879         https://bugs.webkit.org/show_bug.cgi?id=133351
1880
1881         Reviewed by Anders Carlsson.
1882
1883         * DumpRenderTree/mac/DumpRenderTree.mm:
1884         (sizeWebViewForCurrentTest): Added a call to reset the window origin, which
1885         happens to be stored in the UI delegate object. This is part of resetting the
1886         window position.
1887
1888         * DumpRenderTree/mac/UIDelegate.h: Store the window origin rather than storing
1889         a frame rectangle. The size is stored in the size of the web view itself.
1890         * DumpRenderTree/mac/UIDelegate.mm:
1891         (-[UIDelegate resetWindowOrigin]): Added.
1892         (-[UIDelegate webView:setFrame:]): Changed to set the size of the web view. The
1893         old version would store the frame, but not resize the web view!
1894         (-[UIDelegate webViewFrame:]): Get the size from the web view.
1895
1896         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1897         (WTR::PlatformWebView::setWindowFrame): Added code to resize the web view.
1898
1899         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1900         (WTR::PlatformWebView::resizeTo): Added a comment about missing code to resize
1901         the window.
1902
1903         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1904         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame so the
1905         window gets resized too, not just the web view.
1906         (WTR::PlatformWebView::setWindowFrame): Added code to set the size of the web view.
1907
1908         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1909         (WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame so the
1910         window gets resized too, not just the web view.
1911         (WTR::PlatformWebView::setWindowFrame): Added code to set the size of the web view.
1912
1913 2014-05-30  Michael Saboff  <msaboff@apple.com>
1914
1915         Change run-jsc-stress-tests to not resolve jsc path locally when creating a bundle
1916         https://bugs.webkit.org/show_bug.cgi?id=133409
1917
1918         Reviewed by Filip Pizlo.
1919
1920         Handle creating a tarball the same way as running remote when processing
1921         paths in prepareBundle.
1922
1923         * Scripts/run-jsc-stress-tests:
1924
1925 2014-05-30  Mario Sanchez Prada  <mario.prada@samsung.com>
1926
1927         [ATK] Deprecate usage of logAccessibilityEvents() in layout tests
1928         https://bugs.webkit.org/show_bug.cgi?id=132280
1929
1930         Reviewed by Chris Fleizach.
1931
1932         Remove implementation of logAccessibilityEvents() for ATK based
1933         ports, as this has proved to be a flaky method of checking that
1934         ATK events are being properly emitted. Instead, it's better to use
1935         the addNotificationListener() functions and provide a JS callback
1936         to check that the right events are being emmitted from the tests.
1937
1938         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1939         (WTR::AccessibilityController::logAccessibilityEvents): Replaced
1940         with dummy implementation.
1941         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1942         (WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Removed
1943
1944 2014-05-30  Mario Sanchez Prada  <mario.prada@samsung.com>
1945
1946         [ATK] Deprecate usage of logAccessibilityEvents() in layout tests
1947         https://bugs.webkit.org/show_bug.cgi?id=132280
1948
1949         Rubber stamped by Carlos Garcia Campos.
1950
1951         Fix two small issues with previous patch (r169483), that caused some tests to break.
1952
1953         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1954         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Removed
1955         duplicated entry.
1956         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1957         (WTR::AccessibilityUIElement::setSelectedTextRange): Fix boolean condition.
1958
1959 2014-05-30  Jarek Czekalski  <jarekczek@poczta.onet.pl>
1960
1961         [ATK] Added new accessibility signal: text-caret-moved.
1962         Make AccessibilityUIElement.setSelectedTextRange work
1963         as atk_text_set_caret_offset when given offset == 0.
1964         https://bugs.webkit.org/show_bug.cgi?id=132527
1965
1966         Reviewed by Mario Sanchez Prada.
1967
1968         text-caret-moved signal in accessibilityController is needed to
1969         implement tests from Tools/TestWebKitAPI/Tests/WebKitGtk/testatk.c
1970         as LayoutTests. Add the signal to the controller.
1971
1972         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1973         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1974         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1975         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1976         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1977         (setSelectedTextRange): Change return type to bool.
1978         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1979         (setSelectedTextRange): Call atk_text_set_caret_offset and return bool.
1980         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1981         (axObjectEventListener): Add notification name AXTextCaretMoved, allow
1982         for extra arguments passed to handler and use it for text-caret-moved offset.
1983         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
1984         Connect callback to new listener for ATK:AtkText:text-caret-moved.
1985         Refactor so that failures be reported.
1986         Initialize atk interfaces before trying to connect to them, see
1987         https://bugzilla.gnome.org/show_bug.cgi?id=729922
1988         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
1989         Simplify code by using a vector in place of dozen variables.
1990         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
1991         Comment about not synchronizing with accessibilityController.
1992
1993 2014-05-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1994
1995         [GTK] Add a WebKit2 Performance bot.
1996         https://bugs.webkit.org/show_bug.cgi?id=132862
1997
1998         Reviewed by Csaba Osztrogonác.
1999
2000         This adds a GTK WebKit2 perf bot.
2001
2002         * BuildSlaveSupport/build.webkit.org-config/config.json:
2003
2004 2014-05-29  Dan Bernstein  <mitz@apple.com>
2005
2006         Fixed the WebKitTestRunner build after r169452.
2007
2008         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2009         (WTR::InjectedBundle::initialize):
2010
2011 2014-05-28  Gwang Yoon Hwang  <yoon@igalia.com>
2012
2013         Unreviewed. Update my email addresses in contributors.json.
2014
2015         * Scripts/webkitpy/common/config/contributors.json:
2016
2017 2014-05-27  Jon Honeycutt  <jhoneycutt@apple.com>
2018
2019         Need an API test for bug #133193 (r169315)
2020         <https://bugs.webkit.org/show_bug.cgi?id=133324>
2021
2022         This adds an API test that ensures that calling "stop loading" during a
2023         "did fail provisional load" callback doesn't crash.
2024
2025         Reviewed by Andy Estes.
2026
2027         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2028         Add new files to project.
2029
2030         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp: Added.
2031         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2032         If the message is the "test done" message, record that.
2033         (TestWebKitAPI::setInjectedBundleClient):
2034         Register a function for the "did receive message from injected bundle"
2035         callback.
2036         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
2037         Assert that we received the message from the injected bundle, and set
2038         'done' to finish the test.
2039         (TestWebKitAPI::TEST):
2040         Create a WebView, register a page loader client for the "did fail
2041         provisional load" callback, and load a non-existent resource.
2042
2043         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp: Added.
2044         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::StopLoadingDuringDidFailProvisionalLoadTest):
2045         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrameCallback):
2046         Tell the StopLoadingDuringDidFailProvisionalLoadTest object that the
2047         provisional load failed.
2048         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::didCreatePage):
2049         Register a page loader client for the "did fail provisional load"
2050         callback.
2051         (TestWebKitAPI::StopLoadingDuringDidFailProvisionalLoadTest::didFailProvisionalLoad):
2052         Call WKBundlePageStopLoading() during the callback. This not crashing
2053         is what we're ensuring with this test.
2054
2055 2014-05-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2056
2057         [GTK] Make it possible to build with FTL enabled
2058         https://bugs.webkit.org/show_bug.cgi?id=133219
2059
2060         Reviewed by Philippe Normand.
2061
2062         * gtk/jhbuild-optional.modules: Add llvm from svn and build the
2063         same revision than mac.
2064
2065 2014-05-27  Michael Saboff  <msaboff@apple.com>
2066
2067         REGRESSION(r169265): sh: line 0: cd: ../.vm
2068         https://bugs.webkit.org/show_bug.cgi?id=133242
2069
2070         Rubber stamped by Oliver Hunt.
2071
2072         Changed runAndMonitorTestRunnerCommand() to pass mysys as a string instead of an
2073         array since the command may contain character escapes that don't work with the
2074         array form of system().
2075
2076         * Scripts/run-jsc-stress-tests:
2077
2078 2014-05-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2079
2080         [EFL] Change download url of freetype6
2081         https://bugs.webkit.org/show_bug.cgi?id=133303
2082
2083         Reviewed by Csaba Osztrogonác.
2084
2085         freetype6 tarball isn't downloaded in Korea. So, we need to
2086         change the url for now.
2087
2088         * efl/jhbuild.modules:
2089
2090 2014-05-27  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2091
2092         Remove BLOB guards
2093         https://bugs.webkit.org/show_bug.cgi?id=132863
2094
2095         Reviewed by Csaba Osztrogonác.
2096
2097         * Scripts/webkitperl/FeatureList.pm:
2098
2099 2014-05-27  Alberto Garcia  <berto@igalia.com>
2100
2101         Remove leftover comment from r165182.
2102
2103         Rubber stamped by Carlos Garcia Campos.
2104
2105         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
2106
2107 2014-05-26  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2108
2109         [EFL] Add LLVM as optional jhbuild module for FTL developers
2110         https://bugs.webkit.org/show_bug.cgi?id=133216
2111
2112         Reviewed by Gyuyoung Kim.
2113
2114         * efl/jhbuild.modules:
2115
2116 2014-05-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2117
2118         Fix test failures on python test
2119         https://bugs.webkit.org/show_bug.cgi?id=133297
2120
2121         Reviewed by Dirk Schulze.
2122
2123         2 tests are failing because of unbounded local variable reference in test_importer.py.
2124
2125         * Scripts/webkitpy/w3c/test_importer.py: Move local variable declaration to top.
2126         (TestImporter.import_tests):
2127
2128 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2129
2130         [GTK] GObject DOM bindings API break test fails in the tests bots
2131         https://bugs.webkit.org/show_bug.cgi?id=133211
2132
2133         Reviewed by Martin Robinson.
2134
2135         When generating the built product archive on platform GTK, we need
2136         to copy also the file gtkdoc-webkitdom.cfg and the directory
2137         DerivedSources/webkitdom.
2138
2139         * BuildSlaveSupport/built-product-archive:
2140         (archiveBuiltProduct):
2141
2142 2014-05-26  Commit Queue  <commit-queue@webkit.org>
2143
2144         Unreviewed, rolling out r169122.
2145         https://bugs.webkit.org/show_bug.cgi?id=133288
2146
2147         Broke CJK font fallback (Requested by ap on #webkit).
2148
2149         Reverted changeset:
2150
2151         "[Mac] WebProcess doesn't follow localization of UI process
2152         when run as a service"
2153         https://bugs.webkit.org/show_bug.cgi?id=133126
2154         http://trac.webkit.org/changeset/169122
2155
2156 2014-05-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2157
2158         [GTK] WebProcess leaked when closing pages with network process enabled
2159         https://bugs.webkit.org/show_bug.cgi?id=129684
2160
2161         Reviewed by Anders Carlsson.
2162
2163         Enable the test to check that web processes finish when the web
2164         view is destroyed.
2165
2166         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
2167
2168 2014-05-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2169
2170         REGRESSION(r164632): [GTK] Crash in generate-gtkdoc when rebasing docs
2171         https://bugs.webkit.org/show_bug.cgi?id=133279
2172
2173         Reviewed by Philippe Normand.
2174
2175         generator.saw_warnings is only set by GTKDoc::generate(), so it
2176         should only be used after generate.
2177
2178         * gtk/generate-gtkdoc:
2179         (generate_documentation_for_config): Do not check
2180         generator.saw_warnings again, simply return the value returned by
2181         generate_doc() which is generator.saw_warnings. When rebasing,
2182         returns always False since there aren't warnings.
2183
2184 2014-05-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2185
2186         W3C test importer should catch exceptions coming from HTML/CSS conversion
2187         https://bugs.webkit.org/show_bug.cgi?id=133176
2188
2189         Reviewed by Darin Adler.
2190
2191         Exceptions raised when converting HTML/CSS are caught.
2192         Files for which conversion failed are still copied to the target directory.
2193         Each individual conversion failure is logged.
2194         Total conversion failure number is logged at the end of the import process.
2195
2196         * Scripts/webkitpy/w3c/test_importer.py:
2197         (TestImporter.import_tests):
2198
2199 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2200
2201         [GTK] Allow to run the tests on the native X display.
2202         https://bugs.webkit.org/show_bug.cgi?id=133157
2203
2204         Reviewed by Benjamin Poulain.
2205
2206         This adds a new driver (xorgdriver) that runs the tests on the
2207         X display referenced by the environment variable DISPLAY.
2208
2209         This new driver will be activated only if the environment variable
2210         USE_NATIVE_XDISPLAY is defined. This can be used both for layout
2211         tests and performance tests.
2212
2213         This patch also makes the script run-perf-tests to check the
2214         system dependencies before starting the tests. Previously this
2215         was not checked, and if the system dependencies were not met,
2216         the script tried to execute the tests anyway, causing massive
2217         failures. For example, if you had Xvfb not installed and you
2218         wanted to use the Xvfb driver (the default on GTK and EFL),
2219         run-perf-tests would not abort.
2220
2221         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2222         (PerfTestsRunner._parse_args): Check the system dependencies of
2223         the driver before starting the tests.
2224         * Scripts/webkitpy/port/driver.py:
2225         (Driver): Implement generic check_driver method.
2226         (Driver.check_driver):
2227         (Driver.check_driver.implementation):
2228         * Scripts/webkitpy/port/gtk.py:
2229         (GtkPort._driver_class): Check for environment variable
2230         USE_NATIVE_XDISPLAY to decide if the Xorg driver should be used.
2231         * Scripts/webkitpy/port/xorgdriver.py: Added.
2232         (XorgDriver): Implement Xorg driver.
2233         (XorgDriver.check_driver):
2234         (XorgDriver._start):
2235
2236 2014-05-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2237
2238         REGRESSION(r166798): [GTK] [EFL] kill-old-processes should not kill dbus-daemon
2239         https://bugs.webkit.org/show_bug.cgi?id=133215
2240
2241         Reviewed by Csaba Osztrogonác.
2242
2243         This reverts r166798.
2244
2245         * BuildSlaveSupport/kill-old-processes:
2246         (main):
2247
2248 2014-05-26  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
2249
2250         [EFL] Turn on ENABLE_CSS_FILTERS in build script
2251         https://bugs.webkit.org/show_bug.cgi?id=133278
2252
2253         Reviewed by Gyuyoung Kim.
2254
2255         * Scripts/webkitperl/FeatureList.pm: Add a build script condition missing in r169172.
2256
2257 2014-05-26  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2258
2259         run-javascriptcore-tests warning fix on non Mac platforms
2260         https://bugs.webkit.org/show_bug.cgi?id=133260
2261
2262         Reviewed by Darin Adler.
2263
2264         * Scripts/webkitdirs.pm:
2265         (argumentsForConfiguration):
2266
2267 2014-05-23  Michael Saboff  <msaboff@apple.com>
2268
2269         REGRESSION(r169265): sh: line 0: cd: ../.vm
2270         https://bugs.webkit.org/show_bug.cgi?id=133242
2271
2272         Rubber stamped by Geoffrey Garen.
2273
2274         Added missing shell escapes '\' required as part of previous fix.
2275
2276         * Scripts/run-jsc-stress-tests:
2277
2278 2014-05-23  Ryosuke Niwa  <rniwa@webkit.org>
2279
2280         Revert the erroneous change committed in r169286.
2281
2282         * Scripts/webkitpy/performance_tests/perftest.py:
2283         (PerfTest._run_with_driver):
2284
2285 2014-05-23  Geoffrey Garen  <ggaren@apple.com>
2286
2287         run-perf-tests should ignore whitespace lines when snarfing test output
2288         https://bugs.webkit.org/show_bug.cgi?id=133238
2289
2290         Reviewed by Ryosuke Niwa.
2291
2292         Required for PerformanceTests/Canvas/terrain.html.
2293
2294         * Scripts/webkitpy/performance_tests/perftest.py:
2295         (PerfTest._run_with_driver):
2296         (PerfTest):
2297
2298 2014-05-23  Michael Saboff  <msaboff@apple.com>
2299
2300         REGRESSION (r169241) Crash running run-jsc-stress-tests on EFL ARM
2301         https://bugs.webkit.org/show_bug.cgi?id=133223
2302
2303         Reviewed by Geoffrey Garen.
2304
2305         Change runAndMonitorTestRunnerCommand() to convert the *cmd argument to a
2306         string before calling IO.popen() to work with older versions of ruby.
2307         Changed the remote path in runShellTestRunner to quote the command
2308         string we want to run via ssh so that it will work correctly with array
2309         to string conversion needed for popen.
2310
2311         * Scripts/run-jsc-stress-tests:
2312
2313 2014-05-23  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
2314
2315         Remove 'css-shaders' option from the build-webkit
2316         https://bugs.webkit.org/show_bug.cgi?id=133212
2317
2318         Reviewed by Daniel Bates.
2319
2320         Original CSS shaders removed in r162644.
2321
2322         * Scripts/webkitperl/FeatureList.pm:
2323
2324 2014-05-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2325
2326         [GTK] GObject DOM bindings API break test should fail in the bots when the command fails to run
2327         https://bugs.webkit.org/show_bug.cgi?id=133209
2328
2329         Reviewed by Sergio Villar Senin.
2330
2331         Return FAILURE when the command failed to run.
2332
2333         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2334         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.evaluateCommand):
2335
2336 2014-05-23  Alberto Garcia  <berto@igalia.com>
2337
2338         [GTK] Install libharfbuzz-dev in Tools/gtk/install-dependencies
2339         https://bugs.webkit.org/show_bug.cgi?id=133210
2340
2341         Reviewed by Carlos Garcia Campos.
2342
2343         * gtk/install-dependencies:
2344
2345 2014-05-22  Benjamin Poulain  <bpoulain@apple.com>
2346
2347         Add Yusuke Suzuki to the list of contributors (for real)
2348
2349         Wrong section...
2350
2351         * Scripts/webkitpy/common/config/contributors.json:
2352
2353 2014-05-22  Benjamin Poulain  <bpoulain@apple.com>
2354
2355         Add Yusuke Suzuki to the list of contributors
2356
2357         * Scripts/webkitpy/common/config/contributors.json:
2358
2359 2014-05-22  Michael Saboff  <msaboff@apple.com>
2360
2361         Eliminate n/total progress update from run-jsc-stress-tests output to file
2362         https://bugs.webkit.org/show_bug.cgi?id=133191
2363
2364         Reviewed by Geoffrey Garen.
2365
2366         Changed progressMeter setting to be based on stdout being a tty instead of
2367         stdin.  Unified the processing of output from the shell runner to match the
2368         same processing as is used by the makefile runner.  As part of this, the
2369         shell runner script was simplified.  It now forwards the output of each
2370         test_script just like the Makefile and doesn't provide its own progress.
2371
2372         * Scripts/jsc-stress-test-helpers/shell-runner.sh:
2373         * Scripts/run-jsc-stress-tests:
2374
2375 2014-05-22  Michael Saboff  <msaboff@apple.com>
2376
2377         Add option to run-jsc-stress-tests to use installed jsc
2378         https://bugs.webkit.org/show_bug.cgi?id=133102
2379
2380         Reviewed by Geoffrey Garen.
2381
2382         Added --no-copy option to not copy a JavaScriptCore framework, but use the one
2383         provied with the --jsc option.
2384
2385         * Scripts/run-jsc-stress-tests:
2386
2387 2014-05-21  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
2388
2389         [EFL] Add include path of compact_unwind_encoding.h if FTL JIT is enabled
2390         https://bugs.webkit.org/show_bug.cgi?id=132907
2391
2392         Reviewed by Gyuyoung Kim.
2393
2394         We need the mach-o/compact_unwind_encoding.h header from libc++abi-dev package
2395         in JavaScriptCore/ftl/FTLUnwindInfo.cpp when FTL JIT is enabled.
2396
2397         * efl/install-dependencies:
2398
2399 2014-05-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2400
2401         REGRESSION(r169092): It broke run-jsc-stress tests on non Mac platforms
2402         https://bugs.webkit.org/show_bug.cgi?id=133145
2403
2404         Reviewed by Csaba Osztrogonác.
2405
2406         * Scripts/run-jsc-stress-tests:
2407
2408 2014-05-20  Alexey Proskuryakov  <ap@apple.com>
2409
2410         [Mac] WebProcess doesn't follow localization of UI process when run as a service
2411         https://bugs.webkit.org/show_bug.cgi?id=133126
2412         <rdar://problem/13396515>
2413         <rdar://problem/16561084>
2414
2415         Reviewed by Sam Weinig and Tim Horton.
2416
2417         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2418         (WTR::InjectedBundle::platformInitialize): It was too late to override language
2419         here, and it's not necessary any more. Keeping the code for older OS versions in
2420         case it did have effect in some code paths.
2421
2422 2014-05-19  David Farler  <dfarler@apple.com>
2423
2424         Move WebKitTestRunner to std::unique_ptr
2425         https://bugs.webkit.org/show_bug.cgi?id=133081
2426
2427         Reviewed by Daniel Bates.
2428
2429         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2430         (WTR::InjectedBundle::didCreatePage):
2431         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2432         * WebKitTestRunner/TestController.cpp:
2433         (WTR::TestController::initialize):
2434         (WTR::TestController::createWebViewWithOptions):
2435         (WTR::TestController::resetStateToConsistentValues):
2436         (WTR::TestController::runTest):
2437         * WebKitTestRunner/TestController.h:
2438         * WebKitTestRunner/TestInvocation.cpp:
2439         * WebKitTestRunner/TestInvocation.h:
2440         * WebKitTestRunner/WorkQueueManager.cpp:
2441         (WTR::WorkQueueManager::processWorkQueue):
2442         (WTR::WorkQueueManager::enqueue):
2443         * WebKitTestRunner/WorkQueueManager.h:
2444
2445 2014-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2446
2447         [GTK] WebKitWebPage::send-request always pass a valid pointer for redirected response
2448         https://bugs.webkit.org/show_bug.cgi?id=133119
2449
2450         Reviewed by Sergio Villar Senin.
2451
2452         Check that redirect response parameter of
2453         WebKitWebPage::send-request signal is NULL when not redirecting
2454         and a valid WebKitURIResponse object when redirecting.
2455
2456         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2457         (testWebResourceSendRequest):
2458         (serverCallback):
2459         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2460         (sendRequestCallback):
2461
2462 2014-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2463
2464         REGRESSION(CMAKE): [GTK] Several WebKit2GTK+ unit tests are no longer built
2465         https://bugs.webkit.org/show_bug.cgi?id=133117
2466
2467         Reviewed by Philippe Normand.
2468
2469         Bring back missing tests to the build.
2470
2471         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2472
2473 2014-05-19  Filip Pizlo  <fpizlo@apple.com>
2474
2475         Take care of some ARM64 test failures
2476         https://bugs.webkit.org/show_bug.cgi?id=133090
2477
2478         Reviewed by Geoffrey Garen.
2479
2480         * Scripts/run-jsc-stress-tests: Make it easier to conditionally skip things.
2481
2482 2014-05-19  David Kilzer  <ddkilzer@apple.com>
2483
2484         [iOS] REGRESSION (r168910): webkitdirs.pm: Be more forgiving when parsing --sdk, --device and --sim
2485         <http://webkit.org/b/133089>
2486
2487         Reviewed by Darin Adler.
2488
2489         * Scripts/webkitdirs.pm:
2490         (determineXcodeSDK): If both '--sdk SDKROOT' and '--sim' are
2491         specified on the command line, we would remove the '--sdk'
2492         arguments, but leave '--sim', potentially passing it along to
2493         xcodebuild causing a build failure.  This happens when
2494         'old-run-webkit-tests --release --sim' invokes
2495         build-dumprendertree when DumpRenderTree hasn't been built yet.
2496
2497 2014-05-19  David Farler  <dfarler@apple.com>
2498
2499         Dashboard: OpenSource revision key changed from WebKitOpenSource to WebKit
2500         https://bugs.webkit.org/show_bug.cgi?id=133086
2501
2502         Reviewed by Daniel Bates.
2503
2504         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2505
2506 2014-05-19  David Kilzer  <ddkilzer@apple.com>
2507
2508         REGRESSION (r169042): Fix run-api-tests on Mountain Lion
2509         <http://webkit.org/b/132954>
2510
2511         * Scripts/webkitdirs.pm:
2512         (sharedCommandLineOptionsUsage): Remove the prototype for the
2513         subroutine.  Older perls don't like the "+@" syntax.
2514
2515 2014-05-19  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2516
2517         run-javascriptcore-tests should sort the list of failing stress tests
2518         https://bugs.webkit.org/show_bug.cgi?id=132989
2519
2520         Reviewed by Csaba Osztrogonác.
2521
2522         * Scripts/run-javascriptcore-tests:
2523
2524 2014-05-19  David Kilzer  <ddkilzer@apple.com>
2525
2526         webkitdirs.pm: Add setupMacWebKitEnvironment() to set __XPC_DYLD_FRAMEWORK_PATH consistently
2527         <http://webkit.org/b/132954>
2528
2529         Reviewed by Darin Adler.
2530
2531         Extract code into setupMacWebKitEnvironment() for setting up
2532         common environment variables so it may be shared.  Sets
2533         __XPC_DYLD_FRAMEWORK_PATH consistently and adds support for
2534         using guardmalloc to some scripts.
2535
2536         Also adds support for parsing shared (common) command-line
2537         switches, initially just -g|--guard-malloc.
2538
2539         * Scripts/bisect-builds: Add -g|--guard-malloc support by using
2540         sharedCommandLineOptions() and sharedCommandLineOptionsUsage().
2541         (mountAndRunNightly): Call setupMacWebKitEnvironment().  Use a
2542         local copy of %ENV when launching Safari so we don't have to
2543         restore variables.
2544
2545         * Scripts/run-api-tests: Add -g|--guard-malloc support by using
2546         sharedCommandLineOptions() and sharedCommandLineOptionsUsage().
2547         Check result of GetOptions() to catch invalid command-line
2548         switches.
2549         (runTest): Use a local copy of %ENV when running tests so we
2550         don't have to restore variables.
2551         (prepareEnvironmentForRunningTestTool): Call
2552         setupMacWebKitEnvironment().
2553
2554         * Scripts/run-pageloadtest: Add -g|--guard-malloc support by
2555         using sharedCommandLineOptions() and
2556         sharedCommandLineOptionsUsage().  Call
2557         setupMacWebKitEnvironment().
2558
2559         * Scripts/webkitdirs.pm:
2560         (sharedCommandLineOptions): Return array of common switches to
2561         pass to Getopt::Long::GetOptions().
2562         (sharedCommandLineOptionsUsage): Return formatted string of
2563         common switches for printing usage help text.
2564         (setUpGuardMallocIfNeeded): Support using '-g' for enabling
2565         guardmalloc.
2566         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Ditto.
2567         (setupMacWebKitEnvironment): Extracted from runMacWebKitApp()
2568         and changed not to clobber DYLD_FRAMEWORK_PATH if already set.
2569         (runMacWebKitApp): Call setupMacWebKitEnvironment().  Use a
2570         local copy of %ENV when launching Safari so we don't have to
2571         restore variables.
2572         (execMacWebKitAppForDebugging): Call
2573         setupMacWebKitEnvironment().
2574
2575 2014-05-18  Rik Cabanier  <cabanier@adobe.com>
2576
2577         support for navigator.hardwareConcurrency
2578         https://bugs.webkit.org/show_bug.cgi?id=132588
2579
2580         Reviewed by Filip Pizlo.
2581
2582         * Scripts/webkitperl/FeatureList.pm:
2583
2584 2014-05-18  Anders Carlsson  <andersca@apple.com>
2585
2586         Implement Navigations for all methods declared returning one
2587         https://bugs.webkit.org/show_bug.cgi?id=133048
2588         <rdar://problem/16830064>
2589
2590         Reviewed by Sam Weinig.
2591
2592         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2593         Import WebKit.h.
2594
2595         * MiniBrowser/mac/WK2BrowserWindowController.m:
2596         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
2597         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
2598         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
2599         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
2600         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
2601         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
2602         Print out the navigations.
2603
2604 2014-05-17  Zalan Bujtas  <zalan@apple.com>
2605
2606         Subpixel rendering: Add subpixelCSSOMElementMetricsEnabled to WK1 WebPreferences.
2607         https://bugs.webkit.org/show_bug.cgi?id=133029
2608
2609         Reviewed by Simon Fraser.
2610
2611         Added a menu item to toggle subpixelCSSOMElementMetricsEnabled's value. However
2612         toggling it on a WK2 window needs restart.
2613         Adding dynamic toggle to WK2 requires a WebPreferences SPI. It's not worth cluttering
2614         the WebPreferences just to support this temporary toggle.
2615
2616         * MiniBrowser/mac/BrowserWindowController.h:
2617         * MiniBrowser/mac/MainMenu.xib:
2618         * MiniBrowser/mac/WK1BrowserWindowController.m:
2619         (-[WK1BrowserWindowController validateMenuItem:]):
2620         (-[WK1BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]):
2621         (-[WK1BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]):
2622         * MiniBrowser/mac/WK2BrowserWindowController.m:
2623         (-[WK2BrowserWindowController validateMenuItem:]):
2624         (-[WK2BrowserWindowController isSubpixelCSSOMElementMetricsEnabled]):
2625         (-[WK2BrowserWindowController toggleSubpixelCSSOMElementMetricsEnabled:]):
2626
2627 2014-05-17  Anders Carlsson  <andersca@apple.com>
2628
2629         Replace WKContextSetDatabaseDirectory with two WKContextConfiguration parameters
2630         https://bugs.webkit.org/show_bug.cgi?id=133033
2631         <rdar://problem/16830143>
2632
2633         Reviewed by Sam Weinig.
2634
2635         Set up the WebSQL and IndexedDB directories.
2636
2637         * WebKitTestRunner/TestController.cpp:
2638         (WTR::TestController::initialize):
2639
2640 2014-05-16  Martin Hock  <mhock@apple.com>
2641
2642         MemoryCache::addImageToCache should return the result of add().
2643         https://bugs.webkit.org/show_bug.cgi?id=132928
2644         <rdar://problem/16651547>
2645
2646         Reviewed by Alexey Proskuryakov.
2647
2648         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2649         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2650         * TestWebKitAPI/Tests/ios/MemoryCacheAddImageToCacheIOS.mm: Added.
2651         (TestWebKitAPI::TEST):
2652
2653 2014-05-15  David Farler  <dfarler@apple.com>
2654
2655         old-run-webkit-tests: allow specifying a simulator app path
2656         https://bugs.webkit.org/show_bug.cgi?id=132975
2657
2658         Reviewed by Anders Carlsson.
2659
2660         * Scripts/old-run-webkit-tests:
2661         (openIPhoneSimulator):
2662         Add new --simulator-app command line parameter for specifying the
2663         absolute path to the simulator app to launch before starting a
2664         session.
2665
2666 2014-05-16  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2667
2668         [webkitpy] In case of multiple bug rollout, all bugs should be reopened, not only the oldest one
2669         https://bugs.webkit.org/show_bug.cgi?id=131363
2670
2671         Reviewed by Csaba Osztrogonác.
2672
2673         * Scripts/webkitpy/common/checkout/checkout_mock.py:
2674         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
2675         (MockBugzilla):
2676         * Scripts/webkitpy/tool/commands/download_unittest.py:
2677         (test_create_rollout_multiple_revision_with_one_resolved):
2678         (test_create_rollout_multiple_resolved):
2679         (test_rollout_two_revisions):
2680         (test_rollout_multiple_revisions):
2681         (test_rollout_multiple_revisions_with_a_missing_bug_id):
2682         * Scripts/webkitpy/tool/steps/createbug.py:
2683         (CreateBug.run):
2684         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
2685         (ReopenBugAfterRollout.run):
2686
2687 2014-05-16  Martin Hodovan  <mhodovan.u-szeged@partner.samsung.com>
2688
2689         [WK2] Change the remaining framework includes from WebKit2 to WebKit
2690         https://bugs.webkit.org/show_bug.cgi?id=132956
2691
2692         Reviewed by Sam Weinig.
2693
2694         * MiniBrowser/MiniBrowserWebProcessPlugIn.h:
2695         * MiniBrowser/mac/AppDelegate.m:
2696         * MiniBrowser/mac/WK2BrowserWindowController.m:
2697         * TestWebKitAPI/InjectedBundleController.h:
2698         * TestWebKitAPI/InjectedBundleMain.cpp:
2699         * TestWebKitAPI/JavaScriptTest.cpp:
2700         * TestWebKitAPI/PlatformUtilities.h:
2701         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
2702         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
2703         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
2704         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
2705         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
2706         (TestWebKitAPI::TEST):
2707         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp:
2708         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp:
2709         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
2710         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
2711         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
2712         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
2713         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
2714         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
2715         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2716         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2717         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
2718         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
2719         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
2720         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
2721         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
2722         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
2723         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
2724         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
2725         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
2726         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2727         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
2728         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp:
2729         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
2730         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
2731         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
2732         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
2733         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
2734         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
2735         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
2736         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp:
2737         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
2738         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
2739         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
2740         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
2741         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
2742         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
2743         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
2744         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
2745         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
2746         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp:
2747         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
2748         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
2749         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
2750         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2751         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2752         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
2753         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
2754         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
2755         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
2756         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
2757         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
2758         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
2759         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
2760         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
2761         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
2762         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
2763         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
2764         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
2765         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2766         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2767         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
2768         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
2769         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
2770         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
2771         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
2772         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
2773         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp:
2774         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
2775         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
2776         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor_Bundle.mm:
2777         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
2778         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm:
2779         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
2780         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
2781         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
2782         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
2783         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
2784         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
2785         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2786         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
2787         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
2788         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2789         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
2790         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
2791         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
2792         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
2793         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
2794         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
2795         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2796         * TestWebKitAPI/config.h:
2797         * TestWebKitAPI/efl/PlatformWebView.cpp:
2798         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
2799         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2800         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2801         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
2802         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
2803         * WebKitTestRunner/EventSenderProxy.h:
2804         * WebKitTestRunner/GeolocationProviderMock.cpp:
2805         * WebKitTestRunner/GeolocationProviderMock.h:
2806         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2807         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2808         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2809         * WebKitTestRunner/InjectedBundle/GCController.cpp:
2810         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2811         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2812         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
2813         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2814         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2815         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2816         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2817         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
2818         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2819         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2820         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2821         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2822         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
2823         * WebKitTestRunner/InjectedBundle/ios/EventSenderProxyIOS.mm:
2824         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
2825         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
2826         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2827         * WebKitTestRunner/PlatformWebView.h:
2828         * WebKitTestRunner/StringFunctions.h:
2829         * WebKitTestRunner/TestController.cpp:
2830         * WebKitTestRunner/TestController.h:
2831         * WebKitTestRunner/TestInvocation.cpp:
2832         * WebKitTestRunner/TestInvocation.h:
2833         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
2834         * WebKitTestRunner/WebNotificationProvider.cpp:
2835         * WebKitTestRunner/WebNotificationProvider.h:
2836         * WebKitTestRunner/WorkQueueManager.cpp:
2837         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2838         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2839         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
2840         * WebKitTestRunner/config.h:
2841         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2842         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2843         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2844         * WebKitTestRunner/ios/TestControllerIOS.mm:
2845         * WebKitTestRunner/mac/EventSenderProxy.mm:
2846         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2847         * WebKitTestRunner/mac/TestControllerMac.mm:
2848
2849 2014-05-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2850
2851         [EFL][WK2] Skip failing unit tests
2852         https://bugs.webkit.org/show_bug.cgi?id=132979
2853
2854         Reviewed by Daniel Bates.
2855
2856         * TestWebKitAPI/PlatformEfl.cmake: Skip failing unit tests for now.
2857
2858 2014-05-15  David Kilzer  <ddkilzer@apple.com>
2859
2860         [iOS] Support TestWebKitAPI in the iOS Simulator
2861         <http://webkit.org/b/129535>
2862         <rdar://problem/16203529>
2863
2864         Reviewed by Daniel Bates.
2865
2866         * Scripts/run-api-tests:
2867         (runTest):
2868         (listAllTests):
2869         - Extract common arguments into local variable.
2870         - Use xcrun to find the sim tool in order to invoke
2871         TestWebKitAPI properly in the iOS Simulator.
2872
2873         * Scripts/webkitdirs.pm:
2874         (argumentsForConfiguration): Set --device or --sim as
2875         appropriate to fix buildTestTool() in run-api-tests.
2876
2877 2014-05-15  Tim Horton  <timothy_horton@apple.com>
2878
2879         Fix a logging typo in copy-webkitlibraries-to-product-directory
2880
2881         Reviewed by Dean Jackson.
2882
2883         * Scripts/copy-webkitlibraries-to-product-directory:
2884
2885 2014-05-15  David Kilzer  <ddkilzer@apple.com>
2886
2887         TestWebKitAPI: URLExtras.mm should be a shared test for iOS and Mac
2888         <http://webkit.org/b/132959>
2889
2890         Reviewed by Dan Bernstein.
2891
2892         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
2893         Cocoa directory to project and move URLExtras.mm into it.
2894         * TestWebKitAPI/Tests/Cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/URLExtras.mm.
2895
2896 2014-05-15  Carlos Garcia Campos  <cgarcia@igalia.com>
2897
2898         [GTK] Compile all installed resources as GResources
2899         https://bugs.webkit.org/show_bug.cgi?id=131099
2900
2901         Reviewed by Philippe Normand.
2902
2903         * Scripts/webkitpy/port/gtk.py:
2904         (GtkPort.setup_environ_for_server): Removed now unneeded
2905         AUDIO_RESOURCES_PATH env var.
2906
2907 2014-05-14  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2908
2909         Remove CSS_STICKY_POSITION guards
2910         https://bugs.webkit.org/show_bug.cgi?id=132676
2911
2912         Reviewed by Simon Fraser.
2913
2914         * Scripts/webkitperl/FeatureList.pm:
2915
2916 2014-05-14  Carlos Garcia Campos  <cgarcia@igalia.com>
2917
2918         REGRESSION(CMAKE): [GTK] InputMethodFilter unit test is not built
2919         https://bugs.webkit.org/show_bug.cgi?id=132686
2920
2921         Reviewed by Philippe Normand.
2922
2923         Bring back InputMethodFilter test to the build and compile it into
2924         a single binary TestWebCore with the other WebCore tests. Also
2925         move it from TestWebKitAPI/gtk/ to TestWebKitAPI/Tests/WebCore/gtk/.
2926
2927         * Scripts/run-gtk-tests:
2928         (TestRunner): Remove WebCoreGtk from the list of test directories.
2929         * TestWebKitAPI/PlatformGTK.cmake:
2930         * TestWebKitAPI/Tests/WebCore/gtk/InputMethodFilter.cpp: Renamed from Tools/TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp.
2931
2932 2014-05-14  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
2933
2934         [EFL] Make XVFBDriver optional
2935         https://bugs.webkit.org/show_bug.cgi?id=131036
2936
2937         Reviewed by Gyuyoung Kim.
2938
2939         * Scripts/webkitpy/port/efl.py:
2940         (EflPort._driver_class):
2941
2942 2014-05-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2943
2944         Flakiness dashboard contains outdated list of bots on builders.jsonp
2945         https://bugs.webkit.org/show_bug.cgi?id=132874
2946
2947         Reviewed by Darin Adler.
2948
2949         * TestResultServer/static-dashboards/builders.jsonp: Regenerate this
2950         file by changing to the directory Tools/TestResultServer and executing
2951         the script generate_builders_json.py
2952
2953 2014-05-11  Anders Carlsson  <andersca@apple.com>
2954
2955         Replace WKContextSetLocalStorageDirectory with a context configuration getter/setter
2956         https://bugs.webkit.org/show_bug.cgi?id=132809
2957
2958         Reviewed by Dan Bernstein.
2959
2960         * WebKitTestRunner/TestController.cpp:
2961         (WTR::TestController::initialize):
2962         Set the local storage directory using WKContextConfigurationSetLocalStorageDirectory.
2963
2964 2014-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2965
2966         REGRESSION(CMAKE): [GTK] JavaScriptCore API tests are not built anymore
2967         https://bugs.webkit.org/show_bug.cgi?id=132739
2968
2969         Reviewed Anders Carlsson.
2970
2971         * TestWebKitAPI/CMakeLists.txt: Add missing includes required by
2972         the JSC unit tests.
2973         * TestWebKitAPI/PlatformGTK.cmake: Bring back JavaScriptCore unit tests.
2974
2975 2014-05-11  Anders Carlsson  <andersca@apple.com>
2976
2977         Add a WKContextConfigurationRef object and make the injected bundle path part of the configuration
2978         https://bugs.webkit.org/show_bug.cgi?id=132806
2979
2980         Reviewed by Beth Dakin.
2981
2982         Migrate to WKContextConfiguration.
2983
2984         * WebKitTestRunner/TestController.cpp:
2985         (WTR::TestController::initialize):
2986
2987 2014-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
2988
2989         REGRESSION(CMAKE): [GTK] WebKit2 C API tests are not longer built in the same binary
2990         https://bugs.webkit.org/show_bug.cgi?id=132685
2991
2992         Reviewed by Martin Robinson.
2993
2994         Use a single TestWebKit2 binary for all WebKit2 C API tests.
2995
2996         * TestWebKitAPI/PlatformGTK.cmake:
2997
2998 2014-05-09  Benjamin Poulain  <benjamin@webkit.org>
2999
3000         [iOS] Switch geolocation to an explicit authorization query model
3001         https://bugs.webkit.org/show_bug.cgi?id=132717
3002
3003         Reviewed by Sam Weinig.
3004
3005         * DumpRenderTree/mac/MockGeolocationProvider.mm:
3006         (-[MockGeolocationProvider initializeGeolocationForWebView:listener:]):
3007         (-[MockGeolocationProvider cancelWarmUpForWebView:]): Deleted.
3008
3009 2014-05-09  David Farler  <dfarler@apple.com>
3010
3011         com.apple.iphonesimulator.startSession needs to pass "RuntimeIdentifier"
3012         https://bugs.webkit.org/show_bug.cgi?id=132718
3013
3014         Reviewed by David Kilzer.
3015
3016         The simulator may not be able to look up runtimes by SDK paths
3017         and instead will map SDK versions to runtimes instead. In
3018         com.apple.iphonesimulator.startSession notifications,
3019         'runtimeIdentifier' (SDK version string) is preferred over
3020         'sdkRoot' (SDK path) anyway. Include the 'runtimeIdentifier' key
3021         when creating a new DRT or WKTR simulator session.
3022
3023         IPhoneSimulatorNotification.pm filters out keys for this
3024         notification's userInfo with a hard-coded list. There's no harm
3025         in including extra key-value pairs in an NSNotification userInfo
3026         dictionary anyway and the simulator may again change its
3027         userInfo schema for this notification.
3028
3029         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
3030         (postStartSessionNotification):
3031         * Scripts/old-run-webkit-tests:
3032         (installAndLaunchDumpToolAppUsingNotification):
3033
3034 2014-05-09  Anders Carlsson  <andersca@apple.com>
3035
3036         Another build fix.
3037
3038         * Scripts/build-webkit:
3039         WebKit2 should always be built for OS X and iOS.
3040
3041 2014-05-09  Anders Carlsson  <andersca@apple.com>
3042
3043         Follow-up build fix.
3044
3045         * Scripts/build-webkit:
3046         WebKit2 should no longer be built before WebKit.
3047
3048 2014-05-09  Anders Carlsson  <andersca@apple.com>
3049
3050         Rename WebKit2.framework to WebKit.framework
3051         https://bugs.webkit.org/show_bug.cgi?id=132743
3052         <rdar://problem/15920046>
3053
3054         Reviewed by Dan Bernstein.
3055
3056         * Scripts/check-for-inappropriate-files-in-framework:
3057         Use PRODUCT_NAME instead of PROJECT_NAME when matching frameworks.
3058         Change WebKit2 to WebKit.
3059
3060         * Scripts/check-for-webkit-framework-include-consistency:
3061         Change WebKit to WebKitLegacy.
3062
3063 2014-05-09  Manuel Rego Casasnovas  <rego@igalia.com>
3064
3065         Remove GTK+ WK1 EWS from build.webkit.org/dashboard
3066         https://bugs.webkit.org/show_bug.cgi?id=132732
3067
3068         Reviewed by Alexey Proskuryakov.
3069
3070         GTK+ WK1 EWS was removed in r166427, so it shouldn't appear in the dashboard.
3071
3072         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
3073         (EWS): Remove GTK+ WK1 EWS.
3074
3075 2014-05-09  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3076
3077         Add new u-szeged contributors.
3078
3079         Reviewed by Csaba Osztrogonác.
3080
3081         * Scripts/webkitpy/common/config/contributors.json:
3082
3083 2014-05-09  Carlos Garcia Campos  <cgarcia@igalia.com>
3084
3085         REGRESSION(CMAKE): [GTK] run-gtk-tests doesn't set the right injected bundle path
3086         https://bugs.webkit.org/show_bug.cgi?id=132736
3087
3088         Reviewed by Philippe Normand.
3089
3090         There are two problems, the path returned by common.library_build_path() is wrong when
3091         common.binary_build_path() has previously been called, and the test is still looking for
3092         the .la instead of .so
3093
3094         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
3095         (TestWebKitAPI::Util::createInjectedBundlePath): Use .so instead
3096         of .la as extension of the injected bundle library.
3097         * gtk/common.py:
3098         (binary_build_path): Remove unused global variable and add a new
3099         one for binary_build_dir instead of sharing the same global
3100         variable for library_build_path and binary_build_path.
3101
3102 2014-05-08  Praveen R Jadhav  <praveen.j@samsung.com>
3103
3104         [EFL] Enable MEDIA_STREAM for EFL port
3105         https://bugs.webkit.org/show_bug.cgi?id=132648
3106
3107         Reviewed by Gyuyoung Kim.
3108
3109         Script modified to enable MEDIA_STREAM for EFL build.
3110
3111         * Scripts/webkitperl/FeatureList.pm:
3112
3113 2014-05-08  David Farler  <dfarler@apple.com>
3114
3115         old-run-webkit-tests: update strings for simulator devices and app name
3116         https://bugs.webkit.org/show_bug.cgi?id=132687
3117
3118         Reviewed by Darin Adler.
3119
3120         iPhone Retina (4-inch) -> iPhone 5
3121         iPhone Retina (4-inch 64-bit) -> iPhone 5s
3122
3123         * Scripts/old-run-webkit-tests:
3124         (installAndLaunchDumpToolAppUsingNotification):
3125         (openIPhoneSimulator):
3126         (quitIPhoneSimulator):
3127         quit iOS Simulator, not iPhone Simulator.
3128
3129 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3130
3131         REGRESSION(r168471): Update the builder names on the scheduler list.
3132         https://bugs.webkit.org/show_bug.cgi?id=132699
3133
3134         Reviewed by Martin Robinson.
3135
3136         On r168471 I missed to update the builder names for the GTK build
3137         bots on the AnyBranchScheduler type scheduler list of bots.
3138
3139         * BuildSlaveSupport/build.webkit.org-config/config.json:
3140
3141 2014-05-08  Brady Eidson  <beidson@apple.com>
3142
3143         "shouldKeepCurrentBackForwardListItemInList" API should pass clientInfo to the callback
3144         <rdar://problem/16855357> and https://bugs.webkit.org/show_bug.cgi?id=132692
3145
3146         Reviewed by Tim Horton.
3147
3148         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
3149         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
3150
3151 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3152
3153         REGRESSION(r168471): Duplicate builddirs broke the build master.
3154         https://bugs.webkit.org/show_bug.cgi?id=132688
3155
3156         Reviewed by Carlos Garcia Campos.
3157
3158         Rename the builddirs of the new GTK bots introduced on r168471 to
3159         be unique. Otherwise the master will break.
3160
3161         * BuildSlaveSupport/build.webkit.org-config/config.json:
3162
3163 2014-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3164
3165         [GTK] webkitdom script assumes mkdir only fails because the directory already exists
3166         https://bugs.webkit.org/show_bug.cgi?id=132674
3167
3168         Reviewed by Philippe Normand.
3169
3170         Only ignore mkdir failure when exception is raised because the
3171         file already exists and it's a directory.
3172
3173         * gtk/webkitdom.py:
3174         (write_doc_files):
3175
3176 2014-05-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3177
3178         [WK2][GTK] Split the 64-bit GTK buildbots in Build and Test.
3179         https://bugs.webkit.org/show_bug.cgi?id=131358
3180
3181         Reviewed by Carlos Garcia Campos.
3182
3183         Current 64-bit GTK build bots (Release and Debug) not only test
3184         the build, but run all tests. Split each one of the bots in
3185         BuildOnly and TestWebKit2.
3186
3187         This will allow us to have a better overview of the status of
3188         the GTK port.
3189
3190         Original patch from Sergio Villar Senin <svillar@igalia.com>
3191
3192         * BuildSlaveSupport/build.webkit.org-config/config.json:
3193         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3194         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3195         (WebKitBuildbot):
3196         * Scripts/webkitpy/port/builders.py:
3197         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3198         (TestRebaselineTest.test_baseline_directory):
3199         * TestResultServer/static-dashboards/builders.jsonp:
3200         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3201         (resetGlobals):
3202         * TestResultServer/static-dashboards/loader_unittests.js:
3203
3204 2014-05-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3205
3206         [CoordinatedGraphics][WK2] Scale factor and scroll position is not being restored properly in a back/forward load
3207         https://bugs.webkit.org/show_bug.cgi?id=126022
3208
3209         Reviewed by Benjamin Poulain.
3210
3211         Original author : Thiago de Barros Lacerda, and finished by Gyuyoung Kim.
3212
3213         Added an unit test case to check if scroll position and scale are restored properly.
3214
3215         * TestWebKitAPI/PlatformEfl.cmake:
3216         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Added.
3217         (TestWebKitAPI::didFinishLoadForFrame):
3218         (TestWebKitAPI::didChangeContentsPosition):
3219         (TestWebKitAPI::TEST):
3220         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Added.
3221         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Added.
3222
3223 2014-05-07  Simon Fraser  <simon.fraser@apple.com>
3224
3225         WebKit1 is flashy when compositing layers come and go
3226         https://bugs.webkit.org/show_bug.cgi?id=132655
3227         <rdar://problem/16830981&16788846>
3228
3229         Reviewed by Sam Weinig.
3230
3231         Revert the change from r166117.
3232
3233         * DumpRenderTree/mac/DumpRenderTree.mm:
3234         (updateDisplay):
3235
3236 2014-05-07  Chris Fleizach  <cfleizach@apple.com>
3237
3238         AX: AXSelectTextWithCriteria should support capitalize/lowercase/uppercase
3239         https://bugs.webkit.org/show_bug.cgi?id=132622
3240
3241         Reviewed by Mario Sanchez Prada.
3242
3243         * DumpRenderTree/AccessibilityUIElement.cpp:
3244         (selectTextWithCriteriaCallback):
3245         (isEqualCallback):
3246         * DumpRenderTree/AccessibilityUIElement.h:
3247         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3248         (AccessibilityUIElement::selectTextWithCriteria):
3249         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3250         (AccessibilityUIElement::selectTextWithCriteria):
3251         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3252         (selectTextParameterizedAttributeForCriteria):
3253         (AccessibilityUIElement::selectTextWithCriteria):
3254         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3255         (AccessibilityUIElement::selectTextWithCriteria):
3256         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3257         (WTR::AccessibilityUIElement::selectTextWithCriteria):
3258         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3259         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3260         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3261         (WTR::AccessibilityUIElement::selectTextWithCriteria):
3262         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3263         (WTR::AccessibilityUIElement::selectTextWithCriteria):
3264         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3265         (WTR::selectTextParameterizedAttributeForCriteria):
3266         (WTR::AccessibilityUIElement::selectTextWithCriteria):
3267
3268 2014-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
3269
3270         [SOUP] TLSErrors do not cause page load to fail when not ignored
3271         https://bugs.webkit.org/show_bug.cgi?id=121548
3272
3273         Reviewed by Sergio Villar Senin.
3274
3275         Add unit tests to check that the load fails with TLS errors in
3276         case of a redirection.
3277
3278         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
3279         (testTLSErrorsRedirect):
3280         (httpsServerCallback):
3281         (beforeAll):
3282
3283 2014-05-07  Manuel Rego Casasnovas  <rego@igalia.com>
3284
3285         [CSS Grid Layout] Remove runtime feature
3286         https://bugs.webkit.org/show_bug.cgi?id=132382
3287
3288         Reviewed by Benjamin Poulain.
3289
3290         Remove cssGridLayoutEnabled setting usage.
3291
3292         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3293         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3294         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3295         (TestRunner::overridePreference):
3296         * DumpRenderTree/mac/DumpRenderTree.mm:
3297         (resetWebPreferencesToConsistentValues):
3298
3299 2014-05-06  David Kilzer  <ddkilzer@apple.com>
3300
3301         Add Makefile targets for copying static libraries (LLVM and WKSI)
3302         <http://webkit.org/b/132619>
3303
3304         Reviewed by Mark Rowe.
3305
3306         * Scripts/copy-webkitlibraries-to-product-directory: Set a
3307         sensible default for product directory if not specified on
3308         either the command-line or in the environment (by Xcode) by
3309         calling productDir() in webkitdirs.pm.
3310
3311 2014-05-06  Brady Eidson  <beidson@apple.com>
3312
3313         Add WK2 SPI to prevent the previous back/forward item from remaining in the list
3314         <rdar://problem/16248710> and https://bugs.webkit.org/show_bug.cgi?id=132636
3315
3316         Reviewed by Sam Weinig.
3317
3318         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3319
3320         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp: Added.
3321         (TestWebKitAPI::itemURLLastComponentIsString):
3322         (TestWebKitAPI::didFinishLoadForFrame):
3323         (TestWebKitAPI::willGoToBackForwardListItem):
3324         (TestWebKitAPI::shouldKeepCurrentBackForwardListItemInList):
3325         (TestWebKitAPI::setPageLoaderClient):
3326         (TestWebKitAPI::TEST):
3327         * TestWebKitAPI/Tests/WebKit2/simple2.html: Added.
3328         * TestWebKitAPI/Tests/WebKit2/simple3.html: Added.
3329
3330         * WebKitTestRunner/TestController.cpp:
3331         (WTR::TestController::createWebViewWithOptions): Update for new client layout.
3332
3333 2014-05-06  Darin Adler  <darin@apple.com>
3334
3335         Try to fix iOS build.
3336
3337         * DumpRenderTree/mac/TestRunnerMac.mm:
3338         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]):
3339         Updated since I changed testRunner into a pointer instead of a reference.
3340         Updated argument names to avoid conflict with field names.
3341         (-[APITestDelegateIPhone run]): Ditto.
3342         (-[APITestDelegateIPhone _cleanUp]): Ditto.
3343
3344 2014-05-06  Commit Queue  <commit-queue@webkit.org>
3345
3346         Unreviewed, rolling out r168304.
3347         https://bugs.webkit.org/show_bug.cgi?id=132607
3348
3349         Broke the build (Requested by KaL on #webkit).
3350
3351         Reverted changeset:
3352
3353         "[GTK][CMake] Unable to do make install"
3354         https://bugs.webkit.org/show_bug.cgi?id=130188
3355         http://trac.webkit.org/changeset/168304
3356
3357 2014-05-04  Darin Adler  <darin@apple.com>
3358
3359         RetainPtr: Use adoptCF function instead of AdoptCF constructor argument
3360         https://bugs.webkit.org/show_bug.cgi?id=80222
3361
3362         Reviewed by Alexey Proskuryakov.
3363
3364         * DumpRenderTree/mac/TestRunnerMac.mm:
3365         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]): Updated to
3366         do more work here so we don't use RetainPtr local variables.
3367         (-[APITestDelegateIPhone dealloc]): Added.
3368         (-[APITestDelegateIPhone run]): Added an early exit if the web view is already
3369         created. Updated for changes to member names and types.
3370         (-[APITestDelegateIPhone _cleanUp]): Added code to set webView to nil and
3371         updated for changes to member names and types. Changed to two word spelling.
3372         (-[APITestDelegateIPhone webView:didFailLoadWithError:forFrame:]): Updated
3373         name of _cleanUp method.
3374         (-[APITestDelegateIPhone webView:didFailProvisionalLoadWithError:forFrame:]):
3375         Ditto.
3376         (-[APITestDelegateIPhone webView:didFinishLoadForFrame:]): Ditto.
3377
3378 2014-05-05  Benjamin Poulain  <benjamin@webkit.org>
3379
3380         Clean up Image Document and tweak the layout and viewport
3381         https://bugs.webkit.org/show_bug.cgi?id=132552
3382
3383         Reviewed by Anders Carlsson.
3384
3385         * DumpRenderTree/mac/DumpRenderTree.mm:
3386         (resetWebPreferencesToConsistentValues):
3387         Update the default settings to have something consistent with WebKit2.
3388
3389 2014-05-05  Martin Robinson  <mrobinson@igalia.com>
3390
3391         [GTK][CMake] Unable to do make install
3392         https://bugs.webkit.org/show_bug.cgi?id=130188
3393
3394         Reviewed by Carlos Garcia Campos.
3395
3396         * Scripts/webkitdirs.pm:
3397         (buildCMakeGeneratedProject): Always build gtkdoc-no-html for WebKitGTK+. This
3398         will give an early signal that a change has broken the documentation.
3399
3400 2014-05-05  Pratik Solanki  <psolanki@apple.com>
3401
3402         Update framework locations in package-root
3403         https://bugs.webkit.org/show_bug.cgi?id=132571
3404
3405         Reviewed by Simon Fraser.
3406
3407         * Scripts/package-root:
3408
3409 2014-05-05  Ryuan Choi  <ryuan.choi@samsung.com>
3410
3411         [EFL][WK2] Refactor favicon database APIs
3412         https://bugs.webkit.org/show_bug.cgi?id=132519
3413
3414         Reviewed by Gyuyoung Kim.
3415
3416         * MiniBrowser/efl/main.c: Use ewk_favicon_database_icon_get instead of ewk_view_favicon_get.
3417         (update_view_favicon):
3418         (on_icon_changed_cb):
3419         (window_free):
3420         (on_url_changed):
3421         (window_create):
3422         (on_view_favicon_changed): Deleted.
3423
3424 2014-05-02  Mark Rowe  <mrowe@apple.com>
3425
3426         <https://webkit.org/b/132505> Make it possible to tell copy-webkitlibraries-to-product-directory which OS X version to copy for
3427
3428         Reviewed by Dan Bernstein.
3429
3430         * Scripts/copy-webkitlibraries-to-product-directory: Add an --osx-version argument and use the passed value
3431         when determining which LLVM archive to extract.
3432
3433 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
3434
3435         Add Jeremy as a committer.
3436         https://bugs.webkit.org/show_bug.cgi?id=132492
3437
3438         Reviewed by Jer Noble.
3439
3440         Add myself as a committer.
3441
3442         * Scripts/webkitpy/common/config/contributors.json:
3443
3444 2014-05-02  Jeremy Jones  <jeremyj@apple.com>
3445
3446         Add Jeremy as a committer.
3447         https://bugs.webkit.org/show_bug.cgi?id=132492
3448
3449         Reviewed by Jer Noble.
3450
3451         Add Jeremy Jones to the committers file.
3452
3453         * Scripts/webkitpy/common/config/contributors.json:
3454
3455 2014-05-02  Brian J. Burg  <burg@cs.washington.edu>
3456
3457         Hard to figure out how to run a single test with run-api-tests
3458         https://bugs.webkit.org/show_bug.cgi?id=116332
3459
3460         Reviewed by Alexey Proskuryakov.
3461
3462         * Scripts/run-api-tests: add two examples to the help message.
3463
3464 2014-05-02  Simon Fraser  <simon.fraser@apple.com>
3465
3466         Fix several memory leaks found by code inspection
3467         https://bugs.webkit.org/show_bug.cgi?id=132472
3468
3469         Reviewed by Geoffrey Garen.
3470
3471         Fix memory leaks.
3472
3473         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
3474         (TestWebKitAPI::TEST):
3475         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3476         (WTR::InjectedBundlePage::willSendRequestForFrame):
3477         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3478         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3479
3480 2014-05-02  Filip Pizlo  <fpizlo@apple.com>
3481
3482         DFGAbstractInterpreter should not claim Int52 arithmetic creates Int52s
3483         https://bugs.webkit.org/show_bug.cgi?id=132446
3484
3485         Reviewed by Mark Hahnenberg.
3486
3487         Test the FTL by default now that it's enabled by default.
3488
3489         * Scripts/run-javascriptcore-tests:
3490
3491 2014-05-01  Ryuan Choi  <ryuan.choi@samsung.com>
3492
3493         [EFL][WK1] Drop ewk_view_setting_tiled_backingstore APIs
3494         https://bugs.webkit.org/show_bug.cgi?id=132240
3495
3496         Reviewed by Anders Carlsson.
3497
3498         Removed ewk_view_setting_tiled_backingstore related code.
3499
3500         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3501         (DumpRenderTreeChrome::createView):
3502         (shouldUseTiledBackingStore): Deleted.
3503         * EWebLauncher/main.c:
3504         (windowCreate):
3505         (parseUserArguments):
3506
3507 2014-05-01  Anders Carlsson  <andersca@apple.com>
3508
3509         window.testRunner.keepWebHistory() should update the UI process state
3510         https://bugs.webkit.org/show_bug.cgi?id=132440
3511
3512         Reviewed by Dan Bernstein.
3513
3514         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3515         (WTR::InjectedBundle::postSetAddsVisitedLinks):
3516         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3517         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3518         (WTR::TestRunner::keepWebHistory):
3519         * WebKitTestRunner/TestInvocation.cpp:
3520         (WTR::TestInvocation::invoke):
3521         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3522
3523 2014-05-01  David Kilzer  <ddkilzer@apple.com>
3524
3525         Really remove ENABLE_PLUGIN_PROXY_FOR_VIDEO
3526         <http://webkit.org/b/132432>
3527
3528         Reviewed by Tim Horton.
3529
3530         * Scripts/webkitperl/FeatureList.pm: Remove support for
3531         --plugin-proxy-for-video switch.
3532
3533 2014-04-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3534
3535         Kernel sysctl interface hw.activecpu don't exists on Linux.
3536         https://bugs.webkit.org/show_bug.cgi?id=132286
3537
3538         Reviewed by Filip Pizlo.
3539
3540         * Scripts/run-jsc-stress-tests: Redirect stderr to null when
3541         calling sysctl over hw.activecpu
3542
3543 2014-04-30  Anders Carlsson  <andersca@apple.com>
3544
3545         Move the legacy WebKit API into WebKitLegacy.framework and move it inside WebKit.framework
3546         https://bugs.webkit.org/show_bug.cgi?id=132399
3547         <rdar://problem/15920046>
3548
3549         Reviewed by Dan Bernstein.
3550
3551         * Scripts/check-for-webkit-framework-include-consistency:
3552         Allos WAK headers in WebKitLegacy as well as WebKit.
3553
3554         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3555         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
3556         Update header imports.
3557
3558 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
3559
3560         [iOS WK2] Add test URL to crash reports for the UI process, clean up project
3561         https://bugs.webkit.org/show_bug.cgi?id=131954
3562
3563         Reviewed by Darin Adler.
3564
3565         WebKitTestRunner was adding application-specific information to crash reports
3566         to log the test path, but only in the web process. Fix it to also do this
3567         for the UI process, for both iOS and OS X.
3568
3569         Moved InjectedBundlePageMac.mm to InjectedBundlePageCocoa.mm and compile it for
3570         both iOS and OS X.
3571
3572         Factored crash reprorter-related code into CrashReporterInfo, and call it from
3573         a new TestController::platformWillRunTest() function on Mac and iOS.
3574
3575         Also remove Xcode-added unit test junk from the project.
3576
3577         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
3578         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
3579         * WebKitTestRunner/TestController.cpp:
3580         (WTR::TestController::runTest):
3581         * WebKitTestRunner/TestController.h:
3582         * WebKitTestRunner/TestInvocation.cpp:
3583         (WTR::TestInvocation::url):
3584         * WebKitTestRunner/TestInvocation.h:
3585         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3586         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Removed.
3587         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Removed.
3588         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Removed.
3589         * WebKitTestRunner/cocoa/CrashReporterInfo.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm.
3590         * WebKitTestRunner/cocoa/CrashReporterInfo.mm: Renamed from Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm.
3591         (WTR::testPathFromURL):
3592         (WTR::setCrashReportApplicationSpecificInformationToURL):
3593         * WebKitTestRunner/efl/TestControllerEfl.cpp:
3594         (WTR::TestController::platformWillRunTest):
3595         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3596         (WTR::TestController::platformWillRunTest):
3597         * WebKitTestRunner/ios/TestControllerIOS.mm:
3598         (WTR::TestController::platformWillRunTest):
3599         (WTR::TestController::setHidden):
3600         * WebKitTestRunner/mac/TestControllerMac.mm:
3601         (WTR::TestController::platformWillRunTest):
3602
3603 2014-04-30  Simon Fraser  <simon.fraser@apple.com>
3604
3605         Fix DRT assertion about mock scrollbars, which doesn't apply to iOS.
3606
3607         Reviewed by Tim Horton.
3608
3609         * DumpRenderTree/mac/DumpRenderTree.mm:
3610         (resetWebPreferencesToConsistentValues):
3611         (prepareConsistentTestingEnvironment):
3612
3613 2014-04-30  Anders Carlsson  <andersca@apple.com>
3614
3615         check-for-inappropriate-macros-in-external-headers should get the product name, not the project name
3616         https://bugs.webkit.org/show_bug.cgi?id=132397
3617
3618         Reviewed by Dan Bernstein.
3619
3620         * Scripts/check-for-inappropriate-macros-in-external-headers:
3621
3622 2014-04-29  Martin Robinson  <mrobinson@igalia.com>
3623
3624         [GTK] Make it easier to run CMake for downstreams
3625         https://bugs.webkit.org/show_bug.cgi?id=132370
3626
3627         Reviewed by Carlos Garcia Campos.
3628
3629         * Scripts/webkitdirs.pm:
3630         (generateBuildSystemFromCMakeProject): Pass -DDEVELOPER_MODE when building
3631         the GTK+ port.
3632
3633 2014-04-29  Stephanie Lewis  <slewis@apple.com>
3634
3635         <rdar://problem/16765765> Use JSON::PP in perl scripts instead of JSON.
3636
3637         Rubber stamped by Jessie Berlin.
3638
3639         JSON.pm was removed from our tools setup.
3640
3641         * Scripts/generate-coverage-data:
3642
3643 2014-04-29  Filip Pizlo  <fpizlo@apple.com>
3644
3645         Use LLVM as a backend for the fourth-tier DFG JIT (a.k.a. the FTL JIT)
3646         https://bugs.webkit.org/show_bug.cgi?id=112840
3647
3648         Rubber stamped by Geoffrey Garen.
3649
3650         * Scripts/build-jsc: Enable it on Mac.
3651         * Scripts/build-webkit: Enable it on Mac.
3652         * Scripts/export-llvm-build: Make it slightly easier to export the build if you've done a "make install".
3653
3654 2014-04-28  Sam Weinig  <sam@webkit.org>
3655
3656         REGRESSION (r167751): svn-create-patch is very slow
3657         https://bugs.webkit.org/show_bug.cgi?id=132300