2010-12-30 Konstantin Tokarev <annulen@yandex.ru>
[WebKit-https.git] / Tools / ChangeLog
1 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
2
3         Reviewed by David Kilzer.
4
5         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
6         used
7         https://bugs.webkit.org/show_bug.cgi?id=51672
8
9         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
10         with USE_SYSTEM_MALLOC=1
11         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
12         with USE_SYSTEM_MALLOC=1
13
14 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
15
16         Reviewed by David Kilzer.
17
18         [Qt] [Symbian] Fix build-webkit script for Symbian
19         https://bugs.webkit.org/show_bug.cgi?id=51509
20
21         Set the OUTPUT_DIR for Symbian to be the same as the source
22         directory.
23
24         * Scripts/webkitdirs.pm:
25
26 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
27
28         Reviewed by Darin Adler.
29
30         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
31         https://bugs.webkit.org/show_bug.cgi?id=51758
32
33         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
34
35         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
36         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
37
38 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
39
40         Unreviewed WinCE buildfix.
41
42         * WinCELauncher/main.cpp: Add missing include.
43
44 2010-12-29  Daniel Bates  <dbates@rim.com>
45
46         Reviewed by Darin Adler.
47
48         svn-apply updates date of wrong change log entry for a change log diff that
49         contains two consecutive entries with the same author and date
50         https://bugs.webkit.org/show_bug.cgi?id=46061
51
52         Fixes an issue where the date of the wrong change log entry may be modified.
53         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
54         in a ChangeLog file to the top of the file.
55
56         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
57         diff when it detects that the diff inserts a change log entry earlier in a
58         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
59         change. With the advent of the commit-queue this functionality of bailing out
60         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
61         Instead, we should always move the change log entry to the top of the ChangeLog file.
62
63         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
64         the date line of the correct change log entry in a ChangeLog diff.
65
66         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
67
68         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
69           Updated the following unit tests now that we move entries inserted earlier to the top:
70           - "fixChangeLogPatch: New entry inserted in middle."
71             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
72
73           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
74             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
75
76         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
77
78 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
79
80         Reviewed by Eric Seidel.
81
82         [Qt] Fixed compatibility with gold linker on X11 platforms
83         https://bugs.webkit.org/show_bug.cgi?id=51700
84
85         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
86         Linked TestNetscapePlugin with libX11 on Unix platforms
87
88 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
89
90         Reviewed by Darin Adler.
91
92         Circular dependency in webkitpy.common.checkout.changelog module
93         https://bugs.webkit.org/show_bug.cgi?id=50475
94
95         Remove automatic import of api.Checkout module when any checkout/
96         submodule is imported (e.g.: when checkout.scm.Git is imported).
97
98         * Scripts/webkitpy/common/checkout/__init__.py:
99
100 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
101
102         Reviewed by Ojan Vafai.
103
104         prepare-ChangeLog should support the -g option for specifying the git-commit
105         https://bugs.webkit.org/show_bug.cgi?id=51708
106
107         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
108         webkit-patch, though the exact meaning of the two options remain different.
109
110         * Scripts/prepare-ChangeLog: Add -g.
111
112 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
113
114         Reviewed by Simon Hausmann.
115
116         [Qt] Fix compilation with Qt in namespace
117         https://bugs.webkit.org/show_bug.cgi?id=51701
118
119         * QtTestBrowser/webview.h:
120
121 2010-12-28  Daniel Bates  <dbates@rim.com>
122
123         Reviewed by Sam Weinig.
124
125         Substitute // MARK: for compiler-specific #pragma mark
126         https://bugs.webkit.org/show_bug.cgi?id=51657
127
128         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
129         substituting  "// MARK:" for "#pragma mark", which provides
130         analogous code-bookmarking functionality under Xcode.
131
132         Also, for consistency, we should substitute "// MARK:" for compiler-
133         specific "#pragma mark" in the source files for the Mac port.
134
135         * DumpRenderTree/AccessibilityTextMarker.cpp:
136         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
137         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
138         * DumpRenderTree/mac/ObjCController.m:
139         * MiniBrowser/mac/AppDelegate.m:
140         * MiniBrowser/mac/BrowserWindowController.m:
141
142 2010-12-28  Xan Lopez  <xlopez@igalia.com>
143
144         Reviewed by Eric Seidel.
145
146         Add --no-build option to run-sunspider
147         https://bugs.webkit.org/show_bug.cgi?id=51658
148
149         * Scripts/run-sunspider: add --no-build flag to skip building
150         phase.
151
152 2010-12-27  Daniel Bates  <dbates@rim.com>
153
154         Rubber-stamped by Martin Robinson.
155
156         Append the directory Tools/DumpRenderTree to the list of directories that
157         do-webcore-rename should search so that it can rename DRT files and
158         source code.
159
160         * Scripts/do-webcore-rename:
161
162 2010-12-27  Eric Seidel  <eric@webkit.org>
163
164         Reviewed by Adam Barth.
165
166         build-webkit should detect missing Java SDK and explain how to install it
167         https://bugs.webkit.org/show_bug.cgi?id=51651
168
169         * Scripts/build-webkit:
170
171 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
172
173         Reviewed by Daniel Bates.
174
175         [GTK] Add support for build-jsc
176         https://bugs.webkit.org/show_bug.cgi?id=51625
177
178         Add GTK+ support to build-jsc now that building the jsc executable as
179         a standalone target is easy.
180
181         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
182         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
183         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
184         and pass it along to buildAutotoolsProject.
185
186 2010-12-27  David Levin  <levin@chromium.org>
187
188         Reviewed by Eric Seidel.
189
190         check-webkit-style check for meaningless variable names in function declarations.
191         https://bugs.webkit.org/show_bug.cgi?id=51523
192
193         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
194         from the new check and whitespace/parens because the syntax is unusual and
195         produced a fair number of positives for these checks.
196         * Scripts/webkitpy/style/checkers/cpp.py:
197         (_convert_to_lower_with_underscores): Used as a canonical form for type names
198         and parameter names when determining if the parameter name is useless.
199         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
200         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
201         format.
202         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
203         text or an acronym of it.
204         (check_function_definition): Checks function definitions for meaningless variable names.
205         (process_line): Added call to check_function_definition.
206         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
207         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
208         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
209         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
210         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
211         because when only checking a snippet, there are a lot of bogus functions.
212         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
213         that I put there previously and just noticed.
214         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
215         check_function_definition and process_line.
216
217 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
218
219         Reviewed by Martin Robinson.
220
221         [GTK] Disable flash plugin in GtkLauncher when using gtk3
222         https://bugs.webkit.org/show_bug.cgi?id=51591
223
224         Flash plugin uses gtk2 that is incompatible with gtk3 making
225         webkit crash when it's built with gtk3.
226
227         * GtkLauncher/main.c:
228         (main):
229
230 2010-12-25  Adam Barth  <abarth@webkit.org>
231
232         Reviewed by Eric Seidel.
233
234         Move ANGLE to Sources/ThirdParty
235         https://bugs.webkit.org/show_bug.cgi?id=51605
236
237         * Scripts/build-webkit:
238           - Point to the new ANGLE location.
239
240 2010-12-26  David Levin  <levin@chromium.org>
241
242         Reviewed by Eric Seidel.
243
244         check-webkit-style should be able to parse function declaration parameters.
245         https://bugs.webkit.org/show_bug.cgi?id=51451
246
247         * Scripts/webkitpy/style/checkers/cpp.py:
248         (Position.__init__): Holds simple position information (row, column).
249         (Parameter.__init__): Holds information about a parameter.
250         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
251         (SingleLineView.convert_column_to_row): Returns the original row given a column.
252         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
253         (find_parameter_name_index): Finds where the parameter name is.
254         (parameter_list): Generates the list of parameters for a function.
255         (_FunctionState.begin): Added information to allow determining the parameters
256         on demand.
257         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
258         (detect_functions): Improve function detection for operator functions and
259         determine where the parameters end and pass that to _FunctionState.begin.
260         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
261         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
262         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
263         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
264         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
265         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
266         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
267         (FunctionDetectionTest.perform_function_detection): Added support for verifying
268         the parameters found.
269         (FunctionDetectionTest.test_function_declaration_detection): Added more function
270         detection test to verify that we catch the operator functions.
271         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
272         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
273         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
274         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
275         test_function_length_check_definition_severity1_for_test.
276
277 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
278
279         Unreviewed WinCE buildfix after r74334.
280
281         * CMakeListsWinCE.txt:
282
283 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
284
285         Unreviewed, rolling out r74632.
286         http://trac.webkit.org/changeset/74632
287         https://bugs.webkit.org/show_bug.cgi?id=51600
288
289         makes test-webkitpy hang forever on GTK (Requested by philn-tp
290         on #webkit).
291
292         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
293         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
294
295 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
296
297         Reviewed by Kenneth Rohde Christiansen.
298
299         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
300         https://bugs.webkit.org/show_bug.cgi?id=43528
301
302         Remove on_resize because ewk_view_fixed_layout_size_set should not be
303         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
304         FrameView, rendering was ignored when _ewk_view_smart_calculate was
305         called.
306
307         * EWebLauncher/main.c:
308         (browserCreate):
309
310 2010-12-24  Eric Seidel  <eric@webkit.org>
311
312         Reviewed by Adam Barth.
313
314         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
315         https://bugs.webkit.org/show_bug.cgi?id=28291
316
317         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
318         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
319         to strings with find in the diff.
320         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
321
322         * Scripts/webkitpy/common/checkout/api.py:
323         * Scripts/webkitpy/common/checkout/diff_parser.py:
324         * Scripts/webkitpy/tool/steps/abstractstep.py:
325         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
326         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
327         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
328         * Scripts/webkitpy/tool/steps/validatereviewer.py:
329
330 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
331
332         Reviewed by Kenneth Russell.
333
334         Modify new-run-webkit-tests to shut up and exit when all the threads
335         are wedged so that test runs complete faster and we don't end up
336         w/ enormous log files.
337
338         https://bugs.webkit.org/show_bug.cgi?id=51572
339
340         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
341         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
342
343 2010-12-24  Eric Seidel  <eric@webkit.org>
344
345         Reviewed by David Levin.
346
347         commit-queue should better explain how it will re-open bugs and follow duplicate chains
348         https://bugs.webkit.org/show_bug.cgi?id=51549
349
350         I've had multiple people ask me about the commit-queue's behavior
351         regarding reporting flaky tests.  I figured it would be best to just
352         have the queue explain itself in the bugs it files.
353
354         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
355         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
356
357 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
358
359         Reviewed by Eric Seidel.
360
361         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
362         https://bugs.webkit.org/show_bug.cgi?id=51467
363
364         * Scripts/webkitpy/style/checker.py:
365         * Scripts/webkitpy/style/checker_unittest.py:
366
367 2010-12-23  Adam Barth  <abarth@webkit.org>
368
369         Rubber-stamped by Eric Seidel.
370
371         Move JavaScriptGlue into Sources
372         https://bugs.webkit.org/show_bug.cgi?id=51583
373
374         These tools refer to JavaScriptGlue and need to be updated to its new
375         location.
376
377         * Scripts/build-webkit:
378         * Scripts/do-file-rename:
379         * Scripts/do-webcore-rename:
380         * Scripts/webkitpy/common/config/build.py:
381         * Scripts/webkitpy/common/config/build_unittest.py:
382
383 2010-12-23  Lucas Forschler  <lforschler@apple.com>
384
385         Reviewed by Eric Seidel.
386
387         Bug 51539 - update iexploder scripts to point to new location
388
389         * Scripts/run-iexploder-tests:
390         * Scripts/update-iexploder-cssproperties:
391
392 2010-12-23  Evan Martin  <evan@chromium.org>
393
394         Reviewed by Ryosuke Niwa.
395
396         [chromium] LayoutTestController warning in float->int conversion
397         https://bugs.webkit.org/show_bug.cgi?id=51553
398
399         Rather than reading an int, converting to a float, then getting a compiler
400         warning on passing the float to something that expects an int, instead
401         just pass around ints.
402
403         No tests, fixes a compiler warning.
404
405         * DumpRenderTree/chromium/LayoutTestController.cpp:
406         (parsePageSizeParameters):
407         (LayoutTestController::pageNumberForElementById):
408         (LayoutTestController::numberOfPages):
409
410 2010-12-23  Lucas Forschler  <lforschler@apple.com>
411
412         Reviewed by Darin Adler.
413
414         Bug 51537 - iexploder needs cleanup
415         
416         * iExploder/htdocs: Removed.
417         * iExploder/htdocs/config.rb: Removed.
418         * iExploder/htdocs/cssproperties.in: Removed.
419         * iExploder/htdocs/cssvalues.in: Removed.
420         * iExploder/htdocs/htmlattrs.in: Removed.
421         * iExploder/htdocs/htmltags.in: Removed.
422         * iExploder/htdocs/htmlvalues.in: Removed.
423         * iExploder/htdocs/iexploder.cgi: Removed.
424         * iExploder/htdocs/iexploder.rb: Removed.
425         * iExploder/htdocs/index.html: Removed.
426         * iExploder/htdocs/webserver.rb: Removed.
427         * iExploder/iexploder-1.7.2/output: Removed.
428         * iExploder/tools: Removed.
429         * iExploder/tools/lasthit.rb: Removed.
430         * iExploder/tools/osx_last_crash.rb: Removed.
431         * iExploder/tools/showtest.rb: Removed.
432
433 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
434
435         Reviewed by Kenneth Rohde Christiansen.
436
437         [EFL] Make 'single' the default backing store in EWebLauncher
438         https://bugs.webkit.org/show_bug.cgi?id=51534
439
440         'single' is the simplest backing store and the one intended to be the
441         default in the test browser. By mistake the tiled backing store was
442         left as default in r72617.
443
444         * EWebLauncher/main.c:
445         (browserCreate): ditto.
446
447 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
448
449         Reviewed by Kenneth Rohde Christiansen.
450
451         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
452         https://bugs.webkit.org/show_bug.cgi?id=51533
453
454         There's no point in concatenating env("HOME") with "blah", so remove
455         option from EWebLauncher.
456
457         * EWebLauncher/main.c:
458         (main): ditto.
459
460 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
461
462         Reviewed by Eric Seidel.
463
464         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
465
466         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
467         I just discovered that we have two additional GC runs per each WebViewHost.
468         Test_shell had no such calls.
469         These gc runs eat 15% of cpu time.
470
471         https://bugs.webkit.org/show_bug.cgi?id=51479
472
473         * DumpRenderTree/chromium/WebViewHost.cpp:
474         (WebViewHost::~WebViewHost):
475
476 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
477
478         Reviewed by Ojan Vafai.
479
480         This change splits out the TestRunner class into its own file.
481         When we fork the code for message passing, we will create a new
482         TestRunner, and this change will allow that to be more modular.
483
484         While we're at it, split out TestInput and ResultSummary into
485         their own files, to reduce the size of run_webkit_tests to
486         something more managable.
487
488         https://bugs.webkit.org/show_bug.cgi?id=51092
489
490         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
491         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
492         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
493         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
494         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
495         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
496         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
497
498  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
499
500         Reviewed by Ojan Vafai.
501
502         nrwt multiprocessing - start over, prepare to fork the code
503  
504         This code cleans up the signatures and implementation of the
505         TestRunner class so we can easily fork it to run either the
506         stable implementation or the new, unstable message-passing
507         implementation. The two variants will have different
508         implementations of the run_tests() method. We will switch
509         between the two based on the setting for the '--worker-model'
510         switch. We rename the two currently valid values to 'old-inline'
511         and 'old-threads'.
512
513         https://bugs.webkit.org/show_bug.cgi?id=51081
514
515         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
516         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
517
518 2010-12-22  Victor Wang  <victorw@chromium.org>
519
520         Reviewed by Darin Fisher.
521
522         [Chromium] Update chromium archive test result url in rebaseline script.
523
524         https://bugs.webkit.org/show_bug.cgi?id=51503
525
526         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
527
528 2010-12-22  Lucas Forschler  <lforschler@apple.com>
529
530         Reviewed by Alice Liu.
531
532         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
533         Verified on Chrome, Safari, and IE.
534         With this change, we will record memory from a parent browser window and all child processes.
535
536         * record-memory-win/main.cpp:
537         (ProcessArgs):
538         (PrintUsage):
539         (getMemoryInfo):
540         (printProcessInfo):
541         (evalProcesses):
542         (UseImage):
543         (QueryContinuously):
544         (ElapsedTime):
545
546 2010-12-22  Lucas Forschler  <lforschler@apple.com>
547
548         Unreviewed rollout r74489, because it was missing changelog.
549
550         * record-memory-win/main.cpp:
551         
552 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
553
554         Adding myself as a reviewer.
555
556         * Scripts/webkitpy/common/config/committers.py:
557
558 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
559
560         Unreviewed.  Adding myself to committers.py.
561
562         * Scripts/webkitpy/common/config/committers.py:
563
564 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
565
566         Reviewed by Kenneth Rohde Christiansen.
567
568         TestNetscapePlugIn should use #if defined
569         https://bugs.webkit.org/show_bug.cgi?id=51471
570
571         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
572         (NP_Initialize):
573         (NPP_New):
574
575 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
576
577         Reviewed by Yury Semikhatsky.
578
579         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
580
581         DevTools window should be closed explicitly because it has custom deinitialization code.
582
583         https://bugs.webkit.org/show_bug.cgi?id=50722
584
585         * DumpRenderTree/chromium/TestShell.cpp:
586         (TestShell::closeRemainingWindows):
587
588 2010-12-22  David Levin  <levin@chromium.org>
589
590         Reviewed by Shinichiro Hamaji.
591
592         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
593         https://bugs.webkit.org/show_bug.cgi?id=51452
594
595         * Scripts/webkitpy/style/checkers/cpp.py:
596         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
597         Using the file extension if possible but falling back to the file contents if we have a header file.
598         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
599         (_FileState.is_c_or_objective_c):
600         (check_using_std): Changed to using _FileState to determine the file type.
601         (check_max_min_macros): Ditto.
602         (check_for_null): Ditto.
603         (check_style): Changed the parameters to various calls since they now need _FileState
604         to determine the file type.
605         (check_language): Added the file_state parameter so it could be passed
606         to check_identifier_name_in_declaration.
607         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
608         this is an Objective C file.
609         (_process_lines): Added information for the _FileState constructor (and moved the
610         call to a place that had the information).
611         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
612         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
613         its functionality.
614         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
615
616 2010-12-21  Andy Estes  <aestes@apple.com>
617
618         Reviewed by Mark Rowe.
619
620         Do not build non-Intel architectures for WebKit2-related projects.
621         https://bugs.webkit.org/show_bug.cgi?id=51440
622
623         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
624         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
625         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
626
627 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
628
629         Reviewed by Darin Fisher.
630
631         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
632         https://bugs.webkit.org/show_bug.cgi?id=51406 
633         
634         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
635         to WebThemeEngineDRTWin and update references everywhere.
636
637         * DumpRenderTree/DumpRenderTree.gypi:
638         * DumpRenderTree/chromium/TestShellWin.cpp:
639         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
640         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
641         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
642         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
643
644 2010-12-21  Anders Carlsson  <andersca@apple.com>
645
646         Reviewed by John Sullivan.
647
648         Clicking missing plug-in text does not show a sheet
649         https://bugs.webkit.org/show_bug.cgi?id=51403
650
651         Update for changes to the WebPageUIClient.
652
653         * MiniBrowser/mac/BrowserWindowController.m:
654         (-[BrowserWindowController awakeFromNib]):
655         * WebKitTestRunner/TestController.cpp:
656         (WTR::createOtherPage):
657         (WTR::TestController::initialize):
658
659 2010-12-21  Eric Seidel  <eric@webkit.org>
660
661         Reviewed by Adam Barth.
662
663         commit-queue will report constant failures as flaky if other tests flake
664         https://bugs.webkit.org/show_bug.cgi?id=51272
665
666         This patch just removes functionality and adds testing.
667         Previously we attempted to report flaky tests when we had
668         two different tests fail in a row.  However, since we stop
669         running the tests at the first failure, our code was wrong in
670         trying to determine flakiness from the incomplete runs.
671
672         Originally I posted an alternate patch:
673         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
674         which fixed our flaky logic in this case, however it was decided
675         that that patch would be too difficult to maintain, so now
676         I'm just removing the broken logic.
677
678         This will dramatically cut-down on our flaky-test false positives
679         at the (small) cost of the queues being unable to report
680         any flakiness if the tree is very flaky.  (With at least one test
681         flaking on every run, we'll never report failures anymore.)  I think
682         this is a tradeoff worth making.
683
684         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
685         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
686
687 2010-12-20  Eric Seidel  <eric@webkit.org>
688
689         Reviewed by Adam Barth.
690
691         commit-queue wrongly rejects patches when it can't update itself
692         https://bugs.webkit.org/show_bug.cgi?id=46636
693
694         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
695         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
696         * Scripts/webkitpy/tool/commands/queues_unittest.py:
697
698 2010-12-20  Adam Barth  <abarth@webkit.org>
699
700         Move web sites to Websites directory
701         https://bugs.webkit.org/show_bug.cgi?id=51323
702
703         Update references to BugsSite to point to the new location.
704
705         This patch was never officially reviewed (because it was too large to
706         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
707         Rowe gave me the green light.
708
709         * Scripts/old-run-webkit-tests:
710         * Scripts/webkitpy/common/config/build.py:
711         * Scripts/webkitpy/common/config/build_unittest.py:
712         * Scripts/webkitpy/common/prettypatch.py:
713         * Scripts/webkitpy/layout_tests/port/base.py:
714         * Scripts/webkitpy/style/main.py:
715
716 2010-12-20  Adrienne Walker  <enne@google.com>
717
718         Unreviewed. Adding myself to the list of committers.
719
720         * webkitpy/common/config/committers.py:
721
722 2010-12-20  Mark Rowe  <mrowe@apple.com>
723
724         Reviewed by Dan Bernstein.
725
726         <rdar://problem/8757601> Don't install header files in to the Resources directory.
727
728         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
729         Resources directory.
730
731 2010-12-20  Eric Seidel  <eric@webkit.org>
732
733         Reviewed by Adam Barth.
734
735         commit-queue should include bot id when attaching failure diffs
736         https://bugs.webkit.org/show_bug.cgi?id=51280
737
738         This is a tiny change to include the bot id in the name of the attachment.
739         Most of this diff is just changing the unit test expectations
740         now that I hid the comment printing when the comment is None.
741
742         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
743         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
744         * Scripts/webkitpy/tool/commands/upload_unittest.py:
745         * Scripts/webkitpy/tool/mocktool.py:
746
747 2010-12-20  Jeff Miller  <jeffm@apple.com>
748
749         Reviewed by Dan Bernstein.
750
751         Tools/vcbin/midl.exe needs to be rebuilt
752         https://bugs.webkit.org/show_bug.cgi?id=51347
753
754         * vcbin/midl.exe: Rebuilt.
755
756 2010-12-20  David Levin  <levin@chromium.org>
757
758         Reviewed by Ariya Hidayat.
759
760         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
761         https://bugs.webkit.org/show_bug.cgi?id=51343
762
763         Follow up from the WebKitTools -> Tools rename.
764
765         * Scripts/webkit-tools-completion.sh:
766
767 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
768
769         Reviewed by James Robinson.
770
771         new-run-webkit-tests ignores trailing EOL differences in text tests
772         https://bugs.webkit.org/show_bug.cgi?id=36983
773
774         Changed the handling of new-line characters within new-run-webkit-tests
775         to match old-run-webkit-tests.  Differences in leading and trailing empty
776         lines in text expectation files are no longer ignored.
777
778         * Scripts/webkitpy/layout_tests/port/base.py:
779         * Scripts/webkitpy/layout_tests/port/test.py:
780         Added unit tests.  Removed old duplicate unit test entries.
781         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
782
783 2010-12-20  David Levin  <levin@chromium.org>
784
785         Reviewed by Shinichiro Hamaji.
786
787         check-webkit-style should detect function declarations (and trivial functions).
788         https://bugs.webkit.org/show_bug.cgi?id=51303
789
790         * Scripts/webkitpy/style/checkers/cpp.py:
791         (_FunctionState.begin): Add is_declaration and changed the line count
792         start to begin at -1 (which will keep the results consistent, since
793         the starting line number passed in is one less in this change).
794         (detect_functions): changed function detection to now catch trivial
795         functions and declarations.
796         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
797         of the function as this may look at return values (when processing
798         a declaration).
799         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
800         (FunctionDetectionTest.perform_function_detection): Basic mechanics
801         of testing the function detection.
802         (FunctionDetectionTest.test_basic_function_detection): Test a simple
803         function.
804         (FunctionDetectionTest.test_function_declaration_detection): Test a
805         declaration.
806         (FunctionDetectionTest.test_non_functions): A test case for a case
807         that caused the code to fail due to the { being in quotes.
808         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
809         cases to help catch false alarms for return values.
810         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
811         we don't get false alarms for member variables either.
812
813 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
814
815         Reviewed by Antonio Gomes.
816
817         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
818         https://bugs.webkit.org/show_bug.cgi?id=51319
819
820         * CMakeListsEfl.txt:
821
822 2010-12-18  Adam Barth  <abarth@webkit.org>
823
824         Reviewed by Sam Weinig.
825
826         Move WebKitExamplePlugins to Examples
827         https://bugs.webkit.org/show_bug.cgi?id=51291
828
829         * Scripts/webkitpy/common/config/build.py:
830
831 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
832
833         Unreviewed Qt buildfix after r74301.
834
835         Rename WebKitTools to Tools
836         https://bugs.webkit.org/show_bug.cgi?id=49861
837
838         * MiniBrowser/DerivedSources.pro:
839         * MiniBrowser/qt/MiniBrowser.pro:
840
841 2010-12-17  Dan Bernstein  <mitz@apple.com>
842
843         Reviewed by Simon Fraser.
844
845         Rename WebKitTools to Tools
846         https://bugs.webkit.org/show_bug.cgi?id=49861
847
848         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
849         * CodeCoverage/README:
850         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
851         (WebCore::DumpRenderTree::initializeFonts):
852         * EWSTools/start-commit-queue.sh:
853         * EWSTools/start-queue.sh:
854         * GNUmakefile.am:
855         * MIDLWrapper/MIDLWrapper.cpp:
856         (wmain):
857         * MiniBrowser/qt/MiniBrowser.pro:
858         * Scripts/build-api-tests:
859         * Scripts/build-dumprendertree:
860         * Scripts/build-webkit:
861         * Scripts/build-webkittestrunner:
862         * Scripts/generate-coverage-data:
863         * Scripts/old-run-webkit-tests:
864         * Scripts/run-api-tests:
865         * Scripts/run-iexploder-tests:
866         * Scripts/run-javascriptcore-tests:
867         * Scripts/run-mangleme-tests:
868         * Scripts/run-sunspider:
869         * Scripts/run-webkit-websocketserver:
870         * Scripts/sunspider-compare-results:
871         * Scripts/test-webkitperl:
872         * Scripts/test-webkitpy:
873         * Scripts/update-iexploder-cssproperties:
874         * Scripts/update-webkit:
875         * Scripts/update-webkit-localizable-strings:
876         * Scripts/webkitdirs.pm:
877         * Scripts/webkitpy/common/checkout/scm.py:
878         * Scripts/webkitpy/common/checkout/scm_unittest.py:
879         * Scripts/webkitpy/common/config/committervalidator.py:
880         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
881         * Scripts/webkitpy/common/config/ports.py:
882         * Scripts/webkitpy/common/config/ports_unittest.py:
883         * Scripts/webkitpy/common/system/logutils_unittest.py:
884         * Scripts/webkitpy/common/system/ospath_unittest.py:
885         * Scripts/webkitpy/layout_tests/port/chromium.py:
886         * Scripts/webkitpy/layout_tests/port/config.py:
887         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
888         * Scripts/webkitpy/layout_tests/port/http_server.py:
889         * Scripts/webkitpy/layout_tests/port/test.py:
890         * Scripts/webkitpy/style/checker.py:
891         * Scripts/webkitpy/style/checker_unittest.py:
892         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
893         * Scripts/webkitpy/tool/commands/queues_unittest.py:
894         * Scripts/webkitpy/tool/steps/steps_unittest.py:
895         * WebKitTestRunner/DerivedSources.pro:
896         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
897         (WTR::activateFonts):
898         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
899         * wx/build/build_utils.py:
900
901 2010-12-16  Antonio Gomes  <agomes@rim.com>
902
903         Reviewed by Martin Robinson.
904
905         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
906         https://bugs.webkit.org/show_bug.cgi?id=51163
907
908         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
909         GTK+'s DRT should also reset to UNIX after each test execution.
910
911         * DumpRenderTree/gtk/DumpRenderTree.cpp:
912         (resetDefaultsToConsistentValues):
913
914 2010-12-17  David Levin  <levin@chromium.org>
915
916         Reviewed by Eric Seidel.
917
918         check-webkit-style should understand WTF #include guards
919         https://bugs.webkit.org/show_bug.cgi?id=44911
920
921         * Scripts/webkitpy/style/checkers/cpp.py:
922         (get_header_guard_cpp_variable): modify to suggest the WTF style
923         of header guard when appropriate.
924         (check_for_header_guard): handle multiple return values from
925         get_header_guard_cpp_variable
926         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
927         (CppStyleTest.test_build_header_guard): Added tests for the WTF
928         header style.
929
930 2010-12-16  David Levin  <levin@chromium.org>
931
932         Reviewed by Eric Seidel.
933
934         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
935         https://bugs.webkit.org/show_bug.cgi?id=51210
936
937         The error only shows up when using python 2.6 or later.
938
939         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
940         the decprecated field error,message with something equivalent.
941
942 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
943
944         Reviewed by Eric Seidel.
945
946         Add --exit-after-n-failures/crashes to NRWT
947         https://bugs.webkit.org/show_bug.cgi?id=51160
948         
949         Abort test run (in a similar way to how control-C is handled) when
950         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
951         that number of unexpected failures/crashes/timeouts.
952
953         * Scripts/webkitpy/layout_tests/port/test.py:
954         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
955         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
956
957 2010-12-16  David Levin  <levin@chromium.org>
958
959         Reviewed by Shinichiro Hamaji.
960
961         check-webkit-style unit tests has some duplicate boilerplate code.
962         https://bugs.webkit.org/show_bug.cgi?id=49519
963
964         * Scripts/webkitpy/style/checkers/cpp.py:
965         (update_include_state): Replaced the "io" parameter with the global
966         configuration _unit_test_config. This allowed not calling into
967         functions at a low level and also not plumbing through the injection
968         information through many levels of code.
969         (check_for_include_what_you_use): Ditto.
970         (process_file_data): Added the ability to set up the unit test config
971         to allow for injection.
972         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
973         (ErrorCollector.__init__): Added support for having a filter for errors.
974         (ErrorCollector.__call__): Ditto.
975         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
976         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
977         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
978         functions in the cpp.py with generic processing and a filter that
979         indicates what errors should be kept.
980         (CppStyleTestBase.perform_multi_line_lint): Ditto.
981         (CppStyleTestBase.perform_language_rules_check): Ditto.
982         (CppStyleTestBase.perform_function_lengths_check): Ditto.
983         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
984         (CppStyleTestBase.perform_include_what_you_use): Ditto.
985         (CppStyleTest.test_multi_line_comments): Added another
986         error message which applies to the test case.
987         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
988         to not have config.h, since it is processed as a header file.
989         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
990         style and indentation in checked code.
991         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
992         Fixed line number.
993         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
994         Ditto.
995
996 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
997
998         Unreviewed, rolling out r74136.
999         http://trac.webkit.org/changeset/74136
1000         https://bugs.webkit.org/show_bug.cgi?id=51135
1001
1002         r74136 breaks chromium canary bots because some tests are not
1003         rebaselined correctly to resolve EOL differences (Requested by
1004         jianli on #webkit).
1005
1006         * Scripts/webkitpy/layout_tests/port/base.py:
1007         * Scripts/webkitpy/layout_tests/port/test.py:
1008         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1009
1010 2010-12-15  Adam Roben  <aroben@apple.com>
1011
1012         Teach check-webkit-style to check .vcproj and .vsprops files for XML
1013         syntax errors
1014
1015         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
1016         XML syntax errors in .vcproj/.vsprops files
1017
1018         Reviewed by Dave Levin.
1019
1020         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
1021         that should be treated as XML and that should be allowed to contain
1022         carriage returns. (These lists happen to be identical currently.)
1023         (FileType): Added a new XML type.
1024         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
1025         Just does a simple file extension check.
1026         (CheckerDispatcher._file_type): Added a case for XML files.
1027         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
1028         files (surprise!).
1029         (StyleProcessor.process): Ask the dispatcher whether we should pass the
1030         lines through the carriage checker.
1031
1032         * Scripts/webkitpy/style/checker_unittest.py:
1033         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
1034         Added. Checks a few file names to see if carriage returns are allowed
1035         or not.
1036         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
1037         other assert_checker_* functions.
1038         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
1039         test_*_paths functions.
1040         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
1041         test_*_paths functions.
1042         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
1043         file from this test case, as vcproj files now have a type.
1044         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
1045         Added. Similar to the other should_* functions.
1046         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
1047         Added. Checks that carriage returns aren't checked for or stripped for
1048         allowed files.
1049
1050         * Scripts/webkitpy/style/checkers/xml.py: Added.
1051         (XMLChecker.__init__): Simple init method.
1052         (XMLChecker.check): Pass each line through the expat parser, and record
1053         a style error for any errors thrown by the parser.
1054
1055         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
1056         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
1057         produce a style error.
1058         (XMLCheckerTest.assert_error): Checks that the given XML produces an
1059         error of the given category on the given line.
1060         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
1061         checking that the XMLChecker constructor works properly.
1062         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
1063         cause a style error (see, e.g., r73887).
1064         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
1065         cause a style error (see, e.g., r73773).
1066         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
1067         properly.
1068         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
1069         tags cause a style error (see, e.g., r72795).
1070         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
1071         style error.
1072
1073 2010-12-15  Lucas Forschler  <lforschler@apple.com>
1074
1075         Reviewed by Stephanie Lewis.
1076
1077         https://bugs.webkit.org/show_bug.cgi?id=51117
1078         Add a new leopard test bot
1079         really really commit to trunk this time.
1080
1081         * BuildSlaveSupport/build.webkit.org-config/config.json:
1082
1083 2010-12-15  Sam Weinig  <sam@webkit.org>
1084
1085         Reviewed by Anders Carlsson.
1086
1087         WebKit2: Can't add files to an <input type=file>
1088         https://bugs.webkit.org/show_bug.cgi?id=51087
1089
1090         * MiniBrowser/mac/BrowserWindowController.m:
1091         (runOpenPanel):
1092         (-[BrowserWindowController awakeFromNib]):
1093         Add simple implementation of runOpenPanel callback.
1094
1095         * MiniBrowser/win/BrowserView.cpp:
1096         (BrowserView::create):
1097         * WebKitTestRunner/TestController.cpp:
1098         (WTR::createOtherPage):
1099         (WTR::TestController::initialize):
1100         Stub out runOpenPanel callback. 
1101
1102 2010-12-14  Eric Seidel  <eric@webkit.org>
1103
1104         Reviewed by Adam Barth.
1105
1106         commit-queue should upload failure diffs when tests flake
1107         https://bugs.webkit.org/show_bug.cgi?id=51051
1108
1109         To make this testable I needed to pipe FileSystem down onto tool.
1110         We've wanted it there for a long time anyway.
1111
1112         This patch is kinda a big hack.  But we don't have a nice
1113         way to read results.html files.  I think this will need further
1114         revision before this code actually feels clean.
1115
1116         As part of testing this change, I had to make MockBugzilla.create_bug
1117         actually return an id (like it should) which required updating
1118         a few other unit test results (for the better).
1119
1120         The results_matching_keys change in layouttestresults/rebasline
1121         was an alternate path which I decided not to use in the end, but
1122         I left the change as it seemed an improvement.
1123
1124         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1125         * Scripts/webkitpy/common/net/layouttestresults.py:
1126         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1127         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1128         * Scripts/webkitpy/tool/commands/queues.py:
1129         * Scripts/webkitpy/tool/commands/rebaseline.py:
1130         * Scripts/webkitpy/tool/main.py:
1131         * Scripts/webkitpy/tool/mocktool.py:
1132
1133 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
1134
1135         Reviewed by James Robinson.
1136
1137         new-run-webkit-tests ignores trailing EOL differences in text tests
1138         https://bugs.webkit.org/show_bug.cgi?id=36983
1139
1140         Changed the handling of new-line characters within new-run-webkit-tests
1141         to match old-run-webkit-tests.  Differences in leading and trailing empty
1142         lines in text expectation files are no longer ignored.
1143
1144         * Scripts/webkitpy/layout_tests/port/base.py:
1145         * Scripts/webkitpy/layout_tests/port/test.py:
1146         Added unit tests.  Removed old duplicate unit test entries.
1147         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1148
1149 2010-12-15  Ojan Vafai  <ojan@chromium.org>
1150
1151         Reviewed by Adam Barth.
1152
1153         make status-bubble white-space:nowrap so we can measure it's width without wrapping
1154         https://bugs.webkit.org/show_bug.cgi?id=51149
1155
1156         * QueueStatusServer/templates/statusbubble.html:
1157
1158 2010-12-15  Ojan Vafai  <ojan@chromium.org>
1159
1160         Reviewed by Adam Barth.
1161
1162         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
1163         https://bugs.webkit.org/show_bug.cgi?id=51125
1164
1165         * QueueStatusServer/templates/statusbubble.html:
1166
1167 2010-12-15  Darin Adler  <darin@apple.com>
1168
1169         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
1170
1171 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
1172
1173         Unreviewed, rolling out r74117.
1174         http://trac.webkit.org/changeset/74117
1175         https://bugs.webkit.org/show_bug.cgi?id=51113
1176
1177         This broke the GTK1 build. (Requested by mrobinson on
1178         #webkit).
1179
1180         * Scripts/webkitdirs.pm:
1181
1182 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
1183
1184         Reviewed by Martin Robinson.
1185
1186         Change generate-forwarding-headers.pl for GTK port usage 
1187         (https://bugs.webkit.org/show_bug.cgi?id=37369)
1188
1189         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
1190
1191 2010-12-14  Kent Tamura  <tkent@chromium.org>
1192
1193         Reviewed by Jian Li.
1194
1195         [DRT/Chromium] Remove another unnecessary error message
1196         https://bugs.webkit.org/show_bug.cgi?id=51083
1197
1198         * DumpRenderTree/chromium/WebViewHost.cpp:
1199         (WebViewHost::didInvalidateRect):
1200
1201 2010-12-14  Lucas Forschler  <lforschler@apple.com>
1202
1203         Reviewed by Stephanie Lewis.
1204
1205         Add a new Leopard Debug Test WK2 Bot
1206
1207         * BuildSlaveSupport/build.webkit.org-config/config.json:
1208
1209 2010-12-14  Ojan Vafai  <ojan@chromium.org>
1210
1211         Fix python unittests after http://trac.webkit.org/changeset/74070.
1212
1213         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1214
1215 2010-12-14  Kent Tamura  <tkent@chromium.org>
1216
1217         Reviewed by Jian Li.
1218
1219         [DRT/Chromium] Remove a unnecessary error message
1220         https://bugs.webkit.org/show_bug.cgi?id=51069
1221
1222         * DumpRenderTree/chromium/WebViewHost.cpp:
1223         (WebViewHost::paintInvalidatedRegion):
1224
1225 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
1226
1227         Reviewed by Ojan Vafai.
1228
1229         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
1230         https://bugs.webkit.org/show_bug.cgi?id=48926
1231
1232         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1233         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
1234
1235 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1236
1237         Reviewed by Eric Seidel.
1238
1239         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
1240         https://bugs.webkit.org/show_bug.cgi?id=50231
1241
1242         Guard CONFIG+=link_pkgconfig with !symbian.
1243
1244         * DumpRenderTree/qt/DumpRenderTree.pro:
1245         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1246         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1247
1248 2010-12-14  Philippe Normand  <pnormand@igalia.com>
1249
1250         Reviewed by Ojan Vafai.
1251
1252         [new-run-webkit-tests] expectations parsing is slow
1253         https://bugs.webkit.org/show_bug.cgi?id=50635
1254
1255         Avoid expensive iteration of all the tests when checking if a test
1256         file is to be skipped or not.
1257
1258         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1259         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1260         * Scripts/webkitpy/layout_tests/port/test.py:
1261
1262 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
1263
1264         Reviewed by Xan Lopez.
1265
1266         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
1267         https://bugs.webkit.org/show_bug.cgi?id=27048
1268
1269         Add support in DRT for checking whether an accessibility UI
1270         element is focusable and/or focused. Implemented for GTK.
1271
1272         * DumpRenderTree/AccessibilityUIElement.cpp:
1273         (getIsFocusedCallback): New.
1274         (getIsFocusableCallback): New.
1275         (AccessibilityUIElement::getJSClass): Add the new available
1276         callbacks for isFocused and isFocusable.
1277         * DumpRenderTree/AccessibilityUIElement.h:
1278         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1279         (AccessibilityUIElement::isFocused): New, implemented by checking
1280         whether the related AtkState value is in the object's state set.
1281         (AccessibilityUIElement::isFocusable): Ditto.
1282         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1283         (AccessibilityUIElement::isFocused): New, dummy implementation.
1284         (AccessibilityUIElement::isFocusable): Ditto.
1285         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1286         (AccessibilityUIElement::isFocused): Ditto.
1287         (AccessibilityUIElement::isFocusable): Ditto.
1288
1289 2010-12-14  Eric Seidel  <eric@webkit.org>
1290
1291         Reviewed by Ojan Vafai.
1292
1293         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
1294         https://bugs.webkit.org/show_bug.cgi?id=50715
1295
1296         This patch makes webkit-patch print the following:
1297
1298         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
1299         Install a 64-bit git for better performance, see:
1300         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
1301
1302         I wrote this mostly because I have approximately 8 machines that I use
1303         and making sure each one is using a good Git install seemed folly.
1304         webkit-patch makes a lot of git calls, so using a fast git can shave
1305         several seconds in every invocation.  See the webkit-dev thread for more info.
1306
1307         This message will print twice during 'webkit-patch upload',
1308         once from webkit-patch and once from check-webkit-style.
1309
1310         Unfortunately there is no good way to test this due to how machine-dependent
1311         the code is.  I considered writing a test for the log message, but it seemed not worth it.
1312
1313         * Scripts/webkitpy/common/checkout/scm.py:
1314
1315 2010-12-13  Eric Seidel  <eric@webkit.org>
1316
1317         Reviewed by Adam Barth.
1318
1319         FlakyTestReporter doesn't understand bots running from multiple email addresses
1320         https://bugs.webkit.org/show_bug.cgi?id=50960
1321
1322         This explains at least one of the dupes of:
1323         https://bugs.webkit.org/show_bug.cgi?id=50863
1324         that we saw filed by the commit-queue this morning.
1325         I think the other one was explained by my previous fix to result counting code.
1326
1327         Since this is really hard to test with a unit test, instead I
1328         create a new (possibly useful in the future) command
1329         which given a layout test path will return you
1330         the one bug which our tools would assume it the flaky test bug.
1331         If some other script wants to use bug-for-test we'll
1332         need to extend it with some options like --create-if-missing or similar.
1333
1334         * Scripts/webkitpy/common/net/bugzilla/bug.py:
1335         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1336         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1337         * Scripts/webkitpy/tool/commands/__init__.py:
1338         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
1339
1340 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
1341
1342         Reviewed by James Robinson.
1343
1344         Add option to build-webkit to not build WebKit2
1345         https://bugs.webkit.org/show_bug.cgi?id=50988
1346         
1347         Add support for a --no-webkit2 option to build-webkit. It seems to save
1348         ~1 minute from clean builds and ~10 seconds from no-op builds.
1349
1350         * Scripts/build-webkit:
1351
1352 2010-12-13  Lucas Forschler  <lforschler@apple.com>
1353
1354         Reviewed by Dave Kilzer.
1355
1356         Update iexploder from 1.3.2 to 1.7.2
1357         Move 1.3.2 into its own subdir
1358         Add 1.7.2 into its own subdir
1359         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
1360
1361         * Scripts/run-iexploder-tests:
1362         * Scripts/update-iexploder-cssproperties:
1363         * iExploder/CHANGELOG.txt: Removed.
1364         * iExploder/LICENSE.txt: Removed.
1365         * iExploder/README.txt: Removed.
1366         * iExploder/htdocs: Removed.
1367         * iExploder/iexploder-1.3.2: Added.
1368         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
1369         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
1370         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
1371         * iExploder/iexploder-1.3.2/htdocs: Added.
1372         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
1373         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
1374         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
1375         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
1376         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
1377         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
1378         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
1379         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
1380         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
1381         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
1382         * iExploder/iexploder-1.3.2/tools: Added.
1383         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
1384         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
1385         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
1386         * iExploder/iexploder-1.7.2: Added.
1387         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
1388         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
1389         * iExploder/iexploder-1.7.2/README.txt: Added.
1390         * iExploder/iexploder-1.7.2/output: Added.
1391         * iExploder/iexploder-1.7.2/src: Added.
1392         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
1393         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
1394         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
1395         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
1396         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
1397         * iExploder/iexploder-1.7.2/src/css-properties: Added.
1398         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
1399         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
1400         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
1401         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
1402         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
1403         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
1404         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
1405         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
1406         * iExploder/iexploder-1.7.2/src/css-values: Added.
1407         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
1408         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
1409         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
1410         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
1411         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
1412         * iExploder/iexploder-1.7.2/src/headers: Added.
1413         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
1414         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
1415         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
1416         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
1417         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
1418         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
1419         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
1420         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
1421         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
1422         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
1423         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
1424         * iExploder/iexploder-1.7.2/src/html-tags: Added.
1425         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
1426         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
1427         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
1428         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
1429         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
1430         * iExploder/iexploder-1.7.2/src/html-values: Added.
1431         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
1432         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
1433         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
1434         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
1435         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
1436         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
1437         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
1438         * iExploder/iexploder-1.7.2/src/index.html: Added.
1439         * iExploder/iexploder-1.7.2/src/media: Added.
1440         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
1441         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
1442         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
1443         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
1444         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
1445         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
1446         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
1447         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
1448         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
1449         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
1450         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
1451         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
1452         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
1453         * iExploder/iexploder-1.7.2/src/mime-types: Added.
1454         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
1455         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
1456         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
1457         * iExploder/iexploder-1.7.2/src/protocols: Added.
1458         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
1459         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
1460         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
1461         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
1462         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
1463         * iExploder/iexploder-1.7.2/src/version.rb: Added.
1464         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
1465         * iExploder/iexploder-1.7.2/testcases: Added.
1466         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
1467         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
1468         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
1469         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
1470         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
1471         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
1472         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
1473         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
1474         * iExploder/iexploder-1.7.2/tools: Added.
1475         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
1476         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
1477         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
1478         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
1479         * iExploder/tools: Removed.
1480
1481 2010-12-13  Sam Weinig  <sam@webkit.org>
1482
1483         Reviewed by Anders Carlsson.
1484
1485         Remove associated page concept from WKView constructor
1486         https://bugs.webkit.org/show_bug.cgi?id=50983
1487
1488         Step 1: Remove associate page constructors from WKView and make
1489         all views use the shared namespace for the context.
1490
1491         * TestWebKitAPI/PlatformWebView.h:
1492         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1493         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
1494         * WebKitTestRunner/PlatformWebView.h:
1495         * WebKitTestRunner/TestController.cpp:
1496         (WTR::createOtherPage):
1497         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1498         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1499         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1500
1501 2010-12-13  Sam Weinig  <sam@webkit.org>
1502
1503         Reviewed by Anders Carlsson.
1504
1505         Change the WebKit2 public API so there is no explicit WKPageNamespace object
1506         https://bugs.webkit.org/show_bug.cgi?id=50898
1507
1508         * MiniBrowser/mac/AppDelegate.h:
1509         * MiniBrowser/mac/AppDelegate.m:
1510         * MiniBrowser/mac/BrowserWindowController.h:
1511         * MiniBrowser/mac/BrowserWindowController.m:
1512         * MiniBrowser/win/BrowserView.cpp:
1513         Convert MiniBrowser to not use PageNamespaces.
1514
1515         * TestWebKitAPI/PlatformWebView.h:
1516         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
1517         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
1518         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
1519         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
1520         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
1521         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
1522         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
1523         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1524         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1525         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
1526         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1527         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
1528         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
1529         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1530         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
1531         Convert TestWebKitAPI to not use PageNamespaces.
1532
1533         * WebKitTestRunner/PlatformWebView.h:
1534         * WebKitTestRunner/TestController.cpp:
1535         * WebKitTestRunner/TestController.h:
1536         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1537         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1538         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1539         Convert WebKitTestRunner to not use PageNamespaces.
1540
1541 2010-12-13  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1542
1543         Reviewed by Eric Seidel.
1544
1545         webkit-patch rollout should be able to do multi-revision rollouts
1546         https://bugs.webkit.org/show_bug.cgi?id=33336
1547
1548         Make it possible to pass more than one revision to webkit-patch.
1549
1550         * Scripts/webkitpy/common/checkout/api.py:
1551         * Scripts/webkitpy/common/checkout/changelog.py:
1552         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1553         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
1554         * Scripts/webkitpy/tool/commands/download.py:
1555         * Scripts/webkitpy/tool/commands/download_unittest.py:
1556         * Scripts/webkitpy/tool/mocktool.py:
1557         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1558         * Scripts/webkitpy/tool/steps/revertrevision.py:
1559
1560 2010-12-13  Eric Seidel  <eric@webkit.org>
1561
1562         Unreviewed.
1563
1564         Teach webkit-patch how to search bugzilla
1565         https://bugs.webkit.org/show_bug.cgi?id=50500
1566
1567         webkit-patch bug-search fails when there is only one result.
1568         Turns out we needed a bit more logic in our result count parsing code.
1569
1570         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1571         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1572
1573 2010-12-13  Antti Koivisto  <antti@apple.com>
1574
1575         Reviewed by Alexey Proskuryakov.
1576
1577         Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
1578         https://bugs.webkit.org/show_bug.cgi?id=50758
1579
1580         * DumpRenderTree/LayoutTestController.cpp:
1581         (setSerializeHTTPLoadsCallback):
1582         (LayoutTestController::staticFunctions):
1583         * DumpRenderTree/LayoutTestController.h:
1584         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1585         (LayoutTestController::setSerializeHTTPLoads):
1586         * DumpRenderTree/mac/DumpRenderTree.mm:
1587         (resetDefaultsToConsistentValues):
1588         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1589         (LayoutTestController::setSerializeHTTPLoads):
1590         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1591         (LayoutTestController::setSerializeHTTPLoads):
1592
1593 2010-12-13  Dimitri Glazkov  <dglazkov@chromium.org>
1594
1595         Reviewed by Ojan Vafai.
1596
1597         Remove "use-drt" option from test step command line, since the option was removed in r73748.
1598         https://bugs.webkit.org/show_bug.cgi?id=50936
1599
1600         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed the option.
1601
1602 2010-12-13  Patrick Gansterer  <paroga@webkit.org>
1603
1604         Reviewed by Csaba Osztrogonác.
1605
1606         Add revlink to BuildBot status
1607         https://bugs.webkit.org/show_bug.cgi?id=50914
1608
1609         This adds a hyperlink to trac changeset on the revision numbers. 
1610
1611         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1612
1613 2010-12-13  Andras Becsi  <abecsi@webkit.org>
1614
1615         Reviewed by Csaba Osztrogonác.
1616
1617         [Qt][WK2] Fix build if WebKitTools are not available
1618         https://bugs.webkit.org/show_bug.cgi?id=50242
1619
1620         * MiniBrowser/qt/MiniBrowser.pro: Correct the comment.
1621         * Scripts/webkitdirs.pm: Added WebKitTools/MiniBrowser to $subdirs.
1622         * MiniBrowser/DerivedSources.pro: Added.
1623
1624 2010-12-13  Eric Seidel  <eric@webkit.org>
1625
1626         Reviewed by Adam Barth.
1627
1628         EWS Queues should remove orpahned pyc files before starting
1629         https://bugs.webkit.org/show_bug.cgi?id=50904
1630
1631         A previous check added a platform.py which caused
1632         EWS bots on some platforms to hit an import exception.
1633         The platform.py file was removed in a subsequent commit, but
1634         the EWS bots in question stayed stuck.  This change will
1635         fix those bots once restarted (and prevent this in the future).
1636
1637         I also went ahead and unified start-queue and start-commit-queue
1638         since they were nearly identical.  I also added bot_id support
1639         to both force all EWSes to have bot ids as well as get rid of the one
1640         remaining reason why I had my own copies of these scripts.
1641         Hopefully this will be enough to get all the other bot admins
1642         (ahem, Adam, ahem) to move to using these checked in copies as well.
1643
1644         * EWSTools/start-commit-queue.sh: Removed.
1645         * EWSTools/start-queue.sh:
1646
1647 2010-10-28  MORITA Hajime  <morrita@google.com>
1648
1649         Reviewed by Ojan Vafai.
1650
1651         spellcheck does not check pasted text
1652         https://bugs.webkit.org/show_bug.cgi?id=40092
1653
1654         Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
1655         to control the setting.
1656
1657         * DumpRenderTree/LayoutTestController.cpp:
1658         (setAsynchronousSpellCheckingEnabledCallback):
1659         (LayoutTestController::staticFunctions):
1660         * DumpRenderTree/LayoutTestController.h:
1661         * DumpRenderTree/chromium/LayoutTestController.h:
1662         * DumpRenderTree/chromium/LayoutTestController.cpp:
1663         (LayoutTestController::LayoutTestController):
1664         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1665         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1666         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1667         * DumpRenderTree/mac/DumpRenderTree.mm:
1668         (resetDefaultsToConsistentValues):
1669         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1670         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1671         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1672         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1673         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1674         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1675         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1676         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1677         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1678
1679 2010-12-12  Sam Weinig  <sam@webkit.org>
1680
1681         Reviewed by Anders Carlsson.
1682
1683         Fix failing API test. It turns out that a pop-state event
1684         is sent before every fragment navigation, so we have to test
1685         for it in addition in PageLoadDidChangeLocationWithinPageForFrame.
1686
1687         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1688         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1689
1690 2010-12-12  Alejandro G. Castro  <alex@igalia.com>
1691
1692         Reviewed by Eric Seidel.
1693
1694         [GTK] Add new-run-webkit-tests support to gtk
1695         https://bugs.webkit.org/show_bug.cgi?id=50681
1696
1697         Adding the basic support to run the new-run-webkit-tests.
1698
1699         * Scripts/webkitpy/layout_tests/port/gtk.py:
1700
1701 2010-10-11  Diego Gonzalez  <diegohcg@webkit.org>
1702
1703         Reviewed by Kenneth Rohde Christiansen.
1704
1705         [Qt] Mock DeviceOrientation client for DRT
1706         https://bugs.webkit.org/show_bug.cgi?id=47490
1707
1708         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1709         (WebCore::DumpRenderTree::DumpRenderTree):
1710         (WebCore::DumpRenderTree::~DumpRenderTree):
1711         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1712         (LayoutTestController::setMockDeviceOrientation):
1713
1714 2010-12-11  Philippe Normand  <pnormand@igalia.com>
1715
1716         Reviewed by Gustavo Noronha Silva.
1717
1718         [GTK] launcher: disable the Mozilla-style fullscreen API
1719         https://bugs.webkit.org/show_bug.cgi?id=50874
1720
1721         Disabling the fullscreen API until its implementation for GTK is
1722         mature enough. The webview setting for it is already FALSE by
1723         default.
1724
1725         * GtkLauncher/main.c:
1726         (createWindow):
1727
1728 2010-12-10  Eric Seidel  <eric@webkit.org>
1729
1730         Reviewed by Adam Barth.
1731
1732         commit-queue flaky test messages show cryptic version information for mac os x
1733         https://bugs.webkit.org/show_bug.cgi?id=50864
1734
1735         Turns out platform.platform() returns kernel version information
1736         which isn't helpful, and just plain confusing on Mac
1737         (OS X 10.6.5 uses Darwin Kernel 10.5.0).
1738
1739         So I've updated PlatformInfo.display_name() to special case
1740         mac.  I also found a bad use of sys.platform in the process
1741         and fixed that.  (sys.platform always returns 'darwin' on mac).
1742
1743         * Scripts/webkitpy/common/system/platforminfo.py:
1744         * Scripts/webkitpy/common/system/user.py:
1745         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1746         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1747         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1748
1749 2010-12-10  Eric Seidel  <eric@webkit.org>
1750
1751         Unreviewed.
1752
1753         Exception seen while reporting flaky test with commit-queue.
1754         Just a missing include.
1755
1756         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1757         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1758
1759 2010-12-10  Kinuko Yasuda  <kinuko@chromium.org>
1760
1761         Reviewed by Eric Seidel.
1762
1763         [Chromium] Remove old JSONResultsGenerator script that existed for backward-compatibility
1764         https://bugs.webkit.org/show_bug.cgi?id=50796
1765
1766         Also updating the test code to use JSONResultsGeneratorBase and
1767         to improve test coverage for incremental cases.
1768
1769         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1770         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1771
1772 2010-12-10  Joseph Pecoraro  <joepeck@webkit.org>
1773
1774         Reviewed by Darin Adler.
1775
1776         prepare-ChangeLog --help doesn't mention --bug shorthand -b
1777         https://bugs.webkit.org/show_bug.cgi?id=50835
1778
1779         * Scripts/prepare-ChangeLog: be more explicit about -b and match file style.
1780
1781 2010-12-10  Eric Seidel  <eric@webkit.org>
1782
1783         Reviewed by Adam Barth.
1784
1785         Bugs created by the commit-queue should all block on a master bug
1786         https://bugs.webkit.org/show_bug.cgi?id=50857
1787
1788         This makes all bugs created by the commit-queue block on:
1789         https://bugs.webkit.org/show_bug.cgi?id=50856
1790
1791         In the process of testing this, I found that the existing
1792         create_bug code was wrong.  I also found that existing
1793         unit tests for create-rollout used invalid values
1794         for options.blocks.  I fixed both issues and tested.
1795
1796         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1797         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1798         * Scripts/webkitpy/tool/commands/commandtest.py:
1799         * Scripts/webkitpy/tool/commands/download_unittest.py:
1800         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1801         * Scripts/webkitpy/tool/mocktool.py:
1802         * Scripts/webkitpy/tool/steps/options.py:
1803
1804 2010-12-10  Eric Seidel  <eric@webkit.org>
1805
1806         Reviewed by Adam Barth.
1807
1808         Teach webkitpy how to follow duplicate chains when posting comments on flake bugs
1809         https://bugs.webkit.org/show_bug.cgi?id=50853
1810
1811         I also discovered when doing this that the code was posting
1812         the comment on the wrong bug, but that's fixed here too.
1813
1814         * Scripts/webkitpy/common/net/bugzilla/bug.py:
1815         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1816         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1817         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1818         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1819         * Scripts/webkitpy/tool/mocktool.py:
1820
1821 2010-12-10  Anders Carlsson  <andersca@apple.com>
1822
1823         Reviewed by John Sullivan.
1824
1825         Make WKContextGetStatistics gather global statistics
1826         https://bugs.webkit.org/show_bug.cgi?id=50850
1827
1828         Remove the code that gets the statistics and fills in the per context
1829         statistics information for now.
1830
1831         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
1832         (-[BrowserStatisticsWindowController refreshStatistics:]):
1833
1834 2010-12-10  Eric Seidel  <eric@webkit.org>
1835
1836         Unreviewed.
1837
1838         commit-queue should report port/platform information when commenting on flaky test bugs
1839         https://bugs.webkit.org/show_bug.cgi?id=50839
1840
1841         Renamed platform.py to platforminfo.py.  This broke import platform in executive.py
1842         which was only used by new run webkit tests (and clearly not unit tested).
1843
1844         * Scripts/webkitpy/common/system/platforminfo.py: Renamed from WebKitTools/Scripts/webkitpy/common/system/platform.py.
1845         * Scripts/webkitpy/tool/main.py:
1846         * Scripts/webkitpy/tool/mocktool.py:
1847
1848 2010-12-10  Eric Seidel  <eric@webkit.org>
1849
1850         Reviewed by Tony Chang.
1851
1852         commit-queue should report port/platform information when commenting on flaky test bugs
1853         https://bugs.webkit.org/show_bug.cgi?id=50839
1854
1855         This was a suggestion from Tony Chang this morning.
1856         I added a platform.py class so I could easily mock the platform call,
1857         but that may not be the final solution for this mocking.
1858         We'll try it and see.
1859
1860         * Scripts/webkitpy/common/system/platform.py: Added.
1861         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1862         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1863         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1864         * Scripts/webkitpy/tool/main.py:
1865         * Scripts/webkitpy/tool/mocktool.py:
1866
1867 2010-12-10  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>
1868
1869         Reviewed by Joseph Pecoraro.
1870
1871         Bug 43455 - [Qt]: Implement Application Cache Quotas
1872         https://bugs.webkit.org/show_bug.cgi?id=43455
1873
1874         Introduce functions to allow new appcache layout test origin-quota.html
1875         to work correctly under Qt.
1876
1877         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1878         (WebCore::DumpRenderTree::DumpRenderTree):
1879         (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
1880         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1881
1882         Introduce functions to allow new appcache layout test origin-quota.html
1883         to be successful under qt. Changes required because LayoutTestControllerQt
1884         does not inherit from LayoutController.
1885
1886         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1887         (LayoutTestController::reset):
1888         (LayoutTestController::clearAllApplicationCaches):
1889         (LayoutTestController::setApplicationCacheOriginQuota):
1890         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1891         (LayoutTestController::shouldDumpApplicationCacheDelegateCallbacks):
1892         (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
1893
1894 2010-12-10  Eric Seidel  <eric@webkit.org>
1895
1896         Reviewed by Adam Barth.
1897
1898         Move buildbot.py into its own module so we can split it out into one-file-per-class
1899         https://bugs.webkit.org/show_bug.cgi?id=50806
1900
1901         We're adding more buildbot logic these days, so it makes sense
1902         to give buildbot its own module.
1903
1904         * Scripts/webkitpy/common/net/buildbot/__init__.py: Added.
1905         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot.py.
1906         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py.
1907         * Scripts/webkitpy/common/net/failuremap.py:
1908         * Scripts/webkitpy/common/net/regressionwindow.py:
1909         * Scripts/webkitpy/tool/commands/rebaseline.py:
1910
1911 2010-12-10  Tony Chang  <tony@chromium.org>
1912
1913         Reviewed by Eric Seidel.
1914
1915         Use FileSystem::remove when cleaning up http lock files
1916         https://bugs.webkit.org/show_bug.cgi?id=50830
1917
1918         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1919
1920 2010-12-10  Joone Hur  <joone@kldp.org>
1921
1922         Reviewed by Martin Robinson.
1923
1924         [GTK] DRT needs layoutTestController.setCacheModel
1925         https://bugs.webkit.org/show_bug.cgi?id=50705
1926         
1927         webkit_set_cache_mode() is called to set the cache model.
1928         
1929         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1930         (LayoutTestController::setCacheModel): Set the cache model. 
1931
1932 2010-12-10  Tony Chang  <tony@chromium.org>
1933
1934         Reviewed by Ojan Vafai.
1935
1936         [chromium] remove --use-drt and add --use-test-shell
1937         https://bugs.webkit.org/show_bug.cgi?id=50701
1938
1939         * Scripts/webkitpy/common/config/ports.py:
1940         * Scripts/webkitpy/common/config/ports_unittest.py:
1941         * Scripts/webkitpy/layout_tests/port/chromium.py:
1942         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1943         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1944         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1945         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1946         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1947         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1948         * Scripts/webkitpy/layout_tests/port/webkit.py:
1949         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1950         * Scripts/webkitpy/style/checkers/test_expectations.py:
1951         * Scripts/webkitpy/tool/commands/queries.py:
1952
1953 2010-12-10  John Knottenbelt  <jknotten@chromium.org>
1954
1955         Reviewed by Steve Block.
1956
1957         [Chromium] Implement mocks for client-based geolocation
1958         https://bugs.webkit.org/show_bug.cgi?id=46895
1959
1960         * DumpRenderTree/chromium/LayoutTestController.cpp:
1961         (LayoutTestController::setGeolocationPermission):
1962         (LayoutTestController::setMockGeolocationPosition):
1963         (LayoutTestController::setMockGeolocationError):
1964         * DumpRenderTree/chromium/LayoutTestController.h:
1965         * DumpRenderTree/chromium/WebViewHost.cpp:
1966         (WebViewHost::geolocationClient):
1967         (WebViewHost::geolocationClientMock):
1968         (WebViewHost::reset):
1969         * DumpRenderTree/chromium/WebViewHost.h:
1970
1971 2010-12-10  Alejandro G. Castro  <alex@igalia.com>
1972
1973         Reviewed by Martin Robinson.
1974
1975         [GTK] Add hasSpellingMarker support to the DRT
1976         https://bugs.webkit.org/show_bug.cgi?id=50739
1977
1978         Implemented the hasSpellingMarker to support spelling tests.
1979
1980         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1981         (LayoutTestController::hasSpellingMarker):
1982
1983 2010-12-10  Eric Seidel  <eric@webkit.org>
1984
1985         Reviewed by Ojan Vafai.
1986
1987         webkit-patch: not possible to use build-and-test with local commits
1988         https://bugs.webkit.org/show_bug.cgi?id=33378
1989
1990         Make --no-clean not even check if we have local commits.
1991         It's unclear to me why the code was originally written this way.
1992         I was unable to dig up a reason from svn history.
1993
1994         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
1995         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
1996
1997 2010-12-10  Mario Sanchez Prada  <msanchez@igalia.com>
1998
1999         Reviewed by Martin Robinson.
2000
2001         [GTK] AX: implement isEnabled in DRT
2002         https://bugs.webkit.org/show_bug.cgi?id=50814
2003
2004         Implement AccessibilityUIElement::isEnabled() for GTK.
2005
2006         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2007         (checkElementState): New function to refactor common code.
2008         (AccessibilityUIElement::isEnabled): Implement this by checking
2009         the current state of the AtkObject.
2010         (AccessibilityUIElement::isSelected): Use the new
2011         checkElementState function.
2012
2013 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2014
2015         Reviewed by Kenneth Rohde Christiansen.
2016
2017         [Qt][WK2] Add the QWKContext API class to wrap the WebContext.
2018         https://bugs.webkit.org/show_bug.cgi?id=50750
2019
2020         * MiniBrowser/qt/BrowserView.cpp:
2021         (BrowserView::BrowserView):
2022         * MiniBrowser/qt/BrowserView.h:
2023         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2024         (WTR::WebView::WebView):
2025
2026 2010-12-10  Joone Hur  <joone@kldp.org>
2027
2028         Reviewed by Xan Lopez.
2029
2030         [GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
2031         https://bugs.webkit.org/show_bug.cgi?id=50808
2032
2033         Unskipping the following test cases:
2034         userscripts/mixed-case-stylesheet.html
2035         userscripts/simple-stylesheet.html
2036         userscripts/user-style-all-frames.html
2037
2038         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2039         (LayoutTestController::addUserStyleSheet):
2040
2041 2010-12-10  Joone Hur  <joone@kldp.org>
2042
2043         Reviewed by Eric Seidel.
2044
2045         [GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet
2046         https://bugs.webkit.org/show_bug.cgi?id=50783
2047
2048         This patch allows to unskip the following test cases:
2049         printing/page-rule-selection.html
2050         printing/page-format-data.html
2051
2052         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2053         (LayoutTestController::pageProperty): Added.
2054         (LayoutTestController::isPageBoxVisible): Ditto.
2055         (LayoutTestController::pageSizeAndMarginsInPixels): Ditto.
2056         (LayoutTestController::addUserStyleSheet): Ditto.
2057
2058 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2059
2060         Reviewed by Kenneth Rohde Christiansen.
2061
2062         [Qt] Make QtTestBrowser spawn QNAM in a secondary thread.
2063
2064         A menu allows to switch QNAM back to the same thread.
2065
2066         * QtTestBrowser/launcherwindow.cpp:
2067         (LauncherWindow::initializeView):
2068         (LauncherWindow::createChrome):
2069         (LauncherWindow::toggleThreadedQnam):
2070         * QtTestBrowser/launcherwindow.h:
2071         (WindowOptions::WindowOptions):
2072         * QtTestBrowser/webpage.cpp:
2073         (WebPage::WebPage):
2074         (WebPage::setQnamThreaded):
2075         * QtTestBrowser/webpage.h:
2076         (QnamThread::QnamThread):
2077         (QnamThread::~QnamThread):
2078         (QnamThread::networkAccessManager):
2079         (QnamThread::run):
2080
2081 2010-12-10  Martin Robinson  <mrobinson@igalia.com>
2082
2083         Reviewed by Xan Lopez.
2084
2085         [Gtk] style="font-family: courier" makes text disappear
2086         https://bugs.webkit.org/show_bug.cgi?id=47452
2087
2088         Add a test that verifies that fonts without valid charmaps are
2089         never selected.
2090
2091         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2092         (initializeFonts): Initialize DRT with our font (derived from Ahem)
2093         that has no valid charmap.
2094         * DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon: Added.
2095         * DumpRenderTree/gtk/fonts/fonts.conf: Updated settings to override users'
2096         settings which may disable selection of bitmap fonts.
2097
2098 2010-12-10  Eric Seidel  <eric@webkit.org>
2099
2100         Unreviewed.
2101
2102         The commit-queue should file bugs about flaky tests it encounters
2103         https://bugs.webkit.org/show_bug.cgi?id=50803
2104
2105         create_bug_for_flaky_test was insufficiently tested, thus buggy.
2106         Now it's tested.
2107
2108         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2109         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2110
2111 2010-12-10  Eric Seidel  <eric@webkit.org>
2112
2113         Unreviewed.  Somehow this last-minute edit didn't quite get committed.
2114
2115         The commit-queue should file bugs about flaky tests it encounters
2116         https://bugs.webkit.org/show_bug.cgi?id=50803
2117
2118         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2119
2120 2010-12-09  Eric Seidel  <eric@webkit.org>
2121
2122         Reviewed by Adam Barth.
2123
2124         The commit-queue should file bugs about flaky tests it encounters
2125         https://bugs.webkit.org/show_bug.cgi?id=50803
2126
2127         This change got a bit big.  I also added a new config.urls file
2128         because I needed to share the view_source_url code with committervalidator.py.
2129
2130         This adds a new class FlakyTestReporter which holds all the logic about
2131         reporting flaky tests to bugzilla.
2132
2133         Right now this code knows how to look up bugs for flaky tests.
2134         If it can't find a bug filed from the commit-queue, it will open a new
2135         one, ccing the relevant people and adding information about the failure.
2136
2137         It is not yet smart enough to chase down duplicate chains, or to include
2138         the actual failure diff.  But those can be added in later iterations.
2139
2140         * Scripts/webkitpy/common/checkout/api.py:
2141         * Scripts/webkitpy/common/checkout/changelog.py:
2142         * Scripts/webkitpy/common/checkout/commitinfo.py:
2143         * Scripts/webkitpy/common/config/committervalidator.py:
2144         * Scripts/webkitpy/common/config/urls.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
2145         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2146         * Scripts/webkitpy/tool/bot/flakytestreporter.py: Added.
2147         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
2148         * Scripts/webkitpy/tool/bot/irc_command.py:
2149         * Scripts/webkitpy/tool/bot/sheriff.py:
2150         * Scripts/webkitpy/tool/commands/download.py:
2151         * Scripts/webkitpy/tool/commands/queues.py:
2152         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2153         * Scripts/webkitpy/tool/comments.py:
2154         * Scripts/webkitpy/tool/mocktool.py:
2155         * Scripts/webkitpy/tool/steps/commit.py:
2156
2157 2010-12-09  Eric Seidel  <eric@webkit.org>
2158
2159         Reviewed by Adam Barth.
2160
2161         Teach webkit-patch how to search bugzilla
2162         https://bugs.webkit.org/show_bug.cgi?id=50500
2163
2164         This is a step towards teaching webkitpy how to file
2165         new bugs for flaky tests and update them when new flakes occur.
2166
2167         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2168         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2169         * Scripts/webkitpy/tool/commands/__init__.py:
2170         * Scripts/webkitpy/tool/commands/bugsearch.py: Added.
2171
2172 2010-12-09  Adam Barth  <abarth@webkit.org>
2173
2174         Reviewed by Ojan Vafai.
2175
2176         commit-queue errors out due to local commits
2177         https://bugs.webkit.org/show_bug.cgi?id=50766
2178
2179         We seem to be tripping over having local commits in the working copy a
2180         lot recently.  I don't quite fully understand what the issue is, but
2181         this patch attempts to solve the problem by adding an explicit clean
2182         step before processing a patch.  Previously, we did the cleaning as
2183         part of the apply-attachment step, so this might not actually fix the
2184         problem.
2185
2186         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2187         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2188         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2189
2190 2010-12-09  Dirk Pranke  <dpranke@chromium.org>
2191
2192         Reviewed by Ojan Vafai.
2193
2194         Make new-run-webkit-tests --lint-test-files log slightly better
2195         messages and return -1 if lint fails. Remove the
2196         'suppress_errors' keyword param to the TestExpectationsFile
2197         class, and clean up logging and exception raising for error
2198         handling. Also add more unit tests and clean up the unit test code a bit.
2199
2200         https://bugs.webkit.org/show_bug.cgi?id=50205
2201
2202         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2203         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2204         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py
2205         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py
2206         * Scripts/webkitpy/layout_tests/port/chromium.py:
2207         * Scripts/webkitpy/style/checkers/test_expectations.py:
2208         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2209
2210 2010-12-09  Tony Chang  <tony@chromium.org>
2211
2212         Unreviewed, fix for windows code.  We were catching the wrong
2213         exception in Windows.
2214
2215         * Scripts/webkitpy/common/system/filesystem.py:
2216
2217 2010-12-09  Antonio Gomes  <agomes@rim.com>
2218
2219         Reviewed by Martin Robinson.
2220
2221         [Gtk] Populate DumpRenderTreeSupportGtk (part IV)
2222         https://bugs.webkit.org/show_bug.cgi?id=48429
2223
2224         Adjust call sites of webkit_thread_count to use the DumpRenderTreeSupportGtk version now.
2225
2226         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2227         (LayoutTestController::workerThreadCount):
2228
2229 2010-12-06  Philippe Normand  <pnormand@igalia.com>
2230
2231         Reviewed by Martin Robinson.
2232
2233         [GTK] Support the Mozilla-style Fullscreen Javascript API
2234         https://bugs.webkit.org/show_bug.cgi?id=50572
2235
2236         Enable the Javascript Fullscreen support in the GtkLauncher. Also
2237         make DRT update the Chrome when the WebView settings have been
2238         reset to consistent values.
2239
2240         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2241         (resetDefaultsToConsistentValues):
2242         * GtkLauncher/main.c:
2243         (create_window):
2244         * Scripts/build-webkit:
2245
2246 2010-12-09  Koan-Sin Tan  <koansin.tan@gmail.com>
2247
2248         Reviewed by Tor Arne Vestbø
2249
2250         [Qt] run-launcher doesn't start the browser on Mac OS X 10.6
2251         https://bugs.webkit.org/show_bug.cgi?id=50742
2252
2253         check not only QtWebKit.framework/QtWebKit but also libQtWebKit.dylib
2254
2255         * Scripts/webkitdirs.pm:
2256
2257 2010-12-09  Joone Hur  <joone@kldp.org>
2258
2259          Reviewed by Martin Robinson.
2260
2261          [GTK] Support for viewport meta tag
2262          https://bugs.webkit.org/show_bug.cgi?id=45443
2263
2264          Add support for testing the viewport properties for WebKitGtk.
2265
2266          * DumpRenderTree/LayoutTestController.cpp:
2267          (dumpConfigurationForViewportCallback): Added this JS callback to set the size of the visible viewport.
2268          (LayoutTestController::staticFunctions):
2269          * DumpRenderTree/LayoutTestController.h:
2270          * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2271          (LayoutTestController::dumpConfigurationForViewport): Added this function to test the viewport properties.
2272          * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2273          (LayoutTestController::dumpConfigurationForViewport): Ditto.
2274          * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2275          (LayoutTestController::dumpConfigurationForViewport): Ditto.
2276          * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2277          (LayoutTestController::dumpConfigurationForViewport): Ditto.
2278          * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2279          (LayoutTestController::dumpConfigurationForViewport): Ditto.
2280
2281 2010-12-08  William Siegrist <wsiegrist@apple.com>
2282
2283         Reviewed by Eric Seidel.
2284
2285         Migrate buildbot.py from xmlrpc to json.
2286         https://bugs.webkit.org/show_bug.cgi?id=50647
2287
2288         * Scripts/webkitpy/common/net/buildbot.py:
2289
2290 2010-12-08  Tony Chang  <tony@chromium.org>
2291
2292         Reviewed by Eric Seidel.
2293
2294         make starting the websocket server more reliable on windows
2295         https://bugs.webkit.org/show_bug.cgi?id=50712
2296
2297         * Scripts/webkitpy/common/system/filesystem.py:
2298         (remove): Substitute method for os.remove to retry on error on Windows
2299         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2300         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Use FileSystem.remove
2301
2302 2010-12-08  Jessie Berlin  <jberlin@apple.com>
2303
2304         Reviewed by Adam Roben.
2305
2306         WebKit2: Implement WebChromeClient::exceededDatabaseQuota
2307         https://bugs.webkit.org/show_bug.cgi?id=50656
2308
2309         * MiniBrowser/mac/BrowserWindowController.m:
2310         (-[BrowserWindowController awakeFromNib]):
2311         Indicate that exceededDatabaseQuota is not implemented.
2312         * MiniBrowser/win/BrowserView.cpp:
2313         (BrowserView::create):
2314         Ditto.
2315         * WebKitTestRunner/TestController.cpp:
2316         (WTR::createOtherPage):
2317         Ditto.
2318         (WTR::TestController::initialize):
2319         Ditto.
2320
2321 2010-12-08  Antonio Gomes  <agomes@rim.com>
2322
2323         Reviewed by Martin Robinson.
2324
2325         [Gtk] Populate DumpRenderTreeSupportGtk (part III)
2326         https://bugs.webkit.org/show_bug.cgi?id=48429
2327
2328         Moved the following methods from webkitprivate.h to DumpRenderTreeSupportGtk.cpp|h:
2329         * webkit_gc_collect_javascript_objects;
2330         * webkit_gc_collect_javascript_objects_on_alternate_thread;
2331         * webkit_gc_count_javascript_objects;
2332         * webkit_web_frame_layout.
2333
2334         These were all only used by GTK+ DRT.
2335
2336         * DumpRenderTree/gtk/EventSender.cpp:
2337         (dispatchEvent):
2338         * DumpRenderTree/gtk/GCControllerGtk.cpp:
2339         (GCController::collect):
2340         (GCController::collectOnAlternateThread):
2341         (GCController::getJSObjectCount):
2342
2343 2010-12-07  Tony Chang  <tony@chromium.org>
2344
2345         Reviewed by Ojan Vafai.
2346
2347         [chromium] force NRWT to use DRT
2348         https://bugs.webkit.org/show_bug.cgi?id=50359
2349
2350         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2351
2352 2010-12-06  Sam Weinig  <sam@webkit.org>
2353
2354         Reviewed by Anders Carlsson.
2355
2356         Generalize didChangeLocationWithinPageForFrame for all same document navigations
2357         https://bugs.webkit.org/show_bug.cgi?id=50584
2358
2359         * MiniBrowser/mac/BrowserWindowController.m:
2360         (didSameDocumentNavigationForFrame):
2361         (-[BrowserWindowController awakeFromNib]):
2362         (-[BrowserWindowController didSameDocumentNavigationForFrame:]):
2363         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2364         (TestWebKitAPI::didSameDocumentNavigationForFrame):
2365         (TestWebKitAPI::TEST):
2366         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2367         (WTR::InjectedBundlePage::InjectedBundlePage):
2368         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame):
2369         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2370         * WebKitTestRunner/TestController.cpp:
2371         (WTR::TestController::initialize):
2372
2373 2010-12-06  Kinuko Yasuda  <kinuko@chromium.org>
2374
2375         Reviewed by Ojan Vafai.
2376
2377         Make TestResultsServer return 404 for non-existing results files.
2378         https://bugs.webkit.org/show_bug.cgi?id=50581
2379
2380         * TestResultServer/handlers/testfilehandler.py:
2381
2382 2010-12-06  Tony Chang  <tony@chromium.org>
2383
2384         Reviewed by Ojan Vafai.
2385
2386         [chromium] fix an assert hit in DRT
2387         https://bugs.webkit.org/show_bug.cgi?id=50575
2388
2389         This class uses WTF's RefPtr, but expects chrome's base::RefPtr
2390         semantics.
2391
2392         Otherwise, we hit ASSERTION FAILED: !m_adoptionIsRequired
2393         (third_party/WebKit/JavaScriptCore/wtf/RefCounted.h:37 void
2394         WTF::RefCountedBase::ref()).
2395
2396         * DumpRenderTree/chromium/TestWebWorker.h:
2397         (TestWebWorker::TestWebWorker):
2398
2399 2010-12-02  Ojan Vafai  <ojan@chromium.org>
2400
2401         Reviewed by Eric Seidel.
2402
2403         make webkit-patch command work when the git branch is not synced to the remote svn branch
2404         https://bugs.webkit.org/show_bug.cgi?id=50424
2405
2406         * Scripts/webkitpy/common/checkout/scm.py:
2407         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2408
2409 2010-12-06  Patrick Gansterer  <paroga@webkit.org>
2410
2411         Reviewed by Andreas Kling.
2412
2413         [WINCE] Add build system
2414         https://bugs.webkit.org/show_bug.cgi?id=50522
2415
2416         * CMakeListsWinCE.txt: Added.
2417
2418 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
2419
2420         Reviewed by Tony Chang.
2421
2422         Allow the Chromium port to have Leopard-specific baselines
2423         https://bugs.webkit.org/show_bug.cgi?id=50506
2424
2425         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2426
2427 2010-12-03  Tony Chang  <tony@chromium.org>
2428
2429         Reviewed by Kent Tamura.
2430
2431         [chromium] fix 2 bugs with inspector tests in DRT
2432         https://bugs.webkit.org/show_bug.cgi?id=50492
2433
2434         Tasks can outlive the tasklist (even when canceled) so this was
2435         causing a crash when ~WebTask() ran.  Avoid this by unregistering
2436         when a task is canceled.
2437
2438         Also fix an assert when closing devtool windows by copying some
2439         logic from test_shell.
2440
2441         * DumpRenderTree/chromium/Task.cpp:
2442         (WebTask::~WebTask):
2443         (TaskList::revokeAll):
2444         * DumpRenderTree/chromium/Task.h: Canceling a task now removes it from
2445             the tasklist (since the task can outlive the tasklist).
2446         * DumpRenderTree/chromium/TestShell.h:
2447         (TestShell::devToolsWebView):
2448         * DumpRenderTree/chromium/WebViewHost.cpp:
2449         (WebViewHost::~WebViewHost): Don't load about:blank when closing
2450             a window if the window has devtools loaded.  This avoids an
2451             ASSERT and matches test_shell.
2452
2453 2010-12-06  Alejandro G. Castro  <alex@igalia.com>
2454
2455         Reviewed by Martin Robinson.
2456
2457         [GTK] Fix GtkLauncher.c style, use webkit style
2458         https://bugs.webkit.org/show_bug.cgi?id=50542
2459
2460         * GtkLauncher/main.c:
2461         (activateUriEntryCb):
2462         (updateTitle):
2463         (linkHoverCb):
2464         (notifyTitleCb):
2465         (notifyLoadStatusCb):
2466         (notifyProgressCb):
2467         (destroyCb):
2468         (goBackCb):
2469         (goForwardCb):
2470         (create_webViewCb):
2471         (webViewReadyCb):
2472         (closeWebViewCb):
2473         (createBrowser):
2474         (createStatusbar):
2475         (createToolbar):
2476         (createWindow):
2477         (main):
2478
2479 2010-12-04  Antonio Gomes  <agomes@rim.com>
2480
2481         Reviewed by Martin Robinson.
2482
2483         [Gtk] Populate DumpRenderTreeSupportGtk (Part II)
2484         https://bugs.webkit.org/show_bug.cgi?id=48429
2485
2486         Moved more private method declared with WEBKIT_API to
2487         DumpRenderTreeSupportGtk, since they were only being used by DRT.
2488
2489         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2490         (resetDefaultsToConsistentValues):
2491         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2492         (LayoutTestController::addOriginAccessWhitelistEntry):
2493         (LayoutTestController::execCommand):
2494         (LayoutTestController::isCommandEnabled):
2495
2496 2010-12-04  Antonio Gomes  <agomes@rim.com>
2497
2498         Reviewed by Andreas Kling.
2499
2500         Removed extern webkit_web_view_set_group_name from gtk/DumpRenderTree.cpp
2501
2502         Method was removed by http://trac.webkit.org/changeset/71604
2503
2504         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2505
2506 2010-12-05  Alejandro G. Castro  <alex@igalia.com>
2507
2508         Reviewed by Xan Lopez.
2509
2510         [GTK] Fix compilation warnings reported by clang
2511         https://bugs.webkit.org/show_bug.cgi?id=50252
2512
2513         * GtkLauncher/main.c:
2514         (create_window): The create_statusbar function does not have
2515         parameters.
2516
2517 2010-12-05  Robert Hogan  <robert@webkit.org>
2518
2519         Reviewed by Andreas Kling.
2520
2521         [Qt] Zero-sized font does not yet work
2522
2523         Fix fast/text/font-size-zero.html
2524
2525         Copy other ports by setting minimumFontSize to 0 for DRT runs.
2526
2527         https://bugs.webkit.org/show_bug.cgi?id=49759
2528
2529         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2530         (WebCore::WebPage::WebPage):
2531
2532 2010-12-04  Sam Weinig  <sam@webkit.org>
2533
2534         Reviewed by Jon Honeycutt.
2535
2536         WebKit2: Need client functions to notify app when the url changes due to a fragment navigation
2537         https://bugs.webkit.org/show_bug.cgi?id=50511
2538
2539         Update tools for new didChangeLocationWithinPageForFrame client function (and changed bundle
2540         signature) and added a test for the functionality (PageLoadDidChangeLocationWithinPageForFrame.cpp)
2541
2542         * MiniBrowser/mac/BrowserWindowController.m:
2543         (didChangeLocationWithinPageForFrame):
2544         (-[BrowserWindowController awakeFromNib]):
2545         (-[BrowserWindowController didChangeLocationWithinPageForFrame:]):
2546         * TestWebKitAPI/PlatformUtilities.cpp:
2547         (TestWebKitAPI::Util::toWK):
2548         * TestWebKitAPI/PlatformUtilities.h:
2549         (TestWebKitAPI::Util::adoptWK):
2550         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2551         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: Added.
2552         (TestWebKitAPI::nullJavaScriptCallback):
2553         (TestWebKitAPI::didFinishLoadForFrame):
2554         (TestWebKitAPI::didChangeLocationWithinPageForFrame):
2555         (TestWebKitAPI::TEST):
2556         * TestWebKitAPI/Tests/WebKit2/file-with-anchor.html: Added.
2557         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2558         * TestWebKitAPI/win/copy-resources.cmd:
2559         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2560         (WTR::InjectedBundlePage::InjectedBundlePage):
2561         (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
2562         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2563         * WebKitTestRunner/TestController.cpp:
2564         (WTR::TestController::initialize):
2565
2566 2010-11-08  Antonio Gomes  <agomes@rim.com>
2567
2568         Reviewed by Martin Robinson.
2569
2570         [Gtk] Populate DumpRenderTreeSupportGtk
2571         https://bugs.webkit.org/show_bug.cgi?id=48429
2572
2573         Made the previous calls to webkit_web_frame* functions defined as private
2574         APIs in webkitprivate.h go through DRTSupportGtk.
2575
2576         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2577         (AccessibilityController::focusedElement):
2578         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2579         (dumpFramesAsText):
2580         (resetDefaultsToConsistentValues):
2581         (dump):
2582         (webViewDocumentLoadFinished):
2583         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2584         (LayoutTestController::counterValueForElementById):
2585         (LayoutTestController::pageNumberForElementById):
2586         (LayoutTestController::numberOfPages):
2587         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2588         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2589         (LayoutTestController::sampleSVGAnimationForElementAtTime):
2590         (LayoutTestController::numberOfActiveAnimations):
2591         (LayoutTestController::suspendAnimations):
2592         (LayoutTestController::resumeAnimations):
2593         (LayoutTestController::markerTextForListItem):
2594
2595 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
2596
2597         Reviewed by Tony Chang.
2598
2599         Rebaseline server: use pretty text diff output
2600         https://bugs.webkit.org/show_bug.cgi?id=50484
2601         
2602         Serve *-pretty-diff.html for text diff output.
2603
2604         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
2605         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2606         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2607         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2608
2609 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2610
2611         Unreviewed, rolling out r73302.
2612         http://trac.webkit.org/changeset/73302
2613         https://bugs.webkit.org/show_bug.cgi?id=50499
2614
2615         Causes crashes in debug LayoutTests (Requested by xan_ on
2616         #webkit).
2617
2618         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2619         (AccessibilityUIElement::AccessibilityUIElement):
2620         (AccessibilityUIElement::parentElementCallback):
2621         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2622         * DumpRenderTree/chromium/CppBoundClass.cpp:
2623         * DumpRenderTree/chromium/CppBoundClass.h:
2624
2625 2010-12-03  Sam Weinig  <sam@webkit.org>
2626
2627         Reviewed by Maciej Stachowiak.
2628
2629         Enable <a ping> for Mac/Windows/WebKit2 builds
2630         <rdar://problem/8504473>
2631         https://bugs.webkit.org/show_bug.cgi?id=50488
2632
2633         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2634         (TestWebKitAPI::TEST): Test that the default value of
2635         WKPreferencesGetHyperlinkAuditingEnabled is true.
2636
2637 2010-12-03  Chris Guillory  <chris.guillory@google.com>
2638
2639         Reviewed by Chris Fleizach.
2640
2641         Include the FrameView widget of a RenderWidget in the accessibility tree.
2642         https://bugs.webkit.org/show_bug.cgi?id=49106
2643
2644         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2645         (AccessibilityUIElement::AccessibilityUIElement):
2646         (AccessibilityUIElement::parentElementCallback):
2647         (AccessibilityUIElement::isEqualCallback):
2648         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2649         * DumpRenderTree/chromium/CppBoundClass.cpp:
2650         (CppBoundClass::getFromCppVariant):
2651         * DumpRenderTree/chromium/CppBoundClass.h:
2652
2653 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
2654
2655         Reviewed by Tony Chang.
2656
2657         Rebaseline server: organize tests by state, add dry run mode
2658         https://bugs.webkit.org/show_bug.cgi?id=50473
2659         
2660         Group tests in the menu by state, so that it's easier to see after
2661         processing the queue which failed.
2662         
2663         Add support for the --dry-run flag so that it's easier to test changes
2664         such as this (stubs out filesystem and SCM operations).
2665
2666         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2667         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2668         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2669
2670 2010-12-03  Brady Eidson  <beidson@apple.com>
2671
2672         Reviewed by Anders Carlsson.
2673
2674         Groundwork for <rdar://problem/7660733> and https://bugs.webkit.org/show_bug.cgi?id=50191
2675         WebKit2 Authentication Support
2676
2677         Keep these builds working:
2678         * MiniBrowser/mac/BrowserWindowController.m:
2679         (-[BrowserWindowController awakeFromNib]):
2680
2681         * WebKitTestRunner/TestController.cpp:
2682         (WTR::TestController::initialize):
2683
2684 2010-12-02  Mihai Parparita  <mihaip@chromium.org>
2685
2686         Reviewed by Tony Chang.
2687
2688         Rebaseline server: move existing baselines
2689         https://bugs.webkit.org/show_bug.cgi?id=50421
2690         
2691         Implement moving of existing baselines: move all files that are about
2692         to be overwriten by update baselines.
2693         
2694         Also fix a typo in the UI JS.
2695
2696         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2697         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2698         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
2699
2700 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2701
2702         Unreviewed, rolling out r73211.
2703         http://trac.webkit.org/changeset/73211
2704         https://bugs.webkit.org/show_bug.cgi?id=50450
2705
2706         Broke Chromium's "Webkit Win (dbg)(2)" bot. (Requested by
2707         yutak on #webkit).
2708
2709         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2710
2711 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2712
2713         Unreviewed, rolling out r73222.
2714         http://trac.webkit.org/changeset/73222
2715         https://bugs.webkit.org/show_bug.cgi?id=50449
2716
2717         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
2718         (Requested by yutak on #webkit).
2719
2720         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2721         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2722         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2723         * Scripts/webkitpy/layout_tests/port/base.py:
2724         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2725         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2726
2727 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2728
2729         Unreviewed, rolling out r73228.
2730         http://trac.webkit.org/changeset/73228
2731         https://bugs.webkit.org/show_bug.cgi?id=50448
2732
2733         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
2734         (Requested by yutak on #webkit).
2735
2736         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2737         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2738         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2739         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
2740         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2741
2742 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2743
2744         Unreviewed, rolling out r73231.
2745         http://trac.webkit.org/changeset/73231
2746         https://bugs.webkit.org/show_bug.cgi?id=50443
2747
2748         r73211 seemed to broke Chromium's "Webkit Win (dbg)(2)" bot.
2749         (Requested by yutak on #webkit).
2750
2751         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2752         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2753         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2754         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2755
2756 2010-12-03  David Levin  <levin@chromium.org>
2757
2758         Reviewed by Shinichiro Hamaji.
2759
2760         check-webkit-style: false positive reported for #if macro
2761         https://bugs.webkit.org/show_bug.cgi?id=48242
2762
2763         * Scripts/webkitpy/style/checkers/cpp.py: Adjusted check to avoid
2764           all preprocessor commands.
2765         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test.
2766
2767 2010-12-02  Eric Seidel  <eric@webkit.org>
2768
2769         Reviewed by Adam Barth.
2770
2771         Update the EWSTools scripts to use modern-style git repos
2772         https://bugs.webkit.org/show_bug.cgi?id=50402
2773
2774         * EWSTools/create-webkit-git:
2775         * EWSTools/start-commit-queue.sh:
2776         * EWSTools/start-queue.sh:
2777
2778 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
2779
2780         Fix Chromium Linux plugin tests by not logging
2781         unconditionally from the event handling code.
2782
2783         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2784         (handleEventX11):
2785
2786 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
2787
2788         Reviewed by Tony Chang.
2789
2790         nrwt multiprocessing - move logic back into run_webkit_tests
2791
2792         This change moves a bunch of logic that I had put into
2793         message_broker back into run_webkit_tests, in a slightly
2794         different format. WorkerMessageBroker needed to become less aware of
2795         the logic the TestRunner class uses, and more generic.
2796         Eventually the MessageBroker will only do generic messaging and
2797         thread/process-pooling, and (almost) all of the
2798         run-webkit-tests-specific logic will be moved to
2799         run_webkit_tests.py and dump_render_tree_thread.py.
2800         
2801         The biggest changes are that the Broker can now start a single
2802         worker, but the responsibility for starting all of them is pushed
2803         back to the TestRunner (Manager), and the logic for checking if
2804         the threads are done or wedged is moved back to TestRunner. We
2805         also remove WorkerMessageBroker.cleanup (not needed) and
2806         cancel_workers (they have to be cancelled individually).
2807         
2808         The  message_broker is now encapsulated inside
2809         TestRunner._run_tests(); it only needs to exist while actually
2810         running the tests.
2811
2812         Also, delete a bunch of tests in message_broker_unittest that no
2813         longer make much sense.
2814
2815         This patch depends on bug 50372.
2816
2817         https://bugs.webkit.org/show_bug.cgi?id=50374
2818
2819         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2820         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2821         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2822         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2823         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2824
2825 2010-12-02  Hayato Ito  <hayato@chromium.org>
2826
2827         Reviewed by Eric Seidel.
2828
2829         Refactor test_types's compare_output() method so that it takes a
2830         TestInput object.
2831
2832         compare_output() will need additional information included in a TestInput
2833         object to support reftests. This change is a pre-requirement of that.
2834
2835         https://bugs.webkit.org/show_bug.cgi?id=50362
2836
2837         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2838         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2839         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2840         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
2841         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2842
2843 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
2844
2845         Reviewed by Anders Carlsson.
2846
2847         Add the ability to run script on 'new' and 'paint' in the test plugin
2848         https://bugs.webkit.org/show_bug.cgi?id=50425
2849         
2850         Add "onnew" and "onpaintevent" attributes to the test plugin,
2851         so that tests can run JS at these times.
2852
2853         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2854         (pluginAllocate):
2855         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
2856         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2857         (NPP_New):
2858         (NPP_Destroy):
2859         (handleEventCarbon):
2860         (handleEventCocoa):
2861         (NPP_HandleEvent):
2862
2863 2010-12-02  Sam Weinig  <sam@webkit.org>
2864
2865         Fix Qt build.
2866
2867         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2868         (WTR::PlatformWebView::PlatformWebView):
2869
2870 2010-12-02  Sam Weinig  <sam@webkit.org>
2871
2872         Reviewed by Anders Carlsson.
2873
2874         WebKit2 Preferences should be held off the PageGroup, not the Context
2875         https://bugs.webkit.org/show_bug.cgi?id=50414
2876
2877         Update for API changes.
2878
2879         * WebKitTestRunner/PlatformWebView.h:
2880         * WebKitTestRunner/TestController.cpp:
2881         (WTR::createOtherPage):
2882         (WTR::TestController::initialize):
2883         (WTR::TestController::resetStateToConsistentValues):
2884         * WebKitTestRunner/TestController.h:
2885         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2886         (WTR::PlatformWebView::PlatformWebView):
2887         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2888         (WTR::PlatformWebView::PlatformWebView):
2889
2890 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
2891
2892         Reviewed by Tony Chang.
2893
2894         new-run-webkit-tests: minor cleanup for multiprocessing work
2895
2896         This change:
2897         * moves worker naming into TestShellThread, eliminating a
2898           parameter to the constructor and putting the responsibility in
2899           the correct place.
2900         * eliminates the _WorkerState() class in message_broker, because
2901           it turns out that state really needs to be in run_webkit_tests
2902         * renames the Broker classes to be module-private.
2903         * fixes a bunch of minor commenting and whitespace issues to
2904           make subsequent patches a bit clearer.
2905         * Adds a Port hook for default_worker_model() so that we can
2906           accomodate the potential for different worker models on
2907           different ports.
2908         * merge in the fix from 50420 for the brokenness introduced in
2909           bug 50367.
2910
2911         This patch depends on bug 50367.
2912
2913         https://bugs.webkit.org/show_bug.cgi?id=50372
2914
2915         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2916         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2917         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2918         * Scripts/webkitpy/layout_tests/port/base.py:
2919         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2920         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2921
2922 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
2923
2924         Reviewed by Tony Chang.
2925
2926         This change is a bunch of cleanup / refactoring of the file
2927         below. It moves a bunch of free functions to methods on the
2928         TestShellThread class, and restructures other methods to be
2929         closer to the structure we'll need for the multiprocessing
2930         rewrite.
2931
2932         It also makes the logic of --run-singly a *lot* easier to follow
2933         by nestling all of the separate-thread logic into a single
2934         routine.
2935
2936         There should be no semantic changes in this patch, just cleanup.
2937
2938         https://bugs.webkit.org/show_bug.cgi?id=50367
2939
2940         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2941
2942 2010-12-02  Tony Chang  <tony@chromium.org>
2943
2944         Unreviewed, rolling out r73164.
2945         http://trac.webkit.org/changeset/73164
2946         https://bugs.webkit.org/show_bug.cgi?id=50359
2947
2948         broke debugger tests on win
2949
2950         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2951
2952 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
2953
2954         Reviewed by Tony Chang.
2955
2956         Rebaseline server: add updating of baselines
2957         https://bugs.webkit.org/show_bug.cgi?id=50305
2958         
2959         Implements updating of baselines, where we copy -actual.* files over
2960         the current -expected.* files. To do this, we need a
2961         _get_actual_result_files method to get test results files and a
2962         _rebaseline_test method to actually do the file copy and SCM operation.
2963         _rebaseline_test logs output into a buffer, this is useful for both
2964         showing result in the UI and for unit tests.
2965         
2966         To make passing around of the various test environment properties
2967         (results directory, filesystem, SCM, etc) easier, add a TestConfig
2968         class for them.
2969         
2970         Moving of existing baselines is not implemented yet, this patch is big
2971         enough as it is.
2972
2973         * Scripts/webkitpy/common/system/filesystem.py:
2974         * Scripts/webkitpy/common/system/filesystem_mock.py:
2975         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2976         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2977         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
2978         * Scripts/webkitpy/tool/mocktool.py:
2979
2980 2010-12-02  Brent Fulgham  <bfulgham@webkit.org>
2981
2982         Unreviewed build fix after vcproj updates.
2983
2984         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Make sure
2985         that WIN_CAIRO is defined for this build.
2986         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Update file
2987         to reflect new 'Debug_Cairo_CFLite' and 'Release_Cairo_CFLite'
2988         (these were previously 'Debug_Cairo' and 'Release_Cairo'
2989
2990 2010-12-02  Sam Weinig  <sam@webkit.org>
2991
2992         Reviewed by Anders Carlsson.
2993
2994         WebKit2 needs API to turn on popup blocking
2995         https://bugs.webkit.org/show_bug.cgi?id=50407
2996
2997         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2998         (TestWebKitAPI::TEST):
2999         * WebKitTestRunner/TestController.cpp:
3000         (WTR::TestController::resetStateToConsistentValues):
3001
3002 2010-12-01  Tony Chang  <tony@chromium.org>
3003
3004         Reviewed by Ojan Vafai.
3005
3006         [chromium] force NRWT to use DRT
3007         https://bugs.webkit.org/show_bug.cgi?id=50359
3008
3009         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3010
3011 2010-12-02  Martin Robinson  <mrobinson@igalia.com>
3012
3013         Reviewed by Xan Lopez.
3014
3015         [GTK] DumpRenderTree has two copies of JavaScriptCore
3016         https://bugs.webkit.org/show_bug.cgi?id=49877
3017
3018         * GNUmakefile.am: Remove the second copy of JavaScriptCore from the
3019         LDADD list for DumpRenderTree.
3020
3021 2010-12-02  Sergio Villar Senin  <svillar@igalia.com>
3022
3023         Unreviewed: Added myself to list of Committers.
3024
3025         * Scripts/webkitpy/common/config/committers.py:
3026
3027 2010-12-01  Mihai Parparita  <mihaip@chromium.org>
3028
3029         Reviewed by Adam Barth.
3030
3031         build-webkit --chromium always updates DEPS and re-generates project files
3032         https://bugs.webkit.org/show_bug.cgi?id=50340
3033         
3034         Make build-webkit --chromium invoke update-webkit-chromium only when
3035         --update-chromium is passed in, so that we don't add 20 seconds to all
3036         builds.
3037         
3038         Making all invocations update was added with r61883, with the goal of
3039         making EWS bots always update. The bots will switch to using this flag
3040         (as will all other webkit-patch build steps) so nothing should change
3041         for them.
3042
3043         * Scripts/webkitdirs.pm:
3044         * Scripts/webkitpy/common/config/ports.py:
3045         * Scripts/webkitpy/common/config/ports_unittest.py:
3046
3047 2010-12-01  Dirk Pranke  <dpranke@chromium.org>
3048
3049         Reviewed by Tony Chang.
3050
3051         new-run-webkit-tests: add a --dry-run / -n flag
3052         https://bugs.webkit.org/show_bug.cgi?id=50045
3053
3054         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3055         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3056
3057 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
3058
3059         Reviewed by Adam Roben.
3060
3061         WinCairo build should not use link-time code generation (LTCG)
3062         https://bugs.webkit.org/show_bug.cgi?id=50353
3063
3064         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3065         * DumpRenderTree/win/DumpRenderTree.vcproj:
3066         * DumpRenderTree/win/ImageDiff.vcproj:
3067         * FindSafari/FindSafari.vcproj:
3068         * MiniBrowser/MiniBrowser.vcproj:
3069         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3070         * WebKitAPITest/WebKitAPITest.vcproj:
3071         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3072         * WebKitTestRunner/win/InjectedBundle.vcproj:
3073         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3074         * WinLauncher/WinLauncher.vcproj:
3075         * record-memory-win/record-memory-win.vcproj:
3076
3077 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
3078
3079         Touch GetUserAgentWithNullNPPFromNPPNew.cpp in an effort to force
3080         a rebuild of TestNetscapePlugin.la on GTK+. It seems that simply
3081         adding the file to the sources list was not enough to force the rebuild.
3082
3083         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
3084         Remove an empty line at the end of this file to force a rebuild.
3085
3086 2010-12-01  Sam Weinig  <sam@webkit.org>
3087
3088         Fix windows build.
3089
3090         * MiniBrowser/win/BrowserView.cpp:
3091         (BrowserView::create):
3092
3093 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
3094
3095         Add missing file to the TestNetscapePlugin sources list after r73057.
3096
3097         * GNUmakefile.am: Add missing file.
3098
3099 2010-12-01  Sam Weinig  <sam@webkit.org>
3100
3101         Reviewed by Anders Carlsson.
3102
3103         Add PageGrouping to WebKit2 API
3104         https://bugs.webkit.org/show_bug.cgi?id=50332
3105
3106         - Update testing harnesses to deal with new PageGroup API.
3107
3108         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3109         (WKBundleInitialize):
3110         * TestWebKitAPI/InjectedBundleController.cpp:
3111         (TestWebKitAPI::InjectedBundleController::initialize):
3112         (TestWebKitAPI::InjectedBundleController::didInitializePageGroup):
3113         (TestWebKitAPI::InjectedBundleController::initializeTestNamed):
3114         * TestWebKitAPI/InjectedBundleController.h:
3115         * TestWebKitAPI/InjectedBundleTest.h:
3116         (TestWebKitAPI::InjectedBundleTest::initialize):
3117         (TestWebKitAPI::InjectedBundleTest::didInitializePageGroup):
3118         * TestWebKitAPI/PlatformUtilities.cpp:
3119         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
3120         * TestWebKitAPI/PlatformUtilities.h:
3121         * TestWebKitAPI/PlatformWebView.h:
3122         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
3123         (TestWebKitAPI::TEST):
3124         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
3125         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
3126         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3127         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3128         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3129         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3130         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3131         (WTR::InjectedBundle::didInitializePageGroup):
3132         (WTR::InjectedBundle::initialize):
3133         (WTR::InjectedBundle::beginTesting):
3134         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3135         (WTR::InjectedBundle::pageGroup):
3136         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3137         (WTR::LayoutTestController::addUserScript):
3138         (WTR::LayoutTestController::addUserStyleSheet):
3139         (WTR::LayoutTestController::setXSSAuditorEnabled):
3140         * WebKitTestRunner/TestController.cpp:
3141         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3142         (WTR::PlatformWebView::PlatformWebView):
3143
3144 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
3145
3146         Reviewed by Adam Roben.
3147
3148         vcproj changes can't be applied cleanly by the Windows EWS bot
3149         https://bugs.webkit.org/show_bug.cgi?id=50328
3150
3151         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
3152         * CLWrapper/CLWrapper.vcproj: Modified property svn:eol-style.
3153         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
3154         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added property svn:eol-style.
3155         * DumpRenderTree/win/DumpRenderTree.vcproj: Modified property svn:eol-style.
3156         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added property svn:eol-style.
3157         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added property svn:eol-style.
3158         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added property svn:eol-style.
3159         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added property svn:eol-style.
3160         * DumpRenderTree/win/ImageDiff.vcproj: Modified property svn:eol-style.
3161         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added property svn:eol-style.
3162         * FindSafari/FindSafari.vcproj: Modified property svn:eol-style.
3163         * FindSafari/FindSafariCommon.vsprops: Added property svn:eol-style.
3164         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
3165         * MIDLWrapper/MIDLWrapper.vcproj: Modified property svn:eol-style.
3166         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added property svn:eol-style.
3167         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added property svn:eol-style.
3168         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added property svn:eol-style.
3169         * MiniBrowser/MiniBrowser.vcproj: Added property svn:eol-style.
3170         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added property svn:eol-style.
3171         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added property svn:eol-style.
3172         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops: Added property svn:eol-style.
3173         * TestWebKitAPI/win/TestWebKitAPI.sln: Added property svn:eol-style.
3174         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added property svn:eol-style.
3175         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added property svn:eol-style.
3176         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added property svn:eol-style.
3177         * WebKitAPITest/WebKitAPITest.vcproj: Added property svn:eol-style.
3178         * WebKitAPITest/WebKitAPITestCommon.vsprops: Added property svn:eol-style.
3179         * WebKitLauncherWin/WebKitLauncherWin.vcproj: Modified property svn:eol-style.
3180         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added property svn:eol-style.
3181         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added property svn:eol-style.
3182         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added property svn:eol-style.
3183         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: Added property svn:eol-style.
3184         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added property svn:eol-style.
3185         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added property svn:eol-style.
3186         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added property svn:eol-style.
3187         * WebKitTestRunner/WebKitTestRunner.sln: Added property svn:eol-style.
3188         * WebKitTestRunner/win/InjectedBundle.vcproj: Added property svn:eol-style.
3189         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added property svn:eol-style.
3190         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added property svn:eol-style.
3191         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added property svn:eol-style.
3192         * WinLauncher/WinLauncher.vcproj: Modified property svn:eol-style.
3193         * WinLauncher/WinLauncherCommon.vsprops: Added property svn:eol-style.
3194         * record-memory-win/record-memory-win-common.vsprops: Added property svn:eol-style.
3195         * record-memory-win/record-memory-win.vcproj: Modified property svn:eol-style.
3196
3197 2010-12-01  Anders Carlsson  <andersca@apple.com>
3198
3199         Reviewed by Darin Adler.
3200
3201         Return a correct user agent if NPN_UserAgent is called with a null NPP from NPP_New.
3202         https://bugs.webkit.org/show_bug.cgi?id=50336
3203
3204         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3205         Add new test.
3206
3207         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3208         (PluginTest::NPP_New):
3209         Add default implementation/
3210
3211         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3212         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp: Added.
3213         (GetUserAgentWithNullNPPFromNPPNew::GetUserAgentWithNullNPPFromNPPNew):
3214         (GetUserAgentWithNullNPPFromNPPNew::NPP_New):
3215         Get the user agent.
3216
3217         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3218         (NPP_New):
3219         Call PluginTest::NPP_New.
3220
3221         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3222         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3223         Add new files.
3224
3225         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3226         (webkit_test_plugin_new_instance):
3227         Call PluginTest::NPP_New.
3228
3229 2010-12-01  Kevin Ollivier  <kevino@theolliviers.com>
3230
3231         [wx] Build fixes after recent trunk changes.
3232
3233         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3234         (LayoutTestController::findString):
3235         * wx/build/settings.py:
3236
3237 2010-12-01  Dan Bernstein  <mitz@apple.com>
3238
3239         Reviewed by Darin Adler.
3240
3241         WebKitTestRunner needs layoutTestController.findString
3242         https://bugs.webkit.org/show_bug.cgi?id=50238
3243
3244         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added findString().
3245         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3246         (WTR::LayoutTestController::findString): Updated signature for autogenerated bindings.
3247         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
3248
3249 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
3250
3251         Try using svn:eol-style native on a vcproj file.
3252
3253         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Modified property svn:eol-style.
3254
3255 2010-12-01  Patrick Gansterer  <paroga@webkit.org>
3256
3257         Reviewed by Adam Roben.
3258
3259         [WINCE] Add WinCELauncher
3260         https://bugs.webkit.org/show_bug.cgi?id=50217
3261
3262         * WinCELauncher/main.cpp: Added.
3263
3264 2010-11-30  Benjamin Poulain  <benjamin.poulain@nokia.com>
3265
3266         Reviewed by Kenneth Rohde Christiansen.
3267
3268         [Qt] Implement layoutTestController.findString
3269         https://bugs.webkit.org/show_bug.cgi?id=50236
3270
3271         Add the missing function to the LayoutTestController.
3272
3273         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3274         (LayoutTestController::findString):
3275         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3276
3277 2010-11-30  Tony Chang  <tony@chromium.org>
3278
3279         Reviewed by Adam Barth.
3280
3281         [chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn
3282         https://bugs.webkit.org/show_bug.cgi?id=49036
3283
3284         * DumpRenderTree/chromium/LayoutTestController.cpp: Use IsNumber instead of IsInt32
3285             for CppVariants.
3286         (LayoutTestController::cppVariantToBool):
3287         (LayoutTestController::cppVariantToInt32):
3288         (LayoutTestController::setDatabaseQuota):
3289         (LayoutTestController::evaluateInWebInspector):
3290         (LayoutTestController::setMockGeolocationError):
3291
3292 2010-11-30  Eric Seidel  <eric@webkit.org>
3293
3294         Reviewed by Tony Chang.
3295
3296         update-webkit should call git fetch before git svn rebase
3297         https://bugs.webkit.org/show_bug.cgi?id=50273
3298
3299         After discussion on webkit-dev, we've decided to move the "default"
3300         git setup to pulling updates from git.webkit.org in preference
3301         to rebuilding the local svn index using git svn fetch every time.
3302
3303         This change should have no effect on people using the "old" git setup
3304         and should dramatically increase the speed of updates for those using
3305         the "new" git setup along with update-webkit.  I'm about to move the
3306         EWS and other queues over to this setup once this lands.
3307
3308         * Scripts/update-webkit:
3309
3310 2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>
3311
3312         Reviewed by Xan Lopez.
3313
3314         GTK: AX: implement press in DRT
3315         https://bugs.webkit.org/show_bug.cgi?id=36146
3316
3317         Implement AccessibilityUIElement::press() for GTK.
3318
3319         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3320         (AccessibilityUIElement::press): Implemented.
3321
3322 2010-11-29  Mihai Parparita  <mihaip@chromium.org>
3323
3324         Reviewed by Tony Chang.
3325
3326         config.webkit_base_dir returns a path with a trailing slash
3327         https://bugs.webkit.org/show_bug.cgi?id=50197
3328         
3329         config.webkit_base_dir() should return a path without a trailing slash,
3330         like all the other methods that return paths.
3331         
3332         Undoes MockFileSytem changes by r72640, since they're no longer
3333         necessary for GetBaselinesTest to pass.
3334
3335         * Scripts/webkitpy/common/system/filesystem_mock.py:
3336         * Scripts/webkitpy/layout_tests/port/base.py:
3337         * Scripts/webkitpy/layout_tests/port/config.py:
3338         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3339
3340 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
3341
3342         Reviewed by Tony Chang.
3343
3344         Rebaseline server: baseline display tweaks
3345         https://bugs.webkit.org/show_bug.cgi?id=50207
3346         
3347         Determine which baselines were used when running the tests and highlight
3348         them in the UI. Sort platform names alphabetically.
3349         
3350         Also makes the server URL be launched in the user's browser
3351         automatically.
3352
3353         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
3354         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3355         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
3356         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3357         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
3358
3359 2010-11-30  Dan Bernstein  <mitz@apple.com>
3360
3361         Reviewed by Anders Carlsson.
3362
3363         <rdar://problem/8710645> WebKitTestRunner needs layoutTestController.findString
3364         https://bugs.webkit.org/show_bug.cgi?id=50238
3365
3366         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3367         (WTR::LayoutTestController::findString): Added.
3368         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3369
3370 2010-11-30  Steve Falkenburg  <sfalken@apple.com>
3371
3372         Reviewed by Adam Roben.
3373
3374         All projects on Windows should use cmd files for build events
3375         https://bugs.webkit.org/show_bug.cgi?id=50213
3376
3377         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
3378         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Added.
3379         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Added.
3380         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
3381         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Added.
3382         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Added.
3383         * DumpRenderTree/win/ImageDiffCommon.vsprops:
3384         * DumpRenderTree/win/ImageDiffPostBuild.cmd: Added.
3385         * DumpRenderTree/win/ImageDiffPreBuild.cmd: Added.
3386         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops:
3387         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
3388         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops:
3389         * MiniBrowser/MiniBrowserPostBuild.cmd: Added.
3390         * MiniBrowser/MiniBrowserPreBuild.cmd: Added.
3391         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3392         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Added.
3393         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Added.
3394         * WebKitAPITest/WebKitAPITestCommon.vsprops:
3395         * WebKitAPITest/WebKitAPITestPostBuild.cmd: Added.
3396         * WebKitAPITest/WebKitAPITestPreBuild.cmd: Added.
3397         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
3398         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
3399         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd: Added.
3400         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd: Added.
3401         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd: Added.
3402         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd: Added.
3403         * WinLauncher/WinLauncherCommon.vsprops:
3404         * WinLauncher/WinLauncherPostBuild.cmd: Added.
3405         * WinLauncher/WinLauncherPreBuild.cmd: Added.
3406
3407 2010-11-29  Dan Bernstein  <mitz@apple.com>
3408
3409         GTK DumpRenderTree build fix after r72887.
3410
3411         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3412         (LayoutTestController::findString):
3413
3414 2010-11-29  Dan Bernstein  <mitz@apple.com>
3415
3416         Windows DumpRenderTree build fix after r72887.
3417
3418         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3419         (LayoutTestController::findString): Added empty implementation.
3420
3421 2010-11-29  Dan Bernstein  <mitz@apple.com>
3422
3423         Reviewed by Darin Adler.
3424
3425         DumpRenderTree changes for testing the text search API.
3426         https://bugs.webkit.org/show_bug.cgi?id=50038
3427
3428         * DumpRenderTree/LayoutTestController.cpp:
3429         (findStringCallback):
3430         (LayoutTestController::staticFunctions):
3431         * DumpRenderTree/LayoutTestController.h:
3432         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3433         (LayoutTestController::findString):
3434         * MiniBrowser/mac/BrowserWindowController.m:
3435         (-[BrowserWindowController find:]):
3436
3437 2010-11-29  Johnny Ding  <jnd@chromium.org>
3438
3439         Unreviewed: Add myself to the list of Committers.
3440
3441         * Scripts/webkitpy/common/config/committers.py:
3442
3443 2010-11-29  Mark Rowe  <mrowe@apple.com>
3444
3445         Reviewed by Adele Peterson.
3446
3447         <rdar://problem/8694997> DumpRenderTree fails to build.
3448
3449         * DumpRenderTree/mac/PerlSupport/Makefile: Skip generating wrappers.
3450
3451 2010-11-29  Mark Rowe  <mrowe@apple.com>
3452
3453         Reviewed by Adele Peterson.
3454
3455         <rdar://problem/8694997> DumpRenderTree fails to build.
3456
3457         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm.
3458         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c.
3459         * DumpRenderTree/mac/PerlSupport/Makefile:
3460
3461 2010-11-29  Mario Sanchez Prada  <msanchez@igalia.com>
3462
3463         Reviewed by Martin Robinson.
3464
3465         [GTK] Null-check needed in DRT's AccessibilityUIElement::allAtributes()
3466         https://bugs.webkit.org/show_bug.cgi?id=50154
3467
3468         Added missing checks to allAttributes().
3469
3470         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3471         (AccessibilityUIElement::allAttributes): Added missing checks.
3472
3473 2010-11-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3474
3475         Reviewed by Kenneth Rohde Christiansen.
3476
3477         [Qt] Allow pre-generation for package builds for WebKit2
3478         https://bugs.webkit.org/show_bug.cgi?id=50139
3479
3480         Use a build variable for the generated directory path and set the
3481         value based on CONFIG just like for WebKit1.
3482
3483         For non-package builds use a relative base path for the
3484         genrated directory just like for WebKit1.
3485
3486         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3487         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3488
3489 2010-11-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3490
3491         Reviewed by Kenneth Rohde Christiansen.
3492
3493         [Qt] Move some build logic from Qt to platform independent code
3494         https://bugs.webkit.org/show_bug.cgi?id=50134
3495
3496         Create target directories inside generate-forwarding-headers.pl.
3497
3498         * Scripts/generate-forwarding-headers.pl:
3499
3500 2010-11-24  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
3501
3502         Reviewed by Martin Robinson.
3503
3504         [GTK] Windowless plugins gets broken key input
3505         https://bugs.webkit.org/show_bug.cgi?id=49927
3506
3507         Convert the XEvent::keycode to ASCII before printing it. Not
3508         doing this was causing false positive in 
3509         plugins/keyboard-events.html.
3510
3511         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3512         (keycode_to_char):
3513         (webkit_test_plugin_handle_event):
3514
3515 2010-11-24  Jan Erik Hanssen  <jhanssen@sencha.com>
3516
3517         Reviewed by Antonio Gomes.
3518
3519         [Qt] Html autofocus not working with QGraphicsWebView
3520         https://bugs.webkit.org/show_bug.cgi?id=43169
3521
3522         Tell the scene to set the webview item as the currently
3523         focused item. This makes the input field with autofocus get
3524         focus as it should.
3525
3526         * QtTestBrowser/webview.cpp:
3527         (WebViewGraphicsBased::WebViewGraphicsBased):
3528
3529 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
3530
3531         Reviewed by Tony Chang.
3532
3533         nrwt - clean up create_driver interface and print out the
3534         command line used for DumpRenderTree/TestShell.
3535
3536         This patch adds a driver_cmd_line() call to the Port class in
3537         order to retrive the command line to print it out (as part of
3538         --print config).
3539
3540         In addition, this patch cleans up the Port.create_driver()
3541         signature and the Driver constructor interface to take a worker
3542         number and no longer require the image_path argument (Chromium's
3543         drivers now synthesize the image_path from the worker number
3544         internally).
3545
3546         https://bugs.webkit.org/show_bug.cgi?id=49934
3547
3548         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3549         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3550         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3551         * Scripts/webkitpy/layout_tests/port/base.py:
3552         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3553         * Scripts/webkitpy/layout_tests/port/chromium.py:
3554         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3555         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3556         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3557         * Scripts/webkitpy/layout_tests/port/test.py:
3558         * Scripts/webkitpy/layout_tests/port/webkit.py:
3559         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3560         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3561
3562 2010-11-24  Ojan Vafai  <ojan@chromium.org>
3563
3564         Reviewed by Tony Chang.
3565
3566         [chromium] improve memory usage for test results server and store fewer runs
3567         https://bugs.webkit.org/show_bug.cgi?id=50035
3568
3569         Store fewer runs and don't pass full files around when we only need bools.
3570         Greatly improves error rates on test-results.appspot.com.
3571
3572         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3573         * TestResultServer/handlers/testfilehandler.py:
3574         * TestResultServer/model/dashboardfile.py:
3575         * TestResultServer/model/jsonresults.py:
3576
3577 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
3578
3579         Reviewed by Tony Chang.
3580
3581         This patch implements the first part of the manager side of the
3582         Broker objects - it handles creating threads, waiting for them
3583         to complete, and running a single-threaded loop as well.
3584
3585         https://bugs.webkit.org/show_bug.cgi?id=49779
3586
3587         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3588         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3589         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3590         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3591
3592 2010-11-24  Mihai Parparita  <mihaip@chromium.org>
3593
3594         Reviewed by David Levin.
3595
3596         DRT should not generate pixel output for text/plain tests
3597         https://bugs.webkit.org/show_bug.cgi?id=50002
3598         
3599         Modify Mac, Windows and GTK DRT implementations to disable pixel output
3600         when encountering a text/plain response (the Chromium one already does
3601         this, and none of the other ports special-case text/plain output in
3602         the first place).
3603
3604         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3605         (dump):
3606         * DumpRenderTree/mac/DumpRenderTree.mm:
3607         (dump):
3608         * DumpRenderTree/win/DumpRenderTree.cpp:
3609         (dump):
3610
3611 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
3612
3613         Unreviewed.
3614
3615         Add my other email address to committers.py.
3616
3617         * Scripts/webkitpy/common/config/committers.py:
3618
3619 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
3620
3621         Reviewed by Csaba Osztrogonác.
3622
3623         Make build-webkit --minimal build with ENABLE_INSPECTOR=0
3624         https://bugs.webkit.org/show_bug.cgi?id=49975
3625
3626         * Scripts/build-webkit: Add ENABLE_INSPECTOR define to features,
3627         to enable the script to define it 0 in case of a minimal build.
3628
3629 2010-11-24  Martin Robinson  <mrobinson@igalia.com>
3630
3631         Reviewed by Xan Lopez.